memory leak when HTTP/2 codec wrapper API turned on by default

If you are reporting any crash or any potential security issue, do not
open an issue in this repo. Please report the issue via emailing
<EMAIL_ADDRESS>where the issue will be triaged appropriately.
Title: envoy keep using more memory until OOMKill after HTTP/2 codec wrapper API turned on by default
Description:

What issue is being seen? Describe what should be happening instead of
the bug, for example: Envoy should not crash, the expected value isn't
returned, etc.

When running envoy binary that includes the changes from https://github.com/envoyproxy/envoy/pull/19614
we see that envoy keeps using more memory until it gets OOMKilled.
Here's a capture of the heap profile collected using --define tcmalloc=gperftools
envoy.prof.zip
turning the feature envoy/reloadable_features/http2_new_codec_wrapper false fixes the issue
of memory leak.

For context - we saw Envoy sidecars which typically use ~300MB memory at steady-state eventually get OOMKilled after hitting their 4GB memory limit upon pulling the linked change in.

cc @alyssawilk @birenroy can you take a look at this? Should we revert the flag while we sort this out? Unfortunately I think this also went into the last release so either the revert or the fix will need to be backported. cc @oschaaf

I think we found the leak. We'll give the fix some time to bake internally before enabling the runtime feature again.

This was fixed in the QUICHE upstream repository on February 1st:
https://github.com/google/quiche/commit/6c61814256b13aa4550839653672be47c2203103
The fix was imported into Envoy on February 7th:
https://github.com/envoyproxy/envoy/commit/510319c393972f9a54d3c3bf65bf09b9174a73ec

I just had to disable this feature on my grpc service due to memory exhaustion exactly in this manner: https://github.com/envoyproxy/envoy/issues/8857
I am using envoyproxy/envoy-dev:latest, which on my server is:
envoy  version: 9ac1efc72d00a09604ddac335edf570d317b7c8c/1.22.0-dev/Clean/RELEASE/BoringSSL

The workaround I applied in config.yml:
layered_runtime:
  layers:
  - name: "static"
    static_layer:
      envoy.reloadable_features.http2_new_codec_wrapper: false

Without this configuration envoy takes unbounded memory (explodes after a few gigabytes). With this stanza in my configuration file and exactly the same synthetic test envoy's heap stays below 32 megabytes. New configuration looks like:
curl -s localhost:9901/stats | grep memory
envoy.overload_actions.reset_high_memory_stream.count: 0
server.memory_allocated: 14546920
server.memory_heap_size: 23068672
server.memory_physical_size: 24858854

which is perfectly healthy. I'm not sure this new_codec_wrapper feature is ready for v1.22

cc @alyssawilk @birenroy ^^^ I think we need to disable it again. :(

@kvcache Can you say anything about your traffic pattern? Are they long-lived gRPC streams, or short-lived?
Is there a way for me to run your synthetic test setup?
In the meantime, we'll get a PR out to default-disable the feature.

I'll describe my load pattern, and I'm happy to give you as much detail as I can but this is a production/closed-source application:

Long-lived H2 connections
New H2 stream per request (suspect this is related)
120 physical connections, confirmed via AWS NLB connection metrics
NLB just doing bare TCP routing
TLS with a letsencrypt cert on Envoy
When Envoy hits the memory limiter, if I kill the load harness envoy recovers
Envoy is a sidecar - the local service is hosted on a Unix Domain Socket

Thank you for the default-disable. If there's more helpful information I can provide you can DM me and we can figure out how to get you all the answers you need.

@diannahu did some investigation and found the likely cause. We'll have a fix upstream in QUICHE soon. Thanks for the report!


Replace split_nds with split_train_val

This PR replaces the split_nds function with a more generic split_train_val function.  This avoids having any dataset-specific split functions in the core qualx code, and pushes them to the dataset-specific plugins.
I have confirmed that this produces identical models when paired w/ a new nds.py plugin in the internal repo.
Test
Following CMDs have been tested.
Internal Usage:
python qualx_main.py preprocess
python qualx_main.py train
python qualx_main.py evaluate

@parthosa basically, some datasets require custom logic for determining train/test splits, e.g. we use a fixed/curated list of queries for NDS.  This logic is now moved to a plugin that gets loaded per this code.


-Dexec vs -D exec - Unknown lifecycle phase

Environment
Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f)
Maven home: C:\Program Files\apache-maven-3.6.3\bin\..
Java version: 11.0.6, vendor: AdoptOpenJDK, runtime: C:\Users\riniepel\AppData\Local\Programs\AdoptOpenJDK
Default locale: de_DE, platform encoding: Cp1252
OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"

Expected Behavior
All samples can be executed successfully.
Actual Behavior
One day ago we hade the discussion to change all -D exec to -Dexec in the samples.
It seems I've not tested this good enough - it results in an error:
== APP == [ERROR] Unknown lifecycle phase ".mainClass=io.dapr.examples.invoke.http.DemoService".
You must specify a valid lifecycle phase or a goal in the format <plugin-prefix>:<goal> or <plugin-group-id>:<plugin-artifact-id>[:<plugin-version>]:<goal>.
Available lifecycle phases are: validate, initialize, generate-sources, process-sources, generate-resources, process-resources, compile, process-classes, generate-test-sources, process-test-sources, generate-test-resources, process-test-resources, test-compile, process-test-classes, test, prepare-package, package, pre-integration-test, integration-test, post-integration-test, verify, install, deploy, pre-clean, clean, post-clean, pre-site, site, post-site, site-deploy. -> [Help 1]

I can change it back again but would love to get feedback from some unix user.
Steps to Reproduce the Problem

Logs
PS C:\Sources\java-sdk> dapr run --app-id invokedemo --app-port 3000 --port 3005 -- mvn exec:java -pl=examples -Dexec.mainClass=io.dapr.examples.invoke.http.DemoService -Dexec.args="-p 3000"
Starting Dapr with id invokedemo. HTTP Port: 3005. gRPC Port: 63333
You're up and running!  You must specify a valid lifecycle phase or a goal in the format <plugin-prefix>:<goal> or <plugin-group-id>:<plugin-artifact-id>[:<plugin-version>]:<goal>
.
PS C:\Sources\java-sdk> dapr run --app-id invokedemo --app-port 3000 --port 3005 -- mvn exec:java -pl=examples -D exec.mainClass=io.dapr.examples.invoke.http.DemoService -Dexec.args="-p 3000"
Starting Dapr with id invokedemo. HTTP Port: 3005. gRPC Port: 63399
You're up and running!  You must specify a valid lifecycle phase or a goal in the format <plugin-prefix>:<goal> or <plugin-group-id>:<plugin-artifact-id>[:<plugin-version>]:<goal>.
PS C:\Sources\java-sdk> dapr run --app-id invokedemo --app-port 3000 --port 3005 -- mvn exec:java -pl=examples -D exec.mainClass=io.dapr.examples.invoke.http.DemoService -D exec.args="-p 3000"
Starting Dapr with id invokedemo. HTTP Port: 3005. gRPC Port: 63419
You're up and running!        : Initializing Spring embedded WebApplicationContext
== APP == 2020-02-07 16:12:06.468  INFO 27912 --- [oService.main()] o.s.web.context.ContextLoader            : Root WebApplicationContext: initialization completed in 1406 ms
== APP == 2020-02-07 16:12:06.784  INFO 27912 --- [oService.main()] o.s.s.concurrent.ThreadPoolTaskExecutor  : Initializing ExecutorService 'applicationTaskExecutor'
== APP == 2020-02-07 16:12:07.043  INFO 27912 --- [oService.main()] o.s.b.w.embedded.tomcat.TomcatWebServer  : Tomcat started on port(s): 3000 (http) with context path ''
== APP == 2020-02-07 16:12:07.048  INFO 27912 --- [oService.main()] i.dapr.examples.invoke.http.DemoService  : Started DemoService in 2.474 seconds (JVM running for 6.852)
== DAPR == time="2020-02-07T16:12:07+01:00" level=info msg="application discovered on port 3000"
== APP == 2020-02-07 16:12:07.215  INFO 27912 --- [nio-3000-exec-2] o.a.c.c.C.[Tomcat].[localhost].[/]        Status: Running.  Waiting 5 seconds to finish outstanding operations"
== DAPR == time="2020-02-07T16:12:09+01:00" level=info msg="stop command issued. Shutting down all operations"

terminated signal received: shutting down
== APP == 2020-02-07 16:12:09.662  INFO 27912 --- [extShutdownHook] o.s.s.concurrent.ThreadPoolTaskExecutor  : Shutting down ExecutorService 'applicationTaskExecutor'
Exited Dapr successfully
Exited App successfully

https://github.com/dapr/java-sdk/issues/200 should fix this, because with that fix we won't be dapr run-ing mvn anymore.

I can change it back again but would love to get feedback from some unix user.

I don't believe this issue has ever been observed on linux, but it has on windows.  I tried to repro on a windows just now but could not.
  Was the command copied and pasted from github, or from an IDE?

@LMWF you are right - the issue only occurs on PowerShell :)

#200 is now resolved, which means mvn is not used to start examples anymore. So, this problem is not applicable.


Ability to build package locally using version instead of path.

The problem
Hi! I have a lot of crates in my workspace (40+). Let's consider 2 of them - A and B. The A's Cargo.toml specifies dep:
b = {version = "0.0.1", path = "../b"}

It's cool, works and allows for local changes and testing the package. The problem is, however, that I cannot set up CI to test if I have updated all things on crates.io. I want my CI to build the workspace but instead of using path I want it to download things from crates. I believe this functionality is already implemented because this is how cargo works when installing crates from crates.io, but it seems that there is no way to locally enable it.

https://github.com/rust-lang/cargo/issues/8415 may be of interest to you perhaps?

Can you clarify how you would like it to behave?  You can test if it builds today as-if it is version only with cargo package (this creates a temporary copy of the package with all path entries removed).  However, I would assume if you are using path dependencies, this would end up testing with older versions which may not be what you intend?  For example, if you have:
b = {version = "0.1", path = "../b"}

And the version on crates.io is 0.1.0, but the local path dependency is an unpublished 0.1.1, then it would test the wrong version (and presumably if you are relying on new APIs, wouldn't compile at all).
I guess I'm having a hard time seeing when this would be useful, since in most cases the path deps point to unpublished versions.


Cannot upload OPML from Android

OPML uploads from android are triggering the image upload dialog. Even selecting the opml/xml file does not work.
I found uploading from a OneDrive folder results in an error. Uploading the same file locally does not work.
https://podcastindex.social/<EMAIL_ADDRESS>

It seems the image upload is just what Android shows as an option when it is a non-image or video accepted file type.
Also found issues parsing XML with un-escapped characters. See #4


Show expired cert message for local cluster

What kind of request is this (question/bug/enhancement/feature request):
Feature Request
Steps to reproduce (least amount of steps as possible):
Show the message "This cluster has certs that are expiring or have expired." for the local cluster like we do for downstream custom clusters.
Result:
Message: This cluster has certs that are expiring or have expired.
Environment information

Rancher version (rancher/rancher/rancher/server image tag or shown bottom left in the UI): v2.2.8
Installation option (single install/HA): HA

Also, when rancher is starting up, it should check if the certs being used are expiring soon or already expired and print a warning message in the logs.

Fix is limited to RKE clusters, which is fine as thats all we officially support.

I've tested this feature in master-head 37363ba67 HA set up (3 nodes all roles) with a certificate expiring before 30 days as below steps

Created nodes and self signed certificate with less than 30 days expiration date.
Then ran command  rke up --custom-certs --cert-dir=custom_certs to make rke up for nodes.
Set up the HA env
The cluster API has certificate details as below.

certificatesExpiration": {
"kube-apiserver": {
"expirationDate": "2021-02-28T00:17:00Z",
"type": "/v3/schemas/certExpiration"
},
"kube-apiserver-proxy-client": {
"expirationDate": "2021-02-28T00:22:00Z",
"type": "/v3/schemas/certExpiration"
},
"kube-ca": {
"expirationDate": "2020-03-20T00:20:37Z",
"type": "/v3/schemas/certExpiration"
},
"kube-controller-manager": {
"expirationDate": "2021-02-28T00:17:00Z",
"type": "/v3/schemas/certExpiration"
},
"kube-etcd-13-58-142-13": {
"expirationDate": "2021-02-28T00:20:00Z",
"type": "/v3/schemas/certExpiration"
},
"kube-etcd-18-222-215-23": {
"expirationDate": "2021-02-28T00:21:00Z",
"type": "/v3/schemas/certExpiration"
},
"kube-etcd-18-224-2-168": {
"expirationDate": "2021-02-28T00:25:00Z",
"type": "/v3/schemas/certExpiration"
},
"kube-node": {
"expirationDate": "2021-02-28T00:18:00Z",
"type": "/v3/schemas/certExpiration"
},
"kube-proxy": {
"expirationDate": "2021-02-28T00:18:00Z",
"type": "/v3/schemas/certExpiration"
},
"kube-scheduler": {
"expirationDate": "2021-02-28T00:18:00Z",
"type": "/v3/schemas/certExpiration"
}
}

Also, warning of expiring certificate is appearing in logs.
2020/03/02 20:50:45 [INFO] Registering project network policy
2020/03/02 20:50:45 [INFO] Registering CIS controller
2020/03/02 20:50:45 [INFO] registering podsecuritypolicy cluster handler for cluster local
2020/03/02 20:50:45 [INFO] registering podsecuritypolicy project handler for cluster local
2020/03/02 20:50:45 [INFO] registering podsecuritypolicy namespace handler for cluster local
2020/03/02 20:50:45 [INFO] registering podsecuritypolicy serviceaccount handler for cluster local
2020/03/02 20:50:45 [WARNING] Certificate from local cluster will expire soon: kube-ca
2020/03/02 20:50:45 [INFO] registering podsecuritypolicy template handler for cluster local
2020/03/02 20:50:45 [INFO] Registering monitoring for cluster "local"
2020/03/02 20:50:45 [INFO] Registering istio for cluster "local"
2020/03/02 20:50:45 [INFO] Registering namespaceHandler for adding labels
2020/03/02 20:50:45 [INFO] Starting cluster controllers for local
2020/03/02 20:50:45 [INFO] Starting cluster agent for local [owner=true]
2020/03/02 20:50:45 [WARNING] Certificate from local cluster will expire soon: kube-ca
2020/03/02 20:50:45 [WARNING] Certificate from local cluster will expire soon: kube-ca
2020/03/02 20:50:46 [WARNING] Certificate from local cluster will expire soon: kube-ca
2020/03/02 20:50:46 [WARNING] Certificate from local cluster will expire soon: kube-ca

Any reason the warning message should be output 4 times in the log?

@dnoland1 It fires on cluster change and loops through everything in the rke state file, then logs when it comes across an expired cert in that. Guessing what we are seeing here is multiple firings of the controller in a row due to startup process. We can look into limiting the messages within a given time frame.

Ok, now that you explained the algorithm, makes more sense why the log appears multiple times. Not a big deal, just thought I'd raise it in case we had redundant logging in the code that could be easily cleaned up.


hack: TLS setup using cfssl

this demonstrates basic TLS setup with cfssl. it's much easier than other
available tools.

@yichengq I fixed the Procfile to run from hacks/. Does the cfssl installation work for you now?

LGTM. It works well for me.
Please ping me next time that you update the commit. github will not notify me if you don't write something.

Could you also add this method into https://github.com/coreos/etcd/blob/master/Documentation/security.md ? So people could notice this easy solution.

I will add the hook in existing docs. merging it.


Option to define the element the nodes are wrapped in a tree instead of always an a

Sadly this is a deal breaker in our case when trying to update from 1.0.0-rc3 to the latest version unless we can find a workaround to it.
In version 1 the content of the tree node was not wrapped in anything, in version 3 it gets wrapped in an a element that also has an event.preventDefault() for clicks, this completely breaks our implementation:

Checkboxes inside the node (not jsTree ones but other rendered directly in the html) are not clickable.
Labels for those checkboxes are not clickable either.
a elements inside the node are not clickable either.

Those are just some problems with one implementation, I'm sure other implementations will have similar problems with using an element that has meaning and functionality instead of one without semantic or functionality already defined (like a span).
At first I thought it was to have the ability to navigate the tree with the tab key, but then I realized that the a.jstree-anchor elements have a tabindex="-1" attribute applied, which removes that tabbing.
What is then the reasoning for using a instead of span?
Is there a way to make this wrapper a span or a div if needed?
If there isn't: why not? is this required to be an a element?

Hello,
Please read up on accessibility for trees - jsTree is implemented with visually impaired people in mind - this is the reason why anchor elements are used, and the navigation is implemented according to the WAI tree specification - using the arrow keys (and some other keys like space, enter, etc).
As for adding additional elements to the tree - create a plugin for that - just setting an HTML string as a title of the node can work, but it will require more work than adding a plugin which is the correct way to handle this. Take a look at src/misc.js for sample plugins.
By using a plugin you can render all kinds of elements (not necessarily inside the anchor node - the list item is a good option too) and can attach various events which will not affect the already attached events on the anchor nodes.
Best regards,
Ivan
P.S. v.4 (which is in the planning and experimenting phase) will likely have the draw part as a plugin, which will mean that you can easily swap out the DOM format with your own (if that is really what you need), but I doubt it will be ready before next summer.

OK, will take a look. Thank you @vakata

Hi @vakata, are there any news about that v.4 that you mentioned here? Thank you.

There is a new option in v.3 which allows you to change the default node structure:
https://github.com/vakata/jstree/pull/1616
It is already in the core, you can use it right away - create a plugin which overrides the _create_prototype_node function and activate the plugin on your instance. The author of the pull request linked above has already done this if you want to get in touch with him.
As for v.4 - it won't be available until spring. So I am not sure if it will be a good idea to wait.


Usage

Do I have to use this module with co and promises?
Thanks

Yes co/koa is required.

Ok thanks


Lock on bcolz

Hello,
Still playing with this package.
I have a question about the use of threads/locks on dataframe imports and bcolz.
Take this section of code:
def locked_df_from_ctable(*args, **kwargs):
    with lock:
        result = dataframe_from_ctable(*args, **kwargs)
    return result

I think what's happening here is that the lock prevents the dask threads from reading more than one bcolz file at a time. In my particular case, I have a file of about 7 million records in a bcolz dataset. When I just got rid of the lock... (i.e., got rid of the with lock statement and un-indented result = ..., the processing time was cut from around 90 seconds to 50 seconds. CPU usage never exceed 50%. (I presume the bottleneck was hard drive read speeds).
So what's the purpose of this lock? Is it necessary in some legacy packages? I ask because I'd like to make a PR to get rid of it. In my test, I was able to just drop it and I got the same result.
Thanks.

Historically bcolz didn't support safe concurrent reads, notably because of Blosc.  However, blosc has been seeing a fair amount of activity so we should check with the maintainers.
@FrancescAlted, does BColz safely support multiple concurrent reads?

Thanks for the super fast response.
Another question then, essentially, I'm building a tool that needs to read a large-ish file. I experimented with both bcolz and castra and found bcolz had better performance than castra with my data--even though bcolz had all the locking going on.
What I'm writing is pretty agnostic between the different things that make dataframes, but is there a preference as for what is the best tool going forward? I assumed bcolz just because castra describes itself as "experimental".
Thanks.

BColz is definitely more mature.  Castra would handle categoricals and valued-indexes better.  If BColz fits your use case I would definitely use it.

Also, per this, looks like blosc is now thread-safe since version 1.1.
https://github.com/Blosc/python-blosc/wiki/Release-notes
If you are open to a PR, let me know. Happy to build it with your blessing and guidance.

Looks like you don't need my guidance :)
I still recommend that we wait on a response from @FrancescAlted .  It may be that blosc lost thread-safe reading after 1.1.  It may also be that the version that ships with bcolz is different than what's generally released.  The history is a bit complex here.

Ok.
What I mean is that I don't want to do something that will break backwards compatibility, so we'd have to be cautious about how its written.

Hi there,
I spent some time last year looking into bcolz, dask and thread safety.
It's a bit complicated, but I'll try to distil the main points.
I believe that in general bcolz is currently not thread safe. More
discussion and reasoning is on this PR:
https://github.com/Blosc/bcolz/pull/286.
If you are only ever reading bcolz ctables from dask then it might be ok
not to lock a ctable. However, the way bcolz currently uses blosc, blosc
maintains a global lock, and so you can only ever read or write to a single
carray anyway. I.e., if dask did not use a read lock, you still would not
see any performance improvements.
Later versions of blosc (>1.7.0) have alternate "contextual" functions that
avoid the global lock. These in principle would allow a multithreaded
version of bcolz to be developed. I did some work towards this on the above
PR.
However, in the end I decided to implement something from scratch, because
my use cases involve multidimensional arrays and were pulling in a
different direction, see https://github.com/alimanfoo/zarr. In zarr I've
experimented with chunk-level locking, which should in principle allow
concurrent reads or concurrent writes to the same chunked array. However,
zarr only provides an array class and does not provide a table (dataframe)
class, so for your use case it may not be suitable.
Hth.
cc @FrancescAlted.
On Tuesday, March 8, 2016, thequackdaddy<EMAIL_ADDRESS>wrote:

Ok.
What I mean is that I don't want to do something that will break backwards
compatibility, so we'd have to be cautious about how its written.
—
Reply to this email directly or view it on GitHub
https://github.com/dask/dask/issues/1033#issuecomment-193530578.

--
Alistair Miles
Head of Epidemiological Informatics
Centre for Genomics and Global Health http://cggh.org
The Wellcome Trust Centre for Human Genetics
Roosevelt Drive
Oxford
OX3 7BN
United Kingdom
Email<EMAIL_ADDRESS><EMAIL_ADDRESS>Web: http://purl.org/net/aliman
Twitter: https://twitter.com/alimanfoo
Tel: +44 (0)1865 287721

Hi guys, thanks for bringing this to my attention.  Yeah, things are a bit complex here (I have to admit that I sometimes get confused too), so for N-time, I will try to clarify some points here.
C-Blosc 1.x (the library that is used internally by bcolz, and not python-blosc as some seem to suggest) series underwent a series of changes regarding thread safety.  The timeline is something like:

C-Blosc uses internal threads since 1.0, but that created havoc with threaded callers.

Starting with C-Blosc 1.2, a global internal lock was added.  From this version on, only one thread of the caller application was able to to run C-Blosc simultaneously (although C-Blosc still was able to run different threads internally).

In C-Blosc 1.5, the global lock was removed again and two new blosc_compress_ctx() and blosc_decompress_ctx() were added.  So, from 1.5 on, using these calls is the correct way to call C-Blosc from multi-threaded applications.

That's basically it regarding the C-Blosc multithreading evolution.  Now, it turns out that, sometime shortly after 1.5 (or even in 1.5), we introduced code that was not compatible with MS VS2008 (needed for compatibility with Python 2.6 and 2.7 on Windows).  For more info about why VS2008 is creating me trouble, see https://groups.google.com/forum/#!topic/bcolz/58qHe6gv0iU.  Frankly, I was sending this message in the hope that someone would provide a backport of recent C-Blosc to VS2008, but unfortunately that did not happen.
So we are in a position now that C-Blosc 1.5 or higher cannot be included in bcolz.  This is why I'm maintaining a C-Blosc 1.4.x branch, which is the one that I use for applications that require support for Python 2 on Windows.  In fact, I recently downgraded C-Blosc inside bcolz master to 1.4.4 precisely for this reason.
Incidentally, this discussion reminded me that it would be useful to have a bcolz 1.0.0 so that people can be sure that the format is not going to change for a long while, and this is why I recently announced bcolz 1.0.0 RC1 with C-Blosc 1.4.4 on it.  Due to the internal global lock in 1.4.4, I think this is safe to use on multi-threaded environments (so no additional lock would be needed), and the only disadvantage is that multi-threaded apps will inherit this lock and that will create contention (but again, bcolz can still use internal C-Blosc threads for accelerating compression/decompression).
Anyways, hope this helps.  And as always, if anybody is unhappy with this situation I am open to discuss on pull requests.  Thanks.

Thanks Francesc. I think it's worth adding that just because c-blosc
maintains a global lock, this does not ensure that bcolz is safe to use
in a multi-threaded application. Consider the worst case where one Python
thread is attempting to read and another write the same bcolz carray. While
each call to a c-blosc function will be mutually exclusive, at a higher
level crazy things could happen, e.g., one thread could completely erase a
carray's data while another thread was half-way through reading it. The GIL
does not prevent this sort of thing happening.
It may be safe for multiple Python threads to read from the same bcolz
carray, although again there may be unexpected things happening at the
level above c-blosc, so I would not want to put any money on it. But in any
case there would be no point, because there would be no performance gain,
because c-blosc maintains a global lock.
In general I think the safest thing is for multi-threaded applications to
maintain a lock when accessing any bcolz carray or ctable, because there is
nothing to lose and everything to gain.
Hth.
On Tue, Mar 8, 2016 at 2:20 PM, FrancescAlted<EMAIL_ADDRESS>wrote:

Hi guys, thanks for bringing this to my attention. Yeah, things are a bit
complex here (I have to admit that I sometimes get confused too), so for
N-time, I will try to clarify some points here.
C-Blosc 1.x (the library that is used internally by bcolz, and not
python-blosc as some seem to suggest) series underwent a series of changes
regarding thread safety. The timeline is something like:

C-Blosc uses internal threads since 1.0, but that created havoc with
threaded callers.

Starting with C-Blosc 1.2, a global internal lock was added. From this
version on, only one thread of the caller application was able to to run
C-Blosc simultaneously (although C-Blosc still was able to run different
threads internally).

In C-Blosc 1.5, the global lock was removed again and two new
blosc_compress_ctx() and blosc_decompress_ctx() were added. So, from 1.5
on, using these calls is the correct way to call C-Blosc from
multi-threaded applications.

That's basically it regarding the C-Blosc multithreading evolution. Now,
it turns out that, sometime shortly after 1.5 (or even in 1.5), we
introduced code that was not compatible with MS VS2008 (needed for
compatibility with Python 2.6 and 2.7 on Windows). For more info about why
VS2008 is creating me trouble, see
https://groups.google.com/forum/#!topic/bcolz/58qHe6gv0iU. Frankly, I was
sending this message in the hope that someone would provide a backport of
recent C-Blosc to VS2008, but unfortunately that did not happen.
So we are in a position now that C-Blosc 1.5 or higher cannot be included
in bcolz. This is why I'm maintaining a C-Blosc 1.4.x branch
https://github.com/Blosc/c-blosc/tree/blosc-1.4.x, which is the one
that I use for applications that require support for Python 2 on Windows.
In fact, I recently downgraded C-Blosc inside bcolz master to 1.4.4
precisely for this reason.
Incidentally, this discussion reminded me that it would be useful to have
a bcolz 1.0.0 so that people can be sure that the format is not going to
change for a long while, and this is why I recently announced bcolz 1.0.0
RC1 with C-Blosc 1.4.4 on it. Due to the internal global lock in 1.4.4, I
think this is safe to use on multi-threaded environments (so no additional
lock would be needed), and the only disadvantage is that multi-threaded
apps will inherit this lock and that will create contention (but again,
bcolz can still use internal C-Blosc threads for accelerating
compression/decompression).
Anyways, hope this helps. And as always, if anybody is unhappy with this
situation I am open to discuss on pull requests. Thanks.
—
Reply to this email directly or view it on GitHub
https://github.com/dask/dask/issues/1033#issuecomment-193801398.

--
Alistair Miles
Head of Epidemiological Informatics
Centre for Genomics and Global Health http://cggh.org
The Wellcome Trust Centre for Human Genetics
Roosevelt Drive
Oxford
OX3 7BN
United Kingdom
Email<EMAIL_ADDRESS><EMAIL_ADDRESS>Web: http://purl.org/net/aliman
Twitter: https://twitter.com/alimanfoo
Tel: +44 (0)1865 287721

Alistair, I think what you are describing is a general problem with writing and reading into the same area and it will happen either with threads or with processes.  But at any rate, I am fine with locks in software on top of bcolz; it is up to the developer to decide this.

Yikes. Feels like I opened a big can-o-worms.
I can just say this... when I removed the lock statement from the, I got what felt like the same matrix. I didn't check element by element, but the aggregate added up to the same number. Additionally, the wall time was much lower and the dask bokeh profiler do-hickey showed much less time was being used by the locked_df_from_ctable function. I'll try to reproduce and send it here. I'll also do some more robust checking of what I did.
Its also possible that I don't know how to use dask effectively and something I did slowed down the process.
Thanks.


SVG renderer misses footnotes

Steps to reproduce the problem:
Example: r2l.pdf
npm install
gulp dist-install
wget https://github.com/mozilla/pdf.js/files/2470373/r2l.pdf
node examples/node/pdf2svg.js /tmp/r2l.pdf

What went wrong?
Footnotes are missing, from page 2 to page 16, e.g.:

Fixed by #10162. Open issues already exist for gradient support.


Dead link to source

I am interested in building this on a Windows machine.
The link provided to source is dead.

hi, which link do you mean exactly?

closing due to inactivity


PropType validation errors when using custom validators

This just started happening when I updated recently, I think I was on v2.2 or 2.3 previously. I believe the issue is related to #134.
var React = require('react')
  , ImmutablePropTypes = require('react-immutable-proptypes');

var MyComponent = React.createClass({
  displayName: 'MyComponent',
  propTypes: {
    immutableObject: ImmutablePropTypes.shape({
      xyz: React.PropTypes.string
    })
  },
  render: function() {
    return <div className={this.props.immutableObject.get('xyz')} />;
  }
});

module.exports = MyComponent;

eslint-react-plugin will complain that 'immutableObject.get' is missing in props validation (react/prop-types).
As you can see, I'm using a custom validator for immutable.js classes, where the default React.PropTypes.shape does not work. I know a lot of people use the react-immutable-proptypes library, so this is going to affect quite a few people if they are also trying to lint with the latest eslint.
I like where object shape validation is going, but it should probably have a separate flag to enable/disable that feature or limit it to props defined with React.PropTypes.shape. I do not wish to turn off validator linting completely, but at the same time it is completely broken when using a custom validator.

I don't have any experience with immutable.js or react-immutable-proptypes, but I can see that the problem here come from the fact we only allow the usage of the properties defined in the shape object.
Do you have some other cases where the propTypes validation conflict with ImmutablePropTypes ?
I'm thinking to allow all methods on Map.prototype on the shape objects, do you think it can solve your problem ?

That will fix the immediate problem, but I think it is still problematic for anybody who is writing custom validators. Also, it seems somehow wrong to impose functionality from a separate third party library on a React linter. I assume the problem is because it is named shape and there is no way to know if it is React.PropTypes.shape, MyCustomValidator.shape, or even the badly spelled Raect.PropTypes.shape?
This was not a problem up through v2.5.0. What changed between v2.5 and 2.6 that this became a problem?

We support nested prop types validation since 2.6.0, so we make more checks if you define a shape, arrayOf, objectOfor oneOfType prop type.

I assume the problem is because it is named shape

Exactly.

there is no way to know if it is React.PropTypes.shape, MyCustomValidator.shape, or even the badly spelled Raect.PropTypes.shape?

Actually we can know what is preceding shape it but we do not do any check on it because we can not know what React.PropTypes or MyCustomValidator is referring to. Only the last method name is checked (here shape).

I just created an issue in the react-immutable-proptypes repo, HurricaneJames/react-immutable-proptypes#6. I think we can solve this by renaming shape to contains in ImmutablePropTypes. Looking at the eslint-plugin-react code, it appears that contains should bypass your sub-validation stuff. If I have time I might try to write something similar to shape that uses get/getIn to validate sub-props too, assuming you would be amenable to accepting such a PR?

I see no problem to accept such a PR :)


Le Donjon de naheulbeuk 2.4.1

Really sorry guys i made a little mistake in my previous PR Y_Y
updateWeapon and updateWeapons exist both so I had no visible error but right now, the wrong function is called during sheet:opened event and the weapons aren't updated and players see bad values.

Stuff happens. Do you test the sheet by yourself, or do you have others who checks things out when you work on an update? It might be a good idea in the future as a second set of eye might spot bugs that you don't. Sure have saved me a time or two.

Yes i've tested and asked for other players test.
With my pro account i create a new party with empty custom sheets and people can try the new version, but because they dont own pro account i can't let them try the update on their current game.
Sadly the bug only occur in already existing parties with already created sheet :
I've added a new attr_ witch is the sum of other existing stat (calculated by sheet worker on:change on those stats) but when you open an existing sheet, the new stat display 0 (because on:change is not triggered) wich look like a bug for players :s
this bugFix allow the sum to be calcultated on sheet:open if the attr_version < 2.4

Well, now we know a new parameter for with to test stuff in the future. 😄
I've imported character from my other campaigns into my test games but that was because I didn't want to start filling a new one, but now I have a good reason testing on filled and new sheets.


Data error

Hi
Just looking to get this up and running in a vmware lab environment and having some issues pulling data despite connecting successfully.

I've probably missed something but any info would be appreciated?
CentOS 6.8, vCenter/ESXi 6.0u2

Unfortunately I haven't tested it against anything other than ESX 5.5.  I would assume that the VMware APIs should work the same though.
The problem seems to be occurring in vmware_host.py somewhere after line 143.  My guess is that if you try running the module by itself if will output additional error information that might be helpful.

That will be it, 2 hosts in the vCenter and second one was off (lab).. everything looks good once the other host was powered up.
Thanks for coming back!! :)


Make memoryviewslice and cython.array be collections.abc.Sequence

The main reason to do this is so that they'll work in sequence
patterns in structural pattern matching in Python 3.10+.
Since the builtin "memoryview"
type and "array.array" are sequences, I think this is reasonable.

Yep, makes sense to me, too.


[Xamarin.Forms] Removing cache entries doesn't work

Description
Using default settings in Xamarin.Forms on Android with verbose logging.
Removing a cache entry doesn't do anything, it immediately reloads the image from cache.
Might be useful: I'm using the rounded transformation.
Logs:
2018-03-07T12:29:35|Debug|FFImageCacher|[MEMORY_CACHE] EntryDisplayed: DF38299541E91BF728C30B8E5284824C;375x0;transformation
2018-03-07T12:29:35|Debug|FFImageCacher|[MEMORY_CACHE] EntryNoLongerDisplayed: icn_placeholder;375x0;transformation
2018-03-07T12:29:35|Debug|FFImageCacher|[PERFORMANCE] RunAsync - NetManagedThreadId: 16, NativeThreadId: 3080, Execution: 214 ms, Key: DF38299541E91BF728C30B8E5284824C;375x0;transformation
2018-03-07T12:29:35|Debug|FFImageCacher|Remove from memory cache called for https://removed.com/removed/photo
2018-03-07T12:29:35|Debug|FFImageCacher|Remove from memory cache called for https://removed.com/removed/photo;transformation
2018-03-07T12:29:35|Debug|FFImageCacher|Remove from memory cache called for https://removed.com/removed/photo;375x0;transformation
2018-03-07T12:29:35|Debug|FFImageCacher|[MEMORY_CACHE] Cache hit from reuse pool for key: https://removed.com/removed/photo;375x0;transformation
2018-03-07T12:29:35|Debug|FFImageCacher|[MEMORY_CACHE] EntryDisplayed: https://removed.com/removed/photo;375x0;transformation
2018-03-07T12:29:35|Debug|FFImageCacher|[MEMORY_CACHE] EntryNoLongerDisplayed: DF38299541E91BF728C30B8E5284824C;375x0;transformation
2018-03-07T12:29:35|Debug|FFImageCacher|Image loaded from cache: https://removed.com/removed/photo;375x0;transformation
2018-03-07T12:29:35|Debug|FFImageCacher|[MEMORY_CACHE] Cache hit for key: https://removed.com/removed/photo;375x0;transformation
2018-03-07T12:29:35|Debug|FFImageCacher|Image loaded from cache: https://removed.com/removed/photo;375x0;transformation

Steps to Reproduce
await ImageService.Instance.InvalidateCacheEntryAsync(RemovedObject.ImageUrl, CacheType.All, true);
removedImage.Source = ImageSource.FromUri(new System.Uri(RemovedObject.ImageUrl));
Expected Behavior
The removedImage loads the image from the internet.
Actual Behavior
The removedImage shows the previously cached image.
Basic Information

Version with issue: 2.3.4
Last known good version: ???
Platform: Xamarin.Forms/Android

Extra info
I think FFImageLoading only removes the entry from the memory cache and it reloads the old entry from disk cache to memory cache. However, I tried clearing the disk cache too:
await ImageService.Instance.InvalidateDiskCacheAsync();
This didn't solve the issue.

Could you provide a repo? It's working fine for me.


New embedded DNS server doesn't answer (times out)

I have a setup with two containers and a user-defined network, which I create like this:
docker network create --driver=bridge my-net
Both containers run in this network via the "--net my-net --name my-name" command-line switch.
In Docker 1.9 they could see each other (via /etc/hosts), now in Docker 1.10 they can't (via the embedded DNS server).
When I log in to one of my containers I see this in resolv.conf:
search some.local.domain.com
nameserver <IP_ADDRESS>
options ndots:0
I can ping <IP_ADDRESS>, but it doesn't answer to DNS queries:
host www.google.com
;; connection timed out; no servers could be reached
It appears to have nothing to do with Google or Internet access, because it also times out when I look for "my-name", which is the containers own name that previously was listed in /etc/hosts, but isn't anymore.

If you are reporting a new issue, make sure that we do not have any duplicates already open. You can ensure this by searching the issue list for this repository. If there is a duplicate, please close your issue and add a comment to the existing issue instead.
If you suspect your issue is a bug, please edit your issue description to include the BUG REPORT INFORMATION shown below. If you fail to provide this information within 7 days, we cannot debug your issue and will close it. We will, however, reopen it if you later provide the information.
For more information about reporting issues, see CONTRIBUTING.md.
You don't have to include this information if this is a feature request
(This is an automated, informational response)

BUG REPORT INFORMATION
Use the commands below to provide key information from your environment:
docker version:
docker info:
Provide additional environment details (AWS, VirtualBox, physical, etc.):
List the steps to reproduce the issue:
1.
2.
3.
Describe the results you received:
Describe the results you expected:
Provide additional info you think is important:
----------END REPORT ---------
#ENEEDMOREINFO

I'm sorry, but I'm a new user. Will try to fill out the template here:
docker version:
Client:
Version:      1.10.0
API version:  1.22
Go version:   go1.5.3
Git commit:   590d5108
Built:        Thu Feb  4 19:04:33 2016
OS/Arch:      linux/amd64
Server:
Version:      1.10.0
API version:  1.22
Go version:   go1.5.3
Git commit:   590d5108
Built:        Thu Feb  4 19:04:33 2016
OS/Arch:      linux/amd64
docker info:
Containers: 1
Running: 0
Paused: 0
Stopped: 1
Images: 29
Server Version: 1.10.0
Storage Driver: devicemapper
Pool Name: docker-253:1-399605-pool
Pool Blocksize: 65.54 kB
Base Device Size: 107.4 GB
Backing Filesystem: xfs
Data file: /dev/loop0
Metadata file: /dev/loop1
Data Space Used: 6.861 GB
Data Space Total: 107.4 GB
Data Space Available: 35.95 GB
Metadata Space Used: 5.104 MB
Metadata Space Total: 2.147 GB
Metadata Space Available: 2.142 GB
Udev Sync Supported: true
Deferred Removal Enabled: false
Deferred Deletion Enabled: false
Deferred Deleted Device Count: 0
Data loop file: /var/lib/docker/devicemapper/devicemapper/data
WARNING: Usage of loopback devices is strongly discouraged for production use. Either use --storage-opt dm.thinpooldev or use --storage-opt dm.no_warn_on_loop_devices=true to suppress this warning.
Metadata loop file: /var/lib/docker/devicemapper/devicemapper/metadata
Library Version: 1.02.93 (2015-01-30)
Execution Driver: native-0.2
Logging Driver: json-file
Plugins:
Volume: local
Network: null host bridge
Kernel Version: 4.3.4-200.fc22.x86_64
Operating System: Fedora 22 (Twenty Two)
OSType: linux
Architecture: x86_64
CPUs: 4
Total Memory: 15.58 GiB
uname -a:
Linux [deleted hostname for privacy] 4.3.4-200.fc22.x86_64 #1 SMP Mon Jan 25 13:37:15 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
Environment details (AWS, VirtualBox, physical, etc.):
Physical Dell workstation.
How reproducible:
Always. My setup worked under Docker 1.9 and when I upgraded, it stopped working.
Steps to Reproduce:

docker network create --driver=bridge my-net
docker run -it --net my-net --name my-name fedora:22 /bin/bash
host my-name

Actual Results:
I am getting no answer and after a few seconds a timeout. Same happens with dig or other tools querying the DNS.
Expected Results:
Getting a DNS result.
Additional info:

This could be a duplicate of https://github.com/docker/docker/issues/20026; we've found an issue with the embedded DNS not working properly in combination with firewalld. Can you try if (temporarily) stopping firewalld solves this for you?

@realulim @thaJeztah yes this is a duplicate of #20026.

Thanks a lot for filing a detailed issue @realulim! Let's close this one and continue the discussion on #20026.

Thanks @realulim for reporting; I'll go ahead and close this one in favor of https://github.com/docker/docker/issues/20026


HTML comments can now be removed from PHP files too.

Hi, I wonder if you might considering adding my small change as it will benefit anyone that is using HTML comments inside PHP files.

Hey sure, thanks!


Add flux attribute for checking overflows

Adds a flux attribute to check overflows, similar to flux_rs::trusted (#827).

@nilehmann, I assume I should add some tests? Is there a convention to follow when adding those?
Also, for now, since I figured we would want to keep the global configuration of check_overflow, I override check_overflow in the CheckerConfig. I followed a similar approach to trusted for applying the attr to modules.
I tested on my own file (see below) and got expected results.
#[flux::check_overflow]
mod my_mod {
    fn add(x: u32, y: u32) -> u32 {
        x + y
    }

    fn add2(x: u32) -> u32 {
        x + 2
    }
}

#[flux_rs::refined_by(inner: int)]
struct MyStruct {
    #[field(u32[inner])]
    inner: u32,
}

impl MyStruct {
    #[flux::check_overflow]
    fn add1(&self) -> u32 {
        self.inner + 1
    }

    #[flux::check_overflow]
    fn add2(&self) -> u32 {
        self.inner + 2
    }
}

#[flux::check_overflow]
impl MyStruct {
    fn add3(&self) -> u32 {
        self.inner + 3
    }

    fn add4(&self) -> u32 {
        self.inner + 4
    }
}


use stronger motion confounds

currently we only include FD as a regressor by default. we should save the standard 24 motion parameters (rot/trans, rot/trans^2, and derivatives) and included those as regressors.

fixed in #24


⚠ ClamAV has degraded performance

In 982fb9c, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 196 ms

Resolved: ClamAV performance has improved in d671e02 after 5 minutes.


fix err typo, otherwise it won't be built in bazel

when building this with bazel I got
compilepkg: nogo: errors found by nogo during build-time code analysis:
/private/var/tmp/_bazel_senlu/1693ea471a90a355976fdb5d7dafa66b/sandbox/darwin-sandbox/1278/execroot/__main__/external/com_github_googlecloudplatform_compute_image_tools_daisy/workflow.go:496:9: impossible condition: nil != nil

/assign @adjackura


Add Contributing Section to Readme

Why:

When doing my first contribution I found I did not have much
direction towards what is expected from contributors.

These changes address this issue by:

Adding a contributing section to the readme
I considered other, more complex, alternatives but I believe for
now a simple section on the readme will suffice.

Issue #145 tackles another bump I found which I believe should be
solved not through documentation but through proper setup for
dev and test environments.
Closes #138

I'll be adding a reference to imagemagick to this when I get the chance.

@hgg do you still want to merge it?

@gabrielpoca I do. I'll take care of it asap.


KOGITO-3292 KNative eventing is not enabled with Quarkus Extension

https://issues.redhat.com/browse/KOGITO-3292
KNative eventing was erroneously disabled when
KOGITO-3055 Refactor Quarkus Extension (#688)
was merged

Caused by: java.io.FileNotFoundException: src/test/resources/gateway/EventBasedSplit.bpmn2 (Too many open files)

jenkins please retest this

jenkins please retest this
I don't understand this failure, it works on my machine...


Documentation error: Integrate CodeChecker with Gerrit review

The template scripts links are broken
https://github.com/Ericsson/codechecker/blob/master/docs/jenkins_gerrit_integration.md#template-scripts-
there are no such scripts anymore.
In this section we describe
https://github.com/Ericsson/codechecker/blob/master/docs/jenkins_gerrit_integration.md#execute-shell-
CodeChecker cmd diff
-b clangsa_checkers-merge
--url your_baseline_url
-n cc_reports
--new
-o html gerrit
-e $JENKINS_HOME/userContent/$JOB_NAME/$BUILD_NUMBER
But the -o does not have "html gerrit" parameter??

@dkrup This feature was implemented in #2427. It will be available on the next CodeChecker release or in the master branch of the CodeChecker repository.


Blobstore2

Add a servlet to handle file uploads. Alter data servlet to handle images as part of comments. Add relevant html and js support.

Note: blobstore url servlet was copied exactly from examples/hello-world-fetch


name in bower.json should match registered name

This is so you can go bower link d2l-navigation and have it actually work. :)

Thanks @dlockhart!


Support linux-arm

Is your feature request related to a problem? Please describe.
I wanted to install the extension on my chromebook, which has an arm7l-cpu.
Describe the solution you'd like
linux-arm is supported
Describe alternatives you've considered
none
Additional context
I suspect that supporting a new architecture can be a lot of work (can also be
easy, I know). Since I do not know how important this extension is too me, I
cannot put extra pressure. I think it would be neat to have it run on arm in
linux.

it technically is on arm on linux, just 64 bit arm right now as you can see from the latest release.   I'll open a PR shortly.

Thank you this.
(Written from inside gh-dash on my arm-chromebook)
I can now work better from the CLI.


Update for Scala 3.3.3 and 2.12.19

Sorry this is too messed up. I'll try again from fresh, or let someone else do it.


Added [Jitpack] Downloads Counter

See #3220 for example badges.

Messages

:book:
:sparkles: Thanks for your contribution to Shields, @erayerdin!

  Generated by :no_entry_sign: dangerJS against a7f7aa8c200575cd67024ed55b45d14e2c88855c

Sorry @calebcartwright, I just forgot about those square brackets even though I've read about them in the documentation somewhere. :stuck_out_tongue_closed_eyes:

No worries!

Deployed to review app @ https://shields-staging-pr-3221.herokuapp.com/

I will do a couple more changes, wait for it.

I think that's all the changes I can do. Btw, latest fails happened because Jitpack API today have some issues I think. There were times that I couldn't reach it. Is it possible to start the circleci tests again?

The existing Shields Jitpack Version badge is going to have to be updated for the reasons we discussed above. As such, I don't want to replicate those problematic pieces and solutions in this new Jitpack Downloads badge (nor any potential other future Jitpack badges). We should build this new badge the way we want, and update the version badge to match it accordingly.
For the moment, let's set aside the existing version badge/pretend like it doesn't exist. If this Jitpack Downloads badge was the very first Jitpack badge, what do you think is the best badge-creating experience for Jitpack users @erayerdin? (don't worry about the code yet, just the user experience).
Would it be something like this, where the user specifies his/her VCS type, then username, then repo?

Or would it be the user specifying his/her group id and artifact id?

Or something else entirely?

Would it be something like this, where the user specifies his/her VCS type, then username, then repo?

I thought it is a great idea, yet I somehow wondered if some usernames are rendered differently. Like, usernames like below:

some-bogus-user
someBogusUser
_someBogus-user123
123Some-Bogususer

...are valid usernames but some of these are not valid groupIDs and some are not convenient. So I've just sent an email to Jitpack about how they render such usernames and waiting for their reply. Let's decide on this after I get the reply from Jitpack.

I like the idea of making it work with user / repo, and encoding that understanding into the service. Combined with a way to auto-detect jitpack, it could make it easier to suggest relevant badges given a repo, which is something I'd like to do as part of an improved frontend.
We could also support /jitpack/dm/group/com.github.jitpack/maven-simple, to handle difficult-to-encode usernames. "group" is not really a "vcs" though it doesn't seem the end of the world to shoehorn that in.

Sorry, I've been busy for a week and seems like I've found a little while that I can continue implementing this feature.
I'm quoting the reply I've got:

Is there any case that username in "groupID" and username in Github/Bitbucket/Gitlab are different?

They will always be the same. We don't change the groupID even if the username is  invalid, as you say.

So, I think the implementation below would be great for user experience:

Now, is it OK if I implement this to both JitpackVersion and JitpackDownloads? Or should I just implement this to only JitpackDownloads?

@erayerdin

Sorry, I've been busy for a week and seems like I've found a little while that I can continue implementing this feature.

I'm quoting the reply I've got:

No worries, thanks for confirming and sharing!

Now, is it OK if I implement this to both JitpackVersion and JitpackDownloads
Yes, please go ahead and update both service classes accordingly

calebcartwright closed this just now

Oops! hit the wrong button apologies

For the redirector service to maintain compatibility with the old version badge paths:
'use strict'

const { redirector } = require('..')

module.exports = [
  redirector({
    category: 'version',
    route: {
      base: 'jitpack/v',
      pattern: ':groupId/:artifactId',
    },
    transformPath: ({ groupId, artifactId }) => `/jitpack/v/github/${groupId}/${artifactId}`,
    dateAdded: new Date('2019-03-31'),
  }),
]

Okay, I did some changes but there're some things to say.
About Download Endpoint of JitPack's API
JitPack's download endpoint seems to be quite problematic especially the last couple of days. I have many problems accessing it. So, if you see some CI processes fail, that might be because JitPack does not respond in time. It is highly likely that they deal with issues on weekdays. So, if CI fails, try Monday afternoon again.
New Endpoints
These are patterns:

/jitpack/:vcs(github|bitbucket|gitlab)/:user/:repo for version.
/jitpack/:period(dw|dm)/:vcs(github|bitbucket|gitlab)/:user/:repo for downloads

About Redirecting
I am really amazed and happy to see this feature in the codebase, really useful. Now, the pattern below:

/jitpack/v/:groupId/:artifactId

redirects to the new pattern.
While the old badge was clearly mentioning groupId, it was not a real groupId in terms of Java. You can check out what I'm currently using here.
Normally, com.github.erayerdin is a real groupId, but in shields, only username was used. In short, I just made some minor changes regarding to what you have suggested here.

Excellent! I'll take another pass through this tomorrow, but just want to make sure the new path for the Version badge will include the v for version correct?
/jitpack/v/:vcs(github|bitbucket|gitlab)/:user/:repo

No it doesn't. I thought we would agree on base URL to be /jitpack/ for
both. I can change it though to /jitpack/v and /jitpack/d if you think that
would be more proper.
On Mon, Apr 1, 2019, 04:55 Caleb Cartwright<EMAIL_ADDRESS>wrote:

Excellent! I'll take another pass through this tomorrow, but just want to
make sure the new path for the Version badge will include the v for
version correct?
/jitpack/v/:vcs(github|bitbucket|gitlab)/:user/:repo
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/badges/shields/pull/3221#issuecomment-478409928, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ACSbbNM3FTGYXLVp0kHoqFB6Tu3pf81Jks5vcWcggaJpZM4b9RTU
.

Let me have a look at the Pypi stats (mostly because I'm more familiar with Python rather than Java) and have a decision.

I have done everything I can and tests seem to pass, but I still, still get this badge:

/api/stats/com.github.USER/REPO does not respond and fails with timeout (yet the tests somehow magically passed). I have tried to contact @jitpack with every possible way I can, via email, Twitter, Gitter and so on, but they seem to be unresponsive.
So, my suggestion is to let this PR wait because /api/stats of JitPack API is, from what I can see, far from stable. And by wait, I mean for a long time, maybe a month, until I consider the /api/stats is stable.
During this time, I can consider whatever you (@calebcartwright) and the community suggest and apply them.

Both the pypi version badge, and npm version badge include the v prefix. Our badges follow a standard route format that includes the service name (be it pypi, npm, jitpack, etc.) along with the type of badge that is (downloads, versions, license, etc.)
pypi version: https://img.shields.io/pypi/v/pytest.svg (note /pypi/v/...)
npm version: https://img.shields.io/npm/v/mocha.svg (note /npm/v/...)
When a service makes download counts available for different time periods, the badge identifier uses a d* prefix (like dt for total downloads, dw for weekly, etc.)
For example with npm downloads badge:
https://img.shields.io/npm/dt/mocha.svg (note /npm/dt/...)
And when services don't provide downloads in different time intervals, the badge routes will simply use a d or sometimes the more verbose downloads.
For example with the VS Marketplace downloads badge:
https://img.shields.io/visual-studio-marketplace/d/swellaby.rust-pack.svg (note /visual-studio-marketplace/d/...)

/api/stats/com.github.USER/REPO does not respond and fails with timeout

Agreed that we need to wait on this. It does not make sense to deploy this new badge given the current state of the API

Both the pypi version badge, and npm version badge include the v prefix.

Sorry, I didn't see that. Then I will make regarding changes to JitpackVersion.

Sorry, I didn't see that. Then I will make regarding changes to JitpackVersion.

No worries!

And by wait, I mean for a long time, maybe a month, until I consider the /api/stats is stable.

Given the instability in that, what do you think about moving all the changes for JitpackVersion into a separate PR that we can go ahead and merge? We can then leave this PR to handle Downloads and come back to it once the API it uses has stabilized

what do you think about moving all the changes for JitpackVersion into a separate PR

Well, that would be pretty great. The thing is, I don't know if there's a way to separate jitpack.service.js and related other JS files to another branch.

@erayerdin - I'm going to close out this PR for now. Once the API has stabilized we can re-open this.

I've been testing the endpoint for a long while now and it seems it is stabilized enough. I will rebase my fix/jitpack-version branch and will push some changes.

@erayerdin awesome! Feel free to reopen this PR or open a new one (whichever's more convenient for you)  and I'll be happy to take a look

I think I will do this with a seperate branch and PR since it seems I messed up my merging process. Dammit. :laughing:


Correct link to release notes in Releases

The current link is a redirect which works on some devices but not all (at least GitHub mobile).
Seems like this is set in some configuration outside this repository?
The link in releases is: https://github.com/Azure/azure-docs-cli/blob/master/docs-ref-conceptual/release-notes-azure-cli.md
Should be: https://github.com/MicrosoftDocs/azure-docs-cli/blob/main/docs-ref-conceptual/release-notes-azure-cli.md

@jiasli for awareness

Thank you. I'll fix this.


Use the same states variable in the pr count and pr data queries

Since we're passing states into the count query, does it make to sense to use the same states variable in this query to ensure the same states are passed into the count & the getPullRequestData queries.
Originally posted by @adrielp in https://github.com/liatrio/liatrio-otel-collector/pull/77#discussion_r1307631699

For this I don't think it makes sense just because the reason the state variable exists in the count query is so that we can get the open and merged pr count individually with the same function.  We wouldn't be passing a shared variable between them or the getPullRequestData query since there we want both merged and open.

Are we saying that we run the getPullRequestCount two times? one per state and assign them to different metric values?

Closing this as done


PDP doesn't select the variant based on the URL

Type: major
Describe the bug
PDP page does not respect the selected variant from the URL for both the SSR rendered app nor the browser.

SSR page has no variant selected.
Browser app always selects the first variant/option

For example, the price doesn't show up, because a variant needs to , and any selected variants aren't selected.
To Reproduce

Go to a PDP page
See that the price / compare at price , and options (if available) are not visible or selected for a split second
After a second, things pop after the browser app executes the selection of the initial variant

Go to The URL http://localhost:4050/product/light-up-high-tops/cmVhY3Rpb24vY2F0YWxvZ1Byb2R1Y3RWYXJpYW50OkRYQmtKTkdlV01IMlFxZVRl
See that Black / 7 is selected, however... That URL is for Red / 8`

Expected behavior

Left: SSR page has no variant selected so it's missing the price and focus ring around the top variant
Right: Im the browser the first variant is selected

PDP page should select the variant provided by the URL for both the SSR page and browser app.
Screenshots

Desktop (please complete the following information):

OS: MacOS Mojave
Browser Chrome
Version 69.0.3497.100

Fixed in https://github.com/reactioncommerce/reaction-next-starterkit/issues/321

I don't see a PR that closes this issue. #321 is just a duplicate issue


Nuget should advertise its own location

Describe the bug
Using a cppwinrt project with applocal, build fails due to PkgMicrosoft_ProjectReunion not being defined.  The docs describe how to work around this in cs, but solution does not work for cpp.  Reunion should set its announce its location similar to how cppwinrt does with CppWinRTPackageDir.
Steps to reproduce the bug

Create a cppwinrt project with Project Reunion
Make it applocal by adding the ProjectReunionInApp.props and .targets files.
Build

Expected behavior
Build succeeds
Version Info
0.8.1-20210706.4.CI

This is not a valid issue anymore in WinAppSDK 1.6, hence closing the issue.


feat: supports other components

Such as requestBodies and parameters
Allows to parse openapi of RBAC

Codecov Report

Merging #78 (b280ec8) into master (766c6cb) will decrease coverage by 0.02%.
The diff coverage is 92.00%.

@@            Coverage Diff             @@
##           master      #78      +/-   ##
==========================================
- Coverage   88.81%   88.79%   -0.03%
==========================================
  Files          60       60
  Lines         930      937       +7
  Branches      163      184      +21
==========================================
+ Hits          826      832       +6
- Misses        104      105       +1

Impacted Files
Coverage Δ

...es/insights-common-typescript/src/types/Filters.ts
16.66% <ø> (ø)

...escript/src/hooks/usePrimaryToolbarFilterConfig.ts
91.95% <91.66%> (-0.55%)
:arrow_down:

...n-typescript/src/components/Modals/DeleteModal.tsx
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 094bf6f...b280ec8. Read the comment docs.


[BACKPORT][BUG] Error inspecting backup config

Backport https://github.com/longhorn/longhorn/issues/3402

Validated on v1.2.x-head 12/15/2021
Validation - Pass
No such logs are seen now.


How to integrate own layout?

waiting for your reply thank you

private MetaData data;

RichPreview richPreview = new RichPreview(new ResponseListener() {
    @Override
    public void onData(MetaData metaData) {
        data = metaData;

        //Implement your Layout
    }

    @Override
    public void onError(Exception e) {
        //handle error
    }
});

Thank you very much i got the solution

sir how to set link in this case?

sir how to set link in this case?

RichPreview.getPreview(url);


When using fastexcel to read Excel files, empty rows are automatically ignored by default

When using fastexcel to read Excel files, empty rows are automatically ignored by default, which can create significant issues. It would be beneficial to provide an optional parameter to adjust this behavior.

It is somewhat unlcear if the issue has been closed becase it has been fixed or for some other reason, while the issue still exists (version 0.9.1)


20200423 change #2: For security purpose, added a note to specify that clicintattr.mode can only be set to a privilege level that is equal to or lower than the currently running privilege level

Draft 20200423 – separating multiple changes as individual issues to enable change tracking/approval from draft-20200423 doc upload.
20200423 change #2: For security purpose, added a note to specify that clicintattr.mode can only be set to a privilege level that is equal to or lower than the currently running privilege level
In section 3.6: "For security purpose, the mode field can only be set to a privilege level that is equal to or lower than the currently running privilege level."

This change closed issue #53.
Additional question remains what modes can see/modify CLICCFG can be tracked in issue #57.
Closing here.


Dockerfile error and suggested updates.

I amended the Dockerfile, and created a pull request for:

Base container amended to CUDA 10.1 from 10.0
Specified Python3 versions of libraries in installations as not always installed by default.
Added "-y" to TensorRT install 'apt-get install' commands as Docker build failed on unattended installation.

@MurrayData numbers 1 and 3 are taken care of, but I am not understanding number 2. It installs miniconda: python 3.7 by default. Can you please provide more detail?

It was my set up @joehoeller, now fixed.

@MurrayData  - Thanks for pointing out the other errors though. If you catch anything else please do let me know. Can I consider this issue closed then? (Please advise).


Remove requirement for DOCKER_HOST / DOCKER_IP env vars to be set on Linux

Docker Maven Plugin can now talk to the Docker daemon socket. Therefore, there's no longer any need to be exposing the daemon REST API to make things work on Linux.

Turns out these variables are used for other things so lets keep them for now.


issue #1272 - simplify searchParameter configuration

Initially we made each searchParameter its own object so that we could
add additional properties for issue #1351.
However, now we don't think that any additional fields are needed and so
we can simplify the config to be a simple map of SearchParameter  code
-> SearchParameter.url
This format will give us the flexibility of overriding a SearchParameter
code for a given resource type for a given deploy. However, currently
the code from the config is not used...it will only use the url and it
will auto-resolve any conflicting codes.
Signed-off-by: Lee Surprenant<EMAIL_ADDRESS>

However, currently the code from the config is not used...it will only use the url and it
will auto-resolve any conflicting codes.

I wonder if for clarity/consistency if the "code" was required to match the "code" of the SearchParameter pointed to by the URL. Perhaps we should add that in a follow-on PR.

I wonder if for clarity/consistency if the "code" was required to match the "code" of the SearchParameter pointed to by the URL. Perhaps we should add that in a follow-on PR.

Good thought.  Eventually I don't want to require them to match because we want to enable overriding the one in the SearchParameter with the one in the config.  However, since thats a bigger lift, I think its worth seeing if there's an easy way to add the validation check you describe to this PR.  Looking...


[Bug Report] crash after type command 'exit'

Environment
Windows build number:  10.0.18917.1000
Windows Terminal version: commit 315abf6fa6e096f0ad8ba7db68fa8a3fd9a591b1

Steps to reproduce

start Terminal application
run some commands in the prompt
run command exit

Expected behavior
Simply exit shell.
Actual behavior

Run exit command straightly didn't cause a crash, but it will happen after run any other command. It happens in all the default PowerShell, cmd, WSL profiles.
the profiles JSON file's modifications are:
--- profiles.old.json	2019-06-15 17:07:10.565458400 +0800
+++ profiles.json	2019-06-15 17:07:06.089459800 +0800
@@ -1,10 +1,10 @@
 {
     "globals" :
     {
-        "alwaysShowTabs" : true,
+        "alwaysShowTabs" : false,
         "defaultProfile" : "{61c54bbd-c2c6-5271-96e7-009a87ff44bf}",
-        "initialCols" : 120,
-        "initialRows" : 30,
+        "initialCols" : 80,
+        "initialRows" : 24,
         "keybindings" :
         [
             {
@@ -199,28 +199,28 @@
         ],
         "requestedTheme" : "system",
         "showTabsInTitlebar" : true,
-        "showTerminalTitleInTitlebar" : true
+        "showTerminalTitleInTitlebar" : false
     },
     "profiles" :
     [
         {
-            "acrylicOpacity" : 0.5,
-            "background" : "#012456",
+            "acrylicOpacity" : 0.30000001192092896,
+            "background" : "#282C34",
             "closeOnExit" : true,
-            "colorScheme" : "Campbell",
+            "colorScheme" : "One Half Dark",
             "commandline" : "powershell.exe",
             "cursorColor" : "#FFFFFF",
             "cursorShape" : "bar",
-            "fontFace" : "Consolas",
+            "fontFace" : "Sarasa Term SC",
             "fontSize" : 10,
             "guid" : "{61c54bbd-c2c6-5271-96e7-009a87ff44bf}",
             "historySize" : 9001,
             "icon" : "ms-appx:///ProfileIcons/{61c54bbd-c2c6-5271-96e7-009a87ff44bf}.png",
             "name" : "Windows PowerShell",
-            "padding" : "0, 0, 0, 0",
+            "padding" : "4, 4, 4, 4",
             "snapOnInput" : true,
             "startingDirectory" : "%USERPROFILE%",
-            "useAcrylic" : false
+            "useAcrylic" : true
         },
         {
             "acrylicOpacity" : 0.75,

I can confirm this problem as well.. Whenever the shell exits for some reason, the app becomes totally unresponsive without any modification to the file profiles.json

I think this is the same as #1250.

Yeah, it looks like a dupe.

Confirmed resolved, lastest commit 440bee0e4abd0a778cbdff5b86f73fb34a92f3ed.


Could you please provide the data corresponding to the figures of of experiments in the paper——PETS? Because we would like to like cite PETS as one of the state of the art work in our paper, but time is limited. Thank you![Feature Request]

🚀 Feature Request

Motivation
Is your feature request related to a problem? Please describe.

Pitch
Describe the solution you'd like

Describe alternatives you've considered

Are you willing to open a pull request? (See CONTRIBUTING)
Additional context
Add any other context or screenshots about the feature request here.

Hi @curiosityoftiane. Are you referring to the original PETS paper? Note that this repository was not the one used to write that paper.


Do not clear balance on EXECUTED_MULTISIG_TRANSACTION

The EXECUTED_MULTISIG_TRANSACTION might affect the balance of the safe (native token or otherwise). We already handle the events for incoming and outgoing tokens, so we should rely on those to invalidate the balance instead.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.06%) to 92.079%

Totals

Change from base Build<PHONE_NUMBER>:
0.06%

Covered Lines:
4126

Relevant Lines:
4372

💛  - Coveralls


add generic tolerations to controler-manager manifest

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Thi PR add a generic tolerations to controler-manager manifest, so the controller-manager pod can be schedule to certain nodepool that have such taints
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?

NONE

@ahg-g  PTAL

/ok-to-test

Ok, we reached a conclusion
/close
Feel free to take the documentation issue.


Executor cores  always need to be + positive integer

executor:
cores 0.5
coresrequest: 0.5
this would give error. Is this expected. Does that mean we cannot run multiple executor in a core like we do for many other applications where we give cpu slices. instead of entire vcpu.

Yes, this is expected. cores is translated to spark.executor.cores, which only takes integer values. coreRequest can take fractional value and is translated to the cpu request for executors. If you want to share cpus among executors running on the same node, you can set coreRequest to a fractional value smaller than 1.

Closing this and feel free to reopen if you have additional questions.


Estimate value of collected Kingdom resources

On resource collection, will estimate the value of collected resources.

Made requested changes.

The loot tracker now displays miscellania loot


chore: Update Prisma

Update Prisma to 2.27

Codecov Report

Merging #100 (91c2363) into main (67ce824) will not change coverage.
 Consider uploading reports for the commit 0088f88 to get more accurate results

@@           Coverage Diff           @@
##             main     #100   +/-   ##
=======================================
  Coverage   45.26%   45.26%
=======================================
  Files          28       28
  Lines         433      433
  Branches       85       85
=======================================
  Hits          196      196
  Misses        217      217
  Partials       20       20

🖖🏻 Any news on this one ? Tests seems to crash due to pr package name/version

:tada: This PR is included in version 1.0.0 :tada:
The release is available on:

npm package (@next-major dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


[L2] Optimism support

Overview
Backend is now ready to support the Optimism chain.
Once #2630 is complete, Optimism should work out of the box.
Requirements

Prepare test data for Optimism testing ( assigned to Liliya):

[x] native coins
[x] Deploy contracts:
- mint ERC20
- mint ERC721
- mint Decoding testing contract

Verify that  points from Adding network doc are done  ( Franco - web app related stuff, Jago - safe apps related stuff on a new network)

[x] https://docs.google.com/document/d/1xKAMmxcasXLZlt_vWwNPdM-F-xtGJiT4ehiL2jamzyk/edit?usp=sharing

Run full regression on the Optimism ( assigned to Franco)

Note
No static config. To start testing the #2630 should be done to get chain info from config-service

Can be tested on staging environment via: https://safe-client.staging.gnosisdev.com/v1/chains/10

Verified on prod before Christmas


Support imginn.com/imginn.org

Any possibility to add imginn.com&imginn.org support to extract the instagram images&videos download links due to the reason instagram always banned account. Like the passed extension such as DownAlbum to export all the posted images&videos links.
Thank you.

Same thing as in #1416.


Ad rotation in sidebar should be LF Edge focused

There appears to be an "ad" in the left sidebar at landscape.lfedge.org. The ad currently showing is for Kubecon and CNCF. I suggest this could be more edge relevant.

Created a new image for the State of the Edge report and pointed to the lfedge edge page on it:
https://github.com/State-of-the-Edge/lfedge-landscape/pull/324
Image is pretty simple. We can replace with something new if desired.


Containers on debian buster are not accessible outside

docker run -d -p 8001:80 --name webserver1 nginx

wget <IP_ADDRESS>:8001  (from host)
--2019-08-28 20:25:51--  http://<IP_ADDRESS>:8001/
Connecting to <IP_ADDRESS>:8001... connected.
HTTP request sent, awaiting response... Read error (Connection reset by peer) in headers.
Retrying.

wget ip_host:8001   (from host)
The same error

wget ip_host:8001  (from another server)
nGinx page loads.

Looks like the same bug as at https://stackoverflow.com/questions/54991940/docker-containers-on-debian-buster-are-not-accessible-outside-how-do-i-fix-it
Docker version 19.03.1, build 74b1e89
Linux deb 4.19.0-5-amd64 #1 SMP Debian 4.19.37-5+deb10u1 (2019-07-19) x86_64 GNU/Linux

You are right. I posted it on https://github.com/docker/for-linux/issues
Thanks!


you cannot currently require velocity-animate on the server

If you have common client-server code this is a problem.
Pull request to address the issue here.

Will discuss in #474. Thanks!


Adding v flag in project creation

What is the purpose of this change? What does it change?

Only for debug purpose
Was the change discussed in an issue?
fixes #???

How to test changes?

/assign @surajnarwade

Only for debug purpose. So
/hold

Duplicate of #1754


How to just compress a PDF using node?

I got a PDF and need to compress it? How can I do it using nodejs?
Thank you.

Are you asking if this library can compress the pdf once it has been created? You may want to look for other libraries to handle further compression of a generated pdf


Provide API to set concrete type of implicit reset

Introduces mutually-exclusive traits RequireAsyncReset and
RequireSyncReset to set the type of the implicit reset in
MultiIOModules. The Scala-type remains Reset, but the Chisel
elaboration-time checks apply.
This implements my proposal from the Chisel Dev Meeting today (24 Feb 2020). In the notes this is the "subtractive" approach because MultiIOModule has an implicit reset of type Reset and these traits allow us to constrain the runtime type. There is an alternative "additive" approach that I still plan to prototype but I do think this is pretty slick and relatively intuitive.

Related issue:

Type of change: feature

Impact: API addition (no impact on existing code)

Development Phase: proposal &  implementation
Release Notes
Add RequireAsyncReset and RequireSyncReset traits for setting type of implicit reset

@seldridge I don't know if you saw @mwachs5's comments, but she (essentially) requested the ability to override mkReset, then one could write something like this (her example):
val MySpecifiedResetTypeModule(useAsyncReset: Bool) extends Module with RequireSpecificResetType {
  override def resetTypeGen() = if (useAsyncReset) AsyncReset() else Bool()
  ...
}

Details and names aside, there is a case to be had that mkReset or an equivalent should be protected and thus implementable by the user if they so choose. I don't love it because it's a little unintuitive that you can't just override val reset instead, but we can just document why this is.

Adding DO NOT MERGE while we discuss @mwachs5's use case

Adding DO NOT MERGE while we discuss @mwachs5's use case

Basically, my higher level use case is "allow a module to set its own destiny and decide what reset type it should have, at runtime, without relying on the instantiator". Keeping in mind that modules may be top level or may be instantiated in numerous contexts. relying on "the instantiator" requires making sure that every instantiator is "doing the right thing" to decide on the reset type, whereas just letting the module decide for itself is a much more intuitive interface from a user's perspective.
As a concrete example, imagine a component which would like to be fully AsyncReset or SyncReset given a certain runtime parameter. That component can be instantiated in multiple testharnesses / prototyping platforms / larger SoC contexts, many of which the designer of the component won't even be aware of. The current API requires that every caller now can't directly instantiate the Module, they need to be told/aware of the parameter which decides the component's reset scheme and make sure they use it.
If it was under the component's control, there would be a runtime error if the instantiator drives the reset type incorrectly, but that may be better than the silent error of changing the component unintentionally by driving its reset with the wrong type,
There is the clunkier issue of requiring even in correct usage every callsite for the module to consider this parameter/remembering to use the companion object. This gets more complicated with inheritance -- what if we want the parameter to be considered in the component's abstract base class that gets widely used? Now we have to fan out companion objects for each of those subclasses as well, because they have to concretely call the right superclass / with Require...Reset method. Where we could have just done the right thing in the shared base class in a single line.

This may warrant a larger discussion.
I think there's two separable issues here:

There's no way to set the top module reset
There's a use case for setting a specific non-top module's reset

I'm fine with this PR as a fix for (1), but I'm not sure if (2) has to be fixed here. I think the broader issue of (2) is that the module hierarchy for all children of RawModule currently includes an abstract reset member IO. It would seem to me that setting the reset type should be something done via Scala's type system and not via passing parameters that override methods or trait mix-ins.
I.e., I think the following construction is the most logical:
class Foo extends RawModule {
  val clock: Clock      = IO(Input(Clock))
  val reset: AsyncReset = IO(Input(AsyncReset))

  withClockAndReset(clock, reset) {
    // ...
  }
}

I agree that there are two issues at play here, and I am OK if this PR only addresses the first one. So my comments below are only about the first one.
This PR as is doesn't really address the first use case, because the current implementation requires me to instantiate different top modules, not actually allow me to specify the reset type of my top module.
Our use case is to add Async Reset functionality to an existing code base where users are expecting to instantiate a variety of modules as the top level module. Modules which used to be the top level and were sync reset, we would now like to be (optionally) async reset. With this PR as is, any module we used to have as a top level in our chisel generation, we now have to create two classes for it -- the sync reset and async reset one. Or we have to change the entire top level Generator flow to actually have the companion object for the top level module solely to add the right with Require...Reset trait.

To the second point... you seem to be assuming that Bool reset is more "normal" than AsyncReset. If someone wants to enforce AsyncReset they have to turn their module into a RawModule (wheras they can turn off CompileOptions.inferResets to get Bool resets I think...?) Again, retrofitting this onto an existing code base is difficult... things that inherit from the RawModule now have to put everything inside withClockAndReset blocks.
I hypothesize that now that you have Async reset support in Chisel3, people may start considering the AsyncReset as more "normal".

It's more that I think there are assumptions in the existing module hierarchy that make describing different reset types difficult. I'm then questioning if RawModule is a "better" abstraction for all modules of all three reset types.

Anyway, I guess I am fine with merging this PR as-is as it does add necessary functionality. Again I don't think forcing any module (including all its mixins, subchildren, etc) that wants to be async reset to be rewritten as a RawModule is realistic, so this PR solves the problem except at the very top level.

Any thoughts from other @freechipsproject/chisel-lang-developers?

I think this is a nice thing for 3.3 if other devs agree

Alright I'm gonna merge this

Hi there @jackkoenig @seldridge
I've seen that @mwachs5 's request of having mkReset set to protected instead of private has finally not been integrated.
Is there any reason for it?
My current use-case is the following:

I need all modules in my lib to default to AsyncReset (to be able to be annotated as Preset as one would guess) when they are emitted as top-level module (and only as top level)
However I don't want any error when integrated into a hierarchy of Synchronous Resets because the whole point of all this mess with implicit resets is to produce reset-agnostic designs ...
I also need that this option not to affect tester flow behaviour (remain synchronous there for compatibility with firrtl-backends such as treadle)

This cannot be done by mixing in RequireAsyncReset as it would error on SyncReset.
For now I am using an ugly wrapper with a simple withResetAndClock and iteration over ports for propagating IOs.
And as the wrapper needs then to be removed, I do even more ugly file operations at the end: overwrite the emited file while triming the wrapper module to get what I need.
I am currently thinking about leveraging annotations coupled with tiny custom Firrtl transform to do the job much more gracefully.
I keep you updated on that topic and I wanted to share my general thoughts about chisel integration but as it became quite long I decided to go for another issue #1445!

Hi @johnsbrew, you're absolutely right that we need the ability to set the concrete type of the reset via Scala parameters. I'm not a fan of using inheritance to accomplish this goal (ie. making mkReset protected), especially because that would only work for the implicit reset of Module and MultiIOModule. The good news is that I've been thinking about this and I think we can accomplish it with 2 minor changes to Chisel in a way that is generic to all components of type Reset:

Make it legal to drive Bool and AsyncReset with Reset. This has been legal in FIRRTL since https://github.com/freechipsproject/firrtl/pull/1396 and it is a bug that I forgot to make it legal in Chisel
No longer default the top-level implicit reset to Bool. This is done for backwards compatibility reasons, but because the behavior of unification-style reset inference defaults to Bool if there are no concrete constraints, the behavior is maintained even if the type is now inferable

Now, you're probably wondering: "How do these two changes fulfill my use case?" It would make it possible to constrain the type of implicit reset merely by using it to drive a wire (even if unused) of a concrete reset type, eg.
// Constrain type of reset:
val constraint = if (useAsyncReset) AsyncReset() else Bool()
WireDefault(constraint, reset) // alternatively: Wire(constraint) := reset

What I really like about this is that unlike overriding mkReset it works for any arbitrary component of type Reset:
val myWireReset = Wire(Reset())
val constraint = if (useAsyncReset) AsyncReset() else Bool()
WireDefault(constraint, myWireReset)


Fix header Sirius Logo

PR Reference:
https://github.com/proximax-foundry/web-explorer-vuejs/pull/176
Screenshots:


Connect mininet hosts to root namespace

Hi, How could I do to have a mininet host in root namespace? I've read in this link http://mininet.org/walkthrough/ that one can have everything running in root namespace, I do not know how to do it though. I've read there is a parameter (innamespace) which can be set to false. However, my topology is defined in json files instead of using python API. Is there any way to get what I wanna do?
Thanks in advance

I have the same question. Are you using mininet for p4 simulation?

JSON files? I don't think there is any such feature in Mininet.
JSON is a lousy format for specifying topologies because a 1000 node topology would require 2000 lines of JSON.

@p4pifor Have you tried Eder's method? It looks like he used the Root Namespace.
I actually tried his method with OpenFlow vSwitch but it doesn't work as expected. The switch could talk to the Internet, but host couldn't ping to the Internet. I posted my code in Stackoverflow for help.


Terminal prompt is missing production label

This used to work a couple months ago, but now it doesn't:
$ lagoon ssh -p project -e production
[project]cli-drupal:/app$

Whereas it shows up correctly for non-prod envs:
$ lagoon ssh -p project -e test
[project]test@cli-drupal:/app$

I can't replicate this?
Closing as no further recent conversation - please reopen if this use case or issue still exists.


Physics objects don't detect the mouse if inside a sub-viewport

Godot version:
ba854bb
Issue description:
Physics objects (like Area2D, for example) inside sub-viewports aren't detecting any mouse inputs.
This was supposedly fixed in 26d33d1, but it's still reproducible as of now.
EDIT: _unhandle_inputs are also not being detected at all.

Was it really fixed? In 3.2.1 I still have to use
func _input(event):
    $viewport.unhandled_input(event)

and if the scaling or size of viewport is different than is the project setting, event position have to first transformed.


A submission deleted from its submission details page still appears in the submissions table until a refresh

This is due to the async behavior between Fedora and Elasticsearch. It has already been handled in the case of clicking the "Abort" button during the workflow. The same approach should be applied in this case.

See changes made in this PR https://github.com/OA-PASS/pass-ember/pull/956


StorageLoader: use S3DistCp to move enriched and shredded files to archive

See #276, #1776
This is more complex than the related tickets because the cluster will have to be kept running through the load step in order for this "late" S3DistCp step to be executed.

This is doubly difficult because the shredded files are in folders, which will cause S3DistCp to die.

S3DistCp will happily copy a folder structure I believe...


Terms of Use are unreachable

The URL of this page is bad.
https://thorium.edrlab.org/en/documents/thorium-terms-of-use/e

All footer links have to be changed
About Thorium Reader
Terms of use
Credits
Privacy Policy
Accessibility policy
Licence
About this website
Accessibility : conforms to WCAG 2.1 AA
Licence


cmake can't find potassco

I'm packaging clasp for gentoo overlay guru and it can't find potassco through cmake
CMake Error at CMakeLists.txt:101 (find_package):
  Could not find a package configuration file provided by "potassco"                                                                                (requested version 1.0) with any of the following names:

    potasscoConfig.cmake
    potassco-config.cmake

  Add the installation prefix of "potassco" to CMAKE_PREFIX_PATH or set
  "potassco_DIR" to a directory containing one of the above files.  If
  "potassco" provides a separate development package or SDK, be sure it has
  been installed.

The potassco cmake files are here
/usr/lib64/cmake/Potassco/PotasscoConfig.cmake
/usr/lib64/cmake/Potassco/PotasscoConfigVersion.cmake
/usr/lib64/cmake/Potassco/PotasscoTargets-relwithdebinfo.cmake

maybe potassco should be capitalized?

Yes, the spelling is the issue. Note that the install target to install the development libraries is not tested at all. We do not use them here. At the moment, libpotassco, clasp, and clingo releases go hand in hand. Our binary packages bundle all of them and offer no way to install the systems separately. In case you are planning to release clingo, you will find that it uses parts of clasp that are not installed via its install target.

Addressed by @rkaminsk  in https://github.com/potassco/clasp/pull/77
Thanks :+1:


[SDP-1397] Circle Payouts error handling

What
[TODO: Short statement about what is changing.]
Why
[TODO: Why this change is being made. Include any context required to understand the why.]
Known limitations
[TODO or N/A]
Checklist
PR Structure

[ ] This PR has a reasonably narrow scope (if not, break it down into smaller PRs).
[ ] This PR title and description are clear enough for anyone to review it.
[ ] This PR does not mix refactoring changes with feature changes (split into two PRs otherwise).

Thoroughness

[ ] This PR adds tests for the new functionality or fixes.
[ ] This PR contains the link to the Jira ticket it addresses.

Configs and Secrets

[ ] No new CONFIG variables are required -OR- the new required ones were added to the helmchart's values.yaml file.
[ ] No new CONFIG variables are required -OR- the new required ones were added to the deployments (pr-preview, dev, demo, prd).
[ ] No new SECRETS variables are required -OR- the new required ones were mentioned in the helmchart's values.yaml file.
[ ] No new SECRETS variables are required -OR- the new required ones were added to the deployments (pr-preview secrets, dev secrets, demo secrets, prd secrets).

Release

[ ] This is not a breaking change.
[ ] This is ready for production.. If your PR is not ready for production, please consider opening additional complementary PRs using this one as the base. Only merge this into develop or main after it's ready for production!

Deployment

[ ] Does the deployment work after merging?

stellar-disbursement-platform-backend-preview is available here:SDP:      https://sdp-backend-pr491.previews.kube001.services.stellar-ops.com/healthAP:       https://sdp-ap-pr491.previews.kube001.services.stellar-ops.com/healthFrontend: https://sdp-backend-dashboard-pr491.previews.kube001.services.stellar-ops.com

stellar-disbursement-platform-backend-preview is available here:SDP:      https://sdp-backend-pr491.previews.kube001.services.stellar-ops.com/healthAP:       https://sdp-ap-pr491.previews.kube001.services.stellar-ops.com/healthFrontend: https://sdp-backend-dashboard-pr491.previews.kube001.services.stellar-ops.com

stellar-disbursement-platform-backend-preview is available here:SDP:      https://sdp-backend-pr491.previews.kube001.services.stellar-ops.com/healthAP:       https://sdp-ap-pr491.previews.kube001.services.stellar-ops.com/healthFrontend: https://sdp-backend-dashboard-pr491.previews.kube001.services.stellar-ops.com

stellar-disbursement-platform-backend-preview is available here:SDP:      https://sdp-backend-pr491.previews.kube001.services.stellar-ops.com/healthAP:       https://sdp-ap-pr491.previews.kube001.services.stellar-ops.com/healthFrontend: https://sdp-backend-dashboard-pr491.previews.kube001.services.stellar-ops.com

stellar-disbursement-platform-backend-preview is available here:SDP:      https://sdp-backend-pr491.previews.kube001.services.stellar-ops.com/healthAP:       https://sdp-ap-pr491.previews.kube001.services.stellar-ops.com/healthFrontend: https://sdp-backend-dashboard-pr491.previews.kube001.services.stellar-ops.com

stellar-disbursement-platform-backend-preview is available here:SDP:      https://sdp-backend-pr491.previews.kube001.services.stellar-ops.com/healthAP:       https://sdp-ap-pr491.previews.kube001.services.stellar-ops.com/healthFrontend: https://sdp-backend-dashboard-pr491.previews.kube001.services.stellar-ops.com

Something went wrong with PR preview build please check

stellar-disbursement-platform-backend-preview is available here:SDP:      https://sdp-backend-pr491.previews.kube001.services.stellar-ops.com/healthAP:       https://sdp-ap-pr491.previews.kube001.services.stellar-ops.com/healthFrontend: https://sdp-backend-dashboard-pr491.previews.kube001.services.stellar-ops.com


Package maintenance

[x] tests and linter show no problems (npm run t)
[x] code is properly formatted (npm run fmt)

Landed in https://github.com/metarhia/config/commit/2a245cb16735f569684fe5e30e9b5d4a9810859f, https://github.com/metarhia/config/commit/107907a34635574a3d17f8523ba0808a3a4263db and https://github.com/metarhia/config/commit/97061a099aa91f2fc84696cceb27e54ee2f448b5


Adding Changelog for v0.6.0-rc1

What type of PR is this?
/kind documentation
What this PR does / why we need it:
This PR contains the changelog for v0.6.0-rc1. By approving this PR, you are also approving the release of v0.6.0-rc1 based on the current state of the main branch of this project and the changelog included with this PR.
Note: This PR is very much an early WIP, it is not ready for anything other than a high level review to ensure we haven't missed things
/cc @bowei @shaneutt @youngnick

/hold until we're actually ready for a release

I've updated this in #1559, closing this one out.


Making a GET request to /templates/validate (getting template aliased 'validate') doesn't work.

First things first, If this is mentioned in the docs or it's just something wrong with my code then I apologize.
I'm not sure if it's just this library as I haven't tried making a curl request instead ..
Can someone please verify this?
Edit: I tried a request using curl and got the same error, so I guess it's not specific to this library.
{
  "ErrorCode": 1109,
  "Message": "No template data received."
}

@Lootfi sorry for the delay in getting to this issue. This is not related to Postmark-PHP but to the Postmark API.
We have an existing route pointing to templates/validate, used by the Template Validation endpoint, as presented in our Templates API docs.
Because of that endpoint route conflict, unfortunately we do not support fetching a template via an alias named "validate". If you need to keep that exact alias name in place, you can alternatively use the associated TemplateID instead, e.g.: /templates/123456.
Sorry for the inconvenience! Looking back, this naming should probably have been reserved to avoid confusion.
Please let us know if you encounter any other issues.


AttGAN code

AttGAN code has been released recently. https://github.com/LynnHo/AttGAN-Tensorflow

Hi Lynn Ho, thanks for the link, I've added it to the repo. It's really great that you guys have opensourced the code :)