Add support for @supports (...) {} syntax in LESS

VSCode Version: Code 1.17.2 (b813d12980308015bcd2b3a2f6efa5c810c33ba5, 2017-10-16T13:47:41.889Z)
OS Version: Darwin x64 17.0.0
Extensions:

Extension
Author (truncated)
Version

EditorConfig
Edi
0.11.1

vscode-eslint
dba
1.4.0

gitlens
eam
5.7.1

tslint
eg2
1.0.12

flow-for-vscode
flo
0.7.2

node-debug2
ms-
1.18.3

debugger-for-chrome
msj
3.4.0

vscode-react-native
vsm
0.4.4

Steps to Reproduce:

Write the valid CSS in a LESS file:

@supports (display: flex) {
  div {
    display: flex;
  }
}

The editor will highlight (display: flex) as an error as well as the closing bracket in the div.

Reproduces without extensions: Yes

This works for me in the latest insiders build


How about applying a collapsible expander format

As the project grows, more tests are written.
There will be many test files, and this will lead to very long comments.
It becomes uncomfortable to see other comments.
If Commentator put a collapsible section, it would be very convenient.
below is a example format.

 TOTAL | 6329 | 1966 | 69%  5002 passed 8 skipped
detail test go on ...

Have the same issue. Found solution on similar GitHub Action: Pytest Coverage Comment


no outfiles

Hello
Sorry for being here again.
After I thought all issues were done, I moved the folder containing DeepVariant to a different HD with more space. I ran the program and got thumbs up (log attached) except... there were no outfiles. Nothing was saved. I don't know why. It's all the same except that things moved in the machine.
Here's the command line:
sudo ./nextflow run main.nf --exome --h38 --bam_folder /media/user/segundoHD/FA/1/FA_1_N33.bam --bed /media/user/segundoHD/FA/FA_BEDs/FA_1_N33.bed
Thanks a lot, Felipe
log_what.txt

Hi @felipemartins1305,
No worries, sorry the pipeline isn't working for you as expected.
I think the problem here is that the bam_folder should be set to the folder containing the BAM files (in this case /media/user/segundoHD/FA/1) and not the BAM file itself.
If you want to run the pipeline for your FA_1_N33.bam BAM file try using the --bam option instead eg:
sudo ./nextflow run main.nf --exome --h38 --bam /media/user/segundoHD/FA/1/FA_1_N33.bam --bed /media/user/segundoHD/FA/FA_BEDs/FA_1_N33.bed

Sorry that the pipeline was not failing for you and giving any useful error messages in this sitatuation though. I will check that the documentation is clear and see if there's a way to make the pipeline fail in this situation.

Dear Phil:
Thanks for the quick reply.
Your suggestion will not solve the problem. The command --bam doesn't go. Every time I try to use it it gives me an error message (see below). In this case it is a different issue. I will try to ask someone that knows Linux more than me, I'm sure it's something to do with changing folders, I must have made somtething wrong in the process.
Thanks, Felipe

N E X T F L O W  ~  version 18.10.1
Launching main.nf [fabulous_montalcini] - revision: 0f2d95c8e6
WARN: Access to undefined parameter bam_folder -- Initialise it to a default value eg. params.bam_folder = some_value
ERROR ~ please specify --bam_folder option (--bam_folder bamfolder). Expression: (nextflow.ast.LangHelpers.compareEqual(params.bam_folder, true) && nextflow.ast.LangHelpers.compareEqual(params.bam_folder, null))
-- Check script 'main.nf' at line: 141 or see '.nextflow.log' file for more details

Hi @felipemartins1305,
This seems very strange. What was the command that you were running and are you able to upload the .nextflow.log file here?

Hello
Yes, it is for a particular project and yes, I am running on my local machine. I downloaded the correct one now as you pointed, but it seems I have multiplied the error messages. The most uninformative one is below:
WARNING: Your kernel does not support swap limit capabilities or the cgroup is not mounted. Memory limited without swap.

Can you please upload the .nextflow.log file?
I don't know if the error message you sent is causing the issue or if its something else. The error message you sent may just be a warning. It looks like its to do with Docker though so I would check your docker installation. Here is an answer from stackoverflow for that warning from docker
Alternatively if you are just trying to run DeepVariant in the easiest way possible you could also checkout Deploit from Lifebit. Full disclosure I work there. But it provides a web interface where you can run pipelines including DeepVariant on the cloud and you get $10 free credit. It would mean you wouldn't have to worry about some of the installation/configuration if you can't get it to work locally. Just an option though and I'll try and help you to get the pipeline running either way

Hello
I finally got it running. I went back to the correct repository, and it took some work - including editing the config file. I am using for so I can run multiple files and it's fine now. Thanks for your help.

Hi @felipemartins1305,
I'd be curious to know what kind of config edits you needed to do to make this work - is there anything general that we can change to help other users of the pipeline?
Thanks,
Phil

Hello
The program crashed and had an error message about memory usage. So we went to the config file and changed the Max memory and Max CPUs - I feel like it shouldn't be an issue, but after we changed it everything ran smoothly. I am running in a local machine - this is a test, only 60 bams for now. So this was the only thing I can remember.
If I could  make a suggestion, it would be great if there was a --bed_folder command for running multiple bed files. In a different thread you told me I would have to do one at a time, which led me to use a loop to run all 60 files in one command.
Thanks a lot, Felipe

Hi @felipemartins1305,
Yes I agree, that would be a good addition to run with multiple BED files. The main problem would be ensuring that the correct BAM file was run with the correct BED. Would you rather:

Have to specify the same file prefix for your BAM & BED files
I think this is what you are doing already, eg FA_1_N33.bam & FA_1_N33.bed
Supply a seperate CSV file that maps the correct BAM to the correct BED file?
I think this might be more difficult to implement but would have the advantage of being able to run multiple BAM files with the same BED file
Eg example.csv:

FA_1_N33.bam,FA_1_N33.bed
file2.bam,other.bed
file3.bam,another.bed
file4.bam,other.bed

And yes, by default the max cpus & max memory are reasonably high for running DeepVariant in a cloud/HPC enviroment. You can also set your max cpus & memory in the configuration file as you have done or on the command line in your nextflow run command eg:
nextflow run main.nf --max_cpus 2 --max_memory 6.GB

Hi
I don't remember seeing the  --max_cpus and --max_memory options, but now that I know they exist, I will definitely use them.
I believe that what I already did - using .bam and .bed files with the same title - would be the best call. If you use samtools to create the bed files - like I did - they will come with the exact same name as the bam file, so there it is. The other option is not bad though, I think both would work, but I still prefer the first. Just my opinion.
Cheers

Hi both,
I'm a little confused - is the .bed file not there to specify a region of the genome that's of interest? That's how I interpret usage.md:

Path to bedfile, specifying region to be analysed must also be supplied

So then normally you'd have one .bed file for an entire project / run...?
If you're using samtools to generate bed files from bam, then that sounds more like the bed file contains all of the aligned read information. If that's the case then (a) we can do this automatically within the pipeline and (b) the documentation should probably be refined to make this clear :)
Phil

Ah yes sorry you're quite right at @ewels,
The BED file is for the regions of interest and so would normally be the same for all of BAM files.
@felipemartins1305, if you want to run DeepVariant for the whole genome sequence I suggest you find a BED file for the h38 reference genome that you are using. I'm sure this will already be available and if not I think you can produce it from the FASTA file.
Thanks


segfault regression case (happens in 0.52.0, 0.53.0 & 0.53.1, works OK in 0.51.2)

here is a not-so-minimal reproducer (tested with Python 3.8):
import numpy as np, numba
grid = (100, 10)
def fa(data):
    return (np.ones(5, dtype=int), np.zeros([data.shape[i] + 2 * 1 for i in range(2)]))
def fb(data):
    halos = [[(1 - (d == c)) for c in range(2)] for d in range(2)]
    dd = [np.zeros([[data[d].shape[c] + 2 * halos[d][c] for c in range(2)] for d in range(2)][d]) for d in range(2)]
    return (np.ones(5, dtype=int), dd[0], dd[1])
@numba.njit()
def atv_2d_axis0(focus, arrs, i, k=0):
    return arrs[0][focus[0] + int(i - .5), focus[-1] + int(k)]
@numba.njit()
def atv_2d_axis1(focus, arrs, k, i=0):
    return arrs[-1][focus[0] + int(i), focus[-1] + int(k - .5)]
@numba.njit()
def set(arr, i, k, value):
    arr[i, k] = value
@numba.njit()
def apply_scalar_impl(fun_outer, fun_inner, out, vec_arg1_outer, vec_arg1_inner):
    for i in range(1, grid[0]+1):
        for k in range(1, grid[1]+1):
            set(out, i, k, fun_inner(out[i, k], ((i, k), (vec_arg1_outer, vec_arg1_inner))))
            set(out, i, k, fun_outer(out[i, k], ((i, k), (vec_arg1_outer, vec_arg1_inner))))
@numba.njit()
def apply_scalar(fun_outer, fun_inner, out, vec_arg1_meta, vec_arg1_outer, vec_arg1_inner, scal_arg2_meta):
    scal_arg2_meta[0] = True
    apply_scalar_impl(fun_outer, fun_inner, out, vec_arg1_outer, vec_arg1_inner)
def mu(atv):
    @numba.njit()
    def upwind(init, flux):
        return init + atv(*flux, -.5) - atv(*flux, .5)
    return upwind
form = tuple([mu(atv) for atv in (atv_2d_axis0, atv_2d_axis1)])
ns = fa(np.empty([0]*2))
@numba.njit()
def step(a, b):
    return apply_scalar(*form, a[1], *b, ns[0])
step(fa(data=np.zeros(grid)), fb(data=(np.zeros((grid[0] + 1, grid[1])), np.zeros((grid[0], grid[1] + 1)))))

gives:
Process finished with exit code 139 (interrupted by signal 11: SIGSEGV)

works OK with NUMBA_DISABLE_JIT set to "1"

I cannot replicate this using mainline or 0.53.1. Can you try it on the latest mainline?

I can reproduce on mainline:
$ git rev-parse HEAD
8dd28abf57bd554fe25921ad2abee5d2faa81816

$ gdb --args python issue7120.py
<snip>
(gdb) r
<snip>
Program received signal SIGSEGV, Segmentation fault.
0x00007fffcbe75076 in __main__::apply_scalar$242(type$28CPUDispatcher$28$3cfunction$20mu::$3clocals$3e::upwind$20at$200x7fffcf849af0$3e$29$29, type$28CPUDispatcher$28$3cfunction$20mu::$3clocals$3e::upwind$20at$200x7fffcf849ca0$3e$29$29, Array<double, 2, C, mutable, aligned>, Array<long long, 1, C, mutable, aligned>, Array<double, 2, C, mutable, aligned>, Array<double, 2, C, mutable, aligned>, Array<long long, 1, C, mutable, aligned>) () at issue7120.py:36
36          scal_arg2_meta[0] = True
(gdb) bt
#0  0x00007fffcbe75076 in __main__::apply_scalar$242(type$28CPUDispatcher$28$3cfunction$20mu::$3clocals$3e::upwind$20at$200x7fffcf849af0$3e$29$29, type$28CPUDispatcher$28$3cfunction$20mu::$3clocals$3e::upwind$20at$200x7fffcf849ca0$3e$29$29, Array<double, 2, C, mutable, aligned>, Array<long long, 1, C, mutable, aligned>, Array<double, 2, C, mutable, aligned>, Array<double, 2, C, mutable, aligned>, Array<long long, 1, C, mutable, aligned>) () at issue7120.py:36
#1  0x00007fffcbdf1178 in __main__::step$241(Tuple<Array<long long, 1, C, mutable, aligned>, Array<double, 2, C, mutable, aligned> >, Tuple<Array<long long, 1, C, mutable, aligned>, Array<double, 2, C, mutable, aligned>, Array<double, 2, C, mutable, aligned> >) () at issue7120.py:50
#2  0x00007fffcbdf18e7 in cpython::__main__::step$241(Tuple<Array<long long, 1, C, mutable, aligned>, Array<double, 2, C, mutable, aligned> >, Tuple<Array<long long, 1, C, mutable, aligned>, Array<double, 2, C, mutable, aligned>, Array<double, 2, C, mutable, aligned> >) ()
#3  0x00007fffcfcbba54 in call_cfunc(Dispatcher*, _object*, _object*, _object*, _object*) ()

I think I might have aliased a segfault by switching on debug, this also segfaults but I suspect for a different reason:
import numpy as np, numba

jit = numba.njit(debug=True)

@jit
def bar(x):
    x[0] = True

g = (np.ones(1),)

@jit
def foo():
    return bar(g[0])

foo()

I'm suspicious this is coming from trying to write to an array in globals.
import numpy as np, numba

@numba.njit()
def bar(x):
    x[:] = 72

@numba.njit
def foo():
    bar(g[0])

g = (np.ones(10, np.int64),)

foo()

reproduces.

I think this is a bug in the typing of tuples in globals, the arrays inside the tuple should be marked read only, whereas in the above it appears as:
 $4load_global.1 := UniTuple(array(int64, 1d, C) x 1),

this permits mutation, but I don't think it's valid.

thank you!

ping :)

@slayoo this is marked as a bug and needs a fix. The fix will be to catch the issue in code such as that in your reproducer or in the MWR here and abort compilation, i.e. with a fix in place, your code would not compile as it violates this assumption made by Numba: https://numba.readthedocs.io/en/stable/reference/pysemantics.html#global-and-closure-variables.
To make your code work, you'd need to pass the array in as an argument such that writing to it is a valid operation.
Hope this clarification helps?

thank you! this clarification was super super helpful. Workaround in place!

@slayoo No problem. I'm also going to edit the title of this issue to reflect the actual problem.

Thank you!

Thank you!

@slayoo thanks, am glad to get this fixed!


Obtain true vertex info from GENIE files & compare to MINERvA

ML-reco's truth vertex locations have a known issue (in Supera particle edges are moved to the edge of the sensitive volume to aid in labeling for PPN, and the interaction vertex is inferred from those). Stop using those. Switch to GENIE instead.  Also enable passing of true vertex info through MINERvA and ensure that matches GENIE.
Supersedes #54.

Added a commit to fix a trigger filling but happening with MINERvA


[Packager] Error resolving modules in 0.8.0-rc

I am trying to update an app to 0.8.0 to get the renderScrollComponent changes (I had previously been maintaining a fork with that patch). I ran into a problem in the packager when loading a bunch of modules. I tracked it down to the _resolveHasteDependency function in DependencyResolver here.
I am using NPM 3.0.0 here, so I also applied the change from #1752.
These are the modules that cause errors:

ReactChildren
ReactDefaultPerf
ReactInstanceMap
ReactPropTypes
TouchEventUtils
cloneWithProps
emptyFunction
invariant
keyMirror
keyOf
onlyChild
requestAnimationFrame
warning

In these cases, the _hasteMap variable doesn't have a key for the module name, so an error gets thrown. I haven't figured out the actual problem yet, but since the relevant code came from a pretty big change (2d4055e) I wanted to see if anyone had any ideas to start with.
I tried starting a new project with v0.8.0 but the default app seemed to work fine. Obviously that means this could be a problem with my specific app, but since none of these are modules that I actually load myself it seemed like React Native is probably involved as well.

I also meet this error in 0.7.1
Unable to resolve module ../components/overlay/UserOverlay from /Users/soliury/soliury/work/git/noder/app/containers/Home.js
Unable to resolve module ../components/TopicsInTab from /Users/soliury/soliury/work/git/noder/app/containers/Home.js
Unable to resolve module ../components/overlay/MessageOverlay from /Users/soliury/soliury/work/git/noder/app/containers/Home.js

Most likely that this is an issue with your existing code and we just started warning about them

You might have to clean up the packager cache @evansolomon - if that doesn't work, then it may be as @amasad suggests


README needs to be updated to reflect TBB installation instructions

Description
The README.md at the top level needs to be updated to provide instructions for building the Math library properly.
This is the file that needs to be updated: https://github.com/stan-dev/math/blob/develop/README.md#required-libraries
Right now, it doesn't indicate how Intel TBB must be built in order for this to work. The current instructions are adapted instructions from header-only libraries and we should provide clearer instructions for our users.
Example
For "Required Libraries," there's no indication that Intel TBB must be built and that it's a different class of library than Boost or Eigen. For each of the libraries, all the source is included in Math, so it's missing the key information that it needs to be linked in.
For "Installation," it doesn't say how to build the Intel TBB library. There should at least be a note stating how it's supposed to be built from Math. Or a note on where to follow for instructions.
Current Version:
v3.0.0

We do not say that Sundials things are built either in the readme. The things you ask for are probably found in the CmdStan manual. If you think they should go in here as well, sure; but then the Sundials things should be mentioned as well, I think.
I am actually fine with the README as is - I mean if I would approach this afresh, then I read library XY is needed. Ok... libraries are usually something which need to be build by default.
If you approach this as "Stan-math used to be header-only"... ok, then flagging more verbosely that this changed is helpful.
Maybe we add a high-level note somewhere adequate that says "with Stan-math 3.0 changed from header-only to require building the Intel TBB"?

I get where you're coming from, but the simple question is: can you follow
those instructions and build an executable with the Stan Math library that
uses autodiff? The current answer is no. It used to be yes. The README
should really get back up to the standard where someone coming at the
project new could follow and build an executable.
Re: Sundials. That's a different category than TBB. TBB is now required. In
the old directions, it was ok because we didn't set up an example that
required Sundials. So the instructions were correct. In the current
directions, just following those steps is not enough.
If you want to link to a page that will tell people how to build TBB,
that's fine.
Btw, this is not approaching this as "Stan-math used to be header-only."
This is approaching this as "I want to use Stan Math. What are the steps I
should follow to build an executable?" If it's at CmdStan, that's nice, but
it also must be here. Or linked from here. Or something... a user just
needs to know how to build and run it.
On Wed, Nov 27, 2019 at 3:07 AM wds15<EMAIL_ADDRESS>wrote:

We do not say that Sundials things are built either in the readme. The
things you ask for are probably found in the CmdStan manual. If you think
they should go in here as well, sure; but then the Sundials things should
be mentioned as well, I think.
I am actually fine with the README as is - I mean if I would approach this
afresh, then I read library XY is needed. Ok... libraries are usually
something which need to be build by default.
If you approach this as "Stan-math used to be header-only"... ok, then
flagging more verbosely that this changed is helpful.
Maybe we add a high-level note somewhere adequate that says "with
Stan-math 3.0 changed from header-only to require building the Intel TBB"?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/stan-dev/math/issues/1465?email_source=notifications&email_token=AADH6F6FO6VEG7OBAOMLLALQVYTCVA5CNFSM4JR6MC62YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFIU3PA#issuecomment-558976444,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AADH6F5BQAVTBKNJGWKG4X3QVYTCVANCNFSM4JR6MC6Q
.

On Nov 27, 2019, at 1:42 PM, Daniel Lee<EMAIL_ADDRESS>wrote:
I get where you're coming from, but the simple question is: can you follow
those instructions and build an executable with the Stan Math library that
uses autodiff? The current answer is no. It used to be yes. The README
should really get back up to the standard where someone coming at the
project new could follow and build an executable.

I never did anything special for Sundials or TBB and I can still
run autodiff just by downloading stan-math from GitHub.
What kind of instructions do you want to see?

If you start from a clean git clone of Math, the instructions on the README don't work. That's what should be there.
To be more specific, I'm reading from the top of the README.md down:

the first code is to put that example c++ into a file. That works.
I see directions saying what's supposed to happen (and that specifically says that the paths need to be filled in with something else):

This is where it fails: it says this is "an example of a real instantiation"

What I see:

$ clang++ -std=c++1y -I ~/stan-dev/math -I ~/stan-dev/math/lib/eigen_3.3.3/ -I ~/stan-dev/math/lib/boost_1.69.0/ -I ~/stan-dev/math/lib/sundials_4.1.0/include  -I ~/stan-dev/math/lib/tbb_2019_U8/include -L ~/stan-dev/math/lib/tbb -ltbb -Wl,-rpath,"~/stan-dev/math/lib/tbb" -D_REENTRANT foo.cpp
ld: warning: directory not found for option '-L/Users/daniel/stan-dev/math/lib/tbb'
ld: library not found for -ltbb
clang: error: linker command failed with exit code 1 (use -v to see invocation)

The last bit of the text on the page doesn't indicate how this is supposed to be solved.

So the README doesn't include instructions on how to build the executable. It could either point the user on how to build Intel TBB using the makefile, it could point them to a different page, or it could tell them they have to have it installed already (preferably with some link to how that's done). But as it stands now, the README is just incomplete (as of v3.0.0). It's not enough to build any executable.

@bob-carpenter, could you let me know if you can follow and build an executable by following those instructions from a clean git repo? (one that doesn't have Intel TBB prebuilt)

I see - you mean we need to have someone in mind who wants to use only stan-math to do C++ autodiff. To be clear your are looking for instructions which lead to a working executable - allowing for links to other documents where things may already be explained. Does that have to work on all platforms? Windows is problematic with dynamic linking (but Windows c++ users should know that).
Probably the best is probably to come up with a makefile skeleton which takes care of all the build things. Is that reasonable? I have done this for the performance-cmdstan repo a while ago already.

Yes, exactly. Yes, any solution that leads to a new user following the
instructions and building is fine.
On Wed, Nov 27, 2019 at 5:23 PM wds15<EMAIL_ADDRESS>wrote:

I see - you mean we need to have someone in mind who wants to use only
stan-math to do C++ autodiff. To be clear your are looking for instructions
which lead to a working executable - allowing for links to other documents
where things may already be explained. Does that have to work on all
platforms? Windows is problematic with dynamic linking (but Windows c++
users should know that).
Probably the best is probably to come up with a makefile skeleton which
takes care of all the build things. Is that reasonable? I have done this
for the performance-cmdstan repo a while ago already.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/stan-dev/math/issues/1465?email_source=notifications&email_token=AADH6F6KX3KUBY23YTOCJ63QV3XPXA5CNFSM4JR6MC62YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFK4ZGQ#issuecomment-559271066,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AADH6FYMDQUVD27VJX6O43LQV3XPXANCNFSM4JR6MC6Q
.

Stan Math installation instructions have many opportunities for improvement.
Most Unix C++ programmers are used to using a standard "./configure" followed by "make", sometimes followed by "make install" cycle.  Since the math system is mostly headers, you may punt the "make install".  However, since you provide a makefile, it is a reasonable assumption that "make" would configure and make the program.
Instead, it prints out a help file.
Please put together a ./configure file for Unix, and make the makefile "make" command actually make the TBB library.  Since TBB is a frozen version and is now required for Stan, you are responsible for giving sufficient installation instructions/processes for it.
Currently the configure and install process is hidden under runTests.py, instead of the existing makefile.  Although this might make sense to a python programmer, I don't know, it is counter-intuitive to this C++ programmer.  Normally I'm used to tests being run only after a successful installation.  So it never occurs to me to use runTests to perform the configuration and installation itself.  This shows up in the various documentation in a few places; somewhere at the top of something there was another "use runTests to check the program" when it really meant to install it.  So I completely blew past it, and was stuck dead in the water for a long time.
The current README Installation instructions also bury this obscurely way, way down in the middle of a paragraph after the C example helloworld.  As an immediate patch, please insert something like the following paragraphs up at the top:
-------------------------------snip----------
Installation
The Stan Math Library is a C++ library which depends on the Intel TBB library and requires for some functionality (ordinary differential equations and root solving) on the Sundials library.
Frozen tested versions of these libraries have been included underneath the lib directory in your math-develop download, so you should not get the latest versions of these separately and install them yourself.
In order to configure and install the TBB library, the first thing you should do after you unzip the system is to go to your new math-develop directory and run:
./runTests.py test/unit/math/rev/core/agrad_test.cpp
This will install TBB using the default settings of ?1 ?all core, and run a quick simple test to prove the system has been installed correctly and works.
??This will also install the Sundials library.
??The Sundials library is not needed for everyday functionality.
A simple hello world program using Stan Math is as follows:
etc. etc.----------------------end snip----------------------
I would then revert "make" back to the standard configure/install functionality, and put the current help functionality under "make help".  Then always have "make" spit out a "Type "make help" for help on further make commands." message first thing. Since make will only be run once or twice, but is always run first if you're a newbie, having this message appear all the time will not be intrusive but highly useful.
To be clean, have a "make math" or "make stan-math" or "make stan" be the first line on the Common Targets list when make is run.  To make the entire system.  Documentation is a secondary category I'm interested in, the first category should be how to make the system.
One might think that "make tbb", a necessary subsystem, would also to be listed in Installation second behind "make math" under Common Targets.  This would configure, make, and install the TBB system, perhaps printing out a useful "Use   -L /path/to/lib -ltbb   when linking" message.  Although if installing the TBB is accomplished by "make", as it should be, this subcommand would simply redundantly provide peace of mind.
There is a controversy over whether TBB installs as default under Linux configured to use only one processor core, which I tend to believe.  Or whether it is smart enough to configure itself with the possibility of using all processor cores in the system.  Or whether a thread system is one layer up, running in software, and has nothing to do with the number of cores that the machine has.  Or whether the Stan system is strong enough to use some or all cores, or will break obscurely on some commands if more than one core is used.  It seems pointless to use a multithreaded system if you're not using multiple hardware cores, but maybe I'm missing something.  Anyway, I do not have time to mess with this; so I am punting that rabbit hole, installing a default perhaps 1-core TBB, and trying to get the system to run with what I have.  All this should be solved with ./configure.
Somewhere it says you can compile the system with make -j8 to compile it with 8 cores.  This is ambiguous between the immediate compilation process running in fast parallel, which only helps save five seconds right now at system build time, which is what I'm guessing this actually means; vs compiling a system that will run in parallel using 8 cores forever after in the future, which is what I would expect from a decent configuration system.  Both the program and the verbage should be improved to ensure the latter.
Please document somewhere how to configure TBB so it runs with multiple cores, and whether this will break any particular known commands or not, and whether, when they break, do they print anything out or is it simply silent.  Please make the system default to running as many cores as possible, if this will not break too many major routines.
The runTests making process is extremely long and barfs out pages of make feedbacks.  It is completely unobvious that it is installing TBB, or that the installation is successful, or where it ends up.  Please if possible print in bright bold green
"Configuring and installing TBB..."  before the TBB portion of the installation starts, and
"TBB successfully installed at /path/to/lib/tbb/libtbb.so"   after success.
So that people know that TBB was put in, and don't try to go get it from Intel themselves.
The makefile help format is confusing, because dashes are apparently used as subheadings although they are appearing in the place of a literal command.  So if I see
Common targets:
Documentation:

doxygen                  :Builds the API etc.

I don't know whether to type "make - doxygen" or "make -doxygen" or "make doxygen".  I suggest leaving the dash out completely and simply having the command inspaced an additional two spaces.  Unless, of course, you really mean "make - doxygen".
On your main splash page mc-stan.org/users/interfaces/math  you state flatly
The library is header-only, so there is nothing to install.
This is absolutely incorrect.  At the least, it needs a footnote*
*As of Dec 2019, you must configure and install, then link to, the frozen, tested version of the TBB library that has full source included underneath the build.  A ./configure and makefile is provided to do this for Linux systems. "
Hope this helps.  good luck; it's an important system.

Remember that stan math relies on the free time of volunteers who work on it. Your post is beyond my time budget. Feel free to contribute. Right now there is an open pr for this issue and you can comment on it.

@john-myers see #1552 the pr @wds15 is talking about

Thansk for the feedback.  I revised the out-of-date header-only statement on
https://mc-stan.org/users/interfaces/math
That used to be true before we added the Sundials ODE solvers.  We now also require linking against the Intel TBB.

On Dec 28, 2019, at 4:21 PM, Steve Bronder<EMAIL_ADDRESS>wrote:
@john-myers see #1552 the pr @wds15 is talking about
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.


NPE if no services defined

I'm seeing this in 1.4.1. Yes, this is on a job that was upgraded.
Cloud Foundry Plugin:
java.lang.NullPointerException
	at com.activestate.cloudfoundryjenkins.CloudFoundryPushPublisher.perform(CloudFoundryPushPublisher.java:136)
	at hudson.tasks.BuildStepMonitor$1.perform(BuildStepMonitor.java:20)
	at hudson.model.AbstractBuild$AbstractBuildExecution.perform(AbstractBuild.java:779)
	at hudson.model.AbstractBuild$AbstractBuildExecution.performAllBuildSteps(AbstractBuild.java:726)
	at hudson.model.Build$BuildExecution.post2(Build.java:185)
	at hudson.model.AbstractBuild$AbstractBuildExecution.post(AbstractBuild.java:671)
	at hudson.model.Run.execute(Run.java:1766)
	at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
	at hudson.model.ResourceController.execute(ResourceController.java:98)
	at hudson.model.Executor.run(Executor.java:381)

Printfs showed that perform() was called, but the CloudFoundryPushPublisher() constructor was not, leaving a null pointer servicesToCreate. Let's reflect on how this might have happened.
I saw this issue discussed elsewhere, can't remember where though.
Edit https://issues.jenkins-ci.org/browse/JENKINS-28885

Jenkins 1.620, Red Hat Enterprise Linux.
Strange. I added the following field.. the constructor isn't being called, nor the empty constructor (if I add one). My field stackJunk is  null inside  perform().
    public CharSequence stackJunk = "<unset>";
    {
    	stackJunk = "init: " + getCurrentStack();
    }

Thanks for the digging! Discussion continued on the JIRA bug: https://issues.jenkins-ci.org/browse/JENKINS-28885

@WGautier Welcome!
P.S. you can turn off issues in GitHub if you only keep them in JIRA, maybe with an update to the README.md telling people where to file bugs. I had found the JIRA issue with a web search, then opened the issue after I hit the repo.


🚀 [Feature Request] - Dockerizing the app

Is your feature request related to a problem ? Please describe. ✍
Making it accessible for all by providing an Consistent & Isolated Environment .
Describe briefly how you would implement this enhancement.
Some steps to implement this enhancement-
1. Create a Docker-compose file containing all the tech stacks used in it
2. i.e. Mongodb, nextjs, nodejs

Additional context or screenshots
Additional context
Are you contributing for a program?
GSSoC2023
Code of Conduct

[X] I have read and agree to the Contributing Guidelines of this project.

@anmode I would like to work in this issue as my first one in your repo.
Thanks

Size max: 500mb
and image should be multi stage builded


spatial plot of POSH

If we are calculating POSH to calculaTE MESH, then why can't we plot POSH as well ?

POSH is also returned in the dictionary of new radar fields from the MESH functions - you can easily plot it up from there.
Also, POSH isn't calculated from MESH, it's calculated from SHI and WT
https://github.com/joshua-wx/pyhail/blob/07d57b1e5e2faa8251a202003286a4fc491d69b1/src/pyhail/mesh_ppi.py#L214

Yeah, got it... I was able to plot it..
On Thu, 25 Apr, 2024, 4:21 pm Joshua S, @.***> wrote:

POSH is also returned in the dictionary of new radar fields from the MESH
functions - you can easily plot it up from there.
Also, POSH isn't calculated from MESH, it's calculated from SHI and WT
https://github.com/joshua-wx/pyhail/blob/07d57b1e5e2faa8251a202003286a4fc491d69b1/src/pyhail/mesh_ppi.py#L214
—
Reply to this email directly, view it on GitHub
https://github.com/joshua-wx/pyhail/issues/8#issuecomment-2076902144,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AQACDYWMCAJBVFYUOV23EDDY7DN3RAVCNFSM6AAAAABGYMGU52VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANZWHEYDEMJUGQ
.
You are receiving this because you authored the thread.Message ID:
@.***>


Accurate description for workers_additional_policies

Description

Description should mention it is a list of ARNs
It seems that workers_additional_policies are also effective for managed nodes (needs confirmation)
When you pass a custom role for your worker/managed node, it seems that the additional policies are overridden (needs confirmation)

Motivation and Context
I think the description is not precise.
Breaking Changes
None.
How Has This Been Tested?

[ ] I have tested and validated these changes using one or more of the provided examples/* projects
Haven't tested.

closed with #1680


My Markets page should be unaccesible if wallet is disconnected

related to #352

not relevant any more since there is no my markets page any more.


pink trees don't work in Stay True

With optifine, birch trees appear pink with optifine in some biomes with this pack:
https://www.curseforge.com/minecraft/texture-packs/stay-true

With CITResewn they do not.

This has nothing to do with the mod, CIT Resewn is specifically for CIT, not for all of optifine.
The pack is not doing any CIT and the trees specifically are not CIT.


Inconsistent "latest" npm version flips between 5.* and 6.*

https://www.npmjs.com/package/node-gyp
Lists 5.1.1 as "latest" (and no next or beta etc..)
The last time I updated my dependencies (in early Feb 2020) I got version 6.1.0, now when I run npm-outdated it is saying I need to upgrade downgrade to 5.1.1 to get the latest.
Which version is even the latest one we should be using?

I'm sorry, this is my fault. Every time you publish it sets that version as latest unless you tell it not to, and because we're still maintaining 5.x it occasionally flips because I forget about this! I've set it to 6.x and this is the one you should be using. 5.x is basically the same but prefers python2 over python3 where both exist, so it's safe enough, just not ideal. 7.x will be out soon and that will be our new preferred.


Issue when connecting to LN $ sudo journalctl -f -u lnd

I get this issie aswell, I think both are connected

When I try to get some btc test I get this issue, is it because I'm still updating the chain?

I think bitcoind might still by syncing. What does the following command return?
$ sudo tail -f /home/bitcoin/.bitcoin/debug.log

This is what I get when I type
$ sudo tail -f /home/bitcoin/.bitcoin/debug.log
and
$ sudo tail -f /home/bitcoin/.bitcoin/testnet3/debug.log

Ah, you are on testnet. Can you copy the last 200 rows of the log into https://pastebin.com/ and post the link to your paste here? I need more than this one cut-off line to help.
As user "admin":
sudo tail -n 200 /home/bitcoin/.bitcoin/testnet3/debug.log

Sure, here it is pastebin 200 rows

Yes, looks good. It's at 69%, give it a few mir hours.

I´m fully synced to testnet, still rcp issue

I solved the problem what is bold text is what I added
RaspiBolt LND Mainnet: lnd configuration
/home/bitcoin/.lnd/lnd.conf
[Application Options]
debuglevel=info
debughtlc=true
maxpendingchannels=5
alias=YOUR_NAME [LND]
color=#68F442
[Bitcoin]
bitcoin.active=1
enable either testnet or mainnet
bitcoin.testnet=1
#bitcoin.mainnet=1
bitcoin.node=bitcoind
[bitcoind]
bitcoind.rpcuser=raspibolt
bitcoind.rpcpass=MyPassword
[autopilot]
autopilot.active=1
autopilot.maxchannels=5
autopilot.allocation=0.6

Hej @rocky3xr, great, glad you solved it. This is usually not necessary, lnd reuses the information in the bitcoin.conf file if it can find it in the standard path (.bitcoin folder in the same user's home directory).
Maybe there's something different here, or it's a permission issue. Nonetheless, happy it works!


Update dependency versions for U11

Purpose
Fixes: $Subject
Examples
Checklist

[ ] Linked to an issue
[ ] Updated the specification
[ ] Updated the changelog
[ ] Added tests
[ ] Checked native-image compatibility

close this PR with the favour of this PR https://github.com/ballerina-platform/module-ballerinax-persist.sql/pull/94


Problem when using SpriteFlexJS with FlexJS SDK v0.8 "NullPointerExecption"

When using SpriteFlexJS with FlexJS v0.7 I have NO problem et all , and can transpile successfully without any problem
However when using FlexJS v0.8 I got this:

Is this SpriteFlexJS problem OR FlexJS SDK problem?
Thank you

I haven't tested flexjs 0.8. It seems that this method of deleting loop dependent arguments is different from the 0.7.

Thank you
I'll be waiting for the update 👍

i do not know,but ths args diff with 0.7.
-remove-circulars
and pls look at the flexjs0.8 doc.

Unfortunately, the Falcon compiler reference on Flex's chwiki was last updated  on September 2016
:(

pls push a bug at.http://apache-flex-development.2333347.n4.nabble.com/

AH,.. Finally it caught up! :D
To use SpriteFlexJS with FlexJS v0.8 , new param must be explicitly declared : -targets="JSFlex"
This is the .bat file that I modified and works with FlexJS v0.8
set FLEX_HOME=d:/sdk/flexjs.0.8
set LIB=d:/sdk/Spriteflexjslib
set main=src/TestXML.as
start %FLEX_HOME%/js/bin/mxmlc -targets="JSFlex" -external-library-path="%FLEX_HOME%\js\libs\js.swc" -compiler.source-path=%LIB% %main%

They have refine asjsc and mxmlc
asjsc by default will NOT include HTML template unless you define and link it
mxmlc by default will compile to HTML and SWF
-targets param has two values: JSFlex and SWF
by running the .bat file above, the transpiation gets done correctly just I did with FlexJS v0.7
:)

nice job


Fix jnp.arange(x) for fractional x

Fixes #3450

Thanks for fixing this! However, we should use np.ceil or math.ceil here instead so as to avoid doing shape computations on an accelerator. I can do a follow-up PR.


lgtm handler: find lgtm comment and add label

ref: #1389
This PR replaces LGTMAfterCommit munger with LGTMHandler that
// LGTMHandler will
// - apply the LGTM label if reviewer has commented "LGTM, or
// - notify reviewer if non-reviewer has commented "LGTM", or
// - remove the LGTM label from an PR which has been updated since the reviewer added LGTM

LGTM. Not sure how we should test it. But we should test this before get it merged.

cc @kubernetes/contributor-experience

@bgrant0607 @apelisse
Addressed the comment to add the ability to notify reviewers.

How to move forward this? Let me know if anything else I need to do.
@apelisse @bgrant0607

@hongchaodeng Sorry, we're in all-day meetings Tues through Thurs, and eparis is OOO.
@xiang90 Testing: We usually run the bot manually and make it print what it would do ("dry run") in order to test it manually. I haven't thought about how to regression-test it, but am open to suggestions.

@hongchaodeng Please also update the README to describe the new behavior.

@bgrant0607 Updated readme

it's mainly important to determine when to apply the lgtm label, and to make it clear why the lgtm label isn't applied in other cases.

@bgrant0607 Yes. These were addressed in this PR. I have updated the top comment to reflect that, also squashed commits.
We should move forward this. What else?

We usually run the bot manually and make it print what it would do ("dry run") in order to test it manually.

Is there anyone in Google who do the QA/testing? Or do I need to test it? If latter, any pointer to testing documentation?

@hongchaodeng I'll try to have a look. We don't have testers, it's up to you to write a test. There are many (yet probably not enough) examples in mungegithub/mungers/*_test.go.
I'll try to have a look and move it forward as soon as I can.
Thanks,

Rebased.
@apelisse Thanks for taking a look. Let's move this forward and care about others later. Let me know if there is anything you have strong opinions about.

I think this is great. Can you please fix the broken CI test and squash the rebase commit?
Also, we should use the same piece of code to mention users and build the assignee list. I'm also doing that in close-stale-pr.go. But it shouldn't prevent this from moving forward.

@apelisse
Thanks. Squashed.
The previous error was caused by undeleted lgtm_after_commit.go file after rebasing.

@hongchaodeng Thanks! I'll merge and deploy next week

@hongchaodeng @apelisse Great! Thanks!
Please document this in https://github.com/kubernetes/kubernetes/blob/master/docs/devel/automation.md, and send an announcement to kubernetes-dev.

@bgrant0607 Sure. Thanks for notifying.

Ann: https://groups.google.com/forum/#!topic/kubernetes-dev/OZuk1QFmIa4

@hongchaodeng sorry, but we reverted this (because there wasn't a way to turn it off with a flag).
To turn it back on, we need to turn this logic into something that comprehensively considers every lgtm-affecting variable and delivers a verdict (and only once!).
That is, it needs to be able to make messages like "I would have applied the LGTM label, but the release note process hasn't been followed" instead of fighting with itself.
Speaking of, I think we need to add some shortcuts to turn LGTM off, and to turn other labels on/off. Maybe something like bot:+lgtm,+release-note-none.

In particular, I need to be able to say something like "lgtm after you fix nits" and not have the bot interpret that as an lgtm.

@lavalamp @bgrant0607 @apelisse
I'm sorry for not replying in time.
Let me try to fix this. To me it sounds like there are LGTM logic in other places. Can we put them into just one handler? What are the other places?

Part of this issue has been fixed in https://github.com/kubernetes/contrib/pull/1518, where we no longer remove LGTM, and instead add do-not-merge. Also, it would make sense to make LGTM an explicit command, such as /LGTM, which is unambiguous and less likely to lead to situations like: https://github.com/kubernetes/kubernetes/pull/29999#issuecomment-237404442.

@hongchaodeng We definitely should have this implemented as a separate munger, rather than extend an existing one the way it currently does, so as to ensure that we have a way to turn it on/off decoupled from other mungers. I'd be happy to review your PR once these changes are made.

Note that Reviewable's LGTMs look different. I don't know if it adds the label.

@rmmh That is a good point. Perhaps we should still have the reviewer explicitly do a /LGTM in the comments, as a bot command. That would be the easiest and the intent is unmistakable in my opinion.

I'm in favor of something explicit. /lgtm--not quoted with backticks & on
its own line--is fine.
On Fri, Aug 12, 2016 at 12:47 PM, Anirudh Ramanathan <
<EMAIL_ADDRESS>wrote:

@rmmh https://github.com/rmmh That is a good point. Perhaps we should
still have the reviewer explicitly do a /LGTM in the comments, as a bot
command. That would be the easiest and the intent is unmistakable in my
opinion.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes/contrib/pull/1428#issuecomment-239543003,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAnglo8rMWWpvWOUR1OQ4Y8EfmogGwzTks5qfM3vgaJpZM4JTaP6
.

We should also let the PR author say "release-note: none" in the PR
message. Otherwise adding an lgtm command won't in practice help that much.
On Fri, Aug 12, 2016 at 12:52 PM, Daniel Smith<EMAIL_ADDRESS>wrote:

I'm in favor of something explicit. /lgtm--not quoted with backticks &
on its own line--is fine.
On Fri, Aug 12, 2016 at 12:47 PM, Anirudh Ramanathan <
<EMAIL_ADDRESS>wrote:

@rmmh https://github.com/rmmh That is a good point. Perhaps we should
still have the reviewer explicitly do a /LGTM in the comments, as a bot
command. That would be the easiest and the intent is unmistakable in my
opinion.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes/contrib/pull/1428#issuecomment-239543003,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAnglo8rMWWpvWOUR1OQ4Y8EfmogGwzTks5qfM3vgaJpZM4JTaP6
.

"/lgtm" sounds good. Will do it.
"release-note: none" is a good point too. Will do it after lgtm thing. It's a separate issue.
Initially, I would just assume a single line with only "/lgtm" or "xxx" without anything else. If there is more feedback or strong demands, we could handle more later.

Why not just "any line with ONLY lgtm or :lgtm:.
Also, lgtm without 'release-note-none` hopefully won't fight, but you right, we need a non-write way to se tthose...

@eparis We are trying to define more standard way to communicate (in both direction) with the bot right now. /LGTM would be a command you give to the bot. And on the other side, the bot would have specific messages [NEEDS-REBASE] to notify users of what's going on etc. This should make it easier to regex.

I'm all for the bot having to be 'magic' so its actions can be easily captured and reasoned about in the future.  I will get it wrong. Repeatedly. And I'm going to use it a lot.
Humans talking to bots need to be VERY human friendly. Not all of us are particularly bright.. I think the bot should respond to me lgtm if I added it via reviewable or by hand, without any extra syntax...

@eparis The problem with that may be that people use the LGTM comment in an overloaded fashion, sometimes meaning LGTM after nits, or LGTM after comments addressed.
Like in the release note issue that surfaced at https://github.com/kubernetes/kubernetes/pull/29999#issuecomment-237404442, the bot started to add the LGTM label when it wasn't intended (the LGTM comment has since been deleted). It would be better if we knew that it is a command specifically intended for the bot IMO.

I agree with eparis.
LGTM on a line by itself, or the LGTM comment from Reviewable should both be sufficient.
Having the bot not interpret LGTM there's other things on the line "LGTM after fixing nits" would be okay. The bot could also reply to those messages with "if you want to apply the LGTM label, please respond with LGTM on a line by itself".
Another affordance for humans would be accepting punctuation.
Adds LGTM label:
"lgtm", "LGTM", "lgtm.", "LGTM!", "LGTM!\n\nthanks for fixing this", ":lgtm:"
Doesn't add LGTM label, responds with usage hint (ambiguous directive):
"lgtm after nits", "seems fine, lgtm"
Does nothing:
"looks good to me", "unrelated comment"
The usage hint could be as simple as:
"@commenter: to mark a PR as LGTM, write "LGTM" on a line by itself."
In kubernetes/kubernetes#29999, people left these comments, which would be classified as ambiguous:
oops. obviously, I mean  lgtm after nits.
@taufen Just one comment. Otherwise lgtm

/ is not arbitrary. It's the "de facto" command prefix since forever (IRC probably made it popular in the 90s, many games also use it). It makes it easy to write code that says "Look in the comments for the last commands"/"Do we have a LGTM command ...". It's consistent, it's always the same, it's easier to parse, it's a single piece of code (FindCommand("LGTM")) It can have arguments (maybe useful for some commands? /RETEST #Flakyissue). I think it's less awkward than: retest this issue: #Flakyissue.
Also, I completely agree that we should provide help if we detect something that could be a command but is not, mistyped, etc

@eparis @rmmh
We have a lot of inconsistent phrases for communicating with our bots: ok to test, @k8s-bot: test this issue: #...., I signed it!, and so on. It's very confusing, especially the longer they are.
We also have the problems with ambiguity mentioned above.
And the need to be able to easily identify the commands, for multiple purposes: labeling, metrics collection, dashboard, etc.
We're about to add lots more commands. I would strongly prefer a consistent, terse syntax. The proposed syntax was inspired by various chatbots. I'm open to suggestions, but I don't think plain english is the way to go. Think about documenting the rules and examples from the comment above. That's way, way too complicated.
Hypothetical commands:

/lgtm
/approve
/ack
/ptal
/norelnote
/hascla
/dibs (assign this to me)
/help (dump possible commands)

We may also want to make it possible to invoke the same commands from elsewhere, such as a CLI or even slack.

Sentiment analysis may be a fun college project, but we shouldn't need it in order for our bot to work.

If we want the Reviewable flow to work well, we should support its LGTM format. LGTMs happen an order of magnitude more than anything else.
Finding "LGTM" on a line by itself is very far from sentiment analysis.

Opening a PR in Reviewable, reading through all the changes, and clicking the "LGTM" button makes sense.
Having to go back to Github and commenting "/lgtm" to explicitly instruct the bot is a needless extra step.

Is there other identifying notation in comments from reviewable? How about
accepting both "/lgtm" from a human or the official reviewable LGTM message?
On Fri, Aug 12, 2016 at 3:53 PM, Ryan Hitchman<EMAIL_ADDRESS>wrote:

If we want the Reviewable flow to work well, we should support its LGTM
format. LGTMs happen an order of magnitude more than anything else.
Finding "LGTM" on a line by itself is very far from sentiment analysis.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes/contrib/pull/1428#issuecomment-239578880,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAnglrhg2il9VkZRF4l8C1oz48KBlWx-ks5qfPl6gaJpZM4JTaP6
.

We definitely intend to be compatible with Reviewable and special case this if needed.

A Reviewable LGTM has these distinctive lines:

*Comments from [Reviewable](https://reviewable.kubernetes.io:443/reviews/kubernetes/kubernetes/26027#-:-KP-2syrokgBDbUGJ_fL:bnfp4nl)*

@rmmh Reviewable's documentation claims that the text inserted upon lgtm can be customized. Can we reconfigure it to make it compatible with this syntax?

Maybe? I looked and didn't see that.
On Fri, Aug 12, 2016 at 4:05 PM, Brian Grant<EMAIL_ADDRESS>wrote:

@rmmh https://github.com/rmmh Reviewable's documentation claims that
the text inserted upon lgtm can be customized. Can we reconfigure it to
make it compatible with this syntax?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes/contrib/pull/1428#issuecomment-239580580,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAM7nGgcUNwc3AEvKTDyvRYVuq5sScCsks5qfPxEgaJpZM4JTaP6
.

We now have the bot honoring /lgtm and /lgtm cancel on this repo.
Just ran a quick test here, and there shouldn't be races between different mungers (hopefully).
Thanks @hongchaodeng for helping with this effort.

Thanks @foxish for helping too!
Now we are gonna move to "release-note" or "approve" in next step.


Add filter example [WIP]

Related with https://github.com/CartoDB/carto-vl/issues/1172
In this first approach, we're adding a widget that allows filter data by category using the filter expression and the JavaScript API.

@elenatorro this is good!
I have a couple of comments/questions:

can we remove the comments that were specific to this map as a legend example and add in a few comments for the pieces related to the filter and selection buttons?

on line 85 we call out the others labels (I need to ask you about this in the original legend example as well) since there are no other categories showing, can we remove this?

        layer.on('updated', () => {
            if (!initialized) {
                const legend = layer.viz.color.getLegendData({
                    othersLabel: 'Other Weather'
                });

can we remove the comments...

Totally, actually the main idea is to take a final look to the code once we finish the example, clean it and keep the consistency with other examples 👌

others labels

Yes, we can remove this setting for sure, good catch!

@elenatorro thanks so much for all the comment clarifications!
As discussed, our final to do here:

[ ] change bars back to points (as to avoid confusion with a category-like widget since information is static)

@elenatorro ok, awesome! did a review and added some description in the legend box. LGTM. thanks for your work on this!


Problem size and solving time always printing, even at verbosity 0

TN: I'm not sure where these are coming from, both in terms of printf/display/etc. location and in terms of stdout/stderr from Kodkod.
I also wonder if we could send over more structured info with the solution. It feels like this should be a 3rd component of the result (besides sat/unsat and instance/core).

This has been resolved on the new-pardinus branch, keeping this open until it's merged back.
See the new Sat and Unsat structs.

This has been resolved on the new-pardinus branch, keeping this open until it's merged back.
See the new Sat and Unsat structs.


resolve 'No handlers could be found for logger'

resolve 'No handlers could be found for logger "st2.st2common.util.loader"

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

What problem are you trying to solve here?

No handlers could be found for logger
/opt/stackstorm/st2/lib/python2.7/site-packages/st2common/util/loader.py
LOG.setLevel(logging.DEBUG)
LOG.addHandler(logging.StreamHandler())


deeper radio tower mechanics

Thinking about some extra mechanics like hidden generators, which can deactivate the  radio tower functionality and slow / prevent enemy heavy / air vehicle reinforcements

It would be great to see this and other elements of the mission expanded. Like intel and intel related missions. Radio towers could be tied into that. Would be great to see 0.97 released first though.


Make the default value of feEnvVars beEnvVars  to [] to eliminate the helm warning

Describe the current behavior
When use helm upgrade with feEnvVars beEnvVars being overridden with map value. Helm report the following warning.
The reason is because the default value of  feEnvVars beEnvVars are set to []
starrocks-kubernetes-operator/blob/main/helm-charts/charts/kube-starrocks/values.yaml#L252
helm upgrade starrocks . -n celostar  -f values.yaml -f values-eu-dev-1-cs.yaml
...
coalesce.go:289: warning: destination for celostar-starrocks.starrocks.starrocksBeSpec.beEnvVars is a table. Ignoring non-table value ([])
coalesce.go:289: warning: destination for celostar-starrocks.starrocks.starrocksFESpec.feEnvVars is a table. Ignoring non-table value ([])
coalesce.go:289: warning: destination for celostar-starrocks.starrocks.starrocksFESpec.feEnvVars is a table. Ignoring non-table value ([])
coalesce.go:289: warning: destination for celostar-starrocks.starrocks.starrocksBeSpec.beEnvVars is a table. Ignoring non-table value ([])

helm versoion
version.BuildInfo{Version:"v3.14.0", GitCommit:"3fc9f4b2638e76f26739cd77c7017139be81d0ea", GitTreeState:"clean", GoVersion:"go1.21.5"}
Describe the enhancement
Make the default value to [] to eliminate the helm warning
Additional context
Add any other context or screenshots about the enhancement here.

I think what your suggestion is: Make the default value to {} to eliminate the helm warning, not [] ?

I think what your suggestion is: Make the default value to {} to eliminate the helm warning, not [] ?

yes.

+1 to have a default value {}


Options to make the default gulp messages off

[gulp] Using gulpfile ~/Gulpfile.js
[gulp] Starting 'help'...
[gulp] Finished 'help' after 490 μs

Sometimes I don't want to see that, an option on the task to silent it could be great.

@kud Which way did you use at last?

Nothing for the moment.

@kud So, you just leave it there?
[gulp] Starting 'help'... :cry:

I use Make :D

@kud :sunglasses:

It seems that because gulp is called before it is created in the code by running gulp, adding the the --silent flag in the code does not work.
However, if you run node gulpfile.js, you can add the silent flag before you require in gulp.
// This will cause gulp to be silent as long as you call "node gulpfile.js" and not "gulp".
process.argv.push('--silent');

var gulp = require('gulp');

@hzizh The solution was posted already - use --silent

@contra It's not possible to run Gulp in silent mode without using the silent flag. I feel like after you run gulp, it should be possible to pass further configuration into Gulp.

Yeah, I would do this way too.
Something like:
gulp.silent(true);

Please stop requesting custom APIs. This will be supported once gulprc files are supported by the CLI. Locking.


I really want to know that how to use the forex env? and what is the format of csv for forex training?

in other the word, i seeing the env_fx.py contains these two lines hard-code:
        self.df = df
        self.df["_time"] = df[self.time_col]
        self.df["_day"] = df["weekday"]

what is that means?
Thank you very much if there be a reply, thanks again!

This env is merged from trading_gym. Data can be found here https://github.com/cove9988/TradingGym/tree/master/data. After downloading the data file to your local device, you can follow this notebook https://github.com/AI4Finance-Foundation/FinRL-Meta/blob/master/Demo_ForexTrading_Demo.ipynb.

Thank you!


Discussion: Feature/black format

Using black formatting.
Features:

black formatting over setup.py, tests/, and graypy/
Added black formatting check in .travis.yml

Is everyone for this? It does blow out the code in graypy/handler.py, but, I think black's styling is quite clean and easy to read.

Since Go's fmt, I'm all for opinionated code formatters—one less thing to worry about.

I would suggest adding a file .pre-commit-config.yaml into the root directory with contents
repos:

# Automatic source code formatting
- repo: https://github.com/psf/black
  rev: stable
  hooks:
  - id: black
    args: [--safe, --quiet]

Then you can use pre-commit to ensure black is run automatically.

Codecov Report

Merging #120 into master will not change coverage.
The diff coverage is 97.67%.

@@           Coverage Diff           @@
##           master     #120   +/-   ##
=======================================
  Coverage   95.97%   95.97%
=======================================
  Files           3        3
  Lines         273      273
=======================================
  Hits          262      262
  Misses         11       11

Impacted Files
Coverage Δ

graypy/rabbitmq.py
86.2% <100%> (ø)
:arrow_up:

graypy/__init__.py
71.42% <100%> (ø)
:arrow_up:

graypy/handler.py
99.51% <96.96%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7360fe4...c0ae99e. Read the comment docs.


Make into library

This is a very good implementation, I've based my own on this with a small modification.
You should make it into a library that can be included via maven!
The change I made was to use a BiConsumer instead of Runnable, passing the Id and RedisLock into the consumer. I did this to have access to a method that I added for checking if my code still has the lock. So I can periodically check if I still have the lock, if not, I exit.
This is useful for batch jobs that usually iterate over items in a loop.
Just my 2c

Thought about the same... A lower-level library and then a Spring-compatible one :)


Ongoing thread for user feedback

Now that we've started to use this in production, we're going to spin up this issue to start keeping tabs on user feedback. We can use this to inform future dev priorities, changes, etc.
Our first run is by Dee, call notes from night 1 are as follows:

Words used to describe initial use: 'intuitive', 'got everything'
activity: fairly heavy call load, sent several pledges
felt the pledge behavior was a little confusing -- tough to follow that it doesn't autopopulate in the modal until reload, not clear what the relationship between the 'hard pledge' and the 'soft pledge' was. (This is a concept that's drilled into CMs that we don't really track as much in this system.)
Dee noticed that adding new people to the call list didn't throw them at the top or bottom, but somewhere in the middle, which seemed a little jarring
Said the tabs were very useful! Was excited that everything was saving so cleanly
Wasn't quite sure what the income field was for -- it's used mostly for determining whether or not someone's NAF eligible, but Dee pointed out (in so many words, she's much too nice to say this) that it wasn't terribly clear about that. This is probably a +1 for helper text
Toward the end of the conversation Dee said it would be nice to have some representation of what she did over the course of the evening -- her point of reference was a facebook activity feed. This seems to stem from a concern that the call list being cleared would run the risk of people falling through the cracks. For all the things we hate about the spreadsheet it does make history accessible.

Night 2 with Dee:

'Way better today now that I'm used to it!' Observed that she was able to get through calls much faster
Said it wasn't terribly clear why sending a pledge didn't remove the patient from the urgent cases or call list -- reasoning being that usually when we send a pledge, that's it unless we hear from them again
With respect to default voicemail, she said that generally if someone doesn't specify she tends to err on the side of not calling. Didn't find the default setting of 'voicemail okay but don't identify' to be particularly helpful
At one point, she accidentally removed someone from her call list and she had to go back into the system to restore it. Suggested that some kind of safety valve would be helpful
She got a lot of mileage out of drag and drop. Spends time entering patients from the voicemail and taking notes, then moving on to the next, then ordering patients in descending order of urgency (later patients up top, later appointments down bottom).
Said that she observed that the submit pledge checkbox was blank so she couldn't check it off, but that it fixed itself on reload. Potential bug.
Dee loooooves the notes function. Said she would take running notes while taking calls. Averages 2-3 notes per call, plus a note or two from initial entry.

cc @lwaldsc @mebates @eheintzelman

Night 3 with Dee:

had a PT with multiple numbers. Reiterated the need to have the alternate number on the call popup, but told her it was in the pipeline.
need the ability to store more than two phone numbers? how do we want to deal with that?
include income by month (as well as week) as that's how most PTs will discuss their income
how will CMs learn about changes to the system as they happen? we discussed that changes will be integrated into the user manual as well as a running release changes.

Otherwise, Dee said everything is running really well and she loves using the system!

Night 1 with Katelyn:

CMs should ideally have access to the cheat sheets in Crypto via the CM App. This applies mostly to the other funds we work with and the contact/pricing list for clinics.
She said she really appreciated how the system simplified the actual call process.
Still wrote out notes by hand but is trying to force herself to rely on the "Your Call List" function.
Was confused about Colin's initial password email, so he is sending a prep email before the secure email

Overall, really positive feedback with very few issues.

Night 4 with Katelyn:
Overall, still very positive feedback

Your Call List is still repopulating every day with seemingly little reason between PTs. She has seen PTs she has left a VM for, those still in the fundraising status, those marked resolved without DCAF, and a PT where another CM has sent a pledge already.
Sending a pledge does not unmark a PT as urgent automatically. Both Katelyn and I feel this should be done. Is this something we could get by the next release @colinxfleming ?
She still needs to refresh PT screen before submitting pledge to have correct amount populate in the pledge form.
She would like a feature where a PT can be moved from the Completed List back up to Your Call List without manually having to search for the PT again. Again, is this something we could get by the next release @colinxfleming @mebates ?

First dupe! Got an email from Katelyn as follows:

Hey Colin- just ran into this problem and didn't want to forget: There is no alert for when a # is duplicated when creating a new PT. If you don't search by # it doesn't alert you they are already in the system (and if you spell a PTs name wrong ☺ ) Just ran into the issue when searching by phone number and saw two entries for the same PT.

Night 7 with Katelyn:

As stated above, no control for duplicate numbers!
Found a few PTs which had not been entered in the system but handled the cases just fine.
Has stopped using paper notes!

Her handoff emails:
-Was very short as she had no outstanding PT issues.

Used budget tracker rather than system to indicate soft pledges (Indicating soft pledges is something that would be useful in the future, but not sure exactly how we would do that. Something to discuss between @NerdyGirl537 and the UX/design team)
-Noted it was very useful to know the urgent cases from the previous CM

Overall, really great experience. Enthusiastic about using the system and very positive.

Joy -
She found actual calls went much smoother and it was easier to talk with PTs; she could focus on actual conversation than messing around with spreadsheet. This also made collecting data easier as it was right in front rather than having to scroll through the spreadsheet.

Notes on main dashboard sometimes pops up on hover, but not all. All will pop up on click.
The note + is somewhat difficult to pinpoint where exactly to click - possibly make bigger?
Confused on the language on the neutral VM status (specifically the "VM ok," which could be confused for "VM ok, ID ok"
Need to add "Medical/Health issues" to the special circumstances (should be an easy fix, @mebates)
She noted that sometime the "Urgent Cases" heading will be missing. She couldn't figure out what was triggering it. (She is using the current edition of Firefox on Windows 7)
The "refresh pt file to get the pledge amount to populate in the pledge box" issue was flagged as well as sometimes the clinic name would not populate.
-When she logged a call, it would sometime not automatically log into the PT file. It would show up when she refreshed a file or went back from the dashboard. (She noted that she never lost data, just had to refresh the PT file often)
Noted we should have a hard pledge box as well as a soft pledge box.
Again noted that her completed calls would pop back into her call list the next day rather than clearing out.
She recommended we add an appointment date column to the dashboard to make it easy to arrange the call list by who will need their pledge soonest. [@lwaldsc: If we have the room, I think this would be a great addition.]
Would like the dashboard autosortable by the column headers.
Add the ability to create a new record when there are some search results.  Currently, you only get the "add a new patient" dialogue when the search comes up with nothing.  But CMs should be able to search by a partial search and still be able to add a PT if a search returns other PTs.
-Would love the ability to edit notes
-Make a way to move someone from completed calls back to Your Call List. If she left a message for a PT and wanted to retry the PT later or the PT called her back, she was unable to search for the PT until she removed the PT from the Completed Call list.

Issue she flagged which I think we need to address is the scenario where a PT will give an apt date in the voicemail, but we may not actually contact the PT. If the CM fills in the appointment date, the PT's status will be fundraising, regardless if we have ever talked to them. It is rare of enough an occasion, we may not have to do anything, but just want to flag that. cc: @colinxfleming @NerdyGirl537
We've talked about possibly having a feature where a CM's stats (how many calls, how many pledges, etc, in a certain time period) but she added this: "This is another one that's probably very long term, but I would really like to be able to search for my own notes (perhaps within a date range).  Sometimes I get really involved with a patient and want to come back after my shift to see if she was able to get taken care of, but it is hard to remember names or phone numbers.  I'd like to be able to check back on "my" patients." Don't know if this would pose security issues, but a thought.
Also flagged that there are situation where a PT will use several numbers and if a CM does not spell the name correctly, that PT will not show up and not catch the number dup check. Not sure how we'd work this one out, maybe some sort of fuzzy search, but it does happen.
She also gave the highest compliments to Mollie and the design team for making everything very intuitive with very little of a learning curve.

Just did a quick read. The one you asked to flag is actually not an issue.
I did this for over 100 patients on data entry. They stay in no contact
made until you click the I reached patient button.
On Sep 7, 2016 12:00 AM, "Lisa"<EMAIL_ADDRESS>wrote:

Joy -
She found actual calls went much smoother and it was easier to talk with
PTs; she could focus on actual conversation than messing around with
spreadsheet. This also made collecting data easier as it was right in front
rather than having to scroll through the spreadsheet.

Notes on main dashboard sometimes pops up on hover, but not all. All
will pop up on click.
The note + is somewhat difficult to pinpoint where exactly to click
possibly make bigger?
Confused on the language on the neutral VM status (specifically the
"VM ok," which could be confused for "VM ok, ID ok"
Need to add "Medical/Health issues" to the special circumstances
(should be an easy fix, @mebates https://github.com/mebates)
She noted that sometime the "Urgent Cases" heading will be missing.
She couldn't figure out what was triggering it. (She is using the current
edition of Firefox on Windows 7)
The "refresh pt file to get the pledge amount to populate in the
pledge box" issue was flagged as well as sometimes the clinic name would
not populate. -When she logged a call, it would sometime not automatically
log into the PT file. It would show up when she refreshed a file or went
back from the dashboard. (She noted that she never lost data, just had to
refresh the PT file often)
Noted we should have a hard pledge box as well as a soft pledge box.
Again noted that her completed calls would pop back into her call
list the next day rather than clearing out.
She recommended we add an appointment date column to the dashboard
to make it easy to arrange the call list by who will need their pledge
soonest. [@lwaldsc https://github.com/lwaldsc: If we have the room,
I think this would be a great addition.]
Would like the dashboard autosortable by the column headers.
Add the ability to create a new record when there are some search
results. Currently, you only get the "add a new patient" dialogue when the
search comes up with nothing. But CMs should be able to search by a partial
search and still be able to add a PT if a search returns other PTs. -Would
love the ability to edit notes -Make a way to move someone from completed
calls back to Your Call List. If she left a message for a PT and wanted to
retry the PT later or the PT called her back, she was unable to search for
the PT until she removed the PT from the Completed Call list.

Issue she flagged which I think we need to address is the scenario where
a PT will give an apt date in the voicemail, but we may not actually
contact the PT. If the CM fills in the appointment date, the PT's status
will be fundraising, regardless if we have ever talked to them. It is rare
of enough an occasion, we may not have to do anything, but just want to
flag that. cc: @colinxfleming https://github.com/colinxfleming
@NerdyGirl537 https://github.com/NerdyGirl537
We've talked about possibly having a feature where a CM's stats (how many
calls, how many pledges, etc, in a certain time period) but she added this:
"This is another one that's probably very long term, but I would really
like to be able to search for my own notes (perhaps within a date range).
Sometimes I get really involved with a patient and want to come back after
my shift to see if she was able to get taken care of, but it is hard to
remember names or phone numbers. I'd like to be able to check back on "my"
patients." Don't know if this would pose security issues, but a thought.
Also flagged that there are situation where a PT will use several numbers
and if a CM does not spell the name correctly, that PT will not show up and
not catch the number dup check. Not sure how we'd work this one out, maybe
some sort of fuzzy search, but it does happen.
She also gave the highest compliments to Mollie and the design team for
making everything very intuitive with very little of a learning curve.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/colinxfleming/dcaf_case_management/issues/614#issuecomment-245168652,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AOi8meefs5ZBULfdpQ4GbzEEo2XSthFnks5qnjbygaJpZM4JrmLz
.

Ari -

Still having issues with completed calls resetting into her call list the next day.

Needs more than one alt phone number slots

Seconds need for a fuzzy search; she flagged that many PTs give their number late in the voicemail

Wondering if there was a way for CMs to flag a PT for admin review for some reason (the example she gave was duplicate records, but there could be other uses for this feature)

Also flagged a desire to have more slots for different funding sources (other funds) and the information cheat sheets somewhere in the system, but we discussed they are planned for upcoming releases.

Overall, really positive feedback similar to the other case managers.

Arona-

"Resolved without DCAF" PTs are popping back into call list, in addition to others
Would like appointment date on the Your Call List details so CMs can sort PTs by closest appt date
Drag and drop was not working smoothly for her (Firefox 48.0.2/Windows 10)
Asked for a button to call a PT from inside the PT file. After looking at the system today, it looks like there is one, but not sure when it was added or if it's a case of not being easy for the CMs to find.

She also asked if there was a way to see if there are any outstanding soft pledges when we work on the budget tracker. The example she gave was if she is at the end of the week and it's been very slow, she will follow up with soft pledged PTs to see where they are in funding and if she can fill their gap (while staying within rules/budget, obviously).
Other CMs have mentioned desires to see what has happened on the line this week or who is being soft pledged for similar reasons. Not sure how we work this request, but something to think about moving forward!

This has been banging around in my brain all week and I'm pretty sure I
read it wrong.  Definitely should check it out.
On Wed, Sep 7, 2016 at 5:36 AM, Jenn Rudiger<EMAIL_ADDRESS>wrote:

Just did a quick read. The one you asked to flag is actually not an issue.
I did this for over 100 patients on data entry. They stay in no contact
made until you click the I reached patient button.
On Sep 7, 2016 12:00 AM, "Lisa"<EMAIL_ADDRESS>wrote:

Joy -
She found actual calls went much smoother and it was easier to talk with
PTs; she could focus on actual conversation than messing around with
spreadsheet. This also made collecting data easier as it was right in front
rather than having to scroll through the spreadsheet.

Notes on main dashboard sometimes pops up on hover, but not all.
All will pop up on click.
The note + is somewhat difficult to pinpoint where exactly to click
possibly make bigger?
Confused on the language on the neutral VM status (specifically the
"VM ok," which could be confused for "VM ok, ID ok"
Need to add "Medical/Health issues" to the special circumstances
(should be an easy fix, @mebates https://github.com/mebates)
She noted that sometime the "Urgent Cases" heading will be missing.
She couldn't figure out what was triggering it. (She is using the current
edition of Firefox on Windows 7)
The "refresh pt file to get the pledge amount to populate in the
pledge box" issue was flagged as well as sometimes the clinic name would
not populate. -When she logged a call, it would sometime not automatically
log into the PT file. It would show up when she refreshed a file or went
back from the dashboard. (She noted that she never lost data, just had to
refresh the PT file often)
Noted we should have a hard pledge box as well as a soft pledge box.
Again noted that her completed calls would pop back into her call
list the next day rather than clearing out.
She recommended we add an appointment date column to the dashboard
to make it easy to arrange the call list by who will need their pledge
soonest. [@lwaldsc https://github.com/lwaldsc: If we have the room,
I think this would be a great addition.]
Would like the dashboard autosortable by the column headers.
Add the ability to create a new record when there are some search
results. Currently, you only get the "add a new patient" dialogue when the
search comes up with nothing. But CMs should be able to search by a partial
search and still be able to add a PT if a search returns other PTs. -Would
love the ability to edit notes -Make a way to move someone from completed
calls back to Your Call List. If she left a message for a PT and wanted to
retry the PT later or the PT called her back, she was unable to search for
the PT until she removed the PT from the Completed Call list.

Issue she flagged which I think we need to address is the scenario where
a PT will give an apt date in the voicemail, but we may not actually
contact the PT. If the CM fills in the appointment date, the PT's status
will be fundraising, regardless if we have ever talked to them. It is rare
of enough an occasion, we may not have to do anything, but just want to
flag that. cc: @colinxfleming https://github.com/colinxfleming
@NerdyGirl537 https://github.com/NerdyGirl537
We've talked about possibly having a feature where a CM's stats (how many
calls, how many pledges, etc, in a certain time period) but she added this:
"This is another one that's probably very long term, but I would really
like to be able to search for my own notes (perhaps within a date range).
Sometimes I get really involved with a patient and want to come back after
my shift to see if she was able to get taken care of, but it is hard to
remember names or phone numbers. I'd like to be able to check back on "my"
patients." Don't know if this would pose security issues, but a thought.
Also flagged that there are situation where a PT will use several numbers
and if a CM does not spell the name correctly, that PT will not show up and
not catch the number dup check. Not sure how we'd work this one out, maybe
some sort of fuzzy search, but it does happen.
She also gave the highest compliments to Mollie and the design team for
making everything very intuitive with very little of a learning curve.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/colinxfleming/dcaf_case_management/issues/614#issuecomment-245168652,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AOi8meefs5ZBULfdpQ4GbzEEo2XSthFnks5qnjbygaJpZM4JrmLz
.

Have logged issues thru Joy. Will be continuing work shortly.

First round of user feedback completed. Will start making issues from specific feedback.
Thanks!

💯
Actionable issues here are spun out. @lwaldsc , want to reiterate that you did an absolutely outstanding job of collecting and logging all this, and that the changes represented here are going to have the net effect of a massive CM experience improvement. Outstanding work.


Scroll bars appear on visualizations

You can't scroll much but it's annoying. I assume there's a padding or something in CSS that makes the DOM element size mismatch the size of the vis.

Where do you see this happening?


xdg-desktop-portal-gtk: 0.11 -> 0.99

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/xdg-desktop-portal-gtk/versions.
meta.description for xdg-desktop-portal-gtk is: '"Desktop integration portals for sandboxed apps"'.
Release on GitHub
Compare changes on GitHub

Checks done (click to expand)

built on NixOS

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 0.99 with grep in /nix/store/d88ia2jbhfj3ha93y684650h5ylaamv7-xdg-desktop-portal-gtk-0.99

directory tree listing: https://gist.github.com/a4b4a6d6b486014cac31fa2113d2c7e0

du listing: https://gist.github.com/6df26c1f4d2ee8fe42ec41902e1a1992

Test this build with Cachix (click to expand)

One time setup in nixpkgs Git checkout:
cachix use r-ryantm
git remote add r-ryantm https://github.com/r-ryantm/nixpkgs.git

Test this build:
git fetch r-ryantm && git checkout 35ed9f8c8ca835117b7197c92160c7df4e83be57 && nix-shell --pure -I nixpkgs=. -p xdg-desktop-portal-gtk

cc @jtojnar for testing.

No attempt on x86_64-darwin (full log)
The following builds were skipped because they don't evaluate on x86_64-darwin: xdg-desktop-portal-gtk
Partial log (click to expand)

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

Success on x86_64-linux (full log)
Attempted: xdg-desktop-portal-gtk
Partial log (click to expand)
glibPreFixupPhase
glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/5rhlnnlmri9kdxsl1c2mpkypgfswpd7w-xdg-desktop-portal-gtk-0.99
shrinking /nix/store/5rhlnnlmri9kdxsl1c2mpkypgfswpd7w-xdg-desktop-portal-gtk-0.99/libexec/xdg-desktop-portal-gtk
strip is /nix/store/1hi76hr87bd1y1q1qjk0lv8nmcjip1c8-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/5rhlnnlmri9kdxsl1c2mpkypgfswpd7w-xdg-desktop-portal-gtk-0.99/lib  /nix/store/5rhlnnlmri9kdxsl1c2mpkypgfswpd7w-xdg-desktop-portal-gtk-0.99/libexec
patching script interpreter paths in /nix/store/5rhlnnlmri9kdxsl1c2mpkypgfswpd7w-xdg-desktop-portal-gtk-0.99
checking for references to /build in /nix/store/5rhlnnlmri9kdxsl1c2mpkypgfswpd7w-xdg-desktop-portal-gtk-0.99...
/nix/store/5rhlnnlmri9kdxsl1c2mpkypgfswpd7w-xdg-desktop-portal-gtk-0.99

Success on aarch64-linux (full log)
Attempted: xdg-desktop-portal-gtk
Partial log (click to expand)
glibPreFixupPhase
glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/mnq7644rv35zckjvd1z0wxjs3rnjlsw5-xdg-desktop-portal-gtk-0.99
shrinking /nix/store/mnq7644rv35zckjvd1z0wxjs3rnjlsw5-xdg-desktop-portal-gtk-0.99/libexec/xdg-desktop-portal-gtk
strip is /nix/store/zrs21zqcchgyabjf4xfimncdq16njizc-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/mnq7644rv35zckjvd1z0wxjs3rnjlsw5-xdg-desktop-portal-gtk-0.99/lib  /nix/store/mnq7644rv35zckjvd1z0wxjs3rnjlsw5-xdg-desktop-portal-gtk-0.99/libexec
patching script interpreter paths in /nix/store/mnq7644rv35zckjvd1z0wxjs3rnjlsw5-xdg-desktop-portal-gtk-0.99
checking for references to /build in /nix/store/mnq7644rv35zckjvd1z0wxjs3rnjlsw5-xdg-desktop-portal-gtk-0.99...
/nix/store/mnq7644rv35zckjvd1z0wxjs3rnjlsw5-xdg-desktop-portal-gtk-0.99


Fixes ITK factory registration CMake

Addresses the following build error:
CMake Error at CMake/UseITK.cmake:43 (itk_generate_factory_registration):
Unknown CMake command "itk_generate_factory_registration".
This error occurs with the following configuration:
cmake -DBUILD_EXAMPLES=ON -DModule_Montage:BOOL=ON ~/src/ITK

I encountered another issue  and fixed it here too.


 I'd love a hotkey that sets focus to 'The current frame' UI element and most importantly: selects all the text therein. Currently I have to move the mouse down and manually select the text in the box (as double clicking does not select it) and type in a new number.
What would be great is to hit a single key, say f or something, type some digits on the numpad and hit enter to go to an exact frame. So f, numbers, enter, done.

Hi, that's a good suggestion, I'll see if I can add it for the next release. In the meantime you can use the tab key to switch focus to the current frame widget (if there aren't any other text widgets visible), and then use ctrl+a to select the text.

Love this idea. I might suggest ctrl+g, alt+g or some variation. "G" as in "go to". At least that's my intuition. Text editors will often use that to go to a line. And some video tools use it to go to frame numbers as well.

@thompsonalt Now I'm torn between my love of single having a key press for a much used function, and having something more universal like Ctrl+G. I  think my preference is still for a single key press (LightWave had this so I used it a lot and I may be biased), but I'd be happy with either

The next version will also have customizable keyboard shortcuts so you can set it to whichever shortcut you like.


[bug] Motion sensors not working

robertslando/zwave2mqtt   latest              45912840ae75
Build/Run method

[X] Docker
[ ] PKG
[ ] Manually built (git clone - npm install - npm run build )

Zwave2Mqtt version: 2.1.1
Openzwave Version: 1.6.0
Describe the bug
I am currently using HomeSeer Z-Wave and am determining if Home Assistant / Zwave2Mqtt would be a better fit for me. I have two Z-Wave motion sensors that work fine in HomeSeer but do not work in Zwave2Mqtt / Home Assistant.
Sensor 1
WAPIRZ-1 Motion Sensor (Linear (Nortek Security Control LLC))
Battery and Temperature working great. Motion not working.
Sensor 2
ZP3111 Multisensor 4in1 (Vision Security)
Battery, Temperature, Illuminance, Humidity working great. Motion not working.
To Reproduce
I am using MQTT Explorer to watch the traffic.
Sensor 1 reports this on the discovery topic
{"payload_on":true,"payload_off":false,"value_template":"{{ value_json.value }}","device_class":"door","state_topic":"zwave2mqtt/6/48/1/0","json_attributes_topic":"zwave2mqtt/6/48/1/0","device":{"identifiers":["zwave2mqtt_nodeID_6"],"manufacturer":"Linear (Nortek Security Control LLC)","model":"0x0203","name":"WAPIRZ-1 Motion Sensor","sw_version":"4.84"},"name":"nodeID_6_contact","unique_id":"zwave2mqtt_nodeID_6_6-48-1-0"}
Sensor 2 reports this on the discovery topic
{"payload_on":true,"payload_off":false,"value_template":"{{ value_json.value }}","device_class":"door","state_topic":"zwave2mqtt/10/48/1/0","json_attributes_topic":"zwave2mqtt/10/48/1/0","device":{"identifiers":["zwave2mqtt_nodeID_10"],"manufacturer":"Vision Security","model":"0x2101","name":"ZP3111 Multisensor 4in1","sw_version":"5.01"},"name":"nodeID_10_contact","unique_id":"zwave2mqtt_nodeID_10_10-48-1-0"}
Over time these topics do not change from the initial value and at best re-report the same value
{"value_id":"6-48-1-0","node_id":6,"class_id":48,"type":"bool","genre":"user","instance":1,"index":0,"label":"Sensor","units":"","help":"Binary Sensor State","read_only":true,"write_only":false,"min":0,"max":0,"is_polled":false,"value":true}
{"value_id":"10-48-1-0","node_id":10,"class_id":48,"type":"bool","genre":"user","instance":1,"index":0,"label":"Sensor","units":"","help":"Binary Sensor State","read_only":true,"write_only":false,"min":0,"max":0,"is_polled":false,"value":false}
This leads to Home Assistant not getting updated values either.
Expected behavior
Using MQTT Explorer I find the motion reported on topic 6/113/1/7 and 10/113/1/7
The first device goes to "Intrusion at Unknown Location" for 5 seconds then goes back to "Clear"
12:30:51
{"value_id":"6-113-1-7","node_id":6,"class_id":113,"type":"list","genre":"user","instance":1,"index":7,"label":"Home Security","units":"","help":"Home Security Alerts","read_only":true,"write_only":false,"min":0,"max":0,"is_polled":false,"values":["Clear","Intrusion at Location","Intrusion at Unknown Location","Tampering -  Cover Removed","Tampering - Invalid Code","Glass Breakage at Location","Glass Breakage at UnknownLocation","Motion Detected at Location","Motion Detected at Unknown Location","Tampering - Product Moved","Unknown Event"],"value":"Intrusion at Unknown Location"}
12:30:56
{"value_id":"6-113-1-7","node_id":6,"class_id":113,"type":"list","genre":"user","instance":1,"index":7,"label":"Home Security","units":"","help":"Home Security Alerts","read_only":true,"write_only":false,"min":0,"max":0,"is_polled":false,"values":["Clear","Intrusion at Location","Intrusion at Unknown Location","Tampering -  Cover Removed","Tampering - Invalid Code","Glass Breakage at Location","Glass Breakage at UnknownLocation","Motion Detected at Location","Motion Detected at Unknown Location","Tampering - Product Moved","Unknown Event"],"value":"Clear"}
Additional context
Has anyone experienced this before? I need to resolve this or come up with a workaround before I could consider moving to Home Assistant zwave2mqtt.
Would I get better results using only Home Assistant native zwave and not using zwave2mqtt at all? One of the attractions of zwave2mqtt is having it decoupled from the home automation system but I obviously need my motion sensors working.
If the sensors blip over to motion for just a few seconds how can I automate from that? I'm used to my motion sensors being "tripped" for a few minutes.
Thank you

Hi @chr55, thanks for your issue, unfortunally based on your logs it is difficult to debug the problem, it could be a device problem for sure if the new one is correctly working. Can I close this so?

With so many of my motion sensors not working in zwave2matt / Home Assistant I will stay on my current home automation platform ( HomeSeer ) where they are working perfectly. Thank you for the response. You can close this ticket.


mydump: fix infinite loop in ExportStatement when Read() returns an error but is not EOF

What problem does this PR solve?
In the ExportStatement() function, if the reader errored which is not EOF, it will cause the function go into an infinite loop because the error is ignored.
What is changed and how it works?
Handle the error.
Check List
Tests

Unit test

Side effects
Related changes

LGTM


dynamic routing support

What problem does this feature solve?
dynamic routing like react-router-v4
What does the proposed API look like?
Are there plans to upgrade vue-router to dynamic routing (like react-router-v4)

Please check existing issues for addRoutes, replaceroutes, etc
To be clear, dynamic routing is not an upgrade, it's a different way of working with its own disadvantages and advantages


Content-Type header check is case sensitive

I was getting anomalous behavior where the Content-Type header wasn't matching; when I had the expected value as "application/json" it would tell me it was failing to match "application/json; charset=UTF-8" and when I expected the latter it would tell me it was failing to match the former. I finally discovered that there were two Content-[Tt]ype headers in the received request.
It turns out that my client was sending only one Content-type header, but that there is a case-sensitive check in PactDslRequestWithPath in the body(DslPart) method which says that if the request headers do not contain the key "Content-Type" to add it. This is a case-sensitive match and results in two headers on the request if the client is sending the header with a different case.

Fixed in 4.1.2


Tutorial Improvements: recommend naming structure

The sqitch tutorial doesn't seem to have any recommendations for how to name the changes. Having some sort of a common convention would be nice.
Maybe something like:
deploy/
   functions
   tables
   types
   alterations # used for adding columns to tables/types
   indexes
   schemas

So, a new function would be functions/insert_flip.
Adding a column to the orders table would be alterations/orders_add_email_address

@theory are you still looking for contributors on this? @spatrickkelly and I are trying to develop naming conventions, but would love to leverage existing. Is there any existing documentation on naming conventions? If yes, where? If not, where could we put forth our ideas for review by you and the community?

No document, though I have my own conventions, I guess. Others in my office use different conventions. Happy to discuss on the mail list.


Corrected the syntax of format.yml

Fixes #154
Proposed Changes

Corrected the error int the syntax of format.yml

@rajitha1998 can you please review this!