segfault when C client used with Git

I'm compiling the Hyper C bindings into libcurl, and then building git with this libcurl attached. Unfortunately I'm getting a segfault when I try to use the resulting git binaries.
Steps to reproduce:

install Git with Hyper+Rustls support (I set this up for Macs at brew install meterup/safe/git if you want to give it a try)
check out the Go source tree from https://go.googlesource.com/go
Try to run "git pull origin master"

Running with GIT_TRACE=1 GIT_CURL_VERBOSE=1 I get the following error message:
$ GIT_TRACE=1 GIT_CURL_VERBOSE=1 glob
12:27:20.721657 git.c:444               trace: built-in: git rev-parse --symbolic-full-name --abbrev-ref HEAD
12:27:20.728892 git.c:444               trace: built-in: git pull origin master
12:27:20.731244 run-command.c:664       trace: run_command: git fetch --update-head-ok origin master
12:27:20.735904 git.c:444               trace: built-in: git fetch --update-head-ok origin master
12:27:20.739273 run-command.c:664       trace: run_command: GIT_DIR=.git git remote-https origin https://go.googlesource.com/go
12:27:20.743706 git.c:730               trace: exec: git-remote-https origin https://go.googlesource.com/go
12:27:20.744143 run-command.c:664       trace: run_command: git-remote-https origin https://go.googlesource.com/go
12:27:20.754890 http.c:756              == Info: STATE: INIT => CONNECT handle 0x7fcaf5821608; line 1646 (connection #-5000)
12:27:20.755407 http.c:756              == Info: Couldn't find host go.googlesource.com in the .netrc file; using defaults
12:27:20.755422 http.c:756              == Info: Added connection 0.  Let me know what other information you'd need to help track this down. I tried running with RUST_BACKTRACE=1 but that didn't yield anything useful.
FWIW on Mac there should be a log in the console and then the crash files are in ~/Library/Logs/DiagnosticReports. Here's the crash file for this segfault.
$ cat /System/Volumes/Data/Users/kevin/Library/Logs/DiagnosticReports/git-remote-http_2021-02-15-125656_HYENA-2.crash
Process:               git-remote-http [92372]
Path:                  /usr/local/Cellar/git/2.30.1/libexec/git-core/git-remote-http
Identifier:            git-remote-http
Version:               ???
Code Type:             X86-64 (Native)
Parent Process:        ??? [92371]
Responsible:           iTerm2 [40587]
User ID:               501

Date/Time:             2021-02-15 12:56:55.619 -0800
OS Version:            Mac OS X 10.15.7 (19H512)
Report Version:        12
Anonymous UUID:        D2590148-2569-50FD-C193-1A6BC086FB3F

Sleep/Wake UUID:       9CC3BC5D-1490-49A1-A53E-F7A58929B21C

Time Awake Since Boot: 230000 seconds
Time Since Wake:       14000 seconds

System Integrity Protection: enabled

Crashed Thread:        0  Dispatch queue: com.apple.main-thread

Exception Type:        EXC_BAD_ACCESS (SIGSEGV)
Exception Codes:       KERN_INVALID_ADDRESS at 0x0000000000000008
Exception Note:        EXC_CORPSE_NOTIFY

Termination Signal:    Segmentation fault: 11
Termination Reason:    Namespace SIGNAL, Code 0xb
Terminating Process:   exc handler [92372]

VM Regions Near 0x8:
-->
    __TEXT<PHONE_NUMBER>34e000-00000001054a6000 [ 1376K] r-x/r-x SM=COW  /usr/local/Cellar/git/2.30.1/libexec/git-core/git-remote-http

Thread 0 Crashed:: Dispatch queue: com.apple.main-thread
0   git-remote-https              	0x0000000105430b58 strbuf_grow + 16
1   git-remote-https              	0x0000000105431020 strbuf_add + 27
2   git-remote-https              	0x00000001053556d5 fwrite_buffer + 27
3   libcurl.4.dylib               	0x00000001055312ba Curl_hyper_stream + 594
4   libcurl.4.dylib               	0x00000001055750a8 Curl_readwrite + 203
5   libcurl.4.dylib               	0x000000010555ee73 multi_runsingle + 2128
6   libcurl.4.dylib               	0x000000010555e5aa curl_multi_perform + 113
7   git-remote-https              	0x00000001053574cb step_active_slots + 25
8   git-remote-https              	0x0000000105357532 run_active_slot + 67
9   git-remote-https              	0x00000001053577fd run_one_slot + 41
10  git-remote-https              	0x0000000105359b06 http_request + 1630
11  git-remote-https              	0x00000001053579b7 http_request_reauth + 34
12  git-remote-https              	0x0000000105354131 discover_refs + 625
13  git-remote-https              	0x00000001053533fc cmd_main + 4484
14  git-remote-https              	0x000000010535ae55 main + 130
15  libdyld.dylib                 	0x00007fff6dd79cc9 start + 1

Thread 1:
0   libsystem_pthread.dylib       	0x00007fff6df79b68 start_wqthread + 0

Thread 2:
0   libsystem_pthread.dylib       	0x00007fff6df79b68 start_wqthread + 0

Thread 0 crashed with X86 Thread State (64-bit):
  rax: 0x00007fd0b7c0d9c8  rbx: 0x0000000000000000  rcx: 0x0000000000000000  rdx: 0x0000000000000011
  rdi: 0x0000000000000000  rsi: 0x0000000000000011  rbp: 0x00007ffeea8b0710  rsp: 0x00007ffeea8b0700
   r8: 0x0000000000000000   r9: 0x0000000000000000  r10: 0x0000000000010000  r11: 0xffffffd1cd35e9a1
  r12: 0x00000000000000c8  r13: 0x00000000000000c8  r14: 0x0000000000000000  r15: 0x00007fd0b7c0d9c8
  rip: 0x0000000105430b58  rfl: 0x0000000000010217  cr2: 0x0000000000000008

Logical CPU:     0
Error Code:      0x00000004 (no mapping for user data read)
Trap Number:     14

See also abetterinternet/crustls#49 (I wasn't sure which place to submit it.)

0   git-remote-https              	0x0000000105430b58 strbuf_grow + 16
1   git-remote-https              	0x0000000105431020 strbuf_add + 27
2   git-remote-https              	0x00000001053556d5 fwrite_buffer + 27
3   libcurl.4.dylib               	0x00000001055312ba Curl_hyper_stream + 594

It looks like the stack is inside some of curl's code to grow a string buffer? I can't say for certain that's the issue, as I'm less familiar with curl's code. But to aid in tracking down, I see that Curl_hyper_stream calls status_line, which grabs an fwrite_header (or fwrite_func) function pointer, which I assume is fwrite_buffer. Perhaps it's around there?

If you can describe what patches I should make to the source code to add more debugging information, or changes to the arguments used to compile this, I'm happy to try running again, unfortunately I'm not that familiar with C code or the ecosystem, ie. I've never once ran gdb.

What I meant is that at least so far, it sounds like the segfault happens inside curl's code. I'm not too familiar with what changes you would need to debug it. It's probably worth reporting it to the curl project. (If it turns out to be something inside hyper, we can dig more over here).
For the record, I grabbed Curl_hyper_stream just by looking at the queue in your debug output. It can be read in reverse order to understand what function called the next. It's source code is available here.

FWIW, I managed to pull more information out about the crash - not sure if this helps.
Process 9264 stopped
* thread #1, queue = 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS (code=1, address=0x8)
    frame #0: 0x00000001000e2b58 git-remote-https`strbuf_grow + 16
git-remote-https`strbuf_grow:
->  0x1000e2b58 <+16>: movq   0x8(%rdi), %rax
    0x1000e2b5c <+20>: movq   %rax, %rcx
    0x1000e2b5f <+23>: notq   %rcx
    0x1000e2b62 <+26>: cmpq   %rsi, %rcx
Target 0: (git-remote-https) stopped.
(lldb) thread backtrace
* thread #1, queue = 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS (code=1, address=0x8)
  * frame #0: 0x00000001000e2b58 git-remote-https`strbuf_grow + 16
    frame #1: 0x00000001000e3020 git-remote-https`strbuf_add + 27
    frame #2: 0x00000001000076d5 git-remote-https`fwrite_buffer + 27
    frame #3: 0x00000001002ebfba libcurl.4.dylib`Curl_hyper_stream + 594
    frame #4: 0x000000010032fdf8 libcurl.4.dylib`Curl_readwrite + 203
    frame #5: 0x0000000100319a80 libcurl.4.dylib`multi_runsingle + 2113
    frame #6: 0x00000001003191c6 libcurl.4.dylib`curl_multi_perform + 113
    frame #7: 0x00000001000094cb git-remote-https`step_active_slots + 25
    frame #8: 0x0000000100009532 git-remote-https`run_active_slot + 67
    frame #9: 0x00000001000097fd git-remote-https`run_one_slot + 41
    frame #10: 0x000000010000bb06 git-remote-https`http_request + 1630
    frame #11: 0x00000001000099b7 git-remote-https`http_request_reauth + 34
    frame #12: 0x0000000100006131 git-remote-https`discover_refs + 625
    frame #13: 0x00000001000053fc git-remote-https`cmd_main + 4484
    frame #14: 0x000000010000ce55 git-remote-https`main + 130
    frame #15: 0x00007fff699fbcc9 libdyld.dylib`start + 1
    frame #16: 0x00007fff699fbcc9 libdyld.dylib`start + 1
(lldb) v
(lldb) var

(lldb) register read
General Purpose Registers:
       rax = 0x0000000102904748
       rbx = 0x0000000000000000
       rcx = 0x0000000000000000
       rdx = 0x0000000000000011
       rdi = 0x0000000000000000
       rsi = 0x0000000000000011
       rbp = 0x00007ffeefbfe700
       rsp = 0x00007ffeefbfe6f0
        r8 = 0x0000000000000000
        r9 = 0x0000000000000000
       r10 = 0x0000000000010000
       r11 = 0xffff800212d07731
       r12 = 0x00000000000000c8
       r13 = 0x00000000000000c8
       r14 = 0x0000000000000000
       r15 = 0x0000000102904748
       rip = 0x00000001000e2b58  git-remote-https`strbuf_grow + 16
    rflags = 0x0000000000010217
        cs = 0x000000000000002b
        fs = 0x0000000000000000
        gs = 0x0000000000000000

Last bit of code in Hyper, arrow points to the line that's executing at the time of the segfault.
    0x1002ebf75 <+525>:  callq  0x1002f7cb9               ; Curl_dyn_ptr
    0x1002ebf7a <+530>:  movq   %r14, %rdi
    0x1002ebf7d <+533>:  movl   $0x1, %esi
    0x1002ebf82 <+538>:  movq   %rax, %rdx
    0x1002ebf85 <+541>:  movq   %rbx, %rcx
    0x1002ebf88 <+544>:  callq  0x100320273               ; Curl_debug
    0x1002ebf8d <+549>:  movq   %r14, %rdi
    0x1002ebf90 <+552>:  movl   $0x1, %esi
    0x1002ebf95 <+557>:  callq  0x10031b17e               ; Curl_set_in_callback
    0x1002ebf9a <+562>:  movq   %r15, %rdi
    0x1002ebf9d <+565>:  callq  0x1002f7cb9               ; Curl_dyn_ptr
    0x1002ebfa2 <+570>:  movq   0x1f0(%r14), %rcx
    0x1002ebfa9 <+577>:  movl   $0x1, %esi
    0x1002ebfae <+582>:  movq   %rax, %rdi
    0x1002ebfb1 <+585>:  movq   %rbx, %rdx
    0x1002ebfb4 <+588>:  callq  *-0x160(%rbp)
->  0x1002ebfba <+594>:  movq   %rax, %r15
    0x1002ebfbd <+597>:  movq   %r14, %rdi
    0x1002ebfc0 <+600>:  xorl   %esi, %esi
    0x1002ebfc2 <+602>:  callq  0x10031b17e               ; Curl_set_in_callback

strbuf_grow
git-remote-https`strbuf_grow:
    0x1000e2b48 <+0>:   pushq  %rbp
    0x1000e2b49 <+1>:   movq   %rsp, %rbp
    0x1000e2b4c <+4>:   pushq  %r14
    0x1000e2b4e <+6>:   pushq  %rbx
    0x1000e2b4f <+7>:   cmpq   $-0x1, %rsi
    0x1000e2b53 <+11>:  je     0x1000e2bb1               ; <+105>
    0x1000e2b55 <+13>:  movq   %rdi, %r14
->  0x1000e2b58 <+16>:  movq   0x8(%rdi), %rax
    0x1000e2b5c <+20>:  movq   %rax, %rcx
    0x1000e2b5f <+23>:  notq   %rcx
    0x1000e2b62 <+26>:  cmpq   %rsi, %rcx


Add testing with PyTorch 1.11 on GPUs in CI

🚀 Feature
We've decided to have testing with both PyTorch LTS and stable release (1.8 and 1.11 as of now) in CI, and we've already seen some issues arose while trying to enable it in #12373.
TODO
Known issues with PL with PyTorch 1.11

[x] #12846
[x] #12860
[ ] Fix an issue with fitting a model initialised in init_meta_context #12870
[x] Fix an issue with DDP comm tests with some newer PyTorch versions #12878
[ ] Fix an issue with inference mode with FSDP

Motivation
To test new features, e.g. meta init and native FSDP, in CI that are only available in newer PyTorch versions.
Pitch
Use the following image:
pytorchlightning/pytorch_lightning:base-cuda-py3.7-torch1.11

Alternatives
n/a
Additional context
n/a

If you enjoy Lightning, check out our other projects! ⚡

Metrics: Machine learning metrics for distributed, scalable PyTorch applications.

Lite: enables pure PyTorch users to scale their existing code on any kind of device while retaining full control over their own loops and optimization logic.

Flash: The fastest way to get a Lightning baseline! A collection of tasks for fast prototyping, baselining, fine-tuning, and solving problems with deep learning.

Bolts: Pretrained SOTA Deep Learning models, callbacks, and more for research and production with PyTorch Lightning and PyTorch.

Lightning Transformers: Flexible interface for high-performance research using SOTA Transformers leveraging Pytorch Lightning, Transformers, and Hydra.

cc @carmocca @akihironitta @borda

@Borda Would it be an option to have PyTorch 1.12 (nightly) testing, too? For example, #12985 needs 1.12 for adapting FSDP native.

1.11 FSDP seems to be broken in various ways, with state_dict saving/loading issues + no mixed precision. So many fixes have come out for 1.12 (nightly) that no user really should be using 1.11, and be using 1.12 FSDP.

1.11 is fine (already released)
We removed nightly testing because it was too flaky, making everybody ignore the job. We only enable it when there's a release candidate upstream

Will be addressed in #12984.


auto-update always appears to hang

I was just prompted to update several packages, including beautify 0.2.8
After all the others finished (after only about 10 seconds) the indeterminate progress bar for beautify kept going.  Eventually, I quit Atom and on relaunch I see that 0.2.8 has indeed installed.
This has happened for the past few AB updates. No other packages do this.  Atom .207

beautify 0.2.8

Just to confirm, you mean v0.28.0?

After all the others finished (after only about 10 seconds) the indeterminate progress bar for beautify kept going. Eventually, I quit Atom and on relaunch I see that 0.2.8 has indeed installed.

Atom Beautify has quite a lot of dependencies, so it may have needed the extra time to install. How long did you let it run? Was it truly hanging or simply taking it's required time to download all of it's dependencies?

This has happened for the past few AB updates. No other packages do this. Atom .207

More than likely just more beautifiers and more dependencies required in Atom Beautify.
If it does not install, then this is an issue. However, this sounds just like it needs more time. If it does hang, then this is an apm issue: https://github.com/atom/apm/issues

OK, today I just let it go for 5 minutes until it finished, and I got this error

npm WARN `git config --get remote.origin.url` returned wrong result (https://github.com/ariya/esprima.git) xcrun: error: invalid active developer path (/Library/Developer/CommandLineTools), missing xcrun at: /Library/Developer/CommandLineTools/usr/bin/xcrun
npm ERR! git clone https://github.com/ariya/esprima.git xcrun: error: invalid active developer path (/Library/Developer/CommandLineTools), missing xcrun at: /Library/Developer/CommandLineTools/usr/bin/xcrun
npm ERR! Darwin 15.0.0
npm ERR! argv "/Applications/Atom.app/Contents/Resources/app/apm/bin/node" "/Applications/Atom.app/Contents/Resources/app/apm/node_modules/npm/bin/npm-cli.js" "--globalconfig" "/Users/stevel/.atom/.apm/.apmrc" "--userconfig" "/Users/stevel/.atom/.apmrc" "install" "/private/var/folders/10/wbtwnvx88xlfj_006s6f3kq80000gn/T/d-115510-1379-16j1xhn/package.tgz" "--target=0.22.0" "--arch=x64"
npm ERR! node v0.10.35
npm ERR! npm  v2.5.1
npm ERR! code 1

npm ERR! Command failed: xcrun: error: invalid active developer path (/Library/Developer/CommandLineTools), missing xcrun at: /Library/Developer/CommandLineTools/usr/bin/xcrun
npm ERR!
npm ERR!
npm ERR! If you need help, you may report this error at:
npm ERR!     <http://github.com/npm/npm/issues>

npm ERR! Please include the following file with any support request:
npm ERR!     /private/var/folders/10/wbtwnvx88xlfj_006s6f3kq80000gn/T/apm-install-dir-115510-1379-1vzqae4/npm-debug.log

And it failed to update.

invalid active developer path

Looks like your computer is not setup yet / properly for apm to do whatever it needs to do.
I'd recommend forwarding this over to https://github.com/atom/apm/issues or https://discuss.atom.io/ for some help with that.

From an Atom Beautify perspective: I think https://github.com/Glavin001/atom-beautify/issues/320 will resolve this issue above (taking too long to install), as it will make all of the beautifier dependencies loaded upon usage. This means that it will install quickly and then when you first use it, then it will download and install third-party packages that are required.

Yes, I recently updated this one to 10.11b1.  I had to install the latest command line tools.
But now I see

I'll try it on my other 10.10.4 mac.

Note that other pckages updated fine

I have no clue where to start with the error undefined. I'd recommend talking with the Atom/apm team at https://github.com/atom/apm/issues and if there is more information to provide maybe I can help then.

On my 10.10.4 rMBP, "updating" is still going after 1/2 hour.  Like in original bug, I am able to quickly update all other packages and Atom.  I'll check with them.

On my 10.10.4 rMBP, "updating" is still going after 1/2 hour.

 Something is definitely wrong with your setup or Internet connection. Takes a matter of seconds over my wifi to download both production and development dependencies for this package.
Furthermore, I have both Travis CI (Mac) and AppVeyor (Windows) setup and running well and confirming my assumption that everything is downloading and installing properly:

https://travis-ci.org/Glavin001/atom-beautify
https://ci.appveyor.com/project/Glavin001/atom-beautify

It takes about 6 minutes to download and install Atom, multiple languages and many third-party beautifiers (see https://github.com/Glavin001/atom-beautify#language-support and note that most beautifiers are written in other languages and not Node.js), Atom Beautify and it's package dependencies, and then completely run all of the tests. See https://github.com/Glavin001/atom-beautify/blob/master/.travis.yml#L31-L54 for Travis CI and what it installs along with the Atom Beautify package itself. All freshly completed in 6 minutes.

Like in original bug, I am able to quickly update all other packages and Atom.

Yup. I definitely want to speed things up (See https://github.com/Glavin001/atom-beautify/issues/391#issuecomment-110933831 ) however it should not (does not, see Travis CI and AppVeyor) take that long to install.
I hope the Atom team can help you with this!

ok.   i have, for now, deleted the package and re-installed via APM which has worked.  Let's see how the next update goes.  Thanks.


Add gitignore

This change is

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from the review on Reviewable.io


update SDK sha and add comment

Update missing SDK sha and add helpful comment.

Adding a commit to build the Dockerfiles as part of CI to catch this in the future.  The commit has been poisoned to verify that it fails appropriately.  Once that's good, I'll back out the wrong values.

With a bad SHA, the build failed with:
sha512sum: WARNING: 1 computed checksum did NOT match

Restored appropriate SHA, so once green it should be good to go.

@colombod Is there a special syntax used in Binder Dependencies/Dockerfile?  The build of the image is failing with:
Step 17/36 : COPY ./notebooks/ ${HOME}/notebooks/
COPY failed: stat /var/lib/docker/tmp/docker-builder468519462/notebooks: no such file or directory

Or are there extra arguments we need to specify?


[HOLD #40548][$250] Dev-Unable to send a message

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number:
Reproducible in staging?: N/A
Reproducible in production?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @ishpaul777
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1722528633557129
Action Performed:

Open the app
Compose a message to any receiver and click Send button

Expected Result:
Message delivered to recipient
Actual Result:
Unable to send
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[ ] Android: mWeb Chrome
[x] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence
https://github.com/user-attachments/assets/37cb635f-8575-40b6-94d4-04b1d3a6e788

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01fb2184646c58f366
Upwork Job ID:<PHONE_NUMBER>952085072
Last Price Increase: 2024-08-13

Issue OwnerCurrent Issue Owner: @

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

oh awesome! Closing without next steps.

@ishpaul777 do you want to fix this issue here or is there another GH?

awesome! Thanks @ishpaul777 - let's get some proposals.

@ishpaul777 can you check out this proposal when possible? https://github.com/Expensify/App/issues/46823#issuecomment-2273916239

FYI, newer react-native-gesture-handler versions require React Native 0.74 or higher. Otherwise, the iOS app will crash as described in the issue below.
https://github.com/software-mansion/react-native-gesture-handler/issues/2927#issuecomment-2144763757

Our current policy regarding the new architecture support is to support only the most recent version, which at the time of writing is 0.74.

Update for Melvin - we're reviewing proposals

just checking in on this - how is the review going @ishpaul777?

Sounds good @ishpaul777 - thanks for the investigation. I added a HOLD to this GH while https://github.com/Expensify/App/pull/40548 is in the works.

https://github.com/Expensify/App/pull/40548 is closed. In my testing this is resolved - asking QA to test again.

Sorry @ishpaul777 I'm not sure I understand what is next for this. Are we reviewing proposals or waiting for something?

Looks like https://github.com/Expensify/App/pull/45289 is in staging so I think we can test this again. I'll move to daily to try and test today/tomorrow unless you can get to it @ishpaul777

Hum, I think this is resolved, @ishpaul777 can you double-check?


$env:PATH does not pick up settings in /etc/paths at startup on macOS

Prerequisites

[X] Write a descriptive title.
[X] Make sure you are able to repro it on the latest released version
[X] Search the existing issues.
[X] Refer to the FAQ.
[X] Refer to Differences between Windows PowerShell 5.1 and PowerShell.

Steps to reproduce
I'm using iTerm2 on macOS 11.8 and pwsh 7.1.4
I noticed an issue when I changed my iTerm default profile to run pwsh directly. Previously it would start zsh and issue the command pwsh, where my $env:PATH variable would match the $PATH variable of the zsh session that launched it.
When launching pwsh directly, the default $env:PATH value is /usr/local/microsoft/powershell/7:/usr/bin:/bin:/usr/sbin:/sbin and does not include any of the values specified in /etc/paths and /etc/paths.d/.
I created a small workaround for now and added to my profile:
# Fix $env:PATH to include system paths. First turn the variable into an array
[System.Collections.ArrayList]$PATH = $env:PATH -split ':'
# Append the system paths
$PATH += (Get-Content /etc/paths)
$PATH += (Get-ChildItem /etc/paths.d/ | ForEach-Object {Get-Content $_})
#Set the viariable
$env:PATH = ($PATH | Select-Object -Unique) -join ':'

Expected behavior
$env:PATH should include the system entries from /etc/paths and /etc/paths.d/*, just like zsh (and likely bash) do.

Actual behavior
$env:PATH = /usr/local/microsoft/powershell/7:/usr/bin:/bin:/usr/sbin:/sbin

Error details
No response
Environment data
Name                           Value
----                           -----
PSVersion                      7.1.4
PSEdition                      Core
GitCommitId                    7.1.4
OS                             Darwin 20.6.0 Darwin Kernel Version 20.6.0: Mon Aug 30 06:12:20 PDT 2021; root:xnu-7195.141.6~3/RELEASE_ARM64_T8101
Platform                       Unix
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
WSManStackVersion              3.0

Visuals
No response

@mcx808
it's not clear in the issue how you're starting pwsh, but be sure to use -login when starting pwsh (or invoke with the tickbox for login shell).
here's an article that might help:
https://stackoverflow.com/questions/1276703/how-to-make-zsh-run-as-a-login-shell-on-mac-os-x-in-iterm

Hi @JamesWTruher, right you are.
I was starting pwsh by setting the command /usr/local/microsoft/powershell/7/pwsh as my powershell profile in iTerm2, and adding the -login switch does then set my $env:PATH correctly.
I'll add this screenshot of the correct setting for posterity:

Just to add here:

The /etc/paths behaviour only occurs for login shells
pwsh supports this because it supports login shell behaviour by reusing zsh on macOS (it execs itself, so inherits all environment variables)
However, you must ensure that pwsh is started as a login shell
You can do this explicitly by passing -l as the first switch, or
If you configure it as a login shell with chsh and add it to /etc/shells, the OS will start it with a - in the process name and it will infer that it's a login shell

seems I could not make it works even I set it as default login shell or add the -login option


feat(Form): use nuxt's useId to bind input labels

🔗 Linked issue
https://github.com/nuxt/ui/issues/1171

❓ Type of change

[ ] 📖 Documentation (updates to the documentation or readme)
[ ] 🐞 Bug fix (a non-breaking change that fixes an issue)
[x] 👌 Enhancement (improving an existing functionality)
[ ] ✨ New feature (a non-breaking change that adds functionality)
[ ] 🧹 Chore (updates to the build process or auxiliary tools and libraries)
[ ] ⚠ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description
Replaces our custom unique id generation by nuxt's useId to bind accessibility attribute in a SSR friendly way.

📝 Checklist

[ ] I have linked an issue or discussion.
[ ] I have updated the documentation accordingly.

@romhml https://nuxt.com/blog/v3-10#ssr-safe-accessible-unique-id-creation 🔥 I've updated nuxt to 3.10.0 on dev branch!

Great 🚀! I'll wrap this up!

Let me know how it goes! On my side, I'll try to use this composable to fix all the Headless UI hydration issues since Vue 3.4.

@benjamincanac I had to remove the dependencies overrides for nuxt/kit and nuxt/schema for useId to fix this error. Also unpinned vue since we should not have any more hydration issues, which caused unrelated typechecks issues. Do you have any insights on this? Especially this one: https://github.com/nuxt/ui/actions/runs/7719033426/job/21041516307?pr=1211#step:11:16

I've updated the resolutions, sorry I missed that on the upgrade! The typecheck errors should be gone too if you update your branch from dev!
The hydration issues won't be fixed until we take advantage of useId and pass it to all Headless UI components.. I'll try to do this asap!

Thanks @romhml! 😊

Sorry for spamming. Just wondering if there is a way to see when this will be shipped. Is there a way to check the version this will be shipped at?

This will be shipped tomorrow as part of the v2.14.0.


Can bookstack be used without virtualhost?

So the documentation and any guides I see for this use a virtualhost on the web server to access bookstack. However I don't want bookstack to be the root site on the web server nor do I want to have to use a port other than 80.
Can I not set this up on apache to be access via just http://server/bookstack ?

You cannot host any app on apache without using vhosts - i think you did not understand it's purpose.
A vhost is to resolve the users request and load the right site given by that configuration. The same is with your /bookstack - that is an alias and simply one line you need to add to your vhost config.
Furthermore you should not run any app on HTTP anymore which includes a login - 443/https is the way to go.
<VirtualHost *:443>
    ServerName example.com
    DocumentRoot /var/www/bookstack

    # either one of these two alias
    Alias /bookstack
    Alias /bookstack "/var/www/bookstack

    <Directory "/var/www/bookstack">
        Options None
        AllowOverride None
        Order allow,deny
        Allow from all
    </Directory>
</VirtualHost>

Many PHP web apps/sites can be used just via Directory directives without VirtualHosts, that's what I was after, since that fits my situation better. Thanks though


sounddevice.PortAudioError: Error getting stream time

Using friture-git I've encountered this issue:
File "/usr/lib/python3.5/site-packages/sounddevice.py", line 1069, in time
  raise PortAudioError('Error getting stream time')
sounddevice.PortAudioError: Error getting stream time

You should ask the friture-git people then.

Did you get an answer there?
It might be helpful to other people who stumble upon this issue.

Yes loop-printed line was fixed here
https://github.com/tlecomte/friture/issues/53

Thanks, that's good to know!


PLAT-72711: Design and implement an Enact theme standard config

Backward-compatible rewrite of the option parser for the enact object in package.json. Same option names, but with recursive/computed theme support. Will now support the following parse-order:

Environment variable level. Top level overriding in the form ENACT_<OPTION>.
App-level settings.  The normal options in an app's enact object in the package.json. Same options/values supported like before
Theme-level config.  The theme option in #2 will direct Enact dev-utils/CLI to read that package's package.json as well as auto-detect the presence of certain files (screentypes, fontgenerator). The adds the ability for theme packages to include their own settings, such as theme-specific html templates, resolution independence, etc..

Furthermore, themes can now extend other theme, with recursive inheritance of config values. For example, we could have a library called moonstone-extra that has its enact object set "theme": "moonstone" to inherit all the moonstone default config, and then have it own local overriding screentypes.
Enact-DCO-1.0-Signed-off-by: Jason Robitaille<EMAIL_ADDRESS>

Updated based off comments


Youtube serves different itags (was: youtube-dl 2013.10.07 does not always pick highest resolution)

Was downloading videos from youtube user DiapasonRecords and saw that it wasn't downloading the max resolution for few videos randomly.

I agree completely.

@strelec: No re-encoding is performed. ffmpeg simply merges the raw audio and video streams into the final file.

I think you guys can close this one now. youtube-dl is picking the best resolution by default and muxing to mkv.
Any objections?

I'm fine with the infinitely long format string ;-)
Ok, seriously, you can close it. Thanks.


samples: subsys: ipc: ipc_service: keep using remote harness

Temporary solution as there is no such harness as remote. However console regex are not defined yet.

Without this PR, twister is expecting ztest output from that test, which is obviously not valid.


improve iop4 cmd config options and log viewing

This PR:

adds support for overriding any config option from the command line as iop4 -o option1=value1 -o option2=value [...].

improves the filtering and highlighting by a search string in the web gui log viewer.
Now it correctly highlights any string without breaking the html log, and the page does not become unresponsive when filtering and highlighting big logs. It also starts showing the log as it receives it, instead of loading it whole first.

adds support for showing multiple logs in the web. Now logs are stored in the [datadir]/logs/ directory, and the portal allows selecting any log file to display. This will allow datachekers to inspect the logs from different and previous runs of iop4.

Tests passing in local.


Lutz von Hohenzollern (G4)

text: Lutz rule is changed? now if controler Lutz ousted his special dont work?
link: https://www.vekn.net/forum/rules-questions/79952-when-does-lutz-ability-trigger

Duplicate


AbstractJavaVirtualMachine.getCommandLine() is currently stubbed out, can't retrieve CLI parameters for Pre-Unified log.

Describe the bug
The getCommandLine() method has been stubbed out with a TODO.  See https://github.com/microsoft/gctoolkit/blob/1476fc128465991f2c531645c780d3ed7c865f2c/api/src/main/java/com/microsoft/gctoolkit/jvm/AbstractJavaVirtualMachine.java#L84
Expected behavior
Expected this method, or child override in PreUnifiedJavaVirtualMachine to return the command line string from a Pre-Unified log file.
Additional context
There is a pending issue for building the Command Line args for Unified logging here: https://github.com/microsoft/gctoolkit/issues/263 which states that retrieving the command line is supported for Pre-Unified log files.  However, the AbstractJavaVirtualMachine.getCommandLine() method is not overridden in PreUnifiedJavaVirtualMachine so the Abstract method is used instead.
Not sure if this was stubbed out while waiting for issue 263 or an oversight.

@kcpeppe & @dsgrieve for comment

This is behaviour that we had in Censum but didn't get transferred to GCToolKit. It is a lower priority item for me ATM.


Question about plot

❓ Questions & Help

PyG is a powerful frame in graph representation field.
I want to know how to draw a picture that can reflected the clustering ability of a model.
Thank you!

For this, most people typically use the node embeddings produced by your GNN and visualize them via T-SNE. You can find an example here.

For this, most people typically use the node embeddings produced by your GNN and visualize them via T-SNE. You can find an example here.

Fine,thank you!
The number of elements in colors should be equaled to num_classes.
Am I right?

That's correct.


Cannot disable updater.

So, I've just installed this via the overlay, and when I try to run DiscordCanary, I'm told there's a new update, and I have drop down menu where I can select .deb, .tar.gz, or I'll figure it out. How do I disable the automatic update mechanism?

This is Discord's built-in updater, and has nothing to do with this overlay or powercord.
I'm not aware of any methods to bypass it. You just have to wait for nixpkgs to update it, or override the src yourself temporarily to a newer version (something like this https://github.com/LavaDesu/flakes/blob/3fb3e60768061fe8d62ca298bb768ed533140aa6/overlays/discord.nix)


Use next() builtin

Beginning pylint and unit tests.
See https://cmssdt.cern.ch/jenkins/job/DMWM-PR-test/159/ for details

Summary of pylint changes for pull request 6088:
test/python/WMComponent_t/WorkQueueManager_t/WorkQueueManager_t.py fails the pylint check. Report follows:

Line 98 in WorkQueueManagerTest.testComponentBasic W0101 Unreachable code
Line 47 in WorkQueueManagerTest.setSchema W0201 Attribute 'couchApps' defined outside init
Line 46 in WorkQueueManagerTest.setSchema W0201 Attribute 'schema' defined outside init
Line 24 W0611 Unused import fakeReqMgr
Line 14 W0611 Unused import Popen
Line 22 W0611 Unused import localQueue
Line 12 W0611 Unused import shutil
Line 15 W0611 Unused import types
Line 8 W0611 Unused import logging
Line 17 W0611 Unused import loadConfigurationFile
Line 20 W0611 Unused import WorkQueueManagerReqMgrPoller
Line 29 W0611 Unused import WorkQueueReqMgrInterface
Line 14 W0611 Unused import PIPE
Line 22 W0611 Unused import WorkQueue
Line 13 W0611 Unused import WMCore
Line 7 W0611 Unused import os
plus 9 comments on code style

Unit test changes for pull request 6088:

WMCore_t.WebTools_t.REST_t.RESTTest:testException was deleted. Prior status was success
WMCore_t.WebTools_t.REST_t.RESTTest:testSanitiseAssertFail was deleted. Prior status was error
WMCore_t.WebTools_t.NestedModel_t.NestedModelTest:testOuterFooError changed from error to success
WMCore_t.WebTools_t.REST_t.RESTTest:testListTypeArgs was deleted. Prior status was success
WMCore_t.WebTools_t.REST_t.RESTTest:testSanitiseFailHTTP changed from error to success
WMCore_t.WebTools_t.REST_t.RESTTest:testSanitisePass was deleted. Prior status was error
WMCore_t.WebTools_t.REST_t.RESTTest:testBadVerbEcho was deleted. Prior status was success
WMCore_t.WebTools_t.REST_t.RESTTest:testBadPing was deleted. Prior status was error
WMCore_t.WebTools_t.REST_t.RESTTest:testPing was deleted. Prior status was error
WMCore_t.WebTools_t.NestedModel_t.NestedModelTest:testInnerPingError was deleted. Prior status was success
WMCore_t.WebTools_t.REST_t.RESTTest:testA was deleted. Prior status was success
WMCore_t.WebTools_t.REST_t.RESTTest:testDAOBasedHTTP was deleted. Prior status was failure
WMCore_t.Agent_t.HarnessCouchBackend_t.HarnessCouchBackend_t:testAddWorker changed from failure to success
WMCore_t.WebTools_t.RESTFormat_t.RESTFormatTest:testEncodedInput was deleted. Prior status was failure

Please merge this, @ticoann


[Bug]: DOIs excluded from export in 6.7.86

Debug log ID
WPZZZZKZ-refs-euc
What happened?
After upgrading to version 6.7.86, exported .bib files no longer include the doi field.
On version 6.7.79 with identical settings and library items, the doi field was included as expected. See the attached pair of files for a minimal example.  (They're .bib files: I added a .txt extension because Github requires it.)
6_7_86.bib.txt
6_7_79.bib.txt
My export preferences are set to "both" for items with both DOI and URL. (But in any case, on 6.7.86 the DOI is missing even for items with no URL.)

Oh .88 didn't release. On it.

That's working correctly for me with the test build now. Thanks very much for the quick fix!

Thanks for reporting it. .91 is out, but it's just a rebadged .4525. You can request an upgrade manually or wait for a day or two until Zotero checks for updates.


[SP-2838] Backport of PDI-14133 - Transformation Steps Missing Help L…

…inks (6.1 Suite)
cherry-pick:
[PDI-14133] Steps missing help links
Conflicts:
src/org/pentaho/di/trans/steps/cassandrainput/CassandraInputMeta.java
src/org/pentaho/di/trans/steps/cassandraoutput/CassandraOutputMeta.java

Build Completed
:x: This pull request has errors. They will need to be addressed before it can be accepted. See below for more details. Some links are also available below for further assistance in addressing those issues.
Build Commands
ant -Dtestreports.dir=bin/reports/unit-test -f build.xml clean-all resolve jacoco && ant -Dtestreports.dir=bin/reports/integration-test -f build.xml jacoco-integration checkstyle publish-local

Cleanup Commands
rm -r ~/.ivy2/local || echo no publish local to remove

Changed files
  src/org/pentaho/di/trans/steps/cassandrainput/CassandraInputMeta.java
  src/org/pentaho/di/trans/steps/cassandraoutput/CassandraOutputMeta.java
  src/org/pentaho/di/trans/steps/cassandrasstableoutput/SSTableOutputMeta.java

License header violations

:heavy_exclamation_mark: Copyright year is not the current year on src/org/pentaho/di/trans/steps/cassandrainput/CassandraInputMeta.java. Found 2013. Was expecting 2016

:heavy_exclamation_mark: Copyright year is not the current year on src/org/pentaho/di/trans/steps/cassandraoutput/CassandraOutputMeta.java. Found 2013. Was expecting 2016

:heavy_exclamation_mark: Copyright year is not the current year on src/org/pentaho/di/trans/steps/cassandrasstableoutput/SSTableOutputMeta.java. Found 2013. Was expecting 2016

Build Completed
:white_check_mark: This pull request has passed all validations.
Build Commands
ant -Dtestreports.dir=bin/reports/unit-test -f build.xml clean-all resolve jacoco && ant -Dtestreports.dir=bin/reports/integration-test -f build.xml jacoco-integration checkstyle publish-local

Cleanup Commands
rm -r ~/.ivy2/local || echo no publish local to remove

Changed files
  src/org/pentaho/di/trans/steps/cassandrainput/CassandraInputMeta.java
  src/org/pentaho/di/trans/steps/cassandraoutput/CassandraOutputMeta.java
  src/org/pentaho/di/trans/steps/cassandrasstableoutput/SSTableOutputMeta.java


Dashboard draws fail if API call takes too long.

Let's think about solutions here.
The best one that I can come up with immediately is to have each function (filterHostsAndOutput and getHostsFromZabbix) call each other, but I don't know what impact that would have if settings get changed (since filterHostsAndOutput is called to redraw the screen when settings change).

Would using proper AJAX (#3) have an impact in this?

That's a really good question. I'm still convinced that #3 is mainly a result of my incompetence, but wracking my brains for a solution hasn't helped.
I think it would fix the problem, but could cause the dashboard to refresh at irregular intervals, since the dashboard simply refreshes as soon as the API call is finished. If there's variance in API calls...
Eh. Dunno. It's certainly something to think about. I'll spend some time in the indefinite future trying to get async to work properly; we'll see how it goes!
I definitely think if we do that, we have to call filterHostsAndOutput as a success callback from getHostsFromZabbix since regardless of async, filterHostsAndOutput requires data in the hosts variable.
Feel free to correct any incorrect assumptions! :)

Going to go ahead and close this. Excessive load times appears to be an issue only with multiple hundreds of hosts or with Zabbix 2.2.0, which had a bug where results would take progressively longer to return from calls to the API.


serial: bluetooth: Print warning once when ring buffer is full

When compiling with the default CONFIG_UART_LOG_LEVEL, which seems to be INF, I get endless Ring buffer full, discard prints on the console, which also seem to have jammed the BLE connection with my target due to the repeated BLE sends:

This change avoids cluttering the logging subsystem.

Please fix the compliance check error.

@dcpleung FYI all checks passed.


Render GridItems mirrored (right-to-left on html dir="ltr")

Hi,
I'd like to render the GridItems from right to left. I've seen there's support for usage in document with dir="ltr" but my document is just plain ol' European left-to-right. I'll send you a pull-request to address this issue and add a mirrored rendering (so on a html dir="ltr" this will render the GridItems left-to-right). Ah, and support for useCssTransforms or the alternative.

Will keep this open as a reminder to add a description for each option on the README


Rename "remainder" to "unincorparated"

While not technical true, it's a better name than remainder.  And i know how to spell unincorporated.


Enable OAuth authentication method for Okta

In addition to API tokens, support the auth
using an OAuth 2.0 service app credentials.
Based on okta-sdk-python docs.

@kristian-lesko thanks for opening this up! I just tested this and it looks good. Can you also update the .env.example.okta?

Thanks for the review @primetheus; I've updated the example env file as well.


fix: qcloud sync unavailable storages

这个 PR 实现什么功能/修复什么问题:
同步腾讯云不可用的存储
是否需要 backport 到之前的 release 分支:

release/2.8.0

/area region
/cc @swordqiu @yousong

Codecov Report

Merging #2499 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #2499   +/-   ##
======================================
  Coverage    7.07%   7.07%
======================================
  Files         456     456
  Lines       71889   71889
======================================
  Hits         5085    5085
  Misses      66386   66386
  Partials      418     418

Flag
Coverage Δ

#aFlag
7.07% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 065f439...f1ac134. Read the comment docs.

/lgtm

/approve


sandboxfy alerting get started part 2

Sanboxfies the Alerting get started tutorial part 2

See source doc PR: https://github.com/grafana/grafana/pull/95260

ready for review @Jayclifford345 :)


MetricX24 release

Hi, thank you for presenting the paper on https://arxiv.org/abs/2410.03983v1
Would it be possible to release the model as presented on the paper? Thank you in advance!

Hi @alvations, we have now added the code for MetricX-24 and you'll find the links to the model checkpoints on Hugging Face in the updated README.

Thank you @jjuraska!!


validate_uniqueness_of does not work

Hi I am using rspec 3.2.1 with shoulda-matchers 2.8.0 and the "validate_uniqueness_of" its not even found?
Both of these however works fine:
    it { is_expected.to validate_presence_of(:display_name) }
    it { is_expected.to validate_length_of(:display_name).is_at_least(5) }

Model
class User
  include MongoMapper::Document

  key :display_name, String, required: true, unique: true, length: { minimum: 5 }
end

Model Rspec
require 'rails_helper'

RSpec.describe User, type: :model do
  describe 'with validations' do
    it { is_expected.to validate_presence_of(:display_name) }
    it { is_expected.to validate_length_of(:display_name).is_at_least(5) }
    it { is_expected.to validate_uniqueness_of(:display_name) }
  end
end

Output
bundle exec rspec spec/models/user_spec.rb
Run options: include {:focus=>true}

All examples were filtered out; ignoring {:focus=>true}

Randomized with seed 33589

User
  with validations
    should require display_name to be set
    example at ./spec/models/user_spec.rb:7 (FAILED - 1)
    should ensure display_name has a length of at least 5

Failures:

  1) User with validations
     Failure/Error: it { is_expected.to validate_uniqueness_of(:display_name) }
     NoMethodError:
       undefined method 'validate_uniqueness_of' for #<RSpec::ExampleGroups::User::WithValidations:0x007f0b62939cb0>
     # ./spec/models/user_spec.rb:7:in `block (3 levels) in <top (required)>'

Top 3 slowest examples (0.30596 seconds, 98.3% of total time):
  User with validations should require display_name to be set
    0.29238 seconds ./spec/models/user_spec.rb:5
  User with validations should ensure display_name has a length of at least 5
    0.01294 seconds ./spec/models/user_spec.rb:6
  User with validations
    0.00064 seconds ./spec/models/user_spec.rb:7

Finished in 0.31114 seconds (files took 1.23 seconds to load)
3 examples, 1 failure

Failed examples:

rspec ./spec/models/user_spec.rb:7 # User with validations

Randomized with seed 33589

Coverage report generated for RSpec to /repos/authcentric/coverage. 26 / 26 LOC (100.0%) covered.

Other gem info
bundle show
Gems included by the bundle:
  * actionmailer (4.2.0)
  * actionpack (4.2.0)
  * actionview (4.2.0)
  * activejob (4.2.0)
  * activemodel (4.2.0)
  * activerecord (4.2.0)
  * activesupport (4.2.0)
  * arel (6.0.0)
  * awesome_print (1.6.1)
  * bcrypt (3.1.10)
  * better_errors (2.1.1)
  * bson (1.12.0)
  * bson_ext (1.12.0)
  * builder (3.2.2)
  * bundler (1.8.4)
  * callsite (0.0.11)
  * celluloid (0.16.0)
  * coderay (1.1.0)
  * customlogger (0.0.9)
  * database_cleaner (1.4.0)
  * diff-lcs (1.2.5)
  * docile (1.1.5)
  * erubis (2.7.0)
  * fabrication (2.12.2)
  * faker (1.4.3)
  * ffi (1.9.6)
  * formatador (0.2.5)
  * globalid (0.3.3)
  * guard (2.12.4)
  * guard-compat (1.2.1)
  * guard-rspec (4.5.0)
  * hike (1.2.3)
  * hitimes (1.2.2)
  * i18n (0.7.0)
  * json (1.8.2)
  * listen (2.8.5)
  * loofah (2.0.1)
  * lumberjack (1.0.9)
  * mail (2.6.3)
  * meta_request (0.3.4)
  * method_source (0.8.2)
  * mime-types (2.4.3)
  * mini_portile (0.6.2)
  * minitest (5.5.1)
  * mongo (1.12.0)
  * mongo_mapper (0.13.1)
  * multi_json (1.11.0)
  * nenv (0.2.0)
  * nokogiri (<IP_ADDRESS>)
  * notiffany (0.0.6)
  * plucky (0.6.6)
  * pry (0.10.1)
  * puma (2.11.1)
  * rack (1.6.0)
  * rack-contrib (1.2.0)
  * rack-test (0.6.3)
  * rails (4.2.0)
  * rails-api (0.4.0)
  * rails-deprecated_sanitizer (1.0.3)
  * rails-dom-testing (1.0.5)
  * rails-html-sanitizer (1.0.1)
  * railties (4.2.0)
  * rake (10.4.2)
  * rb-fsevent (0.9.4)
  * rb-inotify (0.9.5)
  * responders (2.1.0)
  * rspec (3.2.0)
  * rspec-context-private (0.0.1)
  * rspec-core (3.2.1)
  * rspec-expectations (3.2.0)
  * rspec-mocks (3.2.1)
  * rspec-rails (3.2.1)
  * rspec-support (3.2.2)
  * shellany (0.0.1)
  * shoulda-matchers (2.8.0)
  * simplecov (0.9.2)
  * simplecov-html (0.9.0)
  * slop (3.6.0)
  * spring (1.3.3)
  * spring-commands-rspec (1.0.4)
  * sprockets (2.12.3)
  * sprockets-rails (2.2.4)
  * thor (0.19.1)
  * thread_safe (0.3.4)
  * tilt (1.4.1)
  * timers (4.0.1)
  * tzinfo (1.2.2)

I believe this is an issue with shoulda-matchers 2.8.0. I was having the same error but reverting shoulda-matchers to 2.7.0 fixed it.

Yes it works fine now. The update fixed it.


Query on Deleting Messages

Hi,
We recently set up the CC in a test environment and noticed that, even when messages are deleted, the images and cards created within the associated storage account remain. We are concerned that this could lead to increased storage usage once the system is live. Is there an existing procedure within CC to address this issue?
Thank you

@dvijayaradhan ,
Thanks for reaching out to us!
We will check on the above query and get back to you with proper response soon.

Hello @dvijayaradhan,
Yes, when messages are deleted in Teams, the associated images and cards remain in the Azure storage account, which can indeed increase storage usage
You can opt for:
1.Retention Policy where you can set policies to delete data that is no longer needed or to retain it for a specific period.
2.You can also manually delete the images and cards from the Azure storage.
3.Or you can review your storage usage regularly to ensure efficient use of storage resources.


apcupsd: apcaccess does not respect config from services.apcupsd

Describe the bug
As per the title,
When enabling apcupsd via services.apcupsd, the apcaccess it includes in the PATH does not respect the configuration file it uses to run the daemon.
This becomes problematic when trying to restrict the interfaces on which the NIS server is listening, because apcaccess may no longer properly be able to access the server running on the local machine without explicitly providing the host information. (Normally it is read from the configuration file.)
Steps To Reproduce
Steps to reproduce the behavior:

services.apcupsd.enable = true;
services.apcupsd.configText = "NISIP some.ip.address.here";
Run apcaccess
Observe the resulting error: Error contacting apcupsd @ localhost:3551: Connection refused

Expected behavior
apcaccess should be able to read from the configuration file generated from the service, and behave accordingly.
Additional context
This could likely be solved by having the service install a wrapper which adds -f [config file] into the options when running.
Notify maintainers
@bjornfor
Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
 - system: `"x86_64-linux"`
 - host os: `Linux 6.1.0, NixOS, 23.05 (Stoat), 23.05.20221218.04f574a`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.12.0`
 - channels(root): `"nixos"`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`

Can provide flake locks if necessary.

@Infinidoge: Do you know if we need to wrap all of $out/bin/* with -f /path/to/apcupsd.conf?
FYI:

I don't have a working APC UPS anymore.
I briefly looked into whether we can build apcupsd with --sysconfdir=/etc, but it wants to install stuff to sysconfdir at build time, which breaks the Nix model.

I have a fix locally, it builds on top of https://github.com/NixOS/nixpkgs/pull/208225. When that's merged I'll post the fix.

Do you know if we need to wrap all of $out/bin/* with -f /path/to/apcupsd.conf?

I think everything but apcupsd itself needs to be wrapped (so apcaccess, apctest, apccontrol), but I don't know about the latter 2 for sure, and will check when I'm back on my PC.

I don't have a working APC UPS anymore.

Makes sense.

I briefly looked into whether we can build apcupsd with --sysconfdir=/etc, but it wants to install stuff to sysconfdir at build time, which breaks the Nix model.

Yeah I thought about that too, figured it would do something like that.
It might be possible to apply a patch to change where it places things during build time/where it looks for a config, might look into that later.

I have a fix locally, it builds on top of https://github.com/NixOS/nixpkgs/pull/208225. When that's merged I'll post the fix.

Neat, thanks!

This should fix it: https://github.com/NixOS/nixpkgs/pull/208295.


Unused variables in defaults/main.yml associated with non-existent control 4.3

Describe the Issue
The following variables are unused
# Control 4.3
# ubtu22cis_logrotate is the log rotate frequencey. Options are daily, weekly, monthly, and yearly
ubtu22cis_logrotate: "daily"

# Control 4.3
# ubtu22cis_logrotate_create_settings are the settings for the create parameter in /etc/logrotate.conf
# The permissions need to be 640 or more restrictive.
# If you would like to include user/group settings to this parameter format the var as below
# ubtu22cis_logrotate_create_settings: "0640 root utmp"
ubtu22cis_logrotate_create_settings: "0640"

Expected Behavior
n/a
Actual Behavior
n/a
Control(s) Affected
none
Environment (please complete the following information):

branch being used: devel

Additional Notes
n/a
Possible Solution
Remove the corresponding lines in defaults/main.yml.

hi @bgro
Thank you for raising this issue, this should now be addressed in the sept_issues branch.
thanks
uk-bolly


Suggestion: Better typing for key in "for in" loop.

I noticed that in generic functions when we use for in loop on object of type T then iterator element is of type keyof T
function testForIn<T>(obj: T) {
    for (let key in obj) {
        obj[key]; //key: keyof T
    }
}

But for normal code on not generic object types we always get string as type of key variable:
let example: Example = { propNumber: 1, propString: "foo" };
for (let key in example) {
    let value = example[key];
}

And in this example we'll get any as type of value and error when we'll use noImplicitAny
Suggestion:
Can't we infer the type of key as keyof typeof example which is "propString" | "propNumber". It looks more consistent with generics behavior.
Of couse right now we can do workaround like this:
let example: Example = { propNumber: 1, propString: "foo" };
for (let key in example) {
    let k = key as keyof typeof example;
    let value = example[k];
}

But is it necessary? If key was properly inferred then we would have better typing (no any type when indexing) with no unnecessary additional type annotation.

The behavior is intentional, same reasoning as https://github.com/Microsoft/TypeScript/issues/13989

Ok, this reasoning make sense.
But if we had something like exact types from flow (#12936) it would be valid feature to have, right?

yes.

Automatically closing this issue for housekeeping purposes. The issue labels indicate that it is unactionable at the moment or has already been addressed.


Include license files in the derive_arbitrary crate

The derive_arbitrary crate doesn't ship the licenses it's covered under. Please ship them in the crate.

I'd be happy to merge a PR that did this, if you'd like to make one!


Support for JSP declaration tags

In complex JSP files you may have an internal declarations (custom fields of the servlet, inner classes, etc).
I have an extreme example of such JSP which mainly consists of internal class declarations embraced with <%! and %> tags. Such part should be treated as Java-code and syntax highlighting in Consulo seems to be aware of it. Though code inspections, refactorings and such treat this fragments as HTML code and warn about unusual HTML tags here and there.
Idea Ultimate Edition treats these parts of JSP correctly, though this functionality was not ported to Community Edition. Would be nice to have more correct support for JSP files in Consulo with JavaEE plugin installed.
Simplified code example:
<%@ page import="
    java.lang.*,
    java.io.*
"%>
<%!
class Test
{
    public static final String HTML = "\n" +
    "<title>Hello, World!</title>" +
    "
Hello, World!
\n" +
    "";
}
%>
<%
    out.print(Test.HTML);
%>

Screenshot in Consulo 2.0 build 1696:

Thanks for issue. I will review JSP impl. For now it's a stub. Be patient, it's a new implementation from a scratch

Thanks for your work :)
I've read articles about your IDE on habrahabr and now use it for simple Java classes development, though it would be great if J2EE was also supported so I may recommend it for my coleagues.

Hi. I am started working on JSP part. Now it's parse better JSP code.
Example

When it will pushed to release channel you can read here https://github.com/consulo/consulo/wiki/Update-channels

Great.
Could I ask one more question about plugin system? In Settings I've visited Platform and Plugins dialog. When I pressed "View available plugins" I've seen only 3 plugins all named "Platform", all having same version and updated date but different download counts. Then I've thought I cannot see already installed plugins here (though many more plugins I had not installed while installing Consulo) and removed JavaEE plugin (with dependent plugins). But after this "View available plugins" didn't show anything new - only 3 Platforms as previously.
That seems strange. So easy and convenient was initial plugin installation and so obscure how to install new plugins or update existing ones. Or existing ones are updated automatically? Then, probably, plugin list should show not only version but update date as well?

Hi. You have old build of Consulo. About -> Check for updates will update. It will update platform and plugins to new version.
I don't known your build and OS - macOS had a few update bugs in old builds (better download new Consulo build, it will be show error about plugins - then click Check for updates, and it will update plugins)

I close this complex issue. Now need create issue for each bug.
Thanks


Unable to generate go code following instructions

Describe the bug
I am following the instructions as described in the readme.md to generate golang code from an async api spec but run into issues.
How to Reproduce
I am on MacOs Catalina
node version: v14.17.0
npm version 6.14.13

npm install -g @asyncapi/generator
git clone https://github.com/asyncapi/go-template.git
Used an example asyncapi spec yaml

asyncapi: '2.0.0'
info:
  title: Streetlights API
  version: '1.0.0'
  description: |
    The Smartylighting Streetlights API allows you
    to remotely manage the city lights.
  license:
    name: Apache 2.0
    url: 'https://www.apache.org/licenses/LICENSE-2.0'
servers:
  mosquitto:
    url: mqtt://test.mosquitto.org
    protocol: mqtt
channels:
  light/measured:
    publish:
      summary: Inform about environmental lighting conditions for a particular streetlight.
      operationId: onLightMeasured
      message:
        name: LightMeasured
        payload:
          type: object
          properties:
            id:
              type: integer
              minimum: 0
              description: Id of the streetlight.
            lumens:
              type: integer
              minimum: 0
              description: Light intensity measured in lumens.
            sentAt:
              type: string
              format: date-time
              description: Date and time when the message was sent.

Ran the command

ag asyncapi.yaml go-template/template -o output

OUTPUT
Something went wrong:
Error: command failed
    at ChildProcess.<anonymous> (/usr/local/lib/node_modules/@asyncapi/generator/node_modules/@npmcli/promise-spawn/index.js:64:27)
    at ChildProcess.emit (events.js:376:20)
    at ChildProcess.emit (domain.js:470:12)
    at maybeClose (internal/child_process.js:1055:16)
    at Socket.<anonymous> (internal/child_process.js:441:11)
    at Socket.emit (events.js:376:20)
    at Socket.emit (domain.js:470:12)
    at Pipe.<anonymous> (net.js:673:12)

Expected behavior
Expected go code to be generated in the output directory

Same error that I face here

sorry folks for getting back to you so late but was out last week, super away from electronic devices 😄
I guess you want to perform generation with template cloned locally for development reasons. You cannot do ag asyncapi.yaml go-template/template -o output because you point directly to the template dir, and you should point to the root of the template. So in your case it should be ag asyncapi.yaml go-template -o output, you also need to install template dependencies manually after cloning it (npm i) as generator won't do it for you.
I ran ag asyncapi.yml ./ -o output --force-write and all worked well for me, code was generated. ./ means I ran ag from the context of cloned template repo.
Have a look at these development hints

thanks @derberg and sorry for the late reply.
I followed your instructions and ran ag asyncapi.yml ./ -o output --force-write from the context of the cloned template repo and that ran fine

No worries. Happy to help. Lemme know when you need more help


kililc give different commitments depending on the value of multiExpThreshold

multiExpThreshold == 45:
INFO [05-18|19:42:21.287] Iterating state snapshot                 accounts=114215117 slots=400207177 elapsed=12h21m26.912s eta=2.205s
INFO [05-18|19:42:21.537] Iterated snapshot                        accounts=114215117 slots=400223042 elapsed=12h21m27.162s
INFO [05-18|19:42:21.537] Computed verkle tree                     root hash="542518…3afdb6"
INFO [05-18|19:42:21.539] Number of nodes written to DB
           nodes=174639610

multiExpThreshold == 20:
INFO [05-19|04:00:27.202] Iterating state snapshot                 accounts=114215117 slots=400208359 elapsed=15h45m18.981s eta=3.19s
INFO [05-19|04:00:27.785] Iterated snapshot                        accounts=114215117 slots=400223042 elapsed=15h45m19.564s
INFO [05-19|04:00:27.785] Computed verkle tree                     root hash="2c9607…dcf64f"
INFO [05-19|04:00:27.787] Number of nodes written to DB
           nodes=689077769

Looks the same number of nodes didn't get written to othe db, which certainly explains the time difference. Is it also the reason for obtaining different roots?

actually, multiple runs with the same constant give different results, so there is an issue with our conversion code

Just verified that herumi gives the proper result, it's kilic specific.

Possible duplicate of #50, after all if kilic isn't consistent with itself, it can't be constantly consistent with herumi either.

problem identified: kilic is not thread-safe.

This issue has two parts:

GetTreeConfig wasn't reentrant and the same initialization code could be run concurrently. This has been fixed in #53.
Kilic isn't reentrant either, which has been reported upstream. Not much we can do about this for the moment, except keep #50 open as a tracking issue.

Closing this issue as it is now redundant with #50.


import with webpack

import Jolt from 'jolt-physics'

getting error
ERROR in ./js/game/test.coffee 17:0-36
Module not found: Error: Default condition should be last one

fixing it by modifing package.json
from
"exports": {
    ".": {
      "default": "./dist/jolt-physics.wasm-compat.js",
      "types": "./dist/jolt-physics.wasm-compat.d.ts"
    },

to
"exports": {
    ".": {
      "types": "./dist/jolt-physics.wasm-compat.d.ts",
      "default": "./dist/jolt-physics.wasm-compat.js"
    },

default is last now (why? dont know)
then getting error
  ERROR in ../node_modules/jolt-physics/dist/jolt-physics.js 21:20-36
  Module not found: Error: Can't resolve 'module' in 'D:\projects\js\test\node_modules\jolt-physics\dist'

  ERROR in ../node_modules/jolt-physics/dist/jolt-physics.js 21:172-201
  Module not found: Error: Can't resolve './' in 'D:\projects\js\test\node_modules\jolt-physics\dist'

I guess webpack doesn't like this parts
await import("module")

and
new URL("./",import.meta.url)

If I don't import Jolt into my code, then I will not have auto-completion.
I did read that you are not into JS world, so asking other people who can help here. Thanks.

Sorry, I indeed cannot help you here.
Maybe @isaac-mason has an opinion on swapping default and types (he added TS support)?
The await import("module") and new URL("./",import.meta.url) statements are created by emscripten, so I'm not sure why they would cause a problem.

i was digging this today, and found out that js files you provide are ESM files, means they need to be executed in html with <script type="module"
I'm looking for the old way, which is called CommonJS
Emscripten compiles it as "module" using this args
https://github.com/jrouwe/JoltPhysics.js/blob/9c086477c412fe42f7e30c7e938bd9ddd9a0bfce/CMakeLists.txt#L49-L51
If you could provide another bundles along side with "module" one, but without EXPORT_ES6 and with/without MODULARIZE, people usually make filenames like
mylib.es.js
mylib.umd.js
mylib.cjs.js
I tried to build this myself, but I'm on Windows, after successfully executed this command
cmake -B Build/Distribution -DCMAKE_BUILD_TYPE=Distribution
the next one
cmake --build Build/Distribution
failed with error
MSBuild version 17.8.3+195e7f5a3 for .NET Framework

  Checking Build System
  Generating JoltPhysics.js bindings
  Building Custom Rule H:/1/JoltPhysics.js/CMakeLists.txt
  Building JoltPhysics.js bindings
  Building Custom Rule H:/1/JoltPhysics.js/Build/Distribution/_deps/joltphysics-src/Build/CMakeLists.txt
cl : command line  error D8021: invalid numeric argument '/Werror' [H:\1\JoltPhysics.js\Build\Distribution\_deps\joltphysics-build\Jolt.vcxproj]

i went to
H:\1\JoltPhysics.js\Build\Distribution\_deps\joltphysics-src\Build\CMakeLists.txt
and commented line 134
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wall -Werror")
and get this error
Details
CMake is re-running because H:/1/JoltPhysics.js/Build/Distribution/_deps/joltphysics-build/CMakeFiles/generate.stamp is out-of-date.
  the file 'H:/1/JoltPhysics.js/Build/Distribution/_deps/joltphysics-src/Build/CMakeLists.txt'
  is newer than 'H:/1/JoltPhysics.js/Build/Distribution/_deps/joltphysics-build/CMakeFiles/generate.stamp.depend'
  result='-1'
-- Configuring done
-- Generating done
-- Build files have been written to: H:/1/JoltPhysics.js/Build/Distribution
MSBuild version 17.8.3+195e7f5a3 for .NET Framework

  Checking Build System
  Building Custom Rule H:/1/JoltPhysics.js/CMakeLists.txt
  Building Custom Rule H:/1/JoltPhysics.js/Build/Distribution/_deps/joltphysics-src/Build/CMakeLists.txt
cl : command line  warning D9002: ignoring unknown option '-g' [H:\1\JoltPhysics.js\Build\Distribution\_deps\joltphysics-build\Jolt.vcxproj]
cl : command line  warning D9002: ignoring unknown option '-ffp-model=precise' [H:\1\JoltPhysics.js\Build\Distribution\_deps\joltphysics-build\Jolt.vcxproj]
cl : command line  warning D9002: ignoring unknown option '-std=c++17' [H:\1\JoltPhysics.js\Build\Distribution\_deps\joltphysics-build\Jolt.vcxproj]
  cmake_pch.hxx.cxx
H:\1\JoltPhysics.js\Build\Distribution\_deps\joltphysics-build\CMakeFiles\Jolt.dir\Debug\cmake_pch.hxx(3,9): warning C4068: unknown pragma 'clang' [H:\1\JoltPhy sics.js\Build\Distribution\_deps\joltphysics-build\Jolt.vcxproj]
  (compiling source file 'CMakeFiles/Jolt.dir/cmake_pch.hxx.cxx')

H:\1\JoltPhysics.js\Build\Distribution\_deps\joltphysics-src\Jolt\Core\Core.h(414,12): error C2039: 'string_view': is not a member of 'std' [H:\1\JoltPhysics.js \Build\Distribution\_deps\joltphysics-build\Jolt.vcxproj]
  (compiling source file 'CMakeFiles/Jolt.dir/cmake_pch.hxx.cxx')
  C:\Program Files (x86)\Microsoft Visual Studio\2022\BuildTools\VC\Tools\MSVC\14.38.33130\include\algorithm(81,1):
  see declaration of 'std'

H:\1\JoltPhysics.js\Build\Distribution\_deps\joltphysics-src\Jolt\Core\Core.h(414,1): error C2873: 'string_view': symbol cannot be used in a using-declaration [ H:\1\JoltPhysics.js\Build\Distribution\_deps\joltphysics-build\Jolt.vcxproj]
  (compiling source file 'CMakeFiles/Jolt.dir/cmake_pch.hxx.cxx')

H:\1\JoltPhysics.js\Build\Distribution\_deps\joltphysics-src\Jolt\Math\Float4.h(13,2): error C2039: 'align_val_t': is not a member of 'std' [H:\1\JoltPhysics.js \Build\Distribution\_deps\joltphysics-build\Jolt.vcxproj]
  (compiling source file 'CMakeFiles/Jolt.dir/cmake_pch.hxx.cxx')
  C:\Program Files (x86)\Microsoft Visual Studio\2022\BuildTools\VC\Tools\MSVC\14.38.33130\include\algorithm(81,1):
  see declaration of 'std'

H:\1\JoltPhysics.js\Build\Distribution\_deps\joltphysics-src\Jolt\Math\Float4.h(13,2): error C2061: syntax error: identifier 'align_val_t' [H:\1\JoltPhysics.js\ Build\Distribution\_deps\joltphysics-build\Jolt.vcxproj]
  (compiling source file 'CMakeFiles/Jolt.dir/cmake_pch.hxx.cxx')

H:\1\JoltPhysics.js\Build\Distribution\_deps\joltphysics-src\Jolt\Math\Float4.h(13,2): error C2535: 'void *JPH::Float4::operator new(size_t)': member function a lready defined or declared [H:\1\JoltPhysics.js\Build\Distribution\_deps\joltphysics-build\Jolt.vcxproj]
  (compiling source file 'CMakeFiles/Jolt.dir/cmake_pch.hxx.cxx')
  H:\1\JoltPhysics.js\Build\Distribution\_deps\joltphysics-src\Jolt\Math\Float4.h(13,2):
  see declaration of 'JPH::Float4::operator new'

H:\1\JoltPhysics.js\Build\Distribution\_deps\joltphysics-src\Jolt\Math\Float4.h(13,2): warning C5051: attribute [[maybe_unused]] requires at least '/std:c++17';  ignored [H:\1\JoltPhysics.js\Build\Distribution\_deps\joltphysics-build\Jolt.vcxproj]
  (compiling source file 'CMakeFiles/Jolt.dir/cmake_pch.hxx.cxx')

H:\1\JoltPhysics.js\Build\Distribution\_deps\joltphysics-src\Jolt\Math\Float4.h(13,2): error C2535: 'void JPH::Float4::operator delete(void *) noexcept': member  function already defined or declared [H:\1\JoltPhysics.js\Build\Distribution\_deps\joltphysics-build\Jolt.vcxproj]
  (compiling source file 'CMakeFiles/Jolt.dir/cmake_pch.hxx.cxx')
  H:\1\JoltPhysics.js\Build\Distribution\_deps\joltphysics-src\Jolt\Math\Float4.h(13,2):
  see declaration of 'JPH::Float4::operator delete'

H:\1\JoltPhysics.js\Build\Distribution\_deps\joltphysics-src\Jolt\Math\Float4.h(13,2): error C2535: 'void *JPH::Float4::operator new[](size_t)': member function  already defined or declared [H:\1\JoltPhysics.js\Build\Distribution\_deps\joltphysics-build\Jolt.vcxproj]
  (compiling source file 'CMakeFiles/Jolt.dir/cmake_pch.hxx.cxx')
  H:\1\JoltPhysics.js\Build\Distribution\_deps\joltphysics-src\Jolt\Math\Float4.h(13,2):
  see declaration of 'JPH::Float4::operator new[]'

H:\1\JoltPhysics.js\Build\Distribution\_deps\joltphysics-src\Jolt\Math\Float4.h(13,2): error C2535: 'void JPH::Float4::operator delete[](void *) noexcept': memb er function already defined or declared [H:\1\JoltPhysics.js\Build\Distribution\_deps\joltphysics-build\Jolt.vcxproj]
  (compiling source file 'CMakeFiles/Jolt.dir/cmake_pch.hxx.cxx')
  H:\1\JoltPhysics.js\Build\Distribution\_deps\joltphysics-src\Jolt\Math\Float4.h(13,2):
  see declaration of 'JPH::Float4::operator delete[]'

H:\1\JoltPhysics.js\Build\Distribution\_deps\joltphysics-src\Jolt\Math\Float4.h(13,2): error C2065: 'inAlignment': undeclared identifier [H:\1\JoltPhysics.js\Bu ild\Distribution\_deps\joltphysics-build\Jolt.vcxproj]
  (compiling source file 'CMakeFiles/Jolt.dir/cmake_pch.hxx.cxx')

H:\1\JoltPhysics.js\Build\Distribution\_deps\joltphysics-src\Jolt\Math\Vec4.h(16,2): error C2039: 'align_val_t': is not a member of 'std' [H:\1\JoltPhysics.js\B uild\Distribution\_deps\joltphysics-build\Jolt.vcxproj]
  (compiling source file 'CMakeFiles/Jolt.dir/cmake_pch.hxx.cxx')
  C:\Program Files (x86)\Microsoft Visual Studio\2022\BuildTools\VC\Tools\MSVC\14.38.33130\include\algorithm(81,1):
  see declaration of 'std'

H:\1\JoltPhysics.js\Build\Distribution\_deps\joltphysics-src\Jolt\Math\Vec4.h(16,2): error C2061: syntax error: identifier 'align_val_t' [H:\1\JoltPhysics.js\Bu ild\Distribution\_deps\joltphysics-build\Jolt.vcxproj]
  (compiling source file 'CMakeFiles/Jolt.dir/cmake_pch.hxx.cxx')

H:\1\JoltPhysics.js\Build\Distribution\_deps\joltphysics-src\Jolt\Math\Vec4.h(16,2): error C2535: 'void *JPH::Vec4::operator new(size_t)': member function alrea dy defined or declared [H:\1\JoltPhysics.js\Build\Distribution\_deps\joltphysics-build\Jolt.vcxproj]
  (compiling source file 'CMakeFiles/Jolt.dir/cmake_pch.hxx.cxx')
  H:\1\JoltPhysics.js\Build\Distribution\_deps\joltphysics-src\Jolt\Math\Vec4.h(16,2):
  see declaration of 'JPH::Vec4::operator new'

H:\1\JoltPhysics.js\Build\Distribution\_deps\joltphysics-src\Jolt\Math\Vec4.h(16,2): warning C5051: attribute [[maybe_unused]] requires at least '/std:c++17'; i gnored [H:\1\JoltPhysics.js\Build\Distribution\_deps\joltphysics-build\Jolt.vcxproj]
  (compiling source file 'CMakeFiles/Jolt.dir/cmake_pch.hxx.cxx')

H:\1\JoltPhysics.js\Build\Distribution\_deps\joltphysics-src\Jolt\Math\Vec4.h(16,2): error C2535: 'void JPH::Vec4::operator delete(void *) noexcept': member fun ction already defined or declared [H:\1\JoltPhysics.js\Build\Distribution\_deps\joltphysics-build\Jolt.vcxproj]
  (compiling source file 'CMakeFiles/Jolt.dir/cmake_pch.hxx.cxx')
  H:\1\JoltPhysics.js\Build\Distribution\_deps\joltphysics-src\Jolt\Math\Vec4.h(16,2):
  see declaration of 'JPH::Vec4::operator delete'

H:\1\JoltPhysics.js\Build\Distribution\_deps\joltphysics-src\Jolt\Math\Vec4.h(16,2): error C2535: 'void *JPH::Vec4::operator new[](size_t)': member function alr eady defined or declared [H:\1\JoltPhysics.js\Build\Distribution\_deps\joltphysics-build\Jolt.vcxproj]
  (compiling source file 'CMakeFiles/Jolt.dir/cmake_pch.hxx.cxx')
  H:\1\JoltPhysics.js\Build\Distribution\_deps\joltphysics-src\Jolt\Math\Vec4.h(16,2):
  see declaration of 'JPH::Vec4::operator new[]'

H:\1\JoltPhysics.js\Build\Distribution\_deps\joltphysics-src\Jolt\Math\Vec4.h(16,2): error C2535: 'void JPH::Vec4::operator delete[](void *) noexcept': member f unction already defined or declared [H:\1\JoltPhysics.js\Build\Distribution\_deps\joltphysics-build\Jolt.vcxproj]
  (compiling source file 'CMakeFiles/Jolt.dir/cmake_pch.hxx.cxx')
  H:\1\JoltPhysics.js\Build\Distribution\_deps\joltphysics-src\Jolt\Math\Vec4.h(16,2):
  see declaration of 'JPH::Vec4::operator delete[]'

H:\1\JoltPhysics.js\Build\Distribution\_deps\joltphysics-src\Jolt\Math\Vec4.h(16,2): error C2065: 'inAlignment': undeclared identifier [H:\1\JoltPhysics.js\Buil d\Distribution\_deps\joltphysics-build\Jolt.vcxproj]
  (compiling source file 'CMakeFiles/Jolt.dir/cmake_pch.hxx.cxx')

H:\1\JoltPhysics.js\Build\Distribution\_deps\joltphysics-src\Jolt\Math\Float3.h(15,2): error C2039: 'align_val_t': is not a member of 'std' [H:\1\JoltPhysics.js \Build\Distribution\_deps\joltphysics-build\Jolt.vcxproj]
  (compiling source file 'CMakeFiles/Jolt.dir/cmake_pch.hxx.cxx')
  C:\Program Files (x86)\Microsoft Visual Studio\2022\BuildTools\VC\Tools\MSVC\14.38.33130\include\algorithm(81,1):
  see declaration of 'std'

H:\1\JoltPhysics.js\Build\Distribution\_deps\joltphysics-src\Jolt\Math\Float3.h(15,2): error C2061: syntax error: identifier 'align_val_t' [H:\1\JoltPhysics.js\ Build\Distribution\_deps\joltphysics-build\Jolt.vcxproj]
  (compiling source file 'CMakeFiles/Jolt.dir/cmake_pch.hxx.cxx')

H:\1\JoltPhysics.js\Build\Distribution\_deps\joltphysics-src\Jolt\Math\Float3.h(15,2): error C2535: 'void *JPH::Float3::operator new(size_t)': member function a lready defined or declared [H:\1\JoltPhysics.js\Build\Distribution\_deps\joltphysics-build\Jolt.vcxproj]
  (compiling source file 'CMakeFiles/Jolt.dir/cmake_pch.hxx.cxx')
  H:\1\JoltPhysics.js\Build\Distribution\_deps\joltphysics-src\Jolt\Math\Float3.h(15,2):
  see declaration of 'JPH::Float3::operator new'

H:\1\JoltPhysics.js\Build\Distribution\_deps\joltphysics-src\Jolt\Math\Float3.h(15,2): warning C5051: attribute [[maybe_unused]] requires at least '/std:c++17';  ignored [H:\1\JoltPhysics.js\Build\Distribution\_deps\joltphysics-build\Jolt.vcxproj]
  (compiling source file 'CMakeFiles/Jolt.dir/cmake_pch.hxx.cxx')

H:\1\JoltPhysics.js\Build\Distribution\_deps\joltphysics-src\Jolt\Math\Float3.h(15,2): error C2535: 'void JPH::Float3::operator delete(void *) noexcept': member  function already defined or declared [H:\1\JoltPhysics.js\Build\Distribution\_deps\joltphysics-build\Jolt.vcxproj]
  (compiling source file 'CMakeFiles/Jolt.dir/cmake_pch.hxx.cxx')
  H:\1\JoltPhysics.js\Build\Distribution\_deps\joltphysics-src\Jolt\Math\Float3.h(15,2):
  see declaration of 'JPH::Float3::operator delete'

H:\1\JoltPhysics.js\Build\Distribution\_deps\joltphysics-src\Jolt\Math\Float3.h(15,2): error C2535: 'void *JPH::Float3::operator new[](size_t)': member function  already defined or declared [H:\1\JoltPhysics.js\Build\Distribution\_deps\joltphysics-build\Jolt.vcxproj]
  (compiling source file 'CMakeFiles/Jolt.dir/cmake_pch.hxx.cxx')
  H:\1\JoltPhysics.js\Build\Distribution\_deps\joltphysics-src\Jolt\Math\Float3.h(15,2):
  see declaration of 'JPH::Float3::operator new[]'

H:\1\JoltPhysics.js\Build\Distribution\_deps\joltphysics-src\Jolt\Math\Float3.h(15,2): error C2535: 'void JPH::Float3::operator delete[](void *) noexcept': memb er function already defined or declared [H:\1\JoltPhysics.js\Build\Distribution\_deps\joltphysics-build\Jolt.vcxproj]
  (compiling source file 'CMakeFiles/Jolt.dir/cmake_pch.hxx.cxx')
  H:\1\JoltPhysics.js\Build\Distribution\_deps\joltphysics-src\Jolt\Math\Float3.h(15,2):
  see declaration of 'JPH::Float3::operator delete[]'

H:\1\JoltPhysics.js\Build\Distribution\_deps\joltphysics-src\Jolt\Math\Float3.h(15,2): error C2065: 'inAlignment': undeclared identifier [H:\1\JoltPhysics.js\Bu ild\Distribution\_deps\joltphysics-build\Jolt.vcxproj]
  (compiling source file 'CMakeFiles/Jolt.dir/cmake_pch.hxx.cxx')

H:\1\JoltPhysics.js\Build\Distribution\_deps\joltphysics-src\Jolt\Math\Vec3.h(18,2): error C2039: 'align_val_t': is not a member of 'std' [H:\1\JoltPhysics.js\B uild\Distribution\_deps\joltphysics-build\Jolt.vcxproj]
  (compiling source file 'CMakeFiles/Jolt.dir/cmake_pch.hxx.cxx')
  H:\1\JoltPhysics.js\Build\Distribution\_deps\joltphysics-src\Jolt\Math\Float3.h(50,1):
  see declaration of 'std'

H:\1\JoltPhysics.js\Build\Distribution\_deps\joltphysics-src\Jolt\Math\Vec3.h(18,2): error C2061: syntax error: identifier 'align_val_t' [H:\1\JoltPhysics.js\Bu ild\Distribution\_deps\joltphysics-build\Jolt.vcxproj]
  (compiling source file 'CMakeFiles/Jolt.dir/cmake_pch.hxx.cxx')

H:\1\JoltPhysics.js\Build\Distribution\_deps\joltphysics-src\Jolt\Math\Vec3.h(18,2): error C2535: 'void *JPH::Vec3::operator new(size_t)': member function alrea dy defined or declared [H:\1\JoltPhysics.js\Build\Distribution\_deps\joltphysics-build\Jolt.vcxproj]
  (compiling source file 'CMakeFiles/Jolt.dir/cmake_pch.hxx.cxx')
  H:\1\JoltPhysics.js\Build\Distribution\_deps\joltphysics-src\Jolt\Math\Vec3.h(18,2):
  see declaration of 'JPH::Vec3::operator new'

H:\1\JoltPhysics.js\Build\Distribution\_deps\joltphysics-src\Jolt\Math\Vec3.h(18,2): warning C5051: attribute [[maybe_unused]] requires at least '/std:c++17'; i gnored [H:\1\JoltPhysics.js\Build\Distribution\_deps\joltphysics-build\Jolt.vcxproj]
  (compiling source file 'CMakeFiles/Jolt.dir/cmake_pch.hxx.cxx')

H:\1\JoltPhysics.js\Build\Distribution\_deps\joltphysics-src\Jolt\Math\Vec3.h(18,2): error C2535: 'void JPH::Vec3::operator delete(void *) noexcept': member fun ction already defined or declared [H:\1\JoltPhysics.js\Build\Distribution\_deps\joltphysics-build\Jolt.vcxproj]
  (compiling source file 'CMakeFiles/Jolt.dir/cmake_pch.hxx.cxx')
  H:\1\JoltPhysics.js\Build\Distribution\_deps\joltphysics-src\Jolt\Math\Vec3.h(18,2):
  see declaration of 'JPH::Vec3::operator delete'

H:\1\JoltPhysics.js\Build\Distribution\_deps\joltphysics-src\Jolt\Math\Vec3.h(18,2): error C2535: 'void *JPH::Vec3::operator new[](size_t)': member function alr eady defined or declared [H:\1\JoltPhysics.js\Build\Distribution\_deps\joltphysics-build\Jolt.vcxproj]
  (compiling source file 'CMakeFiles/Jolt.dir/cmake_pch.hxx.cxx')
  H:\1\JoltPhysics.js\Build\Distribution\_deps\joltphysics-src\Jolt\Math\Vec3.h(18,2):
  see declaration of 'JPH::Vec3::operator new[]'

H:\1\JoltPhysics.js\Build\Distribution\_deps\joltphysics-src\Jolt\Math\Vec3.h(18,2): error C2535: 'void JPH::Vec3::operator delete[](void *) noexcept': member f unction already defined or declared [H:\1\JoltPhysics.js\Build\Distribution\_deps\joltphysics-build\Jolt.vcxproj]
  (compiling source file 'CMakeFiles/Jolt.dir/cmake_pch.hxx.cxx')
  H:\1\JoltPhysics.js\Build\Distribution\_deps\joltphysics-src\Jolt\Math\Vec3.h(18,2):
  see declaration of 'JPH::Vec3::operator delete[]'

H:\1\JoltPhysics.js\Build\Distribution\_deps\joltphysics-src\Jolt\Math\Vec3.h(18,2): error C2065: 'inAlignment': undeclared identifier [H:\1\JoltPhysics.js\Buil d\Distribution\_deps\joltphysics-build\Jolt.vcxproj]
  (compiling source file 'CMakeFiles/Jolt.dir/cmake_pch.hxx.cxx')

H:\1\JoltPhysics.js\Build\Distribution\_deps\joltphysics-src\Jolt\Math\UVec4.h(14,2): error C2039: 'align_val_t': is not a member of 'std' [H:\1\JoltPhysics.js\ Build\Distribution\_deps\joltphysics-build\Jolt.vcxproj]
  (compiling source file 'CMakeFiles/Jolt.dir/cmake_pch.hxx.cxx')
  H:\1\JoltPhysics.js\Build\Distribution\_deps\joltphysics-src\Jolt\Math\Float3.h(50,1):
  see declaration of 'std'

H:\1\JoltPhysics.js\Build\Distribution\_deps\joltphysics-src\Jolt\Math\UVec4.h(14,2): error C2061: syntax error: identifier 'align_val_t' [H:\1\JoltPhysics.js\B uild\Distribution\_deps\joltphysics-build\Jolt.vcxproj]
  (compiling source file 'CMakeFiles/Jolt.dir/cmake_pch.hxx.cxx')

H:\1\JoltPhysics.js\Build\Distribution\_deps\joltphysics-src\Jolt\Math\UVec4.h(14,2): error C2535: 'void *JPH::UVec4::operator new(size_t)': member function alr eady defined or declared [H:\1\JoltPhysics.js\Build\Distribution\_deps\joltphysics-build\Jolt.vcxproj]
  (compiling source file 'CMakeFiles/Jolt.dir/cmake_pch.hxx.cxx')
  H:\1\JoltPhysics.js\Build\Distribution\_deps\joltphysics-src\Jolt\Math\UVec4.h(14,2):
  see declaration of 'JPH::UVec4::operator new'

H:\1\JoltPhysics.js\Build\Distribution\_deps\joltphysics-src\Jolt\Math\UVec4.h(14,2): warning C5051: attribute [[maybe_unused]] requires at least '/std:c++17';
ignored [H:\1\JoltPhysics.js\Build\Distribution\_deps\joltphysics-build\Jolt.vcxproj]
  (compiling source file 'CMakeFiles/Jolt.dir/cmake_pch.hxx.cxx')

H:\1\JoltPhysics.js\Build\Distribution\_deps\joltphysics-src\Jolt\Math\UVec4.h(14,2): error C2535: 'void JPH::UVec4::operator delete(void *) noexcept': member f unction already defined or declared [H:\1\JoltPhysics.js\Build\Distribution\_deps\joltphysics-build\Jolt.vcxproj]
  (compiling source file 'CMakeFiles/Jolt.dir/cmake_pch.hxx.cxx')
  H:\1\JoltPhysics.js\Build\Distribution\_deps\joltphysics-src\Jolt\Math\UVec4.h(14,2):
  see declaration of 'JPH::UVec4::operator delete'

H:\1\JoltPhysics.js\Build\Distribution\_deps\joltphysics-src\Jolt\Math\UVec4.h(14,2): error C2535: 'void *JPH::UVec4::operator new[](size_t)': member function a lready defined or declared [H:\1\JoltPhysics.js\Build\Distribution\_deps\joltphysics-build\Jolt.vcxproj]
  (compiling source file 'CMakeFiles/Jolt.dir/cmake_pch.hxx.cxx')
  H:\1\JoltPhysics.js\Build\Distribution\_deps\joltphysics-src\Jolt\Math\UVec4.h(14,2):
  see declaration of 'JPH::UVec4::operator new[]'

H:\1\JoltPhysics.js\Build\Distribution\_deps\joltphysics-src\Jolt\Math\UVec4.h(14,2): error C2535: 'void JPH::UVec4::operator delete[](void *) noexcept': member  function already defined or declared [H:\1\JoltPhysics.js\Build\Distribution\_deps\joltphysics-build\Jolt.vcxproj]
  (compiling source file 'CMakeFiles/Jolt.dir/cmake_pch.hxx.cxx')
  H:\1\JoltPhysics.js\Build\Distribution\_deps\joltphysics-src\Jolt\Math\UVec4.h(14,2):
  see declaration of 'JPH::UVec4::operator delete[]'

H:\1\JoltPhysics.js\Build\Distribution\_deps\joltphysics-src\Jolt\Math\UVec4.h(14,2): error C2065: 'inAlignment': undeclared identifier [H:\1\JoltPhysics.js\Bui ld\Distribution\_deps\joltphysics-build\Jolt.vcxproj]
  (compiling source file 'CMakeFiles/Jolt.dir/cmake_pch.hxx.cxx')

H:\1\JoltPhysics.js\Build\Distribution\_deps\joltphysics-src\Jolt\Math\Mat44.h(15,2): error C2039: 'align_val_t': is not a member of 'std' [H:\1\JoltPhysics.js\ Build\Distribution\_deps\joltphysics-build\Jolt.vcxproj]
  (compiling source file 'CMakeFiles/Jolt.dir/cmake_pch.hxx.cxx')
  H:\1\JoltPhysics.js\Build\Distribution\_deps\joltphysics-src\Jolt\Math\Vec3.inl(14,1):
  see declaration of 'std'

H:\1\JoltPhysics.js\Build\Distribution\_deps\joltphysics-src\Jolt\Math\Mat44.h(15,2): error C2061: syntax error: identifier 'align_val_t' [H:\1\JoltPhysics.js\B uild\Distribution\_deps\joltphysics-build\Jolt.vcxproj]
  (compiling source file 'CMakeFiles/Jolt.dir/cmake_pch.hxx.cxx')

H:\1\JoltPhysics.js\Build\Distribution\_deps\joltphysics-src\Jolt\Math\Mat44.h(15,2): error C2535: 'void *JPH::Mat44::operator new(size_t)': member function alr eady defined or declared [H:\1\JoltPhysics.js\Build\Distribution\_deps\joltphysics-build\Jolt.vcxproj]
  (compiling source file 'CMakeFiles/Jolt.dir/cmake_pch.hxx.cxx')
  H:\1\JoltPhysics.js\Build\Distribution\_deps\joltphysics-src\Jolt\Math\Mat44.h(15,2):
  see declaration of 'JPH::Mat44::operator new'

H:\1\JoltPhysics.js\Build\Distribution\_deps\joltphysics-src\Jolt\Math\Mat44.h(15,2): warning C5051: attribute [[maybe_unused]] requires at least '/std:c++17';
ignored [H:\1\JoltPhysics.js\Build\Distribution\_deps\joltphysics-build\Jolt.vcxproj]
  (compiling source file 'CMakeFiles/Jolt.dir/cmake_pch.hxx.cxx')

H:\1\JoltPhysics.js\Build\Distribution\_deps\joltphysics-src\Jolt\Math\Mat44.h(15,2): error C2535: 'void JPH::Mat44::operator delete(void *) noexcept': member f unction already defined or declared [H:\1\JoltPhysics.js\Build\Distribution\_deps\joltphysics-build\Jolt.vcxproj]
  (compiling source file 'CMakeFiles/Jolt.dir/cmake_pch.hxx.cxx')
  H:\1\JoltPhysics.js\Build\Distribution\_deps\joltphysics-src\Jolt\Math\Mat44.h(15,2):
  see declaration of 'JPH::Mat44::operator delete'

H:\1\JoltPhysics.js\Build\Distribution\_deps\joltphysics-src\Jolt\Math\Mat44.h(15,2): error C2535: 'void *JPH::Mat44::operator new[](size_t)': member function a lready defined or declared [H:\1\JoltPhysics.js\Build\Distribution\_deps\joltphysics-build\Jolt.vcxproj]
  (compiling source file 'CMakeFiles/Jolt.dir/cmake_pch.hxx.cxx')
  H:\1\JoltPhysics.js\Build\Distribution\_deps\joltphysics-src\Jolt\Math\Mat44.h(15,2):
  see declaration of 'JPH::Mat44::operator new[]'

H:\1\JoltPhysics.js\Build\Distribution\_deps\joltphysics-src\Jolt\Math\Mat44.h(15,2): error C2535: 'void JPH::Mat44::operator delete[](void *) noexcept': member  function already defined or declared [H:\1\JoltPhysics.js\Build\Distribution\_deps\joltphysics-build\Jolt.vcxproj]
  (compiling source file 'CMakeFiles/Jolt.dir/cmake_pch.hxx.cxx')
  H:\1\JoltPhysics.js\Build\Distribution\_deps\joltphysics-src\Jolt\Math\Mat44.h(15,2):
  see declaration of 'JPH::Mat44::operator delete[]'

H:\1\JoltPhysics.js\Build\Distribution\_deps\joltphysics-src\Jolt\Math\Mat44.h(15,2): error C2065: 'inAlignment': undeclared identifier [H:\1\JoltPhysics.js\Bui ld\Distribution\_deps\joltphysics-build\Jolt.vcxproj]
  (compiling source file 'CMakeFiles/Jolt.dir/cmake_pch.hxx.cxx')

H:\1\JoltPhysics.js\Build\Distribution\_deps\joltphysics-src\Jolt\Math\Quat.h(35,2): error C2039: 'align_val_t': is not a member of 'std' [H:\1\JoltPhysics.js\B uild\Distribution\_deps\joltphysics-build\Jolt.vcxproj]
  (compiling source file 'CMakeFiles/Jolt.dir/cmake_pch.hxx.cxx')
  H:\1\JoltPhysics.js\Build\Distribution\_deps\joltphysics-src\Jolt\Math\Vec3.inl(14,1):
  see declaration of 'std'

H:\1\JoltPhysics.js\Build\Distribution\_deps\joltphysics-src\Jolt\Math\Quat.h(35,2): error C2061: syntax error: identifier 'align_val_t' [H:\1\JoltPhysics.js\Bu ild\Distribution\_deps\joltphysics-build\Jolt.vcxproj]
  (compiling source file 'CMakeFiles/Jolt.dir/cmake_pch.hxx.cxx')

H:\1\JoltPhysics.js\Build\Distribution\_deps\joltphysics-src\Jolt\Math\Quat.h(35,2): error C2535: 'void *JPH::Quat::operator new(size_t)': member function alrea dy defined or declared [H:\1\JoltPhysics.js\Build\Distribution\_deps\joltphysics-build\Jolt.vcxproj]
  (compiling source file 'CMakeFiles/Jolt.dir/cmake_pch.hxx.cxx')
  H:\1\JoltPhysics.js\Build\Distribution\_deps\joltphysics-src\Jolt\Math\Quat.h(35,2):
  see declaration of 'JPH::Quat::operator new'

H:\1\JoltPhysics.js\Build\Distribution\_deps\joltphysics-src\Jolt\Math\Quat.h(35,2): warning C5051: attribute [[maybe_unused]] requires at least '/std:c++17'; i gnored [H:\1\JoltPhysics.js\Build\Distribution\_deps\joltphysics-build\Jolt.vcxproj]
  (compiling source file 'CMakeFiles/Jolt.dir/cmake_pch.hxx.cxx')

H:\1\JoltPhysics.js\Build\Distribution\_deps\joltphysics-src\Jolt\Math\Quat.h(35,2): error C2535: 'void JPH::Quat::operator delete(void *) noexcept': member fun ction already defined or declared [H:\1\JoltPhysics.js\Build\Distribution\_deps\joltphysics-build\Jolt.vcxproj]
  (compiling source file 'CMakeFiles/Jolt.dir/cmake_pch.hxx.cxx')
  H:\1\JoltPhysics.js\Build\Distribution\_deps\joltphysics-src\Jolt\Math\Quat.h(35,2):
  see declaration of 'JPH::Quat::operator delete'

H:\1\JoltPhysics.js\Build\Distribution\_deps\joltphysics-src\Jolt\Math\Quat.h(35,2): error C2535: 'void *JPH::Quat::operator new[](size_t)': member function alr eady defined or declared [H:\1\JoltPhysics.js\Build\Distribution\_deps\joltphysics-build\Jolt.vcxproj]
  (compiling source file 'CMakeFiles/Jolt.dir/cmake_pch.hxx.cxx')
  H:\1\JoltPhysics.js\Build\Distribution\_deps\joltphysics-src\Jolt\Math\Quat.h(35,2):
  see declaration of 'JPH::Quat::operator new[]'

H:\1\JoltPhysics.js\Build\Distribution\_deps\joltphysics-src\Jolt\Math\Quat.h(35,2): error C2535: 'void JPH::Quat::operator delete[](void *) noexcept': member f unction already defined or declared [H:\1\JoltPhysics.js\Build\Distribution\_deps\joltphysics-build\Jolt.vcxproj]
  (compiling source file 'CMakeFiles/Jolt.dir/cmake_pch.hxx.cxx')
  H:\1\JoltPhysics.js\Build\Distribution\_deps\joltphysics-src\Jolt\Math\Quat.h(35,2):
  see declaration of 'JPH::Quat::operator delete[]'

H:\1\JoltPhysics.js\Build\Distribution\_deps\joltphysics-src\Jolt\Math\Quat.h(35,2): error C2065: 'inAlignment': undeclared identifier [H:\1\JoltPhysics.js\Buil d\Distribution\_deps\joltphysics-build\Jolt.vcxproj]
  (compiling source file 'CMakeFiles/Jolt.dir/cmake_pch.hxx.cxx')

H:\1\JoltPhysics.js\Build\Distribution\_deps\joltphysics-src\Jolt\Math\Double3.h(15,2): error C2039: 'align_val_t': is not a member of 'std' [H:\1\JoltPhysics.j s\Build\Distribution\_deps\joltphysics-build\Jolt.vcxproj]
  (compiling source file 'CMakeFiles/Jolt.dir/cmake_pch.hxx.cxx')
  H:\1\JoltPhysics.js\Build\Distribution\_deps\joltphysics-src\Jolt\Math\Vec3.inl(14,1):
  see declaration of 'std'

H:\1\JoltPhysics.js\Build\Distribution\_deps\joltphysics-src\Jolt\Math\Double3.h(15,2): error C1003: error count exceeds 100; stopping compilation [H:\1\JoltPhy sics.js\Build\Distribution\_deps\joltphysics-build\Jolt.vcxproj]
  (compiling source file 'CMakeFiles/Jolt.dir/cmake_pch.hxx.cxx')

Looks like the typescript docs do say "types" should come first, I can cut a PR to fix this.

The "types" condition should always come first in "exports".

https://www.typescriptlang.org/docs/handbook/release-notes/typescript-4-7.html#packagejson-exports-imports-and-self-referencing

Re adding a CommonJS build, I'm happy to help with this if there's interest!
I suggested starting with only publishing ESM as it's the "modern" format, and there is some effort in supporting both.

Also re your immediate issue, what version of webpack are you using? And do you mind sharing your config?
The latest versions of webpack (iirc 4 and 5) should support ESM.

I use latest webpack
This is minimal example to reproduce the problems
example.zip
> npm i
> npm run build

after that you will need to fix types and default order to get the second error

Thanks! I'll take a look soon

I've found that with the following changes, the minimal webpack repro builds successfully:

The ordering fix in https://github.com/jrouwe/JoltPhysics.js/pull/54
removing node from the ENVIRONMENT argument

https://github.com/jrouwe/JoltPhysics.js/blob/8b42dbfdd599cc7a2711bc28989323016551e846/CMakeLists.txt#L48
before: -s ENVIRONMENT='web,node'
after: -s ENVIRONMENT='web'

It appears this isn't an issue with commonjs vs esm, but an issue with webpack not handling the node-specific code that emscripten adds when node is included in the ENVIRONMENT argument.
In another emscripten package recast-navigation-js, I use the argument -s ENVIRONMENT='web' (not specifying node), and the package works fine in node environments.
I'll do some testing later today checking if the package still works in node using -s ENVIRONMENT='web'. If it does, I think we can make that change, and this particular issue should be resolved 🙂

With the above change, the wasm-compat (default) flavour works with node, but the wasm flavour breaks, seemingly because node's built-in fetch method is not fully implemented?
node:internal/deps/undici/undici:11372
    Error.captureStackTrace(err, this);
          ^

TypeError: fetch failed
    at Object.fetch (node:internal/deps/undici/undici:11372:11) {
  cause: Error: not implemented... yet...
      at makeNetworkError (node:internal/deps/undici/undici:4801:35)
      at schemeFetch (node:internal/deps/undici/undici:9531:18)
      at node:internal/deps/undici/undici:9409:26
      at mainFetch (node:internal/deps/undici/undici:9428:11)
      at fetching (node:internal/deps/undici/undici:9377:7)
      at fetch2 (node:internal/deps/undici/undici:9245:20)
      at Object.fetch (node:internal/deps/undici/undici:11370:18)
      at fetch (node:internal/process/pre_execution:282:25)
      at Ia (file:///Users/isaacmason/Development/JoltPhysics.js/dist/jolt-physics.wasm.js:15:133)
      at file:///Users/isaacmason/Development/JoltPhysics.js/dist/jolt-physics.wasm.js:43:160
}

Node.js v20.9.0

I'll keep investigating!
Reading through some emscripten and webpack issues, having separate node and web builds is a commonly suggested solution 🙁

@kutu I don't have a proper solve yet, but I can share a workaround for using JoltPhysics.js with webpack 5.
These issues appear to be common for emscripten packages that target both web and node environments - I found this workaround from ammo.js github issues discussing similar issues using ammo.js with webpack.
This webpack configuration should mitigate the issues webpack has with the node environment-specific code generated by emscripten (see resolve.fallback.module):
const path = require("path");

module.exports = {
  mode: "production",
  entry: "./main.js",
  output: {
    filename: "main.js",
    path: path.resolve(__dirname, "dist"),
  },
  resolve: {
    fallback: {
      module: false,
    },
  },
};

This still outputs one error though:
ERROR in ./node_modules/jolt-physics/dist/jolt-physics.wasm-compat.js 12:178-207
Module not found: Error: Can't resolve './' in '/Users/isaacmason/Downloads/example/node_modules/jolt-physics/dist'
resolve './' in '/Users/isaacmason/Downloads/example/node_modules/jolt-physics/dist'
  Parsed request is a directory
  using description file: /Users/isaacmason/Downloads/example/node_modules/jolt-physics/package.json (relative path: ./dist)
    using description file: /Users/isaacmason/Downloads/example/node_modules/jolt-physics/package.json (relative path: ./dist)
      as directory
        existing directory /Users/isaacmason/Downloads/example/node_modules/jolt-physics/dist
          using description file: /Users/isaacmason/Downloads/example/node_modules/jolt-physics/package.json (relative path: ./dist)
            using path: /Users/isaacmason/Downloads/example/node_modules/jolt-physics/dist/index
              using description file: /Users/isaacmason/Downloads/example/node_modules/jolt-physics/package.json (relative path: ./dist/index)
                no extension
                  /Users/isaacmason/Downloads/example/node_modules/jolt-physics/dist/index doesn't exist
 @ ./main.js 1:0-32 3:19-23

This error doesn't prevent the bundle from being generated, and seemingly doesn't break the bundle - jolt-physics can be imported and used fine (I tested with the wasm-compat flavour). To silence this error, you could write a basic plugin, e.g.
const path = require("path");

class FilterErrorsPlugin {
  constructor(filter) {
    this.filter = new RegExp(filter);
  }

  apply(compiler) {
    compiler.hooks.done.tap("FilterErrorsPlugin", (stats) => {
      stats.compilation.errors = stats.compilation.errors.filter((error) => {
        return !this.filter.test(error.message);
      });
    });
  }
}

module.exports = {
  mode: "production",
  entry: "./main.js",
  output: {
    filename: "main.js",
    path: path.resolve(__dirname, "dist"),
  },
  resolve: {
    fallback: {
      module: false,
    },
  },
  plugins: [
    new FilterErrorsPlugin("Can't resolve '\\./' in '.+/jolt-physics/dist'"),
  ],
};

As I get time I'll keep investigating what the path forward for the package should be.
Let me know if this helps in the meantime 🙂

yes, it works, thank you for your time.

Will there be separate web and node builds made available, or will users just have to use the webpack config fix?

@KyroVibe we don't have a clear path forward for this yet. Doubling the amount of builds we need to support isn't ideal.
For the moment using the above fix is still what I'd recommend. Or if you really need an environment specific build, you can build JoltPhysics.js yourself with different configuration.

@isaac-mason Yeah, I've just been building it myself so far. Thank you


Upgrade iceberg-spark-runtime version in support of time-travel usage

Problem
The current version specified for spark integration in spark3 project 0.12.1, is quite old and missing SQL support for time travel (supported from iceberg 0.14.0 / Spark 3.3 onward). This alone is not enough, but since the change seems not impacting anything, it may be worth doing until the spark projects get fully merged and upgraded.
Closes: #1969
Solution
Simply upgrade the spark-iceberg runtime version. Does not have any impact on existing tests and does have the immediate benefit of capturing the snapshotid within SparkTable

[ ] Your change modifies the core OpenLineage model
[ ] Your change modifies one or more OpenLineage facets

If you're contributing a new integration, please specify the scope of the integration and how/where it has been tested (e.g., Apache Spark integration supports S3 and GCS filesystem operations, tested with AWS EMR).
One-line summary:
Checklist

[x] You've signed-off your work
[x] Your pull request title follows our guidelines
[x] Your changes are accompanied by tests (if relevant)
[x] Your change contains a small diff and is self-contained
[x] You've updated any relevant documentation (if relevant)
[ ] Your comment includes a one-liner for the changelog about the specific purpose of the change (if necessary)
[ ] You've versioned the core OpenLineage model or facets according to SchemaVer (if relevant)
[ ] You've added a header to source files (if relevant)

SPDX-License-Identifier: Apache-2.0
Copyright 2018-2023 contributors to the OpenLineage project

Meanwhile, we upgraded iceberg versions in a way that:

spark32 module uses 0.13.0