Issue editing emergency contact email address

          There is an issue with entering an email address. I tried to enter random letters without providing @ and whatever goes after like @gmail.com. It asked me to enter a valid email address and did not let me save it, which is good. However, right after that message, I try to enter a valid email address with @gmail.com or @berea.edu, and it doesn't save the real email address either. It keeps telling me that the email address is not valid even when I enter my actual email address.

Originally posted by @Karina-Agliullova in https://github.com/BCStudentSoftwareDevTeam/celts/issues/1058#issuecomment-1708815902

 Issue editing emergency contact email address #1078


[SPARK-13069][STREAMING]. Adds synchronous store() to ActorReciever.

Introduces storeSync() in ActorReceiver as a way to allow actor receiver blocked by back pressure or maxRate.

Can one of the admins verify this patch?

cc @zsxwing

Test build #2541 has started for PR 11176 at commit 970e3c8.

Test build #2541 has finished for PR 11176 at commit 970e3c8.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

@ScrapCodes could you take a look at the new API?

Any update? We need this feature and would love to see it in 2.0

Addressed comments again.

retest this please

Test build #51984 has started for PR 11176 at commit 58f7aa0.

Test build #51984 has finished for PR 11176 at commit 58f7aa0.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/51984/
Test PASSed.

LGTM
@lin-zhao could you update the title to remove "."?

@lin-zhao oh, the tile is out of date. Could you change it to [SPARK-13069][STREAMING]Add "ask" style store() to ActorReciever?

@lin-zhao never mind. I will update the commit message. Merging to master. Thanks a lot, @lin-zhao

@zsxwing  thanks for reviewing it!


Add Monday OSG exercises

Travis-CI is failing because my exercises have links to exercises that happen earlier on Monday that haven't been uploaded yet.


Normalised card height and added spacing in open source programs (responsive)

Description

Category

[ ] Resource Addition
[ ] Documentation
[ ] Codebase
[ ] User Interface
[ ] Feature Addition

Related Issue

Fixes #XX
Checklist

[ ] I have followed the CONTRIBUTING guide
[ ] The name of the resource is spelled correctly (if applicable)
[ ] The link to the resource is working (if applicable)
[ ] The resource is added in the correct format (if applicable)
[ ] I have tested changes on my local computer (if applicable)

this applies only if Normalised card hide and added spacing in open source programs has been merged

If there is any other UI improvements Needed, you could send me a design like the time you sent for the card element, I will try my best implementing it

Hey @Greyash-Dave, I'm currently going for different designs in the category pages to find out the one that looks the best to me. So no, the card swiping design is not finalized yet.


Bios

Sécurité

Description of change

Pre-Merge Checklist

[x] Tests and/or benchmarks are included
[x] Documentation is changed or added
[x] Lint process passed (npm run lint)
[x] Tests passed (npm run test)

Codecov Report

Merging #5846 into dev will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev    #5846   +/-   ##
=======================================
  Coverage   70.54%   70.54%
=======================================
  Files         205      205
  Lines       10404    10404
=======================================
  Hits         7340     7340
  Misses       3064     3064

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b54fdca...02d49ca. Read the comment docs.

Not interested in this change at this time.


AngularJS unescapes matrix parameters

I'm submitting a ...

[x] bug report
[ ] feature request
[ ] other (Please do not submit support requests here (see above))

Current behavior:
AngularJS un-escapes matrix parameters, preventing matrix parameters with slashes from being used in dual-router AngularJS / Angular applications.
Expected / new behavior:
AngularJS should not un-escape matrix parameters.
Minimal reproduction of the problem with instructions:
In a hybrid setup, add a link like: <a [routerLink]="['/a/ng2', {path: '/some/path'}]">ANGULAR A
While Angular properly renders this link as "http://localhost:4200/a/ng2;path=%2Fsome%2Fpath", AngularJS rewrites it as http://localhost:4200/a/ng2;path=/some/path during navigation.  Depending on the setup, this causes the application to display either a missing route mapping or a redirect loop.
AngularJS version: 1.5+
Browser: all

This sounds like a valid bug. Thanks for reporting @bourey !

Is it $location or $route that is doing the rewriting?

@petebacondarwin I think it's $location. I've looked at this encoding/decoding before and I think it's all from $location.

I think the exact problem here is that we are unescaping forward slashes, right?
We have tests that check that we unescape other special characters.
Can anyone point me to the spec for these matrix params? I can't find anything official.

I have created a PR for this: #16316 - please take a look. As with all things related to the can of worms that is $location fixing this bug could well create problems with loads of other use cases.

I just want to flag, without much information as I don't have it right now but finally found out that this update was causing of an issue we were having with angular-ui/ui-router which wasn't there before.
For some reason $state.go('catchall', {alias: URL}) we have setup stopped to work and encoded URLs appeared on the URL breaking the route handling altogether. It might be some inconsistency with uirouter or something else entirely specific to my app but as it was triggered by this update (and very likely this issue) wanted to note it.

@hanoii - perhaps this regression fix will solve your problem: #16316 ?

@petebacondarwin I just tried master and it didn't fix my problem. Not sure if I am testing it correctly. I copied over the built angular.js and angular-sanitize.js, but not the other bits, but I think the issue is within angular.js anyway.

This fix https://github.com/angular/angular.js/pull/16350/files#diff-06a39a7c214933c36a5c4b080ef4d56dR425 doesn't work for me.
Why not using always decodeURIComponent instead of decodeURI for HTML5 mode ?

@dhoko - I think I agree. See https://github.com/angular/angular.js/pull/16354

This fix works, thx :+1:

@bourey can you check if your use case still works with AngularJS master + this patch https://github.com/angular/angular.js/pull/16354? We had to make some changes so that other use cases do not break.

@Narretz at least I tried it and the issue I was having on https://github.com/angular/angular.js/issues/16312#issuecomment-348023449 seems to have gone with master = patch #16354

I am definitely seeing issues related to this with AngularJS 1.7.2 and legacy ui-router 0.4.3. In html5 mode, trying to access a url directly gets rerouted to my fallback state because the the slashes are converted to %2F. Rolling back this change results in expected behavior. The deep-linked state loads as expected.

I personally don’t think that / should be treated as such a special case here.
RFC3986§<IP_ADDRESS> recommends that percent normalization only the normalize unreserved characters listed in RFC3986§2.3. These unreserved characters are -, ., _, ~, ALPHA (/[a-zA-Z]/), and DIGIT (/[0-9]/).
RFC3986§3.3 permits the entirety of the path to consist of /, percent-encoded characters, unreserved characters, sub-delims (!, $, &, ', (, ), *, +, ,, ;, and =), :, and @.
This means that the specification defines three categories of characters used within a path:

Characters which must be considered equivalent regardless of whether or not they are percent encoded. This is the unreserved characters. For example, /%7e%61 and /~a should be considered equivalent URIs. This is important because older implementations may consider ~ to be a reserved character and send %7e which web servers must handle.
Characters which must be percent encoded always. For example, non-latin alphabetic characters.
Characters which may be present in percent encoded form or verbatim but which may not be normalized during normal URI processing. This includes the remaining characters such as (, !, /, and @. The fact that RFC3986§<IP_ADDRESS> does not say that these may be safely normalized means that the difference between percent-encoded and unencoded variants of these characters may be considered significant by the consumer of the URI.

This last category may be further broken down for JavaScript programmers in terms of what encodeURIComponent() will escape which is everything but !, ', (, and ):
encodeURIComponent('/!$^\'()*+,;=:@')
"%2F!%24%5E'()*%2B%2C%3B%3D%3A%40"

And, additionally, I’m sure that the HTML spec also further defines/alters how the URI should be handled.
This patch/PR adds / as a special case targeting ui-router specifically. Instead, it should just fix AngularJS to follow the normalization guidelines which is to only normalize the characters required by RFC3986§2.3.
For example, a function like this could be used instead of decodePath():
/**
 * This takes any percent-encoded character which is listed in
 * RFC3986§2.3 (https://tools.ietf.org/html/rfc3986#section-2.3)
 * and normalizes them to their decoded form. The below is the
 * list of characters:
 *
 * unreserved = ALPHA / DIGIT / "-" / "." / "_" / "~"
 *
 * "-" = %2d
 *
 * "." = %2e
 *
 * "_" = %5f
 *
 * ~ = %7e
 *
 * ALPHA = %41–%5A
 *
 * DIGIT = %30–%39
 *
 * RFC3986§<IP_ADDRESS>
 * (https://tools.ietf.org/html/rfc3986#section-<IP_ADDRESS>) states
 * that the above characters should be considered equivalent when
 * both encoded and not. Thus, the application is not allowed to
 * treat their escaped and unescaped versions differently. For
 * example, none of those characters may be used as path
 * separators because URI implementations are allowed to normalize
 * them away.
 *
 * To avoid accidentally relying on these characters as path
 * separators, normalize them away.
 */
function normalizePathPercentEncoding(s) {
  // For incoming URIs, we expect all of these characters to already
  // be decoded. This replace should be basically free when the path
  // is already percent encoding normalized.
  return s.replace(/%(?:2d|2e|5f|7e|4[1-9a-f]|5[0-9a]|3[0-9])/gi, decodeURIComponent);
}

It is not the place of AngularJS to decode the entire path.  Whatever is handling the path and giving significance to segments—e.g., ui-router which considers the / character to be significant—should be the thing which handles calling decodeURIComponent() on individual components as necessary when extracting the information. A different service consuming $location might decide to use a different character which encodeURIComponent() would percent-encode as a significant character such as '&' or ; or '?'.

Additionally, I see that this is only applied for html5Mode. I actually came here because I was having this same exact problem except in hashbang mode.

Here’s a demo of this same problem existing in 1.7.3 in hashPrefix() mode: http://embed.plnkr.co/Z3Lh5F2b07uAEVgBpyAd/ . Just type in anything with a slash in it and note that it is interpreted as multiple arguments instead of one even though the link is properly encoded.

Thx for the thorough write-up, @binki. You are probably correct.
Unfortunately, changing the behavior of $location is a tricky thing. $location is a very critical part of every AngularJS application and existing code (including popular libraries, such ui-router) are relying on its current (imperfect) behavior. There have been attempts to rectify similar issues in the past, but ended up being reverted, because they apparently broke significantly more usecases than they fixed.
Given that AngularJS has now entered an LTS period, such breaking changes are out of scope.

If someone desperately needs this different (more correct) behavior, it is not too difficult to overwrite $location and provide an implementation that matches your requirements. This is even easier than fixing the existing implementation, because one only has to account for their app's needs, not every possible cornercase out there.

We in our application have  embedded callback urls in path itself and hence decodePath in non html mode (hash bang) has been causing the trouble.
Tried patching the $$parse and $$compose method using decorator pattern. But, the caveat with this approach is, that the decorators are invoked late and in scenarios where a page (with callback embedded) is refreshed, native implementations of $$parse and $$compose have already been invoked. Hence, the route mismatch.
Any reason why in native implementation; decodePath re-encodes the forward slashes to %2F only for htmlMode and not for hashbang mode?


fix: add a sanity check that all bulk mutation entries are accounted for

Add a fail safe that marks missing entries in a response as permanent errors. Previously the client assumed that all entries were present and only looked for errors
Change-Id: Ie3f294fd6bb19ec17662b58bfe9c75a3eed81097
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

[ ] Make sure to open an issue as a bug/issue before writing your code!  That way we can discuss the change, evaluate designs, and agree on the general idea
[ ] Ensure the tests and linter pass
[ ] Code coverage does not decrease (if any source code was changed)
[ ] Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕
If you write sample code, please follow the samples format.

LGTM


#4227 Fix baseTime logic for KPI Chart

Description
Fix baseTime logic for KPI Chart
Related Issue : #4227
How Has This Been Tested?

Need additional checks?
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] I have read the CONTRIBUTING document.
[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have added tests to cover my changes.

Additional Context

deploy to 1

deploy to 1

deploy to 1


adds an MIT License to project

In reference to https://github.com/atech/nifty-attachments/issues/5
On the off chance that you want to distribute with an MIT license (same as Nifty Utils and Nifty Dialog), thought I would make it one step easier.
Thanks for your consideration.

Added :smile:

Thanks @adamcooke! Much appreciated!


Added a RST primer I found on internet :D

Dunno - but it might be helpful!

unfortunately this is conflicting. Please remove the _build directory from your commit (you can revert your previous commit). Thanks

Should be fixed

awesome, thanks!


License

Hello @cozyGalvinism, would it be possible for you to add a license to this project? We're considering adding this repository to community examples in Saleor docs.

Hello, I've added the Apache 2.0 license to the project in b3aac35. I hope that helps!

Thanks a lot. We included your project in our docs section:
https://docs.saleor.io/developer/extending/apps/developing-apps/app-examples


Postgres version string from ubuntu still causing errors [BugFix]

When the PosgreSQL version has values like this: "12.4 (Debian 12.4-1.pgdg100+1)", a exception is raised in versionstring.split.
I added some normalization code to avoid this.
I don't have permission to contribute here with PR. So this is the patch to fix this.
def assure_version(v:str)->str:
	'''Assure the version from postgres is in 99.99[.99] format'''
	import re

	for match in re.finditer("(\d{1,2}.\d{1,2})(\.\d{1,2})?", v):
		return match.group()
	return v

Change the line 19 of postgresql/versionstring.py
from
	v = vstr.strip().split('.')

to
	v = assure_version(vstr).strip().split('.')

Your efforts are appreciated, however, I believe debian offers a py-postgresql package handling their special case.
Supporting such variations in the version string and the protocol is not within the scope of the project. If such compensation is desired, you will, unfortunately, need to manage a patched distribution yourself. (A runtime patch is also possible)
You may also want to consider using: https://www.postgresql.org/download/linux/debian/
I suspect apt.postgresql.org has managed to avoid modifying the version.
Future versions (py-postgresql) may make this a non-issue. Presumably, we can drop support for 8.5 and defer version parsing, but applications needing to switch on server versions would still need a patched variant to handle debian's case.

I've just encountered this same issue and don't see the above as a suitable resolution to this issue. Firstly, I am connecting to the database remotely and from a different operating system, so cannot rely on an OS-specific package release to resolve the issue. Secondly, no other client library gives the same error when connecting to the same database. If the above patch resolves this issue, why reject it?

In the short term, I think the runtime patch is something like:
import postgresql.versionstring as vs
def parse_debian_compat(vstr, _split=vs.split):
    return _split(vstr.split()[0])
vs.split = parse_debian_compat

Didn't test, so you might need to adjust it. Be sure to run that before doing other postgresql.* imports.

In the long term, I would advise not using a postgresql package that modifies that particular version string.
I suspect apt.postgresql.org will work. https://www.postgresql.org/download/linux/debian/
While other drivers connect successfully, applications that choose to switch on the version may be broken as well.
py-postgresql is revealing a symptom. The modification of that particular version string only serves to add risk.
On the py-postgresql side, the best that can be done is an exception trap defaulting the version.
Handling debian's (or other's) special case is simply out of scope. The only reason that this is even considerable is due to the possibility that a PostgreSQL fork or PQ server could, reasonably, make the mistake of omitting or adjusting this string substantially.
However, this driver is only tested against builds of source releases made by postgresql.org. If you're using it to connect to something that is not PostgreSQL, you will need to test it and likely make modifications to compensate.

I'm not interested in debating this further. I have been quite clear about my position. If you find this unacceptable, I recommend that you take your own advice and use another driver (#113).

Sorry, was just fairly frustrating when I tried to get a software
building on this library to run and then stumbled over discussions over
spaces in version strings.
Am 11.03.21 um 22:29 schrieb James William Pye:

I'm not interested in debating this further. I have been quite clear
about my position. If you find this unacceptable, I recommend that you
take your own advice and use another driver (#113
https://github.com/python-postgres/fe/issues/113).
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/python-postgres/fe/issues/105#issuecomment-797061791,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAPB6GNLTRFTX4VOTZKGGJDTDEY35ANCNFSM4SYLC6XA.


Running dev env on frontend with Node backend

Can you describe how to run the frontend part of it on Vue's dev server, and interact with the node backend? I want to edit the code and see the live changes.

I haven't tried it but my guess is that you would have to do the following:

Start backend with debug flag (see config.js)
Edit mininote-frontend/src/services/NotesApiService.js and set the apiBaseUrl to the absolute URL where your backend is listening, e.g. http://localhost:8080/api/
Run vue serve in frontend directory

NODE_ENV=dev npm start
cd mininote-frontend
Edit services/NotesApiService.js and temporarily change apiBaseUrl to http://localhost:3000/api
npm run dev


chore: add badges

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 50.135%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1259

Relevant Lines:
2059

💛  - Coveralls


withRouter doesn't parse query on static website

Bug report
Describe the bug
I'm using withRouter to get the query data from the URL, and when I export to a static website, the router.query prop is empty
To Reproduce
Steps to reproduce the behavior, please provide code snippets or a repository:

Use withRouter to wrap a component
export to a static website
add a query parameter to the URL
router.query will not contain it

Expected behavior
for router.query to contain
Screenshots
not static export:

static export:

System information

OS: Mac
Browser Chrome
Version of Next.js: [e.g. 6.1.1]

I have met the same question with you. actually, after exported, you can not use dynamic query params, instead of it you need to pass the query in your next.config.js => exportPathMap, for example:
exportPathMap: function(defaultPathMap) {
    return {
      '/': { page: '/' },
      '/about': { page: '/about' },
      '/readme.md': { page: '/readme' },
      '/p/hello-nextjs': { page: '/post', query: { title: 'hello-nextjs' } },
      '/p/learn-nextjs': { page: '/post', query: { title: 'learn-nextjs' } },
      '/p/deploy-nextjs': { page: '/post', query: { title: 'deploy-nextjs' } }
    }
  }

@wslx520 Thanks for clarifying, I understand it better now.
I need to pass a dynamic "id" to display a different entity each time.
How did you end up solving your problem?
I can create a higher level component to wrap my layout component and parse the query params by myself, is it a valid way to go?

@saginadir I think it's valid. sometimes I just write a function for getting query from the asPath

@wslx520 Awesome, thanks for the help, I implemented something similar that will fetch the query params, called it {myWithRouter} and using it to wrap my component instead of {withRouter}

@wslx520, @saginadir I was debugging the same issue before I came across this post. Maybe someone from the Next.js team could explain if this is how it should work? Maybe there a way to force the Router to refresh so that it reads the query?

I am not sure how the next.js team expect to solve this, but my solution was this:
// Our router to override the query
// missing query when deploying to static export
export const ourWithRouter = (Component) => {
  return withRouter(({router, ...props}) => {
    // taking the query from router and overriding the query
    router.query = globalRouter.match(router.asPath).query

    return <Component {...props} router={router} />
  })
}

globalRouter.match function parses the router.asPath property and returns an object which contains the query. In my case I use 3rd party next-router library which gives me slugified URLs.
But if you use the regular "?key=value" query, then maybe you can just use something like:
https://www.npmjs.com/package/query-string
to parse your URL

@saginadir Where do you obtain the globalRouter from?

@saginadir Where do you obtain the globalRouter from?

I Apologize for the late response
as I wrote globalRouter is:
"globalRouter.match function parses the router.asPath property and returns an object which contains the query. In my case I use 3rd party next-router library which gives me slugified URLs."
Depends on what you are trying to do - you may need to have custom code on how you parse the "router.asPath"

Above solution is really good but I’ve had some issues URLSearchParams() during SSR. So there is another (and shorter) version using library query-string:
import { withRouter } from "next/router";
import queryString from "query-string";

export const withPageRouter = Component => {
  return withRouter(({ router, ...props }) => {
    router.query = queryString.parse(router.asPath.split(/\?/)[1]);

    return <Component {...props} router={router} />;
  });
};

@chromale hmm the URLSearchParams global object was added in Node 10 and should be available in all browsers. Not sure why it would be causing issues. Anyway, what you have is also a nice option

@chromale my issue was on static website, from my understanding it should not happen during SSR if you are deploying next.js regularly?

Thanks for your snippet @james2doyle it would be awesome if that little example was in the docs

Here is what I ended up doing:
import { withRouter } from 'next/router';

/**
 * Our router to override the missing query when deploying to static export
 * This is required for page components that need access to the router
 *
 * @param {React.Component} Component
 *
 * @return {React.Component}
 */
export const withPageRouter = (Component) => {
    return withRouter(({ router, ...props }) => {
        // split at first `?`
        const searchParams = new URLSearchParams(router.asPath.split(/\?/)[1]);

        const query = {};
        for (const [key, value] of searchParams) {
            query[key] = value;
        }

        // replace the empty query
        router.query = query;

        return (<Component {...props} router={router} />);
    });
};

Very similar to what @saginadir did but without the external dependency. This works identically to withRouter from next/router

This doesn't work on IE11

This feature is supported out-of-the-box in Next.js 9! Please read the blog post to learn more.

Migrated to Next.js 9 to solve this problem, but that brought it's own problem to sour my joy!
Deciding to export pages as HTML files in the root of the /out directory like /out/page.html instead of the usual /out/pagefolder/index.html and no clear way to go back to the previous behavior is a bummer. I need to deploy with IIS and that returns not found when you visit a page directly because it interprets example.com/page as "Hey, give me the index file in the /page directory"

@Tonerolima https://github.com/zeit/next.js/blob/canary/UPGRADING.md#next-export-no-longer-exports-pages-as-indexhtml

Thank you @timneutkens, you are a life saver! I need to start contributing to Next.js soonest, even though I have no idea where to start

@Timer I am using<EMAIL_ADDRESS>with next export. But when I try to read query at pages/index.js as:
import { withRouter } from 'next/router';
import React from 'react';

class Home extends React.Component {
  componentDidMount() {
    const { router } = this.props;
    const { query } = router;
    const searchParams = [
      ...new URLSearchParams(window.location.search).entries()
    ].reduce((q, [k, v]) => Object.assign(q, { [k]: v }), {});

    console.log(JSON.stringify(query), JSON.stringify(searchParams));
  }

  render() {
    return null;
  }
}

export default withRouter(Home);

for a given /?some_key=someValue, the result for query is {}, yet searchParams is {"some_key": "someValue"}. So I do not think this is support out-of-the-box. Or am I making a mistake?

In the meantime, using the above ideas here is what I came up:
import { withRouter } from 'next/router';

/**
 * Our router to override the missing query when deploying to static export
 * This is required for page components that need access to the router.
 *
 * The idea is stolen from https://github.com/zeit/next.js/issues/4804#issuecomment-451558569
 */
export const withPageRouter = Component => {
  return withRouter(({ router, ...props }) => {
    // Mind that `router.query` is always empty on static exports,
    // per https://github.com/zeit/next.js/issues/2910
    router.query = [
      ...new URLSearchParams(
        (router.asPath && router.asPath.split(/\?/)[1]) || ''
      ).entries()
    ].reduce((q, [k, v]) => Object.assign(q, { [k]: v }), {});

    return <Component {...props} router={router} />;
  });
};

This wont work if your component uses getInitialProps() and depends on the props set by this. It will throw all kinds of errors.
You can fix that by
import { withRouter } from 'next/router';
export const withPageRouter = Component => {
  const routerWrapper =  withRouter(({ router, ...props }) => {
    router.query = [
      ...new URLSearchParams((router.asPath || '').split(/\?/)[1]).entries()
    ].reduce((q, [k, v]) => Object.assign(q, { [k]: v }), {});

    return <Component {...props} router={router} />;
  });
  routerWrapper.getInitialProps = Component.getInitialProps;
  return routerWrapper;
};

Ah @Rameshv you are right. Thanks for the heads up!

Alright following @Rameshv advice, plus looking at the source code at https://github.com/zeit/next.js/blob/canary/packages/next/client/with-router.tsx , I've updated the code above (at https://github.com/zeit/next.js/issues/4804#issuecomment-541420735) to something that I think should be bug-free now.

Extending on @cansin's example from https://github.com/zeit/next.js/issues/4804#issuecomment-541420735, I ended up with this:
import React from 'react';
import { withRouter as withNextRouter, useRouter as useNextRouter } from 'next/router';

/**
 * Given a string such as:
 *
 * https://example.com/foo?bar=zip&name=Sam
 *
 * Will return:
 *
 * {
 *   bar: 'zip',
 *   name: 'Sam',
 * }
 */
const queryFromUrl = url => {
  const [, ...queryStrings] = url.split('?');
  const queryString = queryStrings.join('?');
  const query = {};

  for (let [key, value] of new URLSearchParams(queryString).entries()) {
    query[key] = value;
  }

  return query;
};

const extractQueryFromRouter = router => ({
  ...router.query,
  ...queryFromUrl(router.asPath),
});

/**
 * Provide a router provider which ensures router.query is always correctly
 * hydrated on the first render even when statically optimised to avoid [this
 * caveat from the docs](https://nextjs.org/docs/routing/dynamic-routes):
 *
 * > Pages that are statically optimized by Automatic Static Optimization will
 * > be hydrated without their route parameters provided, i.e `query` will be an
 * > empty object (`{}`).
 *
 * Also injects a `.query` paramter to the `context` in `getInitialProps` making
 * it more useful than the existing `.asPath`
 *
 * Usage is identical to `import { withRouter } from 'next/router';
 *
 * Modified from https://github.com/zeit/next.js/issues/4804#issuecomment-541420735
 */
export const withRouter = ComposedComponent => {
  const WithPageRouteWrapper = withNextRouter(({ router, ...props }) => {
    router.query = extractQueryFromRouter(router);

    return <ComposedComponent {...props} router={router} />;
  });

  if (ComposedComponent.getInitialProps) {
    WithPageRouteWrapper.getInitialProps = (context, ...args) => {
      context.query = extractQueryFromRouter(context);
      return ComposedComponent.getInitialProps(context, ...args);
    };
  }

  if (process.env.NODE_ENV !== 'production') {
    const name =
      ComposedComponent.displayName || ComposedComponent.name || 'Unknown';
    WithPageRouteWrapper.displayName = `withPageRouter(${name})`;
  }

  return WithPageRouteWrapper;
};

/**
 * Provide a router hook which ensures router.query is always correctly hydrated
 * on the first render even when statically optimised to avoid [this caveat from
 * the docs](https://nextjs.org/docs/routing/dynamic-routes):
 *
 * > Pages that are statically optimized by Automatic Static Optimization will
 * > be hydrated without their route parameters provided, i.e `query` will be an
 * > empty object (`{}`).
 *
 * Usage is identical to `import { useRouter } from 'next/router';
 */
export const useRouter = () => {
  const router = useNextRouter();
  router.query = extractQueryFromRouter(router);
  return router;
};

Still not working on class components TS

This issue has been automatically locked due to no recent activity. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.


Latest version doesn't work with Traefik

I was using traefik as reverse proxy, and it was working until version 3.4.8.
I've test inside wizarr docker container a curl http://localhost:5690 succesfully. But outside the container through the proxy it doesn't respond.
I've check the tags and commands inside the different versions and seems that some commands are different including the command related with the port exposition:
EXPOSE map[5690/tcp:{}]  <-- appears in tag: latest-3.4.2 but not in 3.4.8 or latest
Perhaps could be the reason of the issue?
Thanks for your work.

Could you share relevant configs, like Docker Compose, Traefik config, and what Docker networks there both on

These are my docker-compose files for:

Traefik

version: '3.4'

services:
  proxy:
    image: traefik:latest
    container_name: proxy
    labels:
      - "com.centurylinklabs.watchtower.enable=true"
    restart: always
    ports:
      - "80:80"
      - "443:443"
      - "2222:2222"
#      - "9080:8080"
    volumes:
      - /etc/localtime:/etc/localtime:ro
      - /var/run/docker.sock:/var/run/docker.sock
      - ./traefik.toml:/etc/traefik/traefik.toml
      - ./conf:/etc/traefik
      - ./logs:/logs
      - ./ssl:/ssl
    networks:
      - proxy

networks:
  proxy:
    external: true

Wizarr

version: "3.8"
services:
  wizarr:
    container_name: wizarr
    image: ghcr.io/wizarrrr/wizarr:latest-3.4.2
    restart: unless-stopped
    networks:
      - proxy
    volumes:
      - ./config:/data/database
    environment:
      - APP_URL=https://mydomain.com #URL at which you will access and share
      - DISABLE_BUILTIN_AUTH=false #Set to true ONLY if you are using another auth provider (Authelia, Authentik, etc)
      - TZ=Europe/Madrid #Set your timezone here
    labels:
      - traefik.enable=true
      - traefik.http.routers.cronoswiz.entrypoints=web
      - traefik.http.routers.cronoswiz.rule=Host(`mydomain.com`)
      - traefik.http.routers.cronoswiz.middlewares=redirect-https@file
      - traefik.http.routers.cronoswizs.entrypoints=secure
      - traefik.http.routers.cronoswizs.rule=Host(`mydomain.com`)
      - traefik.http.routers.cronoswizs.tls.certresolver=le
      - com.centurylinklabs.watchtower.enable=true

networks:
  proxy:
    external: true

This version of docker-compose.yml works, if change to newest images, I got errors on traefik logs, like:

TRAEFIK: LEVEL=ERROR MSG=“FIELD NOT FOUND, NODE: PORT MISSING
if I don't setup the "..loadbalancer.server.port=5690" value inside the traefik labels or
TRAEFIK: LEVEL=ERROR MSG=“FIELD NOT FOUND, NODE: SERVER
if the previous label is setup inside docker-compose.yml

Hope it helps. Thanks

Don't understand your comment. The default docker network is "proxy" and it was working til update to the latest image of wizarr for months.

Don't understand your comment. The default docker network is "proxy" and it was working til update to the latest image of wizarr for months.

It's always best to be a member of both the proxy network and the default docker network so that you can effectively speak with other containers using local DNS (this isnt directly todo with your issue, only that it could prevent issues later if you try speaking to a JF or Plex container locally but not part of the same network) you can disregard that change but note it for future if you face issues, I have also removed the pointless env variables that V3 does not need anymore, these can cause potential problems when left there. The EXPOSE map[5690/tcp:{}] wouldn't have thought that would be the issue, we are talking about internal Docker networks, they act much the same to our external ones, however you are welcome to clone the repo and add EXPOSE 5690 to 86th line of this file ./dockerfiles/wizarr/Dockerfile and run docker build -f ./dockerfiles/wizarr/Dockerfile .

I understand how networks works in docker, all my containers are in the same network (proxy) to avoid those problem you comment. But that setup didn't work with traefik, if the solution is to make a fork of the repo, then the wizarr images will not work with kubernetes or other ingress proxies? There been a lot of images that works with reverse proxy without make a clone of a repository. But I understand your approach. Thank you.
Regards.

I understand how networks works in docker, all my containers are in the same network (proxy) to avoid those problem you comment. But that setup didn't work with traefik, if the solution is to make a fork of the repo, then the wizarr images will not work with kubernetes or other ingress proxies? There been a lot of images that works with reverse proxy without make a clone of a repository. But I understand your approach. Thank you. Regards.

I have added the EXPOSE back to the Docker Image, however it wont be in prod for a couple days, thats why I suggested building the Docker image, it would be a good indication if this is the issue or if its something else, in which case we can get it sorted for before the next release.
I have both a NginxProxyManager installation working with Wizarr, and I know a some of the devs have a Traefik installation working, if you want to speak with some of them about Traefik and there setup then feel free to open a discussion on our Discord.


Add Joyent's Triton as a deploy target

[x] Installs cleanly on a fresh build of most recent master branch
[x] Updates documentation relevant to the changes

Upgrading is not applicable, this is a new target.

lgtm (but needs rebased)

Rebased and merged. Thanks for your review, @ryane and @misterbisson

Appears to be published at http://docs.mantl.io/en/latest/getting_started/triton.html


Add Unit Test for UI

Use TextFX to perform automated testing of Ui

Close this issue as it is too complicated to implement in v1.3


Did the commentary ever materialize?

Hi @Zireael07, sorry it did not. But I was actually just thinking about testing this again and making sure it works (I have not been using libtcod, but happy to support lisp for it). Any questions in particular? If something doesn't work, feel free to submit an issue, though I'll be checking to see if everything is current.

I'm having trouble locating libtcod 1.6.2. for Linux (.so), so I can't even start :(

You'll need to install (or build) libtcod. Some distributions have this readily available, like on the AUR for Arch (package called libtcod). Please see their page: https://github.com/libtcod/libtcod


Changing the deployment source during app engine deployment resets the selected project

steps to reproduce:

Create a new App Engine (Beta) deployment run config
Select a module or artifact for deployment
Select your project
Changed the selected module or artifact
observe that the selected project has been reset

expected behavior:

changing the deployment source doesn't change the target project

@etanshaul and I had a discussion about this #679. It's not just the project, but every setting is cleared. The story doesn't seem simple. @etanshaul could provide some more context on this.
BTW, clicking on 'Cancel' will probably restore the previous settings. There might still exist some subtle problem.

duplicate of #679

The reason the project is reset (along with the rest of the settings) is that, as part of the framework, changing deployment source re-instantiates the editor window with a clean configuration.


Add support to HKHealthStore's startWatchApp method

Summary of changes
I added support to this method, that allows the library to expose the ability for the consumer RN app to start a workout on a companion watchOS app.
More information can be found in this WWDC tech talk and the corresponding sample app.

Released in 8.3.0, thanks @gentilijuanmanuel! 🚀


Question: How to specify a file input?

Hey all, thanks for this great library!
We're currently trying out to replace the old class-transformer lib with nestjs-zod, but face some issues here and there.
In this case, does someone how to specify a file input?
export class ImportFileDto {
  @ApiProperty({ type: 'string', format: 'binary', required: true })
  file: Express.Multer.File;
}

// to?
const assetImportSchema = z
  .object({
    file: z.instanceof(File),
  })
  .required({
    file: true,
  });

On a side note, it might be helpful to integrate https://github.com/asteasolutions/zod-to-openapi internally. It is well maintained so far and could help to benefit from general zod to openapi improvements, withou being tied to smaller nestjs community.

You can do with zod.
https://zod.dev/?id=strings
z.string().description("binary")

You can add requirement to check if it is the right format.
https://zod.dev/?id=refine
https://zod.dev/?id=transform
Zod does not permit to define format, nestjs-zod cannot infer the format only from zod DTO.
I am not a maintainer, my suggestion may not be valid


Does dopamine work with TextWorld?

TextWorld  has an interface to Open AI's gym framework.
Does this mean it's possible to train an agent in TextWorld using the algorithms in dopamine?

yes, you should be able to as long as it's discrete state and action spaces.
you will likely have to define a new network for it (see the cartpole or acrobot ones, for example).

Hi, if anything is missing in TextWorld to support dopamine, I would be happy to help. :)

Hi, if anything is missing in TextWorld to support dopamine, I would be happy to help. :)

Hi @MarcCote , thanks for the vote of confidence :) I think it should mostly work, but Dopamine isn't currently equipped with recurrent networks. So there might be some tooling required to e.g. deal with backpropagation through time. @vishaljain3991 has used TextWorld without Dopamine but with recurrent networks and might have input.

I see. I'm also worried about how we currently defined the observation_space and action_space for TextWorld Gym environments - both are subclasses of gym.spaces.MultiDiscrete where each categorical variable represents a word ID from the vocab (see details).
So far, I don't think anyone has used those custom spaces, and I'm not sure they are ideal.

Yes, fair point – that's probably more complicated. I would implement this by converting the observation in e.g. Dopamine's run_experiment before passing the vector to the agent. But again, extra piping.


Could not resolve module<EMAIL_ADDRESS>when using npm

Environment
with deps
"@nuxt/devtools": "latest",
"@nuxtjs/i18n": "npm<EMAIL_ADDRESS>"nuxt": "^3.8.1",
"vue": "^3.3.8",
"vue-router": "^4.2.5"

Reproduction
https://github.com/metkm/test
Describe the bug
Installing the module using npm and running will result in the following error
Could not resolve module<EMAIL_ADDRESS>
Users need to install @intlify/vue-router-bridge, @intlify/vue-i18n-bridge and vue-i18n-routing as dev dependencies to get around this issue. So workaround is to run: npm i -D @intlify/vue-router-bridge @intlify/vue-i18n-bridge vue-i18n-routing.
Additional context

This issue was mentioned in #2490
Related https://github.com/nuxt/nuxt/issues/15721

Logs
No response

In fact, if I understand correctly, it is the Edge Release Channel that is the problem.
If npm install runs a clean install, without existing node_modules and package-lock.json, then the "@nuxtjs/i18n": "npm:@nuxtjs/i18n-edge" dependency does not install the entire module and does not download all files.
For example, the core-base folder.
If you install it first:
npm install @nuxtjs/i18n@next --save-dev
And then replace in nuxt.config.js according to the instructions:
{   "devDependencies": { -- "@nuxtjs/i18n":"^<IP_ADDRESS>-rc.1" ++ "@nuxtjs/i18n": "npm:@nuxtjs/i18n-edge"   } }
Next, delete package-lock.json ( node_modules should remain) and run npm install.
Everything should work now.

Can you check if you're experiencing this issue if you have vue and vue-router installed as dev dependencies?

both dependencies can be set to use >=0.14.6? Or maybe >=0.13.5 would be more lenient..

i do not recommend use >=
it will allow to update major version, which is most of time breaking
maybe better use will be >=0.13.5 < 1.0.0

Agree, that would be a bit safer, I've changed the PRs to set it to >=0.13.5 < 1.0.0

works with nuxtjs/i18n vs 8.0.0-rc.1

Just merged #2583, can you check if you're still experiencing this issue using the latest edge release? npm i -D @nuxtjs/i18n@npm:@nuxtjs/i18n-edge

It looks good using edge for me as well - https://github.com/AloisSeckar/WBSC-Scoring
Thanks for fixing

Just merged #2583, can you check if you're still experiencing this issue using the latest edge release? npm i -D @nuxtjs/i18n@npm:@nuxtjs/i18n-edge

After applying the command from your post I now see version 8.0.0-rc.6-28361712.0bc7eea in my package-lock,json
It works, but I had to delete node_modules and package-lock.json and do a fresh npm install first. Updating to edge version alone didn't help.

Happy to hear it's working! I just merged #2593 as well which should prevent these dependencies from being installed further nested, will probably publish rc.7 soon which includes these fixes.

It works, but I had to delete node_modules and package-lock.json and do a fresh npm install first. Updating to edge version alone didn't help.

I forgot to mention this, this may be necessary for rc.7 as well for those still getting this error.

Closing as the fixes are now released in https://github.com/nuxt-modules/i18n/releases/tag/v8.0.0-rc.7!
If you're running into this with rc.7, try deleting node_modules and lockfiles and installing again. If you're still running into this issue after that, let me know and I will reopen this issue.

I still have the same issue with "@nuxtjs/i18n": "8.0.0-rc.7" :(

@Tofandel
Sorry to hear that, could you provide a minimal reproduction?

I still have the same issue with "@nuxtjs/i18n": "8.0.0-rc.7" :(
Tried deleting the package-lock.json and node_modules but still I have to install npm i -D @intlify/vue-router-bridge @intlify/vue-i18n-bridge vue-i18n-routing otherwise the issue happens

For me, it worked like this: having the following in package.json:
    "@nuxtjs/i18n": "npm:@nuxtjs/i18n-edge",
    "@nuxtjs/i18n-edge": "npm<EMAIL_ADDRESS>
with a new npm it started working again :)

I'm having this issue on the non-edge 8.0.0 version :/

@gbyesiltas
Can you provide a reproduction? Also have your tried deleting node_modules and lockfiles and installing again?

@gbyesiltas Can you provide a reproduction? Also have your tried deleting node_modules and lockfiles and installing again?

Yes, I have tried deleting the node_modules and the lock files. I will add a reproduction when I have the chance, thanks for the quick reply :)

Update: I had vue-i18n-routing as a dependency myself at my devDependencies and was using to import the STRATEGIES enum. Removing that fixed the issue for me :) Just using the strings for the strategies from here now :)


Unable to save states of log on reload / reset to defaults

I am very angery this is inacceptable!1!!1

Saving States is available in 0.1.1.


vertex number of face model?

I'm having trouble with the number of vertices in the face model. Basically, I would like a uv-mapping of the model, and there is one for the BFM available online, but the vertex numbers do not match with your model. yours has 53215 vertices, and the BFM has 53490 - where did the 275 vertices go? what model did you use?

Forspecific pre-processing details, you can refer to here.


Add New Item in web template doesn't work.

Describe the bug

Steps to Reproduce

Create a Blank Django Web Project template.
Right click the project, select Add > New Item

Additional context and screenshots
The "New Item" window did not pop up.
BTW, I can repro it in web-based Projects. (Python Application cannot repro.)

@ttSpace does this still repro? I couldn't repro it on the latest version.

@StellaHuang95 I cannot repro in today's build 17.6.0 Preview 2.0 [33408.313.main], Python Package: 17.0.23033.1.


Error appearing when no scheduler is set

Hello,
I'm trying to use Salsa in a comparison with other optimizers and I found the following issue:
when trying to run the optimizer without any scheduler the following error appears,
File "/home/claudiu/miniconda3/envs/midas-py310/lib/python3.10/site-packages/torch/optim/lr_scheduler.py", line 38, in __init__
    group.setdefault('initial_lr', group['lr'])
KeyError: 'lr'

This is due to the fact that no learning rate is specified in the optimizer. I found a simple work-around by adding
for group in optimizer.param_groups:
            group['lr'] = 0.0

after the initialization of Salsa optimizer.
hope this helps,
Claudiu

It was an issue in my code, I solved it.
Thank you anyway :+1:


Follow-up for policy trace refactor

These are follow-up items for #7871:

Docs update
Refactor string allocation

This change is

test-docs-please

Coverage decreased (-0.007%) to 41.583% when pulling 6dc3e42b11aee1ddffb7e1b7704bc676b2c79b99 on joestringer:submit/trace-via-filter-followup into a41d8a05b8da69841b5f5d4511cfc3dd006ed482 on cilium:master.


Esp boxes not showing only tracer line

The bug occurs without having Optifine or Optifabric installed? (Optifine bugs won't be fixed)

[X] Yes, I don't have Optifine install.

Mod version
2.3.1
Minecraft version
1.20.1
Mod loader
Fabric
Description of the issue
only my tracer lines are appearing the boxes to highlight the item is not appearing i have 1.20.1 optifine installed and am using fabric
Excepted behavior
the boxes to show and the lines to show
Obtained behavior
No response
How to reproduce
No response
Do I want to contribute to fix it?
No
Something else?
No response

same issue here


2 year follow-up MRI data

Hi,
Your current data release only contains the initial/baseline MRI (and fMRI) assessment of 9-10 year olds, is that correct? If so, are you also planning to release at some point the 2nd year follow-up data (MRI and fMRI) that are available in the ABCD release 3.0 on NDA (https://nda.nih.gov/study.html?id=901)? Trying to figure out which data are best for us to download and use.
Thanks!
Martin

Hi, came here to ask the same question.
Wondering if I should wait for a BIDS release or fetch the source files from the 3.0 release.
Thanks a lot!

Hi there!
Great question!
Yes, we are planning ongoing releases for the Year 2 data and beyond. We are currently in the process of preparing the Year 2 data for processing (ABCD 3.0 and 4.0), and anticipate having the data ready by summer.


Threefold Video Project: Use Cases and Deployments

Threefold Video Project: Use Cases and Deployments
Goal of the Project
We want to initiate a series of videos on how to use the Threefold Grid.
The project is free in nature, meaning we let people create videos as they see fit.
The overall idea is to see what the public wants, and guide ourselves based on feedback.
We also want to create clear and accessible documentation for everyone to use the Threefold Grid.
We want to show that it is easy and quick to deploy on the Threefold Grid. We want to show how it is different than the mainstream and centralized method.
This project will evolve as we get feedback.
Content to Produce
We invite people to share a list of the videos or subjects they would like to address.
We can update this main post to share the different projects proposed.

Here is a project that I think would be a great complement to this video project.

 Threefold Deployment Course: The Complete Picture, Text and Video Guide
The Goal and Overview of the Project
The goal is to make a website with video and picture guides on how to deploy everything Threefold.
The overall output would be very much inspired by the great Huggingface course.
Steps to Achieve the Goal

Take as the core content the Threefold User Guide (picture guide)

pre-deployment
deployments

full vm
micro vm
telegram bot
zola & wordpress website
more

create video tutorials based on the Threefold User guide
create the website

basic Zola website

add content / populate the website with

The Threefold User Guide content

Add short videos for each sections

between 2 and 5 minutes per video

max 7 minutes for complex topic

Basic Template of the Videos

Structure

intro

animations with the writings:

Threefold User Tutorial Series

*Name of video

Powerpoint with face top right
Explain in few minutes the steps of the tutorial
Show the line of codes, screenshots of apps, etc.

The following is the main architecture of the Threefold User Guide. The videos would cover all the following content.

You can see part of the guide already on Github: here and here.
The Threefold User Tutorial Main Concent

Introduction
Create a Threefold Connect Account and Wallet

Download the Threefold Connect App
Create a Threefold Connect Account
Verify Your Identity (KYC) by Email
Create a Threefold Connect Wallet

Get TFT: Buy TFT on Lobstr

Download the App and Create an Account
Connect Your TF Connect App Wallet
Buy XLM with Fiat Currency
Swap XLM for TFT

Threefold Dashboard: Create Account and Transfer TFT

Create Polkadot Extension Account
Transfer TFT from Stellar Chain to TF Chain

Generate an SSH Key

Set SSH on MAC/Linux/Windows

SSH into a 3node on IPv4, IPv6 and the Planetary Network
SSH File Transfer between Remote and Local

Windows

Putty
WSL

Create a Profile Manager
Deploy Workloads

SSH Connection

IPv4
IPv6 and Planetary Network

Virtual Machines

Full Virtual Machine

Cockpit
GUI with xrbp

Micro Virtual Machine

GUI with xrbp

Projects and Use Cases

Telegram AI-ML Bot in Python

Create the Bot on Telegram
Download the Bot Python File
Upload and Run the Python Bot on the 3node

Zola & Wordpress Websites

Conclusion

Ask a Question

Very cool project! I'd be happy to help out with organising a content calendar/planner. Let me know how you'd like to go forward @Mik-TF @scottyeager @weynandkuijpers. Some initial question to get a clearer direction:

How many videos can we expect per week?
Can we create a list of topics to be covered?

Sam mentioned to me an idea of creating a crashcourse series as part of the video project, I think it would be very cool. That would need some structure of its own for planning & posting. Happy to help here as well!

@VicObee
Thanks for the offer. That would be nice to have some organizing overview.

I could post one or two videos per week, starting next week
I would go through the Threefold User Tutorial Content, by chapters or subchapters

Soon we would have a playlist of user guides, a series of videos covering the basics and more
More workload examples could be added (jitsi, taiga, qsfs, kubernetes)
Once use cases go up, I could also do the same for the Farming guide (not a priority)

I created this doc which includes a topic overview & a weekly calendar overview.

@VicObee
Why this in test_feedback repo ?
shouldn't this be a story ?


Update nf-processthreadsapi-openprocess.md

PID 0 is the System Idle Process.

@justanotheranonymoususer : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@Karl-Bridge-Microsoft : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@Karl-Bridge-Microsoft : Thanks for your contribution! The author(s) have been notified to review your proposed change.


SearchFilter fatal error, call to method on non-object (i.e. no sanity check)

Affects all current branches. The following code generates a fatal error if you attempt to filter by a field such as one which you might find on a ManManyList via a $many_many_extraFields value:

( ! ) Fatal error: Call to a member function setValue() on a non-object in framework/search/filters/SearchFilter.php on line 195

For example, the extra field could be SortOrder and you might want to get something from a ManyManyList which may have a SortOrder value higher than 2, like this:
// This is a ManyManyList taken from some relation, somewhere off in the ether.
$list->filter(["SortOrder:GreaterThan" => 2])->toArray();

This fails because ->dbObject() (here: https://github.com/silverstripe/silverstripe-framework/blob/3/model/DataObject.php#L2948) doesn't always return an object, it can sometimes return null (albeit it's not explicitly defined in the docblock like it should be, but I digress). Either way, I'd highly suggest doing a quick sanity check in this ->getDbFormattedValue() method to prevent errors like these.
Affected code:
https://github.com/silverstripe/silverstripe-framework/blob/3/search/filters/SearchFilter.php#L199
	public function getDbFormattedValue() {
		// SRM: This code finds the table where the field named $this->name lives
		// Todo: move to somewhere more appropriate, such as DataMapper, the magical class-to-be?
		$candidateClass = $this->model;
		$dbField = singleton($this->model)->dbObject($this->name);
		$dbField->setValue($this->value);
		return $dbField->RAW();
	}

Recommended solution:
	public function getDbFormattedValue() {
		// SRM: This code finds the table where the field named $this->name lives
		// Todo: move to somewhere more appropriate, such as DataMapper, the magical class-to-be?
		$dbField = singleton($this->model)->dbObject($this->name);
		if (!$dbField) return $this->value;
		$dbField->setValue($this->value);
		return $dbField->RAW();
	}

I've not checked to see if this affects any other areas of the framework which may be depending on an object coming out of ->dbObject(). If this is a common (erroneous) assumption, it may be better to return a generic type, like Varchar or something.

Also, this may also be a good indication that  $many_many_extraFields should be supported by ->dbObject() (on DataObject). So there are three issues here in one:
Sanity check here in SearchFilter->getDbFormattedValue()
Support for $many_many_extraFields in DataObject->dbObject()
Failover to a generic Varchar to encapsulate the value from the DataObject's result from ->getField($fieldName) and then return that just in case elsewhere in the framework someone attempts to fetch an object from ->dbObject().
Personally I don't like this last option since it sort of says "Uh yeah, uh ... sure I have that field! Uh here yah go!"

I'm confused by the existing code... we cast a DBField, but then just get the raw value straight back out of it? In which cases does that fix or protect against anything?
In the age of parameterised queries, I would guess that we might be fine with a simple return $this->value;.

Ok, it's all to do with DBField::setValue doing cleanup on entry. :P E.g. SS_DateField doing cleanup.
In this case, I guess you'd still need that for many_many_extrafields?

Ok, this is a possible place to look...
apparently SearchFilter::apply is passed two parameters, the DataQuery as the first, and the DataList as the second.
If you added $list to the second parameter, you could theoretically check for extra casting helpers (since this list would be a ManyManyList in some cases).
It would be a breaking API though, but doable. Just update all the SearchFilter methods to take both as parameters.

Also, some search filters are just doing getValue() when they should be using getDbFormattedValue() :D

I have no clue what you're talking about with SearchFilter::apply but I do agree with you on the assesment of simply returning $this->value on the SearchFilter instance (no need for Varchar encapsulation nonsense I mentioned).
My attempt to workaround this without making yet another modification to core (due to the fact that I still need to upgrade our site and I've already get a pile of PR's out there that I've yet to update or get around to or yet to be merged, etc). You know me -- I've got many issues that require PR's that I've yet to get to (part of why my company is poking you guys for more formal help, by the way :wink:).  So: Funny you should say that about parameterized queries, though. I'm currently working around the tangled mess of interrelated dependencies of GridField and this GridFieldSortableRows object (unrelated, but it's here: https://github.com/UndefinedOffset/SortableGridField/blob/master/code/forms/GridFieldSortableRows.php#L207) which goes right back and tries to get the record off the GridField by proxy of a Form. All that since the object itself (as you can see there) uses Raw Queries to work around the fact that you cannot really touch extra fields... due to a gap in the framework :disappointed:

So @tractorcow  you'll find probably about 4 or 5 instances in our code where I spitefully write:
$form = new Form(new Controller(), "whocares", $obj->getCMSFields(), new FieldList());

Haha... ugh.

I'm in my own little world...
let me put it his way.
/**
	 * Applies a comparison filter to the query
	 * Handles SQL escaping for both numeric and string values
	 *
	 * @param DataQuery $query
	 * @param DataList $list
	 * @return $this|DataQuery
	 */
	protected function applyOne(DataQuery $query, DataList $list) {
		$this->model = $query->applyRelation($this->relation);

		$predicate = sprintf("%s %s ?", $this->getDbName(), $this->getOperator());
		return $query->where(array(
			$predicate => $this->getDbFormattedValue($list)
		));
	}

	/**
	 * Return the value of the field as processed by the DBField class
	 *
	 * @param DataList $list
	 * @return string
	 */
	public function getDbFormattedValue($list) {
		// SRM: This code finds the table where the field named $this->name lives
		// Todo: move to somewhere more appropriate, such as DataMapper, the magical class-to-be?
		$candidateClass = $this->model;
		$dbField = singleton($this->model)->dbObject($this->name);
		if(!$dbField) {
			if($list instanceof ManyManyList) {
				$extras = $list->getExtraFields();
				if(isset($extras[$this->name])) {
					$dbField = singleton($extras[$this->name]);
				}
			}
		}
		if(!$dbField) {
			return $this->value;
		}
		$dbField->setValue($this->value);
		return $dbField->RAW();
	}

I see what you mean. You originally lost me at ->apply() - so you meant ->applyOne(). Plus passing a list like that so deep into the matrix seems a bit fucky* to me. Instead, maybe it makes more sense for ->dbObject() to detect this for you, since that's what you're after. The database object representing that field, regardless of where it really lives. I suppose maybe the difficulty here is that (if I recall correctly somewhere in the dark corners of my SilverStripe knowledge) that these extra fields are only present on certain objects AFTER they're fetched from a ManyManyList which is why I can tell you're passing that list down the stack.

*Yes I misspelled that but didn't bother to fix it because it fits :smile:

Plus passing a list like that so deep into the matrix seems a bit fucky* to me

I think it's ok, search filters are MENT to be used on DataLists, so it's probably ok for the context to be there.

Because extra fields aren't a component of the model; They are a component of the relationship, which is on the mapping table.
Another way to do this is to externally inject setExtraFields() onto the filter, and make ManyManyList invoke that on filter.


middleman forced polling cranks up CPU

As I discussed 6+ months ago in a different issue, I use middleman inside a vagrant VM which requires force-polling to update pages properly. It's not only slow, but it kills the VM's CPU or disk usage which in turn ramps up my laptops' fans because the battery starts draining like crazy.
Any ideas how to fix this?

I'm trying to run middleman using boot2docker and fig, with the source code being host-mounted back to osx.
This setup works extremely well with my Rails application.  File changes are picked up immediately.
The same setup with middleman does not pickup file changes, I have to restart the middleman server every time.
Any idea why it would work with Rails and not with middleman?  And is there any way I can just tell middleman to reload files on every request?

Not sure. Pretty sure we use the same file watcher.

I seem to have it working well now with --force-polling turned on.

Vagrant using VirtualBox with the default shared folders never worked for me with Middleman server. force polling fixes this but always maxes out the CPU.
Reconfiguring Vagrant to use rsync works amazingly well. AND, you don't need to use force polling with middleman server. The only drawback is that the rsync only works one-way, so make sure to deploy direct from Vagrant or revert back to shared folders to grab your build.

@makeaweli I recently came up with a better approach than "force polling".  I'm using docker and docker-compose to run my development environment (which uses Virtualbox in the background), so I created an additional docker container which runs unison sync (bi-directional) to continually sync my local sandbox into a docker volume container.
It's working really well for me, allowing me to edit locally but have changes recognized by middleman (and other processes) running in the virtualbox vm.

Great to hear unison is working well for you!
Unison was my first thought when encountering the rsync one-way issue, but I was scared off by comments about bad performance with the unison vagrant plugin.

@marclennox - do you still use unison / docker / virtualbox?
I'm re-investigating replacing our vagrant stack as we move to more front-end development where this problem (inotify not working over NFS shared folders) is causing us headache.

Hi @toobulkeh.  No I do not.  Docker machine and compose have gotten a lot more stable since, so I use that in conjunction with a very excellent project called dinghy (https://github.com/codekitchen/dinghy).  Dinghy basically ties up all the loose ends for developing in Docker on a mac, I highly recommend it.

Thanks for the reference! I'm trying out https://github.com/adrienkohlbecker/vagrant-fsnotify, but am running into some problems / limitations. I'd love to give docker a try eventually and that pushes me in that direction.
Thanks again!


switch to nsp

bump version to 2.0

I've taken a different approach, closing this pr in favor of: https://github.com/wercker/step-shrinkwrap-security-audit/pull/2


Optional event execution indexing

Please consider making event execution indexing optional. Since it is not used for any logic directly, it can be made optional and can help reduce i/o.

Please fix the build failure.

Pull Request Test Coverage Report for Build 4217

1 of 5 (20.0%)  changed or added relevant lines in 2 files are covered.
20 unchanged lines in 4 files lost coverage.
Overall coverage decreased (-0.1%) to 69.442%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

core/src/main/java/com/netflix/conductor/core/config/SystemPropertiesConfiguration.java
0
1
0.0%

core/src/main/java/com/netflix/conductor/core/orchestration/ExecutionDAOFacade.java
1
4
25.0%

Files with Coverage Reduction
New Missed Lines
%

core/src/main/java/com/netflix/conductor/core/orchestration/ExecutionDAOFacade.java
1
58.82%

mysql-persistence/src/main/java/com/netflix/conductor/dao/mysql/MySQLBaseDAO.java
3
69.32%

cassandra-persistence/src/main/java/com/netflix/conductor/dao/cassandra/CassandraEventHandlerDAO.java
8
68.42%

cassandra-persistence/src/main/java/com/netflix/conductor/dao/cassandra/CassandraMetadataDAO.java
8
55.44%

Totals

Change from base Build 4211:
-0.1%

Covered Lines:
12401

Relevant Lines:
17858

💛  - Coveralls

Build failure is fixed and please check when you get a chance.


Height of inputs in ArrayList component is too large

Setup

Rancher version: Pre 2.7.0?

Describe the bug

The height of the input element in the ArrayList component is too high

To Reproduce
Used in a far number of places, for examples see linked PR screenshots
Result
See PR screenshots
Expected Result

Height should be a standard input, not one sized for if we had labels within input
See PR screenshots

Screenshots

See PR screenshots

Validated on Rancher version: v2.10-5d66d49d7a72b4c439a33043007e9bb0223c8693-head
UI: master cf8c6d1
The Array fields height is meeting the expected criteria described in the PR linked to this issue.


Delete bookmark

Added to the UI the option to delete a bookmark
Added deleting method to DAO
Deleting is done by bookmark-id, so added the id to bookmark listing (+ changed the tests accordingly)
There are no test for now, need to decide first if there will be a test database

Codecov Report

Merging #16 into master will decrease coverage by 2.38%.
The diff coverage is 56%.

@@             Coverage Diff              @@
##             master      #16      +/-   ##
============================================
- Coverage     69.67%   67.28%   -2.39%
  Complexity       61       61
============================================
  Files            10       10
  Lines           310      321      +11
  Branches         16       17       +1
============================================
  Hits            216      216
- Misses           86       97      +11
  Partials          8        8

Impacted Files
Coverage Δ
Complexity Δ

src/main/java/app/App.java
54.28% <0%> (-5.09%)
6 <0> (ø)

src/main/java/app/dao/BookMarkDAO.java
22.5% <0%> (-3.98%)
2 <0> (ø)

src/main/java/bookmarks/VideoBookmark.java
100% <100%> (ø)
3 <1> (ø)
:arrow_down:

src/main/java/bookmarks/PodcastBookmark.java
100% <100%> (ø)
3 <1> (ø)
:arrow_down:

src/main/java/bookmarks/BookBookmark.java
86.36% <100%> (ø)
3 <1> (ø)
:arrow_down:

src/main/java/bookmarks/BlogBookmark.java
100% <100%> (ø)
3 <1> (ø)
:arrow_down:

src/main/java/app/ui/TextUI.java
76.36% <33.33%> (-1.42%)
22 <1> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70ff0dd...ebb59eb. Read the comment docs.


replaceTo causes scene overlap if a stacking scene is the last scene on the stack

Steps to reproduce:

Call flow.goTo on a non-stacking scene
Call flow.goTo on a stacking scene
Call flow.replaceTo on any scene

To fix this we'll need to save the current scene stack in an array each time that we transition to a new scene.

fixed


add config_name and data_files to datasetcard.md specs

As realised in #1222 the specs of the datasetcard are not up to date. This PR therefore updates the specs.
Let me know if this is sufficient or you would like to add more config examples.
Cc: @severo, @polinaeterna

I personally would keep it simple but not sure

Since this is just an example dataset card, we don't necessarily need to include all possible parameters. A simple example use case should suffice, with a link to more options (to allow users to explore more gradually if they'd like), as you suggested sounds great to me.


Adding bike_index to real-world-rails

Bike index is very interesting https://bikeindex.org/

Great find, thanks @duleorlovic! 👍


fix: operation trait object description

title: "FIX: operation trait object description"

Related issue(s): fixes: #994

Earlier
Now

the description didn't exclude the messages field as operation trait object doesn't have messages field like action or channel.
the exclusion list includes the messages field as well along with others.

Add the ✏ Editorial label.
NOTE: I found a number of MarkDown linting errors. Just want to confirm is it fine to Push the refactored changes in the same Pull Request or open a New Pull Request.

Always make sure that the specification markdown file has no markdown-related errors.

hey @akshatnema @smoya it would be great id you review the pull request for any changes or anything

NOTE: I found a number of MarkDown linting errors. Just want to confirm is it fine to Push the refactored changes in the same Pull Request or open a New Pull Request.

I would recommend you do it better in a new PR

sure @smoya I will raise a new PR by improving the MarkDown linting as per the standards once this gets merged to avoid any conflicts

@akshatnema please change the title prefix to docs: so we do not release a new fix but rather we consider this as an ambiguity in docs. The JSON Schema docs are not changing either.


Shadow Problem

So I haven't figured out why, but more times than not, when i tap on the left menu bar, opening up the menu. There is a blank vertical line all the way on the right side of the screen.
My app is on the iPad landscape mode. The shadow is not covering the view completely and it looks like its as wide as 5-8 pixels. The length of it is the entire length of the small side of the iPad. Do you know what is going on? I can't figure out why the shadow doesn't cover the entire view.
Thanks!!!

Fixed


[BUG] Block quote callouts don't display correctly

Config

nvim version: 0.10
theme: default (or any other)
os: arch linux

  {
    "OXY2DEV/markview.nvim",
    ft = { "markdown" },
    dependencies = {
      "nvim-treesitter/nvim-treesitter",
      "nvim-tree/nvim-web-devicons"
    },
    opts = {}
  },

What should happen

What actually happen
As you can see the callouts are not applied.

How to reproduce
With the default config, paste the next text
> Block qutes and callouts/alerts

> This is a normal block quote.
> It spans a few lines.
>
> It has gaps between lines.

> Important
> This is a callout.
> It has it's own custom style.

> A success callout with a custom title.
> Custom titles are also supported.

> Note
> Custom titles are also supported.

> Note
> You can also nest them.
>
> > Bug
> > Like this one

It works correctly thank you

It would be a good idea to mention that at the top of:
https://github.com/OXY2DEV/markview.nvim/wiki/Block_quotes
example markdown
> [!SUCCESS]
> Text that goes below

It would be a good idea to mention that at the top of:
https://github.com/OXY2DEV/markview.nvim/wiki/Block_quotes
example markdown
> [!SUCCESS]
> Text that goes below

It actually is right here.
But I guess it is a bit hard to spot.

@OXY2DEV I saw it and I didn't understand. Up to you but I would approach wiki pages like:

What is this for
Image
How to use it

And then the options in detail as we are currently doing.

@OXY2DEV I saw it and I didn't understand. Up to you but I would approach wiki pages like:

What is this for
Image
How to use it + minimal copy pasteable markdown example.

And then the options in detail as we are currently doing.

The wiki is incomplete simply because a lot of the stuff may change in the later updates. So until things get stable-ish, they are gonna look like that.


Support @Rule annotation on method

Tks for your cool job, this test tool saved me a lot of time.
But I met a strange issue currently. I have written some code like below:
@Rule
public WireMockRule baseServer() {
    return new WireMockRule(options().port(serverPort()).bindAddress("<IP_ADDRESS>").notifier(new ConsoleNotifier(true)), false);
}

I marked the @Rule annotation on a method instead the field. Because I need to lazy initialize WireMockRule and inject the  port which dynamic generated from spring boot to create the real instance. But writing in this way would failed to bind the port.
So I have to modify the code like below:
private volatile WireMockRule mockRule;

@Rule
public synchronized WireMockRule baseServer() {
    if (mockRule == null) {
        mockRule = new WireMockRule(options().port(serverPort()).bindAddress("<IP_ADDRESS>").notifier(new ConsoleNotifier(true)), false);
    }
    return mockRule;
}

Writing in this way could finally resolve the port binding issue, but it's kind of ugly.

So you're saying the second version always works but the first doesn't?
Any idea why there's a difference? I'd have thought if in the first case the method is getting called before the port is allocated then that would happen in the second instance too?

Year, the second one work perfectly. But the first one would just fail.
Sample reproduce code:
import org.junit.rules.MethodRule;
import org.junit.rules.TestRule;
import org.junit.runner.Description;
import org.junit.runners.model.FrameworkMethod;
import org.junit.runners.model.Statement;

public class TheRuleRunningTwice implements MethodRule, TestRule {

    @Override
    public Statement apply(Statement base, Description description) {
        return apply(base, null, null);
    }

    @Override
    public Statement apply(Statement base, FrameworkMethod method, Object target) {
        return new Statement() {
            @Override
            public void evaluate() throws Throwable {
                System.out.println("Start Mock Server");
                try {
                    before();
                    base.evaluate();
                } finally {
                    after();
                }
            }
        };
    }

    protected void before() {
        // NOOP
    }

    protected void after() {
        // NOOP
    }
}

import org.junit.Rule;
import org.junit.Test;

public class RuleTest {

    @Rule
    public TheRuleRunningTwice rule() {
        return new TheRuleRunningTwice();
    }

    @Test
    public void show() throws Exception {

    }
}

Your would see, the Start Mock Server printed twice.

Implement both TestRule and MethodRule would cause the Rule class called twice if you put the @Rule annotation on a rule method.

Right, got it. Time to drop support for old versions of JUnit then I guess! Thanks for the report.


Fixed decoder time out issue in case of duplicated timestamp

This issue is to fix decoder timeout issue while dequeuing
input buffers. The root cause is that no input buffer returned
to codec2.0 framework in case of receving buffers with dumplicate
timestamp.
Tracked-On: OAM-101354
Signed-off-by: Chen, Tianmi<EMAIL_ADDRESS>

@dyang23 , @yuanjunhuang, @zhangyichix , please have a review.


Add network-lookup extension

Description

Screencast

Checklist

[x] I read the extension guidelines
[x] I read the documentation about publishing
[x] I ran npm run build and tested this distribution build in Raycast
[x] I checked that files in the assets folder are used by the extension itself
[x] I checked that assets used by the README are placed outside of the metadata folder

Hi @frankiexyz. Do you know about the extension IP Geolocation? They both seem to have the same functionality


Editor position can jump by hundreds of lines when switching tabs

Does this issue occur when all extensions are disabled?: Unknown

VS Code Version: 1.75.1
OS Version: Mac OS Ventura 13.2.1 (22D68)

Steps to Reproduce:

Open a dozen files, of around 2,000 lines, split them into panes, multiple tabs per pane.
Switch between the tabs in the different panes
The position of the editor will sometimes jump by hundreds of lines, can be up or down

I see it happening maybe 10-20 times a day, I thought I it was just me to begin with but I think it might be a bug, could be worth looking at.

/gifPlease

Thanks for reporting this issue! Unfortunately, it's hard for us to understand what issue you're seeing. Please help us out by providing a screen recording showing exactly what isn't working as expected. While we can work with most standard formats, .gif files are preferred as they are displayed inline on GitHub. You may find https://gifcap.dev helpful as a browser-based gif recording tool.
If the issue depends on keyboard input, you can help us by enabling screencast mode for the recording (Developer: Toggle Screencast Mode in the command palette). Lastly, please attach this file via the GitHub web interface as emailed responses will strip files out from the issue.
Happy coding!

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!


optimize on ARM (A53 A73)，can realize？

first of all, your code is very excellent, i want to use your code , let it run on ARM CPU, for example, A53, but it is very SLOW!, so ,can you optimize this code on ARM CPU?   Best My Regards!

It's a generic code, it cannot be made faster. If you do not need maximal quality you may try LancIR resizer.

ok,well, i just test the LANCIR resizer, an 1920*1080 pic , resize upsample 2X, it cost 14255ms!, i test the same pic use opencv4.3 resize function with Lanczos method, is just cost 1598ms!,  so  can you optimize your LancIR method? my betst regards!

by the way , i test  on ARM A53 cpu

I think ARM is not very good at memory-intensive operations. I cannot optimize LancIR. OpenCV probably uses videocard features.


Extract Cabal-Helper specific code into its own library

Talking with @jneira on irc, we realized this makes it easier to share code between the projects hie, hls and, potentially, ghcide!
Code would be entirely taken from Cradle.hs in hie-plugin-api and the entire logic of discovering cradles with cabal-helper would be moved into its own library.
Opinions?

I've just discovered that Haskell.IDe.Engine.Cradle only imports Haskell.Ide.Engine.Logger!
Almost it is asking to live in its own home. 😄

In case we decided to creae the library, what about implicit-hie-bios (or hie-bios-implicit or something alike), to not bind it to cabal-helper.
Maybe some day both build tools stack and cabal gives us enough info to use them directly?

I really like the abstraction boundary that hie-bios figures out what the flags for the session should be. If it became a plugin API that I could then configure I'd be much less happy, as it's something I'm super grateful to not have to care about. Whether it incorporates or includes cabal-helper like functionality under the hood is a detail, so if this is transparent, I'm fine with it.

I would not have considered it a plugin API, but I think I see what you mean.
The intention would have been to extract code from Haskell.IDe.Engine.Cradle since only roughly six functions are used elsewhere in haskell-ide-engine, none of them specific to cabal-helper.
I think one can argue that this micro-package would be nothing else but moved code for now.
Do you dislike the idea to have an independent package for cabal-helper to hie-bios cradle conversion? Does that already count as a plugin API?

Is the cabal-helper to hie-bios cradle something ghcide has to mix in? I don't like that idea. Or something that hie-bios always links in? If so, I don't see the advantage of separating the package.

No, currently only hie uses it and hls currently copied the code to https://github.com/haskell/haskell-language-server/blob/master/src/Ide/Cradle.hs
It is an alternative implementation to using the implicitCradle function. It is optional and would not affect ghcide at all, unless ghcide decides to use cabal-helper as well.

I think hls and ghcide should converge on this as much as possible.

Absolutely agreed. I think, somewhere it was mentioned that you agreed in bristol to use cabal-helper? Should there be an attempt to use cabal-helper in ghcide?

@ndmitchell just in case it would be solvable, what are your concerns about link statically cabal-helper in ghcide? is it that it depends on the Cabal library or another problematic lib? or the runtime compilation it triggers?
If hls uses cabal helper directly it will need to pass the cradle generated by c-h to ghcide (the component that actually is using it directly). Not sure if ithat is already possible in ghcide or it should be changed to accept "external" cradles.
Obviously if we add support in ghcide both would have the implicit cradle available. Imo it would be the desirable option over the former one.
Other options i can think of:

discover another, more lightweight way to generate a reliable implicit cradle
make hie-bios use cabal-helper at runtime (i.e. calling c-h as a executable), creating another cradle type (implicit?). Not sure it is possible

I've heard cabal-helper takes a lot of work to support. At the moment, if there's an issue with the GHC flags, I go to hie-bios because the contract is hie-bios provides the flags to start a GHC session. I like the abstract interface "give me the flags" and the support model "ping Matthew et al". It's as much lines of communication and separation of responsibilities as it is code. If you guys want to shove cabal-helper behind the same interface and support model, provided there is no GPL impact, I'm happy (and moreover, consider it none of my business).

That is exactly how we integrated cabal-helper. It is hidden within a Cradle and you just query it, like any other cradle. Granted, the mechanism is not as light-weight as the implicit cradle discovery in hie-bios, but we have no extra logic in hie to support cabal-helper.
That's why usage of cabal-helper is completely isolated in this one module.

FYI https://github.com/haskell/haskell-language-server/blob/master/src/Ide/Cradle.hs

Which should end up wherever we agree

Well i think the consesus had been using the cabal-helper cradle in haskell-language-server, cause cradle setup is in the main exe module owned by h-l-s: https://github.com/haskell/haskell-language-server/issues/38#issuecomment-582789371
@fendor could we close this or you have some concerns about?

I still think outsourcing it into different package does no harm and makes it easier to support both hls and hie.
As I read it, there was no argument against it?

@fendor no other than the usual overhead of maintain a separate lib: github repo, maybe upload to hackage/stackage, etc and the fact hie will be deprecated at some point.
Otoh it could be used in another projects.
If you are fine setting up the new package i am too :wink:

Other option could be integrate the cabal-helper cradle in cabal-helper itself, if @DanielG agree it is a good idea add hie-bios as dependency.

I think, for now I would prefer it as a separate library. I feel like it does not really belong into cabal-helper. However, lets wait for @DanielG opinion :)


min: Add version 1.24.0

Closes #8354

[x] I have read the Contributing Guide.

/verify

If an app does not natively store data in its own directory, we shouldn't try to force persistence. (The chrome manifests are an exception to this because of backward compatibility).
Storing data in AppData is fine.

This is exactly how it's done in ungoogled-chromium, and Min is basically chromium.

(The older chrome manifests are an exception to this because of backward compatibility)

/verify

Removed persistence, the app now stores its data in AppData.


feat: FR-1932 - added captcha for login/sign up; removed unused compo…

…nents demosaas

@AntonReact
see request changes


Some DEMs do not have enough stable terrain for coreg

For example, in the RU_FJL case, many DEMs have very few points. One should set a minimum pixel count for including the DEMs.
How should this value be set?

I also came across something similar,  "/nobackupp11/sbhusha1/sw/shashank_ragmac_xdem/ragmac_xdem/src/xdem/xdem/coreg.py", line 192, in get_horizontal_shift raise ValueError("Less than 10 different cells exist."). I agree with David's suggestion and should be simple to implement this functionality as something similar for block division should have been set for blockwise coregistration in xdem as well.
Once we have that, we should have a valueerror try except block in this function and pass over that DEM when running in parallel and produce modified output stats and output paths for the failed case.


Feature/add lint and tests

Finally add tests! will close #18 .
Also added lint for the src and tests, not the example files.

Hey @goatslacker was wondering if we could setup travis-ci on this repo with the introduction of these tests? Sent you a twitter message about it. Let me know.
Going to merge this soon and would like future PR's to get auto tested :)


Test for in-memory run construction and lookups

Roundtrip test for the in-memory parts: construct a run incrementally from key/value/blob data, then perform lookups on the resulting run (using in-memory raw pages, not actual on-disk pages).

Example test output:
lsm-tree
  Test.Database.LSMTree.Internal.Integration
    {- elided -}
    prop_inMemRunLookupAndConstruction: OK (0.64s)
      +++ OK, passed 100 tests; 2 discarded.

      Lookup classification: post intra-page lookup (1192 in total):
      74.83% TruePositive
      25.17% TrueNegative

      Lookup classification: pre intra-page lookup (1192 in total):
      74.83% TruePositive
      23.57% TrueNegative
       1.59% FalsePositive

      Number of key-entry pairs (100 in total):
      59% 10 < n < 100
      33% 1 < n < 10
       8% n == 1

      Number of pages (100 in total):
      54% 10 < n < 100
      46% 1 < n < 10

      PageSpan distribution (911 in total):
      91.9% n == 1
       4.4% 10 < n < 100
       3.7% 1 < n < 10

      Size of key in run (1804 in total):
      76.39% 10 < n < 100
      23.61% 1 < n < 10

      Size of value in run (1804 in total):
      44.84% 10 < n < 100
      27.11% 1 < n < 10
      14.25% n == 0
       6.76% 10000 < n < 100000
       5.49% n == 1
       1.16% 1000 < n < 10000
       0.39% 100 < n < 1000

All 3 tests passed (5.65s)

"Lookup classification: pre intra-page lookup" records the number of true/false positive/negative results after running prepLookups, i.e., bloom filter queries and index searches. At this point, we can have some false positives from the bloom filter queries, but never false negatives. "Lookup classification: post intra-page lookup" shows the same type of results after doing the actual intra-page lookups. At this point, we're only expecting true positives and true negatives.
We are expecting a false-positive rate of no higher than 10%, but here it is showing ~1%. This is because we're creating a bloom filter using safeSuggestSizing, which still rounds the total number of bits in the filter to the next power of two, reducing the false-positive rate. When we start using more precise tuning, this FPR should be closer to ~10%.

We'll want to rebase on top of #105 and #101, using the new rawPageLookup.


fix make be conf disable_storage_page_cache modifiable

Proposed changes
Issue Number: close #xxx

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall


Notebook reorganization

Addressing issues #24 #25
I also documented error messages (mostly minor) I came across while running through the various notebooks, which we can go over and assign at a later date.
@ahdilmore @cguccione @antgonza

@kfogelso, if I understand this correctly, the goal of this PR is to move files around and add testing data. The first is easy to see but I'm a bit confused about the second: it seems like there is not huge difference between the action running time between your PR and previous ones, which to me it means there are no new tests being run with the test data. However, it seems like there is a slight increment in coverage; could you clarify this?
Thank you.

@antgonza from what I understand, for #25 @ElDeveloper wanted me to run cell by cell through every notebook and document if/where I'm getting errors, as well as if/where there are test data/test outputs missing. Since last running through the notebooks, it looks like some of this issues I was seeing previously have been addressed. However, I identified one needed test_data file not on the repo (in metagenomics_repooling notebook ./finrisk_data/complete_dataframes/FinRisk_5-8_back-compiled_dummy.txt). Was planning on talking through minor error messages w/ @cguccione and @ahdilmore at a later point to see if it these are thing that can be quickly addressed.
Does this answer your question?

It does, thank you for the explanation.

Forgot to add, then I think it seems fine but I think it will be better if we wait for @ElDeveloper feedback.

@ElDeveloper, friendly ping about this.

Thank you everyone. Just for the record: @kfogelso and I met and addressed @ElDeveloper comments so I think is fine to merge.


Custimazation of Marbles for asset transfer

Is there any guide available to customize the marbles code?
I have successfully installed marbles on my local machine and its working smoothly. Thanks to IBM code developers and on line community who posted solutions to so many small small problems.
Now I need to go ahead and allow user to enroll using its secret pass phrase or finger print and allow them to add assets and transfer it to anyone they want.
Can anyone please help me?
Thanks
rGhorpade

Not really. Assuming you read this description on how marbles was built.  If you understand that section and are proficient with node.js you would be able to customize it.

closing - inactivity


Convert minutes to hours

Description
Write a program to convert minutes to hours
1 hour = 60 minutes
Input  : 300
Output : 5

Tracking Issues

[ ] Write a C program to convert minutes to hours
[ ] Write a C# program to convert minutes to hours
[ ] Write a C++ program to convert minutes to hours
[ ] Write a Dart program to convert minutes to hours
[ ] Write a F# program to convert minutes to hours
[ ] Write a GO program to convert minutes to hours
[ ] Write a Haskell program to convert minutes to hours
[ ] Write a Java program to convert minutes to hours
[ ] Write a JavaScript program to convert minutes to hours
[ ] Write a Julia program to convert minutes to hours
[ ] Write a Kotlin program to convert minutes to hours
[ ] Write a Perl program to convert minutes to hours
[ ] Write a PHP program to convert minutes to hours
[ ] Write a Python program to convert minutes to hours
[ ] Write a R program to convert minutes to hours
[ ] Write a Ruby program to convert minutes to hours
[ ] Write a Rust program to convert minutes to hours
[ ] Write a Scala program to convert minutes to hours
[ ] Write a Swift program to convert minutes to hours
[ ] Write a TypeScript program to convert minutes to hours

lol

hey @harshraj8843 can you assign me
Write a C++ program to convert minutes to hours
Write a JavaScript program to convert minutes to hours


Manually move a "current round" into "past round"

I think it could be a good feature (not particularly important though) since it happened that some rounds stayed for a bit longer even after the round was over, i.e. January 2022 - I know it should be move into past round when all maps are moved into Loved (or not) but I think having a control over it could be better imo

it's intentional that they stay "current" until everything is resolved, looks like January has one map that still isn't loved even tho it passed voting--- asked about it on discord

closing cuz it does seem like a one-off issue that intentionally has this display on site


Trivially Relocatable

A minor thought that the usual definition is "valid but undefined state". So it's legal to do anything you /want/ with the object but the only operations that will have a known outcome are assignment and destruction.

Legal but very hard to know if it's okay is kinda what I want to say, I am more focused on the understanding of the code vs legality via the spec in this case. I will def include the valid but undefined, thanks, it helps to connect it in peoples minds if theyve seen that before too.

(Not sure if it's worth mentioning auto_ptr here at all, which I think was generally regarded as behaving in a surprising way due to its ownership transfer upon assignment)

Thanks! Totally worth it I forgot (or didn't know??) this existed. I added some commentary.

This last sentence feels a bit incomplete. This is in contrast to the above snippet referencing trivially movable + destructible, since those traits embed "is" and the condition is clear. I feel like the condition in relocatable_tag::value(0) is not immediately clear.

Yeah, I agree. "So T is relocate_by_memcpy if the author has explcitly declared it to be so, which is found through the relocatable_tag helper:" should do better

"an S* that is actually a T"? Or maybe it'd be clearer to memcpy(&t, &a, size of(&s))?

"into an S* that is pointing to a T subclass".. I think, thanks.

This makes me wonder about object slicing though… maybe this will be answered later.

Slicing would be copying out of the type and dropping the subclass. This would be a way of setting the fields of the base class.
Nonetheless I agree it's a bit sketchy on a base class :) But still want to point out where memcpy with sizeof() gives you memory safety bugs. Maybe I should call it that..

I'm not quite sure what "only present in one of the two" means.

Well i meant that they won't both have a T data member, but they could but don't in my example but okay let me try harder.

It might be nice to phrase this positively instead of negatively, e.g. "However, this is something that can only be determined by manually reading the implementation; the compiler cannot directly determine this based on the types of its fields."

Yeah, thanks!


err-first-miss broken: no longer exits after miss

We should add a test for this. It doesn't seem to exit properly for non-detected files in scan or analyze mode:
go run ./cmd/mal --err-first-miss scan /bin/*
🔎 Scanning "/bin/["
🔎 Scanning "/bin/ab"
🔎 Scanning "/bin/aconnect"
🔎 Scanning "/bin/activate-global-python-argcomplete"
🔎 Scanning "/bin/addr2line"
🔎 Scanning "/bin/adwaita-1-demo"
├─ 🟠 /usr/bin/adwaita-1-demo
│     • c2/addr/ip — hardcoded IP address:
│     137.634.24.969, 17.29.371.563, 29.371.563.593, 306.137.634.24, 336.298.674.582, 445.228.872.406
🔎 Scanning "/bin/airscan-discover"
🔎 Scanning "/bin/alias"

I suspected --err-first-hit is similarly broken, but it's broken differently:
% go run ./cmd/mal --min-risk=medium --err-first-hit analyze ../malcontent-samples/python/
🔎 Scanning "../malcontent-samples/python/"
time=2024-11-04T07:56:01.384-05:00 level=ERROR source=/var/home/t/src/malcontent/pkg/action/scan.go:338 msg="error with processing 16 matching capabilities in ../malcontent-samples/python/2021.DiscordSafety/DiscordSafety-0.1.tar.gz archive: anti-static/obfuscation/python/rename_imports anti-static/unmarshal/marshal c2/addr/php collect/databases/leveldb exec/program exec/remote_commands/code_eval exfil/stealer/browser fs/path/users impact/remote_access/py_setuptools net/url/request\n"

I don't quite understand the error, but the hit result was never shown. If I specify a subdir, it just exits quietly:
% go run ./cmd/mal --min-risk=medium --err-first-hit analyze ../malcontent-samples/python/2024.yocolor/
🔎 Scanning "../malcontent-samples/python/2024.yocolor/"


Add a diagram

Adding a diagram to illustrate the over all picture of this walk through and how these pieces fit together would be very helpful.
[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 1895941d-fa70-08ea-53c4-c49a65300625
Version Independent ID: c41d9420-3dc5-5c49-8135-d208ee13bc14
Content: Quickstart - Create a Private Link service - Azure portal - Azure Private Link
Content Source: articles/private-link/create-private-link-service-portal.md
Service: private-link
GitHub Login: @abell
Microsoft Alias: abell

Ignore

Ognore.

Ignore.

@gary-RR
Glad to know issue got resolved. If there are further questions regarding this topic, please do let us know and we will gladly continue the discussion.