CLDemo still requires InfoUtil

Environment

LWJGL version: 3.2.0
LWJGL build #: ?
Java version: openjdk 10.0.2 2018-07-17
Platform: Arch Linux
Module: opencl

Description

According to #263, the class InfoUtil has been removed in LWJGL 3. However, the demo class CLDemo still references it (a lot). Apparently, InfoUtil still exists in a test package for some reason (https://github.com/LWJGL/lwjgl3/blob/master/modules/lwjgl/opencl/src/test/java/org/lwjgl/opencl/InfoUtil.java), but I expect from a demo class to be able to copy-paste it into my project for testing without problems. However this won't work since it will be missing that specific class.

So what do you expect the maintainer to do?
Why don't you simply copy the InfoUtil class to your project?

Sorry, I thought that you meant the included tests when you said "demos".


Property isAbstract Getting Ignored in Provisioning of Older MDXML Models

Discovered when converting older MDXML models to Papyrus UML. The abstract property does not come out in the provisioning model XML.


Edit index.jsp to include our team name and info

Nit: "Edit" in the description doesn't add a ton to it: "Adds team name and info to index.jsp" is more concise and jumps right in to what changes.


Flaky test test_quantization_mkldnn.test_requantize_int32_to_int8

Example Failure
http://jenkins.mxnet-ci.amazon-ml.com/blue/organizations/jenkins/incubator-mxnet/detail/master/1175/pipeline
Output
FAIL: test_quantization_mkldnn.test_requantize_int32_to_int8
Traceback (most recent call last):
File "/usr/local/lib/python3.5/dist-packages/nose/case.py", line 198, in runTest
self.test(*self.arg)
File "/usr/local/lib/python3.5/dist-packages/nose/util.py", line 620, in newfunc
return func(*arg, **kw)
File "/work/mxnet/tests/python/mkl/../unittest/common.py", line 157, in test_new
orig_test(*args, **kwargs)
File "/work/mxnet/tests/python/mkl/../quantization/test_quantization.py", line 127, in test_requantize_int32_to_int8
check_requantize((3, 4, 10, 10))
File "/work/mxnet/tests/python/mkl/../quantization/test_quantization.py", line 123, in check_requantize
assert_almost_equal(qdata_int8.asnumpy(), qdata_int8_np)
File "/work/mxnet/python/mxnet/test_utils.py", line 493, in assert_almost_equal
raise AssertionError(msg)
AssertionError:
Items are not equal:
Error 1562.500000 exceeds tolerance rtol=0.000010, atol=0.000000.  Location of maximum error:(0, 3, 8, 0), a=-63.000000, b=-64.000000
a: array([[[[ -72,  106,   79, ...,   73,  -43,  126],
[ -74, -118,  -46, ...,  -18,   44,  -37],
[   0,   13,  -93, ..., -117, -123,  -56],...
b: array([[[[ -72,  106,   79, ...,   73,  -43,  126],
[ -74, -118,  -46, ...,  -18,   44,  -37],
[   0,   13,  -93, ..., -117, -123,  -56],...
-------------------- >> begin captured logging << --------------------
common: INFO: Setting test np/mx/python random seeds, use MXNET_TEST_SEED=2054829694 to reproduce.
--------------------- >> end captured logging << ---------------------

Thannks for filing this issue. We will investigate this Flaky test

Cannot reproduce locally. By the way, why just python3 fail?

@xinyu-intel: This is a rarely occurring non-deterministic failure, so the fact it happens in python3 as opposed to python2, (or any other language) is probably just a coincidence.

Hi,
please run the following commands:
ci/build.py -p ubuntu_cpu -i
PYTHONPATH=/work/mxnet/python python3 tools/flakiness_checker.py -s<PHONE_NUMBER> test_quantization_mkldnn.test_requantize_int32_to_int8
The output will be:

INFO:root:Testing: /work/mxnet/tests/python/mkl/test_quantization_mkldnn.py:test_requantize_int32_to_int8
INFO:root:No test seed provided, using random seed
test_quantization_mkldnn.test_requantize_int32_to_int8 ... [INFO] 351 of 10000: Setting test np/mx/python random seeds, use MXNET_TEST_SEED=2127644814 to reproduce.
FAIL

======================================================================
FAIL: test_quantization_mkldnn.test_requantize_int32_to_int8
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/local/lib/python3.5/dist-packages/nose/case.py", line 198, in runTest
    self.test(*self.arg)
  File "/usr/local/lib/python3.5/dist-packages/nose/util.py", line 620, in newfunc
    return func(*arg, **kw)
  File "/work/mxnet/tests/python/mkl/../quantization/common.py", line 172, in test_new
    orig_test(*args, **kwargs)
  File "/work/mxnet/tests/python/mkl/../quantization/test_quantization.py", line 127, in test_requantize_int32_to_int8
    check_requantize((3, 4, 10, 10))
  File "/work/mxnet/tests/python/mkl/../quantization/test_quantization.py", line 123, in check_requantize
    assert_almost_equal(qdata_int8.asnumpy(), qdata_int8_np)
  File "/work/mxnet/python/mxnet/test_utils.py", line 493, in assert_almost_equal
    raise AssertionError(msg)
AssertionError:
Items are not equal:
Error 1562.500000 exceeds tolerance rtol=0.000010, atol=0.000000.  Location of maximum error:(1, 3, 1, 7), a=-63.000000, b=-64.000000
 a: array([[[[-119,   61,  -58, ...,    8,  123,   10],
         [  97,   79,   11, ...,   37, -106,  -13],
         [  82,   53, -125, ...,  104,   90,  112],...
 b: array([[[[-119,   61,  -58, ...,    8,  123,   10],
         [  97,   79,   11, ...,   37, -106,  -13],
         [  82,   53, -125, ...,  104,   90,  112],...
-------------------- >> begin captured logging << --------------------
common: INFO: 351 of 10000: Setting test np/mx/python random seeds, use MXNET_TEST_SEED=2127644814 to reproduce.
--------------------- >> end captured logging << ---------------------

@pengzhao-intel @xinyu-intel

sorry, I missed this one previously.
@xinyu-intel will keep looking the issue.

@KellenSunderland @marcoabreu @reminisce Hi, I think we should set the absolute error to one ULP. When we check whether the int8 data are equal, we should set the absolute error to 1.
In this case, we convert int32 data to float32 data and then convert to int8 data. In the last step (np.sign(data) * np.minimum(np.abs(data) * scale + 0.5, quantized_range)).astype('int8') plus 0.5 to realize rounded up will bring one ULP truncated error.
For example, MKLDNN float 63.4999 will not be round up to 64 after plus 0.5 but Numpy float 63.5000 will. The absolute error of float32 1e-4 will be expand to 1 after converted to int8.
I'll start a pr to fix it.

Great, thanks a lot @xinyu-intel !

https://github.com/apache/incubator-mxnet/pull/12040

#16692 unrelated PR
http://jenkins.mxnet-ci.amazon-ml.com/blue/organizations/jenkins/mxnet-validation%2Funix-cpu/detail/PR-16692/1/pipeline
======================================================================

FAIL: test_quantization.test_requantize_int32_to_int8

----------------------------------------------------------------------

Traceback (most recent call last):

  File "/usr/local/lib/python2.7/dist-packages/nose/case.py", line 197, in runTest

    self.test(*self.arg)

  File "/work/mxnet/tests/python/quantization/common.py", line 177, in test_new

    orig_test(*args, **kwargs)

  File "/work/mxnet/tests/python/quantization/test_quantization.py", line 186, in test_requantize_int32_to_int8

    check_requantize_with_symbol((3, 4, 10, 10))

  File "/work/mxnet/tests/python/quantization/test_quantization.py", line 181, in check_requantize_with_symbol

    assert_almost_equal(qdata_int8.asnumpy(), qdata_int8_np)

  File "/work/mxnet/python/mxnet/test_utils.py", line 627, in assert_almost_equal

    raise AssertionError(msg)

AssertionError:

Items are not equal:

Error 1562.500000 exceeds tolerance rtol=1.000000e-05, atol=1.000000e-20 (mismatch 0.166667%).

Location of maximum error: (0, 2, 3, 4), a=-63.00000000, b=-64.00000000

 ACTUAL: array([[[[ -98,  -25,  -99, ...,  -93,   -8,   37],

         [  94,  -57,  -94, ...,  -84,   83,   60],

         [ -47,  112,   95, ...,  107, -112,    4],...

 DESIRED: array([[[[ -98,  -25,  -99, ...,  -93,   -8,   37],

         [  94,  -57,  -94, ...,  -84,   83,   60],

         [ -47,  112,   95, ...,  107, -112,    4],...

-------------------- >> begin captured stdout << ---------------------

*** Maximum errors for vector of size 1200:  rtol=1e-05, atol=1e-20

  1: Error 1562.500000  Location of error: (0, 2, 3, 4), a=-63.00000000, b=-64.00000000

  2: Error 1562.500000  Location of error: (2, 2, 0, 2), a=63.00000000, b=64.00000000

@xinyu-intel please take a look for flaky test.

Still flaky. For unrelated PR #17993
Log : http://jenkins.mxnet-ci.amazon-ml.com/blue/organizations/jenkins/mxnet-validation%2Funix-cpu/detail/PR-17993/7/pipeline/300

Hi, @ChaiBapchya. Perhaps #16709 was not backported to the 1.6.x branch. Would you mind confirming that? If so, I think we need to backport the patch to 1.6.x as well along with #17993.

Backported that patch. Thanks for pointing it out. Weird how it didn't get selected in the previous cherry-picks.


STG71 Features - New Force Close Handles header: x-ms-number-of-handles-failed

The force close handle operation on file and directory  now return a new filed: numberOfHandlesFailedToClose.
TODO:

[ ] ChangeLog

Why PR includes blob code changes too?
@XiaoningLiu
All features are based on the swagger-generation branch, which includes swagger changes both in file and blob. I have submitted separate PR for the swagger generation, but it is still subject to change.
You probably only need to review the last commit which includes all changes except the swagger generated code.


Switch CI from bors to merge queue

Context: https://rust-lang.zulipchat.com/#narrow/channel/242791-t-infra/topic/Reducing.20the.20amount.20of.20repos.20that.20use.20bors.2Fhomu
This should be merged with cooperation from an infra-admin.
Opening this mainly for discussions! It's up to the Cargo team whether you want to switch or not.

r? @ehuss


Missing PayloadChecksumKind variant for vpc-lattice-svcs

Describe the feature
The PayloadChecksumKind enum in aws-sigv4 only supports two variants at the moment: XAmzSha256 and NoHeader.
However, making SigV4 requests for VPC Lattice services requre to set the x-amz-content-sha256 header with a value UNSIGNED-PAYLOAD.
Documentation: https://docs.aws.amazon.com/vpc-lattice/latest/ug/sigv4-authenticated-requests.html
Use Case
This would enable support for SigV4 for VPC Lattice.
Proposed Solution
Add a new variant to PayloadChecksumKind that will inject an UNSIGNED-PAYLOAD value, and modify the rest of aws-sigv4 to use this information.
Other Information
No response
Acknowledgements

[X] I may be able to implement this feature request
[ ] This feature might incur a breaking change

A note for the community

Community Note

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue, please leave a comment

After diving into the code, it looks like we could already do this, but not with the PayloadChecksumKind enum.
I'll let you fine folks decide if you see an opportunity to improve the SDK itself. Also happy to contribute with an example for this specific use-case. 😄

Thanks for submitting this @nmoutschen.
To whomever picks up https://github.com/awslabs/smithy-rs/issues/1798, they should also take a look at implementing this too, since it touches the same code in the signer.

As @nmoutschen notes you can do this by using SignableBody::UnsignedPayload when you invoke the SigV4 crate.


Empty List Using Indefinite Encoding

Summary
When constructing an empty PlutusList, calling toCbor serialises it with indefinite encoding, which is not canonical and can cause problems with scripts, particularly the serialise builtin.
Steps to reproduce the bug
console.log((new PlutusList()).toCbor())
console.log(PlutusList.fromCbor(HexBlob("80")).toCbor())

Actual Result
9fff
9fff

Which is the encoding for an indefinite list
Expected Result
80
80

Which is the encoding for a definite list
SDK version
0.30.2
Environment type

[X] Node.js
[ ] Browser
[ ] Browser Extension
[ ] Other

Environment details
No response

Thanks for the bug report @EzePze, I opened a PR with the fix here https://github.com/input-output-hk/cardano-js-sdk/pull/1319, should be fixed in the next version of the SDK

@EzePze we just published version 0.33.0 of the @cardano-sdk/core which should have this fixed, give it a try and let us know

It seems that the issue was not properly fixed, see https://github.com/input-output-hk/cardano-js-sdk/pull/1319#issuecomment-2151584168 . Is being addressed in this PR https://github.com/input-output-hk/cardano-js-sdk/pull/1322

You can try the latest release 0.33.1, that should have this fixed :)


Add examples / documentation for the state_view:create command

This has been updated as of v0.0.8


Update the OCI image spec used for packaging ebpf bytecode

Package both el/eb variants of BPF bytecode in an eBPF OCI image
Determine if there's any existing OCI specific infrastructure that can help us here
It would be great if this worked the same way as multi-arch manifests (i.e we have a meta manifest that points to the actual image manifests for the correct os/arch)

Addressed with #1141


AD overview page

@lisawong19,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs-ref-mapping/reference.yml
:white_check_mark:Succeeded

docs-ref-services/activedirectory.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


python program to check weather a number is strong number or not

Strong Numbers are the numbers whose sum of factorial of digits is equal to the original number.

#164

the code was already merged


RNPdfScanner was not found in the UIManager

I followed exact same steps given in ReadMe file.
The build is successful, but when I open component that contains DocumentScanner code, gets below error on the application.

Can someone please help on this or give direction?
CC: @Michaelvilleneuve

how did you install this library I'm unable to install this ?

Seeing this too. Any luck so far?

Same, any fix? 👀

Also getting this error

Also getting this error

I am facing same...

I have resolved this error.
Try these steps 🚶
1- yarn add package-name
2- cd ios
3- pod install
4 - pod update
3- close and re-run the app on the phone 📱


how to see  establishing clients?

how to list connetcting clients and how to see every read/write operation log which no found start with --debug flag? thx！

gRPC should expose some debugging info about this when enabled.


Change color of h1 to red

Pull Request Type
What kind of change does this PR introduce?
[ ] Solved an issue/task
[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:
What is the current behavior?

Issue Number: [Insert Issue Number (if applicable)]
What is the new behavior?

Other information

Pull Request to merge changes to the original repository

Merged

This is an automated message from Fork, Commit, Merge [BOT].

Thank you for your contribution! Your pull request has been merged. The files have been reset for the next contributor.
What's next?
If you're looking for more ways to contribute, I invite you to check out our forkcommitmerge.io website repository. The repository contain real issues that you can help to resolve or create some of your own if you see any bugs or want to add new features to the site, etc. You can also check out the Influences section in the README to find more projects similar to this one.
Also please leave a star to this project if you feel it helped you, i would really appreciate it.
I look forward to seeing your contributions!


import setUpRandomResolver only for new Twisted

twisted.internet._resolver was introduced only in Twitter 17.1 (released on 11 Feb 2017).
I do not want to raise required Twisted version for a minor carbon update, so, this PR just making setUpRandomResolver import optional, because it's using only if DESTINATIONS_POOL_REPLICAS enabled (not by default).
Fixing issue #805.
/cc @iksaif @ybizeul

OTOH it can be simplified to
in lib/carbon/client.py
if settings.DESTINATION_POOL_REPLICAS:
  from carbon.resolver import setUpRandomResolver
else:
    setUpRandomResolver = None

and later
if setUpRandomResolver:
          setUpRandomResolver(reactor)

But in case of old Twisted it will produce error as in #805 and you'll need process exception there. I'm preferring explicit way instead.

Can I get more reviews for this, pretty please? I want to release 1.1.4 tonight. :)
/cc @piotr1212 @DanCech @iksaif
Thanks a lot!

Sorry I'm out for a week, I'll trust you on that. Thanks !
Le lun. 3 sept. 2018 à 15:39, Denis Zhdanov<EMAIL_ADDRESS>a
écrit :

Can I get more reviews for this, pretty please? I want to release 1.1.4
tonight. :)
/cc @piotr1212 https://github.com/piotr1212 @DanCech
https://github.com/DanCech @iksaif https://github.com/iksaif
Thanks a lot!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/graphite-project/carbon/pull/806#issuecomment-418118520,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA_DAwCVLbpXMNklKvy3V2MB5B6EJnUeks5uXTEXgaJpZM4WWNzo
.


Cores have some wonky dry weights - fix

For now, the code sets each core's mass values to the median.
printlog("Temporarily setting core dry weights to be invariant")
valvemap %>%
  group_by(Site, SampleID) %>%
  mutate(Soil_dry_weight_equivalent_g = median(Soil_dry_weight_equivalent_g)) ->
  valvemap

We think this is corrected, but it would be good to go back and spot-check later.


Extend tsconfig in cosmos, identity from base config

This PR updates the tsconfig file in the cosmos and identity packages to extend from the base file as the first step towards #5276
The next step would be to update the code to allow the strict checks that have now been disabled

The next step would be to update the code to allow the strict checks that have now been disabled

Should we file a separate issue to track this so it doesn't get lost?

Should we file a separate issue to track this so it doesn't get lost?

Yes, I plan to do that right after this PR is merged

Alright, here goes:
#11435
#11436
#11437
#11438
#11439
#11440


testing time

I ran the code you posted on github and found that the time of training for a epoch takes about half a minute but the testing takes about half a hour(The command is “python exe_physio.py --testmissingratio 0.1 --nsample 100”). May I ask if this is in line with the actual situation.

Hi, sorry for the late reply.
Yes, it's working correctly.
Our code is not fast at test time. To accelerate the speed, You can combine CSDI with methods which speed up diffusion models.

Hi, Tashiro,
Thanks for your reply. We have already finished the comparison experiment and report as it was described in the paper.
Wenbo
tldr: our recent work is deep ensembles method combined with quantile regression. it is faster than the generative models, such as the diffusion models.
Deep Ensembles Meets Quantile Regression: Uncertainty-aware Imputation for Time Series.
Ying Liu+, Peng Cui+, Wenbo Hu, Richang Hong
https://arxiv.org/abs/2312.01294


fix(endpoints): do not reset organization's secrets when an endpoint is created or updated

Closes #19081
This PR fixes the endpoint service so that it does not rest all secrets when a notification endpoint is created or updated. The code that uses SecretService.PutSecrets deletes all existing secrets, these calls in a notification service were replaced by PatchSecrets.

[ ] CHANGELOG.md updated with a link to the PR (not the Issue)
[ ] Well-formatted commit messages
[ ] Rebased/mergeable
[ ] Tests pass
[ ] Signed CLA (if not already signed)

There is a good test that explains the semantics of PutSecrets. It would IMHO even better to rename the SecretService's PutSecrets method to ResetSecrets to clearly indicate that all existing secrets are deleted and the new are set.  I can offer this refactoring upon reviewer's request, it might be opinionated.
I guess that every code that now uses PutSecrets is suspicious to do the same mistake. I found also https://github.com/influxdata/influxdb/blob/88cdf43db13326007fed0d775888687d6f4e5c24/pkger/service.go#L2424-L2426
It should probably use PatchSecrets, @jsteenb2 ?

@glinton .. a test was added herein to demonstrate the correct behavior


Exception when attempting to deserialize POCO using Json.NET

Great work on this project! I've been having a play with Blazor recently and run into a hitch when trying to use it in conjunction with Json.NET. I know that the cause behind this could manifest anywhere between Blazor, Json.NET and the WASM bits so I apologise in advance if this isn't ultimately the right place to raise it. I won't be offended if you tell me to take this to another repo :)
Title
Exception when attempting to deserialize POCO using Json.NET
Functional impact
Per title
Minimal repro steps

Create a new Blazor project using the ASP.NET Core Project wizard in Visual Studio 2017 Preview
Install-Package Newtonsoft.Json
Replace OnInitAsync in the FetchData component with below:

protected override async Task OnInitAsync()
{
    var emptyJson = "{ }";
    var json = "{ \"Summary\" : \"Value\" }";

    // all working
    Console.WriteLine($"JObject - {JsonConvert.DeserializeObject<JObject>(json)}");
    Console.WriteLine($"ExpandoObject - {JsonConvert.DeserializeObject<ExpandoObject>(json)}");
    Console.WriteLine($"Dictionary<string, object> - {JsonConvert.DeserializeObject<Dictionary<string, object>>(json)}");

    // no setter called, no problem
    Console.WriteLine($"POCO, no setters called - {JsonConvert.DeserializeObject<WeatherForecast>(emptyJson)}");

    // boom
    Console.WriteLine($"POCO, setter called - {JsonConvert.DeserializeObject<WeatherForecast>(json)}");
}

Launch the project and navigate to Fetch data page
Open console to see output

Expected result
All five calls succeed and display the .ToString() representation of the deserialized objects.
Actual result
4/5 calls succeed and exception is raised for the last.
Further technical details
It seems that POCOs fail to deserialize, specifically when a set operation is called, with the below output:
WASM: [Newtonsoft.Json.JsonSerializationException] Error setting value to 'Summary' on 'WebApplication5.Pages.FetchData+WeatherForecast'. ---> System.NullReferenceException: Object reference not set to an instance of an object.
WASM: at Newtonsoft.Json.Serialization.ExpressionValueProvider.SetValue (System.Object target, System.Object value) <0x1cf1220 + 0x00086> in <d32db49e5e3440729da31845c03ddc3a>:0
WASM: at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.SetPropertyValue (Newtonsoft.Json.Serialization.JsonProperty property, Newtonsoft.Json.JsonConverter propertyConverter, Newtonsoft.Json.Serialization.JsonContainerContract containerContract, Newtonsoft.Json.Serialization.JsonProperty containerProperty, Newtonsoft.Json.JsonReader reader, System.Object target) <0x1cf0508 + 0x00158> in <d32db49e5e3440729da31845c03ddc3a>:0
WASM: at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.PopulateObject (System.Object newObject, Newtonsoft.Json.JsonReader reader, Newtonsoft.Json.Serialization.JsonObjectContract contract, Newtonsoft.Json.Serialization.JsonProperty member, System.String id) <0x1ce7cb8 + 0x003e8> in <d32db49e5e3440729da31845c03ddc3a>:0
WASM: at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.CreateObject (Newtonsoft.Json.JsonReader reader, System.Type objectType, Newtonsoft.Json.Serialization.JsonContract contract, Newtonsoft.Json.Serialization.JsonProperty member, Newtonsoft.Json.Serialization.JsonContainerContract containerContract, Newtonsoft.Json.Serialization.JsonProperty containerMember, System.Object existingValue) <0x1c3d5b8 + 0x0029c> in <d32db49e5e3440729da31845c03ddc3a>:0
WASM: at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.CreateValueInternal (Newtonsoft.Json.JsonReader reader, System.Type objectType, Newtonsoft.Json.Serialization.JsonContract contract, Newtonsoft.Json.Serialization.JsonProperty member, Newtonsoft.Json.Serialization.JsonContainerContract containerContract, Newtonsoft.Json.Serialization.JsonProperty containerMember, System.Object existingValue) <0x1b9c508 + 0x000ca> in <d32db49e5e3440729da31845c03ddc3a>:0
WASM: at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.Deserialize (Newtonsoft.Json.JsonReader reader, System.Type objectType, System.Boolean checkAdditionalContent) <0x19646a0 + 0x001a6> in <d32db49e5e3440729da31845c03ddc3a>:0
WASM: at Newtonsoft.Json.JsonSerializer.DeserializeInternal (Newtonsoft.Json.JsonReader reader, System.Type objectType) <0x195ca10 + 0x000ac> in <d32db49e5e3440729da31845c03ddc3a>:0
WASM: at Newtonsoft.Json.JsonSerializer.Deserialize (Newtonsoft.Json.JsonReader reader, System.Type objectType) <0x195c330 + 0x0001c> in <d32db49e5e3440729da31845c03ddc3a>:0
WASM: at Newtonsoft.Json.JsonConvert.DeserializeObject (System.String value, System.Type type, Newtonsoft.Json.JsonSerializerSettings settings) <0x19269d0 + 0x00060> in <d32db49e5e3440729da31845c03ddc3a>:0
WASM: at Newtonsoft.Json.JsonConvert.DeserializeObject[T] (System.String value, Newtonsoft.Json.JsonSerializerSettings settings) <0x1cb3b20 + 0x00020> in <d32db49e5e3440729da31845c03ddc3a>:0
WASM: at Newtonsoft.Json.JsonConvert.DeserializeObject[T] (System.String value) <0x1cb3ae8 + 0x0000a> in <d32db49e5e3440729da31845c03ddc3a>:0
WASM: at WebApplication5.Pages.FetchData+<OnInitAsync>d__2.MoveNext () <0x1925bd8 + 0x00096> in <2cb2c533ff6b4424901e788f72648786>:0

I have also seen a more detailed stacktrace which I happen to have a screenshot of:

Versions
Microsoft.AspNetCore.Razor.Design 2.1.0-preview2-30230
Microsoft.AspNetCore.Blazor.Browser 0.1.0
Microsoft.AspNetCore.Blazor.Build 0.1.0
Newtonsoft.Json 11.0.2
netcore 2.1.300-preview1-008174
Visual Studio Enterprise 2017 Preview (15.7.0 Preview 2.0)

One limitation that we have right now is that there isn't a good way for a library to know at runtime that it's running in mono on wasm.
My guess from the call stack is that there is a problem with the code that JSON.NET is using to generate compiled expressions, which it uses for property getters/setters. I'm not sure what the long term solution to this will be.

@kumpera Is this an expected limitation with compiled expressions?

Closing as there isn't 'anything we can do about this on the Blazor side, but we will follow up with the Mono folks.

https://github.com/mono/mono/issues/7839

Turns out the issues we've had with Json.NET are with our linker configuration. If you want to use Json.NET in a Blazor app you should be able to get it to work by using the following linker configuration: https://gist.github.com/Suchiman/a5e65f40c353120c9cf7f6a631ded28b.

Using the above worked for me, thanks 👏

@danroth27 Adding the linker doesn't seem to work for me. I'm getting the following error:
Error	MSB3073
The command "dotnet "C:\Users\Mitchell\.nuget\packages\microsoft.aspnetcore.blazor.build\0.5.1\targets\../tools/illink/illink.dll" -l none -c link -u link -b true -t --verbose  -d "C:\Users\Mitchell\.nuget\packages\microsoft.aspnetcore.blazor.build\0.5.1\targets\../tools/mono/bcl/" -d "C:\Users\Mitchell\.nuget\packages\microsoft.aspnetcore.blazor.build\0.5.1\targets\../tools/mono/bcl/Facades/" -o "D:\Documents\BlazorLinker\BlazorLinker\obj\Debug\netstandard2.0\blazor/linker/" -x "D:\Documents\BlazorLinker\BlazorLinker\Linker.xml" -a "C:\Users\Mitchell\.nuget\packages\microsoft.aspnetcore.blazor\0.5.1\lib\netstandard2.0\Microsoft.AspNetCore.Blazor.dll" -a "C:\Users\Mitchell\.nuget\packages\microsoft.aspnetcore.blazor.browser\0.5.1\lib\netstandard2.0\Microsoft.AspNetCore.Blazor.Browser.dll" -a "C:\Users\Mitchell\.nuget\packages\microsoft.extensions.dependencyinjection\2.1.0\lib\netstandard2.0\Microsoft.Extensions.DependencyInjection.dll" -a "C:\Users\Mitchell\.nuget\packages\microsoft.extensions.dependencyinjection.abstractions\2.1.0\lib\netstandard2.0\Microsoft.Extensions.DependencyInjection.Abstractions.dll" -a "C:\Users\Mitchell\.nuget\packages\microsoft.jsinterop\0.5.1\lib\netstandard2.0\Microsoft.JSInterop.dll" -a "C:\Users\Mitchell\.nuget\packages\mono.webassembly.interop\0.5.1\lib\netstandard2.0\Mono.WebAssembly.Interop.dll" -a "C:\Program Files\dotnet\sdk\NuGetFallbackFolder\newtonsoft.json\11.0.2\lib\netstandard2.0\Newtonsoft.Json.dll" -a "D:\Documents\BlazorLinker\BlazorLinker\obj\Debug\netstandard2.0\BlazorLinker.dll"" exited with code 1.	BlazorLinker	C:\Users\Mitchell\.nuget\packages\microsoft.aspnetcore.blazor.build\0.5.1\targets\Blazor.MonoRuntime.targets	441

I'm using Blazor 0.5.1, though I was also getting the error with 0.4.0.
Clean, Rebuild and restarting Visual Studio don't have any effect.'
Source code: https://github.com/MitchellEnsink/BlazorLinker
Steps to reproduce:

Create new Blazor 0.5.1 project (non-hosted variant)
Add the linker.xml file you provided to project
Copy the contents of the .csproj you provided into the existing .csproj, but change the Blazor version numbers to 0.5.1

My setup:
OS: Windows 10 Home version 1803 build 17134.165
.NET Core version 2.1.302
Visual Studio Community 2017 version 15.7.5
ASP.NET Core Blazor Language Services version 15.7.10384

@MitchellEnsink Yeah, I've also seen some issues using Json.NET with the latest Blazor bits even when using the linker config @Suchiman put together. Can you try disabling linking on build completely by adding the <BlazorLinkOnBuild>False</BlazorLinkOnBuild> MSBuild property and see if that addresses the issue?

@marek-safar we could use some guidance on how to configure the IL linker so that libraries like Json.NET "just work". Are there changes that @JamesNK could make to Json.NET to facilitate this?

@danroth27 Please follow documentation we have at https://docs.microsoft.com/en-us/xamarin/ios/deploy-test/linker?tabs=vsmac it applies to wasm as well

Thanks @marek-safar! This documentation is very helpful for understanding how you can configure the IL linker. But I think it still leaves a lot for library authors to figure out to make their libraries work well with IL linking. I think what's needed is guidance for library authors that walks through the process of taking an existing library that wasn't originally designed for IL linking and then determining which parts need to be explicitly preserved. This guidance would enable library authors to methodically update their libraries to support IL linking instead of playing whack-a-mole with linker related issues.


Create the ToggleInfo.js sub-component for DiagnosticContainer.js

Task
Use the mockup in the design directory to create a component that toggles between Symptoms.js and Temperature.js, called ToggleInfo.js.
This will be a sub-component of DiagnosticContainer.js as per design/wireframes/CORONATRACKER UI-#17
What done looks like:
Add comments to explain code.
We have a ToggleInfo.js component in /components.
We have a ToggleInfo.css file in /css to style the ToggleInfo.js sub-component.
Design considerations:
We have decided to use regular CSS files to keep things simple for now. This allows for more contributors and less time to upskill to contribute.
Once MVP is done the team can discuss if we want to transition it to styled-components or something like CSS modules.
Folder paths
CSS is located in /client/src/css
Components are located in /client/src/components
Style guide for CSS files:
Naming convention:
Component -> ToggleInfo.js.
CSS file -> ToggleInfo.css
To avoid naming collisions:
prefix class names with the name of component and link with kebab case.
Class name -> .ToggleInfo-header { ... }
How to handle state:
If you can use redux, use it.
Create action and reducer with an appropriate name.
Testing:
No need to worry about testing for now.
If you choose to add tests, please place in client/src/tests

guys, here's something i've been working on, but not familiar with Redux. So, don't know what needs to be modified to change diagnostic container state from temperature to symptoms. i'll probably need to pair program with someone on adding that. will try to do pull request in next hour https://repl.it/@jm5/CoronaTrackerDiagnosticContainer-toggleinfojs

Is this still being worked on, or does it need to be closed?

Still being worked on. Realistically, I can't get back to it until Friday. At this point, could probably take the code that @Tanvez created for the Facts/Quiz cards with toggle button and just refactor.  If you need it sooner, please reassign.

I'd say keep chugging along with this then! We definitely need it for V2 but not necessarily for the alpha release we want out by Friday 👍

@johnemurphy1 How is this going? Are you far enough where I could do #334 ?

@SomeMoosery @tesla809 tried rebase. same results. I'm going to clone and create a new branch.

Hey @Afrogrrrl . This is done and PR merged!


'default' is not a valid name when adding an account to config...

Found this while working on #48 :
https://docs.python.org/2/library/configparser.html#ConfigParser.RawConfigParser.add_section

That basically means you can have only one default section. Is this a problem ?
 I got
ERROR: AzureConfigAddAccountSectionError: 'ValueError: Invalid section name: default'

If I use another section name which also exists I got
ERROR: AzureConfigAddAccountSectionError: "DuplicateSectionError: Section 'sharetest' already exists"

So I think we are good if catch the ValueError on default and provide a better error message
Thoughts ?

Please explain how you would write the section named 'default' into the config file, for example, in the case of a new user.

[default]
storage_account_name =
storage_container_name =
publishsettings =

[james]
storage_account_name =
storage_container_name =
publishsettings =

[marcus]
storage_account_name =
storage_container_name =
publishsettings =

I'm sure I'm missing the point ?

The point is, you cannot produce that '[default]' section using azurectl setup account --name=default ....

ok got it, will look into this today


feature(frontend): adding instrumentation metrics

Changes
This PR adds a set of changes to support instrumentation metrics from the frontend (server side), it also upgrades the open telemetry dependencies to the latest version.
Merge Requirements
For new features contributions please make sure you have completed the following
essential items:

[ ] CHANGELOG.md updated to document new feature additions
[ ] Appropriate documentation updates in the docs folder

Maintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.

please resolve the conflicts first. @xoscar

Hey @pichlermarc if you get a chance would you mind giving this a quick review?

Hey @xoscar can you clean this up? I think we're mostly ready

Hey @cartersocha @puckpuck this one should be ready for its final review

Hey @austinlparker what docs update would you like to be added? or just the change log update?

The feature matrix for metrics needs to be updated, right?

@xoscar would you have some time to take a look at this?
We would love to have that PR merged to do release 1.3.0.

Hey @julianocosta89 how are you trying to build the image? I did it using docker compose build frontend --no-cache and it worked.
@austinlparker I wonder if I should update the doc matrix, the current state of it seems to be quite outdated.

@puckpuck / @open-telemetry/demo-approvers everything addressed? Im on mobile until tonight but I think I see everything resolved

I will test this all end-end in a few hours, and report back.

Thanks @puckpuck ping me on slack when it's good


ASP.NET Core Setup

Is there a full documentation for ASP.Net Core setup?

@matigarowel  Maybe this help: https://github.com/phnx47/dapper-repositories#example-with-aspnet-core-and-di

Thanks a lot for your response I already tried based on documentation. I only have error for "DbFactory", what library would I install in nuget? There are suggestion by visual studio and still an error.

DbFactory - it is your own implementation, not a library.
Alternatives

Register IDapperDbContext from here
Register IDbConnection as Transient, and your repositories based  on DapperRepository<TEntity> as Transient


bzip2 un-downloadable - bzip.org domain expired

It appears as though the bzip.org domain has expired. Until the owner renews it, attempting to download + build bzip2 with vcpkg will fail. This affects many ports (through the dependency tree).
I've mirrored things here: https://github.com/past-due/bzip2-mirror/releases/tag/v1.0.6
@ras0219-msft, @alexkaratarakis:
Is that sufficient for now, or is there a better place we can get the bzip2-1.0.6.tar.gz mirrored for vcpkg?

Fix is in master; thanks again!
This is sufficient for now, though it of course indicates that we need to find a way to solve this on a grander scale :)


'done' is always true starting from first step in MARL env

Hi,
I'm trying to use the MARL env, and here is my code, which is copied from the document, I printed the done and it's true every step, that's really weird to me, can anyone help with this issue? Thanks a lot for your time!
CLASS_NAME = 'tollgate'
from metadrive import (
MultiAgentMetaDrive,
MultiAgentTollgateEnv,
MultiAgentBottleneckEnv,
MultiAgentIntersectionEnv,
MultiAgentRoundaboutEnv,
MultiAgentParkingLotEnv
)
envs_classes = dict(
roundabout=MultiAgentRoundaboutEnv,
intersection=MultiAgentIntersectionEnv,
tollgate=MultiAgentTollgateEnv,
bottleneck=MultiAgentBottleneckEnv,
parkinglot=MultiAgentParkingLotEnv,
pgma=MultiAgentMetaDrive
)
env = envs_classesCLASS_NAME
for i in range(1000):
obs, reward, done, info = env.step(env.action_space.sample())  # Use random policy
#print(env.action_space.sample())
if i%100 == 0:
print(reward)
#env.render()
if done:
print(i)
print('done')
env.reset()
env.close()

well, I think done here is a dict containing the termination status of all agents. You should query the status for each agent via their id like agent0. For getting a global termination status, check done["__all__"] instead

Hi Quanyi,
Thanks for your reply! I just found out that done is a dict for all agents. I have a following question, as the default length is 1000 in MARL env, after 1000 steps, the vehicles that arrive earlier at their destination will terminate and the vehicles that haven't arrived will keep running, is that correct? Also, I noticed that lots of projects, like Copo, use RLlib to train the MARL algorithm, are there any repos directly train the MARL on Metadrive without using RLlib?

Hi, Zhenghao@pengzhenghao, could you help with it?

as the default length is 1000 in MARL env, after 1000 steps, the vehicles that arrive earlier at their destination will terminate and the vehicles that haven't arrived will keep running, is that correct?

No. After 1000 steps, the environment stop respawning new vehicles. But the existing vehicles are still alive and will be terminated if their own horizons are reached.
There are 3 config to control this behavior:
config["max_step_per_agent”] Default to 1000. means the maximum number of the steps of each agent.
config[“horizon”] Default to 1000. is the maximum length of the episode. If allow respawn, then this is the maximum step that respawn can happen. After that, the episode won't terminate until all existing vehicles reach their horizon or done.
config[“allow_respawn”]  Default to True.

I noticed that lots of projects, like Copo, use RLlib to train the MARL algorithm, are there any repos directly train the MARL on Metadrive without using RLlib?

MA-RLLib support MetaDrive.
Best,
Zhenghao

On Mar 13, 2023, at 4:57 PM, jiw18020 @.***> wrote:
Hi Quanyi,
Thanks for your reply! I just found out that done is a dict for all agents. I have a following question, as the default length is 1000 in MARL env, after 1000 steps, the vehicles that arrive earlier at their destination will terminate and the vehicles that haven't arrived will keep running, is that correct? Also, I noticed that lots of projects, like Copo, use RLlib to train the MARL algorithm, are there any repos directly train the MARL on Metadrive without using RLlib?
—
Reply to this email directly, view it on GitHub https://github.com/metadriverse/metadrive/issues/332#issuecomment-1467135247, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFJNUE2E3PRZSH6R763NOZTW36X6DANCNFSM6AAAAAAVZW6NO4.
You are receiving this because you are subscribed to this thread.

Hi Zhenghao,
Thanks for the reply!


YouTube ExtractorError

Please forgive me if this is a duplicate; there are quite a few open issues but searching for "unable to extract html5" yielded some that were close (like #4835, who was trying to set cookies manually).
% youtube-dl --verbose https://www.youtube.com/watch?v=pXRviuL6vMY
[debug] System config: []
[debug] User config: []
[debug] Command-line args: ['--verbose', 'https://www.youtube.com/watch?v=pXRviuL6vMY']
[debug] Encodings: locale UTF-8, fs utf-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2015.10.16
[debug] Python version 3.4.3 - Linux-3.13.0-43-generic-x86_64-with-Ubuntu-14.04-trusty
[debug] exe versions: avconv 9.18-6, avprobe 9.18-6, rtmpdump 2.4
[debug] Proxy map: {}
[youtube] pXRviuL6vMY: Downloading webpage
[youtube] pXRviuL6vMY: Downloading video info webpage
[youtube] pXRviuL6vMY: Extracting video information
WARNING: unable to extract html5 player; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.or
g/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
[youtube] {22} signature length 43.40, html5 player None
ERROR: Signature extraction failed: Traceback (most recent call last):
  File "/usr/local/lib/python3.4/dist-packages/youtube_dl/extractor/youtube.py", line 771, in _decrypt_signature
    video_id, player_url, s
  File "/usr/local/lib/python3.4/dist-packages/youtube_dl/extractor/youtube.py", line 663, in _extract_signature_function
    raise ExtractorError('Cannot identify player %r' % player_url)
youtube_dl.utils.ExtractorError: Cannot identify player 'https://s.ytimg.com/yts/jsbin/player-en_US-vflCIicNM/base.js'; please report this issue on https://yt
-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
 (caused by ExtractorError("Cannot identify player 'https://s.ytimg.com/yts/jsbin/player-en_US-vflCIicNM/base.js'; please report this issue on https://yt-dl.o
rg/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.",)); please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Traceback (most recent call last):
  File "/usr/local/lib/python3.4/dist-packages/youtube_dl/extractor/youtube.py", line 771, in _decrypt_signature
    video_id, player_url, s
  File "/usr/local/lib/python3.4/dist-packages/youtube_dl/extractor/youtube.py", line 663, in _extract_signature_function
    raise ExtractorError('Cannot identify player %r' % player_url)
youtube_dl.utils.ExtractorError: Cannot identify player 'https://s.ytimg.com/yts/jsbin/player-en_US-vflCIicNM/base.js'; please report this issue on https://yt
-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag
and include its complete output.

I'll try to debug it myself a bit tonight.

You are using an outdated version of youtube-dl. See our FAQ if you need help updating.

@phihag thanks  and sorry about that. I actually had done:
sudo apt-get remove youtube-dl
pip install -U youtube-dl

but apparently I had installed it originally with Python 3 using pip3, so I was upgrading the wrong installation.


Fix everything about lists

They are half-broken and tacked-on as an afterthought.

the list attribute should have a PagingEnabled bool property. sets a property like "public override ushort Category { get; } = 1;" called PagingEnabled to that value on the generated class

the out declartion for lists should be changed to entry and re-add out to be what it is traditionally so we can return other values along with the list

also add a way to name a built in type for the list instead of generating one via entry/out. something like [List(Class = int)] will just pass int to the base class generic type and not generated a class. Maybe add BuiltIn = true to signal whether or not we need to generate a class named by the Class property.

Desired C# for a method returning scalar and list data:
 [MessageDefinition(ServerId = ServerId.Planet, AuthenticationRequired = true)]
 public partial class GetBuildings : ListQueryMessageHandler<Objects.Database.Context, GetBuildings.ObjectId> {
     public override ushort Category { get; } = 3;
     public override ushort Method { get; } = 2;

     [MessageInput(Index = GetBuildings.InputStartIndex + 0)]
     [ObjectId]
     public long CityId { get; set; }

     [MessageOutput(Index = GetBuildings.OutputStartIndex + 0)]
     public long Count { get; set; }

     public class ObjectId {
         [MessageOutput(Index = 0)]
         public long Id { get; set; }

     }
 }


Owning strings

PR to make AppInfo a trait and have different structures with different ownership semantics for it.  Resolves issue #19
I still think there should be some way to use Cow to make this simpler, but it's less ergonomic.  Oh well.

If ergonomics for Cow are a blocker, do you think it could be fixed with a new method like this?
pub fn new<'a, U, A>(name: U, author: T)
where
    U: Into<Cow<'a, str>>,
    A: Into<Cow<'a, str>>,
{
    AppInfo { name: name.into(), author: author.into() }
}

The pattern of accepting Into<Cow<str>> is one I've used a lot when I want to accept both String and &'static str in the same method.
What would you think of using that to make it simpler?

@daboross That does actually look pretty cool, I didn't think of that.


Update Package Error

The plugin flashy_tab_bar uses a deprecated version of the Android embedding.
To avoid unexpected runtime failures, or future build failures, try to see if this plugin supports the Android V2 embedding. Otherwise, consider removing it since a future release of Flutter will remove these deprecated APIs.
If you are plugin author, take a look at the docs for migrating the plugin to the V2 embedding: https://flutter.dev/go/android-plugin-migration.
error when I updated Flutter with last version. Can you update package ?

i

i am facing the same issue.On SDKs over 30 the tab bar is no longer being displayed.


pretty printing bound variables

Bound variables are being pretty printed as «#».«0».
Repro:
import Lean
new_frontend
open Lean

def test : MetaM Unit :=
trace! `Meta.debug (mkBVar 0)

set_option trace.Meta.debug true in
#eval test

produces
[Meta.debug] «#».«0»

Not the most aesthetically pleasing representation, I agree :smile: .


[Request] Please move to publishing semver releases

Buttons Relation
n/a
Bug Description
n/a
Expected Result
n/a
Additional Information
I really like this project, but it would be so much better if you started publishing releases. As it stands I'm forced to lock my update automations to the container digest, which changes on every push.
Images
No response

See https://github.com/techno-tim/littlelink-server/issues/76

This was discussed in the above issue.  I totally understand why I should use semver but at the same time, pinning to SHA gives you the same result as pinning to a container tag and also the same amount of work on your part.  Curious if I am missing an edge case?

You're an absolutely right, I'm also pinning to the sha hash and it works. Renovate picks up any updates to the image. I guess it's really an issue on my part. I'm for now updating my cluster manually, and because your automation is building a new image on every push, I'm updating this quite often. I guess I hoping that moving to releases would mean a less frequent update cycle.
I understand I should probably just get my act together and implement fluxcd or something similar.

Ha!  No worries at all, and yes, you are right, even if I did move to semver I would still release it on ever commit to main.  I don't like sitting on releases and I have CI that tests quite a bit so that I can release with confidence!


Create AES128 and AES256 encryption for parameters

Encrypt just before putting into the db
Decrypt only right before invoking the action

Description
This will encrypt the default params for actions and packages at rest in the DB.
Currently implemented AES128 and 256 encryption, although 256 needs some work regarding packaging.
Related issue and scope
My changes affect the following components

[ ] API
[X] Controller
[ ] Message Bus (e.g., Kafka)
[ ] Loadbalancer
[X] Invoker
[ ] Intrinsic actions (e.g., sequences, conductors)
[ ] Data stores (e.g., CouchDB)
[ ] Tests
[ ] Deployment
[ ] CLI
[ ] General tooling
[ ] Documentation

Types of changes

[ ] Bug fix (generally a non-breaking change which closes an issue).
[X] Enhancement or new feature (adds new functionality).
[ ] Breaking change (a bug fix or enhancement which changes existing behavior).

Checklist:

[X] I signed an Apache CLA.
[X] I reviewed the style guides and followed the recommendations (Travis CI will check :).
[X] I added tests to cover my changes.
[X] My changes require further changes to the documentation.
[ ] I updated the documentation where necessary.

Can I get a WIP tag on this PR?

Codecov Report

Merging #4756 into master will decrease coverage by 6.43%.
The diff coverage is 88.98%.

@@            Coverage Diff             @@
##           master    #4756      +/-   ##
==========================================
- Coverage    85.1%   78.67%   -6.44%
==========================================
  Files         190      198       +8
  Lines        8578     8941     +363
  Branches      601      617      +16
==========================================
- Hits         7300     7034     -266
- Misses       1278     1907     +629

Impacted Files
Coverage Δ

...rg/apache/openwhisk/core/entity/WhiskPackage.scala
96.82% <100%> (+0.05%)
:arrow_up:

...org/apache/openwhisk/core/entity/WhiskAction.scala
91.25% <100%> (ø)
:arrow_up:

.../openwhisk/core/containerpool/ContainerProxy.scala
92.05% <100%> (+0.07%)
:arrow_up:

.../scala/org/apache/openwhisk/core/WhiskConfig.scala
94.81% <100%> (+0.03%)
:arrow_up:

...a/org/apache/openwhisk/core/entity/Parameter.scala
88.29% <84.48%> (-2.27%)
:arrow_down:

...he/openwhisk/core/entity/ParameterEncryption.scala
92.3% <92.3%> (ø)

...core/database/cosmosdb/RxObservableImplicits.scala
0% <0%> (-100%)
:arrow_down:

...enwhisk/connector/kafka/KamonMetricsReporter.scala
0% <0%> (-100%)
:arrow_down:

...e/database/cosmosdb/cache/ChangeFeedConsumer.scala
0% <0%> (-100%)
:arrow_down:

...ore/database/cosmosdb/cache/CacheInvalidator.scala
0% <0%> (-100%)
:arrow_down:

... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9e4c10...a94b2a8. Read the comment docs.

WIP can be removed from this it seems ready to go.

Not sure why travis isn't updating this but the build is green for this:  https://travis-ci.org/apache/openwhisk/builds/646477660
@rabbah is this okay to get merged?

Thanks for the nudge. Will review the newest commits.

No worries we have this running now on our prod cluster now so it's at least working.

@mcdan I'm going through this PR again - sorry for the delay. I've resolved the conflict locally and will push that to your branch when I'm done. I have a few other code suggestions I'll make as I go through the code.
I want to confirm some of my understanding:

when parameter encryption is turned on, the parameters on action update and package update are encrypted using the current scheme.
when an action or package is retrieved, the parameters are not decoded

Is that correct? If so, did you omit triggers on purpose?

@mcdan my review edits https://github.com/apache/openwhisk/commit/2a7c55a57294061051381a7ec0a4579c8547e0e5
These are intended to be semantic preserving and were helpful to me in understanding the code. I can send you a PR for these patches or open a PR post merge to implement these.

Codecov Report
Attention: Patch coverage is 90.62500% with 12 lines in your changes missing coverage. Please review.

Project coverage is 76.13%. Comparing base (e12c5de) to head (aa0f85a).
Report is 345 commits behind head on master.

Files with missing lines
Patch %
Lines

...a/org/apache/openwhisk/core/entity/Parameter.scala
85.48%
9 Missing :warning:

...he/openwhisk/core/entity/ParameterEncryption.scala
94.82%
3 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4756      +/-   ##
==========================================
- Coverage   82.20%   76.13%   -6.07%
==========================================
  Files         199      200       +1
  Lines        9169     9277     +108
  Branches      374      376       +2
==========================================
- Hits         7537     7063     -474
- Misses       1632     2214     +582

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Use Central Configuration to get/configure/update TanzuPlatform endpoints and implement Fallback algorithm to find service endpoints

What this PR does / why we need it

Tanzu CLI updates to account for Tanzu Platform Endpoint changes
Uses Central Configuration to get TanzuPlatform endpoints
Implements Fallback algorithm to find the service endpoints if configuration is not found in central config
Support configuring service endpoints with TANZU_CLI_K8S_OPS_ENDPOINT, TANZU_CLI_HUB_ENDPOINT and TANZU_CLI_UCP_ENDPOINT environment variables
Support endpoint updates/migration in user's local tanzu configuration file for existing context using central configuration

Implementation Details
Tanzu-Platform Endpoint and Service Endpoint

Get the default Tanzu Platform Endpoint from Central Config (cli.core.tanzu_default_endpoint: <default-value>)
Get the list of SaaS endpoints from Central Config

cli.core.tanzu_cli_platform_saas_endpoints_as_regular_expression:
    - https://(www.)?platform(.)*.tanzu.broadcom.com
    - https://api.tanzu(.)*.cloud.vmware.com

Get the tanzu platform endpoint to service endpoint mapping from Central Config.

cli.core.tanzu_endpoint_map:
    https://api.tanzu.cloud.vmware.com:
        ucp: https://api.tanzu.cloud.vmware.com
        tmc: https://tmc.tanzu.cloud.vmware.com
        hub: https://api.mgmt.cloud.vmware.com

If the tanzu-platform endpoint mapping is not found in the above map, CLI will use fallback algorithm to find service endpoints

Existing Context Updates when Endpoint gets updated

CLI will use Central Configuration to keep track when the endpoint migration happens. It will rely on following configuration and if the value of the key is non-empty, it means endpoint updates needs to be conducted by the CLI for existing contexts unless it has been done already.

cli.core.tanzu_cli_config_endpoint_update_version: v1

CLI will use following mapping to update the endpoints in the user's existing contexts:

cli.core.tanzu_cli_config_endpoint_update_mapping:
    https://api.tanzu.cloud.vmware.com: https://ucp.platform.tanzu.broadcom.com
    https://tmc.tanzu.cloud.vmware.com: https://ops.platform.tanzu.broadcom.com
    https://api.mgmt.cloud.vmware.com:  https://api.platform.tanzu.broadcom.com

Once the endpoint updates are completed, the update version will be stored in the datastore and the updates will not be carried out again unless there is newer version of update available through central configuration.

Which issue(s) this PR fixes

Fixes #
Describe testing done for PR
Login and Context Creation Tests:

Manually update the local central configuration file to include below configuration to test the CentralConfig changes:

$ cat ~/.cache/tanzu/plugin_inventory/default/central_config.yaml
...
cli.core.tanzu_default_endpoint: https://api.tanzu.cloud.vmware.com
cli.core.tanzu_endpoint_map:
    https://api.tanzu.cloud.vmware.com:
        ucp: https://api.tanzu.cloud.vmware.com
        tmc: https://tmc.tanzu.cloud.vmware.com
        hub: https://api.mgmt.cloud.vmware.com
    https://api.tanzu-stable.cloud.vmware.com:
        ucp: https://api.tanzu-stable.cloud.vmware.com
        tmc: https://tmc.tanzu-stable.cloud.vmware.com
        hub: https://api.staging-tis.symphony-dev.com
    https://api.tanzu-dev.cloud.vmware.com:
        ucp: https://api.tanzu-dev.cloud.vmware.com
        tmc: https://tmc.tanzu-dev.cloud.vmware.com
        hub: https://api.be-tis.symphony-dev.com
cli.core.tanzu_cli_platform_saas_endpoints_as_regular_expression:
    - https://(www.)?platform(.)*.tanzu.broadcom.com
    - https://api.tanzu(.)*.cloud.vmware.com
cli.core.tanzu_cli_config_endpoint_update_version: v1
cli.core.tanzu_cli_config_endpoint_update_mapping:
    https://api.tanzu.cloud.vmware.com: https://ucp.platform.tanzu.broadcom.com
    https://tmc.tanzu.cloud.vmware.com: https://ops.platform.tanzu.broadcom.com
    https://api.mgmt.cloud.vmware.com:  https://api.platform.tanzu.broadcom.com

Login using the https://api.tanzu-dev.cloud.vmware.com endpoint

$ export TANZU_CLI_USE_TANZU_CLOUD_SERVICE_PROVIDER=true
$ tz login --staging --endpoint https://api.tanzu-dev.cloud.vmware.com
...
[ok] Successfully logged into 'Falcons' organization and created a tanzu context 'Falcons-staging-d03c5c97'
---
$ tz context get Falcons-staging-d03c5c97 | grep ndpoint
    endpoint: https://api.tanzu-dev.cloud.vmware.com
    endpoint: https://api.tanzu-dev.cloud.vmware.com/org/57d622c9-b797-4287-b41c-1c2de24471e6
    tanzuHubEndpoint: https://api.be-tis.symphony-dev.com/hub
    tanzuMissionControlEndpoint: https://tmc.tanzu-dev.cloud.vmware.com

Login using the https://platform-verify.tanzu.broadcom.com endpoint

$ tz login --staging --endpoint https://platform-verify.tanzu.broadcom.com
...
[ok] Successfully logged into 'Falcons' organization and created a tanzu context 'Falcons-staging-3fb994fb'
---
$ tz context get Falcons-staging-3fb994fb | grep ndpoint
    endpoint: https://ucp.platform-verify.tanzu.broadcom.com
    endpoint: https://ucp.platform-verify.tanzu.broadcom.com/org/57d622c9-b797-4287-b41c-1c2de24471e6
    tanzuHubEndpoint: https://api.platform-verify.tanzu.broadcom.com/hub
    tanzuMissionControlEndpoint: https://ops.platform-verify.tanzu.broadcom.com

Login using the current default endpoint (as per the central configuration which is https://api.tanzu.cloud.vmware.com)

$ tz login --staging
...
[ok] Successfully logged into 'Falcons' organization and created a tanzu context 'Falcons-staging'
---
$ tz context get Falcons-staging | grep ndpoint
    endpoint: https://api.tanzu.cloud.vmware.com
    endpoint: https://api.tanzu.cloud.vmware.com/org/57d622c9-b797-4287-b41c-1c2de24471e6
    tanzuHubEndpoint: https://api.mgmt.cloud.vmware.com/hub
    tanzuMissionControlEndpoint: https://tmc.tanzu.cloud.vmware.com

Manual update the central configuration to use default endpoint as https://platform.tanzu.broadcom.com to simulate future default and run tanzu login

$ tz login --staging
...
[ok] Successfully logged into 'Falcons' organization and created a tanzu context 'Falcons-staging'
---
$ tz context get Falcons-staging | grep ndpoint
    endpoint: https://ucp.platform.tanzu.broadcom.com
    endpoint: https://ucp.platform.tanzu.broadcom.com/org/57d622c9-b797-4287-b41c-1c2de24471e6
    tanzuHubEndpoint: https://api.platform.tanzu.broadcom.com/hub
    tanzuMissionControlEndpoint: https://ops.platform.tanzu.broadcom.com

Use environment variable to point Hub endpoint to custom endpoint

$ TANZU_CLI_HUB_ENDPOINT=https://custom.hub.endpoint.tanzu.broadcom.com tz login --staging --endpoint https://platform-dev.tanzu.broadcom.com
...
[ok] Successfully logged into 'Falcons' organization and created a tanzu context 'Falcons-staging-5a2f0150'
---
$ tz context get Falcons-staging-5a2f0150 | grep ndpoint
    endpoint: https://ucp.platform-dev.tanzu.broadcom.com
    endpoint: https://ucp.platform-dev.tanzu.broadcom.com/org/57d622c9-b797-4287-b41c-1c2de24471e6
    tanzuHubEndpoint: https://custom.hub.endpoint.tanzu.broadcom.com/hub
    tanzuMissionControlEndpoint: https://ops.platform-dev.tanzu.broadcom.com

Use environment variable for Hub,UCP,TMC all 3 endpoints to use custom endpoint

TANZU_CLI_UCP_ENDPOINT=https://custom.ucp.endpoint.tanzu.broadcom.com TANZU_CLI_HUB_ENDPOINT=https://custom.hub.endpoint.tanzu.broadcom.com TANZU_CLI_K8S_OPS_ENDPOINT=https://custom.ops.endpoint.tanzu.broadcom.com tz login --staging --endpoint https://platform-dev.tanzu.broadcom.com
...
[ok] Successfully logged into 'Falcons' organization and created a tanzu context 'Falcons-staging-2fe92931'
---

$ tz context get Falcons-staging-2fe92931 | grep ndpoint
    endpoint: https://custom.ucp.endpoint.tanzu.broadcom.com
    endpoint: https://custom.ucp.endpoint.tanzu.broadcom.com/org/57d622c9-b797-4287-b41c-1c2de24471e6
    tanzuHubEndpoint: https://custom.hub.endpoint.tanzu.broadcom.com/hub
    tanzuMissionControlEndpoint: https://custom.ops.endpoint.tanzu.broadcom.com

Existing context update tests on endpoint migration:

Current user's central configuration does not have cli.core.tanzu_cli_config_endpoint_update_version information. User login to tanzu context with old endpoint.

$ tz login --staging

$ tz context get Falcons-staging | grep ndpoint
    endpoint: https://api.tanzu.cloud.vmware.com
    endpoint: https://api.tanzu.cloud.vmware.com/org/57d622c9-b797-4287-b41c-1c2de24471e6
    tanzuHubEndpoint: https://api.mgmt.cloud.vmware.com/hub
    tanzuMissionControlEndpoint: https://tmc.tanzu.cloud.vmware.com

Manually update the central configuration file to include endpoint update details and mapping as follows

cli.core.tanzu_cli_config_endpoint_update_version: v1
cli.core.tanzu_cli_config_endpoint_update_mapping:
    https://api.tanzu.cloud.vmware.com: https://ucp.platform.tanzu.broadcom.com
    https://tmc.tanzu.cloud.vmware.com: https://ops.platform.tanzu.broadcom.com
    https://api.mgmt.cloud.vmware.com:  https://api.platform.tanzu.broadcom.com

Run any CLI command after the local central configuration file is updated, this should trigger the endpoint updates.

$ tz context list
[i] The CLI contexts have been updated to use the new Tanzu Platform Endpoints.
  NAME                                      ISACTIVE  TYPE   PROJECT       SPACE
  Falcons-staging                           true      tanzu

[i] Use '--wide' to view additional columns.

Verify the endpoints are updated in the existing context according to the update map in central config

$ tz context get Falcons-staging | grep ndpoint
    endpoint: https://ucp.platform.tanzu.broadcom.com
    endpoint: https://ucp.platform.tanzu.broadcom.com/org/57d622c9-b797-4287-b41c-1c2de24471e6
    tanzuHubEndpoint: https://api.platform.tanzu.broadcom.com/hub
    tanzuMissionControlEndpoint: https://ops.platform.tanzu.broadcom.com

Release note

Use Central Configuration to get/configure/update Tanzu Platform endpoints and implement Fallback algorithm to find service endpoints

Additional information
Special notes for your reviewer

lgtm, thanks!


User specific recent activity feed

Describe the feature you'd like

A user should be able to observe shelves/books/pages (like marking a page as favorite)

The page level would be the most relevant of those three

A user should have the option "Activity Feed" in his user menu

This could also be a tile in the "My Profile" view

A counter should appear inside the profile logo. The counter shows the number of new (not seen) activities.
A activity is marked as "seen", when the use visits the feed page.
Update or create events should be listed in the feed. Each item should link to the affected shelve/page/book

De facto this is only a user defined subset of the recent activity feed

Describe the benefits this feature would bring to BookStack users
This would be a way for a user to keep track of recent changes in a self-defined way.
A user gets all information about the relevant changes, without the need for scanning through the recent activity view. In a very active BookStack app, the relevant changes are filled very quickly.
Use Case:
This feature is a benefit, when there are different working groups that overlap only in a subset of pages that are relevant to them.

Hi @ssddanbrown ,
I totally forgot about comment. This watch feature should also include notifications about comments. I think comments are great, but they are hard to follow, this would improve their use.

I would love the idea of being notified of a change in a page (maybe a dedicated area in the profile that will list the notifications?).
BTW Great job on the overall BookStack app.


Could not refresh tokens - Error 401

Hi,
When we try to use the library in just Laravel it works fine, but when we implement it in Queue's (async) after a couple of requests the library loses the refresh token.
Do you have any idea to fix this? The queue is configured to only run one task at a time to prevent tokens from being lost.

Yeah, there's a long on-going discussion in this regard here https://github.com/picqer/exact-php-client/issues/385
I've implemented a similar locking in #3, however there seems to be some improvements in that area on the Picqer package, so will have another look at it
(I'm running into the same issues)

Yeah, there's a long on-going discussion in this regard here https://github.com/picqer/exact-php-client/issues/385
I've implemented a similar locking in #3, however there seems to be some improvements in that area on the Picqer package, so will have another look at it
(I'm running into the same issues)

Have pushed a new v0.5.0-beta.1 release that applies the principle that's discussed here https://github.com/picqer/exact-php-client/issues/385 and https://github.com/picqer/exact-php-client/pull/449 to see if that helps

Have pushed a new v0.5.0-beta.1 release that applies the principle that's discussed here https://github.com/picqer/exact-php-client/issues/385 and https://github.com/picqer/exact-php-client/pull/449 to see if that helps

Yeah i've read the discussions... thx for the update!
Meanwhile i've implemented the queue lock mechanism of Laravel 8. This makes sure there will only be one simultaneous job in the queue. https://laravel.com/docs/8.x/queues#unique-jobs

Yeah i've read the discussions... thx for the update!
Meanwhile i've implemented the queue lock mechanism of Laravel 8. This makes sure there will only be one simultaneous job in the queue. https://laravel.com/docs/8.x/queues#unique-jobs

Pushed out another release that implements the Atomic Lock option of Laravel in stead of a custom implementation as well to further improve.

Pushed out another release that implements the Atomic Lock option of Laravel in stead of a custom implementation as well to further improve.

I haven't had the 401 error on my setup (with queueing as well) with the v0.5.0.beta2, so I've promoted that one to be the stable v0.5.0. Let me know if you run into anything with the latest stable.

I haven't had the 401 error on my setup (with queueing as well) with the v0.5.0.beta2, so I've promoted that one to be the stable v0.5.0. Let me know if you run into anything with the latest stable.


Monitoring Form fixes - important but not bugs

Aquatic and Terrestrial Chem monitoring forms:

[x] remove the "efficacy comments" field currently under chemical treatment info and mech terr aqu mont info headings on both forms.
[x] Edit the title of the "Activity Monitoring Chemical Terrestrial Aquatic Plant" and "Activity Monitoring Mechanical Terrestrial Aquatic Plant" forms to have an 'or' in between Terrestrial OR Aquatic.
[x] Edit the heading within the Activity Monitoring Mechanical Terrestrial Aquatic Plant form that currently says "Mechanical Terrestrial Aquatic Monitoring Information to just be "Mechanical Monitoring Information"
[x] remove "legacy IAPP release ID" on chemical and mechanical treatment monitoring forms. (Leave it on the biocontrol release monitoring form).

@micheal-w-wells and @sam-warren the second bullet is not complete.  The title name isn't changed on the mechanical monitoring form

my mistake, i see i just


Update your_first_service.md

Proposed changes

Unreleased project version (optional)

Related issues (optional)

Always a pleasure, @scjane :)


Analyzer, support overriding fields in strong mode

This is the Analyzer part of meta-issue #28117.
Analyzer currently rejects an override with "Field declaration [field] cannot be overridden in SubClass.". This should be removed.

This is blocked on resolution of finding an implementation strategy for DDC.

This is blocked on resolution of finding an implementation strategy for DDC.

Is there an issue tracking the need for this strategy? (More importantly, is someone working on developing the strategy?

This is blocked on https://github.com/dart-lang/sdk/issues/28809, and probably https://github.com/dart-lang/sdk/issues/28801 .  Once those are resolved, we can flip the bit here.

https://codereview.chromium.org/2781443003/


Implement everythign in the clojure atom protocol

[x] deref
[x] reset!
[x] reset-vals!
[x] swap!
[x] swap-vals!
[x] compare-and-set!
[x] watches
[x] validator


如何使用该框架进行混合精度训练？

Describe the question

A clear and concise description of what the question is.

Environment (please complete the following information):

OS: [e.g. mac / window]
Python Version [e.g. 3.6]

Screenshots

If applicable, add screenshots to help explain your problem.

Additional context

Add any other context about the problem here.

暂时还没这方面的研究，您可以自己尝试一下


*: allow REST in API resource

/cc @pwittrock
I am still testing it out. But I want to see your early feedback on the direction. Thanks!

Generally looks good.  Would you add a new apigroup in the example + write an integration test that exercises the REST impl.  You can look at the existing example tests for how to do this.

Would you add a new apigroup in the example + write an integration test that exercises the REST impl. You can look at the existing example tests for how to do this.

I will finish them in the next few days! Thanks for review and the quick reply.


missing dll

Error   2   Metadata file 'C:\Users\ahmed\Desktop\whatsapp\New folder\AxolotlTestApp-master\AxolotlTestApp-master\mylibaxolotl\bin\Debug\mylibaxolotl.dll' could not be found   C:\Users\ahmed\Desktop\whatsapp\New folder\AxolotlTestApp-master\AxolotlTestApp-master\WhatsAppApi\CSC  WhatsAppApi
Error   1   Metadata file 'C:\Users\ahmed\Desktop\whatsapp\New folder\AxolotlTestApp-master\AxolotlTestApp-master\Debug\mycurve25519.dll' could not be found    C:\Users\ahmed\Desktop\whatsapp\New folder\AxolotlTestApp-master\AxolotlTestApp-master\mylibaxolotl\CSC mylibaxolotl

WhatsAppApiApp rightClick -> Nuget -> Browse -> mylibaxolotl

Thanks so much. its work, i am able to build the solution.
But i am not able to run the WhatsAppPort, and showing following error:
**An unhandled exception of type 'System.BadImageFormatException' occurred in WhatsAppPort.exe
Additional information: Could not load file or assembly 'mylibaxolotl, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null' or one of its dependencies. An attempt was made to load a program with an incorrect format.**

On each project change Platform target from x86 to x64

i was registered, got sms and password but when i try log in i get error - login failed

https://github.com/mgp25/Chat-API-NET/issues/217

Error	9	The type 'libaxolotl.state.SignedPreKeyStore' is defined in an assembly that is not referenced. You must add a reference to assembly 'mylibaxolotl, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null'.	C:\Users\ahmed\Desktop\Chat-API-NET-master\Chat-API-NET-master\WhatsAppPort\WhatSocket.cs	10	45	WhatsAppPort
This Error That What Happen

@gulitskiy I am having the same problem, got sms and pass but then login failed.
Did you solve this issue? I would appreciate if you could help me.


License

Do you have a preferred open source license to publish this under? Would you mind MIT or similar?

Thanks for the suggestion! I picked MIT as license for the project.


Expose the createdDateTime, lastUpdatedDateTime, or resourceLocationUrl on the BuildModelOperation class

@maririos commented on Thu Sep 16 2021
does it not make sense in .NET to expose the createdDateTime, lastUpdatedDateTime, or resourceLocationUrl on the operation class?
Originally posted by @kristapratico in https://github.com/Azure/azure-sdk-for-net-pr/pull/1481#r709663466

We didn't do it in v2.1
Is there any value in exposing these properties?

There's no clear motivation to do this in the LRO class. Users can get this data from the GetOperation API (which we call internally), so let's keep it as it is until have a clear demand from customers. Closing this.


slot optimization to skip attributes dict lookup

After I  merged this commit, the slot for bufferprotocol gives me a compile error
error[E0599]: no method named `store` found for enum `std::option::Option<std::boxed::Box<(dyn for<'r> std::ops::Fn(pyobjectrc::PyObjectRc, &'r vm::VirtualMachine) -> std::result::Result<std::boxed::Box<(dyn obj::objmemory::BufferProtocol + 'static)>, pyobject::PyRef<exceptions::PyBaseException>> + std::marker::Send + std::marker::Sync + 'static)>>` in the current scope
   --> vm/src/slots.rs:359:1
    |
359 | #[pyimpl]
    | ^^^^^^^^^ method not found in `std::option::Option<std::boxed::Box<(dyn for<'r> std::ops::Fn(pyobjectrc::PyObjectRc, &'r vm::VirtualMachine) -> std::result::Result<std::boxed::Box<(dyn obj::objmemory::BufferProtocol + 'static)>, pyobject::PyRef<exceptions::PyBaseException>> + std::marker::Send + std::marker::Sync + 'static)>>`
    |

I think the problem comes from the new code of here

impl<Item> ImplItem<Item> for SlotItem
where
    Item: ItemLike + ToTokens + GetIdent,
{
    fn gen_impl_item(&self, args: ImplItemArgs<'_, Item>) -> Result<()> {
        let ident = if args.item.is_function_or_method() {
            Ok(args.item.get_ident().unwrap())
        } else {
            Err(self.new_syn_error(args.item.span(), "can only be on a method"))
        }?;

        let item_attr = args.attrs.remove(self.index());
        let item_meta = SlotItemMeta::from_attr(ident.clone(), &item_attr)?;

        let slot_ident = item_meta.slot_name()?;
        let slot_name = slot_ident.to_string();
        let tokens = {
            if slot_name == "new" {
                let into_func = quote_spanned! {ident.span() =>
                    ::rustpython_vm::function::IntoPyNativeFunc::into_func(Self::#ident)
                };
                quote! {
                    slots.#slot_ident = Some(#into_func);
                }
            } else if slot_name == "cmp" {
                let into_func = quote_spanned! {ident.span() =>
                    ::std::boxed::Box::new(Self::#ident)
                };
                quote! {
                    slots.#slot_ident = Some(#into_func);
                }
            } else {
                let into_func = if slot_name == "call" {
                    quote_spanned! {ident.span() =>
                        |zelf: ::rustpython_vm::pyobject::PyObjectRef,  args: ::rustpython_vm::function::PyFuncArgs, vm: &::rustpython_vm::VirtualMachine| -> ::rustpython_vm::pyobject::PyResult {
                            use ::rustpython_vm::pyobject::TryFromObject;
                            let zelf = PyRef::<Self>::try_from_object(vm, zelf)?;
                            Self::#ident(zelf, args, vm)
                        }
                    }
                } else {
                    quote_spanned! {ident.span() =>
                        Self::#ident
                    }
                };
                quote! {
                    slots.#slot_ident.store(Some(#into_func as _))
                }
            }
        };

        args.context.extend_slots_items.add_item(
            format!("(slot {})", slot_name),
            args.cfgs.to_vec(),
            tokens,
        )?;

        Ok(())
    }
}

the errer message is totally unreadable and we should not expect for this error right?

Oh, you should change the Box<py_dyn_fn!()> to be like the other Func type aliases, just a fn()

oh.. the PR would have lots of conflict. sorry for making that. probably #2231 will make more conflict but the situation will be a bit clearer. new is the only exception. other slots share same form.

@coolreader18 I tried to change the function type but not work but I did work around treating as "cmp", just the proc-macro is difficult for me to read...
but I am thinking we could mark all the possible slot name on the pass so easy to tracing for the futher as the compiler gives so little infomation for the macro..

For now after #2231, new is the only exception and all other slots are sharing the fn() form. So I don't want to recommend to do like cmp in this PR but follow other slot functions. Will you push your work to the working PR regardless it compiles or not? let's reveal together.

Sure


Additional text for the "Note"

Issue in ./help/access-control/abac/ui/labels.md
User must have Product Admin rights and access to the default "prod" sandbox.  Pls check with Sal Daoud to see whether this is still the case.  If this stays the case, you want to mention this in the docs to avoid that people open tickets.

Thank you for submitting this issue. We will review the documentation and make the necessary updates as quickly as possible. Tracking internally in PLAT-140474.

We've investigated this issue and the access control team has confirmed that "User must have Product Admin rights and access to the default "prod" sandbox." is incorrect. Closing this issue.


Savu installation

Hello
Among the requirements, you are listing Savu, and I am wondering which kind of installation is required? the standalone one inside a conda environment or the clusterwide version which comes with its own installer ? or should I install it inside the ot2rec env?
ref:
https://savu.readthedocs.io/en/latest/howto/installation.html
Thanks
Tru

Hi @truatpasteurdotfr,
Thanks for your interest in Ot2Rec. Savu is only required if you are intending on using it for your reconstruction, the rest of Ot2Rec will work fine without if you don't install it.
The savu-lite version will be fine (https://savu.readthedocs.io/en/latest/howto/install/savu_lite.html) though you will need to compile from source rather than using the conda installer as the Mrc saving option is not available on the conda version. The clusterwide version will be faster but might not be as straightforward to install.
I recommend creating a fresh conda environment for Ot2Rec and Savu together, their dependencies do clash but here is a workaround:

Create your savu-lite conda environment according to 1B
Install the savu-lite branch of Ot2Rec into the savu-lite environment
Note: the savu-lite branch disables mdocfile which is not compatible with Python 3.7, which is used by Savu. This is not required for the savu step anyway - though I'd suggest using the regular Ot2Rec for everything else

Hope that helps, please let us know if you have any other questions.

(base) [truadm@abiy ~]$ conda install savu-lite -c conda-forge -c savu-dep -c ccpi -c astra-toolbox/label/dev
Collecting package metadata (current_repodata.json): done
Solving environment: failed with initial frozen solve. Retrying with flexible solve.
Solving environment: failed with repodata from current_repodata.json, will retry with next repodata source.
Collecting package metadata (repodata.json): done
Solving environment: failed with initial frozen solve. Retrying with flexible solve.
Solving environment: |
Found conflicts! Looking for incompatible packages.                                                                                failed

UnsatisfiableError: The following specifications were found
to be incompatible with the existing python installation in your environment:

Specifications:

  - savu-lite -> python[version='>=3.7,<3.8.0a0']

Your python: python=3.10

I will install with an earlier python version for savu-lite. Does Ot2Rec have such a requirement for python?

Hi Tru,
The full version of Ot2Rec works with Python 3.8 onwards. To use it in the same environment as Savu, you'd need to use Ot2Rec's savu-lite branch (https://github.com/rosalindfranklininstitute/Ot2Rec/tree/savu-lite) which is also compatible with Python 3.7.
Also with Savu-lite you will need to install the version that they have on GitHub rather than the conda-forge version, as I don't think the conda version has the MrcSaver plugin Ot2Rec uses to save tomograms.

I must be doing something wrong...
[truadm@abiy ~]$ conda create -n py37-savu-lite python=3.7
...
[truadm@abiy ~]$ conda activate py37-savu-lite
(py37-savu-lite) [truadm@abiy ~]$ python -V
Python 3.7.16
(py37-savu-lite) [truadm@abiy ~]$ git clone https://github.com/rosalindfranklininstitute/Ot2Rec
...
(py37-savu-lite) [truadm@abiy ~]$ cd Ot2Rec/
(py37-savu-lite) [truadm@abiy ~]$ git branch -a
* main
...
  remotes/origin/savu-lite
  remotes/origin/stack-split
  remotes/origin/tests
  remotes/origin/tests-neville
(py37-savu-lite) [truadm@abiy ~] git checkout -b remotes/origin/savu-lite
Switched to a new branch 'remotes/origin/savu-lite'
(py37-savu-lite) [truadm@abiy Ot2Rec]$ git status
# On branch remotes/origin/savu-lite
(py37-savu-lite) [truadm@abiy Ot2Rec]$ python3 setup.py develop
running develop
/esmmc/ot2rc-miniconda3/envs/py37-savu-lite/lib/python3.7/site-packages/setuptools/command/easy_install.py:147: EasyInstallDeprecationWarning: easy_install command is deprecated. Use build and pip and other standards-based tools.
  EasyInstallDeprecationWarning,
/esmmc/ot2rc-miniconda3/envs/py37-savu-lite/lib/python3.7/site-packages/setuptools/command/install.py:37: SetuptoolsDeprecationWarning: setup.py install is deprecated. Use build and pip and other standards-based tools.
  setuptools.SetuptoolsDeprecationWarning,
running egg_info
writing src/Ot2Rec.egg-info/PKG-INFO
writing dependency_links to src/Ot2Rec.egg-info/dependency_links.txt
writing entry points to src/Ot2Rec.egg-info/entry_points.txt
writing requirements to src/Ot2Rec.egg-info/requires.txt
writing top-level names to src/Ot2Rec.egg-info/top_level.txt
reading manifest file 'src/Ot2Rec.egg-info/SOURCES.txt'
adding license file 'LICENSE'
writing manifest file 'src/Ot2Rec.egg-info/SOURCES.txt'
running build_ext
Creating /esmmc/ot2rc-miniconda3/envs/py37-savu-lite/lib/python3.7/site-packages/Ot2Rec.egg-link (link to src)
Ot2Rec 0.3.0 is already the active version in easy-install.pth
Installing o2r.aretomo.new script to /esmmc/ot2rc-miniconda3/envs/py37-savu-lite/bin
...
Installing o2r.savu.recon.new script to /esmmc/ot2rc-miniconda3/envs/py37-savu-lite/bin
Installing o2r.savu.recon.run script to /esmmc/ot2rc-miniconda3/envs/py37-savu-lite/bin

Installed /home/truadm/Ot2Rec/src
Processing dependencies for Ot2Rec==0.3.0
Searching for scikit-image
Reading https://pypi.org/simple/scikit-image/
/esmmc/ot2rc-miniconda3/envs/py37-savu-lite/lib/python3.7/site-packages/pkg_resources/__init__.py:126: PkgResourcesDeprecationWarning: image-0.7.2 is an invalid version and will not be supported in a future release
  PkgResourcesDeprecationWarning,
/esmmc/ot2rc-miniconda3/envs/py37-savu-lite/lib/python3.7/site-packages/pkg_resources/__init__.py:126: PkgResourcesDeprecationWarning:  is an invalid version and will not be supported in a future release
  PkgResourcesDeprecationWarning,
../esmmc/ot2rc-miniconda3/envs/py37-savu-lite/lib/python3.7/site-packages/pkg_resources/__init__.py:126: PkgResourcesDeprecationWarning: image-0.20.0rc7 is an invalid version and will not be supported in a future release
  PkgResourcesDeprecationWarning,
Downloading https://files.pythonhosted.org/packages/03/d6/a1495c30d82bd7a0f7e76bcc31273485ddbee92347d5b99ccf8e309f47ae/scikit_image-0.20.0rc8.tar.gz#sha256=492499eb052b27c47ccea8fc96a277e79a5e498dfc3720100c88a13559c7c99d
Best match: scikit-image 0.20.0rc8
Processing scikit_image-0.20.0rc8.tar.gz
error: Couldn't find a setup script in /tmp/easy_install-5y_wvqtb/scikit_image-0.20.0rc8.tar.gz
(py37-savu-lite) [truadm@abiy Ot2Rec]$

Hi Tru,
Sorry this is quite the pain to install!
What worked for me:
git clone https://github.com/DiamondLightSource/Savu.git
conda create --name o2r_savu --file install/savu_lite37/spec-savu_lite_latest.txt
python setup.py install

cd ..
git clone -b savu-lite https://github.com/rosalindfranklininstitute/Ot2Rec.git
cd Ot2Rec
pip install -e .

Hi Tru, oops, yes you should activate the conda env for sure

Thanks for your help, I have wrapped the follwing bash script https://github.com/truatpasteurdotfr/docker-miniconda3-Ot2Rec-Savu/blob/main/runme.sh if that can help.
The only warning I get is:
Successfully built pytools reikna
Installing collected packages: typing-extensions, platformdirs, pytools, funcsigs, superqt, reikna, PyQt5-sip, PyQt5-Qt5, pyopencl, psygnal, executing, docstring-parser, dill, asttokens, redlionfish, pyqt5, multiprocess, magicgui, icecream, beautifultable, Ot2Rec
  Attempting uninstall: typing-extensions
    Found existing installation: typing-extensions <IP_ADDRESS>
    Uninstalling typing-extensions-<IP_ADDRESS>:
      Successfully uninstalled typing-extensions-<IP_ADDRESS>
  Running setup.py develop for Ot2Rec
ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
spyder 4.2.0 requires pyqtwebengine<5.13, which is not installed.
spyder 4.2.0 requires pyqt5<5.13, but you have pyqt5 5.15.9 which is incompatible.
Successfully installed Ot2Rec PyQt5-Qt5-5.15.2 PyQt5-sip-12.11.1 asttokens-2.2.1 beautifultable-1.1.0 dill-0.3.6 docstring-parser-0.15 executing-1.2.0 funcsigs-1.0.2 icecream-2.1.3 magicgui-0.6.1 multiprocess-0.70.14 platformdirs-3.0.0 psygnal-0.8.1 pyopencl-2022.2.4 pyqt5-5.15.9 pytools-2022.1.12 redlionfish-0.8 reikna-0.8.0 superqt-0.4.1 typing-extensions-4.5.0

Not sure how important that is...

Hi Tru,
That's really helpful, thank you for putting that together!
I also get that error but I haven't found any issues with performance - do let me know if you come across any issues with it.
I'm going to go ahead and close this issue, but feel free to reopen or make a new one if you have any further questions. Thanks!


Reading List

Media Technologies: Essays on Communication, Materiality, and Society

specifically "Rethinking Repairs", on this question of "how do you seek truth without damaging the load bearing narratives of your society?"

Replication Crisis syllabus, curated by Ethan Ludwin-Peery https://github.com/DefenderOfBasic/works-in-progress/issues/49

(recommended by mold time, to catch me up on the state of open science, peer review issues, how we got to this current point?)

Plurality by Audrey Tang, "The future of collaborative technology and democracy"

Machine Habitus: Toward a Sociology of Algorithms

Memetic Magic: Manipulation of the Root Social Matrix and the Fabric of Reality

Relevant fields?

Cyborg anthropology is a discipline that studies the interaction between humanity and technology from an anthropological perspective. The discipline offers novel insights on new technological advances and their effect on culture and society.

https://en.wikipedia.org/wiki/Cyborg_anthropology

The Founder of Graphika has a Ph.D in Computational Social Science. We can probably explore that field for some good tools and tactics. (wikipedia link to computational social science: https://en.wikipedia.org/wiki/Computational_social_science )


Support working with SLSA statements (without wrapping)

The SLSA attestation model [1] defines a "statement" as an in-toto attestation, e.g. as "https://in-toto.io/Statement/v1" [2]. This statement contains both the predicate (e.g. "provenance" / "cyclonedx") as well as the "subject", that defines for which files the predicate holds. It would be great, if the cosign tool could directly work with these json documents instead and just add the DSSEv1 envelope (+key handling, rekor uploading,...).
The current version of cosign only allows to work with raw predicates (--predicate), but these are wrapped into a https://cosign.sigstore.dev/attestation/v1. The output then contains the original predicate in Predicate.Data, which hides it from tooling that directly works on the predicates.
Another alternative would be to split the cosign workflow into the certificate fetching part and the upload to rekor part. Then, the creation of the DSSEv1 (which is rather trivial) could be done by other tooling.

[1] https://slsa.dev/attestation-model
[2] https://github.com/in-toto/attestation/blob/main/protos/in_toto_attestation/v1/statement.proto

Let's formalize this a bit. The most important aspect hereby is to clearly define the interface between the application which generates the SLSA statements and the signing / verification.
Use-Case:

a non sigstore component generates SLSA statements: this statement must include zero or more subjects (the spec is a bit imprecise w.r.t zero subjects)
The statement is passed to cosign to sign it and upload to rekor
For verification, the generated DSSE + a search path is passed to cosign to check if all artifact checksums match (+ certificate / key material, as already implemented)

Proposed solution (signing):

extend the cosign attest-blob command
add --statement flag
if --statement is set, the <BLOB> is considered to be a statement and cosign operates on the internals. No need to re-compute and check file hashes. Only syntactic validation shall be performed on the <BLOB>.

Proposed solution (verification):

extend the cosign verify-blob-attestation command
add --statement flag
add --path  option (can be specified multiple times) to set the artifact search path
if --statement is set, the <BLOB> is considered to be a statement and cosign operates on the internals
on execution:

validate integrity of DSSE (already implemented)
extract all subjects (these should be ResourceDescriptor with a digest)
for each RD, check if any artifact in the --path has a checksum that matches. Note, that the artifacts are matched purely by digest, regardless of content type (and name? Spec is imprecise). https://github.com/in-toto/attestation/issues/28

Alternative implementation:

use dedicated commands for this mode of operation
in verification step, let user pass filenames to avoid the complexity around the discovery and matching by checksum only.

Closing words:
It would be great if someone more familiar with the SLSA / in-toto attestations could have a look at the ambiguities in the spec (mentioned above). Maybe that's just due to my imprecise reading of the spec, but if it is really imprecise or unclear, we should improve the spec as well. Anyways, I'm happy to hear feedback.

cc @laurentsimon


[BUG] Image control is working when scrolling feed

Description
Image control works when scrolling the feed, when it should not.
When you scroll your feed, whether from a search or your feed, if you encounter an image and you scroll on it, the image itself will move up or down depending on your scroll, and you'll be put back on your research quitting the current feed, or to a black screen.
Image control should only work when you first tap it.
Step to reproduce the bug

Search for a random feed
Scroll the feed until you find an image
Make the scroll movement on the image, the image is reacting to your scroll
The app makes you go back to your previous research and quits your feed.

ALT

Scroll your feed
Scroll on an image
The image react to your scroll and move on itself
Release the input
You're brought to an empty void

Occurrence
I can only reproduce it sometimes, not all the time.
Device
Xperia 10
Android 10
(Latest beta version of 23/09/2022 as the app shows me "v+" version)
Screenshot
Before:

Scrolling on the image:

After releasing input when searching:

After releasing input when scrolling your feed:

It's the same as https://github.com/jonjomckay/fritter/issues/514.

Closing as a duplicate of #477. The latest beta version contains this fix if you'd like to try it!

Sorry to reopen the case, but I would like to confirm I was not able to reproduce the bug.
Instead, the scroll sometimes stops and only resume when not clicking the image.
Otherwise the user experience is much better now!


Hovering to user avatar in profile settings.

When user does not have permission to change avatar hovering on avatar in profile settings menu also renders "upload new profile picture".

Thanks for the report @Ujjawal3 ! Agreed, the "Upload new profile picture" message should not be shown in this situation.

I wasn't aware of this issue being tracked here, but noticed the bug when I was testing my changes in #23962. I put up #23964 this afternoon before I knew there was an issue and pull request in progress to fix the issue.
While working on it, I did note that this bug/issue also impacts the organization profile tab for non-admin users.


How to add a new item to scene on screen tap?

I want  to add chairs to a 3d house on tap any idea how can i achieve that

Hi @GauravCalidig
three_dart is just three.js rewrite
you can follow three.js tutorial or example
https://threejs.org/docs/#manual/en/introduction/Creating-a-scene
chair is just a mesh or o group, you can add it to a scene
scene.add( chair )


Scheduler Implementation

What do we need

Scheduling policy to prevent resource hogging
Scheduling logic from IntegrationJob to PipelineRun

Implementation Goal

Triggered by IntegrationJob controller

To decide

When to call Schedule() func?

Only when IntegrationJob created/completed

How to detect the exact time?
If Schedule is not available (e.g., recent schedule call is not completed yet), hmm..

How to handle if there are tons of Schedule() calls?
Schedule policy (currently considering only FIFO)


Find alternative to NCC

The NCC dependency has been a bit of a painpoint for this project for a while. We have been using a  prebuild for a while to sidestep a bug that causes problems when bundling SVGO. Now, v0.31.0 introduces another issue that prevents the action from running altogether. So, it's time to look for alternative ways to bundle the source into a single, stand-alone JavaScript file. I've had some success with rollup.js in the past, so that might be a good first try to replace NCC.
For the time being, I configured Renovate to stop updating NCC.

Small update: I'm planning to address this in v3.0.0 where (built-in) support for SVGO v1 is planned to be dropped (see #473).
However, anyone is free to contribute a replacement for NCC for v2 (not v1!) as well.


Adds private_ip var

Also fixes up typo.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.0 out of 2 committers have signed the CLA.:x: angryninja48:x: Jon BakerJon Baker seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Update date-fns to 2.0

Hi @kefranabg
Can I please work on this? I am new here
Thanks

Whoops, this issue is outdated, already solved by #113 . Sorry about that !


Need AP6212 WiFi/BT support included for Radxa Zero

The 512MB and 1GB version of the board use the AP6212 but it looks like only the AP6256 is supported by the OS.

Hi, did this come through a support ticket?

As an additional note, I found that some Radxa Zeros may contain a CM256SM instead of the AP6256.  (see: https://forum.radxa.com/t/my-zero-wifi-is-not-working/10127)  I think it would be best if all three drivers were just included in the OS image.  So these devices: AP6212, AP6256 and CM256SM.

I have the following Radxa Zero boards, and a testbot I can connect them to: (may need help with that)
Model D0: 512MB RAM, WIFI4/BLE4, no eMMC, GPIO header, onboard antenna, AP6212
Model D1: 1GB RAM, WIFI4/BLE4, no eMMC, GPIO header, onboard antenna, AP6212
Model D4E16: 4GB      RAM, WIFI5/BT5, 16GB eMMC, GPIO header, onboard antenna, AP6256

Update:  All of the four devices I received have the AP6212.

@wjlove @alanb128 can you share the dmesg on a device that has AP6212?

@floion This is what I'm getting on the D0, which as far as I understand should be equipped with AP6212:
dmsg.txt

@floion Here is a copy of my dmesg output which has a AP6212 module installed.  It is also the same device I have been using for other testing.
dmesg.txt

@alanb128 - After @floion indicated that support for the AP6212 was added I tested a Radxa Zero D1 with wifi only and was sucessful.  I also tested a Radxa Zero D0 with the same sucess.  Both of these tests were done in staging.

Thanks @wjlove that's great news! I will start testing as well.

@alanb128 Let me know when you get some time to do testing.  I am having stability issues with my devices.  They connect to my wifi network and work fine for "a while" and then disconnect.  The amount of time before disconnect appears to be variable and the device that @floion tested with (on my network) does not have this problem.  All devceis are running the same code.

Follow up-  I have tried several radxa zero device models (D0 and D1) and both have stability issues.  I tried both with and without wifi (USB ethernet device) and have the same issues.  I connected my devices to a keyboard/monitor and found that the devices actually lock-up and are frozen to input and output.  No response from keyboard, and when running the top unitlity the screen stops updating.   Oddly tho, @florin your device has been running fine since you worked on it.  I tried adding a device to the fleet your device is in and have the same results in that at a random time my devices freeze.  (I checked the boards for revision numbers and they are all at v1.5)
I further explored this isssue by installing Ubuntu 20.04 and had the same results.  However, when I installed Debian Buster that worked fine for at least 4 hours.