WIP basic workflow test for containers

This is a basic workflow test of the containers containing the tasks that a typical user would run through to use them and get familiar with ilab.
It is written in shell script because this basic workflow is a shell workflow, run through step by step at a shell prompt by a user.

@rhatdan @jeremyeder @lmilbaum FYI

@lmilbaum @rhatdan These is an e2e test we'd run in https://github.com/containers/ai-lab-recipes/ ... related to https://github.com/containers/ai-lab-recipes/pull/341

This work needs https://github.com/instructlab/instructlab/pull/1018 to fix the container first.
The work is incomplete right now, with lots of TODO statements indicating what remains to be done.

@russellb The Container file also needs this for cuda:
-RUN dnf install -y libcudnn8 nvidia-driver-NVML
+RUN dnf install -y libcudnn8 nvidia-driver-NVML nvidia-driver-cuda-libs

Is this ready for broader review and testing? Did a CI run work successfully in GitHub?

Is this ready for broader review and testing? Did a CI run work successfully in GitHub?

I don’t have the CI job passing yet. I’ll update again later today.

  Some outstanding issues:

I defined an e2e CI job, but it doesn't work reliably. I don't think the github action runners have enough CPU to finish even the most minimal configuration. I'm going to switch to looking at running it on a GPU runner instead. The tradeoff will be that it won't run on every PR for now, since it's not free.
Eventually, we'll squash all of this, but that's for when it's ready for review and merge ... I'd like to have a working CI job ready for this repo first though

The end-to-end CI job that does init/download/generate/train on Linux is passing. This is running on the host OS using a GPU worker available via github actions.
Next steps:

I'm going to clean up this branch by squashing most of it together and putting it in a form ready for review and merging this first workflow
Next I want to add a variant that instead of running it on the host, builds a cuda container using our containerfile and runs the same workflow using the container. I'd like to do that in a follow-up PR, though.

I applied the hold label because:

This PR includes #1058, so that should be reviewed first
There is a commit on the branch that must be removed before merging (the change to make the job run automatically against this PR). The intent is to only merge it as a manually triggered workflow.

Note that the workflow is currently limited and stops before ensuring you can run ilab serve with a model after ilab train because of #579

A data point on costs. The last two successful runs took 22 minutes. That costs us $1.54 each time ($0.07 per minute). If we run this only manually, I think the costs will stay under control.
I also think we could speed this up. A lot of time is spent on downloading and installing stuff. No caching is done in the workflow, yet.

For caching I recommend to use setup-python with cache pip and actions/cache to cache the Hugging Face models. We are using the same technique in test.yaml. You could also cache the APT packages with something like https://github.com/marketplace/actions/cache-apt-packages
      - name: Setup Python 3.11
        uses: actions/setup-python@v5
        with:
          python-version: py311
          cache: pip
          cache-dependency-path: |
            **/pyproject.toml
            **/requirements*.txt

      - name: Cache huggingface
        uses: actions/cache@v4
        with:
          path: ~/.cache/huggingface
          # config contains DEFAULT_MODEL
          key: huggingface-${{ hashFiles('src/instructlab/config.py') }}

Are you sure the PR uses a CUDA-accelerated build of llama-cpp-python? It downloads and builds llama-cpp-python two times:
Collecting llama-cpp-python
  Downloading llama_cpp_python-0.2.68.tar.gz (42.5 MB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 42.5/42.5 MB 170.8 MB/s eta 0:00:00
  Installing build dependencies: started
  Installing build dependencies: finished with status 'done'
  Getting requirements to build wheel: started
  Getting requirements to build wheel: finished with status 'done'
  Installing backend dependencies: started
  Installing backend dependencies: finished with status 'done'
  Preparing metadata (pyproject.toml): started
  Preparing metadata (pyproject.toml): finished with status 'done'

 Collecting llama_cpp_python[server]==0.2.55
  Downloading llama_cpp_python-0.2.55.tar.gz (36.8 MB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 36.8/36.8 MB 172.1 MB/s eta 0:00:00
  Installing build dependencies: started
  Installing build dependencies: finished with status 'done'
  Getting requirements to build wheel: started
  Getting requirements to build wheel: finished with status 'done'
  Installing backend dependencies: started
  Installing backend dependencies: finished with status 'done'
  Preparing metadata (pyproject.toml): started
  Preparing metadata (pyproject.toml): finished with status 'done'

I think you are overriding the CUDA build with a CPU-only build. Our installation instructions have sharp edges.
Please try this:
sed 's/\[.*\]//' requirements.txt constraints.txt
python3 -m pip cache remove llama_cpp_python
python3 -m pip install --no-binary llama_cpp_python -c constraints.txt llama_cpp_python

Are you sure the PR uses a CUDA-accelerated build of llama-cpp-python?

I guess I'm not! I was going off of the output from ilab train confirming that it was using the GPU, but I wasn't thinking that ilab serve might be different. Thank you.

LGTM - I'd love if we could incorporate this into the release workflow somehow - maybe having an automic trigger when we cut a new release branch for Y-streams or for Backport PRs to an existing release branch (to ensure Z-streams have no regressions)

Yeah, that's a good idea. We could definitely trigger it on tag creation. At the moment, it would be triggering it manually, and using the input field that lets you specify which branch or tag to run against. You't put in release-v0.15 or v0.15.0 or whatever you want and it'll run for you.


ValueError: cannot reshape array of size 2 into shape (1,100,1)

Hi,
After i trained my .txt file im stucking with this error when i want to do text generation.

ValueError: cannot reshape array of size 2 into shape (1,100,1)

My code:
import numpy as np
import keras
from keras.models import Sequential
from keras.layers import Dense, LSTM, Dropout, Activation
from keras.optimizers import RMSprop, Adam
from keras.callbacks import ModelCheckpoint
from keras.utils import np_utils

SEQ_LENGTH = 100

def buildmodel(VOCABULARY):
    model = Sequential()
    model.add(LSTM(256, input_shape = (SEQ_LENGTH, 1), return_sequences = True))
    model.add(Dropout(0.2))
    model.add(LSTM(256))
    model.add(Dropout(0.2))
    model.add(Dense(VOCABULARY, activation = 'softmax'))
    model.compile(loss = 'categorical_crossentropy', optimizer = 'adam')
    return model

file = open('ornek_encoded.txt', encoding = 'utf8', errors='ignore')
raw_text = file.read()
raw_text = raw_text.lower()

chars = sorted(list(set(raw_text)))
print(chars)
bad_chars = ['#', '*', '@', '_', '\ufeff']
for i in range(len(bad_chars)):
    raw_text = raw_text.replace(bad_chars[i],"")
chars = sorted(list(set(raw_text)))
print(chars)
VOCABULARY = len(chars)

int_to_char = dict((i, c) for i, c in enumerate(chars))
char_to_int = dict((c, i) for i, c in enumerate(chars))

filename = 'saved_models/weights-improvement-01-3.2719.hdf5'
model = buildmodel(VOCABULARY)
model.load_weights(filename)
model.compile(loss = 'categorical_crossentropy', optimizer = 'adam')

initial_text = '  '# we sat here we two and we said how we wish we had something to do.'
initial_text = [char_to_int[c] for c in initial_text]

GENERATED_LENGTH = 1000
test_text = initial_text
generated_text = []

for i in range(1000):
    X = np.reshape(test_text, (1, SEQ_LENGTH, 1))
    next_character = model.predict(X/float(VOCABULARY))
    index = np.argmax(next_character)
    generated_text.append(int_to_char[index])
    test_text.append(index)
    test_text = test_text[1:]

print(''.join(generated_text))

Hi again, i solved this problem with fill initial_text with 100 char.
But now i have another issue again about shape.

ValueError: Dimension 1 in both shapes must be equal, but are 26 and 51. Shapes are [256,26] and [256,51]. for 'Assign_6' (op: 'Assign') with input shapes: [256,26], [256,51].


Make classes public

When installing through cocoapods, the files are placed in a different module.
This means classes without the public keyword cannot be used in the app's module

Thanks for informing 👍
#d6697ce

check version 0.2.1
Commit #d6697ce


fix(dateparser): do not try to process invalid baseDate

This is causing a lot of issues for me when I manually enter date strings. This could also be related to issues reported with leading zeroes.
Plunker
Enter the date "2001-01-01" into the input field and see that in the end the model becomes an invalid date.
The root of the issue is the parsing of baseDate inside dateparser.
The string '2001-01-0' is an invalid date, passed as baseDate to the next input, '2001-01-01' which is valid but gets corrupted by the previous baseDate because it is assumed to be valid

Fixed by 4f1e03f1147b9a50566df064db72522a130f8135


Prevent key holding

By keeping track whether the key has been pressed and released, we prevent the user from keeping the key down and fast-forwarding through the sentence.
Inspired by a more general version on StackOverflow

Hi Jiri, thanks for taking the time to submit this.
I don't think that there is any point in trying to stop users from doing this. If users want to go through the sentence as fast as possible without reading it, then they can do that, regardless of whether or not separate presses of the space bar are required. The best thing to do is to add comprehension questions and filter out participants who answer a significant number of comprehension questions incorrectly.
This modification also adds a small degree of additional latency, since the next word is displayed only once the space bar is released.
See also discussion here:
https://groups.google.com/forum/#!searchin/ibexexperiments/hold$20key$20down$20space|sort:date/ibexexperiments/8_poa2W9zhA/gq1ITZogBAAJ

Hi & thanks for the quick response. I suppose we can't prevent the users completely, but I don't want to make it easy for them. This would also prevent the few cases where the user holds the spacebar too long and skips the next word by accident. Obviously, it's entirely up to you to decide whether it makes sense in the master branch or not.
Regarding the latency - actually, the next word is displayed immediately, it is only the word after that that is affected, waiting for the "keyup - keydown" event pair.

Ah I see. Ok, I think I agree with the logic for including this. I may look into whether it's possible to do this without registering and unregistering event listeners.


[FEATURE] Export-PnPFlow - Add options to capture errors, increase timeout, retry attempts

Is your feature request related to a problem? Please describe.
Koen recently added verbose information to Export-PnPFlow. I was hoping this could be expanded for error trapping purposes.
https://github.com/pnp/powershell/issues/865#event-5404518820
Describe the solution you'd like
I would like to be able to capture errors from Export-PnPflow with ErrorAction and/or ErrorVariable so I can send those to a log file and provide email notifications.
Describe alternatives you've considered
Here is a work-around I have created. This feels like a hack. I think a more formal approach would be better.
$VerboseStream = (Export-PnPFlow -Environment $globals.envGUID -Identity $_.Flow_FlowName -OutPath $outPath -AsZipPackage -Verbose | Tee-Object -Variable 'String' | Out-Null) 4>&1
if($VerboseStream -like 'error') {
}

You can maybe increase the timeout by adding this environment variable like below:
$env:SharePointPnPHttpTimeout = 300

and then use the Export-PnPFlow command, maybe that can help ?

Okay I will try that. Thanks for the suggested.
Hopefully the other ideas I posted will be considered to make this cmdlet
more resilient.
On Sat, Mar 5, 2022 at 9:49 AM Gautam Sheth @.***>
wrote:

You can maybe increase the timeout by adding this environment variable
like below:
$env:SharePointPnPHttpTimeout = 300
and then use the Export-PnPFlow command, maybe that can help ?
—
Reply to this email directly, view it on GitHub
https://github.com/pnp/powershell/issues/1340#issuecomment-1059786264,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAMJ2HICBLPD6O2QN5L4TLTU6N7CPANCNFSM5H3NWANA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.Message ID:
@.***>

@gautamdsheth - I am getting back into testing this process I am working on. I added the variable you suggested above. I'm seeing it take 5 minutes to establish a connection with Connect-PnPOnline?  I am using a service account that doesn't require MFA. Typically a connection takes 1-2 seconds. Is this to be expected now? Or is there some kind new/temporary of problem?


Tab long space

It's tab character ( ). Maybe I need tab-size](https://developer.mozilla.org/en-US/docs/Web/CSS/tab-size) CSS.

Fixed by tab-size.


Update operation table for 0.2.34

Add <= and >= operators to the operation table in native-numbers.md to reflect the changes made in 0.2.34

Thank you


Only build BYOC aws client if needed

Currently, every time a BYOC account is reconciled, an aws client is build based on the credentials in the secret referenced in the CR. This client is only used when first initializing the BYOC account and is never used again. This PR ensures that we only build the client when needed.

/hold

/lgtm

/hold cancel

/hold

/hold cancel

/lgtm

/retest


Add --replace flag to cargo install

Close #2082.
If --bin or --example are present force overwriting existing
binaries, otherwise uninstall any crates providing conflicting binaries.
This allows updating crates cleanly via
cargo install --replace <crate>

yet one can avoid blowing away whole crates because
cargo install --replace --bin <crate_bin> <crate>

will only overwrite that one binary.
I haven't added any tests yet because this might not get accepted.

r? @huonw
(rust_highfive has picked a reviewer for you, use r? to override)

r? @alexcrichton

Thanks for the PR @gkoz! There's a few technical aspects I'd tweak here, but I agree that the first thing to do here is probably to decide whether we want to do this in the first place. Let's discuss more on the issue, though, as that's probably the best place to have this discussion.
(I'll write a comment over there shortly)

There doesn't seem to be any opposition to this change.

Ok, @wycats and I had a chance to talk about this recently, and this seems like it's desirable as it's pretty orthogonal from the --update flag. Put another way, cargo install --replace is distinct from cargo install --update --replace, so it seems fine to have both!
One thought we had was perhaps this could be renamed -f or --force? That follows the convention of many other tools for saying "just do this". Also, from the discussion on #2082 it sounds like the opinions about --update may have changed in light of our current situation, so if you'd like to implement that as well here feel free!

Yes --force would work. I had avoided it to sidestep a bigger question of whether cargo should have such a flag and consistency considerations (if install gets it other commands might want to as well).
I'll keep --update in mind but wouldn't do it straight away.
You had mentioned some implementation issues. I'm guessing you don't like the replace (or force) flag being passed as a bool from bin/install.rs?

Ah I believe what I had in mind was the "transactional" nature of the install. Right now the uninstall happens first, but it probably wants to get delayed until right before the actual new binaries are moved into place (either that or nothing is really uninstalled, just metadata is updated).

:umbrella: The latest upstream changes (presumably #2421) made this pull request unmergeable. Please resolve the merge conflicts.

ping @gkoz, any update on this?

Oh wow, it's been a month? I'll revisit this in a few days.

Sounds good to me! Feel free to ping me if you need help pushing over the finish line.

Ah I believe what I had in mind was the "transactional" nature of the install. Right now the uninstall happens first, but it probably wants to get delayed until right before the actual new binaries are moved into place (either that or nothing is really uninstalled, just metadata is updated).

To avoid any misunderstanding... The current patch calls uninstall after building but before copying the binaries. If that is too risky (after uninstalling we might find there's not enough space for the new binaries?) I could perhaps create a temporary subdirectory (TempDir::new_in(&dst)), copy new binaries into it and then overwrite the old ones.

Basically what I'm getting at is two properties:

If a normal error happens for whatever reason, we shouldn't tamper with the install root at all
If ctrl-c happens, the "window of where things are corrupted" should be as small as possible

So given that, the error that I'm worried about here is that we successfully remove something but then hit an I/O error copying in a new file, In that case we won't restore the just-removed binaries. Could this be updated to handle that?

I've pushed a version, that copies all binaries into a temp subdirectory of the destination and only after that succeeds tries to replace the existing binaries. If overwriting is partially successful, it doesn't try to undo anything (should it? that could further increase complexity) but still updates the metadata.
Another difference from former behavior is (when --force is absent) listing all of the binaries to be overwritten, not just the first one. However the error message still doesn't make it very clear that without --bin the old packages will be removed completely.
Error handling is not ideal here:

I'm not sure how to make several lines of "binary ... already exists ..." and the "Add --force to overwrite" hint look nicer,
there doesn't seem to be a way to report two unrelated but equally important errors.

Oh and I haven't tested on Windows yet to make sure there's no issue with EXE_SUFFIX.

Thanks @gkoz! Can you also write some tests for some of the corner cases here? Just to make sure the metadata is managed properly and everything works as expected.

Still working on adding tests. Wondering how to imitate failure modes.

It's ok to not necessarily exhaustively test them, it's fine to just smoke test a few simple ones like something already exists, a build failure when overwriting, etc.

Added more tests and an optional optimization in a separate commit.

@bors: r+ 9f0fa249b5d307bd97c8c4957a98ad9f47116bf9
Thanks!

:hourglass: Testing commit 9f0fa24 with merge 401209f...

:broken_heart: Test failed - cargo-win-msvc-32

@bors: retry
On Mon, May 2, 2016 at 10:21 AM, bors<EMAIL_ADDRESS>wrote:

[image: :broken_heart:] Test failed - cargo-win-msvc-32
http://buildbot.rust-lang.org/builders/cargo-win-msvc-32/builds/391
—
You are receiving this because you were assigned.
Reply to this email directly or view it on GitHub
https://github.com/rust-lang/cargo/pull/2405#issuecomment-216300732

:zap: Previous build results for cargo-linux-32, cargo-linux-64, cargo-mac-32, cargo-mac-64, cargo-win-gnu-64, cargo-win-msvc-64 are reusable. Rebuilding only cargo-cross-linux, cargo-win-gnu-32, cargo-win-msvc-32...

:sunny: Test successful - cargo-cross-linux, cargo-linux-32, cargo-linux-64, cargo-mac-32, cargo-mac-64, cargo-win-gnu-32, cargo-win-gnu-64, cargo-win-msvc-32, cargo-win-msvc-64


Photobucket no longer provides account deletion links

Hello, I tried deleting my Photobucket account today, but I realised that with the new website redesign it is impossible to do so. The link provided by justdeleteme redirects to a login page that jumps the user to the new photobucket main page. I have searched for the functionality in the account settings but I couldn't find it. I believe that now it might be impossible to be eresad from photobucket.

Under the main page, after clicking on "Account status", is there a "Delete my account" link anywhere on that page?

I think I was able to screenshot every single setting page, so you can see what I'm dealing with. The settings are quite a joke now.
I was able to delete all my files manually and supply fake personal information, but I still couldn't find a way to delete my account.
This is the main page where you can upload your pictures.
You are redirected here when you use the justdeleteme link. Clicking on your username does nothing.

Profile settings page

Security settings page

Billing/plan landing page

Monthly billing

Annual billing

And I think that's it. These are all the settings I could find

Some websites require mailing them to delete the account, have you tried this? Maybe it's turned this harder

Some websites require mailing them to delete the account, have you tried this? Maybe it's turned this harder

Allright, good idea. I just mailed support, I will get back with their response as soon as I get one.

Have you heard back from them @CarbonaraJack ?

Have you heard back from them @CarbonaraJack ?

Yes, just this morning. My account will be deleted in 48 hours.
When first emailing them they ask you to provide this information

Then after a couple of days you will get this

So apparently they don't store your pictures after the account deletion.
So yeah, I think we can label Photobucket as Hard.

Do you have the support e-mail? Or did you file a request on a specific link?

I mailed<EMAIL_ADDRESS>This was the body of my mail

Thanks! Feel free to write a PR now, otherwise I can do it tomorrow

Alright, I will get to it later in the day.
Thanks for the help :)


the redirect page has been added with classification of bikes

Features Added

Redirect Page has been added with pure HTML, CSS.
Responsive Page
Needed to embed the payment interface
can be embed on the Select Your Bike icon on Home Page
Interface will be done by the repo owner itself.

@preeti13456 i know template folder contains some html files but I keep these asides in a new folder for the feasibility, when you'll move forward with the production level code then it'll easy to merge them and in case of cards just what you need to do is maintain a dB with your backend so that whenever customer clicks on the card they will automatically redirected to payment page with that amount also the vacant bike from dB will be assigned to them.

@preeti13456 i know template folder contains some html files but I keep these asides in a new folder for the feasibility, when you'll move forward with the production level code then it'll easy to merge them and in case of cards just what you need to do is maintain a dB with your backend so that whenever customer clicks on the card they will automatically redirected to payment page with that amount also the vacant bike from dB will be assigned to them.

Cool do one thing I'll raise an issue or something if the backend is done then you can start with adding the file in same folder then it won't make an issue. Is that alright?

Cool do one thing I'll raise an issue or something if the backend is done then you can start with adding the file in same folder then it won't make an issue. Is that alright?

@preeti13456 Sure

@preeti13456 Sure

@preeti13456 You have added two tags here.


Add more token colours

Hi there,
I was just wondering why there's a discrepancy in colours between go and templ files?

The answer to that is that the we have to manually map a token to a colour, and currently we aren't covering all cases: https://github.com/templ-go/templ-jetbrains/blob/main/src/main/kotlin/com/templ/templ/highlighting/TemplHighlighter.kt#L21

Thanks for your reply @joerdav
Are there any plans to add more of those cases so it will recognise types & structs etc?

No immediate plans no, I'll get round to it at some point now we have the ticked raised but it isn't a priority right now. But am open to PRs for this!

Not sure if it's my setup now but seems as if colour tokens are even more limited.
Is there something on the roadmap to make the colours the same?

Looks like html isn't being highlighted anymore in comparison to my first comment.


Parallelize execution of checks

Attempted solution for #167 to run the checks in parallel using Python's inbuilt concurrent.futures module. If any changes are required or alternate attempts at a solution, do let me know and I'll give it a shot.

Hi @a-r-r-o-w , did you benchmark gains in speed? This is unlikely to work due since the threads still share the Global Interpreter lock (GIL). So, this will take a similar time.


Fix travis build script

The Travis Build status is available at https://travis-ci.org/riyadparvez/data-structures-csharp

Hi Riyad,
The project build is not successful. The solution do have lot of errors. Shall I make few changes in the files and send you a PR as a whole. Please note that we need to change a lot of files.
Other solution would be Unload all the projects and load only the projects which are building successfully. There will be only change in the solution file.
My recommendation would be option 2.

NP. I did a lousy job when I've added some classes.
Thanks for the PR.


bugfix: Replaced inappropriate is comparison with ==

Introduction
This PR fixes a logical bug in your codebase
Description
In file gui.py, there's a comparison that compares an empty list to an object using is operator. This is not the correct way to compare objects with empty list or dict.
For example, running the code below will give the output:
x = []
print(x is [])

False

As a result, it's better to perform comparison using == operator than is.
Contribution
All contributions made in this PR follows Developer Certificate of Origin
Comments
If you think such fixes aren't necessary for your project, and you'd like me to find some better bugs / code-to-fix, then please let me know. I'll be happy to contribute.

No, this is super helpful. I'm left wondering why the linter didn't catch that.
Thank you.


Imply not using cache when invoking sync --update-all

Hi! This is an attempt to fix https://github.com/astral-sh/rye/issues/1128 by basically passing the --no-cache  to uv command on lockfile generation.
This should work exactly the same (https://github.com/astral-sh/uv/blob/8ae5c2aee3fa22ac7d11337688e4c1bee3748fe3/crates/uv-cache/src/cli.rs#L17) as adding UV_NO_CACHE=true as environment variable as the issue author tried in order to get the desired behaviour.

Interesting. Thanks for putting up a fix. You should be able to use --refresh instead of --no-cache, the latter will disable writes to the cache as well which is overkill. Not entirely sure if there's a better approach than that though without looking into the original issue further.

I'm still a bit confused about why this is necessary though.

I'm still a bit confused about why this is necessary though.

Got you, no problem. The use-case is described in the issue, so I thought that made sense

But if there's a new release, uv should upgrade to it without refreshing — unless it's been released in the last 10 minutes (which is the TTL for cache of the available releases). It might make more sense to just expose the --refresh flag in Rye. I think we'll need a clearer picture of the problem before it makes sense to change the uv invocation.


SliverAppBar don't scroll if another scroll widget is added

Steps to Reproduce
class HomePage extends StatefulWidget {
  @override
  State<StatefulWidget> createState() => HomePageState();
}

class HomePageState extends State<HomePage>
    with SingleTickerProviderStateMixin {
  TabController tabController;
  @override
  void initState() {
    super.initState();
    tabController = TabController(length: 2, vsync: this);
  }

  @override
  Widget build(BuildContext context) {
    Color tabColor = Theme.of(context).primaryColorDark;
    TextStyle tabStyle = TextStyle(color: tabColor);
    return SafeArea(
      child: Scaffold(
        body: CustomScrollView(
          slivers: <Widget>[
            SliverAppBar(
              title: Text("AppBar"),
              floating: true,
              primary: true,
              pinned: false,
            ),
            SliverFillRemaining(
              child: Scaffold(
                appBar: TabBar(
                controller: tabController,
                tabs: <Widget>[
                  Tab(
                    child: Text(
                      'Tab1',
                     style: tabStyle,
                    ),
                  ),
                  Tab(
                    child: Text(
                      'Tab2',
                    style: tabStyle,
                    ),
                  ),
                ],
              ),
                body: TabBarView(
                  controller: tabController,
                  children: <Widget>[
                    Scaffold(
                      body: Text('Tab One'),
                    ),
                    Scaffold(
                      body: ListView(children: <Widget>[
                        Text('Tab Two')
                      ],),
                    ),
                  ],
                ),
              ),
              ),
          ],
        ),
      ),
    );
  }
}

Logs
No errors in Log
[√] Flutter (Channel beta, v0.2.11-pre.17, on Microsoft Windows [Version 6.1.7601], locale en-US)
    • Flutter version 0.2.11-pre.17 at D:\Flutter\flutter
    • Framework revision dad6b4c884 (2 weeks ago), 2018-06-25 10:39:09 +0530
    • Engine revision 1ed25ca7b7
    • Dart version 2.0.0-dev.58.0.flutter-f981f09760

[√] Android toolchain - develop for Android devices (Android SDK 27.0.3)
    • Android SDK at D:\Android\Sdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-P, build-tools 27.0.3
    • ANDROID_HOME = D:\Android\Sdk
    • Java binary at: C:\Program Files\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1024-b02)
    • All Android licenses accepted.

[√] Android Studio (version 3.1)
    • Android Studio at C:\Program Files\Android Studio
    • Flutter plugin version 26.0.1
    • Dart plugin version 173.4700
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1024-b02)

[√] IntelliJ IDEA Community Edition (version 2018.1)
    • IntelliJ at C:\Program Files\JetBrains\IntelliJ IDEA Community Edition 2018.1.4
    • Flutter plugin version 26.0.2
    • Dart plugin version 181.4892.1

[!] VS Code, 64-bit edition (version 1.25.0)
    • VS Code at C:\Program Files\Microsoft VS Code
    • Flutter extension not installed; install from
      https://marketplace.visualstudio.com/items?itemName=Dart-Code.flutter

[√] Connected devices (1 available)
    • Android SDK built for x86 • emulator-5554 • android-x86 • Android 8.1.0 (API 27) (emulator)

! Doctor found issues in 1 category.

I use Android Studio for code.

Please add the output of flutter doctor

From the issue I don't understand what the desired effect is supposed to be. What behavior do you want?
If you're interested in an AppBar with Tabs, check out the demo in the gallery: https://github.com/flutter/flutter/blob/f62afdcf57c0a3e59f1837d905bc3a709d0686b9/examples/flutter_gallery/lib/demo/material/tabs_demo.dart#L140-L216

Desired effect:

Scrolling AppBar; so used SliverAppBar for this purpose and added two tabs in the same.
Both Tabs are having a scrolling element (like list view).
When we scroll in tabs the AppBar should also scroll with it.

In the code mentioned above the effect is different from one expected.
Actual effect:

When there is no scroll element in the tab one the scrolling of the AppBar works fine.
As soon as there is a listview in the tab two the AppBar neither scrolls up or down.
When we switch back to tab one then it is normal again.

I believe the code I linked to above does exactly what you want. Have you tried that?

I didn't saw this sample before. Works fine. Thanks

Looks like a support request that was solved.


Switch return type of main from 'void' to 'int'

As both C and C++ standards require applications running under an OS to
return 'int', adapt that for Zephyr to align with those standard. This also
eliminates errors when building with clang when not using -ffreestanding,
and reduces the need for compiler flags to silence warnings for both clang
and gcc.

Related discussion: https://github.com/zephyrproject-rtos/zephyr/issues/54336#issuecomment-1421528758

FYI @andyross @peter-mitsis @teburd @nashif @cfriedt

It makes sense, arguably a breaking API change though and needs to go through that? What happens with all the existing applications using void main(void)?

Yeah, it's "kinda" an API change. main isn't declared in any Zephyr header. If we don't adjust the compiler flags, then there's actually no impact on applications at all. The goal is to allow compiling using clang without -ffreestanding, and that requires that main return int.

Just to clarify, I think this should go in after the release, but 100% agree. Thanks!

Glad to see @stephanosio adjusted the milestone to 3.4.0 -- I wasn't sure what label to apply to make sure this wasn't considered for this upcoming release.

Aside from the occasional questionable return value (which others have already pointed out), I do not have any fundamental or design issues with what has been proposed.

Regarding return value usage and meaning:
Bootloaders are a ubiquitous example of an application needing to cleanly shut down the execution environment before handing the HW and CPU(s) off to another executable. To maintain a composable, scalable, and extensible architecture this clean shut down maps to a reverse SYS_INIT() which should be executed by the same thread that called SYS_INIT(). Thus, returning from main() can be very useful to trigger for a shutdown.
AFAICT, the shutdown sequence either succeeds or should cause a catastrophic failure (i.e., k_panic()/z_except_reason()). IF true, then this sequence has no need for the return value - returning from main() is sufficient to trigger the shutdown sequence. Shutdown parameters (e.g., the pointer to jump to upon shutdown, whether or not to reset upon shutdown, etc.) may be specific to the subsystems involved so shouldn't expect to be encodable in an int or passed via the return value.
It may be wise to leave meaning and usage of non-zero return values for native_posix, unit_testing, and/or emulation environments rather than let the Zephyr kernel try to take advantage of it.

If we merge this, we need to "revert" (and similar changes in other files for cmake/compiler/arcmwdt/compiler_flags.cmake):
commit 0f692f5b84db8ef61f1e85c6ef25278966dc3329
Author: Keith Packard<EMAIL_ADDRESS>Date:   Mon Feb 6 21:10:29 2023 -0800
compiler/clang: ignore main-return-type warning for clang

Arch WG:

This is a treewide change, so it requires an RFC issue and other processes to be followed (see https://docs.zephyrproject.org/latest/contribute/guidelines.html#treewide-changes), but no objections were raised
https://github.com/zephyrproject-rtos/zephyr/pull/54525 should be reverted if this is merged
prior discussion in https://github.com/zephyrproject-rtos/zephyr/pull/21100#pullrequestreview-325259287
discussion around to start, requiring 0 return value and reserve other values for future use (https://github.com/zephyrproject-rtos/zephyr/pull/54628#issuecomment-1431921596)
request to verify consequences of not changing the return type and document migration steps in release notes

Arch WG:
* This is a treewide change, so it requires an RFC issue and other processes to be followed (see https://docs.zephyrproject.org/latest/contribute/guidelines.html#treewide-changes), but no objections were raised

#56504

* [compiler/clang: ignore main-return-type warning for clang #54525](https://github.com/zephyrproject-rtos/zephyr/pull/54525) should be reverted if this is merged

These flags are removed as a part of this PR.

* request to verify consequences of not changing the return type and document migration steps in release notes

The only consequence of not changing that I'm aware of is that we will not be able to remove the -ffreestanding compiler flag when using clang as that has an un-skippable error for a non-int main return type (even if -Wno-main-return-type is specified). Consequences of the -ffreestanding compiler flag are discussed in PR #54638

(I've rebased and fixed the conflicts today)

If we merge this, we need to "revert" (and similar changes in other files for cmake/compiler/arcmwdt/compiler_flags.cmake):

This change is already part of this PR.

Setting DNM since this requires agreement before merging.

Please add an entry in the major changes sections of the release notes in: https://github.com/zephyrproject-rtos/zephyr/blob/main/doc/releases/release-notes-3.4.rst

Done.

Needs a rebase.

Needs a rebase.

Yup, all done. No significant conflicts found.

Will merge once approved in the TSC meeting today.

Removing DNM since the proposal in #56504 has been approved by the TSC.

@keith-packard there are no TSC objections to merging this. Could you rebase and address the missing ones that @nordicjm found? Thanks!

@keith-packard there are no TSC objections to merging this. Could you rebase and address the missing ones that @nordicjm found? Thanks!

rebased, repaired and re-pushed.

I just realized that we can add -Wmain to the compiler flags if we want to catch applications using the wrong type for main. This works with gcc even with -ffreestanding, but doesn't appear to work with clang with that flag.


version 0.3.27-dev2 fun "Narrative Memory Filter" not work on windows

Bug Report
Installation Method
[Describe the method you used to install the project, e.g., git clone, Docker, pip, etc.]
Environment

Open WebUI Version: [e.g., v 0.3.27-dev2]

Ollama (if applicable): /

Operating System: Windows 11

**Browser (if applicable):Edge128
issuse info:cannot import name 'CHROMA_CLIENT' from 'open_webui.config' (C:\Users\xxx\anaconda3\Lib\site-packages\open_webui\config.py)

but version 0.3.21 is work


old mixing didn't work

https://old.mydashwallet.org/Mixing
sent dash to mix, but never returned anything to my "Address to send to anonymously"

ouch now i open this issue, no longer anonymous :(

Hi,
please use<EMAIL_ADDRESS>to contact the support team and get
help, the initial transaction or address is all we need to check, both this
and the target address are deleted once the mixing is done.
Looks like your mixing request is still being processed, there have been a
lot of smaller mixings. It can take up to 12 hours if there is not enough
premixed Dash available at the time you start.
There is currently almost enough Dash premixed, but if that doesn't work,
the system will automatically credit even partially mixed Dash (remember
that we do not do the mixing, it is done by the Dash Masternode network and
out of our control how fast it goes, usually for small amounts it is mixed
in a few minutes).
Regards,
Benjamin
On Sat, Dec 28, 2019 at 3:22 AM Leon<EMAIL_ADDRESS>wrote:

https://old.mydashwallet.org/Mixing
sent dash to mix, but never returned anything to my "Address to send to
anonymously"
[image: dash_mixing]
https://user-images.githubusercontent.com/1692346/71537778-e93be200-295b-11ea-9058-d307f4cbba4e.png
ouch now i open this issue, no longer anonymous :(
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/DeltaEngine/MyDashWallet/issues/4?email_source=notifications&email_token=AAMS3TYOPBKVDCCVVM3QGLLQ22Z7PA5CNFSM4KAFPYLKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IC6HBRA,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAMS3TZLUCDC7AOZJQQ324DQ22Z7PANCNFSM4KAFPYLA
.

received.  thanks


Potential bugs when mmdetection runs on PyTorch < 1.8

Thanks for your error report and we appreciate it a lot.
Describe the bug
There is a small bug of  PyTorch (version < 1.8).
In short, when we use DataLoadr with num_workers != 0, these forked children process share the same numpy random seeds.
A toy example, run with PyTorch 1.6.
import numpy as np
from torch.utils.data import Dataset, DataLoader

class RandomDataset(Dataset):
    def __getitem__(self, index):
        return np.random.randint(0, 1000, 3)

    def __len__(self):
        return 8

dataset = RandomDataset()
dataloader = DataLoader(dataset, batch_size=2, num_workers=2)
for batch in dataloader:
    print(batch)

Output:
tensor([[437, 650, 998],  # process 0
        [108,  34, 197]])
tensor([[437, 650, 998],  # process 1
        [108,  34, 197]])
tensor([[153, 629, 103],  # process 0
        [695, 102, 728]])
tensor([[153, 629, 103],  # process 1
        [695, 102, 728]])

Currently, mmdetection sets different numpy seeds for different workers according to the worker_id. However, the worker processes are killed at the end of each epoch, and all worker resources are lost. At the next epoch, mmdetection will set the same seeds as the previous epoch.
Example:
import numpy as np
from torch.utils.data import Dataset, DataLoader

class RandomDataset(Dataset):
    def __getitem__(self, index):
        return np.random.randint(0, 1000, 3)

    def __len__(self):
        return 8

def worker_init_fn(worker_id):
    np.random.seed(worker_id)

dataset = RandomDataset()
dataloader = DataLoader(dataset, batch_size=2, num_workers=2, worker_init_fn=worker_init_fn)

print("the first epoch is ok")
for batch in dataloader:
    print(batch)

print("the second epoch is the same as the first epoch")
for batch in dataloader:
    print(batch)

Output:
the first epoch is ok

tensor([[684, 559, 629],
        [192, 835, 763]])
tensor([[ 37, 235, 908],
        [ 72, 767, 905]])
tensor([[707, 359,   9],
        [723, 277, 754]])
tensor([[715, 645, 847],
        [960, 144, 129]])

the second epoch is the same as the first epoch

tensor([[684, 559, 629],
        [192, 835, 763]])
tensor([[ 37, 235, 908],
        [ 72, 767, 905]])
tensor([[707, 359,   9],
        [723, 277, 754]])
tensor([[715, 645, 847],
        [960, 144, 129]])

Maybe we can use the solution of detectron2 or pytorch-image-models. They use a seed that changed dynamically with epoch, i.e., torch.initial_seed(), torch.utils.data.get_worker_info().seed.
Relevent issue: https://github.com/pytorch/pytorch/issues/5059
Environment
PyTorch 1.6.0

Thank you very much for your error report. In our case, we use a custom sampler when building dataloader. In the sampler, we set different seeds to each epoch and rank.
The code can refer to
https://github.com/open-mmlab/mmdetection/blob/master/mmdet/datasets/samplers/distributed_sampler.py#L11-L54

Actually, the problem is not related to distributed training (e.g., distributed_sampler)
As long as num_workers != 0, we will see duplicate data during training.
Please see the following example using mmdet.datasets.builder.build_dataloader.
import numpy as np
import mmdet.datasets.builder as builder

class RandomDataset(Dataset):
    def __getitem__(self, index):
        return np.random.randint(0, 1000, 3)

    def __len__(self):
        return 8

dataset = RandomDataset()
dataloader = builder.build_dataloader(dataset, samples_per_gpu=2, workers_per_gpu=2, shuffle=False)

for batch in dataloader:
    print(batch)

Output:
tensor([[301, 462, 262],
        [195, 738, 766]])
tensor([[301, 462, 262],
        [195, 738, 766]])
tensor([[347, 805, 531],
        [417, 946, 716]])
tensor([[347, 805, 531],
        [417, 946, 716]])

I reproduce the same problem according to this issue. And I have made a pr to fix it. Thank you again for this bug report.

@serend1p1ty Thanks a lot for your feedback. In fact, this problem exists in all PyTorch versions, and the official solution has been given.

no problem with spawn mode
the persistent_workers parameter was introduced in pytorch1.7, and this problem can be avoided as long as it is set to True.  But if you set it to false it will still appear

@serend1p1ty Thanks a lot for your feedback. In fact, this problem exists in all PyTorch versions, and the official solution has been given.

no problem with spawn mode
the persistent_workers parameter was introduced in pytorch1.7, and this problem can be avoided as long as it is set to True.  But if you set it to false it will still appear

Actually, not all PyTorch versions have this problem. After 1.9, the official has fixed it.
Yes, no problem with spawn mode. However, according to the offcial docs, torch.multiprocessing use the fork as the default method on Unix.
Even use persistent_workers, we still need to set a random seed for numpy in the first epoch. And this method is not compatible with earlier versions of PyTorch (emmm, I think not graceful enough). The official solution using torch.initial_seed() is a better choice.


format the eu/t number in the scanner data of the Naquadah reactor multi

@Alexdoru can you run update buildscript ?


Change the list of collaborators and maintainers

I would like to be removed from the list of collaborators of this project. I made only very small contributions to this project.
If we can fix some of the bugs (e.g. early stopping), then maybe I would reconsider. But for now, I would prefer not to be named

:+1:

@daryadedik @shansfolder ,
Apparently, I'm not in 'group Zalando'. I have given a +1, but I still get the following:

Pending — This PR misses 2 approvals from group zalando (0/2).

Coverage remained the same at 92.38% when pulling fd4ab5145aab850551b0220753848bd125a4aa3e on aaron-mcdaid-zalando:change-list-of-collaborators into 49a1ba3d9fdd786e08146f904a631f67484fd2d3 on zalando:master.

:+1:

👍

I seems that none of our +1 works

I seems that none of our +1 works

It seems like none of us can +1 this repo any more!
I see that the 'Zalando SE' organization on Github has a list of 181 People, including @psycho-ir (Soroosh) but not me nor @daryadedik nor @shansfolder !
I can't yet find any Octopus member other than Soroosh
Soroosh, can you +1 this? Hopefully, that will allow us to verify the theory and too get from "This PR misses 2 approvals from group zalando (0/2)" to "This PR misses 1 approvals from group zalando (1/2)."
Then, we need to follow up with getting some Octopus members into the correct organization!

👍

👍

@aaron-mcdaid-zalando
Sorry I missed your comment.
it did count my thumbs-up.

Mine +1 doesn't work :(


Transfer queue validator

What changed?
Implement transfer queue validator

Why?
Validator for checking if all persisted transfer tasks are loaded and if the load request is continuous

How did you test it?
Tested in staging2

Potential risks
The validation may increase the latency for task loading.

Coverage decreased (-0.04%) to 61.336% when pulling 337701e5a7c7a4d67a2fca92424d157b56adc16c on yycptt:tx-queue-validator into 6a8e9a385bf9e1d4cf6b15a4c533c80bce258073 on uber:master.

Coverage decreased (-0.04%) to 61.336% when pulling 337701e5a7c7a4d67a2fca92424d157b56adc16c on yycptt:tx-queue-validator into 6a8e9a385bf9e1d4cf6b15a4c533c80bce258073 on uber:master.


fix: recommended config

PR Checklist

[x] Addresses an existing open issue: fixes #102
[x] That issue was marked as status: accepting prs
[x] Steps in CONTRIBUTING.md were taken

Overview

This PR fixes "plugin:package-json/recommended" to work and adds a test case to check the fix.

@all-contributors please add @ota-meshi for code.

🤖 Beep boop! This comment was added automatically by all-contributors-auto-action.
Not all contributions can be detected from Git & GitHub alone. Please comment any missing contribution types this bot missed.
...and of course, thank you for contributing! 💙

https://github.com/all-contributors please add @ota-meshi for code.

@all-contributors please add @ota-meshi for code. 😠


Memory grows unless GIL is released

I got a problem, which I'm not sure is a bug, but I haven't found a way to solve it, unfortunately.
Here is some example code:
use pyo3::prelude::*;

static CODE: &str = "
def main():
    pass
";

fn main() {
    let gil = Python::acquire_gil();
    let py = gil.python();

    if let Err(e) = run(CODE) {
        e.print(py);
    }
}

fn run(code: &str) -> Result<(), PyErr> {
    let gil = Python::acquire_gil();
    let py = gil.python();

    py.run(code, None, None)?;
    let main = py.import("__main__")?.get("main")?;

    for _ in 0..200000000 {
        main.call0()?;
    }
    Ok(())
}

Running this in release mode causes process memory to grow up to gigabytes. I have found that the problem does not occur if the GIL is acquired an released in each iteration of the loop. However, that also means I have to get a reference to the main python function every time again (using py.import("__main__")...), which causes the code to run much more slowly.
Not knowing much about the internals, I don't know if this is a memory leak, or intended behavior. I tried to debug using valgrind as described here, and there is a lot of output compared to very few false positives (still), when running the same code in a native python script. I can post the output here if necessary, but I'm not sure if it is relevant.
I'm running Ubuntu 18.04 with python 3.6.7. Rust version is 1.33.0-nightly (a8a2a887d 2018-12-16), and I'm using pyo3 master (0deaee01ad9d538b9865a578840a4bc18b32c3da).

See #311

Thanks


Arrows by previous/next links

Originally created by Tom Smyth at 2015-08-19 03:06, migrated from redmine-#2889

Priority changed from 4 to 3

By Tom Smyth at 2015-08-19 07:19

Priority changed from 3 to 2

By Tom Smyth at 2015-08-27 18:10

Status changed from New to Closed

By Tom Smyth at 2015-08-30 01:40


undefined is not an object in react-native-material-ui

Hi, I found an error while using this.
when I added "import { COLOR, ThemeProvider } from 'react-native-material-ui';" to my App.js file.. it throws undefined is not an object(evaluating '_react2.PropTypes.oneOf')
how can I get rid of this error????
here is the screenshot of an error.

I cloned and I executed the demo successfully, but when i add react-native-material-design in a new project, i got the same problem. Someone know how to resolve that?

The problem occurr because react-native-vector-icons is out of date. PropType was deprecated in react package, from now we need to import PropType from prop-types package.

Thanks @ebonventi - But can you please clarify what is the solution for this case?

@chenop it appears that you need to upgrade the React Native Vector Icons module to a new version supporting the removed PropTypes from react

Hi I am facing the same error . I have use this react version
react-native-cli: 2.0.1
react-native: 0.55.3
can you guide me to solve issue

I recently updated all dependencies - let us know if you still have a problem. https://github.com/xotahal/react-native-material-ui/releases/tag/1.30.0


Publish 1.18 to NPM

<EMAIL_ADDRESS>shows 1.18 release hasn't been published yet

cc @rmeissner @moisses89

I need v1.18.0

done<EMAIL_ADDRESS>


feat: store data to google drive

feat: add upload data to the drive logic
feat: add download data from the drive logic
fix: some cleanup and error handling
Describe your changes
Hi.
I've added the basic functionality to store/retrieve database data to/from Google Drive using Application Data Directory
Address
I don't know react, so it is a MVP implementation, following issues come to mind:

The code might need some adjustments in terms of error handling, I've commented on places it applies
The Google auth procedure can use some state management.

Testing/validation

Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)

[x] I have commented my code, in hard-to understand areas.
[x] I have made corresponding changes to README or wiki.
[x] For front-end changes, I have updated the corresponding English translations.
[x] Ran yarn run mini-ci locally to validate format + lint.
[x] If there were format issues, I ran nx format write to resolve them automatically.

Hey @Mahanmmi Thanks for your work on this feature. I see there are  some additional work with the UI, so I'm going to merge it into a branch. We will also have to take some time to get the site verified on Google. If you are interested to , so can set up additional PRs against the branch.

Hi, I've already applied to requested changes to the UI unless you are talking about another changes that I'm not aware of.
If there are anything you have in mind I'll try my best to provide my assistance to see it done.


Count of selected items

How do you count the number of selected items via a checkbox in ReoGrid? I tried grdFactorData.CurrentWorksheet.SelectionRange.Rows but this returns the count of highlighted rows.

You may have to use your own logic to count the selected items like this:
int count = 0;
for (int r = 0; r < 10; r++){
  if (sheet[r, 4] is bool selected) count++;
}

Thanks for post.


#5155 adding margin when scrolling to desktop only

Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.
PR Type

[x] Bugfix
[ ] Feature
[ ] Refactoring

Context

[x] Closes #5155
[ ] Requires deployment <>

Before submitting pull request, please make sure:

[x] My contribution builds clean without any errors or warnings
[x] I've merged recent default branch -- main and I've no conflicts
[x] I've tried to respect high code quality standards
[x] I've didn't break any original functionality
[x] I've posted a screenshot of demonstrated change in this PR

Optional

[ ] I've tested it at </bsx/collection>
[ ] I've tested PR on mobile
[ ] I've written unit tests 🧪
[ ] I've found edge cases

Had issue bounty label?

[x] Fill up your KSM address:
Payout

Community participation

[x] Are you at KodaDot Discord?

Screenshot 📸

[x] My fix has changed something on UI; a screenshot is best to understand changes for others.

I would increase .sticky top value instead

@roiLeo tried doing that, did not work as expected

https://github.com/kodadot/nft-gallery/blob/c9072d63895d09d4194528a336b4b942aa70b53a/components/explore/SidebarFilter.vue#L28-L33
maybe if we change the two 72px value it should do the work

that is still too much no? You are scrolling like 4 px over, It should scroll only over the stroke and stop

pay 10 usd

😍 Perfect, I’ve sent the payout
💵 $10 @ 30.07 USD/KSM ~ 0.333 $KSM
🧗 EzGc4s9PgCPx1YnF3fqzhLzVHpHMTL4LWPScwpDrR8JKgSU
🔗 0x250ad5b23edd9d1a7b87c85e1acd02121241e96e7ac1fb376ba2cc2913727065
🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@vikiival we can close this one


Added Wrangler Workflow and an example to configure workflow prerequisite jobs condition

Added Wrangler Workflow (pdf) and examples to configure cas workflow prerequisite jobs condition. Linked to #53 and OODT PR #35

@karanjeets fyi my comments

@chrismattmann I was wondering, I didn't change this part but I think, I missed #64. Sorry about that.
The changes are updated in PR. Hopefully, everything is good now.

thanks buddy @karanjeets


Missing prots in davis_aflow

Davis issue with missing proteins in aflow

the # of missing proteins in aflow makes no sense, it should be closer to $79*68=5372$, but instead its around $29852 - 21284=8568$ (almost double!)
Looking at the csv files we also note some weird behavior:

None of the csv files have mutated proteins (total number of proteins with mutations is 75 from pd.read_csv('../data/DavisKibaDataset/davis/nomsa_binary_original_binary/full/XY.csv').prot_id.str.contains('\(').sum()/68). But in any of the "aflow" splits we have no mutated proteins!
Could be due to how we check for aflow. is "(" being properly escaped in the Dataset init?

Two possible issues:

[x] "(" is not being properly escaped when we check for aflow files in (this seems the most likely) https://github.com/jyaacoub/MutDTA/blob/dd324d33ae001c0126c3c2aceba895a16944fb5a/src/data_prep/datasets.py#L751-L760
[x] We used the wrong sequences and they are running into mismatch errors when filtering out prots in  https://github.com/jyaacoub/MutDTA/blob/dd324d33ae001c0126c3c2aceba895a16944fb5a/src/data_prep/datasets.py#L354-L360

Issue resolve by https://github.com/jyaacoub/MutDTA/commit/20c9343160b28992648a367bd9f4e042b9abd1a0, it was due to the wrong path being used in https://github.com/jyaacoub/MutDTA/blob/20c9343160b28992648a367bd9f4e042b9abd1a0/src/data_prep/datasets.py#L923-L931
Since the default was to use the colabfold path in https://github.com/jyaacoub/MutDTA/blob/20c9343160b28992648a367bd9f4e042b9abd1a0/src/data_prep/datasets.py#L770-L783


How can i reset the multiselect  by a default value

Hi
In my controller i have this :
$scope.time= [
			{
				name: "ALL",
				valueBefore: "",
				valueAfter: ""
			},
			{
				name: "T",
				valueBefore: formatDate(dateT1),
				valueAfter: formatDate(dateT)
			},
			{
				name: "T+1",
				valueBefore: formatDate(dateT2),
				valueAfter: formatDate(dateT1)
			},
			{
				name: "T+2",
				valueBefore: formatDate(dateT3),
				valueAfter: formatDate(dateT2)
			},
			{
				name: "T+3",
				valueBefore: formatDate(dateT4),
				valueAfter: formatDate(dateT3)
			}
		];

In my page.html i have this :

										QUARTER :
										<div
											angular-multi-select
											input-model="timeEpics"
											output-model="timeSelected"
											item-label="<[ name ]>"
											button-template="angular-multi-select-btn-data.htm"
											button-label="<[ name ]>"
											tick-property="checked"
											helper-elements="nofilter noreset"
											selection-mode ="single"
											on-item-click="getTimeEpics(timeSelected[0])"
										>

										PROJECTS :
										<div
											angular-multi-select
											input-model="columnTabEpics"
											output-model="columnTabEpicsSelected"
											item-label="<[ name ]>"
											button-template="angular-multi-select-btn-data.htm"
											button-label="<[ name ]>"
											tick-property="checked"
											helper-elements="nofilter noreset"
											selection-mode="single"
											on-item-click="getActiveTabEpics(columnTabEpicsSelected[0].value)"
										>

But when i change the value of "PROJECTS :" by click , i want to reset the multiselect of the "QUARTER " to "All" but i don't success to do that.
BTW : i can do that in the controller :
//get the value of select in quarterEpic
 $scope.quarterEpic = timeEpic;

 // if i want to reset the multiselect in my case ( in this case , it's a single select config)
 $scope.quarterEpic = "";
 $scope.timeEpics[0].checked=true;

But even if  $scope.timeEpics first element has checked to true, on my screen, the last element checked stay checked :/. If it was "T", that stay on the "T" checked even if the content is show for "All" option ...  I hope you will understand my problem :)
Thank you in advance :)

OK i close this issue because i refound my way to see the problem, this issue is not anymore a problem  ;)


Script to pull down test data from box into test-data directory

Ask Dav for details if unclear!
cc @jaysid95

test data is now stored directly in the repository. Settings are probably inefficient on the HDF5 file, but better something than nothing...


Sample/Doc for pipeline module(s)

Most of the questions we get for "how do I?" with the proxy can be solved with a custom middleware component. Although we have a samples folder - that is more of a scratch pad for the teams internal experiments - it is not documentation for what you can do and how you should do it as a middleware component. For example, can you create new destinations on the fly, can you lookup the destinations for a backend cluster and swap those in.
This should cover:

What properties existing pipeline stages operate on, and write out -> so that you know where to insert your module
Reading from config
Modifying destinations for a request
Reading and modifying headers before the request is sent to destination
Reading and modifying headers before the response is sent to the client

Duplicate of #114


Clear button (X) in Search Text not themed correctly

In dark mode you can't see it

Update to latest Xamarin.Forms fixes android. But still needs work on iOS


Changes the README to uphold the sancity of human life

A small change to the README which replaces the word execute with run in order to avoid  potential confusion of whether the awkward connotation of summarily executing the current director of studies of the CSE bachelor. The change proposed still is relatively vague on what it does. However the potential implementation of the program would, in the worst case, help professor Zaidman with his cardio as opposed to starting an autonomous swarm of murder robots.

LGTM!

Hahaha, great PR!

This is a high-quality PR :grin:


Documentation for flashing

I am having a hard time figuring out how to flash the qmk .bin file - tried stm32cubeprogrammer, no luck. Trying with qmk compile now.
Would be nice with some docs on how to do it.

got it to work via https://github.com/dcpedit/vial-qmk/tree/pillzmod/keyboards/dcpedit/pillzmod and
make dcpedit/pillzmod/standard:default:flash
but that image does not show up in vial/via - in macos i get "wrong version". maybe the jsons needs a small update?


Use Sentry only for errors

Sentry has a bunch of fancy tracing features that we're not using.
To keep things simple, let's just disable them.

@ansh this look okay to you?

@pfrazee Yeah this is fine.
We can use those Sentry features when sentry-expo implements them.


[Feature] Add integration test CI workflow

Is this your first time submitting a feature request?

[X] I have read the expectations for open source contributors
[X] I have searched the existing issues, and I could not find an existing issue for this feature
[X] I am requesting a straightforward extension of existing dbt-adapter functionality, rather than a Big Idea better suited to a discussion

Describe the feature

Add integration tests
Pull in dependencies (e.g. dbt-tests-adapter, dbt-postgres)
Build workflow

Describe alternatives you've considered
No response
Who will this benefit?
No response
Are you interested in contributing this feature?
No response
Anything else?
No response

For now, integration tests will simply run in dbt-postgres. We're not pulling that package back down to dbt-adapters. We may revisit this at a later date, but with integration tests running in dbt-postgres, this is effectively complete.


"Transport to zip": don't serialize objects that are not in the transport request

In large. packages this can improve the performance considerably.
Actual situation: first all the package objects are serialized and then, the filter (from the transport request objects) is applied.
Proposed solution: Read all the package objects. Apply the filter. Serialize.
Actually working in this solution. What I've noted so far and need to clarify before creating a PR is that in the actual situation, a ".abapgit.xml" is not being generated (because it is deleted when filter is applied). With the proposed solution the ".abapgit.xml" is being generated and not deleted. So, what I'm not sure of, is that if that file is necessary to add to the zip file.

I have all the changes in this branch: issue553.

@larshp I tested the case you mentioned in #544 and it works as expected:

Note that if the transport contains 2 objects one in the top package and one in a child package, I expect this to be reflected in the folder structure, like when exporting the entire package to zip.

I need to do more tests, specifically online repository tests. I've been working just with offline repositories because of connection problem.


Aligning syntax with MockK's

Summary
This pull request aims to align Mockative syntax more closely with MockK's. The changes introduced here will help reduce friction for developers transitioning from MockK to Mockative.
Proposed changes
1. Infix notation support (backwards compatible)
Enabled infix notation for invokes, returns and throws.
coEvery { api.getUsers() } returns users

2. Expectation parameters as verify arguments (breaking change)
Moved expectation parameters within verify arguments instead of chaining, aligning verification with MockK's approach. Also, developers can easily forget to chain wasInvoked() which will cause the verify block to be ignored.
verify { /* ... */ }
verify(exactly = never) { /* ... */ }
coVerify(atLeast = once) { /* ... */ }

3. Replacement of doesNothing with justRun (breaking change)
Replaced doesNothing with justRun for conciseness and to align with MockK's terminology.
justRun { user.deactivated = true }

4. Renaming of verifyNoUnverifiedExpectations and verifyNoUnmetExpectations (breaking change)
Renamed verifyNoUnverifiedExpectations to confirmVerified and verifyNoUnmetExpectations to checkUnnecessaryStub to align with MockK's terminology.
@AfterEach
fun afterEach() {
  confirmVerified(api)
  checkUnnecessaryStub(api)
}

Thank you for your suggestion @alexandrefavre4!
Truth be told I need to think about whether I like aligning even more with MockK. There are parts of MockK's API I don't think are as intuitive as the APIs I provide in Mockative, examples of which you have provided in the description of this PR. I don't necessarily think it has been an overall positive thing to align with MockK when I introduced the every function in Mockative 2, as the previous implementation of Mockative did have a substantial advantage in the sense that it doesn't need to do any fancy tricks to support its API.
It would be possible to release a mockative-mockk module that provides MockK aliases for many of the APIs in Mockative.
In summary, now that I'm resuming maintenance of this project, I need to determine if I want Mockative to stand on its own as a competitor to MockK on the JVM, or whether I want it to be more like "MockK for KMP".

Just my two cents about verify(exactly = x).
When migrating from Mockative 1.x to Mockative 2.x, I used tons of Find/Replace + RegEx to do it.
I slowly realised that in many places there was missing a .wasInvoked, so there was no assertion at all.
So I'm here just to testify that: yes, unfortunately it can be forgotten.

Other than that, I really don't care much about the differences between MockK and Mockative. Having independent approaches might be best than just blindly following someone else's footsteps.
I'd just like to avoid pitfalls like this whenever possible.

Thank you for your input @vitorhugods
It's a good point that one could forget to call verify, and a great argument for considering changing it. There is a way where I could retain the current API, but also make verify { ... } without .wasInvoked() implicitly be wasInvoked(atLeast = once). I'll have a look at addressing that case in an upcoming release!

Now, while we're on the subject of the verify { ... } function I figured I wanted to share my thoughts through my experience over the past few years...
Regardless of what the documentation currently states I believe that you don't need to call verify { ... } as long as:

You're not using stubsUnitByDefault = true
You call verifyNoUnmetExpectations after every test
I introduce a way to mock an exact number of invocations (e.g. returnsOnly(...))

A test of a function in the SUT returning Unit would thus look like this:
@Test
fun myTest() {
    // Given
    every { api.star("mockative") }
        .returnsOnly(Unit)

    // When
    val result = runCatching { service.star("mockative") }

    // Then
    assertSuccess(result)
}

@AfterEach
fun afterEach() {
    veryNoUnmetExpectations(this)
}

And any calls that haven't been stubbed, as well as any stubbed calls that haven't been called, would now produce an error.
Now, I realize that this differs from patterns that are often taught in books, articles, and tutorials, where using a verify function is often encouraged. Through my experience, I have simply come to learn that I never need the call to the verify function as long as I use verifyNoUnmetExpectations (or alternatives from MockK or Mockito).
Because of this, I am torn between whether Mockative should be its own thing, trying to rethink what a JVM mocking framework should be (e.g. deprecating and later removing the verify { ... } function to promote a different way of thinking), or whether it should "just" be "MocKK for KMP". Since Mockative is already released, and has a significant number of stars (and presumably usages), I can't help but feel an obligation to support an API that feels familiar to consumers of the framework, regardless of whether it aligns with my personal preferences and beliefs of "correctness" 🤷🏻♂
From a technology point of view, Mockative is already fundamentally different from MockK and Mockito since Mockative uses code generation to provide mocks, whereas MockK and Mockito use runtime bytecode generation.

Totally understand your point @Nillerr. Looking at the API, I got the feeling that Mockative wanted to position itself as MockK for KMP, that is why I thought that closing the gap could help consumers as it would for the company I work for.
@vitorhugods I definitely agree with you, Mockative shouldn't blindly follow MockK footsteps. Coming back to the proposed changes, I think that points 1 and 2 still add value other than aligning with MockK. For point 1, some people find infix notation more readable. It's definitely a low hanging fruit to me, as it doesn't impact the current API. For point 2, I think we all agree that verify(...) has some benefits over wasInvoked(...) (e.g. can't forget wasInvoked, conciseness). For points 3 and 4, main benefit is to have the API more closely aligned with MockK. Now, I personally find checkUnnecessaryStub/confirmVerified clearer than verifyNoUnmetExpectations/verifyNoUnverifiedExpectations (too many negations 😵💫) and have a slight preference for justRun over doesNothing, but I guess that's a matter of personal preferences.
I propose you that we close this pull request and that we proceed with the following steps:

We skip points 3 and 4 for now - Up to you to consider these changes according to your vision for Mockative
I create another pull request for adding infix notation support
I create another pull request and keep only changes for point 2 and try to see how we could retain the existing API

About your thoughts on verify, we could indeed skip verify statements when these conditions are met. However I think that verify helps the test to be more explicit (e.g. I want to this specific function call to be made) and errors are also more explicit than getting MissingStubSomething exceptions. Finally it also helps in readability by having the verification done in the then block, next to the assertions.

Infix notation support has been added (see https://github.com/mockative/mockative/pull/100). I'll look into point 2 when I have some time.

Infix notation support has been added (see https://github.com/mockative/mockative/pull/100). I'll look into point 2 when I have some time.


a11y: dropdown is not after the trigger in the tab order

Describe the bug
When I navigate with the keyboard and open the dropdown, I need to tab backwards (Shift + Tab) to get inside the dropdown.
To Reproduce
Steps to reproduce the behavior:

Go to the dropdown demo
Tab to the dropdown trigger
Open the dropdown and press Tab. You are not inside the dropdown and the "see code" accordion is focused instead

Expected behavior
The dropdown appears after the trigger in the tab order. For the demo page, when I hit Tab after opening the dropdown, the "Dismiss dropdown" inside the dropdown is focused.

Since we are going to be moving to the aria rules implementation of keyboard navigation this will no longer be required.

@jason-capsule42 can you elaborate on this? Is there an issue open to track this work?

@geoffrich there is another track of work related to refactoring the a11y interface of the component where this will be addressed.


Feature - meta descriptions

Added meta descriptions to all pages
Updated Page component to accept title and description to apply to header
Updated content context page title helper to append site title to all pages except homepage

Currently this PR has content hardcoded in [page].js - ideally this would be pulled from CKAN.
Also the page title "Current standards" will be updated to "Published standards" in a separate PR, as this is fairly spread around.


Set SO_LINGER in integration tests.

Motivation:
We now have sufficiently many integration tests that the number of TCP
sockets in TIME_WAIT begins to cause resource pressure on the system.
This can lead to the integration tests failing due to being unable to
assign a socket.
We can force this to not happen by disabling linger. As we're running on
a lossless fabric (localhost), this is entirely safe.
Modifications:

Disable TIME_WAIT for integration tests.

Result:
Integration tests will pass.

@weissi please re-review in the context of the new allocation counter changes.

@swift-nio-bot test this please

@swift-nio-bot please test this

@swift-nio-bot test this please


chore(docs): update link

@josephgardner  https://helmfile.readthedocs.io/en/latest/#templating could you add include into that section?


Server_password vs UserGroups password

Is there an existing issue for this?

[X] I have searched the existing issues

Question
Hey! I have the same error using the docker-compose example, can confirm that the server_password variable is not written in enshrouded_server.json
I made sure that all files are owned by my user (1000:1000) and the PUID and PGID are correct.
Following what said @Nitrocrusher in #66 I tried to login using the userGroups password (wich is not the same as server_password) and it worked.
Is it supposed to work like this? UserGroups password overriding server_password ?
docker-compose.yml
services:
  enshrouded:
    image: mornedhels/enshrouded-server:latest
    container_name: enshrouded_proton
    hostname: enshrouded_proton
    restart: unless-stopped
    stop_grace_period: 90s
    ports:
      - "15637:15637/udp"
    volumes:
      - ./data/config:/opt/enshrouded
    environment:
      - SERVER_NAME=Enshrouded Server
      - SERVER_PASSWORD=MyPassword
      - UPDATE_CRON=*/30 * * * *
      - PUID=1000
      - PGID=1000

Ok I'm dumb, I found Server Roles Configuration
It is indeed how it's suposed to work. Might need to update the readme for dumb peoples like me ^^
Closing the issue then.
Regards.

Hey @OnigamiSama,
what do you mean exactly by UserGroups? Do you mean the server-roles?
If so, then yes - the SERVER_PASSWORD  is pretty much ignored. The environment variable SERVER_PASSWORD is only used for the first initial generation of the enshrouded_server.json

Jeah, it is not clear what the SERVER_PASSWORD does and now only works for the initial creation of the .json file.
I'll try to make the README more clear, that it is more or less deprecated.


Support for container.labels field

Corresponding cattle PR: https://github.com/rancherio/cattle/pull/415

@cjellick @sonchang

LGTM

@alena1108 can you rebase and then I'll merge


Deprecation: render_hash_as_hidden_fields

DEPRECATION WARNING: render_hash_as_hidden_fields is deprecated and will be removed from a future release (Use Blacklight::HiddenSearchStateComponent instead). (called from block in _app_views_catal
og__search_form_html_erb___823158628989550518_70228025109240 at /Users/eliotj/Documents/Repositories/dpul/app/views/catalog/_search_form.html.erb:4) (43 times); e.g.:
    /Users/eliotj/Documents/Repositories/dpul/app/views/catalog/_search_form.html.erb:4:in `block in _app_views_catalog__search_form_html_erb___823158628989550518_70228025109240'
    /Users/eliotj/.asdf/installs/ruby/2.6.5/lib/ruby/gems/2.6.0/gems/actionview-<IP_ADDRESS>/lib/action_view/helpers/capture_helper.rb:41:in `block in capture'
    /Users/eliotj/.asdf/installs/ruby/2.6.5/lib/ruby/gems/2.6.0/gems/actionview-<IP_ADDRESS>/lib/action_view/helpers/capture_helper.rb:205:in `with_output_buffer'
    /Users/eliotj/.asdf/installs/ruby/2.6.5/lib/ruby/gems/2.6.0/gems/actionview-<IP_ADDRESS>/lib/action_view/helpers/capture_helper.rb:41:in `capture'
    /Users/eliotj/.asdf/installs/ruby/2.6.5/lib/ruby/gems/2.6.0/gems/actionview-<IP_ADDRESS>/lib/action_view/helpers/form_tag_helper.rb:72:in `form_tag'

Fixed.


Notes not retrieved from server

Hi,
I've been trying to use pyzotero to interact with the zotero server and automate a few actions. So far this has been going fine but I seem to have hit a roadblock with notes.
Checking the documentation and the code there aren't many but a few references seem to point out that notes should also be fetched from the server.
I've tried different things including the everything method but the returned list/dicts doesn't contain notes (tab next to 'tags'). I do get a note when it is associated with a file (i.e. PDF) but not when it's associated with an item (parent of PDF and Notes - don't know the exact term).
So the question is, how do I fetch these notes?

There are two ways:

If you know what items you want to fetch notes for, you can retrieve them, then get their child items using .children(itemID, itemType=Note)
If you want notes for your entire library, you can wrap .items(itemType='Note') in an everything() call, though this might take a long time / result in rate-limiting, depending on the size of your library.

In either case, the key part is filtering by itemType.


Migration to System.Text.Json

I think it would be really great to migrate from Newtonsoft.Json to System.Text.Json. The latter is more performant than the former, in addition to being the library officially maintained by Microsoft.
If the creators are interested, I can try to help by working on this change and making a pull request.

I'm open to it! I don't believe it's a trivial migration however, especially in the realtime-csharp and postgrest-csharp repos, there are some Newtonsoft specific implementations that would need to be converted. But if you're willing to open a PR, please do!

FWIW Unity also has a (slightly different) hacked up version of Newtonsoft (because of course<EMAIL_ADDRESS>I was able to get postgrest etc working using the Unity Newtonsoft instead and it seems they are binary compat. Out of curiosity do you happen to recall what was Newtonsoft specific? Guessing it's more than a call to serialize/deserialize?

@wiverson sure!
For Postgrest: its the PostgrestContractResolver.cs and the Converters.
For Realtime: its the CustomContractResolver and the Converters.
Outside of those, everything should transfer pretty easily. But they are (obviously) all tied to core functionality.

I've tried forking the repository, but I can't; probably because of the modules folder that references other projects. I tried to google a way to make a fork in this scneario, but I didn't find anything. If anyone can give me some guidance, I'd appreciate it.

Would love to see this migration.


Pass variables from Build pipeline to Release

I have traced many articles but not getting clear idea.
I am using azure build pipeline to set a variables and consume the same variable in azure releases by point the build as artifact in releases.
trigger:
  - base

pool:
  name: Default

steps:
  - checkout: self
    persistCredentials: true

  - task: Bash@3
    displayName: "SetVer"
    name: "SetVer"
    enabled: true
    inputs:
      targetType: "inline"
      script: |
        echo "##vso[task.setvariable variable=baseImageTag;isOutput=true]1.0.0"

  - task: Bash@3
    displayName: "printVer"
    enabled: true
    inputs:
      targetType: "inline"
      script: |
        echo "echoinggg"
        echo $(SetVer.baseImageTag)

in the second task i am able to consume the baseImageTag but the same variable i am not able to consume in releases.
Thanks all

Hi @sjdhanasekaran,
The values of pipeline variables can vary between different runs or jobs as it stated in the documentation

The value of a variable can change from run to run or job to job of your pipeline.

If you're using a release pipeline, therefore you have no access to YAML pipeline's variables and their values.
If you need to use a pipeline variable, you may use another deployment strategy, such as defining a deployment stage in a YAML pipeline

@ivanduplenskikh Clear. Thanks


Can't build PWA on Visual Studio 2019.

The C# Windows Application Packaging Project template doesn't have "Start page" entry in package.appxmanifest.
It just had only "Entry point".
on this document:

what actually happens:

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c306f3b9-d287-beba-eb3b-513e58df2440
Version Independent ID: 787855c5-24d2-b772-e4c3-ce43118e5adb
Content: Tailor your PWA for Windows - Microsoft Edge Development
Content Source: microsoft-edge/progressive-web-apps-edgehtml/windows-features.md
Product: microsoft-edge
Technology: pwa
GitHub Login: @MSEdgeTeam
Microsoft Alias: msedgedevrel

Hi @sprout2000, sorry to hear about this issue. We've added a clarifying note to the documentation - the link is below. At the moment, VS2019 does not include the template.
https://github.com/MicrosoftDocs/edge-developer/pull/832/files

@Reezaali
Thank you so much for you answer.
I will try VS2017.

@Reezaali this doesn't seem to work in 2017 either:

@asklar thanks for reaching out. We've updated the doc with the correct project template to be used. Thanks.
https://github.com/MicrosoftDocs/edge-developer/pull/852/files

@Reezaali  I appreciate the update but... the end-to-end instructions are still wrong. Can we have someone walk through this getting started? For example, the instructions/screenshots show an Express app but there is no such thing. If I choose the new template that was just updated, then the app that gets generated just points to example.com, there is no client side javascript code to go modify. How do I build a PWA from scratch with VS (ideally 2019 but can live with 2017) ?

@asklar If you're just getting started with building a PWA, you're looking at the wrong article.
If you're wanting to build a new PWA, go to pwabuilder.com, click Get Started, then Download:

PWABuilder is Microsoft's tool for creating PWAs and optionally publishing your PWA into app stores like Microsoft Store, Google Play, Mac Store, and more.


The extended partition (if any) may not be the last on the disk.

Connects to #19
Change-Type: minor

How come #17 modifies build/partitioninfo.js but this PR doesn't?

@lurch
About build/*.js: good catch, that's because I didn't run npm install that generates the js files.

Great to see updated documentation :+1:


Hidden errors are displayed anyway

The hideWarning property of SMLSyntaxError is not always observed when creating highlights and buttons.

There are @todos in the code about this.

Fixed in #24.


remove CONTRIBUTORS file

Google no longer recommends CONTRIBUTORS files for projects, since this
data is better retrieved directly from version control.
Additionally, contributors are now instructed to add themselves (or
their employer, if appropriate) to the AUTHORS file, rather than the
maintainers being responsible for trying to keep this file up to date.
Ultimately, this should result in more accurate data, since in most
cases we don't know whether the code is copyright the contributor or
their employer.

Additionally, contributors are now instructed to add themselves (or
their employer, if appropriate) to the AUTHORS file, rather than the
maintainers being responsible for trying to keep this file up to date.

If I may, I would like to suggest that this be a part of some CI target. It would fail if the AUTHORS file excludes the information from the author's commit. Additionally, it should be indicated whether that change should be in a separate commit or all part of the same commit.
👍

If I may, I would like to suggest that this be a part of some CI target. It would fail if the AUTHORS file excludes the information from the author's commit.

It is not a requirement that every author must be identified in this file.  The history of this file (in Google projects in general, not necessarily go-github in particular) is more for corporations that would like to have their contributions to open source projects be recognized, which are often not apparent just looking at the commit history.

Additionally, it should be indicated whether that change should be in a separate commit or all part of the same commit.

Either is fine.  In practice, I don't expect this file to see a super high rate of change, so we can just see how it goes.

I like this change a lot because it removes a manually maintained file which contains information that can be inferred automatically from git history. It's also one less file in the top level directory (without any loss of functionality). 🎉
LGTM.


⚠ Bofrost.fr has degraded performance

In 08d2fd1, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 1205 ms

Resolved: Bofrost.fr performance has improved in 10c7ee9 after 10 minutes.


No response when send a request

Thanks for stopping by to let us know something could be better!
PLEASE READ: If you have a support contract with Google, please create an issue in the support console instead of filing on GitHub. This will ensure a timely response.

Is this a client library issue or a product issue?
This is the client library for . We will only be able to assist with issues that pertain to the behaviors of this library. If the issue you're experiencing is due to the behavior of the product itself, please visit the  Support page to reach the most relevant engineers.

Did someone already solve this?

Search the issues already opened: https://github.com/googleapis/nodejs-dialogflow-cx/issues
Search the issues on our "catch-all" repository: https://github.com/googleapis/google-cloud-node
Search or ask on StackOverflow (engineers monitor these tags): http://stackoverflow.com/questions/tagged/google-cloud-platform+node.js

Do you have a support contract?
Please create an issue in the support console to ensure a timely response.

If the support paths suggested above still do not result in a resolution, please provide the following details.
Environment details

OS: Debian 10
Node.js version: 14
npm version:
@google-cloud/dialogflow-cx version: 1.1.0

Steps to reproduce

send request a

no response  in my terminal

Making sure to follow these steps will guarantee the quickest resolution possible.
Thanks!

@gildastema mind sharing a gist of the code in your screen-shot?

hey, did you solve it? I need help with deploying on dialogflow cx

Thank you for filing this issue. We asked some clarifying questions a week or more ago and never heard back from you. We are unable to proceed with this issue until then, so we are closing it. Please feel free to re-open this issue with more information.


Removing title of team members and adding suitable title

Issue: The title of team members looks messy and therefore new titles should be added like CEO, Co-founder, Growth Lead, App Developer, etc. since if any wants to know more about people he/she can visit their GitHub or LinkedIn profile.

This is @akashthedeveloper. And I will be adding my data to do my first contribution as well as get a card on the website.

Hey, @Rajdip019 can you please assign this issue to me?

Go ahead @akashthedeveloper

Hey, @Rajdip019 I am finding it difficult to find out which files I have to edit can you help me out with that? Also is there any way to directly find out which files I have to edit?

Hi @Rajdip019 , please assign this to me

Hey @Rajdip019  assign me this issue.

Where can I get the details about who is CEO or CTO etc.?

hey @Rajdip019, can you please assign me this issue?

Please assign this to me


Remove preprocessing: uglify and sass

Refs: https://github.com/metarhia/impress/issues/998
Closes: https://github.com/metarhia/impress/issues/997
Closes: https://github.com/metarhia/impress/issues/996

Landed in eaa8d89


Possible bug? Using snippets in tfvars causes unmarshal error.

Description
Attempting to pass a snippet to a heterogeneous node in a map(list(string)) causes an unmarshall error.
Steps to Reproduce
Provide clear steps to reproduce the bug.

[X] Relevant error messages if appropriate (concise, not a dump of everything).
[X] Explored using a vanilla cluster from the tutorials. Ruled out customizations.

Expected behavior
terraform plan -var.tfvars & terraform apply -var.tfvars to succeed when referencing snippets in a tfvars file.
Environment

Platform: bare-metal
OS: flatcar-linux 2605.7.0
Release: v1.19.3
Terraform: v0.13.5
Plugins:

+ provider registry.terraform.io/hashicorp/null v2.1.2
+ provider registry.terraform.io/hashicorp/random v2.3.1
+ provider registry.terraform.io/hashicorp/template v2.1.2
+ provider registry.terraform.io/hashicorp/tls v2.2.0
+ provider registry.terraform.io/poseidon/ct v0.6.1
+ provider registry.terraform.io/poseidon/matchbox v0.4.1

Example usage of snippets in a tfvars:
...
snippets = {
  "node4" = [".cl/longhorn-virt.yaml"],
}
...

Example "snippet" aka CLC
storage:
  filesystems:
    - name: longhorn
      mount:
        device: /dev/vdb
        format: btrfs
        wipe_filesystem: true
systemd:
  units:
    - name: longhorn.mount
      enabled: true
      contents: |
        [Unit]
        Before=local-fs.target
        [Mount]
        What=/dev/vdb
        Where=/var/lib/longhorn
        Type=btrfs
        [Install]
        WantedBy=local-fs.target

If I'm understanding the documentation for customization and checking the variable definition for  varibles.tf this should work?
Instead receiving:
Error: error strict parsing Container Linux Config: error: yaml: unmarshal errors:
  line 1: cannot unmarshal !!str `.cl/lon...` into types.Config

  on profiles.tf line 119, in data "ct_config" "worker-ignitions":
 119: data "ct_config" "worker-ignitions" {

In Terraform, file contents are reference via file('some-file.yaml'). You're setting the map value to the literal ".cl/longhorn-virt.yaml" string. Which naturally won't pass the config validation. The customizations docs show the right usage.

Thanks for the prompt reply! The docs seem to show making a modification to the mercury module. Thus requiring a fork and adding my source line as previously mentioned in the docs. If this is the correct way about going about this I will though by the

Extend the snippets map variable

in the docs. I would assume I would be inserting my added snippets in with my tfvars.
After passing file module as a string I get
Error: Invalid attribute name

  on kvmtest.tfvars line 21:
  21:   "node4" = ["file("./cl/longhorn-virt.yaml")"],

An attribute name is required after a dot.

Your new problem is another Terraform syntax error, file should not be quoted. https://www.terraform.io/docs/configuration/functions/file.html
Snippets let you provide CLC or FCC snippets for customization, they do not require a fork.

Right.
Fully get what snippets are for. Though the docs are a bit confusing on usage of them.
As noted here https://typhoon.psdn.io/advanced/customization/#flatcar-linux we're pathing the configs within the mercury module
Which if I'm understanding correctly would require a

source = "git::https://github.com/USERNAME/typhoon//digital-ocean/container-linux/kubernetes?ref=myspecialcase"

I totally agree this can be a syntax error, but I'm confused on the usage as per varibles.tf snippets are a map(list(string)) so it made sense to me to pass the file module as a string.
Either way removing the quotes terraform says "functions can't be called here".

I'll chalk this up as it's not possible to pass a snippet path within a tfvars file. Thanks for your help, I'll close this out.

I see, you're specifically wanting to set this in the special Terraform tfvars file. I believe tfvarsf files are limited to very simple cases and I don't think you'd be able to use Terraform functions or other Terraform features. But you can refer to Terraform upstream, since this isn't specific to snippets or this project.
The docs only describe writing Terraform declarations in .tf files in a Terraform workspace, so its assumed you can use Terraform syntax and features like file.


Add devise

Remove the current_user method in the ApplicationController, devise will provide us with one.
Install and set up devise

Can register a new user.
User logs in with a combination of email and password.
A hashed password should be stored in the database.
Ask for confirmation of email.
Can reset password.

We have completed the changes requested 🌱
Implementations:
Added confirmable to user model:


Add an example for Cloud IAP using the hello-app

@ahmetb
Hi, I have reworded the README and removed most of the tutorials. Is that OK we move forward?
BTW, how could I build an image and upload to gcr.io/google-samples/ like other hello-app samples?

What's the target of this sample? Is a doc being written around this?


Write a C++ program to convert weeks to seconds

Description
Write a C++ program to convert weeks to seconds
1 week = 7 days = 168 hours = 10080 minutes = 604800 seconds
Input  : 5
Output : 3024000

How to contribute

Save the solution in program/ConvertWeeksToSeconds.cpp file
Add ConvertWeeksToSeconds.cpp file in convert-weeks-to-seconds folder

!asign

!assign

Hey @TechnicalAmanjeet,
This issue has been assigned to you for more than 15 days.
We are unassigning you from this issue.
If you are still interested in contributing to this issue, please get auto-assigned on the issue by commenting !assign again.
Thanks for your contributions :)

!assign


Bugs caused by some interface adjustments.

After following the README Installation, I run python3 -u zoo/classic_control/cartpole/config/cartpole_muzero_config.py. Some bugs occurs:
Traceback (most recent call last):
  File "/home/jiangyh/code/LightZero/zoo/classic_control/cartpole/config/cartpole_muzero_config.py", line 93, in <module>
    train_muzero([main_config, create_config], seed=0, max_env_step=max_env_step)
  File "/home/jiangyh/code/LightZero/lzero/entry/train_muzero.py", line 72, in train_muzero
    policy = create_policy(cfg.policy, model=model, enable_field=['learn', 'collect', 'eval'])
  File "/home/jiangyh/miniconda3/envs/lightzero/lib/python3.9/site-packages/ding/policy/base_policy.py", line 344, in create_policy
    return POLICY_REGISTRY.build(cfg.type, cfg=cfg, **kwargs)
  File "/home/jiangyh/miniconda3/envs/lightzero/lib/python3.9/site-packages/ding/utils/registry.py", line 96, in build
    raise e
  File "/home/jiangyh/miniconda3/envs/lightzero/lib/python3.9/site-packages/ding/utils/registry.py", line 82, in build
    return build_fn(*obj_args, **obj_kwargs)
  File "/home/jiangyh/miniconda3/envs/lightzero/lib/python3.9/site-packages/ding/policy/base_policy.py", line 90, in __init__
    model = self._create_model(cfg, model)
  File "/home/jiangyh/miniconda3/envs/lightzero/lib/python3.9/site-packages/ding/policy/base_policy.py", line 144, in _create_model
    return create_model(model_cfg)
  File "/home/jiangyh/miniconda3/envs/lightzero/lib/python3.9/site-packages/ding/model/common/utils.py", line 18, in create_model
    return MODEL_REGISTRY.build(cfg.pop("type"), **cfg)
  File "/home/jiangyh/miniconda3/envs/lightzero/lib/python3.9/site-packages/ding/utils/registry.py", line 96, in build
    raise e
  File "/home/jiangyh/miniconda3/envs/lightzero/lib/python3.9/site-packages/ding/utils/registry.py", line 82, in build
    return build_fn(*obj_args, **obj_kwargs)
  File "/home/jiangyh/code/LightZero/lzero/model/muzero_model_mlp.py", line 104, in __init__
    self.representation_network = RepresentationNetworkMLP(
  File "/home/jiangyh/code/LightZero/lzero/model/common.py", line 260, in __init__
    self.fc_representation = MLP(
TypeError: MLP() got an unexpected keyword argument 'output_norm'

I think this may be caused by code interface adjustment.

Have the same issue on a new install

Hello,
Thank you very much for your question.
This error is due to LightZero currently relying on the latest version of DI-engine. You can install it with the following commands:
git clone https://github.com/opendilab/DI-engine.git
pip install -e .

We will fix this dependency issue as soon as possible. Thank you very much for your attention!
Best wishes.