[BUG] Azure.Search throws when retrieving a SearchIndex created using an encryption key without accessCredentials set

Describe the bug
Retrieving an Azure.Search.Documents.Indexes.Models.SearchIndex using Azure.Search.Documents.Indexes.Models.SearchIndexClient.GetIndex(string indexName) throws an exception during JSON deserialization when the index is created using an encryption key without accessCredentials set.
Expected behavior
According to the official documentation, when using "System-managed identity", one should not set accessCredentials nor identity within the encryptionKey object passed in the JSON for creating a new index. Therefore, the corresponding JSON from this index creation should be able to be deserialized without an exception being thrown, as it is valid according to the official spec.
Actual behavior (include Exception or Stack Trace)
An exception is thrown during JSON deserialization after calling Azure.Search.Documents.Indexes.Models.SearchIndexClient.GetIndex(string indexName).
A partial stack trace for this exception and other details are as follows:
Error message: The requested operation requires an element of type 'Object', but the target element has type 'Null'.
Source: System.Text.Json.Rethrowable
Target site: Void ThrowJsonElementWrongTypeException(System.Text.Json.JsonTokenType, System.Text.Json.JsonTokenType)
Stack Trace:
at System.Text.Json.ThrowHelper.ThrowJsonElementWrongTypeException(JsonTokenType expectedType, JsonTokenType actualType)
at Azure.Search.Documents.Indexes.Models.AzureActiveDirectoryApplicationCredentials.DeserializeAzureActiveDirectoryApplicationCredentials(JsonElement element)
at Azure.Search.Documents.Indexes.Models.SearchResourceEncryptionKey.DeserializeSearchResourceEncryptionKey(JsonElement element)
at Azure.Search.Documents.Indexes.Models.SearchIndex.DeserializeSearchIndex(JsonElement element)
at Azure.Search.Documents.IndexesRestClient.Get(String indexName, CancellationToken cancellationToken)
at Azure.Search.Documents.Indexes.SearchIndexClient.GetIndex(String indexName, CancellationToken cancellationToken)

To Reproduce
Following steps outlined here, create a new index using an encryption key relying on "System-managed identity", i.e without including accessCredentials or identity. Then, attempt to access this index using Azure.Search.Documents.Indexes.Models.SearchIndexClient.GetIndex(string indexName).
 While the index creation did succeed and index retrieval (through Azure.Search.Documents.Indexes.Models.SearchIndexClient.GetIndex(string indexName)) could be performed successfully, the system now fails to retrieve synonym maps due to a similar issue: the stored applicationSecret within accessCredentials is null in the stored index JSON (despite being properly uploaded), and Azure throws an exception, expecting applicationSecret to never be null.
This could and probably should be a separate bug report, but I just want to clarify that this alternative solution also does not work. This leaves just "User-managed identity" as a possible solution. However, given that it is a brand new feature, I'm concerned that it also won't work, given that these more established features do not function currently. I will investigate and attempt to use this approach nonetheless, however.

I was able to resolve the issue by updating Azure.Search.Documents (version=11.4.0) and Azure.Core (version=1.30.0) to the latest version. Our system was utilizing Azure.Search.Documents version=11.1.1 and Azure.Core version=1.21.0.


Compiling wpa_supplicant fails

Attempting to compile wpa_supplicant using the provided steps fails on Kali Live 2023.3, below is what happens when running as root:
apt-get install -y pkg-config libnl-3-dev gcc libssl-dev libnl-genl-3-dev
cp defconfig wpa_supplicant-2.10/wpa_supplicant/.config
git apply wpa_supplicant.patch
cd wpa_supplicant-2.10/wpa_supplicant
make -j4
Reading package lists... Done
Building dependency tree... Done
Reading state information... Done
pkg-config is already the newest version (1.8.1-1).
libnl-3-dev is already the newest version (3.7.0-0.2+b1).
gcc is already the newest version (4:13.2.0-1).
libssl-dev is already the newest version (3.0.10-1).
libnl-genl-3-dev is already the newest version (3.7.0-0.2+b1).
0 upgraded, 0 newly installed, 0 to remove and 543 not upgraded.
../src/build.rules:85: *** mixed implicit and normal rules: deprecated syntax
../src/build.rules:89: warning: overriding recipe for target '/home/kali/Desktop/WPA3'
../src/build.rules:86: warning: ignoring old recipe for target '/home/kali/Desktop/WPA3'
../src/build.rules:89: warning: overriding recipe for target 'stuff/wacker/wpa_supplicant-2.10/build//home/kali/Desktop/WPA3'
../src/build.rules:86: warning: ignoring old recipe for target 'stuff/wacker/wpa_supplicant-2.10/build//home/kali/Desktop/WPA3'
../src/build.rules:88: *** mixed implicit and normal rules: deprecated syntax
../src/build.rules:93: warning: overriding recipe for target '/home/kali/Desktop/WPA3'
../src/build.rules:89: warning: ignoring old recipe for target '/home/kali/Desktop/WPA3'
../src/build.rules:93: warning: overriding recipe for target 'stuff/wacker/wpa_supplicant-2.10/build//home/kali/Desktop/WPA3'
../src/build.rules:89: warning: ignoring old recipe for target 'stuff/wacker/wpa_supplicant-2.10/build//home/kali/Desktop/WPA3'
../src/build.rules:92: *** mixed implicit and normal rules: deprecated syntax
../src/build.rules:103: warning: overriding recipe for target '/home/kali/Desktop/WPA3'
../src/build.rules:93: warning: ignoring old recipe for target '/home/kali/Desktop/WPA3'
../src/build.rules:103: warning: overriding recipe for target 'stuff/wacker/wpa_supplicant-2.10/build//home/kali/Desktop/WPA3'
../src/build.rules:93: warning: ignoring old recipe for target 'stuff/wacker/wpa_supplicant-2.10/build//home/kali/Desktop/WPA3'
../src/build.rules:102: *** mixed implicit and normal rules: deprecated syntax
make: *** No rule to make target '../wpa_supplicant/%.c', needed by '/home/kali/Desktop/WPA3'.  Stop.
make: *** Waiting for unfinished jobs....

The script will then fail to run due to the file being missing:
Starting wpa_supplicant...
Traceback (most recent call last):
  File "/home/kali/Desktop/WPA3 stuff/wacker/./wacker.py", line 236, in <module>
    wacker = Wacker(args, start_word)
             ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/kali/Desktop/WPA3 stuff/wacker/./wacker.py", line 60, in __init__
    self.start_supplicant()
  File "/home/kali/Desktop/WPA3 stuff/wacker/./wacker.py", line 93, in start_supplicant
    proc = subprocess.Popen(self.cmd)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.11/subprocess.py", line 1026, in __init__
    self._execute_child(args, executable, preexec_fn, close_fds,
  File "/usr/lib/python3.11/subprocess.py", line 1950, in _execute_child
    raise child_exception_type(errno_num, err_msg, err_filename)
FileNotFoundError: [Errno 2] No such file or directory: './wpa_supplicant-2.10/wpa_supplicant/wpa_supplicant'

I wasn't able to reproduce. The wpa_supplicant built with the following steps

Run 2023.3 live Kali image in VMware player
sudo apt-get update
git clone https://github.com/blunderbuss-wctf/wacker.git
cd wacker
apt-get install -y pkg-config libnl-3-dev gcc libssl-dev libnl-genl-3-dev
cp defconfig wpa_supplicant-2.10/wpa_supplicant/.config
git apply wpa_supplicant.patch
cd wpa_supplicant-2.10/wpa_supplicant
make -j4
ls -al wpa_supplicant
-rwxr-xr-x 1 kali kali 7407048 Sep 22 22:53 wpa_supplicant

I was also interested in the path in your error report which is suspicious: stuff/wacker/wpa_supplicant-2.10/build//home/kali/Desktop/WPA3
Could you describe your setup?

I am running off a live USB which was made using ventoy, there is also a partition on the USB for regular storage of files, which is where I cloned wacker to. The "stuff" appears to be part of the directory for this, the full directory is
/media/kali/USB STORAGE/Cyber Range/WPA3 Stuff/wacker/wpa_supplicant-2.10/wpa_supplicant.
When cloning to the desktop directly, was able to compile. After further testing it appears to fail when it is cloned to a folder which has a space in the name - when I cloned it to a folder in the desktop called "WPA3 Stuff", it would fail the same as before.

File names with spaces you say... this one likely goes higher up then what wacker can handle. GNU Make has a really hard time with spaces in file names and doesn't support most use cases of them. A few options might be to just not use spaces in the file/dir names, use underscores instead, poke the supplicant folks and see if they can somehow restructure their makefiles to accommodate, or even try to have the GNU make folks revisit the ultimate issue. But as far as wacker is concerned we can't really do anything with this outside of updating the README with a warning.

I'll take not of your directions and install the required packages in order to test my WiFi SAE security.
Thank you for this amazing tool. Seems like a straight forward install to be honest.
Just gotta make sure the nics support wpa3 right I was using chatgpt and it said we can use this command in regards to that.
You can use the following command in the Kali terminal to check if your wireless card supports WPA3:
iw list | grep -A8 "Supported interface modes" | grep "WPA3"

This command will display the supported interface modes of your wireless card, including WPA3 if it is supported.

Attempting to compile wpa_supplicant using the provided steps fails on Kali Live 2023.3, below is what happens when running as root:
apt-get install -y pkg-config libnl-3-dev gcc libssl-dev libnl-genl-3-dev
cp defconfig wpa_supplicant-2.10/wpa_supplicant/.config
git apply wpa_supplicant.patch
cd wpa_supplicant-2.10/wpa_supplicant
make -j4
Reading package lists... Done
Building dependency tree... Done
Reading state information... Done
pkg-config is already the newest version (1.8.1-1).
libnl-3-dev is already the newest version (3.7.0-0.2+b1).
gcc is already the newest version (4:13.2.0-1).
libssl-dev is already the newest version (3.0.10-1).
libnl-genl-3-dev is already the newest version (3.7.0-0.2+b1).
0 upgraded, 0 newly installed, 0 to remove and 543 not upgraded.
../src/build.rules:85: *** mixed implicit and normal rules: deprecated syntax
../src/build.rules:89: warning: overriding recipe for target '/home/kali/Desktop/WPA3'
../src/build.rules:86: warning: ignoring old recipe for target '/home/kali/Desktop/WPA3'
../src/build.rules:89: warning: overriding recipe for target 'stuff/wacker/wpa_supplicant-2.10/build//home/kali/Desktop/WPA3'
../src/build.rules:86: warning: ignoring old recipe for target 'stuff/wacker/wpa_supplicant-2.10/build//home/kali/Desktop/WPA3'
../src/build.rules:88: *** mixed implicit and normal rules: deprecated syntax
../src/build.rules:93: warning: overriding recipe for target '/home/kali/Desktop/WPA3'
../src/build.rules:89: warning: ignoring old recipe for target '/home/kali/Desktop/WPA3'
../src/build.rules:93: warning: overriding recipe for target 'stuff/wacker/wpa_supplicant-2.10/build//home/kali/Desktop/WPA3'
../src/build.rules:89: warning: ignoring old recipe for target 'stuff/wacker/wpa_supplicant-2.10/build//home/kali/Desktop/WPA3'
../src/build.rules:92: *** mixed implicit and normal rules: deprecated syntax
../src/build.rules:103: warning: overriding recipe for target '/home/kali/Desktop/WPA3'
../src/build.rules:93: warning: ignoring old recipe for target '/home/kali/Desktop/WPA3'
../src/build.rules:103: warning: overriding recipe for target 'stuff/wacker/wpa_supplicant-2.10/build//home/kali/Desktop/WPA3'
../src/build.rules:93: warning: ignoring old recipe for target 'stuff/wacker/wpa_supplicant-2.10/build//home/kali/Desktop/WPA3'
../src/build.rules:102: *** mixed implicit and normal rules: deprecated syntax
make: *** No rule to make target '../wpa_supplicant/%.c', needed by '/home/kali/Desktop/WPA3'.  Stop.
make: *** Waiting for unfinished jobs....

The script will then fail to run due to the file being missing:
Starting wpa_supplicant...
Traceback (most recent call last):
  File "/home/kali/Desktop/WPA3 stuff/wacker/./wacker.py", line 236, in <module>
    wacker = Wacker(args, start_word)
             ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/kali/Desktop/WPA3 stuff/wacker/./wacker.py", line 60, in __init__
    self.start_supplicant()
  File "/home/kali/Desktop/WPA3 stuff/wacker/./wacker.py", line 93, in start_supplicant
    proc = subprocess.Popen(self.cmd)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.11/subprocess.py", line 1026, in __init__
    self._execute_child(args, executable, preexec_fn, close_fds,
  File "/usr/lib/python3.11/subprocess.py", line 1950, in _execute_child
    raise child_exception_type(errno_num, err_msg, err_filename)
FileNotFoundError: [Errno 2] No such file or directory: './wpa_supplicant-2.10/wpa_supplicant/wpa_supplicant'

python3 --version
Python 3.11.4
check my sysinfo and then go off of that I am running Python 3.11.4 I cloned as sudo and I ran install as sudo
so what other commands have you set or used that caused the confliction?

Seems like you're having the same issues as SG420 encountered. You'll need to explain your setup further to know for sure. Do you have spaces in your path? The python version isn't going to matter when the supplicant isn't building to begin with.


Adding flatcc dependency and wiring up to bazel/cmake.

This will allow us to generate C flatbuffer reader and verifier files for use in the VM.
Future changes will actually swap out our usage of the C++ version in the VM. The
C++ version will continue to be used for building in the compiler where we don't
care about code size/performance.
Progress on #898.

Reset to not include actual usage of flatcc. I'm punting on Android for now as I need @antiagainst's assistance to make that work and it's not required.


Unable to receive packets

Hello,
I manage to connect through Firefox, I get an IP, I have an adapter tunsnx, but the RX packets are always 0.
Any ideas how to debug further?

turns out I had another adapter with with an IP in the same class, sorry


Turn off SA1407 rule

This rule should be excluding real obvious operator precedence like a*b+c

✅ No public API change.


Update deps

Coverage remained the same at 97.349% when pulling cd13fa3623d6e6fefdc911a70d52a6255fd9cf3d on update-deps into a2a5d7b99515d4b25a73b59dec2d5b49a7eebe26 on master.


Add Nong Song: Sonic blaster X last friday noght

Song Name
Sonic blaster X Last friday night
Artist Name
F-777
Source
Youtube
Youtube Link
https://youtu.be/IvYD-HLAl8E?si=LRr8F_hiDHAHyxkW
Direct File Link
No response
Song ID
574484
Start Offset [ms]
No response
Extra
No response

reject
thats just regular sonic blaster


Document new Blazor WASM SWA VS publishing feature

There was an offline discussion to add a new article or new content to explain how to deploy a standalone (static) Blazor WebAssembly app to Azure Static Web Apps from the new publishing features built into VS (the current article that you maintain is only for deployment via GH). I checked your repo issues, and I don't see an issue to cover it, so I'm opening this one to ask about placing coverage for it ...

I placed temporary guidance in the Blazor docs for the scenario. I plan to pull that guidance and cross-link to whatever you put up.
cc: @sayedihashimi @fiveisprime ... This issue is a follow-up to our offline discussion on the subject. I'll keep the temporary guidance in place for the time being.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 6b5615c8-7144-399d-52d9-04283a942b50
Version Independent ID: 7e846219-4121-92f4-f9f1-1a35353261ac
Content: Build an Azure Static Web Apps website with Blazor
Content Source: articles/static-web-apps/deploy-blazor.md
Service: static-web-apps
GitHub Login: @craigshoemaker
Microsoft Alias: cshoe

@guardrex
Thanks for your feedback! We will investigate and update as appropriate.

Thanks for your feedback. Since this suggestion is product feature related rather than a docs issue, I am going to #please-close this issue for now.

cc: @danroth27 ... Given that Azure docs won't cover this, we'll keep in place what I was only placing temporarily for it at ...
https://learn.microsoft.com/en-us/aspnet/core/blazor/host-and-deploy/webassembly?view=aspnetcore-8.0#deploy-from-visual-studio


taskId expiry

how long the taskId maintained at algolia side
for example if i got a taskId after saveObject and after one month if i call get status API passing task Id can i get the status for same
Thanks,

Can someone please check and update here little urgent.
Thanks in advance


Revert "Added the FreeTDS library to the default cedarish image."

Reverts flynn/flynn#1129
We need to keep the cedarish image inline with Heroku's cedar-14 image.

LGTM


Add exported functions to change logger configuration

https://github.com/jesse-rb/slogger-go/blob/5f4380d0c1a2ee26807916c207607c22241fbd77/slogger.go#L23-L26
Add exported functions to change a logger's config such as logger color and local prefix.

This would save me from having to create a new logger.

Resolved by #6


Bump Package Manager version to 2022.11.4

Bump PPM to 2022.11.4, following image version bump at https://github.com/rstudio/rstudio-docker-products/pull/442

Huh, the checks are passing but I can't merge this because it's still waiting on status checks from helm-docs and lint. I think there's something wonky going on with the helm-docs auto-update bot or GHA, :thinking:. FYI @colearendt unless this is a known issue. I'm going to try to squash commits to see if that fixes things.


Margins added in focus state of buttons

In the :focus state of buttons a strange margin that was never previously defined is added and makes things in the layout to move.
https://github.com/mercadolibre/chico/blob/master/src/ui/styles/_buttons.scss#L12
Also check why line-height and and paddings are re-defined.

Was resolved in 5bf5819d16f745ede98ca2221720d3ac1676af26.


Revert a change to fix cts regression

Test summary for commit cf7c69f17286f39be30c1d0a378f8a76164cacd5
Driver commits used in build
CWPACK: amd-master 7387247eb9889ddcabbc1053b9c2052e253b088e
METROHASH: amd-master 3c566dd9cda44ca7fd97659e0b53ac953f9037d2
LLPC: dev e6247f101f0f2dfc07054866a571673650c84655
SPVGEN: dev 6e35eab398b519b8056a13a57dafc6c64b3df13a
XGL: dev d42c9bcce9f6d2998a522aea7975bc1e66bd507f
LLVM-PROJECT: amd-gfx-gpuopen-dev 32030dd1f4c7364453494fe781ffae05e09b1fb4

CTS tests (Failed: 0/224705)Built with version <IP_ADDRESS>
Rhel 8.2, Gfx10
Passed: 26447/56157 (47.1%)
Failed: 0/56157 (0.0%)
Skipped: 29710/56157 (52.9%)

Ubuntu 18.04, Gfx9
Passed: 26447/56157 (47.1%)
Failed: 0/56157 (0.0%)
Skipped: 29710/56157 (52.9%)

Ubuntu 20.04, Gfx8
Passed: 25036/56234 (44.5%)
Failed: 0/56234 (0.0%)
Skipped: 31198/56234 (55.5%)

Ubuntu 20.04, Gfx103
Passed: 26462/56157 (47.1%)
Failed: 0/56157 (0.0%)
Skipped: 29695/56157 (52.9%)


Fix docs output path

Follow up to #171. The docs Makefile we're now using outputs another layer of directories before getting to the HTML.

@alecbcs @slabasan did this (and previous) PR move the docs/tables/current-system-definitions.csv so that it is not part of the git diff that has been causing conflicts for system PRs until now?

Yes we pulled out the .csv files since they're dynamically created in CI they shouldn't be in the repo


Tag Equals and StartsLike fails to return results

If you could point me to where I have gone wrong or where in the code a mistake may have been made, it would be appreciated.
I have done the following:

curl -s -H "Content-Type: application/json" http://localhost:8080/write -d '{"series": {"key": "foo", "tags": {"host": "www.london.com","site":"lon"}}, "data": {"type": "points", "data": [[1463605960000, 46.0], [1463605970000, 69.0]]}}'
curl -s -H "Content-Type: application/json" http://localhost:8080/write -d '{"series": {"key": "foo", "tags": {"host": "www.petaluma1.com","site":"pet"}}, "data": {"type": "points", "data": [[1463605960000, 46.0], [1463605970000, 69.0]]}}'
curl -s -H "Content-Type: application/json" http://localhost:8080/write -d '{"series": {"key": "foo", "tags": {"host": "www.petaluma2.com","site":"pet"}}, "data": {"type": "points", "data": [[1463605960000, 46.0], [1463605970000, 69.0]]}}'

Successfully retrieved results:

curl -H "Content-Type: application/json" http://localhost:8080/query/metrics -d '{"range": {"type": "relative", "unit": "HOURS", "value": 2}, "filter": ["key", "foo"]}'

Failed to retrieved results (equals):

curl -H "Content-Type: application/json" http://localhost:8080/query/metrics -d '{"range": {"type": "relative", "unit": "HOURS", "value": 2}, "filter": ["key", "foo"]}'
curl -H "Content-Type: application/json" http://localhost:8080/query/metrics -d '{"range": {"type": "relative", "unit": "HOURS", "value": 3}, "filter": ["and",["key", "foo"],["=","site", "pet"]]}'

Failed to retrieved results (starts like):

curl -H "Content-Type: application/json" http://localhost:8080/query/metrics -d '{"range": {"type": "relative", "unit": "HOURS", "value": 3}, "filter": ["and",["key", "foo"],["^","site", "p"]]}'

Hey,
Can you paste or describe the configuration you are using and which commit of Heroic you are running?

I am using the latest master branch.  Here is my yaml

Hey,
With the configuraiton you gave me, I get an error when trying to start Heroic.
An Elasticsearch configuration that does what you want should look like this:
metadata:
  backends:
    - type: elasticsearch
      connection:
        clusterName: BP2
        seeds:
          - elasticsearchclient
        index:
          type: rotating
          pattern: metadata-%s
          interval: 1w

suggest:
  backends:
    - type: elasticsearch
      connection:
        clusterName: BP2
        seeds:
          - elasticsearchclient
        index:
          type: rotating
          pattern: metadata-%s
          interval: 1w

I noticed now that there is a typo in the documentation for the type field.
I've updated the documentation in 71f6729.

We tried this and we get the same non-results.  There are no error, just no results in the json result tag.

Because you are not seeing the error I did when trying to load the configuration. I'm questioning if you are loading the configuration at all.
Could you tell me how you run Heroic, and what the initial output is?

We don't know about elasticsearch, but we know that it can write to cassandra and retrieve by a key (see first comment above).  So to us, this indicated that the config is being used.
We have all the components docker-fied and they all run in a solution. Here is the output of heroic, docker image, run by hand. dump.txt
and here is the yaml (as text) heroic.yaml.txt

So this could be an interoperability issue with the Elasticsearch client library we are using.
I've added an integration test that checks the the operation that you described, if you could run the following test suite it would be helpful:
$ mvn -P integration-tests -D it.elasticsearch.remote=true -D it.elasticsearch.seed=localhost clean verify

This will create a fair bit of clutter on the Cluster if its a permanent one, so if its persistent you might want to delete the templates and indexes created. They all have the pattern heroic-it-*.
$ curl -X DELETE http://localhost:9200/heroic-it-\*
$ curl -X DELETE http://localhost:9200/_template/heroic-it-\*

Hey,
So I think I've figured out what's going on. If an Elasticsearch cluster is not configured, filters partially work. But the starts with filter does not.
I believe you have indexes which are using the wrong mapping, configuring a cluster should add a template that you can look for:
$ curl http://localhost:9200/_template

If there is not template, you can add it by configuring the cluster:
$ tools/heroic-shell -C <config>
heroic> configure

You can make sure that this template has been applied to your indexes:
$ curl http://localhost:9200/heroic-\*/_mapping

If the mapping is wrong, the only way to get it to apply is to drop the indexes. The mapping is persistent in the already created indexes.
$ curl -X DELETE http://localhost:9200/heroic-\*

I hope this helps.

Hello,
@udoprog  with your help we figured out what the problem was on our side.  We had index named with an incorrect pattern.  As you can see above, we set our elasticsearch connections with an  index pattern of metadata-%s per the instructions  [here] (https://github.com/spotify/heroic/blob/site/source/_pages/docs/config/elasticsearch_connection.ngt#L69).  Once we changed those be equal to heroic-a-%s we were able to get correct results using the query/metrics API.  We think it'll be good to update the documentation.
Thanks for your help!


Add Prometheus v2.12.0 as latest version

Signed-off-by: Julius Volz<EMAIL_ADDRESS>

@brian-brazil

:+1:


lens camera default parameters

Hey,
It's stated here (https://carla.readthedocs.io/en/latest/ref_sensors/#rgb-camera) that the default camera lens distortion parameters are non-zero, e.g. lens_circle_falloff= 5.0 and lens_k=-1.0
Zero-ing every parameter leads to a single color screen as stated here: (https://github.com/carla-simulator/carla/issues/2822#issuecomment-653442599).
Now to my issue: Do the default lens distortion values lead to an undistorted pinhole-camera image?
If not, which parameters do lead to an undistorted image?
Cheers

Do the default lens distortion values lead to an undistorted pinhole-camera image

Yes, @dnns92, as my comment you referenced says, default camera lens values lead to undistorted images.
Cheers!

Do the default lens distortion values lead to an undistorted pinhole-camera image

Yes, @dnns92, as my comment you referenced says, default camera lens values lead to undistorted images.
Cheers!

Could you please give the description of the attribute? it's like a puzzle to guess the meaning of such as lens_k?


added default CacheAdapter lifecycle hook

This follows a similar logic to hamilton.plugins.h_diskcache, but uses the standard shelve library. It has the same API as the diskcache, but provides less utilities to manage cache size.
Changes

added a CacheAdapter to hamilton.lifecycle.default
added relevant tests, derived from tests/plugins/h_diskcache

How I tested this

ran tests successfully locally

Notes

one edge case regarding cache history is mentioned in TODOs, but it shouldn't affect usability.

Checklist

[x] PR has an informative and human-readable title (this will be pulled into the release notes)
[x] Changes are limited to a single goal (no scope creep)
[x] Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
[x] Any change in functionality is tested
[x] New functions are documented (with a description, list of inputs, and expected output)
[x] Placeholder code is flagged / future TODOs are captured in comments
[x] Project documentation has been updated if adding/changing functionality.

@zilto this should have a companion example, and also docs entry.


Remote examples udate

Description of changes:

Added a new example showing how to setup remote launching manually w.o. the use of RemoteLauncher
Updated RemoteLauncher to use PyTorch container instead of custom syne-tune build one. The syne-tune container can still be used when passed as custom uri and the helper function to geerate the customr uri remains in the file

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Sorry, but I am really not sure we need this.

What I mean is having this will create even more confusion.
At present, there are two ways to launch experiments remotely:

Using RemoteLauncher, which builds a container. This is used in some of our experiments
All the logic implemented in benchmarking, for which there is a tutorial and which is battle tested

So, if anybody wants to run many experiments in parallel, not using a container, they can use what is in benchmarking, rather than again copy and pasting examples, which we all need to maintain (this includes random seed management, loading data from the right place for plotting, managing meta data, etc).
And if somebody wants to use a container for Syne Tune (which can have advantages, for example once the container is there, experiments get launched a little faster), they can use RemoteLauncher.

I am really somewhat puzzled that people do not simply look at what is there in benchmarking, and instead insist on reinventing the wheel.
I wrote a tutorial, I gave a talk about it, I honestly do not know what else I should do.

The task I entered in the backlog was about changing the examples which current use RemoteLauncher, and make them use the code in benchmarking/commons.

I see your point, I agree that the extra example with manual launching of remote tuning is probably not needed. The reasoning there was to explain how the remote launching code (in benchmarking or in RemoteLauncher) is build but maybe tutorials are a better place for this.
Regarding the remote launcher - I think that having it run only with custom container is a little limiting - we should be able to use that functionality with a default sagemaker containers. Why limit the capability of the code that already exists to niche (custom containers) users. When we enable default sagemaker containers with RemoteLauncher, the existing examples need no further changes.
With that in mind, I am happy to add a new example that shows how to use banchmarking tools to run. Is that hat you have in mind?

OK, so my favourite would be this:

Leave RemoteLauncher as it is, namely build a container
If anybody wants to do remote launching via SM framework, they should use benchmarking/commons. There could be extra examples showing how to use this, but I believe the tutorial is enough
If somebody really wants to do this by hand, not using benchmarking/commons, they can have a look at the code there, which is very clean. But I really prefer people just using this, instead of writing their own scripts

Now, about the examples which currently use RemoteLauncher. If they can be done using benchmarking/commons, I'd prefer that.
Maybe this cannot be done, because benchmarking stuff is too specific. I'd doubt this, because it supports all schedulers and all benchmarks.
But suppose it is felt that this is not pure enough. In that case, we could refactor these examples so they use the PyTorch framework and do not depend on the code in benchmarking.
But to not confuse users, we would point to the benchmarking as a simpler way (even if less "elementary") of doing these things.

What I really would like to avoid is to have another way of doing what is already in benchmarking/commons, being rolled out across our examples. This would be duplicating efforts and be real confusing.

Thanks for the context. I understand that we want to gently push customers to use the solution form benchmarking/commons as a default which makes sense. My proposal is the following:
1/ Make the curent examples (defaults for running jobs remotely) based on benchmarking/commons
2/ add a new example for using RemoteLauncher marketing it as an alternative (non-default) way of running remote jobs. In this point I prefer to retain the change to RemoteLauncher that makes it compatible with both SM default and custom-build containers. I feel that limiting it to custom containers only just makes it hard to use w.o. much added benefit.

As for 2/, you need to argue with David, he wrote the RemoteLauncher.
But note that this code not only uses a container, it also relies on serialization of the Tuner object with all its dependent classes (a closure), which gave us quite a bit of trouble.
The code in benchmarking/commons, which is really also from David (but brushed up a lot by myself), circumvents this step as well, but you need two scripts instead of one.
You can therefore think of benchmarking/commons as a 2nd generation, and RemoteLauncher the first, which is harder to maintain.
I'd personally be most happy if users stopped using RemoteLauncher altogether, because of its dependence on dill serialization. So, this is why I am not sure we should invest much in it anymore.

I see, regarding RemoteLauncher we should either update it to use SM defaults or deprecate it (at least mark for deprecation) if we dont want to support it. Otherwise testing for custom-build containers is a pain point. Happy to discuss in our next sync.

Following offline discussion the plan is as following:

Repurpose this CR to enable default SM containers in RemoteLauncher
Followup with a second CR which will update examples to use benchmarking/commons. At the end of the work we will have one example for RemoteLauncher and two examples for benchmrking - adding custom code to benchmarks and running existing benchmarks.


chore(deps): upgrade dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-k8s-23-main" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 790

Questions ?
Please refer to the Backport tool documentation


Both links under the "Host Networking with WinNAT to attach VMs and Containers" section are broken

Both links under the "Host Networking with WinNAT to attach VMs and Containers" section are broken:
https://msdn.microsoft.com/virtualization/hyperv_on_windows/user_guide/setup_nat_network
https://msdn.microsoft.com/virtualization/windowscontainers/management/container_networking

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: fd3cdd1f-645e-02f6-5ff7-c8f3a88b8ba8
Version Independent ID: 3bbbe76e-148e-7dbd-4a62-3ba9ea226599
Content: Windows NAT (WinNAT) -- Capabilities and limitations
Content Source: virtualization/community/team-blog/2016/20160525-windows-nat-winnat-capabilities-and-limitations.md
GitHub Login: @scooley

Think this should instead be https://docs.microsoft.com/en-us/virtualization/hyper-v-on-windows/user-guide/setup-nat-network

We hugely appreciate your contribution, feedback, and support to our technical documentation.
We’ve phased out GitHub Issues on this repository as the feedback mechanism for content and have replaced it with a new feedback system. For more information see, Content User Feedback. As part of this rollout, we are migrating your issue where our team will use your comments to improve the documentation experience. Unfortunately, this does mean you won't be able to access this issue after the migration is complete.
All issues will be migrated by Thursday 29th August 2024.
Once again, thank you for your valuable feedback, we hope you’ll continue to contribute using our new feedback system.


feat(SDZ): cloning snap drop zones

Cloning/Duplicating SDZ possible through SDZ.Clone();
fixes: #1695

There were the following issues with your Pull Request

Commit: 47f19aff7e9e84993defef823e9419280e6179c4
Invalid type. Valid types are feat, fix, docs, style, refactor, perf, test, chore, revert

Guidelines are available at https://github.com/thestonefox/SteamVR_Unity_Toolkit

This message was auto-generated by https://gitcop.com

Just update the commit message on this to match your previous one so
feat(SnapDropZone)
then when I do the change log it uses the scope as the grouping mechanism

@JWNJWN is this ready to be merged in your opinion?

This should be Read to merge.


Update upstream URLs

Fixes #39.
Before merging, is it okay if I do some cleanup in this PR as well, like removing trailing spaces and fixing typos? Or should it be a separate PR?

Yes, sure.

I think I'll leave the trailing spaces after all. Removing them changes the layout in some parts, which might have been intentional.

Oops, I found this at the bottom:

Please keep your commits and pull requests focused purely on the objectives discussed in your communications with the team (currently just me, but team sounds more legit). If you find other minor bugs, typos or whitespace issues while working on your feature / fix, rather than fixing them, please open a new issue and leave it out of your current contribution. Reviewing Pull Requests and comparing diffs will be much easier that way!

So I guess it's merge time then...


Adding changes to ARTOutcomes model

@Marymary-dev Is it LIHMIS or LHMIS? Depending on your abbreviation, harmonize on the script accordingly.
  	   union all
	select 'LIHMIS' as ARTOutcome

and
WHEN [ARTOutcome] = 'LHMIS'  THEN 'LOST IN HMIS'

@Marymary-dev Is it LIHMIS or LHMIS? Depending on your abbreviation, harmonize on the script accordingly.
  	   union all
	select 'LIHMIS' as ARTOutcome

and
WHEN [ARTOutcome] = 'LHMIS' THEN 'LOST IN HMIS'

@DennisGibz  the I has been added in the DimARTOutcome

@Marymary-dev , Just and been curious.  You had added the same on the Intermediate outcomes table then later closed the PR. How will above amendment on the Dim marry what we will have on the Intermediate outcomes?

@Marymary-dev , Just and been curious. You had added the same on the Intermediate outcomes table then later closed the PR. How will above amendment on the Dim marry what we will have on the Intermediate outcomes?

@DennisGibz  this PR has 2 files that were changed

@Marymary-dev  by " DATEADD(day, 1 - DAY(GETDATE()), GETDATE()) " what happens if an upload is done at 30th or 31st of the reporting month?  According to the script the site will be classified as LOST IN HMIS?

All uploads should be done between 1st and 15th , this is the guidance for reporting


Unauthorized (401) Permission denied, wrong credentials

Issue Summary
I am quite clueless. I believe I have done everything by the book, but I'm getting Unauthorized 401 error.
Steps to Reproduce

Created sendgrid account and API key.

Edited my API key to have all permissions (POST, GET, etc).

In terminal ran commands:
echo "export SENDGRID_API_KEY='my-API-key'" > sendgrid.env
echo "sendgrid.env" >> .gitignore
source ./sendgrid.env

In my express app I'm using this code:
const sendgrid = require('@sendgrid/mail');
sendgrid.setApiKey(process.env.SENDGRID_API_KEY);

app.get('/', (req, res) => {
 const msg = {
   to<EMAIL_ADDRESS>   from<EMAIL_ADDRESS>    subject: 'Sending with SendGrid is Fun',
   text: 'and easy to do anywhere, even with Node.js',
   html: 'and easy to do anywhere, even with Node.js',
 };
 sendgrid.send(msg)
    .then(() => {
      res.send('OK');
      console.log('success!!');
    })
    .catch(error => {
      console.error(error.toString());
    });
});
What am I doing wrong?
Technical details:

sendgrid-nodejs Version: 6.4.1
Node.js Version: 7.10.0
macOS Version: 10.12.6

HI @piilupart88,
Just checking to be sure you closed this because your issue is resolved. Please let us know.
Thanks!
Elmer


created contact page

👷 Deploy Preview for darling-cascaron-57e64e processing.

Name
Link

🔨 Latest commit
30429876e5713d1d1464d30b8245327304a0914d

🔍 Latest deploy log
https://app.netlify.com/sites/darling-cascaron-57e64e/deploys/6616e5a1f0c1780008ac2d45


Thank you so much for your contribution.


What is purpose of examples/impl.ipynb and examples/impl.ipynb?

Do we need these modules?

Probably not - it was just me experimenting with showing how to generate fasthtml apps from notebooks. But I think @ncoop57's recent work probably obsoletes it; is that right Nate?

I haven't made any tutorial on how to write a fasthtml app from a notebook. I think we haven't figured it out ourselves to be honest so I'd lean towards not promoting that workflow until we or the community figures out a better method.


allow label to be passed to plot

Fixes issue where accumulating legend label information in multiple plots to the same figure would fail to produce the desired legend. Thanks @dkweiss31!


last_jump has type int but is used as type None.

"filename": "mythril/analysis/module/modules/exceptions.py"
"warning_type": "Incompatible variable type [9]"
"warning_message": " last_jump is declared to have type int but is used as type None."
"warning_line": 28
"fix": None to 0

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


[Feature][connectors] Simplify connectors module

Purpose of this pull request
close #1763
Check list

[ ] Code changed are covered with tests, or it does not need tests for reason:
[ ] If any new Jar binary package adding in your PR, please add License Notice according
New License Guide
[ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs

@CalvinKirs @BenJFan Please take a look.


Test TorXakis with TorXakis using the Echo model

Acceptance criteria: The following work-flow should end-up in an unit-test for txs-lib:

Load a "TorxakisWithEcho" echo model, which describes the behavior of TorXakis when it loads the Echo.txs model, and steps through it.
Run the tester for a number of steps.
Verify that the verdict is "Pass"/

The Echo.txs model can be found in the examples folder.
A more detailed flow of the unit test is given below:
s <- newSession
load s "TorXakisWithEcho.txs"
-- At this point the TorXakis web-server needs to be started.
tester s
test s 100 -- Or any other value that is consider appropriate
r <- waitForVerdict
r `shouldBe` Pass

Closes #135.

@pjljvandelaar @tretmans could you review that this is what we want to achieve, and that if we achieve this then we can close #135.

With the commit e813b5ba (#610) we can finally use TorXakis to test a TorXakis that steps an Echo model:
TXS_CORE_USER_INFO {s = "Solver \"z3\" initialized : Z3 [4.5.1 - build hashcode 059bad909ad4]"}
TXS_CORE_USER_INFO {s = "TxsCore initialized"}
TXS_CORE_USER_INFO {s = "Tester started"}
TXS_CORE_USER_INFO {s = ".....1:  IN:  Act    { { ( Cmd, [ CmdLoad(\"examps\\Echo\\Echo.txs\") ] ) } }\n"}
TXS_CORE_USER_INFO {s = ".....2:  OUT: Act    { { ( Response, [ ResponseSuccess ] ) } }\n"}
TXS_CORE_USER_INFO {s = ".....3:  IN:  Act    { { ( Cmd, [ CmdInfo ] ) } }\n"}
TXS_CORE_USER_INFO {s = ".....4:  OUT: Act    { { ( Response, [ ResponseInfo(\"UNVERSIONED\",\"Mon 06/12/2017 10:01:59.98\") ] ) } }\n"}
TXS_CORE_USER_INFO {s = ".....5:  IN:  Act    { { ( Cmd, [ CmdStepper(\"Model\") ] ) } }\n"}
TXS_CORE_USER_INFO {s = ".....6:  OUT: Act    { { ( Response, [ ResponseSuccess ] ) } }\n"}
TXS_CORE_USER_INFO {s = ".....7:  IN:  Act    { { ( Cmd, [ CmdInfo ] ) } }\n"}
TXS_CORE_USER_INFO {s = ".....8:  OUT: Act    { { ( Response, [ ResponseInfo(\"UNVERSIONED\",\"Mon 06/12/2017 10:01:59.98\") ] ) } }\n"}
TXS_CORE_USER_INFO {s = ".....9:  IN:  Act    { { ( Cmd, [ CmdInfo ] ) } }\n"}
TXS_CORE_USER_INFO {s = "....10:  OUT: Act    { { ( Response, [ ResponseInfo(\"UNVERSIONED\",\"Mon 06/12/2017 10:01:59.98\") ] ) } }\n"}
TXS_CORE_USER_INFO {s = "....11:  IN:  Act    { { ( Cmd, [ CmdStep(1) ] ) } }\n"}
TXS_CORE_USER_INFO {s = "....12:  OUT: Act    { { ( Response, [ ResponseAction(\"In\",0) ] ) } }\n"}
TXS_CORE_USER_INFO {s = "....13:  IN:  Act    { { ( Cmd, [ CmdStep(1) ] ) } }\n"}
TXS_CORE_USER_INFO {s = "....14:  OUT: Act    { { ( Response, [ ResponseAction(\"Out\",0) ] ) } }\n"}
TXS_CORE_USER_INFO {s = "....15:  IN:  Act    { { ( Cmd, [ CmdInfo ] ) } }\n"}
TXS_CORE_USER_INFO {s = "....16:  OUT: Act    { { ( Response, [ ResponseInfo(\"UNVERSIONED\",\"Mon 06/12/2017 10:01:59.98\") ] ) } }\n"}
TXS_CORE_USER_INFO {s = "....17:  IN:  Act    { { ( Cmd, [ CmdInfo ] ) } }\n"}
TXS_CORE_USER_INFO {s = "....18:  OUT: Act    { { ( Response, [ ResponseInfo(\"UNVERSIONED\",\"Mon 06/12/2017 10:01:59.98\") ] ) } }\n"}
TXS_CORE_USER_INFO {s = "....19:  IN:  Act    { { ( Cmd, [ CmdStep(1) ] ) } }\n"}
TXS_CORE_USER_INFO {s = "....20:  OUT: Act    { { ( Response, [ ResponseAction(\"In\",71829167668948881) ] ) } }\n"}
  testTorXakisWithEcho

What remains to be done:

[ ] Add support for HTTP to CNECTDEFS #615
[ ] Generalize the flow by replacing hardcoded function names and parameters with the ones to be extracted from the ModelDef

@keremispirli Please give me a demo!
Did you know write a value parser from JSON to internal TorXakis?

BTW . Why is there a \n" in all Actions (see e.g.
{ { ( Cmd, [ CmdInfo ] ) } }\n"}

)?

@pjljvandelaar
I didn't write a parser. It needs to be written in #615
I added ToJSON and FromJSON to the Msg type in EnvData so it could be serialized into JSON and returned from the SUT TorXakis server. I receive this in tester TorXakis, deserialize it back to Msg, extract Action, wrap it in a "ResponseAction" Action and write it to "fromWorld" TChan. This is read by getFromWorld function that TxsCore was passed, creating the OUT step.
The reason for "\n"s is that what we see is not the direct output of TxsCore; it's the Msg entities being printed. That's why the newline characters in the output are visible.

@pjljvandelaar I can demo this on Monday. And/or you can checkout feat/txs-interface branch and run stack test txs-lib


Tasks adds server-id option to 'jf tfc'

Describe the bug
Calling the cli from this task to configure terraform for Module publishing results in following error:
[Error] Incorrect Usage: flag provided but not defined: -server-id
[Error] flag provided but not defined: -server-id
To Reproduce
task: JfrogCliV2@1
inputs:
jfrogPlatformConnection: 'my_jfrog_v2'
command: 'jf tfc --server-id-deploy="$(artifactoryHost)" --repo-deploy="$(artifactoryRepositoryName)"'
The task sets the --server-id option but the cli does not recognize this option for the command.
Expected behavior
terraform configurations are to get set
Versions
JFrog Azure DevOps Extension version: 2.2.0
CLI version: 2.19.0 , 2.25.5, 2.28.1
Agent operating system: ubuntu-latest

We're having the same problem...It's weird that you are using a parameter that is wrongly named. Should be --server-id-deploy as per your documentation (not --server-id)...Perhaps adding another helper function (task utils) for terraform that uses a parameter name --server-id-deploy as expected?


Unset grpcPath doesn't have correct behavior

Line 117 in Editor\ProtobufUnityCompiler\ProtobufUnityCompiler.cs I believe should have && instead of ||.
I'm not using (current) grpc, so I don't have that value set in the prefs.  So that string is empty.  But written with || this statement evaluates to true.

Seconded. When the string is empty, it still looks for grpc and fails to compile

Oh no, I have not checked this for long time and it seems a PR #13 is already doing that fix. I have merged it now.


Support for middle/cmd clicking an item to open in new tab

we have some items that are links, whats the recommended approach to support middle clicking? i could imagine onSelect handler passing the event

You can use an anchor tag inside Command.Item
https://codesandbox.io/s/silly-solomon-mthm2w?file=/src/App.tsx

@joaom00 thanks for chiming in, but this doesnt support the standard onSelect keyboard behavior (navigate on return)
best way i'm hacking it is to add an anchor tag inside, but also keep onSelect on the CommandItem. however, the anchor tag needs to have its own click handler that e.stopPropagation to prevent double firing (in the case where you have side effects from onSelect, which I do)

Ohh I see, yeah I think your approach is the way to go for now. I guess if #138 gets merged you will be able to have the desired behavior. Would be like this:
<Command.Item asChild>
  <a />
</Command.Item>


feature request: deactivate play/stop buttons while syrinscape is not active/not logged in

If syrinscape is not yet active, or not successfully logged in, deactivate the play/stop buttons.

fixed in 1.6.0


[WIP] Streams: Add first_message_id field.

Adds first_message_id field to Stream model and backfills the data.
Also ensures that if the lowest message id on the stream is equal to first_message_id browser won't show more topics on the left sidebar.
Fixes #10265

@zy964c sorry for the slow review; I've been sick the last few months :(.
I'd like you to split this into two commits; one for just the backend/data flow changes for tracking the first_message_id property (which has the database migration); that one we should be able to merge soon.
The backend piece is not yet correct, because we need to update .first_message_id in the do_send_messages code path; otherwise, the property won't be correct for most streams.  Can you work on that?  We might need to make check_message pass the stream object into do_send_messages so that it's available.

(Also, you need to rebase and renumber migrations)

Closing in favor of #11730.


TypingError: Cannot unify ListType[int64] and list(int64)<iv=None> during using list comprehension

def test_misc6():

    @njit
    def foo(reflect_list):
        typed_list = typed.List.empty_list(types.int64)
        typed_list.append(1)

        for item1 in reflect_list:
            typed_list = [item1 if item1 == item2 else item2 for item2 in typed_list]

        return typed_list

    foo.py_func([1, 2])
    foo([1, 2])

TypingError is reported, and I think the line is incorrect. The real casue should come from the line typed_list = [item1 if item1 == item2 else item2 for item2 in typed_list], rather than for item1 in reflect_list:.
E                   numba.core.errors.TypingError: Failed in nopython mode pipeline (step: nopython frontend)
E                   Cannot unify ListType[int64] and list(int64)<iv=None> for 'typed_list.2', defined at /home/dali.da/code/asdc/sdc/tests/tests_ant/test_deque.py (737)
E
E                   File "test_deque.py", line 737:
E                       def foo(reflect_list):
E                           <source elided>
E
E                           for item1 in reflect_list:
E                           ^
E

If I change the loop body as below:
        for item1 in reflect_list:
            for index in range(len(typed_list)):
                if item1 == typed_list[index]:
                    typed_list[index] = item1

Typing is ok.
Maybe it's an unimplemented feature? or a bug related list comprehension.

Oh, I guess list comprehension returns an instance of list(int64), and numba cannot allow list(int64) convert/unify to listtype(int64), which causes this TypingError.

The problem here is that the list comprehension returns a reflected list. Thus when attempting to unify the types for that variable you end up with an error.
The following fixes this:
from numba import njit, typed, types

@njit
def foo(reflect_list):
    typed_list = typed.List.empty_list(types.int64)
    typed_list.append(1)

    for item1 in reflect_list:
        typed_list = typed.List([item1 if item1 == item2 else item2 for
                                    item2 in typed_list])

    return typed_list

foo.py_func([1, 2])
foo([1, 2])

Thanks for ur quick response! In fact, it is also related with the loop. If we remove the loop like this:
@njit
def foo(reflect_list):
    typed_list = typed.List.empty_list(types.int64)
    typed_list.append(1)

    item1 = -1
    typed_list = [item1 if item1 == item2 else item2 foritem2 in typed_list]

    return typed_list

This works.
BTW, could u spare some time to review my PR #8029, thanks.
BTW again, I want to contribute a small PR about supporting using str(bool_variable), since I used this in my own njit code. I think I can add some logic for boolean type in the method integer_str in unicode.py.

@esc, Thanks for ur quick response! In fact, it is also related with the loop. If we remove the loop like this:
@njit
def foo(reflect_list):
    typed_list = typed.List.empty_list(types.int64)
    typed_list.append(1)

    item1 = -1
    typed_list = [item1 if item1 == item2 else item2 foritem2 in typed_list]

    return typed_list

This works.

Indeed. The reason the loop breaks the code is due SSA (https://en.wikipedia.org/wiki/Static_single_assignment_form). You can imagine the loop to also act like a branch. In the sense that if the reflected_list is empty the loop will not execute and the typed_list will remain a numba.typed.List. Otherwise it will become a reflected list due to the list comprehension. This means, that the return type of the function foo is determined by the value of the argument reflect_list -- and so the compiler can't work out the signature of the function to compiler and hence will error out with a type unification error.
This is generally an issue, a more illustrative way to show this would be:
In [1]: from numba import njit

In [2]: @njit
   ...: def foo(val):
   ...:     if val:
   ...:         return [1]
   ...:     else:
   ...:         return 1
   ...:

In [3]: foo(True)
---------------------------------------------------------------------------
TypingError                               Traceback (most recent call last)
Input In [3], in <cell line: 1>()
----> 1 foo(True)

File ~/git/numba/numba/core/dispatcher.py:468, in _DispatcherBase._compile_for_args(self, *args, **kws)
    464         msg = (f"{str(e).rstrip()} \n\nThis error may have been caused "
    465                f"by the following argument(s):\n{args_str}\n")
    466         e.patch_message(msg)
--> 468     error_rewrite(e, 'typing')
    469 except errors.UnsupportedError as e:
    470     # Something unsupported is present in the user code, add help info
    471     error_rewrite(e, 'unsupported_error')

File ~/git/numba/numba/core/dispatcher.py:409, in _DispatcherBase._compile_for_args.<locals>.error_rewrite(e, issue_type)
    407     raise e
    408 else:
--> 409     raise e.with_traceback(None)

TypingError: Failed in nopython mode pipeline (step: nopython frontend)
Can't unify return type from the following types: Literal[int](1), list(int64)<iv=[1]>
Return of: IR name '$10return_value.2', type 'list(int64)<iv=[1]>', location:
File "<ipython-input-2-ba37f6e3cdce>", line 4:
def foo(val):
    <source elided>
    if val:
        return [1]
        ^
Return of: IR name '$14return_value.1', type 'Literal[int](1)', location:
File "<ipython-input-2-ba37f6e3cdce>", line 6:
def foo(val):
    <source elided>
    else:
        return 1

Hope that helps?

BTW, could u spare some time to review my PR #8029, thanks.

Not at this time no, but I can update the labels.

BTW again, I want to contribute a small PR about supporting using str(bool_variable), since I used this in my own njit code. I think I can add some logic for boolean type in the method integer_str in unicode.py.

Yes I saw, this is straightforward, thank you.

@dlee992 I am not sure much can be done about this issue, do you think we can close it?

Yes, I think unification of (reflect) list and typedlist cannot be implemented right now in Numba. Can close this.


Extend enumerations for _ma_associated_archive_file_details.file_format

Aim: add support for images as accompanying data
Allowed values to add to _ma_associated_archive_file_details.file_format:

"png" for PNG files
"jpg" for JPEG files

Background info: PNG was observed in a recent ModelArchive deposition. Suggestion to add JPEG is to cover both the most popular lossless and the most popular lossy image format.

Addressed in https://github.com/ihmwg/ModelCIF/pull/25.


If the logo is the logo for Robusta, then the word Robusta should be in the alt text.
Screenshots

Desktop (please complete the following information):

OS: macOS Big Sur
Browser Chrome
Version 98

Additional context
Add any other context about the problem here.

Thank you for reporting!
On Sun, Feb 20, 2022 at 9:19 PM Josh Soref @.***> wrote:

Describe the bug
To Reproduce
Steps to reproduce the behavior:

Turn off loading images in your web browser
Go to https://docs.robusta.dev/master/

Expected behavior
Alt text should be meaningful.
If the logo is the logo for Robusta, then the word Robusta should be in
the alt text.
Screenshots
[image: image]
https://user-images.githubusercontent.com/2119212/154860183-937ada34-3fad-4879-814b-4e1294872382.png
Desktop (please complete the following information):

OS: macOS Big Sur
Browser Chrome
Version 98

Additional context
Add any other context about the problem here.
—
Reply to this email directly, view it on GitHub
https://github.com/robusta-dev/robusta/issues/229, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AADYUBZIKVLPUNYT3JUAF63U4E5CXANCNFSM5O4ZVCGQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

@aantn Should I fix this with robusta-light and robusta-dark in case of Light Logo and Dark Logo in the dark mode.

I question the value of telling a blind user that the logo is light or dark. I think it's more important to say "Robusta Logo" if that's what it is. If a blind user is curious, they can inspect the file name, which I imagine would tell them the fact that it's light or dark.
Note that blind users don't naturally get told the color of the rest of a web page (neither the foreground nor the background). They can inspect if they're curious, but what they generally want is a description of the meaning of the content, not the presentation of the content.

Writing "Robusta Logo" sounds good to me too.
On Mon, 21 Feb 2022, 5:43 Josh Soref, @.***> wrote:

I question the value of telling a blind user that the logo is light or
dark. I think it's more important to say "Robusta Logo" if that's what it
is. If a blind user is curious, they can inspect the file name, which I
imagine would tell them the fact that it's light or dark.
Note that blind users don't naturally get told the color of the rest of a
web page (neither the foreground nor the background). They can inspect if
they're curious, but what they generally want is a description of the
meaning of the content, not the presentation of the content.
—
Reply to this email directly, view it on GitHub
https://github.com/robusta-dev/robusta/issues/229#issuecomment-1046443762,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AADYUB5LJVGJGRWP2UMCVR3U4GYFRANCNFSM5O4ZVCGQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you were mentioned.Message ID:
@.***>

Great suggestion @jsoref Let's go with Robusta Logo


AddNpm App ResourceStop not working

Is there an existing issue for this?

[x] I have searched the existing issues

Describe the bug
I am executing the SWA CLI via NPM
      builder.AddNpmApp("swa", "app", "swa")
          .WithReference(api)
          .WithHttpEndpoint(targetPort: 4280);

Everything works fine on first startup. However when I stop Visual Studio, the node process is still running. Also if I press the stop button on the dashboard, it reports:
2024-10-10T02:25:19 Executing command 'resource-stop'.
2024-10-10T02:25:19 Successfully executed command 'resource-stop'.

but the node process is still running and the url continues to accept traffic.
This is not occurring in the 8.2.0 Nuget Packages and SDK.
Expected Behavior
The executable ends on close or when the stop button is pressed
Exceptions (if any)
No exceptions are being thrown. Silent failure
.NET Version info
Sdk Version: 9.0.0-rc.1.24506.1
.NET 8.0.400
Windows 11 23H2
Ive tried both:
npm: 8.11.0, node: 16.16.0
npm: 10.8.2, node: 20.18.0
fails on windows.
Works on WSL.

Static web apps CLI? Is that what the SWA CLI is? Can you share a project that we can use to reproduce the issue?

Sorry, to clarify it doesn’t matter what the underlying npm task does (call swa cli or webpack), the behaviour is the same.

@davidfowl https://github.com/swissarmykirpan/aspire-swa, i've got two examples here, one using the swa cli and the other using another npm pacakge called http-server. Same outcomes.

I think I understand what's causing this issue; npm shares its stdio with its forked children, but when we kill npm it isn't killing all the children automatically. Unfortunately we're also waiting on the stdio to finish flushing. We need to start cleaning up the children in parallel while we wait for stdio to close.

Yeah, this is purely an orchestrator bug; I've got a fix that can go into the next DCP insertion.

@davidfowl @danegsta any indication of when this will make it out to the nighty build?

It should already be in the latest nightly builds; looks like several CI runs have completed since the fix was merged.

I'm still seeing this issue in 9.0.0-rc.1.24511.1
I don't know whether it's relevant, but I also have other npm projects running at the same time on my computer which aren't managed by Aspire.
It would be very helpful if this is handled correctly as I often need to work on both a .NET Aspire project and a non-.NET Aspire project simultaneously.


chore: remove tofu url_template

csb 1.0.1 defaults to the opentofu download url for tofu dependencies, hence no need to specify it anymore.
#187199931
Checklist:

[ ] Have you added Release Notes in the docs repositories?
[x] Have you followed the Conventional Commits specification?

Context for future us.
Removing url_template for tofu would have caused issues in cloud-service-broker for any version below v1.0.0.
This is so because previously when url_template was missing it defaulted to the constant HashicorpUrlTemplate.
However, https://github.com/cloudfoundry/cloud-service-broker/pull/975 put some logic in place to treat url_template differently depending if it's a provider or the tofu binary itself.
Since such logic was added in v1.0.0, the additional bumps included in this PR are merely complementary and everything should have worked without them too.


chore: implement fix to limit amount of accounts rendered

Try out Leather build 724e604 — Extension build, Test report, Storybook, Chromatic

This PR makes a small change to fix https://github.com/leather-wallet/extension/issues/5149.
This fixes the issue and reduces the impact of the bug however it means that the UI isn't as slick as it could be and the list height doesn't dynamically update on narrower viewports.
I am close to having a full solution in this PR but thought it worth improving what we have on dev while I am finalising that.
Here's what I am talking about:
https://github.com/leather-wallet/extension/assets/2938440/7a26d232-c21c-45e6-ab3c-ba2cc32d5793

Thanks Pete
They do claim to support dynamic window heights, so wonder what the issue is here. What if we don't set a height at all? 🤔

If we don't set the height it just renders an empty list so we don't see anything.  I'm close to having something good and auto sizing in https://github.com/leather-wallet/extension/pull/5171/files , I just need to test it a bit better.
I will check if there is a cleaner way with dynamic heights on their docs

Do we expect the following sort of report to be resolved by this PR?

Do we expect the following sort of report to be resolved by this PR?

No, thats a separate problem. This fix relates to loading all of the accounts at once in the account selector and hadn't been released to production yet.

@alter-eggo are you working on this other problem (see comment above) already via other issues, or do we need to capture as a need issue?

@markmhendrickson there is skeleton loader now on dev instead of 0 balance


Added use of PolymerModelData to Load textures

Hi!
Wanted to help out and saw that the texture deployment could be improved so it uses polymers resource pack generation better. Now servers with polymer's auto host running will find that these textures are now included on startup without needing to run the /polymer generate-pack command. This should mean users don't need to mess around with setting up the resource-pack in their server.properties file.
apologies if this is too forward.

Thank you for the PR!

no worries I'm happy to help


Missing RAS and IAS Servers template.

Following these docs and there are default templates, but the RAS and IAS Servers template is not there.  Running Server 2016 too and used the Powershell commands to install certificate services.
What did I miss?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: daa5ac60-a6aa-b44a-b769-1b264eb3d1ab
Version Independent ID: 796da0f4-4739-864d-ce7f-769fbffe023b
Content: Configure the Server Certificate Template
Content Source: WindowsServerDocs/networking/core-network-guide/cncg/server-certs/Configure-the-Server-Certificate-Template.md
Product: windows-server-threshold
GitHub Login: @shortpatti
Microsoft Alias: pashort

Nevermind, missed a step.

For anyone wondering what Johnny refers to as by "missed a step", he's referring to the fact that only the default enabled certificate templates are added. What you need to do is first manage the templates and create the copy of the RAS and IAS Server template.


Don't let ESC key bubble in CodeHintList. Fixes #12799

This PR fixes #12799 by handling ESC key presses differently from other actions that close the CodeHintList popup. event.stopImmediatePropagation is used to prevent the stop event from bubbling up.
cc @adityapaturi  who reported the original issue.
Signed-off-by: petetnt<EMAIL_ADDRESS>

/cc @bmax too


Update docs for v4.0

Docs need to be aligned due to upgrade to prooph/common v3.x and remove of ZF2\Events.

Done in #55


Spec: Deployment

Adds deployment ipc spec

This is duplicative with existing docs. The hack about using the scripts to initialize a subnet within a Docker deployment, to later copy its state/config out of the containers for faster development cycles is useful. But it'd be better to package it in a script, than to embed the script in a doc.


Add auto-completion for subqueries

When you want to write a subquery, part of it won't have auto-complete hints:

completion of select keyword in subquery,
completion of table name after from.

After you state a table, columns will be hinted correctly.

Updated version (0.10.0) released to PyPI.


kafka: Create responses based on version of request

The current code sends Kafka responses based on the latest version regardless of the version used in the request. Validate if any of the responses returned are incompatible based on the request version. The responses are very basic so it's unclear whether any version incompatibility exists.

I added needs/e2e-test to add a test case for this in Nightly tests.

I have a query about this
We only send a response if there is a request deny. I am going through all the responses we create :
// CreateResponse creates a response message based on the provided request
// message. The response will have the specified error code set in all topics
// and embedded partitions.
func (req *RequestMessage) CreateResponse(err error) (*ResponseMessage, error) {
	switch val := req.request.(type) {
	case *proto.ProduceReq:
		return createProduceResponse(val, err)
	case *proto.FetchReq:
		return createFetchResponse(val, err)
	case *proto.OffsetReq:
		return createOffsetResponse(val, err)
	case *proto.MetadataReq:
		return createMetadataResponse(val, err)
	case *proto.ConsumerMetadataReq:
		return createConsumerMetadataResponse(val, err)
	case *proto.OffsetCommitReq:
		return createOffsetCommitResponse(val, err)
	case *proto.OffsetFetchReq:
		return createOffsetFetchResponse(val, err)
	case nil:
		return nil, fmt.Errorf("unsupported request API key %d", req.kind)
	default:
		// The switch cases above must correspond exactly to the switch cases
		// in ReadRequest.
		log.Panic(fmt.Sprintf("Kafka API key not handled: %d", req.kind))
	}
	return nil, nil

I can see that we fill in the fields of the responses based on the req.apiVersion specifically the Bytes interface of all of these methods. So is this issue concerning checking if we are filling up all these fields based on req.apiVersion or latest version? From what I can tell, we already check for value of req.apiVersion before filling respective fields. Could you clarify a bit more what is needed in this issue?

The intent of this issue is to verify whether we correctly support versioning of responses based on the requests, if we already do this, then this issue can be closed.


cant update. Setup files corrupted

Code says there is an update.  when I click  update I get an error dialog saying "The setup files are corrupted.  Please obtain a new copy of the program"  What does that mean in practice?
The net result is that I am unable to update VS Code.
I'll uninstall and reinstall to see if that helps.

Duplicate of #780


Update plexus-archiver to 4.9.1

About this PR
📦 Updates org.codehaus.plexus:plexus-archiver from 4.9.0 to 4.9.1
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

🔍 Files still referring to the old version number
The following files still refer to the old version number (4.9.0).
You might want to review and update them manually.
modules/tests/shared/src/test/resources/resolutions/com.geirsson/sbt-ci-release/sbtVersion_1.0_scalaVersion_2.12/1.2.6

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.codehaus.plexus", artifactId = "plexus-archiver" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "org.codehaus.plexus", artifactId = "plexus-archiver" }
}]

labels: library-update, early-semver-patch, semver-spec-patch, old-version-remains, commit-count:1

Superseded by #2951.


Transit Gateway Cidr Blocks not supported in network config

<!--
**Describe the bug**
Updating LZA 1.4.2 to 1.5.1, we get this error for the AWSAccelerator-NetworkPrepStack in the Shared Network account:
**Transit Gateway CIDR block X.X.X.X/24 cannot be removed while it is in use by resource vpn-0xxxxxxxxxxxxx**.

_Resource handler returned message: "Transit Gateway CIDR block X.X.X.X/24 cannot be removed while it is in use by resource vpn-0xxxxxxxxxxxxx. (Service: Ec2, Status Code: 400, Request ID: f11d2f54-5806-434e-a783-47a64c58bd83)" (RequestToken: 53f02ac9-e9ea-4f65-a044-e55142bb4d84, HandlerErrorCode: GeneralServiceException)_

**To Reproduce**
We deployed the main TGW with LZA network-config file.
We have one TGW attachement as Direct Connect connection with a Direct Connect Gateway.
We also have 4 private VPN tunnels inside the DX connection which all terminated at the TGW. To be able to achieve this, we manually added a private CIDR block to the TGW to serve for the VPN tunnels. This feature (**TransitGatewayCidrBlocks**) is not supported by LZA yet. We believe that this is the cause of the error and we hereby request this feature be added to LZA.

`- name: Network-Main
    account: Network
    region: *HOME_REGION
    shareTargets:
      organizationalUnits:
        - Infrastructure
    asn: 65521 # À valider
    dnsSupport: enable
    vpnEcmpSupport: enable
    defaultRouteTableAssociation: disable
    defaultRouteTablePropagation: disable
    autoAcceptSharingAttachments: enable
    routeTables:
      - name: Network-Main-Core
        routes: []
      - name: Network-Main-Segregated
        routes:
          - destinationCidrBlock: <IP_ADDRESS>/0
            attachment:
              vpcName: Perimeter
              account: Perimeter
          - destinationPrefixList: onpremises-prefix-list
            attachment:
              vpcName: Inspection
              account: Network
      - name: Network-Main-Shared
        routes:
          - destinationCidrBlock: <IP_ADDRESS>/0
            attachment:
              vpcName: Perimeter
              account: Perimeter
          - destinationPrefixList: onpremises-prefix-list
            attachment:
              vpcName: Inspection
              account: Network
      - name: Network-Main-Onprem
        routes:
          - destinationPrefixList: awslab-prefix-list
            attachment:
              vpcName: Inspection
              account: Network
      - name: Network-Main-Standalone
        routes: []`

**Please complete the following information about the solution:**

- [ ] Version: 1.4.2 to 1.5.1
- [ ] Region: ca-central-1
- [ ] Was the solution modified from the version published on this repository? No
- [ ] If the answer to the previous question was yes, are the changes available on GitHub?
- [ ] Have you checked your [service quotas](https://docs.aws.amazon.com/general/latest/gr/aws_service_limits.html) for the services this solution uses? Yes
- [ ] Were there any errors in the CloudWatch Logs? Yes
**Screenshots**
![image](https://github.com/awslabs/landing-zone-accelerator-on-aws/assets/132080444/143bd99a-dce1-4899-a604-5718708a73f9)

Updating LZA 1.4.2 to 1.5.1, we get this error for the AWSAccelerator-NetworkPrepStack in the Shared Network account:
Transit Gateway CIDR block X.X.X.X/24 cannot be removed while it is in use by resource vpn-0xxxxxxxxxxxxx.
Resource handler returned message: "Transit Gateway CIDR block X.X.X.X/24 cannot be removed while it is in use by resource vpn-0xxxxxxxxxxxxx. (Service: Ec2, Status Code: 400, Request ID: f11d2f54-5806-434e-a783-47a64c58bd83)" (RequestToken: 53f02ac9-e9ea-4f65-a044-e55142bb4d84, HandlerErrorCode: GeneralServiceException)
To Reproduce
We deployed the main TGW with LZA network-config file.
We have one TGW attachement as Direct Connect connection with a Direct Connect Gateway.
We also have 4 private VPN tunnels inside the DX connection which all terminated at the TGW. To be able to achieve this, we manually added a private CIDR block to the TGW to serve for the VPN tunnels. This feature (TransitGatewayCidrBlocks) is not supported by LZA yet. We believe that this is the cause of the error and we hereby request this feature be added to LZA.
- name: Network-Main     account: Network     region: *HOME_REGION     shareTargets:       organizationalUnits:         - Infrastructure     asn: 65521 # À valider     dnsSupport: enable     vpnEcmpSupport: enable     defaultRouteTableAssociation: disable     defaultRouteTablePropagation: disable     autoAcceptSharingAttachments: enable     routeTables:       - name: Network-Main-Core         routes: []       - name: Network-Main-Segregated         routes:           - destinationCidrBlock: <IP_ADDRESS>/0             attachment:               vpcName: Perimeter               account: Perimeter           - destinationPrefixList: onpremises-prefix-list             attachment:               vpcName: Inspection               account: Network       - name: Network-Main-Shared         routes:           - destinationCidrBlock: <IP_ADDRESS>/0             attachment:               vpcName: Perimeter               account: Perimeter           - destinationPrefixList: onpremises-prefix-list             attachment:               vpcName: Inspection               account: Network       - name: Network-Main-Onprem         routes:           - destinationPrefixList: awslab-prefix-list             attachment:               vpcName: Inspection               account: Network       - name: Network-Main-Standalone         routes: []
Please complete the following information about the solution:

[ ] Version: 1.4.2 to 1.5.1
[ ] Region: ca-central-1
[ ] Was the solution modified from the version published on this repository? No
[ ] If the answer to the previous question was yes, are the changes available on GitHub?
[ ] Have you checked your service quotas for the services this solution uses? Yes
[ ] Were there any errors in the CloudWatch Logs? Yes
Screenshots

We are also experiencing this same issue, however it did not happen until going from v1.5.2 to v1.6.0. We've had a TGW CIDR for several LZA upgrades without issue until v1.6.0. We have not yet been able to duplicate in our Dev Environment.

Hi @hpf-mrnf ! Thank you for utilizing the Landing Zone Accelerator on AWS (LZA) solution. We've had several end-users run into this issue when upgrading from 1.4.x version to a version after 1.5. In the 1.5 version, we remove an Accel-P tag from the solution which gets removed from most of the resources that add this that are supported by the LZA solution, Transit Gateways included. When CreateTags or DeleteTags API calls are done with Transit Gateway, there's a Modify API call that is performed to resolve the drift between what's in CloudFormation and the current state of your resource. CloudFormation is then attempting to get your Transit Gateway in a desired state by removing the static CIDR that you implemented.
As a workaround for customers, you can add that tag pairs to the config file, specifically for the Transit Gateways that are provisioned by LZA. I'd first validate the current Accel-P value in your TGWs, but if you're using the default value for the Accelerator prefix, you should just be able to add the following tag values in your network-config.yaml file to ALL Transit Gateways.
tags:
  - key: Accel-P
    value: AWSAccelerator

When a changeset is performed at the Network-Prep stack in the Deployment stage of the pipeline, CloudFormation will see that nothing has changed and the aforementioned Modify call will not be invoked. We will provide an update on when the static TGW CIDRs are natively supported in the LZA solution as part of a feature release as this current exists in our backlog.

[Intranet logo]
[like]  Houessou, Pierre-François (DGR... reacted to your message:

From: Bo Lechangeur @.>
Sent: Monday, February 26, 2024 2:59:37 PM
To: awslabs/landing-zone-accelerator-on-aws @.>
Cc: Houessou, Pierre-François (DGRI-Consultant) @.>; Mention @.>
Subject: Re: [awslabs/landing-zone-accelerator-on-aws] Transit Gateway Cidr Blocks not supported in network config (Issue #326)
Hi @hpf-mrnfhttps://github.com/hpf-mrnf ! Thank you for utilizing the Landing Zone Accelerator on AWS (LZA) solution. We've had several end-users run into this issue when upgrading from 1.4.x version to a version after 1.5. In the 1.5 version, we remove an Accel-P tag from the solution which gets removed from most of the resources that add this that are supported by the LZA solution, Transit Gateways included. When CreateTags or DeleteTags API calls are done with Transit Gateway, there's a Modify API call that is performed to resolve the drift between what's in CloudFormation and the current state of your resource. CloudFormation is then attempting to get your Transit Gateway in a desired state by removing the static CIDR that you implemented.
As a workaround for customers, you can add that tag pairs to the config file, specifically for the Transit Gateways that are provisioned by LZA. I'd first validate the current Accel-P value in your TGWs, but if you're using the default value for the Accelerator prefix, you should just be able to add the following tag values in your network-config.yaml file to ALL Transit Gateways.
tags:

key: Accel-P
value: AWSAccelerator

When a changeset is performed at the Network-Prep stack in the Deployment stage of the pipeline, CloudFormation will see that nothing has changed and the aforementioned Modify call will not be invoked. We will provide an update on when the static TGW CIDRs are natively supported in the LZA solution as part of a feature release as this current exists in our backlog.
—
Reply to this email directly, view it on GitHubhttps://github.com/awslabs/landing-zone-accelerator-on-aws/issues/326#issuecomment-1964348323, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A7PWGPDKD3BASGMRHYJDJ6DYVSPNTAVCNFSM6AAAAAA7LLPLBGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNRUGM2DQMZSGM.
You are receiving this because you were mentioned.Message ID: @.***>

Hello,
We have released support for static CIDR blocks (IPv4 and IPv6) in our 1.8.1 release. This is a sample config:
transitGateways:
  - name: Network-Main
    transitGatewayCidrBlocks:
      - <IP_ADDRESS>/20
      - <IP_ADDRESS>/20
    transitGatewayIpv6CidrBlocks:
      - 2001:db8::/64
    account: Network
    region: *HOME_REGION
    shareTargets:
      organizationalUnits:
        - Infrastructure
    asn: 65521
    dnsSupport: enable
    vpnEcmpSupport: enable
    defaultRouteTableAssociation: disable
    defaultRouteTablePropagation: disable
    autoAcceptSharingAttachments: enable
    routeTables:
      - name: Network-Main-Core
        routes: []
      - name: Network-Main-Segregated
        routes: []
      - name: Network-Main-Shared
        routes: []
      - name: Network-Main-Standalone
        routes: []

If you're using this IP address currently and want LZA to take over, you'll have to remove the IP address from the TGW, then have LZA provision. We also support TGW Connect Attachments as part of our 1.8.0 release, but don't support direct peering as of yet. If you remove the IP address, the Connect Attachment peers will have to be brought down momentarily. Please let me know if you have any other questions or concerns.

Thank you for the update.
Question:
If we currently have a ipv4 CIDR assigned manually to the TGW and run the
LZA upgrade to 1.8.1 without it defined in the yaml file  - will the "now
supported version" attempt to remove the manually assigned CIDR?
Thanks,
Ryan
On Mon, Jul 8, 2024 at 1:58 PM Bo Lechangeur @.***>
wrote:

Hello,
We have released support for static CIDR blocks (IPv4 and IPv6) in our 1.8.1
release
https://github.com/awslabs/landing-zone-accelerator-on-aws/tree/release/v1.8.1.
This is a sample config:
transitGateways:

name: Network-Main
transitGatewayCidrBlocks:

<IP_ADDRESS>/20
<IP_ADDRESS>/20
transitGatewayIpv6CidrBlocks:
2001:db8::/64
account: Network
region: *HOME_REGION
shareTargets:
organizationalUnits:

Infrastructure
asn: 65521
dnsSupport: enable
vpnEcmpSupport: enable
defaultRouteTableAssociation: disable
defaultRouteTablePropagation: disable
autoAcceptSharingAttachments: enable
routeTables:

name: Network-Main-Core
routes: []
name: Network-Main-Segregated
routes: []
name: Network-Main-Shared
routes: []
name: Network-Main-Standalone
routes: []

If you're using this IP address currently and want LZA to take over,
you'll have to remove the IP address from the TGW, then have LZA provision.
We also support TGW Connect Attachments as part of our 1.8.0 release, but
don't support direct peering as of yet. If you remove the IP address, the
Connect Attachment peers will have to be brought down momentarily. Please
let me know if you have any other questions or concerns.
—
Reply to this email directly, view it on GitHub
https://github.com/awslabs/landing-zone-accelerator-on-aws/issues/326#issuecomment-2214837200,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A2TJ2JUZTDR54HR244ABSMLZLLHM5AVCNFSM6AAAAAA7LLPLBGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMJUHAZTOMRQGA
.
You are receiving this because you commented.Message ID:
@.***>

Hi Ryan,
It shouldn't attempt to remove it in 1.8.1. If you have another pipeline/process that added the static CIDR to the TGW, it should be fine.

Thank you!
On Tue, Jul 9, 2024 at 10:41 AM Bo Lechangeur @.***>
wrote:

Hi Ryan,
It shouldn't attempt to remove it in 1.8.1. If you have another
pipeline/process that added the static CIDR to the TGW, it should be fine.
—
Reply to this email directly, view it on GitHub
https://github.com/awslabs/landing-zone-accelerator-on-aws/issues/326#issuecomment-2217914813,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A2TJ2JXAHLULKQ4W2SJCVKDZLPZBVAVCNFSM6AAAAAA7LLPLBGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMJXHEYTIOBRGM
.
You are receiving this because you commented.Message ID:
@.***>


demo app application.properties id setting

In demo app application.properties, how do one find the id information to be set in the properties file?
is routerId = Ref Id?
comms.routerId=
comms.planId=
comms.queueId=

Exactly. I admit the name is a bit misleading. Will clarify in the doc and change it in subsequent release.

@ikrustev  Could you provide some example here. I am trying to get the demo app working.

@weihongchua here you are. Let me know if you need anything else:
# the demo application callback as visible by the router
app.callbackBaseUrl=http://localhost:8080/demo-application/api

# the demo application callback as visible by nexmo (external URL)
app.nexmoCallbackBaseUrl=https://api.comms-router.com/demo-application/api

app.phone=<some phone number>
comms.queueId=queue-ivr
comms.planId=simple-menu
comms.routerUrl=http://localhost:8080/comms-router-web/api
comms.routerId=router-ivr
nexmo.appId=<nexmo api id>
nexmo.appPrivateKey=private.key
app.musicOnHoldUrl=<some music on hold url>

Is the following the answer_url that needs to be configured in Nexmo voice application?
the demo application callback as visible by nexmo (external URL)
app.nexmoCallbackBaseUrl=_**https://api.comms-router.com/demo-application/api**_

@angel-popov could you, please, verify the config I've posted here and answer the questions?

callback parameter is specified in the property. Note that it accepts user and password if any.
<EMAIL_ADDRESS>In nexmo voice setup - we should add
<EMAIL_ADDRESS>  - as event url and
<EMAIL_ADDRESS>- as answer url
When router assigns a task to agent, the router calls task's callback-url. In the body of the request there is info about task, the queue and router.


Feature: Ability to specify start vmid.

Without the ability to specify the vmid used, only one cluster can be created on any one proxmox host (cluster will be overwritten otherwise)
Specifying the start vmid, which is used for the support node, allows auto numbering of the master and worker nodes.

Hey @mannp, thanks for bringing this up! Can you walk me through the scenario you are trying to fix? I understand this is related to the VM IDs being reused, but from the documentation on the vmid option it specifies:
The ID of the VM in Proxmox. The default value of 0 indicates it should use the next available ID in the sequence.

Documentation Ref

To me, this description suggests that Proxmox itself should handle finding a unique ID for the new VM and avoid any overwriting situation except when it is intentional to update some setting on an existing vm.

Created https://github.com/fvumbaca/terraform-proxmox-k3s/pull/16 as unable to rebase this PR to a new branch.


Which is the latest version of mongo compatible with mongo_mapper?

Hi, I have an old app using mongo_mapper and now I want to move DB host ... which is the latest version supported by mongo_mapper ?
Thank you for your answers

Mongo 3.0. Mongo 3.2 is not, as it doesn't support the Ruby 1.x driver. Note that for Mongo 3, you need the Ruby Mongo 1.2.x driver, which has some set-up requirements with MongoMapper. The email list had some discussion on this.


Fix issue with parsing data

Switches "data[1]" to "data"

having issues testing on my local machine so i'm pushing changes to have ci run tests

tests seem to be passing now

LGTM. Thank you!


faster CRC32 implementation

use slicing by 8 algorithm with bigger precomputed tables
roughly 4x faster

Ok, I hadn't digested that hasUnalignedReads was only to force that optimization in DMD rather than to provide a per-architecture switch.
LGTM on the basis of matching other slicing by 8 implementations.

After your comment, I was actually a bit unsure whether genTables is endian correct, so I build a gdc cross-compiler and tested on my router. Will add a comment that the uint reads must be little endian.

LGTM, also love the CTFE construction of the table.

Auto-merge toggled on

Dumb question here but why can't sse4 crc32 numonics be used when available? I apologize of the answer is obvious

@bgaff SSE4.2 crc32 instruction is for castagnoli polynomial, not IEEE.


iTerm printing setopt aliases & saved aliases every startup

Hi folks,
I'm not really sure this is the best place for posting but I'm really struggling to find a resource to help. It's also, more than likely, a really simple fix.
Since installing oh my zsh my terminal keeps printing the following on startup;
saved aliases
setopt aliases

It is driving me insane! How do I stop this?

I'm not sure how I fixed it but it is now fixed.


Fix safari copy button issues

Fixes #1724
Safari has a bug where hover does not always work on hidden elements (safari has had, and continues to have, several :hover bugs). A workaround to this is to set the copy button opacity to 0 by default instead of setting its visibility to hidden.
Safari also has behavior where you are only allowed to copy to the clipboard directly after a user action, not in an async context. There used to be workarounds for this restriction, but they no longer seem to work.
Unfortunately, fluentui-blazor is incompatible with this requirement. It does not allow you to attach a JS onclick listener to a FluentButton (@vnbaaij), but even if it did, and even if you synchronously invoked JS from Blazor (asynchronous invocation again runs into the same issue), I believe you would still run into a permissions issue because call into Blazor from JS is asynchronous.
Seemingly the only way to workaround this issue is to attach an onclick listener in JS to the two places where you are allowed to copy (GridValue and log message popup) after component render, so that we fulfill Safari's requirement of synchronous clipboard write after a user action.
Microsoft Reviewers: Open in CodeFlow

Do you have a link to the safari bug or further details on it. I'm just curious to read about the scenario, because the element with :hover isn't actually hidden - it's a parent of the thing that's hidden.

I don't like using InvokeJS to attach/detach the event handler. Is it necessary?
What about this:
    <FluentButton Appearance="Appearance.Lightweight"
                  Id="@_anchorId"
                  Class="defaultHidden"
                  AdditionalAttributes="@(new Dictionary<string, object> { ["onclick"] = $"copyTextToClipboard('{_anchorId}', '{ValueToCopy ?? Value}', '{Loc[nameof(ControlsStrings.GridValueCopyToClipboard)].ToString()}', '{Loc[nameof(ControlsStrings.GridValueCopied)].ToString()}');" })">
        <FluentIcon Class="copy-icon" Style="display:inline;" Icon="Icons.Regular.Size16.Copy" />
        <FluentIcon Class="checkmark-icon" Style="display:none;" Icon="Icons.Regular.Size16.Checkmark" />
    </FluentButton>

That lets you add an onclick attribute to the fluent-button component. I assume that gets wired up to a regular button's onclick event.
This works in Chrome. Can you test in Safari?
Note: It needs hardening to encode the string values being passed to the method. (a comma in the value will break it right now). Using attributes on the element as the source of values might be better.

Do you have a link to the safari bug or further details on it. I'm just curious to read about the scenario, because the element with :hover isn't actually hidden - it's a parent of the thing that's hidden.

I unfortunately don't have an actual bug report link for this specific hover issue, just an article and stack overflow comments that mentioned others ran into the same behavior.

What about this:

Ah, that is so much better of a solution, thank you James! I'll update the branch and test this in safari, but would be shocked if it did not work. I'll update with results

I can confirm it works in safari


Allow files to be skipped via some repo-level configuration file

Having the ability to skip files via some kind of .linter-alex.yml would be handy.
E.g.
---
skip:
- CODE_OF_CONDUCT.md

Just dropping by to leave my 👍 for this.
https://github.com/probot/probot/pull/611/checks?check_run_id=6710790
All the probot repo's use the same CoC which triggers it. I would even consider suggesting ignoring CoC in the run entirely, considering the templates for all the major ones will trigger these checks.

All the probot repo's use the same CoC which triggers it. I would even consider suggesting ignoring CoC in the run entirely, considering the templates for all the major ones will trigger these checks.

I second this, as we hit the same issue in Git for Windows: https://github.com/git-for-windows/git/pull/1756/checks?check_run_id=7019837

Quick status update:
I want to get some good test coverage in place (#7) before working on enhancements. Once I have good coverage, this will be top of my list to tackle next.

I just want to register my support for this request. Currently, my code-of-conduct.md file triggers linter-alex because it makes references to sexual harassment, etc. That's good, since that means it's working, but that's the one place I want to mention things like that.


import_whisper: Handle input directories not ending with /

This change is

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

biggraphite/cli/import_whisper.py, line 101 [r1] (raw file):

        relative_path = os.path.relpath(path, self._opts.root_directory)
        relative_path_noext = os.path.splitext(relative_path)[0]
        metric_name = relative_path_noext.replace(os.path.sep, ".")

Please put this in a separate function and add tests & comments :)

Comments from Reviewable

Coverage decreased (-0.3%) to 93.008% when pulling 91232c409fd849aa2c56e1bd10f98417f0d3ba78 on unbrice:master into 9703bd08c2c2182821e131e69857c7b730f26e07 on criteo:master.

Coverage increased (+0.02%) to 93.333% when pulling 91232c409fd849aa2c56e1bd10f98417f0d3ba78 on unbrice:master into 9703bd08c2c2182821e131e69857c7b730f26e07 on criteo:master.

Review status: 0 of 2 files reviewed at latest revision, 1 unresolved discussion.

biggraphite/cli/import_whisper.py, line 101 [r1] (raw file):
Previously, natbraun (Nathaniel Braun) wrote…
> Please put this in a separate function and add tests & comments :)

Done.

Comments from Reviewable

Reviewed 2 of 2 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

Previously, coveralls wrote…
>
> [![Coverage Status](https://coveralls.io/builds/6418017/badge)](https://coveralls.io/builds/6418017)
>
> Coverage increased (+0.02%) to 93.333% when pulling **91232c409fd849aa2c56e1bd10f98417f0d3ba78 on unbrice:master** into **9703bd08c2c2182821e131e69857c7b730f26e07 on criteo:master**.
>

Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

Coverage increased (+0.05%) to 93.366% when pulling 4c0559c9efd7242d3213533b8e7253e1b75b7ccb on unbrice:master into 9703bd08c2c2182821e131e69857c7b730f26e07 on criteo:master.


OperatorGroup expansion/contraction

This takes the commits from #675, and rebases them one at a time to get them working with newer changes to OperatorGroups.
I'd like to double check / write a test for any possible edge cases here. The one that comes to mind is: the same CSV supports AllNamespaces and SingleNamespace, and we accidentally overwrite a "real" CSV with a "copied" CSV. It may be better to go ahead with these and follow up with that test case / fix, though, given that this is blocking.

/retest

/retest

/test unit

/retest

/retest

/retest

/test unit

/retest

/test e2e-aws-olm

/test e2e-aws-olm

/test e2e-aws-olm

/retest

/test unit


Synchronizing Tickets in different Github Projects

Based on the new Deployment and QA Process definition, we need a workflow/GA that automatically moves the tickets to the correct columns in the respective boards. This is most important for QA tickets, that are planned within a sprint, created within the application Github project (e.g. sightline) and added to the testing Github project as well:

Note that these tickets have the label type: qa
While the QA team is testing, they manually move the ticket to "In Progress" in the testing Github project  --> the ticket should then be transferred automatically to "In Progress" in the application Github project as well
Once the QA team is done, they will move the ticket manually to "Done" in the testing Github project --> the ticket should then be transferred automatically to "Review" in the application Github project
The PO takes the ticket from "Review", derives his/her measures, and moves the ticket to "Closed" in the application Github project --> the ticket should then be transferred automatically to "Closed" in the testing Github project as well

If any of this is unclear, please feel free to ping me!

syncing issues in this manner doesn't seem to be supported (yet)
actions I found managing issues:
from a verified creator: this one add issue to the default column only.
https://github.com/marketplace/actions/add-to-github-projects
from non-verified:
https://github.com/marketplace/actions/issue-sync-action
https://github.com/marketplace/actions/move-issues-to-column

The core team has decided to not do this because it is quite complex and not worth the investment. The proposed way is to simply use the QA meeting to do this.


BUG: Database.migrate() removes useful lines from scripts

Description
If a migration script contains a line which starts with -- which is inside an actual string value, it will be considered as a comment and thus removed from the eventual script.
Steps to reproduce
Considering this migration script:
-- Up
CREATE TABLE whatever ( certificate TEXT );
INSERT INTO whatever ( certificate ) VALUES (
  '-----BEGIN CERTIFICATE-----
some contents
-----END CERTIFICATE-----');

-- Down
DROP TABLE whatever;

calling db.migrate() will fail due to a syntax error
Explanation
Calling db.migrate() will parse the up script, and will remove the line -----END CERTIFICATE-----'); because it starts with --.
Code which causes this problem: https://github.com/kriasoft/node-sqlite/blob/master/src/Database.js#L170
migration.up = up.replace(/^--.*?$/gm, '').trim();

Published under 2.6.0


Remove for loops variable mangling

Remove for loops variable mangling
Variable declarations in for loops get mangled because the loopFunctionaliser extracts the declarations into the same scope where the loop is instead of creating a new one. Hence, if those variables don’t get mangled, having two separate for loops  in the same function such that both of them declare a variable i, would fail because we would have two different definitions of the variable i in the same scope.
Once the way we handle for loop changes, this mangling should be removed.

can you assign this issue to me? @piwonskp

Sure, done :)

Hi @MostlyGenius !
This task was meant to be done after modifying the way we handle loops in the LoopFunctionaliser pass, and that's something that is on hold at the moment. Although removing the mangling for the variables is a good first issue, working with the pass that handles loops implies modifying a lot of the codebase, so I don't think this is something you should dive into right now.
Sorry about this. We have other good first issue tasks that you can work on if you want to, we appreciate you contributing to the project.