added data types UInt16,UInt32,UInt64 to bitinformation_wrapper.jl

For some reason the notebook kernel died, but I don't understand why from the error message. It's nothing obvious to me or related to this pr. I'm running the failed test again

The error has nothing to do with this PR. It has something to do with the Julia package. At some point #217 seemed to fix it but that is no longer helping. This PR should no longer wait because of that.
Thanks for the contribution @Ishaanj18 and the additional clean-up @milankl


How to check against the cookie

How to check against the cookie so the gate isn't displayed for users who already answered it?

Hi @ghost - I'm sorry for the slow response. I've just released v4.0.0, which is a complete rewrite of this library, and therefore I'm closing this issue because it no longer applies to the current version.
I hope the new version meets your needs.


how can i get the ServerWebExchange anywhere ?

Question
i want to get the ServerWebExchange anywhere, and get some parameters from ServerWebExchange, how can i get it, thank you

You can refer to the responsive context. link:https://projectreactor.io/docs/core/release/reference/#context
You can put serverwebexchange into the responsive context in the interceptor, and then you can get it in the subsequent business code

thank you @hutaishi


Ruidacontrol Rastering

Detect and process rasters for the ruida control emulator.

I guess by popular demand I should push this code back to the front burner. It wasn't too far from working.

👍

This should be an improvement but is not apparently finished. There's a couple seemingly okay modes that fail horribly like trying to raster something at an angle. It goes insane. It actually should be able to be made to work.
If that's sort of required we could push this back a bit. Also, I think there might have been an error at speed that caused a hit. I'll see if there's something notably quick to fix this stuff like forcing a direction shift for the h_switch which would make sense if the direction was somehow wrong.

I would suggest that we tidy up what we have without angled rastering and (ideally with my rastering optimisation finished - I just need to analyse and handle the accelerations) push out another beta or even full release.

I think this might still have a tiny break at the very start point where it goes the wrong way. I tried. forcing the directionality but it seemed like it was still wrong. I think maybe directional angle rastering might be somewhat required since getting things right like that tend to have knock on effects. And the start pip could be something like that.
If it moves at an angle, but does not change the x direction. So we to __/-- it wrongly inverts that because it expects things to only go ==|  So I think the same problem here might be manifesting in a couple different ways.

The issue is that it's detecting a raster and thinking because it didn't move up or down by more than 15 and 1 direction of the cardinal directions wasn't seen that that is a raster. But, it fails to account for movements up while moving in a lateral direction.
I tried super-alt-rasters where I do not do any y-changes in a flip around. I just process the y-change whereever I hit one, but I could hear it move where it was a lot softer inside the N-SE switch. But, I think I might just bite that bullet and do it that way anyway since unlike this it would be able to do laterial shifts without inverts.

I couldn't solve it, got mostly grinding out of my laser. It should be plausible not sure what I did wrong. Might need to run some more tests with that. This is certainly an improvement but the starting up hit should be fixed and maybe things in the driver need some rewriting still. I'll try again tomorrow (much later today). 16 hours from now or so. But, this is like 95% of the way there. Turns out +15 is enough to cause most angles to count as non-rasters. Since they tend to go up by more than that over the distance of the image.
Even tiny images at low angles didn't work. Caused some unknown error where it would try to force raster the same direction twice. The enforce thing might have fixed the first hit.
This stuff could certainly be tested a bit, but I think it's still a little wrong and I'd sort of prefer isolating the direction swaps in this thing.

yes - what is commonly used needs to work fully - rare things less so.

On reflection, I think this should be merged before we spit out a full release.

Okay.


Using slice to get holidays between two dates only returns holidays from the start year and the end year

STEPS TO REPRODUCE

Aim: retrieve list of all holidays between 2014-12-31 and 2016-01-01

us_holidays = holidays.US()
us_holidays['2014-12-31': '2016-01-01']

EXPECTED BEHAVIOUR

Retuns a list of all holidays in 2015 plus 1st January 2016

OBSERVED BEHAVIOUR

Returns [datetime.date(2016, 1, 1)]

Hi,
to be honest, in the provided example the 2 dates - written as strings - don't seem suitable for a python "slicing", and therefore are considered as 2 elements.
Then, the library works as expected / documented, ie: collecting holidays for the years of all the provided dates (2014, 2016), so
import holidays
us_holidays = holidays.US()
us_holidays['2014-12-31': '2016-01-01']
us_holidays

correctly shows holidays for both 2014 and 2016.
Available for further clarifications, thx!

@dr-prodigy
I took a look at the original code and it does seem to be set up for accepting slicing of two dates, as per the code below in __getitem__ (the call to __keytransform__ allows the keys to be in any of the supported formats, including an ISO 8601 string):
https://github.com/dr-prodigy/python-holidays/blob/5cde25b7e2e15578c7c1ab6e3f1a7ebda444fd80/holidays/holiday_base.py#L241-L274
However, I don't think that the recursive call to dict.__getitem__(self, day) in line 270 gets to expand (load) the dates, but calling self.__getitem__(day) instead does.
So it's basically a one-line fix that I will submit as a PR.

@justinwaf
Thanks for taking the time to report this.

EXPECTED BEHAVIOUR

Returns a list of all holidays in 2015 plus 1st January 2016

I just want to clarify that the expected behavior is incorrect: in Python, slicing is done with half-open intervals and upper bounds are exclusive . See https://stackoverflow.com/questions/11364533/why-are-slice-and-range-upper-bound-exclusive
Once the fix is in, the behavior is to return 2014-12-31 if it were a holiday (it isn't so it won't) and all holidays for 2015, but not return 2016-01-01.

Hi, I hope I'm not mistaking but, to be honest, in the provided example the 2 dates - written as strings - don't seem suitable for a python "slicing", and therefore are considered as 2 elements.
Then, the library works as expected / documented, ie: collecting holidays for the years of all the provided dates (2014, 2016), so
import holidays
us_holidays = holidays.US()
us_holidays['2014-12-31': '2016-01-01']
us_holidays

correctly shows holidays for both 2014 and 2016.
Please let me know if I didn't catch it right, I'm available for further clarifications.. thx!

The example I used was a slightly expanded one I got from the README.rst
us_holidays['2014-01-01': '2014-01-03']  # [date(2014, 1, 1)]
From this example I understood that you could send in 2 dates as strings and get back a list of all the holidays in between (and not including the end date).  What I observed is I only got holidays for the year of the first date, and the year of the last date, and the years in between were skipped.

Hi @justinwaf and @mborsetti
thank you both for your support!
After a further analisys on your points (sorry for not understanding them in first place), I confirm you are both right.
The issue was probably buried in the code since before I started working on the lib, so good shot!
I noticed the PR made by Mike has been closed, so I re-applied it (one row fix, quickwin! :-) ) in a new commit.
Thank you both again, KUTGW! 👍


Syntax highlighting is broken when there is no semicolon after a type declaration

We don't use semicolons in my project, so this is really annoying. It breaks everything after it.
<script lang="ts">
type T = any
</script>

(opened here since vuejs/language-tools#986 was closed without an actual fix)

Also seemed to be fixed in https://github.com/microsoft/TypeScript-TmLanguage/commit/d1a9c200322c3dc3fb8a9d0e0912b478cdf973ff.

This is no longer an issue in versions shipped for ST4153+.


Revisit line clamp

We have a dependency vue-clamp for it. Modern CSS already has it: https://caniuse.com/?search=line-clamp but vue-clamp doesn't fallback to this CSS at all. Instead it has a resize observer and does calculations that may be affecting performance.
Kolibri is also doing this with CSS in a TextTruncatorCss component that we should be using directly or borrowing: https://github.com/learningequality/kolibri/blob/develop/kolibri/core/assets/src/views/TextTruncatorCss.vue

One more reason to do this: the "ResizeObserver loop limit exceeded" we are constantly seeing while developing seems to come from the resize-detector dependency of vue-clamp.

Archiving without further QA. Would be a dev-QA.


h: cleanup node by replaceWith

Mutating node from-to must clean up previous observers to clean up memory

Fixed by reinit components


build: simplify dependencies

Purpose
RAI's default python environment takes a lot of time to install. Some of the dependencies should be marked as optional.
Proposed Changes
Moved non-core dependencies to optional category
Issues

Links to relevant issues

Testing

How was it tested, what were the results?

@coderabbitai review


"#" in < ... > construct treated like comment

The # does not start a comment in <...> or <<...>>, but syntax makes it seem to.
> < a b # c d >
a b # c d
> << a b # c d >>
a b # c d

First of all, in the code you pasted, no <...> is getting string highlighting. Although if I remove the first character in the example (>) the <...> on the first line gets highlighted as a string, and the # inside it does not get highlighted as a comment. So I see no issue there. Do you see anything different? If so, are you running an older version of the syntax file?
As for the <<...>>, I do indeed see the # inside it highlighted as a comment. Rakudo doesn't support it, but I was going by S02 when I implemented it:

Colon pairs (but not arrow pairs) are recognized within double angles. In addition, the double angles allow for comments beginning with #. These comments work exactly like ordinary comments in Perl code.

See also some todo tests in roast: https://github.com/perl6/roast/blob/master/S02-literals/quoting.t#L244-250

I just updated to master, which was a small change.  Still I see the comment:

I must have had an older version, or perhaps it was fixed since I posted, since I'm pretty sure I updated then…
Thanks!


[$500] IOS - Chat animation appear in black color for a moment when opening app

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.21-1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:

Open New Dot app
Background the app
Open New Dot app again

Expected Result:
There should be no visual issues when open and reopen the app
Actual Result:
Application background is deformed.
Chat animation appear in black color for a moment when opening app
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[x] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

https://github.com/Expensify/App/assets/93399543/3f2e3398-d2d5-43f1-95b2-ca251b6bc26e
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01dac69aea47e33988
Upwork Job ID:<PHONE_NUMBER>533795840
Last Price Increase: 2024-01-24

Proposal
Please re-state the problem that we are trying to solve in this issue.
The chat background image shows as a dark mode when reopening the app. This only happens if we select the device theme.
What is the root cause of that problem?
This is a known old issue in RN. The background image will show either the dark or light variant depending on the system theme.
https://github.com/Expensify/App/blob/3b424bba3dfd691990755ecec3be5eae1125abf9/src/components/ThemeIllustrationsProvider.tsx#L10-L16
https://github.com/Expensify/App/blob/d4c3e63956e9c14838592172c7e0e8596b0814cf/src/hooks/useThemePreference.ts#L12-L21
However, the system theme value is updated multiple times when putting the app in the background.

One of the comments from the linked issue mentions that when we put the app in the background, iOS is trying to take a snapshot of the app on both theme modes, so the system theme is updated multiple times.
If we reopen the app while the system mode is updated to dark mode, we will see the dark image background.
What changes do you think we should make in order to solve the problem?

We can explore the workaround in the linked issue.
First option is to ignore the system theme changes if we are in the background.
const [isForeground, setIsForeground] = useState<Boolean>(true);

useEffect(() => {
    AppState.addEventListener('change', (state) => {
        setIsForeground(state === 'active');
    });
}, []);

useEffect(() => {
    ...
    if (!isForeground) return;
    if (theme === CONST.THEME.SYSTEM) {
        setThemePreference(systemTheme ?? CONST.THEME.FALLBACK);
    } else {
        setThemePreference(theme);
    }
}, [preferredThemeFromStorage, systemTheme, isForeground]);

What alternative solutions did you explore? (Optional)
The second option is to debounce the the changes.
const setThemePreference = useDebounce(
    useCallback(_setThemePreference, []),
    200,
    {leading: false, trailing: true},
)

I am not sure what the bug is exactly.
@bernhardoj would you elaborate?

The bug is the app switch between dark/light mode when you put it in the background and reopen it as shown in the video (0:21 - 0:22).

Issue not reproducible during KI retests. (First week)

@kevinksullivan bump on https://github.com/Expensify/App/issues/33894#issuecomment-1887653372

Issue not reproducible during KI retests. (Second week)

@kevinksullivan bump on #33894 (comment)

^

Not overdue

^

Sorry, missed closing this. No longer reproducible so I'm closing


Ambiguity in document (as one of the instances)

Link: https://learn.microsoft.com/en-us/sql/database-engine/sql-server-business-continuity-dr?view=sql-server-ver16#always-on-failover-cluster-instances
An FCI can participate in an availability group as one of the instances hosting either a primary or secondary replica.
Does this mean that only 1 side of the AG can be an FCI and the other side must be a standalone instance? Please can you clarify?
The term as one of the is confusing me.

Related to #8419


Respond to name

Steven should reply when someone mentions him

I GOT DIS!

😎 excellent, thank you.
I was also originally intending to get him to respond when using the steven emoji, but was having a hell of a time parsing custom emojis using discordrb... if you're feeling spicy @brooksbecton

resolved by #19


Use ConfigMap instead of .env for cluster configuration

e.g. number of validators, current version, etc
Otherwise everyone working on the cluster needs to keep their .env files in sync (!)

You'd still need to keep files in sync even if using ConfigMap. You don't want to keep committing ConfigMap changes to an open source repo.


Listener depends on Imagine

The event listener event takes an Imagine interface as a param which means that swapping out Imagine will not work because the event params will not match.

Resolved by #93


Spike - UDPIngress API completeness

The purpose of this issue is to spike and then track the requirements to graduate UDPIngress into a GA API.
This relates to https://github.com/Kong/kubernetes-ingress-controller/pull/1057 wherein we provided an initial POC of UDPIngress with v1alpha1.
The requirements are:

[x] ~design service backend functionality~ (to be implemented in https://github.com/Kong/kubernetes-ingress-controller/issues/1080)
[x] ~unit tests for all relevant UDPIngress functionality added to 100% coverage~ (to be implemented in https://github.com/Kong/kubernetes-ingress-controller/issues/1080)
[x] ~integration test coverage for UDPIngress to reduce the risk of later regressions~ (to be implemented in https://github.com/Kong/kubernetes-ingress-controller/issues/1080)
[x] ~documentation for the API provided, including basic usage, examples, and guides~ (to be implemented in https://github.com/Kong/kubernetes-ingress-controller/issues/1080)

Resolving this issue should be a result of spiking the issue and creating the relevant follow-up issues.

@shaneutt is to propose a way forward for whether 2.0 will come with UDPIngress v1alpha1 or v1beta1, and to refine issues https://github.com/Kong/kubernetes-ingress-controller/issues/1080 and https://github.com/Kong/kubernetes-ingress-controller/issues/1081 according to the results of the spike.

https://github.com/Kong/kubernetes-ingress-controller/issues/1080 is the relevant follow up item and is the required work to get us to GA.


[RfR] File version updates

@chrisseto This the last piece this Sprint in potential support of file-checkout, right? Did we decide to connect to a JIRA ticket? -- Thanks.

This looks good for CR2 given that the tests pass.

Is this still a dependency of file checkout? Does this need to be a hotfix?


Fix readme

@radar, I want to fix these on the readme:

Call humanize on 9s.
Fix install guide. It should be:  install from terminal or add to Gemfile and then require it.
Use triple backticks (```) instead of indentations to render them nicely on github.
Add :id to the list of locale in the configuration example.
Remove trailing comma after :fr.

What do you think?

@radar, since this won't really break the code and I think adds a little clarity to the readme, I'm going to merge it.

Thanks!


4.x: Inject update - collateral

Related to #7957
Changes

Modularization of the processors, now using a single annotation processor that uses "extensions" instead of multiple distinct processors
Re-implementation of processors for builder and helidon-copyright as "extensions"
Remove usages of io.helidon.config:helidon-config-metadata

Fix usages of @io.helidon.config.metadata.Configured and @io.helidon.config.metadata.ConfiguredOption

Enforce usages of @io.helidon.builder.api.Option.Configured and @io.helidon.builder.api.Option.Default*
Enforce usages of @io.helidon.builder.api.Prototype.Configured and @io.helidon.builder.api.Prototype.Provides

Fix some javadoc warnings
Update checkstyle plugin to 3.3.1 and checkstyle lib to 10.12.5

Deprecations
Mark modules as deprecated since 4.1.0 and to be removed in 5.0.0.

builder/processor (only described in builder/processor/pom.xml)
common/processor/processor
common/processor/helidon-copyright
common/processor/class-model

New modules

builder/codegen: formerly builder/processor implemented as a "processor extension"
codegen/helidon-copyright: formerly common/processor/helidon-copyright implemented as a "processor extension"
codegen/compiler: wrapper around javax.tools.JavaCompiler
codegen/codegen: code generator API
codegen/class-model: formerly common/processor/helidon-copyright
codegen/apt: one and only annotation processor
codegen/scan: isolates classgraph usage (3rd party) (dependency tree improvement)

Some of the files were touched due to git operation (it thought something was a move even if it was not). As a result, those files have activity reported in git, so they must have updated copyright.

Fixed copyright issue (squashed commits to remove the change).
Added deprecation to builder processor module, package info, and processor class.


HTTP client & connections debugging

Partially covers #256.

:save-request? option for the http/request that saves initial request into :aleph/request key of the response.

user=> (clojure.pprint/pprint @(http/get "http://netty.io" {:save-request? true}))
{:request-time 7,
 :aleph/keep-alive? false,
 :headers
 {"x-cache" "HIT from mail.3f.com.ua",
  ....
  "cache-control" "max-age=600"},
 :status 200,
 :connection-time 6,
 :body
 #object[java.io.ByteArrayInputStream 0x6a756c20 "java.io.ByteArrayInputStream@6a756c20"],
 :aleph/request
 {:save-request? true, :request-method :get, :url "http://netty.io"}}

It would be extremly useful to "save" the reference to the netty's HttpMessage instance that we're sending to the channel (e.g. to have :aleph/req and :aleph/http-req keys). But that's kinda tricky to do right now as this "hidden" by the requests/response stream machinery. So I'm still trying to wrap my head around the problem and find feasible solution.

clj-http has :debug option, which is hard to replicate. But we can achieve pretty much the same debuggability with netty's logging functionality. The key difference that it works on a connection level, not on a specific request level.

Introduced :log-activity option for connection pool that prepends io.netty.handler.logging.LoggingHandler instance into the connection pipeline to trace all events occuring. Looks like the following:
user=> (require '[aleph.http :as http])
user=> (def pool (http/connection-pool {:connection-options {:log-activity :info}}))
user=> @(http/get "http://netty.io" {:pool pool})
[aleph-netty-client-event-pool-1-2] INFO aleph-client - [id: 0x3ab83329] CONNECT: netty.io/<IP_ADDRESS>:80
[aleph-netty-client-event-pool-1-2] INFO aleph-client - [id: 0x3ab83329, L:/<IP_ADDRESS>:50738 - R:netty.io/<IP_ADDRESS>:80] ACTIVE
[aleph-netty-client-event-pool-1-2] INFO aleph-client - [id: 0x3ab83329, L:/<IP_ADDRESS>:50738 - R:netty.io/<IP_ADDRESS>:80] WRITE: 53B
         +-------------------------------------------------+
         |  0  1  2  3  4  5  6  7  8  9  a  b  c  d  e  f |
+--------+-------------------------------------------------+----------------+
|00000000| 47 45 54 20 2f 20 48 54 54 50 2f 31 2e 31 0d 0a |GET / HTTP/1.1..|
|00000010| 68 6f 73 74 3a 20 6e 65 74 74 79 2e 69 6f 0d 0a |host: netty.io..|
|00000020| 63 6f 6e 74 65 6e 74 2d 6c 65 6e 67 74 68 3a 20 |content-length: |
|00000030| 30 0d 0a 0d 0a                                  |0....           |
+--------+-------------------------------------------------+----------------+
[aleph-netty-client-event-pool-1-2] INFO aleph-client - [id: 0x3ab83329, L:/<IP_ADDRESS>:50738 - R:netty.io/<IP_ADDRESS>:80] WRITE: 0B
[aleph-netty-client-event-pool-1-2] INFO aleph-client - [id: 0x3ab83329, L:/<IP_ADDRESS>:50738 - R:netty.io/<IP_ADDRESS>:80] FLUSH
[aleph-netty-client-event-pool-1-2] INFO aleph-client - [id: 0x3ab83329, L:/<IP_ADDRESS>:50738 - R:netty.io/<IP_ADDRESS>:80] READ: 553B
         +-------------------------------------------------+
         |  0  1  2  3  4  5  6  7  8  9  a  b  c  d  e  f |
+--------+-------------------------------------------------+----------------+
|00000000| 48 54 54 50 2f 31 2e 30 20 32 30 30 20 4f 4b 0d |HTTP/1.0 200 OK.|
....

Another option here would be to include (always) a special version of LoggingHandler that's flexible enough to log events only in case :debug? is set to true for a specific request, but that's not always informative, cause we're loosing a lot of information (when/how the connection is made etc). @ztellman what do you think?

Reimplemented :save-request feature as a client middleware. Not it's more functional:

:aleph/request reflects all changes made by all middlewares

:aleph/netty-request holds a reference to Netty's DefaultHttpRequest object that was sent to the channel

:aleph/request-body key is introduces (when :debug-body set to true while sending request)

I don't really like underlying implementation with atoms, but that was the less intrusive way I found (not to break/rebuild requests/responses processing). Will add unit test here as well.
(pprint @(http/get "https://github.com" {:save-request true :debug-body true}))
{:request-time 686,
 :aleph/request-body nil,
 :aleph/keep-alive? true,
 :headers
 {"server" "GitHub.com",
  "content-type" "text/html; charset=utf-8",
  ...
  "cache-control" "no-cache"},
 :status 200,
 :aleph/netty-request
 #object[io.netty.handler.codec.http.DefaultHttpRequest 0x7495a23c "DefaultHttpRequest(decodeResult: success, version: HTTP/1.1)\nGET  HTTP/1.1\nhost: github.com\ncontent-length: 0"],
 :connection-time 357,
 :body
 #object[byte_streams.InputStream 0x72282fa6 "byte_streams.InputStream@72282fa6"],
 :aleph/request
 {:user-info nil,
  :request-url "https://github.com",
  :server-port nil,
  :uri "",
  :server-name "github.com",
  :query-string nil,
  :scheme :https,
  :request-method :get}}

@ztellman I think this one is ready for review now.

This looks good, but has a conflict with the multipart PR.


Fixed UWP column auto/stretch behavior

The boolean logic for auto/stretch was inverted. When dev specified stretch, auto was being assigned, and vice versa.
Fixed the boolean logic (also added check to invalidate negative star size entries) and verified changes using UWP Visualizer and Notifications Visualizer with all of the sample payloads
Before

After

@anbare,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

Fixes #399

:shipit:


Provide proper display name, description and icon for out of the box extensions

With #17068, Built-in extensions will be shown in the extension viewlet. This needs adopting all extensions to provide proper name, description, read me and an icon (if no icon is provided it, defaults to VS Code icon) so that user will know about what each extension is for.
I am assigning users based on the last change done to the extension. If you are not the owner, please assign it to actual owner, otherwise me. Also please check it off, if the current details are good enough
NOTE: Make sure display name and descriptions are translated using nls

[x] bat @aeschli
[x] clojure @aeschli
[x] coffeescript @aeschli
[x] configuration-editing @sandy081
[x] cpp - @sandy081
[x] csharp @aeschli
[x] css @aeschli
[x] diff @aeschli
[x] docker @aeschli
[ ] emmet @ramya-rao-a
[x] extension-editing @sandy081
[x] fsharp @aeschli
[x] git @joaomoreno
[x] gitsyntax @joaomoreno
[ ] go @ramya-rao-a
[x] groovy @aeschli
[ ] grunt @dbaeumer
[ ] gulp @dbaeumer
[x] handlebars @aeschli
[x] hlsl @aeschli
[x] html @aeschli
[x] ini @aeschli
[ ] jake @dbaeumer
[x] java @aeschli
[ ] javascript @mjbvz
[x] json @aeschli
[x] less @aeschli
[x] log @sandy081
[x] lua @aeschli
[x] make @aeschli
[ ] markdown @mjbvz
[ ] merge-conflict @chrmarti
[x] npm @egamma
[x] objective-c @aeschli
[x] perl @aeschli
[ ] php @roblourens
[x] powershell @aeschli
[x] python @aeschli
[x] r @aeschli
[x] razor @aeschli
[x] ruby @aeschli
[x] rust @aeschli
[x] scss @aeschli
[x] shaderlab @aeschli
[x] shellscript @aeschli
[x] sql @aeschli
[x] swift @aeschli
[x] theme-abyss @sandy081
[x] theme-defaults @sandy081
[x] theme-kimbie-dark @sandy081
[x] theme-monokai-dimmer @sandy081
[x] theme-monokai @sandy081
[x] theme-quietlight @sandy081
[x] theme-red @sandy081
[x] theme-seti @sandy081
[x] theme-solarized-dark @sandy081
[x] theme-solarized-light @sandy081
[x] theme-tomorrow-night-blue @sandy081
[ ] typescript @mjbvz
[x] vb @aeschli
[x] yaml @aeschli

Also please make sure that Read me is updated.

@sandy081 Do we have a common template for the readme? Or maybe have it generated from the description?
IMO it would be good to mention that the extension is a built-in extension, cannot be uninstalled but disabled.

Now that @joaomoreno has started it with the git extension I suggest that we add icons for the bundled extensions as well.

Any guidelines on where should (or shoudlnt) we get the icons from?

Read me will be auto generated from extension manifest details if not provided

@aeschli, @ramya-rao-a, @joaomoreno, @dbaeumer, @mjbvz, @chrmarti, @egamma, @roblourens
Looks like most of the extensions versions are at 0.1. Can you please check your extensions versions and bump them at least to 1.0

Done!

Done!

Done for Emmet. The only remaining thing for Emmet is the icon for which I have contacted the Emmet library owner. Should be able to get something in a day or 2

@sandy081 I've updated all extensions such that

the least version is 1.0.0
the Display Name for language related extensions are appropriately Basics/Features
removed "and other language features" from the description for all Language Basics extensions. That will just mislead users to expect more from the extension

The only thing left is to get icons for

Emmet
Typescript
Html
Css
Json
Markdown
Php

which is tracked in #44626.
We can close this issue

Thanks @ramya-rao-a
Closing this


[BUG] onFocusChanged does not work when the keyboard keeps staying active

onFocusChanged only works when:

The keyboard changes state from invisible to visible
The keyboard changes state from visible to invisible

However, it does not work when the keyboard keeps staying active and focusing on other widgets (such as TextField).
Because onFocusChanged depends on the visibility changes of the keyboard.
To Reproduce:

Click on a text field (onFocusChanged is triggered because the keyboard visibility is changed from invisible to visible)
Click on the html editor (onFocusChanged is not triggered because the keyboard visibility is not changed (it is still visible))
Click back to the text field (onFocusChanged is not triggered because the keyboard visibility is not changed (it is still visible))
Press the back button of the device so that the keyboard disappears (onFocusChanged is triggered because the keyboard visibility is changed from visible to invisible)

Smartphone:
Android: Pixel 6 Pro API 33
Flutter Doctor:
Doctor summary (to see all details, run flutter doctor -v):
[√] Flutter (Channel stable, 3.7.12, on Microsoft Windows [Version 10.0.17763.4252], locale tr-TR)
This is taking an unexpectedly long time...[√] Windows Version (Installed version of Windows is version 10 or higher)
[√] Android toolchain - develop for Android devices (Android SDK version 33.0.1)
[√] Chrome - develop for the web
[√] Visual Studio - develop for Windows (Visual Studio Community 2019 16.11.11)
[√] Android Studio (version 2022.1)
[√] VS Code (version 1.70.0)
[√] Connected device (4 available)
[√] HTTP Host Availability
• No issues found!

Hi @hurkanugur,
I have fixed this issue, deployed it in the ver 2.2.0. Please try it out and share the feedback.
Thanks :)


Added "no data" for legend items

Fixed legend date range for infrastructure forecast reported via COST-852.
Also added "no data" text to legend items with no report.
https://issues.redhat.com/browse/COST-852
Overview page

Historical page

Codecov Report

Merging #1795 (f04a802) into master (d98fe59) will increase coverage by 1.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1795      +/-   ##
==========================================
+ Coverage   70.51%   71.51%   +1.00%
==========================================
  Files         307      307
  Lines        5392     5891     +499
  Branches     1083     1404     +321
==========================================
+ Hits         3802     4213     +411
- Misses       1482     1655     +173
+ Partials      108       23      -85

Impacted Files
Coverage Δ

src/components/charts/common/chartUtils.ts
56.19% <100.00%> (+2.89%)
:arrow_up:

src/components/i18n/i18nProvider.tsx
57.14% <0.00%> (-9.53%)
:arrow_down:

src/pages/state/maintenance/maintenanceState.tsx
66.66% <0.00%> (-8.34%)
:arrow_down:

src/store/common.ts
81.81% <0.00%> (-7.08%)
:arrow_down:

...ponents/reports/reportSummary/reportSummaryAlt.tsx
52.94% <0.00%> (-7.06%)
:arrow_down:

src/api/reports/reportUtils.ts
27.77% <0.00%> (-6.71%)
:arrow_down:

src/api/forecasts/forecastUtils.ts
28.57% <0.00%> (-6.22%)
:arrow_down:

src/api/exports/exportUtils.ts
29.16% <0.00%> (-5.84%)
:arrow_down:

src/api/tags/tagUtils.ts
30.00% <0.00%> (-5.30%)
:arrow_down:

src/utils/permissionsComponent.tsx
30.76% <0.00%> (-4.02%)
:arrow_down:

... and 98 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d98fe59...f04a802. Read the comment docs.

Codecov Report

Merging #1795 (f04a802) into master (d98fe59) will increase coverage by 1.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1795      +/-   ##
==========================================
+ Coverage   70.51%   71.51%   +1.00%
==========================================
  Files         307      307
  Lines        5392     5891     +499
  Branches     1083     1404     +321
==========================================
+ Hits         3802     4213     +411
- Misses       1482     1655     +173
+ Partials      108       23      -85

Impacted Files
Coverage Δ

src/components/charts/common/chartUtils.ts
56.19% <100.00%> (+2.89%)
:arrow_up:

src/components/i18n/i18nProvider.tsx
57.14% <0.00%> (-9.53%)
:arrow_down:

src/pages/state/maintenance/maintenanceState.tsx
66.66% <0.00%> (-8.34%)
:arrow_down:

src/store/common.ts
81.81% <0.00%> (-7.08%)
:arrow_down:

...ponents/reports/reportSummary/reportSummaryAlt.tsx
52.94% <0.00%> (-7.06%)
:arrow_down:

src/api/reports/reportUtils.ts
27.77% <0.00%> (-6.71%)
:arrow_down:

src/api/forecasts/forecastUtils.ts
28.57% <0.00%> (-6.22%)
:arrow_down:

src/api/exports/exportUtils.ts
29.16% <0.00%> (-5.84%)
:arrow_down:

src/api/tags/tagUtils.ts
30.00% <0.00%> (-5.30%)
:arrow_down:

src/utils/permissionsComponent.tsx
30.76% <0.00%> (-4.02%)
:arrow_down:

... and 98 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d98fe59...f04a802. Read the comment docs.


When running v4 it gives me this error

root@mypc:~/wgd/src# ./wgd.sh start
| Starting WGDashboard with Gunicorn in the background.    |
Failed to read config file: /root/wgd/src/gunicorn.conf.py
Traceback (most recent call last):
File "/usr/local/lib/python3.8/dist-packages/gunicorn/app/base.py", line 111, in get_config_from_filename
spec.loader.exec_module(mod)
File "", line 848, in exec_module
File "", line 219, in _call_with_frames_removed
File "/root/wgd/src/gunicorn.conf.py", line 2, in
import dashboard
File "/root/wgd/src/dashboard.py", line 1244
return "Public key already exist."
^
IndentationError: unexpected indent
| Log files is under log/

Can you perhaps give some context to where you installed it, how, etc? I do suggest running the application not as root.

This is caused by v4 was still in development and the code is incomplete.


feat: added LeetCode problem 1,2

Created new directory for leetcode solutions, updated DIRECTORY.md and README.md
Description of Change

Checklist

[x] Added description of change
[x] Added file name matches File name guidelines
[x] Added tests and example, test must pass
[x] Added documentation so that the program is self-explanatory and educational - Doxygen guidelines
[x] Relevant documentation/comments is changed or added
[x] PR title follows semantic commit guidelines
[x] Search previous suggestions before making a new one, as yours may be a duplicate.
[x] I acknowledge that all my contributions will be made under the project's license.

Notes:

Hi @Panquesito7, @tjgurwara99
For problem 2, the CI is failing with the following warnings:
/home/runner/work/C-Plus-Plus/C-Plus-Plus/leetcode/src/2.cpp:29:9: warning: assigning newly created 'gsl::owner<>' to non-owner 'ListNode *' [cppcoreguidelines-owning-memory]
sum->next = new ListNode(val%10);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/runner/work/C-Plus-Plus/C-Plus-Plus/leetcode/src/2.cpp:35:9: warning: assigning newly created 'gsl::owner<>' to non-owner 'ListNode *' [cppcoreguidelines-owning-memory]
sum->next = new ListNode(carry);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
I guess it is because of the use of raw pointers instead of smart pointers. Is there a way to suppress this ?

Does this directory also fall under doxygen style guidelines?

Does this directory also fall under doxygen style guidelines?

I believe so. Not required, but if added, it's better, IMO.

Is there a way to suppress this?

It'd be better to use smart pointers, though.
I found this ti convert raw to smart pointer, it may help: https://www.sololearn.com/Discuss/1958592/how-can-i-replace-raw-pointers-with-smart-pointers

Does this directory also fall under doxygen style guidelines?

I believe so. Not required, but if added, it's better, IMO.

Ah alright!


Add getDel method + test"

Some suggestions from sonarcloud  @robinalfengard if you check the 5 issues.


[ArPow] source-build job template should support custom buildScript parameters

Per feedback from @hoyosjs from the Diagnostics repo, the sourceBuild job template should support custom buildScript parameters.  This is necessary for repos that need to specify custom parameters potentially along with a custom build script.  It appears that you can use the buildscript parameter to include parameters e.g. buildscript: ./build.sh /p:myproperty=true but that is not intuitively obvious to the consumer.

It's also not always supported (for example, properties need to be added at the end of the native build scripts in the runtime repo's scripts).

This is required to unblock ASP.NET CI.


Added link to covid19-data.ch

I have created a new page for visualizing the Covid-19 data from OpenZH and would like to add the link here.

Thanks @doerfli for your contribution!

Thanks @doerfli for your contribution!


Keyboard shortcuts not working even for actions operating on current branch

The shortcuts can be added in IntelliJ Settings.... but nothing happens :/ Likely an expected DataKey like PROJECT is missing.
Related to https://github.com/VirtusLab/git-machete-intellij-plugin/issues/264

The keyboard shortcuts work for me. Even the ones that work on Selected Branch - you just need to right click a branch and then press the key combination. @mkondratek, @vzmerr could you check if there's a problem in your IDEs?

Huh indeed, works for me as well now ;D probably got fixed accidentally in the meantime (as this is issue is almost 2 years old). Closing then 🎉


Add support for R4 searches of types String=>Token

User story
Add support for the R4 primitive types.
Acceptance criteria

Support is visible at the /metadata endpoint
Datatype is indexed correctly
Verify resources can be searched by version. e.g. ActivityDefinition.version with version=abc123

AB#72424


Authorisation

Is it possible to use cancan or other authorisation methods with elasticsearch or tire?

Don't know what you mean by that, sorry, could you be more specific?

In my current application i have build a simple search by querying the database directly. Authorisation is done by cancan (@articles = Article.accessible_by(current_ability) ) so i can define what a user is able to access (eg. User can only see tasks form projects he is involved).
What is the concept with tire/elasticsearch, do i have to setup different indexes for different users/permissions?

Several concepts you can use:

An index per user (has a performance penalty),
a filtered alias per user (http://www.elasticsearch.org/guide/reference/api/admin-indices-aliases.html)
filter by eg. user_id in the search block,
etc.

So eg. something like this for the last option:
Todo.search do |search|
  search.query { |q| q.string params[:q] }
  search.filter :term, current_user.id
end

Thanks for your help. Will have a look into this concepts.


GradientMaterial does not stay with the object it's applied to

Bug repro:
http://playground.babylonjs.com/#BWY5S5
Expected result:
Gradient material follows objects as they move
Current result:
Objects move out of the material

This is how it was designed :)
The gradient uses the world space coordinates of each vertex. so it is based on 0,0,0 as origin
I guess that you would be interested by a gradient based on local coordinates

It would be nice to have since we are trying to use it for a selection effect on objects that could be placed anywhere.
Are there many Materials that share this characteristic?
I'm not sure i understand why it isn't a bug, because a material is normally applied to a geometry and should match the transforms of the geometry it's on.  If a material does not match its geometry, is it actually a material?  Wouldn't it be some sort of effect instead?


fix: enabled toggle behavior for settings icon in sidebar

Description
Bug : Settings Bug Link
I have raised this PR In-order to ensure that the App Settings pane is closed when clicked on settings icon when it is open
Cypress testing video
https://github.com/appsmithorg/appsmith/assets/122865888/cd8b3452-3776-4ac2-82a0-577a7f9b1065

Summary by CodeRabbit

Tests

Refactored tests for table widget column editability to use a new method for toggling column settings.
Updated import paths and function calls in multiple test files for better modularity.
Enhanced test logic for SidebarButton to ensure onClick is triggered when toggling state.
Introduced a new test suite for validating the functionality of the App Settings pane, ensuring it behaves correctly when the settings icon is clicked.

Chores

Removed unnecessary properties and adjusted string messages in JSON fixtures to improve clarity and alignment with actual behavior.

/build-deploy-preview skip-tests=true

Updated reviewers based on current context.

/build-deploy-preview skip-tests=true

This issue should not be worked on as it requests a user experience that does not currently align to the IDE usability. Closing this


module 'hashids' has no attribute 'encode' - Python 3.6.3

Hi,
I found this interesting but testing on Python 3.6.3 result to error below.
> cd /tmp
> python3 -m venv env
> . env/bin/activate
(env) > pip install hashids
Collecting hashids
  Using cached hashids-1.2.0.tar.gz
Installing collected packages: hashids
  Running setup.py install for hashids ... done
Successfully installed hashids-1.2.0

(env) > python
Python 3.6.3 (default, Oct  4 2017, 06:09:15)
[GCC 4.2.1 Compatible Apple LLVM 9.0.0 (clang-900.0.37)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>>
>>> import hashids
>>>
>>> hashid = hashids.encode(123)
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
AttributeError: module 'hashids' has no attribute 'encode'
>>>
>>> ints = hashids.decode('xoz')
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
AttributeError: module 'hashids' has no attribute 'decode'
>>>

Any idea on how to resolve this? Thanks in advance.

The usage from the README is this:
from hashids import Hashids
hashids = Hashids()

@carltongibson thanks for pointing that out.


[Bug] Refresh needed to trigger methods

Found an issue or bug? Tell me all about!
Describe the issue / bug.
Hi, so my problem is that when I run npm run dev not all the methods inside the mounted method are called. In my case it specifically the firebase db.ref().on() method. It's the same thing no matter the component (in my case it was App.vue). So the only way to make it working is once I ran npm run dev press F5 to refresh.
Note that I did that on a non electron-vue project using vue-cli and webpack and I never had any problems.
The code.
./app/src/renderer/firebaseconfig.js
import Firebase from 'firebase'
var config = {
	apiKey: "myapikey",
    authDomain: "mydomain",
    databaseURL: "myurl",
    storageBucket: "mystoragebucket",
    messagingSenderId: "mymessagingSenderId"
};

var firebaseApp = Firebase.initializeApp(config);
var db = firebaseApp.database();

export {db};

./app/src/renderer/App.vue
import {db} from './firebaseconfig.js'
export default {
    mounted()
    {
      console.log(db) // This is working (I can see the db object)
      db.ref('myid/lang').on('value', (snapshot) =>{ //this is never called
            console.log("called")
        });
    }
  }

To reproduce the problem.

Just create a new electron-vue project using the normal settings (vue-resource, vuex, vuerouter).
Then just run npm install firebase --save inside the ./app directory.

My environnement

Node version: v6.7.0
NPM version: 3.10.3
vue-cli version: 2.7.0
Operating System: Windows

@GweltazCalori
This is not an issue with electron-vue. db.ref('myid/lang').on('value', <Function>) creates an event listener and will run console.log('called') on every new value. This works the first time (or on page refresh with F5) because the data is loaded in for the first time therefore emitting a value event. It doesn't work on a hot-reload because the value at myid/lang still hasn't changed, so the value event will not fire. This is expected behavior and should also happen on the official vuejs-templates/webpack scaffold as well.
You also stated that console.log(db) is "working" meaning that both functions will run. JavaScript isn't going to randomly stop in the middle of a function and "not [run] all the methods", and no webpack config is going to do that either.
I would highly recommend not to handling data within App.vue and would recommend moving/exporting from another file or use vuex to hydrate your components with data.

Thanks for the reply. Actually it's working in our webpack project so this is weird. The only thing I don't understand is why moving it to vuex will change something. Also the same thing happen if I move to another component. We used Vuex in the project but not for this specific part.

You said that

This works the first time

But in my case it's the opposite. It's not working the first time but working on reload or on modification of any files.

You said that

This works the first time

But in my case it's the opposite. It's not working the first time but working on reload or on modification of any files.

I've the same issue


[IMPROVEMENT] Split Piano King contract in two

Description
Piano King contract is a rather heavy contract in compiled code and is actually pretty close to the contract size limit of 24KB set by the EIP-170. Beyond that size, contracts cannot be deployed as they will be rejected.
To reduce the size, clean things up a bit, and divide some features, splitting the contract in two would be a nice solution. Piano King will remain the ERC721 contract and keep all its basic features. While the second contract could manage the batch mints by interacting with the Piano King contract.

Are the functionalities of both contracts already done and we just have to split them (refactor them) or does the second contract functionality need to be written?

Are the functionalities of both contracts already done and we just have to split them (refactor them) or does the second contract functionality need to be written?

It's only about splitting the current features of the Piano King contracts into two distinct ones that cooperate with each other. So there's no need to add any supplementary features, mostly refactorization then.

I read here that it is super expensive to make 2 contracts speak to each other, maybe we can think of 2 contracts that are completely separate from one another.
Ref: https://forum.soliditylang.org/t/mechanism-to-split-large-contracts/91/2

You raise a good point, even if each external call is just a couple of thousand gas it will get magnified by them being called multiple times in the batch mint functions in order to speak with Piano King contract to mint each NFT.
However, the solution of having the contract split into parts that do not speak to each other requires the use of Proxies or the Diamond Pattern which are rather advanced techniques leveraging DELEGATECALL to call other contracts with the context of the calling contract. This can introduce security risks if not handled properly.

Couldn't we run them independantly ? Are they dependent on each other ?

Most features are dependent yes. Minting requires direct access to Piano King contract storage to update the state of ownership and balance of addresses. Variable setters are for variables necessary on the contract itself.
I think we could maybe move the logic to request and receive the random number to another contract which will forward the number to Piano King contract on reception (so just that one interaction).
getTokenIdInRange and generateTokenId could be moved to a library as well since they are pure functions, although it will not change the size of the contract I believe.


Move code to trait

Q
A

Is bugfix?
❌

New feature?
❌

Breaks BC?
❌

Tests pass?
✔

What is the purpose of this change?

What is the purpose of this change?
This trait is reused in the yiisoft/yii-debug.
It is just duplicated now https://github.com/yiisoft/yii-debug/blob/5de4b3c2f02f11e8ca9ba5cb35bc3a1feab840ef/src/Proxy/ProxyTrait.php


Disable turbolinks-cache-control due to incompatibility with Chartkick

Chartkick doesn't work well with Turbolinks, because it requires a
"load" event that turbolinks does not provide.
Disable turbolinks in hyperlinks to the page that uses Chartkick.
Signed-off-by: David A. Wheeler<EMAIL_ADDRESS>

@jdossett - hopefully this solves the "back button" problem I mentioned before...!


Bluetooth Sensor like Propane Mopeka

first .. tks for that Integration :-).. i was using Yaml and Modbus for this ouf... lot of job
Do you plan to integrate Bluetooth Sensor like Propane Mopeka
in the print screen list has LPG Sensor

Did a upload ..value show up


Investigate options for timeboxing an issue

DOD:
Document the timeboxing options generated from the P4P reservation ideation meeting (March 18)

Spoke with Fred, Todd, Paul C, David W and Loren. The general opinion is that we continue to stick to the principle that the project should minimize the rule making and rely on the development community organization itself. Therefore, we are going to create some functionality that communicates to the development community that an issue is being worked on.


Christmas Wish: Retrofitting Disco to other sponge constructions

Dear Santa,
I am a very good boy, and I don't like 3D array based sponge functions that much.
Can I have a 2D array based cryptographic library? NORX already exists so I want that.

Go https://github.com/Daeinar/norx-go
JS https://github.com/kaepora/norx.js
Python https://github.com/Daeinar/norx-py
Python + NumPy https://github.com/therealmik/norxpy
C https://github.com/ctz/cifra
Java https://github.com/c-rack/norx-java
Ruby https://github.com/gazay/norxrb

Please I would like this Rave abstraction for experimentation.
Love,
D
(For serious though, Disco's model can be used to fit ANY sufficiently sized sponge function, maybe Fugue or Luffa for SHA3 candidates? pi-cipher or ICEPOLE for CAESAR parallelization candidates? Ascon or PRIMATEs or STRIBOB for non parallelization candidates? SPONGENT or PHOTON or QUARK for a more modern twist?)

haha, isn't this more of a request for strobe than disco :) ?
on the other hand, there is now xoodyak to replace strobe as well.

@mimoo it is more of a strobe + noise thing to work in unison. xoodyak is cool but the more experimental sponges the better.

Disco should actually be permutation oblivious. I think there's interesting work in making Strobe compatible with any permutation you want, the first place I would start would be naming (since Strobe's naming doesn't include the name of the permutation).
Unfortunately I don't really have the cycles currently, but I can help if you want to drive this :)

@mimoo in that case my Christmas wish can be fulfilled in https://github.com/mimoo/StrobeGo ?
Also a naming scheme change would be sweet since the more variation means more freedom.

that would be https://github.com/mimoo/StrobeGo for the Go implementation (which this repository makes use of), but there would be some work to be done on the protocol specification itself.


[DO NOT MERGE] Remove .button class

What / why
This PR removes the toolkit dependency on buttons, specifically removing the .button class and updating or removing any reference to it here. Note that before this PR can be merged the following PRs must also be merged (and probably deployed as well):

https://github.com/alphagov/publisher/pull/1202
https://github.com/alphagov/licence-finder/pull/683
https://github.com/alphagov/govspeak/pull/176
plus a PR yet to be written for whitehall 😁

Trello card: https://trello.com/c/d8D7JTJE/203-remove-design-patterns-buttons-from-static
Static itself isn't using the button class/mixin much, apart from the button on the survey popup. I've put in some manual fixes to make it look the same as it used to. To see the survey banner, run GOVUK.userSurveys.displaySurvey(GOVUK.userSurveys.defaultSurvey) in the console and click on the 'take a short survey' link.
Before:

After:

@injms I don't think govuk-frontend/publishing components is import to be able to use these?

@injms I don't think govuk-frontend/publishing components is imported to be able to use these?

The colours and spacings mixing and variables have been copied and pasted into static - so they're available to use without needing an import.
The copied-and-pasted stylesheets can be deleted when we can selectively import bits of the components gem - hopefully soon!

excellent! carry on, ignore me

now that we have mixins available, can we replace the typography ones as well?

@kr8n3r we can, but that'll be done as a separate piece of work.


ROE-1426 Run all validation checks when transaction is closed

Calling the 'validation-status' end-point when API validation is enabled now invokes the full set of checks
An error is added to the response if any checks fail
Unit tests added and updated

Addressing code smells...


Getting Segmentation Problem in -(NSDictionary*)toDictionaryWithKeys:(NSArray*)propertyNames

In my current application, I am converting a JSONModel object to JSON string calling toJSONString.
But the application crashes, in the line number 953 with the statement value = [self valueForKey: p.name]; in JSONModel.m file. Getting a error like
Exception Type:  SIGSEGV Exception Codes: SEGV_ACCERR at 0x447ca811 Crashed Thread:  0.

Sounds like JSONModel may think a property exists which actually doesn't. Could you provide samples of the models & JSON causing this?


Can I add pre-filled data?

Do you have a method for sending a pre-filled form field? We're using this to allow students to send feedback on one of our course tools and I want to hard-code the course information field. I am gonna try having a hidden form field that has a pre-flled value and see if that works, but am wondering if there is a better way to send a value in the form without having to have an input field.

I'm doing that and inject the URL of the page in the hidden input value="{{url}}" when submitted.


ARROW-10817: [Rust] [DataFusion] Implement TypedString and DATE coercion

This PR adds support for what the sqlparser crate calls TypedString which is basically syntactic sugar for an inline-cast. As this was an effort to get the TPC-H queries behaving correctly I then went a step further and added support for Date (temporal) coercion. I can split this PR if needed.
where
    l_shipdate <= date '1998-09-02'

is equivalent to
where
    l_shipdate <= CAST('1998-09-02' AS DATE)

FYI I am planning to tackle INTERVAL next.

Codecov Report

Merging #8892 (d21097e) into master (3deae8d) will increase coverage by 0.02%.
The diff coverage is 77.41%.

@@            Coverage Diff             @@
##           master    #8892      +/-   ##
==========================================
+ Coverage   52.98%   53.01%   +0.02%
==========================================
  Files         172      172
  Lines       30750    30781      +31
==========================================
+ Hits        16294    16319      +25
- Misses      14456    14462       +6

Impacted Files
Coverage Δ

rust/datafusion/src/physical_plan/expressions.rs
0.00% <ø> (ø)

rust/datafusion/src/sql/planner.rs
0.00% <0.00%> (ø)

rust/arrow/src/compute/kernels/cast.rs
96.20% <96.00%> (-0.01%)
:arrow_down:

rust/arrow/src/compute/kernels/take.rs
94.81% <0.00%> (+0.21%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0b9269...d21097e. Read the comment docs.

@andygrove could you please have a look?

I should note that these changes make the test more realistic and will likely reduce performance so we will need to bear this in mind when comparing benchmark results to previous results.

Thanks Andy. I will resolve the merge conflict.

Rebased so should be good to merge.

@andygrove I am actually expecting that comparison on date (in ms sine epoch / int64) should be faster than on strings (if no weird implementation)?
@seddonm1 unfortunately I am getting an error on master, as the CSV reader doesn't support dates yet.
Running benchmarks with the following options: BenchmarkOpt { query: 10, debug: false, iterations: 10, concurrency: 10, batch_size: 20000, path: "/home/danielheres/Code/gdd/arrow/rust/benchmarks/tpch-dbgen", file_format: "tbl", mem_table: true }
Loading table 'part' into memory
Loaded table 'part' into memory in 157 ms
Loading table 'supplier' into memory
Loaded table 'supplier' into memory in 12 ms
Loading table 'partsupp' into memory
Loaded table 'partsupp' into memory in 553 ms
Loading table 'customer' into memory
Loaded table 'customer' into memory in 139 ms
Loading table 'orders' into memory
Error: ArrowError(ParseError("Unsupported data type Date32(Day)"))

@Dandandan I was thinking about the overhead of converting the strings to dates, but you're right, if the data is stored natively in date format in Parquet then it should be faster. It would be slower than before against CSV though, probably.

@andygrove makes sense

@andygrove checked it, in https://github.com/apache/arrow/pull/8913 , indeed parsing is a bit slower, queries are faster

@andygrove checked it, in #8913 , indeed parsing is a bit slower, queries are faster

That is the right tradeoff in my opinion

Sorry I reopened this by accident.


Support for pip upper constraints

Each project can specify an upper constraints file to fetch and use to
constrain the deps and project itself.
A project can still opt out of being constrained.
This also has the byproduct of fixing source installs with a pypi mirror
(which was broken), and updating pip inside the virtualenv (which was
really really old).
Change-Id: Idb02f7bb3071f3cab336bf473d1c70ca1a7ede46

👍


Hundreds of flowtype errors

Using version 0.36.0 of flow-bin, adding react-navigation to the project results in ~350 flow errors. Also seeing this in react-navigation's example repos on a fresh clone.
I was hoping I could get around this with a flowconfig like:
[ignore]
.*/node_modules/react-navigation/.*
...

[libs]
node_modules/react-navigation/lib-rn
...

But still has 150+ errors.
If I am not the only one seeing this, please consider removing the Flow declaration files until they are working with the current React Native Flowtype version. I don't want to ignore the whole module and suppress each import ... from 'react-navigation'.
Thanks for your work on this! So excited to use react-navigation!

I'm also seeing this issue.

Removing flow declaration files won't fix the issue as long as we have annotations in the source code. You can ignore the errors in your flow config for now.
Under [ignore], add .*/node_modules/react-navigation/.*
Under [options], add module.name_mapper='^react-navigation$' -> 'emptyObject'
example config - https://github.com/satya164/PocketGear/blob/ea0cf98dae1b86f19aab874037a0aaeb25bfa464/.flowconfig

Thanks @satya164! Nice trick with module.name_mapper.

@satya164 recently cleaned up or suppressed all the remaining flow errors, so this should be resolved!

Thanks for your work on this, @satya164! I still see errors in the test files, but ignoring them with .*/node_modules/react-navigation/.*-test.js does the trick.


deploying to a namespace other than default

I want to deploy to the shinyproxy namespace and keep all spawned pods in the same namespace. This works for the deployment but the apps fail to start as the code is looking for the default namespace
Caused by: io.fabric8.kubernetes.client.KubernetesClientException: Failure executing: POST at: https://<IP_ADDRESS>/api/v1/namespaces/default/pods. Message: Forbidden!Configured service account doesn't have access. Service account may have been revoked. pods is forbidden: User "system:serviceaccount:shinyproxy:shinyproxy" cannot create resource "pods" in API group "" in the namespace "default".

For you defense it's not straightforward. Man should have to specify user's pod namespace only if it's different from Helm .Release.Namespace…


Exclude WORKLOADS for GKE Cloud Logging

For https://github.com/streamnative/cloud-ops/issues/357

Another (possible complementary) approach may be to define some exclusion filters in the appropriate GCP project. https://cloud.google.com/logging/docs/routing/overview#exclusions

That's interesting. Maybe take a closer look later


Conformance failure: proto2 + JSON + extension

This popped up on a CI bot:
CONFORMANCE TEST BEGIN ====================================
ERROR, test=Recommended.Proto2.JsonInput.FieldNameExtension.Validator: Expected JSON payload but got type 1. request=json_payload: "{\n        "[protobuf_test_messages.proto2.extension_int32]": 1\n      }" requested_output_format: JSON message_type: "protobuf_test_messages.proto2.TestAllTypesProto2" test_category: JSON_TEST, response=parse_error: "JSON failed to parse: unknownField("[protobuf_test_messages.proto2.extension_int32]")"

I sent some email looking for more info on proto2 extension support in JSON.

Let me know what you find.  I just pushed up a draft PR #1002 which is based on the design for TextFormat and the contents of the new conformance test.  It still needs a little work before I'm happy merging it, but it's enough to at least pass that test.

So far what I've been able to piece together:
Python has some support and tests that include extensions:

https://github.com/protocolbuffers/protobuf/blob/master/python/google/protobuf/json_format.py
https://github.com/protocolbuffers/protobuf/blob/master/python/google/protobuf/internal/json_format_test.py

And Go seems to (didn't hunt down their impl, just found a reference to the test):

https://github.com/golang/protobuf/blob/e9dc0d72c1a35f349f6d6871842199ddaaaf9edc/jsonpb/json_test.go#L317

Thanks, Thomas!  Those seem to verify what I guessed from the conformance test.  Extensions are handled essentially the same as in TextFormat:  The key name is surrounded by [] to mark it as an extension field name, but otherwise the coding is the same as regular JSON.
I think that's enough detail to finish up #1002 and get this landed.

Fixed via #1002


[Accessibility]A11y_VSCode_ShowOpenedEditors_Screenreader: JAWS is reading quick picker tree view twice.

Environment Details:
VSCode Version : 1.24.1
OS Version : Win10
Additional Details:
JAWS18.0.5038,MAS1.3.1
Repro Steps:
1)Launch VSCode.
2)Navigate   to welcome screen and beside opened editors pane at top(in middle   pane)->Select More(…)->Select "Show Opened Editors" from   dropdown.
3)Check with JAWS reading.
Actual:
JAWS is reading quick picker tree view twice.
Expected:
JAWS should not read quick picker tree view twice.
Recommendations:
Refer below link which is repository of bug fixes code snippets:
https://microsoft.sharepoint.com/teams/msenable/mas/pages/browse-fixes.aspx
User Impact:
This will create confusion for the user .
MAS Reference:
https://microsoft.sharepoint.com/:w:/r/teams/msenable/_layouts/15/WopiFrame.aspx?sourcedoc={8492c4eb-c179-40ae-8777-cd044ed725a2}
Does this issue occur when all extensions are disabled?: Yes
Attachment for Reference:
editor.pptx

Closing this issue as it's only observed in JAWS, and this isn't strictly needed to meet MAS C compliance.


refactor: move callback init to builder

Refactor to make IllegalActionAfterOpen impossible in engineio. This is not a breaking change thanks to @1c3t3a having the wisdom not to make public yet. Thank you.

Sending this PR into Draft as it(?)'s intermittently failing with "invalid namespace" https://github.com/1c3t3a/rust-socketio/runs/3465528073?check_suite_focus=true https://github.com/1c3t3a/rust-socketio/runs/3465739096?check_suite_focus=true


ROS2 Humble gazebo package installation

Hi, I have a LITE 6 arm that I am looking to program. First I would like to simulate the arm before interacting with the hardware.
I have an Mac M1, running Parallels 19 that has an Ubuntu 22.04.2 ARM64 virtual machine. I am trying to follow the installation instructions here for installing ROS2 Humble.
Installing gazebo
The readme points to here for installing gazebo with the command curl -sSL http://get.gazebosim.org | sh. This results in the following error:
E: Package 'libgazebo-dev' has no installation candidate
E: Package 'gazebo' has no installation candidate

Installing gazebo_ros_pkgs
The readme makes reference to gazebo_ros_pkgs page which contains installation instructions for installing the packages for Foxy rather than Humble.
I considered attempting the Foxy installation but when running sudo apt install ros-foxy-gazebo-ros-pkgs I am provided with:
E: Unable to locate package ros-foxy-gazebo-ros-pkgs

Fortress installation
If I follow the instructions on the Gazebo website I am able to install the fortress version of gazebo and am able to run shapes.sdf.
The issue with this though is when I attempt to install the xArm dependencies (as per here) I receive the following error:
executing command [sudo -H apt-get install -y ros-humble-gazebo-plugins]
Reading package lists... Done
Building dependency tree... Done
Reading state information... Done
E: Unable to locate package ros-humble-gazebo-plugins
ERROR: the following rosdeps failed to install
  apt: command [sudo -H apt-get install -y ros-humble-gazebo-plugins] failed

Would someone be able to provide some guidance on which packages I should be installing? Would there be any expected issues running with my M1 Parallels setup?
Thank you.

Sorry we do not have the experience of M1 Mac platform installation, and we are not sure about the compatibility of the packages needed. Will leave this issue open for other users' help.

I am having the same issue. Is it possible to use the repo without having the gazebo? I will not use the simulation; I will use the robot and Rviz. I think it should be possible to build without the Gazebo


changed > into >= as per bug2808 on bugzilla.fieldtriptoolbox.org

as approved by Alex

thx @schoffelen !


LSTM policies are broken for PPO1 and TRPO

See the feature/fix_lstm branch for a test which fails for the above mentioned algorithms.
For PPO1 and TRPO the cause seems to be that the batch size is not provided to the policy (None is passed). Then the ortho-initializer has issues.
For PPO2 the assert in line 109 fails:
assert self.n_envs % self.nminibatches == 0, "For recurrent policies, "\
                        "the number of environments run in parallel should be a multiple of nminibatches."

Since the PPO2 instance is created using PPO2(policy, 'CartPole-v1'), the default parameters of PPO2 seem to be broken somehow?
For ACKTR the issue is somewhere in get_factors of kfac.py and I have no clue what that does and what goes wrong there but it complains about some shared nodes among different computation ops.

Related to #60 #70

Any hints for what exactly the masks are used for? This would help a lot!

I did not look closely at the code, but I remember seeing masks and dones interchangeably in the code (see here fir ppo2).
Then it used in the policies and especially by  lstm to reset states for new episodes.

ACKTR is fixed on the enhancements branch, however I lost quite some time this month, and didn't have time to finish the branch (wanted to fix PPO1 and TRPO first). might try again over the next few weeks

I am also interested in the combination of PPO1 + CnnLstmPolicy :)

Any updates on this ? TRPO still doesn't support MlpLstmPolicy :'(

@HareshMiriyala for now, we don't have time to fix that (even though it is on the roadmap). Currently, we are working on fixing GAIL + A2C, this will be merged with master soon.
However, we appreciate contributions, especially to fix that kind of thing ;)

I also mentioned this problem last year in issue #60. It seem the problem is not fixed up to now, is there any plan ?
I would like to fix the problem in this month, is there any comment or advice? @araffin @hill-a @erniejunior

It seem the problem is not fixed up to now, is there any plan ?

Hello,
There is not plan for now, we are now focusing on the migration to tf2 (cf #366 ).

I would like to fix the problem in this month, is there any comment or advice?

We would appreciate a PR, however, I think only @erniejunior is a bit familiar with the LSTM policy (I don't know much of that part of the code, which comes from OpenAI code and which is one of the most  complex and undocumented part of the lib).


May be wrong code

https://github.com/muditbhargava66/PyxLSTM/blob/a34c2526aa2646203e6d512ed3186765bbd20b3b/xLSTM/mlstm.py#L89
This code will make a wrong in:
https://github.com/muditbhargava66/PyxLSTM/blob/a34c2526aa2646203e6d512ed3186765bbd20b3b/xLSTM/mlstm.py#L68
RuntimeError: The size of tensor a (2534) must match the size of tensor b (256) at non-singleton dimension 1
Can you please check it?

I also encountered this issue, which occurs when running the test_mlstm.py module.

I also encountered this bug

The issue has been definitively resolved in the latest update, Version 2.0.0.


Events are not attached

I am using riot.js to build my UIs. One of my UIs is a table that shows around 2000 elements so clusterize seems to be the perfect solution. The problem is that my events on my table rows are not triggered anymore. Without using clusterize the events are working fine. Any help would be greatly appreciated.

Hi
Events should not be attached to every row.
They should be attached using event delegation. Check question 3 from FAQ

I appreciate your fast response. Sorry I must have missed that. Initially I thought one of the reasons my app is very slow is because I have attached an event handler to each of my row elements. After applying your solution, I did not see much of improvement. The thing is that each of my rows wraps a lot of DOM elements and I render all of the rows at the same time (I'm getting the data through AJAX and update an array which I then loop through). I was thinking of using setTimeout to slowly get the data from the server. Does the uodate function helps with this performance issue?

Some code sample at codepen would be helpful.
I don't really get what exactly kind of performance issues do you have.
If you get a lot of rows (say tens of thousands) from server and render them in one loop - page may be unresponsive while generating rows in loop. For this case obvious solution will be separate received array of data from server and generate those separated chunks successively inside setTimeout(fn, 0) calls. After each chunk done you could call something like clusterize.append(new_chunk) to append new rows to the list.

Closing due inactivity


CPR-145 remove JPA from auto setup for tests

The jpa config does not appear to have any effect. Flyway is always used (I have checked this on main)

This seems to expose the problem with a DB structure which does not match what is defined in code. See https://app.circleci.com/pipelines/github/ministryofjustice/hmpps-person-record/842/workflows/1a473957-9ed4-45eb-8463-2b3c209faab9/jobs/2488


[move-only] Fix a small thinko.

Specifically, I forgot that when asserts are disabled I made FieldSensitivePrunedLivenessBoundary::getNumLastUsersAndDeadDefs() assert to make sure that callers were sure to place it within a #ifndef block since it is rather expensive and not actual used in the computation. Funnily, I forgot to end.
rdar://104107922

@swift-ci smoke test

preset=buildbot,tools=R,stdlib=RD
@swift-ci Please test

preset=buildbot,tools=R,stdlib=RD
@swift-ci Please test

@swift-ci smoke test


Support overlapping domains for ipv4 and ipv6

This probably involves adding an ipv4/6 type field to Hostname

[x] Completed refactor to support IPv4 and IPv6
[x] Support default behavior which is IPv* agnostic.
[x] Support -4 and -6 flags in CLI
[ ] Make -4 and -6 flags actually do something

These are supported but I don't think the rest of the app is actually using it in most places.

This is complete but support needs to be extended to the UI.

I decided to just remove this from the CLI because I have never needed it, I don't think it ever worked, and no one has ever complained. The library still supports it, though.


delete user role when delete user SQL failed

Hi,
I am using Laravel 5.2 and I have come to a serious issue.
If I try to delete a user and the SQL fails (for example because of foreign key constraints), the roles will still be deleted.
How to make sure that it waits for the SQL to be successful on delete before actually deleting the roles for this user?

I had solve this issue by overwriting the cachedRoles and cachedPermissions in User and Role Model.
In Role Model :
public function cachedPermissions()
    {
        $rolePrimaryKey = $this->primaryKey;
        $cacheKey = 'entrust_permissions_for_role_'.$this->$rolePrimaryKey;

        Cache::store('array')->tags(Config::get('entrust.permission_role_table'))->remember($cacheKey, Config::get('cache.ttl'),function(){
            return $this->perms()->get();
        });

    }

In User Model  :
public function cachedRoles()
    {
        $userPrimaryKey = $this->primaryKey;
        $cacheKey = 'entrust_roles_for_user_'.$this->$userPrimaryKey;

        Cache::store('array')->tags(Config::get('entrust.role_user_table'))->remember($cacheKey, Config::get('cache.ttl'),function(){
            return $this->roles()->get();
        });
    }


Changeable radius while running instance

Hello,
I wanted to change the search radius for roads in special cases. e.g. tunnels/bridges or beacons.
But when I have multiple threads which are using the https://github.com/bmwcarit/barefoot/blob/master/src/main/java/com/bmwcarit/barefoot/matcher/Matcher.java class, then setting the radius will have also effects on other threads which are using the same map/matcher.
Therefore I suggest to add an optional additonal parameter for the Method   execute
https://github.com/bmwcarit/barefoot/blob/c7b55daab5fe14c3e0b02f9e76e22ca509633ac4/src/main/java/com/bmwcarit/barefoot/markov/Filter.java#L114
 which uses this parameter for finding candidates
(https://github.com/bmwcarit/barefoot/blob/c7b55daab5fe14c3e0b02f9e76e22ca509633ac4/src/main/java/com/bmwcarit/barefoot/markov/Filter.java#L127)

Sorry for the delay. Is this still an open issue? The radius could be adapted based on the samples. I see that the abstract Filter class may be a design flaw for this use case but you could still derive the Matcher class to adapt the radius based on properties of the sample. If you need more details on how to accomplish please let me know.


add a tsan test with an heap-use-after-free error

The test got skipped :-)

Ok, the test is skipped because we disabled compiler-rt explicitly, it means our granularity is not good enough. I'm still accepting the patch now.


Node 8.10 not supported with ZipFile in CloudFormation

CloudFormation does not currently support the ZipFile (embedded code) method with Node8.10. Only Node, Node4 and Node6.10.

It does support, make sure you are not exceeding the allowed 4096 characters. Maybe you can replace the number of whitespaces used for indentation to save some characters for your changes.

Code has been updated to nodejs12.x. I found no issues deploying this today via the Cloudformation template. Suggest closing this issue.


should fix npm start and npm run dev

probably wont pass due to npm run lint

@amilajack I added some comments, as you can see I do not have 3 years of react-router4 experience I was just playing around. Nevertheless I hope it helps.

Now the linter complains about React element App:  property children.
https://travis-ci.org/chentsulin/electron-react-boilerplate/jobs/219967223#L3139
I honestly have no idea about flow or is it flow-typed? Could not find any documentation about it :/

Not sure why it still fails linting (see https://travis-ci.org/chentsulin/electron-react-boilerplate/jobs/220217180#L2965). Locally npm run lint does pass for me. I just did a npm install to make sure that I have got the latest deps. BTW: quite a few deps are not up to date npm outdated

https://github.com/chentsulin/electron-react-boilerplate/blob/react-router-4/.travis.yml#L52-L56 runs fine for me locally


Documentation does not build

Describe the bug
Documentation does not build.
To Reproduce
N/A
Expected behavior
It should build.
Additional context
N/A

Having a built PDF would be nice to attach to the manuscript. Reopening.

The root cause was missing .. footbibliography:: lines at the bottom of .rst files that had :footcite: in them.


Issue with VVV2 and Provisioning

Seems there is an issue with using VVV Provision Flipper and the develop branch of VVV - if I use flip and set the provision script to quick
Provisioning seems to take longer than normal, output is below, the site is created but an error is output.
==> default: nginx: [emerg] directive "root" is not terminated by ";" in /etc/nginx/custom-sites/vvv-auto-testwithrepo-provision-bf772b3b1b6331f0c76bfd391db43f06.conf:12
==> default: nginx: configuration file /etc/nginx/nginx.conf test failed
The SSH command responded with a non-zero exit status. Vagrant
assumes that this means the command failed. The output for this command
should be in the log above. Please read the output to determine what
went wrong.
[Success] New VVV Site Setup: Done!

If you reset the provision script back or use the master branch of VVV then no error occurs.

This is broken for the same reasons the vv tool was broken in VVV 2, the correct way to add hosts and new sites in VVV 2 is via the vvv-custom.yml config file


Add 1mbible.co

Hey!
I thought it would be a cool challenge to cram the whole Bible into a 1mb (Scriptures included) SPA app for people to read it.
The challenge was a tough one!

I had to use the bzip2 format to get the bible (King James Version, which is free of use) data file from ~4.3 to ~1.2mb
And prior to compressing, I had to replace some oft-used words (such as "thou", "shall", "LORD", etc) with short marker strings (a poor-man's compression technique), for reducing the size a good bit further, in order to be able to add some Web code for people to read the thing.
The code (mainly javascript) is using a small library that decompresses the .bz2 in memory for accessing the text via JavaScript. The js code and the css is also minified in order to fit the max size.

You can see the github repo here for more info about the project: https://github.com/juliend2/1mbible
Please let me know what you think!
Happy holidays :)
Julien

Great project! If you could just include the first decimal place in the size parameter: 1000.0

@bradleytaunt thanks for your feedback! I did that. :)
Best.


unable to install with composer

I tried to install the bundle with composer, but the error is: Could not parse version constraint ^2.1.3: Invalid version string "^2.1.3"
composer.json:
    "craue/formflow-bundle": "~3.0@dev"

Try to update Composer and try it again.

@pixeloid: Can this be closed?


Updating the modbus URL to MCR URL

Modbus container is no longer in preview + is now onboarded to MCR. Updating the URLs to reflect this change

@ebertrams : Thanks for your contribution! The author, @kgremban, has been notified to review your proposed change.

#sign-off


[Modal] { inverted: true } works only on the first run.

$('.ui.modal').modal({  inverted: true }).modal('show');
Shows the modal with white background. After you close it and then open it again the background is now black.
Run Code twice at "Dimmer Variations" section to see the bug:
http://semantic-ui.com/modules/modal.html#/examples

This is a bug related to doc initialization (the modals are re-used in all the examples), but I don't believe a bug with SUI?

I did some changes and now it works.
Was need instantiate the modal only once.
Here is the test case:
http://plnkr.co/edit/RnUqli4JnYIuxs9v88YC

I got the same unexpected behavior. Here is a common use case with an modal which lost it's inverted state after fired once: http://jsfiddle.net/8x15wobw/
The same result with dimmerSettings:
dimmerSettings: {
	variation: 'inverted'
}

same problem here, even in the Examples pages the bug occurs:

http://semantic-ui.com/modules/modal.html#dimmer-variations

on the first call to inverted modal, the dimmer is clear, if you make a second call, the dimmer goes dark.

@larsbo , you should not instantiate your modal on every click.
http://jsfiddle.net/8x15wobw/1/


fix: increase regen gas price

It seems that 0.002uregen gas price is too low for the restake transactions:
Failed to broadcast: Broadcasting transaction failed with code 13 (codespace: sdk). Log: insufficient fees; got: 610uregen required: 7624uregen: insufficient fee
Failed to broadcast: Broadcasting transaction failed with code 13 (codespace: sdk). Log: insufficient fees; got: 610uregen required: 7624uregen: insufficient fee
Failed to broadcast: Broadcasting transaction failed with code 13 (codespace: sdk). Log: insufficient fees; got: 611uregen required: 4579uregen: insufficient fee
Failed to broadcast: Broadcasting transaction failed with code 13 (codespace: sdk). Log: insufficient fees; got: 610uregen required: 7625uregen: insufficient fee
Failed to broadcast: Broadcasting transaction failed with code 13 (codespace: sdk). Log: insufficient fees; got: 611uregen required: 4579uregen: insufficient fee

Setting the gas price to 0.02uregen is enough for some transactions, but others continue failing.
With 0.03uregen all the restake transactions are performed successfully.

Awesome thanks! I'll merge now so it's in master


uv lock doesn't accept --env-file as a flag

I'm wanting to install a github private repo as part of a uv sync however, in the uv lock stage there is an error because  > [lock 5/5] RUN --mount=type=secret,id=_env     bash -c 'uv lock --env-file /run/secrets/_env': #0 0.070 error: unexpected argument '--env-file' found
docker build --secret=id=_env,src=.build_secrets.env -f DOCKERFILE -t project_name .

...
FROM base AS lock

# Set working directory
WORKDIR /app

# Copy required files
COPY pyproject.toml .
COPY .pre-commit-config.yaml .
COPY .build_secrets.env .

# Use BuildKit secrets and pass the env file directly to uv lock
RUN --mount=type=secret,id=_env \
    bash -c 'uv lock --env-file /run/secrets/_env'
...

<before>
dependencies = [
    <other_dependencies>,
    "desired_repo",
]

[tool.uv.sources]
desired_repo = { git =<EMAIL_ADDRESS>
How can I make this work?

Only uv run accepts an env file. The env file only applies to the command that's executed by uv run, and not to uv itself.

If you want general .env support, you should follow https://github.com/astral-sh/uv/issues/8862.


Long polling fails to clean up and goes on forever

From @yaronyg on June 3, 2016 15:29
Please see https://github.com/pouchdb/pouchdb/issues/5271 for the test code I'm using and check out my final comment there. What I can see happening is that once we set up a long polling connection it keeps polling, forever. Even though the socket associated with the req is destroyed!
Copied from original issue: pouchdb/express-pouchdb#326

From @yaronyg on June 3, 2016 15:30
Note that this matters because:

It's a memory leak on every single replication and in something like Thali we will do a lot of them
I keeps node from exiting which make running our test framework impossible and is just bad form :)

From @yaronyg on June 3, 2016 16:19
In the case I'm looking at the scenario is that both the client AND the server have closed their sockets. So the socket is fully destroyed. However the changes code doesn't realize this and continues writing to its now dead res object endlessly.

From @colinskow on June 3, 2016 16:9
It doesn't appear that CouchDB (and thus PouchDB-Express) actually has an API to instantly cancel continuous replication short of letting the long-poll feed time out.
You could try sending your server a SIGINT event in order to make the tests pass. The connections will eventually automatically drop depending on the timeout and KEEPALIVE settings.

From @colinskow on June 3, 2016 17:6
Adding a req.on('close') handler to PouchDB-Express could be a possible solution.

From @colinskow on June 3, 2016 17:9
In here would probably be a good place to try.

Yeah this doesn't surprise me; I think I wrote that code and didn't test it heavily

From @yaronyg on June 3, 2016 17:46
So per an old stack overflow article I found it claimed that one should listen to the close event on req.connection but I tested that out and it never triggered, even when the socket was destroyed. So just for fun I tried, well, everything:
req.on = listened for abort and socket
req.connection.on = listened for close, end
res.on = listened for close and finish
res.connection.on = listened for close and finish
Nothing fired. Literally nothing.
So I have a trick that seems to work (although really slowly) that I'll submit as a PR for lack of a better idea.
I record the changes object for both of the continuous changes (e.g. for continuous or the inner changes in long poll).
Then I extended cleanup to call cancel on the changes object as well as to call res.end().
Then I put a check into heartbeatInterval to see if res.connection.destroyed is true and if so I call cleanup.
Not pretty but it seems to work.

From @yaronyg on June 3, 2016 18:21
@nolanlawson you and @marten-de-vries both get 'blame' :) It's a minor bug. I'll go fix it now. Mostly I have to figure out what kind of testing I'm supposed to do. Do I just run the normal PouchDB main repo tests but against my forked version of Express-PouchDB?

From @yaronyg on June 3, 2016 19:19
Would it be fair to say that nobody has run the tests in this project in a really long time? Because I'm pretty sure it's loading pouchdb incorrectly.

From @yaronyg on June 3, 2016 18:46
Ahh yes, 'npm run test' Well duh. :)

This appears to have a test case in https://github.com/pouchdb/pouchdb/issues/5271 but needs serious investigation, marking as "hard"

the problem has not been solved.
in chrome , the long polling will timeout when exceed 2 mins, and the browser will report the problem ERR_INCOMPLETE_CHUNKED_ENCODING, after that, i can not receive any update, because there is no long polling set up again

@nolanlawson did you find a solution or workaround for this issue? I'm seeing a leak that amounts to 2GB node res mem in 48 hours (shows up in the heap as an accumulation of zlib and related objects), I'm surprised more people aren't bothered by this issue, given the 5k per week downloads of this package


[RFC] Node schema for pipelines 2.0

Our current solution for handling palette and node properties needs to be overhauled in order to support pipeline 2.0 features.
Current solution

a hard-coded palette.json on the frontend with a fixed list of available nodes and their associated metadata
a hard-coded properties.json on the fronted with a single instance of CommonProperties properties that is assumed to be use for all nodes in the palette
validation of nodes is also hard-coded and doesn't use properties.json so if properties.json changes, the validation needs to be updated as well

Requirements

we should not assume a fixed set of nodes
we should have the ability to lock node types to a specific runtime
each node type should be able to have its own properties definition
runtimes should be able to add properties to nodes
we need to keep the ability of affiliating a filetype with a node type (this enables dragging and dropping files onto the pipeline)
we should support dynamic node labels where the node type can decide whether to show the file name a fixed label or something else as the label
we should support dynamic properties (properties can vary based on the node itself, not just the node type)

we might want a way to generate a component based on a url?
Proposal
Instead of the concept of a single "palette" and single "properties", introduce the idea of a "node schema" per node type. This collection of "node schema" will be used to generate a "palette" at runtime. A runtime should also be able to provide "properties" that are applied across all nodes or override specific operation properties (RFC #1520). Properties will initially only be validated for type, requiredness, regex, min/max and other various json schema specs. All other property validation should be done at submission time.
A "node schema" should contain all static metadata needed for a node:

op (the ID for a node type, ie execute-notebook-node / execute-python-node)
icon (svg that will show up on the node)

we probably need the option to provide light, dark and high contrast versions of the icons

label (the default label, since this can be dynamic)
description (the description that could show up in the palette or when hovering on the node in the pipeline)
properties (RFC #1519, the fixed properties for the node. dynamic and runtime specific properties don't go here)

A "node schema" should also be able to specify that it is attached to a file:

fileNode (should always be true)
extensions (example: [".yml", ".yaml"] valid extensions for the node. if more than one node spec requests a given extension we should add a dropdown property to manually choose the node's type or prompt the user to choose onDrop)
language (example: "python" language identifier, not required but useful if available. VS Code has an api to detect the language based on grammar instead of just extension. This will also improve language icon support)
(this will attach a property for filename)
(this will be the only field that can be validated for a file's existence at runtime)

A "node schema" should have a fixed "label" property so that the user can manually adjust the label. The winning label would follow the logic of: node.properties.label ?? node.properties.filename ?? node.label
Properties (RFC #1519)
The finalized properties of a node will be generated from:

filename (if fileNode is true)
label
static properties defined in "node schema"
dynamic node specific properties
runtime injected properties (RFC #1520)

Examples
POC for being able to drag and drop any arbitrary KFP yaml component onto a pipeline.
Node schema:
{
  op: "execute-kfp-component",
  fileBased: true,
  extensions: [".yaml", ".yml"],
  icon: "xxx",
  label: "KFP Component",
  description: "A KubeFlow Pipelines YAML component",
  properties: []
}

KFP Component yaml: (I am assuming inputs are what would be turned into properties?, not sure how outputs would be handled)
name: 'Deploy Model - Watson Machine Learning'
description: |
  Deploy stored model on Watson Machine Learning as a web service.
metadata:
  annotations: {platform: 'IBM Watson Machine Learning'}
inputs:
  - {name: model_uid,        description: 'Required. UID for the stored model on Watson Machine Learning'}
  - {name: model_name,       description: 'Required. Model Name on Watson Machine Learning'}
  - {name: scoring_payload,  description: 'Sample Payload file name in the object storage', default: ''}
  - {name: deployment_name,  description: 'Deployment Name on Watson Machine Learning', default: ''}
outputs:
  - {name: scoring_endpoint, description: 'Link to the deployed model web service'}
  - {name: model_uid,        description: 'UID for the stored model on Watson Machine Learning'}
implementation:
  container:
    image: docker.io/aipipeline/wml-deploy:latest
    command: ['python']
    args: [
      -u, /app/wml-deploy.py,
      --model-uid, {inputValue: model_uid},
      --model-name, {inputValue: model_name},
      --scoring-payload, {inputValue: scoring_payload},
      --deployment-name, {inputValue: deployment_name},
      --output-scoring-endpoint-path, {outputPath: scoring_endpoint},
      --output-model-uid-path, {outputPath: model_uid}
    ]

finalized properties based on above:
# injected filename
filename:
  type: string
  description: The path to the file.
  required: true

# injected label
label:
  type: string
  description: The label for the node.

# no static properties

# dynamic properties
model_uid:
  type: string
  description: Required. UID for the stored model on Watson Machine Learning
model_name:
  type: string
  description: Required. Model Name on Watson Machine Learning
scoring_payload:
  type: string
  description: Sample Payload file name in the object storage
  default: ""
deployment_name:
  type: string
  description: Deployment Name on Watson Machine Learning
  default: ""

# no runtime injected properties

Being more a visual person I crayola'ed this in ppt, hopefully, its accurate.

Question:
Will the schema be used for other types of operations..e.g. fileNode=False …like an ethereal operation where a file might be too heavy….say a sleep operation op_type=sleep-node (weak example) or no-code type operations?

KFP Component yaml: (I am assuming inputs are what would be turned into properties? not sure how outputs would be handled)

The outputs, cant they be handled in the same way as the inputs and exposed as dynamic properties? I think these just end up being passed to the arg cmd driver per component?

Being more a visual person I crayola'ed this in ppt, hopefully, its accurate.

Yea, that looks about right 😊 I think the only thing is that filename is not part of Node Schema it's more of an ?implied? property that only shows up if it is a file node (it will never be explicitly defined anywhere)

Question:
Will the schema be used for other types of operations..e.g. fileNode=False …like an ethereal operation where a file might be too heavy….say a sleep operation op_type=sleep-node (weak example) or no-code type operations?

yes, all operations will be treated like this by default, "file nodes" are a special case. Also, I think I removed fileNode: true and changed it to type: "file" to future proof any other node types that might pop up in the future (I'll update it here too)

KFP Component yaml: (I am assuming inputs are what would be turned into properties? not sure how outputs would be handled)

The outputs, cant they be handled in the same way as the inputs and exposed as dynamic properties? I think these just end up being passed to the arg cmd driver per component?

Oh okay, makes sense, so outputs are just another set of properties? Do all kfp component yamls have a set of inputs and outputs or is this just what they happened to be named?


Simplify import path

The import path is rather long and very non golang like. Is there any simplification that can be done to the repo name for the next version, or at the very least move the packages out of apps as that is not a good import path?
Thanks!

You are correct, the import path is not Go like.  Non-lowercase words, hyphenated, etc....
However it is consistent with the naming convention that AzureAD is using fo its other msal packages:
microsoft-authentication-library-for-dotnet
microsoft-authentication-library-for-js
microsoft-authentication-library-for-android
...
Normally, "app" like "common" is a bad, but like panics() not every use is bad.  Documentation and others label these as "apss" in the MSAL.
While I would personally prefer: "azure/ad/go/msal", that is unlikely to be an option due to a need to be consistent for discovery and a bunch of other things.  A lot of these structures and conventions were put in years ago and are named in a .Net/Java like naming structure which lacks the brevity that we Go programmers like.
Sorry about this.  We will keep this in mind as we move towards v1, but this is unlikely to happen.


Do not ignore CHANGELOG for spell check

CHANGELOG.md is an evolving file which can be used for verification of spelling prior to release.

/skip-all


Users requiring Power BI Admin

Lab/Demo: 7
Task: 2
Step: 00
Description of issue
The delegates need to be added to a single tenant with Power BI Admin rights to perform the task 2.  If they are all admin only one can change the setting to enabled.  All the others will see it as Enabled.

As the aim is to be focussed on the Business User they will not do this.   Yes if the delegates are on their own tenant it could work.
Personally I think this is such a risk to the course collapsing as a delegate could remove all other users including the instructor.
Fitz

We will look into this issue. Thanks.


Implement lifecycle nodes

Some ROS 2 applications in other languages require the use of lifecycle nodes. We should work on creating/fleshing out the ros2_rust version of these, so that we can support more types of solutions.
I am unsure of how difficult this will be to port over, or if it's a good first issue for the community...

Hi @jhdcs
Are you currently working on this feature? In that case, may I help you?

Yes I am! Though progress is admittedly slow.
I would welcome any and all help that you would like to provide! I'm currently trying to create a unit test to make sure what I've written so far is working correctly, and ironing out any bugs discovered. So far, I'm not happy with the ergonomics of the builder, though I'm drawing a blank on improving it. I've also noticed that if you try to do an invalid transition between states, a segfault occurs - that will need to be fixed as well.
All work is currently being done on my personal fork: https://github.com/jhdcs/ros2_rust/tree/lifecycle_nodes. If you see any ways to improve/tweak what's there, or any glaring faults, please feel free to either let me know or submit a PR!


You cannot use the same root element (#ember-testing) multiple times in an Ember.Application

I get the following errors in a lot of Integration and acceptance tests:
Error: Assertion Failed: You cannot use the same root element (#ember-testing) multiple times in an Ember.Application
and
Promise rejected before it renders: Assertion Failed: You cannot use the same root element (#ember-testing) multiple times in an Ember.Application
My tests now is what the ember g generated, I do not changed anything on it.

I think here is the solution: https://github.com/emberjs/ember.js/issues/11738

No. I upgraded my all project to Ember 2 and everything is the latest version (I hope...) but I got the same error.

@sajt that usually means an earlier test didn't clean up properly (usually due to an error being thrown).

Now it is working, but I do not know why :)