feat: add enabled filter

Description

Using
Enabled

Linked Issues
close #16
Additional context

This is a bit tricky, I think. The reason it was showing both enable/disable are because they could have different scopes, like you enable a rule in all files, but disabled it in only some files. Which is, technically still enabled for the other files.

Yes, I just realized this problem. I'll mark it as draft first to see if there's a good way to deal with it.

Now, enabled filter include overridden rules


add benchmark of rpc

modify #54
compare rpc performance with grpc in different RPC counts.
found result
create client and RPC 50000

create client and RPC in 10、100、1000、10000

Is it necessary to create benches directory?


uWS/uWS.h

The software that I'm trying to use is looking for <uWS/uWS.h> from this library, which I can't seem to find anywhere. Is it something's been deprecated? Does it still exist in a specific release?

That's v0.14 and yes it's deprecated


Add message to display head tracking not supported for older devices

Acceptance Criteria
For users trying to use the app in older devices, we will add message to display that head tracking is not supported for older devices

Current designs disable the "head tracking" switch in settings on unsupported devices.
Will need designs around when to show this message (when attempting to enable head tracking on an unsupported device, once @ first app launch, within onboarding, etc.)

Footer text has been added in the Selection Mode screen noting why the head tracking button is disabled and why the iPad is not supported in version 1.4.0.  If we want to enhance this feature then we can create a separate ticket.


update stale bot

What does this PR do?
Try to set separate roles for issues and PRs, the docs is quite weak...
An alternative is to use GH action - https://github.com/actions/stale
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃

@tchaton thx, pls use gh suggestions options so it easier to accept =)


Remove duplicated "Microsoft's" string

I missed this other duplicate, good catch. #198 now does this and the other duplicate, and also updates the version.

Fixed by #198, closing...


[Feature Request]: Provide chatbot assistant to communicate or interact with this app.

Is there an existing issue for this?

[X] I have searched the existing issues

Feature Description
It will be nice if there will be chatbot assistant to communicate or interact with this app.
Use Case
As for the people who can't able to know how the app is going to work the may ask the chat bot assistant and can do there work in it.
Benefits
No response
Priority
High
Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC contributor
[X] I want to work on this issue
[ ] I'm willing to provide further clarification or assistance if needed.

can you assign me this issue.i have worked on this before  and im a beginner.

@mansiruhil13 kindly assign it to me.


Cannot import pytorch-lightning-v0.5.3

Describe the bug
After updating to v0.5.3, import pytorch_lightning fails due to the following error:
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/local/lib/python3.7/site-packages/pytorch_lightning/__init__.py", line 28, in <module>
    from .trainer.trainer import Trainer
  File "/usr/local/lib/python3.7/site-packages/pytorch_lightning/trainer/trainer.py", line 16, in <module>
    from pytorch_lightning.trainer.callback_config_mixin import TrainerCallbackConfigMixin
  File "/usr/local/lib/python3.7/site-packages/pytorch_lightning/trainer/callback_config_mixin.py", line 4, in <module>
    from pytorch_lightning.logging import TestTubeLogger
ImportError: cannot import name 'TestTubeLogger' from 'pytorch_lightning.logging' (/usr/local/lib/python3.7/site-packages/pytorch_lightning/logging/__init__.py)

To Reproduce
Steps to reproduce the behavior:
$ docker run --rm -it python:3.7 /bin/bash

//
// Install `pytorch_lightning` (succeeded)
//
root@93bfd08b5db7:/# pip install pytorch_lightning
Collecting pytorch_lightning
  Downloading https://files.pythonhosted.org/packages/2d/2e/ef5bedf1bb7f2f786d42f5af71ad5d7383416efec86098372d8016f5305d/pytorch-lightning-0.5.3.tar.gz (55kB)
...
Building wheels for collected packages: pytorch-lightning
  Building wheel for pytorch-lightning (setup.py) ... done
  Created wheel for pytorch-lightning: filename=pytorch_lightning-0.5.3-cp37-none-any.whl size=67557 sha256=80287a76e8fa15b4a64568fcd0c033688479f1bf7cb69dde8ba1d77da25453a6
  Stored in directory: /root/.cache/pip/wheels/0f/4e/df/486c6c64d8d2f4706c70255493e434bacbf3497c7f5d0ab040
Successfully built pytorch-lightning
Installing collected packages: numpy, scipy, scikit-learn, tqdm, chardet, certifi, urllib3, idna, requests, docutils, webencodings, six, bleach, Pygments, readme-renderer, pkginfo, requests-toolbelt, twine, torch, pillow, torchvision, pytz, python-dateutil, pandas, pytorch-lightning
Successfully installed Pygments-2.4.2 bleach-3.1.0 certifi-2019.9.11 chardet-3.0.4 docutils-0.15.2 idna-2.8 numpy-1.16.4 pandas-0.25.3 pillow-6.2.1 pkginfo-<IP_ADDRESS> python-dateutil-2.8.1 pytorch-lightning-0.5.3 pytz-2019.3 readme-renderer-24.0 requests-2.22.0 requests-toolbelt-0.9.1 scikit-learn-0.20.2 scipy-1.3.1 six-1.13.0 torch-1.3.0 torchvision-0.4.1 tqdm-4.35.0 twine-1.13.0 urllib3-1.25.6 webencodings-0.5.1

//
// Import `pytorch_lightning` (failed)
//
root@93bfd08b5db7:/# python
Python 3.7.5 (default, Oct 19 2019, 00:03:48)
[GCC 8.3.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import pytorch_lightning
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/local/lib/python3.7/site-packages/pytorch_lightning/__init__.py", line 28, in <module>
    from .trainer.trainer import Trainer
  File "/usr/local/lib/python3.7/site-packages/pytorch_lightning/trainer/trainer.py", line 16, in <module>
    from pytorch_lightning.trainer.callback_config_mixin import TrainerCallbackConfigMixin
  File "/usr/local/lib/python3.7/site-packages/pytorch_lightning/trainer/callback_config_mixin.py", line 4, in <module>
    from pytorch_lightning.logging import TestTubeLogger
ImportError: cannot import name 'TestTubeLogger' from 'pytorch_lightning.logging' (/usr/local/lib/python3.7/site-packages/pytorch_lightning/logging/__init__.py)

@sile you need to install test-tube from pypi

@Borda My problem was solved by installing test-tube. Thank you!
BTW, I think that it's better to add test-tube to requirements.txt if the package is mandatory to import pytorch_lightning.

I am not sure about it, we had similar discussion some time ago and we decided that we don't want to forse users of mlflow (or other alternatives) to use test-tube so lightning can be installed without any of these dependencies and we leave the decision about preferable logger to the user... That's also why there is integration of the three main logging tools :)

@sile but I agree that the package should not crash just after importing pytorch_lightning...
I will have look at it, pls reopen this issue 8-)

Reopened.

we leave the decision about preferable logger to the user

Sounds good. Thank you for your explanation.

trying to reproduce in https://github.com/Borda/pytorch-lightning/tree/issue_469

we need to submit a fix for test-tube

Fixed on master. we can drop the reqs for next release

Great! Thank you!

@williamFalcon so now e41bf0a047085037cb7e37d4c3cb95aab0e218f6 you force users to use test-tube?
I thought that we let them chose https://github.com/williamFalcon/pytorch-lightning/issues/469#issuecomment-550593621

users should have a choice. i’d like to not force it. but crash on install is not good UX. UX takes priority.

I know that is why I prepared a fix, but I agree that it can go in the next release...

@Borda on second thought, i don't think we can get rid of test-tube logger as a dependency because we need a default logger when people use the trainer.
A happy medium would be to implement a tensorboard logger using PyTorch SummaryWriter which would be the default logger.

I had the same error, too
cannot import name 'TestTubeLogger'
I tried
pip install test-tube
and it says
Requirement already satisfied: test-tube in /home/rpc/anaconda3/envs/hkt/lib/python3.6/site-packages (0.7.3) Requirement already satisfied: future in /home/rpc/anaconda3/envs/hkt/lib/python3.6/site-packages (from test-tube) (0.18.2) Requirement already satisfied: imageio>=2.3.0 in /home/rpc/anaconda3/envs/hkt/lib/python3.6/site-packages (from test-tube) (2.5.0) Requirement already satisfied: pandas>=0.20.3 in /home/rpc/anaconda3/envs/hkt/lib/python3.6/site-packages (from test-tube) (0.24.2) Requirement already satisfied: torch>=1.1.0 in /home/rpc/anaconda3/envs/hkt/lib/python3.6/site-packages (from test-tube) (1.3.1) Requirement already satisfied: numpy>=1.13.3 in /home/rpc/.local/lib/python3.6/site-packages (from test-tube) (1.16.4) Requirement already satisfied: tb-nightly==1.15.0a20190708 in /home/rpc/anaconda3/envs/hkt/lib/python3.6/site-packages (from test-tube) (1.15.0a20190708) Requirement already satisfied: pytz>=2011k in /home/rpc/anaconda3/envs/hkt/lib/python3.6/site-packages (from pandas>=0.20.3->test-tube) (2018.9) Requirement already satisfied: python-dateutil>=2.5.0 in /home/rpc/anaconda3/envs/hkt/lib/python3.6/site-packages (from pandas>=0.20.3->test-tube) (2.8.0) Requirement already satisfied: six>=1.10.0 in /home/rpc/.local/lib/python3.6/site-packages (from tb-nightly==1.15.0a20190708->test-tube) (1.12.0) Requirement already satisfied: protobuf>=3.6.0 in /home/rpc/anaconda3/envs/hkt/lib/python3.6/site-packages (from tb-nightly==1.15.0a20190708->test-tube) (3.8.0) Requirement already satisfied: markdown>=2.6.8 in /home/rpc/anaconda3/envs/hkt/lib/python3.6/site-packages (from tb-nightly==1.15.0a20190708->test-tube) (3.1.1) Requirement already satisfied: setuptools>=41.0.0 in /home/rpc/anaconda3/envs/hkt/lib/python3.6/site-packages (from tb-nightly==1.15.0a20190708->test-tube) (41.0.1) Requirement already satisfied: absl-py>=0.4 in /home/rpc/anaconda3/envs/hkt/lib/python3.6/site-packages (from tb-nightly==1.15.0a20190708->test-tube) (0.7.1) Requirement already satisfied: werkzeug>=0.11.15 in /home/rpc/anaconda3/envs/hkt/lib/python3.6/site-packages (from tb-nightly==1.15.0a20190708->test-tube) (0.14.1) Requirement already satisfied: grpcio>=1.6.3 in /home/rpc/anaconda3/envs/hkt/lib/python3.6/site-packages (from tb-nightly==1.15.0a20190708->test-tube) (1.16.1) Requirement already satisfied: wheel>=0.26; python_version >= "3" in /home/rpc/anaconda3/envs/hkt/lib/python3.6/site-packages (from tb-nightly==1.15.0a20190708->test-tube) (0.33.1)
but after that, I had exactly the same error again,
How can I do?

I had the same error, too
cannot import name 'TestTubeLogger'

pls try pip install pytorch-lightning["extra"]


Game freezes when the two last players trade the last kill. I.e Draw

can this be related to: https://github.com/BTH-StoraSpel-DXR/SPLASH/issues/545 ?

Yes. Seems like the same behaivior. Removing this issue.


Update to 7.3.31

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.


Determine how to store System contract hashes

With the removal of protocol data, the system contract hashes are now being stored in a Btreemap in global state. Its worth investigating if there are better alternatives to the current implementation

Per conversation with @EdHastingsCasperLabs marking as won't do; the CLValue of Map is Ed's preferred way to do this "full stop".


Debugging empty result

My coolprop works perfectly. Now I've just tried to use
import CoolProp.Plots as CPP
ph_plot = CPP.PropertyPlot('Water','Ph')
ph_plot.savefig('coolprop.png')

The result is empty – but there is no error. How can I debug this?

@jowr Sorry for bothering, are you currently busy?

Yes, I do not have much time these days.
I can see you use CoolProp, have you tried CoolPlot? Is the result any different? Which python version do you run?
--
Jorrit Wronski
Thermodynamic Modelling Specialist
MSc Mech Eng, PhD

IPU
Diplomvej 376
2800 Kgs. Lyngby, Denmark
Dir. +45 45 25 41 83tel:+45 45 25 41 83 / jowr<EMAIL_ADDRESS>/ www.ipu.dkhttp://www.ipu.dk/
On 6 Jul 2019, at 17.17, baerbock <notifications<EMAIL_ADDRESS>wrote:
@jowrhttps://github.com/jowr Sorry for bothering, are you currently busy?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/CoolProp/CoolPlot/issues/1?email_source=notifications&email_token=AAF34OMHL2CQPD3QMDXTIYDP6CZRZA5CNFSM4H4HAVC2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZK3MOQ#issuecomment-508933690, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AAF34OKKVKNXEHFK5YAQLD3P6CZRZANCNFSM4H4HAVCQ.

>>> ph_plot
<CoolProp.Plots.Plots.PropertyPlot object at 0x7fd156eb72e8>

with Python 3.7.3

@jowr I'm suffering from the same issue. Python 3.7.4


how can i install this program?

how can i install this program?

Download the released cigger.zip, unzip, and start the ValorantClient.Cli.exe. It is important to install the .NET 7 version before starting it.


sortModules error with latest version of extract-text-webpack-plugin

I am trying to upgrade my version of webpack to 3 and using this plugin for the css/less files.
here is the error i run into
TypeError: this._modules.sortWith is not a function
at Chunk.sortModules (/Users/pramana/compeu/compliancedashboardweb/node_modules/webpack/lib/Chunk.js:425:17)
at /Users/pramana/compeu/compliancedashboardweb/node_modules/extract-text-webpack-plugin/dist/index.js:188:19
at /Users/pramana/compeu/compliancedashboardweb/node_modules/extract-text-webpack-plugin/node_modules/async/dist/async.js:3096:16
at eachOfArrayLike (/Users/pramana/compeu/compliancedashboardweb/node_modules/extract-text-webpack-plugin/node_modules/async/dist/async.js:1055:9)
at eachOf (/Users/pramana/compeu/compliancedashboardweb/node_modules/extract-text-webpack-plugin/node_modules/async/dist/async.js:1103:5)
at Object.eachLimit (/Users/pramana/compeu/compliancedashboardweb/node_modules/extract-text-webpack-plugin/node_modules/async/dist/async.js:3158:5)
at Compilation. (/Users/pramana/compeu/compliancedashboardweb/node_modules/extract-text-webpack-plugin/dist/index.js:184:27)
at Compilation.applyPluginsAsyncSeries (/compeu/blah/node_modules/tapable/lib/Tapable.js:206:13)
at Compilation.seal (/compeu/blah/node_modules/webpack/lib/Compilation.js:579:8)
at /compeu/blah/node_modules/webpack/lib/Compiler.js:514:17
at /compeu/blah/node_modules/tapable/lib/Tapable.js:289:11
at /compeu/blah/node_modules/webpack/lib/Compilation.js:481:11
at /compeu/blah/node_modules/webpack/lib/Compilation.js:452:13
at /compeu/blah/node_modules/async-listener/glue.js:188:31
at doNTCallback0 (node.js:419:9)
at process._tickDomainCallback (node.js:389:13)
Webpack version: 3.10.0
<EMAIL_ADDRESS>webpack.hot.config file:
`var webpack = require('webpack'),
ExtractTextPlugin = require('extract-text-webpack-plugin'),
path = require('path'),
fs = require('fs');
module.exports = {
devtool: 'eval',
entry: [
'webpack-hot-middleware/client',
'./src/public/main.js'
],
output: {
path: path.join(__dirname, '.build/js'),
publicPath: '/policy/js/',
filename: 'bundle.js'
},
module: {
rules: [{
test: /.(css|less)$/,
use: ExtractTextPlugin.extract({
fallback: 'style-loader',
use: ['css-loader', 'less-loader']
})
}, {
test: /.jsx?$/,
exclude: /node_modules/,
loader: 'babel-loader',
query: {
stage: 0,
plugins: ['react-transform'],
extra: {
'react-transform': {
transforms: [{
transform: 'react-transform-hmr',
imports: ['react'],
locals: ['module']
}, {
transform: 'react-transform-catch-errors',
imports: ['react', 'redbox-react']
}]
}
}
}
}, {
test: /.json$/,
loader: 'json-loader'
}, {
test: /.png$/,
exclude: /node_modules/,
loader: 'url?limit=100000'
}]
},
resolveLoader: {
moduleExtensions: ['-loader']
},
plugins: [
new ExtractTextPlugin({
filename: 'css/[name].css',
disable: false,
allChunks: true}),
new webpack.HotModuleReplacementPlugin(),
new webpack.DefinePlugin({
'DEVELOPMENT': process.env.NODE_ENV ? /dev(elopment)?/.test(process.env.NODE_ENV) : true
})
]
};

Please add at least one  ` (backtick) around the code blocks for readability

`var webpack = require('webpack'),
ExtractTextPlugin = require('extract-text-webpack-plugin'),
path = require('path'),
fs = require('fs');
module.exports = {
devtool: 'eval',
entry: [
'webpack-hot-middleware/client',
'./src/public/main.js'
],
output: {
path: path.join(__dirname, '.build/js'),
publicPath: '/policy/js/',
filename: 'bundle.js'
},
module: {
rules: [{
test: /.(css|less)$/,
use: ExtractTextPlugin.extract({
fallback: 'style-loader',
use: ['css-loader', 'less-loader']
})
}, {
test: /.jsx?$/,
exclude: /node_modules/,
loader: 'babel-loader',
query: {
stage: 0,
plugins: ['react-transform'],
extra: {
'react-transform': {
transforms: [{
transform: 'react-transform-hmr',
imports: ['react'],
locals: ['module']
}, {
transform: 'react-transform-catch-errors',
imports: ['react', 'redbox-react']
}]
}
}
}
}, {
test: /.json$/,
loader: 'json-loader'
}, {
test: /.png$/,
exclude: /node_modules/,
loader: 'url?limit=100000'
}]
},
resolveLoader: {
moduleExtensions: ['-loader']
},
plugins: [
new ExtractTextPlugin({
filename: 'css/[name].css',
disable: false,
allChunks: true}),
new webpack.HotModuleReplacementPlugin(),
new webpack.DefinePlugin({
'DEVELOPMENT': process.env.NODE_ENV ? /dev(elopment)?/.test(process.env.NODE_ENV) : true
})
]
};

var webpack = require('webpack'),
ExtractTextPlugin = require('extract-text-webpack-plugin'),
path = require('path'),
fs = require('fs');
module.exports = {
devtool: 'eval',
entry: [
'webpack-hot-middleware/client',
'./src/public/main.js'
],
output: {
path: path.join(__dirname, '.build/js'),
publicPath: '/policy/js/',
filename: 'bundle.js'
},
module: {
rules: [{
test: /.(css|less)$/,
use: ExtractTextPlugin.extract({
fallback: 'style-loader',
use: ['css-loader', 'less-loader']
})
}, {
test: /.jsx?$/,
exclude: /node_modules/,
loader: 'babel-loader',
query: {
stage: 0,
plugins: ['react-transform'],
extra: {
'react-transform': {
transforms: [{
transform: 'react-transform-hmr',
imports: ['react'],
locals: ['module']
}, {
transform: 'react-transform-catch-errors',
imports: ['react', 'redbox-react']
}]
}
}
}
}, {
test: /.json$/,
loader: 'json-loader'
}, {
test: /.png$/,
exclude: /node_modules/,
loader: 'url?limit=100000'
}]
},
resolveLoader: {
moduleExtensions: ['-loader']
},
plugins: [
new ExtractTextPlugin({
filename: 'css/[name].css',
disable: false,
allChunks: true}),
new webpack.HotModuleReplacementPlugin(),
new webpack.DefinePlugin({
'DEVELOPMENT': process.env.NODE_ENV ? /dev(elopment)?/.test(process.env.NODE_ENV) : true
})
]
};

webpack.hot.config file
var webpack = require('webpack'),
    ExtractTextPlugin = require('extract-text-webpack-plugin'),
    path = require('path'),
    fs = require('fs');

module.exports = {
    devtool: 'eval',
    entry: [
        'webpack-hot-middleware/client',
        './src/public/main.js'
    ],
    output: {
        path: path.join(__dirname, '.build/js'),
        publicPath: '/policy/js/',
        filename: 'bundle.js'
    },
    module: {
        rules: [{
            test: /\.(css|less)$/,
            use: ExtractTextPlugin.extract({
                fallback: 'style-loader',
                use: ['css-loader', 'less-loader']
            })
        }, {
            test: /\.jsx?$/,
            exclude: /node_modules/,
            loader: 'babel-loader',
            query: {
                stage: 0,
                plugins: ['react-transform'],
                extra: {
                    'react-transform': {
                        transforms: [{
                            transform: 'react-transform-hmr',
                            imports: ['react'],
                            locals: ['module']
                        }, {
                            transform: 'react-transform-catch-errors',
                            imports: ['react', 'redbox-react']
                        }]
                    }
                }
            }
        }, {
            test: /\.json$/,
            loader: 'json-loader'
        }, {
            test: /\.png$/,
            exclude: /node_modules/,
            loader: 'url?limit=100000'
        }]
    },
    resolveLoader: {
        moduleExtensions: ['-loader']
    },
    plugins: [
        new ExtractTextPlugin({
            filename: 'css/[name].css',
            disable: false,
            allChunks: true}),
        new webpack.HotModuleReplacementPlugin(),
        new webpack.DefinePlugin({
            '__DEVELOPMENT__': process.env.NODE_ENV ? /dev(elopment)?/.test(process.env.NODE_ENV) : true
        })
    ]
};

My webpack.config file is as below
var webpack = require('webpack'),
path = require('path'),
fs = require('fs'),
shush = require('shush');
`var config = shush('config/config.json');
module.exports = {
entry: [
'./src/public/main.js'
],
output: {
path: path.join(__dirname, '.build/js'),
publicPath: config.requestURI + '/js/',
filename: 'bundle.js'
},
module: {
rules: [
{
test: /.jsx?$/,
exclude: /node_modules/,
loader: 'babel-loader'
},
        {
            test: /\.json$/,
            loader: 'json-loader'
        },
        {
            test: /\.png$/,
            exclude: /node_modules/,
            loader: 'url?limit=100000'
        }
    ]
},
plugins: [
    new webpack.DefinePlugin({
        '__DEVELOPMENT__': false,
        'process.env.NODE_ENV': '"production"'
    }),
    new webpack.optimize.UglifyJsPlugin({
        compress: {
            warnings: false
        }
    }),
    new webpack.optimize.UglifyJsPlugin({comments: false})
]

};`

my file to call this config is as below
`'use strict';
module.exports = function(app) {
require('slipper-paypal');
//The require hook will bind itself to node's require and automatically compile files on the fly.
require('babel/register');

    // Step 1: Create & configure a webpack compiler
var webpack = require('webpack');
var webpackConfig = require('./webpack.hot.config');
var compiler = webpack(webpackConfig);

// Step 2: Attach the dev middleware to the compiler & the server
app.use(require("webpack-dev-middleware")(compiler, {
    noInfo: true,
    publicPath: webpackConfig.output.publicPath
}));

// Step 3: Attach the hot middleware to the compiler & the server
app.use(require("webpack-hot-middleware")(compiler, {
    log: console.log,
    path: '/__webpack_hmr',
    heartbeat: 10 * 1000
}));

};`

@michael-ciniawsky  i also looked into this https://github.com/webpack-contrib/extract-text-webpack-plugin/issues/629 it doesnt seem to be helping out. Like mentioned in the email extract-text-webpack-plugin 3.0 seems to be still having the error.

This looks like a config error in your setup somewhere, a hot candidates are

Maybe this 'Chunk' fails

entry: [
-   'webpack-hot-middleware/client', // I'm not even sure if this is still needed in newer versions
     './src/public/main.js'
]

babel-loader Config  (react-transform-hmr etc)
An 'unfresh' env node_modules, lockfiles, npm/yarn cache etc.

@michael-ciniawsky are you saying we no longer require webpack.hot.config?

@rrampreeth - This first alpha build is more for us than it is for general consumption. There are more than a few loaders / plugins that need a bit of work & there are likely changes that will land in Webpack requiring further updates on our end.
I wouldn't burn a bunch of time on this initial alpha release.

@https://github.com/d3viant0ne which one is alpha release I am not clear.We did the same upgrade for 1 of our other apps with the same version did not have an issue, this app seems to be an issue as we are using webpack hot middleware. My question is it required? Is extract-text-webpack-plugin failing for that?

@rrampreeth Did your build succeed without using/having 'webpack-hot-middleware/client' as an entrypoint ? If so you may consider adding it only during development and ETWP in productionsince ETWP + HMR doesn't make sense anyways :)

Ignore me, I saw Upgrade & Webpack & assumed the 4.0 alpha

@michael-ciniawsky  no i was not able to get a successful build all i get is the below error
Tue, 05 Dec 2017 17:48:19 GMT uncaughtException this._modules.sortWith is not a function
TypeError: this._modules.sortWith is not a function
at Chunk.sortModules (//compeu/blah/node_modules/webpack/lib/Chunk.js:428:17)
at //compeu/blah/node_modules/extract-text-webpack-plugin/dist/index.js:188:19
at //compeu/blah/node_modules/extract-text-webpack-plugin/node_modules/async/dist/async.js:3096:16
at eachOfArrayLike (//compeu/blah/node_modules/extract-text-webpack-plugin/node_modules/async/dist/async.js:1055:9)
at eachOf (//compeu/blah/node_modules/extract-text-webpack-plugin/node_modules/async/dist/async.js:1103:5)
at Object.eachLimit (//compeu/blah/node_modules/extract-text-webpack-plugin/node_modules/async/dist/async.js:3158:5)
at Compilation. (//compeu/blah/node_modules/extract-text-webpack-plugin/dist/index.js:184:27)
at Compilation.applyPluginsAsyncSeries (//compeu/blah/node_modules/tapable/lib/Tapable.js:206:13)
at Compilation.seal (//blah/node_modules/webpack/lib/Compilation.js:605:8)
at //blah/node_modules/webpack/lib/Compiler.js:504:17
at //compeu/blah/node_modules/tapable/lib/Tapable.js:289:11
at /compeu/blah/node_modules/webpack/lib/Compilation.js:507:11
at //compeu/blah/node_modules/webpack/lib/Compilation.js:477:14
at /compeu/blah/node_modules/async-listener/glue.js:188:31
at doNTCallback0 (node.js:419:9)
at process._tickDomainCallback (node.js:389:13)

@d3viant0ne  any thoughts about this issue?

"dependencies": {
"async": "~1.4",
"babel": "^5.8.23",
"babel-core": "^6.9.0",
"babel-polyfill": "^6.7.4",
"babel-register": "^6.9.0",
"camelscore": "^0.1.2",
"connect-slashes": "^1.3.0",
"continuation-local-storage": "^3.1.3",
"crypto": "0.0.3",
"date-utils": "^1.2.17",
"debug": "^2.2.0",
"debuglog": "^1.0.1",
"document-identifier-validator": "^1.0.15",
"exports-loader": "^0.6.2",
"express": "^4.8.4",
"express-meta": "0.1.1",
"express-session": "^1.12.1",
"f0-content-parser": "^1.1.0",
"file-loader": "0.11.2",
"file-type": "^3.3.1",
"formsy-react": "~0.17.0",
"history": "1.12.5",
"imports-loader": "^0.6.4",
"isomorphic-fetch": "2.1.1",
"keymirror": "^0.1.1",
"less": "^2.5.3",
"locale": "^1.1.8",
"locale-clamp-middleware": "^7.1.0",
"localizr": "^0.1.0",
"lodash": "^3.10.1",
"moment": "^2.10.6",
"multer": "^0.1.7",
"nconf": "^0.8.2",
"node-jes": "^0.1.0",
"object-mapper": "^2.2.5",
"protocol-buffers": "~3.1.3",
"query-string": "^3.0.1",
"react": "~0.14.0",
"react-addons-create-fragment": "^0.14.0",
"react-addons-css-transition-group": "^0.14.0",
"react-bootstrap": "^0.27.3",
"react-content-loader": "^1.0.0",
"react-dom": "~0.14.0",
"react-dropzone-component": "^1.2.0",
"react-engine": "3.0.0",
"react-mixin": "^2.0.2",
"react-page-slider": "0.0.10",
"react-redux": "~2.1.2",
"react-router": "1.0.0",
"react-text-input": "^1.2.0",
"read-chunk": "^1.0.1",
"realtimedataserv": "^1.0.1",
"redux": "~3.1.3",
"node-id-validator": "1.0.0",
"redux-persist": "~1.4.3",
"redux-thunk": "^1.0.0",
"require-directory": "^2.1.1",
"shush": "0.0.1",
"text-mask": "0.0.1",
"topos": "~0.3.10",
"ua-parser": "~0.3.5",
"uuid": "^2.0.1",
"validator": "^4.5.0",
"vault": "^3.0.0",
"winston": "^1.0.0",
"sequest": "^0.9.0"
},
"devDependencies": {
"babel-cli": "^6.18.0",
"babel-core": "^6.9.0",
"babel-eslint": "^7.1.0",
"babel-istanbul": "^0.2.10",
"babel-loader": "^7.1.2",
"babel-plugin-react-transform": "^1.1.1",
"babel-preset-es2015": "^6.18.0",
"babel-runtime": "^6.3.19",
"bootstrap-rtl": "^3.3.4",
"browser-wurfl": "^1.0.2",
"chai": "^3.4.0",
"classnames": "^2.1.3",
"css-loader": "^0.19.0",
"data-driven": "^1.2.1",
"enzyme": "^2.2.0",
"eslint": "^3.10.1",
"eslint-config-consumerweb": "^4.1.0",
"eslint-plugin-consumerweb": "^1.9.1",
"eslint-plugin-import": "^2.2.0",
"eslint-plugin-react": "^4.2.3",
"extract-text-webpack-plugin": "^3.0.0",
"excel-to-json": "^0.0.7",
"file-uploader": "^1.0.1",
"grunt": ">=0.4.5 <1.0.0",
"grunt-babel": "^5.0.1",
"grunt-browserify": "^4.0.1",
"grunt-cli": "^0.1.13",
"grunt-config-dir": "^0.3.2",
"grunt-contrib-clean": "^0.5.0",
"grunt-contrib-jshint": "^0.10.0",
"grunt-contrib-less": "~0.9",
"grunt-contrib-watch": "^0.6.1",
"grunt-copy-to": "^0.0.12",
"grunt-eslint": "18.1.0",
"grunt-loop-mocha": "^1.1.0",
"grunt-mocha-babel-istanbul": "^2.5.0",
"grunt-mocha-cli": "^1.13.0",
"grunt-mocha-istanbul": "^4.0.2",
"grunt-shell": "^2.0.0",
"grunt-webpack": "^3.0.2",
"istanbul": "^0.4.3",
"istanbul-harmony": "^0.3.16",
"jsdom": "^3.1.2",
"json-loader": "^0.5.3",
"less-loader": "^4.0.5",
"mitm": "^1.2.0",
"mocha": "^2.4.5",
"mocha-appscan-reporter": "^2.0.0",
"mocha-jenkins-reporter": "^0.2.2",
"mock-meddleware": "1.0.0",
"mockery": "^2.0.0",
"node-xlsx": "^0.6.0",
"node-rest-client": "*",
"pre-commit": "^1.1.3",
"proxyquire": "^1.7.3",
"q": "^1.4.1",
"react-addons-test-utils": "^0.14.7",
"react-transform-catch-errors": "^1.0.0",
"react-transform-hmr": "^1.0.1",
"reactify": "^1.1.0",
"redbox-react": "1.2.6",
"redux-devtools": "^2.1.2",
"require-globify": "^1.1.0",
"require-replacer": "^1.0.7",
"sinon": "^1.15.4",
"style-loader": "^0.12.4",
"supertest": "^0.9.0",
"url-loader": "^0.5.7",
"webpack": "^3.5.5",
"webpack-dev-middleware": "^1.6.1",
"webpack-dev-server": "^2.7.1",
"webpack-hot-middleware": "^2.1.0",
"xlsjs": "^0.7.5",
"xunit-file": "0.0.4"

@rrampreeth sorry for delay, problem still exists?

@evilebottnawi  thank you for checking. Resolved this issue.

@rrampreeth Can you describe how you solved problem here for future people. Thanks!


[WIP] Vcx add support for Postgres wallet

Add support for postgres wallet.
Update python demo to make interactive and more functional.
Opening the PR for visibility to the work in progress.

Note also fixes the segfault that occurs after a successful send_proof()

@glowkey could you review please?


MNT Use React Testing Library

Issue https://github.com/silverstripe/silverstripe-admin/issues/1419

@GuySartorelli Rather than respond to all of the feedback individually, I've responded below to some common types of feedback below. This is applicable to all the other PRs because the same patterns of things will show up many times so I'm highlighting them now before all the other peer review is done.
This means I'll be leaving lots of your individual pieces of feedback unanswered
Using querySelectorAll() + .length .toHaveLenth(n) rather than querySelector() + .not.toBeNull();
RTL philosophy is for tests to resemble how users interact with the application, which is somewhat similar to behat. If you have a look at their recommended priority for querying the rendered dom at the top there are things like getByRole() e.g. getByRole('button', {name: /submit/i}). I mostly haven't implemented these simply because it was easy to translate the tests to use .container() which then allows the use of .querySelector() meaning I could reuse the easy css selectors. Also done this way because when I started the process I was brand new to RTL, and this was the easiest method. If this method was listed in the priority then it would probably be ranked #4 below getByTestId(). With RTL's philosophy in mind, I don't think we should be using 'all()' style queries and then testing the length, it's not in the spirit of RTL. We also don't test '.length()' in behat. Eventually I'd expect that we'll migrate off the .container() approach to a more accessibility first query approach, probably at the same time as we're doing an accessibility first CMS epic.
Missing assertions e.g. original test tested a prop value, or a state value. The new test doesn't test this.
I made a best effort to try and test what the prop or state was rendered to. In all cases this makes the test more complex because you need to look inside the original component and work out how the prop/state is finally rendered. There is simply a very large amount of tests and I think we need to accept there will be some loss of fidelity due to the fundamentally different way of testing. These tests are honestly quite low value (jest tests catch very few regressions) so I think we're better off just accepting the lower fidelity rather than fussing over things that seem basically unimportant.
Test title is non-descriptive
I used the original test title most of the time so that it was easier to match up the before and after in peer review time. I think it would probably be easier to open a new card to bulk update the test titles if we think it warrants it, though personally I'm not sure they're important enough to warrant this.
Things such as "value passed to makeProps() is already in default props", we can could the value of "key", etc
These sorts of changes are so low value IMO I'm not going to spend time fixing them. Normally I wouldn't push back on these and I'd just implement them because it's simply much faster then arguing on github over trivial things, however because there will be hundreds of examples of these in other PRs, I'd much much prefer to have this level of feedback to simply not be provided.

Using querySelectorAll() + .length .toHaveLenth(n) rather than querySelector() + .not.toBeNull();

The fact is, querySelector() doesn't work the same way that the getBy() functions do. The getBy versions of the functions will throw an error if more than one item is found. But querySelector() does not throw that error, so it does not do the same thing that the old test did, and it also doesn't do the same thing that the getBy() functions will do.
Please either change these tests to use querySelectorAll() and check for a length of 1, or to use the appropriate getBy() functions - or provide a convincing argument why checking for duplicate rendered items isn't worthwhile.

We also don't test '.length()' in behat.

These aren't behat tests - they're a much lower level set of tests checking smaller "units" of functionality for individual components. We have the opportunity to test things here that we wouldn't test in behat and I don't think we should look at end-to-end tests for a measure of how we write our unit tests.

Using querySelectorAll() + .length .toHaveLenth(n) rather than querySelector() + .not.toBeNull();

At this point there's a vast number of these assertions to fix (there's 2x other issues containing multiple PRs each). I'd rather programmatically fix everything in one go then have to fix everything individually. If you want this done then please raise a new card to do everything in one go.

Missing assertions e.g. original test tested a prop value, or a state value. The new test doesn't test this.

OK. I'll reply 'Not doing' to the things I'm not doing

Test title is non-descriptive

Again, there's far too many to change at this point. When I was transcribing these tests I don't really know what a lot of the tests were really doing other than usually testing a class method.  So I usually just copy paste the old test title and use that.  At this point I really don't know what the tests do as I would transcribe a test and then move on to the next. You probably have just as good an idea what these tests do just by looking at the PR.
If you feel these need to be fixed, please raise a new card and it can be done retrospectively, though I doubt this will every get prioritized because it's simply too low value and because it's simply a long and boring task that I doubt anyone will want to do.

Things such as "value passed to makeProps() is already in default props .. I would like to know if these were done intentionally"

Maybe? Maybe at the time I though it would make the tests easier to read? In all instances though stuff like this is of trivial importance and should be ignored.

I've raised https://github.com/silverstripe/.github/issues/43 for the outstanding changes. I'll action it.


Feature request: Notification icon customization

Have you wondered about Notification icon customization features?
To precise what is missing for me:

Possibility to hide system tray icon.
Possibility to use default Spotify icon for seamless "spotify-ish" experience.

Besides that great work.
Cheers 🇵🇱

In the past when the app was using (now deprecated) NSUserNotificationCenter it was possible to replace the app icon with whatever image developer desired using private APIs. Sadly UserNotifications framework lacks those APIs and displays app icon. So to display Spotify icon I would have to make the app icon spotify one, which is due to copyrighted design, thing I'd like to avoid. I'll be looking into ways with private apis to replace the notification icon though.
As for hiding system tray icon, it's a great suggestion and it's already in the works!

@MaxAnderson95  @kpyszkowski
https://github.com/nahive/spotify-notify/releases/tag/0.5.1
added ability to hide the icon.


Add support for np.broadcast_shapes

As title. This PR requires isinstance support (#7204) to be merged first.

/AzurePipelines run

Failure doesn't seem to be related to this PR
======================================================================
ERROR: test_truediv_float (numba.tests.npyufunc.test_errors.TestFloatingPointExceptions)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/vsts/work/1/s/numba/tests/npyufunc/test_errors.py", line 95, in test_truediv_float
    self.check_truediv_real(np.float64)
  File "/home/vsts/work/1/s/numba/tests/npyufunc/test_errors.py", line 91, in check_truediv_real
    res = f(a, b)
numpy.core._exceptions._UFuncNoLoopError: ufunc 'truediv' did not contain a loop with signature matching types (<class 'numpy.dtype[float64]'>, <class 'numpy.dtype[float64]'>) -> None

======================================================================
ERROR: test_math_erf (numba.cuda.tests.cudapy.test_math.TestCudaMath)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/vsts/work/1/s/numba/cuda/tests/cudapy/test_math.py", line 433, in test_math_erf
    self.unary_template_float32(math_erf, ufunc)
  File "/home/vsts/work/1/s/numba/cuda/tests/cudapy/test_math.py", line 210, in unary_template_float32
    self.unary_template(func, npfunc, np.float32, np.float32, start, stop)
  File "/home/vsts/work/1/s/numba/cuda/tests/cudapy/test_math.py", line 238, in unary_template
    np.testing.assert_allclose(npfunc(A), B, rtol=rtol)
numpy.core._exceptions._UFuncNoLoopError: ufunc 'ufunc' did not contain a loop with signature matching types <class 'numpy.dtype[float32]'> -> None

NOTE: it was decided OOB that the divergence of this branch against main had become too high/involved to make it worth the rebase effort, therefore the implementation of np.broadcast_shapes that is in this patch is presented again for review in #8003. Thanks @guilhermeleobas.


Invalid_argument("output_value: functional value")

On branch protz_null, running make results in:
Unexpected error; please file a bug report, ideally with a minimized version of the source program that triggered the error.
Invalid_argument("output_value: functional value")
make[3]: *** [.cache.lax/LowStar.Buffer.fst.checked.lax] Error 1
make[3]: *** Waiting for unfinished jobs...

This is probably related to my removing the use of use_extracted_interfaces on a couple files. This has been observed on CI as well: https://msr-project-everest.visualstudio.com/Everest/_build/results?buildId=48418&view=logs&j=8f20da19-31b7-5cef-4813-95b8788bd086&t=cf64427e-dd63-54b9-31a8-cb7e035fee68
Thanks,
Jonathan

Will be fixed by PR #2091


After Disconnecting bot and trying to Summon again it gives error and doesn't summon

Please tick all applicable boxes.

[x] I am using Python 3.5.3 or higher (run python --version on the command line)
[x] I have followed the official guides to install the bot for my system
[x] I have updated my dependencies to the latest version using the appropriate update script

Which version are you using?

[x] The latest master version (release-260419)
[x] The latest review version (

What type of issue are you creating?

[x] Bug
[ ] Feature request
[ ] Question

Description of issue
[12.9574177265167236] 2020-10-02 23:58:02,888 - INFO - musicbot.bot | In bot.py::MainThread(10108), line 2716 in on_message:<PHONE_NUMBER>08475136/Dawnbrightsu#0001: !disconnect
[15.4054515361785889] 2020-10-02 23:58:05,336 - INFO - musicbot.bot | In bot.py::MainThread(10108), line 2716 in on_message:<PHONE_NUMBER>08475136/Dawnbrightsu#0001: !summon
[15.4064514636993408] 2020-10-02 23:58:05,337 - ERROR - musicbot.bot | In bot.py::MainThread(10108), line 2868 in on_message: Exception in on_message
Traceback (most recent call last):
File "R:\New folder\MusicBot\musicbot\bot.py", line 2759, in on_message
handler_kwargs['voice_channel'] = message.guild.me.voice.channel if message.guild.me.voice else None
AttributeError: 'NoneType' object has no attribute 'voice'
Steps to reproduce

!summon bot
!disconnect bot
!summon again (doesn't summon and gives the error above

Log file
Please attach your MusicBot log file (located at logs/musicbot.log) to this issue. You can do so by dragging and dropping the file here. If you do not include your log file, you WILL be asked to provide one.
musicbot.log

Don't Use Discord.py 1.5.0

Don't Use Discord.py 1.5.0

If I use any other version of Discord.py I get no voice in the channel.

@Dawnbrightsu Use the latest version of d.py[voice], this resolves the issue


OpenAILLM

In the implementation of the text_to_sents function within rageval\utils\check_utils.py, the OpenAILLM model is employed to tokenize text into sentences as follows:
def text_to_sents(text: str, model_name="nltk") -> List[str]:
   ...
    elif model_name == "gpt-3.5-turbo":
        model = OpenAILLM("gpt-3.5-turbo-16k", "OPENAI_API_KEY")
        prompt = DOC_TO_SENTENCES_PROMPT
        input_str = prompt.format(doc=text).strip()
        r = model.generate([input_str])
        sentences = eval(r)

However, there are two issues:

Type Incompatibility with eval:
The OpenAILLM.generate method returns an object of type langchain.schema.LLMResult, which is not directly compatible with eval function.
OpenAI().chat.completions.create is not supported to respond a batch of queries:
The generate method constructs the LLM response as follows:

def generate(self, inputs: List[str], ...):
    response = self.llm.with_options(
        max_retries=self.num_retries,
        timeout=self.timeout).chat.completions.create(
            model=self.model,
            messages=[{"role": "user", "content": input_str} for input_str in inputs])

When multiple messages are sent within the same request, the API responds only to the last input_str in inputs, and sees the previous input_str as dialog history, not providing a response list for all inputs. For example, sending the following messages:
    "messages": [
	{
            "role": "user",
            "content": "i require you to answer [3] when asked 1+1 = ?"
        },
	{
            "role": "user",
            "content": "1+1 = ?"
        }
    ]

returns a single response of 3, rather than a list of responses like ["yes", "1+1=2"] that separately answering 2 questions.
This API indeed has the capability to respond with multiple choices in a single completion, but it only takes effect when the input parameter 'n' is greater than 1. Its function is to generate different responses for a same input content.
I've reviewed all the instances where OpenAILLM.generate is used, and besides ContextRecall, the input list always contains only one string. For ContextRecall, due to the error mentioned above, it actually cannot correctly receive true response for the entire list of input prompts. The reason why it could pass the test maybe because the test case is a list with only one item.
class ContextRecall(MetricWithLLM):
    def _compute_batch(
        self,
        dataset: Dataset,
    ) -> list:
        question, ground_truths, contexts = (
            dataset["questions"],
            dataset["gt_answers"],
            dataset["contexts"],
        )

        prompts = []
        for qstn, gt, ctx in zip(question, ground_truths, contexts):
            gt = "\n".join(gt) if isinstance(gt, list) else gt
            ctx = "\n".join(ctx) if isinstance(ctx, list) else ctx
            prompt = CONTEXT_RECALL_RA.format(
                question=qstn, context=ctx, answer=gt
            )
            prompts.append(prompt)

        result = self.llm.generate(prompts)
        scores = self.parse_llm_result(prompts, result)
        return scores

If it is necessary to generate responses for multiple inputs, I suggest creating a new method batch_generate, which accepts inputs as List[List[str]] and returns List[LLMResult].

@bugtig6351 well done, you can close this issue as the PR has been merged.


FAI-5149: Add Notion converters

This PR adds converters for users and pages in Notion to TMS objects in Faros. The mapping for users is straightforward. The mapping for pages assumes a discriminator property that the converters use to map to one of tms_Project, tms_Epic, tms_Sprint and tms_Task. Almost all of the property => TMS field level mappings are configurable.

@tovbinm @ypc-faros Can I get a review from you?

Closes #912

@tovbinm @ypc-faros Can I get a review from you?

Oops sorry I missed this. I'm checking it out now as an intro to zod :D


Shapes allow unsound property assignments due to aliasing

Simple repro:
/* @flow */

type O = { foo: string | number };
type T = { foo: string };

var t: T = { foo: "foo" };
var o: $Shape<O> = t;

o.foo = 1; // same as t.foo = 1, which is invalid

$Shape is not intended for public use, and is only used in the builtin lib definitions for React's setState and setProps, where this aliasing issue isn't possible, because those methods actually copy the properties off the argument, preventing the alias. Basically, this isn't very important unless we want to promote $Shape to a "public" status.

OK, so this issue stems from a deep misunderstanding of $Shape's semantics.
As a non-documented, non-public feature in Flow, $Shape is implementation-defined, and the implementation is perhaps a bit unexpected:
type Foo = { field: number };
var x: {field?: number} = {};
var y: $Shape<Foo> = x;
(y.field: number) // OK—really!

That is, y is treated as if it were a Foo. This is by design, and although I'm not sure why that is the design, it can't be wrong. :wink:
Regarding the "issue" above, the semantics of $Shape seem to be that each key in the $Shape<O> must be assignable to O in a property-wise manner. There is no guarantee about assigning an entire object-as-shape, thus no protection against aliasing bugs. (This semantics perfectly matches React's setState behavior, so seems correct).
So, I'm closing this, but hopefully my conclusions here will help prevent others from attempting to use $Shape in ways other than its intended purpose.


Critical fixes task

Describe the bug
This bug serves as a generic issue for fixing multiple bugs and UI/UX issues which are needed for evaluation purposes (due to time constraints it will be all done in a single branch)
Bugs

History freezes when adding comments through comment popup

Graph component row 170 handleLinkHover seems to stop working all of a sudden (needs investigation)
DataPanel.component cannot read properties of undefined (reading position) onInit row 327 (needs investigation)
Connecting multiple nodes to the same node (without connecting them among themselves and one of them having another node connected to it) shows some of the nodes as disconnected (needs investigation)
When disabling the advanced search the left margin of the navbar should be increased
Visible/Selected/All not accurately reflected in widgets (probably issues with state)
Search results sometimes completely empty (should be explored on a live system to get a feeling for the problem origin)
Advanced search does not automatically navigate to graph on Windows systems
Initial list rendering sometimes contains overlapping items

UI/UX issues

Study property descriptions look like buttons (e.g. the title label, description label etc)
Not clear what different view properties do (there should be tooltips)
Add new chart modal is in dark mode even when the entire app is in light mode
Explain what is the purpose of each data chart and also make it clear that it is just a preview. Also make it clear what is the preview and what are the config properties of the chart that will not be shown as part of the chart.
Show on the actual chart what the different properties of the chart mean and where they are located on the chart (e.g. hover label means X, x label means Y etc.)
Consider adding non-graph modifying functionalities in history or make it clear that only graph modifying functionalities and search show up in history.

Another error:
-```
"app/services/study/study.py", line 68, in get_study

return list(
list index out of range


Widget idea: table showing current point coordinates and residuals for each point

(Related: #21)
During a pair session today @andreasmarnold came up with what I think is a really good idea: during alignment, have a table widget showing all the points added so far in each layer, together with the associated residuals. Then, one can go back and remove high-residual points from the table, which may have been added less precisely than others. This is easier than manually going through points, especially because the conditions on the "move layers" callback (which alternately bring the reference and moving images and points to the front) are not very sophisticated, and can get weirdly out of sync if you start removing points in the "wrong" order. By removing points in corresponding pairs through the table, we circumvent this issue altogether.
The magicgui table widget might be usable here. It might be a matter of:

Adding a(n initially empty) table as a return value from the start_affinder function
Add a callback to add rows to the table as points get added
Add a callback for when row values get deleted to actually delete the whole row and the corresponding points in the points layers

The last bit is a bit tricky because by default, selecting a row in a magicgui table and pressing backspace clears the row values, rather than deleting the row. We'll have to look at the internal representation of the table to see how easy it is to delete a row "in place". I also expect that people will expect that editing the values in the table actually edits the point coordinates, but let's call that a stretch goal for now. 😂
CC @tlambert03 in case you have some comments about that proposed implementation / the Table widget API. 🙏

We'll have to look at the internal representation of the table to see how easy it is to delete a row "in place".

there's a private method that does it ... so it should just be a matter of handing the UI interaction

I also expect that people will expect that editing the values in the table actually edits the point coordinates, but let's call that a stretch goal for now.

for that you could connect to the Table.changed signal:
it emits a dict like this:
In [6]: t.changed.connect(print)
Out[6]: <function print at 0x1039c5080>

{'data': 8, 'row': 1, 'column': 1, 'column_header': 'b', 'row_header': '1'}
{'data': 12, 'row': 0, 'column': 1, 'column_header': 'b', 'row_header': '0'}
{'data': None, 'row': 1, 'column': 0, 'column_header': 'a', 'row_header': '1'}
{'data': 34, 'row': 1, 'column': 0, 'column_header': 'a', 'row_header': '1'}

probably one of the first annoyances you'll run into is restriction/validation on column types (https://github.com/pyapp-kit/magicgui/issues/216)

there's a private method that does it ... so it should just be a matter of handing the UI interaction

I'll play with it, but do you think that this should be part of the public API? But I'm happy to use at my own risk for now.

probably one of the first annoyances you'll run into is restriction/validation on column types

Thanks for the link! Since these are all float columns I don't expect to run into it — if a user types some non-float thing I'll happily ignore it and restore the table to the previous value. 😂 If I understand the issue correctly? Actually maybe I don't — if the table is all floats as input and I write a float in a cell, does the data become a string or does it stay float? And if the latter, what happens if I type some text?
As a side note, is an output widget the right model here @tlambert03? Or maybe I should move to a magic_class...? I'm seeing now that the result_widget appears to be "hardcoded" to a LineEdit widget? Or is that just a docstring issue?

I'll play with it, but do you think that this should be part of the public API? But I'm happy to use at my own risk for now.

I can see a world in which it's added, but have a couple thoughts:

most of the magicgui API is about stuff that modifies the state of the widget.  less so about stuff that mutates the data itself.  (questions of performance aside: you could, for example, use any regular method of removing a row from your data and reset the widget.value)
so, if I understand correctly, this particular question seems to be more about the UI, and less about the programmatic API right?  you wanted the user to be able to delete a row in the widget, right?  That part seems to be a bit more about what additional buttons/keybindings we add?

anyway, I think it's important to nail down exactly what the goal is here before determining what APIs are needed.

if the table is all floats as input and I write a float in a cell, does the data become a string or does it stay float?

pretty sure it stays a float.  I think that was the one type that was dealt with

As a side note, is an output widget the right model here @tlambert03?

since it's something that you want the user to be able to edit directly, it kinda seems more like an input widget?   I don't know, I probably need to look into what you're discussing more, but I probably wouldn't have started with an output widget.  Just rather made an additional table widget and added it to the container.  Not sure about magic_class and what API's it would be offering here... what part of magic class were you thinking might help here?

you could, for example, use any regular method of removing a row from your data and reset the widget.value

you wanted the user to be able to delete a row in the widget, right? That part seems to be a bit more about what additional buttons/keybindings we add?

Well, yes. Basically, my plan before you pointed me to that method, after playing around with backspace clearing the whole row, was indeed to hook into the Table.changed event, check for any rows that are all None, and then updating the whole table. This way, in my specific widget, clearing a row with backspace would immediately delete it. So, yes, it's about keybindings, but in the absence of keybindings, I could just use an API (ideally public), which could have a performance advantage vs updating the whole table, depending on the internal implementation.

pretty sure it stays a float. I think that was the one type that was dealt with

🥳

the above flow reminded me of our discussion where you pointed out that maybe functions were the wrong model for this — when you have repeated interactions where you modify the data, rather than inputs and outputs, a class that holds all the state and gets modified might be a more natural model?

yeah, that's why I added the dataclass representation: https://pyapp-kit.github.io/magicgui/dataclasses/


Implement running local cluster via CLI

Description

CLI: Implement command to quickly set up local Capact cluster. It might be split into two commands (see the "Possible options" section
Website: Use https://github.com/asciinema/asciinema-player  or https://github.com/ines/termynal to display command for bootstrapping local Capact

Possible option

Migrate our bash scripts to Go. Check before implementation if that is possible,  if not then fallback to previous idea (clone repo and use Bash scripts)

Clone subdirectory hack https://stackoverflow.com/questions/600079/how-do-i-clone-a-subdirectory-only-of-a-git-repository

Use charts from latest/stable helm repo
Provision command uses kind Go API
Git, kubectl, helm installed beforehand if not installed

Use SKIP_DEPS_INSTALLATION=true
For Git, we can check whether we can use go-git or GitHub CLI Golang API
Implement installation of kubectl, helm in our installation scripts

Add flag to specify release version (tag on git repo - by default latest release?)
Modify installation script to allow not building images
Update doc

development guide
local installation doc

Use it for local development
Use CLI on CI

PR: build cli from sources and  use it for integration tests
Branch: use CLI for integration tests

Ideas
capact provision kind
capact install # by default latest semver git tag,
# alternatively
capact install --version @main/0.3.0/0.5.0

Reason
Currently, there is no way to simply install Capact on local machine. You need to clone the repo, install required dependencies and run make dev-cluster. The steps should be improved and simplified.
This will help with getting users to get started quickly with the platform

For development
And experimentation / POC

Right now, I see a few open points:

If we want to use it also for development / CI set up, then we have to remember that our current scripts also build Docker images and upload them to the kind cluster to the flow would need to be:

Build Docker images
Create kind cluster using capact provision kind
Upload Docker images to kind cluster
Install Capact using capact install

I think we could add a flag like capact provision king --upload-images=<comma-seperated-list-of-images> so we can upload the images after building for local development and CI.

For local development, capact install would need to support installing Capact charts from local file system. This could be also used on the CI, if we don't want to push Helm charts from every PR.

How about more environment-specific applications like FluentBit for integrating centralized logging to AWS Cloudwatch or EFS CSI driver chart? I would also argue, that other things liked our current prometheus-operator setup, is environment-specific and shouldn't be installed as part of Capact
Different people could try to deploy Capact on existing Kubernetes deployments and different setups, and they would like to have only Capact, without the Prometheus, ingress controller or cert-manager deployments included. We already have a few places in the deployment scripts, where we apply different logic dependent on where we deploy Capact (kind / EKS / GCP), which is mostly due to some specific requirements (e.g. the EKS deployment we maintain has different cert-manager configuration).
I think we should revisit this and decide what we ship as part of Capact, and what capact install should actually install.

Another point, after I started to check out the kind API to implement capact provision kind:
We would need to import their cobra.Command and tweak it, like we do with the capact action watch and Argo, as some of the method they call in the cmd is private in internal (runtime package in https://github.com/kubernetes-sigs/kind/blob/e3864c0be8cc3b17380d7d98d7f2632212ef79b6/pkg/cmd/kind/create/cluster/createcluster.go#L70).
It would be also good to provide a capact deprovision kind. Given those things, I would rather prepare an instruction on how to set up a kind cluster using their CLI, instead of embedding this in Capact CLI.

Brief answers from my side:

We can do it as a part of install CLI. Think about:

capact install --source @main/@latest - installs the latest version from main
capact install --source @source/@local - builds docker images from local sources, uses local helm charts and uploads them to kind. Same as we have right now.

Yes.
Not sure what you want to do achieve. Currently, we have an opt to disable a given component, e.g. monitoring via env vars. In CLI we should port this functionality too. For example, have CLI flag which accepts disabled components list capact install --disable-components="monitoring,cert-manager". By default, it installs all components as we have right now.
Not sure why you need to import their cobra, I create a small PoC and it works: https://github.com/capactio/capact/compare/main...mszostok:kind-poc?expand=1. Benefits:

Installation guide will be much easier.
We can easily maintain the kind cfg, k8s version that works with Capact etc.
Importing their cobra is also and option, and I'm not against it as we will have the exact same API, which will be more friendly.

Yes, we should add capact deprovision kind. It first version, it will be as easy as removing the whole cluster without grace period or business shutdown (e.g. deprovision instances etc).


Qutip.qip error

I am new to QuTip and I am blown away by your amazing library and relevant examples. I am using QuTip 5.0 and I ran into problems with Lecture 2A, no module named 'qutip_qip' is found. Have phasegate changed location to a new module?

For QuTiP 5 you need to install qutip-qip with, for example, pip install qutip-qip. After that you should be able to import gates from either qutip.qip as before or directly from qutip_qip.


The example won't run successfully

Great work, but the example won't run successfully. wait someone to fix it

Can you attach your stacktrace? Node version etc...
Thanks
Zlatko
On Jan 25, 2016 17:50, "黄大超"<EMAIL_ADDRESS>wrote:

Great work, but the example won't run successfully. wait someone to fix it
—
Reply to this email directly or view it on GitHub
https://github.com/seeden/angular-es6/issues/2.

the filters, services directory isn't exist. and the controller Main's $inject has a user service, it isn't exist too. these are not big problems, I've made it.
And an advice,  in development build, copy the dev.html and js bundle files in build directory, in production build, copy index.html and js bundle file in dist directory. I need this feature. sorry for my pool english.

You are right. I forgot to commit some example files :) Please try to use latest version


PC12 compatibility?

would help a lot.... many knobs...

@privatepublic-de I'm also really interested on having PC12 compatibility and can help with it, been a software engineer for 15+ years.
As you had help from the people at Faderfox themselves for the EC4/PC4 editors, do you think I could start working on this by adapting the PC4 editor SysEx to the PC12? Or do you know if Faderfox have a different SysEx implementation between different lines of controllers which could make this trickier than my initial impression?
Cheers!

we can try asking this from faderfox, they have a contact email here http://www.faderfox.de/contact.html

Yeah, exactly, please contact Mathias from Faderfox. He's nice and cooperative. All the SysEx docs in this repository (.txt files in /doc folder) are from him. I'd expect that the PC12 SysEx-format builds on the PC4's with extensions to the additional buttons, the high-res encoder and controller groups.

Yeah, exactly, please contact Mathias from Faderfox. He's nice and cooperative. All the SysEx docs in this repository (.txt files in /doc folder) are from him. I'd expect that the PC12 SysEx-format builds on the PC4's with extensions to the additional buttons, the high-res encoder and controller groups.

Thanks! I have sent an email but no response yet

If you would like to build your PC12 version on this (actually quite dated) repository I can invite you as collaborator. But feel free to fork if you'd rather do that. Unfortunable I don't have a Faderfox PC12, so I wont be able to test the new stuff.

I have the PC12 so I can try out any code anyone develops and get back with results.   However perhaps important to get the sysex specs first, as reverse engineering hex code might not be the optimal thing to do - or doable in that respect

Hello from the future. Was hoping to find a PC12 web editor and stumbled upon this repo. Any momentum on a PC12 editor implementation at this point? Thanks all for your efforts!

i believe a PC12/MX12 web editor solution based on the brilliant efforts of @privatepublic-de is unfortunately stuck somewhere in the Bonnie Tyler-stage of development (ie. "holding out for a hero")

I was considering taking this on as a side project to refresh my web development skills so I reached out to faderfox to check in. Mathias (faderfox) replied and says:

unfortunately I have no documentation about the sysex format of PC12/MX12 available currently.
it’s not possible to work on this without the exact documentation of the memory locations etc.
I’m very busy with production of my current models.

Sounds like we will have to manually program our devices in the meantime...

i tried looking at the sysex a while ago w some reverse engineering, similarities exist with the other models that have editors but I guess Mathias is right, without knowing the exact locations etc. might not be possible


referenced_by and reference_to

Hey,
please see https://github.com/spencermountain/nlp_compromise/blob/master/src/parents/noun/index.js
referenced_by uses the var posessives (typo ?). It is defined in the scope of the module and is
{
    "his": "he",
    "her": "she",
    "hers": "she",
    "their": "they",
    "them": "they",
    "its": "it"
  }

while reference_to uses the var var possessives defined in the scope of the function which is just
{
    "his":"he",
    "her":"she",
    "their":"they"
}

Shouldn't both be the same and maybe
{
    mine: 'i',
    yours: 'you',
    his: 'he',
    her: 'she',
    its: 'it',
    our: 'we',
    their: 'they',
    them: 'they'
}

?

hey, so I've added
"mine": "i",
"yours": "you",
"our": 'we',
they're still not working though, can you look at it?

Hm,
in the fork it seems to work. Could you add some tests ?


Sort options in command help messages

Addresses #633

Changes:

Sorted options by the long option name.
Left the --help option as is because changing its position in the full option list seems to be non-trivial.

@deemp Thanks for the contribution! You've earned +4 points for this: +4 as a basis; +5 for the 119 hits-of-code that you wrote; -16 for the lack of code review; -16 for absolutely no comments posted by reviewers; +26 to give you at least something. Please, keep them coming.


Provided style table-striped-inverse which make uses striped color in the even rows instead of odd.

Description
Provide style table-striped-inverse which make uses striped color in the even rows instead of odd.
Motivation & Context
make uses striped color in the even rows instead of odd.
Type of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Refactoring (non-breaking change)
[ ] Breaking change (fix or feature that would change existing functionality)

Checklist

[x] I have read the contributing guidelines
[x] My code follows the code style of the project (using npm run lint)
[ ] My change introduces changes to the documentation
[ ] I have updated the documentation accordingly
[ ] I have added tests to cover my changes
[ ] All new and existing tests passed

Live previews

https://deploy-preview-{your_pr_number}--twbs-bootstrap.netlify.app/

Related issues
https://github.com/twbs/bootstrap/issues/38617#issue-1715027674

https://github.com/twbs/bootstrap/issues/38617#issuecomment-1571299501


Adds initial set of storage Benchmarks

Initial integration and testing of the ordo-one/package-benchmark package to measure performance
Compare baselines with:
swift package benchmark baseline compare alpha

See documentation for Benchmarks

Looks that this is something we should deprioritize right now, considering the lack of support of Benchmarks for lower iOS versions


Missing CLI options for App Service logging ...

Within the Azure Portal, the options for setting App Service web server logging are:

However, when trying to configure App Service logging using the az webapp log config CLI the allowed options for web server logging are:
--web-server-logging {filesystem, off}
How do we set web server logging to "storage" via the CLI?
Also of note:

Configuring an App Service logging via the CLI is painful, see: this issue.

I would like to propose the CLI be upgraded to include the following additional options / switches:

--diagnostic-logs-retention-period-days
--http-logs-retention-period-days
--http-logs-retention-in-mb
--application-logs-retention-period-days
--storage-account-name
--storage-container-name

The options above are self-explanatory, basically options that exist in the Azure Portal, but are missing from the CLI.  Having the above options would make using the CLI so much easier !

Thanks in advance.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: bee2e287-5fb7-a849-9d3b-87013b783f16
Version Independent ID: 97f9e1c4-1573-b776-0fce-53c65839d713
Content: az webapp log
Content Source: latest/docs-ref-autogen/webapp/log.yml
Service: app-service-web
GitHub Login: @rloutlaw
Microsoft Alias: routlaw

route to CXP team

@bdcoder2 Thanks for reaching out to us and sharing the feedback. I am looking into this issue and I will update this thread once we have more details.

This is already being tracked by #10043

Are the follow options being also tracked?
The option for the retention is needed.

I would like to propose the CLI be upgraded to include the following additional options / switches:
--diagnostic-logs-retention-period-days
--http-logs-retention-period-days
--http-logs-retention-in-mb
--application-logs-retention-period-days
--storage-account-name
--storage-container-name
The options above are self-explanatory, basically options that exist in the Azure Portal, but are missing from the CLI. Having the above options would make using the CLI so much easier !


Filtering stops working

Describe the bug

Open a table
Open filters in that table
Filter with wrong data

e.g. id = "pandas" when id is int column

** Actual result **
The whole table view is unusable untill you remove all filters and filter again or reopen the table.
Expected behavior
To show error message and be able to just edit the filter instead of starting all over again.
Application (please complete the following information):

App client [MySQL]
Installation source: [dmg]

Environment (please complete the following information):

OS name: [e.g. Ubuntu]
DB name  [e.g. MariaDB]

Additional context
Very annoying bug :(

Cool @Fabio286 , but it's not only with int...
When using IN filter with comma separated values you get the same result.
IN (10,20,30) = broken table view
IN (''panda", "koala")  = broken table view
Those are the ones i remember of.

Tracked in #687


How to set parameters when train on Jacquard dataset

Hello ,
I want to train on jacquard datasets，I want wo know how to set parameters such as batches-per-epoch? Thanks~

python train_ggcnn.py --description training_on_jacquard --network ggcnn --batches-per-epoch [value] --dataset jacquard --dataset-path ./Jacquard --vis
Just set the [value] as you want

Hello, I want to know how to set the values of these parameters to reproduce the acc in the paper when training Jaquard data. The acc I have trained is only 0.84


XML to pd.DataFrame

I was working to re-train the existing model on more data I annotated myself and saved as different XML files corresponding to each image. But I got stuck in situation where I am not able to convert all XML files within a single loop to a single DataFrame and then directly to a single CSV file.
Can you please help me in it?

I have one approach to place:-
xmin = []
xmax = []
ymin = []
ymax = []
label = []
in such way that for every .xml file being loaded it do not get re-initialized so that we can keep track of values of each and every variable corresponding to all .xml files. And then at last to convert every variable as a column of DataFrame.
Should I go with it or is there any better approach?


React step 1

Closes #
{{short description}}
Changelog
New

{{new thing}}

Changed

{{change thing}}

Removed

{{removed thing}}

Looks like you combined steps 1 and 2 and did not submit step 1 separately. See https://www.carbondesignsystem.com/tutorial/react/step-1

Does that mean I need to do it again? I was having some issues which I later sorted out in Step 2 and didn't think submitting them together would matter too much. If so, I'll redo it!

@Charlotte8699 yes - step 1 and step 2 need to be submitted separately. Feel free to close this PR..


[question] How to deploy to cloud server

Hi, really NICE sample starter kit! I can run it locally just fine but can't seem to get the code to run when running on a cloud instance like Google App Engine or NodeChef. Do you have a set of instructions on what needs to be modified to get this to work when running on a cloud server?

This project can be successfully built and run using the front end hosting service 'surge.sh'


Update how default browser config values are assigned

This update will ensure that all browser config values have a their default values applied.
I also removed the withGTM prop as it was no longer referenced and config was also not passed through anywhere.

@solocommand  I updated the setting of thos values to use getAs object to ensure they are, at minimum and empty, object.


Bumped several Microsoft.AspNetCore.* NuGet packages from 3.1.5 to 3.1.9.

Versions of the following NuGet packages have been bumped from 3.1.5 to 3.1.9:

Authentication:

Microsoft.AspNetCore.Authentication.AzureAD.UI
Microsoft.AspNetCore.Authentication.OpenIdConnect
Microsoft.AspNetCore.Authentication.JwtBearer

Components:

Microsoft.AspNetCore.Components.Web

DataProtection:

Microsoft.AspNetCore.DataProtection.AzureKeyVault
Microsoft.AspNetCore.DataProtection.AzureStorage

Mvc:

Microsoft.AspNetCore.Mvc.NewtonsoftJson
Microsoft.AspNetCore.Mvc.Testing

SignalR:

Microsoft.AspNetCore.SignalR.Client
Microsoft.AspNetCore.SignalR.Protocols.NewtonsoftJson
Microsoft.AspNetCore.SignalR.Protocols.MessagePack

This contains the same changes that are also present in the following PRs:

#783
#773
#777
#784
#779
#778
#765


Provide Planner for ShiftedRead for Postgress connector

Part of https://github.com/quasar-analytics/quasar/issues/3265

Fixed by https://github.com/quasar-analytics/quasar/pull/2905


Build application as jar instead of war

Build the application as jar
Use spring-boot-actuator for metrics and API end point information
Use alpine slim jdk image to run the application

The build artifact has been changed to jar instead of war as is the norm in all microservices or REST based services.
Springboot version has been upgraded to 2.0.0.RELEASE.
Use embedded tomcat as it helps us to scale the service horizontally.
SpringBootServletInitializer is not necessary for a Springboot application.
ShaclexValidator will use this.getClass().getClassLoader().getResourceAsStream(schemaFileName) to read the validation file. Using getResourceAsStream is a more robust way of reading resource files.
Use alpine jdk docker image to run the application using docker and java -jar commands.


Add CVRPTW generator

Created this PR to drop PR #107

Closes https://github.com/dwavesystems/dwave-optimization/issues/104


[tempest] allow set of dns servers for tempest pod

As a pull request owner and reviewers, I checked that:

[x] Appropriate testing is done and actually running
[x] Appropriate documentation exists and/or is up-to-date:

[x] README in the role
[x] Content of the docs/source is reflecting the changes

/approve
Wondering if we may compute that IP (later) in order to ensure it's the right one. Probably at zuul job boostrap level though.


BUGS fixed when tried pipeline

Hi! Please review this PR to see if it makes sense. Many bugs found when I tried to run our workflow:

method/BayesSpace/BayesSpace.r and method/SpiceMix/SpiceMix.py: Their shell argument input are not the same as template method files, leading to smk crash. (for instance, SpiceMix doesn't provide --technology option before I change the script)

method/GraphST/GraphST_optargs.json, method/SpaceFlow/spaceflow_optargs.json: Both of their preprocessing workflows have PCA procedures, but downstream only use scaled data and I can't find anywhere for using PCA. (Question: can we provide scaled data as transform data?)

templates/method.py: Fixed a typo.

There're some more bugs that need to be discussed. I'll open issues.

method/scanpy/method_scanpy.py: Update output format so the column name will be "label"

method/SOTIP/method_sotip.py: commit to fix bugs in #208


don't update counter bar items when counter bar is disabled

Minor thing, the counters continue to update even after you disable them, as the gump isn't disposed when disabling (in order to keep the counter bar items intact). I cannot push to the main branch

@roxya FYI: I can't push to the main branch too because it's protected [unless forced]. It requires a review before the merge


feat: remove mobile desactivation

Questions
Answers

Description?
I am wondering why this module is disabled by default on mobile device. So I propose to make this module always enable by default, because the merchant is able to disable it on his BO. Moreover, we cannot update this configuration when a theme is installed, that's why I think it's better if the module is enabled on mobile by default what do you think about it ?

Type?
improvement / suggestion

BC breaks?
no

Deprecations?

Fixed ticket?

Sponsor company
@PrestaShopCorp

How to test?
You just need to install the module, put your browser in mobile mode, refresh the page and check if the module still shows in mobile.

@tblivet

because the merchant is able to disable it on his BO.

No more, this feature has been removed for v9.

Thx @Hlavtox I wasn't aware about that 👍 so it makes much more sens if we remove it !

Hi @tblivet
Thank you for your PR, I tested it and it works as you can see :
Untitled_ Oct 18, 2023 3_40 PM (1).webm
Thank you

PR in accordance with the evolution that PS will have. I'm merging.


[Bug]: UWP sample app crash on builder.Register() at RegisterNative at JobManager

Component
Core (Jobs, Settings, Initialization)
What platform(s) are effected?

[ ] iOS 12
[ ] iOS 13
[ ] iOS 14
[ ] Android 8
[ ] Android 9
[ ] Android 10
[ ] Android 11
[X] UWP

Steps To Reproduce

Download the source.
Build and run Samples.UWP

Expected Behavior
UWP main page shows
Actual Behavior
Get to the statement:
// TODO: this periodically crashes
builder.Register();
at RegisterNative at class JobManager and crash.
replace with:
try {
builder.Register();
}
catch (Exception Exception) {
Console.WriteLine(Exception.Message);
}
Exception or Log output
Exception.Message:
Class not registered (Exception from HRESULT: 0x80040154 (REGDB_E_CLASSNOTREG))

Exception.StackTrace:
at Windows.ApplicationModel.Background.BackgroundTaskBuilder.Register()
at Shiny.Jobs.JobManager.RegisterNative(JobInfo jobInfo) in H:\Xamarin_Samples\Shiny_LIbrary\shiny\src\Shiny.Core\Jobs\Platforms\Uwp\JobManager.cs:line 8
crash_log.txt
4
Code of Conduct

[X] I agree to follow this project's Code of Conduct

I'm closing this because the samples are setup for internal dev/debugging work and don't offer real world case, nor should issues be filed against samples.
Lastly, UWP is likely switching to a sponsor only model in the very near future.


First tests for macro.

https://github.com/exthereum/ethereumex/issues/25
Hey guys,
I have proposed the way how to test macro. Not sure If I properly understand problematic you are requiring. I have not used the Mox library, but created ad-hoc ClientMock in test which is using this macro. In this client I am mocking single_request method which is called from server (GenServer defined by macro) and testing if this client's single_reuqest method is receiving correct payload.
Could you please give me some feedback if I am on right way? If not give me some clue how to make it correctly? If yes I'll continue to cover all methods in macro.
Thanks a lot,
Zdenko

Hey @ayrat555,
I have done the tests for Macro module. I am new in Elixir world and little confused how I could use the Mox lib for testing this Macro module. I see Mox is mainly using for testing behaviour and Ethereumex.Client.Macro is not behaviour, but using behaviour and adding some additional logic which is tested also (real method names, default args,  ...).
Could you give me some example of using Mox for this Ethereumex.Client.Macor module?
The tests were in core basically same so I have created some helper test methods to keep it DRY.
Thanks a lot for feedback and your help,
Zdenko

@zdenal your request looks good to me. can you please check if there are new methods in ethereum's json-rpc api. if everything is up to date, I'll merge your pr.

@ayrat555 sorry my fault, I have checked it again by this references: https://github.com/ethereum/wiki/wiki/JSON-RPC#json-rpc-api-reference ... didn't find any new method there ... should be up to date.


Stop adding minor labels if minor phc update

We don't want to make the type of update dependent of phc anymore

Ah looks like we need to update the tests


STM32G0B1CBT6 external loader not working

Hello! I was trying to make the external loader for the STM32G0B1CBT6 that has a RAM of 144K. It generates ok, but the issue is that when i try to open in the cube programmer, it shows as unknown and with address 0000000 and no name. Any idea of what could be the issue?

An update. If i select, it shows the name in an other place. But it still not working.

@Guilherme-Mello It appears that the information in Dev_Inf.c is omitted from the loader. Check whether (1) the file name is correct, (2) the EL_linker.ld script is used, and (3) the linker option “Discard Unused Sections” is unchecked.

@Guilherme-Mello It appears that the information in Dev_Inf.c is omitted from the loader. Check whether (1) the file name is correct, (2) the EL_linker.ld script is used, and (3) the linker option “Discard Unused Sections” is unchecked.

I checked those things and seems to be all ok... but the problem still.

Maybe this does not work with G0 family this way... Well there is external loader for the G071 with an other Memory... maybe its built with some other technique ?


Adding basic namespace and logo for PayRue

Fixes # .
Changes proposed in this pull request:

@AbstractBreazy Sorry but we've changed the repository for the spaces can you make a PR here instead: https://github.com/bonustrack/snapshot-spaces ? Have a look here on the updated docs: https://docs.snapshot.page/guides/create-a-space I'm closing this PR for now feel free to reach our Discord for help.


ebpf: reducing ebpf call overhead by using sampling instead of tracing every calls

this reduces the bpf call overhead from 1352ns to 99ns
without this fix
# sysctl -w kernel.bpf_stats_enabled=1
# bpftool prog show |grep kepler_trace |awk '{print $(NF-2)/$NF}'
1352.07

with this fix
# sysctl -w kernel.bpf_stats_enabled=1
# bpftool prog show |grep kepler_trace |awk '{print $(NF-2)/$NF}'
99.0167

[x] make bcc work
[x] make libbpf able to set sampling rate by calling InitilizeGlobalVar

depend on #824

kepler command
BPF_SAMPLE_RATE=1000 _output/bin/linux_amd64/kepler

ebpf calculation
bpftool prog show |grep kepler_trace |awk '{print $(NF-2)/$NF}'

result

sample frequency
per call time (ns)

0
1239

1
797

10
300

50
152

100
129

1000
93

Thanks for sharing it. This is great!

@rootfs, for now, let's set the default value to 10 since we're uncertain about the consequences of skipping samples. Moreover, using 10 seems to bring significant improvements. Once we conduct further analysis, we can increasing this value.

@marceloamaral sure, let default to 10. One more question, when we sample the ebpf calls, should we also extrapolate the metrics (cpu time, cpu instructions, etc) as well?

Just created a discussion
https://github.com/sustainable-computing-io/kepler/discussions/836

@eklee15 @marceloamaral @sunya-ch Let's disable sampling for now until we have a resolution on #836

the rebase was not successful, will reopen another PR


UI bug fix

fixed weird underflow of module title by setting minimum size to titles

Codecov Report
Base: 62.83% // Head: 62.03% // Decreases project coverage by -0.80% :warning:

Coverage data is based on head (3fa4900) compared to base (8977594).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #154      +/-   ##
============================================
- Coverage     62.83%   62.03%   -0.81%
+ Complexity      557      537      -20
============================================
  Files           103       98       -5
  Lines          1959     1907      -52
  Branches        230      219      -11
============================================
- Hits           1231     1183      -48
+ Misses          646      640       -6
- Partials         82       84       +2

Impacted Files
Coverage Δ

...odel/person/TelegramContainsKeywordsPredicate.java
0.00% <0.00%> (-71.43%)
:arrow_down:

...java/seedu/address/logic/commands/ListCommand.java
77.77% <0.00%> (-22.23%)
:arrow_down:

...eedu/address/logic/commands/FindModuleCommand.java
100.00% <0.00%> (ø)

...eedu/address/logic/commands/FindPersonCommand.java
100.00% <0.00%> (ø)

...s/model/person/EmailContainsKeywordsPredicate.java

...s/model/person/PhoneContainsKeywordsPredicate.java

...el/module/ModuleCodeContainsKeywordsPredicate.java

...son/PersonModuleCodeContainsKeywordsPredicate.java

...ss/model/person/NameContainsKeywordsPredicate.java

...odule/LectureDetailsContainsKeywordsPredicate.java

... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


pretty-format: Support HTMLCollection and NodeList in DOMCollection plugin

Summary
Fixes #7121
Problem: When pretty-format serializes a jsdom object instance for which no plugin matches, it takes a “stupid amount of time” on the property with key Symbol(impl) and then fails.
Solution: Support HTML collection classes to write assertions for received values:

element properties childNodes, children, elements, options
getElementsByTagName and so on
querySelectorAll

Also added support for config.min option to omit class name.
Be aware that class names can be moving targets even in browsers:

form.elements returned HTMLFormControlsCollection
fieldset.elements returned HTMLCollection

despite the claim at Mozilla Developer Network

The HTMLFormControlsCollection interface represents a collection of HTML form control elements. It represents the lists returned by the HTMLFormElement interface's elements property and the HTMLFieldSetElement interface's elements property.

So there is some risk for test writers that snapshots might need to be updated at major version upgrades of jsdom package.
Test plan

added 8 tests for collection classes
added 1 test for config.min option
added 1 test for config.maxDepth option

Codecov Report

Merging #7125 into master will not change coverage.
The diff coverage is 88.88%.

@@          Coverage Diff           @@
##           master   #7125   +/-   ##
======================================
  Coverage    66.6%   66.6%
======================================
  Files         253     253
  Lines       10629   10629
  Branches        3       4    +1
======================================
  Hits         7079    7079
  Misses       3549    3549
  Partials        1       1

Impacted Files
Coverage Δ

...ckages/pretty-format/src/plugins/dom_collection.js
93.33% <88.88%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4646b9...69dc91f. Read the comment docs.

Documenting decision to serialize in list item format:

con: comma after item of markup looks awkward
pro: minimize change to snapshot if class names change in future jsdom versions
pro: minimize change to snapshot if received value changes to or from Array.from idiom


User Create Certificates will not work on newer version of Android

On newer versions of Android (7+) apps will not trust/use user certs by default. This stops us from using Charles Proxy on our UAT builds to check api calls.
The work around is to add a network security config file to the app bundle.
<?xml version="1.0" encoding="utf-8"?>
<network-security-config>
    <debug-overrides>
        <trust-anchors>
            <!-- Trust user added CAs while debuggable only -->
            <certificates src="user" />
        </trust-anchors>
    </debug-overrides>
</network-security-config>

AndroidManifest.xml:
 <Application
 	android:networkSecurityConfig="@xml/network_security_config">

This should be added to flagship for all builds that are not store.

Fixed by: https://github.com/brandingbrand/flagship/pull/788/files#diff-672833081bf52cbb6dd0751f78869342R226


fix broken links

fix some broken links which also fixes part of issue #1260
there are still some broken links and content need updating but i couldn't find other available links to replace yet ...

This change is

Thanks for the fix!


Adding Important keywords to readme.md of shellshock

Is your feature request related to a problem? Please describe.
No I it an addon to the readme file to make it more understandable to the reader.
Describe the solution you'd like
I would like to add explanation and full forms of some important keywords used while explaining the topic mentioned in readme.
Please consider this issue
I would like to work on this further.

Thank you for showing your interest. But the readme looks fine already. Could you consider simulating the attack? I've added resources in the issue as well.

@SANTHOSH17-DOT Yes I can do that. Assign me the shellshock issue and I'll get back with a Pr of simulation

I'm closing this isse


vEthernet (WSL) is not created after the on-logon job execution

I use static setup + on-logon scheduled task, which after reboot successfully completes (sometimes even calling out that WSL vSwitch had been already configured correctly) but no vEthernet (WSL) is seen via ipconfig. Then I start my WSL session and get default settings for vEthernet (something like 172.21.22... instead of static address I provided), so the WSL is set up with the address obviously not from required subnet and network is not working as expected.
The workaround I found it to delay scheduled task execution for 1 minute after logon.

Thanks for reporting this observation.
It is difficult to guess what might be the exact reason for this behavior, but the thing is that if the module reports success - this means the adapter has been set up - because it's presence and actual parameters are validated after the the module tries to set it up.
The only thing I can think of is that adapter is being setup by mangling with Windows internals and I noticed that high level commands like ipconfig do NOT reflect the changes straight away and this delay depends on how busy the system is doing whatever it is doing or whatever the user has tasked it to do at the moment when the adapter was setup. I.e. the system needs some time to sync the changes in virtual devices state with it's internal representation of that state.
The delay you had set might be letting the module to run when the system is less busy and therefore the changes are reflected quicker (which might feel like immediately).
To validate this hypotheses you might try (without setting the delay manually) let the script do its job, and run ipconfig after some time (whatever time you found suitable for the delay).
If the hypotheses holds true I might add an option to have the delay for the scheduled task script (i.e. with -RunOnlyIfIdle and -IdleWaitTimeout parameters).


Enumerations and CamelCase

I happened to notice a behavior with prost code generator, that doesn't convert enum items correctly. It seems to make the assumption the items are snake_case, converting them to CamelCase. In our case, the enum values are already in CamelCase, but then they are converted into broken Camelcase, which is hard to read and now when converting our projects from rust-protobuf to prost, breaks lots of things.
What is the expected behavior? Always having proto enums in snake_case and then in Rust CamelCase? Allowing CamelCase in proto and converting it to Camelcase in Rust or detecting if proto has already CamelCase and converting it correctly to CamelCase in Rust?

Basically this works in our case, and didn't seem to break any tests:
https://github.com/pimeys/prost/commit/9d2233e70e7c70184734790e1d2cc667ab5e805c

Thanks for the report, @pimeys!  The Protobuf style guide does recommend using shouty snake case, but clearly prost shouldn't fail like this with Rust-styled variants. I think the way I want to handle this is by improving the ident conversion code, instead of doing recognition via regex.  Towards that end, I posted #15.  Would you mind testing out that PR and making sure it fixes your issue?

I'm all in with not using regex. It was just a quick test to see how far I can get my refactoring to not use rust-protobuf in one of our projects.
I'll give this a spin tomorrow when I get to the office.

This is fixed by c1902708e99e1ba0a1aae00401e32d7f6902869e.


Change how silk touch enchantment works

If Sponge is going to work with Forge mods, it will need to allow for a location/player sensitive way of testing whether a block can be harvested with silk touch.
As @diesieben07 said in #minecraftforge, a mod may only allow a block to be harvested if the player has been playing for a certain amount of time, or it may depend on what tile entity data the block has etc.
This PR changes the API to be more like vanilla where the method is on the block, not the enchantment. BlockLoc is a more appropriate place than BlockType in this case.

This will then be inconsistent with the representation of other enchantments. While I believe this may be correct, shouldn't plugins themselves then be allowed to change this behavior? AFAIK that would be done with some sort of event. This brings up the issue of where mods are on the event chain. Are they combined with vanilla's callback?

@SpongePowered/developers comments?

I was told to do it the way it is currently done for a few reasons. I had originally done it like this PR, and I was told to change it.

@me4502 Yeah I originally suggested it. It is fine for vanilla behaviour but to be compatible with forge mods, it cannot be a simple registry of silk touch-able blocks.

I believe Zidane also told me to do it that way as well.

I would rather mods to have a chance to be ahead of the event chain with regards to silk touch overriding, mostly because I believe plugins should have the final say overall.

This needs to be changed to an event based model, because this is really a specific case of a HarvestEvent. Make another PR for that if you want.
See forge event for inspiration/copying https://github.com/MinecraftForge/MinecraftForge/blob/master/src/main/java/net/minecraftforge/event/world/BlockEvent.java#L45


Cleanup

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@sashamelentyev
Did you read:

This pinned issue? https://github.com/gohugoio/hugo/issues/10366

any bigger code contributions will currently most likely not be merged (or it would have to wait), so we suggest you ask in the relevant issue before spending time implementing it

CONTRIBUTING.md

we currently require any new Pull Requests to be limited to bug fixes closing an existing issue

Git Commit Message Guidelines

Most title/subjects should have a lower-cased prefix with a colon and one whitespace. The prefix can be...

@jmooring I can split MR


Support referer policy in tag helpers and @Html.Link

See
https://html.spec.whatwg.org/multipage/infrastructure.html#referrer-policy-attribute
https://notes.bughunters.club/referrer-policy-168bf3328ecd#.gu0vshwkj

Is this just a regular HTML attribute? If so, there's nothing to add in MVC's tag helpers or HTML helpers. You can always add whatever arbitrary HTML attributes you want.

I read about it a bit more and yeah this is just a plain old HTML element attribute / HTTP header / whatever, so there's nothing stopping anyone from using it. We only need to add specific logic to MVC helpers when there needs to be some "server logic" behind it (e.g. resolving a URL, showing model state values, validation, etc.).


Added environment variable feature close #6

Added feature for setting environment variables.
environment variables need to be in this format.
ENV_VAR_A=123 ENV_VAR_B=Hello

There's something wrong. Its now showing again when i save it. I will fix first before opening again.

thanks