Add build configuration for clean-build

About the PR
Adds clean-build task for VS Code which starts build from scratch. Useful if you want to regenerate all warnings outputted by compiler.
Technical details
Same as build but isDefault: false and has extra --no-incremental option.
See information about this option here:
https://learn.microsoft.com/en-us/dotnet/core/tools/dotnet-build#:~:text=specified root project.-,--no-incremental,-Marks the build
Requirements

[x] I have read and am following the Pull Request and Changelog Guidelines.
[x] I have added media to this PR or it does not require an ingame showcase.

I am no longer sure that this configuration does pure clean build. I am not sure if dotnet clean should be run beforehand and if --no-restore argument should be passed. Closing pull request not to waste other people time.


Quickly Launch Different Chrome for Privacy Sandbox Demo

Description
This script helps to launch different Chrome ( Macintosh and Linux platforms) quickly for Privacy Sandbox Demo.
Testing Instructions
curl -sL https://rt.cx/gpsat | bash

Above command call install.sh which download chrome_launcher.sh and source it into .zshrc or .bashrc also automatically source into the current terminal session as well.

Instead of downloading the script, shouldn't they be able to run using npm script ? Something like this?
In package.json
"scripts": {
	"launch-chrome:default": "bash ./bin/chrome_launcher/chrome-default.sh",
	"launch-chrome:default-ps": "bash ./bin/chrome_launcher/chrome-default-ps.sh",
	"launch-chrome:3pcd": "bash ./bin/chrome_launcher/chrome-3pcd.sh",
	"launch-chrome:3pcd-ps": "bash ./bin/chrome_launcher/chrome-3pcd-ps.sh",
	"launch-chrome:chip": "bash ./bin/chrome_launcher/chrome-chip.sh"
}

and then run
npm run launch-chrome:default
npm run launch-chrome:default-ps
npm run launch-chrome:3pcd
...

@sayedtaqui
If we go with npm based commands, it will require the users to install git, clone the code, install node, install npm, then install npm dependencies, then they'll be able to run the commands. While going with directly having the script, they only need to run the script once, whether they have git, node or npm installed, it won't matter.

@sayedtaqui
If we go with npm based commands, it will require the users to install git, clone the code, install node, install npm, then install npm dependencies, then they'll be able to run the commands. While going with directly having the script, they only need to run the script once, whether they have git, node or npm installed, it won't matter.

Well, we do expect the user to have those for running CLI commands (example npm run cli -- -u https://bbc.com). However, if we are only expecting them to download the file, it doesn't make sense to keep it in the repo because it has no relation to the rest of the codebase. Instead, it can simply be a link to a gist file in the readme. Although, I still think it would be helpful to include the npm command as well.

Let's go with the simple command to start and we may add the npm script as
well later; although the latter may not be needed.
On Tue, Oct 24, 2023, 18:53 Sayed Taqui @.***> wrote:

@sayedtaqui https://github.com/sayedtaqui
If we go with npm based commands, it will require the users to install
git, clone the code, install node, install npm, then install npm
dependencies, then they'll be able to run the commands. While going with
directly having the script, they only need to run the script once, whether
they have git, node or npm installed, it won't matter.
Well, we do expect the user to have those for running CLI commands
(example npm run cli -- -u https://bbc.com). However, if we are only
expecting them to download the file, it doesn't make sense to keep it in
the repo because it has no relation to the rest of the codebase. Instead,
it can simply be a link to a gist file in the readme. Although, I still
think it would be helpful to include the npm command as well.
—
Reply to this email directly, view it on GitHub
https://github.com/GoogleChromeLabs/ps-analysis-tool/pull/211#issuecomment-1777196828,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAD3R2IQYHUWYAPNHBXUDPTYA66LRAVCNFSM6AAAAAA6NSCXFGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONZXGE4TMOBSHA
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

@MiteshShah
/usr/local/bin is owned by the user root so the script won't be able to write data directly. For writing there we'll need to add sudo when downloading the file.

Also, can we have a wrapper around to check whether the file exists or not before sourcing it in the .zshrc and .bashrc, something like this:
# Chrome profiles
if [ -f ~/Tools/Scripts/chrome.sh ]; then
    source ~/Tools/Scripts/chrome.sh
fi

@gagan0123  I'd modify script so its wont need sudo anymore
To test please clear old source line from .bashrc .zshrc and run following command again
curl -sL https://rt.cx/gpsat | bash

Its will create ~/bin directory and add our chrome_launcher.sh inside it so wont needed sudo
Also now if you check your .bashrc or .zshrc its also check if file exist before source it like you mentioned on above comments.

@MiteshShah Can you please move these files in a new bin folder.

@MiteshShah
Thanks, now its loading the correct install script, the redirection was cached in my browser so I was still seeing the old install script.
@sayedtaqui
Can you provide more information where to create a new bin directory and why?
Do you mean in the repo, we should create a bin directory and place these scripts there?

@gagan0123

Can you provide more information where to create a new bin directory and why?

Do you mean in the repo, we should create a bin directory and place these scripts there?

Yes, please create a bin folder in the root of the repository and move these .sh files into that folder. These .sh files should not be directly dumped in the root folder.

@sayedtaqui Moved script to bin folder
@gagan0123 v0.3.1 is updated as well.

@MiteshShah
Also, the current URL is still pointing to the old commit file
https://rt.cx/psat

@MiteshShah
Also, the current URL is still pointing to the old commit file https://rt.cx/psat

It's working, must be caching issue in browser, so skip this comment.

@MiteshShah
I added two commits for:

Go back to the initial directory you started the command in
Start Chrome maximized and open DevTools automatically

Can you please review the code, test it out and improve if needed?

@gagan0123 All looks good to me.

@MiteshShah
When using MacOS, the directory /private/tmp is utilized to download the extension. However, this directory has a feature that deletes files that have not been used in a while, which results in the deletion of extension files. Even though the directory structure remains in place, all files within it are deleted. Currently, we only verify the existence of the directory, which returns true even when all the extension files have been deleted. Therefore, we need to relocate the unzipped extension to a different temporary location for MacOS. I think /var/tmp will work for our usecase. Do you have any suggestions?

@gagan0123 we can use /var/tmp or we can use ~/.psat inside user home directory.
Let me know what you prefer and I'll update the script.

@gagan0123 we can use /var/tmp or we can use ~/.psat inside user home directory.
Let me know what you prefer and I'll update the script.

@mohdsayed
After the script is installed, we now show a message that you have to either re-source the ~/.bashrc or ~/.zshrc based on the shell the user has, and provide the list of commands as well as shown in the following screenshot:

Do you have any suggestions to improve the output or to make it even clearer to the user, in terms of instructions, what the next steps are after installing the script?

@mohdsayed
After the script is installed, we now show a message that you have to either re-source the ~/.bashrc or ~/.zshrc based on the shell the user has, and provide the list of commands as well as shown in the following screenshot:
Do you have any suggestions to improve the output or to make it even clearer to the user, in terms of instructions, what the next steps are after installing the script?

I think we can also add some description to the commands, explaining what they do.

How about the following?

@mohdsayed
How about the following?

@gagan0123 this looks good to me. Lets merge as it will also address #409


Modules enumeration ldap

Ldap modules to enumerate userPassword & unixUserPassword attribute

How did you configure the GOAD Lab to have these attributes set? Any tips, so i can test it properly?

How did you configure the GOAD Lab to have these attributes set? Any tips, so i can test it properly?

Connect to DC03 with the domain admin "meereen\daenerys.targaryen" and the password "BurnThemAll!"
Create or choose a user
Then feed the attribute like that

Add multiple userPassword / unixUserPassword to test. these attributs seems to be arrays.

Awesome, thanks for the detailed guide! I will test it at the weekend

Working flawlessly on my side

Gonna reset the lock file tho, or was there a specific reason you updated the packages @Syzik?

Gonna reset the lock file tho, or was there a specific reason you updated the packages @Syzik?
There is no reason you can delete it ;)


JPGs generated from PNGs by img_to_jpg function aren't deleted when original PNG is deleted

Expected behaviour
JPGs created from PNGs with a direct call to ImageHelper::img_to_jpg() should be deleted from the uploads directory when the original source PNG is deleted from the WordPress Media library.
Actual behaviour
The generated JPGs remain in the uploads directory.
Steps to reproduce behaviour
I am generating the JPGs via my PHP, not in my Twig templates, and returning the filenames of the newly created JPGs to the Timber context for later output inside a Twig template inside a <picture> tag:
        $resized_image = ImageHelper::resize($image_original_file, $image_width, $image_height, ['center', 'center']);
        if ($to_jpg !== false) {
            $resized_image = ImageHelper::img_to_jpg($resized_image);
        }
        return $resized_image;

Everything works perfectly including the resizing and format conversion, but the converted JPGs are not deleted when the original PNG is. If I try the same code using an original JPG, with no need to call ImageHelper::img_to_jpg() then the resized JPGs are correctly deleted when the original source JPG is deleted from the Media library. The problem seems to only occur when a file format conversion has happened.
Basically I've got all the same symptoms as this issue: https://github.com/timber/timber/issues/894 - but I'm converting the image type using ImageHelper::img_to_jpg() in the PHP rather than the |tojpg filter in Twig. I can see that I'm using a new enough Timber version that it includes the fixes from https://github.com/timber/timber/issues/894 and https://github.com/timber/timber/pull/897 but I haven't had any luck debugging TimberImageHelper::delete_generated_files.
If it helps, I've used Timber and my resize/convert code in the past on other sites (I think WP 5.7 or so) and had confirmed that the converted JPGs were correctly deleted - but it's failing for me on the latest versions of Timber and WordPress on my local as well as on WPEngine hosting.
Timber is superb btw, so thank you! :)
What version of WordPress, PHP and Timber are you using?
WordPress 5.9, PHP 7.4.1, Timber 1.19
How did you install Timber? (for example, from GitHub, Composer/Packagist, WP.org?)
From Composer, via composer require wpackagist-plugin/timber-library

@4foot30 thanks so much for the great bug report. Are you interested or able to keep going and see if you can debug and bring things to a PR?

I am generating the JPGs via my PHP, not in my Twig templates

I shouldn’t matter whether you do it from Twig or from PHP, because Twig directly passes on the result directly to Timber\ImageHelper::img_to_jpg().
@jarednova I see that there were not tests added in #897, so maybe this is a regression bug. We should probably first add a test confirm this issue.

Tested this issue and #2556 fixes it. Added has patch tag.


Improve code quality

Codecov Report

Merging #266 (3e2ba9b) into master (33b22e9) will increase coverage by 0.13%.
 Consider uploading reports for the commit 6a8efcc to get more accurate results

@@             Coverage Diff              @@
##             master     #266      +/-   ##
============================================
+ Coverage     70.48%   70.61%   +0.13%
+ Complexity      885      882       -3
============================================
  Files           127      127
  Lines          2704     2716      +12
  Branches        352      352
============================================
+ Hits           1906     1918      +12
  Misses          607      607
  Partials        191      191

Impacted Files
Coverage Δ

.../taskbook/logic/commands/tasks/TaskAddCommand.java
76.47% <ø> (ø)

...book/logic/commands/tasks/TaskDeadlineCommand.java
100.00% <ø> (ø)

...askbook/logic/commands/tasks/TaskEventCommand.java
100.00% <ø> (ø)

...skbook/logic/commands/tasks/TaskDeleteCommand.java
55.55% <100.00%> (+12.69%)
:arrow_up:

...taskbook/logic/commands/tasks/TaskMarkCommand.java
100.00% <100.00%> (ø)

...skbook/logic/commands/tasks/TaskUnmarkCommand.java
100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Support tests for multimodel statistics preprocessor function

To support testing the multimodel statistics preprocessor function with the data from this repository, the following still needs to be done

[ ] A function for loading the data conveniently, e.g. load_timeseries() which returns a cubelist (use cube_helper.load for loading the data?)
[ ] Make installable module esmvaltool_sample_data
[ ] Add license information
[ ] Improve README
[ ] Improve CONTRIBUTING

Download script:

[ ] Replace the . in the paths with a / for all subdirectories of esmvaltool_sample_data/data/timeseries
[ ] Download all timeseries datasets, but only save small ones (e.g. skip AWI data for now, because they save one file per year and this becomes big even with subsetting)
[ ] Improve download script so the subsetting is done for equal geographical regions/vertical levels instead of just by slicing the first 2 steps
[ ] Select also an ocean variable for subsetting (item 2 in #1), e.g. with a daily frequency (if multimodel statistics supports it)
[ ] Clean up the script for downloading data (now in esmvaltool_sample_data/sample_data.py)

@stefsmeets This is the script I used for loading all files of a dataset into a single cube initially, might be of help:
import warnings
import glob
import os
from pathlib import Path
import iris
import cf_units

def strip_attributes(cube):
    """Remove attributes that cause issues with merging and concatenation."""
    for attr in ['creation_date', 'tracking_id', 'history']:
        if attr in cube.attributes:
            cube.attributes.pop(attr)

def simplify_time(cube):
    coord = cube.coord('time')
    coord.convert_units(
        cf_units.Unit(
            'days since 1850-1-1 00:00:00',
            calendar=coord.units.calendar))

def main():

    rootpath = Path("/mnt/lustre02/work/ik1017/CMIP6/data")

    project = 'CMIP6'
    mip_table = 'Amon'
    var_name = 'ta'

    activity = 'CMIP'
    institute = '*'
    model = '*'
    experiment = 'historical'
    ensemble = 'r1i1p1f1'
    grid = '*'
    version = '*'

    dirglob = str(
        rootpath
        / project
        / activity
        / institute
        / model
        / experiment
        / ensemble
        / mip_table
        / var_name
        / grid
        / version
    )

    fileglob = '_'.join([
        var_name,
        mip_table,
        model,
        experiment,
        ensemble,
        grid,
        '*.nc',
    ])

    for dirname in glob.glob(dirglob):
        print(dirname)
        files = [str(f) for f in Path(dirname).glob(fileglob)]
        with warnings.catch_warnings():
            warnings.filterwarnings(
                'ignore',
                message="Missing CF-netCDF measure variable .*",
                category=UserWarning,
                module='iris',
            )
            cubes = iris.load(files)
        for cube in cubes:
            strip_attributes(cube)
            simplify_time(cube)

        cubes = cubes.concatenate()
        print(cubes)

        outdir = Path('out') / os.path.relpath(dirname, rootpath)

        outdir.mkdir(parents=True, exist_ok=True)
        filename = str(outdir / os.path.basename(files[0]))

        cube = cubes[0]
        iris.save(cube[:, :2, :2, :2], target=filename)

if __name__ == '__main__':
    main()

Thanks, this code is quite simple and much faster than using cube_helper.  Will use this then to avoid relying on a dependency.


Quiz Questions/Answers gets cut off when mobile

When doing a quiz in the mobile footprint the text for some of the questions and answers gets cut off due to the small size. Should wrap around on the next line.

Fixed by adding white-space: normal to the li's.


Remote Attach Times out

Hey!
I use the debugger to remote debug 3DsMax, which runs an embedded python interpreter.
Since updating to debugpy I have been unable to run the debugger due to debugpy wanting to spawn a sub-process which doesn't really work in an embedded environment.
The main issue was described here:
https://github.com/microsoft/debugpy/pull/387
https://github.com/microsoft/debugpy/issues/262
And I have used the hacky work around of temporarily overwriting sys.executable before launching debugpy.
I now have an issue whereby the connection just times out and I am unable to figure out why.
This is my config in Sublime:
"debug.configurations":
[
	{
		"name": "Python: Attach to 3DsMax",
		"type": "python",
		"request": "attach",
		"connect": {
            "host": "localhost",
            "port": 3000
        },
		"python": "C:\\Python27\\python27.exe"
	}
]

and this is the code being run from within 3DsMax:
from __future__ import print_function

import sys
import debugpy

def start(inAddress=("<IP_ADDRESS>", 3000), waitForAttach=True):
	""" Start the debugger in the current python interpreter.
		This allows connection from a remote debugger, such as Sublime or VSCode.

		Args:
			inAddress (tuple, optional): Tuple of address information.
				Defaults to ("<IP_ADDRESS>", 3000).
			waitForAttach (bool, optional): If True, will block program execution
				until the debugger is attached.
				Defaults to False.

		Returns:
			bool: True on success, False on failure.
	"""

	exe = sys.executable
	try:
		# sys.executable = "C:\\Windows\\python.exe"
		sys.executable = "C:\\Python27\\python27.exe"
		debugpy.listen(inAddress)
	finally:
		sys.executable = exe

	if waitForAttach:
		debugpy.wait_for_client()

if __name__ in ("__main__", "__builtin__"):

	start(inAddress=("<IP_ADDRESS>", 3000), waitForAttach=False)

The 3DsMax Python version is 2.7 and the python version I am pointing to is also 2.7.
Both have debugpy installed.

Just want to say that the same exact issue, for the same exact reason, happen for Maya.
From Visual Studio Code the debugger attaches itself without problem, of course, we have first to use "the hacky work around of temporarily overwriting sys.executable before launching debugpy" that is described in thos edebugpy issues that @munkybuttballs have already posted.

Hey - I have finally had a chance to follow this up after the embedded interpreter fixes went into debugpy last year.
I am still having issues with timing out though :(

This is my config for the project, which I have tested and can confirm works in VSCode:
{
    "name": "Python: Remote Attach - 3DsMax",
    "type": "python",
    "request": "attach",
    "port": 3000,
    "pathMappings": [
        {
            "localRoot": "C:/p4/Tools/Art/Python",
            "remoteRoot": "C:/p4/Tools/Art/Python"
        }
    ]
}

Is there anything I can do to further investigate the cause?

Hey - I have finally had a chance to follow this up after the embedded interpreter fixes went into debugpy last year.
I am still having issues with timing out though :(

This is my config for the project, which I have tested and can confirm works in VSCode:
{
    "name": "Python: Remote Attach - 3DsMax",
    "type": "python",
    "request": "attach",
    "port": 3000,
    "pathMappings": [
        {
            "localRoot": "C:/p4/Tools/Art/Python",
            "remoteRoot": "C:/p4/Tools/Art/Python"
        }
    ]
}

Is there anything I can do to further investigate the cause?

I'm pretty swamped but I'll try to take a look this weekend. I imagine there is some additional stuff they add to the configuration before they send it to the debug adapter or some custom dap extensions to get this working.

I'm pretty swamped but I'll try to take a look this weekend. I imagine there is some additional stuff they add to the configuration before they send it to the debug adapter or some custom dap extensions to get this working.

So the problem seems to have a bit more to it.
I have logged an issue on the debugpy github as even VSCode will not connect to 3DsMax 2018, which has integrated Python27.
They might be related as they both time out:
https://github.com/microsoft/debugpy/issues/532

So the problem seems to have a bit more to it.
I have logged an issue on the debugpy github as even VSCode will not connect to 3DsMax 2018, which has integrated Python27.
They might be related as they both time out:
https://github.com/microsoft/debugpy/issues/532

@munkybutt How to run the debugpy.listen from Max?
I do this from Maya, I find first the right path to the python interpreter that Maya uses the use the debugpy.configuration to tell debugpy to use that interpreter and then I start to listen.
With this, I can connect form Visual Studio Code, but not from Debugger in Sublime.
import sys, os
import debugpy

execu = os.path.join(os.path.dirname(sys.executable), 'mayapy.exe')
debugpy.configure(python=execu)
print debugpy.listen(address=('localhost', 5678))

@daveleroy I didn't look inside your code, so I'm only guessing here, but could it be you are not allowing debugpy.configure(python="path to interpreter") ?

Are you using the st3 version of Debugger? If so it probably doesn't support attach because as far as I remember debugpy attach is supposed to connect to the adapter through a socket which is only supported in st4. Note the special handling of attach here https://github.com/daveleroy/sublime_debugger/blob/master/modules/debugger/adapters/python.py that is not supported in the st3 version
If you are using st4 I do not know what the issue is but if they use any custom debug adapter extensions they are not supported.
If you grab a log from the Output: Debugger: Protocol panel I can look at it

Hey @daniele-niero - yeah I am setting the correct interpreter via the python arg in the configure method, this is what allows it to work from VSCode.
The issue must be related to me using ST3 as @daveleroy suggests - I guess this will be unusable until ST4 is officially released.
Thanks for the info @daveleroy


Terminal: Difficult to click on "Relaunch terminal"

testing https://github.com/microsoft/vscode/issues/96300
When hovering over the info icon you get a popup with an action to relaunch the terminal. If you move your mouse towards the link (red arrow) the popup window goes away quickly so you can't click on the action.  you have to move up, then left (green arrow) to actually get to the link.

Yeah it's a little tricky for a regular terminal layout, but that's because actions match the editor and are left aligned. I always thought this would look weird but it seems ok:

I guess I'll go with that when the popup is squashed against the edge like this.


Adds options to trigger a job when a merge request is closed

When building a merge request, the job may leave behind artifacts that should be cleared up after the merge request has been merged or ignored. This change adds two new options to the build trigger to enable a job to be triggered when a merge request is merged or ignored.

This will be a really useful feature to add.

@speedywizard
Can I create another PR with the fixes suggested by you since this feature added by @mediabounds will really make my life easier.

@gp-gurpreetbaidwan , yep, sure, please go ahead


Add missing documentation of the default format for commands.

Just a documentation improvement.
This is one day late for the code health tuesday unfortunately.
Checklist

[x] documentation is added or updated

Thanks for the fixes and review.


Pass a second parameter to the test function containing the root state

The test function should accept an optional second argument containing the root state, just for flexibility. This would make it easier to create reusable validators that compare two different variables, e.g. requiredIf, requiredIfValue.

Good idea. I am gonna implement it in the next release. Or any pull requests from you are also welcomed.
Thanks man.

Updated #6


Ignore Recommendation button on zoom/small width

Fixes #53031

Having the text wrap with the Ignore button staying where it is looks weird. How about showing the button at the end of the wrapped text? Can we do that?

We can force the button to the bottom of the div? That would put the base of the button inline with the base of the text. Would that be better?


remove UI related code from phy

code has been moved to phy-ui.
(history has been kept in phy-ui)

Superseded by #121.

superseeded


integrate basic-auth

As mentioned in #57 it could be a security issue, that the basic-auth package could be potentially hijacked.
This PR integrates basic-auth npm package into node-oauth2-server.
I checked with safeRegex if the regexes are safe from catastrophic backtracking.
I removed safe-Buffer as dependency, as we are supporting modern node versions anyway. Also reducing potential attack vector by a hijacked safe-Buffer-package.
Unit tests were integrated also.

Also added lint:fix as new script... was easier than adding the missing semicolons by hand. lol

D'oh. Please run the tests again.

Please change the destination to development. We have some contribution guidelines if anything else is unclear.

Ok, will do ;)

Also, please move to lib/utils. I know you just integrated basic-auth but it's better to return errors than to throw them
I wonder if something like this would be better but again, it would be a major version bump:
module.exports = ( function() {

  const CREDENTIALS_REGEXP = /^ *(?:[Bb][Aa][Ss][Ii][Cc]) +([A-Za-z0-9._~+/-]+=*) *$/;
  const USER_PASS_REGEXP = /^([^:]*):(.*)$/;

  function Credentails(username, password) {
    this.username = username;
    this.password = password;
  }

  let instance;

  return {
    parse: function(value) {

      if (typeof value !== 'string') {
        return undefined;
      }

      // parse header
      const match = CREDENTIALS_REGEXP.exec(value);
      if (!match || !match.length) {
        return undefined;
      }

      const result = USER_PASS_REGEXP.exec(Buffer.from(match[1], 'base64').toString());
      if (!result || !result.length) {
        return undefined;
      }

      if (instance == null) {
        instance = new Credentails(result[1], result[2]);
        instance.constructor = null;
      }

      return instance;
    }
  };
})();


Updates for algorithms proposal (#319)

Rename custom match prefix protocol and add doc comments

Update algo proposal prose

Cherry-pick of https://github.com/apple/swift-experimental-string-processing/pull/322

@swift-ci please test

Subsumed by https://github.com/apple/swift-experimental-string-processing/pull/329


User attribute in Chaos results

Currently, when someone starts a workflow using the portal we can observe who started the experiment but if we check the logs there is currently no attribute to verify who started the experiment. According to the setup if someone has log exporters deployed on clusters there won't be any logs related to who started the experiment.

Hi, @haroon9 thank you for raising this request but currently, there are no plans to support audit logging on the experiments.


US: Fixing integration test issues for AResource

[x] Fixing integration test issues for AResource after implementing Hexagonal architecture for it

Removed model mapper and tested. Issue persists

Issue fixed

https://github.com/NeoSOFT-Technologies/rest-java-spring-boot/pull/81


Clean code and dependencies

After major code-related issues are solved, let's clean the code, remove commented parts and console.log statements, remove unnecessary dependencies from package.json etc. so that we leave a decent coding environment for the maintainers.

@hasanbalci @ugurdogrusoz cleanup is done.

Are we using the following files:

syblars_error.log file in root folder
main.menu.js in src folder
stylesheetNewt.js in src folder

There are some variables named as "syblars" in public/js/main.menu.js file. Can we change them to "sybvals"?
I also see some commented lines especially in src/index.js and public/js/main.menu.js (like here and here)) and multiple consecutive empty lines (like here). Can you please remove them?

Are we using the following files:
* syblars_error.log file in root folder
* main.menu.js in src folder
* stylesheetNewt.js in src folder

There are some variables named as "syblars" in public/js/main.menu.js file. Can we change them to "sybvals"?

I also see some commented lines especially in src/index.js and public/js/main.menu.js (like here and here)) and multiple consecutive empty lines (like here). Can you please remove them?

I also see sbgnml-to-cytoscape as a dependency in package.json. I guess we're not using it, are we?

@hasanbalci I consider it again and remove unnecessary parts mentioned above.


getText() removes line breaks from text

When I use
$('#message').data("emojioneArea").getText()
it returns text without line breaks. How could I avoid this?

It happens, because in some cases this functions works not correctly,
textFromHtml
htmlFromText

This should be marked as critical bug and not as enhancement. This makes this lib practically unusable.

I know where make the changes, but I don't know exactly what to change.
How do we solve it?

duplicate of https://github.com/mervick/emojionearea/issues/34


System.Threading.Tasks.TaskCanceledException: 'A task was canceled.'

When I try to change the them from code behind (from within the Execute of a Command) I get the following error (see end of post)
I'm using version 2.4.3 of mahapps but was also getting an exception in 1.6.0 when attempting the same action, however the error was different.  It was pointing to a threading issue.
The llocation I'm trying to change the them is here
    public class ChangeThemeCommand : ICommand
    {
        public event EventHandler CanExecuteChanged;

        public bool CanExecute(object parameter)
        {
            return true;
        }

        public void Execute(object parameter)
        {
            string name = (string)parameter;

            ThemeManager.Current.ChangeThemeBaseColor(Application.Current, name);
        }
    }

That command is being called from the main window from a menu item like this
            <MenuItem Header="Theme"  >
                <MenuItem Header="Light" Icon="{icons:FontAwesome Kind=CircleRegular,Width=25}" Command="{Binding changeThemeCommand}" CommandParameter="Light" ></MenuItem>
                <MenuItem Header="Dark" Icon="{icons:FontAwesome Kind=CircleSolid, Width=25}" Command="{Binding changeThemeCommand}" CommandParameter="Dark" ></MenuItem>
            </MenuItem>

My app initialization in App.cs looks like this
                Thread splashScreenWindowThread = new Thread(() =>
                {
                    splashScreenWindow = container.Resolve<SplashScreen>();
                    splashScreenWindow.Show();

                    System.Windows.Threading.Dispatcher.Run();

                });
                splashScreenWindowThread.SetApartmentState(ApartmentState.STA);
                splashScreenWindowThread.IsBackground = true;
                splashScreenWindowThread.Start();

                var mainwindow = container.Resolve<MainWindow>();
                this.MainWindow = mainwindow;

                mainwindow.Loaded += (s, ev) =>
                {
                    splashScreenWindow.Dispatcher.Invoke(new System.Action(
                    () =>
                    {
                        if (splashScreenWindow.IsActive)
                            splashScreenWindow.Close();

                        splashScreenWindow.Dispatcher.InvokeShutdown();
                    }

                    ));
                };
                mainwindow.Show();

ERROR
System.Threading.Tasks.TaskCanceledException: 'A task was canceled.'

   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Windows.Threading.DispatcherOperation.Wait(TimeSpan timeout)
   at System.Windows.Threading.Dispatcher.InvokeImpl(DispatcherOperation operation, CancellationToken cancellationToken, TimeSpan timeout)
   at System.Windows.Threading.Dispatcher.Invoke(Action callback, DispatcherPriority priority, CancellationToken cancellationToken, TimeSpan timeout)
   at System.Windows.Threading.Dispatcher.Invoke(Action callback)
   at System.EventHandler`1.Invoke(Object sender, TEventArgs e)
   at ControlzEx.Theming.ThemeManager.ChangeTheme(Object target, ResourceDictionary resourceDictionary, Theme oldTheme, Theme newTheme) in /_/src/ControlzEx/Theming/ThemeManager.cs:line 636
   at ControlzEx.Theming.ThemeManager.ChangeTheme(Object target, ResourceDictionary resourceDictionary, Theme oldTheme, String baseColorScheme, String colorScheme) in /_/src/ControlzEx/Theming/ThemeManager.cs:line 741
   at ControlzEx.Theming.ThemeManager.ChangeThemeBaseColor(Object target, ResourceDictionary resourceDictionary, Theme oldTheme, String baseColorScheme) in /_/src/ControlzEx/Theming/ThemeManager.cs:line 840
   at ControlzEx.Theming.ThemeManager.ChangeThemeBaseColor(Application app, String baseColorScheme) in /_/src/ControlzEx/Theming/ThemeManager.cs:line 769
   at MyAppName.Commands.ChangeThemeCommand.Execute(Object parameter) in D:\SOURCECODE\VISUALSTUDIO\EngineeringTools\MyApp\DEV-branch\MyAppName\Commands\ChangeThemeCommand.cs:line 26
   at MS.Internal.Commands.CommandHelpers.CriticalExecuteCommandSource(ICommandSource commandSource, Boolean userInitiated)
   at System.Windows.Controls.MenuItem.InvokeClickAfterRender(Object arg)
   at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Int32 numArgs)
   at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Int32 numArgs, Delegate catchHandler)
   at System.Windows.Threading.DispatcherOperation.InvokeImpl()
   at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
   at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
   at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
   at MS.Internal.CulturePreservingExecutionContext.Run(CulturePreservingExecutionContext executionContext, ContextCallback callback, Object state)
   at System.Windows.Threading.DispatcherOperation.Invoke()
   at System.Windows.Threading.Dispatcher.ProcessQueue()
   at System.Windows.Threading.Dispatcher.WndProcHook(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
   at MS.Win32.HwndWrapper.WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
   at MS.Win32.HwndSubclass.DispatcherCallbackOperation(Object o)
   at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Int32 numArgs)
   at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Int32 numArgs, Delegate catchHandler)
   at System.Windows.Threading.Dispatcher.LegacyInvokeImpl(DispatcherPriority priority, TimeSpan timeout, Delegate method, Object args, Int32 numArgs)
   at MS.Win32.HwndSubclass.SubclassWndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)
   at MS.Win32.UnsafeNativeMethods.DispatchMessage(MSG& msg)
   at System.Windows.Threading.Dispatcher.PushFrameImpl(DispatcherFrame frame)
   at System.Windows.Application.RunDispatcher(Object ignore)
   at System.Windows.Application.RunInternal(Window window)
   at MyAppName.App.Main()

@erotavlas This issue happens with windows that are created in a different thread and then not closing correctly. I suggest to use this line of code to call the dispatcher shutdown
splashScreenWindow.Dispatcher.BeginInvokeShutdown(DispatcherPriority.Background);


Issue with Grooveshark

This script doesn't work for me (Mac OS X,Snow Leopard, Ubuntu 11) as the grooveshark library fails with an api error.
Does this script need to use grooveshark?

Yep, this is where it gets the songs from.
FYI, you problably want to track this issue: https://github.com/sosedoff/grooveshark/issues/9


Ksubrama/testkitchen

Looks good, had a few minor comments

Done!  I believe chefspec should bring rspec in.

Other than @jdmundrawala's comments, :+1:

:+1: can't wait to have this so we can have some full iis regression tests


Using ANARCI through Parapred

Hello,
I have a issue with using anarci with through parapred. When importing anarci, cannot import .germlines. Actually in lib there is no germlines.py file. Do you know how to solve it?
Following is the error command:
ModuleNotFoundError: No module named 'numpy.core._multiarray_umath'
/usr/local/lib64/python3.6/site-packages/Bio/SearchIO/init.py:211: BiopythonExperimentalWarning: Bio.SearchIO is an experimental submodule which may undergo significant changes prior to its future official release.
BiopythonExperimentalWarning)
Traceback (most recent call last):
File "/usr/local/lib/python3.6/site-packages/parapred-1.0.1-py3.6.egg/parapred/full_seq_processor.py", line 32, in get_CDR_simple
File "/root/.local/lib/python3.6/site-packages/anarci/init.py", line 3, in
from .anarci import *
File "/root/.local/lib/python3.6/site-packages/anarci/anarci.py", line 68, in
from .germlines import all_germlines
ModuleNotFoundError: No module named 'anarci.germlines'
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/usr/local/bin/parapred", line 33, in
sys.exit(load_entry_point('parapred==1.0.1', 'console_scripts', 'parapred')())
File "/usr/local/lib/python3.6/site-packages/parapred-1.0.1-py3.6.egg/parapred/parapred.py", line 227, in main
File "/usr/local/lib/python3.6/site-packages/parapred-1.0.1-py3.6.egg/parapred/parapred.py", line 197, in process_full_VH_VL_sequence
File "/usr/local/lib/python3.6/site-packages/parapred-1.0.1-py3.6.egg/parapred/full_seq_processor.py", line 34, in get_CDR_simple
Exception:
ImportError function get_CDR_simple() requires the python module anarci
Available from http://opig.stats.ox.ac.uk/webapps/sabdab-sabpred/ANARCI.php

You need to run the script build_pupeline/RUN_pipeline.sh. This downloads germline data and builds HMM models. This script is run as part of the installation process, so should not be necessary if the package was installed correctly. Closing as not a code issue.


SAK-29770 - Popup if tool description saved on home with html content

@ottenhoff Do you think this is the correct pattern? It looks like it's working for me. Prior to this patch it was using processEscapedHtml but I don't think this is necessary/correct and really isn't used anymore. It also doesn't capture the message for legacy, I'm not even sure we should continue to support the "return" (legacy) mode anymore.

This looks like the common Sakai pattern. This is the way other tools like Announcements do it. +1 Let's merge this in


tour: Rand does not seem to work correctly

Context: http://<IP_ADDRESS>:3999/basics/1
After running it repeatedly returns 1 every single time.

Some sort of initialization is needed.

From: https://tour.golang.org/basics/1

Note: the environment in which these programs are executed is deterministic, so each time you run the example program rand.Intn will return the same number. (To see a different number, seed the number generator; see rand.Seed.)

What I mean by "needed" is "needs to be added to the code".  It's not surprising that calls to functions in rand are deterministic without a prior call to rand.Seed.  It's surprising that rand.Seed is not being called.

@NathanZook  I think it's not being called because the page is discussing packages and going into seeding random numbers is off topic to that. The note on the page is clear that the same number will be repeated every time and points people to read further about rand.Seed if they wish.
I think the original issue has been answered here @hdost
If there is further discussion to be had about the use of random numbers as an example then we can open a new issue @NathanZook
Otherwise I believe this can be closed @adg


added dark toggle

This pull request implements a toggle feature to switch between dark mode and light mode across the application. The addition of these themes enhances the user experience by providing users with the flexibility to choose a visual style that suits their preferences and improves accessibility in various lighting conditions.
Related Issue #29
https://github.com/user-attachments/assets/36eecf3b-366b-40f5-bf64-1cdef8756a0c
Changes Made:

Added a toggle switch in the navigation bar to allow users to switch between dark mode and light mode.
Updated styling for all relevant components, including forms, buttons, and headers, to ensure consistent visual representation in both modes.
Ensured that the toggle state is preserved during user sessions to maintain the selected theme across page reloads.
Improved the visual hierarchy and readability of text elements in both themes to enhance overall usability.

Impact:

Users can now enjoy a more personalized experience by selecting their preferred theme.
Improved aesthetics and accessibility contribute to a better overall interface.

Testing:

Verified that the toggle functionality works correctly, switching themes without any visual glitches.
Checked all updated components in both dark mode and light mode to ensure proper styling and functionality.`;

Hi @Luson045, There is an issue with the frontend because of which was having issues while implementing the dark mode as some of the contributors have used external CSS, some of them have used styled component and some have also used tailwindCSS. Because of this it took me so much time.

How about we use shadcn for styling

@Abhi0049k  also remove the node modules can't merge with that, i was literally shocked to see 390 files changed 😂

@Abhi0049k use shadcn in every page?

@Luson045 If we use shadcn then we just need to worry about dark mode and we can simply focus on styling our component. But the way thing are there in the repo. I have to go to each and every file and then add dark mode feature.

hmm lemme think of that, anyway get rid of the node modules during PR please @Abhi0049k

Hi @Luson045,
I am facing an issue with the dark mode toggle. In the updated repository, some contributors are using styled-components, while previously, others were using TailwindCSS. Could you please ask the contributors to stick to either TailwindCSS or a consistent CSS library?

I'm unsure what to do next because, in the first PR, the dark mode was working fine, with the only issue being with node_modules. However, now there are more components involved, with a mix of both TailwindCSS and styled-components, which is becoming difficult to manage.

It might also be a good idea to recommend using the shadcn UI library, which integrates well with TailwindCSS and could provide consistency in the codebase.
As for dark mode, you can create individual issues for each dark mode implementation, as working on a single webpage's dark mode is already a level 3 issue by itself. Alternatively, I can create these issues for you. Making smaller, incremental changes will help contributors focus on and complete those issues, allowing updates to be made to the main branch before moving on to other components.

Working on the entire frontend's dark mode implementation will take more time, especially with the current issues, and the project will only grow larger in the future.
Please inform the contributors to use only TailwindCSS or another CSS library like shadcn, as it will help maintain a proper structure in the repo.

Please let me know the next steps, as I am unable to work on this issue in its current state. We can create issues for individual pages and then add dark mode to them.

okay, do it only for home page @Abhi0049k


User Canceled, with Google

Hello,
I've already used this plugin in the past and I remember It worked very well. Due to that, I'm currently trying to use it for another project. However, login with google is always returning me a PlatformException(400, User Canceled, null, null).
I'm not quite sure if the problem is directly related to this plugin or with the new OAuth 2.0 from Google APIs and its new way of generating access keys.
My current API keys are:

(sorry for being in Portuguese, but I think it's understandable: 'Cliente'->Client; 'Computador'->Computer)
In code, I'm passing the key pointed out as the googleWebClientId in the Constructor of Social Login, as follows:

More info on the exception:

Any ideas?
Thanks in advance,
Pedro Tomás

Hi @PedroRTomas, this error PlatformException(400, User Canceled, null, null). is quite common. It means there is some error in the webClientId setup. This error can be caused by many reasons like:

More than one use of a single web client id in multiple projects.
Or you might have not created a Firebase project.
Forgot to turn on web client id access from Firebase project.
Forgot to turn on the Internet connection on the installed app.
Or something else, that I didn't remember.
Can be due to no SHA value in Firebase. (But, I don't think this is required.)

It surely is not the error from the Library code. You can look up in this  thread as well.


test_sha256 and test_utf8_comparisons not executed

Recent patch 8.0.0684 added test_sha256.vim and test_utf8_comparisons.vim,
but they are not executed.  We can see in codecov that function f_sha256()
for example is currently not covered with tests:
https://codecov.io/gh/vim/vim/src/master/src/evalfunc.c#L10448
This PR fixes it.

Codecov Report

Merging #1819 into master will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1819      +/-   ##
==========================================
+ Coverage   75.14%   75.17%   +0.02%
==========================================
  Files          76       76
  Lines      125213   125212       -1
==========================================
+ Hits        94095    94124      +29
+ Misses      31118    31088      -30

Impacted Files
Coverage Δ

src/gui_beval.c
43.96% <0%> (-0.93%)
:arrow_down:

src/if_xcmdsrv.c
85.18% <0%> (-0.19%)
:arrow_down:

src/channel.c
83.71% <0%> (-0.19%)
:arrow_down:

src/os_unix.c
58.62% <0%> (-0.15%)
:arrow_down:

src/gui_gtk_x11.c
47.44% <0%> (-0.11%)
:arrow_down:

src/ex_cmds2.c
79.71% <0%> (-0.11%)
:arrow_down:

src/if_py_both.h
76.01% <0%> (-0.01%)
:arrow_down:

src/eval.c
80.82% <0%> (+0.07%)
:arrow_up:

src/evalfunc.c
82.01% <0%> (+0.1%)
:arrow_up:

src/message.c
68.72% <0%> (+0.45%)
:arrow_up:

... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da5116d...7bbfb5f. Read the comment docs.


Question about Shanghaitech

Hi,  thanks for your work. Could you give more the following details about the training on ShanghaiTech?

Hi
and thanks for the interest.
What kind of additional information do you need? Please note that most implementation details are  reported in the supplementary material.
Best,
D

hello,
I am bothering you again. I trained the network ,after 30 epochs of training Shanghaitech Datasets with the parameters in the paper, the result is LLK 0.449, REC 0.710,  NS 0.645,It is quite different from the results in the paper,How can I reproduce your results??

＠weibienao I also want to try to train, Can you provide your training code? Please, thanks!


[Doc] Publish Reactor programming in Event Hubs SDK tutorial to docs.microsoft.com

There is no immediate plan to do this.


ARROW-18343: [C++] AllocateBitmap() with out parameter is declared but not defined

This variant of AllocateBitmap is declared but not defined in buffer.cc.

Can you find out since when that has been the case? If there have been at least two releases without, perhaps we can safely remove it :-)

Can you find out since when that has been the case? If there have been at least two releases without, perhaps we can safely remove it :-)

The definition is removed in this PR but the api is kept. It appeared to be a mistake to remove the definition back then because this api is not marked deprecated in this PR (or perhaps it should be marked deprecated but was overlooked). Either way since it has been like this for over 2 years, perhaps it's best to remove this api?

Either way since it has been like this for over 2 years, perhaps it's best to remove this api now?

Yes, definitely.

This api is removed.


protocol(ticdc): force enable old value for canal json protocol

This is an automated cherry-pick of #3747 and #3983

What problem does this PR solve?
close https://github.com/pingcap/ticdc/issues/3676
What is changed and how it works?

add validate funcs
complete protocol when create changefeed
add tests

Check List
Tests

Unit test

Manual test(https://github.com/pingcap/ticdc/pull/3747#issuecomment-986629511)
Code changes

Has exported function/method change

Has exported variable/fields change

Side effects
None
Related changes

Need to cherry-pick to the release branch

Release note
Fix the problem that old value is not forced on automatically in `canal-json` and `maxwell` protocols

Codecov Report

:exclamation: No coverage uploaded for pull request base (release-5.0@eba76b8). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             release-5.0      #4057   +/-   ##
================================================
  Coverage               ?   64.0436%
================================================
  Files                  ?        160
  Lines                  ?      16762
  Branches               ?          0
================================================
  Hits                   ?      10735
  Misses                 ?       5076
  Partials               ?        951

can we merge it @hi-rustin

can we merge it @hi-rustin

Yes. But review required.

/merge

I marked it as require-LGT1 because it's actually part of https://github.com/pingcap/tiflow/pull/3780 because it didn't hold and merged part of the code.


Travis build fails

Travis build fails with the following message

This is fixed with https://github.com/ballerinax/docker/pull/381 .
Please get the latest code and retry.


Sawyer Joint Velocity Issues

When I run the sawer simulator in gazebo (I use ROS Melodic, but the issues also persists for ROS Kinetic), the joint velocity doesn't seem to work. The robot just sags down to the ground. Anyone had the issue, and how can it be fixed?

I've been having the same issue.

Hi @danem , in case you were wondering, our solution to this issue was working with the Franka Panda robot's simulation. We have our own fork (at https://github.com/HIRO-group/panda_simulation) that we use for joint velocity control, and it has been serving us well.

Thanks for the suggestion, but unfortunately I'm working with a physical sawyer robot, so ideally I will try to match my simulations with reality. As a temporary fix I bumped up the pid values for right_joint_position_controller found in sawyer_sim_controllers.yaml. This is a bit of a hack, but at least the robot is usable for the time being. I'll provide more information when I come up with something better.


Onboarding questions are running in a loop

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number:
Reproducible in staging?: Needs Reproduction
Reproducible in production?: Needs Reproduction
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @garrettmknight
Slack conversation (hyperlinked to channel name): convert
Action Performed:

Login as a new user

Full story Session: https://app.fullstory.com/ui/o-1WN56P-na1/session/4180436383204950635:4180436383204950635!2827566232608665405
Full story session: https://fsty.io/v/mjRARx2h
Expected Result:
Onboarding modal displayed once
Actual Result:
Onboarding modal questions are running in a loop
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Standalone
[ ] Android: HybridApp
[ ] Android: mWeb Chrome
[ ] iOS: Standalone
[ ] iOS: HybridApp
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/user-attachments/assets/8f14ee67-98e9-4f07-a538-9ffe7d3b4614
View all open jobs on GitHub

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

FYI this is also happening with<EMAIL_ADDRESS>clip

The user in the OP of this issue is<EMAIL_ADDRESS>

Not able to reproduce this :( I see it's potentially related to this issue, @deetergp is there any chance you have seen anything that relates the two in your investigation?

@kadiealexander I think I figured out what is likely causing this issue and others like it. Handing them here.

Closing this one as a dupe of https://github.com/Expensify/App/issues/53981


proxy.call has no return type

The call method has no return type, so as such IDE's don't know to type hint for a Future.

It is now Future. If you explicitly mirror the server's API in your ServerProxy extension, you can help the IDE even further.


[rlgl] Rename near, far variables

Hi, I found a couple more instances of the near and far names being used in rlgl.h.
I don't really know if this could incure the same problem I found with raymath.h, but I tought it might be useful to also rename this one.
This relates to this old issue that mentions these names:

https://github.com/raysan5/raylib/issues/243

I would also mention that I'm not yet using the suggested setup to select includes from windows.h, from here:

https://github.com/raysan5/raylib/issues/1217

Which may fix most of this kind of issues, should anyone incur in the same warnings as in here.

@jgabaut Sure! those functions were added recently


Column resizing with header groups no longer works

material-react-table version
1.8.3
react & react-dom versions
18.2.0
Describe the bug and the steps to reproduce it
Resizing doesn't work if you have header groups.
Open the first sandbox and try to resize any column/group of columns.
I was able to find out that the resizing with header groups is not working in version 1.7.4 and above.
Minimal, Reproducible Example - (Optional, but Recommended)
Sandbox with the latest version (1.8.3) - https://codesandbox.io/s/resize-doesnt-work-with-groups-eq7k2i?file=/src/TS.tsx
Sandbox with version 1.7.3 - https://codesandbox.io/s/resize-doesnt-work-with-groups-old-version-smbq2p?file=/src/TS.tsx
Screenshots or Videos (Optional)
No response
Do you intend to try to help solve this bug with your own PR?
None
Terms

[X] I understand that if my bug cannot be reliably reproduced in a debuggable environment, it will probably not be fixed and this issue may even be closed.

The issue might be related to CSS variables, since it cannot find the right one for the header (see the image below).
The was a change for CSS variables naming in version 1.7.4: 1.7.4 changes for CSS naming


Team Foundation Build support

Is there any way to get this test adapter to run tests on a build server?
I tried the basic stuff of checking the files from the VSIX package into source control (in the location where the build controller looks for custom test adapters), then setting up a test source in the build definition to look for the KarmaTestAdpater.json file. I also tried a trick I've seen elsewhere on the internet, which is to make sure all of the test adapter DLLs have a *.TestAdapter.DLL filename.
Unfortunately the build just doesn't run the Karma tests, and there doesn't seem to be any logging or documentation I can find to troubleshoot this. There are no errors or warnings that I can find, the build just quietly runs no tests.
With the same approach we have had some success with incorporating other JavaScript test adapters into our build, although we really like using this test adapter for running our Karma tests in Visual Studio and it would be great it we could get it to work in our build as well.
I can give a bit more information about things I've tried if there is someone who can help with this,
Thanks

We integrated Karma into our build by just running the karma command on the commandline from PSExec.  I didn't see any clear way of integrating this plugin in the build process.
Also, by separating this out, we are running the tests on a different box than the build machine, so that, potentially, we can run against different versions of IE on different boxes.  Just haven't gotten around to setting that up yet.

Thanks for the reply. Am I right in saying that by using the command line your build either passes or fails – i.e. there is nothing in Visual Studio's build summary page about which Karma tests in particular failed or passed?

Ah, so, our setup is a little more complicated than I led on.

In our build script, we first copy all of the JS files and the karma.config file over to a different JS testing box.
Then, we ca

Thanks for the clarification. To be honest we're probably going to have to go with something like that ourselves, I was just really hoping someone might have already got this test adapter working in a TFS build.


Bug: Actions and services not invoked after transitioning back using history state

Description
The machine receives a PING from an invoked callback and is supposed to transition to a refresh state that is of type history. The state it transitions back to does not re-invoke the service and actions defined for that state but does clean up the invoked callback.
I also have an entry action on the main machine for logging that's showing that the event is a null event (type is an empty string). In version 4.32 this is still xstate.init which is what I expected.
Both issues are not present in version 4.32
Expected result

Expected event of xstate.init to be passed to log action in avocado machine's booting.entry action.
Expect query machine to re-invoke avocadodItemsSubscription after moving back and forth between history node

Using the provided Codesandbox example:
Watch the console when it starts up

After clicking test which sends PING to the query machine:

I would expect these two logs again:

Actual result
The log action on entry logs an empty string as the event type rather than xstate.init

and the invoked child machine does not re-invoke the expected callback service and action after transitioning back from the history state.
Reproduction
https://codesandbox.io/s/still-bash-it7513?file=/src/App.tsx
Additional context
No response

This is fixed in both v4 and v5. I'm also adding a related test case here to ensure that we don't regress on this in the future


meta(gha): Deploy action stale.yml

I are a bot, here to deploy stale.yml. 🤖

I reran the test suite and it's still failing. Can I let you all resolve before proceeding @vladanpaunovic?

I reran the test suite and it's still failing. Can I let you all resolve before proceeding @vladanpaunovic?

Sorry to come late to this. Yes, I will try to resolve it.


Expose buffer

In some situations it is useful to know what is in the buffer, how big it is, or even manipulate the data.
An example is streaming media. If the buffer reaches a threshold you'll want to wipe the buffer, decrease quality, and start filling it again.

sure - but really this module shouldn't be your go to. there is usually a more pull-stream way to do it, although I'd be happy to merge a PR that enabled more pully ways to use this.


Add user management update permission for organization creator

Purpose

The user management update permission is added for the minimum required permission set of the organization creator.

This will cause inconsistencies in the previously created organization role's org-creator roles permissions and the new organization's org-creator permissions.
Let's verify whether can we define that "/api/asgardeo-onboard/v1/users/invite-link" API need user creation permission because invite happens in user creation flow

https://github.com/wso2-extensions/identity-organization-management/pull/172#issuecomment-1299900651 due to the concern mentioned, adding a permission for the org-creator role could cause migration effort also.


indexing NDTensor does not work as expected

Indexing an NDTensor of more than one Index does not work properly. If one index is fixed to a certain value n>1, the returned tensor has dimension n instead of 1. This only happens if another index is indexed over a range.
using ITensors
using ITensors.NDTensors

i = Index(2)
j = Index(2)

T = randomITensor(i, j)
dims(tensor(T)[2, 1:end])  # -> (2, 2) instead of (1, 2)

I would expect that fixing i=>2 would return a (1, space(j))-dimensional tensor. This new behaviour occurred after we updated from ITensors v0.1.34 to v0.1.41.
Version information
Julia:
Julia Version 1.6.0
Commit f9720dc2eb (2021-03-24 12:55 UTC)
Platform Info:
  OS: macOS (x86_64-apple-darwin19.6.0)
  CPU: Intel(R) Core(TM) i5-1038NG7 CPU @ 2.00GHz
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-11.0.1 (ORCJIT, icelake-client)

ITensors:
 ITensors v0.1.41

Oh boy, that's a bad bug, thanks. I can confirm it is also an issue on the main branch (ITensors v0.2.10).


Indicator Light widget ON and OFF text not calculated

When using a datasource to set the On or Off text of a light indiucator widget, the data path apear as is and is not calculated.

+1

+1

+1

+1

Here's a fix:
var indicatorWidget = function (settings) {
    var self = this;
    var titleElement = $('

');
    var stateElement = $('

');
    var indicatorElement = $('

');
    var currentSettings = settings;
    var onText;
    var offText;
    var isOn = false;

    function updateState() {
        indicatorElement.toggleClass("on", isOn);

        if (isOn) {
            stateElement.text((_.isUndefined(onText) ? (_.isUndefined(currentSettings.on_text) ? "" : currentSettings.on_text) : onText));
        }
        else {
            stateElement.text((_.isUndefined(offText) ? (_.isUndefined(currentSettings.off_text) ? "" : currentSettings.off_text) : offText));
        }
    }

    this.render = function (element) {
        $(element).append(titleElement).append(indicatorElement).append(stateElement);
    }

    this.onSettingsChanged = function (newSettings) {
        currentSettings = newSettings;
        titleElement.html((_.isUndefined(newSettings.title) ? "" : newSettings.title));
        updateState();
    }

    this.onCalculatedValueChanged = function (settingName, newValue) {
        if (settingName == "value") {
            isOn = Boolean(newValue);
        }
        if (settingName == "on_text") {
            console.log
            onText = newValue;
        }
        if (settingName == "off_text") {
            offText = newValue;
        }

        updateState();
    }

    this.onDispose = function () {
    }

    this.getHeight = function () {
        return 1;
    }

    this.onSettingsChanged(settings);
};

freeboard.loadWidgetPlugin({
    type_name: "altIndicator",
    display_name: "Alternative Indicator Light",
    settings: [
    {
        name: "title",
        display_name: "Title",
        type: "text"
    },
    {
        name: "value",
        display_name: "Value",
        type: "calculated"
    },
    {
        name: "on_text",
        display_name: "On Text",
        type: "calculated"
    },
    {
        name: "off_text",
        display_name: "Off Text",
        type: "calculated"
    }
    ],
    newInstance: function (settings, newInstanceCallback) {
        newInstanceCallback(new indicatorWidget(settings));
    }
});

I'm not sure if you're aware but the code submitted for the fix still doesn't work.

Gary,
Are you using freeboard.io, or the open source version?  Pushes haven't
been changed to Production on freeboard.io.
On Wed, Aug 19, 2015 at 12:06 PM, Gary Mason<EMAIL_ADDRESS>wrote:

I'm not sure if you're aware but the code submitted for the fix still
doesn't work.
[image: capture-freeboard-issue]
https://cloud.githubusercontent.com/assets/8322023/9361715/abcab1e8-4694-11e5-9c1b-e524eb9e42a5.PNG
—
Reply to this email directly or view it on GitHub
https://github.com/Freeboard/freeboard/issues/125#issuecomment-132659698
.

I'm using the open source version.
Sent from my Samsung device
-------- Original message --------
From: Vishal Kumar<EMAIL_ADDRESS>Date: 19/08/2015  20:35  (GMT+00:00)
To: Freeboard/freeboard<EMAIL_ADDRESS>Cc: Gary Mason<EMAIL_ADDRESS>Subject: Re: [freeboard] Indicator Light widget ON and OFF text not calculated
(#125)
Gary,
Are you using freeboard.io, or the open source version?  Pushes haven't
been changed to Production on freeboard.io.
On Wed, Aug 19, 2015 at 12:06 PM, Gary Mason<EMAIL_ADDRESS>wrote:

I'm not sure if you're aware but the code submitted for the fix still

doesn't work.

[image: capture-freeboard-issue]

https://cloud.githubusercontent.com/assets/8322023/9361715/abcab1e8-4694-11e5-9c1b-e524eb9e42a5.PNG

—

Reply to this email directly or view it on GitHub

https://github.com/Freeboard/freeboard/issues/125#issuecomment-132659698

.

—
Reply to this email directly or view it on GitHub.

I don't know if there is already a solution but i fix my freeboard indicator problem with this
this.onCalculatedValueChanged = function (settingName, newValue) {
if (settingName == "value") {
if (newValue == onText) {
isOn = true;
}
else {
isOn = false;
}
}
if (settingName == "on_text") {
onText = newValue;
}
if (settingName == "off_text") {
offText = newValue;
}
        updateState();
    }

+1


How can i block screen shot ?

flutter_windowmanager: latest :- use this package it's help for you

i used it but it blocking on other portion of the app while I am using the eBook functionality it doesn't work.


Suggest some tweaks for Ondřej.

@certik I've written some proposed changes for F18 and current Flang.
This seemed like the easiest way to suggest the wording change.
Let me know if you would like something else.

Thank you @gklimowicz, I appreciate it. This is perfect, and if you are ok with the wording, then so are we.


mup setup throws error on Phantom.js

Hello,
when I run mup setup I get :
mup setup

Meteor Up: Production Quality Meteor Deployments
------------------------------------------------

“ Checkout Kadira!
  It's the best way to monitor performance of your app.
  Visit: https://kadira.io/mup ”

Started TaskList: Setup (linux)
[hostname] - Installing PhantomJS
events.js:85
      throw er; // Unhandled 'error' event
            ^
Error: getaddrinfo ENOTFOUND hostname
    at errnoException (dns.js:44:10)
    at GetAddrInfoReqWrap.onlookup [as oncomplete] (dns.js:94:26)

any idea whats wrong?, please

In the above example I have set install node to false.
If I set phanton to false I get another error:
mup setup

Meteor Up: Production Quality Meteor Deployments
------------------------------------------------

“ Checkout Kadira!
  It's the best way to monitor performance of your app.
  Visit: https://kadira.io/mup ”

Started TaskList: Setup (linux)
[hostname] - Setting up Environment
events.js:85
      throw er; // Unhandled 'error' event
            ^
Error: getaddrinfo ENOTFOUND hostname
    at errnoException (dns.js:44:10)
    at GetAddrInfoReqWrap.onlookup [as oncomplete] (dns.js:94:26)

navigate to /etc and look in the hostname file :)
I used the wrong hostname


update import function to accomodate meetings fields

Coverage increased (+0.3%) to 86.244% when pulling df0417d7cb742317bd7459e625be1d1be1d7c7c0 on chantca95:import_contacts_updated_1.3 into 9e8636ff8f409cbe7779c3946d3b47ff488e036e on CS2103-AY1819S1-W13-1:master.


False positive against Sentry-Trace

Describe the bug

[x] I have verified that the issue is reproducible against the latest version
of the project.
[x] I have searched through existing issues to verify that this issue is not
already known.

Minimal Reproducible Example
    @SentrySpan
    @Transactional
    @Scheduled(cron = "@hourly")
    @SchedulerLock(name = SYNC_EXERCISES_LOCK_NAME, lockAtLeastFor = "2m", lockAtMostFor = "10m")
    @SentryTransaction(operation = "task")

Produces:
[ERROR]     (see https://error-prone.picnic.tech/bugpatterns/ScheduledTransactionTrace)
[ERROR]   Did you mean '@Trace(dispatcher = true)@SentrySpan'?

Expected behavior
No error should be present. We use Sentry (not New Relic).
Setup

Mac OS latest.
Java version 19.0.1
Error Prone Latest
Error Prone Support Latest

Additional context
None.

Hey @TomBeckett, thanks for opening this issue!
Good news, we are already working on a fix for that! For context, see #308. There we add an extra check to make sure that an error is thrown only if New Relic is on the classpath. In other words, it should fix your case.
For now, I would suggest to turn off the check as is explained in our documentation.
We will let you know once a fix for this is out.

@rickie Awesome, thank you for the fast response. Is there any ETA on when this may be released?
I ask because I have the more issues/examples just like that thread and don't want to spam issues if they are coming soon 😄

I hope we can do a release ~this week (not making a hard promise though 👀).
Do you mean that you have more related issues or other issues that are not related to this one?
In the latter case, feel free to open more issues 😄.

@TomBeckett we released v0.5.0! So updating should solve the problem 😄. Let us know if you encounter any problem.


Tests inherited from Generic test fixture

In case, when TestFixture inherits from (generic) class, which contains tests,

the tests in inherited class and the base class are displayed separately
"Browse th source" for tests in base class is not available

example:
class EntityEditTests
{
[Test]
public void DeleteEntity()
{
...
}
}
[TestFixture]
class DocumentTests : EntityEditTests
{
[Test]
public void SignDocument
{
...
}
}
Instead of showing two tests for DocumentTests, one test for DocumentTests is displayed and one test for EntityEditTests' !
See discussion at https://bugs.launchpad.net/nunit-vs-adapter/+bug/1194734

I'm using a library called SpecEasy which has you implement all tests as a generic NUnit base class. This issue isn't a big deal on my local machine, but when we build on TFS I get a "No source data found..." warning for all of my specs. I looked at the discussion on Launchpad and it looks like there's no plan to make a fix, is that accurate?

We haven't used Launchpad for a long time. Can you point me to the discussion in question?
Right now, this is not a problem that's on our radar, but if you can give us some more info we'll look into it. As a start, what version of the adapter are you using and what do your generic classes look like?

Sorry, I see the discussion is cited above.
@OsirisTerje This has never been categorized (labelled) or assigned any milestone. What should we do with it?

Thanks for the response.
I am using the version provided through Visual Studio extensions which looks like <IP_ADDRESS>. The library that contains the generic base class is SpecEasy. The generic base class is here: https://github.com/trackabout/speceasy/blob/master/SpecEasy/GenericSpec.cs which also inherits from https://github.com/trackabout/speceasy/blob/master/SpecEasy/Spec.cs which has the actual test attributes applied.
So what will end up happening is for each test, we get something like: "No source data found for Namespace.NameOfTestClassSpec.Verify"
I appreciate your time.

Is your test running OK, aside from seeing this warning message that applies to the location of the source code?
Given that the NUnit tests are in the library and not in your code, it makes absolute sense that we can't find the source. We don't have the source! The fact that we give a warning when running under TFS might be a bug. It only makes sense under the VS IDE.
The earlier post referred to tests showing up as two separate classes. I gather that's not what is happening for you however.

Yes, the tests pass just fine in both VS 2013 and TFS 2012, really I just want to be able to suppress the warnings from TFS since it makes it difficult to sort out where the real issues are with the build. I do see these warnings in the Test output in VS, but not as actual warnings.
And yeah, I guess I wasn't really thinking about the differences in these situations; it would be great if I could somehow associate a method in my Spec with the test being executed or even just suppress the warnings, but I see this actually is working as intended.
Thanks

I'll grab @bradenb's code above and use it on a TFS instance, and get a repro, and see if I can pinpoint where this message comes from.  It should be equal in VS and TFS, but the interfaces being used are not absolutely identical.

I'm guessing it's equal in the two cases but more visible in the TFS output. Since there is no use of the source in TFS, maybe we should skip the message. Alternatively, we could create just a single warning if some classes have no source.

I'm not sure if it's of no use in TFS (builds). Consider the following: you have a test failure/assertion during the build. If you now open the build report, open the tests (they get loaded into VS usually), If you then try to navigate to the test code in question, I think you need the source information.

Maybe @osiristerje can try this (I'm traveling) and see. I think VS will give its own message if the source is not available.
In the same way, the ide gives a "source not available" message, possibly making our log message unnecessary except when debugging the adapter.

On the surface, it seems like we would want to fix this in 2.0.

I fixed this bug in the NUnit 3 adapter (two commits at the end of https://github.com/nunit/nunit3-vs-adapter/pull/454). If anyone is waiting for this fix, the test can be brought straight over. The fix will have to be translated to Mono.Cecil rather than System.Type reflection.


Error parsing response when returning a Principal from a canister method written in Rust

When calling the following canister method:
#[query]
fn whoami() -> ic_cdk::export::Principal {
    ic_cdk::caller()
}

or:
#[query]
fn whoami() -> ic_cdk::export::candid::Principal {
    ic_cdk::caller()
}

I receive the following error:
ÙÙ÷£fstatushrejectedkreject_codenreject_messagex¥IC0503: Canister rrkah-fqaaa-aaaaa-aaaaq-cai trapped explicitly: Custom(Cannot parse header 4449444c0001

Caused by:
    binary parser error: index at byte offset 6)

dfx canister call <my-project> whoami shows (principal "<my-principal>") so I expected that to work in a browser too. Other methods like the "hello/greet" example work in the browser.

@dfinity/agent 0.11.1
dfx 0.9.3
ic-cdk 0.5.0
macOS Monterey, Version 12.2.1 (21D62)
Brave, Version 1.36.119 Chromium: 99.0.4844.83
Safari, Version 15.3 (176<IP_ADDRESS>.8)

The error seems to come from the Rust side trying to decode input argument. The client is sending DIDL\00\01, which is invalid. We should be sending DIDL\00\00 instead.

For what it's worth, it appears to work in the Candid UI but I get a different value than I do on the command line with dfx canister call

Can you share the code for calling the canister in JS?
Browser identity and dfx identity are different. And for Candid UI, it only uses the anonymous identity for now.

This appears to have been due to some bindings I wrote that were conceptually typed as Unit -> Principal but called such functions as whoami({}) since {} can represent unit.


getattr does not receive fh

In the c libfuse, getattr calls receive fh if there is some (see fuse_lowlevel.c:1087, static void do_getattr). In rust-fuse, only setattr receives _fh: Option<u64>.

That's because rust-fuse still uses the FUSE kernel ABI version 7.6 and fh in getattr was introduced in 7.9. We definitely need to add support for newer versions, but it's hard to support a range of versions and it's not unclear yet how rust-fuse should handle it (see also #83).

Getattr calls will receive fh after we switched to a newer FUSE kernel ABI in #97


currentUser is not resolved after session authentication is finished

I a querying the currently logged in user as described in the docs. When the beforeModel hook is hit the promise returned by this.get('currentUser').load() is nicely resolved when the route is loaded. No need to deal with promises there (e.g. when calculating permissions).
When the user is logging in and we hit the sessionAuthenticated() path this.get('currentUser').load() is obviously only resolved after the route is completely loaded as there is no one waiting for the promise to resolve.
Is there any way to ensure that the current user is always resolved first before the route is changed?

I stumbled upon #1064 and came up with the following solution. Hnece no real issue which could not be handled in #1064. I think a similar example could be added to the docs.
sessionAuthenticated() {
    this._loadCurrentUser().then(
      () => {
        // Bluntly copied from the super class.
        // We must wait for the current user before we can attempt the transition.
        const attemptedTransition = this.get('session.attemptedTransition');

        if (attemptedTransition) {
          attemptedTransition.retry();
          this.set('session.attemptedTransition', null);
        } else {
          this.transitionTo(this.get('routeAfterAuthentication'));
        }
      }
    );
  }


Move FlattenAtrousConv before AlterOpLayout in the default opt pipeline.

FlattenAtrousConv must be called before AlterOpLayout to give a performance boost. The pass must be called before the change of the layout.

@masahi


Set Texture With setProperty().

What is your question?
Is there any way I can use setProperty() to change a sprite's texture, like for as the texture for the opponent's icon, iconP2?

loadGraphic(object, texture, gridX, gridY)


Uperf pod fails when using default pod net + pinning + multi pair

Describe the bug
Running a uperf pod test w/ more than one pair + node pinning fails with:
  in "<unicode string>", line 12, column 7:
          template:
          ^
expected <block end>, but found '-'
  in "<unicode string>", line 219, column 7:
          - kind: Job
          ^
fatal: [localhost]: FAILED! => {
    "changed": false
}

To Reproduce
ex params:
  workload:
    name: uperf
    args:
      debug: true
      serviceip: false
      hostnetwork: false
      networkpolicy: false
      multus:
        enabled: false
      pin: true
      pin_server: "worker02"
      pin_client: "worker01"
      samples: 1
      kind: pod
      pair: 10

Expected behavior
Clients start
Additional context
I reverted PR #735 and that appears to resolve the issue, but I don't understand what the actual problem is with the filter yet..

cc @mukrishn in case you have any idea why the filter could be causing this


New features: AnnotationDot and LabledDot

Two more Mobjects, that allow you to illustrate your scenes with AnnotationDot and LabledDot.
Here is an example
from manim import *

class ExampleScene(Scene):
    def construct(self):
        sq = Square(fill_color =RED, fill_opacity = 1)
        self.add(sq)
        dot = AnnotationDot()
        dot1 = LabledDot(42)
        dot2 = LabledDot("a")
        dot3 = LabledDot("ii")
        dot4 = LabledDot(r"3")
        dot.next_to(sq, UP)
        dot1.next_to(sq, UL)
        dot2.next_to(sq, UR)
        dot3.next_to(sq, DL)
        dot4.next_to(sq, DR)
        self.add(dot, dot1, dot2,dot3,dot4)
        self.wait(1)

Note: I don't know if importing MathTex locally is the best way to do it, but it was straight forward and it is working.
But please feel free to suggest better solutions for that! :)
Acknowledgement

[ x ] I have read the Contributing Guidelines

Please change "labled" to "labeled" ;)

good point. and I forgot black again.

It would be nice to include a boolean keyword argument (latex? math_typeset?)  that allows switching between using Text and MathTex for the label.

We had faced a similar dilemma in #380 . What we decided was letting the user choose the kind of label they want to pass -- Text, MathTex, etc. Link to comment

Can we please add real quick tests for these?

I will have a look on this soon, just now right now

I feel that in order to make the pile of undocumented classes not even larger than it already is, all new classes should come with at least rudimentary docstrings. (Personally, I'd be fine with a one line summary and one example illustrating how the new feature is used, which could even be just a static image here.)

Is added! :)

It would be nice to include a boolean keyword argument (latex? math_typeset?)  that allows switching between using Text and MathTex for the label.

I did not add this yet, is this still the current state that we want to do it like that?
If yes, maybe we can have math_typeset = "Basic" or "Latex" ?

I feel that in order to make the pile of undocumented classes not even larger than it already is, all new classes should come with at least rudimentary docstrings. (Personally, I'd be fine with a one line summary and one example illustrating how the new feature is used, which could even be just a static image here.)

Is added! :)

It would be nice to include a boolean keyword argument (latex? math_typeset?)  that allows switching between using Text and MathTex for the label.

I did not add this yet, is this still the current state that we want to do it like that?
If yes, maybe we can have math_typeset = "Basic" or "Latex" ?

Can we please add real quick tests for these?

I can do that, however would that not be a redundancy, as the example already acts like a test?

I did not add this yet, is this still the current state that we want to do it like that?
If yes, maybe we can have math_typeset = "Basic" or "Latex" ?

In order to keep things consistent, we have planned to implement it like in the Variable class. Basically, whatever kind of label has to be passed will be passed along with its class, e.g MathTex("{a}_{i}").
You can refer to the example class for Variable here. You can refer to the implementation here if you want to implement it similarly.

Depends on https://github.com/ManimCommunity/manim/issues/571

wuhu, testing is possible!! :)
An AnnotationDotTest is added, a LabeledDot test will be added as soon as we have consent how we want to handle that.
From the most current commit, it goes like this:
class ExampleAnnotationDot(Scene):
    def construct(self):
        sq = Square(fill_color=RED, fill_opacity=1)
        self.add(sq)
        dot1 = LabeledDot(42,var_type= Tex)
        dot2 = LabeledDot("a", var_type= MathTex)
        dot3 = LabeledDot("ii",var_type= MathTex)
        dot4 = LabeledDot("3",var_type= MathTex)
        dot1.next_to(sq, UL)
        dot2.next_to(sq, UR)
        dot3.next_to(sq, DL)
        dot4.next_to(sq, DR)
        self.add(dot1, dot2, dot3, dot4)
        self.wait(1)

wuhu, testing is possible!! :)
An AnnotationDotTest is added, a LabeledDot test will be added as soon as we have consent how we want to handle that.
From the most current commit, it goes like this:
class ExampleAnnotationDot(Scene):
    def construct(self):
        sq = Square(fill_color=RED, fill_opacity=1)
        self.add(sq)
        dot1 = LabeledDot(42,var_type= Tex)
        dot2 = LabeledDot("a", var_type= MathTex)
        dot3 = LabeledDot("ii",var_type= MathTex)
        dot4 = LabeledDot("3",var_type= MathTex)
        dot1.next_to(sq, UL)
        dot2.next_to(sq, UR)
        dot3.next_to(sq, DL)
        dot4.next_to(sq, DR)
        self.add(dot1, dot2, dot3, dot4)
        self.wait(1)

Instead of using a var_type argument: why not simply allow passing the rendered object as a string? In the sense that LabeledDot("a") does something by default (maybe Text?), LabeledDot(MathTex("a")) uses MathTex("a") as a label, and so on?

The whole point of the LabledDot is that it wraps a string into MathTex(r"{\large \textcircled{\small %s}}.
I will revert this pr now to a point, were MathTex is the default and no other things are allowed.
As I don't want to work on this anymore,  we can then either merge it like that, or close the pr, that would be fine with me :)
in case that there is broader interest in choosing which TextMobject should be used, feel free to make  a follow up pr.

class ExampleAnnotationDot(Scene):
    def construct(self):
        sq = Square(fill_color=RED, fill_opacity=1)
        self.add(sq)
        dot1 = LabeledDot(42)
        dot2 = LabeledDot("a")
        dot3 = LabeledDot("ii")
        dot4 = LabeledDot("3")
        dot1.next_to(sq, UL)
        dot2.next_to(sq, UR)
        dot3.next_to(sq, DL)
        dot4.next_to(sq, DR)
        self.add(dot1, dot2, dot3, dot4)
        self.wait(1)

My 2 cents: I believe var_type was suggested to be in line with Variable (cc @nilaybhatia )
However, at this point I'm more interested in merging this than in normalizing the API across different classes.

I am interested in extending the functionality of LabeledDot a bit more. As long as we don't properly support graphs (as in "graph theory"-graphs), I think that these are a somewhat convenient way to add the vertices of a poor man's graph.
While I could technically review my own commit, I'll refrain from doing so -- someone else please have an eye on it. The implementation of AnnotationDot SGTM. (CC @ManimCommunity/geometry)

(And sorry for this "hostile takeover" of your PR, @kolibril13.)

(And sorry for this "hostile takeover" of your PR, @kolibril13.)

As I did not want to work on this anymore by myself, you are more than welcome!
I can also test this tomorrow.

nice, thanks for this!
https://manimce--462.org.readthedocs.build/en/462/reference/manim.mobject.geometry.LabeledDot.html?highlight=lab#manim.mobject.geometry.LabeledDot

The example looks a bit weird, I think here we have to choose e.g. to have still black background.

The example looks a bit weird,

I agree.

I think here we have to choose e.g. to have still black background

I disagree: I think we should rather adapt the text color of the other labels to BLACK (or (almost) anything other than the default white).

ok!

ok!

Better colors via 7e2e17e3.

LGTM now!
@behackl : you can give an approve for me.

Argh, I forgot to change the test control data to the new compressed format (and we should also add changelog entries).
The pipeline on master will be broken; I'll send a follow-up in a moment.

Oh, sorry for being to fast with merging


Only give remote queues 1 minute to flush samples on shutdown.

Fixes #2972, fixes #3707
~This is just a POC - needs to be made flag controlled and need to refactor out the waitgroup, as the extra goroutine is a bit ugly.~

(CircleCI failures are unrelated)

do we even need to make the timeout settable?
LGTM and I don't have an opinion for config vs flag so it is up to @brian-brazil to give green light.

If it is settable, it must be a flag. No point in waiting less time for one source when another has a longer timeout, ans this is a very flagg-y setting.

@tomwilkie shall we leave this hard coded and if someone requests to be settable to revisit?

(Closing in favour of #4187)


Importing binding name 'EventEmitter' is not found.

IMPORTANT: This repository's issues are reserved for feature requests and bug reports. Do not submit support requests here.

Expected/desired behavior
App starts
Other information

Used Node 5.12.0

Same issue here. After #266 is resolved (should be), I tried this seed again. Actually I have been watching and waiting this seed to be ready for quite a long time. Unfortunately, I experienced the same issue as above.
More detail here:
file:///app/app/frameworks/i18n/services/multilingual.service.js:7:30: JS ERROR SyntaxError: Importing binding name 'EventEmitter' is not found.
There is another issue but not a show stopper:
Oct 13 20:49:34 Jamess-MacBook nativescript[1812]: objc[1812]: Class PLBuildVersion is implemented in both /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator.sdk/System/Library/PrivateFrameworks/AssetsLibraryServices.framework/AssetsLibraryServices (0x11f6e1910) and /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator.sdk/System/Library/PrivateFrameworks/PhotoLibraryServices.framework/PhotoLibraryServices (0x11f50b210). One of the two will be used. Which one is undefined.
Environment:
Flash clone the seed git. Tried both nativescript and nativescript@next.
MacOS, Xcode 8, Node 6.6.0, npm 3.10.3, ruby 2.3.1p112,

@hypery2k @netwiser got a fix coming for this shortly...

master has this fix now 👍
After you pull, best to do this:
npm run clean

Try again,
npm run clean, npm run start.ios
and re-clone the seed, npm i, npm run start.ios
Both having the same issue still
file:///app/app/frameworks/i18n/services/multilingual.service.js:7:30: JS ERROR SyntaxError: Importing binding name 'EventEmitter' is not found.

Tried with nativescript 2.3.0 and 2.4.0--2016-10-13, the same.

Im having the same issue here,
1: a fresh clone
2: npm i
3: npm run start.ios
result,
Oct 13 23:00:35 AJs-MacBook-Pro nativescript[24777]: objc[24777]: Class PLBuildVersion is implemented in both /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator.sdk/System/Library/PrivateFrameworks/AssetsLibraryServices.framework/AssetsLibraryServices (0x11d5b7910) and /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator.sdk/System/Library/PrivateFrameworks/PhotoLibraryServices.framework/PhotoLibraryServices (0x11d3e1210). One of the two will be used. Which one is undefined.
Oct 13 23:00:35 AJs-MacBook-Pro nativescript[24777]: 1 0x1069a6940 -[TNSRuntime executeModule:]
Oct 13 23:00:35 AJs-MacBook-Pro nativescript[24777]: 2 0x1065546d2 main
Oct 13 23:00:35 AJs-MacBook-Pro nativescript[24777]: 3 0x10a3a768d start
Oct 13 23:00:35 AJs-MacBook-Pro nativescript[24777]: file:///app/app/frameworks/i18n/services/multilingual.service.js:21:30: JS ERROR SyntaxError: Importing binding name 'EventEmitter' is not found.
Oct 13 23:00:35 AJs-MacBook-Pro com.apple.CoreSimulator.SimDevice.84EDE544-20CB-4192-ABED-7945A0610B67.launchd_sim24587: Service exited due to Segmentation fault: 11

Fixed a diff build issue on master. Still investigating this particular issue.

It's coming from ng2-translate as best I can tell at moment, may be a new change with the recent 3.1.0...trying to resolve tonight.

happened also with ng2-translate 3.0.0

The specific issue reported in this issue is now fixed on master.
However another issue cropped up that I am still working through with {N} build specifically mentioned here: https://github.com/NathanWalker/angular-seed-advanced/issues/272
Sorry for this inconvenience, it is frustrating. I will have a solution for that new issue soon.

@NathanWalker any update ?, I just start facing the same after the update.

Fixed on master. Ensure you 'rm -rf node_modules' then 'npm i'

<EMAIL_ADDRESS>has a dependency on<EMAIL_ADDRESS>


amplify hosting fails with Unknown token: yarn error

I have successfully deployed the repo two weeks ago and able to test the solution . and now been trying to redeploy the same repo in a different aws account using amplify web hosting console which is the exact same process. I also tried the latest version of the repo and below is the error in both cases.
 # Completed phase: build
                                 ## Completed Backend Build
2024-03-22T13:09:59.449Z [INFO]: {"backendDuration": 170}
                                 ## Starting Frontend Build
                                 # Starting phase: preBuild
                                 # Executing command: yarn install
2024-03-22T13:10:00.244Z [INFO]: yarn install v1.22.19
2024-03-22T13:10:00.321Z [WARNING]: error An unexpected error occurred: "Unknown token: { line: 3887, col: 1, type: 'INVALID', value: undefined } 3887:1 in /codebuild/output/src1431019503/src/amazon-connect-chat-translate/yarn.lock".
2024-03-22T13:10:00.322Z [INFO]: info If you think this is a bug, please open a bug report with the information provided in "/codebuild/output/src1431019503/src/amazon-connect-chat-translate/yarn-error.log".
                                 info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
2024-03-22T13:10:00.332Z [ERROR]: !!! Build failed
2024-03-22T13:10:00.333Z [ERROR]: !!! Error: Command failed with exit code 1

Got the latest commits into my fork and now getting different error , i am trying this in two different accounts in two two different regions and have same error in both cases

2024-03-27T16:27:21.901Z [INFO]: # Completed phase: preBuild
                                 # Starting phase: build
2024-03-27T16:27:21.902Z [INFO]: # Executing command: REACT_APP_CONNECT_REGION=${REACT_APP_CONNECT_REGION}
                                 # Executing command: REACT_APP_CONNECT_INSTANCE_ID=${REACT_APP_CONNECT_INSTANCE_ID}
                                 # Executing command: yarn run build
2024-03-27T16:27:22.033Z [INFO]: yarn run v1.22.0
2024-03-27T16:27:22.067Z [INFO]: $ craco build
2024-03-27T16:27:23.196Z [INFO]: Creating an optimized production build...
2024-03-27T16:27:26.825Z [WARNING]: One of your dependencies, babel-preset-react-app, is importing the
                                    "@babel/plugin-proposal-private-property-in-object" package without
                                    declaring it in its dependencies. This is currently working because
                                    "@babel/plugin-proposal-private-property-in-object" is already in your
                                    node_modules folder for unrelated reasons, but it may break at any time.
                                    babel-preset-react-app is part of the create-react-app project, which
                                    is not maintianed anymore. It is thus unlikely that this bug will
                                    ever be fixed. Add "@babel/plugin-proposal-private-property-in-object" to
                                    your devDependencies to work around this error. This will make this message
                                    go away.

2024-03-27T16:28:16.614Z [INFO]: Failed to compile.
2024-03-27T16:28:16.620Z [INFO]: Attempted import error: '@aws-amplify/auth' does not contain a default export (imported as 'Auth').
2024-03-27T16:28:16.693Z [WARNING]: error Command failed with exit code 1.
2024-03-27T16:28:16.694Z [INFO]: info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
2024-03-27T16:28:16.739Z [ERROR]: !!! Build failed
2024-03-27T16:28:16.739Z [ERROR]: !!! Error: Command failed with exit code 1
2024-03-27T16:28:16.739Z [INFO]: # Starting environment caching...