You can just do #navbar-robux {     display: none; }

Like remove the element that shows how much robux you have?

Roblox does not have an official credit converter, you must be using other extensions. Just disable it that way

Probably a third-party extension. I'll keep this issue closed until the extension is named so I can add support for it then.

Probably a third-party extension. I'll keep this issue closed until the extension is named so I can add support for it then.

 ????? i just disabled the roblox addons i had and it still shows up

I have never seen that in my life, but it seems part of roblox.
Unfortunately, I cannot fix this as I don't yet have that icon. Could you inspect that element and send a screenshot -  similar to the following image?

I could maybe try fixing it that way, otherwise hopefully someone can fix it themselves and make a pull request.

@anthony1x6000
This can be removed by adding the following CSS
    /* Remove nav-credit display */
    .nav-credit {
        display: none !important;
    }

What it looks like without

What it looks like with:

That's great!
If possible, could you also test the icon colours on light and dark modes?
It may also be worth making an optional toggle similar to 'displayRecommended.' I could do that part myself to save you the trouble.

I have already implemented the option toggle! Creating the PR right now actually, I will quickly test the icon colors, although I would have no idea how to fix them if they are broken.

Wow, thanks for already implementing that!
Should the icons be broken, sometimes I just do a css filter invert(1) on them. Probably not the best practice.
Sometimes the light and dark mode icon is in the same like svg, so just moving the background image might work as well.

Looking into it, they are broken but Roblox does the color changing for this icon by applying the filter invert(1), currently trying to find a way to override it.

It appears it is broken, but I have found a fix and will add it to the PR

Should be fixed now in #52


Split qrcode.js into 3 files: qrHandler.js, utils.js, and web3Storage.js

Related Issue (if any)
Closes: #40
Describe the add-ons or changes you've made
In this Pull Request, I've split the existing qrcode.js file into three separate files: qrHandler.js, utils.js, and web3Storage.js.
Type of change

[x] Refractor (Splitting up the files)
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Code style update (formatting, local variables)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Checklist:

[x] My code follows the "contribution guidelines" of this project.
[x] I have performed a self-review of my own code.
[x] I have commented my code, particularly wherever it was hard to understand.
[x] My changes generate no new warnings.
[ ] Any dependent changes have been merged and published in downstream modules.

@akhileshthite please review

@akhileshthite please review

Thanks!
Looks good to me.
Will merge tomorrow.

@AdityaNik, merged. Great work!
There's another active issue if you're interested #41

@akhileshthite looking forward to solve that as well

@akhileshthite looking forward to solve that as well

Cool, let me know when you start the work so I can assign the issue to you.


Compile the software bus the command “ make sw.vlt "  have some errors

Is  syntax issues on lines 71 ,80  in "spatz/hw/system/spatz_cluster/sw/build/snRuntime/start.S"  ?

Why are these parameters not being passed successfully in start.S.in

pip install jstyleson


⚠ Bofrost.de has degraded performance

In a5a0806, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 889 ms

Resolved: Bofrost.de performance has improved in ce92f06 after 1 hour, 52 minutes.


bug: fitness collapses

added assertion to make sure elite stays in next pop, if it still collapses then idk

should be fixed once argmax works

not fixed, elites either do not stay in population or happen to work very well on a specific environment

just discovered what i believe to be a bug, elites were selected based on the biggest change from the previous generation, which should only be done for mutation rates

seems like once minimum mut is hit, fitness collapses and don't recover no matter how high gamma increases. since gamma needs to beat the previous elite, it is unlikely to decrease. but im not sure i can make it decrease when the previous generations best is beaten, because then it might cycle somehow?

seems to occur when an agent learns to collect food but doesn't collect all of it, might be an issue with resolution of inputs. retrying using a more precise model


Support UAVCAN v1.0

https://forum.uavcan.org/t/uavcan-2019-roadmap/666

Good morning @pavel-kirienko :wave:
I'm part of a small group building a Arduino MKR Vidor 4000 (that's the Arduino with the FPGA) based quadcopter flight controller for Micro UAVs using Zubax Orel 20 as ESCs. As a part of this effort we are building an Arduino UAVCAN library ( 107-Arduino-UAVCAN ) based on libcanard.
Naturally we are using the latest version of libcanard which already has support for UAVCAN 1.0. Unfortunately the Zubax Orel 20 still run the legacy-v0 version of the protocol and we've been wondering if you can provide an estimate when the sapog firmware will be upgraded to using UAVCAN 1.0? We already have Zubax Orel 20 hardware available and would offer our services in testing any firmware change making the 1.0 protocol available.
CC / @generationmake @per1234

We are aiming at early June. If you could lend us a hand here, it would be appreciated. Also, may you be interested in sharing the info about your project at the UAVCAN forum?

Thank you for letting me know. Early June sounds good to me as we also need some time to get 107-Arduino-UAVCAN into usable shape. We've got experienced firmware engineers on the team so building and testing any sapog changes are well within our ability 😉 I'd love to share on the UAVCAN forum, which category do you think would be best suited and what exactly do you want me to share (focus on the Arduino UAVCAN abstraction or the whole project?).

We've got experienced firmware engineers on the team so building and testing any sapog changes are well within our ability

What I meant is that if your engineers could help us integrate libcanard v1 here instead of libuavcan v0, that would be great. But testing also helps.

I'd love to share on the UAVCAN forum, which category do you think would be best suited and what exactly do you want me to share (focus on the Arduino UAVCAN abstraction or the whole project?).

This category works best: https://forum.uavcan.org/c/app (the libcanard subcategory is also probably acceptable depending on the scope of your post). I think we want the full context.

Good morning :wave: I don't want to promise something we can't deliver (due to time constraints mostly) but we'll give it a try :rocket:

Hey all, just wanted to mention that I'm interested in getting Sapog-compatible ESCs and migrating sapog to UAVCANv1 this summer (although I can't provide a timeline at this point). Trouble is actually getting sapog ESCs, since kotleta20 is semi-permanently out of stock due to chip shortages and Orel 20 is out of my budget. Perhaps I'll design a board.


Discussion: APC vs APCU

About Zend\Cache\Storage\Adapter\Apc
Starting with PHP 7, APCU won't provide the apc_* fonction by default. So the test in __construct will pass, and later other methods will fail with undefined function.
For "legacy" branch
 $enabled = ini_get('apc.enabled') && function_exists('apc_store');

For current branch which requires PHP >= 5.5, as no APC version exists I think It could make sense to use APCU by default, and switch all call to apcu_* functions.
Another way could be to create an Zend\Cache\Storage\Adapter\Apcu adapter, and mark the previous as deprecated. But it will require code changes in all consumer of this library.
Comments ?
P.S. notice, for now, apcu 5.0.0-dev segfaults during the test suite.... under investigation.

If no BC break exists I think we can modify APC class for make internal calls to APCU.
At a second step we could rename the class with the correct "APCU" name and deprecate the old name. However there is no real wins of this so this could be do later.

If no BC break exists I think we can modify APC class for make internal calls to APCU.

I have to code ready on my computer, I'm waiting to ba able to run the test suite, before submitting a PR
https://github.com/remicollet/zend-cache/commits/issue-apcu

@remicollet @Maks3w I would prefer to add an Apcu adapter and make the Apc adapter as deprecated as I noticed that HHVM only supports the old APC methods.
I already worked on an Apcu adapter but currently I get some strange failures on travis that I don't get on my local machine.
-> https://github.com/marc-mabe/zend-cache/tree/feature/23/src/Storage/Adapter
-> https://travis-ci.org/marc-mabe/zend-cache/builds/90415153

Link to the other discussion : #23

I would prefer to add an Apcu adapter

I understand, even if I will prefer something transparent for users...

To summarize as I understand:

The Apc adapter was originally developed to be a wrapper for the APC extension
Later it was going to be also a wrapper for others that support the same interface as the APC extension (APCu and HHVM)
HHVM has (or had) a small difference in it metadata reporting - see https://github.com/zendframework/zend-cache/blob/master/src/Storage/Adapter/Apc.php#L717
APCu fully supports the APC interface but only if compiled with APC compatibility
The APCu extension has a small incompatibility in it's interface if compiled with or without APC compatibility as it's using the same class APCIterator but with different arguments

So for me it would be 100% transparent introducing a new Apcu adapter wrapping only the new APCu extension and leaving the Apc extension as is But mark it as deprecated to inform that this adapter could be dropped in the future but not before there exists an alternative for the minimum PHP version + HHVM.
So the only question I have should the new Apcu adapter support the APCu extension including the APCIterator inconsistency or not. Currently I think it needs to be supported to make the switch to APCu simpler.

I whink there are possible two choices:

Wait until HHVM adopt apcu_ methods.
Continue and to have both adapters. I think in this case APC should extend from the new APCu

closed by 2cd809d


Setting the transfer amount on a drink, has no effect on the quantity consumed

Description

You can set it to 50u and it still takes multiple slurps to empty the glass.
Screenshots

Additional context

Not an issue, that sets the transfer amount, not the drink amount.


COMP: set the required CXX standard to 14 in the bundled example

As suggested by @krm15 on the forum.

Matt plans a patch which would render this unnecessary, so hold off for now.

Superceded by https://github.com/InsightSoftwareConsortium/ITK/pull/2770


Invalid (positive) RSSI readings for the neighbour devices (TZ-674)

Answers checklist.

[X] I have read the documentation ESP Zigbee SDK Programming Guide and the issue is not addressed there.
[X] I have updated my IDF branch (master or release) and ESP Zigbee libs (esp-zboss-lib and esp-zigbee-lib) to the latest version and checked that the issue is present there.
[X] I have searched the issue tracker for a similar issue and not found a similar issue.

IDF version.
v5.3-dev-422-ga7fbf452fa
esp-zigbee-lib version.
1.1.2
esp-zboss-lib version.
1.1.2
Espressif SoC revision.
ESP32-C6
What is the expected behavior?
Valid RSSI readings for neighbours are provided.
This worked in 1.0.5.
What is the actual behavior?
The RSSI reading for the parent neighbour is positive, which is not a valid value.

No response

@nomis The issue is caused by a structure definition mismatch since (commit). Could you try again with the IDF v5.1.3 release.

No, because I want CONFIG_ESP_COREDUMP_FLASH_NO_OVERWRITE and fixes to the monitor command which are only on the v5.3 branch. (I tried 5f4249357372f209fdd57288265741aaba21a2b1 which is more recent but the device restarts/hangs several times a day.)
This implies that this library is not compatible with certain versions of the IDF. A version check won't work because 5.3 and 5.2 are both newer than 5.1.3. You'd need to add a check in the headers that struct esp_ieee802154_frame_info_t is the expected size and cause a compile error.
How am I supposed to tell which versions are compatible with the IDF that I'm using? The most recent release of this library is 4 days before that IDF version was released and there's nothing in the commit messages to indicate this change.

If it keeps crashing on a newer v5.3 build I won't even be able to use git bisect because of this change in structure size which will make it incompatible.
Depending on which IDF that they're built with, the old library will ignore bool process while the new library will misinterpret the channel as bool process. Both libraries will misread the other values in the struct.

@nomis The disadvantage of library is that it's built based with particular commit, the incompatible issue may happen when there is any mismatch change in other souce code. So we recommended using the release/v5.1 branch (Setting up the Repositories) where the zigbee libraries are built from.
If you want to use v5.3, please fetch the latest master branch, we don't see any incompatible issue recently.
In the future release, we will add the corresponding IDF version that the libraries are built from.

The disadvantage of library is that it's built based with particular commit, the incompatible issue may happen when there is any mismatch change in other souce code.

No, this is a problem with the way changes have been made to the IDF in a way that will be both incompatible and hidden.
If an incompatible change is being made you should version or rename the functions so that it won't link.

The disadvantage of library is that it's built based with particular commit, the incompatible issue may happen when there is any mismatch change in other souce code.

No, this is a problem with the way changes have been made to the IDF in a way that will be both incompatible and hidden.
If an incompatible change is being made you should version or rename the functions so that it won't link.

Agree that we should avoid the incompatible change, and invode version control for any break changes. We are very close to a stable Zigbee SDK release, thanks for your suggestions and patience along the way.

@BaWe155，

Hello. I have the same, neigbors LQI always 255. When is the fix and new release?

What is the ESP-IDF version you are currently using? Please note that the ESP-IDF version 5.1.3 is required for the ESP-Zigbee-SDK.

Yes I use 5.1.3
esp-zigbee-lib version.
1.1.2
esp-zboss-lib version.
1.1.2
LQI in the neighbour tabels is always 255.
see (TZ-466) #167 this problem is back.

@BaWe155 ，
You maybe need to use the esp-zigbee-lib and esp-zboss-lib v1.2.0 for a try, it is compiled based on esp-idf v5.1.3.


Hyperlink from Deployment concept to “define environment variables for a container” task page

[On https://k8s.io/docs/concepts/workloads/controllers/deployment/]
there is no reference on how to define environment variables for a container (https://kubernetes.io/docs/tasks/inject-data-application/define-environment-variable-container/)

/retitle Hyperlink from Deployment concept to “define environment variables for a container” task page
/kind feature
/language en

@energister can you suggest some specific location where making a change would work?

/assign


Bump version to 0.4

Necessary to sync the library with PySCF (see #41 ).

How is this necessary to sync with PySCF?

Otherwise the package suffers from the bug #40

openfermionpyscf 0.3 on pypi suffers from bug #40 . Hope the 0.4 version will be uploaded to pypi soon.

@babbush do you have any issues with this PR?

This is quite urgent so I am going to exercise my administrator privileges here.

@sunqm Version 0.4 has been uploaded to PyPI. Sorry for the delay.

Great, Thanks!
On Fri, Mar 15, 2019 at 11:54:34AM -0700, Kevin J. Sung wrote:

@sunqm Version 0.4 has been uploaded to PyPI. Sorry for the delay.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.*

--
Dr. Qiming Sun
Principal Researcher, Tencent Quantum Laboratory


NPE thrown in FHIRPathUtil.getResourceNodes(FHIRPathTree tree, FHIRPathNode node) when FHIRPathNode is not in FHIRPathTree

When the FHIRPath ResolveFunction resolves an internal fragment reference to a resource that is contained (or is a container) it creates a new FHIRPathTree of the resolved resource. This causes an NPE when getResourceNodes is called on a node that is in the new tree but not in the original tree.
https://github.com/IBM/FHIR/blob/cb16c9fcb7d91f1cfd5e1fbf6f9975f8de38e18e/fhir-path/src/main/java/com/ibm/fhir/path/util/FHIRPathUtil.java#L1184-L1188

Associated unit test and integration tests are sufficient.


Upgrade Quarkus to 2.0.1.Final

JIRA

Referenced pull requests
https://github.com/kiegroup/optaplanner/pull/1413

@rsynek can you review the conflicts, thanks


Refs #30116 -- Removed unnecessary str() calls in CommonPasswordValidator.

open() and gzip.open() have supported path-like objects since Python 3.6.

@jdufresne Thanks.


Fix tests and/or provide test running documentation

As mentioned in #14 and #16, I haven't been able to execute the tests successfully. To ensure continuous code quality, it would be awesome if we could accomplish some combination of:

fixing the tests to resolve any errors
fixing the implementation to resolve any errors
updating the developer setup documentation (README.md)
updating the continuous integration configuration (.travis.yml)

Most of the tests should probably live in compactnesslib, since that provides the underlying functionality to the library. We could either duplicate some of those tests here, or just target the interface between the two for testing.

Cool! I get how we could duplicate tests. I don't understand the other option yet. Do you have any advice on how we would target the interface? Maybe a best practice blog post, or a link to an exemplary project? I haven't worked on any integration between Python and native extensions before, so I'm all about the learns :)

Would it be valuable for us to duplicate a happy-path subset of the c++ lib's tests in Python? It would permit the benefit of some quality assurance on each pull request to python-mander without the burden of duplicating every test in the C++ lib. On the other hand, if python-mander is going to be a simple auto-generated thin wrapper around compactnesslib then those tests wouldn't bring much value because they'd really be testing whatever auto-generates the Python based on compactnesslib.

Sorry, I just glanced up to your older post and saw that you are on board:

We could either duplicate some of those tests here


Linter probably needs access to MDAnalysis code in many cases

Added mdanalysis to installed packages for pylint step in GitHub workflows

Fixes #47
PR Checklist

[ ] Tests?
[ ] Docs?
[ ] CHANGELOG.md updated?
[x] AUTHORS.md updated?
[x] Issue raised/referenced?

@ianmkenney tests were failing because of #49 -- I took the liberty of updating your branch with the fix to re-run tests :)


Physics no longer being returned after recent game update

Hi,
Great library BTW, thank you! Since the recent game update (16th November 2022), Physics are no longer being returned. Static and Graphics are working/reporting OK.
I have tried to having a dig through your code, but haven't been successful in getting Physics working again.
Hoping you have some spare time to take a look!
Once again, thank you!
Robert
P.S. I did notice a spelling mistake in the library, you are using headeing instead of heading but that didn't fix anything :-)

Hi,
Tanks :D
It work correctly for me, all the properties are reported to a non default value 🤷♂

Hi,
Thank you for taking the time to test. Just to confirm I am running v1.18.9 of ACC.
Even if I just attempt to print out sm.Physics.speed_kmh it only ever reports 0.0 ... I shall keep diggin'!
Thanks again :-)

Problem now resolved ... my error, I am so sorry to trouble you. Closing down the issue. Thank you for the great work!


feat: add volume control and UI slider

Implements player volume control: unsubscribes from the audio track at volume 0, and resubscribes when volume is raised above 0.
Adds a UI slider for adjusting the volume interactively.

Grabación de pantalla desde 2024-12-09 16-38-55.webm

This look great, thank you!


Improve error when unplugging the drive while its getting unmounted

This is the error I get:

Tasks:

[ ] Show a more user friendly error
[ ] Don't send the error to TrackJS

...and I guess if the drive (unexpectedly) disappears during the unmount process, then there's no guarantees that the write-buffers have been flushed and the drive actually contains the complete image :-/

Did #1301 fix this?


Add percentage support for numeral formatting

Hey, guys! Could you add percentage support for numeral formatting? It seems, that numeric formatting has all popular customization features like delimiter and decimal mark and even rarer styles like Indian and Chinese numbering group style. Awesome! I guess, that adding percentage support would rich the coverage of numeral formatting. The only thing, that I suggest is to make available to enter '%' sign at the end of a digit. What do you think? Or do you, guys, hold the opinion to leave the task of appending suffixes to developers?

As you said, I think this should be left to developers, to enter % or ‰ is a relatively high level behaviour, normally when you expect this to be done, I would rather put it as a label in the end out of th input field.
Thanks for proposing, will close this.


[#102066014] More required declaration answers

See: https://www.pivotaltracker.com/story/show/102066014
Following discussions with CCS these fields are now required in the declaration: SQ1-1b, SQ1-1d-i, SQ1-1d-ii, SQ1-1e
SQ1-1b wasn't optional before anyway, but the other three were and this makes them required.
Also fixes a small validation bug - previously using if not ... on the SQ5-2a field returned true for either None or False, but the required fields should only be added to the errors for the False case, and not for the None case.  So using is False is the right test.

👍 ship it

Rebased and just waiting for Travis...


Add notes on AppRegistry.registerComponent.

Thanks for submitting a pull request! Please provide enough information so that others can review your pull request:

Unless you are a React Native release maintainer and cherry-picking an existing commit into a current release, ensure your pull request is targeting the master React Native branch.

Explain the motivation for making this change. What existing problem does the pull request solve?
Prefer small pull requests. These are much easier to review and more likely to get merged. Make sure the PR does only one thing, otherwise please split it.
Test plan (required)
Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes UI.
Make sure tests pass on both Travis and Circle CI.
Code formatting
Look around. Match the style of the rest of the codebase. See also the simple style guide.
For more info, see the "Pull Requests" section of our "Contributing" guidelines.

Throughout the tutorial, we change the first argument to
AppRegistry.registerComponent, but we never change AppDelegate.m
or MainActivity.java to match. This leads to errors that can be
confusing to beginners.

By analyzing the blame information on this pull request, we identified @lacker and @JoelMarcey to be potential reviewers.

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at<EMAIL_ADDRESS>Thanks!

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@StevenXL updated the pull request.

@StevenXL updated the pull request - view changes

This seems like the wrong place to document this issue. People reading the Props page don't necessarily have a working installation of the tools, or know anything about the Java or Objective-C code. Also, if you run into a problem copying and pasting code, it seems unlikely you would go look at the Props tutorial page to fix it. What happens if you ignore this - do you get an error message if you cut and paste this into a project that you initially created under a different name? If so, maybe a better place to add this warning would be in that error message.

@StevenXL updated the pull request.

@lacker I'm 100% on-board that the comment's current location is not the right place to put this, but I also feel strongly that it has to go somewhere. Here's why:
If you follow the docs from the start, the first thing that we are asked to do is the following:
react-native init AwesomeProject
cd AwesomeProject
react-native run-ios

At this point in the project, both MainActivity.java and AppDelgate.m expect AppRegistry.registerComponent to be called with 'AwesomeProject'.
On the very next page of the tutorial, we are asked to update our index.ios.js and/or index.android.js. Part of that update is to invoke AppRegistry.registerComponent with 'HelloWorldApp' instead of 'AwesomeProject'.
At this point, the App breaks - AppDelegate.m and MainActivity.java are still expecting AwesomeProject.
Frankly, unless I'm missing something obvious, I'm very confused as to how beginners are getting through the tutorial.
How would you feel if I put this in the troubleshooting guide, and link to it on the next page?

@lacker P.S., the error you get would be in the simulator itself:

I expect most people are just not cut and pasting this code, and just running it on the website. But I agree it would be better if cut-and-paste simply works.
The troubleshooting guide doesn't seem great either. Basically there is no reason that someone running into this project will be on any particular page - they could be on any one of the pages that have these inline examples. Troubleshooting pages are usually not useful, because nobody is reading them when they run into trouble, they just go to Stack Overflow. Instead the error messages should just be better.
I think the ideal solution would be to change the message in the simulator to tell you precisely what is going wrong. Failing that, it's probably better to use something a bit more generic like "MyProject" in the getting-started guide, and then to use that consistently in all the examples. It's not great though because a lot of people will probably just rename their project to something other than MyProject immediately.

@lacker Does this mean we should close out this pull request and have someone actually update the actual error code thrown to the simulator instead?

@StevenXL updated the pull request - view changes

Yeah, I think updating the error seems like the best strategy. I'll close this


RuntimeError: "clamp_scalar_cpu" not implemented for 'Half'

This error occurred when I tried to run it.
/home/ubuntu/anaconda3/envs/streamdiffusion/lib/python3.10/site-packages/diffusers/image_processor.py:339: FutureWarning: Passing imageas torch tensor with value range in [-1,1] is deprecated. The expected value range for image tensor is [0,1] when passing as pytorch tensor or numpy Array. You passedimage with value range [-0.050994873046875,1.0]   warnings.warn( Exception in thread Thread-1 (_receive_images): Traceback (most recent call last):   File "/home/ubuntu/anaconda3/envs/streamdiffusion/lib/python3.10/threading.py", line 1016, in _bootstrap_inner     self.run()   File "/home/ubuntu/anaconda3/envs/streamdiffusion/lib/python3.10/threading.py", line 953, in run     self._target(*self._args, **self._kwargs)   File "/home/ubuntu/GITHUG/StreamDiffusion/examples/screen/../../utils/viewer.py", line 54, in _receive_images     postprocess_image(queue.get(block=False), output_type="pil")[0],   File "/home/ubuntu/anaconda3/envs/streamdiffusion/lib/python3.10/site-packages/streamdiffusion/image_utils.py", line 60, in postprocess_image     [   File "/home/ubuntu/anaconda3/envs/streamdiffusion/lib/python3.10/site-packages/streamdiffusion/image_utils.py", line 61, in <listcomp>     denormalize(image[i]) if do_denormalize[i] else image[i]   File "/home/ubuntu/anaconda3/envs/streamdiffusion/lib/python3.10/site-packages/streamdiffusion/image_utils.py", line 13, in denormalize     return (images / 2 + 0.5).clamp(0, 1) RuntimeError: "clamp_scalar_cpu" not implemented for 'Half'
Env:ubuntu1804
GPU:RTX3090*2
cuda:11.4

I also encountered this problem. The issue is that the CPU model does not support FP16 calculations. I switched it to FP32 calculations, and edited the error message in 'image_utils.py' in the function 'denormalize'. I added the following code:
'if images.dtype==torch.float16 and images.device.type=="cpu":                  images = images.float()
and that worked


Fix typos

Summary
Found via codespell -S ./docs/assets -L rouge,reenable
Short checklist

[x] Did you run bundle exec rubocop -a to fix linter issues?
[ ] If relevant, did you create a test?
[ ] Did you confirm that the RSpec tests pass?

Other Information
If there's anything else that's important and relevant to your pull
request, mention that information here.
Thanks for helping improve Capistrano!

:partying_face: :partying_face: :partying_face: :partying_face: :partying_face:


Detect proxy config from environment variables

Instead of using a config file, it would be nice to automatically setup proxy based the HTTP_PROXY (or http_proxy) environnement variables, like other CLI tools does (npm, bower...).
What do you think?

great idea! we should definitely do this


Makes Tailer use ScheduledExecutorService from Java 5

This has multiple benefits:

it provides periodic runs of the read operations without needing to
invoke Thread.sleep().
it removes any looping from the run() method, making for cleaner code.
generally brings Tailer closer to what modern Java looks like.

No public API changes have been made. All tests are passing without
modifications.

@triceo
May you rebase on master?

@triceo
May you rebase on master? The implementation has changed to use the builder pattern with an internal Duration instead of long to track the sleep delay. It looks like the code needs to be adapted to configure the builder with an executor.

@garydgregory I may eventually get to it, but considering that the original PR is from 2014, I have moved on.

Either it's useful or not, regardless of your moving about 😉


Spring boot +Spring MVC

I use Spring MVC. Please Create a project using Spring boot deploying in Appengine Flexible.
Thanks

Hi @magicomajid , have you looked at https://github.com/GoogleCloudPlatform/getting-started-java/tree/master/helloworld-springboot ?

@magicomajid Please checkout the tutorial : https://github.com/GoogleCloudPlatform/community/tree/master/tutorials/run-spring-petclinic-on-app-engine-cloudsql.
We hope to add more soon.


SSO authentication module - RemoteUser

Bespoke authentication module 'RemoteUser' uses HTTPServletRequest.getRemoteUser() to acquire username from tomcat after user has been authenticated by SSO.
Point your SSO at /repository/remoteuser-login
Added files:
dspace-api/src/main/java/org/dspace/authenticate/RemoteUserAuthentication.java
dspace-xmlui/dspace-xmlui-api/src/main/java/org/dspace/app/xmlui/aspect/eperson/RemoteUserAuthenticateAction.java
dspace-xmlui/dspace-xmlui-api/src/main/java/org/dspace/app/xmlui/aspect/eperson/RemoteUserLogin.java
Modified files:
dspace-xmlui-api/src/main/resources/aspects/EPerson/sitemap.xmap
dspace-xmlui-webapp/src/main/webapp/sitemap.xmap
System changes: add the parameter tomcatAuthentication="false" to the ajp connector in /opt/tomcat6/conf/server.xml
Tested and working in Dspace 1.8.2

Closing as outdated/obsolete. Please resubmit if you are interested in helping move this forward. Thanks!


Vue 2 + Typescript + multiple types for props

Version
2.6.14
Reproduction link
https://github.com/vuejs
Steps to reproduce
When working with Vuejs v2.6.14, typescript version without decorators, I noticed that you cannot use multiple types (nor union types) for a prop type definition. Tried lots of alternatives, but always got the same error "Expected String with value '...', got Number with value '...'
E.g.: for a prop named title:
type: String || Number => doesn't work because the String constructor will always be truthy
type: String as PropType<String | Number> => sees only String as a type for the title prop
type: [String, Number] => not working as well
type: => tried creating a union type as well, but failed.
type: string | number => error: "a constructor is expected"
What is expected?

prop type should allow union types or multiple types
you can set "any" type to a prop

What is actually happening?

you cannot have more than one different type for a prop
you cannot set prop type to "any"

It cannot be reproduced via fiddle

Hi, thanks for your interest but Github issues are for bug reports and feature requests only. You can ask questions on the forum, the Discord server or StackOverflow.

Hi @posva, this a bug report, can you please reopen the ticket? Thanks!

Use as PropType<string | number>.
Please, next time consider using the forum, the Discord server or StackOverflow for questions first. But feel free to come back and open an issue if it turns out to be a bug 🙂


"\stampinf.exe" is invalid with error MSB6004

Alright, so I've attempted to compile the mapDriver solution in VS15, and every time I do, I get an error that stampinf.exe is invalid.
I have the WDK v. 1703, and I'm not sure how to link stampinf.exe to it correctly.
Google wasn't any help as everyone says to restore older versions of the WDK (which I did) and it still doesnt seem to work.
This seems to be my only issue, and once its linked it looks to be able to build properly.
Any pointers on how to link it?

More detailed instructions on exactly what build tools in VS15 and VS17 are needed would be appreciated, unless I've overlooked something somehow.

As a side note, I used VS 2015 with Update 3. I'm going to try each of the other 2015 versions to see if it solves the issue.

Looking more into it, it seems that VS15 is looking for a stampinf.exe in
C:\Program Files (x86)\Windows Kits\10\bin\10.0.15063.0\arm
to which there isn't one.
I'm not super advanced into the WDK so I'm not sure if I should find/copy a new one, or change the entire configuration to one that has stampinf.exe, which doesn't exist in any.
Do I have the correct WDK? If not, which version includes stampinf.exe?

I am dumb.
"\stampinf.exe" is invalid because I can't find how to change the directory for where stampinf.exe should be.
Am I missing something here?

Are you trying to build for the ARM instruction instead of x64? :) If so please don't ask any help here anymore.

Nope, I was compiling for x64. I checked inside that folder where it should be, but it wasn't there. Is there a specific version of the WDK that has it?

I'm assuming it cant find it because it doesn't know where to look, although I cant find how to point it, and to which version. In your instructions, you said the VS15 should have the WDK installed, and I have, but looking in the folders for stampinf.exe, it simply does not exist. (C:\Program Files (x86)\Windows Kits\10\bin\10.0.15063.0\x64)
In the WDK that is compatable with VS17, however, it does: C:\Program Files (x86)\Windows Kits\10\bin\10.0.16299.0\x64
Although this is the case, I expect the error to be around why its presumable searching for stampinf.exe in the root folder: "error MSB6004: The specified task executable location "\stampinf.exe" is invalid."
I just really need to know what WDK version you used, because mine doesn't seem to have it, and how to point it towards the stampinf.exe.
Like I said, I'm not well versed in the WDK, and my main focus in C++ was simple tasks (I'm more of a Java guy)

It also exists in the folder right above it, without going into a version:
C:\Program Files (x86)\Windows Kits\10\bin\x64
Filesystems from Microsoft are always confusing to me :/

I attempted copying the existing stampinf.exe to the root folder, but the same error occurred, making me think that somewhere in the WindowsDriver.common.targets file at C:\Program Files (x86)\Windows Kits\10\build it has the rest of the filepath.
I'm just a bit confused as to where the error is coming from, as that file doesn't do anything other than call the function. No filepath. :(

I understand the instructions are basic and vague to kids with no coding experience trying to just grab a free cheat, but I'm personally trying to find where this thing is coming from and the farther I go into it the more confused I get.
Also sorry for all the comments, maybe there's an easier way of contacting you for assistance?

Also, in the hackControl solution, I linked the library but it's not accepting the link.
I should be linking through the Linker Input, right?

How is it not accepting the link?

My apologies, I didn't get an email notification that you commented like I did last time.
I put in the directory through the Linker Input, but it's not doing anything, like it never was linked.


[incubator/kafka] Makes persistence fully configurable

Mimics stable/postgresql and makes persistence fully configurable.
Motivation
We create Kafka StatefulSets during CI on AWS.
Due to the high frequency with which we were creating volumes, EBS wound up getting stuck very frequently.
This change allows us to sidestep the issue by relying on kubelet host volumes.

/signed-cla

signed CLA

/assign @mattfarina

/ok-to-test

/assign

/lgtm


Producer trying to connect to MSK Cluster using Lambda function but, "[BrokerPool] Failed to connect to seed broker, trying another broker from the list: Connection timeout"

Please help @tulios @Nevon @meister @Dieken @pihentagy
When trying to connect to MSK cluster through a Lambda function, it shows below error.
{     "level": "ERROR",     "timestamp": "xxxxx",     "logger": "kafkajs",     "message": "[BrokerPool] Failed to connect to seed broker, trying another broker from the list: Connection timeout",     "retryCount": 0,     "retryTime": 350 }
ERROR	{     "level": "ERROR",     "timestamp": "xxxxx",     "logger": "kafkajs",     "message": "[Connection] Connection timeout",     "broker": "b-1.xxxxx.xxxxx.xxxx.xxxxx.xxxxx-xxxxx-xxxxx.amazonaws.com:9094",     "clientId": "my-app-1" }
I have tried accessing the brokers through plaintext, IAM and TLS authentication types but every time it gives the same error after 6seconds timeout.
My code snippet for Kafka producer (here brokers are given in TLS format):
`const clientId = "my-app-1";
const brokers = [b-2.xxxxmskcluster.xxxxxx.xxxxx.xxxx.xxxx-xxxxxx-xxxxxx.amazonaws.com:9094, b-1.xxxxxxmskcluster.xxxxx.xx.xxx.xxxx-xxxx-xxxx.amazonaws.com:9094];
const topic = "AWSKafkaTopic1";
const kafka = new Kafka({
clientId,
brokers,
ssl: true,
});
const producer = kafka.producer({
retry: 5,
idempotent: true,
transactionTimeout: 10000
});
await producer.connect();`

I was missing some configuration criteria

@dilshan-98 What criteria exactly were you missing ? I am having the same error so I am curious if I am missing something.


backlog parameter

In src\os\unix\listener.rs:88~92
        // FIXME the standard library uses 128 here without an option to change this
        // number, why? If std has solid reasons to do this, remove this notice and
        // document the method's behavior on this matter explicitly; otherwise, add
        // an option to change this value.
        c_wrappers::listen(&fd, 128)?;

The size of the accept queue is equal to min(SOMAXCONN, backlog), by default SOMAXCONN=128.
SOMAXCONN: socket max connections, man page.

Interesting find, but it makes it even more confusing how the standard library just puts a fixed value of 128 there. In this case, I'd like to introduce an optional parameter to specify the value for exotic use cases where SOMAXCONN is raised via /proc/sys/net/core/somaxconn and the server program depends on the increased backlog.


[cinder-csi-plugin] implement structured logging

What this PR does / why we need it:
implement structured logging KEP 1602
CSI plugins often use common values like node name, volume name, volume ID, and instance ID in unstructured error and log messages. This makes it hard to group and sort them. I want to change these logs to structured logs, as the core Kubernetes team has decided to move in this direction
Current logs:
CreateVolume: Successfully created volume 47d323fd-b06c-424e-b27b-d27db2fb2c5c in Availability Zone: nova of size 10 GiB

Structured logs
"Successfully created volume" func="CreateVolume" volumeID="228d4464-48a2-4a45-81a7-24d3d0a1862a" size=10 zone="nova"
"Successfully detached volume" func="ControllerUnpublishVolume" volumeID="228d4464-48a2-4a45-81a7-24d3d0a1862a" instanceID="89e33913-0cce-4c1a-be2f-4e6a39d32b51"
"Successfully deleted volume" func="DeleteVolume" volumeID="228d4464-48a2-4a45-81a7-24d3d0a1862a" cloud=""

Default log keys:

func- name of function, example CreateVolume
size - volume size
volume - volume name
volumeID - volume ID
snapshotID - snapshot ID
instanceID -  instance ID
zone - availability zone
cloud - cloud config

Which issue this PR fixes(if applicable):
make sense after  #2640
Special notes for reviewers:

Release note:

NONE

@sergelogvinov thanks for the PR. Please add more context in the PR description, e.g. how logs will look like comparing to old style. Also its worth to add this link for the context https://github.com/kubernetes/enhancements/blob/master/keps/sig-instrumentation/1602-structured-logging/README.md#new-klog-methods
The release notes are must have for such changes.

@kayrus Whenever you have a moment, could you please take a look at this?


Updated to @actual-app/api to 6.3.0 in package.json.

Weird, can you try deleting the lock file and running install again ?


ExtractorError: requested format not available

Checklist

[ ] I'm reporting a broken site support issue
[x] I've verified that I'm running youtube-dl version 2020.03.24
[x] I've checked that all provided URLs are alive and playable in a browser
[x] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[x] I've searched the bugtracker for similar bug reports including closed ones
[x] I've read bugs section in FAQ

Verbose log
~ ❯ youtube-dl -J -flat-playlist -v  https://www.youtube.com/user/RedLetterMedia
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: [u'-J', u'-flat-playlist', u'-v', u'https://www.youtube.com/user/RedLetterMedia']
[debug] Encodings: locale UTF-8, fs utf-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2020.03.24
[debug] Python version 2.7.16 (CPython) - Darwin-19.4.0-x86_64-i386-64bit
[debug] exe versions: ffmpeg 4.2.2, ffprobe 4.2.2, rtmpdump 2.4
[debug] Proxy map: {}
ERROR: requested format not available
Traceback (most recent call last):
  File "/usr/local/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 808, in extract_info
    return self.process_ie_result(ie_result, download, extra_info)
  File "/usr/local/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 863, in process_ie_result
    return self.process_video_result(ie_result, download=download)
  File "/usr/local/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 1636, in process_video_result
    expected=True)
ExtractorError: requested format not available

Description
youtube-dl -J -flat-playlist -v  https://www.youtube.com/user/RedLetterMedia

This command used to work a couple of days ago without issue.
I'm using the same youtube-dl version (latest).
I've tested with different IPs on Mac and Linux.
I found this issue https://github.com/ytdl-org/youtube-dl/issues/1667
I tried running:
youtube-dl -J -flat-playlist -v --ignore-errors https://www.youtube.com/user/RedLetterMedia

looks like it throws the errors for all videos?
youtube-dl -J -flat-playlist -v -f 37/22/18/best https://www.youtube.com/user/RedLetterMedia

the command never exit

never mind. wrong syntax on my part


Remove unused kubeversion

Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Odd behavior on this PR, so I created https://github.com/aws/eks-anywhere-packages/pull/133


Delete New-NetworkControllerNetworkInterfaceIpConfiguration.md

This PowerShell command no longer exists.
PR Summary

PR Checklist

[ ] Descriptive Title: This PR's title is a synopsis of the changes it proposes.
[ ] Summary: This PR's summary describes the scope and intent of the change.
[ ] Contributor's Guide: I have read the contributors guide.
[ ] Style: This PR adheres to the style guide.

@tiburd
PR has been copyedited and is ready for final review, could you please check and merge? Thanks!

@wu-lily
Apologies for the delay - if you still want to submit this pull request, please complete the checklist at the top, and then @ mention me.
Thank you!


[angular] Fix issue where Angular is asking about the validity of form components, when the connectedCallback hasn't been called yet

Report by the MAX team.
We should check if connectedCallback has been called yet and assume the component is valid if it hasn't.
### Tasks
- [ ] waiting for max online, is it solved on their side?
- [ ] contact max online (what is he status?)

Now that https://github.com/sl-design-system/angular-demo/pull/5 has been merged, the angular demo app contains examples of dynamic forms. I haven't been able to reproduce the issue there. Until we are able to reproduce it there, I'm closing this.


Management Server HA

ISSUE TYPE
 Other

Bug Report
Improvement Request
Enhancement Request
Feature Idea
Documentation Report
Other

COMPONENT NAME

etc

CLOUDSTACK VERSION

4.18

CONFIGURATION

OS / ENVIRONMENT
Ubuntu 22.04
SUMMARY
 Ubuntu server was installed kvm and in kvm i create cloudstack management, sql, nfs, dns server. I want to get HA of all this kvm vm when one of my ubuntu server was failed. I configured with pacemaker, corosync and pcs and i shutdown my server but it not automatically migrate and run to another server.
Storage server mount on /var/lib/libvirt/images and /etc/libvirt/qemu. Both servers can access cs.xml and cs.qcow2.
STEPS TO REPRODUCE

EXPECTED RESULTS

ACTUAL RESULTS

Hi @HtainL  what are you trying appears to be outside Cloudstack, not a feature of Cloudstack itself. Cloudstack can work fine even if one of the management servers goes down. For DB HA you could try the DB HA feature within Cloudstack but it seems to have some issues. Another option is using a Galera Cluster.

This is outside the scope of CloudStack; we already support HA by having a cluster of mgmt server and by design we allow multiple mgmt servers that can take over resources management (vms, hosts etc) when the owner mgmt server is Down.


Not able to experiments from chaoscenter Issue started today on 31st march

What happened: I was able to run experiments till yesterday , today it has stopped running. Its not throwing any error but not showing results
What you expected to happen: Scenarios to be run and show results
Where can this issue be corrected? (optional) Chaoscenter

How to reproduce it (as minimally and precisely as possible): Its reproducible
Anything else we need to know?: when creating work flow directly in kubernetes cluster its showing result in chaos center and shows experiment running and completing and its working. But logs are not generated. till yesterday everything was fine
Chaos version Version is 2.14.0
Also today its throwing below error
very frequently
Handling connection for 9091
E0331 15:58:20.333160     840 portforward.go:362] error creating forwarding stream for port 9091 -> 8080: Timeout occured
E0331 15:58:20.333160     840 portforward.go:362] error creating forwarding stream for port 9091 -> 8080: Timeout occured

Hi @SonalJain1707, Looks like it's a n/w issue.

Please re-open the issue if you are still facing this.


Add installation from homebrew

Add a way to install this package directly from homebrew (for macOS)

I don't have any use for this (or interest).  But I believe that (at least one of) the original authors may use the macOS.  In the meantime, can't you use pip on a mac?

It's an open feature request for who's willing to implement.
Mostly it's for me :)

On 30 Dec 2018, at 20:03, Joshua Crowgey<EMAIL_ADDRESS>wrote:
I don't have any use for this (or interest). But I believe that (at least one of) the original authors may use the macOS. In the meantime, can't you use pip on a mac?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/insanum/gcalcli/issues/394#issuecomment-450576963, or mute the thread https://github.com/notifications/unsubscribe-auth/ABk1jEx9TWYr3Fj2r3mbMGAIgyFsW5yxks5u-P_2gaJpZM4ZTjtF.

I'd be interested in this as well.  Pip does work for now, but I prefer to manage apps through homebrew as much as possible and keep my Python envs clean.

I think that homebrew is some sort of package manager for mac OS.  I'm happy to have gcalcli in as many package managers as possible--that's fine.  But from what I can tell, this issue belongs downstream from here.  I can keep it open if mac OS users want to track status here, but I don't think there's actually any work to be done in this repo, is there?

FYI, working on the homebrew formula: https://github.com/Homebrew/homebrew-core/pull/62935
Once merged, I will update the installation doc to reflect the additional installation method.


F-Droid

Is Aves on the F-Droid official?
https://f-droid.org/packages/deckers.thibault.aves.libre/
If yes, why didn't you release the app with the original package?
I also want to know how it differs from the IzzyOnDroid version?

Yes it is. See the discussion here:

#29

See the wiki for version comparison.


Remove unused fields_prefix

This was used when we had some logstasher log fields prefixed with @fields (so @fields.duration, @fields.action, @fields.controller etc.), and some which have no prefix.
We started fixing this and trying to align on having no prefix back in Jan 2018 (https://github.com/alphagov/govuk-puppet/pull/6658). This should now be complete as of https://github.com/alphagov/search-api/pull/42, so we can remove references to the prefix that allows us to manage the convergence.
cc @surminus

I approve.

This is an enormous deal for me

How time flies!

Thanks all!


id number for India

https://en.wikipedia.org/wiki/National_identification_number#India

https://archive.org/details/Aadhaar_numbering_scheme/page/n12/mode/1up?view=theater


smart cities reading

Hi Nic--
A reminder as discussed- please send me any recommended readings on smart cities. Thanks!

A few recommendations:

This is a good primer / overview https://mitpress.mit.edu/books/smart-cities (if you want to "download" you can find a copy here http://libgen.is/search.php?req=smart+cities+Germaine+Halegoua&open=0&res=25&view=simple&phrase=1&column=def )
I like this article thinking about smart cities as a failed concept -  Sadowski, J., & Bendor, R. (2019). Selling smartness: Corporate narratives and the smart city as a sociotechnical imaginary. Science, Technology, & Human Values, 44(3), 540-563.  https://journals.sagepub.com/doi/pdf/10.1177/0162243918806061?
And Bianca Wylie is usually a good read on all things smart and civic tech Wylie, B. (2018). Searching for the smart city's democratic future. Centre for International Governance Innovation, 13. https://www.cigionline.org/articles/searching-smart-citys-democratic-future/


Match filenames using regex filter

Sorry, I didn't know where else to post this. I'm having difficulties matching files with the regex filter and was hoping you could help.
I have a number of binary files with a particular naming structure that need to be renamed on my server. Specifically, I would like to add the flac extension. An example of such a file might be AEQ3RT~1 - containing exactly six characters of A-Z0-9, a tilde, and exactly 1 character A-Z0-9
Currently, I'm doing this but nothing matches:
'^RG([A-Z\d]{6})~([A-Z\d]{1})'
How can I capture the above filename? Hope that made sense.

Hi there, so sorry - I seem to have tripped onto the answer. This works for me:
(?P<name>[A-Z\d]{6})~([A-Z\d]{1}) letting me rename the file as {regex.name}.flac.
Thanks for your amazing work on this. I use it everyday!

Oops, sorry - spoke too soon. It doesn't seem to match files without an extension. Is there something I'm missing? Thanks again.


Issue with guide example

Hey, loving ldapjs so far, its definately been making learning and setting up ldap a lot more clearer than using slapd directly. Anyways just noticed there is a mistake in the examples located at http://ldapjs.org/guide.html. The examples look for a cn property in rdns[0]
i.e.
req.dn.rdns[0].cn

but they should be looking for it in rdns[0].attrs
i.e.
req.dn.rdns[0].attrs.cn

Other than this the documentation is a huge improvement over the slapd docs I've seen out there. Thanks for putting this together!

👋
On February 22, 2023, we released version 3 of this library. As a result, we are closing this issue/pull request.
Please see issue #839 for more information, including how to proceed if you feel this closure is in error.


PySpark DataFrame Support

Native Support for rendering visualizations for PySpark data frame in the Jupyter notebook.
It is OK to introduce some constraints if the sheer size of the data frame makes it difficult to load.

Hi, How size(row count, column count, data szie) is your data?
pygwalker will support bigger datas(<= your computer memory size) in future version.

1M rows, approximately 200 columns (mix of float and categorical values).

Pygwalker will support pyspark within the next 4 versions.

version 0.3.3 already support pyspark.dataframe , but calculation process of spark not suitable to get datas for render charts.
If the dataframe(spark) you end up needing to analyze doesn't exceed three times your machine's RAM, you can convert to pandas.dataframe: df = spark_df.toPandas(),
then use duckdb to calculation datas in pygwlaker: pyg.walk(df, use_kernel_calc=True)

Pygwalker will support pyspark within the next 4 versions.
@longxiaofei Is this still in plan?

@rishabh-dream11 Dataframe of pyspark is currently supported, but pyspark is not suitable for this kind of interactive calculation.


Support remote snapshotter to speed up image pulling

Among the container's lifecycle, pulling image is one of the biggest performance bottlenecks on container startup processes. One research shows that time for pulling accounts for 76% of container startup time[FAST '16].
I know there is discussion on #2943, but it seems nobody got started the implementation? To make this progress, I implemented a patch based on the discussion with an example implementation of a remote snapshotter. Through the implementation, I found challenges around metadata snapshotter and namespaces so I fixed the design to achieve it. Could anyone give comments on it?

Remote Snapshotter patch: remote-snapshotter branch
Example implementation of remote snapshotter: /snapshotter.go

The overview of the design and implementation
The whole picture is described here.
To make containerd work with remote snapshotter, it needs to:

Skip downloading layers which can be prepared without downloading contents by a remote snapshotter(I call it remote layers here).
Make remote snapshots without "Unpack" operation.
Make the snapshot work with metadata snapshotter so that containerd can bind these snapshots to namespaces

I think we can achieve it by introducing additional filter(Fig 1) during the fetching process(in the Client.fetch method). Currently, there are already some filters in the method, so adding a new filter seems relatively easily.

The filter takes lists of download candidates(blobs) and checks if each one and the lower layers are remote layers.
If so, it filters out the layer from the download candidates and makes the snapshot as a remote snapshot.
Containerd doesn't unpack layers if the layers already exist as snapshots, so we can avoid unpacking them.

The filter talks with remote snapshotters to know whether a layer is a remote layer(Fig 2).

The filter Stat() the layer with ChainID of the layer.
If the snapshot doesn't exist, the filter attempts to Prepare() the layer as a remote snapshot.
If possible, the remote snapshotter prepare an active snapshot with applying a label "RemoteSnapshotLabel" automatically.
The filter Stat() the active snapshot to check if it is a remote snapshot by seeing the label.
Only if the snapshot has the label, the filter Commit() it immediately and filter out this layer from the download candidates.
If the snapshot is a remote snapshot, the snapshotter mounts the remote unpacked layer on the snapshot and commits it.

Question
I'm really keen to make the remote snapshotter real. The capability to boot containers without pulling is great.

Cloud I get your comments on the design and implementation? Is it acceptable for containerd?
If not, are there any considerations? Or are there possible alternative designs?

The tools have been there for a long time now. It's hard to find what makes sense to contribute and get people to agree to it here because there are so many different scenarios.

I think we can achieve it by introducing additional filter(Fig 1) during the fetching process(in the Client.fetch method). Currently, there are already some filters in the method, so adding a new filter seems relatively easily.

Seems OK. Ultimately the registry should tell whether or not it has something available as a decompressed/remote layer. In either case, it's up to the client to do this interaction and decision - there's not really a standard for this across registries.
When you make the snapshots, you can only create metadata. They should be more or less no-ops that just facilitate creating the DAG. When the RW layer is being created, you should do the actual mounts. The reason for this is because there's no daemon or way to know whether or not the remote block drive is mounted. At run time they have to be mounted no matter what, otherwise the container will crash. Just doing it at a commit isn't enough. Try a machine restart when you have all the metadata on disk and see if your design works.
Also, I made the snapshot label passing PR specifically for this problem initially. Another issue with it is you'll need credentials for any real remote device and you don't want these stored in boltdb. And again, how will you support rotating creds, etc. after caching.

Can you comment on the design/steps in #2968? I think that was the outcome of earlier discussions as the main core containerd change required to get this work moving.
I'll let @dmcgowan comment in case there was another issue I'm not finding. I know we tried to open up some issues to drive the work/todo list as we had a contributor interested, but that fell through.

I think the problem last time was finding what made sense to contribute for a framework. It's already possible to do it all, so what would you PR in? Just the client opts and a specific remote filesystem snapshotter?
The client interactions aren't a standard on any registry. Maybe adding some kind of filter options make sense, but they aren't totally usable on their own. You have to have some external process creating all the mounts, providing the client information that it has to skip the mounts, etc. Or the snapshotter itself has to do the mounts so it's case by case.
Originally I made https://github.com/containerd/containerd/pull/3055 just to enable the second scenario, but there are a lot of problems with it when you start using actual credentials. You don't want them to be cached in boltdb. How do you rotate creds, make sure they aren't expired, etc.
 Does it make sense to put NBD, CIFS, NFS, x, y, z all in one?
Then, how do you achieve resiliency in a generic way, to ensure the mounts are available when the container runs, i.e. after a system restart. Does it make sense for the snapshotter to do that, i.e. right before creating the RW layer?

The client interactions aren't a standard on any registry.

@dmcgowan mentioned that the client interaction can make sense for reusing existing snapshots across different namespaces, which could be useful for buildkit.

The idea was to minimize the new interactions which needed to take place between the client and the snapshotter. Generally this could be solved by attempting to Prepare a layer before attempting a fetch. The Prepare method could be used to pull "already existing" (from the backend remote snapshotter perspective) snapshots into the namespace, however this would still be a new interaction with snapshotters and needs to be defined.

@ehotinger Thank you for your comments.

what would you PR in? Just the client opts and a specific remote filesystem snapshotter?

I don't intend to make the PR immediately. Before that, I thought that I need to hear mentainer's opinion based on the code above so I opened this issue. After that, I intend to make PRs:

A new filter to skip downloading layers for which remote snapshotters say to do.
The client options to turn on the filtering.
The remote snapshotter implementation which is backed by normal docker registry using stargz format which is compatible with current docker images.

The client interactions aren't a standard on any registry.

As others mentioning, "Preparing a layer before fetch" idea makes sense as standard client interaction and my design is also based on it. I think it is a reasonable separation of responsibilities that:

the "case-by-case" parts are in the remote snapshotter, and
containerd has responsibilities to skip downloading layers, make remote snapshots and ensure the existence.

'check if something exists', but then the mounts themselves are maintained out of band from containerd so you need something extra.
how do you achieve resiliency in a generic way, to ensure the mounts are available when the container runs

I think ensuring the mounts being available is snapshotter's responsibility. If the snapshotter finds a layer is no longer available, it should return errors on Prepare(). But I think that we need to discuss containerd's behavior on the failure of Prepare() i.e. during creating the rootfs's RW layer.

credential

As discussed in #2968, I think using label to pass the credential down makes sense. But I think we need something for expiration and rotation etc.

Generally local disk outperforms network so the metadata has to be per-layer and snapshotters need to re-use existing snapshots. And there's cases where you may want to choose network over local disk too.

I think it is a nice feature but is it must be in scope at the current stage? I think the performance-related things are the snapshotter's responsibility and the containerd core doesn't need to care about it.
Considering the above, I think current issues are:

containerd side:

The way to manage credentials i.e. expiration, rotation, etc.
resiliency: The containerd's behavior on the failure of Prepare() i.e. during creating the rootfs's RW layer. (re-fetch or something?)

snapshotter side:

credential management
performance
resiliency: ensuring the mounts are available

I think we can just let the remote snapshotter plugin to deal with the credential (typically via ~/.docker/config.json) and call it for a day.
In future, maybe we can consider porting over BuildKit session so that the daemon-side plugin can invoke gRPC requests against the client to fetch credential.

@ktock thanks a lot for putting this together. This is great! I have a question regarding the layer filter. Is there a technical reason why a layer can only be taken from remote when all lower layers are also remote?

@lukasheinrich Thank you for your question!
The reason is the following:

To Prepare() a snapshot, it requires the parent snapshot in advance.
But unpacking layers doesn't occur before filtering contents in the current containerd.

For example, assume that the filter is creating a remote snapshot. If the parent layer isn't a remote layer the filter needs to download and unpack the parent contents and make the parent snapshot before it makes the target snapshot because Prepare() requires parent layers. But currently unpacking are separated from filtering as mentioned in Fig 1 above ("filtering" -> "downloading" -> "unpacking").
Of cause by implementing the downloading+unpacking in the filter we can achieve it but a little bit strange cases can occur like that many layers are downloaded+unpacked during filtering before the Unpack() is actually invoked i.e. when the top-most layer is only one remote layer and all others aren't.
Considering above, the restriction "a layer can only be taken from remote when all lower layers are also remote" made sense for me. Are there any cases that the restriction is critical? I think most images usually have bigger layers in the lower layers so even if the restriction is applied we can skip downloading large parts of an image.

It's very exciting to see all the effort and ideas here. This is great.

As others mentioning, "Preparing a layer before fetch" idea makes sense as standard client interaction and my design is also based on it. I think it is a reasonable separation of responsibilities that:
the "case-by-case" parts are in the remote snapshotter, and
containerd has responsibilities to skip downloading layers, make remote snapshots and ensure the existence.

As others mentioning, "Preparing a layer before fetch" idea makes sense as standard client interaction and my design is also based on it.

Sounds totally reasonable to me. But, the reason I brought this up is containerd isn't standalone when you do this. You always need custom stuff on top of containerd on a per-project basis. For example, how will you integrate this with CRI? It would be nice if I could just use a remote snapshotter with stargz, CIFS, NFS, whatever, and go through the same exact flow we have today.

I think we can just let the remote snapshotter plugin to deal with the credential (typically via ~/.docker/config.json) and call it for a day.

I don't think the concern is where this metadata is stored. It can be anywhere. I personally like it being associated to layers because then you can have different credentials for each remote layer on a per layer basis and potentially use different sources and you aren't coupled directly to username/password/token (it can be easily expanded upon), but this does increase complexity. Let's focus on the interaction model. Prepare fails, cred expired from , do I need to login to a registry (stargz), get creds somehow for NFS, CIFS, etc.? Do I need to take these actions every time right before I run a container, etc.

I placed this issue in the 1.4 milestone as it's a large focus for us and the community. :)

My WIP of this is here https://github.com/dmcgowan/containerd/tree/prepare-snapshot-target
Mostly just figuring out the metadata store side right now and making sure it is backwards compatible.
Basically it allows an ErrAlreadyExists to be returned when passing in containerd.io/snapshot.ref. The backend snapshotter may also return that and the metadata store will handle it by calling a stat to get the snapshot info then adding it to the metadata store. The ErrAlreadyExists will be returned to the client at that point to re-check whether the target snapshot is already there.

@dmcgowan Thank you very much for your work on the metadata snapshotter.
This can reduce the complexty of the filter side because it can make a remote snapshot simply only by Prepare() without Commit().
One question:

On filter side, it needs to check if a committed snapshotter is a remote snapsot or not. Can this be done by checking the label containerd.io/snapshot.ref?

@ehotinger Thank you for your comments.

It would be nice if I could just use a remote snapshotter with stargz, CIFS, NFS, whatever, and go through the same exact flow we have today.

Currently, this filter and snapshotter implementations don't require additional actions on cases except following:

Source preparation: Setting up the remote store(NFS, CVMFS, etc...). Converting images on the registry(stargz, etc...).
Setting an option to turn on the filter(but I think we can make the filter enable by default because it is backwards compatible)
creds(auth)-related events

I think the source preparation is indispensable and each snapshotter's matter so the consideration here is "creds(auth)-related events" as you mentioned:

Prepare fails, cred expired from 'generic network file system', do I need to login to a registry (stargz), get creds somehow for NFS, CIFS, etc.? Do I need to take these actions every time right before I run a container, etc.

The way of auth-related things are very case-by-case depending on the remote snapshotter(store) and it is hard to find a general way to do it.
At the current stage, I think the reasonable solution will be:
Introducing a new error which indicates "Authentication Failed" and users deal with the error(updating the creds, etc.) using tools or following the way specified by the spanshotter.
In the future, we can integrate these processes as plugins into containerd if necessary.

@dmcgowan
How about your WIP on metadata snapshotter mentioned here?:smile:
Recently I integrated your metadata snapshotter with my filter implementation and remote snapshotter. It seems to work fine! Do you have any plan for your metadata snapshotter?

The patch of containerd: remote-snapshotter-target branch
Example implementation of the remote snapshotter: prepare-snapshot-target branch

You can try the demo as written in the README

I have a few questions and I wonder what people's thoughts are:
1) What types of remote snapshotters are we looking to support?
I'm imagining two classes:

read-only
read/write

What would be the scope of each type. ie. for r/w does a local commit propagate to the remote?
2) For surfacing read-only data is using the snapshotter interface appropriate?
Looking at the remote-snapshotter I saw it's using overlayfs and the 'remote' fs is pluggable. That's great. But if I wanted to use a different union fs (ie. btrfs) does that require me to write another remote snapshotter?
Prior when I spent some time looking at this I thought leaving the snapshotter's alone and for the read-only case do a lookup using X prior to pull the layer. If X has the layer content it can be bind mounted in. Other options would be to chain snapshotters together like HTTP middleware - which would change the Snapshotter interface again.

@ktock I am working on the unit tests now. I stopped to get the filters branch in so I could use that. Thank you for testing it out!

@dprotaso

What types of remote snapshotters are we looking to support?

I think the initial scope is "read-only" but it is possible to include the "write" support in future works.
The ways to propagate local changes to remote are very different among filesystems so I think it is remote-snapshotter's responsibility (rather than the core of containerd). And I think it isn't impossible for remote-snapshotter to enable to propagate changes on Active snapshot to remote on each Commit() using each filesystem-specific protocol.

For surfacing read-only data is using the snapshotter interface appropriate?

But if I wanted to use a different union fs (ie. btrfs) does that require me to write another snapshotter implementation?

Yes, currently you need to write your own implementation but you can reuse "remote" fs plugin for filesystem-specific parts.
I also think it's great for remote-snapshotter to support a kind of "union fs plugin".

Secondly, I wonder if it makes sense to integrate it as a look aside remote cache.

It sounds reasonable to me but the integration cost seems higher than simply adding "filter" and plugging remote-snapshotter into containerd. I would also like to hear mentainer's opinion here.

just noting some developments from azure:
https://stevelasker.blog/2019/10/29/azure-container-registry-teleportation/
https://twitter.com/lukasheinrich_/status/1189794453365645312
@SteveLasker are there any plans to integrate that solution with what's discussed here?

The Teleport work was initially started on Moby as we wanted to get this out last year. That became too problematic as there weren't enough extension points in moby to have a clean implementation, so engineering convinced us to move to a containerd solution.
That said, we're still refactoring some of the changes to align with the containerd snapshotter and we likely would have some PRs to do cleanup on our side.  As @ehotinger mentions, the implementations are very cloud specific, as we each have varied storage, auth and networking solutions. If you look at the various registry implementations, we all follow the distribution-spec, but each have unique implementations. This is the beauty of the distribution-spec design.

See #3793 for change to core. Client changes to leverage this will be next.

I posted idea of the client changes on #3846 to enable to skip downloading layers which can be provided by backend snapshotter. Could you give comments on it?
Further additional failure handling on client-side for better resiliency will be next.

This is really fantastic, many thanks!
I'd have two questions:

How do you see the remote file system plugins of the remote snapshotter (CernVM-FS, NFS, etc.) being deployed? Can this be a plugin container, bundling the file system client and whatever else is required?

Can multiple remote file system plugins be active concurrently, and if so, can we decide which one gets priority for serving a layer (e.g. first CRFS than NFS)?

@jblomer Thank you for your great questions! So far, there hasn't been enough discussion about these topics so I would like to hear other's opinion as well, but my opinion is the following.

How do you see the remote file system plugins of the remote snapshotter (CernVM-FS, NFS, etc.) being deployed? Can this be a plugin container, bundling the file system client and whatever else is required?

Remote snapshotter sees filesystem plugins which are plugged into containerd. A current example implementation is a binary plugin and is loaded by containerd during runtime. Socket-based plugin which can be deployed as a container should be recognizable (but I haven't tried)

Can multiple remote file system plugins be active concurrently, and if so, can we decide which one gets priority for serving a layer (e.g. first CRFS than NFS)?

I think these kinds of operations need to be possible. Currently, the example implementation can recognize multiple file system plugins but the priority is undefined.

I posted a new patch #3911 about image information propagation to snapshotters, which is indispensable for remote snapshotter to search proper layers on the remote store(registry, etc.). Could you give comments on it?

FIY: New discussion thread is at containerd/project#43 . We are very welcome for your opinion/feedback!

I posted a new patch #4044 to enable using remote snapshotters without forcing snapshotter users to import snapshotter-specific handlers to the codebase.
The patch is indispensable for wide adoption of the remote snapshotter. Could you give comments on it?

https://github.com/containerd/stargz-snapshotter :tada:


Remove isident/iskeyword local definition in avra.vim syntax file

Requested change in the original addition PR for avra.vim #439
Tested with local avr assembly files and seemed to work just fine without those local definitions.

That is a good suggestions. However, recent Vims learned about the syntax iskeyword command, that can be used to set the 'iskeyword' for a specific syntax file, so it would probably make sense to convert the :setlocal iskeyword setting to :syntax iskeyword commmand.
Having said that, have you contacted the maintainer of the file?

I think he is the maintainer.

Thanks.  I'll also add a "last update" item in the header.


ActivityBar: color customisation for active viewlet icon

Please allow something like "activityBar.activeBackground" and "activityBar.activeForeground". The current styling makes it too subtle and I can't tell if the control is active fast enough. I end up clicking an active control which then closes the entire activity bar.

fyi @bpasero @aeschli

/duplicate https://github.com/Microsoft/vscode/issues/51796


search and searchregex don't work with daily=true

Steps to reproduce:

Put abc somewhere in the current daily note (in my case, Periodic/Daily/2021-11-12).
Open obsidian://advanced-uri?daily=true&search=abc&replace=123.

Expected: The abc should be replaced with 123.
Actual: Nothing changes.

Notably, as expected:

obsidian://advanced-uri?filepath=Periodic%252FDaily%252F2021-11-12.md opens the file.
obsidian://advanced-uri?daily=true also opens the file.
obsidian://advanced-uri?filepath=Periodic%252FDaily%252F2021-11-12.md&search=abc&replace=123 replaces abc with 123.

Sorry, but I can't reproduce. Are on version >=1.13.0 ?

Aw, geez, I forgot you don't see the Update buttons until you click the big Update All button first. 🤦🏻♀ Just pulled in the update, and it works great. Sorry to take up your time! (Also, thanks for this plugin, it's fantastic.)


mgmt, use CoreUtils.mergeContext

Fix https://github.com/Azure/autorest.java/issues/1442
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:

[ ] The pull request does not introduce [breaking changes]
[ ] CHANGELOG is updated for new features, bug fixes or other significant changes.
[ ] I have read the contribution guidelines.

General Guidelines and Best Practices

[ ] Title of the pull request is clear and informative.
[ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[ ] Pull request includes test coverage for the included changes.

API change check for com.azure.resourcemanager:azure-resourcemanager-resources
API changes have been detected in com.azure.resourcemanager:azure-resourcemanager-resources. You can review API changes here


Can't see my solutions to problems beyond "Get Set for our Algorithm Challenges"

I want to review my solutions to previous problems, specifically those in the Basic Scripting Challenges, but I can't. Clicking on the [number] only shows solutions up to "Get Set for our Algorithm Challenges"
Is this intentional?

@stomperstomp the [number] I think that you're referring to is just the number of challenges you've completed. If you click on that number, it'll bring you to your profile page where you can view your challenge solutions. Does that guide you to the correct place?

@erictleung
Yes, that functionality works fine. I know what it's supposed to do. The issue is, that I have completed tasks in the Basic Scripting Challenges, but can't view the solutions. The solutions that are accessible and linked, end at the task "Get Set for our Algorithm Challenges," nothing beyond it.

@stomperstomp The algorithms are in their own table above the rest of the challenges. I'm looking at your profile and I see that your latest completed algorithm is Slasher Flick. Is that correct?

Oh, you are correct! I missed it. I just automatically scroll to the bottom since I assumed all exercises were listed together chronologically.
I'm not sure if you guys take UI/UX suggestions, but I'm happy to elaborate further as I do UX design, if  that would help.

@stomperstomp FCC's open to UI/UX suggestions. Feel free to comment or create a new issue if your suggestion isn't relevant to existing issues.

Looks like this is resolved.
@stomperstomp You may reach out to the Contributors Chat room for any suggestions, and as always open an issue with your feedback.
@alistermada Thanks for looking into this.


Input Chinese characters at Unit field reported an error

Please verify that this bug has NOT been raised before.

[X] I checked and didn't find a similar issue

Describe the bug*
In old version  0.11 doesn't report an issue; the new version reported an error after system migration.
I have found a workaround method - In administrator mode, add a physical unit for the international characters - both name and symbol need be the Chinese unit name.
Steps to Reproduce

Go to “Add new part"
Input Chinese characters "个“ at field "Unit"
Click submit

Expected behaviour
measurement unit error
Deployment Method

[X] Docker
[ ] Bare metal

Version Information
0.13.5
Please verify if you can reproduce this bug on the demo site.

[ ] I can reproduce this bug on the demo site.

Relevant log output
No response

I have found a workaround method - In administrator mode, add a physical unit for the international characters - both name and symbol need be the Chinese unit name.

This is probably what you are going to have to do - create custom physical units as needed. InvenTree already provides a way to add custom units on top of the pint conversion library (which as far as I can tell, does not support multi-lingual support).
So, I would suggest that you add these custom units as required.

The workaround (add physical unit) is not stable. Now when I edit a part, the unit measurement appear again. I suggest that reopen this issue.
Probably just after I modified/added the physical unit, the part edit/add seems to work; after some days, it wouldn't work any more.

@weizhangny can you please provide some more information about your latest comment. Some scr
eenshots and examples would be really helpful.

Just after I added a new custom physical unit, the error was not generated. After a while, the unit error came up consistantly.

Have you tried updating to the latest version? This seems to work ok in 0.14.x:


Update RNCCheckbox.podspec

Fix pod issue - erroring due to missing pod dependency.

Confirmed working for me as well.


Clean up notebooks

Need to go through the notebooks folder and remove / archive anything that is not 'current' or useful. Ideally we might have just one or two notebooks that show how fluvius works.

I moved the two demo notebooks that have extensive tutorial language within on using tabular data on Planetary Computer and accessing STAC catalog

Looks great!


Allow offset as an option for matcher.

I noticed the zrevrange command for redis accepts a 'start' parameter
specifying how many results to skip over before returning the data.
Since there was a use case for this on a particular project I am
working on, I added this to the matcher options.
Let me know if you like this idea.

@ericmhalvorsen why are you using offset? If you're looking for pagination, you might want to check out the extended fork of soulmate that I've made, Soulheart (which has pagination built in and includes demos).

Ah did not see that, that is nice. But the reason I need offset is rather specific - I have a complicated access scheme on a user-by-user basis, where I have to check that results are 'accessible' by the user. If there are not enough accessible results, I have to return to fetch the next n results and repeat the process. My initial design attempted to modify the way Redis holds the data so that the matcher can find only 'accessible' matches, but the access conditions are far too complicated, and I was able to make it work as stated above with pretty reasonable performance, so it works for me.
Any ideas as to other methods that might fulfill this (I admit strange) requirement? Also figured I'd add this because it's not like it's very complicated, and people don't have to use it if they don't want. I'll also admit that I can't think of another reason that someone might need this feature.

@sethherr Gotta say I like the categories implementation however, may need something like that in the future.

Looks fine to me.


Support copying non-pngs and wait for focus to avoid race conditions

This is a follow up to #180269 which fixes #171616
I patched the first PR to test it out and notices a couple of problems.
Firstly, when right clicking, it would often fail with the error message:
DOMException: Document is not focused.

This was because it was called by doing:
this.webviewEditor.reveal();
this.webviewEditor.webview.postMessage({ type: 'copyImage' });

Since .reveal() runs async, there was a race condition where the object was receiving focus and trying to copy at the same time, and for me, the copying was often winning.
I tried to fix this by adding an event listener on document to wait for it to gain focus, but this would also usually fail as it would usually gain focus whilst the listener was being setup, causing it to miss the focus gain event. Instead, I have a slightly less optimal solution which just waits 10ms and then checks again for focus. In testing this was never called more than once so I think that it is acceptable. Another solution would be to have a message sent back from the webview when it has focus, and wait for that in the copy command on the extension side, but I think this would be a lot more expensive.

The other issue I came across was that the copy only works for png images, other types it complains about the mime type not matching. I tried setting the mimetype based on the content type returned in the fetch, but it turns out the clipboard only supports png.
What I have done here is created a temporary canvas, which we can write the image into, avoiding the fetch() entirely. This allows us to get a png from any image type - when testing with gifs, this only keeps a single frame of the gif, so there is room for improvement there.
I think there is room for improvement here, but this resolves some of the issues I was seeing when copying images.

@mjbvz


Improve printing

here are three patches, I'd like to upstream.
the first one fixes a build-issue when using build-linux.sh with --headless - it is not really related to the other two, but I was to lazy to create a separate pull request just for that... hope you don't mind
then there is one commit that simplifies the handling of qt-patches in the build-helper.sh, namely the patch files are now read from folders. that way, a user can just dump custom patches there and run the deploy script without changes.
finally, there are three new qt 4.8 patches, that leverage this new patch-folder structure. the patches are improve PhantomJS printing capabilities substantially. Most notably, tables are now printed much nicer (thead, tfoot are repeated and there are no more page-breaks inside table rows). Furthermore users can add a custom header/footer to pages by adding some javascript to their page(s):

you can see an example .html & .pdf file here:
https://userpage.physik.fu-berlin.de/~milianw/phantomjs/printing/

For reasons described elsewhere, I rather have the issue linked from the commit log. But if you don't have time to add them, I'll try to amend the commit message as I cherry-pick it.

is there a issue for this? I haven't found one.
I'd welcome it if you could just add the "issue: ..." line yourself - sorry for the inconvenience!

Well yeah, technically a feature should be filed in the issue tracker as well (per our Contribution Guide).

so, should I create a new issue? I found http://code.google.com/p/phantomjs/issues/detail?id=63 which is I think at least partially fixed by this - I'd of course also be ok with you just merging these patches with the "issue: ..." line added.
many thanks

see http://code.google.com/p/phantomjs/issues/detail?id=410&start=100 - could you please elaborate on which "global object" you mean?


Make stack variable yes/no prompts honor default value

Fixes #1854

Still seems to prompt with (Y/n) by default
stack: test/test
variables:
  mongodb_lock:
    type: boolean
    default: false
    from:
      prompt:
services:
  foo:
    image: redis

kontena stack validate
> Enable mongodb_lock : (Y/n)

Although the resulting value on hitting Enter is actually false now:
variables:
  mongodb_lock:
    label: mongodb_lock
    type: boolean
    from:
      prompt:
      env: mongodb_lock
    to:
      env: mongodb_lock
    errors: {}
    value: false

The existing code in git master is at consistent in that it prompts with (Y/n) and sets it to true if you hit enter. Prompting with (Y/n) but setting it to false if you hit enter is still buggy.

true:

Odd, it's different for me:

Also with your example:

Gemfile.lock shows tty-prompt (0.11.0)

Strange indeed. CLI shouldn't have Gemfile.lock in the repo anyway.
Also the prompt.yes? defaulting syntax hasn't changed since 0.11.

Bumping to 1.2.1 until we figure out why the prompt seems to be wrong on Linux....

Perhaps this should use [prompt.no?]I(https://github.com/piotrmurach/tty-prompt#25-yesno) for the default: false case?

Uses no? now.

Eh... now it correctly prompts with > Enable mongodb_lock : (y/N), but then if I just hit enter, the result is value: true :/

Heh, that is because no? returns true when you choose no. Reverting.

prompt.yes?('foo', default: false) works as expected.
The original option.default == false ? false : true did not.

Same thing as before, it's prompting with > Enable mongodb_lock : (Y/n) but then making the value false when you hit enter.... some bug with tty-prompt (0.11.0) on Ubuntu 16.04 gnome-terminal vs OSX terminal?

This works, but the default for a boolean variable is now false:
       def bool
        prompt.yes?(question_text, default: !!option.default, type: option.default ? :yes : :no)
       end

The tty-prompt-0.11.0 TTY::Prompt::ConfirmQuestion code is really weird. I think the use of default? is wrong, it should be default?
      # Check if default value is set
      #
      # @return [Boolean]
      #
      # @api public
      def default?
        @default != UndefinedSetting
      end
...
      # @api private
      def setup_defaults
        return if suffix? && positive?

        if suffix? && !positive?
          parts = @suffix.split('/')
          @positive = parts[0]
          @negative = parts[1]
          @convert = conversion
        elsif !suffix? && positive?
          @suffix = create_suffix
          @convert = conversion
        else
          create_default_labels
          @convert  = :bool
        end
      end

      def create_default_labels
        if is?(:yes)
          @suffix   = default? ? 'Y/n' : 'y/N'
          @positive = default? ? 'Yes' : 'yes'
          @negative = default? ? 'no' : 'No'
        else
          @suffix   = default? ? 'y/N' : 'Y/n'
          @positive = default? ? 'Yes' : 'yes'
          @negative = default? ? 'No'  : 'no'
        end
      end

      # @api private
      def create_suffix
        result = ''
        if is?(:yes)
          result << "#{default? ? @positive.capitalize : @positive.downcase}"
          result << '/'
          result << "#{default? ? @negative.downcase : @negative.capitalize}"
        else
          result << "#{default? ? @positive.downcase : @positive.capitalize}"
          result << '/'
          result << "#{default? ? @negative.capitalize : @negative.downcase}"
        end
      end

Seems to be fixed in tty-prompt 0.12.0, the Gemfile needs update.

Confused 😕 :
(byebug) opts
{"default"=>false, "from"=>"prompt"}
(byebug) opts['from']
"prompt"
(byebug) opts['default']
nil


Validate returned notes from oracle call.

We should check the contract address and storage slot of the returned notes in the aztec library. And the app contract only needs to verify the custom note fields.

Closing it as there's no need to validate it. We assign the correct storage slot to returned notes' header in noir contract, and the read request will be siloed with contract address in the kernel circuit. So the contract address and storage slot for the notes returned for the oracle call are not important.


Upmerge v1.17.x to master

There's already quite a few changes, so let's doublecheck the diff.

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

[trickle] No significant performance differences

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 2,019,735      Total (=)      2,019,735

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
11,154,115      Total (<)     11,154,121

 No significant differences in binary sizes

Corrupt JSON data (indicates timeout or crash):
    bm_call_create.BM_IsolatedFilter_ClientChannelFilter_NoOp_.counters.new: 10
    bm_call_create.BM_IsolatedFilter_ClientChannelFilter_NoOp_.counters.old: 10

[microbenchmarks] No significant performance differences

I'll be on vacation over the next few days, so feel free to merge once we have all the approvals.

Known failures:
https://github.com/grpc/grpc/issues/17375


⚠ 366.ru has degraded performance

In 067b120, 366.ru (https://366.ru) experienced degraded performance:

HTTP code: 200
Response time: 5092 ms

Resolved: 366.ru performance has improved in 88d4957.


FastHttpUser client does persist the auth headers across requests like Httpuser's client

With HttpUser, i can set the client.headers to store auth token..etc then issue new client requests without having to specify headers in the request. something like this >>
self.client.headers = self.api_headers self.client.post("reports", data=somedata, name="something")
FastHttpUser on the other hand will not honor the preset headers, thus forcing me to specify the headers for every subsequent call.
self.client.post("reports", data=somedata, headers=self.api_headers, name="something")
The documentation states :
This class creates a client attribute on instantiation which is an HTTP client with support for keeping a user session between requests.
Sounds like a bug to me.

Check the source code for geventhttpclient. It should be possible to modify UserAgent’s default headers (you could even modify HTTPClient.DEFAULT_HEADERS, as long as you do it before any Users are instantiated https://github.com/geventhttpclient/geventhttpclient/blob/99a6d67732c0b2f0f1572e9bd44d1abff954cb52/src/geventhttpclient/useragent.py#L273).
Its not really a bug for geventhttpclient to not be a 1:1 replacement for requests, and even if it was, its a bug there, not in locust :)


Windows Terminal Keyboard Focus Problem with Magnifier

Windows Terminal version
1.14.2282.0
Windows build number
OS Name	Microsoft Windows 11 Home Single Language
Version	10.0.22000 Build 22000
Other Software
I am using WSL2 Ubuntu
Steps to reproduce
Install windows terminal
Open windows default magnifier tool
Write something to terminal, It should follow your cursor. In some cases it is not following.
Mostly happens when changing the focus to another app and re open the termial again with alt+tab combination.
Expected Behavior
In earlier versions, there was a issue like this. Sometime focus were working sometimes not. But last preview build it is not working correctly. Alltough working fine when you use with default Ubuntu Terminal that comes with WSL2 installation.
Actual Behavior
There is no focus when typing. After changing app and re opening terminal works but not works for all the time.

Terminal versions and OS versions area actually really helpful 😉
I'm betting this is correlated with #13388.

Terminal versions and OS versions are actually really helpful 😉
I'm betting this is correlated with #13388.

Yes you are right :)
I add reqired information.

Hey folks who are hitting this - can I ask for some debugging help?
See: https://github.com/microsoft/terminal/issues/13388#issuecomment-1379117011
I can't repro this myself. But I do think it's related to another thread, and I've got a theoretical fix for that thread. Can I get someone in here to try the build I linked in #13388, and see if that build resolves this? It's technically an unsigned package, so you might need developer mode enabled.

Here's a couple questions:

What's your default profile? Is it a WSL profile by any chance?
What are you running in that tab where this repros? WSL, cmd.exe, pwsh?
Do you have Docker for Windows installed? (if so, which version?)

Here's a couple questions:

What's your default profile? Is it a WSL profile by any chance?

     My default profile's a Microsoft Store PowerShell profile.  For the record, I see this issue in any of the profiles I use frequently.  The profiles I use most often are that Microsoft Store PowerShell one and a partly ad-hoc WSL 2 one for a custom, non–Microsoft-Store Gentoo instance.  I have other profiles, but I don't really use them.  I can dump my configuration if needed on request.

What are you running in that tab where this repros? WSL, cmd.exe, pwsh?

     What's running is usually either PowerShell from the Microsoft Store in a PowerShell profile or WSL 2, hosting my custom Gentoo instance, in a WSL 2 profile for said instance.

Do you have Docker for Windows installed? (if so, which version?)

     No, I don't have Docker for Windows installed.

     I should say that I sometimes also see the issue, with about the same frequency, even when Alt-tabbing between open programs on the same virtual desktop.

Is this still happening on Terminal Preview v1.19/?

@zadjii-msft:
     I'm still seeing this issue quite frequently, actually.  This is now under:
OS version:  Windows 11 Pro 22H2 (64-bit,) build 22621.2361
Experience version:  Windows Feature Experience Pack 1000.22674.1000.0
Windows Temrinal app version:  Windows Terminal v1.17.11461.0
in:

PowerShell (Microsoft Store edition) v<IP_ADDRESS>
A WSL 2 Gentoo Linux instance (installed manually without the Microsoft Store's help in the form of an official package.)  (Linux kernel version:  v<IP_ADDRESS>-microsoft-standard-WSL2)