GamePads.update() doesn't remove entries from current upon gamepad disconnect

When a gamepad is disconnected, it should also be removed from the app.gamepads.current and app.gamepads.previous arrays.
It seems that the logic in the update method only iterates over the number of devices returned from Poll(), so doesn't get a chance to set excess entries to null:
https://github.com/playcanvas/engine/blob/d4b8e0a3607a5caf19d65934da6d5b34b7f0d4b2/src/input/game-pads.js#L109

I recently pushed this code in a PR as a fix for something, and I guess I broke something else!
I wonder if just a simple fix where you loop over max(pads.length, this.current.length) and delete excess if you find any would suffice.

I think the bug existed prior to your recent submission as well - so I don't think your recent PR regressed this :)
Your suggestion sounds like it should do the trick though!

I've been thinking about this, and I just realized that might not be good enough @ransico . If you connected gamepads A and B, then current would look like this:
current = [A,B]

So gamepads.wasPressed(1,0) would return true if controller B pressed the 0 button. If you disconnect controller A, and you remove it from current then suddenly it becomes:
current = [B]

Where  gamepads.wasPressed(1,0) wouldn't refer to anything and  gamepads.wasPressed(0,0) is actually now controller B. I can see this being annoying if you had Player 1 using controller A, and Player 2 using controller B, that if A gets disconnected temporarily then suddenly B would be controlling the other player.
What doesn't change is pad.index. So B.index would still be 1.
I guess the question is, should PlayCanvas be handling making the the gamepads persistent in the array, or should that be something the developer sorts out on their own?

Sorry for the delayed response - I've been out of the office for the past 10 days!
No easy answers on this one - the gamepads API doesn't really support the notion of 'pinning' a physical controller to a particular player number (especially across disconnect/reconnect).
If the number and ordering of gamepads mattered strongly to a developer across disconnect/reconnect, I suspect they would need to detect a change in the number of connected gamepads and respond by pausing the app, presenting a dialog of some description allowing players to 'reclaim' their controlled avatar.
I don't have a strong opinion on whether you should introduce gaps in the array; while it does introduce consistency with the Gamepad API - that is always subject to change since it is not a ratified standard no may be an own-goal in the long run. Additionally, introducing gaps could be more error prone in apps, since developers will need to check for nulls (and not just take gamepad 0)


WICKET-7115 spelling corrections, removal of non-breaking-spaces

Clean up of text in code and documentation: spelling corrections, and replacement of non-breaking spaces with regular spaces. Some small improvements to Javadoc and example code in documentation.

@jstuyts thank you very much!


Feat: Confirmation modal for destructive actions

Depends on #92

@johannesvedder I have removed the dependency on #92 & re-opened this PR in #148 . You should be able to use it for your updated survey preview now.


fix(manage-merge-queue): set commit status on updated commit hash

:pencil: Description

Fixes a bug where the proper commit status on the second queued PR when the first PR was removed from the queue.

:tada: This PR is included in version 1.45.7 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Create 0000-01-02-NehaPericherla.md

created a branch, created a file and made a commit, and opened a pull request


MLFlow extension: container image for MLFlow builder

We need a container image implementing the MLFlow "builder": a pipeline step that creates a container image out of an MLFlow compatible codeset that can be used as an environment to execute the MLFlow entrypoints specified in the MLproject file. This image will be associated with the MLFlow builder runnable artifact, but can also be referenced inline in fuseml workflows.
Some highlights about what the container image should contain and do when invoked as a pipeline step:

contains all software utilities able to interpret 'MLprojectandconda.yaml` files and install specified python requirements
contains or inherits from a base image (preferable) all software utilities able to build a container image (inside a container image) and push it to a remote OCI registry
(optional) contains or inherits from a base image (preferable) all software utilities required to register FuseML runnables (i.e. the fuseml CLI)
expects as inputs, modeled as volumes, command line args and/or env variables:

an MLFlow codeset (directory containing MLproject and conda.yaml files) to be mounted as volume. The mount path is either hard-coded as a FuseML wide convention, or supplied as an additional parameter with a default value. The latter is recommended, because it's more flexible.
service URLs and credentials required to push container images and register artifacts:

URI and credentials for an OCI registry
(optional) URI and credentials for the fuseml service API

when executed:

generates the contents and Dockerfile for the output container image
(optional) generates a runnable.yaml file with a description of the FuseML runnable representing the MLFlow environment
pushes the container image to the OCI registry
(optional) registers the FuseML runnable with the fuseml API

generates as outputs, modeled as volumes or files (depending on fuseml conventions on passing pipeline step outputs):

the full container image URL (including tag) where the image is saved
(optional) the runnable URL (including version)

The code (Dockerfiles, scripts etc) needed to build the builder image should be available under the fuseml github org, either as a separate repository holding only the MLFlow specific extensions, or as part of a global repository holding all FuseML extensions.

@flaviodsr could you please take a look at this to see if this makes sense in the context of your ongoing work on workflows ?

Still missing: support to specify OCI registry credentials as input parameters


Adjust trigger for deploying to preview

Under active development there may be multiple PRs being merged in rapid succession and each of these will trigger a deploy currently and there may be failures as only one deploy will work at a time.
By switching to deploying on release we can control when the deploy happens and batch up a group of changes to deployed at the same time.
The trigger is when the release is 'created' with the idea that we will create draft releases that deploy to preview automatically and then when we have a production environment we will publish the release to deploy to production.

 Use GitHub releases to trigger deploys

 Use GitHub releases to trigger deploys

Tweaked to use prereleased and released events as draft releases don't trigger workflows. Also added a manual deploy button for scenarios where we want to deploy a branch or redeploy if a deployment failed.

Tweaked to use prereleased and released events as draft releases don't trigger workflows. Also added a manual deploy button for scenarios where we want to deploy a branch or redeploy if a deployment failed.


minimal-bootstrap: use builtins.fetchGit

Description of changes
Experiment to try to avoid needing an upload to tarballs.nixos.org.
I'm building this now.  It is sloooooow.
This evals for me:
nix build -f '<nixpkgs>' minimal-bootstrap.stage0-posix.src \
  --system i686-linux \
  --option restrict-eval true \
  --option allowed-uris https://github.com/oriansj/stage0-posix

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Now I remember why this can't work: https://github.com/NixOS/nixpkgs/pull/232576/#issuecomment-1592415619


Menu item doesn't change to "selected" style if not an "href" item

Hello,
I have a menu item that is not an "href", and when clicked it doesn't change to the "selected" appearance.
I have tried setting activeClass = true but to no avail.
I think this is related to this:
how to programmatically decide if a menu item is selected or not
How to make non-href items use "selected" style when clicked?

HI @rust-jvm-go
actually activeClass is a string not a boolean (my mistake in the docs) , what it does is that in applies a custom class name to the menu item when the menu item is active , meaning that the menu item MUST have an href to have an activecalss.
now the only way to to make non-href items use "selected" style when clicked is to handle it with event listener and update the menu list .
i am gonna add this feature anyway and let you know when its done :))
my schedule is pretty busy ,but i should be up in a few days.


Importing pycon-fr-2019 from dl.afpy.org, ponyconf, and youtube

@JulienPalard , if you need help with anything, let me know.
YouTube videos are not mandatory (I can't find any playlist on YouTube by the way)

Someone gave me the youtube videos (still unlisted), so I'll can add them. I think I can script this with a few lines of Python :)

I think I properly reconciliated Ponyconf (title / descriptions / speakers), dl.afpy.org (video files) and youtube.
I have two videos that miss a youtube upload but it can be fixed later:
videos/Les-decorateurs:-Kezako?.json
videos/LSTM-Variational-AutoEncoders-for-Network-Signal-Anomaly-Detection.json

(I like how I commit "FIX: Markdown" while fixing reStructuredText :P)

I have two videos that miss a youtube upload but it can be fixed later:
videos/Les-decorateurs:-Kezako?.json
videos/LSTM-Variational-AutoEncoders-for-Network-Signal-Anomaly-Detection.json

First one was still private: https://www.youtube.com/watch?v=JD1eknK3hxo
Last one was public but not part of the playlist: https://www.youtube.com/watch?v=L7m8wIRA11A

It looks like this one is missing: https://www.youtube.com/watch?v=v_EZTo45FtE

Nice catch!

@redapple looks OK to me (but beware it's my first PR on pyvideo).

(rebased and squashed)

Thanks so much @JulienPalard & @pilou-
I just added the thumbnails and slugified filenames.

Thanks @redapple for this final cleaning and merging :)

Spotted an issue related to this import: https://github.com/pyvideo/pyvideo/issues/94

@JulienPalard the issue with tabs is now fixed.
I noticed that https://www.youtube.com/watch?v=UV0k12sGues is not available anymore.
Do you know if there's an alternative? or should be remove the YouTube link?

I noticed that https://www.youtube.com/watch?v=UV0k12sGues is not available anymore.
Do you know if there's an alternative? or should we remove the YouTube link?

There was an issue with this video, new URL is https://www.youtube.com/watch?v=UpmZIble3gQ.


Daemon: Updates Detect() Call to Return Detected Devices

Updates the call to d.deviceManager.Detect() so returned devices are added to the list of network device strings. This allows DevicesChanged() can be invoked with the discovered network devices used for constructing L2 announcement policies.
Fixes: #28009

/cc @dylandreimerink

/test

The Cilium IPsec upgrade job is failing due to https://github.com/cilium/cilium/issues/28088.

:wave: as this is a fix, should it be backported? If so, to what releases?

👋 as this is a fix, should it be backported? If so, to what releases?

The bug was introduced recently, no need for backports.

👋 as this is a fix, should it be backported? If so, to what releases?

The bug was introduced recently, no need for backports.

ah then let's adjust the release-note label :+1: . If the bug never reached a stable release, it's not release-note/bug.


[WIP] Refine the .circleci/config.yml by using dynamic config

Description
Attempted to remove repetitive statements in ci by using dynamic config
Encountered problem
Use of setup workflows must be enabled in project settings (Project settings > Advanced -> Dynamic config using setup workflows)
I lack the necessary permissions to modify project settings. However, adjusting this setting is necessary for debugging the CI workflow effectively as I don't have an environment to run this locally.
Related Issue
https://github.com/redis/rueidis/issues/482

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.89%. Comparing base (87afcd2) to head (4455e48).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #517      +/-   ##
==========================================
- Coverage   95.57%   94.89%   -0.69%
==========================================
  Files          80       59      -21
  Lines       33178    28066    -5112
==========================================
- Hits        31710    26632    -5078
+ Misses       1267     1244      -23
+ Partials      201      190      -11

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Projectname should be Project name

In step 1 'Projectname' is present, this should be 'Project name'.
Additionally, on the Statistics tab the header of the top section is Project, followed by
Project:
Imo this should be
Name:

Resolved in b41c87949002d2de1a4d64d1086d325940dc5802. Thanks for reporting!


object query

hi
I got a problem when i use connection.query ()
the code is like this
connection.query( 'select * from users where ?' , cfg , fcb );

It's great if there is only one setting in cfg.   ->  cfg = { id : 1234 };
But If i assign multiple objects in cfg , the query failed . -> cfg = {name:hello, sex:M, Country:USA };
I found the issue after I check the query.sql
the sql command had been build like this :
'select * from users where name=hello, sex=M, country=USA'

but , as my understanding about sql , the command should be
'select * from users where name=hello and sex=M and country=USA'

So , I trace the codes and modified the function ( "objectToValues" ) in  mysql\lib\protocol\sqlString.js
Just replace the
return values.join(', ');           to
return values.join(' and ');
It seems solved .
Is there any side effect ?

Hi, yes, that change would break a lot of people. The ? object-style replacements are only for use in SET and similar statements, rather than for use in the WHERE clause. If you are looking to dynamically build complex SQL and WHERE clauses, you may want to try using https://hiddentao.github.io/squel/
var query = squel.select()
  .table('users')
  // your stuff
  .toParam();
connection.query(query.text, query.values, function (err, rows) {
  // ...
});


Update scala-java-time to 2.3.0

Updates io.github.cquiroz:scala-java-time from 2.2.2 to 2.3.0.
GitHub Release Notes - Changelog - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "io.github.cquiroz", artifactId = "scala-java-time" } ]

labels: test-library-update, semver-minor

Codecov Report

Merging #1752 (974c895) into master (6989984) will decrease coverage by 0.25%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1752      +/-   ##
==========================================
- Coverage   86.91%   86.66%   -0.26%
==========================================
  Files          59       59
  Lines        2399     2399
  Branches      136      136
==========================================
- Hits         2085     2079       -6
- Misses        314      320       +6

Impacted Files
Coverage Δ

...re/shared/src/main/scala/io/circe/MapDecoder.scala
88.00% <0.00%> (-8.00%)
:arrow_down:

...rc/main/scala/io/circe/numbers/BiggerDecimal.scala
86.54% <0.00%> (-1.17%)
:arrow_down:

.../core/shared/src/main/scala/io/circe/Decoder.scala
84.55% <0.00%> (-0.27%)
:arrow_down:

...re/shared/src/main/scala/io/circe/KeyDecoder.scala
100.00% <0.00%> (+2.70%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6989984...974c895. Read the comment docs.


Video files append titles to the file name when using update action

When you run ./elodie.py update --title="my new title" /path/to/2015-01-01_12-00-00-my-old-file.jpg It will name the file /path/to/2015-01-01_12-00-00-my-old-file-my-new-file.jpg.
This seems to only be happening for videos.

This seems to be fixed in the current code.
➜  My Photos ~/.elodie/elodie/elodie.py update --title="new title" 2014-09-Sep/some\ album/2014-09-18_15-38-49-img_8545-some-title-test.mov
{"source":"2014-09-Sep/some album/2014-09-18_15-38-49-img_8545-some-title-test.mov", "destination":"2014-09-Sep/some album/2014-09-18_15-38-49-img_8545-new-title.mov"}


Update/refresh registries and packages - Parent Issue

Consolidating related issues here:

[x] Support environment -> versioned package mapping #631
[x] ks upgrade moves vendored packages to versioned paths #663
[x] Package vendor paths should be versioned #651
[x] ks pkg install - side-by-side support for versioned packages #660
[x] Add --env flag to pkg install #688
[ ] Address potential conflicts between versioned and unversioned package paths in vendor cache #654
[ ] Expose environment and version information in pkg list #626
[ ] Support package versioning in pkg describe command #630
[x] GitHub registry.yaml cache paths inconsistent #603
[x] Registry cache behavior - do not pin specific version, automatic sliding forward on branches #622
[x] Add new registry update command #604

Pushing to release past 0.12

[ ] Package cache garbage collection #624
[ ] Add pkg remove command #625
[ ] Rename libraries -> packages for app schema 0.2.0 #635

@shomron where does ks upgrade can update vendored packages to their proper location to silence the upgrade warning fit?

@bryanl I'm now tracking that in #663. Here is an early, incomplete sketch:
https://github.com/shomron/ksonnet/tree/upgrade-0.2.0

@shomron What will be the command for upgrading to latest?

@bryanl the following sequence demonstrates how you can currently upgrade a package
$ ksdev init pkg-upgrade && cd pkg-upgrade/
$ ksdev env add stage
$ ksdev pkg install --env=stage incubator/nginx@consistency    # some old version
$ ksdev pkg install --env=stage incubator/nginx    # latest according to registry uri

We start running into problems with the current cli when you want multiple environments to point to the same package version - it currently reports that as a conflict (package already exists).
I can do a writeup on how we might overcome this.


Build failed on ios 12.2

Environment
React Native Environment Info:
System:
OS: macOS 10.14.4
CPU: (8) x64 Intel(R) Core(TM) i7-6820HQ CPU @ 2.70GHz
Memory: 188.01 MB / 16.00 GB
Shell: 3.2.57 - /bin/bash
Binaries:
Node: 10.13.0 - /var/folders/nl/710wyq5x15v877chfxh5hsd80000gn/T/yarn--1554154696352-0.5529216754436022/node
Yarn: 1.13.0 - /var/folders/nl/710wyq5x15v877chfxh5hsd80000gn/T/yarn--1554154696352-0.5529216754436022/yarn
npm: 6.4.1 - ~/.nvm/versions/node/v10.13.0/bin/npm
Watchman: 4.9.0 - /usr/local/bin/watchman
SDKs:
iOS SDK:
Platforms: iOS 12.2, macOS 10.14, tvOS 12.2, watchOS 5.2
Android SDK:
API Levels: 23, 25, 26, 27, 28
Build Tools: 26.0.0, 27.0.3, 28.0.3
System Images: android-24 | Google APIs Intel x86 Atom, android-25 | Google APIs ARM 64 v8a, android-25 | Google APIs ARM EABI v7a, android-28 | Google APIs Intel x86 Atom, android-28 | Google Play Intel x86 Atom_64
IDEs:
Android Studio: 3.3 AI-182.5<IP_ADDRESS>64788
Xcode: 10.2/10E125 - /usr/bin/xcodebuild
npmPackages:
react: 16.8.3 => 16.8.3
react-native: 0.59.0 => 0.59.0
Platforms
iOS
Versions

iOS: 12.2
react-native-netinfo: 1.4.0
react-native: 0.59
react: 16.8.3

Description
yarn react-native run-ios --device="iPhone XS" - getting build failed

Or for example in simulator:

netinfo and all other packages are already linked

@v0lume Thanks for the report.

Can you confirm that you have rebuilt and rerun the app since linking.

Are you using Cocoapods? If so, can you provide the full contents of your ios/Podfile and ios/Podfile.lock?

If you are not using Cocoapods, can you send me a screenshot of the "Link binary with libraries" build phase of your app target?

Could you also try doing as the command line error message says and opening the workspace in Xcode and attempting a build in there. If it gives an error message, can you send me that too? It's easiest to see in the "Report" section of Xcode (The message bubble icon on the right of the left pane) and then clicking on the failed build.

We've run into this issue today as well @matt-oakes
I'm double checking everything right now, but can confirm that we've done number 1 - our CI release builds are what failed this way.

@NathanielWaggoner Are you using Cocoapods for iOS. Where are you seeing the error in your CI builds? Is it in a Jest test?

@matt-oakes sorry for delay

yes
no

i don't see rncnetinfo lib here

Here is a workaround:

dnd<EMAIL_ADDRESS>to your Libraries folder in Xcode
clean and rebuild project
add libRNCNetInfo.a lib to your Linked Frameworks and Libraries

That isn't a workaround really, that's just linking the library correctly. If react-native link does not work for your project (likely because you have a non-standard project structure) then you need to link manually (see above, or the README instructions) or file a bug with @react-native-community/cli.
Closing this issue as it seems to be down to the user not linking correctly rather than a library issue.

@matt-oakes it's a standard project structure and other packages are linked without any problems (for example react-native-community/async-storage).

In that case, you should file an issue on the CLI repo as that's where the link command code lives :+1:


namespace cache for testing on circle CI

Found out from https://github.com/square/okhttp/issues/6214 that the okhttp cache seems to just use the URL as a cache key rather all the vary headers as we would have expected.
In other words, since we have two test users. If we always have tests that go through tests for user A then tests for user B targeted at one repo, the second set of tests will always miss and evict the cache left over from A. Then a new cache is saved based on B which never works for A
As a solution, got side-tracked by application interceptors (https://square.github.io/okhttp/interceptors/). That would work for the suggestion to add a superfluous query parameter, but while logging interceptors seem functional, application and network interceptors seem broken. Otherwise, a superior choice would be to add a fragment as suggested https://square.github.io/okhttp/interceptors/ but non-logging interceptors seem broken in the kohsuke library (might be implied by https://github.com/hub4j/github-api/issues/151)
So adding the ability to rotate caches by github user on CI (but got sidetracked by a very misleading variable name).
Followup issues:

do we need a segmented cache in production too? But this approach breaks the LRU nature of the cache
alternatively why can't we use interceptors properly in kohsuke to have a properly unified multi-user cache?

FYI, bitbucket tests are dying but I had them passing in https://github.com/dockstore/dockstore/pull/4120/commits/326c0a4be9f30aa2d05ff9a2d7e318e0d5a834f6 and everything since is just comments/documentation


Beta/feature/folder selection

While selecting the Unzip option for the FileOperations Action, the Browse button for Destination Path was not working Properly. it was not allowing to select folders. and create folder after Unzip operation
Thank you for your contribution.
Before submitting this PR, please make sure:

[x] PR description and commit message should describe the changes done in this PR
[x] Verify the PR is pointing to correct branch i.e. Release or Beta branch if the code fix is for specific release , else point it to master
[x] Latest Code from master or specific release branch is merged to your branch
[x] No unwanted\commented\junk code is included
[x] No new warning upon build solution
[ ] Code Summary\Comments are added to my code which explains what my code is doing
[x] Existing unit test cases are passed
[ ] New Unit tests are added for your development
[x] Sanity Tests are successfully executed for New and Existing Functionality
[x] Verify that changes are compatible with all relevant browsers and platforms.
[ ] After creating pull request there should not be any conflicts
[ ] Resolve codacy comments
[ ] Builds and checks are passed before PR is sent for review
[ ] Resolve code review comments
[ ] Help Libray document is updated accordingly for Feature changes.

New code changes were required. will create a new PR


bundle install (nokogiri) doesn't work after updating to MacOS X ElCapitan

Before it worked well.
I've updated my system to latest ElCapitan version. And it seems to me that bundle install doesn't work.
The problem is in nokogiri library.
I've tried this link but it doesn't help...

Installing nokogiri <IP_ADDRESS> with native extensions

Gem::Installer::ExtensionBuildError: ERROR: Failed to build gem native extension.

    /System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/bin/ruby extconf.rb --use-system-libraries --with-xml2-include=/usr/local/opt/libxml2/include/libxml2
checking if the C compiler accepts ... yes
checking if the C compiler accepts -Wno-error=unused-command-line-argument-hard-error-in-future... no
Building nokogiri using system libraries.
checking for xmlParseDoc() in libxml/parser.h... no
checking for xmlParseDoc() in -lxml2... no
checking for xmlParseDoc() in -llibxml2... no
-----
libxml2 is missing.  Please locate mkmf.log to investigate how it is failing.
-----
*** extconf.rb failed ***
Could not create Makefile due to some reason, probably lack of necessary
libraries and/or headers.  Check the mkmf.log file for more details.  You may
need configuration options.

Provided configuration options:
	--with-opt-dir
	--without-opt-dir
	--with-opt-include
	--without-opt-include=${opt-dir}/include
	--with-opt-lib
	--without-opt-lib=${opt-dir}/lib
	--with-make-prog
	--without-make-prog
	--srcdir=.
	--curdir
	--ruby=/System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/bin/ruby
	--help
	--clean
	--use-system-libraries
	--with-zlib-dir
	--without-zlib-dir
	--with-zlib-include
	--without-zlib-include=${zlib-dir}/include
	--with-zlib-lib
	--without-zlib-lib=${zlib-dir}/lib
	--with-xml2-dir
	--without-xml2-dir
	--with-xml2-include=${xml2-dir}/include
	--with-xml2-lib
	--without-xml2-lib=${xml2-dir}/lib
	--with-xslt-dir
	--without-xslt-dir
	--with-xslt-include
	--without-xslt-include=${xslt-dir}/include
	--with-xslt-lib
	--without-xslt-lib=${xslt-dir}/lib
	--with-libxslt-config
	--without-libxslt-config
	--with-pkg-config
	--without-pkg-config
	--with-exslt-dir
	--without-exslt-dir
	--with-exslt-include
	--without-exslt-include=${exslt-dir}/include
	--with-exslt-lib
	--without-exslt-lib=${exslt-dir}/lib
	--with-libexslt-config
	--without-libexslt-config
	--with-xml2lib
	--without-xml2lib
	--with-libxml2lib
	--without-libxml2lib

Gem files will remain installed in /var/folders/xq/7ksd8wb95kb_76ldtcf3zkt40000gn/T/bundler20160422-52897-237o01nokogiri-<IP_ADDRESS>/gems/nokogiri-<IP_ADDRESS> for inspection.
Results logged to /var/folders/xq/7ksd8wb95kb_76ldtcf3zkt40000gn/T/bundler20160422-52897-237o01nokogiri-<IP_ADDRESS>/gems/nokogiri-<IP_ADDRESS>/ext/nokogiri/gem_make.out
Using rack-test 0.6.3
Using sprockets 3.4.1
Using coffee-script 2.4.1
Using compass-import-once 1.0.5
Using hamster 2.0.0
Using rb-inotify 0.9.7
Using haml 4.0.7
Using middleman-cli 4.0.0
Using activesupport 4.2.6
An error occurred while installing nokogiri (<IP_ADDRESS>), and Bundler cannot continue.
Make sure that `gem install nokogiri -v '<IP_ADDRESS>'` succeeds before bundling.

Can be fixed like that:
gem install nokogiri -- --use-system-libraries --with-xml2-include=/usr/include/libxml2 --with-xml2-lib=/usr/lib/

bundle install

Cool, glad you got it resolved!


Bad Request

I've followed your demo:
InstagramClient client = new InstagramClient(instagramClientId, instagramAccessToken);
var popularMedia = await client.MediaEndpoints.GetPopularMediaAsync();
var popularMediaJson = JsonConvert.DeserializeObject(popularMedia);
but the GetPopularMediaAsync method always returns "Response status code does not indicate success: 400 (BAD REQUEST)."
any idea what is wrong?
thanks

Bad request means that you miss some of the required parameters or you entered them wrong.
Since popular media required only an access-token , check your access token , and i suggest to call Trim() method for token string.

the token is correct, ive even created a new one to be sure.
I'm not sure what else i can change, it just doesnt work?

I've got it working it was a bad access token


Questions about the generation of config files

Hi, thank you for sharing your excellent work and code. I have a simple question. For these config files, are they manually written by you or it is generated from other automatic process? Thank you.

The configurations are defined by the proto files here https://github.com/kujason/avod/tree/master/avod/protos and the .config files are manually generated.


500 Error

I know you updated the readme to say you'll be back next month, but I wanted to ask if you had a working example I could get from you when the library is functional? Or further documentation?
I have something pretty basic, but the console is returning:

async function test() {
  const matchSchedule = await leaguepedia.fetchMatchSchedule({
    where: `_pageName LIKE "%2021%" AND Team1 = "TSM" OR MatchDay > 10`,
    groupBy: ['Team1', 'Team2'],
    orderBy: [{ field: 'DateTime_UTC', type: 'DESC' }, '_pageName'],
    limit: 100,
    offset: 50,
  })
  console.log(matchSchedule)
  return matchSchedule
}

test();

    at createError (C:\Users\Adam\Documents\GitHub\lol-esports-test\node_modules\axios\lib\core\createError.js:16:15)
    at settle (C:\Users\Adam\Documents\GitHub\lol-esports-test\node_modules\axios\lib\core\settle.js:17:12)
    at IncomingMessage.handleStreamEnd (C:\Users\Adam\Documents\GitHub\lol-esports-test\node_modules\axios\lib\adapters\http.js:236:11)
    at IncomingMessage.emit (events.js:326:22)
    at endReadableNT (_stream_readable.js:1241:12)
    at processTicksAndRejections (internal/process/task_queues.js:84:21)
(node:1184) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which
was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 2)
(node:1184) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.```

I apologize if I missed something but I read over the readme and something seems to be off for me

Sorry for that.
This is because leaguepedia API has changed.
I am refactoring this repo, it will be published this week.


missing statistical/tests for statistical and no github actions

Please let me know when you consider this complete and I will take a look. So far, statistical is missing content and tests, and GitHub actions are not included in the workflow.

Hi Inga,
we're hoping to get this finished by the beginning of next week!
Thank you :)


Download packages 403 Forbidden

Hello Folx,
I try install dcos with UI and process never is done, when check the internet access I looked this problem. Can you check please if is true?
curl  https://downloads.dcos.io/dcos/stable/packages/3dt/3dt--c3970af261c1e9ed9014904a6408617dafd41e6c.tar.xz

AccessDeniedAccess Denied642C6FB052E7C6B0ArQbwFezRMVMC+eGUHZcROZwiPWigE0JudvJ2PoeqwryDsNqL6UIbtqrvnOzvtzBfkuJTub63jA=cin_hbombonato@ni-88654-7:ed9014904a6408617dafd41e6c.tar.xzads.dcos.io/dcos/stable/packages/3dt/3dt--c3970af261c1e9e
cin_hbombonato@ni-88654-7:~/Downloads$ curl -fLsSv  https://downloads.dcos.io/dcos/stable/packages/3dt/3dt--c3970af261c1e9ed9014904a6408617dafd41e6c.tar.xz

Trying <IP_ADDRESS>...
Connected to downloads.dcos.io (<IP_ADDRESS>) port 443 (#0)
found 175 certificates in /etc/ssl/certs/ca-certificates.crt
found 712 certificates in /etc/ssl/certs
ALPN, offering http/1.1
SSL connection using TLS1.2 / ECDHE_RSA_AES_128_GCM_SHA256
server certificate verification OK
server certificate status verification SKIPPED
common name: *.dcos.io (matched)
server certificate expiration date OK
server certificate activation date OK
certificate public key: RSA
certificate version: #3
subject: C=US,ST=California,L=San Francisco,O=Mesosphere, Inc.,CN=*.dcos.io
start date: Fri, 08 Apr 2016 00:00:00 GMT
expire date: Wed, 17 Apr 2019 12:00:00 GMT
issuer: C=US,O=DigiCert Inc,CN=DigiCert SHA2 Secure Server CA
compression: NULL
ALPN, server accepted to use http/1.1

GET /dcos/stable/packages/3dt/3dt--c3970af261c1e9ed9014904a6408617dafd41e6c.tar.xz HTTP/1.1
Host: downloads.dcos.io
User-Agent: curl/7.43.0
Accept: /

The requested URL returned error: 403 Forbidden
Closing connection 0
curl: (22) The requested URL returned error: 403 Forbidden

Do you still have this issue? If so, please raise at Jira: https://dcosjira.atlassian.net


[Help Wanted] [Error] Could not deploy file '': Error: Could not get relative path for

I have no idea what I'm doing wrong here. I went from a single folder workspace to a dual setup, one for dev, other for prd. Settings.json has both configurations, but I'm getting this error when I try to deploy a .jpg file inside /dev/img folder.

@joaociocca
Can you post an example of your settings?

Sorry, I forgot to do that and reverted to single folder... but I think I remember what I did, I can explain:
base folder, something like C:\Project, contained a \dev and \prd folders. I opened them together on Code, and tried to setup two different targets - one for \dev deploy and the other for \prd, but when I tried to just deploy, nothing happened. Then I tried to deploy only that .jpg file, and the "Could not deploy" error showed up.
I'll see if I can get to that point again once I have some free time over here, then I'll post an example!

I have the same issue. Iploading from within a single project directory works ok, but when I move the directory into a workspace it errors with "Could not get relative path for.."

I can confirm this behaviour. I have a big workspace with more or less 30-40 folders in it. I'm trying to set up deployment but get the same error when trying to deploy:
[Error] Could not deploy file '<file>': Error: Could not get relative path for <file>

The  is the absolute path of the file.
My deploy-config inside of workspace's settings.js:
"deploy": {
        "packages": [
            {
                "name": "module",
                "description": "app module",
                "files": [
                    "src/**/*",
                    "bin/*",
                    "plugin/*"
                ],
                "deployOnChange": true,
                "targets": [
                    "local wmware"
                ],

            }
        ],
        "targets": [
            {
                "type": "sftp",
                "name": "local vmware",
                "description": "A SFTP folder",
                "host": "<IP_ADDRESS>",
                "port": 22,
                "user": "root",
                "password": "***",
                "dir": "/opt",
                "mappings": [
                    {
                        "source": "src/frontend",
                        "target": "/opt/app/frontend/modules/module"
                    }
                ]
            }
        ]
    }

Using this config inside the single module folder works fine.

Just tested. It works in deploy reloaded.


Which DRM-related DASH interoperability aspects need clarification?

I am currently working on a change request for DASH-IF IOP to clarify interoperable behavior with regard to some DRM interactions in the player. My motivation for initiating that is to clarify one specific aspect that is implemented in non-interoperable ways in different players (multi-key content handling) but I thought that while the topic is under investigation, perhaps other aspects of DRM behavior could also be given a close inspection and clarified by DASH-IF, if appropriate.
Therefore, I would like to request input from player developers and player integrators here: are there DRM related aspects of DASH playback that could use clarification? Do you know of things that are unspecified or underspecified? What causes you headaches?

Thanks for reaching out!
Can you help us understand what you mean about multi-key content handling?  It would be useful for us to understand the issues you've already identified.

The multi-key issue is that there exists at least one player (ExoPlayer) that assumes requesting one key for a presentation (for one adaptation set) will cause the DRM system to make the keys for all encrypted adaptation sets available.  This I believe is contrary to DASH-IF IOP, though it is rather implicitly stated by IOP at the moment and could certainly be spelled out more clearly. At the moment, I am in the process of proposing a change to IOP clarifying this aspect.
The workflow I envision on this topic would be that:

The player determines what keys it needs (via default_KID).
The player requests from the DRM system (CDM) all these keys.
The DRM system makes one or more license requests to get these keys (ideally, batching all the key requests up all up into one license request).
The DRM system processes the license response(s) and notifies the player of the results.

I believe present-day CDMs do not really implement features to batch up license requests, which is why there has been some desire in some places to do this "behind the scenes" key retrieval where requesting one key will actually return many of them (based on some content ID or whatnot in the PSSH). This, however, is not really interoperable and should be discouraged.

I don't understand what you mean about ExoPlayer.  Are you saying that one request results in multiple keys?  Or that ExoPlayer assumes that this will always be the case?
Widevine can deliver multiple keys in one license response, on all platforms.  Is this what you mean about "batching up"?
Shaka Player does not have any hard-coded knowledge of Widevine behavior, nor any other key system.  We assume that multiple requests might be needed.  We do not assume one key per request, nor do we assume multiple keys per request.  We make one request per unique init data.  The number of unique init datas should be less than or equal to the number of unique key IDs.
Depending on how the init data was created, this may result in redundant Widevine licenses (which the Widevine CDM can handle gracefully).  We can't read the provider-specific payload of the init data, so we don't know what we are actually requesting based on that init data.  If the Widevine payload has a content ID that maps to multiple key IDs, then the response may contain multiple keys.

What I meant with regard to ExoPlayer is that it appears to only ever make a single license request, even if multiple keys (as identified by default_KID) are needed to play the selected adaptation sets. It assumes that the license server will somehow know all the keys needed to play all the other adaptation sets, as well, and return them as a set, based on only this single request for a single key.
While it is possible to implement a license server that does this (e.g. by embedding a content ID in the PSSH), it is not really an interoperable way to use DASH. The player should ask the CDM to acquire every default_KID from the selected adaptation sets.
The batching up aspect I mentioned is more to do with the requests, not so much the responses - if the player sees that there are two adaptation sets, one with default_KID "X" and another with default_KID "Y", it knows that two content keys are needed. The player then informs the CDM that it wants to use these keys and requests that the CDM go get them, if needed.
However, there is not really anything in EME that allows one to provide the CDM two sets of Initialization Data at once - as soon as you provide Initialization Data for key X, the CDM will make a license request. Ideally, you would batch up the requests for both key X and key Y into a single license request (for optimization of network traffic and/or control flow in the player). In theory, one might concatenate the PSSH boxes and expect the CDM to understand what is happening but that sort of behavior is not guaranteed by EME, so may not be practical, especially across DRM systems. Hopefully a future version of EME can cover this gap in a standardized way. Considering how many HTTP requests video playback already makes, I think it is not a big deal to request each key individually, but it matters for some, so an optimization here probably should be enabled, hence my talk of batching.
From your description, it sounds like the Shaka Player works in an interoperable way with regard to multi-key content.
The triggering of license requests based on initialization data is perhaps a point of interest, though. The relationship of Initialization Data and EME appears to be still evolving, though based on today's situation I would probably take the view that it is best treated as an opaque blob to be handed over, not triggering any logic by its presence or content (with the default_KID being the trigger for the player's DRM behavior). Reading meaning into PSSHs seems dangerous. Do you have a particular reason for basing the logic on the Initialization Data difference, instead?
I remember a case with dash.js, which also uses the same (Initialization Data based) logic, where this became a problem. For whatever reason, the content workflow created different PSSHs for the same content key in different places (manifest VS init segment, I believe?), which led to two license requests. One of those was rejected by the license server (it had a limit of one), leading to playback failure, despite actually getting a license in the other request. The content of the PSSHs is entirely in the DRM domain, so one cannot really say that such content is wrong in any way. Probably better logic in the player could have survived this situation gracefully. Yet, considering the big picture, it should be possible for people to make players without caring deeply about such edge cases, if they follow interoperable specifications. If dash.js had based its logic on default_KID, it would have survived this issue.

We filter out duplicate init data exactly because we can't read meaning into PSSHs.  Generically, we can't read key IDs out of init data.  PSSH v0 is still in wide use, and it does not contain key IDs in any generic form across key systems.  PSSH v1 makes this better by providing a generically-parseable set of key IDs, but we don't see it in wide use because it seems that some devices don't support it.  (I don't have specific data on PSSH version support in devices.)
Two dissimilar PSSHs may contain the same key IDs, but two identical PSSHs definitely contain the same key IDs, content IDs, whatever, and can obviously be filtered out.
It would be better if we filtered based on key IDs in the manifest, but those are not always provided.  We could start requiring them in Shaka Player for DASH content, but we would not be able to do that unless there was an equivalent in HLS (which we are actively working on).
I think best-effort for Shaka Player would be:

Filter out duplicate init data from any source (we do this now)
Filter out init data from the manifest based on duplicate default_KID, if present (we do not do this currently)

I should also mention that filtering out duplicate init data is something we only do as an optimization.  It should not be strictly necessary, as having two MediaKeySessions containing the same keys is a non-issue on the client side.
So, although I see the benefit in improving this filtering logic to make use of default_KID when available, it is not a high priority for us at this time.  I just filed it as issue #580.

@sandersaares, is there anything else you feel needs discussion here?  Or are we okay to close this issue?

I got some good feedback here. Sounds like we can close this. Thanks!


Get info higher priority - develop

Change Description

related issue #8655
Raise the priority of get_info call for better user response time.

BTW, during get_info calls, NOT seen a significant impact on nodeos syncing latency time,
Consensus Changes

[ ] Consensus Changes

API Changes

[ ] API Changes

Documentation Additions

[ ] Documentation Additions

See #8894


Udemy Error:No Video formats found

Using the latest youtube-dl using pip command ,i gave below command
youtube-dl -u uid -p mypassword --all-formats  https://www.udemy.com/aspnet-web-api-v/learn/v4
But console displayed below error for udemy course
[udemy:course] Downloading login popup
[udemy:course] Logging in
[udemy:course] aspnet-web-api-v: Downloading webpage
[udemy:course] 1630476: Downloading course curriculum
[download] Downloading playlist: ASP.NET Web API from Basic to Advanced
[udemy:course] playlist ASP.NET Web API from Basic to Advanced: Collected 18 video ids (downloading 18 of them)
[download] Downloading video 1 of 18
[udemy] Downloading login popup
[udemy] 9924520: Downloading webpage
[udemy] 9924520: Downloading lecture JSON
ERROR: No video formats found; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.

Could you add original issue resolution,i just see closeure of issue as duplicate,also i checked other issues of udemy wherein you provided account-needed,so many issue pointing same description cant be wrong ?

alot of people having this issue and no one fix it heeeeeelp


loading shperical harmonics from *_ibl.ktx fails on systems locals using , instead of . for decimal separator

Describe the bug
A clear and concise description of what the bug is.
When building my own 3d viewer in open3d which uses filament for rendering i observed that setting indirect lighting  by loading *_ibl.ktx file faild with inability to load spherical harmonics from *_ibl.ktx file. The file contains proper 3 x 9 table for spherical harmonics.
After investigation i figured that the reason for this locals sensitivity is the std::strtof function used on line ilament/libs/image/src/KtxBundle.cpp:298 of current master branch to parse the spherical harmonics list. See also std::strtof reference.
To Reproduce
Steps to reproduce the behavior:

set system locals to for example de_DE or de_UTF8

run your program which uses indirect lighting only

surfaces will be black only

Open editor (eg vi/vim)

replace all . in spherical harmonics list (key sh) with ,

rerun demo

Surface colors will be back

Expected behavior
A clear and concise description of what you expected to happen.
That KtxBundle::getSphericalHarmonics returns valid spherical harmonics list independent of which locals are set on the system filament or filament based library is used.
Screenshots
If applicable, add screenshots to help explain your problem.
std::strtof failing on eg.: German locale

with , as decimal separator eg: in German locale

Logs
If applicable, copy logs from your console here. Please do not
use screenshots of logs, copy them as text.
Desktop (please complete the following information):

OS: [e.g. iOS] Mint 20 i386
GPU: [e.g. NVIDIA GTX 1080] irrelevant
Backend: [OpenGL/Vulkan] guess opengl through intel/open3d python wheel

Smartphone (please complete the following information):

Device: [e.g. Pixel 2]
OS: [e.g. Android Pie 9.0]

Additional context
Add any other context about the problem here.

Thank you! I didn't realize strtof was locale aware :/


The door to the ammunition workbench in Blackrock wont unlock after the code is typed in

Mod Version: v0.10.4
Game Version: v20.2
Launcher: Steam
Additional mods installed: Yes DeveloperConsole
Perspective: Both
Description
The door to the ammunition workbench won't unlock after the code is typed in the keypad during an aurora.
How to reproduce

Host or client.
On region 'BlackrockPrisonSurvivalZone'
Try to open the ammunition workbench door with the code from the mine (3445). Click the keypad next to the door during an aurora.
The door is still locked.

Expected behaviour
The door should have been unlocked after the code is typed during an aurora.
Additional note for a possible fix:
[05:44:09.516] [Sky_Co-op] [Papers codes] Interact with keypad that has code: 3008
When the actual code is 3445.
Logs
Host side log
MelonLoader_22-11-28_05-24-25.213.log
Client side log
MelonLoader_22-11-27_22-25-44.565.log

I can't see problem by logs. You have code for that keypad. It all looks like it should open. Also I am sure I been tested it few weeks ago, it was working flawless. What exact result you have? Keypad does green light, but door wont open? Or keypad still does red?

Hey, Filigrani!
The keypad lits up green, but the door is still locked.
Here's a short video about the issue.
https://youtu.be/2bZ98x6Vm1E

Oh I see what wrong here. You have input keypad password right, earlier. So keypad inactive now, and can't remove lock from the door once again. Looks like you have input password before, and saved with leaving this door closed. This I was able to reproduce this. This door has automatic close trigger when you enter or far away, I think this not properly saved in multiplayer

So actual steps to reproduce:

Get password and aurora.
Open the door.
Save, and then re-join/re-host.
Result: Keypad with green light, and closed door.

Now I wonder if that happends in vanila aswell.
https://youtu.be/sa21NGaaz14

Fixed in latest release.


When Loac Phi 3 error D:\a_work\1\s\onnxruntime\core\session\provider_bridge_ort.cc:1209 onnxruntime::ProviderLibrary::Get [ONNXRuntimeError] : 1 : FAIL : LoadLibrary failed with error 126 "" when trying to load "C:\Users\Strikene\OneDrive\Learn\MS-PHI3\onnxruntime-genai-main\examples\csharp\Genny\Genny\bin\x64\Release_Cuda\net6.0-windows\runtimes\win-x64\native\onnxruntime_providers_cuda.dll

i have a surface book3
1065g7+1660Ti
i have install Cuda 11.8

when i using  examples named 'Genny' load Phi-3-mini-128k-instruct-onnx\cuda\cuda-fp16 got error(CPU is OK) .

Microsoft.ML.OnnxRuntimeGenAI.Cuda" Version="0.2.0-rc3

I am not sure why you're seeing this issue. I am unable to reproduce the issue you're seeing when the PATH has been correctly set to include the cuda binaries (which you have already tried doing it seems).
Could you try with version 0.2.0-rc4? If that does not work, will try to work with you to find a solution.

@strikene Can you please try this with 0.2.0-rc4?


Game Selection List Appears Several Times After Latest Update

As of the latest update, this add-on frequently opens the game selection list for HLTB when there's no game on that site set. I tried to play MTG Arena (which I intentionally did not setup with this add-on) and the game selection list opened twice before the game would load, followed by another time after the game closes. For clarity, I mean this window appears when I hit Play:

I note that this is despite the option to display the game selection list being deselected in the settings for this add-on:

This seems somewhat aggressive and likely in error?
EDIT: After posting this report, this add-on proceeded to show the game selection list for basically every single game in my library that was not already set-up with this add-on. I think something went wrong in the update?

will be fixed with next release.


Add ambulance icon

What is the purpose of this pull request?

[x] New Icon
[ ] Bug fix
[ ] New Feature
[ ] Documentation update
[ ] Other:

Description
Adds ambulance icon as requested by https://github.com/lucide-icons/lucide/issues/119. Closes feather icons issue https://github.com/feathericons/feather/issues/1177.
Icon use case

For navigation applications directing users to the nearest emergency services, or for listing an emergency contact.
Alternative icon designs

Icon Design Checklist
Concept

[x] I have provided valid use cases for each icon.
[x] I have not added any a brand or logo icon.
[x] I have not used any hate symbols.
[x] I have not included any religious or political imagery.

Author, credits & license

[ ] The icons are solely my own creation.
[ ] The icons were originally created in # by @
[x] I've based them on the following Lucide icons: Bus
[ ] I've based them on the following design:

Naming

[x] I've read and followed the naming conventions
[x] I've named icons by what they are rather than their use case.
[x] I've provided meta JSON files in icons/[iconName].json.

Design

[x] I've read and followed the icon design guidelines
[x] I've made sure that the icons look sharp on low DPI displays.
[x] I've made sure that the icons look consistent with the icon set in size, optical volume and density.
[x] I've made sure that the icons are visually centered.
[x] I've correctly optimized all icons to two points of precision.

Before Submitting

[x] I've read the Contribution Guidelines.
[x] I've checked if there was an existing PR that solves the same issue.

I feel like it's okay for the ambulance to be different and more boxy, that's also how they are in reality.

@jguddas But I think the shape of the "truck" of @jordan808 fits way better with the lucide style, it's also vertically centered.
100% side by side:

@jguddas But I think the shape of the "truck" of @jordan808 fits way better with the lucide style, it's also vertically centered.
100% side by side:

Good point.

Below, I've explored some options to achieve greater consistency. The last one is my favorite, where the truck utilizes the same cab style as the ambulance icon in this PR. This choice would also be more modern, as the flat-face cab style (known as cab-overs or flat faces) has become less common in recent decades due to truck size regulations, at least in the U.S.
Here are some of my explorations aimed at enhancing consistency:
Cab heights same (taller):

Cab heights same (shorter):

Cab's styles same (taller):

Cab's styles same (shorter):

What do you all think @jguddas @ericfennis ?

@jordan808 Nice work on the designs. It's hard to see differences. But I think I like the first and the third options. It uses the space on the canvas a bit better.

I like the first option the most.

Do you all want to go with the first option then? If so, we would need to increase the cab height of the ambulance so that it is the same height as the truck if/when we update the truck icon. I'm warming up to the increased cab height anyway because it does utilize the verticle space better.
Proposed change to ambulance
 →
Increase the cab height to reflect potential adjustment to truck icon.
Proposed change to truck
 →
Increase trailer size, cab height, and round corners to 2px radius (Rule #7).
Finalized ambulance and truck comparison

If you all approve, I can make the updated changes to the ambulance if needed.

@jordan808 looks excellent 🤩. I'm in for the new truck icon.

@jordan808 Can you make a PR for the changes for the truck icon?


Updates the metrics package + new metrics controller

This PR does a couple things:

Cleans up the metrics package to be better consumed
Adds an ACME client Factory interface, used to instrument new ACME clients
Use a shared metrics object through out
Bakes in the metrics sync increment for all controllers
Creates a standalone Certificate metrics controller
Adds a metrics integration test
Expose the host and port address for the metrics to be exposed on

The PR should be pretty well split out between each commit.
/assign @munnerz
fixes #2248
Ensure Deleted Certificates no longer expose metrics and better cover all controller metrics.

@munnerz I've updated the metrics a bit so that the Start func receives the listening address which then returns the http.Server. This;

Makes it clear Start starts the server, and New doesn't require a listening address
Exposes the listening address so that we can use that in tests where needed

Note that the metrics server Start func is no longer blocking since we need the listener. Don't think this is too much of a concern... Shutdown is called through the positive flow in ./cmd/controller.

/kind cleanup
/lgtm

/hold

/retest

/retest


Missing json methods for DocList and DocVec

Description:
DocList and DocVec do not have their own json methods, which could improve usability and provide more convenient serialization.
Suggested feature:
Implement json methods for DocList and DocVec to allow users to directly serialize these objects. This would enhance the user experience and provide a more consistent interface for working with DocList and DocVec instances.

For DocVec we do not have, but for DocList we have to_json; is that good enough?
As per the DocVec thing, we have an issue to add in #1330

but it would be nice to have the same interface for Docs, DocLists and DocVecs.

@movchan74 Good point. DocVec will have the same interface as DocList when we will support all of the methods there. For now we only support Protobuf but we json is coming asap.

fyi @movchan74 in today released (0.31.0) we added an alias to_json to BaseDoc to have a similar experience. We will enforce this as much as we can for new and existing method

Closing as duplicate of #1330


Use req.flash properly in passport.authenticate()

Solves an error that existed in the SAML Proxy but wasn't exposed because it required a bad signature in the staging env (in the investigation of vets-contrib #2069) to expose the bug. So, generally speaking, I don't think that we need to worry about this happening to an end user, unless there is another way to cause it. The reason is that ID.me will handle actual authentication errors like bad email/password combination - it never sends a SAMLResponse back to the SAML Proxy with a failure message to my knowledge in a successfully configured environment. Here's what ID.me does if you enter a bad password or username:

Alternative solution would be to remove this.failureFlash = true in SPConfig.
There's also a lot wrong with this currently, as this fix doesn't actually make the error handler comprehensible. It still 404s because passport.authenticate then immediately tries to redirect to SP_ERROR_URL, which we specified via this.failureRedirect in SPConfig. SP_ERROR_URL doesn't have a route handler, though, so we should probably decide what we want that backup to look like in case something is wrong in a deployed env.

so we should probably decide what we want that backup to look like in case something is wrong in a deployed env.

Are you able to demo that? It's probably worth showing in stand-up so everyone can get on the same page.

@dvogel yes can do


Needs other dependencies?

error: 'adc_select_input' was not declared in this scope
error: 'adc_read' was not declared in this scope
error: 'adc_init' was not declared in this scope
I am using Arduino IDE 2.1.1, board Pico Pi

same here, same error

Same errors with PicoW
Here are the incriminated lines:
/home/patrick/Electronique/libraries/Raspberry_Pi_Pico_CPU_Temperature/src/CPU.cpp:13:3: error: 'adc_init' was not declared in this scope; did you mean 'uart_init'?
   13 |   adc_init();
      |   ^~~~~~~~
      |   uart_init
[...]/libraries/Raspberry_Pi_Pico_CPU_Temperature/src/CPU.cpp:14:3: error: 'adc_set_temp_sensor_enabled' was not declared in this scope
   14 |   adc_set_temp_sensor_enabled(true);
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~
[...]/libraries/Raspberry_Pi_Pico_CPU_Temperature/src/CPU.cpp:16:3: error: 'adc_select_input' was not declared in this scope
   16 |   adc_select_input(4);
      |   ^~~~~~~~~~~~~~~~
[...]/libraries/Raspberry_Pi_Pico_CPU_Temperature/src/CPU.cpp: In member function 'float CPU::getTemperature()':
[...]/libraries/Raspberry_Pi_Pico_CPU_Temperature/src/CPU.cpp:20:18: error: 'adc_read' was not declared in this scope
   20 |   uint16_t adc = adc_read();
      |                  ^~~~~~~~

I read also:  many libraries LittleFS.h available.  Is it linked ?
The one used is:
.arduino15/packages/rp2040/hardware/rp2040/3.6.0/libraries/LittleFS
I'll try  . ....   yes, It is linked, but i don't understand how.
Here is the errors with the other LittleFS.h library  (the one out of rp2040 sub-dir
[...]/libraries/LittleFS/src/flash_utils.h:33:10: fatal error: ../../bootloaders/eboot/flash.h: No such file or directory
   33 | #include <../../bootloaders/eboot/flash.h>
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Can not find any flash.h among all my librairies.

Is that the library we're looking for ?
https://www.arduino.cc/reference/en/libraries/flash/

I've found also that:
https://github.com/mcauser/esp8266-Arduino/blob/master/bootloaders/eboot/flash.h

It seems to work.
What I've done:
git@github.com:esp8266/Arduino.git
cd libraries
mv Arduino/bootloaders/ .
rm -Rf Arduino
but another problem occured :
[...]/libraries/LittleFS/src/../../bootloaders/eboot/flash.h:16:10: fatal error: spi_flash_geometry.h: No such file or directory
   16 | #include <spi_flash_geometry.h>
      |          ^~~~~~~~~~~~~~~~~~~~~~

We now have to find spi_flash_geometry.h

Ok, progress ...
Recap:
git clone git@github.com:esp8266/Arduino.git
cd libraries
mv Arduino/bootloaders/ .
mv Arduino/tools/sdk/include/spi_flash* LittleFS/src/.
mv Arduino/cores/esp8266/flash_hal.* LittleFS/src/.

And now, in
LittleFS/src/LittleFS.h:38:10: fatal error: ../lib/littlefs/lfs.h
it seems that we need to change lfs.h for lfs.c

We're almost there!!!!

NOP!
All this for nothing, back to the beginning ...   we must know which ilbrairies   DeimosHall uses.

Sorry guys, let me check it and I'll answer you tomorrow.

In my Arduino IDE list of available librairies, I found one named LittleFS_Mbed_RP2040  which corresponds exactly to what we want:  read a RP2040

Solution
The main problem is the RP2040 core. I know two options, the Philhower core (doesn't work with my library) and Oficial Arduino mbed core.
Compiling with Philhower core:
❯ make compile
arduino-cli compile --fqbn rp2040:rp2040:rpipico
/Users/deimos/Documents/Arduino/libraries/Raspberry_Pi_Pico_CPU_Temperature/src/CPU.cpp: In member function 'void CPU::begin()':
/Users/deimos/Documents/Arduino/libraries/Raspberry_Pi_Pico_CPU_Temperature/src/CPU.cpp:13:3: error: 'adc_init' was not declared in this scope; did you mean 'uart_init'?
   13 |   adc_init();
      |   ^~~~~~~~
      |   uart_init
/Users/deimos/Documents/Arduino/libraries/Raspberry_Pi_Pico_CPU_Temperature/src/CPU.cpp:14:3: error: 'adc_set_temp_sensor_enabled' was not declared in this scope
   14 |   adc_set_temp_sensor_enabled(true);
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~
/Users/deimos/Documents/Arduino/libraries/Raspberry_Pi_Pico_CPU_Temperature/src/CPU.cpp:16:3: error: 'adc_select_input' was not declared in this scope
   16 |   adc_select_input(4);
      |   ^~~~~~~~~~~~~~~~
/Users/deimos/Documents/Arduino/libraries/Raspberry_Pi_Pico_CPU_Temperature/src/CPU.cpp: In member function 'float CPU::getTemperature()':
/Users/deimos/Documents/Arduino/libraries/Raspberry_Pi_Pico_CPU_Temperature/src/CPU.cpp:20:18: error: 'adc_read' was not declared in this scope
   20 |   uint16_t adc = adc_read();
      |                  ^~~~~~~~

Compiling with Oficial Arduino mbed core:
❯ make compile
arduino-cli compile --fqbn arduino:mbed_rp2040:pico
Sketch uses 91585 bytes (4%) of program storage space. Maximum is 2097152 bytes.
Global variables use 42824 bytes (15%) of dynamic memory, leaving 227512 bytes for local variables. Maximum is 270336 bytes.

Used library                      Version Path
Raspberry Pi Pico CPU Temperature 0.1.0   /Users/deimos/Documents/Arduino/libraries/Raspberry_Pi_Pico_CPU_Temperature

Used platform       Version Path
arduino:mbed_rp2040 4.0.6   /Users/deimos/Library/Arduino15/packages/arduino/hardware/mbed_rp2040/4.0.6

You can install the Oficial Arduino mbed core using Arduino IDE, just open boards manager and type RP2040 or something similar and install the core.

For me the solution does't work because I'm using a Pico-W.   Pico-W is not defined in the mbed-Core, but it is in the Philhower's one.
I've tried with mbed-Core / without Philhower-core.  Anything linked with Wifi doesn't work
I've tried with mbed-Core  AND with  Philhower-core.  The same adc_read error is back.
On my side, it seams to be all about the call of CPU libraries.  I'll try to call the mbed-Core's CPU libraries with both mbed-Core AND Philhower's-core installed and let you know.

Let me know how can I help to solve this.
It must work with PicoW as it does with Pico  it's all about keeping the library up-to-date.

Could you please test the latest version 1.0.0? I solved your problem

Good!

Your test.ico sketch works with Pico-W card.
In my personnal sketch, it works also

Thanks!

Your welcome :D


Android build crashes when typing in LineEdit and TextEdit

Tested versions
Reproducible in: 4.2.2 stable (possible regression)
System information
Android 7.1.1 (ColorOS v3.2) - OPPO F5 (CPH1723)
Issue description
Both LineEdit and TextEdit cause the Android app to crash when you try to type. Mostly when type second symbol.
Steps to reproduce

Add a LineEdit or TextEdit to the scene;
Export to Android;
Run the app and try to type something in LineEdit/TextEdit;

Minimal reproduction project (MRP)
LineEditAndroidBug-godot4.2.zip

I did the test with my redmi 7 (android 10) and no crash happens even after type more than 300 characters

UPD:
Not reproduced on latest android versions.
test with OPPO Reno2 ColorOS v11.1 Android 11 not crashed


[Feature request] Ability to set the source directory

Clear and concise description of the problem
Context
I'm currently looking to add documentation for a monorepo project. The current structure of the monorepo is a packages directory containing all the modules with their own README.md files. Ideally, I want to use Vuepress to create documentation using this pretty standard monorepo structure.
Problem
The problem I'm running into is that I don't see a way to change what vuepress uses as the sourceDir, so I can't tell vuepress to use the markdown files that already exist in the project.
Suggested solution
Allow users to set the sourceDir so instead of having to put all my markdown files in docs, I could set the source directory to the root of the project/ and keep the structure of the monorepo.
Alternative
No response
Additional context
No response

Allow users to set the sourceDir so instead of having to put all my markdown files in docs, I could set the source directory to the root of the project/ and keep the structure of the monorepo.

vuepress dev [dir]

vuepress build [dir]

So if you want abc
vuepress dev abc
vuepress build abc

If you want rootDir
vuepress dev .
vuepress build .

What's the problem here?


Trailing whitespaces lead to failures during the execution

Is your feature request related to a problem? Please describe.
In the Camunda Modeler, I created a BPMN process for Camunda Cloud. The process had a service task with an error boundary event attached to it. By accident, the error code of the error event had trailing whitespace.
The process was deployed successfully and process instances were created. While executing the process instances, error events were thrown from the job worker. These error events were not caught because of the trailing whitespace in the model. As a result, it created incidents.
Besides error events, similar problems can occur on other technical attributes (e.g. message name, job type, etc.).
Describe the solution you'd like
The Camunda Modeler detects trailing whitespace and removes them. I see no valid use case for having trailing whitespace.
Describe alternatives you've considered
Instead of removing trailing whitespace, the Camunda Modeler could show warnings that highlight the problem.
Additional context
Camunda Modeler for Camunda Cloud:

We found this behavior in a Gameday.
The issue is similar to #720

Hi. this is a issue that I see on trainings for Camunda Platform from time to time. It's very confusing for beginners.

Thanks for reporting. That's something we can likely detect once we have proper (execution platform) linting.
/cc @andreasgeier

IMHO, linting is the second-best option (from a UX perspective). If there is no specific case fur such whitespace, I would prefer to automatically remove them (for instance, onblur or onfocusout). Same for whitespace at the beginning?
Do we already have examples of such "smart behavior" in the Modeler or what that be new?
From a development perspective, of course, linting could be a quick fix since we already plan to provide this feature.

If there is no specific case fur such whitespace, I would prefer to automatically remove them (for instance, onblur or onfocusout).

Agreed. How hard would it be to trim whitespace on blur?

I'm curious how that would work. Trimming the whitespace on blur would result in a command, that the user doesn't notice but can then undo. 🤔

@philippfromme https://github.com/bpmn-io/diagram-js/pull/535 would proof useful here.

Confirmed again by internal feedback.

To add to this and bring up the topic again:
In a recent developer training, a trailing whitespace at the end of a message name for a catching message event led to an error that took quite long resolve. This wasn't the only case where this happened.
Generally participants like to copy IDs and message names from websites by double clicking on them. In that case, very often the browser selects the ID/name with a trailing whitespace which is not noticed and copied straight into the modeler property text field.


Example code not working

How to reproduce:
php version
PHP 7.2.9-1+ubuntu16.04.1+deb.sury.org+1 (cli) (built: Aug 19 2018 07:16:12) ( NTS )
Copyright (c) 1997-2018 The PHP Group
Zend Engine v3.2.0, Copyright (c) 1998-2018 Zend Technologies
    with Zend OPcache v7.2.9-1+ubuntu16.04.1+deb.sury.org+1, Copyright (c) 1999-2018, by Zend Technologies

packages
composer require phpmailer/phpmailer
composer require thefox/smtpd
composer require monolog/monolog

server.php
<?php

// Import PHPMailer classes into the global namespace
// These must be at the top of your script, not inside a function
use TheFox\Smtp\Server;
use TheFox\Smtp\Event;
use Zend\Mail\Message;
use Monolog\Logger;
use Monolog\Handler\StreamHandler;

//Load Composer's autoloader
require 'vendor/autoload.php';

// Generate certificate
$privkey = openssl_pkey_new();
$cert = openssl_csr_new([
    'countryName' => 'UK',
    'stateOrProvinceName' => 'Isle Of Wight',
    'localityName' => 'Cowes',
    'organizationName' => 'Open Sauce Systems',
    'organizationalUnitName' => 'Dev',
    'commonName' => '<IP_ADDRESS>',
    'emailAddress' =><EMAIL_ADDRESS>], $privkey);
$cert = openssl_csr_sign($cert, null, $privkey, 365);

// Generate PEM file
$pem = [];
openssl_x509_export($cert, $pem[0]);
openssl_pkey_export($privkey, $pem[1]);
$pem = implode($pem);

// Save PEM file
$pemfile = 'server.pem';
file_put_contents($pemfile, $pem);
$listenOptions = [
    'ssl' => [
        'verify_peer' => false,
        'local_cert' => $pemfile,
        'allow_self_signed' => true,
    ],
];

// Create a Logger with Monolog.
$logger = new Logger('smtp_example');
$logger->pushHandler(new StreamHandler('php://stdout', Logger::DEBUG));

$server = new Server([
    'ip' => '<IP_ADDRESS>',
    'port' => 587,
    'logger' => $logger,
]);
if(!$server->listen($listenOptions)) {
    print 'Server could not listen.' . "\n";
    exit(1);
}

$server->addEvent(new Event(Event::TRIGGER_NEW_MAIL, null, function(Event $event, string $from, array $rcpts, Message $mail) {
    // Do Stuff
}));

$server->addEvent(new Event(Event::TRIGGER_AUTH_ATTEMPT, null, function($event, $type, $credentials): bool {
    return true;
}));

$server->loop();

email.php
<?php

// Import PHPMailer classes into the global namespace
// These must be at the top of your script, not inside a function
use PHPMailer\PHPMailer\PHPMailer;
use PHPMailer\PHPMailer\Exception;

//Load Composer's autoloader
require 'vendor/autoload.php';

$mail = new PHPMailer(true);                              // Passing `true` enables exceptions
try {
    //Server settings
    $mail->SMTPDebug = 2;                                 // Enable verbose debug output
    $mail->isSMTP();                                      // Set mailer to use SMTP
    $mail->Host = 'localhost';  // Specify main and backup SMTP servers
    $mail->SMTPAuth = false;                               // Enable SMTP authentication
    // $mail->Username =<EMAIL_ADDRESS>                // SMTP username
    // $mail->Password = 'secret';                           // SMTP password
    $mail->SMTPSecure = 'tls';                            // Enable TLS encryption, `ssl` also accepted
    $mail->Port = 587;                                    // TCP port to connect to
    $mail->SMTPOptions = array(
        'ssl' => array(
            'verify_peer' => false,
            'verify_peer_name' => false,
            'allow_self_signed' => true
        )
    );

    //Recipients
<EMAIL_ADDRESS>'Mailer');
<EMAIL_ADDRESS>'Joe User');     // Add a recipient
    $mail->addAddress('ellen@example.com');               // Name is optional
<EMAIL_ADDRESS>'Information');
    $mail->addCC('cc@example.com');
    $mail->addBCC('bcc@example.com');

    //Attachments
    // $mail->addAttachment('/var/tmp/file.tar.gz');         // Add attachments
    // $mail->addAttachment('/tmp/image.jpg', 'new.jpg');    // Optional name

    //Content
    $mail->isHTML(true);                                  // Set email format to HTML
    $mail->Subject = 'Here is the subject';
    $mail->Body    = 'This is the HTML message body <b>in bold!</b>';
    $mail->AltBody = 'This is the body in plain text for non-HTML mail clients';

    $mail->send();
    echo 'Message has been sent';
} catch (Exception $e) {
    echo 'Message could not be sent. Mailer Error: ', $mail->ErrorInfo;
}

run server & send email:
sudo php server.php
php email.php

server.php output:
[2018-10-23 19:22:54] smtp_example.INFO: start [] []
[2018-10-23 19:22:54] smtp_example.INFO: ip = "<IP_ADDRESS>" [] []
[2018-10-23 19:22:54] smtp_example.INFO: port = "587" [] []
[2018-10-23 19:22:54] smtp_example.INFO: hostname = "localhost.localdomain" [] []
[2018-10-23 19:22:54] smtp_example.NOTICE: listen ok [] []
[2018-10-23 19:23:06] smtp_example.DEBUG: client 1 data send: "220 localhost.localdomain SMTP Service Ready" [] []
[2018-10-23 19:23:06] smtp_example.DEBUG: client 1 data send: "250-localhost.localdomain\n250-AUTH PLAIN LOGIN\n250-STARTTLS\n250 HELP" [] []
[2018-10-23 19:23:06] smtp_example.DEBUG: client 1 data send: "220 Ready to start TLS" [] []
[2018-10-23 19:23:06] smtp_example.DEBUG: client 1: collect data [] []
[2018-10-23 19:23:06] smtp_example.DEBUG: client 1: collect data [] []
[2018-10-23 19:23:06] smtp_example.DEBUG: client 1: collect data [] []
[2018-10-23 19:23:06] smtp_example.DEBUG: client 1: collect data [] []
[2018-10-23 19:23:06] smtp_example.DEBUG: client 1: collect data [] []
[2018-10-23 19:23:06] smtp_example.DEBUG: client 1: collect data [] []
[2018-10-23 19:23:06] smtp_example.DEBUG: client 1: collect data [] []
[2018-10-23 19:23:06] smtp_example.DEBUG: client 1: collect data [] []
[2018-10-23 19:23:06] smtp_example.DEBUG: client 1: collect data [] []
[2018-10-23 19:23:06] smtp_example.DEBUG: client 1: collect data [] []
[2018-10-23 19:23:06] smtp_example.DEBUG: client 1: collect data [] []
[2018-10-23 19:23:06] smtp_example.DEBUG: client 1: collect data [] []
... (repeats forever) ...

email.php output:
2018-10-24 00:23:06	SERVER -> CLIENT: 220 localhost.localdomain SMTP Service Ready
2018-10-24 00:23:06	CLIENT -> SERVER: EHLO tim-workstation
2018-10-24 00:23:06	SERVER -> CLIENT: 250-localhost.localdomain
                   	                  250-AUTH PLAIN LOGIN
                   	                  250-STARTTLS
                   	                  250 HELP
2018-10-24 00:23:06	CLIENT -> SERVER: STARTTLS
2018-10-24 00:23:06	SERVER -> CLIENT: 220 Ready to start TLS
2018-10-24 00:23:06	CLIENT -> SERVER: EHLO tim-workstation
2018-10-24 00:23:08	SERVER -> CLIENT:
2018-10-24 00:23:08	SMTP ERROR: EHLO command failed:
2018-10-24 00:23:08	SMTP NOTICE: EOF caught while checking if connected

The server does not appear to be receiving the "EHLO tim-workstation" command that is being sent by PHPMailer and so it just continually spins with no received data. Are you able to reproduce this? Do you know why this might be happening? Your library appears to be using a custom networking library and I'm not familiar enough with the low-level networking functions to debug effectively. If you could point me in the right direction I could probably write up a fix.

Having the same problem, and I've narrowed it down a bit.  If I turn off TLS on the sending side, the server works as expected.  Not sure where to go from here to debug further, though...

Hi, I'm sorry for this. I have to debug the code line-by-line. Maybe rewriting the example from scratch with a better approach. And creating the certificate in the example code is not a good idea. This script should not focus on creating an SSL certificate, but only on handling the SMTP server.

Nothing to be sorry for!  Bugs are part of the process (assuming it even is a bug).  If it helps, the stream_socket_enable_crypto call at StreamSocket.php:170 does not return an error or warning, but once it has been called the stream_socket_recvfrom call at line 135 starts returning FALSE.  Of course this should be returning a string, but even worse is that the dataRecv method of the Client class does not know what to do with a FALSE response, so it keeps looping and looping.

More info, in case it may help:  I removed the self-signed certificate and purchased a real one.  The problem still exists, so I don't believe the self-signing is the issue (but of course I may have screwed up the certificate somehow).  If there's anything else I can do to help track this down, please let me know.

Technically there is no different between a self-signed certificate and a purchased real one.

Indeed; I interpreted the second line of your original response to indicate you thought the certificate creation in the example code may be a problem, so I tried to verify that it is not.  If I misinterpreted your comment, I apologize.

Ah, I see. This was a miscommunication.
I meant that the example script and this project should not focus on creating certificates at all. Only take the path to an existing certificate. I'll remove the example in the next version and create an extra examples directory with different example files.

Testing with OpenSSL command line doesn't give me any hints, but perhaps you will understand the attached log better.
openssl.log

Progress, maybe.  At least some information, if not a fix.  Replace stream_socket_recvfrom and stream_socket_sendto with fread and fwrite, respectively, and it works.

@jonevance @zookatron Are you on master, or a specific version?

0.3

That's really old. We are already at 0.7.

Sorry about that.  Your README.rd instructs to install via:
composer.phar require "thefox/smtpd=~0.3"
I've upgraded to 0.7 and the problem persists, and is still "fixable" by swapping the recv and send with fread and fwrite.

Hi all,
@TheFox I've tried several different versions of the library and they all appear to have the same bug for me, including version 0.7.
@jonevance Your "replace stream_socket_recvfrom and stream_socket_sendto with fread and fwrite" fix is working perfectly for me, thanks, that is a huge help! @TheFox Any chance we could get this fix merged into master? Would it help to create a PR?

Prefer to have the stream functions work, of course, but I've tried everything; the problem really seems to be in the underlying system.

@TheFox Same happens here with the current master.
[2019-04-10 15:22:33] smtp_example.DEBUG: client 1: collect data [] []
[2019-04-10 15:22:33] smtp_example.DEBUG: client 1: collect data [] []
[2019-04-10 15:22:33] smtp_example.DEBUG: client 1: collect data [] []
[2019-04-10 15:22:33] smtp_example.DEBUG: client 1: collect data [] []

$ php -v
PHP 7.2.14 (cli) (built: Jan 31 2019 00:51:06) ( NTS )
Copyright (c) 1997-2018 The PHP Group
Zend Engine v3.2.0, Copyright (c) 1998-2018 Zend Technologies

I ran into the same issue and can confirm that https://github.com/TheFox/network/pull/1 from @aaronschmied fixes it


ui: Add error boundary in the React UI

[ ] I added CHANGELOG entry for this change.
[x] Change is not relevant to the end user.

Changes

Add a error boundary to the React UI. Now in case of an irrecoverable error, users would see a "Something went wrong" page instead of a blank screen.
Fix the crash when there is no store connected to the Querier. The crash was because the API response for /api/v1/label/__name__/values was

{
  "status": "success",
  "data": null
}

Here, the UI expects data to be an array.
Fixed this by sending an empty array ([]) instead of null
Verification
Tested locally by emulating error conditions.
Screenshot

looks great. See,s that we need to fix a linting error. This may require regeneration of the bindata.go


bedtools sort -chrThenSizeA does not sort by chr position

Hi,
I wonder why some entries get never sorted using. Note on the second row "should be" 2189552.
$ bedtools sort -chrThenSizeA -i broken.bed | head
chr1	2189550	2189551	32
chr1	2189551	2189552	35
chr1	2189578	2189579	44
chr1	2189579	2189580	43
chr1	2189597	2189598	41
chr1	2189598	2189599	40
chr1	2189599	2189600	41
chr1	2189600	2189601	39
chr1	2189601	2189602	40
chr1	2189602	2189603	41
$

$ grep -n 2189552 broken.bed
2:chr1	2189551	2189552	35
9251:chr1	2189552	2189554	36
$

This gets caught by
$ ... | bedtools merge -i - -o median -c 4 -d 0
Error: Sorted input specified, but the file - has the following out of order record
chr1	2189552	2189554	36
$

In contrary, sort-bed 2.4.26 utility from http://bioinformatics.oxfordjournals.org/content/28/14/1919.abstract works.
I want to sort by chr name and then by chr position, nothing fancy. Seems -chrThenSizeA the closest option. I use 2.29.2 version. Thank you.
test.bed.txt

As the name of the option implies, this sorts by chrom, then intervals by their size, not start position.
By default, bedtools sort sorts by chrom, then start. That said, a faster option is UNIX sort: sort -k1,1 -k2,2n in.bed > out.sorted.bed

Thanks. Please make it clear in the runtime help text. commonly, default settings are emphasized in some way. If the default "sort by chrom, then start" has no dedicated runtime option, make this clear in the help output elsewhere. Or ideally, just make an option for this (another reason is in the next sentence).
The sort -k1,1 -k2,2n in.bed will break place chr10 before chr2 so that is why I was hoping bedtools will do the natural sort for me. Bedtools also complain about
***** WARNING: File /dev/fd/63 has inconsistent naming convention for record:
HLA-A*01:01:01:01	0	3503	0

so I have to grep-away those lines. I guess the sorting would be wrong with the simple unix sort too. Similarly with unassigned chromosome loci, etc. Basically, you know what ordering have the hg19 and hg38 files which I want to achieve. ;-)

will do.  Use UNIX version sort for natural sorting (sort -V).


configure your repository to block merging to main until ContinuousIntegration (CI) checks have passed

Hello @zerubabel4, why do you have two issues? one is enough and you can change the title to be similar to your colleagues.

O okay mr.samirm00 i will fix it now

@zerubabel4  Great! please don't call me mr ,  Samir is good.

sure 😁


Always return true from DynamicJsonObject.TryGetMember

-Prevents exceptions (returning false from TryGetMember throws an exception)
-Returns null if the member has not been defined.
-Returns null if the member actually contains null.
-Includes unit tests

Use HasMember first in guard clause

I just saw this was declined.  Basically, this change would allow us to assign values to DynamicJsonObjects using the dynamic type without referring to the dictionary values.  In other words, if I want to create a DynamicJsonObject, I could do so like this:
dynamic obj = new DynamicJsonObject();
obj.c_CsSubmittedBy = "me";

Rather than:
var obj = new DynamicJsonObject();
obj["c_CsSubmittedBy"] = "me";

This pull request was a matter of convenience.  I don't think this takes away from any functionality, but rather adds another way to setup new DynamicJsonObjects.


Skip ASG in case no instance is present

This fixes a bug which let the operator crash in case ASG are not having EC2 instances.

Going with a ping 🤞🏻


Jennie demo branch

hello!

@ngonz hey hows your day going?

@JennieOhyoung It's going great.  I'll start reviewing now!

Looks like some minor changes 👍


Cannot parse

Hi, I found that an extra character would be inserted into the HTML  if it contained  . Here is my code, it's very simple, just read an HTML and output it.
#include "lexbor/core/base.h"
#include "lexbor/core/types.h"
#include "lexbor/html/parser.h"
#include "lexbor/html/serialize.h"

int main() {
    const char* html = "

";
    lxb_html_parser_t* parser = lxb_html_parser_create();
    lxb_status_t status = lxb_html_parser_init(parser);

    if (status != LXB_STATUS_OK) {
        return 1;
    }

    /* Parse */
    lxb_html_document_t* document = lxb_html_parse(parser, reinterpret_cast<const lxb_char_t *>(html), strlen(html));
    if (document == nullptr) {
        return 1;
    }

    /* Create Collection for elements */
    lxb_dom_collection_t* collection = lxb_dom_collection_make(&document->dom_document, 128);
    if (collection == nullptr) {
        return 1;
    }
    /* Get BODY element (root for search) */
    lxb_html_body_element_t* body = lxb_html_document_body_element(document);
    lxb_dom_node_t* bodyNode = lxb_dom_interface_node(body);

    lexbor_str_t str {};
    lxb_status_t serialStatus = lxb_html_serialize_tree_str(bodyNode, &str);
    if (serialStatus != LXB_STATUS_OK) {
        return 1;
    }
    size_t len = str.length;
    printf("%s", str.data);
}

I expected the output would be the same as the original one, since I didn't do anything about it. However, it was not. An extra character 0xc2 was inserted before  :

�

Since 0xc2 was not a valid character, it was rendered as �. Could you look at this issue and see if it could be fixed? Thanks a lot!

Hi @searene,
Fixed.
Thanks for the report!


reject weak keys

RFC 7518 says:

A key of the same size as the hash output (for instance, 256 bits for "HS256") or larger MUST be used with this algorithm. (from Section 3.2. HMAC with SHA-2 Functions)

A key of size 2048 bits or larger MUST be used with this algorithm. (from 3.3.  Digital Signature with RSASSA-PKCS1-v1_5)

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

18 of 48 (37.5%)  changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.5%) to 52.569%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

jwa/hs/hs.go
12
16
75.0%

jwa/ps/ps.go
3
16
18.75%

jwa/rs/rs.go
3
16
18.75%

Totals

Change from base Build<PHONE_NUMBER>:
-0.5%

Covered Lines:
757

Relevant Lines:
1440

💛  - Coveralls


feat: schema for Subwayside

You can see the live version at https://paulswartz.github.io/schemas/events/com.mbta.ctd.subwayside.train-heartbeat

Oh one last question: is there a specific reason so many fields are named *Dt etc instead of *Date?

Oh one last question: is there a specific reason so many fields are named *Dt etc instead of *Date?

*Dt is for date-time. I'd probably have used *Date for actual dates, or *Time for times.

question: why do some fields use abbreviations like nbr or Dt?

The fields are nbr or *nbr in the database, but I can change that. Some options that come to mind:

number
carNumber
carId

@bklebe I've updated all the Nbr to Number, but kept Dt.


Input: fixing issue of multiple Inputs not working on the same screen

The way this was fixed was the following:

Added a central Keyboard module that handles keyboard events.
Inside Revery_UI we subscribe to those events and handle them in Keyboard.re
we handle those by getting the focused node and calling the handler methods on that if they exist.

This issue was created to address https://github.com/revery-ui/revery/issues/290

Perfect, thanks for the updates! 👍  Merging now.


marker as image

Hello,
I am displaying Marker Icon in the map today :

To be more trendy would it be possible to have a image/gif instead of an icon.
Im thinking about something like in snapchat :

Would that be possible ?

you want animated marker ?
if that true unfortunately technically i could face some issue on iOS or web i need to see how i could do it its not easy feature

you want animated marker ? if that true unfortunately technically i could face some issue on iOS or web i need to see how i could do it its not easy feature

I think having image marrker and animated marker will be a very cool feature for the plugin.

image marker i can add it
i will see better solution for image marker and provide new API for markers
for animated marker its little bit difficult

image marker i can add it i will see better solution for image marker and provide new API for markers for animated marker its little bit difficult
image marker is already a good start...
Thank you very much

Hello @liodali have you started looking into it? Do you think it is doable?

yeah its doable i will start working on it this week
i will need some help from you if you can share some asset to test with at least i can propose some api to set image as marker
because we need to make sure that image will not loose the quality and fit correctly into the wiget

yeah its doable i will start working on it this week i will need some help from you if you can share some asset to test with at least i can propose some api to set image as marker because we need to make sure that image will not loose the quality and fit correctly into the wiget

No problem at all. Who do you the format you would like to use (png, jpg, svg...) ?
And what is the size of the image (32x32, 48x48, 64x64) ?
I will be available to make tests if needed.

if you can provide 3d image that you have in use case
because you  can use iconWidget  in MarkerIcon   to show flutter widget but better to be directly Image
if you have custom widget to show gif i think i need to add new API in MarkerIcon
can you share with me gif image and one static image also (im planning to add isComplex that will help render to provide more time for rendering)

if you can provide 3d image that you have in use case because you can use iconWidget in MarkerIcon to show flutter widget but better to be directly Image if you have custom widget to show gif i think i need to add new API in MarkerIcon can you share with me gif image and one static image also (im planning to add isComplex that will help render to provide more time for rendering)

I have uploaded a gif and png file.

I started making implementation for gif makers technically for now im working on android side and our implementation work fine
i will try to make it available soon for mobile (for web i need more time to find suitable way to provide API as in mobile )
for image marker use iconWidget in MarkerIcon it should work fine

Hell @liodali, have you made any progress on this feature ?

I was fighting with ios to make it work
unfortunately i need to change the implementation for both android to support gif because in ios we only use uiimage so i need animator thread to manage multiple frames
you could do that use addMarker and setMarkerIcon but also its complicated for both sides
i need to take my time for to provide something will at least no break existing api

hello @liodali have you made some progress on the feature ? Anything I can do to help ? Thx

@liodali thanks for your reply. What is the Vectortile feature ?


Updating docs to include triage and maintain permissions, as per PR #303

I spent a little bit of time last week digging around until I discovered that triage and maintain permissions had been added in #303 so I tweaked the docs to include mention of them.

Thanks for this @MatStace and apologies for your time spent digging in. 🙇


Cast nested values in POST/PUT/PATCH operations

Feature Description

Working with the CRUD Service, we noticed that all the values included in request body are casted to the relative type, accordingly to the JSON Schema definition, but this works only on first-level fields.
As example, taking into account the books collection definition, the publishDate property have type Date because I want it to be transformed from a string to an ISODate. The same doesn't happen from the property date inside editionDates, which is a { type: "string", format: "date-time" } but it is located inside an array, and any POST/PUT/PATCH operation will save the value as a regular string (or whatever it is included in the request body).
Desired solution

The function QueryParser.traverseBody is used to transform values of every field defined in the JSON Schema definition.
It would be great if the method would be recursive, and operates inside objects and arrays.
The property fieldDefinition already contains the definitions also for nested types (after #252), so that part is already done.
Possible alternatives

Unfortunately there are no alternative for this issue, other than having these fields at root level. If a property must be included into an array, however, the problem persist.

I'm interested in this issue.
The main problem is that we need to potentially change our data model to avoid this limitation.
It could be a very nice addition for the crud.
Also: if the console would allow us to specify nested objects data models graphically, it would be even better


updated feedstock to version 0.5.1

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

Hi! This is the friendly automated conda-forge-linting service.
I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.
Here's what I've got...
For recipe:

requirements: run: numpy<1.21,>=1.17 must contain a space between the name and the pin, i.e. numpy <1.21,>=1.17
requirements: run: pyyaml>=5.1 must contain a space between the name and the pin, i.e. pyyaml >=5.1

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@conda-forge-admin, please restart ci

@conda-forge-admin, please rerender


New Provider: do.de

I am not sure how to implement it. do.de only offers an https://www.do.de/api/letsencrypt endpoint that allows creating and deleting TXT records. There is no public API to manipulate other records.
API Documentation (archived, but the API is still the same)

Thanks for the contribution!


documentation

The repo template works nicely, I had a small misunderstanding with the docker-compose.yaml file:
I was modifying the one in the repo and didn't realize that I should have downloaded it and placed it in my unzipped folder
We should indicate it in the docs in some way, for newbies like me. A sentence would be enough. What do you think @hampusnasstrom ?

Ah, yeah. That might be good. I could even delete it after putting it in the zip?

you mean delete it from the repo?

Yeah, since you will have to change it locally if you want to change it anyways.

I'm not sure, it might be nice to keep it there, if you want to share with someone your repo and tell to download it.
Can it be placed in a folder maybe? Or even there is fine. Just expliciting its use in the docs would be okay

I think this is not relevant anymore since the docker compose file is now part of the repo.