Support for ILookup<,>

We recently added built-in support for IReadOnlyList<> (#941), IReadOnlyDictionary<,> (#980) and ISet<> (#983).
The one left out is ILookup<,>.
Unluckily this is a tricky one because there is only one implementation (Lookup<TKey, TValue> and this one has no public constructor.
I have a working customization for a closed generic form but I wonder if it can be reimplemented so that it works for open generics and then can be added to the default registration.
fixture.Customize<ILookup<string, int>>(c => c.FromFactory((IDictionary<string, IEnumerable<int>> input) => input.SelectMany(i => i.Value, (item, value) => new { key = item.Key, value }).ToLookup(k => k.key, v => v.value)));

maybe @zvirja knows an awesomely clean way of doing it?

And than's again for raising the issue 🙇
Honestly, I'm a bit reluctant of adding this type to the core library. While ILookup interface is a part of BCL and standard libraries, for me it looks a bit non-trivial collection. Therefore, it might be totally fine that it's not generated out of the box. After all, AutoFixture isn't supposed to support each type in BCL we have.. 😕
As for the customization implementation, it's might be like following:
public class LookupBuilder: ISpecimenBuilder
{
    public object Create(object request, ISpecimenContext context)
    {
        if (request is Type typeRequest
            && typeRequest.IsGenericType
            && typeRequest.GetGenericTypeDefinition() == typeof(ILookup<,>))
        {
            var args = typeRequest.GetGenericArguments();
            return this.GetType()
                .GetMethod(nameof(GenerateTypedLookup), BindingFlags.Static | BindingFlags.NonPublic)
                .MakeGenericMethod(args)
                .Invoke(null, new object[] { context });
        }

        return new NoSpecimen();
    }

    private static ILookup<TKey, TValue> GenerateTypedLookup<TKey, TValue>(ISpecimenContext context)
    {
        return context.CreateMany<KeyValuePair<TKey, IEnumerable<TValue>>>()
            // Make sequence flat to later generate lookup from it.
            .SelectMany(kv => kv.Value.Select(v => new KeyValuePair<TKey, TValue>(kv.Key, v)))
            .ToLookup(kv => kv.Key, kv => kv.Value);
    }
}

And usage:
var fixture = new Fixture();
fixture.Customizations.Add(new LookupBuilder());

fixture.Create<ILookup<int, string>>();

I'd suggest to hold on this feature and see whether there are more requests for it. If they are, we could make another decision.
@moodmosaic You are invited to share your opinion as well 😉 Probably, that's me who used this interface rarely and it appears to be a common one.

I think I would just go with an ad-hoc customization for it... After all, you do need custom, ad-hoc, stuff when working with AutoFixture.
Not that I wouldn't like this to be inside AutoFixture, it's just that there's a fair amount of work to be done in order to include it (tests, façade tests, maintenance).
I've used AutoFixture for years in some fairly sized codebases and I've never seen ILookup<K, V> so perhaps it's not so common interface?

@moodmosaic Thanks for your thoughts, they confirmed my initial intention 😃
@Kralizek Given that there is a relatively simple way to enable this feature in your solution, would you be fine if we close this issue for now? If later there are more requests for it, we could re-open it again.

@zvirja so far you don't cancel the LookupBuilder above until I have time to copy it, no problem. We are just seeing somewhere else that a feature might not appear needed at the current time but might be needed later on.

Well, it's impossible to remove issues from GitHub. Even after I close it, you can still find it using the Search and use the code sample above.
Therefore, you will have ages to copy the sample above 😄


make SimpleAvroKeyGenerator support multi partition key

Change Logs
make SimpleAvroKeyGenerator support multi partition key
Impact
Describe any public API or user-facing feature change or any performance impact.
No, this change is forward compatibility
Risk level (write none, low medium or high below)
NO
Documentation Update
Describe any necessary documentation update if there is any new feature, config, or user-facing change
NO

The config description must be updated if new configs are added or the default value of the configs are changed
Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
ticket number here and follow the instruction to make
changes to the website.

Contributor's checklist

[ ] Read through contributor's guide
[ ] Change Logs and Impact were stated clearly
[ ] Adequate tests were added if applicable
[ ] CI passed

I found CI was failure for other UT, should I do something?

This change is probably not needed. Let me circle back on this in a while @punish-yh

@pratyakshsharma Thanks so much for the review ~


Simplify Query Level Permissions

Notion Page
The current option gives access to all queries under App Resources but, only execute is under Datasources & Queries. This is confusing as I expect to give edit permissions to all my queries when I click edit on workspace in D&Q tab but, that does not affect queries.

Duplicate - Zenhub Crazyness


update userdev version, use plugin-yml to generate the plugin.yml

add missing libraries
update to userdev v1.3.4
use plugin-yml to generate the plugin.yml with the bukkit task

Can you edit the README too, so it works with the plugin-yml thingy


Update active-directory-conditional-access-supported-apps.md

@JairoCadenaMicrosoft,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

@JairoCadenaMicrosoft : Thanks for your contribution to the Azure documentation! The author, @MarkusVi, has been notified to review your proposed change.

#sign-off


Recreate config object before calling each handler to always get the latest configs

Fixes #1557
Fixes #1576
The viper.WatchConfig is not able to update the config properties on the daemon side, when the  same config property is set via cli and also from daemon.
To solve this for config 'set' we watch writes to the config file and use set method from config to explicitly set the config properties read from the config file
Testing
Below what am trying to do is, set/get config by mixing cli and the daemon api, whatever was set last should be returned from both cli and daemon.
## Checking the current config
╭─anjan@Anjans-MacBook-Pro ~/github.com/code-ready/crc ‹config_watch›
╰─$ nc -U ~/.crc/crc.sock
{"command":"getconfig", "args":{"properties":["cpus"]}}
{"Error":"","Configs":{"cpus":5}}%

## Set cpus using cli                                                                                ╭─anjan@Anjans-MacBook-Pro ~/github.com/code-ready/crc ‹config_watch›
╰─$ crc config set cpus 8
Changes to configuration property 'cpus' are only applied when a new CRC instance is created.
If you already have a CRC instance, then for this configuration change to take effect, delete the CRC instance with 'crc delete' and start a new one with 'crc start'.

## Set cpus using daemon api
╭─anjan@Anjans-MacBook-Pro ~/github.com/code-ready/crc ‹config_watch›
╰─$ nc -U ~/.crc/crc.sock
{"command":"setconfig", "args":{"properties":{"cpus":9}}}
{"Error":"","Properties":["cpus"]}%

## Get cpus using cli
╭─anjan@Anjans-MacBook-Pro ~/github.com/code-ready/crc ‹config_watch›
╰─$ crc config view
- cpus                                  : 9

## Again set using cli
╭─anjan@Anjans-MacBook-Pro ~/github.com/code-ready/crc ‹config_watch›
╰─$ crc config set cpus 10                                                                                130 ↵
Changes to configuration property 'cpus' are only applied when a new CRC instance is created.
If you already have a CRC instance, then for this configuration change to take effect, delete the CRC instance with 'crc delete' and start a new one with 'crc start'.

## Get using daemon api
╭─anjan@Anjans-MacBook-Pro ~/github.com/code-ready/crc ‹config_watch›
╰─$ nc -U ~/.crc/crc.sock
{"command":"getconfig", "args":{"properties":["cpus"]}}
{"Error":"","Configs":{"cpus":10}}%

This is imo missing a "why this is not working"? This commit is mostly duplicating the code from viper so it would be nice to understand why their code is not working, and ours is?

Yes it is mostly duplicating the watch part, but in viper when it detects changes on the file, it calls ReadInConfig, in this commit the config is set using viper.Set. I suspect viper.ReadInConfig behaves differently when called multiple time.

This is imo missing a "why this is not working"? This commit is mostly duplicating the code from viper so it would be nice to understand why their code is not working, and ours is?

Yes it is mostly duplicating the watch part, but in viper when it detects changes on the file, it calls ReadInConfig, in this commit the config is set using viper.Set. I suspect viper.ReadInConfig behaves differently when called multiple time.
But, i don't have an answer for the why, as this only fixes the Set part, if something is Unset we have the same not in sync issue again.

I did not look at Unset which might be its own can of worms, but I investigated why Set is not working. First, the exact bug is that after doing {"command":"setconfig", "args":{"properties":{"cpus":8}}} in the daemon, then crc config set cpus 6 will no longer be reflected in the daemon process.
What is happening:

v.Set("cpus", 8) will be roughly doing v.override["cpus"] = 8
the config watch will call ReadInConfig() which reloads the config file, and sets the value of the v.config map to the config file content
however, v.Get("cpus") will first look for "cpus" in v.override, and only if it's not present there, it will search for it in v.config. So once v.Set() has been called in the process for a config key, WatchConfig will never again refresh its value.

Looks that we don't have the choice. Can you try to run go test with -race option ? Currently it crashes due to WatchConfig.

Looks that we don't have the choice. Can you try to run go test with -race option ? Currently it crashes due to WatchConfig.
spf13/viper#174

Ah that's right, avoiding usage of viper.WatchConfig and OnConfigChange (and reimplement the file watching) would allow us to avoid that race.

Thinking about it twice, I am wondering if for the daemon we could create a new instance of config.Storage each time a handler is called. It would probably solve this issue.

Thinking about it twice, I am wondering if for the daemon we could create a new instance of config.Storage each time a handler is called. It would probably solve this issue.

Sounds closer to the behaviour we want/expect. crc code is not going to be able to deal well witha config parameter being change during the execution of a command/handler.

Thinking about it twice, I am wondering if for the daemon we could create a new instance of config.Storage each time a handler is called. It would probably solve this issue.

Yes, that way the behavior should be same as running from the cli, trying this way!

Thinking about it twice, I am wondering if for the daemon we could create a new instance of config.Storage each time a handler is called. It would probably solve this issue.

This indeed works as we expect it to, will update the PR, thanks a lot!

Would not hurt to have a few more details in the commit logs, for example why Run preflight checks on start via api? (because it's been forgotten, and we want the same behaviour as in cmd/crc/cmd/start.go)

Sorry, will update the commit message :)

@cfergeau @guillaumerose Rebased and updated the PR, please have a look again!

A good move!
/lgtm


Google Pay Platform Pay existingPaymentMethodRequired is inconsistent

Describe the bug
We are trying to integrate platform pay using the official Stripe react native SDK on Android. We have the requirement of only showing the platform pay modal if the user has an existing payment method within Google Pay.
Unfortunately we are seeing inconsistent behaviour with this setting. We have found that when a device has Google Pay completely disabled then the isPlatformPaySupported call with the existingPaymentMethodRequired parameter correctly returns false. However we are seeing inconsistent behaviour on devices with Google Pay set up. Sometimes users with no cards in their Google Pay account are getting a true value returned from this check. We originally thought this was maybe just a test environment issue but after switching to the production environment we are seeing the same issue.
To Reproduce

Remove all cards from Google Pay Wallet
isPlatformPaySupported call with an existingPaymentMethodRequired field set to true will still return true even though the device has no cards.

const { isPlatformPaySupported } = usePlatformPay();
...
await isPlatformPaySupported({
        googlePay: {
          testEnv: Config.STRIPE_ENV === 'TEST',
          existingPaymentMethodRequired: true,
        }
})

Expected behavior

Remove all cards from a Google Pay Wallet on a device.
isPlatformPaySupported should return false in this case

We are unable to narrow down exactly when this happens, as it does sometimes seem to work.
Smartphone (please complete the following information):

Device: One Plus Nord 5G
OS: Android 13
Version 0.30.0

Which version of Stripe are you running?

Which version of Stripe are you running?

"@stripe/stripe-react-native": "^0.30.0"
We have since spoken to stripe support and they have concluded it is an issue with the values Google are returning.

@jwoodmansey did you also delete all cards from pay.google.com?


ODBC

[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: de039d46-b6f1-576e-9e8c-d99506ffb16b
Version Independent ID: 5a6ba40d-657d-d44f-ab94-f6badcc49b5e
Content: ODBC Overview - ODBC API Reference
Content Source: docs/odbc/reference/odbc-overview.md
Service: sql
Sub-service: connectivity
GitHub Login: @David-Engel
Microsoft Alias: v-davidengel

@jahernandezp28 What exactly is the issue you'd like to report?


[OLINGO-901] Set osgi range for gson to include 2.2

OLINGO-827 changed the gson version to 2.4 which causes the maven bundle
plugin to set the lower range for gson to 2.4.

Was committed with bef01c2


Can't repair Amedian Tools

The code suggests that Nether Amethyst Crystals should repair them, but it doesn't seem to work.
If I had to guess, I'd say that the Tool Material is being initialized with a null item before AMETHYST_CRYSTAL is initialized.
Version: 1.12.2-2.1.7

I'll take a look soon and update the issue when the fix is available.

This issue has been fixed in the latest version.


CloudStack e2e test fix

Description of changes:
Add missing required cluster ip pool to required variable list.
/approve
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/approve


[GEODE-8661] Use version provided by *-builder-image-family.

Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

[x] Has your PR been rebased against the latest commit within the target branch (typically develop)?

[x] Is your initial contribution a single, squashed commit?

[ ] Does gradlew build run cleanly?

[ ] Have you written or updated unit tests to verify your changes?

[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to<EMAIL_ADDRESS>

I checked the test pipeline you made at https://concourse.apachegeode-ci.info/teams/main/pipelines/smgoller-geode-8661-main. Great!


Candle wick thickness

Hello @C451 ,
Thanks for this awsome work !!
A question, it's possible to increase the wicks of a candle ? I didn't see anything about this.
Take a look on my screen wicks are very thin

Did you change the default color? Props:
colorWickUp
colorWickDw

I can see them, but the color is too bright.

No I didn't change anything about the default wick color.
When I change it with a black color or blue color with this variable, it didn't change anything too.

So i re-install all my base project (electron/vue/vuetify) and now the Wicks are corrects

I don't know why this thin wicks appear, maybe lot of install/reinstall dependencies ...
If you want to investigate i can give you my dirty start project ;)
Thanks for your response, and your time

Thanks, but I think it will be hard to reproduce.


Question: Skip nasty 2FA SMS reminder

Hi,
would it be possible to skip the nasty 2FA SMS reminder after login?
This would be really helpful.
This would maybe need some effort because of the different languages, if you try to skip this with some OCR or something like that, but maybe there is a more efficient way to skip this.
Any ideas are appreciated.
I don't know, if this is needed to implement in GW2LB or if there are any other possibilities.

Agreed that Launch Buddy needs to skip it automatically.
That being said, GW2 allows you to use the same phone number for SMS of every alt account. So it's not difficult to add your phone number to every single alt. I did it in about 1 minute per account.

Is it normal that even with this wait time there is still an increasing delay after login gets pressed. Where the circle next to the login button keeps spinning?


List for choosing google account is not visible

I had tried cloning your repo and filling in all the necessary details as required.

I then tried signing in, but the problem is that I am not asked to choose my google account
My default chrome account is being chosen to login.
(Basically, there should have been a list of google accounts to choose from, which is missing)

What could be the problem? Can you please look into this issue?
Do check this video, I have recorded the problem that I am facing: https://www.loom.com/share/14e5236831f14223a4384504291aca20

while running npm run build it replaces all the changed values back to default. Also what is to be filled in this line :
"key": "-----BEGIN PUBLIC KEY-----\n\n-----END PUBLIC KEY-----"

while running npm run build it replaces all the changed values back to default. Also what is to be filled in this line : "key": "-----BEGIN PUBLIC KEY-----\n\n-----END PUBLIC KEY-----"

were you able to solve this? i thought that you put the public key from uploading to the web store, but it doesn't allow me to upload to the web store.

just delete that line, completely it should fix it, when you do the upload it will give you these details


HUD doesn't dismiss if called immediately after the show (bug)

Hey !
First, thanks for your lib ;)
Problem happens:

With the 2.0 beta8.
Can reproduce every time

Problem: if you try to dismiss the HUD just after displaying it, then it won't work.
Example:
[SVProgressHUD dismiss];```

Reason: the library check if the HUD is displayed when we try to hide it. But in this case, the HUD isn't displayed yet (because the action is in a queue). So we eventually are stuck :-(

Maybe we could move the logic "if([self isVisible]) { }" inside the block execution and not before ?

Cheers,

Vincent

Good catch, at first it was not obvious why you want to immediately dismiss, but a use case might be that you want to cancel the show. Sure moving might be an idea, I am quite busy at the moment with other projects, so PR is very welcome.

Yep that's the case. The dismiss is inside a completion block, which can be called directly after!
I'll try to find some time in the coming week!

Hi, since when did you use this library? This bug with the check (self isVisible] ) exists since https://github.com/SVProgressHUD/SVProgressHUD/commit/28b88ca59839161bda2df5eba7188ac3477ce71a (back in 2013). So I think the behaviour you see is intended. However I agree it should work the way you want it.

Hi, I'm new with the library. It's being used in a project I'm giving some help before its release in the App Store!

it also happens in this code:
[[NSOperationQueue mainQueue] addOperationWithBlock:^ {
    [SVProgressHUD setDefaultMaskType:SVProgressHUDMaskTypeBlack];
    [SVProgressHUD showWithStatus:NSLocalizedString(@"filtrando", nil)];
}];

...... execute some sqlite code...
[[NSOperationQueue mainQueue] addOperationWithBlock:^ {
    [SVProgressHUD dismiss];
}];

if the code in the middle is too fast .. it never dismisses.

I have a small block of code that uses an NSFileCoordinator to copy a small file from one location to another. I'm able to reproduce this issue on 2.0-beta2. It appears (at least for me) to be a regression between -beta and -beta2.

Quick update: I currently have no mac anymore (defect). I will continue work (and also invest some time to this issue) when I have the time and money to repair the machine.

I meet this issue too. I find that method "isVisible" is inappropriate.If you do not modify "isVisible" method, using dispatch_after 0 second shows good performance.

Hi! I just submitted a PR. I think it'll solve most of the issues + the easiest way to solve the bug while not adding too much code.
@honkmaster sad for the defect :-( I hope you'll trust me for the PR and add it to the next beta-release :-)
Cheers

:+1: This works for me, when calling showProgress before it would end up not dismissing the HUD at the end because going from 0.9999 -> 1.0 and completing the progress happens too quickly.
@honkmaster is your Mac back yet? If not would you contemplate pushing this PR? Tested and works ok for me.

Hi! I have same issue on latest version (2.0). I think @Vinzius solution is more stable.

Issue is still happening on master

Yep, I don't think the commit abd1b38 will help. Why not taking my PR?

@Vinzius solution is valid. However, the addOperationWithBlock: must be used used in the local dismissWithDuration function. Will push soon.

Check the latest master. If you agree, I will tag version 2.0.1

Just letting you know that the master fixed an issue I had that's the same or related to this issue.  Showing the hud of viewdidload and if the process finished and it's dismissed before the view is displayed it was never dismissing the HUD.  Works fine with the master branch.  Thanks!

Yep, update looks good.


Option to focus on tags field, instead of name

As the title says, it would be very handy to have an option that will allow us to have the tags field focused, instead the name of a bookmark, when bookmarking a site (ctrl+d).
As far as I can remember, Firefox used to remember the focused field, but your extension always focuses name.
Observing on Firefox 61.0.1 on Ubuntu 18.04.

You are correct, Firefox remembers the last used field (Name or Tag) when adding or editing a bookmark through the built-in bookmarking system. I'm using Firefox 62, and I have not seen any issue with this behavior with the add-on installed.
As far as I am aware, no WebExtension API is provided to select the focused field when bookmarking a page. So unfortunately, my only recommendation would be to update to Firefox 62 and see if you are still encountering the issue.

You can change the default focused field through the about:config page. The setting is named browser.bookmarks.editDialog.firstEditField, though I'm not sure what the value you want is—I tried "tags" and "tagPicker". Please let us know if you find it. 🙂
The default value for that field (as of FF 62.0.3) is namePicker, so Teddy is correct, it is FF picking that default. (I checked this before I installed the addon.)

Thanks! The correct value for Tags is tagsField.

Thank you for your help in closing this issue @jordansaints! 😃 👍


Issue 82 - Post Processing script or executable

Closes #82 by adding a flag to provide executable or script

ping @mpejcoch please review requested changes


Table, Timegraph, XY Chart: Display "no results' message

when analysis results are empty.
For all components, display message in the main chart area to keep
visual consistency.
Other details:

Make CSS class name general since it is being used for several messages
now.
Change CSS properties to consider text displayed on multiple
lines. The manual margin-top ajustment is a hack that only works for
single line messages.

Generalization of PR theia-ide#447
Fixes theia-ide#406
Signed-off-by: Erica Bugden<EMAIL_ADDRESS>

Let me know if I should squash these commits:

Move "no results" message to parent class
Table, Timegraph, XY Chart: Display "no results"

I realized that I didn't add this message (or the analysis failed message) to the new data tree output component. Should I make a separate PR for that with both messages?

I realized that I didn't add this message (or the analysis failed message) to the new data tree output component. Should I make a separate PR for that with both messages?

yes, please.

@ebugden I did a rebase on github, but now it doesn't compile anymore :-( I'm still not used to github way of working.
Could you please discard my merge commit and rebase it manually in your environment, and when adding the data tree change?

Yes I'll do that! (I don't think it's possible to rebase using the default github UI. I think you have to add a custom command? I always do it manually with the terminal.)

Update:

Rebase on master

Should be good to merge! I'll add the message for the data tree component in a separate PR. (Anyways I'm thinking of moving all the error message handling stuff to the abstract output component so we don't need to remember to copy in the checks when new output components are added.)

@ebugden I did a rebase on github, but now it doesn't compile anymore :-( I'm still not used to github way of working.
Could you please discard my merge commit and rebase it manually in your environment, and when adding the data tree change?

Yes I'll do that! (I don't think it's possible to rebase using the default github UI. I think you have to add a custom command? I always do it manually with the terminal.)

My own patches I do with the terminal too. For, other people's PRs I usually ask them to rebase. But today I thought I could rebase for you and merge it since it was fully approved. Anyways it's done.

I realized that I didn't add this message (or the analysis failed message) to the new data tree output component. Should I make a separate PR for that with both messages?

yes, please.

I merged this one now. Just create a new PR for the data tree.


"S-Group properties" window is shown when select and double click FG

Steps to Reproduce

Open Ketcher
Click on FG icon
Select any FG
Place PG on the canvas
Select FG with lasso
Double click on the FG

Expected behavior
Nothing happened.
Actual behavior
"S-Group properties" window is shown
Screenshots

Desktop :

OS: Windows 10
Browser Chrome Version 93.0.4577.63, Firefox Version 92.0, Microsoft Edge Version 93.0.961.47

Fixed, tested v.2.4


Fix #10789: Display "First Published At" DateTime as Absolute Value in Tooltip for Pages and Snippets

Fixes #10789 I have made some changes that enhances the user experience in the Wagtail CMS side panels by introducing a tooltip feature. Now, when users hover over the 'First published at [time ago]' text, they can easily access the absolute datetime. This improvement simplifies the process of retrieving datetime information, making the CMS more user-friendly and efficient.

[x] Do the tests still pass?[^1]
[x] Does the code comply with the style guide?
[x] Run make lint from the Wagtail root.
[ ] For front-end changes: Did you test on all of Wagtail’s supported environments?[^2]

Before changes:

After changes:

Thanks. I've started the CI and have labelled as needs review

As long as a few of the CI steps pass I will merge this.
Thanks for putting this together - and congrats on your first contribution to Wagtail. @rohitsrma

Thank you @lb- for your continuous valuable feedback and suggestions.

Thanks @rohitsrma  - great stuff here.
I realised I should have probably reviewed the naming choice in more detail, we are using 'position' but the tooltip code uses 'placement'. I have a PR up to fix this + add some unit tests https://github.com/wagtail/wagtail/pull/10891
Again, really appreciate the time you took to do this PR, sorry I missed these nuances on my initial review.

@lb- I apologize for any inconvenience my oversight have caused. In the future, I will be more diligent in thoroughly reviewing related code files before implementing changes. I genuinely appreciate the effort you've invested in creating the new PR.

It's not a problem at all @rohitsrma - there's lots of things to consider. We really appreciate the time you've taken to address this. It's a great improvement for the new release and solves a practical problem for users.
Naming things is always a bit tricky and it's hard to know when it matters or not.


Ionic v2: platform.on is marked private, and doesn't accept any arguments

Hi there,
I'm trying to listen to cordova lifecycle events (resume specifically) as described here: https://forum.ionicframework.com/t/running-in-background-to-running-in-foreground/17741, but unfortunately, the documentation for this method claims it's private, and currently doesn't accept any arguments.
Are there any plans on supporting that? If not, what is the recommended way to listen to cordova lifecycle events?
Thanks,
Boaz
Which Ionic Version? v2
Cordova CLI: 6.0.0
Ionic Version: 2.0.0-beta.3
Ionic CLI Version: 2.0.0-beta.19
Ionic App Lib Version: 2.0.0-beta.9
ios-deploy version: 1.8.5
ios-sim version: Not installed
OS: Mac OS X El Capitan
Node Version: v5.7.1
Xcode version: Xcode 7.2.1 Build version 7C1002

There has been an API change and the on method no longer exists. We also recently added events for backbutton and exitApp if that helps: https://github.com/driftyco/ionic/commit/156fdc35ed551977f5c015e408fd72e866fea703#diff-9b766d33086364a7b9078264fee84f82L295


C.ADDI16SP range clarification.

https://github.com/riscv/riscv-isa-manual/blob/af961756090d34139dd1ca81f16d5497bb485f7d/src/c-st-ext.adoc?plain=1#L612
Now: represent multiples of 16 in the range (-512,496).
Suggestion: represent multiples of 16 in the range -512 to 496.
I read (-512,496) as a single negative number. While -512 to 496 is more clear and more in the style of: https://github.com/riscv/riscv-isa-manual/blob/af961756090d34139dd1ca81f16d5497bb485f7d/src/v-st-ext.adoc?plain=1#L2728

(x, y) is a standard representation for ranges, and we don't want to ban that.  The right fix is to add a space after the comma.  I'll handle that.
(Also, it should be [x, y], not (x, y), since the range is inclusive.)


Create a bridged Matrix room

Is your enhancement request related to a problem? Please describe.
Discord has numerous privacy concerns and many people like me just dislike it in general. Discord is a proprietary software while Matrix is made up of free software.
Describe the solution you'd like.
Create a Matrix room bridged to Discord to allow people to talk about OSSU without using Discord. Matrix is a decentralized platform for communication used by many open source projects.
Describe alternatives you've considered.
Creating an IRC channel is also an option.
End Result:

An interesting issue!
You bring up 3 points:

Discord has numerous privacy concerns
More details would be appropriate here.
many people like me just dislike it in general
This is not a description of a problem.
Discord is a proprietary software while Matrix is made up of free software.
This is a valid point.

This issue has been open for a month and has received 2 upvotes. A concern that I have about adopting this bridged system is that it will entail OSSU running a server on our own hardware in order to support 1-3 participants (out of nearly 10,000 Discord users).
I will also point out that OSSU does make use of closed source platforms, Github for example!
I've highlighted this issue with the Discord moderators, as ultimately the responsibility for moderating the Discord communication lies with them.


Add udp_lat: test of latency using UDP sockets

I wanted to compare UDP vs TCP socket latency on localhost, so made a UDP test, based on tcp_lat.  Of course, with UDP it's possible not all the packets will arrive, but I just wanted to test basic performance, so there is no checking of that.  (In practice, on localhost and with smallish packet sizes, it's very rare that packets will drop, at least not in my experience on OS X).
Hope you find it a useful addition.
Glen.

Thanks!


ERR_NAME_NOT_RESOLVED

I've been trying to get Azure Appinsights working with no luck. Followed the readme step by step in a contained React app with three components whose lifecycle I want to track.
Nothing arrives in the backend.
My Chrome dev tools console reports:
GET https://az416426.vo.msecnd.net/scripts/a/ai.0.js net::ERR_NAME_NOT_RESOLVED
Edit: I just realized that appinsights might just be blocked in this network. Google ads that appear in search for example are shown but cannot be clicked. Could this be the explanation?

Yes, it sounds like something in the DNS resolution chain is blocking that specific domain. You may want to try using dig or other tools to troubleshoot this.


Dts 40072 lazy loading iteration

@spal-sapient why so many changes required? And in switch case, why are we handling single KPIs?

changes are make sure will are calling api on inner tab switch, I have replace the existing if else with switch case, single KPIs logic was existing before, I didn't change the existing logic.


How to convert .csv to .fsn?

How can I convert my taxa file (in .csv format) to a .fsn file for use in Qiime2?
I'm trying to create a tree using a script like this: http://qiime.org/scripts/filter_tree.html, not sure if this script will work in Qiime2.
Victoria

Hi @restivve, please find us on the QIIME 2 Forum: https://forum.qiime2.org, that is where we provide official user support. Thanks!

I cannot log in there with my GitHub account, it says it won't allow a log in from my IP.

Please try again.


Test postdeploy script

Test if Heroku can run the postdeploy script without any issue.
I hope Heroku really rocks.

@sayanarijit: can this be closed?

This is to reproduce the postdeploy script issue for Heroku. They said they have included the issue in their open worker item. I'd wait for now.

Closing this.


Page loads after the iteration instead of streaming the chunks

Describe the bug
When I am iterating through the chunks to call res.write_body(chunk) it does not immediately load the page and show the audio whose bytes are incoming; instead, the page loads when the loop is ended and all the downloaded chunks of the audio load.
To Reproduce
See the code
Expected behavior
The page should load as the first chunk arrives and gets attached to the response stream
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: Windows
Browser Chrome
Version 108

Additional context
#[handler]
async fn stream(_req: &mut Request, res: &mut Response) {
  // ...
  res.add_header("Content-Type", "audio/mpeg", true).unwrap();
  res.add_header("Accept-Ranges", "bytes", true).unwrap();
  res.set_status_code(StatusCode::OK);
  while let Some(chunk) = download.next().await.unwrap() {
      println!("Chunk length: {}", chunk.len());
      res.write_body(chunk).unwrap();
      }
}

write_body will not send data to browser immediately. If  download's type is stream, you can use res.streaming(download).


Keywords feature not working

What is the current behavior?
I don't think the SDK is correct for how to make the keywords feature work. When I send an array of strings like the SDK docs say to do, those keywords don't improve. When I make the same request in CURL, they do improve. I think this is incorrect
Steps to reproduce
Use the attached audio file CallCenterPhoneCall.mp3. Use this request:
deepgram.transcription
  .preRecorded(
    {
      buffer: fileBuffer,
      mimetype: "mp3",
    },
    {
      punctuate: true,
      utterances: true,
      keywords: ["Charlie"],
    }
  )

Compare to CURL:
curl \
  --request POST \
  --url 'https://api.deepgram.com/v1/listen?diarize=true&punctuate=true&utterances=true&keywords=charlie' \
 --header "Authorization: Token ${DGAPI}" \
  --header 'content-type: audio/mp3' \
 --data-binary @CallCenterPhoneCall.mp3 | jq -r '.results.utterances[] | "[Speaker:\(.speaker)] \(.transcript)"'

Expected behavior

What would you expect to happen when following the steps above?

When the speaker says his name, it should change to "Charlie" from "Shirley"
[Speaker:0] Okay. What is your name, sir?
[Speaker:1] Charlie Johnson.

As far as I'm aware we should be unfurling the array of strings into multiple URL params.
    {
      keywords: ["Charlie", "Johnson"],
    }

Should result in.
&keywords=Charlie&keywords=Johnson

I'll look at this this week

Not working for me either. Additionally, how can I define the intensifier parameter there?

Not working for me either. Additionally, how can I define the intensifier parameter there?

Hi @lukeocodes any luck on your findings?
I have tried to add intensifier for each keywords, but not working.
For example
const options = {..., keywords: ["hello:-10", "yeah:-10"] }


[BUG] JaggedArray.ContainsKey

it should be?
if (index < 0 || index >= Capacity)
{
    return false;
}

Well looks like that's a bug actually ^^


Add CI status to README.md

Signed-off-by: Ian Campbell<EMAIL_ADDRESS>

LGTM (but not a maintainer here)

LGTM


Simple select query returns wrong result in React Native

Which version are you using?
    "@nano-sql/adapter-react-native": "2.0.6",
    "@nano-sql/core": "2.3.6",
    "@react-native-community/async-storage": "1.6.1",
    "react-native": "0.60.5"

Describe the bug
The simple qery in the example works fine when using the TEMP mode but returns wrong results when using the React Native adapter.
Result using TEMP mode:
ReactNativeJS ▶ [ { key: '2' } ]

Result using the React Native adapter:
ReactNativeJS ▶ []

Example
nSQL()
  .createDatabase({
    id: "db1",
    mode: "TEMP", // new NativeStorage(),
    tables: [
      {
        name: "kv",
        model: {
          "key:string": { pk: true },
          "val:string": {}
        }
      }
    ]
  })
  .then(() =>
    nSQL("kv")
      .query("upsert", [
        { key: "1", val: "A" },
        { key: "2", val: "B" },
        { key: "3", val: "C" }
      ])
      .exec()
  )
  .then(() =>
    nSQL("kv")
      .query("select", ["key"])
      .where(["val", "=", "B"])
      .exec()
  )
  .then(result => console.log(result))

Expected behavior
The query should return the correct result when running with the React Native adapter.
(This is the simplest query I tried that was failing, I can provide more examples of other somewhat more complex queries that were also returning wrong results.)

This seems to be a problem with caching and/or live reload. Queries run as expected after clearing cache + storage and re-installing the app (react-native run-android). Thanks for the amazing work!