Add error message to deploy metrics label

The deploy error message (e.g. "error creating stage directory", or "no cloud sdk was found ...") is currently not being tracked via our metrics. The error message was being shown to the user, but we had no way of digging into the deployment failure to determine more details.
This PR appends the error message to the metrics label.
@chanseokoh do you mind taking a quick look to see if this makes sense to you on the metrics side? i.e is this an ok place to put the message?

LGTM, as far as I can tell. However I'd also want to hear from @chanseokoh before merging.

To be correct, the error string should be escaped. Escaping isn't difficult; GoogleUsageTracker already has METADATA_ESCAPER. But I think we really want to extend the metrics reporting interface for this additional info, like what I said here.

Yes good idea. I didn't realize we could send multiple key value pairs. I'll add this in.

Yeah, FYI, #1154 uses this format to send platform info.

updated, PTAL.
I ended up getting rid of the FluentTrackingEventWithValue interface and instead creating an overloaded withLabel method that also accepts a scalar value. My reasoning is that a value is strongly associated with a label since we are sending these bundled as a key/value pair. Also this makes the interface more fluent in that you can continue setting metadata.

The current API is based off of the Android Studio model which was using an 'application' GA property type where - I think - the event label dimension was explicitly for scalar values.
Since we've transition to concord that's no longer the case, and we now hack all our extra dimensions into this page title mess which clearly isn't going to do any special processing on the scalar values. So I tend to think that Chanseok's suggestion makes more sense of changing it to just accept string type is the better alternative.

Also if we want to improve the API to allow setting multiple key values I'd change the labelling to something more like .addMetadata(key, value), and get rid of with label all together.

something more like .addMetadata(key, value)

I like it.

Sounds good. I'll update this.
On Fri, Jan 6, 2017 at 10:07 AM Chanseok Oh<EMAIL_ADDRESS>wrote:

something more like .addMetadata(key, value)
I like it.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/GoogleCloudPlatform/google-cloud-intellij/pull/1182#issuecomment-270922215,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABp8QL-_6yVVPixJ39kDOVCy6y2w8i6Jks5rPliggaJpZM4LcI6A
.

After going down this path I see a complication with this suggested approach:
A key/value API doesn't really make much sense for clients wishing to set a label or a message. Most of the time they'd end up doing something like this:
.withMetadata(null, label)
.withMetadata(null, message)

I'm almost more inclined to leave it similar to how I have it now:
.withLabel(label)
.withMessage(message)

and internally set the key to either "label" or "message". Also getting rid of that scalar value altogether (since its not used anywhere) or moving it to a separate method (e.g. setValue(value)).
Thoughts?

I think I'll settle for something like this:
.withMetadata(GctTracking.METADATA_LABEL_KEY, eventLabel)
.withMetadata(GctTracking.METADATA_MESSAGE_KEY, errorMessage)

I think the point here is that event label doesn't have any fixed meaning
any more in our reporting. So whether a caller decides to track a specific
key value or another, we're not going to try and assign any particular
category to it, since it all gets jammed into page title anyway.
so the actual calls should look like:
.addMetadata(someArbitraryLabel, labelValue)
.addMetadata(someOtherArbitraryLabe, otherLabelValue)
On Fri, Jan 6, 2017 at 12:21 PM, Etan Shaul<EMAIL_ADDRESS>wrote:

I think I'll settle for something like this:
.withMetadata(GctTracking.METADATA_LABEL_KEY, eventLabel)
.withMetadata(GctTracking.METADATA_MESSAGE_KEY, errorMessage)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/GoogleCloudPlatform/google-cloud-intellij/pull/1182#issuecomment-270954673,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHf5HaHrsRJ1QnnGyp6Y1KwZPgZn9VVHks5rPngfgaJpZM4LcI6A
.

@patflynn @chanseokoh updated. PTAL.

good point. updated to addMetadata

I wonder if the errorMessage may contain sensitive info.

Generally the new API looks good. I'll look into it a bit more.
About the actual format you'd want to use when providing metadata, it looks good too, but I just wanted to mention an alternative. For example, I see you would enforce using the two general keys "label" and "message" for all kinds of your event pings such as
"label=flex-compat,message=..."
"label="
but you could also let the callers decide keys and values, e.g.,
"deployType=flex-compat,errorMessage=..."
"runnerId="
I'll leave the design up to you.

Yes, the caller can put in whatever they want for the key. I just created
those constants for convenience.
On Fri, Jan 6, 2017 at 2:05 PM, Chanseok Oh<EMAIL_ADDRESS>wrote:

Generally the new API looks good. I'll look into it a bit more.
About the actual format you'd want to use when providing metadata, it
looks good too, but I just wanted to mention an alternative. For example, I
see you would enforce using the two general keys "label" and "message" for
all kinds of your event pings such as
"label=flex-compat,message=..."
"label="
but you could also let the callers decide keys and values, e.g.,
"deployType=flex-compat,errorMessage=..."
"runnerId="
I'll leave the design up to you.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/GoogleCloudPlatform/google-cloud-intellij/pull/1182#issuecomment-270978844,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABp8QBOCVhQIMrp4TK5pKeUzUiB6tUqiks5rPpBcgaJpZM4LcI6A
.

@etanshaul Great, I understood you intended it too.

we control the error message. they are pre constructed strings from our
message bundle.
On Fri, Jan 6, 2017 at 1:53 PM, Chanseok Oh<EMAIL_ADDRESS>wrote:

I wonder if the errorMessage may contain sensitive info.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/GoogleCloudPlatform/google-cloud-intellij/pull/1182#issuecomment-270976076,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABp8QHORu0-0CgSr20KvSHuE65m-tTc8ks5rPo2ZgaJpZM4LcI6A
.

@etanshaul Ideally the error message would not be a localized string.  I also agree that now that we don't need to use fixed key types it's probably more useful to use the key name to be more precise about the category of the value.
Both things I'm fine fixing later.

I don't see the approve button for some odd reason.

@patflynn I think you can approve if you go into the code tab and click 'review changes': https://github.com/GoogleCloudPlatform/google-cloud-intellij/pull/1182/files


New patch added to chromium official repository

I just want to tell you that there is a new patch added to chromium official build for Archlinux
https://git.archlinux.org/svntogit/packages.git/commit/trunk?h=packages/chromium&id=b09cf910e816b3bdf0788197e9f50e5f29f58fc8

seems that patch isnt anything mission critical, will add it later

just added the patch, it is building rn.

Because I build your repositry I just want to make sure that everything is okay before buildings it


Lint our files

Throwing this into R1 as earlier the better.

Thats scope creep :D

closed by #33


Regarding the size statement in bullet#2

"Nano Server is even smaller than the Windows Server 2016 version." - This statement is in the second bullet in this page. This does not convey what was actually meant. Reading it literally it means "Nano server" image is smaller in size than the "Windows Server 2016" image. Ofcourse one would expect it to be, and this is stating the obvious. On the contrary I think the intent of the bullet is to say Nano Server on Windows Server 1803 and later is smaller in size, than the Nano server one could run on "Windows Server 2016". It will be great if you can clarify this.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e9308a6f-52cd-8594-c1bd-48376bcc8a35
Version Independent ID: 879f7f6b-d102-e547-7d57-0fddb2327192
Content: Changes to Nano Server in Windows Server Semi-Annual Channel
Content Source: WindowsServerDocs/get-started/nano-in-semi-annual-channel.md
Product: windows server
GitHub Login: @JasonGerend
Microsoft Alias: jgerend

Thanks for your dedication to our documentation. If we have been unable to review your issue in a timely manner, we sincerely apologize for the delayed response. We have captured the informtion you have provided for review. We are closing this issue for now, but if you feel that it's still a concern, please respond and let us know. If you determine another possible update to our documentation, please don't hesitate to reach out again. #please-close


cubox openelec ARMv7 Processor rev 10 (v7l)

OpenELEC:~/test # sh build.sh
Cleaning up...
rm: can't remove 'build_dir': No such file or directory
rm: can't remove 'dist': No such file or directory
Downloading latest AceStream engine for Android...
Connecting to dl.acestream.org (<IP_ADDRESS>:80)
Connecting to dl.acestream.org (<IP_ADDRESS>:80)
Unpacking...
[acestream.apk]
End-of-central-directory signature not found.  Either this file is not
a zipfile, or it constitutes one disk of a multi-part archive.  In the
latter case the central directory and zipfile comment will be found on
the last disk(s) of this archive.
unzip:  cannot find zipfile directory in one of acestream.apk or
acestream.apk.zip, and cannot find acestream.apk.ZIP, period.
Extracting resources...
unzip:  cannot find or open acestream_bundle/res/raw/_private_py.zip, acestream_bundle/res/raw/_private_py.zip.zip or acestream_bundle/res/raw/_private_py.zip.ZIP.
unzip:  cannot find or open acestream_bundle/res/raw/_private_res.zip, acestream_bundle/res/raw/_private_res.zip.zip or acestream_bundle/res/raw/_private_res.zip.ZIP.
unzip:  cannot find or open acestream_bundle/res/raw/public_res.zip, acestream_bundle/res/raw/public_res.zip.zip or acestream_bundle/res/raw/public_res.zip.ZIP.
Patching Python...
unzip:  cannot find or open acestream_engine/python/lib/python27.zip, acestream_engine/python/lib/python27.zip.zip or acestream_engine/python/lib/python27.zip.ZIP.
cp: can't create 'python27/android.py': Path does not exist
cp: can't create directory 'python27/dns': No such file or directory
cp: can't create 'python27/socket.py': Path does not exist
cp: can't create 'python27/urllib2.py': Path does not exist
Patching AceStream engine...
cp: can't create 'acestream_engine/': Is a directory
chmod: acestream_engine/python/bin/python: No such file or directory
Bundling Python...
build.sh: cd: line 48: can't cd to python27
mv: can't rename 'python27.zip': No such file or directory
Making distributable...
cp: can't stat 'chroot/': No such file or directory
cp: can't stat 'platform//': No such file or directory
cp: can't stat 'scripts/start_acestream.sh': No such file or directory
cp: can't stat 'scripts/acestream-user.conf': No such file or directory
cp: can't stat 'scripts/acestream.sh': No such file or directory
mv: can't rename 'build_dir/acestream_engine/*': No such file or directory

@golimer, you need to specify your platform as argument to build.sh, e.g:
$ sh build.sh arm

I hope this issue is solved.

i will try tomorrow, btw did you try on raspberry or cubox ?

I have Orange Pi One, which has ARMv7 processor, running Armbian and it's working fine.


Change user limits

I think nowadays it's rare to not have to sudo. User limits should be rewritten to sudo friendly format
cat << EOF | sudo tee -a /etc/security/limits.conf
*               hard    memlock         unlimited
*               soft    memlock         unlimited
*               hard    nofile          65535
*               soft    nofile          65535
EOF

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: fbe00d45-6f18-5537-1ccc-2e86927ed114
Version Independent ID: bb5f5c1a-01ec-b61b-db1b-3cbf30a0da0a
Content: Set up Message Passing Interface for HPC - Azure Virtual Machines
Content Source: articles/virtual-machines/workloads/hpc/setup-mpi.md
Service: virtual-machines
GitHub Login: @vermagit
Microsoft Alias: amverma

Thanks for this feedback. The documentation has been updated with sudo.


fix: make sure we catch all throwables

Errors were not being caught in the executor, so they were silently ignored. This commit fixes that.
Fixes MWTELE-232

Wrong issue number, will close and try again


Some questions in the utils.py

I have two questions about the utils.py.
1.
In the script located in ./utils/utils.py, the following codes in def run_class_time_CV_fmri_crossval_ridge is to skip TRs between train and test data. Could you please tell me why we should do this skip?
#skip TRs between train and test data
if ind_num == 0: # just remove from front end
    train_data = train_data[skip:,:]
    train_features = train_features[skip:,:]
elif ind_num == n_folds-1: # just remove from back end
    train_data = train_data[:-skip,:]
    train_features = train_features[:-skip,:]
else:
    train_data = train_data[skip:-skip,:]
    train_features = train_features[skip:-skip,:]

In the script located in ./utils/utils.py, the following is some codes in the function def prepare_fmri_features:

#w=find what TR each word belongs to
for i in range(len(time_words)):
    words_id[i] = np.where(time_words[i]> time)[0][-1]

all_features = np.zeros([time_words.shape[0], train_features.shape[1]])
all_features[word_train_indicator] = train_features
all_features[~word_train_indicator] = test_features

p = all_features.shape[1]
tmp = np.zeros([time.shape[0], p])
for i in range(time.shape[0]):
    tmp[i] = np.mean(all_features[(words_id<=i)*(words_id>=i-1)],0)
tmp = delay_mat(tmp, np.arange(1,5))

Among this codes, the line tmp[i] = np.mean(all_features[(words_id<=i)*(words_id>=i-1)],0) may make some mistakes. This would average the 8 words in 2 TRs. However we should have averaged the 4 words in a single TR.

Regarding 1: in order to account for the lag in the hemodynamic response from fMRI recordings, each brain image (TR)'s corresponding NLP features are computed as a function of the words that appear in the previous 4 TRs.  So we remove 5 TRs between the train and test data to be extra careful that no TR's corresponding NLP features (resulting from the function prepare_fmri_features) appear in both the train and test features. The else statement in the code excerpt should say test_data = test_data[skip:-skip,:] and test_features = test_features[skip:-skip,:], which I've corrected in the code.
Regarding 2: thanks for pointing this out. You're right -- words_id>=i-1 should be words_id>i-1. I've made the corresponding change in the code.

Hello, are you sure the code fix is correct? Because with the new code I get the following error :
in run_class_time_CV_fmri_crossval_ridge
ValueError: shape mismatch: value array of shape (292,27905) could not be broadcast to indexing result of shape (302,27905)
at the command        preds_d[test_ind] = preds`
And the problem seems to be that test_features now has shape 292 but test_ind is set to 302 at the start of the loop        test_ind = ind==ind_num

Thanks for pointing this out. The code fix is correct but it was also necessary to change the way that the predictions are being aggregated over the cross-validation folds (as they are now of different dimensions). I've added this fix and the code runs through without errors and produces expected results.


Update MP2.py

The SCS-MP2 correlation energy was printing the SS-MP2 correlation energy.
A simple variable switch was performed in line 104:
print('\nSCS-MP2 correlation energy: %16.10f' % SCS_MP2corr_E)
instead of,
print('\nSCS-MP2 correlation energy: %16.10f' % MP2corr_SS)
Description
Please provide a brief description of the PR's purpose here.
What are your new additions? Please provide a brief list.

New Features

[ ] Feature1
[ ] Feature2

Changes

[x] Change1

Any questions for the community?

[ ] Question1

Status

[ ] Click when ready for review-and-merge

Codecov Report

Merging #87 into master will not change coverage.
The diff coverage is 100%.

LGTM, thanks for the PR!


HiveLoad ERROR : Duplicate entry

Status of Job recorded in wh_etl_job_execution is "SUCCEEDED", but all dataset table is emptry. There is Error throw :
2017-05-25 09:33:18 ERROR HiveLoad[16]:-2 - Duplicate entry '16419-9' for key 'uix_dict_field__datasetid_sortid' [SQLCode: 1062], [SQLState: 23000]

Could you check if the staging tables stg_dict_dataset and stg_dict_field_detail has data in it? If not, could you check if the HiveExtract has produced output file that contains data.

Dear issue owner,
Thanks for your interest in WhereHows. We have recently announced DataHub which is the rebranding of WhereHows. LinkedIn improved the architecture of WhereHows and rebranded WhereHows into DataHub and replaced its metadata infrastructure in this direction. DataHub is a more advanced and improved metadata management product compared to WhereHows.
Unfortunately, we have to stop supporting WhereHows to better focus on DataHub and offer more help to DataHub users. Therefore, we will drop all issues related to WhereHows and will not accept any contribution for it. Active development for DataHub has already started on datahub branch and will continue to live in there until it's finally merged to master and project is renamed to DataHub.
Please check the datahub branch to get familar with DataHub.
Best,
DataHub team


Add automated testing for other compilers

In particular, I'd like to test that this compiles with MSVC.
I'd like to verify it compiles on Linux (clang / gcc), macOS (clang / gcc), Windows (MSVC).
Ideally, the automated tests could be run on all platforms as well, but even simply checking that it compiles on all platforms properly would be a start, as until very recently YASL wouldn't even compile with MSVC.

(It compiles fine with GCC 8.2.1 as either C or C++ on Fedora.)

Yup, same on Ubuntu. The idea of this ticket is that I only run automated tests on Linux using clang / gcc. I need to add C++ tests and tests for windows.

I've added support for this starting from v0.5.0


Angular typescript question: $httpParamSerializer

the constructor of the generated api looks like:
constructor(private $http: ng.IHttpService, basePath?: string, private $httpParamSerializer?: (any) => any) {
But I get runtime errors because of the code expects the second parameter is $httpParamSerializer. So now I have to adapt manualy the generated file.

I believe you got the wrong project... Not sure which one you need, otherwise would refer you.

My issue is about the generated "Angular typescript" code from the Swagger yaml-file

This relates to swagger-codegen then, not this project.

Oke tnx, I've moved it to the  swagger-codegen project.
Angular typescript question: $httpParamSerializer #1536

Closing as issue moved.


nixos-artwork.wallpapers.*: Update

Description of changes
Closes #314837
CC @Guanran928
We prolly want to backport this to the 24.05 branch.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

@ofborg build nixos-artwork.wallpapers

Result of nixpkgs-review pr 314943 run on x86_64-linux 1

14 packages built:

budgie.budgie-gsettings-overrides
cinnamon.cinnamon-gsettings-overrides
cinnamon.mint-artwork
gnome.nixos-gsettings-overrides
kdePackages.waylib (qt6Packages.waylib)
kdePackages.waylib.bin (qt6Packages.waylib.bin)
kdePackages.waylib.dev (qt6Packages.waylib.dev)
pantheon.elementary-default-settings
pantheon.elementary-greeter
pantheon.elementary-gsettings-schemas
pantheon.elementary-session-settings
tests.testers.nixosTest-example
tests.testers.runNixOSTest-example
tests.trivial-builders.references

Wallpaper in pantheon VM tests still appears fine, so I think the non-inits should be fine…


Cursor crashes with java.lang.NullPointerException: null

java.lang.NullPointerException: null
at org.h2.mvstore.Page.getRawChildPageCount(Page.java:868) ~[h2-mvstore-1.4.196.jar:1.4.196]
at org.h2.mvstore.MVMap.getChildPageCount(MVMap.java:1179) ~[h2-mvstore-1.4.196.jar:1.4.196]
at org.h2.mvstore.Cursor.fetchNext(Cursor.java:149) ~[h2-mvstore-1.4.196.jar:1.4.196]
at org.h2.mvstore.Cursor.next(Cursor.java:50) ~[h2-mvstore-1.4.196.jar:1.4.196]
at org.dizitart.no2.internals.DocumentCursor$DocumentCursorIterator.next(DocumentCursor.java:106) ~[nitrite-2.1.1.jar:na]
at org.dizitart.no2.internals.DocumentCursor$DocumentCursorIterator.next(DocumentCursor.java:92) ~[nitrite-2.1.1.jar:na]
at org.dizitart.no2.objects.ObjectCursor$ObjectCursorIterator.next(ObjectCursor.java:108) ~[nitrite-2.1.1.jar:na]

Could you please provide the code to reproduce this error?

I could not reproduce this issue. Please provide your response to reproduce this otherwise I have to close this issue.

seems to happen when multiple threads try to access the cursor.

Based on your input I have constructed the below test cases, but again I am unable to reproduce this. Could you please try to modify the below test case to match your scenario and reproduce this error?

@Indices({
        @Index(value = "name", type = IndexType.Fulltext)
})
public class PersonEntity {
    @Id
    private String uuid;
    private String name;
    private String status;
    private PersonEntity friend;
    private Date dateCreated;

    public PersonEntity() {
        this.uuid = UUID.randomUUID().toString();
        this.dateCreated = new Date();
    }

    public PersonEntity(String name) {
        this.uuid = UUID.randomUUID().toString();
        this.name = name;
        this.dateCreated = new Date();
    }

	// getter and setter...
}

	@Test
    public void testIssue63() throws InterruptedException {
        PersonEntity p1 = new PersonEntity("abcd");
        p1.setStatus("Married");

        PersonEntity p2 = new PersonEntity("efgh");
        p2.setStatus("Married");

        PersonEntity p3 = new PersonEntity("ijkl");
        p3.setStatus("Un-Married");

        ObjectRepository<PersonEntity> repository = db.getRepository(PersonEntity.class);
        repository.insert(p1);
        repository.insert(p2);
        repository.insert(p3);

        final CountDownLatch latch = new CountDownLatch(100);
        ExecutorService executor = Executors.newFixedThreadPool(10);
        final Cursor<PersonEntity> cursor = repository.find();

		// now trying to access same cursor from 100 threads
        for (int i = 0; i < 100; i++) {
            executor.submit(new Runnable() {
                @Override
                public void run() {
                    try {
                        for (PersonEntity entity : cursor) {
                            assertTrue(entity.getStatus().equals("Married")
                                    || entity.getStatus().equals("Un-Married"));
                        }
                    } catch (Throwable t) {
                        t.printStackTrace();
                    } finally {
                        latch.countDown();
                    }
                }
            });
        }
        latch.await();
    }

I got a similar error on accessing the same cursor from 5 threads:
Exception in thread "Thread-4" 3f6cc9c3-067f-4b18-b734-70fb93cdf435
9f0a846f-5b8d-4c3f-9000-15a642508f55
java.lang.NullPointerException
	at org.h2.mvstore.Page.getRawChildPageCount(Page.java:868)
	at org.h2.mvstore.MVMap.getChildPageCount(MVMap.java:1179)
	at org.h2.mvstore.Cursor.fetchNext(Cursor.java:149)
	at org.h2.mvstore.Cursor.next(Cursor.java:50)
	at org.dizitart.no2.internals.DocumentCursor$DocumentCursorIterator.nextMatch(DocumentCursor.java:115)
	at org.dizitart.no2.internals.DocumentIterator.next(DocumentIterator.java:54)
	at org.dizitart.no2.internals.DocumentIterator.next(DocumentIterator.java:32)
	at org.dizitart.no2.objects.ObjectCursor$ObjectCursorIterator.next(ObjectCursor.java:120)
	at samples.nitriteperformance.TestThreadMultiCursor.run(TestThreadMultiCursor.java:23)

@swissfreedev I have modified your code a bit as follows:

    @Test
    public void testIssue63_2() throws InterruptedException, IOException {
        Nitrite db = Nitrite.builder().compressed().filePath("/tmp/nitrite.db").openOrCreate(); //ohne gummi
        ObjectRepository<PersonEntity> repRegion = db.getRepository(PersonEntity.class);
        PersonEntity p1 = new PersonEntity("abcd");
        p1.setStatus("Married");

        PersonEntity p2 = new PersonEntity("efgh");
        p2.setStatus("Married");

        PersonEntity p3 = new PersonEntity("ijkl");
        p3.setStatus("Un-Married");
        repRegion.insert(p1);
        repRegion.insert(p2);
        repRegion.insert(p3);

        final Cursor<PersonEntity> cursor = repRegion.find();

        CountDownLatch latch = new CountDownLatch(5);
        TestThreadMultiCursor t1 = new TestThreadMultiCursor(cursor, 1, latch);
        TestThreadMultiCursor t2 = new TestThreadMultiCursor(cursor, 2, latch);
        TestThreadMultiCursor t3 = new TestThreadMultiCursor(cursor, 3, latch);
        TestThreadMultiCursor t4 = new TestThreadMultiCursor(cursor, 4, latch);
        TestThreadMultiCursor t5 = new TestThreadMultiCursor(cursor, 5, latch);

        t1.start();
        t2.start();
        t3.start();
        t4.start();
        t5.start();
        latch.await();

        Files.delete(Paths.get("/tmp/nitrite.db"));
    }

    public class TestThreadMultiCursor extends Thread {

        Integer threadID;
        Cursor<PersonEntity> cursorRegion;
        CountDownLatch latch;

        public TestThreadMultiCursor(Cursor<PersonEntity> cursorRegion, Integer threadID, CountDownLatch latch) {
            this.threadID = threadID;
            this.cursorRegion = cursorRegion;
            this.latch = latch;
        }

        public void run() {
            System.out.println("Thread " + threadID);
            for (PersonEntity t : cursorRegion) {
                System.out.println(threadID + ". " + t.getName());
            }
            latch.countDown();
        }
    }

But still I could not reproduce it.

Can you please provide some additional details like - OS, system arch, java version etc?

Hi Anindya,
in my office: win10, netbeans8.2, jdk8, nitrite 2.1.0 I can upload the entire project if it helps?
funny, don't tell me it's again a win10 issue ;-)
Gotta try it at home on suse linux leap 43.2 this evening.
Best regards
Pascal

In my experience lots of funny things happen in Windows. This is the reason why I moved away from it long ago for my development and day to day work :). It would help immensely if you can test your code on suse. Meantime I'll test it on my Win10 also. Let's see what happens!

Oh @swissfreedev one more thing I just noticed. I see @wojsys and you are running old version of nitrite. Is it possible for you to test it against 2.2.0-SNAPSHOT in Win10?

Ok this time win10 is innocent, I got the exception on suse leap 43.2 as well, next step is the update to 2.2.0, news will follow...
test startet db=datamulti.db
Thread 2
Thread 1
Thread 3
Thread 4
Thread 5
Exception in thread "Thread-5" java.lang.NullPointerException
at org.h2.mvstore.Page.getRawChildPageCount(Page.java:868)
at org.h2.mvstore.MVMap.getChildPageCount(MVMap.java:1179)
at org.h2.mvstore.Cursor.fetchNext(Cursor.java:149)
at org.h2.mvstore.Cursor.next(Cursor.java:50)
at org.dizitart.no2.internals.DocumentCursor$DocumentCursorIterator.nextMatch(DocumentCursor.java:115)
at org.dizitart.no2.internals.DocumentIterator.next(DocumentIterator.java:54)
at org.dizitart.no2.internals.DocumentIterator.next(DocumentIterator.java:32)
at org.dizitart.no2.objects.ObjectCursor$ObjectCursorIterator.next(ObjectCursor.java:120)
at samples.nitriteperformance.TestThreadMultiCursor.run(TestThreadMultiCursor.java:23)
112161fc-2bea-4ced-b271-d8364100c769
etc.

Really strange. Can you please upload your sample project here?

here it comes: TestMulti() for creating test entries, TestMultiCursor() for producing the error
I' m curious to hear your statement
NitritePerformanceMin.zip

I ran it using 2.2.0-SNAPSHOT it went smoothly on ubuntu 17.10 (64-bit) with JDK 1.8.0_102

Tried with both nitrite 2.1.0 and 2.1.1, no issues either. I'll try to run it couple other systems to see if I can reproduce it.

more and more strange, in this case I can omit a random test with snapshot 2.2.0
=> woisys what is your environment ?

by the way, I'm continuously implementing a Nitrite Admin tool based on your Nitrite explorer 2.0.1 and have added some useful custom features, if you are interested I can share it in a couple of week once a stable state is reached...

Superb!!!! I am eager to see the final product. Great job indeed.

for my own usage I basically added: connect /disconnect since nitrite allows just one connection and its weird to get always the "already connected" error while running two programs, remember/load database path in the local preferencies, direct and quick start without intermediate dialogs, and some cosmetical features
I would now like to add an edit mode if this isn't a big deal, and a table sql-like view in studio3t...

Another development on this issue. I tried it in my office machine - Ubuntu 14.04 (64-bit) with JDK 1.8.0_102. I can see the NPE while using nitrite 2.1.0, but never encountered this with nitrite 2.1.1 or 2.2.0-SNAPSHOT (tried like 30 times with your uploaded code).
Could you please try your code with 2.2.0-SNAPSHOT as well in your machine and share the result?

yes, I'm curious to see what happens, i'll tell you the results soon

Good news: you are right, I switched to 2.1.1 and 2.2.0 the issue is no more reproducible... so just do not use older versions

Great, so I can close this issue. @wojsys please revert back if you are seeing this issue in 2.2.0-SNAPSHOT.
On a separate note @swissfreedev I could not thank you enough for being a backer for this project in https://opencollective.com/nitrite-database. It will surely inspire me a lot more to invest my time in this project. Cheers.


Add python_requires and Trove classifiers

[~] Tests added / passed - All pass except TEST_HDFS, same as master
[~] Passes flake8 dask - No, but fails in the same way as master

This PR:

Adds python_requires to help pip install the right version for the user's version
Adds Trove version classifiers to make support clear on PyPI

Errors are due to an unrelated issue. Thanks! Merging.


Add some config default values and load those in data collector

Description
Add some config default values and load those in data collector.
Only subconfigs that are needed for data collector are initialized here. The proper approach should be to have defaults for all fields (subconfigs with its defaults instead of None's), but more changes are required in order to make it happen.
Type of change

[x] Refactor
[x] New feature
[x] Bug fix

/lgtm

/approve

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 72.05%. Comparing base (d49be6a) to head (1a51869).
Report is 6 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #1179       +/-   ##
===========================================
- Coverage   95.42%   72.05%   -23.37%
===========================================
  Files          56       54        -2
  Lines        2381     2376        -5
===========================================
- Hits         2272     1712      -560
- Misses        109      664      +555

Files
Coverage Δ

ols/app/models/config.py
64.77% <100.00%> (-30.93%)
:arrow_down:

... and 28 files with indirect coverage changes

/retest

/retest

/lgtm


image: use explitic padding on dependency version

This struct currently relies on padding being done by the C compiler.
Although this is generally done the same across targets, this isn't
required, and it is better to make any padding explicit.  This also
makes it clear that there is extra space in this structure that can be
used for another purpose.
The python imgtool is also fixed to match.  It was using a 32-bit int,
which only worked in the little endian case.
Signed-off-by: David Brown<EMAIL_ADDRESS>

@davidvincze, @tamasban, is it difficult for you to test this? I don't believe it should change any behavior.

Thank you for the fix. I've tested it. LGTM


Short term solution for multiple environments

Creating multiple directories can be quickly done with Dockerfile.jupyterlab-environment1 changed to Dockerfile.jupyterlab-environment1

Solution with conda-store proposed and seems to work https://github.com/quansight/conda-store


[v2] Context-Menu Component

Implement new Context-Menu component

+1 feature for desktop design.


Test dry run functionality with github actions

https://github.com/j143/release-scripts/pull/14

yay! asking for the prompt:

There is an issue with dry-run on rc


Wetty Docker Mode : - Google Authenticator Not Working

Hi guys,
Thanks for this wonderful solution. This solution is very easy to be deployed via docker command and works like champ.
However, I found a small issue when I enable my client to run 2fa with goole authenticator. Wetyy seem not able to proceed with login by giving permission denied error instead of asking the fa code.
Can anyone suggest, how to solve this?
Tq

Solve this by setting your argument during docker run.
docker run --rm -p 3000:3000 wettyoss/wetty --ssh-host= --ssh-auth=publickey --ssh-auth=keyboard-interactive

Solve this by setting your argument during docker run.
docker run --rm -p 3000:3000 wettyoss/wetty --ssh-host= --ssh-auth=publickey --ssh-auth=keyboard-interactive


Publish to maven central

Could you publish this library to maven central by any chance? That would be really valuable.

Thanks for the reply. What does MPP mean? I've published libraries to maven central before so maybe I could help.

MPP is Multi-Platform project. This project is MPP (Java, JS and Native), so publish all of them is not so simple.
I can publish only JVM version if you need this, It will not be hard

JVM version would be enough for me so would be really great if you could publish it.

@gildor Any news on this?

Even more relevant with JCenter, Bintray etc going away,

To streamline the productivity of the JFrog Platform we will be sunsetting Bintray (including JCenter), GoCenter, and ChartCenter services on May 1st, 2021.

UPDATE: To better support the community in this migration, JFrog has extended the JCenter new package versions submission deadline through March 31st 2021.
To clarify, the JCenter repository will keep serving packages for 12 months until February 1st 2022. Only the JCenter REST API and UI will be sunsetted on May 1st 2021.

https://jfrog.com/blog/into-the-sunset-bintray-jcenter-gocenter-and-chartcenter/


Update manual.md

fix the dotnet manual doc to remove unused characters.

I like @chalin's solution, makes it look a little bit neater. Do you want to change that accordingly @guangzhengli ? Also please sign the CLA that we can accept your PR

I have created a new PR, is this the correct modification? #2950

@guangzhengli, it should be fine. Typically you can modify existing PR by adding more changes to the current branch.

I had to run the formatter, and this PR has the revision history so I'll merge this one rather than #2950.
Closes #2950

Minor editorial change. Merging.


Post release automated changes for hardwaresecuritymodules releases

Post release automated changes for azure-arm-hardwaresecuritymodules

API change check
API changes are not detected in this pull request.


Unexpected refresh rate behavior while playing videos.

What package does this bug report belong to?
video_player
What target platforms are you seeing this bug on?
Android
Have you already upgraded your packages?
Yes
Dependency versions
pubspec.lock
# Generated by pub
# See https://dart.dev/tools/pub/glossary#lockfile
packages:
  _fe_analyzer_shared:
    dependency: transitive
    description:
      name: _fe_analyzer_shared
      sha256: f256b0c0ba6c7577c15e2e4e114755640a875e885099367bf6e012b19314c834
      url: "https://pub.dev"
    source: hosted
    version: "72.0.0"
  _macros:
    dependency: transitive
    description: dart
    source: sdk
    version: "0.3.2"
  analyzer:
    dependency: transitive
    description:
      name: analyzer
      sha256: b652861553cd3990d8ed361f7979dc6d7053a9ac8843fa73820ab68ce5410139
      url: "https://pub.dev"
    source: hosted
    version: "6.7.0"
  args:
    dependency: transitive
    description:
      name: args
      sha256: bf9f5caeea8d8fe6721a9c358dd8a5c1947b27f1cfaa18b39c301273594919e6
      url: "https://pub.dev"
    source: hosted
    version: "2.6.0"
  async:
    dependency: transitive
    description:
      name: async
      sha256: "947bfcf187f74dbc5e146c9eb9c0f10c9f8b30743e341481c1e2ed3ecc18c20c"
      url: "https://pub.dev"
    source: hosted
    version: "2.11.0"
  boolean_selector:
    dependency: transitive
    description:
      name: boolean_selector
      sha256: "6cfb5af12253eaf2b368f07bacc5a80d1301a071c73360d746b7f2e32d762c66"
      url: "https://pub.dev"
    source: hosted
    version: "2.1.1"
  build:
    dependency: transitive
    description:
      name: build
      sha256: "80184af8b6cb3e5c1c4ec6d8544d27711700bc3e6d2efad04238c7b5290889f0"
      url: "https://pub.dev"
    source: hosted
    version: "2.4.1"
  build_config:
    dependency: transitive
    description:
      name: build_config
      sha256: bf80fcfb46a29945b423bd9aad884590fb1dc69b330a4d4700cac476af1708d1
      url: "https://pub.dev"
    source: hosted
    version: "1.1.1"
  build_daemon:
    dependency: transitive
    description:
      name: build_daemon
      sha256: "79b2aef6ac2ed00046867ed354c88778c9c0f029df8a20fe10b5436826721ef9"
      url: "https://pub.dev"
    source: hosted
    version: "4.0.2"
  build_resolvers:
    dependency: transitive
    description:
      name: build_resolvers
      sha256: "339086358431fa15d7eca8b6a36e5d783728cf025e559b834f4609a1fcfb7b0a"
      url: "https://pub.dev"
    source: hosted
    version: "2.4.2"
  build_runner:
    dependency: "direct dev"
    description:
      name: build_runner
      sha256: "028819cfb90051c6b5440c7e574d1896f8037e3c96cf17aaeb054c9311cfbf4d"
      url: "https://pub.dev"
    source: hosted
    version: "2.4.13"
  build_runner_core:
    dependency: transitive
    description:
      name: build_runner_core
      sha256: f8126682b87a7282a339b871298cc12009cb67109cfa1614d6436fb0289193e0
      url: "https://pub.dev"
    source: hosted
    version: "7.3.2"
  built_collection:
    dependency: transitive
    description:
      name: built_collection
      sha256: "376e3dd27b51ea877c28d525560790aee2e6fbb5f20e2f85d5081027d94e2100"
      url: "https://pub.dev"
    source: hosted
    version: "5.1.1"
  built_value:
    dependency: transitive
    description:
      name: built_value
      sha256: c7913a9737ee4007efedaffc968c049fd0f3d0e49109e778edc10de9426005cb
      url: "https://pub.dev"
    source: hosted
    version: "8.9.2"
  characters:
    dependency: transitive
    description:
      name: characters
      sha256: "04a925763edad70e8443c99234dc3328f442e811f1d8fd1a72f1c8ad0f69a605"
      url: "https://pub.dev"
    source: hosted
    version: "1.3.0"
  checked_yaml:
    dependency: transitive
    description:
      name: checked_yaml
      sha256: feb6bed21949061731a7a75fc5d2aa727cf160b91af9a3e464c5e3a32e28b5ff
      url: "https://pub.dev"
    source: hosted
    version: "2.0.3"
  clock:
    dependency: transitive
    description:
      name: clock
      sha256: cb6d7f03e1de671e34607e909a7213e31d7752be4fb66a86d29fe1eb14bfb5cf
      url: "https://pub.dev"
    source: hosted
    version: "1.1.1"
  code_builder:
    dependency: transitive
    description:
      name: code_builder
      sha256: "0ec10bf4a89e4c613960bf1e8b42c64127021740fb21640c29c909826a5eea3e"
      url: "https://pub.dev"
    source: hosted
    version: "4.10.1"
  collection:
    dependency: transitive
    description:
      name: collection
      sha256: ee67cb0715911d28db6bf4af1026078bd6f0128b07a5f66fb2ed94ec6783c09a
      url: "https://pub.dev"
    source: hosted
    version: "1.18.0"
  convert:
    dependency: transitive
    description:
      name: convert
      sha256: b30acd5944035672bc15c6b7a8b47d773e41e2f17de064350988c5d02adb1c68
      url: "https://pub.dev"
    source: hosted
    version: "3.1.2"
  coverage:
    dependency: transitive
    description:
      name: coverage
      sha256: "4b03e11f6d5b8f6e5bb5e9f7889a56fe6c5cbe942da5378ea4d4d7f73ef9dfe5"
      url: "https://pub.dev"
    source: hosted
    version: "1.11.0"
  crypto:
    dependency: transitive
    description:
      name: crypto
      sha256: "1e445881f28f22d6140f181e07737b22f1e099a5e1ff94b0af2f9e4a463f4855"
      url: "https://pub.dev"
    source: hosted
    version: "3.0.6"
  csslib:
    dependency: transitive
    description:
      name: csslib
      sha256: "09bad715f418841f976c77db72d5398dc1253c21fb9c0c7f0b0b985860b2d58e"
      url: "https://pub.dev"
    source: hosted
    version: "1.0.2"
  dart_style:
    dependency: transitive
    description:
      name: dart_style
      sha256: "7856d364b589d1f08986e140938578ed36ed948581fbc3bc9aef1805039ac5ab"
      url: "https://pub.dev"
    source: hosted
    version: "2.3.7"
  fake_async:
    dependency: transitive
    description:
      name: fake_async
      sha256: "511392330127add0b769b75a987850d136345d9227c6b94c96a04cf4a391bf78"
      url: "https://pub.dev"
    source: hosted
    version: "1.3.1"
  ffi:
    dependency: transitive
    description:
      name: ffi
      sha256: "16ed7b077ef01ad6170a3d0c57caa4a112a38d7a2ed5602e0aca9ca6f3d98da6"
      url: "https://pub.dev"
    source: hosted
    version: "2.1.3"
  file:
    dependency: transitive
    description:
      name: file
      sha256: "5fc22d7c25582e38ad9a8515372cd9a93834027aacf1801cf01164dac0ffa08c"
      url: "https://pub.dev"
    source: hosted
    version: "7.0.0"
  fixnum:
    dependency: transitive
    description:
      name: fixnum
      sha256: b6dc7065e46c974bc7c5f143080a6764ec7a4be6da1285ececdc37be96de53be
      url: "https://pub.dev"
    source: hosted
    version: "1.1.1"
  flutter:
    dependency: "direct main"
    description: flutter
    source: sdk
    version: "0.0.0"
  flutter_driver:
    dependency: transitive
    description: flutter
    source: sdk
    version: "0.0.0"
  flutter_test:
    dependency: "direct dev"
    description: flutter
    source: sdk
    version: "0.0.0"
  flutter_web_plugins:
    dependency: transitive
    description: flutter
    source: sdk
    version: "0.0.0"
  frontend_server_client:
    dependency: transitive
    description:
      name: frontend_server_client
      sha256: f64a0333a82f30b0cca061bc3d143813a486dc086b574bfb233b7c1372427694
      url: "https://pub.dev"
    source: hosted
    version: "4.0.0"
  fuchsia_remote_debug_protocol:
    dependency: transitive
    description: flutter
    source: sdk
    version: "0.0.0"
  glob:
    dependency: transitive
    description:
      name: glob
      sha256: "0e7014b3b7d4dac1ca4d6114f82bf1782ee86745b9b42a92c9289c23d8a0ab63"
      url: "https://pub.dev"
    source: hosted
    version: "2.1.2"
  graphs:
    dependency: transitive
    description:
      name: graphs
      sha256: "741bbf84165310a68ff28fe9e727332eef1407342fca52759cb21ad8177bb8d0"
      url: "https://pub.dev"
    source: hosted
    version: "2.3.2"
  html:
    dependency: transitive
    description:
      name: html
      sha256: "1fc58edeaec4307368c60d59b7e15b9d658b57d7f3125098b6294153c75337ec"
      url: "https://pub.dev"
    source: hosted
    version: "0.15.5"
  http_multi_server:
    dependency: transitive
    description:
      name: http_multi_server
      sha256: "97486f20f9c2f7be8f514851703d0119c3596d14ea63227af6f7a481ef2b2f8b"
      url: "https://pub.dev"
    source: hosted
    version: "3.2.1"
  http_parser:
    dependency: transitive
    description:
      name: http_parser
      sha256: "2aa08ce0341cc9b354a498388e30986515406668dbcc4f7c950c3e715496693b"
      url: "https://pub.dev"
    source: hosted
    version: "4.0.2"
  integration_test:
    dependency: "direct dev"
    description: flutter
    source: sdk
    version: "0.0.0"
  io:
    dependency: transitive
    description:
      name: io
      sha256: "2ec25704aba361659e10e3e5f5d672068d332fc8ac516421d483a11e5cbd061e"
      url: "https://pub.dev"
    source: hosted
    version: "1.0.4"
  js:
    dependency: transitive
    description:
      name: js
      sha256: c1b2e9b5ea78c45e1a0788d29606ba27dc5f71f019f32ca5140f61ef071838cf
      url: "https://pub.dev"
    source: hosted
    version: "0.7.1"
  json_annotation:
    dependency: transitive
    description:
      name: json_annotation
      sha256: "1ce844379ca14835a50d2f019a3099f419082cfdd231cd86a142af94dd5c6bb1"
      url: "https://pub.dev"
    source: hosted
    version: "4.9.0"
  leak_tracker:
    dependency: transitive
    description:
      name: leak_tracker
      sha256: "3f87a60e8c63aecc975dda1ceedbc8f24de75f09e4856ea27daf8958f2f0ce05"
      url: "https://pub.dev"
    source: hosted
    version: "10.0.5"
  leak_tracker_flutter_testing:
    dependency: transitive
    description:
      name: leak_tracker_flutter_testing
      sha256: "932549fb305594d82d7183ecd9fa93463e9914e1b67cacc34bc40906594a1806"
      url: "https://pub.dev"
    source: hosted
    version: "3.0.5"
  leak_tracker_testing:
    dependency: transitive
    description:
      name: leak_tracker_testing
      sha256: "6ba465d5d76e67ddf503e1161d1f4a6bc42306f9d66ca1e8f079a47290fb06d3"
      url: "https://pub.dev"
    source: hosted
    version: "3.0.1"
  logging:
    dependency: transitive
    description:
      name: logging
      sha256: c8245ada5f1717ed44271ed1c26b8ce85ca3228fd2ffdb75468ab01979309d61
      url: "https://pub.dev"
    source: hosted
    version: "1.3.0"
  macros:
    dependency: transitive
    description:
      name: macros
      sha256: "0acaed5d6b7eab89f63350bccd82119e6c602df0f391260d0e32b5e23db79536"
      url: "https://pub.dev"
    source: hosted
    version: "0.1.2-main.4"
  matcher:
    dependency: transitive
    description:
      name: matcher
      sha256: d2323aa2060500f906aa31a895b4030b6da3ebdcc5619d14ce1aada65cd161cb
      url: "https://pub.dev"
    source: hosted
    version: "0.12.16+1"
  material_color_utilities:
    dependency: transitive
    description:
      name: material_color_utilities
      sha256: f7142bb1154231d7ea5f96bc7bde4bda2a0945d2806bb11670e30b850d56bdec
      url: "https://pub.dev"
    source: hosted
    version: "0.11.1"
  meta:
    dependency: transitive
    description:
      name: meta
      sha256: bdb68674043280c3428e9ec998512fb681678676b3c54e773629ffe74419f8c7
      url: "https://pub.dev"
    source: hosted
    version: "1.15.0"
  mime:
    dependency: transitive
    description:
      name: mime
      sha256: "41a20518f0cb1256669420fdba0cd90d21561e560ac240f26ef8322e45bb7ed6"
      url: "https://pub.dev"
    source: hosted
    version: "2.0.0"
  node_preamble:
    dependency: transitive
    description:
      name: node_preamble
      sha256: "6e7eac89047ab8a8d26cf16127b5ed26de65209847630400f9aefd7cd5c730db"
      url: "https://pub.dev"
    source: hosted
    version: "2.0.2"
  package_config:
    dependency: transitive
    description:
      name: package_config
      sha256: "1c5b77ccc91e4823a5af61ee74e6b972db1ef98c2ff5a18d3161c982a55448bd"
      url: "https://pub.dev"
    source: hosted
    version: "2.1.0"
  path:
    dependency: transitive
    description:
      name: path
      sha256: "087ce49c3f0dc39180befefc60fdb4acd8f8620e5682fe2476afd0b3688bb4af"
      url: "https://pub.dev"
    source: hosted
    version: "1.9.0"
  path_provider:
    dependency: "direct dev"
    description:
      name: path_provider
      sha256: "50c5dd5b6e1aaf6fb3a78b33f6aa3afca52bf903a8a5298f53101fdaee55bbcd"
      url: "https://pub.dev"
    source: hosted
    version: "2.1.5"
  path_provider_android:
    dependency: transitive
    description:
      name: path_provider_android
      sha256: c464428172cb986b758c6d1724c603097febb8fb855aa265aeecc9280c294d4a
      url: "https://pub.dev"
    source: hosted
    version: "2.2.12"
  path_provider_foundation:
    dependency: transitive
    description:
      name: path_provider_foundation
      sha256: f234384a3fdd67f989b4d54a5d73ca2a6c422fa55ae694381ae0f4375cd1ea16
      url: "https://pub.dev"
    source: hosted
    version: "2.4.0"
  path_provider_linux:
    dependency: transitive
    description:
      name: path_provider_linux
      sha256: f7a1fe3a634fe7734c8d3f2766ad746ae2a2884abe22e241a8b301bf5cac3279
      url: "https://pub.dev"
    source: hosted
    version: "2.2.1"
  path_provider_platform_interface:
    dependency: transitive
    description:
      name: path_provider_platform_interface
      sha256: "88f5779f72ba699763fa3a3b06aa4bf6de76c8e5de842cf6f29e2e06476c2334"
      url: "https://pub.dev"
    source: hosted
    version: "2.1.2"
  path_provider_windows:
    dependency: transitive
    description:
      name: path_provider_windows
      sha256: bd6f00dbd873bfb70d0761682da2b3a2c2fccc2b9e84c495821639601d81afe7
      url: "https://pub.dev"
    source: hosted
    version: "2.3.0"
  platform:
    dependency: transitive
    description:
      name: platform
      sha256: "9b71283fc13df574056616011fb138fd3b793ea47cc509c189a6c3fa5f8a1a65"
      url: "https://pub.dev"
    source: hosted
    version: "3.1.5"
  plugin_platform_interface:
    dependency: transitive
    description:
      name: plugin_platform_interface
      sha256: "4820fbfdb9478b1ebae27888254d445073732dae3d6ea81f0b7e06d5dedc3f02"
      url: "https://pub.dev"
    source: hosted
    version: "2.1.8"
  pool:
    dependency: transitive
    description:
      name: pool
      sha256: "20fe868b6314b322ea036ba325e6fc0711a22948856475e2c2b6306e8ab39c2a"
      url: "https://pub.dev"
    source: hosted
    version: "1.5.1"
  process:
    dependency: transitive
    description:
      name: process
      sha256: "21e54fd2faf1b5bdd5102afd25012184a6793927648ea81eea80552ac9405b32"
      url: "https://pub.dev"
    source: hosted
    version: "5.0.2"
  pub_semver:
    dependency: transitive
    description:
      name: pub_semver
      sha256: "40d3ab1bbd474c4c2328c91e3a7df8c6dd629b79ece4c4bd04bee496a224fb0c"
      url: "https://pub.dev"
    source: hosted
    version: "2.1.4"
  pubspec_parse:
    dependency: transitive
    description:
      name: pubspec_parse
      sha256: c799b721d79eb6ee6fa56f00c04b472dcd44a30d258fac2174a6ec57302678f8
      url: "https://pub.dev"
    source: hosted
    version: "1.3.0"
  shelf:
    dependency: transitive
    description:
      name: shelf
      sha256: ad29c505aee705f41a4d8963641f91ac4cee3c8fad5947e033390a7bd8180fa4
      url: "https://pub.dev"
    source: hosted
    version: "1.4.1"
  shelf_packages_handler:
    dependency: transitive
    description:
      name: shelf_packages_handler
      sha256: "89f967eca29607c933ba9571d838be31d67f53f6e4ee15147d5dc2934fee1b1e"
      url: "https://pub.dev"
    source: hosted
    version: "3.0.2"
  shelf_static:
    dependency: transitive
    description:
      name: shelf_static
      sha256: c87c3875f91262785dade62d135760c2c69cb217ac759485334c5857ad89f6e3
      url: "https://pub.dev"
    source: hosted
    version: "1.1.3"
  shelf_web_socket:
    dependency: transitive
    description:
      name: shelf_web_socket
      sha256: cc36c297b52866d203dbf9332263c94becc2fe0ceaa9681d07b6ef9807023b67
      url: "https://pub.dev"
    source: hosted
    version: "2.0.1"
  sky_engine:
    dependency: transitive
    description: flutter
    source: sdk
    version: "0.0.99"
  source_map_stack_trace:
    dependency: transitive
    description:
      name: source_map_stack_trace
      sha256: c0713a43e323c3302c2abe2a1cc89aa057a387101ebd280371d6a6c9fa68516b
      url: "https://pub.dev"
    source: hosted
    version: "2.1.2"
  source_maps:
    dependency: transitive
    description:
      name: source_maps
      sha256: "708b3f6b97248e5781f493b765c3337db11c5d2c81c3094f10904bfa8004c703"
      url: "https://pub.dev"
    source: hosted
    version: "0.10.12"
  source_span:
    dependency: transitive
    description:
      name: source_span
      sha256: "53e943d4206a5e30df338fd4c6e7a077e02254531b138a15aec3bd143c1a8b3c"
      url: "https://pub.dev"
    source: hosted
    version: "1.10.0"
  stack_trace:
    dependency: transitive
    description:
      name: stack_trace
      sha256: "73713990125a6d93122541237550ee3352a2d84baad52d375a4cad2eb9b7ce0b"
      url: "https://pub.dev"
    source: hosted
    version: "1.11.1"
  stream_channel:
    dependency: transitive
    description:
      name: stream_channel
      sha256: ba2aa5d8cc609d96bbb2899c28934f9e1af5cddbd60a827822ea467161eb54e7
      url: "https://pub.dev"
    source: hosted
    version: "2.1.2"
  stream_transform:
    dependency: transitive
    description:
      name: stream_transform
      sha256: "14a00e794c7c11aa145a170587321aedce29769c08d7f58b1d141da75e3b1c6f"
      url: "https://pub.dev"
    source: hosted
    version: "2.1.0"
  string_scanner:
    dependency: transitive
    description:
      name: string_scanner
      sha256: "556692adab6cfa87322a115640c11f13cb77b3f076ddcc5d6ae3c20242bedcde"
      url: "https://pub.dev"
    source: hosted
    version: "1.2.0"
  sync_http:
    dependency: transitive
    description:
      name: sync_http
      sha256: "7f0cd72eca000d2e026bcd6f990b81d0ca06022ef4e32fb257b30d3d1014a961"
      url: "https://pub.dev"
    source: hosted
    version: "0.3.1"
  term_glyph:
    dependency: transitive
    description:
      name: term_glyph
      sha256: a29248a84fbb7c79282b40b8c72a1209db169a2e0542bce341da992fe1bc7e84
      url: "https://pub.dev"
    source: hosted
    version: "1.2.1"
  test:
    dependency: "direct dev"
    description:
      name: test
      sha256: "7ee44229615f8f642b68120165ae4c2a75fe77ae2065b1e55ae4711f6cf0899e"
      url: "https://pub.dev"
    source: hosted
    version: "1.25.7"
  test_api:
    dependency: transitive
    description:
      name: test_api
      sha256: "5b8a98dafc4d5c4c9c72d8b31ab2b23fc13422348d2997120294d3bac86b4ddb"
      url: "https://pub.dev"
    source: hosted
    version: "0.7.2"
  test_core:
    dependency: transitive
    description:
      name: test_core
      sha256: "55ea5a652e38a1dfb32943a7973f3681a60f872f8c3a05a14664ad54ef9c6696"
      url: "https://pub.dev"
    source: hosted
    version: "0.6.4"
  timing:
    dependency: transitive
    description:
      name: timing
      sha256: "70a3b636575d4163c477e6de42f247a23b315ae20e86442bebe32d3cabf61c32"
      url: "https://pub.dev"
    source: hosted
    version: "1.0.1"
  typed_data:
    dependency: transitive
    description:
      name: typed_data
      sha256: f9049c039ebfeb4cf7a7104a675823cd72dba8297f264b6637062516699fa006
      url: "https://pub.dev"
    source: hosted
    version: "1.4.0"
  vector_math:
    dependency: transitive
    description:
      name: vector_math
      sha256: "80b3257d1492ce4d091729e3a67a60407d227c27241d6927be0130c98e741803"
      url: "https://pub.dev"
    source: hosted
    version: "2.1.4"
  video_player:
    dependency: "direct main"
    description:
      name: video_player
      sha256: "4a8c3492d734f7c39c2588a3206707a05ee80cef52e8c7f3b2078d430c84bc17"
      url: "https://pub.dev"
    source: hosted
    version: "2.9.2"
  video_player_android:
    dependency: transitive
    description:
      name: video_player_android
      sha256: "391e092ba4abe2f93b3e625bd6b6a6ec7d7414279462c1c0ee42b5ab8d0a0898"
      url: "https://pub.dev"
    source: hosted
    version: "2.7.16"
  video_player_avfoundation:
    dependency: transitive
    description:
      name: video_player_avfoundation
      sha256: "0b146e5d82e886ff43e5a46c6bcbe390761b802864a6e2503eb612d69a405dfa"
      url: "https://pub.dev"
    source: hosted
    version: "2.6.3"
  video_player_platform_interface:
    dependency: transitive
    description:
      name: video_player_platform_interface
      sha256: "229d7642ccd9f3dc4aba169609dd6b5f3f443bb4cc15b82f7785fcada5af9bbb"
      url: "https://pub.dev"
    source: hosted
    version: "6.2.3"
  video_player_web:
    dependency: transitive
    description:
      name: video_player_web
      sha256: "881b375a934d8ebf868c7fb1423b2bfaa393a0a265fa3f733079a86536064a10"
      url: "https://pub.dev"
    source: hosted
    version: "2.3.3"
  vm_service:
    dependency: transitive
    description:
      name: vm_service
      sha256: "5c5f338a667b4c644744b661f309fb8080bb94b18a7e91ef1dbd343bed00ed6d"
      url: "https://pub.dev"
    source: hosted
    version: "14.2.5"
  watcher:
    dependency: transitive
    description:
      name: watcher
      sha256: "3d2ad6751b3c16cf07c7fca317a1413b3f26530319181b37e3b9039b84fc01d8"
      url: "https://pub.dev"
    source: hosted
    version: "1.1.0"
  web:
    dependency: transitive
    description:
      name: web
      sha256: cd3543bd5798f6ad290ea73d210f423502e71900302dde696f8bff84bf89a1cb
      url: "https://pub.dev"
    source: hosted
    version: "1.1.0"
  web_socket:
    dependency: transitive
    description:
      name: web_socket
      sha256: "3c12d96c0c9a4eec095246debcea7b86c0324f22df69893d538fcc6f1b8cce83"
      url: "https://pub.dev"
    source: hosted
    version: "0.1.6"
  web_socket_channel:
    dependency: transitive
    description:
      name: web_socket_channel
      sha256: "9f187088ed104edd8662ca07af4b124465893caf063ba29758f97af57e61da8f"
      url: "https://pub.dev"
    source: hosted
    version: "3.0.1"
  webdriver:
    dependency: transitive
    description:
      name: webdriver
      sha256: "003d7da9519e1e5f329422b36c4dcdf18d7d2978d1ba099ea4e45ba490ed845e"
      url: "https://pub.dev"
    source: hosted
    version: "3.0.3"
  webkit_inspection_protocol:
    dependency: transitive
    description:
      name: webkit_inspection_protocol
      sha256: "87d3f2333bb240704cd3f1c6b5b7acd8a10e7f0bc28c28dcf14e782014f4a572"
      url: "https://pub.dev"
    source: hosted
    version: "1.2.1"
  xdg_directories:
    dependency: transitive
    description:
      name: xdg_directories
      sha256: "7a3f37b05d989967cdddcbb571f1ea834867ae2faa29725fd085180e0883aa15"
      url: "https://pub.dev"
    source: hosted
    version: "1.1.0"
  yaml:
    dependency: transitive
    description:
      name: yaml
      sha256: "75769501ea3489fca56601ff33454fe45507ea3bfb014161abc3b43ae25989d5"
      url: "https://pub.dev"
    source: hosted
    version: "3.1.2"
sdks:
  dart: ">=3.5.0 <4.0.0"
  flutter: ">=3.24.0"

Steps to reproduce

Run the example app (https://github.com/flutter/packages/tree/main/packages/video_player/video_player/example) on a device with variable refresh rate, in release mode (I have encountered the issue on a Samsung Galaxy S24 Ultra running Android 14, One UI 6.1.1, but also on a Samsung Galaxy S21+, Android 14, One UI 6.1).
Enable "Show refresh rate" in the developer options and make sure the phone refresh rate is set to Adaptive.
Open the app. You'll see the refresh rate in the top left corner switch from 120 to a lower value (60, 48, 24, depending on the minimum the phone supports) as you navigate through the app.
Play any video inside the example app. While the video is playing, the refresh rate is forced to always be the highest supported (120 in my case). As soon as the video is paused, the refresh rate will return to being adaptive.
Download the video from the assets folder in the app (https://github.com/flutter/packages/blob/main/packages/video_player/video_player/example/assets/Butterfly-209.mp4) and play it with any native Android video player (on Samsung try the Gallery app). You will see the refresh rate switching as expected to a lower one, as expected.

Expected results
On the Flutter app, while playing the video, the refresh rate should change based on the framerate of the video or at least go to a lower value that does not affect the video playback (such as 60hz), a behavior that matches the native one.
Actual results
The refresh rate while playing the video is capped to the highest one the phone supports. This is an issue on apps that primarily stream videos because the battery life will be much worse if the refresh rate is locked to 120hz.
Code sample
Code sample: https://github.com/flutter/packages/tree/main/packages/video_player/video_player/example
Screenshots or Videos
Screenshots / Video demonstration
Unfortunately, I cannot provide any video or photo demonstration because, when screen recording or screenshoting, the refresh rate is locked to 120hz. When using the app normally, the issue can be observed clearly. Also, I don't have another device on hand at the moment to film the screen.
Logs
Not applicable.
Flutter Doctor output
Doctor output
[✓] Flutter (Channel stable, 3.24.3, on Microsoft Windows [Version 10.0.26100.2448], locale ro-RO)
    • Flutter version 3.24.3 on channel stable at C:\Tools\flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 2663184aa7 (2 months ago), 2024-09-11 16:27:48 -0500
    • Engine revision 36335019a8
    • Dart version 3.5.3
    • DevTools version 2.37.3

[✓] Windows Version (Installed version of Windows is version 10 or higher)

[✓] Android toolchain - develop for Android devices (Android SDK version 35.0.0)
    • Android SDK at C:\Users\iamco\AppData\Local\Android\sdk
    • Platform android-35, build-tools 35.0.0
    • Java binary at: C:\Program Files\Android\Android Studio\jbr\bin\java
    • Java version OpenJDK Runtime Environment (build 17.0.11+0--11852314)
    • All Android licenses accepted.

[✗] Chrome - develop for the web (Cannot find Chrome executable at .\Google\Chrome\Application\chrome.exe)
    ! Cannot find Chrome. Try setting CHROME_EXECUTABLE to a Chrome executable.

[✓] Visual Studio - develop Windows apps (Visual Studio Community 2022 17.11.6)
    • Visual Studio at C:\Program Files\Microsoft Visual Studio\2022\Community
    • Visual Studio Community 2022 version 17.11.35431.28
    • Windows 10 SDK version 10.0.22621.0

[✓] Android Studio (version 2024.1)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.11+0--11852314)

[✓] VS Code (version 1.95.2)
    • VS Code at C:\Users\iamco\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.100.0

[✓] Connected device (2 available)
    • Windows (desktop) • windows • windows-x64    • Microsoft Windows [Version 10.0.26100.2448]
    • Edge (web)        • edge    • web-javascript • Microsoft Edge 131.0.2903.51

[✓] Network resources
    • All expected network resources are available.

! Doctor found issues in 1 category.

Thanks for the report. I tried the plugin example on S10+ device which shows 60 fps constant refresh rate. There have been related issues on refresh rates as below:
https://github.com/flutter/flutter/issues/151067
And maybe this is closely related : https://github.com/flutter/flutter/issues/61958
I will keep the issue open for team's tracking.
stable : 3.24.5
master : 3.27.0-1.0.pre.628

As far as I know, the S10+ supports only 60hz and does not have the variable refresh rate feature, so the issue can't be reproduced on that type of device.
Regarding the mentioned issues, the first one does not apply because the app is not limited to 60hz on VRR devices (at least not anymore). In a classic Flutter app, interacting with menus toggles the device refresh rate to the maximum, so the movement on the screen shows smoothly. When not interacting with the app, the refresh rate does go to a lower value, to preserve battery. The issue is when the video is playing, the refresh rate is locked to the highest supported value. As soon as the video is paused from running, or is not running at all, the refresh rate is variable like it should be. In native Android apps, for example YouTube, Disney+, Netflix, etc., the refresh rate goes as low as possible when the video is running to save battery. That's not the case for Flutter apps that do depend on streaming videos, and it makes the battery drain unbearable.
I should've mentioned that I even tried the flutter_displaymode plugin (https://pub.dev/packages/flutter_displaymode) and, when not playing videos, the device does respect the refresh rate I set manually with this plugin. When playing any video, the refresh rate goes to maximum again. This makes me think that something about the video_player package is locking the refresh rate, making this an issue.


Disable -Werror for pseries_defconfig for now

Yes, realized after the fact and just linked this PR against #189 :)
Thanks for the review!


Hotekit does not see the device when adding

Something happened after update 0.6.0. If I am flashing a new device, the device is not located in the Home app. If I install version 0.5.0, add the device to the house, after that I update it to version 0.6.0, then the firmware is installed and everything works, but if I remove the device from the house, then again it is impossible to add it with version 0.6.0. To check this, I downloaded both files and added one by one to my modeling repository. The same with the files that I compiled at home, I can update the firmware with my file, but I can not connect my compiled file from the latest version of the repository to the homekit.

Post a log and I can take a look

try 0.6.1 . 0.6.0 broke pairing although an already paired device was ok.

Sorry I forgot to push the latest code, sorted now. Pull that and you should be good .


XMPP (RFC 6120), PubSub (XEP-0060) and Atom Over XMPP (RFC 4287)

This is a feature request, not an issue.

Greetings!
My name is Schimon and I am a champion of Syndication and XMPP.
For those of you who are not famiiliar, XMPP (previously Jabber) is a messaging system with open standards. XMPP is extensible via XEP.
I will discuss about XEP-0060: Publish-Subscribe.
Almost a couple of decades ago, a discussion arose about incorporating Atom (RFC 4287) with XMPP PubSub, which is really easy because both are XML data.
One of the major benefits of utilizing PubSub is native Push Notifications (yes, that technique was much before HTML5) which do not require HTTP pulling.
That would be a great feature to have Newsboat to utilize XMPP PubSub natively!
See a proof of concept I have made to parse PubSub nodes as Atom Syndication Format.
https://datatracker.ietf.org/meeting/66/materials/slides-66-atompub-1.pdf
https://codeberg.org/poezio/slixmpp/issues/3526
Cheers,
Schimon

The proof of concept script has developed into an HTTP gateway.
I encourage you to view the video demonstration (length 7:44).

https://video.xmpp-it.net/w/vNqcMooy3pqRAZ8Yb8grr1
https://git.xmpp-it.net/sch/Rivista


[6.0] Cherry-pick recent NFC changes to reduce merge conflicts

Includes these PRs cherry-picked off main

https://github.com/swiftlang/swift-package-manager/pull/7605
https://github.com/swiftlang/swift-package-manager/pull/7660
https://github.com/swiftlang/swift-package-manager/pull/7667
https://github.com/swiftlang/swift-package-manager/pull/7682
https://github.com/swiftlang/swift-package-manager/pull/7687
https://github.com/swiftlang/swift-package-manager/pull/7690
https://github.com/swiftlang/swift-package-manager/pull/7684
https://github.com/swiftlang/swift-package-manager/pull/7679

Explanation: Cherry-pick of recent NFC changes, which makes it easier to cherry-pick actual bug fixes onto 6.0 due to the reduced number of merge conflicts.
Scope: broad, includes both modules graph and llbuild-related changes.
Risk: low, the test suite is passing, no functional changes are included, and cherry-picked changes were incubated on main for some time.
Testing: Existing automated test suite.
Issue: N/A
Reviewers: @xedin @MaxDesiatov @rauhul

@swift-ci test

CI seems to be blocked on swift-format errors apparently unrelated to this change.

@swift-ci test


Typo on page console-deploy-wizard.html

Page Deploy Tanzu Kubernetes Grid Integrated Edition by Using the Configuration Wizard

The same is true for doc pages since TKGI 1.5

Thank you, @Hyacinthe-Jacquet


Version Blazor JS interop circular references content

Fixes #17651
I have a suspicion that Blazor must react to the runtime's updates at https://github.com/dotnet/runtime/issues/30820 based on DR's remark at https://github.com/dotnet/aspnetcore/issues/20525#issuecomment-623865683.
If Blazor requires more work, then we can either:

Close this and put the issue back on hold if updates aren't going to make it for 5.0.
Go ahead and merge if the work in Blazor has been done for 5.0.

Moving the issue to HOLD because Blazor will require work to take advantage of the runtime updates for circular references.


Use net/http Request.Form for params instead of Params

The motivation behind this PR is to attempt to use the existing Form map in the http.Request struct instead of adding an additional parameter, Params, to the Handler function. This has the advantage of being compatible with handlers following the syntax of the net/http package while maintaining the ability to use URL parameters.
Using GitHub as the example from go-http-routing-benchmark; JHttpRouter can be seen to be slower and using a little more memory, there are fewer memory allocations. I feel the downsides may be an acceptable trade off for compatibility.
BenchmarkJHttpRouter_GithubStatic   20000000    86.6 ns/op     0 B/op        0 allocs/op
BenchmarkHttpRouter_GithubStatic    20000000    77.4 ns/op     0 B/op        0 allocs/op
BenchmarkJHttpRouter_GithubParam    3000000     472 ns/op      180 B/op      0 allocs/op
BenchmarkHttpRouter_GithubParam     5000000     340 ns/op	   96 B/op       1 allocs/op
BenchmarkJHttpRouter_GithubAll      20000       82118 ns/op    19235 B/op    0 allocs/op
BenchmarkHttpRouter_GithubAll       30000       60360 ns/op    13792 B/op    167 allocs/op

While I believe this may be at odds with @julienschmidt 's ideology for httprouter, I am still interested in their feedback and thoughts :)

Hello, @jamescun. I like your idea of using Form for parameters instead of Params. However, looks like it brings another incompatibility with the standard library. You are manually allocating r.Form  (file tree.go):
341 // lazy allocation
342 r.Form = make(url.Values)

That makes impossible the use of ParseForm and ParseMultipartForm as they work only if r.Form is nil:
779 func (r *Request) ParseForm() error {
780 	var err error
789 	if r.Form == nil {
    		...
810 	}
811 	return err
812 }

I'm curious how would you solve that problem?


probe return body as well as statuscode

Please provide a description of this PR:
Some times the app probe return failed, and the user want to get some error information from the probe return body, so I think istio-pilot agent shout return the probe body as well as the statuscode.

Hi @wuzhuoquan. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Please change to follow https://github.com/kubernetes/kubernetes/blob/67f72d0e90f8a57c7e761a5fb34f6c4b21c25462/pkg/probe/http/http.go#L102 logic. If so, LGTM.

Thanks for your suggest. But I think the  probe check logic shout be done in the kubelet ,not in the istio pilot-agent. Pilot-agent is a proxy to the probe, return what probe return may be better for the user to observe the real return of the  app.
thank you!

/ok-to-test

@wuzhuoquan: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
bd25480d8ea6317a2db4bf23bfad2d82e43238a5
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest-required

/retest-required

@wuzhuoquan: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
edd8aa63dd89f08d8ead81dde8f301abfa6f60ef
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@wuzhuoquan K8s has used a LimitedReader in recent release, it is for security. You can use io.LimitedReader here

I've change to use utilio.ReadAtMost(response.Body, maxRespBodyLength) instead.But not sure if need to handle the err，because k8s probe has do it already.

@wuzhuoquan: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
d017f8d63996321f2f4381c12eb9e700b078a093
link
true
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@wuzhuoquan: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
a7f770b64dc38cb8f4a0c9b770bab6c1702f78a8
link
true
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@wuzhuoquan: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
a7f770b64dc38cb8f4a0c9b770bab6c1702f78a8
link
true
/test lint

gencheck_istio
a7f770b64dc38cb8f4a0c9b770bab6c1702f78a8
link
true
/test gencheck

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@wuzhuoquan: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

gencheck_istio
a7f770b64dc38cb8f4a0c9b770bab6c1702f78a8
link
true
/test gencheck

lint_istio
e455816e6d9ba7c1d261f5fbd8d9cd409f746452
link
true
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@wuzhuoquan: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
e455816e6d9ba7c1d261f5fbd8d9cd409f746452
link
true
/test lint

gencheck_istio
e455816e6d9ba7c1d261f5fbd8d9cd409f746452
link
true
/test gencheck

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@wuzhuoquan: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

gencheck_istio
fd548fbcb0763ab6918e0647f8ecb79847b68161
link
true
/test gencheck

lint_istio
fd548fbcb0763ab6918e0647f8ecb79847b68161
link
true
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@wuzhuoquan: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

gencheck_istio
fd548fbcb0763ab6918e0647f8ecb79847b68161
link
true
/test gencheck

lint_istio
87686d0082a167334f2efe7d24a159beeb6fba87
link
true
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@wuzhuoquan: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
87686d0082a167334f2efe7d24a159beeb6fba87
link
true
/test lint

gencheck_istio
87686d0082a167334f2efe7d24a159beeb6fba87
link
true
/test gencheck

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@wuzhuoquan: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

gencheck_istio
87686d0082a167334f2efe7d24a159beeb6fba87
link
true
/test gencheck

lint_istio
e79b22ce2407bb7dea6f16a5d3da971ff1a1272c
link
true
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@wuzhuoquan: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
e79b22ce2407bb7dea6f16a5d3da971ff1a1272c
link
true
/test lint

gencheck_istio
e79b22ce2407bb7dea6f16a5d3da971ff1a1272c
link
true
/test gencheck

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@wuzhuoquan: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
e79b22ce2407bb7dea6f16a5d3da971ff1a1272c
link
true
/test lint

gencheck_istio
e79b22ce2407bb7dea6f16a5d3da971ff1a1272c
link
true
/test gencheck

unit-tests-arm64_istio
e81ca6ebfcf66096d62132f829703f12ba6b67ab
link
true
/test unit-tests-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@wuzhuoquan: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

gencheck_istio
e79b22ce2407bb7dea6f16a5d3da971ff1a1272c
link
true
/test gencheck

unit-tests-arm64_istio
e81ca6ebfcf66096d62132f829703f12ba6b67ab
link
true
/test unit-tests-arm64

lint_istio
e81ca6ebfcf66096d62132f829703f12ba6b67ab
link
true
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@wuzhuoquan: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
e81ca6ebfcf66096d62132f829703f12ba6b67ab
link
true
/test unit-tests-arm64

lint_istio
e81ca6ebfcf66096d62132f829703f12ba6b67ab
link
true
/test lint

gencheck_istio
e81ca6ebfcf66096d62132f829703f12ba6b67ab
link
true
/test gencheck

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test gencheck

@wuzhuoquan: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
e81ca6ebfcf66096d62132f829703f12ba6b67ab
link
true
/test unit-tests-arm64

lint_istio
e81ca6ebfcf66096d62132f829703f12ba6b67ab
link
true
/test lint

gencheck_istio
e81ca6ebfcf66096d62132f829703f12ba6b67ab
link
true
/test gencheck

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test unit-tests-arm64

GCI lint check failed

GCI lint check failed

sorry I am not sure how to satisfy the GCI check, can you give me some suggestion? Thank you.

You can run locally BUILD_WITH_CONTAINER=1 make lint and make sure it passes. And make gen as well.

Thanks for help, the GCI check is passed!

@hzxuzhonghu Hello, the pr I've push and mergerd to master, I would like to ask which official version will be released？Thx.

It will be released in 1.22

Sorry, just checked it was merged before, and it is released in 1.21

Sorry, just checked it was merged before, and it is released in 1.21

OK, thanks.


Added missing attribute dataset.

Ran into a problem that this is missing the dataset attribute. This fixes that. My last one for tonight I promise.

Honestly types are a weakness in the JSX. Improvements are always welcome. I will publish these all out to npm in the next couple days.

No probs. I just start using this against a bunch of projects with extensive JSX and so I started seeing issues, which I addressed. I'll keep the fork open in case a hit some more snags over the next few days. Otherwise right now it's looking pretty good.


Update simulation documentation

Result from the ASReview doc-a-thon:

add why you would want to run a simulation
shorter and more to the point explanation

Together with @Sasafrass

Thanks @qubixes for the helpful feedback! And sorry for my late response.


use .env files for sensitive information

hey there ✌
first of all thanks for that plugin... really makes some of my development much easier ❤
is it possible to refer to a local .env file in the pyproject.toml in order to prevent sensitive information (API keys, passwords, that kinda stuff) from ending up in git history?
rn i'm just tracking a pyproject.toml.example and ignore the actual one.

Hey @tweak-wtf this is now released with 1.2.0
See the doc here: https://github.com/nicoloboschi/poetry-dockerize-plugin?tab=readme-ov-file#configuration-via-environment-variables
Thanks for reporting!

great stuff! thanks for implementing this so quickly 🚀


OSX 10.9.5 and Qt 5.3.2 : could not resolve SDK path for 'macosx10.8'

To solve this issue: could not resolve SDK path for 'macosx10.8
It is necessary to add the bellow code in Bacon2D.pro and src/src.pro files
macx {
    QMAKE_MAC_SDK = macosx10.9
}

@ricardodovalle Where do you execute this:
qmake QMAKE_MAC_SDK=macosx10.9

?
I tried doing this in a terminal but I am getting:
MacBook-Pro$ qmake QMAKE_MAC_SDK=macosx10.10
Usage: qmake [mode] [options] [files]

QMake has two modes, one mode for generating project files based on
some heuristics, and the other for generating makefiles. Normally you
shouldn't need to specify a mode, as makefile generation is the default
mode for qmake, but you may use this to test qmake on an existing project

It does not seem to work.

Hi, you should add the directory of the pro file. If you have created a 'build' dir and is on it, you should run:
qmake QMAKE_MAC_SDK=macosx10.9 ..
Note the two dots on the end of the command.
Thank you ;)


Generate flamegraphs for other event types available in a JFR recording

With this PR one is now also able to generate flamegraphs for the following event types:

Allocations in a new TLAB (allocation-tlab)
Allocation outside TLAB (allocation-outside-tlab)
Exceptions (exceptions)
Java Monitor Blocked (monitor-blocked)

In allocation-related flamegraphs the width of the flames represent the total amount of memory allocated in bytes;
For exceptions, the width represents the number of times exceptions were created;
For monitor blocked, the width represents the number of times a Java thread was blocked due that monitor being in use.
The create_flamegraph.sh script has been modified to add the -e option, which allows to specify the event type. For example,
./create_flamegraph.sh -e allocation-tlab -d -f my_recording.jfr > allocation_flames.svg
Would create a flamegraph for allocations in a new TLAB.
When the use doesn't specify an event type, method profiling sample is used by default. So, for example:
./create_flamegraph.sh -f my_recording.jfr > flames.svg
Would generate a flamegraph based on method profiling sample, as today.

Hi @leogomes, This is really great and thanks a lot for this PR. I was actually planning to work on allocation flame graphs and I was so happy to this PR.

Awesome! Thanks for merging it :)

It seems that allocation options represents just size that was allocated in events (num of events * average size) instead of estimated allocation size as it is reported by JMC.
So it can be quite misleading when 2 threads (or pools) are used and they have different average size of allocations.

@plokhotnyuk Could you elaborate?
I just gave a try to allocation-tlab and am puzzled by its output. JMC reports 33GB of TLAB allocations, while the flamegraph only reports  20567136 samples (ie. sum of all EVENT_ALLOCATION_SIZE). Shouldn't sample count match "Total Memory Allocated for TLABs" in JMC ?

As far I understand JFR for TLAB allocation tracks only events when the allocation occurs in new TLAB, so probability (and count) of these events depends on size of allocated block.
Please see on screenshot bellow that Est. TLAB allocation is not just Count * Average TLAB Allocation:

Hello @cykl and @plokhotnyuk,
I think the best way to understand what the flamegraph is showing is to look at the Events tab. I will past here a screenshot of JMC 5.5. I'm still getting used to JMC 6 :)

For allocations in a new tlab, JFR records the size of the object that was the first allocation in a new TLAB and the size of that new TLAB. What you get is a sampling of TLAB allocations where you just recorded the first allocations. In my example above, I have a total of 86.27 GB allocated in new TLABs for my entire recording, but only ~180MB of samples, because only the first allocations were recorded. What I used in the flamegraphs was the size of that allocation. If the same stack trace appears again in another event, we aggregate the amount of memory allocated here. At the end, the width of a frame is the total amount of memory allocated by that path (considering that we only look at samples, so take that with a grain of salt).
Now for allocations outside tlab, JFR records every allocation and the # of sample you see at the bottom of your flamegraph should match what you see here in "Total memory allocated for Objects":

Hope that makes sense. I will ping Marcus Hirt on twitter to see if he wants to have a look at this post :)
I was also thinking about contributing a different flamegraph were we would look at the number of allocations for a given code path, rather than the amount of memory. I'm just not sure how useful that would be. I'm usually looking at allocations to try to reduce the amount of memory (at least for TLAB allocations) more than their frequency. Allocations in a TLAB should be pretty cheap, since it's basically a pointer bump.
Let me know what you think.

Thanks for the explanation! I reached a similar conclusion by reading http://hirt.se/blog/?p=381 and playing with both JMC 5.5 & 6.0.

What you get is a sampling of TLAB allocations where you just recorded the first allocations

My, probably wrong, understanding of hotspot/src/share/vm/memory/threadLocalAllocBuffer.cpp is that TLABs are dynamically sized per thread. TLAB size is computed from a refill target meaning that allocation heavy threads get larger TLABs. Wouldn't that mean that allocation from threads with small TLAB size are over-represented and allocation from threads with large TLAB are under-represented? If so, how would you use a such flamegraph ?

I think the article you cited kind of answers your question :)

Limitations

Since the Allocation in new TLAB events only represents a sample of the total thread local allocations, having only one event will say very little about the actual distribution. The more events, the more accurate the picture. Also, if the allocation behaviour vary wildly during the recording, it may be hard to establish a representative picture of the thread local allocations.

JFR is good because you only need a JDK to use it, but to have a better view of the allocations, you'd probably be better off using something like this: https://epickrram.blogspot.fr/2017/09/heap-allocation-flamegraphs.html

One possibility to work-around this limitation is to use -XX:-UseTLAB and completely disable TLABs while you're looking at allocations. Of course, it will have an important impact on your application performance, but it seems to allow JFR to record all allocations. In any case, if you decide to instrument code to record all allocations, it will have a big hit on performance.


Scala3 migration

This PR lays the groundwork for the Scala3 migration of the code base. Gradle's Scala3 plugin is merged but not released yet (see PR).
During the migration I encountered 2 different bugs in Scala3, they are filed here and here.
Types of changes done in this PR:

Shadowing variables or packages are now errors instead of Scala doing guess work. A fair amount of the changes done in this PR was disambiguation. These include:

Parameter shadowing
Shadowing among imports

Parenthesis-less methods called with parameters is not possible any more in Scala3
SockerServer extra classes were split into different files as Scala3 compiler was failing to find them when referenced in other classes in this same file.
foreach java collections method was not directly usable under Scala3, so I transformed it to the Scala collection's one (this might be another bug in Scala3, I need to investigate)
Scala3 fails to determine the right overload method when SAM is involved if types don't match exactly (a.k.a. bug https://github.com/lampepfl/dotty/issues/13549)
Scala3 companion object of a trait doesn't have the static forwarder methods, needed to reference the companion object "old style" (a.k.a. bug https://github.com/lampepfl/dotty/issues/13572)
Extra manual typing was needed occasionally as Scala3 is probably stricter than Scala 2.13

Compiling with Scala3
In order to test this locally one can run the following:
./gradlew wrapper --gradle-distribution-url=https://services.gradle.org/distributions-snapshots/gradle-7.3-20210906222431+0000-bin.zip
And then the usual
./gradlew compileTestScala -PscalaVersion=3.0
Notes
Jackson is using "2.13.0-rc2" version as it's the one that contains Scala3 improvements, it's not really needed to successfully compile though.
Extra information, Scala3 is compiling in "Migration Mode", meaning it outputs some warnings about deprecated and dropped features. See Migration Mode for further info.
All these warnings can be automatically fixed by the Scala compiler itself.
Current Problems
Spotbugs is currently detecting 30 problems with Scala3, it works fine when compiling with Scala 2.13. This currently blocks the execution of core and streams tests. By excluding spotbugs tests can be run and some tests are still failing, I need to find out why is this. Tests run successfully in Scala 2.13. To exclude spotbugs run the following:
./gradlew test -x spotbugsMain -PscalaVersion=3.0
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

Ping @ijuma I was able to have some progress with migrating to Scala3. I still need to check why some test failures occur only on Scala3. Let me know what you think about the changes.

One of tus failures was https://issues.apache.org/jira/browse/KAFKA-8785
I need to check the other one

Any plans to prioritize the Scala 3 migration? Would be nice to see this happening.

@jvican some intermediate work is here: https://github.com/apache/kafka/pull/11432
I'd need to resolve s couple if conflicts as the PR got no traction for a while. But I'm happy to do it!
What I think is that migration to Scala 3 might happen when Kafka 4.0.0 is closer in time.


Upgrade to hyper 1.0

I think we should probably wait until reqwest switches to hyper 1.0 first. We'll likely replace the client in the fetcher with reqwest, since hyper's client is being deprecated. No particular urgency on this, but wanted to create an issue to track it.

hey let's implement this


feat: visually improve recent transaction tabs

Describe the changes you have made in this PR
The current tabs lack design / it isn't directly clear that those are tabs.
Type of change

feat: New feature (non-breaking change which adds functionality)

Screenshots of the changes [optional]
Before

After

LOOK WHOS BACK!!!!

Great to see you again @dylancom! 🚀
I think the tabs currently look a bit strange when there are transactions. To me they feel visually separated from the transaction entries 🤔

I'd like to get @jakubszwedo's opinion on the tab styles as he is currently working on the design foundation.

@stackingsaunter Thanks for your mockups. I very much like the second one as this one makes it very clear which state your are currently in and that the transactions belong to the current tab.
@dylancom Can you change the styling to that? I think that would be a great improvement to what we have now.

Great to see you guys again 😄!
I agree that the change feels a bit separated from the entries and will change the styling to the second one somewhere this week.

Closing this in favor of the new tab styles implemented in #2322