Update docs

Codecov Report

Merging #368 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #368   +/-   ##
=======================================
  Coverage   98.06%   98.06%
=======================================
  Files           7        7
  Lines         259      259
  Branches       42       42
=======================================
  Hits          254      254
  Misses          2        2
  Partials        3        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58dc958...6e48e48. Read the comment docs.


Set Font for react-native sunmi

Hello, how can i set font Roboto for the text in react native sunmi. Thank you very much

@thuanphat2009 void setFontName(String typeface, ICallback callback)


Suggestion: adding support for Alpine?

Hi @Nyr !
Do you think you would be able to add support for Alpine Linux? That would be awesome. I know that it would require a rather impressive overhaul in such a case. Maybe it would be more suitable as a separate project.
At any rate, it was just something I had on my mind and I had to write to you about it.
Have a great day!

Maybe it would be more suitable as a separate project.

Indeed that's the case. Specially since the differences between Alpine and the currently supported distros are huge.
This isn't something that I plan on doing/supporting, but anyone willing to do so is more than welcome to fork.


Overriding Area class

I'm unable to override core class Area in the following fashion:
application/config/app.php
return array(
    'aliases' => array(
        'Area' => '\Concrete\Package\MyPackage\Src\Concrete\Area\Area'
    )
);

This is because the function Area::get(....) uses self instead of static, as seen here: https://github.com/concrete5/concrete5/blob/develop/concrete/src/Area/Area.php#L466
if ($arRow['arParentID']) {
    $arParentHandle = self::getAreaHandleFromID($arRow['arParentID']);
    $obj = new SubArea($arHandle, $arParentHandle, $arRow['arParentID']);
} else {
    $obj = new self($arHandle);
}

This leads to problems where functions specify the exact type of the arguments. When they mention Area, they will use the new alias. For example public function setAreaObject(Area $area) at  https://github.com/concrete5/concrete5/blob/develop/concrete/src/Block/View/BlockView.php#L63
Can those references be changed to static, or is there another way to override these core classes?

It's not really recommended to override classes in this fashion. Why do you need to override the class this way? If you want a custom area class in your project, why not just create that class and use it in your custom theme templates?


Implement global functions

We should allow the user to maintain ~/.pysh/ directory that has functions that the user would like to reuse. This allows for cleaner code in the end. Within pysh, we should import all files in that directory.

This is a lower-priority feature compared to #12. I'm not entirely sure this is even a good idea, especially with portability in mind. Closing for now.


[v1.4] Select command tests

commits after 7af6c7b are what's new on this PR

add tests for SelectCommand (both unit test and system test)
implemented Deselect feature for data removal commands (i.e. checkout, clear, undo, redo)

Pull Request Test Coverage Report for Build 441

43 of 52 (82.69%)  changed or added relevant lines in 11 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.4%) to 90.826%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/main/java/seedu/address/commons/events/ui/DeselectRoomListEvent.java
0
2
0.0%

src/main/java/seedu/address/ui/MainWindow.java
2
4
50.0%

src/main/java/seedu/address/ui/RoomDetailedPanel.java
0
2
0.0%

src/main/java/seedu/address/ui/UiManager.java
3
6
50.0%

Totals

Change from base Build 436:
0.4%

Covered Lines:
2782

Relevant Lines:
3063

💛  - Coveralls

ready for review


Support IoT Hub routing of OPC UA PubSub JSON messages

This only entails setting the content type to application/json to allow IoT Hub to interpret the message correctly.

Done.


Converter integrations next wired in to the UI and backend

This exposes a new feature added in v0.39.0 of the agent for integrations-next. This works slightly different on the backend since it is a secondary static conversion type.
The backend code to leverage the feature mirrors the unit tests for it here
The feature is further documented here

Thanks for the contribution. I've tested it locally and will merge/deploy this now


Feat: Setup CI and test structure

Closes #13 @aquelemiguel
You can keep adding more versions to the test matrix if you want to, or remove old ones, or just keep the latest.
I wrote one sample test to define the structure.

LGTM!

LGTM, thank you! 🚀


Source is using JDK7 items, when target is 1.6 [JIRA: CLIENTS-521]

Currently in the pom, the maven-compiler-plugin says the source and target are 1.6, however Eclipse complains about two usages of JDK7 code in the codebase:

https://github.com/basho/riak-java-client/blob/develop/src/main/java/com/basho/riak/client/api/RiakClient.java#L265 - getHostString() is not visible
https://github.com/basho/riak-java-client/blob/develop/src/test/java/com/basho/riak/client/core/fixture/NetworkTestFixture.java#L20 - java.net.StandardSocketOptions was introduced in JDK7

I guess we could fix this by either increasing the minimum version to 1.7 or find JDK6 equivalents.

Hey @jplock, not sure how this slipped past - we have the animal sniffer plugin enabled but something's not obviously working.

Ok, this was fixed on the develop branch, and should be out with the next release (today or next week).


obs-studio: add audio support

Adds support for the pulseaudio and jack plugins in obs-studio

I think I might need to propagate the pulseaudioSupport parameter here,  for some reason I thought it was available in the upper scope

added

thanks, was testing this out last night on twitch, works great :+1:


Disable plugin in diff mode

Currently, the plugin remains active even in diff mode. So, it hijacks the signs column and the keymappings too. I'm not able to use [c & ]c, to move between the changes.
My request is to disable the signs and unmap the keymappings when in diff mode. You can use the &diff variable to check if diff mode is active or not.

Could you provide some specific context on the exact way you're using diff mode? Commands, mappings, plugins?
I use it with fugitive so the signs align with the diff changes so [c works well for me. Also what signs in diff mode are being hijacked? Gitsigns sets a low priority for signs (which can be configured) so should be able to work ok with other signs.
Currently the mappings are applied globally but maybe we can make them buffer specific depending if the buffer has signs. Then in diff mode we can make gitsigns detach from the buffer?

Currently, if I do ]c in diff mode, I get the error E5108: Error executing Lua .... gitsigns.lua:559: attempt to index a nil value.

Currently the mappings are applied globally but maybe we can make them buffer specific depending if the buffer has signs. Then in diff mode we can make gitsigns detach from the buffer?

Yes, I think this could be a possible workaround, hopefully I'm correct
P.S: Super awesome plugin, much faster than gitgutter ever was

Hope that fixes it. Let me know otherwise.


Proposed new API for serializing custom types

We've been considering a new API for serializing custom types and would like to solicit community input on our proposal.  The original motivation for this was a desire to support multiple URI schemes in the same serializer.  For example, as we move the transform schemas out of the ASDF standard and into their own package, we would like to change the current tag URIs:
tag:stsci.edu:asdf/transform/add-1.2.0
tag:stsci.edu:asdf/transform/affine-1.3.0
...

to something like this:
http://asdf-format.org/schemas/transform/add-2.0.0
http://asdf-format.org/schemas/transform/affine-2.0.0
...

The current API, ExtensionType, assumes the tag: URI scheme and forces each tag to share the same "organization", "standard", and "name".  We thought we'd simplify by replacing those individual class attributes with a single list of full tags.  Here's the proposed new API, called AsdfConverter:
https://github.com/asdf-format/asdf/blob/asdf-standard-2.0.0-epic/asdf/converter.py#L28
I would like to point out several changes and consequences of this new design:

The name, organization, standard, version, supported_versions, and yaml_tag class attributes have all been collapsed into one attribute, tags, which in the case of the "add" transform schema we'd set like this:

tags = {
  "tag:stsci.edu:asdf/transform/add-1.0.0",
  "tag:stsci.edu:asdf/transform/add-1.1.0",
  "tag:stsci.edu:asdf/transform/add-1.2.0",
  "http://asdf-format.org/schemas/transform/add-2.0.0",
}

This gives developers the flexibility to use any URI scheme they choose, and allows for diverse tags to be handled by the same class.

Drop support for tags that aren't explicitly listed in the class attribute.  The ExtensionType behavior is to use the serializer with the closest higher version if an exact match is unavailable.  Instead, the library would refuse to handle the object if explicit support for the tag is unavailable, since to do otherwise is to risk losing data when the file is written back out.

Drop the handle_dynamic_subclasses attribute and its associated feature.  This is an experimental feature that writes a Python class name into the YAML so that the correct subclass can be automatically chosen when reconstructing the object on read.  This is by definition implementation specific and we would prefer to encourage use of separate tags for these cases.

The ExtensionType classes are capable of operating on themselves, that is to say, serializing and deserializing instances of the same class that defines the from_tree and to_tree behavior.  In order to handle multiple tag versions, the ExtensionType metaclass would dynamically generate additional class definitions for each version.  All this made for a system that was difficult to understand and troubleshoot, so with AsdfConverter we're not permitting self-serialization and are creating instances of the class to handle each tag.

Rename from_tree and to_tree to from_yaml_tree and to_yaml_tree.  The renaming is to help remind us what each method is intended to do, since in both cases the input and output are both trees.

Drop the from_tree_tagged and to_tree_tagged methods.  These existed to allow developers to provide custom logic for choosing a tag.  Now, to_tree_yaml is permitted to return a tagged object directly.

Drop the ctx variable from the from_yaml_tree and to_yaml_tree methods.  In most cases, use of the ctx is not necessary -- only converters that deal directly with binary blocks need access to it.  We're planning to introduce an additional interface for that type of converter.

Drop the requires class attribute.  Most implementations will reside in a package that lists required dependencies in the package metadata.  Those that don't are well served by raising ImportError from within the from_yaml_tree method.

The validators class attribute is not yet implemented for AsdfConverter, but I suspect we'll need it.  That feature is used internally to support custom validations on the shape and datatype of the ndarray objects.

@Cadair @CagtayFabry I know you've both implemented support for custom types using the old API -- we'd appreciate hearing any thoughts you have on the new one.

So far we are more or less still prototyping with asdf so changes to the tag URI format are not really an issue up to this point. I like the idea of having more flexibility with handling different tags outside of the current "organization", "standard", and "name" structure.
Some thoughts regarding the proposed changes off the top of my head:

I like the idea of moving the to_tree_tagged functionality into the new to_yaml_tree method
Using and implementing custom validators is a very powerfull feature of asdf in my eyes so I would really like the functionality to carry over to the new API. Are you considering dropping the feature or simply moving it away from ExtensionType / AsdfConverter ? Not having the validator feature would actually break some of our implementation ideas.

I will have a closer look at the other changes as well.

Using and implementing custom validators is a very powerfull feature of asdf in my eyes so I would really like the functionality to carry over to the new API. Are you considering dropping the feature or simply moving it away from ExtensionType / AsdfConverter ? Not having the validator feature would actually break some of our implementation ideas.

We definitely want keep the feature, dropping it from AsdfConverter was an oversight on my part.  One thing that puzzles me though -- the custom validators are applied globally to all tagged objects, so why are they defined as an attribute of ExtensionType?  Wouldn't it make more sense to define them on AsdfExtension directly?
On the other hand, maybe it doesn't make sense to apply the custom validators to every object.  It's possible that two extension developers will provide custom validators for the same property name with conflicting behavior.  If we scoped the custom validator to only the AsdfConverter classes that it was assigned to, then we'd prevent any such conflicts.

I was about to ask the same question. I noticed that validators get registered globally regardless of which class I assign them to. So defining them on AsdfExtension would be a more natural fit imo.
Regarding different validators per class I also thought about that and it does sound interesting. I am not sure about the current behavior but I doubt this is working with the current implementation.
I must say I really like the current "global" behaviour since I don't have to worry about adding all my validators to all classes individually. Defining them together with the AsdfExtension would feel even more intuitive for me. (also easier to look for)
I guess the most flexible option could look somewhat like the following (no idea if this is possible to implement):

validators defined on AsdfExtension trigger on all schemas
validators only defined on AsdfConverter will trigger only on the specific classes
validators defined on AsdfConverter will override globally defined validators in AsdfExtension for their classes

One more question regarding the following note @eslavich

Drop the ctx variable from the from_yaml_tree and to_yaml_tree methods. In most cases, use of the ctx is not necessary -- only converters that deal directly with binary blocks need access to it. We're planning to introduce an additional interface for that type of converter.

What functionality would the additional interface provide?
One current use case for ctx in to_tree is to switch ctx.set_array_storage(data, "inline") depending on some related class properties. Would that still be possible from within to_yaml_tree?
Also, when dropping ctx would there still be any way to access the type mapping of the AsdfFile (including extensions?)
Those might be of interest if the tag _tag property should be set manually

What functionality would the additional interface provide?

I haven't given this a lot of thought yet, but I find the current interface unsatisfying.  There are potentially multiple ndarray objects that map to the same block, yet the set_array_storage method operates on an ndarray.  And how does the user control storage for other types of block-backed objects?  I also find the lack of symmetry in serialization/deserialization troubling -- after writing an numpy.ndarray to the tree, you get back asdf.tags.core.ndarray.NDArrayType, which is a proxy wrapper around the ndarray that fails the isinstance(obj, numpy.ndarray) test.
So I'm vaguely hoping that we can devise a new interface that generalizes to other objects with blocks and returns an object of the correct type when the tree is read back in.

One current use case for ctx in to_tree is to switch ctx.set_array_storage(data, "inline") depending on some related class properties. Would that still be possible from within to_yaml_tree?

We definitely want to support that feature.  At the very least it'll be possible using the advanced/extended interface (call it AsdfExtendedConverter for the sake of discussion).

Also, when dropping ctx would there still be any way to access the type mapping of the AsdfFile (including extensions?)
Those might be of interest if the tag _tag property should be set manually

I think I see the issue -- we might know that we want to manually set the tag to http://asdf-format.org/foo-x.y.z, but we don't know how to choose the correct version x.y.z without information from the type mapping.  Do I understand correctly?
Removing ctx may not be worth the trouble.  I thought it'd be useful to be able to easily distinguish straightforward converters from those that may be engaged in funny business like manipulating the block index.

I think I see the issue -- we might know that we want to manually set the tag to http://asdf-format.org/foo-x.y.z, but we don't know how to choose the correct version x.y.z without information from the type mapping. Do I understand correctly?

yes, deciding on the correct version number was pretty much the same problematic use case I was thinking of as well
Thank you for your explanations

I think I have a good solution for the ctx variable: allow to_yaml_tree and from_yaml_tree implementations to accept either 1 or 2 arguments.  I'm also planning to add back in the validators property.
I'll link back to this issue when I open a PR.

Just to have this here:
I think some way to integrate the ideas behind https://github.com/asdf-format/asdf-standard/issues/271 / https://github.com/asdf-format/asdf/pull/858 into the tags attribute somewhere in the future would be really nice

I think some way to integrate the ideas behind asdf-format/asdf-standard#271 / #858 into the tags attribute somewhere down the line could be really nice

That feature would help us a lot, I think.  We did a test drive of the proposed API and one class in particular ended up with a long clumsy list of tags:
https://github.com/astropy/asdf-astropy/blob/master/asdf_astropy/tags/transform/compound.py#L38
That list would be lot nicer with wildcards:
tags = {
    "asdf://asdf-format.org/extensions/transform/tags/add-*",
    "asdf://asdf-format.org/extensions/transform/tags/subtract-*",
    "asdf://asdf-format.org/extensions/transform/tags/multiply-*",
    "asdf://asdf-format.org/extensions/transform/tags/divide-*",
    "asdf://asdf-format.org/extensions/transform/tags/power-*",
    "asdf://asdf-format.org/extensions/transform/tags/compose-*",
    "asdf://asdf-format.org/extensions/transform/tags/concatenate-*",
    "asdf://asdf-format.org/extensions/transform/tags/fix_inputs-*",

    "tag:stsci.edu:asdf/transform/add-*",
    "tag:stsci.edu:asdf/transform/subtract-*",
    "tag:stsci.edu:asdf/transform/multiply-*",
    "tag:stsci.edu:asdf/transform/divide-*",
    "tag:stsci.edu:asdf/transform/power-*",
    "tag:stsci.edu:asdf/transform/compose-*",
    "tag:stsci.edu:asdf/transform/concatenate-*",
    "tag:stsci.edu:asdf/transform/fix_inputs-*",
}

Here's another iteration on the converter API:
https://github.com/asdf-format/asdf/blob/752d96e813c218536238fa20368be14abd4272c5/asdf/extension/_converter.py#L11
I ended up bringing back the ctx argument, but assigning it an instance of a new class called SerializationContext instead of the AsdfFile itself.  The block manager isn't available yet (so it's not yet possible to call set_array_storage, but it will be eventually).  I'm trying to avoid passing around the AsdfFile because AsdfFile.write_to operations aren't supposed to modify the file, so I don't want code in the new converters to be able to manipulate it directly.
Tag patterns are permitted in the converter tags property.
I've been thinking more about the validators and my latest idea is to define them on the extension itself, but optionally allow a list of tag URI patterns in case developers want to restrict their use to certain tags.  The interface might look something like this:
class Validator:
  @property
  def name(self):
    # Return the name of the schema property that triggers the validation.

  @property
  def tags(self):
    # Optional list of tag URIs or URI patterns that the validator should
    # be used with.

  def validate(self, schema_value, instance, tag, ctx):
    # schema_value: the value assigned to the schema property
    # instance: the YAML object to be validated
    # tag: the YAML object's tag
    # ctx: the same SerializationContext object as passed to the converters
    #
    # Implementation is expected to raise asdf.exceptions.ValidationError
    # if the instance fails validation.

My goal is to abstract away the jsonschema library so that we can swap in a faster implementation someday.  Validation is currently the slowest part of opening an ASDF file.


Show rooms in the directory

The kids would love it if we added their rooms to the directory as well as creating them. We should use setRoomDirectoryVisibilityAppService so it does that.

Fixed by #175


version in doc/conf.py for documentation

this one still seems to be set by hand?

Thanks, I'll update it.

fixed


Putting the whole bot permanently online again

Title says everything.
Its a TODO

Bot is now on a server, but not ready to be published since there are some issues to be fixed.


Added ON-OFF button support

This PR adds in support for momentary push button based ON-OFF functionality using the ESP's deep sleep feature.
The code was tested on an ESP8266 (specifically a D1 mini) and an ESP32-C3 (supermini esp32c3). For the latter, attaching a push button between GND and any of the RTC GPIOs (GPIO0-5), the code should work, but for the ESP8266, the following hardware needs to be added:

GPIO13 can be set to any of the safe pins (4, 5, 12, 13, 14), however the other ones are already used by the default SlimeVR setup. I have tried to make the setup work with a MOSFET instead of a transistor, but didn't manage to yet.
The on-off behaviour can be activated by defining ON_OFF_BUTTON inside defines.h. For example:
#define ON_OFF_BUTTON D7

for a D1 mini.
When the tracker is on, holding down the button for 1 second puts it to deep sleep (this is debounced). When it's in deep sleep, pressing the button once will wake it up, resetting it. The hold down time can be changed by defining ON_OFF_BUTTON_HOLD_TIME_MS in defines.h.
The tracker attempts to deinitialize the imus attached to it.
While it varies, this setup should drop the power consumption to somewhere around 100-200uA.
Things that need checking:

Is it possible to make the necessary circuitry for the ESP8266 out of a MOSFET
Are the 8266 quirks solvable
Are the deinitialization routines for the IMUs correct

It's also theoretically possible to add in a hold time for turning on the tracker for the ESP32 variant, but since this isn't at all possible for the ESP8266, I didn't implement it.

Tested on custom esp32-c3 board, works as expected

Can I get some eyes on this?

Brought this code up to date with the sfusion merging, now theoretically all IMUs supported by sfusion should also be supported by this PR.

@Vyolex Currently there is a weird drifting issue that happens with this branch, and I want to rewrite some of the logic a bit, to make it non-blocking, so I wouldn't bother yet.


Add content from cliday 2022-03-18

Zsh plugins, forgit, and yq. Plus a tip on Zsh run-help.

Wonder if we should split up CLI tools by type of function/utility at some point.

Indeed, I'll be adding 3/week so eventually it'll need to be.


MoarVM panic: Internal error: zeroed target thread ID in work pass

I'm intermittently seeing this occur in Bailador:
MoarVM panic: Internal error: zeroed target thread ID in work pass
The result is the server comes to a complete halt - ouch!
Here is the current Perl 6 version I'm using:
This is Rakudo version 2016.12-95-ga6c37a7 built on MoarVM version 2016.12-6-g65acd55
implementing Perl 6.c.

I am afraid I can't help since this is something inside the MoarVM

closed because it seems to be a perl6 internal issue


[Bug] Icon disappearing on sidebar

This happens every so often, not sure why.
Rebooting usually fixes it.
Sometimes going into the settings and selecting a new sidebar icon fixes it:

But even some of those don't show up properly:

Hey, thanks for your detailed report, this is a duplicate of #32, I’ve made a fix for this, waiting for the RL guys to approve it but it could take a few weeks :)
https://github.com/runelite/plugin-hub/pull/4029


Sane curated default environment, jupyterlab extensions, and theme for QHub

Files to change.

qhub_ops/template/{{ cookiecutter.project_name }}/image/jupyterlab/*

[ ] Add a README.md to directory with design goals and why etc.

Steps: rinse and repeat

cd into the qhub_ops/template/{{ cookiecutter.project_name }}/image/jupyterlab/ directory
build: docker build -f Dockerfile.jupyterlab . -t qhub-jupyterlab:lastest
docker run -p 8000:8000 -it qhub-jupyterlab:latest jupyter lab --ip <IP_ADDRESS> --port 8000

Other method once you have an image you like we can try it out on the running jupyterhub/qhub cluster at https://jupyter.do.qhub.dev/

commit the changes to qhub_ops/template/{{ cookiecutter.project_name }}/image/jupyterlab/
wait for ci/github actions to finish building the docker images (~10 minutes)
take the tag of the docker images built or use the git commit sha (they are the same) from step 4
use the tag to update https://github.com/Quansight/qhub-ops/blob/master/qhub_ops/template/{{ cookiecutter.project_name }}/infrastructure/variables.tf#L61-L85 tags
commit those changes to the three tags and wait 10 minutes for it to be deployed on https://jupyter.do.qhub.dev

Need to add a section for jupyterlab extensions in qhub-ops-config.yaml

Will have users create an issue if they need additional default extensions. Current default extensions seem sufficient


Refactor SitesData

This PR refactors how parts are being calculated on SitesData. This avoid the use of custom code for the parts, and makes use of existing methods on SitesData where possible.
Closes #34
Todo

[x] Can this just be based off atom_sites? (avoid calculating split_transitions) -> it can't
[x] Methods directly set attributes -> not for now

I think this is good to go, do you have any feedback @v1kko ?


Doesn't work even though installed + setup + autotag enabled

Sorry to bother with a niche problem but I could never get this plugin working after hours of researching.
I'm using lazy.nvim + nvim 0.9.5 and AFAIK to enable this plugin I'll have to:

Enable autotag in treesitter

local options = {
  ensure_installed = { "lua", "vim", "vimdoc" },

  highlight = {
    enable = true,
    use_languagetree = true,
  },

  autotag = {
    enable = true,
  },

  indent = { enable = true },
}
return options

Install through lazy.nvim and setup

  {
    "windwp/nvim-ts-autotag",
    lazy = false,
    dependencies = "nvim-treesitter/nvim-treesitter",
    config = function()
      require 'nvim-ts-autotag'.setup()
    end,
  },

Am I missing anything? You can see my config file here
I'm mainly working on .jsx files but html files don't work as well.

Alright, this has become enough of a problem that I need to add documentation around this 😅.
So for your case, try adding html and other languages you want autotag support in to your ensure_installed section for nvim-treesitter.
Alternatively, you can set auto_install = true for nvim-treesitter which will install the parsers as needed. Autotag won't/can't work without the associated treesitter parser installed for a given language.
See https://github.com/windwp/nvim-ts-autotag/issues/64#issuecomment-2119580720 for a response to a previous issue of this sort.
I'll keep this issue open and create a PR to update documentation and close it from there.

omg that response was quick :100:
Setting auto_install = true shows this error:
Nvim Treesitter Setup is deprecated, use `require('nvim-ts-autotag').setup()` instead.
This feature will be removed in nvim-ts-autotag version 1.0.0

but setting ensure_installed works. Thanks!

Setting auto_install = true shows this error:

Remove these lines from your config.
We no longer use nvim-treesitter modules.
Use the plain require("nvim-ts-autotag").setup method.

That was it!!! :tada: :tada:


[SPARK-33733][SQL] PullOutNondeterministic should check and collect deterministic field

What changes were proposed in this pull request?

The deterministic field is wider than NonDerterministic, we should keep same range between pull out and check analysis.
Why are the changes needed?

For example
select * from values(1), (4) as t(c1) order by java_method('java.lang.Math', 'abs', c1)

We will get exception since java_method deterministic field is false but not a NonDeterministic
Exception in thread "main" org.apache.spark.sql.AnalysisException: nondeterministic expressions are only allowed in
Project, Filter, Aggregate or Window, found:
 java_method('java.lang.Math', 'abs', t.`c1`) ASC NULLS FIRST
in operator Sort [java_method(java.lang.Math, abs, c1#1) ASC NULLS FIRST], true
               ;;

Does this PR introduce any user-facing change?

Yes.
How was this patch tested?

Add test.

Test build #132553 has started for PR 30703 at commit 33eda3c.

Test build #132553 has finished for PR 30703 at commit 33eda3c.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37157/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37157/

retest this please

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/132553/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/37157/

Test build #132557 has started for PR 30703 at commit 33eda3c.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37161/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37161/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/37161/

Test build #132557 has finished for PR 30703 at commit 33eda3c.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/132557/

Test build #132566 has started for PR 30703 at commit d1ebbab.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37170/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37170/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/37170/

Test build #132566 has finished for PR 30703 at commit d1ebbab.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/132566/

retest this please

Test build #132607 has started for PR 30703 at commit d1ebbab.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37211/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37211/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/37211/

Test build #132607 has finished for PR 30703 at commit d1ebbab.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

cc @cloud-fan

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/132607/

Test build #132648 has started for PR 30703 at commit 9ec0654.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37251/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37251/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/37251/

Test build #132648 has finished for PR 30703 at commit 9ec0654.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/132648/

cc @cloud-fan @maropu  thanks for review !

thanks, merging to master/3.1/3.0!

@ulysses-you can you open backport PRs for 3.0/2.4? thanks!

@cloud-fan will do it.

late lgtm. thanks for fixing it, @ulysses-you


[FEATURE] Support passing secrets as target/source configuration to providers

Affected project(s)

[ ] documentation
[ ] examples
[X] wasmCloud host
[ ] wasmCloud CLI (wash)
[ ] wasmCloud dashboard UI (washboard)
[X] capability providers
[ ] provider bindgen
[ ] control interface client
[ ] other / not sure

Is your feature request related to a problem? Please describe.
This is a followup to #2344 centered around full secrets support for links, specifically delivering them to capability providers at runtime and ensuring we can fetch secrets on behalf of providers when they are established.
Describe the solution you'd like
I would like to be able to deliver encrypted secrets to capability providers over NATS when new links are created after the provider starts.
Describe alternatives you've considered
No response
Additional context
Note I've started on this

The strawman design for this feature primarily centers around passing a generated XKey to a provider at startup, and then using that xkey to seal link secrets as we send it to the provider. For backwards compatibility, I suggest we only encrypt the source/target secrets fields instead of the entire link so that providers don't have to support the new xkey field to work. If we do this we can deliver these new links to the link put topic without any breaking changes.
Outstanding questions

The link put topic is currently subscribed to by all instances of the provider, no matter what host they are running on. Because of this, unless hosts accept an encryption xkey at startup, all instances of a provider need to have the same xkey or they won't be able to encrypt secrets. How can we get around this?

Related, we have discussed encrypting wRPC payloads, and while we don't fully have a design laid out here we could use this as the basis for encrypting payloads between hosts/providers/components.

Alternatives

Instead of using encrypted NATS payloads, we could use named pipes / stdin-stdout to deliver payloads to providers. This is a pretty significant breaking change, albeit maybe not too complicated, so it feels like a lot to take on.
Don't support secrets on links


Party-themed extension

Is your feature request related to a problem? Please describe.
Teachers using web browser for teaching can get boring at times and the students may get distracted, Can also be used by employees etc.Also some people use web browsers during special occasions such as birthdays and maybe in a call or livestream so these can be used to enchance and make things a little more fun and lively
Describe the solution you'd like
a party themed extension can be which can contain a countdown timer for birthdays or anything ,or animations and sparkles,popups can be used to make a current webpage fun and lively .

Also is their a time limit for this since im a newbie so i will need little time

Closing this as no PR received


Fix cargo template

The template is currently broken due to recent changes. Cargo CI still fails due to esp-idf-hal: https://github.com/SergioGasquez/esp-idf-template/actions/runs/4959728233/jobs/8874244444

Thanks! Can you apply the same changes to the main.rs file in the cmake dir?

BTW esp-idf-hal CI passes fine now, on 4.4, 5.0 and master. Any ideas why it fails here?

BTW esp-idf-hal CI passes fine now, on 4.4, 5.0 and master. Any ideas why it fails here?

Missmatched types:
error[E0308]: mismatched types
    --> /home/runner/.cargo/git/checkouts/esp-idf-hal-923d08f725716f5e/c7dba31/src/task.rs:703:41
     |
703  |                 Arc::new(AtomicPtr::new(task::current().unwrap())),
     |                          -------------- ^^^^^^^^^^^^^^^^^^^^^^^^ expected `*mut tskTaskControlBlock`, found `*mut c_void`
     |                          |
     |                          arguments to this function are incorrect
     |
     = note: expected raw pointer `*mut tskTaskControlBlock`
                found raw pointer `*mut c_void`
note: associated function defined here
    --> /home/runner/.rustup/toolchains/esp/lib/rustlib/src/rust/library/core/src/sync/atomic.rs:1060:18
     |
1060 |     pub const fn new(p: *mut T) -> AtomicPtr<T> {
     |                  ^^^

error[E0308]: mismatched types
   --> /home/runner/.cargo/git/checkouts/esp-idf-hal-923d08f725716f5e/c7dba31/src/task.rs:753:38
    |
753 |                         task::notify(freertos_task, 1);
    |                         ------------ ^^^^^^^^^^^^^ expected `*mut c_void`, found `*mut tskTaskControlBlock`
    |                         |
    |                         arguments to this function are incorrect
    |
    = note: expected raw pointer `*mut c_void`
               found raw pointer `*mut tskTaskControlBlock`
note: function defined here
   --> /home/runner/.cargo/git/checkouts/esp-idf-hal-923d08f725716f5e/c7dba31/src/task.rs:92:15
    |
92  | pub unsafe fn notify(task: TaskHandle_t, notification: u32) -> bool {
    |               ^^^^^^ ------------------

For more information about this error, try `rustc --explain E0308`.
error: could not compile `esp-idf-hal` due to 2 previous errors
warning: build failed, waiting for other jobs to finish...

Thanks! Can you apply the same changes to the main.rs file in the cmake dir?

Done!


ROX-16212: Fix cert rotation broken on some installations

Description
Cert rotation seems to be breaking if cluster image tag is a SHA reference.
This PR aims to "stop the bleeding" and bring Cert Rotation back to a healthy state. The underlying issue will eventually be fixed by decoupling the secret rendering from full sensor bundle rendering or by implementing support for SHAs in manifest installations.
See comments and commit messages for more context.
Checklist

[x] Investigated and inspected CI test results
[x] Unit test and regression tests added
[ ] Evaluated and added CHANGELOG entry if required
[ ] Determined and documented upgrade steps
[ ] Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)

If any of these don't apply, please comment below.
Testing Performed

[x] (Unit) Regression test added
[x] CI
[x] Manual test on cluster

Cluster "remote" has digest reference:

Generating manifest bundles still fails with error:

message: unable to get required cluster information: pre-rendering sensor chart: instantiating sensor chart template: instantiating file internal/defaults/50-images.yaml: instantiating template file internal/defaults/50-images.yaml: template: internal/defaults/50-images.yaml:73:12: executing "internal/defaults/50-images.yaml" at <required "" .ImageTag>: error calling required: required value was not specified

Generating TLS certs from roxctl successfully generates yaml files:
$ roxctl --insecure-skip-tls-verify -e localhost:8000 sensor generate-certs "remote"
INFO:	Successfully downloaded new certs. Use kubectl apply -f cluster-remote-tls.yaml to apply them.

Looks like CI failed cause Central took too long to start:
Waiting for deployment "central" rollout to finish: 0 of 1 updated replicas are available...
error: timed out waiting for the condition

However, looking at Central logs it doesn't seem like anything unusual happened.

/retest

@msugakov updated PR description with test results.

Thanks for the update Fred!
Question (I know it's annoying if you haven't tried that): did roxctl --insecure-skip-tls-verify -e localhost:8000 sensor generate-certs "remote" fail on similar install before the change?
If it did not fail, we'll not be able to confidently tell that the actual problem was fixed.
Also, looking at the PR checklist, I feel this deserves a mention in the changelog as fixed bug. Do you mind adding one?

@msugakov No worries!

Question (I know it's annoying if you haven't tried that, but have to ask): did roxctl --insecure-skip-tls-verify -e localhost:8000 sensor generate-certs "remote" fail on similar install before the change?

Yes! Here's the example on stagingdb:
$ roxctl --insecure-skip-tls-verify -e stagingdb.demo.stackrox.com:443 sensor generate-certs "misha-test"
ERROR:	error downloading regenerated certs: expected status code 200, but received 500. Response Body: {"code":13,"message":"pre-rendering sensor chart: instantiating sensor chart template: instantiating file internal/defaults/50-images.yaml: instantiating template file internal/defaults/50-images.yaml: template: internal/defaults/50-images.yaml:73:12: executing \"internal/defaults/50-images.yaml\" at \u003crequired \"\" .ImageTag\u003e: error calling required: required value was not specified"}

Also, looking at the PR checklist, I feel this deserves a mention in the changelog as fixed bug. Do you mind adding one?

I thought so too -- but then I read this line on the changelog file:
Entries in this file should be limited to:
-  Any changes that introduce a deprecation in functionality, OR
-  Obscure side-effects that are not obviously apparent based on the JIRA associated with the changes.
Please avoid adding duplicate information across this changelog and JIRA/doc input pages.

So maybe it doesn't fit?

You're right about CHANGELOG.md. There are no entries for bugfixes.
Yet, I thought there are because I saw a section about fixed bugs in the resulting release notes: https://docs.openshift.com/acs/4.0/release_notes/40-release-notes.html#bug-fixes-rn40.
Perhaps the docs team compiles it from the resolved JIRA issues, not from the CHANGELOG.md.
I suggest we put doc-RN-needed on ROX-16212 so that someone from docs team reaches out and adds an entry about the fixed bug.
Otherwise, to me it looks ready


TechDebt: System User Enhancements/Fixes

Links to Jira Tickets
n/a
Description of Changes
Copy existing database functions to procedures folder, where they can be migrated and maintained more easily.
Update api_patch_system_user.ts to do case-insensitive comparisons when finding a system user.
Testing Notes
System user related QA.
Other
Ran this query in Prod to see if there are any duplicates.
WITH w_duplicates AS (
  SELECT
    array_remove(
      array_agg(
        DISTINCT(system_user.system_user_id)
      ),
      NULL
    ) AS system_user_ids,
    LOWER(user_identifier) AS user_identifier,
    user_identity_source_id,
    COUNT(
      LOWER(user_identifier)
    ) AS count
  FROM
    system_user
  WHERE
    record_end_date IS NULL
  GROUP BY
    LOWER(user_identifier),
    user_identity_source_id
  HAVING
    COUNT(
      LOWER(user_identifier)
    ) > 1
)
SELECT
  w_duplicates.*,
  array_remove(
    array_agg(
      DISTINCT(project.project_id)
    ),
    NULL
  ) AS project_ids
FROM
  w_duplicates
  JOIN project_participation ON project_participation.system_user_id = ANY(w_duplicates.system_user_ids)
  JOIN project ON project.project_id = project_participation.project_id
GROUP BY
  w_duplicates.system_user_ids,
  w_duplicates.user_identifier,
  w_duplicates.user_identity_source_id,
  w_duplicates.count;

system_user_ids
user_identifier
user_identity_source_id
count
project_ids

{92,111}
rstaplet
2
2
{43,46,49,50,55,56,58,67,79,80,89,90,99}

{93,108}
eroorda
2
2
{39,46,49,50,55,56,58,80,87,89,99,100,101}

{95,110}
gemery
2
2
{95,96}

{96,107,109,113,114}
jbudzins
2
5
{40,41,47,87}

That jbudzins one was created today, so there might be more appearing if they keep trying and more records get added.

system_user_ids	user_identifier	user_identity_source_id	count	project_ids
{92,111}	rstaplet	2	2	{43,46,49,50,55,56,58,67,79,80,89,90,99}
{93,108}	eroorda	2	2	{39,46,49,50,55,56,58,80,87,89,99,100,101}
{95,110}	gemery	2	2	{95,96}
{96,107,109,113,114}	jbudzins	2	5	{40,41,47,87}
That jbudzins one was created today, so there might be more appearing if they keep trying and more records get added.

I added a migration that should remove duplicate users based on (user_identifier, user_identity_source_id) as a unique key and then patch any references to those removed system_user_ids.

select t.table_schema,
       t.table_name
from information_schema.tables t
inner join information_schema.columns c on c.table_name = t.table_name
                                and c.table_schema = t.table_schema
where c.column_name = 'last_name'


Add example unit files for deploying with Etcd and instructions

A few nit picks, but thanks for this!

Also of note:  this depends on fleet, too, not just etcd.

Fleet is mentioned in README.md

Thanks!  Best practices are hard to come by, right now.  A lot depends on the networking setup used, so I don't see any need to hold this up on that long-term esoterica.


puppet-openldap uses non-existent function: validate_number

puppet-openldap 1.1.4 uses non-existent function validate_number:
manifests/configuration.pp:    validate_number($tls_protocol_min)
manifests/server.pp:    validate_number($ssl_protocol)

validate_number does not exist in (the latest) bodgitlib 1.4.0.

This should be a stdlib function; it should be either validate_integer or validate_numeric and I've had a brain fart and typed validate_number. Let me take a look.

So it should be validate_numeric as the TLS protocol numbers can be specified as 3.2 to require TLSv1.1, etc.
Fixed in master pending a v1.2.0 release. Thanks for the bug report!


Prevent generated types from colliding with Resources

Signed-off-by: Aaron Eaton<EMAIL_ADDRESS>Issue #, if available: https://github.com/crossplane/provider-aws/issues/876
Description of changes:
It is possible to have a name collision between a Crossplane Managed Resource and a generated type based on a resource's fields. A good example of this is the SecurityGroup type, which is both a Managed Resource and a generated type.
Whichever type is declared  in the highest apiVersion will become the "storage version" for the given type.
For SecurityGroup, this has no impact, because the Managed Resource is version v1beta1 and the generated type is only in lower versions.
But for the proposed Route resource, the Managed Resources is v1alpha1 and a generated type exists in v1beta1, resulting in v1beta1 becoming the storage version. Because the storage version is generated, it lacks crossplane required fields status and synced.
Marking all generated types with // +kubebuilder:skipversion will prevent them from becoming the storage version for a Managed Resource of the same name.

/lgtm


eross1lf

Changes to eu branch for implementing the Gift Wrapping and Gift Messaging ( EE and CE )

Bug fix when navigating to Amazon checkout from Magento checkout, the gift wrapping options will not update the totals


What format to fill in "email_url:"？

I tried :
<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>all will be converted as<EMAIL_ADDRESS>

Will have a look

This is now fixed. Please pull the latest version. Thank for reporting the bug !


Change BouncyCastle library from Portable.BouncyCastle to BouncyCastl…

Update BouncyCastle library as suggested by @pablopioli should close: #314
Description
Portable.BouncyCastle is deprecated (last update in 2021) cc: @fszlin
Checklist

[ ] All tests are passing
[ ] New tests were created to address changes in pr (and tests are passing)
[ ] Updated README and/or documentation, if necessary

@fszlin any update on that?


Update mirror.py to a uv script

Summary
From my reading of the UV docs, mirror.py would be a good example of a standalone script. This PR updates mirror.py and the main.yml workflow to be a UV script and makes use of UV in the update process.
Test Plan

Update the uv version (currently 0.8.4) to an older version e.g. 0.8.3 in both pyproject.toml and README.md
Run uv run --no-project mirror.py to check the update process still works as expected

This change was identified when working on https://github.com/calumy/ruff-pre-commit/pull/3. After this is merged, I will rebase and create the PR for this repo. I think it is currently in my fork, as both the head and base branches are in that repo, so I am not sure it will automatically update if/when this PR is merged.


VAULT_ADDR getting reset when running a Job

I've got a db migrate job that needs to run as a pre-install hook - however VAULT_ADDR is getting set twice:
- name: VAULT_ADDR
  value: https://vault.default:8200
- name: VAULT_ADDR
  value: https://vault:8200
- name: VAULT_SKIP_VERIFY
  value: "false"
- name: VAULT_PATH
  value: kubernetes
- name: VAULT_ROLE
  value: default

the first one is coming from the annotation and is correct. i'm not sure where the second one is coming from. the interesting thing is this doesn't happen with the Deployment only in the Job.
i passed the same command to both Job and Deployment:
command:  ["/bin/sh", "-c", "bin/python migrate.py migrate --run-syncdb"]

Interesting, I'm double-checking the code now. Could you please check the Job and the Deployment have the same annotations on the Pod level?

Both are setting:
vault.security.banzaicloud.io/vault-addr: 'https://vault.default:8200'
vault.security.banzaicloud.io/vault-tls-secret: vault-tls

Could you please provide the full manifest for both cases? I try to reproduce.

apiVersion: apps/v1 kind: Deployment metadata:   name: auth   labels:     app.kubernetes.io/instance: auth     app.kubernetes.io/managed-by: Tiller     app.kubernetes.io/name: auth     app.kubernetes.io/version: "1.0"     helm.sh/chart: auth-0.1.0 spec:   replicas: 3   strategy:     type: RollingUpdate     rollingUpdate:       maxSurge: 25%       maxUnavailable: 1   selector:     matchLabels:       app.kubernetes.io/name: auth       app.kubernetes.io/instance: auth   template:     metadata:       labels:         app.kubernetes.io/name: auth         app.kubernetes.io/instance: auth       annotations:         vault.security.banzaicloud.io/vault-addr: "https://vault.default:8200"         vault.security.banzaicloud.io/vault-tls-secret: vault-tls     spec:       containers:         - name: auth           image: "repo-path"           imagePullPolicy: Always           command: ["sh", "-c", ". bin/activate && bin/uwsgi uwsgi.ini"]           ports:             - name: auth               containerPort: 3060           env:             - name: SECRET_KEY               value: vault:secret/data/service/auth/stage/secret_key#key             - name: DATABASE_URL               value: vault:secret/data/accounts/aws/stage/rds#db_url             - name: DEFAULT_FROM_EMAIL               value<EMAIL_ADDRESS>           - name: REDIS_URL               value: redis-url             - name: DJANGO_SETTINGS_MODULE               value: django.settings
apiVersion: batch/v1 kind: Job metadata:   name: db-migrate   annotations:     "helm.sh/hook": pre-install,pre-upgrade     "helm.sh/hook-delete-policy": hook-succeeded     "vault.security.banzaicloud.io/vault-addr": "https://vault.default:8200"     "vault.security.banzaicloud.io/vault-tls-secret": vault-tls spec:   activeDeadlineSeconds: 120   template:     name: db-migrate     spec:       restartPolicy: Never       containers:         - name: db-migrate           image: "repo-path"           command: ["/bin/sh", "-c", "bin/python manage.py migrate --run-syncdb"]           env:             - name: SECRET_KEY                value: vault:secret/data/service/auth/stage/secret_key#key             - name: DATABASE_URL               value: vault:secret/data/accounts/aws/stage/rds#db_url             - name: DJANGO_SETTINGS_MODULE               value: django.settings
sanitized a bit

Not able to reproduce this with the latest version. Could you please check it against that one as well (0.6.2)?


Jeopardy karma should be awarded to BaseNick

Karma won in Jeopardy is incorrectly attributed to user's exact current nick, rather than their base nick.

Fixed by: b01b2147b23be3aa51857b12c64baa932f6abe1c


Map image giving problems

Hi, the map image keeps showing on the screen as if the column was set to: . Does anyone have a solution to this problem? And client mail doesn't seem to be getting through to me.

Re Map Image:
I had no issues reported yet; please specify the context (how can this error be reproduced):

which browser you were using
evetually which screen (mobile/laptop/PC) and resolution.
Re Email:
I am not using the php script, but
have you filled the correct details in ./mail/contact.php?
you webhost is configured to run php scripts?
is there a mail server on your webhost?
Hope it helps,
Thank you

I'll say yes to all, my host has php 5.3 and I'm using the latest firefox browser.

I managed to fix the php script that had conflict with the HTML, but still can't fix the map part.

Not sure what's going on here, look for stray tags is all I can say as a starting point!


Touch.clientX and Touch.clientY contains float not integer values -> java.lang.ClassCastException

On Android prortables the Touch object wich is contained in TouchEvents contains float values. This leads to ClassCastException when accessing e.g clientX or clientY. Don't know yet which other attributes are effected. :-(
Objects in mind:
The attributes https://developer.mozilla.org/en-US/docs/Web/API/Touch
org.scalajs.dom.Touch
Android Version 4.2, 4.4 (No other were tested)
Browser Chrome
The exception makes it impossible to use these Objects

Duplicate to 1493


RevEng: Use Builder Approach to build *Configuration Classes

At the moment ModelConfiguration represents both a) view-model information necessary to output the DbContext and EntityType class files, and b) is used to create all the other *Configuration classes.
It would be better design to have a ConfigurationBuilder class which did b) and restrict ModelConfiguration to just being the view-model class.

Can this be closed? The implementation has changed a lot since this was filed, and it no longer seems valid.


refactor(locale): added missing languages to types

📚 Description
Added missing languages to types in order to make VS stop complaining and to make intellisense work
📝 Checklist

[x] All commits follow the Conventional Commit format
[x] The PR's title follows the Conventional Commit format

:tada: This PR is included in version 5.2.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Fix version qualifiers in pyproject.toml files

Fixes

Related to #4166 by @dhruvkb
Description

@dhruvkb has flagged the fact that the PRs migrating to PDM were setting versions incorrectly, not in the way we use in the API.
This PR updates the version qualifiers:
>=x.y -> >=x.y.z, <x+1.
This prevents PDM from updating the version to the next major version.
Testing Instructions

CI should pass.
Checklist

[x] My pull request has a descriptive title (not a vague title likeUpdate index.md).
[x] My pull request targets the default branch of the repository (main) or a parent feature branch.
[x] My commit messages follow best practices.
[ ] My code follows the established code style of the repository.
[ ] I added or updated tests for the changes I made (if applicable).
[ ] I added or updated documentation (if applicable).
[x] I tried running the project locally and verified that there are no visible errors.
[ ] I ran the DAG documentation generator (ov just catalog/generate-docs for catalog
PRs) or the media properties generator (ov just catalog/generate-docs media-props
for the catalog or ov just api/generate-docs for the API) where applicable.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

It seems like the content hash was updated for utilities/dead_links, but didn't for the other 2 utilities projects?

I'm not sure why that happened.
I re-ran pdm install but it didn't update the lock file. There was a warning WARNING: Lockfile is generated on an older version of PDM, so I deleted the lock file and re-ran pdm install, and the lock file updated the hash, groups and some other dependencies.
Do you know if the lock files are not updated when different pdm versions are used, @dhruvkb ?

Sorry, I don't know what happens if PDM encounters a lockfile generated by an older version of itself.


Radar 'camera' component planned?

The previous integration included a radar camera component, that you could add to Lovelace. Any chance of including that in this platform (or creating a separate one)?

Like this you mean? https://github.com/theOzzieRat/bom-radar-card

thanks - just the ticket!


Missing instructions to press the "Train" button

This should come before the "Try it out sections", otherwise the chat panel will not be available.
Thanks,
Darren

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 172ca5fe-18be-3fa8-38e8-b72461192abc
Version Independent ID: f6f45c1b-9cf9-986a-01ad-5b2d73992911
Content: Quickstart: Create a Custom Command with Parameters (Preview) - Speech service - Azure Cognitive Services
Content Source: articles/cognitive-services/Speech-Service/quickstart-custom-speech-commands-create-parameters.md
Service: cognitive-services
Sub-service: speech-service
GitHub Login: @don-d-kim
Microsoft Alias: donkim

@dargilco we will review your feedback and get back to you shortly. Thanks.

@dargilco I agree that we should mention 'Train' before 'Try it Out Sections'.
@don-d-kim @j-martens please add as backlog item.


Release v1.2.1

Open Tickets

[x] https://github.com/mattermost/mattermost-plugin-apps/pull/438
[x] https://github.com/mattermost/mattermost-plugin-apps/pull/439
[x] https://github.com/mattermost/mattermost-plugin-apps/pull/442
[x] https://github.com/mattermost/mattermost-plugin-apps/pull/445
[x] https://github.com/mattermost/mattermost-plugin-apps/pull/449
[x] https://github.com/mattermost/mattermost-plugin-apps/pull/451
[ ] https://github.com/mattermost/mattermost-plugin-apps/pull/452
[ ] https://github.com/mattermost/mattermost-plugin-apps/pull/432

Ticket Link
Part of https://github.com/mattermost/mattermost-plugin-apps/issues/444

Codecov Report
Base: 20.33% // Head: 20.74% // Increases project coverage by +0.40% :tada:

Coverage data is based on head (3067c23) compared to base (7670ef9).
 Consider uploading reports for the commit 0185e3a to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #450      +/-   ##
==========================================
+ Coverage   20.33%   20.74%   +0.40%
==========================================
  Files          78       80       +2
  Lines        5262     5366     +104
==========================================
+ Hits         1070     1113      +43
- Misses       4062     4114      +52
- Partials      130      139       +9

Impacted Files
Coverage Δ

server/main.go
0.00% <0.00%> (ø)

server/plugin.go
42.15% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

/update-branch


Feature enum parse error..? Locks up game.

Updated to latest "Mono.Cecil.Inject", and updated to latest version of Maid Fiddler. ReiPatcher patched it correctly with no errors, but whenever I get on the KISS logo screeen on startup, Maid Fiddler encounters an error and spits out a log attached below. On the CAUTION screen it seems to sit there fine until I click. Then I get a popup box that says "(0) Feature enum parse error." The CMD box pops up two lines:
"\Assert ! Feature enum parse error.
Exception: Feature enum parse error."
Trying to load to the main screen spits out more text in the CMD box:
"ArgumentNullException: Argument cannot be null.
Parameter name: s"
Fiddler error file attached below.
MaidFiddler_err_y1Zom0kG1Ag=.txt
EDIT: Would also like to say this all started when I tried to update cecil.inject alongside Maid Fiddler after receiving the issue in the following link: https://github.com/denikson/CM3D2.MaidFiddler/issues/4
Was running latest version before v1.40 which I have yet to install. Might try installing v1.40 of CM3D2 and see if it helps any.
EDIT 2: It appears as though updating to v1.40 somehow fixed it even though it came out literally either today or yesterday by my watch. o.O

Judging by the error, the issue wasn't really related to Maid Fiddler.
For reference, if you look at the line of the code where the issue most likely occurred, Maid Fiddler only iterates through the noon work data without editing it. That means the game would still crash even without Maid Fiddler installed. Moreover, Maid Fiddler does work fine with CM3D2 v. 1.39 and older (I still have an old version installed).
The easiest solution would be to install the latest version of the game (exactly what you did) or reinstalling the old version and making sure you have all the files for the game.


Show window when searching over visual selection

Not sure if this should be an issue but is there an expectation that when highlighting a visual selection, the interaction should take place or is that out of scope?

Hi, and sorry for the late reply. I had some issues irl and didn't have much time. Can you please specify the question more, I don't understand it. 😅
Thank you.


Setting Item.issue_count to deferred.  Only joining tables in distinct if necessary.

This solves #548.
The search dropdowns have gotten pretty slow.
I had SQLAlchemy print out the actual SQL it was sending to the DB and determined the Item.issue_count column_property was causing a significant delay.  I've modified that column property to be deferred.
The many joins were also having a big impact.  I've moved the joins to occur only when they are actually needed.  We've seen between a 10x and a 30x improvement with these modifications.
(Adding an index to Technology.name in #610 may have also helped, though I'm not sure by how much.)

Coverage decreased (-0.02%) to 56.598% when pulling 3069fa51b2097a1ef5efce3856dcea42555f784a on distinct_performance_optimizations into ea1c45e73dcca4e14af6d3c8a5c3f906d231edff on develop.


Document correction needed

Section:
App-based or compliant device policy for Exchange Online and SharePoint Online
Step 2 - Configure an Azure AD conditional access policy for Exchange Online with Active Sync (EAS)
4) Conditions: As Conditions, you need to configure Client apps.
As Client apps (preview), select Mobile apps and desktop clients and Exchange ActiveSync clients.

The picture doesn't match the words.  Please replace the screen shot.

As Access controls, you need to have Require approved client app (preview) selected.

The picture doesn't match the words.  Please replace the screen shot.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a1d67eec-b53c-4bbc-b160-b3fb8fca5ff4
Version Independent ID: b943cd70-2c1b-5b9b-8ed7-0b0331da3982
Content: How to require approved client apps for cloud app access with conditional access in Azure Active Directory
Content Source: articles/active-directory/conditional-access/app-based-conditional-access.md
Service: active-directory
Sub-service: conditional-access
GitHub Login: @MicrosoftGuyJFlo
Microsoft Alias: joflore

@igorvt77, Thanks for bringing this to our attention. We are taking a look into this and will get back to you soon.

@MicrosoftGuyJFlo Could you please review the documentation update request provided by @igorvt77 and update it as necessary . If this is already in the pipeline , please let us know accordingly.
Thank you .

Backlog item created to update this doc

#please-close

Please fix this!  The screenshots still do not match the instructions.


AttributeError: 'PointerLSTM' object has no attribute 'get_initial_states'

Trying to start the script getting this error message:
AttributeError: 'PointerLSTM' object has no attribute 'get_initial_states'

You might try Keras 2 branch:
https://github.com/zygmuntz/pointer-networks-experiments/tree/keras-2.0

thank you!


Created recipe for css-loader options

Created recipe for css-loader option localsConvention.

Merged, thank you :)


modified header names in PHAMB

Hi,
My assembled contigs have headers as

c_000003956504
c_000004841845
c_000004821562

which matches with the VAMB bin headers. But when I run PHAMB, I get bin headers as :

1470111
816445
3021234
1094390

How to get the PHAMB contig headers in the initial VAMB bin headers format?.

Hi Shail
Can you send me a snapshot of your clusters.tsv file? And how many samples do you have?
I expect that there might a problem in the naming of your contigs.
The framework is designed to use the Sample-IDs from the header of contigs to keep track of where each viral-bin is from.
best,
Joachim

@joacjo I used a single co-assembled contigs file for binning. Here is the snapshot of the cluster.tsv file and phamb generated fna file

The cluster.tsv file has 1101140 records.
I followed the How to Run - not in parallel - quick and dirty tutorial.
Thank you.

Hi Shail
Ah I see. The names of the entries in vamb_bins.fna matches the VAMB-cluster names. Remember the bins in the .fna file are concats of the VAMB cluster sequences.
Example: In your clusters.tsv you might have a cluster with multiple contigs:
cluster  contig
99999    c_000000123
99999    c_000000321
If this cluster is predicted putative viral,  the resulting name in the .fna file will be:  99999
Does this make sense?
Best,
Joachim

Thanks. that makes sense.
Thanks for this very helpful tool. We could extract a three times higher number of complete contigs (as per CheckV's rule) with PHAMB in comparison to VirSorter2, DeepVirFinder and viralVerify.


Py - Remove any cols with ID in dataframe (after removing GrainID)

Closing. This makes too many assumptions. What if it was DiagnosisID or HospitalUnitID. Those are totally valid features.


Budget and swag requests have been submitted

[ ] Submit budget request based on potential spaces @umeshagarwal
[ ] Open swag request on bugzilla @umeshagarwal
[x] Set dates for online events  @dvigneshwer
[x] Set dates for offline events @umeshagarwal

Updates:

Added tentative dates and agenda for online events in the campaign document

Dates for online and  events are here:https://discourse.mozilla-community.org/t/rainofrust-online-events-schedule/15970
More offline events will be added

@rowdymehul to add more offline events

Offline event schedule : https://discourse.mozilla-community.org/t/rainofrust-offline-events-schedule/16038/2

@couci can we close this?

yes its good to be closed


Missing plugin for ESLint

Is there any way to integrate bardjs to ESLint?

@santiph At what capacity are you thinking Bard should contain ESLint support?   Seeing as you can lint just about anything you want (and also exclude) not sure what you are looking for?

@mikeerickson For example, If no-undef: "error" and you inject an application component using Bard, when you use it on your tests, ESLint throws a linting error. This can be avoided by declaring the vars on a global comment at the top of the file, so is no big deal, but it would be great if ESLint recognised the components injected by Bard.

Ah, this is because it is a global variable.   You can also fix as
/*global error*/

Or, in your package.json
  "eslintConfig": {
...
    "globals": {
      "error": true
    }
  },

@mikeerickson I have tried what you suggest, and it doesn't seem to change anything. Maybe I did't get my message across, let me show you an example:
/* eslint-env mocha */
/* eslint no-undef:2 */
/* global error */

describe('example', function() {
	beforeEach(function() {
		bard.appModule('app.module');
		bard.inject('exampleService');
	});

	it('should do something', function() {
		exampleService.someMethod();
	});

});

'exampleService' is not defined (no-undef)
That's what I mean, does it make sense?
I think it would be very nice if there was a Bard plugin for ESLint so that injected components are recognised as defined. As I said before, the way around it is to declare the injected component as a global /* global exampleService */ but it sort of misses the whole point for using Bard.

@rglepper So in your case, if you apply
/* eslint no-undef: 0 */

Then it would take care of your issue (no?)  I hear what you are saying, but creating a specific bard-eslint-plugin to workaround these types of eslint warnings / errors is sort of out of the scope when specific rules outside of bards control (ie your own choosing) the no-undef switch would do the trick
If I am still missing your point and you feel a bard-eslint-plugin would make additional sense, please let me know.

I was expecting a better solution than copy/pasting this on every test file:
/*global bard $controller $httpBackend $q $rootScope */

You can again apply this in your package.json as follows
  "eslintConfig": {
...
    "globals": {
      "error": true,
      "$controller": true,
      "$httpBackend": true,
      "$rootScope": true
    }
  },

This way, you don't have to apply to each of your test files.

@santiph See previous message...


fix the bug of widget duplication

What changes were proposed in this pull request?
The data of widget in the database will not be deleted when the service (for example YARN) uninstalling. And when installing,will check if the widget exists by clusterId,widget_name,user and default_section_name. The focus is on default_section_name. In the if statement, the default value will be set by SECTION_NAME. But in the else statement, no default value will be set. Then the widget created in the first installation can not be find in the next installation, and another widget (same with the previous) will be created repeatedly.
How was this patch tested?
Manual tests.
(Please explain how this patch was tested. Ex: unit tests, manual tests)
(If this patch involves UI changes, please attach a screen-shot; otherwise, remove this)
Please review Ambari Contributing Guide before opening a pull request.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/4765/
Test PASSed.


Fix #982, separate pipeinfo file data structure

Describe the contribution
Provide a separate/dedicated structure for use in the "Pipe Info" file as written by the CFE_SB_SEND_PIPE_INFO_CC command, instead of using the CFE_SB_PipeD_t which is supposed to be internal/private.
Data is extracted from the internal CFE_SB_PipeD_t while shared data locked and staged into this new format, then the shared data is unlocked while the other information is gathered and finally written to the file.
Fixes #982
Fixes #995
Testing performed
Build CFE and sanity check, run all unit tests
Run the CFE_SB_SEND_PIPE_INFO_CC and confirm that the file is generated.
Expected behavior changes
This changes the binary format of the generated pipe info file.  However after this is merged the format of the fine should be more stable going forward, as internal changes to the CFE_SB_PipeD_t will no longer affect it.
System(s) tested on
Ubuntu 20.04
Additional context
This still needs a rebase as it depends on #1092.
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.

CCB:2021-01-21 APPROVED

CCB:2021-01-21 APPROVED

@astrogeco - This has been approved... does it need a tag update and merge?

@astrogeco - This has been approved... does it need a tag update and merge?

@astrogeco - This has been approved... does it need a tag update and merge?

I think this was probably a last-minute CCB addition since the "ready" label is missing; I missed it. Thanks for catching it!

@astrogeco - This has been approved... does it need a tag update and merge?

I think this was probably a last-minute CCB addition since the "ready" label is missing; I missed it. Thanks for catching it!

@astrogeco - This has been approved... does it need a tag update and merge?

I think this was probably a last-minute CCB addition since the "ready" label is missing; I missed it. Thanks for catching it!

I did notice it's still in draft mode @jphickey did you mean to change anything here?

@astrogeco - This has been approved... does it need a tag update and merge?

I think this was probably a last-minute CCB addition since the "ready" label is missing; I missed it. Thanks for catching it!

I did notice it's still in draft mode @jphickey did you mean to change anything here?

I think it's only as draft since it depends on merges that are still in IC... if you update target to IC they should go away.

I think it's only as draft since it depends on merges that are still in IC... if you update target to IC they should go away.

I think it's only as draft since it depends on merges that are still in IC... if you update target to IC they should go away.

I just clicked the button :)

I think it's only as draft since it depends on merges that are still in IC... if you update target to IC they should go away.

I just clicked the button :)

I still needed to rebase this.... it looks like I'm too late though

I still needed to rebase this.... it looks like I'm too late though

I still needed to rebase this.... it looks like I'm too late though

sorry!! Feel free to push to the cFE IC branch if there's anything we need to fix...

I still needed to rebase this.... it looks like I'm too late though

sorry!! Feel free to push to the cFE IC branch if there's anything we need to fix...

Problem is it picked up an extra commit (0f4ed8f9b) which was a temporary merge I had locally done of the prerequisites.  My normal process is to rebase to "main" once those prerequisites are merged.
Should I force-push to integration-candidate to remove this extra commit in the history - or do you want to just leave it forever?

Problem is it picked up an extra commit (0f4ed8f9b) which was a temporary merge I had locally done of the prerequisites.  My normal process is to rebase to "main" once those prerequisites are merged.
Should I force-push to integration-candidate to remove this extra commit in the history - or do you want to just leave it forever?

Rebased and fixed merge in integration-candidate - all good now.

Rebased and fixed merge in integration-candidate - all good now.


Make gfx_sinematrix size-independent

Hi, since you asked on twitter about size independence of gfx_sinematrix...
This code here for src/modules/gfx_sinematrix.c:draw() pretty much does it. The size_factor does not have to be PI, it just fitted when I tried it ^^
        matrix_clear();

        const int mx = matrix_getx();
        const int my = matrix_gety();
        const float size_factor = M_PI;
        const float fx = mx / size_factor;
        const float fy = my / size_factor;

        pangle = addmodpi( pangle, (0.00937) + (angle/256) );
        angle = cosf(pangle) * M_PI;
        sx = addmodpi( sx, 0.00673 );
        sy = addmodpi( sy, 0.00437 );
        tx = addmodpi( tx, 0.0239/mx );
        ty = addmodpi( ty, 0.0293/my );
        cx = addmodpi( cx, 0.00197 );
        cy = addmodpi( cy, 0.00227 );
        rcx = (mx/2) + (sinf(cx) * mx);
        rcy = (my/2) + (sinf(cy) * my);
        basecol = addmod( basecol, 1.0, 0.007 );

        matrix rotate = {
          .v1_1 = cosf(angle),
          .v1_2 = -sinf(angle),
          .v2_1 = sinf(angle),
          .v2_2 = cosf(angle),
        };
        matrix scale = {
          .v1_1 = (sinf(sx) + 0.35)/fx,
          .v1_2 = 0,
          .v2_1 = 0,
          .v2_2 = (cosf(sy) + 0.35)/fy,
        };
        vector translate = {
          .x = sinf(tx) * mx,
          .y = sinf(ty) * my,
        };

Perhaps make it a PR instead, so you can retain ownership of your fix at least?

Very nice! Thank you so much!


fission.yaml does not result in a working deployment

The yaml snippit for the controller deoployment ends in crash loop backoff with the following logs:
$ kcn fission logs controller-2839000588-pt9wb
2016/11/28 22:35:52 Error: path /filestore does not exist

Oof, the yaml uses the 'latest' tag for fission-bundle and that didn't point to a working image.
I've tagged the current working fission-bundle image as 'latest' as well as 'alpha'.  Also, I'll update fission.yaml to use the 'alpha' tag.


feat: supports scriptable objects

Now you can pass scriptable objects in commands, rpcs and syncvars
For example:
class Weapon: ScriptableObject
{
    public string name;
    public string description;
    public int damage;
    ...
}

class Player : NetworkBehaviour
{

    [SyncVar]
    Weapon equipped;

    ...
}

Scriptable objects will be created in the client using
ScriptableObject.CreateInstance.  If users want something else
they can provide a custom serializer (that has not changed)

I think this needs further consideration.  I'm not comfortable with our invoking ScriptableObject.CreateInstance under the hood, and I think this may open a door to users' expectations we can't fulfill.  SO's are design-time assets, and as such may have all kinds of properties beyond simple ones, e.g. sprites, audio clips, prefab references, custom editors, and more that we can't begin to serialize, so users will have to make their own reader and writer and we already support that.
Let's hold this a bit and see if we can come up with other ideas.

for future reference, as per discord discussion: we already allow serializing classes.
internally they are created with 'new'.
'new' doesn't work for scriptableobjects, they are a special case which is supported in this pr

for future reference, as per discord discussion: we already allow serializing classes.
internally they are created with 'new'.
'new' doesn't work for scriptableobjects, they are a special case which is supported in this pr

I didn't know we did that with classes, and I'd have the same objections.  I don't think we can predict what a malicious client could do to a server by spamming messages in that create thousands of new SO or class instances, instead of passing a ref to one that exists on the other side.  If there was a restriction where calls to new or .CreateInstances could only fire on the client, I'd be happier about this.  At least with that restriction we're not unzipping the server's fly.

@MrGadget1024 @paulpach can you remember why we added classes in the first place?

@vis2k  we didn't.   They were supported since HLAPI.  They have always been there.

ok. we need to reevaluate if we want classes at all or not, but this PR is a class like all the other classes so it makes sense for now.


have you tried it in tensorflow1.4?

I used it in tensorflow1.4, and met the bug,
tensorflow.python.framework.errors_impl.NotFoundError: /home/master/Deform/lib/deform_conv.so: undefined symbol: _ZTIN10tensorflow8OpKernelE
and my g++ is 4.9.4.
nvcc_compile.sh is as below:
nvcc -std=c++11 -arch=sm_37 -ccbin=/usr/bin/g++-4.9 -c -o deform_conv.cu.o deform_conv.cu.cc -I $TF_INC -D GOOGLE_CUDA=1 -x cu -Xcompiler -fPIC -L /usr/local/cuda-8.0/lib64/ --expt-relaxed-constexpr
g++_compile.sh is as below:
g++-4.9 -std=c++11  -shared -o deform_conv.so deform_conv.cc deform_conv.cu.o -I $TF_INC -fPIC -lcudart -L $CUDA_HOME/lib64 -D GOOGLE_CUDA=1 -Wfatal-errors -I $CUDA_HOME/include -D_GLIBCXX_USE_CXX11_ABI=0

No I didn't test it in tf 1.4. This issue suggests to downgrade to 1.3.

According to this issue It might work when -L$TF_LIB -ltensorflow_framework are added to g+= flags. This flag actually baffles me.


Release for macOS is not working

https://github.com/hbelmiro/kgrep/actions/runs/10393395099/job/28780793505

Fixed in https://github.com/hbelmiro/kgrep/commit/776218cf84b8105f9562e19d29d9b38e12c5f3ee.


🐛 BUG: Astro import duplication bug

Describe the Bug
When enabling organizeImports in VSCode settings, saving a file in an Astro project duplicates the import statements, especially when using import aliases defined in tsconfig.json. This issue occurs in Astro v2.13.1 and v2.13.0 but not in v2.12.8.
Environment:

OS: Windows 11 using WSL 2 with Ubuntu
Astro version: v2.13.1 and v2.13.0
VSCode version: 1.92.0 (system setup)
Commit: b1c0a14de1414fcdaa400695b4db1c0799bc3124
Date: 2024-07-31T23:26:45.634Z
Electron: 30.1.2
ElectronBuildId: 9870757
Chromium: 124.0.6367.243
Node.js: 20.14.0
V8: <IP_ADDRESS>-electron.0
VSCode extensions: astro-build.astro-vscode

Additional Context:
Disabling organizeImports resolves the issue temporarily. Reverting to version 2.12.8 resolves the issue as well.
.vscode/settings.json

Bug in Action:
https://github.com/user-attachments/assets/a479bef8-2d09-4ed4-8b91-31cbede0bd22
If you need more information or further details, please let me know.
Steps to Reproduce

Install Astro v2.13.1 or v2.13.0.
Enable organizeImports in the VSCode settings.
Define import aliases in tsconfig.json (e.g., @components, @layouts).
Create a file with multiple import statements using these aliases.
Save the file.
Observe the duplicated import statements.

Expected Behavior
The import statements should not be duplicated upon saving.
Actual Behavior
Import statements are duplicated upon saving the file, particularly when using import aliases from tsconfig.json.
Link to Minimal Reproducible Example
https://github.com/Zyruks/astro-import-duplication-bug

I cannot seem to be able to reproduce this, and I'm not sure why that version would introduce that issue, but I'll take a look!

I have disabled all extensions, but the problem persists. You can try to reproduce the issue using the repository I uploaded.
Link to Repo
https://github.com/user-attachments/assets/6096e6d8-3476-4577-a60e-2dc6bd539e23

Even with your repo, I cannot reproduce the issue. There's probably something else at play here, maybe Windows etc.

Well, if I can help or try anything else, just let me know.

Can confirm this is also happening to me on Windows on all Astro repositories when I have organizeImports turned on. Reverting back to 2.12.8 likewise fixed the issue

So far I have absolutely no idea what could cause this, the only difference between those two versions is the SCSS and LESS support, which should be totally unrelated to the frontmater 🤔

@Zyruks @MattheousDT Does this still happen to you after the update?

Yep, just figured out what's the reason. Working on a fix now! It only affects CRLF files, so at least it's possible to use LF as a workaround until a fix is released. Apologies for the inconvenience.

It should be fixed in the last version, apologies for the delay, issue ended up being a bit complicated.


add installation for zh-tw language.

as title
cc @lunny @tboerger

LGTM

Trusted LGTM
Can you also provide a backport to v1.0 branch?


Update Makefile scripts

Not sure if you planned to finish these or not, so I took a stab  Let me know if you think the yes or no logic is too much, I just noticed the grep indy removed a lot of images for me that were just named indy, so I added logic for indy_pool and indy_dev.  Still dangerous.

@kdenhartog What do you think?

Np and good idea! I was just running the docker run command alone.. Working on your other todos and might file issues for them.  Feel free to files issues as well to give me some scope or direction.


test: minor tweak

#278
#382  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @hi-ogawa and the rest of your teammates on  Graphite


Consider scoping parent per-file globs to the base project when

Summary: per-file-ignores globs in a parent config file seem to resolve relative to the parent's location rather than the base project.
Consider the following
project_a/
|_ pyproject.toml (extends ../config/shared-ruff.toml)
|_ src/...
|_ tests/...

config/
|_ shared-ruff.toml (attempts to set a per-file-ignores glob e.g. to exclude D100 from any tests/**/*.py file)

(Note that the parent config dirname isn't strictly a prefix of the other projects).
Expected: Sharing settings that involve globs across projects with similar layouts should be possible somehow. This seems in line with the other settings when extending config files e.g. https://docs.astral.sh/ruff/settings/#src
Actual:
The globs seems to be resolved as absolute paths in /config/tests/**/*.py. When the workspace is resolved, each configuration is given its own project_root with the path to the current config file being parsed. This means only the base-name glob matcher can be used e.g. I can exclude files like __init__.py or *.py but not tests/__init__.py or more complex globs.
Workaround:
It's possible to move the config file to a shared parent folder and use a prefix glob e.g. **/tests/*.py

Thanks for the report. This looks like a duplicate of https://github.com/astral-sh/ruff/issues/8795, we can track this there.


Date archives not being detected

ie, on clean install, categories and everything else looks ok, but missing /2020/04/ in CrawlQueue

Any luck with this? It's appearing as if most of my uploads are not being crawled, so the final static site is missing almost all of my media.


ThrottleTime with immediate output but all events must be n ms apart

Feature Request
Is your feature request related to a problem? Please describe.
With the current throttleTime behavior with config {leading: true, trailing: true}, events are not guaranteed n ms apart. For example:
const observable = cold('-abcdef-----abcdef|');
const throttled = observable.pipe(
    throttleTime(time('---|'), getTestScheduler(), {leading: true, trailing: true}));
getTestScheduler().expectObservable(throttled).toBe('-a--de--f---a--de-(f|)');

Describe the solution you'd like
I want all events to be at least n ms apart. Specifically:
const observable = cold('-abcdef-----abcdef|');
const throttled = observable.pipe(
    throttleTime(time('---|'), getTestScheduler(), someFooConfig));
getTestScheduler().expectObservable(throttled).toBe('-a--d--f----a--d--(f|)');

Describe alternatives you've considered
I'm currently using throttleTime with {leading: true, trailing: true}, but that's not ideal since my RPCs are not always n ms apart (causing them being throttled from the server). The default config {leading: true, trailing: false} does not cut it because some trailing events are missing. The config {leading: false, trailing: true} does not cut it either because I'd like to process the event immediately if possible.
(If this is new operator request) describe reason it should be core operator
This can be achieved in the user-land module by just clone the throttleTime code and does the fix myself in my code, but that's not very elegant.
Additional context
This feature seems to be the one requested in https://github.com/ReactiveX/rxjs/issues/1625 , but the fix did not achieve that objective.

I can't tell if this is a bug with the current behavior, or it should be a new feature. IMO, something isn't "throttled" if two events can be fired in less time than the throttle. 🤔

Discussed with the team... we will try to align this with whatever lodash is doing.

TBH, this seems related to https://github.com/ReactiveX/rxjs/issues/4429 - i.e. inspectTime is, AFAICT, what's being sought, here.


Proxy settings broken for multi/launcher stager in Empire 2.4

Empire Version
2.4
OS Information (Linux flavor, Python version)
Kali Rolling, python 2.7
Expected behavior and description of the error, including any actions taken immediately prior to the error. The more detail the better.
Expected behavior: set Proxy <IP_ADDRESS> under the multi/launcher stager, followed by execute should complete successfully.
Actual Behavior: upon execute being run, the following error is shown:
[!] Exception: 'str' object has no attribute 'Split'
Screenshot of error, embedded text output, or Pastebin link to the error
https://gist.github.com/Strazzom/f4ba8f3733bffd3bcf3d19921074fa04
Any additional information
This error only occurs when setting the proxy for the stager. I have tested this with multi/launcher, although it may also be an issue with other stagers. This error does not occur when setting proxy options for the listener.
Questions about proxy feature documentation
As an aside, the proxy settings are poorly documented. What exactly do the proxy settings do? Is the listener proxy setting the one used by the agent when it connects back? Is the stager proxy setting used for the initial request, or for all subsequent connections from the agent it creates?
In general, where is development in terms of proxy support? I have been looking at the documentation, but according to http://www.powershellempire.com/?page_id=104 it seems that it hasn't been properly implemented.
From the official site:
"For UserAgent and proxy options, default uses the system defaults, none clears that option from being used in the stager, and anything else is assumed to be a custom setting (note, this last bit isn’t properly implemented for proxy settings yet)."
What does custom mean? There is no explanation about the syntax of "custom" either.

@Strazzom Are you inquiring about a socks proxy server within empire? Or a setting the proxy in the listener settings for the agent to use client side?

The latter. What kind of proxies can I set in the listener, that the agent will use?

I mean an external proxy, like Tor or another socks proxy. I do not mean one built in to Empire.

Ah,  @Strazzom the agent supports HTTP/s proxies.

Ok. Thank you for that explanation. Is there any support planned for socks4/5 proxies?
Also unrelated: how might one get on the Slack? I have a lot of things to discuss that might not be ideal for github issues.

@Strazzom Possibly, haven't had much time to think about new features unfortunately.
For slack: https://adaptiveempire.slack.com/join/shared_invite/enQtMjk4NTUwNzM1NzMwLTYwOTIyZjk3ZjIxOGJiZDM1Y2ZhM2E1NTI5Mjg3MzcwODI5ZTI3YjkxZGE2YWQ0MjIwY2ZkMWMxMTc1ZWRlMjg …

I have the same issue with the war stager, do you manage to fix the error @Strazzom ?

@ThePirateWhoSmellsOfSunflowers after the latest pull I can't seem to replicate that issue. I would look in lib/common/empire.py and lib/common/stagers.py to see the offending 'Split'. Just needs to be lowercase.


PAB fixes

Issues I ran into while working on reinstating the pab client contract pane.

Fix response decoding when retrieving from contract store this was originally trying to decode a PABResp into a Response PABResp. This was a tricky one to track
Fix type of the generated pab api client to match with the backend handlers
Fix demo scripts
set the devolopment host in webpack to <IP_ADDRESS>

Pre-submit checklist:

Branch

[ ] Commit sequence broadly makes sense
[ ] Key commits have useful messages
[ ] Relevant tickets are mentioned in commit messages
[ ] Formatting, materialized Nix files, PNG optimization, etc. are updated

PR

[ ] Self-reviewed the diff
[ ] Useful pull request description
[ ] Reviewer requested

Pre-merge checklist:

[ ] Someone approved it
[ ] Commits have useful messages
[ ] Review clarifications made it into the code
[ ] History is moderately tidy; or going to squash-merge

This completes the changes introduced from #3572 . Thanks :)
LGTM!


multimessage txs

Closes #2149
Description:

Thank you! 🚀

For contributor:

[x] Added entries in PENDING.md with issue # and GitHub username
[ ] Reviewed Files changed in the github PR explorer
[ ] Attach screenshots of the UI components on the PR description (if applicable)
[ ] Scope of work approved for big PRs

For reviewer:

[ ] Manually tested the changes on the UI

Could we add a test that shows multi message transaction displaying?

@faboweb updated


OIPA-2345

https://app.zenhub.com/workspaces/iaticloud-5b8e865bb2cc7b6c78ece322/issues/zimmerman-zimmerman/iati.cloud/2345

:tada: This PR is included in version 5.3.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


JHLite Custom: ignore all children of a parent module

In JHLite Custom, when ignoring a module, it should ignore all the children too.
It doesn't work, and there is a stacktrace:
jhlite-hidden-resources.slugs=custom-jhlite,angular-core

You need to add other children too:
jhlite-hidden-resources.slugs=custom-jhlite,angular-core,angular-health,angular-oauth2,angular-jwt

The problem is:

there are new modules, which have been coded in JHLite: angular-beer
there is a new release
the user upgrades the JHLite custom
it's broken, unless he/she ignores the new module: angular-beer

In fact, when I did the feature I though about that case and decided to do it that way to avoid "silent" exclusions.
That probably was a mistake and should be reworked but we need to find a way to make it explicit. For example with dedicated properties or values to say "I want to exclude this module or this module and all dependent modules". What do you think?

No worry, I don't think it was a mistake, it was designed like this, that's all :-D
I don't think our user will search and exclude all dependant modules. So IMO, no need to manage 2 different properties:

one for excluding single module, 1 by 1
another for exclusing a specific module and all dependant modules

For example, I don't use Angular, and I don't want to use it.
I'll prefer to ignore angular-core, instead of searching and listing all dependant modules to ignore explicitely.
So my opinion is:

keep current property, and improve the behavior to exclude this module and all dependant module
maybe, display the excluded modules at start, to avoid "silent" exclusions

Thank you very much @pascalgrimaud for increasing the bounty 😄 !


Create a Helm 3 compatible chart for the logging-operator

Helm 3 has removed the crd-install hooks in favour of a crds directory: https://helm.sh/docs/topics/chart_best_practices/custom_resource_definitions/#method-1-let-helm-do-it-for-you
The current CRDs for the logging-operator helm chart are located in the templates folder. When using helm 3 to install a helm chart with the logging-operator as a dependency the CRDs are not
installed before they are needed.
Can we create a Helm 3 compatible chart for the logging operator.

Hi @RushedLogic!
Thanks for using the operator and creating the issue, however this change as you suggest would introduce a breaking change to existing helm v2 clients.
We will consider however to create a chart that specifically supports helm3 and deprecate the helm2 version on a longer term.

Hey @pepov
Thanks for the reply! That seems like a much better course of action, I've updated the issue to match.

Yes please, this is a significant blocker for us, as we have security requirements that prohibit the use of Tiller, so we are limited to using Helm 3.

Currently using the logging operator to send Falco logs to Sumo Logic (thanks btw, works fantastic) and would also really appreciate this!

Hi, we are using Helm 3 as well because of the security issues associated with Tiller. This would be good to have.

Wow! Glad that the operator works great for you and that you are all looking to go forward with it. Of course we will add a helm3 compatible chart soon.
If you use the operator in production I would like to kindly ask you to add yourself to the list of adopters here:
https://github.com/banzaicloud/logging-operator/blob/master/ADOPTERS.md

We decided to simply add a flag createCustomResource=true that is compatible with helm v2 clients and you can use it with helm v3 by setting it to false.

Thanks @pepov
I can confirm that's working for me.


Making sets work with complex elements

Changes
Changed the definition of the function Complex.hashCode() to just create an ArrayList, add the real and imaginary parts to it, and then get the value returned by calling the hashing function on the ArrayList.
Fixing tests
One unexpected success in testing in test_complex_element (Trying #36).
test_complex_element (tests.datatypes.test_set.SetTests) ... unexpected success

Can someone help me out, I cannot seem to find a test that is failing in the smoke build.
======================================================================
UNEXPECTED SUCCESS: tests/datatypes/test_set.py::SetTests::test_complex_element
Unexpected success
----------------------------------------------------------------------
Ran 15944 tests in 513.00s
FAILED (expected failures=768, unexpected successes=1)

Where is the failure in the test that should have passed, just an unexpected success.