YARN-9643. Federation: Add subClusterID in nodes page of Router web

In nodes page of router web, there only are node info, No cluster id corresponding to the node.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
118
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

0
mvndep
47
Maven dependency ordering for branch

+1
mvninstall
1226
trunk passed

+1
compile
201
trunk passed

+1
checkstyle
59
trunk passed

+1
mvnsite
87
trunk passed

+1
shadedclient
876
branch has no errors when building and testing our client artifacts.

+1
javadoc
57
trunk passed

0
spotbugs
44
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
148
trunk passed

_ Patch Compile Tests _

0
mvndep
13
Maven dependency ordering for patch

+1
mvninstall
71
the patch passed

+1
compile
188
the patch passed

+1
javac
188
the patch passed

-0
checkstyle
49
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server: The patch generated 3 new + 100 unchanged - 0 fixed = 103 total (was 100)

+1
mvnsite
80
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
792
patch has no errors when building and testing our client artifacts.

+1
javadoc
45
the patch passed

+1
findbugs
156
the patch passed

_ Other Tests _

-1
unit
6867
hadoop-yarn-server-resourcemanager in the patch failed.

+1
unit
105
hadoop-yarn-server-router in the patch passed.

+1
asflicense
34
The patch does not generate ASF License warnings.

11265

Reason
Tests

Failed junit tests
hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesReservation

hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesNodes

hadoop.yarn.server.resourcemanager.rmapp.TestRMAppTransitions

hadoop.yarn.server.resourcemanager.TestRMEmbeddedElector

Subsystem
Report/Notes

Docker
Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1018/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1018

JIRA Issue
YARN-9643

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 57d2f1e82829 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / a79bdf7

Default Java
1.8.0_212

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-1018/1/artifact/out/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1018/1/artifact/out/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1018/1/testReport/

Max. process+thread count
860 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1018/1/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

add constant and test.
Thanks @goiri

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
35
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

0
mvndep
29
Maven dependency ordering for branch

+1
mvninstall
1077
trunk passed

+1
compile
173
trunk passed

+1
checkstyle
53
trunk passed

+1
mvnsite
84
trunk passed

+1
shadedclient
821
branch has no errors when building and testing our client artifacts.

+1
javadoc
55
trunk passed

0
spotbugs
46
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
137
trunk passed

_ Patch Compile Tests _

0
mvndep
11
Maven dependency ordering for patch

+1
mvninstall
64
the patch passed

+1
compile
166
the patch passed

+1
javac
166
the patch passed

-0
checkstyle
45
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server: The patch generated 10 new + 103 unchanged - 0 fixed = 113 total (was 103)

+1
mvnsite
72
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
725
patch has no errors when building and testing our client artifacts.

+1
javadoc
43
the patch passed

+1
findbugs
150
the patch passed

_ Other Tests _

-1
unit
4976
hadoop-yarn-server-resourcemanager in the patch failed.

+1
unit
106
hadoop-yarn-server-router in the patch passed.

+1
asflicense
32
The patch does not generate ASF License warnings.

8880

Reason
Tests

Failed junit tests
hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesNodes

Subsystem
Report/Notes

Docker
Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1018/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1018

JIRA Issue
YARN-9643

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 3699f50551fa 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 4848280

Default Java
1.8.0_212

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-1018/2/artifact/out/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1018/2/artifact/out/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1018/2/testReport/

Max. process+thread count
909 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1018/2/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
31
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

0
mvndep
14
Maven dependency ordering for branch

+1
mvninstall
1032
trunk passed

+1
compile
163
trunk passed

+1
checkstyle
46
trunk passed

+1
mvnsite
74
trunk passed

+1
shadedclient
730
branch has no errors when building and testing our client artifacts.

+1
javadoc
46
trunk passed

0
spotbugs
39
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
128
trunk passed

_ Patch Compile Tests _

0
mvndep
11
Maven dependency ordering for patch

+1
mvninstall
65
the patch passed

+1
compile
161
the patch passed

+1
javac
161
the patch passed

-0
checkstyle
42
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server: The patch generated 10 new + 103 unchanged - 0 fixed = 113 total (was 103)

+1
mvnsite
67
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
653
patch has no errors when building and testing our client artifacts.

+1
javadoc
42
the patch passed

+1
findbugs
143
the patch passed

_ Other Tests _

-1
unit
4958
hadoop-yarn-server-resourcemanager in the patch failed.

+1
unit
105
hadoop-yarn-server-router in the patch passed.

+1
asflicense
33
The patch does not generate ASF License warnings.

8565

Reason
Tests

Failed junit tests
hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesNodes

Subsystem
Report/Notes

Docker
Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1018/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1018

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux b4c70eec13e9 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / be80334

Default Java
1.8.0_212

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-1018/3/artifact/out/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1018/3/artifact/out/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1018/3/testReport/

Max. process+thread count
912 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1018/3/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
140
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

0
mvndep
19
Maven dependency ordering for branch

+1
mvninstall
1451
trunk passed

+1
compile
247
trunk passed

+1
checkstyle
69
trunk passed

+1
mvnsite
102
trunk passed

+1
shadedclient
1063
branch has no errors when building and testing our client artifacts.

+1
javadoc
71
trunk passed

0
spotbugs
53
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
176
trunk passed

_ Patch Compile Tests _

0
mvndep
18
Maven dependency ordering for patch

+1
mvninstall
92
the patch passed

+1
compile
220
the patch passed

+1
javac
220
the patch passed

-0
checkstyle
61
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server: The patch generated 10 new + 103 unchanged - 0 fixed = 113 total (was 103)

+1
mvnsite
99
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
971
patch has no errors when building and testing our client artifacts.

+1
javadoc
65
the patch passed

+1
findbugs
194
the patch passed

_ Other Tests _

-1
unit
5505
hadoop-yarn-server-resourcemanager in the patch failed.

-1
unit
25
hadoop-yarn-server-router in the patch failed.

+1
asflicense
31
The patch does not generate ASF License warnings.

10647

Reason
Tests

Failed junit tests
hadoop.yarn.server.resourcemanager.rmcontainer.TestRMContainerImpl

hadoop.yarn.server.resourcemanager.scheduler.fair.TestFairSchedulerPreemption

hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesNodes

hadoop.yarn.server.resourcemanager.webapp.TestRMWebServices

hadoop.yarn.server.resourcemanager.TestAppManager

Subsystem
Report/Notes

Docker
Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1018/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1018

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux a8dabdb3b53e 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 4e66cb9

Default Java
1.8.0_212

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-1018/4/artifact/out/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1018/4/artifact/out/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1018/4/artifact/out/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1018/4/testReport/

Max. process+thread count
862 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1018/4/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
47
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

0
mvndep
18
Maven dependency ordering for branch

+1
mvninstall
1087
trunk passed

+1
compile
175
trunk passed

+1
checkstyle
55
trunk passed

+1
mvnsite
87
trunk passed

+1
shadedclient
835
branch has no errors when building and testing our client artifacts.

+1
javadoc
57
trunk passed

0
spotbugs
46
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
143
trunk passed

_ Patch Compile Tests _

0
mvndep
14
Maven dependency ordering for patch

+1
mvninstall
70
the patch passed

+1
compile
169
the patch passed

+1
javac
169
the patch passed

-0
checkstyle
47
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server: The patch generated 10 new + 103 unchanged - 0 fixed = 113 total (was 103)

+1
mvnsite
74
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
749
patch has no errors when building and testing our client artifacts.

+1
javadoc
52
the patch passed

+1
findbugs
156
the patch passed

_ Other Tests _

-1
unit
5016
hadoop-yarn-server-resourcemanager in the patch failed.

+1
unit
108
hadoop-yarn-server-router in the patch passed.

+1
asflicense
35
The patch does not generate ASF License warnings.

9026

Reason
Tests

Failed junit tests
hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesNodes

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1018/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1018

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux f3df08fec98a 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / c0a0c35

Default Java
1.8.0_212

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-1018/5/artifact/out/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1018/5/artifact/out/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1018/5/testReport/

Max. process+thread count
883 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1018/5/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
48
Docker mode activated.

_ Prechecks _

+1
dupname
1
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

0
mvndep
12
Maven dependency ordering for branch

+1
mvninstall
1033
trunk passed

+1
compile
167
trunk passed

+1
checkstyle
49
trunk passed

+1
mvnsite
82
trunk passed

+1
shadedclient
739
branch has no errors when building and testing our client artifacts.

+1
javadoc
48
trunk passed

0
spotbugs
41
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
131
trunk passed

_ Patch Compile Tests _

0
mvndep
13
Maven dependency ordering for patch

+1
mvninstall
66
the patch passed

+1
compile
177
the patch passed

+1
javac
177
the patch passed

-0
checkstyle
27
The patch fails to run checkstyle in hadoop-yarn-server

+1
mvnsite
73
the patch passed

+1
whitespace
2
The patch has no whitespace issues.

+1
shadedclient
688
patch has no errors when building and testing our client artifacts.

+1
javadoc
43
the patch passed

-1
findbugs
21
hadoop-yarn-server-router in the patch failed.

_ Other Tests _

-1
unit
4813
hadoop-yarn-server-resourcemanager in the patch failed.

-1
unit
21
hadoop-yarn-server-router in the patch failed.

+1
asflicense
25
The patch does not generate ASF License warnings.

8381

Reason
Tests

Failed junit tests
hadoop.yarn.server.resourcemanager.scheduler.capacity.TestCapacityScheduler

hadoop.yarn.server.resourcemanager.TestResourceTrackerService

hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesNodes

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1018/6/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1018

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux c918c66350e3 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 17e8cf5

Default Java
1.8.0_212

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-1018/6/artifact/out//home/jenkins/jenkins-slave/workspace/hadoop-multibranch_PR-1018/out/maven-patch-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server.txt

findbugs
https://builds.apache.org/job/hadoop-multibranch/job/PR-1018/6/artifact/out/patch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1018/6/artifact/out/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1018/6/artifact/out/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1018/6/testReport/

Max. process+thread count
924 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1018/6/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
43
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

0
mvndep
14
Maven dependency ordering for branch

+1
mvninstall
1098
trunk passed

+1
compile
157
trunk passed

+1
checkstyle
49
trunk passed

+1
mvnsite
71
trunk passed

+1
shadedclient
754
branch has no errors when building and testing our client artifacts.

+1
javadoc
54
trunk passed

0
spotbugs
37
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
132
trunk passed

_ Patch Compile Tests _

0
mvndep
11
Maven dependency ordering for patch

+1
mvninstall
65
the patch passed

+1
compile
143
the patch passed

+1
javac
143
the patch passed

-0
checkstyle
44
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server: The patch generated 10 new + 103 unchanged - 0 fixed = 113 total (was 103)

+1
mvnsite
61
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
709
patch has no errors when building and testing our client artifacts.

+1
javadoc
40
the patch passed

+1
findbugs
137
the patch passed

_ Other Tests _

-1
unit
4883
hadoop-yarn-server-resourcemanager in the patch failed.

-1
unit
16
hadoop-yarn-server-router in the patch failed.

+1
asflicense
30
The patch does not generate ASF License warnings.

8548

Reason
Tests

Failed junit tests
hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesNodes

hadoop.yarn.server.resourcemanager.scheduler.fair.TestFairSchedulerPreemption

hadoop.yarn.server.resourcemanager.scheduler.capacity.TestNodeLabelContainerAllocation

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1018/7/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1018

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux d7a782231a87 4.4.0-157-generic #185-Ubuntu SMP Tue Jul 23 09:17:01 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 70b4617

Default Java
1.8.0_212

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-1018/7/artifact/out/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1018/7/artifact/out/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1018/7/artifact/out/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1018/7/testReport/

Max. process+thread count
895 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1018/7/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
43
Docker mode activated.

_ Prechecks _

+1
dupname
1
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

0
mvndep
13
Maven dependency ordering for branch

+1
mvninstall
1188
trunk passed

+1
compile
178
trunk passed

+1
checkstyle
50
trunk passed

+1
mvnsite
72
trunk passed

+1
shadedclient
787
branch has no errors when building and testing our client artifacts.

+1
javadoc
51
trunk passed

0
spotbugs
43
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
156
trunk passed

_ Patch Compile Tests _

0
mvndep
13
Maven dependency ordering for patch

+1
mvninstall
81
the patch passed

+1
compile
172
the patch passed

+1
javac
172
the patch passed

-0
checkstyle
53
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server: The patch generated 10 new + 103 unchanged - 0 fixed = 113 total (was 103)

+1
mvnsite
73
the patch passed

+1
whitespace
1
The patch has no whitespace issues.

+1
shadedclient
795
patch has no errors when building and testing our client artifacts.

+1
javadoc
52
the patch passed

+1
findbugs
165
the patch passed

_ Other Tests _

-1
unit
5054
hadoop-yarn-server-resourcemanager in the patch failed.

+1
unit
104
hadoop-yarn-server-router in the patch passed.

+1
asflicense
30
The patch does not generate ASF License warnings.

9165

Reason
Tests

Failed junit tests
hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesNodes

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1018/8/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1018

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux a235017192ce 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 397a563

Default Java
1.8.0_212

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-1018/8/artifact/out/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1018/8/artifact/out/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1018/8/testReport/

Max. process+thread count
923 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1018/8/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
65
Docker mode activated.

_ Prechecks _

+1
dupname
1
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

0
mvndep
12
Maven dependency ordering for branch

+1
mvninstall
1049
trunk passed

+1
compile
144
trunk passed

+1
checkstyle
46
trunk passed

+1
mvnsite
63
trunk passed

+1
shadedclient
750
branch has no errors when building and testing our client artifacts.

+1
javadoc
47
trunk passed

0
spotbugs
36
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
130
trunk passed

_ Patch Compile Tests _

0
mvndep
11
Maven dependency ordering for patch

+1
mvninstall
67
the patch passed

+1
compile
139
the patch passed

+1
javac
139
the patch passed

-0
checkstyle
42
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server: The patch generated 10 new + 103 unchanged - 0 fixed = 113 total (was 103)

+1
mvnsite
58
the patch passed

+1
whitespace
1
The patch has no whitespace issues.

+1
shadedclient
711
patch has no errors when building and testing our client artifacts.

+1
javadoc
47
the patch passed

+1
findbugs
146
the patch passed

_ Other Tests _

-1
unit
5164
hadoop-yarn-server-resourcemanager in the patch failed.

-1
unit
16
hadoop-yarn-server-router in the patch failed.

+1
asflicense
26
The patch does not generate ASF License warnings.

8772

Reason
Tests

Failed junit tests
hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesNodes

hadoop.yarn.server.resourcemanager.ahs.TestRMApplicationHistoryWriter

hadoop.yarn.server.resourcemanager.scheduler.fair.TestFairSchedulerPreemption

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1018/9/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1018

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 13e5189b260d 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / e356e4f

Default Java
1.8.0_222

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-1018/9/artifact/out/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1018/9/artifact/out/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1018/9/artifact/out/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1018/9/testReport/

Max. process+thread count
883 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1018/9/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
137
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

0
mvndep
33
Maven dependency ordering for branch

+1
mvninstall
1471
trunk passed

+1
compile
212
trunk passed

+1
checkstyle
73
trunk passed

+1
mvnsite
91
trunk passed

+1
shadedclient
953
branch has no errors when building and testing our client artifacts.

+1
javadoc
51
trunk passed

0
spotbugs
42
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
136
trunk passed

_ Patch Compile Tests _

0
mvndep
13
Maven dependency ordering for patch

+1
mvninstall
72
the patch passed

+1
compile
153
the patch passed

+1
javac
153
the patch passed

-0
checkstyle
50
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server: The patch generated 10 new + 104 unchanged - 0 fixed = 114 total (was 104)

+1
mvnsite
65
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
870
patch has no errors when building and testing our client artifacts.

+1
javadoc
49
the patch passed

-1
findbugs
19
hadoop-yarn-server-router in the patch failed.

_ Other Tests _

-1
unit
5250
hadoop-yarn-server-resourcemanager in the patch failed.

-1
unit
19
hadoop-yarn-server-router in the patch failed.

+1
asflicense
31
The patch does not generate ASF License warnings.

9870

Reason
Tests

Failed junit tests
hadoop.yarn.server.resourcemanager.metrics.TestCombinedSystemMetricsPublisher

hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesNodes

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1018/10/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1018

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux e683320ffeb6 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 094d736

Default Java
1.8.0_222

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-1018/10/artifact/out/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server.txt

findbugs
https://builds.apache.org/job/hadoop-multibranch/job/PR-1018/10/artifact/out/patch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1018/10/artifact/out/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1018/10/artifact/out/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1018/10/testReport/

Max. process+thread count
914 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1018/10/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
40
Docker mode activated.

_ Prechecks _

+1
dupname
1
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

0
mvndep
12
Maven dependency ordering for branch

+1
mvninstall
1123
trunk passed

+1
compile
144
trunk passed

+1
checkstyle
44
trunk passed

+1
mvnsite
62
trunk passed

+1
shadedclient
739
branch has no errors when building and testing our client artifacts.

+1
javadoc
49
trunk passed

0
spotbugs
37
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
124
trunk passed

_ Patch Compile Tests _

0
mvndep
11
Maven dependency ordering for patch

+1
mvninstall
67
the patch passed

+1
compile
146
the patch passed

+1
javac
146
the patch passed

-0
checkstyle
42
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server: The patch generated 10 new + 103 unchanged - 0 fixed = 113 total (was 103)

+1
mvnsite
60
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
718
patch has no errors when building and testing our client artifacts.

+1
javadoc
40
the patch passed

-1
findbugs
14
hadoop-yarn-server-router in the patch failed.

_ Other Tests _

-1
unit
4709
hadoop-yarn-server-resourcemanager in the patch failed.

-1
unit
15
hadoop-yarn-server-router in the patch failed.

+1
asflicense
26
The patch does not generate ASF License warnings.

8315

Reason
Tests

Failed junit tests
hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesNodes

hadoop.yarn.server.resourcemanager.scheduler.capacity.TestIncreaseAllocationExpirer

hadoop.yarn.server.resourcemanager.scheduler.capacity.TestCapacitySchedulerQueueACLs

hadoop.yarn.server.resourcemanager.scheduler.capacity.TestCapacitySchedulerSchedulingRequestUpdate

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1018/11/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1018

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 0f25c00c4c1f 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 69ddb36

Default Java
1.8.0_212

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-1018/11/artifact/out/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server.txt

findbugs
https://builds.apache.org/job/hadoop-multibranch/job/PR-1018/11/artifact/out/patch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1018/11/artifact/out/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1018/11/artifact/out/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1018/11/testReport/

Max. process+thread count
918 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1018/11/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
76
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

0
mvndep
12
Maven dependency ordering for branch

+1
mvninstall
1211
trunk passed

+1
compile
162
trunk passed

+1
checkstyle
54
trunk passed

+1
mvnsite
72
trunk passed

+1
shadedclient
895
branch has no errors when building and testing our client artifacts.

+1
javadoc
52
trunk passed

0
spotbugs
41
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
139
trunk passed

_ Patch Compile Tests _

0
mvndep
13
Maven dependency ordering for patch

+1
mvninstall
71
the patch passed

+1
compile
153
the patch passed

+1
javac
153
the patch passed

-0
checkstyle
47
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server: The patch generated 10 new + 103 unchanged - 0 fixed = 113 total (was 103)

+1
mvnsite
68
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
845
patch has no errors when building and testing our client artifacts.

+1
javadoc
55
the patch passed

-1
findbugs
16
hadoop-yarn-server-router in the patch failed.

_ Other Tests _

-1
unit
5275
hadoop-yarn-server-resourcemanager in the patch failed.

-1
unit
17
hadoop-yarn-server-router in the patch failed.

+1
asflicense
29
The patch does not generate ASF License warnings.

9404

Reason
Tests

Failed junit tests
hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesNodes

Subsystem
Report/Notes

Docker
Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1018/12/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1018

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux b2ea5578f75a 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 3329257

Default Java
1.8.0_222

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-1018/12/artifact/out/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server.txt

findbugs
https://builds.apache.org/job/hadoop-multibranch/job/PR-1018/12/artifact/out/patch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1018/12/artifact/out/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1018/12/artifact/out/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1018/12/testReport/

Max. process+thread count
800 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1018/12/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
33
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

0
mvndep
13
Maven dependency ordering for branch

+1
mvninstall
1228
trunk passed

+1
compile
185
trunk passed

+1
checkstyle
57
trunk passed

+1
mvnsite
74
trunk passed

+1
shadedclient
880
branch has no errors when building and testing our client artifacts.

+1
javadoc
53
trunk passed

0
spotbugs
39
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
139
trunk passed

_ Patch Compile Tests _

0
mvndep
13
Maven dependency ordering for patch

+1
mvninstall
68
the patch passed

+1
compile
154
the patch passed

+1
javac
154
the patch passed

-0
checkstyle
52
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server: The patch generated 10 new + 103 unchanged - 0 fixed = 113 total (was 103)

+1
mvnsite
68
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
806
patch has no errors when building and testing our client artifacts.

+1
javadoc
48
the patch passed

+1
findbugs
152
the patch passed

_ Other Tests _

-1
unit
4884
hadoop-yarn-server-resourcemanager in the patch failed.

-1
unit
17
hadoop-yarn-server-router in the patch failed.

+1
asflicense
30
The patch does not generate ASF License warnings.

8979

Reason
Tests

Failed junit tests
hadoop.yarn.server.resourcemanager.rmapp.TestApplicationLifetimeMonitor

hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesNodes

hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesAppsCustomResourceTypes

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1018/13/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1018

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 537c3143015a 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 915cbc9

Default Java
1.8.0_222

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-1018/13/artifact/out/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1018/13/artifact/out/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1018/13/artifact/out/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1018/13/testReport/

Max. process+thread count
812 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1018/13/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.


Update Kotlin and open google play link

Updated Kotlin version: 1.5.0
Added open Google Play: If app doesn't exist in device, opens Google Play with the app id

@goops17 I don't actively maintain this package. If you want, I can add you to pub.dev so you can push updates to it.

@Akora-IngDKB that would be cool, I can maintain it. Can you please add<EMAIL_ADDRESS>

@goops17 I will go ahead and merge this PR. You should be able to push the update to pub.dev.


Create Understanding Cost Estimates in Control Portal

Digital Team: Please DO NOT merge until we conduct an internal feedback gather and have approval from other teams.
Create  Understanding Cost Estimates in Control Portal KB, seeking for feedback from teams

Digital team: It is good to go for merging, thank you

Fixed the issues

@gavin-lai looks good.  @srveit this can be merged


(GH-133) Added more QDE FAQs

Resolves #133 on adding more FAQ's to QDE main page.

Merging so we have this ready for Twitch Stream! 🚀


add yarn lockfile

(prompted by this post)
In my naive testing, Mocha is installable via Yarn from a working copy (v0.17.10), and all tests pass under Node.js v7.2.0.  The next step will be to add it to Travis-CI & AppVeyor (assuming the latter has support).
I know of no reason why we shouldn't publish a yarn.lock file with the next release.

Closing this as we may want to use npm's lockfiles instead.  It doesn't make sense to use both.  Let's take a wait-and-see approach to npm.


Writes are not atomic on Linux

In order to be atomic on all file systems on Linux the file descriptor of the temporary file must be fsynced before moved. Otherwise data may not have reached disk.
Some file systems sync data before move while others (such as UBIFS) do not:
http://www.linux-mtd.infradead.org/faq/ubifs.html#L_atomic_change
g_file_set_contents is a good source on how to properly write files atomically:
https://github.com/GNOME/glib/blob/1bda4db213bf776143c6d68c4580fd580b1eab5a/glib/gfileutils.c#L1175

In order to be atomic across filesystems on Linux the file descriptor of the temporary file must be fsynced before moved.

Can you even be atomic in that case? I don’t think you can atomically move over filesystem borders.

That was a really bad choice of words on my part. What I really meant by "atomic across filesystems" was "atomic on all different kinds of file systems".
Some file systems make sure that moving a file from A to B makes sure A is first synced to disk. But this is just a nice feature for mitigating a common bug in many implementations and many file systems do not do this. I believe this implementation contain this bug since it doesn't call tmpfile.sync_all() before self.commit() in AtomicFile::write`, and I can't find any guarantees that a file is synced on drop. It seems the only thing that happens is close is called on the file descriptor.

There are plenty of fixes in python-atomicwrites that have not been ported to this crate. This is one of them.

0.2.5 released


Connection establish failure on one unsupported cipher suite

Hello in org.bouncycastle.jsse.provider.ProvSSLContextSpi#isSupportedCipherSuites you fail in case one unsupported cipher suite is found among provided array of cipher suites, instead of ignoring it. This causes an issue to us, in case of creating SSLSocket with specific array of cipher suites provided by user.
Version of library we use: 1.60
Example stack trace:
java.lang.IllegalArgumentException: 'cipherSuites' cannot be null, or contain unsupported cipher suites
        at org.bouncycastle.jsse.provider.ProvSSLParameters.setCipherSuites(Unknown Source)
        at org.bouncycastle.jsse.provider.ProvSSLSocketWrap.setEnabledCipherSuites(Unknown Source)
        at org.apache.http.conn.ssl.SSLConnectionSocketFactory.createLayeredSocket(SSLConnectionSocketFactory.java:386)
        at org.apache.http.conn.ssl.SSLConnectionSocketFactory.connectSocket(SSLConnectionSocketFactory.java:355)
        at org.apache.http.impl.conn.DefaultHttpClientConnectionOperator.connect(DefaultHttpClientConnectionOperator.java:142)
        at org.apache.http.impl.conn.PoolingHttpClientConnectionManager.connect(PoolingHttpClientConnectionManager.java:373)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.lang.reflect.Method.invoke(Method.java:498)

Thanks, we've updated the code to tolerate unrecognised cipher suites, which is compatible with latest JDK behaviour. Note that null or "" values are still not allowed and will result in an exception (same as JDK).


Fixed python 3 compatibility

Will isolate this commit into a separate branch, since I'll be creating multiple pull requests


Broken Typescript types for createStorage -- forces all object keys to be the same type

Please correct me if I'm misunderstanding something here.
I see the type definitions for createStorage (line 42 in storage.ts)
This was my first attempt at using the library:
type MinimalTestType = {
  foo: string
  num: number
}
const [localStore, setLocalStore] = createLocalStorage<MinimalTestType>()
setLocalStore("foo", "asdf") // works
setLocalStore("num", 1) // type error, must be string

I expected it to work just like Solid Store. What happened?
Well, for one thing, the type parameter I passed in (MinimalTestType) was used as the type of the options object rather than the type of the object I am storing. That was already counter-intuitive, so next I tried the override createStorage<O, T> which lets you pass both the option type and the type of data to be stored. That results in a different problem:
const [localStore, setLocalStore] = createLocalStorage<{}, MinimalTestType>()
setLocalStore("foo", "asdf") // error -- expected "MinimalTestType"
setLocalStore("num", 1) // error -- expected "MinimalTestType"

Every single key of the object is now expected to match the type parameter. This does not match the API of the default Solid Store. I was expecting it to hold a single object of type MinimalTestType, use the setter to update it, and get the benefit of automatically writing the object to localStorage on changes. Please let me know if I'm misunderstanding how this library should be used. If you're open to contributions I'd like to take a stab at improving these type definitions to more closely match the calling conventions of Solid Store.

I ended up rolling my own version which follows the semantics and behavior of createStore almost exactly.
import { createStore, Store } from 'solid-js/store';

/**
 * Identical API to Solid Store, but wrapped with read/write to/from localStorage
 *
 * @param key unique string identifier to use for localStorage
 * @param storeArg same as Solid Store
 * @param options same as Solid Store
 * @returns void
 */
export default function createLocalStore<T extends object>(
  key: string,
  storeArg: T | Store<T>,
  options?: {
    name?: string;
  },
): ReturnType<typeof createStore<T>> {
  // Fetch a previous value from localStorage, if it exists
  const localStorageRaw = localStorage.getItem(key)
  const localStorageParsed = localStorageRaw === null ? null : JSON.parse(localStorageRaw) as T
  const initialValue = localStorageParsed === null ? storeArg : localStorageParsed

  // Initialize the store with EITHER a saved value from localStorage,
  // or (as a fallback) the initial value passed in from storeArg
  // (localStorage always takes precedence if present)
  const [store, setStore] = createStore(initialValue, options)

  // Wrap the setter in a function that also writes to localStorage
  const setLocalStore: typeof setStore = (...args: any[]) => {
    const retVal = setStore(...(args as [any])) // ew https://stackoverflow.com/a/72450001
    localStorage.setItem(key, JSON.stringify(store))
    return retVal // void, but left in case of future changes
  }

  // Same return type as `createStore`
  return [store, setLocalStore]
}

The browser Storage API requires keys to be string. You can use JSON.stringify as serializer and JSON.parse as deserializer in your options, then it should be supported.

I think those two (one in solid-primitives and @nathanbabcock's implementation) are completely different APIs. It's not only about the types. createLocalStorage in solid-primitives is more of a "reactive localStorage" with matching API, and the @nathanbabcock's createLocalStore is a solid's store that saves itself to localStorage. Similar to the one here.
So the types for our primitive aren't wrong. Each key-value pair is a different key-value pair in the storage. They reflect the localStorage API, but let you extend it with additional options for serialization and deserialization.
But that also means that we are missing an actual createLocalStore or createStorageStore that would let you just save the entirety of it's value under a single key in the storage, with utilizing fine-grained, single-property updates, and the rest of the store API. In a sense, it could be similar to the new storage option in the solid's createResource.

I think @thetarnav is totally right. If you think about createLocalStorage in solid-primitives as a reactive wrapper around localStorage, it makes perfect sense as-is. I was thinking of something totally different.
Thanks for the link to the Solidjs Todo example. I hadn't seen that one and the implementation is a little different (and cleaner) than mine. Notably they use createEffect instead of wrapping the setter.
I realize now that what I'm thinking of is a whole different can of worms. You mentioned "fine-grained, single-property updates" which makes me wonder whether re-serializing the entire store at every change is wasteful -- perhaps there should be one key-value entry in localStorage per property (including deeper levels of nesting, whose keys could be named with a path-like syntax). Implementing that would be tricky, if it's even worth doing.
Thank you for helping me clear up my confusion, it leaves me with some food for thought.


Upload code coverage stats only on deploy-build. Changed deploy-build to LTS JDK

Codecov Report

Merging #2485 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #2485      +/-   ##
============================================
+ Coverage     95.04%   95.04%   +<.01%
  Complexity     5400     5400
============================================
  Files            89       89
  Lines         12763    12761       -2
  Branches       1586     1582       -4
============================================
- Hits          12130    12129       -1
  Misses          454      454
+ Partials        179      178       -1

Impacted Files
Coverage Δ
Complexity Δ

...n/java/io/vavr/collection/HashArrayMappedTrie.java
97.01% <0%> (-0.02%)
1% <0%> (ø)

src/main/java/io/vavr/Value.java
93.83% <0%> (+0.41%)
145% <0%> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68817b2...8881dbb. Read the comment docs.


Update id-protection-dashboard.md

Fix of formatting in "Confirmed safe"

Thanks, @michaelmsonne!

Allways! Happy tobhelp when see it! 👌


RC1 to RC2 upgrade guide?

Was wondering if anyone knew if an RC1 to RC2 upgrade guide had been posted yet? I think MS said one would be forthcoming. Looking forward to getting on RC2! Thanks!!

https://docs.asp.net/en/latest/migration/rc1-to-rc2.html

Thank you!


Dead link to Azure Front Door Standard/Premium preview

The link to the docs for AFD Standard/Premium is dead.
(/standard-premium/overview.md)

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: dbadca96-7341-36d0-8a38-1c6a5c96b22d
Version Independent ID: 2fad91dc-25f8-0c7a-c21d-93986ec51145
Content: Azure Front Door
Content Source: articles/frontdoor/front-door-overview.md
Service: frontdoor
GitHub Login: @duongau
Microsoft Alias: duau

@felixtsem5, Thanks for reaching out. We will investigate and update this thread.

@felixtsem5, PR has been submitted successfully. It will be merged soon after the review.

@felixtsem5, we are closing this issue for now. If there are further questions regarding this matter, please reply and we will gladly continue the discussion.


DDA Client API features

I can upload data to DagsHub through python API. Can we use python API to remove files and search files (i.e. glob package) as well?

Hi Edward! Thanks for checking out the client!
We don't have any API for deleting files on the backend right now, and for client to be able to do that we'll have to do that first.
Searching is an easier task, and it can actually be accomplished right now with install_hooks(). You can use the built-in python glob.glob() to search and it will work, because install_hooks() makes a lot of builtin os functions aware of the DagsHub repo.
Caveat is you need to have the git repository cloned. No need to pull the data with dvc though :)
import glob

from dagshub.streaming import install_hooks
install_hooks(project_root="<path to the repo>")  # no need to specify project_root if cwd is in the repo

print(glob.glob("**/*.jpg", recursive=True))


"Run at Startup" not working

Microsoft PowerToys version
0.81.1
Installation method
Microsoft Store
Running as admin
Yes
Area(s) with issue?
Settings
Steps to reproduce
"Run at Startup" toggle doesn't work. I reinstalled the app but the outcome didn't change. When I change the toggle to "On", no startup entry is created and the app doesn't run automatically at startup. I have to open in manually.
✔ Expected Behavior
Should create a startup entry and run automatically at startup.
❌ Actual Behavior
Doesn't create a startup entry and doesn't run automatically at startup.
Other Software
No response

Resolved v0.82.0


Index out of Range (Maximum position of Slider)

Error Description:
Whenever the slider move to the maximum value of the slider. The apps will be Crashed and the error message is Index out of Range.
Swift/ContiguousArrayBuffer.swift:600: Fatal error: Index out of range
Something went wrong with in this thread line code 67 in the CalculatorTableViewController:
    private func observeForm() {
        $initialDateOfInvestmentIndex.sink { [weak self] (index) in
            ///Guarding the index cannot be nil then convert the Integer  of initialDateOfInvestmentIndex to Float (Data Type)
            guard let index = index else { return }
            self?.dateSlider.value = index.floatValue

            ///Updating the Intial Date of Investment Value by Moving the Slider
            if let dateString = self?.asset?.timeSeriesMonthlyAdjusted.getMonthInfos()[index].date.MMYYFormat {
                self?.initialDateOfInvestmentTextField.text = dateString
            }

            ///Printing index number from the Select Date page
            //print(index)
        }.store(in: &subscribers)
    }

Solved
Bug Description:
Whenever the slider move to the maximum value of the slider. The apps will be Crashed and the error message is Index out of Range.
Identified Cause:
Something went wrong with in this thread line code 67 in the CalculatorTableViewController, but the problem is in the file CalculatorTableViewController in line 53 - 59. The Slider count value is Integer but the Integer has been converted to Float Data Type (meaning the Float Value will be rounded up and rounded up value is doesn't exist in the index) so the maximum output / position is cannot determined by the system and trick the Slider the Index is Out of Range.
    ///Setup the Numbers of Elements in Slider (Value)
    private func setupDateSlider() {
        ///Getting the Count Index of Asset Monthly Data then Convert the Value of Count Data to Float
        if let count = asset?.timeSeriesMonthlyAdjusted.getMonthInfos().count {
            dateSlider.maximumValue = count.floatValue
        }
    }

Bug Fix:
To address this issue, the variable count needs to be reduced by 1 (by making another new variable inside the count closure the pass the new var value to the maximumValue methods below). The details can be seen as below:
    ///Setup the Numbers of Elements in Slider (Value)
    private func setupDateSlider() {
        ///Getting the Count Index of Asset Monthly Data then Convert the Value of Count Data to Float
        if let count = asset?.timeSeriesMonthlyAdjusted.getMonthInfos().count {
            let dateSliderCount = count - 1 ///Index Out of Range Bug Fix (Without this the Slider cannot be in Maximum Position)
            dateSlider.maximumValue = dateSliderCount.floatValue
        }
    }

Updates the UI for Placeholder to be 0.0 and so on.
Removing redundant animation by clearing the Search Bar after navigate backs to the Main Page
Disable TableView scroll and activates when the user is Search Result appearing


Segmentation Fault with calibrate.py on BW1097

When running calibrate.py on BW1097 the system seg faults after having stepped through checking out the stereo pairs for visualization.
This seems to be similar to the XLink issue that @VanDavv was seeing when running DepthAI on Raspberry Pi:
python3 calibrate.py -s 2.2 -ih
Using Custom Calibration File: depthai.calib
Using Arguments= {'count': 1, 'square_size_cm': 2.2, 'image_op': 'modify', 'mode': ['capture', 'process'], 'config_overwrite': None, 'board': None, 'field_of_view': 71.86, 'baseline': 9.0, 'swap_lr': True, 'dev_debug': None, 'invert_v': False, 'invert_h': True}
Starting image capture. Press the [ESC] key to abort.
Will take 13 total images, 1 per each polygon.
XLink initialized.
Sending device firmware "cmd_file": /home/pi/Desktop/depthai/depthai.cmd
Successfully connected to device.
Loading config file
Attempting to open stream config_d2h
Successfully opened stream config_d2h with ID #0!
Closing stream config_d2h: ...
Closing stream config_d2h: DONE.
WARNING: Version (dev) does not match (c722ebde932d6627463321816a5654b5be6069e1 & b8cebab238c71263c80087051a70c8165f95d374)
EEPROM data: valid (v3)
watchdog started 1000
  Board name     : BW1097
  Board rev      : R1M1E2
  HFOV L/R       : 71.86 deg
  HFOV RGB       : 68.7938 deg
  L-R   distance : 9 cm
  L-RGB distance : 2 cm
  L/R swapped    : yes
  L/R crop region: center
  Calibration homography:
    1.015737,    0.005940,  -21.193869,
   -0.002906,    1.014818,  -16.099894,
    0.000003,    0.000003,    1.000000,
CNN configurations read: /home/pi/Desktop/depthai/resources/nn/mobilenet-ssd/mobilenet-ssd.json
config_h2d json:
{"_board":{"_homography_right_to_left":[1.0165388584136963,0.0061319186352193356,-20.880294799804688,-0.0021309051662683487,1.0140399932861328,-16.308542251586914,5.620724095933838e-06,3.0937208066461608e-06,1.0]},"_load_inBlob":true,"_pipeline":{"_streams":[{"max_fps":10.0,"name":"left"},{"max_fps":10.0,"name":"right"},{"name":"meta_d2h"}]},"ai":{"calc_dist_to_bb":false},"board":{"clear-eeprom":false,"left_fov_deg":71.86000061035156,"left_to_rgb_distance_m":0.0,"left_to_right_distance_m":0.09000000357627869,"name":"","override-eeprom":true,"revision":"","rgb_fov_deg":69.0,"stereo_center_crop":true,"store-to-eeprom":false,"swap-left-and-right-cameras":true},"depth":{"padding_factor":0.30000001192092896}}
Attempting to open stream config_h2d
Successfully opened stream config_h2d with ID #1!
Writing 1000 bytes to config_h2d
!!! XLink write successful: config_h2d (1000)
Closing stream config_h2d: ...
Closing stream config_h2d: DONE.
Read: 14514560
Attempting to open stream inBlob
Successfully opened stream inBlob with ID #1!
Writing 14514560 bytes to inBlob
!!! XLink write successful: inBlob (14514560)
Closing stream inBlob: ...
Closing stream inBlob: DONE.
depthai: done sending Blob file /home/pi/Desktop/depthai/resources/nn/mobilenet-ssd/mobilenet-ssd.blob
Attempting to open stream outBlob
Successfully opened stream outBlob with ID #0!
Closing stream outBlob: ...
Closing stream outBlob: DONE.
CNN input width: 300
CNN input height: 300
CNN input num channels: 3
Host stream start:meta_d2h
Opening stream for read: meta_d2h
Attempting to open stream meta_d2h
Successfully opened stream meta_d2h with ID #1!
Starting thread for stream: meta_d2h
Started thread for stream: meta_d2h
Host stream start:left
Opening stream for read: left
Attempting to open stream left
Successfully opened stream left with ID #2!
Starting thread for stream: left
Host stream start:right
Opening stream for read: right
Attempting to open stream right
Started thread for stream: left
Successfully opened stream right with ID #0!
Starting thread for stream: right
Started thread for stream: right
depthai: INIT OK!
py: Saved image as: left_p0_0.png
py: Saved image as: right_p0_0.png
py: Saved image as: left_p1_1.png
py: Saved image as: right_p1_1.png
py: Saved image as: left_p2_2.png
py: Saved image as: right_p2_2.png
py: Saved image as: left_p3_3.png
py: Saved image as: right_p3_3.png
py: Saved image as: left_p4_4.png
py: Saved image as: right_p4_4.png
py: Saved image as: left_p5_5.png
py: Saved image as: right_p5_5.png
py: Saved image as: left_p6_6.png
py: Saved image as: right_p6_6.png
py: Saved image as: left_p7_7.png
py: Saved image as: right_p7_7.png
py: Saved image as: left_p8_8.png
py: Saved image as: right_p8_8.png
py: Saved image as: left_p9_9.png
py: Saved image as: right_p9_9.png
py: Saved image as: left_p10_10.png
py: Saved image as: right_p10_10.png
py: Saved image as: left_p11_11.png
py: Saved image as: right_p11_11.png
py: Saved image as: left_p12_12.png
py: Saved image as: right_p12_12.png
Starting image processing

Attempting to read images for left camera from dir: dataset/left/
Attempting to read images for right camera from dir: dataset/right/
Finding chessboard corners for left_p0_0.png and right_p0_0.png...
	[OK]. Took 0 seconds.
Finding chessboard corners for left_p10_10.png and right_p10_10.png...
	[OK]. Took 0 seconds.
Finding chessboard corners for left_p11_11.png and right_p11_11.png...
	[OK]. Took 0 seconds.
Finding chessboard corners for left_p12_12.png and right_p12_12.png...
	[OK]. Took 0 seconds.
Finding chessboard corners for left_p1_1.png and right_p1_1.png...
	[OK]. Took 0 seconds.
Finding chessboard corners for left_p2_2.png and right_p2_2.png...
	[OK]. Took 0 seconds.
Finding chessboard corners for left_p3_3.png and right_p3_3.png...
	[OK]. Took 0 seconds.
Finding chessboard corners for left_p4_4.png and right_p4_4.png...
	[OK]. Took 0 seconds.
Finding chessboard corners for left_p5_5.png and right_p5_5.png...
	[OK]. Took 0 seconds.
Finding chessboard corners for left_p6_6.png and right_p6_6.png...
	[OK]. Took 0 seconds.
Finding chessboard corners for left_p7_7.png and right_p7_7.png...
	[OK]. Took 0 seconds.
Finding chessboard corners for left_p8_8.png and right_p8_8.png...
	[OK]. Took 0 seconds.
Finding chessboard corners for left_p9_9.png and right_p9_9.png...
	[OK]. Took 0 seconds.
13 of 13 images being used for calibration
[OK] Calibration successful w/ RMS error=0.20734621552364482
Rectifying Homography...
[[ 1.0180424e+00  5.1960642e-03 -2.1386580e+01]
 [-1.8764788e-03  1.0149957e+00 -1.6575731e+01]
 [ 5.9488111e-06  1.8393540e-06  1.0000000e+00]]
Calibration file written to ./resources/depthai.calib.
	Took 15 seconds to run image processing.

Rectifying dataset for visual inspection
Using Homography from file, with values:
[[ 1.0180424e+00  5.1960642e-03 -2.1386580e+01]
 [-1.8764788e-03  1.0149957e+00 -1.6575731e+01]
 [ 5.9488111e-06  1.8393540e-06  1.0000000e+00]]
Average Epipolar Error: 2.9739750158413183
Displaying Stereo Pair for visual inspection. Press the [ESC] key to exit.
Displaying Stereo Pair for visual inspection. Press the [ESC] key to exit.
Displaying Stereo Pair for visual inspection. Press the [ESC] key to exit.
Displaying Stereo Pair for visual inspection. Press the [ESC] key to exit.
Displaying Stereo Pair for visual inspection. Press the [ESC] key to exit.
Displaying Stereo Pair for visual inspection. Press the [ESC] key to exit.
Displaying Stereo Pair for visual inspection. Press the [ESC] key to exit.
Displaying Stereo Pair for visual inspection. Press the [ESC] key to exit.
Displaying Stereo Pair for visual inspection. Press the [ESC] key to exit.
Displaying Stereo Pair for visual inspection. Press the [ESC] key to exit.
Displaying Stereo Pair for visual inspection. Press the [ESC] key to exit.
Displaying Stereo Pair for visual inspection. Press the [ESC] key to exit.
Displaying Stereo Pair for visual inspection. Press the [ESC] key to exit.
py: DONE.
Stopping threads: ...
Closing stream left: ...
Closing stream left: DONE.
Thread for left finished.
Closing stream right: ...
Closing stream right: DONE.
Thread for right finished.
E: [global] [    344039] [python3] XLinkReadData:165	addEventWithPerf(&event, &opTime) failed with error: 3
Device get data failed: 3
Closing stream meta_d2h: ...
Closing stream meta_d2h: DONE.
Thread for meta_d2h finished.
E: [global] [    344040] [Scheduler00Thr] dispatcherEventSend:53	Write failed (header) (err -1) | event XLINK_CLOSE_STREAM_REQ

E: [xLink] [    344041] [Scheduler00Thr] sendEvents:1036	Event sending failed
Stopping threads: DONE.
Closing all observer streams: ...
Closing all observer streams: DONE.
Segmentation fault

Note that when testing #82 I did also see this segmentation fault, noted here: https://github.com/luxonis/depthai/pull/82#issuecomment-619283062


Fix Docker Executable with optional Executable, PHP-CS-Fixer

What does this implement/fix? Explain your changes.

Optional Executables do not attempt to use Docker when not installed.
PHP-CS-Fixer does not work with Docker Executable

Does this close any currently open issues?
No, I do not think so.
Any other comments?
See #1707.
Checklist
Check all those that are applicable and complete.

[x] Merged with latest master branch
[x] Regenerate documentation with npm run docs
[x] Add change details to CHANGELOG.md under "Next" section
[ ] Added examples for testing to examples/ directory
[ ] Travis CI passes (Mac support)
[ ] AppVeyor passes (Windows support)

Travis failed for an unrelated issue.  Merging.


net/http: (*Transport).getConn traces through stale contexts

(*http.Transport).getConn currently starts a dialConn call in a background goroutine:
https://github.com/golang/go/blob/0b0cc4154e1defed07e73ca1304b9a68c7134577/src/net/http/transport.go#L942-L945
That records traces to the provided Context and eventually invokes t.DialContext with it:
https://github.com/golang/go/blob/0b0cc4154e1defed07e73ca1304b9a68c7134577/src/net/http/transport.go#L1029
https://github.com/golang/go/blob/0b0cc4154e1defed07e73ca1304b9a68c7134577/src/net/http/transport.go#L1060
This is pretty much a textbook illustration of the problem described in #19643 (Context API for continuing work). If (*Transport).getConn returns early (due to cancellation or to availability of an idle connection), the caller may have already written out the corresponding traces, and dialConn (and/or the user-provided DialContext callback) will unexpectedly access a Context that the caller believes to be unreachable.
httptrace.ClientTrace says, "Functions may be called concurrently from different goroutines and some may be called after the request has completed or failed." However, that is not true of Context instances in general: if the http package wants to save a trace after a call has returned, it should call Value ahead of time and save only the ClientTrace pointer. If dialConn calls a user-provided DialContext function, then getConn should cancel the Context passed to it and wait for DialContext to return before itself returning.

See also #20617 (Context race in http.Transport).

Yep, that's technically a bug, but it seems basically unfixable given the current context and httptrace APIs. Do you have any suggestions? I'm all ears.
When we made httptrace, I guess we had implicitly assumed that each trace object was single-use, which made it "safe" to access the trace object outside of the scope of the context. I say "safe" because I don't think we actually through this problem completely.
Aside: #20617 might be related to #19643 but is unrelated to this bug.

Do you have any suggestions?

Per above, unpack the ClientTrace early and save it, and wait for DialContext to return before allowing getConn to return. The change may be ugly, but it seems straightforward.

wait for DialContext to return before allowing getConn to return. The change may be ugly, but it seems straightforward.

We can't do that, it will be a performance regression.

We can't do that, it will be a performance regression.

If DialContext is responsive to context cancellation, then it will introduce a negligible delay if an idle connection is found. If DialContext is not responsive to cancellation, then it will fix a potential OOM condition if too many dials are in flight.
Beyond that, as far as I cal tell, it will add one allocation. I would be shocked if that has a noticeable impact relative to setting up an HTTP connection.

Sorry, I misunderstood your suggestion. You're suggesting that we cancel the pending dial if an idle conn becomes available before the dial finishes (which we currently do not do ... this is the part I missed). If the pending dial is canceled, then I agree, waiting for a canceled dial to finish does not seem like a problem.
That is still a semantics change that could affect performance. Currently, we let the pending dial finish and add it to the pool (up to Transport.MaxIdleConns and Transport.MaxIdleConnsPerHost). If we cancel the pending dial, that means a follow-up request will need to wait for a new dial or for a prior request to finish. This is potentially slower than the current implementation, where the follow-up request might use the pending dial. I am sure some usage pattern of http.Transport would be harmed by this change, and eventually we'd get a bug report.
I consider it a bug that we dial using the request's ctx. Ideally we'd dial using a background ctx, but that depends on #19643, which is unlikely to be fixed any time soon.
I think I have a good (Google-internal) project that could act as a benchmark for your suggestion. If there's no performance impact for that project, then your suggestion is likely a good solution.

Moving to Go 1.11.


Problem with docker with the daps

I have followed the README ont the https://github.com/International-Data-Spaces-Association/omejdn-daps page, and fully executed it, yet i have not found in the documentation the link or the mention that the DAPS can be executed with dockers nor the link to https://github.com/Fraunhofer-AISEC/omejdn-server/tree/cb6d5e56c98b07d70d6753e32901d65df785fcf3, althougt there is a link in with the other folders.
It is not correctly stated that it can be installed using dockers, nor the link to the fraunhofer page. With the code i downloaded in the omejdn-daps page, https://github.com/International-Data-Spaces-Association/omejdn-daps I have tried to execute the steps shown in the fraunhofer page and I have found some error.

sqs@Virtual-Ubuntu-20:~/DAPS-DOCKER/omejdn-daps/omejdn-server$ docker run -d --name=omejdn -p 4567:4567 -v $PWD/config:/opt/config -v $PWD/keys:opt/keys my-omjdn-server
docker: Error response from daemon: invalid volume specification: '/home/sqs/DAPS-DOCKER/omejdn-daps/omejdn-server/keys:opt/keys': invalid mount config for type "bind": invalid mount path: 'opt/keys' mount path must be absolute.
See 'docker run --help'.

Could the documentation be changed so that both ways can be done? and what problem could it be  in this step using dockers?

Thanks for your issue.

what problem could it be in this step using dockers?

'opt/keys' mount path must be absolute.

Exactly this. Absolute paths start with /.

Could the documentation be changed so that both ways can be done?

In theory, yes. And I probably will add a note at some point.
Although I should note that the README in this repository is only intended to get people going for simple test setups, not for production use.
If one needs to use infrastructure involving docker their usecase likely should entail securing certain aspects of Omejdn not covered in the README. A few issues and recommendations are mentioned in the section Going forward.
Note that the README does not go into a lot of details for the necessary steps, as this kind of configuration is targeted at experienced server administrators.

Due to inactivity, I will assume the problem to be resolved and close this issue.
Feel free to reopen, should the problem persist


Apply a grammar check.

I ran the readme through Grammarly.

Will you be merging this?

Will you be merging this?

@fire
Thought i merged it, sorry it's my first merge on github :)


Removal of cnpg pods sometimes lead to CNPG manager getting stuck

In most cases (accidental) removal of a CNPG pods, leads to the manager restoring the pod right away (as it should).
However, in some edge cases, it gets into a limbo state not restoring them:
{"level":"info","ts":"2023-04-23T09:59:35Z","msg":"No primary instance found for this cluster","controller":"cluster","controllerGroup":"postgresql.cnpg.io","controllerKind":"Cluster","Cluster":{"name":"vaultwarden2-cnpg-main","namespace":"ix-vaultwarden2"},"namespace":"ix-vaultwarden2","name":"vaultwarden2-cnpg-main","reconcileID":"348b5fdd-fbbf-4925-afa6-ae9049c8517b","uuid":"8d3fe8e2-e1bd-11ed-b82c-aa1881d0aa5a"}

vaultwarden2-cnpg-main-rw-b969898d5-ktx8l   1/1     Running   0             9m17s
vaultwarden2-cnpg-main-3-join-2nf8f         1/1     Running   0             9m15s
vaultwarden2-cnpg-main-rw-b969898d5-44cjh   1/1     Running   0             2m4s
vaultwarden2-88b49f588-vwfrb                0/1     Running   3 (43s ago)   2m3s

We, as @truecharts, have found a solution to fix clusters in this limbo state:

Hibernate the cluster
Wait 5 minutes
Unhibernate the cluster

This forces the controller to completely go over the cluster again as-if it was freshly starting, including ensuring there is a primary instance.

Adding prio: low tot the title, as this is basically an issue that only occurs when users make mistakes and a quickfix/workaround has been found.
Leaving the issue as this should idealy be a scenario the operator detect itself

I encountered a similar situation where I deleted one of the pods and the cluster got totally stuck and I could not find any way out of it. I tried hibernating but it did not work. I think #1915 is also about this

Ensure you hibernate AND scale down the pooler though...

We, as @truecharts, have found a solution to fix clusters in this limbo state:

Hibernate the cluster
Wait 5 minutes
Unhibernate the cluster

This forces the controller to completely go over the cluster again as-if it was freshly starting, including ensuring there is a primary instance.

How do you hibernate a cluster without a primary?
I'm stuck in the same state and trying your workaround gives me this Error: no primary instance found, cannot proceed with the hibernation

This should be fixed in the latest version 1.22.2, please open a new issue if it happens again


Current version not compatible with GUISlicer

It seems that this version is missing the GFX files

Hi! You are correct that the updated version has changed set of include files.
A new version of GUIslice has been released that uses the updated Waveshare_ILI9486 files.
This version is not yet released via the Arduino IDE library manager, so for now you will need to manually update the library from GitHub.
Let me know if you have any difficulties.
Thanks!

Closing as GUIslice 0.15 has been released to the Arduino IDE library manager


Wrong and duplicate ETag removal

Removing the ETag header is written twice in the web.config.
The first one is with custom HTTP header:

And the second one is with URL rewrite.
Besides from being duplicate, the first option doesn't actually work:
http://stackoverflow.com/a/1250987/601179
(And I verified it today)
BTW, for IIS 8 there is a new way:
http://stackoverflow.com/a/26789473/601179

Ta

Do you need a pull request for this?
It should be pretty no brainier to fix.

Ha! no I was foot tapping waiting to do a much larger release.


pyton3 build failure

Host Environment

OS: Windows 11 Pro
Compiler: Microsoft (R) C/C++ Optimizing Compiler Version 19.33.31630 for x64

To Reproduce
Steps to reproduce the behavior:
./vcpkg --triplet=x64-windows-static install python3
Failure logs
Computing installation plan...
The following packages will be built and installed:

python3[core]:x64-windows -> 3.10.5#4
python3[core]:x64-windows-static -> 3.10.5#4
Additional packages (*) will be modified to complete this operation.
Detecting compiler hash for triplet x64-windows...
Detecting compiler hash for triplet x64-windows-static...
Restored 0 package(s) from C:\Users\Vitaliy\AppData\Local\vcpkg\archives in 583.1 us. Use --debug to see more details.
Installing 1/2 python3:x64-windows...
Building python3[core]:x64-windows...
-- Using cached python-cpython-v3.10.5.tar.gz.
-- Cleaning sources at C:/vcpkg/buildtrees/python3/src/v3.10.5-763741728b.clean. Use --editable to skip cleaning for the packages you specify.
-- Extracting source C:/vcpkg/downloads/python-cpython-v3.10.5.tar.gz
-- Applying patch 0002-use-vcpkg-zlib.patch
-- Applying patch 0003-devendor-external-dependencies.patch
-- Applying patch 0004-dont-copy-vcruntime.patch
-- Applying patch 0005-only-build-required-projects.patch
-- Applying patch 0009-python.pc.patch
-- Applying patch 0010-bz2d.patch
-- Applying patch 0011-dont-skip-rpath.patch
-- Using source at C:/vcpkg/buildtrees/python3/src/v3.10.5-763741728b.clean
-- Building PCbuild/pcbuild.proj for Release
CMake Error at scripts/cmake/vcpkg_execute_required_process.cmake:96 (message):
Command failed: msbuild C:/vcpkg/buildtrees/python3/x64-windows-rel/v3.10.5-763741728b.clean/PCbuild/pcbuild.proj /p:Configuration=Release /p:IncludeExtensions=true /p:IncludeExternals=true /p:IncludeCTypes=true /p:IncludeSSL=true /p:IncludeTkinter=false /p:IncludeTests=false /p:ForceImportBeforeCppTargets=C:/vcpkg/buildtrees/python3/src/v3.10.5-763741728b.clean/PCbuild/python_vcpkg.props /p:IncludeUwp=false /p:_VcpkgPythonLinkage=DynamicLibrary /t:Rebuild /p:Platform=x64 /p:PlatformToolset=v143 /p:VCPkgLocalAppDataDisabled=true /p:UseIntelMKL=No /p:WindowsTargetPlatformVersion=10.0.19041.0 /p:VcpkgTriplet=x64-windows /p:VcpkgInstalledDir=C:/vcpkg/installed /p:VcpkgManifestInstall=false /p:UseMultiToolTask=true /p:MultiProcMaxCount=1 /p:EnforceProcessCountAcrossBuilds=true /m:1
Working Directory: C:/vcpkg/buildtrees/python3/x64-windows-rel/v3.10.5-763741728b.clean
Error code: Access violation
See logs for more information:
C:\vcpkg\buildtrees\python3\build-x64-windows-rel-err.log

Call Stack (most recent call first):
scripts/cmake/vcpkg_install_msbuild.cmake:79 (vcpkg_execute_required_process)
ports/python3/portfile.cmake:145 (vcpkg_install_msbuild)
scripts/ports.cmake:147 (include)
error: building python3:x64-windows failed with: BUILD_FAILED
error: Please ensure you're using the latest port files with git pull and vcpkg update.
Then check for known issues at:
https://github.com/microsoft/vcpkg/issues?q=is%3Aissue+is%3Aopen+in%3Atitle+python3
You can submit a new issue at:
https://github.com/microsoft/vcpkg/issues/new?template=report-package-build-failure.md&title=[python3]+Build+error
Include '[python3] Build error' in your bug report title, the following version information in your bug description, and attach any relevant failure logs from above.
vcpkg-tool version: 2022-11-10-5fdee72bc1fceca198fb1ab7589837206a8b81ba
vcpkg-scripts version: 6f7ffeb18 2022-11-11 (10 days ago)
Additional context
This is Hyper-V virtual machine. The hard drive is physical one dedicated to this machine. Mother OS is Windows Server 2022.
Log file is an empty one.
build-x64-windows-rel-err.log

You can try to open Powershell with administrator privileges and reinstall the port, or you can clone vcpkg to another drive letter, like E or F.

You can try to open Powershell with administrator privileges and reinstall the port, or you can clone vcpkg to another drive letter, like E or F.

There is disk C only on this computer.
Building as administrator doesn't help. I also ensured that I gave required file system access permissions before I submitted this report.
About other possible advises, no, disabling antivirus doesn't help.

You can try to open Powershell with administrator privilege

Most of the times, this is wrong.


Prepend npx to CLI reference commands

Describe this PR
Prepends npx to Prisma commands in CLI reference
Changes

Prepends npx to Prisma commands in CLI reference

What issue does this fix?
Fixes #3538
Any other relevant information

@janpio the Docs team dug up the metrics around what percentage of people run Prisma globally (meaning they do not need to prepend npx), and it is quite small, according to your analysis 2.5%..
I do think we need to add a Note to the top of this page, explaining the use (or non-use), of npx, but adding it to the Docs is based on the usage stats.
We could leave it off the reference pages (leave the reference commands as bare-boned as possible), add the Note I mention above, and only add it to the Get Started Guides and elsewhere as appropriate. But we do for sure want to add it to the Get Started, anywhere where users might trip up using our commands simply because they didn't know they needed to prepend npx.

Yes, this has nothing to do in the end with local vs. global - but that the reference lists the "commands" and not "the thing you execute in your terminal". That is one a different level.
We could have a "Executing Prisma CLI commands on your machine" section somewhere that explains that what you type in your terminal depends on your packager you are using (Npm, Yarn, Pnpm etc) and wether you have a local or a global installation of the CLI - and that this has to consistently be prepended to the actual commands in the command reference. But that is usually assumed in most documentation of Node based tools I think.
(Getting Started etc where we really just tell people "This is the usual thing to type into your terminal" are of course, as you say, different from the reference. There we should be consistent and chose one of the options, and npx prisma * makes sense there.)

Yep, two topics, intersecting. @ObamaTheLlama114 , want to share your proposal on handling this page, and for opening a second PR for the non-Reference topics where we do want to add npx?

I sure would.  I can remove all of the npx prepends, since there already were some, and note at the top of the page the that if prisma is installed locally, the user needs to prepend with their chosen package manager (npx, pnpx, yarn...)

Looks good. I had suggested making it an Admonition, so that it stands out more, but this is fine too. Thanks, let's merge it!


Feature/allocate sequence block

What? and Why?

What does this pull request change/fix? Why was it necessary?

Checklist

[ ] CHANGELOG.md updated? (if required)

Codecov Report

Merging #43 into master will increase coverage by 2.23%.
The diff coverage is 91.34%.

@@            Coverage Diff             @@
##           master      #43      +/-   ##
==========================================
+ Coverage   82.35%   84.59%   +2.23%
==========================================
  Files           6        6
  Lines         255      331      +76
==========================================
+ Hits          210      280      +70
- Misses         45       51       +6

Impacted Files
Coverage Δ

tests/test_sequence.py
79.74% <100%> (ø)
:arrow_up:

tests/test_server.py
99.06% <100%> (+1.1%)
:arrow_up:

server.py
73.33% <79.06%> (-1.38%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41b7712...d7f417f. Read the comment docs.


Improve code quality

Is this ready for review?

Is this ready for review

Yes

Looks like there is no need to update the branch.


mv.bypass.gamemode.* doesnt work on my configuration :(

Information

Server version: Paper 1.16.5

Full output of /mv version -p: https://paste.gg/p/anonymous/f6de09f5c97a4cbf8871715312bcaeeb

Help request
Problem

Im using LuckPerms as permission plugin and the permission mv.bypass.gamemode.* doesn't work, im still changing my gamemode on world change automatically.... I dont know why and cant find anything usefull in web....
What I have tried
Just adding the permission that should work and looking over the config, but couldnt find anything.... I just want admins not to change from gamemode 3 to gamemode 0 cause they want to spectate somebody else in another world....

Unless you can prove that the permission mv.bypass.gamemode.* is set to true and correctly applied to the user in luckperms, and that this issue still occurs when only luckperms and mv plugin is installed. I'm not convinced this issue is with mv.

Just tested on my server - cant reproduce the issue.

 What do you mean with mv plugin? ...sorry ^^

multiverse plugins

Okay well, thank you, ill try to remove all other plugins and test it, I thought this is general issue.... :) Sorry for that....

99% of the time is just you set the permission wrong.

Im very sorry for wasting your time....
But thank you, with your help I found the issue, I have a plugin named GamemodeInventories and in this config file you can set survival on world change and that was set on true.... thanks for your help and sorry for this time waste :(


Userpanel

Fixed to add this back in/catch it up with all the latest changes in main.

I agree with Toby that we will find bugs in testing.


v3.2.0 release notes

Signed-off-by: Rastislav Szabo<EMAIL_ADDRESS>

Coverage remained the same at 71.65% when pulling a440ec3c7a5c8da3d65e8c6be3bb3db26dbe691f on rastislavszabo:master into 135e7b308b69a70361c200a1e183e2d2f4503a2e on contiv:master.


Feature/include xls and csv errors in report

Solves #84.

Coverage decreased (-0.1%) to 81.613% when pulling 550dfbf1e4c2a9d34ace74dd3c04c3aa091c76b5 on feature/include_xls_and_csv_errors_in_report into ef957792fce29c2afbd9f74aa79e118be4237090 on master.

@akariv can you please review this PR when you can.

@pwalsh this looks fine to me.

@akariv thanks


New radio buttons are not responsive

Describe the Bug
As we saw in @philippfromme's laptop, the new radio buttons are not responsive for every screen resolution.
Steps to Reproduce

Open the deployment tool dialog in Philipp's computer.
Look at the screen 👁

Expected Behavior
The radio buttons are responsive.
Environment

OS: Any
Camunda Modeler - Dev branch

Update: It turns out that Philipp has 1.5 zoom ratio configured in his machine which causes this behavior. Volker says we should not invest time on this until further notice.

1.5 zoom is common during trainings on low level projectors.
As this is my daily business, please find a way that I use the deployment from the modeler here.

I'd suggest that we spend a few more minutes to understand if this is a zoom ratio related issue or an issue how we've implemented the custom radio buttons.
@oguzeroglu Please verify with @philippfromme whether he sees the same issue with custom radios, i.e. provided by bootstrap. If not, adapt the styling techniques used in Bootstrap (with our custom style flavor baked in, of course).

As this is my daily business, please find a way that I use the deployment from the modeler here.

@ingorichtsmeier The issue is a cosmetic one that won't impact your trainings.

It fails if px unit is used instead of rem unit. For instance in W3Schools website. In the official Bootstrap website they are implemented with rem unit. Our designs specify exact amount of px values.

OK, thank you for the clarification.
Without screenshot it was difficult to judge.

Thanks for the clarification @oguzeroglu. I assume rewriting with rem is a lot of work we'll understandably not invest right now.


OTA update timeout

After several successful updates, a timeout error appears.
I can still download the firmware that was uploaded on the tuya website a few days ago, but  cannot download the firmware that was updated today.

I encountered a similar issue with OTA, it couldn't download


Please sign tarball

I am maintaining Flask-Mail in Debian, which preferes cryptographic verification of upstream tarballs.
Please sign the source tarball on PyPI if at all possible.

Our new publish workflow generates SLSA provenance for the build and places that in the GitHub release, as Flask and other Pallets projects do. PyPI no longer docs pgp signatures, but is currently working on their own provenance support as part of trusted publishing.

All hail to the ever-trustworthy, centralised Microsoft platform!

Note that this does not mean that we are tied to the GitHub platform. PyPI trusted publishing already works with multiple platforms and more are being added. SLSA provenance is not part of GitHub, nor is PyPI's own provenance support. The provenance is hosted on GitHub release pages because that is a place we can easily host it. If we moved to another source host, we would presumably build provenance and put it there instead. Sarcastically commenting about our (a group of volunteers working in our free time) use of a convenient and popular git service is not productive or appreciated, and will not helping you get support.


Feedback for python filename classification code Jupyter notebook

Generally the notebook is very well laid out and ok to follow. Couple of questions below though:

In the fifth code block you have the following:
one_rec_df = ff.filename_to_df("hello_or_other.nc")
However, it's not clear why you're doing this step. Is it just to demonstrate how filename_to_df works with a dummy filename, or does it have some other purpose?
In the section 'What does our transformed dataset look like?' it says 'There are 1,739 columns, because we have one-hot-encoded the data' - Why are there 1739 columns after one-hot-encoding? I thought this method effectively just turned each of the possible feature values into a column, so for the feature values you specified at the start, you'd end up with about 45 columns. Perhaps I haven't understood one-hot-encoding?! This step could do with further explanation.

Thanks @knappett, very useful feedback. I'm going to update and then you can review and let me know if it makes sense.

@knappett, please review my changes at:
https://github.com/cedadev/ai-mini-projects/blob/main/filename-classifier/filename-classification.ipynb


[Codegen][iOS] Support Embedded Types

Issue #, if available:
Description of changes:

Renamed customType to embedded(type) and embeddedCollection(of)
Adds support in amplify codegen models to generate Extensions for embedded types

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

when running amplify codegen models the Embedded types do not have a *+Schema.swift file generated

Test suite failed to run

    [BABEL] /home/circleci/repo/packages/amplify-appsync-simulator/src/velocity/value-mapper/map.ts: ENOMEM: not enough memory, read

      at Object.<anonymous> (../../node_modules/lodash/values.js:1:18)

FAIL src/__tests__/velocity/value-mapper/string.test.ts
  ● Test suite failed to run

    ENOMEM: not enough memory, read

      at Object.<anonymous> (../../node_modules/@babel/core/lib/config/files/configuration.js:54:41)

yarn test locally passed.

thanks for reviewing @yuth !


Unable to resolve playwright binary

It seems like this plugin is trying to find the playwright binary in the directory of the file I have open instead of the project's root.
For instance, if I open the following test file in /Users/jarvis/work/react-project/e2e/HomeScrreen/HomeScreen.test.ts and then I run ltt to run the tests for the file, I get the following error:

Neotest: neotest-playwright: Error: Unable to locate playwright binary. Expected to find it at: /Users/jarvis/work/react-project/e2e/HomeScreen/node_modules/.bin/playwright

I would expect the binary to be read from /Users/jarvis/work/react-project/node_modules/.bin/playwright instead.
A simple way to solve this is to install Playwright globally on my machine but I'd like to know if I am missing something.
Note: I am running Neovim via the latest LazyVim.

As it stands, this plugin doesn't really exert a lot of effort looking for the playwright binary. There's a lot of room for improvement, especially now that some powerful path finding utilities have finally landed in nvim 0.10.
For now though, your options are either:

Launch nvim in the project root (/Users/jarvis/work/react-project)

or

Set the path using the config. (whether that's by hardcoding it, pointing it to an env var, etc)


Saloon Hooks

I think it would be useful to add various hooks into Saloon which can be added which can be useful for logging. For example I could add a hook before a request has happened, after a request has happened, after a successful response and after a failure response.
This could be added to the connector or the request (or both) and can be used.
There could also be a shouldSendRequest() which can return false if a provided condition fails

I could also add Laravel events when requests are sending.