UI issues on establishing the wallet-selector

Describe the bug

Unlike the example in example/react, I had to manually import wallet icon url and update on setupXXX function all. (or if I don't import them manually, I will get result as below)

Unlike the example in examples/react I had to manually import @near-wallet-selector/modal-ui/styles.css or modal UI looks strange as below.

Invalid wallet icon alignment

To Reproduce Steps to reproduce the behavior:

git clone git@github.com:near/ui.multisafe.git
checkout to revert-154-revert-134-MUL-10
run yarn && yarn start

Expected behavior Bug1. I shouldn't had to manually import and insert iconUrl to setup functions. If I don't pass anything, it should automatically fallback to default image Bug2. I shouldn't had to manually import css file. (I think this is a bug but even if this is intentional, it was missing from readme) Bug3. It should render just as same as examples/react
Screenshots If applicable, add screenshots to help explain your problem.
Device (please complete the following information):

OS: iOS
Browser Chrome
Version 5.0.1

Additional context Add any other context about the problem here.

Hey, @hcho112 thank you for raising this issue.
For: Bug1.

At the moment we expose icons under /assets folder for each wallet, to show icons a developer can either copy these assets through webpack or any other builder to their public folder or just provide the iconUrl to the setup function. There's documentation on the readme of each wallet. This is the default behavior of NX when handling assets but we will look into improving it as you suggested here, so the developer does not need to provide iconUrl unless they want to change the icon.

For: Bug2.

This is not a Bug, the css needs to be imported this has been done to give developers more flexibility if they wish to override some of the css variables or styles there's documentation here: https://github.com/near/wallet-selector/tree/main/packages/modal-ui

For: Bug3

Not sure if this is a bug or just confusion since there's documentation in modal-ui package.  But just to avoid confusion in the future we will add a readme on each example and explain it there too.

For the invalid wallet icon alignment, you might have css that overrides styling for images.

@kujtimprenkuSQA Thank you for quick feedback, really appreciated 👍
For the Bug3, I did further investigation to see if the css issue is coming from ui.multisafe. Unfortunately the issue was still originated from wallet-selector as below:
A. Screenshot from example with showing css rule for .nws-modal-wrapper .spinner img as:

B. Screenshot from example with html structure:

C. CSS rule expression on point B:
.nws-modal-wrapper .spinner .icon {
  width: calc(var(--size) / 1.2);
  height: calc(var(--size) / 1.2);
  border: 1px solid rgba(0, 0, 0, 0.05);
  border-radius: 50%;
  box-shadow: rgb(0 0 0 / 5%) 0 10px 20px 0;
}
.nws-modal-wrapper .spinner img {
  width: 100%;
  height: auto;
  padding: 20px;
}

So what's happening is that img element is applied with .nws-modal-wrapper .spinner .icon instead of .nws-modal-wrapper .spinner img  in example react page.
Where as, when we import wallet-selector as a package and do the same steps:

Notice that html structure has been changed, and css rule applied to img element is also different. (notice that now it is applying .nws-modal-wrapper .spinner img  instead of .nws-modal-wrapper .spinner .icon
So it is not the matter of box-sizing issue, instead it is more coming from inconsistent outcome from what's shown on examples vs what is actually returning if we import from wallet-selector repo.
I was able to hack the css rule by creating custom css rule as below:
.nws-modal-wrapper .spinner img {
  width: calc(var(--size) / 1.2);
  height: calc(var(--size) / 1.2);
  border: 1px solid rgba(0, 0, 0, 0.05);
  border-radius: 50%;
  box-shadow: rgb(0 0 0 / 5%) 0 10px 20px 0;
  padding: 0;
}

Regardless I believe this is still an issue and would be appreciated if the team look into it further. Happy to assist.

Hey, @hcho112
I pulled down your latest changes from your branch revert-154-revert-134-MUL-10 as far as I can understand the markup is the same with what we have already published in our main branch.
When you switch to main branch of wallet-selector can you make sure to do a git pull and see if there are changes in the remote?
I could not reproduce the inconsistency for the markup mentioned above.
Here is the published version of main branch : https://near.github.io/wallet-selector/
I tried editing this file locally with this css rule below, In my case, the image is aligned correctly this way
.nws-modal-wrapper .spinner img {
    box-sizing: border-box;
}

Since I could not reproduce the inconsistency of the markup between the example we have in main and the implementation you have I would like to think it's just a css problem. If you know how to reproduce it please let me know I would like to make this fix too. Thanks.

Hello, @kujtimprenkuSQA
Again, thank you for quick response.
Just follow up with your response, when I tested and report this issue, I was at main branch AND previously was on v4.1.1 and then pull latest which was at v5.0.2 and it was still showing inconsistent html tree. (difference between whats showing on react example and whats on source code was different) After checking with your feedback and further investigation, I found out that if I was on older version and pull latest version (release) I actually need to rebuild in order to apply latest changes on react example.
I assumed that it will apply latest changes to react example straightaway, but after seeing the reference where react example code is referencing to, it actually fetch from dist directory. (So after I ran the yarn run build:all it did update dist directory with latest changes.
And when I reached to this point, previous feedback started to make sense and applying suggested changes fixed the problem. Moving forward, only thing that I could think of is to run make update on serve:react command as:
"serve:react": "yarn build:all && nx serve react" in a sense that react example is guaranteed to build and run against latest source code? (Happy to make PR if this is a good approach)
Thank you for the assistance so far!

Hey, @hcho112
The modal-ui package needs to point to the dist folder because we have an Angular example too and and trying to import the jsx files directly to an Angular example would fail that's why whenever the source code changes in modal-ui this package needs a re-build.
I do not think it is necessary to combine build and serve command because it's only the modal-ui package that requires re-build. For other packages if you build them once and serve the react example and then if you change the source code in any of the packages the changes will reflect immediately.
We will be making that fix about the css rule though.
Thanks for your feedback.


fix: fixes a few invalid uri for 934130 and 934131 tests

Hi!
Sibling of https://github.com/coreruleset/coreruleset/pull/2880. There are some positive tests in which the uri is not starting with a /. Go server and Envoy deny these requests with a 400, therefore tests fail and the real payload that we are trying to analyze is not checked.
The tests are about JavaScript prototype pollution injection attempts, I don't think that it was intended to try to specs/rfcs regarding the path format.
Thanks!

Done, added it also the other tests in the 934130 file which were already /?.

Looks good. Thanks. Merging now.


v0.3.0 update

This pull request integrates v0.3.0 with numerous breaking changes. Main updates:

The vortex lattice setup now uses a VortexLatticeSystem construction for "lazy" evaluations.
The doublet source analysis setup now uses a DoubletSourceSystem construction for "lazy" evaluations.
The Foil type is also reworked for easier manipulation of coordinates.
The naca4 function now generates a Foil type with the appropriate foil name.
Rudimentary documentation added.

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@e05b3d4). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #70   +/-   ##
=======================================
  Coverage        ?   29.86%
=======================================
  Files           ?       50
  Lines           ?     1597
  Branches        ?        0
=======================================
  Hits            ?      477
  Misses          ?     1120
  Partials        ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e05b3d4...db2d615. Read the comment docs.


(#315) replaced Broken RawGit links

(#315) replaced Broken RawGit links

@mohamednizar/z this pull request is too small, just 6 lines changed (less than 10), there will be no formal code review, see §53 and §28; in the future, try to make sure your pull requests are not too small; @paulodamaso/z please review this and merge or reject

Codecov Report

Merging #354 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #354   +/-   ##
=========================================
  Coverage     76.94%   76.94%
  Complexity      193      193
=========================================
  Files            34       34
  Lines          1106     1106
  Branches         85       85
=========================================
  Hits            851      851
  Misses          228      228
  Partials         27       27

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63a1831...1171e2d. Read the comment docs.

@0crat wait

@rultor merge

@rultor merge

@paulodamaso OK, I'll try to merge now. You can check the progress of the merge here

@rultor merge

@paulodamaso Done! FYI, the full log is here (took me 12min)

Job gh:yegor256/jpeek#354 is not assigned, can't get performer

This job is not in scope

@rultor release tag is 0.30.2

@rultor release tag is 0.30.2

@paulodamaso OK, I will release it now. Please check the progress here

@rultor release tag is 0.30.2

@paulodamaso Done! FYI, the full log is here (took me 24min)


Build A Userlist Application using Next js

Proposal Submission
Proposed title of article
Build A Userlist Application using Next js
Proposed article introduction
[Web development] in this tutorial I'll be writing on how to build a Userlist Application using Next js.
Key takeaways
Users will be able to

create next app and layout
make use of userouter to add a class
make use of next js link
make use of getStaticProps to get user data

Article quality
The article is meant to add to a list of projects for readers who are interested in learning Next js. It will help make them farmilar with steps and methods in Next.
Conclusion
This article will be a great read to users both at beginner and professional level.

Unfortunately, introductory aspects of Next.js are already covered in numerous articles. Feel free to suggest another area


Populating Backbone.$ with jquery for CommonJS requires

When performing a require("Backgrid"), we populate Backbone.$ with a require("jquery") statement. This is similar to other's which use Backbone in client-side environment (see: http://learnjs.io/blog/2013/11/23/backbone-jquery-browserify/).
This change technically requires the latest version of the Backgrid source to be checked in which it appears it is not. Package.json needs reference to jquery, backbone and underscore and the project output needs to be re-built.

This didn't quite work for me, I had to do this as well:
diff --git a/Gruntfile.js b/Gruntfile.js
index a851062..9df43e1 100644
--- a/Gruntfile.js
+++ b/Gruntfile.js
@@ -50,6 +50,7 @@ module.exports = function (grunt) {
             '    });\n' +
             '  } else if (typeof exports === "object") {\n' +
             '    // CommonJS\n' +
+            '    var Backbone = require("backbone");\n' +
             '    Backbone.$ = Backbone.$ || require("jquery");\n' +
             '    module.exports = factory(require("underscore"), Backbone);\n' +
             '  } else {\n' +
diff --git a/lib/backgrid.js b/lib/backgrid.js
index f262df3..229fbf4 100644
--- a/lib/backgrid.js
+++ b/lib/backgrid.js
@@ -15,6 +15,7 @@
     });
   } else if (typeof exports === "object") {
     // CommonJS
+    var Backbone = require("backbone");
     Backbone.$ = Backbone.$ || require("jquery");
     module.exports = factory(require("underscore"), Backbone);
   } else {

Still, thanks!

Bryce, you're correct. Thank you for catching this. I'll fix on my side and check in the update

Bump

:+1:  sweet can't this be merged ?
thanks.

Should be able to be merged, but @wyuenho has been MIA. Bump

@ryno1234 , @wyuenho has given me commit rights to this repo.  This pull request looks good and solves a problem I have as well.  Are you still comfortable with it after 27 days?

Hi @ErikEvenson, yes I am comfortable with this. Glad to see this being revived!

Done.

@bryce-gibson I see now that it does exactly that.  I'll take a look at it, or send in a pull request and I'll update it.

Created #597 which is JQuery version agnostic. The theory of not specifying was that there's (probably) already a version being included with Backbone, so Backgrid should be able to just use that version.


Change the Persistance layer name to Persistence. It's a misspelling.

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

Done.


Pax logging 1.11.x with logback 1.2.9

Hello,
I create this PR to include logback 1.2.9
This version fix the CVE-2021-42550 (aka LOGBACK-1591)
I know it is NOT the same security level as log4Shell, but i think this should be included too.

pax-logging-logback shades ch/qos/logback/classic/spi/PackagingDataCalculator.java - I'll check the changes between 1.2.3 and 1.2.9

thanks for the PR btw ;)

git lg v_1.2.3..branch_1.2.x -- ./logback-classic/src/main/java/ch/qos/logback/classic/spi/PackagingDataCalculator.java shows no changes. I'm leaving the shaded class as-is.

Actually, logback packages are NOT exported from pax-logging-logback. The only way to integrate is to create a bundle fragment. Like the org.ops4j.pax.logging:pax-logging-sample-fragment-logback example.


Rails/RedundantAllowNil stumbles upon validation

Actual behavior
Newly added Rails/RedundantAllowNil errors out after encountering validates keyword
5 errors occurred:
An error occurred while Rails/RedundantAllowNil cop was inspecting /home/app/models/user.rb:9:2.
An error occurred while Rails/RedundantAllowNil cop was inspecting /home/app/models/user.rb:10:2.
An error occurred while Rails/RedundantAllowNil cop was inspecting /home/app/models/user.rb:11:2.
An error occurred while Rails/RedundantAllowNil cop was inspecting /home/app/models/user.rb:12:2.
An error occurred while Rails/RedundantAllowNil cop was inspecting /home/app/models/user.rb:13:2.

Steps to reproduce the problem
The file in question app/models/user.rb:
class User < ApplicationRecord
  belongs_to :account, optional: true

  before_save { self.email = email.downcase }

  has_secure_password
  has_secure_token :confirmation_token

  validates :email, format: { with: /\A([^@\s]+)@((?:[-a-z0-9]+\.)+[a-z]{2,})\z/i }
  validates :email, length: { maximum: 256 }
  validates :email, presence: true
  validates :email, uniqueness: { case_sensitive: false }
  validates :password, length: { minimum: 8 }
end

RuboCop version
$ [bundle exec] rubocop -V
0.67.0 (using Parser <IP_ADDRESS>, running on ruby 2.6.2 x86_64-linux)

Identified the culprit after running rubocop -d:
An error occurred while Rails/RedundantAllowNil cop was inspecting /home/app/models/user.rb:10:2.
undefined method `children' for nil:NilClass

Thanks for the feedback. I opened a PR #6886.

I just got the same error in my Rails project :D

Same, still getting it on 0.67.1.
1 error occurred:
An error occurred while Rails/RedundantAllowNil cop was inspecting /path/to/rails/app/models/user.rb:9:2.
Errors are usually caused by RuboCop bugs.
Please, report your problems to RuboCop's issue tracker.
https://github.com/rubocop-hq/rubocop/issues

Mention the following information in the issue report:
0.67.1 (using Parser <IP_ADDRESS>, running on ruby 2.6.2 x86_64-darwin18)
Finished in 5.799085999955423 seconds

In 0.67.1 I get a different error than from 0.67.0 for this cop.  It's now
undefined method `children' for nil:NilClass
..rvm/gems/ruby-2.6.2/gems/rubocop-0.67.1/lib/rubocop/cop/rails/redundant_allow_nil.rb:42:in `on_send'
..rvm/gems/ruby-2.6.2/gems/rubocop-0.67.1/lib/rubocop/cop/commissioner.rb:58:in `block (2 levels) in trigger_responding_cops'
..rvm/gems/ruby-2.6.2/gems/rubocop-0.67.1/lib/rubocop/cop/commissioner.rb:106:in `with_cop_error_handling'
..rvm/gems/ruby-2.6.2/gems/rubocop-0.67.1/lib/rubocop/cop/commissioner.rb:57:in `block in trigger_responding_cops'
..rvm/gems/ruby-2.6.2/gems/rubocop-0.67.1/lib/rubocop/cop/commissioner.rb:56:in `each'
..rvm/gems/ruby-2.6.2/gems/rubocop-0.67.1/lib/rubocop/cop/commissioner.rb:56:in `trigger_responding_cops'
..rvm/gems/ruby-2.6.2/gems/rubocop-0.67.1/lib/rubocop/cop/commissioner.rb:34:in `block (2 levels) in <class:Commissioner>'
..rvm/gems/ruby-2.6.2/gems/rubocop-0.67.1/lib/rubocop/ast/traversal.rb:50:in `block in on_begin'
..rvm/gems/ruby-2.6.2/gems/rubocop-0.67.1/lib/rubocop/ast/traversal.rb:50:in `each'
..rvm/gems/ruby-2.6.2/gems/rubocop-0.67.1/lib/rubocop/ast/traversal.rb:50:in `on_begin'

Sorry, just noticed the changelog mentions the fix isn't released yet but the PR is on master.

You're right. I completely misread the release page. I should probably go to bed. lol
But thanks for pointing it out, I've disabled the cop for now to get rid of the error,

Hi there. We RuboCop core team released RuboCop 0.67.2.
https://github.com/rubocop-hq/rubocop/blob/v0.67.2/CHANGELOG.md#0672-2019-04-05

@koic you're amazing, thank you!

Thanks!

1 error occurred:
An error occurred while Rails/RedundantAllowNil cop was inspecting /path/to/rails/app/models/model.rb:12:8.
Errors are usually caused by RuboCop bugs.
Please, report your problems to RuboCop's issue tracker.
https://github.com/rubocop-hq/rubocop/issues

Mention the following information in the issue report:
0.67.2 (using Parser <IP_ADDRESS>, running on ruby 2.6.1 x86_64-linux)

It seems that some of the issue still persists in 0.67.2
in this case, it was a klass.validates-call in a self.inherited(klass) callback if that information is of any help

@koerneml Could you open a new issue based on the issue template?
https://github.com/rubocop-hq/rubocop/blob/v0.67.2/.github/ISSUE_TEMPLATE/bug_report.md


script type request: global script

script container type: global
which will run continuously while the server is running
with a default delay of 0.5 seconds between running - configurable through delay:
GlobalScript:
type: global
delay: 1s
script:

Why not just ... on server start: + a loop?


Even docs are wrong... (on System class)

Hello.
I recently found Kha and I'm trying to build something simple with it. Sadly, it is getting more and more complicated with each step I take.
Most of tutorials are either outdated or predated. Kha 3D Tutorials by Lubos Lenco uses System.init initialization that works only with Kha from git. 3D Example from Wiki page apparently calls Assets.blobs.body.toString() where Assets.blobs.body_ogex.toString() should be used.
And now this :)
Compiling code.
../Sources/MeshLoader.hx:88: characters 73-90 : Class<kha.System> has no field pixelWidth
../Sources/MeshLoader.hx:88: characters 93-111 : Class<kha.System> has no field pixelHeight

According to API docs, System class indeed has both pixelWidth and pixelHeight fields, but there is no such thing in [https://github.com/KTXSoftware/Kha/blob/master/Sources/kha/System.hx](current System.hx).
And even after replacing field access with windowWidth() calls, example renders nothing, without throwing any error or displaying any output :(

I don't think this is intended state of things.

Thanks, will update the 3D Example and build new docs tonight.
P.S. The git version is where it's at. The haxelib version is severely outdated and won't be updated until Haxe 3.3 - please don't use it.

3D example is already updated (thanks Lubos), only the docs left...

No prob! Also added a note to 3D tuts repo to favor a git version of Kha.

I think it would be great to add a testbed project in the Tests folder.
I'm doing something like https://github.com/lewislepton/kha-examples but in a single project where we can build once and cycle through each kha feature.
It will work as showcase, examples, and facilitate a lot tests for us.

I want to use kodegarden.org for tests when it's ready.
Anyway, docs are updated, all done here.

Thank you all :)

One more small note, although this may be by design:
Inline (or extern?) functions like Vector3.mult are not documented. That's little confusing for beginner. I ended up implementing my own math class before I stumbled upon Vector3.add in some random example.

Oh, that's not by design, looks like the code is confusing dox somehow. Will try to figure out what's going on.


Bump momentjs v2.29.4 in package-lock.json

This change needs to be within this #591 in order for it to pass the Build check


The _get_reward_model function has issues when loading an MoE Reward Model (e.g., ArmoRM).

The current method of loading the RM seems to use a generic approach, predicting through a value head. However, RMs like ArmoRM require the use of a Gating Layer, which appears to create issues with the current RM loading method. We attempted to load this RM using OpenRLHF’s method and ArmoRM’s official loading method, and the scores differed significantly (the former scored -2.23, while the latter scored 0.19). Below is the architecture diagram for ArmoRM:

And our test results:
OpenRLHF output:
{
    "index": 0,
    "input": "user\n\nhow can i develop a habit of drawing daily",
    "output": "assistant\n\nDeveloping a habit of drawing daily requires dedication, consistency, and a willingness to learn and improve. Here are some tips to help you establish a daily drawing habit:\n\n1. **Set a specific goal**: Commit to drawing for a certain amount of time each day, such as 15-30 minutes. Make sure it's achievable and realistic for your schedule.\n2. **Create a routine**: Choose a specific time of day that works for you, such as first thing in the morning or before bed. Try to draw at the same time every day to make it a habit.\n3. **Start small**: Don't feel pressured to create a masterpiece every day. Start with simple exercises, such as drawing shapes, lines, or basic forms. Gradually build up to more complex subjects.\n4. **Warm up with exercises**: Begin each drawing session with simple exercises, like:\n\t* Contour drawing: Draw the outline of an object without looking at the paper.\n\t* Gesture drawing: Quickly sketch the overall pose and movement of a subject.\n\t* Simple shapes: Draw basic shapes, like circles, squares, and triangles.\n5. **Practice different mediums and styles**: Experiment with various drawing tools, such as pencils, pens, markers, or digital drawing programs. Try different styles, like cartooning, realism, or abstraction.\n6. **Draw from reference images**: Use photographs or real-life observations as references to help you improve your drawing skills. This will also help you practice drawing from different angles and perspectives.\n7. **Join a community or find an accountability partner**: Share your daily drawings with friends, family, or online communities. This will help you stay motivated and inspired to continue drawing.\n8. **Be patient and persistent**: Don't get discouraged if your drawings aren't perfect. Celebrate small victories and recognize that improvement takes time.\n9. **Keep a sketchbook or digital portfolio**: Record your progress and reflect on your drawings. This will help you identify areas for improvement and track your growth.\n10. **Reward yourself**: Treat yourself to something nice after reaching a milestone or completing a certain number of days of drawing.\n\nAdditional tips:\n\n* Make drawing a part of your daily routine, like brushing your teeth or taking a shower.\n* Set reminders or alarms to ensure you don't forget to draw.\n* Experiment with different drawing prompts or challenges to keep things interesting.\n* Learn to enjoy the process, rather than focusing on the end result.\n* Don't be too hard on yourself if you miss a day or two. Just get back to drawing as soon as possible.\n\nRemember, developing a daily drawing habit takes time and effort. Be consistent, patient, and kind to yourself, and you'll see improvement over time.",
    "reward": -2.234375
}

ArmoRM official code output:
score: 0.1962890625

Please use remote reward  API for custom models.


Add a nightly job for testing the cloned ECP module

We are making a copy of the ECP module (https://github.com/Mbed-TLS/mbedtls/issues/7598). We are only adding limited testing in the PR job to save CI bandwidth. We still need an extensive testing for the copy and would like to do a full CI run with the cloned ECP module on.
The task is to set up a nightly job that does a full CI run on development with the new ECP module on and only members of the bignum team get notifications about it.
(Ask @bensze01 for help if needed.)

I don't understand why we would use this approach.
It's a separate nightly job so if we break something in a pull request, we won't know it until the code has been merged. It's extra work to run and monitor this job, and the person monitoring the job won't necessarily know what's going on with the changes.
We don't expect changes to the new bignum itself, but it can be affected by global changes, e.g. to platform functions (like zeroization), to build scripts, to the test framework...

would like to do a full CI run with the cloned ECP module on.

Why would we run the whole CI? Why not just run the unit tests in the full configuration — once on 64-bit and once on 32-bit? (Also little vs big endian once we have that.) I don't understand why we'd want test the full matrix of configurations against that particular option. We don't do that for everest and p256-m, why would we do it for this ECC implementation?

It is a separate job because the idea was that the bignum team would monitor this job and we wouldn't inconvenience the rest of the team (This was before the bignum work was paused.)

We don't do that for everest and p256-m, why would we do it for this ECC implementation?

Because unlike those, this eventually will become part of the codebase that will need to pass the full CI when we remove the flag and integrate the new module.
It is a full run, because if we would develop it without cloning, we would get a full CI run with the new code and when we remove the flag, the code will need to pass the full CI. Like this we can be confident that the new code passes the full CI when the flag is removed. If we run a subset, there is always the possibility that we are not as clever as we think we are. How big this residual risk is arguable of course, but I since this is a nightly run, I think the cost should be acceptable.

Note from today's team call: I hadn't realized that we were doing this in addition to regular all.sh jobs. I thought this was proposed as a substitute to all.sh jobs.
As long as we are testing the new code in all.sh with sufficient coverage, I have no objection in terms of risk. Considering the nature of the feature, I think sufficient coverage would be one 64-bit build and one 32-bit build, both running unit tests with Asan.
With respect to additional testing, I don't think the extra complexity is worth it. We are adding new complexity in all.sh (which is already too complex as it is, and overdue for a python rewrite). We are also adding complexity to the CI systems, which historically have not been reliable. There's little risk that the new bignum will break exotic configurations as long as it's passing its unit tests. Perhaps misplaced ifdefs that break certain sets of ECC curves, but that's easily resolved. There may be warnings from some compilers on the new bignum, but that too is easily resolved. So I think we're making a bad trade-off here in terms of amount of work vs benefit. But I won't oppose this design.

See https://github.com/Mbed-TLS/mbedtls/pull/7824#issuecomment-1650182783


actix2 upgrade

Fixes #89, brings the internal actix dependencies up to actix2, which is based on tokio-1.x.
I tried to make the minimal changes necessary for actix2, but nevertheless, other dependencies had to be brought up to date: crossbeam*, tokio-1, oci-registry, and some others.
Some actix apis went away and I created work-around functions. One example: https://github.com/stevelr/wasmCloud/blob/actix2/crates/wasmcloud-control-interface/src/nats_util.rs
As far as I know, no external apis changed, except that most capability providers will probably also need updates.
The only other "optional" changes I made besides immediate or transitive consequences of the actix2 update were making the log crate consistent (0.4.14) and adding some logging for error conditions.
All test pass "on my machine" but that doesn't mean it will work for everyone.
I've updated four capability providers: logging, nats-kvcache, http-server, and redis, which I will push as 4 separate PRs so you can pick and choose if you don't want to add them all at once. Realistically, you probably want to do them all at once too.

build checks are going to fail because there are unaviodable co-dependencies with capability-providers

To test this you'll need capability-providers PR 51 in a directory under the same parent as this

Completed all updates that Kevin and I talked about yesterday. Per @brooksmtownsend 's comment above, we can't push the crate until https://github.com/deislabs/krustlet/issues/543 is resolved.

Changes LGTM, but as stated above unfortunately we'll need to wait for oci-distribution 0.6.0 to be released before we can merge this in, as it'll prevent us from publishing any versions to crates.io until that is released. Perhaps we can bring this up in our community meeting today @autodidaddict.
Once the capability-providers PR is merged in, I'd like to see these tests run fully as well. At the time of reviewing yesterday all of them passed locally for me (with all appropriate relative dependencies) so I'm confident that they won't be a blocker.

We can merge prior to releasing. The main branch doesn't need to be a crates version until we cut a release.

Conflicts with main need to be resolved

from krustlet community meeting, release for oci-distribution is planned for late this week (3/22-3/26), so we can either merge this and change the git dependency once that is released OR keep this PR going until then. I lean towards merging this in so we don't keep this PR out here for too long (maybe after we do the 0.15.4 release to get some of the new features in). Thoughts @autodidaddict ?

If the only thing keeping this from merging is the inability to publish to crates, then we can go ahead and merge. If we can compile and pass all the tests then the PR is merge-able. We just can't cut a release until we can change the git dependency to a crates dependency.
What do you think?

@autodidaddict I'd love to cut the release for 0.15.4 in #130 to get in some of our recent fixes, but because of the community meeting I'm confident we won't be blocked for more than a week with merging

@stevelr I just merged in some of the dependency conflicts from the previous PRs that were merged in, when the tests pass I approve for merge 🙂


add use get image hook

What does this PR do?
add useGetImage custom hook
add several tests for the rgb generator in selector.ts
add mock component
All Submissions:

[x] Have you followed the guidelines in our Contributing document?
[x] Have you successfully ran tests with your changes locally? Including container validation.
[x] Have you lint your code locally prior to submission?
[x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
[x] Have you labelled this PR correctly? E.G. major, milestone, breaking, breaking-change, minor, feature, enhancement, patch, fix, chore, refactor etc

Changes to Core Features:

[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[x] Have you written new tests for your core changes, as applicable?

Not a big change but would be good to look at some tests with smaller fft numbers to like 128 , 256 and 512


Unexpected keyword argument 'capture_output'

Hi! Thanks for this great open-source repository. I'm having a play with it on a ubuntu machine. I installed ffmpeg and created a virtual environment for Python. Then installed the requirements and ran the tool with venv/bin/python3.6 tesla_dashcam/tesla_dashcam.py /path/to/pics.
That results in an error, both on the master branch as the latest release branch.
Stacktrace:
Discovered 2 folders containing total of 10 files, retrieving clip data.
Traceback (most recent call last):
  File "tesla_dashcam/tesla_dashcam.py", line 2518, in <module>
    sys.exit(main())
  File "tesla_dashcam/tesla_dashcam.py", line 2513, in main
    video_settings["source_folder"], args.exclude_subdirs, video_settings
  File "tesla_dashcam/tesla_dashcam.py", line 697, in get_movie_files
    video_settings["ffmpeg_exec"], [front_path, left_path, right_path]
  File "tesla_dashcam/tesla_dashcam.py", line 792, in get_metadata
    command_result = run(ffmpeg_command, capture_output=True, text=True)
  File "/usr/lib/python3.6/subprocess.py", line 423, in run
    with Popen(*popenargs, **kwargs) as process:
TypeError: __init__() got an unexpected keyword argument 'capture_output'

Any idea what's causing this?

I got it working with venv after also installing python3.7-dev, without it I couldn't install the dependencies. Thanks for your help and quick reply @ehendrix23. :clap:


Fix RangeMaintainingScrollPhysics

It now uses the scroll metrics as they stood at the end of the last frame.
It previously used a weird combination of the old extents and the newish position, which led to some weird effects when the position had been changed in expectation of a viewport or content dimension change.

As it stands this breaks a bunch of tests. :-/ Investigating...

Well it passes the tests now, at least.

@Hixie I've stared testing with this patch, and so far so good. Thanks!

should some small epsilon be added to account for floating point error in case the new scroll extend is essentially the same but off by an epsilon due to some layout logic?

We definitely shouldn't just add epsilon, but maybe we could use nearEqual... I think we should wait until that's a real problem though.

Added more documentation. Will land on green unless I hear otherwise. Thanks for the reviews!

Since this is a 1.20 cherrypick candidate, I landed on green.

Fix for https://github.com/flutter/flutter/issues/60288


Validate --ip and --ip6 for docker create

- What I did
This fix tries to fix the issue raised in #25863 where --ip value is not validated for docker create. As a result, the IP address passed by --ip is not used for docker create (ignored silently).
- How I did it
This fix adds validation in the daemon so that --ip and  --ip6 are properly validated for docker create.
- How to verify it
An integration test has been added to cover the changes.
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)
This fix fixes #25863.
Signed-off-by: Yong Tang<EMAIL_ADDRESS>

Couple of nits.
Thanks @yongtang

Thanks @cpuguy83. The comments have been addressed and the pull request has been updated. Please let me know if there are any additional issues.

LGTM

LGTM 🐯
@yongtang This will need a small note on docker_remote_api.md in v1.25 API Changes though 👼

Thanks @vdemeester. The pull request has been updated with documentation update. Please let me know if there are any additional issues.

docs LGTM 🐸

Needs a rebase

Thanks @justincormack. The pull request has been rebased. Let me know if there are any other issues.

docs LGTM


Integration Test - Release - 2022/01/13 03:18:01

Auto create for integration test. IssueCommandFlow

#pri1

Just type '#pri3'

#pri2


Support for segment images?

Are you interested in supporting segment images?
I was able to create a mock up of how it might work using NSTextAttachment and UILabel's attributedText so there are no UIImageViews involved.
But if you wanted to go in this direction, it would take some work make it backward compatible with the other public properties.

As I mention in the Todos, I'd like to make the control very flexible and allow for any kind of UIView subclass to be used as segment.
The way I have it in my mind is to have the segment view conform to a protocol that requires it to provide a selected and normal mode, much like how it is now with the UILabels. I don't know if I'm missing something right now, but that's the direction I'd like to see this go.
Of course, such a change would necessarily break the current public API.

That makes sense and would be a great addition.


Add keyboard system

Resolves #20

Codecov Report

Merging #29 into master will increase coverage by 0.43%.
The diff coverage is 93.75%.

@@            Coverage Diff             @@
##           master      #29      +/-   ##
==========================================
+ Coverage   56.95%   57.39%   +0.43%
==========================================
  Files          37       38       +1
  Lines         906      920      +14
  Branches       89       90       +1
==========================================
+ Hits          516      528      +12
  Misses        310      310
- Partials       80       82       +2

Flag
Coverage Δ

#unittests
57.39% <93.75%> (+0.43%)
:arrow_up:

Impacted Files
Coverage Δ

src/entity/entity.ts
94.11% <0%> (-0.33%)
:arrow_down:

src/standard/keyboard/keyboard_system.ts
100% <100%> (ø)

src/system/system.ts
80.32% <0%> (-3.28%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8a46a5...71da9fe. Read the comment docs.


Rewrite site in Tailwind CSS

Hey @driesvints is tailwindo something we can do?

I'm planning on using the new sidebar ui from Tailwind UI once it's available but until then this is a bit on hold I'm afraid.


Forecast shows the previous day and the current day

Describe the bug
The forecast section shows the previous and current day I am wanting this to just display the next 5 days. Can not figure out how to make this happen. I am using accuweather for the information in the card if that is relevant.
Screenshots

Desktop (please complete the following information):

WEATHER-CHART-CARD VERSION 2.4.6
HOME ASSISTANT VERSION AND INSTALLATION TYPE 2024.6.0 Home assistant Core
OS: 12.3

Ok so I was able to fix this issue but now I can't see an hourly forecast that I set up using this in another card


Duplicate module name error

Hi,
I m getting Duplicate module name error errors (see below for actual error) when I've installed react-native-clean-form. If I remove this error is not coming. With little Google search, I think library needs to include react and react-native as peerDependency.
See below:
https://github.com/RealOrangeOne/react-native-mock/issues/58
https://github.com/stephy/CalendarPicker/issues/24
https://github.com/facebook/react-native/issues/3558
https://github.com/facebook/react-native/issues/7384
...
This warning is caused by a @providesModule declaration with the same name across two different files.
jest-haste-map: @providesModule naming collision:
  Duplicate module name: ReactHostOperationHistoryHook
  Paths: C:\Users\kh1015\manikanta\ditcos-work\readymix\node_modules\react-native-clean-form\node_modules\react-native\Libraries\Renderer\src\renderers\shared\hooks\ReactHostOperationHistoryHook.js collides with C:\Users\kh1015\manikanta\ditcos-work\readymix\node_modules\react-native\Libraries\Renderer\src\renderers\shared\hooks\ReactHostOperationHistoryHook.js

This warning is caused by a @providesModule declaration with the same name across two different files.
jest-haste-map: @providesModule naming collision:
  Duplicate module name: ReactInstanceMap
  Paths: C:\Users\kh1015\manikanta\ditcos-work\readymix\node_modules\react-native-clean-form\node_modules\react-native\Libraries\Renderer\src\renderers\shared\shared\ReactInstanceMap.js collides with C:\Users\kh1015\manikanta\ditcos-work\readymix\node_modules\react-native\Libraries\Renderer\src\renderers\shared\shared\ReactInstanceMap.js

This warning is caused by a @providesModule declaration with the same name across two different files.
jest-haste-map: @providesModule naming collision:
  Duplicate module name: shouldUpdateReactComponent
  Paths: C:\Users\kh1015\manikanta\ditcos-work\readymix\node_modules\react-native-clean-form\node_modules\react-native\Libraries\Renderer\src\renderers\shared\shared\shouldUpdateReactComponent.js collides with C:\Users\kh1015\manikanta\ditcos-work\readymix\node_modules\react-native\Libraries\Renderer\src\renderers\shared\shared\shouldUpdateReactComponent.js

This warning is caused by a @providesModule declaration with the same name across two different files.
jest-haste-map: @providesModule naming collision:
  Duplicate module name: ReactErrorUtils
  Paths: C:\Users\kh1015\manikanta\ditcos-work\readymix\node_modules\react-native-clean-form\node_modules\react-native\Libraries\Renderer\src\renderers\shared\utils\ReactErrorUtils.js collides with C:\Users\kh1015\manikanta\ditcos-work\readymix\node_modules\react-native\Libraries\Renderer\src\renderers\shared\utils\ReactErrorUtils.js

This warning is caused by a @providesModule declaration with the same name across two different files.
jest-haste-map: @providesModule naming collision:
  Duplicate module name: ReactTypeOfWork
  Paths: C:\Users\kh1015\manikanta\ditcos-work\readymix\node_modules\react-native-clean-form\node_modules\react-native\Libraries\Renderer\src\renderers\shared\fiber\ReactTypeOfWork.js collides with C:\Users\kh1015\manikanta\ditcos-work\readymix\node_modules\react-native\Libraries\Renderer\src\renderers\shared\fiber\ReactTypeOfWork.js
...

I see this as well.  It must be an issue with the latest react-native update.

I deleted the node_modules folder inside of react-native-clean-form and the errors are gone.  Not sure what kind of dependencies it has on that.  It appears to just be a duplicate of react-native and some other common packages though.

In fact, I've deleted the react-native from node_modules/react-native-clean-form/node_modules

@manikantag do you have this issue mentioned in #7 after deleting the react-native folder?

@weiliank I m not using redux-form, yet!

@manikantag npm start -- --reset-cache fixed this for me.

@mwarger Oh, thanks. Will try that,

These issues are related https://github.com/esbenp/react-native-clean-form/issues/6
I created a small pull request https://github.com/esbenp/react-native-clean-form/pull/12 to fix that.

@esbenp this can be closed after #12 has been merged ;)

Thanks for reporting. No feedback at the moment and with the current version I can not reproduce this issue.
If there are still issues please reopen the issue and report your problems :)

I am having same problem, detailed steps here:
https://github.com/esbenp/react-native-clean-form/issues/36


Add getNamedArguments to get the list of the named arguments, if any.

In some cases the named arguments may be needed to get their corresponding values.

Thanks!


Memory leak in Microsoft.Extensions.Logging.Internal.FormattedLogValues

The FormattedLogValues causes a serious memory leak. After a day about 1Gb of memory is wasted in my usage. The cause of the problem is:
private static ConcurrentDictionary<string, LogValuesFormatter> _formatters = new ConcurrentDictionary<string, LogValuesFormatter>();
...
...
_formatters.GetOrAdd(format, f => new LogValuesFormatter(f));
This code will just add objects and never clean them.

@meichtf Do you have some examples of what you are logging that fill up the cache? I would like to get the scenario right when we are choosing a fix.
It looks like the only way for this to happen is if you are doing something like combining string interpolation and string formatting, like _logger.LogInformation($"{DateTime.UtcNow} {{0}}", DateTime.UtcNow); is something like that what you are doing?

Yes, this is a good example you just provided. I know this is not a great usage of the API, but it should still not cause a leak.

That's really a bad use of the API, what are your actually doing in your application. There's obviously a trade off being made here. Regular usage of the API doesn't cause problem. It's possible we should just have an upper limit on the amount of values

An upper limit on the collection is what I proposed when we first looked at this, and I expect we will just do that. But I would like to see exactly what you are logging that is giving you the problem. If you put the values that are changing frequently in arguments then this problem goes away, is there a reason you can't or don't want to do that? or was it just that it didn't occur to you at the time? or something else?

One other option to consider, but which I haven't tried it out, is to only cache formatters for interned strings (string.IsInterned(s)):
// Literals are interned; would be cached
"Hello {Name}"

// Generated strings are not interned; not cached
"Hello {Name}" + DateTime.UtcNow

Suggested originally by @jods4 IIRC.
Serilog uses an upper bound on the cache size currently, but might switch to this strategy or a hybrid one (cap the size for non-interned formats, but always allow interned formats to be added). Curious whether there are any obvious holes in it.
The Roslyn-based analyzer in https://github.com/Suchiman/SerilogAnalyzer detects usage of logging methods with non-constant templates - doing something similar for MEL, or broadening the SerilogAnalyzer project to cover it, would be the optimal solution I think :-)

@nblumhardt Can you split this suggestion into another issue to discuss? Even with this an unbounded cache is probably never a good idea, so we will add the max. But I am interested in the ideas enough to think about it in a different thread :).

.NET Core doesn't have string interning AFAIK.

@glennc

Even with this an unbounded cache is probably never a good idea, so we will add the max.

If you only cache interned strings, you cannot create a true memory leak, as those strings are guaranteed to be kept in memory, whether your cache exists or not. So basically, if there is a leak it exists in the application already.
Note that in a typical application the set of interned strings is determined at compile time and rarely (often never) changes.
@davidfowl
Interesting.
Are you speaking of the ability to intern additional strings at runtime or even just the concept?
When C# compiles a program, it dedupes all strings and interns them, does this not apply to a .NET Core build?
The use case I had in mind when I suggested that for NLog was to avoid this specific issue we have here. Proper usage of logging API should use constant strings and parameters; and compile-time constant strings are interned (at least in old-school .NET).

The APIs for checking whether a string is interned and the ability to call intern strings is gone.

It is there - once you upgrade to netcoreapp2.0:
https://github.com/dotnet/corefx/blob/5bd6dea77374feccbc859d4a771f9fff7e973d86/src/System.Runtime/ref/System.Runtime.cs#L2041

https://github.com/aspnet/Logging/commit/cc503aaed0b9fb3e93345b28629e80581337d3c1


Decision history view

Design for the Decision history view:

@georgeschena i realise this is still a draft, but would you like some early comments?

it's better to rebase on top of master than merging… you're more likely to get the right stuff happening and the history then is clearer

let's see if that rebase is possible :)

Didn't have any issues with the rebase :)

Didn't have any issues with the rebase :)

what a pleasant surprise!


Fixing break-line in view mode

@giuliaghisini can you please review this because I am removing your changes. I am doing this because when we press shift+enter we want to keep the empty line. Before this Pr, the edit and view mode is not the same.

@iFlameing is there any way we can write a Cypress test to make sure this regression does not occur again in the future? Since our DraftJS amendments are always very brittle we should try to make sure those features are properly tested so we can detect regressions.

@giuliaghisini can you please review this because I am removing your changes. I am doing this because when we press shift+enter we want to keep the empty line. Before this Pr, the edit and view mode is not the same.

@iFlameing i've never changed those lines! That code was introduced in this pr: https://github.com/plone/volto/commit/aa5258b7c033aa0adb6e4776f9b452fe2e77c38d#diff-0bd4999bb5f7e62daf4e3b68871bfa05.
This pr scares me a little, and I would like to try it on some of our sites.
Anyway, your intent was to show in view all new-lines at the end of the string? If so, isn't enough to add new empty text blocks after the block containing the text?

IMHO we're beating a dead horse here, the whole shift+return is trying to come up with a workaround that's against the spirit of the Volto richtext editor: each paragraph is a separate block and this way Volto blocks can be mixed with the text.

IMHO we're beating a dead horse here, the whole shift+return is trying to come up with a workaround that's against the spirit of the Volto richtext editor: each paragraph is a separate block and this way Volto blocks can be mixed with the text.

yes, but shift+return will be usefull when you have contentypes without blocks, and you have a field that contains formatted text

@giuliaghisini if it's a "metadata" field (so not inside the block) then the enter key works as well, it creates paragraphs. In any case, I think having the break option is fine with shift+return is fine

@tiberiuichim SHIFT+RETURN is a pretty basic requirement for all kinds of blocks. Not in the standard Volto editor of course but in more complex blocks like blocks with image left and text right or our teaser grid blocks or rich-text fields that do not have the Volto editor.
We made the UX decision that a return creates a new block and that's fine. Though, there are lots of edge cases where SHIFT+RETURN is our escape hatch. And our editors are actually used to that pattern from Word and other editors (something I wasn't aware of TBH).

@tisto It is ready for merge :)


Ability to change logging levels at a component level dynamically

Hi,
i want the ability to change log levels at a pinot component level (controller, broker etc) dynamically without requiring a restarts
this is a pretty useful feature for anyone running pinot in production
ideally i would like this to be saved as some config in ZK and some buttons on the pinot ui to toggle between different levels

This is a great feature! Do you want to help contribute this?

Submitted a PR: https://github.com/apache/pinot/pull/9180


json-type JSON codegen

[x] Write codegen for efficient JSON serialization given schema.
[x] Add .isInteger or type: 'u8' | 'u16' | 'u32' ... annotations to "num" json-type.
[x] Add "safe string" annotation to json-type. Which does not need to be escaped in:

[x] JSON.stringify
[x] and when encoding UTF-8 string in MessagePack

Maybe a string could also have a type, say type: 'ascii' | 'utf8' ....
[x] Add README.

:tada: This issue has been resolved in version 6.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Add extension sponsoring config and republish it

It's a maybe. Vote here: https://twitter.com/TarasNovak/status/1557350546893414400
See new sponsor links config in VSCode May 2022 release notes: https://code.visualstudio.com/updates/v1_68#_sponsoring-extensions
Still no proper github sponsorship integration api for extension devs to use, even though it used to be, and still is the most frequently requested vscode ext. devs feature. Some vague promises been made by some vscode team members in the unofficial vscode dev community slack back in April, but I have not seen any updates on that yet.
Till then, I am not sure I want to maintain some of the extensions I unpublished like this data table renderers for code notebooks.
I brought it up again in new vscode discussions repo: https://github.com/microsoft/vscode-discussions/discussions/98

This extension has been published in vscode marketplace again.
See our announcement on twitter: https://twitter.com/TarasNovak/status/1560402316527894531

released: https://github.com/RandomFractals/vscode-data-table/releases/tag/v1.12.0


[Guide] Project Euler: Problem 10: Summation of primes

Added Project Euler: Problem 10: Summation of primes method, solution and reference

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

Great job @ezioda004 and thank you for completing this stub!


[BEAM-6349] Revert "Treat VarInt encoding as a Beam primitive encoding in Dataflo…

…w runner (#7351)"
This reverts commit bac909b8e237ef8a2ab7e17ac986e5cc90143e5b.
We've encountered some blocking issues while developing load tests (both batch and streaming) due to the issues described here: https://issues.apache.org/jira/browse/BEAM-6349. If there's no better solution I suggest reverting the PR.

Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

It will help us expedite review of your Pull Request if you tag someone (e.g. @username) to look at it.
  Is there some other part of the set-up for running load tests that has a frozen old jar or something, maybe an old container image, and so mixing old code with new code?

@CraigChambersG was able to run this on his project so it seems to be a problem with apache-beam-testing project (some old jars? Gradle cache on my machine?) Either way closing.
Thanks @CraigChambersG


home_scroll_perf__timeline_summary 99th_percentile_frame_rasterizer_time_millis regression

Around 2019-03-12, the worst case performance for home_scroll_perf__timeline_summary 99th_percentile_frame_rasterizer_time_millis regressed.
The 90th percentile rasterizer performance did not noticeably regress, nor did the worst frame rasterizer performance, which suggests that there's one particular frame in the benchmark which got worse, and that it's not an infrastructure problem.
cc @jason-simmons @liyuqian

I pinpointed the regression on https://github.com/flutter/flutter/commit/c78ccb0 which happened on 03/12 :

@Hixie @stereotype441

It doesn't make much sense to me that https://github.com/flutter/flutter/commit/c78ccb0 could regress the performance. Maybe it's another instance of https://github.com/flutter/flutter/issues/27574

There are two engine rolls https://github.com/flutter/flutter/commit/c2f4386c548b4f6a5a632d05ed80e4d28b243fa9 and https://github.com/flutter/flutter/commit/ddee4f716cf8fc07ee179671d25c66883a0876ea around https://github.com/flutter/flutter/commit/c78ccb0
Does anyone know how to verify which version of the engine that https://github.com/flutter/flutter/commit/c78ccb0 is using? @jonahwilliams @jason-simmons @dnfield

https://github.com/flutter/flutter/blob/c78ccb0b5ef93a9799b0b37ef3a89802d27e7bb6/bin/internal/engine.version

It is on 0d2cf5857b2be0949435f60c0188f1aed4d93c93

Because of https://github.com/flutter/flutter/issues/27574, https://github.com/flutter/flutter/blob/c78ccb0b5ef93a9799b0b37ef3a89802d27e7bb6/bin/internal/engine.version is not a reliable source of the engine version.

Never mind @jonahwilliams , @dnfield , @jason-simmons : https://github.com/flutter/flutter/commit/c78ccb0 doesn't change the engine.version so no matter how the engine artifact messed up, it should use the same engine as https://github.com/flutter/flutter/commit/e100514
Hence the engine and https://github.com/flutter/flutter/issues/27574 seem to be innocent here.
So https://github.com/flutter/flutter/commit/c78ccb0 is back to our major suspect now. I'll rerun my tests to verify that.

I think that I may have found a bug in my bisection script. I'm rerunning it. https://github.com/flutter/flutter/commit/c78ccb0 is no longer our suspect due to the bug.

After fixing the bug, I now pinpointed the regression on engine roll https://github.com/flutter/flutter/commit/a29906d .

The root cause is likely @dnfield 's AA changes for shape layers.
I think the regression is in some sense expected, so we could just rebase the benchmark and close this bug. @dnfield : please confirm if that makes sense. If so, please rebase and close accordingly.

Makes sense to me


Improve the error message for type conversion

Description:
Please refer following sample.
type Person record {
    string name;
    int age;
};

public function main() {
    json j = {"fname": "Jane", "lnae": "Doe", "age": 14};
    Person p1 = checkpanic j.fromJsonWithType();
}

Will result as an error like,
error: {ballerina/lang.value}ConversionError {"message":"'map' value cannot be converted to 'Person'"}
at ballerina.lang.value.1_0_0:fromJsonWithType(value.bal:251)
waruna.abcProject.0_1_0:main(main.bal:33)
The error message does not have an exact reason why we couldn't convert JSON value to Person record. We need to improve it.

We need to check how we can improve messages with complex type conversions as well.
ex
type Person record {
    string name;
    int age;
};

type Employee record {
    string name;
};

type Student record {
    string name;
};

public function main() {
    json j = {"fname": "Jane", "lnae": "Doe", "age": 14};
    Employee|Student|Person p1 = checkpanic j.fromJsonWithType();

}

Need to handle both cloneWithType and jsonWithType functions.

Related issues: https://github.com/ballerina-platform/ballerina-lang/issues/14810, https://github.com/ballerina-platform/ballerina-lang/issues/31694


To enable HTML rendering for ItemList's name property

The purpose of this commit is to enable ItemList name property to display html content when find 'html' key passed in.

Hi Yanhao!
I think we should avoid using html as the key to identify the intent of a developer to render the browser name field as HTML, to avoid potential conflicts with a model attribute named html. What do you think about renderHtml instead?

@ifox sounds good, will push a new commit later today!


agent, plugin: Add "dump state" endpoints

There was some bulk renaming required in the plugin, so I extracted that into a separate PR (#75) to make reviewing / blame nicer.
I've done a little bit of manual testing for it, seems fine. The JSON output isn't small, so... thorough testing will probably be easier with a dedicated tool to analyze the output.
For now, due to "quirks" of util.AddHandler, the body of the request is expected to be "{}". So, example usage would be something like:
curl -X GET -d '{}' 'http://localhost:10300/"

(for the current default autoscaler-agent port)

this PR didn't run all of the checks/e2e stuff, probably because it's behind main? I think merging main into this will help.

Yep :) Rebased, should be good now


[AIP-6492] Supporting JSONType as param

Good test cases and clean handling of json conversion with try ... except. One minor suggestions for the test case.
Mentioning two more things, not necessarily part of this PR, that I'd like to have you get used to:

Can you write a bit more in the PR description? This PR is relatively short with self-descriptive title but it's mostly to get started on the habit.

This is more important in the future people reviewing your PR doesn't have the same context as I do. It's also a nice record of why the changes are made if anyone (sometimes yourself) wonders months later when debugging.
The description can contain a summary of what's being changed - especially if there are multiple commits or lots of code changes.
More importantly describe why a change is needed since this part of info can't be found in code.

Use formatter (should take you only 5 min)

In Metaflow we happen to have black setup for pre-commit: https://github.com/zillow/metaflow/blob/zillow/argo/.pre-commit-config.yaml. To utilize it, follow step 1 and 3 of this quick start guide https://pre-commit.com/#quick-start.
With this setup, all your future commit in the local git repo will be automatically formatted.

Re your comment above re PR description and using black for formatting, I took note of it and will follow your advice in future PRs


Set CMK of DBFS root via ARM Template

Rather than setting up a DBFS root to use a CMK via the UI as documented in this article are we able to use the Databricks Workspace ARM template to specify the reference to a key in AKV to use for at rest encryption for DBFS so that my deployed Databricks is already setup with a CMK for the DBFS root at the time of deployment?
The ARM template for a Databricks workspace has an "encryption" object and a "prepareEncryption" object which suggests that this might be technically possible however none of the sample ARM deployment templates on that page actually illustrate the use of these parameters to configure CMK for the DBFS root.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 91424758-63e3-7b22-5a81-80e5a83a98e5
Version Independent ID: 7248b056-efcc-de37-0202-6ee809969444
Content: Configure customer-managed keys on default (root) DBFS - Azure Databricks
Content Source: databricks/security/keys/customer-managed-keys-dbfs.md
Service: azure-databricks
GitHub Login: @mssaperla
Microsoft Alias: saperla

@pnarsi - Thanks for the query. We are currently investigating into it and will update you shortly.

@pnarsi - I am moving it to content owner to review.
@mssaperla - Can you please take a look?

@pnarsi We have passed this question along to Databricks engineering for review. We'll update this issue when we've heard back.

@leifbro @HarithaMaddi-MSFT
There is now an example quickstart template illustrating using ARM to setup DBFS encryption here: https://github.com/Azure/azure-quickstart-templates/tree/master/quickstarts/microsoft.databricks/databricks-workspace-with-customer-managed-keys.
The ARM documentation has also been updated with better descriptions of the "encryption" object and  "prepareEncryption" objects

I would suggest updating this link https://docs.microsoft.com/en-us/azure/databricks/security/keys/customer-managed-keys-dbfs/ to show that ARM based configuration of this feature is possible.

Thanks for this helpful feedback, @pnarsi. We have filed a ticket in the Databricks bug tracking system: DOC-3002. We will update this Git issue when the ticket has been resolved. #label:"in-progress".

Thanks for your dedication to our documentation. Unfortunately, we have been unable to review your issue and apologize for the delayed response. The requested updates have not yet been made. The timeline for resolution varies based on resourcing. We've created an internal work item to incorporate your suggestions. We are closing this issue for now, but feel free to comment here as necessary.
#please-close

#please-close


Changes to Config.hs

Ideally this class should require only toGraph, initial, and final functions.

Also it might be nice to make empty, epsilon, literal, fromSet, etc. into part of some class using an existential type variable for q, but perhaps this should be another separate issue.


Dispatch aggregate

The goal of this PR is to dispatch aggregate, currently written in two files, by directly implementing it in _agg_joiner.py.
Following discussions with @Vincent-Maladiere and @jeromedockes, AggJoiner and AggTarget now require the operations parameter by default, and will try to apply all operations on all columns — as opposed to now, where columns are separated in categorical and numeric and only some operations are computed on each category.
I’m planning on doing follow ups to completely remove the _pandas.py, _polars.py, _namespace.py files, and on refactoring AggTarget with cross-fitting.

Thanks a lot @Vincent-Maladiere !
To answer your points:

I can remove _check_dataframes and use CheckInputDataFrame, I just need to handle the case where aux_table="X" to keep the option of using the placeholder. I agree that AggTarget's check_inputs could be simplified, I plan on cleaning it in another PR (it's also missing some tests).
Sure ! Is it something to do here or in another PR ? Should we open an issue so that we add this method for other transformers like Joiner ?
I'm not sure we want this. On the one hand, it might be useful for long-term compatibility when selectors are public, so that people can either use list of cols or selectors directly. On the other, while I think it makes sense to say "compute the mean on all numeric columns", you are not going to join dataframes on all numeric or all string columns with key.

and 2. can be done in this PR, it's not a huge change.

I agree that 3. use cases are rarer, but it looks weird to support selectors for the cols argument only. I might have keys that I can identify using regexes for instance, when the name of the column changes for whatever reason. Not a strong requirement, but it shouldn't be too costly to add.

and 2. can be done in this PR, it's not a huge change.

I agree that 3. use cases are rarer, but it looks weird to support selectors for the cols argument only. I might have keys that I can identify using regexes for instance, when the name of the column changes for whatever reason. Not a strong requirement, but it shouldn't be too costly to add.

Doing 1 & 2 here, the main issue being checking dtypes
I don't have a strong opinion about 3

If think the PR is good for a second pass. I probably need to rename it and add some extra things in the changelog.
@Vincent-Maladiere I addressed points 1 & 2: simplifying AggTarget's _check_dataframes (it was more of a complete RFC of AggTarget) and adding a get_feature_names_out method. Point 3 I didn't implement because I'm not sure it's a good idea to indicate users "you should use selectors to choose keys", so I didn't implement it in this PR. Shouldn't be a blocker for the review though and is a quite minor change IMO

Sorry, there's some duplicate with Jerome's feedback, we reviewed it simultaneously

After discussion with @GaelVaroquaux, it was decided we won't make selectors public here. Let's open a meta issue on their support and documentation first

Let's aim to remove _namespace.py, _polars.py, and _pandas in a follow-up PR!

I'm on it :)

the codecov failure is spurious, codecov seems to be mixing the report with that of an older commit and is showing a different diff than the actual one


Problem with passing the tests on this challenge

Challenge Change the Font Size of an Element has an issue.
User Agent is: Mozilla/5.0 (Windows NT 10.0; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/54.0.2840.71 Safari/537.36.
Please describe how to reproduce this issue, and include links to screenshots if possible.

My code:

CatPhotoApp

Kitty ipsum dolor sit amet, shed everywhere shed everywhere stretching attack your ankles chase the red dot, hairball run catnip eat the grass sniff.

Purr jump eat the grass rip the couch scratched sunbathe, shed everywhere rip the couch sleep in the sink fluffy fur catnip scratched.

@Drewfow94 thanks for the issue but if you get stuck or have questions with a challenge in the future, please first ask questions to the Help Room. Hint: p elements are elements themselves, not classes. Happy coding!

If this wasn't a place to ask for help too, the website wouldn't direct you here.


feature request

hey
nice script. but can be made more user friendly if tab selection is also there.
any case. great work.

I am getting an error at document.body.appendChild(prompt); line that body is null..please help me..I want to use it for div contenteditable tag..


RC2: Update docs generated property docs since triggers will be supported

In RC1 you can't really setup ValueGeneratedOnAddOrUpdate for properties other than ROWVERSION because you can't use triggers (due to aspnet/EntityFramework#1441).
We should update the following docs with examples once they work end-to-end:

generated-properties.rst
explicit-generated-values.rst

Adding a reference to aspnet/EntityFramework#5793 so this can be easily found by those getting here from the docs.


Add aliases to Future.result() dict

Coverage increased (+0.2%) to 77.515% when pulling f6505c0abadc7360800d51ba3c2e8101ddd70656 on randomir:master into ba54e898846af6c088130d4195f7d4403ca06000 on dwavesystems:master.


failed hook at huawei Hisilicon CPU

I have tried two device ，one of huawei honor 6 ，another is huawei p9. While execute registerInlineHook function, app will look dead. Other Qualcomm cpu can work good. Can I resolve this problem?

Would you please give me some details of your SO file and function?


can not reach 66%

Thanks for your great work. But I still have some issues needs your help:
I traian on voc07+12_train datasets for 160000 steps(train 30000+finetune 130000), and finally I found that mAP is 57% below. I dont konw why, Is my datasets(about 2.4GB) wrong?
 This is evaluted on voc07_test(trained on voc07+12_train)
Another question is that I trianed on voc07_train dataset, and  got a higher mAP than trained on voc07+12_train.

Hi,  can you also post your loss chart here?  To be honest, it's a bit hard to say outright where the problem is. The codes should be all right, I remember there a few other people repeated the result with the same code base.
You second chart does not look right to me, in that the accuracy actually decrease from 25k to 40k iteration.. One possible cause is that you might forget to adjust learning rate when you start fine tuning all the parameters in the model.  Please also double check  the readme and ensure you followed the steps as suggested.

Thank you! I will check my work. After finish, I will report my new result.

Thank you! I will check my work. After finish, I will report my new result.@Levin Jian

@LevinJ  Thank you! I will check my work, and report new result.

I’ve got 63% mAP. Thanks a lot.

PS: The mAP we use reference AP_VOC2012/mAP   not  AP_VOC2007/mAP ?
@LevinJ

hey
i dont know who you are but i think that you typed in the wrong mail adress
short question : what are yu doing with these Maps ?
good luck
cheers
2017-10-26 12:01 GMT+02:00 CangHaiQingYue<EMAIL_ADDRESS>
I’ve got 63% mAP. Thanks a lot.
[image: default]
https://user-images.githubusercontent.com/30284428/32046913-ffce7d08-ba76-11e7-8694-653fe71ec68e.png
[image: default]
https://user-images.githubusercontent.com/30284428/32047071-77dbde26-ba77-11e7-9ffd-7f2926ad24c6.png
PS: The mAP we use reference AP_VOC2012/mAP not AP_VOC2007/mAP ?
@LevinJ https://github.com/levinj
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/LevinJ/SSD_tensorflow_VOC/issues/10#issuecomment-339616469,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ASlTtMD-x8E4Rj9K7kW7EeLJEn1Y62e0ks5swFh-gaJpZM4QCNBv
.

Hi Levin over there, these charts are used to track the training process of a neural network. Have a nice day :)

see yaa and good luck
2017-12-01 2:40 GMT+01:00 Levin Jian<EMAIL_ADDRESS>
Hi Levin over there, these charts are used to track the training process
of a neural network. Have a nice day :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/LevinJ/SSD_tensorflow_VOC/issues/10#issuecomment-348376697,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ASlTtOSwHxwSYqn5seIQ5srjhAQPyVWzks5s71kegaJpZM4QCNBv
.


Add better error message for Exit code 177 for Job details page

@sunqinzheng - please refine and abjust the issue to the phase I work you will implement with @yqwang-ms

In PHASE 1, can we also extract below error:

@yqwang-ms I think those info are already extacted in stderr console (new in v0.11.0), cc @sunqinzheng to confirm.


How to modify the time zone in Jenkins container?

Issues and Contributing
Please note that only issues related to this Docker image will be addressed here.

If you have Docker related issues, please ask in the Docker user mailing list.
If you have Jenkins related issues, please ask in the Jenkins mailing lists.
If you are not sure, then this is probably not the place to create an issue and you should use any of the previously mentioned mailing lists.

If after going through the previous checklist you still think you should create an issue here please provide:
Docker commands that you execute
Actual result
Expected outcome
Have you tried a non-dockerized Jenkins and get the expected outcome?
Output of docker version
Other relevant information

Hello,
You can use JAVA_OPTS env variable.
Example :
JAVA_OPTS="-Duser.timezone=\"Europe/Paris\""


@tanstack/start ignores vite.ssr.noExternal from app.config

Which project does this relate to?
Start
Describe the bug
The framework ignores user's vite.ssr.noExternal configuration from app.config.
Your Example Website or App
https://stackblitz.com/edit/tanstack-router-bqhlm4?file=app.config.ts
Steps to Reproduce the Bug or Issue
https://github.com/TanStack/router/blob/82121880c0c3f0dcd9654a58479adbcae208f520/packages/start/src/config/index.ts#L475-L479
Expected behavior
The framework takes into account vite.ssr.noExternal configuration from app.config.
Screenshots or Videos
No response
Platform

Version<EMAIL_ADDRESS>
Additional context
No response

do you want to provide a PR for this?

Yes, sure.


Prebaked Frappe bench for faster fm site creation.

[x] Include prebuilt Docker images in the Frappe Bench setup. These apps will be configured to use the latest stable branch, specifically version-15, featuring the following apps:
Frappe
HRMS
ERPNext
[x] Remove docker pull from all operations.
[x] Docker pull images while migrations and provide command fm self update images to update images.
[ ] Schedule daily image baking to ensure continuous updates.

Expected Outcome:
Anticipated reduction in Frappe site creation time.

* [x]  Remove docker pull from all operations.

* [x]  Docker pull images while migrations and provide command `fm self update images` to update images.

Implemented in #116.


Feed [Mobile - IOS] - Under "Sourced by FightPandemics" the blue dot for "US" is collapsing with "Community"

Under "Sourced by FightPandemics" the blue dot for "US" is collapsing with "Community"
Steps to Reproduce:
1 - Using Mobile IOS (I used Iphone 6s) > Be on Feed page (staging)
2 - scroll down to  "Sourced by FightPandemics"
Current Results: The blue dot for "US" is collapsing with "Community"
Expected: The blue dot should be moved below the community
*** Sorry can't paste image here*****

You actually can paste an image, anyhow if you prefer to use a different tool, think of using this one -> https://www.getcloudapp.com/

Also please refer to this page, in how to properly create issues. https://www.notion.so/fightpandemics/How-to-create-a-ticket-or-a-pull-request-on-GitHub-3ee2abb2d7f24b90ac35553dd0a117c4

please @dabartlett give a read to this document -> https://www.notion.so/fightpandemics/How-to-create-a-ticket-new-issue-on-GitHub-4405fe4ef57e4875b18fce25043d3d6a
There are a few more things that we need to add to a new issue / labels, linking the project, assigning the proper PM...

Thank you, I will revise it again - I have been able to add the image for now, but I think a permission may be missing to edit and add the labels.

It's happening for android devices as well.

This issue also exist for Android, as the company location is overlapped by the company type as shown in below screenshot:

As per @ppagarawal request I'm adding this comment.
Please get a line space between the footer and the last text on the Feed page

@dabartlett @rabbi08 Hey guys, we had another issue for this (#701). Do you guys still see this issue?

This issue is fixed now. Please see #1366. There were various issues related to the UI. This one is last merged for post UI issue fix.

@rabbi08 Okay, I will close this issue for now. If you see this happen again, please either reopen this ticket or open a new one! Thanks :)


fastcall Calling convention incorrectly recognized

I created a dummy C program and compiled it using MinGW as a 32-bit PE executable (see fastcall.zip).
One of the functions of the program is called using fastcall:
__attribute__((fastcall)) int foo1(int a, int b, int c, int d)
{

    printf("0x%x 0x%x 0x%x 0x%x\n",a,b,c,d);
    int ret= a*c+b*d;
    printf("Ret: %d\n",ret);
    return ret;
}

Based on the function signature on the GUI Binary Ninja 1.1.1259 (build f51163e8) correctly detects that the first two parameters are passed in ECX and EDX:
int32_t __stdcall sub_401570(int32_t arg1 @ ecx, int32_t arg2 @ edx, ...

... but still annotes the function as stdcall:
>>> current_function.calling_convention.name
'stdcall'

Edit: I get the same result when compiling with VS2017 and even supplying Binary Ninja with the PDB.

Determining number of parameters is a difficult problem that we're never going to have a complete solution to. It is an issue that BN isn't trusting the PDB though.

Thank you for picking this up!
I'm curious: if ECX and EDX appear as src operands first inside a function, isn't it a clear case for register-based argument passing, that rules out stdcall (among others) entirely? As I mentioned previously, Binary Ninja seems to detect this (ECX, EDX holding function arguments) nicely, so it's strange that it still sticks with stdcall afterwards.

This is actually a duplicate of #1031, close it as such.


OnClick Function: Click on Label in xAxes: Data is empty Array

Hey,
I would like to use the onClick function to open a new window, depending on the clicked data.
I am using the _model var from the data array provided as a parameter. Unfortunally, the data array is empty, if you click the label instead the bar.
Expected Behavior
The onClick function should have a non-empty data array as a parameter.
Current Behavior
The onClick function have an empty data array as a parameter.
Possible Solution
Find the depending data and return this data in the onClick call
Steps to Reproduce (for bugs)

Open jsfiddle (https://jsfiddle.net/e81ks3gq/1/)
Open console
Click on a data (eg the blue one)
See in the console: Array (1)
Click on a label, eg: "Blue"
See in console: []

Context
I would like to use the onClick function to open a new window, depending on the clicked data.
I am using the _model var from the data array provided as a parameter. Unfortunally, the data array is empty, if you click the label instead the bar.
Environment

Chart.js version: 2.8.0
Browser name and version: Firefox 60.7.2esr, but browser independent

Hello ) not empty array will be after click on diagrams with this :
    onClick: function(e, data[label]) {     	console.log(data);      },         scales: {             yAxes: [{                 ticks: {                     beginAtZero: true                 }             }]         }     }

Hello ) not empty array will be after click on diagrams with this :
 onClick: function(e, data[label]) { console.log(data); }, scales: { yAxes: [{ ticks: { beginAtZero: true } }] } }

Thank you for your answer, but the syntax is wrong.

Okay, if you add a hover option, it is working as expected. see https://jsfiddle.net/s4cj37tx/


Add support for snooping IPv6 DHCP & DAD packets and fill app instanc…

…e info message with IPv6 addresses for vifs connected to switch network instances
Applications connected to switch network instances can get IPv6 addresses if the external network supports IPv6.
EVE does not snoop for DHCPv6 or SLAAC addresses. Current code in EVE does not report the IPv6 address that the applications may have. This PR addresses it by snooping for DHCPv6, DAD packets to find addresses used by applications and report them to zedcloud as part of application info messages.
Signed-off-by: Gopi krishna Kodali<EMAIL_ADDRESS>

If you want to have a designated single IPv4 address plus a list of IPv6 addresses it makes more sense to define a AllocatedIPv4Addr (rename of existing) plus a new AllocatedIPV6AddrList.

Makes sense. Will do this.

Created this new PR instead.


[WIP] update aws dependencies based on latest sky

Current dependencies on/for this PR:

main

PR #290   👈

This stack of pull requests is managed by Graphite.


Ajax call to the same Page in Framework7

Hi there,
Im currently developing a project using Framework7 and it is actually at the very first stage. I have implemented a [login-screen modal-in] view along with the main view in my index.html page (to handle the Login screen)
Everything works fine actually, the first screen that pops up is the login screen as expected, and as soon as I click on login it pops down and the index screen (main) shows up.
I've noticed a strange behavior which is, as soon as the index page is loaded, if I click on the home button (which is a link with href to the index.html page) it performs the ajax call to the index.html page even though it is actually the page that is currently being displayed.
I've been reading some articles here and could be something to do with the framework initialization, perhaps I've tried the proposed hints and could not overcome this issue.
Obs.: If I click on another link, which will refer to another page, then go back to index page I can click as many times as I want that the ajax won't reload it.
My index.html and app.js are attached.
index.html.txt
app.js.txt
Framework version is v1.5.3
Please let me know if you need more details.
Any help is more than appreciated.
BR,
Gui

It would be more useful if you would show a sketch of what you want to apply

Well,
I guess it's more like what I want to avoid. Need to understand why at the first time the index.html page is loaded, if I click on the option that will refer to itself, it recalls the same page while next times I click it won't.
Please check the code for further details.

I think this is because Framework7 is using the full URL of the page to identify it.
So when you first load your app the page it's on is http://path.to/page/index.html and when you click your link with href="index.html" the new page is just index.html with no path. Since the url (index.html) doesn't match the original page url (http://path.to/page/index.html) it makes a request to the page.
Quick test of this:
https://www.youtube.com/watch?v=ozgnowj--MA
So the easiest fix would be to just replace your index button with a full path link.

Thanks @jdf221 your solution works (not really charming) more like a workaround. This situation I think it's really linked with this thread https://github.com/nolimits4web/Framework7/issues/28#ref-commit-4c47ac5
I tried initiating the API manually perhaps I get the error that $$ is not a function.
Would this might have changed again in latest releases (regression bug) ?

Or set initial URL (url: 'index.html') parameter for the view when you initialize it


Bump black from 21.11b0 to 21.11b1

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@7060c98). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff            @@
##             main      #105   +/-   ##
========================================
  Coverage        ?   100.00%
========================================
  Files           ?         2
  Lines           ?        22
  Branches        ?         0
========================================
  Hits            ?        22
  Misses          ?         0
  Partials        ?         0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7060c98...d0a8c47. Read the comment docs.


test atlantis pr automation

Testing PR automation

Ran Plan for dir: . workspace: default
Show Output
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
+ create

Terraform will perform the following actions:

  # azurerm_resource_group.az_rg will be created
+ resource "azurerm_resource_group" "az_rg" {
      + id       = (known after apply)
      + location = "eastus"
      + name     = "test-rg-10"
    }

Plan: 1 to add, 0 to change, 0 to destroy.

Changes to Outputs:
+ az_rg_location = "eastus"
+ az_rg_name     = "test-rg-10"

:arrow_forward: To apply this plan, comment:

atlantis apply -d .

:put_litter_in_its_place: To delete this plan click here
:repeat: To plan this project again, comment:

atlantis plan -d .

Plan: 1 to add, 0 to change, 0 to destroy.

:fast_forward: To apply all unapplied plans from this pull request, comment:

atlantis apply

:put_litter_in_its_place: To delete all plans and locks for the PR, comment:

atlantis unlock

atlantis apply -d .

Ran Apply for dir: . workspace: default
azurerm_resource_group.az_rg: Creating...
azurerm_resource_group.az_rg: Creation complete after 1s [id=/subscriptions/6c902ca4-7573-4984-ae9f-2229e22fdd4f/resourceGroups/test-rg-10]

Apply complete! Resources: 1 added, 0 changed, 0 destroyed.

Outputs:

az_rg_location = "eastus"
az_rg_name = "test-rg-10"

Locks and plans deleted for the projects and workspaces modified in this pull request:

dir: . workspace: default


fix edit_distance_align() in distance.py

This pull request provides a quick fix to issue #2954, in which the alignment mapping of two strings based on the minimum edit distance is wrong.
The Levenshtein edit distance table, named lev inside edit_distance_align() was correct. The problem lied in the _edit_dist_backtrace() function. During back tracing, in previous version of _edit_dist_backtrace(), the first cell in (i - 1, j),  (i, j - 1), (i - 1, j - 1) (in this order) that has the minimum cost value was selected to be the next cell in the path. However, it did not consider that going through either cell in (i - 1, j),  (i, j - 1) should always incur an additional cost because they correspond to insertion or deletion. Going though (i - 1, j - 1), however, corresponds to a substitution, which can incur an additional cost of either 0 or a user defined substitution cost (default to 1 in edit_distance_align()). For example (see issue #2954 for an illustration of a similar example), suppose we are at cell (i, j) whose cost is n. Now, if the cost values for (i - 1, j),  (i, j - 1), (i - 1, j - 1) are all n, same as the cost value in cell (i, j), then (i - 1, j) would be added to the path, which is an illegal move because you can't go through an insertion or deletion without an additional cost. In this case, the only viable path is through cell (i - 1, j - 1), which is a substitution move of 0 cost. The easiest way to fix that is to change the order to (i - 1, j - 1), (i - 1, j),  (i, j - 1). The corresponding docstring inside edit_distance_align() has also been updated to reflect this change.

I've also updated a previously broken test case regarding this. Previously, it was:
>>> edit_distance_align("rain", "brainy")
    [(0, 0), (1, 1), (1, 2), (2, 3), (3, 4), (4, 5), (4, 6)]

However, (0, 0) into (1, 1) doesn't make much sense for "rain" and "brainy".
It is now:
>>> edit_distance_align("rain", "brainy")
    [(0, 0), (0, 1), (1, 2), (2, 3), (3, 4), (4, 5), (4, 6)]

I'm convinced this is correct... thank you @yzhaoinuw and @tomaarsen.

That looks sound @yzhaoinuw. Thank you for the simple fix and the analysis! Also thank you to @Miguelvs23 for the discussion in #2954.

@yzhaoinuw Hi, I think there are still some problmes in this impl by simply reordering the list.
Considering a simplest case with sub cost INF in the following table, the min edit cost should be 2, and the desired alignments should be [(0, 0), (0, 1), (1, 1)], but edit_distance_align gives [(0, 0), (1, 1)], which is incorrect I think.

#
b

#
0
1

a
1
2

>>> from nltk.metrics.distance import edit_distance, edit_distance_align
>>> edit_distance('a', 'b')
1
>>> edit_distance_align('a', 'b')
[(0, 0), (1, 1)]
>>> edit_distance('a', 'b', float('inf'))
2
>>> edit_distance_align('a', 'b', float('inf'))
[(0, 0), (1, 1)]

Maybe we need to maintain a path table to record the directions to facilitate the follow-up backtrace?

Hi @yzhangcs, good catch. I tracked down the cause of this bug to be in _edit_dist_backtrace(),
def _edit_dist_backtrace(lev):
    i, j = len(lev) - 1, len(lev[0]) - 1
    alignment = [(i, j)]

    while (i, j) != (0, 0):
        directions = [
            (i - 1, j - 1),  # substitution
            (i - 1, j),  # skip s1
            (i, j - 1),  # skip s2
        ]

        direction_costs = (
            (lev[i][j] if (i >= 0 and j >= 0) else float("inf"), (i, j))
            for i, j in directions
        )
        _, (i, j) = min(direction_costs, key=operator.itemgetter(0))

        alignment.append((i, j))
    return list(reversed(alignment))

The substitution cost being float(inf) means that the substitution is not allowed. Yet in the code above, when adding directions, paths via substitution are still added. In your example, at (1, 1), the directions_costs is (0, (0, 0)), (1, (0, 1)), (1, (1, 0)), in this order. When the direction with the minimum cost in the lev table gets picked out and appended to alignment, it is the direction via substitution that gets appended, which is incorrect when the substitution cost is float(inf). In fact, it would be incorrect for any substitution cost greater than 2, because substitution would then cost more than a deletion, costing 1, followed by an addition, costing another 1.
My proposed fix is to pass the substitution_cost from edit_distance_align() to _edit_dist_backtrace(). Then in _edit_dist_backtrace(), add a condition to check for substitution_cost. When it is greater than 2, do not add (i - 1, j - 1) to direction. I will do a follow-up pull request.


yararule.ScanFile, can not scan filepath which contains chinese, may be other language has the same

code below, use github.com/hillu/go-yara/v4 v4.3.2

Please have a look at the ScanFile documentation:
// Note that the filename is passed as-is to the YARA library and may
// not be processed in a sensible way. It is recommended to avoid this
// function and to obtain an os.File handle f using os.Open() and use
// ScanFileDescriptor(f.Fd()) instead.

The note is there exactly for string encoding reasons.

copy that, thank you


feat: @supaglue/sdk first release

Fixes: ####
[Describe your change here]
Test Plan
[Describe test plan here]
Deployment instructions
[Add any special deployment instructions here]

I'm thinking of changing @supaglue/schemas to simply @supaglue/sdk, it's not technically 100% correct naming given it contains a bunch of unrelated code but feels like the least friction overall and not much tech debt being introduced.

https://www.npmjs.com/package/@supaglue/sdk?activeTab=readme
Need to add docs, but already works!

Not much. We already do in at least one integration test. Should be a straightforward refactor.


Carthage support

Would be awesome if you guys add Carthage support 👍 !

Sure, I'll do that ASAP 👍

Hey, @PaoloCuscela !
Is there any news?

Any news/plans on this one? :)


REG: ISSUE WITH DATALODING (I WANT TO KNOW WHAT DATALODER TO USE)

Huge problem with knowing what is right Data Loder to use for the dataset for training for deep network
When attempting to use the dataset using AWS, I have huge problem of how to handle dataset.
1. What data loader module to use,?
2. Is there any prebuild Data loader which returns (RGB stimuli, FMRI voxels, image captions) in specified batches.?
Can you help me with this i am struggling for nearly 5 months.
Actual goal of my project:
I want to train transformer-based auto encoder - decoder for generating rgb features from brain data which seen the coco images.

I am not sure what a "Data Loader" is.  Is this an AWS specific thing?  Perhaps you can look at recent papers that used NSD data and see if those papers have some associated code that you might get some insights from.

I am not sure what a "Data Loader" is. Is this an AWS specific thing? Perhaps you can look at recent papers that used NSD data and see if those papers have some associated code that you might get some insights from.

A DataLoader in the context of Python programming, especially when working with deep learning models, is essentially a tool or class that helps you manage your dataset more efficiently.
In essence, a DataLoader simplifies the process of getting your dataset ready for training a deep learning model, making it easier to handle large datasets, work with batches, maintain data associations, and preprocess data.

I see.  NSD doesn't quite provide these types of loading routines for the end user, so you'll have to conjure up your own.  Alternatively, see the nsd_access (https://github.com/tknapen/nsd_access) mentioned on the first page of the NSD Data Manual


Git Private Repository Authentication

#downloadZipArchive:to: does not provide a hook for user and password

closing in favor of Issue #475


v0.4.0-rc1 - ros config export shows users section but it's not supported

When I do a ros config export, the file looks like:
ssh_authorized_keys:
write_files:
hostname:
users:
rancher:

Since RancherOS doesn't support users, we need to hide the users section.

We can't hide the users section, because we do support rancher and docker users, and this section can be used to configure them.

@imikushin What can be changed?  I don't believe we have any code to support users element in cloud-config right now.

@imikushin Oh yes, I forgot.  We only support the ssh_keys param of users.

@deniseschannon I would close this issue.  Do we have a general issue anywhere to support more fields?

@deniseschannon @ibuildthecloud I just did a quick test: in fact, we can remove users from our cloud-config, at least for now as we really get rancher and docker users' authorized keys from the top level ssh_authorized_keys cloud-config property.

@ibuildthecloud Yes, we have an issue to support users in another place. https://github.com/rancher/os/issues/263


Publish nightly builds of gauge and plugins

Nightly builds are being pushed to https://bintray.com/gauge/builds for these pacakges:

gauge
gauge-java
gauge-csharp
gauge-ruby
html-report
xml-report

The builds are run at 6PM IST on Monday to Friday.


Output aab option isn't present

I need to output aab file instead of apk as per Google current recommendations

What are the ionic parameters used to achieve this?

@janpio This is what I currently using
desc "Deploy android app on play store - Internal Lane"
 lane :internal do
   bump_version
   ionic(
     platform: 'android',
     build_number: ENV['CORDOVA_BUILD_NUMBER'],
     keystore_path: keystore_path,
     keystore_alias: keystore_alias,
     keystore_password: keystore_password
   )
   supply(
     apk: ENV['CORDOVA_ANDROID_RELEASE_BUILD_PATH'],
     track: 'internal',
   )
 end```

Yeah, I meant how the ionic CLI by Ionic can change their behavior to output aab instead of apk - because this plugin of course only uses that ionic CLI.

Could you advise how to accomplish that?

No, I do not know if it is possible and asking you if you know.

see https://github.com/fastlane-community/fastlane-plugin-ionic/pull/64


Feature/validate role options

Only accept CREATE ROLE flags that doesn't have any params (i.e.
not ADMIN or CONNECTION LIMIT). Check that both flag and NOflag
are not used at the same time.

Coverage decreased (-0.04%) to 8.863% when pulling 57da83ad170b4034a1df05bebca7f07cc0c249fd on feature/validate_role_options into 969a06f521d2cda53bfa9f840f0558e385c2215d on master.

👍

Coverage decreased (-0.03%) to 8.873% when pulling 2eec0e5b52ba4f3d73e1e481d44a8b7fbab01cad on feature/validate_role_options into 969a06f521d2cda53bfa9f840f0558e385c2215d on master.

👍


chore(Blog): update “2016-12-17-making-sense-of-the-scaas-new-flavor-wheel”

Automatically generated by Netlify CMS

👷 Deploy Preview for lucileetguillaume processing.
🔨 Explore the source changes: c464136a6b3ee29d10b97d7a1cd0a05cf87f5974
🔍 Inspect the deploy log: https://app.netlify.com/sites/lucileetguillaume/deploys/618e23be20e9d40007070d1e


conflicts with the debug module

When you're using this with debug, it always logs and you can't turn it off.

I think there's else going on there. How are you running your script?

@tomas The problem is that the debug module uses the DEBUG env var to control it.
For example, DEBUG=app:* node app.js will trigger logging from this module because it only checks if DEBUG exists.
I think an easy resolution for this is to use a different env var (NEEDLE_DEBUG?) or maybe use the debug module, which is really cool.

Ah, I see. You're not using the latest version, it's that simple. Needle does use the debug module now.
npm install<EMAIL_ADDRESS>

nice - this is a dependency of a dependency so ill get them to update
thanks!


the particular FPGA part number?

Thank you for your great work！
What kind of FPGA should I consider to run a simple example.
Xilinx Virtex-7 is too expensive.

@mk123qwe to run a simple example, you can choose whichever device you want, but in general, there are a large range of devices you could use

@ mk123qwe运行一个简单的示例，您可以选择所需的任何设备，但是通常，您可以使用很多设备

I am ready to use KC705. i dont know if it can running a  demo.

If I change the Xilinx Part number in the yml, it gives me KeyError: 'XilinxPart' Could you please tell me where can I find a list of valid parts?

Please have a look at the datasheets.  As an example:
https://www.xilinx.com/support/documentation/data_sheets/ds890-ultrascale-overview.pdf
See page 44 for a detailed explanation of the part numbers