Warning: funds at risk during migration

Issue description
Warning: funds at risk during migration
Wallet version
IOTA Light Wallet 2.5.7 -IRI 0.5.6

wallet version (version number, commit, or branch):

System specification
Windows 10
Mac/Win/Linux (+Version and or Distro if possible)
Is it a repeatable issue?
Y
Steps To reproduce the issue
Explain how the maintainer can reproduce the issue.

Expected behaviour
Describe what you expect to happen.
Issue during IOTA migration.docx
Actual behaviour
Describe what actually happens.
Errors
Paste any errors that you see from the Error Log in the Firefly menu or share screenshots of the issue.

Hey. Please continue the migration.
Firefly will start a procces that will limit the risk of mirating the funds at spent addresses.
The problem is that funds on spent addresses had already a part of the private key of that address reveald due to the nature of the WOTS one time signature sheme.
Firefly will start a proccess called bundle mining and search for the best way to reveal as less possible of your key during the migration (which would be an attack vector).
This proccess will be a high cryptographic task and take 10 minutes per spent address per bundle mining proccess. You rcpus will run on 100% during this time. Afterwards wou will presented with a risk estimation (how good the proccess hides the keys now)
It is possible that you need to run this mining proccess several time untill you reach at least medium risk level and then you can procceed the normal migration.
So plan some time - depends on the ammount of spent addresses and how complicated the case is this could take several hours.
But Firefly will do the best poosible solution to move those funds

Closing as this is not a bug

ClientError: error sending request for url (https://chrysalis-nodes.iota.cafe/api/v1/addresses/iota1qq0tkn6t4u0kvw9urddt8ap6pjyfcynnncslry5w49em745alplmg8qgavj/outputs?include-spent=true): operation timed out


Request for help: Self hosting in Vultr

Hi there
I'd like to try out self hosting this on Vultr for my projects, does anyone have a step by step process that could help please.
Thanks in advance.

Best to wait for the next release, then we can work together on it. Also, jump on Discord, it's much more active.


UPDATE : Development to Master

This is a work in progress, trying to keep changes transparent before the next merge.
Thanks everyone contributing! This project may not be actively maintained anymore but at least we have some community support to keep it alive 👍
X.X.X (XXXX xxth 201X)
Fixed Issues

Fixed issue on graphs page (Thanks @tperalta82 !)
Show error message when trying to send mail to users (Thanks @mecab !)
Removed some name validation on contact forms (Thanks @mecab !)
Calculate the efficiency correctly in API (Thanks @smiba !)
Expend CSRF token expiry (Thanks @smiba !)
Improve est. diff for constantly changing coins (Thanks @smiba !)
Fixed mobile display issue of wallet status (Thanks @TopoX84 )
Fixed mobile display issue of peer info (Thanks @TopoX84 )

Features

MySQL Master/Slave switching based on SQL queries (Thanks @tperalta82 !)
Added a switch to ignore cron errors (Thanks @mecab !) - USE AT YOUR OWN RISK
Adjusted block overview percentage colors to be less "dangerous" ;-) (Thanks @smiba !)
Added 'start' parameter to ´getusertransactions´ api page (Thanks @desaerun !)
Replaced recaptcha-v1 with recaptcha-v2 (Thanks @AmazingDreams !)

I'd like to say that Recaptcha v1 will stop working March 31st: https://developers.google.com/recaptcha/docs/faq#what-happens-to-recaptcha-v1

Any calls to the v1 API will not work after March 31, 2018.

So perhaps it would be a good idea to make a hotfix for the recaptcha thing - if there is no entire release possible.

If in a hassle people can always just switch to the development branch in the time being. As this is officially unsupported, no expectations should be made by users to the project to fix things "on-time".
Bit I think we can do it before the 31st, even though some things may have to wait for a later date.


HTTPError exceptions return a JSON Problem instead of HTML.

Description

The backend should remain an API, and as such, return errors as JSON, and not HTML.
This change removes HTML file responses for HTTP errors, and uses JSON Problem detail responses instead.
Related issues

Type of change

[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Changes Made

Refactor HTTPError responses to return a JSON Problem detail object.
Update JSON Problem detail to include HTTP status code
Update OpenApi Swagger docs

Testing

[x] Tests do not apply

Mentions

@teemukataja, I think logging is better now, what do you think?

There is a need to address how Metax errors would be recognized from submitter errors as this PR is marked to solve #382. We will discuss that with @csc-felipe

There is a need to address how Metax errors would be recognized from Submitter errors as this PR is marked to solve #382. We will discuss that with @csc-felipe

Makes. But I don't really understand what does it mean. Let's merge this PR, if it's desired, or close it if not, and then the other change comes in a new PR.

The JSON errors do not cause any breaking changes in frontend except in some cases I think it's better if the backend can still redirect to html page instead of a JSON format. For example, when the user makes a page request and receives 400 or 401.

@hannyle, Because we are offering the API as a service to customers, it's more natural to give a JSON response than a redirect. Would it be ok if the frontend then redirects to the error page in the front end?

The JSON errors do not cause any breaking changes in frontend except in some cases I think it's better if the backend can still redirect to html page instead of a JSON format. For example, when the user makes a page request and receives 400 or 401.

@hannyle, Because we are offering the API as a service to customers, it's more natural to give a JSON response than a redirect. Would it be ok if the frontend then redirects to the error page in the front end?

In the old way, I think the backend also returned JSON error for API requests and the frontend is already configured that it would intercept and transform the error to either a redirection or something else.
The issue I mentioned is not with API requests but for cases that user types a wrong URL that would return 400 or 401, and with that the frontend currently cannot intercept in the same way as API requests. With the old backend, it would return html page instead, but if this function is removed I would need to figure out another way to configure it frontend, I don't know how yet it may take sometime.

The issue I mentioned is not with API requests but for cases that user types a wrong URL that would return 400 or 401

Now I get it. I'm working on another change #421, so that it will always return the frontend HTML in that case, instead of an error (as part of fixing that PR). So you can do what you want with the wrong URL.
I'll merge this PR.

Now I get it. I'm working on another change https://github.com/CSCfi/metadata-submitter/pull/421, so that it will always return the frontend HTML in that case, instead of an error (as part of fixing that PR). So you can do what you want with the wrong URL.

I'll merge this PR.

That sounds good to me! Please go ahead :)

The fix actually went to PR #476.


Sync with Seldon Core community

What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

/assign @gaocegege


Feature: DECODE_NODE hints

Issue Number: N/A
Type

[x] feature
[ ] bugfix
[ ] dev (no functional changes, no API changes)
[ ] fmt (formatting, renaming)
[ ] build
[ ] docs
[ ] testing

Description
Breaking changes?

[ ] yes
[x] no

Depends on #87.


drivers: sensor: lm73c: Added TI LM73C sensor driver

Added LM73C sensor driver and sample code. Built and
tested on frdm_kw41Z and nrf52840 dongle. Ran twister.
On branch sensor_lm73c
Changes to be committed:
modified:   drivers/sensor/CMakeLists.txt
modified:   drivers/sensor/Kconfig
new file:   drivers/sensor/lm73c/CMakeLists.txt
new file:   drivers/sensor/lm73c/Kconfig
new file:   drivers/sensor/lm73c/doc/LM73CIMK-0.lbr
new file:   drivers/sensor/lm73c/doc/lm73.pdf
new file:   drivers/sensor/lm73c/lm73c.c
new file:   drivers/sensor/lm73c/lm73c.h
new file:   samples/sensor/lm73c/CMakeLists.txt
new file:   samples/sensor/lm73c/README.rst
new file:   samples/sensor/lm73c/boards/frdm_kw41z.overlay
new file:   samples/sensor/lm73c/boards/nrf52840dk_nrf52840.overlay
new file:   samples/sensor/lm73c/boards/nrf52840dongle_nrf52840.overlay
new file:   samples/sensor/lm73c/prj.conf
new file:   samples/sensor/lm73c/sample.yaml
new file:   samples/sensor/lm73c/src/main.c
Signed-off-by: Steven Riedl<EMAIL_ADDRESS>

Mistakenly created a new branch that has all of these fixes and more, and wound up creating a pull request there, so I ma closing this one.

Mistakenly created a new branch that has all of these fixes and more, and wound up creating a pull request there, so I ma closing this one.


db_session as argument of all methods its stupid

better use global db session contextvar, code will be cleaner

Hello, @h0rn3t thanks for your sincere feedback 👍. Maybe you agree with me that it does not exist a perfect code and there is always an opportunity to improve it ✌🙂. The current setup is sharing a database engine and creating an independent database session in each handler (starting session and closing session after the request is handled) as is described in the official FastAPI docs here. I agree with you that if we follow the KISS and DRY principles this code can more simple. I do not think that it is a good idea that handles to share the same session instead create a pool of sessions that can be used and released for each handle as described here.
This recommendation will be added to the TODO list.
Reference links
https://fastapi.tiangolo.com/advanced/async-sql-databases/#connect-and-disconnect
https://github.com/tiangolo/fastapi/issues/2894
https://github.com/tiangolo/fastapi/issues/726

import math
from typing import Any, Generic, Optional

from fastapi_async_sqlalchemy import db
from sqlalchemy.future import select
from sqlalchemy.sql import Select, func

from app.schemas.paginator import Page
from app.utils.types import ModelType

class CRUDBase(Generic[ModelType]):
    def __init__(self, model: type[ModelType]):
        self.model = model

    async def get(self, id: Any) -> Optional[ModelType]:
        statement = select(self.model).where(self.model.id == id)
        result = await db.session.execute(statement)
        return result.scalar_one_or_none()

    async def paginate(self, *, statement: Select, page: int = 1, size: int = 25) -> Page[ModelType]:
        total_result = await db.session.execute(select(func.count()).select_from(statement))
        total = total_result.scalar()

        pages = math.ceil(total / size)
        if page > pages:
            data = []
        else:
            search_result = await db.session.execute(statement.limit(size).offset((page - 1) * size))
            data = search_result.scalars().all()

        return Page(
            total=total,
            current_page=page,
            next_page=page + 1 if page < pages else None,
            previous_page=page - 1 if page > 1 else None,
            size=size,
            data=data,
        )

example how look code without dependency injection :)

btw sorry for my word "stupid", its cool that you want to improve your code

Hello, @h0rn3t thanks for the code. I think this improvement will be beneficial. I am going to improve it as soon as possible 🙂

Thanks for this recommendation @h0rn3t. Dependency injection has been removed in this commit https://github.com/jonra1993/fastapi-alembic-sqlmodel-async/commit/76965146baee85642b220e1d348e3e1ba3269f1f

@h0rn3t do you have an example of how you set the global db session context var?


Additional testcase for Edit-task person field

Codecov Report

Merging #136 (d61b557) into master (b9af92e) will increase coverage by 0.06%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #136      +/-   ##
============================================
+ Coverage     71.25%   71.32%   +0.06%
- Complexity      900      901       +1
============================================
  Files           142      142
  Lines          2936     2936
  Branches        344      344
============================================
+ Hits           2092     2094       +2
+ Misses          739      738       -1
+ Partials        105      104       -1

Impacted Files
Coverage Δ

.../seedu/address/logic/commands/EditTaskCommand.java
95.55% <ø> (+4.44%)
:arrow_up:

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more


isAlpha() failing on AlphaNumerics

Not sure if isAlpha should be failing when numerics are included
IE: req.checkBody('key', 'invalid message').isAlpha() //passes when 'key' refers to 'asdasd'
req.checkBody('key', 'invalid message').isAlpha() //fails when 'key' refers to 'asdasd2'
--- couldn't find a separate isAlphaNum, or isAlphaNumeric. Is there a separate checkBody test I should be using to determine whether something is a combination of characters and numbers?
Thank you in advance!

You were almost there, the correct name is isAlphanumeric.
For reference, look at validator.js's methods.
All validators express-validator provides come from this module.

Thank you!


why the Breakout-v0's action_size is 4 ,but in the checkpoint is 6

when i run it ,get this wrong,is it the version of gym ?
tensorflow.python.framework.errors_impl.InvalidArgumentError: Restoring from checkpoint failed. This is most likely due to a mismatch between the current graph and the graph from the checkpoint. Please ensure that you have not altered the graph expected based on the checkpoint. Original error:
Assign requires shapes of both tensors to match. lhs shape= [4] rhs shape= [6]
[[node save/Assign_9 (defined at \Users\tang\Desktop\DQN-tensorflow-master\dqn\agent.py:328) ]]

same problem


Etag related tests failing

When I locally execute tests using mvn clean test against a LearningLocker LRS three of them fail:

RemoteLRSTest.testOverwriteAgentProfile
RemoteLRSTest.testOverwriteState
RemoteLRSTest.testOverwriteActivityProfile

After analysing them, they all have the following behaviour in common:

They assign the Etag of another entity to a new object (a previous object is reused, but its ID and some other fields are changed)
They try to create this object (using saveAgentProfile, saveState or saveActivityProfile methods).
The test fails because the server answers HTTP 412 error with the content "Precondition (If-Match) failed."

The tests talk about overwriting/updating an object, but since the ID changes I don't think the LRS is considering that it is the same entity anymore. Therefore the Etag is not valid for that entity and IMHO it is correct that these tests fail.

I have rewritten these test to reuse the same ID and the only one which still fails is:

RemoteLRSTest.testOverwriteState

So apparently, what makes an entity for Learning Locker is not only the ID but also the activity associated to that object.
In fact, after reusing the same activity this test also passes successfully.

@gomezgoiri there appears to be a bug in the latest version of learning locker (1.11.0) around the Agent Profile API. See https://github.com/garemoko/moodle-mod_tincanlaunch/issues/80#issuecomment-160328018
It may be worth running these tests against another LRS e.g. SCORM Cloud to confirm the problem.

Thanks for the clue.
Yes, all the tests pass if I use SCORM Cloud.

I'm gathering this is resolved, re-open if necessary.


osd: generate device list for osd_auto_discovery on rolling_update

rolling_update relies on the list of devices when performing the restart
of the OSDs. The task that is builind the devices list out of the
ansible_devices dict only runs when there are no partitions on the
drives. However during an upgrade the OSD are already configured, they
have been prepared and have partitions so this task won't run and thus
the devices list will be empty, skipping the restart during
rolling_update. We now run the same task under different requirements
when rolling_update is true and build a list when:

osd_auto_discovery is true
rolling_update is true
ansible_devices exists
no dm/lv are part of the discovery
the device is not removable
the device has more than 1 sector

Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1613626
Signed-off-by: Sébastien Han<EMAIL_ADDRESS>

Failing LVM scenarios will be fixed by https://github.com/ceph/ceph-ansible/pull/2997#pullrequestreview-144904653


Can not find the FlexSlider.ss template

Affected Version
framework  version: 4.31.1
dynamic/flexslider "version": "4.0.0"
Description
The FlexSlider template is not pulling from the Includes folder.
Error got on frontend:
None of the following templates could be found: Array ( [0] => Array ( [type] => Includes [0] => FlexSlider ) [1] => FlexSlider
Steps to Reproduce
One of my another site is using 4.0.0-beta3 which do not have this issue.
In version 4.0.0:
The folder structure under the "templates" folder is different from 4.0.0-beta3.
If take the Includes folder directly under the templates folder, it will working.
Please have a look. Thanks

This is likely the same as #183

I think #183 would solve this issue, but moving the Includes folder up to live right under Templates would also work. Will do some testing and get it fixed.


Documentation Typo

Should the sphere rgba highlighted below not be 0 0 1 1?

Yes, indeed. Thanks!
Fixed internally.
Apologies that we cannot yet push out fixes between releases.
This will be remedied soon, once we open source.


Logs and Utils

Common Utility packages

[ ] time taken by a function to execute

check the CPU or GPU execution vs Thread running time from Clock. Both gives different total execution time if there is a pause in thread.
No need to research deep, when we encounter any async operation then the difference in Processing time vs Clock time will be essential.

[ ] custom logging

logging will be an abstract class used to have different location option to log.

git fetch origin
git checkout feat/logs-utils
@RahulGhosh02


standardize OS_TICKS_PER_SEC definition

In several instances OS_TICKS_PER_SEC was configurable via syscfg.
This PR proposes to have same behavior across all MCUs.
Now only one definition in os_time.h exists and it gets it form syscfg.
All MCUs have definition moved to syscfg.
In few cases other syscfg values that referred to OS_TICKS_PER_SEC
are using MYNEWT_VAL(OS_TICKS_PER_SEC) to avoid circular
dependency problem.
This requires newt with https://github.com/apache/mynewt-newt/pull/423 included.

I can't compile with this version of mynewt-core:
$ newt build klok-pinetime
Building target targets/klok-pinetime
Error: Priority violations detected (Packages can only override settings defined by packages of lower priority):
    Package: @apache-mynewt-core/hw/mcu/nordic/nrf52xxx overriding setting: OS_TICKS_PER_SEC defined by @apache-mynewt-core/kernel/os

Setting history (newest -> oldest):
    OS_TICKS_PER_SEC: [@apache-mynewt-core/hw/mcu/nordic/nrf52xxx:128, @apache-mynewt-core/kernel/os:]

@caspermeijn you need to use latest newt (master) to build

@caspermeijn I can answer some of the questions you posed.

Why would someone want to change this value?
Some may want to change this value so that the time resolution for the os tick to be greater or less than the default value set. Some folks may want a 1 msec OS tick resolution whereas some may want longer. If you use 128 ticks per second the rate is, I believe 7.8125 msecs per tick.
Why do all mcu define their own value?
The main reason for this, I believe, is the default timer used for generating the os tick. We wanted to be able to generate the tick period exactly. Consider a 1 MHz timer and a 32768 Hz timer. For the 32768 timer, generating a 10msec os tick is not easy given integer number of ticks. That is why 128 is chosen for those MCUs as the 7.8125msec period is an integer number of ticks for a 32768 timer. For 1MHz, a 10msec resolution was chosen since that is an integer number of ticks for that timer.
Would it make sense to standardize the actual value?
I think, given the reason all mcus define their own values, no. There are really only two values I think used that are "standard": 128 and 100. So this seems ok to me.

@andrzej-kaczmarek Thanks, with latest newt it builds.
@wes3 So basically both question are for to get more accurate time handling. Got it.
@kasjer hw/util/button build correctly for me with these changes.

re-base was required over already approved version due to conflicts in pic32 code

re-base was required over already approved version due to conflicts in pic32 code


Error 4058: Can't even run the Getting started example

Which package is this bug report for? If unsure which one to select, leave blank
@crawlee/playwright (PlaywrightCrawler)
Issue description
When I run the "Getting started" crawler ("npm start"), I get this obscure error message related to a tool that is deprecated (WMIC) :

<EMAIL_ADDRESS>start
npm run start:dev

ERROR Memory snapshot failed.
spawn wmic.exe ENOENT
at ChildProcess._handle.onexit (node:internal/child_process:286:19)
at onErrorNT (node:internal/child_process:484:16)
at process.processTicksAndRejections (node:internal/process/task_queues:82:21)
INFO  PlaywrightCrawler: Starting the crawler.
node:internal/child_process:286
const err = new ErrnoException(exitCode, syscall);
^
Error: spawn wmic.exe ENOENT
at ChildProcess._handle.onexit (node:internal/child_process:286:19)
at onErrorNT (node:internal/child_process:484:16)
at process.processTicksAndRejections (node:internal/process/task_queues:82:21) {
errno: -4058,
code: 'ENOENT',
syscall: 'spawn wmic.exe',
path: 'wmic.exe',
spawnargs: [ 'PROCESS', 'GET', 'ProcessId,ParentProcessId,WorkingSetSize,Name' ]
}
Node.js v20.18.0
Code sample
// For more information, see https://crawlee.dev/
import { PlaywrightCrawler } from 'crawlee';

// PlaywrightCrawler crawls the web using a headless
// browser controlled by the Playwright library.
const crawler = new PlaywrightCrawler({
    // Use the requestHandler to process each of the crawled pages.
    async requestHandler({ request, page, enqueueLinks, log, pushData }) {
        const title = await page.title();
        log.info(`Title of ${request.loadedUrl} is '${title}'`);

        // Save results as JSON to ./storage/datasets/default
        await pushData({ title, url: request.loadedUrl });

        // Extract links from the current page
        // and add them to the crawling queue.
        await enqueueLinks();
    },
    // Comment this option to scrape the full website.
    maxRequestsPerCrawl: 20,
    // Uncomment this option to see the browser window.
    // headless: false,
});

// Add first URL to the queue and start the crawl.
await crawler.run(['https://crawlee.dev']);

Package version
<EMAIL_ADDRESS>Node.js version
v20.18.0
Operating system
Windows 11
Apify platform

[ ] Tick me if you encountered this issue on the Apify platform

I have tested this on the next release
No response
Other context
No response

Hello @nicolatournay and thank you for your interest in Crawlee! I tried the following steps on windows 11:
scoop install<EMAIL_ADDRESS>npx crawlee create my-crawler
cd my-crawler
npx playwright install
npm start

This worked as expected, without any error. I selected the getting started - typescript template. Then I rechecked with the javascript template and everything worked fine as well.
Is there any other step that I'm missing?

Hi Jan,
Now that I have added the path to wmic.exe (in my case, C:\Windows\System32\wbem) to my environment variables, it's working as expected.
You might want to include WMIC in the list of prerequisites in the "Setting up" section of your documentation, since it is deprecated for most Windows 11 users.
Anyway, thank you for your quick reply. I’m already enjoying the rest of the tutorial!


Add optional parameter to specify the schemeProvider.

In Azure Functions setting a default provider breaks the other providers but is a requirement for the tenant strategy to locate the correct schemeProvider.
Apply the handler Principal back to the httpContext so that other services can access the resolved Claims.
If the user is already authenticated bypass (will throw an exception if called twice).

@Valks
Thanks for being patient with me and for your contribution. This library has recently been accepted into the .NET Foundation and as a part of that process all contributors have to go through a CLA workflow. It works automatically on new PR requests -- but I'm not sure about you draft PRs. Would you mind if we take this one out of draft status to see if the CLA bot workflow kicks in?

Doesn't look like it triggered.
I can re-submit the PR's tomorrow if need be.

@Valks
I think if you can just resubmit one of them we’d be good. It’s a per contributor thing not per PR so one will be good enough.

Looks like closing and opening the pull request did the trick.
That said, I've already signed the CLA when contributing to the https://github.com/dotnet/aspnetcore in the past.
If you'd like me to do the same with the other PR's so they show the CLA signed just leave a comment.

Perfect, thanks for jumping through the hoops

@Valks didn't mean for StaleBot to flag this -- still planning to incorporate it, thanks

In reviewing this a few thoughts:

Can you point me to some Azure Functions resources that explain the problem this is solving? I'm not too familiar with them yet.

I think checking if there is already an authenticated user is ok, but I'm not aware of any use cases -- usually UseMultiTenant appears before UseAuthentication in an app pipeline -- am I missing something? Also in what situations do you find yourself having

I'm generally wary of setting the User principal during the strategy code because principal validation is usually bypassed in this part of the code (cookie tenant is validated against the request tenant, which at this point would always fail because we are in the middle of determining the tenant. This validation is useful for the other tenant strategies to make sure they match the logged in user during the "real" authentication). Since I skip the validation, which may include extra validation for the app, I like the idea of the regular UseAuthentication still running later to set the User and do the validation there.
Also, since the scheme handler has already been created it is reused later during the "real" authentication and there is little overhead because the cookie contents were cached from the strategy reading it.

So it has been quite a while since I looked at this code.
In my application where I'm using this code, I don't actually call UseMultiTenant or UseAuthentication. I don't remember if it's because there was a problem (I suspect that the difference in the HTTP pipeline meant it didn't work) or an oversight. It would be worth checking to see if that fixes the main issue where the User principal wasn't been populated when trying to evaluate the tenant (which lead to this code-change).
That said, there may still be an issue because Azure Functions registers some Auth providers (internally) and when you try to add more it removes those providers. I had to re-add them using Reflection so that Azure could still talk to the service.
As for setting the User principal, I'm pretty sure I took inspiration from code in the Microsoft Web Identity repository (https://github.com/AzureAD/microsoft-identity-web) which used the same technique. Unfortunately, I don't have notes on where I found the code.
Looking into this made me realise that I didn't add the code to register the default providers back into the Azure Functions pull request.
I'll try and find a moment later this week to look at these pull requests and see if UseMultiTenant is required and look at adding the code to enable re-registration of the default providers.

Ah, wish I looked at the main PR first
You don't need to call UseMultiTenant(), it's already done as part of the binding startup.

Still, I'll take a look.

Thanks. I think I get what you are saying -- the baked in authentication may get executed before UseMultiTenant in the binding startup -- you don't get much control there. In that case user is already set so all good there. If UseMultiTenant executes first I'm still where of setting User when validation for it was bypassed. I am continuing to read up on Azure Functions.
Thanks again.

Hi again and thanks again for this PR.
I'd love to include this soon. I noticed that it has some conflicts to be resolved. Do you still have interest in submitting this? My only request is that you remove the block starting at line 61 -- I explicitly do not want a strategy to act as authentication and set the User especially since it bypasses validation to prevent a chicken/egg problem when validation requires the tenant to be known.

I've removed the code and ran the tests which say they all pass (locally).
I had to add that code because the Principal wasn't been populated when I needed it. That said, for all I remember it could have been to do with the default authentication scheme issue which this pull requests addresses in which case it may no longer be a concern.


Build a dedicated interface for visual regression tests

Closes #21

@andrei-picus-hs @flavius-tirnacop-hs
Can you review?

@flavius-tirnacop-hs Review?

@andrei-picus-hs please also take a look on this

Finished review (didn't quite check the css though).

TestingTheTester.zip
Here is an archive with a test file and baselines. You should get 2 failed test and 2 passed tests.
Decompress the archive in the root directory and run mocha test.js -R index.js.
If you have any other ideas how I could test the package while I am working on it, please let me know.

If you have any other ideas how I could test the package while I am working on it, please let me know

You should write some simple acceptance (end to end) tests on the reporter. Start up the runner, let it generate the HTML report and then make some assertions on it. You could use WebdriverIO to open the report and check simple things. The purpose is to make sure that everything clicks in place.
You can create a separate issue for that though.

Finished review.


ES5 support is broken with the addition of const in 2.29.2

Version 2.29.2 of Moment,JS introduced a few const keywords in locale.js which has broken ES5 support for older browsers (e.g. IE11).
Would it be possible to revert these "const" to "var" to retain ES5 support?

Hi @jamesf91, I already opened a PR for this issue: #5995

Fixed in 2.29.3


fix: UI mobile breaks

🛠 Fixes Issue
Closes #251

👨💻 Changes proposed

Fix mobile UI breaking for gradient-text page

✔ Check List (Check all the applicable boxes)

[x] My code follows the code style of this project.
[x] This PR does not contain plagiarized content.
[x] The title of my pull request is a short description of the requested changes.

📄 Note to reviewers

📷 Screenshots

I think it will be better for it to be in a row, instead of trying to squeeze the preview bar

still in a row
just adjust the width of the inputs and color preview. just make it fit for mobile. I believe that is not to much to ask.

still in a row
just adjust the width of the inputs and color preview. just make it fit for mobile. I believe that is not to much to ask.

sorry i meant column, my bad

Changing the flex direction will make the color preview stack on each other. but could resize the preview bar. what causes it to break is that the input takes up default format without styling

Yes, I know that, that's the point. The preview doesn't have to be as long as the colour, but it fixed the squeezing that doesn't really look good

the preview is 100px on desktop and 70px on small screen is not to back can I make it 70px and request for new PR

Still want it to be in a column, i 100% still feel like it's much better

if I get you right the color input will stack on each other?
e.g
color 1 input
preview
color 2 input
Is that it?

if I get you right the color input will stack on each other?
e.g
color 1 input
preview
color 2 input
Is that it?

Yes exactly, but the preview should be centered in between the color inputs

Alright

Alright

Thank you

Done. It look amazing just like you said.

Done. It look amazing just like you said.

Can you reduce the height a little, i don't want it to be as noticeable as the Color input. So it should be not as thick in height as the color input

Okay

Done ✅

:tada: This PR is included in version 2.8.2 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


The useTina hook does not receive live data for reference fields

Description
Currently if you create a page that has a field of type: "reference", any changes to the value selected in that field are not reflected in the data returned by the useTina hook. Put another way, live editing is completely broken for reference fields.
Update
I have discovered that this is fixed by reverting to<EMAIL_ADDRESS>so the issue described here only started to appear on v0.66.10 of TinaCMS (and it persists on the latest version 0.67.0). I've added other related issues with the latest version of the tinacms package here: #2817. Thanks for all your wonderful work team!
Steps to reproduce

Create a repository with a schema along the lines of the example below
Inside of your pages/index.tsx or any other Tina-powered page, add a console.log statement to log the data returned by the useTina hook
Open your page in edit mode and make changes to the 3 fields in the sidebar

Note which fields trigger the console.log command. You will see the string and dropdown fields trigger that fine, but changes in the value of the reference field do NOT trigger the console.log statement
Also, if you make a change to the reference field then change one of the other fields (to trigger the console.log), the data that gets output on the console will contain the original value for the reference field, not the updated value.

Expected result
I would expect a change in the value selected in the reference field to trigger a change in the live data returned by the useTina hook, in order to update the visual elements associated with that change. For example, if I change the author of a page, the author bio display should update to show the information of the newly-selected author (i.e. to deliver the live editing experience).
Actual result
At the moment the useTina hook does not return the latest data for reference fields, and it does not trigger updates when a change occurs in a reference field. This process does work as expected for dropdown fields.
Example schema below
import { defineSchema, defineConfig } from "tinacms";

export default defineSchema({
  collections: [
    {
      label: "Pages",
      name: "pages",
      path: "content/pages",
      fields: [
        {
          type: "string",
          name: "title",
          label: "Title",
        },
        {
          type: "reference",
          name: "backgroundColourReference",
          label: "Background colour reference field",
          collections: ["colours"],
        },
        {
          type: "string",
          name: "backgroundColourDropdown",
          label: "Background colour dropdown field",
          options: ["colour 1", "colour 2", "colour 3"],
        },
      ],
    },
    {
      label: "Colours",
      name: "colours",
      path: "content/colours",
      format: "json",
      fields: [
        {
          type: "string",
          name: "rgbColour",
          label: "Colour",
          ui: {
            component: "color",
            colorFormat: "rgb",
          },
        },
      ],
    },
  ],
});

const apiURL =
  process.env.NODE_ENV == "development"
    ? "http://localhost:4001/graphql"
    : `https://content.tinajs.io/content/${process.env.NEXT_PUBLIC_TINA_CLIENT_ID}/github/${process.env.NEXT_PUBLIC_EDIT_BRANCH}`;

export const tinaConfig = defineConfig({
  apiURL,
});

Tinacms Package Versions
├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>

Update: I have discovered that this is fixed by reverting to<EMAIL_ADDRESS>so the issue described here only started to appear on v0.66.10 of TinaCMS (and it persists on the latest version 0.67.0). I've added other related issues with the latest version of the tinacms package here: #2817. Thanks for all your wonderful work team!

Thanks for reporting this! I've just reproduced it on the Tina Cloud Starter (by upgrading to "tinacms": "^0.67.0")

Hey @jamespohalloran - hope you had a top Easter break and thanks for the quick response on this one!
I'm using<EMAIL_ADDRESS>and seeing that issue if I try to upgrade to<EMAIL_ADDRESS>Dropping the version of tinacms to 0.66.9 fixes the problem while still using<EMAIL_ADDRESS>I could experiment with different versions of @tinacms/cli if useful but at this stage it seems something changed between<EMAIL_ADDRESS>and<EMAIL_ADDRESS>that causes this problem (as well as the other issues listed in #2817)
Massive thanks for looking into it, and apologies I'm not more across the internals of the package to try isolating the root cause in more detail!

Hey @coreyaus 👋
I was trying to reproduce this myself but haven't been able to, I've pushed up my code to this repo https://github.com/jeffsee55/reference-issue-debug if you can take a look and point me in the right direction to reproduce.
Thanks!

Thanks mate - I'm heading out of the office shortly but will take a look at this in the next week or two - hopefully it will already be resolved with the latest releases of tinacms but I'll keep you posted 👍 Thanks for your work on it so far!

Hey team,
I'm closing this issue as I've worked out what was happening, and it might not be a bug so sorry for the hassle! It's definitely a bit of a rough edge so I'll post my notes below in case they're useful:

The case where reference fields do NOT live-update via the useTina hook:

This happens if the GraphQL query simply uses the PostParts fragment (or equivalent [collection_name]Parts fragment) to access all the necessary data, without defining any inlineFragment on the particular reference field (e.g. no ... on Author fragment or whatever the reference field is called).

In this case the data from useTina still returns the id value for the reference field - that was all I needed in my case, so I hadn't realised you need to explicitly include an extra inlineFragment in your query in order to get the live-updating behaviour for reference fields
If this is expected behaviour it might be helpful to document it somewhere - I found it a bit surprising and fairly hard to diagnose

As an example of this, you can see the live-updating does not work for the post author in the Tina tailwind starter repo after making this change: https://github.com/coreyaus/tinacms-issue-2816/commit/cd99486b792145e7decebc279a1f508f5a37d414

Fixing the issue is as simple as including an inline fragment for the reference collection

Using the Tina tailwind starter repo as the example, the live updating works with the following GraphQL (which is admittedly this version included by default):query BlogPostQuery($relativePath: String!) {
  ...LayoutQueryFragment
  post(relativePath: $relativePath) {
    ...PostParts
    author {
      ... on Author {
        name
        avatar
      }
    }
  }
}

However with the following GraphQL, the live updating does NOT occur when making changes in a post's author field:query BlogPostQuery($relativePath: String!) {
  ...LayoutQueryFragment
  post(relativePath: $relativePath) {
    ...PostParts
  }
}

For my specific use case I didn't need anything more than the id of my reference field, which is why I saw this issue originally as my query didn't include any inline fragments on the reference field I was using (the id field is included by default without adding an extra inlineFragment to the query, and that gave me everything I needed).

One note is that I haven't confirmed the behaviour if your reference field includes multiple collections, e.g. using something like collections: ["author", "page"], in the schema.ts

In that case I'm not sure whether you'd need to update your query to include an inline fragment on each collection mentioned in that collections array

Let me know if you have any questions about that, or if the underlying behaviour is worth reviewing/discussing in more detail at any point 👍

Thanks for the detailed info, @coreyaus - this is due to the fact that that we don't update nodes unless the user has queried for actual fields on the given document. So for our experimental client we do references like this:
query BlogPostQuery($relativePath: String!) {
  ...LayoutQueryFragment
  post(relativePath: $relativePath) {
    title
    author {
      ...on Document {
        id
      }
    }
  }
}

But if you specify fields of any kind:
query BlogPostQuery($relativePath: String!) {
  ...LayoutQueryFragment
  post(relativePath: $relativePath) {
    title
    author {
      ...on Document {
        id
      }
      ...on Author {
        name
      }
    }
  }
}

Those should be picked up. We should fix that so all values are populated.


[v2] (undefined) ReferenceError: command is not defined at MDXContent

🐛 Bug Report
It can not be built in Server stage.
$ node -v
v13.7.0

$ npm -v
6.13.6

Have you read the Contributing Guidelines on issues?
yes
To Reproduce

Run the command npx @docusaurus/init@next init my-website classic.
Modify the config and add the markdown files.
Run the build command npm build

Expected behavior
It should be built successfully.
Actual Behavior
$ npm run build

><EMAIL_ADDRESS>build /Users/focaaby/Project/NCNU-OpenSource.github.io
> docusaurus build

Creating an optimized production build...

✔ Client
  Compiled successfully in 38.09s

✖ Server
  Compiled with some errors in 43.44s

ReferenceError: command is not defined
(undefined) ReferenceError: command is not defined
    at MDXContent (main:14754:931)
    at d (main:23128:498)
    at Za (main:23131:16)
    at a.b.render (main:23136:476)
    at a.b.read (main:23136:18)
    at Object.renderToString (main:23146:364)
    at render (main:40286:252)
Error: Failed to compile with errors.
    at /Users/focaaby/Project/NCNU-OpenSource.github.io/node_modules/@docusaurus/core/lib/commands/build.js:37:24
    at finalCallback (/Users/focaaby/Project/NCNU-OpenSource.github.io/node_modules/webpack/lib/MultiCompiler.js:254:12)
    at /Users/focaaby/Project/NCNU-OpenSource.github.io/node_modules/webpack/lib/MultiCompiler.js:277:6
    at done (/Users/focaaby/Project/NCNU-OpenSource.github.io/node_modules/neo-async/async.js:2931:13)
    at runCompilers (/Users/focaaby/Project/NCNU-OpenSource.github.io/node_modules/webpack/lib/MultiCompiler.js:181:48)
    at /Users/focaaby/Project/NCNU-OpenSource.github.io/node_modules/webpack/lib/MultiCompiler.js:188:7
    at /Users/focaaby/Project/NCNU-OpenSource.github.io/node_modules/webpack/lib/MultiCompiler.js:270:7
    at finalCallback (/Users/focaaby/Project/NCNU-OpenSource.github.io/node_modules/webpack/lib/Compiler.js:257:39)
    at /Users/focaaby/Project/NCNU-OpenSource.github.io/node_modules/webpack/lib/Compiler.js:273:13
    at AsyncSeriesHook.eval [as callAsync] (eval at create (/Users/focaaby/Project/NCNU-OpenSource.github.io/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:40:1)
    at AsyncSeriesHook.lazyCompileHook (/Users/focaaby/Project/NCNU-OpenSource.github.io/node_modules/tapable/lib/Hook.js:154:20)
    at onCompiled (/Users/focaaby/Project/NCNU-OpenSource.github.io/node_modules/webpack/lib/Compiler.js:271:21)
    at /Users/focaaby/Project/NCNU-OpenSource.github.io/node_modules/webpack/lib/Compiler.js:681:15
    at AsyncSeriesHook.eval [as callAsync] (eval at create (/Users/focaaby/Project/NCNU-OpenSource.github.io/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:4:1)
    at AsyncSeriesHook.lazyCompileHook (/Users/focaaby/Project/NCNU-OpenSource.github.io/node_modules/tapable/lib/Hook.js:154:20)
    at /Users/focaaby/Project/NCNU-OpenSource.github.io/node_modules/webpack/lib/Compiler.js:678:31
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>build: `docusaurus build`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>build script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR!      /Users/focaaby/.npm/_logs/2020-02-05T17_39_04_248Z-debug.log

Reproducible Demo

git clone https://github.com/NCNU-OpenSource/NCNU-OpenSource.github.io.git
git checkout migrate-theme-to-docusaurus
npm install
npm run build

Thanks for @lex111 !


Load k8s resources from a manifest file and operate on those resources.

This will make it easy for users of the client library to replicate kubectl create -f <manifest.yml> functionality in python modules. Java client offers this functionality with client.load("manifest.yml) function.

Official java client and python client are generated by swagger code-gen, kubernetes-client/gen, the structure of two java client libraries are quite different.

But if you just want the create function, you can do the function mapping, find the write function name by parsing the manifest.yaml and swagger.json.
Here is a sample:
https://github.com/SmilentRhino/kubenetes_ops_scripts/blob/master/kube_create_draft.py
The code is ugly, and can't use directly, just to provide some thoughts.

IMHO, golang is the only right way for managing kubernetes now. There is not equial of kubectl apply now in other library.
kubectl apply can act as a diff tool, which is quite import for managing kubernetes as code.

You might be interested in helm and [ksonnet)(https://github.com/ksonnet)

/close via #655

I am closing this issue since it has already been merged. Thanks @micw523


Ramp not working with v3

Currently running:

Spotify for macOS (Intel) <IP_ADDRESS>9.ga3ae422d.
Spotify Controller 0.2.0
Companion 3.0.0rc2
MacOS 12.4

Play / Pause works fine, but the volume ramp isn't working for the application.
I have a button with two steps acting as a play ramping volume to 100 on step 1, and ramping down to 0 on step 2.
From the log:
23.07.02 06:00:59 Surface/Handler/streamdeck:DL31L2A84124: Button 1.3 pressed 23.07.02 06:00:59 Instance/Wrapper/spotify-controller2: Error executing action: action is not defined 23.07.02 06:00:59 Instance/Wrapper/spotify-controller2: Sending: play 23.07.02 06:00:59 Instance/Wrapper/spotify-controller2: Error executing action: action is not defined 23.07.02 06:00:59 Surface/Handler/streamdeck:DL31L2A84124: Button 1.3 released 23.07.02 06:01:08 Surface/Handler/streamdeck:DL31L2A84124: Button 1.3 pressed 23.07.02 06:01:08 Instance/Wrapper/spotify-controller2: Error executing action: action is not defined 23.07.02 06:01:08 Surface/Handler/streamdeck:DL31L2A84124: Button 1.3 released 23.07.02 06:01:13 Instance/Wrapper/spotify-controller2: Sending: pause 23.07.02 06:01:13 Instance/Wrapper/spotify-controller2: Error executing action: action is not defined
Screenshots:

It's a companion module bug not a spotify controller problem. However I pushed a module v2.0.1 to companion betas that will fix this


Update CameraModeCommand.java

only /s

If you want your own version with just /s, fine. But I won't remove any of these from the main version without a good reason.

yes i want to use /s in my version how can i do it.


ICorrelationContextAccessor has setter

Hello and thank you for the awesome library, it's very useful for me!
One thing I noticed is that ICorrelationContextAccessor has a setter on its only property CorrelationContext.
When this dependency is injected into a class, is it expected that the dependent type is able to modify the context via the interface?
My thinking is that dependents that need the correlation context shouldn't be able to change it too.
Can you clarify whether this is intended, or whether you'd accept a PR to change this behavior?
Cheers,
Matthew

Thanks, @MatthewLymer. I'm trying to recall if I had a reason for this and I can't think of one. I think it would be reasonable to make it an internal setter. Since this would be a breaking change, it would need to go into a v4 release. I'd welcome a PR against the v4 branch if you have time. Thanks!


Abstract ViewBundle changes in 0.8.0

The changes in #914 make a few assumptions on the usage of ViewBundle. The class was changed to abstract[1] which now requires consumers to implement getViewConfiguration from ViewConfigurable. Not all consumers will want/need to use this new method, in fact the implementation handles when the map is null[3].
While this isn't in itself a huge issue, it created unnecessary work when I uplifted from 0.8.0-rc2 to 0.8.0. I would like to propose converting ViewBundle back to non-abstract and providing a default implementation for getViewConfigutation similar to initialize[4].
[1] https://github.com/dropwizard/dropwizard/commit/1ffa692833bc4f14b9065ded24f19634724d6311#diff-dca5c6ed489635cea5799e7409e13b55
[2] https://github.com/dropwizard/dropwizard/commit/1ffa692833bc4f14b9065ded24f19634724d6311#diff-53f7e525544679077e00d692b9dbc26b
[3] https://github.com/dropwizard/dropwizard/blob/v0.8.0/dropwizard-views/src/main/java/io/dropwizard/views/ViewBundle.java#L105
[4]https://github.com/dropwizard/dropwizard/blob/v0.8.0/dropwizard-views/src/main/java/io/dropwizard/views/ViewBundle.java#L110-113

Relates to https://github.com/dropwizard/dropwizard/pull/943

https://github.com/dropwizard/dropwizard/commit/bff376b17ea4dc48625c2b3b16d6200261632d7a


Fix workspace ignored deps

It seems like workspace ignored deps were not being handled correctly - they should be appended to package-level deps.

This ignore feature is intended to only work on that Cargo.toml.
🤔 wouldn't this accidentally ignore too much?
e.g. Root Cargo.toml ignores a crate, but the crate is clearly unused in a sub-package?

My understanding was that its main purpose (like with cargo-machete) would be to ignore crates that will always pop up - e.g. those used in build-deps and proc-macros in obscure ways, e.g.: prost, prost-build, prost-types, pbtypes, pbtypes-json, tonic-build, etc... otherwise you have to add package.metadata to every single package which gets too boring too fast.

Makes sense.

Thanks @Boshen 🥂


Release v1.3.0

This is an automated PR to prep Data Science Pipelines Operator for release.

odh_org: example-test-organization
release_branch: v1.3.x
target_version_tag: v1.3.0
previous_release_tag: v1.2.0

Release created successfully:
https://github.com/example-test-organization/data-science-pipelines-operator/releases/tag/v1.3.0
https://github.com/example-test-organization/data-science-pipelines/releases/tag/v1.3.0


Tortoise panic when restarting a Node

After restart, a persistent node panicked running the Tortoise:
{"L":"INFO","T":"2020-01-06T21:08:13.875Z","N":"31476.post         ","M":"execution: start executing 1 files, parallelism degree: 1\n","node_id":"31476"} {"L":"INFO","T":"2020-01-06T21:08:13.875Z","N":"00000.defaultLogger","M":"json API listening on port 9090"} {"L":"INFO","T":"2020-01-06T21:08:13.875Z","N":"h895zseHr3shKG2xhiAZRMH9XpbNDT4BM4XiKNzik5c","M":"Bootstrap: starting with 1 sized table"} {"L":"INFO","T":"2020-01-06T21:08:13.875Z","N":"00000.defaultLogger","M":"grpc API listening on port 9091"} {"L":"INFO","T":"2020-01-06T21:08:13.877Z","N":"31476.mesh         ","M":"Validate layer 94","node_id":"31476"} {"L":"INFO","T":"2020-01-06T21:08:13.877Z","N":"31476.trtl         ","M":"Tortoise update tables","node_id":"31476","layer_id":94,"n_blocks":33} {"L":"INFO","T":"2020-01-06T21:08:14.415Z","N":"31476.trtl         ","M":"found minimal good layer 93,<PHONE_NUMBER>","node_id":"31476"} {"L":"ERROR","T":"2020-01-06T21:08:14.426Z","N":"31476.trtl         ","M":"Fatal: goroutine panicked. Stacktrace: goroutine 220 [running]:\nruntime/debug.Stack(0x0, 0xc00013ef88, 0x4d13d4)\n\t/usr/local/go/src/runtime/debug/stack.go:24 +0xa7\ngithub.com/spacemeshos/go-spacemesh/log.Log.Panic(0xc000292a80, 0xc0003041f0, 0xc0066281e0, 0x47, 0x0, 0x0, 0x0)\n\t/go/src/github.com/spacemeshos/go-spacemesh/log/zap.go:41 +0x26\ngithub.com/spacemeshos/go-spacemesh/tortoise.(*NinjaTortoise).addPatternVote.func1(0x30216fdcb0b206ea, 0x13de6a6f1fb9e83e, 0xd21d44f550372a45, 0x4af7f22d7801f38b)\n\t/go/src/github.com/spacemeshos/go-spacemesh/tortoise/ninja_tortoise.go:435 +0x9a2\ngithub.com/spacemeshos/go-spacemesh/tortoise.(*NinjaTortoise).handleIncomingLayer(0xc0001cbce0, 0xc00516b3a0)\n\t/go/src/github.com/spacemeshos/go-spacemesh/tortoise/ninja_tortoise.go:572 +0x5ea\ngithub.com/spacemeshos/go-spacemesh/tortoise.(*Algorithm).HandleIncomingLayer(0xc003cddf00, 0xc00516b3a0, 0x0, 0x0)\n\t/go/src/github.com/spacemeshos/go-spacemesh/tortoise/algorithm.go:56 +0xb6\ngithub.com/spacemeshos/go-spacemesh/mesh.(*Mesh).ValidateLayer(0xc000578120, 0xc00516b3a0)\n\t/go/src/github.com/spacemeshos/go-spacemesh/mesh/mesh.go:170 +0xf0\ngithub.com/spacemeshos/go-spacemesh/sync.(*Syncer).Synchronise(0xc00017e780)\n\t/go/src/github.com/spacemeshos/go-spacemesh/sync/syncer.go:293 +0x3e1\ngithub.com/spacemeshos/go-spacemesh/sync.(*Syncer).getSyncRoutine.func1()\n\t/go/src/github.com/spacemeshos/go-spacemesh/sync/syncer.go:192 +0x6d\ncreated by github.com/spacemeshos/go-spacemesh/sync.(*Syncer).run\n\t/go/src/github.com/spacemeshos/go-spacemesh/sync/syncer.go:207 +0x226\n","node_id":"31476"} {"L":"PANIC","T":"2020-01-06T21:08:14.426Z","N":"31476.trtl         ","M":"block ea06b from layer 93 has no explicit voting, something went wrong ","node_id":"31476"}
Looks like it has a similar cause as https://github.com/spacemeshos/go-spacemesh/issues/1593
[Note that the Node seems to be running Post (first line) for some reason]

@barakshani it would be great if we have a full log of this issue or a way to reproduce

We encountered a similar problem, only that instead of the error message above, we got something about failure of XDR

Ran into this error just now, running using the smapp GUI on OS X. Full log: https://gist.github.com/lrettig/38294598448b67032f378970096f8cea
Here's what I saw in the frontend:
Error: Command failed: /Applications/Spacemesh.app/Contents/node/go-spacemesh --grpc-server --json-server --tcp-port 7513 --config '/Users/lanerettig/Library/Application Support/Spacemesh/config.toml' --coinbase 0xf08f67f9a5c968025e241627625c0cb909c39ab8b52898b68e484ce4fa5006d2 --start-mining --post-datadir '/Users/lanerettig/post' -d '/Users/lanerettig/Library/Application Support/Spacemesh/spacemeshtestdata/' >> '/Users/lanerettig/Library/Application Support/Spacemesh/spacemesh-log.txt'
panic: block 2c432 from layer 149 has no explicit voting, something went wrong

goroutine 225 [running]:
go.uber.org/zap/zapcore.(*CheckedEntry).Write(0xc0000f1600, 0x0, 0x0, 0x0)
	/Users/ilya/go/pkg/mod/go.uber.org/zap@v1.10.0/zapcore/entry.go:229 +0x546
go.uber.org/zap.(*SugaredLogger).log(0xc0002fe208, 0x604, 0xc0001981e0, 0x48, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0)
	/Users/ilya/go/pkg/mod/go.uber.org/zap@v1.10.0/sugar.go:234 +0x100
go.uber.org/zap.(*SugaredLogger).Panicf(...)
	/Users/ilya/go/pkg/mod/go.uber.org/zap@v1.10.0/sugar.go:159
github.com/spacemeshos/go-spacemesh/log.Log.Panic(0xc00028bce0, 0xc0002fe208, 0xc0001981e0, 0x48, 0x0, 0x0, 0x0)
	/Users/ilya/go/src/github.com/go-spacemesh/log/zap.go:42 +0x14a
github.com/spacemeshos/go-spacemesh/tortoise.(*NinjaTortoise).addPatternVote.func1(0x1a4b6812ee2e432c, 0xe962ff911fcfccf, 0xc080bbc1ed)
	/Users/ilya/go/src/github.com/go-spacemesh/tortoise/ninja_tortoise.go:444 +0x9f2
github.com/spacemeshos/go-spacemesh/tortoise.(*NinjaTortoise).handleIncomingLayer(0xc0002f0a80, 0xc0066b5600)
	/Users/ilya/go/src/github.com/go-spacemesh/tortoise/ninja_tortoise.go:566 +0x71d
github.com/spacemeshos/go-spacemesh/tortoise.(*Algorithm).HandleIncomingLayer(0xc004e788a0, 0xc0066b5600, 0x0, 0x0)
	/Users/ilya/go/src/github.com/go-spacemesh/tortoise/algorithm.go:55 +0xc8
github.com/spacemeshos/go-spacemesh/mesh.(*Mesh).ValidateLayer(0xc00010c2c0, 0xc0066b5600)
	/Users/ilya/go/src/github.com/go-spacemesh/mesh/mesh.go:209 +0xf9
github.com/spacemeshos/go-spacemesh/sync.(*Syncer).handleNotSynced(0xc00010c420, 0x96)
	/Users/ilya/go/src/github.com/go-spacemesh/sync/syncer.go:355 +0xca
github.com/spacemeshos/go-spacemesh/sync.(*Syncer).Synchronise(0xc00010c420)
	/Users/ilya/go/src/github.com/go-spacemesh/sync/syncer.go:318 +0x448
github.com/spacemeshos/go-spacemesh/sync.(*Syncer).getSyncRoutine.func1()
	/Users/ilya/go/src/github.com/go-spacemesh/sync/syncer.go:211 +0x6d
created by github.com/spacemeshos/go-spacemesh/sync.(*Syncer).run
	/Users/ilya/go/src/github.com/go-spacemesh/sync/syncer.go:232 +0x234

Full config.toml contents:
[main]
genesis-time = "2020-02-04T07:06:06+00:00"
layer-duration-sec = "300"
layer-average-size = "30"
layers-per-epoch = "6"
genesis-active-size = "50"
poet-server = "<IP_ADDRESS>:50002"
sync-request-timeout = "20000"
hdist = "7"

[p2p]
network-id = "1"

[p2p.swarm]
bootstrap = true
randcon = "8"
bootnodes = ["spacemesh://6Q5oLe7rARVfFeekrzy9qjPDcA9csTLnkQ9aZp64wYf4@<IP_ADDRESS>:7513"]

[api]

[time]

[post]
post-space = "1048576"

[reward]
base-reward = {abs = "50000000000000"}

[hare]
hare-round-duration-sec = "30"
hare-committee-size = "30"
hare-max-adversaries = "14"
hare-exp-leaders = "5"
hare-wakeup-delta = "30"
hare-limit-iterations = "10"

[hare-eligibility]
eligibility-confidence-param = "25"
eligibility-epoch-offset = "0"

[logging]
app = "info"
post = "info"
stateDb= "info"
state = "info"
store = "info"
poetDb = "info"
meshDb = "info"
trtl = "info"
atxDb = "info"
block-eligibility = "info"
mesh = "info"
sync = "info"
block-oracle = "info"
hare-oracle = "info"
hare = "info"
block-builder = "info"
block-listener = "info"
poet = "info"
nipst = "info"
atx-builder = "info"
hare-beacon = "info"

Much shorter log, same issue: https://gist.github.com/lrettig/67f815daed6f0a373e53f881cbdfcf80
Steps to reproduce:

Start running the Spacemesh OS X app
Quit it
rm -rf ~/spacemesh ~/spacemeshtestdata ~/post
Rerun it

App screenshot:

@lrettig that recreation flow is a bit strange, if you deleted spacemeshtestdata
you shouldn't have any prior mesh related data so the node should start from scratch
but from the log is looks like you are trying to recover from layer 149

ok @lrettig 's recreation flow allowed me to figure this out, basically we dont pass the datadir param whan running with the app which causes all data folders to be written to home.
running with -d ~/spacemesh/data/ fixes this

To clarify, I get this error after restarting the node w/o deleting any local data files between the runs.
The app passes the data folder (-d param) to the node when it starts it on each new app session.
I'm going to share full logs of a repo case here next time it happens.


processing data in models

In this PR, I have incorporated the following:
Create models

Create model classes for all entities as shown in the ERD diagram.
Set up associations between models.
Use models to insert data
Familiarize yourself with 'rails c' command.
Open rails console for your project.
Create at least one user by running the following code:

first_user = User.create(name: 'Tom', photo: 'https://unsplash.com/photos/F_-0BxGuVvo', bio: 'Teacher from Mexico.')
second_user = User.create(name: 'Lilly', photo: 'https://unsplash.com/photos/F_-0BxGuVvo', bio: 'Teacher from Poland.')
Create at least 4 posts written by one of the users you created by running the following code:
first_post = Post.create(author: first_user, title: 'Hello', text: 'This is my first post')
Create at least 6 posts comments for one of the posts you created by running the following code:
Comment.create(post: first_post, author: second_user, text: 'Hi Tom!' )
Users

A method that returns the 3 most recent posts for a given user.
Posts
A method that updates the posts counter for a user.
A method which returns the 5 most recent comments for a given post.
Comments
A method that updates the comments counter for a post.
Likes
A method that updates the likes counter for a post.
Go to rails c and check if your methods are working.

Hi @for-ashraf
Your project is complete!  There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

As described in the Code reviews limits policy  you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.


memory buffer + format multiline loses data on restarts

fluentd v0.14.16 (from the td-agent-3 installer)
CentOS 7 under virtualbox
Config to replicate:

  @type tail
  read_from_head true
  path /tmp/test.log
  pos_file /var/log/td-agent/test.log.pos
  tag test
  format multiline
  time_format "%d-%b-%Y %H:%M:%S.%L"
  format_firstline /\d{2}-\S{3}-\d{4} \d{2}:\d{2}:\d{2}.\d{3}/
  format1 /(?<time>\d{2}-\S{3}-\d{4} \d{2}:\d{2}:\d{2}.\d{3}) +(?<message>(?:\n|.)+)/
</source>

<match test>
  @type file
  path "/var/log/td-agent/test.out"
  append true
  <buffer>
    @type memory
  </buffer>
</match>

Steps to replicate:

Start fluentd with the above config, with the attached file (test.log) in /tmp/test.log
Restart fluentd
the log at /var/log/td-agent/test.out now contains messages 1-4.
Add the attached lines to the end of /tmp/test.log (test2.log)
Restart fluentd again
test.out will contain message 6, skipping message 5.

It looks like the multiline formatter (when using a memory buffer) is dropping the last held lines, which were waiting on a matching format_firstline, when you restart. An option to persist this data in the pos file or some other location would be helpful.
This issue does not affect @type file buffers from my testing. Also, I have yet to test on v0.12 to see if it is impacted as well. I should have time later today to test v0.12 and a newer v0.14 version.

This does NOT appear to affect v0.12.

https://github.com/fluent/fluentd/pull/1763 also fixes this issue.

v0.14.25 includes above patch.


UED04 "Dual-Armed Husky" addition

Will be squashing commits/cleaning up as this goes on. This initial un-edited commit is to make users aware of the bulk of the work and where it started from.
In this pull request, I've added these features:

the ability to use 2 UR5 arms on a Husky
the environment variable addition of the flir_ptu, bumblebee, velodyne vlp 16, bulkhead, and robotiq grippers
changing from parametrization of launch files to environment variables for ur5, and following this convention forward in code
addition of the husky_dual_ur5_moveit_config ROS package which holds all configurations for the Husky

Note: this pull request will require more than the Husky package to be a completion of work, it also depends on changes in (will reference the issues when I make them)

husky_simulator
robotiq
universal_robot

Future work includes the addition of the octomap pipeline for moveit for the Dual UR5 platform, and the ability to control the flir_ptu via moveit
@tonybaltovski @paulbovbel @ibaranov-cp  If you could find the time - please take time to look over these changes and propose modifications or edits to the PR in case of convention.

Squash your commits please

My perspective on the husky repositories is that it should include support for 'standard' configurations, and everything else belongs in a customer-specific customization repo.  Please correct me if I'm wrong.
There is a lot of stuff here that makes sense for a one-off deployment...

copy pasted yamls and python scripts for stowing/controller config, with minor changes - DRY, parametrize
a gajillion new env vars that are related only to this dual-arm+bulkhead deployment and not general purpose
namespace incompatibilities between sim and real robot, requiring a real roslaunch arg

.. but is a little worrying to put into the core husky packages
If this is going to be a standard product, let's talk more and we can do a more thorough break down and rework of the issues.

If this is going to be a standard product, let's talk more and we can do a more thorough break down and rework of the issues.

Yes - this is a standard configuration for 2 armed Husky's.

My perspective on the husky repositories is that it should include support for 'standard' configurations, and everything else belongs in a customer-specific customization repo.  Please correct me if I'm wrong.

We need to move away from this mentality. This repo should be configured via parameters that easily allow us to build a husky via building blocks like drivers, models, configurations. Similar to how the kernel can be configured for many use cases. This saves time in the future, and adds a process of progression and allows us to sell more options with less expense in engineering.
After a lot of drivers/setups configurations have been added, we can look to refactor that process to then strap onto other robots, so other robots we make can benefit from this process and use the drivers/system setup/system configuration we've made here.
A standard configuration is enabled by default, however, as always.

copy pasted yamls and python scripts for stowing/controller config, with minor changes - DRY, parametrize

I'll pass in a parameter "left" or "right" and use the same script. Can you comment on the code where there is copy and pasted yamls and offer a suggestion to "parametrize" and "refactor" a YAML file?

a gajillion new env vars that are related only to this dual-arm+bulkhead deployment and not general purpose

... Not true. Later we can add things like env vars for positioning new sensors and their parents as well. See how the lasers are setup. I fail to see what's wrong with providing a 2 armed static setup. We don't currently have one. Are you suggesting I write a general purpose robot configuration setup for the Husky? If so, this PR moves closer to that goal by slowly adding more drivers/configurations such as the linux kernel does.

namespace incompatibilities between sim and real robot, requiring a real roslaunch arg

This is a MoveIt! tradition and I want to preserve it.
TODOS:

Squash commits
Refactor stow scripts

I prefer to see envvars constrained to very simply flag-flips, like "enable the thing". Sophisticated configurations should use the xacro interface in a fully custom URDF, IMO.
I don't have enough context to comment on this in particular.

I prefer to see envvars constrained to very simply flag-flips, like "enable the thing". Sophisticated configurations should use the xacro interface in a fully custom URDF, IMO.
This PR is set up so that there is an envvar to enable the dual arm basic setup, and another envvar to enable the grippers if they wish to use them.Without those two flags used, the husky spawns as standard.
With the envvar which specifies only a single ur5, the single ur5 basic setup is loaded.
At the moment, we have 3 configurations: a base model husky, a single armed husky, and a dual armed husky. Flipping on the respective env-vars handles everything behind the scene for each of these robots and so users should experience a regular launch.

Referencing the newly added parameters: http://wiki.ros.org/husky_bringup/Tutorials/Customize Husky Configuration#preview

Alright fair enough (regarding the standard product part), as long as it's done in a clean way. This and kernel build config is apples and firetrucks.

Preference would be to make the parent_link for any non-dual-ur5 specific sensors (bumblebee, flir_ptu) to top_plate_link, so they can be used independently.
Move any readme information to a section on the wiki, perhaps with specific pages for single and multi armed ur5
Add the necessary dependencies to package.xml
The control_*ur5.yaml's are pretty redundant, maybe template them using CMake or roslaunch XML's rosparam substitution mechanism.
use the same stow script for single and two arm'd ur5 config

Also please squash :)

TODOS: (postponing merge until more time allocated)

Squash commits
Make parent link env vars for bumblebee, flir_ptu, velodyne.
move readme to tutorial for dual husky
add dependencies to package
Same stow script, parametrized
roslaunch param substitution? for the yaml files.. um

@TheDash Is there any update regarding the referenced update to husky_simulator for the dual arm husky? I couldn't find a branch in the corresponding repository.

In order to cut down on the amount of dependencies, everything UR/moveit-related has been removed from the base husky repos in kinetic-devel. Please see kinetic's urdf_extras and config_extras launch arguments as a hook to extend the base husky robot/simulation.

The dual UR5 armed husky org is here:
https://github.com/DualUR5Husky

Extensions are great - but modifications to the "base" systems aren't supported by kinetic, and so we've gone this route.

They are supported, via the urdf_extras and config_extras launch arguments and respective env vars.

They are not @paulbovbel. Launch arguments and env vars is way too complicated for development and actually slows the development time of getting a new robot out the door if there's new stuff to add.
If this stuff were useful, or perhaps it's not explained properly, I would use it. That being said - these do serve their purpose for the base husky customizations. As far as making a Husky more complex - this solution does not work.
Code complexity and spaghetti code is a real thing. And I'm avoiding it at all costs by not using the above soln for my problems


Add a contact popup to facepile

https://youtu.be/QvPjcukG2u4?t=1425
Anthony has requested for a popup to be added to the facepile component.
This would popup when hovering over the avatars.
The popup should include the avatar, user information, and some buttons for actions such as email

Completed.


Crash with Lil Tater Reloaded

The mod crashes with Lil Tater Reloaded, here's the crash report:
https://hastebin.com/hisocofiti.cs

Flamingo isn't exactly a complex mod, you should report it to them instead.

please close this invalid issue 🐛


Adding capability to take max upload size per request.Fileupload 1 3 1

As of now FileUploadBase has sizeMax which is global for all uploads, in many cases it is required to calculate this limit based on request.
https://stackoverflow.com/questions/16585866/changing-file-size-limit-maxuploadsize-depending-on-the-controller

I'd support Gary's request, that you provide a PR for the current master, and not the stable branch.

Well spotted, that you should use the RequestContext, to support both the servlet, and the portlet case!

Rather than using a method getSizeMaxForThisRequest, I'd suggest a more general approach, (The 1.4 branch is still open for API changes.) such as:

Replace

FileItemStream FileUploadBase.getItemIterator(RequestContext pCtx)

with a method

FileItemRequest getItemIterator(RequestContext pCtx)

where FileItemRequest would contain methods like
void setMaxUploadSizeExceeded(Predicate<Long> pPredicate) {
}
FileItemStream getItemIterator();

On the other hand, rethinking that, it is probably a better idea, if I do that myself.

Please close in favour of FILEUPLOAD-300.

@jochenw i implemented current solution avoiding breaking changes for 1.3.1, but i agree with you for master, we can do it with api changes. Also i'll do more brainstorming on this feature. Closing this PR in favour of  FILEUPLOAD-300.


fix wvsharber/BeatMapSynthesizer#44

this pr makes the json data valid so that not all blocks default to red. originally, the number for which color was in quotes, making it a string rather than an integer which is what the game expected.


2386: Make the E2E tests less flaky

Short description

We've been having issues with the E2E tests failing quite a bit, and working when restarting them. I checked the last 11 times that the tests failed, and it was each time because of the test checking for the overlay to change the language to appear.
Proposed changes

I added one additional waiting command to that test, to wait specifically for one of the language links. In 200 tests on my machine, the test hasn't failed since.

Side effects

If we take out the English language from the E2E-Testumgebung, the test will fail again, and then always. But I don't see why we would do that.

Resolved issues

Fixes: #2386

I added one additional waiting command to that test, to wait specifically for one of the language links. In 200 tests on my machine, the test hasn't failed since.

Did the tests failed on your local machine before?

Yes, I don't have the exact numbers anymore but I put in a 50x loop for that specific test and it would fail between 30 and 40 times out of those. Only in Chrome though, not in Firefox or Safari.


session.load_known_hosts() takes very long time to finish.

When my user have 500 known hosts, this call takes many minutes.
https://github.com/leopoul/ncclient/blob/master/ncclient/manager.py#L114
I disabled this call in my code at this moment, hope you can fix it.

Setting hostkeys_verify = False at the connection params will now bypass loading of the hosts file (fixed here:  https://github.com/leopoul/ncclient/blob/master/ncclient/manager.py#L113 )
This fix will be included in the upcoming release.
Best,
Leo


Relative cursor based pagination not working

Hi,
I'm trying to use the following boilerplate code to extract all my shop's products
products = ShopifyAPI::Product.find(:all, params: { limit: 50 })
process_products(products)
while products.next_page?
  products = products.fetch_next_page
  process_products(products)
end

But when I use it, I get a NoMethodError for "process_products".
I'm using the most recent gem 'shopify_api', '~> 8.0'
Any insight?

The process_products method is just a placeholder for whatever you need to do with your products. This isn't explained at all in the readme, so I don't blame you for running into this. We'll have to update the docs.
In the boilerplate example you lined, you're processing them in batches with some undefined method called process_products. If you just want to do something like return every products on the store instead, this is what it would look like :
products = ShopifyAPI::Product.find(:all, params: { limit: 50 })
product_list = []
while products.next_page?
  products = products.fetch_next_page
  product_list << products
end
product_list

Thanks for the insight @ShayneP ! I'll try it out.

Hey,@ShayneP
I have implemented the same in my app but it is giving me an error in the next_page? and fetch_next_page like https://prnt.sc/q95sjp
My Shopify API gem version is "shopify_api (8.0.0)"
api_version =  '2019-10'
'rails', '~> 5.2.3'
'shopify_app' , '>= 10.0.0'
Any insight?


Address feedback on PerfTop dashboard

Description
Feedback received on how to create the perftop dashboard.
Issues Resolved
n/a
Checklist

[x] By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@kkhatua , @khushbr - please review. Thanks!


Is it possible to simply run the calculation of a schema without having to add it to the ui ?

I want to execute a saved schema without having to add it to the UI and if possible with different data but i did not already find a way to change data on a same schema (for exemple putting values on unlinked nodes

hey @Silectio that's possible. you can have a look at the compute_engine within the barfi python package.


slide_in_right.gd is a duplicate of back_in_right.gd, and scales incorrectly.

The problem
Describe the bug
slide_in_right.gd contains incorrect code that causes the animation to have a scaling effect it should not have. The code is identical to back_in_right which I believe is intended to have this effect
To Reproduce
Steps to reproduce the behavior:

Create a character that enters a scene with the slide_in_right animation
build the scene and watch as the animation that plays is incorrect

Expected behavior
The character should slide into the scene without scaling at all.
System (please complete the following information):

OS: Mac
Godot Version: 3.5.stable.official
Dialogic Version: 1.4.5

Solutions
Workaround
I removed lines 8-13 and line 24 of the code in addons/dialogic/Nodes/Anima/animations/entrances_and_exits)/slide_in_right.gd
Possible fixes
this can be fixed by removing lines 8-13 and line 24 of the code in addons/dialogic/Nodes/Anima/animations/entrances_and_exits)/slide_in_right.gd
screenshot

here is a screenshot of the edited code

Closing since Dialogic 1 is no longer in active development


ECR RepositoryPolicy constantly reconciles

What happened?
Seeing a very high rate (upwards of 10 per minute per resource) of reconciles for repositorypolicy.ecr.aws.crossplane.io against provider-aws master, even though all policies exist, are up to date and not late-initialized.
Given that there can only be one policy per repository, I would expect to see a similar reconcile rate as seen with repositories but this is not the case.
It looks like this is caused by the AWS API constantly returning array items inside my repository policy (in this case AWS Principals) in a different order. I've confirmed this locally - no two subsequent calls to aws ecr get-repository-policy for a particular repository returns the same policy order.
This is correctly ignored by provider-aws and marked as up to date (as we ignore sort order when comparing the policy as of #701), but it looks like when the controller persists the 'updated' resource status back to the Kubernetes API, it causes the requeue period that provider-aws requested to be ignored, and the resource is requeued straight away.
This ends up in an endless loop of updates that has some other nasty side effects like blowing out the AWS SDK connection pool.
How can we reproduce it?
Apply an ECR repositorypolicy with the following spec, with many different AWS account ID's:
spec:
   deletionPolicy: Delete
   forProvider:
     policy:
       id: AllowAccounts
       statements:
       - action:
         - ecr:BatchCheckLayerAvailability
         - ecr:BatchGetImage
         - ecr:GetDownloadUrlForLayer
         effect: Allow
         principal:
           awsPrincipals:
           - awsAccountId: arn:aws:iam::3398....7229:root
           - awsAccountId: arn:aws:iam::9718....6735:root
           - awsAccountId: arn:aws:iam::8433....0030:root
           - awsAccountId: arn:aws:iam::4883....5958:root
           - awsAccountId: arn:aws:iam::9418....5648:root
           - awsAccountId: arn:aws:iam::3468....4853:root
         sid: AllowPullNonProdAccounts
       version: "2008-10-17"
     region: us-east-1

And then monitor the number of reconciles. I worked out what was going on by dumping the policy inside kubernetes at set intervals and then diffing the yaml output.
What environment did it happen in?
Crossplane version: v1.3
Provider-AWS version: 009f048d509ba924ce6c456740ab946666a49bb6
Fix
I wonder if policyText should even be available on this resource, as this is just a different representation of a user-defined setting and the resource should be updated if these don't match.

I wonder if policyText should even be available on this resource, as this is just a different representation of a user-defined setting and the resource should be updated if these don't match.

Thanks for detailed debugging @benagricola ! I agree that we can remove it. The only place it's used is here, which can work with the response directly.


[Forms][Android][iOS] Disable notification controls in Android and iOS

💬 Questions and Help
Is there an easy way to completely disable notification controls in Android and iOS?
I've looked around into ExoPlayer sources, but it looks a bit overwhelming. Haven`t gotten into iOS yet.
Any direction or tips?

CrossMediaManager.Current.NotificationManager.Enabled = false;
Available in 0.5.6

Hi @tehort Did you tried
CrossMediaManager.Current.NotificationManager.Enabled = false;
Is it working ??

Hi @tehort Did you tried
CrossMediaManager.Current.NotificationManager.Enabled = false;
Is it working ?? Please Let me know.

Yes, working just fine.

Hi @tehort
Please help me out in this.
In Android it is working.
For iOS it is not working.


Don't add superfluous "and" when there is no discriminator filter

When @WhereJoinTable gets applied to a collection, a superfluous and is added to the rendered SQL unnecessarily when no discriminator filter is rendered as part of the predicate condition.

Thanks @Naros


Feature request: X3D should collect animations into GVRAnimator

When loading models with Jassimp, the animations are collected in a GVRAnimator component attached to the root of the model. This allows the user to start or stop all the animations in that model with a single call. It allows the unit tests to stop animations so the screenshots will produce the same results every time.
X3D should also create a GVRAnimator component which contains the animations that should start on load (as opposed to those triggered by user action). This will make the X3D unit tests which contain animated objects pass.

Made the change, and several regression tests - works fine.  For verification, calling GVRAnimator.start(), not GVRAnimator.autoStart().

The X3D exporter does not need to call GVRAnimator.start(). The asset loader will call this for you if you set the "autostart' option on GVRAnimator. You can do this by passing true as the second parameter to the GVRAnimator constructor.
In the future I will add support for auto-starting animations through the asset loader import settings. Then you will be able to control whether animations start automatically or not when the asset loads.

OK, now constructing GVRAnimator(gvrContext, true); with the true parameter and gvrAnimator.autoStart(); instead of gvrAnimator.start(), and everything works fine with a variety of tests including Level-of-detail demo's.


[CSDiagnostics] Offer protocol conformance fix-it in ContextualFailure

If we're assigning a value of concrete type to a protocol type but the type does not conform to the protocol and it's the same as the decl context's type, then offer a fix-it to add the conformance.
For example:
protocol Foo {}

class Bar1 {
  var prop: Foo?
}

class Bar2 {
  let bar1 = Bar1()

  func method() {
    bar1.prop = self // offer fix-it to conform 'Bar2' to 'Foo'
  }
}

Resolves SR-11412.

This is my initial implementation, but let me know your thoughts :)

@swift-ci please smoke test


DefaultSettings.json doesn't open even if option is checked

Issue Type: Bug

Open settings, having previously checked workbench.settings.openDefaultSettings

Expected: Default settings should open.
Actual: tbh,  it did that just once, then stopped doing it. The only change from then was changing files.hotExit to off.
Below is my settings.json (disregard the workbench.settings.editor, as it is ui by default and I poked with it just to see if it made any difference before resetting):
{
    "workbench.startupEditor": "newUntitledFile",
    "[markdown]": {},
    "editor.accessibilitySupport": "on",
    "window.zoomLevel": 1,
    "[vb]": {},
    "diffEditor.renderSideBySide": false,
    "workbench.settings.openDefaultSettings": true,
    "workbench.settings.openDefaultKeybindings": true,
    "files.hotExit": "off",
    "workbench.settings.editor": "ui"
}

VS Code version: Code 1.39.2 (6ab598523be7a800d7f3eb4d92d7ab9a66069390, 2019-10-15T15:35:18.241Z)
OS version: Windows_NT x64 6.1.7601

System Info

Item
Value

CPUs
Intel(R) Core(TM)2 Duo CPU     E7500  @ 2.93GHz (2 x 2926)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: disabled_offnative_gpu_memory_buffers: disabled_softwareoop_rasterization: unavailable_offprotected_video_decode: unavailable_offrasterization: unavailable_offskia_deferred_display_list: disabled_offskia_renderer: disabled_offsurface_synchronization: enabled_onvideo_decode: unavailable_offviz_display_compositor: disabled_offwebgl: enabledwebgl2: unavailable_off

Load (avg)
undefined

Memory (System)
3.97GB (0.78GB free)

Process Argv
--disable-extensions

Screen Reader
yes

VM
0%

Extensions disabled

To be clear, this only has an effect when opening the JSON version of the settings. You can do that through the command or the button in the GUI settings editor. Is that what you are trying to do?

No, I wasn't doing that. Now I've switched to json editor for settings and it works. Closing. Thank you very much.


Add usage section to help command

Currently the help command shows the Name and Description for the command. A usage section would give the user an idea about how to use the command.

Closed as of #61.


Invalid Link

Description
In section "随机数实践", The link to "Randomization in Contracts", which is https://developers.eos.io/eosio-cpp/docs/random-number-generation is not valid (404 not found) any more.

Thanks

@keywolf we removed that section of the developer docs since on-chain PRNG is not possible with EOSIO.

Okay, good to know. Thanks guys!


Eliminate dynamic cast by implementing MultipleReporters as a linked list

This is an alternative to the pull request I made yesterday (https://github.com/philsquared/Catch/pull/630). It eliminates the same use of RTTI as 630, and together with 631 (or some alternative to that one) makes Catch compile successfully with gcc and -fno-rtti.
I think I prefer this solution to 630. It avoids polluting the IStreamingReporter interface with methods that doesn't really have anything to do with reporting. Design-wise, I think I prefer this  to the original as well.
Note that I left MultiReporters::add() in since it is a public method. It is no longer used by addReporter(), though. So if it isn't used elsewhere and isn't considered part of the public API it can probably be dropped.

As mentioned in #630, I've resolved the underlying issue.
Thanks for the PRs

Thanks.


Cluster small archetypes in parallel iteration

What problem does this solve or what need does it fill?
QueryParIter establishes a batch size to chunk matching archetypes and tables into tasks to run on. Any archetype or table smaller than the batch size ends up in it's own task. This might help with work stealing, but it adds scheduling overhead.
What solution would you like?
Collect batches smaller than the provided batch size into an arrayvec and dispatch it as a task when either the total count exceeds the batch size or the buffer is full.
What alternative(s) have you considered?
Eating the performance cost and leaving it as is.

I'm currently working on a change that does this.
Rayon uses a significantly different algorithm for generating batches than we do. It splits the data in half. Send one half to a new task. And then checks the remaining half if it is now smaller than the batch size.
I'm pretty we can do something similar and it'll be faster when we're bottle necked on spawning tasks. Unfortunately my current work borked iteration speed so I need to figure that out.

Rayon uses a significantly different algorithm for generating batches than we do. It splits the data in half. Sends one half to a new task; Checks the remaining half if it is now smaller than the batch size; Then iterates on if if it is or recurses if it's not.

This is a double edged sword: it alleviates the burden of scheduling all of the tasks from one thread and more fluidly sharding the workload, in exchange for either higher contention or higher startup latency. Given that Rayon seems to do better for compute bound workloads that what we current have, that might be worth trying out.


Add Tensorial scitype

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (5f9fbde) to head (20b726a).

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #15   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            7         7
  Lines           40        41    +1
=========================================
+ Hits            40        41    +1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


How to set inserting mode default instead of filtering mode?

i want to after i draw table, inserting mode is show instead of filtering mode
what can i do?

Please, checkout the answer to the following question https://github.com/tabalinas/jsgrid/issues/280


Add Speeder-1 from Kerbal Stuff

This pull request was automatically generated by Kerbal Stuff on behalf of KerbiceGroup, to add Speeder-1 to CKAN.
Please direct questions about this pull request to KerbiceGroup.

To close (as always !) I even don't checked the checkbox !!

Closed on authors request


Referencing unknown inner type error even if type is defined

Binary Ninja Version: 3.2.3906-dev
OS: Windows 11, x64

Bug Description:
I've a structure like this:
struct _test
{
    int32_t a;
};

and a typedef for it like this: typedef struct _test test.
Now, when I try to edit some variable /function prototype and set variable /parameter type to test, I get an error message like this:
Referencing unknown inner type _test
Steps To Reproduce:

Create a structure
Create a typedef for it
Change variable /parameter type to that typedef
See unknown inner type error in log

Additional Information:
Is reproduces for enums.

Looks like imported typedef types were not properly marked as imported to the Clang plugin, so it was throwing a warning when trying to look it up. Will be fixed on dev 3.2.3924-dev.


kustomize: use quay.io image for the default deployment

ghcr.io requires authentication, it's easier to pull from quay.
part of #3
Signed-off-by: Schlotter, Christian<EMAIL_ADDRESS>
Christian Schlotter , Daimler TSS GmbH,
Provider Information

I wonder if we can use docker hub in the future. Have you asked about that?
Basem Vaseghi<EMAIL_ADDRESS>Daimler TSS GmbH, legal info/Impressum

I did go forward by using quay.io because its the most common one in the community. I'll clarify on that internally prior to mergin this :-)

We currently would be able to continue support here, however we are working on proposing CASM to contribute to github.com/kubernetes-sigs/cluster-api and thus will set this on hold for now.


Custom data directory support for state snapshot

Like geth there can be a --datadir flag using which the state of the local node can be stored and on restarting the service it can read the state from the custom directory, if it is passed, and continue on top of it.

Thanks @Aniket21mathur for pointing this out. In the background we're using Hardhat which intern uses ethereumjs/vm implementation to run a node. We're working on adding a DB layer. Will update shortly.


remove 1.4.3 version

version 1.4.3 introduced a sem ver mistake.

Not allowed, but you can yank it if you like.

Thanks.


After Update Assertions on Screens with SafeAreaView are Failing

Description
Many of our screens have a SafeAreaView at the top level to ensure content is rendered in the safe area bounds. After updating from 16.9.2 to 17.x.x many tests are failing with a RCTSafeAreaView is visible at window point error.

[x] I have tested this issue on the latest Detox release and it still reproduces

Reproduction
Provide the steps necessary to reproduce the issue. If you are seeing a regression, try to provide the last known version where the issue did not reproduce.

Navigate to a screen using a SafeAreaView.
Assert a component nested inside the SafeAreaView with a testID is visible using toBeVisible().
Notice failure. In 16.9.2 this passed.

Expected behavior
The component is visible on the screen with a valid identifier, in this instance the test should pass.
Screenshots
Here is a snapshot of the bottom half of the screen. You can see Add to Cart is visible.

But test fails with the error
       Error: Test Failed: Failed expectation: TOBEVISIBLE WITH MATCHER(identifier: == “buttonText” && (text == “Add to Cart” && (class ⊇ “UITextView” || class ⊇ “UITextField” || class ⊇ “UILabel” || class ⊇ “RCTTextView”))) AT INDEX(0), Another view “<RCTSafeAreaView: 0x7fa585f44270>” is visible at window point “{"x":259,"y":323.25}”
       TIP: To print view hierarchy on failed actions/matches, use loglevel verbose and above.

We're using Cucumber which doesn't work that well with the cli. Every time I try to use the cli it looks for mocha in my node_modules and bombs out. I got this hierarchy from XCode, will this suffice? If not I can fail the test intentionally on 16.9.2 which would print the hierarchy by default. The element selected is the red 'Add to Cart' button that you can see is visible in the screenshot.

I need the hierarchy at the failure of the test, so I can see the pointer it complains about. You should find a way to pass the trace log level to Detox.

That wasn't too difficult to figure out, but the hierarchy is huge so I saved it as a gist.
https://gist.github.com/AlexK777/77862568eb1e5d3e536e3b917e01a10d

The hierarchy is too big. Which text field are you trying to match? There are several with "Add to Cart" text, and identifiers are not printed in the hierarchy.

I think I was able to trim it down to just the screen in question. The second to last line with text: Add to Cart is what I am trying to assert is visible.

We have the same issue.
It works on 16.9.*, but not on 17.4.4.
Example
After logging in, we check for the whole screen before checking other stuff.

Terminal looking for rooms-list-view and the simulator on the view
I tried removing SafeAreaView from that screen, but the error happens anyway.

Thanks! :)

I’m sorry, but these huge hierarchy dumps are not helpful. Is the view you are actually looking for in the hierarchy? @diegolmello Use Xcode to debug your hierarchy and see if it’s there. In your case, you had Detox wait for 10 seconds to find it, and it still couldn’t. If you verify it’s there in the hierarchy, please change the test to be without timeout so I can see the underlying visibility failure reason. Thanks

Interesting.
@LeoNatan check this out:

Xcode thinks the sidebar is opened, but it isn't.
I changed from toBeVisible() to toExist() and the test has passed :)
I'm going to check all toBeVisible usage.
Btw I remember the 75% visible error from v16 would help on this case.
I'll keep you posted.
Thanks! 👊

Hi @diegolmello,
did you find any solution? I have the same problem. Thanks!

Nope.
It was kind of a mess to get it working on the new version.
We delayed this upgrade for now.

Please try the latest Detox version. I’m working on further improvements which will land soon.

Along with @diegolmello, I have just delayed the upgrade. I am still seeing the failure on latest (17.5.6)

@diegolmello I checked your repo. Your drawer type is back and mine too. I changed the drawer type to front. All test work. But drawer animation changed.
@LeoNatan I am using detox last version. Thank you for your improvements.

Please test with Detox 17.7.1, many changes in that build.
If you still get visibility issues, let me know. There is now a new mechanism for debugging visibility.

@LeoNatan I'm going to take a look next week. Thanks!

The test I originally filed this issue on is still failing for a visibility issue on the same element, but the error message is slightly different and no longer mentions SafeAreaView. The new debugging feature is cool. I have attached a screenshot of the output and a gif of the transition from a list of products to a single product. For some reason detox is seeing the list of products that exist behind the modal, and that is causing the visibility failure for the red Add to Cart button.

Please add
"artifacts": {
      "plugins": {
        "uiHierarchy": "enabled"
      }
    },

and reproduce. Once the test fails, provide the .viewhierarchy file. Thanks

If whatever framework you are using is setting the zPosition, I’m not sure we’ll support it.

When I run the test there are 3 .viewhierarchy files created, I attached each.
HierarchyFile.zip
HierarchyFile2.zip
HierarchyFile3.zip

I'm not sure which I should look at. I only the need the one that is at the time of failure.

I would imagine that is the first one, but they all have the same timestamp so I cannot be positive.

I've modified the algorithm to take into account zPosition. Once the test suite passes, I will merge and create a release. Let's hope it fixes that issue.


[Feature] Endothermic Reaction Calculator

Description
An Endothermic Reaction Calculator is a tool used to determine various parameters associated with endothermic reactions. In an endothermic reaction, the system absorbs energy from its surroundings, usually in the form of heat. These reactions are characterized by a positive enthalpy change (ΔH).
Purpose of the Endothermic Reaction Calculator:
1.Calculate the change in enthalpy (ΔH) for a given reaction.
2.Determine the amount of heat absorbed during the reaction.
3.Understand the relationship between reactants, products, and energy absorbed.
4.Perform stoichiometric calculations involving energy changes.
Screenshots

Checklist

[X] I have checked the existing issues.
[X] I follow Contributing Guidelines of this project.
[X] I am a GSSOC'24 contributor.
[ ] I am a IWOC'24 contributor.
[ ] I am a JWOC'24 contributor.
[ ] I am a SWOC'24 contributor.

Code of Conduct

[X] I agree to follow this project's "Code of Conduct".

I would like to work on this project. please assign it to me.

@Rakesh9100 this issue can be assigned

@Rakesh9100 Sir, please assign this issue to me under GSSoC'24.
Thank You!

Pls complete your assigned issues first @TBorundia

Pls complete your assigned issues first @TBorundia

@Rakesh9100 Sir,
I have completed my previous task and it also approved by the @Nihal4777.
Now can you assign me this issue so that I can start working on it.

@Rakesh9100 Sir, you have merged my previous task.
So can I start working on this?