[v1.0-beta] render message attachment

render such message:
        {
            "_id": "A2XbEfnWiDbPg5peg",
            "msg": "### Private Rocket.Chat server in 2 minutes, on a $30 Raspberry Pi\nFrom Ubuntu 16.04 classic for [Pi2](https://www.element14.com/community/community/raspberry-pi/raspberrypi2) command,  issue command `snap install rocketchat-server`. Your server will be up and running at `http://server-ip:3000` in 2 minutes. See [more info](https://github.com/RocketChat/Rocket.Chat.RaspberryPi).",
            "rid": "GENERAL",
            "ts": {
                "$date":<PHONE_NUMBER>832
            },
            "u": {
                "_id": "t49agvvB2iWzy28Hr",
                "username": "singli"
            },
            "urls": [{
                "url": "https://www.element14.com/community/community/raspberry-pi/raspberrypi2",
                "meta": {
                    "pageTitle": "New Raspberry Pi 2 Model B 1GB | element14 Community",
                    "ogUrl": "https://www.element14.com/community/community/raspberry-pi/raspberrypi2",
                    "title": "New Raspberry Pi 2 Model B 1GB",
                    "ogTitle": "New Raspberry Pi 2 Model B 1GB",
                    "ogImage": "https://www.element14.com/community/community/image/2583/2.png",
                    "description": "Visit the 'Community: Raspberry Pi 2' group on element14.com.  The Raspberry Pi 2 Model B is the latest single board computer to be released by the Raspberry Pi Foundation. It is the highest spec variant of the Raspberry Pi, perfect for learning, coding, and creating your own projects.",
                    "ogDescription": "Visit the 'Community: Raspberry Pi 2' group on element14.com.  The Raspberry Pi 2 Model B is the latest single board computer to be released by the Raspberry Pi Foundation. It is the highest spec variant of the Raspberry Pi, perfect for learning, coding, and creating your own projects.",
                    "fbAdmins": "100008324259487"
                },
                "headers": {
                    "contentType": "text/html;charset=UTF-8",
                    "contentLength": "40722"
                },
                "parsedUrl": {
                    "host": "www.element14.com",
                    "hash": null,
                    "pathname": "/community/community/raspberry-pi/raspberrypi2",
                    "protocol": "https:",
                    "port": null,
                    "query": null,
                    "search": null,
                    "hostname": "www.element14.com"
                }
            }, {
                "url": "http://server-ip:3000"
            }, {
                "url": "https://github.com/RocketChat/Rocket.Chat.RaspberryPi",
                "meta": {
                    "pageTitle": "GitHub - RocketChat/Rocket.Chat.RaspberryPi: Run a private social network on your Pi for iPhone and Android devices !",
                    "fbAppId": "1401488693436528",
                    "description": "Rocket.Chat.RaspberryPi - Run a private social network on your Pi for iPhone and Android devices !",
                    "twitterImageSrc": "https://avatars1.githubusercontent.com/u/12508788?v=3&s=400",
                    "twitterSite": "@github",
                    "twitterCard": "summary",
                    "twitterTitle": "RocketChat/Rocket.Chat.RaspberryPi",
                    "twitterDescription": "Rocket.Chat.RaspberryPi - Run a private social network on your Pi for iPhone and Android devices !",
                    "ogImage": "https://avatars1.githubusercontent.com/u/12508788?v=3&s=400",
                    "ogSiteName": "GitHub",
                    "ogType": "object",
                    "ogTitle": "RocketChat/Rocket.Chat.RaspberryPi",
                    "ogUrl": "https://github.com/RocketChat/Rocket.Chat.RaspberryPi",
                    "ogDescription": "Rocket.Chat.RaspberryPi - Run a private social network on your Pi for iPhone and Android devices !"
                },
                "headers": {
                    "contentType": "text/html; charset=utf-8"
                },
                "parsedUrl": {
                    "host": "github.com",
                    "hash": null,
                    "pathname": "/RocketChat/Rocket.Chat.RaspberryPi",
                    "protocol": "https:",
                    "port": null,
                    "query": null,
                    "search": null,
                    "hostname": "github.com"
                }
            }],
            "_updatedAt": {
                "$date":<PHONE_NUMBER>083
            }
        }

as

done 1a19e91


Add Blazor support in the instant-meilisearch

First of all, thank you for this amazing search tool.
My question is, is Blazor going to be supported like meilisearch-blazor ?
Thank you.

@curquiza  thank you :)

Hi @ahmetkocadogan unfortunately, we do not have the resources to work on your suggestion yet!
You can check our current roadmap here: https://github.com/meilisearch/integration-guides/blob/main/roadmap/2022.md
And if you want to make an official suggestion add it here: https://roadmap.meilisearch.com
But can you make my mind clearer regarding this? I only know Blazor from the news and didn't check that yet. Currently, we maintain the .NET SDK to integrate the .net apps with Meilisearch in the server. So are you proposing an instant-meilisearch version for Blazor?

Hi @brunoocasali
Thanks for fast response.
Yes, what i'm asking is instant-meilisearch version for Blazor, like this https://github.com/meilisearch/meilisearch-angular

@ahmetkocadogan thanks!
Can you help me understand more how we could make that conversion? Microsoft or the community has some guides regarding this kind of situation? I need to understand if this "conversion" is something feasible from our side or not.
And could you give me some numbers regarding the possible market share, the community size, etc. of this new integration?
Btw, we have some integrations that are maintained by the community https://github.com/meilisearch/awesome-meilisearch/#community-integrations if you want you could start it, and we can help you along the way!

@brunoocasali hello.
Blazor website is here : https://dotnet.microsoft.com/en-us/apps/aspnet/web-apps/blazor
Blazor lets .NET developers use C# instead of javascript. What i like about it, it makes web development easier and more accessible to .NET developers. I personally never liked to work with javascript, but thanks to Blazor, now i don't have to, at least most of the time.
By asking Blazor support for instant search, what i am asking is, is it in your plans or can be in your plans to add Blazor version of instant-search.
I don't know how to give you the numbers, market share, community size etc. but i guess we can look at the repo it lives and issue counts.
I'll take a deeper look into meilisearch instant-search repo's and try to evaluate that if it is possible or worth it or not. Maybe i can start to code it and hopefully make it work.

First of all, thank you for your hard work. We know that the meilisearch-team is certainly still very busy, but is there any news regarding this? I think many Blazor/C# developers would love to see meilisearch-blazor. Blazor and Meili are both great tools that we would like to combine to build great web apps.
Thank you.

Hi @maxibyte, how are you?
Unfortunately is improbable the @meilisearch/integration-team will work on this integration in the following quarters. We are now focusing on other stacks we would like to partner with. Blazor is also in our plans but only far away in the future due to our internal team size.
I would like to encourage you or anyone else to work on this integration personally, and we will be happy to help across the path :)
Thanks a lot for using Meilisearch! 🚀

I'm cleaning this repo, and unfortunately, my last message is still relevant, we're a small team and don't have much time to work on new and shiny integrations. I would love to see the community stepping in and making an integration for this!
I'll close this issue :)


Handle temporary string xml attributes

Example on handling temp xml string attributes differently

@robbr48  This "fixes" causality attribute handling, but there are other attributes being read similarly (but differently) that should be looked over.
I realized that these strings are temporary and only used to select which enum value (or similar) to set. Maybe instead of duplicating the strings (and having to deal with freeing them) we could make an additional ezxml get attribute function that returns the const char* (or null ptr) to the attribute string, and use that directly for comparison instead.

I'm not really sure what problem this fixes? If parseStringAttributeEzXml fails, the string reference is not modified anyway. The cleanest solution would perhaps be to supply a default value parameter? But C does not allow default values  for parameters, so then we would always have to use it everywhere.

The problem is that if parseStringAttributeEzXml fails, causality will point to a string not allocated on the heap, and then we can not free it. But if it succeeds, then it will instead point to a heap allocated (I assume _strdup is heap allocated) and we must free it to avoid a leak.
My "fix" (I dont like it) is to always ensure _strdup has been called, so that we always need to free it. Instead of having a situation where we must have logic that decides if we should free it or not.
But in this particular case where we do not even want to keep the causality string, why do we even need to _strdupe it?
We could instead "get it" from the XML representation as a const char* pointing into the XML representation and use it read only. But then we need a slightly different getStringAttributeEzXml function.
In fact, the more I think about it, Imaybe we should replace the parseStringAttributeEzXml function with getStringAttributeEzXml. Because the XML is already a string. Then call _strdup manually in those cases where it is needed, where we want to keep a copy of the string.

I made a new attempt at a slightly better solution.
Set the default value first, and only overwrite based on the string attribute if parseStringAttributeEzXml succeeds.
I check the const char* but the return value from the function could be used instead.

Ok, I see the problem and you solution is reasonable. You have a good point that we don't need to duplicate the string if we don't want to keep it. I want all the XML utility functions to be harmonized though, so if we change one we should change all (or add separate functions for different behaviour).

I guess my updated solution is a reasonable middle ground, then we do not need to add additional xml parsing functions.
I will look over the other attributes being parsed, and solve it in the same way.

@robbr48 Ready for review, there are some TODOs in the code that I need input on. Essentially missing default values or handling about unknown values. Also look extra closely on the "clocks" handling, I am not sure if it still works as it is supposed to. The changes are mostly in the start and end of each changed code block.

There were too many conflicts and much work has already been covered by other commits, so I recreated what was left in this PR as #44.


Created Rollup SUmmary with DRS is not working correctly and Salesforce application crashes

Hi guys,
I installed DRS in my Salesforce developer application.
I then created a Rollup Summary field on Account this way:

By testing this, I created an opportunity with CloseDate=30/01/2018 and Amount=500. When I check if this was summarized on the Total_Amount__c on Account, this is not being summarized.
Another point: my application became slower and crashes after installation of the last update of your software.
I would appreciate if someone could help me here.

Can please somebody help me here?

So I just tried to reproduce this and could not. Below is my rollup definition (using the preferred Manage Rollup Summaries tab). One thing to note is that unless the Amount field or CloseDate field changes your rollups will not be recalculated. So when 2019 comes along, you will either have to click Calculate manually yourself or change your rollup schedule to the Full Recalculate mode described here. Regarding performance you do not say what version you where on and what version you have upgraded to, so it's hard to help. Some other factors to consider would be other users creating rollups and/or more data in the system.

Thanks afawcett for your response. I see. The version I had installed was 2.10, the latest vesrion according to this site:
https://github.com/afawcett/declarative-lookup-rollup-summaries

No problem, glad you got sorted!


help my with gui

I would like it to be an input animation e.g. from alpha 0.1 to 1
https://youtu.be/POk80-4zM2g?t=43

do research into how imgui set colors
youll figure it out quickly

Wouldn't it be easier to break into Steam's database and give yourself the Desired Skin?
Close this issue soon.

const int fade_factor = static_cast<int>(1.0f / 0.15f * functions.get_frametime() * 255);
alpha = std::clamp(alpha + (menu_opened ? fade_factor : -fade_factor), 0, 255);

credits: zxvnme


Move edit value from DataCell to DataSheet

When a DataCell is in edit mode and the underlying data changes, the
edited value was lost since the value was local to DataCell, which was
recreated. This commit fixes the problem by moving the edit value to the
parent DataSheet component.

Coverage increased (+0.1%) to 92.128% when pulling 0ad0afbf9d52fec49cb84a988c75405c91b1accc on FraunhoferChalmersCentre:non-volatile-edit into d95e4cc2a84947b533de5fd28b10d80dbc3ee52b on nadbm:master.

@jhagmar  thank you for the PR, will review this asap

@jhagmar I know this was a while,  but I'm having to revert this PR due to the following issues #230 and #218. If you recall exactly how to reproduce this issue I can look into a different way to fix this


difftools: Note that difftools are not a blocker

Review: general check.  Is this what we want to say?

Good note. Thanks!


Modeller 4.11.1 - SELECT Field, Value loss focus

Describe the Bug
Modeler 4.11.1  Form with SELECT
Values cant be set or typ in complete flow because the field value loose the focus after each typ of character or string.

Steps to Reproduce
Just make a Form with a new Select Field and type inside the values of each values.
On each typing the field loose the focus. And U have to click inside again to fill the field to the end.
Expected Behavior
typing without loose the field focus.
Environment

OS: Windows 10
Camunda Modeler Version: 4.11.1
Execution Platform: N/A
Installed plug-ins: N/A

Could you use the existing issue template? Adding details on the Modeler version, execution platform and so forth?
Could you please provide complete steps to reproduce your issue, including an example diagram?

Thanks for the report. I can reproduce the issue.

Added this to our improve forms journey epic.
Thanks for reporting!

This is a duplicate of https://github.com/camunda/camunda-modeler/issues/2603. Therefore I'll close it. 👍🏻


task: Upgrade to Patternfly v5

Let me know what you think about this PR. No hurries in having it merge before a correct review :)

Know issue: Select input loses the border once focus is moved https://github.com/patternfly/patternfly-react/issues/9538

@carlosthe19916 Thank you very much for this! We have this incoming alpha release we are all working on. As soon as I am out of that, I will give this a test, followed by merging it. Thank you again!

@carlosthe19916 I finally got around to look at this PR as I got some time from the release tasks. I rebased the PR with main, and tested it. The changes are looking good and we should be able to merge. Thank you again for your work!


duplicate sheets

Capability to duplicate a sheet, like PowerShell/excel's $wb.sheets.item(1).copy($wb.sheets.item(2)). Perhaps something like:
// sheet at index 1 already exists...
xlsx.NewSheet(2, "sheet2")
xlsx.CopySheet(1, 2)

@xuri in my case, copy sheet didn't work. I ran this using master branch on a526e9040491
n := "1"
last := f.NewSheet(n)
err := f.CopySheet(1, last)

above code will return error about wrong index. The actual excel only contain 1 sheet, but the value last returns 3.
when I ran this
n := "1"
last := f.NewSheet(n)
err := f.CopySheet(1, 2)

that will not return any error, but the sheets is not copied into newly created sheet. I will send the excel file via email if it have to.

Hi @muhrifqii, thanks for your feedback, you can send me the file with credential data masking. xuri.me[at]gmail.com

Hi @muhrifqii, I have fixed this issue. Please try to upgrade the library with the master branch code, and this bug fix will be published in the next release version. Also, we need to get the source worksheet index before copy to the target worksheet:
package main

import "github.com/360EntSecGroup-Skylar/excelize"

func main() {
	n := "1"
	f, err := excelize.OpenFile("blank.xlsx")
	if err != nil {
		panic(err)
	}
	last := f.NewSheet(n)
	if err := f.CopySheet(f.GetSheetIndex("Sheet2"), last); err != nil {
		panic(err)
	}
	f.SetActiveSheet(last)
	if err := f.SaveAs("./Book1.xlsx"); err != nil {
		panic(err)
	}
}


feat(compiler): Support subqueries in the FROM clause

issue #2989, #2400 and probably others
This is without https://github.com/sqlc-dev/sqlc/pull/3220 so we can separate which test failures are caused by which PR.

I've added a fix for unnamed subqueries. That panicked at HEAD and my branch, and works now :)

@Jille, I think the reason why https://github.com/sqlc-dev/sqlc/pull/3322/commits/7d1b0c648ee30d22d698109bb2e229303043494e was required is because this test uses an active database to perform type inference for the query. All tests that use the managed-db config mutate the config to connect to the DB:
https://github.com/sqlc-dev/sqlc/blob/e8405b5bb25c7d612af244fc3958f8f3f7bdc4a0/internal/endtoend/endtoend_test.go#L121-L144
Here is where analysis is performed for columns that are not part of a table:
https://github.com/sqlc-dev/sqlc/blob/caaaacc6faaec2ab893c24328cad260b6a68c6f8/internal/engine/postgresql/analyzer/analyze.go#L272-L288
Notice that notNull is always false in this block. So, for people who do use this setup, the CI output would match this output. I believe this is the reason for the difference between your local sqlc generate output and the CI output, but I'm not sure what can be changed here to allow this analyzer to infer the nullability of this column.


Does every lab result SHC will always return a warning?

Getting this error when attempting to validate a lab result SHC:

· JWS.payload.vc.type SHOULD NOT contain 'https://smarthealth.cards#covid19', no covid immunization or observation found (only CVX codes are currently recognized by the tool) (Warning)

I think the parenthetical "only CVX codes are currently recognized by the tool" means that this warning is not applicable. Is that right? Or is there a user error here?
We may finally be approaching the point when SHC lab tests will start to see significant usage. It would be nice if this awesome tool, created by intelligent, charismatic and good looking developers, returned accurate warnings/errors for lab tests.
Isaac

I don't know about the good looking part :), but we sure want to make sure the tools are accurate! The tool will output this warning if the #covid19 label is used and no covid-related immunizations (from the CVX list) or observations (from the loinc list) are found (message isn't that clear!)
What codes are your lab result using?  Great if you can share the FHIR.

Closing this as a stale issue. Please feel free to reopen if you have an example to share with surprising behavior!


chore(main): release 0.5.9

:robot: I have created a release beep boop
0.5.9 (2022-11-29)
Features

add fastly:cache-override module (f433464)
add geo ip lookup function to fastly:geolocation (24601e5)
Add Logger constructor to "fastly:logger" module (b4818a2)
expose fastly loggers via fastly:logger module (2d0bcfe)
expose the fastly features via 'fastly:' namespaced modules (c06cd16)
move env function into fastly:env (327b344)

Bug Fixes

Add types for setTimeout, clearTimeout, setInterval, clearInterval (c1ed00c)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/fastly/js-compute-runtime/releases/tag/v0.5.9 :sunflower:


AVX512 not enabled with clang-8.0

See https://github.com/pitrou/arrow/runs/1972721611?check_suite_focus=true#step:8:900
In file included from /arrow/cpp/src/arrow/util/bpacking_avx512.cc:19:
/arrow/cpp/src/arrow/util/bpacking_simd512_generated.h:47:14: error: implicit instantiation of undefined template 'xsimd::batch<unsigned int, 16>'
  simd_batch masks(mask);
             ^
xsimd_ep/src/xsimd_ep-install/include/xsimd/types/xsimd_base.hpp:35:11: note: template is declared here
    class batch;
          ^

Yet the compilation command has the flags -march=skylake-avx512 -mbmi2 -mavx512f -mavx512cd -mavx512vl -mavx512dq -mavx512bw. Does xsimd expect more flags when detecting AVX512?

Here is a similar issue on macOS with AppleClang <IP_ADDRESS>00032:
https://github.com/pitrou/arrow/runs/1972721219?check_suite_focus=true#step:5:570

Ok, the explanation is that, while __AVX512F__  is defined, __GNUC__ is also defined by clang to a value smaller than 6.

@JohanMabille we may want to do the same trick to detect clang version as in xtensor here.

This simple fix seems to compile fine here (I don't have AVX512 on the CPU to check that runtime works):
// AVX512 instructions are supported starting with gcc 6
// see https://www.gnu.org/software/gcc/gcc-6/changes.html
#if !defined(XSIMD_X86_INSTR_SET) && (defined(__AVX512__) || defined(__KNCNI__) || defined(__AVX512F__)\
    && (defined(__clang__) || !defined(__GNUC__) || __GNUC__ >= 6))
    #define XSIMD_X86_INSTR_SET XSIMD_X86_AVX512_VERSION

I don't have AVX512 on the CPU to check that runtime works

Yeah, we have an i9 hanging around. We should be able to test what works there.

@pitrou FYI 7.5.0 was released by @JohanMabille today, which includes all of the recent fixes with respect to AVX512, saturated arithmetics, etc.

Thank for the heads up. We indeed noticed that all of our issues were fixed!


Add guidance re: the Red Hat Hybrid Cloud Console

Added:

suggestion to use "the" preceding Red Hat Hybrid Cloud Console or Hybrid Cloud Console
suggestions to properly refer to the Red Hat Hybrid Cloud Console
additional suggested first mention rule

Note also the rule doesn't work with Capitalized "The"

Closing in favour of https://github.com/redhat-documentation/vale-at-red-hat/pull/787


kubernetes.Orphaned() should not write to stdout

I understand that we don't want to leave the user without any feedback during long running operations in Orphaned(). However, when I call tanka.Diff() as a library function from another project I get unwanted output that I can't get rid of. If seems wrong to have functions produce output when they can be imported and called from other projects.
I propose adding an option (e.g. stdoutInfo) to Orphaned() and Diff() that could be used to control if there will be info printed out to stdout.

Lets set some expectations first. Our package design permits the cmd/tk (cli handling) and pkg/tanka (glue code) packages to print to stdout, as they hold the implementation of Tanka as a CLI tool.
Consumers are expected to either use pkg/tanka as long as it fits their workflow. Think of this like the Go equivalent of using the tk binary in shell scripts. If that is not suitable, the expectation is to use the underlying packages, which in your case would be pkg/kubernetes.
Having that said, pkg/kubernetes is the thing that actually prints to stdout here:
https://github.com/grafana/tanka/blob/315bb096a82154f5c113135000aea95ae56eef2d/pkg/kubernetes/apply.go#L39
https://github.com/grafana/tanka/blob/315bb096a82154f5c113135000aea95ae56eef2d/pkg/kubernetes/apply.go#L61
First of all, this really should be stderr, also these really are statements from the phase where prune was highly experimental and we wanted to closely watch timings for performance reasons.
Going forward, we could either remove these statements or somehow pass a log.Logger / io.Writer / logging interface as part of the *kubernetes.Kubernetes type. wdyt?

I agree that pkg/tanka printing to stdout makes sense.
I don't think it's reasonable to remove the info statement. The operation can easily take a minute to complete and it doesn't feel right to leave users without any feedback for that long.
Passing a logger to *kubernetes.Kubernetes seems like the right solution.
The question is if we have any other long running operations or if we expect to have them in the future. If not then maybe we could just pass the logger to Orphaned(). Not the cleanest solution but maybe it's better than changing how everything in kubernetes package is called.
Disclaimer: I have no idea what is the proper way to log from imported packages

For some reason tk prune doesn't take as much time as it did in the past for me.
In the past,  fetching previously created resources took up to 1m40s.
I suspect that selecting resources based on labels involved iterating over all resources in the cluster.
Now, with the same cluster I get at most fetching previously created resources .. done 20.308331916s.
I don't know what changed exactly. I can/will investigate.
But I'm wondering what times are other people seeing with tk prune.
If nobody is getting times that are close to a minute then maybe we could drop the print statements.
What do you think?
Any idea what influences tk prune running times?

not stale, still an issue

Explanation why I care about this getting resolved:
We use tanka to deploy things. We apply changes manually and we have written some tanka-based monitoring that ensures that tanka environments don't stay out of sync with git for too long. We use json as our log format and the stdout messages coming from Orphaned() make the logs of the monitoring service incredibly messy.

Looks like this was already resolved by introducing zerolog. Please reopen if this is not correct 🙂


Create proxy and websocket configuration configmap for wrongsecrets-balancer

Given we will have to upgrade the webtop often, we need to be able to easily adjust the requierd proxying in the wrongsecrets-balancer. That is why we need a configmap that contains a mapping for:

which urls should end up to a websocket upgrade to which service
which urls need to be proxied to which address

so, something like:

websocket

servicename1:8080:
incomingurl1
incomingurl2
incomingurl3
serviname2:3000
incomingurl4
incomingurl5

proxy

servicename1:8080:
incomingurl6
incomingurl7
servicename2:3000
incomingurl8withwildcard
servicename3(CTFD)
incomingurl9
incomingurl10
servicename4(grafana)
incomingurl10

the deployment should mount the configmap in so that the balancer its code should be able to read it. both the deployment and balancer code need to be adjusted.
https://github.com/OWASP/wrongsecrets-ctf-party/blob/main/wrongsecrets-balancer/src/proxy/proxy.js#L106 should no longer be hardcoded but usse a configmap to load like above

/assign
plz

It’s yours now! Welcome aboard!


Fixed context resource leak in DialTimeout

FYI @myleshorton @joesis
One always needs to call the cancel function returned from context.WithTimeout (or context.WithDeadline).

LGTM. Good catch @oxtoacart!


error catalog/categories/create

Thanks!

Hi @marcelowu
Check the collation type of each table, and make sure that they have the same collation.
After that check also the collation type of each table field that you have use in operation.
I had encountered the same error, and that tricks works on me.
You either need to add COLLATE to the WHERE clause,
or add it to the IN parameter definition,
or alter the field itself:
ALTER TABLE tableA CHARACTER SET utf8 COLLATE utf8_unicode_ci;
as the default collation for stored procedure parameters is utf8_general_ci and you can't mix collations.
Unless you need to sort data in Unicode order, I would suggest altering all your tables to use utf8_general_ci collation.
Thanks

ALTER DATABASE bagisto CHARACTER SET utf8 COLLATE utf8_unicode_ci;

does not work

is ok, Thanks!
CREATE DATABASE bagisto CHARACTER SET utf8 COLLATE utf8_unicode_ci;

I still have the same problem.
SQLSTATE[HY000]: General error: 1267 Illegal mix of collations (utf8mb4_unicode_ci,IMPLICIT) and (utf8mb4_0900_ai_ci,IMPLICIT) for operation '=' (SQL: update categories set _lft = case when _lft >= 14 then _lft`+2 else `_lft end, _rgt = case when _rgt >= 14 then _rgt`+2 else `_rgt end where (`_lft` >= 14 or _rgt >= 14))

thank you it worked for I just created a table with utf8_unicode_ci colllection

is ok, Thanks!
CREATE DATABASE bagisto CHARACTER SET utf8 COLLATE utf8_unicode_ci;

it is worked for me

is ok, Thanks!
CREATE DATABASE bagisto CHARACTER SET utf8 COLLATE utf8_unicode_ci;

it is worked for me


Create issue template to try to reduce duplicates

New issues will automatically be pre-populated with the contents of this file. This should hopefully cut down the volume of issues that we're seeing with the same bugs.

Add https://github.com/elm-lang/elm-compiler/issues/1214? It's also something that trips up people a lot, because they think that (type variables in) inner annotations mean something that they actually don't mean.

Done.

@evancz, having this template added would probably help, a lot, the people who do the looking at new (and often redundant) issues reported in this repository almost daily. That potential good effect would be active immediately after addition of the template.

https://github.com/elm-lang/elm-compiler/issues/1192 is supposed to be fixed now.

Done. Also these can be merged with GitHub's new squashing feature 🎉

If this was ever to get merged, it should also mention the error message catalog.

Nice, really like the text! Will merge this in by hand.

Did some things in #1437


Mm 29656

Summary
This PR is a replacement for #6942. Creating a new PR since the old one came from a fork and is stale. The original PR willbe closed after the creation of this. Dicsussions and comments will not be ported over, so please reference comments from the original PR if needed.
Ticket Link
Fixes MM-29656
Related Pull Requests
Original PR: #6942

/update-branch

Error trying to update the PR.
Please do it manually.

@michelengelen how do I test this to get the in-product notices to appear so I can review?

Maybe @hmhealey can help. I would like to avoid hard-coding something that needs to be removed afterwards!

Apparently it is not possible, so I will add a hard-coded part for now which I will remove before merging.

@michelengelen @matthewbirtch maybe a screenshot would be enough for UX review in this case?

Thanks for the PR!
@michelengelen @matthewbirtch maybe a screenshot would be enough for UX review in this case?

yep, that's fine with me if you want to provide screenshots @michelengelen

@matthewbirtch here are some screenshots:
Primary Button

normal
hover
active
focus

Secondary Button

normal
hover
active
focus

Tertiary Button

normal
hover
active
focus

/update-branch


Update to latest frontends

Been a few weeks since an update with the bundled frontends. Updating to latest main from penumbra-zone/web.

This is great, however we also want to include changes in https://github.com/penumbra-zone/web/pull/1533, so we'll need another shortly.


Keldagrim Upgrade

Within Keldagrim and the Blast Furnace it does the following:

Sets path to gravel
Sets the ground to Stone
Sets dirt areas to Dirt
Define Boat Deck as wood
Set interiors of some buildings to Falador Path
Set interiors of some buildings to carpet
Defines stone object materials
Define metal object materials
Define walls as stone
Removes baked in lighting on lamps

Looks great well done :) <3

Agree with Mark! Though is it not possible to replace the flat water here with 117hd water?

Agree with Mark! Though is it not possible to replace the flat water here with 117hd water?

This is the default water (particularly for underground areas), so we should probably just improve our default water I'd say.


Following contraction, backwards rewrite should remove symmetric cospans

Nick, just to record what we discussed on the call: following contraction, the backwards rewrite should not always be the identity, but should be the rewrite that removes all symmetric cospans (i.e. those for which the forward and backward rewrites are the same.)

Fixed


Tracing: added missing sampler types

[x] I added CHANGELOG entry for this change.
[ ] Change is not relevant to the end user.

Changes
Added ParentBasedAlwaysSample,ParentBasedNeverSample,ParentBasedTraceIDRatioBased samples and also removed the wrapping of ParentBased from existing AlwaysSample,NeverSample and TraceIDRatioBasedSample
Fixes #7230

Verification

@yeya24 I have fixed the changelog conflict


How to allow preview adding files after one or more uploads

I'm working uploading multiple files one by one on file select. But I want that if user forgot upload some files, he can add more and the previous data and previews do not disappear. How can I do it?

me too looking for this. did you found ?please post me if you have done

No, I didn't. The only solution is uploading files on select.


Can't install on Blender version 3.1.1

The addon can't be activated on 3.1.1 Churns out the following errors:
Modules Installed (RenderManForBlender-main) from 'C:\Users\ajlan\Downloads\RenderManForBlender-main.zip' into 'C:\Users\ajlan\AppData\Roaming\Blender Foundation\Blender\3.3\scripts\addons'
[DEBUG] (MainThread) RenderManForBlender-main.rfb_logger init_log_level: logger initialized
[DEBUG] (MainThread) RenderManForBlender-main.rfb_logger init_log_level:    |_ logger: 0
Exception in module register(): C:\Users\ajlan\AppData\Roaming\Blender Foundation\Blender\3.3\scripts\addons\RenderManForBlender-main_init_.py
Traceback (most recent call last):
File "C:\Program Files\Pixar\RenderManProServer-24.4\bin\rman_utils\rman_assets\common\shading_node.py", line 14, in
import oslquery as oslq
File "C:\Program Files\Pixar\RenderManProServer-24.4\lib\python3.9\Lib\site-packages\oslquery_init_.py", line 42, in
from oslquery._oslquery import *
ImportError: DLL load failed while importing _oslquery: The specified module could not be found.
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "C:\Program Files\Blender Foundation\Blender 3.3\3.3\scripts\modules\addon_utils.py", line 369, in enable
mod.register()
File "C:\Users\ajlan\AppData\Roaming\Blender Foundation\Blender\3.3\scripts\addons\RenderManForBlender-main_init_.py", line 313, in register
load_addon()
File "C:\Users\ajlan\AppData\Roaming\Blender Foundation\Blender\3.3\scripts\addons\RenderManForBlender-main_init_.py", line 277, in load_addon
from . import rman_presets
File "C:\Users\ajlan\AppData\Roaming\Blender Foundation\Blender\3.3\scripts\addons\RenderManForBlender-main\rman_presets_init_.py", line 27, in
from . import ui
File "C:\Users\ajlan\AppData\Roaming\Blender Foundation\Blender\3.3\scripts\addons\RenderManForBlender-main\rman_presets\ui.py", line 40, in
from . import rmanAssetsBlender as rab
File "C:\Users\ajlan\AppData\Roaming\Blender Foundation\Blender\3.3\scripts\addons\RenderManForBlender-main\rman_presets\rmanAssetsBlender.py", line 25, in
from rman_utils.rman_assets import lib as ral
File "C:\Program Files\Pixar\RenderManProServer-24.4\bin\rman_utils\rman_assets\lib.py", line 50, in
import rman_utils.rman_assets.core as ra
File "C:\Program Files\Pixar\RenderManProServer-24.4\bin\rman_utils\rman_assets\core.py", line 59, in
from rman_utils.rman_assets.common.shading_node import RmanShadingNode  # pylint: disable=unused-import
File "C:\Program Files\Pixar\RenderManProServer-24.4\bin\rman_utils\rman_assets\common\shading_node.py", line 16, in
import oslquery as oslq
File "C:\Program Files\Pixar\RenderManProServer-24.4\lib\python3.9\Lib\site-packages\oslquery_init_.py", line 42, in
from oslquery._oslquery import *
ImportError: DLL load failed while importing _oslquery: The specified module could not be found.****

We currently do not support Blender 3.3.x. The latest version we can support currently is 3.0.x.


[BUG] Incorrect fflags Set When Using fdiv Instruction to Divide by Infinity

Bug Description
In the CVA6 implementation, when the fdiv.s instruction is used to divide by a single-precision floating-point number representing positive infinity (0x7F800000), the Overflow (OF) flag in fflags is erroneously set. The value of fflags becomes 0x4, indicating an overflow error. However, in the Spike simulator, the fflags value is 0x0. According to the IEEE 754 standard, an Overflow (OF) condition should not occur in this case.
Steps to Reproduce:

Initialize ft4 to 0x00000000 and ft6 to 0x7F800000 (infinity).
Execute the instruction: fdiv.s ft1, ft4, ft6.
Observe the value of fflags.

The log from CVA6 is as follows:
core   0: 0x0000000080002018 (0x186270d3) fdiv.s  ft1, ft4, ft6
3 0x0000000080002018 (0x186270d3) f 1 0xffffffff00000000
core   0: 0x000000008000201c (0x001023f3) csrrs   t2, fflags, zero
3 0x000000008000201c (0x001023f3) x 7 0x0000000000000004

The log from Spike is as follows:
core   0: 0x0000000080002018 (0x186270d3) fdiv.s  ft1, ft4, ft6
core   0: 3 0x0000000080002018 (0x186270d3) f1  0xffffffff00000000
core   0: 0x000000008000201c (0x001023f3) csrrs   t2, fflags, zero
core   0: 3 0x000000008000201c (0x001023f3) x7  0x0000000000000000

See:https://github.com/openhwgroup/cva6/issues/2111

Same answer than #110


[BUG] - Overlay position not updating with multiple monitors

Describe the bug
After changing the multi-monitor configuration, Mercury Trade does not accurately update its position if it was originally positioned 'off-screen'.
To Reproduce

Position overlay on a secondary monitor on which PoE is not open.
Change the multi-monitor configuration such that the overlay would be positioned on an inactive monitor (i.e Win+P Extend -> PC Screen Only).
Revert the multi-monitor configuration such that the overlay would now occupy a valid space once again.

Expected behavior
After performing step 2, the overlay correctly moves to a different monitor as the one it was occupying is no longer available, but it does not return to its original position without reloading the program after performing step 3, instead remaining on the monitor it moved to in step 2.
Version
Bug is present on any renderer setting on the Windows 10 version of the game, presumably on other platforms too.

This happens to me too, seems to occur when i turn off monitors but MT is still running

Same problem here. I just change my screen to a 21:9 one, and MT keeps showing notifs & task bar on my old screen. I have to "Restore default location" every time I shutdown my monitor.


As a user, I can redo the commands I undid

so that I can have the flexibility to change my mind when entering commands.

Done


Debugbar resource urls does does not work

I have installed the latest release of Winter 1.2 and Debugbar plugin.
However, the stylesheets and javascript endpoints are reported as not found although they are shown in the route:list !

@khalidchawtany  I found a solution but not sure if it's the best one. At least it works for me.
I commented this line in Plugin.php
App::register(\Winter\Debugbar\Classes\ServiceProvider::class);
and instead added the following to register() method:
$this->app->register(\Winter\Debugbar\Classes\ServiceProvider::class);

I added the routes manually in routes.php and it works. However, it is expected to work without hacks. I didn’t know how to do a proper fix else I would have sent a pr.

@bennothommo Winter 1.2.0 release states

Added two new events (system.beforeRoute and system.route) that fire before and after the system route registration respectively and moved the registration of the Backend and CMS module routes to be after the system route registration. The CMS module's routes should now always be the last routes registered regardless of what happens.

I wonder if this is related because when debugging {slug?} still came before _debugbar/* routes.


Issues about the installation of dependence

Hi developer,
A very exciting work to develop this software to bin the phage genomes!
Unfortunately, I meet some problems in starting to install the software.
It seems like the Prerequisites you provided are conflicting and can not be installed simultaneously.
The errors log is as follows:
 (base) [mcs@mcs1 soft]$ conda create -n phamb snakemake pygraphviz python=3.8 cython scikit-learn==0.21.3
Collecting package metadata (current_repodata.json): done
Solving environment: failed with repodata from current_repodata.json, will retry with next repodata source.
Collecting package metadata (repodata.json): done
Solving environment: -
Found conflicts! Looking for incompatible packages.                                                                                failed                                                                                /

UnsatisfiableError: The following specifications were found to be incompatible with each other:

Output in format: Requested package -> Available versions

Package pygraphviz conflicts for:
pygraphviz
snakemake -> pygraphviz[version='>=1.5']

Package system conflicts for:
pygraphviz -> python=3.4 -> system==5.8
snakemake -> python=3.4 -> system==5.8
cython -> python[version='>=2.7,<2.8.0a0'] -> system==5.8

Package _libgcc_mutex conflicts for:
scikit-learn==0.21.3 -> libgcc-ng[version='>=7.3.0'] -> _libgcc_mutex[version='*|0.1',build=main]
cython -> libgcc-ng[version='>=7.5.0'] -> _libgcc_mutex[version='*|0.1',build=main]
pygraphviz -> libgcc-ng[version='>=7.5.0'] -> _libgcc_mutex[version='*|0.1',build=main]
python=3.8 -> libgcc-ng[version='>=7.5.0'] -> _libgcc_mutex[version='*|0.1',build=main]

Package setuptools conflicts for:
scikit-learn==0.21.3 -> joblib[version='>=0.11'] -> setuptools
snakemake -> dropbox[version='>=7.2.1'] -> setuptools
cython -> setuptools
python=3.8 -> pip -> setuptools

Package ca-certificates conflicts for:
cython -> python[version='>=2.7,<2.8.0a0'] -> ca-certificates
python=3.8 -> openssl[version='>=1.1.1l,<1.1.2a'] -> ca-certificates
pygraphviz -> python=2.7 -> ca-certificates

Package numpy conflicts for:
snakemake -> networkx[version='>=2.0'] -> numpy[version='1.10.*|1.11.*|1.12.*|1.13.*|>=1.11.3,<2.0a0|>=1.12.1,<2.0a0|>=1.13.3,<2.0a0|>=1.14.6,<2.0a0|>=1.15.4,<2.0a0|>=1.16.6,<2.0a0|>=1.19|>=1.19.2,<2.0a0|>=1.21.2,<2.0a0|>=1.20.3,<2.0a0|>=1.20.2,<2.0a0|>=1.9.3,<2.0a0|>=1.9|>=1.12|1.9.*|1.8.*|1.7.*|1.6.*']
scikit-learn==0.21.3 -> numpy[version='>=1.11.3,<2.0a0']
scikit-learn==0.21.3 -> scipy -> numpy[version='1.10.*|1.11.*|1.12.*|1.13.*|>=1.14.6,<2.0a0|>=1.16.6,<2.0a0|>=1.21.2,<2.0a0|>=1.15.1,<2.0a0|>=1.9.3,<2.0a0|1.9.*|1.8.*|1.7.*|1.6.*|1.5.*']

Package python conflicts for:
snakemake -> python[version='3.4.*|3.5.*|3.6.*|>=3.5,<3.6.0a0|>=3.6,<3.7.0a0']
scikit-learn==0.21.3 -> python[version='>=3.6,<3.7.0a0|>=3.7,<3.8.0a0']
python=3.8
scikit-learn==0.21.3 -> joblib[version='>=0.11'] -> python[version='2.6.*|2.7.*|3.5.*|3.6.*|>=2.7,<2.8.0a0|>=3.6|>=3.7|>=3.5,<3.6.0a0|>=3.10,<3.11.0a0|>=3.8,<3.9.0a0|>=3.9,<3.10.0a0|3.4.*|3.3.*']
snakemake -> boto3 -> python[version='2.6.*|2.7.*|>=2.7,<2.8.0a0|>=3.6|>=3.7,<3.8.0a0|>=3.10,<3.11.0a0|>=3.8,<3.9.0a0|>=3.9,<3.10.0a0|3.3.*|>=3.7|>=3.5|>=3.7.1,<3.8.0a0|>=3.3|>=3']
cython -> python[version='2.6.*|2.7.*|3.5.*|3.6.*|>=2.7,<2.8.0a0|>=3.10,<3.11.0a0|>=3.7,<3.8.0a0|>=3.8,<3.9.0a0|>=3.9,<3.10.0a0|>=3.6,<3.7.0a0|>=3.5,<3.6.0a0|3.4.*|3.3.*']

Package certifi conflicts for:
snakemake -> requests[version='>=2.8.1'] -> certifi[version='>=2017.4.17']
cython -> setuptools -> certifi[version='>=2016.09|>=2016.9.26']

Package bzip2 conflicts for:
pygraphviz -> python[version='>=3.10,<3.11.0a0'] -> bzip2[version='>=1.0.8,<2.0a0']
cython -> python[version='>=3.10,<3.11.0a0'] -> bzip2[version='>=1.0.8,<2.0a0']The following specifications were found to be incompatible with your system:

  - feature:/linux-64::__glibc==2.17=0
  - feature:|@/linux-64::__glibc==2.17=0
  - cython -> libgcc-ng[version='>=7.5.0'] -> __glibc[version='>=2.17']
  - python=3.8 -> libgcc-ng[version='>=7.5.0'] -> __glibc[version='>=2.17']
  - scikit-learn==0.21.3 -> libgcc-ng[version='>=7.3.0'] -> __glibc[version='>=2.17']

Your installed version is: 2.17

I also tried to install these packages one at a time and I also failed.
So, maybe the versions of these packages you provided are wrong?
Hope you can help me solve this issue!
Thank you so much!
Looking forward to your reply!
Jiulong

Hi Jiulong
Thank your for you interest in the method. I did some experimentation and experience the same conflicts in the conda installation as you present here. Seems like the required scikit version is not compatible with Python v. 3.8.
Try to give this one a go, python 3.6 should not result in the same conflicts with scikit-learn.
conda create -n phamb python=3.6 cython scikit-learn==0.21.3 snakemake pygraphviz
Let me know if this works out.
Best,
Joachim

And I check now with python=3.7  on Windows10, it does also seem to work:
conda create -c defaults -c conda-forge -c bioconda -n phamb snakemake pygraphviz python=3.7 cython scikit-learn=0.21.3

I added explicitly the list of anaconda channels in search order:  -c defaults -c conda-forge -c bioconda

@joacjo @enryH Thanks for your kindly help!
Yeah, the installation of python=3.6 can work!
conda create -n phamb python=3.6 cython scikit-learn==0.21.3 snakemake pygraphviz
It can work, while "python=3.7" can not work in my CentOS 7.6 system.
Thanks again!
By the way, to my understanding, is this phamb workflow used to identify viral MAGs after binning by Vamb to obtain miscellaneous MAGs?

As python 3.6 is out of live, I guess it will be good to see if this can be updated..

@joacjo @enryH Thanks for your kindly help! Yeah, the installation of python=3.6 can work! conda create -n phamb python=3.6 cython scikit-learn==0.21.3 snakemake pygraphviz It can work, while "python=3.7" can not work in my CentOS 7.6 system.
Thanks again!
By the way, to my understanding, is this phamb workflow used to identify viral MAGs after binning by Vamb to obtain miscellaneous MAGs?

Great it worked for you Jiulong! I will update the dependency for python 3.6, for now.
As Henry points out, python 3.6 is getting outdated, so we will have to prepare the method for a more recent version of Python.
To your question, Yes phamb workflow requires Vamb clusters.tsv and is optimised for that binner.
So you will need to run Vamb on a metagenomic dataset in order to employ this method.
Wish you all the best with your research!


feat: update the broker URL and download type

feat: update the broker URL and download type

Cancel it


trebuchet-client available via CDN for non-NPM project?

@mattkrick this library seems fantastic, good work putting it together. I've rolled my own SSE client library and would love to drop mine for yours.
However, trebuchet-clietn assumes that NPM and NodeJS are the build tools. I'm using vanilla HTML without NPM and was curious if the library could be made to work via a CDN? It's available on most major JS CDNs but importing the script generates the following:

How would one use the library in a vanilla HTML, zero-framework, no builds setting via CDN?

ah, you'll probably want to fork & build for esm or umd

Got it, @mattkrick - thanks for the quick reply. Any chance you might be interested in a sponsored project to do that? Would love to have a CDN-based library that I could use in Deno or the browser without having to do anything in Node.


Easier editing of everywhere links

I have an idea that will make it easier for everywhere to set which links are connected and which are not.
Added output to everywhere, when dragging the output link to input, the UE link is established immediately.
And add a Disconnect UE link option to the right-click menu on Input.

It's not clear to me how this would interact with the existing connection method...

It's not clear to me how this would interact with the existing connection method...

I made a gif to show how it interacts

But that link would already have been there according to the way UE currently works

But that link would already have been there according to the way UE currently works

Suppose I use everywhere? and make it not linked to any input, then I can quickly set which to be linked in this way

Seems to me to go against the whole point of UE nodes, which is that you don't have to make connections... if you are going to make and break them manually, why not just use normal links?

Seems to me to go against the whole point of UE nodes, which is that you don't have to make connections... if you are going to make and break them manually, why not just use normal links?

Maybe Disconnect UE link on the Input menu is more useful when you don't want an input to be linked.

What's the use case for this?
If you don't want UE to connect to a required input, you must want something else to connect to it. So just connect that thing.
Disconnect UE would only make sense for an optional input, which is an unusual enough situation that I doubt it justifies the increased complexity of UI and code.

What's the use case for this?
If you don't want UE to connect to a required input, you must want something else to connect to it. So just connect that thing.
Disconnect UE would only make sense for an optional input, which is an unusual enough situation that I doubt it justifies the increased complexity of UI and code.

The reason why I proposed this idea is that another idea of mine may require this function, but you are right, in general, this function is not necessary

@chrisgoringe I wanted to convert everywhere to a group node with some nodes that are commonly used, but everywhere fails when converted to a group node, and I don't know if this problem can be solved, so I talked to another custom node author ComfyUI-Easy-Use and asked him to add everywhere to the easyloader, but he thought it was a bit complicated and suggested that I mention this idea to you

This is an unwanted idea, so I'm going to close this issue and submit the bug about the group node to a new issue.


x/mobile:

What version of Go are you using (go version)?

$ go version
go version go1.16.2 darwin/amd64

Does this issue reproduce with the latest release?
I am using golang.org/x/mobile v0.0.0-20210220033013-bdb1ca9a1e08
I believe its the latest release.
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/rick/Library/Caches/go-build"
GOENV="/Users/rick/Library/Application Support/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOINSECURE=""
GOMODCACHE="/Users/rick/go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="darwin"
GOPATH="/Users/rick/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/darwin_amd64"
GOVCS=""
GOVERSION="go1.16.2"
GCCGO="gccgo"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD="/dev/null"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -arch x86_64 -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/4g/tb10nky94cxcyrgk2_7bzcch0000gn/T/go-build1988548916=/tmp/go-build -gno-record-gcc-switches -fno-common"

What did you do?

When I make an iOS framework to link into my mobile app using this command:

   go build
   gomobile bind -target=iOS

I get a framework that links and works as expected. However, the comments in the generated objective-C header are only included if I make sure all the public functions for the package are in the same file. If I put some public functions in a different file but the same golang package, the functions will be included in the generated header but not the associated comments.
Note that go doc, etc..., all work fine and show the public functions with their comments.
What did you expect to see?
It should not matter which file the public golang function is in or how many files in the package contain public functions. The comments for each function should always be included in the generated header if the function is public and has comments that go doc can see and associate with the function.
What did you see instead?
Some comments are missing if functions are in two or more files.

cc @eliasnaur @hyangah


Apache 2 license?

Looks like there is an update_license branch and a PR related to this topic (though the PR is outdated and isn't directed at main branch), but would like to confirm that this project will be Apache 2 licensed?
If not, we'll remove it from our postgres extensions directory https://pgt.dev/extensions/pg_embedding

@ryw, please see this PR from a member of the team: https://github.com/neondatabase/pg_embedding/pull/28. It is an up to date variant of the PR you mentioned.


README says sy default to sx

Actually default to 1: https://github.com/vorg/primitive-plane/blob/30abcbafbe76ce161df5f4024b07aaeab799c10f/index.js#L9

I says sx because it should. Just like primitive-cube. Bug is in code. Should be sy || sx || 1

PR updated using sx and nx as default to their y counterparts:
https://github.com/vorg/primitive-plane/blob/7b4317e3188878b1370274e175c4219671615b91/index.js#L8-L11


Cannot access the codewars website at all!!!!!!!!!

Error Message:
Web server is returning an unknown error
There is an unknown connection issue between Cloudflare and the origin web server. As a result, the web page can not be displayed.
Ray ID: 3d44cf900f8e8046
Your IP address:
Error reference number: 520
Cloudflare Location: Cape Town
URL at the time:(signing in to GitHub)
https://www.codewars.com/users/auth/github/callback?code=dd208e26375cef2fac79&state=ea4054312fe5f795934037f795c3985272010d0365397eab
cannot access the website and I went to this codewars status website: https://codewars.statuspage.io/
all systems seemed operational.

Same exact issue here.
Web server is returning an unknown error
There is an unknown connection issue between Cloudflare and the origin web server. As a result, the web page can not be displayed.
Ray ID: 3d4502fb68903e5c
Your IP address:
Error reference number: 520
Cloudflare Location: Zurich
Maybe it is related to the Git Hub sign in.
https://www.codewars.com/users/auth/github/callback?code=17cb0a816b52000b908b&state=ea4054312fe5f795934037f795c3985272010d0365397eab

@RiccardoMaltese I would have thought that but the whole website for me is down. Other websites are working fine. Even the login page says that the website is down for me. :(

I have the same problem
Bad gateway
The web server reported a bad gateway error.
Ray ID: 3d455fd84c838607
Your IP address: <IP_ADDRESS>
Error reference number: 502
Cloudflare Location: Stockholm

Is this still an issue? I notice that everyone reporting is from non-US regions. The site loads fine for me. It may have either corrected itself or perhaps its some sort of CDN/Cloudflare edge issue.

Now working. Thx

Working fine now!


Simple Calendar Webapp [GSSOC'23]

Describe the project you want to add with tech stack
A Simple Calendar webapp using HTML,CSS and Javascript which highlights/indicate today's date.
Expected behavior

display today's date,month and year.
can swipe to any month or year.

Screenshots (optional)

Additional context (optional )
Please assign this issue to me under GSSOC'23

@TusharKesarwani @pranjay-poddar @MohitGupta121 @Saurabh-kumar09 kindly check the issue I created and please assign this issue to me under GSSOC'23
I hope that you will look forward towards my request.


Add support for MPLS encapsulation

Customer requested support for MPLS encapsulated traffic.

Completed via PR #201.


The CSV parser needs to differentiate between an empty cell and an empty string.

Describe the bug
For parsing a CSV table like below,
a,b,c
1,"",2
,,4

and a table with schema
create table (a int, b varchar,c int) ...

our parser will produce rows like:
1,"",2
NULL,"",4

It works fine for non-string type (like int), produces a NULL when cell is blank.
But the parser can not distint between an empty string ("" in L2) and an blanck cell (L3).
To Reproduce
No response
Expected behavior
The empty cell should be parsed to NULL instead of an empty string.
Additional context
No response

fixed by #8709


Produce non-git env vars even if .git directory is not present

I'd like vergen to provide git env vars when there is a .git directory, but skip them when there is no .git directory.
Actual Output
When I build vergen without a .git directory present, it generates an error.
If I ignore that error, it doesn't generate any env vars at all. Even the env vars that don't depend on git are skipped.
Expected Output
Only the Git config depends on the .git directory - the other env vars can be generated without one.
So I want to be able to write a build script that works regardless of the .git directory:

if there is no .git directory, generate all the other env vars I've asked for
when there is a .git directory, generate the Git env vars, as well as the other env vars

Alternative Workaround
If that's not possible, I'd like an easy way to disable the whole Git config. (For example, an "all off" constant for each config.)

You can turn off the git feature.  In your Cargo.toml the vergen dependency line would look something like:
vergen = { version = "5", default-features = false, features = [""build", "cargo", "rustc", "si""] }

You can turn off the git feature. In your Cargo.toml the vergen dependency line would look something like:
vergen = { version = "5", default-features = false, features = [""build", "cargo", "rustc", "si""] }

I want the same build script and Cargo.toml to provide the Git variables if there is a .git directory, and the other variables if there isn't.
That way, I'm not requiring everyone who builds the code to have a .git directory, but I can still use it for debug info when it is present.
(I've edited the ticket description to make that clearer.)

Ah, I see.  This can be done in one build script today.
let config = if fs::metadata(".git").is_ok() {
   // Setup your config without git enabled
} else {
    // Setup your config with git enabled
    Config::default()
};

vergen(config)?

When writing this up I did notice that there is no good way to disable a feature programmatically, so I will be adding that.

Thanks for this change, here's what we ended up doing:
    match vergen(config) {
        Ok(_) => {}
        Err(e) => {
            eprintln!(
                "git error in vergen build script: skipping git env vars: {:?}",
                e
            );
            *config.git_mut().enabled_mut() = false;
            vergen(config).expect("non-git vergen should succeed");
        }

https://github.com/ZcashFoundation/zebra/pull/2065/commits/c7d4bac594ea51e4a08be2fe3a194448d4162dde#diff-068676a96051f451abd4ca1d1b502d1e38a01c91a614374c0b54c6db75098079R35-R45
We can't check for .git because we're in a workspace / monorepo (#30, #21). And we don't want to try to replicate vergen's checks, because that's fragile. (In the specific case we tested, it was actually peel_to_commit() that failed when there was no .git.)
So far, running vergen() twice with different configs doesn't seem to have caused any issues.


Redesign

This is actually more than just a redesign; some new features are added in this branch to make the design work:

use go get to fetch repos instead of git clone (relating to #51)
migration script to make that work with existing repos, and also to still have external links work correctly
add link to github repo, as per #67
more descriptive error handling (no more There was an error processing your request: {} as in #60 and #16)

And for the impatient, the new design looks something like this:

And repo details look like this:

Lots of changes, so best would be for everyone interested to pull this branch down and test it out for yourself. Feedback welcome!

Also need to fix the build, will look into that tomorrow...


GitHub Raffle at DDD Perth 2022 - Leave a comment to enter

Random Name Picker for GitHub prize draw at DDD Perth 2022!
:pray: First, huge shout-out to @icelam for a great and simple name picker we could fork and use for the GitHub booth!
:rocket: This site is deployed to GitHub Pages using GitHub Actions. The Actions workflow pulls entrants from commenters of a GitHub Issue.
:ticket: To enter the draw, add a comment at the bottom of this issue 👇

Check out the original README

A couple of T&C's:

Entry into this raffle will NOT constitute your consent to be contacted for anything else
We will not be adding you to our marketing database (but if you want to subscribe to our newsletter, you can do so here)
The raffle prize cannot be swapped or changed,
The winner of the prize at DDD Perth MUST be at the booth when we draw a winner, otherwise we will redraw!

Good luck!

Hi! At DDD

DDD Perth first timer

Love the stickers! 🙂

Great to be back #DDDperth

Speaking at DDD for the first time 😆

GitHub at DDD

So many nerds here #DDDPerth

Starting the day really well

Be at DDD: check,
Get a sticker: check,
Comment to enter: check!

Let's go, DDD Perth 2022

DDD ftw

At DDD! 🔥☄

DDD 😎

Love it

The Lego is mine!!

Hello DDD

Hey DDD

Heya dddperth 👍

First time here at DDD

Hi DDD !

#DDDRules

Excited to be at DDD!

Got some nice stickers.

Woot! DDD Perth

Hiya ddd

Good vibes and ready to learn more things at DDD Perth y’all 🥰😊

Vibe check DDD

Feels great to be here.

Off to a big start!

Hello DDD!
Go github!!

#DDD

Woohoo DDD!

👋 ddd

Legoooo!!!! #dddperth

Here at DDD!

Hello World

Hey GH crew at DDD!

Hello

Zac Hiew

Love seeing you all here at DDD!!!

Hi DDD

Have a great DDDDay

🚀🦄

Hi!

I am here!

Awesome stickers!

🚀

👋

So many GitHub stickers! 👌🏼

Great conference to be a part of, first time!

Hi from DDD Perth! Thanks for the stickers!

Love Github and stickers!! 🤘

Nice event DDD Perth!

Loving the sticker selection at DDD!

Hello 👋

Ayo

😎

Go DDD!!

👋

Hooray for Lego

Member of duck fan club.

I want the Lego!!!

Give lego pls

THE STICKERS ROCK!!!

Hi hi. :) ❤

Cool sticker designs and cool booth display

Hello from DDD!

👋👋👋

So Awesome to be here! Github is da bomb!

Prizes are fun! Upbeat digital!

Hello from DDD Perth

Hiii from DDD Perth!

Hi DDD

Love to get some Lego please 😊 awesome stickers

Rock on! 🤘🏼🤘🏼

Hi from DDD Perth 2022

Great to chat!

@Dddperth great chat!

Hello from DDD Perth!

Thanks for the stickers!!!

Member of duck fan club.

ducky is that you???

DDD Perth hanging with the awesome GitHub team

DDD ❤ GH

Hello DDD!

DDD Perth :D

Hi DDD Perth!

Hi from DDD!

It's great to be here at DDD Perth 😁😁

Hello!

Swastik!

Random comment!

Hi from DDDPerth! 💥

Hi! Fun idea.

Hi from DDD!

#DDDPerth

Thank you for the stickers! :3

Hello from DDD

DDD is awesome

First time at DDD Perth!

Hello from DDD Perth :)

#dddperth #github #ftw

🤖

#dddperth

First #DDDperth!

Hi to the friendly team 🤘

I like trains

Loving DDD this year 🥰

Lego is great and so is DDD

Sweet stickers

DDD

yeww

Hi DDD Perth.
Best stickers are at the github table 👍

HannahHollywood.GitHubq

Can't believe GitHub is at DDD, pretty cool

Hi from DDD Perth!

DDD

Hi #Github

At DDD!

DDD 😎

Cheers for the stickers

Great setup!!

Thanks for the stickers 👍

My daughter is gonna love the stickers.!

Hey DDD!

Omg LEGO 💜🤘

Hello [DDD] World!

Hello DDD

Loving the stickers! Thanks for helping out on a great DDD Perth!

Hello!

Hello there #dddperth

Hello DDDPERTH

First time speaker, didn't go catastrophically :)

Love the Github stickers! Keep it going for the future DDD Perth :)

Hello DDDPerth.

Great event and loved the presentations and your stand

Hello!

Good stuff 👍

Hello!

[ ]

I logged in :))))) 😊❤✨

Howdy

Hello to Github @ DDD

👋

🥑

Ddd woo!

Hi from DDD

Hello, DDD is very cool I got 4 shirts from Microsoft

DDD time

DDD Perth!

github stickers - rocking the Perth DDD!

DDD Perth

Thanks for the chat 😊

DDDone! 😏

Hello

Hey DDD

yay ddd!

A comment

It took me ages to log in on my phone but I got there eventually

👋🏽

Love it!

Hello DDD

Ddd

✨  Thank you to everyone who dropped by our booth and entered our raffle at DDD Perth! ✨
For those that missed @Damovisa and @mishmanners sessions or want to rewatch, the live stream recordings are linked below. DDD Perth is working on splitting out all the individual sessions so keep an eye out 👀

Damian Brady | End to End DevOps with GitHub

Michelle Mannering | GitHub Copilot, using AI to help you learn, code, and build

This issue will be closed and we look forward to seeing you in Perth next time!
(P.S We heard that some of you got swamped with notifications! We've factored that in for next time, but here's a handy doc if you want to adjust your settings for the future)


[9.x] Add html debug comments around components.

This proposed change adds a small comment around blade components.
The purpose is to allow for easier debugging while inspecting the code using a browser inspector so that you can navigate faster or have more information about the context of what you are looking at.
In this implementation, I added this using app.debug but we can also introduce a new config variable.
Example:

This does not work with livewire as livewire expects the first element to be a div. Closing this for now until I have new ideas for better implementation. Maybe a data-component-info="component-name" attribute that we inject into the first element.


bootstrapURLKeys dosent work

bootstrapURLKeys dosen't work when I using it with  react 16
but when I add key in html it works:
<script src="//maps.googleapis.com/maps/api/js?key=MY_KEY" async="" defer="defer" type="text/javascript"></script>
... and why there is no information in doc that I need add it? That's crucial information
            <GoogleMapReact
                bootstrapURLKeys={{
                    key: 'my key'
                }}
                defaultCenter={this.props.center}
                defaultZoom={this.props.zoom}
                height="200"
            >
                <Point lat={this.props.lat} lng={this.props.lng}  text={'Test'} />
            </GoogleMapReact>

Doesnt work for me as well :/. However, if i do add this css to the map div it will "work"
.map-container > div {
    position: initial !important;
}

Ie i remove the position fixed that the GoogleMapReact will get

Ooops, just saw this: "Make sure the container element has width and height. The map will try to fill the parent container, but if the container has no size, the map will collapse to 0 width / height."
https://github.com/istarkov/google-map-react/blob/master/API.md

I believe the issue is that if you put the key in state etc. it does not work, if you hardcode to the client it works.
Just trying to figure out how to solve this as I would like to secure my key better and use different keys for different env (and secure the key usage by binding it to that domain).
This also follows Google's instuctions on how to handle API keys:
https://support.google.com/googleapi/answer/6310037?hl=en
Any ideas are welcome!

Solved the thing with conditional rendering: https://facebook.github.io/react/docs/conditional-rendering.html
   var reactmap = "";     if(this.state.api_key) {       reactmap =  <GoogleMapReact         defaultCenter={this.props.center}         defaultZoom={this.props.zoom}         center={this.state.center}         zoom={this.state.zoom}         onClick={this.unconfirm}         layerTypes={['TransitLayer']}         yesIWantToUseGoogleMapApiInternals={true}         onGoogleApiLoaded={({map, maps}) => this.setState({maps: maps, map: map})}         options={createMapOptions}         bootstrapURLKeys={this.state.api_key}       >       </GoogleMapReact>
as render is called many times and only in the last call it has the api-key. So I'm preventing the map from loading until it has the key.

hi can you provide options you are using ?
how to show in mobile map at top

@mikkopori use env variables for different envs
        const mapKeys = {             key: process.env.GOOGLE_MAPS_API,             language: 'en',         }

Works fine by me, please see this example.
If the problem persists please feel free to create a new issue. We're doing a cleanup! Thanks.


Panel: weird artifact moving the panel to the right

Testing: #36906
Steps to reproduce:

only have the panel visible
move it all the way to the left
suddenly the background of the sidebar shows up with no contents?

I can not reproduce this with all the fixes.
Probably a dup of #37248
Let me know if you can still repro and I can reopen


Common Legend for two or more charts on Same Page

I have multiple charts on the same page. Which have their corresponding legends. I want to club and make a common legend for all the charts, as the legends are common for all the charts. Also, when i click on a legend particular legend should be toggled in all the charts.
Also it will be helpful if you can let me know how we can refer a chart when we have multiple charts on the same page.
Please let me know how this can be achieved.
Thanks in advance.

Hi there!
We try to keep the issue queue clear for specific code-related problems with C3,
Could you please try asking your question on either the Google Group
or Gitter instead?
Thank you!


Support declarative (attribute based) way of declaring Page/Control objects

Current: page objects can be constructed with explicit constructor initalization.
Desired: Page objects can be constructed based on provided Attribute decorations.

https://github.com/CosminSontu/SpecDrill/commit/b32d9d39fccb064691fcb305c98c43556a4173be


Show output as IPA?

I struggle with the pronunciation of Glish especially with long words like pawrpstst or stweyedhd but also with words that have an ambiguous pronunciation for my written-english-to-sounds-translator in my head like zawng or veevd.
While it probably wouldn't make me able to pronounce pawrpstst, it would massively help if I had a way to see the pronunciation in an unambiguous alphabet like IPA.
Furthermore, from the video:

Frankly, I think this [IPA] is what the alphabet really should be.

totally! It would be great to have a toggle to choose IPA or respelled english


Font weight to 100 for tooltips

Let's publish a new library version to NPM and bump the version used in v2.


[Bug]: Viewport UI breaks when trying to resize any widgets

https://user-images.githubusercontent.com/890915/211353661-fbf4c3d8-c06f-4ed9-b077-4ac1de38cb74.mp4

Working fine now, moving to done.


feat: Add developer type in trending developers

Closes #29

:tada: This PR is included in version 1.6.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


chore: optimize treeview re-render

Types

[x] 💄 Code Style Changes

Background or solution

🤖 Generated by Copilot at 3998ef5

Replaced state variables with ref variables to avoid unnecessary re-rendering of components (link, link, link, link, link, link, link, link, link, link, link, link, link, link)

Changelog

🤖 Generated by Copilot at 3998ef5
The pull request improves the performance of several components that use tree views by replacing state variables with ref variables. This avoids unnecessary re-rendering and state updates when the components are ready or loading. The affected components are extension-tree-view, file-tree, and scm-resource-tree.

看起来可以的，LGTM。
减少 Re Render 次数


[POC] for Delete allow for Satellite only

@lpichler  @dehort  here is a POC for the behavior we want to have for
https://issues.redhat.com/browse/RHCLOUD-19895
It needs some more Sources handler tests, but did not get time to figure out how the mocks work (need to set Satellite source_type_id).
Not crazy about putting the "source" specifics in the permission middleware - can probably be done more cleanly, but was looking for a fast path.
cc @syncrou
Lindani

Yes, sources handler tests needs other changes:

Add another Satellite SourceType to data which are used for tests: https://github.com/RedHatInsights/sources-api-go/blob/main/internal/testutils/fixtures/source_type.go
Add another Source here with Satellite SourceType: https://github.com/RedHatInsights/sources-api-go/blob/main/internal/testutils/fixtures/source_type.go
It looks that cache for Source/App type which is used for dao.Static.GetSourceTypeId("satellite") needs to be initiated for tests - which probably need to make typeCache struct global also with its attributes (sourceType,...). I played with it maybe it can be used: http://pastebin.test.redhat.com/1061108.
With this change can add to each test(or better place) where it is needed:

	tc := dao.TypeCache{}
	tc.SourceTypes = make(map[string]int64)
	tc.SourceTypes = map[string]int64{"satellite": 1} // there is ID defined 1. for satelite.
	dao.Static = tc

Also we can skip mocks test and add only integration in follow up PR if we need this quickly.


Fix caddyserver repo URL in CI

Looks like mholt's repository has gone private - we should be using the
official caddy repo instead anyway.

closing in favor of #177 since I can't push to your branch Scott :/


Linting with --ignore-file doesn't have a deterministic output

I am in version 0.11.1 and I am trying to use vacuum lint with the --ignore-file argument.
When I lint the yaml file with the ignoring, sometimes I get 5 errors (5 valid ones and 1 ignored), but some other times I get 6 errors (none of them gets ignored).
I am executing it one time after the other without changing anything, so there is no difference between the two executions.
Also, I tried to do the same things with a smaller OpenAPI file (13 lines), but then it was working perfectly.
And I couldn't find any 'sequence` of how often I get the right and the wrong result. It seems random to me.
Below you can find both my demo OpenAPI file and the ignore file that I use.
OpenAPI file:
openapi: 3.0.1
info:
  contact:
    email<EMAIL_ADDRESS>  description: API definitions
  license:
    name: Apache 2.0
    url: http://www.apache.org/licenses/LICENSE-2.0.html
  termsOfService: https://example.com/terms/
  title: Example API
  version: 1.0.0
security:
  - basicAuth: []
  - bearerAuth: []
paths:
  /health:
    get:
      operationId: checkReadiness
      responses:
        default:
          content:
            application/json;charset=UTF-8:
              schema:
                $ref: "#/components/schemas/ResponseResult"
          description: default response
      summary: Returns the readiness health of the service
  /health/liveness:
    get:
      operationId: checkLiveness
      responses:
        default:
          content:
            application/json;charset=UTF-8:
              schema:
                $ref: "#/components/schemas/ResponseResult"
          description: default response
      summary: Returns the liveness health of the service
  /v1/repo:
    post:
      description: Creates a new repo
      operationId: createRepo
      requestBody:
        content:
          application/json;charset=UTF-8:
            schema:
              $ref: "#/components/schemas/CreateRepository"
        description: object representation
        required: true
      responses:
        default:
          content:
            application/json;charset=UTF-8:
              schema:
                $ref: "#/components/schemas/ResponseCreateRepo"
          description: default response
      summary: Create a new repo
      tags:
        - Example
components:
  schemas:
    CreateRepository:
      type: object
      properties:
        team:
          type: string
          maxLength: 255
          minLength: 1
        description:
          type: string
          maxLength: 350
          minLength: 10
        name:
          type: string
          maxLength: 100
          minLength: -1
          pattern: "*"
      required:
        - team
        - description
        - name
    CreateRepoResponse:
      type: object
      properties:
        team:
          type: string
        name:
          type: string
        url:
          type: string
      required:
        - team
        - name
        - url
    ResponseCreateRepo:
      type: object
      properties:
        data:
          $ref: "#/components/schemas/CreateRepoResponse"
      required:
        - data
    ResponseResult:
      type: object
      properties:
        data:
          $ref: "#/components/schemas/Result"
      required:
        - data
    Result:
      type: object
      properties:
        details:
          type: object
          additionalProperties:
            type: object
        error:
          type: object
          properties:
            localizedMessage:
              type: string
            message:
              type: string
            stackTrace:
              type: array
              items:
                type: object
                properties:
                  classLoaderName:
                    type: string
                  className:
                    type: string
                  fileName:
                    type: string
                  isNativeMethod:
                    type: boolean
                  lineNumber:
                    type: integer
                    format: int32
                  methodName:
                    type: string
                  moduleName:
                    type: string
                  moduleVersion:
                    type: string
        healthy:
          type: boolean
        message:
          type: string
        time:
          type: string
          format: date-time
      required:
        - healthy
        - time
  securitySchemes:
    basicAuth:
      scheme: basic
      type: http
    bearerAuth:
      bearerFormat: JWT
      scheme: bearer
      type: http

Ignore file:
oas-schema-check:
  - $.components.schemas['CreateRepository'].properties['name'].minLength

@lobocv would you like to take a stab at this, as it's your feature?

Running it with some debug prints I see that the path on the error is sometimes different than the one you are ignoring:
On the run with 6 errors (ignoring is failing) I get the following path

$.paths['/v1/repo'].post.requestBody.content['application/json;charset=UTF-8'].schema.properties['name'].minLength

When it does work (5 errors, 1 ignored) I see the path is:

$.components.schemas['CreateRepository'].properties['name'].minLength

Seems like a bug in the code that generates the path? Looking at the openapi.yaml, it looks like the first one is the real path.
@daveshanley do you know what could be going wrong here?

Running it with some debug prints I see that the path on the error is sometimes different than the one you are ignoring:
On the run with 6 errors (ignoring is failing) I get the following path

$.paths['/v1/repo'].post.requestBody.content['application/json;charset=UTF-8'].schema.properties['name'].minLength

When it does work (5 errors, 1 ignored) I see the path is:

$.components.schemas['CreateRepository'].properties['name'].minLength

Seems like a bug in the code that generates the path? Looking at the openapi.yaml, it looks like the first one is the real path.
@daveshanley do you know what could be going wrong here?
EDIT: Ah I see. It looks like in one case, the $ref is being resolved and in the other case it's not. Looks like the linting behaviour is not consistent in it's output.

Unfortunately I believe this is not yet fixed. I have been getting errors on some runs of vacuum lint (version 0.13.1).
On error it says the path is:
$.paths['/memberAppComponents/{memberAppComponentId}'].delete
But in my ignore file I have:
$.paths['/memberAppComponents/{memberAppComponentId}']
Most of the time it works, maybe 1/5 times it fails. Not sure why it's matching the delete operation sometimes and the path other times.
This is my rule:
  url-starts-with-major-version:
    description: Major version must be the first URL component
    message: All paths must start with a version number, eg /v1, /v2
    given: $.paths
    severity: error
    type: style
    then:
      function: pattern
      functionOptions:
        match: "/v[0-9]+/"

I was able to recreate this issue on v0.13.1  😢
This is my rule which checks that all paths start with a version
url-starts-with-major-version:
description: Major version must be the first URL component
message: All paths must start with a version number, eg /v1, /v2
given: $.paths
severity: error
type: style
then:
function: pattern
functionOptions:
match: "$/v[0-9]+/"
About 1/4 times I run the lint I get a failure. When it fails, it matches on some object in the path rather than the path key:
For example:
$.paths['/memberAppComponents'].post.responses is what vacuum says the path is that is failing
but it should be
$.paths['/memberAppComponents']
And it is, most of the time (and then the tests pass because I have that ignored)

I was debugging this and it looks to be coming from this line.
It assumes the thing you are matching is an object. For my rule, I am matching against the path keys with $.paths[*]~
Not sure what the solution would be here @daveshanley  but i'm happy to contribute to a fix.

Okay I think I've nailed this down the the source. It seems to be an issue in the doctor building a mapping of line number to node objects here.
There is a race condition that happens here when using $ref.
The line numbers of the processed nodes are relative to the yaml file the object is defined, not relative to the overall document. In my case, I have each path in a separate yaml file. What happens is that all the objects from a particular path (path items, reponses, operations etc) get assigned to the same line number. Only the first node gets used.
Since this happens asynchronously, there is a race condition where the first node is the right one and the path reported by vacuum is correct. But in other cases, one of the nodes from deeper within the $ref is used and is assigned the line number of the $ref.
I hope I am explaining this correctly. Unfortunately I don't know the solution. The lineObjects needs to account for the line numbers injected by the $ref.
I will see if I can recreate this as a test in the doctor


Messages with multiple images won't show the details popup correctly

This shouldnt be an issue anymore as the popup just grabs one image at a time


Nextflow fixes

In this PR there are two fixes:

Accepts path of files without a file:// prefix.
It gives support to files with * in its path. Nextflow could declare an output like:

{"url":   "/mnt/d7/bf94bed30fc23584deca82ea83d95a/chunk_*",
 "path": "/work/chunk_*", "type": "FILE"}

Codecov Report

Merging #19 into master will increase coverage by 0.01%.
The diff coverage is 30.00%.

@@            Coverage Diff             @@
##           master      #19      +/-   ##
==========================================
+ Coverage   27.55%   27.56%   +0.01%
==========================================
  Files           8        8
  Lines         606      613       +7
==========================================
+ Hits          167      169       +2
- Misses        439      444       +5

Impacted Files
Coverage Δ

src/tesk_core/filer.py
36.84% <30.00%> (-0.19%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update acebd70...0e8dc78. Read the comment docs.


securityinfo

When filling in the parameters below for a non secure public feature server(NOT Portal, ArcGIS Rest Feature Server), which parameters should I fill for the securityinfo?  Keep getting invalid token when a token shouldn't be required.
Error
appInfo  - attribute not implemented in Portal class.
authorizedCrossOriginDomains  - attribute not implemented in Portal class.
appInfo  - attribute not implemented in Portal class.
authorizedCrossOriginDomains  - attribute not implemented in Portal class.
{u'message': u'Invalid Token', u'code': 498, u'details': []}
error  - attribute not implemented in Feature Layer.
securityinfo = {}
securityinfo['security_type'] = 'Portal'#LDAP, NTLM, OAuth, Portal, PKI, ArcGIS
securityinfo['username'] = "" #User Name
securityinfo['password'] = "" #password
securityinfo['org_url'] = "http://www.arcgis.com"
securityinfo['proxy_url'] = proxy_url
securityinfo['proxy_port'] = proxy_port
securityinfo['referer_url'] = None
securityinfo['token_url'] = None
securityinfo['certificatefile'] = None
securityinfo['keyfile'] = None
securityinfo['client_id'] = None
securityinfo['secret_id'] = None

@wyogisguru if you have a service, then you would use an AGSSecurity token handler.  If you don't need security, then pass None.

You do not want to use the security handler helper, can you share the rest of your code?

closed to no response.


switch atomics to use ManagedBuffer

I'm pretty sure we can use ManagedBuffer(Pointer) to implement the atomics to save one allocation per atomic.
Currently, how this works is:
class Atomic* holds struct UnsafeEmbeddedAtomic which holds an OpaquePointer to raw memory that we use the the C atomics. From from a given use site, we have two layers of indirection
[use site] -> [Atomic class] -> [raw memory for the atomic]

with ManagedBuffer(Pointer) we could however allocate the raw memory together with the Atomic* class instance and whilst it would still technically be two layers of indirection, it's really only one because the second one is a (small) offset from the beginning of the class. So essentially we'd be saving one allocation and one possible cache miss.

This is something that can be done with medium to advanced Swift knowledge but pretty much without any NIO knowledge at all.
If there are any questions regarding what this actually means, please reach out.

I'm interested in doing this one but I need more detail.
Is the idea that Atomic would still use UnsafeEmbeddedAtomic but the space for the underlying atomic is allocated by Atomic.init and stored as a property?
One way I could imagine doing this is have Atomic.init make the T.atomic_create(value) call and pass the result to a new UnsafeEmbeddedAtomic.init(pointer: OpaquePointer). This doesn't seem great though, since there's no enforcement that pointer is pointing to an AtomicPrimitive.
I'm guessing this is where ManagedBuffer comes in, but I'm not understanding how it should be used. Or maybe I'm just completely misunderstanding the intention! :)
Can you explain a bit more about how you see this being implemented?

Hi @2bjake, great to hear you're interested taking this issue.
At the moment, we need two allocations for every atomic:

for the class Atomic<T>
the malloc for the underlying storage

If however we would use ManagedBuffer or ManagedBufferPointer we should be able to allocate the class instance (which we need for lifecycle management) and the storage for the actual atomic in only one allocation because ManagedBuffer(Pointer) support tail allocating some extra storage which is all we need.
Implementation-wise, we have two options:

We make Atomic<T> subclass ManagedBuffer<Void, T.CWrapperType> which would mean we could keep the existing API but unfortunately would get some extra methods on Atomic<T> that we don't really want
Make a new struct FastAtomic<T> which uses ManagedBuffer or ManagedBufferPointer (probably the latter) and doesn't reveal it's own implementation.

In the CAtomics module, we'll likely need a new function like
*/ struct catmc_atomic_##type *catmc_atomic_##type##_create_with_existing_storage(void *storage, type value) { /*
*/     atomic_init(storage->value, value); /*
*/     return storage; /*
*/ } /*

which allows us to initialise a new C atomic using existing storage (which is a pointer to the tail allocated storage of the class).
I'm not sure if all of this makes sense and really answers your questions so please keep asking which bits are unsure.

Thanks so much for providing this explanation. This is all new to me (which is why I wanted to tackle it!) I think I've got it now. I've got a version that is passing tests that looks like this:
public class FastAtomic<T: AtomicPrimitive> {
    @usableFromInline
    typealias Manager = ManagedBufferPointer<Void, T>

    /// Create an atomic object with `value`
    @inlinable
    static func withValue(_ value: T) -> FastAtomic {
        let ptr = Manager(bufferClass: self, minimumCapacity: 1) { buffer, _ in
            Manager(unsafeBufferObject: buffer).withUnsafeMutablePointerToElements { atomicPtr in
                //temporary, should actually pass atomicPtr to catmc_atomic_##type##_create_with_existing_storage(void *storage, type value)
                atomicPtr.initialize(from: UnsafePointer(T.atomic_create(value)), count: 1)
            }
        }
        return unsafeDowncast(ptr.buffer, to: FastAtomic<T>.self)
    }

    @inlinable
    public func compareAndExchange(expected: T, desired: T) -> Bool {
        return Manager(unsafeBufferObject: self).withUnsafeMutablePointerToElements {
            return T.atomic_compare_and_exchange(OpaquePointer($0), expected, desired)
        }
    }

    @inlinable
    public func add(_ rhs: T) -> T {
        return Manager(unsafeBufferObject: self).withUnsafeMutablePointerToElements {
            return T.atomic_add(OpaquePointer($0), rhs)
        }
    }

   //...

    deinit {
        Manager(unsafeBufferObject: self).withUnsafeMutablePointers {
            (pointerToHeader, pointerToElements) -> Void in
            pointerToElements.deinitialize(count: 1)
            pointerToHeader.deinitialize(count: 1)
        }
    }
}

Does this line up with what you were describing for option 2? Is it expected that FastAtomics would be created with a static function rather than an init?

I've got a version that is using catmc_atomic_##type##_create_with_existing_storage. The only part I'm not sure about is how to set the buffer's element type to T.CWrapperType. I tried adding a CWrapper typealias to the AtomicPrimitives but the catmc_atomic_##type types aren't visible on the Swift side.
Any thoughts on how to do this?

Answering my own questions. :p I got this working by moving the struct definitions into the header. However, this won't be backward compatible as now the atomic methods take UnsafeMutablePointer<catmc_atomic_##type> instead of OpaquePointer, which causes the AtomicPrimitive protocol to change. I guess I could create "fast" versions of all these APIs as well.

@2bjake this looks awesome! I think given that you won't need to change the API, couldn't FastAtomic now just be Atomic?

Unfortunately the API does change in a few places:

The ManagedBufferPointer-based Atomic class doesn't have an init, it is constructed with a static function.
The AtomicPrimitive protocol needs an AtomicWrapper (what you called T.CWrapperType) associatedtype and a new atomic_create_with_existing_storage method added (these could be added to a new protocol instead, but then the Atomic class would have to be generic over a type that also conforms to that new protocol)
To specify the AtomicWrapper typealiases, the c structs can't be incomplete in the CNIOAtomics header. However, when fully defining the structs in the header, the generated Swift interface for the methods change. OpaquePointers become UnsafeMutablePointer<catmc_atomic_##type>s. This also causes the AtomicPrimitive protocol to change.

I'm working on a FastAtomic version at the moment that is unique all the way down to the C layer (Atomic, AtomicPrimitive, catmc_atomic_*). "fast" is probably not the right name at the C layer, but it does make sense to have it be separate from the existing version. In the existing C layer implementation, the pointer is opaque and the user is required to call destroy. In the new version, the pointer is not opaque, the user is responsible for allocating and deallocating the memory, and there shouldn't be a destroy function.
That said, it is annoying how much code duplication there is... I'm hoping to get this into a PR today so you can take a look and let me know what you think.


Make admin interface listen to localhost

Make admin interface listen to localhost
Add a config option to allow override

Also rebased brunch on master.

doh, looks like you're out of sync with master again ;/

Will rebase once I'll get home in few hours ;)

Another attempt ;)

Meeerge, I neeed somebody meeerge... me... :)

Merged https://github.com/BuoyantIO/linkerd/commit/d2dc194e584d06cca03fcc5822e774a041eced60


Prevent very far away point lights from being culled

Very far away Omni and Spot lights get culled and can't contribute to the scene's lighting even though their radius is large enough.
This is due to several floating point precision issues this PR resolves :

The light clustering logic computes the squared length of the light position in view space. This involves squaring its components which generates INFINITY if one of them is greater than sqrt(MAX_REAL_T_VALUE) = 1.8446744x10^19  with 32 bit floats). Consequently the light's sphere of influence is always considered behind the near plane or beyond the far plane and it gets culled.
In the compatibility renderer, a similar issue arises when the length of the light position in view space is computed and compared to the fadeoff distances. The length obtained is then INFINITY and the light gets culled against the fade far distance.
In scene and fog shaders, the distance from the light to the vertex is computed. Again, it involves squaring the vector's components, which generate INFINITY when they're greater than SQRT(MAX_FLOAT_VALUE). Consequently the light gets a zero attenuation factor and a zero light vector, therefore doesn't affect the fragment.

This PR solves ~all 3 above issues~ issues 1. and 3. (the compatibility renderer is left unchanged) by scaling down the light position in view space by its L1-norm + 1 before getting the length, then scales it back.
The scene below is lit by two omni lights positioned behind the camera at approx x = y = z = 1E30.

With this PR
Without

FAQ
What about Directional lights ?
There is no such issue for Directional lights, as no distance computation is involved (only the light direction plays a role, and it's a unit vector).
What's the cost of this change in the scene fragment shader ?
The length correction fix is computed once per point light
--> +3 abs() +3 add() +2 mul() per point light

... and once per point light with shadows
--> +3 abs() +3 add() +2 mul() per point light with shadows

1 to 2 `normalize()` per point light are replaced by a less costly division by the length :
+-> -1 to -2 `normalize()` per point light
--> +1 to +2 mul() per point light

Is it really worth it ?
This small tweak unlocks using omni and spot lights in the range [1E19; 1E38] in single precision, speaking of attenuation radius and distance to origin, in addition to the commonly used [0; 1E19] range. This extended range is especially useful in space scenes and other extremely large environments.
Why not just using the double precision build ?
The double precision build can't solve the problem in the scene shader. It would also be a much more resource intensive alternative to solve a simple problem : being able to use the lights across the whole value range of 32 bits floating point, not only the first half of it.
It's not a surprise that rendering very deep scenes raise many numerical precision issues
Absolutely, and this is what I'm into ! I started digging into this rabbit hole a while ago, and also stumbled upon #95944 and #98610 so far. There will be likely more to come

I'm not sure about forcing this change on everyone. It's great for space games that want a long view distance, but aren't willing to pay the cost of double precision. But for everyone else its a performance cost for no gain and for engine maintainers its additional complexity and maintenance burden.
Our fragment shaders are already instruction bottlenecked. So this would have a very real cost for many games who won't benefit from it.
The CPU code is less problematic as there likely won't be any performance regression.

Yes I'm very aware of the performance bottleneck of fragment shaders, and I get your point.
To clarify one thing : this issue prevents anyone from having long ranging lights in space games and alike, including those using double precision. Double precision builds don't help in shaders.
I have a couple of ideas to further reduce the performance cost and maintenance burden :

Leave the compatibility renderer unchanged. Apply this PR only to forward clustered and mobile
Pack the modified normalize and length operations into macros or functions like NORMALIZE_SAFE() and LENGTH_SAFE() for readability

Will update the PR and see if it looks more acceptable. Feedback appreciated :pray:

Can you clarify which max values in meters would start having problems?

Problems start when :

the light itself is very far away from the camera : position in view space has one or more coordinates greater than ~1.84e+19 (culling issue)
and/or the lit vertex is very far from the camera : vector from light to vertex in view space has one or more coordinates greater than ~1.84e+19 (lighting issue in the fragment shader)

Rebased on top of #94981

Rebased


chore(master): release 1.13.0

:robot: I have created a release beep boop
1.13.0 (2022-08-25)
Features

created test action (d76d7aa)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/SethCohen/github-release-to-discord/releases/tag/v1.13.0 :sunflower:


Object Oriented Programming Approach

Description
This particular issue will discuss the various concepts of OOP in python
Domain
Python_Domain
Type of Contribution
Documentation
Code of Conduct

[X] I follow Contributing Guidelines & Code of conduct of this project.

/assign

@queenish001 Is the mentor of this issue. Please reach out to her for your queries.

@Deepanshu-bhalla What's your status on this Issue?