Alternate or supplemental SIC usage

Likely to trial this with higher resolution SIC sources but applies to other potential sources of ground truth. Consider a pretraining phase at lower resolution stepping up to higher.

https://github.com/icenet-ai/icenet/issues/161

Mask validations

[ ] Trial training pipeline with alternate SIC truth

[ ] Straight through training
[ ] Low resolution pre-training workflow

[ ] Trial prediction pipeline with alternate SIC

AMSR 3km is implemented from the University of Hamburg. 6km can come from Bremen (they only supply 3km in HDF so easier just to use the alternative.)
There's reason to extract and improve the downloaders for this issue, so reviewing the development effort to abstract out the common missing dates functionality and start addressing #51 as well as this.

@MartinSJRogers  has posted this. Passive microwave data at 3.125km2 going back to 1979. Although this has data as brightness temperatures so would need to be converted to SIC via the algorithm: https://nsidc.org/data/nsidc-0630/versions/1


[Part-2] IT test cases of Admin API for HBase 1 and HBase 2

This change includes addresses the gap between this Bigtable client and HBase API for the below methods:

Admin#listTableNames(Pattern)
Admin#getTableDescriptorsByTableName(List)(It is being called by below operations)

Admin#getTableDescriptors(List)
Admin#listTables(Pattern)
Admin#enableTables(Pattern)
Admin#disableTables(Pattern)
Admin#deleteTables(Pattern)

Admin#isTableDisabled(TableName)

Admin#isTableEnabled(TableName)

Ideally we would close the gap, what kind of differences have you seen?

The IT test case present in this PR are currently annotated with @Ignore due to all of these methods are calling the Admin#getTableDescritor(TableName) which translates into IBigtableTableAdminClient#getTable.
It seems the getTable's still has this bug which causing each test case to fail with TableNotFoundException or FAILED_PRECONDITION.


Append the short commit revision to version on frontend

Description of PR

What component(s) does this PR affect?

[ ] Back-End (Database, Detection/Configuration/etc. Microservices)
[x] Front-End (Flask, API, UI, etc)
[ ] Monitor (RIPE RIS, BGPStream RV/RIS/CAIDA, etc.)
[ ] Docs (incl. wiki)
[x] Build System

Does the PR require changes on other components? If yes, please mark the components:

[ ] Back-End (Database, Detection/Configuration/etc. Microservices)
[ ] Front-End (Flask, API, UI, etc)
[ ] Monitor (RIPE RIS, BGPStream RV/RIS/CAIDA, etc.)
[ ] Docs (incl. wiki)
[ ] Build System

Related Issue

Resolves #400
Solution

Type

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Docs update
[ ] None of the above

Checklist:

[x] I have read the contributing guide and my code conforms to the guidelines.
[ ] This change requires a change in the documentation.
[ ] I have updated the documentation accordingly.

Should we do this only for frontend or also for the other containers? Does it change anything in the logic of the latest version publishing? Or is it sth within travis only?

Should we do this only for frontend or also for the other containers? Does it change anything in the logic of the latest version publishing? Or is it sth within travis only?

we only print the version on the frontend so I don't think we need any further changes


Fixes #29: [WIP] Added Unit Tests

I tried your suggestion but it causes the other tests to fail (looks like its no longer adding a whitespace?)

@aolszowka do you need any help/guidance with the failing tests?

Ah, I see, if there is a method split (into 2 or more exception specific ones) then the second and all the next are missing a single leading empty line (as they borrow leading/trailing whitespace from the original method).
Let me see what I can do for it.

Ok @aolszowka. I did a few things. It just needs final polishing touches (which I leave to you).

I rebased on the master in a GIT proper way. I see you managed to merge the master into your aolszowka:comment-and-region-truncation in some mysterious way that it wasn't marked as a merge commit - and this we should avoid. I kindly encourage you to read about git merge and git rebase utilities.
You can just reset your branch to mine (wachulski/comment-and-region-truncation). You can delete and checkout again if you don't know how to do it.
As you can see I left your unit tests and provided a fix for the issue. All unit tests should go green now.
What's left are tests. This is that final touch:

please extract your tests into a fixture like: ExceptionExpectancy/TriviaFixture.cs
rename according to the convention: WhenSthIsSetup_PreservesThisAndThat e.g. CommentsArePreserved_ExpectedExceptionAttributeBelowTest turns into WhenExpectedExceptionAttributeBelowTest_FixesAndCommentsArePreserved (and you see it lacks information about the comments arranged for the test, just some info about attribute placement, but should be telling about comments instead/too)
please also add some tests for TestCases with various exceptions (this will produce 1 method split into several ones) [I'm particularly interested if such splits preserve comments/regions correctly]

@aolszowka Are you fancy continuing? In short, we're very close to fix it, merge and release 1.1.1.

Hey @wachulski sorry the holiday rush has started here before we have time off; I'll see if I can address this today.

rebased on the master in a GIT proper way.

Yah I was struggling to understand how to correctly resync to the master branch; I'll take a look at the docs again; do you have any videos you recommend to learn how to do this properly? It seems like I was unable to do it from the Web Interface, is the CLI the only way?

you can delete and checkout again if you don't know how to do it.

I'll probably do that this time around.
Again let me see if I can knock this out today; tomorrow at the latest.

No rush 😃 thx for your contribution and patience so far. If my tone was a bit harsh and hurrying up - excuse me, I didn't mean that.
You contributed quite a lot actually and I didn't want to finalize everything myself. So, final touches left for you 😃
When it comes to GIT, the best resource I learnt from is this book (available online, free): https://git-scm.com/book/en/v2 I also see that there are plenty of other tutorials atm, e.g. https://try.github.io/ by GH itself.
If you're Windows-based then I also strongly recommend some visual tool (e.g. https://github.com/gitextensions/gitextensions which I use heavily).

Hey I am on it right now; I am a little confused by this statement:

please also add some tests for TestCases with various exceptions (this will produce 1 method split into several ones) [I'm particularly interested if such splits preserve comments/regions correctly]

I am unfamiliar what what this means?
At first I thought you maybe meant having multiple tests in there; but upon reading it again I do not think that is what you intended?
        [Test]
        public void WhenExpectedExceptionAttributeIsBelowMultipleTests_CommentsArePreserved()
        {
            var source = @"
using NUnit.Framework;
using System;

[TestFixture]
public class TestClass
{
    /// <summary>
    /// There was another comment here
    /// </summary>
    [Test]
    [ExpectedException(typeof(InvalidOperationException))]
    public void TestMethod2()
    {
        throw new InvalidOperationException();
    }

    /// <summary>
    /// There was a comment here
    /// </summary>
    [Test]
    [ExpectedException(typeof(Exception))]
    public void TestMethod()
    {
        throw new Exception();
    }
}";

            var expected = @"
using NUnit.Framework;
using System;

[TestFixture]
public class TestClass
{
    /// <summary>
    /// There was another comment here
    /// </summary>
    [Test]
    public void TestMethod2()
    {
        Assert.Throws<InvalidOperationException>(() =>
        {
            throw new InvalidOperationException();
        });
    }

    /// <summary>
    /// There was a comment here
    /// </summary>
    [Test]
    public void TestMethod()
    {
        Assert.Throws<Exception>(() =>
        {
            throw new Exception();
        });
    }
}";

            VerifyCSharpFix(source, expected);
        }

Take a look at tests in MixedExpectedExceptionAndTestCasesFixture and TestCaseOnlyFixture - tests that result in 1 method split into several ones. Like: https://github.com/wachulski/nunit-migrator/blob/76c807337e8c1804181b0e245b0ca913f69d80b1/nunit.migrator.tests/ExceptionExpectancy/TestCaseOnlyFixture.cs#L82

Ok that makes sense; and bummer it does not work; would you like me to commit the test? I think I'll need to create a new pull request.
        [Test]
        public void For2TCs_WhenExpectedExceptionAttribute_CommentsArePreserved()
        {
            var source = @"
using NUnit.Framework;
using System;

[TestFixture]
public class TestClass
{
    /// <summary>
    /// There was a comment here
    /// </summary>
    /// <param name=""input"">Comment for input</param>
    /// <remarks>This was a remark</remarks>
    [TestCase(1, ExpectedException = typeof(Exception))]
    [TestCase(2)]
    public void TestMethod( int input )
    {
        throw new Exception();
    }
}";

            var expected = @"
using NUnit.Framework;
using System;

[TestFixture]
public class TestClass
{
    /// <summary>
    /// There was a comment here
    /// </summary>
    /// <param name=""input"">Comment for input</param>
    /// <remarks>This was a remark</remarks>
    [TestCase(1)]
    public void TestMethod( int input )
    {
        Assert.Throws<Exception>(() =>
        {
            throw new Exception();
        });
    }

    /// <summary>
    /// There was a comment here
    /// </summary>
    /// <param name=""input"">Comment for input</param>
    /// <remarks>This was a remark</remarks>
    [TestCase(2)]
    public void TestMethod( int input )
    {
        throw new Exception();
    }
}";

            VerifyCSharpFix(source, expected);
        }
    }

The result ends up being that the comments are only pulled into the first test case. In addition I would have expected test case 1 to remain at the "top" but instead it was moved down, see the diff to see what I'm talking about:

This test also showed some interesting behavior; it ended up appending a _ShouldThrowException; which was not expected in my mind; but in this case the comments were preserved to both test cases (see the attached diff):
        [Test]
        public void For2TCs_WhenExpectedExceptionIsSecondTestCase_CommentsArePreserved()
        {
            var source = @"
using NUnit.Framework;
using System;

[TestFixture]
public class TestClass
{
    /// <summary>
    /// There was a comment here
    /// </summary>
    /// <param name=""input"">Comment for input</param>
    /// <remarks>This was a remark</remarks>
    [TestCase(1)]
    [TestCase(2, ExpectedException = typeof(Exception))]
    public void TestMethod( int input )
    {
        throw new Exception();
    }
}";

            var expected = @"
using NUnit.Framework;
using System;

[TestFixture]
public class TestClass
{
    /// <summary>
    /// There was a comment here
    /// </summary>
    /// <param name=""input"">Comment for input</param>
    /// <remarks>This was a remark</remarks>
    [TestCase(1)]
    public void TestMethod( int input )
    {
        throw new Exception();
    }

    /// <summary>
    /// There was a comment here
    /// </summary>
    /// <param name=""input"">Comment for input</param>
    /// <remarks>This was a remark</remarks>
    [TestCase(2)]
    public void TestMethod( int input )
    {
        Assert.Throws<Exception>(() =>
        {
            throw new Exception();
        });
    }
}";

            VerifyCSharpFix(source, expected);
        }

Regions do not fair well either; in this case it will produce code that will not compile (it will throw CS1038 because there is no #endregion).
Test Case:
        [Test]
        public void For2TCs_WhenExpectedException_RegionsArePreserved()
        {
            var source = @"
using NUnit.Framework;
using System;

[TestFixture]
public class TestClass
{
    #region TestRegion
    [TestCase(1)]
    [TestCase(2, ExpectedException = typeof(Exception))]
    public void TestMethod(int input)
    {
        throw new Exception();
    }
    #endregion
}";

            var expected = @"
using NUnit.Framework;
using System;

[TestFixture]
public class TestClass
{
    #region TestRegion
    [TestCase(1)]
    public void TestMethod(int input)
    {
        throw new Exception();
    }

    [TestCase(2)]
    public void TestMethod(int input)
    {
        Assert.Throws<Exception>(() =>
        {
            throw new Exception();
        });
    }
    #endregion
}";

            VerifyCSharpFix(source, expected);
        }

Result:

I've just pushed another fix, this time the one accounting for mixed exception and non-exception test cases. https://github.com/wachulski/nunit-migrator/tree/comment-and-region-truncation should be ok.
Are you fine with the changes? Do you see any other potential problem here? When it comes to PR, we don't need a new one. Just reset your branch to mine and push with --force.

Do we expect the comments to be duplicated when the test case is extracted? I am OK with them not being duplicated (as it is with your most current fix) with that but maybe we should add a warning about it?
Just so we're clear I'm talking about For2TCs_WhenExpectedExceptionIsFirstTestCase_CommentsArePreserved()
Here is the source:
using NUnit.Framework;
using System;

[TestFixture]
public class TestClass
{
    /// <summary>
    /// There was a comment here
    /// </summary>
    /// <param name="input">Comment for input</param>
    /// <remarks>This was a remark</remarks>
    [TestCase(1, ExpectedException = typeof(Exception))]
    [TestCase(2)]
    public void TestMethod( int input )
    {
        throw new Exception();
    }
}

I could see it being transformed two ways:

This is the way it is working after your fixes (note the comment is missing from the new test case):

using NUnit.Framework;
using System;

[TestFixture]
public class TestClass
{
    /// <summary>
    /// There was a comment here
    /// </summary>
    /// <param name="input">Comment for input</param>
    /// <remarks>This was a remark</remarks>
    [TestCase(2)]
    public void TestMethod( int input )
    {
        throw new Exception();
    }

    [TestCase(1)]
    public void TestMethod_ShouldThrowException( int input )
    {
        Assert.Throws<Exception>(() =>
        {
            throw new Exception();
        });
    }
}

This is another potential way it could have transformed the source (note that the comment is duplicated):

using NUnit.Framework;
using System;

[TestFixture]
public class TestClass
{
    /// <summary>
    /// There was a comment here
    /// </summary>
    /// <param name="input">Comment for input</param>
    /// <remarks>This was a remark</remarks>
    [TestCase(2)]
    public void TestMethod( int input )
    {
        throw new Exception();
    }

    /// <summary>
    /// There was a comment here
    /// </summary>
    /// <param name="input">Comment for input</param>
    /// <remarks>This was a remark</remarks>
    [TestCase(1)]
    public void TestMethod_ShouldThrowException( int input )
    {
        Assert.Throws<Exception>(() =>
        {
            throw new Exception();
        });
    }
}

Thank you so much for your project and helping out!
Also thank you for being patient with me as I learn Git (coming from a Subversion background so things are slightly different). I found this really helpful https://help.github.com/articles/merging-an-upstream-repository-into-your-fork/

When it comes to copying summary docs, I'd like to avoid it for several reasons:

it adds complexity to trivia processing, filtering (to get only summary docs and not regular comments), taking into account whitespacing etc. (this risks breaking builds if done wrong)
having two unit tests with same summary docs can be perceived as boilerplate duplication (some people wouldn't like having that)
unit test summary docs are not that common from my experience
the workaround is to copy it manually afterwards

Let's keep it as it is for now and eventually improve if the community wish so.

Sounds good to me; as everything is checked in can I just close out this issue?

@aolszowka If you only could edit this PR and update source branch, ie. aolszowka/comment-and-region-truncation . As now it tells it wants to merge 14 commits into wachulski:master from unknown repository and it should be 7 commits into wachulski:master from aolszowka/comment-and-region-truncation
We'd benefit from retaining the discussion history for future reference.
The minute you're done, I'll merge and release 1.1.1

Ok, let me recreate the PR and link to this conversation. No worries.
When it comes to branching strategy, yes, I admit it takes time to make SVN->GIT switch.

In general merges are usually safe providing you sync with the base branch (master) often.
In short, these 2 tips: sync often, learn rebase. But anyway, a piece of solid work by you @aolszowka . Thanks.


Documentation Updates

What
Updated the documentation to make it easier for contributors to get started.
How

Updated Contributing to include information on test settings.
Added Issue and PR templates to ask for the required information.

+1

@rhyshort Does the build need to be removed in this line?
https://github.com/cloudant/swift-cloudant/pull/78/files#diff-6a3371457528722a734f3c51d9238c13R97
I remember we chatted over Slack when I was having difficulties testing and you sent me an updated command:
xcodebuild -workspace SwiftCloudant.xcworkspace -scheme SwiftCloudant -destination 'platform=iOS Simulator,OS=latest,name=iPhone 6S' test

Yes it should have been, ( I thought I had already done it, must have been a dream), anyway really done in 0b0dca7

+1


Dashboard Token Listing: GNSx

Discord Handle of Submitter: omnifient | BTFDCA.finance#7921
Token Symbol: GNSx
Network: Polygon
Token Address: 0xfd0577c4707367ff9b637f219388919d3be37592
Network Explorer Link: https://polygonscan.com/address/0xfd0577c4707367ff9b637f219388919d3be37592
Is a Super Token? true
Address of Underlying Token:  0xe5417af564e4bfda1c483642db72007871397896
SVG Logo Link: https://avatars.githubusercontent.com/u/8012606?v=4
Coingecko or Hardcoded Price?: Coingecko
Coingecko ID: gains-network
Harcoded Price (if Coingecko ID is unavailable):
Token HEX Color: #42eda7
Info on Listing: I'm requesting this listing because BTFDCA has added GNSx as an asset, and it would be nice for holders to see it on the Superfluid App.
Please close only after token has been added to resolver!

@vmichalik

listing done: https://console.superfluid.finance/matic/supertokens/0xfD0577C4707367ff9B637F219388919d3Be37592?tab=streams
@msoni89 please add assets


Parameterize tests for permission levels

After all of the permissions PRs are settled, we should look into parameterizing tests based on permission level. Often in the tests, it seems we're writing separate tests for behavior that's mostly unchanged, except the user level, and whether the action being tested was actually completed (due to sufficient permissions), or failed (due to insufficient permissions). I think the following parameterization would be a good start (pseudo-code):
@pytest.mark.parametrize("permission,status_code,success", [
	(None, 404, False),
	(WorkspacePermission.reader, 403, False),
	(WorkspacePermission.writer, 200, True),
	...,
])
def test_table_rest_insert_rows(..., user, permission, status_code, success):
	workspace.set_user_permission(user, permission)
	...

	r = client.put(...)
	assert r == status_code
	if success:
		# assert that things have changed as desired
	else:
		# assert that nothing has changed

Thoughts @naglepuff @waxlamp?

Neat. Looks like a good idea if it works out this way when you go to do it.


Long running OR commands should report their runtime

Description
Every “long running” command should report how long it took to run it.
The goal would be to be able to easily compare log files from different runs.
E.g.
vimdiff dir[12]/log
or
grep runtime dir2/log > dir2/runtime
diff dir[12]/runtime
Suggested Solution
Currently there seems to be a way to get ORFS to report runtime and memory usage.
But this relies on running the openroad executable for each and every step.
And it's not "built into" openroad, it relies on external scripting.
It should be possible to have one OR tcl script to run "the whole flow" and still get this information in the log.
Log                            Elapsed seconds Peak Memory/KB
1_1_yosys                                  243         971412
2_1_floorplan                               27         510688
2_2_floorplan_io                             4         363812
2_3_floorplan_tdms                           4         362360
2_4_floorplan_macro                          4         367364
2_5_floorplan_tapcell                        4         325804
2_6_floorplan_pdn                            6         381020
3_1_place_gp_skip_io                        38         461672
3_2_place_iop                                4         372996
3_3_place_gp<PHONE_NUMBER>
3_4_place_resized                           94         602152
3_5_place_dp                                78         657092
4_1_cts                                    152         747132
5_1_grt                                   6137        1298604
5_2_fillcell                                 5         494576
5_3_route<PHONE_NUMBER>0
6_1_merge                                   15         815860
6_report<PHONE_NUMBER>
Total                                     8169       11470100

Additional Context
No response

OpenROAD-flow-scripts is a flow that uses OpenROAD. This flow is based on invoking OpenROAD many times, reading in the previous .odb file and writing out an updated one for each stage and reporting times and memory usage.
If I understand correctly, you describe a flow where a single .tcl script is used and the OpenROAD binary is invoked once.
OpenROAD-flow-scripts used to have a "single .tcl script" version of the flow, but it was abandoned because it wasn't being used, maintained and there were no tests for it.
There are many flows other than OpenROAD-flow-scripts that exist on top of the OpenROAD tool. To name a few: Hammer, Zero ASIC SiliconCompiler, bazel_hdl.
None of these flows, to my knowledge, is run by a single .tcl script. The OpenROAD binary is invoked multiple times.
For these flows, OpenROAD is not the only tool being used that memory and times have to be tracked for.
Hence, I think today's solution where the measurement of memory usage and running times is outside of the scope of the OpenROAD binary seems to work well. There are some notable exceptions, memory consumption and running times is tracked and printed for each step within detailed routing.
So in short, I think that absent of a more specific description for changes, I think that today's solution is pretty good. It has evolved to the way it is for good reasons.

I have created log files from years ago running ispd routing testcases, using OpenRoad global and detailed route one script OpenRoad tcl script, no need to save and reload odb databases in between.
It would have been nice then and even nicer now to have runtime info in the logs, alongside the information which commands were run. Both of which changed over time.
Having multiple flows to implement their own runtime logging sounds like an argument to put it into the tool itself to me.
I can’t think of a p&r tool I’ve used over the decades that wouldn’t log its runtimes.

I think it is a nice to have though not a high priority.  To be clear this is command level timing rather than flow step level timing so it is a bit more fine grained.  In general OR doesn't have a unified approach to commands so adding this will likely happen when there is some motivating need to make commands more common.  Dependencies like sta further complicate the implementation.
Detailed routing does already report its runtime so that should be present in your old logs.

It's definitely not "high priority", but very much "nice to have".
Not once have I thought "gee, I wish this tool wouldn't report it's runtime or memory usage" ...
Making it easy to compare run's between versions/machines/implementations by diff'ing/grep'ing/scripting is useful.
Key is to have something consistent and easy to grep for. E.g. "egrep -e CMP -e TIME openroad.log".
Not for the "progress report/internal details", but only for the "mayor, time consuming steps".
There is a fine balance between "show some progress/info" and "keep the log file short and concise".

We could either report whenever a command takes more than X time or just decide which commands are interesting to always report.  The former will make the output somewhat non-deterministic around the threshold, the later may report small times on small designs.  I favor the later in which case for determinism in which case we should make a list.

A few comments:

Every command could be a long-running command under some circumstances or design input
As @oharboe mentioned, there used to be a method for running the flow all in one script, but it was removed because no one used it and it fell out of maintenance
If your GRT is taking longer than DRT (as in the OP) that usually indicates some kind of congestion or layer resource reduction issue
I know of many commands in EDA tools that don't report time / mem usage. Perhaps you are thinking of per-session statistics? That sounds like something doable in OR, like printing time / mem on exit.
For a per-command basis, there becomes an issue of too much verbosity. You say that you have never not wanted it, I know that @oharboe likes logs to be as clutter-free as possible, for example.
Time can be measured in Tcl somewhat easily: https://stackoverflow.com/questions/5242647/tcl-how-to-know-how-much-time-a-function-has-worked, memory less so

Every “long running” command should report how long it took to run it.

In my use-case this info would have been useful to me.
So it sounds like our preferences differ and there is the question of the resources necessary to implement this request.
If long running commands (placement, resize, global route, antenna, detailed route) would report time (in c++), this would in no way impede other flows to ignore this info and log this some other way as today, best of both worlds ...
Considering the existing log file clutter, these few additional lines don't add much.

Would
global_place
rtl_macro_placer
repair_design
repair_timing
global_route
detailed_route

suffice?  I suspect those are the big ticket items and wouldn't add too much verbosity.

repair_timing specifically can take surprisingly long, so having extra detail there would be useful.
Also report timing can be very slow.
CTS is a good example.I have seen cases where CTS takes 10 minutes and report/fix timing takes 24 hours.

Adding time to logs makes them non hermetic so this should be an opt in thing.

Adding time to logs makes them non hermetic so this should be an opt in thing.

This is already the case for detailed routing. How do you deal with that (in bazel_hdl, presumably?)?

repair_timing does give detail with -verbose.  This would just be adding an overall time message.

Here's an example why runtime and memory consumption reporting from openroad is useful.
Todays openroad on a machine with 32 threads, 56GB memory + 14GB swap, wsl2 unbuntu:
Now I know not to try to detail_route the 3M stdcell ispd24 mempool_group testcase again.
read_def is fast
placement density displays instantaneous
rudy takes 35sec before the cursor switches from pointer to busy
global_route -verbose didn't report runtime/memory.
detailed_route reported two runtime/memory datapoints before being killed.
OpenROAD v2.0-13573-g9e909da77
Features included (+) or not (-): +Charts +GPU +GUI +Python
...
Design:                   mempool_group
Die area:                 ( 0 0 ) ( 6767040 6762560 )
Number of track patterns: 20
...
[WARNING DRT-0419] No routing tracks pass through the center of Term gen_tiles\[4\].i_tile/gen_banks\[6\].mem_bank/genblk1.sram_instance/rd_out[0]
[WARNING DRT-0418] Term gen_tiles\[4\].i_tile/gen_banks\[6\].mem_bank/genblk1.sram_instance/rd_out[1] has no pins on routing grid
...
#scanned instances     = 3099210
#unique  instances     = 555
#stdCellGenAp          = 16776
#stdCellValidPlanarAp  = 0
#stdCellValidViaAp     = 11479
#stdCellPinNoAp        = 0
#stdCellPinCnt         = 10978298
#instTermValidViaApCnt = 0
#macroGenAp            = 19262
#macroValidPlanarAp    = 19262
#macroValidViaAp       = 0
#macroNoAp             = 0
[INFO DRT-0166] Complete pin access.
[INFO DRT-0267] cpu time = 84:59:19, elapsed time = 03:09:21, memory = 37294.33 (MB), peak = 39299.85 (MB)
....
Number of guides:     28748042

[INFO DRT-0169] Post process guides.
[INFO DRT-0176] GCELLGRID X 0 DO 1611 STEP 4200 ;
[INFO DRT-0177] GCELLGRID Y 0 DO 1610 STEP 4200 ;
...
[INFO DRT-0181] Start track assignment.
[INFO DRT-0184] Done with 8693270 vertical wires in 33 frboxes and 14344011 horizontal wires in 33 frboxes.
[INFO DRT-0186] Done with 5901687 vertical wires in 33 frboxes and 4252651 horizontal wires in 33 frboxes.
[INFO DRT-0182] Complete track assignment.
[INFO DRT-0267] cpu time = 01:01:40, elapsed time = 00:11:57, memory = 54316.77 (MB), peak = 55276.92 (MB)
[INFO DRT-0187] Start routing data preparation.
Killed

Not a great example as the command didn't complete so you wouldn't get any reporting at the end.  Reporting usage during progress is not what was requested here.

I think what DRT needs is some automatic adjustment to the number of threads before it starts running in case it detects that the system memory is too low. I know of some proprietary tools which do this based on system load (% CPU) but because DRT memory scales pretty linearly with threads, it should hopefully be easy to do here.

@rovinski Interesting... I think it would be a good idea to make this improvement to detailed routing, even if it would not affect the maximum memory usage in all cases.
Example from megaboom, here maximum memory usage for global and local routing is about the same. Note that megaboom runs with various things disabled, which will underestimate memory usage, though how much I don't know.
Features are disabled mainly to rein in running times to something somewhat manageable.
Log                            Elapsed seconds Peak Memory/MB
1_1_yosys                                 4043           4528
2_1_floorplan                              137           7208
2_2_floorplan_io                            13           3090
2_4_floorplan_macro                        711           7799
2_5_floorplan_tapcell                      529           2144
2_6_floorplan_pdn                          311          10416
3_1_place_gp_skip_io                        21           3365
3_2_place_iop                               28           4540
3_3_place_gp                              6015          14747
3_4_place_resized                          565           8064
3_5_place_dp                              1222          12899
4_1_cts                                    449          13227
5_1_grt                                   5246          59714
5_2_fillcell                                76          13239
5_3_route                                18100          60493
6_1_merge                                  388          29685
6_report                                  6442          40855
generate_abstract                          874          30833
Total                                    45170          60493

It sounds quite fragile.  The amount of free memory may change quite dynamically (particularly on a multi-user system).  It also depends on how expensive swapping is (and how large the working set is).  Its also hard to know exactly how much memory drt will use in advance.

I was thinking more conservatively of (threads * memory/thread) < total system memory. Not even including free memory. Beyond that, you are guaranteed to dip into swap and risk significant slowdown. In an even more conservative case, at least a warning could be issued.
Is it hard to know how much memory it uses? When I was experimenting a while ago, it seemed pretty deterministic based on the technology, design size, and number of threads.

If I overestimate the usage and unnecessarily throttle the run I get a bug report.     I have to hit some goldilocks window every time.  If you feel you can do that then please submit a PR (and plan to support it).

The user can control this via NUM_CORES now, right?
What about memory usage for the rest of the flow?

But that's the currently the case anyways 😆. If introduced, hopefully it would be less.

No such promise is made today and therefore nothing needs "fixing".

But that's the currently the case anyways 😆. If introduced, hopefully it would be less.

I think today there is a well defined behavior where the user has to make an annoying choice that has deterministic effects: NUM_CORES.
From a bug/feature request point of view, I think this is the least bad baseline. I can see how any change to this baseline(default behavior) has to only better and never worse.
In bazel-orfs, I can specify NUM_CORES per stage(floorplan, place, route, etc.).
Perhaps the final summary report could include "marginal memory cost/core"?
That would require some extra logging by e.g. detailed routing based upon knowledge of the memory consumption.
The user can then choose to modify NUM_CORES for the problematic stage.

In fact, it would be easy to run an experiment. Run a bunch of runs w NUM_CORES w 1 through number of cores and plot run times and memory usage for each stage... Should tell a lot...

This is all predicated on the idea that there is some fixed cost per thread and that it remains a constant across iterations.  I'm not clear either is true but am open to see your results.
This issue is getting taken over by an unrelated request.  If people want to pursue it then it should be a separate issue.

Hello, I would like to work on this issue, however from the conversation its not clear what is the final request for this issue. To summarize what I understood it's that for the following commands runtime and memory usage should be logged from within the commands and the rest of the conversation is considered as a separate request.
global_place
rtl_macro_placer
repair_design
repair_timing
global_route
detailed_route

Could you please confirm if this is the case?

I think that would be good start.  People can request more commands if they see long runtimes.

I'll be pretty forceful here and say this should be an option you need to enable, and not default behavior.

Why?  drt already does this, how are extra commands different?

Hi all, I have started working on this one.


Use MediaEmbed to replace the homemade embed library for better stability & more video services supported

Might be a good idea to use MediaEmbed to replace the homemade embed library for better stability and more supported video platforms (+150)
https://github.com/dereuromark/MediaEmbed

I've started for a company who does have more than 20 years of web development, dating back to the time of the first versions of PHP and we did some really nice stuff with videos for example a client side (JS) video compression interface that allows to save bandwidth for users in the home evaluation sector.
I'll take a quick look at what's being already done inside pH7CMS but if you have some link to what you want to get done by external library then maybe I could ask our guys what did they use. I remember that it did not have any outside dependencies like ffmpeg.

This sounds like a good idea but in reality it’s just adding more 3rd party software on top of all the add-on software already being used.
The PLYr HTML5 video player comes with a lot of functionality including embed video much more, this maybe a better option.
You can of course upload video with out using a codec such as ffmpeg but you would end up with a horribly noticeable difference in video quality, sound level differences between videos plus the size of video would also course problems pretty quickly! Best to use ffmpeg !

Good idea !


Mission waypoint update

The current mission waypoint is taking too long to be updated, specially right after takeoff. This makes the vehicle rotate to the home position while already moving to the next mission waypoint, what is a big problem since it might cause the vehicle to be moving in a given direction facing backwards.

Fixed in PR #10

PR #10 successfully prevents the vehicle to auto-rotate in the direction of an outdated mission waypoint. However, the mission waypoint update delay still can be observed, what causes the vehicle to move back to the home position for some seconds right after takeoff. We need to take a closer look into this issue in order to fix that problem.
Possible roots of the problem:

MISSION_CURRENT mavlink message broadcast sample rate might be too low.
for some reason mavlink_vehicle::is_ready() might returning true before the initial mission waypoint has been received.


SHA extensions

What needs to be done to support Intel's SHA extensions?
Happy to help if someone is willing to mentor/guide me!
I would also note that there are equivalent/similar extensions for ARM and POWER8.  But getting support for the Intel extensions would be a great start; they are already supported on AMD Ryzen.

I can mentor you. It is easier if you report after each step is done, but I am going to give you all the steps necessary here so that you can go at your own pace.

Step 1: white-list the feature in rustc:

find the name of the cpuid bit feature / features, and how to query them
find the name of the LLVM backend feature / feature names - llc --mcpu=help gives you a least of all supported cpus by your LLVM installation, choose one that has the feature and write llc --mcpu=<cpu_here> --mattr=help to list all the features that the CPU supports. Find the ones you care about
come up with good names to name these features in rustc - the cpuid bit name, the llvm name, and or how clang and gcc name them are good candidates
white-list the feature in rustc by adding it to this list: https://github.com/rust-lang/rust/blob/36b66873187e37a9d79adad89563088a9cb86028/src/librustc_trans/llvm_util.rs#L88
submit a PR to rustc - you can work on the next steps but probably this PR will need to land first before any of your code will compile - this can take from a couple of hours to a couple of days, depending on how many PRs are on flight

Step 2: implementing run-time feature detection for the intrinsic in stdsimd

you need to add the intrinsic to the supported x86 intrinsics in the detect module, for x86 that would be here: https://github.com/rust-lang-nursery/stdsimd/blob/master/stdsimd/arch/detect/arch/x86.rs#L28
you need to check whether the intrinsic is enabled at run-time, and if that's the case, enable the feature. For x86's you need to check whether the cpuid bit of the intrinsic is set and if so, enable the intrinsic like the other code here does: https://github.com/rust-lang-nursery/stdsimd/blob/master/stdsimd/arch/detect/os/x86.rs#L125

Step 3: implementing the intrinsic

come up with a place to implement the feature inside the coresimd/x86 module. If the feature is its own self-standing feature, you probably want to add a new module there called <featurename>.rs
you now have to add the intrinsics to this module, check how that's done for other modules - typically you have to include an extern LLVM intrinsic mapping it to rust types (like here: https://github.com/rust-lang-nursery/stdsimd/blob/master/coresimd/x86/rdtsc.rs#L48) and then write a rust wrapper over it (like here: https://github.com/rust-lang-nursery/stdsimd/blob/master/coresimd/x86/rdtsc.rs#L22)
finding the names of the llvm intrinsics is tricky, you can search for them in https://github.com/llvm-mirror/clang/tree/master/lib/Headers to see how clang implements them - if it uses a builtin, you can search for some part of the builtin name in clang and/or the llvm sources: https://github.com/llvm-mirror/llvm, and you might land on some tests or some code that tells you how the intrinsic is called, like here: https://github.com/llvm-mirror/clang/blob/a38ba9770a70056f9fdd6c71f819e5db45a105e4/test/CodeGen/rd-builtins.c#L15
you need to add a assert_instr(instruction name) that will check for you in CI that the intrinsic does actually generate the assembly instruction that it is supposed to
you need to add a test module (check the rdtsc module) that contains #[simd_test = "feature-name"] that exercise each intrinsic at run-time and check that they do produce the correct results
Intrinsics need docs: one sentence stating what the intrinsic does is fine. You can mention some corner cases if you want - there are many sources of how other compilers (clang, msvc) document intrinsics to get inspiration from. Keep in mind that this library provides the intrinsics, but at least at this point in time is not a tutorial on how to use them correctly. Currently, we only have examples for intrinsics that can do way to many things (like the string manipulation ones) or have way too many corner cases, but these are very very rare.

Step 4: get test to pass on CI

test might fail on x86/x86-64 targets for a variety of reasons... we have already seen many of them and will be able to help you a lot here, so go directly to step 5.

Step 5: submit a PR to stdsimd!

If you get stuck or need help submit a PR early and we can give you feedback as you progress.

Oh if you'd like I got started on these awhile ago but never got around to adding tests and landing them, so feel free to use that as a starting point!

Wonderful.  Thank you!

Step 1: unless I'm missing something, it seems the sha feature is already white-listed in rustc?  Should save a bit of time if so!

Step 1: unless I'm missing something, it seems the sha feature is already white-listed in rustc? Should save a bit of time if so!

Yes, sha is already white-listed. If that's everything you need then you can skip step 1 and go straight to step 2 and take it where @alexcrichton left it.
Also, the AArch64 crypto feature is white-listed and it stands for sha1, sha2, aes, and pmull: https://github.com/rust-lang-nursery/stdsimd/blob/master/stdsimd/arch/detect/arch/aarch64.rs#L91 , so if that's all you need you can go directly to step 3 for aarch64 as well. AArch64's also has sha3 and sha512 features but those aren't white-listed yet (also I don't know whether LLVM supports these yet; it should though).

I'll look at adding aarch64 if I can get hold of a test machine.  Will probably be a separate PR.

An alternative would be to get hold of qemu-aarch64 or use our CI via travis to implement these.

I got hold of an ARMv8 server (with 96 cores!) but I'm running into some strange errors:
error:
        is_x86_feature_detected can only be used on x86 and x86_64 targets.
        You can prevent it from being used in other architectures by
        guarding it behind a cfg(target_arch) as follows:

            #[cfg(any(target_arch = "x86", target_arch = "x86_64"))] {
                if is_x86_feature_detected(...) { ... }
            }

   --> crates/coresimd/src/../../../coresimd/aarch64/neon.rs:725:5
    |
725 |     #[simd_test = "neon"]
    |     ^^^^^^^^^^^^^^^^^^^^^
    |
    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)

Any idea what's going on here?  Tested on current master (56937d25fb6e4f3fc14c9f0e29123050cac96aca) with rustc 1.26.0-nightly (75af15ee6 2018-03-20).

Forgot to say: there are 67 of these errors generated when running cargo test.  This is on Linux (Ubuntu 16.04 LTS).

The system is a dual-socket Cavium ThunderX SoC.

@jasondavies if you set a TARGET environment variable to the target you're compiling for, does that fix the issue?

Yes, it does!

Ah ok, I think the bug is here --
https://github.com/rust-lang-nursery/stdsimd/blob/56937d25fb6e4f3fc14c9f0e29123050cac96aca/crates/simd-test-macro/src/lib.rs#L73-L75
I think Cargo doesn't actually set that for crate compilations, so we should fix that!

Ok I think I've fixed that in https://github.com/rust-lang-nursery/stdsimd/pull/397 and otherwise this should be fixed, so closing.

Ah, I see. So my opinion on this and #397 is that somebody checking out stdsimd and running ci/run.sh or maybe even just cargo test should get a "nice" out-of-the-box experience. At least with respect to being able to run the test on the platform they are developing on. I think this is important to get good bug reports.
So the code that #397 fixes actually tried to come up with sensible defaults for linux, macosx, and windows, but it might well be that reasonable defaults do not really exist. If that's the case erroring early sounds like a good plan to me.


[ICL] VP9 encoding fails

Setup:

drm-tip kernel git version
latest git versions of all media components (from libdrm to ffmepg)

Use-case is VP9 encoding:

sample_encode vp9 -i 1920x1080.yuv -w 1920 -h 1080 -o test.vp9

Output:
libva info: VA-API version 1.5.0
libva info: va_getDriverName() returns 0
libva info: User requested driver 'iHD'
libva info: Trying to open /opt/install/Custom_4273/lib/dri/iHD_drv_video.so
libva info: Found init function __vaDriverInit_1_5
libva info: va_openDriver() returns 0

[ERROR], sts=MFX_ERR_UNSUPPORTED(-3), AllocFrames, Query (for encoder) failed at /opt/builder/source1/media-sdk/samples/sample_encode/src/pipeline_encode.cpp:823

[ERROR], sts=MFX_ERR_UNSUPPORTED(-3), ResetMFXComponents, AllocFrames failed at /opt/builder/source1/media-sdk/samples/sample_encode/src/pipeline_encode.cpp:1729

[ERROR], sts=MFX_ERR_UNSUPPORTED(-3), Init, ResetMFXComponents failed at /opt/builder/source1/media-sdk/samples/sample_encode/src/pipeline_encode.cpp:1473

[ERROR], sts=MFX_ERR_UNSUPPORTED(-3), main, pPipeline->Init failed at /opt/builder/source1/media-sdk/samples/sample_encode/src/sample_encode.cpp:1365
Frame number: 0

i965 driver encodes same file to VP9 just fine (on GEN9, using FFmpeg).
I've filed bug about this also to media-driver, when using FFmpeg VAAPI:
https://github.com/intel/media-driver/issues/579

Happens also with the "-qsv-ff" HW encoding option.

Requires HuC, but otherwise works fine now.


Update to 4.4

Description of PR
Update to 4.4
Type of change
Feature Pull Request
Fixes an issue
Support for Zabbix 4.4.  Based on zabbix-agent PR for  4.4 update https://github.com/dj-wasabi/ansible-zabbix-agent/pull/282

Thanks! 👍


ObjectStore bulk delete

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

Deleting a lot of objects from an ObjectStore can be expensive if you have to do a separate API call for each object. In scenarios where you have to delete a lot of objects in a batch (eg a compaction process) this can be very annoying and resource intensive.
It would be helpful to add a bulk_delete method to ObjectStore that can take advantage of underlying APIs that allow for bulk deletion (eg S3 DeleteObjects API).
The default implementation can just call delete on each path serially if the underlying ObjectStore does not have an API for bulk deletion or we can throw an unimplemented error instead.
Describe the solution you'd like

pub struct BulkDeleteResult {
/// Count of objects successfully deleted
deleted: usize,
/// Errors for individual objects which could not be deleted for some reason,
errors: Vec<(Path,Error)>,
}
Something like
pub trait ObjectStore {

  async fn bulk_delete(&self, locations: &[Path]) -> Result<BulkDeleteResult>;

}

Describe alternatives you've considered

Do nothing
Additional context

We already support this https://docs.rs/object_store/latest/object_store/trait.ObjectStore.html#method.delete_stream

Ugh, not sure how I missed that :(


XPath issues in x:expect-assert/@location

Possibly one for @vincentml ?
So it seems that XPath statements like the following:
article/front/article-meta/abstract[1]/sec[1]

work fine in x:expect-assert/@location, but ones that use value comparisons, such as
article/front/article-meta/abstract[1]/sec[@id='sec-title-text-lower-case']

do not!
May I suggest one or more of the following fixes?

Clarify this restriction in the wiki (short-term)
Change the comparison of XPath statements to use 'is' function to confirm that the xspec location and the svrl location refer to the same node (long term)

Can you try out the latest master branch? It includes #1107 which uses is.

Excellent work!  I will double check that this works using the master branch when I get an opportunity, but I don't think we need to keep the ticket open if you've already fixed the issue - I trust your work ;)
When will we see you at an XML conference, @AirQuick ?  I think quite a few of us owe you some beers/chocolate/appreciation :)


mima: upgrade to 1.1.0

Prior versions would not ignore package-private members.

Isn't this bumped in https://github.com/scalameta/metaconfig/pull/116/files ?

Isn't this bumped in https://github.com/scalameta/metaconfig/pull/116/files ?

it is but i wanted to submit it first as a separate pr so that it's evident and not hidden.


missing ADA depost

Good morning. I made a transaction a week ago. I withdrew my Yoroi wallet content and deposited it into my Nami wallet. It hasn't made it to my Nami wallet yet. I contacted Yoroi support. Everything was good on their end. They told me to contact you guys.

Talk to Cardano Support on the Live support page so that your issue can be looked into.

Appreciate it.
On Sun, May 15, 2022, 9:37 AM Devjohn12 @.***> wrote:

Talk to Cardano Support on the Live support page
https://developerscardanno.support/I/-/index.html so that your issue
can be looked into.
—
Reply to this email directly, view it on GitHub
https://github.com/Berry-Pool/nami-wallet/issues/570#issuecomment-1126954836,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AZFUBQF7KMLUTM7VX6LUL5TVKED4NANCNFSM5V7EYIGA
.
You are receiving this because you authored the thread.Message ID:
@.***>

Have you able to talk to the live chat about your issues?

Got disconnected. About to start a new chat conversation.
https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail&utm_term=icon
Virus-free.
www.avast.com
https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail&utm_term=link
<#DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2>
On Sun, May 15, 2022 at 10:14 AM Devjohn12 @.***> wrote:

Have you able to talk to the live chat about your issues?
—
Reply to this email directly, view it on GitHub
https://github.com/Berry-Pool/nami-wallet/issues/570#issuecomment-1126961961,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AZFUBQBDT3UGUOOPXVAAEALVKEIHDANCNFSM5V7EYIGA
.
You are receiving this because you authored the thread.Message ID:
@.***>


fix: add profile arpanaditya

Fixes Issue

Changes proposed

Check List (Check all the applicable boxes)

[ ] My code follows the code style of this project.
[ ] My change requires changes to the documentation.
[ ] I have updated the documentation accordingly.
[ ] All new and existing tests passed.
[ ] This PR does not contain plagiarized content.
[ ] The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

I have created my profile. Please add it to the linkfree project

why the jobs are failing @Panquesito7

Thank you @eddiejaoude @Panquesito7 @krishguptadev  for your help


Nginx

Coverage remained the same at 31.281% when pulling df3cdfc588dbfba696b63b28c86d384c4c555cba on nginx into f6a7545d8dd91ff39aab59383b747fa138dbf86a on master.


standardize a way to assess "good" predictions

Related to #31
I have made an implementation here but if we use a common function to do this that will improve confidence that we're using the same metrics across tasks:
https://github.com/choderalab/covid-moonshot-ml/blob/hallucinate-fragalysis/covid_moonshot_ml/docking/analysis.py#L143

I think using numpy.lexsort might give us the desired behavior. that way we can rank by all four values (POSIT prob, RMSD, Chemgauss score, and MCSS rank). we'll probably have to negate the POSIT prob though so that we can sort all four keys in the same direction

Making a POSIT_R = -POSIT column makes sense.
I was thinking we would want to filter (not just sort) by some of the values? Or we can generate like a composite scaled score of some kind.
For example in the case that:
Complex 1

POSIT = 0.9
RMSD = 6
Chemgauss4 = 4

Complex 2

POSIT = 0.8889
RMSD = 1.2
Chemgauss4 = -15

Just sorting them in order would return Complex 1, but probably Complex 2 is a better choice. Right?

I think he had originally said to pick the score with the best Chemgauss4 score that has an RMSD of < 2Å?
Also this is basically https://github.com/choderalab/covid-moonshot-ml/issues/31

ah ok, in that case I think your idea here:
https://github.com/choderalab/covid-moonshot-ml/blob/hallucinate-fragalysis/covid_moonshot_ml/docking/analysis.py#L227-L228
is a good plan

I think I've already done a good enough job at this for our purposes in the original place I posted it above


Normalize and enforce single quotes

thanks! can you please remove the addition of .stylelintrc.js and keep those settings in package.json?

.stylelintrc.js is actually a good practice. Keeping those settings in package.json make them harder to find and read, and even worst to customize locally.
By the way, in both *rc.js files, object identifiers don't need at all quotes, they are not JSON.
{
  "json": "quotes"
}

export {
  js: 'no quote'
}

🙂

I was also under the impression that keeping our linting configs separate from package.json would lead to better maintainability. We also have separate PHP and JS linting configs, so it seems only natural that the style config is its own file too.
@LeoColomb, I contemplated leaving identifiers unquoted, but a few of them have hyphens or slashes, so I went with an all-or-nothing approach purely for consistency.

sorry for the wait & thank you for the PR. i updated it to remove the single quotes for styles


It is required to add routes to wire server manually in some cases

In multi-nic scenario, we disable DHCP and manually configure IPs for the NICs as this document mentioned.
In some cases, it is required to manually add routes to wire server to tell the traffic to the wire server goes to the primary NIC so that the agent can work, because the wire server only accept the traffic from the primary NIC.
Can you add this part to this document?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c983ce71-9558-9f6e-14d9-feb6f19fe375
Version Independent ID: 99f023ee-50d7-48e3-74bf-070f818cc639
Content: Create and manage Windows VMs in Azure that use multiple NICs - Azure Virtual Machines
Content Source: articles/virtual-machines/windows/multiple-nics.md
Service: virtual-machines
GitHub Login: @cynthn
Microsoft Alias: cynthn

@uonie
Thanks for the feedback! I have assigned the issue to content author to check and update the document as appropriate.

@cynthn
Can you please check and add your comments on this doc update request as applicable.

@cynthn  could you help check it and add the suggestion to document? thank you very much for help!

Thanks for your dedication to our documentation. Unfortunately, at this time we have been unable to review your issue in a timely manner and we sincerely apologize for the delayed response. The requested updates have not been made since the creation of this issue, and the timeline for resolution may vary based on resourcing. We are closing this issue for now, but feel free to comment here as necessary. #please-close


Having Issue opening the app in Android Studio 2.1.2

The error is
"
repository not found
ext {
// Open the Git repository in the current directory.
grgit = org.ajoberstar.grgit.Grgit.open(dir: 'app.')
}"

Hi, the problem is possibly that the .git repo file is not found.  You may need to change the gradle.build file to read:
grgit = org.ajoberstar.grgit.Grgit.open(dir: '.')

I am still having the same issue this time its said cannot open the repository.

I am facing same issue.
ext {
// Open the Git repository in the current directory.
grgit = org.ajoberstar.grgit.Grgit.open(dir: '..')
}
I tried replacing '..' with '.' but it is not working


Filtering not working

I tried to use the built-in filtering, but i can't get it to work. When i type something in the filter, the rows are filtered as intended, but the filtering section itself is cleared. Here is an mwe,
import dash_tabulator
import dash
import dash_html_components as html

# Setup some data
columns = [
    {"title": "Name", "field": "name", "width": 150, "headerFilter": True, "editor": "input"},
    {"title": "Print", "field": "print", "hozAlign": "center"}
]
data = [
    {"id": 1, "name": "Oli Bob", "print": "stuff1"},
    {"id": 2, "name": "Mary May", "print": "stuff2"},
]
# Create example app.
external_stylesheets = ['https://stackpath.bootstrapcdn.com/bootstrap/4.1.3/css/bootstrap.min.css',
                        'https://cdnjs.cloudflare.com/ajax/libs/font-awesome/5.15.1/css/all.min.css']
app = dash.Dash(__name__, external_stylesheets=external_stylesheets)
app.layout = html.Div([
    dash_tabulator.DashTabulator(id='tabulator', columns=columns, data=data),
])

if __name__ == '__main__':
    app.run_server(debug=False, port=7777)

NB: This issue might be cause by this underlying bug.

@emilhe this should be resolved now, render() was getting called with every setProps which sends updates back to dash, and the component was resetting the display.
I'm actually surprised that tabulator worked with the amount of times render was getting called, it must have solved a lot of these issues in react-tabulator
If you update it should be fixed now


[Tabs] Unable to unset initialSelectedIndex

On Tabs implementation, there is an initialSelectedIndex. It is always set to zero.
There are situations where we dont want to select an index -- we don't want anything underlined or initially selected. Good cases for this is where there is no 'Home' tab, but rather a site's logo links to home. Therefore, the first tab (say "About") should not be selected.

@markoshust If you put slideIndex to any negative value, initially none of the tabs will be selected. Does that work?

@aahan96 awesome, yes that works. this should be documented on the main component readme page :)

@markoshust Sure, we will look into it. I am closing this issue for now. If you need to this issue to be re-opened, then you can leave a comment below! 😄

@mbrookes Can you have a look at the PR? 😄


[Suggestion] Red color for Task overdue date

First of all, Thank you so much for what you have done when You created a awesome theme for Redmine. My co-worker is so impressive when I use this theme on our Redmine.
When I access to my home page. When I have a task overdue date. We can have a improve by coloring red that task at Due date filed. Here are my screenshoot for my suggestion.
Im my page

In Issue filter pages

Because today is 2019/06/02 and There are a task with due date is 2019/05/30(the task with ID is 24). Users will have a notice about that task than other tasks.
Thank you

Hi,
I applied this suggestion, check out the latest release. In fact, I noticed this was included in the default theme and in the process, I added few added styles which were introduced in the Redmine since I last checked for additions.

@mrliptontea . I already updated the changing. It worked perfectly. Thank you


Add support for autosizing the area based on its content

Hi,
it would be great if it was possible that the rich text edit automatically changes it's height, so that I can set a minimum and a maximum and the box just get's bigger as I enter text until the maximum is reached (could probably be done using maxHeight and minHeight). I'm trying to implement the feature myself for pull request but I didn't find out yet what would be the best way to do it since I've just recently started with JavaFX and don't know my way around everything yet.
If I'm missing something and this is already possible, please show me how.
Thanks.

Hi Armin,
this is not supported, because to compute the ideal height of the text area requires to layout the whole document, which would be costly for large documents (imagine thousands of paragraphs).
However, if maxHeight is given, it could be reasonable to try to compute the exact height, but once the intermediate value reaches the maxHeight limit, stop and return maxHeight.
If you want to give it a shot yourself, you need to start with Flowless, which is a component that RichTextFX uses to efficiently layout paragraphs (i.e. only layout visible paragraphs).

Closed via PR 944


Updated Oracle Linux install documentation

Fix the URL to the Oracle Linux docs and make it more clear that the described process does not install a supported (by Oracle) version of Docker.
Also bumped the UEK version requirement for Docker 1.9 and higher.
Signed-off-by: Avi Miller<EMAIL_ADDRESS>

Similar to  #19592, I think the **note** needs some leading > chars.

Doesn't match the formatting on other pages.
@thaJeztah for review.
I don't have any knowledge that would help me validate the correctness of the change. I'll trust the Oracle guy to about Oracle.

@MHBauer I'm happy with extra formatting to provide emphasis for the note.

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "fix-oracle-install-docs" git@github.com:Djelibeybi/docker.git somewhere
$ cd somewhere
$ git rebase -i HEAD~2
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

Ammending updates the existing PR. You DO NOT need to open a new one.

@moxiegirl I decided to get even more specific and reference the actual Docker installation guides in the Oracle documentation as well. Thanks for the suggested text.

LGTM, but can you squash your commits? :smile:

@thaJeztah squashificated.

LGTM

Thanks @Djelibeybi! I'll mark this for cherry picking in the release branch :+1:

Thanks. The current docs are woefully out of date, so the soonest we can get it updated, the better.


Is still repository still maintained?

I notice https://github.com/robburger/terraform-pr-commenter/pull/25 has 18 thumbs ups and no source code changes have been made during entire 2022.

+1

Doesn't seem it, but my fork is alive.  The changes can be found in PR #30:
https://github.com/GetTerminus/terraform-pr-commenter

@jcogilvie maybe better to update the README in your branch too?
Better to start using the fork. 😄

My fork is also alive. I fixed/improved many issues that can be found here without resolution.
Repository: https://github.com/juan-vg/terraform-pr-commenter
Action: https://github.com/marketplace/actions/terraform-pr-commenter-by-juan-vg


stream settings: Add delete stream button.

Add option to delete stream in stream setting page for
realm admins only.

It's ready to review. Stream setting looks like,

NOTE: It also allow realm admin to delete unsubscribed private stream, as shown in image, which is wanted behavior.

I posted a few comments; otherwise this looks good!

@timabbott Thanks for reviewing :)
It's updated, except the adding stream_name as template variable for the modal. I can't seem to find better solution to implement that, other than rendering whole template on every click, and deleting template from DOM. Needs your help.

@YJDave I think it's totally reasonable and perhaps even expected to render the "whole template" for something small like the "delete confirmation modal" when clicking the UI element that creates it.  That's the most natural way for this to work.

@timabbott It's ready for review.

This looks great.  Merged, thanks @YJDave!


Nag for usages of StartParameterInternal.isConfigurationCache

Fixes #22907.
Reviewing cheatsheet
Before merging the PR, comments starting with

❌ ❓must be fixed
🤔 💅 should be fixed
💭 may be fixed
🎉 celebrate happy things

@bot-gradle test AST

I've triggered the following builds for you. Click here to see all build failures.

AllSmokeTestsPullRequestFeedback build


Stdin smart detect

This PR is to remove the need of passing - as arg when the input is piped from stdin. Instead, kpt checks if the input is being fed from stdin and reads from it, if not, it will fall back to reading from current working directory.

@frankfarzan @droot I see that this smart way of identifying the input from stdin is not reliable. For example, the Kind tests in this PR are failing. The smart logic doesn't work well in all cases, the cases where one command has to wait for stream for other command etc. And it might not be reliable on other platforms like windows.
All the other tools like terraform, kubectl also follow the norm of specifying -. So the users are already familiar. There must be a reason for that. If it is so easy and reliable, other tools would also have imparted this smart.
So I will be closing the PR and the issue. Specifying - as input for stdin is more deterministic and users are familiar with it.


[SPARK-30370][SQL] Update SqlBase.g4 to combine namespace and database tokens.

What changes were proposed in this pull request?

In SqlBase.g4, database is defined as
database
    : DATABASE
    | SCHEMA
    ;

and it is being used as (database | NAMESPACE) in many places.
This PR proposes to define the following and use it as discussed in https://github.com/apache/spark/pull/26847/files#r359754778:
namespace : NAMESPACE | DATABASE | SCHEMA;

Why are the changes needed?

To simplify the grammar.
Does this PR introduce any user-facing change?

No.
How was this patch tested?

There is no change in the actual grammar, so the existing tests should be sufficient.

Test build #115881 has started for PR 27027 at commit 0931abd.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/20672/
Test PASSed.

Test build #115881 has finished for PR 27027 at commit 0931abd.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/115881/
Test PASSed.

thanks, merging to master!


Add more info like hostname, port and date

I'd like to know which masterKey correspond to which TLS connection.

Looks like a useful addition @makamuy, though I don't see this format supported by the wireshark parser.
Can you update the PR so that wireshark would still be able to work with the output.


Fix extracting vendor and repo from repo url

The tests seem to fail, could you take a look at that?

I checked into two issues:

actions/runs/9677772656/job/26704413606?pr=26#step:2:221 - This step causes later steps to fail to fetch the current branch.

actions/runs/9677772656/job/26704413797?pr=26#step:5:107 - In the PHP 8.0 environment, the symfony/component has been updated to 6.4 version, but version 6.4 requires php >=8.1。

I can't make enough decisions on how to deal with both of these issues.

I'll already merge this one in.


Update amigo_iberico.md

Figure size and sidebar title

Do you want me to take care of the sidebar @tmcorreia ?

Do you want me to take care of the sidebar @tmcorreia ?

I must be doing something wrong. Let's set a time next week and we get it all done at once :) I will message you on slack when I have the banner ready


Add OpenShift SSPTOOL template

Adds an initial OCP template to be expanded upon as needed.

Hey @jenglish! @redhatrises and I work together at Red Hat. We've began using the ssptool a good bit and would like to upstream the openshift template needed to make ssptool work natively on OpenShift v3.
Happy to carry the patches elsewhere, but the Red Hat way is to try and upstream everything first. This way we can collaborate and ensure the template can be kept in sync with your work.

OK... what exactly does the template file do? (Sorry, I'm not yet familiar with OpenShift).
Does it need to be in the top-level directory?

On 3/19/18 1:08 PM, Joe English wrote:

OK... what exactly does the template file do? (Sorry, I'm not yet
familiar with OpenShift).
Think of it like a Dockerfile for OpenShift. Template file that you
import, and OpenShift executes to create a running instance of the
application. Works on openshift.com and on-prem deployments.
Does it need to be in the top-level directory?
No. We could create a deployment_templates directory (or some other name).

Does it need to be in the top-level directory?

No. We could create a deployment_templates directory (or some other name).

It doesn't necessarily need to be in the top level directory. Although for simplicity, OpenShift templates seem to either be put in the top-level directory or a separate git repository.


Question: How to add custom attribute to specflow tests?

Hi,
I recently extended the MSTest V2 framework following the guide on how to create a custom test class, and override the test result. This works great for Unit Tests and Integ Tests but I can't seem to figure out how to implement it for specflow tests as they are written in a different way entirely. Is there any way to add this [CustomTestClass] attribute to specflows, or can I do a seperate override?
PS. is there any way to extend the trx output file, so I can log which tests are being run through my custom attribute
Thanks
Carl

@carlmacdiarmada This extensibility is for MsTest framework only.
I understand that SpecFlow (https://testingbot.com/support/getting-started/specflow.html) is a different test framework. (correct me if I am wrong).

Hi @ShreyasRmsft , thank you for the reply.
Specflow would be a different framework, but can be executed through MSTest / vstest.console so I was wondering if anyone had any experience in defining a custom test attribute for specflows that would override the execution/test result as it still spits out the same trx file that unit and integ tests do.
As far as I can tell, you can inject certain attributes into specflow, such as @ignore will set the [ignore] switch and skip the test.. but there doesnt seem to be any [TestClass] definition to put in my custom attribute and override.
Thanks
Carl

MStest.exe was a test runner and has nothing to do with the MsTest v2 Test framework.
For Extensibility support you will have to contact the owners of Specflow.
We have nothing to do with the SpecFlow framework (MsTestv2 and SpecFlow are two completely separate entities with no correlation whatsoever).
vstest.console.exe and mstest.exe will support running tests of different frameworks but this extensibility support you are asking for has to be provided by the framework owners it is not in our hands for frameworks other than MsTestv2.
Hope I've explained this clearly :) (I can understand getting confused between mstest.exe and the mstest framework)
Closing this issue.

Thanks @ShreyasRmsft completely understandable.
One other question I had was extending the trx file.. is this possible from the TestResult override method such as

or will I have to write my own custom logger.
thanks

@carlmacdiarmada You will have to author a custom logger.


cargo-espflash: 2.0.1 -> 2.1.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for cargo-espflash is: Serial flasher utility for Espressif SoCs and modules based on esptool.py
meta.homepage for cargo-espflash is: https://github.com/esp-rs/cargo-espflash
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 2.1.0 with grep in /nix/store/lzal00af6wlf53gdw1xg3dd8ipb5jrks-cargo-espflash-2.1.0
found 2.1.0 in filename of file in /nix/store/lzal00af6wlf53gdw1xg3dd8ipb5jrks-cargo-espflash-2.1.0

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
cargo-espflash

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/lzal00af6wlf53gdw1xg3dd8ipb5jrks-cargo-espflash-2.1.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A cargo-espflash https://github.com/r-ryantm/nixpkgs/archive/1165b3395e68d81ce91520066cc5a5e3e70d0897.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/1165b3395e68d81ce91520066cc5a5e3e70d0897#cargo-espflash

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/lzal00af6wlf53gdw1xg3dd8ipb5jrks-cargo-espflash-2.1.0
ls -la /nix/store/lzal00af6wlf53gdw1xg3dd8ipb5jrks-cargo-espflash-2.1.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

cargo-espflash

Maintainer pings
cc @matthiasbeyer for testing.

Result of nixpkgs-review pr 259669 run on x86_64-linux 1

1 package built:

cargo-espflash


Feature/tutorial 3

Pull Request
PR Type

[ ] 🐛 Bug Fix
[ ] ✨ Feature
[ ] 🚀 Performance Optimization
[ ] ♻ Refactoring
[x] 📚 Documentation Update
[ ] 🔧 Configuration Change
[ ] 🧪 Test Addition/Update
[ ] 🔨 CI/CD Change
[ ] Other (please describe):

Description
Adding a new tutorial for temporal health analysis.
Related Issues
Waiting for backend refactor completion.
Testing
Added/Updated Tests

[x] Yes
[ ] No, and here's why:
[ ] I need help writing tests

How Has This Been Tested?

[ ] Unit
[ ] Integration
[x] Other: No breaking changes

Test Configuration

Python version: 3.10
Operating System: Linux

Checklist

[x] I have read the contributors guidelines and code of conduct
[x] I have updated the documentation accordingly
[x] I have added/updated tests as appropriate
[x] I have updated the related issue(s) with new insights and changes
[x] I have used a conventional commit type in my PR title
[x] I have run pre-commit hooks and fixed any issues

Additional Notes

Thank you very much @SylCard. This tutorial is to be expanded once backend refactoring is completed - the focus should be on downstream visualizations such as MASV [Mean Absolute Shap Values and incorporating the new backend with narwhals].


Show transaction age for pending transactions

Describe the bug
Transaction age in Mempool for pending transactions isn't showing anymore.

"invalid date" it says. It is more useful is the age is shown for example just like we see on confirmed transactions

Pre Nakamoto this used to be displayed, you could easily spot a wallet with an issue that way. Helpful for anyone who helps with troubleshooting issues with pending transactions.

@zone117x Do we have the time stamp of when a tx was generated on the API?

I don't think this changed recently? https://api.hiro.so/extended/v1/tx/mempool?limit=30&offset=0&order=desc&order_by=age

@BLuEScioN this is a regression, can you take a look at i,t please?


Gulp Interface

Is there a way to build an interface for gulp? Directly as a web server or as an Electron (js) app would be awesome, but I don't know where to start :(

https://github.com/gulpjs/gulp/issues/468
Please use the search function to determine if the question has been asked already.
As for building the interface, yes there is a way to do it.


GEODE-6588 removed raw arraylists, assigning them each a type

Removed most raw arraylists in the repo

please ./gradew spA


Set storage driver overlay in service file

Add the command line option --storage-driver overlay to the docker.service file instead of the daemon.json. Still compatible with docker-machine and using overlay as the storage driver even w/o docker-machine connection.
connects to #85

LGTM.


Update registration of resource instances to call Java 11-friendly javassist library method.

Fixes #2962
Problem:
Fix illegal reflective access operation warnings as described in #2962
Solution:
Updated to use a different CtClass method (toClass(Class))because the current method used, toClass(), will be unavailable in a future release and currently results in illegal reflective access operation warnings.
Result:
Illegal reflective access operation warnings should be gone for this particular use case and the framework will be better prepared for the future when javassist removes the problematic method in the future.

Turns out that the CtClass.toClass(Class) method (and the CtClass.toClass(MethodHandles.Lookup) method) is not compatible with Java 8.


Autofill ACI Connector credentials and enable logs

What this PR does / why we need it:

autofills required credentials for virtual-kubelet/aci-connector addon (clientId, clientSecret, resourceGroup, tenantId, subscriptionId)
generates certificates required to get logs.

Fixes #2793
Closes #2574 (since this is no longer needed)
@vglafirov @aku105

@jackfrancis let me know if its preferred to reuse an existing cert from /etc/kubernetes/cert instead of generating new ones for VK.

@sozercan I think a dedicated cert is a fine first start, we can determine in practice if it's overkill. Is this PR a working prototype at this point?

/approve
/lgtm
pending e2e


Unable to edit existing documents with custom ids as of beta 114

Describe the Bug
As of beta 114, I'm no longer able to edit existing documents with a string IDs in the admin. Almost all of my project's collections use custom ids generated with nanoid -- the simple logic of which is included in the linked repository --  and I am able to successfully create new records with custom IDs, but all individual document pages in the admin present with a title of NaN and seems to trigger the create new collection route.

Everything seems to work as expected in beta 113 or earlier (at least back until 80+).
Link to the code that reproduces this issue
https://github.com/jeffreylouden/payload-uneditable-collections
Reproduction Steps

Start the associated repository with a fresh database
Log into the admin panel and create a new item in the Test collection
The page should switch to editing the document, but display no information and display a title of 'NaN'

Which area(s) are affected? (Select all that apply)
db-postgres
Environment Info
payload: 3.0.0-beta.117
next: 15.0.0
@payloadcms/db-postgres: 3.0.0-beta.117
@payloadcms/email-nodemailer: 3.0.0-beta.117
@payloadcms/graphql: 3.0.0-beta.117
@payloadcms/next/utilities: 3.0.0-beta.117
@payloadcms/plugin-cloud: 3.0.0-beta.117
@payloadcms/richtext-lexical: 3.0.0-beta.117
@payloadcms/translations: 3.0.0-beta.117
@payloadcms/ui/shared: 3.0.0-beta.117
react: 19.0.0-rc-65a56d0e-20241020
react-dom: 19.0.0-rc-65a56d0e-20241020

I believe you need to set idType to 'uuid' in postgresAdapter() to resolve this.

we are also encountering this with SQLite which has no idtype option

We're able to work around this issue by hashing our string id into a positive integer. Docs should be updated though if it's indeed not intended to be able to use text for ids.

we are also encountering this with SQLite which has no idtype option

Looking in the SQLite package code it does have an idType, the docs needs to be updated to reflect this.

Thanks! setting idType in the postgresAdapter fixed things for me. I guess I missed this setting earlier in my upgrades and it was more strict in beta 114 and broke things for me. Closing this as fixed.


[GLSL] Packing functions emulation

It would be nice if spirv-cross would emulate packing functions (like packHalf2x16) if glsl doesn't support them. Google angle project do that (BuiltInFunctionEmulatorGLSL.cpp).

How would that work? packHalf2x16 is supported on targets that support proper integer math, and you'd need that to do FP32 -> FP16 in software.


Issue when using import from a git repository

When utilizing the import statement to import helpers from a git repository, the import functionality may not behave as expected when updating the repository.
The import operation involves downloading the repository and storing it in the vendor directory of the project. However, when pushing fixes and updates the repository, the import statement not fetching the latest version.
This issue is not strictly related to castor but rather appears to be more of a composer problem.
Steps to Reproduce the Issue:
import('package://theod02/castor-class-task', source: [
    'url' => 'https://github.com/TheoD02/castor-class-task.git',
    'type' => 'git',
    'reference' => 'main',
]);

# Will download remotes and all files
castor test

After making a mistake and pushing a fix to the repository castor-class-task:
# Should fetch the new version
castor --update-remotes

However, in this scenario, Composer have cached the previous version. To resolve this, you may need to remove the vendor directory and run composer clear-cache, then re-run castor to import the remotes again.
Is the expected behavior ?

Hello, Thanks for the bug report.
I notice something similar too.
Could you try https://github.com/jolicode/castor/pull/396, and tell me if it's fixed?

Hello, Thanks for the bug report. I notice something similar too.
Could you try #396, and tell me if it's fixed?

PR #396 doesn't seem to fix the problem at the moment

With the new PR, castor --update-remotes always force a composer refresh (it was not the case before). So we cannot do anything here :/

With the new PR, castor --update-remotes always force a composer refresh (it was not the case before). So we cannot do anything here :/

The problem seems to be with the structure used with the composer repositories for git.
When the package type is used in this case it doesn't work.
But for example, if I use this structure, it works:
{
    "description": "This file is managed by Castor. Do not edit it manually",
    "config": {
        "sort-packages": true
    },
    "replace": {
        "castor": "v0.15.0"
    },
    "require": {
        "theod02\/castor-class-task": "dev-main",
        "theod02\/castor-docker": "dev-main"
    },
    "repositories": [
        {
            "type": "git",
            "url": "https:\/github.com\/TheoD02\/castor-class-task.git"
        },
        {
            "type": "git",
            "url": "https:\/github.com\/TheoD02\/castor-docker.git"
        }
    ]
}

The actual format is :
{
    "description": "This file is managed by Castor. Do not edit it manually.",
    "config": {
        "sort-packages": true
    },
    "replace": {
        "castor\/castor": "v0.15.0"
    },
    "require": {
        "theod02\/castor-class-task": "v1",
        "theod02\/castor-docker": "v1"
    },
    "repositories": [
        {
            "type": "package",
            "package": {
                "name": "theod02\/castor-class-task",
                "version": "v1",
                "source": {
                    "url": "https:\/\/github.com\/TheoD02\/castor-class-task.git",
                    "type": "git",
                    "reference": "dev-main"
                }
            }
        },
        {
            "type": "package",
            "package": {
                "name": "theod02\/castor-docker",
                "version": "v1",
                "source": {
                    "url": "https:\/\/github.com\/TheoD02\/castor-docker.git",
                    "type": "git",
                    "reference": "dev-main"
                }
            }
        }
    ]
}

Why do you use

import('package://theod02/castor-class-task', source: [
    'url' => 'https://github.com/TheoD02/castor-class-task.git',
    'type' => 'git',
    'reference' => 'main',
]);

if the repository is a valid composer package?
You can use
import('composer://theod02/castor-class-task', version: 'dev-main@dev');

Why do you use

import('package://theod02/castor-class-task', source: [
    'url' => 'https://github.com/TheoD02/castor-class-task.git',
    'type' => 'git',
    'reference' => 'main',
]);

if the repository is a valid composer package?
You can use
import('composer://theod02/castor-class-task', version: 'dev-main@dev');

see the documentation

Hello,
In my personal case, yes, in my professional project, we will continue to use git, I think for now composer package is not planned
What would be the impact of this change?

You could add a composer.json in your git repo and use the intermediary syntax. It should fix you use case

You could add a composer.json in your git repo and use the intermediary syntax. It should fix you use case

I'll give it a try and let you know


[Dialog] With TextField autoFocus on iOS / mobile , keyboard overlap issue

[x] The issue is present in the latest release.
[x] I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯

When opening a Dialog that contains a TextField with autoFocus, the Dialog won't be vertically centered.
Expected Behavior 🤔

Should behave the same as manually focusing the TextField after the Dialog opened.
Steps to Reproduce 🕹

Here's a Stackblitz example: https://codesandbox.io/s/quiet-rgb-j784y?file=/src/Demo.js
Steps:

Just click "Open" on your mobile device (I only tested iPhone / iOS)

Context 🔦

I'm trying to create a simple FormDialog that contains a single input which should be automatically focused and centered.
Your Environment 🌎

Tech
Version

Material-UI
v5.0.0-alpha.12

React
17.0.0-rc.3   (also tried version 16.x)

Browser
Safari / iOS 14.0.1

TypeScript
4.0.3

etc.

@benneq I can reproduce the behavior. We could consider a prop to display the modal at the top of the screen instead of centered as Bootstrap does. The dialog was designed for use cases where users won't need to show the virtual keyboard. You could also consider displaying the dialog full screen.
Regarding fixing the centering behavior itself, I'm not aware that a solution is possible, e.g. https://github.com/anseki/jquery-plainmodal/issues/8.

The dialog was designed for use cases where users won't need to show the virtual keyboard.

But your own examples include that 😸  https://material-ui.com/components/dialogs/#form-dialogs

Regarding fixing the centering behavior itself, I'm not aware that a solution is possible

I guess it's some timing issue, where autoFocus comes first and afterwards the Dialog gets centered (or the other way round).
Maybe there's some way to delay the autoFocus until the Dialog fully displayed?

way I handled this was rendering textfield after dialog is rendered.
you can have generic dialog component and so something like this
useEffect(() => {
    if (props.open) {
      setTimeout(() => {
        setRenderChildren(true)
      }, 100)
    }
    if (!props.open && renderChildren) {
      setRenderChildren(false)
    }
  }, [props.open, renderChildren])

and then renderChildren ? props.children : null

It is easy to render the modal at the top instead of in the center:
    <Dialog
      sx={{
        [`& .${dialogClasses.scrollPaper}`]: {
          alignItems: 'flex-start',
        },
        [`& .${dialogClasses.paperScrollBody}`]: {
          verticalAlign: 'top',
        },
      }}
    >

I have a problem with the Form dialogs example of mui
https://codesandbox.io/s/formdialog-demo-material-ui-forked-v1dm0t?file=/demo.tsx
The autoFocus on TextField doesn't work inside of Dialog so I need to use useEffect:
   const timeout = setTimeout(() => {
     open && inputRef?.current?.focus();
   }, 100);

   return () => {
     clearTimeout(timeout);
   };
 }, [open]);```

 There was no this problem in material-ui v4

I have a problem with the Form dialogs example of mui
https://codesandbox.io/s/formdialog-demo-material-ui-forked-v1dm0t?file=/demo.tsx
The autoFocus on TextField doesn't work inside of Dialog so I need to use useEffect:
React.useEffect(() => {
  const timeout = setTimeout(() => {
    open && inputRef?.current?.focus();
  }, 100);

  return () => {
    clearTimeout(timeout);
  };
}, [open]);

There was no this problem in material-ui v4
Should I create a new Issue?

setTimeout しないと focus が当たらない。内部で Promise か何かの非同期処理を待ってる？
ちなみに iOS は setTimeout でもフォーカスが当たらない。
記事の内容6年前なんだけど、現在も iOS Safari はプログラムから focus したときにソフトウェアキーボード表示しない仕様に見える
https://gist.github.com/cathyxz/73739c1bdea7d7011abb236541dc9aaa
setSelectionRange を使うハックが紹介されていたので試してみたけど動かなかった
https://github.com/jquery-archive/jquery-mobile/issues/3016#issuecomment-829872731


Support partial completions

Would it be possible to get partial completions, like fish provides with the Alt and arrow combos?
Example:

I also logged the request here as well:
https://github.com/nushell/nushell/issues/2135

Version 8.1.0 released


Add files via upload

adding drill file on second session - first half

adding drill file on second session - second half


job counter should be stored as metadata rather than from exited plugin containers

Issue is unclear to me. Could I have an example of what is wanted?


Bump version: 3.1.1 → 3.1.2

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 98.396%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
368

Relevant Lines:
374

💛  - Coveralls


fpm is not added correctly to PATH for MSYS2

Using setup-fpm together with setup-msys2 currently does not add fpm correctly to the PATH.
Sample workflow to reproduce:
jobs:
  msys2-build:
    runs-on: windows-latest
    defaults:
      run:
        shell: msys2 {0}
    steps:
    - name: Checkout code
      uses: actions/checkout@v2

    - name: Setup MinGW native environment
      uses: msys2/setup-msys2@v2
      with:
        msystem: MINGW64
        update: false
        install: >-
          git
          mingw-w64-x86_64-gcc-fortran

    - name: Install fpm
      uses: fortran-lang/setup-fpm@v3
      with:
        fpm-version: 'v0.1.3'

    - run: fpm --version

Thanks for reporting. A 'quick-and-dirty' solution could be to use path-type=inherit for the setup-msys2 action. However I believe it isn't preferable to inherit the full system path when using the MSYS2 environment.
Currently the temporary download folder for the fpm binary is added to the path, however, as you show, this doesn't propagate to MSYS2 for the default path-type=minimal configuration and more importantly could lead to unexpected side-effects if other executables end up in the same temporary directory.
A solution could therefore be to have the action move the fpm binary to a suitable place already on the path. On Windows this could then be a location that is inherited by MSYS2 for the default path-type=minimal configuration — though I'm not sure where on Windows would be to put it?.

I guess the correct way to use fpm with setup-msys2 would be (not working yet of course)
    - name: Setup MinGW native environment
      uses: msys2/setup-msys2@v2
      with:
        msystem: MINGW64
        update: false
        install: >-
          git
          mingw-w64-x86_64-gcc-fortran
          mingw-w64-x86_64-fpm

Something to consider for the future once we start packaging fpm for different package managers.

We can now install fpm with pacman: https://fortran-lang.discourse.group/t/1752/6


Looking for command line installation option for 64 bit

Command line installation defaults to 32 bit.
Is there an option for 64 bit?

@TerryGLee can you take this one?

@AaronValor Thanks for your feedback. We'll investigate and report back.

@AaronValor  - what do you mean by it defaulting to 32-bit? Visual Studio is a 32-bit application for all Windows platforms. Are you seeing 64-bit components missing in some cases (e.g. 64-bit ETW collectors or debugging?)

@AaronValor We haven't heard back from you re: @artl93's inquiry; we'll close this for now but if you do have further information for us, please feel free to add it later or open a new GitHub Issue.
Thanks,
~ Terry

This was a mistake in my understanding.  I thought there was a 64-bit version of visual studio.


End call button doesn't work

I have been able to get the example app running and have been able to place outgoing calls from it, however I'm having trouble ending the call from the app. I see this issue in both the iOS simulator and when running on a real iPhone.
When I click on "End call", the iOS call-in-progress indicator (green bubble around the time) goes away, so it appears the call to RNCallKeep.endAllCalls() is successful, but the Twilio call does not disconnect and the app's in-progress indicator still shows. It's not until I end the call on the receiving end that the app correctly ends the call.
Before clicking "End call":

After clicking "End call":

I'm having the same issue on iOS. Sometimes endAllCalls works properly, and sometimes it doesn't

@dolsem @bradydoll You need to set the callSid in your Call Connected listener. Then in your hangup function, add TwilioPhone.endCall(callSid).
Something like this:
`
const [callSid, setCallSid] = useState('')
React.useEffect(() => {
const subscriptions = [
twilioPhoneEmitter.addListener(EventType.CallConnected, ({callSid}) => {
setCallSid(callSid)
setCallInProgress(true);
}),
twilioPhoneEmitter.addListener(EventType.CallDisconnected, () => {
setCallInProgress(RNTwilioPhone.calls.length > 0);
RNCallKeep.endAllCalls();
  }),
  twilioPhoneEmitter.addListener(
    EventType.CallDisconnectedError,
    (data) => {
      console.log(data);
      setCallInProgress(RNTwilioPhone.calls.length > 0);
      RNCallKeep.endAllCalls();
    }
  ),
];

return () => {
  subscriptions.map((subscription) => {
    subscription.remove();
  });
};

}, []);
function hangup() {
TwilioPhone.endCall(callSid);
RNCallKeep.endAllCalls();
setCallInProgress(RNTwilioPhone.calls.length > 0);
}`

Isn't calling TwilioPhone.endCall() handled by this library?
In /src/RNTwilioPhone.ts there is a listener for the RNCallKeep 'endCall' event that calls it:
    RNCallKeep.addEventListener('endCall', ({ callUUID }) => {
      const sid = RNTwilioPhone.getCallSid(callUUID);

      sid && TwilioPhone.endCall(sid);

      RNTwilioPhone.removeCall(callUUID);
    });

After re-trying the example app, hangup is working for me now. I'm not sure what is different with my initial testing that was causing the issue.

@bradydoll the root cause because the funtions RNTwilioPhone.getCallSid(callUUID) not working when your app killed. It mean it's only working when app is live or background. I face this issue now.

the root cause because the funtions RNTwilioPhone.getCallSid(callUUID) not working when your app killed. It mean it's only working when app is live or background. I face this issue now.

@bradydoll the root cause because the funtions RNTwilioPhone.getCallSid(callUUID) not working when your app killed. It mean it's only working when app is live or background. I face this issue now.


Revert "Change Android's MainActivity launchMode to singleTop"

Reverts bluesky-social/social-app#4255
Why
When using share intents, this change introduces a problem where multiple instances of the app are opened. This is pretty risky in regards to file system writes or session management. Let's revert.
Reverting does re-introduce the problem found here: https://github.com/bluesky-social/social-app/issues/4212. We should investigate this possibly through the expo-web-browser library itself.
Test Plan
Build after this revert, then open the app through a share intent (for example, through the Photos app). Multiple process shouldn't be open.

Hey @haileyok , sorry to revive this - I was wondering whether you tried the solution provided here? (which would apparently support both cases) https://github.com/expo/expo/issues/29153#issuecomment-2182380261
This seems to be a known issue in react native apps, spanning functionalities such as deep linking, android webviews and 3d payments.
References:
https://github.com/expo/expo/issues/29153
https://github.com/proyecto26/react-native-inappbrowser/issues/213
https://github.com/stripe/stripe-react-native/issues/355#issuecomment-1701323254
https://github.com/auth0/react-native-auth0/pull/944

Feel free to send a PR and we can have a look. Please include note on testing against past regressions this change has caused.


Submodules rename to dependencies

Why
I realized that we may use dependencies between modules more than I thought we were going to use it. For example, if you want to add the upm Node.js packager, you'll need to install Node.js. So really the packager depends on the runtime. It seems wrong to say the runtime in a submodule of the packager. So let's rename it.
What changed
Renamed submodule to dependencies in all the places.
Test plan

nix build .#v2.registry && cat result |jq|less
See that bundles.bun and any bundle for that matter, contains a dependencies option, containing a list of module IDs

On second thought, dependencies doesn't seem right for a bundle and its constituents...

Closing due to de-prioritizing V2..