Fluid spacing token

closes #74
This pull request introduces a $fluid-spacing-scale to @carbon/layout, and differenciates between both fluid and fixed. The values are based on what's current in Digital Design's documentation.
Changelog
New

$fluid-spacing-scale

Changed

$spacing-scale -> $fixed-spacing-scale
Added boolean fluid: false argument to spacing function to indicate which scale to use.
Updated demo to reflect new changes.

@jeanservaas naw, these are great questions! 😄
@emyarod do you have any information on the first question? We're using it in the form examples at the very least. You can see it in use on our spacing documentation page about half way towards the bottom.
If the IBM Design Language team is doing something with fluid spacing, then I'm unaware of it at this point. I personally wouldn't mind updating what I have here with their values if we can track them down. I don't know how Wonil, or @emyarod feel about that (I would imagine they would be on board for consistency's sake). In general though, anything fluid related I've seen up to this point will not align with the a fixed 8px mini unit grid. That goes for the grid, type, and including the spacing within this pull request.
I'm also down for the approach of get it in, and tweak as we see fit. I think one way or another there seems to be a need/desire for fluid spacing like this, so getting the token in place I think is the first step with great value in itself. Once that's done we can change the values around as much as we want. 😉
It's up to y'all though. Just let me know. 😄


[Feature] Bug explanation

Idk if it’s a bug but I catched a shiny Aron and bronzer and there were lvl 23 27 I put them away in my pc and I took them out later then they turned into a lvl 93 and 76

Nvm it was a mistake it spawned at bedrock so it was a higher lvl I didn’t know sorry

The lower your y-level the higher the level of the pokemon that spawn. (Discussed this particular issue and cleared up the misunderstanding with the player in-game, closing issue).


Add 'child_manipulation_disabled' property to Container

Added the child_manipulation_disabled property to the Container class, which stops queue_sort() from queueing the sort unless overridden via the ignore_child_manipulation_disabled argument.
This allows users to use Containers such as BoxContainers and PanelContainers to place children initially, but then directly control the properties of the children in a script without having to worry about the Container overriding them when the size changes. The issue can somewhat be worked around by setting properties of the children after the Container has sorted them, but this introduces a noticeable flicker.
Example of implementation:
Without child_manipulation_disabled
With child_manipulation_disabled
Master implementation does not work due to https://github.com/godotengine/godot/issues/51543
Edit: Godot improvement proposal here
Edit: Renamed property name from sort_disabled to child_manipulation_disabled
Bugsquad edit: Closes https://github.com/godotengine/godot-proposals/issues/3123 for 3.x

I don't think this feature is desired. The whole point of container is to sort their children. So if you don't need sorting, then you should use normal Control nodes instead. Adding an option to disable the sorting of Containers is very confusing IMHO.

I don't think this feature is desired. The whole point of containers is to sort their children. So if you don't need sorting, then you should use normal Control nodes instead. Adding an option to disable the sorting of Containers is very confusing IMHO.

The sorting is needed to initially place the children or at specific points (such as when adding a new child). The point of this is to be able to control when sorting is enabled.

The sorting is needed to initially place the children or at specific points (such as when adding a new child). The point of this is to be able to control when sorting is enabled, as it isn't needed all the time.

Well, sorting is the whole point of containers. Disabling sorting is simply a matter of replacing a Container node by a Control node, which is something you could also do at runtime if needed. Consequently, I don't think this feature is needed, and it is very confusing too.

Well, sorting is the whole point of containers. Disabling sorting is simply a matter of replacing a Container node by a Control node, which is something you could also do at runtime if needed.

You could say the exact same thing about the CollisionShape and CollisionPolygon. You can do that, but it can also introduce other problems like visual flicker and far more complex code within the game code.

it is very confusing too.

How so? It's essentially the exact same thing as disable booleans on other nodes, and if you don't need the property you can just ignore it without having to change anything.

How so? It's essentially the exact same thing as disable booleans on other nodes, and if you don't need the property you can just ignore it without having to change anything.

Explaining how Control and Containers work is already quite difficult. The two positioning systems (container-based or anchors/offset-based) are right now very separated, and it's a lot easier to explain how they should work by keeping them separated than starting to make situations where containers can work like normal Control nodes. I don't want to have situations where users don't understand why their Container do not work anymore because they checked an option about "sorting" things (sorting being a term quite internal to the Container node).
I'm not 100% against the feature, but in any case, this should have gone through a Godot Improvement Proposal first. To see is there are other users who need such a feature, and if there is no confusion about what this does.

I don't want to have situations where users don't understand why their Container do not work anymore because they checked an option about "sorting" things (sorting being a term quite internal to the Container node).

That makes sense. Maybe a rename to something like control_mode or disable_child_manipulation would help? I'm sure there are better options though.

this should have gone through a Godot Improvement Proposal first

Really? This is my first time doing a Godot PR so I wasn't sure, but from what I could tell I thought it was fine to open a PR without a proposal if I could implement the feature myself. I agree that this could create confusion so I'll go ahead and make one now though, thanks.

Maybe a rename to something like control_mode or disable_child_manipulation would help? I'm sure there are better options though.

That could work I guess.

Really? This is my first time doing a Godot PR so I wasn't sure, but from what I could tell I thought it was fine to open a PR without a proposal if I could implement the feature myself. I agree that this could create confusion so I'll go ahead and make one now though, thanks.

We do accept PR right away for bug fixes and for some non-controversial enhancements (like some UX improvements to the editor, things like that), but we need to be very selective when we change a Node's API. Those changes usually mean we need to keep compatibility with further releases, and thus usually implies more maintenance work than other changes. That's why we need to make sure a feature is both desired and in its best implementation before merging anything (that's what the proposals are supposed to help with).

@spectreseven1138 I think you can achieve a similar effect by container.remove_and_skip().

We do accept PR right away for bug fixes and for some non-controversial enhancements (like some UX improvements to the editor, things like that), but we need to be very selective when we change a Node's API. Those changes usually mean we need to keep compatibility with further releases, and thus usually implies more maintenance work than other changes. That's why we need to make sure a feature is both desired and in its best implementation before merging anything (that's what the proposals are supposed to help with).

Thanks for the advice. I opened an improvement proposal here.

especially when I need to move each child back and forth between a Container and non-Container multiple times

I think maybe you misunderstood remove_and_skip(). It removes the container itself from the scene tree hierarchy, not its child.

I think maybe you misunderstood remove_and_skip(). It removes the container itself from the scene tree hierarchy, not its child.

It removes the container then moves its children to its parent right? That would mean in order to move the children back into the same container if I need to resort them, I'd have to add the container back into the tree and then move each child back into the container one-by-one while ensuring that the scale, size, and position remain the same. I think that'd work, but like I said it would be far more complex and prone to breaking than being able to just disable the container.

You could just change the type of the container to Control. Everything stays in place and it's easy to change it back.

@spectreseven1138 I thought your use case is to only sort the children initially :P
For the case in your videos, you could use a different approach. Instead of changing the position of your buttons, you can wrap your button in an HBoxContainer together with an empty Control node on the left. Changing the min width of that empty Control can achieve what you need, in a more flexible way I think.
Demo.zip

You could just change the type of the container to Control. Everything stays in place and it's easy to change it back.

How do you change node types during runtime? I thought that was impossible.

Yeah there is no built-in method that does it, but you can easily write one using Node.replace_by().

I recently found a case where this would be useful. If working with inherited/instanced scenes, you aren't able to change node types in the editor. I had a node in a container, but then there was an instance of that scene where it would be useful to disable the container. It's very edge case though and I worked it around by making the instance local.

I don't think this should be accepted. It's a misuse of containers and indeed all the proposed workarounds are available if one really really needs to misuse containers. But this should not be made easier for most users, who should be taught to use the nodes properly instead. We in fact go to great lengths now to prevent users from changing things about control nodes and positioning in an unsupported way.

Based on the discussion above and in https://github.com/godotengine/godot-proposals/issues/3123, there doesn't seem to be much support for this feature, so closing.
Thanks for contributing nevertheless!


Improve resolver version mismatch warning

fixes: #12557

Looks almost perfect. I believe after updating features2::edition_2021_workspace_member we will be ready to merge.
(Sorry for lacking of UI snapshot autofix 😅)

@weihanglo fixed :+1:

Thanks for the contribution!
@bors r+

:pushpin: Commit 1f80ffabd1b5b60f5f40682881c7306f4f8f258d has been approved by weihanglo
It is now in the queue for this repository.

:hourglass: Testing commit 1f80ffabd1b5b60f5f40682881c7306f4f8f258d with merge b8df7aa4e8c37480b03ea558df08bb75559dcc5c...

:sunny: Test successful - checks-actions
Approved by: weihanglo
Pushing b8df7aa4e8c37480b03ea558df08bb75559dcc5c to master...


Upgrade helm chart to support cert-manager 1.5 ->

helm install rancher rancher-latest/rancher \

--namespace cattle-system
--set hostname=rancher.********.duckdns.org
--set replicas=3
--set ingress.tls.source=letsEncrypt
--set<EMAIL_ADDRESS>W0817 23:34:10.807089   15206 warnings.go:70] cert-manager.io/v1beta1 Issuer is deprecated in v1.4+, unavailable in v1.6+; use cert-manager.io/v1 Issuer

Note: cert-manager API versions v1alpha2, v1alpha3 and v1beta1 that were deprecated in 1.4 will no longer be served in 1.6.
https://github.com/jetstack/cert-manager/releases/

besides the "cattle-system/rancher" (kind: issuer) other ressources to take into considerations?


Issues with a corresponding merged pull request should be closed.

Why? Could you be more specific?
Issues are closed once they are fixed in the master branch. A proposed fix may not be merged, so we don't close issues before merging PRs.

This is done automatically if the PR description or commit message contains "closes #xxxx" (or "fixes #xxxx", "resolves #xxxx") in the description. If not, it has to be done manually.

If not, it must be done manually by the issue poster or someone with repository permissions.

I wonder how many opened issues are there which are already fixed but not closed that way, I think this is what this issue is about. @justchen1369 please provide a list of such issues that must be closed.

I assume quite a lot, since the auto-closing is a fairly new feature...

About 6 months ago I did a full sweep over all existing issues and commented on anything that's already fixed. If some non-closed-fixed issues exists, they are probably recently fixed (some PR authors aren't aware that there's an issue that their PR closes) or I couldn't test them during my run (mostly platform-specific issues etc.).
Anyways, instead of making an issue about issues, if you find something that should be closed, just leave a comment and someone will close it. (if you do this enough times, you can get bugsquad pass :v)

I assume quite a lot, since the auto-closing is a fairly new feature...

It's actually fairly old, at least I can't remember a time where the feature didn't exist (so it must have been around already when I started being active on GitHub projects maybe 7 years ago).
Usually we're on the lookout to make sure that PRs properly include auto-closing keywords if we're aware that they're actually fixing an issue.
In other cases as mentioned by @KoBeWi, we sometimes simply don't know/remember that an old issue exists for what the PR solves, so we usually find this later when we ask people to test old issues after a release to confirm if they're still relevant.
In any case, not sure what this issue is about, but any issue with only a title and no content is probably not worth spending too much time on. Suggestions on workflow improvements are welcome, but this is a bit too terse.


Update tiflash-sanitizer-daily.groovy to add rust code cache

Verified in https://ci.pingcap.net/blue/organizations/jenkins/tiflash-sanitizer-daily/detail/tiflash-sanitizer-daily/638/pipeline

/assign @purelind

@purelind PTAL

nit: Commit message should not be too common 🤝 .
@solotzg


Where is connection data stored?

When providing access to particular entity record with access team, where is this connection stored? in which table or columns?
Also, if connected, "button Share" web using Web Form, where does it saves the share connection information?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1e79dc75-29c6-2f8b-1860-1110fc2e6fbf
Version Independent ID: 8992a69b-30d7-222b-41ee-06ccd0aba949
Content: Use access teams and owner teams to collaborate and share information (Microsoft Dataverse) - Power Apps
Content Source: powerapps-docs/developer/data-platform/use-access-teams-owner-teams-collaborate-share-information.md
Service: powerapps
Sub-service: dataverse-developer
GitHub Login: @paulliew
Microsoft Alias: jdaly

@hkusulja Connection informatiooooooon is stored in the PrincipalObjectAccess table. Customers do not have access to that table.
I cannot comment on the button question as that is not related to developer docs. Try logging an issue in the maker or admin doc feedback.

@phecke
Ok, can you please write in documentation that there is (it exists) the PrincipalObjectAccess table, and there is no access.
Thank you


Make make sure depend on python

Fixes https://github.com/hypothesis/cookiecutters/issues/48
Testing
Create a Python package to test with. Note: the command below creates a Python package from a local copy of the cookiecutter at ~/Projects/cookiecutters:
cd /tmp
cookiecutter ~/Projects/cookiecutters --directory pypackage --no-input
cd my-python-package

Uninstall one of the versions of Python that the package needs:
pyenv uninstall 3.10.4

Run the package's make sure:
make sure

On main you'll get a crash because Python 3.10.4 doesn't get reinstalled. On this branch it'll get reinstalled and make sure will pass.

This repo hasn't been reviewed yet (the plan is to review it by reviewing PRs that bring our projects under the cookiecutter) so I'm going to go ahead and merge this as it's just making changes to unreviewed code


Research Vanilla-Extract as a CSS solution

Description / User story
We want to invest some more time too investigate if Vanilla-Extract is a potential CSS library to use, as recommended by https://github.com/deven-org/boiler/issues/1081 .
The following key factors need to be considered:

Supports Server Side Rendering (SSR)
Supports code driven transformation of CSS (either at build-time or runtime)
Provides a satisfying developer experience which includes:
Syntax highlighting
Context aware editor auto-completion, code navigation and refactoring
CLI validation tools
Extensive documentation
Allow for targeted style overrides from outside the component
Allow for targeted style re-use from outside the component

Requirements / Prerequisites

[x] #1081
[ ] #1096
[ ] #1097

Acceptance Criteria

[ ] Vanilla-Extract has been evaluated by the key factors we defined for a CSS solution
[ ]  The outcome has been documented
[ ]  We are able to decide on the CSS approach after further research of Vanilla Extract and SASS has been finished

Additional information
Current findings as researched via https://github.com/deven-org/boiler/issues/1081

I only did a high-level investigation by looking at the docs. It has a few promising features but also a few shortcomings.
Pros
Extracts and injects static styles. Good fit for our current classMap approach and general lit compatibility.
Doesn't require an extra formatter or linter since it uses a typed object style API instead of tagged template literals. That means it integrates well with TypeScript, Prettier and ESLint.
Features a well designed API for incorporating dynamic styles through CSS variables.
Seems to support custom class names as well as auto generated ones so it can be adopted incrementally.
Seems to be well maintained.
Dynamic TokenIterator concept might be covered by add-function-serializer
Well documented.
Cons
Requires extra build tooling configuration (e.g. webpack plugin) to extract and inject styles.
We'd have to re-write our entire css to use style objects.
Might have the same problem with semi dynamic generation of styles through our TokenIterator concept as linaria.
The object style syntax can lead to poor readability.

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Improving our current CSS approach with #922 and #1021 (and follow up tasks for all other components to remove class maps) seems to be the more safe next steps than to invest time in this task.


Audio offset option for charting

What feature do you want to get added on the base engine?
Sometimes, when charting a song, one runs into the issue of the beats in the song not lining up 1:1 with the note grid, likely because there's some arbitrary length of silence or noise before the song starts, meaning that even if you get the BPM and all that correct you'd still have to zoom in and use really awkward in-between grid spaces to make the charting feel FULLY synced. There is, I think, a straightforward (in concept if not in execution) solution to this which other rhythm games like Stepmania have had for quite some time. Audio offset! Letting a charter offset what the game recognizes as "the first beat" in a song (or in this case at what point in the audio the charting grid begins).

(pic at charting zoom x1)

(pic at charting zoom x8, with an additional note showing where a note would have to be to ACTUALLY sync with the audio)
This should demonstrate what I mean by a song's audio not being in sync with the grid, despite the BPM being correct and whatnot.
To test your sight, and reliability, please select the option of what should NOT be requested.
Stage Editor, 6K+ support, and winning icons.

There's already an offset for the audible stuff...
There should be a thing for those visual lines tho...

There's already an offset for the audible stuff... There should be a thing for those visual lines tho...

I'm not sure what you mean because the "Audio Offset" option in the Psych Chart editor doesn't do shit

In progress

Done.


Extremely poor performance compared to docker-compose

I'm not sure what the cause of this is, but if I run phpunit in batect, it takes 3.84 minutes compared to 6.1 seconds in docker-compose. This is not including the build time for the containers, only the time taken by phpunit itself (it outputs it at the end of the tests).
Both of them are not using any volume mounts, and are using the same Dockerfile.

Hi @nesl247, thanks for your feedback. That doesn't sound right at all, execution performance should be on par with docker-compose.
Are you able to share a sample project that reproduces the problem so that I can investigate further? And could you please post the output from ./batect --version?

Hey. Unfortunately I can't provide the current project as a sample, but I will try and dockerize something else and see if I can reproduce it. Until then, I've included the information request as well as other potentially relevant information.
batect version:    0.32
Built:             2019-05-19 09:19:58 +0000
Built from commit: f96aef904d105c6456f4a4b60f68bc3d87ae4845 (commit date: 2019-05-19 15:18:32 +1000)
JVM version:       Oracle Corporation OpenJDK 64-Bit Server VM 12.0.1
OS version:        Mac OS X 10.14.5 (x86_64)
Docker version:    18.9.2 (API version: 1.39, minimum supported API version: 1.12, commit: 6247962)

For documentation and further information on batect, visit https://github.com/charleskorn/batect.

docker-compose version 1.23.2, build 1110ad01

project_name: shop-front

containers:
  php:
    build_directory: .
    dockerfile: docker/php/Dockerfile
    build_args:
      GITHUB_TOKEN: $GITHUB_TOKEN
    environment:
      LINIO_ENV: local
      XDEBUG_CONFIG: remote_host=host.docker.internal

tasks:
  unitTest:
    description: Run the unit tests.
    run:
      container: php
      command: vendor/bin/phpunit

version: '3.7'
services:
  php:
    build:
      context: .
      dockerfile: docker/php/Dockerfile
      args:
        - GITHUB_TOKEN
    image: shop-front-php:${IMAGE_TAG:-latest}

docker-compose run --rm php vendor/bin/phpunit

And the issue was my fault. I was testing against the image itself without LINIO_ENV, a flag we have to make a few changes, including turning on xdebug. In batect I had it.
Unfortunately though the performance is still twice as slow that of docker-compose. However, it's a big improvement from before.
I'm going to close this as I'm not sure if it's due to environmental factors or batect itself. I will reopen it if I determine it is definitely batect.
Thanks, and sorry for the inconvenience.

No worries at all. If you find anything that would help others speed up their projects, I'd be keen to hear about it so I can add it to the documentation.


Add resizing ui test for RenderDemo

What does the pull request do?

What is the current behavior?

What is the updated/expected behavior with this PR?

How was the solution implemented (if it's not obvious)?

Checklist

[ ] Added unit tests (if possible)?
[ ] Added XML documentation to any related classes?
[ ] Consider submitting a PR to https://github.com/AvaloniaUI/Avaloniaui.net with user documentation

Breaking changes

Fixed issues

@danwalmsley
Master (this PR), Peak: 389:

With UseWindowsUIComposition = true - Peak: 266:

With UseWindowsUIComposition = false - Peak: 363:

With AllowEglInitialization = false - Peak: 59:

With UseDeferredRendering = false:
It just throws from WinUI.Composition code:
System.InvalidOperationException: 'The text associated with this error code could not be found.

The text associated with this error code could not be found.
'


feat(create-react-app-ts): deprecate support for create-react-app-ts projects

Fixes #2352

@nicojs I wrote a test this time 😘

Oh no the build is failing


[WIP] Infer selectors from protocols for property accessors too.

Most property accessors have selectors matching their protocols, but not all. Don't force the user to write @objc explicitly on an accessor, which isn't even possible for stored properties.
Groundwork for rdar://problem/28543037.

This still has two problems:

At the bottom of TypeChecker::findWitnessedObjCRequirements there's a section about inherited conformances that I don't quite understand, but that probably needs to do the same thing.

There's an existing problem that we get duplicate diagnostics when a witness doesn't have the correct type, as seen in test/ClangImporter/objc_parse.swift. I think this is because calling lookupConformance in findWitnessedObjCRequirements is going to try to validate the conformance again even after we've already diagnosed it, but I don't know what to do about it.

@DougGregor, do you have any insight into either of these?

(with expected failures)
@swift-ci Please smoke test

If a base class conforms to a protocol and a subclass implements an optional requirement, we don't record that anywhere. I think this is what that comment is referring to.

In general do we want to change things so that accessors have witnesses, instead of/in addition to the AbstractStorageDecl? We do this dance in a bunch of places where we check if we have an accessor, get its storage, lookup the witness and then get the right accessor from there.

Also it would be cool if a no-payload enum case could witness a read-only static property requirement :)

(still with expected failures)
@swift-ci Please smoke test macOS

Yeah, the comment about inherited conformances is that the superclass can conform to some @objc protocol without implementing some of the optional requirements. Then, the subclass can come in and implement an optional requirement---and we need to make sure we infer the selector there. At some point, we could/should have inherited protocol conformances compute and record these witnesses to optional requirements, but for now we don't, so this code looks for them explicitly.

Regarding the double-diagnostic, it seems like we should be recording an erroneous/missing witness when there is a type mismatch, and shouldn't diagnose any problems with that requirement in that conformance later.

And, thanks for working on this!

Okay, added support for inference from optional requirements as well. Depends on (well, includes) #6698 now. Any more comments, @DougGregor or @slavapestov?
(I'm not touching the larger issue of accessor requirements for now; that's more change than I'd want to pull into Swift 3.1.)
@swift-ci Please test

Build failed
Jenkins build - Swift Test OS X Platform
Git Commit - 9225e25ab5790d88f3fc425736aa3adb010cb5f3
Test requested by - @jrose-apple

Build failed
Jenkins build - Swift Test Linux Platform
Git Commit - 9225e25ab5790d88f3fc425736aa3adb010cb5f3
Test requested by - @jrose-apple

No more comments, thanks @jrose-apple


removed Intune

https://github.com/MicrosoftDocs/windows-itpro-docs/issues/8107

Dear @JohanFreelancer9,
kindly do the copy editor review for this PR.
Dear @e0i, for your information
Thank you


Allow creating global tf.FIFOQueue in deep frame contexts

Let's say I'm building a graph. It's a pretty deep graph with many nested while loops. Let's also say I have some template/abstraction that allows me to create a tf.FIFOQueue on demand deep in my nested while loops as I encounter things I want to send out of the graph. This template allows me to infer the shape automatically from the tensors as they are encountered rather than to have to write a bunch of painful boilerplate to define all the queues and their corresponding shapes up-front.
This is currently not possible with TensorFlow, because this gives this error:

tensorflow.python.framework.errors_impl.InvalidArgumentError: The node 'fifo_queue_DequeueMany' has inputs from different frames. The input 'while/fifo_queue' is in frame 'while/while/'. The input 'fifo_queue_DequeueMany/n' is in frame ''.

I want to create a FIFOQueue() in the global "frame" so I don't get this error. In addition the documentation never explains what a "frame" even is. Having undocumented restrictions that suddenly explode without warning is a sign of leaky abstractions and very frustrating for users.

Similar issue: #8604
I solved this with the workaround: with tf.control_dependencies(None):


fix: Add --port argument in flagd pods for set flagd service port

This PR

Enhance argument injecting logic  for set flagd service port (--port with FeatureFlagSoruce configuration)

Related Issues

Fixes #709
Notes

Follow-up Tasks
I don't have the background knowledge of why this feature wasn't implemented, and I haven't tested this code, so a thorough PR review is needed
How to test
Set FeatureFlagSource.spec.port with specific number and check the --port argument was properly set and check its debug log at info    flag-evaluation/connect_service.go:227    Flag IResolver listening at: {PORT_NUMBER}

@beeme1mr
I agree. This work can't resolve this issue gracefully.
We need to fix why FLAGD prefix is missing in Enviornmet variables.


Add to GitHub

Looks like we may be able to add this to GitHub to get better support for Gleam.
https://twitter.com/importantshock/status/1496884996317011968

Create an issue on your repo and CC me (/patrickt on GitHub) or /dcreager.

Is this something the grammar and queries are ready for?

We'll need tags.scm queries (see https://github.com/elixir-lang/tree-sitter-elixir/pull/18 and https://github.com/tree-sitter/tree-sitter/pull/1649). Otherwise I think this parser is in great shape :)
I can take a look at adding these, I bet it wouldn't be too tough given how the nodes are structured :+1:

Hi @lpil! Sorry for the delay. As @the-mikedavis said, the parser is in pretty good shape. I have a few items on my shortlist:

Move corpus under test (I think this can just be done with no further changes; just an organization item)
Rename type_constructor* to data_constructor*; it's a misnomer as-is

And also tags.scm, but it looks like @the-mikedavis got that one :grin:
Somewhat related, but I think we should move the canonical version of this repository to under the github.com/gleam-lang organization once those are done, but before we ask for it to be used with GitHub.
I'll post updates here; I'm hoping to get my shortlist done this evening :grin:

All sounds fab to me!

Hey @lpil, sorry for the delay! The repository is now at a good point to transition ownership to under the gleam-lang org. Whether you want to fork it to that org or clone-and-push a copy is totally up to you! Once it's over there, I'd love if you could add myself and @the-mikedavis as maintainers of the project, and it should also be ready to provide to GitHub for integration :pray::tada:

I remember transferring a repo to be a bit strange when working on tree-sitter-iex. Iirc I transferred it to José and then José transferred it to the elixir-lang organization, and doing that way you keep the git history, stars and prs/issues

Ah, I didn't even think about GitHub having an official mechanism for this! :sweat_smile: Sure enough, I tried requesting a transfer to gleam-lang, but that didn't work as it said I didn't have access to create repositories for gleam-lang. I have now requested a transfer to @lpil, such that he can then transfer it to gleam-lang.

Hey @lpil! Just wondering if we've reached out to the team at GitHub about adding tree-sitter-gleam functionality to their platform. If not we can cc them here 😁

👋🏻 GitHubber here. We’ve added Gleam support to our roadmap. I can’t make guarantees as to a timeframe, unfortunately, but we’re on the case!

We’ve just integrated highlights.scm-based syntax highlighting for Gleam! You may notice slightly faster page load times.

Wonderful news!

@patrickt Great news! Though to me it doesn't look quite right. We have lost syntax highlighting for types, constructors, and arguments.

The orange module names stand out a lot more than I think is ideal too.

Is this something we can fix on our end?

Found a few more places in which syntax highlighting is broken:
Type definitions are no longer highlighted

https://github.com/gleam-lang/stdlib/blob/a78e3a2eca5593eb0e9eb3c97d0d776a25081573/test/gleam/string_test.gleam#L442-L446
Strings with // in them break highlighting
https://github.com/gleam-lang/stdlib/blob/a78e3a2eca5593eb0e9eb3c97d0d776a25081573/test/gleam/string_test.gleam#L602-L622

FWIW, the general non-highlighting of types (and data constructors/names, which we treat as types for better or for worse) appears to be an issue on GitHub's side. Those use the @type highlight name, which tree-sitter-rust uses as well (our matching, for comparison), and works well in the tree-sitter based Emacs mode:

We also verify this in some of our highlighting tests.
The "comment in string" bug is real and affects environments other than GitHub. I'll try to run that down this evening.

To give a small update on this, the string/comment parsing issue appears to be an artifact of parsing strings as non-terminal nodes/tokens, which means that any field in extras (whitespace, comments) should be able to appear before any child node under the string node.
To counter this, I tried wrapping the string child nodes with token.immediate, whose documentation states:

Usually, whitespace (and any other extras, such as comments) is optional before each token. This function means that the token will only match if there is no whitespace.

It may truly be specific to whitespace, because it had no effect.
My approach looks like this:
    string: ($) =>
      seq(
        '"',
        repeat(choice($.escape_sequence, $.quoted_content)),
        token.immediate('"')
      ),
    escape_sequence: ($) => token.immediate(/\\[efnrt\"\\]/),
    quoted_content: ($) => token.immediate(/(?:[^\\\"]|\\[^efnrt\"\\])+/),

FWIW, tree-sitter-rust's approach is very similar:
    string_literal: $ => seq(
      alias(/b?"/, '"'),
      repeat(choice(
        $.escape_sequence,
        $._string_content
      )),
      token.immediate('"')
    ),
    // ...
    escape_sequence: $ => token.immediate(
      seq('\\',
        choice(
          /[^xu]/,
          /u[0-9a-fA-F]{4}/,
          /u{[0-9a-fA-F]+}/,
          /x[0-9a-fA-F]{2}/
        )
      )),

A notable difference, however, is that tree-sitter-rust's _string_content anonymous node is implemented as an external scanner, whereas our equivalent (quoted_content) is implemented in the tree-sitter DSL. I may attempt to make it an external scanner to see if that makes a difference.

@patrickt Great news!

Thanks!

Though to me it doesn't look quite right. We have lost syntax highlighting for types and constructors, and labels and arguments are two different colours now.

As regards type names, that is technically correct. @type is defined to map to an smi CSS class, that in dark mode is meant to map to an uncolored face (see also Java interfaces, which do the same). This is true also for @property, which, if you prefer argument labels to be highlighted the same as arguments, might not be the right choice. Given that argument labels are a pretty common construct, we could perhaps add a new @property.label class, if you think it’s too jarring (though as of right now I observe the same behavior with Swift labeled arguments).
With respect to constructors, I think those should be mapped to the @constructor highlight, which doesn’t appear to be mentioned in highlights.scm, so I think that should be fixable on your end.

The orange module names stand out a lot more than I think is ideal too. In this snippet I think they are not very important but they are very bold. Previously they were white, like variables.

I agree it’s pretty loud. Unfortunately, we don’t have any facilities for grammars to direct the manner in which things are highlighted: on our end, it’s basically just a map from highlighting classes to CSS classes (closed-source, unfortunately, though I can give a subject-to-change summary of what is done should you need it). I think it would be cool to allow highlighting grammars to suggest how emphatically or subtly a given class should be highlighted, but that would be a long-term project (as would making the module highlighting a little less punchy, given that we’d have to get input from design, plan for the various colorblindness modes, etc etc).
If you’d prefer for us to go back to the old highlighting queries, that’s not a problem on our end (though you will notice some marginally longer page load times).

Oh, I see that the comment-in-string bug is fixed. I can bump that today.

I forgot to address the property vs argument bit. The TL;DR is

Labels and the arguments they label aren't the same syntactically, so I believe that there should be an option to highlight them differently. Personally, I find having them highlighted differently to aid readability.
The same parsing logic and AST nodes are used for arguments to data constructors and arguments to functions. The use of the "property" highlight was born from the former as "property" seemed to fit "the fields of a record/struct" better than anything else.

I'm happy to change what highlight is applied to labels and also to differentiate the highlight for data constructor argument labels vs function argument labels if desired (though I'm not especially fond of that idea), but I do believe that labels and the arguments they point to should be able to be highlighted differently.

All other things being equal, our team would prefer to keep labels and arguments highlighted differently so as to have parity with how Swift and other such languages are highlighted, but it’s ultimately the community’s call.

The new highlighting queries have been bumped in production.

https://github.com/github/linguist/tree/master/vendor/grammars
I think we may be able to update this here!

I think the new tree-sitter highlighting/analysis is separate from the linguist configurations and is probably closed-source for now. The grammars in linguist are textmate grammars (regex-based) I believe - for example the Elixir one points at https://github.com/elixir-editors/elixir-tmbundle/blob/b01fffc49179bdec936ca19b53ba4fc7c51a2cc0/Syntaxes/Elixir.tmLanguage although Elixir is highlighted/analyzed with tree-sitter

Ah boo, I misread and thought they had moved the tree sitters into this repo as well.


[Question] How media locations attribute help in interleaving visual tokens with text?

Please advice on the usage.

Would be great.


Front Page Width

The width of the "select language" is wider than the minimum width of the homepage, this gives us a small border on the right when viewing on my iphone 6s plus

Can this be closed now as #406 got merged?

yes, thanks


Linux binary works only on quite recent distributions

In fact I haven't tested it on any other distribution than Linux Mint 21 (~ Ubuntu 22.04). Rudi reported that it doesn't work on Ubuntu 20.04. You can report further working / not-working distributions here. A solution can be to provide a simple command line server that serves the frontend and a web socket API (that would have a few more advantages than just reducing dependencies), but that is likely not going to happen before RoboCup 2023.

if you build the release on an old ubuntu with an old glibc i think it should work

It is known that the provided Linux binaries do not work on Ubuntu 20.04. You can report working / not-working distributions in https://github.com/RoboCup-SPL/GameController3/issues/37 or via email to Arne Hasselbring.

not working on debian 11 with glibc 2.31

The CI-built binaries should support glibc>=2.28 (e.g. Ubuntu >=18.10 and Debian >=10, but still not Ubuntu 18.04).

the draft is not published so i can't test on my system.
could you support 18.04 by changing https://github.com/RoboCup-SPL/GameController3/blob/master/.github/workflows/mkdist.yml#L18 ?  from the git history, it looks like you only tried 20.04

rc.2 isn't released yet on purpose. The latest build is available at https://github.com/RoboCup-SPL/GameController3/suites/13735406684/artifacts/760207080 (I don't know if you need special privileges to access that link, at least I can't download it without being logged in).
The 18.04 runner image is deprecated and should have been removed in April, according to GitHub.

thanks that works.  for some reason i thought the CI/CD would only run on a tag/release and i didn't check the actions.
works on debian 11.  i guess if we need 18.04 support we can try a static build or the a non-runner base image.


Use defined CGO_ENABLED

With the current state of ci::v1 and building a go project with make build, and running the generated binary inside an alpine:3.7 container, I get the following error:
standard_init_linux.go:178: exec user process caused "no such file or directory"

It seems that CGO_ENABLED is not properly read from the passed make vars, so it should be explicitly passed to the build command.

Maybe it is better to set export CGO_ENABLED=$(CGO_ENABLED) (docs). That should ensure that the variable is set for all commands and not just this one.

CGO_ENABLED or any other env variable should be set at "GO_BUILD_ENV", the CGO_ENABLED is a leftover, should be removed.


RemoveSecurity Does Not Remove Option Contract Added After Initialize

Expected Behavior
RemoveSecurity always removes a Security object added by AddOptionContract method from user-defined universe.
Actual Behavior
It doesn't.
Reproducing the Problem
Use this alternative version of AddAndRemoveOptionContractRegressionAlgorithm:
namespace QuantConnect.Algorithm.CSharp
{
    /// <summary>
    /// Regression algorithm reproducing GH issue #5748 where in some cases an option underlying symbol was not being
    /// removed from all universes it was hold
    /// </summary>
    public class AddAndRemoveOptionContractRegressionAlgorithm : QCAlgorithm, IRegressionAlgorithmDefinition
    {
        private Symbol _contract;
        private bool _hasRemoved;

        public override void Initialize()
        {
            SetStartDate(2014, 06, 06);
            SetEndDate(2014, 06, 09);

            UniverseSettings.DataNormalizationMode = DataNormalizationMode.Raw;
            UniverseSettings.MinimumTimeInUniverse = TimeSpan.Zero;

            var aapl = AddEquity("AAPL").Symbol;

            _contract = OptionChainProvider.GetOptionContractList(aapl, Time)
                .OrderBy(symbol => symbol.ID.Symbol)
                .FirstOrDefault(optionContract => optionContract.ID.OptionRight == OptionRight.Call
                    && optionContract.ID.OptionStyle == OptionStyle.American);
        }

        public override void OnData(Slice slice)
        {
            if (!Securities.ContainsKey(_contract))
                AddOptionContract(_contract);

            if (slice.HasData)
            {
                if (!_hasRemoved)
                {
                    RemoveOptionContract(_contract);
                    RemoveSecurity(_contract.Underlying);
                    _hasRemoved = true;
                }
                else
                {
                    throw new Exception("Expect a single call to OnData where we removed the option and underlying");
                }
            }
        }

Checklist

[x] I have completely filled out this template
[x] I have confirmed that this issue exists on the current master branch
[x] I have confirmed that this is not a duplicate issue by searching issues
[x] I have provided detailed steps to reproduce the issue

Hi Guys!
This would be a major fix to make option algorithms way faster. Any update on this bug?
Thanks a lot!

This issue is happening because the algorithm is trying to add & remove the contract in the same call to OnData see this algo doesn't reproduce the issue:
        public override void OnData(Slice slice)
        {
            if (slice.HasData && Securities.ContainsKey(_contract))
            {
                if (!_hasRemoved)
                {
                    RemoveOptionContract(_contract);
                    RemoveSecurity(_contract.Underlying);
                    _hasRemoved = true;
                }
                else
                {
                    throw new Exception("Expect a single call to OnData where we removed the option and underlying");
                }
            }

            if (!Securities.ContainsKey(_contract))
                AddOptionContract(_contract);
        }

Still a bug though 💯 🐛  just a more corner case one


Additional space after the encoded unicode character destroys the meaning of the original text

The module adds a space after each unicode character, even in your example:
cssesc('Ich ♥ Bücher');
// → 'Ich \\2665  B\\FC cher'

So, in the result Bücher will be shown as Bü cher on the website.
Why don't you follow the CSS specification (https://www.w3.org/TR/CSS2/syndata.html#characters) and convert ü to \0000FC?
To make the result as short as possible is a nice idea, but it doesn't make sense to destroy the orignal string so that the result is not usable anymore.

So, in the result Bücher will be shown as Bü cher on the website.

What makes you say that?

It sounds like you're misunderstanding how CSS escape sequences work. The space following the escape sequence is consumed as part of it. Please read https://mathiasbynens.be/notes/css-escapes, or the CSS spec.
Example: https://mothereff.in/css-escapes#1Ich ♥ Bücher
Navigate to the following URL to see a demo:
data:text/html;charset=utf-8,<!DOCTYPE%20html><title>CSS%20escapes%20example<%2Ftitle>


feature: Allow to alignment between protein or nucleotide sequences

This can be done with Needleman–Wunsch algorithm. Like the title mentions its an algorithm that allowed you to align protein or nucleotide sequences. This algorithm will be in its own file to follow the standard of the project.

Thanks for submitting! It's an interesting idea, and it's definitely a use case for using the Levenshtein distance algorithm. Is this algorithm purely for biology?
From the perspective of a library user (not developer), the Hamming & Levenshtein distance algorithms have a various/wide set of applications to use them in. This includes biology, but it's not solely biology. Ideally, a library should only ship what will be used. Those 2 algorithms (at least as of right now) are the main focus, but Needleman-Wunsch is biology focused.
I do like the idea though, and I think it'd make better sense if we turn this repository into a monorepo of related crates. We can do this by using a "Cargo workspace" (https://doc.rust-lang.org/book/ch14-03-cargo-workspaces.html). If you look at the GitHub repository for the serde crate, there's multiple crates in there like the main serde crate, serde_derive, and serde_derive_internals (crate purely internal for developers).
I think we can do something like this, except move it to where all crates are in a /crates directory. So, we could have like:

differ: Library for just the pure distance/similarity algorithms
needleman_wunsch: Library for the Needleman Wunsch algorithm, which can have differ as a dependency (if it needs it)

If this is something you're interested in, then we should create an issue first to setup the repository for a monorepo, and then we can create a crate for the Needleman-Wunsch algorithm.

As of right now there are two algorithms I would like to implement on bio_diff that being

Needleman–Wunsch algorithm
Smith–Waterman algorithm

Both have to do with aligning protien or nucleotide sequences. Each algorithm will have their own file similar to how differ is structured. I am thinking of re using the same enums and structs EXECPT I plan on implementing the memory optimizations on issue #25 from the start.

I am thinking of re using the same enums and structs EXECPT I plan on implementing the memory optimizations on issue https://github.com/nlp-rs/differ.rs/issues/25 from the start.

By the way, I mentioned earlier you can have a crate as a dependency for another crate :) So, you can have bio_diff depend on the differ crate. By doing this, you won't have to re-implement anything.

I am thinking of re using the same enums and structs EXECPT I plan on implementing the memory optimizations on issue #25 from the start.

By the way, I mentioned earlier you can have a crate as a dependency for another crate :) So, you can have bio_diff depend on the differ crate. By doing this, you won't have to re-implement anything.

If I crate depends on another crate does this have any performance downsides ? Also if bio_diff depends on differ does the user just have access to bio_diff or also differ ?

If I crate depends on another crate does this have any performance downsides ?

No performance downsides here. Think of it this way; it would be a performance downside by having both libraries duplicate code if a user used both libraries, assuming bio_diff didn't depend on differ. It'd also be a burden on the software developer to maintain duplicate code.

Also if bio_diff depends on differ does the user just have access to bio_diff or also differ ?

They'd just have access to bio_diff, but the user can specify differ as an explicit dependency. Rust has a feature called dependency resolving in the situation where a project has common dependencies, to keep the binary size as small as possible, so this is not a worry. :)

Declining for now, see #43. This can be written inside a separate repository


Wagtail page dropdown menu does not seem to match user permissions assigned to a page

I set an Editors group to have only Edit and Publish permissions on the Home page and assigned a user to this group.  When I log in as this user, I expected the user to only be able to edit and publish existing pages.  However, from the Home page, the MORE dropdown includes a Copy option, and the MORE dropdown for pages under the Home page each include Move, Copy and Delete.  When I try to copy one of the pages under Home (I have only a single set of pages one level deep under Home), fortunately the permissions seem to be honored when I click through to try to copy it, but it seems like Copy shouldn't even be displayed as an option in the dropdown menu if Add permission has not been provided for the user for that page because copying a page is the same as adding a page.
Delete also appears in the dropdown menu.  Disturbingly, Delete does actually work.  While I only provided this user permission to edit and publish a page, they can actually delete the page.  It seems that Delete capability should only follow the Add permission.
I will re-post this on StackOverflow if that is a better forum for this item - I wasn't certain whether here or StOf would be best.

I encountered this issue myself today, adding custom permissions via permissions_for_user on a Page model does not seem to be used in other places throughout the UI.
Most likely due to not using page.specific
https://github.com/wagtail/wagtail/blob/main/wagtail/core/models/__init__.py#L1958
    def permissions_for_user(self, user):
        """
        Return a PagePermissionsTester object defining what actions the user can perform on this page
        """
        user_perms = UserPagePermissionsProxy(user)
        return user_perms.for_page(self)


Add container_gpu_allocation metric

Proposal is to start exporting container_gpu_allocation to Prometheus alongside container_cpu_allocation and other metrics.

This is available as container_gpu_allocation


Table column data is mixed up

Other than the first row of each table, the data in each column is shifted to the left.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: fd246a7e-dc3c-6669-ef6a-ba3e0cf0e968
Version Independent ID: 8377d0de-5712-355d-cc25-894053ccfbf2
Content: Rich Presence configuration - UWP app developer
Content Source: windows-apps-src/xbox-live/social-platform/rich-presence-strings/rich-presence-strings-configuration.md
Service: unspecified
GitHub Login: @KevinAsgari
Microsoft Alias: kevinasg

Thank you for your feedback aschultz!
The table has been fixed.


Instance group with BOSH links is always redeployed even if there is no manifest change

Hi,
We have an instance group where a job consumes a BOSH link from an other job (on the same instance group). The instance group is always redeployed independent from the manifest change.
Even if we stop consuming the link the redeploy still happens.
We have the two jobs with the following config on the instance group:
- name: nats
  azs:
  - z1
  - z2
  instances: 2
  jobs:
  - name: nats
    release: nats
    provides:
      nats: {as: nats, shared: true}
  - name: datadog-nats
    release: datadog-for-cloudfoundry
    consumes:
      nats: {from: nats}
  [...]

In the spec file for nats we have this:
provides:
- name: nats
  type: nats
  properties:
  - nats.port

In the spec file for datadog-nats we have this:
[...]
consumes:
- name: nats
  type: nats
  optional: true

properties:
  nats.port:
    description: "Listening Port for NATS server."
    default: 4222
  [...]

We have the following template in the datadog-nats job which uses the optional nats link:
<%=
  nats_port = p('nats.port')
  respond_to?(:if_link) && if_link("nats") do |link|
    nats_port = link.p("nats.port")
  end
%>

init_config:

instances:
  - name: NATS server
    host: <%= spec.address %>
    port: <%= nats_port %>
    collect_response_time: true
[...]

BOSH deploy doesn't show any manifest change but redeploys only the two nats instances:
Task 3266

Task 3266 | 11:40:38 | Preparing deployment: Preparing deployment (00:00:14)
Task 3266 | 11:41:13 | Preparing package compilation: Finding packages to compile (00:00:01)
Task 3266 | 11:41:15 | Updating instance nats: nats/9eec3d9d-5d82-47c9-b5b2-115327d1a52a (0) (00:00:30)
Task 3266 | 11:41:45 | Updating instance nats: nats/832490c3-4f6f-4e8a-8909-22b373719536 (1) (00:00:29)

Running the bosh events command shows only this for the updated instances:
az: z1
changes:
  - configuration

Is there something in the template file which might cause a redeploy?
Environment
BOSH version: 264.7.0
BOSH cli version: 2.0.48

I don't think the following code is doing what you want...
<%=
  nats_port = p('nats.port')
  respond_to?(:if_link) && if_link("nats") do |link|
    nats_port = link.p("nats.port")
  end
%>

The if_link is not technically a boolean statement, but will always return an object which has an else method (to support the else behavior). Because of this, the value being returned is always going to end up being an in-memory object reference. Since you're outputting the result via <%= ... %>, this memory reference is rendered to template and changes every time, director wants to update the templates. You can probably verify the behavior by seeing what ended up in that template file on the VM; probably something like the following...
#<Bosh::Template::EvaluationContext::InactiveElseBlock:0x00007fdd049545f0>

init_config:
...

The easiest solution is probably to switch to <% ... %> and avoid printing anything since that code looks more like setup.
One other useful tip for the future. Since bosh-agent currently keeps a previous version of templates on the VM, when you notice unexpected changes, you can often diff between previous and current versions of the rendered templates with something like diff -r /var/vcap/data/jobs/myjob/{oldid,newid}.

@dpb587-pivotal oh wow, thanks, this is a hilarious mistake :D I didn't even realise it until now that we accidentally used <%=. And because of the starting # it didn't cause any issues in the yaml file.
Solved :)

Thanks @dpb587-pivotal !


sql file for db

Hello, not really an issue more of a question. Is there a location where I could download the sql file for importing into mysql workbench?
Thanks!

The link to a PostgreSQL dump is at the bottom of the project's README: https://github.com/BurntSushi/nfldb
We don't support MySQL and don't have any plans to. Sorry.


fix loading filters.py using importlib

Regression from: https://github.com/saimn/sigal/commit/ceab382e0252c4d7b25f8c2905b64628a9e15ba6
Ref: https://docs.python.org/3/library/importlib.html#importing-a-source-file-directly
Fixes https://github.com/saimn/sigal/issues/451

Thanks for the fix! Do you think you could try to add a unit test for this ? Would be great to make sure this feature is not broken again.

That would definitely be a good idea. But, after an hour trying to implement it, I'm out of ideas how to do it. The sample project under tests uses a built-in theme and the filter is loaded from the theme root with no way to override (but even when copied there, it's not loaded). Do you have some suggestions what would be a good way to implement this?
filters.py:
def test_filter():
    return "filter 'test_filter' is working"

--- a/tests/sample/pictures/index.md
+++ b/tests/sample/pictures/index.md
@@ -15,3 +15,7 @@ in urna ultrices accumsan. Donec sed odio eros. Donec viverra mi quis quam
 pulvinar at malesuada arcu rhoncus. Cum sociis natoque penatibus et magnis dis
 parturient montes, nascetur ridiculus mus. In rutrum accumsan ultricies.
 Mauris vitae nisi at sem facilisis semper ac in est.
+
+## Filter test
+
+{{ test_filter }}

Yeah I agree it's not the easiest to test. I will have a look when I can but my time for sigal is also limited so no worries, and let's at least merge the fix. Thanks for contributing !


Add loading feedback

Briefing
While downloading the page, we should present some loading feedback for the user. https://github.com/briandowns/spinner looks like the right tool for it.
Tasks

[ ] Add spinner while scraping

Hey there! I would like to pick this up.


[WIP] trafficshape: simulate mobile latency and bandwidth conditions

This still needs some more debug logging added throughout.


Only implementing ConfigureAppConfiguration from FunctionsStartup as per documentation does not compile

Following the tutorial on how to use dependency injection for azure functions, the code under the subtitle "Customizing configuration sources" results in error:
Abstract inherited member 'void Microsoft.Azure.Functions.Extensions.DependencyInjection.FunctionsStartup.Configure(IFunctionsHostBuilder)' is not implemented
The code snippet causing the error is as follows:
using System.IO;
using Microsoft.Azure.Functions.Extensions.DependencyInjection;
using Microsoft.Extensions.Configuration;
using Microsoft.Extensions.DependencyInjection;

[assembly: FunctionsStartup(typeof(MyNamespace.Startup))]

namespace MyNamespace
{
    public class Startup : FunctionsStartup
    {
        public override void ConfigureAppConfiguration(IFunctionsConfigurationBuilder builder)
        {
            FunctionsHostBuilderContext context = builder.GetContext();

            builder.ConfigurationBuilder
                .AddJsonFile(Path.Combine(context.ApplicationRootPath, "appsettings.json"), optional: true, reloadOnChange: false)
                .AddJsonFile(Path.Combine(context.ApplicationRootPath, $"appsettings.{context.EnvironmentName}.json"), optional: true, reloadOnChange: false)
                .AddEnvironmentVariables();
        }
    }
}

While in another article Quickstart: Create an Azure Functions app with Azure App Configuration the missing override is present, making the code compilable:
using System;
using Microsoft.Azure.Functions.Extensions.DependencyInjection;
using Microsoft.Extensions.Configuration;

[assembly: FunctionsStartup(typeof(FunctionApp.Startup))]

namespace FunctionApp
{
    class Startup : FunctionsStartup
    {
        public override void ConfigureAppConfiguration(IFunctionsConfigurationBuilder builder)
        {
            string cs = Environment.GetEnvironmentVariable("ConnectionString");
            builder.ConfigurationBuilder.AddAzureAppConfiguration(cs);
        }

        public override void Configure(IFunctionsHostBuilder builder)
        {
        }
    }
}

I thus, expect that the first code snippet from "Customizing configuration sources" is faulty and should be changed to also contain the missing override of void Configure(IFunctionsHostBuilder builder)

Thanks @edvinkugelberg-ff !
The repo this issue has been opened on is not the one that actually contains the document you indicated needs a fix.   I will open a new one on the right repo (azure-docs) add a link to it so you can see where it moved to and then close this one.  Thanks for taking the time to point out this issue, it is very appreciated.

This issue has been moved to the azure-docs repo that contains the topic this issue is referencing.
The new tracking issue is:
azure-docs    Issue 90632


[DEPRECATION WARNING]: Using bare variables is deprecated for variable usage.

Getting this error using this role.

[DEPRECATION WARNING]: Using bare variables is deprecated. Update your playbooks so that the environment
value uses the full variable syntax ('{{yumrepo_repos}}').
This feature will be removed in a future
release. Deprecation warnings can be disabled by setting deprecation_warnings=False in ansible.cfg.

The variables should be defined like this  "{{ variable }}"  not   {{ variable}}.

I will fork and fix, expect pull request.

Please use the yum_repository module instead of this role. It's available in the Ansible 2.1.


Update instructions on how to use SQLite in UWP apps

Since the walkthrough in Getting started with EF Core on Universal Windows Platform (UWP) with a New Database isn't available anymore, this is the only official documentation on how to use SQLite with a UWP app.
These instructions, however, doesn't work. Since the DataAccessLibrary is a .NET Standard project, it can't use Windows.Storagenamespace, used in InitializeDatabase() method and others. In this way, the project does not compile, making the entire process unsuccessful.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6c591596-d202-244c-6fbf-31c288fe9b57
Version Independent ID: 1473907c-0cba-8917-2fd8-d3ca1fb73cae
Content: Use a SQLite database in a UWP app - UWP apps
Content Source: windows-apps-src/data-access/sqlite-databases.md
Product: uwp
Technology: data-and-files
GitHub Login: @lastnameholiu
Microsoft Alias: alholiu

I have found how to use this walkthough to use SQLite in UWP:

Forget create a .NET Standard project in your solution.
Install Microsoft.Data.SQLite.Core and SQLitePCLRaw.bundle_winsqlite3 packages.
Create DataAccess class file wherever is convenient and insert on it the code in the walkthrough.
Call DataAccess.InitializeDatabase() method in App.xaml.cs constructor.
Hit F5 and see the sun shining upon you again.

Hello. We apologize for the delay in resolving this issue. As we transition to a new feedback system, we are closing all outstanding issues. Any issues that can be addressed will be tracked using a different internal tool, and we regret that we won't be able to provide further updates on this particular matter. We value your input and assure you that all feedback is reviewed. We recommend visiting the Microsoft Q&A site, where your issue may have already been discussed.


feat(scripts): add export DOCKER_BUILDKIT=1

这个 PR 实现什么功能/修复什么问题:

[x] 功能、bugfix描述
[x] 冒烟测试

是否需要 backport 到之前的 release 分支:

release/3.6

/cc @zexi
/area scripts

Codecov Report

Merging #9559 (e52da6c) into master (331e60e) will increase coverage by 10.59%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master    #9559       +/-   ##
===========================================
+ Coverage    5.91%   16.50%   +10.59%
===========================================
  Files         843       87      -756
  Lines      130850     9120   -121730
===========================================
- Hits         7736     1505     -6231
+ Misses     122413     7483   -114930
+ Partials      701      132      -569

Flag
Coverage Δ

aFlag
16.50% <ø> (+10.59%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/cloudcommon/db/statusinfrasresource.go

pkg/compute/models/loadbalancernetworks.go

pkg/multicloud/aws/routetable.go

pkg/compute/models/zonequota.go

pkg/cloudcommon/db/quotas/errors.go

pkg/util/qemuimg/consts.go

pkg/monitor/models/metric.go

pkg/multicloud/ucloud/wire.go

pkg/compute/models/inter_vpc_network_vpc.go

pkg/compute/regiondrivers/esxi.go

... and 746 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 331e60e...e52da6c. Read the comment docs.


Documentation site review + aesthetic updates

Content

Reviews + updates wording of current docs site
Splits content into different sections
Adds docs on NhsNumber object inside Usage section

Aesthetic

Uses Carbon-now code snippet for hero section img (loses copy-paste functionality but figured people will go to Usage section anyway)
Moves main nav to top
Uses NHS Core Blue as the main colour
Adds a logo + sets favicon to something I made on Canva very quickly - to have something different to the default

Thanks @anchit-chandran - I made some changes of my own and merged this PR via a branch anchit-edits-reviewed-marcus forked from your PR branch. Some reverts to your stylistic choices, the most prominent being reverting back to a code snippet rather than a Carbon snippet, hope you don't mind, but clippability is king for me.


rbac kubernetes cluster cannot dial apiserver

install k8s use kudeadm with default settings, and installed calico pod networks.
follow the instruction of influxdb section of  Readme
found that heapter pod cannot dial api server, report   2017-05-19T02:19:48.713825123Z E0519 02:19:48.713791       1 reflector.go:190] k8s.io/heapster/metrics/processors/namespace_based_enricher.go:84: Failed to list *v1.Namespace: Get https://kubernetes.default/api/v1/namespaces?resourceVersion=0: dial tcp <IP_ADDRESS>:443: i/o timeout
heapster run as service account  heapster, there seemed that the serviceaccount have not permission to access api, and after applied   heapster-rbac.yaml, still not worked.
I guest  heapster-rbac.yaml just defined clusterRoleBinding, but there have not defined the  clusterRole.

@jeffery9 please check your cluster‘s dns is ok？

DNS works OK,
E0520 01:18:55.360650       1 reflector.go:190]
k8s.io/heapster/metrics/util/util.go:51: Failed to list *v1.Node: Get
https://kubernetes.default/api/v1/nodes?resourceVersion=0: dial tcp
<IP_ADDRESS>:443: i/o timeout

On 20 May 2017 at 02:08, jiahuang<EMAIL_ADDRESS>wrote:

@jeffery9 https://github.com/jeffery9 please check your cluster‘s dns
is ok？
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes/heapster/issues/1648#issuecomment-302772869,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABVuLGV7RnZkP7S4hLF8wXvzqOqslPtRks5r7dqkgaJpZM4NgATJ
.

--
Jeffery        -odoo expert form kunshan, suzhou, china
IM Q913547235

So, there error that you got doesn't look like an RBAC error, it looks like a networking error.

In your networking setup, are pods able to access the API server?

@jeffery9 Could you do wget https://kubernetes.default/api/v1/namespaces?resourceVersion=0 in the heapster pod?

I have same issue with kuberenetes 1.8.
What I see in a container when running "nslookup kubernetes.default" is this:
;; reply from unexpected source: <IP_ADDRESS>#53, expected <IP_ADDRESS>#53
Seems trying to access the dns via entrypoint ip (<IP_ADDRESS>)  and not via the service ip (<IP_ADDRESS>)
Probably the same occurs in the  "heapster" container, causing the time-out.
Any resolution to the issue?

I have same issue
E1211 09:36:32.417400       1 reflector.go:190] k8s.io/heapster/metrics/util/util.go:51: Failed to list *v1.Node: Get https://kubernetes.default/api/v1/nodes?resourceVersion=0: dial tcp <IP_ADDRESS>:443: i/o timeout
E1211 09:36:32.418520       1 reflector.go:190] k8s.io/heapster/metrics/heapster.go:322: Failed to list *v1.Pod: Get https://kubernetes.default/api/v1/pods?resourceVersion=0: dial tcp <IP_ADDRESS>:443: i/o timeout
E1211 09:36:32.421626       1 reflector.go:190] k8s.io/heapster/metrics/processors/namespace_based_enricher.go:84: Failed to list *v1.Namespace: Get https://kubernetes.default/api/v1/namespaces?resourceVersion=0: dial tcp <IP_ADDRESS>:443: i/o timeout

/reopen

I figured out that the example pulles the tag v1.4.2. If I pull the image v1.5.2 I am not able to reproduce the bug anymore. I will propose another MR to refresh containers. Sorry about the noise


The result isn't always accurate, how can I improve it ?

Hi,
I notice the result not always accurate
but some apps like "Lensto"
it get better result
why there is different result even if we use same model ?
and how can I improve result ?
for example I test this image
https://unsplash.com/photos/lmLbkVsCnCA
on my app and https://silueta.me we get this result

but on Lensto

same thing with this image
https://unsplash.com/photos/ehdI_89nzMo

usually the performance of u2net could be finetuned by using more dataset.
On Sun, Aug 28, 2022 at 5:45 AM Basil Baragabah @.***>
wrote:

Hi,
I notice the result not always accurate
but some apps like "Lensto
https://apps.apple.com/in/app/lensto-background-changer/id1574844033"
it get better result
why there is different result even if we use same model ?
and how can I improve result ?
for example I test this image
https://unsplash.com/photos/lmLbkVsCnCA
on my app and https://silueta.me we get this result
[image: Screen Shot 2022-08-28 at 3 33 47 PM]
https://user-images.githubusercontent.com/16876982/187074319-8699151f-ba4f-4622-8868-b5e47f3dc7b4.png
but on Lensto
[image: image]
https://user-images.githubusercontent.com/16876982/187074391-db0769f1-ce3d-4b6d-911b-a17b8c6d26e4.png
same thing with this image
https://unsplash.com/photos/ehdI_89nzMo
[image: Screen Shot 2022-08-28 at 3 41 35 PM]
https://user-images.githubusercontent.com/16876982/187074642-dc9e010a-519a-4512-afa7-b87b8a89168a.png
[image: image]
https://user-images.githubusercontent.com/16876982/187074662-60e5050e-2e4c-4219-88ea-c849e16723b1.png
—
Reply to this email directly, view it on GitHub
https://github.com/xuebinqin/U-2-Net/issues/326, or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADSGORMLSEF35LQ6DWTQTU3V3NNN7ANCNFSM573AN6XA
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

--
Xuebin Qin
PhD
Department of Computing Science
University of Alberta, Edmonton, AB, Canada
Homepage: https://xuebinqin.github.io/


ruv.is downloading wrong files

DO NOT REMOVE OR SKIP THE ISSUE TEMPLATE

[X] I understand that I will be blocked if I intentionally remove or skip any mandatory* field

Checklist

[X] I'm reporting that yt-dlp is broken on a supported site
[X] I've verified that I have updated yt-dlp to nightly or master (update instructions)
[X] I've checked that all provided URLs are playable in a browser with the same IP and same login details
[X] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[X] I've searched known issues and the bugtracker for similar issues including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue
[ ] I've read about sharing account credentials and I'm willing to share it if required

Region
Iceland
Provide a description that is worded well enough to be understood
When downloading multiple episodes of a series from ruv.is, yt-dlp will download the same file again and again.
For example, here are 3 different episodes https://www.ruv.is/sjonvarp/spila/blaeja-ii/34551/a9g453
yt-dlp will download the same video file for each of the 3 URLs
Provide verbose output that clearly demonstrates the problem

[X] Run your yt-dlp command with -vU flag added (yt-dlp -vU <your command line>)
[ ] If using API, add 'verbose': True to YoutubeDL params instead
[X] Copy the WHOLE output (starting with [debug] Command-line config) and insert it below

Complete Verbose Output
M:\OneDrive\ruv-downloader>yt-dlp -vU https://www.ruv.is/sjonvarp/spila/blaeja-ii/34551/a9g453
[debug] Command-line config: ['-vU', 'https://www.ruv.is/sjonvarp/spila/blaeja-ii/34551/a9g453']
[debug] Encodings: locale cp1252, fs utf-8, pref cp1252, out utf-8, error utf-8, screen utf-8
[debug] yt-dlp version<EMAIL_ADDRESS>from yt-dlp/yt-dlp-nightly-builds [85b33f5c1] (win_exe)
[debug] Python 3.8.10 (CPython AMD64 64bit) - Windows-10-10.0.22631-SP0 (OpenSSL 1.1.1k  25 Mar 2021)
[debug] exe versions: ffmpeg 2024-01-01-git-e1c1dc8347-essentials_build-www.gyan.dev (setts), ffprobe 2024-01-01-git-e1c1dc8347-essentials_build-www.gyan.dev
[debug] Optional libraries: Cryptodome-3.19.1, brotli-1.1.0, certifi-2023.11.17, mutagen-1.47.0, requests-2.31.0, sqlite3-3.35.5, urllib3-2.1.0, websockets-12.0
[debug] Proxy map: {}
[debug] Request Handlers: urllib, requests, websockets
[debug] Loaded 1798 extractors
[debug] Fetching release info: https://api.github.com/repos/yt-dlp/yt-dlp-nightly-builds/releases/latest
Latest version<EMAIL_ADDRESS>from yt-dlp/yt-dlp-nightly-builds
yt-dlp is up to date<EMAIL_ADDRESS>from yt-dlp/yt-dlp-nightly-builds)
[ruv.is:spila] Extracting URL: https://www.ruv.is/sjonvarp/spila/blaeja-ii/34551/a9g453
[ruv.is:spila] a9g453: Downloading JSON metadata

[debug] Formats sorted by: hasvid, ie_pref, lang, quality, res, fps, hdr:12(7), vcodec:vp9.2(10), channels, acodec, size, br, asr, proto, vext, aext, hasaud, source, id
[debug] Default format spec: bestvideo*+bestaudio/best
[info] a9g453: Downloading 1 format(s): 3677
[debug] Invoking hlsnative downloader on "https://ruv-vod.akamaized.net/lokad/5350560T0/3600/index.m3u8"
[hlsnative] Downloading m3u8 manifest
[hlsnative] Total fragments: 71
[download] Destination: Jólasund [a9g453].mp4
[debug] File locking is not supported. Proceeding without locking
[download] 100% of  187.53MiB in 00:00:06 at 29.41MiB/s
[debug] ffprobe command line: ffprobe -hide_banner -show_format -show_streams -print_format json "file:Jólasund [a9g453].mp4"
[debug] ffmpeg command line: ffprobe -show_streams "file:Jólasund [a9g453].mp4"
[FixupM3u8] Fixing MPEG-TS in MP4 container of "Jólasund [a9g453].mp4"
[debug] ffmpeg command line: ffmpeg -y -loglevel "repeat+info" -i "file:Jólasund [a9g453].mp4" -map 0 -dn -ignore_unknown -c copy -f mp4 "-bsf:a" aac_adtstoasc -movflags "+faststart" "file:Jólasund [a9g453].temp.mp4"

M:\OneDrive\ruv-downloader>yt-dlp -vU https://www.ruv.is/sjonvarp/spila/blaeja-ii/34551/a9g44i
[debug] Command-line config: ['-vU', 'https://www.ruv.is/sjonvarp/spila/blaeja-ii/34551/a9g44i']
[debug] Encodings: locale cp1252, fs utf-8, pref cp1252, out utf-8, error utf-8, screen utf-8
[debug] yt-dlp version<EMAIL_ADDRESS>from yt-dlp/yt-dlp-nightly-builds [85b33f5c1] (win_exe)
[debug] Python 3.8.10 (CPython AMD64 64bit) - Windows-10-10.0.22631-SP0 (OpenSSL 1.1.1k  25 Mar 2021)
[debug] exe versions: ffmpeg 2024-01-01-git-e1c1dc8347-essentials_build-www.gyan.dev (setts), ffprobe 2024-01-01-git-e1c1dc8347-essentials_build-www.gyan.dev
[debug] Optional libraries: Cryptodome-3.19.1, brotli-1.1.0, certifi-2023.11.17, mutagen-1.47.0, requests-2.31.0, sqlite3-3.35.5, urllib3-2.1.0, websockets-12.0
[debug] Proxy map: {}
[debug] Request Handlers: urllib, requests, websockets
[debug] Loaded 1798 extractors
[debug] Fetching release info: https://api.github.com/repos/yt-dlp/yt-dlp-nightly-builds/releases/latest
Latest version<EMAIL_ADDRESS>from yt-dlp/yt-dlp-nightly-builds
yt-dlp is up to date<EMAIL_ADDRESS>from yt-dlp/yt-dlp-nightly-builds)
[ruv.is:spila] Extracting URL: https://www.ruv.is/sjonvarp/spila/blaeja-ii/34551/a9g44i
[ruv.is:spila] a9g44i: Downloading JSON metadata
[ruv.is:spila] a9g44i: Downloading m3u8 information
[debug] Formats sorted by: hasvid, ie_pref, lang, quality, res, fps, hdr:12(7), vcodec:vp9.2(10), channels, acodec, size, br, asr, proto, vext, aext, hasaud, source, id
[debug] Default format spec: bestvideo*+bestaudio/best
[info] a9g44i: Downloading 1 format(s): 3677
[debug] Invoking hlsnative downloader on "https://ruv-vod.akamaized.net/lokad/5350560T0/3600/index.m3u8"
[hlsnative] Downloading m3u8 manifest
[hlsnative] Total fragments: 71
[download] Destination: Jólasund [a9g44i].mp4
[debug] File locking is not supported. Proceeding without locking
[download] 100% of  187.53MiB in 00:00:06 at 29.43MiB/s
[debug] ffprobe command line: ffprobe -hide_banner -show_format -show_streams -print_format json "file:Jólasund [a9g44i].mp4"
[debug] ffmpeg command line: ffprobe -show_streams "file:Jólasund [a9g44i].mp4"
[FixupM3u8] Fixing MPEG-TS in MP4 container of "Jólasund [a9g44i].mp4"
[debug] ffmpeg command line: ffmpeg -y -loglevel "repeat+info" -i "file:Jólasund [a9g44i].mp4" -map 0 -dn -ignore_unknown -c copy -f mp4 "-bsf:a" aac_adtstoasc -movflags "+faststart" "file:Jólasund [a9g44i].temp.mp4"

24.12.2023  08:13       188.590.199 Jólasund [a9g44i].mp4
24.12.2023  08:13       188.590.199 Jólasund [a9g453].mp4

if I then close the terminal window and run the second yt-dlp command again, it will download the right file
`M:\OneDrive\ruv-downloader>yt-dlp -vU https://www.ruv.is/sjonvarp/spila/blaeja-ii/34551/a9g44i
[debug] Command-line config: ['-vU', 'https://www.ruv.is/sjonvarp/spila/blaeja-ii/34551/a9g44i']
[debug] Encodings: locale cp1252, fs utf-8, pref cp1252, out utf-8, error utf-8, screen utf-8
[debug] yt-dlp version<EMAIL_ADDRESS>from yt-dlp/yt-dlp-nightly-builds [85b33f5c1] (win_exe)
[debug] Python 3.8.10 (CPython AMD64 64bit) - Windows-10-10.0.22631-SP0 (OpenSSL 1.1.1k  25 Mar 2021)
[debug] exe versions: ffmpeg 2024-01-01-git-e1c1dc8347-essentials_build-www.gyan.dev (setts), ffprobe 2024-01-01-git-e1c1dc8347-essentials_build-www.gyan.dev
[debug] Optional libraries: Cryptodome-3.19.1, brotli-1.1.0, certifi-2023.11.17, mutagen-1.47.0, requests-2.31.0, sqlite3-3.35.5, urllib3-2.1.0, websockets-12.0
[debug] Proxy map: {}
[debug] Request Handlers: urllib, requests, websockets
[debug] Loaded 1798 extractors
[debug] Fetching release info: https://api.github.com/repos/yt-dlp/yt-dlp-nightly-builds/releases/latest
Latest version<EMAIL_ADDRESS>from yt-dlp/yt-dlp-nightly-builds
yt-dlp is up to date<EMAIL_ADDRESS>from yt-dlp/yt-dlp-nightly-builds)
[ruv.is:spila] Extracting URL: https://www.ruv.is/sjonvarp/spila/blaeja-ii/34551/a9g44i
[ruv.is:spila] a9g44i: Downloading JSON metadata
[ruv.is:spila] a9g44i: Downloading m3u8 information
WARNING: [ruv.is:spila] Ignoring subtitle tracks found in the HLS manifest; if any subtitle tracks are missing, please report this issue on  https://github.com/yt-dlp/yt-dlp/issues?q= , filling out the appropriate issue template. Confirm you are on the latest version using  yt-dlp -U
[debug] Formats sorted by: hasvid, ie_pref, lang, quality, res, fps, hdr:12(7), vcodec:vp9.2(10), channels, acodec, size, br, asr, proto, vext, aext, hasaud, source, id
[debug] Default format spec: bestvideo*+bestaudio/best
[info] a9g44i: Downloading 1 format(s): 3844
[debug] Invoking hlsnative downloader on "https://ruv-vod.akamaized.net/lokad/5356489A0/3600/index.m3u8"
[hlsnative] Downloading m3u8 manifest
[hlsnative] Total fragments: 70
[download] Destination: Kaffihús [a9g44i].mp4
[debug] File locking is not supported. Proceeding without locking
[download] 100% of  194.10MiB in 00:00:09 at 20.01MiB/s
[debug] ffprobe command line: ffprobe -hide_banner -show_format -show_streams -print_format json "file:Kaffihús [a9g44i].mp4"
[debug] ffmpeg command line: ffprobe -show_streams "file:Kaffihús [a9g44i].mp4"
[FixupM3u8] Fixing MPEG-TS in MP4 container of "Kaffihús [a9g44i].mp4"
[debug] ffmpeg command line: ffmpeg -y -loglevel "repeat+info" -i "file:Kaffihús [a9g44i].mp4" -map 0 -dn -ignore_unknown -c copy -f mp4 "-bsf:a" aac_adtstoasc -movflags "+faststart" "file:Kaffihús [a9g44i].temp.mp4"
24.12.2023  08:13       188.590.199 Jólasund [a9g44i].mp4
24.12.2023  08:13       188.590.199 Jólasund [a9g453].mp4
11.12.2023  16:26       196.901.823 Kaffihús [a9g44i].mp4
`

Can confirm this happened to me on January 1st when downloading another series from their site. A workaround for me was to play a few seconds of the clip I wanted, wait 5-10 seconds, and then download that single clip with --no-playlist, repeat for each clip. If I don't wait 5-10 seconds, the previous clip will be downloaded instead. There seems to be a delay until yt-dlp can retrieve the correct file URL.
I could see which clip would've downloaded if I simulated the download and instructed yt-dlp to only output a json. Repeat the command and one can see when it's safe to download the correct clip.


Pure nix yarn.lock parsing

Hi there,
I've implemented a pure nix yarn.lock parser: https://gist.github.com/bouk/95f565b744168a3a0fcf396c1ebb805e
I was thinking this can be used in js2nix so it can work without having to generate and commit a yarn.lock.nix file. This would make the user experience a lot nicer since you'd only have to run yarn update to upgrade a version for example, without having to then run js2nix as well. Let me know if this is useful and if you need any help integrating it!

The readFile would cause an IFD if the yarn.lock file was generated as well, so if you're packaging up your own code that should be fine.

Oh, you are right. I read it again and it seesms as long as you readFile not from derivation (f drv) it should be fine.
Wow, that’s actually looks exciting if we can remove IFD from this tool. The IFD not a blocker for us at the moment but brings some complexity into pipelines and definitely slows down parallel Nix code evaluation. Thanks for your suggestion, looks forward to get the change in :-)

Thinking about it some more, I think the IFD would only appear if you are packaging an external source, that is you're using js2nix on a project fetched from GitHub or something—in that case you'd need to vendor the yarn.lock.


Concatenate Overlapping mne.annotations

In cases where there are multiple subsequent Epochs that are all annotated with the same pylossless flag (i.e. flag_ch_sd_epoch),  or where there is a small gap annotation (i.e. flag_ch_sd_epoch - gap -  flag_ch_sd_epoch ), I think we can concatenate these annotations to be a single annotation.

This will make adjusting these annotations in the qcr dashboard easier, and makes reading the annotation labels easier.
This shouldn't be too hard. Probably similar to the code we wrote for overlapping eyetracking annotations in MNE.

Sounds reasonable to me...


Roadmap

Road to 1.0

[x] Integration tests for the security middleware
[x] Review SecurityMiddlewareTest assertions (and label the data fixtures to see if we're hitting all the main points)
[x] Port DoctrineMiddlewarePass away from mocks (see https://github.com/thephpleague/tactician-bundle/blob/master/tests/DependencyInjection/Compiler/DoctrineMiddlewarePassTest.php for an example)
[x] Port CommandHandlerPassTest away from mocks
[x] Port ContainerBasedHandlerLocator away from mocks
[x] Fix incorrect docblocks (a number of them are missing type annotations, have old params, etc)
[x] Review Documentation

Post 1.0

[ ] Reduce complexity of main compiler pass
[ ] Add Autowiring features (see #44)
[x] Add SecurityMiddlewarePassTest
[x] Add ValidatorMiddlewarePassTest

The two big themes with 1.0 are

increasing full test coverage of the security middleware: @RonRademaker has done a great job here and the code looks robust but before we ship this, we need to be damn sure it works correctly. Especially because I think many people will use this feature by just hooking it up straight to a web accessible endpoint because "REST doesn't work with DDD 🙄"

making the test suite more readable: the test suite is brittle and full of unnecessary mocks. If we release and receive bugs, I'd like to make it easy for folks to follow the tests and send PRs. I've ported the Doctrine one as a sample and the results are promising, I think.

As a pet feature, I'd like to reduce the complexity of the main compiler pass but that can wait until after 1.0.
How does this sound to everyone? Feedback is absolutely welcome and I'll update this issue to reflect the roadmap as we go.
/cc @tyx @RonRademaker @chalasr @frankdejonge @rdohms

and 5) of Road to 1.0 addressed in #48

I give a try to the integration test of the SecurityMiddleware but with the following lines
$authenticationManager = static::$kernel->getContainer()->get('security.authentication.manager');
$authenticationManager->authenticate(new UsernamePasswordToken('admin', 'kitten', 'main', ['ROLE_ADMIN']));

I get
Symfony\Component\Security\Core\Exception\AuthenticationCredentialsNotFoundException: The token storage contains no authentication token. One possible reason may be that there is no firewall configured for this URL.
I don't get how to handle that. I should admit I have a very small experience with this component. If anyone know how to simply authenticate a user with a single password without Request

Hmm, I haven't had this problem myself, but this might help?
http://symfony.com/doc/current/testing/http_authentication.html
The WebTestCase base class used above is just a thin addition to the same KernelTestCase base classes we use, some I imagine the same solutions apply.

Addressed number 2 in #49

Fix incorrect docblocks (a number of them are missing type annotations, have old params, etc)

Fixed in #51

Add SecurityMiddlewarePassTest
Add ValidatorMiddlewarePassTest

fixed in #52 , good to have

increasing full test coverage of the security middleware

@RonRademaker Would you mind looking at this? Otherwise I can pick it, but I would first have to look at this middleware.

I'll have some time to look at that in the upcoming days 👍

Am I mistaken or do we only need to review the docs for a v1 to be out?

Unfortunately, I found some issues with the security unit tests, documented in #54. I have to offline for a family event, I'm blocking in some time to go forward with review on Saturday though.

@rosstuck I'll have a look at these meanwhile, maybe submit a PR on your cleanup branch

I'm on vacation right now but since we're not making much progress on getting the security issues figured out, I propose we disable/remove them for the time being so we can ship a release that will help the issues 3.3 users are experiencing. I feel bad doing this but I think it's the best option right now. If there's no complaints or alternate suggestions, I'll start on this next week

I'm fine with postponing security related features.

I'd like to see the security middleware in the next release (as I'm already using it in a project that is currently in development, but will be in production in a few months). I'm not exactly clear what the security issues are ATM. Are these clear so I can invest some time to address them?

I'd like to see it there as well because you have really been put through
the wringer over it. The issues are entirely the test suite, I'm very
hesitant to ship a security related piece without full integration tests.
On Jul 19, 2017 9:42 AM, "Ron Rademaker"<EMAIL_ADDRESS>wrote:

I'd like to see the security middleware in the next release (as I'm
already using it in a project that is currently in development, but will be
in production in a few months). I'm not exactly clear what the security
issues are ATM. Are these clear so I can invest some time to address them?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/thephpleague/tactician-bundle/issues/47#issuecomment-316300172,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAI9To7uXF9VQOA9nxjEOq8nDkb1X7qJks5sPbNegaJpZM4NuFaX
.

Moving again on #54, will do a bit more tomorrow as well (look at Scrutinizier issues, etc)

Okay, I've finished tests, updated the docs and walked through all the README examples in a fresh Symfony install. So far it looks really good!
The only thing that smacked me in the face was when I tried to run a command as an anon user. Symfony doesn't automatically give a base ROLE_USER role so there's no way to configure some commands right now to be runnable by base users (say, sign me up for the newsletter) and some to be authenticated users (bill this user) without splitting them into two separate buses or overwriting the token in token storage. We might want to address this or at least give a way of mitigating it in the docs.
Still, I don't see that as a blocker, so I'm thinking I'll tag an RC for 1.0 today and we can get that out there for some install and feedback! Sound good? :)

:+1:

👍

The only thing that smacked me in the face was when I tried to run a command as an anon user. Symfony doesn't automatically give a anon ROLE_USER role so there's no way to configure some commands right now to be runnable by anon users (say, sign me up for the newsletter) and some to be authenticated users (bill this user) without splitting them into two separate buses or overwriting the token in token storage. We might want to address this or at least give a way of mitigating it in the docs.

I've also ran into this issue and worked around it using my own authorization checker with a dedicated CLI role, something like:
use Symfony\Component\Security\Core\Authorization\AuthorizationCheckerInterface;

class WorkaroundAuthorizationChecker implements AuthorizationCheckerInterface
{
    /**
     * Container to retrieve the actual authorization checker from.
     *
     * @var Container
     */
    private $container;

    /**
     * AuthorizationCheckerFacade constructor.
     *
     * @param Container $container
     */
    public function __construct(Container $container)
    {
        $this->container = $container;
    }

    /**
     * Proxy to the authorization checker in the container.
     *
     * @param mixed $attributes
     * @param null $object
     *
     * @return bool
     */
    public function isGranted($attributes, $object = null): bool
    {
        $tokenStorage = $this->container->get('security.token_storage');

        if (null === ($token = $tokenStorage->getToken()) && php_sapi_name() ==='cli') {
            // workaround because cli wouldn't have a token
            $tokenStorage->setToken(
                new AnonymousToken('cli', 'anon', [new Role('ROLE_CLI'), new Role('IS_AUTHENTICATED_ANONYMOUSLY')])
            );
        }

        return $this->container->get('security.authorization_checker')->isGranted($attributes, $object);
    }
}

This is the auth checker I inject in the security middleware.

It's been a couple weeks and I haven't heard of any major issues except the auth ones above, so I'll tag 1.0 today.

Indeed ! we are using the RC1 since the release and everything is fine.

Released, congrats and thanks again to everyone for all your hard work! 😄
Going forward, I think #44 and #60 are high on my priority list. Also, if y'all are interested, someone's also opened a PR for this bundle in the Symfony recipes repo https://github.com/symfony/recipes-contrib/pull/71#discussion_r135396790

I've just merged #67 into master. This adds the ability to have automatic wiring/mapping strategies. If y'all can give this a shot in your applications and open bugs for anything broken, I would greatly appreciate it!
See https://github.com/thephpleague/tactician-bundle#configuring-command-handlers to get started
Also, if you try using this in combination with the Symfony autowiring strategies, please post a sample of your config. I'd love to see what this looks like for most folks and get some samples into the documentation.
Thanks a ton!

Oh and I've updated the roadmap to push the new tactician:debug command to the next release since it's not a must-have IMHO and I don't have the energy to pick it up right now. If anyone is interested in doing so, please post on #71.

Also, if you try using this in combination with the Symfony autowiring strategies, please post a sample of your config. I'd love to see what this looks like for most folks and get some samples into the documentation.

I have about 100 commands in my app, so I have a seperate command_handler.yml for the handler service definitions. Here is a before and after:
Before
services:
    onlinetennis.command_handler.cancel_showmatch_request:
        class: AppBundle\CommandHandler\CancelShowmatchRequestHandler
        arguments<EMAIL_ADDRESS><EMAIL_ADDRESS>        tags:
            - { name: tactician.handler, command: Domain\Command\CancelShowmatchRequest }
    // 500 more lines

After
services:
    AppBundle\CommandHandler\:
        resource: "../../CommandHandler"
        autowire: true
        autoconfigure: true
        public: true
        tags:
            - { name: tactician.handler, typehints: true }

@rosstuck Are you planning to tag the v1.1 in the near future? If you want to give it some more time, would it be possible to tag a v1.1-RC1 as you did with v1.0?

Hey @dmecke, I was hoping #73 would land first (since that would be good to have for folks struggling with the new system) but if that's gonna take a bit longer, then I can tag an RC-ish thing tomorrow.

Tagged v1.1-RC1

#73 has landed, so there's now a debug command for seeing which commands are mapped to which services! Will review docs and update changelog, etc in next couple days then cut 1.1.0 if there's no blockers.
In the meantime, if anyone is interested in giving the debug command a spin on their full app, let me know if it works out for you. 👍

Just tried on an app with ~70 handlers, works fine 👍  (nice work @kejwmen)
I'm just wondering if debug:tactician would've been acceptable instead of tactician:debug as for other debug commands, even if it's not a symfony core one.

Good idea! Changed the command name for consistency. I've also tweaked a couple docs and cut the release, v1.1.0 is out. If anyone finds any bugs, please open an issue.
Otherwise, thanks for all your hardwork and testing, everyone :)

Tagged 1.1.1 (fixes an error using the default bus when absolutely no config is defined, improved version constraints, better docs, no BC breaks)

Split validator middleware into separate package?

@rosstuck we're using the validator middleware with tactician in a Zend Expressive application and we just have some SF packages installed because of this bundle. With that said, could we help with splitting that middleware to another package? It should be pretty straightforward but what are your thoughts on this?

@lcobucci : there is a pending PR regarding the validator middleware extraction -> #74


chore: add datetime from gef to shim

LGTM! 👍

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

2 of 2 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 87.321%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
978

Relevant Lines:
1120

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

2 of 2 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 87.321%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
978

Relevant Lines:
1120

💛  - Coveralls


[Docs] add Chinese version of conventions

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
This PR adds Chinese version of conventions.md
Modification
This PR adds Chinese version of conventions.md

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

openmmlab算法挑战赛任务


Fix sync-mirror.yml workflow

Currently this workflow is being skipped because the name of the repository that we're checking for is subtly wrong (there's an extra .git on the end of it). Fix this.
Closes #9.

@djmaxus I'm afraid I'm on leave next week, so feel free to merge this if you're happy with it but if it's still not working, it'll have to wait till I get back. Hopefully this will sort it though :crossed_fingers:


It connects but doesn’t work.

*Describe the bug
A description of what the bug is.
I don’t think it is a bug, I just think it doesn’t work for me. I. Just bought my bike second hand and the bike has a speed limiter. I don’t want the speed limiter I just want to go 45 kmph. I tried to do it with the app and it connects with the bike with Bluetooth but then it just doesn’t do anything to the bike. It doesn’t go faster the lights do go on and of. Can you help me with this issue?
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Tap on '....'
Scroll down to '....'
See error

Expected behavior
A description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Bike (please complete the following information):

Model: [e.g. RX] I have the super 73 zx moon rock
Region: [e.g. US]
Updated Firmware?

Smartphone (please complete the following information):

Device: [e.g. iPhone6] iPhone 14
OS: [e.g. iOS8.1] 17.5.1
Browser [e.g. stock browser, safari] safari
Version [e.g. 22] 0.5.0

Additional context
Add any other context about the problem here.

@floris02fg
Can you try using the official Super73 app first.
See if you can update the firmware as well.
See if you can change modes on the super73 app to mode4.
If it works then close the official app, turn off&on the bike, then try with the SuperDuper app.

Okay, I will try but first I have to register the bike with super 73.

I've just updated SD with a new architecture that should work for more people. It might be worth trying again. That being said, it sounds like the bike is on an older firmware that this app does not support. If that's the case, you'll need to update the bike through the official app.

Okay I will try that! Thank you!
Op vr 28 jun 2024 om 20:00 schreef Bo Lopker @.***>

I've just updated SD with a new architecture that should work for more
people. It might be worth trying again. That being said, it sounds like
the bike is on an older firmware that this app does not support. If that's
the case, you'll need to update the bike through the official app.
—
Reply to this email directly, view it on GitHub
https://github.com/blopker/superduper/issues/36#issuecomment-2197404379,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BJFKTJ6FRIVVKJP5IELC6GTZJWQCPAVCNFSM6AAAAABJJF7GT6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOJXGQYDIMZXHE
.
You are receiving this because you were mentioned.Message ID:
@.***>