Add UC3 and UC4

Codecov Report

Merging #29 (86ef7d3) into master (325579c) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #29   +/-   ##
=========================================
  Coverage     72.15%   72.15%
  Complexity      399      399
=========================================
  Files            70       70
  Lines          1232     1232
  Branches        125      125
=========================================
  Hits            889      889
  Misses          311      311
  Partials         32       32

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 325579c...86ef7d3. Read the comment docs.

Closes #24 and #25 .


is it possible to trigger the time-picker-overlay from a custom time-picker template?

Hello,
I want to customize the Timer in my datepicker component, but i want to use the input and also the overlay.
is it possible to hand over to the time-picker template a function to trigger the time-picker-overlay?
<VueDatePickerv-model="dateInput">
    <template #time-picker="{ toggleTimePickerOverlay }">
        <input type="time">
        <NuxtImg
            src="/chevron-down-regular.svg"
            @click="toggleTimePickerOverlay"
        />
    </template>
    <template #time-picker-overlay>
             ....
    </template>
</VueDatePicker>

It is not, when you use the time-picker slot, the overlay is replaced.


Revert "fix: when selecting categories, the selected categories get reset"

Explanation of change
Reverts Expensify/App#53519 to fix https://github.com/Expensify/App/issues/54486. The PR we're reverting uncovered that issue. There's probably a better way to fix the original issue that PR aimed to solve, without causing this bug.
Fixed Issues
$ https://github.com/Expensify/App/issues/54486

Straight revert so no need for checklists

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.


fix: log collection merges multiple lines

https://issues.redhat.com/browse/ECOPROJECT-828
log collection merges/concatenates multiple lines
Signed-off-by: Yaron Dayagi<EMAIL_ADDRESS>

@masayag @eloycoto @pkliczewski


Update CLI extensions available doc

Update CLI extensions available doc.
Triggered by Azure/azure-cli-extensions - TRAVIS_BUILD_ID=370291315
https://github.com/Azure/azure-cli-extensions/commit/6b9b2a9706fef32ab74f711d8626f2dfebfdd6e4

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs-ref-conceptual/azure-cli-extensions-list.md
:white_check_mark:Succeeded
View (azure-cli-latest) View (azure-cli-2017-03-09-profile)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


[stable/stolon] Make STKEEPER_PG_LISTEN_ADDRESS configurable

Signed-off-by: Sameer Mene<EMAIL_ADDRESS>
Is this a new chart
No
What this PR does / why we need it:
Currently there is no way to set the env variable STKEEPER_PG_LISTEN_ADDRESS in the keeper because this is always set in the command. The listen address needs to be set to "*" in certain scenarios, for example when istio sidecar injection is enabled.
Which issue this PR fixes
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

fixes # 23896

Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[X] DCO signed
[X] Chart Version bumped
[ ] Variables are documented in the README.md
[X] Title of the PR starts with chart name (e.g. [stable/mychartname])

/ok-to-test

/assign @lwolf

/lgtm


1984 - TeamSpeak Registration Deletion Fix

This PR will be easier to review with the stack trace in #1984
The TeamSpeak library is throwing an exception incorrectly.
When removing a registration, we first check that there is a privilege key in our system (stored in teamspeak_confirmation) associated with the registration being deleted.
We then delete it from TeamSpeak ($tscon->privilegeKeyDelete($this->confirmation->privilege_key);) and then remove it from our database ($this->confirmation->delete();).
The first line is throwing a TeamSpeak3_Adapter_ServerQuery_Exception exception even though the exception message is ok and the privilege key is removed on TeamSpeak. The result it that the privilege key isn't removed from our system and the registration also is not removed - throwing an error to the user.
This is not the proudest code I have ever written, but it should fix the problem for now. We need to decide on the future of TeamSpeak and if we are retaining it, it is highly likely a lot of this needs a full re-write to tidy it up...
Resolves #1984

:tada: This PR is included in version 6.5.5 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Error text when using ufetch-macos

The script runs as it should but before rest of the script loads, there's 'Warning: nothing to list' error text.

Fixed in 722490c0cba03ce2efe5eb4c6547066920c84b58, thanks!


[rewrite] Big problem with object schizophrenia

createComponent has a problem in that it creates a copy of the keys in vnode.tag, placing them in vnode.state, ignoring the prototype which may have methods required for displaying the view correctly.
vnode.instance = Vnode.normalize(view.call(vnode.state, vnode))

The above line prevents using vnode.tag, the actual object reference, as an object. When the view function is a method of the vnode.tag object, view will surprisingly be called with the vnode.state object, which looks similar to the vnode.tag object, but it isn't, so any prototype method calls in the view method will fail.

Hi @ciscoheat, good to see you again!
This should probably be documented as a gotcha — I prefer that term to 'anti-pattern' as currently used in the docs, which has a tendency to inform dogma.
Mithril has always had an idiosyncratic attitude to JS objects and this, but I think it's acceptable for Mithril to lay down the requirements for the vnode object contract — it is after all a custom type of its own devising. This leads to less runtime ambiguity, no?
What are component prototypes doing for you in your current codebase @ciscoheat?

IMHO, this is really a bug. The special hooks Mithril uses should be read up the prototype chain. Although, I'll point out that using Object.assign (or similar) instead of prototypes will alleviate this problem mostly.

@ciscoheat mea culpa... I initially used a for in loop that was visiting the prototype chain of traditional JS objects (and class instances transpiled with Babel and Bublé), but it turns out that native ES6 methods are not enumerable on instances, so I went for Object.keys.forEach(...) instead.
We could instead use vnode.state = Object.create(vnode.tag) since that function is supported by IE9.
I didn't care much about it initially because I thought that Class instances as components were a stopgap until classes as components were supported, but @lhorie delayed that until after v1, so it may be relevant again...

Hi guys, it's nice to be back. :) I'm taking the first steps toward making the rewrite work in Haxe.
@barneycarroll well, currently I cannot even do this:
function Numbers(numbers) {
	this.numbers = numbers
}

Numbers.prototype.odd = function() {
	return this.numbers.filter(function(n) { return n%2 == 1 })
}

Numbers.prototype.view = function() {
	return this.numbers.odd().map(function(n) { return m('p', n) })
}

var nums = new Numbers([1,2,3,4,5]);

m.mount(document.getElementById('content'), nums)

I would be quite disappointed if the rewrite denies me that fundamental OO notion...
@isiahmeadows and @pygy , I don't think any duplication of an object is a good solution. Identity is a fundamental part of objects as you know, losing that can lead to very subtle bugs.
My current quick-fix is to just put:
vnode.instance = Vnode.normalize(view.call(vnode.tag || vnode.state, vnode))

But of course, I have no idea if that works in general.

Sorry for the error, fixed now.

I don't think we can do without the object copying. Consider for example
function Numbers(numbers) {
	this.numbers = numbers
}

Numbers.prototype.oninit = function() {
	this.numbers = this.numbers.filter(function(n, i) { return i%2 == 1 })
}

Numbers.prototype.view = function() {
	return this.numbers.map(function(n) { return m('p', n) })
}

var nums = new Numbers([1,2,3,4,5]);

m.mount(document.body, {view: () => [m(nums), m(nums)]})

The state object must be different for each component, so vnode.tag can't pass as the state object for both, otherwise the example above would break.
The example above may seem dumb, but it's fairly idiomatic to do things like this:
things.map(thing => m(SomeComponent, {thing: thing}))

SomeComponent instances may have internal state and their states should not be shared with other instances

losing that can lead to very subtle bugs

I don't think you'd ever want to rely on equality between this (in a class method) and nums for the reason above.

I don't mind if the state object exists and is copied from the original object. But what is the problem with having this referring to the actual object? Don't you find it confusing if this becomes something else in the prototype, especially something that looks very similar to the object created from it, but isn't?

What's confusing is the expectation that a given Javascript object can fulfil both the function of a Mithril-specified vnode tag and any arbitrary external contracts. IMO your strawman  — a native Number which is also a Mithril component — is just as ambiguous a requirement as, say, a React component which is also a Mithril component, or asking why  HTMLElement.onclick = ArrayInstance.push doesn't 'just work'.
Components can be written so as to fulfil the implied desirable OOP features — common methods, inheritance, persistent state reference — but they must first and foremost conform with Mithril's component & vnode specifications.
You could write an adapter, of course, but given the flexible and often brittle potential of Javascript objects, only you can judge whether it will address your particular concerns. Something like this might work:
const NumbersComponent = {
  oninit(vnode){
    this.value = new Numbers( vnode.attrs.value )
  },

  view(){
    /**/
  }
}

for( key in Numbers.prototype )
  NumbersComponent[ key ] = function(){
    Numbers.prototype[ key ].apply( this.value, arguments )
  }

While this may end up yielding satisfactory results, it certainly isn't idiomatic Mithril. Mithril (especially as if the rewrite) defines and provides the component contract for your convenience and expects you to make whatever 'business' model bindings work within that contract.
DOMVM would seem a better fit for the strawman — it goes for flexibility over hand-holding. In its own words:

It lets you - not the view layer - dictate your app architecture.

This is a stark and exceptional reversal of the norm for view libraries inasmuch as it simply provides a low-level hyperscript and virtual DOM patching API which is left to you to decide how to integrate into your existing application architecture.

Sorry @ciscoheat, I didn't intend to disparage your argument. By 'straw man', I mean an artefact written to demonstrate a scenario (the numbers component); by 'esoteric', I mean comprising expectations that are unknowable in the receiving context — ie Numbers is esoteric in the context of Mithril. I'm trying to elucidate the nature of the unmet assumptions when trying to reconcile the behaviour of 2 constructs from different domains into a singular object that fulfils the expected behaviour of both domains.
I'm a big fan of DCI principles and don't mean to come across dismissive, but the concerns presented here aren't trivial.
Mithril tags are highly specific entities whose properties are defined and managed by Mithril — what might be considered 'esoteric' to the author of the Numbers entity.

The keyword is simplicity. It's not a React component or anything else. It's a simple object with identity, state and behavior that I would like to display with as little hassle as possible.

Mithril eschews prototypal inheritance and the other associated behaviors of Javascript 'classes' in favour of a more explicit contract. In contrast, idiomatic React usage involved extending the ReactComponent class. You could argue this is 'simpler' since it involves a common Javascript standard for defining reusable entities, given which — in the absence of any other requirements — a Numbers entity is just as simple as a ReactComponent. But even if Mithril were more 'generic' in this regard, it still comes up against the 'diamond problem' which Javascript inheritance is unable to address: how does one reconcile the intent to inherit from both Numbers and Component? The traditional abstract straw man for this problem is the task of using inheritance principles to define a Photocopier in a context where you have existing Scanner and Printer classes. It isn't straightforward using Javascript native idioms, and recent work on the language (extensions to class, static methods in place of class methods such as Object.keys) are indicative of the hidden complexity behind seemingly intuitive OOP concerns in Javascript.
FWIW you might be interested in @pygy's long standing effort into catering for divergent concerns in Mithril component definition in #1339, specifically in trying to enable components as classes and factories rather than static 'tags'.

I think there isn't really a canonical most-sensible value for this in javascript. For example, back in the jQuery days, it was really common for people to get tripped over what this was in .each even though it was logically what it was supposed to be.
In backbone, we used to have to manually rebind this everywhere because the defaults were pretty much useless.
Vue allows for stuff like this out of the box:
const Counter = {
  template: `<div>{{ count }}</div>`,
  computed: {
    count () {
      return this.$store.state.count // this != Counter.computed
    }
  }
}

But I would argue that its rebinding of this is far more useful than if it did what plain Javascript would.
IMHO, this should be what's most useful. Pointing to vnode.state seems more useful to me than pointing to vnode.tag

On a side note, #1484 is relevant to this discussion

@lhorie @ciscoheat
Here's my proposed solution:

Have vnode.state inherit prototypically from vnode.tag (the component) instead of just shallow-cloning its own properties.
Use vnode.state directly instead of depending on vnode.tag.
Don't pass vnode.state to vnode.attrs via this, but instead, pass the vnode.attrs object itself.

This will speed up creation significantly by just setting a prototype instead of copying everything, including hooks, to vnode.state (including oninit/view/etc.), and it would simplify the renderer internals quite a bit. One perk is that vnode.attrs and vnode.state could share the exact same hook invocation logic. Another is that you wouldn't have to look up vnode.tag nearly as much, mostly just to check identity.
One caveat is that vnode.state would be invalid until the component is initialized, but mutating the state directly before creation is an anti-pattern at best.

For what it's worth, this bug was likely induced by @pygy changing from the prototype-aware deep cloning to just shallow cloning with own properties.

vnode.state now inherits via prototype from vnode.tag


feat(bfdr): add support for attendant fields

Attendant Title (ATTEND), Name (ATTEND_NAME), NPI (ATTEND_NPI), and Other specified text (ATTEND_OTH_TXT)

Resolve conflicts and then we can merge this in


controlled inputs

we have react-hook-form versions of the inputs. add controlled versions for times when a controlled input is needed
v1

[ ] Input
[ ] Textarea
[ ] Select

Could punt to next task:

[ ] NumberInput
[ ] Checkbox
[ ] Radio Button

If you do Textarea plz look at #55 bg styles 🙏

Working on these and realized we'd want to add the error state handling via the FormError likely -- this is something we also probably want to add to the other Inputs that are already in the system. Thoughts @scottrepreneur ?

If you do Textarea plz look at #55 bg styles 🙏

Fixed as part of this PR. Going to put one up for the Input + Textarea, and a separate one for the Selects since we'll add support for react-select or the Chakra wrapped version.


Enable docs translations (backport #383)

Summary
Backporting PR #383
Details and comments

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-66.02%) to 0.0%

Totals

Change from base Build<PHONE_NUMBER>:
-66.02%

Covered Lines:
0

Relevant Lines:
0

💛  - Coveralls


Investigating JavaScript prime number widget implementation.

This is not a real pr, the purpose is more for talking about the ipyreact pattern.
The Situation:
I have a widget that contains a button.
When the button is clicked, the value count increases.
A message is shown that notifies if the number of total clicks is a prime number or not.
In the first widget, I use a prime_message traitlet to communicate with the user.
When the button is pressed, a new message is calculated and displayed correctly.
The message can also be manipulated by primepy.prime_message = "Hello World"
Now I want to do the same thing, but make the calculations in JavaScript.
That also works, but I don't know how to allow the user to manipulate the message by e.g. primejs.prime_message = "Hello World".
@paddymul : would you be interested in investigating how the
prime_message = isPrimeNumber(count);
return  {prime_message} ;

pattern can be used in a way that prime_message = isPrimeNumber(count); only gets called on number change?

I think you want to use the setter for primeMessage, not set it directly.
So
export const MyUpdater = ({ count, prime_message}) => {
    prime_message = isPrimeNumber(count); //This feels very un-reactlike because you are modifying a property inplace
    return  {prime_message} ;
    };

Should be something like
export const MyUpdater = ({ count, prime_message}) => {
    return  {prime_message} ;
    };

 export default function ({ on_count, count, prime_message, on_prime_message}) {
    on_prime_message(isPrimeNumber(count));
    return (

        <button onClick={() => on_count(count + 1)}>{count} times clicked</button>

        <MyUpdater count={count} prime_message = {prime_message}/>

    );
    }
    """

I don't think the above will work though, because it will result in a loop.
I'm not sure I have a good answer.

Thanks for your suggestion.
I just included your suggestions, it did not result in a loop, however the line on_prime_message(isPrimeNumber(count));
does not allow setting the message by  primejs.prime_message = "Hello World":
import ipyreact
from traitlets import  Any , Int

class PrimeJavaScriptWidget(ipyreact.ReactWidget):
    prime_message = Any("Click the Button").tag(sync=True)    # <- TODO: this message does not show up because prime_message is overwritten
    count = Int(0).tag(sync=True)

    _esm = """
    import * as React from "react";

    function isPrimeNumber(n) {
    for (let i = 2; i < n; i++) {
        if (n % i === 0) {
        return "No 🌐🧊🧊🧊";
        }
    }
    return "Yes 🌐✅✅✅";
    }

    export const MyUpdater = ({ count, prime_message}) => {
        return  {prime_message} ;
        };

    export default function ({ on_count, count, prime_message, on_prime_message}) {
    on_prime_message(isPrimeNumber(count));
    return (

        <button onClick={() => on_count(count + 1)}>{count} times clicked</button>

        <MyUpdater count={count} prime_message = {prime_message}/>

    );
    }

    """
primejs = PrimeJavaScriptWidget()
primejs.prime_message = "Hello World"  # <- TODO
primejs


Initial Schema reported as not empty (view pg_stat_statements exists)

What version of Flyway are you using?
5.0.5
Which client are you using? (Command-line, Java API, Maven plugin, Gradle plugin, SBT plugin, ANT tasks)
Java API
What database are you using (type & version)?
Postgres 9.6
What operating system are you using?
? Linux on AWS
What did you do?
Started a spring boot service with flyway migration scripts on a fresh/ intitial postgresql instance
What did you expect to see?
A successfull flyway migration
What did you see instead?
Migration failed with exception:
https://github.com/flyway/flyway/blob/master/flyway-core/src/main/java/org/flywaydb/core/Flyway.java#L1196
Issue:
https://github.com/flyway/flyway/blob/fb9a6ebe3a560553f7a2211a40460532f6154d13/flyway-core/src/main/java/org/flywaydb/core/internal/database/postgresql/PostgreSQLSchema.java#L51
Running a postgresql DB on cloud foundry we have a postgres instance which has initially the db view "pg_stat_statements" available. The linked statement in doEmpty() returns "true", but i this case it should be false. In flyway 4.2.0 the doEmpty() is different and issue not occuring.

We just found out that spring property "baselineOnMigrate" just fits well to our requirements.
So issue can be closed.


fixed call to bundle file in example

I'd been trying to get HMR working with the package and decided to clone the repo so I can see how the example works. Kept getting 404's when it was calling client.js. Looked into the webpack config and noticed it was creating a file called bundle.js.

Coverage remained the same at 80.808% when pulling 9890dccce96bda9165f1bb0dd35ef849989c1cc9 on silverlight513:example-fix into a257b08126ab0556986f9a43a2ee1b151c487cf0 on glenjamin:master.

Good spot, thanks


Setting language

I have to set language of re-captcha but this is not possible.

Updated the component to support a language parameter, pass [language]="'de'" for example.

Thanks


Anti-Aliasing Not Working

Reframework seems to disable every anti aliasing option. Checked RE2 and 3 and both had this issue.
reframework uninstalled with TAA enabled

reframework installed with TAA enabled (but not working)

I tried 10 different releases from the nightly builds and they all had this issue even from the newest release to the oldest available 1-d29c481. Versions 1.2 and 1.1 on the official releases page both have this issue too. v1.06.3 from Jul 2021 does not.

Delete the re2_sharpness_removal.lua from your reframework/autorun folder.


Add Linux package dependencies for packaging

PR Summary
Add Linux package dependencies for packaging
PR Context

PR Checklist

[x] PR has a meaningful title

Use the present tense and imperative mood when describing your changes

[x] Summarized changes
[x] Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
[x] This PR is ready to merge and is not Work in Progress.

If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.

Breaking changes

[x] None
OR
[ ] Experimental feature(s) needed

[ ] Experimental feature name(s):

User-facing changes

[x] Not Applicable
OR
[ ] Documentation needed

[ ] Issue filed:

Testing - New and feature

[x] N/A or can only be tested interactively
OR
[ ] Make sure you've added a new test if existing tests do not effectively test the code changed

Tooling

[ ] I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
OR
[ ] I have considered the user experience from a tooling perspective and opened an issue in the relevant tool repository. This may include:

[ ] Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode
(which runs in a different PS Host).

[ ] Issue filed:

[ ] Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.

[ ] Issue filed:

[ ] Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).

[ ] Issue filed:

[ ] Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).

[ ] Issue filed:

@TravisEz13   Please look at failed builds ('A parameter cannot be found that matches parameter name 'Logs'.').


fix/MD/XL-9798 model file problems

Task XL-9798

Codecov Report
Attention: Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.

Project coverage is 4.31%. Comparing base (64a14ba) to head (b064944).

Files with missing lines
Patch %
Lines

src/Generator/Commands/ModelGenerator.php
0.00%
12 Missing :warning:

Additional details and impacted files
@@                             Coverage Diff                             @@
##             fix/MD/XL-9797-Repository-model-string     #43      +/-   ##
===========================================================================
- Coverage                                      4.32%   4.31%   -0.01%
  Complexity                                      892     892
===========================================================================
  Files                                            99      99
  Lines                                          3215    3221       +6
===========================================================================
  Hits                                            139     139
- Misses                                         3076    3082       +6

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Remove EB code

Remove unused elastic bean stock code. It is no longer used by this repo.

I'm not immediately, off the top of my head, sure of how to properly remove/replace this
@Bento007 @atarashansky ?

server.eb.app is used by hosted explorer.


mpg123.LibInitializationException: libout123 not found

I installed with:
pip3 install -r requirements.txt
python3 ~/gits/Looper/loop.py Arriba\ Arriba\ (Extended\ Mix)-5ySKv0hUrIE.mp3
and i'm getting this error:
Loading Arriba Arriba (Extended Mix)-5ySKv0hUrIE.mp3...
Playing with loop from 03:08.088 back to 01:39.480 (61% match)
(press Ctrl+C to exit)
Traceback (most recent call last):
File "/home/pkssd/gits/Looper/loop.py", line 174, in
loop_track(sys.argv[1])
File "/home/pkssd/gits/Looper/loop.py", line 165, in loop_track
track.play_looping(start_offset, best_offset)
File "/home/pkssd/gits/Looper/loop.py", line 140, in play_looping
out = Out123()
File "/home/pkssd/.local/lib/python3.5/site-packages/mpg123.py", line 274, in init
self._lib = self.init_library(library_path)
File "/home/pkssd/.local/lib/python3.5/site-packages/mpg123.py", line 263, in init_library
raise self.LibInitializationException('libout123 not found')
mpg123.LibInitializationException: libout123 not found

mac users: if you have homebrew do brew install mpg123 and it will install the libraries you need.
@NolanNicholson i came here from the article and this is a real gem 👍


Spike: have ComponentGraph skip samplers in transform/predict, and refactor sampler code

Problem
Currently the following fails. I would expect it to pass.
undersampler = evalml.pipelines.components.Undersampler()
undersampler.fit(X, y)
X_undersampled_t, y_undersampled_t = undersampler.transform(X, y)
undersampler = evalml.pipelines.components.Undersampler()
X_undersampled_ft, y_undersampled_ft = undersampler.fit_transform(X, y)
assert X_undersampled_t == X_undersampled_ft
assert y_undersampled_t == y_undersampled_ft

This is because our samplers rely on the fact that the ComponentGraph impl just so happens to always call fit_transform at fit-time, and transform at predict-time. So in the above, the output of .fit_transform() will be downsampled but the output of .fit().transform() will not.
I think that level of subtlety in a component impl represents potentially dangerous behavior. If the ComponentGraph impl happens to change, this will break. Plus it makes it hard for users to look at the component code and understand what's happening.
Changes
I think we just need to shuffle the delegation a bit. I think all our transformers should be "dumb" in that they produce the same output regardless of whether you call .fit().transform() or .fit_transform(). Conversely, I think ComponentGraph should be smart enough to only include samplers at fit-time. This PR does that.
This PR also refactors the sampler code a bit. I don't think we need the undersampler to support more than one sampling method right now, for instance.
Finally, this PR also fixes #1982 by re-initializing every sampler during component fit instead of during component __init__, ensuring every invocation uses the same RNG seeding.
Labeled as spike until I can update the unit tests!

Changes addressed by #2583 and #2595, closing!


STYLE: Remove redundant checks in ProcessObject::VerifyPreconditions()

Removed redundant checks of required named inputs, which were performed already in the previous lines of code.
Partially reverts commit bf6f1065a07037fe27d290f72adf81c81ed408ec "BUG: VerifyPreconditions checks required named inputs", April 23, 2013.

Please compare the code that is removed by this PR with the code just above it:
https://github.com/InsightSoftwareConsortium/ITK/blob/bc1025b1c00d8cd99d98646c6a59072edf0488f9/Modules/Core/Common/src/itkProcessObject.cxx#L1332-L1341
Isn't it basically just doing the same check?

@blowekamp please review.

Yes, I agree it looks redundant. The linked change did not add a test. Could we test a couple cases of names inputs being null?

Ping! Test, yes or no? If not, should we merge as is?

A test would be nice, but I haven't had time to write it so far. And honestly, I think the test should have been written before, when the original code (which is removed by this PR) was added! If necessary, of course. I'm fine by having this little clean-up merged now.


read class-level @Produces/@Consumes

The spec says these annotations can be on the class or method levels:
https://jersey.java.net/documentation/latest/jaxrs-resources.html#d0e2065
https://jersey.java.net/documentation/latest/jaxrs-resources.html#d0e2144

NetflixOSS » feign » feign-pull-requests #147 SUCCESS
This pull request looks good

you sneakily opened a github account and published a pull request I've no changes to recommend on. great work and thanks!

Adrian, do you know when you'll publish 8.10 with support for method-level annotations?
Cheers! And thanks @pnepywoda .

There's another PR in progress once that's in, sure. Latest Monday

in 8.10.0!

Sweet, thanks Adrian!
R.
On Mon, Sep 14, 2015 at 3:34 AM Adrian Cole<EMAIL_ADDRESS>wrote:

in 8.10.0!
—
Reply to this email directly or view it on GitHub
https://github.com/Netflix/feign/pull/270#issuecomment-140031405.


pytest issues with get_native_int

After installing openfhe-python, I am trying to run pytest in the project root directory. I get the following errors. It must be something simple. Can you help fix? I am using Mac OSX Sonoma (Apple M2).
============================================================= ERRORS =============================================================
_______________________________________________ ERROR collecting tests/test_bgv.py _______________________________________________
tests/test_bgv.py:7: in <module>
    pytestmark = pytest.mark.skipif(fhe.get_native_int() == 32, reason="Doesn't work for NATIVE_INT=32")
E   AttributeError: module 'openfhe' has no attribute 'get_native_int'
______________________________________________ ERROR collecting tests/test_ckks.py _______________________________________________
tests/test_ckks.py:6: in <module>
    pytestmark = pytest.mark.skipif(fhe.get_native_int() == 32, reason="Doesn't work for NATIVE_INT=32")
E   AttributeError: module 'openfhe' has no attribute 'get_native_int'
__________________________________________ ERROR collecting tests/test_cryptocontext.py __________________________________________
tests/test_cryptocontext.py:4: in <module>
    pytestmark = pytest.mark.skipif(fhe.get_native_int() != 128, reason="Only for NATIVE_INT=128")
E   AttributeError: module 'openfhe' has no attribute 'get_native_int'
____________________________________________ ERROR collecting tests/test_examples.py _____________________________________________
tests/test_examples.py:10: in <module>
    pytestmark = pytest.mark.skipif(fhe.get_native_int() == 32, reason="Doesn't work for NATIVE_INT=32")
E   AttributeError: module 'openfhe' has no attribute 'get_native_int'
____________________________________________ ERROR collecting tests/test_serial_cc.py ____________________________________________
tests/test_serial_cc.py:6: in <module>
    pytestmark = pytest.mark.skipif(fhe.get_native_int() == 32, reason="Doesn't work for NATIVE_INT=32")
E   AttributeError: module 'openfhe' has no attribute 'get_native_int'
==================================================== short test summary info =====================================================
ERROR tests/test_bgv.py - AttributeError: module 'openfhe' has no attribute 'get_native_int'
ERROR tests/test_ckks.py - AttributeError: module 'openfhe' has no attribute 'get_native_int'
ERROR tests/test_cryptocontext.py - AttributeError: module 'openfhe' has no attribute 'get_native_int'
ERROR tests/test_examples.py - AttributeError: module 'openfhe' has no attribute 'get_native_int'
ERROR tests/test_serial_cc.py - AttributeError: module 'openfhe' has no attribute 'get_native_int'
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! Interrupted: 5 errors during collection !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!

I want to provide a bit more info to see if this is an installation issue. openfhe is installed in my home directory. After build and install of openfhe-python, I have set PYTHONPATH and LD_LIBRARY_PATH to include openfhe dynamically shared libraries. So far it seemed reasonable without any issues.
Later, when I run pytest, I got the error:
Traceback:
/opt/homebrew/Cellar/python@3.11/3.11.7_1/Frameworks/Python.framework/Versions/3.11/lib/python3.11/importlib/__init__.py:126: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
tests/test_serial_cc.py:4: in <module>
    import openfhe as fhe
openfhe/__init__.py:1: in <module>
    from openfhe.openfhe import *
E   ModuleNotFoundError: No module named 'openfhe.openfhe'

What should my PYTHONPATH include at this point? Note that if it includes only $HOME//Users/anitha_gollamudi/openfhe-development/install/lib I get No module named openfhe.openfhe error.

setting export PYTHONPATH=openfhe-python/build:$PYTHONPATH solved the issue. This is not mentioned in the documentation; only OpenFHE libraries were mentioned, and I assumed that they referred to libraries from openfhe-development.


Don't use strings for injection - use injection tokens

Using Strings like 'parent' for injection may cause conflicts with other components.

I've just changed all the string injection keys to InjectionKey interface provided by vue. Thanks!


Fix encoding of unpaired surrogates and enable WPT tests in CI

Fixes failing WPT textencoder-utf16-surrogates tests and adds any tests we've enabled to run in CI. We replace unmatched surrogates in JS with a UTF-16 replacement char before converting to UTF-8. This does introduce a 0.0862% to 3.5610% increase in execution time as measured by our benchmarks for cases where there are no unpaired surrogates.
The code is not the cleanest JS I could have written. I tried with a cleaner looking version and I saw 10% increases in total execution time. After some experimenting and trying to optimize for cases without surrogates, I got it down to what's here. There might be some other ways to get the time spent in this function down even further.
Some other approaches I considered:

Addressing this in Rust code but we do not have access to the underlying WTF-16 byte array in the JSValue we receive as an argument. QuickJS does not expose any APIs to retrieve these bytes either. So we cannot preprocess the input in Rust without adding extensions to our QuickJS implementation.
Briefly looked at if we could post-process the output we receive back from QuickJS from invoking JS_ToCStringLen2 and after experimenting a bit, right now I'm not confident that there's a contiguous range of output byte triples where it would be safe to replace them with a UTF-8 replacement char without unintentionally replacing valid byte triples. It may be worth that exploring that further though.
Adding an extension to our QuickJS code to handle the string conversion better but, I am rejecting that approach for now given the approach here is more maintainable and the impact on execution speed seems manageable to me. We could do this in the future if it makes sense to.

For cases where there are unpaired surrogates, our current encoder implementation will currently throw an exception, so the slower execution speed that would result from this change is likely better in most cases with unpaired surrogates.

I'm going to close this since I think I can use a different approach after reviewing the WTF-8 spec and my own notes on various outputs I was getting back from JS_ToCStringLen2.


Eden Fetch  Add case for text/event-stream and forward response to return statement

Would love to give this one a shot, and write a pull request for it
Currently we can't stream with Eden Fetch

[ ]  EdenFetch doesn't pass response, even though it's stated in the type definition
[ ]  Default would transform the stream data into text , not allowing access to the Stream

Proposal add a text/event-stream case
 switch (res.headers.get('Content-Type')?.split(';')[0]) {
                    case 'application/json':
                        data = await res.json()
                        break
                    case 'text/event-stream': {
                        data = res
                        break
                    }
                    default:
                        data = await res.text().then((d) => {
                            if (!Number.isNaN(+d)) return +d
                            if (d === 'true') return true
                            if (d === 'false') return false

                            return d
                        })
                        break
                }

Add response to the return  of EdenFetch
 return {
                    data,
                    error: null,
                    status: res.status,
                    response: res,
                    headers: res.headers,
                    retry: execute
                }

Really, it should be possible for the developer to get the response before it's resolved if they wanted it. This block of code is convenient for most use cases, but there's always going to be some fringe edge case, like for me where I want to handle an application/octet-stream and turn it into a blob instead of having to modify eden treaty or eden fetch.

Right, this is a big footgun. If you use eden fetch or eden treaty in conjunction with @elysiajs/stream, you cannot read the stream, it will lock the body and consume the entire stream, defeating the point. There appears to be no way around it except using regular fetch and bypassing eden altogether


Upgrade to Angular 9

Upgrade demo and library to Angular 9.

Why is this not being merged?
I cannot use this component with Angular9, waiting for this PR.


Dev #740 - Admin pages: change text on 'Import categories and concepts backup file' page

Admin pages: change text on 'Import categories and concepts backup file' page
When an admin user decides to import a categories and concepts backup file, they should be informed that this will overwrite the existing categories and concepts structure.
Development
On the 'Import categories and concepts backup file' page, under the page header the text currently states, 'Categories and concepts backup file to import'; this should be changed to, 'Select a categories and concepts backup file to import. Importing this file will overwrite the existing categories and concepts structure.'.
Screenshot

Thanks @cacquani happy for this to be deployed to staging.


Update getting-ready-to-install-sdn-interface.md

Docs Build status updates of commit b200a87:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

Skype/SDN/articles/getting-ready-to-install-sdn-interface.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


HTTP 404 while adding custom embedding model

When I am adding custom embedding model, it is giving me 404 error. Even though I have selected the OpenAI Compatible API in the first option, it is still sending ollama in the request.

Hey, thank you for pointing out that there was an issue on the frontend. We will release a fix later today

@n4ze3m I see the code is fixed but you re-opened the issue. Should I test now or wait?

Yes it is working.


Create a native Android SDK

As a developer, I want to implement TIKI SDK in my native Android code without installing Flutter SDK.
The module should be compiled as a maven dependency. It enables the Flutter Framework independently and developers can use the Flutter code without installing Flutter SDK.
https://docs.flutter.dev/development/add-to-app/android/project-setup#option-a---depend-on-the-android-archive-aar
Acceptance criteria
1 - The Flutter example app written in Kotlin and running natively in Android.

Kotlin build is failing. Created a new issue for that. #6


Add parallel action execution for ToolkitTask

This PR introduces a new way for LLMs to execute actions. LLMs accessed via ToolkitTask can now execute multiple actions in parallel. Griptape will execute all provided actions with a futures_executor. The following is a list of major changes:

Changes to the ToolkitTask system prompt explianing how to run actions in parallel.
ActionSubtask was renamed to ActionsSubtask.
Split action execution logic into execute_actions and execute_action in ActionsSubtask.
Added BaseActionSubtaskEvent.subtask_actions.
Removed subtask_action_name, subtask_action_path, and subtask_action_input in BaseActionSubtaskEvent.
Improved system prompt inToolTask to support more use cases.

This change was tested on gpt-4 and Claude2 with temperatures ranging from 0.1 to 0.9.

Let’s make sure we update Grippy’s logic before we merge this to main - since it’ll change how it handles subtasks

Oh, just noticed failing type-check. Can you please resolve that?


Workshop presentation slides

Hi, do you think it's possible to add workshop presentation slides to this repo?

I believe the slides or a link to the slides was sent out in a follow-up email for the workshop from Segment. If you didn't get the email, let me know if it's okay to email the deck to your email address on your github profile and will send directly.

I searched through the emails once again and only found a follow-up email with feedback link. If you could send it to the address in my github profile that would be great, thanks! V.


PHP 8 compatibility

I believe this package does not support PHP 8
spatie/pdf-to-image v2.x-dev requires php ^7.0 -> your php version (8.0.11) does not satisfy that requirement.

The latest version does.

Hi there
I am facing the same issue. Has anyone found the solution?


Exclude images from getting their background set to black

Many images with a transparent background are created with a white background in mind, which are not readable with this extension. For example from https://en.wikipedia.org/wiki/Low-pass_filter:

I added the img tag to the list of elements which automatically get their background-color set to black, which fixes this problem for many images.

@mercutiodesign I added the quotation marks, thank you.

Nice, will check and test the PR the coming days and approve 🚀

Due to merge conflicts, I just copied over your solution and will include in next version: 4.5.4, thanks for reporting!


Light/Dark palette switching with mkdocs's palette toggle

Hello,
Currently, d2 only switches the theme in accordance with system/browser preference.
Is there a way to sync the theme with mkdocs's current palette instead?
Minimal reproduction for test:
9.5.25+insiders.4.53.11-d2-does-not-respect-mkdocs-palette-toggle.zip
P.S. Basic function works great! Thank you for your work on this plugin.

There is no way to sync the theme between D2 diagrams and MkDocs right now. It should be possible but I doubt it's as easy as it looks like since I embed SVG directly, otherwise links would not work. I'll give it a try when I have some free time.
Sorry for the late reply, I was on vacation.

I finally got to it and released a beta version with support for light/dark mode switching. You can try it out by installing 1.5.0b2 or visiting the plugin documentation.
I have to fix a bug causing diagrams to not be rendered when dark_theme is disabled globally but enabled locally, which is why there is only a beta release for now.

1.5.0 is released.


Smart API detection when loaded from non-standard API port in go-ipfs

This is something came to me when I was looking at https://github.com/ipfs/js-ipfs/pull/1595  and https://github.com/ipfs-shipyard/ipfs-webui/issues/785.
If go-ipfs runs API on a different port than :5001, then webui will not be able to connect to it, even tho it was loaded from the API port :upside_down_face:
Instead, it will display error page  where user needs to manually provide the port.
Its not bad, and may be enough for now, however I feel we could make it work automatically:

(A) by appending parameter with custom API port to the webui URL printed to the console  (see https://github.com/ipfs/js-ipfs/pull/1595 and  discussion in https://github.com/ipfs-shipyard/ipfs-webui/issues/785)
(B) by adding a simple fallback to webui: if default port fails, check the same hostname but under the port  from window.location.port ("" means 80/443)

I think (B) makes more sense, it would fix the issue for both go-ipfs and js-ipfs without adding any cruft to URL.
@olizilla  thoughts?

@lidel oh my yes! B is a very good idea.

First pass of this is in https://github.com/ipfs-shipyard/ipfs-redux-bundle/pull/15


lvgl: hello world sample crashes

Describe the bug
Running the zephyr lvgl sample on any commit after c7292efbda9902579966657ae5bc514bcda7033b (target: native_posix) leads to a  segfault.
Please also mention any information which could help others to understand
the problem you're facing:

The issue is that the drivers are now initialized before the default display lvgl.c#L252. LVGL requires the presence of the display before any drivers which are group and therefore display related are instantiated.

To Reproduce
Steps to reproduce the behavior:

west build -b native_posix -d build vendor/zephyr/samples/subsys/display/lvgl
west build -t run -d build

Expected behavior
The sample should not crash.
Impact
Encoder devices are not usable anymore.

@gmarull what would be the prefered way of resolving this? Undoing the change or moving the other lvgl setup code to POST_KERNEL?

@gmarull FYI


Advanced permissions phase 1

This is the PR to merge the "Advanced Permissions Phase 1" feature branch into master.
All the individual commits to this branch have already received a full PR review, and the branch as a whole has undergone a detailed QA pass on a spinmint, so only minimal review should be required at this stage.

I going to add issues for each proposed change, but If you find any "stopper" to merge it, we can stop the merge, if not, we can merge, and fix the problems later.


LDAPS (ldap over ssl) working with ssl certificates

hi all,
i have generated self-signed certificate and i have used  following code snippet to access certificates on same machine while using ldaps:///
var tlsOptions = {
// This is necessary only if the server uses the self-signed certificate
ca: [ fs.readFileSync('/etc/ldap/cacert.pem') ]
};
var ldap = require('ldapjs');
var client = ldap.createClient({url: 'ldaps://plat.com:636',tlsOptions: tlsOptions});
this works fine if the ldap server and certificate are on same machine, but it fails if the ldap server is on remote machine.
any help/guidance regarding such issue?

Because ldapjs uses the tls.TLSSocket/tls.TLSServer API for TLS sockets, I would suggest looking to that documentation in order to interpret any errors you may be observing.

Thanks prmooney.
can you please give some examples how to start TLS in ldap. Because i spent much time starting TLS but i was not successful. But LDAP with SSL was successfully working for me. That's why i chose ssl.
A

And also it was working fine with the above code snippet  on same machines.

I'm stuck at this problem for days. Please guide me

I would suggest starting with the node.js documentation on TLS.

yes i have followed the documentation
https://nodejs.org/api/tls.html
Also tried following code snippet and other combinations as well
var tls = require('tls');
var fs = require('fs');
var options = {
key: fs.readFileSync('server-key.pem'),
cert: fs.readFileSync('server-cert.pem'),
// This is necessary only if using the client certificate authentication.
requestCert: true,
// This is necessary only if the client uses the self-signed certificate.
ca: [ fs.readFileSync('client-cert.pem') ]
};
var server = tls.createServer(options, function(socket) {
console.log('server connected',
socket.authorized ? 'authorized' : 'unauthorized');
socket.write("welcome!\n");
socket.setEncoding('utf8');
socket.pipe(socket);
});
server.listen(8000, function() {
console.log('server bound');
});
But get the exception i.e.,
events.js:72
throw er; // Unhandled 'error' event
^
Error: UNABLE_TO_VERIFY_LEAF_SIGNATURE
at SecurePair. (tls.js:1370:32)
at SecurePair.EventEmitter.emit (events.js:92:17)
at SecurePair.maybeInitFinished (tls.js:982:10)
at CleartextStream.read [as _read] (tls.js:469:13)
at CleartextStream.Readable.read (_stream_readable.js:320:10)
at EncryptedStream.write [as _write] (tls.js:366:25)
at doWrite (_stream_writable.js:223:10)
at writeOrBuffer (_stream_writable.js:213:5)
at EncryptedStream.Writable.write (_stream_writable.js:180:11)
at write (_stream_readable.js:583:24)

I'm continuously getting below error:
events.js:72
throw er; // Unhandled 'error' event
^
Error: socket hang up
at SecurePair.error (tls.js:1013:23)
at EncryptedStream.CryptoStream._done (tls.js:705:22)
at CleartextStream.read [as _read] (tls.js:496:24)
at CleartextStream.Readable.read (_stream_readable.js:320:10)
at EncryptedStream.onCryptoStreamFinish (tls.js:301:47)
at EncryptedStream.g (events.js:180:16)
at EncryptedStream.EventEmitter.emit (events.js:117:20)
at finishMaybe (_stream_writable.js:356:12)
at endWritable (_stream_writable.js:363:3)
at EncryptedStream.Writable.end (_stream_writable.js:341:5)
Following is my server-side code:
var tlsOptions= {
key: fs.readFileSync('/home/aneela/client-ldapjs/serverkey.pem'),
cert: fs.readFileSync('/home/aneela/client-ldapjs/servercrt.pem'),
requestCert: true,
// This is necessary only if the server uses the self-signed certificate
rejectUnauthorized: true,
ca: [ fs.readFileSync('/etc/ldap/servercrt.pem') ]
};
var server = tls.createServer(tlsOptions, function(socket) {
console.log('client connected', socket.authorized ? 'authorized' : 'unauthorized');
process.stdin.resume();
process.stdin.pipe(server);
});
server.listen(8001, function() {
console.log('server bound');
});
Following is my client-side code:
var tlsOptions = {
// These are necessary only if using the client certificate authentication
key: fs.readFileSync('/etc/ldap/serverkey.pem'),
cert: fs.readFileSync('/etc/ldap/servercrt.pem'),
ca: CAcerts,  //where CAcerts is the certificate chain
requestCert: true,
rejectUnauthorized: true
};
var server = tls.connect(8001,tlsOptions, function() {
    console.log('client connected', server.authorized ? 'authorized' : 'unauthorized');
    if(!server.authorized) {
console.log("authorizationError: " + server.authorizationError);

}
process.stdin.resume();
process.stdin.pipe(server);
});
server.setEncoding('utf8');
server.on('data',function(data){
console.log(data);
});
server.on('end', function() {
console.log('client closing...');
server.close();
});

Hi pfmooney!
I have spent a lot of time discovering the solution. The following code works fine in my case. Just wanted a little bit guidance. Please have a look on following code and tell me is it the correct approach?
//Server.js file
var fs = require('fs');
var tls = require('tls');
var tlsOptions = {
key: fs.readFileSync('/etc/ldap/serverkey.pem'),
cert: fs.readFileSync('/etc/ldap/servercrt.pem'),
requestCert: true,
rejectUnauthorized: true,
ca: [ fs.readFileSync('/etc/ssl/certs/cacert.pem') ]
};
var server = tls.createServer(tlsOptions, function(socket) {
console.log(socket.getPeerCertificate());
console.log('client connected', socket.authorized ? 'authorized' : 'unauthorized');
socket.write("welcome Client!\n");
socket.setEncoding('utf8');
socket.pipe(socket);
});
server.on('data',function(data){
console.log(data);
});
server.on('uncaughtException', function(error) {
console.log('error   ',error);
});
server.listen(8002, function() {
console.log('server bound');
});
//Client.js file
var fs = require('fs');
var tls = require('tls');
var ldap = require('ldapjs');
var tlsOptions = {
host: 'plat.com',
key: fs.readFileSync('/etc/mycerts/clientkey.pem'),
cert: fs.readFileSync('/etc/mycerts/clientcrt.pem'),
ca: fs.readFileSync('/etc/ssl/certs/cacert.pem')
};
var server = tls.connect(8002,tlsOptions,function() {
console.log('tls connect');
console.log('client connected', server.authorized ? 'authorized' : 'unauthorized');
process.stdin.resume();
process.stdin.pipe(server);
    if ( server.authorized )
    {
            var client = ldap.createClient({url: 'ldaps://plat.com:636',tlsOptions:tlsOptions});
            client.bind(dn, password, function (err) {
            cb(err === null, err);
            });

//Perform LDAP search operation
var opts = {
filter: '(&(objectclass=organizationalRole))',
scope: 'sub',
attributes: ['cn'] };
            client.search('dc=plat,dc=com', opts, function(err, res) {
            res.on('searchEntry', function(entry) {
                          console.log('entry: ' + JSON.stringify(entry.object));
            });
            res.on('searchReference', function(referral) {
                          console.log('referral: ' + referral.uris.join());
            });
            res.on('error', function(err) {
                         console.error('error: ' + err.message);
            });
            res.on('end', function(result) {
                        console.log('status: ' + result.status);
            });
       });
  }

});
server.setEncoding('utf8');
server.on('data',function(data){
console.log('data section: ',data);
});
server.on('secureConnect',function(data){
console.log('secure connect section: ',data);
});
server.on('error', function(error) {
console.log('client closing...',error);
});

Hi @aneelaSaleem Were you able to get a final solution for this? I am also facing a similar issue.

Please use backticks for syntax highlighting, it's much easier to read

 your code goes here

I'm sorry to bump this, but I am still unable to use the createClient to connect to an OpenLDAP server using a certificate key:crt pair. I've been looking for days and trying so many ways of doing this, and I still am unable to get anything to work. Can someone please give a concrete example of how this works using this API? The documentation doesn't even cover the basics. I've also looked at the source code and I can't really make out how it is handled either. I'm out of options here...

Same problem here..

@SineOfLight  In my view this is a workaround but not a solution. Why use a secure LDAPS server when you accept unauthorized requests?

If you've come here looking for an implementation of SASL ldapts has an implementation on v3.2.0

👋
On February 22, 2023, we released version 3 of this library. As a result, we are closing this issue/pull request.
Please see issue #839 for more information, including how to proceed if you feel this closure is in error.


Environment variable not set for fastlane match

I have observed that match is not setting the environment variable.
+----------------------+----------------------------------------+
|                Installed Provisioning Profile                 |
+----------------------+----------------------------------------+
| App Identifier       | myapp.test.prod            |
| Type                 | adhoc                                  |
| UUID                 | b99338ae-cc51-41ad-84ac-49f392ad05e3   |
Now on command line if I enter:
echo $(sigh_myapp.test.prod_adhoc) I don't get the UUID.

It's only being set in the context of the fastlane process. There is no way for a process to pass an environment variable to its parent process, so make sure to run both match and gym from within fastlane 👍

Thanks a lot Felix for your quick reply. I have couple of queries.

Can I define the name of the provision profile created in match? sigh allows us to specific the name. But don't see this option in match.

Am using Jenkins to automate the build and I wanted to use fastlane/match for only creating the provisioning profiles. Am maintaining few environment variables inside jenkins like lastbuildnumber, etc. and hence am using Jenkins xcode plugin rather than gym.

Am selecting the profile at run time in Jenkins using PlistBuddy and passing to Xcode:
PP_PATH="${WORKSPACE}/Profiles/myapp_${COUNTRYCODE}${XCODE_PROFILE_ENV}${1}.mobileprovision"
PP_UUID=$(/usr/libexec/PlistBuddy -c 'Print UUID' /dev/stdin <<< $(security cms -k "${KEYCHAIN_PATH}" -D -i "${PP_PATH}"))
where ${1}.mobileprovision is my profile and its has a fix value eg: us_mypp_profile.
When the profile is updated, the profile file is overwritten manually by me and everything works fine on Jenkins.
With match am having difficulty fetching the UUID as the profile names are auto generated plus cant access the environment variables.

Thanks KrauseFx ,
I have successfully set up fastlane with jenkins. Thanks for all the support.
Thanks and Regards,
Santosh

@KrauseFx But is there a way to read env var from match and pass it outside? I need it to set up Unreal Engine project on Jenkins.

@santoshshetty2612 how did you manage to pass env vars from Match to Jenkins shell?

Hi @ruslanfutureuniverse  I passed the environment variables from Jenkins to fastlane.
I copied the Jenkins environment variables into .env file and copied it into fastlane folder.
When fastlane runs, it will read the value from this .env file.

@santoshshetty2612 ah yeah, understand. But are there any way to pass match  job results to env var? If new profile was generated here, I need to pass it to Jenkins script.

@ruslanfutureuniverse
Consider your project Folder -> fastlane
Inside which you have fastfile.
Now you can run the fastlane you can write the variables in a file (example fastline.properties)
In Jenkins, you can read this file and load it using the inject environment variable step passing the path to fastline.properties.

@santoshshetty2612 wow. I see...
Could you please write a snippet, how to write match values to file and read from it?


Improve chrome Travis tests stability

For some reason some Chromedriver tests sometimes crash with:

Facebook\WebDriver\Exception\UnknownErrorException: unknown error: Chrome failed to start: exited abnormally
(unknown error: DevToolsActivePort file doesn't exist)
(The process started from chrome location /usr/bin/google-chrome is no longer running, so ChromeDriver is assuming that Chrome has crashed.)

As per this StackOverflow question adding the --disable-dev-shm-usage flag might help. :man_shrugging:

Unfortunately, this obviously did not help :disappointed:
Facebook\WebDriver\Exception\UnknownErrorException: unknown error: Chrome failed to start: exited abnormally
  (chrome not reachable)
  (The process started from chrome location /usr/bin/google-chrome is no longer running, so ChromeDriver is assuming that Chrome has crashed.)


Provide a way to validate addresses via the API.

Context

Exchanges prefer validating data before submission (even though the API will validate things upon submission). There's no easy to simply validate arbitrary string an know whether they are valid addresses or not. That feature exists in cardano-address but only available via command-line.
Decision

Make the API able to inspect addresses.
Acceptance Criteria

There's a new API endpoint to validate addresses
The validation is implemented using cardano-address 'inspect' method.

Development

Added endpoint to the API ==> #2184
Tweaked a bit the swagger documentation to put the endpoint in a separate category ==> #2185

QA

The inspect feature comes from cardano-addresses and is well-tested there.

Added two straightforward integration tests showing that the API reacts correctly to inputs:
https://github.com/input-output-hk/cardano-wallet/blob/d4d5cf3f1dbf478e49186f9e1742939af528bcaa/lib/core-integration/src/Test/Integration/Scenario/API/Shelley/Addresses.hs#L229-L237

Make sure that the generated JSON matches the OpenAPI schema:
https://github.com/input-output-hk/cardano-wallet/blob/d4d5cf3f1dbf478e49186f9e1742939af528bcaa/lib/core/test/unit/Cardano/Wallet/Api/TypesSpec.hs#L1524-L1525
Although, this is a bit of a lie because we don't yet have a proper type to represent the result of an address inspection. What we get from cardano-addresses is an opaque JSON value which (from a type perspective) could be anything. So we should ultimately replace this with a proper Haskell data-type so that we can have static type-checking on this:
https://github.com/input-output-hk/cardano-wallet/blob/d4d5cf3f1dbf478e49186f9e1742939af528bcaa/lib/core/test/unit/Cardano/Wallet/Api/TypesSpec.hs#L1460-L1467

Ported the test cases from cardano-addresses and tested them at the unit-level. Ideally, once we have cardano-addresses to return a proper Haskell data-type, we can make the test a bit more expressive instead of simply isRight and isLeft
https://github.com/input-output-hk/cardano-wallet/blob/d4d5cf3f1dbf478e49186f9e1742939af528bcaa/lib/shelley/test/unit/Cardano/Wallet/Shelley/CompatibilitySpec.hs#L232-L292

Lgtm. However I wonder if there is a point of showing network_tag: null in case of Mainnet/Staging Byron random and Byron icarus addresses. Perhaps better not to show anything?
curl http://localhost:8092/v2/addresses/DdzFFzCqrhtBfCivoJApi19mydJT1ipghz72mqPPzmZZ1ULYxronKfB4HCYfXGoxEsvgsBKuTeF7ZAi2VytAA78sBT1EpXLk4CgoJQTK
{
  "stake_reference": "none",
  "address_style": "Byron",
  "address_root": "f3ab6fc64a78c8b4873002c578dee136c062d340358b973a4be6dfbb",
  "derivation_path": "581cc17572ba517c7d2b68b598478ac15aedbb49a0bdfc960d33fb56d0fe",
  "network_tag": null <--------------------
}

curl http://localhost:8092/v2/addresses/Ae2tdPwUPEZCXHQ1b2RjVryp63eVAehJN4HPPYGH1fuddixeQRkzERCbEB6

{
  "stake_reference": "none",
  "address_style": "Icarus",
  "address_root": "9d8157c18118e753486e3fc39754b2772aa187e5241a5e1a6d2f5b0f",
  "network_tag": null <--------------------
}

It'd rather be explicit about that one and show it. It's not that the information is not available (in which case not showing the key would make more sense), it's that, we know that there's no network tag. So that's a bit different and a null value is better suited for this IMO.


Add profile modal popup

Description
This pull request introduces a Profile Modal Popup feature that enhances user engagement by encouraging users to add their GitHub profiles.

Profile Modal Popup: A user-friendly modal has been implemented to prompt users to add their profiles, making it easy and accessible for them to contribute.
Single Appearance: To improve user experience and avoid annoyance, the modal is designed to appear only once per user upon their visit.

A video demonstration of this feature is attached for reference.
https://github.com/user-attachments/assets/084d45a0-dd1a-4da4-92bc-95f40a7227b9

Maybe It's my mistake that I have created this PR to merge with main branch which does not contain code. Instead I should have merge these change to gh-pages.
So, please tell me if should create a new PR for merging changes into gh-pages branch Or what should I do ?

new PR


Ignore empty child_frame_id in odometry message

In case child_frame_id in the odometry message is empty, assume
identity transform for sensor_to_tracking.
Otherwise, when TfBridge::LookupToTracking is passed an empty string, errors occur.
Use case: mit stata center data set

The documentation does not really allow for child_frame_id to be empty. And why should this be identity if unset?
How about fixing their data instead of adding a workaround into Cartographer?

I submitted it because I thought that it would be a reasonable assumption that the odometry is expressed with regards to the tracking frame if this information is missing, rather than to error out. I was aware that the chances were low that you would let this slip in, I just wanted to bring it to your attention :)

How about fixing their data (and contribute the fixed data back to them) instead of adding a workaround into Cartographer?

I would love to do this, but these bags are huge. From 50 to 70 gigabytes.
I think I know how this error slipped by. Most of the ROS nodes that I have seen which do localization take the odometry information directly from the TF tree (it would be nice if Cartographer could do this too). As a consequence of its limited use, the separate odometry topic often goes missing in various datasets, or in this case, has a defect.
Feel free to close the PR; I will be keeping this commit in my fork until I am done with these bags.

I was aware that the chances were low that you would let this slip in, I just wanted to bring it to your attention :)

We are actually aware that this data is broken. I saw this in https://github.com/googlecartographer/cartographer_ros/issues/332#issuecomment-302080051.

I think I know how this error slipped by. Most of the ROS nodes that I have seen which do localization (e.g. AMCL, GMapping) take the odometry information directly from the TF tree (it would be nice if Cartographer could do this too).

I am not very experienced about odometry and ROS, but my understanding is that this is the old way of doing odometry and that it is deprecated and should not be done anymore. Is that not the case?

 But here's some more rambling: another significant difference is that the Odometry message has twist information, which is not directly available from TF (there exists lookupTwist, but it's just numeric differentiation within an averaging interval). Cartographer is not using the twist information (but it could, and probably will). Until then, maybe it would make sense to also support reading odometry from TF, just for interoperability's sake.

So, we're not merging this? Again, free to close it if not.

Sounds to me like a node should rewrite tf into odometry data instead. This seems the wrong approach to me. Sorry :(


test: add tests for repository functions

A first attempt at setting up testing for persistence functions.

I hope you enjoyed my feedbacks

I hope you enjoyed my feedbacks

Definitely, thanks for the reviews :)
I left a sorta high level question regarding types here; any help would be appreciated :)


Antwerp would like CO2 reference year to be 2005 instead of 1990

Apparently 1990 is not the universal reference year for CO2 emissions that we thought it was. In some countries 2005 is more commonly used. Belgium is one of those.
A 'simple' way to fix that would be to have the CO2 chart label the left-most column with whatever reference year the dataset provides.

Is it possible to have the label for 1990 be country-specific? Is this desirable, do we need to change many labels, etc?
This is not a major request, but if this is easy to fix, then why not do so?
Curious wat you think @ChaelKruip @marliekeverweij @antw

@redekok and I encountered this in Gent as well

Currently the 1990 CO2 emissions are added to the left-most column by ticking the is 1990 in the admin-section (see screenshot below).

Maybe we could:

add a tick box for is 2005?
or
make the tick box more general: f.e. is reference year. And then add an area-attribute (f.e. - reference_year = ) with which you can set the reference year for the dataset (for Dutch datasets we can set it on 1990 by default).

I actually think it's not very easy to fix, but @antw can better decide that I think!
Btw: the label of the output element series (f.e. '1990 CO2 emissions of international transport') does not have to include the reference year per se I think. We can also delete 1990 from the text above the chart. Then we do not have to make those country-specific.
Only underneath the vertical stacked bar it is needed that the right reference year is stated!

Btw: the label of the output element series (f.e. '1990 CO2 emissions of international transport') does not have to include the reference year per se I think. We can also delete 1990 from the text above the chart. Then we do not have to make those country-specific.
Only underneath the vertical stacked bar it is needed that the right reference year is stated!

Indeed, in most text you can refer to the 'reference year'. I do know there are 3 area .ad files that refer to co2_emission_1990..., like: co2_emission_1990.ad
- query = UPDATE(AREA(), co2_emission_1990, USER_INPUT())
- priority = 2
- update_period = both

I think @marliekeverweij is correct to suggest making it more generic to call it a "reference year" (or similar) and define the year in the area/dataset file.
Currently "1990" is hard-coded in quite a number of places, particularly some of the ETMs charts, but also the reports, ETEngine, Atlas, and ETSource. I expect replacing it properly will be a small project of it's own.

Sorry for responding a month later to this issue.... Let's keep is as it is for now then, since we do not have budget to replace '1990' with a more general year. We have communicated to Antwerp that we will use 2005 emissions for the Antwerp dataset instead of 1990 emissions and that the 1990 label will stay the same. It will probably give some confusion, but so be it.
Notifying @MartLubben: as this may be relevant during your workshop in Antwerp this week.


Move indicator calculators into their own packages

Hi there,
I've been looking into automated trading, and specifically the renko indicator. I've noticed that your package is pretty darn awesome, and includes renko.
Currently, the indicator calculators are bundled with react-stockcharts and intended to be used with it.  Looking at their source code, their doesn't seem to be anything specific in them that requires the client-side. As such, it would be cool for them to published as independent and documented universal npm packages, such that they can run on the client-side in web browsers and server-side in nodejs.
That will then allow stockcharts, as well as node apps, to use your calculator code easily, increasing opportunity for use and improvement.
What do you think?

If you are down, I've created https://github.com/stockcharts and invited you as an owner.
I could work on abstracting the calculators out, and submit PRs to the react-stockcharts repo for each abstraction.

you are right, there is nothing react specific. if you notice the usage also it is like
import { sar } from "react-stockcharts/lib/indicator";

I was planing to use lerna and create a monorepo with mutiple packages. However as you might have seen there are 0 tests in the project so far, I am not comfortable publishing these packages without sufficient test. I am down with the new org, and I am happy to contribute and would appreciate support to creating tests also.
oh and I almost forgot, the indicators in react-stockcharts are inspired by d3fc

Cool.
I've also noticed https://github.com/anandanand84/technicalindicators - maybe this task could be simplified by using their indicators instead?

I am not familiar with that lib, I will have to check it out. When starting down the custom indicator route, I did look at using an existing library, it has its benefits, but also might lack customization.
for instance, I wanted to be able to customize the type of moving average on a bollingerband, the default is sma, and the libraries I was looking at did not allow such, few of them required data to be formatted as an array of prices, while I already have data as an array of ohlcv.and I did not want to do an additional map operation. Finally I really liked the style in d3fc, using functional constructs, minimizing object mutation so I took the plunge.
Still, renko, p&f, kagi are not written d3fc style, I will have to get to it.


click event on series

i wanna handle onClick event on chart value, but i could not find any thing in rishaw.

I'm using something like: http://stackoverflow.com/a/29609206/1165132


Pin cmake dependency used to build wheels

The latest release of cmake 3.29.0 is broken with Python 3.8. Since this is not the first time that a cmake release is broken, we should pin the dependency and manually update when needed.
Contributor (creator of pull-request) checklist

[ ] Tests updated (for new features and bugfixes)?
[ ] Documentation updated (for new features)?
[ ] Issue referenced (for PRs that solve an issue)?

Reviewer checklist

[ ] CHANGELOG updated with public API or any other important changes?

📚 Documentation preview 📚: https://metatensor--559.org.readthedocs.build/en/559/

This has been fixed by the cmake package in <IP_ADDRESS>: https://pypi.org/project/cmake/3.29.0/