breaking: codeActionsOnSave

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version: 1.83.0
OS Version: *

Steps to Reproduce:
With version 1.83.0, codeActionsOnSave accepts only an object. Unfortunately for my use case is deal-breaker because I would like to apply format and sorting before the lint. With the object configuration, it is not possible anymore.
This is my actual configuration:
"editor.codeActionsOnSave": {
    "editor.formatOnSave": "always",
    "source.organizeImports": "always",
    "source.sortImports": "always",
    "source.fixAll": "always"
  }

There is an old issue that describes my exact same case: https://github.com/microsoft/vscode/issues/88131.
Do you have any workaround to achieve the same result, or can you please consider rolling back the array configuration?

Source seems to indicate that array is still allowed:
https://github.com/microsoft/vscode/blob/7d4027b62bb1e620e5454580450fa646682bc102/src/vs/workbench/contrib/codeActions/browser/codeActionsContribution.ts#L40-L62

Or maybe when 153335bd0611fcb46cf7d0e879eca53e11f5d960 from @justschen added type and additionalProperties in lines 55-59 above these overrode the oneOf array at lines 41+ ?

Or maybe when 153335b from @justschen added type and additionalProperties in lines 55-59 above these overrode the oneOf array at lines 41+ ?

This is possible. If I try with an array this is the result:

And no actions are performed

Error is coming from https://github.com/microsoft/vscode/commit/153335bd0611fcb46cf7d0e879eca53e11f5d960 in saveParticipants.
Interesting case - when there are Code Actions in the array, even with the error (saying Incorrect type...), do code actions still run?

Error is coming from 153335b in saveParticipants (lines 283, where string[] was replaced)
Interesting case - when there are Code Actions in the array, even with the error (saying Incorrect type...), do code actions still run?

I tried rolling back to my previous conf:

"editor.codeActionsOnSave": [
    "editor.formatOnSave",
    "source.organizeImports",
    "source.sortImports",
    "source.fixAll"
  ]

And unfortunately no actions are performed

roger. looking at it rn, and draft PR is mentioned here. will take a look at this again first thing in the morning.

Probably same issue on SO: editor.codeActionsOnSave does not run in order: changes form VSCode 1.82 to VSCode 1.83

@ArturoDent not sure if you are the OP, but I wasn't able to find a difference in current behavior vs. what happens in 1.82. Do you have a repro of this for expected vs. current behavior?

@justschen Thanks for taking this on!
The difference in current behavior vs 1.82 is that in 1.83 array values are silently ignored, and code actions are not run on save
As you have mentioned, an object config is not suitable because we can't specify the order. This broke our dev environment, and we look forward to a fix. Thank you!

Running into this issue as well, so it is very much appreciated @justschen that you are looking into this.
Specifically, we are using a combination of Prettier and ESLint for formatting and linting to enforce JS Standard Style, which depends on the order in which the actions are applied.
  "editor.codeActionsOnSave": ["source.formatDocument", "source.fixAll.eslint"],
  "editor.defaultFormatter": "esbenp.prettier-vscode",

Being able to format the document via Prettier and then applying ESLint fixes does not seem to be possible with the object notation right now.

Hi @justschen, here is a repro. Consider this spec file: https://github.com/orchy-mfe/orchy-core/blob/main/packages/web-component/src/configuration-client/httpConfigurationClient.spec.ts
Here is the behaviour of vscode 1.82:
https://github.com/microsoft/vscode/assets/6383527/dbbea965-3d57-4393-87b4-77eff17da0e0
While this is the behaviour of vscode 1.83, without any change in the configuration:
https://github.com/microsoft/vscode/assets/6383527/6fd9ee90-3db2-4cf0-93d6-91df72ee297a
If I update the configuration to be an object, this is the final result:
https://github.com/microsoft/vscode/assets/6383527/0090e1ed-6b7e-495d-ab4d-becc65ac1588
As you can see, at each save imports are flickering but never really fixed.

Candidate PR will just add back support for arrays for now! Under discussion atm if orderings from objects will be considered.

tests candidate for https://github.com/microsoft/vscode/issues/194861.
insiders PR (when released): https://github.com/microsoft/vscode/pull/194870
release branch PR: https://github.com/microsoft/vscode/pull/194930
Things to test:

Search in settings for Code actions on save
edit in settings.json
Test scenarios for explicit, always, and never when saving normally, and do so again when Auto Save is enabled for Window change and Focus Change, as well as when Auto Save is enabled after delay (in which case nothing would happen).
Test scenarios for true and false in same conditions.
Code Actions with the array (ensure no error, runs like true and false).
Edge Cases: Scenarios like https://github.com/microsoft/vscode/issues/194978 where multiple types of source actions are used.

Example for arrays:
"editor.codeActionsOnSave": [
    "editor.formatOnSave",
    "source.organizeImports",
    "source.sortImports",
    "source.fixAll"
  ]

Runs when code actions are in the array, does not run when code actions are excluded from the array.
Known issues:

Intellisense only shows source.fixAll and source.organizeImports: https://github.com/microsoft/vscode/issues/161284

Arrays for codeactionsonsave were what allowed the "Format Code Action", rohit-gohri.format-code-action to work.  This was important because the array determines the order which you can't do with an object.

verified on latest insiders
Version: 1.84.0-insider (user setup)
Commit: eb4f3c149f34d82b9763a08230907cf79e7fc103
Date: 2023-10-10T07:26:46.161Z
Electron: 25.8.4
ElectronBuildId: 24154031
Chromium: 114.0.5735.289
Node.js: 18.15.0
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.22621


[SPARK-48113][CONNECT] Allow Plugins to integrate with Spark Connect

What changes were proposed in this pull request?
This PR enables Spark Connect plugins to process Relations and Expressions using SparkConnectPlanner on the server side and to create DataFrames using Relations on the client side. This has been difficult due to the shading of the protobuf libraries, which meant that Java classes generated for the plugin's Protobuf message usage different base classes than the Java classes for Spark's protobuf messages. This was previously worked around by adding methods that accept a byte array (containing a serialized protobuf message) instead of a protobuf message. Unfortunately, this was not scalable as a lot of methods (such as DataTypeProtoConverter.toCatalystType) did not have this alternative. Luckily, we can avoid having to do this as the generated Java classes are not shaded and can still be used from plugins. Instead, plugins should serialize their own version of the generated Java classes for Spark Connect's protobuf messages and then parse them using Spark's (using the ConnectProtoUtils added in this PR).
Why are the changes needed?
Enable the development of Spark Connect plugins.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Existing tests
Was this patch authored or co-authored using generative AI tooling?
No

Could you re-trigger CIs, @tomvanbussel ?

Merged to master.

What's a Spark Connect Plugin? And where can we read some documentation about how to create one?
I see there is this blog post describing how to extend Spark Connect, but I assume we have (or should have) our own documentation about this, no?

Looks like the docs I am looking for are in #45340.


chore: remove experimental flag from oracle endblocker

Description
This turns off the experimental flag for the oracle endblocker.
Should be merged in after v3.3 is cut 💯

Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...

[ ] included the correct type prefix in the PR title
[ ] added ! to the type prefix if API or client breaking change
[ ] added appropriate labels to the PR
[ ] targeted the correct branch (see PR Targeting)
[ ] provided a link to the relevant issue or specification
[ ] added a changelog entry to CHANGELOG.md
[ ] included comments for documenting Go code
[ ] updated the relevant documentation or specification
[ ] reviewed "Files changed" and left comments if necessary
[ ] confirmed all CI checks have passed

Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...

[ ] confirmed the correct type prefix in the PR title
[ ] confirmed all author checklist items have been addressed
[ ] reviewed state machine logic
[ ] reviewed API design and naming
[ ] reviewed documentation is accurate
[ ] reviewed tests and test coverage
[ ] manually tested (if applicable)

Codecov Report

Merging #1662 (0934ab9) into main (2782a97) will decrease coverage by 0.01%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##             main    #1662      +/-   ##
==========================================
- Coverage   55.29%   55.28%   -0.02%
==========================================
  Files          73       73
  Lines        7503     7501       -2
==========================================
- Hits         4149     4147       -2
  Misses       3034     3034
  Partials      320      320

Impacted Files
Coverage Δ

x/oracle/module.go
52.63% <0.00%> (-0.62%)
:arrow_down:

x/oracle/abci.go
82.35% <75.00%> (-0.18%)
:arrow_down:


Added component for content buffering time

Changes

Added component for content buffering time
Remove duplicates in other components which store buffering time for mp4 ad and VRM processing.

JIRA Ticket
@VerizonAdPlatforms/mobile-sdk-developers: Please review.

@VladyslavAnokhin is it RFR?

@AndriiMoskvin Yes


[Web] Fix thread+dlink builds with emscripten 3.1.61+git

This PR does few things to restore and improve thread+dlink web builds:

Refactor the emscripten's -s OPTION=value to -sOPTION=value to get rid of a nasty warning (I can split this in a separate PR if you prefer, since it adds a bit of noise)
Force the SUPPORT_LONGJMP option to 'wasm' to improve gdextension interop (see emscripten 3.1.32 changelog). ~I'll open a godot-cpp PR to add the same flags~ (godot-cpp counterpart godotengine/godot-cpp#1489).
Disable thorvg threading on the web (this is of little use, and threads are a scarce resource so it increases the chance of deadlock).
Use emscripten dynamicLibraries option to preload GDExtensions instead of manually calling loadDynamicLibrary which seems to avoid a deadlock on firefox (see https://bugzilla.mozilla.org/show_bug.cgi?id=1897427 ).

Note, emscripten 3.1.62 is unreleased, I've taken 3.1.61 and applied https://github.com/emscripten-core/emscripten/pull/19496

Thanks!


Determine origin IP from Google headers and set REMOTE_ADDR

Resolve bug reported by @apolito where REMOTE_ADDR header and env var are blank.
R: @bryanmau1 CC: @apolito @isdal

LGTM


Dot Executable called if graphFormat != dot or createImage=false

mvn com.github.ferstl:depgraph-maven-plugin:3.2.2:graph -nsu -DgraphFormat=text -DcreateImage=false

[ERROR] Failed to execute goal com.github.ferstl:depgraph-maven-plugin:3.2.2:graph (default-cli) on project <myproject>: Unable to write graph file.: Unable to execute Graphvi
z: Error while executing process. Cannot run program "dot": CreateProcess error=2, The system cannot find the file specified -> [Help 1]

Not reproducible on Windows PowerShell, Windows cmd.exe and Bash.


Add operation index to PathException for detailed error reporting

The reason for this change is to have the index for the operation in cases where two identical operations target the same resource.
For example, if two identical remove operations target the same resource, the latter will fail because the first operation already removed the resource.
By having the index, we can accurately identify and report the failing operation.

Let's add op index via a setter function instead of constructor, so that there is no breaking change of constructor signature.

Done ✅


DockerHub Image Workflow

Changes included in this PR
Add workflow to create and upload Bodo docker image to DockerHub with each new release.

Testing strategy
https://github.com/bodo-ai/Bodo/actions/runs/12420811976
Tested uploaded image locally
docker pull bodoai/bodoai_image:latest
docker run -p 8888:8888 --cpus=8 bodoai/bodoai_image

User facing changes

Checklist

[x] Pipelines passed before requesting review. To run CI you must include [run CI] in your commit message.
[x] I am familiar with the Contributing Guide
[x] I have installed + ran pre-commit hooks.

Also @hadia206 what do we do about the missing Codecov main report?

Also @hadia206 what do we do about the missing Codecov main report?

For that, The problem is main need to run with codecov and generate a coverage file for it.
For now, I'll try with changing base to be Hadia/codecov and see if that works for now.


Update to Swift 2.0

Maybe we could create a swift-2.0 branch?
#7

:+1:

:+1:

Updated, thanks all!


Rubocop

Coverage decreased (-0.003%) to 83.466% when pulling 62797c45b93a0e953146e4ae51e3a91d294c97f5 on itowtips:rubocop into c578d859600a793ea3cfae14e2079270dbf97395 on shirasagi:master.


Clean Zone Viomi.V10

I have a xiaomi mop-p vacuum cleaner:
NAME: RoboBobo
ID: 3756...
MAC: 5C:6B:....
IP: <IP_ADDRESS>
TOKEN: 4b7841....
MODEL: viomi.vacuum.v10
I have integrated it with mIot without problems, I can start, pause, send to docker... But the part of sending to zones or point gives me an error:

when trying to call the service:
service: xiaomi_miot_raw.call_action
data:
  entity_id: vacuum.v10_cloud_
  siid: 4
  aiid: 13
  inn:
    - 0
    - 1

I get this error:
Failed to call service xiaomi_miot_raw.call_action. Unknown error
any idea what i'm doing wrong?

xiaomi_miot_raw is not this component.

event_type: call_service
data:
  domain: vacuum
  service: send_command
  service_data:
    entity_id: vacuum.viomi_v10_804a_robot_cleaner
    command: app_zoned_clean
    params: [[-4.8, -7.4, -2.5, -3, 1]] # [[x1, y2, x2, y1, repeats]]

sweep:service: xiaomi_miot.send_command
data:
  entity_id: vacuum.viomi_v10_804a_robot_cleaner
  method: set_mode_withroom
  params: [0, 1, 0]

sweep mop:service: xiaomi_miot.send_command
data:
  entity_id: vacuum.viomi_v10_804a_robot_cleaner
  method: set_mode_withroom
  params: [1, 1, 0]

mop:service: xiaomi_miot.send_command
data:
  entity_id: vacuum.viomi_v10_804a_robot_cleaner
  method: set_mode_withroom
  params: [3, 1, 0]

Does it work ?


#163383179 Add functionality for user to retrieve and edit their profile

What does this PR do?

Create a user's profile on successful user registration
Enable a user view their profile
Enable a user edit their profile
Allow a user view other users profiles
Prevent a user from editing other users profiles

How should this be manually tested?

Download and install postman onto you're local machine
Clone the repo onto you're local machine
Create and activate virtual environment
Move into the project directory
pip3 install -r requirements.txt python3 manage.py runserver
Open postman
Register a user using the route
http://<IP_ADDRESS>:8000/api/v1/users/
Login the user you just registered
http://<IP_ADDRESS>:8000/api/v1/users/login/
Get the token that was returned
Insert a header in postman with a key of Authorization  and value Bearer <token>
Then visit the route http://<IP_ADDRESS>:8000/api/v1/profiles/<username> using the username you logged in with. Then you should be able to see your profile. This should be a GET request in postman
To update your profile change the request from GET to PUT then input the fields you want to update along with their values in the body area in postman then make the request, this should update your profile.

What are the relevant pivotal tracker stories?
#163383179

Oma nice work. Do we really have to use regular expressions in the URL? Can't we avoid them?

Yeah, I think like we had agreed @oma0256. you should stick to using regular expressions in the urls.

@missvicki had to use them in this case since there's no way I can match username without using regular expressions.

@oma0256, Great work, but we are going to have to try and get rid of re_path see what happens.

@codjoero @missvicki thanks for the feedback got rid of the regular expressions and used path

Works fine. Good work @oma0256. I need to find you and you explain to me why we absolutely need the re_path in the url.

@pbkabali It was a mistake on my side fixed it now using path instead of re_path


How can I reset the navigation stack without this animation?

I'm going from child screens to main screen in a stack but the screens are giving multiple animations and keep redirecting to parent screen. Please help. Thank You!

Duplicate of: https://github.com/react-community/react-navigation/issues/1493


Enable support to get openflow count from all HVs

Tested with creating 2 sandboxes and one controller which created 6 total openflows on each sandbox.
Works as expected below:
Task 6eed038b-ac5f-49e8-913d-d741cd1e5e96: finished
test scenario OvnNetwork.list_oflow_count_on_all_sandboxes
args position 0
args values:
{
"runner": {
"type": "serial",
"times": 1
},
"context": {
"sandbox": {},
"ovn_multihost": {
"controller": "ovn-new-controller-node"
}
}
}
+---------------------------------------------------------------------------------------------------------------------+
|                                                Response Times (sec)                                                 |
+------------------------------------------------+-------+--------+--------+--------+-------+-------+---------+-------+
| action                                         | min   | median | 90%ile | 95%ile | max   | avg   | success | count |
+------------------------------------------------+-------+--------+--------+--------+-------+-------+---------+-------+
| ovn_network.list_oflow_count_for_all_sandboxes | 0.354 | 0.354  | 0.354  | 0.354  | 0.354 | 0.354 | 100.0%  | 1     |
| total                                          | 0.361 | 0.361  | 0.361  | 0.361  | 0.361 | 0.361 | 100.0%  | 1     |
+------------------------------------------------+-------+--------+--------+--------+-------+-------+---------+-------+
Scenario Specific Results
+-------------------------------------------------------------------+
|           Openflow count on each sandbox in StackedArea           |
+----------------------+-----+--------+--------+--------+-----+-----+
| key                  | min | median | 90%ile | 95%ile | max | avg |
+----------------------+-----+--------+--------+--------+-----+-----+
| sandbox-<IP_ADDRESS> | 6.0 | 6.0    | 6.0    | 6.0    | 6.0 | 6.0 |
| sandbox-<IP_ADDRESS> | 6.0 | 6.0    | 6.0    | 6.0    | 6.0 | 6.0 |
+----------------------+-----+--------+--------+--------+-----+-----+
Load duration: 0.366648197174
Full duration: 0.391592979431

Awesome, LGTM!

Actually, one more comment.
I would consider if this scenario new doesn't fit better into OvnSandbox module.

Thanks @jsitnicki for review.
You mean move the lflow logic to ovn_sandbox? The reason I choose current place is because getting openflow count is related to ovs scenarios, similar to other ovn/ovs client commands. Hence, I feel this would be ok. Let me know


container hosting vs hosted kubernetes cluster

In order to run our ach service (REST api), we need to containerize it and run that container somewhere. There's nothing secret inside the container itself, so we can store that on docker hub.
The big question is, do we try and go down the route of a "magic cloud container runner" or just spin up a hosted k8s cluster?
Hosted container runners charge per-container-per-second, which might add up. (Or they charge per-node). You don't get visibility into the control pane and often have to run cloud LB's (cost).
A hosted k8s cluster lets us deploy and connect containers, with the addition of infra services (grafana, logs). We can run multi-zone and spread across.
Initially I see the following being deployed:

apps: ach/rest (maybe put caddy inside this image)
db: hosted mysql
infra: nginx/caddy, grafana, prometheus, ELK/EFK/oklog
secrets: vault? cloud KMS?

FWIW I'm biased towards a hosted k8s setup.

Done, see https://github.com/moov-io/infra/issues/6


Remove TC internals in thermo state computation

Peel off from #966

bors r+

bors r+

Results in this build look the same within machine precision. Merging.

bors r+


My IDE file background is white

I've tried uninstalling and reinstalling it again it's not working can you change the theme back the orginal

oh never mind got it

How did you fix it? This just happened to me as well with the latest update. Both my main window and terminal windows are white.

Yeah so I was retracing and you go settings editor then color scheme then change it to the cyberpunk neon theme

Amazing, that worked. Thank you!


Remove duplicate global formatters matched by require.context()

Summary
This modifies the regular expression that matches components in shell/plugins/global-formatters.js so that only one set of components is matched by require.context().
Fixes #11786

Occurred changes and/or fixed issues

Update the regular expression that matches global formatters

Technical notes summary

Inspecting the components reveals that there are two sets of components that are matched by require.context(), for example:
./AppSummaryGraph.vue
components/formatter/AppSummaryGraph.vue

This looks to be a breaking change in Webpack5, but documentation about this breaking change is hard to find, but a comment left in a webpack issue somewhat confirms this change in behavior^1.
Areas or cases that should be tested

Loading global formatters

Areas which could experience regressions

Loading global formatters

Checklist

[x] The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
[x] The PR has a Milestone
[x] The PR template has been filled out
[x] The PR has been self reviewed
[x] The PR has a reviewer assigned
[x] The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
[x] The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

There are other instances of require.context() used throughout dashboard. We might want to investigate each of these cases to ensure that we are matching the values that we expect.

Note https://github.com/rancher/dashboard/issues/11786 was spun out from the require.context investigation carried out in https://github.com/rancher/dashboard/issues/11773

There are other instances of require.context() used throughout dashboard. We might want to investigate each of these cases to ensure that we match the values we expect.

It would be more convenient to have predefined helpers, typed and with test, highlighting usage cases. If the scope should be bulk importing, it should have some shared logic. Therefore we can define guidelines in terms of project tree structure, naming, and other parameters.
This will also help for when we'll have to migrate to Vite I guess.

Note: For reproduction in Chrome is necessary to enable Verbose as log level.

There are other instances of require.context() used throughout dashboard. We might want to investigate each of these cases to ensure that we match the values we expect.

It would be more convenient to have predefined helpers, typed and with test, highlighting usage cases. If the scope should be bulk importing, it should have some shared logic. Therefore we can define guidelines in terms of project tree structure, naming, and other parameters.
This will also help for when we'll have to migrate to Vite I guess.

I definitely agree with this sentiment; we also have components that directly invoke require.context() and I think that it would be a better pattern to isolate bundler features in some service or util.


175-dev-py4jps-1025: released py4jps 1.0.25 to both PyPI and TestPyPI.

I still think it's better to have the same version number as the Java package, at the moment I'm not sure how someone is able to determine which base lib version this is based on

One can check the jps-base-lib version in the JPS_BASE_LIB/pom.xml when the release commit was made. This is not ideal but it will remain as it is before the automated release is set up.


RangeError: Maximum call stack size exceeded

expander.js:2472:22 (build from Master)
Unfortunately I can't share the code that results in this error, and haven't found another way yet to reproduce it.

@SanderSpies just pushed a fix for a stack overflow. Let me know if that fixed your stack overflow.


segment and vector outputs are single value

Environment Information

samgeo version: segment_geospatial-0.4.0-py2.py3-none-any.whl
Python version: 3.1
Operating System: Windows 10

Description
Ran the example code provided in both pycharm on local machine and in Google Colab here:
https://colab.research.google.com/github/opengeos/segment-geospatial/blob/main/docs/examples/satellite.ipynb#scrollTo=Gqby0rFINPNR
Output vectors and segments return single value of 255. Does not return the same output as shown in example.

What I Did
import os
from samgeo import SamGeo, tms_to_geotiff, get_basemaps
bbox = [-122.0142108,37.0539328,-122.0129377,37.0554187]

image = 'satellite_v6.tif'
shapefile = "segment_v6.shp"
mask = 'segment_v6.tif'
tms_to_geotiff(output=image, bbox = bbox, zoom=20, source="Satellite", overwrite=True)

# '''
# Initialize SAM class
# '''
out_dir = os.path.join(os.path.expanduser("~"), "Downloads")
checkpoint = os.path.join(out_dir, "sam_vit_h_4b8939.pth")

sam = SamGeo(
   model_type="vit_h",
   checkpoint=checkpoint,
   sam_kwargs=None,
)
#
# '''
# Segment the image
# Set batch=True to segment the image in batches. This is useful for large images that cannot fit in memory.
# '''
print('Generating segments...')

sam.generate(
   image, mask, batch=True, foreground=True, erosion_kernel=(3, 3), mask_multiplier=255
)

# '''
# Polygonize the raster data
# Save the segmentation results as a GeoPackage file.
# '''
print('Creating shapefile...')
sam.tiff_to_vector(mask, shapefile)

Returns same results as in the Colab example.

This bug has been fixed in https://github.com/opengeos/segment-geospatial/pull/29, but it has not been released to PyPI yet. You can run the following to install it from GitHub. Otherwise, wait until the next release later this week.
pip install git+https://github.com/opengeos/segment-geospatial.git

Or install v0.3.0.
pip install segment-geospatial==0.3.0

In line. resintalled version 0.3.0
sam.generate() returns an error:
mask = "segment.tiff"
sam.generate(
image, mask, batch=True, foreground=True, erosion_kernel=(3, 3), mask_multiplier=255
)
TypeError                                 Traceback (most recent call last)
 in <cell line: 2>()
1 mask = "segment.tiff"
----> 2 sam.generate(
3     image, mask, erosion_kernel=(3, 3), mask_multiplier=255
4 )
/usr/local/lib/python3.10/dist-packages/samgeo/samgeo.py in generate(self, in_path, out_path, **kwargs)
110         """
111
--> 112         return tiff_to_tiff(in_path, out_path, self, **kwargs)
113
114     def image_to_image(self, image, **kwargs):
TypeError: tiff_to_tiff() got an unexpected keyword argument 'erosion_kernel'

It is probably because the notebook has been updated. It is no longer compatible with v0.3. Try installing from Github

You're right, thank you


HDInsight SDK Preview Overview

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs-ref-mapping/reference.yml
:white_check_mark:Succeeded

docs-ref-services/hdinsight.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


[Bug]: [FromForm] does not generate a property in schema but makes itself the schema

Describe the bug
I have a Minimal API. In previous versions of this library I had to patch the generated schema to have tags in the schema next to file (-> properties of schema object).
I heard, in the newer versions of this library [FromForm] is better supported, so I tried that.
Unfortunately, one of my endpoints relying on [FromForm] yields a schema that is incorrect.
I have a Minimal API with the following action:
app.MapPost(
    "{tool}/{scenario}/{fileName}",
    async (
        string tool,
        string scenario,
        string fileName,
        [FromForm(Name = "tags")] string tags,
        IFormFile file,
        HttpRequest request) =>
    {
        return Results.Ok();
    })
.WithName("Upload")
.DisableAntiforgery()
.WithOpenApi();

[!NOTE]
A simpler version without file also shows this behavior.

Expected behavior
It should generate:
{
    "operationId": "Upload",
    "parameters": [
        {
            "name": "tool",
            "in": "path",
            "required": true,
            "schema": {
                "type": "string"
            }
        },
        {
            "name": "scenario",
            "in": "query",
            "required": true,
            "schema": {
                "type": "string"
            }
        },
        {
            "name": "fileName",
            "in": "path",
            "required": true,
            "schema": {
                "type": "string"
            }
        }
    ],
    "requestBody": {
        "content": {
            "multipart/form-data": {
                "schema": {
                    "required": [
                        "file"
                    ],
                    "type": "object",
                    "properties": {
                        "file": {
                            "type": "string",
                            "format": "binary"
                        },
                        "tags": {
                            "type": "string"
                        }
                    }
                },
                "encoding": {
                    "tags": {
                        "style": "form"
                    },
                    "file": {
                        "style": "form"
                    }
                }
            }
        },
        "required": true
    },
    "responses": {
        "200": {
            "description": "OK"
        }
    }
}

[!NOTE]
Please note the file and tags properties in the schema. This way I can send a tags string alongside the binary file payload.

[!NOTE]
tags in encoding is just a guess on my side.

Actual behavior
It generates:
"post": {
    "operationId": "Upload",
    "parameters": [
        {
            "name": "tool",
            "in": "path",
            "required": true,
            "schema": {
                "type": "string"
            }
        },
        {
            "name": "scenario",
            "in": "query",
            "required": true,
            "schema": {
                "type": "string"
            }
        },
        {
            "name": "fileName",
            "in": "path",
            "required": true,
            "schema": {
                "type": "string"
            }
        }
    ],
    "requestBody": {
        "content": {
            "multipart/form-data": {
                "schema": {
                    "allOf": [
                        {
                            "type": "string"
                        },
                        {
                            "required": [
                                "file"
                            ],
                            "type": "object",
                            "properties": {
                                "file": {
                                    "type": "string",
                                    "format": "binary"
                                }
                            }
                        }
                    ]
                },
                "encoding": {
                    "tags": {
                        "style": "form"
                    },
                    "file": {
                        "style": "form"
                    }
                }
            }
        },
        "required": true
    },
    "responses": {
        "200": {
            "description": "OK"
        }
    }
}

This schema would mean, that the body is a mix of a string (tags) and something with a property file that is a binary file (⚠ note the allOf). That is incorrect.

[!NOTE]
A simpler version without file also shows this behavior (but with skipping allOf).

[!NOTE]
As to be expected, Swagger UI is also not able to display a tags input anywhere

Steps to reproduce

Create new minimal API project with .NET 8 from template
Configure to use swagger gen
Add endpoint like in example
Update Swagger libraries
Browse to the generated swagger.json and inspect generated OpenAPI schema

Exception(s) (if any)
No response
Swashbuckle.AspNetCore version
6.8.1
.NET Version
net8.0
Anything else?
No response

I am working on it. It's a fix over the PRs: #2979, #2972 and #2963.
The problem that the previous version had is that if there is no schema it has to create the properties and so on.
The AllOf is OK (Because the implementation of Microsoft.AspNetCore.OpenApi does just the same (if there is more than one element then it creates an AllOf node.
This is how it's going to get rendered:
"post": {
    "operationId": "Upload",
    "parameters": [
        {
            "name": "tool",
            "in": "path",
            "required": true,
            "schema": {
                "type": "string"
            }
        },
        {
            "name": "scenario",
            "in": "query",
            "required": true,
            "schema": {
                "type": "string"
            }
        },
        {
            "name": "fileName",
            "in": "path",
            "required": true,
            "schema": {
                "type": "string"
            }
        }
    ],
    "requestBody": {
        "content": {
            "multipart/form-data": {
                "schema": {
                    "allOf": [
                        {
							"type": "object",
							"properties": {
							  "tags": {
								"type": "string"
							  }
							}
                        },
                        {
                            "required": [
                                "file"
                            ],
                            "type": "object",
                            "properties": {
                                "file": {
                                    "type": "string",
                                    "format": "binary"
                                }
                            }
                        }
                    ]
                },
                "encoding": {
                    "tags": {
                        "style": "form"
                    },
                    "file": {
                        "style": "form"
                    }
                }
            }
        },
        "required": true
    },
    "responses": {
        "200": {
            "description": "OK"
        }
    }
}


Is there a way that the ClientInterceptor of C++ can modify method name

PLEASE DO NOT POST A QUESTION HERE. This form is for bug reports and feature requests ONLY!
For general questions and troubleshooting, please ask/look for answers at StackOverflow, with "grpc" tag: https://stackoverflow.com/questions/tagged/grpc
For questions that specifically need to be answered by gRPC team members, please ask/look for answers at grpc.io mailing list: https://groups.google.com/forum/#!forum/grpc-io


Use callback in muxer.end instead of close event

Solves https://github.com/ipfs/js-libp2p-ipfs-nodejs/issues/58
Not sure if this is the right way to fix it though, since multiplex seems to not correctly emit close event...

@diasdavid you were right, changing order fixes issue as well!


kubernetes v1.0.0 failing test cases

I am trying to build docker images with kubernetes v1.0.0 . I pulled the git repository and created a branch for v1.0.0. The ./run.sh hack/build-go.sh goes through fine, and I can see that the binaries have been built under:
~/kubernetes/_output/dockerized/bin/
darwin  linux  test_for_remote  windows

However, when I run
./run.sh hack/test-go.sh

It fails with this cryptic error:
ok      github.com/GoogleCloudPlatform/kubernetes/third_party/golang/expansion  0.008s
!!! Error in hack/test-go.sh:159
  'go test "${goflags[@]:+${goflags[@]}}" ${KUBE_RACE} ${KUBE_TIMEOUT} "${@+${@/#/${KUBE_GO_PACKAGE}/}}" "${testargs[@]:+${testargs[@]}}"' exited with status 1
Call stack:
  1: hack/test-go.sh:159 runTests(...)
  2: hack/test-go.sh:221 main(...)
Exiting with status 1
!!! Error in ./../build/common.sh:471
  '"${docker_cmd[@]}" "$@"' exited with status 1
Call stack:
  1: ./../build/common.sh:471 kube::build::run_build_command(...)
  2: ./run.sh:30 main(...)
Exiting with status 1

I am trying to build a dockerized image to try and run a local docker-based installation.

Looks like this is fixed v1.0.1 . I created a branch of the v1.0.1 tag and the ./release.sh build script was able to pass all the test cases. There closing this.


DriverError when running integration test with a custom widget

I am trying to write an integration test for my flutter application. I have a custom widget which I am using to create a TextField with rounded borders. I have created a gist for the widget if you want to have a look. But I am having some problem running integration test with this widget.
Steps to Reproduce
As part of my integration test, I need to tap on this RoundTextField and enter some text into it. When adding the widget to my application, I also add a key to it
RoundTextField(
  key: Key('loginKeyString'),
  icon: Icon(Icons.add),
  hint: 'Some data',
)

Now, in my integration test this is what I am trying to do

void main() {
  group('Test', (){
    FlutterDriver driver;

    setUpAll(() async {
      driver = await FlutterDriver.connect();
    });

    tearDownAll(() async {
      if (driver != null) {
        await driver.close();
      }
    });

    test('Click test', () async {
      await driver.tap(find.byValueKey('loginKeyString'));
    });

  });
}

And when I run it, this is the error that comes up.

DriverError: Error in Flutter application: Uncaught extension error while executing tap: Bad state: Too many elements

Note
This error only comes up when I use my custom widget. If I use a TextField this integration test passes.
Logs

[+4306 ms] 00:00 +0: Test (setUpAll)
[  +46 ms] [info ] FlutterDriver: Connecting to Flutter application at http://<IP_ADDRESS>:49681/
[ +306 ms] [trace] FlutterDriver: Isolate found with number: 287964734
[  +91 ms] [trace] FlutterDriver: Isolate is paused at start.
[  +13 ms] [trace] FlutterDriver: Attempting to resume isolate
[   +5 ms] [trace] FlutterDriver: Waiting for service extension
[ +700 ms] [info ] FlutterDriver: Connected to Flutter application.
[   +8 ms] 00:01 +0: Test Click test
[ +554 ms] 00:01 +0 -1: Test Click test [E]
[   +4 ms]   DriverError: Error in Flutter application: Uncaught extension error while executing tap: Bad state: Too many elements
[        ]   #0      Iterable.single (dart:core/iterable.dart:554:24)
[        ]   #1      WidgetController._getElementPoint (package:flutter_test/src/controller.dart:511:47)
[        ]   #2      WidgetController.getCenter (package:flutter_test/src/controller.dart:483:12)
[        ]   #3      WidgetController.tap (package:flutter_test/src/controller.dart:260:18)
[        ]   #4      FlutterDriverExtension._tap (package:flutter_driver/src/extension/extension.dart:304:19)
[        ]   <asynchronous suspension>
[        ]   #5      FlutterDriverExtension.call (package:flutter_driver/src/extension/extension.dart:180:51)
[        ]   <asynchronous suspension>
[        ]   #6      BindingBase.registerServiceExtension.<anonymous closure> (package:flutter/src/foundation/binding.dart:392:32)
[        ]   <asynchronous suspension>
[        ]   #7      _runExtension (dart:developer/runtime/libdeveloper.dart:86:23)
[        ]   #8      RenderView.performLayout (package:flutter/src/rendering/view.dart:140:3)
[        ]   #9      RenderObject._layoutWithoutResize (package:flutter/src/rendering/object.dart:1506:7)
[   +2 ms]   #10     PipelineOwner.flushLayout (package:flutter/src/rendering/object.dart:765:18)
[        ]   #11     __DriverBinding&BindingBase&ServicesBinding&SchedulerBinding&GestureBinding&PaintingBinding&SemanticsBinding&RendererBinding.drawFrame (package:flutter/src/rendering/binding.dart:270:19)
[        ]   #12     __DriverBinding&BindingBase&ServicesBinding&SchedulerBinding&GestureBinding&PaintingBinding&SemanticsBinding&RendererBinding&WidgetsBinding.drawFrame (package:flutter/src/widgets/binding.dart:671:13)
[        ]   #13     __DriverBinding&BindingBase&ServicesBinding&SchedulerBinding&GestureBinding&PaintingBinding&SemanticsBinding&RendererBinding._handlePersistentFrameCallback (package:flutter/src/rendering/binding.dart:208:5)
[        ]   #14     __DriverBinding&BindingBase&ServicesBinding&SchedulerBinding._invokeFrameCallback (package:flutter/src/scheduler/binding.dart:990:15)
[        ]   #15     __DriverBinding&BindingBase&ServicesBinding&SchedulerBinding.handleDrawFrame (package:flutter/src/scheduler/binding.dart:930:9)
[        ]   #16     __DriverBinding&BindingBase&ServicesBinding&SchedulerBinding.scheduleWarmUpFrame.<anonymous closure> (package:flutter/src/scheduler/binding.dart:751:7)
[        ]   #17     Timer._createTimer.<anonymous closure> (dart:async/runtime/libtimer_patch.dart:21:15)
[        ]   #18     _Timer._runTimers (dart:isolate/runtime/libtimer_impl.dart:382:19)
[        ]   #19     _Timer._handleMessage (dart:isolate/runtime/libtimer_impl.dart:416:5)
[        ]   #20     _RawReceivePortImpl._handleMessage (dart:isolate/runtime/libisolate_patch.dart:171:12)
[        ]   Original error: null
[        ]   Original stack trace:
[        ]   null
[  +35 ms]   package:flutter_driver/src/driver/driver.dart 405:7   FlutterDriver._sendCommand
[        ]   ===== asynchronous gap ===========================
[        ]   dart:async/future_impl.dart 22:43                     _Completer.completeError
[        ]   dart:async/runtime/libasync_patch.dart 40:18          _AsyncAwaitCompleter.completeError
[        ]   package:flutter_driver/src/driver/driver.dart         FlutterDriver._sendCommand
[        ]   ===== asynchronous gap ===========================
[        ]   dart:async/zone.dart 1053:19                          _CustomZone.registerUnaryCallback
[        ]   dart:async/runtime/libasync_patch.dart 77:23          _asyncThenWrapperHelper
[        ]   package:flutter_driver/src/driver/driver.dart         FlutterDriver._sendCommand
[        ]   package:flutter_driver/src/driver/driver.dart 431:11  FlutterDriver.tap
[        ]   ===== asynchronous gap ===========================
[        ]   dart:async/zone.dart 1053:19                          _CustomZone.registerUnaryCallback
[        ]   dart:async/runtime/libasync_patch.dart 77:23          _asyncThenWrapperHelper
[        ]   package:test/src/backend/declarer.dart                Declarer.test.<fn>.<fn>.<fn>
[  +14 ms]   package:test/src/backend/invoker.dart 250:15          Invoker.waitForOutstandingCallbacks.<fn>
[        ]   ===== asynchronous gap ===========================
[        ]   dart:async/zone.dart 1045:19                          _CustomZone.registerCallback
[        ]   dart:async/zone.dart 962:22                           _CustomZone.bindCallbackGuarded
[        ]   dart:async/timer.dart 52:45                           new Timer
[   +3 ms]   dart:async/timer.dart 87:9                            Timer.run
[   +1 ms]   dart:async/future.dart 174:11                         new Future
[        ]   package:test/src/backend/invoker.dart 402:11          Invoker._onRun.<fn>.<fn>.<fn>
[        ] 00:01 +0 -1: Test (tearDownAll)
[  +68 ms] 00:01 +0 -1: Some tests failed.
[   +2 ms] Unhandled exception:
[        ] Dummy exception to set exit code.
[        ] #0      _rootHandleUncaughtError.<anonymous closure> (dart:async/zone.dart:1112:29)
[        ] #1      _microtaskLoop (dart:async/schedule_microtask.dart:41:21)
[        ] #2      _startMicrotaskLoop (dart:async/schedule_microtask.dart:50:5)
[        ] #3      _Timer._runTimers (dart:isolate/runtime/libtimer_impl.dart:391:30)
[        ] #4      _Timer._handleMessage (dart:isolate/runtime/libtimer_impl.dart:416:5)
[        ] #5      _RawReceivePortImpl._handleMessage (dart:isolate/runtime/libisolate_patch.dart:171:12)
[  +67 ms] Stopping application instance.
[        ] Stopping application.
[   +7 ms] "flutter drive" took 38,787ms.
Driver tests failed: 255

#0      throwToolExit (package:flutter_tools/src/base/common.dart:26:3)
#1      _runTests (package:flutter_tools/src/commands/drive.dart:300:5)
<asynchronous suspension>
#2      DriveCommand.runCommand (package:flutter_tools/src/commands/drive.dart:124:23)
<asynchronous suspension>
#3      FlutterCommand.verifyThenRunCommand (package:flutter_tools/src/runner/flutter_command.dart:375:18)
#4      _asyncThenWrapperHelper.<anonymous closure> (dart:async/runtime/libasync_patch.dart:77:64)
#5      _rootRunUnary (dart:async/zone.dart:1132:38)
#6      _CustomZone.runUnary (dart:async/zone.dart:1029:19)
#7      _FutureListener.handleValue (dart:async/future_impl.dart:129:18)
#8      Future._propagateToListeners.handleValueCallback (dart:async/future_impl.dart:642:45)
#9      Future._propagateToListeners (dart:async/future_impl.dart:671:32)
#10     Future._complete (dart:async/future_impl.dart:476:7)
#11     _SyncCompleter.complete (dart:async/future_impl.dart:51:12)
#12     _AsyncAwaitCompleter.complete.<anonymous closure> (dart:async/runtime/libasync_patch.dart:33:20)
#13     _rootRun (dart:async/zone.dart:1124:13)
#14     _CustomZone.run (dart:async/zone.dart:1021:19)
#15     _CustomZone.bindCallback.<anonymous closure> (dart:async/zone.dart:947:23)
#16     _microtaskLoop (dart:async/schedule_microtask.dart:41:21)
#17     _startMicrotaskLoop (dart:async/schedule_microtask.dart:50:5)
#18     _runPendingImmediateCallback (dart:isolate/runtime/libisolate_patch.dart:115:13)
#19     _RawReceivePortImpl._handleMessage (dart:isolate/runtime/libisolate_patch.dart:172:5)

flutter analyze
Analyzing flutter_integrations...
No issues found! (ran in 6.1s)

flutter doctor -v
[✓] Flutter (Channel master, v0.9.7-pre.79, on Mac OS X 10.13.6 17G65, locale en-IN)
    • Flutter version 0.9.7-pre.79 at /Users/Ajil/Development/flutter
    • Framework revision e4111b804b (13 hours ago), 2018-10-08 23:27:20 -0400
    • Engine revision bfcdad8557
    • Dart version 2.1.0-dev.6.0.flutter-c6254163dc

[✓] Android toolchain - develop for Android devices (Android SDK 28.0.3)
    • Android SDK at /Users/Ajil/Library/Android/sdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-28, build-tools 28.0.3
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1136-b06)
    • All Android licenses accepted.

[✓] iOS toolchain - develop for iOS devices (Xcode 10.0)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 10.0, Build version 10A255
    • ios-deploy 2.0.0
    • CocoaPods version 1.5.3

[✓] Android Studio (version 3.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 29.0.2
    • Dart plugin version 181.5616
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1136-b06)

[✓] VS Code (version 1.27.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 2.19.0

[✓] Connected device (1 available)
    • iPhone 8 • 8444C14E-ADCA-4634-BC25-3816F4EA3041 • ios • iOS 12.0 (simulator)

• No issues found!

The problem here is that you assigned key to two different widgets, your RoundTextField via this.key and the child container widget. This causes flutter driver to find two widgets instead of one

The problem here is that you assigned key to two different widgets, your RoundTextField via this.key and the child container widget. This causes flutter driver to find two widgets instead of one

Nice catch. Thanks

The problem here is that you assigned key to two different widgets, your RoundTextField via this.key and the child container widget. This causes flutter driver to find two widgets instead of one

Can you explain again about  this?

@ajilo297, did you solve this situation?
Can you explain about this?

Hey,
I don't have the code which was causing the problem, but I believe the problem was here.
RoundTextField(
  key: Key('loginKeyString'),
  icon: Icon(Icons.add),
  hint: 'Some data',
);

class RoundTextField extends StatelessWidget {
  final Icon icon;
  final String hint;
  final Key key;

  RoundTextField({
    this.icon,
    this.hint,
    this.key,                 // <---- I think I was doing this. This is wrong.
  }): super(key: key);        //       The key should not be part of the widget
}

class RoundTextField extends StatelessWidget {
  final Icon icon;
  final String hint;
  final Key key;

  RoundTextField({
    this.icon,
    this.hint,
  }): super(key: key);    // <---- The key needs to be added to the super constructor
}

I had the following code and had the same problem. As @jonahwilliams said, this code duplicates the keys in MyButton and RaiseButton.
`class MyButton extends StatelessWidget {
final Key key;
const MyButton({this.key});
@override
Widget build(BuildContext context) {
return  RaisedButton(
key: this.key,
);
}
}
MyButton(key: new Key('myButton'));`
By default, all widgets have a property of type Key, without declaring it, you can use the key only for the parent widget.
`class MyButton extends StatelessWidget {
const MyButton({Key key}) : super(key: key);
@override
Widget build(BuildContext context) {
return  RaisedButton();
}
}
MyButton(key: new Key('MyButton'))`

I had the following code and had the same problem. As @jonahwilliams said, this code duplicates the keys in MyButton and RaiseButton.
class MyButton extends StatelessWidget {
  final Key key;
  const MyButton({this.key});

  @override
  Widget build(BuildContext context) {
	return  RaisedButton(
		key: this.key,
	);
  }
}

MyButton(key: new Key('myButton'));

By default, all widgets have a property of type Key, without declaring it, you can use the key only for the parent widget.
class MyButton extends StatelessWidget {
  const MyButton({Key key}) : super(key: key);

  @override
  Widget build(BuildContext context) {
    return  RaisedButton();
  }
}

MyButton(key: new Key('myButton'));

What if I have several widgets with the same key? Let's say list of two identical items and I want to make sure there are two items found.


make Column Selection on hotkey+LMB consistent

please make so when user presses the hotkey and then LMB, the selection would start from the location he pressed LMB on .
currently, the selection expands from existing, 1st placed cursor, and the workaround is to start 1-cursor selection and then press Ctrl+Shift . this is undesired behavior, and the action should not require the user to press the buttons in certain order . (MMB is not always comfortable, specifically with large amount of selections)
also i would like to change the Ctrl+Shift shortcut to Ctrl+Alt . (perfectly, the Keyboard Shortcuts settings should get all the functions that involve mouse, and a way to assign/input the mouse actions)
and the Column Selection should be integrated with the multi-selection . (perfectly, [ Ctrl+Shift/Alt+LMB >-> Column Selection, Shift+LMB >-> adjust the closest/last/1st Column or 1-cursor selection, Ctrl+Shift/Alt+LMB >-> add new Column Selection (multi-select) ] )

Please configure "editor.multiCursorModifier": "ctrlCmd".
Then, alt becomes free and you can use alt + mouse down and mouse drag to create column selections.
You can always also use the middle mouse button to create column selections.

@alexdima your comments doesn't address a single of the mentioned features . obviously i am already using "editor.multiCursorModifier": "ctrlCmd"

For me, when I configure "editor.multiCursorModifier": "ctrlCmd" and then press Alt and press the left mouse button, the selection starts from the location where I pressed it:

Having the ability to customize mouse bindings is tracked in #3130

@alexdima i reinstalled it and that worked, thank you . would still be good to make it work with multi-selection (Alt+Ctrl) .


Error installing extension from marketplace

My org can't install the extension from the marketplace due to AAD error.
Error: GetUserAccessToken: Failed to obtain an access token of identity
Activity ID: 73ff8f9d-afb2-4efd-98c2-14b789e93286
Date and Time: 2/12/2024 3:13:59 PM (UTC)

Hi, sorry for late reply. Do you still have install issues?
Br
Manuel

No, we had a naming conflict with an existing extension that was removed by Microsoft and then re-enabled during the installation process. After removing the existing extension the installation started working.


Limit reloading the systemctl daemon to distributions using systemd

This is actually the work of StudioEtrange in a separate fork that has not been merged back in to this one. This is commit 2e01f70 on that fork.

This change is

@zanewestover thanks for this. We haven't received any PR from StudionEtrange so probably that's why it hasn't been merged here ;)
This looks good so let's get it shipped.


[Question]How to create only one set of rule/ruleset buttons?

I am trying to have only one set of Rule/Ruleset buttons. I am not able to set the context of buttons when I am trying to add rule to a child. It is always taking the parent context. Any guidance will be helpful. I am trying to set the buttons' context to current rule selection.

Did you manage to create a solution for this? If so, please let me know. Im facing the same issue.


Place the compiled NeoFS protocol files in the repository

they are not used yet, but will be in the next PRs

Have you considered moving "SDK" things to a separate folder?

no i havent. I won’t say anything against it right off the bat, imo u should create an issue to reorganize the tree. Go source code may be placed into src dir, or pkg+internal

Do not move anything we have currently public, this SDK is used a lot.
proto or rawproto may be a bit less ambiguous than api.
internal/api can be considered as well, although these definitions can be useful in some ways.

Do not move anything we have currently public, this SDK is used a lot.

overall agree, #594 is dedicated for the discussion. There are backward compatible ways to do such things

proto or rawproto may be a bit less ambiguous than api.

i dont mind, suggest moving? I thought api  matches well with the names of the corresponding repository and protocol

internal/api can be considered as well, although these definitions can be useful in some ways

currently it is used by neofs-node for server implementation (example), but this is not a burden: the node make codegen for itself
i even like how it sounds: client codegen - for the client implementation, server - for the server. They may be parameterized more specific and flexible. Although now the node uses the SDK client to access other nodes

I thought api matches well with the names of the corresponding repository and protocol

That's true for us, but most people outside don't know what neofs-api is. They just take the SDK and see some api there. If it'd be raw or rawproto it'd be easier to digest.

currently it is used by neofs-node for server implementation

Let's have it exposed for now, perform the transition to the new SDK and then see what uses of api we have case-by-case. Duplicating generated code isn't elegant either, if these definitions have some real use outside then we can have them exported.


ui-view in Jade file doesn't work

This seems to follow the documentation for nested states.
http://plnkr.co/edit/fp09uXZ8xM2suQBwvXr7
EDIT: updated title for more clarity.

Issue still exists and just ran into it. Spent quite some time trying to figure out what was wrong until I found this thread. Using .ui-view still works.

This has just bit me too, wasted a couple of hours on it until I noticed the diff in the html that was generated :<

I solved it adding doctype html

I defined the sub router in express router so solve the render jade template problem.
like below:
$stateProvider
  .state('gallery-index', {
     url: '/index',
     templateUrl:  'temp/index'
  })
  .state('gallery-info', {
     url: '/info',
     templateUrl: 'temp/info'
  });

 $urlRouterProvider.otherwise("/index");

in express router file:
router.get('/temp/index', function(req, res) {
  res.render('temp/index')
});

router.get('/temp/info', function(req, res) {
  res.render('temp/info')
});

hope that help others people...

@hanaarena are your template files called "temp/index.jade"? There's no file extension on the templateUrl in your example; when I've tried this I have to explicitly set templateUrl: "path/filename.pug". Have you got some setting in the main app that interprets the filename?
Also I don't like having to set a route explicitly for every route. It's not very DRY. I wonder whether there's a way to use a wild-card...?

@CJBrew I have set jade as my app default view engine so I can just use res.render(viewName) and express know what view file I want.uh..I have not use templateUrl yet and not found in express.com api doc :(
yeah..jade work with ui-router is confused for me sometime. also never use wild-card


Non semver apps

The real magic is in the update on checkCLI but other changes accidentally found their way in here, too.  Woops!  Non-critical, but sorry for the noise.
closes #21

Fixes this


Insufficient content

Great to know that there are additional parameters.
Usually, these are explained and described, not just mentioned.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2bab3db4-745f-2c66-eac3-be6d6e168200
Version Independent ID: e1479a2b-49cd-9edb-63c1-e1b0e9907d9f
Content: Caption Property - Business Central
Content Source: dev-itpro/developer/properties/devenv-caption-property.md
Service: dynamics365-business-central
GitHub Login: @SusanneWindfeldPedersen
Microsoft Alias: solsen

Thanks, this will be fixed with the next doc refresh.


Config.toml file throws invalid escape sequence error when running in Windows

Description:
$Subject
Steps to reproduce:

Create a ballerina project in Windows system.
Add the following entry to a Config.toml file

[log]
level = "WARN"
format = "json"

[[log.modules]]
name = "myorg/myproject"
level = "DEBUG"

[[log.modules]]
name = "myorg/myproject.foo"
level = "ERROR"

Run the project.
Re-run with the following entry as well.

[integration_tests]
bal_exec_path = "@exec.path@/bal"
temp_dir_path = "@temp.path@/bal"

Affected Versions:
SLAlpha3
OS, DB, other environment details and versions:
Windows OS

Seems to be a bug from toml parser. @xlight05 could you have a look?

I couldn't reproduce this neh,
toml file
[log]
level = "WARN"
format = "json"

[[log.modules]]
name = "myorg/myproject"
level = "DEBUG"

[[log.modules]]
name = "myorg/myproject.foo"
level = "ERROR"

[integration_tests]
bal_exec_path = "@exec.path@/bal"
temp_dir_path = "@temp.path@/bal"

I ran this in a windows PC. I don't get any diagnostics. ;o

@xlight05 could you check against this PR build: https://github.com/ballerina-platform/module-ballerina-log/runs/2208580512?check_suite_focus=true

Thanks, I've debugged the issue and found the cause for this issue. It seems like this is not an issue with configurables or toml parser. Issue happens when gradle replaces<EMAIL_ADDRESS>There are two issues in the replace.

backslash are not escaped
replacement logic also unix specific

Please refer to the below screenshot.

@xlight05 thanks for the input! Yes, the issue was there need to be 2 double backslashes in Config.toml if the OS is Windows. The issue is stored now.


Fix #95

See #95

This is a greater problem than I thought, not only the help filter was faulty, but also the Action Filter.

We also need a test if the expression item is shown. I broke that feature and no test failed.

This should all be fixed with better fuzzy matching.

This should all be fixed with better fuzzy matching.

Thats right - and we should convince the customer that that issue is important.
But for now my fixes should at least make it work as described.
The filter:given: code for the Action Filter was completely faulty.


Remove libunwind Gtrace.c workaround

Since C __thread support has been added, enclave build of libunwind can use
existing 3rdparty source code that depends on it directly, so remove the
Gtrace.c wrapper that was created to work around that dependency.

This will resolve #1275. Thanks!

bors r+


New Server Endpoint Usage

This is in relation to #48 on SIT.Aki-Server-Mod. This uses the newly added endpoint for UDP clients to announce their join intent so that we can track the number of players to display in the server browser and so the fix for joining too soon can be applied to UDP P2P raids.

@paulov-t /coop/server/join appears primarily to be for clients to join, and checks the password where we intend to call this after that has already been called previous, and only adds users to the Authorized list and not the connected list. These changes are designed to allow the check here to run on PeerToPeerUDP as well. Since without it it's possible to join a raid before the host has finished loading and so the client gets permanently stuck joining.


Custom client configuration NOT considered when using SQS

This issue relates to #63.
The PR only corrects SqsClientConfiguration.

As a workaround and to be able to use your own ClientConfiguration (with proxy settings for example), you might do the following:

Do NOT use EnableSqs annotation and switch off the auto configuration for SQS:

@SpringBootApplication(exclude = MessagingAutoConfiguration.class)
class Application { ...

But import SqsConfiguration:

@SpringBootApplication(exclude = MessagingAutoConfiguration.class)
@Import(SqsConfiguration.class)
class Application { ...

And finally declare your own AmazonSQSAsync @Bean definition


Can't run Fetch_Reach.py

Hello I am currently running some of your codes and got some errors I can't solve. It says that
".local/lib/python3.7/site-packages/gym/envs/registration.py:14: PkgResourcesDeprecationWarning: Parameters to load are deprecated.  Call .resolve and .require separately.
result = entry_point.load(False)"
The full message is below
python3 Fetch_Reach.py  /home/matthewcool/.local/lib/python3.7/site-packages/gym/envs/registration.py:14: PkgResourcesDeprecationWarning: Parameters to load are deprecated.  Call .resolve and .require separately.   result = entry_point.load(False) Traceback (most recent call last):   File "Fetch_Reach.py", line 15, in <module>     config.environment = gym.make("FetchReach-v1")   File "/home/matthewcool/.local/lib/python3.7/site-packages/gym/envs/registration.py", line 167, in make     return registry.make(id)   File "/home/matthewcool/.local/lib/python3.7/site-packages/gym/envs/registration.py", line 119, in make     env = spec.make()   File "/home/matthewcool/.local/lib/python3.7/site-packages/gym/envs/registration.py", line 85, in make     cls = load(self._entry_point)   File "/home/matthewcool/.local/lib/python3.7/site-packages/gym/envs/registration.py", line 14, in load     result = entry_point.load(False)   File "/home/matthewcool/anaconda3/envs/my_env/lib/python3.7/site-packages/pkg_resources/__init__.py", line 2443, in load     return self.resolve()   File "/home/matthewcool/anaconda3/envs/my_env/lib/python3.7/site-packages/pkg_resources/__init__.py", line 2449, in resolve     module = __import__(self.module_name, fromlist=['__name__'], level=0)   File "/home/matthewcool/.local/lib/python3.7/site-packages/gym/envs/robotics/__init__.py", line 1, in <module>     from gym.envs.robotics.fetch_env import FetchEnv   File "/home/matthewcool/.local/lib/python3.7/site-packages/gym/envs/robotics/fetch_env.py", line 3, in <module>     from gym.envs.robotics import rotations, robot_env, utils   File "/home/matthewcool/.local/lib/python3.7/site-packages/gym/envs/robotics/robot_env.py", line 10, in <module>     import mujoco_py   File "/home/matthewcool/anaconda3/envs/my_env/lib/python3.7/site-packages/mujoco_py/__init__.py", line 3, in <module>     from mujoco_py.builder import cymj, ignore_mujoco_warnings, functions, MujocoException   File "/home/matthewcool/anaconda3/envs/my_env/lib/python3.7/site-packages/mujoco_py/builder.py", line 507, in <module>     cymj = load_cython_ext(mujoco_path)   File "/home/matthewcool/anaconda3/envs/my_env/lib/python3.7/site-packages/mujoco_py/builder.py", line 101, in load_cython_ext     mod = load_dynamic_ext('cymj', cext_so_path)   File "/home/matthewcool/anaconda3/envs/my_env/lib/python3.7/site-packages/mujoco_py/builder.py", line 124, in load_dynamic_ext     return loader.load_module()   File "__init__.pxd", line 918, in init mujoco_py.cymj
How can I fix this problem??

Sorry I solved it! It was  gym version problem! Thank you!


Removed Unnecessary Ifdefs for MacOS 10.15

Should fix the issue, though it's worth discussing. I build the smaller bits of ST on MacOS 10.15 and lower. But I build the parent class of ST on 10.15 only.
So the encoding and decoding layers are built on 10.14 but all the pieces together are built in 10.15. Should I just #ifdef those smaller pieces to be only on 10.15 as well?


feat: mention npm audit in dependency security reports post

PR Checklist

[x] Addresses an existing open issue: fixes #244
[x] That issue was marked as status: accepting prs
[x] Steps in CONTRIBUTING.md were taken

Overview
Includes https://overreacted.io/npm-audit-broken-by-design/ with a thanks to @EskiMojo14 for mentioning it.
Co-authored-by: Ben Durrant<EMAIL_ADDRESS>

@all-contributors please add @eskimojo14 for code.

🤖 Beep boop! This comment was added automatically by all-contributors-auto-action.
Not all contributions can be detected from Git & GitHub alone. Please comment any missing contribution types this bot missed.
...and of course, thank you for contributing! 💙


Software Server Capabilities - add endpoint for creation of the entity and for fetching it

recheck

@danielaotelea  I'll take a look at the javadoc error this pm. I made a change yesterday which did go in clean, but this build appears to be reporting an error in the top level pom :-(

I can see later PRs have gone through ok. I suggest rebasing/merging with current upstream master, then hopefully it will build clean.

recheck


Can I decode 8k audio?

Thanks for the server.  I have a model trained with 8k audios and want to decode 8k audios, how can I do it? When I run the server, it has an error as shown below,  but I have trouble finding where to add the --allow_{upsample,downsample} option. Can you help me please?
"ERROR (fcgi-nnet3-decoder[5.5.517~1-06bf]:MaybeCreateResampler():online-feature.cc:99) Sampling frequency mismatch, expected 8000, got 16000
Perhaps you want to use the options --allow_{upsample,downsample}",

Problem solved. The data_frequency is defined in "RequestRawReader.h" and "OnlineDecoder.cc".