API call not implemented server-side: No handler found for 'fs subvolume metadata set' in ceph 15.2.17

Describe the bug
failed to provision volume with StorageClass "csi-cephfs-sc": rpc error: code = Internal desc = failed to set metadata key "csi.storage.k8s.io/pvc/name", value "cephfs-pvc" on subvolume &{0xc000948160 a6893219-4fa6-437e-9de1-79c77c835fdb true 0xc0002f6648}: API call not implemented server-side: No handler found for 'fs subvolume metadata set'
Environment details

Image/version of Ceph CSI driver : v3.7.0
Kernel version : 5.4.210-1.el7.elrepo.x86_64
Mounter used for mounting PVC (for cephFS its fuse or kernel. for rbd its
krbd or rbd-nbd) : kernel
Kubernetes cluster version : Server Version: v1.24.4
Ceph cluster version : ceph version 15.2.17 (8a82819d84cf884bd39c17e3236e0632ac146dc4) octopus (stable)

Additional context

csi-cephfs-secret.yaml

apiVersion: v1
kind: Secret
metadata:
  name: csi-cephfs-secret
  namespace: ceph-csi
stringData:
  userID: cephfs
  userKey: AQBt1QNjlAEDJRAAWFeUCwOTLRcfDuok2dvejA==
  adminID: admin
  adminKey: AQBAmgNjcKxwGxAANjoDA2L12Ap403+qjB4tCA==

csi-cephfs-sc.yaml

apiVersion: storage.k8s.io/v1
kind: StorageClass
metadata:
   name: csi-cephfs-sc
   namespace: ceph-csi
provisioner: cephfs.csi.ceph.com
parameters:
   clusterID: a6893219-4fa6-437e-9de1-79c77c835fdb
   fsName: cephfs
   pool: cehpfs-data
   mounter: kernel
   csi.storage.k8s.io/provisioner-secret-name: csi-cephfs-secret
   csi.storage.k8s.io/provisioner-secret-namespace: ceph-csi
   csi.storage.k8s.io/controller-expand-secret-name: csi-cephfs-secret
   csi.storage.k8s.io/controller-expand-secret-namespace: ceph-csi
   csi.storage.k8s.io/node-stage-secret-name: csi-cephfs-secret
   csi.storage.k8s.io/node-stage-secret-namespace: ceph-csi
reclaimPolicy: Delete
allowVolumeExpansion: true
mountOptions:
 - discard

csi-cephfs-test.yaml

apiVersion: v1
kind: PersistentVolumeClaim
metadata:
  name: cephfs-pvc
spec:
  accessModes:
    - ReadWriteMany
  resources:
    requests:
      storage: 1Gi
  storageClassName: csi-cephfs-sc

[root@ceph-node-1 ~]# ceph --version
ceph version 15.2.17 (8a82819d84cf884bd39c17e3236e0632ac146dc4) octopus (stable)
[root@ceph-node-1 ~]# ceph mon --version
ceph version 15.2.17 (8a82819d84cf884bd39c17e3236e0632ac146dc4) octopus (stable)
[root@ceph-node-1 ~]# ceph mgr --version
ceph version 15.2.17 (8a82819d84cf884bd39c17e3236e0632ac146dc4) octopus (stable)
[root@ceph-node-1 ~]# ceph fs ls
name: cephfs, metadata pool: cehpfs-metadata, data pools: [cehpfs-data ]
[root@ceph-node-1 ~]# ceph auth get client.cephfs
exported keyring for client.cephfs
[client.cephfs]
        key = AQBt1QNjlAEDJRAAWFeUCwOTLRcfDuok2dvejA==
        caps mds = "allow rw"
        caps mgr = "allow rw"
        caps mon = "allow r"
        caps osd = "allow rw pool=cephfs-data, allow rw pool=cephfs-metadata"
[root@ceph-node-1 ~]# ceph auth get client.admin
exported keyring for client.admin
[client.admin]
        key = AQBAmgNjcKxwGxAANjoDA2L12Ap403+qjB4tCA==
        caps mds = "allow *"
        caps mgr = "allow *"
        caps mon = "allow *"
        caps osd = "allow *"

8月 27 22:30:44 ceph-node-1 ceph-mgr[1974609]: 2022-08-27T22:30:44.308+0800 7f6978a68700 -1 mgr.server reply reply (22) Invalid argument No handler found for 'fs subvolume metadata set'
8月 27 22:35:00 ceph-node-1 ceph-mgr[1974609]: 2022-08-27T22:35:00.376+0800 7f6979269700 -1 client.0 error registering admin socket command: (17) File exists
8月 27 22:35:00 ceph-node-1 ceph-mgr[1974609]: 2022-08-27T22:35:00.376+0800 7f6979269700 -1 client.0 error registering admin socket command: (17) File exists
8月 27 22:35:00 ceph-node-1 ceph-mgr[1974609]: 2022-08-27T22:35:00.376+0800 7f6979269700 -1 client.0 error registering admin socket command: (17) File exists
8月 27 22:35:00 ceph-node-1 ceph-mgr[1974609]: 2022-08-27T22:35:00.376+0800 7f6979269700 -1 client.0 error registering admin socket command: (17) File exists
8月 27 22:35:00 ceph-node-1 ceph-mgr[1974609]: 2022-08-27T22:35:00.376+0800 7f6979269700 -1 client.0 error registering admin socket command: (17) File exists
8月 27 22:35:00 ceph-node-1 ceph-mgr[1974609]: 2022-08-27T22:35:00.497+0800 7f6978a68700 -1 mgr.server reply reply (22) Invalid argument No handler found for 'fs subvolume metadata set'
8月 27 22:40:00 ceph-node-1 ceph-mgr[1974609]: 2022-08-27T22:40:00.553+0800 7f6979269700 -1 client.0 error registering admin socket command: (17) File exists
8月 27 22:40:00 ceph-node-1 ceph-mgr[1974609]: 2022-08-27T22:40:00.553+0800 7f6979269700 -1 client.0 error registering admin socket command: (17) File exists
8月 27 22:40:00 ceph-node-1 ceph-mgr[1974609]: 2022-08-27T22:40:00.553+0800 7f6979269700 -1 client.0 error registering admin socket command: (17) File exists
8月 27 22:40:00 ceph-node-1 ceph-mgr[1974609]: 2022-08-27T22:40:00.553+0800 7f6979269700 -1 client.0 error registering admin socket command: (17) File exists
8月 27 22:40:00 ceph-node-1 ceph-mgr[1974609]: 2022-08-27T22:40:00.553+0800 7f6979269700 -1 client.0 error registering admin socket command: (17) File exists
8月 27 22:40:00 ceph-node-1 ceph-mgr[1974609]: 2022-08-27T22:40:00.646+0800 7f6978a68700 -1 mgr.server reply reply (22) Invalid argument No handler found for 'fs subvolume metadata set'
8月 27 22:41:02 ceph-node-1 ceph-mgr[1974609]: 2022-08-27T22:41:02.648+0800 7f6978a68700 -1 mgr.server reply reply (22) Invalid argument No handler found for 'fs subvolume metadata set'
8月 27 22:45:00 ceph-node-1 ceph-mgr[1974609]: 2022-08-27T22:45:00.701+0800 7f6979269700 -1 client.0 error registering admin socket command: (17) File exists
8月 27 22:45:00 ceph-node-1 ceph-mgr[1974609]: 2022-08-27T22:45:00.701+0800 7f6979269700 -1 client.0 error registering admin socket command: (17) File exists
8月 27 22:45:00 ceph-node-1 ceph-mgr[1974609]: 2022-08-27T22:45:00.701+0800 7f6979269700 -1 client.0 error registering admin socket command: (17) File exists
8月 27 22:45:00 ceph-node-1 ceph-mgr[1974609]: 2022-08-27T22:45:00.701+0800 7f6979269700 -1 client.0 error registering admin socket command: (17) File exists
8月 27 22:45:00 ceph-node-1 ceph-mgr[1974609]: 2022-08-27T22:45:00.701+0800 7f6979269700 -1 client.0 error registering admin socket command: (17) File exists
8月 27 22:45:00 ceph-node-1 ceph-mgr[1974609]: 2022-08-27T22:45:00.843+0800 7f6978a68700 -1 mgr.server reply reply (22) Invalid argument No handler found for 'fs subvolume metadata set'
8月 27 22:47:08 ceph-node-1 systemd[1]: [/usr/lib/systemd/system/ceph-mgr@.service:15] Unknown lvalue 'LockPersonality' in section 'Service'
8月 27 22:47:08 ceph-node-1 systemd[1]: [/usr/lib/systemd/system/ceph-mgr@.service:18] Unknown lvalue 'MemoryDenyWriteExecute' in section 'Service'
8月 27 22:47:08 ceph-node-1 systemd[1]: [/usr/lib/systemd/system/ceph-mgr@.service:21] Unknown lvalue 'ProtectControlGroups' in section 'Service'
8月 27 22:47:08 ceph-node-1 systemd[1]: [/usr/lib/systemd/system/ceph-mgr@.service:23] Unknown lvalue 'ProtectKernelModules' in section 'Service'
8月 27 22:47:08 ceph-node-1 systemd[1]: [/usr/lib/systemd/system/ceph-mgr@.service:24] Unknown lvalue 'ProtectKernelTunables' in section 'Service'
8月 27 22:50:00 ceph-node-1 ceph-mgr[1974609]: 2022-08-27T22:50:00.924+0800 7f6979269700 -1 client.0 error registering admin socket command: (17) File exists
8月 27 22:50:00 ceph-node-1 ceph-mgr[1974609]: 2022-08-27T22:50:00.924+0800 7f6979269700 -1 client.0 error registering admin socket command: (17) File exists
8月 27 22:50:00 ceph-node-1 ceph-mgr[1974609]: 2022-08-27T22:50:00.924+0800 7f6979269700 -1 client.0 error registering admin socket command: (17) File exists
8月 27 22:50:00 ceph-node-1 ceph-mgr[1974609]: 2022-08-27T22:50:00.924+0800 7f6979269700 -1 client.0 error registering admin socket command: (17) File exists
8月 27 22:50:00 ceph-node-1 ceph-mgr[1974609]: 2022-08-27T22:50:00.924+0800 7f6979269700 -1 client.0 error registering admin socket command: (17) File exists
8月 27 22:50:01 ceph-node-1 ceph-mgr[1974609]: 2022-08-27T22:50:01.017+0800 7f6978a68700 -1 mgr.server reply reply (22) Invalid argument No handler found for 'fs subvolume metadata set'
8月 27 22:55:01 ceph-node-1 ceph-mgr[1974609]: 2022-08-27T22:55:01.081+0800 7f6979269700 -1 client.0 error registering admin socket command: (17) File exists
8月 27 22:55:01 ceph-node-1 ceph-mgr[1974609]: 2022-08-27T22:55:01.081+0800 7f6979269700 -1 client.0 error registering admin socket command: (17) File exists
8月 27 22:55:01 ceph-node-1 ceph-mgr[1974609]: 2022-08-27T22:55:01.081+0800 7f6979269700 -1 client.0 error registering admin socket command: (17) File exists
8月 27 22:55:01 ceph-node-1 ceph-mgr[1974609]: 2022-08-27T22:55:01.082+0800 7f6979269700 -1 client.0 error registering admin socket command: (17) File exists
8月 27 22:55:01 ceph-node-1 ceph-mgr[1974609]: 2022-08-27T22:55:01.082+0800 7f6979269700 -1 client.0 error registering admin socket command: (17) File exists
8月 27 22:55:01 ceph-node-1 ceph-mgr[1974609]: 2022-08-27T22:55:01.162+0800 7f6978a68700 -1 mgr.server reply reply (22) Invalid argument No handler found for 'fs subvolume metadata set'
8月 27 22:56:02 ceph-node-1 ceph-mgr[1974609]: 2022-08-27T22:56:02.694+0800 7f6978a68700 -1 mgr.server reply reply (22) Invalid argument No handler found for 'fs subvolume metadata set'
8月 27 23:00:01 ceph-node-1 ceph-mgr[1974609]: 2022-08-27T23:00:01.227+0800 7f6979269700 -1 client.0 error registering admin socket command: (17) File exists
8月 27 23:00:01 ceph-node-1 ceph-mgr[1974609]: 2022-08-27T23:00:01.227+0800 7f6979269700 -1 client.0 error registering admin socket command: (17) File exists
8月 27 23:00:01 ceph-node-1 ceph-mgr[1974609]: 2022-08-27T23:00:01.227+0800 7f6979269700 -1 client.0 error registering admin socket command: (17) File exists
8月 27 23:00:01 ceph-node-1 ceph-mgr[1974609]: 2022-08-27T23:00:01.227+0800 7f6979269700 -1 client.0 error registering admin socket command: (17) File exists
8月 27 23:00:01 ceph-node-1 ceph-mgr[1974609]: 2022-08-27T23:00:01.227+0800 7f6979269700 -1 client.0 error registering admin socket command: (17) File exists
8月 27 23:00:01 ceph-node-1 ceph-mgr[1974609]: 2022-08-27T23:00:01.526+0800 7f6978a68700 -1 mgr.server reply reply (22) Invalid argument No handler found for 'fs subvolume metadata set'

I have found the problem and need to set - "--extra-create-metadata=false"

Hello, I would suggest reopening this issue since although using the --extra-create-metadata=false parameter is a good workaround it does not solve the issue. FYI, We're using a Ceph 16.2.9 cluster (Pacific) and are using CSI 3.7.1.
From what we understood looking at the Ceph source code, the fs subvolume metadata set command is not available before Ceph 17.2.3 (which also contradicts the official Ceph documentation, where the command is mentioned for the Pacific release documentation for instance).
Anyway, I feel like the experience of upgrading from CSI 3.6.0 to 3.7.x should not end up with something like the error message below when attempting to provision CephFS volumes:
failed to provision volume with StorageClass "csi-cephfs-sc": rpc error: code = Internal desc = failed to set metadata key "csi.storage.k8s.io/pv/name", value "pvc-88c7287c-f95c-4acf-bfb0-9f99197ef5af" on subvolume &{0xc000e14420 XXX_cephfs_cluster3 true 0xc000136840}: API call not implemented server-side: No handler found for 'fs subvolume metadata set'```

It looks like [this PR](https://github.com/ceph/ceph-csi/pull/3352/commits) would have help avoid this situation, but it looks like it did not work (at least for our versions) ?
And maybe https://github.com/ceph/ceph-csi/issues/3390 is related to this as well, not so sure though.

Lastly, the workaround parameter is not customizable in the CSI chart ([here](https://github.com/ceph/ceph-csi/blob/devel/deploy/rbd/kubernetes/csi-rbdplugin-provisioner.yaml#L63) and [here](https://github.com/ceph/ceph-csi/blob/devel/deploy/rbd/kubernetes/csi-rbdplugin-provisioner.yaml#L78). So we have to manually override it post release. I'm not sure that's supposed to be added as a value in the chart, but if so I'd gladly open a PR to support this.

Thanks ! :)

Hello, I would suggest reopening this issue since although using the --extra-create-metadata=false parameter is a good workaround it does not solve the issue. FYI, We're using a Ceph 16.2.9 cluster (Pacific) and are using CSI 3.7.1.
From what we understood looking at this Ceph PR and the Ceph source code, the fs subvolume metadata set command is not available before Ceph 17.2.x (which also contradicts the official Ceph documentation, where the command is mentioned for the Pacific release documentation for instance).
Anyway, I feel like the experience of upgrading from CSI 3.6.0 to 3.7.x should not end up with something like the error message below when attempting to provision CephFS volumes:
failed to provision volume with StorageClass "csi-cephfs-sc": rpc error: code = Internal desc = failed to set metadata key "csi.storage.k8s.io/pv/name", value "pvc-88c7287c-f95c-4acf-bfb0-9f99197ef5af" on subvolume &{0xc000e14420 XXX_cephfs_cluster3 true 0xc000136840}: API call not implemented server-side: No handler found for 'fs subvolume metadata set'

It looks like this PR would have help avoid this situation, but it seems like it did not work (at least for our versions) ? And maybe #3390 is related to this as well, not so sure though.

You mean you get error with 3.7.1 release also?

Lastly, the workaround parameter is not customizable in the CSI chart (here and here). So we have to manually override it post release. I'm not sure that's supposed to be added as a value in the chart, but if so I'd gladly open a PR to support this.
Thanks ! :)

This is configurable in the helm charts https://github.com/ceph/ceph-csi/blob/devel/charts/ceph-csi-cephfs/templates/provisioner-deployment.yaml#L131

opening for now, i will try to reproduce it with specified ceph version

https://github.com/ceph/ceph-csi/pull/3423 should fix the problem.

You mean you get error with 3.7.1 release also?

Yes, that's the release we experienced this issue with.

This is configurable in the helm charts https://github.com/ceph/ceph-csi/blob/devel/charts/ceph-csi-cephfs/templates/provisioner-deployment.yaml#L131

It does not seem to be the parameter we need to set to workaround the issue. We had to set --extra-create-metadata=false in order for PVC binding to succeed.

You mean you get error with 3.7.1 release also?

Yes, that's the release we experienced this issue with.

Should be fixed in next release 3.7.2 (maybe next week we will release it)

This is configurable in the helm charts https://github.com/ceph/ceph-csi/blob/devel/charts/ceph-csi-cephfs/templates/provisioner-deployment.yaml#L131

It does not seem to be the parameter we need to set to workaround the issue. We had to set --extra-create-metadata=false in order for PVC binding to succeed.

It is the right parameter to set to disable metadata operation at cephcsi.

You mean you get error with 3.7.1 release also?

Yes, that's the release we experienced this issue with.

Should be fixed in next release 3.7.2 (maybe next week we will release it)

This is configurable in the helm charts https://github.com/ceph/ceph-csi/blob/devel/charts/ceph-csi-cephfs/templates/provisioner-deployment.yaml#L131

It does not seem to be the parameter we need to set to workaround the issue. We had to set --extra-create-metadata=false in order for PVC binding to succeed.

It is the right parameter to set to disable metadata operation at cephcsi.

I'm afraid to say that release 3.7.2 and #3423 did not solve the issue for us. 😢
Unless we set provisioner.setmedata: false in the cephfs chart values, we cannot provision cephfs volumes on clusters that do not support setting cephfs volumes metadata (ie. Ceph releases prior to v17.2.x).

You mean you get error with 3.7.1 release also?

Yes, that's the release we experienced this issue with.

Should be fixed in next release 3.7.2 (maybe next week we will release it)

This is configurable in the helm charts https://github.com/ceph/ceph-csi/blob/devel/charts/ceph-csi-cephfs/templates/provisioner-deployment.yaml#L131

It does not seem to be the parameter we need to set to workaround the issue. We had to set --extra-create-metadata=false in order for PVC binding to succeed.

It is the right parameter to set to disable metadata operation at cephcsi.

I'm afraid to say that release 3.7.2 and #3423 did not solve the issue for us. cry Unless we set provisioner.setmedata: false in the cephfs chart values, we cannot provision cephfs volumes on clusters that do not support setting cephfs volumes metadata (ie. Ceph releases prior to v17.2.x).

@Bengrunt sorry to hear that but i have tested it manually see the results here https://github.com/ceph/ceph-csi/pull/3423#issue-1404509117, can you please check you have the v3.7.2 image? can you try to repull or test it on some test cluster? please provide logs and the ceph version i can retry it again with same version.

I'm so sorry, Ansible helm module is so unreliable ... So yeah, I checked and was using the 3.7.1 images... It works now.
Sorry for the noise. I'll be more careful next time.


Missing MyJFrog API Token warning when not specified

Describe the bug
When not specifying the deprecated myjfrog_api_token in the provider configuration or using JFROG_MYJFROG_API_TOKEN environment variable a warning will be printed all the time.
Sample configuration
terraform {
  required_version = ">= 1.0"
  required_providers {
    platform = {
      source  = "jfrog/platform"
      version = "1.12.0"
    }
  }
}

provider "platform" {
  url          =  <VALID URL>
  access_token = <VALID ACCESS TOKEN>
}

Requirements for and issue

[x] A description of the bug
[x] A fully functioning terraform snippet that can be copy&pasted (no outside files or ENV vars unless that's part of the issue). If this is not supplied, this issue will likely be closed without any effort expended.
[x] Your version of artifactory (you can curl it at $host/artifactory/api/system/version
[x] Your version of terraform
[x] Your version of terraform provider

Versions
Artifactory: 7.90.13
Terraform: 1.9.6
Provider: 1.12.0
Expected behavior
If this argument is deprecated why even print a warning if not used.
Additional context
N/A

@mymasse Deprecating an attribute is a multi-steps process. The first step is to mark the attribute as 'deprecated' whilst retaining all functionality. The next step is to remove functionality with next major release whilst keeping the attribute in the provider config schema. Then final step is to remove the attribute altogether in another major release.
So expect the warning message be gone in next major release.

Why should this be seen for those who aren't using that provider causing this warning?


Error: "Couldn't read NPC_22"

Hi,
I run into an error when switching on the texture option. I have the GOG version <IP_ADDRESS>.

Works for me. Steam version.

Make sure the path to the textures is set correctly in Settings.  Its complaining that it cant find an .xnb, and NPC_22.xnb should definitely be in terraria's Content/Images folder.


BGP Community test automation

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 53.102%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1729

Relevant Lines:
3256

💛  - Coveralls

Pull Request Functional Test Report for #2747 / 0f996dec7e6138dfa05c8f2a0bdbdc73e8cabd46
Virtual Devices

Device
Test
Test Documentation
Job
Raw Log

Arista cEOS

RT-7.2: BGP Policy Community Set
e09c5110
Log

Cisco 8000E

RT-7.2: BGP Policy Community Set
9be725fc
Log

Cisco XRd

RT-7.2: BGP Policy Community Set
d5b09f4d
Log

Juniper ncPTX

RT-7.2: BGP Policy Community Set
97b49b25
Log

Nokia SR Linux

RT-7.2: BGP Policy Community Set
81dd128e
Log

Openconfig Lemming

RT-7.2: BGP Policy Community Set
3952e5ed
Log

Hardware Devices

Device
Test
Test Documentation
Raw Log

Arista 7808

RT-7.2: BGP Policy Community Set

Cisco 8808

RT-7.2: BGP Policy Community Set

Juniper PTX10008

RT-7.2: BGP Policy Community Set

Nokia 7250 IXR-10e

RT-7.2: BGP Policy Community Set

Help


E2E test suite: Allow piping the logs to the terminal from browser console

The config option should be implemented via an env variable in test/e2e.env.
Ctl.Internal.Test.E2E.Feedback.Node contains code that suppresses the logs until an error is observed. addLogLine there could be conditionally replaced with Effect.Console.log

duplicate of #1439


Move metadata to ReferenceTemplate and do some cleanup

Remove extractMetadata, moving metadata into the ReferenceTemplate.
This allows moves errors that may occur with extracting the metadata
earlier in the process.
Also move error wrap into the stored error message string to simplify
generation of the error.

/cc @pixelsoccupied @AlinaSecret

/approve


Tests

Tests should be written to ensure that new code never breaks functionality.

There are now tests for the core functionality of the application


HandshakeException - TLSV1_ALERT_PROTOCOL_VERSION

Steps to Reproduce

TLS v1.3 only available from server endpoint.
HTTP graphql connect to the endpoint.

Target Platform: Android
Target OS version/browser: Android version 10
Devices: Multiple emulator devices
Logs
I/flutter ( 4779): [HandshakeException, HandshakeException: Handshake error in client (OS Error:
I/flutter ( 4779): 	TLSV1_ALERT_PROTOCOL_VERSION(tls_record.cc:586))]

Analyzing flutter_sonar_technician...
No issues found! (ran in 1.1s)

[✓] Flutter (Channel stable, v1.9.1+hotfix.6, on Linux, locale en_US.UTF-8)
    • Flutter version 1.9.1+hotfix.6 at /home/user/development/flutter
    • Framework revision 68587a0916 (8 weeks ago), 2019-09-13 19:46:58 -0700
    • Engine revision b863200c37
    • Dart version 2.5.0

[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
    • Android SDK at /home/user/Android/Sdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-29, build-tools 29.0.2
    • ANDROID_HOME = /home/user/Android/Sdk
    • Java binary at: /home/user/android-studio/jre/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405)
    • All Android licenses accepted.

[✓] Android Studio (version 3.5)
    • Android Studio at /home/user/android-studio
    • Flutter plugin version 41.0.2
    • Dart plugin version 191.8593
    • Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405)

[✓] IntelliJ IDEA Ultimate Edition (version 2019.2)
    • IntelliJ at /home/user/.local/share/JetBrains/Toolbox/apps/IDEA-U/ch-0/192.6817.14
    • Flutter plugin version 41.0.3
    • Dart plugin version 192.7402

[✓] VS Code (version 1.40.0)
    • VS Code at /usr/share/code
    • Flutter extension version 3.6.0

[✓] Connected device (1 available)
    • Android SDK built for x86 • emulator-5554 • android-x86 • Android 10 (API 29) (emulator)

• No issues found!

Hi @zulandar
I'm not sure this is a Flutter related issue according to the error logs you provided,
could you provide your flutter run --verbose
together with a minimal code sample to reproduce the problem
thank you

[ +382 ms] D/eglCodecCommon(13155): setVertexArrayObject: set vao to 0 (0) 1 0
[ +264 ms] D/EGL_emulation(13155): eglMakeCurrent: 0xeb9b75c0: ver 2 0 (tinfo 0xeba60b80)
[        ] D/eglCodecCommon(13155): setVertexArrayObject: set vao to 0 (0) 7 0
[ +170 ms] I/flutter (13155): [HandshakeException, HandshakeException: Handshake error in client (OS Error:
[        ] I/flutter (13155):   TLSV1_ALERT_PROTOCOL_VERSION(tls_record.cc:586))]
[   +9 ms] I/flutter (13155): [Handshake error in client: Undefined location]

The verbose file was to large to place in here. I can pastebin it if need be.
The dependencies;
dependencies:
  flutter:
    sdk: flutter
  graphql_flutter: ^2.0.1
  http: ^0.12.0+2

Here is the graphqlconf.dart
import "package:flutter/material.dart";
import "package:graphql_flutter/graphql_flutter.dart";

class GraphQLConfiguration {

  static HttpLink httpLink = HttpLink(
    uri: "REMOVED_FOR_SECURITY_REASONS",
  );

  ValueNotifier<GraphQLClient> client = ValueNotifier(
    GraphQLClient(
      link: httpLink,
      cache: OptimisticCache(dataIdFromObject: typenameDataIdFromObject),
    ),
  );

  GraphQLClient clientToQuery() {
    return GraphQLClient(
      cache: OptimisticCache(dataIdFromObject: typenameDataIdFromObject),
      link: httpLink,
    );
  }
}

Hi @zulandar
if you are using a 3rd party [graphql_flutter] plugin
to handle SSL certificates, please consider to open an issue to the dedicated github.
If instead you are using the 1st party http package,
please provide your flutter run --verbose,
if the output is too large you can attaching it to the post as file or link a gist
thank you

same error message when use httpclient;
var url = "https://xxx"   ; // which only support tls 1.3
var httpClient = HttpClient();
var req = await httpClient.getUrl(Uri.parse(url)).then((value) => value.close());
maybe tls 1.3 support issue


Use inherent string concatenation feature

Thank you. the repo is no longer user, its moved to collection kameshampath/kubernetes_spices


Self Signed Certs cause Atom to crash after 2nd connection attempt

The FTPS server I'm trying to connect to has a self signed cert.  If I try to connect to it, an error appears in Atom stating "Remote FTP:  Error:  self signed certificate".
If I try to connect again, the entire Atom editor crashes.
Has anyone been able to connect using a self-signed cert yet?
Thank you.

Look into #187 or the wiki (https://github.com/mgrenier/remote-ftp/wiki/Settings#usage-of-self-signed-certs) :smile:


Minor doc suggestion

Add to the build instructions in the README.md that gengetopt is required to build pandaPIengine?
Other than that, the build process was very smooth.

True! I've added the requirement to the README.md.
Thanks!


Add FlashAttention support

@sandrohanea please check this PR

Hello @Sing303 ,
Thank you for your contribution!
lgtm


Fixes for ES6 etc..

Fixed usage for ES6 imports as well added undefined variable...

Thanks for the PR, it looks like I missed this one, not sure how. I read all emails from GitHub.

@jcubic - no problem! Glad your finally seeing this. I actually got a personal gift of code just for you (my project too but) it was meant mostly for you ✌ I'll try to get around to making a gist etc soon.

@jcubic - this is not your gift but lol!
Is this useful to you or this library?

detecting BG / foreground color codes etc in ANSI and returning the results as ANSI.


Add GitHub Actions workflow for building release binaries

This adds a GitHub Actions workflow that builds Ninja release binaries for Windows, Linux, and macOS on each commit and stores them as artifacts. For published releases on GitHub, the compiled release binary archives are uploaded as assets.
Currently CMake is used instead of the Python script bootstrapping process, because it kept the steps more similar across platforms (using configure.py on Windows requires extra steps with vcvarsall.bat to make so that the MSVC compiler is found). If configure.py is preferred it should be fairly easy to switch.
Another issue that was mentioned is using the ubuntu-latest image (LTS 18.04), and wanting a binary that works with older versions of Linux. Two ideas to address this are static linking with system libraries, or switching the build to use a Docker image that has an older version of glibc and stdc++. These should also address issue #1533, which using Ubuntu 16.04 as the build image might not.

I added a trigger for pull requests that should make it show up under checks for PRs from forked repositories.
Testing it with some forks I created, the checks seem to show up as expected in the PRs when adding a new workflow. I think it's most likely just a permissions thing, since the workflow is being added in a PR from a fork without collaborator/write access to this repository.
Some of the test PRs between forks:
https://github.com/nightlark/ninja/pull/3
https://github.com/ryan-mast/ninja/pull/1

Ah I see.
Can you switch to Ubuntu 16.04? Better than nothing.
We also need to link Visual Studio's C++ runtime statically on Windows.

Mm yea, I'll see if I can get those changes made within the next couple of days.

I've merged this PR for now so that we can see the result on this repository in action.
(Thank you very much btw!)

It seems to be working for forks, based on open PRs like #1674 that have had commits since the merge.
A quick update on creating Linux binaries -- I think I've figured out how to build a binary that will take care of issue #1533 (CentOS 7 GLIBCXX symbols not found), and that should work with glibc-based Linux distros released since around 2011.

Using CentOS 6 was our solution before we ended up needing other newer support (CentOS 7 is suitable for us since the older Debian/Ubuntu releases it "jumped" over aren't supported by that project either).


Trying to replicate Helmet Webgl.

I cannot reproduce the Helmet example .
which i get this error :
Uncaught (in promise) TypeError: engine.createIblFromKtx1 is not a function
at new App (helmet.html:46:49)
at helmet.html:36:18
at taskFinished (filament.js:78:17)
at filament.js:102:9
To Reproduce
After cloning whole filament projects. i ran virtual server to view Helmet sample. helmet sample didnt have filamentjs + wasm and other resources so i copied them from the main files.

@prideout Is this a tutorial or something we need to update with the new APIs?

It looks to me like the helmet example is up to date, however the filamentjs + wasm that you're using is old, not sure where you got them from.


Add Unit Test Coverage Threshold and Badge

This PR adds the following functionality:

Checks the overall coverage against a threshold. Currently set 95% but I'll create a follow-up story
Generates a coverage badge from the pipeline for both index.md and README.md

We have so many awesome https://github.com/Boeing/config-file-validator/labels/OSS Community Contribution PR's it'd be nice to be able to see in the PR that unit test coverage has remained within the threshold
Badge can be seen in my fork: https://github.com/kehoecj/config-file-validator/tree/main#readme
Closes #23

Nice! LGTM.


Convert Node to SVG

Is is possible to convert and save a root node as SVG?

Unfortunately, it's not possible for now. However this task is not that big, so we'll try to schedule it to the one of upcoming releases.

Done! You can use SVGSerializer.serialize() method to convert Node to SVG.

Thanks !


Unify dependency versions to one file and remove workarounds

More version cleanup.
Removed runtimeconfig.template.json. It is no longer required.

Squash next time please.


unable to connect jenkins via virtualbox

Hello sir,
I have install centOS via vagrant (Oracle VM VirtualBox)
install jdk, jenkins (done with environment variable JAVA_HOME)
but when I am connecting ip address (ip a) with 8080 I am not getting connected
Started Jenkins server and set it to run at boot time
(sudo systemctl start jenkins.service)
Allow access to Jenkins via 8080 port
(sudo firewall-cmd --zone=public --permanent --add-port=8080/tcp)

in vagrantfile enable public ip and give ip address


feat(cli): generate & execute aws terraform code

Summary
Enable the automated generation & execution of Terraform code for integrating Lacework with AWS
How did you test this change?
See tests
https://github.com/ipcrm/go-sdk/blob/ipcrm/ally-392/cli/integration/aws_generation_test.go
https://github.com/ipcrm/go-sdk/blob/ipcrm/ally-392/cli/cli/cmd/generate_aws_test.go
Issue
https://lacework.atlassian.net/browse/ALLY-392
wip
documentation (wiki)

make it so

Pipeline Error:

                                Diff:
                                --- Expected
                                +++ Actual
                                @@ -22,2 +22,3 @@
                                   event          Inspect Lacework events
                                +  iac-generate   create iac code
                                   integration    Manage external integrations
                Test:           TestNoCommandProvided

Also, you need to rebase from main.

make it so

MAKE_IT_SO!

Make it so!!


Create a new branch named feature/body (based on develop)

Create a new branch named feature/body (based on develop), push it to origin - git push -u origin feature/body

Branch creation was successful.


DBZ-823 Optionally parallelize initial snapshots

@jpechane The tests are passing locally...

@ggaborg Applied, it is a known transinet failure. Thanks


Scripts to inject into shell .rc files

Still need info / docs on how to activate these, and to put them into the Homebrew formula.


version 2.0.9 filter has a major bug

If  I  not set  “numFilter” in  xml ，numFilter is  0  and  when i  set  filter  in  java  code，it's  must  crash

Fixed in 2.1.0.
Now, this is working as expected and wiki was updated too.

0 or less -> Infinite filters.
1 or more -> limited filters, app will crash if you exceed this value.

0 value to disable filters (limit to 0) has no sense because it is the same that use any value and never set a filter. Also, if you want disable filters, LightOpenGlView is a better option beacause the render is faster than OpenGlView without filters. For this reason 0 is infinity

Fixed in 2.1.0.
Now, this is working as expected and wiki was updated too.

0 or less -> Infinite filters.
1 or more -> limited filters, app will crash if you exceed this value.

0 value to disable filters (limit to 0) has no sense because it is the same that use any value and never set a filter. Also, if you want disable filters, LightOpenGlView is a better option beacause the render is faster than OpenGlView without filters. For this reason 0 is infinity

Ok，I will try thanks

Fixed in 2.1.0.
Now, this is working as expected and wiki was updated too.

0 or less -> Infinite filters.
1 or more -> limited filters, app will crash if you exceed this value.

0 value to disable filters (limit to 0) has no sense because it is the same that use any value and never set a filter. Also, if you want disable filters, LightOpenGlView is a better option beacause the render is faster than OpenGlView without filters. For this reason 0 is infinity

Ok，I will try thanks

Now，Have other bug

I  add  a  imagefilter  and then clear filter  ，and then  add  new imagefilter，and  it's  crash

This is working for me.
What are you doing exactly?
numFilters to 0 in xml, addFilter, clearFilters and addFilters?

This is working for me.
What are you doing exactly?
numFilters to 0 in xml, addFilter, clearFilters and addFilters?

Yes，i not to  set  xml  numFilters

This is working for me.
What are you doing exactly?
numFilters to 0 in xml, addFilter, clearFilters and addFilters?

Yes，i not to set xml numFilters

My business needs need to switch between a filter and no filter gas

Are you using addfilter(0, filter)?

Are you using addfilter(0, filter)? or addfilter(filter)?

Did you update app example to get last commit?
Updated gradle:
implementation 'com.github.pedroSG94.rtmp-rtsp-stream-client-java:e8c29fb570'

I checked it with last commit and it is working fine.
Did you update app example to get last commit?
Updated gradle:
implementation 'com.github.pedroSG94.rtmp-rtsp-stream-client-java:e8c29fb570'

implementation 'com.github.pedroSG94.rtmp-rtsp-stream-client-java:rtplibrary:e8c29fb570'
Depend on success now ，and  i  trying now

I checked it with last commit and it is working fine.
Did you update app example to get last commit?
Updated gradle:
implementation 'com.github.pedroSG94.rtmp-rtsp-stream-client-java:e8c29fb570'

this bug is fixed now ，but  there is a new  bug now，I think it may be related to bitmaps, but in the 2.0.8 version, bitmaps are transmitted normally。

I think that all problems should be solved now:
implementation 'com.github.pedroSG94.rtmp-rtsp-stream-client-java:38cefae298'

Please, confirm me that all is working fine to create a new release

I think that all problems should be solved now:
implementation 'com.github.pedroSG94.rtmp-rtsp-stream-client-java:38cefae298'

Please, confirm me that all is working fine to create a new release

I think that all problems should be solved now:
implementation 'com.github.pedroSG94.rtmp-rtsp-stream-client-java:38cefae298'

Please, confirm me that all is working fine to create a new release

Sorry, I took a vacation two days ago，I will try this today

I updated the 2.1.2 version. Fortunately, all the exceptions that caused the program to exit were resolved, but when I added an image filter and then deleted the image filter, the streaming failed

I can't reproduce your problem.
Do you have bitrate adapter?
Can you reproduce this error in opengl example? (I tried it with clearfilters in no filter button)

I can't reproduce your problem.
Do you have bitrate adapter?
Can you reproduce this error in opengl example? (I tried it with clearfilters in no filter button)

I think this should be caused by the creation of bitmap

It should be fine. Any way try set filter size to full stream size:
val bitmap = createBitmap(
      ...
    )
    imageObjectFilterRender.setImage(bitmap)
    //100% width, 100% height (full preview size and full stream size)
    imageObjectFilterRender.setScale(100f, 100f)
    imageObjectFilterRender.setPosition(TranslateTo.CENTER)
    rtmpCamera2.glInterface.setFilter(imageObjectFilterRender)

Also, since you are using an Android view you can use this filter:
//This filter update automatically if you change layout externally.
// For example: if you change a button color, you can see that change on fly.
AndroidViewFilterRender androidViewFilterRender = new AndroidViewFilterRender();
androidViewFilterRender.setView(view);
androidViewFilterRender.setScale(100f, 100f);
androidViewFilterRender.setPosition(TranslateTo.CENTER);

Anyway, if possible share me layout content (with necessary resources) to emulate your case.

It should be fine. Anyway try set filter size to full stream size instead of setdefaultscale:
val bitmap = createBitmap(
      ...
    )
    imageObjectFilterRender.setImage(bitmap)
    //100% width, 100% height (full preview size and full stream size)
    imageObjectFilterRender.setScale(100f, 100f)
    imageObjectFilterRender.setPosition(TranslateTo.CENTER)
    rtmpCamera2.glInterface.setFilter(imageObjectFilterRender)

Also, since you are using an Android view you can use this filter:
//This filter update automatically if you change layout externally.
// For example: if you change a button color, you can see that change on fly.
AndroidViewFilterRender androidViewFilterRender = new AndroidViewFilterRender();
androidViewFilterRender.setView(view);
androidViewFilterRender.setScale(100f, 100f);
androidViewFilterRender.setPosition(TranslateTo.CENTER);

Anyway, if possible share me layout content (with necessary resources) to emulate your case.

<LinearLayout
    android:layout_width="wrap_content"
    android:layout_height="wrap_content"
    android:layout_gravity="center"
    android:orientation="vertical">

    <androidx.appcompat.widget.AppCompatImageView
        android:id="@+id/iv_pause_empty"
        android:layout_width="wrap_content"
        android:layout_height="wrap_content"
        android:layout_gravity="center_horizontal"
        android:src="@drawable/ic_live_pause" />

    <androidx.appcompat.widget.AppCompatTextView
        android:layout_width="wrap_content"
        android:layout_height="wrap_content"
        android:layout_gravity="center_horizontal"
        android:layout_marginTop="16dp"
        android:text="@string/live_pause_desc"
        android:textColor="@color/colorTextSecondary"
        android:textSize="12sp" />

</LinearLayout>

this  is  my  layout content

private fun setImageToStream() {
val imageObjectFilterRender = ImageObjectFilterRender()
    val view = layoutInflater.inflate(R.layout.layout_stop_live, null, false)
    val bitmap = createBitmap(
        view,
        ScreenUtils.getScreenWidth(this),
        ScreenUtils.getScreenHeight(this)
    )
    imageObjectFilterRender.setImage(
        bitmap
    )
     imageObjectFilterRender.setDefaultScale(
         ScreenUtils.getScreenWidth(this),
         ScreenUtils.getScreenHeight(this)
     )
    imageObjectFilterRender.setPosition(TranslateTo.CENTER)
    rtmpCamera2?.glInterface!!.setFilter(imageObjectFilterRender)

}

private fun createBitmap(v: View, width: Int, height: Int): Bitmap? {
    val measuredWidth = View.MeasureSpec.makeMeasureSpec(width, View.MeasureSpec.EXACTLY)
    val measuredHeight = View.MeasureSpec.makeMeasureSpec(height, View.MeasureSpec.EXACTLY)
    v.measure(measuredWidth, measuredHeight)
    v.layout(
        0,
        0,
        v.measuredWidth,
        v.measuredHeight
    )
    val bmp = Bitmap.createBitmap(
        v.width,
        v.height,
        Bitmap.Config.ARGB_8888
    )
    val c = Canvas(bmp)
    c.drawColor(Color.WHITE)
    v.draw(c)
    return bmp
}

And  this  is  my  kotlin  code  。just  createBitmap  and  setFilter

I can' reproduce it.
I did my own filters based in your files:

A class to create image filter (I replaced ScreenUtil with other way to get screen size  because I haven't dependencie):

class Test {

  fun setFilter(stream: RtmpCamera2, activity: Activity) {
   val imageObjectFilterRender = ImageObjectFilterRender()
    val view = activity.layoutInflater.inflate(R.layout.layout_stop_live, null, false)
    val displayMetrics = DisplayMetrics()
    activity.windowManager.defaultDisplay.getMetrics(displayMetrics)
    val height = displayMetrics.heightPixels
    val width = displayMetrics.widthPixels

    val bitmap = createBitmap(view, width, height)
    imageObjectFilterRender.setImage(bitmap)
    imageObjectFilterRender.setDefaultScale(width, height)
    imageObjectFilterRender.setPosition(TranslateTo.CENTER)
    stream.glInterface!!.setFilter(imageObjectFilterRender)
  }

  private fun createBitmap(v: View, width: Int, height: Int): Bitmap? {
    val measuredWidth = View.MeasureSpec.makeMeasureSpec(width, View.MeasureSpec.EXACTLY)
    val measuredHeight = View.MeasureSpec.makeMeasureSpec(height, View.MeasureSpec.EXACTLY)
    v.measure(measuredWidth, measuredHeight)
    v.layout(
      0,
      0,
      v.measuredWidth,
      v.measuredHeight
    )
    val bmp = Bitmap.createBitmap(
      v.width,
      v.height,
      Bitmap.Config.ARGB_8888
    )
    val c = Canvas(bmp)
    c.drawColor(Color.WHITE)
    v.draw(c)
    return bmp
  }
}

Layout (I changed image icon and textview text and text color):

<?xml version="1.0" encoding="utf-8"?>
<LinearLayout
    xmlns:android="http://schemas.android.com/apk/res/android"
    android:layout_width="wrap_content"
    android:layout_height="wrap_content"
    android:layout_gravity="center"
    android:orientation="vertical">

    <androidx.appcompat.widget.AppCompatImageView
        android:layout_width="wrap_content"
        android:layout_height="wrap_content"
        android:layout_gravity="center_horizontal"
        android:src="@drawable/icon_camera" />

    <androidx.appcompat.widget.AppCompatTextView
        android:layout_width="wrap_content"
        android:layout_height="wrap_content"
        android:layout_gravity="center_horizontal"
        android:layout_marginTop="16dp"
        android:text="Live"
        android:textSize="12sp" />

</LinearLayout>

In OpenGlRtmpActivity:

Replace setImageToStream method to:

    new Test().setFilter(rtmpCamera2, this);

Use clearFilter to remove image in noFilter menu button.
Replace RtmpCamera1 to RtmpCamera2

Can you compile my app example and check it?
A PR, fork project and share me a link or something where I can compile an apk with the issue could be really helpfull

What do you mean? I don't understand.
Can you reproduce error using that code? I can create a branch with my code and we can work in that branch to reproduce the error.

What do you mean? I don't understand.
Can you reproduce error using that code? I can create a branch with my code and we can work in that branch to reproduce the error.

I am not describing the previous problem, I just want to set a fixed resolution (such as 19201080) when streaming, but not all mobile phones have a resolution of 19201080. What can I do to make all phones preview in full screen

Full screen image filter no matter screen resolution because it is wokring in percent:
imageObjectFilterRender.setScale(100f, 100f);

Full screen image filter no matter screen resolution because it is wokring in percent:
imageObjectFilterRender.setScale(100f, 100f);

I mean  when I don’t add any filters and the resolution of the stream transmission is less than the screen resolution, how do I set it to distort the picture in the full screen state?

Obviously, the picture is distorted

Ah ok.
If you want full screen without distortion in preview you can use aspect ratio mode fill:
<com.pedro.rtplibrary.view.OpenGlView
      android:layout_width="match_parent"
      android:layout_height="match_parent"
      android:id="@+id/surfaceView"
      app:keepAspectRatio="true"
      app:aspectRatioMode="fill"
      app:AAEnabled="false"
      app:numFilters="1"
      app:isFlipHorizontal="false"
      app:isFlipVertical="false"
      />

adjust: Adapt to preview size doing black borders to avoid distortion.
fill: Full preview size cropping borders to adapt screen resolution and avoid distortion.

This have no effect to stream result, this is only for preview

Ok, all problems are solved, thank you very much


[Bug]: Linux desktop client keeps creating autostart file for Electron

Checks before filing an issue

[X] This issue doesn't reproduce on web browsers (such as in Chrome). If it does, issue reports go to the Mattermost Server repository.
[X] I have checked the issue tracker and have not found an issue that matches the one I'm filing.
[X] This issue is not a troubleshooting question. Troubleshooting questions go here: https://forum.mattermost.com/c/trouble-shoot/16.
[X] This issue is not a feature request. You can request features and make product suggestions here: https://mattermost.com/suggestions/.
[X] This issue reproduces on the most recent stable version, or the most recent prerelease version of the Mattermost Desktop App.
[X] I have read the contribution guidelines.

Mattermost Desktop Version
5.7.0
Operating System
ArchLinux
Mattermost Server Version
9.7.2
Steps to reproduce
Install the mattermost-desktop package from ArchLinux official repositories, start the app, configure a server, close and restart.
Expected behavior
No  ~/.config/autostart/electron.desktop file should be present.
Observed behavior
A  ~/.config/autostart/electron.desktop has been created, autostarting an Electron instance at every login to the desktop environment (Plasma Wayland in my case).
Log Output
[2024-05-08 09:59:16.566] [error] Logger Log level set to: info
[2024-05-08 09:59:16.681] [warn]  [App.Initialize] Current working directory is /home/mori, changing into /usr/lib/electron28
[2024-05-08 09:59:16.744] [info]  [App.Initialize] Autoupgrade disabled: false
[2024-05-08 09:59:16.784] [info]  [ServerDropdownView] init
[2024-05-08 09:59:16.792] [warn]  [i18nManager] Failed to set new language en-US
[2024-05-08 09:59:16.792] [warn]  [i18nManager] Failed to set new language IT
[2024-05-08 09:59:16.852] [info]  [App.Config] config.autostart has been configured: true
[2024-05-08 09:59:16.853] [info]  [App.Config] config.autostart has been configured: true
[2024-05-08 09:59:17.268] [info]  [App.Config] config.autostart has been configured: true

Additional Information
The  ~/.config/autostart/electron.desktop file is created at every start of the Mattermost desktop client, so deleting it is not effective. Deleting it, touching it, and then making it non-writable with e.g. sudo chattr +i ~/.config/autostart/electron.desktop then the client crashes at startup with this message:
Application: Mattermost 5.7.0 [commit: 5.7.0
]
Platform: Linux 6.8.9-arch1-1 x64
Error: EPERM: operation not permitted, open '/home/mori/.config/autostart/electron.desktop'

@nicolamori Can you post a screenshot of the "vanilla" Electron window you're seeing?

@devinbinnie Here it is:

And this is the .desktop file created at Mattermost start:
[Desktop Entry]
Type=Application
Version=1.0
Name=electron
Comment=electronstartup script
Exec=/usr/lib/electron28/electron
StartupNotify=false
Terminal=false

@nicolamori Huh, that seems really odd. Have you ever spun up Electron for development purposes in the past? How did you install Mattermost? (AppImage, Snap, from our APT repo, using the .tar.gz)

@devinbinnie I've no development record with Electron. The only thing that comes to my mind related to development is that if I remember correctly in Archlinux this bug was hit and now the mattermost-desktop executable is this shell script:
#!/bin/sh
exec electron28 /usr/lib/mattermost-desktop/app.asar --disable-dev-mode "$@"

That's probably what's doing it. If I recall correctly the desktop file is created using the executable name, so if it's supposed to be just run vanilla Electron with the ASAR it's probably creating a file using that executable. I think if you modify the desktop file to use the extra arguments it should work fine.

That makes sense, if I correctly understood what's happening under the hood. Anyway it's a buggy behavior and requiring the user intervention for such a basic functionality doesn't feel right. I'll check with the ArchLinux packager if it's possible to fix this at distribution level.

Thank you, unfortunately this is something that package is doing, which we don't currently maintain ourselves.
Closing this issue as-is for now.


Replace Axios by Fetch API

Is your feature request related to a problem? Please describe.
Currently, we use Axios for rather simple HTTP requests that the Fetch API can also perform.
Describe the solution you’d like
Axios is no longer used in the project. The Fetch API is used instead.
Describe alternatives you’ve considered
Continue using Axios.

Error handling is much better with Axios. Will stick with it for the time being.

Maybe I will come back here some day: https://kentcdodds.com/blog/replace-axios-with-a-simple-custom-fetch-wrapper


DOC: Document MSVC versions

Document which MSVC is used for the official binary builds of python.

LGTM

See also http://mingwpy.github.io/issues.html#choice-of-msvc-runtime

@grlee77 I don't think this war merged?

whoops! sorry about that.


Added python aliases for face predict overloaded functions

fixes #512
Added aliases predict_label and predict_collect for python bindings.

:+1:

Hi, i try to use PredictCollector:
recognizer = cv2.face.createLBPHFaceRecognizer()
collect = cv2.face.PredictCollector()
recognizer.predict_collect(predict_image, collect)
but i get an error:
Traceback (most recent call last):
  File "faces.py", line 62, in <module>
    collect = cv2.face.PredictCollector()
AttributeError: 'module' object has no attribute 'PredictCollector'
I can't figure out what I'm doing wrong? i use python 2.7, opencv 3.1.0 master branch

@SashaPilinovich , Python bindings do not have access to C++ constructors, you should call static factory method instead:
collect = cv2.face.StandardCollector_create()

@mshabunin, thanks, now it works. If I'm not mistaken, i must use getResults, because getResultsMap not working:
callect.getResults()
i get some array, in this arrays i don't see pairs (pair of label and distance) and i can't  understand how to parse this array. There is some methods to work with pairs?

@SashaPilinovich , isn't it a list of tuples?
for label, distance in collect.getResults():
    print("%s -> %s" % (label, distance))

@mshabunin, it is not work, i get an error:
for label, distance in collect.getResults():
    ValueError: need more than 1 value to unpack
if i write like this:
for label in collect.getResults():
    print("%s " % (label))
i get a lot of numbers like:
       ...
<PHONE_NUMBER>184395691<PHONE_NUMBER>566912598<PHONE_NUMBER>546165289
<PHONE_NUMBER>99945266<PHONE_NUMBER>05136134<PHONE_NUMBER>488506897
<PHONE_NUMBER>055211562<PHONE_NUMBER>245932824<PHONE_NUMBER>7576181829
       ...
there is no pairs

@SashaPilinovich , looks like vector<pair<>> return type is not correctly supported in Python bindings. Please check https://github.com/Itseez/opencv/pull/6547 , it adds required methods.

@mshabunin, thanks, now it's work


merge package template from arlac77/npm-package-template

package.json

chore(devDependencies): update<EMAIL_ADDRESS>from template

Coverage remained the same at 15.294% when pulling 64de7a97f62d1f654dd9d7418165365a449cffb0 on template-sync-1 into 1053af660d1f645b29b0e56a34c83d3dc4473bc5 on master.

Coverage remained the same at 15.294% when pulling 64de7a97f62d1f654dd9d7418165365a449cffb0 on template-sync-1 into 1053af660d1f645b29b0e56a34c83d3dc4473bc5 on master.


Loosing connection via docker proxy

Hey there,
from time to time the addon looses connection
ERROR (Thread-3) [custom_components.monitor_docker.helpers] [Docker] hassio_observer: Container not available anymore (3) (DockerError(900, 'Cannot connect to Docker Engine via tcp://<IP_ADDRESS>:2375 [Server disconnected]'))
docker -H tcp://<IP_ADDRESS>:2375 ps
gives me data back so there is a connection
How can i solve this?
greetz

This should hopefully be fixed in '1.14-beta3', can you try that version?

i'll try it out

Up until now the connection persists. There is a log error at night saying there is no connection (which bothers me a bit ^^) but the data is there

Works great but also spams the logs as error. Any plans to remove them?

Technically it is not a monitor_docker problem, because the proxy closes the connection and we do a re-establish. I will check if we can introduce an ignore option (something like if you enable it, it does not log anything in any situation).

I configured log level via HA config. That works good

I will close this one, if it persist, please raise a new ticket.


No sound

Hello,
irst of all, thnaks a lot for your work, it helps a lot !
I adapted this demo for our own videochat needs, but I can't get the sound to work.
 So I would be grateful for any tip or advice !
Best,
Quentin

Just wanting to acknowledge that I saw this, I'll take a closer look at this later today.
I am seeing The application should use MODE_IN_COMMUNICATION audio mode! but I doubt that will fix things.
I have a getting started tutorial, specifically I would point you to the Gathering Video and Audio Resources section. If everything there looks good, I would suggest you run AndroidRTC without modifications to make sure that the audio works for you. Just tested it and it still works for me, but perhaps it is an issue that varies by the phone.
Let me know!

Thank you for your prompt reply !
Regarding the MODE_IN_COMMUNICATION, do you know how to set it ?
I did read the tutorial and used the AndroidRTC example as a starting point for my application, but I'll try with the unmodified version of it. I'll have to tweak the SDK versions a bit, as I'm testing with older androids (4.1 and 4.3). Maybe that's one source of issue ?
I'll let you know !

Hello,
Unconclusive report here :
I tried AndroidRTC with two 4.3 devices. The only modification I did was to add an if (this.localVideoSource != null) to avoid an NPE in VideoChat::onResume. The call are stuck in the "connecting" phase (even though the other device does display the green and red buttons when the first device calls). The messages don't go through...
What's weird is that I do manage to have video call with the AndroidRTC code I merged into my application... So now I'm even more puzzled ;)
Any hint or advice ?

Hi Kevin,
I am having the same issue, I tried to run your example code from this repository, and I tried it on three different devices, connecting to the web app, so I receive sound on my laptop but on the devices there is no sound. I tried calling from the device, and from the web. The devices that I am using are, ASUS MeMO Pad 10 (ME103K), Nexus 7 2012 and Nexus 4.
Any help will be appreciated.
Thanks!

Hi Kevin,
I wondered if you had to time to look at this issue ? I also managed to make the sample code work in one way, and I could backport this into my app. So now the application on one device (a tablet) sends sound to the application on another device (a phone), but not in the other direction... Any idea what could cause this ?
Thanks,

Sorry everyone, I've been looking into this and it has been a relatively difficult issue to pinpoint. XirSys, a WebRTC server hosting company posted some of the Common WebRTC problems. Says one issue is "No hardware / driver support. WebRTC in Android isn't enabled for all devices." However some issues can probably be fixed by using XirSys Servers. The updated AndroidRTC has code showing how to use XirSys servers. See here for the server code. Hoping that's not the case with the issues on this page.
Once you have that class, we can create a function that gathers ICE Servers as follows.
 public List<PeerConnection.IceServer> getXirSysIceServers(){
    List<PeerConnection.IceServer> servers = new ArrayList<PeerConnection.IceServer>();
    try {
        servers = new XirSysRequest().execute().get();
    } catch (InterruptedException e){
        e.printStackTrace();
    } catch (ExecutionException e){
       e.printStackTrace();
    }
    return servers;
}

Now when we place our call in VideoChatActivity we can provide servers to our PnSignalingParams as follows:
List<PeerConnection.IceServer> servers = getXirSysIceServers();
if (!servers.isEmpty()){
    this.pnRTCClient.setSignalParams(new PnSignalingParams(servers));
}

I will add this all to the tutorial in the near future. Hope some of this helps.
Also thanks @qbonnard, what did you change to get audio going from tablet to phone?

Hello,
This project and your tutorial was well done, I created my own app using the guide. However I am also having the problem of the Caller cannot hear the Callee's audio but the Callee can hear the Caller. Other than that it works well, I have asked on Stack overflow and will provide the link below. Just posting here incase anyone has solved this problem or has insight as to why this situation would happen
http://stackoverflow.com/questions/36611968/video-chat-with-webrtc-on-android-using-pubnubs-sdk-and-api

pcConstraints.mandatory.add(new MediaConstraints.KeyValuePair("OfferToReceiveAudio", "true"));

#14
Should fix the issue. For now you will have to clone the repo and add it to your project. Will rebuild artifacts for the gradle distribution shortly.


iOS Teams App Propagation and weird Android Behavior

I was asked by internal Microsoft Teams Engineering PM to open an issue here in hopes of getting to the bottom. Thnk you in advance.
What we did

We developed a custom teams app using fluent ui, react.js components using most from https://www.npmjs.com/package/@fluentui/react-components and some from https://www.npmjs.com/package/@fluentui/react-northstar.

The teams app was not deployed to Microsoft Store as we're in the early stages of development. What we do instead is create a setup policy, upload the app and watch the users get the app installed as it propagates. We followed the documentation from https://learn.microsoft.com/en-us/microsoftteams/teams-app-setup-policies

The app uses the bot framework and [proactive messages](https://learn.microsoft.com/en-us/microsoftteams/platform/bots/how-to/conversations/send-proactive-messages?tabs=dotnet) to start a conversation

Upon installation and happy path scenario, when the app is first installed, it sends a welcome message. Users see it in the native Teams Chat Notification as well as under our app. If they click on the chat, they're taken to our app. This works fine for most users

On a daily basis, the user receives 2 proactive messages from us (basically something for them to work on). We work with various companies to deliver bite-sized business objectives, hence, the daily messages. Each proactive message sends an adaptive card with a button that they click on to commit to each daily activity. Note: I can add you to our demo environment if you want to try it out. No information is needed besides your email but the app does require certain permissions within the tenant to operate properly. Just let me know if you want to try and replicate. I can remove once we're done troubleshooting.

What the issues are
We have 2 issues that we're dealing with:

When we create the aforementioned linked setup policy above, it actually works quite well and both windows and mac users see the app installed over time on their desktop Teams app. Great! However, iOS users (iPhone and iPad) never do. At first we thought more time was needed but nothing ever happened. We then tried it on a completely different tenant. We have an ex Microsoft employee working with us and he had a tenant he's using for himself for many years now. He tried it there as well and exactly the same issue occurs. As you can imagine, we're at a point where we tell companies, sorry, this only works for desktop users. Android users seem ok with this issue. There are no screenshots to provide as the issue is about propagation of the app itself.

The second issue has to do with Android users. Now, they do get the app installed and they do get proactive messages sent to them. As I mentioned above, upon receiving a proactive message in the Teams native Chat tab on Android, a completely new behavior appears. For all others, upon clicking on our message, they're taken to our app. On Android, though, they see 2 tabs within the native Chat tab on Teams. When clicking on More, an error occurs. We have no idea why this appeared. We never designed it, as our application has our own tabs and nothing to do with More. See below.

Screenshot can be seen here
What we tried
Contacted Support. After 3 weeks, we were told sorry, we do not support custom teams development. We said, the issue is not with our app, the issues are propagation and a weird Android tab. They told us nothing they can do and closed the cases.
We are at a mercy of your team and hope we can figure this out.

Hello @gsogol - Thanks for reporting your issue.
We will investigate your issue and let you know the updates.

@gsogol, Could you please add<EMAIL_ADDRESS>to your demo environment to repro the issue.

Yes, added.

The person will receive 2 proactive messages daily to test the Android issue we are seeing. That's the one where a mysterious More tab shows up and upon clicking it, gives us an error. Clicking on the chat message, also does not take us to the app.
The other issue with iOS where the app does not get installed during propagation via setup policy, you can try that yourself in your tenant. I am wondering if somehow something needs to be enabled on your end. This talks about connecting some Apple ID

https://learn.microsoft.com/en-us/microsoftteams/platform/concepts/deploy-and-publish/appsource/prepare/update-apple-store-team-connect-id
but I'm unsure. We are not publishing to the teams store. We are uploading manually to each org. But feels like something was not enabled or some missing step that is not part of docs

The app zip file can be found here

@gsogol:

"More" Tab apps are showing error "something went wrong" in mobile. We see it as product bug and reported the same to product group.
We see it as issue with values given in manifest.
Observed issue with bot commands. Commands are given empty in manifest. If we remove commandLists section from manifest, app is showing in iOS.
"commandLists": [
{
"scopes": ["personal", "team", "groupchat"],
"commands": []
}
]
So, if commands are not required, please remove the respective section from manifest to fix the issue.

Hope it helps?

Thank you so much.

so you will let us know when this is fixed?
we will try this tomorrow and report back! 🙌

Update. The iOS propagation now works when removing the empty commandLists from manifest.
Remaining issue is the mysterious More tab and a proactive message click within the native Chat does not take you to the app unlike on other devices.

@SubbaReddi @Nivedipa-MSFT @ChetanSharma-msft   could you confirm that the Android issue is being looked at? Forgive my uneasiness, we need to roll it out to many users and many users Android so we just want to know that it's being looked at. Thank you as always.

@gsogol : In Teams tab/bot application we observed extra 'More' tab and on click of it gives us an error. "Something went wrong". If you are referring to the same issue, we reported as bug to product team. And it may take time to get the fix ETA.

Hello @gsogol - Currently we don't have exact ETA to share but we are actively checking the updates with engineering team and let you know once it is resolved.

Hello @gsogol, we haven't received any proactive messages after installing your app manifest so could not repro the below issue. Could you please help us to repro the same.

Yes of course. Could you provide me your email addresses? Assuming we are testing the Android issue

<EMAIL_ADDRESS>this is my test user id.

@sagar-malpure  we already added this user over the weekend. The idea is to validate via the Android phone using the app. We see you're using and clicking via chrome browser.

@sagar-malpure just making sure you were able to recreate the issue and getting what you need. If a call is easier, we can do that too to speed up the process.

@gsogol Could you please let us know your availability? so that we can schedule a meeting to look into this further.

Any day, any time from 7am to midnight est timezone<EMAIL_ADDRESS>


Create a .yaml file with kubeflow version

Fixes for https://issues.redhat.com/browse/RHOAIENG-12524
Collaborated with @andyatmiami
Created a .yaml file with kubeflow version with automated doc

Is it intentional for opening PR in this repo and not in https://github.com/opendatahub-io/kubeflow? can you please share the reasoning

No I think I opened it to this Repo because its the one I had forked. I can reopen it on the other repo

No I think I opened it to this Repo because its the one I had forked. I can reopen it on the other repo

yes please, can you open in opendatahub repo.


Add favicon to site

Acceptance criteria

[ ] There exists a favicon for the site

@hannahouazzane thought it might be a nice touch to have a favicon for the website. @rachelpeharding might have a version of the logo suitable for that.


VSL-80: Propose & Execute actions can be only done by signers

Extended Action to include proposer
Updated actions to require signature in order to verify that the signer of the treasury can propose and execute actions
Updated all transactions to require additional parameters in order to verify the signer
Updated the UI to work with these changes
Updated the tests that cover the updated transactions

Since 'useTreasury' hook is a dependency of the Web3Context, bringing web3 as an argument to the api functions defined in useTreasury could be problematic.
Consider moving the createSignature function from the util to the web3 context to utilize the context within, that way we can also avoid passing web3 (which is a big object) through multiple functions.

Contracts look good to me but we should hold off on merging until we can deploy the updated contracts (which we may need to rename)

Looks like there's a conflict caused by the modal refactor pr, sendTokens.js is safe to remove 👍


Fix rename tag not changing tags within items

Fixes: https://github.com/AY2223S1-CS2103T-W16-2/tp/issues/293
Note:
https://nus-cs2103-ay2223s1.github.io/website/se-book-adapted/chapters/principles.html#law-of-demeter
This may look like it is voiding the law of demeter. However, I argue otherwise. For the current implementation of item, all fields should be immutable. Despite the tagset being final. We can still mutate it. I have converted item to be immutable now. This will reduce bugs in future.
It looks like it is voiding the LOD. However, it is actually not as a new tagset is always being created.

Whenever we get a tag set we now only get back a copy :D

Codecov Report

Merging #296 (77638a3) into master (5717dda) will decrease coverage by 0.34%.
The diff coverage is 77.77%.

@@             Coverage Diff              @@
##             master     #296      +/-   ##
============================================
- Coverage     78.06%   77.71%   -0.35%
+ Complexity      691      687       -4
============================================
  Files           117      117
  Lines          2074     2087      +13
  Branches        223      234      +11
============================================
+ Hits           1619     1622       +3
- Misses          367      370       +3
- Partials         88       95       +7

Impacted Files
Coverage Δ

src/main/java/seedu/foodrem/model/item/Item.java
73.91% <71.42%> (-9.43%)
:arrow_down:

src/main/java/seedu/foodrem/model/FoodRem.java
87.50% <76.47%> (-5.84%)
:arrow_down:

...foodrem/logic/commands/tagcommands/TagCommand.java
95.83% <100.00%> (+4.92%)
:arrow_up:

...odrem/logic/commands/tagcommands/UntagCommand.java
95.83% <100.00%> (+0.37%)
:arrow_up:

...rc/main/java/seedu/foodrem/model/ModelManager.java
92.75% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Openshift resource group should contain a random name

This will help to prevent the build failing if an existing resource group with the same name already exists. A good random name would be the cluster id.

A possible naming convention for this resource group would be,
${NAME_PREFIX}-aro-${CLUSTER_ID}-rg


Update TableImport.cs - CommandTimeout increased to 120s

CommandTimeout increased to 120s
https://github.com/TabularEditor/TabularEditor/issues/1115

Thanks for this contribution. I've modified it slightly, so that we set the CommandTimeout based on the value of the "Timeout" property on the provider data source (this is also what SSAS would do internally when processing data):

See https://github.com/TabularEditor/TabularEditor/pull/1152


Request - 'Continue where the user left off' feature

Hello,
Thank you for the great tool. I have been using it for a while now, and it's a total delight to use.
Saving and loading collections works great, but I have a suggestion to make it easier to resume work instantly: I believe that adding something similar to chrome or VS Code's 'continue where you left off' feature would be awesome.

Please let me know if you would like me to take a stab at it.

@yagasoft I am not familiar with the functionality, probably I can replicate the behavior you described using the localStorage (so the current state is always saved there and when the page is loaded it checks if an entry exists there).
If you have suggestions on how this can be added to DRB let me know

@GuidoPreite
Indeed, that is what I had in mind exactly.
Periodically, say every 5 seconds, invoke the 'save' functionality but don't pop up the 'save file' dialogue. Instead, save the JSON directly to localStorage.
On load, check the localStorage for the JSON. If found, invoke the 'load' function but don't pop up the 'load file' dialogue. Instead, load the JSON read from storage.
I am not sure how performant is the 'save' function, but if it's too slow with large collections, we could replace the internal loop with an always-visible button to save progress in the browser. Or, we could measure the performance of the save, and if it takes longer than 100ms, for example, we could show that button for the user and increase the loop time to be 60 seconds, for example.
I am just spitballing, to be honest, but there are a lot of ways to do it.
Shame that JS is single-threaded, or it would have been straightforward. One way to overcome the performance hit of the internal loop is to implement a Service Worker ...
https://medium.com/techtrument/multithreading-javascript-46156179cf9a

a setInterval every X seconds should do the trick, but you are right, I have no idea performance-wise how this works. I can eventually create a 3 state dropdown (like: off, autosave, manual save) so a user can decide the behavior, default would be off and if a user wants to enable the functionality is free to do so

Great idea.
One final suggestion: please consider using setTimeout instead of setInterval. That is because if, for example, the interval is 5 seconds, and the save function takes 3 seconds, then the user is left with 2 seconds of 'unfrozen' UI to do any work. If the save function takes the full 5 seconds, then the UI will hang.
You can scale that up to any interval for the same outcome. setTimeout allows for a breather on the UI for slow logic.
Regardless of the method, thank you for listening.

@yagasoft I had another change in the pipeline so I had time to check about this functionality.
I released a new version (<IP_ADDRESS>), now you can manually save the collection to localStorage using the Save State option (right click on the collection).
The localStorage key name includes the instance url, so if you use the same browser with different instances it should work.
I know it's not the autosave functionality but I will keep this issue open for a while as reminder, I want to do some tests with the Worker API but right now I can't dedicate too much time on this, the manual save was easier to implement.

Manual save in the browser will make things much easier. Extra functionality than that is nice to have for sure.
Thank you.

@yagasoft thanks again for making this suggestion. It was very helpful for me to be able to save the collection state inside localStorage when I added the Fetch API syntax and when I added the REST Client export.
I thought in the last days about the autosave and I decided to don't proceed as I can't create something reliable and suitable for everybody.
I also checked the jsTree events (the request configuration is saved inside the data attribute of the jsTree node) but also the "changed" one doesn't get triggered when the data attribute is updated.
Sadly I also update the configuration (DRB.Metadata.CurrentNode that is a reference to the jsTree node) not uniformly in the code I wrote, making it difficult to pursue an approach related to this.
Feel free to comment if you want to add something, I will close this ticket 3 days later.

Thank you for considering my suggestion.
You could create a loop in a Web Worker and let it save periodically, regardless of events. The saved data would be exactly the same as the 'export to JSON' functionality. It wouldn't affect performance. However, you know your solution better than I do.
In any case, thanks again for adding the current save functionality. It's very helpful, indeed.


TR3 - Add RequiresDamage property to locations

Add a flag to Location to indicate that taking damage will be needed to reach particular locations. In TR3SecretRandomizer, handle this by assigning suitable "damage control".

Resolved under #265.


 Can you provided the log file or other advice to help me rise the accuracy?
python main.py --mode train --relation_dim 200 --hidden_dim 256
--gpu 2 --freeze 0 --batch_size 128 --validate_every 5 --hops 3 --lr 0.0005 --entdrop 0.1 --reldrop 0.2  --scoredrop 0.2
--decay 1.0 --model ComplEx --patience 5 --ls 0.0 --kg_type full
ps: I have used the LSTM

Thanks for your interest.
With 3-hop base and proper finetuning we can get ~0.75 accuracy. We need relation matching to get the results reported in the paper since the path is too long.
Please keep posted for the relation matching code to be uploaded.
Thanks


feat: views

Meaning a way to easily lay a filter/view over a JsonValue tree. For example based on annotations.
interface JsonUser extends JsonObject {
  @SensitiveInformation
  String getPassword();
}

Now a tree should be filtered
JsonUser user = ...
JsonUser userPublic = user.viewExclude(SensitiveInformation.class);

While this works with "static" information views should also allow to do data driven filtering.
For example, by passing a Predicate<JsonUserField> so a logic can be added when to include a JsonUserField that is based on the data in a JsonUserField value, like a isConfidential() boolean property.
There are two variants of views:

a true view as a filter in the proxy - this is likely easy to implement in the proxy handler with some additional logic but it will only work for access via the proxy
a mapped JSON view that filters the underlying - this requires a model of the interfaces to know which properties to affect when processing the JSON content, but this is much safer and once produced has no overhead

Filter Models
This is an idea that maybe has best of both worlds/variants (as described above).
In a first step a filter model would be created by some process. This is a tree of what values to look at in a tree.
record JsonFilter<T extends JsonValue>(
  Class<T> as,
  Predicate<T> test,
  Map<String,JsonFilter<T>> itemsByPath) {}

The model would then using structure like this
new JsonFilter(JsonGroup.class, null,
  Map.of("user", new JsonFilter(JsonUser.class, JsonUser::isInternal, Map.of()));

This would be a dynamic model that might remove the $.user from a UserGroup root object based on the actual users isInternal() property.
From this model and an actual value one can compute the removal operations to do.
In some models the test may not be dynamic but already decided as model creation.
For such models it is possible to create a patch of remove operations without an actual value.
The key in the map for the items is a path segment with array indexes being encoded as [i].
A special index would be used [*]to say "for all" items, similarly * alone means for all members of an object.
To access the member named * one uses the {*} variant of the name.
Models can be created in many different ways, for example by making an annotation analysis where a marker annotation marks all properties that should be filtered.

Note that there is another feature hidden in the filter model which is a declarative navigation though the tree where you want to do something with the nodes navigated to. In this case run test filter test predicate and based on the result create a remove operation for the path of the tested value.

See also https://github.com/Breus/json-masker


Update readme.md

Fix capitalization of DOSBox, a typo, and escape ][ properly

The ][ doesn't need to be escaped, it reads better when it is not.

I agree the escaped version is harder to read with a (plain) text editor, but w/o \ syntax highlighters might get confused. You can see this right here in the GitHub editor or on Linux Mint xed 3.0.2. Anyway, I will create a new PR w/o \.


Web access

We need to provide administrators an access through web browser.

Implemented in v1.2.0


[TOPIC-BLE-LLCP] Bluetooth: controller: rename private functions

Renamed the functions in ull_llcp_internal, renaming the ull_cp_priv into llcp prefix
Signed off by: Andries Kruithof<EMAIL_ADDRESS>

There are so many changes, so it is hard to certify that everything is covered, however it looks good to me.

I created a bash-script for doing the changes :)


Manual exposure support for OpenCV

In testing I noticed that the previous method of waiting a couple frames was still not fully reliable. Now I set manual exposure at every frame in the main loop.
Is it ok for you? Or should I rather make this workaround separately configurable or somehow whitelisted per-camera-model?

Thanks a bunch!


Add monitoring (ServiceMonitors) for rest of OPEA applications

Description
Background: All applications already use Gateway => HttpService class instance, so they all already provide Prometheus metrics end point.   And https://github.com/opea-project/GenAIComps/pull/845 adds more service specific Prometheus metrics to ServiceOrchestrator, which is also used by the all the applications.
This PR adds ServiceMonitors to all the remaining applications, so that their metrics are also visible in Prometheus, Grafana etc, similarly to ChatQnA.
This includes fix to VisualQnA, which README and values file incorrectly contained the monitoring items, but had no ServiceMonitor.
Issues
n/a.
Type of change
List the type of change like below. Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds new functionality)

Dependencies
n/a.
Tests
Manually verified that rest of the applications Service files are identical to ChatQnA except for the service name, and that their values files have a global section at end.  Therefore I could automate adding ServiceMonitor objects to them, and Helm options to their values.html file.

As this does not modify anything that could affect CI tests, but FaqGen still fails, there's either a bug in FaqGen or CI.
Maybe test is just not waiting enough for the results?
...
data: {"ops":[{"op":"add","path":"/logs/HuggingFaceEndpoint/streamed_output_str/-","value":" Can"},{"op":"add","path":"/logs/HuggingFaceEndpoint/streamed_output/-","value":" Can"}]}
curl: (18) transfer closed with outstanding read data remaining
data: {"ops":[{"op":"add","path":"/logs/HuggingFaceEndpoint/streamed_output_str/-","value":" I"},{"op":"add","path":"/logs/HuggingFaceEndpoint/streamed_output/-","value":" I"}]}
...
 data: {"ops":[{"op":"add","path":"/logs/HuggingFaceEndpoint/final_output","value":{}},{"op":"add","path":"/logs/HuggingFaceEndpoint/end_time","value":"2024-11-04T14:25:57.620+00:00"}]}
data: {"ops":[{"op":"add","path":"/logs/LLMChain/final_output","value":{}},{"op":"add","path":"/logs/LLMChain/end_time","value":"2024-11-04T14:25:57.624+00:00"}]}
curl failed with code 18

And:
-----------Pod: faqgen20241104142125-llm-uservice-7458f464c4-hwxmf---------
...
    |   File "/home/user/.local/lib/python3.11/site-packages/huggingface_hub/inference/_common.py", line 322, in _async_stream_text_generation_response
...
    | TimeoutError

Please wait PR #525 to land-in and rebase on it.


Extract function causes problems

Hi,
I`ve been running into problems when testing your algorithm on some of our data.
It seems your are using function extract from a given toolbox but my desktop is unaware of it.
In particular, running articulation_rate displays message
Undefined function 'extract' for input arguments of type 'double'.
My desktop is picking extract function from here:
which extract
C:\Program<EMAIL_ADDRESS>% cvdata method
and I think thats not the one your are using.
Can you please specify the origin of extract?
Thanks
Vojta

Hi @vojtaiii,
This function belongs to Audio Toolbox:
`

which extract
F:\programs\Matlab2020a\toolbox\audio\audio\audioFeatureExtractor.m  % audioFeatureExtractor method
`

I've reworked usage of labeled data and its splitting on train and validation dataset. Should be easier to use on different data now.


Fix training NR pipelines

 Fix using NodeRegression pipelines in the client

Thank you for the review I extended the change log entry, but kept it as a bug-fix as the feature was exposed to the user via Documentation as well as the python classes were present


Doc: Change the getkeypool's obsolete --wpkhs to --addr-type wpkh

While following the steps in /docs/bitcoin-core-usage.md I stumbled upon the command-examples for (re)filling the keypools which no longer work since #415 .

Please change also the --wpkh usage on line 288

Oops, I overlooked those. Thanks!

ACK 41740d3c7c21b1e545027f05ef35da9ba8b80e64


Example for STM32F4

I am in the process of porting a micropython firmware to rust using embassy and need to interact with an ADS1015.
Would it be possible to provide a sample code please?

There is an example for an STM32F3 here, an example for an STM32F1 here on top of the linux examples in this crate.
I think those should be fairly simple to adapt to an STM32F4.


Improve test database handling documentation

This patch documents the use of --noinput which can be useful in
several scenarios.

This works exactly as you described, but was never clearly stated in the docs, I'm +1 for this.


5.* Eloquent model update not checking if update was successful

Digging through the model update logic I noticed that the DB return value (number of updated rows) is not checked at all, instead true is returned always.
Illuminate\Database\Eloquent\Model::performUpdate
I think it should be checked (i.e. equal to 1).
I have made a patch for this already, hope you don't mind. I will do a pull request so you can check it out.
Br,
Fran

On the subject of changing default return value.
This feels like a big change that could end up breaking a lot of applications? This broke our update functions where we only used if($model->save())
We now have to do a check to see if the model isDirty and adjust accordingly, what is now the best practice to handle this?

Yeah this has to be reverted.

So, you want this in master or not at all?
I still think checking the update return value is prudent. Maybe the check could be improved by using != 0 instead.
The reason I was hoping this PR would pass is because I am doing a PoC for a optimistic lock model trait and without this check I might have to completely override the performUpdate instead of just checking if it returned true. The PoC optimistic lock is using a version field and appending it to the update where clause.

One way you could work around this is by using the Eloquent query builder
instead of performing the update on the model itself...
Something like Model::where('id', $model->id)->update($attributes); ...
this WILL return the number of records updated.
On Wed, Oct 28, 2015 at 8:01 PM, Fran Pregernik<EMAIL_ADDRESS>wrote:

So, you want this in master or not at all?
I still think checking the update return value is prudent. Maybe the check
could be improved by using != 0 instead.
The reason I was hoping this PR would pass is because I am doing a PoC for
a optimistic lock model trait and without this check I might have to
completely override the performUpdate instead of just checking if it
returned true. The PoC optimistic lock is using a version field and
appending it to the update where clause.
—
Reply to this email directly or view it on GitHub
https://github.com/laravel/framework/issues/10704#issuecomment-152044087
.

Yeah, I suppose that is also a possibility - but not a nice one :-)
I will adapt and hope someone makes a good PR for #545.

-- but not a nice one

For the record by that I meant, not as nice as $model->save().
Your advice is appreciated.

@taylorotwell When you have time, please check the new commit d8e709d. It addresses the regression caused by my first attempt.
If this is OK I will create a PR.

Hi everyone,
i'm interesting with this topic.
And what about FranPrefernik's d8ee709d commit?

+1
FranPrefernik's commit looks good to me. This would be really helpful to have.


Fixes issue with reloading based on repository.json url

Eventually, Hass.io uses the URL specified in the repository.json to update the repo...
this obviously fails.

(This goes wrong after another repo is being added). This fixes it for current users.

Is a bug in hass.io let use that as workaround


Can't disable animation

Hi,
I can't disable the fade effect, it's still enabled even when animation is set to false
See the sample here:
https://jsfiddle.net/k9x7yfuo/
Thanks

my mistake, animation is an option for steps not for the Tour


Create an 'Async' based ExecuteReader(), ExecuteScalar(), ExecuteNonQuery()

We need to use the DbCommand.ExecuteReaderAsync() and other 'async' methods of the DbCommand.

Done and reployed at v1.7.0-beta4


openssl dgst: add option to specify output length for XOF

This adds the -xoflen option to control the output length of the XOF algorithms, such as SHAKE128 and SHAKE256.
I initially thought that this can be implemented as a more generic option (say -mdopt xoflen:100) that allows to specify the "xoflen" param with EVP_MD_CTX_set_params. However, in the end I realized that it nevertheless requires a special case for XOF for the following reasons:

dgst makes use of BIO and the underlying gets method truncates the output
in the default provider, the value of "xoflen" is looked up with OSSL_PARAM_get_size_t which only works on a parameter values stored with OSSL_PARAM_construct_size_t, not the one returned from app_params_new_from_opts

I'd like to hear any suggestions.
Fixes: #11964

Checklist

[x] documentation is added or updated
[x] tests are added or updated

Daiki, could you please submit a CLA? Otherwise the PR cannot be merged.

https://www.openssl.org/policies/openssl_icla.pdf

* in the default provider, the value of "xoflen" is looked up with `OSSL_PARAM_get_size_t` which only works on a parameter values stored with `OSSL_PARAM_construct_size_t`, not the one returned from `app_params_new_from_opts`

This isn't quite correct.  The OSSL_PARAM helpers make an effort to convert between built in numeric types.  Thus, using other numeric construct functions (e.g. OSSL_PARAM_construct_int) will work here.  I.e. the parameter returned from app_params_new_from_opts should work and if it doesn't we've got a bug.

retriggering the CLA check

@ueno could you please address the comments from Richard and me?

I'm sorry for the delay; addressed those issues.

* in the default provider, the value of "xoflen" is looked up with `OSSL_PARAM_get_size_t` which only works on a parameter values stored with `OSSL_PARAM_construct_size_t`, not the one returned from `app_params_new_from_opts`

This isn't quite correct. The OSSL_PARAM helpers make an effort to convert between built in numeric types. Thus, using other numeric construct functions (e.g. OSSL_PARAM_construct_int) will work here. I.e. the parameter returned from app_params_new_from_opts should work and if it doesn't we've got a bug.

I think this is because "xoflen" is defined as a bignum:
https://github.com/openssl/openssl/blob/master/providers/implementations/digests/sha3_prov.c#L261
while it is always accessed as size_t. Would it make sense to change the definition to use OSSL_PARAM_size_t?

while it is always accessed as size_t. Would it make sense to change the definition to use OSSL_PARAM_size_t?

OSSL_PARAM_size_t uses OSSL_PARAM_UNSIGNED_INTEGER underneath.  OSSL_PARAM_UNSIGNED_INTEGER doesn't imply bignum -- they can always convert to bignum but could be native types too.
As I mentioned, the conversion between numeric types happens automatically.  Setting this via a double, int, unsigned int or size_t will all work (assuming the length is within range of these types).

If we were able to use OSSL_PARAM for this, I guess the patch would look something like:
https://github.com/ueno/openssl/commit/29abe6407538ab318468120dd2836d652afeca82
I'm new to OpenSSL, so let me know which approach is more palatable.

The test failure seems relevant.

ping for second review

This pull request is ready to merge

Merged to master. Thank you for the contribution.


Close hibernate validator vulnerability

Sanitise potential nested el expressions in configuration path values. Remove dollar signs from path values before creating validation message,

Codecov Report

Merging #1007 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master    #1007      +/-   ##
============================================
+ Coverage     99.31%   99.31%   +<.01%
  Complexity     2231     2231
============================================
  Files           337      337
  Lines          6100     6102       +2
  Branches        363      363
============================================
+ Hits           6058     6060       +2
  Misses            5        5
  Partials         37       37

Impacted Files
Coverage Δ
Complexity Δ

...orum/tessera/config/constraints/PathValidator.java
100% <100%> (ø)
10 <0> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58fa9ba...265abde. Read the comment docs.


Why did you set PRO_SCALABLE_BASELINE = 83,   PRO_SCALABLE_HIGH     = 86 ?

Hello everyone,  I have found if I set  "SimulcastAVC                     0              # 0: use SVC syntax for higher layers; 1: use Simulcast AVC"
take a look at"  uiProfileIdc = (!bSimulcastAVC) ? PRO_SCALABLE_BASELINE : uiProfileIdc;" The IDR frame is set to PRO_SCALABLE_BASELINE 83. After I extract one layer of streams in SVC streams, uiProfileIdc  cannot be parsed by FFMPEG.

My question is why do you set PRO_SCALABLE_BASELINE to 83.

As can be seen from the standard protocol, the baseline profile of SVC is 83(in this case, you set SimulcastAVC to false, means you will enable svc coding)

Thank you very much.  I have to rewrite NAL to meet the requirement of FFMPEG.

Maybe you can set SimulcastAVC to true, it will achieve the same purpose.

@hzk7287 is your problem resolved?

Yes.

great.
so I will close this issue. thank you for you attention.


Add tests for RoleFilter component

RoleFilter is a component that receives children and an array of roles. We need to check if it returns null when the user doesn't have the proper roles.

I would like to do this one !

@Isaac-alencar please, ask for assign next time :) @perchespierri I'm sorry for this, and I'm sure you can help us with another issue :)

@m-pereira, @belgamo and @perchespierri  I'm sorry about it, I will ask to assign next time!


Old Ignite folder structure

how can i generate the old Ignite folder structure using ignite new MyAppName? The new boilerplate seems to not include the folders: Actions, Fonts, Utils, Store. Reducers folder is also changed to Redux

I don't believe we have a boilerplate based on the older structure.   I'd be open to listing a fork of the old structure.  Do you want help creating a boilerplate with that structure?

yup that would be great! cause i already have an existing project based on the old folder structure and previous redux logic. i plan to transition everything but not now since im rushing on deploying a new version of my app

Nice! I'll close for now, but reach out if you need help with your new boilerplate.

where am i gonna grab the fork?

@mykelaballe I'd start with https://github.com/infinitered/ignite-ir-next, but wait until we release Andross this week (our first major release with Ignite CLI).

ohh too bad. i really need the old structure ASAP

This tag has the 1.0 structure if you need to resurrect some files.

Yup, look through the releases (https://github.com/infinitered/ignite/releases) and find out when you'd like the old structure, then it's super easy!

Looks to me like anything before 1.7 should be good:   https://github.com/infinitered/ignite/releases/tag/1.7.0

@skellock how should i generate the boilerplate? ill download the repo then call ignite new MyApp inside that repo? also when i looked at the App folder, its still the new folder structure.
@GantMan the same question here, how should i generate it? ill download it and then run command ignite new MyApp, and then it will map my app's name to android's manifest file, gradle, ios AppDelegate file, etc...?

why is it that ignite new MyApp command gets the 1.13.0 folder structure even though the ignite version installed on my windows pc is 1.5.0?

Another thing is that whenever i run the generated boilerplate, i keep getting this error

run npm dedup

it worked for vector-icons but now another naming collision appeared which is the router-flux. is there an npm dedup recursive command?

i tried deleting the collisioned file stated in the image above, but when i build it again another file has collided with other files again. And it seems to happen repeatedly even though i delete the next files and so on and so forth


not done yet D:

For now, apparently you have some conflicts to resolve and since this library appears to be with front-end capabilities I'm not confident to comment in your code, but all seems pretty neat and organized. Nice job.


Split assets into multiple files

Soundsets is now also exposed through assets.

kinda forgot about this, sorry ⌚
Thanks 👍

No problem!


Used Object assign to get rid of lodash

Coverage remained the same at 100.0% when pulling 542f7dba6221530ba5ef6d0199888392566a8410 on daveedgarcia:master into a309a4a02c87a1f4df7879fd4a17ab9a5ca77613 on awolden:master.


refactor: update getToday from UTC to Local

as previous PR, refactor function getToday from UTC to local time

LGTM mas, Thank you for contribution
Appreciate it!


Strong type the App.tsx page props

The App page can't be strong typed if it uses withRouter() from React-Router

This issue was fixed by using the following code-
interface IApp extends RouteComponentProps {   store: IStore; }


Adding step count

Created a secondary feature for step count to work differently for iOS and Android. Added secondary tests as well.

Random thought: is it possible to add daily/weekly/monthly aggregation? (i.e. bucket = 30 // days or so.)

The resolution parameter works like this, so this functionality should already be built in.

@dcurrey88 Perfect! I knew I was forgetting something. Thanks for the clarification.


Feature request - Migrate to io.sentry packages

Sentry have overhauled their Java API and renamed its associated packages and artefacts.
Is there an intention to produce an updated version of dropwizard-raven to align with the latest available implementation?

I've followed the development of sentry-java and seen the newer 1.x releases. Unfortunately, I haven't been able to figure out the best way to continue to expose the same API currently supported by dropwizard-raven with the latest versions.
Upgrading sentry-java may mean changing the public API and removing some of the currently available configuration settings that cannot be supported going forward.
I'd like to upgrade to keep this current but need to give this more thought.

Yeah, it's a tricky one.
I could see future new users coming along and being confused as to why a library for Sentry would have Raven in the name.  So perhaps it might be best to create a new project and abandon some backwards compatibility.
Do you have a list of the settings that might drop off with this approach?

So perhaps it might be best to create a new project and abandon some backwards compatibility.

This is probably the best approach

Do you have a list of the settings that might drop off with this approach?

Do you have a list of the settings that might drop off with this approach?

I had a branch where I started an attempt to upgrade to sentry-java, hopefully I still have it around...

So, upon further investigation, I was mistaken. They've removed programmatic access to configuration in the SentryAppender and instead recommend configuration via a properties file.
This actually simplifies things quite a bit. I still thing dropwizard-sentry is probably the right approach vs. adapting this library to these new conventions.

I suppose that means we can close this issue, as it will not be related to this project / repository.