RFC 7233 - Range Requests

See #978 for details.

Travis seems to have a hard time running redis server on last build :)

:umbrella: The latest upstream changes (presumably ca1665a) made this pull request unmergeable. Please resolve the merge conflicts.

:umbrella: The latest upstream changes (presumably 2bc6035) made this pull request unmergeable. Please resolve the merge conflicts.

@magne4000 I think you goofed up the diff, it now contains unrelated changes.
I recommend git rebase -i <base_branch> to select which commits should stay.

I had to soft reset, but it's cleaner now

I had to soft reset because I messed up the history, but it's cleaner now.

:umbrella: The latest upstream changes (presumably 0407d22) made this pull request unmergeable. Please resolve the merge conflicts.

Excellent work, it's really rare to get a PR of this size with so few errors. Sorry it took so long to review this, but here we go.

There's one issue left: There are several new public functions. It needs to be decided which ones we want to expose, those have to be added to the .rst files in the docs folder.

werkzeug/datastructures.py new method Range.to_content_range_header already handled by:

.. autoclass:: Range
   :members:

werkzeug/wrappers.py new methods are considered protected
werkzeug/__init__.py add 'RangeWrapper' to 'werkzeug.wsgi'
werkzeug/wsgi.py should add RangeWrapper in wsgi.rst

Don't know if we need something more

If they're protected they should be prefixed by underscore IMO, but will have to look how rest of Wz handles this.
On 7 September 2016 13:17:58 CEST, "Joël Charles"<EMAIL_ADDRESS>wrote:

werkzeug/datastructures.py new method
Range.to_content_range_header already handled by:

.. autoclass:: Range
  :members:

werkzeug/wrappers.py new methods are considered protected
werkzeug/__init__.py add 'RangeWrapper' to 'werkzeug.wsgi'
werkzeug/wsgi.py should add RangeWrapper in wsgi.rst

Don't know if we need something more
--
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/pallets/werkzeug/pull/977#issuecomment-245250309

--
Sent from my Android device with K-9 Mail. Please excuse my brevity.

That is already the case

Ah sorry, I forgot there were mostly new methods there. Do we really want to expose RangeWrapper? It seems like out of scope for Werkzeug as a WSGI library (like many things in Werkzeug, see #4). Also imports from __init__ will be deprecated eventually.

RangeWrapper would never be used manually indeed, and as you said perhaps out of scope for a WSGI lib, so I think we can leave it unexposed.
And also if we do not need to update __init__.py, I think there's nothing left for me to update then.

Actually RangeWrapper should be prefixed by an underscore then.
On Wed, Sep 07, 2016 at 05:49:47AM -0700, Joël Charles wrote:

RangeWrapper would never be used manually indeed, and as you said perhaps out of scope for a WSGI lib, so I think we can leave it unexposed.
And also if we do not need to update __init__.py, I think there's nothing left for me to update then.
--
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/pallets/werkzeug/pull/977#issuecomment-245270050

I added some details in make_conditionnal doc in order to make good use of _RangeWrapper without knowing it exists

Just a few notes from myself about this: I'm actually okay with RangeWrapper being public. Reason being that people will just start to import the underscored version anyways and this way we at least commit to not breaking it. It seems sensible to support.

Not our problem tbh
On 8 September 2016 11:02:58 CEST, Armin Ronacher<EMAIL_ADDRESS>wrote:

Just a few notes from myself about this: I'm actually okay with
RangeWrapper being public. Reason being that people will just start
to import the underscored version anyways and this way we at least
commit to not breaking it. It seems sensible to support.
--
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/pallets/werkzeug/pull/977#issuecomment-245537265

--
Sent from my Android device with K-9 Mail. Please excuse my brevity.

Not our problem tbh

Then we should quickly figure out the answers to these two questions:

Is there a value for a user to create instances of this object?
If the answer to 1. is yes, are they supposed to copy paste it?

Also not our problem, but I'd rather create a third-party package with this API than exposing it here.
On 8 September 2016 11:08:10 CEST, Armin Ronacher<EMAIL_ADDRESS>wrote:

Not our problem tbh

Then we should quickly figure out the answers to these two questions:

Is there a value for a user to create instances of this object?
If the answer to 1. is yes, are they supposed to copy paste it?

--
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/pallets/werkzeug/pull/977#issuecomment-245538549

--
Sent from my Android device with K-9 Mail. Please excuse my brevity.

@untitaker sure. But we already need to include this thing internally anyways. So it's not like we can delete that code.

We shouldn't incitate one to instanciate this class. Instead, as I added in the doc, the response data object must implement a part of io.BaseIO methods.

If we suddenly don't need it anymore we can't delete it either without API breakage. With your philosophy taken to the extreme, no refactor would be possible without bumping the major version.
On 8 September 2016 11:12:51 CEST, Armin Ronacher<EMAIL_ADDRESS>wrote:

@untitaker sure. But we already need to include this thing internally
anyways. So it's not like we can delete that code.
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
https://github.com/pallets/werkzeug/pull/977#issuecomment-245539651

--
Sent from my Android device with K-9 Mail. Please excuse my brevity.

Let's keep it private for now then and add a comment to decide on what to do with it in the future.

@magne4000 Could you add that comment? Thanks!

Should I prefix the comment with a specific sphinx markup ?

No I think a normal #-comment is fine.
On Thu, Sep 08, 2016 at 04:48:53AM -0700, Joël Charles wrote:

Should I prefix the comment with a specific sphinx markup ?
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
https://github.com/pallets/werkzeug/pull/977#issuecomment-245573225

Excellent, thank you!

:wink:

Also thanks for being patient with the bit-by-bit review I did. I do try to review your PR in large chunks, but some things only come to mind after a while.

No probs, that was necessary, this was not a tiny PR :smile:


Probot Stale default configuration

closes: #746
Adds "good first patch" as an exception to stale determination, as
discussed here.

Just a question that came to mind: here you've redefined all defaults as well as the customization regarding labels. Is that a recommended strategy? (For reference, in xjava, we only overrode specific parts of the configuration; I'm not sure whether it's better to adopt defaults where possible, or to be more robust and over-specify). 🤔

As per #746 this repository will not use the Probot.

@stkent I changed the values based on discussion in the mentioned discussion, but did copy and paste the entirety as reference in case more was to be changed.  I think having the complete set of options that exist being in the file is helpful for quick modification.  I simply did not know if further discussion would have me make changes and wanted the information close.


promtool tsdb dump support native histogram

partly fix #12146
let promtool tsdb dump support native histogram as @beorn7 suggests

Which leaves us with tsdb dump: That would indeed be good to support native histograms. The dump uses pretty much an ad hoc format. That's a problem of its own, see discussion in https://github.com/prometheus/prometheus/issues/8281 in https://github.com/prometheus/prometheus/pull/8320 , but for now, it simplifies things here. You can essentially make something up (which could be using the String methods that are also used in the internal web UI).

The output I test looks like
{__name__="http_request_durations", code="200", instance="native-demo:8080", job="native-demo", service="service#9"} {count:822093, sum:4.935757323322672e+06, [-0.05,0.05]:3409, (0.044194173824159216,0.0625]:833, (0.0625,0.08838834764831843]:1792, (0.08838834764831843,0.125]:2467, (0.125,0.17677669529663687]:3574, (0.17677669529663687,0.25]:5031, (0.25,0.35355339059327373]:7107, (0.35355339059327373,0.5]:10193, (0.5,0.7071067811865475]:14093, (0.7071067811865475,1]:20101, (1,1.414213562373095]:28544, (1.414213562373095,2]:40030, (2,2.82842712474619]:56409, (2.82842712474619,4]:80098, (4,5.65685424949238]:113296, (5.65685424949238,8]:160707, (8,11.31370849898476]:227336, (11.31370849898476,16]:47073}<PHONE_NUMBER>140
{__name__="http_request_durations", code="200", instance="native-demo:8080", job="native-demo", service="service#9"} {count:822524, sum:4.938426501507527e+06, [-0.05,0.05]:3411, (0.044194173824159216,0.0625]:835, (0.0625,0.08838834764831843]:1792, (0.08838834764831843,0.125]:2470, (0.125,0.17677669529663687]:3575, (0.17677669529663687,0.25]:5035, (0.25,0.35355339059327373]:7109, (0.35355339059327373,0.5]:10198, (0.5,0.7071067811865475]:14097, (0.7071067811865475,1]:20113, (1,1.414213562373095]:28554, (1.414213562373095,2]:40058, (2,2.82842712474619]:56437, (2.82842712474619,4]:80134, (4,5.65685424949238]:113345, (5.65685424949238,8]:160795, (8,11.31370849898476]:227473, (11.31370849898476,16]:47093}<PHONE_NUMBER>144

Thanks! Seems reasonable for now given the ad hoc format as discussed.


Update neural_style_transfer.py

The scipy pkg cancelled the imsave function and save_img function is not defined in some version of Keras 2 (eg. AWS DL AMI v8.0).
Thus using the opencv-python PKG instead.

You can use from keras.preprocessing.image import save_img now.


Laikad: Use clocks for faster fetching orbits

Using the clocks walltime to receive the time from messages for fetching orbits. It's only used to download orbits at startup faster.
When ublox messages are received it will ignore the clocks messages.
The last_fetch_time_t is now set to the time of request instead of the time of receiving. This fixes the issue where a wrong walltime could stop fetching orbits for 1 minute.

Don't forget to add clocks to process replay


add maybe: dual of assert

Pre-merge checklist
Performance:
OR

[X] I am very sure this PR could not affect performance.

bors r+


Routing

Hello,
I'm trying to understand the routing with Elder.js.  How would you internally link to pages inside your site?
Thanks!

Thanks.  Ya, the issue was on my end.  I was trying that but my page wasn't building properly.  Once it built properly the links are working.


Copy+paste from the site into a workbook isn't lined up in columns

When I copy+paste from the expenses web site, it doesn't paste neatly into columns
See how it pasted in image below:

This may be a quirk with Excel. Try with Google Sheets.

This may be a quirk with Excel. Try with Google Sheets.


Perturbation bug on turn to NE

See https://github.com/saeed-moghimi-noaa/Next-generation-psurge-tasks/issues/6#issuecomment-1834039503
These are 8 directions straight tracks for testing:
straight_tracks.tgz

Using a fake track, it is definitely obvious something's wrong with NE direction:

NE
NW

All of these are supposed to be perturbed similarly for 50 track ensemble!
Just FYI @WPringle @lauraalaka

Southwest has the same issue:

@SorooshMani-NOAA OK, I guess that there must be an issue with the sign or something.

I made some changes and it seems that it works:

NE
SW

I'm still testing...

And this is how Michael looks like:

Looking at all of the 3 storms for all lead times, I don't see anything fishy. See the attached zip file:
plots.zip


Added the ability to have code based configuration rather than file based

In Addition logfiles now no longer have to exist, they are created upon first use.

Thank you for the contribution! I don't have time to fully check it just yet, but it looks like Travis already caught a small problem. Until I am able to test it, would you mind fixing the issue and any others that pop up in Travis?

No problem.  I did run it through the tests, but not Travis, but it's about time I looked into Travis anyway :)
Regards
Steve
Get Outlook for Androidhttps://aka.ms/ghei36
On Tue, Sep 27, 2016 at 10:04 PM +0100, "Thomas Hernandez" <notifications<EMAIL_ADDRESS>wrote:
Thank you for the contribution! I don't have time to fully check it just yet, but it looks like Travis already caught a small problem. Until I am able to test it, would you mind fixing the issue and any others that pop up in Travis?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/CPIGroup/phpAmazonMWS/pull/103#issuecomment-249998023, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AVaTGBdONRyjBVAA7_M5Zy5EmS5pIHn-ks5quYSzgaJpZM4KH14C.

Since the project has Travis support added, checking Travis is easy. All you have to do is click the red X (or green mark) next to the commit hash to see the test results.

They're all fine, I did wonder about the credits and change log, I just figured if you didn't want them, you'd revert them ;)
As for that bug, you're right, I missed that one  it's obviously not covered by the tests, I'll fix that too when I'm back at work.
Regards
Steve
Get Outlook for Androidhttps://aka.ms/ghei36
On Tue, Sep 27, 2016 at 10:24 PM +0100, "Thomas Hernandez" <notifications<EMAIL_ADDRESS>wrote:
@Peardian requested changes on this pull request.
I think I did this correctly

In includes/classes/AmazonCore.phphttps://github.com/CPIGroup/phpAmazonMWS/pull/103#pullrequestreview-1824042:

@@ -467,25 +475,20 @@ public function setThrottleStop($b=true) {
protected function log($msg, $level = 'Info'){
if ($msg != false) {
$backtrace = debug_backtrace(DEBUG_BACKTRACE_IGNORE_ARGS);

       if (file_exists($this->config)){

           include($this->config);

       } else {

           throw new Exception("Config file does not exist!");

       }

       if (isset($logfunction) && $logfunction != '' && function_exists($logfunction)){

       $logCallback = $this->config->getLogCallback();

       if (empty($this->config->getLogCallback()) === false){

PHP 5.4 will give a fatal error on this

In CHANGELOG.mdhttps://github.com/CPIGroup/phpAmazonMWS/pull/103#pullrequestreview-1824042:

@@ -2,6 +2,11 @@
All notable changes to this project will be documented in this file.
This project adheres to Semantic Versioning.

+# 1.4.0 - 2016-08-27
If you don't mind, I would prefer it if changes to the changelog were handled by me at the time of release.

In CREDITShttps://github.com/CPIGroup/phpAmazonMWS/pull/103#pullrequestreview-1824042:

@@ -1 +1,2 @@
The phpAmazonMWS library was designed and written by Thomas Hernandez (peardian at gmail) for the CPI Group.
+The v1.4.0 refactoring when adding the AmazonMWSConfig class was done by Steve Childs (stevechilds76 at gmail) for Color Confidence (UK).

I do want to give contributors credit, but I haven't yet figured out the best way to go about it, so for now I would prefer it if the credits file was not modified. You are welcome to put an author tag in the new config class, though.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/CPIGroup/phpAmazonMWS/pull/103#pullrequestreview-1824042, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AVaTGIip_BWWy1mu_g0WLEakmVKMT3BXks5quYl5gaJpZM4KH14C.

Should hopefully all be fixed now :)

Thanks. I will get to checking it in-depth when I able to.

My pleasure @Peardian, thanks for creating the library in the first place, it's saved me a lot of time (even allowing for the half day to refactor the code ;).
When I've got some time I'll add some Symfony usage examples too, even if its just a 'how-to' for inclusion in the read-me, it may be useful to someone :)

This is great, solves a real problem for me, is there any estimate on when it will be released @Peardian?

@ThomasRedstone If I can't get to it next week, it may have to be sometime in November.

@ThomasRedstone  - Feel free to use my fork (I think its public) in the mean time if you can't wait. I've been using it myself and I haven't found any issues yet... (Famous last words, I know!)

I've finally had a chance to sit down and look through it in detail. It's good for the most part, but there are some tweaks I want to make to the design before it gets approved. When I have the time to work on it, I'll make pull request based off of your branch. I'll leave this open until then. Thanks again for the contribution!

Drats, I should have known that the other pull request would conflict with this one. I'll fix them when I make my tweaks.

hi.. any chance this will be done anytime soon?

I have been busy with other things in preparation for the holiday season. Once those are done, I may have time to work on this, but I can't make any guarantees until Christmas has passed.

Please Note, I've changed my username, so my fork is now at https://github.com/stevechilds/phpAmazonMWS

Hi,
just wanted to know when can we get this merged? :)
thanks.

Unfortunately, I have not had a chance to work on this yet. I am still busy with wrapping up some holiday-time projects, but I may have some time to work on it at the end of the month or next month.

I think this is a great contribution to the project.
Any idea when you will merge?
I will use /stevechilds/phpAmazonMWS  in the meantime.

I don't have a solid answer, but I am hoping to work on it sometime this month. Only just last week was I able to finish up the projects I mentioned in my previous comment, so I hope to find time to work on this relatively soon.

Thank you, let me know if I can help with anything!

Hi @Peardian
hope you are doing good.. just wanted to ask whats an eta on this merge?
really looking forward on getting this merged :)
much appreciated on all the work you have already done :) saved me alot of time and effort :)
thanks.

Unfortunately, I still haven't had a chance to work on this. I have been much busier than I anticipated with new projects. I want to work on this soon, though that is not entirely in my control. Maybe this summer I will have time.

I finally have a bit of time to look into this. I don't think I'll be able to finish it today, but at the very least I can probably get a WIP pull request up.

Thanks @Peardian
your efforts are much appreciated! :)
looking forward.
cheers

I am still continuing to look into this with the free time I can manage, though I don't think it will be part of the v1.4. I want to get support for new operations and fields as soon as possible, and then this config overhaul can be part of v1.5.

Thanks again for all the work. Definitely looking forward to the config change being merged. Currently having to use the forked version for a few projects and would rather get back on the mainline. Again though, thanks for all the work, it makes working with MWS much more pleasant.

Is there any ETA on this ever getting merged? I think using the forked version would potentially not be up to date with the most recent changes to Amazons API as compared to the master branch?

Unfortunately, I have been quite busy and have not had a chance to work on this more. I can't make any promises on when it will be ready, but I plan for this to be the focus of the next release. I realize that it has been over a year now, and I apologize to everyone who has been patiently waiting on this feature.

ETA on getting this merged?

For all of you looking for some solution: I use rapidwebltd/amazon-mws-config-generator to use the bundle with symfony. At least it's a temporary problem solving solution.


Hotfix: Infinite Re-rendering of SideNavDrawer

Description
This hotfix resolves an infinite rendering issue in the SideNavDrawer component caused by improper error handling. The fix includes moving error notification logic to useEffect, improving user profile data handling, and adding proper loading state management.
Key Changes:

Error Handling: Moved error notification logic to useEffect to prevent infinite re-renders when an error occurs.
User Profile Handling: Added type-safe checks to ensure correct rendering of the user profile or fallback to "Guest" in error/loading states.
Loading State: Introduced explicit loading state management to display "Loading..." during data fetch.

Type of change

[X]  🐛 Bug fix (non-breaking change which fixes an issue)

How Can this be tested? Testing Plan to review this PR

[X] Where in the app does this change take place?
SideNavDrawer component
[X] What are the steps to test this change?
[X] What is the expected output?

Spin up app in firefox
Observe browser console and you will not see infinite re-rendering of sideNavDrawer

Checklist:

[X] I have performed a self-review of my own code.
[X] I have commented on my code, particularly in hard-to-understand areas.
[ ] I have made corresponding changes to the documentation.
[X] My changes generate no new warnings.
[ ] Any dependent changes have been merged and published in downstream modules.
[X] I have reviewed the Security Best Practices Document.
[X] I have followed the Naming Conventions Guide for my changes.
[X] I have ensured that my pull request title is descriptive.

Thanks for doing this hotfix. I see in the testing steps you mention to fire up the app in Firefox. We're still seeing the snackbar error message with a loading indicator where using name is on the sidebar and then the app crashes with the following error.

Thanks for the comment. I will investigate this.


Oscillator with amplitude of 1.0 or greater results in distorted waveform

When an oscillator amplitude value is >=1.0, the resultant waveform is distorted regardless of the wave shape selected. For the time being, keep the amplitude for any single oscillator to <= 0.90.

This was only experienced in the example code where the maximum/minimum sample value exceeded the 16-bit signed integer limits. The examples were corrected.
Consideration is being given to incorporating a hard limit, but for now amplitude values outside of the 0.0 to 1.0 range will be allowed as extreme values create a potentially desirable distortion sound.


Can manage all overriding following rules

can :manage, :all overrides following can rules implicitly.
Given the following ability:
class Ability
  include CanCan::Ability

  def initialize(user)
    user ||= User.new # guest user (not logged in)

    if user.superadmin?
      can :manage, :all
    elsif user.admin?
      can :manage, :all
      cannot :manage, User, role: User.roles[:superadmin]
    end
  end
end

This bug scenario happens
> user = User.find_by(role: User.roles[:admin])
> ability = Ability.new(user)
> ability.can?(:manage, User, role: User.roles[:superadmin])
true

This completely neglects the usage of cannot

:+1: Same issue here

same issue

I've had a closer look at this and wasn't able to reproduce this on 1.16.0, master, develop.
I think the issue comes from misuse of the method can?.
The third argument incan? isn't a hash of conditions. It's an argument that is passed to the condition block. Also, when passing a class to can? the block isn't called.
In other words:
# this
ability.can?(:manage, User, role: User.roles[:superadmin])
# is equivalent to this
ability.can?(:manage, User)

Which according to wiki and docs should be true.
To get the expected behavior you should pass an instance as argument:
ability.can?(:manage, User.new(role: User.roles[:superadmin]))

Hope this helps.

@musialik has given the right answer. Using ability.can?(:manage, User, role: User.roles[:superadmin]) is the same as ability.can?(:manage, User) which makes also sense.


[FLINK-32073][checkpoint] Implement file merging in snapshot

What is the purpose of the change
As one part of FLIP-306, this PR enables file merging in snapshot by implementing the corresponding output&input streams for FileMergingSnapshotManager
Brief change log

Add createCheckpointStateOutputStream in FileMergingSnapshotManager.
Add output&input streams for file merging checkpoints
Add SegmentFileStateHandle to represent a state that is written into a file segment.

Verifying this change
Please make sure both new and modified tests in this PR follows the conventions defined in our code quality guide: https://flink.apache.org/contributing/code-style-and-quality-common.html#testing
This change added several UT tests in:

FileMergingSnapshotManagerTest
FileMergingCheckpointStateOutputStreamTest
FsSegmentDataInputStreamTest.

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: (no)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes)
The S3 file system connector: (no)

Documentation

Does this pull request introduce a new feature? (no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

Thanks @fredia and @Zakelly for your comments. Sorry for the late reply. I have addressed your comments. Would you please take another look?

Thanks @fredia and @Zakelly for your comments. Sorry for the late reply. I have addressed your comments. Would you please take another look?

Thanks for your effort. I have no comments but a minor one, PTAL, thanks.

CI seems Failed with "99d7b97"

@flinkbot  run azure

@curcur The CI failure has been addressed. (The file-merging checkpoint was unexpectedly enabled.) Would you please take another look?

The PR looks GTM.

I left a few comments.
squash the commits.
There are conflicts, resolve them and after turn green, ping me, and I will merge them.

@curcur I have addressed your comments by removing the unused codes and squashing the commits. The PR is now free of conflicts and has passed the CI tests. PTAL.


License?

Looks interesting, but without a license, nobody else can legally use it.

Oh good, point. It's MIT. I'll add it asap

Added, thanks 👍

Thank you!


B5st + Woocommerce

I`m trying to make this team support Woocommerce which should be super easy but after declaring support i get no images on the product site. It doesnt happen with b4st. Do you know what can be the reason?

Hi Geekabit,
Sorry for the delay — I had no time until now (Saturday).
Here's what I've just done. Simplest setup, not quite following my b4st wiki but close — looks like the order of setting up is wrong in https://github.com/SimonPadbury/b4st/wiki/Adding-WooCommerce-support-to-b4st
This works for me in b5st:

Fresh WordPress install on a local server (I started over, with a new project in Flywheel Local).

Install and activate the WooCommerce plugin — skip whatever you don't need at this stage.

Paste b5st/ (unzipped) into the WordPress themes/ folder.

Don't activate theme b5st yet, because it's not WooCommerce-ready, until you've added Woocommerce support._ Instead, open it as a project in an editor (e.g. VS Code).

In b5st’s functions/setup.php , inside function b5st_setup() { ......} , I simply pasted in add_theme_support( 'woocommerce' ); (But you could do what I said in the b4st wiki.)

in b5st's root folder, create woocommerce.php and paste into it this basic template:

<?php get_header(); ?>

    <?php woocommerce_content(); ?>

<?php get_footer(); ?>

Now, in Appearance>Themes, Activate b5st. This will now initiate correctly as a WooCommerce-ready theme, because you did the stuff above.

Populate the navbar.

Inside the WooCommerce plugin folder, there's a folder called sample-data/. Using the sample_products.csv you’ll find there, do this: https://woocommerce.com/document/importing-woocommerce-sample-data/

View the site frontend (refresh it), and you've got demo merch with images.


cbprintf_cxx.h error with void*

There are two specializations  of z_cbprintf_cxx_arg_size for float and void *. When using a void *, the linker seems to randomly pick the specialization or the generic version. The generic version causes a compiler error because of pointer arithmetic.
In file included from /usr/local/google/home/pfagerburg/zephyrproject/zephyr/include/zephyr/sys/cbprintf_internal.h:62,
                 from /usr/local/google/home/pfagerburg/zephyrproject/zephyr/include/zephyr/sys/cbprintf.h:124,
                 from /usr/local/google/home/pfagerburg/zephyrproject/zephyr/include/zephyr/logging/log_msg.h:11,
                 from /usr/local/google/home/pfagerburg/zephyrproject/zephyr/include/zephyr/logging/log_core.h:9,
                 from /usr/local/google/home/pfagerburg/zephyrproject/zephyr/include/zephyr/logging/log.h:11,
                 from /usr/local/google/home/pfagerburg/chromiumos/src/third_party/pigweed/pw_log_zephyr/public/pw_log_zephyr/log_zephyr.h:16,
                 from /usr/local/google/home/pfagerburg/chromiumos/src/third_party/pigweed/pw_log_zephyr/public_overrides/pw_log_backend/log_backend.h:16,
                 from /usr/local/google/home/pfagerburg/chromiumos/src/third_party/pigweed/pw_log/public/pw_log/log.h:62,
                 from /usr/local/google/home/pfagerburg/chromiumos/src/third_party/pigweed/pw_rpc/call.cc:18:
/usr/local/google/home/pfagerburg/zephyrproject/zephyr/include/zephyr/sys/cbprintf_cxx.h: In instantiation of 'size_t z_cbprintf_cxx_arg_size(T) [with T = const void*; size_t = unsigned int]':
/usr/local/google/home/pfagerburg/chromiumos/src/third_party/pigweed/pw_rpc/call.cc:306:3:   required from here
/usr/local/google/home/pfagerburg/zephyrproject/zephyr/include/zephyr/sys/cbprintf_cxx.h:109:27: error: pointer of type 'void *' used in arithmetic [-Werror=pointer-arith]
  109 |         return sizeof(arg + 0);
      |                      ~~~~~^~~~

My build environment is:

Linux
Zephyr SDK 0.16.0
Zephyr hash 47102de474cb055804e8f786e74c72d8248fd7b0
Pigweed hash 97c6a1079c65b9c4ad61c83b806c362e268ee5ea

Changing sizeof(arg + 0) to sizeof(T) and deleting the void * specialization seems to fix it.
We should also consider deleting the float specialization.

Created PR https://github.com/zephyrproject-rtos/zephyr/pull/60751 to fix

PR has merged, and my code builds correctly. Should we also remove the specialization for float?

@dcpleung I'm not sure we want to close this. I believe that the same issue will happen with float

@yperess seems like a separate issue might have been better for the float case so that we can map which PR closes which bug

@yperess seems like a separate issue might have been better for the float case so that we can map which PR closes which bug

Your call, both issues are from the same cause, the specialization isn't done right and we get 2 copies of the same function. We're at the mercy of the linker after that.

I think CI didn't complain because it wasn't also building with the Pigweed libraries. Also I realize I forgot to include a link to the source for the application I was building - Chameleon v3 EC.
it seemed to be a random thing, because we have been building this code for a while, but perhaps the linker was always choosing the "right" copy of the function until one day it didn.t

Maybe certain compiler/linker flags are passed which alter the behavior?
Though, without a way to reproduce using the main zephyr tree, it would be impossible to verify any fixes.

Though, without a way to reproduce using the main zephyr tree, it would be impossible to verify any fixes.

That's a difficult problem. The PR that merged definitely fixed the issue I was seeing, but without the Pigweed libraries and a Google Chameleon v3 target to build in Zephyr CI, it's nearly impossible to make sure this doesn't come back later.
I will spend some time thinking about whether I can make a much smaller test case that fails on void * before that PR, and passes afterwards.


More precise description of dependabot's Gradle support

Code of Conduct

[X] I have read and agree to the GitHub Docs project's Code of Conduct

What article on docs.github.com is affected?
https://docs.github.com/en/code-security/supply-chain-security/keeping-your-dependencies-updated-automatically/configuration-options-for-dependency-updates#package-ecosystem
What part(s) of the article would you like to see updated?

[1] Dependabot doesn't run Gradle but supports updates to the following files: build.gradle and build.gradle.kts (for Kotlin projects).

This is no longer precise, Dependabot can also update e.g. dependencies.gradle.
Additional information
https://github.com/dependabot/dependabot-core/pull/4155#issuecomment-918500360

@zbynek
Thanks so much for opening an issue! I'll triage this for the team to take a look :eyes:


Component not found

Hi,
In lsp mode inside nvim I get this error message:

but when I run "laravel-dev-tools views . > views-my-my.json" in the project root dir the component is listed in the .json file:
"common.components.pagination.index": "/home/michael/Code/staremesto/resources/views/common/components/pagination/index.blade.php",
How can I make the lsp detect the component too instead of giving me an error?

I'm experimenting the same issue.
Digging a bit, I'm getting the error when LSP is running

[ERROR][2024-10-24 10:25:17] .../vim/lsp/rpc.lua:770    "rpc"   "/home/clement/.local/share/laravel-dev-tools/builds/laravel-dev-tools" "stderr"    "PHP Fatal error:  Cannot redeclare Amp\delay() (previously declared in phar:///home/clement/.local/share/laravel-dev-tools/builds/laravel-dev-tools/vendor/amphp/amp/lib/functions.php:132) in /home/clement/Projects/test-lsp/vendor/amphp/amp/src/functions.php on line 81\n"

This can also be replicated by running the command
./laravel-dev-tools helpers /home/clement/Projects/test-lsp

It may not be related at all, but I think the server conflict with newer versions of Laravel.
I have spatie/laravel-data and rector/rector in the project.
Both use amphp/amp:v3.0 meanwhile laravel-dev-tools has the v1 in the dependencies through phpactor/language-server


pass rvalue reference to visitor when visiting an rvalue variant

Fixes #142
A note about the admittedly awkward syntax std::move(var).match(...)
This branch includes a change to apply_visitor which I forgot to put in a separate commit. Here's the deal:
mapbox::util::variant<int> v{42};
auto f = mapbox::util::make_visitor(
    [](int&) { std::cout << "lvalue\n"; },
    [](int&&) { std::cout << "rvalue\n"; });

mapbox::util::apply_visitor(f, v); // should print "lvalue"
mapbox::util::apply_visitor(f, std::move(v)); // should print "rvalue"

v.match(f); // what should this print?

Now, if you wanted this to work:
v.match([](int&&) { ... });

... you'd need to either
a) delegate to visit(std::move(*this), fn), which might have surprising behaviour (using the visitor from the above example, v.match(f) would print "rvalue"); or
b) implement special logic for this case that'd only std::move(stored_alternative) if the visitor doesn't accept it by lvalue
a) is basically  a design decision, and b) sounds non-trivial; so in order to keep it simple, I chose to do neither. Thence the required std::move(var).match(...) syntax.

Noticed I created this PR with the wrong target branch, and some test failures caused by changed diagnostics messages.
I've rebased the branch, moved changes to apply_visitor to a separate commit, and updated expected compilation failure messages.
There are two failing tests remaining:

clang 3.7 with an obscure ICE in Catch, I have no idea what's going on
gcc 4.7 which doesn't support ref-qualified member functions; I'd ditch it

👍  to ditching those versions @lightmare - as far as minimum compilers I think we should test on/maintain support for:

gcc 4.9
clang++ 5

Ad clang 3.7 ICE: that error is unrelated to this PR, and to variant code altogether. I've found another, older PR build failing in exactly the same way when compiling test/unit.cpp which only includes catch.hpp, nothing else. Perhaps

@lightmare
https://github.com/mapbox/variant/pull/180#issuecomment-656568987

@lightmare - explicit return type in visitor functor is useful in some circumstances. So looks like we need some SFINAE logic deducting return type:
diff --git a/include/mapbox/variant.hpp b/include/mapbox/variant.hpp
index e92f00f..7aedbcd 100644
--- a/include/mapbox/variant.hpp
+++ b/include/mapbox/variant.hpp
@@ -195,11 +195,35 @@ struct copy_cvref<Src&&, Dest>
     using type = Dest&&;
 };

+template <typename T, typename R = void>
+struct enable_if_type
+{
+    using type = R;
+};
+
+template <typename F, typename Enable = void>
+struct return_type_fun
+{
+    using type = void;
+    static constexpr bool value = false;
+};
+
+template <typename F>
+struct return_type_fun<F, typename enable_if_type<typename F::result_type>::type>
+{
+    using type = typename F::result_type;
+    static constexpr bool value = true;
+};
+
 template <typename F, typename T>
-using result_of_unary_visit = decltype(std::declval<F>()(std::declval<T>()));
+using result_of_unary_visit = typename std::conditional<return_type_fun<F>::value,
+                                                        typename return_type_fun<F>::type,
+                                                        decltype(std::declval<F>()(std::declval<T>()))>::type;

 template <typename F, typename T>
-using result_of_binary_visit = decltype(std::declval<F>()(std::declval<T>(), std::declval<T>()));
+using result_of_binary_visit = typename std::conditional<return_type_fun<F>::value,
+                                                         typename return_type_fun<F>::type,
+                                                         decltype(std::declval<F>()(std::declval<T>(), std::declval<T>()))>::type;

 template <type_index_t arg1, type_index_t... others>
 struct static_max;

/cc @springmeyer

https://github.com/mapbox/variant/pull/180/commits/b1076bbee3857a325288dcf8658b66d2063ade66

I agree that explicit result type may be useful. But I'm not entirely sure whether the above implementation with both explicit and deduced type in std::conditional doesn't defeat one of the benefits -- namely avoiding the guesswork required to deduce the return type. Maybe it doesn't touch the second type at all if the condition is true, I'm really not sure. Anyway, here's an alternative implementation that 100% doesn't try to deduce anything if there is result_type:
template <typename F, typename = void>
struct deduced_result_type
{};

template <typename F, typename... Args>
struct deduced_result_type<F(Args...), decltype((void)std::declval<F>()(std::declval<Args>()...))>
{
    using type = decltype(std::declval<F>()(std::declval<Args>()...));
};

template <typename F, typename = void>
struct visitor_result_type : deduced_result_type<F>
{};

// specialization for explicit result_type member in visitor class
template <typename F, typename... Args>
struct visitor_result_type<F(Args...), decltype((void)std::declval<typename std::decay<F>::type::result_type>())>
{
    using type = typename std::decay<F>::type::result_type;
};

template <typename F, typename T>
using result_of_unary_visit = typename visitor_result_type<F&&(T&&)>::type;

template <typename F, typename T>
using result_of_binary_visit = typename visitor_result_type<F&&(T&&, T&&)>::type;

Note: decltype((void)std::declval<typename std::decay<F>::type::result_type>()) could be contracted to void_t<std::decay_t<F>::result_type>, but I didn't want to C++11-mimic void_t just for that.
Here it is with a test, which was apparently missing:
https://github.com/mapbox/variant/commit/0ebf09deaec67318c9fb2595dcdf12826197c245

^^ Cool, I'll check it out, thanks @lightmare !


broken URL

Hi team,
there is a broken URL on this page. Could you please fix it.
Issue on page:        https://github.com/opentelekomcloud-docs/image-management-service/blob/main/umn/source/managing_private_images/converting_the_image_format_using_qemu-img-hw.rst
broken URL: https://obs-20181128.ims.obs.eu-de.otc.t-systems.com/DT-image-convert-tools.zip
BR Thies

Thank you for your report, ticket OCS-8940 was raised based on it.
We will inform you after the update.

.


Integrate Azure chatbot with Twilio

Hi
I have created a azure chatbot and have registered in dev.botframework. I am trying to integrate the chatbot with twilio channel. I have provided the required details such as twilio phonenumber, accnt id, auth token after following the steps in the https://docs.microsoft.com/en-us/bot-framework/channel-connect-twilio
I am able to use the SMS functionality using twilio. Does Azure chatbot only supports SMS as of now?I wanted to enable the calling functionality with twilio to the bot i have created.
It will be helpful if you guide me through.
Thanks in Advance!

At this time Bot Framework only supports the use of SMS with the Twilio channel.  At this time there is no roadmap to support voice.

Hi @YazhC, Can you pls. share code how you integrated chatbot with twilio. I am getting some issues.

hi i am also facing issue with twillio channel, can u please share the code of bot where u configure sms channel

i am facing issue with twillio channel, can you please share your code. any extra classes you added to make it work with sms channel.


RS-134: Use case AI workflows

This PR introduces two pages:

/use-cases: this page can be used to group all use cases on a single page
/use-cases/ai-workflows: this is the first use case: "Optimize Your AI Workflows" with a layout that can be used for all use cases: title, subtitle, image-text blocs, FAQ, and contact form

@atimin got some timeout issue with ReductStore, but the rest is ready.


Missing providers??

I just installed mov-cli on a second computer, but only the version installed on the first computer is showing kimcartoon and other providers.
pointblank@ao1-macbook ~ mov-cli

Movies and Shows:
theflix
actvid
sflix
solar
dopebox
ask4movie

Live TV:
eja
ustvgo / US IP ONLY

Cartoons:
kimcartoon

the installation on the other device only shows theflix, vidsrc, ejz, trailers, and ask4movie
this is my update / install function for zsh:
function mov-cli-update {
        sudo rm -rf /usr/local/bin/mov-cli
        git -C /tmp/ clone https://github.com/mov-cli/mov-cli
        cd /tmp/mov-cli/
        python3 setup.py build && sudo python3 setup.py install
        sudo rm -rf /tmp/mov-cli/
        cd ~
}

nevermind, i "just" needed to install python 3.10. this was a pain though. i hope it doesn't break anything else on my computer


Updating HNS v1 policy schemas with correct omitEmpty fields

Signed-off-by: elweb9858<EMAIL_ADDRESS>Several fields in the NatPolicy and AclPolicy v1 schema structs do not reflect the omitEmpty json field. This can be problematic in cases of integer fields because if the user does not specify a value for this field, it will be assigned a 0 during marshalling. In cases like protocol, a value of 0 is not something HNS recognizes so policy application will fail. This PR reflects all the omitEmpty fields properly in the hcsshim v1 policy schema structs (all v2 structs are currently up to date).

PTAL @negup @sbangari @Keith-Mange @vikas-bh

lgtm

@elweb9858 Are we ok to check this in? Any others we're waiting to take a look?

@dcantah  this is ok to check in


ADD SECTIONS NOT SHOWING

ALSO ON CREATING REPORT EXECUTIVE SUMMARY SHOWING BLANK

You need to add custom sections in the last tab on that page.

https://pwndoc-ng.github.io/pwndoc-ng/#/data?id=custom-sections


Not Mobile Friendly

If you change it to mobile mode you get the following:

Fixed in the next merge


Add more desktop notifications

This commit adds more desktop notifications and introduces
the gopass logo to these notifications.

Not exactly. This will cause a desktop notification when your clipboard gets auto-cleared (after the timeout expires).
This has two reasons: 1.) there is no other way to inform the user if this operation succeeded or not, i.e. if an error ocurs 2.) this feature was broken for quite some time and no one noticed due to 1.)


Expand pr bot to python

This starts running the pr bot on the python label. I did my best to come up with an initial set of reviewers to be round robined to, but it was mostly based on manual inspection. The bot should eventually update that list anyways.
Part of #21417

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[x] Mention the appropriate issue in your description (for example: "addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment "fixes #" instead.
[ ] Update CHANGES.md with noteworthy changes.
[x] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

R: @tvalentyn


Is there a way to keep the state tree open?

Is there a way to keep the state tree open?
every time a dispatch occurs, the entire state tree collapses.
I remember it used to stay open, did something break / change recently?
regards
Sean

bug fixed in today's update!


New Employee Training and Development

Issue Description: New Employee Training and Development
In line with my responsibilities as a part of the HR team, I will be taking on the crucial task of training new employees. This training aims to provide them with a solid foundation in understanding our company's culture and values, enabling them to seamlessly integrate into our work environment.
Training Components:
Company Culture:
I will guide new hires through an immersive experience that delves into our company's core values, mission, and vision. This will help them understand the ethos that drives our organization and fosters a sense of belonging.
Communication Skills:
Effective communication is a cornerstone of a successful workplace. I will work diligently to enhance the communication skills of our new team members, ensuring they can convey their ideas clearly and collaborate effectively.
Professional Etiquette:
Adeptness in professional etiquette is pivotal for a positive workplace environment. I will educate the new employees on best practices for workplace behavior, interactions, and decorum.
Daily Meeting Involvement: To provide practical exposure, I plan to integrate the new hires into our daily meetings. This will offer them insights into ongoing projects, team dynamics, and the collaborative nature of our work.
Interviewing Experience: New employees will also gain invaluable experience by participating in the interview process for potential candidates. This firsthand involvement will give them insights into our hiring standards and the qualities we value in potential team members.
Conflict Resolution: As part of their holistic development, I will touch upon conflict resolution techniques. This essential skill equips employees to navigate disagreements constructively and maintain a harmonious workplace.
Performance Feedback: I will provide guidance on how our performance review process works, ensuring new employees understand how their progress will be evaluated and how they can continually improve.
By addressing these aspects, the training aims to empower new employees with the knowledge and skills required to excel in their roles while contributing positively to our organization's growth. I am dedicated to fostering a supportive and learning-oriented environment, and I am excited to embark on this journey of developing our newest team members.

🛠 Work in Progress: New Employee Training and Development 🛠
Hello team,
I'm thrilled to announce that I've taken the initiative to drive the New Employee Training and Development program. As part of this initiative, I'll be focusing on nurturing a strong foundation for our new team members, ensuring they integrate seamlessly into our vibrant company culture.
Current Focus Areas:
Company Culture:
I'll be delving deep into our company's core values, mission, and vision, creating an immersive experience that fosters a sense of belonging.
Communication Skills:
Effective communication is key, and I'll be working diligently to enhance the new employees' ability to convey ideas clearly and collaborate effectively. Guiding our team in the art of professional conduct, interactions, and workplace decorum.
Daily Meeting Involvement: Providing practical exposure by integrating new hires into our daily meetings, showcasing ongoing projects and the collaborative essence of our work.
Interviewing Experience: New hires will also have the unique opportunity to participate in our interview process, gaining insights into our hiring standards and valued qualities.
Conflict Resolution: Equipping our team with conflict resolution techniques, fostering a harmonious workplace where disagreements are constructively addressed.
Performance Feedback: Guiding them through our performance review process, aiding them in understanding evaluation criteria and continuous improvement.
I'm dedicated to creating an enriching learning environment, and I can't wait to see our new team members flourish. This journey is not only about skill development but also about fostering a positive work ethos.
Stay tuned for further updates as I continue to shape this program to empower our newest members. Your feedback and suggestions are always welcome!

Today, my primary objective is to conduct interviews for potential candidates to join our internal teams. I have already gathered a pool of candidates and am prepared with the necessary questions and materials. I aim to complete the interviews within a time frame of 2 hours. I have to give training to our new teammate.


Unable to update Text on Simple layout....

Describe the bug
I'm unable to update the text in a simple text box on screen. I've been trying to follow other code but just not able to get it to change.
Device hardware

MCU: ?ESP32
Display with link: https://www.amazon.com/gp/product/B07KPD4DHD/ref=ppx_yo_dt_b_asin_title_o02_s00?ie=UTF8&psc=1
GUIslice config selected: `  #include "../configs/esp-tftespi-default-notouch.h"

Checklist to try first
Most display/touch issues can be identified by working through the steps in the Configuring GUIslice guide.
Please confirm whether:

Display works correctly with standalone display driver library examples (eg. TFT_eSPI graphicstest, Adafruit graphicstest, etc.) without GUIslice:  Turns on and displays layout...can't make changes to the text....

Touch works correctly with standalone touch library examples without GUIslice: Touch is not hookked up at this time..

Expected behavior
I expect text to change when I update it...
Initialization messages
Please copy any startup messages / errors reported to the serial monitor window here. You can enable all error messages by setting DEBUG_ERR 2 in the GUIslice config file. WHERE? I don't see iit in the config file.....
Additional info
Creation code....
pElemRef = gslc_ElemCreateTxt(&m_gui,E_ELEM_TEXT1,E_PG_MAIN,(gslc_tsRect){3,8,132,26},
    (char*)"9:12:12",0,E_FREESANSBOLD18);

  gslc_ElemSetTxtMargin(&m_gui,pElemRef,10);
  gslc_ElemSetCol(&m_gui,pElemRef,((gslc_tsColor){150,150,150}),GSLC_COL_BLACK,GSLC_COL_BLACK);
  gslc_ElemSetTxtEnc(&m_gui,pElemRef,GSLC_TXT_ENC_UTF8);
```
`
ESSP32 loop code..

`
```
void loop()
{

  // ------------------------------------------------
  // Update GUI Elements
  // ------------------------------------------------
  char mytime[] = "00:00:00";
  //char carray[8] = "       ";
  delay(4000);
  gslc_tsElemRef*  pElem  = gslc_PageFindElemById(&m_gui,E_PG_MAIN,E_ELEM_TEXT1);
  gslc_ElemSetTxtStr(&m_gui, pElem, "0");

  delay(6000);
  // ------------------------------------------------
  // Periodically call GUIslice update function
  // ------------------------------------------------
  gslc_Update(&m_gui);

}
```
`

@bostonmacosx You need to begin by assigning storage to the text field you want to modify at runtime.
Otherwise you are trying to store a new string into the flash const.
Inside the builder for E_ELEM_TEXT1 set the property "External Storage Size
" equal to the largest string you want to use.  The Builder will assign one more than youy ask for to account for the needed trailing null character '\0'.  You should use the very lastest builder 0.16.b002 since I just fixed a sizing bug in this area.
Paul--

@bostonmacosx — I will presume that the above setting works for you. However, if you still encounter a problem, please feel free to update this issue and I will reopen it for you. Thanks


change file extension to .xls issue#120

Change file extension to .xls in convert view for spreadsheets. Fix issue #120.

LGTM. Merging.


[1.3] Energy EVSE Cluster XML has to be updated as per spec changes

Description
XML has to be updated as per spec:
Max range(80000) has been removed from the spec for below mentioined attributes and commands. So the XML has to be updated with removing those things.
Attributes:

CircuitCapacity
MinimumChargeCurrent
MaximumChargeCurrent
MaximumDischargeCurrent

Commands:

EnableCharging
EnableDischarging
EnergyTransferStarted

Specification Reference: https://github.com/CHIP-Specifications/connectedhomeip-spec/blob/master/src/app_clusters/EnergyEVSE.adoc#attributes

Issue fixed


nvjpeg memory allocation failure

Hi,
I ran into an issue that the pretraining script crashes after 8.5 epochs due to an allocation failure. I am guessing there might be a memory leak somewhere.
Details:

Nvidia Titan V GPU (12GB)
Using Nvidia Dali
commit 85b888a622ff08fcf7843c28a47f6bde51b089c6 (i will do another pull, rerun and post the result, just to be sure.)
arguments: python3 main_pretrain.py     --dataset imagenet     --encoder resnet50     --data_dir /data     --train_dir imagenet/train     --val_dir imagenet/val     --max_epochs 100     --gpus 0     --distributed_backend ddp     --sync_batchnorm     --precision 16     --optimizer sgd     --scheduler warmup_cosine     --lr 0.5     --classifier_lr 0.1     --weight_decay 1e-5     --batch_size 48     --num_workers 12     --brightness 0.4     --contrast 0.4     --saturation 0.4     --hue 0.1     --zero_init_residual     --name simsiam-resnet50-100ep-imagenet  --dali     --entity tomsal     --project solo-learn     --wandb     --method simsiam     --proj_hidden_dim 2048     --pred_hidden_dim 512 --output_dim 2048 --amp_level O2 --log_gpu_memory all
I did disable the val_loader for unrelated reasons (by val_loader = None just before line 159). No other changes were made.

The error I get is the following:
GPU available: True, used: True
TPU available: False, using: 0 TPU cores
Using native 16bit precision.
~/miniconda3/envs/solo-learn/lib/python3.6/site-packages/pytorch_lightning/trainer/configuration_vali
dator.py:101: UserWarning: you defined a validation_step but have no val_dataloader. Skipping val loop
  rank_zero_warn(f'you defined a {step_name} but have no {loader_name}. Skipping {stage} loop')
Global seed set to 5
initializing ddp: GLOBAL_RANK: 0, MEMBER: 1/1
----------------------------------------------------------------------------------------------------
distributed_backend=nccl
All DDP processes registered. Starting ddp with 1 processes
----------------------------------------------------------------------------------------------------

LOCAL_RANK: 0 - CUDA_VISIBLE_DEVICES: [0]

  | Name       | Type       | Params
------------------------------------------
0 | encoder    | ResNet     | 23.5 M
1 | classifier | Linear     | 2.0 M
2 | projector  | Sequential | 12.6 M
3 | predictor  | Sequential | 2.1 M
------------------------------------------
40.2 M    Trainable params
2.0 K     Non-trainable params
40.3 M    Total params
161.002   Total estimated model params size (MB)
Global seed set to 5
read 1281167 files from 1000 directories
Epoch 8:  50%|████████████████                | 13369/26690 [1:55:18<1:54:53,  1.93it/s, loss=3.67, v_num=ok1z]
Traceback (most recent call last):
  File "main_pretrain.py", line 136, in <module>
    main()
  File "main_pretrain.py", line 130, in main
    trainer.fit(model, val_dataloaders=val_loader)
  File "~/miniconda3/envs/solo-learn/lib/python3.6/site-packages/pytorch_lightning/trainer/trainer.py
", line 460, in fit
    self._run(model)
  File "~/miniconda3/envs/solo-learn/lib/python3.6/site-packages/pytorch_lightning/trainer/trainer.py
", line 758, in _run
    self.dispatch()
  File "~/miniconda3/envs/solo-learn/lib/python3.6/site-packages/pytorch_lightning/trainer/trainer.py
", line 799, in dispatch
    self.accelerator.start_training(self)
  File "~/miniconda3/envs/solo-learn/lib/python3.6/site-packages/pytorch_lightning/accelerators/accel
erator.py", line 96, in start_training
    self.training_type_plugin.start_training(trainer)
  File "~/miniconda3/envs/solo-learn/lib/python3.6/site-packages/pytorch_lightning/plugins/training_t
ype/training_type_plugin.py", line 144, in start_training
    self._results = trainer.run_stage()
  File "~/miniconda3/envs/solo-learn/lib/python3.6/site-packages/pytorch_lightning/trainer/trainer.py
", line 809, in run_stage
    return self.run_train()
  File "~/miniconda3/envs/solo-learn/lib/python3.6/site-packages/pytorch_lightning/trainer/trainer.py
  ", line 871, in run_train
    self.train_loop.run_training_epoch()
  File "~/miniconda3/envs/solo-learn/lib/python3.6/site-packages/pytorch_lightning/trainer/training_l
oop.py", line 491, in run_training_epoch
    for batch_idx, (batch, is_last_batch) in train_dataloader:
  File "~/miniconda3/envs/solo-learn/lib/python3.6/site-packages/pytorch_lightning/profiler/profilers
.py", line 112, in profile_iterable
    value = next(iterator)
  File "~/miniconda3/envs/solo-learn/lib/python3.6/site-packages/pytorch_lightning/trainer/supporters
.py", line 534, in prefetch_iterator
    for val in it:
  File "~/miniconda3/envs/solo-learn/lib/python3.6/site-packages/pytorch_lightning/trainer/supporters
.py", line 464, in __next__
    return self.request_next_batch(self.loader_iters)
  File "~/miniconda3/envs/solo-learn/lib/python3.6/site-packages/pytorch_lightning/trainer/supporters
.py", line 478, in request_next_batch
    return apply_to_collection(loader_iters, Iterator, next)
  File "~/miniconda3/envs/solo-learn/lib/python3.6/site-packages/pytorch_lightning/utilities/apply_fu
nc.py", line 85, in apply_to_collection
    return function(data, *args, **kwargs)
  File "~/Code/solo-learn/solo/methods/dali.py", line 59, in __next__
    batch = super().__next__()
  File "~/miniconda3/envs/solo-learn/lib/python3.6/site-packages/nvidia/dali/plugin/pytorch.py", line
 194, in __next__
    outputs = self._get_outputs()
  File "~/miniconda3/envs/solo-learn/lib/python3.6/site-packages/nvidia/dali/plugin/base_iterator.py"
, line 255, in _get_outputs
    outputs.append(p.share_outputs())
  File "~/miniconda3/envs/solo-learn/lib/python3.6/site-packages/nvidia/dali/pipeline.py", line 863,
in share_outputs
    return self._pipe.ShareOutputs()
RuntimeError: Critical error in pipeline:
Error when executing Mixed operator decoders__Image encountered:
Error in thread 2: [/opt/dali/dali/operators/decoder/nvjpeg/nvjpeg_decoder_decoupled_api.h:917] NVJPEG error "5
" : NVJPEG_STATUS_ALLOCATOR_FAILURE n02447366/n02447366_33293.jpg
Stacktrace (7 entries):
[frame 0]: ~/miniconda3/envs/solo-learn/lib/python3.6/site-packages/nvidia/dali/libdali_operators.so(
+0x4cbbee) [0x7efc6c55dbee]
[frame 1]: ~/miniconda3/envs/solo-learn/lib/python3.6/site-packages/nvidia/dali/libdali_operators.so(
+0x87a63b) [0x7efc6c90c63b]
[frame 2]: ~/miniconda3/envs/solo-learn/lib/python3.6/site-packages/nvidia/dali/libdali_operators.so(
+0x87aa2e) [0x7efc6c90ca2e]
[frame 3]: ~/miniconda3/envs/solo-learn/lib/python3.6/site-packages/nvidia/dali/libdali.so(dali::Thre
adPool::ThreadMain(int, int, bool)+0x1f0) [0x7efc6b5ed330]
[frame 4]: ~/miniconda3/envs/solo-learn/lib/python3.6/site-packages/nvidia/dali/libdali.so(+0x70718f)
 [0x7efc6bb9f18f]
[frame 5]: /lib/x86_64-linux-gnu/libpthread.so.0(+0x76db) [0x7efd013b96db]
[frame 6]: /lib/x86_64-linux-gnu/libc.so.6(clone+0x3f) [0x7efd010e2a3f]

Current pipeline object is no longer valid.

After I ran into this the first time, I reran it with GPU memory logging. This is the plot I get:

I am a bit confused that there is an increase after 3.5k steps (from 11979 GB to 1201GB). Let me know in case, I should provide more logs, or so.
P.S.: Great work! It is a pleasure to work with! :)

Are you running on a single GPU with 12GB memory? I doubt you can fit an imagenet run on that setup.
In our experiments after some time the memory usage stabilizes, so it's unlikely that this is due to a memory leak. More probably it is due to automatic mixed precision (some param groups might jump from precision 16 to precision 32) or to some internal functioning of Dali that I am not sure about.

Yes, I am running it on a single GPU with 12 GB memory, but as you correctly noted with batch size 48. I am aware that in terms of training results this not an ideal setup. It is still good enough for debugging code before going on a multi gpu cluster, I'd say. :)
I will try out the workers, and I am aware that, in general, this is not a major issue. Still, I thought it is good to let you know about this.

Just to add on what @DonkeyShot21 said, DALI's memory usage scales with the number of workers. Every 4 workers per gpu would add an overhead of ~3gb after it stabilizes. I'm not really sure why memory increases after some epochs, because it should stay pretty much the same since we pre-allocate a buffer here https://github.com/vturrisi/solo-learn/blob/532e9a516b1253c86149a01812e81dfe2bd729df/solo/utils/dali_dataloader.py#L187.
According to DALI docs (https://docs.nvidia.com/deeplearning/dali/user-guide/docs/supported_ops.html?highlight=host_memory_padding) this should be enough, but we always experienced a small increase in memory usage until ~epoch 60.

Ok, thanks, that's great info! So deactivating DALI should also work out, I guess? I have to admit that I didn't really take DALI into the equation when scaling up the workers.

Yes, if you turn DALI off you will save ~3gbs of memory (when using 4 workers) but you will run around 50% slower. If you scale the workers a lot, I think you can get good performance, but you will use a lot of ram.


Variable digits

@gbalabasquer @dbrock left some feedback if you didn't get a notification for this PR

In general I'd like more comments and we should start talking about creating a Maker Market test suite


DataGrid OnCellPointerPressed not respecting e.Handled

In version 8.x, I added a DataGrid event handler so that left clicking a selected DataGrid cell would deselect the row. This did require some slightly hacky behavior due to the DataGrid not respecting setting the e.Handled (which is the case for both 0.8 and 0.9). The specific hack is to set the MouseButton to None. However, that option isn't available in 0.9 since the MouseButton is now a readonly property.
Would it be possible to add some better handling for the event?
Code to unselect a selected row
private void DataGrid_CellPointerPressed(object sender, DataGridCellPointerPressedEventArgs e)
		{
			DataGridRow row = e.Row;
			if (e.PointerPressedEventArgs.MouseButton == MouseButton.Left && row != null && dataGrid.SelectedItems != null && dataGrid.SelectedItems.Count == 1)
			{
				if (dataGrid.SelectedItems.Contains(row.DataContext))
				{
					// need both of these
					dataGrid.SelectedItems.Clear();
					dataGrid.SelectedItem = null;

					// parent function doesn't check Handled, but does check MouseButton = MouseButton.Left
					e.PointerPressedEventArgs.Handled = true;
					e.PointerPressedEventArgs.MouseButton = MouseButton.None;
				}
			}
		}

The DataGrid code for this
private void DataGridCell_PointerPressed(PointerPressedEventArgs e)
        {
            // OwningGrid is null for TopLeftHeaderCell and TopRightHeaderCell because they have no OwningRow
            if (OwningGrid != null)
            {
                OwningGrid.OnCellPointerPressed(new DataGridCellPointerPressedEventArgs(this, OwningRow, OwningColumn, e));
                if (e.MouseButton == MouseButton.Left)
                {
                    if (!e.Handled)
                    //if (!e.Handled && OwningGrid.IsTabStop)
                    {
                        OwningGrid.Focus();
                    }
                    if (OwningRow != null)
                    {
                        e.Handled = OwningGrid.UpdateStateOnMouseLeftButtonDown(e, ColumnIndex, OwningRow.Slot, !e.Handled);
                        OwningGrid.UpdatedStateOnMouseLeftButtonDown = true;
                    }
                }
            }
        }

I tried adding a check for e.Handled, and that didn't restore that functionality. It looks like my previous hack of setting the mouse button to none was also affecting the DataGridRow_PointerPressed(), which there's not really a mechanism for overriding the behavior for. So I don't really see a good way of adding back this behavior.
This might also have been useful for button cells that serve as delete buttons, but not change the row focus when they're clicked, which I I'm also currently using in my project. I haven't tried adding that nofocus behavior yet, but it would be useful due to row selections triggering long reloads.

I found a workaround for this with a delayed dispatch message.


Thanos returns result with missing sample in long range

Thanos, Prometheus and Golang version used
Thanos: v0.3.2
Prometheus: 2.8.0
No custom changes

What happened
There are 2 prometheus as HA. Thanos sidecar is attached to both prometheus.
the below is example metric last 24 hours.(long range)

some samples seem to be dropped. But if I narrow the range to see more detail,

It shows correct samples.
Can I know why thanos returns no result in case of first situation?
I added options as the below( I'm using prometheus-operator)

--log.level=info
--query.replica-label=prometheus_replica
--no-query.partial-response

The prometheus is global. it federates local prometheus.
               +--> Global Prom 1 ----+                +--> Local Prom 1(replica-label=prometheus-0)
Thanos Query --|                      |----> |SVC| --- |
               +--> Global Prom 2 ----+                +--> Local Prom 2(replica-label=prometheus-1)

Thank you.
What you expected to happen
How to reproduce it (as minimally and precisely as possible):
Full logs to relevant components

Anything else we need to know

I think global-prometheus should remove replica_label when scraping. the mixed label values seem make this issue.

Hi, sorry for the delay. Did you manage to resolve the issue?

@gangseok514 is this still relevant on the newest version? There have been some fixes regarding this.

I am very sorry, I missed github mail.
the problem is already solved by remove replicas_label when federating like
metric_relabel_configs:
  - regex: ^(prometheus_replica|prometheus)$
    action: labeldrop

Thanks anyway!


adding broker ui to port forwarding

@timclifford / @tobybellwood is this PR still required?

yes, no harm in it for workflow purposes

closing in favor of #384


program_medications response

added additional field

Changes Unknown when pulling 9e0ae78ddc40740ea1f82407731c556e0ab2cfda on program_medication_schemas_2 into ** on master**.

it's already done


[CognitiveServices] LUIS Runtime SDK

https://github.com/Azure/azure-rest-api-specs/pull/2051

Description

This checklist is used to make sure that common guidelines for a pull request are followed.

[x] Please add REST spec PR link to the SDK PR
[x] I have read the contribution guidelines.
[x] The pull request does not introduce breaking changes.

General Guidelines

[x] Title of the pull request is clear and informative.
[x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[x] Pull request includes test coverage for the included changes.

SDK Generation Guidelines

[x] If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
[x] The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
[x] The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

@azuresdkci retest this please


trying to acess an empty image?

dorker@pop-os:~/midiplayer/build$ ./midiplayer play Addict_-_Hazbin_Hotel.mid
./midiplayer (MIDIPlayer) dev (Apr  5 2024 01:18:49)
INFO: Resource path: /usr/local/share/midiplayer
INFO: Shaders loaded
INFO: Font loaded
INFO: Textures loaded
WARNING: No display font is specified. Using debug font.
INFO: Config file successfully reloaded from config.cfg
Failed to load image "/usr/local/share/midiplayer/icon32.png". Reason: Unable to open file
Trying to access the pixels of an empty image
X Error of failed request:  BadValue (integer parameter out of range for operation)
Major opcode of failed request:  53 (X_CreatePixmap)
Value in failed request:  0x0
Serial number of failed request:  169
Current serial number in output stream:  176

Did you run sudo make install (then you should be able to use just midiplayer)?
Or just build with -DMIDIPLAYER_PORTABLE_INSTALL=1 and then just ./midiplayer should work

yes i did. its trying to enter an empty image. its nothing with the build.
dorker@pop-os:~$ cd Downloads/
dorker@pop-os:~/Downloads$ midiplayer play midis_MyOrdinaryLife.mid
midiplayer (MIDIPlayer) dev (Apr  5 2024 16:43:12)
INFO: Resource path: /usr/local/share/midiplayer
INFO: Shaders loaded
INFO: Font loaded
INFO: Textures loaded
WARNING: Failed to setup watch for config.cfg: No such file or directory
WARNING: No display font is specified. Using debug font.
Failed to load image "/usr/local/share/midiplayer/icon32.png". Reason: Unable to open file
Trying to access the pixels of an empty image
X Error of failed request:  BadValue (integer parameter out of range for operation)
Major opcode of failed request:  53 (X_CreatePixmap)
Value in failed request:  0x0
Serial number of failed request:  169
Current serial number in output stream:  176
dorker@pop-os:~/Downloads$

oops my bad. just place some random 32x32 png image there, should work for now while I fix this

do i provide a soundfont since it dosent play sounds?

There is no support for instrument plugins/soundfonts yet.
You could

specify a -m 0 flag (midiplayer -m 0 play something.mid)
open some DAW and set "Midi Through" as MIDI input

I got this working with pipewire and LMMS.

In (at least) pipewire you should be able to connect these directly

I don't know if this will work in pulseaudio.

Obviously, if you have some real MIDI device which can play sound, you can specify it as -m argument too (run midiplayer list-midi-devices for which number you need to enter there)


Can't put Global Search in panel anymore

VSCode Version:

Version: 1.46.1
Commit: cd9ea6488829f560dc949a8b2fb789f3cdc05f5d
Date: 2020-06-17T21:17:14.222Z (1 day ago)
Electron: 7.3.1
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Darwin x64 18.7.0

OS Version: OS X 10.14.6

Steps to Reproduce:

I had configured to put the global search to appear in the panel (right or bottom) instead of the side bar (left)
Since the update 1.46, it appears in my left side bar instead of the panel and I can't find the settings anymore to put it back in the panel

Does this issue occur when all extensions are disabled?: Yes/No

For future reference: https://stackoverflow.com/questions/50058584/vs-code-toggle-search-icon-in-activity-bar-move-from-panel-or-back


Handling nodes with same ID

Is your feature request related to a problem? Please describe.
It can happen (as it did before for MIMIC dataset) that some concepts pertaining to different classes (like procedures and diagnosis) might have the same node ID. We should address this somehow.
For now, the user will just receive an Error Warning saying that the node ID is already in the MedRecord. That might prone to some extra time of realising that the data itself create this problem and is not a case of misuse from the user (the node was already added).
Should we leave this realisation up to the user? Or should we implement some contingency plan to remind them of making sure all added Node IDs should have different names?
Describe the solution you'd like
We could add an Optional argument to the add_nodes function, that allows for adding Nodes with the same ID and creates a prefix/suffix automatically, indicating in a returned dictionary what the mapping looks like.
Code Example (if applicable)
No response
Additional context
No response

No need for this. Node IDs should be unique.


Bug: Search issues does not work and stalls all network requests. Also searching for updates causes all network requests to stall.

Expected Behavior
Searching for issues should work. Such as searching for chronos app updates. ;)
Actual Behavior
It does not. The network requests are stalled and the app is not usable afterwards any more (no more network requests get through), if either any search term for the issues is entered, or if Settings / Updates is opened.
Steps to Reproduce the Problem

Enter any search term to search issues
No more network requests are working

Specifications

Chronos-timetracker version: 2.5.11
OS: Windows 10

@feldifux Fixed

in which version?


[csharp02 - ValueReference] Documentation

Do we really need the code in the README.md file?
I don't think is a good idea just to put some code there without explaining it step-by-step so my suggestion would be either remove it (the best option) or comment it line by line (which not the case, because it's already explained what this project does)

I have created the https://github.com/microsoft-dx/csharp-fundamentals/tree/documentation-cleanup branch because there are more README.md files with the same problem


TeX formulas in chart elements

Hello Tim,
I guess this is more of a comment/proposal than an issue...
Something I always wanted is a plotting package that supports the use of professionally-looking mathematical elements for plot axes, legends etc. Since I could not find anything suitable (even professional tools do not offer this), I started out about 2 weeks ago to marry forks of XChart and JLatexMath to get this working. The main features I had in mind are

the possibility to replace axis labels, legends, and chart titles by TeX-formated math elements ("$...$"),
the use of proper minus signs in numerical values (turned out to be easy),
the use of standard TeX fonts (Computer Modern) for axis tick labels.

I am attaching an example below. I also added PDF output with iText (which I regularly use).
What was originally intended for personal use only ended up in quite some coding work, so I decided to put a preliminary version online (http://sourceforge.net/projects/jtexxchart/). However, if you like the idea and there is interest to merge this into the main XChart distribution, I'd be happy to contribute. Please let me know what you think about this.
--Wilhelm
Example output:

I love the idea!
XChart already uses a different lib for PDF export that also exports SVG and EPS. So ideally that would just continue to work.

Great! Let me know how you would like to proceed.
Actually the choice of the PDF exporter is no real issue as long as it provides an AWT-compatible Graphic2D. I looked at VectorGraphics2D initially and liked its simplicity very much but also noticed two problems with its EPS and PDF output:

Font embedding does not seem to work properly and causes viewers to throw errors. This is not an issue as long as text is rendered as shape outlines. (I thus proposed to the JLatexMath developers to adopt my changes for rendering outline text only.)
Apparently VectorGraphics2D does not specifiy a default color profile for viewing. This creates problems with Acrobat X+ by rendering wrong colors. The same happens when converting a VectorGraphics2D-created EPS to PDF with Adobe Distiller.

Those are the primary reasons for continuing with iText, which is very mature. However it is not free for commercial applications.
--Wilhelm

Awesome! How to proceed... I'm working on 3.0.0, which is  a pretty major refactor and the code is a bit of a mess. On the one hand, it'd be good for you to work off of that branch (I can commit it if you prefer option). Or you could just add to the current develop branch. Then later I'll need to manually merge your code into 3.0.0. How big are the changes.
I think it's important to keep this and all dependencies commercial-friendly. We could always submit a feature request at VectorGraphics2D or even submit a PR with a fix if it's easy.

This is not an issue as long as text is rendered as shape outlines.

That's the way to go. Hopefully they accept your changes. What license does JLatexMath have?

Most of the changes to XChart relate to the drawing of text, calculating dimensions and render positions. I am attaching a screenshot below that lists all modified and new files. All (OK, most) modifications in the code are marked "wilbur" and there is also a new package with that name which contains all new files. Please just browse the code (which I just cleaned up) in http://sourceforge.net/p/jtexxchart/code/HEAD/tree/trunk/xchart/src/main/java/imagingbook/other/xchart/ to see the scope of the modifications. Generally I suggest to add this functionality to version 3.0.0 once it is close to being finished, but perhaps some of the anticipated changes could be considered right away. I'd be happy to edit and commit myself -- if you permit ;-).
One more comment regarding vector output: I agree that outline text rendering solves many - if not all - font-related problems. However, some people (including myself if required) still use the old-fashioned DVI-PS-PDF LaTeX  workflow in combination with the popular 'psfrag' literal text replacement in EPS files. There is no working substitute for PDF's yet and (e.g.) EPS output by recent Mathematica releases has become completely useless for this purpose -- a real nightmare! Thus I think it would be quite helpful to (at least optionally) have standard font inclusion and rendering too. And it should not be too hard to do either.
--Wilhelm
XChart modifications by "wilbur":

I took a quick look and the changes seem pretty minimal, which is nice! I'll push the new 3.0.0 branch in a few days from now. I suggest doing it in two stages 1) just integrate jlatexmath and get it rendering on screen. 2) Get VectorGraphics2D working (or other options you've mentioned).
Note that jlatexmath 1.0.2 is available on Maven Central but not the newest version: http://mvnrepository.com/artifact/org.scilab.forge/jlatexmath
A PR is preferred as it is a wonderful way to do a changes review and comment back and forth on specifics. It's the path of least resistance and saves the most time.

Actually this is kind of a big issue: https://www.apache.org/licenses/GPL-compatibility.html

We avoid GPLv3 software because merely linking to it is considered by the GPLv3 authors to create a derivative work. We want to honor their license. Unless GPLv3 licensors relax this interpretation of their own license regarding linking, our licensing philosophies are fundamentally incompatible. This is an identical issue for both GPLv2 and GPLv3.

What are your thoughts?

The plan is perfectly fine with me, and VectorGraphics2D does work with the current setup.
I had downloaded (and modified) JLatexMath 1.0.3 from https://forge.scilab.org/index.php/p/jlatexmath/ . Unfortunately I am quite ignorant about licensing issues (should take a course maybe?). Is this of any help?: https://forge.scilab.org/index.php/p/jlatexmath/issues/1566/

OK, we can do this, but there is some ground work to be taken care of first.

They need to add the part about "GPL with classpath
exception" to their LICENSE: https://github.com/opencollab/jlatexmath/blob/master/LICENSE, as mentioned here. Until that exists, the license is incompatible with XChart's. Here's what theya re talking about: https://en.wikipedia.org/wiki/GPL_linking_exception
They need to incorporate your changes into their code.
Once that is done, we need a jar on Maven Central. They have an open issue for that here:https://forge.scilab.org/index.php/p/jlatexmath/issues/1293/

After that, we're good to go and add your code into XChart. Since you have already made contact with them, it'd be great if you could follow up with them on the above issues. I'd love to see this work out!

OK, I will contact the JLatexMath people again to clarify these issues. I wonder how other projects incorporating JLatexMath (e.g., SciLab, Geogebra ...) handle this problem.

Looks like those two are GPL licensed, so no problem.
The main problem people/companies have with GPL is that if their proprietary app uses GPL libs, then they must also provide their app under the same license. That means they'd have to give the source code to their app if asked for. That's a major issue for companies making software, and why I chose Apache 2.0 for XChart. Companies can use XChart in their apps and not need to also open source their projects. For XChart that means potentially more contributors compared to similar libs licensed under a more restrictive license.
I'm not against GPL by any means, and think it's the right choice for a lot of projects.
Also, a fun side note is that if I wanted to change the license of XChart, I couldn't without the consent of all the people who contributed to XChart, because we all share copyright to the project and only the copyright holder(s) can change the license.

Just a quick update: To keep things simple I reverted the vector export in my code to 'VectorGraphics2D' so there is no more dependency on 'iText'. As mentioned, the problem with the missing PDF output profile remains and I have not idea how to fix this in VectorGraphics2D. An example is given below. SVG and EPS seem to render OK.
PNG Output with VectorGraphics2D (OK):

PDF export with VectorGraphics2D when viewed with Adobe Acrobat X (and exported to PNG again):

Excellent! OK, so what's the problem with PDF exactly? Just the colors or something else as well?
If we can clearly show the problems with PDF vs. EPS and SVG, then we can post an issue on: https://github.com/eseifert/vectorgraphics2d
How's the progress on the licensing issue? Are there any threads I could help "poke" and move the issue forward?

Apart from the color problem (missing viewer profile) I suspect that PDF font embedding does not work properly (throws "bad character box" errors in Acrobat). It can be avoided if outline-only text rendering is used.
I had no time to follow-up the licensing issue yet. Will check...


enabling https proxy properties

Addressing issue #360

I signed it!

Thanks, @danielribeiro!

Awesome/thank you/congrats!!

Thank you @mattwhisenhunt !


self_assume_role var.role_name is null

Description
Please provide a clear and concise description of the issue you are encountering, and a reproduction of your configuration (see the examples/* directory for references that you can copy+paste and tailor to match your configs if you are unable to copy your exact configuration). The reproduction MUST be executable by running terraform init && terraform apply without any further changes.
If your request is for a new feature, please use the Feature request template.

[X] ✋ I have searched the open/closed issues and my issue is not listed.

⚠ Note
Versions

Module version [Required]: v5.5

Terraform version:
terraform -v
Terraform v1.2.9
on darwin_arm64

provider registry.terraform.io/gavinbunney/kubectl v1.14.0
provider registry.terraform.io/hashicorp/aws v4.32.0
provider registry.terraform.io/hashicorp/cloudinit v2.2.0
provider registry.terraform.io/hashicorp/helm v2.6.0
provider registry.terraform.io/hashicorp/http v3.1.0
provider registry.terraform.io/hashicorp/kubernetes v2.13.1
provider registry.terraform.io/hashicorp/null v3.1.1
provider registry.terraform.io/hashicorp/random v3.4.3
provider registry.terraform.io/hashicorp/time v0.8.0
provider registry.terraform.io/hashicorp/vault v3.8.2
provider registry.terraform.io/terraform-aws-modules/http v2.4.1

Reproduction Code [Required]
module "argocd_iam_role_sa_cross_cluster" {
  source  = "terraform-aws-modules/iam/aws//modules/iam-role-for-service-accounts-eks"
  version = "~> v5.5"

  role_name_prefix       = substr("${var.addon_context.eks_cluster_id}-argocd-sts-", 0, 38)
  max_session_duration   = "3600"
  force_detach_policies  = true
  allow_self_assume_role = true

  oidc_providers = {
    argocd = {
      provider_arn = var.addon_context.eks_oidc_provider_arn
      namespace_service_accounts = [
        "${var.namespace}:argocd-application-controller",
        "${var.namespace}:argocd-server",
      ]
    }
  }
}

Expected behavior
for a role to be created
Actual behavior
│ Error: Invalid template interpolation value
│
│   on .terraform/modules/base_system.argocd.argocd_iam_role_sa_cross_cluster/modules/iam-role-for-service-accounts-eks/main.tf line 24, in data "aws_iam_policy_document" "this":
│   24:         identifiers = ["arn:${local.partition}:iam::${local.account_id}:role${var.role_path}${var.role_name}"]
│     ├────────────────
│     │ var.role_path is null
│
│ The expression result is null. Cannot include a null value in a string template.
╵
╷
│ Error: Invalid template interpolation value
│
│   on .terraform/modules/base_system.argocd.argocd_iam_role_sa_cross_cluster/modules/iam-role-for-service-accounts-eks/main.tf line 24, in data "aws_iam_policy_document" "this":
│   24:         identifiers = ["arn:${local.partition}:iam::${local.account_id}:role${var.role_path}${var.role_name}"]
│     ├────────────────
│     │ var.role_name is null
│
│ The expression result is null. Cannot include a null value in a string template.
╵

Additional context
related to https://github.com/terraform-aws-modules/terraform-aws-iam/pull/281
cc @bryantbiggs

modified the module a bit
module "argocd_iam_role_sa_cross_cluster" {
  source  = "terraform-aws-modules/iam/aws//modules/iam-role-for-service-accounts-eks"
  version = "~> v5.5"

  # role_name_prefix       = substr("${var.addon_context.eks_cluster_id}-argocd-sts-", 0, 38)
  role_name              = substr(random_id.suffix.hex, 0, 64)
  max_session_duration   = "3600"
  force_detach_policies  = true
  allow_self_assume_role = true
  role_path              = "/"

  oidc_providers = {
    argocd = {
      provider_arn = var.addon_context.eks_oidc_provider_arn
      namespace_service_accounts = [
        "${var.namespace}:argocd-application-controller",
        "${var.namespace}:argocd-server",
      ]
    }
  }
}

used role_name instead of role_name_prefix
added role_path (shouldn't "/" be the default in the variables.tf ? )
this module generated the following policy
"argocd_iam_role_sa_cross_cluster" = {
"data_aws_iam_policy_document" = [
    {
    "id" = "3350686316"
    "json" = <<-EOT
    {
        "Version": "2012-10-17",
        "Statement": [
        {
            "Sid": "ExplicitSelfRoleAssumption",
            "Effect": "Allow",
            "Action": "sts:AssumeRole",
            "Principal": {
            "AWS": "arn:aws:iam::360093697111:role/argocd-sts-c03686ae5f06138e"
            }
        },
        {
            "Sid": "",
            "Effect": "Allow",
            "Action": "sts:AssumeRoleWithWebIdentity",
            "Principal": {
            "Federated": "arn:aws:iam::360093697111:oidc-provider/oidc.eks.us-east-1.amazonaws.com/id/XXXX"
            },
            "Condition": {
            "StringEquals": {
                "oidc.eks.us-east-1.amazonaws.com/id/XXXX:aud": "sts.amazonaws.com",
                "oidc.eks.us-east-1.amazonaws.com/id/XXXX:sub": [
                "system:serviceaccount:argocd-system:argocd-application-controller",
                "system:serviceaccount:argocd-system:argocd-server"
                ]
            }
            }
        }
        ]
    }
    EOT
    "override_json" = tostring(null)
    "override_policy_documents" = tolist(null) /* of string */
    "policy_id" = tostring(null)
    "source_json" = tostring(null)
    "source_policy_documents" = tolist(null) /* of string */
    "statement" = tolist([
        {
        "actions" = toset([
            "sts:AssumeRole",
        ])
        "condition" = toset([])
        "effect" = "Allow"
        "not_actions" = toset([])
        "not_principals" = toset([])
        "not_resources" = toset([])
        "principals" = toset([
            {
            "identifiers" = toset([
                "arn:aws:iam::360093697111:role/argocd-sts-c03686ae5f06138e",
            ])
            "type" = "AWS"
            },
        ])
        "resources" = toset([])
        "sid" = "ExplicitSelfRoleAssumption"
        },
        {
        "actions" = toset([
            "sts:AssumeRoleWithWebIdentity",
        ])
        "condition" = toset([
            {
            "test" = "StringEquals"
            "values" = tolist([
                "sts.amazonaws.com",
            ])
            "variable" = "oidc.eks.us-east-1.amazonaws.com/id/XXXX:aud"
            },
            {
            "test" = "StringEquals"
            "values" = tolist([
                "system:serviceaccount:argocd-system:argocd-application-controller",
                "system:serviceaccount:argocd-system:argocd-server",
            ])
            "variable" = "oidc.eks.us-east-1.amazonaws.com/id/XXXX:sub"
            },
        ])
        "effect" = "Allow"
        "not_actions" = toset([])
        "not_principals" = toset([])
        "not_resources" = toset([])
        "principals" = toset([
            {
            "identifiers" = toset([
                "arn:aws:iam::360093697111:oidc-provider/oidc.eks.us-east-1.amazonaws.com/id/XXXX",
            ])
            "type" = "Federated"
            },
        ])
        "resources" = toset([])
        "sid" = ""
        },
    ])
    "version" = "2012-10-17"
    },
]
}

but the errored out with
│ Error: failed creating IAM Role (fernando-guiding-stud-argocd-sts-c03686ae5f06138e): MalformedPolicyDocument: Invalid principal in policy: "AWS":"arn:aws:iam::XXX:role/argocd-sts-c03686ae5f06138e"
│ 	status code: 400, request id: 40f427f6-4a21-4b6c-992a-f60a5cb90e91
│
│   with module.base_system.module.argocd[0].module.argocd_iam_role_sa_cross_cluster.aws_iam_role.this[0],
│   on .terraform/modules/base_system.argocd.argocd_iam_role_sa_cross_cluster/modules/iam-role-for-service-accounts-eks/main.tf line 59, in resource "aws_iam_role" "this":
│   59: resource "aws_iam_role" "this" {

speaking with aws support, i'm told:

this is a known issue, because trust policies are evaluated upon creation using an automated engine
the role was not created yet hence not mapped to a logical id
the workaround is to create the role first then update the assume role policy

guess we need to open a ticket with the aws provider to handle this logic change

further discussion with aws support, this is a proposed solution.
        {
            "Sid": "ExplicitSelfRoleAssumption",
            "Effect": "Allow",
            "Principal": {
                "AWS": "*"
            },
            "Action": "sts:AssumeRole",
            "Condition": {
                "ArnLike": {
                    "aws:PrincipalArn": [
                        "arn:aws:iam::XXXX:role/argocd-sts-c03686ae5f06138e"
                    ]
                }
            }
        }

this one at least is valid.
we are going to try to test this today in one of our EKS test clusters

we confirmed that the conditional policy works for us.

This issue has been resolved in version 5.5.2 :tada:


convert regular DF to simba supported geometries

Does simba have som UDF to support creation of a simbaDF out of a regular data frame? I.e. like magellans df.withColumn("point", point('x, 'y))
If I am required to manually map all points / polygons to simba Geometry, how can I represent additional fiels?
val ps = (0 until 10000).map(x => PointData(Point(Array(x.toDouble, x.toDouble)), x + 1)).toDS
How can I parse WKT polygons to a simba supported geometry format?

Theoretically, you can do anything supported by Spark SQL DataFrame to a Simba DataFrame. As Simba DataFrame inherits from that of Spark SQL.
To represent additional fields, you simply add them to your structure. For example, you can define:
case class PointData(x: Point, payload: Int, tag: String)
And Simba will be able to automatically detect its fields and build the data frame. It will give you a schema  like:
-- DataFrame
|----- x : ShapeType
|----- payload : Integer
|----- tag : String

I see. And What about polygons? You seem to use Polygon.apply(Array(Point(Array(-1.0, -1.0)), Point(Array(1.0, -1.0)), If I have WKT polygon strings how could these be converted?

Refer to:
https://github.com/InitialDLab/Simba/blob/standalone-2.1/src/main/scala/org/apache/spark/sql/simba/spatial/Polygon.scala#L117

So assuming a Data frame with Polygons like below
case class MyClass(a:String, b:int, wktString:String)
val df = Seq(MyClass("a", 1, "POLYGON ((30 10, 40 40, 20 40, 10 20, 30 10))"), MyClass("b",2,"POLYGON ((30 1, 40 40, 20 50, 10 20, 30 1))")).toDS()
val dfGeom = df.map(x => SPolygon.fromWKB(x.wktString.toCharArray.map(_.toByte)))

is this how the conversion is supposed to be?
As for me this will fail with a code generator exception when calling dfGeom.show
17/03/20 20:26:50 ERROR CodeGenerator: failed to compile: org.codehaus.commons.compiler.CompileException: File 'generated.java', Line 102, Column 31: Assignment conversion not possible from type "org.apache.spark.sql.simba.spatial.Shape" to type "org.apache.spark.sql.simba.spatial.Polygon"

I think you can try this:
case class MyClass(a:String, b:int, wktString:Polygon)
val df = Seq(("a", 1, "POLYGON ((30 10, 40 40, 20 40, 10 20, 30 10))"),("b",2,"POLYGON ((30 1, 40 40, 20 50, 10 20, 30 1))")).map(x => MyClass(x._1, x._2, Polygon.fromWKB(x._3.toCharArray.map(_.toByte)))).toDS()
df.show()

I don't know if it can work, but you can try.

This would fail with com.vividsolutions.jts.io.ParseException: Unknown WKB type 71 already when trying to parse the WKT.

Well, I think this is a parsing problem of JTS, which is out of my scope now. And just to remind, general geometric objects including polygons are still under development.

Would about:
def toPolygon(s:String, u:String):SPolygon = {
    @transient lazy val reader = new WKTReader()
    reader.read(s) match {
      case poly: Polygon => {
        poly.setUserData(u)
        SPolygon.fromJTSPolygon(poly)
      }
    }
  }
  val df = Seq(("a", 1, "POLYGON ((30 10, 40 40, 20 40, 10 20, 30 10))"),("b",2,"POLYGON ((30 1, 40 40, 20 50, 10 20, 30 1))")).map(x => MyClass(x._1, x._2, toPolygon(x._3, "foobar"))).toDS
df.show

not sure if it will join later on, but df.show works.

df.show() should work. There must be something wrong with my fromWKT function.
Nevertheless, I don't think it will work for joins since our current join algorithm does not support polygons, which is technically caused by no partitioner for polygons and it assumes the join keys will be evaluated as Point. This is coming from our legacy hacks for its original prototype. Still, I treat partitioning general geometry objects as a research problem.


Connection Error due to SSL Option Removal

Describe the bug:
Unable to connect to Milvus cluster.
Connection error (Bad Request) when connecting to Milvus cluster with server side tls enabled.
I noticed that ssl was removed on 2.2.7: https://github.com/zilliztech/attu/pull/203
May I know why was it removed? And how can we connect using SSL enabled if this is the case
Steps to reproduce:

Login to Milvus running on same Kubernetes namespace (e.g. milvus:19530)

Specifying https://milvus:19530 does not work as well.
Attu version:
v2.2.7
Milvus version:
2.2.10

Let me check it soon. https should be equal to ssl:true.


Headers not parsed

Please search to check for an existing issue (including closed issues, for which the fix may not have yet been released) before opening a new issue: https://github.com/k9mail/k-9/issues?q=is%3Aissue
Expected behavior
Headers like subject should be parsed and shown in the according fields
Actual behavior
Subject is "(No Subject)" and headers are displayed as message body. Thought this was related to another issue, but in https://github.com/k9mail/k-9/issues/4846#issuecomment-648736286 I was adviced to open a new one.
Steps to reproduce
See attached email:  message.zip
Environment
K-9 Mail version: 5.716
Android version: 10
Account type (IMAP, POP3, WebDAV/Exchange): IMAP
Please take some time to retrieve logs and attach them here:

This message is broken in all sorts of ways. There are two CRLFs after Content-Transfer-Encoding: quoted-printable . For the parser that ends the header and starts the mail body. But what follows looks like it should be part of the header, too.
I'm guessing this is another case of one system sending out a broken message and another system trying to fix it up. In this case the "fix" seems to consist of inserting a Content-Transfer-Encoding: quoted-printable header and encoding the remainder of the message using quoted-printable. Further down there's also Content-Transfer-Encoding: 8bit. I assume this was the original header and the other one was injected at a later stage.
There's really nothing sensible K-9 Mail could do here. The bug needs to be fixed on the sending side.

Too bad. Thanks for looking into it.


Fix attaching User/Groups headers for bypass strategy

This change includes attaching the following headers when an authenticated session exists while using the bypass strategy:

Remote-User
Remote-Groups

Sorry for the delay. LGTM.