Remove Unnecesary @Nested

Once we merge this I will creta a PR adding the hash of that commit to .git-blame-ignore-revs to remove it from blame. https://docs.github.com/en/repositories/working-with-files/using-files/viewing-a-file#ignore-commits-in-the-blame-view

Did codecov provide a report? We'll want the coverage diff to be 0%... Not sure how closely anyone will review given the number of lines changed (!!)

To give context. To make this PR I implemented a new rule on my junit rule set and then I executed it over detekt until I fixed all the issues.
I did all the changes manually but in general all of them were to remove the first @Nested and reduce by one all the indentation.
I don't know if there is a way with github or git to ignore indentation changes. That way the review would be way easier.

I would appreciate to have fast feeback on this PR. If you think that it shouldn't be merged I can close it. But this PR will get a lot of conflicts so I would like to take a decission about it asap.


[BEAM-551] Allow TextIO to accept ValueProvider

Thinking about testing, is it worth having something sub-integration-test level?  We'd likely want to add some convenience methods to RVP for that, then.
R: @dhalperi

Argh, fixing test now.

Fixed.

Test added.

retest this please
(@jenkins, not Sam.)


[BUG] KG - for full DVDs, mediainfo is inputted into Rip Specs instead of KG's DVDRip template

Is there an existing issue for this?

[x] I have searched the existing issues

Current Behavior
easy-upload puts the mediainfo in the "Rip Specs" section on KG, but for a full DVD, KG wants you to fill out their DVD template instead of entering in the mediainfo
Help text on the upload form:
For DVD/Blu-Ray uploads you need to use the DVD/Blu-Ray template which will be automatically pasted when you select "DVDR" or "Untouched BluRay" below. It may also be found in the rules page. Please make sure the Video_TS/BDMV folder has a parent directory.

Template:
DVD label: ?
DVD5 / DVD9 ?
DVD Format: NTSC / PAL ?
DVD Audio: Codec (AC3, DTS, PCM) ?, Channels (1.0, 2.0 or 5.1) ?
Program(s): Program(s) used to rip/customize the DVD ?
Menus: Untouched / Reencoded / Removed ?
Video: Untouched / Reencoded / Removed ?
Audio: Untouched / Reencoded / Removed ?
DVD extras: Untouched / Reencoded / Removed ?
Extras contain: (Making of / Interviews / Trailer(s) etc.) ?
DVD runtime(s) (main feature and extras): 00:00:00 (hours:minutes:seconds) ?

Expected Behavior
When uploading a full DVD, instead of inputting the mediainfo into the Rip Specs section, use KG's template as instructed
Steps To Reproduce

Transfer a full DVD (DVD5/DVD9 VIDEO_TS) to KG
Notice that mediainfo output is in the Rip Specs section instead of KG's DVD template

Environment
- Browser：Microsoft Edge
- Browser Version：Version 100.0.1190.0 (Official build) Canary (arm64)
- Script manager extension：Tampermonkey
- easy-upload version：3.1.5

I assume so.  They list that rule right there on the upload form under the rip specs textarea.  I haven't asked staff if mediainfo is OK tho.

On the upload page, it also says
For film/TV rips you need to include the full MediaInfo output for the files.

So it sounds like if it's an encode, they want the mediainfo output.  If it's a full DVD or BluRay, they want the template.


Support per-operation capability attestation constraints

Problem
In the current version of wascap, and thus all parts of the waSCC ecosystem that rely upon it, the list of capability attestations in the embedded JWT is an array of strings. From a security standpoint, this means that the use of a capability provider is designated as all or nothing.
Today, it is not physically possible to sign an actor that is allowed to only subscribe to topics and barred from publishing. It's not possible to sign an actor that can only read from an event stream and not write to it.
Proposal
I propose that we make a change to the embedded tokens that allows fine-grained control over which operations can be invoked, and in which direction they can be invoked. It should be possible to bar a capability provider from invoking an operation on an actor or bar an actor from invoking an operation on a capability provider.
To allow JWTs to be backwards compatible with this new change, I propose we add a new field to the wascap object called constraints, which is an array of capability constraints. This should be treated as a fully closed allow list (often called a "whitelist"). If this list exists within the token, then only the operations and corresponding directions will be available to this actor.
Here is an example of what a new token under this system would look like:
{
  "jti": "xtenj4kDAv6mCR0xnpIqwy",
  "iat":<PHONE_NUMBER>,
  "iss": "AAGRUXXTGSP4C27RWPTMCHCJF56JD53EQPA2R7RPC5VI4E274KPRMMJ5",
  "sub": "MB4OLDIC3TCZ4Q4TGGOVAZC43VXFE2JQVRAXQMQFXUCREOOFEKOKZTY2",
  "wascap": {
    "name": "Echo Actor",
    "hash": "5FCFF41C3E1A3EE89E10C23EFCCC17E08AFEF2CDC04F77364F108DBBA5480816",
    "tags": [],
    "caps": [
      "wascc:http_server"
    ],
    "constraints": [
       {
           "mode": "to_actor",
           "op": "HandleRequest",
           "cap": "wascc:http_server"
        }
    ],
    "prov": false
  }
}

This token limits the actor in question to only being able to receive the HandleRequest operation from the wascc:http_server capability provider. Other mode values are to_cap and both indicating support for bi-directional invocations.
Additional
We should also provide an easy way for the constraints to be configured from the command line. It can potentially get unwieldy for constraints to be entered "long-hand" as a list. As such we should have a short-hand for representing a constraint.
One option is to use arrows as the shorthand, a->wascc:http_server but this includes a pipe re-direct character that can be difficult or ugly to escape on command lines. Therefore, I suggest we use the following syntax:
A -x- wascc:http_server:HandleRequest
A -x wascc:http_server:HandleRequest
A x- wascc:http_server:HandleRequest

Here, we have the use of the x character in three ways:

-x- - bi-directional invocation of the given operation
-x - invocation to the actor
x- - invocation to the capability provider

And now the syntax to describe an operation of the capability provider is cap_id:operation (remember that the capability ID doesn't necessarily have to contain a :, it's only a convention we use in wascc).
This results in a new wascap invocation that might look like this:
$ wascap sign -s -l --constraint "A -x wascc:http_server:HandleRequest" input.wasm output_signed.wasm

Potentially a far more readable / less error-prone thing to do would be to separate out the configuration of constraints into a new sub-command of wascap, e.g.:
$ wascap chmod echo.wasm --to-actor wascc:http_server HandleRequest
$ wascap chmod echo.wasm --to-provider wascc:http_server HandleRequest
$ wascap chmod echo.wasm --both wascc:http_server HandleRequest
$ wascap chmod echo.wasm --none wascc:http_server HandleRequest

The last command ensures that the operation doesn't appear in the whitelist. If you call the first two in sequence, it will change the mode to both, etc.

I like this idea. If an existing actor is already signed to use the httpserver capability, with this new structure (and since it's an old JWT, it won't have any constraints) will it still be able to issue bidirectional httpserver calls, or will constraints act as a "default deny" so you have to whitelist your api calls?

They would be default deny.

No constraints listed - full access to all operations within all of the capability providers listed
A few constraints listed - Only access permitted is what's in those constraints.

Existing actors signed with capabilities but no constraints would have access all operations bi-directionally.

No constraints listed - full access to all operations within all of the capability providers listed
Constraints listed - Only access permitted is what's in those constraints, regardless of what is listed in the capabilities field

This seems like the most sensible thing to me, provides backwards compatibility and it's transparent. I was just concerned that it would be "backwards compatible" but then all capabilities would be denied anyways. I also like the --to-actor --to-provider wascap subcommand for readability.

If we implement it properly, then all existing tokens should continue to function exactly as they did before without any interruption in functionality.


Bumps lsp-mode

A fix upstream gets rid of a (random) bug that forces users to restart emacs.
Specifically https://github.com/emacs-lsp/lsp-mode/issues/2141.

Can you please also bump lsp-ui ? There have been merged lots of fixes the last weeks.

Done, both bumped to the latest commits.

Bumped versions again.

Done.

Thanks for your help!


Update Generator to v2.0.0

Coverage remained the same at 100.0% when pulling f67fca7f785617680d2ae638b76c9f55c4af66f6 on generator into 0f2e62a5777fd3762042205377d25da23315c2e3 on master.

Coverage remained the same at 100.0% when pulling d2ac5965856dbbb26d777eb79fa1814f1b5e454c on generator into 0f2e62a5777fd3762042205377d25da23315c2e3 on master.

Coverage remained the same at 100.0% when pulling 4fab604ef464d5ac17270618cf057a97576edbc5 on generator into 0f2e62a5777fd3762042205377d25da23315c2e3 on master.


[Exposure Request] Table 36 "Sales Header" - StoreSalesCommentLineToTemp

Please make function StoreSalesCommentLineToTemp in table 36 "Sales Header" externally available.

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 42678.


Remove unnecessary test

Description
test_glue_session_demo.py creates Glue Interactive Session, but it doesn't call any dbt related function at all. Also, this test doesn't close the Interactive Session and it continues to run for 2 days (= default timeout: 2880 min).
Checklist

[x] I have run this code in development and it appears to resolve the stated issue
[x] This PR includes tests, or tests are not required/relevant for this PR
[ ] I have updated the CHANGELOG.md and added information about my change to the "dbt-glue next" section.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Hi @moomindani @menuetb would you review this?


GH-44866: [C++] Minor enhance the doc and impl of DictionaryArray::Transpose

Rationale for this change

Minor enhance the doc and impl of DictionaryArray::Transpose
What changes are included in this PR?

Minor enhance the doc and impl of DictionaryArray::Transpose
Are these changes tested?
Covered by existing

Are there any user-facing changes?
No

GitHub Issue: #44866

@pitrou Would you mind take a look?

@pitrou I've reverted the change for move


A third joycon for BAXY in Mode 1

I' m considering tie a third or even fourth joycon at hand position in Mode 1 to keep the heavy press and BAXY key functions . Is it possible? And how to make all key mapping customizable in a config file?

I' m considering tie a third or even fourth joycon at hand position in Mode 1 to keep the heavy press and BAXY key functions . Is it possible? And how to make all key mapping customizable in a config file?

download the source file and revise it on joycon key layout, and then recompile it. you will have what you want. But first you should know programming.

The key functions are hard coded, the easiest way to change them currently is to use a third party software like joytokey then you can change to what you want.
Because they are hardcoded, I have not allowed for adding additional joycons, I can't think of any easy ways to add them either without modifying the code.

The key functions are hard coded, the easiest way to change them currently is to use a third party software like joytokey then you can change to what you want.
Because they are hardcoded, I have not allowed for adding additional joycons, I can't think of any easy ways to add them either without modifying the code.

Please, help me with the dependecy head files of your C++ code, I want to do some change to your code, but can't complile it without them or the right version of them. I think people who are interested with your code, may come across the same problem. Thanx a lot.

Hi @flydays1980 , I lost all the data on my dev machine so do not currently have the source. I will need to get the dependencies again as well if I am to make any further changes to this.

Hi @flydays1980 , I lost all the data on my dev machine so do not currently have the source. I will need to get the dependencies again as well if I am to make any further changes to this.

Thank you anyway. I do think you can make some more development to your code. When I tried your app with many games, most problem is map navigation, walking in the 3d game world, I find this very inconvient if you are not used to it, plus the menu navigation is also a problem. At the same time, I discovered @SuperLouis64 's solution. He used the right joycon's anolog stick to walk,  which is more precise and easy to use. However, for body excersice purpose, he used the left joycon's gyro to enable and disable the right joycon's anolog stick. If you don't want or run in reality, you can't use the joycon to walk in the game world.  He also uses light press to attack.  I found this solution is quite good. If you can make another version it will be great. Thanks.

help with the JoiCon problem: https://github.com/ringrunnermg/Ringcon-Driver/issues/22?ysclid=llhxsz6lkk27258939


Controller does not pick up a re-applied schedule.

Applied the example schedule, got an error saying the date was in the past (imo it should not matter as the repete was set to daily)
Updating with a future date, ran kubectl apply again without the controller picking up the change. removing and then adding the schedule made the controller pick up on the change.

I've added a new issue for ignoring date on repeat: https://github.com/kubecost/cluster-turndown/issues/24
The other issue you're referring to is the way we handle failed (and completed) schedules. Whenever a schedule fails, we do not immediately delete the resource.
$ kubectl get tds
NAME               STATE            NEXT TURNDOWN   NEXT TURN UP
example-schedule   ScheduleFailed   <no value>      <no value>

Likewise, when a non-repeating schedule completes, the resource is not immediately deleted. These are mainly to show a status similar to a pod failing to locate an image. The resources will eventually be cleaned up (there's a 30 minute interval cleanup job that runs).
With the example we provide, example-schedule, if it fails and you try to re-apply, it will attempt to update the resource, which is not currently supported. We have a note in our docs regarding
I agree that this is a bit annoying, and we plan on addressing the updating resource issue soon. In the mean time, I've updated the documentation surrounding the example-schedule.yaml interaction.
Thanks again for all your input!

No problem at all, great to see the quick response. 👍


MDA vs Canvas

@AhmedSalih-PowerPlatformPlace  use the "@" before my alias to "tag" me I will receive a notification 😉
You can also set my as reviewer in the top right of this PR


New oauth2.JWT_SECRET is missing from gitea generate secret

Gitea version (or commit ref): v1.8.0
Git version: 2.20.1
Operating system: Alpine 3.9.3
Database (use [x]):

[ ] PostgreSQL
[ ] MySQL
[ ] MSSQL
[x] SQLite

Can you reproduce the bug at https://try.gitea.io:

[ ] Yes (provide example URL)
[ ] No
[x] Not relevant

Log gist:

Description
There is a new secret in the Gitea config since 1.8.0 (I think) named oauth2.JWT_SECRET but there is no command to per-generate it under gitea generate secret. That is, there is no gitea generate secret JWT_SECRET.

LFS_JWT_SECRET can be used for oauth as well, but I'm going to keep this ticket open to update the command to be just JWT_SECRET.


cannot resolve symbol youtubeplayerview

I followed the instructions on the page . But when I add reference to youtubeplayerview in my main activity , it shows "cannot resolve symbol youtubeplayerview".
Should I create a class for it or is there anything missing ?

I have just copy pasted some code on to manifest , activity_main.xml , mainactivity.java and into the gradle files .
How can i import the library ?
Do I have to download something ?

Please read about Gradle and how it works.
You can also clone the library and look at the sample app to learn how you are supposed to do things.

Sorry ..
I couldnot understand .
I am new to programming . Do i have to download something ?
Some jar file or something ?
Or how can I import the library ?

you can import the library.

How ?
Please give me the link from where i can import it ?

Check out this library's Readme (download section) and look for more detailed information on tye internet. Basically, you have to add a line listed in Readme to your apps module build.gradle file.

I followed the instructions on the page . But when I add reference to youtubeplayerview in my main activity , it shows "cannot resolve symbol youtubeplayerview". Should I create a class for it or is there anything missing ?

I am also facing same problem. Have you resolved it??


Add copyright header to PowerShell samples

Investigate linting options for PowerShell

Along with this issue, I will also remove unnecessary comments in samples-powershell.
https://github.com/Azure/azure-functions-sql-extension/pull/581#discussion_r1066430984


Support inbound routing basing on HttpRouteGroup

Please describe the Improvement and/or Feature Request

Originally, this feature is opened in SMI repo. I think it is better to implement it in OSM.
Scope (please mark with X where applicable)

New Functionality          [ ]
Install                    [ ]
SMI Traffic Access Policy  [ ]
SMI Traffic Specs Policy   [X]
SMI Traffic Split Policy   [X]
Permissive Traffic Policy  [ ]
Ingress                    [ ]
Egress                     [ ]
Envoy Control Plane        [ ]
CLI Tool                   [ ]
Metrics                    [ ]
Certificate Management     [ ]
Sidecar Injection          [ ]
Logging                    [ ]
Debugging                  [ ]
Tests                      [ ]
CI System                  [ ]
Project Release            [ ]

Possible use cases

As our case, we are facing to migrating common microservice architech to mesh. Usually it's not good practice to migrate all service to mesh at one time, but part by part gradually.
In this case, we can't rely on client side routing if we want to provide canary feature. Such as A depends on B and B is in canary release stage, it is better to implete routing within ingress listener on B side. Bcoz A or other service consumers may not be migrated to mesh yet.
With ingress routing, will help system migrate to mesh architech smoothly.
If not explained clearly, will provider more info.

@addozhang currently OSM programs both client side and server side routes. Client side routes are programmed for TrafficSplit scenarios which require the client to load balance traffic. Server side routes are programmed based on SMI policies as well.
Could you share more details on what is it that you think is not correct?

@shashankram sorry for late reply.
Currently our system built with Spring cloud framework (Edgware) and running on Openshift (3.11, which kubernetes is 1.11). Service discovered is via Netflx Eureka and service accessing is via Feign which using pod ip and port directly.
We hope to migrate to mesh smoothly and implement Cancary release with power of envoy. Smooth requires we MUST upgrade microservice partially, even no one needs to do SDK upgrading. This results that there will be one case that client(service consumer) is still in old generation architech and server (service provider) is running in mesh architech. The client still access service with pod id and port (no HOST in HTTP header, and domains won't work in virtual_host and server_names not work in filter_chain_match).
With this requirement, we want to implete traffic split in server side. This means we need to:

[√] enable egress in system which will open ORIGINAL DST filter to allow client which in mesh architech access others with pod ip and port directly.

inbound listener support both TLS and non-TLS filter chain. I have already implement on my local, is it compliant to involved in osm as PR?
RDS_Inbound provied one more virtual_host with wildcar * domain at end of list, then weighted and http route are implemented there.

Hoping my explanation clear.

@addozhang thanks for providing more details.
Would your problem where the HOST header contains IP:Port be addressed if we program IP:Port in the virtual_host domains?
We do not want to open inbound listener for non-TLS traffic for in-mesh traffic. We do support non-TLS only for ingress traffic via Kubernetes ingress resource. At the moment, in-mesh inbound filterchain should not allow non-TLS traffic.
RDS_Inbound virtual_host can be updated to use IP:Port instead of wildcard. We want to enforce HOST headers without wildcarding it.

Would your problem where the HOST header contains IP:Port be addressed if we program IP:Port in the virtual_host domains?

Currently we need to upgrade sdk in all microservices if we need HOST appear in HTTP header, it will be huge cost.
If not upgrade, client out traffic is sent by the passthrough-outbound, the ORIGINAL_DST filter. (this filter will handle the trffic like mysql .etc). It is configured as protocol_selection: USE_DOWNSTREAM_PROTOCOL in passthrough-outbound cluster. This means request will be sent as non-TLS one with original protocol (it's http in our case).
Then the  non-tls request reaches service side. In order to selet a desired listener fitler chain to handle it, like inbound_prometheus_listener.

We do not want to open inbound listener for non-TLS traffic for in-mesh traffic. We do support non-TLS only for ingress traffic via Kubernetes ingress resource. At the moment, in-mesh inbound filterchain should not allow non-TLS traffic.

How about provide a switch to handle this? With swtich on, it accepts non-TLS traffic. This will help system to perform migration to mesh with low cost. Once all service migrated, the switch will be off.

RDS_Inbound virtual_host can be updated to use IP:Port instead of wildcard. We want to enforce HOST headers without wildcarding it.

I think it will be ok with ip:port in virtual_host instead of wildcard, but not sure domains field can hold ip:port.

Would your problem where the HOST header contains IP:Port be addressed if we program IP:Port in the virtual_host domains?

Currently we need to upgrade sdk in all microservices if we need HOST appear in HTTP header, it will be huge cost.
If not upgrade, client out traffic is sent by the passthrough-outbound, the ORIGINAL_DST filter. (this filter will handle the trffic like mysql .etc). It is configured as protocol_selection: USE_DOWNSTREAM_PROTOCOL in passthrough-outbound cluster. This means request will be sent as non-TLS one with original protocol (it's http in our case).

passthrough-outbound is only meant for egress traffic, not traffic within the mesh. For traffic within the mesh, you either need to use permissive mode by setting permissive_traffic_policy_mode=true in the osm-config ConfigMap, or explicitly add SMI policies.

Then the non-tls request reaches service side. In order to selet a desired listener fitler chain to handle it, like inbound_prometheus_listener.

We do not want to open inbound listener for non-TLS traffic for in-mesh traffic. We do support non-TLS only for ingress traffic via Kubernetes ingress resource. At the moment, in-mesh inbound filterchain should not allow non-TLS traffic.

How about provide a switch to handle this? With swtich on, it accepts non-TLS traffic. This will help system to perform migration to mesh with low cost. Once all service migrated, the switch will be off.

Here is a related issue: https://github.com/openservicemesh/osm/issues/1001 (disable mTLS using a flag). Will this address the TLS problem for you?

RDS_Inbound virtual_host can be updated to use IP:Port instead of wildcard. We want to enforce HOST headers without wildcarding it.

I think it will be ok with ip:port in virtual_host instead of wildcard, but not sure domains field can hold ip:port.

ip:port is allowed in virtual_host.domains, so this should work for you. I can create an issue for this.
Let me know your thoughts @addozhang.


Refactoring of JGitEnvironmentRepository.java class:

split into several classes
moved git related classes into dedicated package
refactored JGitEnvironmentRepositoryTests.java: left & enriched unit-test + moved integration tests to JGitEnvironmentRepositoryIntegrationTests.java

PS: this PR brings zero new functionality. It's just a minor step to decrease amount of logic in this class.
This change should lead to better unit-test coverage and simplicity of changing & adding new tests.

Codecov Report

Merging #952 into master will decrease coverage by 5.5%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #952      +/-   ##
============================================
- Coverage     75.62%   70.12%   -5.51%
+ Complexity      800      109     -691
============================================
  Files            99       13      -86
  Lines          3085      415    -2670
  Branches        415       47     -368
============================================
- Hits           2333      291    -2042
+ Misses          585      103     -482
+ Partials        167       21     -146

Impacted Files
Coverage Δ
Complexity Δ

.../environment/AbstractScmEnvironmentRepository.java

...r/environment/SvnEnvironmentRepositoryFactory.java

...work/cloud/config/server/ssh/SshUriProperties.java

...er/environment/CompositeEnvironmentRepository.java

...fig/server/ssh/PropertyBasedSshSessionFactory.java

...erver/environment/SvnKitEnvironmentProperties.java

.../server/encryption/CipherEnvironmentEncryptor.java

...config/server/environment/RepositoryException.java

...erver/environment/SvnKitEnvironmentRepository.java

.../server/support/GitCredentialsProviderFactory.java

... and 69 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e0f749...bf0462f. Read the comment docs.

One thing that I wanted to add, that this change should be one of the several in order to make code simpler and easier to add new features. So I guess (IMHO) that   the time has come - to refactor ;)

Unfortunately, we missed the boat for this to add breaking changes in Finchley.


Manage words in dict for word_tokenize

[ ] add new word to dict default

[ ] remove word from dict

[ ] save new dict to file

You can use  class Tokenizer.
Colab by @korakot  : https://colab.research.google.com/drive/1Kkr4Uc5UIldZqFuXam2mPPaOhOrDbcV0


Using dropzoneOptions without a url

I want to use Vue dropzone without using the url in dropzoneOptions i.e. I do not want to send the uploaded image to any external server (due to security reasons). Is there any way I can use it without using the url field in dropzoneOptions?

@paridhikhaitan did you figure out the way?

@paridhikhaitan @portikM
I found a workaround is to set url: 'http://localhost'.
I don't know how you deal with this problem


add animation to rubber ducky

Bounce? Shift? Rotate?
First inclination is a bounce.

Successfully added bounce animation along with a Zoom onHover transition. Tried shake, too much. Looks good.


Flag to allow continuation while password spraying

Adds --continue-on-success flag when spraying passwords using smb. Allows for continuing of password spraying even after valid password is found. (Useful when password spraying with userlist.)
Usage example:
cme smb ipaddress -u users.txt -p password --continue-on-success
In response to:
https://github.com/byt3bl33d3r/CrackMapExec/issues/245
https://github.com/byt3bl33d3r/CrackMapExec/issues/247

Thanks!


Add stackset support

https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/what-is-cfnstacksets.html

I'm told that the web console's support for deploying to an organisation unit (OU) is because it calls ListOrganizationalUnitsForParent on the user's behalf

Stack sets will soon be getting native org integration, so they'll become a lot more useful and this would be even more useful to add


Add "X-Requested-With: XMLHttpRequest" header.

This should be user-configurable, or at the very least only enabled on same-domain requests.

Closing as we've implemented our own version of this PR in the dev branch.


KAFKA-16484: Support to define per broker/controller property by ClusterConfigProperty

related to KAFKA-16484
Introduce a new field id in annotation ClusterConfigProperty. The main purpose of new field is to define specific broker/controller(kraft) property. And the default value is -1 which means the ClusterConfigProperty will apply to all broker/controller.
Note that under Type.KRAFT mode, the controller id starts from 3000, and then increments by one each time. Other modes the broker/controller id starts from 0 and then increments by one.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

@brandboat Please fix the conflicts

build get failed ... retrigger again


Release to candidate (prod-beta)

Codecov Report

Merging #319 (206701f) into prod-beta (2bbe60d) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@              Coverage Diff              @@
##           prod-beta     #319      +/-   ##
=============================================
+ Coverage      85.13%   85.14%   +0.01%
=============================================
  Files             24       24
  Lines            982      983       +1
  Branches         365      366       +1
=============================================
+ Hits             836      837       +1
  Misses           146      146

Impacted Files
Coverage Δ

src/Components/ClusterRules/ClusterRules.js
84.33% <ø> (ø)

...nts/AffectedClustersTable/AffectedClustersTable.js
89.06% <100.00%> (+0.08%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2bbe60d...206701f. Read the comment docs.

:tada: This PR is included in version 1.7.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Render bugs with GatsbyJS

First of all, thank you for making this! ❤
The problems

The last FootnoteRef that uses jsx in the description (instead of a string) gets duplicated when clicking on "data-a11y-footnotes-ref" or "data-a11y-footnotes-back-link" (basically when Footnotes is triggered to re-render)

If you customize the Footnotes Wrapper, the component renders multiple times. Which either completely breaks the :target css selector or makes it behave inconsistently (tested in Chrome, Firefox, and Safari)

I tried looking through the code in this repo, and I imagine this has something to do with the SSR code (registering, cloning, etc.) but I don't know for sure. This is a little over my head right now, so I thought I'd reach out for help.

Steps to reproduce
Using Gatsby cli start a new project gatsby new
Install this package (react-a11y-footnotes), update the src/pages/index.js with basic implementation
<FootnotesProvider>

Just <FootnoteRef description="My footnote 1">testing footnotes</FootnoteRef>

...and <FootnoteRef description={<>My footnote 2</>}>testing more footnotes</FootnoteRef>

  {/*
some more <FootnoteRef description={My footnote 3}>footnotes</FootnoteRef>
 */}
  <Footnotes Wrapper={props =>
{props.children} {console.warn('render footnotes')}
} />
</FootnotesProvider>

Remove the Wrapper prop and see the :target css selector start working again.
Uncomment the 3rd footnote and see that the duplication problem now happens on that instead of the 2nd footnote.

Hello Matt!
Thank you for reaching out and for the detailed bug report. I’ve been having a look at what’s going on, and I can confirm it has nothing to do with Gatsby itself. It would happen on any system using client-side rendering. It can easily be reproduced on CodeSandbox as well for instance.
What I found out is that the problem only happens with footnotes using JSX for their description prop. String footnotes are working as they should. The reason why is that JSX trees don’t pass the memoization (from useMemo) as they’re essentially always different. For that reason the footnotes using JSX get re-rendered when the parent component updates.
An actionable fix (until I figure out how to solve it on the lib side) is to store the JSX tree in a ref so it’s stable across renders.
const MyComponent = () => {
  const footnoteDescription = React.useRef(<>My footnote 2</>)

  return (
    <FootnotesProvider>
      <FootnoteRef description={footnoteDescription.current}>testing more footnotes</FootnoteRef>
      <Footnotes />
    </FootnotesProvider>
  )
}

Hold on.  Turns out I can’t type and there was a typo in the code. Shame on me. 😅 This has been fixed in 0.4.3 and I think (I hope) things will be smoother for you.
https://github.com/KittyGiraudel/react-a11y-footnotes/releases/tag/0.4.3
Could you update and let me know if that solves your problem? :)

Thank you! This fixed the duplication problem 🥳🙌
The 2nd issue still exists. Customizing the Wrapper breaks the css :target
In my simple test (with a custom Wrapper).
<Footnotes Wrapper={props =>
{props.children}
} />
I can see the DOM re-renders every time I click a different footnotes link (I see Chrome dev tools highlighting the changed DOM nodes in the Elements tab). Clicking the same link twice in a row will not re-render and the target styles show.
When the Wrapper is not customized.
<Footnotes />
The DOM doesn't re-render, so target styles always work as expected

I also found that customizing only the ListItem causes the same problem.
<Footnotes ListItem={props =>
} />

@8bitmatt Could you try memoizing your components please? Like so:
const FootnotesWrapper = React.memo(props =>
{props.children}
)
const FootnotesListItem = React.memo(props =>
)

<Footnotes Wrapper={FootnotesWrapper} ListItem={FootnotesListItem} />

React.memo does not seem to help. (If the assignment happens inside the main exported component)
const IndexPage = () => {
    const FootnotesWrapper = React.memo(props =>
{props.children}
)
    const FootnotesListItem = React.memo(props =>
)

return (
    ...
)
};

export default IndexPage

If I move the assignment outside of the component it does help... But, I also tried removing React.memo in that situation and it works too. 🤷
// Seems to help
const FootnotesWrapper = React.memo(props =>
{props.children}
)
const FootnotesListItem = React.memo(props =>
)

const IndexPage = () => {
...
};

// But this works too
const FootnotesWrapper = props =>
{props.children}

const IndexPage = () => {
...
};

Anyway, I can get by with this! Thank you for helping!

Hello! 👋  Sorry I’m only now coming back to this.
I think what you explained makes sense: if you declare components within the main component, you end up passing different components to the footnotes for every render, which can cause issues. By declaring them outside of the render lifecycle, they‘re always the same. :)


⚠ Bofrost.de has degraded performance

In 6b998e0, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1321 ms

Resolved: Bofrost.de performance has improved in b7f1b95.


Modify DiskANN build to accept a config struct

Signed-off-by: liliu-z<EMAIL_ADDRESS>issue: #253

Refactor DiskANN's build by accepting a config struct. This make it easier to expand in the future and free us from tedious param num check, type check.
Delete no need DiskANN test files from the original repo involved this build function.

/lgtm

/lgtm


Last version CDN for this module

Hi, I see there are a CDN at cdn.rawgit.com, but it is not updated.. There are a newer one?

this one, or you can get any of them from https://unpkg.com/greiner-hormann


Unreadable directory / Error initializing DaemonStateData

For reasons, there is a directory in my filesystem that I don't have permission to access. It's not beneath the directory containing .buckconfig . FileWatcher still tries to look at it however and then buck2 fails to start.
setup:
/
/project
/project/other_stuff
/unreadable_dir

Error initializing DaemonStateData

Caused by:
    0: Error creating a FileWatcher
    1: Permission denied (os error 13) about ["<directory name>"]
    ```

It's not beneath the directory containing .buckconfig

That seems rather odd, what does buck2 root -k project yield?

Cool, sounds like you must have a .buckconfig somewhere up the tree.

I think that the buck2 init --git command should probably add a .buckroot as well most likely

Sure, that's a good idea. Did you want to send a PR for this? if not I'll submit that.

Added support for that in https://github.com/facebook/buck2/commit/54e1eb5e29eca8a021579b859d0a34c73754eb2a


[PackageDescription] Add new product API

and get rid of the old one...

This is now fully done

@swift-ci please test

@swift-ci please test

@swift-ci please test


pinpoint 's plugins compatibility , ask for help.

I want to know pinpoint 's some plugins compatibility,such as redis,mysql,dubbo,tomcat,postgre 's plugins,which version's driver they can compatible, who can list the menu,thank 's alot.

Hi @magicdogs
I'm not too sure of jedis, dubbo, and postgresql versions but I think anything that was released reasonably recently should work. A recently released major version might not work.
MySQL connector - 5.x should work
Tomcat - 6+ (not sure about 5 but it's pretty old)
If something doesn't work with a version you're using please let us know.
Thanks!

@Xylus At first  thank for your help
i am using pinpoint-postgresql-jdbc-driver-plugin-1.6.0.jar into my application ,  the postgresql driver version is 9.1-901.jdbc4 ,  but the pinpoint collector UI show like this
 ,
i had checked the application logs file,  i had checked the application logs file,  has found something error information , and i had compared postgre plugin 's code and the postgres driver 's code,
cause those problems the reason was PostgreSQLConnectionCreateInterceptor ' s @TargetConstructor({ "org.postgresql.util.HostSpec[]", "java.lang.String", "java.lang.String", "java.util.Properties", "java.lang.String" }),
but in fact the postgres driver Jdbc4Connection seem like  this @TargetConstructor({ "java.lang.String", "int", "java.lang.String","java.lang.String", "java.util.Properties", "java.lang.String" }) ,
though i had solved those problem, i think need to know pinpoint 's plugins compatibility,
the best way is list all pinpoint  's plugins  compatibility information that can let us avoid to face those problem again , Thanks!

@magicdogs Thanks for identifying the problem!
There is a known issue #2239 regarding postgresql 9.4.1207+, but looks like you've found another version that needs to be supported.
Thanks for testing this out.
I totally agree with you that supported versions need to be tested and displayed somewhere. It'll take a long time to test everything, but we'll hopefully add this information.


VelocityTransitionGroup positioning on first tick

As per the readme, I'm using the style key in the enter/leave animation hash to set absolute positioning for the child elements to not affect the container height, but the absolute positioning stays on the elements even after the enter/leave animations are complete.
I expected it to default back to its original positioning once velocity-react is done animating. Since it doesn't do this, the parent container loses height/width.

The "style" just gets applied, since it’s done via Velocity / DOM rather than React it's not straightforward to just "undo". You can often override it in the animation if that's necessary.
For doing a crossfade-like effect, I'd recommend only using “position: absolute” for the leaving element, leaving the parent to size naturally from any entering element.


Remove hack* scripts as they don't appear to be doing anything

Please verify the following:

[x] yarn ci:test jest tests pass with new tests, if relevant
[x] README.md has been updated with your changes, if relevant

Describe your PR
This PR removes the hack* scripts in package.json. I don' tthink they are needed anymore.

:tada: This PR is included in version 6.5.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Added basic autocomplete functionality

Quick implementation of auto-complete. It does not support multiple suggestions and will auto-complete using the nearest suggestion.

Great work. Thanks!


Create unit tests for WFV\Validator

This is a meaty one...

ValidatorTest introduced in 0.8.7 https://github.com/macder/wp-form-validation/pull/58

albeit this will continue to be an on going process of TDD, there is a good foundation in place introduced in 0.10.0 https://github.com/macder/wp-form-validation/pull/82


nested structs and enums in structs without Box

Allows the use of nested structs or enums in structs without wrapping the inner struct with Box.
E. g. struct A { b: B } now also works in addition to struct A { b: Box<B> } (which had to be used before).
This is related to some of the problems encountered in #525, #548, though there might be more related issues.
So far this seems to be working with nested structs and simple enums (without associated data) in structs,
though I haven't really looked into enums with associated data (e. g. enum B { A, B { s: String, i: i64 }, C(C) }), yet.
TODO: update docs
Checklist

[ ] An issue to be fixed by this PR is listed above.
[ ] New tests are added to ensure new features are working. End-to-end tests are usually in the ./frb_example/pure_dart example, more specifically, rust/src/api.rs and dart/lib/main.dart.
[ ] The code generator is run and the code is formatted (e.g. via just refresh_all).
[ ] If this PR adds/changes features, documentations (in the ./book folder) are updated.
[ ] CI is passing.

Remark for PR creator

New contributors will be blocked by GitHub from running CI, but you can use a trick to workaround this, and verify your code using CI by yourself.
If fzyzcjy does not reply for a few days, maybe he just did not see it, so please ping him.

Good job!

[ ] Add a few tests, otherwise future release may create the bug again. End-to-end tests are usually in the ./frb_example/pure_dart example, more specifically, rust/src/api.rs and dart/lib/main.dart.
[ ] The code generator is run and the code is formatted (e.g. via just refresh_all).

Oops I did not realized you have resolved all conversations! Next time please just ping me if I do not reply :)
So, maybe resolve the conflicting files and I am ready to merge it. (As long as it is not the same as #949)

@nitn3lav Could you rebase this? :)

@nitn3lav Damn. Great work!
This is one of my biggest pain points right now. Would love to see this getting merged :))
Thanks for your work

@all-contributors please add @nitn3lav for code, doc


Support Reforming Refine recipe in DSP

DSP added a new recipe, "Reforming Refine" for the refinery. Would be nice to support that in factoriolab.

Could you share a link or image with the details of that recipe? I see it mentioned in the patch notes but I can't see it called out in the dsp wiki.

Here you go

You're awesome. Unlike the other recipe changes this will require a new icon in the sprite sheet so I won't be able to add this as quickly, but thanks for the info.
I assume proliferator with extra products only multiples the net output (1) not the gross output (3)? It's ok if you don't know.

This recipe actually can't multiply extra products, only speed up the process. Same as X-Ray refining.  (Apologies for the duplicate issue, I must be blind.)


docs(typography): add docs for typography

:tada: This PR is included in version 0.2.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Update systemd oneshot Restart warning on next systemd release

We currently have this logic
https://github.com/NixOS/nixpkgs/blob/f2f36822ca740292f6005fe29e0fe2eddfb949c9/nixos/modules/system/boot/systemd.nix#L786-L787
that emits
trace: warning: Service ‘consulReady.service’ with ‘Type=oneshot’ must have ‘Restart=no’

if you have Restart = "no" on a type = "oneshot" service.
With the upstream change https://github.com/systemd/systemd/pull/13754 that restriction will be relaxed.
We should update the warning once that lands as part of the next systemd release.

@maralorn this has been implemented in https://github.com/NixOS/nixpkgs/pull/90604, hasn't it?

Yes, this is fixed on master.

But I don‘t have the rights to close this issue. :-(

Alright, closed :-)


CLI: configuration can pass to measure to run on specific configuration

metric
bands

Fixed in https://github.com/aiidateam/aiida-sssp-workflow/commit/b3b18895ba3ae5088d1f0d0727dcd254e1383f90


Graphic bugs on Metal gear Solid The Phantom Pain using DXVK

Hi, i have been trying to use DXVK on MGSTPP and i have detected some graphic bugs.
Im using an RX 570 with AMD drivers 22.3.2, without DXVK the graphics are perfectly fine but i tried to use DXVK because DX11 support on AMD side is a bit shit and i get some frame drops without gpu or cpu being maxed out.
I tried 4 versions of DXVK, since 1.10 to 1.10.3, and all of them got this bugs. Im using windows 10 fully updated by the way.
On other games DXVK works perfectly fine.
Going to attach 2 pics of this bugs:

We don't support Windows, and this is likely a driver bug since the game is known to work on Linux.

Ok, i understand that you dont support windows but without DXVK graphics are perfectly fine and in all other games theres no issues with DXVK. Yeah, the drivers are 4 months old but the game is several years old, maybe i have to use some config on the dxvk.conf file or a problem with vulkan itself?
log files:
mgsvtpp_d3d11.log
mgsvtpp_dxgi.log

Again, the problem is almost certainly the AMD driver, and probably specifically on older GPUs as well (they constantly break Vulkan stuff on Polaris, Vega, and even RDNA 1 sometimes). It works fine on RADV, and I don't want to spend several days figuring out what might be going wrong and whether or not it's possible to work around this, since it's just not our target platform. Hence, no support.

@doitsujin I don't mean to be a jerk, but I see A TON of issues on this repo that always follow the same pattern: someone has a problem and they're either using Windows (sometimes even Windows 7), an old GPU, unsupported drivers,... you know the drill.
Wouldn't it be appropriate to have a warning dialog pop up when a DXVK DLL is loaded and it detects that it's not running in Wine? Maybe even straight up refuse to load? After all, DXVK is supposed to be used on Linux.
Just my opinion, feel free to disagree.

It's been stated that DXVK on Windows is not officially supported by DXVK, and even if it were, support is not a right, as can be deducted from the license. Old GPUs may also not be getting Vulkan driver updates, and as such, DXVK may not properly work on them.

Maybe even straight up refuse to load? After all, DXVK is supposed to be used on Linux.

Either that, or try to redirect it to the system's DirectX dlls instead, although I'm not sure if that's worth the hassle.

Why would it be DXVK's responsibility to educate users by force? Really don't like the vibes of that idea.
Imho a warning in the issue template for amdvlk-pro driver (and probably also -open, as that one regresses like crazy too; not to be confused with RADV) and asking users to re-test with RADV would be sufficient. It's not so much Windows vs. Linux when the game actually manages to load, such visual corruption issues are always shared between Windows and amdvlk-pro driver on Linux. It's also not like RDNA1/2 would necessarily show less issues with this driver and DXVK vs. e.g. Polaris.

@aufkrawall I think it's needed because many of these users don't even know that DXVK is not supposed to be used on Windows.
Take a look at this example (from the PCGamingWiki page for GTA IV):

The link points directly to the releases page, do you think the average GTA IV player will take time to go and read the readme file?
Look how many times people recommend using DXVK on Windows on PCGW: https://www.pcgamingwiki.com/w/index.php?search=dxvk&title=Special%3ASearch . The only page that has a warning is Stray because some good soul added it a few days ago.
Same thing on the Steam community, with this guy recommending using DXVK to play Stray on Windows 7

When these users inevitably run into issues, they're going to come here and open issues and then we have to explain them that they're not supposed to do that.
A simple warning message like the one below could be added here or in any other piece of code that's executed early during the initialization and will at least inform some these users.
DXVK is not designed to be used on Microsoft Windows.

You can continue but you may run into performance and/or stability issues, please DO NOT report these issues on Github.

To disable this message, add dxvk.disableWarnings=True to the config file.

Similar warnings could be added at the same location to warn people with old Kepler GPUs or with really old drivers.

This issue is maybe derailing a bit so I'd suggest opening a new one if you have concerns or or want to discuss change suggestions.
fwiw I'm not personally a fan of outright disallowing dxvk to be used on windows. Even tho i understand the concern for having lots of reports that are mostly related to improper windows and dxvk compatibility do note that windows users can and have reported and brought legitimate dxvk issues to light.

@zarebcn that really wasn't my intention, I'm sorry if I made you feel unwelcome in some way.
My proposal was simply to warn users about known issues on an unsupported platform so that the project doesn't get flooded with issues. There's no fanboy war going on.
Believe it or not, I've been on the other side of this for many years, if you look on my profile you'll see that I even have scripts to build WineD3D for windows that I've been maintaining since 2014 (and from 2016 through 2019 even mesa builds). It's bad, it's unsupported, often has stability issues, but sometimes it gets the job done when you want to play some broken old game on windows, before DXVK and dgVoodoo came along it was a godsend for windows users!
Of course, people have been abusing the hell out of it and sending me emails complaining that it doesn't work and expecting me to be able to fix it, that's why I suggested that maybe DXVK should have a warning, that's all.
I'll open a separate issue as Blisto suggested.

@adolfintel I think that i understood it in the wrong way, i see your point. Sorry if i overreacted a bit but i just came here for informing of a bug and i felt that i was being annoying with my issue and got no support but complaints.
Va bene, saluti.

@aufkrawall I think it's needed because many of these users don't even know that DXVK is not supposed to be used on Windows.

Well, if such hints are mentioned in game wikis etc., it is probably (relatively) safe to assume that the game in question generally works with DXVK on Windows. I don't want to turn a bug ticket into a driver flame war, but reality is that basically every game just works with DXVK on Windows with Nvidia when loading of the DLL is not an issue (which tends to happen, but it's obviously a minority of affected titles). I probably have run dozens of games with DXVK with Nvidia on Windows, and can't recall any case of visual corruption.

Try latest master.
https://github.com/doitsujin/dxvk/actions/runs/2819592531

@Blisto91 Tried with this build and the bug is still there. My drivers are up to date (22.7.1)

I will try to check it out here later on Linux with the community drivers when i get home and see if i can repro a difference between master and 1.10.3

When gpu isn't 100% it's usually because there is a cpu bottleneck or otherwise. Unless there is a fps or vsync cap.
There have been some optimizations on master that should improve CPU bound performance. But if you FPS drops the same time as your GPU utilization goes up that sounds weird.
Can you check if there is a difference in how much Vram is used between the two versions?

@Blisto91 Yh, i use vsync cap at 60fps. Im pretty sure that i deleted .cache file but im going to try again and i'll do some pics

That's a totally unrelated problem. Please open a new issue for that.

How does it behave without vsync?
Also try disabling the overlay you are using and see if you see the same just using dxvk's own.
Make a file called dxvk.conf next to the games exe (or where the logs generate) and insert dxvk.hud = full
Post a screenshot of what that says.

Both 2k and max settings and vsync disabled but the game seems to cap at 60fps for me. Maybe caps at the display Hz.
Master

1.10.3

Please start taking screenshots.

I'm not seeing any meaningful performance differences on my system between the two versions.

Haven't reproduced either. Can you send a save game?

@Blisto91 I had Twitch Studio vulkan layer disabled on both tests, im going to send my savegame and config files of my game but i dunno if you will be able to use it because i think that are linked to an user.
local.zip
remote.zip

Turns out that this was once again specific to the official AMD drivers. RADV and Nvidia are fine.
No idea why, but enabling the Vulkan 1.3 maintenance4 feature just completely destroys GPU-bound performance.
I disabled this feature now to work around this, DXVK doesn't really need it, although the relaxed interface matching rules are nice for buggy D3D games. But AMD should really take a look at this, there's no way that enabling this particular feature should cost that much performance (or really, any performance).

@doitsujin If disabling this the performance is the same as in older versions is fantastic and if continues to launch games even without disabling twitch studio vulkan layers in my case it will be awesome.
In reference to the graphic corruption theres something that can be done? Maybe some config in the dxvk.conf file? Because is a pity that performance wise is perfect, far better than dx11 one, but the bug kills the immersion.

Sorry for jamming myself in when the ping wasn't for me 😁
You can try messing with the conf options, tho i'm pretty sure it wont affect it. But doesn't hurt trying.
This will most likely need a driver fix from amd. If my GPU wasn't unsupported with those drivers i would open one myself at the AMDVLK repo. A fix there might carry over to the windows drivers since they share alot of code afaik and is why it also reproduces the issue. Or atleast the funky trees I've been told.
You could try reporting it yourself and see if anything comes out of it. I know they have a bug report tool in adrenalin or what it's called. Tho dunno what they'll think about a bug report with dxvk on windows, but you could say it's the same issue with AMDVLK on linux.

AMD devs told me not to open tickets for the Windows driver at amdvlk GitHub tracker (e.g. related to unreliable shader cache on Windows that spams duplicates vs. Linux amdvlk-pro...). You could of course reproduce the issue on Linux with the amdvlk-pro driver, but they didn't fix ~anything I reported with regard to it.

Ye they shouldn't open at the AMDVLK tracker. Might have worded it badly.
They could try their luck with the windows bug report tool or hope someone else on linux that can reproduce there with amdvlk opens a issue and a fix carries over. Or try on linux themselves ofc.

The issue is caused by out of bound buffer access.   amdvlk 2022.Q3.5 release added a workaround for the game.

Sounds good. Did see the games mentioned in the release notes.
Didn't know amdvlk had been made aware. Was gonna make a issue myself if it was still an issue in a few months when i anticipate getting a new GPU that will be supported by the latest driver.
Will this also be relevant for a future windows driver release? Since that is what the original issue poster is on.

@zarebcn Could i get you to try again with latest driver and dxvk? 🙂

Did you submit a bug report to AMD?

Did you submit a bug report to AMD?

Nope because i think that they will say that i should not use dxvk on windows and use directx instead

Yaaay its finally fixed!!! 😀

Im using Amernime modded drivers 22.12.2 with dxgma kernel, AMD has not still released official 22.12.2 for polaris, and finally its fixed. Will see if with the next official release its fixed. Btw im using dxvk 1.10.3 because with 2.0 doesnt work MSI afterburner overlay.

Good to hear 🙂

Great news! I will try that in my end too.

@zarebcn Is it fixed in the newly released official driver? 🙂

Hi @Blisto91, i tested with the official driver and yes its fixed too but i dont know what they have done with the vulkan driver but now theres a noticeable loss of performance when using vulkan so i will stick with the modded drivers by the moment. Seems that AMD fixes some things and fucks another ones...


Support strong mode

Upgrade to the latest version of the VM, add an optional argument to support strong mode.

Build issues are cosmetic, I'll get a fix shortly: https://github.com/dart-lang/dart-services/issues/269


Retrieve Soda Core check outputs as JSON/Dict

Hi there,
I'm in the process of migrating from Prefect 1 to Prefect 2 and have been exploring the use of the Perfect 2 with your prefect-soda-core package. I'm impressed with the block abstraction in Prefect 2, and I noticed that your package has been updated to support this abstraction for running Soda checks.
However, I noticed that your package is using the shell command to run the Soda code, which means that the output of the jobs is only available in the stdout format. As I use this library independent of Soda Cloud, I prefer having a dictionary/JSON output that I can easily manipulate and use.
I think this could be achieved by changing your package to use and execute soda-core methods directly so that the task can return dictionary objects containing Soda check results.
Alternatively, an option to store the JSON-based output in a specified location using the --scan-results-file param from the soda-core library could be added.
I'd be happy to contribute to this change if it makes sense to you.
Thanks!

Hey @fakhavan 👋
When I started working on the prefect-soda-core collection implementation, I started by using Soda Core methods.
However, after a bit of testing, I discovered there were serialization issues within a Prefect flow that would have required a big refactor of Soda Core.
Together with @vijaykiran, we decided to refactor the implementation to make use of the Soda Core CLI to avoid having those serialization issues.
I'd be more than happy if you will to contribute a PR to implement the use case you described.
And I think that many people would benefit from such feature!
Best,
Ale

Hi @AlessandroLollo
Thanks for your explaining the context on why the shell task was being used to make this task. I raised a PR proposing changes to accept the scan_results_file param. Looking forwards to your feedback.
Cheers

Hey @fakhavan 👋
I've just merged this PR (starting from your previous one).
Let me know if I can close this issue!

Sovled by https://github.com/sodadata/prefect-soda-core/pull/21


How can I tell which version of Sass is running with node-sass?

Hi,
This might sound like an odd question but I'm using gulp-sass, a wrapper for node-sass which in turn uses libsass.
I'm confused as to how I know which version of Sass I'm running. Does it simply correspond to the version of node-sass? I found this more self explanatory when using Ruby gems for sass.
Thanks.

Hi,
node-sass is a wrapper around libsass which is an alternate / substitute implementation of Sass language compiler written in C/C++, as opposed to the primary implementation in Ruby language.
Going by https://github.com/sass/libsass/issues/629, we can say LibSass' latest version (v3.2.4) fully conforms with Sass language v3.3 and majority of v3.4 features. In other words, the lines are blur from that perspective. Besides, (IMO) the language version is an implementation detail. However, from node-sass' consumer perspective, the more imperative and distinguishing detail is the LibSass version itself, which node sass emits as follow.
From CLI:
node-sass -v
# or, depending on cwd and env PATH status, you may need:
#
# node_modules/.bin/node-sass -v

# OR even

node -e "console.log(require('node-sass').info)"

# OR -p (processes && evaluates)

node -p "console.log(require('node-sass').info)"

From code usage:
var sass = require('node-sass');
console.log(sass.info);

With latest node-sass, the output is:
node-sass       3.1.1   (Wrapper)       [JavaScript]
libsass         3.2.4   (Sass Compiler) [C/C++]

Let us know if and how we can further improve this experience.

@markweston also see my response https://github.com/sass/node-sass/issues/962#issuecomment-102568127

Another way to check the version of an indirect-dependency (node-sass) used in your direct dependency (gulp-sass) is to go into the node_modules folder and find the node-sass folder and check the package.json to see what version of libsass it depends on.
cd node_modules/gulp-sass/node_modules/node-sass
cat package.json | grep sass

npm code-sass -v

npm node-sass -v works well

It only shows the npm version not the node-sass version i checked

I found this command:
node -e 'console.log(require("node-sass").info)'


Make SharedContext settable

Summary of the PR
A short summary of this PR and what it adds/removes/fixes.
Related issues, Discord discussions, or proposals
Links go here.
Further Comments

This is ready for review: 1 LOC change with a bit of generated fluff on top


prevent unnecessary recursion during trace

Fixes #701
The current exit condition is sub-optimal. As the tree of load dependencies is traversed asynchronously, it is possible that the same module's dependencies could be recursed many times. In our case, this was triggering a massive number of promises and crashing node itself.

FWIW, this also gives us a massive performance boost locally:
Before:
./bin/build  146.57s user 6.64s system 101% cpu 2:31.69 total

After:
./bin/build  54.98s user 4.35s system 101% cpu 58.374 total

getLoadRecord itself does have a synchronous queue through the tracing object at https://github.com/systemjs/builder/blob/master/lib/trace.js#L140.
But this will avoid duplicate tracing work on the tree certainly, which would be especially important with deep module trees.
Thanks so much for tracking this down!

Mind releasing a new version?


missing comments (remarks) for methods in ActivityHandler class

Version
4.3.1
Describe the bug
Most methods in Microsoft.Bot.Builder.ActivityHandler don't have remarks/ comments. The samples override methods like OnMessageActivityAsync, which is missing remarks. While most method names are self-explanatory, it would be helpful to include some description.
for example - https://github.com/Microsoft/botbuilder-dotnet/blob/master/libraries/Microsoft.Bot.Builder/ActivityHandler.cs#L63
[bug]

@yochay - I have written documentation comments based on my understanding of the ActivityHandler class and submitted a pull request


Fix glob not following symdir directories

Fixes #9241
I have no idea why my initial code did explicitly exclude symlinks. It doesn't seem to make sense because everyone else follows symlinks.

If there are symlinks to parent folder it will iterate forever. ∞
Python does not traverse by default. https://docs.python.org/3/library/glob.html.
I would do the same:

to not follow symlinks by default
add a named argument in Dir.glob to follow_symlinks


tsproxy takes 100% load on one CPU when started

Using
docker run --rm -p 1080:1080 webpagetest/tsproxy --inkbps 1000 --outkbps 1000

I get a 100% CPU load on one of my cores (i7, gen8, 2.7GHZ)
It does not need to be proxying a the moment, just starting it creates this heavy load.
Is there any way to fix that?

Just in case, since this project is fairly dead - i switched over to https://github.com/mistakster/throttle-proxy - it has a socks and http proxy and has 0 load.


Use correct container registry for latest 2.9 head builds

Summary
User correct container registry for latest 2.9 head builds
Occurred changes and/or fixed issues

without this it doesn't look like rancher serves up the correct CNi charts related to the version of kube (1.28 and below are fine, 1.29 and above will fail to fetch charts)

Checklist

[x] The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
[x] The PR has a Milestone
[x] The PR template has been filled out
[x] The PR has been self reviewed
[x] The PR has a reviewer assigned
[x] The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
[x] The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

Note - this is blocked on eio 2933

https://github.com/rancher/dashboard/pull/12937 should be after this merges


Do not raise on unsuccessful cast

Currently when there's invalid value(such as empty string) given to the Geo.PostGIS.Geometry.case  it raises.
It's not a perfect solution if we want to use this function when parsing data that comes from outside of the system, like GraphQL request.
To make it more friendly to use I've made so that on unsuccessful cast returns :error instead of raising.

Thanks so much, @marmor157! 😄 💜

Included in the newly published v3.7.0 👍


Add upgrade notifier

https://github.com/yeoman/update-notifier

Closing as this has already been done:

https://github.com/Availity/availity-workflow/blob/master/packages/workflow/scripts/notifier.js
https://github.com/Availity/availity-workflow/pull/3/files#diff-168726dbe96b3ce427e7fedce31bb0bc


Test that node building on invalid blocks get disconnected

Supplements p2p-acceptblock with 2 extra test steps, backported (-ish) from Bitcoin Core, to make sure that when a node sends us an invalid block, it gets disconnected, and, when it builds upon that bad block, it gets disconnected again.
This ensures correct implementation of the fix for #2280, done in #2297 which has been cleaned up in #2457
Details of added steps:

Create a fork which is invalid at a height longer than the current chain (ie to which the node will try to reorg) but which has headers built on top of an invalid block. Check that we get disconnected if we send headers on the chain the node now knows to be invalid.
Test that node1 is able to sync when connected to node0 (which should have sufficient work on its chain) afterwards.

I pulled this in from @xanimo's fork, reflected in the first commit.
On top, I did the following changes:

Added a condition to NodeConn that when asyncore calls handle_read without any data, this must be a disconnect and closes the socket
Added a loop in the p2p-acceptblock specific client that waits for the socket to be in a closed state after we expect to be disconnected by the peer
Made expected disconnects non-optional in p2p-acceptblock, which is valid Dogecoin behavior, unlike Bitcoin's test
Synced the test descriptions and outputs with reality

@patricklodder Did you cancel it?

Did you cancel it?

Yes. No point in doing tests without the actual source. Merging #2457 first, then rebasing this, then 🚀🚀🚀

Now rebased on top of #2457

there's a variable name that seems wrong.

Thanks! Missed that. Fixed up now!


Consider writting docs as MD not RST

Although reStructuredText has a greater feature set and is a more powerful documentation language, it seems less maintainable than Markdown. There are less developers that use rst in their daily development while Markdown is ubiquitous across the development world. Most other documentation for IRIS supported code is written in MD and not in RST. If there were a significant amount of docs we would likely not want to change the documentation language, but the documentation seems sparse so it doesn't seem like much refactoring will be necessary to move from rst to md.
Please comment and outline specific reasons for using rst for this project's documentation.

@jcapriot the docs are up and working. Thanks for getting the docs up and working.


Update Slovenian translations for new paths; remove useless strings

Trubar changed the way paths are stored. The file is updated accordingly.
Also, Trubar now correctly ignores docstrings and unused string expressions, so these are removed, too.

Included in #4.


Add free learning resources for react js

Add free learning resources for react js that you know

#goodfirstissue


Clean up _scalar.pyx

Cleans up _scalar.pyx/pxd.

Previously, convert_scalar() returned different types of objects depending on a flag. This is confusing because the return type is obscure.
Unifies CScalar's various creation functions into static methods CScalar.from_xxx().

You might as well review #2918 altogether as it's based on this PR.

Jenkins, test this please.

Jenkins CI test (for commit 0b6113b893c8c5277954c7823bfde6d93fc2cfa9, target branch master) succeeded!


Request: Allow JsDoc on the options of a string literal type.

Would it be possible to support JsDoc comments on the options of a string literal type, so we can leverage the comments in our code editors? (VSCode for example):
For example:
type TMaterialIcons =
    /**
     * ![access-point-network](https://raw.githubusercontent.com/Templarian/MaterialDesign/master/icons/svg/access-point-network.svg?sanitize=true)
     */
    | 'access-point-network'
    /**
     * ![access-point](https://raw.githubusercontent.com/Templarian/MaterialDesign/master/icons/svg/account.svg?sanitize=true)
     */
    | 'account';

Checking the code above with an AST explorer shows that the comments on top of the string literals are ignored. Only 'account' and  'account-point-network' are recognised as StringLiteral. The comments above each value don't show up in the AST explorer so there is no way for a language service provider to show them in the IntelliSense.
Any thoughts?

Well, the compiler considers any given string literal type to be the same, and none of them have declarations per-se. So if you used a literal type in two places, it's not 100% certain you always want to show that doc comment.

Using a (const) string enum should work because each member has a declaration

@DanielRosenwasser @ajafff  Yes, I understand, I didn't think of it that way. Perhaps in this case an enum would have been better if I didn't have 2000+ enum options. I was hoping to have cheap way to show the icon images in the IntelliSense and not having to load a large enum in the browser. In my case the enum  or the type TMaterialIcons ... are auto-generated from large list of options.

Related discussion in https://github.com/Microsoft/TypeScript/issues/25090

@DanielRosenwasser @mhegazy It took some imagination and a good night sleep, but I found a solution to avoid creating a large enum and show the icon images within intelliSense.
Following is a POC.


Update comments for consistency, add TODOs where required

This is the result of reading through the code base for another PR.
The main changes are:
a) corrected spelling mistakes,
b) Comment formatting (capital first letter, period at end),
c) TODOs where comments recommend future work.

This PR is likely to have conflicts with the staging branch, where we're preparing to do a massive (>10,000 lines of code) code merge. Could I have you PR this into that branch and fix any conflicts?

staging branch is focused primarily on the host + wallet. We're working to get that into master this week so that the two aren't so far apart anymore.

@DavidVorick sure thing.

@DavidVorick Yep, done.

Whoa! Is that a new feature? I don't recall being able to switch branches like that before.
These are minor changes but we do really appreciate them. We want our code to look consistent across files so that it's easier to dive into and figure out what's going on.

Updates made, @lukechampine let me know if anything else needs changing.

Looks good to me.


Black Blank Screen with Google Authentication

[x] I have read the FAQ.
[x] I have searched in existing issues.

Environment

OS: Debian 11
scrcpy version: 1.24
installation method: manual build
device model: Nokia 3.4
Android version: 12

When Google Auth app is launched the screen is dark blank for that app.
Other apps used display fine.
Google Auth screen works fine otherwise (ie. on phone's screen with the cable unplugged).

Android version: 11

Are you sure it Android 11, not Android 12?
It's expected on Android 12 (see #36 #2129).

I'm sorry, you're right, I updated the description, I have recently upgraded to Android 12.
Why is it expected, what should I do to prevent that as a workaround?
(Didn't get much information from the linked issues)
Thanks

Since Android 12, the system prevent access to "protected" views with "flag secure", even for the shell user.

what should I do to prevent that as a workaround?

Nothing :disappointed:

Okay, thanks.


Support batch build

CodeBuild now supports conccurent/coordinated builds in a project with batch build.
https://docs.aws.amazon.com/codebuild/latest/userguide/batch-build.html

Do we have any update on this?

Is there an update on this? Batch builds would be really useful to avoid starting multiple codebuild jobs in parallel from Jenkins (which can be problematic when there are lot, e.g. 50+). Thank you


Eliminate ITransport interface

We don't actually use the interface, which has been dropped from Engine.Core, so stop using it as a base for ITestAgencyTransport.

:tada: This issue has been resolved in version 2.0.0-beta4 :tada:
The release is available on:

GitHub Release
NuGet Package


feat: prometheus metrics

Description
Introduces simple metrics for Flask application using prometheus-flask-exporter for mutate endpoints. The metrics are available from the /metrics endpoint.
It also introduces the possibility to specify a different port for the mutating webhook based on the service port.
Checklist

[x] PR is rebased to/aimed at branch develop
[x] PR follows Contributing Guide
[x] Added tests (if necessary)
[-] Extended README/Documentation (if necessary)
[x] Adjusted versions of image and Helm chart in values.yaml and Chart.yaml (if necessary)

Addresses feature issue: https://github.com/sse-secure-systems/connaisseur/issues/511

@xopham, @tluimes and I had a few backs and forth fighting with the tests but we finally managed to get everything green. Thanks for the great help, @tluimes


Bump Swift Tools Version

We we also then want to change the readme to say Xcode 15 is required? Currently says 14.1 or newer.

Do we also then want to change the readme to say Xcode 15 is required? Currently says 14.1 or newer.

@des12437 took care of it in #516.


No CMAKE_Fortran_COMPILER could be found.

Hi there.
I am trying to use openfast on mac for my university dissertation but I have no experience at all trying to set anything like this up. I have followed the instructions as best I can and installed the relevant software but I have ran into an error. When in Cmake and I hit configure it comes up with the error:
The Fortran compiler identification is unknown
CMake Error at CMakeLists.txt:18 (project):
No CMAKE_Fortran_COMPILER could be found.
Configuring incomplete, errors occurred!
See also "/Users/ethan/Desktop/openfast-master/build/CMakeFiles/CMakeOutput.log".
See also "/Users/ethan/Desktop/openfast-master/build/CMakeFiles/CMakeError.log".
Any help/ advice would be greatly appreciated, Thanks.

Can you verify that you have a Fortran compiler installed?

I believe I initially installed gFortran but when that didn't work I installed intel parallel studio Fortran

On a Mac, you can install gfortran easily with Homebrew.
In any case, you need to figure out which Fortran compiler you have installed. You can try these bash commands:
# Intel Fortran
which ifort

# Gfortran version 9 from homebrew
which gfortran

# Gfortran version 8 from homebrew
which gfortran-8

# Gfortran version 7 from homebrew
which gfortran-7

If any of those return a path to a compiler, choose one and then do this:
export FC=<path to a Fortran compiler>

# Then in the same terminal window move into the OpenFAST build directory
cmake ..

If those which commands don't point to a compiler, you either don't have one installed or its not on your path.

Take the brackets out...
ethans-MBP:~ ethan$ export FC=/usr/local/bin/ifort

When I enter that nothing happens. Also I don't really understand what you said to do after that. sorry I'm very new to doing anything like this

Ah ok. You shouldn't see anything happen after the line above, but it sets an environment variable which will be used by CMake. A nuance here is that you're setting the environment variable for your current terminal instance, so if you close the terminal window you lose that environment variable.
Do these commands in a freshly opened terminal:
# set the FC variable - nothing will show after this
export FC=/usr/local/bin/ifort

# make sure its set - the command should return the path you've set above
echo $FC

# move into your openfast folder
cd ~/Desktop/openfast-master/build/

# Run CMake
rm CMakeCache.txt
cmake ..
# in the command above, CMake does lots of things including searching for your Fortran compiler. Since you've set the environment variable FC, you've hinted to CMake where to find the compiler. FC means Fortran Compiler. For C projects, you would set CC. For C++, you would set CXX.

# Compile and install
make -j8 install

When I type in those commands this is what comes up:
Last login: Tue Oct  8 22:59:55 on ttys000
ethans-MBP:~ ethan$ export FC=/usr/local/bin/ifort
ethans-MBP:~ ethan$ echo $FC
/usr/local/bin/ifort
ethans-MBP:~ ethan$ cd ~/Desktop/openfast-master/build/
ethans-MBP:build ethan$ rm CMakeCache.txt
ethans-MBP:build ethan$ make -j8 install
make: *** No rule to make target `install'.  Stop.

You left out cmake ..! :) Its subtle

@gbhn100 let me know if you have any more trouble with this.

when i add the cmake . . this happens:
oa-edu-172-153:~ ethan$ export FC=/usr/local/bin/ifort
oa-edu-172-153:~ ethan$ echo $FC
/usr/local/bin/ifort
oa-edu-172-153:~ ethan$ cd ~/Desktop/openfast-master/build/
oa-edu-172-153:build ethan$ rm CMakeCache.txt
oa-edu-172-153:build ethan$ cmake ..
-bash: cmake: command not found
oa-edu-172-153:build ethan$ make -j8 install
make: *** No rule to make target `install'.  Stop.

@gbhn100 Are you on the same computer? Your command line prompt changed from ethans-MBP:~ ethan$ to oa-edu-172-153:~ ethan$, so just be sure you are on the computer you expect to be on.
In any case, the error message bash gave you is letting you know that it can't find the cmake command. How did you work with CMake the first time?

yes, I am still on the computer. I was at the uni before and connected to their wifi if that would have changed it. I'm home now and it has changed back but I still get the same message:
ethans-MBP:~ ethan$ export FC=/usr/local/bin/ifort
ethans-MBP:~ ethan$ cd ~/Desktop/openfast-master/build/
ethans-MBP:build ethan$ rm CMakeCache.txt
ethans-MBP:build ethan$ cmake ..
-bash: cmake: command not found
ethans-MBP:build ethan$ make -j8 install
make: *** No rule to make target `install'.  Stop.
I have been opening the application, clicking browse source and selecting the openfast folder then clicking configure

Are you running the CMake GUI? If so, you can install the command line version with brew install cmake and then run the commands as I listed above.
Otherwise, you'll have to understand better what the source directory is and what configure means. If you do, then you can absolutely substitute cmake .. with the corresponding commands in the CMake GUI.

ah, thank you. I went and installed cmake through homebrew then when I ran it everything worked. my only problem now is I can't figure out how to open openfast

so I found the openfast executable but I don't understand what you mean by in a terminal, go into your case directory where you have a .fst file

Sounds like using a command line environment may be new to you so here's an intro article on that: https://www.makeuseof.com/tag/beginners-guide-mac-terminal/. I hope that answers some of your questions and gives you some background into using a computer this way.


Hold note score calculation overlap

As a player, I want the score calculation to be consistent so I don't feel punished for duplicate score calculation.

Currently, there is an issue where hold note score calculation can be overlapped with another note. Take a look at this snippet of score calculation:

if (IsHovered && IsBeingHeld()) {
    switch (State) {
        case HoldNoteState.VisibleBefore:
            ScoreBefore += elapsed;
            ScoreInfo.AddScore(elapsed);
            break;
        case HoldNoteState.VisibleAfter:
            ScoreAfter += elapsed;
            ScoreInfo.AddScore(elapsed);
            break;
        default:
            break;
    }
}

Closing as I'm looking more into this


Added worker process that merges LLVM profile data concurrently with the testing suite on a coverage build

When build-script is given --swift-analyze-code-coverage merged, this will fire off this worker which responds to tests and merges generated profile data into a final coverage file in the test results folder.

I also don't see a definition of SWIFT_ANALYZE_CODE_COVERAGE in the top-level CMakeLists.txt, could you add it?

@swift-ci Please test

@swift-ci Please test

@swift-ci Please test

@swift-ci Please test

@modocache If you get a chance, would you mind reviewing profdata_merge_worker.py? Thanks!

Sure thing! @practicalswift is also probably good for some Python opinions. :wink:

@modocache I agree that the script would be better off as a module. Let mw know what you think, and thanks so much for the review!

Thank you for the fascinating read, @harlanhaskins. And I've never seen anyone address comments so quickly! :grin:
My parting thought is that it would be nice if we could verify the behavior of this code without actually building Swift itself--it seems like it would be difficult for someone new to this codebase to verify whether this was working correctly.

@modocache Thanks for the comprehensive review! I really appreciate your input.
The codebase relies really heavily on global out-of-process state, but it's definitely not specific to Swift. This process could be used to merge profile data from instrumented builds of anything, (modulo some hard-coded filenames that explicitly say 'swift'). I could envision a small test runner that compiles a simple C file with profiling and shoots files at the server, then investigates the output, but I don't know if that's on the roadmap for me right away.
Thanks again!

@gribozavr I think this is good to merge. We should probably run the CI once more, though. (@shahmishal, too)

@swift-ci Please test


Toasts - without background color?

Hi, first to all great work!!
Is it possible to display the Toast messages without the semi-transparent background color?
Currently it is displaying the toast with the message at the bottom (as expected) but using semi-transparent background occupying the whole screen (like a modal message as with the rest of the messages).
Is there a way to get only the area of the message without the full semi-transparent part?
I tried to change the background (System.Drawing.Color.Empty) color via ToastConfig but it is ignoring the values set to the Background property.

The toasts in android are provided via AndHUD.  Unfortunately, the background colors don't apply to this mechanism.  You can override the mechanism or switch to the appcompat version to get around this.


Example scenario for Drupal

OPS Build status updates of commit dc5e4e3:
:warning: Validation status: warnings

File
Status
Preview URL
Details

bread/toc.json
:warning:Warning

Details

toc.json
:warning:Warning

Details

building-blocks/extending-templates/toc.json
:warning:Warning

Details

contributing-to/templates/sample-solution.md
:white_check_mark:Succeeded

docs/example-scenario/data/hybrid-etl-with-adf.md
:white_check_mark:Succeeded
View

docs/example-scenario/infrastructure/drupal-linux-azure.md
:white_check_mark:Succeeded
View

docs/example-scenario/infrastructure/hpc-cfd.md
:white_check_mark:Succeeded
View

docs/example-scenario/infrastructure/media/architecture-drupal-linux-azure.png
:white_check_mark:Succeeded
View

bread/toc.json

[Warning] Error happen when converting bread/toc.json to Pdf. Details: Could not find a part of the path 'T:\ste3\bread\toc.json'.

toc.json

[Warning] Error happen when converting toc.json to Pdf. Details: Could not find file 'T:\ste3\toc.json'.

building-blocks/extending-templates/toc.json

[Warning] Error happen when converting building-blocks/extending-templates/toc.json to Pdf. Details: Could not find a part of the path 'T:\ste3\building-blocks\extending-templates\toc.json'.

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

OPS Build status updates of commit 2d96eca:
:warning: Validation status: warnings

File
Status
Preview URL
Details

bread/toc.json
:warning:Warning

Details

building-blocks/extending-templates/toc.json
:warning:Warning

Details

toc.json
:warning:Warning

Details

contributing-to/templates/sample-solution.md
:white_check_mark:Succeeded

docs/example-scenario/data/hybrid-etl-with-adf.md
:white_check_mark:Succeeded
View

docs/example-scenario/infrastructure/drupal-linux-azure.md
:white_check_mark:Succeeded
View

docs/example-scenario/infrastructure/hpc-cfd.md
:white_check_mark:Succeeded
View

docs/example-scenario/infrastructure/media/architecture-drupal-linux-azure.png
:white_check_mark:Succeeded
View

bread/toc.json

[Warning] Error happen when converting bread/toc.json to Pdf. Details: Could not find a part of the path 'T:\e5wh\bread\toc.json'.

building-blocks/extending-templates/toc.json

[Warning] Error happen when converting building-blocks/extending-templates/toc.json to Pdf. Details: Could not find a part of the path 'T:\e5wh\building-blocks\extending-templates\toc.json'.

toc.json

[Warning] Error happen when converting toc.json to Pdf. Details: Could not find file 'T:\e5wh\toc.json'.

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Closed - scenario is on hold.


Can't use a string hostname as the server address

Stylophone 2.2.0 does not connect to my mpd server when I enter its hostname or IPv6 address, it fails with:

Couldn't find an MPD server at this address!

When I enter the IPv4 address is connects immediately.
DNS works and resolves both IPv4 and IPv6 addresses. MPD listens on both addresses.

Indeed, the underlying TcpClients used by MpcNET were initialized with the old IPv4 config, so it makes sense IPv6 wouldn't work 😅
I've modified the library code (https://github.com/Difegue/MpcNET/commit/6bcc61b57b6e3f16102868cce79ddbd2081cd389) to use dual mode sockets, so this should be solved in a future release.

Specifying hostname still is not working. If this isn't an easy fix, then maybe just put a note in the dialog that it has to be an IP?

Hmm I'm not sure if I've tried hostnames, the fix above was mostly for IPv6. Maybe hostnames aren't being translated to an IPEndPoint correctly!
Might as well reopen this with a name change..

Support for this should be available in the next update!


pkg/trace/*: use protobuf everywhere and avoid expensive deserialization/reserialization overhead

Experiment with no-copy editing protobuf on the fly without re-serializing between receiving and sending.

@richardartoul is this still in-progress or could we close it?

Close it!

@richardartoul thanks for the nice experiment and lesson here!


Some minor changes on documentation

Pull Request Template
Description
I was just going though the repo and saw that the readme had some issues, looks like it was AI generated and some wrong stuff was copy pasted so I just fixed that : )
Type of change
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
NA
Additional Context (Please include any Screenshots/gifs if relevant)
...
Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules
[x] I have checked my code and corrected any misspellings
[ ] I have tagged the reviewers in a comment below incase my pull request is ready for a review
[x] I have signed the commit message to agree to Developer Certificate of Origin (DCO) (to certify that you wrote or otherwise have the right to submit your contribution to the project.) by adding "--signoff" to my git commit command.

PTAL @Sonichigo : )


Update MD file on new branch 2017-11-18_21-23-27

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

split/updateTestRef1.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


handle fuge generate parsing exception

handle the thrown error for a call like:
$ fuge generate system
pulling...
Error: could not parse github url: system
    at Object.generate (/usr/local/lib/node_modules/fuge/node_modules/fuge-runner/lib/gitPuller.js:73:19)

The app behavior when receiving an error in a callback is to log the error to console.
Will close it because it is not a case of unhandled parameter parsing case.


Fix ECDHE-PSK-only build configuration

Fixed Issue #270 and added a new configuration file and test to verify the fix.

Thanks! Looks good to me!

Automatic CI verification build not done, please verify manually.

I'm sorry, we finally decided to take a different approach for the tests (we'll use a script to systematically test all configs with a single key exchange), so we won't need your config.h.
Thanks anyway for your contribution, I hope you understand.

Hi @mpg
I think your solution to testing is better. I didn't have the time to propose such a significant change; I just needed a test to show exactly WHY I needed to delete line 254 of include/mbedtls/ssl_ciphersuites.h to allow compilation.
Are you still going to incorporate commit 05fbe18 which includes the actual fix?
Thanks,
-Chris

Yes, the fix is in branch "misc" which is pending review and should be integrated in our next release: https://github.com/ARMmbed/mbedtls/pull/325
This is a bit embarrassing, I kept confusing #270 and #310 as they are quite similar, so I thought there was no PR for #270 (there is none for #310) and fixed it myself... I still attributed it to you in the ChangeLog.

Closing, as #270 is now fixed.


s2nIntegrationBoringSSLGcc9 job failing against master

Problem:
From the 3/30 scheduled run:
[March 30, 2020, 2:55 PM] Malloy, Nicola: Running SSLyze tests with: OpenSSL 1.1.1f-dev  xx XXX xxxx

Traceback (most recent call last):
  File "s2n_sslyze_test.py", line 143, in <module>
    sys.exit(main())
  File "s2n_sslyze_test.py", line 139, in main
    return run_sslyze_test(host, port, fips_mode)
  File "s2n_sslyze_test.py", line 113, in run_sslyze_test
    failed = check_sslyze_results(scan_output_location)
  File "s2n_sslyze_test.py", line 88, in check_sslyze_results
    robot_result = json_obj["accepted_targets"][0]["commands_results"]["robot"]
KeyError: 'accepted_targets'
Makefile:106: recipe for target 'sslyze' failed
make[2]: *** [sslyze] Error 1
make[2]: Leaving directory '/codebuild/output/src092348519/src/github.com/awslabs/s2n/tests/integration'
Makefile:39: recipe for target 'integration' failed
make[1]: *** [integration] Error 2
make[1]: Leaving directory '/codebuild/output/src092348519/src/github.com/awslabs/s2n/tests'
Makefile:81: recipe for target 'integration' failed
make: *** [integration] Error 2

Proposed Solution:

I have a fix for this problem that will let the test pass: https://github.com/awslabs/s2n/pull/1724
However, the reason Travis and Codebuild are using different versions of sslyze seems to be that they are using different versions of python. I turned on verbose logging for pip to get more info and found that Travis does not install the latest version of sslyze because the latest version of sslyze requires Python 3.7, and Travis is only running with Python 3.6 (which is what our python install script installs). Codebuild does install the latest version of sslyze, because it seems to have installed Python 3.7 at some point. Executing "which python3.7" from the Codebuild build script returns "/root/.pyenv/shims/python3.7 ".
If we want to avoid more problems like this, we might want to address this discrepancy.

We actually specify Python 3.7 in the Codebuild buildspec: https://github.com/awslabs/s2n/blob/master/codebuild/spec/buildspec_ubuntu.yml#L18-L19


Make EmrEtlRunner targetable against a cluster that is already running

Following client discussions

done in #3945 , closing


[Markdown] Refactoring and expanding unit tests

Related #2067
Description

Originally, I intended to improve the coverage of the Markdown component, but since the source code was inappropriate, I refactored it. Additionally, I addressed the lack of coverage.

@zonoryo17 @kaitobq
I revised it because some of the English expressions caught my attention when I reviewed it.


Make it so that auth middleware and recovery middleware is added to grpc

Due Date: 06/12/21
Description

In the initalize function, the grpc middleware should be set up based on the config.
The auth middleware should be one of the standard middleware (interceptor).
https://github.com/grpc-ecosystem/go-grpc-middleware

UAT

Place UAT here

Deployment Steps

Place steps here

SubTasks
Auth

[ ] Write test for authentication (grpc)
[ ] Write a new authenticate (grpc) function which takes in a context and returns one as well.
[ ] Write a supporting function to getKey for use in jwt config.

Recovery

[ ]

Repository that has reference to already built interceptors - https://github.com/grpc-ecosystem/go-grpc-middleware

Useful Links:
https://shijuvar.medium.com/writing-grpc-interceptors-in-go-bf3e7671fe48

Example of what initialize the server could
s := grpc.NewServer(weosgrpc.GetStreamMiddleware(),weosgrpc.GetUnaryMiddleware())


Some URIs contain "_" at the end which causes italicisation

Example:

This was because some URIs end with "/" which are replaced by "_"s in the filename. This will be fixed in the next release. Thanks!

This was because some URIs end with "/" which are replaced by "_"s in the filename. This will be fixed in the next release. Thanks!


New Terraform Recipe Schema format for supporting private modules

What content needs to be created or modified?
Updating env schema in docs and Terraform Recipe section
Describe the solution you'd like
New schema:
+   recipeConfig: {
+     terraform: {
+       authentication:{
+         git:{
+           pat:{
+             "github.com":{
+               secret: secretStoreGithub.id
+             },
+             "dev.azure.com": {
+               secret: secretStoreAzureDevOps.id
+             },
+           }
+         }
+       }
+     }
+   }

Where should the new material be placed?

The associated pull request from the Radius code repo, if applicable

Additional context

AB#11232

Closing as complete


Adding decimal point and then numbers on the same animation

hope all is well, I was wondering if you can help me, i like your animation, is it possible to add a decimal point to it?

@oshaban89 hello.
That is the plan that I most want to do.
wait for me or please contribute 😀

close in favor of #23


Add flatten node + add shape to output node

still need to add new tests for flatten

Maybe I missed the discussion. By my understanding the shape could be extracted from the node before the output node. For all other nodes (except Input, where it is necessary), we do not give the output shape. So why explicitly set the shape for the Output node?

@matjobst has a good point, I also don't see the point of having to specify dimension of the output node

It'd be for convenience. Basically, a few people argued that it'd be helpful to directly read the shape directly from the graph instead of inferring it.

very true, just updated to follow pytorch convention


Port cell hover fix and new Interactive extension metadata additions to release branch.

This PR ports the following commits to release:
https://github.com/microsoft/azuredatastudio/commit/8bd5ea5c84f78541fbb625846c3b667ff9840901
https://github.com/microsoft/azuredatastudio/commit/8747ac5c52e10a64bd383b79b229f4eee8ed40ce
These are the tracking issues for those two fixes:
https://github.com/microsoft/azuredatastudio/issues/18980
https://github.com/microsoft/azuredatastudio/issues/19066

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

2 of 2 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.0008%) to 42.26%

Totals

Change from base Build<PHONE_NUMBER>:
0.0008%

Covered Lines:
27678

Relevant Lines:
61226

💛  - Coveralls