Update the behavior of the yellow thread highlight after exiting a thread

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/42165
PROPOSAL: https://github.com/Expensify/App/issues/42165#issuecomment-2408656910
Tests

[x] Verify that no errors appear in the JS console

send a message in any report and Copy a message link.
send copied message link in report and click on it.
Observe the message is highlighted.
Now send a message in chat Verify: Message is no longer highlighted
Repeat step 1, 2 and 3
click on + icon in composer, Verify: Message is no longer highlighted
Repeat step 1, 2 and 3
Click into any other message thread and navigate back with back button, Verify: Message is no longer highlighted

Offline tests

QA Steps

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

https://github.com/user-attachments/assets/44b2c522-a0f1-40b9-b80d-4671f99c5998
https://github.com/user-attachments/assets/13834bfc-98e1-4fd9-9ec5-434c21724902

Android: mWeb Chrome

https://github.com/user-attachments/assets/14b3c2a5-95b5-4317-9ad6-d76671e3a3d3

iOS: Native

https://github.com/user-attachments/assets/357f8ff8-d8c0-459f-8716-20b879f21874

iOS: mWeb Safari
https://github.com/user-attachments/assets/f22e95e9-9cda-456a-a979-26b89eb55e0a

MacOS: Chrome / Safari
https://github.com/user-attachments/assets/708ea188-08cf-4f69-a1c4-55bb44ae2f59

MacOS: Desktop
https://github.com/user-attachments/assets/e22cd914-9db2-48fe-81df-1cf876538156

Thanks @ishpaul777 I will try to review the PR by EOD.

@ishpaul777 We want to remove the highlight only on specific actions:

Clicking out of the chat into another chat
Clicking into another thread
Sending a new comment in the same chat (but not receiving a comment from another user)
Taking any action from the + menu while in the chat

However, with the changes in this PR, the highlight is also being removed for actions like opening the context menu, emoji picker, and FAB, which is unintended.
Also, the highlight should ideally only be removed when opening the RHP (after clicking Submit Expense, Split Expense, etc.) not when clicking + on the Composer.

i can try to refactor this to acheive what you explain but can we confirm this again from desgin team?

@ishpaul777 Yup. Can you please start the discussion in the issue.

Sorry for the delay @ishpaul777
I will try to get it done asap.

@ishpaul777 Let's add the test cases in QA section as well.

Now send a message in chat Verify: Message is no longer highlighted

Should we also add a case to receive message from another user and verify message is still highlighted?

click on + icon in composer, Verify: Message is no longer highlighted

I believe we should change this test case to Click on + icon in composer and take any action.
On native apps and small screen devices as soon as I click on + icon, the message is no longer highlighted.

Click into any other message thread and navigate back with back button, Verify: Message is no longer highlighted

This test doesn't pass. When I navigate back with back button, Message is still highlighted.
https://github.com/user-attachments/assets/276a1e05-43ae-4790-99a4-3712b0e8c357

Any update @ishpaul777?

@ishpaul777 As seen in the video, when a thread is highlighted and we open the RHP through any action, there is no animation during the transition. This behavior differs when the thread is not highlighted.
https://github.com/user-attachments/assets/59f0648e-e3dc-4815-8d07-eaf8f643988c

ON native, the thread remains highlighted even after taking some action like "Split expense".
https://github.com/user-attachments/assets/f45a0b14-24b2-4b68-964b-3eb44c08b572

Reproducible in web and mWeb.
Steps to reproduce:

Highlight message 1
Highlight message 2
Highlight message 1
Open message 2 and press back button
Notice that message 1 is still highlighted.

https://github.com/user-attachments/assets/e8c8489e-2866-479e-9056-860c98f7d7d1

@ishpaul777 Could you please test it in an account with high traffic.

now we will remove the navigation param for reportActionId on small screen which will scroll the user to bottom of the chat.

I don't think this is something we want. As you can see in this comment, we decided not to go with the idea of removing reportActionID because of unwanted scrolling.

i was able to reproduce this only when the a thread is highlighted in large chat, it seem to be removing the highight color is inturupting the transition animation, i have a fix to use InteractionManager.runAfterInteractions while removing highlight but that will cause a slight delay in removing highlight color

This looks much better than the existing condition . I am okay with it.

@ishpaul777 Sorry for the delay, I missed the notification somehow.

On small screen its unnoticable since user already took a action it does not make any sense to keep user linked on the comment, if we dont remove param and it is just acting as user is refreshed page on now landed on comment link first time that's why it show the comment linked. if you notice we did remove the highlight when user navigates but it comes again when we go back becuase reportactionid in param when we go back.

I believe we should maintain the state where the user was earlier in the report.


Bow and Crossbow

Describe the bug

Forge - crossbow_damage_multiplier in config file don't work.
You should check the netherite bow textures, just rename them to display correctly.

Expected behavior
Even if the damage multiplier of the crossbow changes, it continues to do the default damage, the other objects do work correctly.

Fixed in the latest release

Fixed in the latest release


wrong RGB

If I change the brightness of a light I get the same color from ToRgb(). I have noticed that the color coordinates do not change, only the brightness property changes so I guess that method does not take account of this member.

In fact I found the inbuilt color conversion poorly works at all. I had several problems especially while trying to receive the correct color code (RGB or Hex) of the lamps via the actual light state. The conversion tools of the api try to convert based on the CIE XY values.
You need to keep in mind that CIE 1931 XY is based on coordinates and the conversion to common color systems like RGB can be very inaccurate.
I ended up to set colors per Hue, Saturation and Brightness (HSB). It's more easy and accurate to convert colors between HSB and RGB, but there are a few things you need to know about HSB:

Common HSB format: Hue in degrees (0-259);  Saturation from 0 to 100;  Brightness from 0 to 100.
Huelamp HSB format: Hue as integer from 0-65535 (common hue * 182,04); Saturation and Brightness as integers from 0-254.
HSB = HSV

Sorry for my bad english, hope this will help you.

The latest update of the color conversion was in this PR: https://github.com/Q42/Q42.HueApi/pull/46
It would be very helpful to receive more PRs with improvements to the color conversions by someone that really understands this stuff.
@CharlyTheKid any chance you have some custom color conversion code to contribute?

@michielpost as requested i can give you my code for color conversion. You can get my example project from the following dropbox folder.
https://www.dropbox.com/sh/2xobws18ta5kga6/AAAKwPtkNRpJPb8USCe5aXOxa?dl=0
To set color for hue lamp use it like this:
var rgbColor = new RGB(){ R = 250, G = 100, B = 0};
var hsbColor = rgb.GetHSB();
var command = new LightCommand();
command.Hue = hsb.Hue;
command.Saturation = hsb.Saturation;
command.Brightness = (byte)hsb.Brightness;
...

To get actual color from hue state could be like this:
var rgbColor = new HSB(){Hue = light.State.Hue, Saturation = light.State.Saturation, Brightness = light.State.Brightness }.GetRGB();

Some basic explanation:

To make it easy I made two classes named RGB and HSB which contain the methods to convert each other.
You could also return a Color Object from the RGB values.
This conversion is pretty accurate, but there can be little 	rounding errors. (double/float to int cast)
I did this especially for the use of color canvas and color pickers to show the actual color in RGB and HEX from state without any variation.
When testing the code from dropbox please mention the extensions for float and numbers, otherwise this won't work like expected.

If there is any problem with the code or the dropbox link let me know.

Thanks for the code. I'm currently moving the ColorConversion code to a separate assembly and adding the HSB colorconversion from @CharlyTheKid.
The Q42.HueApi.ColorConversions project will contain multiple colorconversion.

The original one based on the conversion array
The one currently in use, based on PR: #46
The new HSB conversion

With this setup it's also easy to add more colorconverters and you can use the ColorConverter that works best for your usecase. It's also less tied to the Q42.HueApi, which is essentially about communicating withthe Hue Bridge.
It's still work in progress and I'm going to add more unit tests.
Have a look at https://github.com/Q42/Q42.HueApi/pull/71 and let me know if this is the right direction.

ColorConverters are now in a separate package, so you can pick your favorite ColorConverter.
PRs and new Coloronverters ar welcome

I'm late to the party, but I was hoping someone would enlighten me about why "FF0000" isn't possible. Is it because the color (and perhaps HSB) ranges are limited to 0-254 instead of the standard 0-255?


Fix deserialization of packets with zero length

Instead of ignoring it, I think the client should be disconnected as that should never happen.


Make it possible to save characters

Users should be able to save their created characters.

This issue appears rather vague to me. So you only want to save characters but not load them?! :stuck_out_tongue:


DPI and aliasing issue while using WinUI 3 against C++

Describe the bug
While using WinUI 3 in a C++ project (without WAP), I found texts and controls are scaled and have aliasing issue.
Steps to reproduce the bug

Use Visual Studio 2022 to create a C++ WinUI 3 Desktop App (no WAP) from template
Build and run
See scaling and aliasing in texts and controls

Expected behavior
No response
Screenshots

NuGet package version
WinUI 3 with WindowsAppSDK 1.0-preview 2
Windows app type

[ ] UWP
[X] Win32

Device form factor
Desktop
Windows version
Insider Build (22471)
Additional context
I don't know but maybe this issue should be transferred to WindowsAppSDK repo?

@gegao18 FYI

The issue still exists in WASDK 1.0-preview3

I can confirm this issue has been fixed in WASDK 1.0 GA.


Touchevents not working on Windows Surface Tablet

On a Windows Surface tablet, the corners of the cropper cannot be moved. The touch event is triggered, but the cropper does not respond to it. The issue occurs when I use the Windows Surface as a tablet. This functionality is essential for us, as most of our business customers use Windows Surface, also as a tablet.

I am investigating with my Windows touchscreen device. It seems that we need to use PointerEvent.

I've released a new version 2.2.3 which works on FireFox. But it does not perform well on Chrome.

On chrome i get this error

Is your Version deployed to https://candid-tarsier-04033c.netlify.app/?

It seems that the license is expired.

I can only move the handler like 10px, then it stops and i have to touch it again an move for another 10px. Other than that the image jumps around when touching. Did you test it on a surface?

Thanks. I've release version 2.3.0 to fix this.

I've also raised an issue for stencil about using touchevents: https://github.com/ionic-team/stencil/issues/5320


Infinite loop in reading GPX file

I'm still debugging this, but I see that there are threads on my server that are using 100% of the CPU - i.e infinite loop.
I have created a dump file and opened it in visual studio.
I found two threads that are "stuck" on 100% CPU, both are inside function of this library.
Here is a screenshot of the dump when I opened it in visual studio:
The code that I'm using to read the gpx file can be seen here:
https://github.com/IsraelHikingMap/Site/blob/4cb8ade62604c6b5ded7f94d944bef1da29893e4/IsraelHiking.API/Gpx/SerializarionExtensions.cs#L108L120

Any help would be appreciated.
I'm using version 1.1.0 as can be seen here:
https://github.com/IsraelHikingMap/Site/blob/4cb8ade62604c6b5ded7f94d944bef1da29893e4/IsraelHiking.API/IsraelHiking.API.csproj#L28L31
Unfortunately I don't have the relevant GPX file...

Ok, I added some logic around the problematic code to catch problematic files and save them to the file system.
I found this file:
Bad_File_132406542477521233.gpx.txt
I see that it does enter an infinite loop as the task that runs this code never finishes on my dev env.
I'll see if I can fork this repo and send a RP or just get more insights as to what caused this.
@airbreather, let me know if you have a few minutes to take a look at this as you'll probably find the root cause faster...

See PR #42, feel free to review the code I wrote and let me know if I need to fix anything.
If this could be pushed to NuGet it would be extremely helpful.
I don't think I have an easy way to workaround this since .net core does not have a way to kill threads and I would like to avoid parsing part of the gpx xml to find out there are issues in it as it would mean I'll need to copy the code to my project...
This is currently running in production and causes threads hangs so I think it's a critical bug.
Getting permissions to this repository would also be nice :-)

FYI, I'm addressing this now.  Your PR #42 is a great start, and my fix is going to be based on that, but it relaxes a little bit too much of the structure that GpxReader promises to obey for me to take it as-is.  Don't worry about updating that PR on my account, I'll build on top of it and merge once I'm satisfied.  I agree that this is a high-priority critical bug.
I do appreciate the failing tests, as they reveal the two actual bugs: this one (where an unexpected top-level child of the gpx element triggers an infinite loop) and, immediately after fixing that, another bug where the loop isn't terminating quite properly when the metadata element is the only child of the gpx element.

Version 1.1.1 is on NuGet now, I have some non-critical things to fix up, which I'll get to after I'm done with my normal work.

Thanks for pushing it! Keep up the good work!
I'm sure we'll meet in the near future with another invalid GPX example :-)


Add pre-commit hook option to cargo dist init

To avoid issues with updates to the project configuration failing in CI because cargo dist generate wasn't run. It would be nice to have an option to install a pre-commit hook when running cargo dist init. A new option could be added to append a pre-commit hook to the local configuration?
I am thinking maybe something like
cargo dist init --install-precommit-hook

cat ./.git/hooks/pre-commit
#!/bin/sh

cargo dist generate --check

My understanding is that git hooks are something that will only impact local git repositories. Pushing hooks isn't a common pattern and recent versions of git do not preserve the executable permission on the file if it is included in any clones or fresh pulls of the file.
cargo-dist init might not be the abstraction since it probably shouldn't be something that requires re-initing the configuration. Potentially this could either be its own sub-command cargo dist install-precommit or maybe there is another sub-command for miscellanea?

 This is definitely worth considering then, especially as an opt-in or separate command.
I think the main obstacle is just making sure it does something workable on windows too.


RouteServiceProvider route bind

Not sure whether this has been asked before or not, but bear with me.
Have generated a routeservice provider for my module.
Have setup Route bind on the before function as indicated below;
public function before(Router $router)
    {
        \Route::bind('worker', function ($hid) {
            return Worker::find(($hid)) or JsonResult::exception('Invalid Worker');
        });
    }

The above doesn't seem to be reached, even adding a breakpoint in teh function doesn't get called.
The service provider was generated via php artisan module:route-provider Abcm
What am I missing?
Thanks.

Hi Good People,
Is there anyone who has been able to work with the RouteServiceProvider in a module?
Literally stuck at the moment. Have tried registering it on  the ModuleServiceProvider register function, but all in vain.
How do I register it or any pointer to documentation on the same?
Regards

Hi,
Yes I'm using the RouteSP one very module I use. Look at the modules here: https://github.com/idavoll

Hi @nWidart, superb library just started to use it.  I've checked Setting and Core from https://github.com/idavoll and you are not using the before() hook.  I'm grepping laravel-modules and laravel for something that calls before() and cannot find anything.
The hook i usually use in service providers is boot().  Should before be boot?  Happy to submit a PR if you agree.

Thank you :)
Hm I haven't heard about that before hook, I've always just used register and boot.

https://github.com/nWidart/laravel-modules/blob/master/src/Commands/stubs/route-provider.stub#L25

Ah I see you mean on the routeSP. Yea you're free to use anything you want in there.

@mfullbrook Thanks for pinpointing the issue. It has baffled me for hours now.
Sure, when I changed it from before(Router $router) to boot() it worked.
@nWidart Thanks for a great library.

You shouldn't have to do that though. The sounds like you haven't extended the laravel route service provider which has the before method.

I don't think there's a before() function in RouteServiceProvider:
https://laravel.com/api/5.5/Illuminate/Foundation/Support/Providers/RouteServiceProvider.html
Check the API link.

The RouteServiceProvider stub extends the generic ServiceProvider not laravel's RouteServiceProvider.  I'll have a play to see if there are any side affects from extending Laravel's RouteServiceProvider instead of ServiceProvider.

Just checked on this, but might have overlooked. Check it out;
https://github.com/laravel/framework/blob/5.5/src/Illuminate/Support/ServiceProvider.php
Binding a model on the boot method on the RouteServiceProvider seem to be returning a boolean.
Has anyone tested this out on the module?


Issue on page /how-to-restructure-pad.html

Hi @jpivarski ,
I'd be interested in this documentation/example, if you have one! Thanks!
Cheers,
Max

Okay, it's bumped up in priority; thanks!
Just to be sure you know about it, the ak.pad_none reference documentation has a few examples.

Thanks! I found that too and it also seemed helpful!

Done in #943.

Thanks @jpivarski !


BetterProgressBar inaccurate percentage (ytdownload-progress)

Describe the bug
BetterProgressBar percentage is wrong when maximum value is set to anything other than 100.
Steps to reproduce

Download a youtube playlist with more than or less than 100 videos
When the progress bar is 50 percent see the percentage on the progress bar is wrong
When the progress bar is 100 percent see the percentage on the progress bar is wrong

Expected behaviour
The progress bar percentage displayed on the progress bar should be accurate.
Download Manager Version
ytdownload-progress: 74dc4f4
Windows Version
Windows 11 Pro Insider Preview 22H2 23475.1000
Comments
No response

Fixed in f0d5490


UI Polish

Description Issue #373
Different UI problems were fixed on this issue:

Logo misaligned with the header

Minors alignments on the homepage

In ProjectTile the client name now is under the project name and the icon changed

All buttons that update/save data now say Save instead of Edit

Budget timeframe and budget amount now are grouped

Tasks that were not mentioned were already fixed.

Update
In component ProjectSummary I didn't want to do big changes since this is going to get a refactor and it also looks good like this for now, so I ended changing the color of the edit button and adding some border-radius to the overview


[doc]Create wikis or faqs for the scenarios that the generator cannot properly generate convenience methods

Describe the issue or request
We need to document the solutions for the cases that our generator cannot automatically generate convenience methods, for instance unions, literal types with number values, patch operations
And we need the generator to automatically generate comments in code to guide them to the wiki item or faq item so that they could make the corresponding customization or client teaspoon

Since now we have the principals of generating things for the unbranded libraries, we no longer need the confident level things, and we no longer need those faqs or wikis specifically.
We might need to write other documents and those should be tracked in other issues.
Closing this one.


Release Script Adjustments

Using the --future-release parameter of github-changelog-generator to have the new CHANGELOG entry be part of the ongoing release / tag.

:+1:


Removed stake.js and liquidate.js, moved functionality into stakingpool.js. Also made stakingpool.js take contracts to use dynamically through props.

Closes issue #9


Profile::profileName value to be added to comments at Profile reference attributes

No Profile referenced at the MacInterface.

No Profile referenced at the MacInterface.


[Feature] Contact from Styled enhnaced

Description
in your website at contact from section i have notched some implement should be done like:
1.the contact information are not decorated properly like there is lack of animation
2. the URL link and website icons are not aligned properly
3. and the social icons are not in the right position
this features improve the UI of contact section to make more engaging to the users.
Screenshots

Checklist

[X] I have checked the existing issues.
[X] I follow Contributing Guidelines of this project.
[X] I am a KWOC'24 contributor.

Code of Conduct

[X] I agree to follow this project's "Code of Conduct".

Go ahead @biswajit-sarkar-007


I need to connect to the DB2 database

I need to connect to the DB2 databse, I tried to use the Keyword "Connect To Database" but not sure what should be the value in dbapimodulename
I am having Python 2.7.8 and working on 64 bit machine , I am not able to install the Pydb2 for this python version and the machine configuration
Please suggest me any way by which the db2 database can be connected by robot scripts

This tracker is for bug reports and enhancements related to Robot Framework itself. This issue is a question about using Database Library and thus invalid. Questions are best asked on robotframework-users mailing list and other similar forums.


[2.7.11] KDM update for RKE2/K3s Jan K8s patches

Tracking issue to sync Jan patches RKE2/K3s k8s versions 1.26.13 and 1.27.10 to 2.7.11. dev-v2.7 branch is used for v2.7-Patch1 effort currently and that's where Jan patches should be added too (including 1.27.x version).
https://github.com/rancher/rancher/issues/43937

This was added and validated and results posted on the PR itself: https://github.com/rancher/kontainer-driver-metadata/pull/1322#issuecomment-1939377574


Document Api Reference if MFA is activated

https://docs.nhost.io/reference/hasura-auth/api-reference
Under Authentication swagger the post /signin/email-password there is no example return field if mfa is activated.
I want to at least know the flow if mfa is activated, does signin will return access toke and refresh token even if they didnt fullfil mfa

Hello, sorry for the late reply.
There is a mfa field in the payload that contains the ticket when MFA is activated, please have a look at the OpenApi specs.
Access and refresh tokens are only returned when the user finished their authentication i.e. when there is no need to complete MFA


Support "default" and "5XX" types of response status code

Which package are you using?
chai-openapi-response-validator
OpenAPI version
3
Describe the bug
Support "default" and "5XX" types of response status code. Those responses are valid based on the open api documents.
https://github.com/OAI/OpenAPI-Specification/blob/master/versions/3.0.0.md#responsesObject
https://swagger.io/docs/specification/describing-responses/
OpenAPIValidators doesn't seem to support these responses other than status codes in number.
To Reproduce
Sorry for not having time to provide recreation test case.

In open api spec, add 2 different types of response type, "200" and "default", under responses section for whatever path and method

In a test, call satisfyApiSpec with actual response with 400 status code

Test fails with
     expected res to satisfy a '400' response defined for endpoint 'GET /aaa/bbb' in your API spec
     res had status '400', but your API spec has no '400' response defined for endpoint 'GET /aaa/bbb'
     Response statuses found for endpoint 'GET /subject/{subjectCode}/{apiVersion}/textbooks' in API spec: 200, default`

Expected behavior
The response is supposed to be validated based on the "default" response definition under responses
Additional context
Reproduce steps above are only about default. But I can see that OpenAPIValidators doesn't support status code range such as "5XX" either
Are you going to resolve the issue?
I'd like you to confirm this is a bug or there's something I'm missing.

Thanks @leonoh-oua! I think we overlooked this functionality. The bug is occuring because we currently throw an error if the actual status code doesn't exactly match that of any responses in the API spec.
As you say, if there are no exact matches, instead we should try to match (e.g.) 400 to the defined 4XX response in the spec if there is one. If there's still no match, we should try to match the defined default response.
To capture this in tests, we probably want new tests here asserting:

200 matches 2XX when no 200 response in API spec
200 matches default when no 200 or 2XX response in API spec
(optional) 300 matches 3XX when no 300 response in API spec

And we may want to update the current error messages thrown when there are no matches, e.g.
res has status '200', but your API spec has no '200', '2XX', or 'default' response defined ...

If you'd like to contribute a PR, I'm happy to support you with advice or by writing the tests. Let me know :)

Thanks @leonoh-oua! I think we overlooked this functionality. The bug is occuring because we currently throw an error if the actual status code doesn't exactly match that of any responses in the API spec.
As you say, if there are no exact matches, instead we should try to match (e.g.) 400 to a 4XX response in the spec. If there's still no match, we should try to match a default response.
To capture this in tests, we probably want new tests here asserting:
* 200 matches 2XX when no 200 response in API spec

* 200 matches default when no 200 or 2XX response in API spec

* (optional) 300 matches 3XX when no 300 response in API spec

And we may want to update the current error messages thrown when there are no matches, e.g.
res has status '200', but your API spec has no '200', '2XX', or 'default' response defined ...

What do you think of that error message?
Also, if you'd like to contribute a PR, I'm happy to support you with advice or by writing the tests. Let me know :)

I wish I would have time to fix it myself :/ I agree with @setaman . Your suggested error message looks good to me too.

Hey, I am encountering the same issue, any ETA of merging #271 ?


Create npm package

We should add an NPM package to make it simple to install the CLI tool, and update the README with installation instructions.

https://www.npmjs.com/package/@recordreplay/replay-node-cli


getText doesn't seem to always works

While trying to track a weird problem, it seemed to stem from getText() returning an empty string, even when I can see the correct element is being selected and the expected content is shown when I use getOuterHtml() or getHtml().
There is a major difference in the implementation between this:
https://github.com/minkphp/webdriver-classic-driver/blob/9567c6e77c2b89dcdc5a5f567ce826c1a831de1f/src/WebdriverClassicDriver.php#L297
vs:
https://github.com/minkphp/webdriver-classic-driver/blob/9567c6e77c2b89dcdc5a5f567ce826c1a831de1f/src/WebdriverClassicDriver.php#L304
I was able to solve my problem by using:
return $this->getElementDomProperty($this->findElement($xpath), 'innerText');

I have a feeling the original implementation was the same in all three cases, so now I'm wondering which case is really the correct one..

This is what Git Blame from 2012 year on MinkSelenium2Driver shows:

the getText method always used Selenium Server native method for that
the getHtml method always used innerHTML property from the JavaScript

As long as the test suite passes I'm fine with the proposed fixing approach.
P.S.
There are several issues/prs about this on MinkSelenium2Driver.


[BUG] Select menu not displaying any value initially

Is there an existing issue for this?

[X] I have searched the existing issues

Current behavior
The select menu is set up to show a value that has been stored locally but it displays nothing.
Expected behavior
Initially, it should show the saved local storage theme, either system, dark or light but it shows absolutely nothing.
Steps to reproduce

Scroll down to the footer
Take a look

Environment (remove values that do not apply)
- OS: macOS and iOS
- Browser: Google Chrome

Anything else?

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Console log


ngnix is complaining about missing conf file

while starting nginx in docker  nginx is complaining about the missing /etc/nginx/conf.d/default.conf. I commented out the rm command in the docker file. now the failure comes in line 7 of nginx.conf ...host not found in upstream "app".
I have absolute no idea what to do. I composed the whole from the directory /home/xxx/ebay-kleinanzeigen-api as proposed.

Hey @mascheck55
This project is not maintained anymore. I've created a new scraper API for various online marketplaces. It's not open source. If you're interested, we can discuss your use case, and I will give you access to the API.


Reverse complement?

Not sure what the question is. Maybe take a look at the --rc option? (See --help for more detail.) I'll close this up in the meantime.

Thanks for the reply! Sorry for the vagueness. I can't seem to get it to work with --rc
Is this the right way to do it:
$ ./kmer-counter --fasta --k=6 --rc <fasta_file> --rc

You don't need to add --rc at the end:
$ ./kmer-counter --fasta --k=6 --rc <fasta_file>

I'm sorry to bother you but I can't seem to get that to work. I can't find reverse complements in the output.


Cannot update keybase, "Access Denied" to prerelease.keybase.io / Tor

Unable to update Keybase.  I would guess you are blocking Tor?  Is that really necessary?  I think not.
Err http://prerelease.keybase.io/deb/ stable/main keybase amd64 2.5.0-20180802173336.f9c762fe53
  403  Forbidden [IP: <IP_ADDRESS> 80]
E: Failed to fetch http://prerelease.keybase.io/deb/pool/main/k/keybase/keybase_2.5.0-20180802173336.f9c762fe53_amd64.deb  403  Forbidden [IP: <IP_ADDRESS> 80]

And when visiting the URL in a browser, the following is returned,
<Error>AccessDenied<Message>Access Denied</Message><RequestId>6705E4FA5BDF31C0</RequestId><HostId>MRUr40qDBtr6JNvKLJCgwur887+RMa8QgqkBVBKFEyVqvxZLJkjRCI0/YIxBEH2MIuR3lZyJgbs=</HostId></Error>

I just got the same error, not using tor, just coming from a Mozilla owned IP space
E: Failed to fetch http://prerelease.keybase.io/deb/pool/main/k/keybase/keybase_2.6.0-20180814163904.23e84dff6f_amd64.deb  403  Forbidden [IP: <IP_ADDRESS> 80]

Note, the IP listed in @scarf  and my report are not our IPs, but IPs in the Amazon IP range.
I suspect all Ubuntu updates are failing currently.
The command I ran that got his error was
sudo apt upgrade

and my keybase apt repo looks like this
$ cat /etc/apt/sources.list.d/keybase.list
### THIS FILE IS AUTOMATICALLY CONFIGURED ###
# You may comment out this entry, but any other modifications may be lost.
deb http://prerelease.keybase.io/deb stable main

Aha, here's the problem. I'd not run apt update before apt upgrade and keybase isn't keeping the older versions of the deb packages on their site. I'll open a new issue that speaks specifically to this.
Keybase should allow clients to fetch a package, that in this case, was only 2 days old.


[Feature Request] Support CF metadata

Description
It would be helpful to have ability to specify labels and annotations right in mta/mtad files.
Additional information
It would be nice to have something like:
ID: "my-mta"
_schema-version: 3.3.0
version: 1.0.0

modules:
  #A cf app which will be bound to the service
- name: my-app
  type: application
  path: "appBits.zip"
  requires:
    - name: my-service
  parameters:
    instances: 1
    labels:
     environment: staging
     type: core-modules
    annotations:
      last-change:
        author: John Doe
        date: 12-12-12
        commitId: abc4567

Hello,
Thanks for providing feedback!
multiapps-controller does not provide support to users to modify CF metadata. However, it uses it to store MTA related data.
I would like to understand more about your use case:

Do you use MTA deployment provided by SAP BTP?

What is the end-to-end scenario?
Is it an option to use CF app env instead?

Best Regards,
Boyan

Hello,
I see it as well that metadata is hidden from us in mta/mtad, but in CF manifest it is available.

We use SAP BTP
We use SAP BTP
For now we store in CF space's tag the latest hash, which later we're using to calculate difference between different spaces
Possible, but looks not so right

Another scenario which came to my mind:
For security validation we need to implement rate limiting. For different type of applications rate limiting should be one of 2 types: jwt-based or host-based. Currently we mark our applications with one of 2 types in our script, and store this configuration there.
It would be a nicer solution to make this a label instead and store this in mta[d] file itself where all the configuration is stored. Then we could simply select all the applications with specific rate limiting type with 1 command or api query.
It is possible to store in env variables as well, but this has its own downsides, like polluting env variables, additional calls.

The current possible way is to do it with env variables. Support of CF metadata is not in the mid-term roadmap of the service


Custom Scroll-Bar absent in DSA Problems page

Describe the bug
Custom Scroll bar is absent in DSA Problems page, in rest of the pages it is present. I would like to add the same custom scroll bar(feature) in this page also.
Possible solution
I would like to add the same custom scroll bar(feature) in this page also.
Screenshots

Kindly assign me this issue as a part of GSSOC21.

I want to work on this issue.


Adds a --json flag to gslc

Adds a --json flag to gslc. Writes out a JSON representation of the assembly results.
Used by Autodesk's GSL extension for Genetic Constructor - https://github.com/autodesk-bionano/genome-designer/tree/master/extensions/gslEditor
Thanks!

Thanks so much for the feedback, @chrismacklin !

@chrismacklin , is there a F# lint or style guide that I could follow for the indentation and function recommendations ? I'm worried i might introduce other style violations

Unfortunately F# is a little bit scattered here, the language doesn't have
quite the same rigorous dogma of style as Python (which is a little
unfortunate as langs with semantic whitespace really benefit from it, IMHO).
Here are a couple places to start:
https://fsharpforfunandprofit.com/posts/fsharp-syntax/
https://docs.microsoft.com/en-us/dotnet/articles/fsharp/language-reference/code-formatting-guidelines
A few guidelines that I use for style:

Function pipelines constitute a single expression and should thus all
have the same level of indentation.  Each |> operator is another action, so
it is nice to give them each their own line, in the spirit of one line of
code does one thing.
I try to write with a 100 character line width limit, though staying
shorter than that is ideal.
If a function call doesn't fit neatly on one line, first try dropping the
list of arguments down one line and in one level of indentation. If it
still doesn't fit inside the ruler, drop all of the args into a little
stack, indented by one level relative to the function call.

For the most part, I've found that (for the same reasons it produces nice,
legible Python) applying the recommendations of Python's PEP8 to F# leads
to clean, readable code.
On Tue, Oct 11, 2016 at 1:10 PM, Rupal Khilari<EMAIL_ADDRESS>wrote:

@chrismacklin https://github.com/chrismacklin , is there a F# lint or
style guide that I could follow for the indentation and function
recommendations ? I'm worried i might introduce other style violations
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Amyris/GSL/pull/1#issuecomment-253031162, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ALRqWoEmF3kH8SOnwO_P42Ouu-JhjhULks5qy-1SgaJpZM4KRTvo
.

Thanks @chrismacklin, that was very useful ! I have modified the code as per your comments.

Looks great, sorry for the slow merge this fell off my radar.


[Sage-408] Hero - Foundations Update

Description

Updates Hero component to Foundations design specs:

Updates row gap to 16px
Updates margin for title and body to 36px
Updates title and body text

Title: Heading 4 styles
Body: Grey 700

Adds borderless prop
Adds custom_background_color prop

Figma
Implementation Updates
N/A
Follow-up Items
N/A
Screenshots

Before
After

Testing in sage-lib

View Hero
Check that component matches Foundations design specs

Testing in kajabi-products

(LOW) Updates Hero component to Foundations design specs.
Related

Sage-408

The Container sizes update seems to have caused a sizing issue with this component's max-width. I've updated the sizing to "full" for now but will open up a follow-up ticket to address this further.


Accessing state after signin

I am sending some state with my signin request as wish to access it again once the signin is complete
export const SimpleLogin: React.FC = (): JSX.Element => {
  const auth = useAuth();

  return (

      <div>
        {auth?.userData && (
         <>{auth?.userData.profile.name || ''}</>
        )}
        {!auth?.userData && (
          <button onClick={() => auth?.signIn({ state: { targetUrl: window.location.pathname } })}>
            Login
          </button>
        )}
      </div>
  );
};

i need to access this state after login so that i can redirect to the correct path in my application, however state is undefined on the User object in the onSignIn event
<AuthProvider
      authority='someAuthority'
      clientId='someclientid'
      automaticSilentRenew
      responseType="code"
      autoSignIn={false}
      onSignIn={(user) => {
        console.log(user.state);
         // user.state is undefined
      }}
      scope="openid profile email "
      redirectUri={window.location.origin}
    >
      <RestOfMyApp />
    </AuthProvider>

How can i get access to the state after signin. I can see that the state is being included in the query paramaters along with the code on the redirect url, but cant work out how to access it, any help would be greatly welcomed
I noticed #36 allows the state to be sent to the authorizer server so presume it is getting through? Bu then not accessible when try to access onSignIn? @johnkors  @cobraz  any thoughts?
thanks, Ed

Hello @ed-sparkes!
Thanks for using oidc-react. That's an interesting question, as oidc-react handles the callback action here:
https://github.com/bjerkio/oidc-react/blob/cbc1204b0b2f075d3d89761faa6187932dd5066a/src/AuthContext.tsx#L87-L92
We don't currently have a way for you to get state. However, it would be pretty trivial to get it. A simple addition to line 88 where the state is returned to our onSignIn handler would probably do it. Mind you, we are looking into improving the how we handle callback-ing in #313. I haven't personally had the chance to look into that yet, so feel free to contribute! Would love to get a pull request, feedback or otherwise! If you feel like creating a simple PR to fix this particular issue, I wouldn't mind that either :)

Agree, @ed-sparkes . Re: #36 . The solution didn't end up adding much value, since it didn't include getting the state back after sign-in. I guess I forgot to add that comment to #36 😅 ..

Ok i raised a PR with the following change. Seemed unnecessary to call getUser when the signincCallback contains the user so i removed that, if there is some reason why this was being done please let me know
if (hasCodeInUrl(location)) {
        const userAfterSignIn = await userManager.signinCallback();
        setUserData(userAfterSignIn);
        onSignIn && onSignIn(userAfterSignIn);
        return;
      }


fix: make deploy workflow reusable

:tada: This PR is included in version 4.14.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


DirectoryProperty#file(Provider) looses task dependency

In Gradle 7.1
abstract class Foo : DefaultTask() {
    @get:OutputDirectory abstract val outDir: DirectoryProperty
    @TaskAction fun foo() {}
}
abstract class Bar : DefaultTask() {
    @get:InputFile abstract val inDir: RegularFileProperty
    @TaskAction fun bar() {}
}
val foo by tasks.registering(Foo::class) {
    outDir.set(layout.buildDirectory.dir("bam"))
}
tasks.register<Bar>("bar") {
    inDir.set(foo.get().outDir.file(provider { "baz" })) // breaks task dependency
//    inDir.set(foo.get().outDir.file("baz")) // preserves task dependency
}

looses the task dependency of outDir.
Replacing inDir.set(foo.get().outDir.file(provider { "baz" })) with the commented file(String) variant inDir.set(foo.get().outDir.file("baz")), the task dependency is preserved.

You mention Gradle 7.1, does that mean it is a regression compared to 7.0?

No, that's just the version where I found it.
Nothing worse than reading an issue created half a year ago and there is no trace of affected version.
I now tried some versions, happens the same with 7.0.2, 6.8.3, 6.1.1, 5.6.4.

An alternative is to not unbox the TaskProvider:
tasks.register<Bar>("bar") {
//    inDir.set(foo.get().outDir.file(provider { "baz" })) // breaks task dependency, eager 'foo' realization
//    inDir.set(foo.get().outDir.file("baz")) // preserves task dependency, eager 'foo' realization
    inDir.set(foo.flatMap(Foo::outDir).map { it.file("baz") }) // preserves task dependency, does not trigger eager 'foo' realization
}

It has the advantage of not triggering eager realization of foo, in case bar is not executed (e.g. gradle :help --task=bar).

The eager realization of foo is not relevant at all. foo was just there for the sake of a concise self-contained example. In a more real example you have a property of type DirectoryProperty that someone sets from the outside with a DirectoryProperty and then in the inside you want to use file.

Duplicates

#6361

While this issue seems to be a duplicate #6361, that one is obsolete, and this one is not. Reopening.

@Vampire, we're using that flag for a very specific internal purpose (despite the generic name) and for that particular purpose, we aren't interested in this issue (even though it's a valid one).

Ok, just wanted to make sure, as it had that label before you initially closed it as duplicate. :-)


Wrong information in the line "Sign in to Graph Explorer on the left menu"

You sign in to Graph Explorer on the top right.
Also, please ad information on where to find the GroupID (I found it by selecting 'Microsoft Teams' in the left menu, and then 'GET my joined teams' where I found the ID.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 3b51b67a-d89c-723f-3520-87cb2dc93b90
Version Independent ID: 78d10cbc-d75b-2b02-d49c-2c3fe1579807
Content: Manage teams in the Microsoft Teams admin center - Microsoft Teams
Content Source: Teams/manage-teams-in-modern-portal.md
Service: msteams
GitHub Login: @MikePlumleyMSFT
Microsoft Alias: mikeplum

Hi @RipRapRob, thank you for your feedback.
I'm updating the step to sign in in Graph explorer. Related to your 2nd concern, we can find the following sentence in the article:
"Replace {groupid} in the Query for the actual GroupId in question, which you can get via the Exchange Online PowerShell, with the "Get-UnifiedGroup" cmdlet, as the "ExternalDirectoryObjectId" attribute."


Fixes #14209

  Thanks for submitting a PR! Please read these instructions carefully:

[ ] Explain the motivation for making this change.
[ ] Provide a test plan demonstrating that the code is solid.
[ ] Match the code formatting of the rest of the codebase.
[ ] Target the master branch, NOT a "stable" branch.

Please read the Contribution Guidelines to learn more about contributing to React Native.

Motivation (required)
What existing problem does the pull request solve?
Test Plan (required)
A good test plan has the exact commands you ran and their output, provides screenshots or videos if the pull request changes UI or updates the website.

Looks like you forgot to fill out the PR template.

Need to be fixed in another way. I`ll back to that little bit later


Script crashes on launch

discord.py now needs Python 3.8 or higher to work, so I downloaded the latest python version (3.9.6 64-bit).
The bot_main.py script closes instantly when opened, and spits out the following error when opened with command prompt:
E:\MC servers\remote-minecraft-server-start-from-discord-master>bot_main.py
Traceback (most recent call last):
File "E:\MC servers\remote-minecraft-server-start-from-discord-master\bot_main.py", line 11, in
bot_settings = json.loads(settings_json)
File "C:\Users\Quint\AppData\Local\Programs\Python\Python39\lib\json_init_.py", line 346, in loads
return _default_decoder.decode(s)
File "C:\Users\Quint\AppData\Local\Programs\Python\Python39\lib\json\decoder.py", line 337, in decode
obj, end = self.raw_decode(s, idx=_w(s, 0).end())
File "C:\Users\Quint\AppData\Local\Programs\Python\Python39\lib\json\decoder.py", line 353, in raw_decode
obj, end = self.scan_once(s, idx)
json.decoder.JSONDecodeError: Invalid \escape: line 3 column 23 (char 56)
I have filled in the settings.json file and double-checked but couldn't find anything myself.

Tried again with version 0.16.6 of discord.py and the last version of python 3.6, but the exact same error is shown.

Man, this is a really old script! Anyways, since you're on Windows, I suspect the problem is that you need to use double backslashes in your file and directory paths, otherwise the slashes will be treated as escape characters.
Minimally, in order to get the bot running on latest discord.py 1.7.3 + Python 3.9.6, you'll also have to swap out lines with bot.send_message with whatever discord.py uses now, or comment it out or replace it with pass or something.
Let me know how you get on. If you end up replacing bot.send_message and the other bot methods that start with await with the newer versions, feel free to make a pull request or something.

Also I'm really curious how you found this bot!

I only realized the script isn't that new midway through and decided just to go for it. Surprisingly there's still no good alternative to this day afaik.
I've probably spent over 10 hours spread over 2 weeks googling for something that could turn on a server, used to do it using parsec and just remoting into my pc but it uses way too much bandwidth. Then finally found this in some last attempt to find something that'd work.
Also fixed the script and it works with the newest version of discord.py and python now. You were right about the double backslashes.
No idea how to make a pull request but I'm sure I can figure it out with some googling, I only had to make some minor changes, thanks for the useful script :D

I'm glad my script has come in handy for you! I just kinda made the script a long time ago and didn't really end up using it, so I'm glad someone's found some utility in it.
You can fork the repo on the top right of the repo page, and then you can commit your new version of the script to your fork's repo. Then in this repo you can go to the Pull Requests tab and make a pull request. Just make sure you don't accidentally check in your bot credentials.
https://docs.github.com/en/github/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request-from-a-fork

Since #2 has been merged in, I'm closing this issue.


Does not work in case of participles and linking verb

Please consider those cases as well:

oxuyan uşaqlar -> must return stem - "oxu", but returns "oxuyan"
gedərkən gördü -> must return stem - "get", but returns "gedərkən"

Thank you, Mammad ( @mammadhajili ), for contributing!
Ziyaddin ( @ziyaddin ) and Samir ( @smr3mdv ) let's consider these cases, too.

For some reason, some participles including "oxuyan" are on the list of words and must be removed.
Suffix forms (-kən) of conjunctives (ikən) must be added to the list of suffixes.

@smr3mdv , appropriate suffix must be "arkən(ərkən)" for the second case. For preventing further issues related to participles and linking verbs, I recommend you add all suffixes, not only "an(ən)" or "arkən(ərkən)".

@mammadhajili "-arkən(-ərkən)"="-ar(-ər)"+"ikən". This is not the only case suffix form of "ikən" is preceded by an inflectional suffix ("-mış^4"+"ikən"). If your advice is followed, all possible combinations of suffixes will need to be generated and added.


make pip installable

once matchms has a pip package (lightweight) we can also add spec2vec to pypi

will be done with PR #39

Done. It is now on pypi.


Trancated xhr response in Edge - resolved via hackery!

Hi,
I had an issue that Edge would randomly truncate my initial long response after the connection, I think potentially related to this open bug: https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/6346939/
It's really odd because in XHRTransportInternal.prototype.onStart if you console.log(this) and look at xhr, the response is correct and not truncated, but if you console.log(this.xhr) the response is truncated to around 630 chars (exact length varies between messages).
I think it's a timing issue, and my work around is to move the contents of XHRTransportInternal.prototype.onProgress to another function which is then called like this:
XHRTransportInternal.prototype.onProgress = function () {
if (!UAisEdge){
XHRTransportInternalProgress(this);
} else {
setTimeout(XHRTransportInternalProgress, 1, this);
}
};
function XHRTransportInternalProgress (xhrtransportinternal) {
xhrtransportinternal.onStart();
if (xhrtransportinternal.state === 2 || xhrtransportinternal.state === 3) {
xhrtransportinternal.state = 3;
var responseText = "";
try {
responseText = xhrtransportinternal.xhr.responseText;
} catch (error) {
// IE 8 - 9 with XMLHttpRequest
}
var chunkStart = xhrtransportinternal.charOffset;
var length = responseText.length;
for (var i = xhrtransportinternal.offset; i < length; i += 1) {
var c = responseText.charCodeAt(i);
if (c === "\n".charCodeAt(0) || c === "\r".charCodeAt(0)) {
xhrtransportinternal.charOffset = i + 1;
}
}
xhrtransportinternal.offset = length;
var chunk = responseText.slice(chunkStart, xhrtransportinternal.charOffset);
xhrtransportinternal.onProgressCallback.call(xhrtransportinternal.thisArg, chunk);
}
};
Horrible hackery I know, but it works. I'm sure you can come up with a more elegant solution. I've attached my version of the file.
eventsource.yaffle.js.zip
Thanks

@georgekaz, https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/12224510/ - is it about this issue?

There is another block in the code to check responseText every 500 ms:
    if (("readyState" in this.xhr) && global.opera != undefined) {
      // workaround for Opera issue with "progress" events
      this.timeout = setTimeout(function () {
        that.onTimeout0();
      }, 0);
    }

I think, it is better to use it for Edge.

Yes, could be related to that ms issue as it's a new problem as far as I know. How would I use the other block you mention in this case? If they've fixed the edge bug in v16 I might just wait til they roll that out and switch back to your trunk version.


CLI: stack upgrade/build to fetch from registry

Stack install supports using registry directly without downloading the .yml first:
$ kontena stack install --name jakolehm-mongo --deploy jakolehm/mongo

Same behavior for stack upgrade/build/? ?

Fixed in 1.1.


When there are 4 or less slides with wrapAround, transition is broken

https://codesandbox.io/s/ncpb8
The issue is seen in the codesandbox. When swiping the transition is broken.

Transition from does break when there are 4 or less.

I can confirm the issue is present, four or fewer slides - the transition is not behaving as supposed.

if there a four slides, transition got breaking. it must to slide right to left but reversed.

@ismail9k are you still maintaining this package? Or we should search for another solution outthere?

This issue has been fixed in v0.1.32

This issue has been fixed in v0.1.32

Its not. With 2 slides and warpAround=true it allways slide to the right no matter what arrow you press.


Use native Node WebSockets for hmr

Is your feature request related to a problem? Please describe.
Maybe we can handle error from #477 I hope so :)
Describe the solution you'd like
We can implement it anyway, because with this approach we can't avoid dependency which are not longer necessary (since Node 21) :)
PS: We can't do it WebSocketServer that way, because Node doesn't support it :(

It has no sense till node support WebSocketServer, because anyway we still need ws package


return Message instances from produce

This pull request fixes #398 by returning the Message instance added to the Producer's internal queue from a call to produce(). I can't see anything that this breaks, but I may be overlooking something. The benefit of this change is that it allows unambiguous matching of produced messages to those popped from the delivery report queue.

Putting this on hold for the time being. It's pretty innocuous except for the fact that it exposes the Message interface, which we're not completely certain is ready to be exposed in a public API.

I think it might be ok to merge this now. Any opinions @yungchin @kbourgoin?

Codecov Report

Merging #403 into master will decrease coverage by 0.11%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #403      +/-   ##
==========================================
- Coverage   85.95%   85.83%   -0.12%
==========================================
  Files          27       27
  Lines        3296     3142     -154
  Branches      519      496      -23
==========================================
- Hits         2833     2697     -136
+ Misses        321      310      -11
+ Partials      142      135       -7

Impacted Files
Coverage Δ

pykafka/producer.py
89.22% <100%> (+1.6%)
:arrow_up:

pykafka/utils/socket.py
81.25% <0%> (-18.75%)
:arrow_down:

pykafka/managedbalancedconsumer.py
75% <0%> (-6.82%)
:arrow_down:

pykafka/partitioners.py
80% <0%> (-2.86%)
:arrow_down:

pykafka/balancedconsumer.py
89.93% <0%> (-1.73%)
:arrow_down:

pykafka/simpleconsumer.py
85.86% <0%> (-1.52%)
:arrow_down:

pykafka/topic.py
78.88% <0%> (-1.12%)
:arrow_down:

pykafka/rdkafka/producer.py
94% <0%> (-0.45%)
:arrow_down:

pykafka/handlers.py
95.38% <0%> (ø)
:arrow_up:

pykafka/client.py
95.23% <0%> (ø)
:arrow_up:

... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 402c5b1...b0c425d. Read the comment docs.


Remove code for the legacy proxy message store

This is mostly done, some refactoring still could be done, but it's not unique to this issue.


Git remotes management

Describe the feature or enhancement
Right now, git-sync clones a repository with the default remote using the current information from the config (token, server...), but never updates this information.
If for instance, the token I originally used gets expired or if I choose to fork my repository to another instance/service (even though the commit history is the same), I'll have errors. In summary, we could say that git-sync doesn't keep the repositories updated with the config file as it changes.
One way I thought about handling this, is git-sync updating/creating a specific remote to use with its operations (could be named git-sync or something else, just to not fall under the default "origin"), and always keep this remote in sync with the config file as a pre-task before any operation.
So if I have a config setup with GitHub, git-sync would check if I have the repository cloned (the "folder exists" check, like nowadays) then it would upsert the remote it manages, creating or updating the remote as needed (but if there's a way to supply the remote as an argument to every git command, I think this works too and might be even better).
If in the next run of git-sync, tokens have changed or I changed my client to Bitbucket, since git-sync will always as a pre-task upsert the remote, the sync would run successfully and get the config change without needing to sync from scratch again (of course, if the username changes, I think it should be considered as a different config and so, sync from scratch, since it's part of the repository "full name").

Linking to the previous discussion regarding this: https://github.com/AkashRajpurohit/git-sync/issues/42#issuecomment-2386517392


Smaller Binary by Manual Code Removal

Description
I've tried to use treeshaking and a dozen other things to shrink the CNDI binary. I didn't expect that importing without a * would result in any gains, but I tried anyway. Maybe importing less code means shipping less code? Seems like low-hanging fruit for a compiler to catch, but worth a try!

Test Instructions

Code of Conduct
By submitting this Pull Request, you agree to follow our
Code of Conduct

[ ] I agree to follow this CNDI's Code of Conduct

Notes (Optional)

this resulted in literally no change to compile binaries!


Open the GitHub web interface to create the new pull request

Instead of specifying a message/file/editor, just open the github page for a new pull request with the specified base and head. This way I can use the github interface for entering my message and description (also gives me the autocompletion for tagging reviewers).

:+1:

:+1:

:+1:

:+1:

lml


list.FlattenN does not work with #Defs

What version of CUE are you using (cue version)?
master: 1d8c688
Does this issue reproduce with the latest release?
Not with < 0.3...
What did you do?
package flatten

import "list"

#MyDef: {
        name: string
        ...
}

_all: [
       _a,
       _b,
]

_a: [...#MyDef] & [
{ name: "a" },
{ name: "b" },
{ name: "c" },
]

_b: [...#MyDef] & [
{ name: "1" },
{ name: "2" },
{ name: "3" },
]

output: [...#MyDef] & list.FlattenN(_all, 1)

changing _all to the following works:
_all: [
        [ for elem in _a { elem } ],
        [ for elem in _b { elem } ],
]

What did you expect to see?
$ cue eval flatten.cue
#MyDef: {
    name: string
}
output: [{
    name: "a"
}, {
    name: "b"
}, {
    name: "c"
}, {
    name: "1"
}, {
    name: "2"
}, {
    name: "3"
}]

What did you see instead?
$ cue eval flatten.cue
0: field `name` not allowed:
    ./flatten.cue:29:23
    ./flatten.cue:6:2
    ./flatten.cue:17:9
    ./flatten.cue:18:3

This issue has been migrated to https://github.com/cue-lang/cue/issues/563.
For more details about CUE's migration to a new home, please see https://github.com/cue-lang/cue/issues/1078.


Identical attributions for all test images

I tried the CIFAR10 and MNIST example codes, and obtained the same attributions for all test images.  I used the provided CIFAR10 and MNIST example codes without any modifications.
Has anyone else had the same problem?
Thanks

Hi @avakanski, thank you for your comment! To keep the time spent in computations low, the CIFAR10 example notebook currently uses only 500 images from the CIFAR10 dataset. I suspect neither the explained nor the explaining model are therefore fully converged - please try using a larger number of samples. (The notebooks are primarily meant to show how to use the CXPlain API.)

Hi Patrick, thank you very much for your quick reply. I run again the example code for MNIST images by using 50,000 images, but the attribution maps again are all identical. The accuracy of the prediction model was 95.7%, which is decent considering that the hyperparameters were not tuned.
I suspect that there is a bug in the codes that makes all attributions identical. I looked at the codes in more detail, and I wanted to ask you about the meaning of the following 2 parameters in build_explanation_model: num_indices and steps. I would appreciate if you could clarify the meaning of these two parameters. Thank you.

I had a quick look at the training of the explanation models in the CIFAR10 and MNIST notebooks (using verbose=2), and found that the CXPlain models converged at a very high loss due to a poor choice of hyperparameters.
I updated the notebooks with hyperparameter settings that converge better - please have a look @avakanski, and do let me know if you are still experiencing any issues.

Thank you Patrick, you were right, the models were not converging. Thank you for your help.


Add Mac Catalyst support

Motivation
Support the transport in Mac Catalyst apps.
Modifications
Add the platform requirement to Package.swift.
Result
Builds correctly for Mac Catalyst now.
Test Plan
Unit tests passed.

Typically macCatalyst availability is inferred from iOS availability. Was that not the case here?

Typically macCatalyst availability is inferred from iOS availability. Was that not the case here?

Good question, not sure, I just wanted to be explicit, and other Apple Swift packages also have it set explicitly. It also allows potential future divergence from iOS availability.


Update version to 0.7.0 and class-transformer dep to 0.2.0

Closes #15
Bumped version to 0.7.0, since theoretically this is a breaking change in class-transformer.
Tests still work, I believe they don't use those breaking changes.

@quezak Released 🎉

That was quick, thanks!


SharedPreferences values lost when after notification receive

I'm store the data of notification in sharedPreferences and print the data from sharedPrefernces in the same function  this is works well,
But if call the preferences from another function its return null
This is the code of store in sharedPreferences :
`Future<dynamic> setSharedPreferences(Map<String, dynamic> message) async {
  SharedPreferences.setMockInitialValues({});
  SharedPreferences prefses = await SharedPreferences.getInstance();
  FcmNoification fcm = FcmNoification.fromJson(message['data']);
  String stateOrder = findStatTrue(fcm);
  var fcmNot = {'ord_state': '$stateOrder', 'order': fcm.toJson()};
  await prefses.setString('order_state', '${jsonEncode(fcmNot)}');
  prefses.commit();
  print('NOTIFICATION  ${prefses.getString('order_state')}');
}
`
Here the data is printed correctly , But when I call into button printing it prints null such as :
`
 RaisedButton(
          onPressed: () {
  print('NOTIFICATION  ${prefses.getString('order_state')}');
},
          child: const Text(
            'Print preferences',
            style: TextStyle(fontSize: 20)
          ),
        ),
`

@awshakam1998
Please provide flutter doctor -v and a complete minimal reproducible code sample that we can copy paste and run in IDE that helps to replicate the issue you are facing.
Thanks.

Zm

Zm

Without additional information, we are unfortunately not sure how to resolve this issue.
We are therefore reluctantly going to close this bug for now.
Please don't hesitate to comment on the bug if you have any more information for us; we will reopen it right away!
Thanks for your contribution.
Could everyone who still has this problem please file a new issue with the exact description of what happens, logs, and the output of flutter doctor -v.
All system setups can be slightly different, so it's always better to open new issues and reference related issues.


CPU and memory use optimizations

Increase size of bitfield index, use all available memory in phases 3 and 4.

looks good to me. Did you run this through a heap profiler to ensure it doesn't exceed the limit?

I did not use a heap profiler, but I traced all calls to constructors and destructors of SortManager to ensure we stay within the limit.


Fix memory management in polyfill with multiple holes

Multiple holes would not be correctly used because the C code would read past the end of the buffer. Setting up some tests with the C code would be helpful so that Valgrind could also be used.
Edit: I forgot to mention that the test uses loop 1 (not loop 0) as the outer region. This didn't match what I expected, and might be a bug in the core C library. I used the following to test the C library and saw similar results to Java:

TEST(2RingMultiHoles) {
    LinkedGeoPolygon* polygon = calloc(1, sizeof(LinkedGeoPolygon));
    // 2-ring, in order returned by k-ring algo
    char* hexes[] = {"8930062838bffff", "89300628383ffff", "893006283d7ffff",
                     "89300628313ffff", "89300628317ffff", "893006283bbffff",
                     "89300628387ffff", "89300628397ffff", "89300628393ffff",
                     "89300628067ffff", "8930062806fffff", "893006283d3ffff",
                     "893006283c3ffff", "893006283cfffff", "8930062831bffff",
                     "89300628303ffff"};
    int numHexes = sizeof(hexes) / sizeof(hexes[0]);
    H3Index* set = makeSet(hexes, numHexes);

    H3_EXPORT(h3SetToLinkedGeo)(set, numHexes, polygon);

    t_assert(countLinkedLoops(polygon) == 4, "3 loops added to polygon");
    t_assert(countLinkedCoords(polygon->first->next) == (6 * (2 * 2 + 1)),
             "Expected number of coords added to loop");

    H3_EXPORT(destroyLinkedPolygon)(polygon);
    free(set);
    free(polygon);
}

Pull Request Test Coverage Report for Build 36

0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 98.142%

Totals

Change from base Build 33:
0.0%

Covered Lines:
317

Relevant Lines:
323

💛  - Coveralls


Fix typo in URL

Sure, I can help you with that. Can you please provide me with the URL and the typo that needs to be fixed?


Can I inference with camera

How can I run the model with image

You can treat images as length=1 videos. Please refer to docs/inference.md for guidance.

Hi, in the
[https://github.com/Walter0807/MotionBERT/blob/main/docs/inference.md] i dont se a guidance to how to make the input to be a image file, when i try to specify --vid_path to point to .jpg file and setting the --clip_len to 1, it still does not work. Could you help or guide me somehow?
Thanks.


[WIP] Work towards next minor release

Warning: requires Pkg.add(url="https://github.com/ACEsuit/ACEfit.jl", rev="0.1-dev") or equivalent.
Branch with three short-term goals:

Implement remaing changes associated with the tasks in #97, some of which are breaking.
Incorporate examples for the paper into the CI. Not permanent, but useful for now. They are currently in paper-examples.
Keep pace with ACEfit changes in https://github.com/ACEsuit/ACEfit.jl/tree/0.1-dev.

Preview the updated docs: https://acesuit.github.io/ACE1pack.jl/previews/PR120/.

CI is finally working again (except for MPI, which I have disabled).


Add pattern_shape to pie, funnel_area, hierarchial

This was very recently added to plotly:
https://plotly.com/python/pattern-hatching-texture/
"support for pie, sunburst, icicle, funnelarea, and treemap charts in 5.15"
all that should need to be done is add the pattern_shape arguments to the function, but I tried that while working on plot by and could not get it working at the time
since this also leads to 2 different style arguments on these plots, it is worth supporting by on them as well

If it's new new, it might need a matching client library update to work.


Export mutation graph in json/dot syntax through restapi

Could be done by reworking DumpGraph and adding a hook in restapi.
This would allow easy inspection and debugging of the mutation graph.

This was added in #69


Add Studio

A workbench for developing Composer packages.

How is this better/different from existing packages we list?

In list not exist packages with same functions
it's replace some repositories in dev enviroment - very usefull if write own composer package.

This seems like the tooly package right under it, and some of it's functionality seems to be in composer already.

Ok, i just suggest

Right. I'm asking you to justify your suggestion is all. Can you list a few ways this package is awesome?


Please confirm these before moving forward

[X] I have searched for my issue and not found a work-in-progress/duplicate/resolved issue.
[X] I have not been informed if the issue is resolved in a preview version of the winget client.

Category of the issue
Other
Brief description of your issue
The version detected by Winget is  6.0.5
Anyway, the installed and lastest is  6.0.7

Steps to reproduce
..
Actual behavior
If i upgrade the app get reinstalled for no reason
Expected behavior
..
Environment
Windows: Windows.Desktop v10.0.22621.317
System Architecture: X64
Package: Microsoft.DesktopAppInstaller v1.18.2091.0

Screenshots and Logs
WinGet-2022-07-27-16-58-26.048.log
WinGet-2022-08-01-16-18-59.865.log

Happens again. All my DesktopRuntime versions are recognized as Microsoft.DotNet.DesktopRuntime.6.

Happens again. All my DesktopRuntime versions are recognized as Microsoft.DotNet.DesktopRuntime.6.

Same, bc it got updated

winget list Desktop
-----------------------------------------------------------------------------------------------------------------------------------
Microsoft Windows Desktop Runtime - 5.0.17 (x86)          Microsoft.DotNet.DesktopRuntime.6           < 6.0.5                 6.0.19   winget
Microsoft Windows Desktop Runtime - 8.0.0 Preview 5 (x86) Microsoft.DotNet.DesktopRuntime.Preview     8.0.0-preview.5.23302.2          winget
Microsoft Windows Desktop Runtime - 3.1.32 (x64)          Microsoft.DotNet.DesktopRuntime.6           < 6.0.5                 6.0.19   winget
Microsoft Windows Desktop Runtime - 6.0.19 (x86)          Microsoft.DotNet.DesktopRuntime.6           6.0.19                           winget
Microsoft Windows Desktop Runtime - 5.0.17 (x64)          Microsoft.DotNet.DesktopRuntime.6           < 6.0.5                 6.0.19   winget
Microsoft Windows Desktop Runtime - 8.0.0 Preview 5 (x64) Microsoft.DotNet.DesktopRuntime.Preview     8.0.0-preview.5.23302.2          winget
Microsoft Windows Desktop Runtime - 3.1.32 (x86)          Microsoft.DotNet.DesktopRuntime.6           < 6.0.5                 6.0.19   winget
Microsoft Windows Desktop Runtime - 7.0.8 (x86)           Microsoft.DotNet.DesktopRuntime.6           > 6.0.19                         winget
Microsoft Windows Desktop Runtime - 6.0.19 (x64)          Microsoft.DotNet.DesktopRuntime.6           6.0.19                           winget
Microsoft Windows Desktop Runtime - 7.0.8 (x64)           Microsoft.DotNet.DesktopRuntime.6           > 6.0.19                         winget

Same boat.

Happens again. All my DesktopRuntime versions are recognized as Microsoft.DotNet.DesktopRuntime.6.

I also see always an upgrade, but 6.0.20 is now latest 6 version:
C:\Windows\system32>winget upgrade
Name                                             ID                                Version Verfügbar Quelle
-----------------------------------------------------------------------------------------------------------
Microsoft Windows Desktop Runtime - 6.0.20 (x64) Microsoft.DotNet.DesktopRuntime.7 < 7.0.0 7.0.9     winget

List shows correct 6 and 7 identifier:
C:\Windows\system32>winget list dotnet
Name                                             ID                                Version Quelle
--------------------------------------------------------------------------------------------------
Microsoft Windows Desktop Runtime - 7.0.9 (x64)  Microsoft.DotNet.DesktopRuntime.7 7.0.9   winget
Microsoft Windows Desktop Runtime - 6.0.20 (x64) Microsoft.DotNet.DesktopRuntime.6 6.0.20  winget

But on a different Window 10 system it works fine

C:\Users\FPSUs> winget list "Desktop Runtime"
Name                                             Id                                Version  Available Source
------------------------------------------------------------------------------------------------------------
Microsoft Windows Desktop Runtime - 6.0.20 (x64) Microsoft.DotNet.DesktopRuntime.6 6.0.20             winget
Microsoft Windows Desktop Runtime - 5.0.14 (x64) Microsoft.DotNet.DesktopRuntime.6 < 6.0.5  6.0.20    winget
Microsoft Windows Desktop Runtime - 3.1.23 (x64) Microsoft.DotNet.DesktopRuntime.6 < 6.0.5  6.0.20    winget
Microsoft Windows Desktop Runtime - 7.0.9 (x64)  Microsoft.DotNet.DesktopRuntime.6 > 6.0.20 7.0.9     winget

C:\Users\FPSUs> winget list dotnet
Name                                             Id                                Version Source
--------------------------------------------------------------------------------------------------
Microsoft Windows Desktop Runtime - 6.0.20 (x64) Microsoft.DotNet.DesktopRuntime.6 6.0.20  winget
Microsoft Windows Desktop Runtime - 7.0.9 (x64)  Microsoft.DotNet.DesktopRuntime.7 7.0.9   winget

Not sure why it defaults to 6 with pretty much the same command, except filtering on something different. The winget list "Desktop Runtime" is the same as whatever is shown in winget upgrade.

After installing the .net8 Desktop Runtime, the issue is solved:
C:\Windows\system32>winget list runtime
Name                                             ID                                Version Quelle
--------------------------------------------------------------------------------------------------
Microsoft Windows Desktop Runtime - 8.0.0 (x64)  Microsoft.DotNet.DesktopRuntime.8 8.0.0   winget
Microsoft .NET Runtime - 6.0.25 (x64)            Microsoft.DotNet.Runtime.6        6.0.25  winget
Microsoft Windows Desktop Runtime - 7.0.14 (x64) Microsoft.DotNet.DesktopRuntime.7 7.0.14  winget
Microsoft Windows Desktop Runtime - 6.0.25 (x64) Microsoft.DotNet.DesktopRuntime.6 6.0.25  winget

@MagicAndre1981 Not really. It might not show available versions in this list, but running winget upgrade still shows them with updates available. Weird.

It might not show available versions in this list, but running winget upgrade still shows them with updates available. Weird.

no, it shows nothing to upgrade as .net6 is now Microsoft.DotNet.DesktopRuntime.6,  .net7 is Microsoft.DotNet.DesktopRuntime.7 and  .net8 is Microsoft.DotNet.DesktopRuntime.8 so every version is now seperate.

For me it looks like this:
C:\>winget upgrade
Name                                             Id                                Version            Available          Source
-------------------------------------------------------------------------------------------------------------------------------
Microsoft Windows Desktop Runtime - 3.1.32 (x64) Microsoft.DotNet.DesktopRuntime.6 < 6.0.5            6.0.25             winget
Microsoft Windows Desktop Runtime - 8.0.0 (x64)  Microsoft.DotNet.DesktopRuntime.6 > 6.0.25           8.0.0              winget
Microsoft Windows Desktop Runtime - 5.0.17 (x64) Microsoft.DotNet.DesktopRuntime.6 < 6.0.5            6.0.25             winget
Microsoft Windows Desktop Runtime - 7.0.14 (x64) Microsoft.DotNet.DesktopRuntime.6 > 6.0.25           7.0.14             winget
4 upgrades available.

1 package(s) have version numbers that cannot be determined. Use --include-unknown to see all results.

I'm using 1.6.3133 on Windows 10 22H2

How did you install .net8 runtime? Via winget?

yes, I installed it after updating 6 and 7. And after this I ran winget upgrade to see if there are other updates and here I was supreised that it worked now.

I installed it after manually downloading the installer. Now, after installing again via winget I still get this:
Microsoft Windows Desktop Runtime - 3.1… Microsoft.DotNet.DesktopRuntime.8 < 8.0.0            8.0.0              winget
Microsoft Windows Desktop Runtime - 5.0… Microsoft.DotNet.DesktopRuntime.8 < 8.0.0            8.0.0              winget
Microsoft Windows Desktop Runtime - 7.0… Microsoft.DotNet.DesktopRuntime.8 < 8.0.0            8.0.0              winget
Microsoft Windows Desktop Runtime - 6.0… Microsoft.DotNet.DesktopRuntime.8 < 8.0.0            8.0.0              winget

So, there's a difference how you install it, clearly. This has also be mentioned in this thread. It will probably come back for you when updating via Windows Update.
Alas, the issue isn't resolved.

@MagicAndre1981 Interestingly, my workplace Windows 10 computer looks as clean as yours.

@MagicAndre1981 Interestingly, my workplace Windows 10 computer looks as clean as yours.

it worked on all PCs/VMs except 1 laptop. And here it suddenly worked after installing .net 8 . This whole matching is confusing

I just had this weird behaviour, when trying to upgrade from 6.0.22 to 6.0.25.
winget upgrade
Name                                             Id                                Version        Available      Source
-----------------------------------------------------------------------------------------------------------------------
Microsoft Windows Desktop Runtime - 6.0.22 (x64) Microsoft.DotNet.DesktopRuntime.6 6.0.22         6.0.25         winget
Windows PC Health Check                          Microsoft.WindowsPCHealthCheck    3.6.2204.08001 3.7.2204.15001 winget
Microsoft .NET Core Runtime - 2.1.11 (x64)       Microsoft.DotNet.Runtime.3_1      < 3.1.25       3.1.32         winget

winget upgrade Microsoft.DotNet.DesktopRuntime.6
Found Microsoft .NET Windows Desktop Runtime 6.0 [Microsoft.DotNet.DesktopRuntime.6] Version 6.0.25
This application is licensed to you by its owner.
Microsoft is not responsible for, nor does it grant any licenses to, third-party packages.
Downloading https://dotnetcli.azureedge.net/dotnet/WindowsDesktop/6.0.25/windowsdesktop-runtime-6.0.25-win-x64.exe
  ██████████████████████████████  54.7 MB / 54.7 MB
Successfully verified installer hash
Starting package install...
Successfully installed

winget upgrade
Name                                             Id                                Version        Available      Source
-----------------------------------------------------------------------------------------------------------------------
Microsoft Windows Desktop Runtime - 5.0.17 (x64) Microsoft.DotNet.DesktopRuntime.6 < 6.0.5        6.0.25         winget
Windows PC Health Check                          Microsoft.WindowsPCHealthCheck    3.6.2204.08001 3.7.2204.15001 winget
Microsoft .NET Core Runtime - 2.1.11 (x64)       Microsoft.DotNet.Runtime.3_1      < 3.1.25       3.1.32         winget

I seems to download the correct URL, at the Apps & features also shows the hopefully correct version:

Not sure this fit here, if not please feel free to move this to a new issue if needed.

i have this

and since this post got very long i would like to know the final solution.

i have this  and since this post got very long i would like to know the final solution.

alright the winget uninstall Microsoft.DotNet.DesktopRuntime.6 didn't work the first time so i closed cmd and started again, had to click again on some yes and it's gone now. i know what that means, but seriously, who still needs .NET desktop runtime anyway?

but seriously, who still needs .NET desktop runtime anyway?

this is required to run .net 6 WinForms/WPF apps. If you only run cli tools you can use the normal .net runtime Microsoft.DotNet.Runtime.6

but seriously, who still needs .NET desktop runtime anyway?

this is required to run .net 6 WinForms/WPF apps.

Running the following command, should solve the problem:
winget install --moniker dotnet-desktop-6
The following command, should also work:
`winget install --id Microsoft.DotNet.DesktopRuntime.6'

Nope. Unfortunately not.

Nope. Unfortunately not.

If you´ve the problem with "Microsoft.DotNet.DesktopRuntime.8", then you should use "--id Microsoft.DotNet.DesktopRuntime.8" or "-moniker dotnet-desktop-8", instead of 6.

Well, apparently I had to uninstall first. And after reinstalling dotnet-desktop-6 it solved it for all other conflicts as well. At least for now. I don't trust it completely.

can someone paste the solution again plz?

Uninstall dotnet-desktop-6, reinstall dotnet-desktop-6.

Still the same problem.
I wonder if it is related to: #4415 ?

i'll skip it on unigetUI


isy class doesn't work with pyisy version 3.0

The latest pyisy release, 3.0 is very different in how you use it to connect to the ISY and the interface ISY class no longer works with this version.

Can you just change the requirements to use the latest 2.x version for now?

Fixed in version 3.0.17.  Changed the requirement to use version 2.1.1 only
3.0+ versions will require major changes in the interface ISY class and possibly changes to node servers that use this as well.


Issue

I don't want to use it as a self bot but as a bot. What am gonna do to code?

Just enter your bot token into the same token spot
It will auto detect which one you are using


HAWQ-1372 - doc config change without cluster restart for ambari-managed clusters

cluster restart for config change in an ambari-managed deployment may not be tolerated in some cases.  document the procedure to update hawq config and reload for ambari-managed clusters.
also including a small rework to master mirroring standby resynchronization section with this PR.

PR merged, closing.  (i ended up directly pushing the "update step identifiers" commit to the asf repo.)


Fix the issues in computing F1 score in the evaluation script

This PR fixed the following issues:

Enable the cluster functions to support the csv files with/without header.
Fixed the issues when union two sets.

It will print out the TP, FP, FN, precision, recall for logging.

@dusenberrymw Could you have a look at this PR? With it, the evaluation script can run as expected.


Random freeze in Ubuntu 19.04

Issue Type: Bug
Latest VSCode, disabled a couple of extensions, these are the bare minimum I am using. Updated to the latest recommended video driver.
Using c_state=1, disabled gpu... I don't know what else I could try to workaround these freezes.
VS Code version: Code 1.40.1 (8795a9889db74563ddd43eb0a897a2384129a619, 2019-11-13T16:49:30.162Z)
OS version: Linux x64 5.0.0-36-generic snap

System Info

Item
Value

CPUs
Intel(R) Xeon(R) Silver 4108 CPU @ 1.80GHz (16 x 800)

GPU Status
2d_canvas: unavailable_softwareflash_3d: disabled_softwareflash_stage3d: disabled_softwareflash_stage3d_baseline: disabled_softwaregpu_compositing: disabled_softwaremetal: disabled_offmultiple_raster_threads: enabled_onoop_rasterization: disabled_offprotected_video_decode: disabled_offrasterization: disabled_softwareskia_renderer: disabled_offsurface_control: disabled_offsurface_synchronization: enabled_onvideo_decode: disabled_softwareviz_display_compositor: enabled_onviz_hit_test_surface_layer: disabled_offwebgl: unavailable_softwarewebgl2: unavailable_software

Load (avg)
2, 1, 1

Memory (System)
15.37GB (9.82GB free)

Process Argv
--force-user-env --no-sandbox --unity-launch --no-sandbox

Screen Reader
no

VM
0%

Extensions (4)

Extension
Author (truncated)
Version

vscode-eslint
dba
1.9.1

tslint
eg2
1.0.44

vscode-scss-formatter
sib
1.4.2

code-spell-checker
str
1.7.20

Can you launch with code --verbose from the terminal and attach the log when you see the freeze ?

Currently we have reports of crash from snap install https://github.com/microsoft/vscode/issues/84233 , might be related. Do you see the same issue when you use the deb package https://code.visualstudio.com/ ?

I have the same issues with Ubuntu 18.04.3 LTS and VS Code version: 1.40.2
I uninstalled the snap version and installed from .deb but it still freezes after random time.

@MauriceBuiten can you launch with code --verbose and attach the log when it freezes.

Verbose mode  is a informative  software and operating system for start up
and operations. ill
start a workshop now
On Sunday, December 1, 2019, Robo<EMAIL_ADDRESS>wrote:

@MauriceBuiten https://github.com/MauriceBuiten can you launch with code
--verbose and attach the log when it freezes.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/microsoft/vscode/issues/85231?email_source=notifications&email_token=AN5O426QKTPGRHRMGTF75MLQWSDQNA5CNFSM4JPXXGXKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFSEWSA#issuecomment-560221000,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AN5O426KNLT3NPAKFGRERHTQWSDQNANCNFSM4JPXXGXA
.

--
EMMANUELL

Well, I have to 'hard-reset' my laptop after it completely freezes. Its just wont react to anything anymore.  Is the log still retrieveable after restart?

Ok, after trying to turn off extensions, I found out that when I turn of the Microsoft TSLint extension, I no longer have crashes so far. So for me that was the culprit.
So for some reason after VS code updated to 1.40 it has issues with the Microsoft TSLint extension.

@MauriceBuiten do you see issue with the extension in the insiders build https://code.visualstudio.com/insiders/ ?

@deepak1556 I used the insiders version for 2 days now with Microsoft TSLint running, and I have not experienced any freezes so far.
So its looking good!

Thanks for testing @MauriceBuiten , I believe the issue you were facing is https://github.com/microsoft/vscode/issues/85919
@totszwai @vadjs can you confirm how does it look on your machine with latest insiders ?

Closing issue for milestone https://github.com/microsoft/vscode/issues/91278, fix should be available in stable soon.


Pairing with Windows 11

Has anyone managed to get the pairing to work with Windows 11?
When I try to pair it through Windows settings it never shows up.
Worked just fine on a Windows 10 machine yesterday albeit with a different controller.
It is shown though in toolBLEx:

Pairing through the app also fails:
Pairing failed, status=Failed
Tried to use pairing with encryption enabled did not work either.
It's a brand new controller out-of-the-box. I could pair it with a Samsung Galaxy S6 Edge.
I'll try with the controller that works on Windows 10 in the coming days.

I tried using a different Bluetooth adapter and I had the same issue. Then I rebooted Windows. Still could not find the device when trying to pair it through Windows settings. Then I tried through as Microsoft BluetoothLE sample as suggested there and sure enough it worked.


change status of Rich Schema RFC to ACCEPTED

Changes the status of the RFC 0250: Rich Schemas from PROPOSED to ACCEPTED
Signed-off-by: Brent<EMAIL_ADDRESS>

https://github.com/hyperledger/aries-rfcs/issues/253#issue-505499046

@troyronda I have made some modifications to the text in 6bbc258 which I think helps to separate the concept of rich schemas from anonymous credentials. Please let me know if these changes address your concerns.

Gave a 7-day notice with messages on Rocketchat and reached out to @troyronda to check if everything was settled. I believe this has met the sufficient criteria to move this RFC to the accepted status.


WB S3 provider: Assign resp.headers before releasing resp

While working SVCS-314 ran into issue during testing where I was receiving "Key not found: 'X-WATERBUTLER-METADATA'" error from s3/provider.py def _metadata_file . This PR fixes the issue.

@felliott this is the side issue from SVCS-314. There is no corresponding JIRA ticket.

Coverage increased (+0.004%) to 75.735% when pulling ced09369654b2a1fac091acc3c7803f0ec63cb10 on TomBaxter:feature/svcs-314-collateral into 2c5d8c3d30772840436ad20fad95d236b7f55f3a on CenterForOpenScience:develop.

Coverage increased (+0.004%) to 75.735% when pulling d83e8623f345fa6dd777a0ed4fbb227d8084e44b on TomBaxter:feature/svcs-314-collateral into 425a3296014126931847d466b77673716516e2a7 on CenterForOpenScience:develop.

Coverage increased (+0.002%) to 89.944% when pulling 1904cc8cc14d2153f8fd6727147d4b0e70598e9e on TomBaxter:feature/svcs-314-collateral into 26bf2093c15af333e634f14372709e7bf014ccb4 on CenterForOpenScience:develop.

This could use a little more info on how to reproduce this, if this fails every time _file_metadata is called how did we not notice immediately?


add configure repo api swagger

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information

[x] The title of the PR is clear and informative.
[x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
[x] Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
[ ] If applicable, the PR references the bug/issue that it fixes.
[x] Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

[x] I have read the contribution guidelines.
[x] My spec meets the review criteria:

[x] The spec conforms to the Swagger 2.0 specification.
[x] The spec follows the guidelines described in the Swagger checklist document.
[x] Validation tools were run on swagger spec(s) and have all been fixed in this PR.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: frankycrm14 sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Automation for azure-libraries-for-java

Automation for azure-sdk-for-python

Automation for azure-sdk-for-go

Automation for azure-sdk-for-node

Signing off as the feedback given over email has been addressed.

Are these changes deployed to the public? Are you ready for me to merge?

I'm testing the api to verify that the approach we took actually works.

Still working on this PR, @frankycrm14? What's its status?

It’s done, but I’m waiting for deployment on the backend, I was told that’s the way to go, not to change swagger until changes are deployed in backend’s prod.
It’s been taking some time to deploy on the backend side for some issues that were found, but hopefully it will be done soon.
From: Martin Strobel<EMAIL_ADDRESS>Sent: Monday, May 7, 2018 4:09 PM
To: Azure/azure-rest-api-specs<EMAIL_ADDRESS>Cc: Franky Gutierrez Gutierrez<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [Azure/azure-rest-api-specs] [Do not merge][Datafactory] Add configure repo api swagger (#2866)
Still working on this PR, @frankycrm14https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Ffrankycrm14&data=02|01|fgutierr%40microsoft.com|56077c32127a490c6b3908d5b46f8724|72f988bf86f141af91ab2d7cd011db47|1|0|636613313460308450&sdata=%2F0a9PbWkd5KFaCjK7RMy%2BQKDQBYcFin%2Fp1Iuc6DsiuI%3D&reserved=0? What's its status?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-rest-api-specs%2Fpull%2F2866%23issuecomment-387233858&data=02|01|fgutierr%40microsoft.com|56077c32127a490c6b3908d5b46f8724|72f988bf86f141af91ab2d7cd011db47|1|0|636613313460318458&sdata=S%2B0leo3EmahgHxsxQjxWHsINzB3Er80MJYsL0Dr2iTI%3D&reserved=0, or mute the threadhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAkhz1HngeVdMJUgMkBiE0hsLfR3pCF5Vks5twNQQgaJpZM4TSjBM&data=02|01|fgutierr%40microsoft.com|56077c32127a490c6b3908d5b46f8724|72f988bf86f141af91ab2d7cd011db47|1|0|636613313460328462&sdata=vKItU5BDZ7y5vImhCVETolWsiCBZohMa%2F30uExMVOb0%3D&reserved=0.