Horizontal FlatList is not ok on Android (iOS is OK)

[x] Review the documentation: https://facebook.github.io/react-native
[x] Search for existing issues: https://github.com/facebook/react-native/issues
[x] Use the latest React Native release: https://github.com/facebook/react-native/releases

Environment
System:
  OS: macOS High Sierra 10.13.6
  CPU: x64 Intel(R) Core(TM) i7-2635QM CPU @ 2.00GHz
  Memory: 818.48 MB / 16.00 GB
  Shell: 3.2.57 - /bin/bash
Binaries:
  Node: 8.9.4 - /usr/local/bin/node
  Yarn: 1.9.4 - /usr/local/bin/yarn
  npm: 6.4.0 - /usr/local/bin/npm
  Watchman: 4.9.0 - /usr/local/bin/watchman
SDKs:
  iOS SDK:
    Platforms: iOS 11.2, macOS 10.13, tvOS 11.2, watchOS 4.2
  Android SDK:
    Build Tools: 23.0.1, 23.0.2, 25.0.0, 25.0.2, 25.0.3, 26.0.1, 26.0.2, 26.0.3, 27.0.0, 27.0.1, 27.0.2, 27.0.3
    API Levels: 16, 18, 19, 22, 23, 24, 25, 26, 27
IDEs:
  Android Studio: 3.1 AI-173.4907809
  Xcode: 9.2/9C40b - /usr/bin/xcodebuild
npmPackages:
  react: ^16.5.1 => 16.5.2
  react-native: ^0.57.1 => 0.57.1
npmGlobalPackages:
  create-react-native-app: 2.0.2
  react-native-cli: 2.0.1
  react-native-macos-cli: 2.0.1

Description
Code is so simple:
  <FlatList
        horizontal={true}
        data={this.state.data}
        style={{backgroundColor:'yellow'}}
        showsHorizontalScrollIndicator={false}
        keyExtractor={this._keyExtractor.bind(this)}
        renderItem={({item}) => <ProductItem navigation={this.props.navigation} dataItem={item} key=
        {item.id}/>}/>

As you can see below when app is RTL and list has just one content (that doesn't fill it's width) on Android it goes to the end (left), iOS behavior is OK as expected. LTR is OK on both.
LTR:

Android:

iOS:

RTL:

Android:

iOS:

Reproducible Demo
none

Can you try updating to 0.57.2?

And if it's still NOT ok, try 0.56.

Its Android issue (not iOS) and still exists on 0.57.2

Seeing this also on 0.55.0 + Android

+1 on 0.57.3

Facing Same issue only in Android.

It has also problem for large lists on RTL! When contents get too large flatlist will automatically scrolls to first items when  horizontal={true}


Provide a forum for the MIMIC community

We would like to provide a forum for the MIMIC community to discuss research questions, data extraction issues, etc. The aims of doing this include:

openly documenting questions, answers etc for future reference;
moving away from providing email support, reducing workload on the lab
encouraging collaboration and idea sharing between researchers
increasing the size of the MIMIC community in a sustainable way.

One option for the forum is:
https://www.discourse.org/about/
For an example, see:
http://discuss.gohugo.io

I don't think we can roll out the discussion forum right away, since we'll have to be thoughtful about the user management system. I'm hesitant to add yet another signup/user system.  It should either integrate with something existing (which Discourse seems to allow with google/github signup) or integrate with the PhysioNet user system (which would be a serious overhaul).
In the meantime, would the github issue tracker be sufficient for now?

We're getting snowed under with emails from people using the new version of MIMIC and we haven't announced it yet, so I'd like to get something in place fairly soon (definitely before we announce MIMIC formally).
The trouble with sticking with GitHub is that we already know that it's not an ideal solution. If we postpone the decision to move, we'll end up creating more work in migrating content and more disruption for the community.
I'm not committed to Discourse, but I do think we should make a decision pretty soon. Can we try to reach a decision by the end of the week? To get things moving, I'll set out my reasons for using Discourse below:

Nothing will be permanent, so our best option is to choose something well-used with a reasonable chance of being around in 2 or 3 years.
Discourse has strong pedigree. It was started by the founder of StackExchange. It also has some major users, like Twitter (https://twittercommunity.com), imgur (https://community.imgur.com), and GitHub (https://discuss.atom.io).
It is open source, free, and should be relatively easy to escape from if and when we move to a different solution in the future.
It integrates with user accounts for Github, Twitter, Google, Facebook, etc so user management is taken care of already.

Please could people add alternative suggestions here? I'm sure there are other good options. We can then (hopefully!) come to a group decision.

Hey @alistairewj @Franck-Dernoncourt @tnaumann @spitz-dan-l @ikarosilva ... does anyone have experience with Discourse or other user forums? We're looking for a place to support discussion within the MIMIC community. Trying to work out what our options are!

Unsure, I know many libraries use Google Groups for the mailing list, but the interface is quite ugly and inconvenient to use.
There is a list Stack Exchange clones here: http://meta.stackexchange.com/a/37953/178179
Among the forums I frequent:

OpenStack uses Askbot: https://ask.openstack.org/en/questions/# but it's also hurting my eyes :)
MetaOptimize uses OSQA: http://metaoptimize.com/qa/  I prefer it is visually over Askbot. Looks like metaoptimize is slow at the moment, https://ask.wireshark.org/ is another OSQA example.

I don't have any experience with Discourse but I had also heard of it, that sounds like a reasonable option.

Good suggestions, thanks Franck. A StackExchange-style system would be a nice way to go, so it's a shame that there don't seem to be any polished, free ones. Of the StackExchange clones on the list, Askbot looks like the best bet (http://askbot.org/en/questions/).

By the way, speaking of community knowledge and documentation, I found this proposal interesting:  Warlords of Documentation: A Proposed Expansion of Stack Overflow.

No idea about which solution is best. Obviously stack overflow is huge but - at least for me - most of the time I'm redirected to a stack overflow question/answer through google. So in that respect the actual site layout of stack overflow questions may or may not be ideal (I've never actually used it).
The biggest issue is the user registration. Honestly the problem is we have this PhysionetWorks registration which is tedious to manage and completely disconnected from the rest of the web. I don't think anyone on the team has the bandwidth to overhaul it though. In my opinion, our best bet is to stick with GitHub account integration with everything else. That way people can keep their work life distinct from their social media if they so please, but it's not necessary since anything that integrates a GitHub account undoubtedly integrates the more common social media accounts. In this light I'd go with discourse - has great pedigree as you say and seems to have the features we want: simple, can be organized into categories, has GitHub integration, open source, and it's something we can easily maintain.

Discourse looks nice, but I'm not sure it would be "easily" maintained. Anything we have to install ourselves runs the risk of becoming outdated and unmaintained (see joomla, redmine). In my brief scan, it seems to require ruby/rails? Are you guys comfortable with that? I suppose we'd be able to host in on AWS, but there is the ongoing maintenance.
Same probably goes with any of the other Open Source QA projects.
I've used Question2Answer ( http://www.question2answer.org/ ) previously, but it quickly fell victim to disuse and spam.
OSQA (does look cleaner) and Askbot seem similar, but I can't find anything post-2013 that actually compares them.
It would be nice if we could start a mimic.stackexchange, but that isn't really their business model ( http://meta.stackexchange.com/questions/76974/how-can-i-propose-a-new-site ).  They do have Open Data ( http://opendata.stackexchange.com/ ), but it might be odd to host mimic questions on a general site.
Ikaro set up a google group previously, but it was a horribly kludgey and not an ideal solution.
I'm just being devil's advocate. If you think the maintenance and support are feasible then any are probably good.
Are we thinking of hosting it on our servers or AWS?

I'd thought about proposing a StackExchange for MIMIC, but I'm pretty sure it would be doomed to failure. You need to have a very active userbase for it to make it out of the beta, as @Franck-Dernoncourt and I recently experienced (http://area51.stackexchange.com/proposals/65426/open-science).

Discourse looks nice, but I'm not sure it would be "easily" maintained. Anything we have to install ourselves runs the risk of becoming outdated and unmaintained (see joomla, redmine).

Everything becomes outdated at some point, so the best option is to choose something that has a strong community and limited tie-in. If you prefer an externally hosted solution, then we could pay a subscription to Discourse (https://payments.discourse.org/buy/) or choose an alternative platform.

What platform are you guys most comfortable with?  Ruby (Discourse), Django (Askbot, OSQA), or PHP (just kidding)?
Hosted solution is good, except that Discourse is $100/month.  I think Askbot was $15/month.  Maybe we should install one that we think is good, and if the users like it, then we can justify a hosted solution moving forward.

I agree, $100 would be a lot to pay for a small forum, so hosting locally would make sense. As we aren't planning on any major customization, we should be able to avoid getting involved in the codebase, so from that perspective any of the languages would be fine.

What about using StackOverflow and just having users tag their questions with something like "MIMIC-ICU"?

On StackOverflow questions to be about some libraries or programming languages, not on data sets.
I was thinking about the open data SE but it doesn't seem to fit there either from my understanding of the on-topic page. I've pinged their meta in case it is though:  Is asking questions about a particular data set on-topic?
Also not on-topic on http://health.stackexchange.com/   :-/

Turned out asking questions about a particular data set is on-topic on http://opendata.stackexchange.com/, so it could be used for MIMIC. (not sure if they won't change their mind if they see hundreds of questions though, but since all contents on there is  cc by-sa 3.0 anyway, and it's really not common they remove questions due to change of scope). If anyone ask a question about MIMIC there just ping me and I can create the tag.

@Franck-Dernoncourt Thanks for doing this!
We have been discussing whether or not http://opendata.stackexchange.com/ is a good place for Q&A and haven't managed to reach consensus.
It would be great to have some opinions shared here (@alistairewj @rjstretch @kepaik @erinhong @li-lcp @kpierceHST @rgmark)
Some positives:

the format is perfect for Q&A.
many people are familiar with StackExchange
moving the conversation to a public forum is a clear message that development of code, support etc, is the role of the community
no technical burden for the lab to support a forum

Some negatives (/questions):

limited control over the platform. What happens if legitimate questions get marked for deletion? What happens if the accepted answers are weak. What happens if StackOverflow decides to delete the conversations in 3 years time?
will questions to get lost? Is it simple to set up a notification system so that we are informed when a MIMIC question is posted? Is there a simple way of searching for all MIMIC posts?
how do we ensure that questions are linked to a specific MIMIC version? e.g. how do we deal with the fact that a new version of MIMIC might have a different itemid dictionary, which could result in older queries failing?

Also @tnaumann @spitz-dan-l @mghassem @ikarosilva - please could you add your thoughts on the point above (http://opendata.stackexchange.com/ for MIMIC support)?

Just answering a few questions:

limited control over the platform. What happens if legitimate questions get marked for deletion?

Go to meta and refine the scope, if the scope becomes unsustainable, move somewhere else.

What happens if the accepted answers are weak.

Indeed that happens sometimes, leaving a comment is one way around, not perfect though.

What happens if StackOverflow decides to delete the conversations in 3 years time?

Content is cc by-sa 3.0 so one can legally move the content somewhere else.

will questions to get lost?

What do you mean?

Is it simple to set up a notification system so that we are informed when a MIMIC question is posted?

Yes:

Is there a simple way of searching for all MIMIC posts?

yes through searching all questions with a tag mimic tag.

how do we ensure that questions are linked to a specific MIMIC version?
e.g. how do we deal with the fact that a new version of MIMIC might have a different itemid dictionary, which could result in older queries failing?

one tag per version

Hey Tom, I like the idea because (like Alistair said) most of the time I'm redirected to a stack overflow question/answer through google anyway.
Franck addressed all the potential negatives, and in general I think the platform makes sense with the push to have a more open/public "ownership" of the data.

Thanks guys, I'm sold! @alistairewj  sounds happy with StackExchange too, so we'll make a start with setting this up over the next week or so.
Alongside StackExchange for Q&A we need somewhere for people to post bug reports on the data. We plan to create a repository containing the code used to create MIMIC, where people can raise issues and bug reports.
So, the steps are:

Archive issues at https://github.com/mimic2/v3.0 then delete the repo.
Create a new public repository containing cleaned "Building-MIMIC" code
Post some seed questions on http://opendata.stackexchange.com/, with the "MIMIC-III" tag
Update the documentation at: http://mimic.physionet.org/community/contributing/ with instructions on how to get support via StackExchange.

I think there is a good potential that putting it on SE will have the added benefit of publicity for MIMIC. Also all for offloading management and administration.  I was going to suggest running a hosted open source version, but even that would take a lot of time that would be better spent elsewhere.
My concern would be primarily around usability. Finding information should be easy enough, but posting seems like several steps and liable to human error. It would be nice if we could embed a form on our site to automatically create questions on SE automatically tagged.
I wanted to look into it, but it seems like SE is blocking our IPs at the moment...

@kepaik  I've had some "disagreement" with some SE mods this weekend but I don't think they banned the 18.* :-) SE seems to be working OK but slow on my side of the campus.

I'm able to connect now, by switching off the MIT wifi to the LCP intranet.
A direct link such as:
http://opendata.stackexchange.com/?tags=mimic  will be nice a clean for listing previous issues, but not sure if a similar method exists for generating questions.
Also, as a "Beta" site, are there concerns it will eventually be deleted?

as a "Beta" site, are there concerns it will eventually be deleted?

Yes in theory, in practice once a site has survived its first few weeks, it is rare it gets closed afterward, I would guess < 5%, though I don't have any number on it. (opendata is over two years old but has not much traffic -> http://stackexchange.com/sites#questions)

It wouldn't be ideal if the site was closed, but I think this concern is covered by Franck's point below:

What happens if StackOverflow decides to delete the conversations in 3 years time?

Content is cc by-sa 3.0 so one can legally move the content somewhere else.

not sure if a similar method exists for generating questions.

Stack Exchange has an API (https://api.stackexchange.com/) with write access, but it would probably be a pain to wrap it in a form for questions and do the same for comments, and answers, etc. (+ if any spammer posts junk that would probably cause some trouble)

I've posted the first question on MIMIC there: Gold annotations for diabetic patients in MIMIC-III

Thanks @Franck-Dernoncourt -
We'll try to post a response shortly (it'll need some thought!).

We are testing Discourse on our internal servers and have a couple of minor issues to sort out. There should be a version ready for public use within a week or two.

A test instance of the forum is running at: https://mimic.physionet.org/forum/

The forum is currently unreachable because the server hosting it is down.

Hi everyone, any updates on the forum? I really feel the need to discuss things with you on a forum or another means. Any chance we can start one?
I know I and other people have many questions and also suggestions and solutions that will help others.

@manashty Hi Alireza, thanks for letting us know that there is still demand for a forum. We have no immediate plans to introduce one, due to limited resources, so for now we suggest raising issues on the MIMIC Code Repository when you have points for discussion. We are in the process of updating PhysioNet, and we might consider providing a forum as part of this work.

A combination of issues and Gitter (https://gitter.im/MIT-LCP/mimic-code) seems to be a good solution for now. We can push more people towards Gitter by linking to it from https://mimic.physionet.org/community/contributing/


Organize Planting List

We are following the Miyawaki Forest method.
We will focus on Autumn / Late Summer plants (since our planting schedule begins in September/October).
This includes canopy trees, understory trees, cover crops, and vegetables.

Closed by #17


Add initial port of zerodark color theme

Hi @djblue,
Here is my initial take on porting the  zerodark to use with Portal.
Example Screenshots:

s:
Here is the list of colors extracted from the source code of the original project.

Please let me know if you want me to adjust anything or if you have other suggestions to improve the color.

Does something like:

work for you?

Definitely. 👍

Okay cool. When you update the colors to:
{::text        "#abb2bf"
 ::background  "#282c34"
 ::background2 "#22252c"
 ::boolean     "#da8548"
 ::string      "#98be65"
 ::keyword     "#61afef"
 ::namespace   "#61afef"
 ::tag         "#ccd4e3"
 ::symbol      "#abb2bf"
 ::number      "#da8548"
 ::uri         "#da8548"
 ::border      "#4c566a"
 ::package     "#88c0d0"
 ::exception   "#ff6c6b"
 ::diff-add    "#a3be8c"
 ::diff-remove "#ff6c6b"}

I'll merge 👌


Simpler solution

“ The problem with objectWillChange outside of SwiftUI is that there's no built-in way of achieving (2) — being notified that an object will change is not the same as knowing that it did change and it’s time to update the view.”
You can simply use the debounce operator on the willChange publisher and now it’s becomes didChange. And multiple changes to the object result in only one update. The same way multiple changes to objects in SwiftUI result in only one call to body.
And by the way, View model pattern is not compatible with SwiftUI. SwiftUI View structs are already the model for the views eventually rendered on screen and you should use @State and @Binding to make the structs behave like objects.
ObservableObject in SwiftUI is for loaders or fetchers you need to tie to view life cycle. It is also commonly used as the model structs container.

Hello, is the corresponding demonstration code? I am very interested in this idea, if you can, please provide a reliable code, thank you.
@malhal

Just watch this https://developer.apple.com/videos/play/wwdc2020/10040/

You can simply use the debounce operator on the willChange publisher and now it’s becomes didChange.

If you're interested, I'd be happy to review a PR with a test that demonstrates the approaches are equivalent.

The same way multiple changes to objects in SwiftUI result in only one call to body.

Unfortunately, neither approach is actually equivalent to what SwiftUI does internally. SwiftUI controls the render loop, and is able to ensure that the views are re-evaluated before the next "tick" rendering the UI. This results in smoother animations than what we're able to currently achieve with either the dispatch source approach implemented here or a debouncing approach, which always appear to be scheduled during the following tick.

And by the way, View model pattern is not compatible with SwiftUI. SwiftUI View structs are already the model for the UIViews that are eventually shown on screen....Typically this kind of ObservableObject is use for loading or fetching where the data needs to be tied to the view lifecycle.

The term "view model" used by this project is used intentionally to model those long-running operations. Other design patterns have called these objects "controllers" or "presenters", but the concept is the same.


Add last approver to expense

Related: https://github.com/opencollective/opencollective/issues/6675
Adds the last approver of the expense to the Expense graphql object. Used to display approver on the expense list

I think @betree has a point and we can use this refactor to lay the foundation for multiple approvals. I don't think we should rely on activities due to the size of the table and the time it could take for us to resolve this field. I think denormalizing this into a column in the Expense is a good idea, just make it an array and isolate the logic of managing this array in a method.

I don't think we should rely on activities due to the size of the table and the time it could take for us to resolve this field.

I don't agree with the performance argument. Sure, the Activities table is huge, but we have an index on ExpenseId that makes it extremely cheap to query this information:
EXPLAIN ANALYZE
select * from "Activities" where "ExpenseId" = 143189 AND type = 'collective.expense.approved'

Index Scan using activities__expense_id on ""Activities""  (cost=0.09..11.61 rows=1 width=1445) (actual time=0.012..0.013 rows=1 loops=1)"
  Index Cond: (""ExpenseId"" = 143189)"
  Filter: ((type)::text = 'collective.expense.approved'::text)
  Rows Removed by Filter: 1
Planning Time: 0.074 ms
Execution Time: 0.023 ms

:arrow_up: From prod data. Complexity = 10, Execution time = 0.02ms. Performance is not an issue.

I think denormalizing this into a column in the Expense is a good idea, just make it an array and isolate the logic of managing this array in a method.

As far as I know, foreign key arrays are not well supported in Postgres (e.g. there's no onDelete: cascade, it's not a real relationship).

I agree with @Betree now. We just need a custom method on the expense to get the latest approvals more recent than the last state change.

I agree with the desired outcome of multiple approvers, but I think it should be attempted as part of this PR.
Many approvers is more complex when considering unapprovals, and using the activities for this makes it a bit harder.

Alice approved once.
Alice for some reason unapproved. (repeat the two steps N times)
Bob then approved.
Carlos (fiscal host) unapproved
Expense was updated.
Daniel approved.
Expense is paid.

Alice is definitely not approving, but to know it we need to reduce N activities.
Is Bob still approving? He never explicitly unapproved, was he unapproved by Carlos? Or was his approval stale by the expense details changing?
Daniel was the last approver.
This also needs to happen on a loader, as this information is intended for the expense list.
ATM I propose we keep a  lastApprovedBy field that takes the last approver (Daniel) from the expense activity log, it can be deprecated when many approvers is implemented.

Alice is definitely not approving, but to know it we need to reduce N activities.
Is Bob still approving? He never explicitly unapproved, was he unapproved by Carlos? Or was his approval stale by the expense details changing?
Daniel was the last approver.

We can start with the assumption that any unapproval invalidates all previous approvals; it sounds reasonable and simple enough to me. Said with code:
const blockingTypes = ['UNAPPROVED', 'REJECTED']
const typesToCheck = [...blockingTypes, 'APPROVED']
const activities = await findAll({ where: { type: typesToCheck }, order: ['createdAt', 'DESC'] })
const lastApprovedActivities = takeWhile(activities, a => a.type === 'APPROVED');
return lastApprovedActivities.map(a => a.user);

This definition could evolve in the future depending on what we decide with https://github.com/opencollective/opencollective/issues/3081, as we'll have to answer this question to decide when an expense needs to move to the "Approved" list.
It's not a blocker for me to go with lastApprovedBy, but I would find it a bit sad considering that we know the problem is going to hit us in the near future, and on top of having to resolve it we will have to deprecate and migrate an API field.

@Betree I updates the field to approvedBy and added the filter by activities as you described. Is the UNAPPROVED activity sufficient to reset approvers?


add useIsMobile hook and udpate copy

Description
FIxes #83
Move useIsMobile logic inside the reusable hook, we were already using that logic  in NetworksDropDown component
Again we are not using useMediaQuery from hook usehooks-ts since it had some bug in v2

Thanks for this @technophile-04 !
I'd personally would have gone with a simpler route: using tailwind responsive design classes, hiding / displaying depending on the viewport. Something like: (writing it without testing haha)

  Please select read methods from the hamburger menusidebar

If we are not going to use the hook in more places, maybe this is a good solution.
But just think it out loud, we can merge it as it's.

I'd personally would have gone with a simpler route: using tailwind responsive design classes, hiding / displaying depending on the viewport. Something like: (writing it without testing haha)

Ohhh yeah thanks !, this didn't click in my mind at all :(. Lol I had in my mind that we had custom useIsMobile and that could easily solve this issue and without thinking of any alternatives directly jumped on PR my bad
Just updated the solution to use class, because of simplicity and I kind of prefer it more instead of accessing media queries from JS land then directly utilizing CSS media queries  to handle this

Pushed a typo fix, not related with this PR

Ohh lol thanks !!
Merging this 🙌


changing name for the package?

Just came across this and wanted to let you know that there is already an R package on CRAN  called broomExtra-
https://cran.r-project.org/web/packages/broomExtra/index.html

I will definitely change it. Thanks for letting me know. I should’ve searched first.


Removing code that disables amCharts branding

Description
The only proper way to remove amCharts branding is via application of a commercial license acquired from amCharts.
It is alrady applied correctly via initAmcharts() function.
However, some widgets have a hardcoded code that disables amCharts branding even without proper license.
This PR removes those lines to get in-line with amCharts free license.

Close this PR due to no following commits.


Add postMessage to window API

Adds window.postMessage(message) to the window API. In the browser, this uses postMessage(), whereas in OpenFin and Electron, it is just a wrapper around the MessageService call.

Fixed :)


Fix CircleCI API failing to detect PRs

The CircleCI API seems to have changed and the query to fetch PR metadata when "only build pull requests" = false fails.
Old JSON:
{
    "pull_request_urls": [ "..." ]
}

New JSON:
{

    "pull_requests": [
        {
            "head_sha": "...",
            "url": "..."
        }
    ]
}

@orta Finally, I updated the fixtures with a random PR and non-PR responses from the eigen repo (following your example). Hope that's ok.
I also updated the CircleCI documentation.

          2 Errors

:no_entry_sign:
Please include a CHANGELOG entry.
You can find it at CHANGELOG.md.

:no_entry_sign:
Failing due to documentation issues, see below.

Core Docs Errors

  Generated by :no_entry_sign: Danger

Not sure why tests are failing :(

Re: The red, I download it and ran them all locally and they passed, so I'll just call  this a weird one and merge it on red.
Thanks!

Me pressing a button nowadays, will do so


refactor np.where to use overload

xref: #8254

Refactor np.where to use @overload
Broadcast arrays of different shapes. This removes a restriction in the old code where only arrays with the same shape were supported.
Add NumPy tests
Add type check for supported types + tests

Thanks for the review, @apmasell

@guilhermeleobas thanks for the patch. In the interests of making this easier to review, perhaps split the API refactoring and the addition of new functionality into separate patches?

@guilhermeleobas please could you resolve the conflicts against main? Many thanks.

@kc611 @stuartarchibald, would you folks be ok with not supporting None inputs in this patch? Current patch fails with such values as np.asarray(None) is not supported.


Add to Community page in Channels docs?

Hi, this looks great. Fancy making a PR to add it to the docs?

sure :-)

Fixed in https://github.com/django/channels/pull/1663 — Thanks @danidee10!


Add supported keycloak version

IMPORTANT: Do Not Merge - To be merged by Docs Team Only
Version(s): 1.4

Add the relevant labels to the Pull Request.
Issue: https://issues.redhat.com/browse/RHIDP-3060

Just need clarification on what RHDH version this is for, otherwise it looks good

This is for RHDH 1.3. @kim-tsao

/cherry-pick release-1.3


Reverted attributes placeholders in activeTextInputField

Previously used the old version bootstrap (YiiBooster, DrMabuse bootstrap 3).
And all of them are displayed by default placeholders.
After the upgrade project to use yiistrap all forms have empty placeholders.
May be solution is - add the setting to enable or disable this feature, for backward compatibility...

I don't think this is a good idea, the default behavior in Bootstrap itself is not to have placeholders, but labels for inputs.


Merge master into hook framework

It's really cool to see such a fast pace on this implementation ❤👌
We have a feature that we would like to implement as a hook. If the implementation is in a stage ready for testing we could try to implement this feature and give feedback.

It's really cool to see such a fast pace on this implementation heartok_hand
We have a feature that we would like to implement as a hook. If the implementation is in a stage ready for testing we could try to implement this feature and give feedback.

Thank you for your interest in this huge feature. We plan to merge the MVP in mid-May for community feedback.
But for now it is not actually ready for testing, as some of the hook contracts may change.


feature: Option to Convert Quadratic Value Curves to PWL for Plexos Parser

In cases where quadratic value curves have time-varying fuel costs associated with them, PSI wont be able to model Market Bid Cost with time-varying quadratic value curves. Here I implement the feature to convert quadratic value curves to PWL.
Usage: feature_flag quad2pwl = number of tranches to fit
Also changed the exporter to export the value curves using the same logic used to export the PiecewiseStepData

Codecov Report
Attention: Patch coverage is 35.71429% with 27 lines in your changes missing coverage. Please review.

Project coverage is 61.07%. Comparing base (d1a61f0) to head (8200ce5).

Files with missing lines
Patch %
Lines

src/r2x/parser/plexos.py
0.00%
15 Missing :warning:

src/r2x/parser/parser_helpers.py
31.25%
11 Missing :warning:

src/r2x/api.py
75.00%
1 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #45      +/-   ##
==========================================
- Coverage   61.41%   61.07%   -0.35%
==========================================
  Files          29       29
  Lines        2978     3008      +30
==========================================
+ Hits         1829     1837       +8
- Misses       1149     1171      +22

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Reimplement creation of minio client to avoid minio extension limitations

With this issue (https://github.com/quarkiverse/quarkiverse-minio/issues/22) solved, it should be possible to change obtaining mechanism of miio client and therefore remove limitations caused by current implementation.

Please, assign to me.

Please, assign to me.

Issue is fixed by https://github.com/apache/camel-quarkus/pull/2140/


[REEF-774] Remove Serializable interface from Tasklet

This PR makes VortexFuture class serializable and
consequently resolves a high-priority findbug warning on Tasklet class.
JIRA:
REEF-774
Pull Request:
This closes #512

@johnyangk Could you review this? I think you're the best man to review this.

@dongjoon-hyun Thanks for the PR.
However, instead of making VortexFuture Serializable, it'd be better to make Tasklet not Serializable as Tasklet never goes on the wire and shouldn't have been Serializable in the first place. Does this make sense?
Removing Serializable from Tasklet seems to make the error go away. This is a one-line change. Would you like to make the fix? Or if it's okay with you, I can create a separate PR(closing the current one).

Oh, if so, I agree with your opinion. I will change REEF-774 and this PR according to your guide. Thank you, @johnyangk .

@johnyangk . I updated JIRA issue and this PR. I hope this PR is proper and enough for now. Thank you again for your quick help.
This PR removes Serializable interface from Tasklet class
since Tasklet class is not designed for serialization.
This also resolves a high-priority findbug warning
between Tasklet and VortexFuture class.
JIRA:
REEF-774
Pull Request:
This closes #512

@dongjoon-hyun No problem. Thank you for fixing the bug! I'll do the merge.

Thank you! @johnyangk


Fixes #218: Allow rendering description from schema for all fields.

Helps with #218

Would you mind adding a few tests? Thanks!

Done.

Thanks for highlighting the styling issues. Resolved now. npm run lint didn't catch them though. Will be good to add these rules in there, I feel?

npm run lint didn't catch them though. Will be good to add these rules in there, I feel?

If you know about what the rules to add are, please add them :)

If you know about what the rules to add are, please add them :)

Will do. As another pull request.

Side note, please avoid squashing and keep your commits atomic on the PR so I can review them individually. Squashing is enabled for this repo so a single commit will eventually land anyway :)

Noted. It's just that I didn't want the intermediate commits on my fork either. But seeing that you have left comments on them, I guess I shouldn't be squashing them. Got it.

When you have a spare moment later, can restart the Travis build? It failed because of issues with npm.

Jobs restarted.

Strange issue with travis it seems, where fetching this url https://registry.npmjs.org/babel-plugin-transform-object-rest-spread/-/babel-plugin-transform-object-rest-spread-6.8.0.tgz fails with a 502 while
$ curl -I https://registry.npmjs.org/babel-plugin-transform-object-rest-spread/-/babel-plugin-transform-object-rest-spread-6.8.0.tgz
HTTP/1.1 200 OK

Perfect, I'm landing this. Again, thanks for contributing!

Released in v0.36.0.


Add missing data types (date, datetime, timestamp)

Add to the translator typesystem and catalog

fixed by https://github.com/ldbc/gcore-spark/commit/637f6856a90f7f0ffc2fc2273f0fde0051611e1c

Agreement: allow datatypes supported by spark


Jon Rivera_TL_Maggie_DS17_Sprint5

Good work John! You always push yourself and it's going to pay off. Just a couple things that I am thinking you addressed and the notebook was just not re-run. Sometimes you use X_train and sometimes Xtrain, and also your target ends up being nested with the double square brackets, which I believe you ran into that error when trying to access the index locations of the coefficients. We can talk about these things in our 1:1 but as usual, good job!

John! Your notebook is so organized and all your comments are great and will help your future self. I liked how you accessed the month in the created column to split for training and testing data. How come your engineered features didn't make it into the model??  The minimum was 2 features, so maybe trying out different things to see if you can improve your metric scores. Good work!

Nice visualizations! I liked how you tested out the different alphas for the Ridge Regression and also did a Linear Regression to see how the metrics compared.


fix: replace .lg:pb-18 with a valid classname

the classname .lg:pb-18 doesn't exist in tailwind's default spacing scale. hint: why it was being ordered before .relative
this replaces it with .lg:pb-20

can we get the same fix over on the grunge stack and blues stack as well ❤

@mcansh done! https://github.com/remix-run/grunge-stack/pull/77 https://github.com/remix-run/blues-stack/pull/91


Success of DataArray.plot() depends on object's history.

What happened?
I have the following 2D DataArray
ldda

I can select a portion of it like so
da1 = ldda.sel(component=0)
da1

I can get what seems like an equivalent array (equal values, matching dtypes, etc.) in the following way:
da2 = ldda.to_dataset(dim="component")[0]
da2

And yet, while I can successfully plot da1...
da1.plot()

Trying to do the same with da2 results in the following error...
da2.plot()

AttributeError: 'int' object has no attribute 'startswith'

See below for full traceback and minimal working example.
What did you expect to happen?
I expected da1 and da2 to be functionally equivalent.
Minimal Complete Verifiable Example
import xarray as xr
import numpy as np

da = xr.DataArray(
    data=np.asarray([[1, 2], [3, 4], [5, 6]]),
    dims=["x", "y"],
)

da.sel(x=0).plot() # Succeeds
da.to_dataset(dim='x')[0].plot() # Fails

MVCE confirmation

[X] Minimal example — the example is as focused as reasonably possible to demonstrate the underlying issue in xarray.
[X] Complete example — the example is self-contained, including all data and the text of any traceback.
[X] Verifiable example — the example copy & pastes into an IPython prompt or Binder notebook, returning the result.
[X] New issue — a search of GitHub Issues suggests this is not a duplicate.

Relevant log output
---------------------------------------------------------------------------
AttributeError                            Traceback (most recent call last)
/Volumes/scratch/neuropixels/t2_shared_projects/discoflow_v2/discoflow/analysis/ANPIX30/discoflow-day2/get_senzai_ic_loadings.ipynb Cell 18 in <cell line: 1>()
----> 1 da2.plot()

File /Volumes/scratch/neuropixels/t2_shared_envs/discoflow_v2/lib/python3.8/site-packages/xarray/plot/plot.py:866, in _PlotMethods.__call__(self, **kwargs)
    865 def __call__(self, **kwargs):
--> 866     return plot(self._da, **kwargs)

File /Volumes/scratch/neuropixels/t2_shared_envs/discoflow_v2/lib/python3.8/site-packages/xarray/plot/plot.py:332, in plot(darray, row, col, col_wrap, ax, hue, rtol, subplot_kws, **kwargs)
    328     plotfunc = hist
    330 kwargs["ax"] = ax
--> 332 return plotfunc(darray, **kwargs)

File /Volumes/scratch/neuropixels/t2_shared_envs/discoflow_v2/lib/python3.8/site-packages/xarray/plot/plot.py:436, in line(darray, row, col, figsize, aspect, size, ax, hue, x, y, xincrease, yincrease, xscale, yscale, xticks, yticks, xlim, ylim, add_legend, _labels, *args, **kwargs)
    432 xplt_val, yplt_val, x_suffix, y_suffix, kwargs = _resolve_intervals_1dplot(
    433     xplt.to_numpy(), yplt.to_numpy(), kwargs
    434 )
    435 xlabel = label_from_attrs(xplt, extra=x_suffix)
--> 436 ylabel = label_from_attrs(yplt, extra=y_suffix)
    438 _ensure_plottable(xplt_val, yplt_val)
    440 primitive = ax.plot(xplt_val, yplt_val, *args, **kwargs)

File /Volumes/scratch/neuropixels/t2_shared_envs/discoflow_v2/lib/python3.8/site-packages/xarray/plot/utils.py:491, in label_from_attrs(da, extra)
    488 units = _get_units_from_attrs(da)
...
    493         textwrap.wrap(name + extra + units, 60, break_long_words=False)
    494     )
    495 else:

AttributeError: 'int' object has no attribute 'startswith'

Anything else we need to know?
Thank you for one of my favorite packages!
Environment

INSTALLED VERSIONS
commit: None
python: 3.8.13 | packaged by conda-forge | (default, Mar 25 2022, 06:04:18)
[GCC 10.3.0]
python-bits: 64
OS: Linux
OS-release: 5.4.0-122-generic
machine: x86_64
processor: x86_64
byteorder: little
LC_ALL: None
LANG: en_US.UTF-8
LOCALE: ('en_US', 'UTF-8')
libhdf5: 1.12.2
libnetcdf: None
xarray: 2022.3.0
pandas: 1.4.3
numpy: 1.21.0
scipy: 1.8.1
netCDF4: None
pydap: None
h5netcdf: None
h5py: 3.7.0
Nio: None
zarr: None
cftime: None
nc_time_axis: None
PseudoNetCDF: None
rasterio: None
cfgrib: None
iris: None
bottleneck: None
dask: 2022.7.0
distributed: None
matplotlib: 3.5.1
cartopy: None
seaborn: 0.11.2
numbagg: None
fsspec: 2022.5.0
cupy: None
pint: None
sparse: None
setuptools: 63.2.0
pip: 22.2
conda: None
pytest: 7.1.2
IPython: 8.4.0
sphinx: None

The difference is that one has a name of 0:

In [7]: da.sel(x=0)
Out[7]:
<xarray.DataArray (y: 2)>
array([1, 2])
Dimensions without coordinates: y

In [8]: da.to_dataset(dim='x')[0]
Out[8]:
<xarray.DataArray 0 (y: 2)>
array([1, 2])
Dimensions without coordinates: y

In [9]: da.to_dataset(dim='x')[0].name
Out[9]: 0

This shouldn't prevent the plotting from working — that is indeed a bug....


Add the session exception translations

The translations were discussed so now we have the latest version to
show the enduser.
https://www.pivotaltracker.com/story/show/164076545

Hi @thijskh, are this the messages you would expect for the session exceptions?

The changes requested by @thijskh are done.

The changes requested by @arnoutt are done.

@domgon would you be so kind to verify if the Portuguese translation makes sense. Else I could directly update the translation if needed.

@MKodde would you be so kind to do a review?


Document DistributionStrategies including how it can be extended.

This request was a product of the TensorFlow Fall Symposium.  It might be nice to start with a simple block diagram and then go deeper with the objective to show companies, individual, and academics how they can extend DistributionStrategies at various points.
Picking a random person from the tf-dist-strat team to start.

This looks interesting. Looking forward to a SIG in distributed training.

Nagging Assignee @anj-s: It has been 14 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @anj-s: It has been 29 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @anj-s: It has been 44 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @anj-s: It has been 61 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @anj-s: It has been 76 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Stale


Remove extra logging

Goal

Testing

Release Notes

WHAT:
WHY:
WHO:

#852  👈
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @bidetofevil and the rest of your teammates on  Graphite


Userconfig for Autoexit

Added two options to config.ini
startup_timeout ; Seconds until LUI will exit if PoE is not detected. -1 to disable. Default 60, same as upstream.
restart_timeout ; Seconds until LUI will exit if PoE is closed and not restarted. -1 to disable. Default 60, upstream was 0.
User can now keep LUI running indefinitely if they want, and the new default prevents LUI from killing itself every time PoE crashes and is quickly restarted.

I only saw this right before going to bed because my phone apparently didn't feel like giving me notifications. I will have a look at this tomorrow (and how merging works). I was planning on adding a settings window with the relevant ini options as groundwork for adding optional non-archnemesis QoL features in the near future, so I would probably include configurable timeouts there.

As mentioned before, configurable timeouts are now part of a new settings menu and no longer need to be set manually in the config.ini.


HSEARCH-3431 Upgrade to Hibernate ORM 5.3.7.Final

https://hibernate.atlassian.net//browse/HSEARCH-3431

Pull Request Test Coverage Report for Build 1

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 83.895%

Totals

Change from base Build 7:
0.0%

Covered Lines:
23743

Relevant Lines:
28301

💛  - Coveralls


syncMoreHistoricMessages failing

User B created a conversation with User A.
When User A does:
Conversation conversation;
try {
    conversation = App.layerClient.newConversationWithUserIds(participantId);
} catch (LayerConversationException e) {
    conversation = e.getConversation();
}
conversation.syncMoreHistoricMessages(HISTORIC_MESSAGES_PER_FETCH);

everything works fine.
When User B tries to use the above method for getting the conversation with User A, I get the following:

Ignoring call to syncMoreHistoricMessages. Cannot request syncMoreHistoricMessages on a new Conversation: ConversationImpl [  id: layer:///conversations/a338b9df-808c-497f-b1fb-1aeb0352c7a2, mStreamDatabaseId: null, mStreamId: null, mCreatedAt: null, mDatabaseId: null, mDistinct: true, mTotalMessageCount: null, mTotalUnreadMessageCount: null, mHistoricSyncStatus: INVALID, mReadReceiptsEnabled: true, mParticipants: [0: 1 : participant [  mMemberId: 1, mDatabaseId: null, mConversationDatabaseId: null, mStreamMemberDatabaseId: null], 1: 2 : participant [  mMemberId: 2, mDatabaseId: null, mConversationDatabaseId: null, mStreamMemberDatabaseId: null]], mMetadata: MetadataImpl{mMap={}}]

yet it still successfully loads the last message between the two users.

Also note if I instantiate my LayerClient with .historicSyncPolicy(LayerClient.Options.HistoricSyncPolicy.ALL_MESSAGES) it DOES successfully sync all messages.

For technical assistance please reach out to us via support.layer.com.
Thanks,
Chris

I think the heart of this issue was that when I was calling newConversationWithUserIds, Layer hadn't fully sync'd all conversations yet. It later corrected itself, but after I had already called syncMoreHistoricMessages.
I had to hack a way around this issue by listening for Layer change events.
I don't know of another way to wait on all conversation history to sync before I call newConversationWithUserIds and have it fail as I mentioned in my first post.


Response doesn't send

Bug Report:
The system's current song request handling mechanism is not thread-safe. When multiple requests are received concurrently, a race condition occurs, causing the initial request to be lost.
When multiple users simultaneously request a song, only the latest request is processed. This prevents the initial requester from receiving a response.

This issue will be fixed soon

Thank U I appreciate your prompt and valuable response.


Typescript: SQL 'value' output is unreadable

We're executing a sql query to get all storage objects of a certain collection. We're using the sql query to bypass the arbitrary hardcoded limit where nakama returns an error if requesting a list of more than 100. I think this should be removed, it's frankly the source of many of our issues and it should be up to the developer to decide what list size is too big. I know we can use a cursor and grab everything but doesn't that amount to many queries? My understanding is that one big query is cheaper than many small ones... but I digress.
We're getting a bizzare output for "value" which is unreadable. The rest seems fine:
rows = nk.sqlQuery(query, parameters);
return JSON.stringify({ success: true, servers: rows });
{       "user_id": "00000000-0000-0000-0000-000000000000",       "write": 0,       "update_time": "2022-06-09T19:52:30.476506Z",       "collection": "servers",       "key": "whatever",       "value": [         123,         34,         71,         97,         109,         101,         77,         111,         100,         101,         34,         58,         32,         49,         44,         32,         34,         83,         101,         114,         118,         101,         114,         78,         97,         109,         101,         34,         58,         32,         34,         66,         114,         101,         110,         100,         101,         110,         34,         125       ],       "version": "745f2988787925a473d1589c25934d14",       "read": 1,       "create_time": "2022-06-09T19:52:30.476506Z"
When I look up the storage item in nakama it reads like this:
{
  "GameMode": 1,
  "ServerName": "Brenden"
}

Any idea why the sql query is returning gibberish? Are you guys doing anything fancy here? I looked at source and didn't spot anything. The database schema also showed that 'value' is stored as JSONB so I would have expected to get the exact parseable JSON here unless there's a bug going on.
Thanks,
Brenden

JSONB columns store the underlying data as binary, so what you're seeing is a raw array of bytes. If you convert that to a string you'll see it reads as {"GameMode": 1, "ServerName": "Brenden"}.
It's not quite as simple as fewer queries leading to better performance, it's a balancing act of one or more of: query complexity, shape of the data on disk, other database activity, table and row lock lifecycle, amount of data returned, length of time the connection is held by any one process, and so on.
All that aside, until you're in production and actively observing problems (or have measured problems in a production-like load testing environment) I highly recommend using Nakama's built-in functions to do this. The pagination approach is tried and tested with large scale production workloads so I'm very interested to learn more about your use case and what issues it's creating for you. You say the pagination requirement for certain APIs is the source of many of your issues - can you go into a bit of detail about what these issues are?

I think in the absence of any new information we can consider this issue resolved by the comment above.
To stress for any other developers finding this issue: we do not recommend writing custom SQL queries to interact with the database if at all possible.


Airdrop to EOS accounts / UID interface

Need clarity of how UID is suppose to be integrated.
Does the airdropper input a posting public key or a wallet public key? Do we allow both and just try to detect?
Will omit UID for now and rebuild only with EOS / Telos accounts.

Need clarity of how UID is suppose to be integrated.
Does the airdropper input a posting public key or a wallet public key? Do we allow both and just try to detect?
Will omit UID for now and rebuild only with EOS / Telos accounts.

It's not the easiest thing for the user to find their posting key, since we don't display it anywhere (as far as I know) but they can access their wallet key via the wallet tab right?
So let's do wallet key.
You mentioned using display names as well, but that could be tricky since users can change it. Seeing how this will be an internal tool for the forseeable time, I think using wallet key is sufficent

It's not the easiest thing for the user to find their posting key, since we don't display it anywhere (as far as I know) but they can access their wallet key via the wallet tab right?
So let's do wallet key.
You mentioned using display names as well, but that could be tricky since users can change it. Seeing how this will be an internal tool for the forseeable time, I think using wallet key is sufficent


stop bit and Parity

Hi @gbmhunter Thanks for your work!
How can I set the parity EVEN, stop bit 1, Databits 7

Hi @RamatovInomjon , it's something I haven't yet added support for, but I should do! Will try and add support for setting the parity, num. stop bits and num. databits in the next few days.

Done! Sorry I did this a while ago, but forgot to close the issue!


Move bot with playlist and music to another server (by samvaio)

samvaio- Yesterday at 1:45 PM
SOME FUTURE MUSIC FEATURE NOTES
Make HaNadeko swap queued music not just between voice channels, but between servers.
For example, if I am playing music on server A, but my friends are in server B instead of asking all of them to change server, I can just use HaNadeko !m servermove in server A first and then then on server B to play my queued music in server B. (and this command makes music to start from beginning so all my friends can hear it.)
Also if the HaNadeko is already in server B  voice channel and playing music then !m servermove just adds all music to queue

It's a pretty cool idea but I do not see a clear way of telling when would someone be allowed to do this.
If we come to a good conclusion ill reopen the issue and implement it asap


Support database connection

It should be possible to use pagination with a pooled connection (as this is required on some hosts, e.g. heroku):
func index(_ request: Request) throws -> Future<Paginated<Item>> {
        return request.withPooledConnection(to: .psql) { connection in
            return try Item.query(on: connection).paginate(for: request)
        }
    }

It would be nice to maybe have an optional parameter connection: Database that can be passe to the paginate function.

The reason the request is there is to help generate the missing pieces for the request. What it does is just read the query parameters for the page and count to allow it to perform the fetch for the given page.
https://github.com/vapor-community/pagination/blob/d018e2a02ed94536ad494ff750057990e8ae1acf/Sources/Pagination/QueryBuilder%2BPaginatable.swift#L50-L67
Implementing the database connection isn't need for something like this, unless I am miss understanding you. Can you maybe elaborate a bit more? 🙂

Oh i see, it is already using the database connection - thanks for your answer!


Where to use your champion algorithem MMDet ? I can not find it.

It will be released after CVPR.

Could you provide an example about how to build the net from Cascade Mask RCNN to the Hybrid Task Cascade using your mmdetection?

#478


solves issue  #24

Pull Request
this PR closes issue #24
Description
I have successfully linked the logo and the text logo to the home page
https://github.com/TailoredUI/TailoredUI/assets/123164129/5138b280-36f3-4705-b74f-ca19d4647a4e

@AMISH-KHAN
Change the base of the pull request from 'main' to 'develop'.

hey @AkashSharma001 I have changed the PR to "develop". please review #44


Export images array drawn from canvas gives the error [object Object]

I add placeholder in Word:

And my code (React):
let blobList: any = [];

const createImageFromCanvas = async () => {
  const cefWidth = 3371;
  const cefHeight = 2420;

  const canvas = canvasRefs.current;
  if (!canvas) return;

  const ctx = canvas.getContext('2d');
  if (!ctx) return;

  const image = new Image();
  image.crossOrigin = "Anonymous";
  image.src = temData.image;

  image.onload = () => {
    // ...draw text...
  }

  await new Promise<void>((resolve) => {
    canvas.toBlob((blob) => {
      if (blob) {
        console.log(URL.createObjectURL(blob));
        blobList.push({
          _type: "image",
          source: URL.createObjectURL(blob),
          format: MimeType.Png,
          width: 500,
          height: 359,
        });
        resolve();
      }
    });
  });
}

const getTemplate = async (): Promise<Blob> => {
  if (theTemplate) return theTemplate;
  const request = await fetch("/files/template_test.docx");
  const defaultTemplate = await request.blob();
  return defaultTemplate;
};

const saveFile = (filename: string, blob: Blob) => {
  // get downloadable url from the blob
  const blobUrl = URL.createObjectURL(blob);

  // create temp link element
  let link: HTMLAnchorElement | null = document.createElement("a");
  link.download = filename;
  link.href = blobUrl;

  // use the link to invoke a download
  document.body.appendChild(link);
  link.click();

  // remove the link
  setTimeout(() => {
    if (link) {
      link.remove();
      URL.revokeObjectURL(blobUrl);
      link = null;
    }
  }, 0);
};

const download = async (e: any) => {
  e.preventDefault();

  console.log("Getting the template...");
  const templateFile = await getTemplate();

  await createImageFromCanvas()

  const jsonData: any = {
    blobList,
    // more data...
  };

  console.log("Parsing data...");
  // const jsonData = getJsonData();
  const data = JSON.parse(JSON.stringify(jsonData));
  console.log(data);

  console.log("Creating document...");
  const handler = new TemplateHandler();
  const docx = await handler.process(templateFile, data);

  console.log("Done!");
  saveFile("output.docx", docx);
};

Log in devtool:

The results I got:

First of all, the source attribute accepts a blob, not a URL. So instead of this:
{
  _type: "image",
  source: URL.createObjectURL(blob),
  format: MimeType.Png,
  width: 500,
  height: 359,
}

Do this:
{
  _type: "image",
  source: blob,
  format: MimeType.Png,
  width: 500,
  height: 359,
}

Second, you can't render a list directly, you need to use a loop for that. Please see: https://github.com/alonrbar/easy-template-x?tab=readme-ov-file#loop-plugin

I tried updating the above code according to your instructions:
await new Promise<void>((resolve) => {
  canvas.toBlob((blob) => {
    if (blob) {
      console.log(URL.createObjectURL(blob));
      blobList.push({
        _type: "image",
-       source: URL.createObjectURL(blob),
+       source: blob,
        format: MimeType.Png,
        width: 500,
        height: 359,
      });
      resolve();
    }
  });
});

// ...

const jsonData: any = {
-  blobList,
+  blobList: blobList[0], // test for one object
  // more data...
};

But I still get the error: Binary type 'Object' is not supported

Not sure what your bug is but here's a code sandbox that works: https://codesandbox.io/p/sandbox/easy-template-x-canvas-demo-dg78mh
I trust that you'll get it from here.
Good luck :)

Thank you very much, I did it successfully, it seems like this in my code is the cause:
const data = JSON.parse(JSON.stringify(jsonData)); // remove this line

removed this line and it worked fine

For this list of images, how do I write a placeholder in Word?

Did you read the loop plugin instructions I linked before?

Yes, I have read it, I add placeholder {#blobList}{/} in Word, log in devtools

The result I get is no image at all, just a blank sheet of paper
What I did in the comments above is only for 1 image

If I write the placeholder {#blobList}{1}{2}{/}, only 2 images (1 and 2) will appear in the array in the image above.

Your template should look like this:
{#blobList}{my image}{/}
And the data like this:
{
  blobList: [
   {
     "my image": {
       _type: "image",
       source: blob,
       format: MimeType.Png,
       width: 500,
       height: 359,
     }
   },
   {
     "my image": {
       _type: "image",
       source: blob,
       format: MimeType.Png,
       width: 500,
       height: 359,
     }
   }
  ]
}

Meaning, the data is an array of objects where each object has a "my image" field (you can name it however you like of course) and the value of this field is the object that represents the image, with _type and all. This is similar to the way the "Beers" list is a list of objects where each has "Brand" and "Price" fields.

I got it, it worked great, thanks for your support ❤.


fix(view.js, center.js) : unregistering map events on scope destroy f…

…or better memory leak management

thanks for your information. I had raised pull request against master in #299


Real time io usage

It is excellent, I use it in my video sequencer to upscale videos.
Would it be possible to have the executable able to be fed images from std in and wait until there are more and end when stdin is closed?
Currently I have either to call the executable on each frame, or take say 100 frames from my video, run it in a folder, then another 100 etc.

I managed to cope with this by caching ahead the video input so the executable gets to scale a whole 1000 frames directory.
Example of my upscaling: Shadow of the Comet


Running dependents (eg always run task B after task A)

Gulp 3 gives control over dependencies which need to run before a given task. With those, I can say task B depends on task A.   But if A has already run and its output is valid, during development when some files B operates on change I may want to just run B without running A. So I'd rather describe the tasks in terms of dependents rather than dependencies. In other words, I'd like to tell Gulp that whenever A runs, B should run afterwards.
If the chain is longer, like A through E, and files are being edited such that only E strictly needs to be run, the entire chain will still run since E depends on D, D depends on C, C depends on B, B depends on A. Say I edit a file such that C needs to run, I do need D and E to run afterwards, but not A and B.
Is there an elegant way to set this up in Gulp 3? At the moment I have a bunch of run-sequences, and it's somewhat unpleasant to maintain, and in certain cases inefficient since I can't so easily dictate which sets of tasks can run in parallel, at least not with a fine level of control.
Or is this something Gulp 4 addresses at all?
I believe even with npm run (package.json scripts) you can define tasks which need to be run after other tasks. I feel that I must be missing something here.

Parallel vs series in Gulp 4 may be suitable.
	gulp.task('A', function() {
	  ...
	}
	gulp.task('B', function() {
	  ...
	}

	// runs A then B
	 gulp.task('buildAthenB', gulp.series( A, B ) );

	// runs A and B concurrently
	 gulp.task('buildAthenB', gulp.parallel( A, B ) );

From there you could set a watch on the output of A to trigger B.
You can even mix and match to fit your dependency needs:
    gulp.task('build', gulp.series(
        'A',                         //1
        gulp.parallel(               //2
            'B',
            gulp.series(
                'D',
                'F'
            )
        ),
        gulp.parallel(               //3
            'C',
            'E'
        ),
        function() {                 //4
            notifier.notify({ message: "All files are built" })
        }
    ));

gulp build now runs:

A
B & D then F
C & E
Notice

Well written @sprynm

I get that and that's nice and I can certainly do what I need to do with it, but I think it'll result in a lot of code and a lot of tasks. When a new task is added I need toI think there will be a lot of redundancy in the gulpfile.
I think it'd be more elegant and much more maintainable to be able to

Define pre- and post- (and during-? haven't thought that through) dependencies along with any given task
Automatically run dependencies when triggering a task
Make it possible to force a task to run without its dependencies running
Define a gulp task which runs a given set of tasks, but automatically determines their interdependencies and so decides the best order to run them in, with as much parallellization as possible
Obviously still allow the gulp.parallel and gulp.series for fine control where necessary


Update stable version in repo from 0.5.4 to 0.5.5

Think about update stable version to 0.5.5
Version: stable=0.5.4 (83 days old) => latest=0.5.5 (15 days old)
Installs: stable=789 (51.53%), latest=98 (6.4%), total=1531
Click to use developer portal
Click to edit
Do not close this issue manually as a new issue will be created if condition for update still exists.
Please drop a comment if any reason exists which blocks updating to version 0.5.5 at this time.
Note: This is an automatically generated message and not personally authored by bluefox!
@mcm1957 for evidence

https://github.com/ioBroker/ioBroker.repositories/pull/3807

This issue seems to be outdated.
This issue suggests to update the stable version of this adapter to 0.5.5 but the current stable version is already 0.5.5.
So this issue should be closed.
@mcm1957 for evidence


If a user denies location permissions, the default view of the explore tab should be worldwide

Describe the bug
If a user denies location permissions, the default view of the explore tab should be all organisms worldwide. Right now, if I deny location permissions, the explore tab still opens "all organisms nearby" with the green "allow location access button"
Expected behavior
If a user has already denied location permissions, the default view of the explore tab should always be all organisms worldwide. The user should only see the locations permissions denied screen when they tap "nearby" in the explore location shooser.
Context (please complete the following information):
Device: iPhone 13 Pro
OS: iOS 17.5.1
App version: 0.73.0 (103)

@angielt can you move this to the top of your list for this iteration, please?

Related problem that this should address:

Fresh install
Go to Explore
Open the Filters
Tap EDIT LOCATION
Tap NEARBY
In the permission gate, tap the the button and chose "Allow once"
Back to Filters
Tap X in upper left
Explore is still showing the ALLOW LOCATION button even though we just allowed location access

Related problem that this should address:

Fresh install
Go to Explore
Open the Filters
Tap EDIT LOCATION
Tap NEARBY
In the permission gate, tap the the button and chose "Allow once"
Back to Filters
Tap X in upper left
Explore is still showing the ALLOW LOCATION button even though we just allowed location access

Was working on this and got this working but explore would freeze when following the above steps and instead denying location permissions. Will make another issue to continue this


[GOBBLIN-253] Enhance Hive materializer.

Enhancements:

No assumption that source tables are Avro.
Can materialize views and queries.
Usage simplification.
Added sample job.

Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA

[X] My PR addresses the following Gobblin JIRA issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"

https://issues.apache.org/jira/browse/GOBBLIN-253

Description

[X] Here are some details about my PR, including screenshots (if applicable):

Tests

[ ] My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

[ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

@abti can you review?

@autumnust addressed or replied to comments


Record the per page number for list when querying after setting it once

Is your enhancement related to a problem? Please describe.

The list shows 10 items by default, which is only half a screen on a screen with a high resolution.
If you want to view more data, you need to modify the number of pages each time you enter the page.

Describe the solution you'd like

Record the number of per page after setting it once. And set it as the default value.

Describe alternatives you've considered

Additional context

Environment

Walrus version: main 068e70303c857a262eb48aa2f7f59bec0073015b
UI version: dev-5976040

Test Result: pass
App Management

Project list page: pass
Environment list page: pass
Variables list page: pass
Connector list page: pass
Member list page: pass
service list page: pass

Cost Management

perspective list page: pass

Operation Hub

template list page: pass
catalog list page: pass
connector list page: pass
global variables list page: pass


#1314 #1869 #2072 Default timeout enhancements

Closes #1314 #1869

#1314
#1869

Proposed Changes

FileGlobalConfiguration add RequestTimeoutSeconds
MessageInvokerPool use RequestTimeoutSeconds

Discussion

#2072

Successors

PR #2081
TODO: https://github.com/ThreeMammals/Ocelot/discussions/2112#discussioncomment-10507241

Thank you for PR creation!
Good start! 🚀
But could you work more plz? Please pay attention also that you need to implement requirements of both issues: #1314 and #1869

Thanks, I'll do this for both tasks

Please find some time to rebase branch onto develop and I'll review.
Do not forget to Sync fork to have actual develop before rebasing.

Also we have to take into consideration this https://github.com/ThreeMammals/Ocelot/discussions/2072#discussioncomment-9469641 !
So, we have old Timeout property 👇
https://github.com/ThreeMammals/Ocelot/blob/cc8f5c5dfc7c56e4446a2e80d97391429c8b364d/src/Ocelot/Configuration/File/FileRoute.cs#L75
We have to reuse it somehow. It's more relevant for #1869 ...

Additionally, we must consider this #2072 (comment). We have an existing Timeout property as shown here:
https://github.com/ThreeMammals/Ocelot/blob/cc8f5c5dfc7c56e4446a2e80d97391429c8b364d/src/Ocelot/Configuration/File/FileRoute.cs#L75
We need to find a way to repurpose it, as it is particularly pertinent to issue #1869

Ok, I found a solution, can you take a look?

Would you stop tagging me?

@raman-m Write tests?)

Why did you push the code which cannot be compiled.
Build error

Write tests?)

Certainly! But I'm going to review finally...

Zhannur,
Your PR is the final one pending for the current release/milestone❗
Could you please prepare for an intense session of pair programming this evening and tomorrow whole day? 🙏
I will help you for sure...
Please consider an extra DevOps to rebase the feature branch onto develop, if you have time. But it is not required, the history is pretty linear.

Hi @ggnaegi  Could you look into MessageInvokerPoolTests and review 2 failed tests please?
I can't get it why do they fail? See my try to fix: https://github.com/ThreeMammals/Ocelot/pull/2073/commits/a09760bdf0febae7273184770a0bc28bec8848e1 but with no luck 😢

@hogwartsdeveloper I'm going to rebase feature branch...

sorry I didn't have time this evening, I'll find time sorry

@hogwartsdeveloper There is commit: Merge remote-tracking branch 'origin/issues-1869' into issues-1869 Why was it committed? Was it conflict resolution, or something else?
Today I'm going to add another commit to develop, so seems rebasing your feature branch will be necessary, we will see...

it was a solution to the conflict

@raman @hogwartsdeveloper Are you sure about the rebase process, I can see some changes from other PR, such as Metadata or Version Policy? Otherwise, ok for me, the acceptance tests are still missing though

@raman @hogwartsdeveloper Are you sure about the rebase process, I can see some changes from other PRs, such as Metadata or Version Policy? Otherwise, ok for me, the acceptance tests are still missing though. Acceptance tests for the default timeout, for the priority of the route timeout over global timeout and for the priority of the QoS timeout over route and global timeout should be foreseen imo.

Add tests to PollyQoSResiliencePipelineProvider add test too?

@hogwartsdeveloper Regarding unit tests...
I think we need tests in

MessageInvokerPoolTests
PollyQoSResiliencePipelineProviderTests

Regarding acceptance tests...

PollyQoSTests
I'm not sure which class is the best to write tests for MessageInvokerPool... Help, @ggnaegi! ContentTests❓

@hogwartsdeveloper Regarding unit tests... I think we need tests in

MessageInvokerPoolTests
PollyQoSResiliencePipelineProviderTests

Regarding acceptance tests...

PollyQoSTests
I'm not sure which class is the best to write tests for MessageInvokerPool... Help, @ggnaegi! ContentTests❓

I added tests

MessageInvokerPoolTests
RoutesCreatorTests

you can check plz?

Hi @RaynaldM !
Are you OK if we do the following changes in lines 64-67

branch L64-L67
PR L64-L67

        var options = route.QosOptions;
        var timeout = options.TimeoutValue;
        if (timeout.HasValue && timeout.Value > 0)
        {
            builder.AddTimeout(TimeSpan.FromMilliseconds(timeout.Value));
        }
        else
        {
            builder.AddTimeout(TimeSpan.FromMilliseconds(_global.QoSOptions.TimeoutValue ?? DefaultQoSTimeoutMilliseconds));
        }

The change involves a new else block that initializes the TimeOut strategy with a global/default value, ensuring the TimeOut strategy is always enabled.
Looks good?

@ggnaegi If you have time, I would appreciate your review of the failed acceptance tests in the Ocelot.AcceptanceTests.ServiceDiscovery namespace. I've attempted to address them with the newly refactored code (refer to commit 02ab62a43e82be0917452ce2f83f1d2537e34674), but without success. The issues seem to be related to the Consul SD logic, the IInternalConfiguration interface, or QoS. Your fresh perspective might help identify the bug or any design flaws. Thank you!
P.S. I will continue with debugging and a deeper code analysis tomorrow...

Attention ❗ ⚠
@hogwartsdeveloper
A new commit in the develop branch has caused numerous merge conflicts in the Polly project files. It's necessary to rebase the feature branch onto develop. I'm starting the rebase process now... your patience is appreciated!

@hogwartsdeveloper Don't push please❗
But if you want to commit more, then you have to delete branch, fetch all, checkout the branch locally 👉

git switch develop
git branch -D issues-1869
git fetch --all
git checkout issues-1869

And you will be able to contribute more 😉

@ggnaegi @RaynaldM
Ready for final code review❗

@RaynaldM You could pay attention to QoS changes → PollyQoSResiliencePipelineProvider
@ggnaegi I need your help with broken acceptance tests related to Consul logic (total 3 failed tests) 👇

Going to rebase onto develop...

Related to

https://github.com/ThreeMammals/Ocelot/discussions/2072#discussioncomment-9469641

What's up, man?

Hello, @RaynaldM!
Your responsibility covers QoS & Polly. Could you please review the following?

src/Ocelot.Provider.Polly/PollyQoSResiliencePipelineProvider

Additionally, if time permits, please examine the rest of the new code in the main library, src/Ocelot/*.
FYI Successor is your PR #2081❗

@ggnaegi, your primary focus should be on MessageInvokerPool. 😄
Kindly review it first at: src/Ocelot/Requester/MessageInvokerPool.
The key method here is DownstreamRoute.TimeoutMilliseconds(), which contains all the logic for the Default Timeout feature. Please make sure to review all the changes!

TODO

[ ] Work on fake changes

TODO

[ ] Write major acceptance tests for linked issues → #1314 and #1869
[ ] Optionally add more unit tests and check code coverage
[ ] Write docs: explain global static default timeout constants, and how to configure global timeouts

TODO

[ ] Rebase the branch due to merge conflicts

TODO

[ ] Write major acceptance tests for linked issues → #1314 and #1869
[ ] Optionally add more unit tests and check code coverage
[ ] Write docs: explain global static default timeout constants, and how to configure global timeouts


draw to target after DOMContentLoaded

closing because this property is implicitly satisfied by the fact that a DOM node needs to be provided to for the app to draw.


Critical issue when passing workers != 1

When using the latest version 3.9.6, I get a critical error when using workers != 1, i.e. I cannot use multi-processing to speed-up string comparisons; see the below screenshot. The error does not occur in rapidfuzz 3.5.2, however.

What is causing the issue? Apart from downgrading, is there a fix?
(Note: I have also posted this issue on StackOverflow.)

Just FYI cdist works on lists of strings. So in your examples this would run a similarity comparison on the individual characters.
On which platform are you testing? I can't reproduce this on my regular machine.

In addition you could try the versions in between 3.5.2 and 3.9.6 to see when this issue was introduced

Hi @maxbachmann,
thanks for your quick reply :) I'm aware that cdist runs on lists and iterates over individual characters when single strings are passed. I just had not noticed it when uploading the screenshot. But it is in any case unrelated to the error.
I tested several rapidfuzz versions from 3.5.2 onwards. The bug occurs from 3.9.4 onwards, i.e. only in newer versions of rapidfuzz.

Side note: The original motivation to upgrade from 3.5.2 to the latest version (3.9.6) was a bug that I noticed in the 3.5.2 version which has apparently been fixed somewhere in between:
https://stackoverflow.com/q/78923595/5269892
Regarding the platform: I'm using python 3.11.6 in an IPython 8.25.0 console inside PyCharm 2024.1.1 Community Edition on a Windows 10 Enterprise laptop. Are there any specific platform characteristics you would like to know?

This should be caused by an upgrade of visual studio which made an incompatible change to std::mutex (https://github.com/microsoft/STL/wiki/Changelog#vs-2022-1710). I should be able to make a build with _DISABLE_CONSTEXPR_MUTEX_CONSTRUCTOR that should solve this issue.

@silenceOfTheLambda can you check whether version 3.9.7 fixes the issue for you?

@silenceOfTheLambda can you check whether version 3.9.7 fixes the issue for you?

Yes, in 3.9.7 the bug does not occur. Thanks for the quick fix, great work :)


feat: overflow cells, writing overflow values

This handles the encoding of overflow cells and writing them in leaves.
In a leaf node, we use a 16-bit integer to encode the offset of each cell start. We take the high bit of this integer to encode whether the cell is an overflow cell or not.
When ingesting a value, if it's too large, we chunk it. Additionally, LeafUpdater::ingest has gained a callback for handling deletion of overflow cells. This will be fleshed out in the next PRs, along with loading of overflow values.
I am not focusing on optimization at all at the moment, as it's clear that the beatree update logic needs to be rewritten for parallelism in any case and any optimization at this stage would be wasted effort.

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#324  👈
#322
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @rphmeier and the rest of your teammates on  Graphite

Merge activity

Aug 26, 3:30 PM EDT: @rphmeier started a stack merge that includes this pull request via Graphite.


Internet Connection Problem After Adding Sentry Package to Flutter Project

Hello!
My application loses the internet connection in the device after adding sentry to the project. In an emulator, it is ok, but the connection fails in the device.

@Bunny1376 I'm pretty sure this is not related to the Sentry's SDK.
Do you have an error message or something to look at?
Thanks.

@Bunny1376 any news here?

Closing the issue as a part of large repository cleanup, due to it being inactive and/or outdated.
Please do not hesitate to ping me if it is still relevant, and I will happily reopen and work on it.
Cheers!


Major changes

Hi there,
I found your mod after an excellent demo from @Ultrawipf. It's cool to see how the free camera can be made into a drone with some simple physics applied, and the results are great. I can see some professional drone pilots creating some nice videos of virtual drifting with it.
I've had a go at re-writing the physics it uses, in order to allow users to input real data about the drone. This should allow the simulated physics to correlate with the real thing (hopefully). I also added some new input options (inverted axis, combined axis) to allow users (like myself) to use a gamepad, rather than a flight controller. I also fixed some issues regarding the flight dynamics being affected by the framerate. I've not written anything in Python before, so it was a personal challenge of learning a new language too. It also taught me about AC app development, which is nice.
Have a look and see what you think. I've tested it personally and had others too, and we think the gravity is still a bit weak, though I don't want to artificially increase it since the drag equations and gravity forces should all be true-to-life. Maybe I'm missing something obvious in the simulation that may solve it.
I've changed the default config (with the new format) to some tested values that feel decent, but I guess it depends on the type of drones you fly and what you're comfortable with. Feel free to experiment and report back on what you think of it 😄
Morgan Gardner
Major Changes

Physics re-write, now use mass, air density, wingspan (calculated surface area), and forces calculated for gravity, drag, and thrust.
Input scaling altered, separating from deltaT (old system was affected by framerate).
config.defaults.ini added. Used by Content Manager to provide descriptions, defaults, and new controls to the app settings

Thanks so much. There is still some weird stuff going on with the physics but i will look into it as soon as i have time.

Honestly, it was not my equation that I used, I found it somewhere, but I agree, looking at it now, it doesn't match the basic physics equations for acceleration, velocity, etc.
After testing your changes I do see that it feels much better (the drone drops faster with gravity).
A final thing to mention may be to add some rotational inertia, so the forces involved in rotating the drone (giving the wingspan and mass) are applied, rather than directly controlling the roll/pitch/yaw from the joystick inputs directly.

Yes, that would be an idea. I also thought about adding wind, different surface area depending on the rotation or a full pid controller. I will merge this now. Thanks

What about converting to quaternions instead of Euler rotations? I'm sure I noticed before that there's a slight drift off-axis (not noticeable while actually flying around). I was testing the gravity and drag by limiting the motion to just vertical Z, and I started getting ever so slight X and Y movement too. Maybe it's not related, but it's definitely not an issue in the real use-case.

I noticed that too but only on some maps (i think). I don't think quaternions would fix that and working with them is probably more difficult. I also didn't have a problem with gimbal lock while testing so i don't know if it's worth it.


Search Enhancements - tags, help, keywords

Search still feels rather clunky, I rarely find what I am looking for quickly.

Rather than limiting the results and sorting them by date, I'd rather score the results with some algorithm, maybe inspired by a fuzzy finder (fzy/fzf) or something.
This way you don't need to ignore common words either, which can lead to unintuitive behavior, but rather reduce their influence on the score: https://chat.ftt.gmbh/help/search-for-messages#words-and-phrases

I cannot search for hashtags, even with quotes - so searching for "#wiki" returns everything containing the word wiki, which is a bit annoying and hinders the implementation of https://github.com/zulip/zulip/issues/2329 even with linkifiers.

Lastly, when I am in the search bar, a direct link to the search section in the help center would be handy, similar for example to the little "You can use Quick Add Magic. What?" on https://try.vikunja.io/

@zulipbot claim

This is one of the main factors making Zulip hard to use, as we have a vast collection of resources accumulated over the messages and are unable to discover them again most of the time.

Replying to @xeruf points 1. & 2.: after a short review of Zulip, I find that search is sub-optimal, including lack of ability to search for #tags, which would allow more fuzzy search results, acros streams and topics - not everything is easily put into category(stream)/sub-category(topic) format.


[ISSUE-5286]  Integration tests for MaxRcptHandler

i am tackling this issue

@florentos17 squash fixups and clean git history?


transformer-compile-class changes neither generate nor update

UnoCSS version
0.53.5
Describe the bug

in playground

<button bg-white class=':uno-my-test: text-(black 2xl) w-22 h-22'>你好</button>
When you change
<button bg-white class=':uno-my-test: text-(black 2xl) w-22 h-10'>你好</button>
It is not compiled and updated

in my project Error screenshot

https://github.com/unocss/unocss/assets/24783915/1de2aded-55a6-4a2b-a9ac-1fb2e00a64bf
Reproduction
playground
System Info
mac: 13-inch, 2018 os:13.4.1
chrome:114.0.5735.198
Validations

[X] Read the Contributing Guidelines.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

This is similar to the previous problem, except that here we use a custom class prefix. I have seen that it is said that this problem has been solved, but in fact there is still a problem. Referenc：playground issue:2667

ENV: Nuxt + UnoCSS

Same issue, and I dont use custom prefix. transformer-compile-class will generate prefix-shortcode instantly, however, not generate css in _unocss.css file.

I am facing the same issue. I have to restart the server every time manually to see the transformer's effect.


deps: update to<EMAIL_ADDRESS>

Closes #3613
Closes #3712
Closes #3577

Closes https://github.com/camunda/camunda-modeler/issues/3709 too


AzureResourceGroupDeployment@2 doesn't support multi-line strings

Type: bug
Enter Task Name: AzureResourceGroupDeployment
Environment

Azure Pipelines
Agent Info:

Issue Description
It seems like the AzureResourceGroupDeployment task doesn't handle correctly multi-lines in my ARM template. There is a user-defined function in my template. While this version is deployed without any problem

the version when the value is split into multiple lines is failing:

According to the documentation this should work. And actually, the ARM template is deployed successfully when the PowerShell is used. But when I'm trying to deploy it with use of Azure Resource Group Deployment Task, it fails:

2021-01-22T11:50:15.6031626Z Creating deployment parameters.

2021-01-22T11:50:15.6205264Z The detected encoding for file 'D:\a\1\s\infra\configuration\DailyProcessing\azuredeploy.json' is 'utf-8'

2021-01-22T11:50:15.6318501Z ##[error]Check out the troubleshooting guide to see if your issue is addressed: https://docs.microsoft.com/en-us/azure/devops/pipelines/tasks/deploy/azure-resource-group-deployment?view=azure-devops#troubleshooting

2021-01-22T11:50:15.6340620Z (node:1588) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.

2021-01-22T11:50:15.6346063Z ##[error]Error: Ensure the Template file ( 'D:\a\1\s\infra\configuration\DailyProcessing\azuredeploy.json' ) is valid. Task failed while parsing with following error: Unexpected token in JSON at position 2127

2021-01-22T11:50:15.6449989Z ##[section]Finishing: DailyProcessing-ru (configuration)

FYI, here is the screenshot of my testing pipeline I'm using to deploy the ARM template as well:
[Include task name(s), screenshots and any other relevant details]

Error logs

2021-01-22T11:50:15.6318501Z ##[error]Check out the troubleshooting guide to see if your issue is addressed: https://docs.microsoft.com/en-us/azure/devops/pipelines/tasks/deploy/azure-resource-group-deployment?view=azure-devops#troubleshooting

2021-01-22T11:50:15.6340620Z (node:1588) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.

2021-01-22T11:50:15.6346063Z ##[error]Error: Ensure the Template file ( 'D:\a\1\s\infra\configuration\DailyProcessing\azuredeploy.json' ) is valid. Task failed while parsing with following error: Unexpected token in JSON at position 2127

I can confirm I have seen this as well. Ensured the ARM template had a schema set to the latest value in case that had an effect (https://schema.management.azure.com/schemas/2019-04-01/deploymentTemplate.json#).
This would be very useful to have, more complex statement are difficult maintain when they are all on a single line.

I'm having a similar issue with the ARM template deployment@3 task. I originally thought it was an issue with Azure DevOps since I was running the ARM template successfully through Azure CLI.

Just commenting to say this is definitely still something we would find useful 👍


Implement support for Squiggly annotations

Notice that the reduced test case provided with this patch now renders just like Adobe Reader/Acrobat and without any warnings in the console.

/botio-linux preview

/botio test

r=me, with less duplication in the CSS.

/botio-linux preview

/botio test

Landing with r=Snuffleupagus and r=me.
/botio makeref


feat: (IAC-298) Security update - use-forwarded-headers set to false for ingress-ngnix

Changes:
Previously the default value for use-forwarded-headers was set to true. This has raised a security concern as it allows spoofing source IP via X-Forwarded-For header.
NGINX Ingress Controller states the use of use-forwarded-headers as follows:

If true, NGINX passes the incoming X-Forwarded-* headers to upstream. Use this option when NGINX is behind another L7 proxy / load balancer that is setting these headers.
If false, NGINX ignores incoming X-Forwarded-* headers, filling them with the request information it sees. Use this option if NGINX is exposed directly to the internet, or it's behind a L3/packet-based load balancer that doesn't alter the source IP in the packets.

As NGINX is not behind another L7 proxy / load balancer this PR will set the use-forwarded-headers to false by default. Instructions are added in troubleshooting guide if user wishes to enable this setting.
Tests:
Verified on following scenarios, the deployment stabilized and applications were accessible using the change use-forwarded-headers = false. See additional details and tests in internal ticket:

Scenario
Task
Provider
Cadence

1
OOTB
Azure
fast:2020

2
OOTB
AWS
fast:2020

3
OOTB
GCP
fast:2020

I am ok with this as long as we tested the SAS coded and verified that the systems still work without this item.

Yes this change was verified on all the cloud providers, SAS Viya Platform deployments were successful and applications were accessible.


github: consider using GitHub Discussions

The Go project uses the GitHub issue tracker for tracking bugs, not for asking questions or having general discussions.
Proposal #23745 was about considering using it with a "question" label, which we tried, but it wasn't a great experience for everyone involved (an issue tracker is designed primarily for tracking bugs, not asking questions or having discussions), and so we didn't proceed with it.
As @mvdan mentioned in https://github.com/golang/go/issues/23745#issuecomment-591378648, GitHub is working on a new Discussions feature that is specifically for having discussions rather than tracking bugs. Once it becomes available for general use, we can consider using it for the Go project. Edit: It's now available in beta.
This is the tracking issue.
(Until something changes, please see https://golang.org/wiki/Questions for a list of places to ask questions and having discussions.)
/cc @golang/osp-team

Could we consider moving this forward?  It looks like there are some iterations to the Generics draft and I think it would be beneficial to discuss with the community members who perhaps aren't subscribed to or scanning go-nuts (looks like there's ~10 people in that thread).  It's been made clear that the longstanding Generics issue isn't the place, so I'm wondering what the thought is regarding turning on the Discussions beta.

Discussions was released today, so I remembered this one. I really hope that Go will have a centralized and relatively casual place for people to discuss and ask questions. Please think about it, maybe give it a try?

Yes, it was!
I think we will want to give it some time to get a sense of how well it works (it's still in beta, after all), whether there's an API available (or becomes available in the future), and so on. So, I don't think we'll want to activate it on day one, but let's give it some time. This is the issue where we'll post updates.
(For anyone else seeing this issue, please keep https://golang.org/wiki/NoPlusOne in mind. If you just want to express that you'd like to see this happen, leave a reaction instead of a comment.)

 See https://github.com/golang/go/discussions/47139.

related #61188


[1.8.9] Spawners crashes server, conflict with Spongeforge

Server crashes when I activate a wither skeleton spawner.
Crash report: http://pastebin.com/g96eaCPy

Could you try updating SpongeForge? They are currently on build 1395 while you are on 1336. If that doesn't work, I'd report it to them. They're doing some weird casting shenanigans on their end.

Any news?

updating to spongeforge-1.8.9-1890-4.2.0-BETA-1421 fixed it.


Get lfs going and add installers

Tried to add with b298929, but 100% not doing it right.

Actually, looking again I see it did work, I just had to add an exception in the gitignore for the file I'm pointing to.


Improved feature: observe DOM changes instead of manually setting scrollactiveItems with setScrollactiveItems()

Changes:

add a DOM MutationObserver to listen for Node addition/deletion
console.warn instead of throwing error when the destination of the hash does not exist in the DOM yet as it may exist at some point in the future
update window.location.hash after the scroll animation (when scrollactive-item was clicked) so that we get kind of the same behavior as a normal link with a hash

Great additions, I really appreciate your help! I'm merging and soon updating the package.


Release 4.13.0 for Windows

Add total of 16 audio players for 12 HOURS of Relaxing Fireplace Sounds - Burning Fireplace & Crackling Fire Sounds. Upgrading the previous number of 12 audio players.

https://github.com/kkamara/kelvinkamara/releases


map div's position gets changed to relative

The api seems to change the map div's position to relative from what ever the user had set it to. I had position the map at  a certain absolute position on my page, but the maps is created, the div's position is changed to relative which messes up the layout of the map on my page
Thank You,
Vish

Did you find a solution to this?

This got fixed as above.
If it is broken again then please open a new issue and relate it to this. Thanks.

For the next one to reopen a new issue to follow up on this one, I had to use
#map {
    position: fixed !important;
}

which felt bad and ugly to fix a map to the background.

Had to use !important too.


Add JVM API dump

It will let us get more confidence that no API changes (wrt. signatures) are introduced whenever we e.g. refactor stuff, and help us review API changes if we make them.

It could be a good idea to add a check (in another PR) to make sure we don't expose any Okio types in the public ABI? Just a simple "Okio" !in file("snake-kmp.api").readText() check.


Change setup name

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 93.174%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
273

Relevant Lines:
293

💛  - Coveralls


Get thumbnail as base64Image

frameQuality
Setting this prop will fire onFrameChange callback

0 (default) - Don't display the video in fullscreen
1 - Display the video in fullscreen

Platforms: iOS, Android

onFrameChange
callback function that is called for each frame when frameQuality > 0`, results each frame as base64Image(thumbnail)
  <Video
    {...videoProps}
    frameQuality={0.3} // required to fire callback
    onFrameChange={(thumbnail: string) => setThumbnail(thumbnail)}
  />

Platform: iOS, Android

Closed due to inactivity


Adding sample reads tool.

I've found this useful for testing but not sure it is worth having in the repo.

Rebased and addressed review comments.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/cannoli-prb/36/Build result: FAILURE[...truncated 15 lines...] > /home/jenkins/git2/bin/git fetch --tags --progress https://github.com/bigdatagenomics/cannoli.git +refs/pull/:refs/remotes/origin/pr/ # timeout=15 > /home/jenkins/git2/bin/git rev-parse origin/pr/41/merge^{commit} # timeout=10 > /home/jenkins/git2/bin/git branch -a -v --no-abbrev --contains c0de23351b8f0124732024f7eda07e4878bf2f15 # timeout=10Checking out Revision c0de23351b8f0124732024f7eda07e4878bf2f15 (origin/pr/41/merge) > /home/jenkins/git2/bin/git config core.sparsecheckout # timeout=10 > /home/jenkins/git2/bin/git checkout -f c0de23351b8f0124732024f7eda07e4878bf2f15First time build. Skipping changelog.Triggering cannoli-prb ? 2.6.0,2.11,1.6.1,centosTriggering cannoli-prb ? 2.3.0,2.11,2.0.0,centosTriggering cannoli-prb ? 2.6.0,2.10,2.0.0,centosTriggering cannoli-prb ? 2.6.0,2.10,1.6.1,centosTriggering cannoli-prb ? 2.3.0,2.10,2.0.0,centosTriggering cannoli-prb ? 2.3.0,2.11,1.6.1,centosTriggering cannoli-prb ? 2.6.0,2.11,2.0.0,centosTriggering cannoli-prb ? 2.3.0,2.10,1.6.1,centoscannoli-prb ? 2.6.0,2.11,1.6.1,centos completed with result FAILUREcannoli-prb ? 2.3.0,2.11,2.0.0,centos completed with result FAILUREcannoli-prb ? 2.6.0,2.10,2.0.0,centos completed with result FAILUREcannoli-prb ? 2.6.0,2.10,1.6.1,centos completed with result FAILUREcannoli-prb ? 2.3.0,2.10,2.0.0,centos completed with result FAILUREcannoli-prb ? 2.3.0,2.11,1.6.1,centos completed with result FAILUREcannoli-prb ? 2.6.0,2.11,2.0.0,centos completed with result FAILUREcannoli-prb ? 2.3.0,2.10,1.6.1,centos completed with result FAILURENotifying endpoint 'HTTP:https://webhooks.gitter.im/e/ac8bb6e9f53357bc8aa8'
Test FAILed.

Changes Unknown when pulling 7649103a1ccae2e01d67fe51740e0996385cccc7 on heuermh:sample-reads into ** on bigdatagenomics:master**.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/cannoli-prb/37/
Test PASSed.

Coverage decreased (-1.9%) to 30.556% when pulling 7ca3ff9cdcbee05914fc60c1c87f5621fc1d3e83 on heuermh:sample-reads into b026a94ffb93b7c5e0065b488d601b727a822d8f on bigdatagenomics:master.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/cannoli-prb/48/
Test PASSed.