macOS exporter ignores shared objects tags

Godot version
3.4.4.stable
System information
macOS 11, M1 Pro, GLES 3
Issue description
When exporting GDNative shared objects on macOS, the exporter ignores the shared object tags and stores multiple dylib files under the same path, effectively overwriting the file. This makes it impossible to export a multi-arch app on macOS.
https://github.com/godotengine/godot/blob/3.4.4-stable/platform/osx/export/export.cpp#L936-L954
Godot Export Log:
export dylib: [...]/native/target/x86_64-apple-darwin/release/libnative.dylib -> [...]/Library/Caches/Godot/Game.app/Contents/Frameworks/libnative.dylib
codesign ([...]/Library/Caches/Godot/Game.app/Contents/Frameworks/libnative.dylib):
[...]/Library/Caches/Godot/Game.app/Contents/Frameworks/libnative.dylib: signed Mach-O thin (x86_64) [libnative-555549449b9f202bca4f3c55b3b6bf69762e15a8]

export dylib: [...]/native/target/aarch64-apple-darwin/release/libnative.dylib -> [...]/Library/Caches/Godot/Game.app/Contents/Frameworks/libnative.dylib
codesign ([...]/Library/Caches/Godot/Game.app/Contents/Frameworks/libnative.dylib):
[...]/Library/Caches/Godot/Game.app/Contents/Frameworks/libnative.dylib: replacing existing signature
[...]/Library/Caches/Godot/Game.app/Contents/Frameworks/libnative.dylib: signed Mach-O thin (arm64) [libnative-555549447c38cc49f3c13759a06cbbf489f3bfad]

Steps to reproduce

add a gdnative gdnlib
add the dylib paths similar to this:

OSX.x86_64="res://native/target/x86_64-apple-darwin/release/libnative.dylib"
OSX.arm64="res://native/target/aarch64-apple-darwin/release/libnative.dylib"

add the features x86_64 and arm64 to the export preset
export the project

Minimal reproduction project
No response

This is expected, default macOS exports are universal (x84_64 + arm64) and have both tags set. Also, placing libraries in the subfolders is not supported in 3.x (it is in 4.0), everything is placed directly into the Frameworks folder.
You can merge both libs into a single universal lib using lipo, and use a single OSX=... path in the gdnlib.

Thanks to https://github.com/godotengine/godot/issues/60692#issuecomment-1114265591 by @bruvzg I now set it up this way:
add three entries to the gdnlib:
[...]

[entry]

OSX.x86_64="res://native/target/x86_64-apple-darwin/release/libnative.dylib"
OSX.arm64="res://native/target/aarch64-apple-darwin/release/libnative.dylib"
OSX.universal="res://native/target/universal-apple-darwin/release/libnative.dylib"

[...]

and a universal custom feature to the export preset:
[preset.0]

name="macOS"
platform="Mac OSX"
runnable=true
custom_features="universal"

[...]

This will cause the project to be exported with a universal library file, but can still locally be executed with architecture-specific libraries. Since all three files share the same name, Godot will always locate the right library, also in the final export.


Attachment

How about to add support of attachments ?

Yes, this is possible.  Sounds like a good idea.  I'll try to get to it sometime this week.

First thanks for your great contact form but could you please add attachments? :)
I've tried to implement it myself but nothing works.


Printing policies - Print background graphics

Is it possible to enable the "Background graphics" setting for printing via GPO?
I was able to find the " Print headers and footers" (PrintHeaderFooter) policy but
the "Background graphics" policy seems to be missing.
https://docs.microsoft.com/en-us/DeployEdge/microsoft-edge-policies#printing-policies
Will this setting be available in the future if it isn't already?

@MaxBGitHub We've added new polices in version 89 for Background Graphics.
Here are links to our documentation:
https://docs.microsoft.com/en-us/deployedge/microsoft-edge-policies#printingallowedbackgroundgraphicsmodes
https://docs.microsoft.com/en-us/deployedge/microsoft-edge-policies#printingbackgroundgraphicsdefault

@Y-Kelly Great, Thank you for the update!

I would like a policy for silent printing, i.e. --kiosk-printing instead of having to call:
"C:\Program Files (x86)\Microsoft\Edge\Application\msedge.exe" --kiosk https://example.org/ --kiosk-printing
The policy would come in handy since you cannot pass parameters to Assigned Access / Kiosk mode via Windows Settings.

@shapeh I've passed your feedback on to the team.  If you haven't had a chance yet, you can also submit feedback through the browser ("..." menu > Help and feedback > Send feedback)  Thanks!

@Y-Kelly Thanks for the quick response and for passing on my comments. Hope they will be implemented. I have stopped using the Help and feedback service - we rarely see any response on that system unfortunately, despite some decent suggestions (I guess there is too looong a distance between the product teams and the people who monitor the feedback system). Github response seems to work better. :)

@shapeh There looks to be some discussion related to your feature request but no ETA right now.  Thanks!

@Y-Kelly I have run into sever problems related to Edge with Assigned Access / security issues. I have posted it on the Feedback hub but I am not sure it will be seen by the right people. If you can, please notify the right team - please see here: https://aka.ms/AAd5fv7

@shapeh I don't have access to view the feedback.
Are you trying to set up Kiosk mode for your organization?  We have a few options for help, first our FastTrack team which can help transition to MS Edge https://www.microsoft.com/en-us/fasttrack/microsoft-365/microsoft-edge, you can also reach out to our support team https://microsoftedgesupport.microsoft.com/hc/en-us or for Enterprise specific questions you can visit the Enterprise section of the Tech Community. Thanks!

@Y-Kelly - we have found some security problems with Edge in Kiosk mode. We have submitted the request to https://www.microsoftedgeinsider.com/en-us/support
Thanks.


Implement multipart uploading for S3 files larger than 5GB

Feature Request
Desired behaviour
See https://docs.aws.amazon.com/AmazonS3/latest/dev/usingHLmpuJava.html
Currently, 5GB uploads result in
com.amazonaws.services.s3.model.AmazonS3Exception: null (Service: Amazon S3; Status Code: 400; Error Code: EntityTooLarge; Request ID: tx00000000000000000fae4-0058886cf8-50570c-default), S3 Extended Request ID: 50570c-default-default

FYI @keiranmraine
Environment (Browser or OS and Dockstore version)
1.1.2

Untested (I need to set up a build environment yet).  Reading suggests this would replace the S3 block.
        if (destPath.startsWith("s3://")) {
          AmazonS3 s3Client = FileProvisioning.getAmazonS3Client(config);
          TransferManager tx = TransferManagerBuilder.withS3Client(AmazonS3)
          String trimmedPath = destPath.replace("s3://", "");
          List<String> splitPathList = Lists.newArrayList(trimmedPath.split("/"));
          String bucketName = splitPathList.remove(0);

          Upload myUpload = tx.upload(bucketName, sourceFile.getName(), sourceFile);

          myUpload.addProgressListener(new ProgressListener() {
              ProgressPrinter printer = new ProgressPrinter();
              long runningTotal = 0;

              @Override
              public void progressChanged(ProgressEvent progressEvent) {
                  if (progressEvent.getEventType() == ProgressEventType.REQUEST_BYTE_TRANSFER_EVENT) {
                      runningTotal += progressEvent.getBytesTransferred();
                  }
                  printer.handleProgress(runningTotal, inputSize);
              }
          });
          // After the upload is complete, call shutdownNow to release the resources.
          tx.shutdownNow();
          System.out.println();
        } else {

This will allow up to 150GB
Will need to test the file size to set an appropriate chunk size as a maximum of 10,000 chunks are allowed and they default to 15MB.  Quite likely this will be exceeded for things like BAM files.  Looks like the following is what is needed:
TransferManager tx = TransferManagerBuilder.withS3Client(AmazonS3).withMinimumUploadPartSize(XXXXX);

Doc for method here.

Released as part of 1.1.5


No additional examples

Under each section in the documentation is a link that says "See more examples of {section} here.". In some of these sections multiple implantations are discussed but not showcased, for instance the Codes section. Please can we either provide more examples or remove the link as it is quite frustrating to the user: landing on a page showing an isolated view of the section you just clicked on, on its own page.

Possible to add the example pages to source control? I forked with the intention of building them out but couldn't find them :)

@tomholford I believe you will find the examples here: https://github.com/milligram/milligram.github.io

Ah of course, thanks @olorton. Added an example :)

Hello guys.
Recently I updated the repository and I created two account, in Codepen and another in Codepad, to support new examples. In the future I want to create a section for use cases and add more examples. I appreciate the interest in improvements and who can help with tips and examples, it will be amazing. For now I will closed this issue.
Anyway sorry for the delay, I was out for few time, but this month will update all repositories and website.


Kernel crashes when attempting to load LLC4320 through Scisever

Description
There is some missing data in some zarr files associated with vertical velocity, which causes (chuncking and performance) errors when creating the OceanDataset in the following way:
od = oceanspy.open_oceandataset.from_catalog('LLC4320')

You get something like:
/home/idies/miniconda3/envs/Oceanography/lib/python3.9/site-packages/xarray/core/indexing.py:1228: PerformanceWarning: Slicing is producing a large chunk. To accept the large
chunk and silence this warning, set the option
    >>> with dask.config.set(**{'array.slicing.split_large_chunks': False}):
    ...     array[indexer]

To avoid creating the large chunks, set the option
    >>> with dask.config.set(**{'array.slicing.split_large_chunks': True}):
    ...     array[indexer]
  return self.array[key]
/home/idies/miniconda3/envs/Oceanography/lib/python3.9/site-packages/dask/array/core.py:4781: PerformanceWarning: Increasing number of chunks by factor of 24
  result = blockwise(
/home/idies/miniconda3/envs/Oceanography/lib/python3.9/site-packages/dask/array/core.py:4781: PerformanceWarning: Increasing number of chunks by factor of 13
  result = blockwise(
/home/idies/miniconda3/envs/Oceanography/lib/python3.9/site-packages/xarray/core/indexing.py:1228: PerformanceWarning: Slicing is producing a large chunk. To accept the large
chunk and silence this warning, set the option
    >>> with dask.config.set(**{'array.slicing.split_large_chunks': False}):
    ...     array[indexer]

and then, the kernel crashes. I wasn't getting this error through datascope, so it took me a while to figure this one out!
Solution
The problem arose when I added the vertical velocity to the preexisting velocity zarr stores (files). My error was that I missed the last day of data and so the last three zarr files do not have the vertical velocity. Forcing files are also missing for the last day, but that didin't cause any error (because forcing files are separate).
No PR is needed to fix this. I just have to transform and add the missing files from binary to zarr. This should be done later today, and once all is good, I will close this issue.

Finished transforming the remaining binary w files. The od loads fine. Therefore, I am closing issue.


[Improvement] GravitinoClient needs metalake to obtain version

What would you like to be improved?
Currently the GravitinoClient requires a known metalake name if you want to get the server version number. This is an issue if no metalakes exist.
How should we improve?
You should be able to get the version number without knowing the name of any existing metalakes.

Hello, I would like to give it a try. Can this task be assigned to you

Where should I have made the modifications? Can you provide me with assistance

You want to take a look at GravitinoClient.java / GravitinoClientBase.java and the serverVersion() method. serverVersion() doesn't require a metalake, but the GravitinoClient build method checks that the metalake is not null or empty. The GravitinoClient constructor also calls loadMetalake.

You want to take a look at GravitinoClient.java / GravitinoClientBase.java and the serverVersion() method. serverVersion() doesn't require a metalake, but the GravitinoClient build method checks that the metalake is not null or empty. The GravitinoClient constructor also calls loadMetalake.

Hello, I have made some modifications based on your prompt. Do you have any questions? Feel free to communicate with me anytime

Hey, was that possible that I can work with this task together?


[Feature]fix compile error with jdk11

Search before asking

[X] I had searched in the issues and found no similar feature requirement.

Problem Description
compile with jdk11 error
Description
no
Use case
no
Solutions

property.putAll  change to  map.foreach {case (k,v) => props.put(k,v)}
add jakarta api with removed by jdk11
scala and jdk11  constants access problem

Anything else
no
Are you willing to submit a PR?

[X] Yes I am willing to submit a PR!

finished


[SPARK-45377][CORE] Handle InputStream in NettyLogger

What changes were proposed in this pull request?
Handle InputStreams in the NettyLogger so we can print out how many available bytes there are.
Why are the changes needed?
As part of the SSL support we are going to transfer InputStreams via Netty, and this functionality makes it easy to see the size of the streams in the log at a glance.
Does this PR introduce any user-facing change?
No
How was this patch tested?
CI. Tested as part of the changes in https://github.com/apache/spark/pull/42685 which this is split out of, I observed the logs there.
Was this patch authored or co-authored using generative AI tooling?
No

cc: @mridulm @JoshRosen this is now ready to review and has all green tests on CI

Merged to master


Compilation issues fix

We were having two issues compiling the repository.

The find_package pkg macro, which was conflicting with vcpkg in Windows. Removing it didn't broke the linux build.

Qt version lack of compatibility. The QFontMetrics class from 5.13  doens't have width() method. It was changed to horizontalAdvance(). And I guess they it will keep that way for the next LTS version.

I bumped the supported Qt 5 version to 5.15 and Qt 6 should work now as well.

I bumped the supported Qt 5 version to 5.15 and Qt 6 should work now as well.

yay Thanks!


mtprotoproxy: 1.0.5 -> 1.0.6

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/mtprotoproxy/versions.
meta.description for mtprotoproxy is: '"Async MTProto proxy for Telegram"'.
meta.homepage for mtprotoproxy is: '"https://github.com/alexbers/mtprotoproxy"
Release on GitHub
Compare changes on GitHub

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 1.0.6 with grep in /nix/store/rrccqqyixdpzdjmcb7fgmy8c5gz3qwki-mtprotoproxy-1.0.6

directory tree listing: https://gist.github.com/1aafe69ef031c633f63665d6e954c26e

du listing: https://gist.github.com/1dcab634c3b334e64711071839e20500

Rebuild report (if merged into master) (click to expand)

4 total rebuild path(s)
1 package rebuild(s)
1 x86_64-linux rebuild(s)
1 i686-linux rebuild(s)
1 x86_64-darwin rebuild(s)
1 aarch64-linux rebuild(s)
First fifty rebuilds by attrpath
mtprotoproxy

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/rrccqqyixdpzdjmcb7fgmy8c5gz3qwki-mtprotoproxy-1.0.6 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)
Or, build yourself:
nix-build -A mtprotoproxy https://github.com/r-ryantm/nixpkgs/archive/c41a11634195c3ed9343f4bd92476d932ba8ced4.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/rrccqqyixdpzdjmcb7fgmy8c5gz3qwki-mtprotoproxy-1.0.6
ls -la /nix/store/rrccqqyixdpzdjmcb7fgmy8c5gz3qwki-mtprotoproxy-1.0.6/bin

cc @abbradar for testing.

@GrahamcOfBorg build mtprotoproxy


False exceptions

In my experience, train systems occasionally display false errors. Such as platform changes when in fact, there was no change and the original service is running correctly.
Perhaps similar imaginary exceptions could be produced?

Not sure how this would be implemented. Pull requests are welcome!

Hah yeah I can't actually figure out the implementation.  Ah well!


Selling part to remove stock

When creating a part you can flag it as "Sellable", but there doesn't seem to be a way to remove stock via a sale.  The only work around I see is to go into the stock page for the part and select "Take from stock".  Is there another method of marking a sale?  Would be nice to have a process so that stock notes are consistent.

The "sellable" flag speaks to a feature that has not been implement yet - namely the ability to sell stock.
Currently there is the concept of a "PurchaseOrder" for buying parts. But not yet a "SalesOrder" for selling them.
I hope to implement this soon but there's a lot of extra complications because you now need to keep track of which stock items are at which customer, etc, etc...

Ah, understood.  I figured it was a future feature.
One thought regarding a stop-gap solution.  Perhaps a simple SalesOrder page that just has optional input fields for customer name (no retention like Suppliers) and invoice number, and a drop down to allow you to choose a Part/StockItem.  Confirming the SalesOrder would perform a stock out and place the customer name and invoice number in the stock out notes.  This would give a way to keep consistent records, and the customer name and invoice number would still be searchable.
I can see the value of a more fleshed out SalesOrder process, but my guess is that most people would be relying on their accounting software for invoices and customer info, and would use InvenTree just to keep the link of invoice number to batch or serial number.


the thread of commons-pool-evictor-thread can't quit normally

Expected behavior
The program can quit jvm after main thread finished.
Actual behavior
The thread of commons-pool-evictor-thread which is started by jedis will not quit after the main thread finished.that is a bug,I think.
Steps to reproduce:
1.I try the version 2.6.1 and 2.8.1,the program is OK.
2.I try run my program with the config of  TimeBetweenEvictionRunsMillis = -1 , it is OK.
3.When I run my program with the jedis version of 2.9.1 or 3.0.1 with  the config of  TimeBetweenEvictionRunsMillis <> -1 ,the problem happen.
Redis / Jedis Configuration
TimeBetweenEvictionRunsMillis = 3000
Jedis version:
above  the version 2.9.1
Redis version:
any version
Java version:
all version of jdk
My code
`public class Test {
public static void main(String[] args) {
ICacheClient client = null;
try {
client = new RedisClient();
client.setnx("name", "mmmmmmmmmmmmmmmmm");
} finally {
if (client != null)
client.release();
}
System.out.println("end..........................");

}
}`

metoo

@cyxinda It's difficult to address any issue outside Jedis. ICacheClient, RedisClient don't come from Jedis.


CSP-412 Create solution structure

Basic project structure added.
Default home page:

Closing as pipeline not linking to PR as it was created before PR existed. Raising an identical PR on same branch


error when finetune gemma2-2b when Running Evaluation

File "torch/_dynamo/variables/constant.py", line 176, in call_method
return ConstantVariable.create(op(self.value, add_target))
torch._dynamo.exc.InternalTorchDynamoError: 'bool' object is not subscriptable
from user code:
File "unsloth/kernels/flex_attention.py", line 73, in slow_attention_softcapping
A += causal_mask[:q_len, :q_len]
Set TORCH_LOGS="+dynamo" and TORCHDYNAMO_VERBOSE=1 for more information

I check my flash_attn=2.6.3, I got this error when Running Evaluation

Oh try uninstalling Unsloth and reinstalling (hopefully that'll fix it!)

I have this issue as well when using DPOTrainer with unsloth/gemma-2-9b-it-bnb-4bit. I have reinstalled Unsloth along with all dependencies.

Will check again apologies!

I think I fixed it!

Hello. After completely reinstalling everything with the latest commit, I can confirm that the error no longer occurs. Interestingly, this also resolved a non-breaking issue I had where the state of each step was missing during training (the dataframe-like state report after each step). Thank you for such an instant fix!
Now my only problem is that I can't test the model evaluation due to CUDA Out of Memory (OOM) errors. I have tried both unsloth/gemma-2-2b-bnb-4bit and unsloth/gemma-2-9b-it-bnb-4bit. I'm on Windows with WSL, running the code with ipynb in VS Code, and my GPU is an RTX 4090. Do you any suggestions I can try?
Thanks

Hello. After completely reinstalling everything with the latest commit, I can confirm that the error no longer occurs. Interestingly, this also resolved a non-breaking issue I had where the state of each step was missing during training (the dataframe-like state report after each step). Thank you for such an instant fix!
Now my only problem is that I can't test the model evaluation due to CUDA Out of Memory (OOM) errors. I have tried both unsloth/gemma-2-2b-bnb-4bit and unsloth/gemma-2-9b-it-bnb-4bit. I'm on Windows with WSL, running the code with ipynb in VS Code, and my GPU is an RTX 4090. Do you any suggestions I can try?
Thanks

I just realized there's a per_device_eval_batch_size parameter. After setting it to 1, I no longer encountered OOM errors. Model evaluation ran smoothly until the end of training.

Oh great you solved it :)

I still receive the same error when installing from source with pip install "unsloth[colab-new] @ git+https://github.com/unslothai/unsloth.git". I'm on Python 3.10, using torch==2.3, xformers<0.0.27, trl<0.9.0 using the Gemma 2b fine-tuning demo notebook.

Having this problem as well

I am experiencing the same error. I am using the 'unsloth/gemma-2-9b-it-bnb-4bit' model with CUDA 11.8 and Torch 2.2.0. For Unsloth, I used the following installation command:
pip install "unsloth[cu118-ampere-torch220] @ git+https://github.com/unslothai/unsloth.git"
The error I am encountering is:
torch._dynamo.exc.TorchRuntimeError: Failed running call_function ((FakeTensor(..., device='cuda:0', size=(1, s2s3, s10, s10), dtype=torch.bfloat16), FakeTensor(..., device='cuda:0', size=(s9, 1, s10, s10), dtype=torch.bfloat16)), **{}):
output with shape torch.Size([1, s2s3, s10, s10]) doesn't match the broadcast shape (s9, s2s3, s10, s10)
from user code:
File "/home/ksj/.pyenv/versions/3.11.8/lib/python3.11/site-packages/unsloth/kernels/flex_attention.py", line 73, in slow_attention_softcapping
A += causal_mask[:q_len, :q_len]
If anyone has encountered and resolved this issue, I would greatly appreciate it if you could share how you resolved it.

Wait @gsarti @ivsanro1 @kimseungju-00 Could you all try uninstall Unsloth then installing it again:
pip uninstall unsloth -y
pip install --upgrade --no-cache-dir "unsloth[colab-new] @ git+https://github.com/unslothai/unsloth.git"

Encountering this same problem with the unsloth/gemma-2-9b-bnb-4bit model, with torch 2.3.0 and CUDA 12.1. I tried this but didn't solve it:

Wait @gsarti @ivsanro1 @kimseungju-00 Could you all try uninstall Unsloth then installing it again:
pip uninstall unsloth -y
pip install --upgrade --no-cache-dir "unsloth[colab-new] @ git+https://github.com/unslothai/unsloth.git"

The problem is likely due to _ignore_causal_mask_sdpa returning False (called by _prepare_4d_causal_attention_mask_for_sdpa), when the sequence length is longer than the sliding window size 4096, causing attention_mask to be not None.
The latter function is called in LlamaModel_fast_forward, and the decoder_layer takes a non-None attention_mask.
In Gemma2Attention_fast_forward, this causes slow_attention_softcapping to be used rather than flash attention. However, slow_attention_softcapping somehow does not take attention_mask (which might be incorrect?). Instead, it takes causal_mask. caucal_mask is always a bool, but in the implementation of slow_attention_softcapping it attempts to slice this variable, hence causing the error. Turning on/off dynamo does not solve the problem, as dynamo only makes the error message more complicated, but the underlying reason is that causal_mask is actually not a mask but a bool.
To solve this problem, slow_attention_softcapping needs to take attention_mask rather than causal_mask. My code works after this change. I believe the slow_attention_softcapping function only needs attention_mask but not causal_mask, as Gemma uses sliding window attention and is not entirely causal when the sequence length is longer than the sliding window size.
@danielhanchen Could you confirm my analysis? If this is correct I can make a PR. Happy to contribute to the project. Thanks.

I solved it by upgrading to version 2024.9

@danielhanchen , hello smart boy, I encountered a similar error while training the SFT gemma2-9B-it model:

The process worked with other models but got stuck with gemma2-9B-it. I am running on CUDA 12.2.
Training initially progresses, logging results for a few steps, but then it raises this error.
My hardware setup includes an NVIDIA A100-PCIE-40GB GPU, Driver Version 535.183.01, and CUDA Version 12.2."

@TonyLianLong Oh wait did I miss this after nearly 2 months?!! Yikes extreme apologies and thanks @vincent-amchrus for bringing the issue again to my attention - I'm unsure if @TonyLianLong still remembers the exact - but if you're interested in a PR, that'll be awesome :))

@TonyLianLong Oh wait did I miss this after nearly 2 months?!! Yikes extreme apologies and thanks @vincent-amchrus for bringing the issue again to my attention - I'm unsure if @TonyLianLong still remembers the exact - but if you're interested in a PR, that'll be awesome :))

Ran into the same error just now, finetuned mistral-nemo just fine, however unsloth/gemma-2-9b-bnb-4bit results in TorchRunTimeError:
File "/opt/miniconda3/envs/unsloth_env/lib/python3.11/site-packages/unsloth/kernels/flex_attention.py", line 67, in slow_attention_softcapping
A += causal_mask[:q_len, :q_len]
Set TORCH_LOGS="+dynamo" and TORCHDYNAMO_VERBOSE=1 for more information

@danielhanchen , hello smart boy, I encountered a similar error while training SFT gemma2-9B-it model:
* The process worked with other models but got stuck with gemma2-9B-it. I am running on CUDA 12.2.

* Training initially progresses, logging results for a few steps, but then it raises this error.

* My hardware setup includes an NVIDIA A100-PCIE-40GB GPU, Driver Version 535.183.01, and CUDA Version 12.2."

Did you manage to solve the problem?

@Erland366 Another issue on running evaluation with Gemma-2 2b and it breaks - it seems like it's a causal mask issue but I'm uncertain

Hi!
I am also running into the same issue, my CUDA version is 12.4.
My pip installs were as follows (compatible with this CUDA version):
!pip install "unsloth[cu124-torch250] @ git+https://github.com/unslothai/unsloth.git"
!pip install torch==2.4.1 torchvision==0.19.1
!pip install --upgrade xformers==0.0.28.post1

The trainer runs perfectly for 1 epoch, but as soon as the second epoch finetuning starts, i run into this issue:

What is the suggested fix for the same ? A prompt response would be highly appreciated. Thanks!

Hi! I am also running into the same issue, my CUDA version is 12.4. My pip installs were as follows (compatible with this CUDA version):
!pip install "unsloth[cu124-torch250] @ git+https://github.com/unslothai/unsloth.git"
!pip install torch==2.4.1 torchvision==0.19.1
!pip install --upgrade xformers==0.0.28.post1

The trainer runs perfectly for 1 epoch, but as soon as the second epoch finetuning starts, i run into this issue:
What is the suggested fix for the same ? A prompt response would be highly appreciated. Thanks!
Tagging @danielhanchen

Update @danielhanchen : The same error is encountered even with the version update fix mentioned somewhere above:
pip uninstall unsloth -y
pip install --upgrade --no-cache-dir "unsloth[colab-new] @ git+https://github.com/unslothai/unsloth.git"

@schlechter-afk
I also tried experimenting with different versions, but the error you mentioned kept appearing. I hope this error is resolved quickly.

Can we like somehow reopen this issue?Because currently this one marked as fixed.

@schlechter-afk @Ilia-Trof88 @daegonYu
Extreme apologies on the issue - weird I tried Gemma-2 9b in Colab for 3 epochs with evaluation and it works fine on a T4 and L4 - I even tried Torch 2.4 on Runpod - would it be possible for you guys to share a notebook / the full error trace, torch version, Unsloth version etc

I'll try my best to fix it, but I just can't seem to reproduce it :(

ACTUALLY I can reproduce it!!! Extreme apologies. It's failing for evaluation on Gemma when NOT using flash-attn

Just fixed it in nightly!! @schlechter-afk @Ilia-Trof88 @daegonYu Again sorry on the issue!

Please try it again - so sorry I thought this wasn't an issue but it was! Try the nightly branch via pip uninstall unsloth -y && pip install --upgrade --no-cache-dir "unsloth[colab-new] @ git+https://github.com/unslothai/unsloth.git"

Likewise apologies a lot on the issue - ccing @zfflxx @Simplegram @gsarti @kimseungju-00 @ChrisSpraaklab @TonyLianLong @vincent-amchrus - it'll be cool if you guys could confirm it works if you guys have time - again apologies didn't expect the issue until I tried it out myself! pip uninstall unsloth -y && pip install --upgrade --no-cache-dir --no-deps "unsloth[colab-new] @ git+https://github.com/unslothai/unsloth.git@nightly" for local machines

Thanks a lot for a quick response, but now when I try to import unsloth or/and pytorch I ran into import error:

Likewise apologies a lot on the issue - ccing @zfflxx @Simplegram @gsarti @kimseungju-00 @ChrisSpraaklab @TonyLianLong @vincent-amchrus - it'll be cool if you guys could confirm it works if you guys have time - again apologies didn't expect the issue until I tried it out myself! pip uninstall unsloth -y && pip install --upgrade --no-cache-dir --no-deps "unsloth[colab-new] @ git+https://github.com/unslothai/unsloth.git@nightly" for local machines

After fixing my dependencies issues I can confirm, that from my end finetuning process continues after evaluation. Thanks a lot, Sir!

Likewise apologies a lot on the issue - ccing @zfflxx @Simplegram @gsarti @kimseungju-00 @ChrisSpraaklab @TonyLianLong @vincent-amchrus - it'll be cool if you guys could confirm it works if you guys have time - again apologies didn't expect the issue until I tried it out myself! pip uninstall unsloth -y && pip install --upgrade --no-cache-dir --no-deps "unsloth[colab-new] @ git+https://github.com/unslothai/unsloth.git@nightly" for local machines

It worked, @danielhanchen! I still encountered some import errors after trying reinstall as u mentioned, so I removed the conda env containing the old version of unsloth, create new conda env, and reinstall unsloth. Now it seems to work well!
I see some Reddit guys tell that u're too sweet for a math and coding genius, and today I can absolutely confirm it! Thank you for patiently answering questions, apologizing for bugs, engaging in conversation, and helping others!


generated-index-page cards show MD comments

Have you read the Contributing Guidelines on issues?

[X] I have read the Contributing Guidelines on issues.

Prerequisites

[X] I'm using the latest version of Docusaurus.
[X] I have tried the npm run clear or yarn clear command.
[X] I have tried rm -rf node_modules yarn.lock package-lock.json and re-installing packages.
[ ] I have tried creating a repro with https://new.docusaurus.io.
[ ] I have read the console error message carefully (if applicable).

Description
The sidebar item of type generated-index-page created cards that automatically show the first line's 46ish characters of each given docs pages.
The issue is that we display the first line, even when it's a comment leading to the following output:

Reproducible demo
No response
Steps to reproduce

Create MD file with a title, and make the first content line as a comment:---
title: Hey
---

<!-- my comment -->

My first line. Real line.

Use this page in a generated-index-page items list.{
  type: 'category',
  label: 'Test category',
  link: {
     type: 'generated-index',
     title: 'Test title',
     description:
       "Test",
      },
  items: [
    'myTestPage',
  ],
},

Expected behavior
Display the first line that is not an MDX import statement or HTML comment.
Actual behavior
Displays the first line that is not a MDX import statement.
Your environment

Public source code:
Public site URL:
Docusaurus version used: <IP_ADDRESS>
Environment name and version (e.g. Chrome 89, Node.js 16.4):
Operating system and version (e.g. Ubuntu 20.04.2 LTS):

Self-service

[ ] I'd be willing to fix this bug myself.

Duplicate of #6108

This is because the generated cards use the description metadata. You can use the description front matter to assign a custom description text.


cannot compile mod

why do we even have to compile it ourself, is there no normal download?
first i tired to run "gradlew setupCIWorkspace" which worked and was done after 20 sec. then i ran "gradlew build" which almost instantly failed. https://pastebin.com/ZqhLPAH1

Try to clone project via Git instead of downloading a .zip or init Git in a directory.

Normal downloads located here: https://discord.gg/gBUm6Z

and that with git means what?

 CMD?

You need to install Git first. And probably yes, in CMD. I'm using Ubuntu so I'm not sure.

Try --clone

same error.
is there some one time thing i have to run before i can do this?

@ProxyPlayerHD here: http://www.mediafire.com/file/i7mg0kzjyf6q29m/CubicChunks-1.12.2-0.0.881.0-SNAPSHOT-all.jar

git clone https://github.com/OpenCubicChunks/CubicChunks.git. Or just join our discord for all the download links you may ever want.

Apparently Windows version of git uses another set of command. I can't help you.

alright thanks
i never used discord so i tried this way

And the real reason it failed is that you don't have JDK installed, only JRE.

dammit, such a simple mistake


[PE-D][Tester C] Unexpected invalid VRN, maybe documentation bug

As you guys can see, my VRN correctly follows the format given in both the glossary and message error. However,
it seems to be invalid. Maybe I didn't read the documentation clearly?

Labels: type.FeatureFlaw severity.High
original: blackpanther9229/ped#3

Invalid VRN used.


Add -Calculate to Open-ExcelPackage and Import-Excel

I am using this package mainly to read and process existing spreadsheets.  I read spreadsheets and use the results from cells with formulas in them.
Today this does not work with just Import-Excel or Open-ExcelPackage.  You must Open-ExcelPackage, Close-ExcelPackage with the -Calculate parameter and than once again Open-ExcelPackage.
Can we add -Calculate parameter to both Import-Excel and Open-ExcelPackage to avoid the additional steps?

Add
[OfficeOpenXml.CalculationExtension]::Calculate($worksheet)
Before Close-ExcelPackage


Fix: Fixed cloud icon for OneDrive work accounts

Resolved / Related Issues

[x] Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
Closes #8313...

Validation
How did you test these changes?

[x] Did you build the app and test your changes?
[ ] Did you check for accessibility? You can use Accessibility Insights for this.
[ ] Did you remove any strings from the en-us resource file?

[ ] Did you search the solution to see if the string is still being used?

[ ] Did you implement any design changes to an existing feature?

[ ] Was this change approved?

[ ] Are there any other steps that were used to validate these changes?

Confirm the sidebar displays the OneDrive icon for OneDrive work accounts

Screenshots (optional)
Add screenshots here.

@Lukiluc29 fyi

Thank you, I didn't think it would fix the issue, but in the end it did.

The icon in the sidebar updated successfully, but not in the preview pane.

At the end of the day, the folder icon is the correct icon as that's what's provided by Windows (I imagine File Explorer does the same). I applied custom logic in the sidebar so that it doesn't look out of place next to the regular OneDrive item.

This doesn't solve the issue because my OneDrive, which previously didn't have an icon in the sidebar, now has one, but still not in the preview pane. It displays as a regular folder there, whereas the other one, where the icon was correctly displayed in the sidebar, also appears correctly in the preview pane.

As mentioned above, the icon in the preview pane is the actual icon provided by File Explorer. We made an exception to override the real icon in the left-hand sidebar, but this is indeed the expected behavior.

Where can this problem come from? In my file explorer it shows me the OneDrive icon.

It's possible they have custom behavior for the preview pane as well, as of now we don't plan to do this but it's not impossible that we'll do this at some point.

Finally, by completely uninstalling OneDrive, everything went back to normal.


⚠ Community has degraded performance

In 5d1fcb5, Community (https://community.wrk.com/health) experienced degraded performance:

HTTP code: 200
Response time: 204 ms

Resolved: Community performance has improved in 31c8d54.


Coinacceptor client device implementation.

Here comes the Coin Acceptor client device implementation.
Also bundles some general changes to existing APIs:

Replaced serial with serialport library and also reworked the SerialClient / CCTalkDevice inititalizations a bit.
Adds simple cctalk-host and coinacceptor examples. Nothing fancy for now, but at least shows how to use them :)
Also comes with tests (for coin acceptor client device). These are still hacky and could be simplified, but at least work.

Future TODO list:

Make the CoinAcceptor embeddable in multi-threaded application (our initial approach is will be probably event polling using mpsc. Basically we have to listen for master inhibit and send out coin in events).

And some ideas that are currently out of scope, but worth thinking about:

It would be also nice to drop the current hard dependency on serialport and instead refactor the whole serialport to use generic interface types....
...which would be a first step towards eventual no-std support (yay for rust-embedded).

Let me know if you need a Crates.io release


Default error handler does not return a 5xx on UncheckedIOException

Environment Details

Helidon Version: 4.1.0
Helidon SE
JDK version: 21.0.3
OS: macOS
Docker version (if applicable): N/A

Problem Description
When a request handler throws an UncheckedIOException (such as when the handler uses a WebClient to call another service that isn't currently running resulting in a ConnectException wrapped in an UncheckedIOException) I expect the Helidon default error handler to return a 500 HTTP error. Instead the web server return nothing.
The cause is io.helidon.webserver.http.ErrorHandlers.runWithErrorHandling line 80 that catches and re-throws UncheckedIOException (and CloseConnectionException), with a comment saying 'these errors must "bubble up"'.
Maybe if the response is "broken" so returning an HTTP 500 can't work then an exception needs to bubble up. Perhaps the code assumes that these 2 exception categories (UncheckedIOException and CloseConnectionException) are due to the response. But that is not always correct, particularly since the Helidon WebClient throws those and lots of microservices call other microservices.
Steps to reproduce

helidon init -- the defaults
Add a path to the routing (and import java.io.*): .get("/throw", (req, res) -> { throw new UncheckedIOException(new IOException("ugh")); })
mvn package
java -jar target/quickstart-se.jar
`curl -vi http://localhost:8080/throw

Expect HTTP/1.1 500 Internal Server Error but don't get anything.

There are a few exception that you cannot throw from your code, and UncheckedIOException is one of them.
We need this exception to "bubble" through, as this is the only way how we identify issues where (for example) the client closed the connection, and we failed to write a response.
You can use checked exception in Helidon routing, so you can throw IOException.

Treating every UncheckedIOException as if it is about the incoming request/response is a poor assumption. Plenty of other I/O can occur when handling a request. One microservice calling another or calling a database is really common -- and code for that also throws the quite-generic UncheckedIOException. Helidon's WebClient throws UncheckedIOException. Having to wrap all those potential sources with try-catch blocks to re-package UncheckedIOExceptions is painful, will be error-prone, defeats the purpose of the "Unchecked" part, and forces a surprising (and undocumented) rule on every handler (don't throw UncheckedIOException if its not about the response connection).
Perhaps Helidon could use it's own special exception to signal response connection problems to error handling routing?

I will update this as you  proposed - using a custom exception. Will require some time, as it impacts quite a lot of code. Also I need to try to make this backward compatible...

Thanks a lot for the prompt response and good solution.


Safari 12.0 (MacOS Mojave) throws Origin errors for doi.org

MacOS Mojave 10.14.0 and Safari 12.0
Start a submission (both test and demo) and type 'abc' in the DOI field.  This throws the following errors in the Developer Console:
[Error] Unhandled Promise Rejection: Error: No DOI present
	(anonymous function) (pass-ember-802a920e0c70a4619f2d0bb97461e494.js:90:85)
	promiseReactionJob
[Error] Failed to load resource: the server responded with a status of 404 () (a, line 0)
[Error] Unhandled Promise Rejection: Error
	(anonymous function) (pass-ember-802a920e0c70a4619f2d0bb97461e494.js:89)
	promiseReactionJob
[Error] Failed to load resource: the server responded with a status of 404 () (ab, line 0)
[Error] Unhandled Promise Rejection: Error
	(anonymous function) (pass-ember-802a920e0c70a4619f2d0bb97461e494.js:89)
	promiseReactionJob
[Error] Cross-origin redirection to https://doi.org/10.1038/NATURE09091 denied by Cross-Origin Resource Sharing policy: Origin https://demo.pass.library.jhu.edu is not allowed by Access-Control-Allow-Origin.
[Error] Fetch API cannot load https://doi.org/abc due to access control checks.
[Error] Failed to load resource: Cross-origin redirection to https://doi.org/10.1038/NATURE09091 denied by Cross-Origin Resource Sharing policy: Origin https://demo.pass.library.jhu.edu is not allowed by Access-Control-Allow-Origin. (abc, line 0)
[Error] Unhandled Promise Rejection: TypeError: Cross-origin redirection to https://doi.org/10.1038/NATURE09091 denied by Cross-Origin Resource Sharing policy: Origin https://demo.pass.library.jhu.edu is not allowed by Access-Control-Allow-Origin.
	(anonymous function)
	promiseReactionJob
[Error] Cross-origin redirection to https://doi.org/10.1038/NATURE09091 denied by Cross-Origin Resource Sharing policy: Origin https://demo.pass.library.jhu.edu is not allowed by Access-Control-Allow-Origin.
[Error] Fetch API cannot load https://doi.org/abc due to access control checks.
[Error] Failed to load resource: Cross-origin redirection to https://doi.org/10.1038/NATURE09091 denied by Cross-Origin Resource Sharing policy: Origin https://demo.pass.library.jhu.edu is not allowed by Access-Control-Allow-Origin. (abc, line 0)
[Error] Unhandled Promise Rejection: TypeError: Cross-origin redirection to https://doi.org/10.1038/NATURE09091 denied by Cross-Origin Resource Sharing policy: Origin https://demo.pass.library.jhu.edu is not allowed by Access-Control-Allow-Origin.
	(anonymous function)
	promiseReactionJob
[Error] Cross-origin redirection to https://doi.org/10.1038/NATURE09091 denied by Cross-Origin Resource Sharing policy: Origin https://demo.pass.library.jhu.edu is not allowed by Access-Control-Allow-Origin.
[Error] Fetch API cannot load https://doi.org/abc due to access control checks.
[Error] Failed to load resource: Cross-origin redirection to https://doi.org/10.1038/NATURE09091 denied by Cross-Origin Resource Sharing policy: Origin https://demo.pass.library.jhu.edu is not allowed by Access-Control-Allow-Origin. (abc, line 0)
[Error] Unhandled Promise Rejection: TypeError: Cross-origin redirection to https://doi.org/10.1038/NATURE09091 denied by Cross-Origin Resource Sharing policy: Origin https://demo.pass.library.jhu.edu is not allowed by Access-Control-Allow-Origin.
	(anonymous function)
	promiseReactionJob

Updating to Mojave 10.14.1 and Safari 12.0.1 did not fix this.
I cannot recreate this problem in Firefox.  But this does break PASS for Safari users.

This happens under Production as well.

For completeness, here's the Apache configuration for the reverse proxy that shows we are not limiting CORS:
    Header set Access-Control-Allow-Origin "*"
    # allow cookies to be sent cross origin
    Header set Access-Control-Allow-Credentials "true"
    Header merge Access-Control-Allow-Methods "PUT, OPTIONS"
    Header merge Access-Control-Expose-Headers "authorization"

I bet its an issue with allowed headers. Check all the headers on the request in Safari and see if there are in the allowed headers.

I cannot reproduce this issue at work.  I may need to investigate more at home.

This cannot be reproduced, closing.


+ContinuousBeziersIterator. May need some more refactoring.

This is for MFEK/kurbo.rlib#1 and linebender/kurbo#230.
Sorry for the long delay on this @raphlinus. Because your code did not handle discontinuous splines, I had to add support here first for iterating over only the continuous Beziers of a Piecewise Bezier path.

Ultimately I think it might be best to split this out of math.rlib and make a new Rust project out of the code, similar to cucoqu.rlib. Called something like discontinue.rlib. Basically, I'd create a crate that'll hard depend on kurbo, and then I'd define the same types as here.
The reason I think it might be best to do it that way is that this is yet more GPT-3 aided code.
I'm simply just not talented enough at this kind of thing to come up with stuff like:
         match G {
            // G^0 continuity
            // The two Bezier splines are connected if the end point of the first Bezier spline
            // equals the start point of the second Bezier spline.
            0 => xdist!() && ydist!(),
            // G^1 continuity
            // The two Bezier splines are connected if the end point of the first Bezier spline
            // equals the start point of the second Bezier spline and the tangent at the end point
            // equals the tangent at the start point.
            1 => xdist!() && ydist!() && taneq!(),
            // G^2 continuity
            // The two Bezier splines are connected if the end point of the first Bezier spline
            // equals the start point of the second Bezier spline and the tangent at the end point
            // equals the tangent at the start point and the second derivative at the end point
            // equals the second derivative at the start point.
            2 => xdist!() && ydist!() && taneq!() && crveq!(),
            const_order => {
                panic!("G continuity of order {} not supported.", const_order);
            }
        }

My policy on this is here: https://github.com/MFEK/cucoqu.rlib/blob/main/GPT-3 (English).md
I might need to email Dr. Stallman or someone else at the FSF for guidance on this matter, as GPT-3 is becoming more and more important to my workflow.

Moving to own lib.


Awaken download to RAM, FLASH

Issue being Addressed
The first release had removed this capability until I could figure out how to package the USB support.  Now that I know, let's get this built as intended
Enhancement
add back in the -r -and -f options to download the compiled image to the P2 and awaken the USB Serial port/Propplug access
Alternatives
No response
Additional information
No response

Watch for this to appear in next minor update!


Feature Request:  Add GA  code to docs

Is your feature request related to a problem? Please describe.
Now we can't monitor page views and event for wasmedge.org/docs. We need to add this freature.
Describe the solution you'd like.
It seems that we need to install a plugin to enable this feature. https://github.com/facebook/docusaurus/issues/7221
Describe alternatives you've considered
No response
Additional context.
No response

Hi  @adithyaakrishna
Can you please check this out? Thanks.

#169 fixed this problem.


feat(protocol-designer): add hover background to well order

Overview
This PR adds a gray hover background to the well order image/mixed text.
Note, the well order zig zag image will now also have a hover background in single edit mode.
Closes #7456
Review requests
See ticket, oh and also I am not good at css so if I'm doing something dumb plz tell me 🙃
Risk assessment
Low

I copied the alpha from components/src/buttons/buttons.css since it uses the same style. i wonder if i should just get rid of it tho?


MutableObjectModelBinder should avoid using PropertyInfo.SetValue to set property values

We should use cached delegates created using PropertyHelper.MakeFastPropertySetters to set property values instead. Note: We create these delegates as part of creating DefaultMetadataDetailsCache for property entries today.

@Eilon @danroth27 this is something we wanted to do in a follow up to the MMP changes and didn't quite get to yet. There's a few more places to cleanup also beyond the setter in modelbinding.


refactor: ci docker build publish

For aesthetics (bit less YAML) and maintenance (use more defaults), this uses the Docker publish orb's job instead of commands in a custom job.
Also found an orb that seems more official and supports a tag on push.

PR Storybook available here


fix(apig):  adding Default Method Options to LambdaRestApi

Coverage Report

Totals

Statements:
96.35% ( 4192 / 4351 )

Methods:
93.08% ( 148 / 159 )

Codecov Report

Merging #19 (3112b98) into main (2ace17d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #19   +/-   ##
=======================================
  Coverage   96.34%   96.34%
=======================================
  Files          26       26
  Lines        4350     4351    +1
  Branches      290      290
=======================================
+ Hits         4191     4192    +1
  Misses        159      159

Impacted Files
Coverage Δ

src/lib/manager/aws/apiManager.ts
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ace17d...3112b98. Read the comment docs.


Works on Raspberry Pi 2 with OpenElec and Kodi 14.1 and 14.2b

Hi --
I just wanted to mention that the script works fine (I had to manually set the bridge IP and create a user through the Hue API myself though) on my Raspberry PI 2 running OpenElec (Kodi 14.1 and 14.2 beta). I'm using 2 Philips Bloom Hue lights.

Yes, works also here with RPi2 and Ambilight mode... Maybe change the readmethat RPi2 is supported...


Spec: Increase the MAX_EFFECTIVE_BALANCE

Problem description
Track update and implementation of https://ethresear.ch/t/increase-the-max-effective-balance-a-modest-proposal/15801 a proposal to allow network participants to consolidate state and reduce the number of active indexes
Progress tracker
Active incomplete implementation here https://github.com/ChainSafe/lodestar/compare/dapplion/maxeb?expand=1

Reopen when spec is final


Upgrade Guzzle to 7.0.1

Laravel Framework requires Guzzle 7.0.1. Can we allow upgrade on this Repo?

I'm not sure if that would break anything? What does the upgrade process look like for Guzzle?

IIUC, upgrading guzzle has to be done on the openapi-generator side, also making sure generators are not using any removed classes or methods, etc.
I'd call dropping php5 support a major change, but I see hydra client already setting php 7.2 as minimal supported version, so that shouldn't be an issue.
While I'm eager do move to guzzle7 myself, I'd say this is a wontfix for this particular package until the 'upstream' tooling does the upgrade.

Agreed!


Test for asana link on task creation

Test for #54
Asana Tasks:
#44725863208403

Success! :beers:


feat: avoid uncessary body margin

The change also separates custom styles into a css file.

Thanks, @changkun


Added workspace Id tracking

This PR adds workspace_id tracking for Receive and Send events.

I was going to add support for fetching the workspace id to all of the ProjectResource queries, like I've done for the v3 sdk https://github.com/specklesystems/speckle-sharp-sdk/pull/134
But, since its important that the v2 SDK is compatible with older self hosted servers, I thought it would be easiest simply to
add a helper function just for this query. This avoids having to add  a version check in each of the Project resources (which, at least right now in their current form don't have direct access to the underlying GqlClient.

Needs through testing:

Test with app.speckle.systems:

[x]  project on a workspace, does it track send and receives in mixpanel
[x] project not on a workspace, should track null

Test with testing1

[x] project not on a workspace, should track null, nothing should throw!

note: didn't test locally, just sanity check glanced at the code!


Improve dim transform repr and add further operators

This PR improves the repr of dim transform to ensure it is in most cases fully usable. It also adds support for further operators and numpy functions.
Here's a mixture of unary operators (-), binary operators (* and +), numpy ufuncs (np.log), and ndarray methods (min):
> np.log(-dim('A')*3+3).min()

np.log((-dim('A')*3)+3)).min()

And here's an example using one of some of the custom functions (norm and categorize):
> (dim('y').norm()>0.5).categorize({False: 'red', True: 'blue'})

(dim('y').norm()>0.5).categorize(categories={False: 'red', True: 'blue'}, empty=None)

@jlstevens Ready to review and merge.

Looks good! This will be very helpful for my helper script that uses the parser to suggest was of removing the magics (the old reprs where invalid/confusing).
Happy to merge though is there an option to avoid qualifying the namespace? I'm happy with the default but let's say someone used import numpy a lot instead of import numpy as np or used from numpy import *. I made a suggestion above as how this could be done in the code...

Ready to merge.


Computes the KL penalty using the entire distribution

I got so fed up with negative KL that I have added an option to calculate the KL for the entire distribution.
It is memory intensive for large sequences with an allocation of 8*vocab_size per token, but it should stabilize training and cannot be negative! Memory usage could be greatly reduced but would require a larger refactor.
Single seed runs for gpt2-sentiment:

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


upgrading node and npm

This is needed for a security patch https://nodejs.org/en/blog/vulnerability/july-2017-security-releases/

@samageloff please review

🌴


Query enable by rule

Only allows for query operations to be performed on rules that have query enabled. If not enabled the query operation is just plainly ignored. Also if a user configures a rule with querying without a backend query provider it will error.

Relies upon https://github.com/gingersnap-project/cache-manager/pull/18

Here is an idea: https://github.com/gingersnap-project/cache-manager/commit/e385d58840e291fcbb45841e4b88f0e7d2f95cad

Here is an idea: e385d58

Nice, yes this is precisely what I was thinking, but didn't get time to get it. Thanks!

Here is an idea: e385d58

Nice, yes this is precisely what I was thinking, but didn't get time to get it. Thanks!

Added your commit to my PR.

I need to revamp the tests a bit now, since it is not using the proper rule any longer and causes test failures.

Merged, thanks @wburns!


Background is too intense and poor contrast

Suggested new feature or improvement
The background should be using Mica (as opposed to Mica Alt). The easiest way to do this is with the built in MicaBackdrop API in Windows App SDK 1.3 instead of the WinUIEx MicaSystemBackdrop, which seems to have problematic defaults.
Scenario
The current background has poor contrast, especially with some wallpapers in light mode.

Screenshot from @Pdawg-bytes
This easily fails accessibility standards in light mode and is too intense in dark mode as well.
Additional details
It looks like the WinUIEx MicaSystemBackdrop is not necessarily using the right values. Since MicaBackdrop was recently added to WinUI itself, there is no reason to use the WinUIEx API anymore.

The attached image might have been a bug on a specific Windows build. Even still, the background is not consistent with other Mica apps on Windows.


Desktop Safari - No Sound When Empty Cache

Hi!
Has anyone else noticed in Safari 9.0.2, Yosemite 10.10.5 that sound with an empty browser cache does not play until you refresh the browser.  Sound plays properly after refresh.
The sound plays through as I have actions on sound complete that fire.
Tried with mousedown or when playing sound on game load.  Phaser 2.4.4
We have 4 games that seem to be doing this via 4 different programmers.

Sorry, it was a server issue.  Moved the game to a different server and it seemed to fix the issue.  Now to determine what that issue was.


Could h265ize print actual ffmpeg commands for offline usage?

Which I think would be useful for helping friends.

Try running latest master with debug option.

Thank you author!


Updating MieleCloudService to v1.2.1 in stable repo

RE-CHECK!

Automated adapter checker
ioBroker.mielecloudservice

[ ] :heavy_exclamation_mark: [E301] Tests on Travis-ci.com are broken. Please fix.

Add comment "RE-CHECK!" to start check anew

@Grizzelbee please remove node 8 from testing


[FEAT]: Automatic Re-indexing of webpages in a workspace?

What would you like to see?
Hi,
If I am querying Google Docs that are published as webpages in a workspace, is there any way that the URL can be re-indexed at timed intervals to account for changes that will be made to the content in these URLs over time?
Thanks!

Yes, via the live document sync. Only manually uploaded documents are not able to be live synced when on Docker, otherwise every file is able to be synced.
https://docs.anythingllm.com/beta-preview/active-features/live-document-sync
https://docs.anythingllm.com/beta-preview/enable-feature

Awesome, thank you!


fix android alert

motivation use alert on android
Test plan (required)
https://github.com/facebook/react-native/blob/master/ReactAndroid/src/main/java/com/facebook/react/modules/dialog/DialogModule.java#L40
UIExplorer or here is an image

fixed here https://github.com/facebook/react-native/commit/72ddfb014a567093dfa17293d1191d8412f8989a


Make sure labels become blue when parent of any level has focus

@StevePole @oliverviljamaa

Why is it necessary?

Transferflow and user app have grey labels on focus because their labels are not direct descendants of the .focus :(

Ok, :+1:


fix: ci image dependencies

Co-Authored-By: Leonardo Di Donato<EMAIL_ADDRESS>Signed-off-by: Lorenzo Fontana<EMAIL_ADDRESS>What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area build
What this PR does / why we need it:
Fixes deps for push docker images.
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
NONE

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign leodido
You can assign the PR to them by writing /assign @leodido in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash: d8061e0ca32e1b5d3556c7a44b3a5e6268714350

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: fntlnz
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [fntlnz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


display Mozillas Obersovatory status

This change adds a badge for Mozilla's Observatory status to display the website's security status discussed in #6.

Sorry, but we do not include any assets loaded from external sources.

By the way, we are not vulnerable to XSS as this is a static website and no authorized requests are made against a backend. So the security rate "D+" is not justified for this setup.

Ups, just realized this badge will be displayed on the GitHub Readme, only, and not on the website itself. So I'll reopen this PR. Still the rating "D+" is not justified and has to be adjusted.

By the way, we are not vulnerable to XSS as this is a static website and no authorized requests are made against a backend. So the security rate "D+" is not justified for this setup.
Just because you're serving a statically rendered website does not mean that X-(Content | Frame | XSS)-Headers (sh | c)ould be skipped. Because endusers do not know in which way the website will receive additions in functionality these headers should be placed either way. So D+ rating is fine at this point.

Well, we already accepted #6 so it was just a question of time and configuration to get this fixed. I would still say they could honor meta tags, but don't need to be nitpicking. Now we proudly show our A+ :)
Mit freundlichen Grüßen/Best regards,
SW
Corona Warn-App Open Source Team


Adds hurry up and grace period features to multiball ball save

Added hurry up and grace period features to the multiball ball save.  This allows the user to run shows off the hurry up, as well as provide a grace period for saves.
The tests for test_Modes are failing when I run bulk, but run fine when I run just them.  So not sure what is going on there.  If you also see this issue, please let me know what I changed or need to do to fix that issue.
If this is approved and merged, I would also like to go add similar features for add_a_ball to provide a different and shorter ball save feature.
Relates to 768 (set shoot_again to 0) and 1132.  The wording is slightly inconsistent with ball_saves, but I didn't want to change it and break users configs.  But might be worth doing (however that works) to ultimately have them be the same verbiage.

Tests fail because of this:
========
mpf/devices/multiball.py
Line: 147
pep257: D202 / No blank lines allowed after function docstring (found 1)

Line: 166
pep8: E128 / continuation line under-indented for visual indent (col 28)

pep8: E128 / continuation line under-indented for visual indent (col 28)

Jan, Thanks!  I know see where those errors are located in Travis_CI, so I can fix them going forward.  So everything passes now, but on my local it still fails the same 7 tests...  Kinda weird.  They all have the exact same stack trace.  I've tried hunting, but can't seem to find it, and obviously is happening on my machine, but not in Travis.  Thanks!
ERROR: test_ball_end (mpf.tests.test_Modes.TestModes)
Traceback (most recent call last):
File "c:\users\atummons\desktop\mpf\mpf\tests\MpfTestCase.py", line 548, in setUp
self._initialise_machine()
File "c:\users\atummons\desktop\mpf\mpf\tests\MpfTestCase.py", line 564, in _initialise_machine
self._wait_for_start(init, 20)
File "c:\users\atummons\desktop\mpf\mpf\tests\MpfTestCase.py", line 576, in _wait_for_start
init.result()
asyncio.base_futures.InvalidStateError: Result is not set.
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "c:\desktop\mpf\mpf\tests\MpfTestCase.py", line 557, in setUp
raise self._exception['exception']
File "C:\AppData\Local\Programs\Python\Python37\lib\asyncio\events.py", line 88, in _run
self._context.run(self._callback, *self._args)
File "c:\desktop\mpf\mpf\core\events.py", line 115, in _async_handler_done
future.result()
File "c:\desktop\mpf\mpf\core\mode_controller.py", line 119, in load_modes
self.machine.modes[mode] = self._load_mode(mode)
File "c:\desktop\mpf\mpf\core\mode_controller.py", line 157, in _load_mode
mode_class = self._load_mode_code(mode_string, config['mode']['code'])
File "c:\desktop\mpf\mpf\core\mode_controller.py", line 135, in _load_mode_code
return Util.string_to_class("modes.{}.code.{}".format(mode_string, code_path))
File "c:\desktop\mpf\mpf\core\utility_functions.py", line 608, in string_to_class
m = import(module)
ModuleNotFoundError: No module named 'modes.mode3'

Jan, Thanks! I know see where those errors are located in Travis_CI, so I can fix them going forward. So everything passes now, but on my local it still fails the same 7 tests... Kinda weird. They all have the exact same stack trace. I've tried hunting, but can't seem to find it, and obviously is happening on my machine, but not in Travis. Thanks!
ERROR: test_ball_end (mpf.tests.test_Modes.TestModes)
Traceback (most recent call last):
File "c:\users\atummons\desktop\mpf\mpf\tests\MpfTestCase.py", line 548, in setUp
self._initialise_machine()
File "c:\users\atummons\desktop\mpf\mpf\tests\MpfTestCase.py", line 564, in _initialise_machine
self._wait_for_start(init, 20)
File "c:\users\atummons\desktop\mpf\mpf\tests\MpfTestCase.py", line 576, in _wait_for_start
init.result()
asyncio.base_futures.InvalidStateError: Result is not set.
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "c:\desktop\mpf\mpf\tests\MpfTestCase.py", line 557, in setUp
raise self._exception['exception']
File "C:\AppData\Local\Programs\Python\Python37\lib\asyncio\events.py", line 88, in _run
self._context.run(self._callback, *self._args)
File "c:\desktop\mpf\mpf\core\events.py", line 115, in _async_handler_done
future.result()
File "c:\desktop\mpf\mpf\core\mode_controller.py", line 119, in load_modes
self.machine.modes[mode] = self._load_mode(mode)
File "c:\desktop\mpf\mpf\core\mode_controller.py", line 157, in _load_mode
mode_class = self._load_mode_code(mode_string, config['mode']['code'])
File "c:\desktop\mpf\mpf\core\mode_controller.py", line 135, in _load_mode_code
return Util.string_to_class("modes.{}.code.{}".format(mode_string, code_path))
File "c:\desktop\mpf\mpf\core\utility_functions.py", line 608, in string_to_class
m = import(module)
ModuleNotFoundError: No module named 'modes.mode3'

Did you run the tests from inside the mpf folder? I think I fixed something similar recently. I think it needed some init.py (which should be optional in python 3 but that seems not to be always true). If CI is happy you at least did not make it worse ;-).


Allow children to be React element

The following PR allows ReduxContainer to contain React elements.
It does not break compatibility.
<Container {...opts} Wrapper={SomeFancyComponent}>
  <CounterRed />
  <CounterBlue />
</Container>

Feedback is welcomed :wink:

What does this buy us over the function form?

With<EMAIL_ADDRESS>and parent-based context we no longer need to be careful with the owner. Using children as a function into Root will be useless. Allowing the same syntax for Container would reinforce code consistency between the 2 components.

Good point about Root in React 0.14.
I think the need for Wrapper is what makes this proposal not very appealing to me. With the function form, we need to teach people once: put a function inside and you'll be fine. With this form, I'd need to consult the docs: why can't I just put two things in there? Where does the extra span come from? Oh wait, so there's Wrapper. But I used a custom component, and now I want to props to my wrapper. How do I do that? I'd need wrapperProps. Or else they'd be magically inferred from props I passed to the <Component>...
Another problem is cloning. I don't see cloning as the right solution. A designer might wrap the insides of <Container> in a <div> to change the layout, and the data no longer comes through because only the immediate children are cloned. Oops! Also, I specify my props with isRequired, but propTypes validation will fail initially because when I create the element, the props are not there yet.
The alternative seems to be more consistent. No edge cases, and a single trick to learn instead of a dozen. These are the reasons I'm inclined to not accept this.

Perfectly legit. It was just a suggestion.

However be sure to drop the function form for Root with 0.14 :wink:

Yep!


OKD 4.7.0-0.okd-2021-06-04-191031: entrypoint not found in $PATH

Describe the bug
Since upgrading to OKD 4.7.0-0.okd-2021-06-04-191031 we are experiencing that sometimes containers won't start because the entrypoint could not be found:
Error: container create failed: time="2021-06-08T13:58:08Z" level=error msg="container_linux.go:380: starting container process caused: exec: \"docker-entrypoint.sh\": executable file not found in $PATH"

Version
OKD 4.7.0-0.okd-2021-06-04-191031 on vSphere IPI
How reproducible
The issue occurs with ~1/4 of containers.
Log bundle
https://docker.ntslabs.net/files/must-gather.local.8916468073005934167.tar.gz

No matching lines for in must-gather, so it seems OKD components are not affected. Looks like its specific to user containers then?

I don't think it's an issue with the images. The same images worked before upgrading to 4.7.0-0.okd-2021-06-04-191031. It happens with images we build our self as well as "official" images like keycloak, elasticsearch and postgresql.

If this is a node issue why we don't see the same behaviour on the images we control, like Prometheus or ingress?

Good point.

This has to be an issue with OKD and/or cri-o. We are getting errors like
Error: container create failed: time="2021-06-09T11:58:07Z" level=error msg="container_linux.go:380: starting container process caused: exec: \"/bin/bash\": stat /bin/bash: no such file or directory"

but it definitely is present:
§ podman run --rm -ti docker.io/bitnami/redis:6.0.8-debian-10-r0 /bin/bash
redis 12:41:36.69
redis 12:41:36.69 Welcome to the Bitnami redis container
redis 12:41:36.69 Subscribe to project updates by watching https://github.com/bitnami/bitnami-docker-redis
redis 12:41:36.69 Submit issues and feature requests at https://github.com/bitnami/bitnami-docker-redis/issues
redis 12:41:36.69

1001@00cfb72eed15:/$ echo $0
/bin/bash
1001@00cfb72eed15:/$

I just can't see anything relevant in the crio logs:
Jun 09 12:46:05 okd-4cq4d-worker-8c5km crio[1593]: time="2021-06-09 12:46:05.439712939Z" level=info msg="Image status: &ImageStatusResponse{Image:&Image{Id:ff5a96d1fba3cdc5e29b3813d6c9574c0ea5e00729306fa8f29d1d4cc1f85c21,RepoTags:[docker.io/bitnami/redis:6.0.8-debian-10-r0],RepoDigests:[docker.io/bitnami/redis@sha256:71cbd4598b84e7f0e2ea2effb822472309064e763d68fbef57b5f1e9265da672],Size_:106744447,Uid:&Int64Value{Value:1001,},Username:,Spec:nil,},Info:map[string]string{},}" id=97f95458-7395-429d-8237-9effc7d148b3 name=/runtime.v1alpha2.ImageService/ImageStatus
Jun 09 12:46:05 okd-4cq4d-worker-8c5km crio[1593]: time="2021-06-09 12:46:05.440914970Z" level=info msg="Creating container: nextcloud/nextcloud-staging-redis-master-0/redis" id=633367e6-9c4f-4364-b9e6-81bd6e68d311 name=/runtime.v1alpha2.RuntimeService/CreateContainer
Jun 09 12:46:05 okd-4cq4d-worker-8c5km crio[1593]: time="2021-06-09 12:46:05.500068787Z" level=warning msg="Failed to open /etc/passwd: open /var/lib/containers/storage/overlay/482caa889e5b0970961880f57087d3ae09cae43ea2e2fdf117e1ac92d1e0f7ec/merged/etc/passwd: no such file or directory"
Jun 09 12:46:05 okd-4cq4d-worker-8c5km crio[1593]: time="2021-06-09 12:46:05.500179893Z" level=warning msg="Failed to open /etc/group: open /var/lib/containers/storage/overlay/482caa889e5b0970961880f57087d3ae09cae43ea2e2fdf117e1ac92d1e0f7ec/merged/etc/group: no such file or directory"
Jun 09 12:46:05 okd-4cq4d-worker-8c5km crio[1593]: time="2021-06-09 12:46:05.606845595Z" level=error msg="Container creation error: time=\"2021-06-09T12:46:05Z\" level=error msg=\"container_linux.go:380: starting container process caused: exec: \\\"/bin/bash\\\": stat /bin/bash: no such file or directory\"\n"

Not an OKD bug, otherwise OKD components would be affected too.
It could be a lot of things wrong with this image - serviceaccount which doesn't have permissions to access /bin/bash, updated SELinux permissions which close some holes previously used by this image etc.
If its a crio bug its needs to be reported to https://github.com/cri-o/cri-o, if its strict selinux rules then its a Fedora 34 bug.
There isn't anything we can fix in OKD directly.


assignment inside if clause

I often use(d) statements like this
if ( $from = any_function() ) {
   // any code
}

But this throws an error:
Assignments must be the first block of code on a line
The following 2 variations would both validate, but especially variation A is ugly
Variation A
if (
   $from = any_function()
   ) {
   // any code
}

Variation B
$from = any_function()
if ( $from ) {
   // any code
}

Is this an error? Or is it desired? I doubt that Variation A (which validates) is the desired solution.

Yes, B is definitely what is intended here. There are also other sniffs that check for assignments within conditions. I get a warning from WordPress.CodeAnalysis.AssignmentInCondition for the initial  example. Putting assignments within conditionals is generally considered bad practice, because it can lead to mistakenly having an assignment instead of a condition (= instead of ==), when a conditional check is actually what is intended.

Phpstorm just showed me the one error and not the second, while example a validated. Might be because I only use the less strict WordPress Core and not WordPress.
But as it is intended I am happy with the answer and change my habit when it comes to expressions alike.


Allows base_uri with path to function

This adds the ability to have drupal in a subdirectory (which is my current scenario)
The path that was being passed, via Milliner, to guzzle was absolute, so any path on the base_uri was then lost.
For example, if I my base path was http://localhost/claw and the drupal node was /node/81, the resulting uri would become http://localhost/node/81 and not resolve.   This fixes that issue by making sure the leading slash is always removed from the drupal entity string.
GitHub Issue: (link)

Other Relevant Links (Google Groups discussion, related pull requests, Release pull requests, etc.)

What does this Pull Request do?
This pull request removes a leading slash from the node path that will be used to talk to drupal with.  This way if the drupal_base_uri has a path on it the node being worked with will still resolve.
This pull request also adds a note to the config file stating that if you are working with a path on the drupal base uri, make sure you put on a trailing slash, or relative paths will not work. (http://docs.guzzlephp.org/en/stable/quickstart.html)
Full disclosure:  This should not affect drupal base uris with no path on them, they should still resolve just fine, but that is something I haven't tested, given my current setup.

I'll add some tests to this PR tomorrow.

Or maybe I'm talking out of my *** as it seems to have passed the code coverage check now.


SVG Renderer misplaces ClosedPath

Hey man, I really like what you've done here and it's cool to see the project alive and kicking. As far as I'm aware this is the best tool for generating Svg out of Scala so I appreciate it!
I'm having an issue with some Svg output.
Given:
val rect = Image.rectangle(200, 200).strokeColor(Color.red)
val rect2 = ClosedPath(List(
  MoveTo(Cartesian(0.0, 0.0)),
  LineTo(Cartesian(200.0, 0.0)),
  LineTo(Cartesian(200.0, 200.0)),
  LineTo(Cartesian(0.0, 200.0)),
  LineTo(Cartesian(0.0, 0.0))
))

val frame = doodle.svg.effect.Frame("svg").fitToPicture(10)
rect.write[Svg]((wd / "rect-200.svg").toString, frame)(svgWriter)
rect2.write[Svg]((wd / "rect2-200.svg").toString, frame)(svgWriter)

The first rect correctly yields a Rect(10, 10, 200, 200) where Rect(x,y,w,h) on a canvas of 220 by 220.
The latter path yields a path with:
d: M 0,0 M 0,0 L 200,0 L 200,200 L 0,200 L 0,0 Z
transform: matrix(1.0,0.0,0.0,-1.0,0.0,0.0)
In this case we get a Rect(10, 210, 200, 200). As soon as I remove the transformation the rectangle moves to be center in the viewbox but I suspect for the wrong reason (it'll be upside down). I suspect the y-mirror transformation fails because the transforms are applied around the 'origin' of the shape. In the case of a svg rect that's its centroid. In the case of a path it's the coordinates of the very first draw call.
Entire Svg output for rect2: https://gist.github.com/Pucilowski/ace2dce5f15872ebca173b345cbd6826?short_path=fde0c33
Thanks for the time you're putting into this!

Thanks for the report. I'm not sure what's causing the issue off the top of my head, but I'll take a look as soon as I have time.


turtlebot3 navigation costmap2DROS transform timeout and Could not get robot pose

ISSUE TEMPLATE ver. 0.2.0
Set-up

TurtleBot3: Waffle Pi

SBC: Raspberry Pi 3

OS installed in SBC: Raspbian

OS installed on remote PC: Ubuntu 16.04 LTS

SW version: v1.12.13

Firmware version: v1.2.3

Commands:
[remote PC] roscore
[turtlebot] roslaunch turtlebot3_bringup turtlebot3_robot.launch
[remote PC] roslaunch turtlebot3_slam turtlebot3_slam.launch slam_methods:=gmapping
[remote PC] rosrun map_server map_saver -f map
[remote PC] kill slam
[turtlebot] kill bringup
[turtlebot] roslaunch turtlebot3_bringup turtlebot3_robot.launch
[turtlebot] roslaunch turtlebot3_navigation turtlebot_turtlebot3_navigation.launch map=$HOME/map.yaml

Problem:
I am trying to follow the navigation portion of the e-manual and have been running into a couple problems. After running the last command, I get the error shown below. The second error, "could not get robot pose, cancelling reconfiguration", comes and goes. I typically use the RC100 to move the bot as using the teleop keyboard doesn't work when trying to move the robot but works in simulation.

I've tried redoing SLAM and trying navigation on the new map to see if maybe my map just isn't good but still get the same error.
I've looked at other issues related to mine and have tried the proposed solutions (reseting OpenCR, restarting roscore and bringup, checking if turtlebot and the remote PC are on the same time using ntpdate ntp.ubuntu.com). None of these worked.
I ran roswtf to see what was wrong and noticed that the following nodes were not connected.

I noticed in the related issues that there were mentions of topic frequencies (tf and odom) so I'm attaching tf_monitor output. When I ran rostopic hz /tf, the average frequencies ranged from 30Hz to 70Hz. It also says it's an unknown publisher?

I also get this issue sometimes when bringing up turtlebot3: [WARN] Failed to get param: timeout expired
I'm unsure of what is going wrong and would really appreciate any help in getting to the bottom of this! Thank you so much in advanced!

Hi, @velvetbleurose :)
To move the turtlebot using RC100 and teleop is absolutely different. The RC100 only controls the DXL by directly connecting to openCR. Teleop is example package for ROS. So, If you can't move to turtlebot3 using teleop, It is not connect to turtlebot3 and PC. This mean that you can't use another package.
First, you have to move the turtlebot3 using teleop.

You can check connection turtlebot3 and remote PC by rostopic.

Bring up your turtlebot3.
Run teleop launch.
Check topic information follow command.
rostopic info /cmd_vel

If you connected, you can see publishers and subscribers nodes.
Actually, you can run the another package as SLAM, navigation. But, It can't move to turtlebot3.
In navigation, It use ROS message as /cmd_vel for moving turtlebot3. So, you can't work navigation.
But, In SLAM, It doesn't matter how to communicate for moving turtlebot3. Because It not use /cmd_vel for moving turtlebot3.

I found the problem with regards to teleoperation - it was my OS firewall settings. I had only allowed turtlebot to communicate on port 11311 instead of allowing all connections.
For this I ran sudo ufw allow from turtlebot_ip
However, my navigation problem still remains. I ran roswtf and get the same error outputs (move_base --> move_base not connected but should be) minus the cmd_vel error. I also still get the Costmap2DROS transform timeout error and I notice that tf_monitor still says it's from an unknown publisher.

I'm sorry for late reply.
Did you type follow command in turtlebot3?
roslaunch turtlebot3_navigation turtlebot_turtlebot3_navigation.launch map=$HOME/map.yaml
This package has to run in remote PC.

Yes, I am running it from remote PC. Both problems still persist, shown below. I just ran these right now.

I'm sorry for late reply.
Did you try to sync time? Refer to this.
Type the following command in turtlebot3 and RemotePC.
sudo ntpdate ntp.ubuntu.com

@kijongGil
I have done the time sync numerous times.
I got navigation to finally work by increasing the transform tolerance parameter and TurtleBot is able to navigate well so I fixed that issue!
I still get the error that the two nodes that should be connected are not. Is that a major problem or if is it one I can ignore?

Don't care, It is not problem.
Increasing the transform tolerance parameter is not good way. Because the transform tolerance is that how many different ros time btw Remote PC and turtlebot3. For example, the transform tolerance is 0.5, you get warning log when ros time btw Remote PC and turtlebot3 is over 0.5s.
So, I recommend return to the transform tolerance. and update ntpdate frequently.
Thanks.

This issue will be closed since there were no actions for a while. You can reopen this issue to show this issue to the users whenever. Thanks.

did you solve it? I have exactly the same issue

For future reference:
Had the same problem, syncing the time on the Turtlebot as well as on the remote PC fixed the problem using this:
$ sudo apt-get install ntpdate
$ sudo ntpdate ntp.ubuntu.com


Convert to Hex

Before jumping into Pr first comment for assign.All Problem from Edabit. Link is mandatory to add
Problem statement: Create a function that takes a strings characters as ASCII and returns each characters hexadecimal value as a string.
Problem Link: https://edabit.com/challenge/g6yjSfTpDkX2STnSX

Before submitting a PR please Check some details.Check Edabit for problem task

[ ] fileName formet should be in camelcase
example- returnTheNextNumber.py
[x]  Add label for Problem
[x]  In file there should be problem statement and link to probelm
example -

'''
    Probem Task : This program will add two numbers
    Problem Link : https://edabit.com/challenge/SFzHtm63XT6EYNHWY
'''
*/
def main():
    return a + b

This repository is vaild for HacktoberFest2020
Read before making PR - How to contribute on Github
Good Luck,

please assign this task to me!

Can you please assign this task to me?


Default Field Values

It would be awesome to be able to specify default values for fields.
I find myself creating a lot of forms where I have optional fields, but if a user doesn't supply a value for an option field I'd like to populate it manually with a default value.
It would save me a lot of code if this library supported something of this sort out of the box.

Duplicate of #120 which has a number of ideas in it - namely, binding prior to rendering.
I'm open to better ideas of how to do this, but it seems like "binding before rendering" would solve this.
Please reopen if not.


Fix: 'Reset All' should reset all the values in the form fields

Now clicking the 'Reset All' button will reload the CourseFinderFilterForm component after deleting the query string. This will reset the form to its default initial values.
React will re-render a component whenever a parameter changes, so the key parameter is changed to reload the component.
Fixes #40

Great Work, I reviewed the code, just make the PR to the DOPE branch and not the master branch and then I will merge

Great Work, I reviewed the code, just make the PR to the DOPE branch and not the master branch and then I will merge

Done


[#1135] improvement(docs): Add docs about tables advanced feature like partitioning

What changes were proposed in this pull request?
Add docs about the details of table partitioning, bucketing, and sorting order.
Why are the changes needed?
The document is mandatory for users.
Fix: #1135
Does this PR introduce any user-facing change?
N/A
How was this patch tested?
N/A

The Expression section should be an independent chapter, making it easier for Partitioning, Bucket, and sortOrder to reference it.

The first version I did used a separate chapter to describe it. It seems a bit isolated, so I merged it into this file.

@jerryshao
Can you spare some time to review the PR?

@jerryshao Can you spare some time to review the PR?

@jerryshao
Please take time to review it, thanks.

@jerryshao
Please take a look if the modification is reasonable, thanks.

@mchades would you please help to review again?


[TASK] Allow to load guides.xml when in composer mode

When building a PHAR, or using this project as a composer dependency, the vendor/bin/guides binary could not be called due to a PHP error.
This is because the file guides.xml is referenced via vendor/../guides.xml. That works in the root of the main render-guides repository, but not in a composer environment.
There the correct location is vendor/t3docs/render-guides/guides.xml.
This PR adds a check to resolve that file in case the first try returns FALSE for the realpath() lookup.
Generally this lookup code is a bit spaghetti-ish and we should properly refactor this. For the time being, a hotfix like this would allow me to continue on using render-guides as a dependency in referring projects.

@garvinhicking  I just merged #824, does this solve your issue as well? the error might be gone, but I think you have a more specific use case for typo3, when the tool is installed via composer?

No, doesnt fix mine because I need the fallback without ../ just like in this PR. Maybe you could look at it again, it doesn't do so much more than the one you merged apart from one more directory check...

Ah, now I see the problem - I need to reference the guides.xml of a specific composer packe, but it's one that uses "guides" but it isn't guides itself.
So we'd probably need another configuration directive to specify the projectConfig file. Can I override that later on in the workflow, or do you have a suggestion how to specify the file without needing a patch so individual like mine?

Maybe we should solve this in some way in the typo3 project, let's see if that's possible someway.

The script tries to load the guides.xml file from 3 locations:

The directory containing vendor/ (i.e. the project root)
The current working directory, either the current directory where the guides command is ran or the directory specified using the --working-dir option
From any other directory specified by --config

The script tries to load the guides.xml file from 3 locations:

The directory containing vendor/ (i.e. the project root)
The working directory, either the current directory where the guides command is ran or the directory specified using the --working-dir option
From any other directory specified by --config

Let me try to rephrase the problems I have.
The TYPO3 render-guides composer package (not really, because this is not offered as a composer package...) requires this phpdocumentor/guides. The guides.xml file of the render-guides repository is thus part of the "root" project.
When checking out the render-guides repository, the file will be loaded because it matches "vendor-dir/../guides.xml". All good so far. Additionally, another config file can additionally be loaded from a subdirectory (e.g. render-guides/Documentation/guides.xml). That sub-directory guides.xml only has documentation-specific configuration, while the main guides.xml has some core-level configuration.
core-level example:
<?xml version="1.0" encoding="UTF-8" ?>
<guides
    xmlns="https://www.phpdoc.org/guides"
    xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
    xsi:schemaLocation="https://www.phpdoc.org/guides vendor/phpdocumentor/guides-cli/resources/schema/guides.xsd"
    links-are-relative="true"
    theme="typo3docs"
>
    <extension class="\phpDocumentor\Guides\RestructuredText\DependencyInjection\ReStructuredTextExtension"/>
    <extension class="\phpDocumentor\Guides\Bootstrap\DependencyInjection\BootstrapExtension"/>
    <extension class="\phpDocumentor\Guides\Graphs\DependencyInjection\GraphsExtension"/>
    <extension class="\phpDocumentor\Guides\Markdown\DependencyInjection\MarkdownExtension"/>
    <extension class="\T3Docs\Typo3DocsTheme\DependencyInjection\Typo3DocsThemeExtension"/>
    <extension class="\T3Docs\GuidesExtension\DependencyInjection\Typo3GuidesExtension"/>
    <extension class="\T3Docs\GuidesPhpDomain\DependencyInjection\GuidesPhpDomainExtension"/>
    <output-format>html</output-format>
    <output-format>singlepage</output-format>
    <output-format>interlink</output-format>
</guides>

project-level:
<?xml version="1.0" encoding="UTF-8" ?>
<guides
    xmlns="https://www.phpdoc.org/guides"
    xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
    xsi:schemaLocation="https://www.phpdoc.org/guides vendor/phpdocumentor/guides-cli/resources/schema/guides.xsd"
>
    <project title="Render guides"/>
    <extension
        class="\T3Docs\Typo3DocsTheme\DependencyInjection\Typo3DocsThemeExtension"
        edit-on-github="TYPO3-Documentation/render-guides"
        edit-on-github-branch="main"
        interlink-shortcode="t3docsRenderGuides"
        typo3-core-preferred="stable"
    />
    <!-- explicitly link to stable versions of extensions -->
    <inventory id="georgringer/news/stable" url="https://docs.typo3.org/p/georgringer/news/11.3/en-us/"/>
    <inventory id="cobweb/external_import/stable" url="https://docs.typo3.org/p/cobweb/external_import/7.2/en-us/"/>
</guides>

Both files need to be loaded (not just one). If I read the code right, the first one is $projectConfig, and the second one is $localConfig in the packages/guides-cli/bin/guides script.
If I now create a package that uses the phar or composer package, when running it, the vendor/../guides.xml no longer resolves to the guides.xml that is specified in t3docs/render-guides. Because that is actually in vendor/t3docs/render-guides/guides.xml.
To get this all running, what we need is to be able to influence BOTh the $projectConfig AND $localConfig.
The current phpdocumentor/guides-cli implementation only makes $localConfig configurable, and NOT $projectConfig. When using the phar I could thus only either specify the guides.xml of my own project or the one of t3docs/render-guides -- but I would need both.
So in the end I would need the ability to specify:

projectConfig = vendor/t3docs/render-guides/guides.xml
localConfig = /path/to/my/Documentation/guides.xml

I hope this explanation is better understandable now.


add rpc state

TITLE
Description
Description of the pull request changes and motivation.
Checklist

[ ] Linked to Github Issue
[ ] Unit tests added
[ ] Integration tests added.
[ ] This change requires new documentation.

[ ] Documentation has been added/updated.

Codecov Report

Merging #851 (cf98117) into main (3bbcf53) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #851      +/-   ##
==========================================
- Coverage   91.74%   91.73%   -0.02%
==========================================
  Files          54       54
  Lines       12842    12836       -6
==========================================
- Hits        11782    11775       -7
- Misses       1060     1061       +1

see 4 files with indirect coverage changes


Removed unicodecsv in requirements

Was forgotten in 80e72cfa27264ef.

Would be superseded by #361, so just close this if you plan to merge that one.

Replaced by #361


feat(proxy-wasm) implement response body buffering

First this fixes on_response_body execution of requests when they issue subrequests that produce a body (see 004-on_http_phases.t). This unlocks testing of response body buffering via subrequests producing chunked responses (ngx_chain_t buffers).
Response body buffering itself is implemented as part of ngx_http_wasm_filter_module, so as to be usable from other components than just proxy-wasm. Response body buffering is enabled via rctx->resp_buffering which is enabled when ngx_wasm_ops_resume returns NGX_AGAIN, which for filters translates to returning PAUSE from on_http_response_body.
If and when the response body buffers are full, then the next on_http_response_body call will have eof=false, and more invocations can be expected, as the body must be proxied in chunks.
If the response body fit in the buffers, then the next on_http_response_body call will have eof=true as one would expected.
We catch "response body already requested" in ngx_proxy_wasm to produce a proxy-wasm error message, as this feature is currently only exposed through it.

[ ] CI & Valgrind
[ ] coverage
[ ] documentation
[ ] changelog

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

112 of 119 (94.12%)  changed or added relevant lines in 6 files are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.01%) to 91.025%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/http/ngx_http_wasm_filter_module.c
101
108
93.52%

Files with Coverage Reduction
New Missed Lines
%

src/wasm/ngx_wasm_util.c
2
87.1%

Totals

Change from base Build<PHONE_NUMBER>:
0.01%

Covered Lines:
7637

Relevant Lines:
8390

💛  - Coveralls


ThirdPartyInfoEntity should use DateTimeField for its release_date

Currently ThirdPartyInfoEntity used StringField for its release_date whereas it should use DateTimeField.
This causes the following issue:

release_date (2018-07-03): Could not adapt datetime.date(2018, 7, 3) to <type 'unicode'>

This does not seem like a SpringField issue. If it is, please add more information so it is more clear.


NIFTI services for all datatypes

uint8, uint16, uint32, float, double -- dependent upon Greg providing suitable examples.

This is complete. 8 datatypes accepted 3d/4dx8,16,32,float.  There is no automatic channel creation.  This is discussed in slack.  I've pushed to rbdevel.  Kunal to merge when he makes the AWS instance.


Missing standard element: Fieldset

Requesting Fieldset to be added to standard elements.

@kriszyp I don't think it's working, does it need to be included in the generate function here? https://github.com/kriszyp/alkali/blob/master/Element.js#L1118

Oops, sorry about, should be fixed with the latest commit/version.


Update Astro

This PR contains the following updates:

Package
Type
Update
Change
Pending

@astrojs/react (source)
dependencies
patch
2.1.1 -> 2.1.2
2.1.3

@astrojs/rss (source)
dependencies
minor
2.3.2 -> 2.4.0
2.4.1

@astrojs/tailwind (source)
dependencies
patch
3.1.1 -> 3.1.2

astro (source)
dependencies
patch
2.3.1 -> 2.3.3
2.4.1 (+2)

Release Notes

withastro/astro (@astrojs/react)
v2.1.2
Compare Source
Patch Changes

#6933 649d70934 Thanks @matthewp! - Automatically configure redoc

withastro/astro (@astrojs/rss)
v2.4.0
Minor Changes

#6707 4ea716e56 Thanks @philnash! - Added extra elements to the RSS items, including categories and enclosure

withastro/astro (@astrojs/tailwind)
v3.1.2
Compare Source
Patch Changes

#6930 2dca81bf2 Thanks @bluwy! - Update dependencies

Updated dependencies [a98df9374, 50975f2ea, ebae1eaf8, dc062f669]:

<EMAIL_ADDRESS>

withastro/astro (astro)
v2.3.3
Patch Changes

#6940 a98df9374 Thanks @delucis! - Support custom 404s added via injectRoute or as src/pages/404.html

#6948 50975f2ea Thanks @imchell! - Placeholders for slots are cleaned in HTML String that is rendered

#6848 ebae1eaf8 Thanks @Princesseuh! - Update experimental.assets's image.service configuration to allow for a config option in addition to an entrypoint

#6953 dc062f669 Thanks @Princesseuh! - Update astro check to use version 1.0.0 of the Astro language server

Updated dependencies [ac57b5549]:

<EMAIL_ADDRESS><EMAIL_ADDRESS>

v2.3.2
Patch Changes

#6920 b89042553 Thanks @bluwy! - Fix tsconfig alias baseUrl handling for "." and ".." imports

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

⚠ Artifact update problem
Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.
♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

any of the package files in this branch needs updating, or
the branch becomes conflicted, or
you click the rebase/retry checkbox if found above, or
you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:
File name: pnpm-lock.yaml
undefined