Added skeleton x-ray

I've added the x-ray on skeleton in order to see its bones. It can be activated in the Debug menu.

I'm not 100% sure that EditorNode is the right way where to put the variable debug_skeleton_xrays. Please let me know if I've to move it in a better place.
My intent was to add the skeleton bones names, but it require the creation of an additional Node that allow me to use a label in the 3D world. So for now I'm submitting only this.
Related topic: https://github.com/godotengine/godot/issues/11507

Will this make bones visible in game? This menu has options to display debug stuff when game runs.
I would change name a bit - "Visible Skeleton Bones" ?

Yes you true, The name does not explain what it does very well, instead "Visible Skeleton Bones" sounds very good to me.
Also this material is set in the Skeleton gizmo and it's loaded only into the editor so the bones are never rendered in game.
Initially I was implementing it in the skeleton menu (that doesn't exist in this moment) but I thought that it's way more handy had it in a menu that is always visible, So I move it there. Probably the best position could be under the Editor Menu.

If it's like that I think it should be in the View menu of the Spatial Editor. It is probably the most logical place for 3D viewport feature like this.

The current location of the option implies that it will be visible during runtime. (which imo a nice feature, but I'm not sure about actual use case.) If that's not the case, I agree that SpatialEditor toolbar or its submenus are better places.

It could be added to Skeleton node maybe? This way we would be able to see bones when debugging a game too (like collision shapes), just suggesting

Ok some feedback from the PR monday:

having as an entry of the debug menu is probably not a good choice.
@reduz suggested we could instead have an option to make all gizmos x-ray, thus it could be a viewport option instead :).

I'll put it in the viewport menu, as suggested by n-pigeon. I didn't have the time to do that before, I'll update it soon. I'll use "Gizmo x-ray" if the reduz's idea is to have x-ray for all gizmos in the editor.

I've moved the option in the View menu.
When you click Gizmos X-Ray is required that you click the skeleton node in the nodes panel in order to redraw the gizmos with new material. Do you know how can I force Gizmo to be redrawed?

From todays PR irc meeting:
 this should probably be applied to all gizmos, not skeleton

Spatial objects have an update_gizmo() function to update the gizmos

Also, what's debug_skeleton_bones_names for ? it doesn't seem used.

I've changed menu name to "Show bones on top"
Removed unused code
Implemented function that update gizmos to instantly show or hide bones.

Do you know when this can be merged? I need it

Well there are still some problem with the PR. Please,

Make sure the change affects all 3D gizmos.
Remove set_skeleton_bones_names(), get_debug_skeleton_bones_names() and debug_skeleton_bones_names as they are not used.
Rename set_gizmos_xrays() to set_show_gizmos_on_top(), is_debug_skeleton_xrays() to is_show_gizmos_on_top() and debug_skeleton_xrays to show_gizmos_on_top
Remove the update_all_gizmos() function, and just call _update_all_gizmos() at the end of set_show_gizmos_on_top().

I was checking this PR code, and I saw that it went in a different direction of my first intent.
My main need was to view skeleton bones (x-ray) and at the same time I want to see only skeleton bones on top in order to avoid confusion in the editor.

For example the image above show only the skeleton on top but the scene is to crowded, imagine if all gizmos were on top, it'd be chaos.
@Hinsbart said:

From todays PR irc meeting:
[reduz] this should probably be applied to all gizmos, not skeleton

Now I want revert it and focus just to the original thing, so @reduz what do you think about the implementation of an option for each spatial gizmo that require to stay on top?
In order to have

Show skeleton on top
Show XXXXX on top
Show YYYY on top

and allow the user to customize the view as he needs.

Ok, if it bloat the view it's not a good idea then.
In fact I think having this as an option is a little bit unexpected. Is there any reason why we would not want the bone to be drawn on the top ?

@groud always on top? I want to add more control to the view.
My idea is to add some other options in order to show / hide gizmos.
For example in the picture above would been usefull hide all collisions gizmos, sice I was working on skeleton.
So put something always on top is not so usefull.

@AndreaCatania, maybe not always on top, but when you select a node from the same skeleton (maybe ?).
My point is that we should avoid adding "optional" stuff if one of the option is never used. If it's hard working with bones which are not drawn on top, just make "drawn on top" the default, then maybe add an option to show/hide the bones totally.

My point is that we should avoid adding "optional" stuff if one of the option is never used.

You can't assume that one option is optional and will never be used only because it doesn't yet exist, or you don't need it.
I don't exactly know why you are against it but probably you are scared about adding too many options, that for sure give more control to the user.
This screenshot is how looks like UE4, it has tons of options that give all kind of required customizations (It is a completed editor, so we can base to it).

Another thing that I want to point out is that, completely hide a gizmo or show it always on top is could be very annoying, I think we have to give more control to user.

To be honest, I think Unreal is doing a pretty bad job about this... Their interface is overcrowded with a lot of useless elements that are everything but user-friendly. Having too much options is often useless (as nobody change 90% of them) or at least confusing as it's hard to find the truly interesting ones. As for the API, we should be careful about what we let available to the user and what not, as we want Godot to stay easy to learn.
I am not against the option, but if there is a way to avoid something to be optional I think it is better. I have the feeling that bones are pretty useless if not drawn on top, as if they are hidden inside an object (which may happen most of the time) it is like is there were not here. Thus, if we can find a way to hide them when they are not needed, I think it is better. A solution could be to hide the bones when the object is not selected (but I'm open to other proposals :) ).
I'm not against merging, but for me this option does not seem very ergonomic as is. I think it need more opinions.

Be careful, you're more than the everyday user. Debugging the editor/engine is not like creating a game with the engine. :)

Instead of adding options, why dont we simply make the skeleton be always
on top? I dont see any use for it being behind objects. In fact, I think
this is how it used to work before..
On Tue, Nov 7, 2017 at 10:02 AM, Gilles Roudiere<EMAIL_ADDRESS>wrote:

To be honest, I think Unreal is doing a pretty bad job about this... Their
interface is overcrowded with a lot of useless elements that are everything
but user-friendly. Having too much options is often useless (as nobody
change 90% of them) or at least confusing as it's hard to find the truly
interesting ones. As for the API, we should be careful about what we let
available to the user and what not, as we want Godot to stay easy to learn.
I am not against the option, but if there is a way to avoid something to
be optional I think it is better. I have the feeling that bones are pretty
useless if not drawn on top, as if they are hidden inside an object (which
may happen most of the time) it is like is there were not here. Thus, if we
can find a way to hide them when they are not needed, I think it is better.
A solution could be to hide the bones when the object is not selected (but
I'm open to other proposals :) ).
I'm not against merging, but for me this option does not seem very
ergonomic as is. I think it need more opinions.

Be careful, you're more than the everyday user. Debugging the
editor/engine is not like creating a game with the engine. :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/godotengine/godot/pull/11510#issuecomment-342475425,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AF-Z2wK-CdYH9AKHgGEMRcS2V_ZG4pP0ks5s0FTjgaJpZM4Phiiz
.

@groud UE4 is too crowded and this is not a good thing when you open it for the first time, and here I agree with you. And yes my formamentis is different from every day user and my opinion could be wrong.
However depending on the situation it may be useful have it visible, on top, or hidden. Probably a button with three way check could be useful.
Something like:

In this way we can save options numbers and at the same time we get full control of all gizmos, if you don't think it's a good idea, draw the skeleton always on top as default and allow to hide it with an option is enought for my needs.

@AndreaCatania I think this is very good idea.

I'm ok with such option for each gizmo, still I don't know see any use case where you need to have the bones visible but not drawn on the top.

It's a rare case, but for example if you need to set the size of physical bone, or set the transform of attached node could be hard in some cases if the skeleton is drawd on top.
Imagine if you want to do it for an hand where you have 20 bones drawed all togheter.

We can always make it so bones are always visible on top and check if that really is a problem or not.
I think at minimum, we have to be able to hide them without turning them OFF.
Although if we make clean feature that some nodes if they need to can be in XRay mode using Scene tab, then it will be nice addition for usability. I see this useful not only for Bones.

It's a rare case, but for example if you need to set the size of physical bone, or set the transform of attached node could be hard in some cases if the skeleton is drawn on top.

Yeah but in this case, just hiding them would do the trick, wouldn't it ? ^^

I think at minimum, we have to be able to hide them without turning them OFF.

I agree on that :)
In any case, my point is that every option should have a purpose corresponding to a specific use case.  For example, I'd rather have a "Debug collisions" checkbox, that displays collision boxes on the top, displays a different color when collisions occur or displays debug text, rather than several checkboxes to activate the features one by one.

I've implemented it. This is how looks like:

I like it very much.


Create files base64 and sed errors

Hi,
Reviewing the material for my acredition I discover two minor issues on create_files script, the first one is about base64 function, because on my machine ( WSL2 ) the $content generate a return line and the post file fail (400 bad request ) because invalid json.
The sed ejectued on non msys plattform is also malformed also (blank quotes)  I fix both issues as I show on the code
        # Insert slide image into slide
        sed -i "s|IMAGE|$random_image|g" "$new_file" >>log.out 2>&1
        # Encode the file
        content=$(base64 -w 0 <"$new_file")

If you are interested I can create PR with my changes,

Well... another bug more on the scripts

on shared_functions the --quiet parameter for http is also not supported!

Thanks for reporting this, @unaizorrilla. Feel free to open a pull request with your changes and we’ll review it.

Well... another bug more on the scripts

on shared_functions the --quiet parameter for http is also not supported!

Hello, I had the same issue but the --quiet parameter is not supported for httpie 1.0.3 version that is shipped automatically on Ubuntu using apt-get in my environment. I solved installing httpie version 3.0.2 using snapd package manager but is not automatically managed by bootstrap script.

@pamontag, I ran into a similar issue around HTTPie version and filed #344.

This issue will be automatically closed when #351 is merged. If the sed issue isn’t resolved, feel free to re-open this issue or create a new one.


Update index.md

do not tell people to modify dist file, it is not used by the application

Merged on the lowest maintained branch, thank you @janmyszkier.


Error No module named 'requests' using Open edX connection

Bug Report
Problem description
When using Richie connected to an Open edX instance, that use src/richie/apps/courses/lms/edx.py, Richie is throwing an error.
The error is related with the missing No module named 'requests'.
I don't know how this could have happened, but probably the requests have been installed by a transitive dependency.
Environment

Richie version: 2.15.1

It works ok on Richie v2.14.0
Possible Solution
Add requests as Richie requirement.
Add a test that verify the split_course_key method.
Stack trace
Add any other context about the problem here. If applicable, add screenshots to help explain.
No module named 'requests'
......
  File "/usr/local/lib/python3.10/site-packages/richie/apps/courses/lms/edx.py", line 7, in <module>
    import requests
ModuleNotFoundError: No module named 'requests'

It was introduced when the social-auth-app-django==3.1.0 have been removed from the dependencies, when it was removed the unused social auth.


TEAMNADO-4242: Apply unit testing best practices to components

Codecov Report
Base: 95.26% // Head: 95.76% // Increases project coverage by +0.49% :tada:

Coverage data is based on head (9e6872e) compared to base (dd47efa).
Patch has no changes to coverable lines.

:exclamation: Current head 9e6872e differs from pull request most recent head 4965ec8. Consider uploading reports for the commit 4965ec8 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #79      +/-   ##
==========================================
+ Coverage   95.26%   95.76%   +0.49%
==========================================
  Files          31       31
  Lines         401      401
  Branches       97       97
==========================================
+ Hits          382      384       +2
+ Misses         16       14       -2
  Partials        3        3

Impacted Files
Coverage Δ

...components/SubscriptionTable/SubscriptionTable.tsx
87.95% <0.00%> (+1.20%)
:arrow_up:

src/components/ProductsTable/ProductsTable.tsx
100.00% <0.00%> (+1.40%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Replace Win32 named pipe with simple ServerSocket

This currently works fine, but spawns a new server on every invocation!?
I'm not sure if this is a problem introduced by this change but I doubt it.
Maybe I just don't understand the locks code in Mill well enough.. 😄
Anyways, it runs a simple ServerSocket on a random port on localhost, and writes that port in a file.
Client can then read the port and connect to the server.
I also "tested" the security part of server, by running an Android app that scans the ports of my computer.
It doesn't show the allocated port, so should be good.

One thing missing from this PR is a description of what it is actually trying to accomplish, an understanding of what the behavior and problems of the current system are, and an explanation of how this is the best solution to fix those problems  😛
The client/server code could definitely use a lot of work, particularly on windows, and definitely has bugs. But it's a pretty tricky area of code involving multi-process concurrency and locking, so it demands more "measure twice cut once"-style changes rather than "move fast and break things"

@lihaoyi yeah, that makes sense. Can you describe a bit the logic behind MillServerMain code?
I mean just conceptually, what is its main logic trying to achieve?
Then we could get to some conclusion and improvements maybe? 😄
For example, it's not clear to me why in while (running) { it reopens the server socket?

The logic is trying to implement the following:

If there is no MillServerMain, or there are existing MillServerMains but they're all in use, we create a new one and connect to it
If there is an existing MillServerMain running that is not currently being used, we connect to it and use it
If there are n=5 existing MillServerMains, and all are in use, we fail with an error (just to stop someone from accidentally spawning 100s of background processes)
An individual MillServerMain terminates after n=5 minutes or inactivity, or if Ctrl-C is given while it is executing tasks
If a MillServerMain is given Ctrl-C while in the file-watching mode, it should not terminate but remain in the background to pick up further tasks

A lot of the complexity around locks etc. is to do this reliably in the presence of multiple Mill clients being spawned concurrently and in arbitrary orders, with the given commands taking arbitrary amounts of time to run

#1230 tries to fix existing code instead of this.


Create cron job to update unity-renderer version in kernel and ecs packages once per day

@pravusjif FYI


waitpid implementation difference between ucore and rcore

Description
Discovered by testing ucore test badarg.
In uCore, when waitpid succeeds, it returns 0.
But in rCore, when waitpid succeeds, it returns the pid of the process that changes it status.
In test badarg, it asserts that "waitpid(-1, exit_code) == 0" (which corresponds to the standard of uCore), but in rCore the return value is 2 (the pid of the child process that exits).
Reproduce Steps
make sfsimg arch=x86_64
make run arch=x86_64 mode=release
cd ucore
./badarg

Current Result
fork ok.
user panic at /home/huangbj16/Documents/ostrain/rCore_Self/rCore/user/ucore/src/badarg.c:21:
    assertion failed: waitpid(pid, &exit_code) == 0 && exit_code == 0xbeaf
Unknown signal (core dumped)

#Expected Result

IMHO, uCore tests are no longer needed or can be rewritten for POSIX.

I think uCore tests should be modified to match the POSIX API,
which means they can run on common Linux.

agree.


default link in docs/guide shows 404

What steps will reproduce the problem?

Navigate here: https://www.yiiframework.com/doc/guide/2.0/en/input-validation#data-filtering
Click on default link.
Receive 404

What is the expected result?
Navigate to default core validator page
What do you get instead?
404
Additional info
This happens on @cebe mirror as well http://stuff.cebe.cc/yii2docs/guide-input-validation.html
Any guide on how the docs are generated? All links look correct just isn't rendering the link correctly.

Q
A

Yii version
master and <IP_ADDRESS>

PHP version
n/a

Operating system
n/a

Link that give 404 error : https://www.yiiframework.com/doc/guide/2.0/en/tutorial-core-validators.md#default
Link that give correct redirection :  https://www.yiiframework.com/doc/guide/2.0/en/tutorial-core-validators#default
seems .md generated in links in not needed to create working links

Also I checked other links, they are generated properly. For e,g. link for trim, it does not contain .md in the link

@SOHELAHMED7 I thought the same thing about dropping the '.md' but other places in the docs have it. There is something else causing this that I'm not aware of yet.

The docs are built with https://github.com/yiisoft/yii2-apidoc. Likely the issue is about it. I'll move it there.


[GHSA-74w3-p89x-ffgh] ansi_term is Unmaintained

Updates

Affected products
Severity

Comments
RUSTSEC classifies this as "info". This crate just produces ansi console output, it doesn't even parse any trusted or untrusted input. So there's no reason to mark this as "critical".

Thank you for your community contribution, however we cannot accept it because it is a duplicate of https://github.com/github/advisory-database/pull/685. Please see https://github.com/github/advisory-database/pull/685#issuecomment-1251099168 for more information.


Add 8.0 compatibility

Currently, the pod was 8.2 and above compatible.
I added compatibility with 8.0

Ok, I merged your changes, and did update pods to version 0.3.1. Thank you:)


Contributor Nomination tomi-font

Nomination
GitHub User
Provide the following information about the GitHub user:
Full Name: Tomi Fontanilles
GitHub username: tomi-font
Organization: Nordic Semiconductor
Supporting Documents
#68981
#68651
#68206
#67062
#66522

CC @nashif @MaureenHelm @carlescufi

@kartben This one is stuck I think :)

https://github.com/zephyrproject-rtos/zephyr/invitations


How to MMPlayerlayer from playing if Pushing new viewcontroller

I'm using MMplayerLayer for viewing images in table view, But it won't stop even after pushing new controller. How can I make it stop from playing if pushing new Controller.

I already have written this in viewDidDisapear but this doesn't work.Looks like there is some other problem as well.

Thanks for reply, I have been to fix this issue , when you push/present controller you will get function "func transitionCompleted(player: MMPlayerLayer)" and you can get this variable to put in your variable


Remove useless bootstrap overrides and clean up variables

What this PR does / why we need it:
Remove everything that seemed useless from bootstrap-override directory and the _variables.scss file. The resulting file seems to have the same effects as before and it's much smaller and easier to configure.
Release note:
Make the theme lighter
Better bootstrap override config

Triggered a redeploy for netlify. Was a connection issue.

Removing code \o/


上传功能实现

Coverage decreased (-0.5%) to 99.507% when pulling 97f5889973f05802b8351b6587665a0893d8ce4e on bottle0825:master into 37ddbe07b5d72487e73d28ef37ecc91e8c7ac46c on rugao-web-fullstack:master.

Coverage decreased (-0.5%) to 99.507% when pulling 8ea03f69ff5e9bfe90f5432908d78eb032939518 on bottle0825:master into 37ddbe07b5d72487e73d28ef37ecc91e8c7ac46c on rugao-web-fullstack:master.

Coverage decreased (-0.5%) to 99.507% when pulling 0f0399ec206329f53061842ade4210c67c56fba9 on bottle0825:master into 37ddbe07b5d72487e73d28ef37ecc91e8c7ac46c on rugao-web-fullstack:master.


Android-Kotlin: 05.0 Introduction to Views in Android

Description

Give an overview of Views in Android. Talk about View and ViewGroups, and how both are different from each other.
Discuss various Views: ImageView, TextView, Button, EditText.
Discuss in brief about the basic implementation of each of them.

Resources

Views in Android - Official Docs

Changes should be made in Android_Development/Kotlin/ directory under Android_Development_With_Kotlin branch.
You have to push your PR to the Android_Development_With_Kotlin branch only.
You can take help to the references but don't simply try to copy it. Just explain in your own word. PRs with Plagiarised content will be rejected.
This issue is for GWOC'21 contributors only.
You need to push in a single commit. If there exists more than one commit then you need to squash your commits into one commit.

Supervisor @rahulsain

hey i am currently learning android development. kindly assign this issue to me. @rahulsain

@Narayan1002 You are already assigned to one issue, please work on that

@rahulsain Hey, can I work on this?

@ydasc815 bro may you please change the numbering from 05.0 to 06.0

@rahulsain Can I work on this task?

@rahulsain Hey, can I work on this?

Status?

@rahulsain I am working on this, sorry it was quite bit late I had some problems due to that I was unable to be regular. Just give me 3 days and it will be completed.

@rahulsain I am working on this, sorry it was quite bit late I had some problems due to that I was unable to be regular. Just give me 3 days and it will be completed.

Okay

@rahulsain sir I created a pull request please check it

Assign me this issue for   "  Audio section  "   . @rahulsain .
Thanks


Remove: ScratchForDiscord.ScratchForDiscord.Dev version 2.0.0-dev.13

Moniker is overlapped with parent package. No new dev releases since 2021. Low value in retaining package when newer stable package is released
Checklist for Pull Requests

[x] Have you signed the Contributor License Agreement?
[ ] Is there a linked Issue?

Manifests

[ ] Have you checked that there aren't other open pull requests for the same manifest update/change?
[x] This PR only modifies one (1) manifest
[x] Have you validated your manifest locally with winget validate --manifest <path>?
[ ] Have you tested your manifest locally with winget install --manifest <path>?
[ ] Does your manifest conform to the 1.6 schema?

Note: <path> is the directory's name containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

URL: https://github.com/scratch-for-discord/scratch-for-discord-app/releases/download/v2.0.0-dev.13/Scratch-For-Discord-Setup-2.0.0-dev.13.exe
Status Code: 200
(Automated message - build 896)

Hi @Trenly,
This manifest has the highest version number for this package. Is it available from another location? (This might be in error if the version is switching from semantic to string, or string to semantic.)
(Automated response - build 896.)


Open Source Backend

@krasimir thanks for making this—have been having fun using it but realize the limitations while in running dev mode (or running at localhost:8004). Would you be open to open sourcing the backend or providing a swagger doc or similar so those that are interested can roll their own? Namely, the ability to export to zip seems a prod-only feature.
Somewhat related: I am unable to login via Github on https://poet.krasimir.vercel.app — when looking at Github connected oauth applications, I do see Poet.codes, thought it lists https://poet.krasimir.now.sh—I see the other URLs were migrated from now.sh, but not this one. Perhaps this is related? FWIW, error message reads: "Authentication failed   Reason: ML"
I understand this is an old repo and you might not be interesting in working on it. If that's the case, no worries at all.
Just to say—thanks again, for this and your consideration.

Thanks for the reply @krasimir - I think Poet it is an incredibly cool and clever piece of software.
And thank you for sharing the full source—it is appreciated!


Switch to JDK HTTP client for Kubernetes Client

Note that this would probably mean switching the code base to require Java 17 at least.


Plugin triggers on "Zzz"

Plugin triggers on the sleeping cat in the farming guild. I imagine it would also trigger for other messages saying "Zzzz" or any variation of that.

It also triggers on cows saying "Moo"... What is this...

Turns out if the custom trigger is left blank, it triggers on every single message. I just happened to notice it on something similar to "Gzzz" first. Leaving this up so this can be addressed.


[feature request]: ChatGPTActAs allows user to edit prompt before submitting

ChatGPTActAs is a very powerful command and it would be even better if the user could edit the Awesome Prompt text before the request gets submitted.
Current behaviour
ChatGPTActAs shows a preview and title for awesome prompts, but does not allow prompt to be yanked.
I have tried <C-w w>, but this causes the prompt to close instead of letting me navigate to the prompt preview window and yank the prompt (see video below 👇) .
https://user-images.githubusercontent.com/22574186/236442926-9d1f104a-c2e2-4312-904f-d822affadc32.mp4
Once you choose a prompt it is immediately submitted to the OpenAI endpoint and consumes tokens, even if the prompt is not customized/ready to be submitted yet.
Proposed behaviour
ChatGPTActAs shows a preview and title for awesome prompts; hitting enter (or some other keybinding) opens a new session and populates the prompt field so it can be modified by the user before submitting.

PS: Thank you for the great plugin! ❤ It's my favourite way of interfacing with ChatGPT

I added option to set "system message" it should solve the issue, need to update the README  later to cover that.

Thanks for the fast response ⚡
I tested it out and the new SYSTEM window looks really good! My first instinct was to jk for moving but I realised that the prompt is one single wrapped line.
https://user-images.githubusercontent.com/22574186/236673735-d14d1e5b-f58a-48c5-ba35-aad4447668bb.mp4
Btw, how should draft_message = "<C-d>" be used?
In ChatGPTActAs it just scrolls the preview buffer (usual Vim movement)
In the regular prompt it seems to send an empty message and nothing else?
https://user-images.githubusercontent.com/22574186/236674040-f81995cb-4eba-41a2-9965-a63330037dec.mp4

Closing this issue because my initial request is already live 🙏


Golang 1.14 unreliably supported

When making use of this library in a golang 1.14 application the application as a whole intermittently starts up.  Once the import for this library is removed the same application starts up just fine.
Worth giving consideration for golang 1.15 as well I think.

Do you have a PR that would fix this?

I must admit I have not attempted to make one. I notice you have got tests targeting each golang version 1.9 - 1.13 (https://github.com/mattn/go-oci8/blob/master/test.sh) and I thought I would first find out if there was already a failed attempt due to a known issue that wasn't obvious to me.

On the same line I'd like to ask: which is the latest compatible version of the oracle instant client?
I'm trying to compile a project with instant client v19.6 and I get the following error:
main #gosetup
# runtime/cgo
clang: error: /opt/oracle/instantclient_19_8: 'linker' input unused [-Werror,-Wunused-command-line-argument]

Compilation finished with exit code 2

Sorry I am not sure why I didn't see this comment come through...
For me the latest version of golang that works reliably with this library is 1.13.  Given that this library is written with golang 1.13 either its a big coincidence or it might just be a matter of changing the golang version (and adding a test here: https://github.com/mattn/go-oci8/blob/master/test.sh) and done and dusted.
If there is no better plan than this I will give it a shot soon enough...

@calvinmo I found some time to take care of that and as #409's pipeline passed now we can assert that the package works with the latest versions of 1.14 and 1.15 (at least with the test coverage provided here)
Logs can be seen here: https://travis-ci.org/github/mattn/go-oci8/builds/750614710
I guess that leaves two questions open (agreeing with @MichaelS11 label here):

Whether there are platform any platform specific issues and fill them separately with mode detail (MacOS has it nasty share of issues, I don't know how well CGo fares there but that's my work environment and I was unable to install this package seamlessly)
Whether newer versions of oracle include a compatible libocci.so

This can be tested via some juggling with docker images (oracle provides a generator on https://github.com/oracle/docker-images/tree/master/OracleDatabase). If I have the time to run the tests myself I will check in here

@calvinmo There does not seem to be an issue with Golang 1.14. Can you please close this issue?

OK it seems I incorrectly diagnosed this issue then. My apologies. Back to the drawing board for me...

OK it seems I incorrectly diagnosed this issue then. My apologies. Back to the drawing board for me...


How to get account

I am trying to get account using below code but I am not getting account so please help.
var router = NetworkingRouter(RPCEndpoint.devnetSolana)
var account: Account? = null
var solana = Solana(router, auth = object : SolanaAccountStorage{
override fun save(account1: Account): Result {
account = account1
Log.d("Account Publik key", account?.publicKey.toString())
Log.d("Account Secrect key", account?.secretKey.toString())
return Result.success(Unit)
}
        override fun account(): Result<Account> {
            Log.d("Account ", "Account")
            account?.let {
                return Result.success(account!!)
            }
            return Result.failure(Throwable(""))
        }

        override fun clear(): Result<Unit> {
            Log.d("Account ", "Account Clear")
            account = null
            return Result.success(Unit)
        }
    })

have you make it work?


Excel file: NotImplementedError: Unable to parse uri to data resource

Hi there,
I thought I'd use odo to read in an Excel file. From the documentation it seems xls(x) is supported yet when I run the following I get an error.
odo('test.xlsx', list)

NotImplementedError: Unable to parse uri to data resource: test.xlsx

Has the Excel support been dropped?

This may be a carry over from when odo was inside of blaze. If we wanted to support excel we'd probably use pandas or whatever the reader is that pandas uses.


Unable to load model from .h5 file

currently i am using anaconda and python 3.6
i have .h5 but cannot load plz help me solve this error
i type this line to load the .hm
model = tf.keras.models.load_model('**rustnorust_b/rustnorust_model.h5**'))
i get this error
AttributeError                            Traceback (most recent call last)
 in
----> 1 model = tf.keras.models.load_model('rustnorust_b/rustnorust_model.h5')
~\anaconda3\envs\Corrosion_Detection\lib\site-packages\tensorflow\python\keras\engine\saving.py in load_model(filepath, custom_objects, compile)
227     if model_config is None:
228       raise ValueError('No model found in config file.')
--> 229     model_config = json.loads(model_config.decode('utf-8'))
230     model = model_from_config(model_config, custom_objects=custom_objects)
231
AttributeError: 'str' object has no attribute 'decode'
I have no idae help give any suggestion

@faisalhazry
In order to expedite the trouble-shooting process, please provide a code snippet to reproduce the issue reported here. Could you let us know the TF version you are using ? Thank you!

@faisalhazry In order to expedite the trouble-shooting process, please provide a code snippet to reproduce the issue reported here. Could you let us know the TF version you are using ? Thank you!

is this code snippet (https://github.com/faisalhazry/Corrosion_Detection/blob/main/rust_det-using-a-pretrained-convnet-VGG16.ipynb)
i upload the file in my github repository
If i am wrong plz tell me. I am new in this forum and machine learning
Current the file is running in anaconda python environment python=3.6 tensorflow==1.12.2 and keras==2.2.4

@faisalhazry In order to expedite the trouble-shooting process, please provide a code snippet to reproduce the issue reported here. Could you let us know the TF version you are using ? Thank you!

@faisalhazry The error is not reproducing with the 2.x version of Tensorflow. I tried to install the 1.x version on Google Colab but it is not longer supported. @sushreebarsa if there's anything you want me to try, please let me know.

@sunny7712 Thank you for your response!
@faisalhazry TF v1.x is no longer actively supported so it is always recommended for upgrading to latest TF version. Please let us know if you still face the issue in TF v2.11.
Thank you!


chore: change Github Action triggers for build/test jobs

High Level Overview of Change
Github Actions for the build/test jobs (nix.yml, mac.yml, windows.yml) will only run on branches that build packages (develop, release, master), and branches with names starting with ci/. This is especially targeted toward personal forks where CI runs are set up, but frequently unnecessary, and particularly once a pull request is opened - at that point any runs on the forks are redundant and wasteful.
Context of Change
This is intended as a compromise between disabling CI jobs on personal forks entirely, and having the jobs run as a free-for-all. Note that it will not affect PR jobs at all.
Type of Change

[X ] Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 76.94%. Comparing base (af9cabe) to head (66aca7c).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #4956   +/-   ##
========================================
  Coverage    76.94%   76.94%
========================================
  Files         1127     1127
  Lines       131675   131675
  Branches     39609    39515   -94
========================================
+ Hits        101320   101321    +1
+ Misses       24446    24411   -35
- Partials      5909     5943   +34

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


recoll rclimg @INC

Describe the bug
when running recollindex on images (mime-type image/*), rclimg is called and fails with
Can't locate Image/ExifTool.pm in @INC (you may need to install the Image::ExifTool module) (@INC contains: /nix/store/p4kc21xjdp11sgsmp804g0w1ya8irl1s-perl-5.36.0/lib/perl5/site_perl/5.36.0/x86_64-linux-thread-multi /nix/store/p4kc21xjdp11sgsmp804g0w1ya8irl1s-perl-5.36.0/lib/perl5/site_perl/5.36.0 /nix/store/p4kc21xjdp11sgsmp804g0w1ya8irl1s-perl-5.36.0/lib/perl5/5.36.0/x86_64-linux-thread-multi /nix/store/p4kc21xjdp11sgsmp804g0w1ya8irl1s-perl-5.36.0/lib/perl5/5.36.0) at /nix/store/zdjxabbnwvkm039l3m2csc8yj55fhk62-recoll-1.32.7/share/recoll/filters/rclimg line 154.
BEGIN failed--compilation aborted at /nix/store/zdjxabbnwvkm039l3m2csc8yj55fhk62-recoll-1.32.7/share/recoll/filters/rclimg line 154.

Steps To Reproduce

configure recoll to include some directories containing images (jpg, png, etc.)
run recollindex

Expected behavior
recollindex calling rclimg without failure
Notify maintainers
@jcumming
Metadata
[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 6.2.12, NixOS, 22.11 (Raccoon), 22.11.20230424.f536431`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.11.1`
 - channels(root): `""`
 - channels(woffs): `""`
 - nixpkgs: `/nix/store/mjwn8yvvd2j83srwbphsfpph6j3rkj58-source`

trying to work around, I found more issues:

filters/rclcheckneedretry.sh checks bindirs="/usr/bin /usr/local/bin $HOME/bin /opt/*/bin" which is rather useless on NixOS
rclimg.py also fails: RECFILTERROR HELPERNOTFOUND python3:pyexiv2


Update CRD documentation

switch asciidoc gen to referencing v1beta1
improve doc & default for ignored metrics (those changes were previously done on v1alpha1 instead of v1beta1, mistakenly)
add enum info on disableAlerts doc (unfortunately the enum doc, while being correctly picked up for openapi, is not picked up for doc generation; so I am duplicating it)
regenerate bundle & doc

@skrthomas here's the CRD doc update, with the re-generated asciidoc file
@OlivierCazade I noticed that your PR here did not show the disableAlerts enum documentation .. whereas is works correctly with openapi, it doesn't with our doc generators. So I am duplicating the enum listing & doc so it can appear in doc

/approve


Image Web Part in Sharepoint don't get rendered properly

Category

[x] Question

Expected or Desired Behavior
Images in SharePoint that was added via an Image Web Part should render like using ´figureandfigcaption`. Right now, all images get rendered in a construct of multiple div elements, while there are semantical HTML elements available.
In case of Accessibility, the images should follow the WAI Guidelines provided by the W3C on complex images.
Observed Behavior
The following screenshot of the source code illustrates how the image will be rendered at the moment.

Hi @StfBauer The issue has been fixed and rolled out to PROD. thanks for contacting.


Support tag deletion for draft releases

Hello,
Is it possible to expose an input draft-drop-tag, and support the deletion of draft-releases tags too?
(I have added a PR, trying to make it easier. )
Thank you

Hello, thank you for your PR, but there is one point that I think needs to be discussed.
The reason why there is no option to delete the draft tag is because if there are other releases on the tag where the draft is located, when the tag is forcibly deleted, the other releases will be forced to convert to draft.
I think this is not an expected behavior.

It is a bit tricky decision, I can understand, but If the option keeps the original behavior (not deleting tags), I suppose it is on developer's decision to take this "risk"
In my case, I am facing the exact opposite problem, where I am using some release actions that needs to reference on tags, but need to pass some extra steps, that may reject it later, and your action was almost the only giving this functionality.
Please consider of this, and thank you again

I'd be happy to merge this PR if the decision was made to leave it to the developers at their own risk.
This action puts the deletion of draft in the last step. In this way, if the deletion of release and pre-release tags causes a draft, a cleanup-like operation can be performed at the end.
But if a new draft is generated after deleting the draft tag, should we continue to delete it recursively? Maybe adding this new feature cannot be as simple as adding a parameter.

Nice thought. As much I would like to think of it on a simple base,  I don't know what to propose over this


updateHostsFile.py Issue

This seems to be associated with the updated readme template and other commits included in the release yesterday. When running updateHostsFile.py, I get the following error right after it asks me if I want to exclude any other domains.
(Edited to keep long directory chains private)
Traceback (most recent call last):
  File "updateHostsFile.py", line 1803, in <module>
    main()
  File "updateHostsFile.py", line 304, in main
    update_readme_data(
  File "updateHostsFile.py", line 1245, in update_readme_data
    readme_data = json.load(f)
  File "/usr/lib/python3.10/json/__init__.py", line 293, in load
    return loads(fp.read(),
  File "/usr/lib/python3.10/json/__init__.py", line 346, in loads
    return _default_decoder.decode(s)
  File "/usr/lib/python3.10/json/decoder.py", line 337, in decode
    obj, end = self.raw_decode(s, idx=_w(s, 0).end())
  File "/usr/lib/python3.10/json/decoder.py", line 355, in raw_decode
    raise JSONDecodeError("Expecting value", s, err.value) from None
json.decoder.JSONDecodeError: Expecting value: line 1 column 1 (char 0)

As you can see, using python 3.10, and I  just freshly installed dependencies using the requirements.txt file.

Hi @bd-g thank you for raising this.
In our readme, in the Option 2: Generate it in your own environment section, it's stated that we support Python 3.5 and upwards for that.
Try this with Python 3.5+?

@bd-g we require python 3.5, at minimum.
I'm sorry maybe I was unclear about that?  What would you suggest we change in the readme so that's crystal clear?
Here's the History of Python Wikipedia article. Python 3.1 hasn't been supported for a full decade.  We don't support it either.

Perhaps you misread. I am using python 3.10 (ten), not 3.1 (one). I believe my point still applies.

Oh I'm sorry @bd-g that's a fair point and I misread that.

Does anybody have input on this?
Works fine with Python 3.9.10, which is what I use.

I can try and debug more to figure it out  when I have time -- just wanted to open the issue as soon as I noticed, even if I didn't have a solution yet

It actually works fine on CI with Python >=3.6 on latest Ubuntu, macOS and Windows: https://github.com/StevenBlack/hosts/actions/runs/1983250291
Must be something specific to your system :/

Hallo everyone, just a little tip: Look at the format or LINT of all your JSON files.
That error happens when a JSON file is not correctly formatted. An empty JSON file should actually have the content {}.
Stay safe and healthy!
\selfunilrys Reminder: Better handling of this.

Found the problem, stemming from a module dependency specifically for python 3.10 - thanks everyone!


[Feature]: Enable use of Appsmith icons

Is there an existing issue for this?

[X] I have searched the existing issues

Summary
I have a column that is editable via a button and the team would like it to have the pencil icon to show it is editable as for another (text) column. As it is a button I cannot check Editable so the icon doesn’t show up. Is there a way to add the Appsmith pencil icon to the beginning of my column name? I have managed to copy a special characters pencil in there but it is the incorrect pencil image (and points to right bottom corner instead of left bottom corner) and I haven’t managed to paste an actual image into the name field.
Why should this be worked on?
For consistency and to make it easier to use the app it would be good to be able to show what fields are editable by use of the pencil icon in the column name like the columns that are text editable. Better user experience and look of page

@sklug1 the icon that you are talking about is intended to show what columns have editable value.
I am assuming that you want this very icon on the column that has the action button,
But the challenge is that its an action column and nothing that can be edited.
But making the button label more descriptive be of any help for the end users?
Otherwise, please help me understand your use case better, Right now I dont understand why should we do this and what users will benefit from it
cc @dilippitchika @sbalaji1192

It is the visual aid that would be good for the users to be able to see at a glance which columns are editable. The button we currently have for this field is an editor's name which can be clicked on to assign a different editor, however new users to Appsmith may not realise what this is - our product manager who is running UAT testing suggested adding the same pencil image to the column to show it is editable.
Of course I realise that buttons may have other functionality and not always to edit so it would need to be an optional feature (perhaps with different icons) or that an image could be added to the text of the column field, which is what I was trying to do above but the pencil image that I could use doesn't match the Appsmith one.

@somangshu Do you think adding a property to display a user-chosen icon on the column headers would help here?

The action of the button may be to edit it by using a drop down or search
in a modal instead of directly editing the string. An edit icon would still
be appropriate to indicate clicking the button would lead to tan edit
action. A different icon could potentially be selected for other button
actions if you were to allow the user to choose which icon they attribute
to the column, so this could be helpful in multiple use cases , not just
mine, which is edit (and so the pencil icon would be good here)
On Thu, 9 Nov 2023 at 00:10, Somangshu Goswami @.***>
wrote:

@sbalaji1192
https://urldefense.com/v3/__https://github.com/sbalaji1192__;!!LBk0ZmAmG_H4m2o!ovwull7l7ESWjFpmE8DoURyN7bcjlLDo1Sdv0WpBGPmdUZIoMlYpt-FHXfs16K1mrC4LwLWM5ET4JhD4CAqpl9TN$
what I am trying to point is that the edit icon is to show which column is
editable, A column which as action buttons is not really editable, clicking
it may lead to other columns being edited, but not itself.
Please help me understand the use case If I am missing it.
—
Reply to this email directly, view it on GitHub
https://urldefense.com/v3/__https://github.com/appsmithorg/appsmith/issues/28024*issuecomment-1801863978__;Iw!!LBk0ZmAmG_H4m2o!ovwull7l7ESWjFpmE8DoURyN7bcjlLDo1Sdv0WpBGPmdUZIoMlYpt-FHXfs16K1mrC4LwLWM5ET4JhD4CJhRAeug$,
or unsubscribe
https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/A6TIFLTBB3FVCBV57E4NXOTYDOAGDAVCNFSM6AAAAAA56LUNNKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMBRHA3DGOJXHA__;!!LBk0ZmAmG_H4m2o!ovwull7l7ESWjFpmE8DoURyN7bcjlLDo1Sdv0WpBGPmdUZIoMlYpt-FHXfs16K1mrC4LwLWM5ET4JhD4CJlFO9tE$
.
You are receiving this because you were mentioned.Message ID:
@.***>

--
The information contained in this e-mail message and any accompanying files
is or may be confidential. If you are not the intended recipient, any use,
dissemination, reliance, forwarding, printing or copying of this e-mail or
any attached files is unauthorised. This e-mail is subject to copyright. No
part of it should be reproduced, adapted or communicated without the
written consent of the copyright owner. If you have received this e-mail in
error please advise the sender immediately by return e-mail or telephone
and delete all copies. Nine Group does not guarantee the accuracy or
completeness of any information contained in this e-mail or attached files.
Internet communications are not secure, therefore Nine Group does not
accept legal responsibility for the contents of this message or attached
files.

@somangshu Yes. I understand what you're saying.  I'm suggesting giving the option to show the user's icon of choice on the left side of the column for cases like this. I agree that we should re-use the pencil on the right side for anything other than indicating the editability of a data column.

@sklug1 i have a few questions

Have you tried using the select column type in the table to do this? Because what you are describing is similar to using a dropdown to edit the data? If you did, can you let me know why it doesn't work for you?
Regarding showing the edit icon on the column, i don't think it's standard for any table with actions to show that. Because having a button is indicator enough of an action that is going to happen outside of the table. If you plan to use this to perform an action outside the table, then i don't think an icon is needed.
You said that - however new users to Appsmith may not realise what this is - can you explain why you think this is the case, are your users already used to seeing the columns with edit icons have a button?

@sklug1 you can also choose to use an icon in the button itself to show that it's editable, by using the button column's properties as well

This column hold’s an editor’s name. By clicking on it a modal opens that
allows editor search by name or id and shows some other data relating to
the editor, a different editor can be selected and the name will then
populate this column entry.
It cannot be a free text field as it links to an entry in the editor table.
A drop down wouldn’t have all the info needed for us to select the correct
editor (some editors can have more than 1 id so multiple entries) although
perhaps with a concatenated listing it could be done.
Our users are new to Appsmith so seeing the pencil icon will give a clue to
the edit ability of that field. Yes a button implies some possible action
but not necessarily what that action is if it is not in the button text or
using an image. The pencil image for this field was suggested by a new user
to our app to make its editability clear.
On Thu, 9 Nov 2023 at 17:08, dilippitchika @.***> wrote:

@sklug1
https://urldefense.com/v3/__https://github.com/sklug1__;!!LBk0ZmAmG_H4m2o!rZoZzBTJK8bGoBkuP1Eeal5-Dxkd42gKjrHg2c7UbwHhps7ZAn7ATClzBXZc3Qw0VNCcSQ5J0JsabgRm3vj24gXK$
you can also choose to use an icon in the button itself to show that it's
editable, by using the button column's properties as well
—
Reply to this email directly, view it on GitHub
https://urldefense.com/v3/__https://github.com/appsmithorg/appsmith/issues/28024*issuecomment-1803219509__;Iw!!LBk0ZmAmG_H4m2o!rZoZzBTJK8bGoBkuP1Eeal5-Dxkd42gKjrHg2c7UbwHhps7ZAn7ATClzBXZc3Qw0VNCcSQ5J0JsabgRm3oiixdj5$,
or unsubscribe
https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/A6TIFLR2WZSIIPKIRNSEEYLYDRXMRAVCNFSM6AAAAAA56LUNNKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMBTGIYTSNJQHE__;!!LBk0ZmAmG_H4m2o!rZoZzBTJK8bGoBkuP1Eeal5-Dxkd42gKjrHg2c7UbwHhps7ZAn7ATClzBXZc3Qw0VNCcSQ5J0JsabgRm3uUFXoQb$
.
You are receiving this because you were mentioned.Message ID:
@.***>

--
Sara Klug
Data Engineer
[image: Nine]
A 1 Denison St, North Sydney, NSW, 2060
E @.***
--
The information contained in this e-mail message and any accompanying files
is or may be confidential. If you are not the intended recipient, any use,
dissemination, reliance, forwarding, printing or copying of this e-mail or
any attached files is unauthorised. This e-mail is subject to copyright. No
part of it should be reproduced, adapted or communicated without the
written consent of the copyright owner. If you have received this e-mail in
error please advise the sender immediately by return e-mail or telephone
and delete all copies. Nine Group does not guarantee the accuracy or
completeness of any information contained in this e-mail or attached files.
Internet communications are not secure, therefore Nine Group does not
accept legal responsibility for the contents of this message or attached
files.

@sklug1 does using an icon button solve the problem in this case?

No the button text is the editors name, if we used an icon we wouldn’t know
which editor is linked to each record, the button links to functionality to
change to a different editor.
On Thu, 9 Nov 2023 at 22:37, dilippitchika @.***> wrote:

[image: Screenshot 2023-11-09 at 5 06 54 PM]
https://urldefense.com/v3/__https://user-images.githubusercontent.com/19730984/281717698-af7664e7-74a6-4d69-bd5d-f2d76bf89086.png__;!!LBk0ZmAmG_H4m2o!oVRQnHgc3oGtTSroD8TQLif6_f46J6dwAk2WmsgTT_SgelnF9pSdgZthEfX6RoeMSOJUOYY88E-oKZMPIrCUkY0i$
@sklug1
https://urldefense.com/v3/__https://github.com/sklug1__;!!LBk0ZmAmG_H4m2o!oVRQnHgc3oGtTSroD8TQLif6_f46J6dwAk2WmsgTT_SgelnF9pSdgZthEfX6RoeMSOJUOYY88E-oKZMPIv-lR8p2$
does using an icon button solve the problem in this case?
—
Reply to this email directly, view it on GitHub
https://urldefense.com/v3/__https://github.com/appsmithorg/appsmith/issues/28024*issuecomment-1803667905__;Iw!!LBk0ZmAmG_H4m2o!oVRQnHgc3oGtTSroD8TQLif6_f46J6dwAk2WmsgTT_SgelnF9pSdgZthEfX6RoeMSOJUOYY88E-oKZMPIrhA6X66$,
or unsubscribe
https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/A6TIFLXBFPQFFT5EDOVI76TYDS6ANAVCNFSM6AAAAAA56LUNNKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMBTGY3DOOJQGU__;!!LBk0ZmAmG_H4m2o!oVRQnHgc3oGtTSroD8TQLif6_f46J6dwAk2WmsgTT_SgelnF9pSdgZthEfX6RoeMSOJUOYY88E-oKZMPIhIpfTtV$
.
You are receiving this because you were mentioned.Message ID:
@.***>

--
Sara Klug
Data Engineer
[image: Nine]
A 1 Denison St, North Sydney, NSW, 2060
E @.***
--
The information contained in this e-mail message and any accompanying files
is or may be confidential. If you are not the intended recipient, any use,
dissemination, reliance, forwarding, printing or copying of this e-mail or
any attached files is unauthorised. This e-mail is subject to copyright. No
part of it should be reproduced, adapted or communicated without the
written consent of the copyright owner. If you have received this e-mail in
error please advise the sender immediately by return e-mail or telephone
and delete all copies. Nine Group does not guarantee the accuracy or
completeness of any information contained in this e-mail or attached files.
Internet communications are not secure, therefore Nine Group does not
accept legal responsibility for the contents of this message or attached
files.

Ok so in this case then if we also supported adding icons in the button column type, just like our button widget would that have helped?

It could help, though it would look less cluttered to have one icon at the
top in the column name
On Fri, 10 Nov 2023 at 16:16, dilippitchika @.***>
wrote:

Ok so in this case then if we also supported adding icons in the button
column type, just like our button widget would that have helped?
[image: Screenshot 2023-11-10 at 10 44 15 AM]
https://urldefense.com/v3/__https://user-images.githubusercontent.com/19730984/281964402-fa1e257b-9fda-4d81-a68d-66adb93e76f8.png__;!!LBk0ZmAmG_H4m2o!vl3k-Wg0LjwBX2tDc40UoY4cmqjyaG_YpBZW0-GLzASVKzA6_BQsplfyayLggGfACt0YPw1O_gnbr8YNOreM9n4w$
—
Reply to this email directly, view it on GitHub
https://urldefense.com/v3/__https://github.com/appsmithorg/appsmith/issues/28024*issuecomment-1805101281__;Iw!!LBk0ZmAmG_H4m2o!vl3k-Wg0LjwBX2tDc40UoY4cmqjyaG_YpBZW0-GLzASVKzA6_BQsplfyayLggGfACt0YPw1O_gnbr8YNOg7-u9Ek$,
or unsubscribe
https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/A6TIFLTLFU2YCDMZ6SVISDDYDW2BDAVCNFSM6AAAAAA56LUNNKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMBVGEYDCMRYGE__;!!LBk0ZmAmG_H4m2o!vl3k-Wg0LjwBX2tDc40UoY4cmqjyaG_YpBZW0-GLzASVKzA6_BQsplfyayLggGfACt0YPw1O_gnbr8YNOmr_O449$
.
You are receiving this because you were mentioned.Message ID:
@.***>

--
The information contained in this e-mail message and any accompanying files
is or may be confidential. If you are not the intended recipient, any use,
dissemination, reliance, forwarding, printing or copying of this e-mail or
any attached files is unauthorised. This e-mail is subject to copyright. No
part of it should be reproduced, adapted or communicated without the
written consent of the copyright owner. If you have received this e-mail in
error please advise the sender immediately by return e-mail or telephone
and delete all copies. Nine Group does not guarantee the accuracy or
completeness of any information contained in this e-mail or attached files.
Internet communications are not secure, therefore Nine Group does not
accept legal responsibility for the contents of this message or attached
files.

I apologise but i think it's a wrong design pattern to use, the icon on top resembling editability for something that's not directly editable in the table is not the pattern which enforces consistency.
While i agree that have icons on top will help you configure an icon specific to the column, we would not provide the same icon that Appsmith has been using because this gives an incorrect impression to users. If you have an existing design or a table where you have done this, can you please share a screenshot?

Since this one doesn't make sense from the product and design perspective, I am closing it.


Clean up Dashboard and change directory structure

@ttonyan10 -- I'd like to apply some cleanups to the dashboard, similar to the ones I applied to the authentication related pages, but don't want to create too many merge conflicts for you. I'll work on other things and plan on applying them whenever you're at a good stopping point. (No rush.)
Also, I was thinking about changing the directory structure to something a little more organized. Is that okay with you? I was thinking something below. The benefits I see are that it clearly separates the pages from the partials and libs, and embeds page-specific less files in the same directory as the related html file.
- src
   + app
   + images
   - libs
      - auth
         - auth.module.js
         - authApi.service.js
      + core
      + properties
      + users
   - pages
      - dashboard
         - dashboard.controller.js
         - dashboard.html
         - dashboard.less
         - dashboard.module.js
         - dashboard.routes.js
      + login
      + logout
      + register
      + user-movies
   - partials
      + nav
   - styles
      - common.less
      - mixins.less
   - index.html

I cleaned up the dashboard. Let's leave the directory structure as-is for now.


Improve execution time of should_pass E2E tests

Description
This PR improves the execution time of should_pass E2E tests by making ~33% of them use a stripped-down version of the std library.
This approach brings noticable speed gains as demonstrated in the below comparison table.
(The tests are executed on my local machine in Rust release and Sway debug build. Running them in Sway release build brings additional but small gain.)

Test filter
Before (mm:ss)
After (mm:ss)

should_pass/language/
14:26
04:23

should_pass/language/references
04:10
00:56

should_pass/language/main_args
01:10
00:12

should_pass/language/match
00:57
00:09

should_pass.*enum
00:51
00:28

The improvement approach is based on the following observations:

most of the time in should_pass tests is spent on compiling std.
out of ~480 should_pass tests, ~160 use std just because of assert.
in addition, ~10 tests need Option and/or Result.

Thus, the PR provides two stripped-down versions of the std, one containing only support for assert, and another one containing assert and Option and Result. The compilation time of those two libraries is negligible compared to the compilation time of the whole std.
This apporach is:

easy to use and enforce in new tests
compatible with whichever solution for running tests in parallel we come up with
trivial to remove once we implement incremental compilation or caching of std in tests

Therefore, proposal is to use this approach for the time being to improve the efficiency of our inner loop.
Checklist

[ ] I have linked to any relevant issues.
[x] I have commented my code, particularly in hard-to-understand areas.
[ ] I have updated the documentation where relevant (API docs, the reference, and the Sway book).
[x] I have added tests that prove my fix is effective or that my feature works.
[ ] I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
[x] I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
[x] I have requested a review from the relevant team or maintainers.

I do have some long-term concerns about duplicating the libraries code

Me too! Duplicating and running out of sync is definitely a concern. Having something like cargo features is of course the long term feature great to have. For the tests, I was thinking about a simple approach where the std code is not duplicated and checked in, but for each reduced version of the lib simply copied over locally (not checked in) before test start, based on a simple config file. Only the strip down lib.sw and prelude.sw should be checked in. I might play with this a bit in the second step.


tests: Fix checking the version of 'rpm'

The version numbers of 'rpm' are not always just numbers. A 'beta' might
show up here and there, for example, which will make the int conversion
fail.
In order to fix this, use simple string comparison to tell if the
current installed version of 'rpm' is lower than '4.16'.
Signed-off-by: Hunor Csomortáni<EMAIL_ADDRESS>

nice, rawhide is passing now

rebased so we can get less test failures now


Test hnsw index prepare_add_document and find_top_k with missing tensor.

@geirst : please review

This tests the fix in https://github.com/vespa-engine/vespa/pull/30992.


Upgrade to Transformers v4.31

What does this PR do?

Updating to Transformers v4.31 is needed because Transformers' Trainer now relies on Accelerate. So this PR adapts the required tools from Accelerate to make them compatible with HPUs.
Before submitting

[ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
[ ] Did you make sure to update the documentation with your changes?
[x] Did you write any new necessary tests?

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


Testing: empty space context menu

Refs: https://github.com/microsoft/vscode-python/issues/17040
Currently when you context menu into an empty area in the testing view nothing happens.
I suggest to have a context menu with some global actions. Here are some candidate:

Run All Tests
Debug All Tests
Refresh Tests
Unhide All Tests
Clear All Results

For simpler projects the empty area can be quite large and I think we should use it.

Haven't really heard others wanting this, will close for now


Marathon package should construct zk url using marathon.zk and marathon.framework-name

To guarantee that the Marathon zk node is unique we should construct the url as follow: --zk {{marathon.zk}}/{{marathon.framework-name}}. We were doing this in revision 2 of the package but was changed when we moved to revision 3. Does anyone remember why?
cc @kolloch @aquamatthias

@jsancio - it looks like this might be a bug. @aquamatthias is working on a tool to generate Marathon DCOS app configs and we can re-assess this with that.

Sorry team, just couldn't bear to wait: https://github.com/mesosphere/universe/pull/273

This is fixed in #268

#268 is not yet available, and users are reporting issues while trying to follow the official docs. We need to merge this to make it work until #268 is available.

I just did an install of marathon in version-2.x and by default it took over the universe znode. It should do that ideally by default is should use universe/marathon-user
cc @aquamatthias

@jsancio what is the story about version 2? When will it be the default? We currently only maintain version 1.

As far as I see you created version 2

@aquamatthias version-2.x will become the default after 1.6.1 (when we release Cosmos). I created version-2.x for Marathon for you. I did this by copying the latest Marathon package and refactoring it to conform to the version-2.x spec.

Assigning back to you. Let me know if you need anything from me.

So what is the schedule for 1.6.1?


configure script should detect if compiler is not c++17

I checked out the master branch and ran configure and it succeeded.
However, make failed because my compiler was not c++17.
The configure script should be written to detect whether it has a c++17 compiler.

We require C++17 now on master and for all 8.x releases.  You will need to upgrade the compiler to gcc7 or clang5.


Allow zero length arrays as bodies

This change should allow zero length arrays as bodies without converting them to undefined

pushed as beta<EMAIL_ADDRESS>


Recipe using lava bucket fails with lava fluid in storage

Issue description:
Crafting won't recognize lava fluid in place of lava buckets. That was one of the major new features with 1.6, I believe?
What happens:
Trying to make a Mekanism Crusher (default recipe). I added the pattern, which uses lava buckets, to the reborn storage crafting unit.
When trying to actually initiate a craft, the systems says I have no lava buckets available. However, when looking in my fluid monitor it says I have 50+ of lava.
What you expected to happen:
It should recognize the lava instead of an actual lava bucket.
Steps to reproduce:

Add pattern with lava bucket recipe
Import lava into fluid disk
Try crafting

Version (make sure you are on the latest version before reporting):
Minecraft 1.12
RebornStorage-1.12.2-<IP_ADDRESS>
RebornCore-1.12.2-<IP_ADDRESS>4-universal
refinedstorage-1.6.3
forge-1.12.2-<IP_ADDRESS>05-universal (Current 1.12 recommended)
Does this issue occur on a server? Yes

that system has been replaced
read the wiki
thank you

My bad, thanks.
I assumed the autocrafting would recognize the liquid without a processing pattern. However, I'm still not clear because the wiki says the processing pattern needs an input of "one empty bucket, 1000 mB of the fluid of your choice". Are those meant for one pattern? I don't know how to set an item and a fluid into the same pattern.
Also, this appears to require a third party "bottling" machine, so I need that before this will even work, correct?

those are meant for one pattern
you can toggle between fluid and item mode in the pattern grid
and you will need a bottling machine indeed


Requiring unknown module "Reflux" error with react native on windows

I am getting the title mentioned error on windows with reflux 0.3.0 and react native 0.13.2. Please suggest how to solve this?

Typo in my own code. Fixed now. Thanks


OP-16544: setting header strict-transport-security: max-age=31536000.

https://devopsmx.atlassian.net/browse/OP-16544

This PR  triggered this build in this execution, please wait for it  and child pipelines to succeed before merging:  https://isd.prod.opsmx.net/deck/#/applications/gcp-gitprtrigger/executions/details/01G94YK2VY7YJQZC81BJMCBS7R

This PR  triggered this build in this execution, please merge to v4.0 branch only if this succeeds:  https://isd.prod.opsmx.net/deck/#/applications/isd40/executions/details/01G94YM3X5CSQKR8VE08W06Z27

RunTestJar RESULT: Tests run: 229, Failures: 14, Errors: 0, Skipped: 29, Time elapsed: 446.664 sec <<< FAILURE! Reviewers , please check that the changes in this PR did not cause the failures in  http://jenkins.opsmx.net:8181/jenkins/job/Dev-API-Automation-Test-v4.0/ws/emailable-report-178.html


Smoother transitions between levels

Right now the transition from one level to another is very abrupt, especially if you aren't looking at the countdown clock. Would it be possible to add some sort of modal showing that you beat the level, and maybe even the amount of points you gained from that particular level? I'd be glad to open a PR for it.

@wwatkins09 Great idea, perhaps the modal could be on a timer so that it displays for 3 seconds before opening the new level.
Any issues just leave a comment.

Completed by @wwatkins09


Rewrite traffic_layout with ArgParser

This is the first trial using ArgParser. It turns out traffic_layout is super clean and more understandable. There are 250 lines less than the previous messy code. It's also easier for people to maintain this code in the future.
Note: runroot_path.yml is changed to runroot.yaml.

Any other concerns?


Error running tests for the first time

With a clean install, I run into this error when running tests:
~/opt/src/railsgoat$ bundle exec rake test
rake aborted!
LoadError: cannot load such file -- rails/performance_test_help
/home/me/opt/src/railsgoat/.direnv/ruby/gems/activesupport-4.2.8/lib/active_support/dependencies.rb:274:in `require'
/home/me/opt/src/railsgoat/.direnv/ruby/gems/activesupport-4.2.8/lib/active_support/dependencies.rb:274:in `block in require'
/home/me/opt/src/railsgoat/.direnv/ruby/gems/activesupport-4.2.8/lib/active_support/dependencies.rb:240:in `load_dependency'
/home/me/opt/src/railsgoat/.direnv/ruby/gems/activesupport-4.2.8/lib/active_support/dependencies.rb:274:in `require'
/home/me/opt/src/railsgoat/test/performance/browsing_test.rb:2:in `<top (required)>'
...

I was able to get past this error by adding gems rails-perftest and ruby-prof. (https://github.com/rails/rails-perftest). However, there's another error after this one:
$GEM_HOME/ruby-prof-0.16.2/lib/ruby-prof/printers/call_tree_printer.rb:46:in `print': wrong number of arguments (given 2, expected 0..1) (ArgumentError)
	from $GEM_HOME/rails-perftest-0.0.7/lib/rails/perftest/active_support/testing/performance/ruby.rb:54:in `block (2 levels) in record'
...

This has me wondering if the performance tests are worth keeping, or perhaps they should be tagged in someway so they aren't run in Rails 4, for now.

For some reason I never saw this issue opened until today while going in and trying to do clean-up. So sorry @wobh but did you find your answer?

@wobh Poking one more time before closing, thanks!

Sorry! I did not find an answer. I became rather busy with other things and forgot all about it. I'll circle back to this soon, I hope.

I'm the one who is sorry 😄 (as I missed this issue for nearly 2 months). Thank you!

I'm the one who is sorry 😄 (as I missed this issue for nearly 2 months). Thank you!

@cktricky - Was able to reproduce by "bundle exec rake test".
Note that "test/performance/browsing_test.rb" is not run by default.
Should we remove it or fix the repo to run it cleanly?

Hey @jasnow I'm trying to see if I can just fix it. Mainly in the case someone decided they wanted to use this functionality in the future - figured it'd make sense to try and get it working rather than removing. Consider it "In progress".

@wobh and @jasnow I've resolved this issue on both the Rails 4 and 5 branches. Thanks for your help!


Maierson patch 1

Move state flag to left and space out table title for enhanced readability
Motivation
Anchor the state awareness visually beyond reading the state name.
Enhance reader's awareness of each state flag.
Changes
Move background image to left of header
Add padding to offset the title text.
Increase line-height slightly to separate title from description.
Motivation
Changes

[x] Ensured that you have rebased your branch with this repo's latest master branch.
[x] Ensured that relevant issues are linked, if this PR resolves any outstanding.
[x] Added a screenshot for all UI changes (you can drag the file into this edit box and it will be uploaded).
[x] Ensured that changes to auto-generated files have not been committed; in particular, *.html, *.csv, *.xml and *.json files.

We're pretty firm on wanting the state flag on the right where it is. If you'd like to provide a screenshot of the other changes you're suggesting (before/after), we'll take a look.


Request to update tools

https://github.com/skylot/jadx/releases/tag/v1.4.7
https://github.com/pxb1988/dex2jar/releases/tag/v2.4
It seems that there are newer versions of the above tools. Could you please follow up on these updates?

BTW, https://github.com/apk-spectrum/apk-spectrum-core/tree/master/src/main/resources/icons/logo
The resolution of r.png and subsequent logos seems not to be 150x150, and the overly large images seem to cause display errors.

I updated tools.
I also fixed the layout issue in the apk-scanner project.(72d0b22)


Improving Cranelift's IR generation

Motivation
Cranelift's IR went through a huge overall from the original python generator to one written in Rust. This has made it easier to work on it as we're using the same language to generate the code that used in the rest of the project. However it is still not ideal in terms of contributing new instructions or changing existing instructions as it is not clear what steps are required, and which parts of the meta code generator need to be modified to correctly add an instruction.
This could be partially solved by providing better documentation, however documentation doesn't improve the experience of contributing to the codebase itself, and documentation is likely to fall out of date as time goes on similar to the current situation, as there's no strict link between an instruction and its documentation besides what's available in InstBuilder.
Instead I would like to propose rewriting at least some of the meta code generator with a greater focus on data locality, so that if someone wants to contribute to the IR, the number of overall steps is reduced. This should also help with documenting the IR format, as the documentation can be more closely coupled.
Proposed Solution
I would like to propose something along the lines of using a data format to encode information about a instruction and how it is encoded. I've used YAML to illustrate what this could look like, though I'm not advocating for the use of YAML specifically.
---
name: jump
doc: >
    Jump.

    Unconditionally jump to an extended basic block, passing the specified
    EBB arguments. The number and types of arguments must match the
    destination EBB.
attributes:
    - terminator
    - branch
operands_in:
    - Ebb # This would also imply `args`
encodings:
    # Encode from recipe
    x86:
        recipe: x86_JMP
    # If this was YAML specifically you could use anchors for recipes. e.g.
    x86:
        << *X86_JMP
    # Or encode directly
    riscv:
        emit: >
            let dest = i64::from(func.offsets[destination]);
            let disp = dest - i64::from(sink.offset());
            put_uj(bits, disp, 0, sink);

The main advantage to this approach is that moves the current imperative style of cranelift-codegen into something that is more declarative and data oriented. To me this provides more clarity around how a instruction is defined and used, if you wanted to create a new instruction one could simply copy and paste from another already working instruction.
Drawbacks
While the goal of this proposal is to simplify working on the IR language itself it could make the underlying meta code more complex, as well potentially increasing the compile time to build cranelift-codegen since there would now be a deserialisation step that wasn't there before.
Alternatives
Instead of changing the system there could be a greater focus on building resources for contributing to cranelift that try to explain how to use the current system.

I think now we are discussing pretty much the same thing in bytecodealliance/rfcs#15.

Not exactly, this is also about cranelift ir instruction definitions, while ISLE is only about lowering of instructions.


chore: replace lazy_static with once_lock and remove lazy static

This change is

#353  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ArniStarkware and the rest of your teammates on  Graphite

Codecov Report
Attention: Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.

Project coverage is 82.29%. Comparing base (1d8b65f) to head (0364a03).

Files
Patch %
Lines

crates/gateway/src/gateway.rs
83.33%
1 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #353      +/-   ##
==========================================
+ Coverage   82.12%   82.29%   +0.16%
==========================================
  Files          32       32
  Lines        1589     1604      +15
  Branches     1589     1604      +15
==========================================
+ Hits         1305     1320      +15
  Misses        219      219
  Partials       65       65

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


also detect Azure CI environments

Cc @sunjay

@bors r+

:pushpin: Commit ebc3b718818c27a5061c2f2da31f9ef7e4d6851d has been approved by RalfJung

:hourglass: Testing commit ebc3b718818c27a5061c2f2da31f9ef7e4d6851d with merge 8b4b0b4a54a9614d3e1f8fda66bd48aae68b68b9...

:sunny: Test successful - checks-travis, status-appveyor
Approved by: RalfJung
Pushing 8b4b0b4a54a9614d3e1f8fda66bd48aae68b68b9 to master...

Thanks @RalfJung! 🎉


feat: c extension support

Overview

[!NOTE]
WIP.

Adds support for the RVC extension, which is preferred by the most heavily supported RISC-V targets in rustc. More information can be found in the working document, which I'll update along the way of implementing support.
TODO

[x] Assess supported c extension instructions for asterisc

Pretty much everything but FP ops. See the hackmd.

[x] Decoding logic for various c extension instruction types.
[x] Encoding logic for various base ISA instruction types.
[x] Adjust program counter incrementation based on instruction size.
[x] Instruction decompressor in fast package

[ ] Port to rvsol and slow

[x] RISC-V standard c extension tests
[x] Decompressor tests
[x] Rust minimal example

[ ] New syscalls

[ ] Document Rust / glibc / llvm syscall usage for RISC-V linux targets.

[ ] symbol patches

[ ] Final cleanup; Delete scripts, etc.

Going ahead and closing this for now. We initially needed this for Rust code running on Asterisc, but found some targets that don't render c extension instructions.
If we ever need to revisit, will keep the branch intact.


Getting Started Guide: no instructions on troubleshooting diesel-cli install.

In the getting started guide, the user is instructed to cargo install diesel_cli. However, this requires headers for libpq, libsqlite3, and libmysqlclient. It would be awesome if there was documentation of this. I'd submit a PR, but I don't know where the repo is for that web page.

The repo is here https://github.com/sgrif/diesel.rs-website

Duplicate of https://github.com/diesel-rs/diesel/issues/588

Indeed. Resolved by sgrif/diesel.rs-website#29.


struct _key_fntable_int incompatible with memory leak detectors

Most memory leak detectors redefine the "free" function (and others).
The struct _key_fntable_int contains the following:
void (*free)(cjose_jwk_t *);
This clashes with a redefintion of "free".
Is it possible to rename this field (like "free_func")?
Thanks

This won't be a problem for normal memory leak detectors, unless they redefine free in the preprocessor stage, which, I imagine, will wreak all kinds of havoc. Leak detectors (i.e. valgrind, are there others that are used actively?) substitutes symbol tables (or doing something of the sort), this will neither affect local symbols nor structures fields (those aren't even exposed as symbols after compilation).
Which memory detector are you having problems with?

Several memory detectors do indeed define free (and malloc, alloc, ...) to add the filename & line number to the info. One concrete example is the Microsoft one integrated to Visual C++. And I met several others also.
As this change is trivial and cannot break anything, it's a (very) quick win.

this is now part of the maintenance fork here:
https://github.com/zmartzone/cjose/tree/version-0.6.2.x


Kong plugin CI environment

Would be great if you could open source the kong-ci repository that is being used here. That repository plus the travis config could then become the standard way to test third-party plugins. Perhaps there could be an advanced version of the kong-plugin template that includes this travis build setup.
This kong-ci repository:
https://github.com/Kong/kong-plugin-prometheus/blob/master/.travis.yml#L49

ping @hutchic

@peter-evans https://github.com/Kong/kong-build-tools/pull/27 is landing soon which I hope will give a Kong / kong plugin development environment. Feel free to grab the branch and give it a run if you like

@hutchic Great! I'll take a look. Thank you.


Update to use new module system

Consume new /sdk and /pkg modules from pulumi/pulumi
Split this repo into a multi-module repo so that pulumi/pulumi-azure/sdk can be imported without bringing in core pulumi/pulumi/pkg dependencies.

This still has a local replace on tfbridge as this change is blocked on https://github.com/pulumi/pulumi-terraform-bridge/pull/134

@EvanBoyle this looks great! thanks for this - works for me locally as well


#1649 Reuse query counters

This PR stores the query counters in a HashMap and reuses them when processing messages instead of registering query counters in every transform. According to the benchmark report, query_counter_pre_used gains 14% improvement thanks to the faster transform.

Progress towards #1649

nice work! lets land this.
I think that if we ever want to further improve performance here, the best way would be to make redis_query_name return a new enum named RedisCommandType and then have a to_str() method on that enum. That way we can make this work completely with &'static str and other usages of redis_query_name across the codebase would also be able to avoid the allocation. But again, I think we've hit the sweetspot of how much time to spend on this problem since this will resolve the performance impacts that are being warned about in the new metrics release.

Yeah sounds good. We can probably change redis_query_name to improve performance opportunistically in the future. Do we want to raise an issue for it just for tracking purpose?

I think just leave it, better in general to let performance work be driven by observed issues in the system rather then guessing which parts of the system are going to end up as the bottleneck.
I consider this work an exception since we had a warning pointing out a potential issue, better to resolve it then just ignore it.


Default permissions on IPC endpoints are weak

We should default to the most restrictive permissions that still allow the endpoint to be used.

This was fixed in #28? So maybe the issue is done?
Can we maybe get a release with this fix? We want to use the library with the stricter permissions. Thanks.


⚠ SceneTime has degraded performance

In 6cc4ac4, SceneTime ($ST) experienced degraded performance:

HTTP code: 200
Response time: 1545 ms

Resolved: SceneTime performance has improved in 9e55a63 after 6 minutes.


[Bug]: JSEditor | JSObject with async & sync functions throws random error toast

Is there an existing issue for this?

[X] I have searched the existing issues

Description
https://github.com/appsmithorg/appsmith/assets/91450662/37ca058b-4347-44fd-95ee-2c333bb71906
Steps To Reproduce

Create a new JS Object with below:

     myVar1: [],
     myVar2: {},
     myFun1: () => {	},
     myFun2: async () => {	},
     myFun3: async () => {	},
     myFun4: async () => {	},
     myFun5: async () => {	},
     myFun6: async () => {	},
     myFun7: () => {	},
   }```

Move to settings page to verify the async settings of the async functions
Observe the async functions are all not showing plus there is random error toast 'JSObject1.myfun5 already exists'
Expected: User should have smooth experience in creating the async, sync functions in JSEditor

Public Sample App
No response
Environment
Production
Issue video log
No response
Version
Cloud/Release v1.9.59

Run details Workflow link. with docker logs if it helps
dockerlogs.zip

Similar Bug reported here

not reproducible anymore, maybe it got fixed along with another PR.
https://github.com/appsmithorg/appsmith/assets/94514895/87ec57de-5775-40f2-b56b-981c6c7b930b


Update CI based package publishing

Codecov Report

Merging #12 (fa5a7ae) into main (e8f6960) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main       #12   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            7         7
  Lines          338       338
=========================================
  Hits           338       338

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8f6960...fa5a7ae. Read the comment docs.


fix: scientific notation with negative exponents

Also added a few new tests. Patches #7.

Pull Request Test Coverage Report for Build 16

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 14:
0.0%

Covered Lines:
37

Relevant Lines:
37

💛  - Coveralls

Thank you for your help!

Happy to help! I think that you can also close #7.


Kafka Indexing Service in 0.10.1 requires Kafka brokers upgrade to 0.10.X

Just wanted to create an issue so that it is mentioned in the release notes.

The PR already has release notes tag so closing this one


Improved installation process

CouchDBSample's main.swift now creates a connection on port 5984, the default port used by CouchDB upon install.
Changed the name of the default database which Kitura tries to connect to: kitura_test_db. The README.md is also updated to mention that a database with this name needs to be created.
The README.md has updated and more thorough installation instructions.
Improved error logging with HeliumLogger.

@shmuelk Please review this so it can be merged.

The change to ConnectionProperties, making userid and password required fields with the changes that followed, will cause the API to fail on a server that doesn't have security enabled.
Please change that part back to the way it was.
The rest is very good.
Thanks for your efforts in improving our CouchDB APIs

@shmuelk Can you point me to where this failure is happening so that I can better understand the issue?

The URL created by:
// CouchDB URL
var URL: String {
return "(HTTPProtocol)://(username):(password)@(host):(port)"
}
Will only work iff there actually is a userid and password. If I am running a local server, I may not want to activate security, yet you are forcing it. The old code build the URL differently depending on whether or not there was a userid and password.

@shmuelk Please review latest changes. Thanks!

A couple of questions on the latest changes to: CouchDBSample:

Why did you remove the userid and password parameters? They should be made optional.
Why did you hard code the host instead of getting it as a parameter?

I think the number of parameters should be either one or three (i.e. always with a host and with or without a userid and password pair).

From this comment:
// Parse runtime args... this is just an interim solution
It appeared that the previous runtime arguments were just a temporary solution. There was no mention of what they were a temporary solution to, so if there is a strong reason for accepting runtime arguments then please let me know and I can change that part back.
As an outsider, it's not 100% clear to me what the blueprint is, so some more documentation or comments would be very much appreciated so that I don't accidentally break some un-documented requirement.
Thanks.

@shmuelk can you help me get this merged?

Merged into develop in the commit https://github.com/IBM-Swift/Kitura-CouchDB/commit/6c1725112bcdd008e0d747df47d859fe3e1c52fc


DNS Modify records

We have the ability to replace records (if they exist), but we also want to be able to modify an existing record. For instance, we want to be able to update the ttl without caring what data. Currently, we need to do something like this:
existing_mx_record = zone.records(name: "example.com.", type: "MX").all.first
updated_mx_record = existing_mx_record.dup
updated_mx_record.ttl = 3600 # change the TTL
zone.update updated_mx_record, existing_mx_record

We would prefer it be this instead:
zone.modify "example.com.", "MX" do |mx|
 mx.ttl = 3600 # change the TTL
end

Closed by PR #321


Changes from Elizabeth

:

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

This PR is closed as it was superseded by the changes made for the 1.25 release.


File path recognition and parallel processing

This is a possible bug. See Yesterday's google group post by Kenn.
File recognition may not work efficiently when doing parallel processing and encountering specific file path names and/or when dealing with files that do not generate output.
TO DO:

Verify that getfolderstructure.R works correctly even when files are missing or when directory paths have names that overlap with the extensions we look for.
In line with this check whether the corresponding unit test covers this functionality.

Update: Kenn was working with object filename_dir which is stored by g.part1 but not actually used anywhere in GGIR, and g.part1 itself uses objects fnames and filename the latter is use in the RData filename.
Unrelated to this the code for filename identification is fairly old and could benefit from some refactoring. For example,
apply(X = as.matrix(fnamesfull),MARGIN = 1, FUN = f16) can probaly be replaced by a simple basename() call.
Action points:

[ ] Replace filename_dir value by actual full filename.
[ ] Refactor code to be more readable and covered by unit tests.


Cpu utilization on an unused cluster varies over time

Here's a plot of CPU utilization on a cluster where no actions are performed:

The cluster was 4 nodes + master, n1-standard-1 each.
After I restarted the cluster, I played with it a bit. But certainly, there were no operations between May 23 and May 25.
The CPU spikes are visible on 2 nodes only (the other two have flat CPU usage plot)

The issue must have been fixed. Now a fresh unused cluster uses up about 8% of CPU.


Testing upload within graphql-ruby

Hi :wave:
I'm trying to write tests for my rmosolgo/graphql-ruby project, and I don't know how I can prepare a file to be passed as variables to MySchema.execute within a rspec example, so I can test my upload mutation.
I tried looking at the specs of this project, but had no luck.
I also asked there: rmosolgo/graphql-ruby#2146 with some more details.

Hi @guyzmo
Try this Rack::Test::UploadedFile.new("path/to/file.ext", "mime/type")

it works, thanks 🙌


Configure K3s cluster so it can be switched between LAN use and 4G LTE

So... this is something I haven't really done on a more automated basis before.
Basically, my LAN (with Spectrum Internet) has DHCP configuring IP addresses in the 10.0.100.x range. My LTE modem is currently configured in the 192.168.0.x range (and I'm loathe to change that—since it's someone else's, and I'm just borrowing it. Though I could.)
What I would like to do is make it so I could plop down the cluster on any network with any private IP range, and the master/control plane IP could change, and any/all of the node IPs could change, and everything would still work.
Judging by this issue, if node IPs change, a simple restart of the k3s-agent is all that's required, and the node should rejoin the control plane afterwards.
But what about the master/control plane? What do I need to do when it's IP address changes?

Another option is to always have the nodes set up through a virtual network with node 1 acting as a router, and keep their IP addresses persistent no matter what node 1 is connected to as a gateway.
That might ultimately be the easier approach, though for non-Turing-Pi-2 clusters that could artificially limit bandwidth to the speed of the router.

On my home network:
root@turing-node-1:/home/pi# kubectl get nodes -o wide
NAME            STATUS   ROLES                  AGE   VERSION        INTERNAL-IP      EXTERNAL-IP   OS-IMAGE                         KERNEL-VERSION   CONTAINER-RUNTIME
turing-node-2   Ready    <none>                 40h   v1.22.5+k3s1   <IP_ADDRESS>     <none>        Debian GNU/Linux 11 (bullseye)   5.10.63-v8+      containerd://1.5.8-k3s1
turing-node-4   Ready    <none>                 40h   v1.22.5+k3s1   <IP_ADDRESS>     <none>        Debian GNU/Linux 11 (bullseye)   5.10.63-v8+      containerd://1.5.8-k3s1
turing-node-3   Ready    <none>                 40h   v1.22.5+k3s1   <IP_ADDRESS>     <none>        Debian GNU/Linux 11 (bullseye)   5.10.63-v8+      containerd://1.5.8-k3s1
turing-node-1   Ready    control-plane,master   41h   v1.22.5+k3s1   <IP_ADDRESS>   <none>        Debian GNU/Linux 11 (bullseye)   5.10.63-v8+      containerd://1.5.8-k3s1

After unplugging Turing Pi from home LAN and plugging into Cradlepoint on 192.168.0.x:
TODO

There is k3s server --bind-address [ip address here], but that's not super flexible and dynamic.
It seems like the best solution is to make sure the control plane's IP address is static.

So... yeah. Gonna just bypass this and use static IPs with the Pis running in their own little segregated network: https://github.com/geerlingguy/turing-pi-2-cluster/issues/9

Reopening because I still need to set up the switching. As of #9, I have the first node set up as a router, but it's defaulting to route through wlan0 and not usb0. I need to set something up so it will switch through usb0 instead.

I can confirm I can see:
pi@turing-node-1:~ $ sudo iptables -t nat -L
Chain PREROUTING (policy ACCEPT)
target     prot opt source               destination

Chain INPUT (policy ACCEPT)
target     prot opt source               destination

Chain OUTPUT (policy ACCEPT)
target     prot opt source               destination

Chain POSTROUTING (policy ACCEPT)
target     prot opt source               destination
MASQUERADE  all  --  anywhere             anywhere

I want to make sure if I switch active_internet_interface, it switches Internet access and routing over to usb0 instead of wlan0.

Switched it, re-ran the playbook, and now am re-testing everything (with admittedly poor antenna location:
# From node 1
pi@turing-node-1:~ $ speedtest-cli
Retrieving speedtest.net configuration...
Testing from Amazon.com (<IP_ADDRESS>)...
Retrieving speedtest.net server list...
Selecting best server based on ping...
Hosted by Liberty Connect (Joplin, MO) [1503.87 km]: 216.842 ms
Testing download speed................................................................................
Download: 5.51 Mbit/s
Testing upload speed......................................................................................................
Upload: 0.77 Mbit/s

# From node 3
pi@turing-node-3:~ $ speedtest-cli
Retrieving speedtest.net configuration...
Testing from Amazon.com (<IP_ADDRESS>)...
Retrieving speedtest.net server list...
Selecting best server based on ping...
Hosted by Liberty Connect (Joplin, MO) [1503.87 km]: 185.314 ms
Testing download speed................................................................................
Download: 5.63 Mbit/s
Testing upload speed......................................................................................................
Upload: 0.72 Mbit/s

Then I switched back to active_internet_interface: "wlan0", re-ran the tests, and everything on all nodes is back to my home connection.
Woohoo! That was... a heck of a lot easier than I thought it would be.
I thought I might have issues with the iptables masquerade rules, but it looks like they can coexist with no ill effect:
pi@turing-node-1:~ $ sudo iptables -t nat -L
...
Chain POSTROUTING (policy ACCEPT)
target     prot opt source               destination
MASQUERADE  all  --  anywhere             anywhere
MASQUERADE  all  --  anywhere             anywhere

Hmm... but it seems autossh will only work when the active interface is wlan0:
Jan 26 17:37:19 turing-node-1 autossh[5186]: starting ssh (count 1)
Jan 26 17:37:19 turing-node-1 autossh[5186]: ssh child pid is 5189
Jan 26 17:37:21 turing-node-1 autossh[5189]: Warning: remote port forwarding failed for listen port 22000
Jan 26 17:37:21 turing-node-1 autossh[5189]: Warning: remote port forwarding failed for listen port 2222
Jan 26 17:37:21 turing-node-1 autossh[5189]: Warning: remote port forwarding failed for listen port 8080

For idempotence, I can get the current default route (top of output) with:
pi@turing-node-1:~ $ route | grep '^default' | grep -o '[^ ]*$'
usb0
eth0
wlan0

But I think I'm going to hack a little bit of a solution together and (gasp) break idempotence on this one playbook. Drat.

It's hacky, but hey... it works.