User I2C support v2

A bit similar to #261. Allows inserting I2C transfers into the I2C state machine. Should probably bump the API version for this... Also has a few small cleanups.
Useful if you want to do something crazy like add a Pico W for wifi things. Mostly PR-ing this since the code exists and works.

I haven't decided if this is too much of a hack or not, but it is faster...
diff --git a/32blit-stm32/Src/32blit/i2c.cpp b/32blit-stm32/Src/32blit/i2c.cpp
index 679da217..53bd65df 100644
--- a/32blit-stm32/Src/32blit/i2c.cpp
+++ b/32blit-stm32/Src/32blit/i2c.cpp
@@ -166,11 +166,14 @@ namespace i2c {
         break;

       case SEND_REG_USER:
+        // this is a bit of a hack, set the delay before starting the user transfer
+        // to avoid affecting the timing
+        blit_i2c_delay(16, SEND_ACL);
+
         if(user_addr) {
           HAL_I2C_Master_Transmit_IT(&hi2c4, user_addr << 1, &user_reg, 1);
           i2c_state = user_buf_len ? DATA_USER : DONE_USER;
-        } else // skip user states
-          blit_i2c_delay(16, SEND_ACL);
+        }
         break;

       case DATA_USER:
@@ -189,7 +192,8 @@ namespace i2c {
         if(api.i2c_completed && !blit_user_code_disabled())
           api.i2c_completed(addr, user_reg, user_buf, user_buf_len);

-        blit_i2c_delay(16, SEND_ACL);
+        // alredy setup the next state/time
+        i2c_state = DELAY;
         break;
       }
     }

:thinking: Maybe I should sneak the "raw serial" stuff from my micropython hacks in here too...

thinking Maybe I should sneak the "raw serial" stuff from my micropython hacks in here too...

Well, that happened (after rewriting it a bit).... this is a "low-level APIs" PR now I guess.
(Debug firmware is ~100 bytes too big...)

(Debug firmware is ~100 bytes too big...)

Youch!
I wonder if it's worth ifdef guarding some of this stuff, since it's "advanced". Though that may consign it to obscurity.

I think the code size increase here is small, but debug builds were really close to the limit. Not needing to rebuild the firmware for my python repl would be nice :smile:

Now there's still >3k left in a debug build :smile:

Something to test the CDC part with...

MicroPython!!!! :astonished:

I should really push the code for that somewhere to increase the chances of it getting finished/usable/not-entirely-forgotten :laughing:


Several Things

PSR-4 autoloading
PSR-2 Code styling, short array syntax, and single quotes
Composer

Updated dependencies to allow minor releases
Removed composer.lock (It's not needed for libraries and general practice is to ignore it.)

Travis

Updated to builtin composer and caching vendor dirs (should be faster now)
Added PHP 7.0 and HHVM. (looks like the bug with 7.0 is fixed in the dev branch of superclosure, once they tag a release, we can make not allowed to fail)

Simplified PHPUnit config

I do have some actual features coming, but my OCD was making me twitch so I'm sending this in first :)
@hellogerard I see you don't have travis setup. Would you mind enabling it? All you have to do is create an account, and enable this repo. It will pick up the config file automatically. I did it earlier today for my fork and it only took a minute.

Thanks for the PR!  I pulled this branch locally, and tried running phpunit, but I'm getting an PHP Fatal error:  Class 'Jobby\Helper' not found  error. Do I need be running a certain version of PHP or phpunit?

Did you run composer dump? The autoloader changed so it needs to be rebuilt

Ah, that did it. Thanks.

Yay! I have a few more things coming this weekend. If you're thinking about tagging a release, I'd be grateful to get those in first :)

How about travis too?

No rush on a release. Be my guest!
Travis CI appears to be working!


Fixes macOS arm64 builds (again)

This change reverts 43452ca8 (#7662) and fa8b3f9a (#7389) and fixes the
real issue, where Thread::set_specific was not a pure virtual function,
leading to link issues:
duplicate symbol 'vtable for Thread' in:
    ../iocore/eventsystem/libinkevent.a(Inline.o)
    ../iocore/eventsystem/libinkevent.a(Thread.o)
duplicate symbol 'typeinfo name for Thread' in:
    ../iocore/eventsystem/libinkevent.a(Inline.o)
    ../iocore/eventsystem/libinkevent.a(Thread.o)
duplicate symbol 'typeinfo for Thread' in:
    ../iocore/eventsystem/libinkevent.a(Inline.o)
    ../iocore/eventsystem/libinkevent.a(Thread.o)

This will partially fix #855, but also requires a change from our release packager or a change to the brew upstream (and always running autoreconf -if

@ywkaras volunteered to take a look at this.

Should we leave this out of 9.1.x, to be safe ?

Cherry-picked to v9.2.x


Consider switching to Kotlin DSL for generated --idea flag

Command:
kscript --idea some-file.kts

Produces an IntelliJ project with a build.gradle in the root. Since we all love Kotlin, it may make sense to transition this to a build.gradle.kts now that's got first party support in Gradle.
Thanks for such a great project!

Sounds like a great idea for a PR to me. Would you be willing to contribute it?

Any news, or shall we close this issue?

Hey @holgerbrandl, I don't personally have the time to contribute this change, and only wanted to suggest it here in case someone else wanted to take it up. In projects I manage, I generally leave tickets open if we still think it's a good idea so that others can come along and find something they may want to contribute. If you'd like to close it instead though, that's completely up to you.
Thanks for responding :smile:

Fixed with https://github.com/holgerbrandl/kscript/pull/258


Simplify BucketUUID to remove thread local

The primary motivation of this change is to simplify the code. As a bonus, a simple JMH benchmark shows that the new code is twice as fast:
Benchmark                          Mode  Cnt         Score        Error  Units
BenchmarkBucketUuid.bucketBuffer  thrpt    5  14548998.313 ± 209390.443  ops/s
BenchmarkBucketUuid.bucketDirect  thrpt    5  30708144.423 ± 522965.940  ops/s

+1, thanks!
I should also note that the hash function is validated in TestBucketing, so we know that the hash of the test UUID still matches the value in the spec.


triggerScrollToDateDelegate does not trigger willScrollToDateSegmentWith

Hi, I am on version 8.0.3.
While performing calendar.scrollToDate, I noticed that the delegate function willScrollToDateSegmentWith is not triggered but didScrollToDateSegmentWith is triggered perfectly.
I currently load my data in willScrollToDateSegmentWith for the visible dates so is there any way to force the delegate function to trigger before the calendar.scrollToDate is triggered?
I also noticed that the completion handler of calendar.scrollToDate triggers before the animation ends so if I try to select a date in the completion handler, it doesn't work.
Thank you!

I just checked the code which deals with scrolling and I can see that it only calls the didScrollToDateSegmentWith method.
    func scrollTo(point: CGPoint, triggerScrollToDateDelegate: Bool? = nil, isAnimationEnabled: Bool, extraAddedOffset: CGFloat, completionHandler: (() -> Void)?) {
        isScrollInProgress = true
        if let validCompletionHandler = completionHandler { scrollDelayedExecutionClosure.append(validCompletionHandler) }
        self.triggerScrollToDateDelegate = triggerScrollToDateDelegate
        var point = point
        if scrollDirection == .horizontal { point.x += extraAddedOffset } else { point.y += extraAddedOffset }
        DispatchQueue.main.async() {
            self.setContentOffset(point, animated: isAnimationEnabled)
            if (isAnimationEnabled && self.calendarOffsetIsAlreadyAtScrollPosition(forOffset: point)) ||
                !isAnimationEnabled {
                self.scrollViewDidEndScrollingAnimation(self)
            }
        }
    }

I would like to know why you decided to not include willScrollToDateSegmentWith here because I am very tempted to do so myself but I am worried it might break something else.

Do it.
Let me know how it goes.
I will take a look as well, its just that given this current time, I am a little tied up.
Help on this project is always welcomed.

Thanks, I fixed it in the PR #1264 1264

@patchthecode please, look :)


Submit issue to @nx/rollup re: hard-coded file extensions

The @nx/rollup:rollup executor hard-codes the file extensions for the resulting bundles:

file names set here
package.json references set here and here

This means that when "format": ["cjs", "esm"] is specified, index.cjs.js and index.esm.js files are created. This prevents the resulting package from supporting both CommonJS (require) and ES Module (import) imports, because Node will interpret  all .js files in the same way (based on "type" in package.json).
We need to generate explicit file extensions, i.e. index.cjs and index.mjs. In order to achieve this with the @nx/rollup plugin, we've had to resort to the following workarounds:

adding a custom "rollupConfig": "rollup.config.js" for each project.json to change entryFileNames from '[name].[fomat].js' to '[name].cjs' or '[name].mjs' - see rollup.config.js
modifying the underlying @nx/rollup sources in node_modules using patch-package - see<EMAIL_ADDRESS>

No longer necessary, used @nx/esbuild instead.


Add flip kernel and op

Add flip kernel and op

passes all UTs

Although we can see all dtpyes covered by non-fine-gran cases, we still need add the op into fine gran compare_cpu suite, since test_compare_cpu includes some PyTorch op semantics definition test.


Incorrect permissions :: /etc/ipa/dnssec/ipa-dnskeysyncd.keytab

Following error exists:
[start ipa-dnskeysyncd.service]
Running [export SOFTHSM2_CONF=/etc/ipa/dnssec/softhsm2.conf; /usr/sbin/runuser -g named -u ods -- /usr/libexec/ipa/ipa-dnskeysyncd]
Marked pid [2444] for [ipa-dnskeysyncd.service]
[is-active ipa-dnskeysyncd.service]
[is-active ipa.service]
Traceback (most recent call last):
  File "/usr/libexec/ipa/ipa-dnskeysyncd", line 68, in <module>
    ipautil.kinit_hostprincipal(KEYTAB_FB, WORKDIR, PRINCIPAL)
  File "/usr/lib/python2.7/site-packages/ipapython/ipautil.py", line 1208, in kinit_hostprincipal
    raise StandardError('Error initializing principal %s in %s: %s' % (principal, keytab, str(e)))
StandardError: Error initializing principal ipa-dnskeysyncd/fax.puglord.com in /etc/ipa/dnssec/ipa-dnskeysyncd.keytab: (13, 'Permission denied')

Originally the file was listed:
-r--r----- 1 root ods  354 Jul 16 00:48 ipa-dnskeysyncd.keytab
Meaning the process could not access the file.

Could you please check if the following patch fixes the issue?
diff --git a/systemctl b/systemctl
index 6a15c0b..eb12f51 100755
--- a/systemctl
+++ b/systemctl
@@ -451,6 +451,9 @@ sub add_runuser {
                if (defined $data->{'Service.Group'}) {
                        unshift @$cmd, '-g', $data->{'Service.Group'};
                }
+               if (defined $data->{'Service.SupplementaryGroups'}) {
+                       unshift @$cmd, '-G', $data->{'Service.SupplementaryGroups'};
+               }
                unshift @$cmd, '/usr/sbin/runuser';
        }
 }

Applied to master via 702cdcef98805955824c9894434a3b33f2f3c6c9.


Add a LogLevel.fromString method

I have this in my codebase, figured it makes sense to push upstream.
Do we want it to match the output of show at all?

@Daenyth
I would prefer that we match the output of show with that of fromString.
And for the sake of not breaking the existing API I think it's best to adapt your method. Otherwise I wouldn't care either way.
Also, just remembered I'm a maintainer of this repo 😬

That's reasonable. Feel free to edit this branch before merging if I don't get to it first


Can we upload Multiturn questions using excel file?

Can we upload Multiturn questions using excel file?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 38f6b983-0c19-6439-78df-ea7bdab3f94e
Version Independent ID: 15dc8197-fed8-a94f-4143-2799d5e6a002
Content: Multi-turn conversations - QnA Maker - Azure Cognitive Services
Content Source: articles/cognitive-services/QnAMaker/How-To/multiturn-conversation.md
Service: cognitive-services
Sub-service: qna-maker
GitHub Login: @diberry
Microsoft Alias: diberry

@vikramdadwal Thanks for the feedback! We are currently investigating and will update you shortly.

@vikramdadwal  For now, the Populate your KB section displays an Enable multi-turn extraction from URLs, .pdf or .docx files check box.

@vikramdadwal I highly recommend you to post your feedback to the User Voice forum, the product team is reviewing the feedback carefully. https://cognitive.uservoice.com/
Thank you for the feedback again. We will now proceed to close this thread. If there are further questions regarding this matter, please respond here and @YutongTie-MSFT and we will gladly continue the discussion.


[1.9] rootless: move join namespace inside child process

open the namespace file descriptors inside of the child process.


refactor : add capacity in stopfuncs slice

Overview

added capacity in slice, as we are aware of capacity
open issue

Checklist

[x] New and updated code has appropriate documentation
[ ] New and updated code has new and/or updated testing
[x] Required CI checks are passing
[ ] Visual proof for any user facing features like CLI or documentation updates
[ ] Linked issues closed with keywords

Codecov Report

Merging #333 (d7a80a4) into main (50a67ac) will decrease coverage by 0.21%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #333      +/-   ##
==========================================
- Coverage   43.76%   43.56%   -0.21%
==========================================
  Files          26       26
  Lines        1990     1990
==========================================
- Hits          871      867       -4
- Misses        998     1001       +3
- Partials      121      122       +1

see 1 file with indirect coverage changes


Add the service info endpoints

Closes #11
Can't be merged until #45 is merged. A rebase should be enough when the time comes

This is ready for review now

@CastilloDel The output doesn't seem quite right with the scaping and newlines?:
% curl -s <IP_ADDRESS>:8080/variants/service-info | jq .
"{\n  \"error\": \"InvalidInput\",\n  \"message\": \"Wrong key derived from ID: service-info.vcf.gz.tbi\"\n}"

I'll look it up. I have been using fish and I haven't noticed that %.

Okay, one problem at a time:

I've now fixed the scaping problem.
Example:

curl --header "Content-Type: application/json" -d '{"format": "VCF", "regions": [{"referenceName": "chrM"}]}' <IP_ADDRESS>:8080/variants/adfadf
{"error":"InvalidInput","message":"Wrong key derived from ID: adfadf.vcf.gz.tbi"}

I don't think the % is a problem. It is something specific to zsh and is used to mark that the output didn't end with a newline
The errors you had earlier with the examples from the README.md happened because you executed the server inside htsget-http-actix. For those examples, it is supposed to be executed from the top of the htsget-rs project, as it says in the README.md 'These are some examples with curl in which the server was started at the root of the htsget-rs project'. If you want to execute the server inside htsget-http-actix, it is enough to set the HTSGET_PATH variable:

 HTSGET_PATH=../ cargo run

It's true that the JSON isn't pretty formatted, I'm on it!

Now the formatting works as expected!
Example:
curl --header "Content-Type: application/json" -d '{"format": "VCF", "regions": [{"referenceName": "chrM"}]}' '<IP_ADDRESS>:8080/variants/data/vcf/sample1-bcbio-cancer'
{
  "format": "VCF",
  "urls": [
    {
      "url": "file:///home/daniel/htsget-rs/data/vcf/sample1-bcbio-cancer.vcf.gz",
      "headers": {
        "Range": "bytes=0-3367"
      },
      "class": "body"
    }
  ]
}

Thanks a ton @CastilloDel for the fixes!!

* I don't think the `%` is a problem. It is something specific to zsh and [is used to mark that the output didn't end with a newline](https://unix.stackexchange.com/questions/167582/why-zsh-ends-a-line-with-a-highlighted-percent-symbol)

Got it! No worries... although I might introduce a newline at the end of the JSON response, just to display it well on a regular shell... I think it's unlikely that other JSON parsers will complain about an extra final \n and it looks better on quick tests in the terminal.

* The errors you had earlier with the examples from the README.md happened because you executed the server inside `htsget-http-actix`. For those examples, it is supposed to be executed from the top of the htsget-rs project, as it says in the README.md 'These are some examples with curl in which the server was started at the root of the htsget-rs project'. If you want to execute the server inside `htsget-http-actix`, it is enough to set the HTSGET_PATH variable:

 HTSGET_PATH=../ cargo run

Hm, I'm now torn on what would be the most usable... I'd guess that running cargo run within the htsget-http-actix crate is the most intuitive way to operate this. I indeed missed that HTSGET_PATH=../ cargo run hint in the README, and I can anticipate many other users missing that bit.
Would you mind having it so that this relative ../ path (HTSGET_PATH) is implicit/default? That way casual users will not have to be confused, but just use the server right away with a clean cargo run command :)

I just noticed that there seem to be a few missing fields that are present in the reference implementation?:
https://htsget.ga4gh.org/reads/service-info
http://localhost:8080/reads/service-info

Can you try to match those fields present in the Go reference implementation with ours?

Got it! No worries... although I might introduce a newline at the end of the JSON response, just to display it well on a regular shell... I think it's unlikely that other JSON parsers will complain about an extra final \n and it looks better on quick tests in the terminal.

Okay, that should be easy

Hm, I'm now torn on what would be the most usable... I'd guess that running cargo run within the htsget-http-actix crate is the most intuitive way to operate this. I indeed missed that HTSGET_PATH=../ cargo run hint in the README, and I can anticipate many other users missing that bit.
Would you mind having it so that this relative ../ path (HTSGET_PATH) is implicit/default? That way casual users will not have to be confused, but just use the server right away with a clean cargo run command :)

This isn't so easy :(. Although I agree with you that it would be more intuitive, there are some problems regarding that change:

It makes sense for the server to start where it is being executed, having HTSGET_PATH=../ be the default could be confusing and doesn't make much sense outside this case.
The data folder is outside the htsget-http-actix folder, so the examples can't be changed to work with the server running inside the htsget-http-actix folder because directory traversal isn't allowed

Copying the data folder inside this crate could solve this, but it is an ugly solution :(
I can edit the README.md to try to make this clearer, though.

Can you try to match those fields present in the Go reference implementation with ours?

Yes! Should be pretty straight forward. I guess having extra fields apart from the spec can be useful

I think it is much clearer now.

Oops:
(base) rvalls@m1 htsget-http-actix % cargo run
   Compiling htsget-http-core v0.1.0 (/Users/rvalls/dev/umccr/htsget-rs/htsget-http-core)
   Compiling htsget-http-actix v0.1.0 (/Users/rvalls/dev/umccr/htsget-rs/htsget-http-actix)
    Finished dev [unoptimized + debuginfo] target(s) in 3.59s
     Running `/Users/rvalls/dev/umccr/htsget-rs/target/debug/htsget-http-actix`
thread 'main' panicked at 'The environment variables weren't properly set!: MissingValue("htsget_contact_url")', htsget-http-actix/src/main.rs:44:43
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
Panic in Arbiter thread.

Would you mind having it so that this relative ../ path (HTSGET_PATH) is implicit/default?
That way casual users will not have to be confused, but just use the server right away with a clean cargo run command :)

This isn't so easy :(. Although I agree with you that it would be more intuitive, there are some problems regarding that change:
It makes sense for the server to start where it is being executed, having HTSGET_PATH=../ be the default could be confusing and doesn't make much sense outside this case.
The data folder is outside the htsget-http-actix folder, so the examples can't be changed to work with the server running inside the htsget-http-actix folder because directory traversal isn't allowed

I see the problems :/ ... and I still think that just cargo run is perhaps the only way that this crate will not generate usability issues and bug reports, regardless of how well indicated it is on the README, hmm :-S
Why do you think that HTSGET_PATH=../ could be confusing? How else do you foresee users spawning this server?
I'm thinking that cargo run at the toplevel does not make much sense because there could be other http server implementations or other components in the future, so I'd expect to cd <crate> first to run a particular http impl?
Sorry if such a UX nuthead sometimes, but I want to get this right to avoid newcomer confusion mainly ;)

Don't worry about insisting on the UX, I also think it is really important, I just don't see the way to do it in this case :(

Why do you think that HTSGET_PATH=../ could be confusing? How else do you foresee users spawning this server?

Well, it seems logical to me that if you start a server in a certain directory, it should have access to the files in that directory and no others. It's also how other "servers" work, for example the python http server module

I'm thinking that cargo run at the toplevel does not make much sense because there could be other http server implementations or other components in the future, so I'd expect to cd  first to run a particular http impl?

Well, personally, I tend to use cargo run -p {crate name} more than cd and then cargo run, because in projects with several crates it allows you to execute several of them without changing directories and also executing all the tests. Although I'm not the most experienced, I would suppose there are other people like me (?). Keep in mind that having HTSGET_PATH=../ would also mean that using cargo run -p htsget-http-actix would stop working out of the box for the examples.

Those vars should have reasonable hardcoded defaults, otherwise it can get really tedious to spin up the server fast:

Yep, that was a lapse. It is already fixed now

Well, personally, I tend to use cargo run -p {crate name} more than cd and then cargo run, because in projects with several crates it allows you to execute several of them without changing directories and also executing all the tests.

That makes a metric ton of sense, thanks for providing this alternative, let's go this way then ;)
Merge afterwards, I think that all bugs are ironed at this point for this PR.

Done! It is kinda sad the examples won't work with just cargo run inside the crate, but I think the better default is way more important

I've reworked the docs in https://github.com/umccr/htsget-rs/commit/9949a040c5c12aa13b2922888789b8b98cbd7460, I find them a bit easier to work on/read, good job with this, Daniel! :)

I still need some practice on writing docs 😄 Good catch on the htsget-http_actix typo! I missed that one


SonarCloud Issues and Low Code Coverage Resulting From Admin Separation

Pipeline Gate Failed for PR for Admin Separation
SonarCloud Report shows some code smells and low coverage. Do we want to address them?
There is another ticket to address adding minimum (1 for each) frontend components tests but to achieve 80% might be very difficult.

@ianliuwk1019 Thankfully 80% is only required for new components!  Thanks for logging this.

Most of the code smells are not worth fixing or are false positives and can be resolved(ignored). This is essentially what I did for the public component. (Code coverage is a completely separate topic though)

Closing as #158 addressed major updates and Renovatebot is now in place.


Move sensor/sample to new logger

Last remaining code using the old logger.

Codecov Report

Merging #10950 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #10950      +/-   ##
==========================================
- Coverage   53.32%    53.3%   -0.02%
==========================================
  Files         215      215
  Lines       25908    25908
  Branches     5711     5711
==========================================
- Hits        13815    13810       -5
- Misses       9772     9777       +5
  Partials     2321     2321

Impacted Files
Coverage Δ

subsys/logging/log_core.c
76.05% <0%> (-2.35%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58058ee...43f2681. Read the comment docs.

@nordic-krch fixed


Add Python Cheatsheet

Hacktoberfest notes:

due to volume of submissions, we may not be able to review PRs that do not pass tests and do not have informative titles.
please read our contributing guidelines
be sure to check the output of Travis-CI for linter errors
if this is your first open source contribution, make sure it's not your last!

What does this PR do?
Add Resource(s) | Remove Resource(s) | Add info | Improve Repo
For resources
Description
Why is this valuable (or not)?
How do we know it's really free?
For book lists, is it a book? For course lists, is it a course? etc.
Checklist:

[ ] Not a duplicate
[ ] Included author(s) if appropriate
[ ] Lists are in alphabetical order
[ ] Needed indications added (PDF, access notes, under construction)

Closing as these changes are duplicated in https://github.com/EbookFoundation/free-programming-books/pull/5027.


Move all sensor processing to a coroutine

[ ] Processing happens in a coroutine
[ ] Callback occurs on the main thread

Consider using kotlin flows instead


Add retry on delete stack + send event to datadog

What does this PR do?
Add a retry around deleteStack.
We should add unit tests to verify we do not break it but I did not manage to run them locally yet. I will address that in a follow up PRs.
In the meantime this should reduce some flakiness we have for now

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

/merge


look into removing space from config/log paths

On this topic, using ~/.config/terminalone, even on Windows, would be nice. It can be one of the directories it looks at. This is a nice-to-have for cross platform dotfiles.

@gplusplus314 check out https://github.com/atinylittleshell/TerminalOne/releases/tag/v1.6.0 and see #50 for details


Add engine property to OneWayShooting

OneWayShootingMover did not have an engine attribute. It could be accessed from the submovers, but this is not very user-friendly.
This PR adds an engine property to OneWayShootingMover and to OneWayExtendMover. It also cleans up formatting to remove some of the unnecessary vertical space.
This should be immediately ready for review/merge.

Giving this until Saturday for a review, then I'll merge it.


feat: add ohi-auto-config tests

Ran non-regression tests locally and they passed, so am reasonably confident that this works as intended.

Ran non-regression tests locally and they passed, so am reasonably confident that this works as intended.


Performance and redundancy

I like the anonymous talk to mods feature but doesn't dyno do the moderation part?

We're trying to replace dyno


exceptions raised at shutdown

When stopping an AbuseHelper instance with sudo su abusehel -s /bin/bash -c 'botnet stop /full/path' some threads raise exceptions.
Traceback from startup log:
Exception in thread Thread-1 (most likely raised during interpreter shutdown):
Traceback (most recent call last):
  File "/usr/lib/python2.7/threading.py", line 810, in __bootstrap_inner
  File "/usr/lib/python2.7/threading.py", line 763, in run
  File "/usr/local/lib/python2.7/dist-packages/idiokit/threadpool.py", line 100, in _thread
  File "/usr/local/lib/python2.7/dist-packages/idiokit/_selectloop.py", line 48, in asap
<type 'exceptions.AttributeError'>: 'thread._local' object has no attribute 'current'
Exception in thread Thread-2 (most likely raised during interpreter shutdown):
Traceback (most recent call last):
  File "/usr/lib/python2.7/threading.py", line 810, in __bootstrap_inner
  File "/usr/lib/python2.7/threading.py", line 763, in run
  File "/usr/local/lib/python2.7/dist-packages/idiokit/idiokit.py", line 161, in throw
  File "/usr/local/lib/python2.7/dist-packages/idiokit/idiokit.py", line 550, in __init__
  File "/usr/local/lib/python2.7/dist-packages/idiokit/idiokit.py", line 381, in _pipe
  File "/usr/local/lib/python2.7/dist-packages/idiokit/idiokit.py", line 119, in add
<type 'exceptions.TypeError'>: 'NoneType' object is not callable
Exception in thread Thread-1 (most likely raised during interpreter shutdown):
Traceback (most recent call last):
  File "/usr/lib/python2.7/threading.py", line 810, in __bootstrap_inner
  File "/usr/lib/python2.7/threading.py", line 763, in run
  File "/usr/local/lib/python2.7/dist-packages/idiokit/threadpool.py", line 100, in _thread
  File "/usr/local/lib/python2.7/dist-packages/idiokit/_selectloop.py", line 48, in asap
<type 'exceptions.AttributeError'>: 'thread._local' object has no attribute 'current'

I'm running idiokit https://github.com/abusesa/idiokit/commit/5f223bdcf75e58b873d99759c34ce58170324e88 .

Thank you. Which platform are you using?

Ubuntu 14.04.3 LTS, Python 2.7.6

Commits b10489c and 8173274 seem to fix this issue.

I can confirm that. Running https://github.com/abusesa/idiokit/commit/817327458d14d618791fa58ce3a8e6063bd480fb without issues.

\o/


update icons

The icons have been updated on Heroicons.
They added aria-hidden="true" + 8 new icons.

Thank you @quentin-bettoum ❤
I'll cut a new release with these. We're also tracking automating these upgrades here: https://github.com/mveytsman/heroicons_elixir/issues/6

@quentin-bettoum do you mind fixing the tests before I merge this https://github.com/mveytsman/heroicons_elixir/runs/5277134654?check_suite_focus=true

It should be good now.

0.3.2 released!


Caching JSON data returned by Axios

Test found that XHR will not cache, how to configure

@haliuhei I think you cannot intercept syncronous request, last time I read about it doesn't work, I'll check the service worker docs, but you need to use fetch api to make it working with servive worker.

Found issues: will not work, at least on chromium based browsers, there is a deadlock/livelock intercepting synchronous request.
https://bugs.chromium.org/p/chromium/issues/detail?id=602051
https://chromium-review.googlesource.com/c/chromium/src/+/1376738


updated Azure SDK for swagger updates regarding the new property cal…

Added Swagger tests for Single VM, VM Scaleset and Image tests to verify the DiskEncryptionSet resource usage.
Added SetSwaggerTestEnvironment.ps1 for setting the test env variables and to invoke the solution file for updating and running the tests in record mode.
Swagger documentation Pull request for reference:
https://github.com/Azure/azure-rest-api-specs/pull/7293
https://github.com/Azure/azure-rest-api-specs/pull/7318

@hari-bodicherla
Azure/azure-rest-api-specs#7318 is still open. I suppose you are going to regenerate SDK after it's merged.
Please let me know if this PR is ready for review.
Thanks

@hari-bodicherla
Azure/azure-rest-api-specs#7318 is still open. I suppose you are going to regenerate SDK after it's merged.
Please let me know if this PR is ready for review.
Thanks

Hi,
This SDK is generated from my forked branch where the azure-rest-api-specs/pull/7318 changes  already present. So I think we dont need to regenerate the SDK from the master again once the swagger documentation changes are merged. The only one thing to note is the azure-rest-api-specs/pull/7318 is going to private branch called 2019-07 ( which needs to publish into master for new api version  2019-07-01 yet) . So the current master azure-rest-api-specs branch is not aware of api version 2019-07-01 which are resulting in above failed checks it seems.

Hi,
This SDK is generated from my forked branch where the azure-rest-api-specs/pull/7318 changes already present. So I think we dont need to regenerate the SDK from the master again once the swagger documentation changes are merged. The only one thing to note is the azure-rest-api-specs/pull/7318 is going to private branch called 2019-07 ( which needs to publish into master for new api version 2019-07-01 yet) . So the current master azure-rest-api-specs branch is not aware of api version 2019-07-01 which are resulting in above failed checks it seems.

OK I got it. Please notify me when the spec is merged into master and your PR is ready for review.
Thanks

Hi,
This SDK is generated from my forked branch where the azure-rest-api-specs/pull/7318 changes already present. So I think we dont need to regenerate the SDK from the master again once the swagger documentation changes are merged. The only one thing to note is the azure-rest-api-specs/pull/7318 is going to private branch called 2019-07 ( which needs to publish into master for new api version 2019-07-01 yet) . So the current master azure-rest-api-specs branch is not aware of api version 2019-07-01 which are resulting in above failed checks it seems.

OK I got it. Please notify me when the spec is merged into master and your PR is ready for review.
Thanks

Sure , I will notify when the spec is merged into master @isra-fel  . Thanks

@hari-bodicherla How's going about the spec?

@hari-bodicherla I'll close this PR for now. Feel free to reopen or open a new one to continue. THanks


Chore/26/change privacy policy url to new one

Summary
This pull request contains the updating of minor things for version 2.3.0 and closes #26.
Changes

Updated gitignore
Added new build commands for each browser
updated URL to the new URL

Approved


Prepend a space before command scripts executed in terminal to avoid polluting shell history

Currently, when I try to start a terminal or debug a container, OrbStack launches a new Terminal session and executes something like this:
/var/folders/gc/td184n4s61q_bpkf85ddvlym0000gn/T/orbstack-open-terminal_68BAF0E2.sh; exit

These bootstrap scripts are used only once, and they ended up leaving entries in the shell history file that show up when I do up arrows. Currently a lot of modern shells (zsh, fish, nu, ...) supports a feature that if a command is prepended with spaces, it will not be recorded. It would help someone who doesn't want one-time-used commands leaving traces in their history file (like me). As for shells (sh, bash) that do not support this feature, these commands end up in the history anyway.

Unfortunately, this isn't possible because the command you're seeing is generated and injected by your terminal emulator when we ask it to open the script.


Only sync down data for specific user

Discussion during community call on Sept 9, 2019:
Data syncs down for all users. Uses lots of data, challenge in limited bandwidth.
Also a data security issue for PII.
Need to clarify data vs. tables (#106)
Some people constantly switch users on the tablet so need whole database.
Needs to be an option


Add Vite 5 to peer dependencies

Supersedes #1210 since that PR made other breaking changes.
Also snuck in a fix for type errors observed when running locally, e.g. https://github.com/vanilla-extract-css/vanilla-extract/pull/1210#issuecomment-1790181830. It has no impact on the public API as the types are only used internally.

It'd be good for this to go out at the same time as https://github.com/vanilla-extract-css/vanilla-extract/pull/1239 since Remix is already running Vite 5.


Question: Support for vertical/horizontal/both support.

As mentioned in the upwork request i have started added tablet support to the site.
But here i am not sure if the support you mention is for the iPad vertical mode or horizontal mode ( landscape mode )
I currently added and tested home,star,direct,obstacle,mass,newdarkmatter,darkmatter,interactivelens,slrare pages on the https://github.com/aadi58002/huntfordm/commit/136d755337da9472b660f282fa9041d0d47d6090 commit
Can you clarify the target device dimensions?
Also can you look at the commit and clarify if you want me to keep working on this or should i change any type of styling choices which i have made in code.

I guess ideally both, but it may be the last screens don't work well on vertical, in which case it would be OK if the message which currently warns about general problems on mobile, instead tells the user to rotate to horizontal if on a tablet. Desktop browser windows may also have closer to vertical shape though.

Which page do you mean by last page ?
Also there are some pages which are using ( mainly obstacle,mass) which do not work well in vertical mode i tried to make them work but it was barely working and broke easily so i can add a popup saying to change to landscape on those pages. Aside from those two. I think other can be made for both vertical and horizontal . Are you ok with that ?
( Also i haven't seen all the pages so there might still be some pages which can't work with vertical )

Sounds ok. The last step is the actual game (the main thing, the rest is just into to explain it)

From: Aditya Yadav @.>
Sent: Saturday, July 22, 2023 12:45:59 PM
To: CosmoPars/huntfordm @.>
Cc: Antony Lewis @.>; Comment @.>
Subject: Re: [CosmoPars/huntfordm] Question: Support for vertical/horizontal/both support. (Issue #1)
Which page do you mean by last page ?
Also there are some pages which are using ( mainly obstacle,mass) which do not work well in vertical mode i tried to make them work but it was barely working and broke easily so i can add a popup saying to change to landscape on those pages. Aside from those two. I think other can be made for both vertical and horizontal . Are you ok with that ?
( Also i haven't seen all the pages so there might still be some pages which can't work with vertical )
—
Reply to this email directly, view it on GitHubhttps://github.com/CosmoPars/huntfordm/issues/1#issuecomment-1646564720, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AA6GQI6OYAP5CNSTFJREEELXRO4PPANCNFSM6AAAAAA2TY3HCA.
You are receiving this because you commented.Message ID: @.***>

I am fixed the major things which i could see.
https://github.com/aadi58002/huntfordm
Can you run the fork and tell me the things which you still want changes or some test which i might have missed ?

Can you set up a test site? I’m travelling..

From: Aditya Yadav @.>
Sent: Saturday, July 22, 2023 3:21:56 PM
To: CosmoPars/huntfordm @.>
Cc: Antony Lewis @.>; Comment @.>
Subject: Re: [CosmoPars/huntfordm] Question: Support for vertical/horizontal/both support. (Issue #1)
I am fixed the major things which i could see.
https://github.com/aadi58002/huntfordm
Can you run the fork and tell me the things which you still want changes or some test which i might have missed ?
—
Reply to this email directly, view it on GitHubhttps://github.com/CosmoPars/huntfordm/issues/1#issuecomment-1646594761, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AA6GQI46SAXBHQ4HKYI5ISLXRPOYJANCNFSM6AAAAAA2TY3HCA.
You are receiving this because you commented.Message ID: @.***>

It is night time in my country do you mind if I do it tomorrow?

No rush

From: Aditya Yadav @.>
Sent: Saturday, July 22, 2023 6:06:51 PM
To: CosmoPars/huntfordm @.>
Cc: Antony Lewis @.>; Comment @.>
Subject: Re: [CosmoPars/huntfordm] Question: Support for vertical/horizontal/both support. (Issue #1)
It is night time in my country do you mind if I do it tomorrow?
—
Reply to this email directly, view it on GitHubhttps://github.com/CosmoPars/huntfordm/issues/1#issuecomment-1646617778, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AA6GQI6RZQTUODZE33WIA6LXRP3BXANCNFSM6AAAAAA2TY3HCA.
You are receiving this because you commented.Message ID: @.***>

https://huntfordm.vercel.app/ deployed site

The “please open this app in landscape mode” message also pops up in vertical-shaped browser windows on desktop, and there seems to be no way of getting rid of the message e.g. after re-sizing the window to be full screen the message still shows.
I would just put this warning at the start as the other mobile warning message, but make sure it disappears if the screen is rotated/resized. On the previous screens the next can also overlap the buttons in landscape shapes.
I would change “Please open this app full screen in landscape mode.. “ since even in landscape, if the user is split-screen the browser window itself may not be landscape.
From: Aditya Yadav @.>
Sent: 23 July 2023 03:04
To: CosmoPars/huntfordm @.>
Cc: Antony Lewis @.>; Comment @.>
Subject: Re: [CosmoPars/huntfordm] Question: Support for vertical/horizontal/both support. (Issue #1)
https://huntfordm.vercel.app/ deployed site
—
Reply to this email directly, view it on GitHubhttps://github.com/CosmoPars/huntfordm/issues/1#issuecomment-1646714483, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AA6GQI63ZHDPMSUJ4X6F7QTXRR2A3ANCNFSM6AAAAAA2TY3HCA.
You are receiving this because you commented.Message ID: @.***>

I added the close button as well the message will disappear on resize

You didn't run prettier on the code so should i format all the file and commit them ?

Ideally don’t change the format if it will complicate the git diff, but if you’ve already re-indented don’t worry (can view diffs without whitespace).
From: Aditya Yadav @.>
Sent: 23 July 2023 09:52
To: CosmoPars/ntfordm @.>
Cc: Antony Lewis @.>; Comment @.>
Subject: Re: [CosmoPars/huntfordm] Question: Support for vertical/horizontal/both support. (Issue #1)
You didn't run prettier on the code so should i format all the file and commit them ?
—
Reply to this email directly, view it on GitHubhttps://github.com/CosmoPars/huntfordm/issues/1#issuecomment-1646772400, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AA6GQIYKBLS6ZY54HGYNNS3XRTJYLANCNFSM6AAAAAA2TY3HCA.
You are receiving this because you commented.Message ID: @.***>

I commit the format changes in another commit so that it won't make the commit which cause change to logic harder to read.

If you have any request for changes, Let me know

I was trying to apply for the upwork job post which you posted . But it seem you have closed it. Can you reopen it so that i can officially claim this job ?

Still travelling.,.  is the live site updated? Did you manage to fix the touch issues ok? I thought the job was already assigned, but can check when properly back online possibly tomorrow
Sent from Outlook for iOShttps://aka.ms/o0ukef

From: Aditya Yadav @.>
Sent: Sunday, July 23, 2023 2:19:50 PM
To: CosmoPars/huntfordm @.>
Cc: Antony Lewis @.>; Comment @.>
Subject: Re: [CosmoPars/huntfordm] Question: Support for vertical/horizontal/both support. (Issue #1)
I was trying to apply for the upwork job post which you posted . But it seem you have closed it. Can you reopen it so that i can officially claim this job ?
—
Reply to this email directly, view it on GitHubhttps://github.com/CosmoPars/huntfordm/issues/1#issuecomment-1646826260, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AA6GQIYXDCYUYD6CDTABXGTXRUJGNANCNFSM6AAAAAA2TY3HCA.
You are receiving this because you commented.Message ID: @.***>

I fixed it should be live now

Thanks. Definitely better, but some things don’t seem to work with touch on the iPad, e.g. the first up down slider moves the page not the slider. Some text also wrapping oddly or overlapping.
Change the mobile warning pop up on the first paper, e.g. so no longer shown on landscape tablets and/or ask to rotate to landscape as appropriate.

From: Aditya Yadav @.>
Sent: Sunday, July 23, 2023 3:04:13 AM
To: CosmoPars/huntfordm @.>
Cc: Antony Lewis @.>; Comment @.>
Subject: Re: [CosmoPars/huntfordm] Question: Support for vertical/horizontal/both support. (Issue #1)
https://huntfordm.vercel.app/ deployed site
—
Reply to this email directly, view it on GitHubhttps://github.com/CosmoPars/huntfordm/issues/1#issuecomment-1646714483, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AA6GQI63ZHDPMSUJ4X6F7QTXRR2A3ANCNFSM6AAAAAA2TY3HCA.
You are receiving this because you commented.Message ID: @.***>

Touch only worked once for me on the first drag, then stopped working. And touch drag did not work on later screens. I also see the landscape pop up even though already viewing on an iPad landscape.
Sent from Outlook for iOShttps://aka.ms/o0ukef

From: Antony Lewis @.>
Sent: Sunday, July 23, 2023 6:40:29 PM
To: CosmoPars/huntfordm @.>; CosmoPars/huntfordm @.>
Cc: Comment @.>
Subject: Re: [CosmoPars/huntfordm] Question: Support for vertical/horizontal/both support. (Issue #1)
Thanks. Definitely better, but some things don’t seem to work with touch on the iPad, e.g. the first up down slider moves the page not the slider. Some text also wrapping oddly or overlapping.
Change the mobile warning pop up on the first paper, e.g. so no longer shown on landscape tablets and/or ask to rotate to landscape as appropriate.

From: Aditya Yadav @.>
Sent: Sunday, July 23, 2023 3:04:13 AM
To: CosmoPars/huntfordm @.>
Cc: Antony Lewis @.>; Comment @.>
Subject: Re: [CosmoPars/huntfordm] Question: Support for vertical/horizontal/both support. (Issue #1)
https://huntfordm.vercel.app/ deployed site
—
Reply to this email directly, view it on GitHubhttps://github.com/CosmoPars/huntfordm/issues/1#issuecomment-1646714483, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AA6GQI63ZHDPMSUJ4X6F7QTXRR2A3ANCNFSM6AAAAAA2TY3HCA.
You are receiving this because you commented.Message ID: @.***>

I fixed the modal div popup error. I was not able to reproduce the slider stuck error on any of the pages.
I tried to move all the slider and they worked fine. You might want to try refreshing the page once.

The page https://huntfordm.vercel.app/tutorial/darkmatter has weird word wrap, the next page https://huntfordm.vercel.app/tutorial/interactivelens has the dark matter blob that I can’t move by touch ( and the text overlaps the Next button, probably the font size needs to scale with the viewport up to some max?).

From: Aditya Yadav @.>
Sent: Sunday, July 23, 2023 7:43:36 PM
To: CosmoPars/huntfordm @.>
Cc: Antony Lewis @.>; Comment @.>
Subject: Re: [CosmoPars/huntfordm] Question: Support for vertical/horizontal/both support. (Issue #1)
I fixed the modal div popup error. I was not able to reproduce the slider stuck error on any of the pages.
I tried to move all the slider and they worked fine. You might want to try refreshing the page once.
—
Reply to this email directly, view it on GitHubhttps://github.com/CosmoPars/huntfordm/issues/1#issuecomment-1646902381, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AA6GQI5AOVYGFV36U4KIPITXRVPERANCNFSM6AAAAAA2TY3HCA.
You are receiving this because you commented.Message ID: @.***>

On upwork you are listed as "hired"

On upwork you are listed as "hired"

I don't see any active jobs on my portal.

The page https://huntfordm.vercel.app/tutorial/darkmatter has weird word wrap, the next page https://huntfordm.vercel.app/tutorial/interactivelens has the dark matter blob that I can’t move by touch ( and the text overlaps the Next button, probably the font size needs to scale with the viewport up to some max?).
…
________________________________ From: Aditya Yadav @.> Sent: Sunday, July 23, 2023 7:43:36 PM To: CosmoPars/huntfordm @.> Cc: Antony Lewis @.>; Comment @.> Subject: Re: [CosmoPars/huntfordm] Question: Support for vertical/horizontal/both support. (Issue #1) I fixed the modal div popup error. I was not able to reproduce the slider stuck error on any of the pages. I tried to move all the slider and they worked fine. You might want to try refreshing the page once. — Reply to this email directly, view it on GitHub<#1 (comment)>, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AA6GQI5AOVYGFV36U4KIPITXRVPERANCNFSM6AAAAAA2TY3HCA. You are receiving this because you commented.Message ID: @.***>

I fixed the word wrap and the interactive lens.

You'll have to ask UpWork what's going on there. I see things like this on desktop still

and more.

On  iPad I still get message at being about being optimized for desktop, and I can't close  the Help modal popup because Close button not visible. Also the first up-down slider till mostly doesn't work by touch (moves the page instead). The object now moves OK.
"We've hidden some dark matter for you" slightly overlaps the image.

tutorial/ending, touching in the image grid to find the dark matter doesn't seem to work..

Desktop

Tablet

https://huntfordm-aadi58002.vercel.app/tutorial/mass

Desktop

Tablet

https://huntfordm-aadi58002.vercel.app/tutorial/interactivelens

Please use the vercel link on which i am deploying to check for the updated site

(Please test things carefully yourself,  the idea is not to use the employer as test service! Testing is usually 50% of the work)

You'll have to ask UpWork what's going on there. I see things like this on desktop still

and more.

Ok I will test on most thing I can today.
Can you tell me the device you got these screenshots on ?
I have been using my browser to test on tablet mode for 1080px width in landscape and 810px in width in portrait mode.

Those screenshots were on desktop window (not full screen, not in emulator).  You should be able to freely re-size the desktop window to see what it looks like for a plausible range of desktop and tablet-like sizes.

It was the vercel link

On iPad the slider here is also way off

From: Aditya Yadav @.>
Sent: Monday, July 24, 2023 8:31:32 AM
To: CosmoPars/huntfordm @.>
Cc: Antony Lewis @.>; Comment @.>
Subject: Re: [CosmoPars/huntfordm] Question: Support for vertical/horizontal/both support. (Issue #1)
Please use the vercel link on which i am deploying to check for the updated site
—
Reply to this email directly, view it on GitHubhttps://github.com/CosmoPars/huntfordm/issues/1#issuecomment-1647295027, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AA6GQIY2UVNAKH4T6FDMFM3XRYJEJANCNFSM6AAAAAA2TY3HCA.
You are receiving this because you commented.Message ID: @.***>

https://huntfordm-aadi58002.vercel.app/tutorial -> I check all pages on the sizes which i think are in ranges of Tablet.

I still see some things like this where font scaling seems wrong

I increases the range on which the changes should take effect. It should make it so that text and images don't collide now

@.***

@.***

I don't get what you mean here

Hmm , looks like github did something weird with the pic, trying again:

Something is off with vertical alignment now on most pages e.g.

Can you send me a pic where i mentions my username or shows my profile picture. You may have hired someone else.
My upwork profile -> https://www.upwork.com/freelancers/~019e1ce9bbbf97b2c6

The profile is called “Nusair A.” is that not you? Did you post messages on github but not on upwork ,and before being accepted? I assumed you were him just with a different username on gitthub – the messages on github started just after I stopped communicating with him on upwork.
From: Aditya Yadav @.>
Sent: 25 July 2023 02:21
To: CosmoPars/huntfordm @.>
Cc: Antony Lewis @.>; Comment @.>
Subject: Re: [CosmoPars/huntfordm] Question: Support for vertical/horizontal/both support. (Issue #1)
Can you send me a pic where i mentions my username or shows my profile picture. You may have hired someone else.
My upwork profile -> https://www.upwork.com/freelancers/~019e1ce9bbbf97b2c6
—
Reply to this email directly, view it on GitHubhttps://github.com/CosmoPars/huntfordm/issues/1#issuecomment-1648791057, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AA6GQI37ZJF7YRGBVJQJUPDXR4GP3ANCNFSM6AAAAAA2TY3HCA.
You are receiving this because you commented.Message ID: @.***>

I wanted to confirm if you are good with my code before I applied to you on upwork. my name are common across all my account. My name is Aditya Yadav and my username name is aadi58002

Let me check what the person hired is up to

Any update on the matter ?

They say they are working on it. For future you shouldn't start working on something before being accepted, this confusion has potentially wasted quite lot of both our time. (but if the other guy doesn't deliver by the end of the week, I can try to assign you instead)

You don't seem to be on the list of bids for the project? When can you complete it and what would be your bid?

The job status shows that the job is no longer available.
Completion time can vary but it max it should be around 4-5 days at max
Bid -> Same as you posted on the job 100$

Try this
https://www.upwork.com/jobs/~01c81c68486d697917
Looks like you've done most of it already, so would be good to have most done today if possible ready for further testing by my collaborators.

Try this https://www.upwork.com/jobs/~01c81c68486d697917
Looks like you've done most of it already, so would be good to have most done today if possible ready for further testing by my collaborators.

I let you know when the issues you mentions are resolved

I made the changes can you see if you like any more changes ?

On the front page the help button position, and the help button  popup alignment is wrong.

And this

And this. You really need to test things more carefully yourself.

I adjusted the font so that it smaller if there is not enough height to the screen.

There still seems to be some overlap here:

The "This what we see" box also tends to hind the thing it is talkign about

Ok i changed the resize changes limits to be bigger.

Are you confident that if I try this on my iPad I will not find any more obvious issues? If not, then you should test more yourself.
At the moment the first screen still gives the warning about being optimized for desktop. And the Help pop-up on the next screen still does not work correctly as mentioned previously (cannot close it).

I fixed the warning message on the first page. As for the pop up on the rest of the pages

There should be the red cross mark on top right.

By help popup I meant the "?" help button.

It should be fixed now.I checked the help button on both landscape and portrait mode.

What did you change? on iPad landscape the still doesn't fit my screen and close button is not visible (and it does not scroll)

On /interactivelens, touch dragging the mass and slider also doesn't work (or is unusably slow/unresponsive)

If it is cpu bound, seems it must be triggering computations too frequently, eg once per touch event, when it should be triggering much less frequently ?

From: Aditya Yadav @.>
Sent: Wednesday, August 2, 2023 10:36:49 AM
To: CosmoPars/huntfordm @.>
Cc: Antony Lewis @.>; Comment @.>
Subject: Re: [CosmoPars/huntfordm] Question: Support for vertical/horizontal/both support. (Issue #1)
On /interactivelens, touch dragging the mass and slider also doesn't work (or is unusably slow/unresponsive)
The interactive lens functionality is a cpu bound task. It works fluent in tablet mode for desktop. This is not a problem with the website rather a limitation of the hardware.
—
Reply to this email directly, view it on GitHubhttps://github.com/CosmoPars/huntfordm/issues/1#issuecomment-1661755209, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AA6GQIZ4F6MHI6SXJGRRIW3XTIGSDANCNFSM6AAAAAA2TY3HCA.
You are receiving this because you commented.Message ID: @.***>

The previous developer for this site seems to have created a personal library implementation for it. But changing it for mobile specific event will require a rewrite or major changes to it.

I didn't change any logic in the code I have been some minor js and CSS tweaks.

It works fluently on my phone

If it works on phone it can’t be a cpu power issue. It seems to sometimes work better than others. I suspect the underlying issue is how updates are triggered from touch events. It does seem to be specific to tablet touch.

From: Aditya Yadav @.>
Sent: Wednesday, August 2, 2023 3:47:50 PM
To: CosmoPars/huntfordm @.>
Cc: Antony Lewis @.>; Comment @.>
Subject: Re: [CosmoPars/huntfordm] Question: Support for vertical/horizontal/both support. (Issue #1)
I didn't change any logic in the code I have been some minor js and CSS tweaks.
[Screenshot_20230802-191550]https://user-images.githubusercontent.com/96418027/257833591-1aed1035-cfb5-4875-a72a-80633d29fc93.png
It works fluently on my phone
—
Reply to this email directly, view it on GitHubhttps://github.com/CosmoPars/huntfordm/issues/1#issuecomment-1662246864, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AA6GQIYIPHHFU7J4LXCS2VTXTJLANANCNFSM6AAAAAA2TY3HCA.
You are receiving this because you commented.Message ID: @.***>

I force restarted Safari, and then worked ok. Weird.

From: Antony Lewis @.>
Sent: Wednesday, August 2, 2023 4:22:55 PM
To: CosmoPars/huntfordm @.>; CosmoPars/huntfordm @.>
Cc: Comment @.>
Subject: Re: [CosmoPars/huntfordm] Question: Support for vertical/horizontal/both support. (Issue #1)
If it works on phone it can’t be a cpu power issue. It seems to sometimes work better than others. I suspect the underlying issue is how updates are triggered from touch events. It does seem to be specific to tablet touch.

From: Aditya Yadav @.>
Sent: Wednesday, August 2, 2023 3:47:50 PM
To: CosmoPars/huntfordm @.>
Cc: Antony Lewis @.>; Comment @.>
Subject: Re: [CosmoPars/huntfordm] Question: Support for vertical/horizontal/both support. (Issue #1)
I didn't change any logic in the code I have been some minor js and CSS tweaks.
[Screenshot_20230802-191550]https://user-images.githubusercontent.com/96418027/257833591-1aed1035-cfb5-4875-a72a-80633d29fc93.png
It works fluently on my phone
—
Reply to this email directly, view it on GitHubhttps://github.com/CosmoPars/huntfordm/issues/1#issuecomment-1662246864, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AA6GQIYIPHHFU7J4LXCS2VTXTJLANANCNFSM6AAAAAA2TY3HCA.
You are receiving this because you commented.Message ID: @.***>

(The help button text stil does not show correctly on landscape iPad)

If it works on phone it can’t be a cpu power issue. It seems to sometimes work better than others. I suspect the underlying issue is how updates are triggered from touch events. It does seem to be specific to tablet touch.
…
________________________________ From: Aditya Yadav @.> Sent: Wednesday, August 2, 2023 3:47:50 PM To: CosmoPars/huntfordm @.> Cc: Antony Lewis @.>; Comment @.> Subject: Re: [CosmoPars/huntfordm] Question: Support for vertical/horizontal/both support. (Issue #1) I didn't change any logic in the code I have been some minor js and CSS tweaks. [Screenshot_20230802-191550]https://user-images.githubusercontent.com/96418027/257833591-1aed1035-cfb5-4875-a72a-80633d29fc93.png It works fluently on my phone — Reply to this email directly, view it on GitHub<#1 (comment)>, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AA6GQIYIPHHFU7J4LXCS2VTXTJLANANCNFSM6AAAAAA2TY3HCA. You are receiving this because you commented.Message ID: @.***>

Tablet cpu are more often than not worse than modern phones. My phone is high spec I just checked on it to see if it was a wrong trigger of query or javascript code bug.

Also on desktop some fonts now look much smaller than they were originally, and there's now overlap here

note scroll bars have appeared, so looks like something wrong with page size layout.

Also on desktop some fonts now look much smaller than they were originally, and there's now overlap here
* note scroll bars have appeared, so looks like something wrong with page size layout.

It is looking smaller because there is not enough height to display both the image and text.
And the screen size you are viewing at i don't see where i can put the text so that it does not conflict with the image.
I can fold it but it will increase the text overall height and it still might overlap with the image.

I can show a warning saying screen height is too low if you see it as a better option.

Presumably the images should just scale so that things fit?

From: Aditya Yadav @.>
Sent: Thursday, August 3, 2023 3:26:59 PM
To: CosmoPars/huntfordm @.>
Cc: Antony Lewis @.>; Comment @.>
Subject: Re: [CosmoPars/huntfordm] Question: Support for vertical/horizontal/both support. (Issue #1)
I can show a warning saying screen height is too low if you see it as a better option.
—
Reply to this email directly, view it on GitHubhttps://github.com/CosmoPars/huntfordm/issues/1#issuecomment-1663983748, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AA6GQI44ERJLT3ONFP4RZ73XTORKHANCNFSM6AAAAAA2TY3HCA.
You are receiving this because you commented.Message ID: @.***>

(The screen shot I sent looked fine in the original version)

From: Antony Lewis @.>
Sent: Thursday, August 3, 2023 4:10:18 PM
To: CosmoPars/huntfordm @.>; CosmoPars/huntfordm @.>
Cc: Comment @.>
Subject: Re: [CosmoPars/huntfordm] Question: Support for vertical/horizontal/both support. (Issue #1)
Presumably the images should just scale so that things fit?

From: Aditya Yadav @.>
Sent: Thursday, August 3, 2023 3:26:59 PM
To: CosmoPars/huntfordm @.>
Cc: Antony Lewis @.>; Comment @.>
Subject: Re: [CosmoPars/huntfordm] Question: Support for vertical/horizontal/both support. (Issue #1)
I can show a warning saying screen height is too low if you see it as a better option.
—
Reply to this email directly, view it on GitHubhttps://github.com/CosmoPars/huntfordm/issues/1#issuecomment-1663983748, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AA6GQI44ERJLT3ONFP4RZ73XTORKHANCNFSM6AAAAAA2TY3HCA.
You are receiving this because you commented.Message ID: @.***>

Presumably the images should just scale so that things fit?
…
________________________________ From: Aditya Yadav @.> Sent: Thursday, August 3, 2023 3:26:59 PM To: CosmoPars/huntfordm @.> Cc: Antony Lewis @.>; Comment @.> Subject: Re: [CosmoPars/huntfordm] Question: Support for vertical/horizontal/both support. (Issue #1) I can show a warning saying screen height is too low if you see it as a better option. — Reply to this email directly, view it on GitHub<#1 (comment)>, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AA6GQI44ERJLT3ONFP4RZ73XTORKHANCNFSM6AAAAAA2TY3HCA. You are receiving this because you commented.Message ID: @.***>

The image can not scale as it is the background image and is predefined with its location and size.
https://github.com/aadi58002/huntfordm/blob/main/apps/grav-lensing/src/assets/img/stackingstill4.png
https://github.com/aadi58002/huntfordm/blob/main/apps/grav-lensing/src/assets/img/stackingstill3.png
https://github.com/aadi58002/huntfordm/blob/main/apps/grav-lensing/src/assets/img/stackingstill2.png
https://github.com/aadi58002/huntfordm/blob/main/apps/grav-lensing/src/assets/img/stackingstill.png

It is fine (and with no scroll bars) on the original so this must be something you have changed. You should try to fix things rather than trying to find reasons why they can't be fixed.

It is fine (and with no scroll bars) on the original so this must be something you have changed. You should try to fix things rather than trying to find reasons why they can't be fixed.

It should resize according to the height of the available screen now.

(The help button text still does not show correctly on landscape iPad)

I also looked into this but i can still see reproduce this issue.

If you can give me your email I can forward with screenshots.

This is what I see on iPad for help button pop up.

If you can give me your email I can forward with screenshots.

<EMAIL_ADDRESS>

This should be fixed now

Hello, I'm the "key external tester who will be hosting site" that cmbant mentioned earlier. Thanks for doing all this work.
With the galaxy stacking animation pages, in the current version, you appear now to have just removed the background images that had the grid of galaxies, and stacked images (i.e. on pages like: https://huntfordm-aadi58002.vercel.app/tutorial/stackedgalaxies2). This makes the screen flicker when one loads each new page, because for a tiny fraction of a second the grid disappears. In the original version this effect was minimised because the background image was changed to one with the grid in it (and these background images were pre-loaded when someone loads the app itself). While the app didn't work well on mobile, at least on desktop the experience was pleasant. Ideally, we would still have the background images with the grid in them, but they would rescale exactly how the video rescales, so that on any screen the grid in the image and the grid in the video are placed precisely on top of each other. In the dm.sharingresearch.com version this was what happened on any screen size.
I think cmbant and I have a difference in opinion about how we should warn people about mobile devices. I prefer the warning on the loading screen, i.e. how it was before, where perhaps we could also give an instruction to tell people to put their device in landscape mode. This way the warning is given once, to all mobile users, and they can carry on. I don't like the new method, which doesn't warn anyone in advance, and then repeatedly warns on every new screen later on.
On this page: https://huntfordm-aadi58002.vercel.app/tutorial/mass the page opens without the light rays bending now. I'm confused as to why, because as soon as one clicks on the slider they bend, even if you don't move the slider. Again, on the https://dm.sharingresearch.com/tutorial/mass version the rays are bent as soon as the page opens.

Thanks for testing the site repeatedly.I have tried to do the best i can to
look for bugs and such but i don't have a tablet device so there were many
which i didn't notice.
As for the first point about video and the background image. You are
correct that I replaced the background image to a pure galaxy image without
the grid. I didn't see any way for the background image and the video to be
resized together. Since both grow and shrink at different rates. As the
video does not have enough space below it to show all the tutorial text
which is shown there (image below). In this case either the video has to
shrink or overlap with the image will occur. If you have a solution in mind
please let me know.
[image: image.png]
Regarding the second point. I can convert the popup so that it is just a
warning text which does not obstruct the rest of the website (image
below).I think a non obstructive popup like this should work as a
warning.If i was a user of the site i also won't want to keep clicking the
cross sign on near the top each time a new page occurs ( just personal
opinion ).
[image: image.png]
I fixed the snapping of light beams on the desktop page and minimize it on
the tablet size page. I try to remove it from the tablet size page as well.
On Sat, 5 Aug 2023 at 01:19, shaunhotchkiss @.***>
wrote:

Hello, I'm the "key external tester who will be hosting site" that cmbant
mentioned earlier. Thanks for doing all this work.
With the galaxy stacking animation pages, in the current version, you
appear now to have just removed the background images that had the grid of
galaxies, and stacked images (i.e. on pages like:
https://huntfordm-aadi58002.vercel.app/tutorial/stackedgalaxies2). This
makes the screen flicker when one loads each new page, because for a tiny
fraction of a second the grid disappears. In the original version this
effect was minimised because the background image was changed to one with
the grid in it (and these background images were pre-loaded when someone
loads the app itself). While the app didn't work well on mobile, at least
on desktop the experience was pleasant. Ideally, we would still have the
background images with the grid in them, but they would rescale exactly
how the video rescales, so that on any screen the grid in the image and
the grid in the video are placed precisely on top of each other. In the
dm.sharingresearch.com version this was what happened on any screen size.
I think cmbant and I have a difference in opinion about how we should warn
people about mobile devices. I prefer the warning on the loading screen,
i.e. how it was before, where perhaps we could also give an instruction to
tell people to put their device in landscape mode. This way the warning is
given once, to all mobile users, and they can carry on. I don't like the
new method, which doesn't warn anyone in advance, and then repeatedly warns
on every new screen later on.
On this page: https://huntfordm-aadi58002.vercel.app/tutorial/mass the
page opens without the light rays bending now. I'm confused as to why,
because as soon as one clicks on the slider they bend, even if you don't
move the slider. Again, on the
https://dm.sharingresearch.com/tutorial/mass version the rays are bent as
soon as the page opens.
—
Reply to this email directly, view it on GitHub
https://github.com/CosmoPars/huntfordm/issues/1#issuecomment-1666098074,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AW7TR254A7CSZRX3DIVTLMTXTVG6BANCNFSM6AAAAAA2TY3HCA
.
You are receiving this because you authored the thread.Message ID:
@.***>

--
Aditya Yadav
@.***

As for the first point about video and the background image. You are correct that I replaced the background image to a pure galaxy image without the grid. I didn't see any way for the background image and the video to be resized together. Since both grow and shrink at different rates. As the video does not have enough space below it to show all the tutorial text which is shown there (image below). In this case either the video has to shrink or overlap with the image will occur. If you have a solution in mind please let me know.

I don't fully understand this issue. On the original, they both take up the full screen and rescale exactly the same, and the tutorial text fits beneath the grid. On a smaller screen, would it not work to just shrink the text so that it still fits under the grid? Or is the issue not so much smaller screen size, but different screen dimension? (i.e. if the screen is too wide?)
If I understand correctly from looking at the images, what you've done is move the video up a bit, so that there is always room underneath it for the text and button. In principle that's fine as a solution. Could the exact same re-positioning not be done for the images that have the grid and are pre-loaded?
So, could there be the normal background image (i.e. the one that is present on most screens) at the back of the screen. Then placed on top of that, the translated and rescaled images that have the grid in them (the ones that are the first frame of the video and are pre-loaded). Can that be done so that the video and image rescale on top of each other?

As for the first point about video and the background image. You are correct that I replaced the background image to a pure galaxy image without the grid. I didn't see any way for the background image and the video to be resized together. Since both grow and shrink at different rates. As the video does not have enough space below it to show all the tutorial text which is shown there (image below). In this case either the video has to shrink or overlap with the image will occur. If you have a solution in mind please let me know.

I tried to do that at first but doing that will either result in video going clipping at the top or the text size being too small to read. The below amount of text can't be resized to be both readable and fit in the space below the video. Also the button need space so that they don't overlap with the text.

I don't fully understand this issue. On the original, they both take up the full screen and rescale exactly the same, and the tutorial text fits beneath the grid. On a smaller screen, would it not work to just shrink the text so that it still fits under the grid? Or is the issue not so much smaller screen size, but different screen dimension? (i.e. if the screen is too wide?)
If I understand correctly from looking at the images, what you've done is move the video up a bit, so that there is always room underneath it for the text and button. In principle that's fine as a solution. Could the exact same re-positioning not be done for the images that have the grid and are pre-loaded?

I made so that the video resizes relative to the max possible width it can have. Then its height changes according to aspect ratio.

So, could there be the normal background image (i.e. the one that is present on most screens) at the back of the screen. Then placed on top of that, the translated and rescaled images that have the grid in them (the ones that are the first frame of the video and are pre-loaded). Can that be done so that the video and image rescale on top of each other?

That is a good idea i tried it. It reduced the flicker but there is still a very small flicker where the first bg is loaded first then the send bg and then the video.

It is looking quite playable on iPad, I think the alignment in the winning page is a bit off though

(Worse on portrait, button widths wrong)

I fixed the game page.

Thanks

I made so that the video resizes relative to the max possible width it can have. Then its height changes according to aspect ratio.

This doesn't sound the best solution - video does not have to have max possible with if a smaller width would improve vertical layout?
When everything is working, please make a PR with the changed code and I can clear the payment.

This doesn't sound the best solution - video does not have to have max possible with if a smaller width would improve vertical layout?

I don't get what you mean here in which case will it be better if video didn't occupy the complete width.
( It also shows a warning in portrait mode that landscape has a better experience )

The screen shot  looks like landscape but showing the warning?
Didn’t you accept he job offer on upwork? I got a message that it expired.

From: Aditya Yadav @.>
Sent: Sunday, August 6, 2023 3:38:25 PM
To: CosmoPars/huntfordm @.>
Cc: Antony Lewis @.>; Comment @.>
Subject: Re: [CosmoPars/huntfordm] Question: Support for vertical/horizontal/both support. (Issue #1)
This doesn't sound the best solution - video does not have to have max possible with if a smaller width would improve vertical layout?
I don't get what you mean here in which case will it be better if video didn't occupy the complete width.
( It also shows a warning in portrait mode that landscape has a better experience )
[image]https://user-images.githubusercontent.com/96418027/258645813-77a3002a-a928-4b96-b48e-2f2962840813.png
—
Reply to this email directly, view it on GitHubhttps://github.com/CosmoPars/huntfordm/issues/1#issuecomment-1666863354, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AA6GQI7ELVLVGTRSLNEFQMLXT6M5DANCNFSM6AAAAAA2TY3HCA.
You are receiving this because you commented.Message ID: @.***>

I don't get what you mean here in which case will it be better if video didn't occupy the complete width.

I guess the problem would come with very wide screens in landscape mode (typical of most cellphones nowadays) where by occupying the full width, the video can no longer fit vertically.
You and cmbant have the contract here, so I won't involve myself in what is/isn't in scope, but the long term solution in such a situation would probably be to have the video play on the left 50% of the screen and the text/buttons appear on the right.

The screen shot  looks like landscape but showing the warning?

I'm not sure we can tell for sure, as we can't see the full screen in Aditya's screenshot. It could continue down much further. I think the warning message kicks in based on screen width, independently of the orientation. That's probably desired though, as a very small landscape screen still won't have a good experience.

I tested it on ultra wide and i think it showing the video at center and text and button on either side is a good way to display thing .

I created the PR.

Thanks, why didn’t you accept the job on upwork? Not sure what to do now,

From: Aditya Yadav @.>
Sent: Monday, August 7, 2023 6:48:31 PM
To: CosmoPars/huntfordm @.>
Cc: Antony Lewis @.>; Comment @.>
Subject: Re: [CosmoPars/huntfordm] Question: Support for vertical/horizontal/both support. (Issue #1)
I created the PR.
—
Reply to this email directly, view it on GitHubhttps://github.com/CosmoPars/huntfordm/issues/1#issuecomment-1668245968, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AA6GQI5EHIGC6ETTPX74JOTXUEL57ANCNFSM6AAAAAA2TY3HCA.
You are receiving this because you commented.Message ID: @.***>

Thanks, why didn’t you accept the job on upwork? Not sure what to do now,
…
________________________________ From: Aditya Yadav @.> Sent: Monday, August 7, 2023 6:48:31 PM To: CosmoPars/huntfordm @.> Cc: Antony Lewis @.>; Comment @.> Subject: Re: [CosmoPars/huntfordm] Question: Support for vertical/horizontal/both support. (Issue #1) I created the PR. — Reply to this email directly, view it on GitHub<#1 (comment)>, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AA6GQI5EHIGC6ETTPX74JOTXUEL57ANCNFSM6AAAAAA2TY3HCA. You are receiving this because you commented.Message ID: @.***>

I accepted it but after that a week passed and I was over the deadline and I think it automatically unassigned me

Do you see any options on your end to increase the deadline if not I think I might have to reapply for the upwork job

I have sent a message to you on upwork. Can you give me a reply for it.

The money is deposited with them, so ideally. Via upwork. (I’m now on holiday)

From: Aditya Yadav @.>
Sent: Wednesday, August 9, 2023 2:20:31 PM
To: CosmoPars/huntfordm @.>
Cc: Antony Lewis @.>; Comment @.>
Subject: Re: [CosmoPars/huntfordm] Question: Support for vertical/horizontal/both support. (Issue #1)
I have sent a message to you on upwork. Can you give me a reply for it.
—
Reply to this email directly, view it on GitHubhttps://github.com/CosmoPars/huntfordm/issues/1#issuecomment-1671222829, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AA6GQIYSDTWCVY37GYZH3ODXUN6A7ANCNFSM6AAAAAA2TY3HCA.
You are receiving this because you commented.Message ID: @.***>


Accessible button

[x] https://github.com/CliffCloud/Leaflet.LocationShare/commit/87cb18a63b1e4e3e14f89afbf60fa74bddd9a064 hides the image element from screen readers.
See related resources:

https://github.com/Leaflet/Leaflet/blob/37d2fd15ad6518c254fae3e033177e96c48b5012/src/layer/tile/TileLayer.js#L146-L156
https://www.w3.org/WAI/tutorials/images/decorative/

[x] https://github.com/CliffCloud/Leaflet.LocationShare/commit/1395d2aa78f79adf2e7c76d834114ba3dc5f42e3 adds role=button so that screen readers announce "button" as opposed to "link" when focused.
See related resources:

https://github.com/Leaflet/Leaflet/blob/e76f97cba319d97482e395279000ac95de5a8d99/src/control/Control.Zoom.js#L91
https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/button_role

A very nice PR. Thank you.


RFC: add API to return a list of all devices

This RFC proposes to add an API to the standard for returning the list of devices. Currently, the only standardized means for an array API consumer to access a device object is by creating an array and accessing the .device attribute.
>>> x = xp.zeros((2, 2))
>>> d = x.device

More generally, the standard currently lacks APIs for device inspection, and device objects are unspecified, apart from required support for equality comparison. To aid in introspection and scripting/REPL envs, having a means for getting the list of devices would be useful, especially when probing the capabilities of an unknown platform.
Prior art
JAX
jax.devices(backend=None) -> List[Device]

Returns the list of devices from the default backend (e.g., gpu, tpu, or cpu).
jax.local_devices(process_index=None, backend=None, host_id=None)

Returns a list of devices local to a given process.
Proposal
devices() -> List[device]

The proposed API would be a nullary function which returns a list of device objects.
Notes

Currently, when not provided a backend kwarg, JAX returns the list of devices for the default backend. I am not sure whether this is preferred compared to returning a list of devices across all backends.

Related

https://github.com/data-apis/array-api/issues/499

This RFC has been superseded by #640.


Is: "Operators should always return an Observable" valid for rxjs 6?

Documentation Related To Component:

Please check those that apply

[ ] typo
[ ] documentation doesn't exist
[X] documentation needs clarification
[ ] error(s) in example
[ ] needs example

Description Of The Issue

In this section: https://github.com/ReactiveX/rxjs/blob/master/doc/operator-creation.md#guidelines
I read the following:

Operators should always return an Observable. You're performing operations on unknown sets of things to create new sets. It only makes sense to return a new set. If you create a method that returns something other than an Observable, it's not an operator, and that's fine.

According to the above, map() should not be considered an operator because it does not return an observable. It returns a function.
A contradicting definition(described here):

"Operators take configuration options, and they return a function that takes a source observable. When executing this returned function, the operator observes the source observable’s emitted values, transforms them, and returns a new observable of those transformed values"

I guess that this is an old definition when pipeable operators weren't around. Before pipeable operators were introduced (I think in version 5.5 of RxJS), operators were returning Observables. An old map() implementation indicates just that.
This outdated problem seems to affect the whole /doc folder. Contents of the many files from this folder are mainly outdated and seems like this documentation is not being updated regularly.
Can I have someone from the core team to explain what should be done with the contents from /doc folder since this is clearly outdated documentation that needs some big rewrites or maybe deletion?

I think that this issue can be closed as the old /docs is removed now. This documentation was obsolete.

As suggested I will close this issue. If there is anything else needed to do about this, feel free to reopen this issue


DataTable Issuse

I use this template , I like it so much. but I have problem with datatable in responsive design. when I preview in mobile it not work correctly as responsive , anyone help?

We have completely redone dataTables, could you please check if everything is working correctly now.


fix: unit tests depending on docker

Depends on #2180
Unit tests for storages were all ignoring failures (such as CouchDB or MySQL not running). This completely undermined confidence in any of these tests... a real mess.
This patch only ignores these tests when running in GitHub actions using the 'macOS-10.15' virtual environment. Issue #2183 was opened to track the problem of not running these tests in the macOS CI in the first place.
Signed-off-by: George Aristy<EMAIL_ADDRESS>

@llorllale I was also thinking about it. But I would suggest using github.com/ory/dockertest/v3 package. In that case, we don’t need to play with docker. It works fine on the local machine (Linux/mac). But it will not work on CI for mac. Since mac (on CI) doesn’t have docker. So, my suggestion is to remove unit tests for mac on CI. What do you think about it?
It will allow us to run the test just hitting the run button in idea.
@troyronda

@soluchok

@llorllale I was also thinking about it. But I would suggest using github.com/ory/dockertest/v3 package. In that case, we don’t need to play with docker. It works fine on the local machine (Linux/mac). But it will not work on CI for mac. Since mac (on CI) doesn’t have docker. So, my suggestion is to remove unit tests for mac on CI. What do you think about it?
It will allow us to run the test just hitting the run button in idea. No need to run docker images manually.

Still depends on docker so it won't work on macOS in the CI (as you said)
We should not remove unit tests for mac in the CI. Why would we do this? I'm wondering why we don't include windows in there as well...
The current build script runs each docker container once per run. I think your intention is to have each test package run its own container? Won't that make the tests run longer? I like the idea of compartmentalizing each test package, but also appreciate fast builds... and our build is dreadfully slow ...

@llorllale The current build script runs each docker container once per run. - it runs one docker container per test package. It will not strongly impact on execution time.

@soluchok

@llorllale The current build script runs each docker container once per run. - it runs one docker container per test package. It will not strongly impact on execution time.

I believe you meant to say "it will run one docker container per test package". Because currently only one container is ran per test run.

@soluchok let me do some tests to compare the timing diifference

@soluchok let me do some tests to compare the timing diifference

Sure. Since we are ignoring decker tests for mac on CI I think it makes sense to usedockertest  package. I am not saying to use it in this PR. We can create an issue. But, It would simplify our life :)

@soluchok

I am not saying to use it in this PR. We can create an issue.

I tend to agree... I'm wondering why each storage implementation is duplicating tests from the parent package... is it for test coverage?

@soluchok

I am not saying to use it in this PR. We can create an issue.

I tend to agree... I'm wondering why each storage implementation is duplicating tests from the parent package... is it for test coverage?

Yes, it is for coverage.

@soluchok we should explore the dockertest option in a separate issue.
FYI: I did a quick test and ran into an IDE quirk... basically my IDE's test report feature doesn't work for some reason:

The tests do pass on the command line.

@troyronda @fqutishat added the following as required checks:

Unit test (macOS-10.15)
Unit test wasm


teach miri to use intrinsics' fallback bodies

And then replace lots of our SIMD and numeric  shims with fallback bodies by adding said fallback bodies to libcore.
Note that we need to take lots of care to preserve UB.
This may regress diagnostics quality, so maybe we need some sort of unreachable_unchecked intrinsic equivalent which can be passed a string that explains the UB?

I think we may want to require some sort of opt-in here, like #[rustc_intrinsic_fallback_fit_for_miri] or so, so that one can locally review in the intrinsic body whether the requirement is upheld.

Isn't this a duplicate of https://github.com/rust-lang/miri/issues/3302?


feat(upgrade): add set flag in upgrade

Helm doesn't validates the  value passed
Example
root@ashish-dev:~/code/rust/mayastor-extensions(set-flag)$ helm install mayastor mayastor/mayastor -n mayastor --create-namespace --version 2.3.0 --set='alpha=beta,gamma={30,101}'
NAME: mayastor
LAST DEPLOYED: Wed Aug  9 06:26:30 2023
NAMESPACE: mayastor
STATUS: deployed
REVISION: 1
NOTES:
OpenEBS Mayastor has been installed. Check its status by running:
$ kubectl get pods -n mayastor

Upon getting the values
root@ashish-dev:~/code/rust/mayastor-extensions(set-flag)$ helm get values mayastor --all  -n mayastor  -oyaml > ~/test.yaml

The values present in test.yaml
root@ashish-dev:~$ grep -i alpha  test.yaml
alpha: beta
root@ashish-dev:~$ grep -i -C 4 gamma  test.yaml
      limits: {}
      requests: {}
eventing:
  enabled: false
gamma:
- 30
- 101
image:
  pullPolicy: IfNotPresent

So , we don't need to validate the values passed, Its just that we need to validate the format.
This PR validates by running helm upgrade --dry-run command .
root@ashish-dev:~/code/rust/mayastor-extensions(set-flag)$ ./target/debug/kubectl-mayastor  upgrade --set obs.callhome.enabled=false,a={1,2  --skip-upgrade-path-validation-for-unsupported-version

Volumes which make use of a single volume replica instance will be unavailable for some time during upgrade.
It is recommended that you do not create new volumes which make use of only one volume replica.

ServiceAccount: mayastor-upgrade-service-account-bbb created in namespace: mayastor
Cluster Role: mayastor-upgrade-role-bbb in namespace mayastor created
ClusterRoleBinding: mayastor-upgrade-role-binding-bbb in namespace mayastor created
Job: mayastor-upgrade-bbb created in namespace: mayastor

 The validation failed for upgrade, hence deleting teh upgrade resources. Please re-run upgrade with valid values.
 {"fromVersion":"2.3.0","toVersion":"0.0.0","message":"Failed to upgrade: `helm upgrade` command return an error,\ncommand: helm,\nargs: [\"upgrade\", \"mayastor\", \"/chart\", \"-n\", \"mayastor\", \"--timeout\", \"15m\", \"-f\", \"/chart/.tmpGpv2QI\", \"--set\", \"obs.callhome.enabled=false,a={1,2\", \"--atomic\", \"--dry-run\"],\nstd_err: Error: failed parsing --set data: list must terminate with '}'\n"}
Job mayastor-upgrade-bbb in namespace mayastor deleted
ClusterRoleBinding mayastor-upgrade-role-binding-bbb in namespace mayastor deleted
ClusterRole mayastor-upgrade-role-bbb in namespace mayastor deleted
ServiceAccount mayastor-upgrade-service-account-bbb in namespace mayastor deleted

bors merge

bors merge

bors merge


Fix unused parameters in proxy/http3 functionality

Fix unused parameters using /* name ATS_UNUSED */
This pull request is part of the effort for removing the -Wno-unused-parameter warning suppression.

[approve ci rocky]

You are right. I should have left these changes for tomorrow. To do them on a clear head.
I'm about to fix it.
And the other pull request is probably broken too.

The AuTest chunked_encoding_disabled failed.
           -       [DEBUG]: Response connection: keep-alive
           +       [DEBUG]: Response contained "Connection: close". Closing the connection for key: 1.
           +       [DEBUG]: Reading response header.
           +       [DEBUG]: Received an HTTP/1 200 response for key 2 with headers:

[approve ci autest]

Cherry-picked to v10.0.x


Drag and drop from Explorer onto VS Code multiple times resulted in "associated text model is undefined" error.

VSCode Version: 1.2.1
OS Version: 10586.318

Steps to Reproduce:

Open VS Code (only instance with --disable-extensions)
Drag a file in to VS Code to open
Close file
Remove from file list (multiple times)
Repeat 2-4 several times.
Encounter the following error:

From then on, unable to open that file despite it being a valid file.

Restarting VS Code fixes the problem.
(I have had difficulty reproing this issue myself -- I'm not sure how to better reproduce the issue.)
Discovered while trying to repro https://github.com/Microsoft/vscode/issues/7787

@dilijev does it reproduce using our insiders build?
We are releasing preview releases of the next stable VS Code version for everyone to try and give feedback. These preview releases are not 100% tested and might be unstable but contain our latest features and bugfixes. You can give our preview releases a try from: http://code.visualstudio.com/Download#insiders

@bpasero Thanks for pointing me to the preview release. I'll run that for a while and see if I happen to observe this again.

Ok please comment if it reproduces. We can reopen then.

Yes, things seem to work better now. I'll let you know if I see any further problems.


Prevent remove_invisible_characters from removing url encoded characters from db drivers like statements (that don't need escaping)

In CI3, escapeString passed false to remove_invisible_characters. CI4 doesn't. This removes characters if they fall within %0[0-8bcef] and %1[0-9a-f]. Beginning of LIKE binds start with %. Drivers should use their own _escapeString function (document?). SQLSRV doesn't necessarily need to be escaped.

I'll let it slide this time, but in the future a couple of things:
1 - keep PRs to one topic. You've mixed two here (the crop change and the invisible characters change.)
2. - We like contributions to have the code signed.

Honestly, I didn't really know I did two changes in one PR. I'm still learning how to use github :(

No worries. It's a learning curve, but we appreciate it!


WPRDC: Non-traffic violation data

The WPRDC provides a dataset for non-traffic citations (NTCs, also known as "summary offenses") document low-level criminal offenses where a law enforcement officer or other authorized official issued a citation in lieu of arrest, available here: https://data.wprdc.org/dataset/non-traffic-citations. We need to pull this in just like the 311 and police data, getting the results from the past month. We should make sure this doesn't overlap with any other police data we're getting. It doesn't seem like it is.

Could I take this one @vonbearshark ? I'm relatively new to javascript, so it may not be perfect but I think I can do it.

I think you can, too @GavinFreud ! Let me know if you need any guidance at all. Make sure to pull the most recent changes first because we've updated how we're calling the data

@vonbearshark should I make a new icon for this?

Yeah take a look how we implement the others, as well as Font Awesome: http://fontawesome.io/icons/, you can pick one of those and a color, essentially


enable memcg notifications in kubelet

Kubelet responds to memory pressure by evicting pods gracefully to save
the system before kernel oomkiller kicks in. By default, kubelet polls
to check if memory thresholds have been crossed. This can be too slow in
scenarios where resource usage rises rapidly. This patch enables cgroup
notifications to the kubelet immediately when thresholds have been
reached.
Signed-off-by: Alexander Eldeib<EMAIL_ADDRESS>

I figured it's fine to stick in the same spot as the rest of kubelet config, since this mostly reflects the target AKS config already


Proposal for removing replace directive in go modules

[!NOTE]
This issue is NOT an RFC. The only reason this issue is opened here instead of a specific repo is because it applies to multiple areas (Diego,  Garden Containers, Networking) under app-runtime-platform and it was mentioned in monthly working-group meeting July 11th 2024

Problem
Over the years, we had to lock go dependencies to an older version of a component when we didn’t have the capacity to keep dependencies up-to-date. Now that we can keep up with updating required dependencies, we need to revisit those replace directives and remove them so that we can get the latest version of a dependent module.
This PR for groot-windows is one of latest issues we discovered when we decided to bump to go1.22. Thankfully this issue was resolved with minimal changes to groot-windows, but most of the time this is not the case. The problem arises when we need to do the bump (due to keeping up with security patches) and the work to do the bump is quite significant. This proposal aims to front-load all of the bump issues to now so that when the time comes for patching a security fix, the work has already been done.
Proposed Solution
We would start by removing every single replace directive to see what will fail in CI or at runtime.
There are 3 possible scenarios that can happen:

Newer dependency just works. This is the happy path and we would simply remove the replace directive.
Newer dependency fails CI and the fix is in our codebase. We would spend the time fixing our code so that it will be compatible with newer versions of the library.
Newer dependency fails CI and the fix is outside of our control.  This would be the case when the library is used inside of another library authored by someone else outside of the org. There are 2 possible ways we could approach this

Outer library is maintained and had a commit within the last year. This is the case where we would open an issue with the owner or try to fix the issue within the library.
Outer library is deprecated and not maintained. This is the case where we would look for alternative libraries or re-writing the logic in our codebase to not depend on this library.

If a dependency had to be kept around for the time being (Option 3i), we would create a replace-directive.yml file in CI under the repo dir with the following format:
---
replace_exceptions:
- module: code.cloudfoundry.org
  exceptions:
  - name: http://github.com/spf13/cobra
    reason:
       type: github_issue or github_pr
       refrence: https://github.com/link-to-issue
    expires_at: 2026-03-01

Additionally, there will be a concourse job for each pipeline that will validate the list defined in replace-directive.yml against what’s defined in the go.mod file of each repo. The job will go red when expires_at or closing of the issue/PR has been reached. For now, we would only care about github_issue and github_pr types, but maybe down the line there is a need to allow more types.
Since some of the pipelines contain submodules that are in itself a go-module (e.g. garden in garden-runc-release), replace-directive.yml is scoped by a module to accommodate defining multiple modules.
Development
Above proposal would require writing a new go binary that would utilize modfile package and github golang API to check whether an issue or PR is closed or not. Since we would probably get rate-limited by Github for unauthenticated access, the binary would require providing a token to authenticate requests. The input for the new binary would be a go.mod and replace-directive.yml and the output would be an error in stderr if issue/pr has been closed or expires_at has been reached.

cc @maxmoehl

Our list of dependencies which need to be bumped or replaced:

[x] routing-release: github.com/codegangsta/cli:v1.6.0 (cloudfoundry/routing-release/pull/423)
[ ] routing-release: github.com/golang-jwt/jwt/v4
[ ] routing-release: replace github.com/uber-go/zap:2016
[ ] routing-release: gopkg.in/yaml.v2
[ ] nats-release: github.com/nats-io/gnatsd:v1.4.1
[ ] nats-release: github.com/nats-io/go-nats:v1.7.2 (in progress by me)

/cc @plowin @Soha-Albaghdady

@maxmoehl is this still in progress?

@beyhan thanks for the reminder!
I've updated the list above. As we are not using and haven't contributed to routing-api we won't invest in bumping the jwt library from v4 to v5, although that should probably still be done. But since that's not a replace directive we could consider it out-of-scope for this issue.
gnatsd will have to stay for compatibility promises so it's out of scope for this issue to address that. @ameowlia is aware and will follow up.
From my side we can close this issue, @winkingturtle-vmw do you agree?

@maxmoehl thank you for the update! This is a WG related issue. Pls feel free to close it if it is completed.

I don't have write access so I can't close it. @winkingturtle-vmw please close this if you consider it complete.


Prevent player with no coins from gambling

See Gambling.cpp. Gambling can only occur when the player has at least the same amount of coins as CoinsDeduction. Check if the player has enough coins after GenerateValues() method is called. If they don't, return to the intermission menu.

working on it

Fixed by #25