Task backlinks show full links from heading text

Please check that this issue hasn't been reported before.

[X] I searched previous Bug Reports didn't find any similar reports.

Expected Behavior
Task backlinks should "simplify" links in headings to just their display text.

Current behaviour
Currently, backlinks to headings that include a link include the full link.
Applies to markdown links and wikilinks both.
This can make the backlinks quite hard to read.

Steps to reproduce

Create a task under a heading with a link (markdown or wikilink)
Display the task

I have made an example vault for this, let me know if I should link to it.
Which Operating Systems are you using?

[ ] Android
[ ] iPhone/iPad
[ ] Linux
[X] macOS
[ ] Windows

Obsidian Version
1.4.16
Tasks Plugin Version
5.0.0
Checks

[X] I have tried it with all other plugins disabled and the error still occurs

Possible solution
No response

Hi, your sample vault would be greatly appreciated please.
ideally by making a .zip and attaching it in a comment in this ticket.
Thanks in advance.

Here you go
sample.zip

Hi @ybnd, thanks very much, it's a lot clearer now that I've been able to experiment with it.
So I understand the problem.
Prior backlinks requests
I've given this the backlinks label and then looked at all backlinks requests:

Discussions - all open
Discussions - ideas open (that is, earlier feature requests)
Issues - open

I do think that this is a new description of the problem.
The request
Now I need to understand what the request actually is.
These are the two ways you have phrased it:

Task backlinks show full links from heading text
Task backlinks should "simplify" links in headings to just their display text.

But I think that the screenshot under 'Expected behaviour' makes it really clear.
If I understand it correctly, I think the request is effectively:

Since the entire backlink text is rendered a link ...
... there is no value in the heading component of the backlink displaying the destinations of any other kinds of links that are in the heading ...
... as URLS, wikilinks or markdown links are useless clutter that make the backlink harder to read.

Is that broadly what you mean?

Exactly!

Great, thanks - I've updated the title to (try to) clarify...
Thanks for the suggestion.


README suggestion: install a specific version?

I install nvm hoping to install a specific version of node.  I mean, that seems like the obvious use case for nvm.
I looked over the README and don't see a clear standout example of:
"If you want to install node 6.14.4 run this:"
code

This would go a long way.

Do the various examples in https://github.com/creationix/nvm#usage not indicate that you can provide any version pointer you like? nvm install 6.14.4 is how you’d do that, ftr.

It's not immediately obvious.  The README, imo should quickly get people started.
It doesn't immediately state what I'm asking for.  There are other examples, but nothing specifically calling out what (IMO) is the most common use case.  It's only by parsing text hidden in a paragraph ("In place of a version pointer like "0.10" or "5.0" or "4.2.1") and that line is not even explained prior.  What is a version pointer?
That's not efficient for someone who quickly needs to get this running.  People look for code blocks.  You can say RTFM but sometimes people don't have time to read pargraphs of text to find the info they need.

It’s not the most common use case, but I’m surprised it’s not obvious that to install X, you’d do nvm install x. If you’d like to make a PR that would have made it clearer to you, that’d be appreciated.

The most common use case is, ftr, “installthe latest node”, which is whynvm install node` appears first. Most people don’t have an explicit version to cleave to.

I have learned that nothing in the NodeJS community is ever obvious.  So no, I don't assume that nvm install 6.x is what has to be done.

It is pretty obvious to be honest and if you keep reading the usage section, you will find the following:

In place of a version pointer like "0.10" or "5.0" or "4.2.1", you can use the following special default aliases with nvm install, nvm use, nvm run, nvm exec, nvm which, etc:

That is followed by the list of aliases: node, iojs, stable and unstable.
At least to me, that makes it very clear that node is an alias that can be replaced by a version pointer to install a specific version.

@codiphile "pretty obvious"is subjective. The instructions aren't clear, and it's embedded in a paragraph instead of code blocks like I've added in my PR.

+1 to this, because I wasn't sure what the syntax for specifying the version # was based on the example in the README

Fixed in #1901.


CORS support

There needs to be support for CORS in serverless.yaml, similar to that provided by AWS

Thanks for the feedback, I'd add this feature when I'm updating the API GW service to use the new production service.
https://github.com/serverless/serverless-openwhisk/issues/53

Hello @shikhirsingh.
I've been investigating this and the short answer is I won't be able to include this feature for the upcoming release (0.7).
With the new API Gateway support, CORS is turned on by default for all APIs with the following headers. You do not need to configure this manually.
Access-Control-Allow-Methods: GET, POST, PUT, DELETE, PATCH, HEAD, OPTIONS
Access-Control-Allow-Origin: *

I want to provide support for turning it off and (if possible) controlling the header values as you can do with AWS Lambda + API Gateway. Looking into the code on how to do this, it's not simple and I'll need to spend more time understanding the APIs before I can get this ready. As I want to get the 0.7 release out this week, I'll have to move this feature back to a later release.
Thanks for opening this issue and giving me feedback, I'll plan to work on this for the 0.8 release.

@jthomas Did you get a chance to implement in 0.8?

@shikhirsingh Hey, I have not. I haven't had much time to work on the project recently. It might might be a few months before I get round to adding this. I would happily accept a PR if you want to work on it?

Any workaround? This is a significant deficiency for those creating single page apps.

@shikhirsingh CORS is enabled by default for APIs, are you saying you want to turn it off or that you want more control over the CORS options returned?

CORS is on by default - this can now be turned off using configuration.


issue #40; Solution : Updated Website Logo in Navigation Bar

The updated logo aims to enhance the overall visual appeal and brand identity of the website.
Key Changes:
Logo Redesign: A new logo design has been incorporated, incorporating ML picture of a human brain and tech combined and also the the website name :"ML Fusion LABs " integrated into the logo which makes it precise .
Layout Adjustments: The navigation bar layout has been adjusted to accommodate the new logo while maintaining a consistent user experience.
Expected Outcome:
The updated logo will contribute to a more visually appealing and professional website, enhancing the overall user experience.
Review:
Please review the changes and provide any necessary feedback. I am happy to address any concerns or make further modifications as needed.

PS: some adjustments may be needed for the contents of nav bar to aligned with the logo.
Please add the tags HacktoberFest and GSSOC
@vivekvardhan2810

Hi @Iampratyush004, I am closing your Pull Request,
Because you didn't mentioned in issue 40 that i am doing this work and i didn't assigned it yet.
Until i assign the issue, Pls don't Create PR

@Iampratyush004 please resolve the conflicts.

Ok sir


Export infrastructure/platform_detector.dart

Platform class from src/infrastructure/platform_detector.dart needs to be exported so that the test client code can set the platform in widget tests.
This came up when client code relies on PrimaryShortcutKey.isPrimaryShortcutKeyPressed extension method.

Notes: the exposure of Platform is needed for Superlist tests because the Superlist code relies on this existing extension:
extension PrimaryShortcutKey on RawKeyEvent {
  bool get isPrimaryShortcutKeyPressed =>
      (Platform.instance.isMac && isMetaPressed) || (!Platform.instance.isMac && isControlPressed);
}

At a minimum, we should probably rename Platform before making it public, so that it doesn't conflict with dart:io.
We should also see if Platform is still needed. Maybe defaultTargetPlatform is sufficient.
If we continue with this PR, we should move the export of Platform to super_editor_test.dart.

@angelosilvestre can you investigate our use of our definition of Platform and see if we still need it? I'm thinking that maybe defaultTargetPlatform is sufficient. Maybe we never really needed Platform, or maybe Flutter has changed since then. Can you let me know how it looks to you?

@matthew-carroll We only check our Platform instance on the keyboard actions code. defaultTargetPlatform should be sufficient.

@angelosilvestre can you try removing Platform, running the tests, and also try out any relevant behavior in the example app to make sure? If we really don't need it, then please put up a PR that removes it, and we'll take that one instead of this one.

@matthew-carroll Sure. Will do that.

Closing in favour of #834


Prometheus Pipeline worker stats missing

What happened?:
Using the prometheus endpoint on pipelines exposes pachd_pfs metrics (and go and grpc ones) but the expected pipeline worker ones aren't there (https://github.com/pachyderm/pachyderm/blob/master/src/server/worker/stats/stats.go)
What you expected to happen?:
the documented job metrics to be there (https://docs.pachyderm.com/2.0.x-rc/deploy-manage/deploy/prometheus/job_metrics/)
How to reproduce it (as minimally and precisely as possible)?:
curl the /metrics endpoint of any pipeline service
Anything else we need to know?:
broken in 1.13 and 2.0
Environment?:

Kubernetes version (use kubectl version):
Pachyderm CLI and pachd server version (use pachctl version):
Cloud provider (e.g. aws, azure, gke) or local deployment (e.g. minikube vs dockerized k8s):
If you deployed with helm, the values you used (helm get values pachyderm):
OS (e.g. from /etc/os-release):
Others:

AB#130

Does this bug apply to all pipelines or is it specific to pipelines with autoscaling / standby enabled. I remember there being an issue with that because the pipeline gets spun down and thus the endpoint goes away.

All pipelines

@Tryneus assigning to you since you made the last changes on the file listed in description

Looking at release notes for 1.13 this PR looks a little bit suspicious: https://github.com/pachyderm/pachyderm/pull/5912

Fixed by #6914.

Trying w RC2 and I see all the pachd/pfs stats, but still no worker stats?


[PL-50714] Publishes the total count for a user group

PL-50714
Changes will be reflected on this doc: https://developer.harness.io/docs/platform/delegates/manage-delegates/delegate-metrics/
Adding a new metric entry to the table:
| ldap_sync_group_flush_total | Publishes the total count for a user group when the LDAP group sync returned 0 users for that group. The metric publishes the accountIdentifier , GroupDN and the count. |
Description

Please describe your changes: __________________________________
Jira/GitHub Issue numbers (if any): ______________________________
Preview links/images (Internal contributors only): __________________

PR lifecycle
We aim to merge PRs within one week or less, but delays happen sometimes.
If your PR is open longer than two weeks without any human activity, please tag a code owner in a comment.
PRs must meet these requirements to be merged:

[ ] Successful preview build.
[ ] Code owner review.
[ ] No merge conflicts.
[ ] Release notes/new features docs: Feature/version released to at least one prod environment.

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://663b620004c4f63a2e6558e1--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://663b87acdab6215e0379be53--harness-developer.netlify.app


MinusFace代码运行报错

命令行：bash local_train.sh
Original Traceback (most recent call last):
File "/root/miniconda3/envs/MinusFace/lib/python3.8/site-packages/torch/utils/data/_utils/worker.py", line 308, in _worker_loop
data = fetcher.fetch(index)
File "/root/miniconda3/envs/MinusFace/lib/python3.8/site-packages/torch/utils/data/_utils/fetch.py", line 51, in fetch
data = [self.dataset[idx] for idx in possibly_batched_index]
File "/root/miniconda3/envs/MinusFace/lib/python3.8/site-packages/torch/utils/data/_utils/fetch.py", line 51, in
data = [self.dataset[idx] for idx in possibly_batched_index]
File "/root/autodl-tmp/TFace-master/recognition/tasks/minusface/../../torchkit/data/dataset.py", line 164, in getitem
image, label = self.sample_parser(*sample)
TypeError: call() takes 3 positional arguments but 4 were given
为什么会出错呢？请教各位大佬

我也有这个问题，请问解决了吗？


Generated Documentation

Since complete documentation will be important, what are thoughts on using something like JSDOC to generate docs for us?

Sounds very good to me. Let's automate as much of this lib as possible!

We've had this discussion today @ work and went with https://github.com/documentationjs/documentation, due to it's Flow & Babel support.

Addressed by https://github.com/styled-components/polished/pull/15

Addressed by https://github.com/styled-components/polished/pull/15


OauthInput throws NullReferenceException when Prompt is not defined

There is an inconsistency with BeginDialogAsync and ContinueDialogAsync. A default prompt is created during BeginDialogAsync flow, however ContinueDialogAsync will throw an exception
https://github.com/microsoft/botbuilder-dotnet/blob/f7bc2e82b2a0ad6a6a96e179d657e7cbcd9720d5/libraries/Microsoft.Bot.Builder.Dialogs.Adaptive/Input/OAuthInput.cs#L225
For now, we need to define both Text and Prompt fields

@tomlm, can we please get an update.

@Crazedpeanut can you update your PR as @Stevenic suggests?

Closing due to inactivity.


Ask a small question，about the tool you used to generate these small dots ⢿

am very curious, what tool did you use to generate these small dots ⢿
thanks

I’ve searched around for different terminal indicators and spinners and have copied (license permitting (if applicable)).


Pruning doesn´t work anymore after update to 1.2

Describe the bug
After the update via APT to the latest version 1.2 (IOTA mainnet) the pruning of the node doesn´t work anymore. I have tried it with "db size" and "milestone based" pruning. The node currently has about 68Gb (image 1) and the pruning setting is set to 60Gb. At the startup of the node the correct config.json file is loaded with the setting of db size pruning and 60Gb (image 2).
With the update to 1.2 I replaced the config.json and adapted the values back to the previous ones. The following values were changed:

dashboard.bindAddress
dashboard.auth.username
dashboard.auth.passwordHash
dashboard.auth.passwordSalt
pruning.size.targetsize
node.enablePlugins

(image 1)

(image 2)
To Reproduce

Set the targetSize in config.json to a value smaller than the current db size of the node

Expected behavior
The node should prune the data according to the settings in the config.json
Environment information:

Hetzner CPX21
OS: Ubuntu 18.04.6 LTS
RAM: 4 GB
Cores: 3 vCPU
Type: VPS
Browser: Chrome
HORNET version: 1.2

After deleting the db pruning works again.

Sorry Mike, we didn't have time to look into that issue.
But good that it works for you now.

No worries. I guess it was something on my side as nobody else had problems with pruning. So all good ;-)


make it work with django-suit out-of-the box

Hello,
thank you for the PR! Have you tested that it doesn't break anything for non-django-suit users?
Thanks!

yes, I have tested this patch with and without suit works flawlalesly

Great, thank you!


Config UI: Create Pipeline Blank Page (Reference Error)

Pipelines / Create New Pipeline
:warning: The Create Pipeline page is not accessible and a reference error is presented in the console. This appears to be related to a previous refactor on config-ui that was not fully completed & tested. https://github.com/merico-dev/lake/pull/1161
To Reproduce
Steps to reproduce the behavior:

Open Pipelines Menu (On Sidebar)
Click on 'Create New Pipeline'
The Page/Service is not available
See console errors

Screenshots

The Pipeline Activity page is also affected, repository name is missing from the run settings display.

Adding to v0.8.0 iteration as this will block other tasks.

If this bug is blocking other tasks, it should be addressed asap


Story Map Series (tabbed) cannot embed Operation Dashboard web app?

I already posted the issue under Operation Dashboard:
https://github.com/Esri/dashboard-samples/issues/3
So basically when I try to add the Operation Dashboard web app as a website to one of the tabs in my Map serier, it just would not load. (note*... my operation dashboard app loads fine if I add it to the Map Journal Template).
Is it a bug, or am I missing something.
Thank you,
Nataliya

Hey,
I made a test and it seems to work. This may be an issue because your story map is using a different protocol (http or https) than your dashboard.
We have a blog post explaining this in detail, see https://blogs.esri.com/esri/arcgis/2016/04/14/embedding-apps-and-websites-in-story-maps/.
You can start by trying to change the URL of the dashboard in the story map to use http if it was https or vice versa.

@glazou,
Thank you for the blog article. That was it. It was the issue with http vs. https. My OpsDashboard map was http, once I switched url to https it loaded in the Map Series Tab. Thanks, again. Nataliya.


Labels field missing from exported struct

https://github.com/opencontainers/image-spec/pull/371 added in the labels field to this doc, but didn't update the struct exported by this repo (here) to include the new field. It should be added.

like https://github.com/opencontainers/image-spec/pull/460 ?

Oh hey there's a PR for this! Sorry, missed it before opening this. I'll close this then.


zkBob Multi-sig

Full description: https://blockscout.notion.site/Smart-contract-wallet-and-bridge-deposits-aa102d2e4c9f47b89890e8832c019353
It was decided to proceed with the option with Ephemeral deposit credentials.

[x] Call with Max, Kirill, Alex and Evgeny to finalize the UX flow

[x] Create user flow - Tatyana

User should be able to create and manage multiple Ephemeral addresses similar to deposit address at CEXes

Ephemeral address will be used for deposits only, meaning that a multisig will send funds to this address and they will be deposited to zk Account.

[x] Contracts - Alex, Kirill

[ ] Library changes - Evgeny

[ ] UI - Max

[x] zk core - decided that zk multi-sig is worth researching Vladimir, Alexandr - separate task

14/10/22 - need to organize a call to discuss this feature's implementation

This is Epic, we need to decompose it to several tasks @popov-vladimir

Converted to the Library task.

@vadimnikonov1 Better to test this task on local machine

QA review - OK

Pending UI.


boot_command missing ?!

/kind bug
boot_command needed.
In my hyperv config I have a option to give Windows after it boot from the iso the right keystroikes to read the Autounattend.xml from another cd-image.
Is there also a way here or is it missing?
I only have found the shutdown_command .

Hello @DevTown
this is a duplicate of #121 #105 #49
this is a legitimate request
i let you read the entire thread here #49
As this is a limitation of AOS we cannot provide any solution yet. Please feel free to file a feature request at Nutanix Support and link to this issue.
Once you have created your own ticket to prioritize the feature please give the ticket number here

@DevTown
in your specific windows case normally you can solve it with a proper packer config
example
...
     "cd_files": [
        "autounattend.xml"
      ],
      "cd_label": "OEMDRV",
...

we use it to build windows image without any issue

THX with    boot_type         = "legacy" it works on my side. :-)

@tuxtof did you have experience with UEFI and the OEMDRV cd_lable ?

no i never test with Windows and UEFI @wolfganghuse any clue on your side ?

Default UEFI Windows Boot requires a keystroke to continue boot from ISO.... you need a "no-prompt" ISO... find more information here: https://github.com/nutanix-cloud-native/packer-plugin-nutanix/issues/33


Add privacy button behavior for shared datasets

Related to: #11342
Privacy button for shared datasets (span) is styled now as a button:

Cursor pointer
Disable user select

Also the following features have been added:

Inactive style for shared datasets
A tooltip with the content "You're not able to change the privacy of this dataset. Contact the owner {name}"

For the Acceptance:

Share a private dataset with  a colleague
Ask the colleague to attempt to change the privacy settings
Colleague will not be able to do this (expected behavior)

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Hey ho, hey ho!
@Jesus89 has signed a CLA with us (thanks, @Jesus89), so all good to go, CARTO team. 👍

Hey @agnesgyorfi, he is in the interview process :joy:, let's close it for the moment. Thanks both!

:shipit:


How to delete a statefulset object with cascade=false mode ?

Want to delete a object from k8s cluster in cascade=false (i.e do not delete dependent objects) mode.
What options do we need to use ? and reference docs for the same ?

@kaushiksrinivas did you try?
policy := metav1.DeletePropagationOrphan
cascdePolicy := metav1.DeleteOptions{
    PropagationPolicy: &policy,
}
clientset.AppsV1().StatefulSet(<namespce>).Delete(context.Background(), <name>, cacdePolicy)

Will try and update the same. Thanks


Update to OCaml 5

This PR updates the engine to OCaml 5

Do we really want to do this when all our other tools don't? I'm of course all for updating, but I want to avoid incompatibilities.

Mmh, I was not thinking about that indeed.
But the engine of hax is not used as an OCaml library from any other projects, and it doesn't consume any other projects as an OCaml library.
So, since the projects compose only at the binary level, I think there won't be any incompatibilities.
Does that make sense or I'm missing a source of incompatibility?

Yes, the Rust change is just about formatting. I think that's something rustfmt used not to format or something like that.


Revert "Converter for figure permissions."

This reverts commit 440100ae706812bfe8b8e425351d34c51309296f.

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@f9726ce). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #714   +/-   ##
=========================================
  Coverage          ?   66.56%
=========================================
  Files             ?      280
  Lines             ?     7198
  Branches          ?        0
=========================================
  Hits              ?     4791
  Misses            ?     2407
  Partials          ?        0

Impacted Files
Coverage Δ

src/article/converter/r2t/FigConverter.js
92.5% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9726ce...1d0058e. Read the comment docs.


ES6 jsconfig.json error

I am incorrectly getting the following error, "This can only be used with ES6. Make sure to have a jsconfig.json-file which sets the target to ES6".
Furthermore, I think I may have stumbled upon a weird case where if the start of the file name is "temp" as in "temp.js", "temporary.js", or "temp123.js" it will cause this error.
To reproduce:
Create a file called temp.js with some ES6 code, such as:
let x = 10

The above error is now showing. To fix it, create the jsconfig.json file which sets the target to ES6:
{
	"compilerOptions": {
		"target": "ES6"
	}
}

The error is still showing, now incorrectly.
If I rename "temp.js" to "test.js" (or anything that doesn't start with 'temp') the error goes away. Or, if I create a files array in jsconfig.json which lists "temp.js", the error goes away:
{
	"compilerOptions": {
		"target": "ES6"
	},
	"files": [
		"temp.js"
	]
}

I don't want to have to do this for every file in my project.
I'm running on Windows 7, 64-bit.
Thanks

I'm seeing a similar thing when editing Vue files (http://vuejs.org/guide/application.html#Single_File_Components). These are HTML-like and will have a script tag that contains JS.

I have the following jsconfig.json file:
{ 	"compilerOptions": { 		"target": "ES6", 		"module": "system" 	}, 	"files": [ 		"Editor.vue" 	] }
(with Editor.vue being my file). I'm manually setting the filetype to HTML as well.

+1
@ron-wade noticed that as well. Ended up using jshint instead.

+1

@garethfentimen might be a different problem you were having, as I am the issue with the latest release: 0.10.1.

I am having related issues to this, and wasn't really sure how to fix it. It seems to happen a lot for new files, but if I save the file, close VS Code and reopen it, the errors go away. Editing jsconfig.json and saving it seems to correct the issue as well, doesn't seem to matter what changes I made the jsconfig, just that it did change.

@gigafied what naming convention were you using for your files when you had the errors. I also found that restarting in conjunction with dropping my myfile.controller.js convention for a more straight forward myfileController.s seemed to clear the es6 messages. So like you say it is possible that it is just a new file thing.

I get it even if I rename an existing file, from Something.js to SomethingElse.js, but indeed, if i just edit jsconfig.json and add a insignificant space somewhere, then hit save, everything starts working again.

+1
It's wired for me, in some files in my project it's work in others not. I'm using a the jsconfig.jscon without a file configuration. Sometimes it works for a few hours and then the "This can only be used with ES6. Make sure to have a jsconfig.json-file which sets the target to ES6" error comes back.

+1 Having the same issue

+1

Making this a duplicate of #703. There are a few things off when it comes to jsconfig.json and I trying to tackle them for Dec15


WebInspect / Mirco Focus WebInspect v<IP_ADDRESS> issues XML import to DD

Sample file:
https://drive.google.com/file/d/1OlLnu5GcgYh9R1Ez6PUOqHysaetJmG9E/view?usp=sharing

@johnfelipe Can you provide a bit more detail here?
I'm guessing there's an issue with the existing parser but having the error from the logs or something more then a link to a Google drive will greatly increase your chances on someone picking this up and fixing the issue.

worked on my computer:

Which version?
El vie, 1 nov 2024, 3:28 a. m., manuelsommer @.***>
escribió:

worked on my computer:
grafik.png (view on web)
https://github.com/user-attachments/assets/4aa1eb00-44d1-4340-b3f4-06ee8bb3cb62
—
Reply to this email directly, view it on GitHub
https://github.com/DefectDojo/django-DefectDojo/issues/11163#issuecomment-2451503367,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AADIWFEKJO45RQ53I5WQPETZ6M3TFAVCNFSM6AAAAABQ4UWVG6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINJRGUYDGMZWG4
.
You are receiving this because you were mentioned.Message ID:
@.***>

v. 2.39.4 ( release mode )

Can we close this @johnfelipe?

Yes pls, update code and works, tnks

Can you close it @johnfelipe ?


High water mark incorrectly moved during undo

Hi! Recently I've been noticing issues with the high water mark moving after an undo.
Steps to reproduce:

In a new file, type Definition X := 2. and step through the command.
Change X into Y: the high water mark returns to the beginning of the file.
Undo: the high water mark is now incorrectly back after Definition X := 2.

I suspect Sublime is undoing the region change automatically. Notice how changing X back to Y after the Steps to reproduce does not remove this incorrect highlighting, because the plugin's internal high water mark variable is correctly at the beginning of the file so the text change listener does nothing.
The following is a fairly easy, but unsatisfying fix, since you can see the high water mark jump down after then undo then up after this bit of code runs.
diff --git a/CoqPlugin.py b/CoqPlugin.py
index edfd64b..ebdcfed 100644
--- a/CoqPlugin.py
+++ b/CoqPlugin.py
@@ -843,6 +843,9 @@ def handle_view_modification(view, modification_start_index):
             text = view.substr(sublime.Region(0, worker_watermark + 1))
             worker.mark_dirty(text=text)
             worker.display.set_bad_ranges([])
+        else:
+            worker.display.set_marks(worker_watermark, worker_watermark)
+            worker.display.set_bad_ranges([])

 def check_for_terminated_views():
     for worker_key, worker in list(coq_threads.items()):

Aaaand of course I run into the solution on the forums just after I post this issue. There is a NO_UNDO flags for regions which can be set to avoid precisely that. I'm surprised it didn't come up earlier though, this appears to be an old option thus an old behavior...

As far as I know, this issue has existed in the plugin since day 1. I've always kinda worked around it. (It happens to me a lot.)
Amazing that the fix is so easy. Let me know if you're working on this one; otherwise, I'll add NO_UNDO myself later this evening.

Excellent! Happy to help as always.


Road to 1.0

Hi all,
Mobservable is quite stable for a while and feels (imho) quite complete. So it's time to work to a 1.0 release. Here are some ideas for 1.0
Improvements

[x] disable consistency checks in production mode for improved performance
[x] simplify error handling for fail fast behavior
[x] include typescript 1.6 typings
[x] docs docs docs
[ ] improved mobservable-react-devtools (see the readme for the ideas) (post 1.0)
[ ] support nested transactions (post 1.0)
[ ] add some utilities to create observables based on time, which is nice for animations and such? (post 1.0)
[ ] extend observable objects with utility methods to remove, add and iterate reactive properties? (post 1.0)

Breaking changes

[x] rename makeReactive to observable, to nicely mirror the earlier released rename from sideEffect to `observe.
[x] rename @observable (the property annotation) to obervableProperty or observableSubject -> will remain @observable, the signatures could be overloaded
[x] rename @reactiveComponent to @observer
[x] throw away all already deprecated api's.
[x] the observable function (formerly makeReactive) will no longer be the root export of the module export itself. It will be the default export though.
[x] extendReactive -> extendObservable
[x] isReactive -> isObservable
[x] observe* -> autorun*

Wild ideas
Actually I don't like the name of the module. Initially it wasn't planned to open source it, so it got a boring name. So if people are not too much hindered by it, it might be cool to give it a better name. So cool name suggestions are welcome! (or if you don't like a new name feel free to mention it as well)
Some of my personal ideas:

fume
(...might add more later)

+1 for observableSubject
And as a rename for the package MOS or mos. The short form of mobservable. You don't even have to change the logo... haha

I suggest that if the above list contains features, that you keep that post 1.0 release. Clean up your API a bit with some name / aliasing to make 1.0 docs use the new syntax while allowing folks an on-ramp to your 1.0 APIs. Then after 1.0, you have the opportunity to add new features. I use this lib, and would really prefer that you keep the core of the lib very small as it stands now, and add on to it as small modules.
Name suggestion, based your "fume" name:
flume - a deep narrow channel or ravine with a stream running through it.

@kenotron: Yes most of the improvements are ideas at this stage which will be released (if ever) post 1.0. The renames will be part of 0.1, as these will be breaking changes, and maybe the simplified error handling. Currently mobservable is quite resilient to exceptions in views, but I think a fail fast approach might be easier to debug and urges users more to make their own code resilient.
Thanks for the name suggestion!

Still not convinced that mobservable.observe is the proper name, Meteorjs calls it autorun, probably that name makes it better clear what it does?

1.0 has been released! Check the release notes :)


Use uint256 when calculating desired BTC for DEx 1

The legacy calculation of the desired BTC amount for DEx 1 was not suitable for larger numbers, resulting in bad data on the RPC layer.
The legacy calculation is part of the consensus code, and was used when calculating the updated desired amount, in case a seller offered more than available. This is no longer possible since 0.0.10, but the code is still needed for historical transactions.
The updated version uses plain integer math. The function is used on the RPC layer for omni_gettransaction and omni_getactivedexsells.
Note that there is some explicit rounding involved now, and the desired amount is rounded up, to ensure a payment really covers the whole amount.
The submission is tagged with "consensus", because it touches consensus code, but the change is not consensus affecting.

Reviewed & tested, looks good to me - OK to merge.
Preparing a test environment...
   * Starting a fresh regtest daemon
   * Preparing some mature testnet BTC
   * Obtaining a master address to work with
   * Funding the address with some testnet BTC for fees
   * Participating in the Exodus crowdsale to obtain some OMNI
   * Generating addresses to use
   * Listing a sell for 4000 OMNI for 18.5 BTC
     # Checking the bitcoin desired is 18.5... PASS
   * Cancelling the existing sell...
   * Listing a sell - all the OMNI (550K) for all the BTC (21M)
     # Checking the bitcoin desired is 21M... PASS

####################
#  Summary:        #
#    Passed = 2    #
#    Failed = 0    #
####################


Stick to one Package Manager

Describe the bug
The app folder contains both a package-lock.json and yarn.lock. It is not recommended to mix package managers and only 1 should be used.

What is the issue?
It is advised not to mix package managers as their index files are used to track installed packages.
How to fix the bug?

Delete package-lock.json && yarn.lock from /app
Add package-lock.json && yarn.lock to .gitignore

@devbihari . Would like to work on this issue.  Need a guidance here. We need to remove either one lock file from package-lock.json or yarn.lock or else  both files removed as per your suggestion in previous comment


Add Sendan Life (Katagiri Bootleg) by Shoue, Katagiri

Song Name
Sendan Life (Katagiri Bootleg)
Artist Name
Shoue, Katagiri
Source
Youtube
Youtube Link
https://www.youtube.com/watch?v=ZgjrL8XDNEQ
Direct File Link
No response
Song ID
1
Start Offset [ms]
0
Extra
Created from Auto Nong.
Created for level: 106590574

accept

accept
i guess? also @Arturviper0  bro you are not a mod, anyways thanks for adding a song


.catch() doesn't seem to catch .invoke() error when the ps process is destroyed

_safelyRunCommand: function(command, callback = undefined, error = undefined){

        this._ps.addCommand(command);

        this._ps.invoke()
            .catch((e) => {
                console.log("ps destroyed!!");
                this._ps.dispose();
                this._ps = new Shell({
                    executionPolicy: 'Bypass',
                    noProfile: true
                });

                this._safelyRunCommand(command, callback, error);
            });
    },

I manually destroy the powershell process created by new Shell(...) just to try and test some edge cases, and the .catch() block after .invoke() doesn't catch the issue and:

(node:6600) UnhandledPromiseRejectionWarning: Error [ERR_STREAM_DESTROYED]: Cannot call write after a stream was destroyed
at doWrite (_stream_writable.js:411:19)
at writeOrBuffer (_stream_writable.js:399:5)
at Socket.Writable.write (_stream_writable.js:299:11)
at resolve (C:\PATH\node_modules\node-powershell\lib\utils.js:44:14)
at new Promise ()
at shellSafeWrite (C:\PATH\node_modules\node-powershell\lib\utils.js:43:41)
at Shell.invoke (C:\PATH\node_modules\node-powershell\lib\Shell.js:188:5)
at Object._safelyRunCommand (C:\PATH\DockerManager.js:14:18)
at Object.startDocker (C:\PATH\DockerManager.js:32:14)
at Timeout.setTimeout [as _onTimeout] (C:\PATH\main.js:5:31)
(node:6600) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 2)
(node:6600) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

Is returned.
Please let me know if I am missing smth here or is it is a bug in the node-powershell...

Getting the same error on one of my machines but not on the other


Can't set locale

there is no way to set a locale to change a language.
when setting the api.js file from google, need to be set as example:
https://www.google.com/recaptcha/api.js?hl=fr instead https://www.google.com/recaptcha/api.js only.


[Enhancement] Add message gray strategy solution, compatible with POP consumption mode and Push consumption mode

Before Creating the Enhancement Request

[X] I have confirmed that this should be classified as an enhancement rather than a bug/feature.

Summary
The solution provides an extensible message grayscale solution for implementing message grayscale publishing that supports RocketMQ 4.x and RocketMQ 5.x . It is compatible with POP consumption mode and Push consumption mode. No matter the client-rebalance or server-rebalance, the solution can realize the message gray level in a lightweight way.
Motivation
At present, many business systems control the impact of version release through the gray scale release process, and almost all service releases will strictly go gray scale release first, and then go online after verification. gRPC and HTTP calls during GRay-scale publishing can be precisely controlled through microservice governance and gateway request headers.
However, if the message gray scale scheme is not implemented, even if the current link is a gray scale link, the message transmission is still uncontrollable, may go to the gray cluster monitoring partition, may also enter the online cluster monitoring partition. Therefore, when it comes to consuming logic changes, developers need to incorporate a lot of compatibility logic into their code. Even so, these logics only ensure that new traffic does not affect the line, but they do not guarantee that gray-scale traffic precisely enters the gray-scale consumer client, so that strict gray-scale verification cannot be performed.
the industry lacks a perfect message gray scale solution, the existing MQ gray scale solution can not completely solve the problem of message isolation and switching interface. Therefore, it is particularly important to design a lightweight message gray scale scheme that is easy to access and controllable to upgrade.

Describe the Solution You'd Like

Add client configuration: Add enableGraySwitch and grayTag. enableGraySwitch Indicates whether the grayscale message is enabled. grayTag indicates whether the client is a grayscale client. grayTag takes effect only when enableGraySwitch is enabled. The solution adds two configuration items that make it easy for the RocketMQ consumer to determine whether a client is a grayscale client.
Use the clientId generation mechanism: If the client is a grayscale client (enableGraySwitch and grayTag are both true), its clientId will contain the @gray identifier.
Producer message sending strategy: The producer client decides to send the message to grayscale partition or non-grayscale partition according to whether there is a grayscale identifier. For this purpose, the SelectMessageQueueByGray policy is implemented specifically to ensure that producers send messages accurately to the specified MessageQueue when they are sent.
The new weight balance strategy: to design a new weight balance strategy, expand the AllocateMessageQueueAveragely, compatible RocketMQ 4 x and 5. X version different versions, and different consumption patterns (such as POP/Push). The core idea is that during rebalancing, grayscale clients are distinguished from non-grayscale clients by whether or not there is a @gray identifier in the clientId string, ensuring that grayscale clients consume from grayscale queues and non-grayscale clients consume from non-grayscale queues.
Compatible with POP consumption mode: The program also takes into account POP consumption mode. However, the scheme will be divided into gray scale queue and non-gray scale queue according to gray scale identification. The feature of POP consumption mode is still retained, that is, multiple POP Normal consumers can consume the same Normal Queue. Similarly, multiple POP Gray consumers can consume the same Gray Queue. Ensure that every consumer client can consume messages.
Switch connection processing: When all gray consumer clients do not exist (for example, the gray verification on the consumer side is published online, or the gray consumer side is abnormally offline), the message will be taken over by other normal consumer clients immediately to ensure that the message will not be lost.

detail link: 语雀
Describe Alternatives You've Considered
/
Additional Context
This solution is lightweight, easy to access and upgrade controllable message grayscale scheme. Compatible with RocketMQ4.x and RocketMQ5.x versions.

the related documentation:语雀

We know that in practical applications, full-link gray scale publishing scenario is very common, and message queue as one of the links should also have this capability, this scheme makes RocketMQ4.x and RocketMQ5.x native support message gray scale publishing function. Compared with existing solutions in the industry, this solution does not require additional shadow Topic/Group. There is also no need to transform grayscale tag/UserProperty, etc. (ps: When the scale of the business is relatively large, the grayscale function is implemented by adding a topic or group. On the one hand, there is a critical problem, that is, when the grayscale verification is switched to prod, messages may be missed for consumption, which is unacceptable. On the other hand, there is the cost issue. Imagine the cost of doubling each topic and group, which cannot be ignored.) The solution uses gray partition to solve the problem of message isolation and switching connection at low cost, and has low intrusion to RocketMQ. Just add a few client configurations and access grayscale policies to allow businesses to seamlessly access RocketMQ grayscale publishing capabilities. The scheme has been widely applied and verified in our projects, which confirms its reliability, security, and stability.

The solution has been widely applied and verified in our projects, which confirms its reliability, security, and stability.

How to avoid non-grayscale consumer consumption when message retry occurs

How to avoid non-grayscale consumer consumption when message retry occurs

If it is a retry topic, the equal-allocation policy is used (the retry topic goes to the internal callback broker, which queue is written to is random)

所以在这个场景下会有可能消息互串，比如prod实例消费0,1,2,3队列，gray实例消费4,5,6,7队列，如果gray实例消费触发消息重试，消息会默认回到0队列，这样会导致prod实例消费到灰度消息。


HTML in DialogService.ShowMessageBox message

Feature request type
Enhance component
Component name
DialogService.ShowMessageBox
Is your feature request related to a problem?
Such a handy API ShowMessageBox :)
Describe the solution you'd like
Support HTML message in DialogService.ShowMessageBox same as SnackBar
Have you seen this feature anywhere else?
ISnackbar
Describe alternatives you've considered
No response
Pull Request

[ ] I would like to do a Pull Request

Code of Conduct

[X] I agree to follow this project's Code of Conduct

I agree that the ShowMessageBox API could use some love. I just tried using <br> and \n and can't even get a new line to show up. Going to take a peek at the code now and see if I might be able to offer up a pull request.


Revert create-pod Role name

@elenaviter I've had to revert the renaming of the ClusterRole because it breaks upgrades.
We can look at this again after the release this week
Description

We can not change the name of an already created ClusterRole as it breaks upgrades.
Related Issue(s)

Checklist

[x] I have read the contribution guidelines
[ ] Suitable unit/system level tests have been added and they pass
[ ] Documentation has been updated

[ ] Upgrade instructions
[ ] Configuration details
[ ] Concepts

[ ] Changes flowforge.yml?

[ ] Issue/PR raised on flowforge/helm to update ConfigMap Template
[ ] Issue/PR raised on flowforge/CloudProject to update values for Staging/Production

Labels

[ ] Backport needed? -> add the backport label
[ ] Includes a DB migration? -> add the area:migration label

Hi @hardillb,
Thank you for bringing this to my attention. I understand you're busy with the release.
When time allows, I'd be grateful for any follow-up you can provide regarding this aspect.
Thank you once again for your time and support!

@elenaviter can you raise an issue with detail of what exactly you were trying to achieve with this change then we have somewhere to discuss options going forward.
Thanks.


Why to.be.true shows warning

Hey @hi2rashid I assume what you're looking for is something along the lines of:
expect(res.getBody()).to.equal(true);

Although I don't think you'll get the result you want with this code as getBody() only returns the data of the request. What should work instead is:
expect(res.getStatus()).to.equal(200)

I don't think there is anything with your test code. The code linter of Codemirror just doesn't understand it.
There is currently an ongoing issue to upgrade Codemirror to Version 6 this may improve things #1212

same issue with empty

I made this test generator for bruno, try
https://testsgenerator.net/

@hi2rashid or you can try my branch that contain already the functionality within Bruno : https://github.com/survivant/bruno/tree/BrunoSD

Hi @survivant Can you raise a PR for this fix?

@helloanoop sorry, I don't have the fix for this issue, I was referring to the test generator


Define behaviour for CRD and ConfigMap containing the same profile

The operator is gaining full support to represent seccomp profiles in CRD.
Used in conjunction, and having the same profile name used in both CRD and ConfigMap forms, may lead to a non-deterministic results. Whatever resource is created last would overwrite the other former. Here's a few ideas on how we could tackle it:

Only allow a single method to represent profiles per cluster. When CRD is enabled, ConfigMap is disabled and vice-versa.

Create slightly different path for each (i.e. cm/myprofile.json and crd/myprofile.json).

@cmurphy @saschagrunert @hasheddan any suggestions on other options or favourite options? I personally would be leaning towards the first one.

Would be fine having it configurable, while having the CRD be the new default :)

It might be easier to just use different paths. The path for a profile created as a ConfigMap versus a CRD are already naturally different, since both the name of the ConfigMap and an explicit name for the file are used to construct the path, e.g. /var/lib/seccomp-operator/<namespace>/<configmap name>/<file name>, but there is no equivalent explicit file name for the CRD (unless we want to add it), so it would be more straightforward to write them to something like /var/lib/seccomp-operator/<namespace>/custom-profiles/<resource name>.json. Then there would only be a collision if a ConfigMap happened to use "custom-profiles" as its name. But I can see arguments for option 1 as well.

@cmurphy My main concern would be the edge case you already called out, which makes me feel like option 2 may become a footgun as it gives users some room for misinterpretation.

After some talk on this subject we come to the conclusion that we were better-off removing ConfigMap support.
This change will make it easier for users to use the operator and remove unnecessary ambiguity.
Closing this issue given that its goal was to define the behaviour, which no longer is needed.
/close


add plugin replace-responsebody

Ⅰ. Describe what this PR did
Implement a plugin that can replace the response body according to the configuration
Ⅱ. Does this pull request fix one issue?

fixes #62
Ⅲ. Why don't you add test cases (unit test/integration test)?
No unit tests yet
Ⅳ. Describe how to verify it
If you deployed higress as a K8S cluster, you can use this yaml to test replace-responsebody.yaml
Ⅴ. Special notes for reviews
Check out README.md

Codecov Report

Merging #95 (94e7310) into main (cf50b6e) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

@@           Coverage Diff           @@
##             main      #95   +/-   ##
=======================================
  Coverage   24.80%   24.80%
=======================================
  Files          24       24
  Lines        4076     4076
=======================================
  Hits         1011     1011
  Misses       3008     3008
  Partials       57       57


FR: Add path() method to DirEntry

I noticed that openssh_sftp_client::fs::DirEntry is missing a path() method which is provided in the std-equivalent.
Is there a technical reason this isn't implemented?

It can be implemented, I was focusing on providing a minimal usable API based on what is provided by sftp protocol.
I will welcome any PR for this, you would need to record the path passed to Fs::open_dir and then it can be implemented with relative ease.


Add zooming feature to small loot tables

Currently, "zooming in" actually displays loot tables at their real size. Therefore, it is pretty useless for loot tables that are too small (https://matrix4348.github.io/loot-tables/Barren_Foliage_1.png).
Moreover, reworking minimum and maximum height and width (on both zoom-in and zoom-out) might be a good idea. By adding some "acceptable margin", for example?

Implemented in version 4.7.


CreateOrgWebHookCommand reports success but message suggests failure

{
  ...
  "status": "success",
  "message": "Failed to install webhook: Failed to create org-level webhook for `atomisthqa`"
}

Resolved by #11


yum install script fails due to missing packages

While installing master works, other packages fail with errors like:
# bash install.sh -r metanode
http://ocs-cn-north1.heytapcs.com/cubefs/cfs-metanode-latest-el7.x86_64.rpm
--2022-04-26 17:09:12--  http://ocs-cn-north1.heytapcs.com/cubefs/cfs-metanode-latest-el7.x86_64.rpm
Resolving ocs-cn-north1.heytapcs.com (ocs-cn-north1.heytapcs.com)... <IP_ADDRESS>
Connecting to ocs-cn-north1.heytapcs.com (ocs-cn-north1.heytapcs.com)|<IP_ADDRESS>|:80... connected.
HTTP request sent, awaiting response... 404 Not Found
2022-04-26 17:09:14 ERROR 404: Not Found.

http://ocs-cn-north1.heytapcs.com/cubefs/cfs-metanode-latest-el7.x86_64.rpm  : Url not found.

@bndbsh thanks for notification，the error due to wrong rpm name and already be fixed，please try agagin

#1500


chore: coverage remove restart vitest

fix: #998
from https://nodejs.org/api/v8.html#v8takecoverage

This method can be invoked multiple times during the lifetime of the process. Each time the execution counter will be reset and a new coverage report will be written to the directory specified by NODE_V8_COVERAGE.

This looks like NODE_V8_COVERAGE is reread every time v8.takeCoverage is executed.
NODE_V8_COVERAGE read once when nodejs start.

"It looks like the output is no different after removing that"

because thread enable test coverage run in sub-thread.
this PR restart Vitest when threads disabled.

The v8.takeCoverage() method allows the user to write the coverage started by NODE_V8_COVERAGE to disk on demand.

NODE_V8_COVERAGE starts coverage itself. Without it coverage is not enabled so v8.takeCoverage should not work.
Can you add tests for this?

And check if this works with threads disabled.
It would be nice if we can skip restarting Vitest.

so how about restart Vitest when threads disabled.

"It looks like the output is no different after removing that"

because thread enable test coverage run in sub-thread. 😂


[SPARK-16896][SQL] Handle duplicated field names in header consistently with null or empty strings in CSV

What changes were proposed in this pull request?
Currently, CSV datasource allows to load duplicated empty string fields or fields having nullValue in the header. It'd be great if this can deal with normal fields as well.
This PR proposes handling the duplicates consistently with the existing behaviour with considering case-sensitivity (spark.sql.caseSensitive) as below:
data below:
fieldA,fieldB,,FIELDA,fielda,,
1,2,3,4,5,6,7

is parsed as below:
spark.read.format("csv").option("header", "true").load("test.csv").show()

when spark.sql.caseSensitive is false (by default).
+-------+------+---+-------+-------+---+---+
|fieldA0|fieldB|_c2|FIELDA3|fieldA4|_c5|_c6|
+-------+------+---+-------+-------+---+---+
|      1|     2|  3|      4|      5|  6|  7|
+-------+------+---+-------+-------+---+---+

when spark.sql.caseSensitive is true.
+-------+------+---+-------+-------+---+---+
|fieldA0|fieldB|_c2| FIELDA|fieldA4|_c5|_c6|
+-------+------+---+-------+-------+---+---+
|      1|     2|  3|      4|      5|  6|  7|
+-------+------+---+-------+-------+---+---+

In more details,
There is a good reference about this problem, read.csv() in R. So, I initially wanted to propose the similar behaviour.
In case of R,  the CSV data below:
fieldA,fieldB,,fieldA,fieldA,,
1,2,3,4,5,6,7

is parsed as below:
test <- read.csv(file="test.csv",header=TRUE,sep=",")
> test
  fieldA fieldB X fieldA.1 fieldA.2 X.1 X.2
1      1      2 3        4        5   6   7

However, Spark CSV datasource already is handling duplicated empty strings and nullValue as field names. So the data below:
,,,fieldA,,fieldB,
1,2,3,4,5,6,7

is parsed as below:
spark.read.format("csv").option("header", "true").load("test.csv").show()

+---+---+---+------+---+------+---+
|_c0|_c1|_c2|fieldA|_c4|fieldB|_c6|
+---+---+---+------+---+------+---+
|  1|  2|  3|     4|  5|     6|  7|
+---+---+---+------+---+------+---+

R starts the number for each duplicate but Spark adds the number for its position for all fields for nullValue and empty strings.
In terms of case-sensitivity, it seems R is case-sensitive as below: (it seems it is not configurable).
a,a,a,A,A
1,2,3,4,5

is parsed as below:
test <- read.csv(file="test.csv",header=TRUE,sep=",")
> test
  a a.1 a.2 A A.1
1 1   2   3 4   5

How was this patch tested?
Unit test in CSVSuite.

Test build #64178 has started for PR 14745 at commit a3c3dc6.

Test build #64178 has finished for PR 14745 at commit a3c3dc6.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64178/
Test PASSed.

Merged build finished. Test PASSed.

Test build #64201 has started for PR 14745 at commit 94620ca.

looks good to me.
do we need to consider case? is "a1" the same as "A1"?

Hm, yea, I think we should take that into account as spark.sql.caseSensitive is false by default. I will take a look at R as well and will fix this up tomorrow. Thank you for reviewing @felixcheung .

Test build #64201 has finished for PR 14745 at commit 94620ca.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64201/
Test PASSed.

Merged build finished. Test PASSed.

Test build #64250 has started for PR 14745 at commit 316049b.

@falaki and @felixcheung Do you mind if I ask another quick look please?

Test build #64250 has finished for PR 14745 at commit 316049b.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64250/
Test PASSed.

Cc @rxin as well.

Test build #64630 has started for PR 14745 at commit 0c02581.

Test build #64630 has finished for PR 14745 at commit 0c02581.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64630/
Test PASSed.

cc @cloud-fan Do you mind if I ask to take a look please?

Test build #66605 has started for PR 14745 at commit fd24c5b.

Test build #66605 has finished for PR 14745 at commit fd24c5b.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66605/
Test FAILed.

retest this please

Test build #66608 has started for PR 14745 at commit fd24c5b.

Test build #66608 has finished for PR 14745 at commit fd24c5b.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66608/
Test PASSed.

LGTM

Test build #66652 has started for PR 14745 at commit 969c8f9.

Test build #66652 has finished for PR 14745 at commit 969c8f9.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66652/
Test PASSed.

thanks, merging to master!

As R has a separator for column headers like
a a.1 a.2 A A.1
can we have one as well like underscore?

I think you can simply just rename the columns after loading manually.


docs: update standalone keycloak theme section in README.md

The section Standalone keycloak theme in the README.md has two minor bugs in the import statements.

Those kind of contribution are very valuable!
Thank you for taking the time to submit a PR, it saves me and the comunity time.

@mhenke96
https://github.com/garronej/keycloakify-advanced-starter/invitations
https://github.com/garronej/keycloakify-starter/invitations
https://github.com/InseeFrLab/keycloakify/invitations


starter project for Haystack

How - how do we go about adding a spring cloud starter project for Haystack?   We will be happy to contribute and maintain that project. Alternately, we can host it in Expediadotcom org and issue an update to your documentation. Let me know

This is just instrumentation. You can use it with any OpenTracing compatible tracer and create integrations like these:
https://github.com/opentracing-contrib/java-spring-zipkin
https://github.com/opentracing-contrib/java-spring-jaeger
Or is there something else required to make it work with Haystack?

@pavolloffay Haystack is an opentracing compatible tracer.  I am adding a springboot integration similar to what you have for zipkin and jaeger in opentracing-contrib.  Should I just issue pull for your documentation adding Haystack's integration as well or do you prefer I move my integration library to opentracing-contrib?  similar to zipkin and jaeger, all the library does is create a Tracer instance so it can work with opentracing-spring-web-starter

@mchandramouli as you prefer we can move the repo to opentracing-contrib or just add docs with the repo location to this repository.

Great. Here is our README link https://github.com/ExpediaDotCom/haystack-client-java/tree/master/integrations/opentracing-spring-haystack-web-starter

Thanks for the pointer, you are welcome to create a PR and add it to https://github.com/opentracing-contrib/java-spring-cloud#configuration.


Cannot save a card outside of checkout flow with handleCardSetup

Hey Stripe,
I have been following this guide (please click on 'Saving Cards Outside Checkout Flow tab): https://stripe.com/docs/payments/payment-intents/migration#saving-cards
The goal was to save a card outside of a checkout flow, and I followed:

Fetch a client_secret from my app's backend
Pass the client_secret to handleCardSetup along with elements

Here is a simplified example of my frontend code for fetching:
 const responseWithSecret = await axios().get('/get_my_client_secret')

    try {
      const responseAfterHandleCardSetup = await props.stripe.handleCardSetup(
        responseWithSecret.data.data.client_secret,
        this.element
      )

    } catch (error) {
      console.log('error:', error)
    }

this.element:

But I get the following error:

What might be the issue here?
Thanks

Hi GavBaros,
I don't have an answer but I've run into a similar issue, as have a few others. I've been speaking to support about this. Supposedly there is a need to isolate the handleCardSetup() call from the CardElement.
https://github.com/stripe/react-stripe-elements/blob/8b5d1ffb2eaf5235193597b7d4f57349163a12ef/src/components/inject.js#L316
https://github.com/stripe/react-stripe-elements/blob/8b5d1ffb2eaf5235193597b7d4f57349163a12ef/src/components/inject.js#L317
https://github.com/stripe/react-stripe-elements/blob/8b5d1ffb2eaf5235193597b7d4f57349163a12ef/src/components/inject.js#L318
I've tried isolating them this morning (wrapping a checkout form in one Element, and calling handleCardSetup() from another Element. However I've found that handleCardSetup() then complains that it can't find a card element when it's isolated in a different element. I'll edit with  a Gist shortly.

Hey Callum, forgot to mention that handleCardSetup is now working for me, the above error is now replaced with the expected success response. I would guess Stripe did some BE update to this by coincidence.
Regarding your issue, perhaps setup two separate handleCardSetup ?

I've spent a bit more time reading about the isolation methods others have discussed in the issues here. Solution was to keep the isolation between the element containing the card and the element calling handleCardSetup(). The final issue was that handleCardSetup(clientSecret,{}) requires a second parameter, an empty object. Without the empty object, it searces and fails to find the now isolated card element.
Am going to raise an issue about the documentation for creating subscriptions with free trials using react-stripe-elements. Implementing the flow using the regular stripe.js library took about 30 minutes, spent over a day trying to get elements to work with the flow documented in the Stripe docs.

would passing elements (in my case this.element) also help?
I got my solution here from the answer from dweedon-stripe: https://github.com/stripe/react-stripe-elements/issues/368

UPDATE:
It seems I can only use the handleCardSetup process once successfully. When I try to add another card again, it gives me the above error once again.

LATEST UPDATE:
I can no longer add even one card. handleCardSetup does not even work anymore for the exact same logic as above. I get:

Hey @GavBaros can you try this again? We released an update to the API that allows you to use a PaymentMethod not associated with a Customer on setup. (Not that it wont automatically associated it with the customer. You will have to do that via a call on your backend when this handleCardSetup resolves

@mikeshaw-stripe , everything works great now; can add 1 or more cards with SCA challenge toggled or just plain test cards. Thanks!

@mikeheaton-stripe can you say where to access the update? I see the last official release 4.0.0 was 28 days ago.
Thank you!


Make yaml.Unmarshal strict

Using yaml.UnmarshalStrict() will prevent us from making typos in our yamls without being noticed.

Codecov Report

Merging #271 (90e775f) into main (db266db) will decrease coverage by 0.04%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##             main     #271      +/-   ##
==========================================
- Coverage   60.81%   60.77%   -0.05%
==========================================
  Files          73       73
  Lines        4247     4247
==========================================
- Hits         2583     2581       -2
- Misses       1497     1500       +3
+ Partials      167      166       -1

Flag
Coverage Δ

unittests
60.77% <66.66%> (-0.05%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/confgen/confgen.go
43.47% <50.00%> (ø)

pkg/confgen/config.go
33.33% <100.00%> (ø)

pkg/pipeline/ingest/ingest_collector.go
48.12% <0.00%> (-1.51%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db266db...90e775f. Read the comment docs.

Note: This PR deals only with confgen. That is, flowlogs-pipeline would start normally even if its config has unknown fields. I created an issue for it and will solve it in a later PR. #274


chore: add type tests

Purpose (TL;DR) - mandatory
https://github.com/sinonjs/fake-timers/issues/356#issuecomment-768227159
I just added a dummy test, no attempt at coverage. But it's a good opportunity for new contributors if they want, and future changes to the types should include tests

This looks like a good start to me. @SimenB can you think of any reason not to merge this?

Only reason would be if we wanted more tests before landing, but I think it's valuable as is 👍


v2.5.0 release

Related Issue(s):

Description:
PR Checklist:

[ ] pre-commit hooks pass locally
[ ] Tests pass (run make test)
[x] Documentation has been updated to reflect changes, if applicable, and docs build successfully (run make docs)
[x] Changes are added to the CHANGELOG.

wait a sec here ....


Invalid version error

I have a set of uuid's which were generated from different platforms and are very old, are now breaking after the recent commits 90e70752a64cf46564d9eede418fe822948f7529.
One such Id which I am using is : ba60a9fc-b22c-9d4c-970e-5fb8eacdbe16
I get "invalid version" when used with FromString. This id is

Getting the same issue here with GUIDs from Active Directory.

It should be fixed by 0aa62d5ddceb50dbcb909d790b5345affd3669b6. Thanks for reporting it!


problem db

Hello nick , the bd not save all time on good variable

Not a Package Issue. Please request support in the DBS Server.


Tool Reference nodes

Overview

This PR adds the ability to refer to other Tools within other Tools (without necessarily inspecting the implementation of the referent).
Checklist
~- [ ] Styleguide updated, if necessary~
~- [ ] Swagger specification updated, if necessary~
~- [ ] Symlinks from new migrations present or corrected for any new migrations~
Demo
This bit of JSON is a minimal example of ToolReference use:
{
  "id":"e6c1b210-a111-416f-bf83-1193672f192b",
  "toolId":"f3ea90a6-f67b-4e0b-8072-3173cb5180f4"
}

This is the Tool to which it refers.
{
    "id": "f3ea90a6-f67b-4e0b-8072-3173cb5180f4",
    "createdAt": "2017-06-08T20:09:14.706Z",
    "modifiedAt": "2017-06-08T20:09:14.706Z",
    "createdBy": "google-oauth2|109761154833744383601",
    "modifiedBy": "google-oauth2|109761154833744383601",
    "owner": "google-oauth2|109761154833744383601",
    "organization": {
        "id": "dfac6307-b5ef-43f7-beda-b9f208bb7726",
        "createdAt": "2016-11-16T01:55:32.916196Z",
        "modifiedAt": "2016-11-16T01:55:32.916196Z",
        "name": "Public"
    },
    "title": "potsdamtest2",
    "description": "",
    "requirements": "",
    "license": "",
    "visibility": "PUBLIC",
    "compatibleDataSources": [
        ""
    ],
    "stars": 5.5,
    "definition": {
        "id": "a9f4066b-a783-46b6-997d-a0e0d377a1ec"
    },
    "tags": [],
    "categories": []
}

Here's the ToolRun which specifies the sources we'll use (note that the source ID it points to is on the referent Tool):
{
  "visibility" : "PUBLIC",
  "organizationId" : "dfac6307-b5ef-43f7-beda-b9f208bb7726",
  "tool" : "69e4f0a9-47fd-478c-92b5-761bdb089e6a",
  "executionParameters" : {
    "sources" : {
      "a9f4066b-a783-46b6-997d-a0e0d377a1ec" : {
        "id" : "b7a9ba35-ed59-4e8e-bab8-bfefa84145e1",
        "band" : 1,
        "type" : "scene"
      }
    }
  }
}

Here's what we get as a result of that:

Closes ##1790

Is there some rebase weirdness going on?


[Bug] Can not install npm to tar.Extract is not a function

steps
1: uninstall nodist v0.8.8
2: delete 「C:\Program Files (x86)\Nodist」directory
3: install nodist v0.9.0 for 「https://github.com/nullivex/nodist/releases/download/0.9.0/NodistSetup-v0.9.0.exe」
C:\>nodist npm 6.4.1
npm 6.4.1
tar.Extract is not a function.
Sorry.

environment
OS: Window 7 HomePremium SP1 64bit
Lang: ja
C:\Program Files (x86)\Nodist\node_modules\tar\package.json
version: 4.4.8

This is due to a dependency upgrade on the tar package. I will work on a 0.9.1 to address this issue.

I have release version 0.9.1 please see if this corrects the issue.

I have released version 0.9.1 please see if this corrects the issue.

thanks
sorry it's became late for reply
confirmation perfect work


doesn't show buttons

When I open the index file I get just a blank output and I don't see the buttons on the left side. What should I do to fix this?
Thanks for helping :)

yeah local

What local server are you using to open the file?

I just open it in a browser, i tried a different one but none of them works

You can't open an HTML file in the browser directly, you need a local server.  Keep in mind that some basic HTML / Javascript knowledge is required to work with the library. This is a good place to start!


modules/k8s, Ingress dependency on apiVersion

k8s module Ingress strongly depends on k8s.io/api/extensions/v1beta1 although extensions/v1beta1 is deprecated.
If I migrate an ingress to networking.k8s.io/v1 or networking.k8s.io/v1beta1 terratest retreives warnings like this:
W0326 15:52:08.878455   20111 warnings.go:70] extensions/v1beta1 Ingress is deprecated in v1.14+, unavailable in v1.22+; use networking.k8s.io/v1 Ingress
TestK8gbRepeatedlyRecreatedFromIngress 2021-03-26T15:52:08Z retry.go:103: Wait for ingress test-gslb-failover-simple to be provisioned. returned an error: Ingress test-gslb-failover-simple is not available.

The warning is caused by hardcoded  clientset.ExtensionsV1beta1() in GetIngressE function.
func GetIngressE(t testing.TestingT, options *KubectlOptions, ingressName string) (*extensionsv1beta1.Ingress, error) {
   // ...
   return clientset.ExtensionsV1beta1().Ingresses(options.Namespace).Get(context.Background(), ingressName, metav1.GetOptions{})
}

Can you extend the k8s module to support multiple apiVersions ?

Ran into this today. @yorinasub17 I'm happy to take a stab at this but I'll likely need to do some brainstorming to make this backward compatible. Do you know of any existing patterns for supporting multiple API versions in Terratest? Otherwise, I'll come up with a proposal for a possible implementation!

Hi, sorry for the delay in responding to this. I think this is one of the few cases were having a backward incompatible release is fine, given that Kubernetes doesn't really support go modules that well and thus it is near impossible to support multiple API versions when we link the libraries like this.
That said, as far as supporting multiple versions go, I think the only way we can do that is to have multiple copies of the function for each library version.
I opened a PR to update the references: https://github.com/gruntwork-io/terratest/pull/879

Released as https://github.com/gruntwork-io/terratest/releases/tag/v0.34.0


Kacper murzyn/build links job

What does this PR do?
This PR adds new job to the datadog-agent gitlab pipeline which is responsible for updating the QA build links after successful Release Candidate build.
After this PR:

Using inv release.build-rc task will automatically pass rc_build flag to tasks responsible for triggering the build pipelines, to easily identified that the build is for Release Candidate (it will be used for jobs to be added in the near future as well),
If rc_build flag is passed to the build pipeline, there's a new job added to the pipeline that will update build links.

I decide to leave k8s-deployments flag as it is and not merge it together with rc_build, as with the current situation with automatic deployments I think it will be safe to require to opt-in than make it default behaviour. This can be reviewed after some time.
Motivation
Automating part of  Agent Release Candidate build process.
Describe how to test/QA your changes
The change was tested locally as much as possible. The final verification will happen with the next RC build.
Reviewer's Checklist

[ ] If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
[ ] Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
[ ] A release note has been added or the changelog/no-changelog label has been applied.
[ ] Changed code has automated tests for its functionality.
[ ] Adequate QA/testing plan information is provided. Except if the qa/skip-qa label, with required either qa/done or qa/no-code-change labels, are applied.
[ ] At least one team/.. label has been applied, indicating the team(s) that should QA this change.
[ ] If applicable, docs team has been notified or an issue has been opened on the documentation repo.
[ ] If applicable, the need-change/operator and need-change/helm labels have been applied.
[ ] If applicable, the k8s/<min-version> label, indicating the lowest Kubernetes version compatible with this feature.
[ ] If applicable, the config template has been updated.

/merge


Chem: porting "Diversity Search" to TS

Port Diversity Search from core to Chem package in TypeScript

The diversity search viewer was implemented in this comit.


Implement UDP communication services for discv5

Add two simple services that read and write data to and from a UDP socket.
To-Do

[ ] Fix async fixtures: For some reason they don't work even though they should ("RuntimeError: Cannot be used outside of a run context")
[ ] Tell CI to run tests with trio_mode enabled
[ ] Fix type hints if possible
[ ] Clean up commit history

Cute Animal Picture

Now, the current model does have this property in that it appears you could just wire up some trio channels and pretend they had networking behind them.

Yes, the intention is that there are separate services for each processing step (socket, decoding, decryption, handshake, ...) that just receive data from some channel and send it to another. This should make it possible to test all components fully independently.

This should make it possible to test all components fully independently.

Cool, sounds like you've got a vision for this so I'll wait to see how it comes together.


"unable to create impersonator account ... serviceaccounts not found" error after upgrade from 2.5.9 to 2.6.0

Rancher Server Setup

Rancher version: 2.6.0
Installation option (Docker install/Helm Chart): ?

If Helm Chart, Kubernetes Cluster and version (RKE1, RKE2, k3s, EKS, etc): ?

Proxy/Cert Details: ?

Information about the Cluster

Kubernetes version: ?
Cluster Type (Local/Downstream): downstream

If downstream, what type of cluster? (Custom/Imported or specify provider for Hosted/Infrastructure Provider):

Describe the bug

From https://github.com/rancher/rancher/issues/34671#issuecomment-922883807:

Not sure if that's exactly the same issue, but it may be:

I just upgraded a Rancher cluster from 2.5.9 to 2.6.0. It now fails to upgrade the agent in the downstream cluster.

No keycloak is in use, but we use FreeIPA authentication, if that matters.

To Reproduce

Result
Expected Result

Screenshots

Additional context

Created from issue https://github.com/rancher/rancher/issues/34671#issuecomment-922883807. May be related to https://github.com/rancher/rancher/issues/34187.

Experiencing the same issue after 2.6.0 upgrade.
After downloading the kubeconfig, and running kubectl the following error is being observed:
$ k get nodes
Error from server (InternalError): an error on the server ("unable to create impersonator account: error setting up impersonation for user u-qwerty123: failed to get secret for service account: cattle-impersonation-system/cattle-impersonation-u-qwerty123, error: serviceaccounts \"cattle-impersonation-system/cattle-impersonation-u-qwerty123\" not found") has prevented the request from succeeding

Though the UI is successfully able to display the nodes:

@tuxpeople could you enable trace logging on the rancher server for a short time and show any logs related to "impersonation" or "impersonator"? Could you check on the downstream cluster whether the service account is in fact there kubectl -n cattle-impersonation-system get serviceaccount?
How many nodes are in your local RKE1 cluster? How many in the downstream RKE1 cluster, and how was that deployed? RKE1 on existing nodes, cloud provider, or imported?

@ankit-ls if you're able to share any logs or details of your deployment that would be helpful too.

@cmurphy Hi Colleen
There are service accounts in the downstreamcluster, but not the one he complains about:
[root@rancher-test-001 ~]# kubectl -n cattle-impersonation-system get serviceaccount
NAME                                SECRETS   AGE
cattle-impersonation-u-47gxn        1         46h
cattle-impersonation-u-63pxstdqwp   1         46h
cattle-impersonation-u-dvgrzbbuyx   1         46h
cattle-impersonation-u-gykbp3it2p   1         46h
cattle-impersonation-u-j2jv9        1         46h
cattle-impersonation-u-mxl2w3kt73   1         46h
cattle-impersonation-u-pegwa4vgkj   1         46h
cattle-impersonation-u-t2lawztxdm   1         46h
cattle-impersonation-u-wqajade3yl   1         46h
cattle-impersonation-u-zflcmvxsm4   1         46h
cattle-impersonation-user-tx2zz     1         46h
default                             1         46h

The management Cluster consists of 3 Nodes, the downstream cluster consists of 6 nodes (3 Worker, 3 Controlplane). Downstream cluster was deployed out of Rancher, "existing nodes" with the docker command Rancher displays. The cluster is not very new, but I can't tell you which was the first version we installed. But I remember to already upgrade this cluster to 2.5 back when that was released.
[root@rancher-test-001 ~]# export KUBECONFIG=/home/rancher/kube_config_rancher-cluster.yml
[root@rancher-test-001 ~]# kubectl get nodes
NAME            STATUS   ROLES                      AGE    VERSION
XX.XXX.XX.XXX   Ready    controlplane,etcd,worker   536d   v1.21.5
XX.XXX.XX.XXY   Ready    controlplane,etcd,worker   536d   v1.21.5
XX.XXX.XX.XXZ   Ready    controlplane,etcd,worker   536d   v1.21.5
[root@rancher-test-001 ~]#
[root@rancher-test-001 ~]# export KUBECONFIG=/home/rancher/downstreamcluster-config.yml
[root@rancher-test-001 ~]# kubectl get nodes
NAME           STATUS   ROLES               AGE    VERSION
kln-test-001   Ready    worker              404d   v1.20.6
kln-test-002   Ready    worker              404d   v1.20.6
kln-test-003   Ready    worker              152d   v1.20.6
kms-test-001   Ready    controlplane,etcd   404d   v1.20.6
kms-test-002   Ready    controlplane,etcd   404d   v1.20.6
kms-test-003   Ready    controlplane,etcd   404d   v1.20.6

As for the logs, please find them attached. I tried to capture the interesting part (cut stuff away from before and after, but nod from between). Let me know if you need more:
rancher-log.txt
As Rancher complains about secrets, here's also a list of them in the downstreamcluster:
[root@rancher-test-001 ~]# kubectl -n cattle-impersonation-system get secrets
NAME                                            TYPE                                  DATA   AGE
cattle-impersonation-u-47gxn-token-fwgkb        kubernetes.io/service-account-token   3      47h
cattle-impersonation-u-63pxstdqwp-token-5hdjg   kubernetes.io/service-account-token   3      47h
cattle-impersonation-u-dvgrzbbuyx-token-sk7h7   kubernetes.io/service-account-token   3      47h
cattle-impersonation-u-gykbp3it2p-token-swhjf   kubernetes.io/service-account-token   3      47h
cattle-impersonation-u-j2jv9-token-5btr7        kubernetes.io/service-account-token   3      47h
cattle-impersonation-u-mxl2w3kt73-token-zhxkr   kubernetes.io/service-account-token   3      47h
cattle-impersonation-u-pegwa4vgkj-token-cfrlr   kubernetes.io/service-account-token   3      47h
cattle-impersonation-u-t2lawztxdm-token-z7t77   kubernetes.io/service-account-token   3      47h
cattle-impersonation-u-wqajade3yl-token-wvpp9   kubernetes.io/service-account-token   3      47h
cattle-impersonation-u-zflcmvxsm4-token-d6466   kubernetes.io/service-account-token   3      47h
cattle-impersonation-user-tx2zz-token-pnpzf     kubernetes.io/service-account-token   3      47h
default-token-5krdc

@tuxpeople could you enable TRACE logs with
$ kubectl -n cattle-system get pods -l app=rancher --no-headers -o custom-columns=name:.metadata.name | while read rancherpod; do kubectl -n cattle-system exec $rancherpod -c rancher -- loglevel --set trace; done
and send the logs related to "impersonation" or "impersonator"?

There are service accounts in the downstreamcluster, but not the one he complains about:

That's good information, are there any other warning or error logs in rancher about user u-jfyttf5ej2?

@cmurphy My apologizes, I over-read your "trace" and just copy/pasted "debug" from the linked webpage. Here's a piece of log file, hopefully it helps (slightly redacted):
log2.txt

That's good information, are there any other warning or error logs in rancher about user u-jfyttf5ej2?

I found some while grep trough this new log file. But nothing special except for the not existing, I think.
I wantet to know who this user is. At /dashboard/c/local/auth/management.cattle.io.user I see the users but none of them has this ID. But I also don't see myself there, but as I connected the external auth, I may be tied to the "admin" user, which is on that list.
I tried to directly access /dashboard/c/local/auth/management.cattle.io.user/u-jfyttf5ej2#gp which brings me to the "User: System account for Cluster c-g9q7w". I attached below screenshots from the 4 tabs of the permissions, maybe that system account "lost" some permissions?

Hi @cmurphy
Looks like I've stepped into the same issue:

both clusters RKE provisioned: 1.20.10
Upgrade from Rancher 2.5.9 to 2.6.0

I've got a bit different message, UI is showing:
Error while applying agent YAML, it will be retried automatically: exit status 1, Error from server (InternalError): an error on the server ("unable to create impersonator account: error setting up impersonation for user u-zj7uehpdv3: the server rejected our request for an unknown reason (post namespaces.meta.k8s.io)") has prevented the request from succeeding
The server logs starts from:
2021/09/22 15:49:52 [ERROR] error syncing 'c-vx5mv/creator-cluster-owner': handler cluster-crtb-sync: couldn't ensure service account impersonator: the  server rejected our request for an unknown reason (post namespaces.meta.k8s.io), requeuing 2021/09/22 15:49:52 [ERROR] error syncing 'p-nqfbd/u-yzamxjvdq6-member': handler cluster-prtb-sync: couldn't ensure service account impersonator: the se rver rejected our request for an unknown reason (post namespaces.meta.k8s.io), requeuing 2021/09/22 15:49:52 [ERROR] error syncing 'p-j2mcn/u-huumhjsp6q-member': handler cluster-prtb-sync: couldn't ensure service account impersonator: the se rver rejected our request for an unknown reason (post namespaces.meta.k8s.io), requeuing 2021/09/22 15:49:52 [ERROR] error syncing 'c-vx5mv/u-zj7uehpdv3-admin': handler cluster-crtb-sync: couldn't ensure service account impersonator: the ser ver rejected our request for an unknown reason (post namespaces.meta.k8s.io), requeuing 2021/09/22 15:49:52 [ERROR] error syncing 'p-nqfbd/creator-project-owner': handler cluster-prtb-sync: couldn't ensure service account impersonator: the  server rejected our request for an unknown reason (post namespaces.meta.k8s.io), requeuing 2021/09/22 15:49:52 [ERROR] error syncing 'p-j2mcn/creator-project-owner': handler cluster-prtb-sync: couldn't ensure service account impersonator: the  server rejected our request for an unknown reason (post namespaces.meta.k8s.io), requeuing
I can see repeated:
2021/09/22 16:07:42 [ERROR] error syncing 'c-vx5mv': handler cluster-deploy: Error while applying agent YAML, it will be retried automatically: exit status 1, Error from server (InternalError): an error on the server ("unable to create impersonator account: error setting up impersonation for user u-zj7uehpdv3: the server rejected our request for an unknown reason (post namespaces.meta.k8s.io)") has prevented the request from succeeding , requeuing

@tuxpeople thanks for all the information, this has been really helpful. I've proposed a PR that should address the issue.

I wanted to know who this user is. At /dashboard/c/local/auth/management.cattle.io.user I see the users but none of them has this ID.

The user that Rancher is complaining about is a service user and so it doesn't show up in the list of regular users in the UI. However, you can confirm that the user exists by running kubectl get user u-jfyttf5ej2 on the local cluster.

But I also don't see myself there, but as I connected the external auth, I may be tied to the "admin" user, which is on that list.

Correct, when using external auth your own user gets tied to the admin user and that is what will appear on the list.
For QA: although I haven't been able to naturally get my test system into the state that @tuxpeople describes, I can fake the problem by manually deleting a user's impersonation service account from the downstream cluster (kubectl -n cattle-impersonation-system delete sa cattle-impersonation-user-abcde) and then trying to use kubectl as that user on the downstream cluster.
@difrost this looks like a separate issue and I think is not directly related to the impersonation subsystem that we're addressing in this issue. Are you able to use any kubectl command on the downstream cluster? Can you check if any of these issues could be possible explanations for what you're seeing:

misconfiguration of the load balancer: https://github.com/k3s-io/k3s/issues/1437
problem with the CNI: https://unofficial-kubernetes.readthedocs.io/en/latest/getting-started-guides/kubeadm/#troubleshooting-troubleshooting
problem with Istio: https://github-wiki-see.page/m/istio/istio/wiki/Troubleshooting-Istio#diagnostics

@cmurphy Your help is highly appreciated! Never had a such good and fast response on an issue here for Rancher before.
Out of curiosity: I assume your patch will be included in 2.6.1. Can I just install 2.6.1 and it's going to magically working again or do I have to do manual steps to get the cluster working again?

@cmurphy Thanks for quick turnaround. Indeed this was not a Rancher issue, I've managed to fix it - on downstream cluster a webhook was rejecting requests.
Cheers!

@tuxpeople yes, this will be included in 2.6.1, and upgrading will automatically fix it.
@difrost glad to hear it!

On 2.6.0, reproduced the issue as Colleen has mentioned here
Steps:

Deploy a downstream rke2 cluster
delete the SA in the downstream cluster kubectl -n cattle-impersonation-system delete sa <sa-name>
Download kubeconfig from the cluster on rancher UI
access the kubectl of this cluster from local terminal using this kubeconfig
Error seen:

Error from server (InternalError): an error on the server ("unable to create impersonator account: error setting up impersonation for user u-lxbxl: failed to get secret for service account: cattle-impersonation-system/cattle-impersonation-u-lxbxl, error: serviceaccounts \"cattle-impersonation-system/cattle-impersonation-u-lxbxl\" not found") has prevented the request from succeeding

On 2.6-head commit id: fe57abd

Deploy a downstream rke2 cluster
delete the SA in the downstream cluster kubectl -n cattle-impersonation-system delete sa <sa-name>
Download kubeconfig from the cluster on rancher UI
access the kubectl of this cluster from local terminal using this kubeconfig
The SA gets recreated

> kubectl -n cattle-impersonation-system get sa
NAME                                SECRETS   AGE
cattle-impersonation-u-25kz2efowx   1         12s
cattle-impersonation-u-gqj49        1         4s
default                             1         11m

The workaround that works for us to fix this is by doing a rolling restart on the rancher deployment.
kubectl rollout restart deploy rancher -n cattle-system

This is still an issue with Rancher v2.6.6 and an AKS cluster with version 1.22.6.

I can also confirm that this issue exists on Rancher v2.6.6, with an AKS direct imported cluster. I further verified that it is an issue exclusive to AKS clusters. I took the same cluster, and added it to Rancher the "old" way as a generic cluster, the issue no longer exists. So it very much seems to me like it is an issue with the way Rancher imports an AKS cluster.
EDIT: I kept digging, and I was incorrect. This doesn't have to do with AKS in my case. For me, this was a simple incompatibility with the kubernetes version. We upgraded to k8s v24 a while back. Existing rbac through Rancher kept working. But new users were having issues. The fix was to upgrade Rancher from 2.6.6 to 2.6.8, which is compatible with k8s v24.

Thank you @De1taE1even
I can confirm moving to v2.6.9 ( I specfied 2.6.8 but "stable" did whatever it does) and works with AKS K8 version 1.25.5

Encountered this on 2.6.10

Encountered on 2.7.8


Revert "Revert "e2e dataplex test scenarios""

Reverts data-integrations/google-cloud#1055
@itsankit-google

Resolved conflicts.


feat: enhancement kcl import go struct with schema name and doc field

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

[x] N
[ ] Y

feat: enhancement kcl import go struct with schema name and doc field

Pull Request Test Coverage Report for Build<PHONE_NUMBER>7
Details

4 of 6 (66.67%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.05%) to 32.363%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pkg/tools/gen/genkcl_jsonschema.go
1
3
33.33%

Totals

Change from base Build<PHONE_NUMBER>8:
0.05%

Covered Lines:
5612

Relevant Lines:
17341

💛  - Coveralls


Short description missing from About field

The repo is currently missing a short description in the About field on the code page. Changing this could improve discoverability and visibility.
Example descriptions based on the docs can be found below:

Common description of computational HCI contexts with Python.

Component-based interaction environments for computational HCI with Python.

Generic components for computational human-computer interaction with Python.

Tentative description:
Two-agent component-based interaction environments for computational HCI with Python


What's with all the resolutions?

Hi I just noticed that the package.json has a ton of resolutions.
Resolutions tell the constraint solver "I know better than you!" which is sometimes true, but adding resolutions also has some downsides. I think of them as like a stop gap when one of your dependencies doesn't model their dependencies correctly and you need to force the solver to solve it a certain way while you wait for them to fix it.
Also, resolutions during development can mask your own project's incorrectly configured constraints because resolutions tell the constraint solver to ignore your own dependencies specified versions. So then when someone tries out your library, the constraints you specified in "dependencies" won't work.
I know everyone has their own workflow, and whatever works for you is best - just thought I'd bring up the point in case you hadn't considered it.

Hi @jordwalke. I see what you mean, resolutions definitely make this library harder to use. I wanted to base this off of Bonsai's unreleased development version v0.14 because of some major backwards incompatible changes. This version depends on rest of Jane Street libraries being on  v0.14 as well.
I tried using Jane Street's "bleeding" repository with Esy but struggled to get it going because it doesn't support multiple opam repositories (janestreet-bleeding only contains Jane Street packages), and even if I did it wouldn't have made it easy to use bonsai_revery anyway.

Fixed on master


[Ebay] RU936061244GB

Only one state:
https://www.royalmail.com/track-your-item?trackNumber=RU936061244GB
Another ID: RS848042845GB
All states:
https://gls-group.eu/EU/en/parcel-tracking?match=RS848042845GB
widely used by uk sellers

online with track24, but direct support for royal mail is nice

Add support for GLS website. Royal mail is online with track24


Hot reload not working in VSCode

After saving the changes in VSCode (event changing a simple text), Debug Console returns Reloaded 1 of 495 libraries in 149ms.  But nothing changes in the emulator and I should use Hot Restart instead (Ctrl + Shift + F5)
in contrast to VSCode, Android Studio seems to be ok and changes are visible after saving with Hot Reload

Steps to Reproduce

Create a simple project in VSCode
Start the emulator with Ctrl + F5
Apply some changes
Press Ctrl + S or hot reload button from the panel

Logs

[√] Flutter (Channel stable, v1.17.5, on Microsoft Windows [Version 10.0.18363.628], locale en-US)
    • Flutter version 1.17.5 at F:\flutter
    • Framework revision 8af6b2f038 (5 days ago), 2020-06-30 12:53:55 -0700
    • Engine revision ee76268252
    • Dart version 2.8.4

[√] Android toolchain - develop for Android devices (Android SDK version 30.0.0)
    • Android SDK at C:\Users\Amir\AppData\Local\Android\Sdk
    • Platform android-30, build-tools 30.0.0
    • ANDROID_SDK_ROOT = C:\Users\Amir\AppData\Local\Android\Sdk
    • Java binary at: F:\Program Files\Android\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)
    • All Android licenses accepted.

[√] Android Studio (version 4.0)
    • Android Studio at F:\Program Files\Android\Android Studio
    • Flutter plugin version 47.1.2
    • Dart plugin version 193.7361
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)

[√] Connected device (1 available)
    • Android SDK built for x86 • emulator-5554 • android-x86 • Android 7.0 (API 24) (emulator)

• No issues found!

VSCode version: v1.46.1
Dart extension version: v3.12.1
Flutter extension version: v3.12.1

Hi @ffb255
Are you experiencing the issue only with VS Code or with Android Studio and Terminal as well?
Thank you

It's only in VSCode and Android Studio works fine.

Hi @ffb255
Seems like you it's just VS Code issue for you
Following the indication of VS Code Flutter Extension, the correct way to address the problem is to open an issue in the dedicated repository.
Closing, as this isn't an issue with Flutter itself. If you disagree, please write in the comments and I will reopen it.
Thank you

Hello,
Click file (on the left) and enable autosave :) it is work for me :)

Thanks a lot ☺☺


Collapsible onOpenEnd does not fire in Chrome 77.0

var instances = M.Collapsible.init($('.collapsible').first(), {
	onOpenEnd: function(i){
		console.log(i);
	}
});

Works Ok in Firefox but not in Chrome!

My bad. I initiated it empty before that. It works ok on FF but not in chrome. Problema solved removing the empty initiation....


chore: bump dependencies

Hey! 🐻
I came across some build errors and this PR simply fixes that by updating the dependencies.
Cheers!

LGTM! Thanks for contributing!