Put getInput() back in. Remove warning attributes

This is a merge-able version of the last two commits of PR #145:

Added a commit to put the deprecated function getInput() back in. We're trying to make this as backwards compatible to V1.1 as possible.
I think this function was unintentionally removed instead of leaving it in but letting it remain deprecated.

According to a comment made by @dastergon in PR #123 the compiler used by Arduino V1.0.5 doesn't like a deprecated attribute with a message, which causes problems with codebender. However, I've tried it with V1.0.5 and found that deprecated attributes with a message work properly.
There's no need to use a warning attribute to provide a message, so a commit has been added to this PR to remove them.
Besides, if this is a problem with codebender then it can be addressed in the ArduboyClasssic library that codebender uses.

In the Arduino IDE as of V1.6.10 there is a new "includes" property for file library.properties. This specifies which files to include in a sketch when IDE menu item Sketch -> Include Library is used.
A commit has been added to this PR to set the includes property to Arduboy.h. This will prevent ArduboyCore.h, ArduboyAudio.h and any other future unwanted .h files from being included.


Added try/catch for importing json/simplejson for Django 1.7

This has been done in the code base in other places and possibly overlooked in this file.

Coverage decreased (-0.01%) to 28.4% when pulling 34d95cdf8338faa0c3e6f45208e0b596c6d2eff5 on NSLockhart:master into 47844ad9306a29a0c323715bba67482def810793 on django-extensions:master.

Yeah i think so, thanks for the PR !


Bug report: Error: Invalid status code: 1

When Running<EMAIL_ADDRESS>I always get:
⬤  debug     Getting activity for bloedboemmel
⬤  debug     31 events found for bloedboemmel.
[
  '⭐ Starred [bloedboemmel/Steinbock](https://github.com/bloedboemmel/Steinbock)',
  '⭐ Starred [eth-cscs/SummerSchool2021](https://github.com/eth-cscs/SummerSchool2021)',
  '🔱 Forked [bloedboemmel/novatorem](https://github.com/bloedboemmel/novatorem) from [novatorem/novatorem](https://github.com/novatorem/novatorem)',
  '⭐ Starred [Festify/app](https://github.com/Festify/app)',
  '📔 Created new repository [bloedboemmel/bloedboemmel](https://github.com/bloedboemmel/bloedboemmel)'
]
✔  success   Updated README with the recent activity
{ hello: 'readme-workflows.glitch.me' }
⬤  debug     Something went wrong
✖  fatal     Error: Invalid status code: 1
    at ChildProcess.<anonymous> (/home/runner/work/_actions/Readme-Workflows/recent-activity/v2.3.0/dist/index.js:24711:15)
    at ChildProcess.emit (events.js:210:5)
    at maybeClose (internal/child_process.js:1021:16)
    at Socket.<anonymous> (internal/child_process.js:430:11)
    at Socket.emit (events.js:210:5)
    at Pipe.<anonymous> (net.js:659:12)

So apparently getting the updates works. But after that something goes completly wrong. Any help appreciated!

It strangely worked again after making a new yml-Script

Hello @bloedboemmel
I've observed similar failures happen. However, it's very rare (once a week) scenario. But I just noticed that these errors occurred a lot of times in your case. Sorry for the inconvenience caused.
We'll try logging the error details when we release next so that we too will understand it better.
Thanks for bringing this to our notice 😊.


Updating manifest for djobs is not working as expected.

to reproduce:
create a djob
update the notebook path
It doesn't update the notebook path but shows the successful message (it can be at Datbricks API level or Operator level)

@Azadehkhojandi Can you please add me to this repo to be able to assign any bug to myself.
@idc101 there is a limitation at Databricks API level, some fields can't be applied to the active jobs.
Reference from Databricks documentation.

The new settings of the job. These new settings replace the old settings entirely.  Changes to the following fields are not applied to active runs: JobSettings.cluster_spec or JobSettings.task. Changes to the following fields are applied to active runs as well as future runs: JobSettings.timeout_second, JobSettings.email_notifications, or JobSettings.retry_policy. This field is required.

--

If we try to update fields that are not supported, we should probably delete the job and recreate it.


How to disable colored toolbar icons?

Hi,
How can I disable these colored icons on the toolbars? I like the regular grey icon colors better.
I'm using Thorium_AVX2_106.0.5199.0 at the moment.
Thanks.

@danielstreba @gz83 I know they can be changed, as you can see in the TOOLBAR_TINT property when making a chrome theme, which changes the clours. I would like to add a flag which changes the colours of the .icon files, instead of hard coding them in the .icon files themselves. I understand that not everyone will want the new colours, I will work to make it an option rather than hard coded.

@danielstreba @gz83 I know they can be changed, as you can see in the TOOLBAR_TINT property when making a chrome theme, which changes the clours. I would like to add a flag which changes the colours of the .icon files, instead of hard coding them in the .icon files themselves. I understand that not everyone will want the new colours, I will work to make it an option rather than hard coded.

@danielstreba Still having trouble making this something not hard coded. Although I have reverted the reload button icon and cookies icon to blue, because using the greenish color of the chrome labs icon makes it too hard to see in light mode.

@danielstreba @gz83 Checking back in. Gz83, this is something still on the roadmap. Now that we have worked out pretty much all bugs and issues except all the win avx2 issues, I will be focusing more of my attention on developing a chrome://flags flag to toggle top bar icons. Its just a matter of finding where in source code this applies. It is not WebUI, but rather native chrome views. I feel that maybe thorium_ui_debug_shell could help with this. There is somewhere in code that sets the TINT variable, and this could be used to set the colours in the .icon files, without hard coding them in RGB like I showed you before.

bump, this just doesn't work well with themes AT ALL

Hi @Alex313031  been using Thorium for a while and having the same issue here, doesn't look good on any colored theme. Hope this can be fixed! So close to be perfect :)

The color of the icon changed because we hardcoded the color in the code, and we may change the icon subsequently
@Alex313031

@Alex313031 maybe potentially revert them back to the default white while you still work on making it not hard coded?

Was looking to replace ungoogled chromium with Thorium but this is a blocker for me, also the contrast ratio is poor which affects accessibility

@joaocastilho @danielstreba @im-tem @neo773  Added in all releases now that M121 is released today. Closing issue now.


fix(safari): basic dark mode support

Fixes #201
Goal
Fix #201: basic launcher dark mode support
Todos:

[X] Remove explicit background color
[X] Update assets for any / dark modes

Implementation Decisions
Assets were taken from design here and updated within the project to add support for dark mode. By removing the explicit background color, the launcher takes the color of the window based on the selected system theme (i.e white for light, black for dark).
All Submissions:

[ ] Have you followed the guidelines in our Contributing document?
[X] Have you checked to ensure there aren't other open Pull Requests for the same update/change?

@nzeltzer @collectedmind please add the correct label(s) / project(s) / milestone(s) as required

@dskuza Let’s get Jen’s eyes on this before merging.

@nzeltzer Re-review requested as I made a change to explicitly set window color for OSes < 10.14 (when dark mode was introduced).


Fix Markdown syntax in Tasks/RunDistributedTests/README file

Fix mainly headers syntax and other minor changes

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@madd0 can you re open this after fixing the conflicts. Will merge after that


Please add standard testing

Please add standard github based testing.
New release will not be accepted at repository without successfull testing.
If you need assitance, please let us know. I can provide a PR if desired.

looks like testing has been added.


Property is not generated

Hi!
As far as I can see, there is no code generated for the following constellation:
class Preference {
String _id;
set id(String value) {
checkNotEmpty(value, source: "id");
_id = value;

}
get id {
return _id;
}
....
@JsonSerializable(nullable: false)
class PreferenceModel extends Preference with EquatableMixin {
PreferenceModel() : super();
@override
get id {
if (super.id == null || super.id.trim().isEmpty) {
super.id = Uuid().v4();
}
return super.id;
}
...
Don't know if this is because of the name 'id', similar fields seem to work fine.

The underscore prefix means the variable is private in your class (dart convention).
Private members are not serialized. Just make your field final to prevent mutating it by accident.
`final String id;
PreferenceModel(this.id);
`
Don't call super() as your class does not heritage from any class.

This is compiling code. PreferenceModel extends from Preference.The call to super is correct.
I know that _id is private, the getter and setter are not. The same stuff seem to work with other fields.

That's a legit bug!

Fixed published https://pub.dev/packages/json_serializable/versions/3.4.1


[#2077] improvement: Check java version in release scripts

What changes were proposed in this pull request?
Check java version in release scripts
Why are the changes needed?
Use a fixed java version in the release scripts
Fix: #2077
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Manual test:
Use mismatched java version:
./release/create-package.sh binary

output:
Unexpected Java version: 17.0.10. Java 8 is required for release.

When using matched Java version, release scripts execute successfully.

#1983 @wForget

#1983 @wForget

That's a good way, thank you.


Update example code about Promise.all

download module returns the instance of stream instead of promise. However, we can call then/catch to manage promise event through extented binding methods but not in Promise.all. So the example should be updated but I'm not sure what is the best way to use Promise.all with download. Any recommends?

I've missunderstanding for it. nevermind


Re-downloaded folder for pset5 does not show up on my GUI

I had trouble compiling my code that I wrote in dictionary.c, so I figured I'd just delete my entire Speller folder and re-download it. When I did as the instruction said, I noticed that the speller folder did not show up on my GUI. However if I enter ls in my terminal window, all the files that should be in the folder is listed, I just can't physically see the folder, which means I can't open dictionary.c and type my code in to test my program.
Version: 1.83.1
Commit: f1b07bd25dfad64b0167beb15359ae573aecd2cc
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36
Embedder: codespaces

This issue is caused by an extension, please file it with the repository (or contact) the extension has linked in its overview in VS Code or the marketplace for VS Code. See also our issue reporting guidelines. If you don't know which extension is causing the problem, you can run Help: Start extension bisect from the command palette (F1) to help identify the problem extension.
Happy Coding!


Extension Table 5065 – Interaction Log Entry

The "OpenAttachment" feature must add at least two publishers.
•	OnBeforeOpenAttachment ( incl.IsHandled)
•	OnAfterCopyFieldsFromInteractLogEntry

TheSetCancelledCheckmarkfeature must receive a publisher "OnBeforeCancelledCheckMark." There must be an IsHandled parameter.

Alternatively, an intervention in the above function "ToggleCanceledCheckmark" would be possible as long as one gets influence on the filtering and selection of the activity log posts to be deleted.

First event already exist. For the second ask, please specify event with parameters and place in the code. Without this information it cannot be implemented.

Event information missing, no reply from partner, cannot implement

Hello all,
here your information about the second publisher.

Hello,
based on my phone call with jared hall yesterday, here is a better definition for this function. I also added an description of the event(s) needed.
Additionally i developed the events by my own. Take a look at the C/AL  object i'va added.
Here you can see the exact publishers, parameters, function name etc.
I also splitted this event request. This one is about function "OpenAttachment". I made a new one for the second function.
My Code is documented like:
// A/ Event Request
OnBeforeSomething...
// E/ Event Request
Requested Event in CU 5052 - Function "ProcessDeliverySorter"

OnBeforeOpenAttachment
OnAfterOpenAttachment

Tab 5065 Interaction Log Entry.txt
in Addition:
i can not agree to your comment that the first event allready exists. I found the event "OnOpenAttachmentOnBeforeShowAttachment(Rec,SegLine);" in your code. But that event is only triggered in a specific case. It is not like a "OnBefore..." Event.
I hope you allready have all needed information.

https://github.com/microsoft/ALAppExtensions/issues/3561


not eligible for auto-proxying

2024-02-29 09:39:23.928  WARN 80213 --- [winx-admin] [           main] trationDelegate$BeanPostProcessorChecker : Bean 'wingsCacheOperationSource' of type [pro.fessional.wings.slardar.cache.spring.WingsCacheAnnoOprSource] is not eligible for getting processed by all BeanPostProcessors (for example: not eligible for auto-proxying). Is this bean getting eagerly injected into a currently created BeanPostProcessor [healthEndpointGroupsBeanPostProcessor]? Check the corresponding BeanPostProcessor declaration and its dependencies.
2024-02-29 09:39:23.936  INFO 80213 --- [winx-admin] [           main] p.f.w.s.s.b.SlardarCacheConfiguration    : Slardar spring-bean wingsCacheInterceptor as Primary
2024-02-29 09:39:23.949  WARN 80213 --- [winx-admin] [           main] trationDelegate$BeanPostProcessorChecker : Bean 'wingsCacheInterceptor' of type [pro.fessional.wings.slardar.cache.spring.WingsCacheInterceptor] is not eligible for getting processed by all BeanPostProcessors (for example: not eligible for auto-proxying). Is this bean getting eagerly injected into a currently created BeanPostProcessor [healthEndpointGroupsBeanPostProcessor]? Check the corresponding BeanPostProcessor declaration and its dependencies.
2024-02-29 09:39:23.983  WARN 80213 --- [winx-admin] [           main] trationDelegate$BeanPostProcessorChecker : Bean 'io.sentry.spring.jakarta.checkin.SentryCheckInAdviceConfiguration' of type [io.sentry.spring.jakarta.checkin.SentryCheckInAdviceConfiguration] is not eligible for getting processed by all BeanPostProcessors (for example: not eligible for auto-proxying). Is this bean getting eagerly injected into a currently created BeanPostProcessor [healthEndpointGroupsBeanPostProcessor]? Check the corresponding BeanPostProcessor declaration and its dependencies.
2024-02-29 09:39:23.988  WARN 80213 --- [winx-admin] [           main] trationDelegate$BeanPostProcessorChecker : Bean 'io.sentry.spring.jakarta.checkin.SentryCheckInPointcutConfiguration' of type [io.sentry.spring.jakarta.checkin.SentryCheckInPointcutConfiguration] is not eligible for getting processed by all BeanPostProcessors (for example: not eligible for auto-proxying). Is this bean getting eagerly injected into a currently created BeanPostProcessor [healthEndpointGroupsBeanPostProcessor]? Check the corresponding BeanPostProcessor declaration and its dependencies.
2024-02-29 09:39:23.990  WARN 80213 --- [winx-admin] [           main] trationDelegate$BeanPostProcessorChecker : Bean 'sentryCheckInPointcut' of type [org.springframework.aop.support.ComposablePointcut] is not eligible for getting processed by all BeanPostProcessors (for example: not eligible for auto-proxying). Is this bean getting eagerly injected into a currently created BeanPostProcessor [healthEndpointGroupsBeanPostProcessor]? Check the corresponding BeanPostProcessor declaration and its dependencies.
2024-02-29 09:39:23.992  WARN 80213 --- [winx-admin] [           main] trationDelegate$BeanPostProcessorChecker : Bean 'io.sentry.spring.boot.jakarta.SentryAutoConfiguration$HubConfiguration' of type [io.sentry.spring.boot.jakarta.SentryAutoConfiguration$HubConfiguration] is not eligible for getting processed by all BeanPostProcessors (for example: not eligible for auto-proxying). Is this bean getting eagerly injected into a currently created BeanPostProcessor [healthEndpointGroupsBeanPostProcessor]? Check the corresponding BeanPostProcessor declaration and its dependencies.
2024-02-29 09:39:23.999  WARN 80213 --- [winx-admin] [           main] trationDelegate$BeanPostProcessorChecker : Bean 'io.sentry.spring.boot.jakarta.SentryAutoConfiguration$HubConfiguration$ContextTagsEventProcessorConfiguration' of type [io.sentry.spring.boot.jakarta.SentryAutoConfiguration$HubConfiguration$ContextTagsEventProcessorConfiguration] is not eligible for getting processed by all BeanPostProcessors (for example: not eligible for auto-proxying). Is this bean getting eagerly injected into a currently created BeanPostProcessor [healthEndpointGroupsBeanPostProcessor]? Check the corresponding BeanPostProcessor declaration and its dependencies.
2024-02-29 09:39:24.121  WARN 80213 --- [winx-admin] [           main] trationDelegate$BeanPostProcessorChecker : Bean 'sentry-io.sentry.spring.boot.jakarta.SentryProperties' of type [io.sentry.spring.boot.jakarta.SentryProperties] is not eligible for getting processed by all BeanPostProcessors (for example: not eligible for auto-proxying). Is this bean getting eagerly injected into a currently created BeanPostProcessor [healthEndpointGroupsBeanPostProcessor]? Check the corresponding BeanPostProcessor declaration and its dependencies.
2024-02-29 09:39:24.158  WARN 80213 --- [winx-admin] [           main] trationDelegate$BeanPostProcessorChecker : Bean 'contextTagsEventProcessor' of type [io.sentry.spring.jakarta.ContextTagsEventProcessor] is not eligible for getting processed by all BeanPostProcessors (for example: not eligible for auto-proxying). Is this bean getting eagerly injected into a currently created BeanPostProcessor [healthEndpointGroupsBeanPostProcessor]? Check the corresponding BeanPostProcessor declaration and its dependencies.
2024-02-29 09:39:24.166  WARN 80213 --- [winx-admin] [           main] trationDelegate$BeanPostProcessorChecker : Bean 'inAppPackagesResolver' of type [io.sentry.spring.boot.jakarta.InAppIncludesResolver] is not eligible for getting processed by all BeanPostProcessors (for example: not eligible for auto-proxying). Is this bean getting eagerly injected into a currently created BeanPostProcessor [healthEndpointGroupsBeanPostProcessor]? Check the corresponding BeanPostProcessor declaration and its dependencies.
2024-02-29 09:39:24.172  WARN 80213 --- [winx-admin] [           main] trationDelegate$BeanPostProcessorChecker : Bean 'sentryOptionsConfiguration' of type [io.sentry.spring.boot.jakarta.SentryAutoConfiguration$HubConfiguration$$Lambda/0x00000008006d5850] is not eligible for getting processed by all BeanPostProcessors (for example: not eligible for auto-proxying). Is this bean getting eagerly injected into a currently created BeanPostProcessor [healthEndpointGroupsBeanPostProcessor]? Check the corresponding BeanPostProcessor declaration and its dependencies.
2024-02-29 09:39:24.195  WARN 80213 --- [winx-admin] [           main] trationDelegate$BeanPostProcessorChecker : Bean 'winxAdminApplication' of type [com.moilioncircle.wings.admin.WinxAdminApplication$$SpringCGLIB$$0] is not eligible for getting processed by all BeanPostProcessors (for example: not eligible for auto-proxying). Is this bean getting eagerly injected into a currently created BeanPostProcessor [healthEndpointGroupsBeanPostProcessor]? Check the corresponding BeanPostProcessor declaration and its dependencies.
2024-02-29 09:39:24.210  WARN 80213 --- [winx-admin] [           main] trationDelegate$BeanPostProcessorChecker : Bean 'spring.info-org.springframework.boot.autoconfigure.info.ProjectInfoProperties' of type [org.springframework.boot.autoconfigure.info.ProjectInfoProperties] is not eligible for getting processed by all BeanPostProcessors (for example: not eligible for auto-proxying). Is this bean getting eagerly injected into a currently created BeanPostProcessor [healthEndpointGroupsBeanPostProcessor]? Check the corresponding BeanPostProcessor declaration and its dependencies.
2024-02-29 09:39:24.213  WARN 80213 --- [winx-admin] [           main] trationDelegate$BeanPostProcessorChecker : Bean 'org.springframework.boot.autoconfigure.info.ProjectInfoAutoConfiguration' of type [org.springframework.boot.autoconfigure.info.ProjectInfoAutoConfiguration] is not eligible for getting processed by all BeanPostProcessors (for example: not eligible for auto-proxying). Is this bean getting eagerly injected into a currently created BeanPostProcessor [healthEndpointGroupsBeanPostProcessor]? Check the corresponding BeanPostProcessor declaration and its dependencies.
2024-02-29 09:39:24.223  WARN 80213 --- [winx-admin] [           main] trationDelegate$BeanPostProcessorChecker : Bean 'gitProperties' of type [org.springframework.boot.info.GitProperties] is not eligible for getting processed by all BeanPostProcessors (for example: not eligible for auto-proxying). Is this bean getting eagerly injected into a currently created BeanPostProcessor [healthEndpointGroupsBeanPostProcessor]? Check the corresponding BeanPostProcessor declaration and its dependencies.
2024-02-29 09:39:24.270  WARN 80213 --- [winx-admin] [           main] trationDelegate$BeanPostProcessorChecker : Bean 'sentryHub' of type [io.sentry.HubAdapter] is not eligible for getting processed by all BeanPostProcessors (for example: not eligible for auto-proxying). Is this bean getting eagerly injected into a currently created BeanPostProcessor [healthEndpointGroupsBeanPostProcessor]? Check the corresponding BeanPostProcessor declaration and its dependencies.
2024-02-29 09:39:24.280  WARN 80213 --- [winx-admin] [           main] trationDelegate$BeanPostProcessorChecker : Bean 'sentryCheckInAdvice' of type [io.sentry.spring.jakarta.checkin.SentryCheckInAdvice] is not eligible for getting processed by all BeanPostProcessors (for example: not eligible for auto-proxying). Is this bean getting eagerly injected into a currently created BeanPostProcessor [healthEndpointGroupsBeanPostProcessor]? Check the corresponding BeanPostProcessor declaration and its dependencies.
2024-02-29 09:39:24.282  WARN 80213 --- [winx-admin] [           main] trationDelegate$BeanPostProcessorChecker : Bean 'sentryCheckInAdvisor' of type [org.springframework.aop.support.DefaultPointcutAdvisor] is not eligible for getting processed by all BeanPostProcessors (for example: not eligible for auto-proxying). Is this bean getting eagerly injected into a currently created BeanPostProcessor [healthEndpointGroupsBeanPostProcessor]? Check the corresponding BeanPostProcessor declaration and its dependencies.
2024-02-29 09:39:24.282  WARN 80213 --- [winx-admin] [           main] trationDelegate$BeanPostProcessorChecker : Bean 'io.sentry.spring.jakarta.exception.SentryExceptionParameterAdviceConfiguration' of type [io.sentry.spring.jakarta.exception.SentryExceptionParameterAdviceConfiguration] is not eligible for getting processed by all BeanPostProcessors (for example: not eligible for auto-proxying). Is this bean getting eagerly injected into a currently created BeanPostProcessor [healthEndpointGroupsBeanPostProcessor]? Check the corresponding BeanPostProcessor declaration and its dependencies.
2024-02-29 09:39:24.285  WARN 80213 --- [winx-admin] [           main] trationDelegate$BeanPostProcessorChecker : Bean 'io.sentry.spring.jakarta.exception.SentryCaptureExceptionParameterPointcutConfiguration' of type [io.sentry.spring.jakarta.exception.SentryCaptureExceptionParameterPointcutConfiguration] is not eligible for getting processed by all BeanPostProcessors (for example: not eligible for auto-proxying). Is this bean getting eagerly injected into a currently created BeanPostProcessor [healthEndpointGroupsBeanPostProcessor]? Check the corresponding BeanPostProcessor declaration and its dependencies.
2024-02-29 09:39:24.287  WARN 80213 --- [winx-admin] [           main] trationDelegate$BeanPostProcessorChecker : Bean 'sentryCaptureExceptionParameterPointcut' of type [org.springframework.aop.support.ComposablePointcut] is not eligible for getting processed by all BeanPostProcessors (for example: not eligible for auto-proxying). Is this bean getting eagerly injected into a currently created BeanPostProcessor [healthEndpointGroupsBeanPostProcessor]? Check the corresponding BeanPostProcessor declaration and its dependencies.
2024-02-29 09:39:24.291  WARN 80213 --- [winx-admin] [           main] trationDelegate$BeanPostProcessorChecker : Bean 'sentryCaptureExceptionParameterAdvice' of type [io.sentry.spring.jakarta.exception.SentryCaptureExceptionParameterAdvice] is not eligible for getting processed by all BeanPostProcessors (for example: not eligible for auto-proxying). Is this bean getting eagerly injected into a currently created BeanPostProcessor [healthEndpointGroupsBeanPostProcessor]? Check the corresponding BeanPostProcessor declaration and its dependencies.
2024-02-29 09:39:24.291  WARN 80213 --- [winx-admin] [           main] trationDelegate$BeanPostProcessorChecker : Bean 'sentryCaptureExceptionParameterAdvisor' of type [org.springframework.aop.support.DefaultPointcutAdvisor] is not eligible for getting processed by all BeanPostProcessors (for example: not eligible for auto-proxying). Is this bean getting eagerly injected into a currently created BeanPostProcessor [healthEndpointGroupsBeanPostProcessor]? Check the corresponding BeanPostProcessor declaration and its dependencies.
2024-02-29 09:39:24.292  WARN 80213 --- [winx-admin] [           main] trationDelegate$BeanPostProcessorChecker : Bean 'io.sentry.spring.jakarta.tracing.SentryAdviceConfiguration' of type [io.sentry.spring.jakarta.tracing.SentryAdviceConfiguration] is not eligible for getting processed by all BeanPostProcessors (for example: not eligible for auto-proxying). Is this bean getting eagerly injected into a currently created BeanPostProcessor [healthEndpointGroupsBeanPostProcessor]? Check the corresponding BeanPostProcessor declaration and its dependencies.
2024-02-29 09:39:24.296  WARN 80213 --- [winx-admin] [           main] trationDelegate$BeanPostProcessorChecker : Bean 'io.sentry.spring.jakarta.tracing.SentrySpanPointcutConfiguration' of type [io.sentry.spring.jakarta.tracing.SentrySpanPointcutConfiguration] is not eligible for getting processed by all BeanPostProcessors (for example: not eligible for auto-proxying). Is this bean getting eagerly injected into a currently created BeanPostProcessor [healthEndpointGroupsBeanPostProcessor]? Check the corresponding BeanPostProcessor declaration and its dependencies.
2024-02-29 09:39:24.297  WARN 80213 --- [winx-admin] [           main] trationDelegate$BeanPostProcessorChecker : Bean 'sentrySpanPointcut' of type [org.springframework.aop.support.ComposablePointcut] is not eligible for getting processed by all BeanPostProcessors (for example: not eligible for auto-proxying). Is this bean getting eagerly injected into a currently created BeanPostProcessor [healthEndpointGroupsBeanPostProcessor]? Check the corresponding BeanPostProcessor declaration and its dependencies.
2024-02-29 09:39:24.300  WARN 80213 --- [winx-admin] [           main] trationDelegate$BeanPostProcessorChecker : Bean 'sentrySpanAdvice' of type [io.sentry.spring.jakarta.tracing.SentrySpanAdvice] is not eligible for getting processed by all BeanPostProcessors (for example: not eligible for auto-proxying). Is this bean getting eagerly injected into a currently created BeanPostProcessor [healthEndpointGroupsBeanPostProcessor]? Check the corresponding BeanPostProcessor declaration and its dependencies.
2024-02-29 09:39:24.301  WARN 80213 --- [winx-admin] [           main] trationDelegate$BeanPostProcessorChecker : Bean 'sentrySpanAdvisor' of type [org.springframework.aop.support.DefaultPointcutAdvisor] is not eligible for getting processed by all BeanPostProcessors (for example: not eligible for auto-proxying). Is this bean getting eagerly injected into a currently created BeanPostProcessor [healthEndpointGroupsBeanPostProcessor]? Check the corresponding BeanPostProcessor declaration and its dependencies.
2024-02-29 09:39:24.301  WARN 80213 --- [winx-admin] [           main] trationDelegate$BeanPostProcessorChecker : Bean 'io.sentry.spring.jakarta.tracing.SentryTransactionPointcutConfiguration' of type [io.sentry.spring.jakarta.tracing.SentryTransactionPointcutConfiguration] is not eligible for getting processed by all BeanPostProcessors (for example: not eligible for auto-proxying). Is this bean getting eagerly injected into a currently created BeanPostProcessor [healthEndpointGroupsBeanPostProcessor]? Check the corresponding BeanPostProcessor declaration and its dependencies.
2024-02-29 09:39:24.302  WARN 80213 --- [winx-admin] [           main] trationDelegate$BeanPostProcessorChecker : Bean 'sentryTransactionPointcut' of type [org.springframework.aop.support.ComposablePointcut] is not eligible for getting processed by all BeanPostProcessors (for example: not eligible for auto-proxying). Is this bean getting eagerly injected into a currently created BeanPostProcessor [healthEndpointGroupsBeanPostProcessor]? Check the corresponding BeanPostProcessor declaration and its dependencies.
2024-02-29 09:39:24.306  WARN 80213 --- [winx-admin] [           main] trationDelegate$BeanPostProcessorChecker : Bean 'sentryTransactionAdvice' of type [io.sentry.spring.jakarta.tracing.SentryTransactionAdvice] is not eligible for getting processed by all BeanPostProcessors (for example: not eligible for auto-proxying). Is this bean getting eagerly injected into a currently created BeanPostProcessor [healthEndpointGroupsBeanPostProcessor]? Check the corresponding BeanPostProcessor declaration and its dependencies.
2024-02-29 09:39:24.306  WARN 80213 --- [winx-admin] [           main] trationDelegate$BeanPostProcessorChecker : Bean 'sentryTransactionAdvisor' of type [org.springframework.aop.support.DefaultPointcutAdvisor] is not eligible for getting processed by all BeanPostProcessors (for example: not eligible for auto-proxying). Is this bean getting eagerly injected into a currently created BeanPostProcessor [healthEndpointGroupsBeanPostProcessor]? Check the corresponding BeanPostProcessor declaration and its dependencies.

is not eligible for getting processed by all BeanPostProcessors (for example: not eligible for auto-proxying). Is this bean getting eagerly injected into a currently created BeanPostProcessor

wings

pro.fessional.wings.slardar.spring.bean.SlardarCacheConfiguration$CacheAop
pro.fessional.wings.slardar.cache.spring.WingsCacheAnnoOprSource
pro.fessional.wings.slardar.cache.spring.WingsCacheInterceptor
com.moilioncircle.wings.admin.WinxAdminApplication

spring

org.springframework.boot.autoconfigure.info.ProjectInfoProperties
org.springframework.boot.autoconfigure.info.ProjectInfoAutoConfiguration
org.springframework.boot.info.GitProperties

sentry

all others

https://github.com/getsentry/sentry-java/pull/3154

Mark all AOP related classes/methods annoted with @Configuration or @Bean with @Role(BeanDefinition.ROLE_INFRASTRUCTURE)


Bug 2101394: Changing the data-test-id

Signed-off-by: Dana Orr<EMAIL_ADDRESS>
📝 Description
🎥 Demo
Before:

After:

/lgtm


Add a separation b/w filename-line number and message in gitlab inline comments

Before

From this PR

👍🏻 strange that this broke no tests, but seems reasonable to me


[blockvault] Fix CICD Test Failure

Installing the dependencies in libpq and libpqxx in the .cicd/platforms/unpinned/macos-10.15-unpinned.sh script is causing the test snapshot_unit_test_eos-vm. This change addresses that issue.

The problem was a bad merge with develop


write type classes chapter, move tactic section

Feel free to add / correct information on type classes. At the end of the section, I wanted to tell users how to modify the "prolog program" by setting priorities of instances, but I could no longer find an instance in the library. Is it still possible to do that?

BTW, I had to cite type classes in Chapter 09.
I will also have to talk about type classes in other tactics (e.g., apply).
Should we switch 09 and 10?

Sure. The order of 9, 10, 11 is largely arbitrary. 8 talks about the
elaborator, and Type Classes are natural to put after that.
Should we do
Type Classes
Structures (since they use type classes)
Tactics (since they are largely independent)
?
On Sat, Feb 7, 2015 at 4:31 PM, Leonardo de Moura<EMAIL_ADDRESS>wrote:

BTW, I had to cite type classes in Chapter 09.
I will also have to talk about type classes in other tactics (e.g.,
apply).
Should we switch 09 and 10?
—
Reply to this email directly or view it on GitHub
https://github.com/leanprover/tutorial/pull/55#issuecomment-73384105.

I agree.
Thanks,
Leo

From: Jeremy Avigad<EMAIL_ADDRESS>Sent: Saturday, February 7, 2015 2:43 PM
To: leanprover/tutorial
Cc: Leonardo de Moura
Subject: Re: [tutorial] write type classes chapter, move tactic section (#55)
Sure. The order of 9, 10, 11 is largely arbitrary. 8 talks about the
elaborator, and Type Classes are natural to put after that.
Should we do
Type Classes
Structures (since they use type classes)
Tactics (since they are largely independent)
?
On Sat, Feb 7, 2015 at 4:31 PM, Leonardo de Moura<EMAIL_ADDRESS>wrote:

BTW, I had to cite type classes in Chapter 09.
I will also have to talk about type classes in other tactics (e.g.,
apply).
Should we switch 09 and 10?

Reply to this email directly or view it on GitHub
https://github.com/leanprover/tutorial/pull/55#issuecomment-73384105.

Reply to this email directly or view it on GitHubhttps://github.com/leanprover/tutorial/pull/55#issuecomment-73386960.

I am heading out now, but I will merge your changes and do the renaming first thing tomorrow morning.

I had a bit of trouble with git, but hopefully everything is o.k. now. I have reordered the chapters as we discussed. @leodemoura, let me know if I should add something about setting priorities of instances (and, if so, how to do it).

@leodemoura, @soonhokong This pull request is waiting to be merged. It has a new chapter on type classes.


Added missing fields in serializer.

Adds missing fields in serialiser. I forgot to add them to the Meta fields :blush:

Codecov Report

Merging #599 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #599   +/-   ##
========================================
  Coverage    96.47%   96.47%
========================================
  Files          125      125
  Lines         3749     3749
  Branches       325      325
========================================
  Hits          3617     3617
  Misses          94       94
  Partials        38       38

Impacted Files
Coverage Δ

datahub/search/investment/serializers.py
100% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bebf774...a7a463d. Read the comment docs.

Can we update one of the tests to make sure the fields are there?

Good idea, so mistake like that won't happen again :) Added.


Benchmark is almost twice as fast in 1.5.4 than Julia 1.6-rc2

Why?

Julia version
constant parameters
full parameters

1.5.4
605us
861us

1.6-rc2
1162us
1392us

It took quite a bit of experimenting, but I think I have isolated the issue. It has to do with operations whose results are in principle known at compile time, in the presence of a rng state. MWE_rand! and kernel_rand! below are functions that perform a division of a constant c by a random number that is generated inside the kernel, while MWE_wo_rand! and kernel_wo_rand! are corresponding functions that perform a division of the same constant c by a random number that is taken from an array that is passed as an argument. By making the computation of c more expensive, you should find that the difference in speed between the Julia versions can be magnified for the benchmark of MWE_rand!, but not MWE_wo_rand!.
Since my rand_binomial! function contains many such operations, I suspect that's why the impact is quite a bit larger for that kernel compared to the MWE below.
Can you reproduce this?

Julia version
MWE_rand!
MWE_wo_rand!

1.5.4
128us
50us

1.6-rc3
158us
51us

Julia code for MWE
using BenchmarkTools
using CUDA
using GPUArrays

gpuarrays_rng() = GPUArrays.default_rng(CuArray)

function kernel_rand!(A, randstates, p::Float32)
    i = (blockIdx().x - 1) * blockDim().x + threadIdx().x
    @inbounds if i <= length(A)
        b = GPUArrays.gpu_rand(Float32, CUDA.CuKernelContext(), randstates)
        c = p^2 + 2*p + 3*p^3 + sqrt(p) + CUDA.log(p) # this is known at kernel compile time
        A[i] = c/b
        return
    end
    return
end

function kernel_wo_rand!(A, B, p::Float32)
    i = (blockIdx().x - 1) * blockDim().x + threadIdx().x
    @inbounds if i <= length(A)
        b = B[i]
        c = p^2 + 2*p + 3*p^3 + sqrt(p) + CUDA.log(p) # this is known at kernel compile time
        A[i] = c/b
        return
    end
    return
end

MWE_rand!(A, p) = MWE_rand!(gpuarrays_rng(), A, p)
function MWE_rand!(rng, A::DenseCuArray, p::Number)
    pp      = Float32(p)
    kernel  = @cuda name="MWE" launch=false kernel_rand!(A, rng.state, pp)
    config  = launch_configuration(kernel.fun)
    threads = Base.min(length(A), config.threads)
    blocks  = cld(length(A), threads)
    kernel(A, rng.state, pp; threads=threads, blocks=blocks)
    return A
end

function MWE_wo_rand!(A::DenseCuArray, B::DenseCuArray, p::Number)
    pp      = Float32(p)
    kernel  = @cuda name="MWE" launch=false kernel_wo_rand!(A, B, pp)
    config  = launch_configuration(kernel.fun)
    threads = Base.min(length(A), config.threads)
    blocks  = cld(length(A), threads)
    kernel(A, B, pp; threads=threads, blocks=blocks)
    return A
end

## main code

const n = 1024

A = CUDA.zeros(n, n)
B = CUDA.rand(n, n)
MWE_rand!(A, 0.5)
MWE_wo_rand!(A, B, 0.5)

println("")
println("Benchmarking MWE_rand!")
display(@benchmark CUDA.@sync MWE_rand!($A, 0.5))
println("")
println("Benchmarking MWE_wo_rand!")
display(@benchmark CUDA.@sync MWE_wo_rand!($A, $B, 0.5))
println("")

The SASS code produced by Julia 1.6.0-rc3 is 7 times longer (3471 lines vs. 485), maybe that's another hint.

Can't reproduce this. On 1.5:
Benchmarking MWE_rand!
BenchmarkTools.Trial:
  memory estimate:  1.69 KiB
  allocs estimate:  53
  --------------
  minimum time:     90.799 μs (0.00% GC)
  median time:      175.431 μs (0.00% GC)
  mean time:        194.407 μs (0.00% GC)
  maximum time:     3.476 ms (0.00% GC)
  --------------
  samples:          10000
  evals/sample:     1
Benchmarking MWE_wo_rand!
BenchmarkTools.Trial:
  memory estimate:  576 bytes
  allocs estimate:  24
  --------------
  minimum time:     34.031 μs (0.00% GC)
  median time:      50.708 μs (0.00% GC)
  mean time:        51.077 μs (0.00% GC)
  maximum time:     190.222 μs (0.00% GC)
  --------------
  samples:          10000
  evals/sample:     1

On 1.6:
Benchmarking MWE_rand!
BenchmarkTools.Trial:
  memory estimate:  2.50 KiB
  allocs estimate:  130
  --------------
  minimum time:     87.467 μs (0.00% GC)
  median time:      90.413 μs (0.00% GC)
  mean time:        90.741 μs (0.20% GC)
  maximum time:     1.877 ms (97.33% GC)
  --------------
  samples:          10000
  evals/sample:     1
Benchmarking MWE_wo_rand!
BenchmarkTools.Trial:
  memory estimate:  1.02 KiB
  allocs estimate:  58
  --------------
  minimum time:     27.681 μs (0.00% GC)
  median time:      28.341 μs (0.00% GC)
  mean time:        28.458 μs (0.00% GC)
  maximum time:     55.978 μs (0.00% GC)
  --------------
  samples:          10000
  evals/sample:     1

The SASS code also isn't much longer:
tim@taurus /tmp$ wc -l 1.5/rand/MWE_1.asm
210 1.5/rand/MWE_1.asm
tim@taurus /tmp$ wc -l 1.6/rand/MWE_1.asm
339 1.6/rand/MWE_1.asm

Could you upload the output of @device_code dir="..." application() in both cases?

Could you also check the master branch of CUDA.jl?

Interesting. I just reran some tests. So on Julia 1.6.0 (release) I'm using either the master branch of CUDA.jl with the master branch of GPUCompiler (with 0.10.0 I'm getting an ERROR: LoadError: LoadError: UndefVarError: ci_cache not defined) or CUDA.jl 2.6.2 with GPUCompiler 0.10.0.  I'm also including the timings from the full kernel used in BinomialGPU.jl (version 0.2.3, not the current one, since that already uses the new rand! function and doesn't work on Julia 1.5 anyway):

Julia version
CUDA.jl version
MWE_rand!
MWE_wo_rand!
rand_binomial! constant parameters
rand_binomial! full parameters

1.5.4
2.4.2
132us
52us
594us
842us

1.6.0
2.6.2
158us
55us
1073us
1379us

1.6.0
master
132us
36us
993us
1319us

Interestingly, I'm not seeing the improvement in MWE_rand! that you are getting. In fact, the behavior you are seeing would probably not have prompted me to look into this.
I will upload the @device_code dir="..." application() in a minute.

1.5.4_2.4.2_rand.zip
1.5.4_2.4.2_wo_rand.zip
1.6.0_2.6.2_rand.zip
1.6.0_2.6.2_wo_rand.zip
1.6.0_master_rand.zip
1.6.0_master_wo_rand.zip

Just as a side note, on Julia 1.6.0 with CUDA#tb/speedup_rand and GPUCompiler#master, as well as using<EMAIL_ADDRESS>I obtain:

Julia version
CUDA.jl version
MWE_rand!
MWE_wo_rand!
rand_binomial! constant parameters
rand_binomial! full parameters

1.6.0
tb/speedup_rand
50us
36us
655us
778us

Julia code for MWE
using BenchmarkTools
using CUDA

function kernel_rand!(A, p::Float32)
    i = (blockIdx().x - 1) * blockDim().x + threadIdx().x
    if i <= length(A)
        b = rand(Float32)
        c = (p^2 + 2*p + 3*p^3 + sqrt(p) + CUDA.log(p)) / (1 + p - p^2) # this is known at kernel launch time
        @inbounds A[i] = c/b
        return
    end
    return
end

function kernel_wo_rand!(A, B, p::Float32)
    i = (blockIdx().x - 1) * blockDim().x + threadIdx().x
    if i <= length(A)
        @inbounds b = B[i]
        c = (p^2 + 2*p + 3*p^3 + sqrt(p) + CUDA.log(p)) / (1 + p - p^2) # this is known at kernel launch time
        @inbounds A[i] = c/b
        return
    end
    return
end

function MWE_rand!(A::DenseCuArray, p::Number)
    pp      = Float32(p)
    kernel  = @cuda name="MWE" launch=false kernel_rand!(A, pp)
    config  = launch_configuration(kernel.fun)
    threads = Base.min(length(A), config.threads)
    blocks  = cld(length(A), threads)
    kernel(A, pp; threads=threads, blocks=blocks)
    return A
end

function MWE_wo_rand!(A::DenseCuArray, B::DenseCuArray, p::Number)
    pp      = Float32(p)
    kernel  = @cuda name="MWE" launch=false kernel_wo_rand!(A, B, pp)
    config  = launch_configuration(kernel.fun)
    threads = Base.min(length(A), config.threads)
    blocks  = cld(length(A), threads)
    kernel(A, B, pp; threads=threads, blocks=blocks)
    return A
end

## main code

const n = 1024

A = CUDA.zeros(n, n)
B = CUDA.rand(n, n)
MWE_rand!(A, 0.5)
MWE_wo_rand!(A, B, 0.5)

println("")
println("Benchmarking MWE_rand!")
display(@benchmark CUDA.@sync MWE_rand!($A, 0.5))
println("")
println("Benchmarking MWE_wo_rand!")
display(@benchmark CUDA.@sync MWE_wo_rand!($A, $B, 0.5))
println("")

Thanks for the device code dumps, but that's only for the MWEs which don't show a significant regression, right?
Furthermore, I can't reproduce when running the full version:
Julia 1.6, CUDA#master:
julia> using BinomialGPU, CUDA, BenchmarkTools
julia> A = CUDA.zeros(Int, 1024, 1024);
julia> probs  = CUDA.rand(Float32, size(A));
julia> @benchmark CUDA.@sync rand_binomial!(A, count = 128, prob = probs)
BenchmarkTools.Trial:
  memory estimate:  32.06 KiB
  allocs estimate:  1950
  --------------
  minimum time:     1.052 ms (0.00% GC)
  median time:      1.075 ms (0.00% GC)
  mean time:        1.089 ms (0.53% GC)
  maximum time:     9.170 ms (63.79% GC)
  --------------
  samples:          4586
  evals/sample:     1

Julia 1.5, CUDA 2.4.2:
julia> @benchmark CUDA.@sync rand_binomial!(A, count = 128, prob = probs)
BenchmarkTools.Trial:
  memory estimate:  3.47 KiB
  allocs estimate:  95
  --------------
  minimum time:     1.114 ms (0.00% GC)
  median time:      1.375 ms (0.00% GC)
  mean time:        1.535 ms (0.11% GC)
  maximum time:     22.349 ms (0.00% GC)
  --------------
  samples:          3237
  evals/sample:     1

So please provide a snippet that demonstrates the actual regression, with device_code dumps.

The code dumps are for all MWE examples in the table just above them. Any other code dumps you need?

So I just reran the exact same code as you did:
Julia 1.6, CUDA#master:
julia> using BinomialGPU, CUDA, BenchmarkTools
julia> A = CUDA.zeros(Int, 1024, 1024);
julia> probs  = CUDA.rand(Float32, size(A));
julia> @benchmark CUDA.@sync rand_binomial!(A, count = 128, prob = probs)
BenchmarkTools.Trial:
  memory estimate:  59.73 KiB
  allocs estimate:  3751
  --------------
  minimum time:     1.226 ms (0.00% GC)
  median time:      1.298 ms (0.00% GC)
  mean time:        1.303 ms (0.25% GC)
  maximum time:     4.945 ms (51.66% GC)
  --------------
  samples:          3838
  evals/sample:     1

Julia 1.5, CUDA 2.4.2:
julia> using BinomialGPU, CUDA, BenchmarkTools

julia> A = CUDA.zeros(Int, 1024, 1024);

julia> probs  = CUDA.rand(Float32, size(A));

julia> @benchmark CUDA.@sync rand_binomial!(A, count = 128, prob = probs)
BenchmarkTools.Trial:
  memory estimate:  2.83 KiB
  allocs estimate:  83
  --------------
  minimum time:     771.439 μs (0.00% GC)
  median time:      819.634 μs (0.00% GC)
  mean time:        829.123 μs (0.11% GC)
  maximum time:     15.338 ms (0.00% GC)
  --------------
  samples:          6019
  evals/sample:     1

So I'm seeing very different behavior on my machine. It is quite curious but unfortunately I don't know where I should look. The MWE I provided above seemed to isolate the reason for the regression, but it seems to be device dependent or we are missing some other factor.

Any ideas why the number of allocations are so different for our Julia 1.6 examples? Or nothing to worry about?

Yeah that might be problematic, I wonder where those come from. Which CUDA version are you using? Might also be interesting to run under NSight Systems, if you have that available, something a la:
run(A) = rand_binomial!(A, count = 128, prob = probs)

function iteration()
  A = CUDA.zeros(Int, 1024, 1024)
  probs  = CUDA.rand(Float32, size(A))
  NVTX.@range "run" run(A)
end

function main()
  # warmup
  iteration()

  CUDA.@profile begin
    NVTX.@range "iteration 1" iteration()
    NVTX.@range "iteration 2" iteration()
  end
end

Run under nsys launch julia. Note that I capture 2 iterations here because the first tends to be a little noisy due to profiler overhead.

$ nvidia-smi
Tue Mar 30 11:17:01 2021
+-----------------------------------------------------------------------------+
| NVIDIA-SMI 460.39       Driver Version: 460.39       CUDA Version: 11.2     |
|-------------------------------+----------------------+----------------------+
| GPU  Name        Persistence-M| Bus-Id        Disp.A | Volatile Uncorr. ECC |
| Fan  Temp  Perf  Pwr:Usage/Cap|         Memory-Usage | GPU-Util  Compute M. |
|                               |                      |               MIG M. |
|===============================+======================+======================|
|   0  GeForce RTX 2070    Off  | 00000000:01:00.0  On |                  N/A |
|  0%   31C    P8    20W / 185W |    163MiB /  7979MiB |      2%      Default |
|                               |                      |                  N/A |
+-------------------------------+----------------------+----------------------+

+-----------------------------------------------------------------------------+
| Processes:                                                                  |
|  GPU   GI   CI        PID   Type   Process name                  GPU Memory |
|        ID   ID                                                   Usage      |
|=============================================================================|
|    0   N/A  N/A      1554      G   /usr/lib/xorg/Xorg                104MiB |
|    0   N/A  N/A      2240      G   cinnamon                           45MiB |
|    0   N/A  N/A     11264      G   /usr/lib/firefox/firefox            1MiB |
|    0   N/A  N/A     13345      G   /usr/lib/firefox/firefox            1MiB |
|    0   N/A  N/A     24135      G   /usr/lib/firefox/firefox            1MiB |
|    0   N/A  N/A     24242      G   /usr/lib/firefox/firefox            1MiB |
|    0   N/A  N/A     24305      G   /usr/lib/firefox/firefox            1MiB |
+-----------------------------------------------------------------------------+

Here are the stats from nsys, using the julia code
using BinomialGPU
using CUDA

run(A, probs) = rand_binomial!(A, count = 128, prob = probs)

function iteration()
  A = CUDA.zeros(Int, 1024, 1024)
  probs = CUDA.rand(Float32, size(A))
  NVTX.@range "run" run(A, probs)
end

function main()
  # warmup
  iteration()

  CUDA.@profile begin
    NVTX.@range "iteration 1" iteration()
    NVTX.@range "iteration 2" iteration()
  end
end

main()

Julia 1.5.4, CUDA 2.4.2:
 Time(%)  Total Time (ns)  Num Calls   Average    Minimum    Maximum          Name
 -------  ---------------  ---------  ----------  --------  ---------  -------------------
    88.1        411’582          6  68’597.0  55’109  119’907  cuMemAlloc_v2
     8.9         41’485          6   6’914.2   3’208   17’419  cuLaunchKernel_ptsz
     3.0         13’910          2   6’955.0   6’051    7’859  cudaLaunchKernel

Exporting [/opt/nvidia/nsight-systems/2020.4.3/target-linux-x64/reports/gpukernsum.py report1.sqlite] to console...

 Time(%)  Total Time (ns)  Instances    Average     Minimum    Maximum                                                   Name
 -------  ---------------  ---------  -----------  ---------  ---------  ----------------------------------------------------------------------------------------------------
    93.9    1’854’516          2  927’258.0  927’130  927’386  julia_BTRS_full(CuDeviceArray<Int64, 2, 1>, CuDeviceArray<Int64, 2, 1>, CuDeviceArray<Float32, 2, 1…
     4.6         91’456          4   22’864.0   22’624   23’136  julia_YY_4_2507(CuKernelContext, CuDeviceArray<Int64, 2, 1>, Int64)
     1.4         28’544          2   14’272.0   13’984   14’560  void gen_sequenced<curandStateXORWOW, float, int, &(float curand_uniform_noargs<curandStateXORWOW>(…

Exporting [/opt/nvidia/nsight-systems/2020.4.3/target-linux-x64/reports/gpumemtimesum.py report1.sqlite] to console... SKIPPED: report1.sqlite does not contain GPU memroy data.

Exporting [/opt/nvidia/nsight-systems/2020.4.3/target-linux-x64/reports/gpumemsizesum.py report1.sqlite] to console... SKIPPED: report1.sqlite does not contain GPU memory data.

Exporting [/opt/nvidia/nsight-systems/2020.4.3/target-linux-x64/reports/osrtsum.py report1.sqlite] to console...

 Time(%)  Total Time (ns)  Num Calls       Average           Minimum          Maximum        Name
 -------  ---------------  ---------  -----------------  ---------------  ---------------  ---------
    99.6  100’137’745          1  100’137’745.0  100’137’745  100’137’745  poll
     0.3        341’892         18         18’994.0          1’044         54’271  ioctl
     0.0         19’324          1         19’324.0         19’324         19’324  waitpid
     0.0          1’661          1          1’661.0          1’661          1’661  read
     0.0          1’372          1          1’372.0          1’372          1’372  sigaction

Exporting [/opt/nvidia/nsight-systems/2020.4.3/target-linux-x64/reports/nvtxppsum.py report1.sqlite] to console...

 Time(%)  Total Time (ns)  Instances    Average     Minimum    Maximum      Range
 -------  ---------------  ---------  -----------  ---------  ---------  -----------
    47.2        342’661          1  342’661.0  342’661  342’661  iteration 1
    29.4        213’277          1  213’277.0  213’277  213’277  iteration 2
    23.5        170’583          2   85’291.5   76’851   93’732  run

Julia 1.6.0, CUDA#master:
 Time(%)  Total Time (ns)  Num Calls   Average    Minimum   Maximum         Name
 -------  ---------------  ---------  ----------  -------  ---------  ----------------
    71.2        128’056          6  21’342.7  1’212  113’991  cuMemAllocAsync
    21.9         39’461          6   6’576.8  2’930   19’914  cuLaunchKernel
     6.9         12’385          2   6’192.5  3’417    8’968  cudaLaunchKernel

Exporting [/opt/nvidia/nsight-systems/2020.4.3/target-linux-x64/reports/gpukernsum.py 1.6.0_master.sqlite] to console...

 Time(%)  Total Time (ns)  Instances      Average         Minimum        Maximum                                                     Name
 -------  ---------------  ---------  ---------------  -------------  -------------  ----------------------------------------------------------------------------------------------------
    96.9    3’678’892          2  1’839’446.0  1’695’383  1’983’509  julia_BTRS_full(CuDeviceArray<Int64, 2, 1>, CuDeviceArray<Int64, 2, 1>, CuDeviceArray<Float32, 2, 1…
     2.3         88’128          4       22’032.0       21’280       22’496  julia__4_1973(CuKernelContext, CuDeviceArray<Int64, 2, 1>, Int64)
     0.8         30’208          2       15’104.0       14’880       15’328  void gen_sequenced<curandStateXORWOW, float, int, &(float curand_uniform_noargs<curandStateXORWOW>(…

Exporting [/opt/nvidia/nsight-systems/2020.4.3/target-linux-x64/reports/gpumemtimesum.py 1.6.0_master.sqlite] to console... SKIPPED: 1.6.0_master.sqlite does not contain GPU memroy data.

Exporting [/opt/nvidia/nsight-systems/2020.4.3/target-linux-x64/reports/gpumemsizesum.py 1.6.0_master.sqlite] to console... SKIPPED: 1.6.0_master.sqlite does not contain GPU memory data.

Exporting [/opt/nvidia/nsight-systems/2020.4.3/target-linux-x64/reports/osrtsum.py 1.6.0_master.sqlite] to console...

 Time(%)  Total Time (ns)  Num Calls      Average          Minimum         Maximum         Name
 -------  ---------------  ---------  ----------------  --------------  --------------  ----------
    98.9   10’086’862          1  10’086’862.0  10’086’862  10’086’862  epoll_wait
     1.0         97’836          3        32’612.0         3’619        55’200  ioctl
     0.1          6’085          1         6’085.0         6’085         6’085  waitpid
     0.0          1’723          1         1’723.0         1’723         1’723  read
     0.0          1’577          1         1’577.0         1’577         1’577  sigaction

Exporting [/opt/nvidia/nsight-systems/2020.4.3/target-linux-x64/reports/nvtxppsum.py 1.6.0_master.sqlite] to console...

 Time(%)  Total Time (ns)  Instances    Average     Minimum    Maximum      Range
 -------  ---------------  ---------  -----------  ---------  ---------  -----------
    70.1        242’159          1  242’159.0  242’159  242’159  iteration 1
    17.4         60’244          2   30’122.0   17’015   43’229  run
    12.5         43’041          1   43’041.0   43’041   43’041  iteration 2

Julia 1.6.0, CUDA 2.6.2:
 Time(%)  Total Time (ns)  Instances      Average         Minimum        Maximum                                                     Name
 -------  ---------------  ---------  ---------------  -------------  -------------  ----------------------------------------------------------------------------------------------------
    96.6    3’388’812          2  1’694’406.0  1’690’806  1’698’006  julia_BTRS_full(CuDeviceArray<Int64, 2, 1>, CuDeviceArray<Int64, 2, 1>, CuDeviceArray<Float32, 2, 1…
     2.6         89’888          4       22’472.0       22’272       22’880  julia__4_1941(CuKernelContext, CuDeviceArray<Int64, 2, 1>, Int64)
     0.9         29’856          2       14’928.0       14’432       15’424  void gen_sequenced<curandStateXORWOW, float, int, &(float curand_uniform_noargs<curandStateXORWOW>(…

Exporting [/opt/nvidia/nsight-systems/2020.4.3/target-linux-x64/reports/gpumemtimesum.py report1.sqlite] to console... SKIPPED: report1.sqlite does not contain GPU memroy data.

Exporting [/opt/nvidia/nsight-systems/2020.4.3/target-linux-x64/reports/gpumemsizesum.py report1.sqlite] to console... SKIPPED: report1.sqlite does not contain GPU memory data.

Exporting [/opt/nvidia/nsight-systems/2020.4.3/target-linux-x64/reports/osrtsum.py report1.sqlite] to console...

 Time(%)  Total Time (ns)  Num Calls      Average          Minimum         Maximum         Name
 -------  ---------------  ---------  ----------------  --------------  --------------  ----------
    96.8   11’054’107          1  11’054’107.0  11’054’107  11’054’107  epoll_wait
     3.1        354’944         18        19’719.1         1’237        43’145  ioctl
     0.1          6’709          1         6’709.0         6’709         6’709  waitpid
     0.0          1’962          1         1’962.0         1’962         1’962  sigaction
     0.0          1’606          1         1’606.0         1’606         1’606  read
     0.0          1’034          1         1’034.0         1’034         1’034  write

Exporting [/opt/nvidia/nsight-systems/2020.4.3/target-linux-x64/reports/nvtxppsum.py report1.sqlite] to console...

  But you can see that the actual julia_BTRS_Full kernel goes from 900us to 1.6ms and 1.9ms, so there's definitely something off with the codegen.

The code dumps are for all MWE examples in the table just above them. Any other code dumps you need?

Yes, for the actual full application (calling the julia_BTRS_full kernel), since the MWEs don't really show the same kind of regression.
Could you share your Manifest you used for profiling? I should have an RTX 2070 available somewhere, I'll try reproducing on there.

If I'm not mistaken, I saw similar timings also in the automatic builds on BuildKite, which are usually run on RTX4000 and RTX2080's, but it is a bit harder to track down in-between different builds. But as an example, I think we can safely compare the builds #22 and #23, which don't have any performance-critical differences, and where the two GPUs are alternated:

Julia version
RTX2080
RTX4000

1.5.4
734us/984us
770us/1116us

1.6.0
1092us/1394us
1138us/1742us

So it doesn't seem to be just an issue on my machine, but I'm still puzzled why you cannot reproduce it on yours.
Here are the manifests for the tests on my machine:
manifests.zip
Finally, here are the code dumps for rand_binomial!:
Julia 1.5.4, CUDA 2.4.2
Julia 1.6.0, CUDA 2.6.2
Let me know if you need anything else.

No longer relevant, since next version will drop support for Julia 1.5, and is now plenty faster (575us/800us).


Update test_dvc.py

Remove outdated xfail

Now failing due to a wrong checksum. Perhaps we just need to update it?


i'm trying to crack DarkSouls3, just to use a Internal Server to play online

( yes, it works with pirate) but i'm having a WARNING until extracting the archives to the game folder.
WARM  SteamStubUpdate  Cannot to upack file ""E/Dark Souls III/DarkSouosIII.exe"" (File not Packed/Other Protector)

i solved.


CAMEL-11959: Add new camel-yql component

Add a new YQL component

We will review soon, thanks @carlphilipp :-)

Great work, I added some comments which would be good if you could take a look at.

Working on the comments

Let us know when you think this is ready

It should be ready for review. Thanks!

Thanks I am working on merging this now


rewrote the logic for the custom locator "label:"

This fixes the following work items:

W-10809197 - "label:" locator strategy doesn't work for labels with spans
W-9070673 - Performance improvement in Input form data for non-lightning components

The logic for transforming a locator such as label:First Name has changed. Previously the code would look for a lightning component with a single XPath, and fall back to finding an input or textarea only once that xpath timed out.  Now it looks for the label first, and from that it tries to find the component it is associated with. This is the
root of the speed performance.
Also, the xpath for finding the related input item has been tweaked to work for more styles of markup. I've added a suite of tests for the variations I've observed in the wild.
Critical Changes
Changes

The custom locator strategy "label:" has been improved to handle more types of markup found in labels (such as labels with spans around the label text), and is as much as 10x faster in finding non-lightning elements such as input and textarea fields. This locator is used by the input form data keyword.

Issues Closed

@boakley could you please edit the release note to include a mention of Robot Framework so that the context is clearer?


Update rego title in OSS defsec Part2

we introduced three new rego checks to the oss. These checks are currently part of the commercial but not included in the oss.
Additionally, there are certain checks in the oss where two checks are combined into a single check. However, in the commercial, these checks are treated as two separate checks. Therefore, we will be splitting the combined checks from the oss into two distinct checks to align with the commercial implementation.
Resolves: SLK-69409

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: mjshastha:x: ManojShasthaYou have signed the CLA already but the status is still pending? Let us recheck it.

@chen-keinan PTAL after you are back, thanks.

lgtm

Looks like tests are failing and there's a merge conflict with upstream after the first PR was merged.


Auto-restore not kicked in when multiple target frameworks is specified

Repro Steps

Create a console (net core ) application
Make sure restore completes and build
Right click and edit the project to the below

<Project ToolsVersion="15.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
  <Import Project="$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props" />
  <PropertyGroup>
    <OutputType>Exe</OutputType>
    <RuntimeIdentifier>win7-x86</RuntimeIdentifier>
    <TargetFrameworks>netcoreapp1.0;net461</TargetFrameworks>
  </PropertyGroup>
  <ItemGroup>
    <Compile Include="**\*.cs" />
    <EmbeddedResource Include="**\*.resx" />
  </ItemGroup>
  <ItemGroup>
    <PackageReference Include="Microsoft.NETCore.App" Condition="'$(TargetFramework)' == 'netcoreapp1.0'">
      <Version>1.0.1</Version>
    </PackageReference>
    <PackageReference Include="Microsoft.NET.Sdk">
      <Version>1.0.0-alpha-20161104-2</Version>
      <PrivateAssets>All</PrivateAssets>
    </PackageReference>
  </ItemGroup>
  <Import Project="$(MSBuildToolsPath)\Microsoft.CSharp.targets" />
</Project>

Expected
Auto restore is kicked in and it builds successfully
Actual
Restore is not kicked in and build fails with missing assembly reference
WorkAround
Go to the project directory
run "dotnet restore "
run "dotnet build"
now come back and build from IDE and it will build fine.

2017-RC
d15rel/15.0.25913.0

This is a known issue. The problem is that this scenario changes from using TargetFramework to TargetFrameworks and this results in TargetFramework returning an empty string. If you open an unrestored project with TargetFrameworks, auto restore should work correctly. I'll change the title accordingly.


disable jscpd linter

Description
Due to https://github.com/kucherenko/jscpd/issues/215, the jscpd linter can't exclude specific file.
Linked issue(s)/Pull request(s)

issue_number

Type of Change

[ ] Non-breaking bug fix
[ ] Breaking bug fix
[ ] New feature
[ ] Test
[ ] Doc update
[ ] Docker update

Related Component

[ ] Simulation toolkit
[ ] RL toolkit
[ ] Distributed toolkit

Has Been Tested

OS:

[ ] Windows
[ ] Mac OS
[ ] Linux

Python version:

[ ] 3.6
[ ] 3.7

Key information snapshot(s):

Needs Follow Up Actions

[ ] New release package
[ ] New docker image

Checklist

[ ] Add/update the related comments
[ ] Add/update the related tests
[ ] Add/update the related documentations
[ ] Update the dependent downstream modules usage

Codecov Report

Merging #270 (de53ded) into master (1c970c8) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #270   +/-   ##
=======================================
  Coverage   64.37%   64.37%
=======================================
  Files         113      113
  Lines        5553     5553
=======================================
  Hits         3575     3575
  Misses       1978     1978

Flag
Coverage Δ

unittests
64.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c970c8...de53ded. Read the comment docs.

Codecov Report

Merging #270 (de53ded) into master (1c970c8) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #270   +/-   ##
=======================================
  Coverage   64.37%   64.37%
=======================================
  Files         113      113
  Lines        5553     5553
=======================================
  Hits         3575     3575
  Misses       1978     1978

Flag
Coverage Δ

unittests
64.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c970c8...de53ded. Read the comment docs.


Live Demo is not working.

The live demo would help us so much in implementing the editor.

up.
please do something.

Unless the angular rxjs issue is fixed there's nothing that can be done. So, I believe you have to wait until the authors find a fix.

Live demo is now available at https://centroida.github.io/ngx-image-editor/


[MERGE] Cherry pick commits from master to branch 1.0

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/8817/
Test PASSed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/8818/Failed Tests: 1org.alluxio:alluxio-tests: 1alluxio.shell.command.PinCommandTest.setPinTest
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/8819/
Test PASSed.

LGTM


Rename mongo to downsize PVCs

We intend to do a release containing only email blast changes to prod. This is on hold until we've done so. See discussion.

These changes have been covered by the mongo.helm.yml file, so I'm closing this PR


Loading text content is not displaying in chrome while ajax loading of tooltip content,but works in firefox.

When adding dynamic content via tooltipster's predefined ajax "functionBefore" function,first the tooltip shows on hover with "Loading.." text ,then the ajax content gets replaced by it.However this works fine in firefox but in chrome it doesn't work accordingly.The tooltip doesn't show up on hover rather it shows when the ajax response comes up.So If a random user hovers on some element he will not know about the tooltip and the information bundled with the element.Please help me on this....

Hi, it's working in the example given in the documention. Please prepare a jsFiddle to reproduce your issue.


Update using-the-sharepoint-search-query-apis.md

Changed 2010 CSOM doc link to 2013 doc link
Category

[x] Content fix
[ ] New article
Related issues: partially #2666

What's in this Pull Request?
Changed search query doc link to SP2010 CSOM documentation to a link for 2013 CSOM options.

thx @amyegan, appreciated.


[Communication][Email] Adding parameter for only running the PPE stage

I've added a parameter to the email live test pipelines that allows only the PPE stage to be run. This allows us to start a build on this pipeline from our service deployment pipeline.

API change check
API changes are not detected in this pull request.


Better laravel-5 support

:dancers:

I almost think that you shouldn't implement a BugsnagExceptionHandler at all.
Just instruct people to include this code in the one that is there for us to use:
app/Exceptions/Handler.php

<?php namespace App\Exceptions;

use Exception;
use Illuminate\Foundation\Exceptions\Handler as ExceptionHandler;

class Handler extends ExceptionHandler {

  /**
   * A list of the exception types that should not be reported.
   *
   * @var array
   */
  protected $dontReport = [
    'Symfony\Component\HttpKernel\Exception\HttpException'
  ];

  /**
   * Report or log an exception.
   *
   * This is a great spot to send exceptions to Sentry, Bugsnag, etc.
   *
   * @param  \Exception  $e
   * @return void
   */
  public function report(Exception $e)
  {
    // added lines here
    if ( ! $this->shouldntReport($e))
    {
       \Bugsnag::notifyException($e);
    }

    return parent::report($e);
  }

  /**
   * Render an exception into an HTTP response.
   *
   * @param  \Illuminate\Http\Request  $request
   * @param  \Exception  $e
   * @return \Illuminate\Http\Response
   */
  public function render($request, Exception $e)
  {
    return parent::render($request, $e);
  }

}


Old horizon Issues

never forget: https://github.com/stellar/horizon/issues

Hey @jedmccaleb, doesn't look like there's currently anything open at that endpoint. Issue should be closed for now?


Windows CI errors with latest electron-builder

There are errors on Windows CI during the build of example-electron-builder when the latest version is used.  This is blocked pending resolution of (or further information in) https://github.com/electron-userland/electron-builder/issues/8175
The workaround which works for Electron 29 is pinning EB to 24.13.0.

Fixed by #681


Error generating report: ERROR: Cannot find type [html]: verify that the assembly containing this type is loaded. TRACE

Hello,I got this error when running CAMP the report was not generated. I don't know what could have gone wrong.
Logging Started
Start time: 07/21/2023 15:41:39
Computer Name: HSDQIT036
Operating System Name: Microsoft Windows 10 Pro
Operating System Version: 10.0.19045
PowerShell Version: 5.1.19041.3031
********************************************************************************************
07/21/2023 15:41:39 INFO: Configuration Analyzer for Microsoft Purview Started
07/21/2023 15:41:39 INFO: Version Check Started
07/21/2023 15:42:05 INFO: Version Check Completed
07/21/2023 15:42:05 INFO: Establishing Connections
07/21/2023 15:42:56 INFO: Connecting to Exchange Online (Modern Module)..
07/21/2023 15:43:30 INFO: Connecting to Security & Compliance Center
07/21/2023 15:43:55 INFO: Connections Established
07/21/2023 15:43:55 INFO: Fetching User Configurations
07/21/2023 15:43:56 INFO: Getting DLP Settings
07/21/2023 15:45:07 INFO: Getting Information Protection Settings
07/21/2023 15:45:14 WARN: Force Validate not set
07/21/2023 15:45:15 INFO: Getting Communication Compliance Settings
07/21/2023 15:45:20 INFO: Getting Information Governance Settings
07/21/2023 15:45:30 INFO: Getting Audit Settings
07/21/2023 15:45:31 INFO: Getting eDiscovery Settings
07/21/2023 15:45:35 INFO: Getting Insider Risk Management Settings
07/21/2023 15:45:36 INFO: Getting Accepted Domains
07/21/2023 15:45:36 INFO: Getting Alert Policies Settings
07/21/2023 15:45:40 INFO: Getting Organization's region information
07/21/2023 15:45:41 INFO: Getting Organization's solution preference information
07/21/2023 15:45:41 INFO: User Configurations Fetched
07/21/2023 15:45:41 INFO: Creating Output Objects
07/21/2023 15:45:41 ERROR: Cannot find type [html]: verify that the assembly containing this type is loaded.
TRACE: at global:New-Object, <No file>: line 32
at Get-CAMPOutputs, C:\Program Files\WindowsPowerShell\Modules\CAMP\1.1\CAMP.psm1: line 547
at Invoke-CAMP, C:\Program Files\WindowsPowerShell\Modules\CAMP\1.1\CAMP.psm1: line 1291
at Get-CAMPReport, C:\Program Files\WindowsPowerShell\Modules\CAMP\1.1\CAMP.psm1: line 1205
at <ScriptBlock>, <No file>: line 1
********************************************************************************************
Logging Ended
End time: 07/21/2023 15:45:41

Hi David, I am having the same issue. Do you managed to get a solution for this problem. If yes, please share the steps to resolve and fix it. Thanks!


Improve error handling for missing src/dest

Error messages previously did not distinguish between an invalid source input or destination input as the cause of the error, so this simple change clarifies what exactly the issue when console logging in the event of invalid input. There are now separate warnings for (1) if source doesn't exist, (2) if destination doesn't exist, or (3) if both don't exist, so someone encountering one of these issues will hopefully be able to address things more easily. Hope that's clear; let me know if there are any questions 🌮

A couple of minor things, looks good otherwise!

I made the changes requested, let me know how it looks! I think the indentation stuff must have been a tabs vs spaces issue on my editor's end. Should be all good to go now though.

Sorry, it's still there, further down the file.

Ah thank you, sorry I missed that one. Should be fixed now. Have you considered installing something like eslint as a dev dependency? It would certainly make issues like that easier to track down.

Ah, yes, let me set up a travis job for that!

Thanks for this! :sparkles:

Awesome, sounds great. Thanks man 🌮 🌮


CFME 5.9 to 5.10 migration Playbook

Have used this successfully a few times to upgrade 5.9 appliances to 5.10 appliances. Largely similar to other migration playbooks in this repository.

approving based on just looking at it and trustring it is as you say that you have used this a few times.


Build error

go get -u github.com/google/gxui/...

github.com/google/gxui/drivers/gl
C:\Users\Stephan\go\src\github.com\google\gxui\drivers\gl\driver.go:191:12: assignment mismatch: 2 variables but c.window.Window.GetClipboardString returns 1 values
line 191 should be
	str = c.window.GetClipboardString()

As written in readme this package is no longer maintained. If your want to upgrade existing application you can try to use nelsam's fork , otherwise there is A list of Go GUI/graphics/image related projects with several interesting options.


ARM Support?

Would it be possible to issue both an x86 and ARM release?  I'd like to set this up on my raspberry pi using docker for educational purposes.
Thank you!

Yes, I'll add this right now!

v0.2.2 now has support for arm64, amd64, and armv7!


AssociatedMessagesCopyOption default behaviour contradiction

The documentation for the AssociatedMessagesCopyOption parameter for New-MailboxRestoreRequest says two opposing things about default behaviour: that the default is to copy the associated messages, and that the default is to not copy the associated messages.

-AssociatedMessagesCopyOption
The AssociatedMessagesCopyOption parameter specifies whether associated messages are copied when the request is processed. Associated messages are special messages that contain hidden data with information about rules, views, and forms. By default, associated messages are copied. This parameter accepts the following values:

DoNotCopy: The associated messages aren't copied. This is the default option.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 514e13f3-66b0-e6ed-a914-4784823665d6
Version Independent ID: 4028ab31-0d94-8136-bf5b-a49942417900
Content: New-MailboxRestoreRequest (exchange)
Content Source: exchange/exchange-ps/exchange/mailboxes/New-MailboxRestoreRequest.md
Service: exchange-powershell
GitHub Login: @chrisda
Microsoft Alias: chrisda

@officedocsbot assign @yogkumgit

@chrisda Please merge this PR #3997

@dariomws306  Thank you very much for the contribution and updating the documentation with PR. @koolhand Hope this update is helpful for you. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.


Advanced Context Menu to Tabs

First of all congrats for this amazing application :)
If you open Google Chrome or Firefox and you press right click on a Tab you get plenty of options like ...
New Tab
Close Tabs to the Right
Close Tabs to the Left
etc....
It would be great to add this functionality . Of course i can fork the repo and add it but firstly would like to know if you agree so i don't spend time to write the code for no reason ;)

First of all congrats for this amazing application :)

Thanks! I'm glad you like it!
Yes, this is definitely needed. Feel free to contribute.
While you're at it, could you do a couple of things:

Make the context menu fit with Adreana's dark grey and orangered aesthetic
Make this overflow menu and this button with the arrow follow the same aesthetic. I couldn't get a screenshot of the menu itself but you'll see it when you open a lot of tabs.

It's totally cool if you wanna do just the first one, too.
Let me know what you think. Thanks! :+1:

Yes of course i have some css for that too ;)
On Sat, Oct 6, 2018, 07:45 Rohit Awate<EMAIL_ADDRESS>wrote:

First of all congrats for this amazing application :)
Thanks! I'm glad you like it!
Yes, this is definitely needed. Feel free to contribute.
While you're at it, could you do a couple of things:

Make the context menu fit with Adreana
https://github.com/RohitAwate/Everest/blob/master/src/main/resources/css/Adreana.css's
dark grey and orangered aesthetic
Make this overflow menu and this button with the arrow follow the
same aesthetic. I couldn't get a screenshot of the menu itself but you'll
see it when you open a lot of tabs.

[image: ecm]
https://user-images.githubusercontent.com/23148259/46567410-4101be00-c950-11e8-9e6c-108a5d45920a.jpg
It's totally cool if you wanna do just the first one, too.
Let me know what you think. Thanks! 👍
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/RohitAwate/Everest/issues/26#issuecomment-427545840,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ATbiwPa7k1H18hfKl40e8VIwjRfE_BNWks5uiDVpgaJpZM4XH6m7
.


Can't add listfile to map

Why can I edit a map with any file except listfile? I can replace any file in map opening mpq in write mode except for listfile. Also tried using SFileAddListFile instead of SFileAddFileEx but it doesn't seem to alter the mpq. map is https://ufile.io/1wm3p

Listfile is maintained internally by StormLib. Yes, you can add a listfile, but if the map is somehow malformed (which is the case of ANY map protector today), StormLib opens it in read-only mode.

But this map is not opened in read only mode, I can edit any other file in it

True, SFileAddListFile does not alter the map, but it merely adds an extra information about names which are unknown.
You may use SFileAddListFile, then add any file into the map (in order to mark it as changed) and close. StormLib will save the updated listfile.

The thing is, what you are looking for is in WinMPQ, I really don't want MPQ Editor to have the same functionality, gives way too much useless powers to either those who just want to mangle a map or straight up steal things.
Of course, that is coming from a person who did all of the things above, but at least I had to be "tricky" about it. Let's not forget again, that this is MPQ Editor and not WC3 Map Editor, it does more than it should already to be fair.
Anyhow, just use combination of MPQ Editor + WinMPQ, add listfile with WinMPQ, close it and edit with MPQ Editor later.

@Unryze I mean I don´t see the difference, I can already add listfile, then extract all files and then make a new mpq with it. Its just unnecessarily inefficient for me. Map not having editor files and optimized script is the most you can do. Stealing models is already possible, and mpq editor already makes editing harder on read only maps. I am not sure when does it deem it to be read only, but this is not that case.

@juvian
It is a small "problem" for you and me, for others, who never did it, is like an obstacle that they cannot cross.
As for editing, I've edited a lot of maps with just MPQ Editor and Notepad++ from basic abilities to coding, thus I look at it from the same perspective.
Read-Only appears on any, even small malformaion of MPQ via hex, like Vexorian does, etc.

I still don´t see the issue of adding it for non read only maps, which you are supposed to be able to edit

There is no real reason not to add, only if you factor that it won’t be used in most cases just to translate maps, in majority of the cases it will be people trying to inject cheats, change code and etc, which is a very bad trade off.
Let’s wait for Ladik’s response, after all it is up to him to decide, I just gave my 5 cents on this matter. :)

You can already inject cheats on a non read only map.. Most maps where this matters are rpgs, and most do replay checking anyway. I see your point of hacking, but at this point in time even if you know nothing, just need to post the request at the appropiate site and you get hacked map ^^. "Experts" already have their own toolsets, and they do it in really little time.

Just a small addition, there are protections that they are unable to bypass, like saint Seya map for example.
Even Somj with filelist destroyed can’t be fully scanned.
I do have my own toolset of course, but what’s important is to not make life easier for beginners at this, so they don’t consider doing it.
That was pretty much what I was trying to tell, anyways cheers :)

@juvian: Repeat: You may use SFileAddListFile, then add any file into the map (in order to mark it as changed) and close. StormLib will save the updated listfile. Understood? If this won't work, it's a bug.

@ladislav-zezula oh I see, misunderstood that files got marked as changed instead of mpq. Will try it out later, thanks!

@ladislav-zezula is SFileAddListFile second parameter a string to the path of listfile or the listfile text?
Tried with both options and still not working, did:
SFileOpenFileEx
SFileAddListFile
SFileAddFileEx
SFileCloseArchive
Both SFileAddListFile and SFileAddFileEx return true

It's name of the listfile.

@ladislav-zezula tried multiple things, both with a map that had no listfile and one that had, nothing seems to be able to change it (both editable maps)

Could you send me the listfile and the map? I'll test and if there's a bug, I'll fix it.

@ladislav-zezula map without listfile is https://uploadfiles.io/1wm3p, don´t have listfile on this pc but can use just a file with regular files as listfile (war3map.j, war3map.w3a)

I checked and the problem here is that StormLib keeps listfile status on a MPQ. So when there was no listfile before, there will be no listfile after. I recommend keep using an external listfile.

@ladislav-zezula when I tried with a map that had listfile it didn´t work either, unless entries are only added if file exists in mpq?

I just tried with a map that has listfile and it works as expected. Newly added file was added to the MPQ and also to the listfile. Could you send me example of such map?

@ladislav-zezula yeah I meant arbitrarily adding file names that don´t exist to listfile, which doesn´t really have a use but that´s what I had tried. Haven´t tried with a map with partial list file (so with some unknown files) which would make more sense. Yes, if you add a file it works fine, just wanted to extend listfile though. For my particular purposes, managed to edit a map optimizer to take an external listfile, so guess will just go that way instead of modifying stormlib. The whole point of my case was to be able to use the optimizer to optimize map after translation, but map did not have listfile on it. Also 1.30 w3 stops being able to read most korean maps (this included) so rebuilding mpq or optimizing it was necessary. Thanks for your time

I added a new flag to SFileOpenArchive. This one forces adding/updating listfile even if there was none at the at the archive open. Download the latest MPQEditor and follow these steps:

Run MPQEditor.exe YourMap.w3x
In the open dialog, check the "Force adding listfile when modified"
Add a dummy file to the archive
When you close the archive, the listfile will be properly updated.

Please, let me know if this solution is OK for you.

@ladislav-zezula tried on mpq editor, perfect 💯 . Do you have the dll? Hard to get it to compile

Here:
StormLib_DLL.zip


Add release notes for 1.23.1

I'm adding the release notes for 1.23.1 in the release branch. I'll replicate this same PR on main.
I've also added a filterPickRequests flag to our changelog generator as that's what I used to generate the changelog for the point release.

Messages

:book:

Thank you very much for making our website better :heart:!

  Generated by :no_entry_sign: dangerJS against e08953478200ef4b134c00e7b10ff119b8f6a613


cli: fix rootCmd.Long text typo

去 -> 取

Can you translate all Chinese character to English in this file?

I'm working on it.


Add optional functionality to create extra siteadmin host groups

Reworked from #47.
This pull request adds support for cases (such as ours) where administrators want to create additional host groups with a different prefix for each host group in the mapping file. The option is exposed as a TOML array that takes an arbitrary number of extra group prefixes. By default, the array is empty, disabling this feature.
Given the new config options:
hostgroup_siteadmin_prefix = "Hostgroup-"
mapping_file_prefix = "Hostgroup-"
extra_siteadmin_hostgroup_prefixes = ["Templates-", "Foo-", "Bar-"]

and the siteadmin mapping file:
bob@example.com:Hostgroup-bob-hosts

We expect the following groups to be created for this mapping file entry:

Hostgroup-bob-hosts (primary)
Templates-bob-hosts (extra)
Foo-bob-hosts (extra)
Bar-bob-hosts (extra)

Which we observe happening:

Differences from #47
With this approach, we do not modify the logic for creating the standard host groups. It is explicit in the code where we create the extra host groups, instead of the shoe-horned creation seen in the previous implementation. Furthermore, more validation has been added to ensure that mapping_file_prefix is actually found in the mapping file, so that we don't add double prefixes to the new host group names.
Additional features
The config option hostgroup_siteadmin_prefix option adds the ability to create ZAC-managed host groups with a different prefix than the one found in the mapping file.

I still strongly discourage this, but it's not very intrusive to implement.
An issue though:
It crashes if you e.g. have this mapping
bob@example.com:Hostgroup-bob-hosts,Myhosts-bob-hosts

I think I would rather not have the "old prefixes" in config. Just say that by definition the first letters in front of the first hyphen is the prefix? This would of course limit some potential "prefixes", but I think it would be much cleaner and actually more flexible (since you don't need to define a strict known prefix in config).
The reason why I discourage this is like before:
I see no real useful usecase/scenario. The usecase at UiO could/should be solved by merging their use of Siteadmin- and Templates-.
A merge of this PR means that more code (i.e. more complexity) is added to zac without solving a real issue/without adding value.
Also for the record: The Templates- and Siteadmin- duplicate creation was a part of the old "auto config" at UiO. This was not kept/reimplemented in zac by choice. This is because it made/makes no sense for zac to do this.

An issue though: It crashes if you e.g. have this mapping
bob@example.com:Hostgroup-bob-hosts,Myhosts-bob-hosts

This is intentional, as to be certain each host group name is constructed the way we expect (no double prefixes). I've added a new config option strict_prefix_checking (which is disabled by default) that can be enabled to require the "old prefix" to be found in the mapping file entries. Enabling this option requires a prefix to be specified in the config.
All prefix replacement/validation options are also empty by default, so the existing ZAC behavior is unchanged.

This is intentional, as to be certain each host group name is constructed the way we expect (no double prefixes).

I might not have been clear about what I meant. I think that something like ...:
bob@example.com:Hostgroup-bob-hosts1,Myhosts-bob-hosts2

... and ...
extra_siteadmin_hostgroup_prefixes = ["Foo"]

... should result in the groups:
Hostgroup-bob-hosts1
Foo-bob-hosts1
Myhosts-bob-hosts2
Foo-bob-hosts2

(I altered my example a bit, since it would result in two new groups with the same name, i.e. a single group).
I.e. just interpret everything before the first hyphen as the prefix.
I think this is the most flexible solution and require less config (known prefixes)?

I think this is the most flexible solution and require less config (known prefixes)?

Ok, we can do it that way. I will simplify the logic for constructing group names, and document that the program expects groups to have prefixes separated by a hyphen (-) when creating additional host groups.

bob@example.com:Hostgroup-bob-hosts1,Myhosts-bob-hosts2

... and ...
extra_siteadmin_hostgroup_prefixes = ["Foo"]

Given these settings, and the changes made in 6002d51, we now get the following host groups:

Which to me looks correct.

Why is this approved without any comment? A PR should never pass without comment.
I think I would not do the strict part, and not check if there are weird separators in the prefix or anything. Do this just to simplify the code.
E.g now you can do:
>>> #1
>>> mapping_values_with_prefix({"a": ["x-1","x-2"]}, "foo")
{'a': ['foo-1', 'foo-2']}
>>> #2
>>> mapping_values_with_prefix({"a": ["x--1","x--2"]}, "foo")
{'a': ['foo-1', 'foo-2']}
>>> #3
>>> mapping_values_with_prefix({"a": ["x-1","x-2"]}, "foo-")
{'a': ['foo-1', 'foo-2']}
>>> #4
>>> mapping_values_with_prefix({"a": ["x--1","x--2"]}, "foo--")
{'a': ['foo---1', 'foo---2']}

I can really see any reason for having the extra code that makes 2 and 3 equal to 1 when you still can do 4. Just let people do weird stuff if they want to do weird stuff (which can let you get away with less code).
>>> mapping_values_with_prefix({"a": ["x-1","2", "y-3"]}, "foo")
ValueError: Could not find prefix in '2'
>>> mapping_values_with_prefix({"a": ["x-1","2", "y-3"]}, "foo", strict=False)
{'a': ['foo-1', 'foo-', 'foo-3']}

I think I would just allow the above and just skip the ones that doesn't have a prefix. I.e create:
{'a': ['foo-1', 'foo-3']}

@pederhan what do you think? It could make it simpler.

with_prefix could still throw a ValueError, but just accept/pass it in mapping_values_with_prefix perhaps.

Why is this approved without any comment? A PR should never pass without comment.

In this case, "approved" means that the reviewer agrees with the PR. I haven't given any comment to this PR because I had nothing more to say. The PR delivers what we need. And I emphasize this, we need/want this functionality (the creation of an extra hostgroup), we have discussed this internally and it is no problem for us to have this in zac.
Zac is opensource and available to others if they want to use it, but is provided "as is", without warranty of any kind.
We are of course open to discussion, feedback and input but sometimes we have to put an end to some discussions. Unfortunately, we have limited resources at work and we have to limit how much time we use with such a simple functionality as creating an extra host group. We have to remember that this software was created and is used at the university as a tool to help us with the automation of "our" zabbix infrastructure.
About the PR: Does it take care of every corner-case? no. Could it be coded differently? sure. Could it be even more robust? yes. Is it good enough for what we need? yes, and this is the reason why it has been approved.

My suggestion was not implementing this at all and simplifying the design (merging the groups you use). If spending time is an issue this would probably be a better path. But let's not use the PR to discuss how UiO want to spend their time.
I'm happy to hear what @pederhan thinks about my suggestions.
This behavior is probably what would lead to the weirdest groups, since the old name is completely removed from the new name:
>>> with_prefix("2", "Foo", strict=False)
'Foo-'

My suggestion was not implementing this at all and simplifying the design (merging the groups you use). If spending time is an issue this would probably be a better path.

And obviously we have not been able to communicate this clearly enough, we don't want to merge these 2 host groups. They are used for 2 different things:

One, for the hosts/devices owned by a user group.
The other, for the templates owned by a user group.

They are used to organize and categorize two different types of objects in zabbix. This not necessary in an organization without many user groups, but in our case it is necessary because we have a few dozen groups and some of them own hundreds of objects. We want to be able to find out quickly all the templates a user group owns or all the devices a user group owns. Is this so difficult to understand?

And obviously we have not been able to communicate this clearly enough, we don't want to merge these 2 host groups. They are used for 2 different things:
* One, for the hosts/devices owned by a user group.
* The other, for the templates owned by a user group.

Hostgroups are ment to contain both hosts and templates. Your argument isn't valid. You're saying "more is more, because more". What issue does the split resolve?
It doesn't resolve an issue. It creates issues. I have mentioned this loads of times.

They are used to organize and categorize two different types of objects in zabbix. This not necessary in an organization without many user groups, but in our case it is necessary because we have a few dozen groups and some of them own hundreds of objects. We want to be able to find out quickly all the templates a user group owns OR all the devices a user group owns. Is this so difficult to understand?

This problem does not exist. Here is an illustration:

Hostgroups are meant to contain both hosts and templates. Your argument isn't valid. You're saying "more is more, because more". What issue does the split resolve?

Up to zabbix-6.0, host groups CAN contain both hosts and templates but this doesn't mean you cannot use dedicated host groups for templates and dedicated host groups for devices (You as a user can choose this). Afaik, this the way Zabbix has done this for years, a dedicated host group named "Templates" to have all templates in the system register in this host group.
That they have used "Host groups" to organize hosts and templates is actually a misrepresentation of reality because templates and host/devices are not the same type of objects.
And finally in Zabbix-6.2 they have fixed this anomaly once and for all, ref: https://www.zabbix.com/documentation/6.2/en/manual/introduction/whatsnew620#separate-groups-for-templates Now we have "template groups" and "host groups".

Up to zabbix-6.0, host groups CAN contain both hosts and templates but this doesn't mean you cannot use dedicated host groups for templates and dedicated host groups for devices (You as a user can choose this). Afaik, this the way Zabbix has done this for years, a dedicated host group named "Templates" to have all templates in the system register in this host group.

You're still avoiding to come up with an example where it makes sense to split them in the current version. The "more is more" argument isn't valid (An extreme of your argument would be to create TemplatesA-, TemplatesB-, ..., TemplatesZ- groups, where you could add templates where the name starts with the given letter, because more is more? This makes just the same amount of sense).

That they have used "Host groups" to organize hosts and templates is actually a misrepresentation of reality because templates and host/devices are not the same type of objects.

Yes, but that's a problem in Zabbix, not zac.

And finally in Zabbix-6.2 they have fixed this anomaly once and for all, ref: https://www.zabbix.com/documentation/6.2/en/manual/introduction/whatsnew620#separate-groups-for-templates. Now we have "template groups" and "host groups". So actually we have to have the functionality of using separate groups for hosts and templates in place before we upgrade to the next LTS version.

This is new to me. It's probably a good thing and tries to solve the confusion regarding why it's not only hosts in "host groups". This means that this PR needs rework when upgrading to 6.2. Then it makes even less sense to merge it. It's already legacy code before the merge and without any real/good usecases.
Template and access management isn't a part of zac. The creation of template groups should happen in a tool that deals with those things. Or, like I have mentioned, zac should expand it's scope into template and access management. I would welcome an expanded scope as it would make zac more complete :+1:


Language updates

Fixes language issues found during the usability audit and user testing and updates urls throughout the interview.
Fixed #513, Fixed #489, Fixed #480, Fixed #467, Fixed #512, Fixed #487, Fixed #515, Fixed #495

[X] I have manually tested the interview with these changes
[X] I have requested a review from Quinten

@nonprofittechy All look good to me! That makes sense, I wasn't sure how intense we wanted to be in our references to MA only language. I definitely prefer your suggestion.