[Refactor] Little refactor on mv codes

Signed-off-by: kangkaisen<EMAIL_ADDRESS>What type of PR is this：

[ ] BugFix
[ ] Feature
[ ] Enhancement
[x] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Which issues of this PR fixes ：

Fixes #
Problem Summary(Required) ：

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[ ] I have checked the version labels which the pr will be auto backported to target branch

[ ] 2.5
[ ] 2.4
[ ] 2.3
[ ] 2.2

[FE PR Coverage Check]
:heart_eyes: pass : 29 / 36 (80.56%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/catalog/MaterializedView.java
0
1
00.00%
[909]

:large_blue_circle:
com/starrocks/sql/optimizer/rule/transformation/materialization/ColumnRewriter.java
1
3
33.33%
[140, 152]

:large_blue_circle:
com/starrocks/sql/optimizer/rule/transformation/materialization/AggregatedMaterializedViewRewriter.java
5
7
71.43%
[419, 420]

:large_blue_circle:
com/starrocks/sql/optimizer/rule/transformation/materialization/OptExpressionDuplicator.java
6
8
75.00%
[173, 193]

:large_blue_circle:
com/starrocks/sql/optimizer/rule/transformation/materialization/MaterializedViewRewriter.java
7
7
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/rule/transformation/materialization/rule/OnlyJoinRule.java
1
1
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/rule/transformation/materialization/rule/OnlyScanRule.java
1
1
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/rule/transformation/materialization/MvUtils.java
4
4
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/rule/transformation/materialization/rule/AggregateScanRule.java
1
1
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/rule/transformation/materialization/RangeSimplifier.java
1
1
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/rule/transformation/materialization/rule/AggregateAggregateScanRule.java
1
1
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/rule/transformation/materialization/MVColumnPruner.java
1
1
100.00%
[]

run starrocks_admit_test


[Shortcut Guide] Missing icon (left arrow)

Environment
Windows build number: 10.0.18363.836
PowerToys version: 0.18.0
PowerToy module for which you are reporting the bug (if applicable): Shortcut Guide

Steps to reproduce

Press Win key to pop up Shortcut Guide overlay
Expected behavior

Shortcut Guide overlay appears with all the correct icons and icon labels
Actual behavior

The Shortcut Guide overlay appears and everything works just fine apart from the left arrow icon in section "Window controls" is not displayed.
With a dark background as provided in the screenshot below the area where the icon should be appears white instead.
Interestingly, this behavior did not appear from the start on (i.e. directly after installing PowerToys 0.18.0) but appeared all of a sudden without any user-induced changes to the operating system in between (no changed settings, no newly installed software or updates, not even a change in network connection or whatever).
Please do not hesitate to ask for any additional information to backtrace this problem.
Screenshots

Just a short feedback: the issue didn't appear again after rebooting (so far). It might have just been some very weird one-time local issue. If it isn't reproducible by the developers or other users, I'd see this issue as resolved.

Hi @florianhofhammer
thank you for the update. Closing the issue for now, please reopen it if it happens again.
Thank you.


In betweenPairs demo app, include from/to point counts in calculation status message

Change status message from:
BetweenPairs calculated in 1.64 seconds
to:
BetweenPairs took X fromPoints and Y toPoints and calculated X*Y pairs in 1.64 seconds

Alternately, just display fromPoint and toPoint counts somewhere in the form and leave the message the betweenPairs calculated message the same.

I did both options because it was easy and useful.

In delivery (cmhodgson.github.io) now.

Now the line connecting the closest point to the start point isn't redrawn when you change the from point.

BetweenPairs took 1 fromPoints and 3000 toPoints and calculated 90 pairs in 0.291 seconds. Very impressive. It would have taken 75 minutes in the current betweenPairs, done in groups of 40 to fit within the one minute reverse proxy timeout interval.

Verified in test.


Update README.md version to 0.5.0

update 0.4.0 to latest version

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@mukulmurthy thanks, i will close this pr.

Previous changes updated the other two but not examples/README.md. Can we still merge your PR to get that change?

@mukulmurthy sure, I had delete change of README.md which may cause conflict.


Incorrectly Formatted JSON Response (Array of objects in string)

I have checked the following:

[X] I use the newest version of bruno.
[X] I've searched existing issues and found nothing related to my issue.

Describe the bug
The JSON response from the API endpoint is incorrectly formatted, resulting in an additional closing square bracket (]) in the string. This issue causes parsing errors when handling the response data.
.bru file to reproduce the bug
Incorrectly Formatted JSON Response.json
Screenshots/Live demo link

Any Answer for this behavior?


Specify the discriminant for enum variants

#[repr(u8)]
#[derive(Serialize, Deserialize)]
pub enum Enum {
	Variant1(...),
	Variant3(...) = 2
}

Expected result:
Enum::Variant3(...) -> [2, ...]

Hi there @desm86, as far as I am aware: serde doesn't actually use the discriminant value, even if it is specified like this.
Serde provides an integer that is the zero-indexed item, so in your example Variant1 will always be 0 and Variant3 will always be 1.
This is not something postcard can address, unless I am mistaken.


solve an issue caused by dependency updates - std

Hey @dfvgbh: We enjoy your module. We just found out that an upgrade regarding std lead to errors.
This PR will solve those errors by adding an explicit previous version (info) regarding std...

Finally we can use the telegram bot again with this fix -


Issue #718 Add server side entity (and enough client side logic to integration test things)

Test this please

I believe the build errors are caused because there is no reference to the terracotta snapshot repository in the gradle config.


Added final 2 stat tools

@galaxybot deploy this

Ok, I switched the installer to use Mamba instead of Conda and it appears to have worked. We can just leave this in place and hopefully have faster installs for all tool installs on Test and Main.

@galaxybot deploy this

Ok, I switched the installer to use Mamba instead of Conda and it appears to have worked. We can just leave this in place and hopefully have faster installs for all tool installs on Test and Main.

So, its ok to merge the PR (with your changes) when the tool is on Main, right?


KAFKA-16335: Remove deprecated method of StreamPartitioner

Remove deprecated method StreamPartitioner#partition.
All tests were updated if the new signature of StreamPartitioner#partitions.

Next release is 3.8, so we cannot merge this yet. We can of course leave this PR open for the time being, and I can review it when we start 4.0 release (which is planned after 3.8).

Thanks @mjsax, I will fix the problems in the CI and let it open. 😄

Thanks for the PR. trunk was bumped to 4.0-SNAPSHOT so we can finally work on this.
Make a pass. -- Could you also rebase this PR to trunk to make sure it's still up-to-date? We cannot rely on the old Jenkins run any longer.

Thanks @mjsax for reviewing the PR, I'll try to work in the changes this days, so I might let you know if any question comes up.

Thanks for the PR @caioguedes -- merged to trunk.


Failed test on 'Test_hlset'

Steps to reproduce

Clone repository
Run 'make'
Run 'make check'

(Actually I'm using PKGBUILD to build vim package for Archlinux and building fails on test introduced in commin d1a8d658e1b16cf8579fc72cf7aa6a29a57ff5ef)
Expected behaviour
All tests are passed.
Operating system
Archlinux x86_64
Version of Vim
git
Logs and stack traces
xecuted:  4737 Tests
 Skipped:   104 Tests
  FAILED:     1 Tests

Failures:
        From test_highlight.vim:
        Found errors in Test_hlset():
        command line..script /home/vladimir/pkgs/vim/src/vim/src/testdir/runtest.vim[455]..function RunTheTest[44]..Test_hlset[104]..CheckLegacyAndVim9Success[1]..CheckTransLegacySuccess[8]..CheckLegacySuccess[7]..Func line 8: Expected ['myhlg2         xxx term=underline,strikethrough cterm=underline,strikethrough', '                   gui=underline,strikethrough'] but got ['myhlg2         xxx term=underline,strikethrough cterm=underline,strikethrough gui=underline,strikethrough']
        command line..script /home/vladimir/pkgs/vim/src/vim/src/testdir/runtest.vim[455]..function RunTheTest[44]..Test_hlset[104]..CheckLegacyAndVim9Success[2]..CheckTransDefSuccess[7]..CheckDefSuccess[7]..Func line 8: Expected ['myhlg2         xxx term=underline,strikethrough cterm=underline,strikethrough', '                   gui=underline,strikethrough'] but got ['myhlg2         xxx term=underline,strikethrough cterm=underline,strikethrough gui=underline,strikethrough']
        command line..script /home/vladimir/pkgs/vim/src/vim/src/testdir/runtest.vim[455]..function RunTheTest[44]..Test_hlset[104]..CheckLegacyAndVim9Success[3]..CheckTransVim9Success[7]..CheckScriptSuccess[6]..script /home/vladimir/pkgs/vim/src/vim/src/testdir/XScriptSuccess18 line 9: Expected ['myhlg2         xxx term=underline,strikethrough cterm=underline,strikethrough', '                   gui=underline,strikethrough'] but got ['myhlg2         xxx term=underline,strikethrough cterm=underline,strikethrough gui=underline,strikethrough']

TEST FAILURE
make[2]: *** [Makefile:49: report] Error 1
make[2]: Leaving directory '/home/vladimir/pkgs/vim/src/vim/src/testdir

Seems something fishy with spaces.

I see the same bug on xubuntu-18.04.6 (clang-11), 8.2.3582, huge, nogui.
I found that the test:

always succeeds if the terminal has <= 105 columns
always fails if the terminal has > 105 columns

I suppose that the test needs to do :set columns=… to be reliable.  I'll confirm and create a PR if that fixes it.

To @vp1981: I created PR https://github.com/vim/vim/pull/9101 to fix this.
Can you confirm that it also fixes it for you?

Hello dpelle.
Yes, I have COLUMNS=140 and with pr#9101 vim from git compiles fine.

Dominique Pellé @.***> [2021-11-06 01:42 -0700]:

To @vp1981: I created PR https://github.com/vim/vim/pull/9101 to fix this.
Can you confirm that it also fixes it for you?

Your Patch fixes the issue for me too -> $COLUMNS=238.
Thanks for providing the patch ;-)
Elimar
On the keyboard of life you have always
to keep a finger at the escape key;-)

Hi,
On Sat, Nov 6, 2021 at 1:42 AM Dominique Pellé @.***>
wrote:

To @vp1981 https://github.com/vp1981: I created PR #9101
https://github.com/vim/vim/pull/9101 to fix this.
Can you confirm that it also fixes it for you?

I have updated this test in PR #9117 to remove the dependency on the
terminal width.

Yegappan

Confirming that #9101 fixed the issue for me on Ubuntu 20.04.3 LTS


Fixes JsonInputFormatter synchronous read workaround

Fixes https://github.com/aspnet/AspNetCore/issues/7606
PS 2.1/2.2 only. master/3.0 will have this part reworked.

Thanks for your effort, @azhmur.
We're closing this PR as the associated issue is closed.


workspaces: Autodection and members override

As a user, I expected that if I specify the members of my project, then only the members that I specify will be present in the generated page.
However, there is something with the autodetection of members that causes ALL projects to be included, and some included twice, perhaps once with the overidden slug+path, and once with the naturally detected slug+path.
Given the following project file:
{
  "build": {
    "static_dir": "assets"
  },
  "workspace": {
    "name": "MnemOS",
    "members": [
      {
        "slug": "MnemosProjectOverview",
        "path": "."
      },
      {
        "slug": "kernel",
        "path": "./source/kernel"
      },
      {
        "slug": "abi",
        "path": "source/abi"
      },
      {
        "slug": "spitebuf",
        "path": "source/spitebuf"
      },
      {
        "slug": "alloc",
        "path": "source/alloc"
      },
      {
        "slug": "forth3",
        "path": "source/forth3"
      },
      {
        "slug": "sermux-proto",
        "path": "source/sermux-proto"
      },
      {
        "slug": "trace-proto",
        "path": "source/trace-proto"
      },
      {
        "slug": "crowtty",
        "path": "tools/crowtty"
      },
      {
        "slug": "dumbloader",
        "path": "tools/dumbloader"
      },
      {
        "slug": "f3repl",
        "path": "tools/f3repl"
      },
      {
        "slug": "allwinner-core",
        "path": "platforms/allwinner-d1/core"
      },
      {
        "slug": "beepy",
        "path": "platforms/beepy"
      },
      {
        "slug": "melpomene",
        "path": "platforms/melpomene"
      }
    ]
  }
}

I see the following generated page:

My title might be wrong, I've tracked the issue down to these two lines:
https://github.com/axodotdev/oranda/blob/135da68b034f9a10c919c273b51759540c4eb35c/src/config/mod.rs#L154-L155
The first call cfg.apply_custom_layer(conf); seems to populate the workspace members, and then cfg.apply_project_workspace_layer(workspace); seems to populate the members again.


[new component] auto-complete

This component is the latest update from #1985
I decided to open a new PR because of the name change.
Known bug:
from @vijayrawatsan:

Lets say you type in 'h' - > 4 results
After that you type 'e' -> 1 result
No you press backspace to remove letter 'e'. Now the dropdown should show 4 results but it only show 1 result, rest is empty space in dropdown.
This is fixed when I turn animated: false while creating menu.

This might be caused by bug from src/menus/menu.jsx
@oliviertassinari the api has been changed to:
dataSource // for list proprity

/* function(searchText,prevDataSource) -> if return a list,
   then replace dataSource with that list,
   otherwise use the dataSource from props */
onUpdateInput

//and
onNewRequest(searchText,index,dataSource) //if no match then index = null

Please merge, it should be ready! :)

@oliviertassinari @shaurya947 It should be ready now :)

@yongxu The API look good to me :+1:. Could you have a look at my comment? I will merge then

@yongxu Thanks for your effort!

Thanks for all the review @oliviertassinari :+1:

@yongxu @oliviertassinari @shaurya947 :+1:
Finally its merged.

Yes!


User-defined patch replacement functions unusable with patch builder

You can't use a user-defined replacement constructor function through PatchBuilder because the namespace setup by PatchBuilder.library() is wrong. It is using the module path instead of the namespace. Either that or the contract described in the spec is wrong, but I'm gonna go with the impl being incorrect. It does this:
 return {'replace-library':{
    ns: '/ext/marklogic/patch/apply/'+rootname,
    at: '/ext/marklogic/patch/apply/'+module
  }};

Instead of this:
 return {'replace-library':{
    ns: 'http://marklogic/patch/apply/'+rootname,
    at: '/ext/marklogic/patch/apply/'+module
  }};

P.S. There's no unit test for patch UDFs. :)
Example to reproduce the problem follows. Currently, when you run the patch script, you get this cruelly undeserved error:
{ [Error: patch document: cannot process response with 400 status (on /patch/udfs.json)]
  message: 'patch document: cannot process response with 400 status (on /patch/udfs.json)',
  statusCode: 400,
  body:
   { errorResponse:
      { statusCode: 400,
        status: 'Bad Request',
        messageCode: 'XDMP-IMPMODNS',
        message: 'XDMP-IMPMODNS: (err:XQST0059) Import module namespace /ext/marklogic/patch/apply/my-lib does not match target namespace http://marklogic.com/patch/apply/my-lib of imported module /ext/marklogic/patch/apply/my-lib.xqy' } }
}

UDF impl, which might not work as I ran into this bug when I was trying to test it.  Copy into my-lib.xqy.
xquery version "1.0-ml";

module namespace my-lib =
  "http://marklogic.com/patch/apply/my-lib";

(: Double the value of a node :)
declare function my-lib:dbl(
  $current as node()?,
  $args as item()*
) as node()*
{
  if ($current/data() castable as xs:decimal)
  then
    let $new-value := xs:decimal($current/data()) * 2
    return number-node {$new-value}
  else
    fn:error((), "RESTAPI-EXTNERR",
      ("400", "Bad Request", "xml", <reason>Non-decimal data</reason>))
};

(: Find the minimum value in a sequence of value composed of :)
(: the current node and a set of input values. :)
declare function my-lib:min(
  $current as node()?,
  $args as item()*
) as node()*
{
  let $new-value := fn:min(($current/data(), $args))
  return number-node {$new-value}
};

Installation script to stuff it into the modules db. It expects to find the UDF impl lying about as ./my-lib.xqy.
var fs = require('fs');
var marklogic = require('marklogic');
var my = require('./my-connection.js');
var db = marklogic.createDatabaseClient(my.connInfo);

db.config.extlibs.write({
  path: '/marklogic/patch/apply/my-lib.xqy',
  permissions: [
    {'role-name': 'app-user', capabilities: ['execute']}
  ],
  contentType: 'application/xquery',
  source: fs.createReadStream('./my-lib.xqy')
}).result(function(response) {
  console.log('Installed module ' + response.path);
}, function(error) {
  console.log(JSON.stringify(error, null, 2));
});

Script that inserts a document and attempts to patch it using the installed UDFs:
var marklogic = require('marklogic');
var my = require('./my-connection.js');
var db = marklogic.createDatabaseClient(my.connInfo);

// (1) Insert the base document into the database
db.documents.write({
  uri: '/patch/udfs.json',
  contentType: 'application/json',
  content: {
    inventory: [
      {name: "orange", price: 10},
      {name: "apple", price: 15},
      {name: "pear", price: 20}
  ] }
}).result().then(function(response) {
  // (2) Patch the document
  var pb = marklogic.patchBuilder;
  return db.documents.patch(response.documents[0].uri,
    pb.library('my-lib.xqy'),
    pb.replace('/inventory[name eq "orange"]/price', pb.apply('dbl')),
    pb.replace('/inventory[name eq "pear"]/price',
               pb.apply('min', 18, 21))
  ).result();
}).then(function(response) {
  // (3) Emit the resulting document
  return db.documents.read(response.uri).result();
}).then(function(documents) {
  console.log(JSON.stringify(documents[0].content, null, 2));
}, function(error) { console.log(error); throw error; });

Closing backlog issue, the issue has regression test


[AutoPR monitor/resource-manager] Minor Updates - description text

Created to sync https://github.com/Azure/azure-rest-api-specs/pull/2998

(message created by the CI based on PR content)

Codecov Report

Merging #2513 into restapi_auto_monitor/resource-manager will increase coverage by 0.16%.
The diff coverage is 33.33%.

@@                            Coverage Diff                            @@
##           restapi_auto_monitor/resource-manager    #2513      +/-   ##
=========================================================================
+ Coverage                                   54.3%   54.47%   +0.16%
=========================================================================
  Files                                       6022     5472     -550
  Lines                                     136291   128396    -7895
=========================================================================
- Hits                                       74011    69941    -4070
+ Misses                                     62280    58455    -3825

Impacted Files
Coverage Δ

...nitor/azure/mgmt/monitor/models/alerting_action.py
45.45% <ø> (ø)
:arrow_up:

...zure/mgmt/monitor/models/az_ns_action_group_py3.py
50% <ø> (ø)
:arrow_up:

...r/azure/mgmt/monitor/models/alerting_action_py3.py
45.45% <ø> (ø)
:arrow_up:

...or/azure/mgmt/monitor/models/az_ns_action_group.py
50% <ø> (ø)
:arrow_up:

...e-mgmt-monitor/azure/mgmt/monitor/models/source.py
50% <0%> (ø)
:arrow_up:

...mt-monitor/azure/mgmt/monitor/models/source_py3.py
50% <50%> (ø)
:arrow_up:

..._12_01/models/virtual_machine_instance_view_py3.py
23.52% <0%> (-76.48%)
:arrow_down:

.../compute/v2017_12_01/models/virtual_machine_py3.py
25% <0%> (-75%)
:arrow_down:

...ure/mgmt/compute/v2017_12_01/models/os_disk_py3.py
31.25% <0%> (-68.75%)
:arrow_down:

...models/virtual_machine_scale_set_os_profile_py3.py
33.33% <0%> (-66.67%)
:arrow_down:

... and 754 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d19dcb8...56e9c90. Read the comment docs.

This PR has been merged into https://github.com/Azure/azure-sdk-for-python/pull/2460


iOS screen design assumes too large a screen - Elements covered up and can't be scrolled

The developer of the iOS app has made an assumption that everyone owns an iPhone X or larger. The attached screen is from a brand new, current model iPhone SE2. It has a screen the size of the older 6, 7 and 8.
As you can see, it’s not possible to see what is in the “Chart your account” buttons as they are covered by the Wallet Address slider. And you can't get rid of the slider completely, and you can't scroll the underlying screen up to see those assets.
Suggestion to fix could be moving the title of “My Wallet” to the blank space beside the icon and maybe making the description text smaller. This should give you the room to show the currently hidden assets. ** (PS. Looking at the screen again, you already have "My Wallet" at the top, so the title under the icon is superfluous. I'd just remove it.) **

Hi, thanks for reporting. Do you happen to have font scaling enabled on your device?

Yes, I do have font scaling on. With it off on my SE2 (same screen size as 6/7/8) the text is too tiny for my old eyes. I have it on the 3rd tick up.

this screen has been updated, feel free to file another bug if it's still happening.


Is the dataset now publicly available？

Thank you very much for your work, is the dataset now available？

same question here

The dataset is under the IEEE ISBI challenge and is only available to the participants. We are considering making it public (provided a signed Data Usage and Confidentiality Agreement) after the challenge post-proceedings.


Sequencer: import batch section to solve txpool imbalance issue

According to our pressure test result, the sequencers' txpool might be imbalance. For instance, some sequencers' txpool might be empty, while some other sequencers' txpool might have a lot of pending transactions. Under current scheduler policy, we need to wait for a whole batch expire time and produce no blocks, but there are still some pending transactions. As a result, the network TPS will be lower and user experience will be much worse.
To solve the above problem, we can import batch section. For instance, the batch expire time is 60 second. We can divide the whole period into 10 section. So a section time is 6 second. In each section, if the current sequencer doesn't generate valid batchPeriodAnswerMsg, the scheduler should just end the batch and start a new batch. Thus we just need to wait a few time on sequencers with empty txpool.

related issue: https://github.com/mantlenetworkio/mantle/issues/603


RFC: Add Python::with_pool as a safe alternative to GILPool usage.

The Ungil bound is required to prevent the closure from reusing the outer GIL token via captures which does give this a limited applicability compared to direct usage of GILPool, but nevertheless I think it should be safe.
Obviously only draft as this would require a deprecation cycle and an extensive update of the documentation.

Great insight that there is potential for a safe API here. However, I'm a bit concerned that on stable this conflicts with #2141. How do you feel about making this nightly-only, where the auto trait makes it sound?

Great insight that there is potential for a safe API here. However, I'm a bit concerned that on stable this conflicts with #2141. How do you feel about making this nightly-only, where the auto trait makes it sound?

Didn't get a notification mail again...
Hhhmmm, I am not sure about making it nigthly-only. Is it in any way more unsound than with_gil currently is? I would say no. But then again, the bar is higher for adding a new API than for removing an existing one.
One thing that is in favour of adding this as a safe if technically unsound API on stable is that I think this would reduce the probability of making mistakes compared to the existing GILPool API, meaning that that API is easy to misuse whereas the send_wrapper needs or certain purposefulness or at least another layer of wrapping.

So do we add this another option or should it replace the current API? Is it nightly-only or also-stable?

I agree this is significantly easier to use than Python::new_pool, so I am certainly in favour of replacing. I take your point that with send_wrapper interaction there's already some murky waters, however I'm reasonably sure it's us that are in the wrong with allow_threads so it feels incorrect to add a new API to stable with is "safe" despite the misuse of Send.
How do you feel about offering this on both stable and with the nightly feature, with the difference that on stable we keep it as unsafe, and on nightly it is safe?

however I'm reasonably sure it's us that are in the wrong with allow_threads

I think that is definitely the case. We are in the wrong, but we cannot make it right without either using nightly features or making the feature useless using the 'static bound.

it feels incorrect to add a new API to stable with is "safe" despite the misuse of Send.

Strictly speaking it is incorrect, but I think we might need to make room for the immaturity of the language here to avoid the perfect being the enemy of the good. Especially since from a strict point of view, Python::with_gil is just as incorrect.

How do you feel about offering this on both stable and with the nightly feature, with the difference that on stable we keep it as unsafe, and on nightly it is safe?

If we do this and deprecate GILPool::new, the ecosystem will likely start moving towards it and therefore be safe eventually. However, I feel that we will make users unhappy this way as they have the churn of changing the API, but without the benefit of dropping the unsafe code.
Hence, under these requirements, it seems better to me to just add this as a new (mostly unsafe) API without a deprecation of the existing one, possibly even targetting v0.19.x instead of v0.20.0, so that it can gain some voluntary users before we push people this way by starting a deprecation cycle.

Sure thing, so is the agreement that in this PR we will add
impl Python<'_> {
    #[cfg(not(feature = "nightly"))]
    unsafe fn with_pool(...) { }

    #[cfg(feature = "nightly")]
    unsafe fn with_pool(...) { }

which is suitable to cherry-pick for 0.19.1 (should we have reason to create a patch release), and we can leave an issue in the backlog to deprecate Python::new_pool after a major release or two?
My reluctance to add it as "safe" on stable also comes from the hope that we can eliminate the need for the pool entirely before too much longer. In fact, I'm just going to push the prototype I have for that now so that we can discuss whether what I've been sketching out makes sense and begin iteration in that direction.

(Corrected the above snippet to unsafe on stable, safe on nightly.)
Also posted my current branch which might be how we remove the pool in #3205

My reluctance to add it as "safe" on stable also comes from the hope that we can eliminate the need for the pool entirely before too much longer. In fact, I'm just going to push the prototype I have for that now so that we can discuss whether what I've been sketching out makes sense and begin iteration in that direction.

I think that if there is a realistic path towards removal of GILPool entirely, then we should put people on the wrong track by emphasizing it using a new API, even if it might be an improvement. We should implement the replacement and tell people about it.

Ok - though I think it might be quite a while before we manage to phase out the GILPool (because it's likely very breaking and needs some further design) 😅


Fix/navbuttonHover

Description
Fixed the navbar button hover feature.
Fixed #127
Type of change
Please check options that are relevant to your PR.

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] This change requires a documentation update

Checklist:

[x] I have squashed my commits
[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings

@aj3011 I don't see the border-bottom feature fixed. Please check and update your PR.


Add reference/link to more-itertools in the docs

This has been done, all the methods wrapping more-itertools methods include links to upstream.


Incorrect "Module '%s' has no '%s' member"

For example:
Module 'numpy' has no 'zeros' member.
But numpy indeed does have a zeros member and this code runs without error.
Sublime Text, Stable 3803
SublimeLinter 3.5.0
SublimeLinter-PyLint 1.3.1

Do you have a recent numpy ?
cf http://stackoverflow.com/questions/20553551/how-do-i-get-pylint-to-recognize-numpy-members
In that case, it's not the fault of SublimeLinter-pylint ..

$ pylint --version
No config file found, using default configuration
pylint 1.4.3,
astroid 1.3.6, common 0.63.2
Python 2.7.6 (default, Sep  9 2014, 15:04:36)
[GCC 4.2.1 Compatible Apple LLVM 6.0 (clang-600.0.39)]

>>> import numpy
>>> numpy.__version__
'1.9.2'

2 possibilities:

SublimeLinter-pylint uses a global pylint, so that it does not know the content of your virtualenvs, and can't find pylint. To fix that, you can provide paths to the virtualenv site-packages in the sublimelinter settings of pylint.
pylint gives this error even when called manually on the command line. In that case, it is yet another bug of numpy that does not expose its API properly for static analysis ..

I tend to think that it's the last possibility, since I can reproduce it.
Then, sorry, I can't do anything about it ...
You can rely on tips from http://stackoverflow.com/questions/20553551/how-do-i-get-pylint-to-recognize-numpy-members, or add # pylint: disable=E1101 at the end of the import line.


Release 2.2.3

Environment

Nautobot version:
nautobot-circuit-maintenance version:

Proposed Functionality
Release 2.2.3

Use Case
Docs link

done


Removing .gitignore ?

Hi again,
with the aim to have 'clear place' for repeated autocmake testing would it be possible to remove the .gitignore file ?
The commands git clean -f and git pull would clean the table in existing installation for testing. Otherwise one has to remove the entire directory and do git clone to download the 'virgin' autocmake from repo.

Removing .gitignore is not the solution for this problem.
I am not sure what the problem is. But I am sure that you don't need
to clone every time. What exactly is bothering you? Try to solve the reason
not symptoms.

Hi,
to be able to check the developing code effectively, I prefer git pull & subsequent test run. For that one needs to have clean table, with all update/setup generated files erased.
git pull
git clean -f
py.test -v test/test.py

OK but what exactly is the issue that we are trying to solve here?

Easing and improving the software development and testing due to possibility to "Untracked files:", which are hidden otherwise due to .gitignore.

OK but what should be changed or done differently?

Hi,
I wished to remove .gitignore to easy cleaning of all test.py generated files:
milias@login.grid.umb.sk:~/Work/qch/software/software_projects/autocmake_devel/autocmake/.git status .

# On branch master
# Changed but not updated:
#   (use "git add/rm <file>..." to update what will be committed)
#   (use "git checkout -- <file>..." to discard changes in working directory)
#
#       deleted:    .gitignore
#
# Untracked files:
#   (use "git add <file>..." to include in what will be committed)
#
#       test/__pycache__/
#       test/cxx/CMakeLists.txt
#       test/cxx/build-2015-07-14-16-17-21/
#       test/cxx/build-2015-07-17-11-37-15/
#       test/cxx/build-2015-07-30-15-29-47/
#       test/cxx/cmake/lib/
#       test/cxx/cmake/update.py
#       test/cxx/setup.py
#       test/cxx_custom/CMakeLists.txt
#       test/cxx_custom/build-2015-07-30-15-29-39/
#       test/cxx_custom/cmake/lib/
#       test/cxx_custom/cmake/update.py
#       test/cxx_custom/setup.py
#       test/extra_cmake_options/CMakeLists.txt
#       test/extra_cmake_options/build-2015-07-30-15-29-44/
#       test/extra_cmake_options/cmake/lib/
#       test/extra_cmake_options/cmake/update.py
#       test/extra_cmake_options/setup.py
#       test/fc/CMakeLists.txt
#       test/fc/build-2015-07-14-16-17-25/
#       test/fc/build-2015-07-17-11-37-19/
#       test/fc/build-2015-07-30-15-29-51/
#       test/fc/cmake/lib/
#       test/fc/cmake/update.py
#       test/fc/setup.py
#       test/fc_blas/CMakeLists.txt
#       test/fc_blas/build-2015-07-17-11-37-24/
#       test/fc_blas/build-2015-07-30-15-29-56/
#       test/fc_blas/cmake/lib/
#       test/fc_blas/cmake/update.py
#       test/fc_blas/setup.py
no changes added to commit (use "git add" and/or "git commit -a")
milias@login.grid.umb.sk:~/Work/qch/software/software_projects/autocmake_devel/autocmake/.git clean -f -d
Removing test/__pycache__/
Removing test/cxx/CMakeLists.txt
Removing test/cxx/build-2015-07-14-16-17-21/
Removing test/cxx/build-2015-07-17-11-37-15/
Removing test/cxx/build-2015-07-30-15-29-47/
Removing test/cxx/cmake/downloaded/
Removing test/cxx/cmake/lib/
Removing test/cxx/cmake/update.py
Removing test/cxx/setup.py
Removing test/cxx_custom/CMakeLists.txt
Removing test/cxx_custom/build-2015-07-30-15-29-39/
Removing test/cxx_custom/cmake/downloaded/
Removing test/cxx_custom/cmake/lib/
Removing test/cxx_custom/cmake/update.py
Removing test/cxx_custom/setup.py
Removing test/extra_cmake_options/CMakeLists.txt
Removing test/extra_cmake_options/build-2015-07-30-15-29-44/
Removing test/extra_cmake_options/cmake/downloaded/
Removing test/extra_cmake_options/cmake/lib/
Removing test/extra_cmake_options/cmake/update.py
Removing test/extra_cmake_options/setup.py
Removing test/fc/CMakeLists.txt
Removing test/fc/build-2015-07-14-16-17-25/
Removing test/fc/build-2015-07-17-11-37-19/
Removing test/fc/build-2015-07-30-15-29-51/
Removing test/fc/cmake/downloaded/
Removing test/fc/cmake/lib/
Removing test/fc/cmake/update.py
Removing test/fc/setup.py
Removing test/fc_blas/CMakeLists.txt
Removing test/fc_blas/build-2015-07-17-11-37-24/
Removing test/fc_blas/build-2015-07-30-15-29-56/
Removing test/fc_blas/cmake/downloaded/
Removing test/fc_blas/cmake/lib/
Removing test/fc_blas/cmake/update.py
Removing test/fc_blas/setup.py
milias@login.grid.umb.sk:~/Work/qch/software/software_projects/autocmake_devel/autocmake/.git status
# On branch master
# Changed but not updated:
#   (use "git add/rm <file>..." to update what will be committed)
#   (use "git checkout -- <file>..." to discard changes in working directory)
#
#       deleted:    .gitignore
#
no changes added to commit (use "git add" and/or "git commit -a")
milias@login.grid.umb.sk:~/Work/qch/software/software_projects/autocmake_devel/autocmake/.py.test -v test/test.py
====================================================== test session starts ======================================================
platform linux2 -- Python 2.6.6 -- py-1.4.28 -- pytest-2.7.1 -- /usr/bin/python
rootdir: /home/milias/Work/qch/software/software_projects/autocmake_devel/autocmake/test, inifile:
collected 5 items

test/test.py::test_cxx_custom PASSED
test/test.py::test_extra_cmake_options PASSED
test/test.py::test_cxx PASSED
test/test.py::test_fc PASSED
test/test.py::test_fc_blas PASSED

=================================================== 5 passed in 21.82 seconds ===================================================
milias@login.grid.umb.sk:~/Work/qch/software/software_projects/autocmake_devel/autocmake/.

But there is the git command for that as I have found, so we can keep the .gitignore :
.
# do py.test -v test/test.py
# clean all generated files:
milias@login.grid.umb.sk:~/Work/qch/software/software_projects/autocmake_devel/autocmake/.git clean -X -f -d
Removing test/__pycache__/
Removing test/cxx/CMakeLists.txt
Removing test/cxx/build-2015-07-31-09-27-23/
Removing test/cxx/cmake/downloaded/
Removing test/cxx/cmake/lib/
Removing test/cxx/cmake/update.py
Removing test/cxx/setup.py
Removing test/cxx_custom/CMakeLists.txt
Removing test/cxx_custom/build-2015-07-31-09-27-14/
Removing test/cxx_custom/cmake/downloaded/
Removing test/cxx_custom/cmake/lib/
Removing test/cxx_custom/cmake/update.py
Removing test/cxx_custom/setup.py
Removing test/extra_cmake_options/CMakeLists.txt
Removing test/extra_cmake_options/build-2015-07-31-09-27-19/
Removing test/extra_cmake_options/cmake/downloaded/
Removing test/extra_cmake_options/cmake/lib/
Removing test/extra_cmake_options/cmake/update.py
Removing test/extra_cmake_options/setup.py
Removing test/fc/CMakeLists.txt
Removing test/fc/build-2015-07-31-09-27-26/
Removing test/fc/cmake/downloaded/
Removing test/fc/cmake/lib/
Removing test/fc/cmake/update.py
Removing test/fc/setup.py
Removing test/fc_blas/CMakeLists.txt
Removing test/fc_blas/build-2015-07-31-09-27-31/
Removing test/fc_blas/cmake/downloaded/
Removing test/fc_blas/cmake/lib/
Removing test/fc_blas/cmake/update.py
Removing test/fc_blas/setup.py
milias@login.grid.umb.sk:~/Work/qch/software/software_projects/autocmake_devel/autocmake/.git status
# On branch master
nothing to commit (working directory clean)
milias@login.grid.umb.sk:~/Work/qch/software/software_projects/autocmake_devel/autocmake/.

Closing this issue as solved - the solution is "git clean -X -f -d".

Assuming that you have no unstaged local modifications in test/, you
can delete them like this:
git status test  # better double-check that there is nothing unstaged
rm -rf test
git checkout test


Add solution for The Levenshtein distance

Hi, I can provide code for this problem in C++. Could you please assign this issue to me?

@sneaky-potato Done it! Thank you very much.
And please take a look at the contribution guideline first :)


Updated Network Section of ReadMe

Updated readme to describe the current approach to creating network policies and include information on how DNS intents are resolved.

Replaced with PR#418


Rename test .c sources to .cpp where necessary

Remove hacks to force language from CMake files.
Closes KhronosGroup/OpenCL-CTS#25

Rebased and now tested on Linux, macOS and Windows (added some more renames for macOS/Windows as necessary).

This now needs rebasing.

Rebased.


WIP: patrick-trim-capture-proton

This PR repairs trimmed capture of workloads utilizing VKD3D/Proton as reported in issue #551 .
This is achieved by improving trimmed capture handling the extensions VK_KHR_create_renderpass2 and VK_KHR_push_descriptor.

CI gfxreconstruct build queued with queue ID 10041.

CI gfxreconstruct build # 1133 running.

CI gfxreconstruct build # 1133 failed.

CI gfxreconstruct build queued with queue ID 10065.

CI gfxreconstruct build # 1134 running.

CI gfxreconstruct build queued with queue ID 10075.

CI gfxreconstruct build # 1135 running.

CI gfxreconstruct build # 1135 failed.

CI gfxreconstruct build queued with queue ID 10462.

CI gfxreconstruct build # 1136 running.

CI gfxreconstruct build # 1136 passed.

CI gfxreconstruct build queued with queue ID 10811.

CI gfxreconstruct build # 1139 running.

CI gfxreconstruct build # 1139 passed.

CI gfxreconstruct-extended build queued with queue ID 10908.

CI gfxreconstruct-extended build # 18 running.

CI gfxreconstruct-extended build # 18 passed.

CI gfxreconstruct build queued with queue ID 14500.

CI gfxreconstruct build # 1160 running.

CI gfxreconstruct build queued with queue ID 14518.

CI gfxreconstruct build queued with queue ID 14520.

CI gfxreconstruct build # 1162 running.

CI gfxreconstruct build # 1162 passed.


Add fixes to allow files over 2GB to be uploaded

Change the UploadHandler.php file to fix two issues:
Change the value used to fix the overflow from PHP_INT_MAX to the size of a
32 bit integer.  Due to this fix, we also only check the value of the size
via '==' instead of the type and value of size '==='.
This change will likely require updates to the php.ini of the webserver
where the OTJ is running. Update the values of the PHP variables listed below
with the recommended value:
upload_max_filesize: 4096M
post_max_size: 4096M
max_input_time: 10800
max_execution_time: 10800

:+1: Nice
@jamiesnape @cpatrick  Out of curiosity, does this apply to midasplatform/Midas ? Looking at the code base I couldn't find UploadHandler.php

midasplatform/Midas has not had a file size limit at all for quite a while.

Great.


Windows Walker should have text focus on activation

Summary of the new feature/enhancement
When activating Windows Walker through Ctrl+Win, the input field should have focus so that one can start typing immediately. Currently, one needs to click it with the mouse or hit Tab once.
Proposed technical implementation details (optional)
Set the focus() property on activation.

Hi @tchara
I've tried on a couple of different PCs and on both Window Walker has the focus active and you can type right away.
Can you verify if the problem you are seeing is persistent?
Thanks.

It happens when I have the focus in Outlook (365 v20.03), but I cannot pinpoint a reproducible behaviour.
Sometimes, it consistently refuses to set the focus in Window Walker when I am in the e-mail list. Other times it just works fine.
The same is oddly the case with editing calendar items. Sometimes the focus remains outside Windows Walker, sometimes it does not.
Based on this behaviour, I presume Outlook somehow snatches/hijacks the focus?

On my machine the text focus only works on the first try.
If you find an application, switch to it then activate the feature again the text box will not automatically have focus until you press tab/select with the mouse.

i think it is slightly inconsistent.  I've seen this a bit too.  @betsegaw any ideas?

I haven't run into this yet. Back in the day, there used to be some issues with focus, specifically on launch (after a reboot). I will assign it to myself and take a look.

Oh wait.. already assigned 👍

Okay.. so I got one repro and maybe a fix for this will also fix the other ones.

CTRL + WIN
a
Using your mouse, click on the app to switch to
CTRL + Win

Result : Focus is nowhere to be seen... @tchara, did you use the mouse to select the result at any point?

The change I applied will hopefully fix the more general case as well. Please do ping back if it doesn't.

Okay.. so I got one repro and maybe a fix for this will also fix the other ones.

CTRL + WIN
a
Using your mouse, click on the app to switch to
CTRL + Win

Result : Focus is nowhere to be seen...
@tchara, did you use the mouse to select the result at any point?

Now that you mention it, yes. If I am near the item with the mouse I just click it rather than using the keyboard.

For me it consistently doesn't work.

Hi @runxel
we have a fix ready, it will be included in the 0.16.1 release.


Add/edit pages you own

How can I give permissions to add/edit pages you own to a group on the most recent versions of wagtail?
I think this option disappeared in one of the last releases.

Hi @EduardoNogueira - please use the Wagtail support Google group for support queries.
This option is still available as the 'Add' column under 'Page permissions' - there wasn't space for the full label in the new layout.

Tks for the answer! @gasman


feat: Background Color

It would be nice if we could be able to set a background color for the WhatsNew view. I'll probably open a pull request for this over the weekend. :)

Glad to see it. 😉

Hello. I noticed that you are using android-gradle-plugin version 3.5.0-alpha04 which is only available in canary  version of android studio. I've lowered it to 3.3.2, I hope that's okay?

That's fine 😉.
On Tue, Apr 9, 2019 at 20:10 Michael Bukachi<EMAIL_ADDRESS>wrote:

Hello. I noticed that you are using android-gradle-plugin version
3.5.0-alpha04 which is only available in canary version of android
studio. I've lowered it to 3.3.2, I hope that's okay?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/TonnyL/WhatsNew/issues/11#issuecomment-481224732, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AMti_AclwV8sNf9p-_PlLweamytk1Mgzks5vfIM6gaJpZM4cgGNe
.

In my opinion, backgroundColorResource should call backgroundColor internally.

With the current implementation, backgroundColorResource receives a resource integer instead of a color integer. That implementation will have to change for more flexibility.


Provide a way to update timoni package

At the moment, Timoni uses the timoni.sh/core/v1alpha1 definitions from the template that is pulled when timoni mod init is run. The problem is that this doesn't allow easy upgrading of the definitions when changes are made in this repository.
This is more of a tracking issue because I suspect it's not worth solving until the CUE modules work is done. They are currently holding feedback sessions for the related development. At a certain point, when we feel things are stable enough, we should switch to using the new implementation so that (hopefully) upgrades are possible in the future.

Here are the docs for keep them up to date: https://github.com/stefanprodan/timoni/tree/main/schemas#vendoring
I need to add these to the docs website.

I wasn't even aware of the timoni artifact subcommand :) I guess this changes the question: do you forsee there being value in switching over to using modules for managing this once development is complete?

The timoni artifact commands are more for sharing bundle files, which may not necessary be CUE.
When CUE adds support for modules, then we'll publish the Timoni's schemas as a module so it can be updated with cue.  Right now you can abuse 😄 the timoni artifact commands to manage cue.mod, I see no reason to do that when cue will have this capability.


:ok_hand: Expanding the list of required values in the LammpsPotentialData

It has been brought to my attention that the author of the potential, the year and title should be required entries to ensure that the potential is easier to track. These keywords should be set in the required attributes of the LammpsPotentialData type.

After some discussion it was decided that this is not needed, and that having them as extras is enough.


chore: bdd-spring-1584980816 to 0.0.1

chore: Promote bdd-spring-1584980816 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


[2.3] Update to json-schema 0.40.0

https://github.com/open-cluster-management/backlog/issues/18101

/test e2e-cluster

/cc @fxiang1


fix(data-table): add a width to the expand icon container

Closes #1260
Changelog
New

added width to icon expand container to prevent slight width change on rows when expanding.

Testing / Reviewing
Check dev environment is not broken.
Check DataTableV2 expandable

I'm still seeing a jump in the width by 1px. Looking at what else might be causing it.


Face Recognition new design

Recreate all FR new design changes + tests.

@sirpy tests are fixed.


Ensure date functions in Hive VIEW are considered to have right return type

According to https://cwiki.apache.org/confluence/display/Hive/LanguageManual+UDF the return type of date_add changed

pre 2.1.0: string
2.1.0 on: date

since we cannot be compatible with both, we should be compatible with the newer hive version.
same applies to date_sub, to_date

Requires https://github.com/prestosql/presto/issues/5978


Add fields to nodeDriverStatus

Problem:
Nodedrivers don't hold info on what has been applied
Solution:
Add applied fields

lgtm


Integration with docker-compose that has java application

Hi guys.
Do you know how to integration datadog-agent with docker-compose that has java application ?

@PertQin You may want to find examples online that use the agent:<version>-jmx docker image. According to DataDog:

This variant embeds a Java Runtime Environment for JMX-based checks. If you are uncertain about what your needs are, this is probably the one you should use.

That might point you in the right direction when it comes to using the agent with a Java application.


[main] Add Konflux configurations

Add Konflux components and pipelines

/lgtm

@creydr Do we need to apply this manually in Gitlab?

@creydr Do we need to apply this manually in Gitlab?

We need to manually copy them (for now) to gitlab. I'll do it...

@creydr Thanks!

@mgencur: https://gitlab.cee.redhat.com/releng/konflux-release-data/-/merge_requests/2774


Document methodology

The details of each layer, importing from OSM, and the metrics are all interesting. As the dust settles on some of these, write them up clearly. Maybe two levels of detail, for both a user manual and a more technical audience.

Example detail: to determine if different destinations are reachable, we snap to the nearest road (or roads, for areas like town centres). If that road happens to be a severance, then the only way for it to be considered reachable is for a route with appropriate infrastructure to edit that road.


How to set setOnItemClickListener

How to set setOnItemClickListener on PullLoadView ?
Thanks

//get RecyclerView
RecyclerView mRecyclerView = mPullToLoadView.getRecyclerView();
then as same as use RecyclerView


Use exportDefault

@alfonsogarciacaro If you build this version of the REPL you will see my problem with the ExportDefault not working.
If you can help me fix it inside this PR would be awesome :)

Hmm, not sure what's happening. There was a problem with the module names in the Editor project but that didn't fix that. I also tried changing the name exports in case it caused a conflict with Webpack but that wasn't the solution either. Finally I just solved by adding directly a project reference :/

Yes this is really strange because, when I tried to access editor in the global scope in the browser. I didn't saw the editor.defaults or editor.exports like if webpack or fable was erasing this variable.
But I was able to see editor.create, editor.parseEditor, etc. as Fable export by default everything. I don't really understand neither. Should we use the project reference so ? Only, problem is it's will probably make webpack bundling slower (more files to bundle etc.).

I don't know either, I'll try to investigate later. Anyway, yes, for this case a project reference (or maybe just a single project) should be enough. There are not many more files than a medium size Fable app. I think I made the structure like this at the beginning because I was thinking in making the editor a component that could be embedded in any other web, but we can deal with that later :+1:

I am closing this PR because, the change have already been included in the new repl


Revert "feat(topology): Add topology to dsp and migrate to v1beta2"

All E2E were failing as E2E framework doesn't support v1beta2 for now. This Pr had breaking change as it introduces a new Diskpool version.
Reverting this until things are fixed.
Reverts openebs/mayastor-control-plane#701

Clsoing this PR as the e2e changes are made and merged


[SSoC'23] Graphs_bfs

Graphs Adjacency List implementation for Generic Data.

@Kumar-laxmi assign this to me.

I can implement BFS on graph by the help of queue. A visited boolean array will be marked as false for all the elements. Then proceeding from a node, it will be printed and it will be marked as true in visited array. After that, until the queue is empty, the front element of queue will be dequeued and if there is a node between any node and this node, then those node will be added to queue and the procedure will be repeated.
Kindly assign me this issue, I can implement this.


[embedded] Use atomic load/store/rmw in embedded runtime refcounting implementation

This is supposed to implement refcounting in the embedded Swift runtime in a threads-safe way, i.e. all loads and modifications are done via atomic builtins.

@swift-ci please test


remove scala-library from combined tools jar

Fixes https://github.com/NVIDIA/spark-rapids/issues/4454
build was reporting a shade warnings when building the tools artifact
[WARNING] rapids-4-spark-tools_2.12-22.02.0-SNAPSHOT.jar, scala-library-2.12.15.jar define 1 overlapping resource:
[WARNING]   - META-INF/MANIFEST.MF
[WARNING] maven-shade-plugin has detected that some class files are

I did some testing and it doesn't look like we need to include the scala-library in the combined tools jar.  For the tools the user has to include the jars directory for Spark so we can pick up the scala library from there. I tested against a bunch of different spark versions from 3.0.1 and up and it ran fine.

build


Collision radius does not scale with stretch

Need to send update to sphere-collider
maybe emit event for other colliders to respond
maybe move physics body resizing to physics-collider

sphere-collider cannot respond to scale changes


windows_run_count ignores freq when ufunc_1dim=True

Setup Information

Xclim version: 0.40.0
Python version: 3.10
Operating System: Ubuntu 22.04

Description
When ufunc_1d is selected, windows_run_count outputs the total number of contributions to a run, regardless of whether or not freq is specified
Steps To Reproduce
import xarray as xr
import xclim

def bug_windowed_run_count():
    da = xr.DataArray([False] * 730, dims=['time'], coords={'time': xr.date_range('2001-01-01', '2002-12-31')})
    da[10:20] = True  # 10 days in 2001
    da[400:420] = True  # 20 days in 2002
    wrc = xclim.indices.run_length.windowed_run_count(da, window=3, freq='YS')

    # expected [10, 20]
    # actual 30
    return wrc

Additional context
It looks like it's a minor logic error in windowed_run_count(), where resampling doesn't happen if ufunc_1dim == True
    if ufunc_1dim:
        out = windowed_run_count_ufunc(da, window, dim)

    elif window == 1 and freq is None:
        out = da.sum(dim=dim)

    else:
        d = rle(da, dim=dim, index=index)
        d = d.where(d >= window, 0)
        if freq is not None:
            d = d.resample({dim: freq})
        out = d.sum(dim=dim)

Contribution

[ ] I would be willing/able to open a Pull Request to address this bug.

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Thanks for reporting this.
The bug
The behaviour was intended, but you were not notified about it because there's an error in the code. In  windowed_run_count, we currently have:
ufunc_1dim = use_ufunc(ufunc_1dim, da, dim=dim, index=index)

but there should be an extra argument freq=freq. The combination ufunc_1dim==True and a defined freq (not None) would raise a value error in use_ufunc, stating that

Resampling after run length operations is not implemented for 1d method

A possible computation with the current xclim
To get a similar behaviour to what you want, you can first resample your data, then map to the function windowed_run_count:
from xclim import run_length as rl
window = 3
freq = "YS"
da.resample(time=freq).map(rl.windowed_run_count, [window], ufunc_1dim=True)

or simply use the function resample_and_rl with resample_before_rl=True. This function is in run_length.py. Many indices use this function, for instance maximum_consecutive_wet_days in `_threshold.py.
This can lead to differences however, because resampling is done before the windowed_run_count.
To enhance or not
Why not implement resample_before_rl=False for the 1d version too?
The 1d version of run_length and windowed_run_count in this case was a workaround to alleviate some performance issues (in some specific cases) of regular multi-dimensional algorithms using xarray. Those issues were solved in #1134 , which allowed the new behaviour, i.e. resample after using run length introduced in #1136. This new feature was not implemented to the 1d algorithm because as far as I could tell, performance benefits of the 1d version algorithm in some specific were now marginal or non-existent.
If you still have performance justifications to keep using the 1d algorithm, I'd be interested to know more about it!


Some multi-record forms can have different visit columns in different Row#

flatten_multi_records.py needs revision

Replaced by flatten_multi_records_1.py.


Unresolved requirement: Import-Package: com.liferay.osgi.util; version="[2.0.0,3.0.0)"

I am building Gradle ServiceBuilder API example, and deploying it, and I have this error:
C:\java\git\tdf\tdf.api>blade deploy -p 12345 build\libs\tdf.api-1.0.0.jar
Error
   0. [MBeanIntrospector.unwrapInvocationTargetException] java.io.IOException: Start of bundle with id 376 failed with message: Could not resolve module: tdf.api [376]
   Unresolved requirement: Import-Package: com.liferay.osgi.util; version="[2.0.0,3.0.0)"

I am using Liferay nightly build from January 05, 2016.
Felix console shows it "installed" (instead of "active").

Hi Fuad , can you send your code to my email or you can upload it to https://dev.liferay.com/web/liferay-7-community-expedition/feedback/-/message_boards/category/514265 so I can check it more , thanks !

Hi Andy, it is absolutely the same code as in "blade.servicebuilder.api"; the only difference: it is renamed & regenerated. Please try to regenerate & rebuild & deploy standard "blade.servicebuilder.api" (I'll do the same too)

HI Andy,
I tried to 'clean', 'buildService', 'build', and finally 'blade deploy' of the standard Gradle-based example of Service Builder, and I cannot deploy "api" module:
$ blade deploy -p 12345 build/libs/blade.servicebuilder.api-1.0.0.jar
Error
0. [MBeanIntrospector.unwrapInvocationTargetException] java.io.IOException: Start of bundle with id 378 failed with message: Could not resolve module: blade.servicebuilder.api [378]
Unresolved requirement: Import-Package: com.liferay.osgi.util; version="[2.0.0,3.0.0)"
I am using Liferay Nightly build from January 05 2016. I believe something wrong with Liferay: OSGi package "com.liferay.osgi.util" is not properly deployed. Thanks,

@FuadEfendi in your running portal can you login to the gogo shell telnet localhost 11311 and run the command packages com.liferay.osgi.util and paste the full report here?

g! packages com.liferay.osgi.util
No exported packages
g!

it looks like you are missing the bundle
https://repository.liferay.com/nexus/content/groups/public/com/liferay/com.liferay.osgi.util/2.0.4/
can you install that one and see if it resolves the issue?

Thank you very much Raymond!
Installed; and "blade.servicebuilder.api" became instantly active (without reinstalling):
378|Active     |    1|blade.servicebuilder.api (<IP_ADDRESS>601081639)
379|Active     |    1|Liferay OSGi Utilities (2.0.4)


SPARK-11760 - Fix getSeconds() to use the timezone

Can one of the admins verify this patch?

A fix has already been applied.


Text field is not adjusted when information is selected in Knowledge Base

Issue
When you select information from the Knowledge Base, it is pasted in the text field. However, the size of the text field does not automatically adjust to the size of the text that is pasted from the Knowledge Base. The size gets adjusted when you click in the text field and navigate in it.
Solution
Adjust the size of the text field after selecting information from the Knowledge Base so that the whole text is visible in the text field.

Duplicate? https://github.com/mrsimpson/Rocket.Chat/issues/63

@janrudolph this is not a duplication.
#63 says that the knowledge base tab bar does not appear wehen selecting a reuqest
#74 says that the message field is not expanding, when a suggestion has been selected from the knowledge base.
I think this issue could have been solved by #62, since the expansion of the message box is most probably triggered by the same event the send icon is being triggered.
So we should test, if this issue still persists.

Moved to: https://github.com/assistify/Rocket.Chat/issues/51
@andytipp please close


Add a special case for /31 networks to openvpn_get_interface_ip() (another instance of #2529)

Finally, I've fixed it in the place where I originally intended to fix it (#2529).
This time I've verified that it works, thanks to people on the IRC who explained me how to restart the web GUI properly.

Merged, thanks!


Some problems when training on PCN

When data goes trough PCN network, it comes out the error 'Out of Memory'. And this error is located at class 'global_network', 'out = out.repeat(1, 1, int(self.image_size / n), int(self.image_size / n))' in PCN.py. Do you mean convert the feature with size [1, 512, 256, 256] to a feature [1, 512, 32, 32] in 'global512' block? Why don't you use upsampling method?

I changed the 'global_network' in PCN.py to let PCN network work and counted the total 'd_loss' and 'g_loss' for each epoch. But 'd_loss' didn't change since iteration 16 and 'g_loss' changed very very tiny. Any idea to fix this problem?

Hi, I also met this question "cuda out of memory" when trainning PCN. Have you solved this problem? And could you share  how did you change the 'global_network' to make it work to me?

Hi, I also met this question "cuda out of memory" when trainning PCN. Have you solved this problem? And could you share how did you change the 'global_network' to make it work to me?

I commented the code 'out = out.repeat(1, 1, int(self.image_size / n), int(self.image_size / n))' and change the definition of convolution layer 'self.twoD', 'self.threeD' , 'self.fourD' in global_network, to apply the size of the output of 'conv4', 'conv8', 'conv9'.
Hope it would help you.

Hi, I also met this question "cuda out of memory" when trainning PCN. Have you solved this problem? And could you share how did you change the 'global_network' to make it work to me?

I commented the code 'out = out.repeat(1, 1, int(self.image_size / n), int(self.image_size / n))' and change the definition of convolution layer 'self.twoD', 'self.threeD' , 'self.fourD' in global_network, to apply the size of the output of 'conv4', 'conv8', 'conv9'.
Hope it would help you.

Thanks for your reply.
I have changed the code in the way similar to your recommendation,  but the d_loss and g_loss  almost unchanged after few iteration same as your description.
Have fixed it?

Hi, I also met this question "cuda out of memory" when trainning PCN. Have you solved this problem? And could you share how did you change the 'global_network' to make it work to me?

I commented the code 'out = out.repeat(1, 1, int(self.image_size / n), int(self.image_size / n))' and change the definition of convolution layer 'self.twoD', 'self.threeD' , 'self.fourD' in global_network, to apply the size of the output of 'conv4', 'conv8', 'conv9'.
Hope it would help you.

Thanks for your reply.
I have changed the code in the way similar to your recommendation, but the d_loss and g_loss almost unchanged after few iteration same as your description.
Have you fixed it?

Not yet. So I am wondering if something wrong in this part...

@leejingbei change the definition of convolution layer 'self.twoD', 'self.threeD' , 'self.fourD' in global_network, to apply the size of the output of 'conv4', 'conv8', 'conv9'.how to do this

嗨，我在训练PCN时也遇到了“ CUDA内存不足”这个问题。你解决了这个问题吗？您能否分享您如何更改“ global_network”以使其对我有用？

我注释了代码'out = out.repeat（1，1，int（self.image_size / n），int（self.image_size / n））'并更改了卷积层'self.twoD'，'self的定义。 global_network中的threeD'和'self.fourD'，以应用'conv4'，'conv8'，'conv9'的输出大小。
希望对您有帮助。

感谢您的回复。
我已经按照与您的建议类似的方式更改了代码，但是经过几次迭代后，与您的描述相同，d_loss和g_loss几乎没有变化。
你修好了吗？

还没。所以我想知道这部分是否有问题...

HI ,Have you fixed this problem now?

嗨，我在训练PCN时也遇到了“ CUDA内存不足”这个问题。你解决了这个问题吗？您能否分享您如何更改“ global_network”以使其对我有用？

我注释了代码'out = out.repeat（1，1，int（self.image_size / n），int（self.image_size / n））'并更改了卷积层'self.twoD'，'self的定义。 global_network中的threeD'和'self.fourD'，以应用'conv4'，'conv8'，'conv9'的输出大小。
希望对您有帮助。

感谢您的回复。
我已经按照与您的建议类似的方式更改了代码，但是经过几次迭代后，与您的描述相同，d_loss和g_loss几乎没有变化。
你修好了吗？

还没。所以我想知道这部分是否有问题...

HI ,Have you fixed this problem now?

i have fixed this problem。

i have fixed this problem。

How??

Hi, How can I solve the problem?

UserWarning: Using a target size (torch.Size([32])) that is different to the input size (torch.Size([32,])) is deprecates.
RuntimeError: CUDA error: out of memory

i have fixed this problem。

How did yo fix it ??

i have fixed this problem。

How did yo fix it ??

Did you fix that and i had the same problem as you

hey guys, is there an official solution to this?


Feature Request: Binary Bitshift operator

One thing that would be really nice would be a bitshift operation. One that could go either direction using only bitshift and bitwise operators, no arithmatic, if possible. For doubling and halfing values the speed should be a lot faster than times or divide, I'm guessing. Times is already faster than divide, but this would probably be even faster.

There is already a shift method, but it just uses times under the hood. (I notice that the shift method is currently missing from the API image in the README.)
The value of a Bignumber is not stored internally in a binary or power of two form so it is not really feasible to use bitwise operations.

When I open Google Chrome's console and type in new BigNumber('7854923758493275894032758940327589403278590437285428832'), and then inspect the result, the coefficient array appears to be an array of integers.
I did, however, try it, and it appears that the integers are bigger than what the bit shift operator can handle. They would probably have to be modified.

I'm not clear if we are talking about the internal optimisation of the library or about adding bitwise methods to the API.
Regarding the latter, most decimal values with digits after the decimal point cannot be represented in binary, so that's a non-starter.
As for the internal optimisation for the library, there would almost cetainly be no performance improvement at all in replacing for example * with << for power of two multiplications. Bitwise operations may actually be slower if a JS number first needs to be first converted to a 32 bit integer. And regardless, the speed of native arithmetic is not a significant factor in the performance of the library.

The code I am trying to optimize is c = a.plus(b).times(0.5).floor();, which is part of a Binary Search Division operation to return p mod m. Now, I may well be picking at tiny problems, and this may not be the most efficient division operation. A long division implementation I made is actually faster.
var p = new BigNumber(divisor), m = new BigNumber(dividend), a = new BigNumber(0), b = p;
var c,d;  // c will contain the quotient
while(true){

    c = a.plus(b).times(0.5).floor(); //avg 7,000 nanoseconds
    d = m.times(c); //avg 2,500 ns

    if(d.lt(pm1)) a = c;
    else if (d.gt(p)) b = c;
    else return p.minus(d); //return p mod m
}

At first glance I don't see any obvious optimisations to be made and I don't have time to analyse further.
Good luck.


Basic Installation Help

About 2 months ago I discovered Home Assistant, and installed HA OS on a RaspberryPi.
My initial interest was to enable Energy monitoring including a Solax battery, and a Growatt PV array.
I was amazed the ease with which I installed the Growatt integration for PV data, and then used the Solax X1 Hybrid G4 Worked Example as a base for getting Battery data. All was going well ... then the PV data became unavailable.
I eventually found it caused was Growatt, not me, and I have been trying to follow the many scattered posts about the problem and possible solutions.
I found muppet3000 / homeassistant-grott and tried to follow the ReadMe. HACS I had, so on to Prerequisites and then to Grott. I do not have Docker, so had to try the Python Application install.
However, it is not clear (to me) where I download the Repository, or where to use the sudo command - and I have read around! Note that I am not familiar with Linux, apart from following the simple instructions to install PiHole on another RPi.
Please can someone clarify how to to this on HAOS?
Some of the following instructions look complex, and further help may be required.
Thanks for any help.

I know what you mean. I am a retired Unix/DBA sysadmin and have a really hard time to follow these children. They assume a lot.  As a Sysadmin I ve had a few moments with developers, they didn't care about security , clarifying, documenting or cleaning up. BUT, I AM GRATEFULL THESE PEOPLE DO THIS FOR FREE!!!
To answer your questions a little bit:

sudo is needed to run commands as root. If you are already root, don' t use it. (issue the command "id" to see if you are root)
to download a repository from github you need to setup github or use the command line with wget or curl command.
you can find the files at the alternate link(otherwise you end up with an index.html like i did, github in browser is a webpage not a file host
"cd /config/custom_components" --> to where ever you need to be and then use wget , but adjust the webbrowser :
https://raw.githubusercontent.com and leave out the "blob"
"wget https://raw.githubusercontent.com/johanmeijer/grott/master/grott.service" par example.

I wish you all the best in finding a complete "hit the keyboard with my head" tutorial. I couldn't. I almost gave up.

Thanks CK0y0TE ... but (as a retired DBA myself!) even you have assumed that I know how to get to a command prompt on HAOS - note I am not familiar with Unix/Linux.

LOL.  Well, there is an addon that gives you terminal acces within Home assistant
Goto Settings-> Addons-> bottom right "Addon Store" search for "ssh" or "web terminal".
That is all with the mouse...
You were DBA for Oracle/mysql?

Ahah! Thanks - that was the vital clue. Now installed - will try to use it later.
I was IBM & MVS based for 40 years - including a lot of work with CICS and DB2.

Tried to use Terminal - cd command worked (though not sure if it should be just as you suggested), then tried wget you suggested, which downloaded just the grott.service file. That on its own did not seem right, so (eventually) managed to delete it using File Editor!
Your suggestions to 'find the files', 'alternate link', 'adjust web browser' & 'blob' mean nothing to me, sorry.
Using wget, how do I download all the required files?

Hi guys, DevOps team lead here (read: Sysadmin turned Linux bash hacker turned semi-python developer turned CI/CD specialist turned manager because I can't keep up with the rate of change but damn can I herd cats!).
One of the things on my list is to improve the documentation for this integration and in doing so also how to install the prerequisites.
If you're using Home Assistant OS then there's a much simpler option to get Grott up and running and that's by installing the Grott 'add-on', if you Google for 'egguy Grott addon' you should be able to find it pretty easily. There are a couple of extra bits to consider if you want to use it with this integration (which I recommend because this integration formats all the information so you can use it with the energy dashboards etc). I'll find the steps for that and provide another comment when I have them (they're on another ticket and I'm on my phone so they're not easy to track down).
I'm currently away on holiday for a week but I'll try and assist where I can.

The extra thing to do is when you're installing that add-on is to tweak the options show on this image: #16 (comment)
You need to enable "Enable Grott MQTT" option and to disable the "Home Assistant plugin" option. After that my integration should then be able to be installed and make use of the data being pushed into MQTT from grott.
If you have any problems let me know, I'd love to get some feedback from a 'beginner' (bonus points for screengrabs) so that I can update the documentation.

dont forget that we need a clone of the files in the custom_components folder:
"cd /config/custom_compoinents"
"git clone https://github.com/johanmeijer/grott.git"
Also I just figured out why it didnt work for me the first time. As it apears, I just could'nt get grott to use the username/passwd for mosquitto. Since auth was on in grott and mosquitto one has to know where to adjust things (and reload). I hope I am right. Still stumbling

Tried to use Terminal - cd command worked (though not sure if it should be just as you suggested), then tried wget you suggested, which downloaded just the grott.service file. That on its own did not seem right, so (eventually) managed to delete it using File Editor! Your suggestions to 'find the files', 'alternate link', 'adjust web browser' & 'blob' mean nothing to me, sorry. Using wget, how do I download all the required files?

Never mind, I asked one of my sons, see comment above

Great!
Thank you for the attention
Please dont forget that we need a clone of the files in the custom_components folder:
"cd /config/custom_components"
"git clone https://github.com/johanmeijer/grott.git"
Also I just figured out why it didnt work for me the first time. As it apears, I just could'nt get grott to use the username/passwd for mosquitto. Since auth was on in grott and mosquitto , ... one has to know where to adjust things (and reload). I hope I am right. Still stumbling
We can copy these commands and in the webterminal , by holding "shift"+"right-click mouse" issue paste

No you don't need to do this at all. If you use the egguy HA OS addon it handles all this for you, it essentially wraps Grott into a handy package so you're running it as part of home assistant.

Great!
Thank you for the attention
Please dont forget that we need a clone of the files in the custom_components folder:
"cd /config/custom_components"
"git clone https://github.com/johanmeijer/grott.git"
Also I just figured out why it didnt work for me the first time. As it apears, I just could'nt get grott to use the username/passwd for mosquitto. Since auth was on in grott and mosquitto , ... one has to know where to adjust things (and reload). I hope I am right. Still stumbling
We can copy these commands and in the webterminal , by holding "shift"+"right-click mouse" issue paste

No you don't need to do this at all. If you use the egguy HA OS addon it handles all this for you, it essentially wraps Grott into a handy package so you're running it as part of home assistant.

Yes a read that, but I have 2 extra mosquitto devices now that do work (nous a1t smart power outlets). How do I know those will still function. I am a noob afterall and once things work I tend to continue. I will be watching things closely. eguyy too has some missing things in the docu.
cheers to you for your commitment!

MQTT is a message broker so it's just a big queue of messages coming in and then integrations consume only from the topics that they know about. In short: asking more days to MQTT won't affect your existing integration, if it does: just stop the Grott add-on.

@Muppet3000: Some progress: I installed the Grott addon, enabled Grott MQTT, disabled HA plugin and restarted HA.
However, when trying to start Grott, there is an error logged:
Got unexpected response from the API: Service not enabled
It seems there is some Grott setup that is not in the Configuration. I will follow the Grott docs to do that.
Do I have to copy the Configuration file and change it, or is that included in the Grott addon?
There also is the DataLogger setup - I have tried to connect to my Dongle, but it times out - possibly because it has give inactive after dusk, so I will try again tomorrow.

I have hit a snag. Now the PV is active I tried to connect to the datalogger at its IP of <IP_ADDRESS>, but I get Connection Refused error, whatever browser I try. Using a port scanner it seems there are NO open ports, but I can see no reason in the router that would stop me accessing it.
The datalogger is a ShineWifi-X and the Inverter is a MIN 5000TL-XE.
Any suggestions?

I have just found suggestions how to use web interface to set the IP which I will try.

After discovering that I should be able to set the datalogger IP using the web page, I have reverted to trying to follow the pre-requisite instructions, specifically Grott. As I have installed Grott as an addon, does that mean I can ignore Python Application steps 2, 3 & 4? How can I check Grott is now running as a service?
If I need to do any of steps 2, 3 or 4, I tried using sudo in the Terminal addon ... but it just responded bash: sudo: command not found. What on earth is bash? It seems to be a scripting language rather than a normal terminal.
I then tried to follow the Configuration section. I found grott/examples/grott.ini, updated it, and saved it over a blank file I found in my config/grott/grott.ini. Is that the correct place?
The Summary page says I should now have a running Grott server - how do I prove that before I try to update the datalogger IP? I do not want to lose any stats sent to the growatt server!
I also had a look ahead at MQTT installation, but got lost when referred to mosquitto.org with no indication how to install on HAOS!
I feel I am computer literate, but this is all bloody confusing, and I am losing hope.

I have hit a snag. Now the PV is active I tried to connect to the datalogger at its IP of <IP_ADDRESS>, but I get Connection Refused error, whatever browser I try. Using a port scanner it seems there are NO open ports, but I can see no reason in the router that would stop me accessing it. The datalogger is a ShineWifi-X and the Inverter is a MIN 5000TL-XE. Any suggestions?

I had the exact same issue. There are 2 possible solutions I tried that worked. One is per the webinterface at server.growatt.com ( at the dash scroll down and spot "All Device", click it and you can find settings for your datalogger on bottom right, remember the "key/passwd" is either growattYYYYMMDD or datalogYYYYDDMM)
Or use the app on your phone: set the logger in hotspot and enter the "Advanced settings" in the setup procedure.
Annt suggestion with webbrowsers didn't work for me either

I am in the same confused state. I installed mosquito addon from addon
store in HA. But the grott addon uses it own user id "grott" hard coded and
I am unable to change it despite extra lines in configuration tab of the
addon or in the ini file in /config/grott. The documentation refers to
addon and component and totally confuses me which is which and what is
necessary in combination with what.
The devs are aware and on it. But they  need time,beer,coffee and cheers.
No doubt they ll succeed. But it's their charity and spare time.
Let's bear with them.
Op zo 29 okt. 2023 12:19 schreef MSavisoft @.***>:

After discovering that I should be able to set the datalogger IP using the
web page, I have reverted to trying to follow the pre-requisite
instructions, specifically Grott. As I have installed Grott as an addon,
does that mean I can ignore Python Application steps 2, 3 & 4? How can I
check Grott is now running as a service?
If I need to do any of steps 2, 3 or 4, I tried using sudo in the Terminal
addon ... but it just responded bash: sudo: command not found. What on
earth is bash? It seems to be a scripting language rather than a normal
terminal.
I then tried to follow the Configuration section. I found
grott/examples/grott.ini, updated it, and saved it over a blank file I
found in my config/grott/grott.ini. Is that the correct place?
The Summary page says I should now have a running Grott server - how do I
prove that before I try to update the datalogger IP? I do not want to lose
any stats sent to the growatt server!
I also had a look ahead at MQTT installation, but got lost when referred
to mosquitto.org with no indication how to install on HAOS!
I feel I am computer literate, but this is all bloody confusing, and I am
losing hope.
—
Reply to this email directly, view it on GitHub
https://github.com/muppet3000/homeassistant-grott/issues/63#issuecomment-1784072028,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AEV42JK5LACOS4DO3WGXRJTYBYUSNAVCNFSM6AAAAAA6OB663OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBUGA3TEMBSHA
.
You are receiving this because you commented.Message ID:
@.***>

I think if you're having problems with the egguy addon then I recommend posting a message over in the github for that so it can be addressed there: https://github.com/egguy/grott-home-assistant-add-on

I think if you're having problems with the egguy addon then I recommend posting a message over in the github for that so it can be addressed there: https://github.com/egguy/grott-home-assistant-add-on

It works now. I had all the devices under MQTT showing but not under grott. I removed all the "shit" I had done to my setup by doing all three guides (Johan Meijers, egguy and yours) and started all over. I didn't edit /config/grott/grott.ini with MQQT. I just entered it in the addon config with the credentials I have the "HA Addon Mosquitto" setup for my tasmota's :

Thanks a bucket of solar for your endless energy in assisting us! (going to buy you a coffee).

After discovering that I should be able to set the datalogger IP using the web page, I have reverted to trying to follow the pre-requisite instructions, specifically Grott. As I have installed Grott as an addon, does that mean I can ignore Python Application steps 2, 3 & 4? How can I check Grott is now running as a service?
If I need to do any of steps 2, 3 or 4, I tried using sudo in the Terminal addon ... but it just responded bash: sudo: command not found. What on earth is bash? It seems to be a scripting language rather than a normal terminal.
I then tried to follow the Configuration section. I found grott/examples/grott.ini, updated it, and saved it over a blank file I found in my config/grott/grott.ini. Is that the correct place?
The Summary page says I should now have a running Grott server - how do I prove that before I try to update the datalogger IP? I do not want to lose any stats sent to the growatt server!
I also had a look ahead at MQTT installation, but got lost when referred to mosquitto.org with no indication how to install on HAOS!
I feel I am computer literate, but this is all bloody confusing, and I am losing hope.

OK. There was no need for terminal acces after all.
Is your setup working?
Decide if you want to use the "HA Mosquitto" addon which you can install from "addons" in HA or if you will be using the builtin mqtt (mosquitto) from the HACS integration by muppet3000.
See my other comment above with picture:
I have the "HA Mosquitto addon" already in my system for other devices that use it.  so I do not use the mosquitto option from muppet3000 in grott but, i DO have to fill in the user password credentials inside grott "configuration" tab for the HA addon "Mosquitto". ( If i am wrong here, some will correct me. So far everything is working for me)
If you do NOT use the HA Addon "Mosquitto" and plan to use the mqqt bundled inside Grott, you have to switch both sliders different:

Disable "Enable Grott MQTT". (yeah totally makes sense, doesn't it?)
Enable "Homeassistant Plugin" (The mqtt lines 1 and 2 with user/password are not needed in this case I assume)
I have nothing in /config/grott/grott.ini . It is left empty!!! I write this because we were fiddling with it before. Also /config/custom_components/grott is left default. No copy from examples or git clone.

BTW Where is the "buy me a coffee" for these devs?

Glad you've got it sorted.
I'd like to leave this issue open though so I can use it to feed into documentation if that's ok? Is there anything else outstanding?
With regards to the 'where's the buy me a coffee', mine is on my github homepage or on this repo. e.g.: https://github.com/muppet3000/homeassistant-grott/ (there's a cute little 'buy me a beer' button or a paypal beerfund button).
There's a bigger version of both here: https://github.com/muppet3000
I'm not sure if egguy has the equivalent, but this is his github page: https://github.com/egguy
I really don't expect anything for this, I'm just trying to help the community the best I can with a hobby that I love.

Hi
I really need some help getting Grott up and running. I am relative new in HA and much more home in Windows environment. And I feel, that the learning curve is not as steep as it used to be.
My setup is HA running native on a x86 computer. The Growatt api integration has worked (sort of), but has stopped some time ago. And i am tiered of Growatt's slow server and limited bandwidth. The proxy solution seems right for me.
I followed the guidelines, except i already have a working MQTT server (installed in HA). It serves data collection from the electricity meter via the HAN port on the meter. One device and 85 entities.
The Grott integration seems to be ok, but shows no devices or entities. I put the grott.ini file in the grott directory and edited it according to the instruktions. But no new entities appear in MQTT. What am I missing? And which additional info may I provide to solve my problem?
Thanks in advance
Per

o devices or entities. I put the grott.ini file in the gro

Have you actually got grott running? Are you running Home Assistant OS? If so have you tried using the HomeAssistant Add-on to run Grott instead as it simplifies the process somewhat.

Hi
Thanks for answering and your time.
Yes, I am on HA OS. That's what I ment with "native". I am not that familiar with the nomenclature in this environment ;-)
In HACS i added the integration from "https://github.com/muppet3000/homeassistant-grott".
I added Grott via Settings - integrations - Add integration. I see Grott in integrations. It shows in Integration entries with no devices and no entities.

Does that mean, that it is running? I dont know what to answer, mostly because I dont know what to expect. I'll say yes, because there are no visible errors.
There is no Grott in Settings - Add-ons, and search for "Grott" gives no results.
Thanks again.
Best, Per

Grott running now with egguy's add-on. Thanks :-)

time to close the topic / issue as it had been solved and nothing new to expect.

After several months pause, I am restarting my attempts at following the instructions to install homeassistant-grott. I will be back with further questions , so please do not close yet!
I think my confusions are caused by the myriad of links to follow in the instructions, and it is not always obvious when to stop following a chain of links, or when to ignore a link.
One major stumbling block is in the Setup MQTT page - I am running HAOS on a RPi4, so I do not understand the instructions for installing mosquitto - presumably as a Local Install - but the Mosquitto Downloads page gives no obvious version to download. Does the HA Mosquitto Broker add-on do the same thing?

I spent some time to help you as others have helped me. It took me weeks to figure it all out and I totally understand your confusion as i went the same rabithole of links and references of information. So, i tried explaining to you what i did to get it working... What part is not explanatory enough?
Seen my comments about mqtt authorization?
"I think my confusions are caused by the myriad of links to follow in the instructions, and it is not always obvious when to stop following a chain of links, or when to ignore a link."
Exactly this is very frustrating. Hence my comment. Appearantly my addition is even worse?
BTW isnt your net meter an "esphome" version?

BTW isnt your net meter an "esphome" version?

Not sure what you mean by 'net meter' or 'esphome' I am afraid.
I do thank you and all others who have contributed ... eventually I seem to have found a way through!
LIke others, I decided to delete stuff and start again, having tried to distill all the docs and advice ... but largely aiming for the minimum. For others to comment, and maybe to help newcomers, what I actually did was...
Installed the following in my RPi4 hosted HomeAssistant:
Add-on: Mosquitto broker
Configuration changes
None
Log
No errors seen
Add-on: Grott Beta v2.8
Configuration changes
Inverter Type = MIN			(which is the reason for v2.8, as MIN may not work with v2.7)
Enable grott MQTT = Selected
Home Assistant Plugin = NOT selected
Network Port = 5279
Log
No errors seen
Seems to be IP <IP_ADDRESS> port 5279   <<< Private address used by?
Received packets from radr

'<IP_ADDRESS>', 5279         <<< Alibaba Cloud
'<IP_ADDRESS>', 13946			<<< My Growatt Wifi dongle

HACS Integration: homeassistant-grott
Configuration changes
None
Datalogger ShineWifi-X
Configuration changes
I think I changed the IP to my HA IP using web interface, using
-> All devices -> Datalogger Setting -> Set IP -> Yes + password.
But I am not sure of this, and the web interface does not seem to display what the setting currently is!
Results
However, after doing just the above AFAIK, much to my suprise it all seemed to spring into life!

The web interface and Shine app are continuing to show updated values.
Home Assistant is also seeing the same set of updated values!

Does this look ok? Is there anything else I can do to check that all is well?
How does HA know where to forward the messages for the growatt server?
Many thanks to all!


Add support for non human samples

Description of feature
Infer organism from sample meta and process fastq's.
flowchart LR
fastq --"picard FastqToSam"--> uBam --"samtools"--> uCram

done in 4069813