fix: ui overlap between dropdown and sticky-widget

I was using Playground and found Ui overlapping between dropdown contents and sticky-widget
The z-index of the sticky-scroll is higher, so I set it to be one larger than that z-index.
prev
https://github.com/microsoft/TypeScript-Website/assets/87258182/ab3fa5f7-8785-4aec-a21b-910287cb549b
after
https://github.com/microsoft/TypeScript-Website/assets/87258182/2c5c0384-1c00-48ee-9e3f-57a0b0f97f03

I'm not seeing the original behavior at all; what browser are you on? Anything special?

You must click Nav with sticky-scroll enabled. The same happens with Firefox.
chrome: v125.0.6422.114
firefox: v121.0.1
https://github.com/microsoft/TypeScript-Website/assets/87258182/98df0d6b-a0e8-4406-9f73-87fb6202d613

How does one "enable sticky-scroll"?

How does one "enable sticky-scroll"?

Creates a class or function and is activated when scrolling.
It's a basic function from vscode version 1.87 and more guide

Okay, but is that enabled on the website?

Yes, I do, but you don't?

I apparently wasn't testing it right. I see the problem now.


Socket tracer unable to start on 6.11 kernel

Describe the bug
From working with someone in the community, I received a report that their OpenSUSE MicroOS instances were failing to start the socket tracer. Their PEMs fail to compile multiple BPF programs (as seen below). Their instances are running a 6.11 kernel while our latest kernel headers are 6.1.x.
I'm in the process of verifying that newer kernel headers resolves their problems, and if that's the case, our linux header kernels should be updated through 6.11.
Logs
pixie_logs_20241001120707.zip
The relevant logs from that PEM are the following:
E20241001 18:31:33.085537 91215 task_struct_resolver.cc:330] Internal : Unable to initialize BCC BPF program: Unable to initialize BPF program
I20241001 18:31:33.150326 91217 bcc_wrapper.cc:166] Initializing BPF program ...
In file included from <built-in>:4:
In file included from /virtual/include/bcc/helpers.h:54:
In file included from arch/arm64/include/asm/page.h:52:
include/asm-generic/getorder.h:33:27: error: use of undeclared identifier 'CONFIG_ARM64_PAGE_SHIFT'
                        return BITS_PER_LONG - PAGE_SHIFT;
                                               ^
arch/arm64/include/asm/page-def.h:14:21: note: expanded from macro 'PAGE_SHIFT'
#define PAGE_SHIFT              CONFIG_ARM64_PAGE_SHIFT
                                ^
In file included from <built-in>:4:
In file included from /virtual/include/bcc/helpers.h:54:
In file included from arch/arm64/include/asm/page.h:52:
include/asm-generic/getorder.h:35:22: error: use of undeclared identifier 'CONFIG_ARM64_PAGE_SHIFT'
                if (size < (1UL << PAGE_SHIFT))
                                   ^
arch/arm64/include/asm/page-def.h:14:21: note: expanded from macro 'PAGE_SHIFT'
#define PAGE_SHIFT              CONFIG_ARM64_PAGE_SHIFT
                                ^
In file included from <built-in>:4:
In file included from /virtual/include/bcc/helpers.h:54:
In file included from arch/arm64/include/asm/page.h:52:
include/asm-generic/getorder.h:38:30: error: use of undeclared identifier 'CONFIG_ARM64_PAGE_SHIFT'
                return ilog2((size) - 1) - PAGE_SHIFT + 1;
                                           ^
arch/arm64/include/asm/page-def.h:14:21: note: expanded from macro 'PAGE_SHIFT'
#define PAGE_SHIFT              CONFIG_ARM64_PAGE_SHIFT
                                ^
In file included from <built-in>:4:
In file included from /virtual/include/bcc/helpers.h:54:
In file included from arch/arm64/include/asm/page.h:52:
include/asm-generic/getorder.h:42:11: error: use of undeclared identifier 'CONFIG_ARM64_PAGE_SHIFT'
        size >>= PAGE_SHIFT;
                 ^
arch/arm64/include/asm/page-def.h:14:21: note: expanded from macro 'PAGE_SHIFT'
#define PAGE_SHIFT              CONFIG_ARM64_PAGE_SHIFT
                                ^
In file included from src/stirling/bpf_tools/bcc_bpf/task_struct_mem_read.c:24:
In file included from src/stirling/bpf_tools/bcc_bpf/system-headers/linux/sched.h:1:
In file included from include/linux/sched.h:14:
In file included from include/linux/pid.h:5:
In file included from include/linux/rculist.h:11:
In file included from include/linux/rcupdate.h:30:
arch/arm64/include/asm/processor.h:314:16: error: use of undeclared identifier 'CONFIG_ARM64_PAGE_SHIFT'
        return addr < TASK_SIZE;
                      ^
arch/arm64/include/asm/processor.h:68:5: note: expanded from macro 'TASK_SIZE'
                                TASK_SIZE_32 : TASK_SIZE_64)
                                ^
arch/arm64/include/asm/processor.h:65:42: note: expanded from macro 'TASK_SIZE_32'
#define TASK_SIZE_32            (UL(0x100000000) - PAGE_SIZE)
                                                   ^
arch/arm64/include/asm/page-def.h:15:35: note: expanded from macro 'PAGE_SIZE'
#define PAGE_SIZE               (_AC(1, UL) << PAGE_SHIFT)
                                               ^
arch/arm64/include/asm/page-def.h:14:21: note: expanded from macro 'PAGE_SHIFT'
#define PAGE_SHIFT              CONFIG_ARM64_PAGE_SHIFT
                                ^
In file included from src/stirling/bpf_tools/bcc_bpf/task_struct_mem_read.c:24:
In file included from src/stirling/bpf_tools/bcc_bpf/system-headers/linux/sched.h:1:
In file included from include/linux/sched.h:32:
include/linux/mm_types_task.h:19:10: fatal error: 'asm/tlbbatch.h' file not found
#include <asm/tlbbatch.h>
         ^~~~~~~~~~~~~~~~
6 errors generated.
I20241001 18:31:34.551831 91217 scoped_timer.h:48] Timer(init_bpf_program) : 1.40 s
E20241001 18:31:34.551985 91217 task_struct_resolver.cc:330] Internal : Unable to initialize BCC BPF program: Unable to initialize BPF program
W20241001 18:31:34.552109 91084 bcc_wrapper.cc:149] Failed to obtain task_struct offsets, will not override the task_struct offsets, error: Internal : Resolution failed in subprocess. Check subprocess logs for the error.
I20241001 18:31:34.552258 91084 bcc_wrapper.cc:166] Initializing BPF program ...
In file included from <built-in>:4:
In file included from /virtual/include/bcc/helpers.h:54:
In file included from arch/arm64/include/asm/page.h:52:
include/asm-generic/getorder.h:33:27: error: use of undeclared identifier 'CONFIG_ARM64_PAGE_SHIFT'
                        return BITS_PER_LONG - PAGE_SHIFT;
                                               ^
arch/arm64/include/asm/page-def.h:14:21: note: expanded from macro 'PAGE_SHIFT'
#define PAGE_SHIFT              CONFIG_ARM64_PAGE_SHIFT
                                ^
In file included from <built-in>:4:
In file included from /virtual/include/bcc/helpers.h:54:
In file included from arch/arm64/include/asm/page.h:52:
include/asm-generic/getorder.h:35:22: error: use of undeclared identifier 'CONFIG_ARM64_PAGE_SHIFT'
                if (size < (1UL << PAGE_SHIFT))
                                   ^
arch/arm64/include/asm/page-def.h:14:21: note: expanded from macro 'PAGE_SHIFT'
#define PAGE_SHIFT              CONFIG_ARM64_PAGE_SHIFT
                                ^
In file included from <built-in>:4:
In file included from /virtual/include/bcc/helpers.h:54:
In file included from arch/arm64/include/asm/page.h:52:
include/asm-generic/getorder.h:38:30: error: use of undeclared identifier 'CONFIG_ARM64_PAGE_SHIFT'
                return ilog2((size) - 1) - PAGE_SHIFT + 1;
                                           ^
arch/arm64/include/asm/page-def.h:14:21: note: expanded from macro 'PAGE_SHIFT'
#define PAGE_SHIFT              CONFIG_ARM64_PAGE_SHIFT
                                ^
In file included from <built-in>:4:
In file included from /virtual/include/bcc/helpers.h:54:
In file included from arch/arm64/include/asm/page.h:52:
include/asm-generic/getorder.h:42:11: error: use of undeclared identifier 'CONFIG_ARM64_PAGE_SHIFT'
        size >>= PAGE_SHIFT;
                 ^
arch/arm64/include/asm/page-def.h:14:21: note: expanded from macro 'PAGE_SHIFT'
#define PAGE_SHIFT              CONFIG_ARM64_PAGE_SHIFT
                                ^
In file included from src/stirling/source_connectors/proc_exit/bcc_bpf/proc_exit_trace.c:24:
In file included from ./src/stirling/bpf_tools/bcc_bpf/task_struct_utils.h:26:
In file included from src/stirling/bpf_tools/bcc_bpf/system-headers/linux/sched.h:1:
In file included from include/linux/sched.h:14:
In file included from include/linux/pid.h:5:
In file included from include/linux/rculist.h:11:
In file included from include/linux/rcupdate.h:30:
arch/arm64/include/asm/processor.h:314:16: error: use of undeclared identifier 'CONFIG_ARM64_PAGE_SHIFT'
        return addr < TASK_SIZE;
                      ^
arch/arm64/include/asm/processor.h:68:5: note: expanded from macro 'TASK_SIZE'
                                TASK_SIZE_32 : TASK_SIZE_64)
                                ^
arch/arm64/include/asm/processor.h:65:42: note: expanded from macro 'TASK_SIZE_32'
#define TASK_SIZE_32            (UL(0x100000000) - PAGE_SIZE)
                                                   ^
arch/arm64/include/asm/page-def.h:15:35: note: expanded from macro 'PAGE_SIZE'
#define PAGE_SIZE               (_AC(1, UL) << PAGE_SHIFT)
                                               ^
arch/arm64/include/asm/page-def.h:14:21: note: expanded from macro 'PAGE_SHIFT'
#define PAGE_SHIFT              CONFIG_ARM64_PAGE_SHIFT
                                ^
In file included from src/stirling/source_connectors/proc_exit/bcc_bpf/proc_exit_trace.c:24:
In file included from ./src/stirling/bpf_tools/bcc_bpf/task_struct_utils.h:26:
In file included from src/stirling/bpf_tools/bcc_bpf/system-headers/linux/sched.h:1:
In file included from include/linux/sched.h:32:
include/linux/mm_types_task.h:19:10: fatal error: 'asm/tlbbatch.h' file not found
#include <asm/tlbbatch.h>
         ^~~~~~~~~~~~~~~~
6 errors generated.

App information (please complete the following information):

Pixie version: v0.14.11
K8s cluster version:
Node Kernel version: 6.11.0-1-default
OS distro: openSUSE MicroOS
Browser version: N/A

After supplying one-off built kernel headers from #2036, this community user's ARM64 and x86 PEMs are still seeing BPF compilation issues. I ran one of the trace bpf tests in qemu with a 6.11.1 kernel and the new headers, and I'm able to reproduce the same error message that they have.
observability__vizier-pem-dv96n__pem.log
qemu_dns_trace_bpf_test.log

I was able to track down the problem and upgrading bcc fixes the issue.
BCC has certain "virtual" files it includes behind the scenes. The compat/linux/virtual_bpf.h file in particular needs to be kept in sync with libbpf and matches the header guard of the include/uapi/linux/bpf.h file. This means that while our linux headers were updated, our older bcc install was inserting an older copy of the uapi/linux/bpf.h file -- one that didn't contain the bpf_wq declaration.
I need to double check that my rebasing of bcc's updated changes is correct, and update our fork (pixie-io/bcc) first, but I should be able to open a PR for this soon.


Internal server error when manually retrying a delayed job

Hey,
I have a job delayed upon a 3rd attempt. I press retry on the job in the delayed section and then I get an internal server error

Can you open the console and check what is the entire error?

Getting this error too, console says:
Retried job not failed
    at Job.retry (node_modules/bullmq/dist/classes/job.js:556:19)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at async retryJob (node_modules/@bull-board/api/dist/src/handlers/retryJob.js:7:5)
    at async node_modules/@bull-board/express/dist/ExpressAdapter.js:61:34

@djdmbrwsk can you elaborate what do you get on the server side / client side?
How I can reproduce the issue?

So the bug is in the UI, the retry button should appear only on failed tab

That would be the simple fix, but I think it could be interesting to allow users to execute a delayed job immediately too. Useful for this scenario, but unsure of other scenarios...maybe too dangerous.

@djdmbrwsk thank you for the explanation 🙏🏼

That would be the simple fix, but I think it could be interesting to allow users to execute a delayed job immediately too. Useful for the retry scenario, but unsure of other scenarios...maybe too dangerous.

Delayed jobs has promote button for this

Delayed jobs has promote button for this

Interesting! I thought I saw a PR for this, but didn't notice it in the UI...


Minimal hot deployment

See commit messages for details.
Resolves #227, the remaining work detailed in that issue is tracked by #226 and #282

@Jannis Comments addressed, this is ready for re-review.

@Jannis @timmclean I'm now using a regular JSON-RPC request to add the subgraph from the CLI, this is ready to review again.

LGTM!


Use .eslintrc for linting when it is present

First of all, thank you for the great tool!
Current Behavior
tsdx ignores .eslintrc.js or .eslintrc.json in project's root directory and uses default config when lint script is run.
At the moment it is possible to redefine default linting config only by specifying necessary settings in eslint key inside package.json. It is quite inconvenient.
Desired Behavior
Use .eslintrc.js or .eslintrc.json when it is present in project's root directory to redefine/replace default config.
Suggested Solution
Check presence of .eslintrc.js or .eslintrc.json in project's root directory and use its contents instead of default config returned by createEslintConfig.

Who does this impact? Who is this for?
All users wanting to customize linting settings.
Describe alternatives you've considered

Additional context

Duplicate of #498 . Per my comments there, tsdx lint does read .eslintrc ~3 lines below the code you linked.
I use an .eslintrc.js with TSDX latest in my own projects and can't reproduce this. Please provide a repro.

Sorry, I missed #498 (I searched only for open issues).
I've added the following snippet in .eslintrc.js
    rules: {
        'prettier/prettier': 'off'
    }

as mentioned in the comment for 498 and fixed the problem.
By the way, I suppose the info from this comment (about You can change everything, but one difference with using an eslintrc file is that the internal rules will be added to any custom ones, unless you've specifically set them to off in your rules.) and this comment (adding 'prettier/prettier': 'off' to rules) should be added into README.md to avoid confusion.

Yea as this has popped up at least twice now, docs around this behavior would be helpful.
The behavior does feel unintuitive (I was confused by this initially too), but I'm not sure it can be changed without being breaking.
Similarly, as the ESLint API is handling loading .eslintrc, it's not easy to differentiate between the case of no .eslintrc (use defaults) and yes .eslintrc (don't use defaults, breaking change) 😕

Ahhh so I just realized why this didn't pop up with package.json.eslint -- that config is shallow merged with the default config, and all the extends are another level deep, so the whole extends array gets overwritten.
I guess the ESLint API does a deeper merge? This mismatched behavior is definitely something that should be fixed so that they work the same way... Unfortunately that has potential for breakage regardless of which one is changed, welp 😕
I'd lean toward matching the ESLint API, though I have a feeling it might automatically check package.json.eslint too, need to investigate more.
But if one has to break anyway, might make sense to get rid of the confusing baseConfig when using a custom eslintrc. Will have to see if the API has a way to detect custom options outside of CLIEngine.
If we remove baseConfig when a config is specified for tsdx lint, we should probably do the same with tsdx test for consistency. Still need presets and --write-file to make that easier though 😕 . That'd be double breaking then ooof

Imho baseConfig (or at least default config) should be ignored when there is an ESLint config file in project's root directory.
Another way is to add an option to skip/ignore default config.

Yea I think that's the less confusing option, particularly because of the editor integration and how nuanced linting tends to be (including me, you're at least the third to be confused by this). The base Jest config merging doesn't seem to have been as confusing.
As I alluded to here and explicitly mentioned in #498 , the difficulty with this will be determining when there is and isn't a custom config present. As there are like 4+ different extensions and package.json.eslint, it'd be a lot easier if the ESLint API handled it, but idk that it does.

it'd be a lot easier if the ESLint API handled it, but idk that it does.

Seems like there might be a way to hack it together with CLIEngine#getConfigForFile, but there isn't really an exact API to check for existence of config, so I might have to file an issue with ESLint


Bold line remove fix

This is a hot fix for bold letters not finding path and focus

You ought to merge into dev first, PR has been created and merged.


meta updates for Swiftype, plus viewport meta

This PR update the Swiftype meta tags and adds a viewport meta tag. While we're not sure how the generated docs will be incorporated in the site-wide search (we want to slowly rollout to measure usage so we can allocate time/effort accordingly), but would like to get these pages entered in Swiftype with the attributes we need.
@friedbunny do you know if there's a template var to generate a page description/excerpt? I did a quick search, but haven't found a good resource.

In terms of the available variables, I think this method outlines what’s there at the document level.
The first sentence/paragraph of overview might be useful, since it’s usually (but not always) a decent synopsis of a given class/protocol/thing.


Notice: unserialize(): Error at offset 0 of 1 bytes in /home/billing99/public_html/core/classes/System/Config.php on line 32

Warning: Cannot modify header information - headers already sent by (output started at /home/billing99/public_html/core/classes/System/Config.php:32) in /home/billing99/public_html/core/classes/System/Tools.php on line 27
Really like the  script, but install it is very tedious, will be happy and ready to support any developer that expend time  fixing it, to make a clean easy to install and configure this wonderful script.

Try to delete from app/modules billmanagervps.zip

исправлено


Add 'check SQL query' mode

With templated SQL queries, variables get replaced with values from the playbook.
:variables:
  :input_schema: atomic

and
SELECT * FROM {{.input_schema}}.events

produce:
SELECT * FROM atomic.events

With less straightforward cases, it will be helpful to check what value a variable get's replaced with, without having to go through the full Sync & Deploy & Run cycle.
One such case is:
:variables:
  :start_date: '2018-03-13'

where it isn't clear how the single quotes should be properly escaped.

What should the output of 'check SQL query' mode be? How does this relate to -dryRun?

The output should be the SQL query or queries the way they look after all the {{.variables}} have been replaced with values from the playbook. That will allow us to see the SQL that is going to actually be run.
Currently, a -dryRun of the playbook reports SUCCESS for the queries in it, but when we run the actual job it still might fail with a SQL error.
Since there is no visibility about the transformations that are being done to the variables, we have to debug this through trial and error; and a trial involves updating the file, waiting for S & D, asking Support to run the job manually, then waiting for the results. It's quite long-winded and can turn into a significant time-sink.
A 'check SQL option` would produce a SQL query that we can directly run in Redshift or Snowflake.

Got it, I think we could go with with a CLI arg like -fillTemplates to kick this off.

Updated ticket name, please update commit


Release 0.6.0

I'd like to include #110, and enhancements for #85, #66

Agreed. And support for "alternative" distribution installation.

Targeting the 21st or 22 for a release.


ra dec db

Now it is 'safe'. I will list comments/requests from the old PR below

[ ] options changed to -s (doc string)
[ ] lines to set ra, dec, mc dec repeated in try except
[ ] read ra and dec together from dictionary
[ ] one extended source in db and one 'not source'
[ ] sort dictionary


Compress a chunk of data and retrieve the compressed size

Is-it possible to achieve the following with sharpcompress ? : https://stackoverflow.com/questions/45225914/how-to-get-the-compressed-size-ziparchive-of-a-filestream-block

Just use DeflateStream on each 64k block.  No need to actually make a zip file.

I'm writing an windows store package editor, the appx format used here is basically a zip( can be zip64) deflate file with some XML metadatas.
In order to create a package, I for example need to split a file in several 64kb chunks, compress each of them using the deflate method then store the compressed length of each chunk inside an XML file. So I need to make a zip (appx) file in the end.
Are you saying that either compressing a file with a deflate-stream or directly into a ZIP, the compressed data are going to be strictly identical on both ends ? If not, is it possible to compress data by chunk and get the compressed length of each ?

You could make a zip and get the length but it’s more efficient just to make a deflate stream write to a file or memory and get the length that way.  It doesn’t matter if it’s 64k chunks or whole files.
I can’t help with the appx spec.  I thought it was a regular zip file.

Thanks for your help adam. It is a regular zip file :p But it requires an XML file that contains, for every single entry, a hash of each 64kb uncompressed block and the size of the compressed block inside the archive.
A better explanation from Microsoft :

When an app file is added to the app package, it is first divided into 64-KB blocks, and each block is hashed using the algorithm specified. If the size of the file is not an even multiple of 64 KB, the size of the final block is inferred as the remainder of the file size divided by 64 KB.

The Size attribute value is the size of the data block as stored in the app package. This is usually smaller than 64 KB because each block is commonly compressed before being stored in the app package. Because data compression (Deflate algorithm) produces a variable-length result, the Size attribute must be specified for all blocks of a file stored in compressed form within the package.

At the very end, I need to make a zip (appx) file, can I first compress each block with a deflate stream, then collect the compressed length on-the-fly and finally compress the source file into a zip entry ?
Is processing this way going to give me the same compressed data on both ends ? I ask because I imagine that compressing a file by chunk is not the sane as doing it in a single shot ? In my case, it is not really important if the compression is not very efficient.

No it won’t be the same as doing a single stream vs 64k chunks.  You can do anything you’re talking about with DeflateStream and/or Zip classes.  It’s just a matter of figuring out the algorithm for making appx files which I can’t help with.

Sure I wasn't expecting you to help me with the appx part :D How can I access the deflate stream with sharpcompress while adding a zip entry ? Is the compression done in real-time or only when the stream is closed ?

It's done in real time when writing the stream.  Closing the stream just guarentees the final bit which is what you need to do 64k at a time.
You're going to have to chunk the file and compress first to get the data you want then later create the final zip file.

Ok, this make sense ! One last question if you don't minde, Is there any equivalent of zlib Z_FULL_FLUSH when using a DeflateStream using the Zip class ? this is what I need (and cannot do with native .net io.compression since it is too high level).

I don’t currently expose it but I could easily on ZipWriterOptions.  The enum is FlushType and could be used along side DeflateCompression.
A pull request is welcomed :)


Fixing issue with x axis label

Previously, by default, the x positions of the skill plots were at [1, 2, 3, ..., n]. However, when an aux variable is numeric, that raised rendering issues (see issue #429).
This PR changes the handling of x labels in skill plots based on whether the x values are numeric or not.

I do not understand.
This _format_ax() function in the notebook has nothing to do with the bug fixed in this PR. I created that function to consistently format all plots in my notebook.
If I implement sk.mape.plot.line(ax=ax, color=my_color_dict), then I get:

Which was already correct before the PR, since the lead time has a time step = 1. However, I wanted it a bit "prettier", so I made the formatting function.


Risk of stopping a process by mistake

Dev Home version
<IP_ADDRESS>
Windows build number
10.0.22621.1702
Other software
OS Build Version: 10.0.22621.1702.amd64fre.ni_release.220506-1250
.NET Version: .NET 6.0.16
Steps to reproduce the bug
Ensure there isn't any process running that is heavy on the CPU. Add the CPU widget and kill a process.
Expected result
The process you wanted to kill should get killed.
Actual result
Depending on your processes and their CPU load, the processes move around so much, that it's almost impossible to kill the one you want. So you either have to accept that the buttons are useless, or you can choose to risk it and you might kill a process by mistake...
Included System Information
No response
Included Extensions Information
No response

I know this was opened first, but I'm going to dupe it to 1284 because that one has a PR attached.

Duplicate of #1284


Update the pip install commands on build to fail if pure python library is not available

Update the command to look for py3-none-any wheels while installing.

Yes. We are getting close to a point where we don't have any dependencies other than jedi-language-server. Since that is shipped inbox, we still have to consider this.

This can be closed now as jedi-language-server dropped a dependency that could have caused issue.


fix 805-support-array-type-validation-for-aliased-definition

Problem:
Go-swagger supports array type validation for the modals that uses direct definition, while if the modal definition is set by $ref (aliased), the validation logic are not generated in Swagger templates rendering, causing Rest server unable to prevent invalid rest calls.
Fix:
By allowing IsAliased items to be rendered for type validation.

Current coverage is 68.91% (diff: 100%)

Merging #808 into master will decrease coverage by 0.01%

@@             master       #808   diff @@
==========================================
  Files            19         19
  Lines          5566       5566
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
- Hits           3837       3836     -1
- Misses         1351       1352     +1
  Partials        378        378

Powered by Codecov. Last update 9c21adb...c90cd4f


Import/export data sources

Hi guys,
This tool is simple, but really powerful ! 👏
Did you plan to add data source import and export ?

Hey! Thanks, great to hear that! :+1:
Can you tell me more about this, how would you like to use it? Do you mean exporting whole data source including all data to a file, i.e. dumping?

Thanks for the fast reply ;)
On my infrastructure, I scripted the deployment of prometheus + grafana.
I use Grafcli for importing from my git repo a list of selected dashboards. But I still need to execute a curl command for creating the data source :-(
I use both import and export command, with the remote target.

It should be as simple as inserting a row to data_source table. 👍

So I've decided to take advantage of the HTTP API, since changes will be safer this way. The basic version is there, supporting data sources should be coming soon.

Would be great once this is implemented!

Any news on this issue? I was about to test this but after I saw this backup/restore issues I am not so sure anymore


Threads: THREAD_MEMBERS_UPDATE presence field is nullable

As per https://github.com/discord/discord-api-docs/pull/3688, the presence field is now nullable on this event.

We already have it as optional, I do not believe there would be any difference between null and it not being sent in this case
https://github.com/twilight-rs/twilight/blob/feature/threads/model/src/channel/thread/member.rs#L18

Thanks for pointing that out


update npm version to 1.4.12

Update cache to use NPM version 1.4.12

@paulgmiller I added 1.4.9 back in the above commit. Can you approve?


Improve logic to cleanup server-session exactly once

Breaking apart the PR in #6401.  This one includes the logic to better ensure that the server_session is closed and deleted in a timely manner.  The crash we were seeing was due to a server_session staying around after the HttpSM had been deleted.  The inactivity cop would execute the handleEvent on the deleted HttpSM continuation.

Unfortunately, I still get the crash with trailers. Have you tried this with --trailer? Am I missing something?
nghttp -v --no-dep -s "https://<IP_ADDRESS>:4443/post/" -d /usr/local/var/www/128kb --trailer 'foo: bar'

CONFIG proxy.config.http.transaction_no_activity_timeout_in INT 3
CONFIG proxy.config.http.transaction_active_timeout_out INT 5

We also needed PR #6407 to fix the crash.  Perhaps that is all we needed.  Will do some experiments today with combinations of this PR #6407 and PR #6404

So far, our 9.0.x plus PR #6407 and PR #6404 is not crashing.  Our crashes were intermittent, so I'll keep an eye on things today.
Unfortunately, PR #6407 and #6404 do not play together well.  With the fix for #6407, the read_complete has already been sent for the post data so the HttpSM handler is state_watch_for_client_abort when the second trailer READ_COMPLETE is sent.  This causes the transaction to fail and the nghttp request is responded with a 502 error.
In our case, the faulty clients are not sending trailing headers, so just fixing it in the trailing header logic is not sufficient.

So far, our 9.0.x plus PR #6407 and PR #6404 is not crashing.

Do you mean #6407 and #6408 ?
#6407 will hide the issue which uncovered by the commit.
For trailers, we should not signal READ_COMPLETE on final DATA frame. I can do that on #6404, after #6407 is merged.

I talked with @bryancall today, and since the according to the spec we should really be returning a a HTTP/2 error to the client if they are not sending a data frame EOS.  I didn't get time today, but I would like to spend some more time tomorrow correctly identifying and cleaning up this case.  While PR #6408 avoids the crash, it does not return the error to the client.

I think we can take this one out of the mix

Remember to clear Milestone / Project when closing a PR without merging :).


Issue #1323 - Add support for ':of-type' modifier

Issue #1323 - Add support for ':of-type' modifier
Signed-off-by: Troy Biesterfeld<EMAIL_ADDRESS>

Here's what the extracted parameters look like in the x_TOKEN_VALUES_V views.

PARAMETER_NAME_ID
CODE_SYSTEM_ID
TOKEN_VALUE
COMPOSITE_ID

1191
20003
333333

20000
20005
MR1
0

20001
20010
333333
0

20000
20004
MR2
1

20001
20010
333333
1

1191
20003
4444444

20000
20009
MR3
2

20001
20010
4444444
2

20000
20008
MR4
3

20001
20010
4444444
3

This PR is dependent on changes in the PR for issue #773.

This PR is dependent on changes in the PR for issue #773.
So review of this PR can focus on just the commits for this issue #1323.

Tip:  you can actually have this pull request target the branch you used for the other PR...then the diff will only show the delta.   If the other PR gets merged, github will automatically change this target to main.  Mind if I change the base of the PR?

This PR is dependent on changes in the PR for issue #773.
So review of this PR can focus on just the commits for this issue #1323.

Tip: you can actually have this pull request target the branch you used for the other PR...then the diff will only show the delta. If the other PR gets merged, github will automatically change this target to main. Mind if I change the base of the PR?

Ah, ok.  I didn't realize it worked that way.  Sure, go ahead!


change stakerspace validator name and stash

@wpank this PR can be closed since address was changed in your PR 2286


[WIP] Add contribution guidelines (Issue #91)

I will wait for the rules to add content to this file

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Solves #91


Enemy move revealed immediately as first rival fight begins

Version: v.0.5.2
Game: FRLG
Two different streamers have run into this issue where very rarely they see move information for a Pokemon they shouldn't know about. This appears to happen exclusively in lab fights, even before the Pokemon are sent out. I wonder if this has something to do with reading in game data and a desync between tracking it.  It's possible this bug affects other pokemon but is seen most commonly in lab fights.

Source: https://www.twitch.tv/videos/1536104846
Unsure if this affects games other than FRLG.

i am pretty sure that something similar happened to me
it happned for a mon outside the lab in route 22 fighting against armaldo
on the fight it showed all his moves i wasnt 100% concentrating so it could be that i missed him using moves but i doubt i would have missed all the 4 moves being used
from what i am seeing in the clip the move has * so my guess in the move data it registered as learned at lvl 1 or something maybe it would help narrowing it down


Support for serializing Objects to JSON or XML

From<EMAIL_ADDRESS>on October 06, 2011 08:38:37
Add support for at least Jackson, Gson and JAXB
Original issue: http://code.google.com/p/rest-assured/issues/detail?id=118

From<EMAIL_ADDRESS>on October 05, 2011 23:40:51
Status: Started

From<EMAIL_ADDRESS>on October 06, 2011 09:51:39
Status: Fixed


Custom message when there's no autocomplete item to show

How can I add custom message when the auto complete doesn't return any value? ex: "No results found"

is this feature available now??

+1

+1

This issue was selected to be spring-cleaned by a script. More information can be found here.
If anyone thinks this was a mistake and this issue should be reopened, please leave a message below explaining why. Before doing so, please consider reading the CONTRIBUTING file.


inference slow

Why is the inference speed using ComfyUI almost twice as slow as the library "https://github.com/s9roll7/animatediff-cli-prompt-travel"?
4090GPU，512 X 680, 16frame

Something may be up with your environment, or drivers, etc. On my RTX 4090 (Windows 10, 5950x, Driver 537.42), at the 512x680 resolution (16 frames), I get 1.59 it/s, which is 2.4x your ComfyUI speed and 1.5x your CLI.

For future speed comparisons, I recommend a simple 512x512 resolution (16 frames), using the basic AD txt2img workflow on the readme: https://github.com/Kosinkadink/ComfyUI-AnimateDiff-Evolved#txt2img
Running the linked workflow to get that README gif, I get ~2.17it/s

I know NVIDIA's current driver allegedly fixed a significant Stable Diffusion speed decrease from the driver version right before, so maybe updating the NVIDIA driver would help. I personally am on the driver version from September 12th.

tks!


Implement expand macros command for proc-macro derives

It currently only works for macro_rules! macros.

Duplicate of #4005?

My bad


Enhanced cover art uploads script fails with "Skipping : Cannot read properties of undefined (reading 'filename')"

The latest update to the userscript has completely broken functionality for me, any attempt to import an image results in errors like:
Skipping 500x500.jpg: Cannot read properties of undefined (reading 'filename')

The error console displays the following:
[mb_enhanced_cover_art_uploads] Searching for images in Deezer release…
instrument.js:102 [mb_enhanced_cover_art_uploads] Found 1 images in Deezer release
instrument.js:102 [mb_enhanced_cover_art_uploads] Skipping 500x500.jpg TypeError: Cannot read properties of undefined (reading 'filename')
    at MB： Enhanced Cover A…oads.user.js:106311
    at l (MB： Enhanced Cover A…oads.user.js:104504)

The first line in the stack trace points to:
https://github.com/ROpdebee/mb-userscripts/blob/98f99f6c06c7a293b5685df6c23131bf291cb8c9/src/mb_enhanced_cover_art_uploads/fetch.ts#L80
Entering a URL in the input box results in the same error.
I'm running:

Brave v1.33.106-1 on Linux
Violentmonkey v2.13.0
MB: Enhanced Cover Art Uploads v2<IP_ADDRESS>

@atj please install and test the preview from https://github.com/ROpdebee/mb-userscripts/pull/352#issuecomment-1003003221 which should fix the issue.

Works for me, thanks for the quick fix!


Remove CAPA command from deployment

What this PR does / why we need it:
Removes command from CAPA deployment to fix crashloop
Checklist

[ ] Subject and description added to both, commit and PR.
[ ] Relevant issues have been referenced.
[ ] This change includes docs.
[ ] This change includes unit tests.

/lgtm


Block breaking particle issues

Forge: 34.1.42
BlockCarpentry: 1.16.2-0.3.4
When breaking all blocks, the breaking particle is tinted green and doesn't match the texture. This discoloration occurs regardless if the block is being disguised with another block.

In addition, breaking specific blocks spawn too many particles:

Frame
Illusion Frame
Frame Chest
Illusion Frame Chest
Frame Bed
Illusion Frame Bed

Strangely, disguising the frame/illusion frame/frame bed/illusion frame bed and breaking it spawns a normal amount of particles. When doing this with the frame chest/illusion frame chest, disguising and breaking the chest still spawns too many particles.

I've included a screenshot of breaking a wooden plank block for both particle number and color comparison.

Ugh... thanks for reporting. That's pretty weird. I think I know how to fix the "particles have wrong texture" thing. For the green coloring I do know where it comes from but I don't know how to fix it, and for the "too many particles"-part I don't even have a clue what causes it...
Thanks for reporting, I'll try and fix this, when I have some time. Right now, I'm very busy with my studies...
Regards, Manu


Update cats-effect to 3.4.6

Updates org.typelevel:cats-effect from 3.4.5 to 3.4.6.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.typelevel", artifactId = "cats-effect" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "org.typelevel", artifactId = "cats-effect" }
}]

labels: library-update, early-semver-patch, semver-spec-patch, version-scheme:early-semver, commit-count:1

Codecov Report
Base: 79.00% // Head: 78.98% // Decreases project coverage by -0.02% :warning:

Coverage data is based on head (c86864c) compared to base (497209d).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #35      +/-   ##
==========================================
- Coverage   79.00%   78.98%   -0.02%
==========================================
  Files          54       54
  Lines        2491     2470      -21
  Branches       58       17      -41
==========================================
- Hits         1968     1951      -17
+ Misses        523      519       -4

Impacted Files
Coverage Δ

.../src/main/scala/kinesis4cats/kpl/KPLProducer.scala
81.72% <0.00%> (-1.30%)
:arrow_down:

.../main/scala/kinesis4cats/kcl/RecordProcessor.scala
72.22% <0.00%> (-0.31%)
:arrow_down:

.../src/main/scala/kinesis4cats/kcl/KCLConsumer.scala
43.05% <0.00%> (-0.19%)
:arrow_down:

...main/scala/kinesis4cats/client/KinesisClient.scala
67.53% <0.00%> (+0.45%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Add copy_file function and its windows implementation

Adds a new copy_file function. This PR adds only the Windows based implementation. Linux and macOS implementations throw exception.

Just merged 👍  I'll try to implement this for the other platforms next week.


🐛 Delete 3PID association upon deactivating user

Open issue in upstream: https://github.com/matrix-org/dendrite/issues/2703
Case in Are We Synapse Yet?: 3PIDs are unbound after account deactivation.

Open issue in upstream: https://github.com/matrix-org/dendrite/issues/2703
Case in Are We Synapse Yet?: 3PIDs are unbound after account deactivation.

@PiotrKozimor
I am not sure what's wrong with this PR tbh 😅
Seems like I don't actually delete the 3PID association because the Are We Synapse Yet? corresponding testcase still doesn't pass. I've spent many hours trying to figure out how to approach this but the various different tests infrastructures confuse me. I'll bring it up tomorrow on our weekly to get some input about this if possible 🙏🏼

We have one flaky presence test. Reagrding 3PIDs are unbound after account deactivation, it verifies that association was removed from identity server, which is not relevant in our case. However, we might want to extend complement test that will check that one is able to register again with the same email after deactivation.


Change with_stdin to &mut to fix #22

This is a quick fix. I didn't carefully read the code. Please review before merge. Thanks.

Eh, CI is close enough


Add configure option to box

See title.

Has been added to the development branch https://github.com/nraboy/ng-cordova-oauth/commit/2b835ba806f9eec89c59d3c3e3d9b060d403295a
Will be merged with the master when more is added to the plugin.


Is there any roadmap on ROS2 Foxy pipeline?

Sorry, we don't have a pipeline for ROS2

Is it okay to port it to ROS2 for submission for the challenge?

Sorry, we have no plan to port it to ROS2 at least for this year's challenge, but probably in the future.


Credit Screen Background Does Not Match LCE

The credit screen has the dirt background similar to Java Edition. However, LCE uses a special image corresponding to the title update. See images below

This is not an issue, it's a parity suggestion, it will be considered, but I will close it for that reason


Pattern matching the values of two different variables

It isn't possible to pattern match one variable to another in a case statement.
pub fn match_cases() -> String {
  let x = 1
  let y = 2
  case x {
  | y -> "Same!"
  | _ -> "Different."
  }
}

pub fn match_cases_test() {
  match_cases() |> expect.equal(_, "Different.")
}

The test fails and the compiler reports that the variables Y and Y1 are unused.
(Similar issue to #253 but with two different variable names)

Variable in Gleam can be reassigned, so this will not be supported. We will however have something like this:
case x {
| [y] when y == z -> 1
| other -> 0
}

I'll close this issue and track this in the other one. Thanks!


Can't we do this with just runc?

Why does this only work with docker?  Isn't the information you need provided by the runc config?  If we move to ocid in the future I want to make sure we could easily use this hook.
@mrunalp Shouldn't this code work for runc?

when i was relying on docker api, it was a docker-only deal... but now, it could potentially work w/ just runc.  So long as i can get assigned uid & image ID from runc config.json

I believe you can, and then your hook could be used by any container runtime that uses runc.

Theoretically any OCI compliant runtime that supports entering the mount namespace.

@rhatdan @mrunalp I'm not seeing where i can grab the container's image ID/spec w/ runc.  Any ideas?

The issue is that we don't have any image metadata as a first class field in the runc config.json. We have two potential options:

Set an environment variable container=cri-o for the hooks
Set image metadata as annotations in the config.json

Wtih either of these we can use containers/image to get the image metadata from a different location.

Why do you need the image ID?  Isn't all you need the path to the ROOTFS?

I have to determine the user that the image was configured to run as.

So I can do a string replace on the correct passwd entry

If I run a container with uid 3267
docker run -ti -u 3267 fedora sh
$ id
uid=3267 gid=0(root) groups=0(root)

Then I go look in the config.json file generated by docker
 cat /run/docker/libcontainerd/10b639cf59b36f6189b38a67f91a7812e289f3f0a2e9672066c54bfea87e9a15/config.json | json_pp | less

   "process" : {
          ...
      "user" : {
         "uid" : 3267,
         "gid" : 0
      },

   "root" : {
      "path" : "/var/lib/docker/overlay2/fe9a2094f7a41daf59d204fdb35a9f8fbfaa7ca
53ad55c4e43e9063df21c9def/merged"
   },

This gives me the uid and the rootfs to modify the
/var/lib/docker/overlay2/fe9a2094f7a41daf59d204fdb35a9f8fbfaa7ca
53ad55c4e43e9063df21c9def/merged/etc/passwd
file.  What other data do you need?

i need the .Config.User metadata from the image w/ sets the default/expected user at container runtime.
In the case of the fedora image, that would be "", which translates to 0 uid.
Using another image as an example...
$ docker inspect -f {{.Config.User}} registry.access.redhat.com/rhscl/nginx-18-rhel7
1001

$ docker run -tiu 243637 registry.access.redhat.com/rhscl/nginx-18-rhel7 sh
$ cat /run/docker/libcontainerd/17a968bfbb33ef0b22bc83c3012c995b4de7eadd0db3c0472bfe9fe6340c3e46/config.json | json_pp | less

   "process" : {
          ...
      "user" : {
         "uid" : 243637,
         "gid" : 0
      },

Both fields, container and image user, are critical here. Having the image user allows the hook to effect the proper user in /etc/passwd.

Ok I get it now.    So right now docker does not tell runc about this USER Field, if the container creation overrode it?

correct, based on what i've seen.

@rhatdan Yeah, well, runtime spec only cares about the path to the rootfs. It doesn't care about how/where it was created which makes sense from separation for concerns point of view. We can add annotations when we generate the config.json from cri-o.

What does the entry in the /etc/passwd file end up looking like?

in the above example... like this:
default:x:243637:0:Default Application User:/opt/app-root/src:/sbin/nologin

vs the original:
default:x:1001:0:Default Application User:/opt/app-root/src:/sbin/nologin


When a project can't be created the error message should be more informative and the directory cleaned.

root@c1742fb0fdb3:/app# antler-proj init /host/home/alex/dev/projects/AntelopeIO/Clion_DUNE test_proj 0.0.1
"/host/home/alex/dev/projects/AntelopeIO/Clion_DUNE/tests" could not be created: generic:17
Here Clion_DUNE directory already has a symlink "tests"
If creation of the project was aborted all created files and directories should be removed before exit of the program.
Update: In the new update https://github.com/AntelopeIO/antler-proj/pull/22 the error message is much better:
root@c1742fb0fdb3:/app# antler-proj init /host/home/alex/dev/projects/AntelopeIO/Clion_DUNE test_proj 0.0.1
[info_log] :: project.version 0.0.1
[error_log] :: /host/home/alex/dev/projects/AntelopeIO/Clion_DUNE/tests could not be created: File exists

Closing the issue because it is fixed in #22


[Feature Request] Nuki Keypad display authorization code information

As explained on Discord the actual authorization code is not exposed in MQTT topics such as lock/log and keypad/json as a security measure.
It would be great to have an additional checkbox on the "Nuki General Access Control" page which allows the actual authorization code to be exposed.

Note that the code is not available as part of  the authorisation data published in lock/log. Nuki devices don't publish the code there.

Note that the code is not available as part of the authorisation data published in lock/log. Nuki devices don't publish the code there.

Makes sense, keypad/json would be sufficient - don't think there are any other places.


New teams page

converted the teams, events, about and contact-us pages to react

 Here is an overview of what got changed by this pull request:

Issues
======
- Added 1

Complexity increasing per file
==============================
- src/About.js  1
- src/ContactUs.js  1
- src/Events.js  1

Clones added
============
- src/About.js  6
- src/Events.js  8

Clones removed
==============
+ src/components/Navbar.js  -2

See the complete overview on Codacy


GoogleMap : newLatLngBounds() inside mapController.animateCamera() throws __NSArrayM doubleValue

vehicleDetailsMapController
?.animateCamera(CameraUpdate.newLatLngBounds(LatLngBounds(
southwest: const LatLng(21.23755166666667, 72.88526333333333),
northeast: const LatLng(21.251688333333334, 72.89319277777777),
), 100));
I'm experiencing the issue with Flutter on iOS, getting the error:
*** First throw call stack:
(0x18a2e908c 0x1875eb2e4 0x18a3ef7c8 0x18a286888 0x18a2861b0 0x10362986c 0x10362aa78 0x103630060 0x10362fad8 0x1093521e4 0x108dc1794 0x106154a30 0x10615671c 0x106166de8 0x1061669a4 0x18a2bbf64 0x18a2b9188 0x18a2b85b8 0x1d5d4e1c4 0x18ce0e5f0 0x18cebd10c 0x18d1e9e50 0x1025d4c4c 0x1025d4bc4 0x1025d4cc8 0x1afa8bd34)
libc++abi: terminating due to uncaught exception of type NSException

Hi @trushal93, please provide the following information

The version of google_maps_flutter & google_maps_flutter_ios you're using
The full crash log
The steps to reproduce the crash
A complete minimal reproducible code sample
The device(s) you're seeing the crash on and the version of iOS they're using
Your flutter doctor -v output

Thank you


Write Windows batch script version of 'miri' script?

With my Windows PC, I've been running the miri bash script by running
ex. sh miri run tests/run-pass/env.rs.
It's been working because I had Git for Windows installed (which comes with bash.exe & sh.exe)
and I had the sh.exe added in my Path.
Running cargo miri works in Windows, but the miri bash script itself does not work out-of-the-box in Windows. The current method I'm using is more of a workaround, rather than proper support for Windows developers.
I think it'd be nice to have a batch script version of miri script that Windows users can use out-of-the-box, without workarounds.
p.s. if there is already proper support for Windows users to run the miri script, please let me know 😉

I should preface that I have not done any development on Windows for at least 15 years, so I have no idea at all what is considered a normal development environment on that platform.^^
That said, if there is a way to use the shell script we have, that seems like the best option to me. That shell script is maintained as Miri changes, and it is used by our CI, so it should just always work. Sharing code across platforms is better than re-writing things for each platform. Currently, Windows CI (via AppVeyor) does not use it; if you could help use it there that would be great. :D
I suspect most devs will have git installed on their Windows box so your method will work for them?
That said, if you want to submit and maintain a Windows variant of that script, I'll happily review those patches. I just want to avoid having an outdated Windows-only script in the repository that nobody in the Miri team can fix or test.

Why is there a script? Rust executables are far more portable.
Anyway, if you wanted a Windows equivalent, you'd probably use PowerShell.
"Batch files" are woefully outdated and underpowered.

@eddyb well go read it yourself if you want to know what it does. ;)
Note that the rustup distribution contains no script. The script is just for development. It handles building the Miri sysroot (usually done by cargo-miri, but during development you often want to to worectly with the miri driver), working around https://github.com/rust-lang/rust/issues/58343, things like that.

@eddyb well go read it yourself  if you want to know what it does. ;)

I have, it looks like the kind of thing a Rust project would write in Rust :P.

Note that the rustup distribution contains no script.

Okay so this isn't as bad as it could be.

it looks like the kind of thing a Rust project would write in Rust :P.

Fair. ;) I'm somehow still reaching for shell/Python first for such things...
It's not entirely trivial though, since this sets flags for the build it would have to at least be an entirely separate crate from the main thing. And workspaces always seemed too complicated for me...^^

And workspaces always seemed too complicated for me...^^

Every cargo package is at most one lib crate and any number of bin crates, so you wouldn't need a workspace probably - or wait, whoops, do you mean it'd need to be a separate package?

do you mean it'd need to be a separate package?

Yes. In particular it should have an independent set of dependencies. After all this sets RUSTFLAGS for the main compilation.
Now, moving to a workspace would also help with https://github.com/rust-lang/miri/issues/418, but still... so far I couldn't be bothered.^^

That said, if there is a way to use the shell script we have, that seems like the best option to me. That shell script is maintained as Miri changes, and it is used by our CI, so it should just always work. Sharing code across platforms is better than re-writing things for each platform.

I agree with your point :smiley_cat:
I've just learned that the Windows Build environment of Travis CI also uses Git Bash to run builds.
I guess there isn't much motivation to write and maintain a separate batch script.
Adding a single line - windows to .travis.yml should probably suffice to make Travis CI test the build in its Windows Build environment.
https://github.com/rust-lang/miri/blob/acdddc78bc738786e3992377a0d1378c071d8579/.travis.yml#L10-L12
Thank you for your feedback! I'm closing the issue now :sweat_smile:

We've experimented with using Travis for Windows CI in the past and it didn't really work. Maybe it got better since then.

With https://github.com/rust-lang/miri/pull/1407, we are now using bash miri for our Windows CI, and it actually Just Works (TM). So this should also be an option for developing on Windows (AFAIK a bash comes with git, so I assume most developers will have one).


UIImage extension

I am digging through the repro still, but is there a way to just set a UIImage from a URL with the callback? I do not need to set an image view in this stage.. I could make a fake imageView, but I thought I would ask about it anyways.
Best,
Matt

Maybe you can see this.


scalafmt

This PR uses scalafmt to format every source file and adds a check. the configuration is the same as for the 3.x branch

Great, I am sure it will be helpful to all contributors


feature: adding email validation on login

During login even if i enter a invalid email address it still processes the request. The same issue is with the 100xdevs website too on email and mobile number for otp we can add frontend validations for those feilds. For this we can use react hook forms or just using some variable.

It also works with phone number. so, email only validation doesn't sounds too good.
It might be rare but there are people who login with they phone number

For number also although it check for the type number but  we can enter more than 10 digits and it still sends out the request.

then a frontend validation would be fine for phone number then

I have came up with the solution for this issue.
Solution:

Created a validation function that validates if a input is valid email or a valid phone number.```
function isValidEmailOrPhone(value: string) {
if (value.length === 10 && !value.includes('@')) {
const re = new RegExp(
'^(\+\d{1,2}\s?)?\(?\d{3}\)?[-.\s]?\d{3}[-.\s]?\d{4}$',
);
console.log(re.test(value));
setEmailValidationError(!re.test(value));
return;
}
const re = new RegExp('^[a-zA-Z0-9._%+-]+@[a-zA-Z0-9.-]+.[a-zA-Z]{2,}$');
console.log(re.test(value));
setEmailValidationError(!re.test(value));
}

We have some users that dont follow any format so wil have to skip this one altho its a good one

Hi @hkirat I have made the changes for this enhancement

Added react-hook-form in login component
Added email validation regex that is /^[^\s@]+@[^\s@]+.[^\s@]+$/
Marked Email and Password as required field

The demo has been attached for your reference
Thanks
login.webm

Hi @hkirat I have made the changes for this enhancement

Added react-hook-form in login component
Added email validation regex that is /^[^\s@]+@[^\s@]+.[^\s@]+$/
Marked Email and Password as required field

The demo video has been attached for your reference
Thanks login.webm
Shall I push the changes ?

Yooo... Watch his reply.

We Can also disable the login button until both email and password fields are valid. In this way we can avoid un necessary api call for invalid credentials

@Pratish10 read the thread again!!! It's not as simple as adding validation for email.

@SujithThirumalaisamy , Would like to know if gmail signin/signup  would be a good enhancement ?

@SujithThirumalaisamy , Would like to know if gmail signin/signup  would be a good enhancement ?

It might be. IMO.


not "remove" inline style chars

I got the point of hiding some stylizing chars on preview, so `code` -> code when not editing that line.

It's real nice.
But this also make some work with thing a bit wonky, specially in tables
Where some text changes size, and get misaligned.

I aware of the potential awkward extra spacing, but maybe could it be that those char could only be replaced by blank ones, so spacing remains?
Or any otter ideas here.
Maybe prevent that only inside tables?!
Some example of what i'm talking:

Code block hide the ticks, but dont collapse de line, giving it an extra "border" on top and bottom.

Quotes change the char/symbol, but spacing remains the same.

That hiding of characters is not from headlines.nvim. That is Neovims build in :help conceal and treesitter.


Input perturbation by increasing the noise strength

Hi @forever208 ,
Great work! I like your observation of the inconsistency between training and sampling and propose a simple input perturbation to mitigate/align it. A question about your implementation code.
new_noise = noise + gamma * th.randn_like(noise)  # gamma=0.1

I understand this equation as increasing the noise strength because the new noise is essentially two Gaussian noises added with weight 1 and gamma. Thus the resultant new_noise is a gaussian noise scaled by (1+gemma)
If so, can I understand the input perturbation as interpolating with a larger noise?
Thanks,
Zhangzhi

hi @pengzhangzhi, thanks for your comments and insightful observation, yes, you can understand input perturbation as interpolating with a larger noise, but the training target, in this case, is a scaled epsilon.
We actually derived an equivalent loss for input perturbation (IP) below

Treating $\bar{\beta_t}\sqrt{1+\gamma^2}$ as a whole, this term becomes the new noise schedule and it is larger than the original noise schedule $\bar{\beta_t}$
from which, we can interpret IP as training the reverse diffusion using a larger noise schedule $\bar{\beta_t}\sqrt{1+\gamma^2}$, but the target is scaled epsilon which differs from epsilon

Thanks!! I like this idea, super neat!  Anywhere I can read about the loss from the code?

@pengzhangzhi do you mean the equivalent loss I showed above? It is not implemented in the released code, but I personally tried it, and the results are equivalent to input perturbation.


Aggregate data in a specific column

Hi,
I saw #17 explaining how to use kind="values and x_range in order to use aggregated data, but I'm finding it hard to combine this functionality with setting a specific column for output.
I've got a dataset with a set of locations (lat & long) with measurements taken at each point giving a numerical value.
     lat        long        val

    001.012    001.01        11

    001.431    004.49        25

    001.769    008.72        04

    002.100    001.32        03

    002.504    003.49        17

    ...

(rubbish formatting but it gives you the right idea)
I've binned the y-values (lat) using pd.cut to give a lat_bins column and plotted this using:
fig, axes = jp.joyplot(df, by="lat_bins", column="long")
But what I'd like to have is something like:
fig, axes = jp.joyplot(df, by="lat_bins", column="long", kind="values", x_range=<some range>))
This displays a plot without any data; and no error appears when running the code so I don't know what to fix. The goal is to have a plot at each latitude showing the distribution according to longitude. (i.e., the dataset shown above would have the first layer showing 11 - 25 - 4 going across from 001 to 008 lat.

Hi! Not sure I fully understood what you want to obtain here.
One thing I can say, though, is that kind="values" is not meant to be used with "by" - it's meant to be used only if you want to do all the binning yourself (and no smoothing will be done by joypy).
So you would need to have a dataframe with lat_bins as rows, and lon_bins as columns, with the grouped val in the cells. Does it make sense?
Example with iris (just renamed the columns to be similar to your case):
%matplotlib inline
df = iris[["SepalLength","SepalWidth","PetalLength"]].copy()
df.columns = "lat", "lon", "val"
df["lat_bin"] = pd.cut(df.lat, 10)
df["lon_bin"] = pd.cut(df.lon, 10)
grouped = df.groupby(["lat_bin","lon_bin"])["val"].sum().fillna(0).unstack(1)
joypy.joyplot(grouped, kind="values", x_range=[0,10]);

Then you're going to need to do some work to manually fix the x and y ticks as you prefer.


Missing callstack in error

In the cli.js there is such code:
    .fail((msg, err, yargs) => {
      debug(err);
      yargs.showHelp();
      console.error(`\n${symbols.error} ${ansi.red('ERROR:')} ${msg}`);
      process.exit(1);
    })

When this code handles the error it does not print error callstack. So I getting output like this:

Such output does not help to localize the problem. I spent hours to debug - where problem is by removing lines of code one by one.
I have some project configuration with babel, and I have no time to make minimal reproducing example, but in my project all errors in loading tests are handling with this code. It is very frustrating.
Please, change code to smth like this:
 console.error(`\n${symbols.error} ${ansi.red('ERROR:')} ${msg} \n${err && err.stack}`);

Versions
$ mocha --version
7.1.2
$ node -v
v12.16.1
OS: Windows 8.1 x64
Shell: MinGW

I don't know where Cannot read property 'get' of undefined comes from.
You can see call stack by setting DEBUG environment variable as DEBUG=mocha:cli:cli or DEBUG=*.
We don't want to show call stack to every user because it only needs to debug.


Authentication API using NodeJS

Prerequisites

[X] I am a GSSoC-22 Participant
[X] I checked to make sure that this issue has not already been filed

Description
A simple registration and login authentication API . The user's credentials will be stored in a MongoDB database. An OTP will be sent to the user's email to check if the email is valid or not. If login details are not found then the user is told to register. If the detains are found, then user can go to the homepage.
@heet-kumar @manisha-27 @abhijeet007rocks8  Please assign this issue to me.
Tech Stack
NodeJS

@abhijeet007rocks8 @heet-kumar @manisha-27
Please assign this issue to me.

@abhijeet007rocks8 , please assign this issue to me


PyPerf demangling c++ symbols - module update

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots

Checklist:

[ ] I have read the CONTRIBUTING document.
[ ] I have updated the relevant documentation.
[ ] I have added tests for new logic.

I will go over the failures, I think they are all flakiness. Will add flaky ones to https://github.com/Granulate/gprofiler/issues/462.
If all are flakiness I will merge this now

BCC PR https://github.com/Granulate/bcc/pull/37

These are all flaky. I am merging


Added support to tablet HUION h320m id 256c:006d

@joseluis please merge this branch

Thanks, added


Trailing newline on every message/warn/fail on Bitbucket Cloud

Hi!
I've been trying to use endanger on our projects on Bitbucket, but it seems like there is an extra \n or new line at the end of every message, even if there wasn't any on the  as can be seen on the image below.

Is there a way to remove those trailing new lines?
source code:
...
      messages: {
            missingPrefix: "{where} não está marcado com um prefixo válido. Deve iniciar com 'bugfix/', 'feature/' ou 'hotfix/'.",
            prefixThanks: ":thumbsup: Obrigado por colocar o prefixo correto no título da {where}.",
            hasCard: ":thumbsup: {where} contém um card do Jira",
            doesntHaveCard: `{where} não contém um card do Jira no formato '<prefix>-<number>'. Exemplo: 'CA-123'`,
        },
...
                    context.message("prefixThanks", {}, {where: where})
...

I'm not entirely certain where it's coming from, but I suspect it's actually from danger.js itself with the fail(), warn(), and message() globals it provides that I'm using here: https://github.com/discord/endanger/blob/master/src/run.ts#L96-L104
It might be adding newlines at the end, I'm not sure.
The only other place it might be is in the formatReport() method, I'm using IntlMessageFormat to add the message syntax. It could be doing something I don't expect in there: https://github.com/discord/endanger/blob/master/src/utils/formatReport.ts#L113

I believe it can be this formatReport() method, considering that I am using the danger js methods with no newlines, and only by using the context.[method] those newlines appear

Is it possible to create a new release so that this change can be used?


Around the globe dots cut the world

Hey folks, steps to reproduce:

Create map
Place a Polygon layer with following coordinates ([-179, 79], [179,-56])
Render map

Expected: a straight line is drawn from top to bottom of the globe
Actual: Globe is crossed
Sample code:
const dataSource = new atlas.source.DataSource();
    map.sources.add(dataSource);

    //Create a rectangular polygon.
    dataSource.add(new atlas.data.Feature(
        new atlas.data.Polygon([[
            [x1, y1],
            [x2, y2]
        ]])
    ));

    //Create and add a polygon layer to render the polygon to the map, below the label layer.
    map.layers.add(new atlas.layer.PolygonLayer(dataSource, null,{
    }), 'labels');

Screenshot (red - expected, blue - actual)

Could you please drop a few lines why Polygon is drawn across the globe, and if that is correct?
Thanks <3

In this case the polygon you are providing is not a valid Geojson polygon and thus causing rendering issues. Polygons should have three unique positions at a minimum, and ideally have a fourth position that is the same as the first position to close the polygon area.

Fair comment, bringing it up to four points gives us a good shape:
    dataSource.add(new atlas.data.Feature(
        new atlas.data.Polygon([[
            [x1, y1],
            [x2, y1],
            [x2, y2],
            [x1, y2]
        ]])
    ));```

So that is a proper one, right?

![image](https://user-images.githubusercontent.com/14172414/212682904-494e2ba3-aab7-42f3-95d9-d1a12784a42b.png)

I'm asking cause there is a follow up question - bounding box and camera bounds:
positioning.bounds = AzData.BoundingBox.fromData([one, two]);
map.setCamera(positioning);
The map is centered within the gap instead the center of the box we agreed to be correct:

The situation does not change should we shuffle the props (assuming most southwesterly is in the play).
So it seem the bounding box API cannot tolerate values supplied, am I right?

Nearly, the first and last positions should be the same to "close" the polygon. For example:
dataSource.add(new atlas.data.Feature(
        new atlas.data.Polygon([[
            [x1, y1],
            [x2, y1],
            [x2, y2],
            [x1, y2],
            [x1, y1]
        ]])
    ));

That said, it should be noted that the GeoJSON specification states that polygons should not cross the anti-meridian and instead cross the entire globe. Crossing the anti-meridian is known as world wrap which polygon rendering doesn't support directly in the MapLibre rendering engine used in Azure Maps, however there is a workaround.
For example, a polygon like this:
{
	"type": "Feature",
	"properties": {},
	"geometry": {
		"type": "Polygon",
		"coordinates": [
			[
				[-179, 85],
				[179, 85],
				[179, - 85],
				[-179, -85],
				[-179, 85]
			]
		]
	}
}

would cover nearly the full globe with a sliver of space near the anti-meridian. However, you can use longitude values outside of the -180/180 range. For example, this is a modified version of the above polygon (one edge is offset by 360 degrees):
{
	"type": "Feature",
	"properties": {},
	"geometry": {
		"type": "Polygon",
		"coordinates": [
			[
				[-179, 85],
				[-181, 85],
				[-181, - 85],
				[-179, -85],
				[-179, 85]
			]
		]
	}
}

The sliver of a polygon would be rendered (minimal polygon area).
The camera however supports world wrap and correctly calculates the centroid of the minimal bounding polygon.

@rbrundritt  I agree with all aforesaid, polygons work well, thanks <3
As of now we also align on camera relying on minimal bounding polygon over following most southwesterly convention.
In order to give a little bit of context/(nature of the question).
I'm projecting data over the world (Azure WAF logs -> Client IPs -> Coordinates), and customers are able to pick 2 point (bounds to be displayed).
I, as a customer, would like to have US & Europe & Asia to be in focus, so I roughly click on Alaska & New Zealand.
While the viewport is produced using the smallest/(minimal bounding) polygon which shows the part i'm not interested.
The most obvious solution is to pick 2 coordinates North/South pole, in the middle of the viewport (somewhere at a Greece level) to get the smallest zoom and camera on Greece, however that feels as a hack.
Therefore we are drifting towards:

Polygon is fine
Camera viewport out-of-the-box uses minimal (violating most southwesterly idea)
Straightforward use-case leads to opposite to expected outcome

And here is the final question - Is there a way to force camera positioning work as polygon?
Thanks.


Warning test authors?

Reading #411 one can see that it might be sometimes necessary to warn test authors about what they might be doing wrong. After inspecting the codebase, I couldn't find any mechanism used in QUnit to do this useful task.
Facebook's react offers this functionality through the warning [function] (https://github.com/facebook/react/blob/4d9561d9385d6efa97f2e3ecdf5caad292611aa6/src/vendor/core/warning.js). It also offers an invariant violation warning whenever necessary with the invariant [function] (https://github.com/facebook/react/blob/2aeb8a2a6beb00617a4217f7f8284924fa2ad819/src/vendor/core/invariant.js). In order to make our warning system more powerful, it should be great if these warnings could be shared with reporters, so that they could be shown to the test author more naturally.
Do you guys think that something like this could be useful?

It looks like React's warning function is mostly a wrapper around console.warn, with some project-specific baggage. Seems like something we could do when necessary. For the particular issue you point to, #411, it seems like that should be handled as a bug in QUnit, not as a bug in user code. If there are usecases where warnings are actually needed, I'm happy to review that as part of those issues.

I'm sorry, what I meant citing #411 was not the issue itself but @Krinkle 's comment https://github.com/jquery/qunit/issues/411#issuecomment-17523633. He asserts that the user should be warned if a primitive value is passed to propEqual.
In addition to this, as I said, it could be great if the warning info was somehow shared with the reporter so that it was shown to the user no matter what environment they may be executing their tests on.

Ah, gotcha. Though he wrote "perhaps". Probably the more important part was this: "But treating them as strings instead of objects would be masking an error by the test author. I'd like to get this removed from deepEqual as well.". Anyway, that discussion should happen in #411.
I currently don't see the need for a warning system. We should fix bugs in our code and treat issues in user code as failures.

Closing due to inactivity.


sticks version not sticks -v

#28  👈
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @mAmineChniti and the rest of your teammates on  Graphite


Fixes for v0.7/1.0

And bump to v2.8.1

Supersedes #85

Coverage increased (+16.3%) to 96.296% when pulling 00a3a08b731eae7b581cb3197b3881648ebc5429 on RA/fix into 306aa8f3837071e6e5f9837297a161b338c3f52d on master.

Fails because BinDeps hasn't been ported to 1.0 yet


Result of To-date is  Not sorted under View User activity log, Login records and Transactions Page(Agent Panel)

Describe the bug
When we Select To-date and From-date from the Calendar under View User activity log, Login records and Transactions Page then the data of Selected to-date is not visible in a Table of each Page.
Steps to reproduce the behavior:

Go to 'https://www.pulseptt.com/agent.html'
Login with valid credential:- 1' User name: john 2. Password: 12345678.
Navigate to Personal Center.
Select View User Activity Logs.
Select From-date:- 2.3.2022.
Select to-date:- 29.3.2022.
Click on Search Button.
See error.

Expected behavior
The data of selected To-date must be sorted.
Screenshots

Desktop
OS: Windows 10
Browser :Version 100.0.4896.60 (Official Build) (64-bit)
Version [0.1.1]

This Issue is not Completely Resolved. Same issue on "Transaction" Page still exist.

Build:-  <IP_ADDRESS>

Now issue resolved on all the pages.

Issue not Resolved.

I have pushed the modified code and it is working from my side.

This Bug has Resolved on View User activity log and Login records page but not on Transaction Page. Right now on Transaction Page 'Search button' is not working.

Please Check now it is working.


Crash at specialized SKPhotoBrowser.__allocating_init(photos:initialPageIndex:)

I'm getting many crash reports that look like this:
Exception Type:  EXC_BREAKPOINT (SIGTRAP)
Exception Codes: 0x0000000000000001, 0x0000000101d52744
Termination Signal: Trace/BPT trap: 5
Termination Reason: Namespace SIGNAL, Code 0x5
Terminating Process: exc handler [406]
Triggered by Thread:  0
Thread 0 name:
Thread 0 Crashed:
0   SKPhotoBrowser                	0x0000000101d52744 specialized SKPhotoBrowser.__allocating_init(photos:initialPageIndex:) + 928 (:0)
1   SKPhotoBrowser                	0x0000000101d52590 specialized SKPhotoBrowser.__allocating_init(photos:initialPageIndex:) + 492 (SKPhotoBrowser.swift:0)
2   SKPhotoBrowser                	0x0000000101d4bb88 SKPhotoBrowser.__allocating_init(photos:) + 24 (:0)
It is happening on iOS 13 and iOS 14 with both iPhones and iPads, right after calling SKPhotoBrowser like this:
let browser = SKPhotoBrowser(photos: images)
It doesn't appear to be a low memory issue, as there's plenty of free RAM on the devices when it happens.
Is anyone else seeing this?

Managed to reproduce while in the debugger. The crash happens on line 88 of SKPhotoBrowser.swift:
animator.senderOriginImage = photos[currentPageIndex].underlyingImage
Thread 1: Fatal error: Index out of range

Could it be cache invalidation causing currentPageIndex to go out of range? Line 85 calls checkCache:
self.photos.forEach { $0.checkCache() }

After futher investigation, it appears the fault is in the image caching framework and not SKPhotoBrowser. Closing this bug report.


new icons for attestations

Closes #<GH_issue_number>
Description of the Problem / Feature
add new icons for attestations
Explanation of the solution
update communities.json seed script

no longer needed


Implement eth_getProof

Now that EDR is out, we should consider adding support for this RPC method. We didn't want to add it to Hardhat Network to avoid expanding the scope of the first EDR release, but this changed now.
Also, eth_getProof may be simpler to implement now, with a different state manager (when compared to ethereumjs).

Closing as this is a duplicate of https://github.com/NomicFoundation/hardhat/issues/3345


Get coordinate on click

How can we get the cursor coordinate using the onClick event on the map?
Here is how I'm trying:
_onClickMap(e) {
        console.log(e.lngLat);
    }

render() {
        return <div>
            <Map
                style="mapbox://styles/mapbox/outdoors-v10"
                containerStyle={{
                    height: 400,
                    width: "100vw",
                    marginTop: 60
                }}
                center={[-104.99, 39.75]}
                zoom={[9]}
                onClick={this._onClickMap}/>
           </div>

I would expect to be able to access the lngLat property similarly to this example: https://www.mapbox.com/mapbox-gl-js/example/mouse-position/

Almost that, sorry it is not clear in the documentation, here is what you need:
_onClickMap(e, map) {
  console.log(map.lngLat);
}

Thanks!!!

Could this be implemented in Kepler Gl? Do you have any guide in where should I add this?

Cool

how do i get only the longitude or the latitude?

Just read out the property you care about from evt.lngLat @SanHolo101

Thanks, You save my day


s/to/two in basics

skimming the docs and stumbled on this.  Cool library!

Good catch, thank you!


Errors after upgrading to Forms 4.2.x

I'm seeing this in the output:
Xamarin.Forms.Xaml.XamlParseException: Position 1:1533. An element with the name "_punchCard" already exists in this NameScope.
Downgrading to XForms 4.1.x solves the problem.

I logged a related issue on Forms for this https://github.com/xamarin/Xamarin.Forms/issues/7685

@InquisitorJax don't think they will fix it since there is official hotReload

@AndreiMisiukevich ... I think this is breaking the official hot reload as well

@InquisitorJax ah, got it.
I need to find a little time and update my HotReload.
BTW, i am going to remove "code reloading". Because it piece of s...t

Going to close this ticket, since the same issue occurs on the official hotReload


New search alert receivers and routes

This removes the old MVP search alerting receivers and routes, and adds two new Slack receivers with appropriate routing rules:

A search-slack-warning receiver for minor or developing issues that goes to our team's alerts channel
A search-slack-critical receiver for major issues that goes to our team's main channel

Both of these are configured to group all ongoing alerts into a single notification to avoid excessive messages, and are generic to any alert unlike before (taking alert data from the alert's summary and description annotations).

@csutter sorry this has been reviewed by the team yet. Just checking is this PR still needed/need updating, as its been quite awhile?

@theseanything As on the other PR, will revisit this in the future and close this so it's out of the way!


RT4148

Accept leading 0-byte in PKCS1 type 1 padding. Internally, the byte is
stripped by BN_bn2bin but external callers may have other expectations.

@kroeckx - want to take a look?

+1

Merged.


All data formats - how to handle multi-row header?

Dup of #100. And not an iteration 12 issue anyway.


gb build is actually gb install

I know of the persistent advice of "use go install" when "go build" doesn't do what people expect... But "go build" does what I expect, or in certain cases GOBIN=something go install does it better.
I was hoping that gb build would do the right thing (in my opinion) by placing the build artifact in the current directory, so that I can tar it up etc as part of a build process. However in actuality it ends up in ../../../../bin, which is an annoying place to go looking for build artifacts.

Sorry this is a design decision.
gb always works on projects, and all packages and binaries produced are scoped by a package, so they end up in $PROJECT/pkg and $PROJECT/bin respectively.
I also took the opportunity to return the build command to what every beginner gopher expected it to be ( and then we have to have the confusing chat that build builds and throws away, etc )
gb doesn't support GOBIN and this won't change in the future, but because gb works on projects, your binaries will always be in $PROJECT/bin.

Is the expectation that a repo should nowadays have a structure with a README, top level src directory, etc? I tried that, with a repo that is anyway under my $GOPATH, and there was unhappiness but I may have screwed up.

i'd suggest making a new gb repo for your project
mkdir -p ~/projects/demo/src
cd ~/projects/demo
~/projects/demo is your $PROJECT

Yeah, I realized. For my existing project, which is github.com/syncthing/syncthing, that would mean a repo syncthing in ~/projects/syncthing and that repo would then contain src/github.com/syncthing/syncthing/cmd/syncthing (etc) and the build command would be gb build github.com/syncthing/syncthing/cmd/syncthing which is somewhat cumbersome. Or is the intention that I move to a not "fully qualified" package name, as the repo is anyway no longer go-gettable?

gb projecs are not "go gettable" so there is no requirement to maintain the full fdqn structure in your code. You can keep it for simplicity if you like, or you can restructure your code, something like this
~/projects/syncthing/src/cmd/syncthing
and so forth

Reasonable. I'll give it a try, and see what I can do about that plugin.


React slick dynamic not working with first element

Hello,
I have a button who delete the current item display in my slider (Item active is stored in redux)
<button onClick={e => this.deleteListing(e)}>{text.labels.BUTTON_NO}
deleteListing() {
const { listingActive } = this.props
this.props.deleteListing(listingActive)
}
//------- Slider -----
Here is my slider with settings :
<Slider ref='slider' {...settings}>
{items.map(item => (
this.displayItem(item)
))}

const settings = {
dots: false,
infinite: true,
speed: 500,
slidesToShow: 1,
slidesToScroll: 1,
afterChange: (index) => {
const itemActive = store.getState().item[index].id
store.dispatch(updateItemActive(idActive))
},
}
When i delete all elements other than first all works, the methods afterChange is called and the item active is setCorrectly
But when i delete the first element, the afterChange is notCalled and the slider can't delete the newCurrent element
Do you have any suggestion ?
Thanks

That sounds like a bit complex situation, could you create a codesandbox demo for the same?


Update README.md

@christ1ne and @guschmue, please review and update the documentation -- specifically about the "Running Benchmarks" section where machine details etc. could be improved.

I signed it!

@christ1ne thanks for the specs. updated it.


Removing CORS hack and adding a proper middleware for handling CORS headers

Description
Remove CORS headers hack and use a proper middleware for handling the CORS headers.
Fixes #24
Type of change

Bug fix (non-breaking change which fixes an issue)
Refactor (refactoring code, removing useless files)

Testing steps
Regular CI

Codecov Report

Merging #42 into master will increase coverage by 3.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #42      +/-   ##
==========================================
+ Coverage   30.46%   33.49%   +3.03%
==========================================
  Files          10       10
  Lines         627      627
==========================================
+ Hits          191      210      +19
+ Misses        411      393      -18
+ Partials       25       24       -1

Impacted Files
Coverage Δ

server/server.go
46.35% <100.00%> (+9.89%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9d3a80...e41dc51. Read the comment docs.


How fast is the real-time loading speed?

I have a mount of data(about >=5 million,Up to 100 million).And the area polygon has many points,now I use tilestrata + postgresql to rendering geo data ,but only can zoom to 13level and the speed is not ideal.，I want to know whether martin can solve my problem（real time rendering  big geo data）
Forgive my poor English level，hope  you can understand me。
Any Help will appreciated！

Hi @yh371174229! I didn't benchmark marting with tilestrata yet. If you use tilestrata-postgismvt the speed may be about the same as both martin and tilestrata utilizes PostGIS ST_AsMVT function for generating tiles.
I'm closing the issue for now, maybe I'll run some benchmarks later.