Make auto-rotate rate of rotation configurable

When enabling auto-rotate, users may desire to:

Change the rate of rotation to some specific value
Reverse the direction of the rotation

We should add a configurable attribute to set the rate of rotation in order to support these use cases.

any news on when this might be available?

It's been on the back burner for quite some time, so thanks for pinging. Can you tell me about your use case?

Thanks!
Flipping the rotation direction is all we need at the moment.
Some clients have their logo on one side of their product which is a great starting position. But the current rotation makes it then rotate to the back of the product from that position.
Any quick way to flip the rotation direction?

There's not, but this should be a simple attribute to add. I'll try to get this in the next release.


Mock openai.Client

To test the behavior of the chat bot, we may have to apply a mock of openai.Client.
I have no idea how sashabaranov/go-openai provide mocking features.
Without mocking, the chatbot is completely untestable.

https://github.com/sashabaranov/go-openai/blob/c6a63ed19aeb0e91facc5409c5a08612db550fb2/client.go#L16-L21
Client is struct but ClientConfig, utils.RequestBuilder is interfaces and createFormBuilder is a function type, thus it can be mocked.


Update CONTRIBUTING.md

I changed the list numbering format to {#}: to stop Markdown re-starting the list.

Before

After


fix error message for issue 298

@ChristianLangmann could you please run ./gradlew spotlessApply test to format the source code and push the code again? Maven compilation won't succeed without formating the code. More here in the contribution guide. Thank you!


Unable to build Project-Serum Stake Program using Anchor

I am getting this error and not able to figure out how to resolve this.
C:\Users\varun\stake>anchor build --verifiable
Error: Unable to deserialize config: missing field provider at line 1 column 1

Please move this to the correct repo.


Is it possible to launch puppeteer from within a browser?

Puppeteer version: Latest
Platform / OS version:  Windows 10
Node.js version: 10.16.0
Hello! I'm working on a web application which scrapes a website using puppeteer and cheerio. I have the local version running fine, but when I bundle the app and use it as the "src" in the HTML for a local server, it throws errors pointing me to the "puppeteer.launch" call. I can go into more detail, but I suspect the issue is that I am trying to launch puppeteer from within an existing browser.
Is that something that I am able to do with puppeteer? I discovered puppeteer.connect in my research, but it doesn't seem like that would fit my needs for an automatic scraping application which scrapes a website for certain data based on the user's input.
I apologize for asking a question which may not be an issue with puppeteer itself, but there isn't an appropriate place for me to ask on stackoverflow (my question was marked as off-topic there), and I can't find the answer anywhere else.
Thank you for any suggestions you have! Again, sorry for the bother. <3

Is that something that I am able to do with puppeteer?

@celynjacobs No, you can't launch a browser from-within a browser. This would be a huge security vulnerability, making the whole web a very unsafe thing :-)
So please stick to the node.js if you want to launch browsers!

I apologize for asking a question which may not be an issue with puppeteer itself, but there isn't an appropriate place for me to ask on stackoverflow (my question was marked as off-topic there), and I can't find the answer anywhere else.

No worries, this is a right place to ask questions!
Cheers!

@aslushnikov thanks for letting me know! Is there any way then to make a web app in Javascript that can automatically click a button on a website (as opposed to simply scraping the html) when a user inputs the target URL? Again, sorry to bother you!

Is that something that I am able to do with puppeteer?

@celynjacobs No, you can't launch a browser from-within a browser. This would be a huge security vulnerability, making the whole web a very unsafe thing :-)
So please stick to the node.js if you want to launch browsers!

I apologize for asking a question which may not be an issue with puppeteer itself, but there isn't an appropriate place for me to ask on stackoverflow (my question was marked as off-topic there), and I can't find the answer anywhere else.

No worries, this is a right place to ask questions!
Cheers!

Not to revive an ancient ticket, but I was also looking into this and I think you completely missed the intention here. The need is not to "launch a browser from within a browser". The need is for a "high level" javascript API to control a web app or web page "as a user would". We can already do this with javascript of course from a different iframe (same origin) but its not easy, its not high level and why re-invent the wheel?
If puppeteer could be installed via npm and bundled into a webapp (e.g. as an instrumented test automation version for example), where it can auto-pilot the webapp or web pages, that would be a very useful thing in line with what puppeteer is 98% already doing.


False positive for contexts stored in structs

Love the concept, but I got stung by a false positive involving a struct that contains a context. (Yeah, yeah, I know that's not preferred.) I can repro by adding either of the following to the test:
    var c = struct { Ctx context.Context }{ctx}
    for i := 0; i < 10; i++ {
        c := c
        c.Ctx = context.WithValue(c.Ctx, "key", i) // here
        c.Ctx = context.WithValue(c.Ctx, "other", "val")
    }

    for i := 0; i < 10; i++ {
        var c = struct { Ctx context.Context }{ctx}
        c.Ctx = context.WithValue(c.Ctx, "key", i) // here
        c.Ctx = context.WithValue(c.Ctx, "other", "val")
    }

My actual case is more like the first, but the second is more clearly a false positive. It looks like this comes down to not recognizing this as a case that breaks the chain, continuing due to t.String() != "context.Context" instead of breaking due to assignStmt.Tok == token.DEFINE. But solving this seems like a bear, especially as a syntactically very similar case should likely still be reported:
    var c = &struct { Ctx context.Context }{ctx}
    for i := 0; i < 10; i++ {
        c := c
        c.Ctx = context.WithValue(c.Ctx, "key", i) // want "nested context in loop"
        c.Ctx = context.WithValue(c.Ctx, "other", "val")
    }

I can't look today but let me know if you'd want me to attempt a solution. My guess is that pass.TypesInfo's Defs and Uses could disambiguate these, at least if filtered by appropriate levels of indirection in their containers.

Hello @MichaelUrman 👋🏻
Thank you for your report and coming up with test cases. I don’t have much free time now to come up with a solution myself but I’d be glad to review a PR, should you send one 🙂

I found enough time to give this a shot. The added complexity seems within reason to me, so I opened a PR. I leave the assessment of the additional complexity and the choice to you. (I won't be offended either way!)

func WithContext(ctx context.Context) SqliteChatMessageHistoryOption {
	return func(m *SqliteChatMessageHistory) {
		m.Ctx = ctx
	}
}

this apparently is picked up by this linter so this may still be an issue

Looks like it’s working as expected: https://github.com/Crocmagnon/fatcontext/pull/9/files#diff-6cae0614464d2fe2003259c4f94f3e5d25c1c661c1c3e4a0dd28e27e93df93d0R58


What is the specific use cases of FirebaseObjectObservable Vs. FirebaseListObservable?

Heyy @davideast and @jeffbcross
It seems to me thhat FirebaseListObservable is more fancy/useful/utility (not sure what is best to describe) than FirebaseObjectObservable. it's because with FB List Obs we can get 'push id'. We can also get entire list of items. We can also update and save data just like how we can with FB Obj Obs.
In short, everything we can do with FB Obj Obs can be done with FB List Obs. So may I understand what is the specific use cases for one to use FirebaseObjectObservable?
Cheers,
Jek Bao :)

You shouldn't be creating these observables yourself, they are just
returned from database.list() and database.object(). List is concerned with
many of the same kind of object, and provides mutation method appropriate
for lists, whereas object is a single object with methods that make sense
for an object.
On Wed, Jun 1, 2016 at 7:37 PM Jek Bao CHOO<EMAIL_ADDRESS>wrote:

Heyy @davideast https://github.com/davideast and @jeffbcross
https://github.com/jeffbcross
It seems to me thhat FirebaseListObservable is more fancy/useful/utility
(not sure what is best to describe) than FirebaseObjectObservable. it's
because with FB List Obs we can get 'push id'. We can also get entire list
of items. We can also update and save data just like how we can with FB Obj
Obs.
In short, everything we can do with FB Obj Obs can be done with FB List
Obs. So may I understand what is the specific use cases for one to use
FirebaseObjectObservable?
Cheers,
Jek Bao :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/angular/angularfire2/issues/202, or mute the thread
https://github.com/notifications/unsubscribe/AAcTV1DYYVX_cyxJ-ikZQh8fOHv2TbL2ks5qHkHbgaJpZM4IsJzH
.

Hey @jeffbcross
I'm understanding you a bit here. Allow me to go deeper for my understanding. Why would anyone want to use database.object() if database.list() could use to create, read, update, and delete on a list and also on an object in a list.
Whereas database.object() could only deal with an object only. So what are instances / data structure instances that people would use database.object() over database.list()?
I'm not sure if I'm making sense here with my question. New to AngularFire2.
Regards,
Jek Bao

Hey @choopage,
I use database.object() when I'm working on one single object.
Let's say you have a blog and it has numerous posts that you edit via a form:
database.list() would be a good fit to enumerate the blog posts into a list via *ngFor.
database.object() would be better to edit each individual object (depending on what your UX goals are).
If my edit form is on another route and I want to keep things simple, I can pass an object's key from the database.list() via routeParams into the editComponent and only have the editComponent work on one specific object. In some of my development, this structure has made the most sense in terms of separating concerns (listing as opposed to editing for example).
There may be other times when you want to edit many items at once like you would on a more tabular data (say a spreadsheet style app). This will be where you'll leverage the power of database.list() over database.object() as it can manipulate items in its list without the extra overhead of a FirebaseObjectObservable in addition to the already present FirebaseListObservable.
This is just a simple use case, I'm sure someone else can chime in with some more sophisticated examples.

Hi @pmenocal
Wow perfect explanation. Thank you so much.
This is gold. Helped me understand it all.

If my edit form is on another route and I want to keep things simple, I can pass an object's key from the database.list() via routeParams into the editComponent and only have the editComponent work on one specific object. In some of my development, this structure has made the most sense in terms of separating concerns (listing as opposed to editing for example).

You nailed it. Fully understood it now.

so there is no way to use own typings wen using FirebaseListObservable ?


Fix/issue-69: not creating user if doesn't exist except init call

In this PR, I have removed user creation if the user doesn't exist and now instead error message: user not defined is thrown. The user can only be created via /init call. The following calls /mark,   /assign,   /useraliases,   /datalog,   /bloblog,   /failed  is now devoid of user creation( if not exist).

@YashilDepani I can still see the user is being created from the below 2 calls
1. /groupmembership
2. /workinggroup

Are we going to keep user creation for this calls?
We also need to add /init API in the client library to call backend.
CC: @VivekFitkariwala  @nirmalpatel

I am not sure about these two calls, can anyone let me know what to do for these calls?

groupmembership
workinggroup

I am not sure about these two calls, can anyone let me know what to do for these calls?

groupmembership
workinggroup

This 2 calls are also from the client library and as per discussion, we will allow to create user from the /init call only and hence we should throw error in this 2 APIs also. Here is the link of all APIs being called from the library - https://github.com/CarnegieLearningWeb/UpGrade/blob/main/clientlibs/js/src/UpgradeClient.ts

@msandbothe there are 3 things combined in this PR:

only init() creates new users in UpGrade
JS client supports init()
Java client supports init()

@YashilDepani  I think You also need to bump up the JS library version.

No current version of MATHia makes an init call, so we may not want to merge this now. @kschaefe can you let us know the deadline for the next Portal release? We would normally ask @jerith666 to make the change of adding the init call but he is on vacay until ~Aug13.

It shouldn't matter if we merge this as long as the currently-used client library versions will continue to work (or at least work as well as they did prior to these changes).
If these changes are going to force the clients to update, then we can only merge them, if we don't release and use that version of the server.
Can anyone tell me what the client responsibilities are for these changes?

This is a major change that will cause our implementation of the client library to return an error response. We currently don't call init() so all calls on new users should fail (which I hope we handle gracefully). The necessary change is to call init() in both portal and launcher before calling setGroup/setWorkingGroup.
At first I thought we just needed to call init() from portal, but we should also call init() for users who launch without portal. The init() call in launcher is lower priority than the one in portal.

I've entered https://carnegielearning.atlassian.net/browse/PORTAL-620 to have portal make the init() call.  I think we have to merge only the client API change first, though, so that it's available to make the portal update, before the server starts requiring it.

@jerith666 @msandbothe
@YashilDepani created two new PRs. One for SDK changes and one for Backend changes.
SDK changes #124
Backend changes #125


How does your public key encryption compare to RSA + AES?

I was reading this: https://github.com/cryptosphere/rbnacl/wiki/Public-Key-Encryption
and wondering how it would compare to RSA public/private keys being used to encrypt an AES key and iv (which is in turn used to decrypt the final message of N length)
This is what I'm currently doing:
https://github.com/NullVoxPopuli/meshchat/blob/master/lib/meshchat/encryption/aes_rsa.rb#L21
Is XSalsa20, Poly1305 MAC, and Curve25519 better than that application of AES and RSA? if so, how / why?

crypto_box is a hybrid cryptosystem (similar to an ECIES) which uses Curve25519 ECDH for key exchange and XSalsa20Poly1305 for authenticated symmetric encryption.
I wouldn't necessarily say XSalsa20 is "better" than AES: on modern Intel CPUs AES is hardware accelerated. XSalsa20Poly1305 provides an authenticated construct similar than GCM. On the NaCl web site, AES-GCM was listed as another option for the crypto_secretbox symmetric encryption primitive. libsodium now implements it, although RbNaCl does not yet expose it (but only for systems that support hardware acceleration)
Regarding RSA: it's fraught with problems. The large keys make it slow, require use of bignums, and therefore make it difficult to implement in constant time. Poor padding modes like PKCS#1v1.5 have plagued RSA for years.


Any chance for ubuntu build or at least instruction how to proceed ?

I'm not super experienced with the Linux dev environment and I don't have access to a Ubuntu desktop machine. All the libraries used are crossplatform so it should be possible.
I think a good place to start would be to try and get https://github.com/dinodeck/step_01 building, as that's the early core of the dinodeck engine.
Getting the libraries building correctly is probably the main challenge, then in the code there are few minor #ifdefs for the platforms (such as in DinodeckGL.h).
For the build process I use a standard make file and then build scripts that a PLATFORM flag called make_windows.sh and make_mac.sh.

Hey all,
I've begun working on a branch on my own fork of Dinodeck to allow compiling on Ubuntu Linux. It's not quite ready for prime-time, but if you're looking for a start in this direction feel free to check out the latest commit: https://github.com/etscrivner/dinodeck/commit/ce00fb3b68be0ed35c152660f8badaf1b04b6055
It compiles, but unfortunately I still can't get it to run without an almost immediate core dump. I'm not sure what the issue is, but at the moment it appears that SDL doesn't recognize my graphics card and so FrameBuffer allocation fails (strangely, SDL v1.2 fails on my laptop but SDL v2.0 works perfectly).
I'll continue to work on this and hopefully have something ready for a pull request soon, time permitting!

Congrats on getting it compiling; I know that can't have been easy!
I couldn't hazard a guess (that would be helpful!) about why the framebuffer / graphics card detection is failing.

For those who hoping for a linux port, on ubuntu (untested on other OS), you can use the program "wine" to run the dinodeck_win.exe. Install wine through the package manager and then run "wine dinodeck_win.exe" in your game folder.


[UI] Migrate DatabaseSummary component to Sistient and MUI v5. Fixes #12421

Notes for Reviewers
This PR migrates the DatabaseSummary.js component to use Sistent and MUI v5.
Changes:

Updated MUI v4 components to MUI v5 with Sistent equivalents (Button, Typography, useTheme).

Wrapped the component with UsesSistent for consistent theming.

No logic changes; functionality remains intact.

[x] Yes, I signed my commits.

@SAHU-01 please review this pr

Thanks, @Vaibhav701161.
@sudhanshutech are we still doing this?
Wrapped the component with UsesSistent for consistent theming.

@sudhanshutech are we still doing this?

Wrapped the component with UsesSistent for consistent theming.

@sudhanshutech are we still doing this?

Wrapped the component with UsesSistent for consistent theming.

@sudhanshutech, asking again: are we still doing this?

@sudhanshutech are we still doing this?

Wrapped the component with UsesSistent for consistent theming.

@sudhanshutech, asking again: are we still doing this?

yes until the all pages are completed and then we will remove from everywhere and use it in single place that is app.js.

@Vaibhav701161 checking in again...


Metric depth

Hi, have you tested any fine-tuning on a metric depth?

@bhack   Thank you for your attention! We focus on self-supervised MDE with monocular videos, resulting in scale-ambiguous depth.  We do not conduct fine-tuning for metric depth.


feat(config/server): Add option to deploy a HTTP server for the metrics endpoint

What type of PR is this?
/kind feature

Any specific area of the project related to this PR?
/area config

What this PR does / why we need it: See issue
Which issue(s) this PR fixes:

Fixes https://github.com/falcosecurity/falcosidekick/issues/564
Special notes for your reviewer:

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: annadorottya
Once this PR has been reviewed and has the lgtm label, please assign cpanato for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.
:memo: Please follow instructions in the contributing guide to update your commits with the DCO
Full details of the Developer Certificate of Origin can be found at developercertificate.org.
The list of commits missing DCO signoff:

2de4d79 Merge branch 'add-separate-http-server-for-prometheus' of github.com:annadorottya/falcosidekick into add-separate-http-server-for-prometheus

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Adding label do-not-merge/contains-merge-commits because PR contains merge commits, which are not allowed in this repository.
Use git rebase to reapply your commits on top of the target branch. Detailed instructions for doing so can be found here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: annadorottya
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: annadorottya
Once this PR has been reviewed and has the lgtm label, please assign cpanato for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: annadorottya
Once this PR has been reviewed and has the lgtm label, please assign cpanato for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

See my comment in #564, I don't think this implementation would be the best.
BTW, I would like to release the 2.28.0 asap, if you feel you'll not have enough time to propose a new PR, I'll post pone this feature to 2.29.0 (which has no ETA)

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: annadorottya, Issif
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Issif]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash: 6e9ee53cc543f67e445792ec08799f8f255b25c5


Seanaye/feat/server wasm

Draft PR (still very much WIP) just to show progress of serverside WASM integration.
Goals:

Support all SSR modes with streaming and server actions
Target deno deploy and cloudflare workers

Thanks! will do. I realized I should probably implement Service from tower instead of creating my own handler trait. Haven't had much time to work on this recently but I will get there eventually!


Entangles not working

Entangles aren't really supported yet.  You can roll the damage dice, just don't apply it.  Handle the entangle manually.

Despite the fact that entangles are now displaying just BODY, rather than STUN and BODY, they should still not have the damage applied.


[MC-2359] Add normalized event and property names evaluation

Adds method areEqualNormalizedName: to check if two strings are normalized equal or not.
Adds method getNormalizedName: to get normalized name after removing white spaces and converting it to lowercase with en_US locale.
Added unit tests.

@nishant-clevertap Implementation looks good to me. Please add a comment on why this is done and why we use the English locale, see the android PR for details.

@nishant-clevertap Implementation looks good to me. Please add a comment on why this is done and why we use the English locale, see the android PR for details.

Added method docs and comment.


Credit Card field has glitched scroll

Using a Galaxy Note 5.
I entered "424242424242...." and then it scrolls over, but it ends up glitched as shown

Same on google pixel


Validation redirects

Before redirecting a user to an exit page after a validation failure we should show them validation failures for other fields within the current step.
A user should only be redirected to an exit page if all other fields within the step are valid.

I'm not sure _validate is the appropriate place for this code. The logic is very similar to that within the getErrorStep method (https://github.com/UKHomeOffice/passports-form-controller/blob/master/lib/form.js#L170-L182) which exists explicitly to handle redirection of errors so that feels like a more natural place to handle this.


1.3 - GEOMESA-2005 - Fix small typo in GeoMesa HBase docs

Signed-off-by: Jim Hughes<EMAIL_ADDRESS>

closing this and re-opening against the 1.3 branch


Can't include landmark.pb.h, trying to get face and iris landmarks

I want to create a small app that uses the direction of where the user is looking, for that I decided to use the iris demo and edit the main demo_run_graph_main.cc, I am trying to get "face_landmarks_with_iris" out.
I can't read the mediapipe::NormalizedLandmarkList without including the landmark.pb.h, however, it doesn't work even after adding "//mediapipe/framework/formats:landmark_cc_proto", to the BAZEL build, so I am pretty lost.
Also would love to just use python for that (streaming the video in and getting the iris and face landmarks out)
Would appreciate all the help.
bazel build --define MEDIAPIPE_DISABLE_GPU=1 mediapipe/examples/desktop/iris_tracking:iris_tracking_cpu
mediapipe/examples/desktop/demo_run_graph_main.cc:28:10: error: expected "FILENAME" or <FILENAME>
#include "mediapipe/framework/formats/landmark.pb.h
         ^
1 error generated.
Target //mediapipe/examples/desktop/iris_tracking:iris_tracking_cpu failed to build
INFO: Elapsed time: 4.709s, Critical Path: 4.56s
INFO: 130 processes: 129 internal, 1 darwin-sandbox.
FAILED: Build did NOT complete successfully

cc_library(
    name = "demo_run_graph_main",
    srcs = ["demo_run_graph_main.cc"],
    deps = [
        "//mediapipe/framework:calculator_framework",
        "//mediapipe/framework/formats:landmark_cc_proto",
        "//mediapipe/framework/formats:image_frame",
        "//mediapipe/framework/formats:image_frame_opencv",
        "//mediapipe/framework/port:commandlineflags",
        "//mediapipe/framework/port:file_helpers",
        "//mediapipe/framework/port:opencv_highgui",
        "//mediapipe/framework/port:opencv_imgproc",
        "//mediapipe/framework/port:opencv_video",
        "//mediapipe/framework/port:parse_text_proto",
        "//mediapipe/framework/port:status",
    ],
)

Running into something similar. How did you solve it?


Deleting Tables from database.

Hi I am working on the Social Education app in which i have used DBflow version 1.8.0. I am facing the issue in deleting all tables when user switches the stream or user is changed. Some times tables get deleted and some time not. I have followed the delete query statement as per the documentation.
This is the query I fire to delete all the tables from the database
Delete.tables(MyTable1.class, MyTable2.class); but this does not work properly. Some how tables are persisted in db with previous stream data and new stream data which leads to confusion of streams.
Help will be greatly appreciated.

I would recommend updating to DBFlow 3.0.0-beta1. Not sure how they are persisted, or what you mean but deleting only clears the row from the tables, if you have something else adding rows to the table on another thread, it'll add rows to the table. If you dive into the source, all it's doing is calling SQLiteDatabase.execSQL("DELETE FROM Table")

ok, Thank you for precious reply. Will update to 3.0.0-beta1 and test.


Early-released charts show partially

I just wasted quite some time figuring out why my chart was only showing a plain line, without the grid or axis labels. Turns out, you have to assign the Chart variable to a strong reference to keep it in memory for it to display correctly. I think a bold mention of this in the readme would help a lot!

You are very right, there have been already some issues about this. I'll add it, thanks.


CharacterReader always allocate a 32 KB buffer that can even exceed document size

This might be overkill and we might be able to decrease the size of this buffer for small strings to be parsed.
This should thus reduce memory allocation.
Here is a small async profiler memory flame graph showing this:

I think the difficulty will be in knowing upfront the expected content length of the response to parse. My understanding in practice is that if it is set, the Content Length header is often incorrect. And so browsers typically ignore it / handle larger sizes.
 I picked that number based on a bit of empirical benchmarking and testing and found it worked reasonably.
Another approach would be to reuse the buffer on subsequent reads, so the allocation doesn't need to happen. We use that pattern in e.g. StringBuilders.

 I picked that number based on a bit of empirical benchmarking and testing and found it worked reasonably.

No not that critical, though you get many small HTLM emails in an email server.

OK yes in that use-case I think it would make sense. A pattern of a threadlocal reusable buffer would work, similar to the Builders in StringUtil.

Thinking more about this, is there something that prevent doing (potentially opt-in) buffer recyclingjust like Jackson JSON parsers does ?
I am working on a similar approach in MIME4J and it did so far yield a 40& allocation reduction that translated in micro-benchmarks into a 10-15% performance improvment.
I would be happy to cary other such a contribution.

I'm not familiar with the implementation of Jackson parser. Recyling the buffer makes sense. I don't know that it should be opt-in as I would expect most people to miss it if it were.
Would be happy to review a PR!

Question before getting started: are there some jmh benchmarks somewhere? Would you be interested in getting a set of jmh benchmarks as well?
Will be in vacations all of july so nothing would likely happen before august.

I did succeed to put together https://github.com/jhy/jsoup/pull/1800 before leaving.
Looks like massive gains are ahead ;-)

Implemented in #2186


Problems encountered when applying gradient boosting to Resnet18 on Cifar10.

Hello, I am learning deep ensemble methods. Your work is very good and helps me a lot. But I encountered a problem when applying gradient boosting to Resnet18 on Cifar10.
When applying ensemble algorithms, such as Bagging and Fast Geometric, to Resnet18 on the Cifar10 dataset, they work normally. However, Gradient Boosting Classifier and Soft Gradient Boosting Classifier cannot improve performance through training.
After checking, I found that the latter two used the "pseudo-residual function" instead of the cross-entropy function in the classification. Is this the reason for the inability to train?
I believe I overlooked some details. Because there are some predictions of Gradient Boosting in the file ./docs/plotting/resnet_cifar10.py.
Below is a code snippet that I applied Soft Gradient Boosting to Resnet18 on Cifar10:
###code START###
model = SoftGradientBoostingClassifier(estimator=ResNet,
                                       estimator_args={"block": BasicBlock, "num_blocks": [2, 2, 2, 2]},
                                       n_estimators=n_estimators,
                                       cuda=True)

# Set the Optimizer
model.set_optimizer("SGD", lr=lr, weight_decay=weight_decay, momentum=momentum)

# Set the Scheduler
model.set_scheduler("CosineAnnealingLR", T_max=epochs)

# Train
estimator = model.fit(train_loader, epochs=epochs, test_loader=test_loader)
###code END###

This is the result returned by the console
- INFO: Epoch: 000 | Batch: 000 | RegLoss: 1019.32739
- INFO: Epoch: 000 | Batch: 100 | RegLoss: nan
- INFO: Epoch: 000 | Batch: 200 | RegLoss: nan
- INFO: Epoch: 000 | Batch: 300 | RegLoss: nan
- INFO: Epoch: 000 | Validation Acc: 10.000 % | Historical Best: 10.000 %
- INFO: Saving the model to ./SoftGradientBoostingClassifier_ResNet_3_ckpt.pth
How should I modify this code? Thank you so much for your patience ^_^

Hi @know-nothing8, try the following solutions, and let me know if you have any problem:

Set use_reduction_sum to False when calling the fit method
Use a smaller learning rate when calling the set_optimizer method

The training loss turns into nan typically means that the current configuration on the optimizer does not adapt well with the problem appropriately. Therefore, my first suggestion is to use a smaller learning rate ;-)

Thank you very much for your help.
After I changed the learning rate from 1e-1 to 1e-3, it still doesn't work. But after I changed the optimizer from "SGD" to "Adam", it can be trained normally! 👍

If I remember correctly, the performance of ResNet should be slightly better when using the SGD optimizer. You could also try to use a smaller momentum factor.
I am going to close this issue since it is more of a problem on how to optimize a specific deep learning model. Thanks for reporting. 😄


GoCD integration not working

Hi
I followed the following guide to integrate GoCD to Zulip: -> https://zulip.com/integrations/doc/gocd
The link from the guide is missing the ${ID} parameter which must be in the URL.
I just added it at the back like myurl?api_key=xxx&id=${ID}.
I haven't received a message from the bot so far. What could be the problem here? Could anyone help me on how to
troubleshoot the problem?
zulip_version: 4.9
zulip_feature_level: 65

@cynay thanks for the report!  Hopefully someone will pick this up; it should be not hard for a contributor to setup GoCD and then test this; our integrations guide has some advice.
One thing you can do to help is inspect /var/log/zulip/webhook*.log for any traceback; that might make it possible to debug this without setting up GoCD.

Hey @timabbott , Can i work on this issue? I am beginner in Open Source and this project, can you please guide me on how to get started? Thank you!

Start by trying to reproduce the issue: Set up GoCD on a server and follow our integration guide from there.

Hi, I am a new stater of Zulip and just tried to reproduce this issue by following the guide. May this problem be caused by  of GoCD?
I find that the ${ID} is used to find id information like "#3301" from your commit message.  In GoCD's document, it says 'Go will find the first matched group in your commit messages and use it to construct the hyper-link.'
so I think maybe  may just generate a hyperlink in GoCD's 'Trigger By changes' without sending any request to Zulip server.
just like the example in [https://docs.gocd.org/current/integration/]

@zulipbot claim

@zulipbot claim

@zulipbot claim

@zulipbot claim

@timabbott I can reproduce this issue in my local setup of GoCD and Zulip. Few observations similar to what @cynay and @junchen-liu pointed out

When configuring Config.XML as instructed here, one needs to add &id=${ID} in the url, else GoCD will not accept the url by throwing this error - Link must be a URL containing '${ID}'. Go will replace the string '${ID}' with the first matched group from the regex at run-time.
After constructing the url and having configured the Config.XML, I tried to push changes to my github repository (linked with GoCD) - the GoCD pipeline runs successfully, but there is no notification in Zulip
I tried to push changes again to my repo with this commit message #3301 - Modify README again, and I noticed that in GoCD pipeline history page (shown below), #3301 has been hyperlinked with the url we configured in Config.XML
I tried to look for gocd keywords in /home/vagrant/zulip/var/log/webhooks*.log, but there is no trace of it at all - it seems like Zulip server isn't triggered at all

These observations led me to believe that as explained here, the configuration of URL in Config.XML merely just made GoCD replace digits in the commit message with the configured URL, but not actually sending any data to the configured URL...

@timabbott I can reproduce this issue in my local setup of GoCD and Zulip. Few observations similar to what @cynay and @junchen-liu pointed out

When configuring Config.XML as instructed here, one needs to add &id=${ID} in the url, else GoCD will not accept the url by throwing this error - Link must be a URL containing '${ID}'. Go will replace the string '${ID}' with the first matched group from the regex at run-time.
After constructing the url and having configured the Config.XML, I tried to push changes to my github repository (linked with GoCD) - the GoCD pipeline runs successfully, but there is no notification in Zulip
I tried to push changes again to my repo with this commit message #3301 - Modify README again, and I noticed that in GoCD pipeline history page (shown below), #3301 has been hyperlinked with the url we configured in Config.XML
I tried to look for gocd keywords in /home/vagrant/zulip/var/log/webhooks*.log, but there is no trace of it at all - it seems like Zulip server isn't triggered at all

These observations led me to believe that as explained here, the configuration of URL in Config.XML merely just made GoCD replace digits in the commit message with the configured URL, but not actually sending any data to the configured URL...

I think it's reasonable to contact the GoCD project if you're unable to debug why it isn't doing an outgoing HTTP request to the Zulip server, yeah.

Their response suggests the right plan might be to just rewrite this integration using a different API?

GoCD contributor here. I am relatively new to the GoCD project (user for many years, occasional plugin dev for a few, but adhoc contributor/maintainer on GoCD itself for last 9 months or so) so don't have all the history back through here from a dev perspective - but as I mentioned in my comment at https://github.com/gocd/gocd/issues/10379#issuecomment-1111137009 I'm a bit confused as to how this would have ever worked with just the "Tracking Tool" stuff as documented unless the way it worked has changed over the years internally in GoCD. I don't think so though.
I wonder if somewhere there is some testing that might have been demonstrated this working somewhere, or someone using it? The text fixture files in https://github.com/zulip/zulip/commit/e1eabe286ad2888cd2f5904c8f592874ba991d00 seem to indicate it is expecting a body that would be returned from GoCD's get-pipeline-instance API which I believe would have to be polling based (not webhook/notification style) and probably not the intention of the Zulip integration, I imagine.
To my knowledge GoCD has not had a generic webhook based mechanism to make arbitrary calls out to 3rd party tools and all such tools are implemented as Notification Plugins, similar to the gocd-slack-build-notifier or generic contributor http-notifications-plugin. There is a skeleton for building such a plugin here which might need a little bit of updating for newer Gradle versions/suggested lib versions but otherwise could be useful if there is enthusiasm for this.

@zulipbot Claim

I am a first time contributor and would love to help tackle this issue, if nobody else already has!

@zulipbot claim

I am still working on this

@zulipbot claim

@zulipbot abandon

@timabbott Hi! I am a first-time contributor and found this issue to be interesting. I have read through all the related posts and codes. It seems that we have to write a plugin for gocd as suggested by @chadlwilson. I wonder if it is still a good first issue to do and if there are any suggestions to start with. Thank you!

@zihanqiuu You're welcome to give it a try!

@zulipbot claim

Please assign m this Isuue!

@zulipbot claim

@zulipbot abandon

@zulipbot claim

@zulipbot abandon
On Fri, Feb 3, 2023 at 2:09 AM zulipbot @.***> wrote:

@Rish-it https://github.com/Rish-it We noticed that you have not made
any updates to this issue or linked PRs for 10 days. Please comment here if
you are still actively working on it. Otherwise, we'd appreciate a quick @zulipbot
abandon comment so that someone else can claim this issue and continue
from where you left off.
If we don't hear back, you will be automatically unassigned in 4 days.
Thanks!
—
Reply to this email directly, view it on GitHub
https://github.com/zulip/zulip/issues/21224#issuecomment-1414344633, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AY6ROGVLWMV4F5P74HHAW2TWVQLQJANCNFSM5PEIPPOA
.
You are receiving this because you were mentioned.Message ID:
@.***>

@zulipbot claim

@zulipbot abandon

@zulipbot claim

@zulipbot claim

@zulipbot claim

@zulipbot claim

is this issue still open?

@zulipbot abandon

I am suggesting adding a option to add some extra args in WebhookIntegration url to meet the requirement of External Integrations.
Is it a good approach?

To get feedback on your approach, I recommend posting in the #integrations stream in the Zulip development community.

@zulipbot claim

@zulipbot claim

@zulipbot claim

@zulipbot abandon

I am trying to reproduce this bug can someone provide any help?

@zulipbot claim

@zulipbot claim

@zulipbot claim

@zulipbot claim

Claim

@zulipbot claim

On testing is it ok to use postman to send HTTP requests?

@SydneyWamalwa You can ask you questions in the #integrations channel in the development community for more visibility.

@zulipbot claim

@zulipbot claim

is this still open

claim

@zulipbot claim


Make the Rejuvenate page Responsive

While making it Responsive,I was thinking of adding a scrollup button as well to the responsive version of the page

I would like to work on this issue under gssoc'23

ok assigning u

@karthiknadar1204 this was done, can I close it now?

Working on this one


Updated shell command to install

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


How to contribute

I've extended this plugin to include the Electromagnetic Emissions PDU and wanted to know how to contribute before making a pull request. Any specifics?

No, not really any specifics. Go ahead and make a pull request and then we'll look over it on our end prior to merging it.


basic report suppor

example

summ courses by hours spent
summ courses by purchesed
most popular course
most popular tutor
etc - what easy to achive


Can anyone help me with high memory consumption on Heroku platform?

Hi,
I time-to-time building demo and production apps and deploying on Heroku. A few months ago, I bumped with this issue.
I used Liberica JDK, which proved to be good in local dev env and production. Can you possibly help me out or point to the right repo/channel? I will highly appreciate any help on this.
Note: I used Java 11 and Kotlin with Jackson for object mapping. I tested this setup with Docker locally, and it wasn't supposed to bump any limits on the Heroku platform.

Having the same issue, in my machine it stays bellow 350 and in Heroku is going to pass the 512 ins a few hours.
The strangest part is that I can reproduce this locally and my heap+non heap is ~350mb and my RSS memory is ~506mb
Did you solved this issue @ChameleonTartu ?

Hello @ChameleonTartu and @rafaeldelboni!
Sorry for the long delay before you got an answer. First off, let me say that the repository here is in no way contributing to your Docker container on Heroku. As per our support policy, we cannot help with debugging your application. However, here are my thoughts:
@ChameleonTartu Using Liberica is fine, I don't think this is where your problem is. In your linked StackOverflow questions, I can see that you're not explicitly passing any JVM options in. Are you sure you limit the maximum heap to a value that matches the dyno type you're using?
@rafaeldelboni please note that Heap+NonHeap reported by the JVM is not all of RSS. The operating system inside the container requires memory as well. That might explain the difference in memory consumption you see.
I will close this as we cannot provide application debugging support and the issue is not related to the code in this repository.

@rafaeldelboni I didn't solve it before. I am checking Malax's answer as I completely missed flags for limiting my heap. 🤦


Update and rename happy-destiny-womens.yaml to d13-happy-destiny-wome…

…ns.yaml
Update district number for Happy Destiny's Women's.

You obviously have a large number of additional changes planned. Since you have my email address, you can feel free to add these to this PR and send me an email when you believe it is ready.


Change overlay of dashboard kfdef

Description

Change the overlay of the dashboard release based on https://github.com/opendatahub-io/odh-dashboard/pull/1622
How Has This Been Tested?

Merge criteria:

[ ] The commits are squashed in a cohesive manner and have meaningful messages.
[ ] For commits that came from upstream, [UPSTREAM] has been prepended to the commit message.
[ ] JIRA link(s):
[ ] The Jira story is acked.
[ ] Live build image:
[ ] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[ ] The developer has manually tested the changes and verified that the changes work.
[ ] QE contact acknowledges that this has been tested and is approved for merge.

This should be merged after https://github.com/red-hat-data-services/odh-manifests/pull/446

@andrewballantyne @vaibhavjainwiz @zdtsw Same thing here, it's now ready for 1.33


[ENG-1725] feat: add remove connection button

Adds remove connection after successful connect with ConnectProvider
Adds a deprecation flag to onSuccess in favor of onConnectSuccess
Adds onDisconnectSuccess callback

demo of change

change does not include component confirmation of connection deletion


chore(package): update kronos-flow to version 2.5.40

Coverage remained the same at 14.118% when pulling 2f3cc120173cc9ba344a06cda8205bd67e89b412 on greenkeeper/kronos-flow-2.5.40 into 615fc181832231cf4dac6bc65f494c7473f93265 on master.

Coverage remained the same at 14.118% when pulling 2f3cc120173cc9ba344a06cda8205bd67e89b412 on greenkeeper/kronos-flow-2.5.40 into 615fc181832231cf4dac6bc65f494c7473f93265 on master.


FATAL: Cannot decrypt keys using any of the given key secrets. The key secrets must be changed to include one that can decrypt the existing keys, or the existing keys must be deleted.

when i run cmd "./bin/dex-overlord &" to start dex-overlord, i get the follow error, what i should do? i exported the var in container, maybe export DEX_KEY_SECRET ... twice, but these environment variables not set, so i add it to /etc/profile, then run "./bin/dex-overlord &",  but it show the fatal error.

The error is pretty descriptive. The secrets to decrypt data in the database is incorrect. How are you ensuring that -key-secrets flag or the DEX_KEY_SECRETS environment variable is set the same on subsequent runs of the overlord?

Thank you @ericchiang, i remove the secrets form database and regenerate, It works.

Great! Closing this for now.


Add support for retrieving invites with counts

Previously retrieving an invite with the ?with_counts=true wasn't possible.
Added support to get_invite for retrieving an invite with the counts, this requires the user to pass true to the function.
The counts include approximate_presence_count and approximate_member_count which have been added to the Invite stuct.
Done in response to: https://github.com/zeyla/serenity/issues/83

Thanks


Send timeserieses to stackdriver in batches.

Stackdriver has a limit of 200 timeserieses per request. To be able to
send more we need to send them in batches.

This change is

/lgtm

/approve


normalize buffer names when saving the buffer position

I'm not sure what's special about my setup, but vim.api.nvim_buf_get_name always returns the absolute path of a buffer. Including when no plugins are enabled. In case the bufname is already relative nothing changes so this should safely cover both cases.
This code also does not get called during VimLeavePre, as a result the position of the last buffer might not be persisted, not sure if this is intentional.
https://github.com/ThePrimeagen/harpoon/blob/harpoon2/lua/harpoon/init.lua#L148
Perhaps this also fixes the problem described in https://github.com/ThePrimeagen/harpoon/issues/441?

vim.api.nvim_buf_get_name always returns the full file name for the buffer. I believe this will solve some of the issues mentioned in #441, but it not being called in VimLeavePre is still an issue.

vim.api.nvim_buf_get_name always returns the full file name for the buffer.

Strange that only a few people seem to be reporting this then. Keeping track of the position, like marks, was kind of the sales pitch for this plugin.


Design of Tech Calls and Selection Day Prep Webpage

Admins currently complete a selection day tech call via teams for every candidate invited. The teams would like to move this onto word press via the website research project and need designs to see how it would look and feel for a candidate
Attached is the wording, but there is also a need for videos and information from Microsoft on how to download MS Teams and use it.
https://app.zenhub.com/files/201485031/5a554442-488d-485e-a561-e6bff9edf4fb/download
This is currently some of the information given to candidates - https://judicialappointments.gov.uk/guidance-on-the-application-process-2/selection-day/
This is the YouTube channel which hasn't be updated for a long time - https://www.youtube.com/channel/UCejOzLmdtpIkyy6gp3gLx3A
There was a proposal to record new videos for it and examples of how interviews would run.

https://www.figma.com/file/YWlSW6gFpA6AT4VZwVTVMz/The-alternative-webpage-to-Tech-Call?node-id=0%3A1&t=DRFRYzW3ZKh7NqV3-0


[7.x][FILEBEAT] Add ability to set update strategy when use deployment

Signed-off-by: disaster37<EMAIL_ADDRESS>
[X] Chart version not bumped (the versions are all bumped and released at the same time)
[X] README.md updated with any new values or changes
[X] Updated template tests in ${CHART}/tests/*.py
[X] Updated integration tests in ${CHART}/examples/*/test/goss.yaml

Fix enhance #1179.

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

Close to rebase on master branch


Add safeguard limits for file cache during node level allocation

Description

Related to #7713
Adds safeguards to prevent file cache over-subscription during allocation for individual node level decisions.
Fetches the filecache stats to get node cache size, calculates the remote shard size on nodes and verifies if the shard can be safely allocated to the said node
size of shard + sum(remote shards on the node) < 5 * (node cache size)
The constant value will be replaced by a setting in a following PR.

Related Issues
Partially resolves #7713
Check List

[x] New functionality includes testing.

[x] All tests pass

[x] New functionality has been documented.

[x] New functionality has javadoc added

[x] Commits are signed per the DCO using --signoff
[x] Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Tagging previous reviewers: @andrross / @reta / @Bukhtawar

@reta Resolved your comments. 3 green gradle checks in a row might be a sign :)

@reta Resolved your comments. 3 green gradle checks in a row might be a sign :)

@kotwanikunal my apologies, missed that somehow, will look first thing tomorrow morning

The backport to 2.x failed:
The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-8208-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 91bfa01606974b947455fbc289e21a1aad096fa8
# Push it to GitHub
git push --set-upstream origin backport/backport-8208-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-8208-to-2.x.

Will look into the backport after the followup PR.


Why does my tone sound better with lower samplerate

Hi guys,
Here is a snippet of code that I wrote that produces a piano-like tone using sounddevice:
import sys
import numbers
import math

import numpy as np
import sounddevice

note_length = 3
frequency = 400
half_life = 0.2
volume = 1

def get_pressure(time: numbers.Rational) -> numbers.Rational:
    overtones = {i: 2 / (i ** 1.3) for i in range(1, 13)}
    if time < 0 or time > note_length:
        return 0
    result = 0
    for overtone, overtone_volume in overtones.items():
        result += overtone_volume * math.sin(
            time * frequency * overtone * (math.pi * 2)
        )
    result *= volume * 2 ** (- time / half_life)
    return result

def play(hz):
    n_frames = int(hz * note_length)

    t = np.linspace(0, note_length, n_frames, False)

    array_1 = np.vectorize(get_pressure)(t)

    # Ensure that highest value is in 16-bit range
    array_2 = array_1 * (2 ** 15 - 1) / np.max(np.abs(array_1)) * 0.5
    # Convert to 16-bit data
    array_2 = array_2.astype(np.int16)

    sounddevice.play(array_2, samplerate=hz)

    sounddevice.wait()

sample_rate = int(sys.argv[1] if len(sys.argv) >= 2 else 8000)
play(sample_rate)

I was surprised to learn that when you play it at 8KHz, which is the default, it sounds really life-like, but if you raise it to 16Khz, it sounds too computer-generated. Try it by copying it to a file and running it with the samplerate as the argument, like this: python foo.py 16000 or python foo.py 32000 .
Is there something weird here I'm not thinking about that is causing this phenomenon? And if not, and it's just a crazy fluke, how can I preserve this quality of sound even when I'm playing at a higher quality?

That's an interesting exercise you've come up with!
Depending on your knowledge of signal processing this can have a quick answer, or it might need some longer explanations ...
Are you aware of the sampling theorem (a.k.a. Shannon's law or something like that)?
Did you have a look at the frequency values of your partial tones?

it sounds really life-like

Are you listening to the sound on laptop loudspeakers?
If I listen to it on laptop loudspeakers, it sounds surprisingly nice, but when I listen to it with headphones, not so much anymore.

That's an interesting exercise you've come up with!

Thanks Matthias! I'm planning a cool project with sounddevice, but I won't reveal it yet, because I'm not sure I'll have the time to finish it :)

Are you listening to the sound on laptop loudspeakers? If I listen to it on laptop loudspeakers, it sounds surprisingly nice, but when I listen to it with headphones, not so much anymore.

No, I listened with high-quality speakers and it sounded good to me. I tried to connect my USB headphones to listen but that resulted in #199 .

Are you aware of the sampling theorem (a.k.a. Shannon's law or something like that)?

I googled it now and oh boy :D why does math have to show up every time to ruin the party. So the answer is no.

Did you have a look at the frequency values of your partial tones?

Well, I know that they are integer multiples of the base frequency, so 2x, 3x, 4x, 5x etc. Not sure what I should do with that information.

OK, so let me try to give you a very short and superficial summary:

The sampling theorem states that sampling only works properly if the sampling frequency is at least twice the value of the highest frequency in the signal. For example, if you use a sampling rate of 8000 Hz, the highest signal frequency should not be higher than 4000 Hz.

People who make sound cards know the sampling theorem, therefore they include a so-called "anti-aliasing filter" when converting a digital signal to analog. This filter is designed to block all frequencies above half the sampling rate. With a sampling rate of 8000 Hz that means that everything above 4000 Hz is blocked (i.e. filtered out).

If I'm not mistaken, the frequency values of your example are [400, 800, 1200, 1600, 2000, 2400, 2800, 3200, 3600, 4000, 4400, 4800].

Are you seeing the problem now?

I'll think about it. Thanks Matthias!

@cool-RR Did you have any insights you want to share here?

If I remember correctly, a few weeks ago I tried putting 3 waves together with a phase difference, and I think it made the quality a little better when the sample rate is high. But it still didn't solve the problem completely. Honestly I'm pretty much an ignorant when it comes to synthesizing sound, so I don't really know how to solve a problem like that.
The project that I'm planning is a live-coding talk in which I'll build a synthesizer and have it play MIDI files. It's not finished yet, I hope to finish it soon.

If you are building a synthesizer, you should definitely know about the phenomenon called "aliasing". You should search the interwebs for this or read about it in some book about digital signal processing.

I'll check it out, thanks!
On Mon, Sep 30, 2019 at 8:10 PM Matthias Geier<EMAIL_ADDRESS>wrote:

If you are building a synthesizer, you should definitely know about the
phenomenon called "aliasing". You should search the interwebs for this or
read about it in some book about digital signal processing.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/spatialaudio/python-sounddevice/issues/198?email_source=notifications&email_token=AAAN3SRS2EZYBLKFFN5UEMTQMIXGFA5CNFSM4IQIR4SKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD76L53I#issuecomment-536657645,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAAN3SS3L4T3OKYWA535PFLQMIXGFANCNFSM4IQIR4SA
.


Fix some incorrect method overrides

Fixes some code problems:

Return type missing (ArraySubSet)
Stricter types on override methods: FilterEmailValidation, FileSystemAdapter =>
Missing parameters: Builder, HasManyThrough

For stricter types i could have fixed it by adding types to parent classes but this could lead to breaking changes.

There are several breaking changes to method signatures in this PR. Please attempt 10.x, thanks.


bug: Thrown TRPCError always returning a httpStatus code of 500

Provide environment information
System:
    OS: macOS 14.5
    CPU: (8) arm64 Apple M1
    Memory: 127.89 MB / 8.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 20.15.1 - /opt/homebrew/opt/node@20/bin/node
    npm: 10.7.0 - /opt/homebrew/opt/node@20/bin/npm

Describe the bug
When throwing a TRPCError inside of a createTRPCRouter function, the specified code is always returning INTERNAL_SERVER_ERROR with a httpStatus of 500. This happens regardless of the environment (dev/prod).
I have declared a thrown error to be as follows:
throw new TRPCError({
    code: "NOT_FOUND",
    message: "Forced error being thrown.",
});

So, I would expect the error that is returned to the error.tsx page to be 404. It seems that whichever error code i specify, the same INTERNAL_SERVER_ERROR is thrown, almost as if it's being overwritten somewhere.
The error page is displayed inside of app/error.tsx with the following:
interface Props {
  error: TRPCError;
  reset: () => void;
}

const error = ({ error, reset }: Props) => {
  const httpCode = getHTTPStatusCodeFromError(error); // This is always 500
  console.log(error, httpCode);
  return (

          Error: {httpCode}

{error.message}

  );
};

Reproduction repo
https://github.com/lukeorriss/trpc-server-error-example.git
To reproduce
A production example of this can be found https://trpc-error.orriss.dev.
Alternatively, the github repo: https://github.com/lukeorriss/trpc-server-error-example.git
To reproduce:

create t3 stack nextjs application
force an error to be thown in the provided post.ts route example
httpStatus will be 500, regardless of specified error code.

Additional information
No response

I think this is a trpc error because the GetStatusCodeFromKey function tries to parse the code into a number and if it fails


As a user, I want to be able to import multiselect picklist data with the NPSP Data Importer

user reporting that multiselect picklists don't copy their data to the object.  https://powerofus.force.com/_ui/core/chatter/topics/TopicPage?id=0TO800000000Tp4&ref=feed_item_topic&entityId=0D58000001rFMK2

turns out it was user mistake.  the mapping wasn't specified in the Help text field.

Story deleted from ScrumDo


Show assigned user in case details

When the user clicks on the case to see the details of the case, there is some information that appears below the case number title. It currently only shows the partner that the case is assigned to, we need to also show the user.

@justinvdm Ready for review.
Sorry for the large list of commits, I accidentally merged another branch into this one, so I had to revert those commits. The only commit that was for this PR is this one: https://github.com/praekelt/casepro/pull/77/commits/8e9f5ab237eb0c905bd9d2b72eea7d1c822639c5
@rowanseymour Pinging you for vision on this.

:+1: Wondering if we should make a new PR with just the commit we want to avoid noise in the comments. Not a big deal though I guess, I'm happy either way.


fixed surfacebuilders and removed several unneeded mixins that supported the old way

things to do as a result of this change:
Make large dimstone patches be an ore or ore-like feature so you can control frequency and size easier instead of relying on surfacebuilder rng voodoo.
Make glowdust layering be a feature similar to cinderscape's ashes or vanilla's snowandice feature. This way, the glowdust gets placed correctly on slopes and wont be floating above carvers/caves/pits that carved out the below land.

Doesn't conform to our code style at all, I'm going to add a commit that solves this.


Add Docker image artifact URL to PR comment

Status
Ready
Related Content Pull Request
Related PR: link to the PR at demisto/content
Related Issues
Related: https://jira-dc.paloaltonetworks.com/browse/CIAC-8620
Description
In PRs originating from forked repos, post a message with the link to the generated Docker image in CircleCI artifacts and command to load it locally.
See https://github.com/demisto/dockerfiles/pull/23484#issuecomment-1981412985 for how the comment is supposed to be presented.

@JudahSchwartz - Should be good to go. I added the following:

the env var as an arg as suggested in the review.
The preview of how the comment looks can be found in https://github.com/demisto/dockerfiles/pull/23484#issuecomment-1981384890.
The comment now includes the Docker metadata as well. It was added only to prod comments (see https://github.com/demisto/dockerfiles/pull/23484#issuecomment-1981384890). This was a fix added in https://github.com/demisto/dockerfiles/pull/23484/commits/3caa1f229450f6ba536f3db656fac3f7e9e86bab.

This is the output when command is copied and run in local env:
❯ curl -L 'https://output.circle-artifacts.com/output/job/4dbef337-6798-4238-9a3c-53e2418d3090/artifacts/0/docker_images/devdemisto_bottle2:<IP_ADDRESS>518.tar.gz' | gunzip | docker load
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100 24.9M  100 24.9M    0     0  4698k      0  0:00:05  0:00:05 --:--:-- 5971k
e6f9ed28d3c3: Loading layer [==================================================>]  2.048kB/2.048kB
3abcf15506eb: Loading layer [==================================================>]  731.6kB/731.6kB
Loaded image: devdemisto/bottle2:<IP_ADDRESS>518


[⚡e2e]: ability to store image snapshots as a WebP/AVIF

It is requested to investigate the capability of storing images snapshots in a webp/avif format to make it smaller.

:tada: This issue has been resolved in version 5.0.0-beta.34 :tada:
The release is available on:

npm package (@beta dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

Todo: @ala-n to close the issue


feat(strategysheet): 支持自定义衍生指标

👀 PR includes

✨ Feature

[x] New feature

📝 Description
优化 https://github.com/antvis/S2/pull/1750 的方案, <StrategySheetDataTooltip/> 支持自定义衍生指标, 更灵活

   <StrategySheetDataTooltip
      cell={cell}
      renderDerivedValue={(currentValue, originalValue) => (
        <span>
          {currentValue} ({originalValue})
        </span>
      )}
    />

🖼 Screenshot

Before
After

❌
✅

🔗 Related issue link

🔍 Self-Check before the merge

[ ] Add or update relevant docs.
[ ] Add or update relevant demos.
[ ] Add or update test case.
[ ] Add or update relevant TypeScript definitions.

:tada: This PR is included in version @antv/s2-react-v1.28.0-alpha.1 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version @antv/s2-react-v1.28.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Default rp syntax not working

The following query:
SELECT * FROM db0..cpu

Verified that the default RP does exist with:
show retention policies db0

results:
{"results":[{"series":[{"columns":["name","duration","replicaN","default"],"values":[["default","0",1,false],["rp0","1h0m0s",1,true]]}]}]}

No longer works.   Results in the following error:
{"results":[{"error":"retention policy not found"}]}

There is a test for this that is skipped under cmd/influxd/run/server_test.go.  Test name: TsetServer_Query_DefaultDBAndRP
And also test TestServer_Query_Regex table test specified db and default rp

https://github.com/influxdb/influxdb/commit/be792b926a86bad31b8e3c9e0d997a6ede31dc70
https://github.com/influxdb/influxdb/commit/5b39b96b9db87e27e8a75ee090fc50259931fd74
tests re-enabled and now pass after recent changes.


Refactoring: Use bindings for PosterBanner widget (UtcDate and IsAnonymous properties) in Post widget

Fixed by af83197 commit


Add parallel actions for every supported python version

https://github.com/pypa/hatch/issues/669#issuecomment-1407416005

refactor publish to another job to avoid publishing the same version plenty of times


[Survey list] "No surveys available" shown when app restored from background

Describe the bug
"No surveys available" messages is shown when app restored from background.
To Reproduce
Steps to reproduce the behavior:

Open the survey list
Press power button to put phone to sleep, wait a minute or two
Press power button to wake up, unlock

Expected behavior
List of available surveys should be shown
Actual behavior
"No surveys available" message is shown
Pressing the "<-" arrow reloads the list

@sufyanAbbasi @shobhitagarwal1612 @jcqli FYI


[bin] encode label name if it set as multibyte string

summary

if label is saved as multibyte string(such as Japanese) via Web-UI,
print(label.label(output.best)) will throw UnicodeEncodeError

description

my label name  "ゴリラ"  causes this exception
Traceback (most recent call last):
  File "/home/vagrant/labellio_cli/bin/labellio_classify", line 55, in <module>
    main(get_parser().parse_args())
  File "/home/vagrant/labellio_cli/bin/labellio_classify", line 40, in main
    exec_batch(batch, classifier, label)
  File "/home/vagrant/labellio_cli/bin/labellio_classify", line 19, in exec_batch
    print("{0}\t{1}\t{2}".format(paths[i], label.label(output.best), output.values))
UnicodeEncodeError: 'ascii' codec can't encode characters in position 0-2: ordinal not in range(128)

will be fixed as

images/labellio/monkey.jpg      ゴリラ  [  2.30376329e-02   9.76935029e-01   2.73859241e-05]

Thank you very much for your pull request. I have just confirmed that this patch works well.


Fix eslint glob

Fix eslint glob issue, which prevented ESLint from expanding globs and instead left it up to the OS.
@mramato please merge soon!

Thanks.
Looks like this worked on windows by not other systems (because of wildcard expansion), your change should work everywhere.


Use Go standard library slices package more extensively

Make use of some newly added functionality added in Go 1.23.
See commit messages for details.

/test

@tklauser there are some things the linter is complaining.

/test

/test

/test

/test


[$1000] some emojis are not displayed correctly as they should be - reported by Karim mostafa

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:
1- open app
2- Type emoji's keyword in the chat box
3- observe the shape of the emoji appeared
Expected Result:
Emojis should appear in the normal shapes as they are supposed to
Actual Result:
Emojis appeared in different shape than they are supposed to
Workaround:
unknown
Platform:

Where is this issue occurring?

Web
iOS
Android
Desktop App
Mobile Web

Version Number: 1.1.88-0
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://user-images.githubusercontent.com/43995119/184213098-5b1b9d1d-efae-4df8-a304-634fa58f3a6d.mp4

Expensify/Expensify Issue URL:
Issue reported by: @Karim-30 (Karim mostafa)
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1658404495570899
View all open jobs on GitHub

At least for them moment, https://github.com/Expensify/App/pull/9551 is not solving it:

This can be reproduced in Chrome / web (macos). I have no idea where these emojis come from, are they characters in the font we use?

@parasharrajat #9123 is referencing a particular subset of emoji problems (skin tone), but if I'm understanding correctly, you're saying that it will address this problem too?

I got the feeling that it was something different. This happens even in chrome and I think it is coming from the hardcoded list of emojis in this file: https://github.com/Expensify/App/blob/e3c8897a5f7f870cce04e62fc433acb68f371dbe/assets/emojis.js#L8779-L8784
I tested manually changing the symbol, and I saw it changing in the app.

https://github.com/Expensify/App/issues/9123 has two issues in it.

Hand emoji at emoji picker shows as black and white
Some emojis look different at windows/Ubuntu because they need some system specific font.

This one is same as 2 but the system is different so we will need another font for this (Apple Color Emoji)

Great, thanks for the explanation!
Upwork job here
Reporting job here - please apply to this @Karim-30

Proposal
By replacing the incorrect emojis inside App/assets/emojis.js with the correct emojis (see the attached emojis.txt), all Emojis will appear in the correct shapes in Safari, Firefox.

but in Chrome all Emojis will appear in the correct shapes except these 8 arrow emojis.

to solve these 8 emojis we will need to change the fontFamily for some components from GTAmericaExp-Regular to sans-serif or roboto as the following :
in src/styles/fontFamily/index.js:
    MONOSPACE_BOLD: 'GTAmericaExpMono-Bd',
    MONOSPACE_BOLD_ITALIC: 'GTAmericaExpMono-BdIt',
+   SANS_SERIF: 'sans-serif',

in src/styles/styles.js :

    baseTextInput: {
-       fontFamily: fontFamily.GTA,
+       fontFamily: fontFamily.SANS_SERIF,
        fontSize: variables.fontSizeNormal,
        lineHeight: variables.fontSizeNormalHeight,
        color: themeColors.text,

    textLabelSupporting: {
-       fontFamily: fontFamily.GTA,
+       fontFamily: fontFamily.SANS_SERIF,
        fontSize: variables.fontSizeLabel,

   textInputCompose: addOutlineWidth({
        backgroundColor: themeColors.componentBG,
        borderColor: themeColors.border,
        color: themeColors.text,
-       fontFamily: fontFamily.GTA,
+       fontFamily: fontFamily.SANS_SERIF,
        fontSize: variables.fontSizeNormal,
        borderWidth: 0,

    emojiText: {
-       fontFamily: fontFamily.GTA_BOLD,
+       fontFamily: fontFamily.SANS_SERIF,
        textAlign: 'center',

in src/pages/home/report/ReportActionItemFragment.js :
 import canUseTouchScreen from '../../../libs/canUseTouchscreen';
 import compose from '../../../libs/compose';
+import fontFamily from '../../../styles/fontFamily';

                    <Text
                        selectable={!canUseTouchScreen() || !props.isSmallScreenWidth}
-                       style={EmojiUtils.containsOnlyEmojis(props.fragment.text) ? styles.onlyEmojisText : undefined}
+                       style={[{fontFamily: fontFamily.SANS_SERIF}, EmojiUtils.containsOnlyEmojis(props.fragment.text) ? styles.onlyEmojisText : undefined]}
                    >

Result :
https://user-images.githubusercontent.com/108357004/184735747-cadeb0b8-5ad2-4cd7-8834-a9e2acd03e88.mov
Don't forget to replace App/assets/emojis.js content with the attached file content.
emojis.txt

@Karim-30 I don't think changing the font family is an option here.

Doubled to $500

Is there a reason for not adding Apple Color Emoji as mentioned here https://github.com/Expensify/App/issues/10356#issuecomment-1213429783.

I vote we stay away from a sprite-based approach. I think it results in
more maintenance than is worth it.
On Tue, Aug 23, 2022 at 10:33 AM mdneyazahmad @.***>
wrote:

Another option is to use an sprite of emojis. It will be used as
background of span element and adjust background position for specific
emoji. We can break the emoji into multiple sprite sheet. This will
guarantee consistency between browsers and platforms. But, it will require
more work to be done.
—
Reply to this email directly, view it on GitHub
https://github.com/Expensify/App/issues/10356#issuecomment-1223740473,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAJMAB2HJMFIB2WAPDJC5GTV2SEGRANCNFSM56JESWWQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

Agreed with no sprite approach.

Doubled to $1000

Issue not reproducible during KI retests. (First week)

@mananjadhav proposal above for you to review

Thanks for the bump @bfitzexpensify.
@Puneet-here While your proposed solution might work to replace the emojis with the relevant symbols, it lacks details on:

Which source are you going to rely on? I am not very confident with emojipedia.org emojis (this feedback is from my experience of atleast 1-1.5 years back)
How will you identify the problematic emojis?
Is there a way to test his reliably?

@Puneet-here While your proposed solution might work to replace the emojis with the relevant symbols, it lacks details on:

Which source are you going to rely on? I am not very confident with emojipedia.org emojis (this feedback is from my experience of atleast 1-1.5 years back)

I tried it and haven't seen any problem for the emojis I tried to fix so far, we can use it as I will be checking every emoji so in case some emoji doesn't work I can get that emoji from some other place. We can get the emojis from other sources like:- https://github.com/github/gemoji/blob/master/db/emoji.json

How will you identify the problematic emojis?

I will check every individual emoji at different platforms.

Is there a way to test this reliably?

I can create the list of problematic emojis and share it so that we can just replace all the emojis at emojis.js with them to test it.

How will you identify the problematic emojis?
I will check every individual emoji at different platforms.

@Puneet-here Considering the number of emojis to be checked? Can we either list down the problematic emojis or have a programmatic way to identify the problematic emojis?

Considering the number of emojis to be checked? Can we either list down the problematic emojis or have a programmatic way to identify the problematic emojis?

I don't think there's a programmatic way, I will list them down manually.

@mananjadhav do you think the manual approach is fine or should we try to find another solution?

@bfitzexpensify I started an internal thread here. I've tagged you.

Trying to wrap up the thread in Slack today so we can keep moving here.

So we've discussed this internally and here's the conclusion.

Instead of fixing some emojis, we've decided to update our datasource to also include Emoji 13 (and if possible Emoji 14) characters
I've evaluated a couple of datasources and so far Gemoji is closest to what we need (it's biggest shortcoming is missing Emoji 14 characters)
We don't want to update the structure of our format at the moment.
We don't want to break any existing feature (like Frequently used emojis).

Here's what we'll need from the proposal:

A working script which sources data from Gemoji to our format similar to this. This doesn't include creating any API to auto connect. Reading from a JSON dump to populating our assets/emojis.js should be fine.
All emojis to be rendered in symbol(emoji) representation on all platforms. None of them should be text representation.
An automated test that verifies that all the emojis are in Emoji representation and not the Text representation, so that when we add any new emoji, the same issue doesn't crop up.
All existing features working as expected, viz., Skin tone, Frequently used emojis, search emojis, categorization of the emojis, and UI related items like navigation, selection, hover, etc. @tgolen / @mvtglobally  can share if we maintain any internal regression suite here. For frequently used emojis, it could be that problematic emojis won't show up. That's fine and is expected.

@Puneet-here Because you were the one finding the Gemoji datasource and also with the closest proposal of replacing the emojis, I am going to give you a dibs on this one for 2 days. If we don't get a proposal from you, then we'll be open for proposals from others.

@tgolen @bfitzexpensify  Feel free to add/correct if I've missed anything.

@Puneet-here Quick bump here.

Open for proposals.

@Puneet-here Quick bump here.

Sorry, I didn't get the time to look into this. I will try in the morning.

Proposal
I checked the requirements and the Gemoji dataset. Following is what I propose for the code.

Take a dump of gemoji data as json
Run the script mentioned below
Copy data json to our src/assets/emojis.js file.

I also found that we can add alias to our dataset for future use. Also, I have merged keywords from our old dataset to new dataset so that we don't lose keywords. For example, 🙈 has 6-7 keywords in our dataset, but gemoji has only 3 keywords.
const _ = require("lodash");
const emojiData = require('./gemoji.json');
const oldEmojiData = require('./emoji.js');
const fs = require('fs');

const emojisGroupedByCategory = _.groupBy(emojiData, 'category');
const oldEmojiMap = _.keyBy(oldEmojiData, 'code');

const emojisList = [];
for(let category in emojisGroupedByCategory) {
    let categoryName = category.replace(' & ', 'And');
    categoryName = categoryName.charAt(0).toLowerCase() + categoryName.slice(1);
    emojisList.push({
        code: categoryName,
        header: true
    });
    const emojisPerCategory = emojisGroupedByCategory[category];
    for(let i = 0; i < emojisPerCategory.length; i++) {
        const emoji = emojisPerCategory[i];
        let keywords = emoji.tags;

        if(oldEmojiMap[emoji.emoji]) {
            keywords = keywords.concat(oldEmojiMap[emoji.emoji].keywords);
        }
        const emojiRow = {
            code: emoji.emoji,
            aliases: emoji.aliases,
            keywords: _.uniq(keywords)
        };
        emojisList.push(emojiRow);
    }
};

let data = JSON.stringify(emojisList);
fs.writeFileSync('new-emoji.json', data);

About the tests I tried but there is no pattern from which we can identify if our emoji has no text representation, But I compared the dataset and I found the different emojis, I can add a test
const problematicEmojis = ["◀", ...];
for(let i = 0; i < problematicEmojis.length; i++) {
    const isColoredEmoji = /fe0e$/.test(problematicEmojis[i]);
}

reassigning as I head ooo for 2 weeks

@akshayasalvi Thanks for the updated proposal. The script looks mostly good to me, but let's not worry about alias for now. If we decide to use it in the future, we can incorporate it at that time.
Are you sure there is nothing that will work for automatically detecting the emoji's? I don't think the test you mention would be worth it to add since it only contains a hard-coded list and wouldn't detect anything outside of that.

@tgolen I took sometime to check if something can be done in an automated way.  I couldn't find. Generally the text emojis end with fe0e unicode or nothing. So emojis like 😀  don't have text representation so when fe0e doesn't exist we don't know if it is ⚰  or 😀  type emojis.
Checked @akshayasalvi's proposal. It looks good. The only thing is:

You're merging the keywords that is a good idea, but the ones you said don't match, we'll lose keywords?
@tgolen If we're removing alias, should we add them to keywords?

Thank you for reviewing the proposal @tgolen. I couldn't find a way to automate this. This python package https://github.com/carpedm20/emoji/ uses unicode scraping for the emojis, but if we're using a source like gemoji then it won't make sense for us to scrap the records.
@mananjadhav I can try and add the keywords manually. There are some 150 odd ones, or a script to match the keywords may be.

Yes @akshayasalvi we can take a look at those and see if we're missing any keywords.

If we're removing alias, should we add them to keywords?

This would probably be a good idea, yeah. I could go for that.
Thanks for the additional thoughts on testing 👍 I guess there is no real automated way to go about it for now, so let's not have any automated testing be part of the proposal. It would maybe be good to think about adding some manual test cases to try and cover our bases at some point for our QA testing team.

@tgolen @mananjadhav Can I start with the PR?

You have my 🟢 for this @akshayasalvi but let @tgolen confirm once.

AFAICS the script will remove the skin tones.

You're right @Puneet-here, here's the piece of code that takes care of it. I've given a working example of the code and not the full script. Something on the lines of. In the PR I'll be testing the skin tones, frequently used emojis as pointed out earlier in the requests.
   if(emoji. skin_tones)  {
        emojiRow.types = ['1f3fb', '1f3fc', '1f3fd', '1f3fe',  '1f3ff'].map(skinTone => String.fromCodePoint(`${emoji.code}{skinTone}`));
   }

Thanks for the comment @Puneet-here.
That works @akshayasalvi  and String.fromCodePoint will need them to be unicode but we can handle that in the PR.

🟢 from me! @MitchExpensify you can officially hire them in upwork if you haven't yet.

Great! @akshayasalvi Please accept my invite to the Upwork Job and I will officially hire you, thanks!

I am working on this issue and completed partially. There's an issue with some emojis when I add skin tone to them. So working that out.

@mananjadhav I did, and I found that the issue exists with only Male/Female version of some odd 14-16 Emojis. I am going to update those and add up here.

I fixed the problematic emojis, I am verifying if there's any random one left. Testing the rest of the changes. PR should be ready for review by weekend or Monday.

Issue not reproducible during KI retests. (First week)

Draft PR is already raised. I am currently testing all the features. It should be ready for review in 1-2 days.

Issue not reproducible during KI retests. (Second week)

Issue not reproducible during KI retests. (Third week) @tgolen @MitchExpensify  Are we ok to close this?

@akshayasalvi are you still working on this? What is the status of your PR? Can you still reproduce the original problem?

Yes @tgolen I am working on it. I haven't been able to sync the main branch because it results in conflicts every time. I am just updating the final emoji list, keep a copy and then update it. I'll raise the full PR by tomorrow.

@akshayasalvi Did you get a chance to get that PR started?

@tgolen I created a second PR after all the fixes, but we have a new field in the emojis.js that is currently used for searching the PR. name is used in the emojis for searching and older dataset didn't have. I am working on the changes of the PR, to add the name. It is most similar to alias in gemoji.

@puneetlath is there guidance I'm missing on completing a BugZero checklist? Thank you https://stackoverflow.com/c/expensify/questions/14574

@MitchExpensify started a discussion on it here: https://expensify.slack.com/archives/C01SKUP7QR0/p1667427593134589

Nice! Will keep an eye out for an answer to that SO

Made a note to pay on my calendar!

@MitchExpensify SO is updated.

@tgolen Can I please request to increase the compensation for this one by some amount?
I didn't factor in the changes to process the emojis and refactor of the Tests. I know the tests are to be part of the PR, but the new emojis did break the current test, and I cleaned up some of the unwanted to code while fixing the tests not related to the change.
Would be great if you can consider the request.

@mananjadhav, following these instructions - Mind pointing to me to the PR that cause this bug?  Thank you

@MitchExpensify This has been a problem since the inception. What I mean is our emoji datasource didn't support them since the beginning. https://github.com/Expensify/App/pull/1991 here's the PR when we added the previous emojis with the emoji picker.

@puneetlath "A discussion in #contributor-plus has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner."
Curious for your thoughts as I try to follow these instructions, the PR that introduced the emoji picker didn't have a C+ or CME. Does it still make sense to post in #contributor-plus in a similar manner tagging internal engineers involved? Thank you!

Can I please request to increase the compensation for this one by some amount?

I can appreciate that there was more work required to complete this than was figured in the original proposal. However, I was pretty disappointed that it took almost a month to get the PR created for this.
You originally said on Sep 30:

PR should be ready for review by weekend or Monday.

The PR was taken out of draft and marked ready to review on Oct. 30 and there was a gap of nearly a month where the branch didn't have any commits.
If the work would have been done with greater urgency, I would be OK doubling the price of this issue, but due to the solution taking so long to get to completion, I am only approving a $500 increase to the price of this issue to a total of $1500.

@akshayasalvi Few points of feedback in addition to @tgolen mentioned.

While we understand conflicts arise, and if you see any impeding PR pushing frequent updates which causes you to resolve conflicts, just highlight so that we can put this on Hold.
As @tgolen mentioned, there was a long gap between commits, if you're going OOO or not working then please inform. Communication goes a long way in setting up expectations.
I also saw some commits with misses in the script, so if you felt you're stuck somewhere, clarify, and we can
Ideally we're looking for longer relationships with the contributors, so we don't want bad experiences neither for you or ourselves.  Appreciate that you refactored some of the code.

Making a note for myself:

Reporting payment will be issued via this Upwork Job
C+ and Contributor payment will be issued via this Upwork Job

@MitchExpensify I am already hired for this job with this link. When I click on the link you've shared it says Job no longer available.
I am guessing it's the same link, but still fyi.

@mananjadhav Yes all set! Issuing payment now

@Karim-30 mins accepting the offer here? Thank you!

Paid @mananjadhav & @akshayasalvi ! Thank you!

Thanks @MitchExpensify

@MitchExpensify Accepted the offer, Thanks.

@tgolen I got paid, we can close it.

Issue not reproducible during KI retests. (First week)

Conversation started in #contributor-plus here


Merge cloudflare branch into master

@inikulin would it be possible to merge this PR with a merge commit? I'd like to avoid rewriting the history of that branch if possible.

@marmeladema I'll reply in a private chat


Generate typespecs as well

How would you feel about adding support for typespecs?
  defcast inc(x :: integer), state: state, do: new_state(state + x)

would generate
@spec inc(x :: integer)
  def inc(pid, x), do: GenServer.cast(pid, {:inc, x})

I think that for your example, I prefer adding the @spec manually. The reason is that such approach is consistent with how specs are supplied in other modules.
With your proposal, we'd have to use both "inlined" specs and the explicit ones. In some cases even the ExActor powered modules would need to contain the combination of both styles. I fear that this would cause more confusion and so I'm not sure it's worth supporting this.


Update to Sadconsole v9 release

Quick change to use SadConsole v9.
Font -> IFont was the only breaking change.

Working locally on my end as well. I'm going to go ahead and merge this.  Thank you!


created and added image as per provided mock design

created and added grid_348_bhargav_sai_gajula.html in the 'modules/grid' folder and the appropriate images in the 'images & icon'

@NtemKenyor Please review and approve my pr


Large blur radius causes un-blurred image or other odd effects

Changing the blur radius to large values (I've seen issues as low as 46) results in a modified, but not-properly-blurred image.
You can reproduce by using MZFormSheetController's example app and changing line 26 in MZViewController:
[[MZFormSheetBackgroundWindow appearance] setBlurRadius:90.0];

The result is a non-blurred background. Interestingly, changing the blur radius to 80 yields:

I'm trying to find a documented limit to the blur radius, but have not found it yet. I don't see anything in MZFormSheetController or deeper into any of the Apple APIs that are called.
Any idea where the ceiling for blurred radius is?

No idea, i am using code shared by Apple.

Hi @m1entus,
could you provide some way to use this:
[[MZFormSheetBackgroundWindow appearance] setBackgroundBlurEffect:YES];

with this ?
[[MZFormSheetBackgroundWindow appearance] setBlurRadius:90.0f];
[[MZFormSheetBackgroundWindow appearance] setBlurSaturation:55.0f];

in all tests that I made, isn't possible to change the blurRadius.
thanks in advance

/*
Apply native background blur effect, you have to set backgroundBlurEffect to YES to apply blur!
By default, this is YES for iOS8, it is only available for iOS8
*/
@property (nonatomic, assign) BOOL shouldUseNativeBlurEffect

For iOS8 will use native UIBlurEffect by default so this will be ignored, if you set this flag to NO then will use screenshoting


Write tests for history engine's RefreshWorkflowTasks

What changed?
Write tests for history engine's RefreshWorkflowTasks

Why?
Improve coverage

Pull Request Test Coverage Report for Build 018f5b86-d4f3-45c3-9a57-ad88fe968cd8
Details

0 of 0   changed or added relevant lines in 0 files are covered.
38 unchanged lines in 7 files lost coverage.
Overall coverage increased (+0.02%) to 68.684%

Files with Coverage Reduction
New Missed Lines
%

service/history/shard/context.go
2
68.91%

service/history/task/transfer_active_task_executor.go
2
72.9%

service/matching/matcher.go
2
90.72%

service/history/task/transfer_standby_task_executor.go
4
87.04%

common/task/fifo_task_scheduler.go
4
83.51%

service/history/queue/timer_queue_processor_base.go
4
77.66%

service/history/task/task_util.go
20
70.57%

Totals

Change from base Build 018f5abe-dcfd-41a6-a917-2cc14ce02439:
0.02%

Covered Lines:
100905

Relevant Lines:
146911

💛  - Coveralls


Fix JUnit 4 support

It appears that support for JUnit 4 got broken at some point. It's possible that I'm just not formulating the commands or JVM arguments properly, but the RunListener doesn't appear to be firing events anymore.

I've been tracing through the execution, and the JUnit Foundation method interceptors aren't getting called for some reason. Without those being invoked, the lifecycle handlers fail.

Yup... it's Gradle, which is apparently using JUnit directly to execute the tests. By the time the agent runs, all of the classes I need to add hooks to have been loaded into the class cache, which means that the agent accomplishes precisely nothing. I'm searching the interweb for a way to configure Gradle to run the tests like Maven does - in a separate thread with its own class loader.

I upgraded JUnit Foundation to the latest Byte Buddy, and this appears to do the trick.


Allow cmake users to use FetchContent_Declare

Description
It would be nice for cmake users to be able to use something like the following to include Stan math in their projects
include(FetchContent)

FetchContent_Declare(
  stanmath
  GIT_REPOSITORY https://github.com/stan-dev/math
  GIT_TAG        v4.7.0
)

FetchContent_MakeAvailable(stanmath)

I have part of this written here where I have stan math compiling with cmake. I'd be happy to expand this into a CMakeLists.txt file in the stan math repo, which would then allow cmake users to do something like the above to include stan math in their projects.
Do any folks have objections to this? I'd say the cmake file I have there is like 60% complete. It does all the correct includes, but does not handle some of the specific flags we use. It also does not support MPI, but that should be easy to setup.
If I set this up we could also setup our test suite to integrate with ctest
Expected Output
Please provide the expected output.
If this is a bug report, show what you expected to happen. Please also show what currently happens.
If this is a feature request, show what you expect to happen if the feature exists.
Current Version:
v4.7.0

No objections!

I have my own version of this (modified from Steve’s) here: https://github.com/WardBrian/math/tree/experiment/cmake
It has a bit more flag configuration and some logic to support a “install” target for Math, which would let other tools use a find_library call


feat: add more fn

:tada: This pull request is included in version<EMAIL_ADDRESS>:tada:
The release is available on GitHub release


Happy Birthday.

After looking at your code, I have seen you do not minify your mod scripts so I figured I would post this as is. If there s anything wrong with it, then I don't know what it is because I've checked every line to the point of insanity to make sure it would work as an import.

Looks fine


Notifications for Hardware Wallet

[x] - Hardware Wallet error: connect your wallet or check the connection.
[x] - Hardware Wallet error: launch the BEAMapp

Pop-up without buttons (automatically closed).

[ ] Text: Output transaction is in process. Connect your Hardware Wallet to finalize the transaction.

[ ] Text: Input transaction is in process. Connect your Hardware Wallet to finalize the transaction.

[ ] QR code is wrong, we need to add a notification for the user: A hardware wallet is not connected. Please, connect the wallet

right view of the QR code

Left a comment in Figma for this part. No QR code. Text only
Pop-up without buttons (automatically closed).
Text: Output transaction is in process. Connect your Hardware Wallet to finalize the transaction.
Text: Input transaction is in process. Connect your Hardware Wallet to finalize the transaction.

For this one:
QR code is wrong, we need to add a notification for the user: A hardware wallet is not connected. Please, connect the wallet

Correct QR code


Update ro.json

1400rpm and his translation should be added to all languages since its missing. Tested on BEKO B5WFU78435WB<PHONE_NUMBER>).

Yes, you are correct. Using the device id you provided, I will generate new translation files (should hopefully be ready later this week) 😃

Happy to hear this!