fix some javadoc typos

Codecov Report

Merging #11 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #11   +/-   ##
=========================================
  Coverage     94.14%   94.14%
  Complexity       14       14
=========================================
  Files             5        5
  Lines           222      222
  Branches         20       20
=========================================
  Hits            209      209
  Misses            8        8
  Partials          5        5

Impacted Files
Coverage Δ
Complexity Δ

knot/src/main/kotlin/de/halfbit/knot/Knot.kt
95.65% <ø> (ø)
0 <0> (ø)
:arrow_down:

...t/src/main/kotlin/de/halfbit/knot/CompositeKnot.kt
95.12% <ø> (ø)
0 <0> (ø)
:arrow_down:

...c/main/kotlin/de/halfbit/knot/TestCompositeKnot.kt
100% <ø> (ø)
0 <0> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aae735e...e5a8821. Read the comment docs.


Use serializer when deserializing LazyDocument to T

When converting a LazyDocument to type T, use the JsonNetSerializer configured, along with all registered contract resolvers.
Fixes #2788

Can we also add an ovlerload to fix https://github.com/elastic/elasticsearch-net/issues/2408 as part of this PR.
Two for one :)

What overload were you thinking of for #2408, @Mpdreamz?

https://github.com/elastic/elasticsearch-net/blob/master/src/Nest/CommonAbstractions/LazyDocument/LazyDocument.cs#L21
Also a As(Type T) for dynamic invocations.

Gotcha

ported to 2.x in c77ee31e120b49a774cf5a463c1bb0cecf2cfb58
ported to master in bd71ff8f27585dc1477ed9bed6f47673190b2ac5


Missing configuration options in tabnine::config

Do you know why there are missing configuration options in tabnine::config when using nvim as opposed to say vscode? I no longer see options like multiline suggestions or  inline completions when using nvim. I remember being able to use multiline suggestions with the older compe-tabnine. Now this is no longer possible.

No idea.
Try changing the client parameter for tabnine, see if it make a difference.
Otherwise, open an issue with tabnine....


Implement serde::{Serialize, Deserialize} traits for Program

Implement serde::{Serialize, Deserialize} traits for Program
Description
In starknet_in_rust we need to serialize and  deserialize a Program, so we add the serde::Serialize and  serde::Deserialize implementations to the corresponding structs
Checklist

[ ] Linked to Github Issue
[ ] Unit tests added
[ ] Integration tests added.
[ ] This change requires new documentation.

[ ] Documentation has been added/updated.

The PR itself LGTM and I see no harm in doing it. However, I'm curious about why that need exists.
@Oppen
We save different types of structs in a  key-value storage . So, in order to save them we need to convert them into JSON and then save it as bytes


chore: get the full detailed text from Confluence

The idea is to get all the possible data from Confluence:
https://developer.atlassian.com/server/confluence/expansions-in-the-rest-api/
For example, if you use the regular storage endpoint it will give you the ID of the mentioned users inside the wiki pages but in the export_view you will get their full name and family, this will apply to all data that needs some post process like data in code views.
We tested this and we are super happy using export_view instead of storage end point.

Hi @pesarkhobeee , Thank you for the contribution!!
I think you'll need to update the test case and take a look at linting too.

Hey @anoopshrma , sorry I didn't check the tests, now they are aligned with my changes. I should emphasize again on the changes, you can see the official documentation about the new endpoint:

EXPORT_VIEW
HTML representation for viewing, but with absolute urls, instead of relative urls in the markup.

and compare it with the old one:

STORAGE
Raw database format, for content that stores data in our XML storage format

Hey!
Thank you for the contribution. Much appreciated!!


Timeout::elapsed_rounded_to()

Previously, Timeout::elapsed_rounded() was hard coded to round to the nearest millisecond. This renames the function and adds a parameter to specify what factor the duration should be rounded to.
For example, timeout.elapsed_rounded_to(Duration::from_millis(1)) returns the elapsed time rounded to the nearest millisecond.
This also adds a private function to round Durations more generally, and a private function to create a Duration from u128 of nanoseconds (Duration::from_nanos() takes a u64).

[ ] Fix // FIXME think this through
[ ] Maybe split this out into a method on Duration.

I’m working on a more generic Roundable trait.


Add component display name along with generated class

I'm raising this PR to replace https://github.com/styled-components/styled-components/pull/153 which I'll close. The commit log got into a bit of a mess and I couldn't pick it apart. This PR contains only the commits necessary for the final outcome of this change.
Add displayName as a class value in the output HTML when in development mode to make it easier to debug from the browser console
This PR adds the component displayName as a class when process.env.NODE_ENV !== 'production'

@JamieDixon This is great! I’ve also had a discussion with @mxstbr and @geelen on Twitter about this. I think this would pair very well with a babel-transform that adds displayNames to styled components in development (or also production).

@ehd Yes! We've tested this locally with the babel-transform (https://github.com/vdanchenkov/babel-plugin-styled-components-named) and it works great.

Hot damn, I want this 😄 Let me know if I can assist with this PR in any way. It would help in two projects I’m working on with a team where people had trouble finding components by name.

What's the reason for not prepending the name to the hash? I read #153 but couldn't quite make out why that was changed.
That would also guarantee that the name doesn't exist in the global namespace, without having to have tons of emojis in the DevTools. (not a fan of that)
Let's get this landed asap!

That would also guarantee that the name doesn't exist in the global namespace, without having to have tons of emojis in the DevTools. (not a fan of that)

Yeah, that’s a good point. If there’s no objection to concatenating I’d prefer that, too. Bonus: People are discouraged from writing external CSS matching on 💅FooBar💅 when it’s concatenated with the random string.

One of the problems I had was that the check for whether the className had been generated already was based on the hash (nameGenerator) and the hash has to be generated from a number as per generateAlphabeticName = (code: number). This meant we couldn't suffix with the displayName until after the hash was created but because of that, the check for a cashed hash wasn't taking into account the displayName. To get around this I thought it would be easier to just subvert the problem and append the displayName as a separate class name.
However, you're absolutely right that this isn't necessary and might cause other problems like name clashes. We can get around this by reverting to a similar proposal as earlier and have a hash and a hashSuffixed which we use for the cache. I'm about to submit the code that makes this change.
As for the emojis in the DevTools, I thought it was cute but I've removed it now :)

I think this PR is now ready and inline with your comments above. Let me know if there's more to be done here. 👍

Btw, I’d be happy to contribute a test case for this, but not sure where to push 😄

@ehd push a new branch based on this branch to your fork, and submit a PR against JamieDixon's fork!

@mxstbr @JedWatson I shall!

@mxstbr @JamieDixon Good morning/evening/timeZoneAppropriateGreeting! So the test case is fairly simple:
it('should add displayName as className suffix', () => {
  const Comp = styled.div``
  Comp.displayName = 'Comp'
  shallow(<Comp />)
  expectCSSMatches('.a-Comp { }')
})

However, something came to my attention:
The current implementation only attaches the displayName suffix when NODE_ENV=development, which I agree is a good idea.
However, when running the tests with NODE_ENV=development, the current test cases which assert on generated CSS all fail because each className is now suffixed with -styled-div.
This probably also means that when using styled-components in development, all current styled-components classNames will have a suffix of -styled-something unless you explicitly set displayNames or add the babel transform. This might actually add value to the current class names by hinting at where they are coming from and thereby help devs with finding definitions.
Two questions:

Should we set NODE_ENV=development when running tests?
Should we change the suffix generation to only suffix for custom displayNames? Or adjust the current tests?

Should we set NODE_ENV=development when running tests?

Can we somehow test that it does the appending in dev, but doesn't do it prod? (i.e. test both cases?)

Should we change the suffix generation to only suffix for custom displayNames? Or adjust the current tests?

I like this. styled-div seems a bit pointless, since one sees <div class="xYhfd-styled-div" /> in the DevTools – well, who would've thought it's a div! 😱

Can we somehow test that it does the appending in dev, but doesn't do it prod? (i.e. test both cases?)

I wouldn’t want to add an extra parameter to ComponentStyle and make it part of the public API.
Run mocha twice with different NODE_ENV settings.
Override process.env.NODE_ENV before and after that test.

I think 3 is the smallest change but could break, 2 is the cleanest, 1 doesn’t seem worth it.
Also, we should check for NODE_ENV !== 'production' instead of checking for dev like React does.

I like this. styled-div seems a bit pointless, since one sees  in the DevTools – well, who would've thought it's a div! 😱

That was my first impression, but then I thought it might hint at where these otherwise random classNames are originating from 🤔

Thanks for this feedback @ehd. Loving it :)
I switched NODE_ENV !== production in one of the latest commits to fix the broken tests, otherwise I agree that it's the better approach.
For the cases where xYhfd-styled-div is an issue, I'd suggest using the https://github.com/vdanchenkov/babel-plugin-styled-components-named plugin to ensure displayName is correctly added. This is how we're doing it on our project.
RE the environment during a test, I'm a big fan of tests being clear and easy to understand at a glance. This is one of the reasons I never use beforeTest and afterTest hooks. I like the look of option 3 the most "Override process.env.NODE_ENV before and after that test" where we set the NODE_ENV twice as part of a single atomic test. What do you think?
I'm happy to change the test to !== production and to double up on the current tests so we check that the displayName is appended when NODE_ENV=test and not appended when 'production'.
Thoughts?

Thanks for this feedback @ehd. Loving it :)

Thank you, I appreciate that! I love this PR! 😄

I switched NODE_ENV !== production in one of the latest commits to fix the broken tests, otherwise I agree that it's the better approach.

Gotcha!

For the cases where xYhfd-styled-div is an issue, I'd suggest using the https://github.com/vdanchenkov/babel-plugin-styled-components-named plugin to ensure displayName is correctly added. This is how we're doing it on our project.

I was planning on adding the transform to the projects where I’m using styled-components. I reckon @mxstbr was thinking of cases when the transform hasn’t been added. I’m personally still leaning towards adding display name suffixes even if they’re just going to result int -styled-something, but leaving them out seems perfectly fine, too.

RE the environment during a test, I'm a big fan of tests being clear and easy to understand at a glance. This is one of the reasons I never use beforeTest and afterTest hooks. I like the look of option 3 the most "Override process.env.NODE_ENV before and after that test" where we set the NODE_ENV twice as part of a single atomic test. What do you think?

Yeah, that sounds good! Also allows you to see the expected behavior around NODE_ENV at a glance instead of having to look at two test runs in package.json or something.

I'm happy to change the test to !== production and to double up on the current tests so we check that the displayName is appended when NODE_ENV=test and not appended when 'production'.

Btw, NODE_ENV isn’t even set to test as far as I know, currently it’s just not set at all during testing. So if we change it back to matching !== production'` that should work out for tests, too! Adjusting current tests was as simple as replacing ".a " and ".b " with ".a-styled-div " and ".b-styled-div " respectively.
Only need to agree on classNames generated from default displayNames now :)

I’m personally still leaning towards adding display name suffixes even if they’re just going to result int -styled-something, but leaving them out seems perfectly fine, too.

I don't have a hugely strict opinion on this, if you prefer it so be it! 👍

Is there anything left to be done here?

Everything works as it is however if we want to change the check to NODE_ENV !== production then I'll need some time to change all the tests and write new tests for the condition where NODE_ENV ===  production.
I'm happy to do that and could even do it as a separate PR once this is merged in? Might be best if people would get a lot of value from this right now. What do you think?

Let's do that fix first, I don't want to ship a version just to ship another one straight afterwards that works differently!

The fix is now done. I've changed to using NODE_ENV !== 'production' and updates all test cases.
The next step is to add new tests that check that the display name is not added when we're in production mode. Happy to do that as part of this PR or as a separate update.

Looking great 😄 I’m also happy to contribute the additional tests then!

Please add that test so we got it, then we can merge and ship this! 🎉

@JamieDixon Will send a PR your way tonight!

🎉 → https://github.com/JamieDixon/styled-components/pull/1/files

Thanks @ehd. Awesome stuff! Looking forward to landing this one. The people on our team will be so happy 💃

Hey just caught up on this issue, had a couple of thoughts.
I don't think the -styled-div should be added unless the user has set the displayName (i.e. with the babel plugin). Given that most people are starting without that, it seems noisy to add it to all their classnames.
Also, be careful with anything that affects caching behaviour between dev and prod. There could be some spectacular bugs introduced that way, which people will only see when pushing to prod. Rare, sure, but high pain.
Personally I'd inject an unselectable classname instead of concatenating the hashed class. Like, starting with a number or a zero-width space character or something. TBH the 💅 would be sufficient.
Looks great otherwise. Very keen to try to make the dev env here as good as possible 👍

Also, be careful with anything that affects caching behaviour between dev and prod. There could be some spectacular bugs introduced that way, which people will only see when pushing to prod. Rare, sure, but high pain.

How does this affect caching behaviour between dev and prod? When would there ever be an overlap between those two?

Any update here?

This will superseded by #227 which solves this problem in a more thorough way. Together with the new babel-plugin-styled-components (which builds upon the original styled-components-named) we'll have comprehensively solved this, and a bunch of other, issues. I'm working on getting #227 shipped literally all of today!
Sorry for letting you go through all of this effort @JamieDixon just to then not merge this PR, but it set us off in the right direction!

@mxstbr Oh hey this is even more awesome, thank you so much!
On Sat, 26 Nov 2016 at 10:34 Max Stoiber<EMAIL_ADDRESS>wrote:

Closed #160
https://github.com/styled-components/styled-components/pull/160.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/styled-components/styled-components/pull/160#event-872566734,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAEpsBL8Kvw2BQjfYzwwdvwzvllTIJX7ks5rB_0XgaJpZM4KnFyT
.

Aha! Well great, glad that there's a better solution to this problem. Being new to OSS it feels hard when a PR doesn't get merged but the learning from feeling bad is always good. New personal discoveries made. 💃

Really sorry for not merging it @JamieDixon, seriously thanks so much for taking the time to make this happen!


CircleCI PR swift check fails with error: outdated Homebrew version

New Issue Checklist

[x] Updated fastlane to the latest version
[x] I read the Contribution Guidelines
[x] I read docs.fastlane.tools
[x] I searched for existing GitHub issues

Issue Description

Starting 5 days ago, a couple of CircleCI jobs are failing their Validate Fastlane.swift generation step, with: Error: Your Homebrew is too outdated for `brew bundle`. Please run `brew update`!
https://app.circleci.com/pipelines/github/fastlane/fastlane/6676
https://app.circleci.com/pipelines/github/fastlane/fastlane/6677
https://app.circleci.com/pipelines/github/fastlane/fastlane/6678
Command executed

On CI: bundle exec fastlane generate_swift_api
Complete output when running fastlane, including the stack trace and command used

https://app.circleci.com/pipelines/github/fastlane/fastlane/6678/workflows/00d0ce06-1b15-45b0-8c2f-89d9719a1969/jobs/102690/parallel-runs/0/steps/0-108?invite=true#step-108-202794_81
Environment
CircleCI

Resolved by #20898


error saving dataframe to emr 9.0 (spark 2.2)

error saving dataframe to emr 9.0 (spark 2.2)
read works ok

forgot to post the error please assist
eventsDF.write.format("com.databricks.spark.redshift").option("url", JdbcURL).option("dbtable", "public.dwdate2").option("user",RedshiftUserName).option("aws_iam_role", IamRoleUrl).option("password","Rs030629").option("tempdir", S3TempTable).save()
17/10/31 00:23:27 WARN Utils$: The S3 bucket dwh-mlp-test does not have an object lifecycle configuration to ensure cleanup of temporary files. Consider configuring tempdir to point to a bucket with an object lifecycle policy that automatically deletes files after an expiration period. For more information, see https://docs.aws.amazon.com/AmazonS3/latest/dev/object-lifecycle-mgmt.html
17/10/31 00:23:27 WARN Utils$: The S3 bucket dwh-mlp-test does not have an object lifecycle configuration to ensure cleanup of temporary files. Consider configuring tempdir to point to a bucket with an object lifecycle policy that automatically deletes files after an expiration period. For more information, see https://docs.aws.amazon.com/AmazonS3/latest/dev/object-lifecycle-mgmt.html
[Stage 1:>                                                          (0 + 2) / 2]17/10/31 00:23:31 WARN TaskSetManager: Lost task 1.0 in stage 1.0 (TID 2, ip-10-226-41-36.ec2.internal, executor 1): org.apache.spark.SparkException: Task failed while writing rows
at org.apache.spark.sql.execution.datasources.FileFormatWriter$.org$apache$spark$sql$execution$datasources$FileFormatWriter$$executeTask(FileFormatWriter.scala:272)
at org.apache.spark.sql.execution.datasources.FileFormatWriter$$anonfun$write$1$$anonfun$apply$mcV$sp$1.apply(FileFormatWriter.scala:191)
at org.apache.spark.sql.execution.datasources.FileFormatWriter$$anonfun$write$1$$anonfun$apply$mcV$sp$1.apply(FileFormatWriter.scala:190)
at org.apache.spark.scheduler.ResultTask.runTask(ResultTask.scala:87)
at org.apache.spark.scheduler.Task.run(Task.scala:108)
at org.apache.spark.executor.Executor$TaskRunner.run(Executor.scala:335)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
Caused by: java.lang.AbstractMethodError: org.apache.spark.sql.execution.datasources.OutputWriterFactory.getFileExtension(Lorg/apache/hadoop/mapreduce/TaskAttemptContext;)Ljava/lang/String;

Did you debug? What are your findings?


Unable to publish extension due to: - Incompatible API version (5.1)

Hi, We're using AzureDevOps Server 2019 and we tried to install this add-ons but run into issue " Unable to publish extension due to: - Incompatible API version (5.1)", does anybody have any suggestion to install this to ADO Server 2019? thanks

Thanks for reporting @kevinjonna19 . We'll dig into this.

It should work, let me know if you still have the same issue.

@AminTi - we've just come across this same issue using the latest extension from the marketplace.

@AminTi  this page seems to suggest the 'supported' API version for 2019 is 5.0 - does this mean the extenstion doesn't work with Azure Devops Server 2019?
https://learn.microsoft.com/en-us/azure/devops/integrate/concepts/rest-api-versioning?view=azure-devops


creating output instead of throwing solverError

Description
Fixes #1992
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

[x] New feature (non-breaking change which adds functionality)
[x] Optimization (back-end change that speeds up the code)
[ ] Bug fix (non-breaking change which fixes an issue)

Key checklist:

[ ] No style issues: $ flake8
[ ] All tests pass: $ python run-tests.py --unit
[ ] The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.
Further checks:

[x] Code is commented, particularly in hard-to-understand areas
[ ] Tests added that prove fix is effective or that feature works

checks are failing at  test_casadi_solver.TestCasadiSolver.test_model_solver_failure because the tests that expect a SolverError are now getting a SolverWarning. Also the tests all fail in the first timestep without creating a solution.  This wasn't a problem since a SolverError was raised and the test terminated as expected. Now though the following functions can't run, since the solution object was only created as "None" and therefore has no properties.
Now a test is needed that creates a solution in the first timestep but runs into a problem in a later timestep, so that there already is a solution object that can be processed by the follow up functions. @tinosulzer could you help out with creating such a test?

See extra comments added with ####
def test_model_solver_failure(self):
        # Create model
        model = pybamm.BaseModel()
        var = pybamm.Variable("var")
        model.rhs = {var: -pybamm.sqrt(var)}
        model.initial_conditions = {var: 1}
        # add events so that safe mode is used (won't be triggered)
        model.events = [pybamm.Event("10", var - 10)]
        # No need to set parameters; can use base discretisation (no spatial operators)

        # create discretisation
        disc = pybamm.Discretisation()
        model_disc = disc.process_model(model, inplace=False)

        solver = pybamm.CasadiSolver(
            extra_options_call={"regularity_check": False}, dt_max=1e-3
        )
        #### By reducing dt_max, this one should pass. You need to add a check that the final solution
        #### does indeed stop before t=20
        # Solve with failure at t=2
        t_eval = np.linspace(0, 20, 100)
        with self.assertWarns(pybamm.SolverWarning):
            solver.solve(model_disc, t_eval)
        # Solve with failure at t=0
        model.initial_conditions = {var: 0}
        model_disc = disc.process_model(model, inplace=False)
        t_eval = np.linspace(0, 20, 100)
        #### This one should fail immediately and throw a `SolverError`
        #### since no progress can be made from the first timestep
        with self.assertWarns(pybamm.SolverWarning):
            solver.solve(model_disc, t_eval)

Continued in #2350


nixos/sway: refactoring of package option

Description of changes
I started using swayfx yesterday, but found a discrepancy in the environment variables compared to sway. Initially I didn't look at the module implementation and just passed with pkgs; sway.override { sway-unwrapped { sway-unwrapped = swayfx; }; to programs.sway.packages assuming that this would override the package for the module and everything would work as before. In reality, it breaks several options.
So I created this PR where instead of the defaultSwayPackage variable that overrides pkgs.sway, I use a function that overrideы the user-defined package, but only if the package contains the necessary arguments.

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

guys @SebTM @primeos @thiagokokada?

LGTM, but currently not using sway so not tested other than nixpkgs-review 👍🏻
Let me ask two questions here:

Is there a way we can extend the tests to cover the changed behavior/catch different behaviors on future changes early?
Would it be an option to change the package-option and check if the package supports these overrides and then provide them on the go if the user changes the package?

For the second question it's rather an idea for better/easier UX than a we have to change that to get it merged ✌🏻

Superseded by #270013

Oh oops sorry! Not exactly, something like this is still needed!

and apply wrapSway to it.

But what if someone wants to pass a packet that swayWrapper should not apply to? Don't think this is a good solution

and apply wrapSway to it.

But what if someone wants to pass a packet that swayWrapper should not apply to? Don't think this is a good solution

The wrapper is effectively a noop if you set wrapperFeatures.base and wrapperFeatures.gtk to false, so I don't think this is an issue at all.
On the flip side, currently you just can't install sway forks that aren't pre-wrapped and expect them to work, which makes no sense.

The wrapper is effectively a noop (just swaps sway out with a wrapper that immediately calls sway and does nothing else) if you set wrapperFeatures.base and wrapperFeatures.gtk to false, so I don't think this is an issue at all

When I was working on this #259066 had not yet been reverted, so there were other options that used cfg.package inside.

On the flip side, currently you just can't install sway forks that aren't pre-wrapped and expect them to work, which kind of defies the purpose of even having a package option

Furthermore, even if you set a wrapped fork, the other options will not be applied to your package. At this point, the only thing you can do is write something like this:
  programs.sway.packages = pkgs.sway.override {
    sway-unwrapped = pkgs.swayfx;
    extraSessionCommands = config.programs.sway.extraSessionCommands;
    extraOptions = config.programs.sway.extraOptions;
    withBaseWrapper = config.programs.sway.wrapperFeatures.base;
    withGtkWrapper = config.programs.sway.wrapperFeatures.gtk;
  };

Furthermore, even if you set a wrapped fork, the other options will not be applied to your package.

Ah, yeah, you're right. wrapSway would need to be changed to take the arguments the module needs so this can be done reasonably.

Ah, yeah, you're right.

That's not exactly what I meant when I wrote the previous answer. I forgot about that bad PR that added wrapSway, without lib.makeOverridable. But that can be easily fixed. The problem I was talking about is in the module. Right now, the default value of programs.sway.package is an internal variable, not a package, which is then used to apply overrides to it:
https://github.com/NixOS/nixpkgs/blob/fd44c780f0e79e69e6ccde779f9f19c89669f215/nixos/modules/programs/wayland/sway.nix#L29-L47
So if you change programs.sway.package to any value, the other module options will not be applied to your package, even if they could be. This is exactly what I meant when I said:

Furthermore, even if you set a wrapped fork, the other options will not be applied to your package

@kira-bruneau @primeos @thiagokokada any review/merge? I still think this is good changes. Should I ping someone else for a review?

Oh yep sorry! I was testing this out a couple of weeks ago, but ran into problems and didn't figure out what was wrong. Will try again today though!

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/what-is-the-right-way-to-add-optional-pkgs-to-nixos-binary-cache/37547/1


Add Feature Flag To Skip Failures

I have a third party database that I cannot change it. Is there a way to silently fail and still generate the correct entities?
reform-db: 2018/11/10 04:33:51.656895 cmd_init_sqlite3.go:85: no such module: spellfix1
panic: no such module: spellfix1

goroutine 1 [running]:
gopkg.in/reform.v1/internal.(*Logger).Fatalf(0xc0000938f0, 0x45377d0, 0x2, 0xc000348a60, 0x1, 0x1)
	/Users/mgonzalez/go/src/gopkg.in/reform.v1/internal/logger.go:51 +0x107
main.initModelsSQLite3(0xc00009c8a0, 0xc0000dbbd0, 0x400b9bd, 0x44dd240)
	/Users/mgonzalez/go/src/gopkg.in/reform.v1/reform-db/cmd_init_sqlite3.go:85 +0x469
main.cmdInit(0xc00009c8a0, 0xc00001e004, 0x1f)
	/Users/mgonzalez/go/src/gopkg.in/reform.v1/reform-db/cmd_init.go:184 +0xb2f
main.main()
	/Users/mgonzalez/go/src/gopkg.in/reform.v1/reform-db/main.go:128 +0x3a4

Something like the following:
https://stackoverflow.com/questions/38425835/reflecting-sqlite-database-with-spellfix1-tables
Edit:
Even better, something like --skip-tables I think would be less invasive?

panic: no such module: spellfix1

goroutine 1 [running]:
gopkg.in/reform.v1/internal.(*Logger).Fatalf(0xc0000938f0, 0x45377d0, 0x2, 0xc000348a60, 0x1, 0x1)
	/Users/mgonzalez/go/src/gopkg.in/reform.v1/internal/logger.go:51 +0x107
main.initModelsSQLite3(0xc00009c8a0, 0xc0000dbbd0, 0x400b9bd, 0x44dd240)
	/Users/mgonzalez/go/src/gopkg.in/reform.v1/reform-db/cmd_init_sqlite3.go:85 +0x469
main.cmdInit(0xc00009c8a0, 0xc00001e004, 0x1f)
	/Users/mgonzalez/go/src/gopkg.in/reform.v1/reform-db/cmd_init.go:184 +0xb2f
main.main()
	/Users/mgonzalez/go/src/gopkg.in/reform.v1/reform-db/main.go:128 +0x3a4```

Is it the same as #174?

@AlekSi Yes, you want me to close this one?

Closing as duplicate of #174.

Ok, that's a somewhat different issue. Reopening.
The proper fix is to log an error and continue to the next loop iteration there. PRs are welcome.

@AlekSi I feel that this behavior should be configurable. How you feel about adding an extra flag to comand-db. Either way, I can take the work :) (just checking what are your thoughts about it.)

Is this flag still needed? I can give this a shot


NetworkBoundResource - Can we use it if we are not saving the API response to a Room DB?

It seems NetworkBoundResource works on the bases that, the data is stored in the DB. I have data I want to fetch from an API, however this data won't be stored in the DB as it does not need to live longer than the users session on the activity lifecycle. How could we still use NetworkBoundResource in this case?

To answer my own question, what I have come up with is to build a cache class, that the repository also knows about and in cases where I dont need data saved to the DB, I store it in the cache. The cache class returns the data using LiveData signals and this works well with the NetworkBoundResource methods.
If there is a better way of doing this, I would love to hear it.

If you don't have to cache, you don't need it at all. I used the service directly in the repository and it worked seamlessly.

That sounds great. Could you give me an example if possible? Would really appreciate! Thanks

Of course. I will use UserRepository for simplicity's sake. In loadUser(String login), Notice this method returns LiveData<Resource<User>>, and GithubSerivce#getUser() returns LiveData<ApiResponse<User>>, which is very similiar, I removed the Resource wrapper and made the both methods returns LiveData<ApiResponse<List<Repo>>>.
Consequently, the UserRepository#getuser(String login) became like this. and that doesn't affect UserViewModel or LiveDataCallAdapter
public LiveData<Resource<User>> loadUser(String login) {
        return githubService.getUser(login);
}

So, what I did is totally removing NetworkBoundResource, some might have objection for that, cuz Resource<T> can handle some network errors. So, I change the ApiResponse<T> to handle some errors.
public final class ApiResponse<V> {

    @Nullable
    private final V data;

    @Nullable
    private final Throwable error;

    /**
     * In Case of successful API request, pass the received data here.
     *
     * @param Data received data from successful API Call.
     */
    public ApiResponse(@NonNull final V Data) {
        Objects.requireNonNull(Data);

        this.data = Data;
        this.error = null;
    }

    /**
     * In case of failed API request, pass error.
     * @param error The cause of the failed API Call.
     */
    public ApiResponse(@NonNull final Throwable error) {
        Objects.requireNonNull(error);

        this.error = error;
        this.data = null;
    }

    public boolean isSuccessful() {
        return data != null && error == null;
    }

    @NonNull
    public V getData() {
        if (data == null) {
            throw new IllegalStateException("Data is null; Call ApiResponse#isSuccessful() first.");
        }
        return data;
    }

    @NonNull
    public Throwable getError() {
        if (error == null) {
            throw new IllegalStateException("error is null; Call ApiResponse#isSuccessful() first.");
        }
        return error;
    }
}

ApiResponse<V> either has data or error where you can set the error LiveDataCallAdapter like this:
@Override
public void onFailure(@NonNull Call<R> call, @NonNull Throwable throwable) {
    postValue(new ApiResponse<>(throwable));
}

However, if you want to keep the Resource<T> wrapper, the turn around for that is editing NetworkBoundResource and change the logic by removing db related actions and shouldFetch() will be always true, BUT I guess NetworkBoundResource became useless and more complex.

@amrro Thanks for the sample and explanation. This does indeed look like a good solution. However, in some cases, I need the Repo to decide, if it should fetch from a DB or from the network. I think in my case, I might need to keep NetworkBoundResource. I will try implement some of your recommendations though.

https://github.com/googlesamples/android-architecture-components/issues/288

@amrro and @RJ-Clegg Can you tell me how to add loader if i don't want to use NetworkBoundResource ?


ci: adding zap on the CI for verification

Description
Fixing security issues reported by ZAP
Fixes # (issue)
Type of change

[x] Bug fix (non-breaking change which fixes an issue)

Further comments

Thanks for the PR!
Any successful deployments (not always required) will be available here
Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow

can we remove the backend route @paulushcgcj @DerekRoberts , we don't need it

@mishraomp @paulushcgcj Backend route removed!

@mishraomp @paulushcgcj Backend route removed!

I think some changes need to support this, since I dont see caddy reverse prxying request to backend @paulushcgcj ?

@mishraomp @paulushcgcj Backend route removed!

I think some changes need to support this, since I dont see caddy reverse prxying request to backend @paulushcgcj ?

This won't be done right now as it will require more test and some adaptations here and there to accommodate this. For now it stay outside of Caddy

@mishraomp @paulushcgcj Backend route removed!

Please don't do that, reverting the route for now

may be a ticket in the backlog to align this with QSOS , thoughts?

do we need this in frontend?
    <script>
      window.global = window
      var exports = {}
    </script>

This PR will close #850 and #851

This one closes #850

This one closes #851


ARROW-3374: [Python] Implicitly set from_pandas=True when passing pandas.Categorical to pyarrow.array. Preserve ordered categories

+1


feat(api): remove dependency from fingerprintjs

:tada: This PR is included in version 2.59.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Create Feature object

Related to #61

I first tried creating a Feature class, but then, I reilase it could be complex to explain to users in the docs. It can be done with things like @hideconstructor, but it seemed artificial to me.
I finally "added it" by documenting a Feature object type, similar to CartoError. In this way it is more clear that a Feature is a type of something that we will provide, instead of a class that the user can instantiate in order to do something.


Gradle error configuring project ':google_api_availability'

🔙 Regression
Hello,
After upgrading to latest flutter beta (0.9.4) I cannot run my app which depends on this plugin.
Here is the error occurred when running gradle
           FAILURE: Build failed with an exception.

           * What went wrong:
           A problem occurred configuring project ':google_api_availability'.
           > Failed to notify project evaluation listener.
              > java.lang.AbstractMethodError (no error message)

Old (and correct) behavior
No error when running gradle
Current behavior
Error running gradle
Reproduction steps
Update to latest flutter beta (0.9.4), run app that depends on this plugin.
Configuration
Flutter doctor output
[√] Flutter (Channel beta, v0.9.4, on Microsoft Windows [Version 10.0.17763.55], locale en-US)
    • Flutter version 0.9.4 at D:\Devs\Flutter\flutter
    • Framework revision f37c235c32 (2 weeks ago), 2018-09-25 17:45:40 -0400
    • Engine revision 74625aed32
    • Dart version 2.1.0-dev.5.0.flutter-a2eb050044

[√] Android toolchain - develop for Android devices (Android SDK 28.0.2)
    • Android SDK at D:\AndroidSDK
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-28, build-tools 28.0.2
    • ANDROID_HOME = D:\AndroidSDK
    • Java binary at: D:\AndroidStudio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1024-b02)
    • All Android licenses accepted.

[√] Android Studio (version 3.1)
    • Android Studio at D:\AndroidStudio
    • Flutter plugin version 27.1.1
    • Dart plugin version 173.4700
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1024-b02)

[√] VS Code, 64-bit edition (version 1.27.2)
    • VS Code at C:\Program Files\Microsoft VS Code
    • Flutter extension version 2.19.0

[√] Connected devices (1 available)
    • Redmi 3S • c37ae0927d63 • android-arm64 • Android 6.0.1 (API 23)

• No issues found!

Version: 2.0.1
Platform:

[ ] :iphone: iOS
[x] :robot: Android

Ah sorry I didn't see there is an update to this plugin. Gonna update & check it again.

It still happened after upgrading.

@skybur we have just release version 2.1.0 of the Geolocator plugin, this should solve you problem.

@mvanbeusekom hello, sorry but I tried with a newly created project, added this plugin and the issue still happened. I don't know if the issue caused by this plugin or my environment. Is there anything I can do?

Here is the top level build.gradle &  app build.gradle file
buildscript {
    ext.kotlin_version = '1.2.30'
    repositories {
        google()
        jcenter()
    }

    dependencies {
        classpath 'com.android.tools.build:gradle:3.1.2'
        classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlin_version"
    }
}

allprojects {
    repositories {
        google()
        jcenter()
    }
}

rootProject.buildDir = '../build'
subprojects {
    project.buildDir = "${rootProject.buildDir}/${project.name}"
}
subprojects {
    project.evaluationDependsOn(':app')
}

task clean(type: Delete) {
    delete rootProject.buildDir
}

def localProperties = new Properties()
def localPropertiesFile = rootProject.file('local.properties')
if (localPropertiesFile.exists()) {
    localPropertiesFile.withReader('UTF-8') { reader ->
        localProperties.load(reader)
    }
}

def flutterRoot = localProperties.getProperty('flutter.sdk')
if (flutterRoot == null) {
    throw new GradleException("Flutter SDK not found. Define location with flutter.sdk in the local.properties file.")
}

def flutterVersionCode = localProperties.getProperty('flutter.versionCode')
if (flutterVersionCode == null) {
    flutterVersionCode = '1'
}

def flutterVersionName = localProperties.getProperty('flutter.versionName')
if (flutterVersionName == null) {
    flutterVersionName = '1.0'
}

apply plugin: 'com.android.application'
apply plugin: 'kotlin-android'
apply from: "$flutterRoot/packages/flutter_tools/gradle/flutter.gradle"

android {
    compileSdkVersion 27

    sourceSets {
        main.java.srcDirs += 'src/main/kotlin'
    }

    lintOptions {
        disable 'InvalidPackage'
    }

    defaultConfig {
        // TODO: Specify your own unique Application ID (https://developer.android.com/studio/build/application-id.html).
        applicationId "com.terreciel.testgeo"
        minSdkVersion 16
        targetSdkVersion 27
        versionCode flutterVersionCode.toInteger()
        versionName flutterVersionName
        testInstrumentationRunner "android.support.test.runner.AndroidJUnitRunner"
    }

    buildTypes {
        release {
            // TODO: Add your own signing config for the release build.
            // Signing with the debug keys for now, so `flutter run --release` works.
            signingConfig signingConfigs.debug
        }
    }
}

flutter {
    source '../..'
}

dependencies {
    implementation "org.jetbrains.kotlin:kotlin-stdlib-jre7:$kotlin_version"
    testImplementation 'junit:junit:4.12'
    androidTestImplementation 'com.android.support.test:runner:1.0.2'
    androidTestImplementation 'com.android.support.test.espresso:espresso-core:3.0.2'
}

Finally I fixed it by updating my gradle & kotlin version. thank you very much

@skybur, happy to hear you managed to solve the problem. I must admit I also ran in to this and indeed could solve it by manually upgrading gradle & kotlin. For other people running into this problem, I simply made the same changes as Flutter did in the following PR: https://github.com/flutter/flutter/pull/22790/files
I bit more background information can be found here: https://github.com/flutter/flutter/issues/22614

Thanks @mvanbeusekom   I fixed it by updating my gradle & kotlin version

For someone just coming in:
build.gradle (app)
ext.kotlin_version = '1.2.71'
and
classpath 'com.android.tools.build:gradle:3.2.1'
gradle-wrapper.properties
distributionUrl=https\://services.gradle.org/distributions/gradle-4.10.2-all.zip
This worked for me, with geolocator: '^2.1.0'
I stumbled on this one after upgrading flutter to 0.11.3, after these changes it works.


Volto production docker builds failure with webpack error

Volto production builds fails in docker.
To Reproduce
Steps to reproduce the behavior:

Checkout plone volto training github repo https://github.com/collective/training-deploy-project
Change directory to local root directory of the repo.
Initialize a new volto code base and use 'frontend' default addon name.
Change directory into 'frontend' and yarn install and yarn start
Build a new frontend container with 'make build-image)

Expected behavior
Docker build fails with webpack module missing error. How docker builds succeed if you remove '--prod' entry in the dockerfile https://github.com/collective/training-deploy-project/blob/main/frontend/Dockerfile#L16
$ yarn omelette && yarn patches
yarn run v1.22.17
$ ln -sf node_modules/@plone/volto/ omelette
Done in 0.04s.
yarn run v1.22.17
$ /bin/bash patches/patchit.sh > /dev/null 2>&1 ||true
Done in 0.04s.
Done in 238.86s.
Removing intermediate container e1d6cbd070f7
 ---> 37d81c8602db
Step 7/15 : COPY . .
 ---> f1f52f7ed646
Step 8/15 : RUN yarn build
 ---> Running in 20e6291a3aff
yarn run v1.22.17
$ razzle build
internal/modules/cjs/loader.js:905
  throw err;
  ^

Error: Cannot find module 'webpack'
Require stack:
- /usr/src/app/node_modules/mini-css-extract-plugin/dist/index.js
- /usr/src/app/node_modules/mini-css-extract-plugin/dist/cjs.js
- /usr/src/app/node_modules/razzle/config/createConfigAsync.js
- /usr/src/app/node_modules/razzle/scripts/build.js
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:902:15)
    at Function.Module._load (internal/modules/cjs/loader.js:746:27)
    at Module.require (internal/modules/cjs/loader.js:974:19)
    at require (internal/modules/cjs/helpers.js:101:18)
    at Object.<anonymous> (/usr/src/app/node_modules/mini-css-extract-plugin/dist/index.js:8:39)
    at Module._compile (internal/modules/cjs/loader.js:1085:14)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1114:10)
    at Module.load (internal/modules/cjs/loader.js:950:32)
    at Function.Module._load (internal/modules/cjs/loader.js:790:12)
    at Module.require (internal/modules/cjs/loader.js:974:19) {
  code: 'MODULE_NOT_FOUND',
  requireStack: [
    '/usr/src/app/node_modules/mini-css-extract-plugin/dist/index.js',
    '/usr/src/app/node_modules/mini-css-extract-plugin/dist/cjs.js',
    '/usr/src/app/node_modules/razzle/config/createConfigAsync.js',
    '/usr/src/app/node_modules/razzle/scripts/build.js'
  ]
}
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
The command '/bin/sh -c yarn build' returned a non-zero code: 1

**Software (please complete the following information):**

- OS: Ubuntu
- Browser  Firefox
- Volto Version  14 (Stable) and 15(Alpha8)
- Plone Version  6-Dev
-
**Additional context**

Downstream bug https://github.com/collective/training-deploy-project/issues/4

@ericof I had better luck with production builds with following command.
yarn install --frozen-lockfile --no-cache --production

I will test it as well

Resolved by using the command in https://github.com/plone/volto/issues/3101#issuecomment-1055624497


ibus-engines.table: 1.12.3 -> 1.12.4

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/ibus-table/versions.
meta.description for ibus-engines.table is: "An IBus framework for table-based input methods"
meta.homepage for ibus-engines.table is: "https://github.com/kaio/ibus-table/wiki"
meta.changelog for ibus-engines.table is: ""
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 1.12.4 with grep in /nix/store/j6wi872dbilqs2xpnj4ifx6lra5fnig9-ibus-table-1.12.4

directory tree listing: https://gist.github.com/00724fcadb8c3ddbc7294526a7697c02

du listing: https://gist.github.com/fa761efe5300616ac6a63f986bd53e30

Rebuild report (if merged into master) (click to expand)

9 total rebuild path(s)

3 package rebuild(s)

3 x86_64-linux rebuild(s)
3 i686-linux rebuild(s)
0 x86_64-darwin rebuild(s)
3 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
ibus-engines.table
ibus-engines.table-chinese
ibus-engines.table-others

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/j6wi872dbilqs2xpnj4ifx6lra5fnig9-ibus-table-1.12.4 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A ibus-engines.table https://github.com/r-ryantm/nixpkgs/archive/bb3e5d82f20be575d703514335651667f205babc.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/j6wi872dbilqs2xpnj4ifx6lra5fnig9-ibus-table-1.12.4
ls -la /nix/store/j6wi872dbilqs2xpnj4ifx6lra5fnig9-ibus-table-1.12.4/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

3 packages built:

ibus-engines.table
ibus-engines.table-chinese
ibus-engines.table-others

Maintainer pings
cc @laMudri for testing.

Result of nixpkgs-review pr 113348 at bb3e5d82 run on aarch64-linux 1

3 packages built:

ibus-engines.table
ibus-engines.table-chinese
ibus-engines.table-others

1 suggestion:

warning: unclear-gpl
lgpl21 is a deprecated license, check if project uses lgpl21Plus or lgpl21Only and change meta.license accordingly.
Near pkgs/tools/inputmethods/ibus-engines/ibus-table/default.nix:63:5:
   |
63 |     license      = licenses.lgpl21;
   |     ^


[develop] Permit to pin kernel version while updating os packages

Sometimes it's required to pin the kernel version (e.g. if Lustre client is not avail for latest kernel) but at the same time permit to update all the other OSes packages.
Added a new DevSettings/DisableKernelUpdate parameter that is used only when UpdateOsPackages is set to true.

Closing in favour of #5929


Ignore null LEAD support for small batch sizes.

Which issue does this PR close?

Closes #.
Rationale for this change
This PR is a subsequent work of the PR9419 by @comphead .

What changes are included in this PR?
This PR adds support for ignore nulls mode for lead function. When data is received in small batches.

Are these changes tested?
Yes

Are there any user-facing changes?

I plan to merge it as its a good fix


Use logarithmic math to incrementally update the loading bar progress

This addresses the todo to mathematically update the progress of the loading bar. The only thing is that it rapidly goes through the first quarter of the loading bar, any suggestions about this are appreciated. I've removed the tests as they are no longer needed because there are no further conditions to check on.

This looks cool!
But it's also out of date.  Closing due to inactivity.


As a Shipwright developer, I want to ensure tutorials cover most scenarios on how to use Shipwright

Idea:
Adding this for the record (there might be already a similar issue). With the introduction of tutorials, we should extend the list to cover:

Building an image from a private git repository. Note: We might have this already, but we should consolidate this under tutorials.
Building an image with Buildah.
Building an image with Buildpacks-v3-heroku.
Building an image with source-to-image
Introduce at least an initial tutorial on how to write a custom Cluster/BuildStrategy. This will get easier, once the implementation of https://github.com/shipwright-io/build/pull/697 is in place.

Please provide further ideas if possible.

This content should be synced to the website and versioned (as it is versioned with the code).


Use a timeout for InspectJob calls.

Better than just letting the tests timeout.

@derekchiang bit o' dat review?

LGTM


ubuntu 22.04 gepetto viewer can not be initialized

I setted up pinocchio in an ubuntu 22.04 system
I launched gepetto-gui
and tried to run this example program
https://gepettoweb.laas.fr/doc/stack-of-tasks/pinocchio/master/doxygen-html/md_doc_b-examples_display_a-gepetto-viewer.html
I changed the urdf filename with mine.
unfortunately it replies with this message
Check whether gepetto-viewer is properly started
Error while loading the viewer model. It seems you should start gepetto-viewer

Please switch to meshcat for simplicity. Gepetto-gui is no more recommended.

@nim65s Could you provide some guidance for that issue?

From my developer experience I would prefer web 3D applications like meshcat.
I managed to use meshcat . But from my viewpoint it is not easy to without advanced documentation for noobs :
export ROS_PACKAGE_PATH , to define where you stored your meshes if you defined your urdf robot
pip install --user meshcat
overload your PYTHONPATH to ~/.local/lib/python.../site-packages (otherwise browser replies with Uncaught ReferenceError: MeshCat is not defined)

Normally, you should not use PYTHONPATH if meshcat is installed alongside Pinocchio.
The ROS_PACKAGE_PATH is used by the Pinocchio parser to retrieve the geometries. But in general, you can change your URDF to just use the file:// option

@sancelot Could you provide a tiny example of using meschat with the documentation to help us improving the doc in general?

@jcarpent
Installing meshcat in your home dir :
pip install --user meshcat
meshcat is now setted up in your ~ folder , in the directory ~/.local/lib/pythonXX/site-packages (where XX should reflect  your python version)
FAQ
When launching meshcat, console logs Uncaught ReferenceError: MeshCat is not defined:
overload your PYTHONPATH using this command before launching meshcat :
export PYTHONPATH=~/.local/lib/pythonXX/site-packages # where XX reflects your python version
your robot meshes are not displayed and not found :
set ROS_PACKAGE_PATH variable to follow the folder where your urdf meshes are located

Thanks a lot @sancelot for this tiny example!


lyxal: Watch<EMAIL_ADDRESS>

lyxal requests the watch of the watch_keyword<EMAIL_ADDRESS>See the MS search here and the Stack Exchange search in text, in URLs, and in code.

<EMAIL_ADDRESS>has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by Jeff Schaller in Charcoal HQ


Big review of the current codebase

Hi, is there an eta for these changes to be merged? Would love to use the latest and updated version :)

Oh no worries, the latest version is on main, this is just a very specialized PR which I was just using to do comprehensive review of codebase but never got to it. It is not 22k of changes, it is no changes at all actually, just a placeholder. I will close it so it doesn't confuse people. We are improving OpenSaas all the time and all the changes are pretty quickly landing on main, so you are not missing out on anything. The next bigger update will be coming in a couple of weeks, when we switch to Wasp 0.12, as soon as it releases.


Tools Marketplace and one click installation

There should be a way for users to see list of all tools built for SuperAGI and install them in their project with one click

Closing this as this is done.


The LLM-Guard API docker instance running on podman return the following error while using swagger UI and testing methods.

The LLM-Guard API docker instance running on podman return the following error while using swagger UI and testing methods.
To Reproduce
Steps to reproduce the behavior:
Follow steps to run an instance in podman
podman pull docker.io/laiyer/llm-guard-api
Expected behavior
Podman runs and the swagger UI be used for testing
Screenshots

Additional context
Error logs below
DEBUG:llm-guard-api:Received analyze request: prompt='string'
WARNING:presidio-analyzer:Entity CUSTOM doesn't have the corresponding recognizer in language : en
INFO:llm-guard:Scanned prompt with the score: {'Anonymize': 0.0, 'BanCompetitors': 0.0, 'BanSubstrings': 0.0, 'BanTopics': 0.0, 'Code': 0.0, 'Language': 0.0, 'PromptInjection': 0.0, 'Regex': 0.0, 'Secrets': 0.0, 'Sentiment': 0.0, 'TokenLimit': 0.0, 'Toxicity': 0.0}. Elapsed time: 0.504167 seconds
INFO:     <IP_ADDRESS>:35310 - "POST /analyze/prompt HTTP/1.1" 500 Internal Server Error
ERROR:    Exception in ASGI application
Traceback (most recent call last):
File "/usr/local/lib/python3.11/site-packages/uvicorn/protocols/http/httptools_impl.py", line 426, in run_asgi
result = await app(  # type: ignore[func-returns-value]
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/site-packages/uvicorn/middleware/proxy_headers.py", line 84, in call
return await self.app(scope, receive, send)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/site-packages/fastapi/applications.py", line 1054, in call
await super().call(scope, receive, send)
File "/usr/local/lib/python3.11/site-packages/starlette/applications.py", line 123, in call
await self.middleware_stack(scope, receive, send)
File "/usr/local/lib/python3.11/site-packages/starlette/middleware/errors.py", line 186, in call
raise exc
File "/usr/local/lib/python3.11/site-packages/starlette/middleware/errors.py", line 164, in call
await self.app(scope, receive, _send)
File "/usr/local/lib/python3.11/site-packages/starlette/middleware/cors.py", line 91, in call
await self.simple_response(scope, receive, send, request_headers=headers)
File "/usr/local/lib/python3.11/site-packages/starlette/middleware/cors.py", line 146, in simple_response
await self.app(scope, receive, send)
File "/usr/local/lib/python3.11/site-packages/starlette/middleware/exceptions.py", line 62, in call
await wrap_app_handling_exceptions(self.app, conn)(scope, receive, send)
File "/usr/local/lib/python3.11/site-packages/starlette/_exception_handler.py", line 64, in wrapped_app
raise exc
File "/usr/local/lib/python3.11/site-packages/starlette/_exception_handler.py", line 53, in wrapped_app
await app(scope, receive, sender)
File "/usr/local/lib/python3.11/site-packages/starlette/routing.py", line 762, in call
await self.middleware_stack(scope, receive, send)
File "/usr/local/lib/python3.11/site-packages/starlette/routing.py", line 782, in app
await route.handle(scope, receive, send)
File "/usr/local/lib/python3.11/site-packages/starlette/routing.py", line 297, in handle
await self.app(scope, receive, send)
File "/usr/local/lib/python3.11/site-packages/starlette/routing.py", line 77, in app
await wrap_app_handling_exceptions(app, request)(scope, receive, send)
File "/usr/local/lib/python3.11/site-packages/starlette/_exception_handler.py", line 64, in wrapped_app
raise exc
File "/usr/local/lib/python3.11/site-packages/starlette/_exception_handler.py", line 53, in wrapped_app
await app(scope, receive, sender)
File "/usr/local/lib/python3.11/site-packages/starlette/routing.py", line 72, in app
response = await func(request)
^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/site-packages/fastapi/routing.py", line 299, in app
raise e
File "/usr/local/lib/python3.11/site-packages/fastapi/routing.py", line 294, in app
raw_response = await run_endpoint_function(
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/site-packages/fastapi/routing.py", line 191, in run_endpoint_function
return await dependant.call(**values)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/user/app/app.py", line 147, in analyze_prompt
sanitized_prompt, results_valid, results_score = await asyncio.wait_for(
^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/asyncio/tasks.py", line 454, in wait_for
if timeout <= 0:
^^^^^^^^^^^^
TypeError: '<=' not supported between instances of 'str' and 'int'

Hey @ajithbitspilani , thanks for raising the issue.
We've just released a new version, which fixes this issue and introduces many cool features to the API like auth and opentelemetry integration.

Hey @ajithbitspilani , thanks for raising the issue.
We've just released a new version, which fixes this issue and introduces many cool features to the API like auth and opentelemetry integration.

I pulled the API again from web site, getting following error upon running the container
docker pull laiyer/llm-guard-api
Upon running.
2024-02-11 23:00:29 Traceback (most recent call last):
2024-02-11 23:00:29   File "/home/user/.local/bin/llm_guard_api", line 5, in
2024-02-11 23:00:29     from app.app import run_app
2024-02-11 23:00:29   File "/home/user/.local/lib/python3.11/site-packages/app/app.py", line 25, in
2024-02-11 23:00:29     from util import configure_logger
2024-02-11 23:00:29 ModuleNotFoundError: No module named 'util'

Oh, good catch. Thank you. I updated the image with the fix

Oh, good catch. Thank you. I updated the image with the fix

The API runs now as container deployment, thanks for that. but I could not find swagger UI up in /docs
I found /readyz and /health reporting good, but other routes are not up for example below:

I found Swagger UI was up and running last time, I checked, but failed in code. In this version, the container is up and running, there is a security authentication failing me to bring up the input scan and output scan.

In order to call /analyze/prompt or /analyze/output, you need to send POST requests.
To get Swagger UI, you need to set LOG_LEVEL as DEBUG.

You can also remove auth config from the scanners.yml to not have it

You can also remove auth config from the scanners.yml to not have it

Thanks for quick response. I downloaded direct image and ran, so could not configure it out of the box,
however, I will run from the code and let you know how it works.

I am able to build docker container removing the auth section and it works now.
Requested a feature to expose the interface details and sample implementation code.
Thank you.

I run the container directly, with DEBUG log level and do not enable auth in the command line. I also login the docker and make sure the auth is disabled in the scanners.yml:
docker run -d -p 8000:8000 -e LOG_LEVEL='DEBUG'  laiyer/llm-guard-api:latest
but I can not access the swagger.json:
{
"message": "Not Found",
"details": null
}
Am I missing something?


fashion-mnist url is error.

TensorFlow website error url:https://www.tensorflow.org/tutorials/keras/basic_classification
it should downloads the fashion-mnist,but it really downloads the origin-mnist which is digital.
please modify this error.
I download the right datasets from GitHub:https://github.com/zalandoresearch/fashion-mnist

@anlei1996
Are you referring to a link on the website or the following code snippet?
`
fashion_mnist = keras.datasets.fashion_mnist
(train_images, train_labels), (test_images, test_labels) = fashion_mnist.load_data()
`

Great! Closing this issue now.

http://fashion-mnist.s3-website.eu-central-1.amazonaws.com/t10k-labels-idx1-ubyte.gz
http://fashion-mnist.s3-website.eu-central-1.amazonaws.com/t10k-images-idx3-ubyte.gz
Tensorflow 1.8 still wrong datasets.

Yes, I use the same code.

@ypatz I'm unable to reproduce even with tensorflow==1.8.0. The dataset is fashion-mnist. What about it do you believe is wrong? Maybe I'm misunderstanding.

Closing the issue. Unable to reproduce on 1.8.0.


[Desktop Bug] bold and italics exporting to pdf visual bug

Describe the bug
When having a note using the custom bold and italics texts, exporting it to pdf will make the bolded/italiced text just display as a blue box
To Reproduce
Steps to reproduce the behavior:
make some text bold or italic
export the note to pdf
open to view
Expected behavior
that it would be exported out to appear as it does in reading view
Screenshots, Gifs, Video

Desktop (please complete the following information):

OS: kali linux
Obsidian Version: 1.1.9
CyberGlow Version: 7.8.8

Additional context
this could also just be a pdf limitation, if so then feel free to close the issue but it would be great if the pdf actually came out looking as polished as reading view does

that's weird, i tried exporting it myself and was unable to replicate this (see screenshot below) I tried Foxit Reader and Chrome/Edge built in PDF viewer.
Could you check if you have any plugins that in anyway influence the pdf exporting?
Or what PDF reader do you use?

Otherwise it may be a limitation from Obsidian on Linux. I haven't tried my theme on Linux or Mac (don't have any device running either of those OS.) If that's the case I'll see if there's a way in CSS to differentiate between Linux and remove the gradient styling for that OS.

Please update the theme to v7.9.0 either via obsidian or manually, and verify if that issue has been resolved.
If not I will provide you with a snippet for you to test that should resolve it.

just updated it, the issue persists. the pdf reader is the default one, Evince document reader for gnome. I did try opening the pdf in firefox though, which displayed the bond text correctly, so it's probably just something within evince itself that can't read it properly.

clip from a pdf export with this fix.
while it doesn't make the background transparent like it aims to, it's suitable for actually being able to read it. still weird that it displays this behaviour in the first place though

Definitely, no idea why there's this issue for some pdf viewer/readers.
But like I said, I will be changing the stylings of bold and italics to be a bit more simple as to avoid these incompatibility with some readers.
Hopefully this fix is good enough for you for now, until the rework is done. If it isn't you can remove the styling from the theme, I can tell you what code specifically you need to remove.

It's all good for now, tbh i really like the blue gradient style and mostly use obsidian in reading/edit mode cause i'm doing my project journals for uni with it, so i still get to look at all the good styling stuff. thanks!


[Date Histogram] Investigate the safe number of buckets for which filter rewrite optimization can be applied

Follow up tasks for #13317
The idea of the filter rewrite optimiaztion is to utilize the index structure instead of iterating over documents to get the buckets results. We are able to know how many buckets before the actual aggregate execution logic begins.
As the bucket counts increase or the number of documents that should be aggregated on decrease, the iterative method may become faster and the filter rewrite method may become slower.
Currently we have a cluster setting to define the supported bucket count but it may not always work. For example, if the dataset only has 3k different values and the aggregation query asks for 1024 buckets, it is too high and wouldn't be better than just iterating over; on the other hand, if the dataset has 100k different values, we can probably support more than 1024 buckets.
This task is to investigate some rules to decide whether the optimization should be used, dynamically depending on the dataset or the index.
The biggest part of overhead normally is when reading the values from documents. The bkd index structure has all the documents as leaf nodes and will only need to be traversed through when the leaf node is intersected with the query.
One idea here is to do a dummy traversal on the bkd tree to tell how many leaf node will be intersected, and how many middle node will be skipped, based on these 2 numbers, we can get a relatively accurate idea about the cost of certain range query.

[Triage - attendees 1 2 3 4]
@bowenlan-amzn Thanks for filing.

close because new issue #14438 will include this.


Rename efr32bg_sltb010a and add support for efr32bg22_brd4184b

This PR renames SiLabs efr32bg_sltb010a board to efr32bg22_brd4184a and adds support for efr32bg22_brd4184b.
fixes #56155

Thanks for your comment
I committed efr32bg22_brd4184b support without file duplication


self-referencing foreign key support.

As per #165

@rgrp @jpmckinney

Why __self__ and not simply self as used in the rel attribute in HTML?

@jpmckinney I'd prefer self - I just wanted to ensure something that is likely not to be a filename.

I'd consider the probability of a data package being called self without extension to be about the same as __self__, and self has the benefit of being recognizable from other contexts.

I've changed from __self__ to self

So. anyone want to merge, or, object?

I've re-read and looks good-to-merge to me.

ok, I'll take that as a green light :)

Have to say I was still not convinced the need justified the additional spec complexity on this one but it seems pretty minor and @jpmckinney was happy ;-)


Invalid duplicate checksums reported

What I got (tossing unrelated rows):
directory,file,size,size_in_bytes,checksum,remove_file
,,,,,
.,prune-input-testing.csv,25.2 KiB,25832,1d0c2cbe8fc192c57774fb39b258860bc66427ba2914ceaf46493112c35165ae,
.,report.csv,25.2 KiB,25832,1d0c2cbe8fc192c57774fb39b258860bc66427ba2914ceaf46493112c35165ae,

Actual:
$ sha256sum *.csv
1d0c2cbe8fc192c57774fb39b258860bc66427ba2914ceaf46493112c35165ae *prune-input-testing.csv
d942dce529d17457f5f42b386256da6c3d6b43118ec9219c6f0a5c2270a6c740 *report.csv

After building and re-running the app, I'm not able to reproduce the problem against the original data set. Fluke?

Cannot reproduce, closing for now.


Fix Searches

I want to merge this change because it fixes (and refactors a bit) entity pickers with searchable fields.
Fixes #4471
Fixes #4472
Pull Request Checklist

[ ] Privileged views and APIs are guarded by proper permission checks.
[ ] All visible strings are translated with proper context.
[ ] All data-formatting is locale-aware (dates, numbers, and so on).
[ ] Database queries are optimized and the number of queries is constant.
[ ] Database migration files are up to date.
[ ] The changes are tested.
[ ] The code is documented (docstrings, project documentation).
[ ] GraphQL schema and type definitions are up to date.
[x] Changes are mentioned in the changelog.

Here is the report for 6d55b6f7becc27a3cd84cd3fce71c5488e21c8dc (mirumee/saleor @ fix/searches)
Base comparison is c0984137c26304a1d0bd9b22cb6d31e48039959b.
No differences were found. (click me)

# api.benchmark checkout
  test name                           	left count 	right count	duplicate count
  ------------------------------------	-----------	-----------	---------------
  add billing address to checkout     	         34	         34	             20
  add shipping to checkout            	          7	          7	              0
  checkout payment charge             	         14	         14	              0
  complete checkout                   	          6	          6	              0
  create checkout                     	         43	         43	             21

# api.benchmark homepage
  test name                           	left count 	right count	duplicate count
  ------------------------------------	-----------	-----------	---------------
  retrieve main menu                  	          5	          5	              0
  retrieve product list               	          4	          4	              0
  retrieve secondary menu             	          5	          5	              0
  retrieve shop                       	          2	          2	              0

# api.benchmark product
  test name                           	left count 	right count	duplicate count
  ------------------------------------	-----------	-----------	---------------
  product details                     	         13	         13	              3

# api.benchmark variant
  test name                           	left count 	right count	duplicate count
  ------------------------------------	-----------	-----------	---------------
  retrieve variant list               	          9	          9	              2


Module Usage->example error

Win7 Python3.5
Module Usage->example:
DSDownload(urls, workers, output) should be DSDownload.DSDownload(urls, workers, output)
Or
Traceback (most recent call last):
File "C:\Users\Administrator\Desktop\TEST.PY", line 12, in
DSDownload(urls, workers,output)
TypeError: 'module' object is not callable

Fixed!
Thank you!


When softBody set restitution, this softBody will not stop

Try reducing the stiffness on the constraints by passing this options object as the final argument: { stiffness: 0.5 } and increase or decrease the value as needed.


Clone template from full repository urls

In the guide https://middlemanapp.com/basics/upgrade-v4/ it says urls without :// are supposed to be on github, however passing the full repository url doesn't work.
$ middleman init -T https://github.com/middleman/middleman-templates-default.git
Template `https://github.com/middleman/middleman-templates-default.git` not found in Middleman Directory.
Did you mean to use a full `user/repo` path?

I've added a way to use both middleman directory, github user/repo syntax and full clone urls (with the :// check as the guide) so all of them works.
middleman init -T middleman/middleman-templates-default
         run  git clone --depth 1 git://github.com/middleman/middleman-templates-default.git /var/folders/dg/2k1h_3dd44b19cqk00dvs70c0000gn/T/d20150212-13109-1wnvvo2 from "."
Cloning into '/var/folders/dg/2k1h_3dd44b19cqk00dvs70c0000gn/T/d20150212-13109-1wnvvo2'...
remote: Counting objects: 22, done.
remote: Compressing objects: 100% (15/15), done.
....

middleman init -T https://github.com/middleman/middleman-templates-default.git
         run  git clone --depth 1 https://github.com/middleman/middleman-templates-default.git /var/folders/dg/2k1h_3dd44b19cqk00dvs70c0000gn/T/d20150212-13153-15zhooz from "."
Cloning into '/var/folders/dg/2k1h_3dd44b19cqk00dvs70c0000gn/T/d20150212-13153-15zhooz'...
remote: Counting objects: 22, done.
remote: Compressing objects: 100% (15/15), done.
....

in this way even people using bitbucket (like us) can use their templates.

Maybe I can also add the ability to use local filesystem as template source to make easier developing the template

Forgot about that http(s) git protocol. Good catch.

@tdreyno could be useful also the ability to use a template from local filesystem?


Confused about v-prediction SDS loss

Hi, thanks a lot for the brilliant work.
In the implementation of SDS loss with v-prediction (here). The final grad is
$|\epsilon-\sqrt{1-\alpha_t}z_0-\sqrt{\alpha_t}\epsilon_\theta|$, where $\epsilon$ and $\epsilon_\theta$ denotes the random noise and the model predicted noise.
However, in the training loss of v-prediction diffusion model. For example, in train_lora method. The loss is formulated as the below equation as here and here. The loss is:
$|\sqrt{\alpha_t}\epsilon-\sqrt{1-\alpha_t}z_0-\epsilon_\theta|$, where $\epsilon$ and $\epsilon_\theta$ denotes the random noise and the model predicted noise.
As in DreamFusion, we should use the diffusion loss as the grad. Therefore, I am not sure the v-prediction SDS loss is correct or not.

Hi @HeliosZhao ,
Actually, the correct expression for the final gradient is not $|\epsilon-\sqrt{1-\alpha_t}z_0-\sqrt{\alpha_t}\epsilon_\theta|$, but rather $|\epsilon-\sqrt{1-\alpha_t}z_t-\sqrt{\alpha_t}\epsilon_\theta|$. Note that $z_t$ is not equal to $z_0$. So the original implementation is correct.

Hi @DSaurus ,
Thanks for the reply. Please note that my question is not about $z_t$ and $z_0$.
My question is, the expression for v-prediction training in diffusion is different from the SDS loss in your implementation.
The v-prediction in diffusion training is:
$|\sqrt{\alpha_t}\epsilon-\sqrt{1-\alpha_t}z_t-\epsilon_\theta|$
In your SDS implementation, the v-prediction SDS loss is:
$|\epsilon-\sqrt{1-\alpha_t}z_t-\sqrt{\alpha_t}\epsilon_\theta|$
The coefficients for $\epsilon$ and $\epsilon_\theta$ are different.

Actually the v-prediction in diffusion training is $|\sqrt{\alpha_t}\epsilon-\sqrt{1-\alpha_t}z_0-\epsilon_\theta|$.  Note that $z_0$ is not equal to $z_t$. You can use it to derive the SDS loss $|\epsilon-\sqrt{1-\alpha_t}z_t-\sqrt{\alpha_t}\epsilon_\theta|$.

Oh. I got it. Thanks!


nydusify: skip tls verification

Throw the error when converting image to https registry with
self-signed TLS cert:
failed to do request: x509: certificte signed by unknown authority
Fixed it by importing nerdctl pkg implementation, if users specify
--source-insecure or --target-insecure option, then skips verifying
HTTPS certs, and allows falling back to plain HTTP for registry.
Test to enable --source-insecure and --target-insecure:

Tested with http registry with domain name like registry.com;
Tested with https registry with self-signed TLS cert;

Test to disable --source-insecure and --target-insecure:

Tested with https registry with CA-signed TLS cert;
Tested with http registry with localhost/<IP_ADDRESS> address;

Signed-off-by: Yan Song<EMAIL_ADDRESS>

/retest

The smoke failure seems to have nothing to do with this patch.


[BUG] Headers are not properly set up in the request

Describe the bug
Headers are not properly set up in the request, so the X-Fields header is not working
To Reproduce
https://github.com/mysuperai/superai-sdk/blob/a95be6ee06d1d3ad7eedb72c3d1263eb94c17578/superai/apis/project.py#L56-L58
Expected behavior
Add support to setup headers properly in Client.request.
Versions (please complete the following information):

Superai Version 0.2.1
Python version 3.11

@lpfann can you please take a look


Unboxing of Boolean to boolean

Unboxing Boolean to boolean
Defaults to false if Boolean returned is null
https://github.com/Azure/azure-sdk-for-java/issues/9110

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: DanielBenniah sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Can one of the admins verify this patch?

/azp run java - eventhubs - tests

@DanielBenniah  there was some issue with the CI system, because of which the tests are failing. Can you please update your branch with latest master and push the latest changes ?
That way, CI should get fixed.

Didn't mean to close it, sorry. Reopened it.

@kushagraThapar All tests have passed, please let me know if I need to make any changes

Thank you!


Remove ssh_private_key_path variable

@hyder , in our offline email exchange, you clarified that the ssh_private_key_path variable is not needed for the bastion module, and asked me to file an issue to remove it.

We'll keep this for now, until we can evaluate downstream impact on other projects such https://github.com/oracle-terraform-modules/terraform-oci-oke
Let's revisit this later.


How to set path to composer in app.yaml file

After going throw the docs I didn't find anything related to setting a path to composer file and was wondering if that is possible.

Hello @eliadjoke !
Unfortunately, composer.json must live in the root of your application. What is the use-case for having it live elsewhere?
If you use Cloud Run, you can define a custom Dockerfile and change this, but it would add a lot of complexity if not absolutely needed.


R0614R1 + complete for auto loop

(Click "Preview" to turn any http URL into a clickable link)

PLEASE CAREFULLY READ: Contributing Guidelines

Clear this template before submitting your PR.

I'm not certain all "for" changes are "efficient". I'll add a method to test the compilation time (which I've planned)


Improve about information of cargo search

What does this PR try to resolve?
Since it supports multiple registries, it's better to mention that it's not limited to just crates.io.
How should we test and review this PR?

[x] See the docs changes.

Additional information
None

Wried. I supposed I needed to update the man page, but it seemed we didn't check it.

Guess we might want to update manpage here as well?
master/src/doc/man/cargo-search.md

I see. We only check if we generate it from markdown correctly.

:pushpin: Commit<PHONE_NUMBER>e3647f767910876e0c3559bc735ff7 has been approved by weihanglo
It is now in the queue for this repository.

:sunny: Test successful - checks-actions
Approved by: weihanglo
Pushing a4764b0dd88f4bf801d5d761ca035d20339bae78 to master...


Expose:  useRootNavigator

Describe the Feature
It would be great if we can configure useRootNavigator, because some people don't want to show the Dialog in front of all other pages (like sub-pages e.g.)
Todo
Suggested Solution
expose:

Thanks for this. You can try out this branch: https://github.com/thesmythgroup/easy_image_viewer/tree/GH-31_expose_root_navigator
However, I'm a bit concerned about this change. Here's why: The whole package is designed for two things:

Easily (hence the name) show images in a a fullscreen, immersive mode. That includes a close button etc.
Using the EasyImageViewPager directly (as you can see in main.dart) if you want to build a custom view.

Could you describe in which specific scenario you'd like to use the "easy" showDialog version without useRootNavigator = true? Any scenario I can think of (on a tab, for example) would be weird, because you'd still have the close button etc.

@Ahmadre I'm closing this issue for now. Feel free to open a new one with more information if needed. Thanks!

Hi @jfahrenkrug, the scenario is using de facto standard flutter navigation package go_router with de facto standard stateful shell navigation supported by that package. I believe this scenario is very common nowadays and should be supported in an 'easy' way. What do you thing?


Snapshot Launch Arguments Not Passed to Simulator from Command Line

New Issue Checklist

[x] Updated fastlane to the latest version
[x] I have read the Contribution Guidelines

Issue Description
I am using the NSUserDefaults 'FASTLANE_SNAPSHOT' value to determine if I should request location and notification permissions or not. I do not want to display or handle the system dialogue alerts when doing screenshots.
I get the expected results when running my UITests directly from Xcode, including the default FASTLANE_SNAPSHOT NSUserDefault value being present. However, not when running Snapshot from the command line.
The key error is: Failed to background test runner.
Complete output when running fastlane, including the stack trace and command used
[16:51:15]: Patching '/Users/calebhicks/Library/Preferences/com.apple.iphonesimulator.plist' to scale simulator to 100%
[16:51:16]: Launch Simulator iPhone 5
[16:51:16]: $ xcrun instruments -w F8D4829F-CBAF-4366-984C-2C560E4DC2C7 &> /dev/null
[16:51:18]: Uninstall application com.foreup.core
[16:51:18]: $ xcrun simctl uninstall F8D4829F-CBAF-4366-984C-2C560E4DC2C7 com.foreup.core &> /dev/null
[16:51:19]: ------------------------
[16:51:19]: --- iPhone 5 - en-US ---
[16:51:19]: ------------------------
[16:51:19]: $ set -o pipefail && xcodebuild -scheme 'ForeUpCore' -project './ForeUpCore.xcodeproj' -derivedDataPath '/var/folders/vl/3py3mdjd01j5thd2ddzcnts80000gp/T/snapshot_derived20160314-55634-1i5qdqd' -destination 'platform=iOS Simulator,id=F8D4829F-CBAF-4366-984C-2C560E4DC2C7,OS=9.2' build test | tee '/Users/calebhicks/Library/Logs/snapshot/ForeUpCore-ForeUpCore.log' | xcpretty
[16:51:19]: ▸ Loading...
[16:51:20]: ▸ 2016-03-14 16:51:20:149 xcodebuild[57359:e0b] BBUncrustifyPlugin Version 2.1.1 loaded
[16:51:20]: ▸ Building ForeUpCore/ForeUpCore [Debug]
[16:51:20]: ▸ Check Dependencies
[16:51:21]: ▸ Build Succeeded
[16:51:21]: ▸ 2016-03-14 16:51:21.498 xcodebuild[57359:849676] [MT] IDETestOperationsObserverDebug: (AED00C62-88AD-4E52-A31D-8F1FACA0BC75) Beginning test session AED00C62-88AD-4E52-A31D-8F1FACA0BC75 with Xcode 7C1002 on target <DVTiPhoneSimulator: 0x7fd60b8b5330> {
[16:51:21]: ▸ SimDevice: SimDevice : iPhone 5 (F8D4829F-CBAF-4366-984C-2C560E4DC2C7) : state={ Booted } deviceType={ SimDeviceType : com.apple.CoreSimulator.SimDeviceType.iPhone-5 } runtime={ SimRuntime : 9.2 (13C75) - com.apple.CoreSimulator.SimRuntime.iOS-9-2 }
[16:51:21]: ▸ } (9.2 (13C75))
[16:51:21]: ▸ 2016-03-14 16:51:21.509 xcodebuild[57359:849676] [MT] IDETestOperationsObserverDebug: (BE9A67BC-ED32-4E34-8700-45481B93C850) Beginning test session BE9A67BC-ED32-4E34-8700-45481B93C850 with Xcode 7C1002 on target <DVTiPhoneSimulator: 0x7fd60b8b5330> {
[16:51:21]: ▸ SimDevice: SimDevice : iPhone 5 (F8D4829F-CBAF-4366-984C-2C560E4DC2C7) : state={ Booted } deviceType={ SimDeviceType : com.apple.CoreSimulator.SimDeviceType.iPhone-5 } runtime={ SimRuntime : 9.2 (13C75) - com.apple.CoreSimulator.SimRuntime.iOS-9-2 }
[16:51:21]: ▸ } (9.2 (13C75))
[16:51:21]: ▸ 2016-03-14 16:51:21.519 xcodebuild[57359:849676] [MT] IDETestOperationsObserverDebug: (D1CDD5A5-E3E7-49E0-AD7C-93C358BBB5AC) Beginning test session D1CDD5A5-E3E7-49E0-AD7C-93C358BBB5AC with Xcode 7C1002 on target <DVTiPhoneSimulator: 0x7fd60b8b5330> {
[16:51:21]: ▸ SimDevice: SimDevice : iPhone 5 (F8D4829F-CBAF-4366-984C-2C560E4DC2C7) : state={ Booted } deviceType={ SimDeviceType : com.apple.CoreSimulator.SimDeviceType.iPhone-5 } runtime={ SimRuntime : 9.2 (13C75) - com.apple.CoreSimulator.SimRuntime.iOS-9-2 }
[16:51:21]: ▸ } (9.2 (13C75))
[16:51:21]: ▸ Building ForeUpCore/ForeUpCore [Debug]
[16:51:21]: ▸ Check Dependencies
[16:51:21]: ▸ Building ForeUpCore/ForeUpCoreUITests [Debug]
[16:51:21]: ▸ Check Dependencies
[16:51:21]: ▸ Building ForeUpCore/ForeUpCoreTests [Debug]
[16:51:21]: ▸ Check Dependencies
[16:51:21]: ▸ Building ForeUpCore/ForeUpCoreScreenshot [Debug]
[16:51:21]: ▸ Check Dependencies
[16:51:21]: ▸ Running script 'Run Script'
[16:51:44]: ▸ 2016-03-14 16:51:44.629 xcodebuild[57359:849676] [MT] IDETestOperationsObserverDebug: (FAA7726A-287D-4A63-AD0D-F710E12159FB) Beginning test session FAA7726A-287D-4A63-AD0D-F710E12159FB with Xcode 7C1002 on target <DVTiPhoneSimulator: 0x7fd60b8b5330> {
[16:51:44]: ▸ SimDevice: SimDevice : iPhone 5 (F8D4829F-CBAF-4366-984C-2C560E4DC2C7) : state={ Booted } deviceType={ SimDeviceType : com.apple.CoreSimulator.SimDeviceType.iPhone-5 } runtime={ SimRuntime : 9.2 (13C75) - com.apple.CoreSimulator.SimRuntime.iOS-9-2 }
[16:51:44]: ▸ } (9.2 (13C75))
[16:51:46]: ▸ ** TEST FAILED **
[16:51:46]: ▸ All tests
[16:51:46]: ▸ Test Suite ForeUpCoreTests.xctest started
[16:51:46]: ▸ 	 Executed 0 tests, with 0 failures (0 unexpected) in 0.000 (0.000) seconds
[16:51:46]: ▸
[16:51:46]: ▸ All tests
[16:51:46]: ▸ Test Suite ForeUpCoreUITests.xctest started
[16:51:46]: ▸ 	 Executed 0 tests, with 0 failures (0 unexpected) in 0.000 (0.000) seconds
[16:51:46]: ▸
[16:51:46]: ▸ All tests
[16:51:46]: ▸ Test Suite ForeUpCoreScreenshot.xctest started
[16:51:46]: ▸ ForeUpCoreScreenshot
[16:51:46]: ▸ ✗ testCreateSnapshots, UI Testing Failure - Failed to background test runner.
[16:51:46]: ▸ Selected tests
[16:51:46]: ▸ Test Suite ForeUpCoreScreenshot.xctest started
[16:51:46]: ▸ 	 Executed 0 tests, with 0 failures (0 unexpected) in 0.000 (0.001) seconds
[16:51:46]: ▸
2016-03-14 16:51:20:149 xcodebuild[57359:e0b] BBUncrustifyPlugin Version 2.1.1 loaded
▸ Building ForeUpCore/ForeUpCore [Debug]
▸ Check Dependencies
▸ Build Succeeded
2016-03-14 16:51:21.498 xcodebuild[57359:849676] [MT] IDETestOperationsObserverDebug: (AED00C62-88AD-4E52-A31D-8F1FACA0BC75) Beginning test session AED00C62-88AD-4E52-A31D-8F1FACA0BC75 with Xcode 7C1002 on target <DVTiPhoneSimulator: 0x7fd60b8b5330> {
SimDevice: SimDevice : iPhone 5 (F8D4829F-CBAF-4366-984C-2C560E4DC2C7) : state={ Booted } deviceType={ SimDeviceType : com.apple.CoreSimulator.SimDeviceType.iPhone-5 } runtime={ SimRuntime : 9.2 (13C75) - com.apple.CoreSimulator.SimRuntime.iOS-9-2 }
} (9.2 (13C75))
2016-03-14 16:51:21.509 xcodebuild[57359:849676] [MT] IDETestOperationsObserverDebug: (BE9A67BC-ED32-4E34-8700-45481B93C850) Beginning test session BE9A67BC-ED32-4E34-8700-45481B93C850 with Xcode 7C1002 on target <DVTiPhoneSimulator: 0x7fd60b8b5330> {
SimDevice: SimDevice : iPhone 5 (F8D4829F-CBAF-4366-984C-2C560E4DC2C7) : state={ Booted } deviceType={ SimDeviceType : com.apple.CoreSimulator.SimDeviceType.iPhone-5 } runtime={ SimRuntime : 9.2 (13C75) - com.apple.CoreSimulator.SimRuntime.iOS-9-2 }
} (9.2 (13C75))
2016-03-14 16:51:21.519 xcodebuild[57359:849676] [MT] IDETestOperationsObserverDebug: (D1CDD5A5-E3E7-49E0-AD7C-93C358BBB5AC) Beginning test session D1CDD5A5-E3E7-49E0-AD7C-93C358BBB5AC with Xcode 7C1002 on target <DVTiPhoneSimulator: 0x7fd60b8b5330> {
SimDevice: SimDevice : iPhone 5 (F8D4829F-CBAF-4366-984C-2C560E4DC2C7) : state={ Booted } deviceType={ SimDeviceType : com.apple.CoreSimulator.SimDeviceType.iPhone-5 } runtime={ SimRuntime : 9.2 (13C75) - com.apple.CoreSimulator.SimRuntime.iOS-9-2 }
} (9.2 (13C75))
▸ Building ForeUpCore/ForeUpCore [Debug]
▸ Check Dependencies
▸ Building ForeUpCore/ForeUpCoreUITests [Debug]
▸ Check Dependencies
▸ Building ForeUpCore/ForeUpCoreTests [Debug]
▸ Check Dependencies
▸ Building ForeUpCore/ForeUpCoreScreenshot [Debug]
▸ Check Dependencies
▸ Running script 'Run Script'
2016-03-14 16:51:44.629 xcodebuild[57359:849676] [MT] IDETestOperationsObserverDebug: (FAA7726A-287D-4A63-AD0D-F710E12159FB) Beginning test session FAA7726A-287D-4A63-AD0D-F710E12159FB with Xcode 7C1002 on target <DVTiPhoneSimulator: 0x7fd60b8b5330> {
SimDevice: SimDevice : iPhone 5 (F8D4829F-CBAF-4366-984C-2C560E4DC2C7) : state={ Booted } deviceType={ SimDeviceType : com.apple.CoreSimulator.SimDeviceType.iPhone-5 } runtime={ SimRuntime : 9.2 (13C75) - com.apple.CoreSimulator.SimRuntime.iOS-9-2 }
} (9.2 (13C75))
** TEST FAILED **

All tests
Test Suite ForeUpCoreTests.xctest started

	 Executed 0 tests, with 0 failures (0 unexpected) in 0.000 (0.000) seconds

All tests
Test Suite ForeUpCoreUITests.xctest started

	 Executed 0 tests, with 0 failures (0 unexpected) in 0.000 (0.000) seconds

All tests
Test Suite ForeUpCoreScreenshot.xctest started
ForeUpCoreScreenshot
✗ testCreateSnapshots, UI Testing Failure - Failed to background test runner.
Selected tests
Test Suite ForeUpCoreScreenshot.xctest started

	 Executed 0 tests, with 0 failures (0 unexpected) in 0.000 (0.001) seconds

[16:51:46]: Exit status: 65
[16:51:46]: Tests failed - check out the log above

Configuration Files
Please copy the complete content of your Fastfile and any other configuration files you use below:
Snapfile:
# Uncomment the lines below you want to change by removing the # in the beginning

# A list of devices you want to take the screenshots from
devices([
  "iPhone 6s",
  "iPhone 6s Plus",
  "iPhone 5",
  "iPhone 4s",
])

languages([
  "en-US"
])

clear_previous_screenshots true

reinstall_app true

app_identifier ENV["APP_IDENTIFIER"]

number_of_retries 2

# Arguments to pass to the app on launch. See https://github.com/fastlane/snapshot#launch-arguments
launch_arguments([
    "-hasDisplayedTutorialAlert-GPSViewController YES"
])

# Where should the resulting screenshots be stored?
# output_directory "./screenshots"

# For more information about all available options run
# snapshot --help

Environment
fastlane version (fastlane -v):
Do you use bundler, rbenv or rvm?

Resolved. But for the sake of anyone coming after the fact via search:
The issue was that the regular project testing target does not get the launch arguments by default.
If you want to accomplish something similar, you can add the launch argument in the scheme Edit Scheme -> Test -> Arguments Passed On Launch.
Alternatively, to solve this specific problem, you can add a new Scheme and only use the snapshot UITesting target during the Test phase.


Please export BLP files when performing a 'raw' export of WMO files

Unlike the behavior for m2 files (where associated BLP files are exported when a raw export is requested), a 'raw' WMO export only exports the WMO files. It would be wonderful if the BLP files associated with a WMO were exported when a raw export was performed.
(noncritical, not blocking me, just a nice to have)

Resolve in 448f060


Use command that works on any exercise

Previously, the language kind of surprised me.  I was working on the "Bob" exercise and I was
surprised to see mentions of Hello World in it.  This change makes it so that the user can just
copy/paste the command and it will work for any exercise.

Much better! Thank you. ✨ 💖 ✨


doc/develop: Add picolibc documentation

This describes the capabilities offered by Picolibc along with some of the requirements applications have when using it.
Closes: #49620
Signed-off-by: Keith Packard<EMAIL_ADDRESS>

Merging on @carlescufi 's behalf


Is anyone monitoring this repo?  I'd have a couple pull requests for environment.yml and get_esa_worldcover.sh

cheers

It looks like I can merge PRs, please do.

awesome!  PR sent.


Output files generated with hv.output now respect all settings

My initial approach was too simplistic and didn't use all the supplied keywords. For instance this now correctly outputs an SVG file:

In addition I added keyword validation to make sure only the appropriate keywords are supplied.

@philippjfr Tests have passed and ready for review. There isn't much too it so I think it can just be merged.

Looks good, merging.


Spindle button functions but bounces back to previous state - Doesn't change state when running a program.

When I manually switch the spindle on, it functions as expected but the radio button bounces back to off. To switch the spindle off, I have to click the CW button then Off. The button then bounces back to CW, and to turn on I have to hit off then CW again.
If I run a program, the spindle turns on and off as expected but doesnt change state in the UI until the program finishes and the spindle displays CW.
Behaviour only happens with the spindle enable pin inverted (Which I need). Using a PicoBob and this is repeatable across every version of ioSender I've tried, and any firmware I've tried, on three different computers so far 🤔

Fix committed for the RP2040 grblHAL driver.


PUT /api/featur/{featureName} does not update the record

Operation succeeds but has not effect. Most probably related to missing @RequestBody annotation

Create a test


Nothing was returned from render

💥 Regression Report
After migrating from react-scripts 3.4.4 to 4.0.0 jest was updated from 24.9.0 to 26.6.0. When using the jest.mock with a factory function in the new version my tests have a mock error and react-testing-library prints that nothing was returned from the render.
From the jest docs:
jest.mock('../moduleName', () => {
  return jest.fn(() => 42);
});

// This runs the function specified as second argument to `jest.mock`.
const moduleName = require('../moduleName');
moduleName(); // Will return '42';

From this case I can see that moduleName in the last line is a mock function but when the function is called the result is undefined and the arrow function passed to the jest.fn is never called. The same happens if I use mockImplementation.
If the factoring function returns a real function it works normally. For example:
jest.mock('../moduleName', () => {
  return () => 42;
});

// This runs the function specified as second argument to `jest.mock`.
const moduleName = require('../moduleName');
moduleName(); // Will return '42';

Last working version
Worked up to version: 24.9.0
Stopped working in version: 26.6.0
To Reproduce
Steps to reproduce the behavior:

Setup a react app with create-react-app (react-scripts 4.0.0)
Make your App.js like:

// Import any function from any module
import anyFn from 'anyModule';

function App() {
  const a = anyFn('any param') // anyFn is a jest mocked function
  console.log(a) // It will print undefined
  return 'My App';
}

export default App;

Create a file called App.test.js:

import { render, screen } from '@testing-library/react';
import App from './App';

jest.mock('./anyModule', () => jest.fn(param => {
  return `${param} + called`; // this is never called
}))

// This works
// jest.mock('./anyModule', () => param => {
//   return `${param} + called`;
//  })

test('renders learn react link', () => {
  render(<App />);
  expect(screen.getByText(/my app/i)).toBeInTheDocument();
});

Run the test. The mocked function will not be called and the call returns undefined.

Expected behavior
The mocked function is called and the defined value is returned.
Run npx envinfo --preset jest
Paste the results here:
  System:
    OS: macOS 11.0.1
    CPU: (4) x64 Intel(R) Core(TM) i5-7267U CPU @ 3.10GHz
  Binaries:
    Node: 12.19.0 - ~/.nvm/versions/node/v12.19.0/bin/node
    Yarn: 1.22.4 - /usr/local/bin/yarn
    npm: 6.14.8 - ~/.nvm/versions/node/v12.19.0/bin/npm

I believe we are facing the same issue when trying to upgrade to react-scripts 4.0.1 : our stack uses Apollo Graphql client and the MockedProvider component to provide mocks. We use Jest to track the api calls and provide an answer. After upgrading, most of our tests are failing. After some investigating, it appeared that a normal function works as expected while a function using jest.fn() does'nt.
i.e.
// working:
<MockedProvider
          mocks={[
            {
              request: {
                query: UPDATE,
                result: () => {
                  return {
                    data: {
                      update: {id: 1},
                    },
                  };
                },
              },
            },
          ]}
          addTypename={false}
        >
...
</MockedProvider>

// not working:
<MockedProvider
          mocks={[
            {
              request: {
                query: UPDATE,
                result: jest.fn(() => {
                  return {
                    data: {
                      update: {id: 1},
                    },
                  };
                }),
              },
            },
          ]}
          addTypename={false}
        >
...
</MockedProvider>

We end up with an undefined result in the component.
For what it's worth, all variants of jest.fn() implementation give the same result:
// not working:
jest.fn(() => ( {  data: { update: {id: 1} } }));
jest.fn().mockImplementation(() => ( {  data: { update: {id: 1} } }));
jest.fn().mockResolvedValue({  data: { update: {id: 1} } });

It seems this is due to a new behaviour in Jest that removes the mockImplementation between tests by default.
It can be fixed by using
"jest": {
  "resetMocks": false
},

in the package.json, as stated in https://github.com/facebook/create-react-app/issues/10171#issuecomment-736598707


Update Autocomplete component to use hooks

Also fixes a nuisance with the input styles also being applied to the rendered TextInput

No need to use useState or useEffect. Thx for you contribution.