version update

Codecov Report

Merging #269 into dev will increase coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                dev     #269      +/-   ##
============================================
+ Coverage     34.64%   34.66%   +0.02%
- Complexity     1570     1573       +3
============================================
  Files           102      102
  Lines         23660    23660
  Branches       3873     3873
============================================
+ Hits           8197     8202       +5
+ Misses        13847    13845       -2
+ Partials       1616     1613       -3

Flag
Coverage Δ
Complexity Δ

#JDBC41
34.48% <ø> (-0.08%)
1559 <ø> (-5)

#JDBC42
34.49% <ø> (+0.05%)
1566 <ø> (+8)
:arrow_up:

Impacted Files
Coverage Δ
Complexity Δ

...a/com/microsoft/sqlserver/jdbc/SQLJdbcVersion.java
0% <ø> (ø)
0 <0> (ø)
:arrow_down:

...n/java/com/microsoft/sqlserver/jdbc/Parameter.java
31.38% <0%> (-0.87%)
37% <0%> (ø)

...oft/sqlserver/jdbc/SQLServerPreparedStatement.java
31.15% <0%> (-0.27%)
90% <0%> (ø)

...om/microsoft/sqlserver/jdbc/SQLServerBulkCopy.java
46.39% <0%> (+0.14%)
195% <0%> (ø)
:arrow_down:

...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java
39.14% <0%> (+0.2%)
0% <0%> (ø)
:arrow_down:

...om/microsoft/sqlserver/jdbc/ReaderInputStream.java
46.06% <0%> (+4.49%)
17% <0%> (+3%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab62a67...29b35ef. Read the comment docs.

@v-suhame Thanks!

@v-suhame, I updated the CHANGELOG. There were some incorrectly formatted URLs.


Provide a note on 'extern crate' usage in edition 2018 syntax of Rust

I was confused reading 'extern crate' in the examples of the book since it looks like old Rust syntax and encounters quite rare nowadays. So it is looked like not-updated. I saw an issue which tells that other people also had same thoughts. So my change is to make it clear that usage of this declaration form is intended and not-updated.

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @thejpster (or someone else) soon.
If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.
Please see the contribution instructions for more information.

I think it would be even better to change the code from extern crate panic_halt; to use panic_halt as _;

appropriate changes were made to github.com/rust-embedded/cortex-m-quickstart - PR


Bug: 1.16 - Strange and exciting results when using air as ground block in surface and ground control

Here is what it looks like when only the SurfaceBlock air (SurfaceAndGroundControl: AIR,DIRT,0.0), it can be used to make some cool effects if the biome is exactly at sea level.

Here is what happens when both SurfaceBlock and GroundBlock are air (SurfaceAndGroundControl: AIR,AIR,0.0)

For 1.16.5 - 0.0.15, any sagc block that is air (after replaceblocks) is set to waterblock when between waterlevelmin/max.


Test case 10B : "Error in FHIR validation"

I submitted a file for test case 10B (incoming messages ID 847 & 848) but its status comes out as "Error in FHIR validation", and they don't show up in "My test results". The file was however succesfully validated on https://fhir-testserver.be/index.php/visualization_webapp
Can you check what's wrong?

@sebwautelet ,
Indeed, you are right, there are no problems with the validation. We will investigate.

@sebwautelet ,
We were able to trace this problem to a transient issue on the international HL7 terminology server. The problem has disappeared, and we hope it stays so. You can retry to send the files.

Thanks @bdc-ehealth , our example has now been processed (test result #176). It didn't pass because of this rule :
Bundle.entry.where(resource is Observation).resource.where(code.coding.where(system = 'http://loinc.org' and code = '66121-5')).exists()
So I have some questions :

could this LOINC code (or LP7839-6?) be set on the DiagnosticReport instead? Our Observation linked to the DiagnosticReport refers to a more specific procedure (immunofluorescence), not sure if there's a LOINC code for it though.
we have more sub-Observations for the different paragraphs of the pathology report (macroscopy, microscopy, conclusion...). Is this OK or should all the text be contained in the same Observation?

Hello @bdc-ehealth , do you have an update on my 2 questions above?
Thanks

@sebwautelet ,
Sorry for the late reply, your message got out of my sight.

This is not my area of expertise. I will have to ask a clinical biologist.
Pathology has not been fully structured yet, so you have the choice: either you create a tree of observations if they fit within the current agreements, or you take only one observation and put everything in the string value of the observation. If you take the first solution, you of course have the risk that if pathology is structured in the future, the structure can be different from the one that you are creating now. BTW. If you have ideas how to structure pathology in FHIR, you can always give them as an input to the HL7 FHIR workgroup about Lab Reports.


Any chance of support for TF 2.4.0 (or later) ?

Dear authors of TFLMS,
I am one of the authors of this paper:
https://www.epj-conferences.org/articles/epjconf/abs/2021/05/epjconf_chep2021_03047/epjconf_chep2021_03047.html
The study presented in this paper strongly depends on TFLMS. Our follow-up studies with a real particle physics detector also depend on TFLMS. At the same time, we need to move on to CUDA 11. That pretty much implies migrating to TensorFlow 2.4.0 or later. Is there any chance that you might develop such a version of TFLMS ?
If not, I could of course try to take your published patch for 2.2.0 and merge it into 2.4.0 myself. Do you anticipate any particular/conceptual difficulties with this ?
Thanks !
Jan

Your work is really interesting and I'm glad LMS was able to help out with LHC work. Unfortunately, none of the original authors have plans to release newer versions of TensorFlow LMS.
I haven't looked at TensorFlow source code since the 2.2.0 release so I can't speak about specific difficulties you would encounter trying to upgrade the LMS patch to a 2.4.0 base. While we only published patches for 2.1 and 2.2, we did start the work back in the 2.0 days. During those two release changes (to 2.1 and 2.2) we saw changes in TensorFlow's native (C/C++ layer) eager execution which caused us to change the locations where we needed to trigger swap outs and swap ins. I think we may have also seen some changes in how tensors were tagged as "needed" and thus changes to how the code knows when it's OK to swap out inactive tensors.
Any changes to the BFC allocators or CUDA mem copy specifics between 2.2.0 and 2.4.0 would also probably drive additional changes.
You could also try reaching out to others who have used TensorFlow LMS to see if they are able to help with getting the code updated to 2.4.0. There are a few open and closed issues where others have talked about using it. In particular, @aviallon, who opened #54 was interested in the status of getting this merged back into the upstream/main TensorFlow code base.
I would also suggest taking a look at PyTorch and PyTorch LMS: https://github.com/IBM/pytorch-large-model-support. Depending on how much TensorFlow has changed vs how much PyTorch has changed, it may be easier to update PyTorch LMS for the latest PyTorch release. However, that would require you to change your models from TensorFlow to PyTorch.

Thank you for your detailed reply. I will look into all of these options. PyTorch LMS is a realistic option for us, since we have already created a PyTorch version of our models / code.


Google sitelinks not picking up page title or h1 on /works

What
Google has decided to index /works (without a query string) as one of the six sitelinks it displays below the main hit on a search for 'wellcome collection'. It isn't picking up the h1 or the page title to use as the link text for the sitelink, but instead looks to be taking an early anchor on a page of search results that would remove a particular filter (so far we have seen 'Remove "Popular works"' and 'Remove "VIRUS"').
Previously, there hadn't been an h1 on the page at all. We added one and hid it with CSS but kept it accessible to screenreaders. This appeared to make the issue go away for a while.
Where

The potential fix for this was deployed yesterday, and I requested a reindex for the /works page in the search console. Nothing's changed yet.
Something that's niggling away at me is that the 'Remove {filter name}' links don't appear on the root /works page, but only on pages that have a query string, so Google seems to be combining information it has found on one page (e.g. `/works?subjects.label="VIRUS") with another page that it displays as a sitelink.
We still don't have a visible h1 on search result list pages, which was a design decision a while ago. But I'm now wondering if we would need to have one in order to prevent this happening. I'm not sure how long is a reasonable amount of time to wait to find out whether the initial fix has worked. I think it was rectified within a day last time, but I guess it could take longer.

Looks like the fix was good enough for the time being.

I just spotted this too. I'll keep an eye out for if it changes again.


Revert "Enable paying Bolt12Invoice (#606)"

PR #606 seems to cause a regression when testing against eclair (InvalidOnionPayload).
I believe the issue is due to the change related to TrampolineOnion/OnionRoutingPacket.TrampolinePacketLength

I believe #611 is sufficient, and will be easier to revert once https://github.com/ACINQ/eclair/pull/2810 is deployed on our node.

Closed in favor of #611.


Disable secure connection(STARTTLS)

Hello
Could you help to understand how to run mail2go without using secure connection?
What is my use case - I'm need to send test email for portForwarded postfix, which have  STARTTLS option, so the connection can be secured, but as long I'm doing test locally with portForwarding I don't need to have secure connection.
Thank you

Hi, normally if there's no secure connection it should automatically detects it and make it work accordingly. What is the output it gives you when you try that if it doesn't work?

Output of the command
Error sending email: dial failed: tls: failed to verify certificate: x509: certificate is valid for *.my.maindomain.com, my.maindomain.com, not localhost

Oh ok I see, I can make a new release soon with more configuration options around TLS and TLS verification

Hi,
I made a new release (1.1.4).
I tried a similar setup as yours locally and seems to work for me now using the new TLS option.
Can you try the new version and tell me how it goes?
The instructions are in the release description or the new README.

Hello.
I have tried new release.
But, I guess, right now I can't check it. I faced this "problem"
$ mail2go -h
mail2go: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.34' not found (required by mail2go)
mail2go: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.32' not found (required by mail2go)

My ENV
PRETTY_NAME="Debian GNU/Linux 11 (bullseye)"
NAME="Debian GNU/Linux"
VERSION_ID="11"
VERSION="11 (bullseye)"
VERSION_CODENAME=bullseye
ID=debian
HOME_URL="https://www.debian.org/"
SUPPORT_URL="https://www.debian.org/support"
BUG_REPORT_URL="https://bugs.debian.org/"

libc-bin:
  Installed: 2.31-13+deb11u5
  Candidate: 2.31-13+deb11u10
  Version table:
     2.31-13+deb11u10 500
        500 http://security.debian.org/debian-security bullseye-security/main amd64 Packages
     2.31-13+deb11u8 500
        500 http://deb.debian.org/debian bullseye/main amd64 Packages
 *** 2.31-13+deb11u5 500
        500 http://deb.debian.org/debian bullseye-updates/main amd64 Packages
        100 /var/lib/dpkg/status

libc6:
  Installed: 2.31-13+deb11u10
  Candidate: 2.31-13+deb11u10
  Version table:
 *** 2.31-13+deb11u10 500
        500 http://security.debian.org/debian-security bullseye-security/main amd64 Packages
        100 /var/lib/dpkg/status
     2.31-13+deb11u8 500
        500 http://deb.debian.org/debian bullseye/main amd64 Packages
     2.31-13+deb11u5 500
        500 http://deb.debian.org/debian bullseye-updates/main amd64 Packages

Is it possible to build mail2go with older version of glibc?

Anyway, I was to harsh, so I build one, for my self, from the source code, this solve this issue.
It's seems you set -l flag as required  and without default value.
I would say, that is not a good idea, because of if someone using your script for some automatic test, it will stop working. In general this release will give people bit of a pain to actual the command/scripts.
It's better to save the previous behavior, by setting corresponding default value.
My test show this option -l working.
Can you say what is difference in tls-skip and none  - for it acts identically .
BTW - it's possible to ask mail2go to print the email which will be send to the postfix? For debug purpose, to understand on my side(sender) what will get postfix?
Thank you for the quick release))

Oh ok that might be because I built it with CGO enabled, I replaced the executables from the release tab with new ones built without CGO like before which should work. Try it and tell me how it goes

Didn't saw your previous comment, glad it works now!

Oh ok that might be because I built it with CGO enabled, I replaced the executables from the release tab with new ones built without CGO like before which should work. Try it and tell me how it goes

Now binary don't show any warnings

As for the -l setting yeah I could put tls as a default now that I think about it, that's somewhat how it was before. I won't make a new release for it I'll replace the 1.1.4 executables.

I'll check it later.
Thanks

Now binary don't show any warnings

Perfect thank you for checking.
Also just uploaded the version without required -l option.


Storage/swaggerfixes

rename numberOfHandlesFailedToClosed to numberOfHandlesFailedToClose
Fix comments for File Lease
Fix comments for Encryption Scope

/azp run automation - sdk

Can one of the admins verify this patch?


docs-bug(Typography): Description on mat-body-1 and -2 appear reversed

Documentation Feedback
Looking at how mat-body-1 (mat-h4) and mat-body-2 (mat-body) classes are applied, it seems that the descriptions in the documentation are reversed?

Affected documentation page
https://material.angular.io/guide/typography#typography-levels

Hello,
@michaelfaith what is the package and scope of this issue?
Trying to make a commit message, but finding it difficult to know the package and scope to use for the commit message format.

I would suggest "docs(material/typography)" similar to this one by Jeremy: https://github.com/angular/components/pull/25975

Alright.
@michaelfaith, How can I pass the "ci/angular: merge status" and "ci/circleci: lint" tests?
I've been trying to create a PR for a while now, and it's my first time here.

@DrVickie8 the "merge status" one is referring to the missing "target" label on the PR.  Notice some of the PRs have this "target" label indicated the significance of the change.  I.e. can it be part of a patch release (i.e. a bug fix), or is it significant enough to be part of a "major" release (i.e. has breaking changes).  I believe this should be a "target: patch", since it's a bug fix.

For the lint error, it actually tells you in the CI error message.  The commit message isn't formatted according to the contributing standards:

You'd need to redo the commit message so it aligns to what's listed in the CONTRIBUTING.md

So is this related to these missmatch in documentation:
https://material.angular.io/guide/typography#using-typography-styles-in-your-application
https://material.angular.io/guide/typography#typography-levels

Before fix can someone tell me which one is correct? I try to migrate from angular 14 version to 15.

After little investigation it seems that my finding is different than this issue. Although related. So can my findings be fixed also in this issue?

@JanneHarju i'm not sure i understand what your issue is. Can you explain?

I tried to color code those which are incorrect. So for example if you check h4 element. At left side(Typography levels) it says subtitle-2 and right side(Using typography styles in your application) it says h4 element is body-1. Same kind of miss match in other two.

I see what you mean.  The table I was highlighting conflicts with the table lower in the same page.  I was just pointing out that the name in the top table didn't reflect what was implemented for mat-body-1 and 2.  I didn't even realize there were the conflicts between the tables.  It seems like there needs to be an accuracy check across both sets of tables, identifying which rows are correct for each and then aligning them.

I think they should be aligned with material design spesification so even implementation might have flaws. I don't say there is but source for truth should be original source. Although I'm not sure does it contain anything this implementation spesific. But still implementation and both tables must me aligned with each other atleast.


merge package template from arlac77/npm-package-template

Updated standard to latest version

Coverage remained the same at 87.402% when pulling 164ca7790948ec1203ed6a28f6259c2d3b41479a on template-sync-1 into 553b7af50b237765438c8d3837e97df749149013 on master.

Codecov Report

Merging #109 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master    #109   +/-   ##
======================================
  Coverage    87.4%   87.4%
======================================
  Files          16      16
  Lines         127     127
======================================
  Hits          111     111
  Misses         16      16

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 553b7af...164ca77. Read the comment docs.


Move common validation code to single place.

This hopefully stops the crazy etcdclusteridchanged import errors in openstack test code.

LGTM.


Question

I have a question for echo -ne "\x00\x00\x00\x17\x00\x00\x00\x00" > /dev/hidg0
I can't map x17 to the letter t... even thought the output is a bunch of t's when I run this script.
Any insight?

Look on the page numbered 53 & onwards of this PDF for reference to all keys on the keyboard:
http://www.usb.org/developers/hidpage/Hut1_12v2.pdf
I found it after quite a search.

Problem solved?

Yes
On Thu, Jun 7, 2018 at 5:39 PM, Brosseau Valentin<EMAIL_ADDRESS>wrote:

Problem solved?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/c4software/pi-as-keyboard/issues/3#issuecomment-395557046,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AV2q0bGAEVhqKuVhTN5Qctg4xZu8Z_4qks5t6Y9ngaJpZM4SnABu
.

FUUUUUUUU

Never mind, found it on Archive.org
https://web.archive.org/web/20180827225742if_/http://www.usb.org/developers/hidpage/Hut1_12v2.pdf

For the record i attach the file here too
Hut1_12v2.pdf


office-ui-fabric-react-bundle 404 Not found

Thank you for reporting an issue or suggesting an enhancement. We appreciate your feedback - to help the team to understand your needs, please complete the below template to ensure we have the necessary details to assist you.
Category

[x ] Question
[ ] Typo
[x] Bug
[ ] Enhancement / Suggestion
[ ] Additional article idea

Expected or Desired Behavior
Initial install of SharePoint framework and generation of shell program "hello world" should display in my browser as in the tutorial.
Observed Behavior
Everything seems to start fine using gulp serve, but it displays a blank page in the browser. In the console I am receiving the following error: 404 not found - https://localhost:4321/node_modules/@microsoft/office-ui-fabric-react-bundle/02a01e42-69ab-403d-8a16-acd128661f8e.
Steps to Reproduce
I have tried creating a new folder and starting over, but I receive the same error.
Thanks for your assistance!

Hi @maleman82, can you please share the contens of the "node_modules@microsoft\office-ui-fabric-react-bundle" folder, and the "dist" folder inside that.

Thank you Manish for looking into this!
office-ui-fabric-react-bundle.zip

Any progress yet on this issue?

Finally after numerous attempts, patches, tweaks, I believe I have found the problem. Apparently, I did not have the right or matching versions of the generator-sharepoint, gulp-core-build-typescript, and the yo Client-side generator. Evidently I had a problem when I originally updated the generator-sharepoint. It had not actually updated like I thought it had.
So far I am able to create a new project and view it in the browser window!


Feature: Inquiry Type Dropdown

We'll add a dropdown menu where users can select the type of inquiry they have (e.g., General Inquiry, Support, Feedback, etc.). This dropdown will be positioned above the message input field.

please assign this issue to me under hacktoberfest2024


Decide if -o pipefail is always appropriate

Consider:
($$ xxd /dev/urandom | head -n 3)
Do clearly the user want's just 3 lines, but in this case xxd will exit with an error.
Currently this will throw an exception, in bash this will fail if run with set -eo pipefail .
What should we do to allow this case?
My thoughts is better to be safe with error exit codes, but allow the user to explicitly to opt in.
If we opt out/in of pipefail, how do we let the user specifiy this?

Perhaps we can check if a process was signaled by a pipe signal...

Now we do not consider a SIGPIPE as an error when getting a job exit code.


Remove increment from upload event emitters

This attempts to further simplify the upload event emitters by removing the increment, which never changes, and which should probably be controlled by the listener, not the emitter, since the listener is responsible for actually updating the progress. Also tries to ensure that events that get emitted to signal that an upload finished always happen even if the upload errors out.

I tried and failed to get this merged with main, so I'm just going to abandon it. IMO we should probably isolate the upload logic from ObsEditProvider somehow, but I'm not sure if a different context or using a hook would be best.


[DUOS-897][risk=no] Use local Roboto/Montserrat fonts

Addresses
https://broadworkbench.atlassian.net/browse/DUOS-897
Use downloaded versions of the css that we would normally link to google for.

Have you read Terra's Contributing Guide lately? If not, do that first.
I, the developer opening this PR, do solemnly pinky swear that:

[ ] PR is labeled with a Jira ticket number and includes a link to the ticket
[ ] PR is labeled with a security risk modifier [no, low, medium, high]
[ ] PR describes scope of changes

In all cases:

[ ] Get a minimum of one thumbs worth of review, preferably 2 if enough team members are available
[ ] Get PO sign-off for all non-trivial UI or workflow changes
[ ] Verify all tests go green
[ ] Squash and merge; you can delete your branch after this
[ ] Test this change deployed correctly and works on dev environment after deployment

Thank you @JVThomas!

Thank you @JVThomas!


compile fail when import types with decorator

TypeScript Version:  3.0.0-dev.20180602

Search Terms:
import types with decorator
Code
export class A {
  @test
  b: import('./b').B
}

// tsconfig.json:
{
    "experimentalDecorators": true,
    "emitDecoratorMetadata": true,
    ...
}

Expected behavior:

compile success
the design:type of property b is B.

Actual behavior:
when tsc output:
Error: Debug Failure. Unexpected node.
Node 179 was unexpected.

Playground Link:
N/A
Related Issues:
N/A

First we should not fail, second the resulting type would be Object at runtime.


feature request: assign origin to a different remote on creation

If you create your project with the CLI the origin remote is the repo where the boilerplate is.

Resolved by #2


Feat/Add support for weaviate vector db

Description
Adding support for weaviate vector database
Fixes #436
Type of change
Please delete options that are not relevant.

[ ] New feature (non-breaking change which adds functionality)

How Has This Been Tested?
from embedchain import CustomApp
from embedchain.embedder.openai import OpenAIEmbedder
from embedchain.llm.openai import OpenAILlm
from embedchain.vectordb.weaviate import WeaviateDb

app = CustomApp(llm=OpenAILlm(), embedder=OpenAIEmbedder(), db=WeaviateDb())

app.add(...)
app.query(...)

Please delete options that are not relevant.

[ ] Unit Test

Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules
[ ] I have checked my code and corrected any misspellings

Maintainer Checklist

[ ] closes #xxxx (Replace xxxx with the GitHub issue number)
[ ] Made sure Checks passed

@Dev-Khant for your reference

@Dev-Khant for your reference

Thanks, I will go through it

@rupeshbansal thanks for adding the support. Although, I think there are some issues with the integration which I found out when testing with the weaviate sandbox.
Issues:

Looks like we are trying to add documents again even when it already exists and hasn't changed. We should only try to add if it doesn't exist. If it exists and has changed, then we only update the ones that has changed. See the integration code for chroma and opensearch db.
Similar to the issue with pinecone db integration, looks like the chunks are not added properly to the weaviate db resulting in bad answers. See the code below to reproduce the issue

In [1]: from embedchain import CustomApp
   ...: from embedchain.embedder.openai import OpenAIEmbedder
   ...: from embedchain.llm.openai import OpenAILlm
   ...: from embedchain.vectordb.weaviate import WeaviateDb

In [3]: import os
   ...:
   ...: os.environ['WEAVIATE_ENDPOINT'] = 'https://xxx'
   ...: os.environ['WEAVIATE_API_KEY'] = 'xxx'

In [4]: app = CustomApp(llm=OpenAILlm(), embedder=OpenAIEmbedder(), db=WeaviateDb())
WARNING:root:DEPRECATION WARNING: Please use `App` instead of `CustomApp`. `CustomApp` will be removed in a future release. Please refer to https://docs.embedchain.ai/advanced/app_types#opensourceapp for instructions.

In [5]: app.query("What is the net worth of Elon musk?")
Out[5]: "As of September 2021, Elon Musk's net worth is estimated to be around $250 billion, making him one of the wealthiest individuals in the world. However, please note that net worth can fluctuate over time due to various factors such as stock market fluctuations and business ventures."

In [6]: app.add("https://www.forbes.com/profile/elon-musk")
Successfully saved https://www.forbes.com/profile/elon-musk (DataType.WEB_PAGE). New chunks count: 13
Out[6]: '8cf46026cabf9b05394a2658bd1fe890'

In [7]: app.query("What is the net worth of Elon musk?")
Out[7]: "As of September 2021, Elon Musk's net worth is estimated to be around $250 billion, making him one of the wealthiest individuals in the world. However, please note that net worth can fluctuate over time due to various factors such as stock market fluctuations and business ventures."

In [8]: app.add("https://en.wikipedia.org/wiki/Elon_Musk")
   ...: app.add("https://www.forbes.com/profile/elon-musk")

Successfully saved https://en.wikipedia.org/wiki/Elon_Musk (DataType.WEB_PAGE). New chunks count: 367
Successfully saved https://www.forbes.com/profile/elon-musk (DataType.WEB_PAGE). New chunks count: 13
Out[8]: '8cf46026cabf9b05394a2658bd1fe890'

Have addressed the comments. Requesting review please!


fix: Remove flipper config from the Podfile template

Summary:
When building a new project with React Native MacOS, it would fail with this error:
Couldn't install Pods. Updating the Pods project and trying again...
Command `pod install` failed.
└─ Cause: Invalid `Podfile` file: uninitialized constant Pod::Podfile::FlipperConfiguration.

 #  from /Users/moru/Documents/Work/test_project/macos/Podfile:18
 #  -------------------------------------------
 #      # Flipper is not compatible w/ macOS
 >      :flipper_configuration => FlipperConfiguration.disabled,
 #      # An absolute path to your application root.
 #  -------------------------------------------

As, for example, here: https://github.com/microsoft/react-native-macos/issues/2164
The ongoing solution was to remove that line from the Podfile, I'm sending this PR to edit the template so that line is removed by default.
Test Plan:
I'm probably going to need some help here, not quite sure how I can create a project against my local version of react-native-macos to test this one, but I'm sure that with this line removed (and as many other issues point) the project compiles and this error is avoided.

Hi! Thanks for the change! I thought we had done this, but I guess not. To get this in 0.74 and 0.75, we'll have to make PRs to the 0.74-stable and 0.75-stable branch. Can I ask what version of RNM you were using that encouraged this change?

Right now it happened to me with 0.75, I'm going to create PRs pointing to those branches and link them here in a minute!

Looks like it was only affecting on 0.75, since it's fixed on 0.74 (#2166). I opened mine for 0.75 here: #2200.
Thanks!


Last N actions as mlp_keys encoder input for dreamer_v3

Hi,
Working on an Atari environment wrapper with action input buffer with len=N that I want to feed as input to mlp_keys.
Algo config:
algo:
  mlp_keys:
    encoder: [actions]

However, unable to get it working, getting error TypeError: object of type 'NoneType' has no len() at
File "/home/sam/dev/ml/sheeprl/sheeprl/utils/env.py", line 171, in <listcomp>
    [k for k in env.observation_space.spaces.keys() if len(env.observation_space[k].shape) in {2, 3}]

Because gym.spaces.Tuple has no member shape.
Wondering what should change in this wrapper so it correctly interfaces with what sheeprl expects? Would there be a way to augment Tuple to have a shape, or should it change to a Box? If needed to be Box, what should be its config?

class InputBufferWtihActionsAsInput_Atari(gym.Wrapper):
    def __init__(self, env: gym.Env, input_buffer_amount: int = 0):
        super().__init__(env)
        if input_buffer_amount <= 0:
            raise ValueError("`amount` should be a positive integer")
        self._input_buffer_amount = input_buffer_amount
        self._input_buf = deque(maxlen=input_buffer_amount)
        self.observation_space = gym.spaces.Dict({
                "rgb": self.env.observation_space,
                "actions": gym.spaces.Tuple([self.env.action_space] * input_buffer_amount)
            })

    def get_obs(self, observation):
        return {
            "rgb": observation,
            "actions": self._input_buf
        }

    def reset(self, **kwargs):
        obs, infos = super().reset(**kwargs)

        while len(self._input_buf) < self._input_buf.maxlen:
            self._input_buf.append(self.env.action_space.sample())

        return self.get_obs(obs), infos

    def step(self, action):
        this_frame_action = self._input_buf[0]
        self._input_buf.append(action)

        obs, reward, done, truncated, infos = self.env.step(this_frame_action)

        return self.get_obs(obs), reward, done, truncated, infos

Edit:
I have a working setup using hard-coded, implementation details-aware wrapper using stuff like this. Still wondering how to achieve generic solution though.
        self.observation_space = gym.spaces.Dict({
                "rgb": self.env.observation_space,
                #"last_action": self.env.action_space
                #"actions": gym.spaces.Box(shape=(self.env.action_space.shape, input_buffer_amount), dtype=np.int64)
                #"actions": gym.spaces.Box([self.env.action_space] * input_buffer_amount)
                "actions_0": gym.spaces.Box(low=0, high=8, shape=(1,), dtype=np.int64),
                "actions_1": gym.spaces.Box(low=0, high=8, shape=(1,), dtype=np.int64),
                "actions_2": gym.spaces.Box(low=0, high=8, shape=(1,), dtype=np.int64),
                "actions_3": gym.spaces.Box(low=0, high=8, shape=(1,), dtype=np.int64),
            })

    def get_obs(self, observation: Any) -> Any:
        #observation['past_actions'] = spaces.Space(list(self._input_buf))
        return {
            "rgb": observation,
            #"last_action": self._input_buf[0]
            #"actions": np.array(self._input_buf, dtype=np.int64)
            "actions_0": self._input_buf[0],
            "actions_1": self._input_buf[1],
            "actions_2": self._input_buf[2],
            "actions_3": self._input_buf[3],
        }

Hi @geranim0,
yes, the observation space must have the shape attribute. I suggest to use the gymnasium.spaces.Box space to augment the observations of the environment.
I prepared a branch with the ActionsAsObservationWrapper that allows you to add last n actions: https://github.com/Eclectic-Sheep/sheeprl/tree/feature/actions-as-obs.
You can specify the number of actions in the env.action_stack parameter. You can also add a dilation between actions (like in the FrameStack), you can set the dilation with the env.action_stack_dilation parameter in the configs.
The key is "action_stack", otherwise it creates conflicts during training (add it to the mlp_keys).
Let me know if it works
Note: Discrete actions are converted into one-hot actions (as the agent works with one-hot actions in the discrete case). We can discuss which is the best option.
cc @belerico

Hi @Michele,
Thanks for the branch! Taking a look and doing some tests with it.

So, did some testing, here are the results

Where the gray line represents the agent trained with the last N (in this case, 12) actions added to the observations, and the blue line represents the agent trained with the same input buffer (12), without the input buffer as observation. Only 1 run was made for each, but it looks like in the presence of a large input buffer, adding the input buffer as observations is helpful.
It also suggests that the branch works 👍
Only modification I made to your branch was add an input buffer to the wrapper.

Great, I'm glad it works.
I do not understand why you added the input buffer and how you used it. Can you show me which modification you made?
Thanks

Sure, actually it is in my first message, in the step function. Instead of using this frame action, I use the one ready for use in the buffer with this_frame_action = self._input_buf[0].
The purpose of this is to simulate human reaction time. That's why I wanted to test adding the input buffer to the observation, to see if it would improve performance (looks like it does).

Understood, thanks

Hi @geranim0, if this is done we can add this feature in a new PR and put it in the next release

Hi @belerico, sure!
Side note though, in tests using Discrete action space, things worked fine, but encountered some problems with the action shape not being handled with MultiDiscrete envs for the action-as-obs wrapper and also dreamer_v3.py::main() with this portion
  real_actions = (
      torch.cat([real_act.argmax(dim=-1) for real_act in real_actions], dim=-1).cpu().numpy()
  )
  step_data["actions"] = actions.reshape((1, cfg.env.num_envs, -1))

For now got around it by reshaping my action space to Discrete. Kind of using an old branch, will re-test with when updating.

Hi @geranim0,
can you share the error you encountered and which environment you are using?
Thanks

I should have fixed the problem, could you check with the multidiscrete action space?
Thanks


Added package.json

Hi there,
Thanks for this. It would be nice if it would npm-installable. Would you consider adding a package.json and publishing the project to npm?
Thanks

Thanks Reggino!


Make logging hot paths lighter.

Logging is the hotspot in our application today. This takes a first stab at making the overhead a bit smaller by respecting the set log-level as early as currently possible and not do any extranous throwaway computation.
It also reduces a bit of unnecessary boxing for the sake of just trying to keep a single space out of the message.

PG1 2087 🔵

With these prs can we record pre and post improvements?


chore: upgrade spring boot to 3.0.3

Issue
Dependabot
Description
Upgrade Spring to 3.0.3
Checklist

Code is easy to understand
No obvious errors or bugs
CI/CD Pipelines did run successfully
Tests were implemented
Documentation was created

@rami-nk Could you check the pizza example?
Moreover I have deleted a few classes in the user integration.
No need for requesting the current logged in user. It also had a dependency on camunda

Do you still want me to do this? I think the example is already migrated to the consulting repo, not sure tho


Duplicated celery setting for django?

Here: https://docs.getsentry.com/hosted/clients/python/integrations/django/#additional-settings
it says:
If you are also using Celery, there is a handler being automatically registered for you that captures the errors from workers. The default logging level for that handler is logging.ERROR and can be customized using this setting:
SENTRY_CELERY_LOGLEVEL = logging.INFO
RAVEN_CONFIG = {
    'CELERY_LOGLEVEL': logging.INFO
}

Is it intentional? Does the setting need to be duplicated as shown?
PS: tried to dig into the code but could not figure it out

We should probably kill the first one. Technically we support both, but theres no reason that anyone should care about that.

Sounds reasonable to remove the first one from the docs.

Curious thing, I cannot find that bit of text here: https://github.com/getsentry/raven-python/blob/master/docs/integrations/django.rst
Am I looking at the wrong file?

It's that file, it's in the source. Github just fails at rendering it.

Fixed in bbc7e1523c3723c5fe479494e03abb0e0400ecf1

Ok sorry I should have looked more in deep, I wanted to send a small patch but @mitsuhiko was faster ;-)
Thx


Knowhow build up about the use of keycloak in marketplace

As a developer I want to get the knowhow about how to use keycloak and its possibiltiy for using it in marketplace so that I can use it for database solution questions / security and so on.
DoR

[ ]  We got a story about the possibility using keycloak elements. In this case it is Ticket
https://github.com/AkrosAG/Akros-Marketplace/issues/182

Acceptance Criteria

[ ] AC1: The knowhow about using parts of keycloak is build up and documented
[ ] AC2: The knowhow about where our keycloak server runs (inhouse / internet and country and company) is up to date.
[ ] AC3: For the ticket 182 we know wheter it is worth to use components from keycloak instead of our table advertiser or not
[ ] AC4: In case of using keycloak elements instead of table we know which table we will drop and how to use keycloak instead
[ ] AC5: In case of using keycloak elements we have a new ticket that specifiy each step to get keycloak in use in marketplace

DoD

[ ] We got the knowhow about using keycloak
[ ] Because of the huge possibility of keycloak the analysed parts are documented
[ ] The decision is done about we will use keycloak for fulfill ticket 182 or we handle it as it is designed today.
[ ] We got an estimation about how many days it takes to change the current databasemodel with the keycloak solution
[ ] When we use keycloak we got a new ticket in which every step to change the use of database and so on is documented

After what I learned about keycloak it does not make sense to connect our db with this from keycloak because it is a system that works perfectly how it is.
For the marketplace that means know that we have 2 possibility how resolve the ticket #182

Save userId on the topic
At the moment we are saving on the topic an userId that comes from keycloak. With that we can show our adds and everything. That would also be a little bit the easier way

After register save the created user from Keycloak in our advertiser table
As soon as we have registered the user in keycloak, we would need to store it also in our table. So that would mean we save the information twice and for making one register we would need 2 requests


Move dev dependencies to devDependencies

I ran into the problem that I couldn't use Radium in a Babel 6 app because<EMAIL_ADDRESS>was in Radium's dependencies. I also moved some other dev dependencies which weren't used anywhere in src/ to devDependencies.

Ah yes, I see that they're used in postinstall. Thanks for pointing out @ryan-roemer!
But I wonder why postinstall is even needed, lib/ is built during prepublish? In any case the babel@5 dependency breaks apps which are built with Babel 6.

@herrstucki -- lib/ is not in source, so if you do a dependency like:
"radium": "FormidableLabs/radium"

or off of a fork / working git branch / etc. you'll need to create lib/.


TypeError: hoistNonReactStatic is not a function

Thanks for awesome hoc. I get this error when I try to use it: "TypeError: hoistNonReactStatic is not a function".
I'd be really thankfull if you could take a look at this issue.
This is repo with code for reproducing : https://github.com/annmirosh/react-click-outside-bug
Thanks

ugh, related to this package https://github.com/mridgway/hoist-non-react-statics/issues/52

I think it works now, but you might need to remove your node_modules directory and reinstall packages to get a working version of the hoist-non-react-statics package


400 Bad Request after starting vite dev

Question
I get a 400 Bad Request error when I open the URL http://localhost:3000 after running ddev npm run dev
docker-compose.vite.yaml
# Override the web container's standard HTTP_EXPOSE and HTTPS_EXPOSE services
# to expose port 3000 of DDEV's web container.
version: '3.6'
services:
  web:
    # ports are a list of exposed *container* ports
    ports:
      - "3000"
    environment:
      - HTTP_EXPOSE=${DDEV_ROUTER_HTTP_PORT}:80,${DDEV_MAILHOG_PORT}:8025,3001:3000
      - HTTPS_EXPOSE=${DDEV_ROUTER_HTTPS_PORT}:80,${DDEV_MAILHOG_HTTPS_PORT}:8025,3000:3000

vite.config.js
  server: {     host: '<IP_ADDRESS>',     port: 3000,     strictPort: true,   },
package.json
  "scripts": {     "dev": "vite",     "build": "vite build",     "preview": "vite preview"   },

This is unlikely to have anything to do with the Craft Vite plugin, it's likely a DDEV setup issue of some kind. I'd have a look at the existing setups that use DDEV for examples.
(I don't use DDEV for my local dev usually, so unfortunately I don't have an answer for you)


Scenarios are not running: SignalRBroadcast, SignalREcho, SignalREchoAll

Some scenarios have stopped running:

Scenario
Environment
Last Run

SignalRBroadcast
Windows, Cloud, http, KestrelSockets
2019-10-24 22:29:56Z

SignalREcho
Windows, Cloud, http, KestrelSockets
2019-10-24 22:34:19Z

SignalREchoAll
Windows, Cloud, http, KestrelSockets
2019-10-24 22:37:44Z

Logs

Dup of https://github.com/aspnet/AspNetCore/issues/15422


Add UI for creating a data template for peoples data

I've been wondering if we could let people select 1 or more folders and then like OMERO (i think) does, prompt them to tell us what each hierarchy of a folder represents and what parts of a file path mean
This came up in a few conversations where people think it is something they have to train themselves to do going into a project rather than doing retroactively. Could we get around that by at least creating a basic template for them to then download and edit in excel to then re-upload to BFF?

Duplicate of #92


无论是否为好友 ，都提示has been friend with bot, no need to send friend request!

Important：Please file the issue follow the template, or we won't help you to solve the problem.

0. Report Issue Guide

Please run the following command and check whether the problem has been fixed：

rm -rf package-lock.json
rm -rf node_modules
npm install

Please search in FAQ List first, and make sure your problem has not been solved before.

Please search in the issue first, and make sure your problem had not been reported before

1. Versions

What is your wechaty version?
Answer: 0.22.6

Which puppet are you using for wechaty? (padchat/puppeteer/padpro/...)
Answer: padpro

What is your wechaty-puppet-XXX（padchat/puppeteer/） version?
Answer: padpro": "0.0.57"

What is your node version? (run node --version)
Answer: v10.15.3

What os are you using
Answer: mac

2. Describe the bug
测试场景是添加群成员
无论是否为好友   Friendship.add(contact, hello) 都提示：
WARN PuppetPadpro friendshipAdd wxid_hshg4vdh0ix421 has been friend with bot, no need to send friend request!
3. To Reproduce
const memberList = await room.memberAll()
for (let i = 0; i < memberList.length; i++) {
await bot.Friendship.add(member, '你好')
}
4. Expected behavior
Give a clear and concise description of what you expected to happen.
5. Actual behavior
If applicable, add screenshots to help explain your problem. But do not paste log screenshots here.
6. Full Output Logs

7. Additional context
Add any other context about the problem here.
[bug]

Don't put screenshot image as the output logs, just copy paste the log into the issue.
You should check whether the user is oneway friend with the bot.
In WeChat, friendship are double directions.
For example: Bot and Tom are friends means that Bot is Tom's friend and Tom is Bot's friend. When you delete Bot in Tom's account, you are removing the connection from Tom to Bot, but the connection from Bot to Tom is still there. When you try to accept the request from Bot, it can not be done since Bot is already a friend of Tom.

双方一直不是好友，是一个完全不认识的，他们从来没有加个好友
也会提示：WARN PuppetPadpro friendshipAdd wxid_y85hr471 has been friend with bot, no need to send friend request!

更新了版本 ：
"wechaty": "^0.26.1",
"wechaty-puppet-padpro": "^0.2.1"
没有报错了，但是没有成功发送加好友请求


Don't fail containerd start in case of corrupted events.log

Some host crash scenarious might cause a corruption at the end of the
events.log. In those cases, the file ends with multiple 0x00 (assuming
that were created for journaling of an event prior the crash).
In such case, there is no meaning of preventing containerd from starting.
This commit add a logic of ignoring the rest of the file (it should be a single event
that is missing anyhow) and proceed with those that were succesfully parsed so far.
Tested using the corrupted log attached to the github issue.
Signed-off-by: Rom Freiman<EMAIL_ADDRESS>

LGTM

LGTM


Additional config properties

I'd like to propose some additional config properties for config.json files:

notes: Array of notices in markdown that developers should be aware of, useful for deprecated features like String.prototype.contains, eg "This feature was deprecated due to poor existing native implementations, and replaced with String.prototype.includes"
repo: URL of the repository from which the polyfill has been copied.  It's otherwise been tempting to put that into the author property, and it would be better in such cases to provide repo and leave author blank.

Thoughts?

Good idea!
I propose to use package.json format like
"name"       : "URL",
"version"    : "1.0.0",
"author"     : "Mail.Ru Group Limited",
"description": "https://url.spec.whatwg.org/",

"man": "README.md"

"os" : [ "darwin", "linux", "!win32" ]
"cpu" : [ "x64", "ia32" ]

"maintainers": [
	{
		"name" : "Alexander Abashkin",
		"email"<EMAIL_ADDRESS>	}
],

"repository" : {
	"type": "git",
	"url" : "git@gitlab.corp.mail.ru:cloud/aviary.git"
},

"licenses": [
	{
		"type": "MIT",
		"url" : "http://www.opensource.org/licenses/mit-license.php"
	}
]

I disagree with that - the data we're describing is quite different to a node module, there's no equivalent to the browsers and variants objects for example.
I'd like to also add a spec property to contain the URL of an appropriate spec doc, to make the most of the behaviour of adding a spec URL to the top of the polyfill, which is a great idea that @jonathantneal has started doing with stuff like https://github.com/Financial-Times/polyfill-service/blob/master/polyfills/Element.prototype.after/polyfill.js#L1.  That's incredibly valuable for those of us who struggle to find the canonical description of a feature.
I've updated the OP with this.

Closed by https://github.com/Financial-Times/polyfill-service/pull/337


"List schemes" should list schemes instead of preview

Steps to reproduce
$> base16-builder ls schemes

Expected Behaviour
a list ls of a all names of schemes
Actual Behaviour
a wide html page
Proposition
Split the preview from the listing:

$> base16-builder ls schemes should list schemes name
$> base16-builder preview schemes should preview schemes name

We may want to use another word than "preview". In top of my head, I think of "render", "show", "view" and "display" too.
Node and npm versions

Node: v6.2.2
NPM: 3.9.5

Base16-Builder version
1.2.0
Additional Information
Related to  #127

Hm, I'm not sure about this one.
In response to #127, I would rather make the tool warn that the scheme ateliersulphurpool could not be found, but schemes with a similar name could. The error might look something like this:

Could not find ateliersulphurpool. Here are some similarly named schemes you might have meant: atelier-sulphurpool, atelier-foo

That being said, I do not love the current ls schemes command


Improved the spacing in homepage, and the Card Content's Spacing and Visibility #10

Title : Improved the spacing in homepage, and the Card Content's Spacing and Visibility
Issue No. : #10
Code Stack : CSS
Closes #10
Video (mandatory)
https://github.com/user-attachments/assets/c62b6ae6-01e6-44d3-8070-0b2aa74ae5e5
Checklist:

[ X] I have mentioned the issue number in my Pull Request.
[ X] I have commented my code, particularly in hard-to-understand areas
[ ] I have created a helpful and easy to understand README.md if its a new page/tech stack
[X ] I have gone through the  contributing.md file before contributing

Additional context (Mandatory )
Screenshots:

Are you contributing under any Open-source programme?

[ X] I'm a GSSOC-EXT contributor
[ X] I'm a HACKTOBERFEST contributor

kindly add gssoc label to be considered under gssoc exd.


Expose schema registry errors

Hello,
Thanks for this great library!
I was wondering if there's a simple way to check for "subject not found" errors.
I can see that in the IsRegistered method, there's a check for schema not found error:
if ce, confluentErr := err.(confluentError); confluentErr && ce.ErrorCode == schemaNotFound {
	return false, fs, nil
}

But the const subjectNotFound is not used on the project. Is there any reason behind that?
Thanks!

@racevedoo
When https://github.com/Landoop/schema-registry/pull/12 will be merged, open your terminal and execute go get -u github.com/landoop/schema-registry/schema-registry-cli to update the package, you now have two helpers for the error type check:
if schemaregistry.IsSubjectNotFound(err) {
 // error raised by subject not found.
}

if schemaregistry.IsSchemaNotFound(err) {
 // error raised by schema not found.
}

Thanks and do not hesitate to ask for more, please do consider our lenses-go too!


Add oss-fuzz responsibility

@hiddeco @scottrigby please share your views on this.
Do we need to capture somewhere all the access people should attain when they become part of the Security Team?
This would help keeping the accesses in line once folks move on from the team as well.
Here's an example of access that needs to be managed as part of the Security Team membership:
https://github.com/google/oss-fuzz/blob/master/projects/fluxcd/project.yaml#L4-L9

Here's an example of access that needs to be managed as part of the Security Team membership:
https://github.com/google/oss-fuzz/blob/master/projects/fluxcd/project.yaml#L4-L9

I think it would be good to take note of this somewhere, as it's easily forgotten.

@hiddeco 💯
@pjbgf this note should probably be another bullet point in the PROCESSES doc under Applying as a Security Team member > Adding new… > "Once the above process has taken its course, make sure you"

Added the extra step as part of this PR. PTAL


As a content editor, I want to associate an author other than myself with a blog post so that I can indicate who wrote the content.

Notes for testing
I have it configured so the author defaults to the current user, since I figured that was the most likely scenario.

Author defaults correctly. I am able to change author to a different person listed in the menu. I am able to add a person not listed in the menu and select him/her too.


entrypoint: logstash -e doesn't work anymore with 6.1.2

I use logstash docker from within a stack in which I have the following service definition:
    image: docker.elastic.co/logstash/logstash:6.1.2
    environment:
      config.support_escapes: "true"
    logging:
      driver: "json-file"
    networks:
      - logging
    ports:
      - "12201:12201"
    entrypoint: logstash -e 'input { ........
                        output { stdout{ } elasticsearch { hosts => ["http://elasticsearch:9200"] } }'

Unfortunately this causes: ERROR: Settings 'path.config' (-f) and 'config.string' (-e) can't be used simultaneously.
I don't understand why this happens as I don't specify -f at all in the entrypoint. How can I get this to work?

Ugly hack in my docker-compose file:
version: '3.1'
services:
  logstash:
    image: docker.elastic.co/logstash/logstash-oss:6.1.3
    command: sh -c 'rm -v /usr/share/logstash/config/logstash.yml; logstash -e "input { syslog { port => 51414 } } output { elasticsearch { hosts => [\"elasticsearch:9200\"] } }"'
    restart: unless-stopped
    networks:
      - elasticnet
    expose:
      - "51414/udp"
networks:
  elasticnet:
    external: true

Can you tell me about the reasons you use -e instead of putting your pipeline configs in a file?
For background, the -e flag was primarily intended as for testing or one-off examples.
We can try to bring back the functionality you are using, but I want to understand better your specific use cases and situation to see if we can provide an alternative.

@jordansissel I have a docker swarm with 5 nodes and I'm using portainer as a front end.  I don't want to have to create docker configuration items, then create a stack and reference those configuration items.  It's "too many moving parts" if I have to do disaster recovery.
Currently I can create my 'proxy' network and then paste my docker-compose file in to portainer.  I'm back online.  If I used docker configs, I would have to create the 'proxy' network, create a bunch of properly-named config files, paste in the docker-compose file, ensure I have the proper config files mapped to the proper logstash instances, etc...too much work. ;)

If your output is Elasticsearch, this means you probably can use Logstash's central management feature which lets you store the configuration in Elasticsearch and may solve your concern (which I admit I don't fully understand[1])
As an alternative, you can also specify a url (http/https) for where to fetch your config. For example:
input {
  generator { count => 1 }
}

output {
  stdout {
    codec => rubydebug
  }
}

I created a gist (https://gist.github.com/jordansissel/afca9c30542262837e1f342cfd65aec2) and we can point Logstash at the raw file contents:
% bin/logstash -f https://gist.githubusercontent.com/jordansissel/afca9c30542262837e1f342cfd65aec2/raw/671bc59e04b85cbe240b881bbb0ffb149bf0a971/gistfile1.txt
{
  "@version"   => "1",
  "sequence"   => 0,
  "@timestamp" => 2018-02-01T06:21:20.546Z,
  "message"    => "Hello world!",
  "host"       => "pork.semicomplete.com"
}

Additionally, as a general concern, it seems lots of people have different preferences about how to run Logstash in Docker, and many of these preferences are incompatible with the others. Can you build an image which layers your changes on top of this one? If not, why not?
[1] you say "too much work" but I look at the complexity of the machine you just described and I am not understanding yet why 'put it in a file' is significant amounts of work. This is not a judgement against you - I try to say that I don't understand yet how you are measuring "work"  ;)

I can build an image and put the changes on top. But when I develop my filters/logstash config for my docker swarm this will mean that everytime I change something I need to create a new image and push it to the registry and then redeploy.
Also it makes things way more complicated if I have to keep the configuration of logstash somewhere in another repo and then remember which image correspons to which state of that repo.
When using the official elk docker registry its also extremely easy to update the version of elk (just change version number and check if everything still works). Having a separate image just introduces another step.
Another thing is that I like having as many services as possible on official repositories as my own repository can be a bottleneck (when I deploy an application to a swarm of 10 servers, 10 servers will simultaniously docker pull a bunch of large images)

Sorry @jordansissel, my last reply was a bit brief.
I'm of the opinion that a docker-compose file should describe the entire application stack.  But when it comes to 'docker config' files you literally have to load a config file in (i.e. cat myconfig | docker config create myconfig.yml -) and then reference that in your docker-compose file--something like:
version: '3.3'
services:
  heartbeat:
    image: 'docker.elastic.co/beats/heartbeat:6.1.2'
    configs:
      - source: monitoring.1
        target: /usr/share/heartbeat/heartbeat.yml
configs:
  monitoring.1:
    external: true

Docker configs can't be edited, and they can't be removed if a service is using them.  But they are a decent way of directing docker to insert a file into a docker image.   Anyways, if I wanted to make a change (in this example heartbeat) to the config file, I would have to edit the config, create a new docker config (maybe 'monitoring.2'), then go in and update the above docker-compose file and change two places from monitoring.1 to monitoring.2 and submit it...then the services would restart and I could go in and delete monitoring.1.
Using -e from the command line when it's simply for translating between syslog and elasticsearch is so much easier.  If I need something more complex like grok, I will probably end up using a config file, building my own custom image, or using the -f method to pull from a URL as you mentioned above.
Although personally I think the most ideal situation would be for something like logspout to support an elasticsearch output (as opposed to logspout -> syslog -> logstash -> elasticsearch).

I just tested this against a build candidate for the upcoming 6.2.0 release, and it appears that -e will work again.
We made a change w/r/t defaulting to multiple pipeline configuration that inadvertently appears to have fix this.  Since this an incidental fix, we are not explicitly testing or making any guarantees about this behavior.
I will leave this issue open for further discussion and to allow others to test when 6.2.0 is released.

I see a failure when running the logstash-docker#master test suite (as of today) that seems to indicate -e pipeline.batch.delay wasn't parsed properly:
   def test_setting_pipeline_batch_delay_from_environment(logstash):
10:25:59         logstash.restart(args='-e pipeline.batch.delay=36')
10:25:59 >       assert logstash.get_node_info()['pipelines']['main']['batch_delay'] == 36
10:25:59 E       KeyError: 'batch_delay'
10:25:59
10:25:59 tests/test_settings.py:17: KeyError

This is certainly odd, as I don't see any changes in the corresponding product master branches or this repo. I thought I'd add this here, in case this is common knowledge.

Though the KeyError is on the batch_delay key, which is at the bottom of the tree, so there is some structure being returned. Interesting.
Can I ask how you are generating the failure result? The CI runner seems happy.

Both good points. The automated CI seems to be happy again, so I consider this a transient issue related to a delayed start of the monitoring API.


Password form field not rendered

This is  a bug.

Prerequisites

[ 3.3.4 ] Are you running the latest version?
[ x ] Are you reporting to the correct repository?
(enso is made of many specialized packages: https://github.com/laravel-enso)
[ x ] Did you check the documentation?
[ x ] Did you perform a cursory search?

Description
While trying to add a password form field for one of my models called "cluster", I see no field being rendered inside the edit form.

Container is created:

cluster.json:
{
  "routePrefix": "models.clusters",
  "sections": [
    {
      "columns": 2,
      "fields": [
        {
          "label": "Name",
          "name": "name",
          "value": null,
          "meta": {
            "custom": false,
            "type": "input",
            "content": "text",
            "disabled": false
          }
        },
        {
          "label": "Hash",
          "name": "cluster_hash",
          "value": null,
          "meta": {
            "custom": false,
            "type": "input",
            "content": "text",
            "disabled": false
          }
        }
      ]
    },
    {
      "columns": 1,
      "fields": [
        {
          "label": "Description",
          "name": "description",
          "value": null,
          "meta": {
            "custom": false,
            "type": "textarea",
            "content": "text",
            "disabled": false,
            "rows": 2
          }
        }
      ]
    },
    {
      "columns": 2,
      "fields": [
        {
          "label": "HIDDEN",
          "name": "HIDDEN",
          "value": null,
          "meta": {
            "custom": false,
            "type": "input",
            "content": "text",
            "disabled": false
          }
        },
        {
          "label": "HIDDEN",
          "name": "HIDDEN",
          "value": null,
          "meta": {
            "custom": false,
            "type": "input",
            "content": "text",
            "disabled": false
          }
        }
      ]
    },
    {
      "columns": 2,
      "fields": [
        {
          "label": "Username",
          "name": "username",
          "value": null,
          "meta": {
            "custom": false,
            "type": "input",
            "content": "text",
            "disabled": false
          }
        },
        {
          "label": "Password",
          "name": "password",
          "value": null,
          "meta": {
            "custom": false,
            "type": "password",
            "disabled": false
          }
        }
      ]
    }
  ]
}

Index view is OK

Steps to Reproduce

Create CRUD using enso:cli for "cluster"
Define table structure
Define form structure

Expected behavior
Password field should be rendered as a password field.
Actual behavior
Missing field

The correct repo would be forms
from user.json
{
    "label": "New Password",
    "name": "password",
    "value": null,
    "meta": {
        "readonly": true,
        "type": "input",
        "content": "password",
        "hidden": true,
        "custom": true
    }
},

It should have a "type": "input", "content": "password".
You also have a problem with the validations if you did not receive an error with that template.

The correct repo would be forms
from user.json
{
    "label": "New Password",
    "name": "password",
    "value": null,
    "meta": {
        "readonly": true,
        "type": "input",
        "content": "password",
        "hidden": true,
        "custom": true
    }
},

It should have a "type": "input", "content": "password".
You also have a problem with the validations if you did not receive an error with that template.

1st - sorry for the miss-report in the incorrect project.
2nd - maybe a small documentation mistake? - because i tried to follow the documenation therefore, when type is password, there is no content needed as it is only required for type input:

Thank you help and for your quick replys.

updated docs


Patch install guide for new Dev Portal

Needed to update install doc to more easily enable Dev Portal.

awaiting mergination by proper authorities


Make sure user policy creation take into the account the number of users per realm

Closes #291

thanks for fixing the bug, lgtm


This repository is excluded from Hacktoberfest as it doesn't align with their core values.

Yes, confirmed here as well. The owner should put a message on the README to clarify that pull requests on this repo will not count towards Hacktoberfest.
In fact the Hacktoberfest team already put an issue up in https://github.com/rishabh-bansal/GitStart/issues/3812 explaining the situation but the owner closed the issue so it's not visible by default, and I guess most beginners will not realize this.


Please this is not working in IE 11

Do you have some polyfill to use for this library? I spent a lot of time building but I can make it work on IE. Some suggestion or help?

I have found this polyfill and solve my problem
I have figure out that new URL is not supported by IE
here we go!
<EMAIL_ADDRESS>


Use emoji flags directly instead of computing them

I'm experiencing a noticable delay when opening the currency picker widget. I guess because it has to compute more than 200 flags when generating the listview.
Can we just add the emoji data directly to the list?
I think that will boost the performance of the package.
What do you think?

@minhdanh Yes we can, feel free to create a PR.


how to check if a piece has an attack available (on your side )

Okay so i am kinda starting out C# and this whole thing is new to me so i am a little confused. Do i just loop through the entire  board and checking every square or is there a craftier way to do this.
Help would be appreciated

By attack do you mean a capture move? If so, you can just loop through all the moves in board.getLegalMoves() and check if the start square of the move is the square of your piece and the captured piece of the move isn't PieceType.None

Use board.getLegalMoves(true)

Specifically, the line:
Move[] allCaptureMoves = board.GetLegalMoves(true);
will give you all of your moves stored in an array variable named "allCaptureMoves". You can then iterate over these moves to check which pieces have captures available, or look to see if the piece you are interested in is in any of the moves in the array.


Lock -> activate Pin XX -> deactivate after 3 sec.

I search for an lock a-plugin, that just swtich on an relais who is connected to an pin on the PI. Does someone know a solution?

use node-red and  homebridge-mqtt plugin, node-red gives you the ability to trigger gpio on raspberry very easy. if you are running raspberry pi just type node-red-start then go http://Your_ip-address:1880


Implement title reactivity in the corresponding get/set methods

Great. I'll take this.

Published with 1.4.0

Thank you for the fast response! — I should definitely take inspiration from that :-)


Fixed but that would delete and re-create jobs over and over again if…

… two PlanExecutions created a job with the same name
This bug also only manfiested itself for Plans with Jobs since Updating a job does not cause it to re-run, which is the desired action.  The controller, thus, deletes Jobs that it should create with the same name IF they've been created by a different PlanExecution (identified via Label values)
This bug would manifest itself when restarting the controller.  Restarting the controller would cause previously completed PlanExecutions to get re-Reconciled.  When reconciling a completed plan, the function would not properly handle the Completed state escape early.
The Completed plan would see that there's a job out there already, but for a different PlanExecution and delete it so it could make a Job for the current plan.

Closes #57


Improvements to sync migrations

We were crashing when migrating between Folio versions (to an album sync version) when there were albums with no artworks empty. This protects against that.

          1 Warning

:warning:
Needs testing on a Phone if change is non-trivial

  Generated by :no_entry_sign: Danger

This should get merged BTW, as it's what is shipped.


Report table on mobile device auto expands

Describe the bug
When scrolling on mobile + resizing the window on a desktop, the data table suitable expand.
What version are you running?
4.1.0
Did this happen on prior versions to the one you are running?
Unsure
To Reproduce
Steps to reproduce the behavior (on a mobile device)

Go to 'reports'.
Click on a service body with data.
Scroll down
Note the data table expands all rows.

Steps to reproduce the behavior (on a desktop device)

Go to 'reports'.
Click on a service body with data.
Change the window size
Note the data table expands all rows.

Expected behavior
Data table shouldn't expand unless you click a row.
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Add any other context about the problem here.

reported by @jbraswell

This will be solved with the fix mentioned in #1034 (4.3.5).  Simply not using Tabulator subtables which has a number of quirky rendering issues.  We cannot upgrade to 6.x right now because we aren't transpiling javascript (yet).  5.x added this requirement.


fix: toggling override status

Hey @joeldenning 👋
First, thanks a lot for this package!
It's really helping us to develop without having to spin up several MFEs. 🙇
There's only one issue I came across when trying to disable/apply an override.
Essentially, when disabling an override it is not falling back to the default value.
After debugging it, I've found that the culprit is this condition due to the order of evaluation of the last condition: !disabledOverrides.indexOf(moduleName) >= 0 -> !(disabledOverrides.indexOf(moduleName) >= 0).
Cheers,

Released in https://github.com/joeldenning/import-map-overrides/releases/tag/v1.15.3

thanks a lot @joeldenning !


Make section/subsection names clickable

A common default for tools like mdbook is to make section/subsection names clickable so users can copy/paste specific reference links very easily. So I think it would be nice if Verso had this option, probably enabled by default, or simply always enabled.

Thanks, this is indeed very important. It should also apply to docs, technical terms, and the other cross-reference-able items.


Find a proper layout for UpupUploader

we need to make a new layout for those 3 component the upload, gdrive and oneDrive components, maybe we put the buttons side by side and increase the padding between them !

@arijhajji-1 also make sure to bring back the old style for the 1st component, like this:


MASM test runner

Idea
Add support to doctest for MASM code
Rationale
Increase test coverage, by making stupidly easy to write unit tests
Proposal
I would imitate the doctests from languages like rust/python, something like:
#! Validates that a non fungible asset is well formed. Panics if the asset is not well formed.
#!
#! ```test
#! push.<IP_ADDRESS> exec.validate_non_fungible_asset
#! > FailedAssertion { err_code: 131128 }
#! ```
#!
#! Stack: [ASSET]
#! Outputs: [ASSET]
#!
#! ASSET is the asset to validate.
export.validate_non_fungible_asset
    # assert that ASSET[1] is a valid account id
    dup.2 exec.account::validate_id
    # => [ASSET]

    # assert that ASSET[1] is a fungible faucet
    dup.2 exec.account::is_non_fungible_faucet assert.err=ERR_NON_FUNGIBLE_ASSET_FORMAT_POSITION_ONE_MUST_FUNGIBLE
    # => [ASSET]

    # assert the fungible bit is set to 0
    dup u32split swap drop
    push.FUNGIBLE_BITMASK_U32 u32and assertz.err=ERR_NON_FUNGIBLE_ASSET_HIGH_BIT_SET
    # => [ASSET]
end

Another approach is to add test.<name> ... end.
Test execution would be as simple as parsing the code and calling a method in the module to collect/run the tests.

The approach above is intentionally simple. There tons of things that could be done around testing. And IMO anything fancier should be discussed as another issue. Here I'm trying to proposal the minimum that would quickly improve productivity when testing.


Adds solution for <IP_ADDRESS> Exercise 2

It's a bit lengthy, but I think it answers the question with only the tools provided to this point in the book. Certainly demonstrates the exploratory nature of this chapter, but the question is much better suited to regression.

Thanks. I don't think it needs the caveats about regression beforehand. The data viz should be sufficient to answer this question for these purposes. Rereading it, I'm not sure why I was confused about it. Can you remove the stuff on regression and then add more explanation around the data viz?

access


provide a handler for double click

There should be a way to declare that a double click action has occured so a controller can take some interaction based on it.

How is this generic double click handler differ from the HTML Mouse event?

you mean ondblclick?  I suppose we can use ng-dblClick.  The one problem though is, by default it would not send the model + ID of the items?  So it would be up to the author to pull this information themselves vs. have an even that publishes the table ID, the row ID and the row model.

The user already has the ability to add ng-dblClick to the row template, what are we solving by wrapping this and pushing this information up higher?

so if you add ng-dblClick how easy is it for you to get the row, model representing the row etc?  This is often the information you would need.  Think about edit on double click.
if you have ng-dblClick="callFunction()" there will not be any arguments passed.  So the user is left to set all this up in their row.  Would it not be cleaner to have this emitted with all the parameters one would logically need?

If you needed the model in the function then it would be passed. For editing you additionally need the event so you know what element is being edited if you are swapping out components,

I may have missed your point about the row model, if you were referring to the location of the attribute being changes, such as the name field row.name.
If that is the case then all I see an event being able to do it activate an editable-cell directive. Without any additional parameters the directive would be able to know the model being modified in a simple edit case by running the uncompiled cell HTML through $interpolate

For now we'll go with ng-dbl-click and see how it works out.  This may be reopened in the future if it proves insufficient.


latest.datasette.io is no longer updating

https://latest.datasette.io/-/versions is stuck on 0.35.

I can switch over to deploying that using Cloud Run. Unfortunately if I move away from Zeit Now v1 (since it's no longer supported and might stop working) I don't think I'll be able to deploy a permanent URL for every commit hash that I push any more, which is a real shame.

I'd like to still provide https://v0-35.datasette.io/ URLs for every named release, but I'm not sure how to best automate the provisioning of those subdomains.
For the moment I'm going to focus on getting latest.datasette.io working again, using Cloud Run.

I'm going to do this using GitHub Actions and the recipe from https://simonwillison.net/2020/Jan/21/github-actions-cloud-run/
First step: deploying manually using this:
datasette publish cloudrun fixtures.db \
    -m fixtures.json \
    --branch=7656fd64d8b6a32ebc34d89c1b8711cc5ea240f7 \
    --version-note=7656fd64d8b6a32ebc34d89c1b8711cc5ea240f7 \
    --extra-options="--config template_debug:1" \
    --service=datasette-latest

That's live at https://datasette-latest-j7hipcg4aq-uc.a.run.app/

I need to verify datasette.io with Google. These instructions look good: https://cloud.google.com/endpoints/docs/openapi/verify-domain-name

I tried running this:
$ now dns add datasette.io '@' TXT google-site-verification=wHw15S1fkNOMzk42PEVK6XLnSG9qEfyq6paO8_G4IVU

That worked:

Now add the service mapping in Cloud Run: https://console.cloud.google.com/run/domains?project=datasette-222320

... and set up the CNAME record:
$ now dns add datasette.io latest CNAME ghs.googlehosted.com.

Removed the conflicting record with:
 $ now dns rm rec_e4c36ae94cf0a2b7b1781329

Then:
$ now dns add datasette.io latest CNAME ghs.googlehosted.com.
> Success! DNS record for domain datasette.io (rec_5b8855344da0be1861c4d55b) created under simonw [10s]

Could take a while for the certificate to be issued:

Now following steps in https://simonwillison.net/2020/Jan/21/github-actions-cloud-run/ - I've added the GCP_SA_EMAIL and GCP_SA_KEY secrets to this repository: https://github.com/simonw/datasette/settings/secrets

https://latest.datasette.io/-/versions is now serving from Cloud Run.

It worked! After that push https://latest.datasette.io/-/versions updated to show 90015b26895fd2bd29676bc375f096102b0587ed as the version note.


Not Working Anymore :(

Regards!

Excuse me, I cannot understand your claim at all.
Please describe an issue you have in detail.

I will close this issue because there is no response.


Why is epanet_export.h now #included in epanet2.h in the latest merge of dev

It seems like one is now required to #define NO_GENX in their calling program to avoid having to link in the epanet-output library. Was this an oversight?

No it’s not an oversight. And it has nothing to do with linking to the output library. It is how cmake generates an export library. It’s a replacement for the antiquated def file approach we have been using. The export library is used to link with the EPANET.dll. Anyone who wants to link with the dll will find it useful. I use to build the python wrappers.
Define NO_GENX in your build script and the export headers will be ignored.

What build script are you talking about? This type of change without informing developers of what you are doing is very frustrating. 😥

The changes were made in a public repo and contributed in a reviewed PR that other developers were welcome to comment on at any point in the process. If you don’t like it just Define NO_GENX in your build setup.

Is the build script you refer to CMakeLists.txt? If so, how does one define NO_GENX in it? If someone is going to use the API in their 3rd party app it would fail to compile because they don't know they have to define NO_GENX somewhere. Why are you making the API header file dependent on what's in a build script. I just don't get it.

How do you build EPANET?

I understand there are shortcomings to this approach. Why don’t you do something constructive and open an issue and offer workable solutions. Be aware that building the python packages puts constraints on the build process that you aren’t taking into consideration.

What do you mean by it is a replacement for the antiquated def file approach? If I don't use NO_GENX I can ignore the def file?

i always  can compile epanet in windows by visual studio, but now i cant compile with it :(

The project made the decision to standardize on CMake three years ago in Issue #38.
I’m willing to bet that the developers posting here don’t use it.

always compile a code on different platforms requires a bit of additional configuration. This is not a worry.
:)

@michaeltryby regarding the DEF file you mentioned. Is the new build equivalent to the one built by the win script with the DEF file?
Maybe it was better to have the NO_GENX by default and not the other way around. This would help with backward compatibility.

@eladsel there are three different approaches for linking in Visual Studio. Def files, export libraries, and another I can’t recall. It’s a technical subject best left to the Visual Studio documentation.

how to #define NO_GENX ? im use fedora but cant compile by cmake

You can see from the badge that cmake is building on Travis running Ubuntu Linux. So what exactly are you doing?

ok i can do it
git clone https://github.com/OpenWaterAnalytics/EPANET.git cd EPANET/ cmake CMakeLists.txt   make cd bin/ ./runepanet
:)

how to clean after cmake and  again run cmake

You can see from the Travis build script that it creates a folder to contain the files that cmake generates. Then If you want to regenerate the build system you can just delete the folder. This is the recommended approach.

I finally figured out what the deal is with epanet_export.h. It allows the DLLEXPORT modifer on the API functions to define either an export library, as when the DLL is being built, or as an import library when the DLL is used by an app. In the latter case it eliminates the need to use a DEF file (which with almost 200 API functions would be a pain to create). The CMakeLists.txt file tells epanet_export.h to use the DLLEXPORT symbol in export mode while the default is to define it for import mode. When you want to reference epanet.dll functions in your own app, you need to #include epanet2.h in your file as usual, but also make sure that epanet_export.h is in the same folder with epanet2.h. I found this to be a useful reference on  linking and using DLL's.

Yes that is what it does, however, your original criticism is still valid especially for developers not using cmake.

Can we eliminate the need for epanet_export.h by modifying the top of epanet2.h to look as follows:
  // --- define EPANET_API
  #ifndef EPANET_API
    #ifdef WINDOWS
      #ifdef EPANET_EXPORTS
        #ifdef __cplusplus
        #define EPANET_API __declspec(dllexport)
        #else
        #define EPANET_API __declspec(dllexport) __stdcall
        #endif // __cplusplus
      #else
        #ifdef __cplusplus
        #define EPANET_API __declspec(dllimport)
        #else
        #define EPANET_API __declspec(dllimport) __stdcall
        #endif // __cplusplus
      #endif  //EPANET_EXPORTS
    #elif defined(CYGWIN)
      #define EPANET_API __stdcall
    #else
      #define EPANET_API
    #endif  //WINDOWS
  #endif  //EPANET_API

and in CMakeLists.txt add the following under IF (MSVC):
add_definitions(-D EPANET_EXPORTS)
and delete the include(GenerateExportHeader) section.
People not using cmake will have to add the EPANET_EXPORTS preprocessor definition either to their command line or through the Project Properties dialog if using Visual Studio. Developers using the DLL as an import library don't have to do anything special other than #include epanet2.h and link with epanet.lib.
Note that I replaced the DLLEXPORT symbol with EPANET_API which I think is more descriptive (since it serves for both export and import). Of course this means that one would have to do a global Find and Replace on DLLEXPORT in both epanet2.h and epanet2.c (or not -- replacing DLLEXPORT is just a suggestion).

@LRossman I use the DEF which need to be updated only when new functions are added (the DEF file is in the \win_build\WinSDK\ directory). However, I would be happy to give it up if there was a simple way to do so. I have tried compiling with the epanet_export.h file but that didn't work with VB and VBA. Any additional flag needed in cl.exe command line?

@eladsal I think (not sure) that the epanet_export.h file is missing the __stdcall qualifier when it defines DLLEXPORT and therefore the compiled DLL won't work with VB. So, with no guarantees, here's what I suggest:

Add -DNO_GENX to your cl.exe command line. That should (I think) force the compiler to use the old #defines in epanet2.h to define DLLEXPORT with __stdcall.

To avoid having to use a DEF file, include the decorated name of the DLL functions in your epanet2.bas and epanet2.vb files, using an alias clause in the function declaration like so:

Declare Function ENgetversion Lib "epanet2.dll" Alias "_ENgetversion@4" (ByRef Value As Int32) As Int32
So you're essentially just embedding the DEF file information directly into the VB declaration modules.

If you need to see what the decorated alias names are for the DLL functions you can add a /MAP option to your cl command that will generate an epanet2.map file where the names will be listed.

@LRossman CMake generates epanet-exports differently depending on what system the code is being built on. What you are suggesting will work on Windows but may not work on Linux.

@michaeltryby I assume you are referring to my comment about eliminating epanet_export.h. I believe that my suggestions for modifying the cmake script only apply to those portions that are Windows-specific. I will try to test my alternative on both a Windows and Linux build and report back.
Plus, as noted in my response to @eladsal, I think that the #defines in epanet_export.h don't distinguish between a C and C++ build, and for the former case fail to add on the __stdcall qualifier to the defintion of DLLEXPORT.

@LRossman thanks!
The win script is here. I already use the /D NO_GENX  and /MAP flags. Will try the VB declare option but it is not elegant :)

@LRossman I think I've got a better solution.  With NO_GENX as it stands now epanet_export.h is opt out. You have to tell the compiler you don't want to use it. I have an alternate setup working where it is opt in rather than opt out. So the compiler will include epanet_exports.h only when WITH_GENX is defined. Thus epanet-export.h is not required unless you want it, and backwards compatibility is preserved.
I think this is simpler than what you are proposing.

The goal of my PR was to get the python packages to build while providing backward compatibility for VB.

@LRossman another thing to consider is that we don’t need a single dll to be all things to all people. It is ok for there to be different EPANET library builds for different purposes. It’s not essential to moving things forward.

@michaeltryby  i work in the web with RestFullAPI  but in win  we need same standard ,
i think we can create Multi Dll with spatial Category such as Quality, Hydraulic, ....
it is possible?

@milad-ghiami reorganizing EPANET into several dlls is a different idea. I was talking about building the dll one way to link with an export library and another way to link using a def file.

If the new default is to use the old macros at the top of epanet2.h to define DLLEXPORT then they need to be modified so that a VB (or C#, Pascal, etc.) - compatible DLL can be created without the need to deploy a DEF file. Here is what it should look like:
 // --- define DLLEXPORT
  #ifndef DLLEXPORT
    #ifdef WINDOWS
      #ifdef EPANET_EXPORTS
      #define DLLEXPORT __declspec(dllexport) __stdcall
      #else
      #define DLLEXPORT __declspec(dllimport) __stdcall
      #endif
    #elif defined(CYGWIN)
      #define DLLEXPORT __stdcall
    #else
      #define DLLEXPORT
    #endif
  #endif

And in addition, as mentioned previously, the following needs to be added to CMakeLists.txt under the  IF (MSVC) section: add_definitions(-D EPANET_EXPORTS).
I tested the DLL resulting from this mod on both a C and a C# custom app without referencing a DEF file and both worked just fine. (I assume that since it worked for C# it would also work for VB.net). If I can get an OK to proceed I'd like to commit these changes.

But then wouldn't -D EPANET_EXPORTS and -D WITH_GENX duplicate eachother and conflict?

@LRossman Yes it is. I merged it yesterday. See PR #274.

It seems like generate exports would do everything you want to do, if there was a way to add __stdcall to the macro definition.

Looks like we can add /Gz compiler flag to add __stdcall to all declared functions.
https://msdn.microsoft.com/en-us/library/zxk0tw93.aspx

Wouldn't using /Gz make all functions in the entire DLL stdcall -- that's not needed.
Also I'm now totally confused about how you want to treat the #include epanet_export.h in epanet2.h. I thought you agreed to skip over it by default.
Since we seem to be going around in circles on this I'm opting out of this discussion.

@LRossman I agreed to ignore epanet_export.h by default so that it wouldn't interfere with other build systems. Why would I generate it and then ignore it in a cmake build? How does that make sense?
I have stated clearly what my objectives where - To get the python wrappers to build while providing backwards compatibility for Elad's VB build. That is what PR #274 accomplishes. Done.
If you want to eliminate the def file open an issue.


Deep link not created for IOU's preview in the workspace chat if paid by business account

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number:
Reproducible in staging?: Needs reproduction
Reproducible in production?: Needs reproduction
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @quinthar
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1714277084448909
Action Performed:

User A submits an IOU to User B
User B pays the IOU with a business account
For User A the report is moved to new workspace chat

Expected Result:
The link generated in the chat should be deep linked to that IOU's preview in the workspace chat.
Actual Result:
The link generally links to the workspace chat
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[X] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

View all open jobs on GitHub

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

I'm having trouble recreating this, so going to see if QA can test this 👍

This is not overdue — waiting for this to be tested by QA before we apply a project in case it cannot be recreated

Still has not been tested ^^^

Not applying to a project until this is tested 👍

Not overdue Melvin — waiting for it to be tested!

Waiting for it to be tested before applying to a project!

QA team is not able to confirm if this issue is still reproducible during KI retests as it requires definitive business account. We are only having test accounts. This issue should be retested internally

Thanks for the context @mvtglobally! Unfortunately, I also only have a test account as well, so this is going to be tricky. Because there is not a way to definitively confirm this is still happening, I am going to close this and if the issue occurs again, we can get it addressed 👍


CCI org list falsely displays scratch orgs as persistent orgs

When executing the cci org connect --sandbox  is used, cci org list falsely displays sandbox and scratch orgs as persistent orgs.

Sandboxes are persistent orgs; the issue is that we aren't recognizing scratch orgs and setting the org config's scratch setting to true.


Load model config file i to dataclass

Would document the model format and provide some validation

Update README with references new dataclasses

closed by updates in 0.3.0


graphics.vertex_instructions.Line - object has no attribute 'dash_lenght'

The Line is supposed to have a dash_length attribute, but an attempt to use it throws an error. That is while using python 2.7 and kivy 1.9.2 dev.
Code:
#!/usr/bin/env python2
# -*- coding: utf-8 -*-
from kivy.app import App
from kivy.lang import Builder

gui = '''
FloatLayout:
    canvas:
        Line:
            points: 100, 100, 200, 200
            dash_offset: 10
            dash_lenght: 10
            width: 1
'''

class Test(App):
    def build(self):
        return Builder.load_string(gui)

Test().run()

Error log:
[INFO   ] [Logger      ] Record log in /home/stefan/.kivy/logs/kivy_16-06-17_32.txt
[INFO   ] [Kivy        ] v1.9.2-dev0
[INFO   ] [Python      ] v2.7.6 (default, Jun 22 2015, 17:58:13)
[GCC 4.8.2]
[INFO   ] [Factory     ] 193 symbols loaded
[INFO   ] [Image       ] Providers: img_tex, img_dds, img_gif, img_sdl2, img_pil (img_ffpyplayer ignored)
[INFO   ] [OSC         ] using <multiprocessing> for socket
[INFO   ] [Window      ] Provider: sdl2(['window_egl_rpi'] ignored)
[INFO   ] [GL          ] OpenGL version <3.0 Mesa 10.1.3>
[INFO   ] [GL          ] OpenGL vendor <Intel Open Source Technology Center>
[INFO   ] [GL          ] OpenGL renderer <Mesa DRI Intel(R) Sandybridge Mobile >
[INFO   ] [GL          ] OpenGL parsed version: 3, 0
[INFO   ] [GL          ] Shading version <1.30>
[INFO   ] [GL          ] Texture max size <8192>
[INFO   ] [GL          ] Texture max units <16>
[INFO   ] [Window      ] auto add sdl2 input provider
[INFO   ] [Window      ] virtual keyboard not allowed, single mode, not docked
 Traceback (most recent call last):
   File "main.py", line 22, in <module>
     Test().run()
   File "/usr/local/lib/python2.7/dist-packages/kivy/app.py", line 802, in run
     root = self.build()
   File "main.py", line 19, in build
     return Builder.load_string(gui)
   File "/usr/local/lib/python2.7/dist-packages/kivy/lang/builder.py", line 379, in load_string
     self._apply_rule(widget, parser.root, parser.root)
   File "/usr/local/lib/python2.7/dist-packages/kivy/lang/builder.py", line 502, in _apply_rule
     rule.canvas_root, rootrule)
   File "/usr/local/lib/python2.7/dist-packages/kivy/lang/builder.py", line 827, in _build_canvas
     '{}: {}'.format(e.__class__.__name__, e), cause=tb)
 kivy.lang.builder.BuilderException: Parser: File "<inline>", line 7:
 ...
       5:            points: 100, 100, 200, 200
       6:            dash_offset: 10
 >>    7:            dash_lenght: 10
       8:            width: 1
 ...
 AttributeError: 'kivy.graphics.vertex_instructions.Line' object has no attribute 'dash_lenght'
   File "/usr/local/lib/python2.7/dist-packages/kivy/lang/builder.py", line 822, in _build_canvas
     setattr(instr, key, value)

Your example has a typo; dash_lenght


Typo in path

The example config file uses a path with \ExampleFile\ and \ExampleFiles\. In the source it's only \ExampleFiles\ so I made that consistent everywhere.

Will be fixed in another branch with global repo refactoring (#640). Thanks for contribution.
We will release it soon, so your changes will not be lost


Allow for filter bypass for cellua achievement

I fix your achievements pt.1

pull request now

very important

ok I'll do regex

frog


Update BSI to latest version

Bootstrap Italia should be upgraded to the last version (1.3.10).

Fixed by #101, closing.


http context never done

Codecov Report
Patch coverage: 60.00% and project coverage change: +0.06 :tada:

Comparison is base (ed63617) 78.80% compared to head (d87cec1) 78.87%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2602      +/-   ##
==========================================
+ Coverage   78.80%   78.87%   +0.06%
==========================================
  Files         631      629       -2
  Lines       51618    51507     -111
==========================================
- Hits        40680    40626      -54
+ Misses       8928     8880      -48
+ Partials     2010     2001       -9

Flag
Coverage Δ

go-1.15-386
78.81% <60.00%> (-0.02%)
:arrow_down:

go-1.15-amd64
78.80% <60.00%> (-0.03%)
:arrow_down:

go-1.16-386
78.82% <60.00%> (+0.01%)
:arrow_up:

go-1.16-amd64
78.83% <60.00%> (+0.01%)
:arrow_up:

go-1.17-386
78.83% <60.00%> (-0.01%)
:arrow_down:

go-1.17-amd64
78.83% <60.00%> (-0.01%)
:arrow_down:

go-1.18-386
?

go-1.18-amd64
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

net/ghttp/ghttp_request_param_ctx.go
88.23% <60.00%> (-11.77%)
:arrow_down:

... and 2 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


IComparer not supported for OrderBy?

How can the OrderBy overloads that take an IComparer actually be used, since the calls generated expect the types passed to the comparer match the types of the dynamic fields created by the string expression?
Is there any way to have an IComparer<object> be used?

Hello @NetMage,
The IComparer is supported, a unit test can be found here:
https://github.com/zzzprojects/System.Linq.Dynamic.Core/blob/master/test/System.Linq.Dynamic.Core.Tests/QueryableTests.OrderBy.cs#L10
(IComparer<object> is compatible with IComparer)

Except that test only works if the string for the field is actually the name of a string field. Try again with an integer field and your passed in IComparer object will be the wrong type.

Hello @NetMage,
Can you check this test:
https://github.com/zzzprojects/System.Linq.Dynamic.Core/blob/stef-add-more-OrderByIComparer-unittests/test/System.Linq.Dynamic.Core.Tests/QueryableTests.OrderBy.cs#L40
And provide some insights from your side?

I have the same problem,
I have some code similar to the link you sent (QueryableTests.OrderBy.cs#L10)
For information I use .NET 6, EF Core 6.0.3, and a PostgresSQL database.
Here is my code:
query.OrderBy($"{columnName} {(sorting.Descendant ? "desc" : "asc")}", StringComparer.OrdinalIgnoreCase)

The error in visual studio when I run the code
The LINQ expression 'DbSet<Reference>()
    .Include(_ => _.Warehouse)
    .Include(_ => _.Departments)
    .Include(_ => _.Nature)
    .OrderBy(
        keySelector : => .Nature.Description,
        compare : __p_0)'
could not be translated. Either rewrite the query in a form that can be translated,
or explicitly switch to client evaluation by inserting
 a call to 'AsEnumerable', 'AsAsyncEnumerable', 'ToList' or 'ToListAsync'.
See https://go.microsoft.com/fwlink/?linkid=2101038 for more information.

Can you please help me?

@NetMage Did you have time to look at my new / updated UnitTests ?
@maxime-ducoroy Maybe it's related to Postgress database? Did you try SQL ? Or can you provide a full working example project?

OrderBy accepts a IComparer but it have to impement both IComparer and IComparer. It would look something like,
public class CustomComparer : IComparer<object>, IComparer
	{
		public int Compare(object x, object y)
		{
			// Compare here
		}
	}

@i-am-jyotirmaya
I understand your issue.
I've changed the code so that you can also provide an IComparer<T> to the order extension method:
 var orderByDynamic = qry.OrderBy("Income", new ObjectComparer()).ToArray();

https://github.com/zzzprojects/System.Linq.Dynamic.Core/pull/584