Initial implementation of "v2" controller for ambient

TODO:

Events are not the same. This is generally fine but makes it really hard to test due to debouncing.
Fetch() is scary, can we make it less so?
Is DiscoveryFilter handling needed?
Can we have depdency per-type instead of per-instance
Syncing discussions

Please provide a description of this PR:

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/test all

/test all

@howardjohn: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
6f88ec86a553aef344a9189349a13bd26d578cc9
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
6f88ec86a553aef344a9189349a13bd26d578cc9
link
true
/test release-notes

lint_istio
6f88ec86a553aef344a9189349a13bd26d578cc9
link
true
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
6f88ec86a553aef344a9189349a13bd26d578cc9
link
true
/test release-notes

lint_istio
6f88ec86a553aef344a9189349a13bd26d578cc9
link
true
/test lint

unit-tests-arm64_istio
6f88ec86a553aef344a9189349a13bd26d578cc9
link
true
/test unit-tests-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
6f88ec86a553aef344a9189349a13bd26d578cc9
link
true
/test release-notes

lint_istio
6f88ec86a553aef344a9189349a13bd26d578cc9
link
true
/test lint

unit-tests-arm64_istio
6f88ec86a553aef344a9189349a13bd26d578cc9
link
true
/test unit-tests-arm64

unit-tests_istio
6f88ec86a553aef344a9189349a13bd26d578cc9
link
true
/test unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
6f88ec86a553aef344a9189349a13bd26d578cc9
link
true
/test release-notes

lint_istio
6f88ec86a553aef344a9189349a13bd26d578cc9
link
true
/test lint

unit-tests-arm64_istio
6f88ec86a553aef344a9189349a13bd26d578cc9
link
true
/test unit-tests-arm64

unit-tests_istio
6f88ec86a553aef344a9189349a13bd26d578cc9
link
true
/test unit-tests

gencheck_istio
6f88ec86a553aef344a9189349a13bd26d578cc9
link
true
/test gencheck

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


[Enhancement] Drop ms-peak-picker dependency

Unfortunately, ms-peak-picker ends up being a difficult dependency, because it requires development tools for the C++ libraries to install. This may be too much for some users of Diadem to do when installing it for the first time.

its removed in the breaker release


How to change tax value?

my country using 0.18 tax. but laravelshopping cart used presumably 0.21.  i need to change tax value but there are not config file.
thanx for reply.

You can write php artisan vendor:publish.
You will find cart.php file into config folder

I have the same issue as kvlknctk but when ir run "php artisan vendor:publish" i get
[ErrorException]
The use statement with non-compound name 'Cart' has no effect

@kvlknctk you have a /vendor/gloudemans/shoppingcart/src folder, inside of it is there a "cart.php" where you can change tax value and many oders things!

We don't chnage values under vendor folder. If you update your package all values will be rest.

so what i have to do?

php artisan vendor:publish should have worked. I am already using it and vendor:publish worked.

I'm gettin this error...

Even when i do php artisan migrate

Did you setup Cart alias into config/app.php?
Maybe Cart class not found.

Yes
'Cart' => Gloudemans\Shoppingcart\Facades\Cart::class,

Maybe i should change for ?
'Cart' => Gloudemans\Shoppingcart\Src\Facades\Cart::class

Well, it seems you did great 👍
Look, when I wrote vendor:publish.

Look, if i search for Cart.php this is what i found.

Maybe i am including the alias with a wrong path?

No, Src is a folder path, but your class has NAMESPACE namespace Gloudemans\Shoppingcart\Facades so you have to call class by Namespace not folder source.

OK i did it,

i was adding "use Cart;" in a Controller, i don't know why, maybe I pasted there accidentally! Thanks!

Good, you have figured it out 👍

Can you help me with this? https://github.com/Crinsane/LaravelShoppingcart/issues/229

I want the admin user to be able to change the sales tax. This is what I added cart.php config:
'tax' => \DB::table('business_info')->select('sales_tax')->first(),
When refreshing the page to test it I get an error:
Class 'DB' not found
Is there a better route to take in handling this type of function?

You can't access the db in the configuration. I guess right now you best option is to set the config in you AppServiceProvider or something at runtime with Config::set()

Thank you.

'tax' => \Illuminate\Support\Facades\DB::table('products')->value('vat'),

You can write php artisan vendor:publish.
You will find cart.php file into config folder

Thanks bhai jan


Improve migration 110

Use Postgres CTE to update iteration numbers
When explaining the updae before it looks like this:
postgres@172:postgres> explain UPDATE iterations iter SET number = seq.row_number
                       FROM (
                           SELECT id, space_id, created_at, row_number() OVER (PARTITION BY space_id ORDER BY created_at ASC)
                           FROM iterations
                       ) AS seq
                       WHERE iter.space_id = seq.space_id AND iter.id = seq.id;
+-----------------------------------------------------------------------------------------+
| QUERY PLAN                                                                              |
|-----------------------------------------------------------------------------------------|
| Update on iterations iter  (cost=2.06..2.16 rows=1 width=263)                           |
|   ->  Merge Join  (cost=2.06..2.16 rows=1 width=263)                                    |
|         Merge Cond: (seq.space_id = iter.space_id)                                      |
|         Join Filter: (iter.id = seq.id)                                                 |
|         ->  Subquery Scan on seq  (cost=1.03..1.09 rows=2 width=112)                    |
|               ->  WindowAgg  (cost=1.03..1.07 rows=2 width=48)                          |
|                     ->  Sort  (cost=1.03..1.03 rows=2 width=40)                         |
|                           Sort Key: iterations.space_id, iterations.created_at          |
|                           ->  Seq Scan on iterations  (cost=0.00..1.02 rows=2 width=40) |
|         ->  Sort  (cost=1.03..1.03 rows=2 width=187)                                    |
|               Sort Key: iter.space_id                                                   |
|               ->  Seq Scan on iterations iter  (cost=0.00..1.02 rows=2 width=187)       |
+-----------------------------------------------------------------------------------------+

Now the update looks better (notice absence of nested seq scans):
postgres@172:postgres> explain WITH iteration_numbers AS (
                           SELECT *, ROW_NUMBER() OVER(PARTITION BY space_id ORDER BY created_at ASC) AS num
                           FROM iterations
                       )
                       UPDATE iterations SET number = (SELECT num FROM iteration_numbers WHERE iteration_numbers.id = iterations.id);
+---------------------------------------------------------------------------------------------+
| QUERY PLAN                                                                                |
|---------------------------------------------------------------------------------------------|
| Update on iterations  (cost=1.07..2.18 rows=2 width=191)                                    |
|   CTE iteration_numbers                                                                     |
|     ->  WindowAgg  (cost=1.03..1.07 rows=2 width=193)                                       |
|           ->  Sort  (cost=1.03..1.03 rows=2 width=185)                                      |
|                 Sort Key: iterations_1.space_id, iterations_1.created_at                    |
|                 ->  Seq Scan on iterations iterations_1  (cost=0.00..1.02 rows=2 width=185) |
|   ->  Seq Scan on iterations  (cost=0.00..1.11 rows=2 width=191)                            |
|         SubPlan 2                                                                           |
|           ->  CTE Scan on iteration_numbers  (cost=0.00..0.04 rows=1 width=8)               |
|                 Filter: (id = iterations.id)                                                |
+---------------------------------------------------------------------------------------------+

Ike Plugins (test-keeper)
Thank you @kwk for this contribution!

It appears that no tests have been added or updated in this PR.
Automated tests give us confidence in shipping reliable software. Please add some as part of this change.
If you are an admin or the reviewer of this PR and you are sure that no test is needed then you can use the command /ok-without-tests as a comment to make the status green.
For more information please head over to official documentation. You can find there how to configure the plugin.


GOBBLIN-1225 Multistage Generic Connector for HTTP Protocol and JSON Format

Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA

[X] My PR addresses the following Gobblin JIRA issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"

https://issues.apache.org/jira/browse/GOBBLIN-1225

Description

[X] Here are some details about my PR, including screenshots (if applicable):

Many HTTP data sources, including OData and GraphQL based data sources, use a set of common HTTP request methods,
but their parameters can vary significantly case by case. The Gobblin ecosystem has multiple connectors that were
built to suite those needs, for example, the Salesforce connector, the Google Search Console connector, etc.
Multistage connector framework is a paradigm that makes connectors more generic and more reusable. We have used this framework to address the huge variety challenge in data integration with external data sources.
HTTP data sources are the top beneficiary of this framework, including Rest API, OData, and SOAP based data sources. S3 and GCS (Google Cloud Storage) data sources can also benefit from it in small data volumes that are less than 10TB, without using SDK.
We have also verified the HTTP Multistage connector can greatly simplify data ingestion from Salesforce.com. However, this PR doesn't included the necessary component, CSV Extractor, yet.
This PR includes following functionalities:
- This PR contains a separate multistage module that works with HTTP data sources
- It supports HTTP GET, PUT, POST, and DELETE operations
- It supports nested JSON format
- It supports Rest API calls and its derived OData service
- It supports following ways of pagination
○ By offset and page size
○ By page number
○ By a total record count
○ By signal of an empty response
○ By next page URL
○ By a cursor or next page locator
- It supports session state control as a mechanism of pagination or asynchronous requests
- It supports pulling files from GCS or S3 via HTTP requests
- It supports field project, including nested field projection, based on a given schema
Tests

[X] My PR adds the following unit tests OR does not need testing for this extremely good reason:

All 113 unit tests were successful.
Commits

[X] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50   ##characters
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@5be1702). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff            @@
##             master   #3198   +/-   ##
========================================
  Coverage          ?   8.87%
  Complexity        ?    1737
========================================
  Files             ?    2054
  Lines             ?   80050
  Branches          ?    9085
========================================
  Hits              ?    7108
  Misses            ?   72247
  Partials          ?     695

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5be1702...0250bc5. Read the comment docs.

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@5be1702). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff            @@
##             master   #3198   +/-   ##
========================================
  Coverage          ?   8.87%
  Complexity        ?    1737
========================================
  Files             ?    2054
  Lines             ?   80050
  Branches          ?    9085
========================================
  Hits              ?    7108
  Misses            ?   72247
  Partials          ?     695

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5be1702...0250bc5. Read the comment docs.


Add PWA example

PWA by default for native desktop support. No Electron required.

https://whatpwacando.today/


grid

Before version 1:

[ ] add tests

[ ] clean up test

[ ] cleanup and refactor parts... some parts are messy
[x] menu for filter (so someone can choose another filter)
[x] menu to clear all groups/expand all/collapse all
[x] filter dialog
[x] menu to copy cell value and paste (into selected rows)

After version:
...

Need to refactor datasource part, rip it out of grid widget

[ ] make datasource into own package


New package: Everything.Cli version <IP_ADDRESS>

[x] Have you signed the Contributor License Agreement?
[x] Have you checked that there aren't other open pull requests for the same manifest update/change?
[x] This PR only modifies one (1) manifest
[x] Have you validated your manifest locally with winget validate --manifest <path>?

[x] Does your manifest conform to the 1.5 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Everything search cli portable official.
Microsoft Reviewers: Open in CodeFlow

@microsoft-github-policy-service agree

Manual Validation ended with:

PS C:\Users\User\Desktop> C:\Users\User\AppData\Local\Microsoft\WinGet\Packages\voidtools.Everything.Cli__DefaultSource\es.exe Error 8: Everything IPC window not found. Please make sure Everything is running. PS C:\Users\User\Desktop>
Is voidtools.Everything a dependency?

Hi @1208nn,
It appears that voidtools.Everything is a dependency for this package.

Hi @stephengillie

It appears that voidtools.Everything is a dependency for this package.

Any versions of Everything installed could make this work, including Lite, Alpha and even portable.
I think considering voidtools.Everything as a dependency is not friendly for these users.

Hi @1208nn,
The difficulty is for new users, who might not have heard of voidtools and do not have any version of Everything installed. We're working on a kind of wildcard system for dependencies, which might allow any .NET SDK to be selected, and could be a better solution for this situation. But for now, the path forward isn't clear.

Hi @stephengillie,
The dependency was added. So is the PR OK to be merged?

@wingetbot waivers Add Validation-Executable-Error


Expand Jobs Server Documentation

The Jobs server section should be expanded to include details like the following:

How to set up a Mattermost server as a worker
The circumstances where you'd need a worker server as opposed to using all servers as both application and workers

If you're interested in taking on this documentation request, let us know by commenting on the issue.  The documentation that needs to be updated is located here: https://docs.mattermost.com/administration/config-settings.html#jobs. The submitter of this issue may have additional links and content available.

If you're a new contributor take a look through the Technical Writing Handbook to learn more about our processes.

For technical advice or questions, please join our Developers community channel..

For stylistic, formatting, or other questions join the Documentation community channel.

We look forward to your contribution!


Setting ignore-unfixed no longer working with 0.0.9

Hello! 👋
We are using your wonderful action to scan for CVEs in our Docker images — thank you for hard work and contribution to open-source!
Sadly we noticed that there seems to be a regression in 0.0.9 with respect to ignore-unfixed.
In 0.0.8 setting ignore-unfixed: true correctly ignores CVEs that have no published fix version yet.
In 0.0.9 setting ignore-unfixed: true has no effect and we can see CVEs being failed on that have no published fix version.
For example:
========================================================================================
Total: 44 (HIGH: 40, CRITICAL: 4)

+----------------------+------------------+----------+---------------------------+---------------+--------------------------------------------------------------+
|       LIBRARY        | VULNERABILITY ID | SEVERITY |     INSTALLED VERSION     | FIXED VERSION |                            TITLE                             |
+----------------------+------------------+----------+---------------------------+---------------+--------------------------------------------------------------+
| curl                 | CVE-2020-8169    | HIGH     | 7.64.0-4+deb10u1          |               | libcurl: partial password                                    |
|                      |                  |          |                           |               | leak over DNS on HTTP redirect                               |
|                      |                  |          |                           |               | -->avd.aquasec.com/nvd/cve-2020-8169                         |
+                      +------------------+          +                           +---------------+--------------------------------------------------------------+

This is a scan result from 0.0.9 with ignore-unfixed: true on and we can clearly see a CVE for curl that does not yet have a fix version published.
Here is the action step config we were using:
      - name: Run Trivy vulnerability scanner
        uses: aquasecurity/trivy-action@master
        with:
          image-ref: "<docker image repo/tag here>"
          format: "table"
          exit-code: "1"
          ignore-unfixed: true
          severity: "CRITICAL,HIGH"

Changing from master to 0.0.8 after 0.0.9 was published fixed the issue:
      - name: Run Trivy vulnerability scanner
        uses<EMAIL_ADDRESS>        with:
          image-ref: "<docker image repo/tag here>"
          format: "table"
          exit-code: "1"
          ignore-unfixed: true
          severity: "CRITICAL,HIGH"

I'm so sorry, should have checed first but just seen you've published 0.0.10 and it has a fix for this!
This issue was related to https://github.com/aquasecurity/trivy-action/issues/28. Closing!
Thanks again for everything!

I'm so sorry, should have checked again before raising! Just seen you've published 0.0.10 and it has a fix for this! 😂 🤦
This issue was related to #28. Closing!
Thanks again for everything!

note that the version has been published as v0.0.10 instead of simply 0.0.10 as all the previous version this could cause quite a lot of confusion, I'd suggest to create a tag with 0.0.10 without deleting v0.0.10 as someone it might have used that already

I'm so sorry, should have checked again before raising! Just seen you've published 0.0.10 and it has a fix for this! 😂 🤦
This issue was related to #28. Closing!
Thanks again for everything!

note that the version has been published as v0.0.10 instead of simply 0.0.10 as all the previous version this could cause quite a lot of confusion, I'd suggest to create a tag with 0.0.10 without deleting v0.0.10 as someone it might have used that already

I'd also suggest to delete 0.0.9 and recreate it from master (without caring about the fact that is identical to 0.0.10), that would automatically fix issues for other people trying to checkout 0.0.9 which holds the bug in it


Update Golang requirements in PACKAGERS.md

Docker 1.12 now requires Go 1.6, so update the packagers.md accordingly
ping @tianon - I think this document needs more updates, but just fixing one thing I was aware of :D

LGTM 🐮

author LGTM. It's updated to 1.6 (not 1.6.2h as suggested by @tianon, so I think we're good to go for now


Fix default larrow rarrow

@parrt Let's leave larrow, rarrow in colors.py so users see they exist, but comment them out like this. The default None does not print any edge arrows.

thanks for all the help!


Fixed Typo

found the typo while playing the game....

Hey @amananand20, but they are indeed hoppy. We'll keep it in there. 😉


merge capi call limits

Docs Build status updates of commit baddf93:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

Advertising/shopping-content/TOC.yml
:white_check_mark:Succeeded

Advertising/shopping-content/release-notes.md
:white_check_mark:Succeeded

Advertising/shopping-content/request-method-limits.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


impl rust Collaboration and Remote API

Unimplemented:

BNRemoteFileDownload - Returns the c++ std::vector for the core API don't provide any way to free it.
BNCollaborationSnapshotDownloadSnapshotFile - Returns the c++ std::vector for the core API don't provide any way to free it.
BNRemoteRequest - Parameters are complex c++ types, and no direct way to manage it.
BNAnalysisMergeConflictGetPathItem - Implementation with downcast to u64 is unclear.
Remote::connect - Not fully implemented because it depends on enterprise and SecretsProvider.
Remote - Methods in python preemptively calls pull_files/pull_folders/pull_user_permissions/open, but C++ don't. Python was followed.
RemoteProject::upload_new_file - Ported from remotebrowser.cpp, what is not public.

It's probably better to leave Result<T, ()> for now, because it's very likely that an Error type will be implemented and it will be replaced byResult<T, BnError> .


Treat any non-200 from a mirror as a 503

In order to improve UX responses from the mirror should either return a 200 status code (found) or a 503 (service not available). This is because there are many URLs that the mirrors do not cache that are valid (for example, /search). In these cases whilst it is technically correct to return a 404 this is likely to confuse a user who would assume they have mis-typed the URL rather than, as is the case, hit the website during an outage. The user response we would like to encourage in this case is retrying in a little while once the site has returned.
To return 503s for non-200 responses we have changed the varnish configuration for fastly so that any response from a mirror which isn't a 200 has its status code set to 503.

looks fine to me i do wonder which 503 it will serve though.

Yeah, that's a good question. My assumption is that it will take the same backend response text (which in this case is the mirror error page) and only modify the status code.

@alexmuller that would be the case currently but what about when we are using s3?

I think in that case S3 has the error page set which we could specify to be our standard error and that would end up propagated all the way through.

Also think it looks fine and having the name of the backend has served to be extra useful!


compile-error without reason

I can't compile laf for some reason. The error-message is just
"collect2: error: ld returned 1 exit status". I am trying to compile laf with skia. I downloaded skia-m102 from here: Skia-m102 and chose the libstdc++-version, since I think g++ is the compiler used in my system. I compiled and installed cmake 3.27 by hand, before.
as you can see in the compiler-output, I extracted skia-m102 to ~/deps/skia and set-up all path correctly. Nevertheless compiling just stops without usefull error-message.
Please see full compiler-output on pastebin

ok, I got it to work: Turns out, I had to compile skia by hand, in addition. The pre-compiled versions don't seem to work on ubuntu 18.04. For this, I had to install the package libc++-10-dev in ubuntu. They contain the c++10-header-files. Also I had to type
export CPLUS_INCLUDE_PATH=/usr/lib/llvm-10/include/c++/v1
at the command line, so the build-system could actually make use of the c++10-header-files.
BTW, the build-system is called GN and is needs to be downloaded with:
curl -L -o gn.zip "https://chrome-infra-packages.appspot.com/dl/gn/gn/linux-amd64/+/latest"
inside the downloaded zip-file was just one file "gn". I made it executable
chmod ugo+x ./gn
and copied it to /usr/local/bin so the system could make use of it.


Add a "Help" screen

Add a help screen which displays information about how to use the emulator. This could include

The key bindings (Which can be found in the keyboard.js file)
Where to find ROMs

This could potentially be accessible via a clickable help icon which opens a modal, or an entirely separate page. Happy to discuss.

Hey @Taiters, just saw your issue. Would be interested in working on it. How did you want to approach this? Is the info. going to be really long, or short? I guess that would determine the use of a modal or separate page

Hey @arminderk. Thanks for taking a look!
I don't think there needs to be a huge amount of information on it. The main information it requires is the key bindings and possibly a link to a source of ROMs (Such as https://github.com/dmatlack/chip8/tree/master/roms)
Ideally the rest of the UI should be easy enough to use to avoid the need for explanations in the help page.

Hey @Taiters, I was thinking of using react-bootstrap to load the modal.  I thought that it may easier to incorporate bootstrap and modal.

Hey @arminderk, yeah using bootstrap sounds good.


Changed changeDetection to OnPush

... for

BigInputComponent
BigInputActionComponent

Also changed SharedModule import path.  The old one was  not working in my IDE (VS Code on Windows).

Thank you very much for your effort! There are couple of issues still...

failed build seems to be only caused by prettier check so you can try running npm run prettier locally to make the fix (also you try running npm run ci locally to try CI build if everything works out)

also there seems to be merge conflicts ? maybe you can squash all commits in your branch into one and rebase on top of master

please use standard-version commit message formatting as explained in CONTRIBUTING.md file
so in this case we would end up with feat(shared): use OnPush change detection strategy or something similar...

Also the import should work because of the path property in main tsconfig.json file with aliases and index.ts barrel in shard module. Could VS code settings be adjust to recognize that configuration? I work mostly with Intellij IDEA where it causes no issues or warnings.

I will try to address the issues tomorrow.  I get the same problem when running npm run ci locally.  Not sure what to do about that.  I wonder if it has something to do with my using Windows (8.1 x64).  Here is the log.  Any suggestions would be appreciated:
0 info it worked if it ends with ok
1 verbose cli [ 'C:\\Program Files\\nodejs\\node.exe',
1 verbose cli   'C:\\Program Files\\nodejs\\node_modules\\npm\\bin\\npm-cli.js',
1 verbose cli   'run',
1 verbose cli   'prettier:ci' ]
2 info using<EMAIL_ADDRESS>3 info using<EMAIL_ADDRESS>4 verbose run-script [ 'prettier:ci' ]
5 info lifecycle angular-ngrx-material-starter@6.0.0-rc.1~prettier:ci<EMAIL_ADDRESS>6 verbose lifecycle angular-ngrx-material-starter@6.0.0-rc.1~prettier:ci: unsafe-perm in lifecycle true
7 verbose lifecycle angular-ngrx-material-starter@6.0.0-rc.1~prettier:ci: PATH: C:\Program Files\nodejs\node_modules\npm\node_modules\npm-lifecycle\node-gyp-bin;D:\Users\<user_a>\Documents\Angular2Dev\angular-ngrx-material-starter\node_modules\.bin;D:\Users\<user_a>\bin;C:\Program Files\Git\mingw64\bin;C:\Program Files\Git\usr\local\bin;C:\Program Files\Git\usr\bin;C:\Program Files\Git\usr\bin;C:\Program Files\Git\mingw64\bin;C:\Program Files\Git\usr\bin;D:\Users\<user_a>\bin;C:\ProgramData\Oracle\Java\javapath;C:\Program Files (x86)\Intel\iCLS Client;C:\Program Files\Intel\iCLS Client;C:\Windows\system32;C:\Windows;C:\Windows\System32\Wbem;C:\Windows\System32\WindowsPowerShell\v1.0;C:\Program Files (x86)\Windows Kits\8.1\Windows Performance Toolkit;C:\Program Files\Microsoft SQL Server\110\Tools\Binn;C:\Program Files\Microsoft SQL Server\Client SDK\ODBC\110\Tools\Binn;C:\Program Files (x86)\Microsoft SQL Server\120\Tools\Binn;C:\Program Files\Microsoft SQL Server\120\Tools\Binn;C:\Program Files\Microsoft SQL Server\120\DTS\Binn;C:\Program Files (x86)\Microsoft SQL Server\120\Tools\Binn\ManagementStudio;C:\Program Files (x86)\Microsoft SQL Server\120\DTS\Binn;C:\Program Files\Microsoft\Web Platform Installer;C:\Program Files (x86)\Microsoft Visual Studio 12.0\Common7\IDE\PrivateAssemblies;C:\ProgramData\chocolatey\bin;C:\Program Files\Microsoft SQL Server\130\Tools\Binn;C:\Program Files\Intel\Intel(R) Management Engine Components\DAL;C:\Program Files\Intel\Intel(R) Management Engine Components\IPT;C:\Program Files (x86)\Intel\Intel(R) Management Engine Components\DAL;C:\Program Files (x86)\Intel\Intel(R) Management Engine Components\IPT;C:\Program Files\Git\cmd;C:\Program Files (x86)\Microsoft Emulator Manager\1.0;C:\Program Files (x86)\Microsoft SQL Server\110\DTS\Binn;C:\Program Files (x86)\Microsoft SQL Server\130\DTS\Binn;C:\Program Files\Microsoft DNX\Dnvm;C:\Program Files (x86)\Skype\Phone;C:\Program Files (x86)\Microsoft SQL Server\140\DTS\Binn;C:\Program Files\dotnet;C:\Program Files (x86)\GnuPG\bin;C:\Program Files\nodejs;D:\Users\<user_a>\.dnx\bin;D:\Users\<user_a>\AppData\Roaming\npm;D:\Users\<user_a>\AppData\Local\Programs\Fiddler;C:\Program Files\Git\usr\bin\vendor_perl;C:\Program Files\Git\usr\bin\core_perl;C:\Program Files\Microsoft VS Code;D:\Users\<user_a>\AppData\Roaming\npm
8 verbose lifecycle angular-ngrx-material-starter@6.0.0-rc.1~prettier:ci: CWD: D:\Users\<user_a>\Documents\Angular2Dev\angular-ngrx-material-starter
9 silly lifecycle angular-ngrx-material-starter@6.0.0-rc.1~prettier:ci: Args: [ '/d /s /c',
9 silly lifecycle   'prettier {src,e2e}/**/*.{ts,json,md,scss} --list-different' ]
10 silly lifecycle angular-ngrx-material-starter@6.0.0-rc.1~prettier:ci: Returned: code: 1  signal: null
11 info lifecycle angular-ngrx-material-starter@6.0.0-rc.1~prettier:ci: Failed to exec prettier:ci script
12 verbose stack Error<EMAIL_ADDRESS>prettier:ci: `prettier {src,e2e}/**/*.{ts,json,md,scss} --list-different`
12 verbose stack Exit status 1
12 verbose stack     at EventEmitter.<anonymous> (C:\Program Files\nodejs\node_modules\npm\node_modules\npm-lifecycle\index.js:285:16)
12 verbose stack     at emitTwo (events.js:126:13)
12 verbose stack     at EventEmitter.emit (events.js:214:7)
12 verbose stack     at ChildProcess.<anonymous> (C:\Program Files\nodejs\node_modules\npm\node_modules\npm-lifecycle\lib\spawn.js:55:14)
12 verbose stack     at emitTwo (events.js:126:13)
12 verbose stack     at ChildProcess.emit (events.js:214:7)
12 verbose stack     at maybeClose (internal/child_process.js:925:16)
12 verbose stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:209:5)
13 verbose pkgid<EMAIL_ADDRESS>14 verbose cwd D:\Users\<user_a>\Documents\Angular2Dev\angular-ngrx-material-starter
15 verbose Windows_NT 6.3.9600
16 verbose argv "C:\\Program Files\\nodejs\\node.exe" "C:\\Program Files\\nodejs\\node_modules\\npm\\bin\\npm-cli.js" "run" "prettier:ci"
17 verbose node v8.10.0
18 verbose npm  v5.6.0
19 error code ELIFECYCLE
20 error errno 1
21 error<EMAIL_ADDRESS>prettier:ci: `prettier {src,e2e}/**/*.{ts,json,md,scss} --list-different`
21 error Exit status 1
22 error Failed at the<EMAIL_ADDRESS>prettier:ci script.
22 error This is probably not a problem with npm. There is likely additional logging output above.
23 verbose exit [ 1, true ]

@tomastrajan I have looked into the issue with module resolution in VS Code.  I have found a workaround/solution here that consists of changing
"baseUrl": "./"
to
"baseUrl": "src"
in tsconfig.json
I tried that. The app compiles and runs.  Do you want me to include it in my other changes?

Gonna try it locally first and will let you know soon.

Also, as for the error when running npm run ci, it could be caused by using windows cmd... I use windows too but with cygwin ( which is similar to git bash or linux subsystem for windows ) so its not just pure cmd. When I try running npm run ci in windows cmd, I get error that the rm is unknown command so maybe I can come with some cross environment way of cleaning dist folder.

I reworked build script a bit and ran it successfully in the windows environment using cmd so if you sync your fork you should be able to run npm run ci on your local machine.
ps: I use following commands to sync my forks when working on some other repos

git checkout master --force
git fetch upstream
git merge upstream/master
git push

@tomastrajan - Thanks for the advice.  I just did what you suggested (sync'd my fork using the commands above).  Unfortunately I still get the same ELIFECYCLE error from npm run ci on my machineas before.  I usegit bash.  I wonder if this has something to do with VS Code.  Specifically, with the fact that (I think) it changes line endings from CR to CRLF when it saves a file. I will make a brand new copy of the project and try to run npm run ci` locally on it without changing it first.

@tomastrajan  CI started to work after I ran npm run prettier, which appears to do prettier --write.
In my last commit, I tried to use the proper commit message syntax. I hope that worked.  I also put the close tag in the comment footer, unfortunately I typed #134 instead of #126 (the correct issue number).  I don't know how to fix that in the existing comment.
Let me know if I need to do anything else on this.

Thank you very much for your contribution!


Add -a/--all option to doit forget

I have a very large data analysis project that uses doit to analyze large data sets and cache the results of those analyses in pickle files, which are then loaded and used for plotting downstream. Doit handles this task perfectly. It's hard to overstate how much time doit has saved me when working on this project.
However, one instance where doit has cost me time is when I have accidentally done doit forget with no arguments. I know that this forgets everything, but it is common for me to change a plotting task then forget it, and run it. When I'm tired, sometimes I press enter early when trying to forget the plotting task, which ends up forgetting tasks that cache analyses that take hours.
My solution to that is to force users to opt in to forgetting all tasks with an -a/--all flag (e.g., doit forget --all). I've implemented this in this PR, but I haven't yet filled out the changelog or added tests because I wanted to be sure that you would be okay with this change first @schettino72. If you're okay with it, then I will add those to this PR.

Thanks Trevor. I understand your use-case.
I guess in order to retain backward compatibility (and the functionality for those who like it) we would need to add one more command-line option --disable-default-all. For your use-case you would set this to True in your config and get the behavior you want. Makes sense?

we would need to add one more command-line option --disable-default-all

Yep that makes total sense. I'll make that change and add in some tests as soon as I can.

Hey, I am planning a release this month. It would be great if you have time to complete this.

Thanks @schettino72 I should be able to do this :+1:

Okay I've updated this PR to add the --disable-default-all option, and updated metadata files where I could find them. I also added a note to the forget command documentation, but if you'd prefer to keep that short and let people discover the options through the --help system, feel free to remove the documentation note.

Codecov Report

Merging #377 (75a8826) into master (90f19fa) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #377   +/-   ##
=======================================
  Coverage   99.68%   99.68%
=======================================
  Files          65       65
  Lines        8961     8978   +17
=======================================
+ Hits         8933     8950   +17
  Misses         28       28

Impacted Files
Coverage Δ

doit/cmd_forget.py
100.00% <100.00%> (ø)

tests/test_cmd_forget.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90f19fa...75a8826. Read the comment docs.

This actually does not work the way I expected.
If you do not provide any parameter the default_tasks are forgotten, not all tasks...
DOIT_CONFIG = {
    'default_tasks': ['pyflakes', 'ut'],
}

So I will make following changes:

rename --disable-default-all to --disable-default.
--all will really forget all not just the default
I will add an inverse --enable-default if your config has --disable-default but you want to explicitly forget the default tasks

Makes sense?

Yes that works for me! In my use case I ran all tasks by default so I mistakenly thought that the default to was to forget all tasks rather than just the default tasks. Your suggestion makes sense. Let me know you want me to help with anything!

Your redone version looks great @schettino72, thanks for getting this in the new release!


init: wait for ifindex file

On s390x a network device creation is triggerd asynchronously by a machine
check interrupt. With this patch init waits until the interface file is ready to be opened.

Can one of the admins verify this patch?


The video embedded in the README should run when user scrolls to that point

If it is set to play automatically, it might be not comfortable for some users, users with low bandwidth internet will experience inconvenience with that feature.

The old video has been removed from the README. Closing this issue for now.


Use GTK toolkit on linux

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

This builds emacs using modern toolkit (gtk3), graphics (cairo) and font (harfbuzz) libraries to produce a more full-featured emacs experience on linux.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@conda-forge-admin, please rerender

@conda-forge-admin, please rerender

I don't really use the GUI emacs on Linux. Which toolkit is used by default? What is the advantage of this over the current behavior?

I don't really use the GUI emacs on Linux. Which toolkit is used by default? What is the advantage of this over the current behavior?

The recipe test only tests emacs -nw. I wonder if it would break on CI if we also added the same test without -nw. Otherwise I don't know if we can actually test that it works without checking manually.

The recipe test only tests emacs -nw. I wonder if it would break on CI if we also added the same test without -nw. Otherwise I don't know if we can actually test that it works without checking manually.

I don't really use the GUI emacs on Linux. Which toolkit is used by default?

gtk is the default according to http://git.savannah.gnu.org/cgit/emacs.git/tree/INSTALL?h=emacs-27 , though I had to specify --with-x-toolkit=gtk3 in order to get it to use that. gtk is pretty much the only modern tookit supported by Emacs -- the others are mostly of historical interest.

What is the advantage of this over the current behavior?
Basically that menus and fonts work and don't look like they came back to haunt us from the 1980's. Here is a quick side-by-side comparison:

I don't really use the GUI emacs on Linux. Which toolkit is used by default?

gtk is the default according to http://git.savannah.gnu.org/cgit/emacs.git/tree/INSTALL?h=emacs-27 , though I had to specify --with-x-toolkit=gtk3 in order to get it to use that. gtk is pretty much the only modern tookit supported by Emacs -- the others are mostly of historical interest.

What is the advantage of this over the current behavior?
Basically that menus and fonts work and don't look like they came back to haunt us from the 1980's. Here is a quick side-by-side comparison:

The recipe test only tests emacs -nw. I wonder if it would break on CI if we also added the same test without -nw. Otherwise I don't know if we can actually test that it works without checking manually.

Since this is the status quo with the current X11 GUI it might make sense to consider that issue separately.

The recipe test only tests emacs -nw. I wonder if it would break on CI if we also added the same test without -nw. Otherwise I don't know if we can actually test that it works without checking manually.

Since this is the status quo with the current X11 GUI it might make sense to consider that issue separately.

Since this is the status quo with the current X11 GUI it might make sense to consider that issue separately.

Sure, but I've tried the current GUI on Linux and I know others use it, so I know it works. I would like to confirm that GTK works before merging this if it isn't too hard.
All I'm suggesting is to try adding
$PREFIX/bin/emacs -Q --kill --batch

as a test in the recipe. If it works, then that is good. If it doesn't, presumably because of some limitation in the CI being too "headless", then I wouldn't worry about it too much.
Actually, I had thought that -nw bypassed even loading the GUI frameworks, but I remembered wrong https://github.com/conda-forge/emacs-feedstock/issues/11. So it seems even the -nw test passing is a good sign.
Also, have you tested this yourself manually? Is there some way to install the artifact from this PR without merging? I guess we could also just merge it and if something breaks we revert it.

Since this is the status quo with the current X11 GUI it might make sense to consider that issue separately.

Sure, but I've tried the current GUI on Linux and I know others use it, so I know it works. I would like to confirm that GTK works before merging this if it isn't too hard.
All I'm suggesting is to try adding
$PREFIX/bin/emacs -Q --kill --batch

as a test in the recipe. If it works, then that is good. If it doesn't, presumably because of some limitation in the CI being too "headless", then I wouldn't worry about it too much.
Actually, I had thought that -nw bypassed even loading the GUI frameworks, but I remembered wrong https://github.com/conda-forge/emacs-feedstock/issues/11. So it seems even the -nw test passing is a good sign.
Also, have you tested this yourself manually? Is there some way to install the artifact from this PR without merging? I guess we could also just merge it and if something breaks we revert it.

Since this is the status quo with the current X11 GUI it might make sense to consider that issue separately.

I have to admit that I'm new to conda packaging, and I haven't been able to get build-locally.py to work on my machine. It might have something to do with using podman in place of docker, but anyway I haven't been able to run all the tests locally.
Should I add $PREFIX/bin/emacs -Q --kill --batch to the tests and push it here to the the CI test it?
I did build it in a podman container running linux-anvil-comp7:latest and manually tested it there. I also uploaded the package to https://anaconda.org/izahn/emacs-gtk. I've been using it all afternoon without any problems, though admittedly in a conda environment with a bunch of other stuff already installed.

Since this is the status quo with the current X11 GUI it might make sense to consider that issue separately.

I have to admit that I'm new to conda packaging, and I haven't been able to get build-locally.py to work on my machine. It might have something to do with using podman in place of docker, but anyway I haven't been able to run all the tests locally.
Should I add $PREFIX/bin/emacs -Q --kill --batch to the tests and push it here to the the CI test it?
I did build it in a podman container running linux-anvil-comp7:latest and manually tested it there. I also uploaded the package to https://anaconda.org/izahn/emacs-gtk. I've been using it all afternoon without any problems, though admittedly in a conda environment with a bunch of other stuff already installed.

Should I add $PREFIX/bin/emacs -Q --kill --batch to the tests and push it here to let the CI test it?

Yeah push up a commit and see what happens on the CI.

Should I add $PREFIX/bin/emacs -Q --kill --batch to the tests and push it here to let the CI test it?

Yeah push up a commit and see what happens on the CI.

It looks like the CI tests all passed. I've done a few more manual tests using https://anaconda.org/izahn/emacs-gtk and everything seems to work as expected.

It looks like the CI tests all passed. I've done a few more manual tests using https://anaconda.org/izahn/emacs-gtk and everything seems to work as expected.

OK. I'm going to merge this. If something breaks, we can open a new PR to fix it.

OK. I'm going to merge this. If something breaks, we can open a new PR to fix it.


PHPUnit 10 Shift

This pull request contains changes for upgrading to PHPUnit 10 automated by the PHPUnit 10 Shift.
Before merging, you need to:

Checkout the shift-112999 branch
Review all pull request comments for additional changes
Run composer update (if the scripts fail, try with --no-scripts)
Run your tests suite: vendor/bin/phpunit

If there were changes you felt could have been automated, please reply to the follow-up email with your feedback or on Twitter.

:warning: PHPUnit 10 requires PHP version 8.1 or higher. Be sure to verify you met this requirement by running php -v in your test environment.

:information_source: PHPUnit has documented declaring test classes as final since PHPUnit 8. In an effort to modernize your test suite, Shift has declared your test classes as final.
Shift understands developers have different preferences when it comes to using final. If you do not wish to declare your test classes as final, you may undo this change by running: git revert 1b479487

:warning: PHPUnit 10 has made several changes to the configuration file. After running composer update, you may run vendor/bin/phpunit --migrate-configuration to have PHPUnit upgrade your configuration file.

:information_source: PHPUnit has documented using return types for test cases and data providers since PHPUnit 8. In an effort to modernize your test suite, Shift added a return type of void to your test cases and a return type of array to your data providers.
Shift understands developers have different preferences when it comes to type hints. If you do not wish to add return types, you may undo this change by running: git revert 1b479487

:warning: PHPUnit 10 now requires any base test class to have a TestCase suffix. In addition, this class should be defined as abstract. If you have a custom base test class, you should ensure it meets these new requirements.

:alembic: This Shift is still being refined. Please report any issues or suggestions to<EMAIL_ADDRESS>Your feedback is what helps improve the experience for everyone.


add DataFrameSchema.rename_columns method

This method should take in a dictionary where keys are current column name and values are renamed column name and return a copy of the schema with the associated column name changes.

I'd like to take this up.
In which test file would you write the test for this?


Web: Missing Refresh Token

Checklist

[X] The issue can be reproduced in the auth0_flutter sample app (or N/A).
[X] I have looked into the Readme, Examples, and FAQ and have not found a suitable solution or answer.
[X] I have looked into the API documentation and have not found a suitable solution or answer.
[X] I have searched the issues and have not found a suitable solution or answer.
[X] I have searched the Auth0 Community forums and have not found a suitable solution or answer.
[X] I agree to the terms within the Auth0 Code of Conduct.

Description
I found a problem using refreshtokens and localstorage on web implementation. I not 100% sure if im doing it wrong or if this is a bug, because i cannot give an audience for onLoad function.
Reproduction
This is the inital conf:
      final credentials = await auth0Web.onLoad(
        cacheLocation: CacheLocation.localStorage,
        useRefreshTokens: true,
      );

and here the Login happens:
final credentials = await auth0Web.loginWithPopup(
        audience: Config.auth0Audience,
      );

The data is saved in LocalStorage as expected with audience information.
When I rerun the application i get the following WebException from onLoad():
[ERROR] | 11:26:38 466ms | Missing Refresh Token (audience: '', scope: 'openid profile email offline_access')
So there is an error that we do not have an audience here. Where can i config the audience in onLoad? Is this an misusing on my side?
Additional context
No response
auth0_flutter version
1.2.0
Flutter version
3.10.2
Platform
Web
Platform version(s)
1.2.0

Works perfectly!
Thanks a lot for quick fix!


patch: fix buildRevertPatch not restoring the value at the destination of a move operation

Quick fix, congratulations !


.eh_frame: Do we need to handle register rules?

Something like
diff --git a/pkg/stack/unwind/plan_table.go b/pkg/stack/unwind/plan_table.go
index 1935cef..72597dd 100644
--- a/pkg/stack/unwind/plan_table.go
+++ b/pkg/stack/unwind/plan_table.go
@@ -286,6 +286,8 @@ func buildTableRows(fde *frame.DescriptionEntry, start uint64) []PlanTableRow {
                                        row.RA = Instruction{Op: OpCFAOffset, Offset: rule.Offset}
                                case frame.RuleUndefined:
                                        row.RA = Instruction{Op: OpUndefined}
+                               case frame.RuleRegister:
+                                       row.RBP = Instruction{Op: OpRegister, Reg: rule.Reg}
                                default:
                                        row.RA = Instruction{Op: OpUnimplemented}
                                }
@@ -304,6 +306,8 @@ func buildTableRows(fde *frame.DescriptionEntry, start uint64) []PlanTableRow {
                                        row.RBP = Instruction{Op: OpCFAOffset, Offset: rule.Offset}
                                case frame.RuleUndefined:
                                        row.RBP = Instruction{Op: OpUndefined}
+                               case frame.RuleRegister:
+                                       row.RBP = Instruction{Op: OpRegister, Reg: rule.Reg}
                                default:
                                        row.RBP = Instruction{Op: OpUnimplemented}
                                }

I am unsure if we need this or not. But opening an issue so we don't forget to take a look at this.

The answer is yes! While they happen rarely, they are needed. This was fixed our dwarf unwind information parser in https://github.com/parca-dev/parca-agent/pull/922


EIP-1102 verbiage updates

I went ahead and took a stab at the EIP-1102 edits based on the EIP-1102-specific PR feedback so far. I figured you'd want to focus on your new proposal instead of worrying about verbiage modifications to an existing one.
I submitted this here so you could review and pull into your branch whenever you're ready, and these changes will percolate into your PR against ethereum/EIPs.

Ah, I can actually submit these edits against ethereum/EIPs directly and they'll be auto-merged. That way you don't have to worry about lobbying EIP-1102 changes through in addition to your provider proposal.

Ok, I submitted EIP-1102 edits at https://github.com/ethereum/EIPs/pull/1195. They were auto-merged, so you should be able to rebase your branch on the master branch of ethereum/EIPs and only focus on your new Ethereum provider proposal 👍

@bitpshr Awesome, nice idea. Updates look great, just merged in :) thx for all your help.


Add some colors to pkg deletion messages

The idea is to colorize some messages I find important in the initial poudriere output of bulk, like which pkgs are deleted and for what reason: new version, dependency changed, options changed, etc...
Running this set of patches in production for  a number of bulk runs / days now. Haven't tested all possible situations. Example screenshot here:

I like this, but I think we should limit to 1 color here.  It can be simpler if we move the msg into delete_pkg as well and pass the reason as an argument.


[Ingress] Support for Mutual TLS with external clients

It would be great to support mutual TLS with Ingress clients.
A working example can be found in nginx ingress controller: https://github.com/kubernetes/ingress/blob/master/controllers/nginx/configuration.md#certificate-authentication
This should not be confused with mutual TLS inside your cluster (i.e. service-to-service communication) -> that's what https://github.com/istio/auth is for.

Hi,
Can you please post this issue on istio/issues repo? We are keeping track of all bugs and feature requests in that repo. The issues here are for our internal tracking purposes.

Issue moved to istio/issues #50 via ZenHub


Give banner to inform users of which network the instance of GovTool is connected to

What?

GovTool instances are connected to different networks
Different networks have different characteristics so it is important for users to know this

Why?

We need to inform users which network the instance of GovTool is on, so they can set their wallets to the correct network.

How?

@m-i-k-e and team design how a informative banner could be used for this
GovTool FE adjusted to render this new information using the designs

User Story
Title: Display Network Information on GovTool
User Story: As a user of GovTool, I want to know which network the instance of GovTool is connected to, so I can set my wallet to the correct network.
Acceptance Criteria:

Given that I am a user of GovTool.
When I access GovTool.
Then I should see an informative banner that clearly indicates the network the instance of GovTool is connected to.

First mockup from Mike

you could use the same component we are using for the member area

Yeah, that will work. Thanks!

Question: @Ryun1 @l-br1:
The user story says:

Given that I am a user of GovTool.
When I access GovTool.
Then I should see an informative banner that clearly indicates the network the instance of GovTool is connected to

This implies that the network should always be shown. I agree that this is better than 'sometimes' showing it.
This would make the banner permanent, however. I think we could look at different ways of displaying this next week.

This would make the banner permanent, however. I think we could look at different ways of displaying this if that's the case.

Why dont we just show the banner on testnets? and then it is removed on mainnet?
this is how some dApps on Cardano do it

That was my idea at first.

So there are two banners: One for the network - the network banner shows when you're not on Mainnet. It always shows.
The other banner is the bootstrapping banner, which can show on any network (but SanchoNet).
Sometimes there is a need for both to show.
Examples:

This has been passed to @kgrzonka  for final artwork.

Looking great @m-i-k-e 🤝


Update metrics.py

Fixes issue https://github.com/tensorflow/tensorflow/issues/54117

@Yashashree304  Can you please resolve conflicts? Thanks!

@gbaned @fchollet Sorry for late response was stuck up in something. But I am unable to resolve conflicts can you please help me?

Just close this PR, pull a fresh copy of the repo, and create a new PR. The PR is a 2-line change only anyway.

Okay Thanks!


rake aborted!  Build failed

Hi,
Whenever I am doing "RAKE" from within the kxsmb folder in the terminal I get the following errror:
checking whether we are big endian... configure: error: in `/Users/deyi/Downloads/kxsmb/samba/source3':
configure: error: cannot run test program while cross compiling
See `config.log' for more details
rake aborted!
******** Build failed ********
/Users/deyi/Downloads/kxsmb/Rakefile:42:in `system_or_exit'
/Users/deyi/Downloads/kxsmb/Rakefile:216:in `buildArch'
/Users/deyi/Downloads/kxsmb/Rakefile:260:in `block in <top (required)>'
Tasks: TOP => default => build_all => build_smb_i386
(See full trace by running task with --trace)

I have this too, running on macOS 10.12.1 with Xcode 8.0
Any help would be appreciated

I have this too....
macOS 10.12.2 with Xcode 8.0

export samba_cv_big_endian=no
export samba_cv_little_endian=yes
export samba_cv_CC_NEGATIVE_ENUM_VALUES=yes
export libreplace_cv_HAVE_GETADDRINFO=yes
export samba_cv_HAVE_WRFILE_KEYTAB=no
export smb_krb5_cv_enctype_to_string_takes_krb5_context_arg=no
export smb_krb5_cv_enctype_to_string_takes_size_t_arg=yes
export ac_cv_file__proc_sys_kernel_core_pattern=yes
rake

export samba_cv_big_endian=no
export samba_cv_little_endian=yes
export samba_cv_CC_NEGATIVE_ENUM_VALUES=yes
export libreplace_cv_HAVE_GETADDRINFO=no
export samba_cv_HAVE_WRFILE_KEYTAB=no
export smb_krb5_cv_enctype_to_string_takes_krb5_context_arg=no
export smb_krb5_cv_enctype_to_string_takes_size_t_arg=yes
export ac_cv_file__proc_sys_kernel_core_pattern=yes
rake

I have this too, running on macOS 10.12.1 with Xcode 8.0
Any help would be appreciated

I use @ppyupp's method to solve this problem.
Thank you very much!

it's not work @ppyupp
macOS 10.12.6  with Xcode 9.2,
******** Build failed ********
/Users/jack/Documents/GitHub/kxsmb/Rakefile:42:in system_or_exit' /Users/jack/Documents/GitHub/kxsmb/Rakefile:219:in block in buildArch'
/Users/jack/Documents/GitHub/kxsmb/Rakefile:218:in each' /Users/jack/Documents/GitHub/kxsmb/Rakefile:218:in buildArch'
/Users/jack/Documents/GitHub/kxsmb/Rakefile:243:in `block in <top (required)>'
Tasks: TOP => default => build_all => build_smb_armv7
(See full trace by running task with --trace)
how to do next,thanks


Use the new recert additional trust bundle options

Incomplete, still testing and need to add a bit more code
Background / Context
Recert recently added ([1], [2]) some options that allow changing the
cluster's trust bundle (it's recommended you read the PRs for more
background about this).
Issue / Requirement / Reason for change
The lifecycle-agent doesn't make use of the new options added to recert
Solution / Feature Overview
Change the lifecycle-agent to use the new options added to recert
Implementation Details
Multiple new fields have been added.

AdditionalTrustBundle in SeedReconfiguration. This represents the
trust bundle to be used for seed-reconfiguration. This contains the
user-ca-bundle contents, the proxy configmap name, and the proxy configmap
contents.

AdditionalTrustBundle in SeedClusterInfo. This represents the
state of the trust bundle in the seed cluster. This is simply booleans
indicating the presence or lack there-of of the user-ca-bundle and the
proxy configmap name (only if it actually has contents, a configmap
with no contents is considered invalid OCP configuration). This is
useful for when we want to verify that the seed is compatible with
our desired SeedReconfiguration.

RecertConfig will now use the new CryptoDirs and CryptoFiles fields
to specify the directories and files that should be considered part of
the cluster's crypto material. Along with the ClusterCustomizationDirs and
ClusterCustomizationFiles fields that specify the directories and files
involved in cluster customization. Since these no longer overlap when
it comes to customizing the trust bundle, we must use these new fields
instead of the old common StaticDirs and StaticFiles fields.

[1] https://github.com/rh-ecosystem-edge/recert/pull/110
[2] https://github.com/rh-ecosystem-edge/recert/pull/140

/hold waiting for  https://github.com/rh-ecosystem-edge/recert/pull/140

/remove-label cluster-config-api-changed

/remove-label cluster-config-api-changed

/unhold

/remove-label cluster-config-api-changed

@omertuc how it will work with IBI? i wonder how we will be able to provide all the needed params?

/approve

/lgtm


format of date

Hi,
I have a query with 2 dates at the format "YYYY-MM-DD". In the table, the field is stored on the format "YYYY-MM-DD HH:mm"
If I build my query with:
.whereBetween(date,[date1,date2])
knew return 0 rows
If I try with:
.whereBetween(date,['%'+date1+'%','%'+date2+'%'])
The result is the same
If I want force the format of the field:
.whereBetween("date_format(date,'%Y-%m-%d')",[date1,date2])
I have an message of error:
_Unhandled rejection Error: select id, employee_id, category_id, days, label, date, date_end from event_view_abs where date_format(date,'%Y-%m-%d') between '2016-02-17' and '2016-02-18' and parent_id in (2, 50) and cb_pointage = 1 order by employee_id asc, date asc - Unknown column 'date_format(date,'%Y-%m-%d')' in 'where clause'
_
Thanks for your help.
Franck

Moment.js is your friend.
whereBetween('date',
        [ (moment().subtract(ageBounds[1] + 1, 'years').add(1, 'day').format('YYYY-MM-DD')),
          (moment().subtract(ageBounds[0], 'years').format('YYYY-MM-DD')) ]
      )

Hi,
Thanks for your response, At the begining I tried with moment but the problem was the same.
Sample: date1= '2016-02-29'
date2= '2016-03-05'
whereBetween['birthday',moment(date1).format('YYYY-MM-DD'),moment(date2).format('YYYY-MM-DD')]
In your sample, if we define int1='2016-02-29'  and int2='2016-03-05'
The result is : 2016-03-08 and 2016-03-07. Not the dates defined??
Thanks,
Franck

Hi,
I change my code and I integrated your comment:
.whereBetween('date',[moment().subtract(date3, 'years').add(parseInt(diffDays)-1, 'day').format('YYYY-MM-DD'),moment().subtract(date3, 'years').add(parseInt(diffDays2)-1, 'day').format('YYYY-MM-DD')])
But the problem is the same.
If the sql include only one date:
.andWhere('date','%'+args[2]+'%')
It's ok.
I think, there is a problem with date and whereBetween.
Thanks,
Franck

@fsebbah Can you give us a more detailed example? For example the exact code you are using, and also the database rows that you are trying to select. Reading the comments in this issue I'm having a hard time understanding what the problem is here.
Since the column isn't just a date column, but also contains HH:MM:ss, a 'Between' can be hard to understand. I'll give you a few examples:
Let's say I have two database rows with the following dates:
2016-03-07 10:00:00
2016-03-10 12:00:00

This will return both rows:
db('test')
	.whereBetween('date', ['2016-03-07', '2016-03-11'])
	.select()

This will only return one row:
db('test')
	.whereBetween('date', ['2016-03-07', '2016-03-10'])
	.select()

Because 2016-03-10 defined as the "end" point of the between clause, is less than 2016-03-10 12:00:00.
This will not return any rows:
 db('test')
	.whereBetween('date', ['2016-03-07 11:00:00', '2016-03-10 11:00:00'])
	.select()

Because the starttime is greater than 10:00:00 and the end time is less than 12:00:00.
 If you do not want to take HH:mm:ss into consideration, then your best bet is to append 00:00:00 to the start date, and 23:59:59 to the end date.
Like so:
.whereBetween(date, [date1 + ' 00:00:00', date2 + ' 23:59:59'])

To your point about date_format(date,'%Y-%m-%d') throwing an error, you are getting that error because knex will treat the first parameter as a valid column. If you still want to use this method, then you can try using raw.
.whereRaw('date_format(date, \'%Y-%m-%d\') BETWEEN ? AND ?', [date1, date2])

I feel like I'm rambling quite a bit in this reply, but please supply us with proper information so we can assist you further. While Momentjs is an outstanding library, I see absolutely no reason why it would be needed here.

Hi Wbuzz,
Thanks for your response.
I read your message and I test your solutions. I send you my feedback after.
Franck

Hi wubzz,
This solution works : .whereRaw('date_format(date, '%Y-%m-%d') BETWEEN ? AND ?', [date1, date2]).
It was very hard for me to understand how work with date format.
I won many days thanks to you.


can it run in Pycharm

can it run in Pycharm

Yes, it works with PyCharm. The JetBrains marketplace lists the current version to be compatible with:
PhpStorm — 2020.2+

Rider — 2020.2+

IntelliJ IDEA Educational — 2020.2+

WebStorm — 2020.2+

DataGrip — 2020.2+

Android Studio — build 202.0+

AppCode — 2020.2+

IntelliJ IDEA Ultimate — 2020.2+

PyCharm Educational — 2020.2+

IntelliJ IDEA Community — 2020.2+

PyCharm Professional — 2020.2+

GoLand — 2020.2+

PyCharm Community — 2020.2+

RubyMine — 2020.2+

MPS — 2020.2+

CLion — 2020.2+

(as the question has been raised in a different thread: please read it as "supported from 2020.2 onwards" - this includes also 2021.*)

I close this issue as there hasn't been a comment for several months. Please comment again to re-open the issue.


[ALLUXIO-1598] Improve the unit test coverage for HdfsFileInputStream

Currently HdfsFileInputStream is only covered by integration tests
add unit tests.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/8742/Build result: FAILURE[...truncated 1105 lines...][JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/assembly/pom.xml to org.alluxio/alluxio-assemblies/1.1.0-SNAPSHOT/alluxio-assemblies-1.1.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/shell/pom.xml to org.alluxio/alluxio-shell/1.1.0-SNAPSHOT/alluxio-shell-1.1.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/underfs/oss/pom.xml to org.alluxio/alluxio-underfs-oss/1.1.0-SNAPSHOT/alluxio-underfs-oss-1.1.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/underfs/oss/target/alluxio-underfs-oss-1.1.0-SNAPSHOT.jar to org.alluxio/alluxio-underfs-oss/1.1.0-SNAPSHOT/alluxio-underfs-oss-1.1.0-SNAPSHOT.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/underfs/oss/target/alluxio-underfs-oss-1.1.0-SNAPSHOT-sources.jar to org.alluxio/alluxio-underfs-oss/1.1.0-SNAPSHOT/alluxio-underfs-oss-1.1.0-SNAPSHOT-sources.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/client-internal/pom.xml to org.alluxio/alluxio-core-client-internal/1.1.0-SNAPSHOT/alluxio-core-client-internal-1.1.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/keyvalue/client/pom.xml to org.alluxio/alluxio-keyvalue-client/1.1.0-SNAPSHOT/alluxio-keyvalue-client-1.1.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/underfs/hdfs/pom.xml to org.alluxio/alluxio-underfs-hdfs/1.1.0-SNAPSHOT/alluxio-underfs-hdfs-1.1.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/underfs/hdfs/target/alluxio-underfs-hdfs-1.1.0-SNAPSHOT.jar to org.alluxio/alluxio-underfs-hdfs/1.1.0-SNAPSHOT/alluxio-underfs-hdfs-1.1.0-SNAPSHOT.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/underfs/hdfs/target/alluxio-underfs-hdfs-1.1.0-SNAPSHOT-sources.jar to org.alluxio/alluxio-underfs-hdfs/1.1.0-SNAPSHOT/alluxio-underfs-hdfs-1.1.0-SNAPSHOT-sources.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/underfs/swift/pom.xml to org.alluxio/alluxio-underfs-swift/1.1.0-SNAPSHOT/alluxio-underfs-swift-1.1.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/underfs/swift/target/alluxio-underfs-swift-1.1.0-SNAPSHOT.jar to org.alluxio/alluxio-underfs-swift/1.1.0-SNAPSHOT/alluxio-underfs-swift-1.1.0-SNAPSHOT.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/underfs/swift/target/alluxio-underfs-swift-1.1.0-SNAPSHOT-sources.jar to org.alluxio/alluxio-underfs-swift/1.1.0-SNAPSHOT/alluxio-underfs-swift-1.1.0-SNAPSHOT-sources.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/examples/pom.xml to org.alluxio/alluxio-examples/1.1.0-SNAPSHOT/alluxio-examples-1.1.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/server/pom.xml to org.alluxio/alluxio-core-server/1.1.0-SNAPSHOT/alluxio-core-server-1.1.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/keyvalue/common/pom.xml to org.alluxio/alluxio-keyvalue-common/1.1.0-SNAPSHOT/alluxio-keyvalue-common-1.1.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/underfs/pom.xml to org.alluxio/alluxio-underfs/1.1.0-SNAPSHOT/alluxio-underfs-1.1.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/keyvalue/client-internal/pom.xml to org.alluxio/alluxio-keyvalue-client-internal/1.1.0-SNAPSHOT/alluxio-keyvalue-client-internal-1.1.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/underfs/glusterfs/pom.xml to org.alluxio/alluxio-underfs-glusterfs/1.1.0-SNAPSHOT/alluxio-underfs-glusterfs-1.1.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/underfs/glusterfs/target/alluxio-underfs-glusterfs-1.1.0-SNAPSHOT.jar to org.alluxio/alluxio-underfs-glusterfs/1.1.0-SNAPSHOT/alluxio-underfs-glusterfs-1.1.0-SNAPSHOT.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/underfs/glusterfs/target/alluxio-underfs-glusterfs-1.1.0-SNAPSHOT-sources.jar to org.alluxio/alluxio-underfs-glusterfs/1.1.0-SNAPSHOT/alluxio-underfs-glusterfs-1.1.0-SNAPSHOT-sources.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/integration/pom.xml to org.alluxio/alluxio-integration/1.1.0-SNAPSHOT/alluxio-integration-1.1.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/keyvalue/pom.xml to org.alluxio/alluxio-keyvalue/1.1.0-SNAPSHOT/alluxio-keyvalue-1.1.0-SNAPSHOT.pomchannel stopped
Test FAILed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/8743/
Test PASSed.

Merged build finished. Test PASSed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/8744/
Test FAILed.

Merged build finished. Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/8745/
Test PASSed.

Hi @luoli523, thanks for improving the unit test coverage! I left some comments on the code and also have some high-level comments:

The current PR tests the unsupported operation cases for HdfsFileInputStream - could you also test the normal usage, e.g. read, getPos, seek, and readFromHdfsBuffer?
Right now there are 5 commits with the same commit message title. Do you mind changing the titles to better reflect what each commit does?
Please include a link to the JIRA as the first line of the pull request message

This push does below:

add more cases for normal usage methos
update the commit messages to better reflect what each commit really does
add the jira link to the PR message

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/8763/
Test PASSed.

Thanks for the additional tests, I've left some comments

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/8765/
Test PASSed.

@luoli523 Any updates on this PR?


[fix case when multi aac frame in a rtp packet]

Please describe the summary for this PR.

Add more details about this PR.
Add more details about this PR.
Add more details about this PR.

In gb28181,  some IPC will put multi aac frame in one rtp packet,  then srs will lose some frame.
For rtp packet with multi aac frame, srs treat as one frame,  then the frame_length in adts header is wrong. Some video player like videojs will crash.

感谢提交PR，方便在微信上给我发个消息吗？


Flight planning notebook

This implements the flight planning notebook using OpenAP for aircraft data.
It provides:

[x] a utility module with:

[x] a class to retrieve meteo data from CDS
[x] a class to interpolate wind data

[x] the notebook itself

Remaining work:

[x] creating the wind data object OpenAP is expecting from our own wind data

testme


Drupal uses APCu very  actively in version 8 core

The extension is not available at the moment in the DockerFile, though it is very actively used in D8 core.
It should be fairly easy to add it from a package.

@ndobromirov thank you for the suggestion. The extension has been added.


Using sslmode=disable with pgdriver

According to the documentation there are multiple ways to configure a Postgres connection, e.g.

Example:

pgconn := pgdriver.NewConnector(
	pgdriver.WithAddr("localhost:5437"),
//...
)

Example

pgconn := pgdriver.NewConnector(
	pgdriver.WithDSN("postgres://postgres:@localhost:5432/test?sslmode=verify-full"),
)

Now, I wanted to test this out with a local dockerized Postgres that is running without SSL/TLS.
The following connection string works as expected:
dsn := fmt.Sprintf("postgres://%s:%s@%s:%d/%s?sslmode=disable&search_path=%s", cfg.User, cfg.Password, cfg.Host, cfg.Port, cfg.Database, cfg.Scheme)
connector := pgdriver.NewConnector(pgdriver.WithDSN(dsn))

sqldb := sql.OpenDB(connector)

db := bun.NewDB(sqldb, pgdialect.New())
// ...

However, if I transform that into the syntax from  example 1, I get an error "pgdriver: SSL is not enabled on the server":
connector := pgdriver.NewConnector(
	pgdriver.WithAddr(fmt.Sprintf("%s:%d", cfg.Host, cfg.Port)),
	pgdriver.WithUser(cfg.User),
	pgdriver.WithPassword(cfg.Password),
	pgdriver.WithDatabase(cfg.Database),
	pgdriver.WithConnParams(map[string]interface{}{
		"sslmode":     "disable",
		"search_path": cfg.Scheme,
	}))

sqldb := sql.OpenDB(connector)

db := bun.NewDB(sqldb, pgdialect.New())
// ...

It appears that the sslmode connection parameter is ignored for some reason? Additionally specifying pgdriver.WithTLSConfig(&tls.Config{InsecureSkipVerify: true}) or even pgdriver.WithTLSConfig(&tls.Config{}) does nothing either.
Sadly there isn't an actual example for what I am trying to do and there doesn't appear to be an open (or closed) issue here either. Apparently, I am overlooking something – presumably something basic but what is it? Sorry, if this is a trivial problem.

Local test setup:

Database: postgres:13-alpine
Go: 1.18, 1.19
go-bun:github.com/uptrace/bun v1.1.7
github.com/uptrace/bun/dialect/pgdialect v1.1.7
github.com/uptrace/bun/driver/pgdriver v1.1.7
github.com/uptrace/bun/extra/bundebug v1.1.7
github.com/uptrace/bun/extra/bunotel v1.1.7

WithConnParams specifies PostgreSQL server params like https://www.postgresql.org/docs/14/runtime-config.html. Perhaps we should rename it to WithServerParams. So this is working as expected.

Okay, that makes sense. Thanks for the information.
As a follow up question: what would be the correct way to specify sslmode=disable (or any other) with the connection configuration style from example 1? Is it even possible to do that?

WithInsecure(true) - https://pkg.go.dev/github.com/uptrace/bun/driver/pgdriver#WithInsecure


couple of Goldens

Hi @abdushakoor12 this one just needs a
dart format lib test
on the example project I'd say

Thanks @abdushakoor12 . Had to bring through a temp branch again here: https://github.com/Nimblesite/nimble_charts/pull/41/files

@abdushakoor12 I added you to the repo so you should be able to create branches in this repo now without the fork.
Please prefix new branches with abdushakoor12/[branchname] so I can keep track. Thankyou!

Ok thanks @MelbourneDeveloper


Signature Help for Local Functions

Fixes #https://github.com/OmniSharp/omnisharp-vscode/issues/1715
The issue has been fixed with the change in #1030 . Added a test to check for the same.
Please review @DustinCampbell @TheRealPiotrP @rchande

Sigh... hit update branch instead of merge...  Will merge later once CI does its thing.


Consumption plan support still planned?

Hello! The quick start documentation says the following:

At the time of writing, the Durable SQL provider is in its early stages and does not yet work with the Azure Functions Consumption plan. It does work with the Azure Functions Elastic Premium plan but you must enable Runtime Scale Monitoring to get automatic scaling. App Service plans are also supported. Consumption plan support and Scale Controller support for Elastic Premium is coming in a later release.

That seems to say that consumption plan support is planned. Is that still the case?

Yes, Consumption plan support has been completed and we're just waiting for it to roll out to all Azure Functions production regions. We'll send a GA announcement and update the documentation (including here) once it's ready to be used.

That's great news, thank you!

hi @cgillum! Any updates on the consumption plan support rollout? Docs still say it's not supported, but a rollout taking multiple months seems odd as well. If there's an issue I could watch instead of bugging you, just LMK :). Thanks!

I completely agree that a deployment taking multiple months seems odd - yet unfortunately that's the current state of things. Some changes are being made so that future changes won't take this long (they will use a different deployment mechanism designed to avoid these kinds of delays). We're close, though - somewhere in the 90%+ range of completion.


Add Openstack advisories

See https://security.openstack.org/ossalist.html

@pombredanne   what are the package types for these ? PURL conversion  for eg  for https://security.openstack.org/ossa/OSSA-2019-004.html would be helpful.

A better source pointed to by @sbs2001 is https://github.com/openstack/ossa which is YAML.


Quality upper bound

Fix bug in qualityUpperBound:

In and Out parameters were swapped when calculating the rate
In and out qualities were not calculated correctly; use existing functions
to get the qualities
Added tests to check that theoretical quality matches actual computed quality

Jenkins Build Summary
Built from this commit
Built at 20190820 - 19:41:29
Test Results

Build Type
Log
Result
Status

msvc.Debug
logfile
1181 cases, 0 failed, t: 1099s
PASS :white_check_mark:

msvc.Debug, NINJA_BUILD=true
logfile
1181 cases, 0 failed, t: 1134s
PASS :white_check_mark:

msvc.Debug -Dunity=OFF
logfile
1180 cases, 0 failed, t: 1667s
PASS :white_check_mark:

msvc.Release
logfile
1181 cases, 0 failed, t: 428s
PASS :white_check_mark:

gcc.Release -Dassert=ON, MANUAL_TESTS=true
logfile
no test results, t: 246s [BAD EXIT]
FAIL :red_circle:

gcc.Debug -Dcoverage=ON, TARGET=coverage_report, SKIP_TESTS=true
logfile
no test results, t: 188s [BAD EXIT]
FAIL :red_circle:

docs, TARGET=docs
logfile
1 cases, 0 failed, t: 0m1s
PASS :white_check_mark:

clang.Debug
logfile
no test results, t: 126s [BAD EXIT]
FAIL :red_circle:

gcc.Debug
logfile
no test results, t: 167s [BAD EXIT]
FAIL :red_circle:

clang.Release -Dassert=ON
logfile
no test results, t: 519s [BAD EXIT]
FAIL :red_circle:

gcc.Release -Dassert=ON
logfile
no test results, t: 240s [BAD EXIT]
FAIL :red_circle:

gcc.Debug -Dstatic=OFF
logfile
no test results, t: 176s [BAD EXIT]
FAIL :red_circle:

gcc.Debug -Dstatic=OFF -DBUILD_SHARED_LIBS=ON
logfile
no test results, t: 176s [BAD EXIT]
FAIL :red_circle:

gcc.Debug, NINJA_BUILD=true
logfile
1181 cases, 0 failed, t: 3m0s [BAD EXIT]
FAIL :red_circle:

Without having looked hard at the change yet, it seems like these changes will effect payment calculations.  Do we need an amendment to control the switchover?

@scottschurr These changes do not effect payments; they only effect the new offer crossing code (ref: https://github.com/seelabs/rippled/blob/qualityUpperBound/src/ripple/app/paths/impl/StrandFlow.h#L531-L538). As that code isn't active (and I'm not even sure the offer crossing would be effected by this bug) I don't believe this needs an amendment.
Note: I do intend to use this in some upcoming payment code.

Codecov Report

Merging #3053 into develop will increase coverage by 0.02%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop    #3053      +/-   ##
===========================================
+ Coverage    68.94%   68.97%   +0.02%
===========================================
  Files          688      688
  Lines        55743    55755      +12
===========================================
+ Hits         38433    38455      +22
+ Misses       17310    17300      -10

Impacted Files
Coverage Δ

src/ripple/app/paths/impl/Steps.h
84% <ø> (ø)
:arrow_up:

src/ripple/app/paths/impl/BookStep.cpp
84.98% <100%> (+2.42%)
:arrow_up:

src/ripple/app/paths/impl/DirectStep.cpp
79.82% <100%> (+0.34%)
:arrow_up:

src/ripple/app/paths/impl/XRPEndpointStep.cpp
80.64% <100%> (-0.16%)
:arrow_down:

src/ripple/protocol/Quality.h
97.01% <100%> (+0.93%)
:arrow_up:

src/ripple/app/paths/impl/StrandFlow.h
84.45% <100%> (+0.06%)
:arrow_up:

src/ripple/core/Stoppable.h
93.75% <0%> (-6.25%)
:arrow_down:

src/ripple/core/impl/Workers.cpp
98.93% <0%> (-1.07%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06c3715...274b46d. Read the comment docs.

@scottschurr @thejohnfreeman Took care of the last few issues and re-based on the latest develop.

@scottschurr Good feedback, thanks! I addressed them all in 4f655c917 * [fold] Add missing include, cleanup comments, & minor code cleanups:

FWIW, the clang-5 Travis build (only) is failing.  Here are the complaints:
In file included from ../../src/test/unity/app_test_unity2.cpp:33:
../../src/test/app/TheoreticalQuality_test.cpp:369:55: error: suggest braces around initialization of subobject [-Werror,-Wmissing-braces]
            std::array<Account, numAccounts> accounts{alice, bob, carol, dan};
                                                      ^~~~~~~~~~~~~~~~~~~~~~
                                                      {                     }
../../src/test/app/TheoreticalQuality_test.cpp:447:17: error: suggest braces around initialization of subobject [-Werror,-Wmissing-braces]
                alice, bob, carol, dan, oscar};
                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
                {                            }
2 errors generated.

Looks like we need double braces to initialize a couple of std::arrays in order for clang-5 to be happy.

Thanks @scottschurr I fixed clang 5 CI failures with in the 61aa2e8bd * qualityUpperBound [fold] Fix clang 5 warnings patch.

Hmmm.  Clang-5 is good now.  Thanks @seelabs. Now the unit tests for the two debug Windows builds are failing.  Parallel unit test problems?  I'm not sure...

@scottschurr The current beta has similar windows issues. I'll wait until those are resolved and see if they resolves these as well (I suspect they will)


PageView with BottomNavigationBar the default page init method not invoke.

Sorry for bother, But I am runing into a seriously problem, I have 3 pages of BottomNavigationBar, but the initial page , the initial method not runing at all.
 List<Widget> pageViewChildren = [
    new MySessionPage(),
    new ContactsPage(),
    new MorePage(),
    // new CupertinoNavigationDemo(),
  ];

....

@override
  Widget build(BuildContext context) {
    return new Scaffold(
      body: new PageView(
          children: pageViewChildren,
          controller: pageController,
          onPageChanged: onPageChanged),
      bottomNavigationBar: new BottomNavigationBar(items: [
        new BottomNavigationBarItem(
            icon: new Icon(Icons.chat),
            title: new Text("聊天"),
            backgroundColor: Colors.orange),
        new BottomNavigationBarItem(
            icon: new Icon(Icons.people),
            title: new Text("联系人"),
            backgroundColor: Colors.orange),
        new BottomNavigationBarItem(
            icon: new Icon(Icons.settings),
            title: new Text("更多"),
            backgroundColor: Colors.orange),
        // new BottomNavigationBarItem(
        //     icon: new Icon(Icons.settings),
        //     title: new Text("测试"),
        //     backgroundColor: Colors.orange),
      ], onTap: onTap, currentIndex: page),
    );
  }

The frist page is the default page, but it's inital method are not runing at all.

Sorry, I'm having a little trouble understanding exactly what the problem is.
Not sure what you mean by "initial method", not clear about what the BottomNavigationBar has to do with the problem.
Are you saying that if you create a PageView with 3 StatefulWidget children, the first child's initState() method doesn't run?

Dumb I am! The Children page running before this page cause I called a new SessionPage()


Add content/en/role-based access control(RBAC)

Signed-off-by: Julia Furst Morgado<EMAIL_ADDRESS>Describe your changes
Added new term: Role-based access control (RBAC)
Related issue number or link (ex: resolves #issue-number)
resolves #1465
Checklist before opening this PR (put x in the checkboxes)

[x] This PR does not contain plagiarism

don’t copy other people’s work unless you are quoting and contributing it to them.

[x] I have signed off on all commits

signing off (ex: git commit -s) is to affirm that commits comply DCO. If you are working locally, you could add an alias to your gitconfig by running git config --global alias.ci "commit -s".

@juliafmorgado I like it. Short and on point :)
lgtm

ok that too fast. @juliafmorgado spellcheck fails, can you please add the words to the list :)

My general concern is that the definition does not reference application control since RBAC refers to an application's access to resources within the system.
This definition should include RBAC enabling the creation of permissions for users AND workloads to act within an environment. By having hardened default RBAC controls, you can limit the ability of malicious actors or misguided operations teams from "breaking out."
While limiting its attackers, it also lets organizations scale efficiently through grouping permissions and hardened defaults.

+1 for adding workloads/applications and not only restricting RBAC to users/groups.
The aspect of scaling efficiently is something I never thought of before. This could be something that we should incorporate.
We could say that before RBAC, permissions would have to be given to each user separately, which is error-prone and does not scale. Using RBAC kind of standardizes that, which results in better scaling and hardening.

Great! Can you add that as "committable" suggestions? It did feel a little simplified overall.

Thanks @juliafmorgado and sorry that it is so much back and forth going on. This is a perfect example of how we need to pay attention to all small details because we aim to be a go-to point for cloud native terms. This is a huge responsibility. However, I feel that we could now merge it. What do you think @CathPag? Some editing needed?


add: support to set and reset genbank location types in a round trip

Closes #166
Relevant Issue created in SBOL-Specification repo: https://github.com/SynBioDex/SBOL-specification/issues/491
The issue regarding the pySBOL3 bug on providing identity to Location class: https://github.com/SynBioDex/pySBOL3/issues/414
Bug Fix for the above issue merged by @tcmitchell: https://github.com/SynBioDex/pySBOL3/pull/415
Changes:
Inappropriate GenBank Locus names for SBOL's display id:

There are cases wherein GenBank locus names that are loosely created don't conform to SBOL's requirements for them being display_ids of SBOL3 components (i.e: strings being alphanumeric and not starting with a number). Thus, directly storing locus names as display_ids of components led to parsing errors begin thrown by SBOL3.
To resolve this, we use SBOL's string_to_display_id() method which conveniently converts a string to conform to SBOL's requirements by either substituting non-alphanumeric characters with alphanumeric characters or removing them.
However, we also store the original Locus name in a separate string extraneous property field in the extended GenBank component class, which is reset back during a round-trip conversion.
A unit test for the same has been added along with the test-files

Feature Location Endpoints Types:

GenBank Feature Locations support the starting and ending points to be "fuzzy" or "exact"; i.e, the endpoint can be exact or denote that all points after that point are valid endpoints. Similarly, the start point can be exact or denote that all points before that point are valid start points.
This type of location endpoint is not currently supported by SBOL3, as a workaround we store all such features having "fuzzy" features separately as extraneous property of a component, using the Component_GenBank_Extension's fuzzy_features field, which is an OwnedObject ListProperty, which can store the list of all such fuzzy features.
The reason behind not storing these features directly in SBOL3 SequenceFeatures is that in the absence of an SBOL3 field depicting the "exactness" or "fuzziness" of a location endpoint, the stored feature would be incompletely or inaccurately interpreted.
With respect to this shortcoming, an issue has been created in the SBOL-Specification Repo to consider adding support to store fuzzy endpoints in Feature Locations here.

Round-tripping Fuzzy Features:

Although conversion from GenBank to SBOL3 would "ignore" (store separately as extraneous property) features with fuzzy location endpoints, in a round trip, we need to preserve the features as the final GenBank output must be identical to the supplied file.
For this purpose, the "Range" object has been extended as Range_GenBank_Extension, which stores start_position and end_points Integer fields, which are mapped to their corresponding GenBank Location Type operators (BeforePosition, ExactPosition, AfterPosition), using maps defined in the main converter class.
SBOL_LOCATION_POSITION and GENBANK_LOCATION_POSITION map these integers to and from their GenBank operators. Also, a build_range_extension helper method is created to register the builder for this custom extension on the URI sbol3.SBOL_RANGE.
The feature handling helper methods then keep track of GenBank features having fuzzy locations and store them in the extraneous "fuzzy_features" property instead of the corresponding SBOL3 component's features.
In the round trip to GenBank, all features (every SBOL3 component's features, and all fuzzy_features) are considered to be converted to GenBank.

TODO:

[x]  Extend SBOL's Location class instead of Range class to store extraneous fuzzy features.
[ ]  Remove the temporary workaround for the pySBOL3 bug once a new release is made.

I've looked at the code and it looks good to me. I haven't yet seen a change that addresses the change requested by @jakebeal so I am holding off on approval.
I thought the handing of fuzzy features was clear, and I thought the handling of the genbank name vs. SBOL display id was clear. Nice job coding those up!

@tcmitchell @jakebeal With the workaround implemented (and noting it to be removed once a new pySBOL3 release is made), and the handling of improper display ids from GenBank in place, I think this PR is good to merge

@tcmitchell @jakebeal the redundant comments are removed, and I have also added a commit after running an autopep8 formatted on the whole converter file code as well. This should be good to merge.


this.$modal.modal is not a function

Hello! I've been developing a feature for a project using ng2-bs3-modal, and when getting ready to merge to master I've run into this error when trying to open modals:
TypeError: this.$modal.modal is not a function
    at ModalInstance.show (modal-instance.js:37)
    at ModalInstance.open (modal-instance.js:15)
    at ModalComponent.open
I've looked at some other similar issues but haven't been able to fix this yet. I'm not sure if it's directly related to this module or something else, but it would be great if someone could be able to give me a nudge in the right direction.

Thanks in advance, and sorry if this is not the right place for this issue or if relevant information is missing!

This typically occurs if the bootstrap javascript is missing or hasn't been loaded before your modal code. Your html snippet above, is it from the head? Are you seeing any http errors in your dev tools (404, etc)?

All of this was from the head, yes.
I've done some more experimenting with the order of various scripts after I read your answer, and it appears that the problem was from some external libraries (related to an odoo module, im_livechat, that we're trying to interface with).
Apparently, having these two lines:
<script type="text/javascript" src="/static/im_livechat/external_lib.js"></script>
  <script type="text/javascript" src="/static/im_livechat/loader/3"></script>

after loading the bootstrap javascript was what was causing the problems. I've bumped them above my line that loads bootstrap.min.js and now it seems to be working.
So, all in all, I guess I should have just tried a bit harder, as this doesn't seem to be really related to ng2-bs3-modal. Sorry for the unnecessary posts and thank you for your time!

No problem, glad I could be of some help!

Better solution will be
Install jquery and bootstrap in your project
npm install jquery
npm install bootstrap
then import both in the file (for eg model-view.component.ts) where you are using this modal
import 'jquery';
import 'bootstrap';
For me this worked flawlessly :)

Ankita-Jaiswal - thanks, it helped me a lot!

@Ankita-Jaiswal  I am facing same issue. I have included both jquery and bootstrap in my angular project but still it is not working.


should timestamps() set default values for updated_at and created_at?

I would expect this to be the case however it currently does not behave in this manor manner.

:+1:

this was funny, thanks


"Connection timeout has expired" error occurs often and crushes the application

The error is expected, but I agree it should not crush the application.


Strange behavior in File-list

Describe the bug
On the staging instance, there are loading errors in the file.
In the file menu bis a file that hidden at irregular intervals and reappears after a short time.
How to Reproduce
Mediafiles:

Navigate to the mediafiles
upload a file
open a new tab
navigate to motion-list > motion
create a poll
the mediafile in the other tab vanish until a new sutoupdate from the mediafiles come in

Expected behavior
Files should not be appear and disappear.

This seems to be fixed https://github.com/OpenSlides/openslides-client/pull/3839

This is reliable reproducible like this:

Open meeting mediafiles
Open another tab
Upload orga mediafile