rspamd: 2.6 -> 2.7

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/rspamd/versions.
meta.description for rspamd is: "Advanced spam filtering system"
meta.homepage for rspamd is: "https://rspamd.com"
meta.changelog for rspamd is: ""
Updates performed

Version update

To inspect upstream changes

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 2.7 with grep in /nix/store/38a4cbcx30jk9b14dwpv4lbxs8ppkknx-rspamd-2.7

directory tree listing: https://gist.github.com/7d4d27237c2efb9abb35bc22564c666d

du listing: https://gist.github.com/fb421ca5d666ce1083a336223b84ca43

Rebuild report (if merged into master) (click to expand)

3 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
1 i686-linux rebuild(s)
0 x86_64-darwin rebuild(s)
1 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
rspamd

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/38a4cbcx30jk9b14dwpv4lbxs8ppkknx-rspamd-2.7 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A rspamd https://github.com/r-ryantm/nixpkgs/archive/858d02495ac254d7dd0afd6b4595130ee0355f0c.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/38a4cbcx30jk9b14dwpv4lbxs8ppkknx-rspamd-2.7
ls -la /nix/store/38a4cbcx30jk9b14dwpv4lbxs8ppkknx-rspamd-2.7/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

rspamd

Maintainer pings
cc @avnik @fpletz @globin for testing.

Result of nixpkgs-review pr 115541 run on x86_64-linux 1

1 package built:

rspamd


dg-common helpers are not dg specific

There are a lot of Scala helpers which are not specific to DG, for instance DateHelper and IntHelper.  We should remove them, making sure there are no dependencies elsewhere in DG
@SamerAdra - please provide a list of the functions you want to remove as a comment to this issue

Resolved by PR: https://github.com/FINRAOS/DataGenerator/pull/277


Add support for proxy in S3FileSystem

The AWS C++ S3 Client does not automatically pick up
http proxy configurations set at the OS environment
level using the HTTP_PROXY, HTTPS_PROXY and
NO_PROXY environment variables.
The AWS Java S3 Client does.
The environment variables themselves can be
lower case and upper case. If both versions are provided
then the lower case values take precedence.
The following is supported:

http_proxy/HTTP_PROXY, https_proxy/HTTPS_PROXY
and no_proxy/NO_PROXY environment variables are read.
The NO_PROXY content is scanned for exact and
suffix matches.
CIDR expressions provided in NO_PROXY
are not supported for matching.
IP addresses or domains can be specified.
NO_PROXY list is comma separated.
Use . or *. to indicate domain suffix matching, e.g.
.foobar.com will match test.foobar.com or
foo.foobar.com.

A new a new hive config variable “hive.s3.use-proxy-from-env”
is added to enable reading the environment variables if present.
The default is false.

@majetideepak PLease take a look when you get a chance. I made some additional changes since you last looked.

Tested manually using the S3FileSystemTest.writeAndRead using tinyproxy listeneing at the port with user/password set in HTTP_PROXY in this test. The only change to the test is allowing the proxy config to be used by overriding the hive.s3.use-proxy-from-env to true.
  auto hiveConfig = minioServer_->hiveConfig({{"hive.s3.use-proxy-from-env", "true"}});

@pedroerp can you please help review/merge this? Thanks.

Thanks, @czentgr

@majetideepak Thank you for the review!


Harvest should support per-instance queries to allow cherry picking from large groups

For example: you want to monitor these five qtrees or snapshots and ignore the others

REST supports this kind of filtering, ZAPI does not

Closing this one, duplicate of #868


Carson/testing nits

Internal API overhaul to make using in NodeJS about 1000x easier. Plus some things found while testing.

@asutula is off today, so I'm going to merge with the one approval. @asutula I still recommend you take a look at some point.


yttadd ignores duration and always add 1h

https://github.com/bullshitsoftware/youtimetrack/blob/2b8b4d2e56c2ab6f41ad510c767bd3d95fec38bc/internal/pkg/youtrack/youtrack.go#L109-L114

Fixed in v0.1.1

Thanks!


Compute verification code for artifacts

This requires updates to SPDX to handle symbolic links (broken and otherwise).

Resolved in v0.1.9


why class-agnostic?

Beyond bounding box regression for simplicity,more importantly do the class-agnostic model occupy less the  memory of gpu,and train faster too ?

Yes. If we didn't use class-agnostic, the bbox_regression layer would have 8147*7=15876 channels. What's more, using class-agnostic doesn't have a big impact on the performance.


[Enhancement] UX:  As we populate API and header the api_key must also be populated dynamically

Steps to reproduce

Add an API with api_key
Noe click on save as datsource
and observe

Observation:
it is observed that the Auth does not get populated however, the API data gets populated
Expectation:
Since the API data contains the Auth Type and considered key we can populate the data like we populate the API and the header

@prapullac can you add more details. Not able to understand this exactly

@Nikhil-Nandagopal
Please find the video :
https://www.loom.com/share/07fd248ac134476a985e20eedf3c2722
The API_Key is attached inside the cURL / API yet we ask the user to add it explicitly when it is converted to API data source

Got it. This is actually a duplicate of #4568
It doesn't show because we don't have a query params section.
We also can't detect the apikey because it can be added as any field


Fix service shell test

This test couldn't even start with v1 API before this change.
After this change I've run it 3 times and it passed (although I think we should not move it out of flaky suite yet).
Ref #10127 #9312
cc @quinton-hoole @davidopp @thockin

Also - we should migrate this test to .go test, but this should be done after 1.0.

cc @gmarek

LGTM

Because:

this PR only touches "services.sh" shell e2e test
this test didn't passed even once during last over 200 runs
I'm going to merge this PR now to improve the situation.


Update the Equinor fonts in the CDN

We will have to update the fonts in Figma first, but there are some limitations to what’s possible to do in Figma (no support for variable fonts) – so we need to do some tuning in code that’s not possible to do in Figma. I still put this as dependent on the Figma issue since the question of how to use the monospace font needs to be clarified before we do anything.
We also need to figure out how to solve versioning, how to prevent fallback to local versions of the old fonts and how to decrease the file size of the fonts. We now have one file with all the fonts, as well as individual files for each font. My gut feeling is that most projects download more font-files than they use, so maybe we should add two more files – one for uprights and one for italics for example, since we don’t use italics in the design system.
We’ve also received a request from users in our Slack channel to include the font-display property using the fallback value, so we need to do some testing on that.
The fonts are uploaded to the EDS Core Teams channel. I’ve received the files in several emails, so it’s a bit of a mess. I’ll talk to the person in charge once he’s back from holiday in week 32 to make sure we have the latest version of all the files.
CC: @mimarz, @pomfrida, @spcttre, @ErlendAHall

The new fonts are uploaded to the CDN. I’m a bit hesitant about replacing the individual font-files with the new variable fonts since we don’t know how variable fonts are handled in all the apps that use the fonts from the CDN, so I’ve added some new css-files in addition to the original ones. I don’t think we need to update the private NPM packages on Github as nobody seem to use them. Even though users have the option of just using one of the fonts and not the entire package, my gut feeling is most users download all the fonts. Since we only use the uprights in the EDS I’ve made separate files for uprights and italics. The variable fonts are also split into two files even though technically it could have been one. (Since the italic fonts are really oblique and not italic, meaning they’re electronically slanted, that too could have been an axis in the variable font similarly to font weight.)
Users now have the following options:

equinor-font.css (all 8 fonts)
equinor-light.css
equinor-regular.css
equinor-medium.css
equinor-bold.css
equinor-lightitalic.css
equinor-mediumitalic.css
equinor-bolditalic.css
equinor-uprights.css (new, only the uprights)
equinor-italics.css (new, only the italics)
equinor-font-vf.css (new, uprights and italics)
equinor-uprights-vf.css (new, only uprights)
equinor-italics-vf.css (new, only italics)

Since the fonts are new, we need to prevent the browser from falling back to locally installed versions of the font – so I’ll re-introduce the unicode smiley as the local font name, unless there are new techniques that solve the same problem. The font-display property is not implemented yet, I thought I’d create a couple of copies of the variable fonts with different settings to see if “fallback” is the best option.

I’ve added font-display: fallback to

equinor-uprights-vf.css
equinor-italics-vf.css
equinor-uprights.css
equinor-italics.css

I’ve also added a reference to a non-existing local font to prevent the previous version of the font to take precedence on Equinor PCs. This is based on an old technique by Paul Irish that I used back in the day. As far as I can tell this is still the best way to prevent local fonts from being loaded in the browser. If anyone has some new information that proves this to be wrong please let me know.
For the EDS components I recommend using equinor-uprights-vf.css since we don’t use italics in any components. This file favours woff2 with a fallback to woff and finally the regular woff font. That means that for users with browsers that don’t support variable fonts, all the text will be displayed with Equinor Regular. Since we only support evergreen browsers anyway I think this is an acceptable solution.
@font-face {
    font-family: Equinor;
    src: local('😊'),
        url(//eds-static.equinor.com/font/EquinorVariable-VF.woff2) format('woff2-variations'),
        url(//eds-static.equinor.com/font/EquinorVariable-VF.woff) format('woff-variations'),
        url(//eds-static.equinor.com/font/Equinor-Regular.woff) format('woff');
    font-style: normal;
    font-weight: 1 999;
    font-display: fallback;
}

Hi, we test the new font equinor-uprights-vf.css and works just fine, but we realized that when the font-weight is different than 400 (Equinor-regular) the font looks a bit different, we saw this with our tests through a visual regression tool. The differences are minimum so perhaps they are ok.
For example:
eds-static.equinor.com/font/Equinor-Medium.woff2 -> That is font-weight: 500
Doesn't have the same result as:
https://eds-static.equinor.com/font/equinor-uprights-vf.css -> with font-weight: 500
The differences are mark with yellow and red on the Difference picture and are based on the Reference picture
Example using the accordion header that uses font-weight 500
Reference (using https://eds-static.equinor.com/font/equinor-font.css):

Difference (Using https://eds-static.equinor.com/font/equinor-uprights-vf.css):

Another example with the button that also uses font-weight 500:
Reference (using https://eds-static.equinor.com/font/equinor-font.css):

Difference (Using https://eds-static.equinor.com/font/equinor-uprights-vf.css):

Another example using a Menu component:
Reference (using https://eds-static.equinor.com/font/equinor-font.css):

Difference (Using https://eds-static.equinor.com/font/equinor-uprights-vf.css):

That’s very interesting, it should be the same – thanks for the feedback 👍🏻 Are you sure you use the new fonts and not local ones? I’ve added a mechanism to prevent the browser from using a local fallback as noted above, but I haven’t done that for all the font-files yet. I’ll update the rest of the files too, then maybe you could try again and see if the difference is still there. I would expect a difference between the old and new fonts, but not between the individual font-files and the variable font-files.

Yes every test is using the different fonts, at the end the tests are running in different instances of a docker through a headless chrome, so every tests runs without any local data (or it should run without).
Old version gets the fonts from: https://eds-static.equinor.com/font/equinor-font.css
new version gets the fonts from: https://eds-static.equinor.com/font/equinor-uprights-vf.css
Also cleaning cache and using my own vision i can even notice the small differences.


Add check_boot_security

Macs equipped with a T2 chip support secure boot at three security levels:

Full
Medium
No Security

If possible mOSL should audit this settings and fail if security level is not Full or Medium.

As far as I can tell this isn't possible via bash. Closing for now.


AssertionError: Strided Slice case not handled

I have tried to convert the model given in the README.md. The following code raises an exception.
---------------------------------------------------------------------------
AssertionError                            Traceback (most recent call last)
<ipython-input-15-e92eef8ff752> in <module>()
     21         green_bias=-128,
     22         blue_bias=-128,
---> 23         image_scale=1/128.0)

/Users/a123/Documents/projectDL/tf-coreml/tfcoreml/_tf_coreml_converter.py in convert(tf_model_path, mlmodel_path, output_feature_names, input_name_shape_dict, image_input_names, is_bgr, red_bias, green_bias, blue_bias, gray_bias, image_scale, class_labels, predicted_feature_name, predicted_probabilities_output)
    491       class_labels=class_labels,
    492       predicted_feature_name=predicted_feature_name,
--> 493       predicted_probabilities_output=predicted_probabilities_output)

/Users/a123/Documents/projectDL/tf-coreml/tfcoreml/_tf_coreml_converter.py in _convert_pb_to_mlmodel(tf_model_path, mlmodel_path, output_feature_names, input_name_shape_dict, image_input_names, is_bgr, red_bias, green_bias, blue_bias, gray_bias, image_scale, class_labels, predicted_feature_name, predicted_probabilities_output)
    289   context.input_feed_dict = input_feed_dict
    290   context.skip_ops = skip_ops
--> 291   convert_ops_to_layers(context)
    292   sess.close()
    293

/Users/a123/Documents/projectDL/tf-coreml/tfcoreml/_ops_to_layers.py in convert_ops_to_layers(context)
    146         print('%d/%d: Converting op name: %s ( type:  %s )' % (
    147             i+1, len(context.all_ops), op.name, op.type))
--> 148         translator(op, context)
    149       connect_skipped_ops(context)

/Users/a123/Documents/projectDL/tf-coreml/tfcoreml/_layers.py in strided_slice(op, context)
   1184     skip(op,context)
   1185   else:
-> 1186     assert False, 'Strided Slice case not handled'
   1187   context.translated[output_name] = True
   1188

AssertionError: Strided Slice case not handled

I see the stridedslice has implement.  what happen to it ?

Not all configurations of StridedSlice are supported (reflected in the asterisk beside this op mentioned in the readme.md).
Which model from the Readme.md file are you trying to convert?

This issue is being closed due to inactivity preceeding the request for an update. This operator has been extended in Core ML 3, feel free to try it out. Thanks!


Add Dark LookAndFeel

RText lets users add their own LookAndFeels, but it would be nice if it shipped with one OOTB, likely Darcula or something based off of it since it's nice-looking, simple, and based off of BasicLookAndFeel so isn't likely to cause trouble.
Bonus points if it integrates with the upcoming "theme" spport.

The Darcula theme was added in the last release, and it does indeed integrate with the "theme" support.  Thus I'm closing this ticket.


For some reason [chunkhash] is not replaced for css files

For some reason [chunkhash] is not replaced for css files. And that causes this issue for me https://github.com/GoogleChromeLabs/size-plugin/issues/17

@smashercosmo Need a bit more info to debug this - how are you generating the CSS files? If you're using a plugin like extract-text-plugin or mini-css-extract-plugin, can you paste the plugin options you're using?
Also it'd be helpful to know if you have any output options set in your webpack configuration.
Cheers.

@developit This happens because stripHash fails the regex check for css files as it uses top level output.filename/output.chunkFilename and mini-css-extract-plugin defines it's own filenameTemplate (check here)


Custom 404 page no longer working

Somewhere in the latest code changes we broke the custom 404 page functionality. Cloudflare now always returns an empty 404 page. For example on https://head-start.pages.dev/nl/aapje:

@decrek do you have any idea how this issue was introduced? Maybe in the recent upgrade to newer Astro + Cloudflare adapter?


Any plans to support ColQwen2 + Similarity Maps?

Hi there,
I recently came across this tweet regarding ColQwen2 + Similarity Maps from @tonywu71https://x.com/tonywu_71/status/1846870432831402315
Just wondering if there are plans to support these?
Many thanks for any help, and this amazing work/lib!

Confirmed for others, I updated the colpali-engine and colqwen is off to the races!

ColQwen2 is indeed easy to support and is something we absolutely want in byaldi (and we do have now, I just forgot to reply to the issue...)
As for the similarity maps, I think that's something we don't necessarily want to support to keep the core APIs lightweights, but a contribution on how to use the byaldi API to get embeddings for it and generate the same maps would be a great cookbook to add to our examples :)
Thanks @tonywu71 for answering the issue in the first place 😄


chore: remove macos build for Go 1.14

Closing this until we figure out the support for FUSE in macOS versions after Catalina.


Update sql-database-user-error-recovery.md

Updated the restore section to include note about needing enough capacity on the server to restore.

Hi @elfisher, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no contribution license agreement is required at this point. Real humans will now evaluate your PR.

TTYL, AZPRBOT;

Updated this article to make sure people are aware of Server Quota limits when restoring.

@elfisher
Please remove the locale indicator "en-us" from links. For guidance, see https://github.com/Azure/azure-content-pr/blob/master/contributor-guide/create-links-markdown.md
Thanks.


Is it possible to add attributes to "instrumentation scope"?

This OTEP proposed to add attributes to instrumentation scope.
This issue is a question for the maintainers of this repo: are we able to do this in a non-breaking manner and without significant performance impact?

It is feasible in a non-breaking way since we already use an object as options for the Tracer (here) and Meter (here) because we already had the issue for the schemaUrl addition.
I don't think this will have much impact in term of performance too
cc @open-telemetry/javascript-maintainers

Since the OTEP is merged, I think this issue can be closed


My panoramic pictures were cut off when loaded onto my post.

Expected behavior
I've loaded this type of picture on the steemit platform.   Usually it'll load the entire picture and just shrink it slightly so the entire thing is visible on the post.
Actual behavior
When the picture loaded it was zoomed into the center.   I thought maybe it would change once posted,  but it posted just add displayed.

https://www.imageupload.co.uk/images/2017/10/25/Screenshot_2017-10-25-07-32-21.png That's what I thought they would look like
How to reproduce

Browser: chrome
Operating system:
Samsung galaxy mini 4

They all loaded cut off

Can you add a link to the post?

espoem, i saw you needed the link to dreamingirwin's post.
Here it is... https://steemit.com/life/@dreamingirwin/jump-off-in-stratford-ct-is-a-cool-place-to-bring-the-kids

Sorry guys.   I edited my post using steemit and reposted it with the updated pictures.   I only left one of the original pictures,  That were loaded through busy on the post.  Most of them loaded indirectly,  and the post couldn't stay that way.  Sorry for not seeing the comment.

Incorrectly

@dreamingirwin hey, I posted those images from Busy and I think they are displayed properly:
https://busy.org/test/@hellosteem/test-post-897

I can't see any bug on our side. I will close it due to inactivity.


3.46.0: Adds new SDK versions and contract files

Pull Request Template
Description
This bumps the SDK GA version from 3.45.2 to 3.46.0 and preview version from 3.46.0-preview.2 to 3.47.0-preview.0. No changes in the public GA contract and preview contract. The images are given below:

## Type of change

[X] New feature (non-breaking change which adds functionality)

Closing issues
To automatically close an issue: closes #IssueNumber

No changes in the public GA contract. The preview contract changes are given below:

Curious - Are there any changes in the preview contract ? The screenshot doesn't show any. If there are none, can you please fix the description ?

No changes in the public GA contract. The preview contract changes are given below:

Curious - Are there any changes in the preview contract ? The screenshot doesn't show any. If there are none, can you please fix the description ?

Updated the comment. No changes in preview as well.


remove extra 0 on ehcache dependency

Please review my change on POM.xml, I only change the version number of ehcache.
I tried to run the latest test a few minutes ago and maven keeps showing me errors.
It disturbing for a while but I found the version number was not match with Maven Repository, and it's good after I remove that.

It works fine today, so weird.
I'm sorry cause you any inconvenience.

No worries.


Showcase Submission for 171-wave-function-collapse

Thank you F9Mute for your contribution! A member of the Coding Train team will review it shortly.

Wave Function Collapse in Processing4
F9Mute

This is so great!!


Task: add CI checks for settings migrator DAGs

🧰 Task

after the settings migrations added in #4086,  we should add a CI check to make sure that none of the known migrator decorators in napari/settings/_migrations create a DAG in the migration tree (e.g.  0.2 -> 0.3,  0.3 -> 0.4, and 0.2 -> 0.4)
h/t cc @Carreau

To add from the meeting, the reasoning is there is no reason to have a dag, and we should always have a tree where all path lead to current version.
If there is A->B and B->C, the only reason to add A->C is if A->B->C is broken.
In which case A->B should never run, and the A->B migrator should be deleted.
I don't think it's high priority, but would still be nice to have, and is a good first issue if you are looking to contribute.


HIVE-28631: Close opened iterables in HiveDeleteFilter to stop resource leak.

Why are the changes needed?
The Iterables created in HiveDeleteFilter are CloseableIterators and it actually opens multiple files during iteration, if left behind especially without finishing iteration it leaves opened resources behind.
Does this PR introduce any user-facing change?
No.
Is the change a dependency upgrade?
No.
How was this patch tested?
Tested by deploying this change in a cluster and running a large merge query accessing files in HiveDeleteFilter across multiple mappers.

this method is not even called upstream!

I'm sorry, I do not understand which method is not called upstream? close or filterBatch?

This method is not even called upstream!

I'm sorry, I do not understand which method is not called upstream? close or filterBatch?

CloseableIterator#close(). Instead CloseableIterable#close is invoked.
I've refactored the IcebergRecordReader#nextKeyValue not to use iceber's CloseableIterable.concat and looking into positional-delete readers leak - seems to be some race condition in deletes loading.
I can repro the issue locally, and I do not see how proposed change even supposed to help. deleteInputIterable is just a closeable wrapper over srcIterator, and deleteOutputIterable is the result of filter transform on the same srcIterator. Closing srcIterator should be enough to release the data-files connection.

This method is not even called upstream!

I'm sorry, I do not understand which method is not called upstream? close or filterBatch?

CloseableIterator#close(). Instead CloseableIterable#close is invoked. I've refactored the IcebergRecordReader#nextKeyValue not to use iceber's CloseableIterable.concat and looking into positional-delete readers leak - seems to be some race condition in deletes loading.
I can repro the issue locally, and I do not see how proposed change even supposed to help. deleteInputIterable is just a closeable wrapper over srcIterator, and deleteOutputIterable is the result of filter transform on the same srcIterator. Closing srcIterator should be enough to release the data-files connection.

Thank you for the clarification, yes you are right. This patch is not required for master. I do not know if there is a leak in the master, I'll close this ticket and patch.


chore(deps): upgrade dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-dependencies-1.x" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 992

Questions ?
Please refer to the Backport tool documentation


Enhancing User Interface

improving the scrolling
making changes in the interface

@DeepRahangdale
Not sure what exactly you mean?
The interface seems to work well on all resolutions, I just tested right now.

Feel free to open a pull request and I'll gladly take a look.


Long Time To Disable Something

it is about 30+ minutes to disable scheduled tasks

@AllRun1 - Can you try the latest version of the GUI script? It should not take this long.


Sharding on forked ledgers is broken before ledger 32570

https://github.com/ripple/rippled/blob/eaff9a0e6aec0ad077f118501791c7684debcfd5/src/ripple/nodestore/Types.h#L53
This variable prevents rippled from storing pre-32570 ledgers in a shard database. This is likely due to the unavailable ledgers from late 2012 on XRPL, but not a specific limitation to rippled in general. Please make this setting configurable instead of hard-coding it.

We will sort this out. Thanks for pointing it out.

@MarkusTeufelberger thanks for reporting this. I've addressed the issue here: https://github.com/ripple/rippled/pull/2410

Thanks.
I'm not so sure if it is a good strategy to compile the default of 32570 into the software and require a setting to change it instead of the other way around... but that's up to you.


Execute Terraform commands with -parallelisms=1

Currently the libvirt provider documents to require that, and
it helps anyway to read the logs and get more predictable/reproducible
behavior.
Why is this PR needed?
Does it fix an issue? addresses a business case?
add a description and link to the issue if one exists.
Fixes #
Reminder: Add the "fixes bsc#XXXX" to the title of the commit so that it will
appear in the changelog.
What does this PR do?
please include a brief "management" technical overview (details are in the code)
Anything else a reviewer needs to know?
Special test cases, manual steps, links to resources or anything else that could be helpful to the reviewer.
Info for QA
This is info for QA so that they can validate this. This is mandatory if this PR fixes a bug.
If this is a new feature, a good description in "What does this PR do" may be enough.
Related info
Info that can be relevant for QA:

link to other PRs that should be merged together
link to packages that should be released together
upstream issues

Status BEFORE applying the patch
How can we reproduce the issue? How can we see this issue? Please provide the steps and the prove
this issue is not fixed.
Status AFTER applying the patch
How can we validate this issue is fixed? Please provide the steps and the prove this issue is fixed.
Docs
If docs need to be updated, please add a link to a PR to https://github.com/SUSE/doc-caasp.
At the time of creating the issue, this PR can be work in progress (set its title to [WIP]),
but the documentation needs to be finalized before the PR can be merged.
Merge restrictions
(Please do not edit this)
We are in v4-maintenance phase, so we will restrict what can be merged to prevent unexpected surprises:
What can be merged (merge criteria):
    2 approvals:
        1 developer: code is fine
        1 QA: QA is fine
    there is a PR for updating documentation (or a statement that this is not needed)

Thanks for asking QA to approve.
PR looks good to me.
On a side note: we should insist that the PR template get used as intended if QA has to approve it.

ARM specific. so for later.


upgrade alibi version to 0.6.4

Signed-off-by: Suresh Nakkeran<EMAIL_ADDRESS>This PR is to upgrade the alibi package version to 0.6.4 to fix alibiexplainer tests failure.

/retest

/retest

/lgtm
/approve


Mobile layout issue

The mobile layout is broken on the product page

@dobby-gh-bot translate to french


conv2d gives NaN gradients with float16 input

Environment info
Operating System: Ubuntu 16 LTS
breaks already on CPU
If installed from binary pip package, provide:

A link to the pip package you installed: recent nightly build
The output from python -c "import tensorflow; print(tensorflow.__version__)".

>tf.__version__
'0.12.head'
>tf.__git_version__
'0.12.1-2263-g4cc0d1e-dirty'

If possible, provide a minimal reproducible example (We usually don't have time to read hundreds of lines of your code)
import tensorflow as tf
import numpy as np

slim = tf.contrib.slim

dtype = tf.float16
shape = (4, 16, 16, 3)

inpt = tf.placeholder(dtype, shape, name='input')
net = slim.conv2d(inpt, 16, [3, 3], scope='conv')
loss = tf.reduce_mean(net)
opt = tf.train.AdamOptimizer(1e-3)
train_op = slim.learning.create_train_op(loss, opt)

with tf.Session() as sess:
    sess.run(tf.global_variables_initializer())
    for i in range(2):
        val = np.random.randn(*shape)
        print(sess.run(train_op, feed_dict={inpt: val}))

So basically it breaks on the second step of SGD because loss is NaN. If I change dtype in float32, it works. It should have nothing to do with CUDA, I tested it on CPU version as well as on GPU with CUDA8, CuDNN5.1.
What other attempted solutions have you tried?
I have no idea what to try here. Now I continue with float32.
Logs or other output that would be helpful
(If logs are large, please upload as attachment or provide link).
-0.00072765
Traceback (most recent call last):
  File "/home/lear/kshmelko/.local/lib/python3.5/site-packages/tensorflow/python/client/session.py", line 1022, in _do_call
    return fn(*args)
  File "/home/lear/kshmelko/.local/lib/python3.5/site-packages/tensorflow/python/client/session.py", line 1004, in _run_fn
    status, run_metadata)
  File "/usr/lib/python3.5/contextlib.py", line 66, in __exit__
    next(self.gen)
  File "/home/lear/kshmelko/.local/lib/python3.5/site-packages/tensorflow/python/framework/errors_impl.py", line 469, in raise_exception_on_not_ok_status
    pywrap_tensorflow.TF_GetCode(status))
tensorflow.python.framework.errors_impl.InvalidArgumentError: LossTensor is inf or nan : Tensor had NaN values
         [[Node: train_op/CheckNumerics = CheckNumerics[T=DT_HALF, message="LossTensor is inf or nan", _device="/job:localhost/replica:0/task:0/cpu:0"](control_dependency)]]

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "test_bn.py", line 22, in <module>
    print(sess.run(train_op, feed_dict={inpt: val}))
  File "/home/lear/kshmelko/.local/lib/python3.5/site-packages/tensorflow/python/client/session.py", line 767, in run
    run_metadata_ptr)
  File "/home/lear/kshmelko/.local/lib/python3.5/site-packages/tensorflow/python/client/session.py", line 965, in _run
    feed_dict_string, options, run_metadata)
  File "/home/lear/kshmelko/.local/lib/python3.5/site-packages/tensorflow/python/client/session.py", line 1015, in _do_run
    target_list, options, run_metadata)
  File "/home/lear/kshmelko/.local/lib/python3.5/site-packages/tensorflow/python/client/session.py", line 1035, in _do_call
    raise type(e)(node_def, op, message)
tensorflow.python.framework.errors_impl.InvalidArgumentError: LossTensor is inf or nan : Tensor had NaN values
         [[Node: train_op/CheckNumerics = CheckNumerics[T=DT_HALF, message="LossTensor is inf or nan", _device="/job:localhost/replica:0/task:0/cpu:0"](control_dependency)]]

Caused by op 'train_op/CheckNumerics', defined at:
  File "test_bn.py", line 16, in <module>
    train_op = slim.learning.create_train_op(loss, opt)
  File "/home/lear/kshmelko/.local/lib/python3.5/site-packages/tensorflow/contrib/slim/python/slim/learning.py", line 472, in create_train_op
    'LossTensor is inf or nan')
  File "/home/lear/kshmelko/.local/lib/python3.5/site-packages/tensorflow/python/ops/gen_array_ops.py", line 433, in check_numerics
    message=message, name=name)
  File "/home/lear/kshmelko/.local/lib/python3.5/site-packages/tensorflow/python/framework/op_def_library.py", line 768, in apply_op
    op_def=op_def)
  File "/home/lear/kshmelko/.local/lib/python3.5/site-packages/tensorflow/python/framework/ops.py", line 2402, in create_op
    original_op=self._default_original_op, op_def=op_def)
  File "/home/lear/kshmelko/.local/lib/python3.5/site-packages/tensorflow/python/framework/ops.py", line 1264, in __init__
    self._traceback = _extract_stack()

InvalidArgumentError (see above for traceback): LossTensor is inf or nan : Tensor had NaN values
         [[Node: train_op/CheckNumerics = CheckNumerics[T=DT_HALF, message="LossTensor is inf or nan", _device="/job:localhost/replica:0/task:0/cpu:0"](control_dependency)]]

It is normal to see that float16 doesn't have enough range especially in the beginning of the training. So this is an intended behavior instead of a bug...
If you want to ask around about how to train with float 16, please go to stackoverflow... Thanks.

Are you kidding me or what? How can it not have enough capacity when we start we just one convolution?
Fine, let's modify an example. Choose conv layer with zero weights
net = slim.conv2d(inpt, 16, [3, 3], scope='conv', weights_initializer=tf.zeros_initializer())

and as well zero batch:
        val = np.zeros(shape)

It still fails. Do you imply that float16 does not have enough capacity to backpropagate on zero batch through all zero convolution? It is clearly a bug somewhere in native code. Please reopen this issue, it can't be intended behaviour.

See here:
http://stackoverflow.com/questions/42064941/tensorflow-float16-support-is-broken
Setting the Adam epsilon to 1e-4 works for me.


fix: Allow to delete images when names of images are short digest ids…

… of another images.
"nerdctl rmi " can be run to delete the target images.
However, at the current implementation, the deletion fails when images names are the short digest ids of another images.
The specific behavior is described below, which is how it works in the current implementation.
First, suppose there are alpine and busybox images.
```
> nerdctl images
REPOSITORY    TAG       IMAGE ID        CREATED           PLATFORM       SIZE       BLOB SIZE
busybox       latest    768e5c6f5cb6    3 seconds ago     linux/arm64    4.092MB    1.845MB
alpine        latest    beefdbd8a1da    11 seconds ago    linux/arm64    10.46MB    4.09MB
```

Then, we tag the alpine image using digest id of the busybox image.
```
> nerdctl tag alpine $(dn inspect busybox | jq -rc .[0].RepoDigests[0] | awk -F':' '{print substr($2, 1, 8)}')

> nerdctl images
REPOSITORY    TAG       IMAGE ID        CREATED          PLATFORM       SIZE       BLOB SIZE
768e5c6f      latest    beefdbd8a1da    4 seconds ago    linux/arm64    10.46MB    4.09MB
busybox       latest    768e5c6f5cb6    22 hours ago     linux/arm64    4.092MB    1.845MB
alpine        latest    beefdbd8a1da    22 hours ago     linux/arm64    10.46MB    4.09MB
```

In this situation, running 'nerdctl rmi "$(dn inspect busybox | jq -rc .[0].RepoDigests[0] | awk -F':' '{print substr($2, 1, 8)}')"' will fail to remove the image.
The details of the error are as follows.
```
> nerdctl rmi "$(dn inspect busybox | jq -rc .[0].RepoDigests[0] | awk -F':' '{print substr($2, 1, 8)}')"
FATA[0000] 1 errors:
multiple IDs found with provided prefix: 768e5c6f
```

This issue is reported in the following issue.
- https://github.com/containerd/nerdctl/issues/3016

Therefore, this pull request modifies this so that images can be deleted with "nerdctl rmi " when images names are the short digest ids of another images.

I think the problem runs deep.
I did work earlier on inspect and fixed a bunch of issues, but it is still buggy (my bad obviously).
Also, anything else using the imagewalker seems to have issues as well.
image history is clearly broken.
GetExistingImage might be fishy as well.
A number of other case just assumes that whatever is the first result returned by ImageService().List will be right (with a filter that contains both name=X and digest=^X.* - clearly problematic)
I do have strong feelings against imagewalker tbh (see #3502 ) - and maybe it is time to get done with it.
I appreciate this might be out of scope for this PR though - but for a larger refactor, I would suggest starting fresh with a clearer algorithm, and listing all possible cases, and removing imagewalker in favor of a simpler method that returns a slice.
IMHO image lookup algorithm should do the following:

first call ImageService().List to find an image with that exact name
if above returned nothing, try again ImageService().List, matching the prefix of the digest with the provided needle

An interesting case that is not covered anywhere is when querying using "X", where X is a prefix that actually matches two distinct RepoDigests.
eg:
query using ab
with
image1 sha256:ab19575368743875438
image2 sha256:abef89478445

This is hard to reproduce ^ as you need two distinct images with the first two chars of the digest identical, but it is doable.
... and obviously we should add a boatload of tests.
Anyhow.

Hi, @apostasie
Thanks for many advices!!!
First, I respond to apostasie's comments ,and then I would like to discuss of my future works.
Afrer reviewing the issue and the related PR that apostasie pointed out, I understood the necessity of refactoring imagewalker.ImageWalker to address concurrency issues.
Specifically, I understand that the refactoring should similar to how ListNetworksMatch() is called within network.Remove(), as seen in the following PR.

pkg/cmd/network/remove.go : https://github.com/containerd/nerdctl/pull/3508/files

Future Policies
I think the following is a good policy for the future, is this correct?

Refactor cmd/nerdctl/image/image_remove_linux_test.go (Not Using base.Cmd() etc. Using nerdtest etc.)
Add tests for some scenarios to cmd/nerdctl/image/image_remove_linux_test.go
Refactor imagewalker.ImageWalker based on apostasie's advices 1 and 2

If this is correct, this PR can resolve the issue of removing images with short digest IDs using the nerdctl rmi. However, should I close this PR and focus on addressing points 1 to 3 mentioned above instead?
Questions for comments
I didn't fully understand the following comments, could you please explain them in more details? 🙏
When running nerdctl rmi with a query using "ab", I believe that images like sha256:ab19575368743875438 or sha256:abef89478445
would not match because the regular expressions used with digest IDs in nerdctl rmi are ^sha256:<input id>.*$ and ^<input id>.*$..

An interesting case that is not covered anywhere is when querying using "X", where X is a prefix that actually matches two distinct RepoDigests.
...

If this is correct, this PR can resolve the issue of removing images with short digest IDs using the nerdctl rmi. However, should I close this PR and focus on addressing points 1 to 3 mentioned above instead?

Hey @haytok !
You are welcome.
I think your future direction sounds good.
Nevertheless, feel free to just keep things simple and if your first step is to fix some symptoms, just go for it, it is fine.

Questions for comments
I didn't fully understand the following comments, could you please explain them in more details? 🙏
When running nerdctl rmi with a query using "ab", I believe that images like sha256:ab19575368743875438 or sha256:abef89478445 would not match because the regular expressions used with digest IDs in nerdctl rmi are ^sha256:<input id>.*$ and ^<input id>.*$..

An interesting case that is not covered anywhere is when querying using "X", where X is a prefix that actually matches two distinct RepoDigests.
...

nerdctl pull --platform linux/arm64 alpine
nerdctl pull --platform linux/arm64 ubuntu

nerdctl images | grep -E " b"
ubuntu          latest    b359f1067efa    2 days ago    linux/arm64    110.3MB    28.89MB
alpine          latest    beefdbd8a1da    2 days ago    linux/arm64    9.486MB    4.09MB

So, in that case, what will your code do?
nerdctl rmi b

I think your future direction sounds good.
Nevertheless, feel free to just keep things simple and if your first step is to fix some symptoms, just go for it, it is fine.

Thans !!! OK :)

So, in that case, what will your code do?

Thanks, I can understand what you explained.
nerdctl in my code behaves below.
> _output/nerdctl images
REPOSITORY    TAG       IMAGE ID        CREATED         PLATFORM       SIZE       BLOB SIZE
ubuntu        latest    b359f1067efa    15 hours ago    linux/arm64    108.3MB    28.89MB
alpine        latest    beefdbd8a1da    15 hours ago    linux/arm64    10.46MB    4.09MB

> _output/nerdctl rmi b
FATA[0000] 1 errors:
no such image: b

However, this modification is considered incorrect as the upstream nerdctl behaves as follows.
> nerdctl rmi b
FATA[0000] 1 errors:
multiple IDs found with provided prefix: b

So, as previously advised, it would be better to implement the following.

first call ImageService().List to find an image with that exact name
if above returned nothing, try again ImageService().List, matching the prefix of the digest with the provided needle

Hi, @apostasie
Based on your advice, I updated the logic.
So, could you review when you have time ?
When running nerdctl rmi b in the current implementation, the following actions are performed.
Details

> _output/nerdctl images
REPOSITORY    TAG       IMAGE ID        CREATED               PLATFORM       SIZE       BLOB SIZE
768e5c6f      latest    beefdbd8a1da    2 seconds ago         linux/arm64    10.46MB    4.09MB
alpine        latest    beefdbd8a1da    About a minute ago    linux/arm64    10.46MB    4.09MB
nginx         latest    d2eb56950b84    53 minutes ago        linux/arm64    212.1MB    69.59MB
busybox       latest    768e5c6f5cb6    4 days ago            linux/arm64    4.092MB    1.845MB
ubuntu        latest    d4f6f70979d0    4 days ago            linux/arm64    108.3MB    28.89MB

When there is more than one image with prefix d (d2eb56950b84 and d4f6f70979d0), the following error occurs
I think this behavior is expected.
> _output/nerdctl rmi d
FATA[0000] 1 errors:
multiple IDs found with provided prefix: d

On the other hand, an image with short digest id of another image can be deleted.
> _output/nerdctl rmi 768e5c6f
Untagged: docker.io/library/768e5c6f:latest@sha256:beefdbd8a1da6d2915566fde36db9db0b524eb737fc57cd1367effd16dc0d06d
Deleted: sha256:16113d51b7181f20135f51e8ffbaead20a7671cd783017601f198748ce8a8ebf

> _output/nerdctl images
REPOSITORY    TAG       IMAGE ID        CREATED           PLATFORM       SIZE       BLOB SIZE
alpine        latest    beefdbd8a1da    7 minutes ago     linux/arm64    10.46MB    4.09MB
nginx         latest    d2eb56950b84    59 minutes ago    linux/arm64    212.1MB    69.59MB
busybox       latest    768e5c6f5cb6    4 days ago        linux/arm64    4.092MB    1.845MB
ubuntu        latest    d4f6f70979d0    4 days ago        linux/arm64    108.3MB    28.89MB

Hi, @apostasie
Based on your advice, I updated the logic. So, could you review when you have time ?
When running nerdctl rmi b in the current implementation, the following actions are performed.
Details
> _output/nerdctl images
REPOSITORY    TAG       IMAGE ID        CREATED               PLATFORM       SIZE       BLOB SIZE
768e5c6f      latest    beefdbd8a1da    2 seconds ago         linux/arm64    10.46MB    4.09MB
alpine        latest    beefdbd8a1da    About a minute ago    linux/arm64    10.46MB    4.09MB
nginx         latest    d2eb56950b84    53 minutes ago        linux/arm64    212.1MB    69.59MB
busybox       latest    768e5c6f5cb6    4 days ago            linux/arm64    4.092MB    1.845MB
ubuntu        latest    d4f6f70979d0    4 days ago            linux/arm64    108.3MB    28.89MB

When there is more than one image with prefix d (d2eb56950b84 and d4f6f70979d0), the following error occurs I think this behavior is expected.
> _output/nerdctl rmi d
FATA[0000] 1 errors:
multiple IDs found with provided prefix: d

On the other hand, an image with short digest id of another image can be deleted.
> _output/nerdctl rmi 768e5c6f
Untagged: docker.io/library/768e5c6f:latest@sha256:beefdbd8a1da6d2915566fde36db9db0b524eb737fc57cd1367effd16dc0d06d
Deleted: sha256:16113d51b7181f20135f51e8ffbaead20a7671cd783017601f198748ce8a8ebf

> _output/nerdctl images
REPOSITORY    TAG       IMAGE ID        CREATED           PLATFORM       SIZE       BLOB SIZE
alpine        latest    beefdbd8a1da    7 minutes ago     linux/arm64    10.46MB    4.09MB
nginx         latest    d2eb56950b84    59 minutes ago    linux/arm64    212.1MB    69.59MB
busybox       latest    768e5c6f5cb6    4 days ago        linux/arm64    4.092MB    1.845MB
ubuntu        latest    d4f6f70979d0    4 days ago        linux/arm64    108.3MB    28.89MB

Hey @haytok
I left of few comments for the test part.
Apart from that, I think that is a good first step, and probably all we can do short of a full rewrite of imagewalker.
+1

Hi, @apostasie
Thanks for review !!!
I have updated, so could you re-reiview?
If there are no problems, I'll squash.

Apart from that, I think that is a good first step, and probably all we can do short of a full rewrite of imagewalker.

Thank you! Working on this issue has made me read the imagewalker source code, so I will work on fixing imagewalker if no one else is working on it.

Hi, @apostasie
Thanks for review !!!
I have updated, so could you re-reiview? If there are no problems, I'll squash.

+1
You need maintainers review. Tagging @AkihiroSuda @djdongjin @ktock
Side-note: to avoid having to squash, you can just amend and force push your commits instead.

Hey @apostasie
I updated code, but the test / unit | windows failed bacase of timeout ...
Do you have any knowledge on how to deal with this?

I have squashed commits, but a test in test-integration-docker-compatibility failed, so I'm checking ...
Details

=== NAME  TestImagesFilter/since=ghcr.io/stargz-containers/alpine:3.13-org_ghcr.io/stargz-containers/alpine:3.13-org
    command.go:112: assertion failed: expect.ExitCode is not result.ExitCode: Expected exit code: 0

        Command:  /usr/bin/docker images --filter since=ghcr.io/stargz-containers/alpine:3.13-org ghcr.io/stargz-containers/alpine:3.13-org
        ExitCode: 1
        Error:    exit status 1
        Stdout:
        Stderr:   Error response from daemon: No such image: ghcr.io/stargz-containers/alpine:3.13-org

        Env:
        LANG=C.UTF-8
        PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin
        MAIL=/var/mail/root
        LOGNAME=root
        USER=root
        HOME=/root
        SHELL=/bin/bash
        TERM=unknown
        SUDO_COMMAND=/tmp/go-build1499803690/b845/image.test -test.paniconexit0 -test.timeout=20m0s -test.v=true -test.target=docker -test.allow-kill-daemon
        SUDO_USER=runner
        SUDO_UID=1001
        SUDO_GID=118
        ImageVersion=20241016.1.0
        ImageOS=ubuntu24
        ACCEPT_EULA=Y
        XDG_CONFIG_HOME=/home/runner/.config
        AGENT_TOOLSDIRECTORY=/opt/hostedtoolcache
        RUNNER_TOOL_CACHE=/opt/hostedtoolcache
        ACTIONS_RUNNER_ACTION_ARCHIVE_CACHE=/opt/actionarchivecache
        AZURE_EXTENSION_DIR=/opt/az/azcliextensions
        SWIFT_PATH=/usr/share/swift/usr/bin
        DOTNET_SKIP_FIRST_TIME_EXPERIENCE=1
        DOTNET_NOLOGO=1
        DOTNET_MULTILEVEL_LOOKUP=0
        EDGEWEBDRIVER=/usr/local/share/edge_driver
        GECKOWEBDRIVER=/usr/local/share/gecko_driver
        CHROME_BIN=/usr/bin/google-chrome
        CHROMEWEBDRIVER=/usr/local/share/chromedriver-linux64
        BOOTSTRAP_HASKELL_NONINTERACTIVE=1
        GHCUP_INSTALL_BASE_PREFIX=/usr/local
        JAVA_HOME_8_X64=/usr/lib/jvm/temurin-8-jdk-amd64
        JAVA_HOME_11_X64=/usr/lib/jvm/temurin-11-jdk-amd64
        JAVA_HOME=/usr/lib/jvm/temurin-17-jdk-amd64
        JAVA_HOME_17_X64=/usr/lib/jvm/temurin-17-jdk-amd64
        JAVA_HOME_21_X64=/usr/lib/jvm/temurin-21-jdk-amd64
        ANT_HOME=/usr/share/ant
        GRADLE_HOME=/usr/share/gradle-8.10.2
        CONDA=/usr/share/miniconda
        SELENIUM_JAR_PATH=/usr/share/java/selenium-server.jar
        VCPKG_INSTALLATION_ROOT=/usr/local/share/vcpkg
        DEBIAN_FRONTEND=noninteractive
        ANDROID_SDK_ROOT=/usr/local/lib/android/sdk
        ANDROID_HOME=/usr/local/lib/android/sdk
        ANDROID_NDK=/usr/local/lib/android/sdk/ndk/27.1.12297006
        ANDROID_NDK_HOME=/usr/local/lib/android/sdk/ndk/27.1.12297006
        ANDROID_NDK_ROOT=/usr/local/lib/android/sdk/ndk/27.1.12297006
        ANDROID_NDK_LATEST_HOME=/usr/local/lib/android/sdk/ndk/27.1.12297006
        PIPX_BIN_DIR=/opt/pipx_bin
        PIPX_HOME=/opt/pipx
        GOROOT_1_21_X64=/opt/hostedtoolcache/go/1.21.13/x64
        GOROOT_1_22_X64=/opt/hostedtoolcache/go/1.22.8/x64
        GOROOT_1_23_X64=/opt/hostedtoolcache/go/1.23.2/x64
        HOMEBREW_NO_AUTO_UPDATE=1
        HOMEBREW_CLEANUP_PERIODIC_FULL_DAYS=3650
        RUNNER_USER=runner
        DEPLOYMENT_BASEPATH=/opt/runner
        PERFLOG_LOCATION_SETTING=RUNNER_PERFLOG
        POWERSHELL_DISTRIBUTION_CHANNEL=GitHub-Actions-ubuntu24
        XDG_RUNTIME_DIR=/run/user/1001
        DOCKER_CONFIG=/tmp/TestImagesFiltersince=ghcr.iostargz-containersalpine3.13-org_ghcr.iostargz-containersalpine3.13-org1174145695/001
    case.go:164: ======================== Post-test cleanup ========================
...
=== NAME  TestImagesFilter/since=ghcr.io/stargz-containers/alpine:3.13-org
    command.go:112: assertion failed: expect.ExitCode is not result.ExitCode: Expected exit code: 0

        Command:  /usr/bin/docker images --filter since=ghcr.io/stargz-containers/alpine:3.13-org
        ExitCode: 1
        Error:    exit status 1
        Stdout:
        Stderr:   Error response from daemon: No such image: ghcr.io/stargz-containers/alpine:3.13-org

        Env:
        LANG=C.UTF-8
        PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin
        MAIL=/var/mail/root
        LOGNAME=root
        USER=root
        HOME=/root
        SHELL=/bin/bash
        TERM=unknown
        SUDO_COMMAND=/tmp/go-build1499803690/b845/image.test -test.paniconexit0 -test.timeout=20m0s -test.v=true -test.target=docker -test.allow-kill-daemon
        SUDO_USER=runner
        SUDO_UID=1001
        SUDO_GID=118
        ImageVersion=20241016.1.0
        ImageOS=ubuntu24
        ACCEPT_EULA=Y
        XDG_CONFIG_HOME=/home/runner/.config
        AGENT_TOOLSDIRECTORY=/opt/hostedtoolcache
        RUNNER_TOOL_CACHE=/opt/hostedtoolcache
        ACTIONS_RUNNER_ACTION_ARCHIVE_CACHE=/opt/actionarchivecache
        AZURE_EXTENSION_DIR=/opt/az/azcliextensions
        SWIFT_PATH=/usr/share/swift/usr/bin
        DOTNET_SKIP_FIRST_TIME_EXPERIENCE=1
        DOTNET_NOLOGO=1
        DOTNET_MULTILEVEL_LOOKUP=0
        EDGEWEBDRIVER=/usr/local/share/edge_driver
        GECKOWEBDRIVER=/usr/local/share/gecko_driver
        CHROME_BIN=/usr/bin/google-chrome
        CHROMEWEBDRIVER=/usr/local/share/chromedriver-linux64
        BOOTSTRAP_HASKELL_NONINTERACTIVE=1
        GHCUP_INSTALL_BASE_PREFIX=/usr/local
        JAVA_HOME_8_X64=/usr/lib/jvm/temurin-8-jdk-amd64
        JAVA_HOME_11_X64=/usr/lib/jvm/temurin-11-jdk-amd64
        JAVA_HOME=/usr/lib/jvm/temurin-17-jdk-amd64
        JAVA_HOME_17_X64=/usr/lib/jvm/temurin-17-jdk-amd64
        JAVA_HOME_21_X64=/usr/lib/jvm/temurin-21-jdk-amd64
        ANT_HOME=/usr/share/ant
        GRADLE_HOME=/usr/share/gradle-8.10.2
        CONDA=/usr/share/miniconda
        SELENIUM_JAR_PATH=/usr/share/java/selenium-server.jar
        VCPKG_INSTALLATION_ROOT=/usr/local/share/vcpkg
        DEBIAN_FRONTEND=noninteractive
        ANDROID_SDK_ROOT=/usr/local/lib/android/sdk
        ANDROID_HOME=/usr/local/lib/android/sdk
        ANDROID_NDK=/usr/local/lib/android/sdk/ndk/27.1.12297006
        ANDROID_NDK_HOME=/usr/local/lib/android/sdk/ndk/27.1.12297006
        ANDROID_NDK_ROOT=/usr/local/lib/android/sdk/ndk/27.1.12297006
        ANDROID_NDK_LATEST_HOME=/usr/local/lib/android/sdk/ndk/27.1.12297006
        PIPX_BIN_DIR=/opt/pipx_bin
        PIPX_HOME=/opt/pipx
        GOROOT_1_21_X64=/opt/hostedtoolcache/go/1.21.13/x64
        GOROOT_1_22_X64=/opt/hostedtoolcache/go/1.22.8/x64
        GOROOT_1_23_X64=/opt/hostedtoolcache/go/1.23.2/x64
        HOMEBREW_NO_AUTO_UPDATE=1
        HOMEBREW_CLEANUP_PERIODIC_FULL_DAYS=3650
        RUNNER_USER=runner
        DEPLOYMENT_BASEPATH=/opt/runner
        PERFLOG_LOCATION_SETTING=RUNNER_PERFLOG
        POWERSHELL_DISTRIBUTION_CHANNEL=GitHub-Actions-ubuntu24
        XDG_RUNTIME_DIR=/run/user/1001
        DOCKER_CONFIG=/tmp/TestImagesFiltersince=ghcr.iostargz-containersalpine3.13-org2364475696/001
    case.go:164: ======================== Post-test cleanup ========================
...
=== NAME  TestImagesFilter/before=ID:latest
    command.go:112: assertion failed: expression is false: strings.Contains(stdout, compare): Output does not contain: "ghcr.io/stargz-containers/alpine"
        Command:  /usr/bin/docker images --filter before=testimagesfilter-2a4e0faa:latest
        ExitCode: 0
        Stdout:   REPOSITORY                                      TAG                IMAGE ID       CREATED       SIZE
        ghcr.io/stargz-containers/cesanta/docker_auth   1.7-org            e10c17d11f85   3 years ago   33.9MB
        ghcr.io/stargz-containers/registry              2-org              ee34aa9d8ab2   3 years ago   26.2MB
        taggedimage                                     one-fragment-one   49f356fa4513   3 years ago   5.61MB
        taggedimage                                     two-fragment-two   49f356fa4513   3 years ago   5.61MB

        Stderr:
        Env:
        LANG=C.UTF-8
        PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin
        MAIL=/var/mail/root
        LOGNAME=root
        USER=root
        HOME=/root
        SHELL=/bin/bash
        TERM=unknown
        SUDO_COMMAND=/tmp/go-build1499803690/b845/image.test -test.paniconexit0 -test.timeout=20m0s -test.v=true -test.target=docker -test.allow-kill-daemon
        SUDO_USER=runner
        SUDO_UID=1001
        SUDO_GID=118
        ImageVersion=20241016.1.0
        ImageOS=ubuntu24
        ACCEPT_EULA=Y
        XDG_CONFIG_HOME=/home/runner/.config
        AGENT_TOOLSDIRECTORY=/opt/hostedtoolcache
        RUNNER_TOOL_CACHE=/opt/hostedtoolcache
        ACTIONS_RUNNER_ACTION_ARCHIVE_CACHE=/opt/actionarchivecache
        AZURE_EXTENSION_DIR=/opt/az/azcliextensions
        SWIFT_PATH=/usr/share/swift/usr/bin
        DOTNET_SKIP_FIRST_TIME_EXPERIENCE=1
        DOTNET_NOLOGO=1
        DOTNET_MULTILEVEL_LOOKUP=0
        EDGEWEBDRIVER=/usr/local/share/edge_driver
        GECKOWEBDRIVER=/usr/local/share/gecko_driver
        CHROME_BIN=/usr/bin/google-chrome
        CHROMEWEBDRIVER=/usr/local/share/chromedriver-linux64
        BOOTSTRAP_HASKELL_NONINTERACTIVE=1
        GHCUP_INSTALL_BASE_PREFIX=/usr/local
        JAVA_HOME_8_X64=/usr/lib/jvm/temurin-8-jdk-amd64
        JAVA_HOME_11_X64=/usr/lib/jvm/temurin-11-jdk-amd64
        JAVA_HOME=/usr/lib/jvm/temurin-17-jdk-amd64
        JAVA_HOME_17_X64=/usr/lib/jvm/temurin-17-jdk-amd64
        JAVA_HOME_21_X64=/usr/lib/jvm/temurin-21-jdk-amd64
        ANT_HOME=/usr/share/ant
        GRADLE_HOME=/usr/share/gradle-8.10.2
        CONDA=/usr/share/miniconda
        SELENIUM_JAR_PATH=/usr/share/java/selenium-server.jar
        VCPKG_INSTALLATION_ROOT=/usr/local/share/vcpkg
        DEBIAN_FRONTEND=noninteractive
        ANDROID_SDK_ROOT=/usr/local/lib/android/sdk
        ANDROID_HOME=/usr/local/lib/android/sdk
        ANDROID_NDK=/usr/local/lib/android/sdk/ndk/27.1.12297006
        ANDROID_NDK_HOME=/usr/local/lib/android/sdk/ndk/27.1.12297006
        ANDROID_NDK_ROOT=/usr/local/lib/android/sdk/ndk/27.1.12297006
        ANDROID_NDK_LATEST_HOME=/usr/local/lib/android/sdk/ndk/27.1.12297006
        PIPX_BIN_DIR=/opt/pipx_bin
        PIPX_HOME=/opt/pipx
        GOROOT_1_21_X64=/opt/hostedtoolcache/go/1.21.13/x64
        GOROOT_1_22_X64=/opt/hostedtoolcache/go/1.22.8/x64
        GOROOT_1_23_X64=/opt/hostedtoolcache/go/1.23.2/x64
        HOMEBREW_NO_AUTO_UPDATE=1
        HOMEBREW_CLEANUP_PERIODIC_FULL_DAYS=3650
        RUNNER_USER=runner
        DEPLOYMENT_BASEPATH=/opt/runner
        PERFLOG_LOCATION_SETTING=RUNNER_PERFLOG
        POWERSHELL_DISTRIBUTION_CHANNEL=GitHub-Actions-ubuntu24
        XDG_RUNTIME_DIR=/run/user/1001
        DOCKER_CONFIG=/tmp/TestImagesFilterbefore=IDlatest1569974224/001

I have squashed commits, but a test in test-integration-docker-compatibility failed, so I'm checking ...
Details

@haytok see comment on not removing common images.

I have squashed commits, but a test in test-integration-docker-compatibility failed, so I'm checking ...
Details

@haytok see comment on not removing common images.

Comment applies to both images (alpinenginx as well).

I have squashed commits, but a test in test-integration-docker-compatibility failed, so I'm checking ...
Details

@haytok see comment on not removing common images.

Comment applies to both images (alpinenginx as well).

Generally speaking, only remove images you are creating in your test (through build or tag).
We probably need a better mechanism for that overall, but TBD.

Comment applies to both images (alpinenginx as well).

Oh, OK, I'll fix

Comment applies to both images (alpinenginx as well).

Oh, OK, I'll fix

Generally speaking, only remove images you are creating in your test (through build or tag).

Thanks !!!

Thanks @haytok.


[SPARK-21590][SS]Window start time should support negative values

What changes were proposed in this pull request?
Remove the non-negative checks of window start time to make window support negative start time, and add a check to guarantee the absolute value of start time is less than slide duration.
How was this patch tested?
New unit tests.

Can one of the admins verify this patch?

@zsxwing @brkyvz Can you review this?

ok to test

test this please

I added some tests in DataFrameTimeWindowingSuite, please have a look @brkyvz

test this please

Can one of the admins verify this patch?

Test build #4154 has started for PR 18903 at commit 07e98e7.

Test build #4154 has finished for PR 18903 at commit 07e98e7.

This patch fails PySpark unit tests.
This patch does not merge cleanly.
This patch adds no public classes.

Test build #4175 has started for PR 18903 at commit 07e98e7.

Test build #4175 has finished for PR 18903 at commit 07e98e7.

This patch fails PySpark unit tests.
This patch does not merge cleanly.
This patch adds no public classes.

Test build #4178 has started for PR 18903 at commit 07e98e7.

Test build #4178 has finished for PR 18903 at commit 07e98e7.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

retest this please

Can one of the admins verify this patch?

ok to test

Test build #93048 has started for PR 18903 at commit 07e98e7.

Test build #93048 has finished for PR 18903 at commit 07e98e7.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93048/
Test PASSed.

Merged to master


When can Carla deal with poly3 geometry exported by roadrunner

Recently I found that Carla can not read the poly3 geometry in the OPENDRIVE file exported by roadrunner. I have tried many ways to prevent that. But failed. When can this kind of geometry be loaded properly?
Thanks a lot

Updates on this?

It is still not supported in importing OPENDRIVE file. I really hope it can be repaired.


Unomi 1.5.x throw exceptions

Currently if there is an exception in Unomi, it is catched and 204 return in the response.
This PR allows to use the option of throwException=false/true in the custom.system.properties.
If this field is true, the response in case of exception would be an error.
Note that the PR is for unomi-1.5.x branch, since it changes files that are no longer exist in master branch

@liatiusim do you have a version for the master ? Because I would like to avoid having something only in the 1.5 branch if it is not in master.

@liatiusim  Also there really should be a ticket in UNOMI JIRA for these modifications. I forgot to ask before, but it will make tracking changes and releasing the changelog a lot easier. Could you please create a ticket there ? https://issues.apache.org/jira/projects/UNOMI/summary


Not possible to use Before or BeforeSuite with BDD

What are you trying to achieve?
I want to implemente a Before/BeforeSuite hook for all my tests
What do you get instead?
BeforeSuite is not defined

Provide console output if related. Use --verbose mode for more details.

Could not include object Step Definition from ./tests/step_definitions/steps.js from module 'project/tests/step_definitions/steps.js'
BeforeSuite is not defined

Error:
    at loadSupportObject (/Users/xxx/.nvm/versions/node/v8.10.0/lib/node_modules/codeceptjs/lib/container.js:212:11)
    at loadGherkinSteps (/Users/xxx/.nvm/versions/node/v8.10.0/lib/node_modules/codeceptjs/lib/container.js:201:5)
    at Function.create (/Users/xxx/.nvm/versions/node/v8.10.0/lib/node_modules/codeceptjs/lib/container.js:34:25)
    at Codecept.init (/Users/xxx/.nvm/versions/node/v8.10.0/lib/node_modules/codeceptjs/lib/codecept.js:37:15)
    at Command.module.exports (/Users/xxx/.nvm/versions/node/v8.10.0/lib/node_modules/codeceptjs/lib/command/run.js:35:14)
    at Command.listener (/Users/xxx/.nvm/versions/node/v8.10.0/lib/node_modules/codeceptjs/node_modules/commander/index.js:315:8)
    at emitTwo (events.js:126:13)
    at Command.emit (events.js:214:7)
    at Command.parseArgs (/Users/xxx/.nvm/versions/node/v8.10.0/lib/node_modules/codeceptjs/node_modules/commander/index.js:651:12)
    at Command.parse (/Users/xxx/.nvm/versions/node/v8.10.0/lib/node_modules/codeceptjs/node_modules/commander/index.js:474:21)

Provide test source code if related

// Scenario:
Feature: Change published block type

  As a Typeform user
  I want to change the type of published blocks
  So I can edit my forms quickly

  Scenario: Change published block type

    Given an editor with a multiple choice block
    And I have changed the block type to dropdown
    When the form is saved
    Then the payload should be valid

//Steps definition
const I = actor()

const assert = require('assert')

BeforeSuite((I) => {
  I.amOnPage('/')
})

Details

CodeceptJS version:1.4.2
NodeJS Version: 8.10.0
Operating System: Mojave
Puppeteer
Configuration file:

{
  "output": "./output",
  "helpers": {
    "Puppeteer": {
      "url": "http://localhost:9000",
      "waitForNavigation": [
        "domcontentloaded",
        "networkidle0"
      ],
      "windowSize": "1280x800",
      "chrome": {
        "args": [
          "--no-sandbox",
          "--disable-setuid-sandbox"
        ]
      },
      "show": false
    },
    "RequestInterceptionHelper": {
      "require": "./tests/request_interception_helper.js"
    },
    "StepHelper": {
      "require": "./tests/step_helper.js"
    }
  },
  "include": {
    "customizeThemePage": "./tests/pages/customize-theme.js",
    "notificationPanelPage": "./tests/pages/notifications_panel.js"
  },
  "mocha": {},
  "bootstrap": false,
  "teardown": null,
  "hooks": [],
  "gherkin": {
    "features": "./tests/features/*.feature",
    "steps": [
      "./tests/step_definitions/steps.js"
    ]
  },
  "timeout": 10000,
  "name": "xxx"
}

I think you mixed the beforeSuite with Background of gherkin. For feature file, you can only add Background which is literally beforeSuite when you develop non gherkin style.
Please check this document
https://codecept.io/bdd/#advanced-gherkin

But then this force you to repeat again the same code on all the Given statements, like if you want to go to a specific URL for all the tests. No?

Background in Cucumber is used to define a step or series of steps which are common to all the tests in the feature file. It allows you to add some context to the scenarios for a feature where it is defined. A Background is much like a scenario containing a number of steps. But it runs before each and every scenario where for a feature in which it is defined.
That's how thing go when you go with Gherkin.

Yes I know but what if I don't want to add a background on each feature, is it possible to not do it?
In Ruby for example is possible to create hooks so you don't need to

Here is a snippet from documentation:
// inside step_definitions
Before((test) => {
  // perform your code
  test.retries(3); // retry test 3 times
});

It throws the following exception:
Could not include object Step Definition from ./step_definitions/users.steps.js from module 'XXXX' Before is not defined

I understood what Background is a better way to organize steps. Here is my point:

Is documentation outdated?
How to organize steps like "clean DB" better with Background?

Thanks.


[mh] fixed broken links in docs

Signed-off-by: Matthias Holzer<EMAIL_ADDRESS>
fixed broken links in documentation

Type of request

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Refactoring
[x] Documentation or documentation changes

Related Issue(s)

Concept

Description of the change

Description of current state
Description of target state
Estimated investment / approximate investment

10mins
Initiator
Matthias Holzer / Allianz Technology GmbH
Technical information
Platform / target area

known side-effects
other
DB Changes (if so: incl. scripts with definitions and testdata)
How has this Tested?

Screenshots, Uploads, other documents (if appropriate):

Checklist:

[x] All the commits are signed.
[x] My code follows the code style of this project.
[x] I agree with die CLA.
[x] I have read the CONTRIBUTING docs.
[x] I have added/updated necessary documentation (if appropriate).

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.0 out of 2 committers have signed the CLA.:x: holzerma:x: StefanFranzWeiserYou have signed the CLA already but the status is still pending? Let us recheck it.


[MRTK3] Cheese model bug fix 10637

Overview
Fixing warning message 'identifier uniqueness violation' from the cheese object.
Updated Cheese.fbx and CheeseObjectManipulator.prefab. (CheeseBoundsControl.prefab inherits the update)
Changes
Updated structure and sub-node name. Re-exported FBX file.


Release fresh version to Rubygems

Hello, please release current gem version to Rubygems ;).

I know you asked for this a while back and I'm still moving towards it. Thank you for your patience.

There is a jruby-kafka 1.0.0.beta in rubygems if you want to mess with that.


Question about hardware requirements - 关于硬件要求的问题

This hardware requirement section isn't clear

Does this table show RAM or hard disk space?  Or is it VRAM?
How much RAM and hard disk space is it recommended to use?
Which graphics card to use?
Is there a small model we can download on PC to develop locally before we upload it to the server?

这个硬件要求部分不清楚

这个表格显示的是RAM（随机存取存储器）还是硬盘空间？
建议使用多少RAM和硬盘空间？
应该使用哪款显卡？
有没有一个小型模型，我们可以在PC上下载来本地开发，然后再上传到服务器？

This question has been translated into Chinese by ChatGPT as I don't speak Chinese
这个问题已经被ChatGPT翻译成中文，因为我不会说中文。

VRAM
32G RAM cpu, and 200G disk
A100 or V100
you can use 6B or Qwen-1.8B: https://huggingface.co/Qwen/Qwen-1_8B

Ok thank you.

@shibing624 trying to run it on AWS EC2 p4d.24xlarge, it complains about Ampere GPU when doing  sh run_pt.sh

Only A100 processors are based on Ampere architecture. AWS have only p4d.24xlarge instances with A100
Does it run on p4d.24xlarge?

use fp16


fix: Dockerfile build

Description
Fixed the Dockerfile, which previously failed to build and run tests correctly inside the Docker container. The changes ensure that the Docker environment is properly set up to handle both tasks without errors.
How to test
Build the Docker image using the command docker build -t wallet-core-dev . and verify that it completes without errors.
docker run -i -t wallet-core-dev /bin/bash
./tools/build-and-test
Types of changes

Bug fix

Checklist

[x] Create pull request as draft initially, unless its complete.
[ ] Add tests to cover changes as needed.
[x] Update documentation as needed. (There is another PR in developer repo https://github.com/trustwallet/developer/pull/358 )
[ ] If there is a related Issue, mention it in the description.

Hi @robtry, the CI has failed. Also we do not have any issue with running docker build command

So can you run ?
docker build docker/wallet-core --tag wallet-core-dev
docker run -i -t wallet-core-dev /bin/bash
and
cd wallet-core
./tools/build-and-test

I mean the folder docker does not even exists


BN config

@brittcyr possible to create a vercel or something so Butter can self serve here

I dont think it is worth it to pay for our own vercel and configure it instead of just building locally. The gov team can approve launching one if you file a pull request with them