Example: Add OpenTelemetry tracing

Signed-off-by: Nguyen  Phan<EMAIL_ADDRESS>Commit Message: Add OpenTelemetry tracing example
Additional Description:
Risk Level: Low
Testing: README.md guideline
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

cc @AlexanderEllis

hi @AlexanderEllis, I'm not sure whether the otel-collector-config.yaml file here has the right configuration? I cannot find any metrics on http://localhost:55679/debug/tracez 🤔

hi @AlexanderEllis, I'm not sure whether the otel-collector-config.yaml file here has the right configuration? I cannot find any metrics on http://localhost:55679/debug/tracez 🤔

Sorry, my bad, I've corrected the address of clusters. It works now.
I think we just need to correct the document and some verify steps
cc @phlax

I think we just need to correct the document and some verify steps

yep - im currently working on the skywalking sandbox and its evolving a bit from the zipkin one

/docs

/docs

/retest

/retest

/docs

Thanks @nguyenptk, looks great! Excited to see this in place :)


Bootstrap v4.4.1 Modal sometimes get stuck in transition when "fade" is used

This is a random bug and it does not always occur. I suspect it may have something to do with ajax calls when the modal dialog box is opened and the contents are getting populated with the ajax call.
When the modal dialog box is stuck in "_isTransitioning = true", the modal dialog box can no longer be dismissed no matter how the dismissal is triggered. Calls to modal("hide") has no effect.

Can you supply with an example which may show the mentioned issue.  Without a working example, it will not help really

Hi Alan,
This is indeed a problem, the $ ('# myModal'). Modal ('hide') method sometimes fails.
This is an application scenario: the user needs to upload a file or certificate.
(1) When the user selects a good file or certificate, he clicks the upload button, then I want to pop up a modal box that is uploading,
(2) When the background returns successful upload information, I want to hide the uploading modal box.
But the modal box will not be hidden, it will be displayed continuously.
Below is a code example of an upload method:
var uploadLicense = function () {
            $ ('# progress'). modal ('show');
            var params = "Some parameters";
cfgLicenseMgmtService.exportBy (params)
                .success (function (data) {
                    $ ('# progress'). modal ('hide');
                    if (0 == data ['return']) {
                        console.log ("Uploaded successfully")
                    } else {
                        console.log ("upload failed")
                    }
                })
                .error (function (data, status, headers, config) {
                    console.log ("upload failed")
                });
        };
There is no such problem in bootstrap3. I do n’t know what changes have been made to bootstrap4, which causes the $ ('# myModal'). Modal ('hide') method to sometimes fail.

The following two methods can make the modal box normally hidden in this case:
(1)
setTimeout (function () {
             $ ('# progress'). modal ('hide');
}, 1000)
(2)
$ ('# progress'). on ('shown.bs.modal', function (e) {
             $ ('# progress'). modal ('hide');
   });
This problem is very prominent. I believe that many users who upgraded from bootstrap3 to bootstrap4 have encountered this problem.

This is an online case https://codepen.io/dllluoluo/pen/KKdVrxZ?editors=0000, there are two ways to hide the modal box, you can see different phenomena by modifying the value of setTimeout. Is there any good way to solve this problem in this application scenario (the value of setTimeout is equivalent to the return time of api, we can not control it), thank you very much.
(1) If the value of setTimeout is set to 500 or more, it will not hide itself when the progress modal is triggered for the first time (you can click to hide). When it is triggered again later, it will hide normally. If the value of setTimeout is set below 500, the progress Modal will be hidden normally.
(2) If the value of setTimeout is set to 500 or above, progress Modal can be hidden normally (every time). If the value of setTimeout is set below 400, progress Modal will not be hidden normally (every time, the status of progress Modal has not been changed).

@DLLluoluo if you want to stop the openning of a modal before the trigger of shown.bs.modal you can call event.preventDefault() on the show.bs.modal it'll cancel the openning

Closing due to lack of response. You can comment here and we can re-open the issue.
This is an automated reply

I'm very sorry for my late reply, I encapsulated a hideModal method, it is very simple. Pass in the id name of the modal box and call two methods that can hide the modal. In this way, regardless of the length of time, the modal can be hidden normally. This may be better understood.
var hideModal = function (id) {
$ (id) .modal ('hide');
         $ (id) .on ('shown.bs.modal', function (e) {
             $ (id) .modal ('hide');
          });
}

I wound up here because a modal I added wouldn't close for nothing. Turns out I had misspelled "model-dialog". Commenting in case it saves somebody else some frustration. /picard


package com.darryncampbell.cordova.plugin.intent.api.exerciser does not exist

Hi Darryn..
Thanks for changing #4 so quickly, but now I get the following message when compiling.
package com.darryncampbell.cordova.plugin.intent.api.exerciser does not exist
Thanks..

Strange, it definitely exists up at https://www.npmjs.com/package/com-darryncampbell-cordova-plugin-intent.  Perhaps try uninstalling / re-installing the plugin (ensure to use the latest version).  Failing that, remove (& ensure it clears out) & re-add the Android platform

Sorry for confusion..

Thanks..

Goodness!  I'm afraid I was over zealous with Android Studio's auto complete.  Sorry about that, should be fixed under https://github.com/darryncampbell/darryncampbell-cordova-plugin-intent/commit/6ef1a37ccd84db03712f4514c409d05f55fb5dd3 and 0.0.10


Cloning this repo from command line results in warning

When I cloned this repo from the command line, it resulted in the following surprising warning:
warning: the following paths have collided (e.g. case-sensitive paths
on a case-insensitive filesystem) and only one from the same
colliding group is in the working tree:

'docs/images/Architecture.png'
'docs/images/architecture.png'

While git status confirms "nothing to commit, working tree clean", if I look at Windows Explorer (for which I have TortoiseGit), there is a red circle with an exclamation point indicating this folder is out of sync.

And if I look in "/docs/images/", the "Architecture.png" is missing.
Browsing the files here, I can see "Architecture.png" and "architecture.png" are identical.
I expect "Architecture.png" should be deleted unless this is needed for legacy reasons.

Thanks for the report - fixed.  Let me know if you still have problems cloning.


Cluster failing when reloading my flannel wireguard interface.

Environmental Info:
K3s Version:

k3s version v1.20.4+k3s1 (838a906a)
go version go1.15.8
Node(s) CPU architecture, OS, and Version:

Linux ovh-node 5.8.0-29-generic #31-Ubuntu SMP Fri Nov 6 12:37:59 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Cluster Configuration:

1 master 4 workers
Describe the bug:

I have set the flannel interface on the masters and the workers like:
--flannel-iface wg1

Unfortunately however if on the master I reload the wg1  interface (wg-quick down wg1 && wg-quick up wg1) - k3s does not seem to handle it well with a lot of things appearing to start hanging. It is then fixed by reloading the k3s service on the master node (service k3s restart).
[Unit]
Description=Lightweight Kubernetes
Documentation=https://k3s.io
After=network-online.target

[Service]
Type=notify
ExecStartPre=-/sbin/modprobe br_netfilter
ExecStartPre=-/sbin/modprobe overlay
ExecStart=/usr/local/bin/k3s server --node-external-ip X.X.X.X --node-ip <IP_ADDRESS> --no-deploy traefik --flannel-iface wg1
KillMode=process
Delegate=yes
# Having non-zero Limit*s causes performance problems due to accounting overhead
# in the kernel. We recommend using cgroups to do container-local accounting.
LimitNOFILE=1048576
LimitNPROC=infinity
LimitCORE=infinity
TasksMax=infinity
TimeoutStartSec=0
Restart=always
RestartSec=5s

[Install]
WantedBy=multi-user.target

Steps To Reproduce:

Installed K3s with --flannel-iface wg1
restart wg1

Expected behavior:

k3s to handle the reload of the interface without needing to be restarted.

Actual behavior:

I can't find any specific logs but it just feels like flanel breaks and the internal networking stops working.
Additional context / logs:

N/A - but would really appreciate some pointers on where I should be looking.

 If it is deleting interfaces that we are bound to, I can see how that would require a restart to resume listening. Does it seem unreasonable that a service would need to be restarted when you take down the interface that it is bound to?

yes when you run wg-quick down wg1 it completely deletes the interface. For some reason when adding a node to my wg mesh I have to restart (down/up) every interface. I have tried other wireguard techniques such as syncconf but they don't work. Do you think that perhaps I need to add some hook to my config above to restart k3s after?

Yeah, I'm not sure of the best way to add that hook but I don't see any other way around it. If the interface we're listening on goes away, K3s (and all the Kubernetes bits) need to be restarted to resume listening on it.

I have noticed that if I restart wireguard on any node all connections to it stop working even though k8s is saying the node is in a ready state. restarting the master node fixes this...


Can set wrong image on token when used in combination with Token Variant Art module

Describe the bug
I'm using combat utility belt to configure effects that are applied with conditions.  I've configured both ATL to add lighting effects and Token Variant Art to change a token's image.  With other effects applied by CUB the image is retained, but with any effects that include ATL values the image is reset to the tokens original.
To Reproduce
Steps to reproduce the behavior:

Enable modules Combat Utility Belt, Token Variant Art and ATL.
Configure a condition that changes a token image as described in TVA.
Configure a different condition that adds token lighting with ATL.
Apply first condition - image is changed
Apply second condition

Expected behavior
Image should remain that defined by first condition.
Actual behavior
Image is changed back to default
Environment:

OS: Mac OSX
Browser: Electron app
Foundry Version: 9
Module Version: 0.4.01
All Modules Disabled: No
Module List if no:
As described above.

See that's a similar thing described in #100

Hope you don't mind me jumping in but if you want to avoid TVA clashes with ATL for your usecase of setting both the image and some lighting effects, you might make do with using Custom Configs functionality provided by TVA.
TVA allows to assign whatever setting exists in the Token Configuration window to an image, and if that image is mapped to an effect those settings will get applied to the token together with the image:
https://user-images.githubusercontent.com/7693704/173160740-d005bb61-4684-473a-89a6-52aab5482907.mp4
However this does seem like a resolvable bug.
Just throwing it out there so that you're aware in case there are any more clashes that could potentially be avoided 🙂

Thank for the detailed demo, but I don't think this quite fits my use case:
I have two images, one for standing and another for prone.  I want the "Prone" image to be shown when that condition is applied, and the default one when its not.
I have several conditions that apply lighting that can be applied separately of "Prone", for example the Light spell.
I'm trying to get it so the light is applied independently of the image and vice versa.
Although my PR fixes this specific case, it won't fix #100 which addresses a larger issue in that ATL is messing with properties it shouldn't be IMO

Hi, since the pull request hasn't gone through and as far as I can tell the problem still perisists, I wanted to inform that since my last comment TVA (>=2.10.0) now supports Token Configurations on Active Effects independent of any actual image.
If anyone has conflicts occur between these two modules it should now be a bit easier to just make do with one if need be. This is not a complete substitute for all that ATL can do, and will not work for everyone, but it's there. 👍

I'm having the same issue with Convenient Effects. If I've used TVA to select another token, an ATL change using CE will revert the token back to the prototype. Doesn't seem to happen with TMFX or other effects triggered by CE, just ATL. Unfortunately there are a fair few CEs that use ATL.

I too am getting this issue. It took a lot of effort to find out what was happening. I have updated TVA to the latest but it still doesn't resolve the issues for me. ;(

There’s a setting in TVA now that updates the prototype to skirt around this issue. Do you have that turned on?

I couldn't find this setting. Any help is appreciated.  Thanks

Note that ATL will still be reverting back to the prototype data, but with this setting enabled changes made via TVA at aleast will be preserved because they will get applied to the token and the prototype.

I have indeed tried using this setting to no avail. My token still instantly reverts to the Prototype tied to the character sheet when Darkvision spell which is using ATL to give it sight is applied to said token.  I am at a loss ;(

Jut to be sure. The order of events in your test are:

You've set the setting to true
Updated the Token image using the TVA module (Art Select, Token HUD, Condition mapping etc.)
Applied a condition which is using ATL
The Token image got reverted ?

Could you check that with the setting enabled any changes to the Token image using TVA are actually being applied to the Prototype? If not I may need to look into this.

Yes for number 1 and 3. When I manually tell it via the TVA which art to select to begin with, it sometimes reverts to the prototype and sometimes keeps the current blank PNG, but each time regardless of the outcome, it reverts to the original size of the prototype token which is in this case 1 x 1 where my PNG token is set to 4 x 4.  But I would like to emphasize that this issue happens where there or not your module TVA is enabled. The only thing that corrects it is removing the ATL in DAE or disabling ATL altogether.
Here is a video(without audio) for the case issues.
https://www.youtube.com/watch?v=m1jQBgqfCvI

Ok, yes this has nothing to do with TVA. All of these problems stem from ATL.
The workaround that worked for Lukas will work for your use case.
The TVA setting seems to be doing what it's supposed to. The only thing that got "ratained" was the only thing that you changed using TVA which was the image. You could also assign the width and height to the image using TVA but I don't think that's what you want.
You want your Actors to have differing images on different scenes which is not possible due to how ATL works. Your tokens will all source the same prototype and will automatically be reset to it.

Changing the prototype using TVA to the settings you want for your splash screen would mean that that's how your token would look when you drag in that actor onto another scene.
Changing the token outside the splash screen would mean that ATL would then revert your "blank" token on the splash screen

So yeah, ATL needs to be changed to only affect the properties it has been set to modify. Which is the original problem described by strongpauly.
I'm not sure how it could be worked around in a way that would not break your splash screen. Sorry Bryn. 😞


Unable to run the Example Project

Describe the bug
I tried suggestions found in other
To Reproduce
Steps to reproduce the behavior:

pod try SwiftEntryKit and wait for it to open (cloning repo yields same result)
Build QuickLayout
Build SwiftEntryKitDemo
See error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots

iPhone (please complete the following information):

Any device
iOS Version: 12.1
Xcode Version 10.1
Dependency Manager: Cocoapods 1.6.0.beta.1
SwiftEntryKit Release: 0.8.4

Additional info
I can get the project to work by:

Removing the SwiftEntryKit target from the example workspace
Cleaning workspace
Rebuild

Hi,
Have you taken a look at the example project installation section?
What you described happens when one downloads the project. Instead, you need to:
$ git clone --recurse-submodules https://github.com/huri000/SwiftEntryKit.git

There are multiple issues referring this, which are currently closed because they were resolved.
Please let me know if that works for you.

Hi Huri000,
That does work, but it seems kind of redundant? This breaks the pod try mechanism and installs dependencies twice: once through the pod dependencies and once manually.
Simply removing the duplicate build targets also works, which confirms all the needed dependencies are already there.

Yes @krummler, you are right. I remember struggling with it quite a bit back when I initially release the library. It had something to do with SwiftEntryKit started supporting Carthage and so I had to Include the QuickLayout framework as a submodule. Xcode's build tool could not find it in its proper location in the Carthage/Build/... path.  After tinkering with it a bit (unsuccessfully) I descide it didn't worth the time and regressed to the git clone using recurse flag, which do work.


The npm install doesnt work

After downloading the code when i tried to install the dependencies there is an error comes like
Failed at the<EMAIL_ADDRESS>postinstall script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
     C:\Users\User\AppData\Roaming\npm-cache_logs\2019-02-23T06_19_29_334Z-debug.log
I am new to ionic and cannot handle with this error even if i used the npm clean --force.

I also have this problem. I found some useful info here but i am not keen to uninstall all dependencies and downgrade them to older versions to make this work. Did @susnas find any solution to this?

New version has been released. Everything should work now :)


Move runtime files in project template

When the CLI updates a project, the following items should be easily replaced, so moving them in an internal folder will make this easier.

metadataGenerator
NativeScript
NativeScript.framework
TNSDebugging.h

@fealebenpae Should we also move main.m and build.xcconfig?

Well, build.xcconfig is supposed to be user-editable, so perhaps it would be best to leave it where it is so it doesn't get updated by the CLI.
I'm torn about main.m, though. My gut feeling says we should leave it where it is, but I'm afraid there will  come a time when we have to update it if we change the way the runtime is initialized (like scheduling it on a runloop, for example). @Fatme, your thoughts?

@fealebenpae What do you think if we move all NativeScript specific settings from the Xcode project to a separate nativescript-build.xcconfig?
For example:

Link libraries (libNativeScript.a, libc++, libz, libicucore, MobileCoreServices)
Other linker flags (-ObjC -sectcreate ...Metadata...)
Header search paths (NativeScript/include)
Library search paths (NativeScript/lib)

Sounds awesome. Would build.xcconfig include this new file?

We can also add three generic NativeScript build steps in the project template: PRE_BUILD PRE_LINK POST_BUILD to future proof any changes. We can also make the scripts language agnostic, by removing the bash nativescript-pre-build.sh and change it to ./nativescript-pre-build for example.

aleph-one

There are some conflicts with our CocoaPods integration, that I'm currently looking at.

https://github.com/CocoaPods/CocoaPods/issues/1761#issuecomment-32890062


chore: csp header splitting improvements

Some suggested changes to #1360, the CF-testable version of @NeOMakinG's #1338.

Adds doc comments with types so we can get the benefits of TS even though we can't use a .ts file
A more comprehensive, and hopefully maintainable, set of functions for CSP transformation
removes 'report-sample' from child-src; it doesn't hurt anything, but it's not valid there

(doing this as a PR-into-a-PR so @NeOMakinG can see the changes separately)

@NeOMakinG says go for it on discord, merging


LRU算法

http://flychao88.iteye.com/blog/1977653

Kamino closed and cloned this issue to dongyuanlongwang/algorithms


About Hand Pose Estimation

Great job!
Would you please implement "Hand Pose Estimation from Depth Images" of the paper?

Sorry but I don't have any plan for implementing it.

I'm currently working on NYU hand datasets. Just another version of your code. I'll be updating some of your .py files together with preprocessed NYU hand dataset so please visit my repo when it's done!!:)

Great job,
Just to clarify this library works only for images classification? does it work for any other type of data other than images?


Bump Terraform's azurerm provider to 3.0.0

This PR contains required changes required to use the 3.0 version of the Terraform azurerm provider. https://github.com/hashicorp/terraform-provider-azurerm/releases/tag/v3.0.0
E2E testing is running here: https://dev.azure.com/Mission-Critical/Online/_build/results?buildId=773&view=results
Draft PR still work in progress / and needs further testing.

How about 3.0.1? ;)

How about 3.0.1? ;)

You're of course right - but I assume the work to do is the same.. ;) Dependabot can take care of 3.0.1 then..

I know, but especially when the work to do is minimal, I would prefer to update straight to the latest version instead of dealing with the Dependabot overhead in a few weeks...

I know, but especially when the work to do is minimal, I would prefer to update straight to the latest version instead of dealing with the Dependabot overhead in a few weeks...

For sure, I was a bit too quick setting this PR to ready for review.. its a rabbit hole..

E2E Test is running here: https://dev.azure.com/mission-critical/Online/_build/results?buildId=800&view=results

Will prepare a PR for -connected in the next hours or days. Would like to keep an eye on this one in -online first.


pull request for e2e test at 12/21/2016 14:26:28

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


3.0.X-0: browser.resources.dump(), 'call' is undefined within core-js.js getIterator

Using 3.0.3-0 through 3.0.6-0 our team has been seeing the following:
TypeError: Cannot call method 'call' of undefined
at Function.getIterator (/test/node_modules/zombie/node_modules/6to5-runtime/core-js.js:496:31)
at Resources.dump (/test/node_modules/zombie/lib/resources.js:161:123)
...

Current stable versions do not have this issue, but we've upgraded to the 3.x.x releases for the improved XHR support.

I've seen the same issue with the 3.0 branch.

Just pushed 3.0.7 to npm, give it a try

Hi Assaf,
Thanks for the quick update, it is much appreciated. Unfortunately, it seems the bug still remains (but is now caused from a slightly different place within the Resources.dump() iterator function:
Warning: Command failed: ^--- With additional stack trace: TypeError: Cannot call method 'call' of undefined
  at Function.getIterator (/test/node_modules/zombie/node_modules/babel-runtime/core-js.js:550:31)
  at Resources.dump (/test/node_modules/zombie/lib/resources.js:167:123)

But seriously, I tried calling it on a new browser object and a browser with open documents, on Node 0.10 and 0.12, not seeing any errors.


chore: master > main

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.31%. Comparing base (a02bf94) to head (d62c8ce).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##           master       #7   +/-   ##
=======================================
  Coverage   94.31%   94.31%
=======================================
  Files           4        4
  Lines          88       88
  Branches        6        6
=======================================
  Hits           83       83
  Misses          3        3
  Partials        2        2

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Add support for onChange callbacks for zoom, pan

Would be nice to have some sort of callback to hook in to for zoom and pan events.
For example, when I pan my <svg> "paper", I want to move an html based menu that lies outside of the <svg> "paper" as I pan the <svg> paper. Currently, I have no way of knowing when the pan is occurring and when it completes.
I propose adding: onZoom and onPan as props for the ReactSVGPanZoom component and passing back the scaleFactor and translateX/translateY properties respectively.
Happy to put up a PR that handles this.

I Agree. It could be a very useful feature.
If you have enough time to develop it go on with the PR.

component and passing back the scaleFactor and translateX/translateY properties respectively.
Instead of this I suggest to pass back the viewerEvent instance, because it calculate those  informations only when requested (lazy load), moreover it has a lot of additional information that could be useful to the developer.

How to intend to pass the zoom/pan action that now is only known by the interactions.js module to the viewer that should invoke those callback?

Working on this now - our org needs these features with your awesome plugin 👍
I was planning on adding a function to check for these callbacks and pass through the desired params, probably inside Viewer.handleViewerEvent

In progress here https://github.com/chrvadala/react-svg-pan-zoom/pull/75

Introduced in version 2.16.0


Create a loader page for CRX

When the user opens the extension, files can take some time to fully load, or the user could not have set up the secret yet. This makes the extension open with a blank background.
We should implement a loader page that doesn't require any external components, making it open right away, without the need to download js files or CSS files, before the react application is fully loaded or the background page takes action.
This will also avoid the flicker effect where the extension resizes common on many extensions.

I have created a loader, but the work to add it would be a bit bigger as we need this to be an overlay.
The ideal implementation is;

Add the loader directly on the HTML. This will make the loader appear when the user opens the page, not waiting time without a loader
On react, we should be able to trigger a removal that will remove the loader.
After removing the loader, it should fade out to the screen to avoid blinking
The time for the loader to appear and disappear should be around 1 second. In this way, the loader will always appear and disappear in a slow way event if the application loads fast; this prevents the screen from blinking with components loading, giving a smoother experience for the user.

This is my current implementation FuelLoader.zip. Note: We should remove the react-motion use here and use only plain CSS and SVG to avoid react loading time.


fix(ABR): Fix variant choose when two variants have the same bandwidth but different resolution

@theodab can you review it? Thanks!


Fix a bug where responses weren't closed on a late cancel (3.12.x branch)

Closes: https://github.com/square/okhttp/issues/4583

@swankjesse @yschimke  Beware that this way of fixing the issue is a breaking change. (Including the merged one for 3.14)
It's still totally possible to have another thread that cancels at https://github.com/square/okhttp/blob/bf394560e1c83d05a552079634359fad9e0a640b/okhttp/src/main/java/okhttp3/RealCall.java#L202 point.
Before it would have thrown, call failure and leaked the response, now it will call onResponse (so success) and ignore the cancel.
Personally I'm fine with the change as I find better to have a success call than a leak but I'm not sure this was wanted with that version of the fix.

Needs to be rebased on this:
https://github.com/square/okhttp/pull/4652

@Tolriq yep! You can also cancel a call while it’s being processed in onResponse(). When this happens the response body stream will throw an IOException, but the onResponse() implementation is still responsible for closing it.

@swankjesse Yes I know and handle all the cases and found this issue, just pointing that the way of fixing it is a breaking change in some user cases.
A late cancel would have called onFailure now it can call onReponse.
If a user expect that onResponse is not called for cancelled calls this is breaking change and may require proper warning in the changelog that now a check for call.isCanceled() might be wanted in the onResponse callback due to this change since it can now happens.

Just a side note that changelog does not contains a comment about the fact that a cancelled call can reach onResponse now after those fixes. (3.14 and 3.12.x)

@Tolriq it was already possible previously. The call is often canceled while reading the response body.

@swankjesse I guess I badly explained in all previous comments so :)
The breaking change is that onResponse can be called with a call that is already cancelled. This was not possible before.
This change behaviors for API consumers, not all consumers want to actually use the body and will see an error if there's an error when using a body from a cancelled but successful call (I don't think so). And can start job / stuff that they are not supposed to do if the call was cancelled and never reached onResponse.
Furthermore the documentation says:
/** Cancels the request, if possible. Requests that are already complete cannot be canceled. */
So if onResponse is called a call.cancel() is said to do nothing.
Now onResponse can be called with a call that is already cancelled and the consumer should not use the response, yet 99% of users certainly don't do call.isCancelled() check at the start of this function since it was not possible that is happened before.
Hope it's more clear why it's a breaking change and people should be aware, the race condition is now move to end user code.

There’s no ordering guarantees between cancel() and onResponse(), and a call can be canceled immediately after an isCanceled() check returns false.

Does this clarify? A call isn’t complete until the response body is exhausted or closed, which is also independent of when onResponse() is invoked.

Then docs are not clear enough about what complete is.
And this also means that it's virtually impossible to prevent the leaks in coroutines world so :(
return suspendCancellableCoroutine { continuation ->
            continuation.invokeOnCancellation {
                cancel()
            }
            enqueue(object : Callback {
                override fun onResponse(call: Call, response: Response) {
                    continuation.resume(WorkerResult.Success(response))
                }

                override fun onFailure(call: Call, e: IOException) {
                    if (call.isCanceled || !isActive) {
                        continuation.resume(WorkerResult.Error(CancellationException("Cancelled")))
                    } else {
                        continuation.resume(WorkerResult.Error(e))
                    }
                }
            })
        }

Can leak for example  coroutines 1.1.x ignores the resume when the call is cancelled and now with the race on client side the response is not closed :(
Maybe @JakeWharton have more idea about how to manage those races as retrofit coroutines will face that too.
Adding the isActive isCancelled check can face the race condition in onResponse,

Retrofit doesn't have this problem because it doesn't propagate an open
resource. Seems like any coroutine that resumes with a resource will have
this problem. Is there anything specific to OkHttp?
On Thu, Mar 14, 2019 at 8:36 AM Tolriq<EMAIL_ADDRESS>wrote:

Then docs are not clear enough about what complete is.
And this also means that it's virtually impossible to prevent the leaks in
coroutines world so :(
return suspendCancellableCoroutine { continuation ->
continuation.invokeOnCancellation {
cancel()
}
enqueue(object : Callback {
override fun onResponse(call: Call, response: Response) {
continuation.resume(WorkerResult.Success(response))
}
            override fun onFailure(call: Call, e: IOException) {
                if (call.isCanceled || !isActive) {
                    continuation.resume(WorkerResult.Error(CancellationException("Cancelled")))
                } else {
                    continuation.resume(WorkerResult.Error(e))
                }
            }
        })
    }

Can leak for example coroutines 1.1.x ignores the resume when the call is
cancelled and now with the race on client side the response is not closed :(
Maybe @JakeWharton https://github.com/JakeWharton have more idea about
how to manage those races as retrofit coroutines will face that too.
Adding the isActive isCancelled check can face the race condition in
onResponse,
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/square/okhttp/pull/4651#issuecomment-472834234, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAEEEXP0ezLCEKDcMPDPoUSP9Iv4ziLUks5vWkI1gaJpZM4bOSA0
.

Can you register a different cancelation handler in onResponse() ?

@JakeWharton you do the exact same thing:
https://github.com/square/retrofit/blob/master/retrofit/src/main/java/retrofit2/KotlinExtensions.kt#L69
and
https://github.com/square/retrofit/blob/master/retrofit/src/main/java/retrofit2/KotlinExtensions.kt#L89
Don't know how those extensions method are used currently but they present the same issue :(
@swankjesse not sure to understand your question :(

Those aren't resources. They don't need closed. They're values.
On Thu, Mar 14, 2019 at 8:52 AM Tolriq<EMAIL_ADDRESS>wrote:

@JakeWharton https://github.com/JakeWharton you do the exact same thing:
https://github.com/square/retrofit/blob/master/retrofit/src/main/java/retrofit2/KotlinExtensions.kt#L69
and
https://github.com/square/retrofit/blob/master/retrofit/src/main/java/retrofit2/KotlinExtensions.kt#L89
Don't know how those extensions method are used currently but they present
the same issue :(
@swankjesse https://github.com/swankjesse not sure to understand your
question :(
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/square/okhttp/pull/4651#issuecomment-472839466, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAEEEQEycrppKnEdSnSNmHHahjs507DMks5vWkX1gaJpZM4bOSA0
.

Oh sorry, long time not used Retrofit, did not notice the Call is the same interface but not same API :(.
Will move this to coroutines support so.

See https://github.com/Kotlin/kotlinx.coroutines/issues/1044 for the coroutine part and design thinking by Roman Elizarov, maybe you have ideas to share :)


Update CMakeLists.txt

This is an update to the pull request https://github.com/ros-visualization/rviz/pull/825
Moves find package logic up to the main CMakeLists.txt so both image_view and rviz can find it.
Addresses issue https://github.com/ros-visualization/rviz/issues/824

Bump, it would be great if you had some time to fix this up in the near future. If not I'll eventually do it, but I'd rather you get the contribution in the history.

Oh, this was superseded by https://github.com/ros-visualization/rviz/pull/825, my bad... closing.


Fix INT_MIN assignement in GDScript

Fixes #65506

Doesn't that break doing subtractions?

 When operands are not spaced, it's broken. I will do more tests and update

The problem is clearly here
https://github.com/godotengine/godot/blob/baded9fe09e3dcb0a1e5c52ffc5436394aa6e38d/modules/gdscript/gdscript_tokenizer.cpp#L742
but every negative number is collected as positive one, so the "resolution" must happen after that.
since +9223372036854775808 is impossible, I think the easiest way to handle INT_MIN would be to introduce it as a "builtin-const" (like CONST_PI, CONST_INF, ...)
I don't if it's intended, but I noticed that
	print(-123)      # prints -123
	print(- 123)     # prints -123
	print(-- 123)    # prints 123
	print(--- 123)   # prints -123


when i restart app after i change the language, the currentLocale.languageCode returns the initLanguageCode value not the one that i've recently changed

There is a small bit of delay in getting the last languageCode from currentLocale. To prevent a null value, it returns the default code from initLanguageCode first and followed by the latest languageCode.


delete old disabled end to end tests

supports resolution of https://github.com/fabric8io/fabric8-test/issues/497

@kbsingh could you please review?

@joshuawilson @maxandersen who is able to review and merge?

I would like @ldimaggi to review

Do not delete jobs from the JJB manually guys. The only person who is able to merge this cleanly is @jmelis

@kbsingh do we have docs explaining how to do it correctly?

@jmelis could you help us with this PR?


Error saving settings with unexpected response

When I save settings this shows saying External app url responded with an unexpected response:

I look at network log and the PUT request resulted in 400 and responded with {"status":"ERROR","message":"External app url responded with an unexpected response: "}
This happened when I built manually on latest a516e56 and when I use Docker.

your app url needs to be a public facing url pointing to the site for the webhooks to post to, required for recording to work

your app url needs to be a public facing url pointing to the site for the webhooks to post to, required for recording to work

can i not run it locally on my network instead? I dont need webhooks either but if you say it is required then is a discord webhook fine?

if you want it to record channels when they go online you need a public facing address with https. not sure if i've set the settings to be optional

that sucks i didnt expect to face any issues running it local wasnt expecting to require a specific server with a public domain to run the app. Your app looks useful but maybe ill use it in the future when there is local support

if you want to have it local only it would have to constantly check if a streamer is online every like 30 seconds, do that thousands of times a day and it would probably spam a bit too much. there are other projects like that, but i wanted it to be the least intrusive as possible

it would have to constantly check if a streamer is online every like 30 seconds, do that thousands of times a day

is your project not using eventsub to listen for when a streamer goes live?

it would have to constantly check if a streamer is online every like 30 seconds, do that thousands of times a day

is your project not using eventsub to listen for when a streamer goes live?

it does, and that's why it needs an url where twitch can send the data to

i didnt know sorry. thank you for your help


132 Pattern

Hey @ayu8  I would like to contribute to this repo under hactoberfest
Please assign me this issue

Please find a suitable folder (topic) for this problem and add there.

yeah we can put this in Stack or in Binary Search


Clarify how to contact support if you can't log in

Closes #1333

@King-of-Spades : Thanks for your contribution! The author(s) have been notified to review your proposed change.


@Factory - a new annotation to produce a factory class.

@Factory is a new annotation I would like to suggest .
Many times, I find it very convenient to have all siblings of a parent class/interface/annotation a) enlisted (great for code assistance) and b) ready for construction.
In vanilla Java - I have to either remember all those siblings, or use IDE's method do rediscover them over-and-over again, or create and maintain a Factory class manually.
Such Factory class is responsible for building (assuming @Build annotation) instances of those (non-abstract) siblings.
It would be much more convenient to have that Factory class, created by Lombok!
I show this in the example below.
------------------------
@Value
class abstract Transformer {
}

------------------------
@Value
class abstract Autobot extends Transformer {
}

@Builder
@Value
class Optimus extends Autobot {
}

@Builder
@Value
class Bumblebee extends Autobot {
}

...

------------------------
@Value
class abstract Decepticon extends Transformer {
}

@Builder
@Value
class Megatron extends Decepticon {
}

@Builder
@Value
class Soundwave extends Decepticon {
}

...

------------------------
@Factory(Autobot.class)
class Autobots {}

@Factory(Decepticon.class)
class Decepticons {}

//
// vs. Vanilla Java
//

class Autobots {

  public static Optimus.Builder optimus() {
   return Optimus.builder();
  }

  public static Bumblebee.Builder bumblebee() {
   return Bumblebee.builder();
  }

  // ...

}

class Decepticons {

  public static Megatron.Builder megatron() {
   return Megatron.builder();
  }

  public static Soundwave.Builder soundwave() {
   return Soundwave.builder();
  }

  // ...

}
------------------------
public class Example {

 public static void main() {
  //
  // Autobots
  //
  Transformer optimus = Autobots.optimus().build();
  Transformer bumblebee = Autobots.bumblebee().build();
  //
  // Decepticons
  //
  Transformer megatron = Decepticons.megatron().build();
  Transformer soundwave = Decepticons.soundwave().build();
  //
  //...
  //
 }
}

------------------------

Sources:
List of The Transformers

I like the idea, though I see need for some details.
As far as I can see, handling of @Factory(T) annotation would look like this:

find all instantiable subclasses/implementations of T
for each subclass:
2.1. for each public constructor
2.1.1. generate public static method named the same way as the subclass and with the same argument list as constructor

The problem is in (1) - where do you look for them?
a. in the same package as annotated class (what with inner classes? should we look only through the same scope, so only in outer class, or maybe in the most outer class and all below, or the package in which the most outer class is?)
b. in currently compiled sources
c. in the whole classpath
d. add argument to annotation: @Factory(T, scanPackages: String[], scanClassPackages: Class[]) in similiar fashion as in Spring Boot; if both scan... argument are missing, we may then fall back to some variant of (a), (b) or (c).
I would propose (d) with fallback to (b) (though this may be tricky, so maybe to (a)).

@FilipMalczak, I agree with you considerations.
I think scanPackages annotation attribute is a good idea. Though I'd propose includePackages/excludePackages and includeClasses/excludeClasses.
I'd vote for a fallback to (b) - because those sources are being processed anyway.

Any progress?

+1

+1

+1

I'm just a contributor and not speaking for the dev team, but I don't think this feature will ever make it into Lombok.
The reason is that it requires resolution, and that will make it very hard to implement and create a high maintenance burden. When Lombok runs, you simply cannot get info about subclasses, and there is no such thing as "currently compiled sources", because the compilation is not yet finished.

You have to think of "no resolution" as if you cannot inspect anything of a referenced class. You don't know any methods or constructors of that class, you even cannot say if the class exists at all. All this is processed at a later stage of the compiler, and it's to late for Lombok then.
This means that everything you have to generate must be computable using only lexical/syntactical information from the annotated class. So you not only have to annotate the class name, but also the method name or constructor and all its parameters. This would create the most ugly Lombok annotation ever, and you would simply move the reduced lines to the annotation.

Absolutely fine with me.
Generating constructor methods for enlisted subclasses requires "no resolution" at all!
See my comment above as an example: https://github.com/rzwitserloot/lombok/issues/1408#issuecomment-439678883

BTW: The generated code you propose isis not an example of the factory pattern as described by the GoF. Typically you have an interface as return type, because you want to allow to redefine which class to instantiate. This would further increase the annotations parameters.

Out of curiosity: Why exactly do you use this pattern so much? What is the
value of that pattern?
On Sun, Nov 18, 2018 at 5:24 PM Pavel Bekkerman<EMAIL_ADDRESS>wrote:

BTW: The generated code you propose is not an example of the factory
pattern as described by the GoF. Typically you have an interface as return
type, because you want to allow to redefine which class to instantiate.
Including this would further increase the annotations parameters.
I don't know if anyone would ever want of to become a fully-blown GoF.
I'm seeing @factory https://github.com/factory annotation as a simply:
"Add here constructor methods for enlisted subclasses of the annotated
class."
This simple feature is very important in virtually all projects I do.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/rzwitserloot/lombok/issues/1408#issuecomment-439705214,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAKCRd4Ah2SRlBAaQKZ0q5Kk0RdF3ZUjks5uwYm_gaJpZM4NspHj
.

--
"Don't only practice your art, but force your way into it's secrets, for it
and knowledge can raise men to the divine."
-- Ludwig von Beethoven

Regarding the "value"
As my example above shows:

------------------------
public class Example {

 public static void main() {
  //
  // Autobots
  //
  Autobot optimus = Autobot.optimus().build();
  Autobot bumblebee = Autobot.bumblebee().build();
  //
  // Decepticons
  //
  Decepticon megatron = Decepticon.megatron().build();
  Decepticon soundwave = Decepticon.soundwave().build();
  //
  // Transformers
  //
  Transformer[] transformers = {
    Transformer.optimus().build(),
    Transformer.bumblebee().build(),
    Transformer.megatron().build(),
    Transformer.soundwave().build(),
  //
  //...
  //
 }
}

In other words:

make a discovery of a "contract" implementors as easy as possible at the codding time.
hide details of their construction

Note: 2 - is of less importance than 1, but nice to have.

Regarding the frequency of use
I can't reveal details of my projects of course.
But, empirically, every project has Interfaces and their implementations, right?

As an example, let's say, I have a BinaryExpression (abstract class) and plenty of its subclasses: Addition, Subtraction, Multiplication, Division, Modulo, etc. etc.
So, ideally, I'd like my IDE to auto-suggest this:
BinaryExpression.
                 addition()
                 subtraction()
                 multiplication()
                 division()
                 modulo()
                 ...

And, it would be silly of me to expect it would auto-suggest this:
new
    ??????

(...actually why not?!?!)
new BinaryExpression
    Addition
    Subtraction
    Multiplication
    Division
    Modulo
    ...

Another example, from the apps world.
Let's say, I have a Controller (interface) and its implementors: UserController, DataController, etc.. And also Service (interfaces) and its implementors: UserService, DataService, etc.
Now if I'm in the Spring world - great! I can both instantiate and tie controllers and services together.
Otherwise I would have to do that myself. Than the Factory approach would be of help, of course.
Now, as for Point 1 - I would really love the package auto-scanning for implementors of interest.
But, as the discussion above goes, it's a tougher task for Lombok team: https://github.com/rzwitserloot/lombok/issues/1408#issuecomment-439678883 .
So I'm fine with manually maintaining this implementors list.
For now... :)

Out of curiosity: Why exactly do you use this pattern so much? What is the value of that pattern?
…
On Sun, Nov 18, 2018 at 5:24 PM Pavel Bekkerman @.***> wrote: BTW: The generated code you propose is not an example of the factory pattern as described by the GoF. Typically you have an interface as return type, because you want to allow to redefine which class to instantiate. Including this would further increase the annotations parameters. I don't know if anyone would ever want of to become a fully-blown GoF. I'm seeing @factory https://github.com/factory annotation as a simply: "Add here constructor methods for enlisted subclasses of the annotated class." This simple feature is very important in virtually all projects I do. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#1408 (comment)>, or mute the thread https://github.com/notifications/unsubscribe-auth/AAKCRd4Ah2SRlBAaQKZ0q5Kk0RdF3ZUjks5uwYm_gaJpZM4NspHj .
-- "Don't only practice your art, but force your way into it's secrets, for it and knowledge can raise men to the divine." -- Ludwig von Beethoven

Right.
Well, I get why you find that useful. But I think that once you know the
name of the class you want to instantiate the usefulness of this kinda ends.
You're right. The IDE should be able to discover implementers of an
interface somehow. And honestly, doing it with inheritance? That kind of
sucks, if only because usually inheritance is the wrong tool for the job.
(almost always, in fact. There are a few narrow cases where it's better
than interfaces or delegate objects, but not many).
On Tue, Nov 20, 2018 at 9:51 PM Pavel Bekkerman<EMAIL_ADDRESS>wrote:

Regarding the "value"
As my example above shows:

------------------------public class Example {
public static void main() {
//
// Autobots
//
Autobot optimus = Autobot.optimus().build();
Autobot bumblebee = Autobot.bumblebee().build();
//
// Decepticons
//
Decepticon megatron = Decepticon.megatron().build();
Decepticon soundwave = Decepticon.soundwave().build();
//
// Transformers
//
Transformer[] transformers = {
Transformer.optimus().build(),
Transformer.bumblebee().build(),
Transformer.megatron().build(),
Transformer.soundwave().build(),
//
//...
//
}
}
In other words:

make a discovery of a "contract" implementors as easy as possible
at the codding time.
hide details of their construction

Note: 2 - is of less importance than 1, but nice to have.

Regarding the frequency of use
I can't reveal details of my projects of course.
But, empirically, every project has Interfaces and their
implementations, right?

As an example, let's say, I have a BinaryExpression (abstract class) and
plenty of its subclasses: Addition, Subtraction, Multiplication, Division,
Modulo, etc. etc.
So, ideally, I'd like my IDE to auto-suggest this:
BinaryExpression.
addition()
subtraction()
multiplication()
division()
modulo()
...
And, it would be silly of me to expect it would auto-suggest this:
new
??????
(...actually why not?!?!)
new BinaryExpression
Addition
Subtraction
Multiplication
Division
Modulo
...
Another example, from the apps world.
Let's say, I have a Controller (interface) and its implementors:
UserController, DataController, etc.. And also Service (interfaces) and
its implementors: UserService, DataService, etc.
Now if I'm in the Spring world - great! I can both instantiate and tie
controllers and services together.
Otherwise I would have to do that myself. Than the Factory approach would
be of help, of course.
Now, as for Point 1 - I would really love the package auto-scanning for
implementors of interest.
But, as the discussion above goes, it's a tougher task for Lombok team: #1408
(comment)
https://github.com/rzwitserloot/lombok/issues/1408#issuecomment-439678883
.
So I'm fine with manually maintaining this implementors list.
For now... :)
Out of curiosity: Why exactly do you use this pattern so much? What is the
value of that pattern?
… <#m_-4146766576779420309_>
On Sun, Nov 18, 2018 at 5:24 PM Pavel Bekkerman @.***> wrote: BTW:
The generated code you propose is not an example of the factory pattern as
described by the GoF. Typically you have an interface as return type,
because you want to allow to redefine which class to instantiate. Including
this would further increase the annotations parameters. I don't know if
anyone would ever want of to become a fully-blown GoF. I'm seeing @factory
https://github.com/factory https://github.com/factory annotation as a
simply: "Add here constructor methods for enlisted subclasses of the
annotated class." This simple feature is very important in virtually all
projects I do. — You are receiving this because you are subscribed to this
thread. Reply to this email directly, view it on GitHub <#1408 (comment)
https://github.com/rzwitserloot/lombok/issues/1408#issuecomment-439705214>,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAKCRd4Ah2SRlBAaQKZ0q5Kk0RdF3ZUjks5uwYm_gaJpZM4NspHj
.
-- "Don't only practice your art, but force your way into it's secrets,
for it and knowledge can raise men to the divine." -- Ludwig von Beethoven
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/rzwitserloot/lombok/issues/1408#issuecomment-440424982,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAKCRZ2qqUHDk_6J2LD0xnclUjZ0xFcfks5uxGtFgaJpZM4NspHj
.

--
"Don't only practice your art, but force your way into it's secrets, for it
and knowledge can raise men to the divine."
-- Ludwig von Beethoven


How to obtain 12331 training videos and 444 test videos from VoxCeleb?

In vox-metadata.csv, there are 19550 video chunks for training (3354 unique video_id) and 525 video chunks (90 unique video_id) for testing. How do you obtain 12331 training videos and 444 testing videos as stated in the paper?

In vox-metadata.csv, there are 19550 video chunks for training (3354 unique video_id) and 525 video chunks (90 unique video_id) for testing. How do you obtain 12331 training videos and 444 testing videos as stated in the paper?

Seems to be solved in https://github.com/AliaksandrSiarohin/video-preprocessing/issues/6#issuecomment-625406386

Noted. Thank you for the reference.


how to use this data toolkit

[background]
I want to use my own text-image datasets to generate binary format dataset for CogView training in 'https://github.com/THUDM/CogView'. It has been mentioned in that repo the author use this cogdate toolkit to preprocess data.
[question]
Would you please tell me how to organize my raw text-image dataset, and then how to use the cogdata toolkit to generate the target bin file?  for example, whether i should name the a text-image pair the same, such as 'a dog sits on the ground.txt' and 'a dog sits on the ground.png', or i should take other forms?

I am too busy to write a tutorial, can you help him? @yzy-thu

@xiaocaijizzz
More detailed documentation is here : 'https://sleepychord.github.io/cogdata/build/html/index.html'.
For example, you can use '--data_format TarDataset --data_files path_to_your_tar', or '--data_format ZipDataset --data_files path_to_your_zip' while creating dataset.
Images in zip are like '1.jpg, 2.jpg .....'
Then I recommend you use '--text_format dict --text_files path_to_your_txt'.
Text files are like : "{'1':'a dog sits on the ground', '2':'cat', ....}"


Add setHeader method for sending custom headers to Gotenberg

If you need to set arbitrary headers when making requests to Gotenberg you can use ApiModule::trace with a custom header name as a workaround, but figured it'd make sense to have it as a dedicated function and update ApiModule::trace to use it instead.

Hello @indygriffiths! Thanks for the MR!
However, you are already able to do so with:
<?php

$request = Gotenberg::chromium('http://localhost:3000')
    ->url('https://my.url');
$request->withHeader("X-Foo", "bar");
$response = $client->sendRequest($request);

Ah didn't spot that RequestInterface exposes that method, thanks!


Update README.md (#56)

Update README.md

This change is

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


urlUtils: Pass in component options with parameters

Maybe we can create a structure here where components can have position?
e.g. "top-right"
https://github.com/Esri/application-base-js/blob/master/support/urlUtils.ts#L48

It would be dependent on the View UI props. https://developers.arcgis.com/javascript/latest/api-reference/esri-views-ui-DefaultUI.html#components

So should it be: components=[{0,top-left,zoom},{0,bottom-left,compass}]?

@alaframboise open an issue for the JSAPI first. We can't do it until its supported in the API.

@driskull I'm not clear why we need an API issue. This is the same as creating a camera and viewpoint - you have decompose the URL and build with the JS API. In this case it might look something like this:
componentsUrl.foreach(function(item)) {
  var component = createComponent(item[2])
  view.ui.add([
  {
    component: component,
    position: item[1],
    index: item[0]
  });
});

@alaframboise because the API provides an easy way to add components. I don't want to build a different version of it in the boilerplate.

@driskull might be good to include something like this in one of the default boilerplate samples?

@alaframboise sure if you think it will be a commonly used pattern we can easily update a sample to show this. Feel free to submit a pull request with the new sample - or revision to an existing one.
Thanks


ProxyCommand updated for copy ssh pub key

Added aws ssm command to copy pub ssh key to bastion instance

 Update SSM-bastion tunnel in terraform-aws-ec2-bastion module


Renaming changes in azurestackadmin module

updating canary tests for renaming to AzS in admin powershell module

making the PR against https://github.com/Azure/AzureStack-Tools/tree/renamestaging


Update graph_batch.py

My Python is very rusty, but I had a crack at adding a while loop to the retry loop, I added a pool count with a max count set in the variables so it doesn't go forever, it will pop out an error with failed count if it fails.
I also increased the base wait_time to 20s in the handle_responses function.
I reinitialised the retry_pool after the batch_list is created and before the batch is called, this is so it can actually reach 0.
Tests OK on my system, although it recovers very slowly until stop the 2nd instance, as I am overloading the api on purpose, when the 2nd job stops it will recover after a few min

Alternative Fix implemented in main


Trivial updates to the coercions chapter

The modern way is `dyn Trait
Use compile_fail instead of ignore, to make sure it doesn't start
compiling by accident in some future version of Rust (and also to
provide link to playground).

Thanks!


Add support for AllWinner CPUs (Banana Pi and Orange Pi)

Info
Raspberry Pi's have become "unobtanium" with the current chip shortage. Because of this, I think RaSCSI should be expanded to work with other Raspberry Pi compatible clones, such as the Banana Pi or Orange Pi.

Which version of Pi are you using:
Banana Pi M2 Zero
Which github revision of software:
22.02
Which board version:
Any
Which computer is the RaSCSI connected to:
Any

Describe the issue
The GPIO low level software interface of the Banana Pi M2 Zero (Allwinner H3 CPU) does not appear to be compatible with the RaSCSI service. It would probably be possible to use a higher level GPIO interface (such as wiring Pi), but that is likely going to kill the performance.
Additional details
The RaSCSI gpiobus.cpp is looking for a /proc entry at /proc/device-tree/soc/ranges. The Banana Pi does not have this proc entry. However, the general "gpio" utility seems to work.
I'm going to use this issue to document the notes that I find and any progress that I make. If anyone has a Banana Pi and wants to help, I would welcome it!
Todo list:

Try latest version of Armbian
Buildroot has a defconfig for the Banana Pi. Potentially give that a try?
Maybe some clues in the Allwinner H3 Datasheet

FYI: https://wiki.banana-pi.org/Banana_Pi_BPI-M2_ZERO

@akuker Wouldn't it be better to address the numerous open issues instead of spending time on new ports? There is no automated testing, no code analysis etc. that would ensure that any changes for new platform don't break existing code. You often say you are lacking time, a new port would not help with that ;-).

I think this is a high priority feature due to the extreme ongoing scarcity of Raspberry Pis. It is practically impossible to get into RaSCSI as someone who doesn't already own a Pi, which really does the project a disservice.
That said, introducing unit testing and static analysis first would be incredibly beneficial for maintaining confidence in code quality while making low-level changes! :)

I just created https://github.com/akuker/RASCSI/issues/703, which is related to the question on how to test, and also on how to support other hardware without affecting most of the existing code. Once more the lack of code modularity and well-defined interfaces becomes apparent. This cannot resolved by just adding some #ifdefs here and some work-arounds there ;-).

I just created https://github.com/akuker/RASCSI/issues/703, which is related to the question on how to test, and also on how to support other hardware without affecting most of the existing code. Once more the lack of code modularity and well-defined interfaces becomes apparent. This cannot resolved by just adding some #ifdefs here and some work-arounds there ;-).

@uweseimet I can only speculate, but the Banana Pis are simply not well known among the general populace, and are only traded directly from China. Lower pressure on their stock, and the proximity to manufacturing plants in China perhaps means that they can keep up with demand easily, while RPis are on backorder everywhere which has a cumulative effect on demand. But I digress. Someone with an economics major could probably explain this more accurately. :)
@akuker The going price on Aliexpress for a Banana Pi M2 Zero seems to be about $30 with shipping. Is this what you paid as well?

Wouldn't it be better to address the numerous open issues instead of spending time on new ports?

I agree that the open issues are important. There were other folks in the discord channel who were interested in this same thing. I can't speak to WHY officially rapsberry pi's are so hard to purchase, but these clones are available. My PhD in supply chain analysis isn't quite done yet ;-) I've had several inquiries from folks who wanted to get involved in the project, but they can't find Raspberry Pi's.
For me, this will be a background task. When I'm watching TV, I'll be browsing Allwinner documentation and maybe poking at Armbian builds. I really think the changes will be limited to the gpiobus.cpp class. Other than the low level GPIO interface, the code should be the same.
Regarding #703 - I would like to abstract the gpiobus.cpp class so that we could have different sub-classes:

Raspberry Pi GPIO (current implementation)
Allwinnner GPIO
Simulated GPIO (would work great for implementation - maybe just used shared memory or something?)

But again, this is lower priority for me. We should make better use of the "bug" label in the issue list. This will help us focus on those items instead of the enhancements. Right now there are only a couple issues tagged as "bug", so I'd welcome help with tagging the ones that are true bugs.

@akuker I doubt that there are (many) issues that are bugs but are not labelled as bugs. Is there any way to prioritize issues with github? Just with labels it is hard to prioritize.

@akuker Regarding a simulated GPIO I don't see (maybe I am missing something) how shared memory would help here. I guess a kind of state machine would be needed, something that remembers and can change the status of the bus signals. I would expect the methods gettting/setting the signals would be the ones that end up iin different implementations (all implementing the same interface), for different hardwares or just the simulation.

@akuker Regarding prioritization, maybe github supports a Scrum board, which may make working with priorities easier. On the other hand, being able to pick any open ticket you like (which is NOT Scrum) is IMO important for projects like RaSCSI, where contributions are voluntary and the skills of the contributors are unlikely to match the order of prioritized tickets.

https://armbian.hosthatch.com/archive/bananapim2zero/archive/Armbian_21.08.1_Bananapim2zero_hirsute_edge_5.13.12.img.xz
https://armbian.hosthatch.com/archive/bananapim2zero/archive/

https://wiki.banana-pi.org/Getting_Started_with_M2_Zero#Advanced_Development

@akuker Any news on this? Pis are still almost unavailable.

No news - doesn't work. Closing ticket. If someone finds time to work on this, we can reopen.


Do not return error when flag parsing should be skipped

Closes #208
cc @codegangsta @jszwedko
FWIW I'm not in favor of removing SkipFlagParsing in general as it's proven useful in a couple of situations for us so far.  Granted, that may not be the best thing for all users.
Signed-off-by: Nathan LeClaire<EMAIL_ADDRESS>

I know it may not be the most elegant implementation, but this seems to be the most non-intrusive solution I've come up with so far and includes a test case which fails on master but passes in this branch.

Hi @nathanleclaire, thanks for the submission!
I took a look at the PR that introduced this (https://github.com/codegangsta/cli/pull/80) and am a bit confused about its intention. The naming, SkipFlagParsing makes me think that it should skip all flag parsing, but it seems like it is just skipping reordering of flags and args and still ultimately calls set.Parse. I think it'd be better to skip the flag parsing in general when this flag is specified, but it will break backwards compatibility so it is worth a second thought. Are you relying on that behavior?

The naming, SkipFlagParsing makes me think that it should skip all flag parsing, but it seems like it is just skipping reordering of flags and args and still ultimately calls set.Parse

Yeah, I was really confused by that as well.

I think it'd be better to skip the flag parsing in general when this flag is specified, but it will break backwards compatibility so it is worth a second thought. Are you relying on that behavior?

We're not relying on flag parsing (i.e. the results of c.Args or c.String etc. populated) when we have SkipFlagParsing set to true.  In that case we handle any needed querying of the CLI args manually.

@jszwedko How are you feeling on this?  OK to merge it in its current form?  It should have minimal impact on existing use cases outside of SkipFlagParsing.

@nathanleclaire apologies for the delay! I think it'd be least confusing to just skip flag parsing in its entirety if the field is set (even if this breaks things depending on this strange behavior). To this end I put together #283 with your commit and then one more just removing flag parsing if SkipFlagParsing is set.

I'll test #283 and see how it works for our use case.  Thanks!

Commented on one issue I have with the proposed PR in that thread.

This is covered by the referenced issue.


[Fix] 修复未引用Str类导致在Laravel5.5 LTS版本中报错的问题

@jxlwqq can you please make a release for this ? thanks

@jxlwqq can you please make a release for this ? thanks

released


Tab completion error

I'm running powerlevel9k on archlinux (antergos). My locale is set to en_GB.UTF-8, though I also have en_US.utf8 installed. If I open a terminal and type a,p,tab, then it shows options for completion, but changes the text at the prompt to aap. Hitting Ctrl+l clears the screen and "fixes" it back to "ap". I'm seeing similar text offset errors when going through history, etc.
The only two customisations in zshrc are (though with these commented out, the issue persists):
export POWERLEVEL9K_HOME_FOLDER_ABBREVIATION=""
export POWERLEVEL9K_HOME_SUB_ICON="%F{black}$(print_icon 'HOME_ICON')%F{black}"

If I switch the theme to agnoster, the completion errors go away.
Any ideas?

Hm, not really sure what might be going on, to be honest. That sounds strange. If you switch to en_US do you see the same issue?
By the way, I'm not sure about your HOME_SUB_ICON setting - you never close your color setting with %f, which I think you may want to do at the end of that string?

@ashic - Just a ping on my question, above?

Closing due to inactivity. Feel free to re-open if you need to!

This might be an issue with ZSH, not powerlevel9k. I have this same problem, but only when I switch to the root user (with either su - or sudo -i or sudo -sE). I switched to the agnoster theme & noticed the same issue.


Status field does not show in all OneDrive folders

Description
Many of my OneDrive folders do not show the status field.
Also, whern right clicking on header fields, like to have a size all like in file explorer.
Steps To Reproduce
No response
Expected behavior
Status field should show on all OneDrive items. I have a screen shot but I do not see where to attach it.
Files Version
Version: <IP_ADDRESS> OS Version: 10.0.19043.1237
Windows Version
2181 (OS build 19043.1237)
Relevant Assets
No response

Bumping to #7922


Is there a list of all the redis commands supported by dynomite?

I was looking through http://www.dynomitedb.com/docs/key-value-api/v0.5.8/introduction/ and under clients it says, DynomiteDB supports the Redis protocol and the majority of Redis commands. I was just wondering what are the redis commands that dynomite doesn't support?

https://github.com/Netflix/dynomite/blob/dev/notes/redis.md

Let us know if your question has been answered. Thanks!

awesome! That's exactly what I needed. Thanks!


Thanks for nice great information

I thought of updating firmware using by setup.exe and  other third party provided by the OEM .
But after reading this article , i wondered how the windows os  updates particular unique  firmware to respective unique device . I am totally  wondered how the windows was designed to update the uefi firmware. Last 25-05-2017 , i received  bios uefi firmware via device manager , this windows 10 updated without problems . I say thanks to  asus  development team for released bios v 307 and  the windows os development team for provided  correct bios.
Moreover i like to humble thanks to  all authors who are all contributed to this article with their practical knowledge.
I wish all the best to all the authors. Keep  updating new articles with more attractive  video lecturers if possible

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1b4320a0-085e-4ca1-e83a-1b030b480100
Version Independent ID: 5e474f7e-998e-1d76-49e7-fbc67ca1071d
Content: Windows UEFI firmware update platform - Windows drivers
Content Source: windows-driver-docs-pr/bringup/windows-uefi-firmware-update-platform.md
Product: windows-hardware
Technology: windows-devices
GitHub Login: @barrygolden
Microsoft Alias: bagold

Thanks @RAJU2529!
Happy to hear that your ASUS device firmware updated successfully under Windows 10.


Add older version of Parallels to macos-12

Tool name
Parallels + Parallels SDK
Tool license
Paid.
Add or update?

[ ] Add
[X] Update

Desired version
older version of Parallels - 19.3.0-54924 and Parallels SDK - 19.3.0-54924
Approximate size
No response
Brief description of tool
On Macos-12 we have Parallels v19.4.1-54985 installed. However, we cannot start a Windows 11 VM using this version.
Can we install an older version of Parallels 19.3.0-54924 on Macos-12?
URL for tool's homepage
https://download.parallels.com/desktop/v19/19.3.0-54924/ParallelsDesktop-19.3.0-54924.dmg
Provide a basic test case to validate the tool's functionality.
No response
Platforms where you need the tool

[ ] Azure DevOps
[ ] GitHub Actions

Runner images where you need the tool

[ ] Ubuntu 20.04
[ ] Ubuntu 22.04
[ ] Ubuntu 24.04
[X] macOS 12
[ ] macOS 13
[ ] macOS 13 Arm64
[ ] macOS 14
[ ] macOS 14 Arm64
[ ] Windows Server 2019
[ ] Windows Server 2022

Can this tool be installed during the build?
No response
Tool installation time in runtime
around 1 minute
Are you willing to submit a PR?
Yes

@zadesai, Will take a look into this issue. Will keep you posted.

@zadesai,  We were able to start "Windows 11" VM successfully using  Parallels v19.4.1-54985 in our local (used trial version in local since we do not have the license). Can you please check if the issue is related to your license?
Also please share us a workflow with the error you are facing.

@sureshe456 we use Packer to create and start our Parallels vm. Packer-Parallels plugin uses "prlctl start" command to start the vm. When "prlctl start" is called, we get an operation canceled error.
I am curious about testing the runner macos images locally, can you share the steps for it? I can try running my script locally on them.

Hi @zadesai Sorry for delay response.Can you please validate parallels of windows 11 once on macOS 12/13 images with the newer version as mentioned below since we don't have license to test parallels with older version.
New Version parallels : https://download.parallels.com/desktop/v20/20.0.1-55659/ParallelsDesktop-20.0.1-55659.dmg
Older version paralles: https://download.parallels.com/desktop/v19/19.3.0-54924/ParallelsDesktop-19.3.0-54924.dmg

Hi @zadesai, We are closing the issue for now. If you face the same issue again, it can be reopened and we will work on it.


x/playground: ExampleNoOutput test is flaky

When running the playgrounds within the Dockerfile, it sometimes fails with
Step 60/62 : RUN /app/playground test
 ---> Running in 8fbf8f5df18a
App (project ID: "") is NOT caching results
2018/03/30 23:30:42 unexpected output: "PASS\ntesting: warning: no tests to run\n", want "testing: warning: no tests to run\nPASS"

after updating the test code, it will sometimes fail with:
Step 60/62 : RUN /app/playground test
 ---> Running in 411206ccfd4d
App (project ID: "") is NOT caching results
2018/03/30 22:51:30 unexpected output: "testing: warning: no tests to run\nPASS\n", want "PASS\ntesting: warning: no tests to run"

The output seems non-deterministic, which is odd.
@ysmolsky

I am unable to reproduce this.  When I run make test using macOS native Docker I have different step numbers:
...golang.org/x/playground (master $=) % git a
* 76d1738 - (HEAD -> master, origin/master, origin/HEAD) playground: support examples as tests

... SKIPPED ...
Step 45/48 : WORKDIR /app
Removing intermediate container 7782ffd5187f
 ---> 87a0a8813a76
Step 46/48 : RUN /go/bin/playground test
 ---> Running in 8188688d1019
App (project ID: "") is NOT caching results
OK
Removing intermediate container 8188688d1019
 ---> 226e01540b07
Step 47/48 : EXPOSE 8080
 ---> Running in d7deedd5a872
Removing intermediate container d7deedd5a872
 ---> cebe18a41b3c
Step 48/48 : ENTRYPOINT ["/go/bin/playground"]
 ---> Running in df745592a4fd
Removing intermediate container df745592a4fd
 ---> 91f5b1decaa6
Successfully built 91f5b1decaa6
Successfully tagged playground:latest
go test
PASS
ok  	golang.org/x/playground	0.018s

Does it happen for the commit 76d1738?

That particular test is the only which expect output of two different kinds in Events slice: [{"testing: warning: no tests to run\n" "stderr" "0s"} {"PASS\n" "stdout" "0s"}]
Trying to write to stderr and stdout gives inconsistent output when writing both to stderr and stdout at the same "playground time":
https://play.golang.org/p/8du1N7eAxmq
https://play.golang.org/p/yky_PWrcZvu
This program produces correct order on local playground.

And then I got to this function: https://github.com/golang/go/blob/master/src/runtime/sys_nacl_amd64p32.s#L63
TEXT runtime·write(SB),NOSPLIT,$16-20
	// If using fake time and writing to stdout or stderr,
	// emit playback header before actual data.

https://github.com/golang/go/commit/242050d07f1becd35d5990d7728403ea4eece5c3
ping @minux

Of course we can resort to just fixing the test and closing the issue. Then spawn another issue for fixing stdout/stderr messed up order.
@andybons, what do you think?


Add DeFiat Space

Add space for DeFiat
This PR is blocked until the relevant strategy from this PR is merged: https://github.com/snapshot-labs/snapshot.js/pull/30
Updated space with contract-call strategy, sums all DFT network power fairly. Voting Power algorithm explained in source: https://etherscan.io/address/0xf4ecf04c1d77029a848a8efe33f08f0a27058f3d#code
Etherscan: https://etherscan.io/token/0xB6eE603933E024d8d53dDE3faa0bf98fE2a3d6f1
CoinGecko: https://www.coingecko.com/en/coins/defiat
Website: https://defiat.net
Twitter: https://twitter.com/DeFiatCrypto
Medium: https://defiat.medium.com

@gokaiorg Updated my PR based on the suggestions from @bonustrack. Ready for review whenever you are available. Thanks mate!


Rework TLS generation

Right now using local scripts and kubeseal.  Would rather do something that doesn't have such a local dependencies - but still lightweight.  Vault might be an option, but also pretty heavy.  Leaning toward a light-weight container that has cfssl baked in - and that had enough permissioned to generated sealedsecrets (which can then be exported/saved off).

A few ideas:
Just sign the cert with Kubernetes interanl CA and the CA API within k8s itself.  https://kubernetes.io/docs/tasks/tls/managing-tls-in-a-cluster/

Old cluster issues, closing


Add new ping command

Depends on https://github.com/planetscale/planetscale-go/pull/186
I'm not sure what all goes into adding a new command, but I assume documentation and whatnot.
I'm also very open to how to display this information, but right now, we get a table like:
  ENDPOINT (17)                                    LATENCY   TYPE
 ------------------------------------------------ --------- -----------
  aws.connect.psdb.cloud                           32.9ms    optimized
  us-west.connect.psdb.cloud                       35.7ms    direct
  gcp-us-central1.connect.psdb.cloud               57.3ms    direct
  gcp.connect.psdb.cloud                           59ms      optimized
  aws-us-east-2.connect.psdb.cloud                 60.4ms    direct
  gcp-us-east4.connect.psdb.cloud                  68.5ms    direct
  us-east.connect.psdb.cloud                       71ms      direct
  gcp-northamerica-northeast1.connect.psdb.cloud   83.4ms    direct
  ap-northeast.connect.psdb.cloud                  122.4ms   direct
  aws-ap-southeast-2.connect.psdb.cloud            146.9ms   direct
  gcp-asia-northeast3.connect.psdb.cloud           153.9ms   direct
  eu-central.connect.psdb.cloud                    155.1ms   direct
  aws-eu-west-2.connect.psdb.cloud                 163.5ms   direct
  eu-west.connect.psdb.cloud                       173.9ms   direct
  aws-sa-east-1.connect.psdb.cloud                 182.1ms   direct
  ap-southeast.connect.psdb.cloud                  195.8ms   direct
  ap-south.connect.psdb.cloud                      238.1ms   direct

I didn't really like having them all combined into 1 table, I wanted to split optimized vs direct into different groups, but our CLI's formatting definitely expects to return some JSON object for the results, so figured adding a "type" field was the best option.
But this should be able to help folks quickly diagnose what the best endpoint is for them while running from an actual VM or wherever.
There are a couple use cases for this tool:

help debug latency issues, if the "optimized" endpoint appears to be resolving wrong, this could identify where it's going wrong and if you should prefer the "direct"
If you're hosted in a provider that isn't AWS or GCP, you might not exactly know which of our regions are the closest to your server, so this tool identify the closest region.

I think this is a helpful feature, but I don't think ping should be a top-level command because there will be no subcommands for it. How would you feel about adding it under something like a debug command. This also gives us room for adding more subcommands under the debug command as necessary. What do you think?

I have no opinions, I'm fine with that.


Avoid --find-links in wheel jobs

Description
Contributes to https://github.com/rapidsai/build-planning/issues/69
Contributes to https://github.com/rapidsai/build-planning/issues/33
https://github.com/rapidsai/cugraph/pull/4509 proposed a stricter pattern for passing a pylibcugraph wheel from the wheel-build-cpp job that produced it into the wheel-build-python job wanting to use it (as a build dependency of cugraph). This change improves the likelihood that issues with the pylibcugraph wheels will be caught in CI.
This proposes porting that change here, so that when CI is set up in this repo, it'll also benefit from that strictness.

I'm not sure we need this?

By "this" you mean the use of rapids-download-wheels-from-s3 to download a wheel? That makes sense, I suspected that maybe that was just copied over from cugraph and not yet changed here.
You can close this if you'd like.
But if you do plan to keep using the "download wheels from S3 approach", then something like what I've put up here will more reliably catch issues in those wheels than the --find-links approach.

I think we should remove that file since we aren't building wheels for cugraph here.  Thanks James.

I'll make a PR removing the unneeded script.

Ok thanks, no prob! We can close this then.


endecode_test.c: Avoid running the SM2 tests with 3.0.0 FIPS provider

Fixes #25326

Merged to all the active branches. Thank you for the reviews.


updating docker and containerd versions for all AMIs except AL2022

Summary

updating docker to 20.10.13 and containerd to 1.4.13 for all AMIs except AL2022.
Implementation details

Testing

New tests cover the changes:
Description for the changelog

Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Could we add a changelog for this PR? Thanks!


Pass an excluded state from the config for aggregation

Can you open an issue to add the ability to pass an excluded state form the config for US aggregation?
I don't want this to hold up an MVP but I think we need to do this so that we can test

Originally posted by @kgostic in https://github.com/CDCgov/cfa-epinow2-pipeline/pull/17#discussion_r1746186890
As discussed over teams, it's an open question whether this kind of ad hoc selection should happen here or upstream in the data preprocessing. It's not a big deal where it lives when we only have one model, but we may want to be more careful about it when we start running multiple models for comparison.

How would this happen in upstream preprocessing? Is there any preprocessing functionality in this package at the moment?
If we were to add this option to exclude a state from the US aggregate, I think it'd be helpful to keep this information as metadata somehow.
It does seem to me that we would want to be doing this type of thing upstream and keeping this read_data function to just states or the whole US (with whatever exclusions applied). We might also want to be doing specific exclusions of facilities from states so adding infrastructure to just remove states seems to be opening a can of worms.


Update azure-portal-safelist-urls.md

in Azure portal BMX team integrated Centro modules, so include those centro end points

@JnHs
Can you review the proposed changes?
When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

Hello @stylishvinod  - thank you for taking the time to create this PR, and I'm sorry for the delay in reviewing. At this time we don't generally recommend that all customers unblock these endpoints, although certain customers may depending on their scenarios - as our page says, "you may want to add URLs related to other Microsoft products and services".
I'll close this PR now, please let us know if you have further feedback and thank you again for this submission.
#please-clsoe


Direct YouTube URL support

I wanted to propose the idea of providing the exact url to the song to musicnow and bypassing the query / select stage.
Suppose you use the query method but you find that the result you choose was bad quality or was a weird live version or some MIDI remix.
Ideally I would like to personally verify which link I'd want and provide that to musicnow to workout the rest. Perhaps using a -u / --url argument to separate this functionality from the default.
I'm willing to try and make a pull request (I've never developed using python but willing to learn), I would just like to know your opinion on something like this.

This seems like a great idea and the points you bring up are valid. If you'd like to work on this, I'd be happy to merge your pull request. The only difficulty I believe you might face is that the download_song method requires the url and the title. You will have to find a way of extracting the title through the url, or you could make the title argument optional in download_song and make the required changes in download_song

Also, currently this project is very messed up. I am not proud of the code in it and there are no tests too. I believe once I'm free during a weekend, I'll end up redesigning the entire codebase and I will probably use musictools.
So, I suggest that rather than making changes in the download_song method in this project, you should head over to musictools and add the necessary changes in the download_song method over there. Basically you'll have to make the title parameter a default argument, and make the necessary changes in the downloading of the song through youtube-dl.
Adding an option for this on argparse over here would be an easy task.

So, I suggest that rather than making changes in the download_song method in this project, you should head over to musictools and add the necessary changes in the download_song method over there. Basically you'll have to make the title parameter a default argument, and make the necessary changes in the downloading of the song through youtube-dl.

That makes sense, thanks for the input, I will start with musictools 😄


loading thepackage

The package does not load if \usepackage{Simple} is declared in the preamble as suggested in the sample .tex file. Rather, \usepackage{SimpleDarkBlue} works.

Hi,
In sample.tex file, I used \usetheme{Simple} instead of \usepackage{Simple}.
https://github.com/PM25/SimpleDarkBlue-BeamerTheme/blob/caf70aa3b77b121036ef7e8ae9ac1c3c86fda6ad/sample.tex#L5
I did not find any problems compiling sample.tex.
I'm using XeTeX 3.14159265-2.6-0.999992 (TeX Live 2020/W32TeX)
Please let me know if you still experience this problem. Thanks!

However, I find it quite confusing with different style file names. I will rename all the files with SimpleDarkBlue at the end.


Popup not showing.

In the latest version (v1.5.5) after the update, the popup window will not show when the button is clicked.

this is what console shows :

Same error.
logseq version: 0.10.1
git plugin version: 1.5.5

Same error. 同样的错误。

These two versions work fine.
logseq verson: 0.10.3
git plugin version: 1.5.5

The latest version of Logseq （0.10.3） has made some changes, and 1.5.5 is released to adapt to the new version.
If you are using an older version of logseq, you can download the old version plugins in the release.

@haydenull Yes that's true, the issue is not present in the latest version of logseq v0.10.3


Move static Entity lookup maps to EntityTracker

EntityTrackerEntry exists to ensure the same behavior as before in regards to the recorded position in the tracker.

Putting an entity in an instance which already contains that ID or UUID should throw an exception

Putting an entity in an instance which already contains that ID or UUID should throw an exception

It will from the (using Checks) assertion in EntityTracker.