Prometheus Config Generation Can Build Invalid Config Due To Inability To Skip Specific GCE Metadata Tags

In some cases the gce metadata may have info that is completely unnecessary/unhelpful as a metric label and should not be included. Specifically when you have metadata_startup_script set to a long script that is included as a huge label in the generated scrape config. This can cause you to run into an almost identical issue as https://github.com/GoogleCloudPlatform/ops-agent/issues/1221 where parts of that startup script are attempted to be interpreted leading to the otel agent unable to start the metrics portion of the service.
Can metadata_startup_script (startup_script) always be excluded from https://github.com/GoogleCloudPlatform/ops-agent/blob/master/confgenerator/prometheus.go#L170-L173 or can there be a config option available to disable it from being included and potentially causing the otel agent to exit due to a bad config?

@ryanohnemus Do you have an example of a startup script that causes a broken configuration?
Our metadata labels mirror upstream Prometheus's GCE service discovery, and it looks like they don't do any special handling for the startup script: https://github.com/prometheus/prometheus/blob/cf528bef034dcf078d3bff0d50224a13068c391e/discovery/gce/gce.go#L195-L205

@quentinmit thank you for the quick reply!
I am unable to share the entire script, but the part that breaks looks like this:
#Variables
LOGFILE=${LOGDIR:-/tmp}/something.out

this results in the following exit:
otelopscol[960219]: Error: failed to get config: cannot resolve the configuration: scheme "LOGDIR" is not supported for uri "LOGDIR:-/tmp"

The config.yaml we use to configure opsagent doesn't contain any of the LOGDIR info it comes directly out of the startup-script GCE Custom metadata field and the https://github.com/GoogleCloudPlatform/ops-agent/blob/master/confgenerator/prometheus.go#L170-L173  lines don't filter out that specific metadata key, resulting in a pretty large (full script) prometheus label being created in the generated /run/google-cloud-ops-agent-opentelemetry-collector/otel.yaml file.
(Also I forgot to mention we are ops-agent version 2.42.0, which is 1 version from the latest).
Let me know if i can provide any more details!

@ryanohnemus Would you be able to share your config.yml? That plus your previous comment should give us enough info to reproduce this.

@igorpeshansky here is what I am using in the metrics section of the config.yml
metrics:
  receivers:
    metrics_endpoint:
      type: prometheus
      config:
        scrape_configs:
          - job_name: 'metrics_endpoint'
            static_configs:
              - targets: ['localhost:9090']
            scrape_interval: 10s
  service:
    pipelines:
      prometheus_pipeline:
        receivers: [metrics_endpoint]

Related to #1221 and #1239.


no matches for kind "NatsCluster" in version "nats.io/v1alpha2"

% kubectl  logs deployment/nats-operator
time="2022-05-20T00:37:20Z" level=info msg="nats-operator Version: 0.8.2"
time="2022-05-20T00:37:20Z" level=info msg="Git SHA: 4f36153"
time="2022-05-20T00:37:20Z" level=info msg="Go Version: go1.15.6"
time="2022-05-20T00:37:20Z" level=info msg="Go OS/Arch: linux/amd64"
time="2022-05-20T00:37:20Z" level=info msg="nats-operator is operating at the namespace scope in the \"default\" namespace"
E0520 00:37:20.723740       1 event.go:296] Could not construct reference to: '&v1.Endpoints{TypeMeta:v1.TypeMeta{Kind:"", APIVersion:""}, ObjectMeta:v1.ObjectMeta{Name:"nats-operator", GenerateName:"", Namespace:"default", SelfLink:"", UID:"3b83caed-d4ef-4bfd-b61f-abe4fe0d647a", ResourceVersion:"111650", Generation:0, CreationTimestamp:v1.Time{Time:time.Time{wall:0x0, ext:63788597310, loc:(*time.Location)(0x1dec6c0)}}, DeletionTimestamp:(*v1.Time)(nil), DeletionGracePeriodSeconds:(*int64)(nil), Labels:map[string]string(nil), Annotations:map[string]string{"control-plane.alpha.kubernetes.io/leader":"{\"holderIdentity\":\"nats-operator-74f4c74ff9-wfzrb\",\"leaseDurationSeconds\":15,\"acquireTime\":\"2022-05-20T00:34:27Z\",\"renewTime\":\"2022-05-20T00:37:20Z\",\"leaderTransitions\":7}"}, OwnerReferences:[]v1.OwnerReference(nil), Initializers:(*v1.Initializers)(nil), Finalizers:[]string(nil), ClusterName:"", ManagedFields:[]v1.ManagedFieldsEntry{v1.ManagedFieldsEntry{Manager:"nats-operator", Operation:"Update", APIVersion:"v1", Time:(*v1.Time)(0xc00046c180), Fields:(*v1.Fields)(nil)}}}, Subsets:[]v1.EndpointSubset(nil)}' due to: 'selfLink was empty, can't make reference'. Will not report event: 'Normal' 'LeaderElection' 'nats-operator-74f4c74ff9-wfzrb became leader'

time="2022-05-20T00:37:20Z" level=fatal msg="unexpected error while running the main control loop: the server could not find the requested resource"

Seems like NATS CRD was not installed successfully. (referred https://github.com/nats-io/nats-operator/blob/master/README.md )
kubectl get crd doesn't show nats CRD as well.
I am running kubernetes on minikube vm-driver = docker.

I also followed the steps for deployment-rbac.yaml.
$ kubectl get -n nats-io pods
NAME                             READY   STATUS    RESTARTS   AGE
nats-operator-58885f8dd6-tcq5n   1/1     Running   0          6m12s
```

```
$ kubectl logs nats-operator-58885f8dd6-tcq5n -n nats-io
time="2022-05-20T00:52:58Z" level=info msg="nats-operator Version: 0.2.0-v1alpha2+git"
time="2022-05-20T00:52:58Z" level=info msg="Git SHA: 4040d87"
time="2022-05-20T00:52:58Z" level=info msg="Go Version: go1.9"
time="2022-05-20T00:52:58Z" level=info msg="Go OS/Arch: linux/amd64"
E0520 00:52:58.214157       1 event.go:260] Could not construct reference to: '&v1.Endpoints{TypeMeta:v1.TypeMeta{Kind:"", APIVersion:""}, ObjectMeta:v1.ObjectMeta{Name:"nats-operator", GenerateName:"", Namespace:"nats-io", SelfLink:"", UID:"10d14d01-c2d4-49fc-b290-5f4164823c0f", ResourceVersion:"112496", Generation:0, CreationTimestamp:v1.Time{Time:time.Time{wall:0x0, ext:63788604778, loc:(*time.Location)(0x1d49d80)}}, DeletionTimestamp:(*v1.Time)(nil), DeletionGracePeriodSeconds:(*int64)(nil), Labels:map[string]string(nil), Annotations:map[string]string{"control-plane.alpha.kubernetes.io/leader":"{\"holderIdentity\":\"nats-operator-58885f8dd6-tcq5n\",\"leaseDurationSeconds\":15,\"acquireTime\":\"2022-05-20T00:52:58Z\",\"renewTime\":\"2022-05-20T00:52:58Z\",\"leaderTransitions\":0}"}, OwnerReferences:[]v1.OwnerReference(nil), Initializers:(*v1.Initializers)(nil), Finalizers:[]string(nil), ClusterName:""}, Subsets:[]v1.EndpointSubset(nil)}' due to: 'selfLink was empty, can't make reference'. Will not report event: 'Normal' 'LeaderElection' 'nats-operator-58885f8dd6-tcq5n became leader'
time="2022-05-20T00:52:58Z" level=error msg="initialization failed: fail to create CRD: the server could not find the requested resource" pkg=controller
time="2022-05-20T00:52:58Z" level=info msg="retry in 30s..." pkg=controller
time="2022-05-20T00:53:28Z" level=error msg="initialization failed: fail to create CRD: the server could not find the requested resource" pkg=controller
time="2022-05-20T00:53:28Z" level=info msg="retry in 30s..." pkg=controller
time="2022-05-20T00:53:58Z" level=error msg="initialization failed: fail to create CRD: the server could not find the requested resource" pkg=controller
time="2022-05-20T00:53:58Z" level=info msg="retry in 30s..." pkg=controller
time="2022-05-20T00:54:28Z" level=error msg="initialization failed: fail to create CRD: the server could not find the requested resource" pkg=controller
time="2022-05-20T00:54:28Z" level=info msg="retry in 30s..." pkg=controller
time="2022-05-20T00:54:58Z" level=error msg="initialization failed: fail to create CRD: the server could not find the requested resource" pkg=controller
time="2022-05-20T00:54:58Z" level=info msg="retry in 30s..." pkg=controller
time="2022-05-20T00:55:28Z" level=error msg="initialization failed: fail to create CRD: the server could not find the requested resource" pkg=controller
time="2022-05-20T00:55:28Z" level=info msg="retry in 30s..." pkg=controller
time="2022-05-20T00:55:58Z" level=error msg="initialization failed: fail to create CRD: the server could not find the requested resource" pkg=controller
time="2022-05-20T00:55:58Z" level=info msg="retry in 30s..." pkg=controller
time="2022-05-20T00:56:28Z" level=error msg="initialization failed: fail to create CRD: the server could not find the requested resource" pkg=controller
time="2022-05-20T00:56:28Z" level=info msg="retry in 30s..." pkg=controller
time="2022-05-20T00:56:58Z" level=error msg="initialization failed: fail to create CRD: the server could not find the requested resource" pkg=controller
time="2022-05-20T00:56:58Z" level=info msg="retry in 30s..." pkg=controller
time="2022-05-20T00:57:28Z" level=error msg="initialization failed: fail to create CRD: the server could not find the requested resource" pkg=controller
time="2022-05-20T00:57:28Z" level=info msg="retry in 30s..." pkg=controller
time="2022-05-20T00:57:58Z" level=error msg="initialization failed: fail to create CRD: the server could not find the requested resource" pkg=controller
time="2022-05-20T00:57:58Z" level=info msg="retry in 30s..." pkg=controller
time="2022-05-20T00:58:28Z" level=error msg="initialization failed: fail to create CRD: the server could not find the requested resource" pkg=controller
time="2022-05-20T00:58:28Z" level=info msg="retry in 30s..." pkg=controller
time="2022-05-20T00:58:58Z" level=error msg="initialization failed: fail to create CRD: the server could not find the requested resource" pkg=controller
time="2022-05-20T00:58:58Z" level=info msg="retry in 30s..." pkg=controller
time="2022-05-20T00:59:28Z" level=error msg="initialization failed: fail to create CRD: the server could not find the requested resource" pkg=controller
time="2022-05-20T00:59:28Z" level=info msg="retry in 30s..." pkg=controller
```

Thanks for looking into this!!!

I ended up creating a CustomResourceDefinition, NatsCluster  -> from https://github.com/nats-io/k8s/blob/main/helm/charts/nats-operator/crds/customresourcedefinition.yaml

This is still an issue in 2024.


Compile to AOT

Hi all,
Did aqueduct support compile to AOT ?
Do you have plan to have it for the next release ?
Thanks.

This is not supported by the Dart VM outside of Flutter.

@joeconwaystk https://dart.dev/tools/dart2aot

@aaveidt https://github.com/stablekernel/aqueduct/issues/669


Drop downs for Frames will show full path names

This will help disambiguate names that could be ambiguous
Fixes issue #1025
Brief summary of changes
When populating lists of Frames, use AbsolutePathString rather than getName() this list is used in all places where Frames are used for selection
Testing I've completed
Changed frames for Marker(s) without an issue
CHANGELOG.md (choose one)

May need to update because in the past we showed only names and they were short and unique

LGTM. Tested on W10 Pro OpenSim 4.0-2018-10-17-a1ed8256.

Does this also address #1018?

This should address issues #1018, #1025, leftover of #825

Thanks @chrisdembia


Convert to TypeScript

This is loosely related to https://sanity-io-land.slack.com/archives/C9Z7RC3V1/p1601637650136800
I probably should have opened an issue instead, but I got the impression that this would be a welcome change, so I proceed.
If the team has any suggestions/ideas/wishes how things should be done, please leave a comment under! Thanks :slightly_smiling_face:

[x] ~convert files~

[x] ~fix all TS errors~

[x] ~get dom tests working~

[ ] get react native tests working

[ ] create multiple bundles

This is a minimal conversion to TS, meaning I extensively used any to silence the TypeScript checker. I added some types though, where it seemed to be doable easily.
Probably the inner data structure types could have been written a bit better and exposed, so the generated .d.ts files could be used for example to create new parsers compatible with Portable Text.
This could incorporate https://github.com/nhi/sanity-block-content-to-react-types
Although, some of these types can be declared in https://github.com/sanity-io/block-content-to-hyperscript and re-exported here.
Note: This is based on https://github.com/sanity-io/block-content-to-hyperscript/pull/23
Using yarn link locally to get it to work. The imports and exports are a bit messy though, and they need some tinkering https://github.com/sanity-io/block-content-to-hyperscript/pull/23#issuecomment-710806629

@balazsorban44 do you plan on merging this anytime soon?

I'm not a maintainer. 😂 I've stopped working on the PR though, so it's best if I close it for now. Please use the code as base if you want to open your own PR


Unit | Component | sl date time: Default property values

not ok 417 PhantomJS 1.9 - Unit | Component | sl date time: Default property values
    ---
        actual: >
            null
        message: >
            Died on test #1     at test (http://localhost:7357/assets/test-support.js:3025)
                at testWrapper (http://localhost:7357/assets/test-support.js:6192)
                at test (http://localhost:7357/assets/test-support.js:6205)
                at http://localhost:7357/assets/tests.js:23150
                at http://localhost:7357/assets/vendor.js:152
                at tryFinally (http://localhost:7357/assets/vendor.js:33)
                at http://localhost:7357/assets/vendor.js:158
                at http://localhost:7357/assets/test-loader.js:60
                at http://localhost:7357/assets/test-loader.js:51
                at http://localhost:7357/assets/test-loader.js:82
                at http://localhost:7357/assets/test-support.js:6024: 'undefined' is not a function (evaluating 'validTimeZonesArray.includes(this.get('timezone'))')
        Log: |
    ...

Will likely be resolved by https://github.com/softlayer/sl-ember-components/issues/1503

Resolved by https://github.com/softlayer/sl-ember-components/issues/1503


Some changes

Includes changes suggested here: https://github.com/apache/skywalking/pull/5914#discussion_r532335397

Codecov Report

:exclamation: No coverage uploaded for pull request base (f-log@c0aa895). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             f-log      #9   +/-   ##
=======================================
  Coverage         ?   0.00%
=======================================
  Files            ?     158
  Lines            ?    3885
  Branches         ?     452
=======================================
  Hits             ?       0
  Misses           ?    3885
  Partials         ?       0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0aa895...0630f53. Read the comment docs.


DOC: signal.correlate: formula doesn't match behavior when x is longer than y

Issue with current documentation:
In the document https://docs.scipy.org/doc/scipy/reference/generated/scipy.signal.correlate.html,

N is the greater length of x and y. However, when x is longer than y, this formula cannot describe the actual output
Idea or request for content:
Please check the definition of N here
Additional context (e.g. screenshots, GIFs)
No response

The formula comes from gh-6971. cc @mivmar @ev-br

I think there is a problem with the formula.
As an example, assume $x=(x_0, x_1)$ and $y = (y_0)$. Then, $\Vert x \Vert=2$, $\Vert y \Vert=1$, $N=2$, and $k$ runs from $0$ to $1$.
We have:
$z[0] = \sum_{l=0}^{1} x_{l} y_{l+1} = 0$ as $y$ is zero outside of its range
and
$z[1] = \sum_{l=0}^{1} x_{l} y_{l} = x_0 y_0$
However
x = np.array([4.0, 3.0])
y = np.array([-1.0])
signal.correlate(y, x)

gives
array([-4., -3.])

By the way, should we explain the notation $y^*$?

do you have a suggestion for a formula which accurately describes the behaviour @fbourgey ?


--strip-css support

I would like to be able to inline all my CSS in one go....

Please don't double-post, but if you do, at least have the decency to cross-link...
https://github.com/Polymer/vulcanize/issues/171


Please add bedrock support with geysermc

Description
Please add bedrock support with geysermc, even if the model is 2d, it's still better than having to look at feathers which feels awful atm
Configuration
My_Feature:
  Feature_Option: <true/false>
  Other_Option: <amount>
  etc.

Payment

[ ] I'm willing to pay for this feature

Converting the texture pack from Java to Bedrock doesn't work. I get some sound effects when reloading but nothing else.

Test.zip
try that


Mouse button remapping &  support for multiple keyboard remapping

Usually a mouse has 2 buttons but now a days many mice comes with more than 2 buttons and sometimes I need to remap those buttons.
Like the wheel button I want it to open the windows menu or the windows search, etc
And the next feature is the remapping of keys for multiple keyboards.Like if I have Two keyboards the the secondary keyboard can be completely remapped .

hi @pratham280, thank you for submitting the issue, for tracking sake please submit one topic per issue. In regards to what you mentioned:

Mouse remapping is being tracked here: #3690
Multiple keyboards (to use your second as a macro keyboard) is great but unfortunately not possible with public APIs see here : #3421, #3676, and #1460

closing this issue as a duplicate


Update claims and supports before expiration

I will fix the ugliness of the duplicated logic required to craft the transaction outputs in an update

Not done with testing yet but I added some commits:
I seperated out the logic that obtains transaction inputs and outputs into a function that update and updatesupport can use.
I added docstrings for the update command
I made sure in updatesupport that the fetched claim is a support
@jack I also think that updateclaimsbeforexpiration should be called "renewclaimsbeforexpiration" (to differentiate the fact that a "renew" is meant to just copy over details of the previous claim without changing it)  and should take an argument for "txid" and "nout" to specify the exact claim for debugging and in case people want to renew certain claims but not others. What do you think?

@kaykurokawa
I agree, it should be renewclaimsbeforeexpiration

@kaykurokawa

should take an argument for "txid" and "nout" to specify the exact claim

I think this should be a renew or renewclaim function, and renewclaimsbeforeexpiration should call it

Renamed to renewclaimsbeforeexpiration
Added a renewclaim command that takes txid and nout as arguments , this uses newly created function _renewclaim which is also used by rewnewclaimsbeforeexpiration
Also saw that rewnewclaimsbeforeexpiration was obtaninig expired claims from wallet.get_name_claims,
expired claims cannot be updated so we should not be trying to renew them.

Added optional skip_validate_schema argument to renew commands

tested manually, and also passed tests in fixed lbry-in-a-box testing, this is good to merge unless jack has additional comments


cant use osmedeus after install it

i get this error after install
python3 ./osmedeus.py -t c.com
Traceback (most recent call last):
File "/home/eyal/opt/Osmedeus/./osmedeus.py", line 13, in
from lib.mode import routine
File "/home/eyal/opt/Osmedeus/lib/mode/routine.py", line 6, in
from lib.mode import general
File "/home/eyal/opt/Osmedeus/lib/mode/general.py", line 6, in
from modules import subdomain
ImportError: cannot import name 'subdomain' from 'modules' (/usr/lib/python3.9/site-packages/modules/init.py)
i cant understand why he isnt import the modules from the directory
do you know what i can do with it?
i use black arch linux
install like this:
cd /home/eyal/opt/
git clone https://github.com/j3ssie/Osmedeus
cd Osmedeus
./install.sh

found a way to fix it
sudo cp modules/* /usr/lib/python3.9/site-packages/modules/


#116 add contentPackageFiles property to support validating a list of content package files

Fixes #116

thanks for merging! - when is the next release planned?

@stefanseifert It will happen soon :)


Merge Notifications Integration into AOS GA

Description
[Describe what this change achieves]
Issues Resolved
[List any issues this PR will resolve]
Check List

[ ] New functionality includes testing.

[x] All tests pass, including unit test, integration test and doctest

[ ] New functionality has been documented.

[ ] New functionality has javadoc added
[ ] New functionality has user manual doc added

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #136 (723b75f) into aos-<IP_ADDRESS>-ga (076e353) will decrease coverage by 9.96%.
The diff coverage is 100.00%.

@@                 Coverage Diff                  @@
##             aos-<IP_ADDRESS>-ga     #136      +/-   ##
====================================================
- Coverage             63.39%   53.42%   -9.97%
  Complexity              309      309
====================================================
  Files                   101       69      -32
  Lines                  4398     2454    -1944
  Branches                669      277     -392
====================================================
- Hits                   2788     1311    -1477
+ Misses                 1442      978     -464
+ Partials                168      165       -3

Flag
Coverage Δ

dashboards-reports
?

reports-scheduler
53.42% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...nsearch/reportsscheduler/model/ReportDefinition.kt
77.60% <100.00%> (ø)

...s-reports/public/components/main/reports_table.tsx

...rts/server/routes/utils/savedSearchReportHelper.ts

dashboards-reports/public/components/main/main.tsx

...r/routes/utils/visual_report/visualReportHelper.ts

...ic/components/main/loading_modal/loading_modal.tsx

...main/__tests__/__utils__/main_utils_test_utils.tsx

...ublic/components/report_definitions/utils/index.ts

...shboards-reports/public/components/utils/utils.tsx

.../report_definitions/report_settings/time_range.tsx

... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 076e353...723b75f. Read the comment docs.

Reporting x Notifications not going into GA, changes are for pentesting. Closing PR.


Fix publishing renamed dependencies to crates.io

This commit fixes publishing crates which contain locally renamed dependencies
to crates.io. Previously this lack of information meant that although we could
resolve the crate graph correctly it wouldn't work well with respect to optional
features and optional dependencies. The fix here is to persist this information
into the registry about the crate being renamed in Cargo.toml, allowing Cargo
to correctly deduce feature names as it does when it has Cargo.toml locally.
A dual side of this commit is to publish this information to crates.io. We'll
want to merge the associated PR (link to come soon) on crates.io first and make
sure that's deployed as well before we stabilize the crate renaming feature.
The index format is updated as well as part of this change. The name key for
dependencies is now unconditionally what was written in Cargo.toml as the
left-hand-side of the dependency specification. In other words this is the raw
crate name, but only for the local crate. A new key, package, is added to
dependencies (and it can be None). This key indicates the crates.io package is
being linked against, an represents the package key in Cargo.toml.
It's important to consider the interaction with older Cargo implementations
which don't support the package key in the index. In these situations older
Cargo binaries will likely fail to resolve entirely as the renamed name is
unlikely to exist on crates.io. For example the futures crate now has an
optional dependency with the name futures01 which depends on an older version
of futures on crates.io. The string futures01 will be listed in the index
under the "name" key, but no futures01 crate exists on crates.io so older
Cargo will generate an error. If the crate does exist on crates.io, then even
weirder error messages will likely result.
Closes #5962

r? @matklad
(rust_highfive has picked a reviewer for you, use r? to override)

r? @ehuss
cc @withoutboats

It's important to consider the interaction with older Cargo implementations
which don't support the package key in the index.

This is a radical thought for how to make sure that older cargos do not see this package, what if we rename the name field to package_name_in_index if explicit_name_in_toml is Some. Now older cargos that expect the name field to be present will just not deserialize it from the index.

@Eh2406 There's a trade off there: on the one hand, always erroring on data you don't understand makes sure you don't have any kind of spurious success; on the other hand, sometimes the program could've succeeded & now won't because it doesn't care about the name field (thinking of extension tools), but it still expects it to be there during deserialization.
I think there's no risk of users downloading the wrong package, because if they get a different package named name, it won't checksum, right? (Unless someone's written a custom tool which doesn't validate the checksums, but I think that's out of scope for us.)

@Eh2406 an interesting though! I think it's certainly possible we could do that, although we've never really focused on this before. Historically all features we've added to Cargo which changed the index just made older Cargos confused.
@withoutboats ah unfortunately checksums are only in place once you've got a lock file, typically this error would be hit when you're forming a lock file. In that sense I don't think the checksums protect us, but I don't think we need to bend over backwards too much here.

@ehuss I think you mentioned on IRC, but does this strategy look ok to you? If so I'll get the crates.io PR merged and then we can merge this

Ah, yea, this seems fine to me. 👍
There is the bigger question of schema compatibility and versioning to provide better error messages.  However, that seems like a much bigger issue similar to the scope of RFC 2495, and I don't see that happening soon, and getting this bug fixed seems pretty important for this feature.

@bors: r=ehuss

:pushpin: Commit e82443dfd8944d243cfeea8d7b49f4690ebf7892 has been approved by ehuss

:hourglass: Testing commit e82443dfd8944d243cfeea8d7b49f4690ebf7892 with merge 6a811f462b071663eba66f75c40968ed743113e1...

:broken_heart: Test failed - status-appveyor

@bors: retry

:hourglass: Testing commit e82443dfd8944d243cfeea8d7b49f4690ebf7892 with merge 74b4f4f2c6b8ebae3cac6b4cca4871f2f5676d33...


Implement full URL scheme

First draft:
URL scheme:

[x] GET /
homepage with list of most recent decks, competitions, and maybe people

[x] GET /decks/
paginated list of all decks

[x] GET /decks/
view of an individual deck

[x] GET /decks/
view of an individual deck

[x] GET /competitions/
paginated list of all competitions

[x] GET /compeititons/
view of an individiual compeition

[x] GET /compeititons/
view of an individiual compeition

[x] GET /people/
pagingated list of all people

[x] GET /people//
view of all decks from a specific person

[x] GET /add/
form to add a deck to the db

[x] POST /add/
add a deck to the db

[x] GET /archetype/
list of archetypes

[x] GET /archetype/
show all aggro/combo/control decks

[x] GET /decktype/
list of all decktypes

[x] GET /decktype/
show all s2 ub control lists, all s2 ooze combo lists, etc.

[ ] GET /search
search for decks by card, user, archetype, etc.

Only thing left to do here is search. Search should be fuzzy and work on mtgo usernames, deck names, archetype names and card names at least.

Did we decide not to do /decktype/?

Everything in earth refers to decktype as archetype. So I'm going to use
that name and complicate from the broad categories we have right now into
more specific archetypes.
On Sat, Jun 17, 2017 at 11:52 PM Katelyn Gigante<EMAIL_ADDRESS>wrote:

Did we decide not to do /decktype/?
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/PennyDreadfulMTG/Penny-Dreadful-Tools/issues/309#issuecomment-309260455,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAAGBQf0IYyDMaJQ0G5l8tmVsVKQ0WT0ks5sFMkwgaJpZM4KhuDo
.

Site search is e36c01. We are done here!


Fix 3 Admin Approval Process Bugs Pt 1

/cib fix 3 admin approval process bugs pt 1

Branch 41-fix-3-admin-approval-process-bugs-pt-1 created!


Use extname setting for template paths in instance methods

I'm not sure if this is possible, but it would save some typing (and possibly refactoring time in the future) if express-handlebars instance methods used the extname setting to figure out the path of the specified template. Right now it seems to be required to pass the full path (relative to the project's root) to the express-handlebars instance methods (for example: getTemplate, render):
hbs.render('views/some/stuff.handlebars`).then(function(renderedTemplate) {
  /* ... */
})

However, by setting extname when creating the instance, I expected that instance to know what kind of extension I'm using for templates, so I could do just this:
hbs = exphbs.create({extname: '.handlebars'})
hbs.render('views/some/stuff`).then(function(renderedTemplate) {
  /* ... */
})

That would just leave the issue of figuring out automatically where the views are located, but that is probably more complicated right?

Since most of the time templates are rendered via Express there's no need to do this since Express' View module will figure out which extension to add if it's missing. If you'd like to add this because you're calling render() on the Express Handlebars instance, feel free to open a PR for it; you could look into how Express does this for the implementation details.

Great! I'll take a look into in when I have some free time. So, just to clarify, it won't break anything if this functionality is included in the Express Handlebars' render method right?

Correct, it should be possible to add this feature without breaking back-compat.

@ricardograca I've done a refactor of this package and plan to release v2.0 soon which adds support for the newly released Handlebars 3.0. If you're still interested in making this change, checkout out #105 and make it against the handlebars-3.0 branch.

Thanks. Will do.


Replace nohup to service restart for parity in Vagrant.

Current coverage is 87.29% (diff: 100%)

Merging #24 into master will not change coverage

@@             master        #24   diff @@
==========================================
  Files            43         43
  Lines          1204       1204
  Methods           0          0
  Messages          0          0
  Branches        158        158
==========================================
  Hits           1051       1051
  Misses          101        101
  Partials         52         52

Powered by Codecov. Last update 5d8cac4...867c1dc


improve IPAM doc integration

'address allocation' is the feature covering both automatic and manual allocation.

LGTM minor comments notwithstanding; merge at will


Remove circular dependencies on build

Remove Circular dependencies on build. Fixes #5968.
(!) Circular dependency: src\geo\crs\CRS.Earth.js -> src\geo\crs\CRS.js -> src\geo\LatLng.js -> src\geo\crs\CRS.Earth.js
(!) Circular dependency: src\geo\LatLng.js -> src\geo\LatLngBounds.js -> src\geo\LatLng.js
(!) Circular dependency: src\core\Browser.js -> src\layer\vector\SVG.Util.js -> src\core\Browser.js
(!) Circular dependency: src\dom\DomEvent.js -> src\dom\DomEvent.Pointer.js -> src\dom\DomEvent.js
(!) Circular dependency: src\dom\DomEvent.js -> src\dom\DomUtil.js -> src\dom\DomEvent.js

API compatibility should be maintained, I've tried to keep the exports in the same modules to avoid changing.
Challenges
I could not easily separate LatLng and LatLngBounds, they seem tightly coupled, so they were merged.
If anyone has any peer advice on a better solution, I'm more than happy to amend the code.
Note
This came about as I was doing some work on Rollup and Terser, and when running the Karma build it would spiral into an endless loop, related to the above circular dependencies.

Hi, I'm sorry but I'd like to get clear if this progress could go ahead? It seems the circular dependencies will invalidate the tree-shaking to some extent.

@jafin Would you like to resolve the merge conflicts please?

@Malvoz,  merge conflicts resolved.
Note:  LatLng and LatLngBounds are merged again.  I don't know of a clean option to keep them separated without keeping the circular dependency.  As noted from @IvanSanchez he raised a comment about these being merged.  I had originally responded with an approach to extend from Class.  But the testsuite had errors for this change, so it has been reverted.
If someone can provide guidance on a better way to maintain LatLng and LatLngBounds separately and still avoid the circular dependency I'm happy to attempt to fix
Removing toBounds from LatLng would solve it, but its a breaking change.


[Suggestion] Confirmation for purchase of townclaim

It is possible to set a cost for creating a town claim, and it works very well. But what I miss is a way to be able to activate confirmation. There are several players who make a town claim by accident, and notice that they lack money.
Is it possible to add an option so that we can activate confirmation before the town claim is created? If the player writes for example /townaccept, or possibly click on a text in the chat to confirm.

An example that could be used in the configuration file
town {
    auto-nature-restore=false
    cleanup-task-interval=5
    creation-cost=80000.0
    confirmation=true
}

Sounds reasonable to just get this added by default. I'll make sure to do it for next release.

So I just got around to looking at this again and this is already supported for economy mode servers. If you are not using economy mode then that is your issue. However, if you are planning on converting to economy mode then make sure you clone your production server to test and use /gdblocktransfer to transfer ALL player accrued/bonus claimblocks into currency for economy mode use.


[TBD] Playground Samples - screenshots slideshow

Slideshow the screenshots provided for each sample

AC:

Screenshots should change automatically without being able to change them manually
All slideshows should change simultaneously on the same interval
Transition effect TBD
Interval value TBD

Deprecated. We will use only the first item of the array.


 Also added in a sanity check for dependencies (because I keep running this without being in the fastqc env).
Also added PhiX analysis cli arg, so far we don't run PhiX every time but I am assuming this will be changed in the near future to run by default.
let me know if you spot anything that doesn't belong and check the changelog for more yapping
TODO: docstrings!

@ksaulog oh that's a remnant of another approach I did. Initially it went through, checked them all, and then returned a dict of version info and stuff for parsing.
Maybe in this implementation, it effectively doesn't return anything useful. Should raise RuntimeError if anything is amiss tho

@Ryn29 @ksaulog @PaddyKTaylor
If anyone wants Python practice, we've got some docs to write lmao


[Bug]Restore-DbaDatabase sometimes generates duplicate RESTORE TRN entries

Environmental information
#### PowerShell version:
Name                           Value
----                           -----
PSVersion                      5.1.17763.771
PSEdition                      Desktop
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
BuildVersion                   10.0.17763.771
CLRVersion                     4.0.30319.42000
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>

#### dbatools Module version:
Name    : dbatools
Path    : C:\Program Files\WindowsPowerShell\Modules\dbatools\1.0.92\dbatools.psd1
Version : 1.0.92

Name    : dbatools
Path    : C:\Program Files\WindowsPowerShell\Modules\dbatools\1.0.73\dbatools.psd1
Version : 1.0.73

LCID             Name             DisplayName
----             ----             -----------
4108             fr-CH            French (Switzerland)

SQL Server:

Microsoft SQL Server 2017 (RTM-CU14) (KB4484710) - 14.0.3076.1 (X64)   Mar 12 2019 19:29:19   Copyright (C) 2017 Microsoft Corporation  Enterprise Edition: Core-based Licensing (64-bit) on Windows Server 2016 Datacenter 10.0 <X64> (Build 14393: ) (Hypervisor)

us_english

Report
For some databases (not all) I tried to restore, the Restore-DbaDatabase with RestoreTime option generates duplicate entries leading to message:  backup cannot be restored because no files are ready to rollforward
Using the -OutputScriptOnly parameter confirms the 2 last entries NORECOVERY + RECOVERY are on the same TRN backup files.

Host used

[X] powershell.exe
[X] ISE
[X] VS Code
[ ] Other (please specify)

If anything other than powershell.exe was used, please confirm that you can duplicate the issue with powershell.exe

[X] Still buggy in powershell.exe

Errors Received
backup cannot be restored because no files are ready to rollforward
Steps to Reproduce
$RestoreTime = Get-Date('03:00 26/02/2020')

Restore-DbaDatabase `
                -SqlInstance ag-xxx-xxx `
                -DatabaseName xxxx `
                -Path '\\fileshare\SQLBackupProd\AAG_AG-XXXX\XXXX' `
                -DestinationFilePrefix 'restore' `
                -UseDestinationDefaultDirectories `
                -WithReplace `
                -RestoreTime $RestoreTime `
                -SqlCredential $credential -OutputScriptOnly

RESTORE LOG [xxxx] FROM  DISK = N'\\fileshare\SQLBackupProd\AAG_AG-XXX\xxxx\xxxx_20200226024501.TRN' WITH  FILE = 1,  MOVE N'xxxx' TO N'D:\XXXX\Data\restorexxxx.mdf',  MOVE N'xxxx_log' TO N'L:\XXXX\Logs\restorexxxx_log.ldf',  NORECOVERY,  NOUNLOAD,  STATS = 10,  STOPAT = N'02/26/2020 03:00:00'
RESTORE LOG [xxxx] FROM  DISK = N'\\fileshare\SQLBackupProd\AAG_AG-XXX\xxxx\xxxx_20200226030000.TRN' WITH  FILE = 1,  MOVE N'xxxx' TO N'D:\XXXX\Data\restorexxxx.mdf',  MOVE N'xxxx_log' TO N'L:\XXXX\Logs\restorexxxx_log.ldf',  NOUNLOAD,  STATS = 10,  STOPAT = N'02/26/2020 03:00:00'
RESTORE LOG [xxxx] FROM  DISK = N'\\fileshare\SQLBackupProd\AAG_AG-XXX\xxxx\xxxx_20200226030000.TRN' WITH  FILE = 1,  MOVE N'xxxx' TO N'D:\XXXX\Data\restorexxxx.mdf',  MOVE N'xxxx_log' TO N'L:\XXXX\Logs\restorexxxx_log.ldf',  NOUNLOAD,  STATS = 10,  STOPAT = N'02/26/2020 03:00:00'

Expected Behavior
To avoid 2 last duplicate entries and warning message
Actual Behavior
Duplicate entries generated leading to the aforementioned warming message

I think the problem is in Select-DbaBackupInformation. This function returns the last trn file twice when RestoreTime == BackupStartTime == BackupEndTime. I have this phenomenon on very small transaction log backups on a very fast system.
https://github.com/sqlcollaborative/dbatools/blob/96a76674d2e9fca8863eecdbe79c50af8f49a09d/functions/Select-DbaBackupInformation.ps1#L221
$FilteredLogs = $DatabaseHistory | Where-Object { $_.Type -in ('Log', 'Transaction Log') -and $_.Start -le $RestoreTime -and $_.LastLSN -ge $LogBaseLsn -and $_.FirstLSN -ne $_.LastLSN } | Sort-Object -Property LastLsn, FirstLsn
Should be
$FilteredLogs = $DatabaseHistory | Where-Object { $_.Type -in ('Log', 'Transaction Log') -and $_.Start -lt $RestoreTime -and $_.LastLSN -ge $LogBaseLsn -and $_.FirstLSN -ne $_.LastLSN } | Sort-Object -Property LastLsn, FirstLsn
(-le replaced by -lt)
A few lines later, the following code uses -ge to determine the Last Log Backup
# Get Last T-log
$lastLog = $DatabaseHistory | Where-Object { $_.Type -in ('Log', 'Transaction Log') -and $_.End -ge $RestoreTime -and $_.DatabaseBackupLSN -eq $Full.CheckpointLSN } | Sort-Object -Property LastLsn, FirstLsn | Select-Object -First 1

So when the backup start time is equal to the backup end time and the RestoreTime is equal to both, this bug happens.  When changing the code as said above, the problem is not present.  I will try to submit a pull request in the coming days.


Cdp 633

I am not sure I've interpreted the changes correctly, but do we fail silently when xattrs are not set?

yes, we are report an error to the error log and return attributes from the inode


enable dependabot for GitHub actions

This allows to get updates for GitHub actions automatically. I have used this for my own packages, the Trixi.jl framework, and the SciML organization. After merging this, you could also enable other Dependabot actions in 'Settings -> Code security and analysis -> Dependabot alerts' and '... -> Dependabot security updates'.
See https://github.com/SciML/MuladdMacro.jl/pull/37

Codecov Report
Patch coverage has no change and project coverage change: -0.16 :warning:

Comparison is base (85de506) 80.39% compared to head (3aa8ad5) 80.24%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #117      +/-   ##
==========================================
- Coverage   80.39%   80.24%   -0.16%
==========================================
  Files           4        4
  Lines         663      663
==========================================
- Hits          533      532       -1
- Misses        130      131       +1

see 1 file with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Generic derivation fails for sealed hierarchy living in a file with a lower-case name

This is happening with circe 0.5.4 and scala 2.11.8.
I've created a simple repo to reproduce this: https://github.com/backuitist/circe-test

Okay, that's really weird. Here's a minimization that's not circe-specific:
// build.sbt
scalaVersion := "2.12.0"
libraryDependencies += "com.chuusai" %% "shapeless" % "2.3.2"

// project/build.properties
sbt.version = 0.13.13

// foo.scala
sealed trait Foo
case object Bar extends Foo

// Test.scala
object Test { shapeless.Generic[Foo] }

This won't compile, but if you rename foo.scala to Foo.scala and sbt clean compile it works just fine.
To make things even more horrifying, you can also leave foo.scala as it is and rename Test.scala to test.scala and it'll work.
Same thing happens on 2.10.6 and 2.11.8.
Unfortunately I don't really know what to say besides "don't do that", @backuitist.

Looks like a bug in the incremental compiler..
$ scalac -cp ~/.ivy2/cache/com.chuusai/shapeless_2.12/bundles/shapeless_2.12-2.3.2.jar foo.scala Test.scala

$ scalac -version
Scala compiler version 2.12.0 -- Copyright 2002-2016, LAMP/EPFL and Lightbend, Inc.

Mac or Linux?

@djspiewak Not sure about @backuitist, but I'm on a Mac at the moment. Trying on Linux now…

I'm on a Mac

I'm on Mac, with a case-insensitive FS:
16:16:05 $ touch foo.scala

16:16:08 $ touch Foo.scala

16:16:09 $ l
.
└── [   0]  foo.scala

0 directories, 1 file

Same thing on Linux.

It's SI-7046. scalac sorts source files by (path) name. So filename can affect type checking order.

Do you think https://github.com/scala/scala/pull/5284 will fix that?

Ah...
$ scalac -cp ~/.ivy2/cache/com.chuusai/shapeless_2.12/bundles/shapeless_2.12-2.3.2.jar \
  Test.scala foo.scala
Test.scala:1: error: could not find implicit value for parameter gen: shapeless.Generic[Foo]
object Test { shapeless.Generic[Foo] }
                               ^
one error found

@backuitist I just confirmed that this works with TLS, so yes, it should.

This is out-of-scope for circe, but we've now got docs about workarounds via #644.


Memo field shows extra characters in Browsers Chrome V81 & Edge V81

Describe the bug
This issue is only on a windows machine, If you go to the transaction details page and look in the memo field you will see  extra characters where there should be empty space. This only happens on a windows machine and not in a Mac for Browsers Chrome V81 & Edge V81 Microsoft 10 OS
Link to transaction: https://explorer-git-feat-contract-call-debug.blockstackpbc1.now.sh/txid/0x8982abdd11df77152de15c50b9f52689eb2546cdf66bd4311f26b64389756830
Transaction ID 0x8982abdd11df77152de15c50b9f52689eb2546cdf66bd4311f26b64389756830
Address STB44HYPYAT2BB2QE513NSP81HTMYWBJP02HPGK6
Block#  21527
Time stamp 3 days ago
To Reproduce
Steps to reproduce the behavior:

Go to on a windows 10 PC open Chrome 81 and also Edge 81
Click on the link I listed above
Scroll down to the memo page
See the error below

Expected behavior
The memo field on the transaction details page should appear on a windows machine the same way as it appears below in the image from the mac machine.
Screenshots
If applicable, add screenshots or consol.log to help explain your problem.

Desktop (please complete the following information):

OS: Windows 10
Browser Chrome 81 & Edge 81

closing in favor of https://github.com/blockstack/explorer/issues/123


Better way to handle Security using PEM & Key

https://github.com/pions/webrtc/blob/master/examples/sfu-ws/web.go#L16
This generating the PEM and Key.
However the example uses the browser and so we need a way to inject the the PEM into your browser.
https://support.securly.com/hc/en-us/articles/206081828-How-to-manually-install-the-Securly-SSL-certificate-in-Chrome
Also it generates the new PEM on every run, and so you have to reinject it into the browser.
How about this ?
We need a common way for all he examples.

Have a cmd to gen the PEM and Key
Have a cert to inject it into the key store
Then the examples can use that PEM and KEY.

this might help:
https://github.com/FiloSottile/mkcert

I removed certificates from sfu-ws
Users should fork+modify if they need this.


Do not use secret credentials for forked repos on GitGub Actions

Actually I tried to create a new env variable and set it conditionally, but with no result, so decided to make another run with applicable arguments for now.


Status messages

This will add status messages inside the chat output so the user knows when they connect and disconnect. Also adds a setting to turn on join messages which will output a message to the chat when someone joins the channel ( setting defaults to false to not show them ).
All of these status messages are colored in the output. I matched the connect/disconnect with the status IRC in the atom window. And join messages are blue, this way they wont be the same color as PM's which are green.
Here are the colors of the messages:
Connected: Green ( @text-color-success )
Disconnected: Red ( @text-color-error )
Joined: Blue ( @text-color-info )

@aaronholla I had some time to review this and there is a couple of things that should be added/fixed before this is merged:

You've added a configuration on whether or not to display joined messages, however that configuration is never used.
Can you also add a message for QUIT events? Seeing when a user quits is almost as important as seeing when they join.

Thanks for the contribution.

@cjsaylor Great feedback! I will try to add the changes as soon as I can.

Okay I added Quit Messages as well, also both join and quit messages now use the showJoinMessages config setting.

Okay good point on that, it also makes this a lot easier to read. I also removed the debug messages now that join and quit both will show in the output. It also just didn't seem needed to log them as irc logs error messages and quits already. Plus the debug messages would only show if the show join messages is enabled.

:+1:


Can the Redux docs mention something about code re-use?

@gaearon
Usually, the Redux sample code is to wire something up using connect() and that's the end of the sample.  Can it state something about code re-use?  That is, component re-use: if the component is used with one Redux state and the component is re-used for another state in the Redux store?
Example:
Let's say, we already have  a Count component (counter):

what if we need two such components on the same page, one for countIceCream and one for countDrink?
if on the To Go Order page, we need such component but it is for countSpoon?

There are two questions, one related to not using React Hooks, and one if using React Hooks:
https://stackoverflow.com/questions/60689844/how-to-re-use-a-component-in-react-and-redux
https://stackoverflow.com/questions/60690050/how-to-we-achieve-code-reuse-if-we-use-react-redux-hooks
If possible, can Dan Abramov @gaearon  give us a definitive answer?

First, Dan doesn't really participate in these projects anymore.
This falls outside the scope of our docs. We're not going to teach you how to implement reusable hooks, or general coding patterns. You should search elsewhere for that.

First, Dan doesn't really participate in these projects anymore.
This falls outside the scope of our docs. We're not going to teach you how to implement reusable hooks, or general coding patterns. You should search elsewhere for that.

Code re-use is such an important topic. If the docs can have just a short article about it, millions of developers can benefit from it.

I'm with Tim.  There's nothing specific to the concept of code reuse that we need to document.

I'm with Tim. There's nothing specific to the concept of code reuse that we need to document.

I think it may be more particular with using Hooks. If the component uses a Redux state, and then spit out 80 lines of JSX.  Now the component needs to be used with a different Redux state, and need to render the same 80 lines of JSX, how could we structure our code, if we don't want to repeat that 80 lines of JSX?

The question is too vague.  It's your app, you're welcome to structure and reuse things however you want.


MenuFragment cannot find view with appcompat-v7:23.1.0 or higher

view.findViewById in MenuFragment doesn't work with appcompat-v7:23.1.0 +, design:23.1.0+, and so on.
//I should use navigationView.getHeaderView(0) to get view from header.so, it's not your issue.
delete it please :dancers:

I don't find something wrong with appcompat-v7:23.1.0 or higher in my demo .

Same that @quanlt with appcompat-v7:23.1.+ i used on MyMenuFragment:
View view = inflater.inflate(R.layout.fragment_menu, container, false);
NavigationView navigationView = (NavigationView) view.findViewById(R.id.vNavigation);
ivMenuUserProfilePhoto = (ImageView) navigationView.getHeaderView(0).findViewById(R.id.ivMenuUserProfilePhoto);

regards.


Fixed back-to-list for crm bundle

To be able to overwrite the back to list logic, there have to be a function for the back event!
Tasks:

[ ] gather feedback for my changes
[ ] submit changes to the documentation

Informations:

Q
A

Tests pass?
yes

Fixed tickets
none

BC Breaks
none

Doc
none

@danrot i have to fix the name in extension bundle: https://github.com/sulu-io/SuluContactExtensionBundle/pull/15


RequestBody.string()

Hi, would be possible to have a method RequestBody.string() like in the ResponseBody.string() ?
It would help with the logging of the request being sent.

You can write your own method to do that like this:
  public static String requestBodyToString(RequestBody requestBody) throws IOException {
    Buffer buffer = new Buffer();
    requestBody.writeTo(buffer);
    return buffer.readUtf8();
  }

I'm reluctant to include it as it may cause substantial performance problems for some request bodies.

We’re going to get this for free in OkHttp 4 when we unify the request and response body types.

unable to find string method in RequestBody class.
Using below version of okhttp
implementation 'com.squareup.okhttp3:okhttp:3.10.0'

@jinal90 it doesn't exist in OkHttp 3, use the sample code that Jesse provided above for now.

I tried with the sample code provided by Jesse. Its not working, I am getting null buffer object.
//This is the RequestBody object
RequestBody mRequestBody = new MultipartBody.Builder()
.setType(MultipartBody.FORM)
.addFormDataPart("name", "content")
.addFormDataPart("filename", "sample.pdf",
RequestBody.create(MediaType.parse("/"), new File(filePath)))
.build();
//This is the requestBodyToString method
//here I get buffer object as null
public String requestBodyToString(RequestBody requestBody) {
try{
Buffer buffer = new Buffer();
requestBody.writeTo(buffer);
return buffer.readUtf8();
}catch(Exception e){
e.printStackTrace();
return "";
}
}

You should ask usage questions like this on stackoverflow.  If you can reproduce a bug then raise an issue here.  But comments on existing closed issues are a very noisy place to debug through usage problems like this.

You can write your own method to do that like this:
  public static String requestBodyToString(RequestBody requestBody) throws IOException {
    Buffer buffer = new Buffer();
    requestBody.writeTo(buffer);
    return buffer.readUtf8();
  }

I'm reluctant to include it as it may cause substantial performance problems for some request bodies.

Buffer class is an Abstract class in Java.nio Package

Buffer is also a concrete class in the okio package.

Buffer is an abstract class in plain Java. To make this work you need to install Okio library in your grade file
build.gradle
implementation group: 'com.squareup.okio', name: 'okio', version: '3.1.+'
Ref: https://github.com/square/okio


Upgrade as_constant and as_variable

They now return std::optional<T> instead of const T*. This turns out to matter in subtle cases like
      int foo = *as_constant(simplify(thing()));

where the return value of simplify is a temporary that's discarded immediately, but that as_constant() assumes will remain valid. Using std::optional captures the value in a way that should be safer against this pattern, as well as more easily debuggable (since dereferencing an empty std::optional is caught by clang-tidy in many cases and is also checked for by debug builds of libc++).

I see now, it's your other PR


Crash when moving item into library that has infusion enchantment

A client crash occurs when a player moves an item into a library that contains the infusion enchantment.
https://crashy.net/oQzYex0BzIxWgYhZUoe4?raw

We had it on a book somehow, not entirely sure how we got it to began with.

Fixed in 5.4.0


[web]: Mouse wheel (or trackpad) scroll is reversed when ListView is reverse

When scrolling with the mouse wheel (or trackpad) on a ListView configured with reverse: true, scrolling down goes up and vice versa.
Maybe this is the intended behaviour from a dev perspective, but it is a surprising behaviour for the end-user. In my case, I reverse the ListView because it seems to be the only way to stick scrolling to the bottom edge while adding animated items to it. In that case, reversing is not meant to change the way the user interacts with this widget.
It would help if the wheel handling logic was decorrelated from the logic of the viewport offset & display. The current properties and interfaces make it difficult (impossible?) to counter this mouse wheel scroll reversal.
flutter_web version: commit 1ed4317 (June 22)
Mac OS X 10.14.5 18F132, locale en-KR

Totally agree with you. It's a weird behaviour for the end-user.


Add the ability to fetch groups from multiple endpoints

These commits adds the ability to fetch groups from multiple endpoints. The endpoints are passed as a comma-separated list of URLs.

merged from internal repo.


Find symbol stops highlighting updates

In vscode.d.ts find symbol "register", notice that the highlighting in the list stops as "reg" because that's when the items in the list no longer move around.  I expect the entire word to be bold as it's matching:

Pressing T will update all items except the focused one.

Not sure what you are doing but for me this works - when typing or pasting that work.

@jrieken happens on my home computer as well, both machines are Windows 10. It works fine on my macbook

I could not reproduce on windows... I suspect that this is a rendering issue, not a matching issue. Either some dom-reuse issue with the tree or some debounce issue. The next this happens can you then inspect the element and see if highlight spans are there?

Pressing T will update all items except the focused one.

What happens when you delete the T again?

It's working now, weird. I suspect it was related to when the list viewport not updating when only items outside the viewport changed removed. Will keep an eye out if it happens again

Will keep an eye out if it happens again

Yes please! We have seen something similar with completion items and also suspected a painting/redraw issue and also didn't understand what was going all. Both use the highlight label...


add requestId via cls-rTracer to outbound request(s) headers

Ticket

non-public

Goal / Context

as part of improving our developer(s) experience(s), we're increasing the traceability of requests made through our nodesJS services. This change will help us to trace requests from A to Z across our systems.

Extra

replace deprecated method resolve by url constructor

@Duffleman : do you think overall this is the right approach? I feel like I'm taking a shortcut

@Duffleman : do you think overall this is the right approach? I feel like I'm taking a shortcut

Everything in JS feels like a shortcut compared to Go haha. I'm not super familiar with the rtrace library, so will do some looking about, but this does feel like the right approach from what I can tell at this stage

One note about JS. This library is very old, and the objectAssign function this pulls from a third party lib is now part of the standard lib.
I wouldn't think it would be a wise idea to update that in this PR, but for your own JS knowledge, you can remove the const objectAssign = require('es6-object-assign').assign; line at the top and instead use Object.assign(), or even the syntax sugar equivalent which is { ...{} }.
For example:
const reqID = rTracer.id() ?? null;

if (reqID != null) {
	headers = { ...headers, 'request-id': reqID };
}

Or since it's only 1 key
const reqID = rTracer.id() ?? null;

if (reqID != null) {
	headers['request-id'] = reqID
}

Thanks again for all the comments @Duffleman , I'll try to address them in upcoming PRs


Detecting file change on client vs server

The checksum feature seems to verify integrity of newly uploaded body, but I'm not seeing verification of the combined file as a whole.
The problem:

Client uploads a file partially
User modifies the file
Client tries to resume upload from the same file on disk

A naive implementation would end up with first half of first version of the file and second half of the second version of the file combined on the server, which is likely to end up being garbage.
I see two ways of improving this:

The server could give the client metadata about the server's version of the file to compare against the local one. At very least it could be the expected total file size (sent by the client previously), so edits that change file size are detected. Or send a checksum of the part of the file already on the server, so the client can compare it against local file.

The client could always send checksum of the full file it sends (not the body of the request, which may be partial), so that the server can immediately reject resumption of a wrong file.

The checksum feature seems to verify integrity of newly uploaded body

That's correct, the checksums are meant to detect transmission error for a single PATCH request.

The problem:
1. Client uploads a file partially
2. User modifies the file
3. Client tries to resume upload from the same file on disk

This situation should be caught by the client without needing involvement from the server. The client is able to determine file modifications to a certain degree. For example, tus-js-client (and tus-java-client and tus-android-client) currently check if the file size or the file modification date has changed between uploads. If that's the case, it will not resume a previous upload to ensure that no file chunks are mixed up. It's similar to the first solution you proposed but the server does not need to be involved in that; the client should be able to maintain that state on its own.
A better improvement would be to compute the full checksum for a file on the client side and then let the client verify the checksum whenever it resumes the upload. This would catch all file modifications but it's not easily doable in a fast way in browsers and on mobile devices, so the costs are a bit too high for normal use-cases. Personally, I have never experienced that in-upload-modifications are a real problem.

That's why I wrote a "naive implementation". Client-side prevention requires storing state on the client. With help of the server the clients could be stateless (i.e. always try to resume everything, and succeed whenever possible), and the server by necessity is already stateful, so it seems to be the better place to store state.

Clients are usually not stateless if you want to resume an upload. In that case you have to transfer some knowledge between your uploading session about the upload you want to resume. This is normally kept to the minimum of an upload URL pointing to your resource on the server and is needed so that the client knows where you want to resume the upload to. I agree that one should always be careful when adding more state to a component but clients usually do already have to deal with that.

Bummer. I hoped I could use it to have stateless clients and threat resumption as an optimization for retries of idempotent operations.

I can understand that hope but I think it's not related to tus clients but is a general problem. If you want to resume a previous action you need some information about the previous state. Even if that information is just a URL to a remote server where you can get more details, as in tus' situation.
However, regarding:

The client could always send checksum of the full file it sends (not the body of the request, which may be partial), so that the server can immediately reject resumption of a wrong file.

You can currently do following which is a bit similar: When the client creates an upload, it calculates the checksum of the entire file and sends it as metadata to the server. The server will never validate this checksum but when the client wants to resume the upload, the client can send a HEAD request to get the stored checksum from metadata. After that the client can verify that checksum and see if it wants to resume or start a new upload.

Closing this issue due to inactivity. Feel free to leave a comment if you want to continue the discussion :)


Error on "vue create" with babel, typescript and eslint/prettier

Version
3.0.0-rc.8
Node and OS info
Node v10.6.0, NPM 6.1.0, Windows 10
Steps to reproduce
Run "vue create" with options (manual)
Babel
TypeScript
Linter/Formatter
Use class-style component syntax? Y
Use Babel alongside TypeScript for auto-detected polyfills? Y
ESLint   Prettier
Lint on save
In dedicated config files
What is expected?
Vue create succeeds without error
What is actually happening?
Creation results in the following errors:-
🚀  Invoking generators...
📦  Installing additional dependencies...
added 15 packages from 13 contributors and audited 14055 packages in 20.376s
found 0 vulnerabilities

Running completion hooks...error: 'Component' is defined but never used (no-unused-vars) at test6-vue-cli-rc8\src\App.vue:9:10:
7 |
8 |
42 |

error: 'JSX' is not defined (no-undef) at test6-vue-cli-rc8\src\shims-tsx.d.ts:4:13:
2 |
3 | declare global {

4 |   namespace JSX {
|             ^
5 |     // tslint:disable no-empty-interface
6 |     interface Element extends VNode {}
7 |     // tslint:disable no-empty-interface

error: 'ElementClass' is not defined (no-undef) at test6-vue-cli-rc8\src\shims-tsx.d.ts:8:15:
6 |     interface Element extends VNode {}
7 |     // tslint:disable no-empty-interface

8 |     interface ElementClass extends Vue {}
|               ^
9 |     interface IntrinsicElements {
10 |       [elem: string]: any;
11 |     }

error: 'IntrinsicElements' is not defined (no-undef) at test6-vue-cli-rc8\src\shims-tsx.d.ts:9:15:
7 |     // tslint:disable no-empty-interface
8 |     interface ElementClass extends Vue {}

9 |     interface IntrinsicElements {
|               ^
10 |       [elem: string]: any;
11 |     }
12 |   }

error: 'elem' is not defined (no-undef) at test6-vue-cli-rc8\src\shims-tsx.d.ts:10:8:
8 |     interface ElementClass extends Vue {}
9 |     interface IntrinsicElements {

10 |       [elem: string]: any;
|        ^
11 |     }
12 |   }
13 | }

8 errors found.

(command prompt)

Steps to reproduce should read ...
Run "vue create" with options (manual)
(instead of Run "vue cli" ... )

FYI, it is because in the generated .eslintrc.js, @vue/prettier comes after @vue/typescript, so those rules turned off by @vue/typescript are overridden.
https://github.com/vuejs/vue-cli/blob/ee85f7c2d6f90d8c48159a434aa189760cb467b7/packages/%40vue/eslint-config-typescript/index.js#L10-L22

Following on from @sodatea, as a workaround, the errors are fixed by changing the order of the rules in the generated .eslintrc.js file.
For example the following order, does not result in errors ...
// .eslint.js module.exports = {   'extends': [     'plugin:vue/essential',     '@vue/prettier',     '@vue/typescript',   ], ...


Clear all bounding tiles

It would be nice if the "Clear" button had an "all" option. Personally, I'd want that to be default but I could see the argument for not doing that too.

@benbarbour Added in 0.0.4.
You can now select the "All" button when clearing bouding tiles.
"All" is also the default option, so you can just press the "Enter" key.


How te enable / implement Google font?

We are implementing the style guide with Gulp. We aren't able to added the @import Google font. How should we do that?

Don't know if it's the official way, but I worked around it by importing the styles using the extraHead flag
--extraHead "<style>@import url('https://fonts.googleapis.com/css?family=Open+Sans&subset=latin');</style>"

I tried to do the same way, but it load after the original stylesheet. It doesn't work for me. I didn't find any information about Google Fonts. The documentation describe static fonts and that works fine for me. For now I am searching the best way to enable Google Fonts (if these is possible).

The load order doesn't really matter, the fonts would be rendered once they're loaded. Make sure you're using the right font-family: "Typeface Name"; for the actual typeface you're loading and check the network tab in your browser's dev-tools to see if the fonts ever get loaded. Might be connectivity issues (or plugins blocking the fonts).

@jeroenb2511 Could you share how exactly you are trying to link the font? Are you doing this in the CSS (SASS, LESS) code processed by SC5-StyleGuide?

Try to use
beforeBody build option with link to google font


GloSC not work...

It's the first time I've tried GloSC, since I wanted to play Forza.
Unfortunately, as soon as I click "Add all to Steam", I get this error:

Could not detect Steam shortcuts file!
Make sure you have at least one non-Steam shortcut for the file to be present
Steam must be running for it to be detect

The problem that Steam effitivamente is open (even as an administrator) ...
I do not know how to solve, can you help me?

It tells you.
Add any Game or Program as non-Steam game first.
Then GloSC will create Steams "non-Steam game" shortcuts file.


Add subprocess exit error handling on discovery

Add error processing so when the discovery subprocess dies there is still a payload crafted and sends that gives information on the failure. See similar subprocess exit handling for execution.

The following is code that should error and display something to the user that is easily findable / understandable:
# Copyright (c) Microsoft Corporation. All rights reserved.
# Licensed under the MIT License.

import unittest
import ctypes

ctypes.string_at(0)  # Dereference a NULL pointer

class TestSegmentationFault(unittest.TestCase):
    def test_segfault(self):
        assert True

if __name__ == "__main__":
    unittest.main()


Minimize repeated feature generation in gcn_cronjob.py

As new GCN events appear on Fritz, gcn_cronjob.py will run feature generation even on sources that already have SCoPe classifications. We're always using ZTF DR16 to generate these features, so the underlying data are not changing from day to day. There is currently no check on which sources have been classified already. Perhaps maintaining a rolling list of such sources (and cross-referencing when new GCN events arise) could help reduce duplicate feature generation on the same sources. To avoid a continuously growing list, we should purge sources from the file once they fall out of a certain date range.

Addressed by #446.


HowTo authenticate a user that is in a UserPool using AWS C++ SDK.

I am trying to authenticate a user that is in a UserPool using the AWS C++ SDK.  I have written a small program to try to do this.  There are no examples on the AWS web site that are C++ based.  I tried looking at this JavaScript sample, http://docs.aws.amazon.com/cognito/latest/developerguide/using-amazon-cognito-user-identity-pools-javascript-examples.html in the Authenticate a User section, and translate to C++ hoping that there would be a 1-to-1 correspondence between the two languages.
Here is the code that I wrote:
#include <aws\cognito-identity\model\GetOpenIdTokenForDeveloperIdentityRequest.h>
#include <aws\cognito-identity\CognitoIdentityClient.h>
#include <aws\cognito-identity\CognitoIdentityRequest.h>
#include <aws\core\Aws.h>
#include <aws\core\auth\AWSCredentialsProvider.h>
#include
using namespace Aws::CognitoIdentity;
using namespace Aws::CognitoIdentity::Model;
using namespace Aws::Auth;
void main()
{
Aws::SDKOptions options;
Aws::InitAPI(options);
CognitoIdentityClient* identityClient = new CognitoIdentityClient(AWSCredentials("my access key -

not included for privacy reasons","my secret access key - not included for privacy reasons"));
AdminGetUserRequest objRequest;

objRequest.SetIdentityPoolId("my pool id - not included for privacy reasons");

objRequest.SetUsername("my id - not included for privacy reasons");

auto objUserInfo = identityClient->AdminGetUser(objRequest);

Aws::ShutdownAPI(options);
}
The objUserInfo has a success field.  It seems to be being set correctly whether the user is in the UserPool or not.  But, I don't use the users password.  I was wondering how I include the password for authentication?  Do I need to use a different request type?

AdminGetUser is not for authentication, and there is no place for a password in this call. It runs on top of the developer credentials.
http://docs.aws.amazon.com/cognito-user-identity-pools/latest/APIReference/API_AdminGetUser.html
Your next step is to call AdminitInitiateAuth or InitiateAuth
http://docs.aws.amazon.com/cognito-user-identity-pools/latest/APIReference/API_AdminInitiateAuth.html

You want to use an SDK library extension that handles SRP (Server Remote Password) authentication. Here's a library I've had some success with: https://github.com/drozhkov/aws-cpp-cognito-auth

I'm marking this issue for closing as it seems to have been resolved, if there's any other doubts please comment, and we'll bring it back.


Says that there is no module called requests

i did install pipenv flask and requests like they said the the correct versions but I get this error:
Traceback (most recent call last):
  File "blockchain.py", line 7, in <module>
    import requests
ModuleNotFoundError: No module named 'requests'

I also tried the newest versions of the modules but nothing is working. i reinstalled python and pip but also did not work. any way I can fix this.

you need to do pipenv install


子路径问题，麻烦研究一下，路径缺失

https://aistudio.baidu.com/projectdetail/8064463
启用你的插件

https://aistudio.baidu.com/projectdetail/8064463 启用你的插件

I looked at the code where my nodes are installed. If you mean that my repository is not cloned on startup. Line:
asyncio.run(asyncio.gather(*(asyncio.get_running_loop().run_in_executor(None, git_clone, comfyui_custom_nodes, os.path.join(comfyui_path, "custom_nodes")) for comfyui_custom_nodes in [
    'https://github.com/ltdrdata/ComfyUI-Manager.git',
    # 'https://github.com/11cafe/comfyui-workspace-manager',
    # 'https://github.com/AlekPet/ComfyUI_Custom_Nodes_AlekPet',
    # 'https://github.com/crystian/ComfyUI-Crystools',
    # 'https://github.com/pythongosssss/ComfyUI-Custom-Scripts',
    # 'https://github.com/ssitu/ComfyUI_UltimateSDUpscale',
    # 'https://github.com/Fannovel16/comfyui_controlnet_aux',
    # 'https://github.com/jags111/efficiency-nodes-comfyui',
    # 'https://github.com/Kosinkadink/ComfyUI-AnimateDiff-Evolved',
    # 'https://github.com/cubiq/ComfyUI_IPAdapter_plus'
])))

I checked it on Windows, everything is copied, maybe you can provide the error code or more detailed information, as I understand it you are not running Comfyui on a local computer.
import asyncio
import os
import subprocess

# Function git clone
def git_clone(repo_url, clone_path):
    result = subprocess.run(['git', 'clone', repo_url, clone_path], capture_output=True, text=True)
    if result.returncode == 0:
        print(f'Clone ok {repo_url} in {clone_path}')
    else:
        print(f'Clone failed {repo_url}. Error: {result.stderr}')

# Path to comfyui (test: current dir where script running)
comfyui_path = os.path.dirname(os.path.realpath(__file__))

# List url repositories
repos_to_clone = [
    'https://github.com/ltdrdata/ComfyUI-Manager.git',
    'https://github.com/AlekPet/ComfyUI_Custom_Nodes_AlekPet',
]

async def main():
    loop = asyncio.get_running_loop()
    await asyncio.gather(
        *(loop.run_in_executor(None, git_clone, repo_url, os.path.join(comfyui_path, "custom_nodes", os.path.basename(repo_url))) for repo_url in repos_to_clone)
    )

# Run code
asyncio.run(main())

Thank you for your response. This is a project I've published on the platform. The section is commented out because I wanted to add your plugin, but it's currently not working properly.

Hi, as an option you can do the following, see what path other extensions use, make a fork of my repository (if you can’t edit files directly in aistudio) and change the import paths of js files in js files and try.

Hello! Updated the paths of the nodes (pose and extras), please reinstall.

Hello! Updated the paths of the nodes (pose and extras), please reinstall and check.

The error is the same as before. Could it be that the actual file path /IDENode/lib and the URL path /lib/idenode are inconsistent?

Hello! Updated the paths of the nodes (pose and extras), please reinstall and check.

The error is the same as before. Could it be that the actual file path /IDENode/lib and the URL path /lib/idenode are inconsistent?

No errors with ide are not critical, since comfyui scans all folders for js files and tries to load them. But with pose and extras, I fixed it. This lines in two files https://github.com/AlekPet/ComfyUI_Custom_Nodes_AlekPet/issues/69#issuecomment-2256604259 . In the StableSwarmUi (https://github.com/Stability-AI/StableSwarmUI) there were the same errors with the same paths. Checks lines in the files (inspector chrome, tab source or network).

Hello! Updated the paths of the nodes (pose and extras), please reinstall and check.

The error is the same as before. Could it be that the actual file path /IDENode/lib and the URL path /lib/idenode are inconsistent?

No errors with ide are not critical, since comfyui scans all folders for js files and tries to load them. But with pose and extras, I fixed it. This lines in two files #69 (comment) . In the StableSwarmUi (https://github.com/Stability-AI/StableSwarmUI) there were the same errors with the same paths. Checks lines in the files (inspector chrome, tab source or network).

You're correct.
Ace.js often loads after the modules that depend on it.

Hello! Updated the paths of the nodes (pose and extras), please reinstall and check.

The error is the same as before. Could it be that the actual file path /IDENode/lib and the URL path /lib/idenode are inconsistent?

No errors with ide are not critical, since comfyui scans all folders for js files and tries to load them. But with pose and extras, I fixed it. This lines in two files #69 (comment) . In the StableSwarmUi (https://github.com/Stability-AI/StableSwarmUI) there were the same errors with the same paths. Checks lines in the files (inspector chrome, tab source or network).

You're correct.
Ace.js often loads after the modules that depend on it.


[WIP] add rbac support.

Signed-off-by: yxxhero<EMAIL_ADDRESS>
Description
add rbac support

Related Issue
https://github.com/dragonflyoss/Dragonfly2/issues/376

Motivation and Context

Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Documentation Update (if none of the other choices apply)

Checklist:

[ ] Code compiles correctly.
[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

Codecov Report

Merging #474 (13a624c) into main (7659def) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #474      +/-   ##
==========================================
- Coverage   36.54%   36.49%   -0.05%
==========================================
  Files          89       89
  Lines        6959     6959
==========================================
- Hits         2543     2540       -3
- Misses       4048     4051       +3
  Partials      368      368

Flag
Coverage Δ

e2etests
?

unittests
36.49% <ø> (-0.05%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

client/daemon/peer/peertask_base.go
32.21% <0.00%> (-0.72%)
:arrow_down:


Refactored document area to follow best practices

added props to super call
added placeholder state to state object
made number of columns responsive based on screen size
moved document area to dashboard

refactor looks great, styling is spot on

Like the fact that the screen automatically scales!

Good job looks great


General code enhancements, fixes and updates

This release contains several code enhancements, fixes and updates, including:

Remove restriction on printing DBIDs when sorting adjusted measurements
Change n-statistic sorting on GNSS baselines from magnitude of 3 (x, y, z) n-statistic components to maximum of the 3 n-statistic components.
Add capability to print ignored measurements for phased adjustments (fixes https://github.com/icsm-au/DynAdjust/issues/39) and restrict ignored measurements connected to unused stations from being printed
Code enhancements addressing various compiler warnings
Minor revisions to the User's Guide
Update version to 1.0.3
Remove old prerequisite installation and build scripts
Add debug launch handlers for gdb in vs code

Thanks for all this work @rogerfraser. Could I suggest that future PR be focused on one or two well defined changes? This is huge amount of changes to push through in one go and I suspect that even for you this would be difficult to review.

That's fine Craig.  Sorry for the inconvenience.

All good, the size of the DynAdjust code base is pretty daunting :-)


Moving background image to this repo

This might have a valid reason, but I just noticed that the background image is linked to a discord upload: https://media.discordapp.net/attachments/310799529161129984/417408747812552715/zilesanamin.jpg
Is there any reason for it? I would rather move it to this repo for a cleaner look ;)

Another thing I overlooked and forgot about. :sweat_smile:

Will be live in tomorrow's update.


Better inline policy/arn with essential privileges to create the emr virtualcluster using ACK

What is the URL of the document?

https://aws-controllers-k8s.github.io/community/docs/user-docs/irsa/
Which section(s) is the issue in?

https://github.com/aws-controllers-k8s/emrcontainers-controller/tree/main/config/iam
What needs fixing?

https://github.com/aws-controllers-k8s/emrcontainers-controller/tree/main/config/iam
The following page doesn't have an arn specified similar to ack s3.
https://github.com/aws-controllers-k8s/s3-controller/blob/main/config/iam/recommended-policy-arn
Currently only has an inline policy which is insufficient in terms of cluster creating privileges.
Additional context
A valid arn will be helpful to fix the validation issue which I'm facing while creating a EMR virtual cluster using ACK.
If I give admin privileges I am able to create the virtualcluster successfully which is not ideal for clusters other than test environments.
Appreciate something sImilar to ACK s3: arn:aws:iam::aws:policy/AmazonS3FullAccess for ACK EMR as well  to be documented.
This is the output of $ kubectl describe virtualclusters
Name:         my-ack-vc
Namespace:    default
Labels:       <none>
Annotations:  <none>
API Version:  emrcontainers.services.k8s.aws/v1alpha1
Kind:         VirtualCluster
Metadata:
  Creation Timestamp:  2024-06-21T19:30:01Z
  Finalizers:
    finalizers.emrcontainers.services.k8s.aws/VirtualCluster
  Generation:        3
  Resource Version:  34043
  UID:               102d8601-1d0f-475d-8681-8e61e2f6767b
Spec:
  Container Provider:
    Id:  eks-emr
    Info:
      Eks Info:
        Namespace:  ack-system
    type_:          EKS
  Name:             my-ack-vc
Status:
  Ack Resource Metadata:
    Owner Account ID:  1XXX4X8X4XXX
    Region:            us-east-1
  Conditions:
    Message:               ValidationException: Unauthorized to perform read namespace on ack-system
    Status:                True
    Type:                  ACK.Terminal
    Last Transition Time:  2024-06-21T19:56:47Z
    Message:               Resource not synced
    Reason:                resource is in terminal condition
    Status:                False
    Type:                  ACK.ResourceSynced
Events:                    <none>

Currently only has an inline policy which is insufficient in terms of cluster creating privileges.

Can you please tell more about the missing IAM Policies? What permissions are we missing?

arn:aws:iam::aws:policy/AmazonS3FullAccess

Managed policies are created by service teams, if there isn't one for EMR we will have to use an inline policy unfortunately

These are the default AWS managed policies available from console. None of them provide access to emr-containers: * services.


typo fix

Hi @ProtD, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, MSBOT;


Add CONTRIBUTING.md

Based on uber/grafana-dash-gen's CONTRIBUTING.md

Once we get the generate documentation/gh-pages pipeline setup, that should be noted in here too


Documentation for the Council Module

Relates to https://github.com/paritytech/substrate-developer-hub/issues/27
Requires update for consistency with https://github.com/paritytech/substrate/pull/2172

I will add a minimal code example for the seats selection to this tomorrow.
General overview of the doc:
Being a complicated module I prefer the Council as well to be treated a slightly different and give it a bit more room to be verbose, explain the story and rational etc. The current doc does that in terms of going through the terminology. Yet, I see the big picture entirely missing (which is understandable given that the doc author is not the coder and the module is complicated). I think the least that can be done here is for the terminology bullet points to be sorted in some sensible way?
Also, I don't know if having parts of the code comments as doc is ok or not. Maybe a good choice in favour of time but in the long term I think the doc should deliver more + easily understandable info, while the code comments are usually not like this.
I would recommend enhancing the format of this doc and merge it as an initial version and to have consistency in the level of doc contributed to each module, yet create a dev-hub issue to enhance this. I don't see making it perfect content-wise to be a trivial task, so it might have to stay for after Sub0.

Some of the implementation code from this line of code https://github.com/paritytech/substrate/pull/2281/files#diff-4b33d936907774f9f47492facc3f3ac4L21 was accidently modified unintentionally when trying to merge the latest master and fixing indentation. Joe suggested it'd be better to just create a fresh PR https://github.com/paritytech/substrate/pull/2447 where he's added some further changes in addition to fixing the accident that I caused


Index Desktop Icons for PowerToys Run

Please index desktop shortcuts for PowerToys run, or increase their search weight
Often I use PowerToys run as a quick way to launch things that I also have icons for on the desktop. This way I don't have to go back to the desktop to launch them. Many of these items also appear in the start menu, but not all of them. A good example of things that don't appear there and should be indexed separately are games installed through the Xbox app. They don't appear in search results even with additional shortcuts created. They do appear when I search in the Start Menu.

I think we need to validate how those apps are getting installed.  If they appear in start menu, we may just be not doing it correctly.
Can you give us an example of the game so we can repro that you got on xbox?

An example is Alien Isolation. Ori and the Blind Forrest.

Many of them are showing though, so that's confusing. Undertale is an example of that:

Additionally Some games that are installed through the Epic Games Store aren't present in PowerToys Run either.

Thanks for looking into this!

@ColinRNickels I downloaded Alien: Isolation and Ori using windows store and I am able to find these in powertoys run. Can you please clear cache by deleting following folder : %userprofile%/appdata/local/microsoft/powertoys/powertoys run/Cache  and see if these games show up?

I removed that folder and now both items appear!

caching issue then and being more proactive here for getting newest.

Fixed in 0.19.0, please visit https://github.com/microsoft/PowerToys/releases/ for the latest release


Stream protection with HLS and secure_link

I don't get the secure_link module to work with nested hls .m3u8 playlists and .ts chunks. With the base configuration (no uri mapping) only the master-playlist is served but the variant playlises and .ts chunks are denied (403) due to the lack of the hash. When usind a map directive, all files are denied (403).
Here is one of my configs (excerpt) I tried:
http {
...
map $uri $hls_uri {
~^(?<base_uri>.).m3u8$ $base_uri;
~^(?<base_uri>.).ts$   $base_uri;
default                 $uri;
}
server {
...
location /hls {
secure_link $arg_md5,$arg_expires;
secure_link_md5 "$secure_link_expires$hls_uri$remote_addr secret";
if ($secure_link = "") {
return 403;
}
if ($secure_link = "0") {
return 410;
}
}
}
}
Any ideas? Thanks for any help.

I think a directive like "hls_forward_args on" is missing here. It is available with the hls module from nginx (only mp4 > hls for vod, not live). Would be great to have that within the rtmp module for hls live.

Nginx RTMP module does not forward the arguments of the HLS URL to the different ts fragments of the m3u8 playlist. So, the player is not able to download the different ts fragments as Nginx server returns an error on the secure link check.
ffplay returns:

[hls,applehttp @ 0x7f8d68000b80] Opening 'http://mondomain.fr/hls/cours-8.ts' for reading
[http @ 0x7f8d68008400] HTTP error 403 ForbiddenB sq=    0B f=0/0
[hls,applehttp @ 0x7f8d68000b80] Failed to open segment of playlist 0
[hls,applehttp @ 0x7f8d68000b80] Opening 'http://mondomain.fr/hls/cours-9.ts' for reading
[http @ 0x7f8d680086e0] HTTP error 403 ForbiddenB sq=    0B f=0/0
[hls,applehttp @ 0x7f8d68000b80] Failed to open segment of playlist 0
[hls,applehttp @ 0x7f8d68000b80] Opening 'http://mondomain.fr/hls/cours-10.ts' for reading
[http @ 0x7f8d68008b40] HTTP error 403 ForbiddenB sq=    0B f=0/0
[hls,applehttp @ 0x7f8d68000b80] Failed to open segment of playlist 0

If it is not possible to fix this issue, do you know a workaround to secure the HLS stream?

You need to setup nginx so your URLs look something like this
domain.com/hls/argument1/argument2/cours-8.ts
This way, rtmp module can prepend those arguments to all the ts files in the playlist by setting it in hls_base_url
This has limitations, though, and the arguments can't be dynamic from what I recall. If you're looking for something dynamic, you can set the parameters via cookies, so you can do this via nginx directive (not very flexible), php, javascript, etc, and can retrieve them in nginx  config to use in the secure_link module. This is what I ended up doing, and it works great. It's not a super portable solution as your player needs to be able to access cookies, but security wise it's pretty good, since the files have to be accessed/played from the domain anyways.

Think you @MasterEvilAce  for your answer.
Take some time before answering to explore the different solutions and design it.
The principal of the security links is to control the access right on ephemeral links. The solution based on the path of link URI is not compatible with the need.
I do not want to use a solution based on cookie because I want to allow the user to use a standalone player like VLC for instance to watch the video.
I keep Nginx security link functionality and I added the missing part with a couple of scripts (PHP in my case):

one script to add the service link inside the m3u8 playlist
another script to generate the secured m3u8 links with a default web player

I finally removed nginx-rtmp-module which has no real added value in my case. The second script starts the FFmpeg process to generated the HLS files which are delivered from Nginx.
Maybe I will take a look again to the nginx-rtmp-module if I can enabled the support of SSL for the HLS files on the client side.


KDM or KMS?

Describe the bug
typo on readme ( maybe )
To Reproduce
KDM on readme, KMS on raspi-config
Expected behavior
I really believe it´s supposed to be KMS as there is no KDM on advanced raspi-config
Screenshots

Device information (please complete the following information):

Device info: Raspberry Pi Zero W
OS information: Raspberry Pi OS 32bit
Kernel module information: lsmod
Driver version:
Module                  Size  Used by                                                                                rfcomm                 49152  4                                                                                fuse                  114688  3                                                                                aes_arm                16384  1                                                                                aes_generic            40960  1 aes_arm                                                                                cmac                   16384  1                                                                                bnep                   20480  2                                                                                hci_uart               40960  1                                                                                btbcm                  16384  1 hci_uart                                                                                bluetooth             376832  29 hci_uart,bnep,btbcm,rfcomm                                                                                ecdh_generic           16384  2 bluetooth                                                                                ecc                    40960  1 ecdh_generic                                                                                libaes                 16384  3 bluetooth,aes_arm,aes_generic                                                                                8021q                  32768  0                                                                                garp                   16384  1 8021q                                                                                stp                    16384  1 garp                                                                                llc                    16384  2 garp,stp                                                                                brcmfmac              286720  0                                                                                brcmutil               20480  1 brcmfmac                                                                                sha256_generic         16384  0                                                                                libsha256              20480  1 sha256_generic                                                                                cfg80211              667648  1 brcmfmac                                                                                rfkill                 28672  6 bluetooth,cfg80211                                                                                raspberrypi_hwmon      16384  0                                                                                bcm2835_codec          36864  0                                                                                snd_bcm2835            28672  2                                                                                v4l2_mem2mem           32768  1 bcm2835_codec                                                                                bcm2835_v4l2           45056  0                                                                                bcm2835_isp            28672  0                                                                                bcm2835_mmal_vchiq     28672  3 bcm2835_isp,bcm2835_codec,bcm2835_v4l2                                                                                videobuf2_dma_contig    20480  2 bcm2835_isp,bcm2835_codec                                                                                videobuf2_vmalloc      16384  1 bcm2835_v4l2                                                                                videobuf2_memops       16384  2 videobuf2_dma_contig,videobuf2_vmalloc                                                                                snd_pcm                94208  1 snd_bcm2835                                                                                videobuf2_v4l2         28672  4 bcm2835_isp,bcm2835_codec,bcm2835_v4l2,v4l2_mem2mem                                                                                videobuf2_common       53248  5 bcm2835_isp,bcm2835_codec,bcm2835_v4l2,v4l2_mem2mem,videobuf2_v4l2                                                                                snd_timer              32768  1 snd_pcm                                                                                snd                    73728  7 snd_timer,snd_bcm2835,snd_pcm                                                                                videodev              225280  6 bcm2835_isp,bcm2835_codec,videobuf2_common,bcm2835_v4l2,v4l2_mem2mem,videobuf2_v4l2                                                                                vc_sm_cma              32768  2 bcm2835_isp,bcm2835_mmal_vchiq                                                                                mc                     45056  6 bcm2835_isp,bcm2835_codec,videobuf2_common,videodev,v4l2_mem2mem,videobuf2_v4l2                                                                                uio_pdrv_genirq        16384  0                                                                                uio                    20480  1 uio_pdrv_genirq                                                                                fixed                  16384  0                                                                                i2c_dev                16384  0                                                                                ip_tables              28672  0                                                                                x_tables               32768  1 ip_tables                                                                                ipv6                  446464  38

Additional context
That´s pretty much it, but I really want to thank you deeply, this would give me millions of possibilities as a game developer

Use Full KMS, thanks for noticing

Use Full KMS, thanks for noticing

Use Full KMS, thanks for noticing

no buddy, thank you... I will take advantage of our little interaction to ask you for pointing me in the direction on how to learn stuff like this... any books or even internet documentation you would recommend? thanks!

Use Full KMS, thanks for noticing

no buddy, thank you... I will take advantage of our little interaction to ask you for pointing me in the direction on how to learn stuff like this... any books or even internet documentation you would recommend? thanks!

the list is probably way too long :)
learn programming in low level languages like c/c++/assembly, learn computer graphics (opengl, vulkan), analyse how open source drivers work and how the linux stack works

the list is probably way too long :)
learn programming in low level languages like c/c++/assembly, learn computer graphics (opengl, vulkan), analyse how open source drivers work and how the linux stack works

That´s probably enough to lead me there! Thanks! I´ll close this now

That´s probably enough to lead me there! Thanks! I´ll close this now