NDJSON/CSV methods to add and update documents

⚠ This issue is generated, it means the nameing might be done differently in this package (ex: add_documents_json instead of addDocumentsJson). Keep the already existing way of naming in this package to stay idiomatic with the language and this repository.
📣 We strongly recommend doing multiple PRs to solve all the points of this issue
MeiliSearch v0.23.0 introduces two changes:

new valid formats to push data files, additionally to the JSON format: CSV and NDJSON formats.
it enforces the Content-type header for every route requiring a payload (POST and PUT routes)

Here are the expected changes to completely close the issue:

[ ] Currently, the SDKs always send Content-Type: application/json to every request. Only the POST and PUT requests should send the Content-Type: application/json and not the DELETE and GET ones.

[ ] Add the following methods and 🔥 the associated tests 🔥 to ADD the documents. Depending on the format type (csv or ndjson) the SDK should send Content-Type: application/x-dnjson or Content-Type: text/csv)

[ ] addDocumentsJson(string docs, string primaryKey)
[ ] addDocumentsCsv(string docs, string primaryKey)
[ ] addDocumentsCsvInBatches(string docs, int batchSize, string primaryKey)
[ ] addDocumentsNdjson(string docs, string primaryKey)
[ ] addDocumentsNdjsonInBatches(string docs, int batchSize, string primaryKey)

[ ] Add the following methods and 🔥 the associated tests 🔥 to UPDATE the documents. Depending on the format type (csv or ndjson) the SDK should send Content-Type: application/x-dnjson or Content-Type: text/csv)

[ ] updateDocumentsJson(string docs, string primaryKey)
[ ] updateDocumentsCsv(string docs, string primaryKey)
[ ] updateDocumentsCsvInBatches(string docs, int batchSize, string primaryKey)
[ ] updateDocumentsNdjson(string docs, string primaryKey)
[ ] updateDocumentsNdjsonInBatches(string docs, int batchSize, string primaryKey)

docs are the documents sent as String
primaryKey is the primary key of the index
batchSize is the size of the batch. Example: you can send 2000 documents in raw String in docs and ask for a batchSize of 1000, so your documents will be sent to MeiliSearch in two batches.
Example of PRs:

in PHP SDK: https://github.com/meilisearch/meilisearch-php/pull/235
in Python SDK: https://github.com/meilisearch/meilisearch-python/pull/329

Related to: https://github.com/meilisearch/integration-guides/issues/146
If this issue is partially/completely implemented, feel free to let us know.

Hi @alallema, I would like to work on this issue but, I was wondering if it would be solved or not in the next release you mentioned before, please let me know to start working on it.

Hi @diegonavarroq,
The next release brings a lot of improvement to other parts of the API. The management of the keys and a modification of updates in tasks so no worries on the part who add documents.
Thanks a lot for your interest ❤!


work on windows x64

I've find a windows x64 version of caffe, and it does work with training, but i  don't know how to compile the python and matlab wrapper, and i find your project here for some help, so ,will there be a windows x64 version of your project released? If necessary, this is the windows version caffe-master https://github.com/initialneil/caffe/tree/windows

maybe can use mingw compile on windows


Selected items not being selected in dropdown causing duplicates

Hi
whenever I place a item into the selectItems array it places the item in a position as seen bellow

this understandably creates a duplicate if i select the item again.
if you could help me out on this i would greatly appreciate thanks.
Sean

it appears that the ids were not the identical so i just change the id to something that wouldn't change and easy fix

Please read the documentation and test it multiple times before raising an issue. Thanks !


Create the Timelines Backend Solution

Create the backend solution for the Timelines app in order to kickstart the development of the ASP.NET segment of the app.
Acceptance criteria:

GitHub repo containing the backend solution is created.
Team members are added as colaborators.
The solution follows the clean architecture principles and is built following the modular monolith architectural principles.
Initial module Nodes is created alongside the Core.Api and the BuildingBlocks projects.
Project structure is described and documented.
The solution is virtualised as a service within the Docker assembly.
A database is added to the assembly as a service.

Story points: 8

This one is created upon completing the task for the sake of completeness.


Home Assistant: Deprecated payload_template option used in MQTT publish action call to topic evcc/power_meter_consumption

Describe the bug
Home Assistant show a warning with the current way EVCC publishes MQTT payloads:
Deprecated payload_template option used in MQTT publish action call to topic evcc/power_meter_consumption from payload template 1823.93. Use the payload option instead. In automations templates are supported natively. Update the automation or script to use the payload option instead and restart Home Assistant to fix this issue.
This stops working in version 2025.2.0 of Home Assistant
Steps to reproduce

enable MQTT in evcc:
mqtt: broker: mqtt:1883 user: xyz password: abc
run HA >= 2024.8.2
receive the warning in HA

Configuration details
`mqtt:
  broker: mqtt:1883
  user: xyz
  password: abc`

Log details
Not much to say here

What type of operating system are you running?
Linux
Version
0.130

Sorry, i am dumb. This is something i need to fix in my automation.


cosign verify doesn't properly validate when Vault used as KMS

Hey team!

I created 2 different keys in Vault.
I only used one to sign the image using cosign.
However, I'm able to use cosign verify using the other key.

➜  docker-trust-playground git:(main) ✗ cosign sign --key hashivault://my-key bluong/test-image
➜  docker-trust-playground git:(main) ✗ cosign verify --key hashivault://my-key2 bluong/test-image

Verification for bluong/test-image:latest --
The following checks were performed on each of these signatures:
  - The cosign claims were validated
  - The signatures were verified against the specified public key
  - Any certificates were verified against the Fulcio roots.

[{"critical":{"identity":{"docker-reference":"bluong/test-image"},"image":{"docker-manifest-digest":"sha256:cf902f10bbaf57e67641e8fbf73dc437afb7f1fb51bb8f9839a46ff7c84f6cae"},"type":"cosign container image signature"},"optional":null}]
➜  docker-trust-playground git:(main) ✗ echo $?
0

Interestingly, when I export the public key, verification fails
➜  docker-trust-playground git:(main) ✗ cosign public-key --key hashivault://my-key2 > my-key2.pub
➜  docker-trust-playground git:(main) ✗ cosign verify --key my-key2.pub bluong/test-image
Error: no matching signatures:
failed to verify signature
main.go:48: error during command execution: no matching signatures:
failed to verify signature

Other Info

Key type: ecdsa-p256
Cosign: 1.4.1
Vault: 1.9.1

Cc @developer-guy any guesses here?

Okay, I have the feeling the verification has been broken because based on vault verification endpoint "valid=true" should be what we expect as a successful verification

If replace line here with
if isValid, ok := valid.(bool); ok && !isValid {

and add "prehashed":  alg != crypto.Hash(0), to the request here
It does seem to be able verify
Plus solved issue with verify-blob where it verifies all files as Verified Ok
to reproduce
cosign verify-blob --key=hashivault://my-key --signature=file.sig ./<any arbitrary file>
Verified OK

@blz-ea Great! I was working on a PR but I saw your PR. Yes, it looks good to me and works.

@hectorj2f Thank you for the review
Sorry if I cut you with PR. Didn't mean to 😄

@blz-ea All good 👍🏻 ! Actually I was about to remove the prehashed in sign to fix it.


Some questions about constrained decoding

Hello, Mr. Lu. In the constraint decoding algorithm, there is a judgment that is not clear. Can you help explain it?
def check_state(self, tgt_generated):
        if tgt_generated[-1] == self.tokenizer.pad_token_id:
            return 'start', -1

Here,tgt_generated[-1]==self.tokenizer.pad_token_idmeansstart,Why？Can we substitute decoder_start_token_id for self.tokenizer.pad_token_id？Or just use the value 0？
In my opinion, if tgt_generated[-1] == self.tokenizer.pad_token_id,It means that the last one is pad_token, so the generation enters the end phase instead of the start phase.So judge the start of generation with decoder_ start_ token_ id is recommended, is it right?

Hi,
This is because T5 uses the pad_token_id as the starting token for decoder_input_ids generation.
Employing decoder_start_token_id is better for other tokenizers.

Hi,
This is because T5 uses the pad_token_id as the starting token for decoder_input_ids generation. Employing decoder_start_token_id is better for other tokenizers.

I use XLMRobertaToken, it takes cls_token as the start tag, sep_token as the end tag,pad_token as the pad tag. To adapt to T5Model，I add codes as
config.eos_token_id = tokenizer.eos_token_id
config.pad_token_id = tokenizer.pad_token_id

Does that mean my judgment should be tgt_generated[-1]==self.tokenizer.cls_token_id?
At present, the program can run without constraint decoding algorithm, and the effect is OK; With the constraint decoding algorithm, the program F value is 0. So what's the problem？

I think it is no need to add config.eos_token_id = tokenizer.eos_token_id.
You can rewrite the constraint decoding based on the XLMRobertaTokenizer, as you stated that cls_token as the start tag, sep_token as the end tag.
I think the modification of some special symbols in the raw code for the constraint decoding should be working.
For example, change type_start/type_end/pad_token_id/eos_token_id according the generation state and the XLMRobertaTokenizer.
For the problem of F=0, it is better to analyze the content of the generation.
For example, one possible results of generation are all empty (no event) <extra_id_0> <extra_id_1>.

I think it is no need to add config.eos_token_id = tokenizer.eos_token_id.
You can rewrite the constraint decoding based on the XLMRobertaTokenizer, as you stated that cls_token as the start tag, sep_token as the end tag. I think the modification of some special symbols in the raw code for the constraint decoding should be working. For example, change type_start/type_end/pad_token_id/eos_token_id according the generation state and the XLMRobertaTokenizer.
For the problem of F=0, it is better to analyze the content of the generation. For example, one possible results of generation are all empty (no event) <extra_id_0> <extra_id_1>.

Thank you for your analysis. I seem to have some ideas！
Wish you every success in your work!

Thanks


[Feature] Extended key bindings (M&K)

Device
Desktop
Operating System
Windows
Browser
Chrome/Edge/Chromium
Suggestion
Would be nice if we could bind the same key to more than one button in case they don't conflit with each other during gameplay.
Also, having modifiers for quick range changes on the Axis, AKA holding Shift would make Left Analog range decrease to 50 or 25% (Customizable if possible) making your character walk instead of run.
Plus, would be great if we could have access to the "file" of the mapping, so more advanced users could customize it their own way indepth on the coding side, like most console emulators works nowadays, allowing us to setup modifiers that would allow a partial mapping change. And not only that, this would allow us to save, export and share the mapping.
That would be useful in games like AC where you want to have your melee attacks and ranged attacks both mapped to your mouse.
Also, maybe a third row for binding, allowing us to bind up to 3 keys per button instead of 2. Is that possible?

This is too complicated and out of scope. Please use third-party app like reWASD.


List enabled transformers

There should be a way to list enabled transformers.
One option would be to add another column to output of --list command f.g. just  Enabled
that would list the status after configuration is taken into account.

Yes, that sound about right.👍

Having default values is great way for checking what might need enabling/disabling for my own use.
Having status reflecting my configuration provides easy way to verify it
If we/you want to play with colors then changed values could be shown in different color.

Well, I tend to use this kind of list (both robotidy & robocop) is in CI runs. Having the printout in CI output provides an easy way check what configuration, in fact, was in place when something failed (or did not fail).

I have figured out the first part (using configuration in --list). Now it will use white colour for default, and magenta (current color for disabled transformers) for modifed ones.
Default output (on Windows):

robotidy --list

robotidy -c configure Translate:enabled=True --list

robotidy --transform Translate --list

For the second part (and main topic of this issue), the click 8.+ version introduces optional values. I have decided to bump minimal required version of click (from 7.1.3) to get this feature.
With this it is possible to filter our results:

FInal note - the --list obviously will take into account configuration from the config files. Now I need to add various tests for this feature. It should be part of the next release (which I'm planning for tommorrow).
I can tweak this option in the future if there are any additional suggestions or bugs.

Just couple things to remember.
Usually in CI there are no colors (but the main thing to get is what are the active transformers).
As it takes into account the config the list should also contain custom (users own) transformers.

The color are just addition - but I agree that without the color it's impossible to see if the original status was overwritten by configuration. I will add "*" to enabled status to further denote such cases, so it is visinle even without colors.
As for custom transformers, you're right, I completely forgot about them! The code is designed in a way that it should be already supported or easy to add support but I need to test it. It's actually interesting because it's clear for me people are creating they own rules for Robocop but I have not heard about custom transformers that much. I hope though they are in use and I will provide support for them. Thanks!

The thing is that, well, first I had this feature request to allow underscore as first char in keyword name to visually mark "private" keywords in RenameKeywords but soon realized that it not enough.
We need the following:

Remove underscore
Make words title case
Handle embedded variable "our way"

The last thing is the difficult one. We have a format how to use embedded variables. And they may contain underscores and all lowercase letter. they need to be detected and excluded from the transformation.
So we may need to customize what you have already done. And I will need to learn that.
So happy debugging ahead
It would help, though, if there would be a bit more words on how those work😉

Our transformers were designed on top of the Robot Framework Model Transformer. That's why there isn't much of the documentation (except https://robotidy.readthedocs.io/en/stable/external_transformers.html), Besides various optional features from the robotidy (like skipers or disables, formatting config etc) the transformer code is just Python code and Robot API. However I know that learning the Robot Framework API/model takes time and there are various special edge cases or problems (RF is after all quite flexible). What helps me is follow TDD approach. I first create some skeleton of the transformer, create basic tests and run them and debug to see what Robot model of given part of the code looks like etc.
You can start by using RenameKeywords transformer and its tests (https://github.com/MarketSquare/robotframework-tidy/blob/main/tests/atest/transformers/RenameKeywords/test_transformer.py). Select given test, put breakpoint in the code and see what you will get. The RenameKeywords has bit of complicated code because of all possible edge case it covers. In your case if you want what you want you might to use lot less code. For instance the lines with VariableIterator parse the embedded variables in the code and may be useful for you. I'm always happy to help and if you have any questions I will answer. And I will try to extend our documentation on the topic.
Btw thanks to you I have found some leftover debug code in the RenameKeywords :D Such as:
        if value.strip() == "${keyword}":
            print()

I will clean it up.


Fails only if the build command was executed with postinstall

Describe the bug
I'm writing a rules package for a tool called textlint in monorepo.
There are packages in "packages" with the build command set to "postinstall", but when I try to install the dependencies, it fails.
TypeError: Method get TypedArray.prototype.length called on incompatible receiver [object Object]
│     at get length [as length] (<anonymous>)
│     at _0x2290eb (https://stackblitzstarterswije7f-nlli.w-credentialless.staticblitz.com/blitz.c53ab388.js:37:266369)
│     at https://stackblitzstarterswije7f-nlli.w-credentialless.staticblitz.com/blitz.c53ab388.js:37:267155
│     at Array.forEach (<anonymous>)
│     at _flushBuffer (https://stackblitzstarterswije7f-nlli.w-credentialless.staticblitz.com/blitz.c53ab388.js:37:26714…
│     at Map.forEach (<anonymous>)
│     at _0x346633 (https://stackblitzstarterswije7f-nlli.w-credentialless.staticblitz.com/blitz.c53ab388.js:37:265677)
│     at https://stackblitzstarterswije7f-nlli.w-credentialless.staticblitz.com/blitz.c53ab388.js:42:407467
│     at Object.spawn (https://stackblitzstarterswije7f-nlli.w-credentialless.staticblitz.com/blitz.c53ab388.js:42:40758…
│     at Object.spawnSync (https://stackblitzstarterswije7f-nlli.w-credentialless.staticblitz.com/blitz.c53ab388.js:35:1…
│  ELIFECYCLE  Command failed with exit code 1.

However, if the build command is executed as follows, it completes without problems.
pnpm run -r postinstall

or
cd packages/textlint-rule-example
pnpm postinstall

Link to the blitz that caused the error
https://stackblitz.com/edit/stackblitz-starters-wije7f
Steps to reproduce
Just open blitz.
Expected behavior
The build completes without outputting any errors.
Parity with Local

[X] I have run the project in my local machine and I could not reproduce the issue.

Screenshots
No response
Platform

OS: Windows 11
Browser: Chrome, Firefox
Version:

Chrome 114.0.5735.199
Firefox 116.0b6

Additional context
When pnpm install is executed, an error is displayed, but the build process itself seems to complete successfully.

Hi! :wave: Thanks for reporting the issue!
when I run the project locally (not in WebContainer) I get;
Lockfile is up to date, resolution step is skipped
Already up to date
packages/textlint-rule-example postinstall$ pnpm build
│ ><EMAIL_ADDRESS>build /home/cake/wfh/webcontainer/e2e/fixtures/aaaa/textlint/packages/textlint-rule-example
│ > textlint-scripts build
│ ../../../../../../node_modules/@types/express-serve-static-core/index.d.ts(589,18): error TS2430: Interface 'Response<ResBod
[1 lines collapsed]
│     Type 'Request<ParamsDictionary, any, any, ParsedQs, Record<string, any>> | undefined' is not assignable to type 'Incomin
│2      Type 'undefined' is not assignable to type 'IncomingMessage'.```

Because of this I've not been able to confirm that this is an issue with WebContainer

Can you confirm it definitely works locally for you? Is there something else I need to do to get it to work?

Thanks for confirming this!
This is working fine in my local environment. The local node.js and pnpm versions are the same as those used in WebContainer.
> node -v
v16.20.0

> pnpm -v
8.6.3

> pnpm install
Scope: all 2 workspace projects
Lockfile is up to date, resolution step is skipped
Packages: +420
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Packages are hard linked from the content-addressable store to the virtual store.
  Content-addressable store is at: /home/hiratake/.local/share/pnpm/store/v3
  Virtual store is at:             node_modules/.pnpm
Progress: resolved 420, reused 418, downloaded 2, added 420, done
packages/textlint-rule-example postinstall$ pnpm build
│ ><EMAIL_ADDRESS>build /home/hiratake/workspace/monorepo/packages/textlint-rule-example
│ > textlint-scripts build
│ Successfully compiled 1 file with Babel (382ms).
└─ Done in 3s
Done in 5.2s

I have a repository of my website with the same problem.
This repository is installing dependencies within a GitHub Actions workflow. In this case, the build still completes successfully. However, it fails in WebContainer.
https://github.com/Hiratake/hiratake-web
https://stackblitz.com/~/github.com/Hiratake/hiratake-web

Thanks for the updated links. I still cannot get the original version to install locally, but the hiratake-web repo works locally for me and has this issue in WebContainer
We're tracking this issue internally and will post updates about it when we have them.


chore(release): Autobump agent plugin version (0.13.4)

Automated PR

Merged on https://github.com/armory/docs/pull/2014


Main Only RX, make the display more simple. (only show one VFO)

Hi Guys, this firmware is great. My only problem is complexity for family use, plus my eyes are not that good. Personally, I run my radio solely in main only RX mode i don't really ever use the second VFO. therefore i would like if i could have only one VFO displayed at a time in this mode (Or another mode, i don't mind) still being able to switch between a and b could be nice, however if the main thing is that if only 1 VFO is displayed, the main font could be larger, and easier on my eyes.
Thanks guys,
let me know if I'm completely wrong and this is not a valid request.

I also want such feature.

related to (or duplicate of) #124


xmp capabilities?

anyway to retrieve and write xmp tags in the metadata?
I 've tested with few video files that have embedded XMP metadata, yet the xmp tag is not showing up.

Hi,
This is an ffprobe question (fluent-ffmpeg just runs ffprobe/ffmpeg), please seek help from the ffmpeg community :)

there is no potion to send the flag to ffprobe with your module. in ffprobe.js .
      // Spawn ffprobe
      var ffprobe = spawn(path, [
        '-show_streams',
        '-show_format',
       '-export_xmp',
         '1',
        input.source
      ]);

adding "-export_xmp 1" flag is what tells ffprobe to include xmp key into the format node. but it seems that the xmp key is parsed incorrectly.


Improve chest images

Chests images should be pixel perfect, consistent, with better resolution, and include new chests.

Fixed by @MaherFa on #53.


ImportError: cannot import name contrib

while running the pipeline unit test, i get this error
Traceback (most recent call last):   File "/usr/lib/python2.7/runpy.py", line 174, in _run_module_as_main     "__main__", fname, loader, pkg_name)   File "/usr/lib/python2.7/runpy.py", line 72, in _run_code     exec code in run_globals   File "/usr/lib/python2.7/unittest/__main__.py", line 12, in <module>     main(module=None)   File "/usr/lib/python2.7/unittest/main.py", line 94, in __init__     self.parseArgs(argv)   File "/usr/lib/python2.7/unittest/main.py", line 149, in parseArgs     self.createTests()   File "/usr/lib/python2.7/unittest/main.py", line 158, in createTests     self.module)   File "/usr/lib/python2.7/unittest/loader.py", line 130, in loadTestsFromNames     suites = [self.loadTestsFromName(name, module) for name in names]   File "/usr/lib/python2.7/unittest/loader.py", line 91, in loadTestsFromName     module = __import__('.'.join(parts_copy))   File "seq2seq/__init__.py", line 24, in <module>     from seq2seq import contrib ImportError: cannot import name contrib

Hi, could you tell me how you solved this error?

the problem is basically with the path. it worked for me when i change the path in the code

I was able to fix the issue by following a comment mentioned in this thread.
https://github.com/google/seq2seq/issues/37

#from tensorflow.contrib.distributions.python.ops import bernoulli
#from tensorflow.contrib.distributions.python.ops import categorical
try:
from tensorflow.python.ops.distributions import bernoulli
from tensorflow.python.ops.distributions import categorical
except:
from tensorflow.contrib.distributions.python.ops import bernoulli
from tensorflow.contrib.distributions.python.ops import categorical

In file seq2seq/seq2seq/contrib/seq2seq/helper.py

Worked for me!

Worked for me!

It works.


Advisory serializing/deserializing a CultureAwareComparer with .NET Framework 4.6+

Advisory serializing/deserializing a CultureAwareComparer with .NET Framework 4.6+
An issue with serializing/deserializing a CultureAwareComparer was discovered with .NET Framework 4.7.1. This issue was resolved earlier this year, with the May 2018 Preview of Quality Rollup. We recently learned that some applications continue to experience this issue. The changes made to .NET Framework 4.7.1 were also integrated into .NET Framework 4.6 and later servicing releases. As a result, this advisory applies to .NET Framework 4.6 and later versions.
This advisory is provided so that developers can correctly diagnose this issue and be aware of our guidance. We will continue to update this issue as we have new information to share.
Guidance
This guidance only applies to customers that have experienced this issue.
We intend to release an update for .NET Framework 4.6 and later releases that resolves this issue within the next month. When that happens, you must deploy the .NET Framework update for this issue to all .NET Framework 4.6+ machines that communicate via serialized objects. After doing that, cross-machine serialization will work as expected.
Please consult your software vendor to understand if this impacts the software you are using.
Technical Context
In the May 2018 Preview of Quality Rollup, we made a change to the internal type CultureAwareComparer to implement ISerializable. We made the change in order to address issue with serializing/deserializing a CultureAwareComparer.
The issue reported was that a type that contains an instance of CultureAwareComparer was not able to correctly serialize and deserialize across different versions of the .NET Framework. There are a few types in .NET Framework that do this, the most commonly impacted one being the Dictionary<TKey, TValue> type.
The change to implement the ISerializable interface had unintended side effects when exchanging this type across different machines. We have had a small number of reports from customers who have been affected.
A common, but not unique way, of exchanging objects across machines is to use WCF in conjunction with a serializer. One of the common serializers being DataContractSerializer. The side-effect of the change prevented data serialized on systems where the type implements ISerializable to correctly deserialize of systems where the type does NOT implement ISerializable. The same is true of the opposite case, that systems where the type does not implement ISerializable will not correctly deserialize data from systems where the type does implement ISerializable.
We have an updated fix that we intend to release within the next month that will remove the implementation of the ISerializable interface on the type and use a different internal mechanism for ensuring the cross-version serialization continues to work as expected. This change addresses the break experienced with WCF.
The upcoming fix will remove the implementation of the ISerializable interface on the type and use a different mechanism for ensuring the cross-version serialization of that type continues to work. This change addresses the break experienced with WCF.
Symptoms
An application that is affected by this issue will most likely crash when trying to deserialize an object. It may print or log an error message similar to the following one:
The formatter threw an exception while trying to deserialize the message:
There was an error while trying to deserialize parameter . The InnerException message was ''EndElement' 'Comparer' from namespace '' is not expected. Expecting element '_compareInfo'.'.  Please see InnerException for more details.

@richlander Can you please be more specific about what exactly 4.6+ means? Is it 4.6.* or is it all versions after 4.6.0, i.e. 4.6.* AND 4.7.*?


Support for RHEL 7.4

Newest available version of RHEL in Azure is 7.4
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information

[x] The title of the PR is clear and informative.
[x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
[x] Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
[ ] If applicable, the PR references the bug/issue that it fixes.
[ ] Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

[ ] I have read the contribution guidelines.
[ ] My spec meets the review criteria:

[ ] The spec conforms to the Swagger 2.0 specification.
[ ] The spec follows the guidelines described in the Swagger checklist document.
[ ] Validation tools were run on swagger spec(s) and have all been fixed in this PR.

@cantorek This file also need to be changed - https://github.com/cantorek/azure-rest-api-specs/blob/e2a218e49585cb0d483336529723139499ef1276/specification/compute/quickstart-templates/aliases.json#L41 before approval and merge

@gatneil, you okay with that? I cross checked PIR images, looks like the only offerring that has the SKU 7.4 is the RHEL-SAP which is not the mainline one.
I think we should stick to 7.3
(env) D:\sdk\azure-cli>az vm image list --all -p Redhat --offer RHEL --sku 7.4 -otable
Offer     Publisher      Sku  Urn                                 Version
--------  -----------  -----  ----------------------------------  --------------
RHEL-SAP  RedHat         7.4  RedHat:RHEL-SAP:7.4:7.4.2018031222  7.4.2018031222

Yeah, I we should stick with the mainline one, which is only up to 7.3.

@sarangan12 Sure, I can do that.
@gatneil @yugangw-msft are you positive about this?
I'm relatively new to Azure, but RHEL 7.4 is available in azure portal and when trying to list images using CLI - az vm image list --all I can see things like:
  {
    "offer": "rhel-byol",
    "publisher": "RedHat",
    "sku": "rhel74",
    "urn": "RedHat:rhel-byol:rhel74:7.4.0",
    "version": "7.4.0"
  },
  {
    "offer": "rhel-ocp-marketplace",
    "publisher": "RedHat",
    "sku": "rhel74",
    "urn": "RedHat:rhel-ocp-marketplace:rhel74:7.4.1",
    "version": "7.4.1"
  },

Indeed, RHEL offereing is only 7.3.
:-(

@johanste This is the PR that I was talking about. Please take a look as you have more expertise in this area.

@cantorek I don't know what you want to accomplish here. You can sure use the output of az vm image --all command to pick any newer RHEL image you like to create a vm, like az vm create --image RedHat:RHEL-SAP:7.4:7.4.2018031222 -g myGroup -n myvm1.
It is unnecessary (not correct) to update this alias file which is designed as the shortcut to the most reliable/mainline PIR images available to all regions w/o extra costings.

Similarly, you can use the corresponding imageReference in a Azure Resource Manager template to specify the image.


error in using argparse in ipython google colab

usage: [-h] --model_file MODEL_FILE [--ken_lm_file KEN_LM_FILE]
: error: the following arguments are required: --model_file
An exception has occurred, use %tb to see the full traceback.
SystemExit: 2
/usr/local/lib/python3.6/dist-packages/IPython/core/interactiveshell.py:2890: UserWarning: To exit: use 'exit', 'quit', or Ctrl-D.
warn("To exit: use 'exit', 'quit', or Ctrl-D.", stacklevel=1)

usage: [-h] --model_file MODEL_FILE [--ken_lm_file KEN_LM_FILE]
: error: the following arguments are required: --model_file
An exception has occurred, use %tb to see the full traceback.
SystemExit: 2
/usr/local/lib/python3.6/dist-packages/IPython/core/interactiveshell.py:2890: UserWarning: To exit: use 'exit', 'quit', or Ctrl-D.
warn("To exit: use 'exit', 'quit', or Ctrl-D.", stacklevel=1)


Addition of transcriptome output for STAR and update test data

Please indicate the output STAR transcriptome bam filename pattern.

Addressed.


Any way we can execute some continuations with ExecuteSynchronously?

https://blogs.msdn.microsoft.com/pfxteam/2010/05/24/why-is-taskcontinuationsoptions-executesynchronously-opt-in/
I've also been working with getting F#'s TPL usage up to the perf level that C# has for a few of our  ASP.NET Core middlewares and judiciously adding TaskContinuationOptions.ExecuteSynchronously for small function bodies like exception handlers etcetera really made a huge difference in that code's performance profile.
The hard part about this however is that there is no way of accessing these levers while working with a CE. As I see you have done some really nice work on writing a performant CE I hope you might have some good ideas we, the F# community, are able to pursue.
I think it's a pity the TPL is natively so badly supported as it's crucial in working with many of the libraries written in C# these days.

I don't think this is possible (or necessary? not sure) since Task.ContinueWith is not used at all in the TaskBuilder, so we have nowhere to pass this option.
The implementation is designed to mimic the state machine generated by the C# compiler for async methods. It has a bit more overhead than the C# version because on each MoveNext() call it must call a closure to run the next chunk of synchronous code (to get to the next awaitable or return), instead of just switching on a state ID to jump straight to the code. Other than that unavoidable(?) performance cost, it should function identically.
In my experience so far, Task.ContinueWith is only suitable for chaining a fixed, relatively small number of continuations onto a task. It doesn't make a very good all-purpose monadic Bind due to this issue.

Yeah saw that a while after posting this issue too, I think that is all the room you have there then. Never hurts to confirm though :)
Bottom line it's just a bit slower in stepping and probably more allocation hungry, that doesn't sound that bad actually ^_^. Our hotpaths are mostly using continueWIth + ExecSync at the right places, minimizing the time we're in a TPL continuation and evading the CE builder allocs. Most other places just use Async or our own Task CE.
All in all it's a very pretty implementation you created, really nice work, and I'm absolutely including this in our codebase.

Thanks!


GitHub is HTTPS by default

This reduces unnecessary redirection from http://... to https://... when someone visits this gem's homepage via https://rubygems.org/gems/activerecord-nulldb-adapter or some tools or APIs that use the gem's metadata.

Thank you


HIVE-26195: Keep Kafka handler naming style consistent with others

What changes were proposed in this pull request?

Why are the changes needed?

Change Kafka handler naming to Keep it consistent with others (JDBC, Hbase, Kudu, Druid).
Does this PR introduce any user-facing change?

No
How was this patch tested?

There is no new code added, so no need test

Failed iceberg tests need to be fixed by https://github.com/apache/hive/pull/3262


[@react-native-community/eslint-config] Peer deps

Move dependencies to peer dependencies and loose version.
You don't directly require() them in the JavaScript code of this package, so don't force users to keep old versions of the typescript parser

Summary

Changelog

[Internal] [Security] - Moved @react-native-community/eslint-config dependencies to peer dependencies
Test Plan

I submitted the CLA check from the link, but didn't seem to work and unblock the PR

You don't directly require() them in the JavaScript code of this package

This doesn't mean that they aren't used. From an ESLint doc, it looks like https://github.com/facebook/react-native/blob/main/packages/eslint-config-react-native-community/index.js is a "shareable config" file, and it uses at least some of them in, to take one example,
  extends: [
    'plugin:prettier/recommended', // https://github.com/prettier/eslint-plugin-prettier#recommended-configuration
    'prettier/react',
  ],

I think that doc would recommend putting some of them under peerDependencies. But there are some (maybe eslint-config-prettier and @typescript-eslint/parser?) that it would rather be kept under dependencies, it looks like:

If your shareable config depends on a plugin, you should also specify it as a peerDependency (plugins will be loaded relative to the end user's project, so the end user is required to install the plugins they need). However, if your shareable config depends on a third-party parser or another shareable config, you can specify these packages as dependencies.

For whether to remove the upper bound on the ranges, I guess that's recommended in the doc:

The recommended way to declare a dependency for future proof compatibility is with the ">=" range syntax, using the lowest required ESLint version.

But that approach doesn't actually guarantee "future-proof compatibility." It just means you won't get a warning when compatibility is broken in the future. It's a claim that "this package will work with all future versions of dependency X," and that'll be pretty unrealistic until time travel is invented. I guess you could check the packages' changelogs for breaking changes up until the current moment, and of course test that things work when you pull in all their current latest versions.


Inpainting code and video

https://www.youtube.com/watch?v=N913hReVxMM
I think it works pretty well but i wouldnt implement it like he did (on small 512 image and synthesizing whole image)
What i would do is open a big image and start to synthesize by moving a window with adjustable size 512x512 lets say and mask things i want to apply inpainting to, this way we can work on huge images and fill them up with a lot of generated windos at various sizes .
Well, basically something like this would be better approach , scaling the window and synthesizing on small parts is a good way to save gpu cycles and time .
https://twitter.com/EMostaque/status/1555245665676132353?s=20&t=rVGevPHhk5hHooQWA-S1sw
A moveable window, not sure if thats possible in gradio.

Inpainting is a great feature. I see that at least a couple of other forks have implemented WebUIs to support it. Interactive web design is not my strong point and I'm hoping another developer will volunteer to reimplement or copy the approach.

@lstein this repo support inpainting https://github.com/hlky/stable-diffusion-webui, if you are looking for simple interface, check out the hosted version here: https://huggingface.co/spaces/stabilityai/stable-diffusion, you can add inpainting quiclky with huggingface diffusers: https://github.com/huggingface/diffusers#in-painting-using-stable-diffusion


Replace os::args() by os::args_as_bytes()

Under linux you can have non-utf8 filenames, e.g.,
#include <fcntl.h>
#include <unistd.h>

int main(void)
{
    int fd = creat("test\xf0\x90\x80test", 0644);
    write(fd, "hello\n", 6);
    close(fd);
}

When you try to cat this file with gnu cat you get
$ cat test$'\360'$'\220'$'\200'test
hello

When you try to cat this file with uutils cat you get
$ ~/rust/coreutils/cat/cat test$'\360'$'\220'$'\200'test
cat: test�test: no such file or directory (No such file or directory)

That's because args() has replaced the invalid sequence by �.

This can be closed as we've moved to using clap for argument handling.


IOS ITMS-91053 errors

I am using version 16.4 of the cordova-plugin-firebasex plugin
App Store Connect is still warning of APIs
ITMS-91053: Missing API declaration - Your app’s code in the “Lorca connect” file references one or more APIs that require reasons, including the following API categories: NSPrivacyAccessedAPICategoryFileTimestamp. While no action is required at this time, starting May 1, 2024, when you upload a new app or app update, you must include a NSPrivacyAccessedAPITypes array in your app’s privacy manifest to provide approved reasons for these APIs used by your app’s code. For more details about this policy, including a list of required reason APIs and approved reasons for usage, visit: https://developer.apple.com/documentation/bundleresources/privacy_manifest_files/describing_use_of_required_reason_api.
ITMS-91053: Missing API declaration - Your app’s code in the “Lorca connect” file references one or more APIs that require reasons, including the following API categories: NSPrivacyAccessedAPICategoryDiskSpace. While no action is required at this time, starting May 1, 2024, when you upload a new app or app update, you must include a NSPrivacyAccessedAPITypes array in your app’s privacy manifest to provide approved reasons for these APIs used by your app’s code. For more details about this policy, including a list of required reason APIs and approved reasons for usage, visit: https://developer.apple.com/documentation/bundleresources/privacy_manifest_files/describing_use_of_required_reason_api.
ITMS-91053: Missing API declaration - Your app’s code in the “Lorca connect” file references one or more APIs that require reasons, including the following API categories: NSPrivacyAccessedAPICategoryUserDefaults. While no action is required at this time, starting May 1, 2024, when you upload a new app or app update, you must include a NSPrivacyAccessedAPITypes array in your app’s privacy manifest to provide approved reasons for these APIs used by your app’s code. For more details about this policy, including a list of required reason APIs and approved reasons for usage, visit: https://developer.apple.com/documentation/bundleresources/privacy_manifest_files/describing_use_of_required_reason_api.
How can I resolve this problem?
Do I need to specify a specific version of the Firebase SDK to resolve this issue? (IOS_FIREBASE_SDK_VERSION)

https://stackoverflow.com/questions/78163859/itms-91053-missing-api-declaration-privacy

https://stackoverflow.com/questions/78163859/itms-91053-missing-api-declaration-privacy

Thanks I saw this.
There are 2 solutions:
Add the privacyinfo.xcprivacy file from xcode
Update the SDK version to a version that has privacyinfo support.
I would like to do the second but how do I know which SDK to use?

From what I read, Google Firebase has updated their SDKS with the required privacy info. Does this plugin use those updated SDKs? Or will it need to be updated?

From what I read, Google Firebase has updated their SDKS with the required privacy info. Does this plugin use those updated SDKs or will it need to be updated?
I think Apple is requiring 3rd party SDKS (Firebase) to use the privacy info at the plugin level, meaning we cant just add it to our project. Can anyone confirm that?

This plugin (repo) uses iOS SDK 10.17.0. On my fork I've updated the sdk to 10.23.0, which has the PrivacyInfo.xcprivacy added (https://github.com/firebase/firebase-ios-sdk/releases/tag/10.23.0).
Personally I've created a PrivacyInfo.xcprivacy file in the iOS root folder and added all the info there and I had no longer any warning (keep in mind if you delete the ios platform and you re-add it, you need to add the file again. Myself I've added a script to be executed at "after_platform_add" hook, to add this file automatically).
My recommendation is to use sdk 10.24.0 (I will update my fork with the latest versions, both for iOS and Android) and if the warnings persist, I would add the PrivacyInfo.xcprivacy manually in the root folder.

I've updated my fork with iOS sdk 10.24.0 and bumped up Android sdks versions

Resolved by release of<EMAIL_ADDRESS>

thx it's work


between ... and ... for column of datetime  type is not supported

Bug Report
SQL like "select * from t_order  where create_time between '2018-01-01 00:00:00' and '2018-01-02 00:00:00'"  is not supported, we use create_time for RangeShardingAlgorithm
 public Collection<String> doSharding(Collection<String> availableTargetNames, RangeShardingValue<String> value)
CommonExpressionSegment.java not support the string value and in the code of PredicateExtractor
it extract the number value and ignore the string value.
 private Optional<? extends ExpressionSegment> buildExpression(final Map<ParserRuleContext, Integer> questionNodeIndexMap, final ParserRuleContext valueNode) {         Optional<? extends ExpressionSegment> sqlExpression = new ExpressionExtractor().extract(valueNode);         if (!sqlExpression.isPresent() || !(sqlExpression.get() instanceof CommonExpressionSegment)) {             return sqlExpression;         }         CommonExpressionSegment commonExpressionSegment = (CommonExpressionSegment) sqlExpression.get();         Optional<ParserRuleContext> expressionNode = ExtractorUtils.findFirstChildNode(valueNode, RuleName.QUESTION);         if (expressionNode.isPresent()) {             Integer index = questionNodeIndexMap.get(expressionNode.get());             commonExpressionSegment.setIndex(index);         } else {             Optional<ParserRuleContext> bitExprNode = ExtractorUtils.findFirstChildNode(valueNode, RuleName.BIT_EXPR);             expressionNode = ExtractorUtils.findFirstChildNode(valueNode, RuleName.NUMBER);             if (expressionNode.isPresent() && (!bitExprNode.isPresent() || 1 == bitExprNode.get().getChildCount())) {                 commonExpressionSegment.setValue(NumberUtil.getExactlyNumber(expressionNode.get().getText(), 10));             }         }         return sqlExpression;     }
Which version of ShardingSphere did you use?
3.1.0
Which project did you use? Sharding-JDBC or Sharding-Proxy?
Sharding-JDBC
Expected behavior
supported
Actual behavior
not supported
Reason analyze (If you can)
as mentioned above
Steps to reproduce the behavior, such as: SQL to execute, sharding rule configuration, when exception occur etc.
as mentioned above
Example codes for reproduce this issue (such as a github link).
as mentioned above

It is depends on your customized RangeShardingAlgorithm, in your example, the generic of  RangeShardingAlgorithm is String, not Date


chore(main): release 9.8.1

:robot: I have created a release beep boop
9.8.1 (2024-11-16)
Bug Fixes

slash_commands: telescope selection (6184bd4)

This PR was generated with Release Please. See documentation.

:robot: Created releases:

v9.8.1
:sunflower:


Custom storage type for every table.

What problem does the new feature solve?
The GreptimeDB already supports storing data in the local file system, AWS S3 and Aliyun Oss, thanks to OpenDAL.
But this storage configuration is global. You can't have a table in the local file system and the other on S3.
I think we can make this configuration also present in table engine options. For example, you can create a table and specify its storage type:
create table monitor(CPU double, ts timestamp time index) with(regions=1, storage='S3');

If the SQL doesn't set the storage option, then using the global configuration.
What does the feature do?
Describe as above.
Implementation challenges
No response

@MichaelScofield
Is this also blocked as #1709?

@NiwakaDev I don't think this issue is blocked by any other features, it can be resolved independently.

@killme2008
This issue discussion already lands? If so, I'd like to work on this issue.

@NiwakaDev We haven't discussed it in detail yet, but the syntax is as expected in the issue description.
Feel free to try it, we think it's helpful for users.

@killme2008
Should we support this feature for file engine?: https://github.com/GreptimeTeam/greptimedb/blob/develop/src/datanode/src/datanode.rs#L487

@NiwakaDev Do you mean to create a file engine table with custom storage?
It's already supported, we can create a file engine table with file in s3, see https://docs.greptime.com/reference/sql/create#s3


[BUG] BlobClient cannot read blobs with # characters in name

Library name and version
Azure.Storage.Blobs 12.19.1
Describe the bug
The BlobClient incorrectly truncates blob file names if the name contains a # character.
Expected behavior
The following code should output:
example#test.json
example.json
Code:
using Azure.Identity;
using Azure.Storage.Blobs;

BlobClient blobClient1 = new(new Uri("https://example.blob.core.windows.net/example/exmple#test.json"), new DefaultAzureCredential());
Console.WriteLine(blobClient1.Name);

BlobClient blobClient2 = new(new Uri("https://example.blob.core.windows.net/example/exmple.json"), new DefaultAzureCredential());
Console.WriteLine(blobClient2.Name);

Actual behavior
The code outputs:
example
example.json
example#test.json is truncated at the # character.
Reproduction Steps

create a .net 8 console app
install Azure.Storage.Blobs (and Azure.Identity)
run this code:

using Azure.Identity;
using Azure.Storage.Blobs;

BlobClient blobClient1 = new(new Uri("https://example.blob.core.windows.net/example/example#test.json"), new DefaultAzureCredential());
Console.WriteLine(blobClient1.Name);

BlobClient blobClient2 = new(new Uri("https://example.blob.core.windows.net/example/example.json"), new DefaultAzureCredential());
Console.WriteLine(blobClient2.Name);

Environment
No response

Seems like this was fixed previously... is this a regression?
https://github.com/Azure/azure-sdk-for-net/issues/11602

Will be resolved by https://github.com/Azure/azure-sdk-for-net/pull/44941
after it releases with v12.21.0 of Azure.Storage.Blobs

@amnguye thanks!


Add Air Pollution

I decided to implement the air pollution data that I asked on #17 as it was pretty straightforward to add.
I can start working on adding to HA once this gets merged

Thanks for the review @freekode, it will be a couple of days until I have some time to address your comments

@freekode I've updated this PR addressing your comments. I made air_pollution_client.py a subclass of OWMClient(). Let me know if you don't like raising NotImplementedError() if someone for example calls get_weather() for the air pollution api. I thought it would be better than returning None, which could give the impression that something went wrong but was valid usage nonetheless.
Alternatively, we could rename get_weather() into something more generic like get_data() and then each subclass would only need to implement one function

LGTM Thanks

if you don't like raising NotImplementedError()
Yeah, I think this is much better than return None.

Alternatively, we could rename get_weather() into something more generic like get_data() and then each subclass would only need to implement one function
This is good idea. I even thought about to split it to get_current and get_forecast. So client can separate request for forecast.


Jhack is incompatible with juju 2 controllers

Jhack ships with a juju 3 client. As a result it can't use certain commands with juju 2 controllers:
juju status will work, but juju status --format=json will not.
This is the reason for #30

Workaround for SOME issues (juju ssh compatibility) is to use jhack from sources (not the snapped version).
Commands that rely on juju cli output may still break, as some of that output (format) is inconsistent between juju versions.


[Visibility] messes up callout height

How can we reproduce this bug?
Use a visibility class on hidden callout, when callout is shown, height will be incorrect.

What did you expect to happen?
Height be respected

@tdhartwick What have you tried so far? Can you update the issue?


[🐛 BUG] - {Unsupported browser warning}

Describe the bug
A warning that the current browser is not supported by Google Drive.
To Reproduce
Steps to reproduce the behavior:

Open app
Sign in
Error in the left bottom corner

Expected behavior
Nothing showing up.
Screenshots

G Desktop Suite:

Version [e.g. 0.2.1]

Platform:

OS: Windows, probably platform neutral tho.
Version: 0.3.1 (latest to 01/06/2020)

Additional context
Could be related to #71

@alexkim205 this is definitely something that needs to be tested and investigated haha
@filiptronicek See: https://github.com/alexkim205/G-Desktop-Suite/issues/25 for more details from our previous attempt at fixing this

Got the same on Linux machine (Ubuntu 18.04.4)

Same

Same on version 0.3.1 (Windows 10 Pro)

Same on Mac OS 11.0.1 (and G Suite 0.3.1)

I can"t login using google account.
Last week I was able to log in.
G-desktop-suite showed below message.
"Couldn't sign you in"
"This browser or app may not be secure. Learn more
Try using a different browser. If you’re already using a supported browser, you can refresh your screen and try again to sign in."


React UI: Figure out how to handle "Xs ago" duration displays

Some of the pages in the classic UI (like /targets and /rules) show durations in the format "3.45s ago". In the new React UI, we get only absolute timestamps of events from the server, so if we wanted to compute such a relative duration, we need a relative "now" timestamp to subtract them from. The current approach is to use the browser's current timestamp, but the user's clock might be totally off with regards to the server's. We could instead think about using the Date header that the Prometheus server returns on every API request, and which is at least precise to the second (although not lower).

@juliusv can I work on this issue?

@kimuraz Sure. First thing is to figure out what we want to do though. Via date header or some other way? I don't like any of the options, but maybe the Date header is the least bad?

@juliusv I did some research but so far I guess the Date header is the "least bad" option indeed, I guess it will guarantee that the calculation is correct since it will have the same reference. If that's the way, what is the Definition of Done for this issue? I mean, what should be delivered in this case?

@kimuraz Yes, I'm thinking the same. Another option would be to replace the "Xs ago" displays with absolute timestamps, but I feel that the relative displays are much more useful for the reader.
So I would say, go for the Date header option.

what is the Definition of Done for this issue? I mean, what should be delivered in this case?

A pull request that changes the existing React UI code to make available the Date header timestamp for relative time computations by the component that fetches data, and then use that on the /new/targets and /new/rules pages (the latter doesn't exist yet in the React UI). Currently the targets page uses a client-side now() timestamp as a reference, which would need to be replaced: https://github.com/prometheus/prometheus/blob/06b47447938a9017e7d1c2ad24df050fd61964df/web/ui/react-app/src/pages/targets/ScrapePoolPanel.tsx#L82


add read content method

This is what I was asking for in the comments

@MathieuAA btw are you following any specific coding style? coz I find your style bit different from normal node module style?

I won't merge it as I'm quite busy, I'll discuss my problems with the PR later today, please don't merge it.

ok

I looked into various pseudo-coding style guides when we started JHipster UML a long time ago, but there's nothing official and the provided information is not the same every time, so I follow my own (which I find quite good =p).
As for Node modules (code, tests, etc.) they always vary a lot (especially the tests, which is weird). So, again, I follow my own. But I tend to "respect" various coding habits (wrapping apps in (function () {})(); etc..).
We can't compare JHipster's coding style with other projects as JHipster is a Yeoman generator, and I guess it must follow some strange rules... For this project, I follow the same coding habits I usually follow when working on JHipster UML.

Not that I find it wrong or anything just that it can be bit more simpler since its javascript and not Java/C :P
Btw there are some official style guides like the npm one itself  https://docs.npmjs.com/misc/coding-style
Since this is javascript many folks actually follow this https://github.com/airbnb/javascript (this is something im slowly trying to adapt in Jhipster, but will take some time due to the large codebase, it has nothing on yeoman to blame btw :) since its a node module it can very well follow normal js style )
This node specific one is also quite popular https://github.com/felixge/node-style-guide

Sorry for the delay, quite a lot of work to do.
Concerning the "official" style guide from NPM, my code respects it... almost. Some rules are just plain contradictory or stupid (the semi-colons is something I'd like to see less often for instance, but I doubt every platform can support that).
I like the guide proposed by AirBnb, and I really wish you luck to push it more in the codebase so that others copy this style!
However, I don't fully agree with their coding rules either... Maybe because I don't understand how V8 does some of its voodoo :-).
For instance, the "Use a leading underscore _ when naming private properties" may be the ugliest thing I've read in the guide, and I won't ever respect this rule, even if I agree 99.99% with the rest of the doc.

As for the PR, there's no need to have a spec subfolder in the test folder, as mocha will find every .js test file... and spec is kinda redundant with test as I use chai/expect (logical matter, not important).
You were right when you renamed the samples' folder "samples".
The test file shouldn't be named index.js for these reasons:

One test subfolder can have more than one test;
The test files should be easy to recognize;
As one subfolder can have more than one test file, I dont like the idea of having all my tests in one file even if you can describe('MyClass', function...) more than once.

Ideally it should take all the js files but its not working at least in
windows, but that might have something to do with the command used in npm.
I dont like having samples and tests in the same level and spec is the most
common naming style for tests in the node world, if you want sub folders
have it inside the spec folder. Did you try running the tests earlier?  Did
they work?
About coding style, when you do a personal project its fine to do whatever
style as javascript is too flexible anyway. But in a collaborative project
you have to adapt to something that all can agree. Anyway we need to put an
.editorconfig and .eslint file.
I dont have much problems with your coding style except for the use of too
many error handling classes which is kind of un necessary in javascript.
On 22 Mar 2016 02:28, "Mathieu ABOU-AICHI"<EMAIL_ADDRESS>wrote:

Sorry for the delay, quite a lot of work to do.
Concerning the "official" style guide from NPM, my code respects it...
almost. Some rules are just plain contradictory or stupid (the semi-colons
is something I'd like to see less often for instance, but I doubt every
platform can support that).
I like the guide proposed by AirBnb, and I really wish you luck to push it
more in the codebase so that others copy this style!
However, I don't fully agree with their coding rules either... Maybe
because I don't understand how V8 does some of its voodoo :-).
For instance, the "Use a leading underscore _ when naming private
properties" may be the ugliest thing I've read in the guide, and I won't
ever respect this rule, even if I agree 99.99% with the rest of the doc.
As for the PR, there's no need to have a spec subfolder in the test
folder, as mocha will find every .js test file... and spec is kinda
redundant with test as I use chai/expect (logical matter, not important).
You were right when you renamed the samples' folder "samples".
The test file shouldn't be named index.js for these reasons:

One test subfolder can have more than one test;
The test files should be easy to recognize;
As one subfolder can have more than one test file, I dont like the
idea of having all my tests in one file even if you can describe('MyClass',
function...) more than once.

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/jhipster/jhipster-domain-language/pull/4#issuecomment-199414691

The point of having a lot of error classes is to return them to the user, or the calling code (and to help me debug without any problem)... But I have a new method for handling these, I just need to test it =).
Yes, the basic npm test works for my settings (see JHipster UML for example, tested in Windows and Linux distros). Does yours differ than the "normal" one is some way? I'll do some more tests tonight with different settings... Does the package.json recognize things listed as '**/*.js'?
And finally, yes. We all need to agree on some coding rules. Can you start a thread in the dev mailing list? It would be nice to know the habits of everyone so that we may decide. Thank you Deepu.

I have update test file names, do you have any more issues with this?

btw shouldnt the travis build be running npm test? currently it does just an npm install

Travis should know how to deal with a NPM package (I hope so anyway)...

Outch! You used const! It's a ES6 feature.

yes we need not support node x as Jhipster doesnt anyway

I meant node 0.x

See my first build =) it failed because of 2 or 3 versions that are way too old to use!

yes lets just support 4 onwards its waste of effort to support 0.x its too old

and we need to enable npm test on travis

It is enabled Deepu. Don't know what you are talking about. Check the output of your last build.
Let's not use any ES6 feature for now (even if I do want to use it myself). You should remove the const.

No Mathieu, I differ. This is a supporting lib for JHipster, we are already
using es6 in jhipster as node 4.x onwards supports it and we are
recommending node LTS so not using those to support older versions here
doesn't make sense to me.
On 23 Mar 2016 03:41, "Mathieu ABOU-AICHI"<EMAIL_ADDRESS>wrote:

Merged #4 https://github.com/jhipster/jhipster-domain-language/pull/4.
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/jhipster/jhipster-domain-language/pull/4#event-599259786

When you say "already using", does that mean you use things as const, let, etc.? I don't see where we disagree here though. Unless you answered to my original post, I've changed my mind since then =)

its ok nevermind its reflected in code
Thanks & Regards,
Deepu
On Wed, Mar 23, 2016 at 2:48 PM, Mathieu ABOU-AICHI <
<EMAIL_ADDRESS>wrote:

When you say "already using", does that mean you use things as const, let,
etc.? I don't see where we disagree here though. Unless you answered to my
original post, I've changed my mind since then =)
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/jhipster/jhipster-domain-language/pull/4#issuecomment-200209923


Tsachi/viper followup

This is a WIP, do not merge.

I'm closing this as https://github.com/stellar/soroban-tools/pull/652 provides much better solution.


WARN  Missing supabase ***, set it either in nuxt.config.js or via env variable

I am using @nuxtjs/supabase and this package expects the .env file in the project root directory to define SUPABASE_URL and SUPABASE_KEY.
However, since my project defines different environment variables for the production and staging environments, I put the respective .env files together in the env/ directory as a management method, and there is no .env file in the project root directory.
Therefore, I get the following warning.
WARN  Missing supabase url, set it either in nuxt.config.js or via env variable
WARN  Missing supabase anon key, set it either in nuxt.config.js or via env variable

It seems that you can define it in nuxt.config file, but I don't think you can define it in nuxt.config file because SUPABASE_URL and SUPABASE_KEY are different in each environment.
The use of @nuxtjs/supabase itself is working fine.
However, the warning points out that "the definitions of SUPABASE_URL and SUPABASE_KEY do not physically exist in the .env , file in the project root or in the nuxt.config file," and I don't think that resolving the environment variables to be loaded at run-time will fix the display.
What can I do to avoid the warning?

I am having the same warning, but with the variables in the .env file in the project root. They do not seem to be showing up. It seems like none of the env vars are coming through.

I have encountered the same problem, i've created the env file but the warning persiste.

Same. If I use .env.local file I get the 2 warns:
WARN  Missing supabase url, set it either in nuxt.config.js or via env variable
WARN  Missing supabase anon key, set it either in nuxt.config.js or via env variable
but if I use .env file warn about url disappears, but about anon key is still here:
WARN  Missing supabase anon key, set it either in nuxt.config.js or via env variable

You can try Doppler.

In our case, we generate the app once and use it for the production and staging environments.
The .env values are freezed at build time and we can't change them at deploy time (since it's only a static payload).
For other settings we use this workaround:
the deploy step injects a public/conf.json the app can fetch to get specific environments values.
But we did not find how to feed those values to nuxt/supabase instead of the env variables.

Apologies if I'm necroing this thread. For anyone who Googles this like I did - I found by surrounding the variables with double quotes and using a .env file instead of .env.local resolved on my end. My nuxt.config.ts file looks like this:
// https://nuxt.com/docs/api/configuration/nuxt-config
export default defineNuxtConfig({
  devtools: { enabled: true },
  modules: ["@nuxtjs/supabase"],
  supabase: {
    url: process.env.SUPABASE_URL,
    key: process.env.SUPABASE_KEY,
    redirect: false,
  }
})

I see, so I decided to give it a try.
I thought.... Now I see that there are no warnings already?
Maybe @nuxtjs/supabase has been improved somehow?

After hours of debugging i noticed my vscode wasnt on auto save, it was a secondary pc


Remove duplicate csv import in modules/csv/csv.go

Remove the unnecessary duplicate package import for encoding/csv in modules/csv/csv.go
Fix #16557

Codecov Report

Merging #16631 (432d48c) into main (19e2c6a) will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main   #16631   +/-   ##
=======================================
  Coverage   45.35%   45.35%
=======================================
  Files         750      750
  Lines       85115    85115
=======================================
+ Hits        38605    38606    +1
+ Misses      40264    40262    -2
- Partials     6246     6247    +1

Impacted Files
Coverage Δ

modules/csv/csv.go
75.92% <0.00%> (ø)

modules/util/timer.go
42.85% <0.00%> (-42.86%)
:arrow_down:

modules/log/event.go
60.64% <0.00%> (-1.86%)
:arrow_down:

routers/web/repo/view.go
41.52% <0.00%> (+0.57%)
:arrow_up:

modules/queue/workerpool.go
53.81% <0.00%> (+0.76%)
:arrow_up:

modules/git/blame.go
67.14% <0.00%> (+1.42%)
:arrow_up:

models/unit.go
43.83% <0.00%> (+2.73%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a1332c...432d48c. Read the comment docs.


Duplicate log of "Message User Properties"

Message User Properties - log message is duplicated!

Resolved in release 0.0.33


SOC_FLASH_LPC vs SOC_FLASH_MCUX

Describe the bug
Hey folks, seems like we have two drivers that can handle compatible = "nxp,lpc-iap":
https://github.com/zephyrproject-rtos/zephyr/blob/main/drivers/flash/soc_flash_mcux.c#L35
https://github.com/zephyrproject-rtos/zephyr/blob/main/drivers/flash/soc_flash_lpc.c#L21
These used to be enabled manually on few platforms but since https://github.com/zephyrproject-rtos/zephyr/pull/48154 we started enabling them based on the dt setting, which means that both gets enabled at the same time.
This is causing build failures in CI for patches touching those platforms, something like
/usr/local/google/home/fabiobaltieri/zephyrproject/modules/hal/nxp/mcux/mcux-sdk/drivers/flashiap/fsl_flashiap.h: In function 'iap_entry':
/usr/local/google/home/fabiobaltieri/zephyrproject/modules/hal/nxp/mcux/mcux-sdk/drivers/flashiap/fsl_flashiap.h:109:24: error: 'FSL_FEATURE_SYSCON_IAP_ENTRY_LOCATION' undeclared (first use in this function)
  109 |     ((FLASHIAP_ENTRY_T)FSL_FEATURE_SYSCON_IAP_ENTRY_LOCATION)(cmd_param, status_result);
      |                        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/local/google/home/fabiobaltieri/zephyrproject/modules/hal/nxp/mcux/mcux-sdk/drivers/flashiap/fsl_flashiap.h:109:24: note: each undeclared identifier is reported only once for each function it appears in
[7/20] Building C object zephyr/drivers/flash/CMakeFiles/drivers__flash.dir/soc_flash_lpc.c.obj

For SoCs that are missing that definition and should use the other driver.
I think that the solution would be to add some strategic depends on SOC_LPC... in https://github.com/zephyrproject-rtos/zephyr/blob/main/drivers/flash/Kconfig.lpc and https://github.com/zephyrproject-rtos/zephyr/blob/main/drivers/flash/Kconfig.mcux, though I'm not familiar enough with the families. Could you NXP folks look into it?

Impact
CI broken...
Logs and console output
$ ./scripts/twister -v -n -M -p lpcxpresso11u68 -p lpcxpresso51u68 -p lpcxpresso54114_m0 -p lpcxpresso54114_m4 -p lpcxpresso55s06 -p lpcxpresso55s16 -p lpcxpresso55s28 -p lpcxpresso55s36 -p lpcxpresso55s69_cpu0 -p lpcxpresso55s69_cpu1 -p lpcxpresso55s69_ns -T samples/drivers/flash_shell
Keeping artifacts untouched
INFO    - Using Ninja..
INFO    - Zephyr version: zephyr-v3.1.0-3590-g91e4ae35f7e9
INFO    - Using 'zephyr' toolchain.
INFO    - Building initial testsuite list...
INFO    - JOBS: 128
INFO    - 1 test scenarios (11 configurations) selected, 0 configurations discarded due to filters.
INFO    - Adding tasks to the queue...
INFO    - Added initial list of jobs to queue
INFO    -  1/11 lpcxpresso55s28           samples/drivers/flash_shell/sample.drivers.flash.shell FAILED Build failure (build)
ERROR   - see: /usr/local/google/home/fabiobaltieri/zephyrproject/zephyr/twister-out/lpcxpresso55s28/samples/drivers/flash_shell/sample.drivers.flash.shell/build.log
INFO    -  2/11 lpcxpresso11u68           samples/drivers/flash_shell/sample.drivers.flash.shell SKIPPED (runtime filter)
INFO    -  3/11 lpcxpresso55s36           samples/drivers/flash_shell/sample.drivers.flash.shell SKIPPED (runtime filter)
INFO    -  4/11 lpcxpresso51u68           samples/drivers/flash_shell/sample.drivers.flash.shell SKIPPED (runtime filter)
INFO    -  5/11 lpcxpresso54114_m4        samples/drivers/flash_shell/sample.drivers.flash.shell FAILED Build failure (build)
ERROR   - see: /usr/local/google/home/fabiobaltieri/zephyrproject/zephyr/twister-out/lpcxpresso54114_m4/samples/drivers/flash_shell/sample.drivers.flash.shell/build.log
INFO    -  6/11 lpcxpresso54114_m0        samples/drivers/flash_shell/sample.drivers.flash.shell FAILED Build failure (build)
ERROR   - see: /usr/local/google/home/fabiobaltieri/zephyrproject/zephyr/twister-out/lpcxpresso54114_m0/samples/drivers/flash_shell/sample.drivers.flash.shell/build.log
INFO    -  7/11 lpcxpresso55s69_cpu1      samples/drivers/flash_shell/sample.drivers.flash.shell FAILED Build failure (build)
ERROR   - see: /usr/local/google/home/fabiobaltieri/zephyrproject/zephyr/twister-out/lpcxpresso55s69_cpu1/samples/drivers/flash_shell/sample.drivers.flash.shell/build.log
INFO    -  8/11 lpcxpresso55s16           samples/drivers/flash_shell/sample.drivers.flash.shell FAILED Build failure (build)
ERROR   - see: /usr/local/google/home/fabiobaltieri/zephyrproject/zephyr/twister-out/lpcxpresso55s16/samples/drivers/flash_shell/sample.drivers.flash.shell/build.log
INFO    -  9/11 lpcxpresso55s06           samples/drivers/flash_shell/sample.drivers.flash.shell FAILED Build failure (build)
ERROR   - see: /usr/local/google/home/fabiobaltieri/zephyrproject/zephyr/twister-out/lpcxpresso55s06/samples/drivers/flash_shell/sample.drivers.flash.shell/build.log
INFO    - 10/11 lpcxpresso55s69_cpu0      samples/drivers/flash_shell/sample.drivers.flash.shell FAILED Build failure (build)
ERROR   - see: /usr/local/google/home/fabiobaltieri/zephyrproject/zephyr/twister-out/lpcxpresso55s69_cpu0/samples/drivers/flash_shell/sample.drivers.flash.shell/build.log
INFO    - 11/11 lpcxpresso55s69_ns        samples/drivers/flash_shell/sample.drivers.flash.shell FAILED Build failure (build)
ERROR   - see: /usr/local/google/home/fabiobaltieri/zephyrproject/zephyr/twister-out/lpcxpresso55s69_ns/samples/drivers/flash_shell/sample.drivers.flash.shell/build.log

Environment (please complete the following information):

OS: Linux
Toolchain: Zephyr SDK
Commit SHA: anything after a529c4511d (running on 6fc4bb9486248b2d2a9cc8eff505f365a4006ef1 right now)

cc @mmahadevan108

This has been fixed with #48832

Actually one of the tests is still failing:
$ ./scripts/twister -v -n -M -p lpcxpresso55s69_cpu1 -T samples/drivers/flash_shell <- this one
Looks like the cpu1 still enables SOC_FLASH_MCUX, but not HAS_MCUX_IAP (from https://github.com/zephyrproject-rtos/zephyr/blob/main/soc/arm/nxp_lpc/lpc55xxx/Kconfig.soc#L77).
Should there be a select HAS_MCUX_IAP under SOC_LPC55S69_CPU1? Happy to add a patch to the PR where I'm hitting this test if it helps.

Guess if cpu1 is not supposed to access the flash controller I can add a
+&iap {
+       status = "disabled";
+};

to lpcxpresso55s69_cpu1.dts, that would disable the flash driver and runtime skip the test.

cc @ yvanderv

Filed https://github.com/zephyrproject-rtos/zephyr/pull/49189 to propose disabling the iap node. Happy to change it if that's not the right thing to do.


Add tests for swapchain validation layer

The currest list of validation errors as well as any associated tests for the swapchain validation layer are documented in vk_validation_layer_details.md.
This documentation should be examined according to the existing validation code and the Vulkan specification and additional test(s) should be added as appropriate.

Just noticed this tracking issue.  I dealt with this a while back, but didn't close this issue.  There are some time-consuming tests that should be added sometime (I left TODO statements for what was needed).
Jon Ashburn also added some incomplete support for the VK_KHR_display extension.  It would be good for somebody to finish that support sometime.


Code for generating dataset

Please provide the code for generating datasets.

Hello, thank you for your interest in this work.
The code for generating datasets (MAGs) can be found here: https://github.com/dinobby/ReConcile
We randomly sample 1000 data points from each dataset's training set and run this code to collect MAGs.


updates around monitoring

Some suggestions from Alan -

Is it possible / of value to the community to add a section under the "Logging" section called "Splunk Analytics", that provides some of the example Splunk queries / reports we use for the monthly meetings?
Can we add a section to cross link / point to the XDMoD Integration section "https://osc.github.io/ood-documentation/develop/customizations.html#xdmod-integration"... although I think that currently focuses on just what shows up inside of OOD.  Maybe we need a few screenshots showing what types of info is available within the XDMoD interface  not from a individual user job level but more the system level stuff.
We previously utilized Nagios instead of Prometheus.  I assume there is some documentation still out there about that?  Lots of sites still utilize Nagios so if we have any docs it would be nice to include that too.

┆Issue is synchronized with this Asana task by Unito

Also be good to cross reference the XDMOD module to parse OnDemand usage logs: https://ondemand.xdmod.org/10.0/overview.html.  There is some tooling at OSC to make that process easier, most of it is here: https://github.com/treydock/puppet-module-xdmod/tree/master/templates/ondemand
WRT Nagios, that's actually a lot harder to document and be useful than Prometheus as Prometheus it's pretty easy to share alerts and configs with other sites but Nagios is configured so many different ways and the way OSC used it was kind of complicated and hard to follow.  The most we might have done was monitor that Apache was online , nothing really specific to OnDemand itself.


Create IBD exclusion chunk in preprocessing

Create a chunk that accounts for the exclusion of inflammatory bowel disease in National BioResource cohort. This is to make sure that we aren't oversampling for IBD in our sample.

alternatively sample according to IBD prevalence in UK population

What is the IBD prevalence in the UK population? -> Literature search

This chunk needs to be included when we have the data available from the NBR

https://pubmed.ncbi.nlm.nih.gov/32690524/
Point prevalence estimates on 31 December 2018 for IBD overall, CD and UC were 725, 276 and 397 per 100 000 people, respectively.

IBD 0.00725
CD 0.00276
UC 0.00397

I've written this chunk in the script. 3,410 NBR IBD participants were excluded. Made a note in the script as well. #44


Get image path from cache

A lot of people has request this feature (including me), so thanks to this PRs: https://github.com/DylanVann/react-native-fast-image/pull/351 by @compojoom and https://github.com/DylanVann/react-native-fast-image/pull/557 by @dolsem I managed to add a new static method getCachePath that is retrieving the local cached path of an image by image source.
This library is awesome and is working very well, so I think this kind of feature is needed for the situations when you need to make an offline-first app or need to pass the path of the images to other libraries (such as image galleries, image editors and so on)

@DylanVann I think this functionality adds a lot of value to the library and it would be nice if this PR could be merged.

@DylanVann Can you please look this over and merge? Or give perms to a contributor to do so? I believe this addresses the concerns you expressed about #351.

When will this PR be merged? Thanks

any update ? 🙏

This needs to be really added to the package because we use react-native-photo-editor in our project and in offline mode it needs the saved path of the image, and we don't want to download all the images again with another package to get just the local path when offline.

any updates?

@DylanVann why is this is not merged yet?

@DylanVann Any update? This is an amazing feature and it would be amazing to be merged already :)

Hey, don't want to rush anyone but please when will this be merged, this seems like a very important feature that will help everyone. Thanks.

@DylanVann

Can we merge this? Thanks

is there any chance to get this published?

Waiting this feature released.

Can this cat help you publish this feature?

Any day?..)

@alexandrumic  cant you create a patch file for us to use meanwhile?? Much helpful if done

@alexandrumic  cant you create a patch file for us to use meanwhile?? Much helpful if done

this is exactly importain update


Field Type Image wont show in the list

If the following field type is created, it will not be shown in the view list (Index view) and instead it is shown as an integer 1
["profile_image", "Profile Image", "Image", false, "img_path.jpg", 0, 250,  false],

Please check OrganizationsController for implementation.

I follow the OrganizationsController for implementation.
then added this into employee
show.blade -> @la_display($module, 'profile_image')
and
index.blade
@la_input($module, 'profile_image')
but it gives nothing.
help me.

Please Check Module and Module Field Permission for your Role.

Yes thanks.
It's working.


Add LosslessCut

Types of Changes
What types of changes does your PR introduce? Put an x in all boxes that apply

[x] New addition to list
[ ] Fixing bug in existing item in list
[ ] Removing item from list
[ ] Changing structure (organization) of list

Proposed Changes
LosslessCut is a tool used by many people for super fast rough processing of videos from cameras, drones etc
Guidelines say alphabetical so I added it accordingly, even though order is chaotic there.
PR Checklist
Put an x in the boxes once you've completed each step. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[x] I have read the CONTRIBUTING guide
[x] I have explained why this PR is important
[x] I have added necessary documentation (if appropriate)

Further Comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

Looks good to me. We should do an alphabetization of that section at some point. Opening an issue and merging this.


Billing process

Once per months  (parameter) at 00:00 declarations state and released info should be saved in form of Capitation report.
Info should be provided:

[ ] Age Group
[ ] Compensation Group - TBD
[ ] Mountain Group

Billing table contain:

id
billing date
declaration id
MSP id
red MSP id
mountain group (calculate by address in declaration)
age group (choose one of the groupe 0-5 років, 6-17 років, 18-39 років, 40-64 років, 65 років і старші)

The table contains only the first declaration of the patient, that has red_msp_id
Add connection between red_list table and billing table in specs

How I can test this reports?
Provide please url for push request.

Waiting for deploy.

ok


how to align comments at the end of lines?

Expect this:
var a = 1;   // comment1
var bb = 22; // comment2

But got this:
var a = 1; // comment1
var bb = 22; // comment2

This issue is currently wrecking the formatting on a bunch of code I wrote awhile ago, but am now just trying to use in an environment that uses js-beautify.  Has anything ever happened with this?  Why would any formatter automatically strip all whitespace before comments?  Is there a setting to control this?  If not, I don't think I can continue to use js-beautify.

This issue is currently wrecking the formatting on a bunch of code I wrote awhile ago, but am now just trying to use in an environment that uses js-beautify.  Has anything ever happened with this?  Why would any formatter automatically strip all whitespace before comments?  Is there a setting to control this?  If not, I don't think I can continue to use js-beautify.

@jfriend00

This issue is currently wrecking the formatting on a bunch of code I wrote awhile ago, but am now just trying to use in an environment that uses js-beautify. Has anything ever happened with this? Why would any formatter automatically strip all whitespace before comments?

As you may have noticed from https://github.com/prettier/prettier/issues/10068 this not uncommon.

If not, I don't think I can continue to use js-beautify.

That is unfortunate but unavoidable. I hope you'll take this experience and reflect on how you might get more traction on issues that matter to you by asking nicely and offering to contribute.  Contributors and maintainers of projects like this are volunteers.  Comments consisting purely of pointed remarks about the quality/design/implementation of project are particularly ineffective since they make people less interested in working with you.

@jfriend00

This issue is currently wrecking the formatting on a bunch of code I wrote awhile ago, but am now just trying to use in an environment that uses js-beautify. Has anything ever happened with this? Why would any formatter automatically strip all whitespace before comments?

As you may have noticed from https://github.com/prettier/prettier/issues/10068 this not uncommon.

If not, I don't think I can continue to use js-beautify.

That is unfortunate but unavoidable. I hope you'll take this experience and reflect on how you might get more traction on issues that matter to you by asking nicely and offering to contribute.  Contributors and maintainers of projects like this are volunteers.  Comments consisting purely of pointed remarks about the quality/design/implementation of project are particularly ineffective since they make people less interested in working with you.

That is unfortunate but unavoidable.

Why is it unavoidable?  Nobody believes there's any algorithm that could do better?

That is unfortunate but unavoidable.

Why is it unavoidable?  Nobody believes there's any algorithm that could do better?

If not, I don't think I can continue to use js-beautify.

That is unfortunate but unavoidable.

Why is it unavoidable? Nobody believes there's any algorithm that could do better?

Of course not.  The problem isn't finding an algorithm.  The problem is finding a person with the time and inclination to design, implement, test, and document this feature.  I gathered from your statements that you expect that person to be someone other than you.  That seems very unlikely, thus "unfortunate but  unavoidable".
If I was wrong and you are interested in doing this work, I suggest you start by reading the CONTRIBUTING.md and try building the project locally.  If you have questions along the way.  Please come to the gitter.im channel for the project.

If not, I don't think I can continue to use js-beautify.

That is unfortunate but unavoidable.

Why is it unavoidable? Nobody believes there's any algorithm that could do better?

Of course not.  The problem isn't finding an algorithm.  The problem is finding a person with the time and inclination to design, implement, test, and document this feature.  I gathered from your statements that you expect that person to be someone other than you.  That seems very unlikely, thus "unfortunate but  unavoidable".
If I was wrong and you are interested in doing this work, I suggest you start by reading the CONTRIBUTING.md and try building the project locally.  If you have questions along the way.  Please come to the gitter.im channel for the project.

In case it helps anyone, you can accomplish something similar by using spaces inside your comments.
var a = 1; //    comment1
var bb = 22; //  comment2


flowr should default to noTransactionAnimation

Currently, flowr provides entry and exit custom transitions by default which causes us to use noTransactionAnimation() a lot. Instead we could switch the default behaviour. Thoughts @husseinala?

@esoxjem you actually don't need to use noTransactionAnimation() if you haven't provided default enter/exit animations by extending Flowr and overriding any of these methods getDefaultEnterAnimation(), getDefaultExitAnimation(), getDefaultPopEnterAnimation(), or getDefaultPopExitAnimation().

@ragdroid @chetdeva @initishbhatt looks it defaults to no animation 🤔 We don't need to add it. Good to close?

Yes 👍


Somn: Warning Messages for Stereochemistry and Heavy Atoms

Warning messages upon Somn SMILES input validation for molecules containing stereochemistry (dashes etc.) or heavy atoms (more than 150 atoms etc.)

Stereochemistry

See the following Slack link for David's initial pybel code for this: https://moleculemakerlabinst.slack.com/archives/C064A6PR01M/p1724949118827219
Link for Figma designs: https://www.figma.com/design/XMOJNiIiIK7Q8zdRIWBFE5?node-id=1956-26304#930837523

Heavy atoms (greater than 150 atoms)

See the following Slack link for David's initial pybel code for this: https://moleculemakerlabinst.slack.com/archives/C064A6PR01M/p1727891243631019
Link for Figma designs: https://www.figma.com/design/XMOJNiIiIK7Q8zdRIWBFE5?node-id=2000-26785#959605189

Hi David, thank you for creating this issue! Will take a look next week or Friday if have time

Sounds good, thanks Bingji! Let me know here or in Slack if you have any questions on it.

Hi David, please let me know if this issue still persists with openbabel parsing cdxml? This might be covered before but i'd like to double check to make sure if I use the right tool

@ckouder, this is a good point! The openbabel code should work for this, we just have to double check that it doesn't leave any "open valences" (which would show up as two extraneous dots over an atom in the image), and that the Hs get properly added with .addHs() and the pull request mentioned in the issue that you shared above.

this is blocked on https://github.com/moleculemaker/mmli-backend/issues/63 - other parts are under review


gen_mmu_x86: fix overlapping region detection

Fixes: #13515
Signed-off-by: Andrew Boie<EMAIL_ADDRESS>

Q: do you care if the (addr, end_addr) is within (other_addr, other_end_addr)? or "other" within "addr"?

Codecov Report

Merging #13590 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #13590   +/-   ##
=======================================
  Coverage   52.45%   52.45%
=======================================
  Files         322      322
  Lines       46592    46592
  Branches    10768    10768
=======================================
  Hits        24442    24442
  Misses      17247    17247
  Partials     4903     4903

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 707e229...ad98aaa. Read the comment docs.

Q: do you care if the (addr, end_addr) is within (other_addr, other_end_addr)? or "other" within "addr"?

We do, that case should be covered though.


Update thanks.json w/ kennethreitz info

Hey @kennethreitz! Thanks for this. I ended up adding yours separate from the PR. The commit is there, but it doesn't seem to register the PR being finished, so I'm going to close it.


Cache write behind - Redis Live Object Service.

Hi Guys,
Would there be support on having a cache write behind listener for the RLO service as we have it for RMap ? This is for the use case , if I have Java POJO as a REntity and I have persisted the REntity Object using RLO service . As a result of that , I want to a cache write behind functionality to persist the entity in MySQL.
Regards,
Harish

Hi  @mrniko ,
Thanks for acknowledging as a feature change . Would there be an ETA for this ?
Regards,
Harish


Bump expecto to 5.1.1

The current adapter only works up to 5.1.0 as https://github.com/haf/expecto/commit/d145a43ad753bc48ef5b3e3f34130966a210a0ab changed the signature of ExpectoConfig by adding allowDuplicateNames which result in:
System.MissingMethodException: Method not found: 'Void ExpectoConfig..ctor(Boolean, Int32, Microsoft.FSharp.Core.FSharpOption`1<System.TimeSpan>, System.TimeSpan, Double, Boolean, Microsoft.FSharp.Core.FSharpFunc`2<Expecto.Test,Expecto.Test>, TestPrinters, Expecto.Logging.LogLevel, Microsoft.FSharp.Core.FSharpFunc`2<Expecto.TestCode,Expecto.SourceLocation>, Int32, Int32, Microsoft.FSharp.Core.FSharpOption`1<Int32>, Boolean)'.

(there are now 2 Boolean at the end)

@davidtme Thanks!


UAR-1325 Remove navigate to company authentication page

JIRA link
https://companieshouse.atlassian.net/browse/UAR-1325
Change description
Changes in two places

remove check in the company authentication middleware function
remove check on post function of the previous entity details page

Work checklist

[x] Tests added where applicable
[ ] UI changes meet accessibility criteria

Merge instructions
We are committed to keeping commit history clean, consistent and linear.  A BREAKING CHANGE can be part of commits of any type,
types other than fix: and feat: are allowed, for example build:, chore:, ci:, docs:, style:, refactor:, perf:, test:, and others,
footers other than BREAKING CHANGE: <description> may be provided.

Changes looking good @mattch1 but I think you need to get AC1 and AC2 removed from the story.
Also, AC5 Then clause mentions a new tab but no new tab is actually opened, so suggest getting this changed too.


feat: tab completion for everything

Hi, my suggestion is to improve or add another configuration for "editor.tabCompletion": true, to complete everything not only snippets.
As an example:

I disable quick suggestions with "editor.quickSuggestions": false,
I enable tab completion with "editor.tabCompletion": true,
I open a JS file and write const comp = 'my component';
I write if (co and when I press tab it will complete to comp automatically

Why?
I feel quick suggestions are too noisy and if you want to disable them in some situations you still are triggering it with CTRL + SPACE, but it can be avoided if I have the ability to complete by pressing TAB.
I don't know if I formed it correctly, but my suggestion is to just simply pick first suggestion which matches with TAB instead of triggering quick suggestion and doing the same thing.

Also, about configuration instead of creating new one or by letting the user decide what they want it can be changed to a string like this:
For snippets: snippets | onlySnippets
For words: code | words | onlyCode | onlyWords
For everything: all | true
For disable: none | off | false
My opinion best would be: editor.tabCompletion: ['snippets', 'words', 'all', 'off']
And to keep default as it was it can be default to snippets

I hidded quick suggestions widget in Developer Tools to show you how it looks like to complete code with TAB.

If there's no such suggestion it simply uses TAB as default (space defined in User Settings).
If it's already completed it uses TAB as default (space defined in User Settings).
If it wasn't completed but it matches the same word for e.g. IS_DEVELOPMENT it uses TAB as default (space defined in User Settings).

@jrieken I tried to create this feature as a extension, but I couldn’t get suggestions list by string. I didn’t find any API in ‘vscode.languages’, maybe I was doing something wrong? Or it’s impossible to create such thing as a extension? Maybe it should go as a extension instead of in vscode core?
Thanks!

It is tricky... There are API commands which allows you trigger other completion providers.

This could also be useful for providing auto-completion for some spelling extensions.

If you wanna make a PR, please go ahead. It's not trivial but should be manageable. You should start by adding a command that triggers and accept a completions. For that add a new method like, similar to SuggestController#trigger.
Basically what you want is

trigger suggest from the controller (new function like trigger) in a way that prevents the widget from showing (add some kind of flag to trigger and the "did suggest"-event)
locally (in that function) wait for the "did suggest"-even, check for the best completion item, and if there is one invoke the _onDidSelectItem method

I might have missed some critical details but in essence that's all it takes and how the data flows.

@jrieken thank you very much, I will try to do it.
P.S. Your links are broken 😢

fixed the links above

@svipben Just fyi that #28215 might actually happen this month. I took another look and I have hacked something together and works reasonable well...

@jrieken Very good, I'm really happy, so then we can close this issue. Maybe you can show gif how it looks, I'm really curious 😄

@svipben see https://github.com/Microsoft/vscode/issues/28215#issuecomment-422310232


python310Packages.awscrt: 0.14.0 -> 0.14.3

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python310Packages.awscrt is: "Python bindings for the AWS Common Runtime"
meta.homepage for python310Packages.awscrt is: "https://github.com/awslabs/aws-crt-python"
meta.changelog for python310Packages.awscrt is: ""
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.14.3 with grep in /nix/store/wxnbscc14yh5x85a8xgfsdrhhcn1a3ak-python3.10-awscrt-0.14.3
found 0.14.3 in filename of file in /nix/store/wxnbscc14yh5x85a8xgfsdrhhcn1a3ak-python3.10-awscrt-0.14.3

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath
python310Packages.awscrt
python39Packages.awscrt

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/wxnbscc14yh5x85a8xgfsdrhhcn1a3ak-python3.10-awscrt-0.14.3 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python310Packages.awscrt https://github.com/r-ryantm/nixpkgs/archive/90c688a3ae16904388ed8038a8362ea2cc5d1a50.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/wxnbscc14yh5x85a8xgfsdrhhcn1a3ak-python3.10-awscrt-0.14.3
ls -la /nix/store/wxnbscc14yh5x85a8xgfsdrhhcn1a3ak-python3.10-awscrt-0.14.3/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

2 packages built:

python310Packages.awscrt
python39Packages.awscrt

Maintainer pings
cc @davegallant for testing.

Result of nixpkgs-review pr 188963 run on x86_64-linux 1

2 packages built:

python310Packages.awscrt
python39Packages.awscrt


feat: added duckduckgo search

simple duckduckgo search using the langchain tool, some refactoring to separate search-engine-specific code

If browse still works: https://github.com/abcsys/libem/blob/main/examples/browse.py, let's make duckduckgo the default?

browse.py works and duckduckgo is the default.

Nice!


Switch from Maven to Gradle

We're currently using Maven to build the project. Maven uses tedious XML. As we're getting quite used to Groovy, perhaps we should switch to using Gradle, which is just using another Groovy DSL?

Added a gradle branch that has completed this conversion.