Support for promotion API

Frodo-lib (and frodo-cli) should expose operations needed to handle promotions for Cloud Identity.
Is it already in the roadmap ?

@vscheuber, I will soon start working on integrating Lock/Unlock and Promotion API in frodo-lib.
I will be able to contribute back this evolutions.
Do you already have some ideas about how these API should be integrated ?

#289 is part of the solution to this.

#289 is part of the solution to this.

Yes, I did the same on my fork : https://github.com/frederic-luce/frodo-lib/blob/feature/promotion-api/src/ops/AuthenticateOps.ts#L47

@frederic-luce - I'm having to build a call to promotions outside of FRODO for now. One thing to note is that we really need two commands here.

Pull a promotion up to this environment from the one below
Check the lower environment for pending promotions

We probably don't want our pipeline to go to the effort of locking a FRIC environment to try a promotion when there's nothing to do. For full automated deployments, checking the lower environment with:
curl 'https://openam-customer-euw2-dev.id.forgerock.io/environment/promotion/report/provisional' \
 -H 'accept: application/json, text/plain, */*' \
 -H 'accept-api-version: protocol=1.0,resource=1.0' \
 -H 'authorization: Bearer ACCESS_TOKEN' \
 --compressed

is a good idea first - this will return a report with the changes in, or a report with empty arrays of changes, if there's nothing to do.

@ashleyfrieze, yes I have this step in my CI job. I still don't know if I really need to do a dry-run promotion before the real one. Is the provisional report enough ?

@frederic-luce - I think you can probably trust the provisional report. When you say you have it in your CI job, are you implementing it in FRODO for your CI job to use? Or are you running some scripts outside of FRODO?
I'm pitching some changes to FRODO to help, but we're building things FRODO can't do outside of FRODO in the hope that when we've got them working, we can get them added back in.
The hard part is probably the waiting loops and watching the state of promotion. Your pipeline may discover a half-finished lock/promotion and have to recover.
How are you getting on? Can I help?

I use frodo-lib but it's outside of frodo-cli.
I will use some kind of mutex in the pipeline to simplify the cases, but I think we can check the promotionId before each step to verify if it's the same as in our own lock call. If not, I will failed the whole pipeline.

@frederic-luce  - yeah we're using FrodoLib too. We've built a driver app that works better for us than frodo cli.
My concern is that a failed pipeline may leave the environment locked and we'd either need to use the UI to unlock it, or build resilience into deployment jobs.
If the environment is locked, then either try a promotion, or try to unlock it. Likewise, if there's a promotion running, then wait for it, rather than start a new one.
Jobs work great until they don't.... :)


Apply Python syntax highlighting to README.md

The title says it all.

Thanks for PR, seems I just committed this separately.


Don't try to store an empty result

When an agent fails (for example: llama_generate: error: prompt is too long (2215 tokens, max 1996)), it returns no result. This PR ensures that a call to store_result doesn't raise an exception when result is empty.
So, it fixes the exception below (but doesn't fix the "prompt too long" error that occurs before):
llama_generate: error: prompt is too long (2215 tokens, max 1996)
Exception in thread Thread-2:
Traceback (most recent call last):
  File "/usr/lib/python3.9/threading.py", line 954, in _bootstrap_inner
    self.run()
  File "/usr/lib/python3.9/threading.py", line 892, in run
    self._target(*self._args, **self._kwargs)
  File "~/agent-llm/AgentLLM.py", line 282, in run_task
    task = self.execute_next_task()
  File "~/agent-llm/AgentLLM.py", line 254, in execute_next_task
    self.response = self.execution_agent(self.primary_objective, this_task_name, this_task_id)
  File "~/agent-llm/AgentLLM.py", line 221, in execution_agent
    self.response = self.run(prompt)
  File "~/agent-llm/AgentLLM.py", line 73, in run
    self.store_result(task, self.response)
  File "~/agent-llm/AgentLLM.py", line 110, in store_result
    self.collection.add(ids=result_id, documents=result, metadatas={"task": task_name, "result": result})
  File "~/agent-llm/.venv/lib/python3.9/site-packages/chromadb/api/models/Collection.py", line 89, in add
    raise ValueError("You must provide either embeddings or documents, or both")
ValueError: You must provide either embeddings or documents, or both

Thanks again for the contributions!


Call stopRunning on captureSession when freeing

Currently, the green light (on a Mac) indicating the camera is in use never goes off, even after closing the videoTrack. I think stopRunning should be called on the captureSession when the videoTrack is closed. This patch seems to work for me:
diff --git a/pkg/avfoundation/AVFoundationBind/AVFoundationBind.m b/pkg/avfoundation/AVFoundationBind/AVFoundationBind.m
index ed75c99..db8f838 100644
--- a/pkg/avfoundation/AVFoundationBind/AVFoundationBind.m
+++ b/pkg/avfoundation/AVFoundationBind/AVFoundationBind.m
@@ -236,6 +236,7 @@ STATUS AVBindSessionFree(PAVBindSession *ppSession) {
     CHK(ppSession != NULL, STATUS_NULL_ARG);
     PAVBindSession pSession = *ppSession;
     if (pSession->refCaptureSession != NULL) {
+        [pSession->refCaptureSession stopRunning];
         [pSession->refCaptureSession release];
         pSession->refCaptureSession = NULL;
     }

or maybe call AVBindSessionClose instead?

Do you still experience this ? I have tested it and the green light stops when I close the video track.
Do you have an example that triggers the bug for you ?


ansel: remove hardcoded paths in desktop file

Description of changes
Fixes #326676.
Related to #308324

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Absolute paths are not ideal but the project also incorrectly concatenates paths, which should be fixed upstream.


porting some improvements from the cg2 branch

I'm porting some improvements non-cg-specific improvements made on the jcr/cg2 branch over here.

@kpamnany I'm going to remove vp and elbo_vars from ea in a subsequent PR.


Drop pytest-mock and use std python mock

excessive dependence on pytest-mock. Python stdlib has a library called unittest.mock which is used by pytest-mock and wrapped in a mocker. I think, I think, xta dependency in fact does not add anything new for mock testing. sometimes you want to make additional fixtures based on unittest.mock, but this will divide our tests into 2 ways to create mocks. otherwise, you need to use a mocker - and other than wrapping it in the standard library, it doesn’t do anything useful. I do not deny, of course, the fact that this library allows you to use advanced mock testing, but this library uses basic functionality. So what is the main motivation behind this problem? I just want to reduce the dependency deprivation and make the code more specific in the future.
Pytest-mock based on package mock.

simple exmple
async def test_inflight_batches_creation(self, mocker, event_loop, autobatching, cluster):
        inflight_batches_class = mocker.patch("emcache.autobatching._InflightBatches")

@pytest.fixture
def inflight_batches_class(self):
    with patch("emcache.autobatching._InflightBatches") as _InflightBatches:
        yield _InflightBatches

async def test_inflight_batches_creation(self, event_loop, autobatching, cluster, inflight_batches_class):

This reason is really significant https://stackoverflow.com/questions/77654858/pytest-mock-and-unittest-mock

Well, apparently this is not a problem but a choice of the developer. I even agree to some extent. There is definitely convenience.


Profiling output

It would be useful to output some numbers for CPU time, GPU time, and total time per frame. That would ease up the comparison to pathfinder. cc @nical


Programmatically set URL for reset button

The URL for the reset button is currently hardwired into the variations_table.html template. It should be instead constructed programmatically, at least by reference to constants.VARTABLE_BASE_URL ("/node/"). Perhaps add another constants that builds upon that to add "0/0" (and see where else should reference that).

Closed as out of scope for this repository.


pogu.live

Can I already download from there? It have weird format.

https://twitch-cors.herokuapp.com/https://dgeft87wbj63p.cloudfront.net/e8db2e8ad71f97ba28c0_aziegodx_42695735580_1626781922/chunked/641.ts
found this on console

Please use and follow the template for site support request.
You can see the template while you're signed in to github and click 'New issue' button.


Update jnats to 2.16.7

Updates io.nats:jnats from 2.16.5 to 2.16.7.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "io.nats", artifactId = "jnats" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "io.nats", artifactId = "jnats" }
}]

labels: library-update, early-semver-patch, semver-spec-patch, commit-count:1

Superseded by #30.


New version of broccoli-babel-transpiler breaks live reloading in ember cli

I noticed that a fresh install of ember-cli no longer correctly re-compiles on file change. I have tracked this down to a change in broccoli-babel-transpiler. It appears that the change from<EMAIL_ADDRESS>to<EMAIL_ADDRESS>is the problem. Reverting to<EMAIL_ADDRESS>fixes my issues.

Strange. Will take a look after lunch

Any progress on this one?

I was unable to reproduce. Can someone provide a repo that demonstrates this?

this seems to have gone stale, if someone can provide a reproduction I will take a look and reopen.


Improve logging experience when transient failures happen in AMQP

There are transient errors that happen in AMQP which are later recovered from in the library. These errors are propagated back to the user as warnings which may give them the impression that the library failed.

Duplicate of #3531 3531

Parented by #20836


Fix the broken link for issues under CONTRIBUTING.md file

Fix the broken link [1] for opening new issue in the CONTRIBUTING.md [2]
[1] https://github.com/epam/DLab/issues
[2] "https://github.com/apache/incubator-dlab/blob/master/CONTRIBUTING.md"

Opened a PR [1]
[1] https://github.com/apache/incubator-dlab/pull/846


App compat issues on MSDN and not in GitHub

@twsouthwick  @mjrousos
The 8 app compat issues that are documented on MSDN but not on GitHub

Hi @rpetrusha, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

It looks like you're a Microsoft contributor (Ron Petrusha). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

@twsouthwick The doc IDs have evidently been flagged as invalid, but I don't see any conflict with IDs, nor do I think that these are incorrectly formatted. Help!!!

@rpetrusha I looked at the Details for the failures and it is failing because there is no class with the method: System.Security.Cryptography.VerifyHash.  Did you mean "System.Security.Cryptography.RSA.VerifyHash"?

Closing; will open a new PR from a branch of master.


Release?

Could you provide a compiled release?
People are asking for it (https://r4p3.net/threads/release-text-formatting-application.480/post-50926)

I'll look into it this evening. I didn't manage to compile it on windows last time I tried so there may only be a linux version. :)

Atleast something to start :) I can try to provide a windows release for you

So I've rewritten it as a web application since I don't see any reason it should be a compiled binary:
https://robinleander.com/stylize/
For now it only supports the rainbow mode and doesn't do any attempts at compressing the text.
You can fork and pull request or I can add you as a contributor if you feel like adding to it!


Provide a non-commit-marking dispatch

For bulk-importing / high-load I find the call to MarkAsDispatched significantly slows commits down even when using a 'fast' database (e.g. MongoDB). It can be the difference between 16-17k per second and 4-5k per second.
I think having an option to dispatch commits without marking them as dispatched would be useful (maybe doing the marking in a batch or at the end of a run).
Perhaps a base dispatch class can be decorated with a class to do the marking (if required) and these used by either the Synchronous or Asynchronous scheduler?
I'd welcome any opinions on it first.

One of the reasons that I haven't touched this project in a couple of months is that I've been looking at asynchronous, non-blcoking workflows (like node.js, etc.).  The one trouble with this is the current model of the EventStore, it's definitely a "blocking" model, at least, the mechanism to talk to the various engines is.  This particular issue that you've raised cuts right to the heart of that.  Perhaps we should have some more in-depth conversations via email and/or Skype to figure out how to migrate to an async model.

Yes, I did end up adding something to the MongoDB provider to do this on a
separate thread which keeps the commit performance high without forgoing
the stream-head and dispatched-flag updates but this is probably something
that should live at a higher level than a single provider (although
dedicating a db connection for these tasks does seem to particularly help
it).
See:
https://github.com/CaptainCodeman/EventStore/commit/0de180cd380203a5acb4fcc45b7b8999050e4958
It'd be good to chat ... I've also been working on some async stuff but
more from the aggregate root / common domain angle and this is where I got
most of the perf gains.
On Tue, Jan 31, 2012 at 7:00 AM, Jonathan Oliver <
<EMAIL_ADDRESS>
wrote:

One of the reasons that I haven't touched this project in a couple of
months is that I've been looking at asynchronous, non-blcoking workflows
(like node.js, etc.).  The one trouble with this is the current model of
the EventStore, it's definitely a "blocking" model, at least, the mechanism
to talk to the various engines is.  This particular issue that you've
raised cuts right to the heart of that.  Perhaps we should have some more
in-depth conversations via email and/or Skype to figure out how to migrate
to an async model.

Reply to this email directly or view it on GitHub:
https://github.com/joliver/EventStore/issues/97#issuecomment-3739359

--

Simon Green


[BE] add setting to disable notification history

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@7474d28). Click here to learn what that means.
The diff coverage is 100%.

@@            Coverage Diff            @@
##             master      #27   +/-   ##
=========================================
  Coverage          ?   83.86%
=========================================
  Files             ?       34
  Lines             ?     1184
  Branches          ?        0
=========================================
  Hits              ?      993
  Misses            ?      191
  Partials          ?        0

Impacted Files
Coverage Δ

universal_notifications/notifications.py
94.68% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7474d28...2fc8e81. Read the comment docs.


The “room” plugin is not working. Can you please help me with this issue?

I have compiled the “room” plugin as instructed in the manual and placed it in the plugins directory. However, despite following the configuration steps outlined in the manual, the plugin does not seem to be functioning correctly. I am using a Mac with an M1 chip and macOS version 13.5.1. Could you please assist me in troubleshooting this problem?

What version of zellij are you using?

The zellij version is 0.37.2

@darkhucx in that case you must eat that use the previous commit or update zellij. Let me know if the problem doesn't resolve in either case.

I upgraded to version 0.38.1, but it seems like the issue persists. When I press the Ctrl+y key, Zellij program exits directly

Hm I had that issue you're describing but it went away as soon as I updated zellij.

Here I was facing the same problem with both Room and Harpoon, but when I remove the 0.37.2 version and install 0.38.1 from Cargo. It's all working now, except Monocle.

@rvcas ,@carlosonrails , The issue has been resolved as it was caused by the installation of Cargo using Homebrew. After removing Cargo and installing it manually, I compiled Room again, and the problem was resolved. I appreciate both of your assistance.


fix(taskscheduler): label sharded tasks with numbers instead of letters

Letters run into a problem with a maximum of 26.
See #2042

Closed via e599cf301d1ff0fe705b2362fa6b4b17859ab8da


/clients - Sort and filter by all columns

Related: #5624

Related: #5624

When you say "all columns" does that include status?

Nah I think we can cover that case with a toggle button


Query iterator per feed range

Is your feature request related to a problem? Please describe.
With the v2 sdk we could pass the PartitionKeyRangeId in the FeedOptions when querying (CreateDocumentQuery).
We used this feature to create a web api that would allow clients to read data (backed by a query) in parallel by first reading the shards (partition key ranges) and then executing an iterator per shard (partition key range).
This doesn't seem to be possible with the v3 sdk.
Describe the solution you'd like
We would like the ability to specify a feed range when querying so that the iterator only returns results from the specified range.
The internal property FeedRange on QueryRequestOptions might already cover this functionality in part.
Describe alternatives you've considered
Parallel execution is supported by the sdk, but this doesn't work for remote clients that use our web api without having direct access to Cosmos DB.
The change feed pull model does support this with e.g. ChangeFeedStartFrom.Beginning(range), but we need a filtered data set, instead of all data.
Additional context
I cooked up something to get us started. Hopefully it clarifies what we're trying to do:
    public static class ContainerExtensions
    {
        /// <summary>
        ///  This method creates a query for items under a container in an Azure Cosmos database using a SQL statement with parameterized values.
        ///  For more information on preparing SQL statements with parameterized values, please see <see cref="QueryDefinition"/>.
        /// </summary>
        /// <param name="container">The container to create the query for.</param>
        /// <param name="queryText">The Cosmos SQL query text.</param>
        /// <param name="continuationToken">(Optional) The continuation token in the Azure Cosmos DB service.</param>
        /// <param name="requestOptions">(Optional) The options for the item query request.</param>
        /// <param name="feedRange">(Optional) Feed range to limit query to.</param>
        /// <returns>An iterator to go through the items.</returns>

        public static FeedIterator<T> GetItemQueryIterator<T>(this Container container,
            QueryDefinition queryDefinition, string continuationToken = null, QueryRequestOptions requestOptions = null,
            FeedRange feedRange = null)
        {
            if (feedRange != null)
            {
                // If we need to start at the beginning, create an empty continuation token for a specific range.
                if (continuationToken == null)
                    continuationToken = SingleRangeFeedIterator<T>.CreateBeginningOfRangeContinuationToken(feedRange);

                return new SingleRangeFeedIterator<T>(
                    container.GetItemQueryIterator<T>(queryDefinition, continuationToken, requestOptions),
                    feedRange,
                    continuationToken
                );
            }

            return container.GetItemQueryIterator<T>(queryDefinition, continuationToken, requestOptions);
        }

        /// <summary>
        ///  This method creates a query for items under a container in an Azure Cosmos database using a SQL statement with parameterized values.
        ///  For more information on preparing SQL statements with parameterized values, please see <see cref="QueryDefinition"/>.
        /// </summary>
        /// <param name="container">The container to create the query for.</param>
        /// <param name="feedRange">The single feed range to query items in.</param>
        /// <param name="queryText">The Cosmos SQL query text.</param>
        /// <param name="continuationToken">(Optional) The continuation token in the Azure Cosmos DB service.</param>
        /// <param name="requestOptions">(Optional) The options for the item query request.</param>
        /// <param name="feedRange">(Optional) Feed range to limit query to.</param>
        /// <returns>An iterator to go through the items.</returns>
        public static FeedIterator<T> GetItemQueryIterator<T>(this Container container,
            string queryText = null, string continuationToken = null, QueryRequestOptions requestOptions = null,
            FeedRange feedRange = null)
        {
            if (feedRange != null)
            {
                // If we need to start at the beginning, create an empty continuation token for a specific range.
                if (continuationToken == null)
                    continuationToken = SingleRangeFeedIterator<T>.CreateBeginningOfRangeContinuationToken(feedRange);

                return new SingleRangeFeedIterator<T>(
                    container.GetItemQueryIterator<T>(queryText, continuationToken, requestOptions),
                    feedRange,
                    continuationToken
                );
            }

            return container.GetItemQueryIterator<T>(queryText, continuationToken, requestOptions);
        }
    }

    /// <summary>
    /// Iterates a feed without switching ranges.
    /// This iterator will only return results from a specific feed range.
    /// </summary>
    /// <typeparam name="T"></typeparam>
    public class SingleRangeFeedIterator<T> : FeedIterator<T>
    {
        private readonly FeedIterator<T> _innerIterator;

        private bool? _hasMoreResults;
        public override bool HasMoreResults => _hasMoreResults ?? _innerIterator.HasMoreResults;

        public FeedRange FeedRange { get; }

        public SingleRangeFeedIterator(FeedIterator<T> innerIterator, FeedRange feedRange, string continuationToken)
        {
            if (string.IsNullOrWhiteSpace(continuationToken))
                throw new ArgumentException($"'{nameof(continuationToken)}' cannot be null or whitespace.", nameof(continuationToken));

            _innerIterator = innerIterator;
            FeedRange = feedRange;

            // Valiate range in continuation token.
            var continuationRange = ExtractRange(continuationToken);
            if (continuationRange != null && !FeedRange.Equals(continuationRange))
                throw new ArgumentException("This continuation token does not match the provided feed range for this iterator.");
        }

        public override async Task<FeedResponse<T>> ReadNextAsync(CancellationToken cancellationToken = default)
        {
            var response = await _innerIterator.ReadNextAsync(cancellationToken);

            if (!string.IsNullOrWhiteSpace(response.ContinuationToken))
            {
                var nextRange = ExtractRange(response.ContinuationToken);

                if (nextRange == null || !FeedRange.Equals(nextRange))
                    _hasMoreResults = false;
            }

            return response;
        }

        protected override void Dispose(bool disposing)
        {
            _innerIterator.Dispose();
        }

        #region Static helpers

        public static string CreateBeginningOfRangeContinuationToken(FeedRange feedRange)
        {
            if (feedRange is null) throw new ArgumentNullException(nameof(feedRange));

            var jRange = JObject.Parse(feedRange.ToJsonString())["Range"];

            //return $@"[{{""token"":null,""range"":{{""min"":""{jRange["min"]}"",""max"":""{jRange["max"]}""}}}}]";
            return JsonConvert.SerializeObject(new[]
            {
                new
                {
                    token = (string)null,
                    range = new
                    {
                        min = jRange["min"].ToString(),
                        max = jRange["max"].ToString()
                    }
                }
            });
        }

        private static FeedRange ExtractRange(string continuationToken)
        {
            if (string.IsNullOrWhiteSpace(continuationToken)) return null;

            var jContinuation = JArray.Parse(continuationToken).Single();

            // Patch casing.
            jContinuation["Range"] = jContinuation["range"];

            return FeedRange.FromJsonString(jContinuation.ToString());
        }

        #endregion
    }

Please look at the following documentation: https://docs.microsoft.com/en-us/azure/cosmos-db/sql/change-feed-pull-model#using-feedrange-for-parallelization

This documentation is only talking about retrieving changes, not about regular queries right?
My issue concerns queries, not the change feed.

@WimVergouwe the FeedRange works the same for both query and changefeed. You should be able to apply the same principals to both.
@timsander1 can you please add documentation for query using feed range?

This exists in the preview package, you can call GetQueryIterator with a FeedRange. It is not GA.

This has been GAed in 3.26.0


TE-11.2: Backup NHG: Multiple NH

Added TC TE-11.2: Backup NHG: Multiple NH
Uplifted GRIBI NHG call for supporting additional parameters
Added Flush API

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 70.423%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1050

Relevant Lines:
1491

💛  - Coveralls

As per the WBB vendor plan ipv4 address, <IP_ADDRESS>/8 needs to be used. Can you please confirm which address needs to be used

As per the WBB vendor plan ipv4 address, <IP_ADDRESS>/8 needs to be used. Can you please confirm which address needs to be used

Thank you for the contribution.  In this case, lets use the contribution guide - ip address assignment guidelines.
So for this test, the destination prefix should be changed to be within the range TEST-NET-3: (<IP_ADDRESS>/24): data plane destination network addresses used for traffic testing; split as needed..      Since this test doesn't call for multiple subnets,  think you could use <IP_ADDRESS>/24

Hi Darren, can you please assign a reviewer?

Hi thanks for your contribution!  I will assign a reviewer now and queue as candidate for our next sprint.  It may be 1-2 weeks before there is action.

/gcbrun

/gcbrun

/gcbrun

This PR is older and the Cloud Build task fails.  If this was rebased to include #526 it should pass, but I don't believe the changes here are relevant to the cloud build check either.

/gcbrun

/gcbrun

@liulk I included the suggested change in https://github.com/openconfig/featureprofiles/pull/403#discussion_r981556680 .  I had to rebase the PR to make this merge successfully with the AddNHG changes.  Does this look good?

/gcbrun


feat: upgrade to lance 0.9.11 and expose merge_insert

This adds the python bindings requested in #870 The javascript/rust bindings will be added in a future PR.

Hmm, the failing doctest should be fixed in the next lance release.  I corrected the order of merge_insert slightly in https://github.com/lancedb/lance/pull/1892 .  I'll leave in draft for now.

Hmm, the failing doctest should be fixed in the next lance release. I corrected the order of merge_insert slightly in https://github.com/lancedb/lance/pull/1892 . I'll leave in draft for now.

Nevermind, there is no stable order because we are using a JOIN.  I'll add a sort to the example and move this back to ready.


Any KD experimental results that can be published?

@moyans
Thanks for your interest. Do you want to which ckpt? I have enough GPUs current. This week I will update some of these checkpoints (feel sorry, because I hace no access to previous ckpts now).

Thank you for your work.
I'm just interested in the performance of distillation on lightweight models.

@moyans
Sorry, I haven't distilled the lightweight detection network before.
I remember that the authors of FGD and CWD said in the previous group that distillation technology will not greatly improve the lightweight network, and there is a distillation upper limit for small networks.
Take YOLOX-Tiny as an example, distillation can achieve little performance improvement, because these networks are well designed by hand, and there is no distillation space left.
That is why recent KD papers don't show lightweight detection model's performance.


How to use LDAP with ariflow-docker?

Hello,
I am trying to use LDAP on Airflow with Docker but i have the following error:
airflow-webserver_1       |   File "/home/airflow/.local/lib/python3.11/site-packages/airflow/www/extensions/init_security.py", line 65, in init_api_experimental_auth
airflow-webserver_1       |     raise AirflowException(err)
airflow-webserver_1       | airflow.exceptions.AirflowException: No module named 'airflow.api.auth.backend.ldap_auth'

Do you know how to?
Thank you

I havent tried using LDAP on docker instance.  Can you tell me more how you are trying to do this?


outlineOTF: do not allow negative advance widths when generating hmtx table

The hmtx specs clearly say advanceWidth field in _longHorMetric struct must be an USHORT.
FreeType also interprets the field as an unsigned short, leading to extremely wide rendering.
Acrobat Reader returns a "A number is out of range" error if a negative advance is found in a PDF, and then all the widths will show up scrambled.
The UFO spec is silent about it (just says 'integer or float'), however Glyphs.app prevents this issue by not allowing to set negative advance widths.
Hence we should do the same in ufo2ft.

FontLab Studio 5 does allow such negative advance widths to sneak in a font (that's how we stumbled on this issue).
For some reason (/cc @behdad) FontTools deliberately decompiles advance widths from hmtx table as signed integers:
https://github.com/behdad/fonttools/commit/035bc7da2318f0dcacecba2e1e24c0a4bf3cf80c#diff-f1a37102608ecea22d52a8cb91aba526R21

Error should probably be thrown by fontTools?

Yes, there is an open issue in fonttools. But it does not harm to raise here as well.


Type "boolean" is incompatible with type "false | true"

function foo(a: true | false): undefined {

}
function bar(): boolean {
    return true
}

foo(bar()) //Err Type "boolean" is incompatible with type "false | true"

try

Thank you for reporting. It's already fixed, so, it will be added in the next version. Please, don't close the issue. I will close it by myself after the new version will be published.
Thank you for your contribution ^_^.


jjson's %* macro does not work with object variant types

On nim devel, karax 1.1.2
import karax / [jjson, kbase, kajax]

type
  RpcKind = enum
    doThis,
    doThat
  Rpc = object
    case kind: RpcKind
    of doThis: thisParam: kstring
    of doThat: thatParam: kstring

let obj = Rpc(kind: doThis, thisParam: "foo")
system.echo (%*obj).toJson

Expected: prints {"kind": "doThis", "thisParam": "foo"}
Got: compile error:  expression cannot be cast to JsonNode=ref JsonNode:ObjectType
While we're at it, I can get it to work by replacing karax utils with std's json module, specifically:

jjson.%* -> json.%*
kajax.toJson -> json.$
kstring -> string

But I assume using karax's utils and kstring is more performant because that way it only works with native js strings and objects - is that correct?

is that correct?

Yes.

This one can be solved similarly to https://github.com/karaxnim/karax/issues/104#issuecomment-830861588
Here's a working example using jsffi:
import karax / [kbase, kajax]
include karax/prelude
import jsffi
type
  RpcKind = enum
    doThis,
    doThat
  Rpc = object
    case kind: RpcKind
    of doThis: thisParam: kstring
    of doThat: thatParam: kstring

let obj = Rpc(kind: doThis, thisParam: "foo")
let objJs = obj.toJS
let original = objJs.to(Rpc)
kout objJs
kout original
kout original.thisParam

Output:
{kind: 0, thisParam: "foo", thatParam: null}
{kind: 0, thisParam: "foo", thatParam: null}
foo

Again, I think jsffi is just as performant as the jjson module, so I would recommend using it over jjson as jsffi is part of the stdlib.
(If you want to turn this into a string, you can use https://github.com/karaxnim/karax/blob/master/karax/kajax.nim#L130)
Please reopen if you have any other issues!


🗑 Deprecation of toNotEmptyList extension function with warning level

📝 Description
We would like to deprecate toNotEmptyList extension function with a warning level for using the NotEmptyList.Companion.create(Collection) function instead.
🔗 Dependencies
This issue is blocked by the following ones:

[x] #498

✅ Checklist

[ ] Deprecate the declaration with a warning level, refactor its usages and update the unreleased changelog.
[ ] Close this issue as completed and update tracking ones if present.

We are not ready to implement this change.


DEV-14281 Deprecate ephemeral spark cluster module.

Changes in README's, variable names, submodules, and examples to support more than just the static hbase cluster use case.
With these changes, the module supports 3 patterns of use -- creation of infrastructure for (1) static hbase cluster, (2) static spark cluster, and (3) ephemeral spark cluster

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


wrong id for table row in dashbard view

When showing branch jobs on jenkins dashboard, they generate single
 for every branch.
Now having two repositories with same branches each:
front:
  develop
  release
  master
backend:
develop
release
master
we get  twice, which is not allowed in html
It better be
 and

The Dashboard view plugin would have to add support for a nested item hierarchy.


Fallible collections

Vectors, Hashmaps, e.t.c all implicitly fail whenever allocations fail. We are already capping the global allocations using cap, fallible collections would then ensure we don't panic but rather surface the allocation errors

It wouldn't be practical or possible to make every datastructure we use fallible, so how about we wrap critical client parts in an std::panic::catch_unwind to ensure that if we ever do massive allocations, we are able to report errors from there back to the client


[vim] Clean up temp files on interrupt

The clean-up is done in s:collect(), so let's make sure it's run before
we may terminate due to CTRL-C or ESC in exit_handler().

Reproducer:

Start vim
Activate the search (e.g. :FZF)
Observe the /tmp/v* directory (there should be at least one file)
Press ESC or CTRL-C to close the window
Files in /tmp/v* are still there

After the patch, no files are present in the /tmp/v* directory.

Merged, thanks!


Preferences does not load the existing preference when showing screen

When you navigate away from preferences and return, the value resets to 0 even though the database has the value stored.
Expected Behavior; Should show the value last entered
Test;

Navigate to Preferences, enter a value of 64
Validate the database has a preference of 64 target fluid ounces
Navigate to Log
Navigate back to Preferences
Value should show 64

Looking at this, it looks like a new endpoint will be needed to get the preferences from the api,  additionally the preferences page needs to be initialized from that endpoint.

As we added timezone offset to the preferences since this was done, we should also load this preference and display options for selecting timezone.


Flatten attribute doesn't compose well when flattening type with same name

When attempting to flatten field of SimpleObject that has the same name as your wrapper object, SDL schema generator doesn't embed fields inside.
E.g.
#[derive(SimpleObject)]
pub struct Config {
    whatever: String
}

#[derive(SimpleObject)]
#[graphql(name = "Config")]
pub struct Wrapper {
    id: i64
    config: Config
}

Results in
type Config {
  Id: Int
}

But if you remove or change name of wrapper to anything else, it will properly embed fields in schema.
I understand it might be inherent limitation, but let me know if it is actually bug.

Don't let them have the same name, this problem is very difficult to solve. 😂

yeah, I would like to have the same name so that the same code could be used in both endpoints...
I suppose I will write my own proc macro to generate wrapper code then


Simplify FetchRequestDelegate.prepareHeadersForRequest

With the introduction of FetchRequest.acceptResponseType() in hotwired/turbo#647, the
FetchRequestDelegate.prepareHeadersForRequest callback interacts with more than just the FetchRequestHeaders instance passes as its first argument.
Additionally, every implementation of the FetchRequestDelegate interface implements the prepareHeadersForRequest method, so the fact that it's listed as optional and invoked with a guard clause are unnecessary.
This commit renames the method to prepareRequest, reduces the signature to a single FetchRequest argument, and no longer declares it as a conditional property on the interface.

Hey @kevinmcconnell, this came out of some of the Turbo Stream work you've done. If you're available, I'd really appreciate some code review!


Query: WGAN-GP FID SCORE (PyTorch)

Thank you for sharing the implementations of the GAN based models on popular datasets like CelebA.
I have implemented the WGAN-GP model (in PyTorch), the samples are looking closer the reported work (please refer to the attached image). When I try to evaluate the Fréchet inception distance (FID score), I am not able to comprehend the high values of 100+ (best value 113.4). Others have reported lower FID Scores. Authors in the Quality Aware Generative Adversarial Networks compared the vairous FID scores for various GAN models and there Ishaan Gulrajani's official implementation of WGAN-GP got FID score of 12.89.
I request you to guide me.
Regards
Prabhav
I have used the following repositories for reference while implementing the WGAN-GP model and evaluating the FID scores:
LynnHo/DCGAN-LSGAN-WGAN-GP-DRAGAN-Pytorch
CharlesNord/WGAN-GP-DRAGAN-Celeba-Pytorch
eriklindernoren/PyTorch-GAN
hukkelas/pytorch-frechet-inception-distance
mseitzer/pytorch-fid

Hello, I'm using the code here to train WGAN-GP on cifar10, but I keep getting blurry images. Since you have tried to train the model on CelebA, which is also a more complex dataset than MNIST, have you ever tried on cifar10? Sorry that my comment is not helping you with your problem, but can you share your hyperparameters with me when you do experiments on CelebA?

您好，您的邮件小皮已经收到啦！！！


Adding Scroll Progress Bar

@notsoocool
I would like to add scroll progress bar
could you please assign it to me

Hi @notsoocool ,
I noticed @AswaniBolisetti has taken on multiple issues but haven't resolved any yet. It becomes difficult for others like me to contribute when someone tries to hold two or three issues at the same time. I would also like to work on this issue, but it’s challenging when others block multiple tasks without completing them.
To the maintainer: Please consider this, as it affects the pace and opportunities for contributors. I resolved this issue in 2 hours and would appreciate it if my efforts were recognized.
Thanks!

@RachitSahu26
I have completed all my issues
Thank you

@AswaniBolisetti kindly have a different PR for each issue. I mentioned this earlier, but you still didn't follow my instructions.

@AswaniBolisetti see, do one thing: make different branches for different issues. It will help you in raising different PRs for different issues. Just do some modifications to successfully achieve the points. Thank you!

@notsoocool
Kindly check it again
I have created seperate branches for all the three issues created by me

@notsoocool
I have created seperate branches as you said
But you closed all my pull requests

@notsoocool I have created seperate branches as you said But you closed all my pull requests

Because you have to raise different pull requests with those branches and solve the separate issues in the respective branches.

@notsoocool I have created seperate branches as you said But you closed all my pull requests

Because you have to raise different pull requests with those branches and solve the separate issues in the respective branches.

@i raised different pull request that's why in pull requests section there are 3 pull requests created by me

@AswaniBolisetti first take a deep breath and listen

this basically means all changes in one PR even if you raised 3 different PR, the changes and commits are always the same, thats why we have branches to push different commit at a time. You are getting confused with pushing changes one after another and creating 3 different PR, it will always reflect in same changes to all 3 PR, as it was performed to same branch


Sortable List needs css adapted

The new drag and drop sortable list implementation uses dummy css to work.
Proper css classes, currently the size of the Modal doesn't scale to its content.

#137

Should be much better already, since #145 and 6c46d0d.


Deleting a workflow prompts me to also "delete from database"

Pre-requisites

[X] I have double-checked my configuration
[X] I can confirm the issues exists when I tested with :latest
[ ] I'd like to contribute the fix myself (see contributing guide)

What happened/what you expected to happen?
Deleting the workflow via the UI results in this popup:

The warning makes no sense because we do not have workflow archiving enabled.
The workflow is deleted regardless of whether I press cancel or ok anyway. So from a UX perspective, it's a bit baffling.
Version
3.5-rc1
Paste a small workflow that reproduces the issue. We must be able to run the workflow; don't enter a workflows that uses private images.
Any workflow.

Logs from the workflow controller
time="2023-08-23T10:53:32.377Z" level=info msg="Processing workflow" namespace=ci workflow=renovate-pipeline-mono-prbj4
time="2023-08-23T10:53:32.378Z" level=info msg="Task-result reconciliation" namespace=ci numObjs=0 workflow=renovate-pipeline-mono-prbj4
time="2023-08-23T10:53:32.378Z" level=info msg="node unchanged" namespace=ci nodeID=renovate-pipeline-mono-prbj4-3492216532 workflow=renovate-pipeline-mono-prbj4
time="2023-08-23T10:53:32.378Z" level=info msg="Terminating pod as part of workflow shutdown" namespace=ci podName=renovate-pipeline-mono-prbj4-renovate-3492216532 shutdownStrategy=Stop workflow=renovate-pipeline-mono-prbj4
time="2023-08-23T10:53:32.378Z" level=info msg="node renovate-pipeline-mono-prbj4-3492216532 phase Running -> Failed" namespace=ci workflow=renovate-pipeline-mono-prbj4
time="2023-08-23T10:53:32.378Z" level=info msg="node renovate-pipeline-mono-prbj4-3492216532 message: workflow shutdown with strategy:  Stop" namespace=ci workflow=renovate-pipeline-mono-prbj4
time="2023-08-23T10:53:32.378Z" level=info msg="node renovate-pipeline-mono-prbj4-3492216532 finished: 2023-08-23 10:53:32.378636191 +0000 UTC" namespace=ci workflow=renovate-pipeline-mono-prbj4
time="2023-08-23T10:53:32.379Z" level=info msg="Stopped with strategy 'Stop'" namespace=ci workflow=renovate-pipeline-mono-prbj4
time="2023-08-23T10:53:32.379Z" level=info msg="node renovate-pipeline-mono-prbj4-1573759850 phase Running -> Failed" namespace=ci workflow=renovate-pipeline-mono-prbj4
time="2023-08-23T10:53:32.379Z" level=info msg="node renovate-pipeline-mono-prbj4-1573759850 message: Stopped with strategy 'Stop'" namespace=ci workflow=renovate-pipeline-mono-prbj4
time="2023-08-23T10:53:32.379Z" level=info msg="node renovate-pipeline-mono-prbj4-1573759850 finished: 2023-08-23 10:53:32.379189863 +0000 UTC" namespace=ci workflow=renovate-pipeline-mono-prbj4
time="2023-08-23T10:53:32.379Z" level=info msg="Outbound nodes of renovate-pipeline-mono-prbj4-2344736112 set to [renovate-pipeline-mono-prbj4-3492216532]" namespace=ci workflow=renovate-pipeline-mono-prbj4
time="2023-08-23T10:53:32.379Z" level=info msg="node renovate-pipeline-mono-prbj4-2344736112 phase Running -> Failed" namespace=ci workflow=renovate-pipeline-mono-prbj4
time="2023-08-23T10:53:32.379Z" level=info msg="node renovate-pipeline-mono-prbj4-2344736112 finished: 2023-08-23 10:53:32.379311141 +0000 UTC" namespace=ci workflow=renovate-pipeline-mono-prbj4
time="2023-08-23T10:53:32.379Z" level=info msg="Stopped with strategy 'Stop'" namespace=ci workflow=renovate-pipeline-mono-prbj4
time="2023-08-23T10:53:32.379Z" level=info msg="node renovate-pipeline-mono-prbj4 phase Running -> Failed" namespace=ci workflow=renovate-pipeline-mono-prbj4
time="2023-08-23T10:53:32.379Z" level=info msg="node renovate-pipeline-mono-prbj4 message: Stopped with strategy 'Stop'" namespace=ci workflow=renovate-pipeline-mono-prbj4
time="2023-08-23T10:53:32.379Z" level=info msg="node renovate-pipeline-mono-prbj4 finished: 2023-08-23 10:53:32.379483979 +0000 UTC" namespace=ci workflow=renovate-pipeline-mono-prbj4
time="2023-08-23T10:53:32.379Z" level=info msg="TaskSet Reconciliation" namespace=ci workflow=renovate-pipeline-mono-prbj4
time="2023-08-23T10:53:32.379Z" level=info msg=reconcileAgentPod namespace=ci workflow=renovate-pipeline-mono-prbj4
time="2023-08-23T10:53:32.379Z" level=info msg="Updated phase Running -> Failed" namespace=ci workflow=renovate-pipeline-mono-prbj4
time="2023-08-23T10:53:32.379Z" level=info msg="Updated message  -> Stopped with strategy 'Stop'" namespace=ci workflow=renovate-pipeline-mono-prbj4
time="2023-08-23T10:53:32.379Z" level=info msg="Marking workflow completed" namespace=ci workflow=renovate-pipeline-mono-prbj4
time="2023-08-23T10:53:32.384Z" level=info msg="cleaning up pod" action=terminateContainers key=ci/renovate-pipeline-mono-prbj4-renovate-3492216532/terminateContainers
time="2023-08-23T10:53:32.384Z" level=info msg="https://<IP_ADDRESS>:443/api/v1/namespaces/ci/pods/renovate-pipeline-mono-prbj4-renovate-3492216532/exec?command=%2Fvar%2Frun%2Fargo%2Fargoexec&command=kill&command=15&command=1&container=main&stderr=true&stdout=true&tty=false"
time="2023-08-23T10:53:32.385Z" level=info msg="cleaning up pod" action=deletePod key=ci/renovate-pipeline-mono-prbj4-1340600742-agent/deletePod
time="2023-08-23T10:53:32.394Z" level=info msg="Workflow update successful" namespace=ci phase=Failed resourceVersion=138747944 workflow=renovate-pipeline-mono-prbj4
time="2023-08-23T10:53:32.395Z" level=info msg="Queueing Failed workflow ci/renovate-pipeline-mono-prbj4 for delete in 1h0m0s due to TTL"
time="2023-08-23T10:53:32.407Z" level=info msg="cleaning up pod" action=labelPodCompleted key=ci/renovate-pipeline-mono-prbj4-renovate-3492216532/labelPodCompleted
time="2023-08-23T10:53:32.538Z" level=info msg="signaled container" container=main error="<nil>" namespace=ci pod=renovate-pipeline-mono-prbj4-renovate-3492216532 stderr= stdout="killing 1 with terminated\n"
time="2023-08-23T10:53:32.538Z" level=info msg="https://<IP_ADDRESS>:443/api/v1/namespaces/ci/pods/renovate-pipeline-mono-prbj4-renovate-3492216532/exec?command=%2Fvar%2Frun%2Fargo%2Fargoexec&command=kill&command=15&command=1&container=wait&stderr=true&stdout=true&tty=false"
time="2023-08-23T10:53:32.628Z" level=info msg="signaled container" container=wait error="<nil>" namespace=ci pod=renovate-pipeline-mono-prbj4-renovate-3492216532 stderr= stdout="killing 1 with terminated\n"
time="2023-08-23T10:53:36.967Z" level=info msg="Processing ci/renovate-pipeline-mono" cronWorkflow=ci/renovate-pipeline-mono
time="2023-08-23T10:53:36.969Z" level=info msg="CronWorkflow ci/renovate-pipeline-mono added" cronWorkflow=ci/renovate-pipeline-mono
time="2023-08-23T10:54:02.629Z" level=info msg="cleaning up pod" action=killContainers key=ci/renovate-pipeline-mono-prbj4-renovate-3492216532/killContainers
time="2023-08-23T10:57:28.921Z" level=info msg="Queueing Failed workflow ci/renovate-pipeline-mono-prbj4 for delete in 56m4s due to TTL"
time="2023-08-23T10:57:29.065Z" level=info msg="Queueing Failed workflow ci/renovate-pipeline-mono-prbj4 for delete in 56m3s due to TTL"

Logs from in your workflow's wait container
time="2023-08-23T10:43:42.160Z" level=info msg="Starting Workflow Executor" version=v3.5.0-rc1
time="2023-08-23T10:43:42.163Z" level=info msg="Using executor retry strategy" Duration=1s Factor=1.6 Jitter=0.5 Steps=5
time="2023-08-23T10:43:42.163Z" level=info msg="Executor initialized" deadline="2023-08-23 11:35:20 +0000 UTC" includeScriptOutput=false namespace=ci podName=renovate-pipeline-mono-prbj4-renovate-3492216532 template="{\"name\":\"renovate\",\"inputs\":{},\"outputs\":{},\"nodeSelector\":{\
time="2023-08-23T10:43:42.163Z" level=info msg="Starting deadline monitor"
time="2023-08-23T10:48:42.164Z" level=info msg="Alloc=6974 TotalAlloc=13886 Sys=30829 NumGC=6 Goroutines=7"
time="2023-08-23T10:53:32.622Z" level=info msg="Deadline monitor stopped"
time="2023-08-23T10:53:32.622Z" level=info msg="stopping progress monitor (context done)" error="context canceled"
time="2023-08-23T10:53:33.222Z" level=warning msg="Non-transient error: context canceled"
time="2023-08-23T10:53:33.222Z" level=info msg="Main container completed" error="context canceled"
time="2023-08-23T10:53:33.222Z" level=info msg="No Script output reference in workflow. Capturing script output ignored"
time="2023-08-23T10:53:33.222Z" level=info msg="No output parameters"
time="2023-08-23T10:53:33.222Z" level=info msg="No output artifacts"
time="2023-08-23T10:53:33.222Z" level=info msg="S3 Save path: /tmp/argo/outputs/logs/main.log, key: my-artifacts/2023/08/23/renovate-pipeline-mono-prbj4/renovate-pipeline-mono-prbj4-renovate-3492216532/main.log"
time="2023-08-23T10:53:33.222Z" level=info msg="Creating minio client using AWS SDK credentials"
time="2023-08-23T10:53:33.329Z" level=info msg="Saving file to s3" bucket=pipekit-argo-workflows endpoint=s3.amazonaws.com key=my-artifacts/2023/08/23/renovate-pipeline-mono-prbj4/renovate-pipeline-mono-prbj4-renovate-3492216532/main.log path=/tmp/argo/outputs/logs/main.log
time="2023-08-23T10:53:33.530Z" level=info msg="Save artifact" artifactName=main-logs duration=307.244472ms error="<nil>" key=my-artifacts/2023/08/23/renovate-pipeline-mono-prbj4/renovate-pipeline-mono-prbj4-renovate-3492216532/main.log
time="2023-08-23T10:53:33.530Z" level=info msg="not deleting local artifact" localArtPath=/tmp/argo/outputs/logs/main.log
time="2023-08-23T10:53:33.530Z" level=info msg="Successfully saved file: /tmp/argo/outputs/logs/main.log"
time="2023-08-23T10:53:33.558Z" level=info msg="Alloc=11295 TotalAlloc=18297 Sys=35181 NumGC=8 Goroutines=9"

Is this for deleting a single workflow (on workflow details page) or batch deletion (on workflow list page)?

cc @toyamagu-2021

I think this message is displayed on the workflow list page but not on the details page.
It's a specification from the code currentrly, but can we erase this popup when archived workflows not enabled?
https://github.com/argoproj/argo-workflows/blob/aac4f89d1649125a7c431e0c92fbc3862e60f494/ui/src/app/workflows/components/workflows-toolbar/workflows-toolbar.tsx#L52-L56

I'll try this in this weekend.

Sorry, I was answering if it was a single or batch, both on the list page. It's not on the details page.

I introduced that code. Sent a fix in https://github.com/argoproj/argo-workflows/pull/11659


Window: Theme is not applied to tabs

I believe it is a problem, after all the theme colors are not applied to the tabs.
This is the result I have

Only maintainers make issues. Read the rules in CONTRIBUTING.md


Fix very wrong staking test

closes #5838

while doing this, I once more saw how confusing and bad some tests have become. Mostly because some tests are not well isolated, so numerous PRs from numerous people changed one tests case, and this naturally leads to a bad test. For example this one that I fixed here was first written by me and Shawn waaaaay back last year, then there are signs of it being changed with the reward PR and then the slashing PR, all in the same unit test. Some assertions (about rewards for example) made no sense anymore.
I already have a few issues open about staking tests, but even without that, I will start an endeavour soon to read all of them A to the very damn Z and make sure they make sense.

Sorry, can you be a bit more explicit about what in the old test was totally wrong? How was it passing?

1- as stated in the issue, the slash portion of nominator was zero, so nothing was being really tested.
2- it had a lot of totally unrelated stuff such as rewards or bonding a new nominator. Now it does one thing and it does it clearly: a nominator is slashed pro rata.

bot merge


Realtek ALC892

VoodooHDA works, but the sound quality is poor :(
Is it possible to make sound work using AppleALC.kext for Realtek ALC892?

Yes. ALC892 is supported by AppleALC, see here.
For installation, follow the instructions here


"Conlen controls"

This PR adds support for a control scheme suggested by @mathisonian. In the new scheme, there are just three keys: A and D click left or right around the hexagon, and W moves forward. All three work within a tile, only A and D work inside a path (they flip you around).
The implementation is such that switching back to the previous version is now trivial, we just swap out
keymap: ['A', 'D', 'W']
heading: [-60, 60, 0]
shift: [0, 0, 8]

with
keymap: ['Q', 'W', 'E', 'A', 'S', 'D']
heading:[-60, 0, 60, -120, -180, 120]
shift: [8, 8, 8, 8, 8, 8]

the key idea is that shift is now an array of shifts, one per heading direction, and if a shift is 0 it means you don't move when heading in that direction.
Remaining todos:

[x] switch to arrow keys (or at least make an option)
[ ] reconsider what happens when you hit a wall (maybe bounce back to the center)

there's at least one remaining bug with these controls, in which a quick turn followed by a forward movement can take you "off rails" in a diagonal vector, doesn't happen easily, but definitely reproducible, thanks for catching @maxogden!
suspect we need to adjust the key blocking logic in automove

@sofroniewn latest changes are really good! Love the back button. I think we should merge this in and continue to tweak the controls with additional PRs as needed.

:+1:

LGTM!


Refactor remove the unless timer in scanner

Proposed changes
remove the unless code in scanner

run buildall

run buildall


docs: Tips for fixing failures in do-release-upgrade

I've just upgrade from Ubuntu 20.04->22.04 in order to install Zulip 9.0.
Aside from these two issues, the upgrade went well :+1:

Hey!
I'm not sure what the issue is can the CI job maybe output the reason that it fails the link check? "Code style issues found in the above file." doesn't help a lot :smiley:
21s
Run source tools/ci/activate-venv
  source tools/ci/activate-venv
  echo "Test suite is running under $(python --version)."
  ./tools/lint --groups=backend --skip=gitlint,mypy # gitlint disabled because flaky
  shell: bash --noprofile --norc -e -o pipefail {0}
  env:
    HOME: /home/github/
Using /srv/zulip-py3-venv
Test suite is running under Python 3.11.2.
prettier  | [warn] docs/production/upgrade.md
prettier  | [warn] Code style issues found in the above file. Run Prettier with --write to fix.
Run ./tools/lint --fix to fix errors for the following linters: prettier
Error: Process completed with exit code 1.

Thanks for the PR! It's a good thought.
The error message is from prettier upstream, the auto-formatter we use; I agree it's not fantastic. But in any case, our own error message tells you to run ./tools/lint --fix, which will run the autoformatter for you to correct the line-wrapping (etc.) to match our preferred style.

I see that I also made some spelling errors, so may not get around setting up a local checkout and environment :)

I tried to get the linting to work, but after reading a couple of documentation articles, installing Vagrant and downloading gigabytes of packages and waiting forever, I will leave it in case another fellow developer happens to already have this running :stuck_out_tongue:

The linter is just prettier, which is a standard open-source code formatter; you're welcome to just install and run that yourself; but yes the development environment is optimized to make life really easy for folks who to run a Zulip server, and that means getting all the dependencies.


Al 2275 [dev]

Codecov Report

Merging #1066 (0fd04a8) into dev (4b8df8f) will increase coverage by 0.03%.
The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff             @@
##              dev    #1066      +/-   ##
==========================================
+ Coverage   76.86%   76.90%   +0.03%
==========================================
  Files         134      134
  Lines       12946    12946
==========================================
+ Hits         9951     9956       +5
+ Misses       2995     2990       -5

Impacted Files
Coverage Δ

assemblyline/odm/randomizer.py
95.25% <0.00%> (+0.86%)
:arrow_up:

assemblyline/common/heuristics.py
86.95% <0.00%> (+2.17%)
:arrow_up:

assemblyline/datasource/alert.py
92.30% <0.00%> (+3.84%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Source code was not found for app:///index.android.bundle

When uploading source maps, what are the rules in which sentry looks up the source maps by?
In the web ui for additional data I have release: xxxxx and in releases tab in the web ui I have a release with that exact version, then under artifacts with that release name I have a file uploaded entitled ~/index.android.bundle and ~/index.android.map, and if I look in the file for  ~/index.android.bundle at the bottom of it there is this line:
//# sourceMappingURL=index.android.bundle.map

This works for my iOS app but not my android app, (for iOS basically replace ios anywhere I mentioned android and that's how iOS is setup).
Additional context:
I setup source map uploading myself outside of react-native setup docs, I tied it into my release process to upload docs for example.  I use Code Push so every time the app boots I call Sentry.setExtraContext({ release: 'xxx' }) and Sentry.setRelease(),
perhaps I need to also call setVersion?
I noticed on iOS where sourcemaps works under tags there is release, but android there isn't? Maybe setting release is broken on Android?

Hey, I've recently updated the CodePush docs
https://docs.sentry.io/clients/react-native/codepush/
with these settings, I tried it with iOS and Android and it worked.
Note that also the dist has to match the release in sentry.
Also, can you link a few events here so I can check whats wrong?

@HazAT can I PM / email you the links directly?

So we continued the conversion via email.
The gist of it is that the release and dist have to match in order to have the source map to match.

Hi i am facing same issue .I dont know what am i missing.It is working fine in debugger mode but fails to load the source map when error occurs though sourcemaps have been loaded in artifacts but still facing this error.Please review my screenschots


Somebody, Show me pls working version this slider with custom range (non-linear) ...

Somebody, Show me pls working version this slider with custom range (non-linear) ...
Cuz i try all various of "range:{}" set, and all not work. Work only with "range:[]".
And i many time try to find already work version non-linear angular nouiSlider, but not have results...

I update all libraries and all work :) thnks


Refactor Linear Models

Codecov Report
Base: 100.00% // Head: 100.00% // No change to project coverage :thumbsup:

Coverage data is based on head (2d09ac3) compared to base (9b3e0e8).
Patch coverage: 100.00% of modified lines in pull request are covered.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@            Coverage Diff            @@
##              main        #3   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            7         7
  Lines          144       132   -12
  Branches        13        14    +1
=========================================
- Hits           144       132   -12

Impacted Files
Coverage Δ

dvml/models/linear.py
100.00% <100.00%> (ø)

dvml/models/model.py
100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Add issues

As the maintainer of a Learn + Collaborate repo, keeping Issues up-to-date will help the student community understand what they can do to contribute. Issues should vary by the easy (update documentation) to the difficult (add a new feature). The more involved you are, the more opportunities there are to collaborate.
Recommendations:

[ ] Add issues of varying difficulty to the repo often.
[ ] Generate issues even if you plan on solving them, so the repository appears as active.
[ ] Contribute/commit often to the repo so it does not go stale.

In order to submit your project into CX you will need at least one issue, but we recommend more so other students have an idea on where to start.

I'm going to keep this open for now, but I love that you've already started adding issue and labelling them with things like "Good first issue" ⭐

Actually on second thought, I'm closing this out, but please feel free to continue adding issues!


[chore] Update docker dependancies

https://github.com/hashicorp/go-secure-stdlib/pull/136 has been resolved and released as part of v0.4.1. Blocking docker dependencies from the upgrade is no longer needed.

We need this for 0.112.0, thanks! However it looks like that breaks the docker monitor.

This is almost ready to merge, one lint issue with a deprecated API. Given that this blocks updating the collector, I'd like to merge this, and open a follow up to fix the lint issue in parallel to updating dependencies. Please let me know if that works?


Add policy for determining Project Director substitutes

This solves an ambiguity about what to do when a Project Director cannot make a Foundation Board meeting. Instead of there being UB where in practice the PD in question decided on their own, this document lies out a simple procedure for choosing a sub.
Supersedes #61
@ehuss can you kick off the review process again and check off those who have already given their checkmark?

@rfcbot fcp merge
I'm going to check boxes from https://github.com/rust-lang/leadership-council/pull/61#issuecomment-1897739373, assuming everyone is fine with the minor updates that have been made.


My CPU is A10-7870K,there is a error when runing sample.

ERROR: This processor assumes device is fiji
The device object code was compiled for a kaveri.
Recompile or run this binary with a kaveri

To debug this issue more information is needed. Specifically, the sample being run. Please provide that information.


This is empty-commit to build a new image

This PR is for building new images by openshift-ci

/approve

/lgtm


[AAH-3101] adjust edit ns form to accept resources markdown field

https://issues.redhat.com/browse/AAH-3101
This pr adds the markdown field to the namespace pages.
Affected screens: Create, Edit, Details. @trahman73 @tiyiprh Anastasia Ratti have confirmed that the new ui will have the markdown under the "details" screen and not in a separate "resources" tab.
Edit:

Create:

Details:

Can you include jira issue, please? Additionally, we need to add the Resources tab, but that can be addressed in a different PR :)

@jerabekjiri , thanks for the review! I added the ticket AAH-3101 to the description (It is also in the pr title). See comment in description; we are foregoing the 'resources' tab on the new ui in favor of a details tab that includes the markdown. Create and edit screens are done and I am working on the detail page. I'll ping you again when it's complete.:)


reproducible/hermetic binary builds

The aim of this PR is to provide a deterministic build environment, which results in bit-by-bit identical firmware binaries.
To create reproducible builds:
0. change container upstream name in Makefile and Containerfile

make base: creates static docker container with build dependencies
Adjust base image in Containerfile
make build:
3.1 builds caliptra-sw and copies artifacts to host systems
3.2 generates sha256sum for each build

By comparing the sha526 hahes of all binaries for multiple compilations we can see, that only the following files are not identical:
$ diff caliptra-artifacts/10-03-23-144930/sha256sums.txt caliptra-artifacts/10-03-23-171654/sha256sums.txt
52c52
< 2aa8b8c40f2e4f18090865f587a431506490552395126fc32fe3637d4bd975a7  libcaliptra_emu_periph.rlib
---
> f21e14ff79c59cf55737539f158bb1acd1d3ffb693f9ff5f58ab9a217e1d1bfd  libcaliptra_emu_periph.rlib
62c62
< 619fe59d0283a4d06c02045cd56b9c979e1f6995e60fb619f128f0a4a76d7cca  libcaliptra_hw_model.rlib
---
> a2c463f5dd5d710ba99296dbe466d3cfa1080a335e9210d11f6181e22f8b84fa  libcaliptra_hw_model.rlib

Not reproducible so far (after extracting the archives using ar x <name>.rlib):

[ ] libcaliptra_hw_model.rlib -> lib.rmeta
[ ] libcaliptra_emu_periph.rlib -> lib.rmeta

@rusty1968 @jhand2 may you have a look at this?

This doesn't appear to be building the firmware binaries. See ./ci.sh check_frozen_images.

@korran does this fit the needs? Is generating and freezing the checksums all we are interested in?

@korran does this implement what you have in mind? Is building the binaries caliptra-rom-with-log.bin and caliptra-rom-no-log.bin and recording their sha384 sums enough? Or should this also package and release other binaries (such as in the github releases)?


Worker API documentation incorrectly says process isolation creates daemons that persist across builds

Issue type
Wrong or misleading information
Problem description
https://docs.gradle.org/8.6/userguide/worker_api.html#creating_a_worker_daemon says

These worker daemon processes will persist across builds and can be reused during subsequent builds.

This is not accurate since #21632 changed workers to run session scoped instead of daemon scoped.
It also talks about performance improvements when using worker daemons:

Note that the execution time may be somewhat high. This is because Gradle has to start a new process for each worker daemon, which is expensive. However, if you run your task again, you’ll see that it runs much faster. This is because the worker daemon(s) started during the initial build have persisted and are available for use immediately during subsequent builds.

The last two sentences should be removed - there doesn't seem to be any performance benefit to using process isolation now, an in fact it will be quite slow because Gradle has to start a new process for each worker daemon for every build.
Context (optional)
No response
Page with the problem
https://docs.gradle.org/8.6/userguide/worker_api.html#creating_a_worker_daemon

This issue needs a decision from the team responsible for that area. They have been informed. Response time may vary.

Thanks, this is a good point. We should change wording here.
This issue is actionable and it's a good issue for someone that wants to contribute.

should this issue be closed

@andrewkolda indeed. Thanks!


Status of radio buttons not displayed in Firefox after saving the pdf file from Firefox

Affected versions

Latest Nightly 82.0a1
Firefox 81.0b9

Affected platforms

Ubuntu 18.04 64bit
MacOS 10.15
Windows 10 64bit

Steps to reproduce

Open the following https://royalegroupnyc.com/wp-content/uploads/seating_areas/sample_pdf.pdf
Click on a radio button (remember it)
Save the .pdf locally
Open the .pdf inside Firefox

Expected result

Radio buttons previously saved are displayed in Firefox.

Actual result

Radio buttons that were previously saved are not displayed in Firefox.

Regression range

Not a regression since this did not work before as well.

Additional notes

The radio button is displayed in Firefox if pdfjs.renderInteractiveForms is set as false.

Suggested severity

Not sure about the severity here, I would say S2-S3, I would say though that it would be bad if the data saved in Firefox won't be displayed in Firefox but all other pdf editors.

The parent of the radio doesn't have any "V" field so we don't get the parent reference and so the parent is not saved.


Comparing mgatk and maegatk

I'm looking to compare the calls between mgatk and maegatk. I've read the FAQ and know that they should produce very similar results. I'm currently working with scRNA-seq data from 10X Multiome kit, processed with Cellranger-ARC.
How is a comparison made? For mgatk, I can read the results into a Seurat object using ReadMGATK(). However this function fails for maegatk output as it has more columns. Is there a way to output a Seurat object RDS like there is a Signac object RDS for mgatk?
Are there any suggestions to make a scRNA via mgatk vs a scRNA via maegatk comparison?
Ultimately I will compare scATAC via mgatk against scRNA via maegatk.

The tricky thing is that there isn't an obvious way of calling variants with maegatk since there is only 1 strand. In the MAESTER paper, there were a variety of filtering strategies to identify high-confidence variants. An mgatk versus maegatk comparison will show that most of the per cell, per variant allele counts will be similar.
The logic behind the ReadMGATK() --> variant calling in Seurat fails again because there is no strand concordance to call. @petervangalen do you have any advice on the best scripts to refer to call variants from maegatk output?

To call informative variants from maegatk output, I generated a heteroplasmy/allele frequency matrix for all possible variants (af.dm) and applied thresholds depending on the experimental question, such as " variants with 20-fold coverage, VAF of <10% in the bottom 10% of cells and VAF of >90% in top 10% of cells" (TenX_CellLineMix) or "variants present in at least 10 cells with a VAF of >50%" (CH_Sample) or variants with differing presence between samples (or cell subsets) from the same patient (GBM). This would yield on the order of 10 to 30 informative variants of which >80% transitions. Then I would consider cells to be part of a clone based on detecting these informative variants (e.g. heteroplasmy > 1%). As I said, this downstream analysis depends on the biological question and generally required a lot of iteration to find the best thresholds for each experiment. I am still looking for a more standardized approach.
We are also planning to compare scATAC vs. scRNA-derived variants, so it might be interesting to compare notes. Hope that helps!


Data trace and mutating loads

Using LC to access memory can cause the value loaded into a register not to match what was in the memory, e.g. reducing CL or removing LM+W permission.
What should data trace show in these cases?

The actual bits from the memory
The value which was loaded into the register

It seems reasonable that 2. is easier to implement, otherwise you need to hang on to the original and modified versions of the data.
Any opinions?
Also, if the data trace includes the tag, then it could affects stores which tag-strip. Would you trace the tag before or after the strip?
@tomaird @jamie-melling

I would argue that the purpose of the data trace is to monitor what is loaded from / stored to memory. The modification of permissions is part of the instruction semantics of lc, which happens after the data is loaded. By tracing the modified data, the trace encoder won’t have an accurate picture of what data is in the memory - it won't know if (e.g.) the LM-perm was clear in memory already, or if it was cleared by the lc. And if you do a lc immediately followed by a lw to the same region of memory where the metadata is stored, then you’ll see different results on the traced data, even though the data in the memory hasn’t actually changed at all, which doesn't seem right.

https://github.com/riscv/riscv-cheri/pull/463
I went for option 2


Use cookie store only without userDataDir for puppeteer

Default cookie store (saving cookies to json file and loading from it) should be disabled when user pass userDataDir into puppeteer options.
Btw, using userDataDir i better for saving session becasue according to me is safer. Using multiple accounts I have problem with maintain session on default cookie store but using userDataDir it works fine using multiple accounts.
I tested it and it works. Currently only set for upload method because I can't test it on other methods.

Thanks


Authorizer created but fails to attach to route

Description
Running the below code creates the authorizer (you can see and manage it) but it does not attach it to the route.
I have tried using the previous suggested fixes by adding authorization_type      = "REQUEST" to the route section but it still doesnt work.

[X ] ✋ I have searched the open/closed issues and my issue is not listed.

Versions

Module version [Required]:

Terraform version: 1.8.5

Provider version(s):

provider registry.terraform.io/hashicorp/archive v2.4.2
provider registry.terraform.io/hashicorp/aws v5.53.0
provider registry.terraform.io/hashicorp/external v2.3.3
provider registry.terraform.io/hashicorp/local v2.5.1
provider registry.terraform.io/hashicorp/null v3.2.2

Reproduction Code [Required]
terraform {
  required_providers {
    aws = {
      source  = "hashicorp/aws"
      version = "~> 5.0"
    }
  }
  required_version = ">= 1.8.0"
}

# simple lambda - save to index.mjs

# export const handler =  function(event, context, callback) {
#     console.log(event);
# };

resource "local_file" "index" {
  content  = <<EOF
export const handler =  function(event, context, callback) {
     console.log(event);
 };
EOF
  filename = "${path.module}/index.js"
}

data "archive_file" "lambda" {
    depends_on = [ local_file.index ]
  type        = "zip"
  source_file = "${path.module}/index.js"
  output_path = "${path.module}/lambda_function_payload.zip"
}

module "lambda_function" {
  source  = "terraform-aws-modules/lambda/aws"
  version = "~> 7.5"

  function_name = "bug-test"
  description   = "Authorizer test"
  handler       = "index.handler"
  runtime       = "nodejs20.x"
  architectures = ["x86_64"]
  publish       = true

  create_package    = false
  local_existing_package = "${path.module}/lambda_function_payload.zip"

  cloudwatch_logs_retention_in_days = 7

    create_role = true

    // when publish = false we must skip current ver
    create_current_version_allowed_triggers = false

  allowed_triggers = {
    AllowExecutionFromAPIGateway = {
      service    = "apigateway"
      source_arn = "${module.authorizer-bug-api-gwy.api_execution_arn}/*/*"
    }
  }
}

data "aws_iam_policy" "full_sqs_policy" {
    arn = "arn:aws:iam::aws:policy/AmazonSQSFullAccess"
}

data "aws_iam_policy" "apigwy_cloudwatchlogs_policy" {
    arn = "arn:aws:iam::aws:policy/service-role/AmazonAPIGatewayPushToCloudWatchLogs"
}

resource "aws_iam_role" "apigateway_service_role" {
  name = "Test-APIGWY-ServiceRole"
  assume_role_policy = <<EOF
{
  "Version": "2012-10-17",
  "Statement": [
    {
      "Action": "sts:AssumeRole",
      "Principal": {
        "Service": "apigateway.amazonaws.com"
      },
      "Effect": "Allow",
      "Sid": ""
    }
  ]
}
EOF
}

resource "aws_iam_role_policy_attachment" "full_sqs_policy_attach" {
   role       = "${aws_iam_role.apigateway_service_role.name}"
   policy_arn = "${data.aws_iam_policy.full_sqs_policy.arn}"
}

resource "aws_iam_role_policy_attachment" "apigwy_cloudwatchlogs_policy_attach" {
   role       = "${aws_iam_role.apigateway_service_role.name}"
   policy_arn = "${data.aws_iam_policy.apigwy_cloudwatchlogs_policy.arn}"
}

module "authorizer-bug-api-gwy" {
    source  = "terraform-aws-modules/apigateway-v2/aws"
    version = "~> 5.0"

    name = "BugTest"

    create_certificate = false
    create_domain_name = false
    create_domain_records = false
    create_stage = false

    // once we set up domain - this should be enabled
    //disable_execute_api_endpoint = true

    routes = {

        "POST /updatetest" = {
            integration = {
                type            = "AWS_PROXY"
                subtype         = "SQS-SendMessage"
                credentials_arn = "${aws_iam_role.apigateway_service_role.arn}"

                request_parameters = {
                    "QueueUrl"    = "$request.header.queueUrl"
                    "MessageBody" = "$request.body.message"
                }

                payload_format_version  = "1.0"
                timeout_milliseconds    = 12000
                authorization_type      = "REQUEST"
                authorizer_key          = "hackyAuth"
            }
        }

    }

    authorizers = {
        hackyAuth = {
            authorizer_type  = "REQUEST"
            identity_sources = ["$request.header.Authorization"]
            name             = "HackyAuth"
            authorizer_payload_format_version = "2.0"

            authorizer_uri = "${module.lambda_function.lambda_function_invoke_arn}"
        }
    }

}

Steps to reproduce the behavior:
terraform init && terraform apply
 No
 Yes
 init && apply
Expected behavior
I need to attach the lambda authorizer to the gwy route
Actual behavior
authorizer is created but not attached - aws console verified

ugh sorry about the code format

You should move these from the integration key one level up to the "POST /updatetest":
authorization_type      = "REQUEST"
authorizer_key          = "hackyAuth"

See this example:
https://github.com/terraform-aws-modules/terraform-aws-apigateway-v2/blob/6af44f5a90192660e519a3579fa81a7f2c73107d/examples/complete-http/main.tf#L74-L75

Ugh... Thank you - that worked.
One clarification, had to change the type to "CUSTOM"


no devices/emulator found

What would you like to be added:
to support emulator better
Why is this needed:
run this tool in an emulator
I want to use this tool in android emulator,  after installed termux and all the pkg required,  could not run the tool successfully,  when input the command   adb devices
it shows no devices/emulator,    when i input adb devices  in windows console the emulators devices are all listed , whats could be the problem for that?
anyone has the same problem and can do help Thanks.

Hello...
What are you talking about? Termux in an emulator? :S
You have three choices:

real phone connected to a PC / Raspberry / Mac
real phone with termux
an emulator like memu

The choice Termux + emulator doesn't have any sense.
If you need to run Termux ON A REAL DEVICE you have to follow the guide in the docs and if you fail, just ask people on the discord dedicated channel.


when someone goes from crit to dead they stop moving

Description

walk into space
bang stick yourself to crit
/ghost
body stops moving immediately

@deltanedas  this happens when we disable collision for a entity on dead MobState but i am not found any possibility to disable collision  without stopping movement , is this bug require engine changes or i am wrong?

i think it would need an option for SetCanCollide that preserves velocity yes

Realistically mobs just shouldn't have collisionwake or cancollide turned off.

thats seems right but now if we do so then we will constantly hit someone in crit on floor , feels like smth like this should be implemented before we can do so #21497

issue is fixed


nixos/soju: migrate to a static user

This makes it easy to give soju access to TLS certificates by adding the "soju" user to the "acme" group. Closes #353554

Things done

Built on platform(s)

[ ] x86_64-linux
[x] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Can't we make use of SupplementaryGroups?

Good point, though likely not everyone who wants to use the module knows about this systemd feature, whereas the extraGroups = [ "acme" ] thing is kind of standard. tbh I also dislike the DynamicUser feature because I've found it very hard to restore a backup of the StateDirectory for a service with dynamically allocated uid in a way that makes systemd happy, but this is besides the point.

There’s an accepted RFC specifically advising the use of DynamicUser whenever possible, and having to add supplementary groups is a standard part of using the ACME module. DynamicUser avoids additional unnecessary state management and also dovetails well with the various systemd service hardening options. If you want a static user it’s easy to override the systemd service in your own configuration, but I don’t think that we should regress things for the sake of users not having to learn about systemd features when we gain so many advantages from our deep systemd integration; if anything we should perhaps provide an easier interface to integrate ACME directly with arbitrary services. I also worry this would likely be backwards‐incompatible with existing users of the module in its current state as I don’t know if the owner would be automatically migrated?

I don’t know if the owner would be automatically migrated?

systemd does some magic here in the case of DynamicUser = true that I forget the details of, specifically wrt setting perms, and I'm not sure if this carries over to when it's disabled (I doubt it).

There’s an accepted RFC specifically advising the use of DynamicUser whenever possible, and having to add supplementary groups is a standard part of using the ACME module. DynamicUser avoids additional unnecessary state management and also dovetails well with the various systemd service hardening options. If you want a static user it’s easy to override the systemd service in your own configuration, but I don’t think that we should regress things for the sake of users not having to learn about systemd features when we gain so many advantages from our deep systemd integration; if anything we should perhaps provide an easier interface to integrate ACME directly with arbitrary services.

Fair enough.


Removal of Xamarin Studio for Windows

Updated text for the Information_InstallXamarinStudio to reflect that Xamarin Studio for Windows no longer exists.
Updated text across most languages (I don't grok cn/tw/jp so those are still the old text)
Updated the links in some mobile projects so that the Prerequisite is Xamarin for iOS projects and Visual Studio for Android and Forms Xamarin projects.

Looks good. I'll merge these on to dev and see what else needs to change

On second thoughts. Looks like https://github.com/projectkudu/SimpleWAWS/blob/master/SimpleWAWS/Resources/Client.Designer.cs
also needs to be updated. Will need to ensure it builds locally first. Also , we can pick up the translations from the loc team


compatbility fix

As html5lib has changed their structure this import needs to be updated for this project to continue to work.

Thanks @sorter -- but because of "legacy mode" of the project, #319 is probably favorable once it's updated to make tests work.
Are you willing to refactor the remaining codebase for these (not sure how many) changes to html5lib "internals"?

so.. will the lib have an legacy code update or just the html5lib==1.0b8 requirements "fix"

Depends if anyone wants to do the actual code fix, I still favor the more "legacy-like" requirements fix.

This was fixed in #321 by pinning the htmllib version.


Integrity constraint violation: 1062 Duplicate entry for Soft Delete

Hello,
I find issue on  Duplicate entry for unique slugs,
for example, if you using soft delete on model and
you want to insert a new record with same title, but you have soft deleted recored with that slug,
that you trying to instert with a new one,
you will get Integrity constraint violation.
Is there any solution or fix for this?
Thanx,
Nikola

Did you set to true an includeTrashed config option?

Did you set to true an includeTrashed config option?

Thank you.


Fix forkingclusterinvoker npe

What is the purpose of the change
fix #9582
When the cluster uses the forking mode and the provider side all times out ,consumer side will npe
Brief changelog
org.apache.dubbo.rpc.cluster.support.ForkingClusterInvoker
org.apache.dubbo.rpc.cluster.support.ForkingClusterInvokerTest
Verifying this change

Checklist

[x] Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[x] Each commit in the pull request should have a meaningful subject line and body.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[x] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
[ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
[ ] Add some description to dubbo-website project if you are requesting to add a feature.
[ ] GitHub Actions works fine on your own branch.
[ ] If this contribution is large, please follow the Software Donation Guide.

When the cluster uses the forking mode and the provider side all times out, the poll method used in forkingClusterInvoker will time out earlier than the provider side, so it will get null from the queue and throw NPE in the subsequent process. The poll method here should not set the timeout time, but wait for the provider to timeout. When the provider times out, the poll method will correctly obtain an RpcException

Codecov Report

Merging #9612 (ec78ca1) into 3.0 (b8a1398) will decrease coverage by 0.31%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##                3.0    #9612      +/-   ##
============================================
- Coverage     65.66%   65.35%   -0.32%
  Complexity      297      297
============================================
  Files          1189     1189
  Lines         51824    51786      -38
  Branches       7843     7811      -32
============================================
- Hits          34032    33843     -189
- Misses        14117    14246     +129
- Partials       3675     3697      +22

Impacted Files
Coverage Δ

...bbo/rpc/cluster/support/ForkingClusterInvoker.java
86.84% <100.00%> (-0.34%)
:arrow_down:

...dubbo/remoting/zookeeper/ZookeeperTransporter.java
55.55% <0.00%> (-33.34%)
:arrow_down:

...pache/dubbo/common/function/ThrowableFunction.java
71.42% <0.00%> (-28.58%)
:arrow_down:

...ing/zookeeper/curator/Curator5ZookeeperClient.java
42.02% <0.00%> (-25.61%)
:arrow_down:

.../apache/dubbo/rpc/filter/ProfilerServerFilter.java
59.37% <0.00%> (-25.00%)
:arrow_down:

.../remoting/api/SingleProtocolConnectionManager.java
61.53% <0.00%> (-23.08%)
:arrow_down:

...ache/dubbo/rpc/proxy/InvokerInvocationHandler.java
69.81% <0.00%> (-15.10%)
:arrow_down:

...ache/dubbo/remoting/transport/AbstractChannel.java
75.00% <0.00%> (-12.50%)
:arrow_down:

...dubbo/common/status/support/LoadStatusChecker.java
50.00% <0.00%> (-11.54%)
:arrow_down:

...bo/rpc/protocol/dubbo/DecodeableRpcInvocation.java
67.85% <0.00%> (-9.83%)
:arrow_down:

... and 52 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8a1398...ec78ca1. Read the comment docs.

Agree with @juzi214032


Http Headers for individual querys?

I want to use http headers, actually is reference about use and set up over the vue-apollo.js file with httpLinkOptions. but is possible to use different header in an individual query?

Use the context system.
https://www.apollographql.com/docs/link/links/http/#passing-context-per-query
For example:
export default {
  apollo: {
    myQuery () {
      return {
        query: gql`...`,
        context: {
          headers: { foo: this.fooHeader }
        }
      }
    }
  }
}


rewrite entire application code

you should create a dev-a3bz branch firstly and change my merging target main to dev-a3bz, so that i can submit code later and don't influence your branch
v1 package includes source code i has rewrited, and you can continue to develop on your original code

rewrite application read configuration logic
refactor package structure

Thank you for you contribution. But I think you could modify the architecture of package before merging this branch into dev-a3b4.


serveSinglePageApp mime type detection is too aggressive

My app, every.org, is using Cloudflare Workers to host our static bundle. We have URLs for nonprofits, looking like every.org/<nonprofit slug>, and slugs can currently have periods in them. so for instance, the url for the popular nonprofit Vote.org is every.org/vote.org.
However we found out that because cloudflare tries to read mime types to determine if it should tack on index.html or not, and because the mime package decides that a .org extension ought to be a MIME type of application/vnd.lotus-organizer, it decides that this isn't actually supposed to be a page, searches for an asset with that name, can't find it and then hard crashes our website.
We're working around this by not using the serveSinglePageApp helper since it's so simple to implement ourselves, but would be nice if the default either didn't presume so much or was clearer that you could bork your site based on your URL scheme. Thanks!

I’m going to close this issue for now. Going forward, we’ll revisit the assets system as part of Pages/Workers convergence, and will inherit the benefits of the Pages assets system.
In the meantime, Pages is the best choice for deploying sites with static assets.


Deprecate legacy qcstyle module

Summary
Deprecate the legacy module qiskit.visualization.qcstyle, which has been set for deprecation since Terra 0.22. The new location is qiskit.visualization.circuit.qcstyle.

Yeah that's a good point, I'll add that 🙂 (also here for consistency)


diesel generated schema.rs does not include Mapping suffix for enum types

According to the getting started page on Diesel's docs the schema.rs file is typically automatically created/updated by diesel setup or diesel migration run.
The problem is that the schema.rs that it generates does not include the proper Mapping suffix for enum types. This results in an errors similar to this.
I am able to work around this issue by adding a patch_file to diesel.toml, but I would prefer to avoid this.

Yes, this is definitely annoying and I myself came up against it this week. However, it is a result of how Diesel chooses to mangle the names of types it does not recognize - it uses Title_case i.e. foo -> Foo but foo_bar -> Foo_bar. There is no consistent way to map this to the type this crate generates.
I think the real solution would be to offer a PR to Diesel to allow you to specify the name mangling rule in your diesel.toml. However I haven't really thought about how this might work.
As a workaround, if you make sure your enums are always TwoWords then you can use #[DieselType = "Two_words"] and it should work, or else use a patch file as you suggested.

You could also try re-exporting the mapping types in a different modules, as described in #53 . That allows you to alias the mapping types to whatever diesel expects them to be.


Status::Stop when playing DSF files

Not really sure where this problem comes from but I'll try my best to explain.
I've got a basic loop that idles in blocking mode waiting for Subsystem::Player events, matches Status.state and sets the cover on song change, or unsets it if stopped. It all goes well with other types of files, but if I start playing a DSF file I have a surge of player events and Status.state is always State::Stop. Meanwhile CPU usage goes sky high while looping through those events. Is this possibly an issue with MPD itself? How can I provide more info? Any way to clear the idle events queue?
Meanwhile mpc correctly reports state as playing
Edit: I asked if I can clear the events queue because even if I change the song to a known working one, say FLAC, MP3, whatever, I continue getting the accumulated events and state continues being matched to State::Stop.

My bad, I was using unwrap_or_default to get the state. So after unwrapping it I get the actual error:
Result::unwrap()` on an `Err` value: Parse(BadRate(ParseIntError { kind: InvalidDigit }))
So you can ignore the part that concerns matching against Status.state
The result from probing MPD directly:
OK MPD 0.20.0
status
volume: 100
repeat: 0
random: 0
single: 0
consume: 0
playlist: 76
playlistlength: 6
mixrampdb: 0.000000
state: play
song: 0
songid: 51
time: 16:629
elapsed: 16.253
bitrate: 2822
duration: 628.993
audio: dsd64:2
nextsong: 1
nextsongid: 52
OK

Investigating why the call to wait() doesn't block after starting playing a DSD file I found out this.
The first to calls to client.wait(&[mpd::Subsystem::Player]) result in Ok([]). Why is the list empty and not Ok([Player]) as expected?
After those two I start getting Err(Io(Os { code: 32, kind: BrokenPipe, message: "Broken pipe" })), so yeah, that's why no blocking. Still need to figure out where this comes from...

Hi, I had a look and the parser and came up with the following which works for me:
impl FromStr for AudioFormat {
    type Err = ParseError;
    fn from_str(s: &str) -> Result<AudioFormat, ParseError> {
        let mut dsd = false;
        let mut it = s.split(':');
        let rate = it.next().ok_or(ParseError::NoRate).and_then(|v| {
            if v.starts_with("dsd") {
                dsd = true;
                v.trim_start_matches("dsd").parse::<u32>().map(|v| v * 44100 / 8)
            } else {
                v.parse()
            }
            .map_err(ParseError::BadRate)
        })?;
        let bits = if dsd {
            1
        } else {
            it.next().ok_or(ParseError::NoBits).and_then(|v| match v {
                "f" => Ok(0),
                "dsd" => Ok(1),
                _ => v.parse().map_err(ParseError::BadBits),
            })?
        };
        let chans = it
            .next()
            .ok_or(ParseError::NoChans)
            .and_then(|v| v.parse().map_err(ParseError::BadChans))?;
        Ok(AudioFormat { rate, bits, chans })
    }
}

I'm new to Rust so I've no idea if it's idiomatic or silly, or whatever, but that's the gist and it works. I found the info in the MPD user manual, it was missing from the protocol specs, here:
https://www.musicpd.org/doc/html/user.html#configuring-audio-outputs
Anyway, I've still no clue why the connection breaks down on parse error, haven't looked at it. Any idea?

I've found these relevant bits in the MPD code base and I've put them together in a gist so I stop cluttering this feed with overly long snippets: https://gist.github.com/zhelezov/585e0dd20cce521f16cd46da00fa3f68
Basically FromStr should be orthogonal to ToString in AudioFormat.cxx. To achieve this without loss of information I've introduced a small enum: SampleFormat -- have a look at the last file in the gist: https://gist.github.com/zhelezov/585e0dd20cce521f16cd46da00fa3f68#file-test-rs. I've used it for testing. The implementation of FromStr there is still not completely orthogonal though. It returns an error in case of SampleFormat::UNDEFINED and doesn't check if rate or chans equal zero, which they shouldn't.
Note that floating point PCM signal is defined with 32 bit resolution, not zero. Zero is defined as  SampleFormat::UNDEFINED, so an error. You can verify that in the definition of sample_format_size() in SampleFormat.hxx.