overflow: hidden removes titlebar

When using the parameter overflow: hidden it removes the title bar completely, I don't even know why this titlebar-framework is adding a scrollbar, my app main.css has already overflow hidden but for some reason adding titlebar adds a overflow. I also tried to remove my own overflow: hidden and only use it inside the titlebar parameters to remove it, but it removes not only the overflow but also the whole custom-electron-titlebar.
It seems for me when looking at the scrollbar it adds exactly that much to scroll how much the height of the custom-electron-titlebar is so the CET itself is the reason I get a scrollbar I hope there is a fix for this.
EDIT I have found out that "custom-electron-titlebar" is breaking layouts that are made with CSS-Grid, here an simple grid you can add in Electron App to reproduce the bug https://github.com/ireade/holy-grail-css-grid
EDIT When adding the parameter overflow: hidden as I said before the whole custom-electron-titlebar is removed but interesting is that the drag region works so I can drag around the area where the custom-electron-titlebar need to be normally.

View #52


Code Quality: Introducing StandardViewBase to reduce code duplication.

Resolved / Related Issues
Items resolved / related issues by this PR.

Related #10305

What is the purpose of that PR.
A lot of code duplication can be found inside the ViewBrowsers. This PR aims at reducing the duplication by combining the concerned classes inside a standard view.
This preliminary work has for objective to pave the way to a tackle #1928 further down the line.
What has been done

Introducing StandardViewBase to gather up the duplicated code in GridViewBrowser, ColumnViewBase and GridViewBrowser.

Validation
How did you test these changes?

[X] Built and ran the app.

Setting this up as a draft so discussions may ensue to make sure it goes into the right direction.

@lukeblevins

@QuaintMako what are your plans for the current BaseLayout, will that be removed?

@QuaintMako what are your plans for the current BaseLayout, will that be removed?

What I aim with this PR is to reduce the duplication inside GridViewBrowser, ColumnViewBase and GridViewBrowser who share a pretty close philosophy. They do inherit the BaseLayout, but so does ColumnViewBrowser who is completely different to the others. That's why I introduced something between BaseLayout and the three classes I am refactoring.
For now there is no plan around the BaseLayout. But looking at it, we may have ways to simplify it.

Opening up this PR for a first refactoring of the different views.
When it's done and merged, I'll look into defining another object between the Grid and Details layouts to reduce even more the duplication of the code.


In Graphql total count of filtered items is wrong

I'm building a blog and when I bring in my filtered data with Search I get an incorrect return of the quantity that refers to my filter.

In the example in the image I use a search with additional filtering, I get a return that shows that there is no data referring to this search, but the total is 5

Hey @Caio-Mendonca,
this seems to be an issue with Strapi overwriting the pagination meta for the GraphQL types - see this issue for updates.


[KYUUBI #6281][PY] Initialize github action for python unit testing

:mag: Description
Issue References 🔗

This pull request fixes #6281
Describe Your Solution 🔧
The change initialize a CI job to run unit testing on python client, including:

Set up Github Action based on docker-compose
Update test cases and test succeeded for dialect presto and trino
Temporary disabled hive related test due to test cases are not valid, not about connection
Update dev dependencies to support python 3.10
Speed up testing with pytest-xdist plugin

Types of changes :bookmark:

[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Test Plan 🧪
Behavior Without This Pull Request :coffin:
Not able to ran unit test in local and on CI
Behavior With This Pull Request :tada:
Able to run and partially cover a couple of test cases
Related Unit Tests
No
Additional notes
Next action is about fixing failing test cases or considering skipping some of them if necessary

Checklist 📝

[ ] This patch was not authored or co-authored using Generative Tooling

Be nice. Be informative.

@pan3793 not sure this is which type of change, new feature or bug fix?

<EMAIL_ADDRESS>is not allowed to be used in apache/kyuubi. Actions in this workflow must be: within a repository owned by apache, created by GitHub, verified in the GitHub Marketplace, or matching the following: /@[a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9]+, AdoptOpenJDK/install-jdk@, JamesIves/github-pages-deploy-action@5dc1d5a192aeb5ab5b7d5a77b7d36aea4a7f5c92, TobKed/label-when-approved-action@, actions-cool/issues-helper@, actions-rs/, al-cheb/configure-pagefile-action@, amannn/action-semantic-pull-request@, apache/, burrunan/gradle-cache-action@, bytedeco/javacpp-presets/.github/actions/, chromaui/action@, codecov/codecov-action@, conda-incubator/setup-miniconda@, container-tools/kind-action@, container-tools/microshift-action@, dawidd6/action-download-artifact@, delaguardo/setup-graalvm@, docker://jekyll/jekyll:, docker://pandoc/core:2.9, eps1lon/actions-label-merge-conflict@, gaurav-nelson/github-action-markdown-link-che...

Are there any other options that we can consider?

thanks for informing, where can I see that message in full version? @yaooqinn

https://github.com/apache/kyuubi/actions/runs/8868934136
You can navi to this page via Checks tab of this PR

ah thanks a lot, that's why it doesn't appear below

Yeah, We can refer to other Apache repos for available actions

@pan3793 also suggested me another approach adopting this approach
I went for docker-compose first because it provides isolation and flexibility with less set up efforts
let me try this one

docker compose is fine too. and trino provides some pre-built images for Hadoop/Hive/Spark https://github.com/trinodb/docker-images

@sudohainguyen hadoop-testing is for local dev, for CI, docker compose / single docker image approach is preferred. so I suggest u refer to Trino's approach. Apache has strict rules for GitHub Actions plugins, you may need to install docker compose manually or leverage testcontainers(we already use the Java/Scala one)

just switched action provider to docker and seems working now 🙌

ok works now @pan3793
update:

Test succeeded for dialect presto and trino
Temporary disable hive related test due to test cases are not valid, not about connection
Speed up testing with pytest-xdist plugin

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 58.43%. Comparing base (ef28a61) to head (732344a).
 Consider uploading reports for the commit 96ef831 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6343      +/-   ##
============================================
- Coverage     58.47%   58.43%   -0.05%
  Complexity       24       24
============================================
  Files           653      653
  Lines         39880    39880
  Branches       5481     5481
============================================
- Hits          23320    23304      -16
- Misses        14071    14077       +6
- Partials       2489     2499      +10

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

@pan3793 could we process this MR please 👀 ?

Temporary disabled hive related test due to test cases are not valid

Can you elaborate more on it?

yep, can see the result of testing here
there are 2 failed cases but I'm not sure if we should skip them or not, think we can work this out in the next PR?

yes this relates to hive test cases we need to resolve in the upcoming PR 😄

Thanks, merged to master


Removed ExceptionThreadingUtility.  Stack traces are not helpful in an event-loop world

/cc @benjchristensen @KoltonAndrus for review
Issues #289, #290 deal with fixing ExceptionThreadingUtility to correctly attach stack traces (at very high cost).  This doesn't seem worthwhile, especially since, even if we did that properly, they would become useless as soon as Hystrix is used in an event-loop system like Netty.

Hystrix-pull-requests #203 SUCCESS
This pull request looks good

I'm fine with removing it.

:+1: on the changes.
:-1: on non-deterministic tests that I wrote.


Background issue with React native 0.61-rc3

Hello
After investigating with @Trobyss we found an issue with styled-components after migrating on 0.61-rc3 to test on ANDROID.
ANDROID ONLY
"react": "16.9.0",
"react-native": "0.61.0-rc.3",
"styled-components": "^4.3.2"

You can freely switch between Bug and BuggingView to see the difference.
The text is correctly displaying above the background in absolute, but not the background of the text container.
Without styled-components, this works.
import React from "react";
import { Text, View } from "react-native";
import styled from "styled-components/native";

const Bug = () => {
  return (
    <View style={{ flex: 1 }}>
      <BuggingView />
      <PageWrapper>
        <Text>
          This should appear above backgroundThis should appear above background This should appear above background This should appear
          above above background This should appear above background This should appear above background This should appear above background
          This This should appear above background This should appear above background This should appear above background This should
          appear above background This should appear above background This should appear above background This should appear above
          background This should appear above background This should appear above background This should appear above background This should
          appear above background This should appear above background This should appear above background This should appear above
          background This should appear above background This should appear above background This should appear above background This should
          appear above background This should appear above background This should appear above background This should appear above
          background This should appear above background
        </Text>
      </PageWrapper>
    </View>
  );
};

const BuggingView = styled.View`
  height: 200;
  position: absolute;
  background-color: blue;
  top: 0;
  right: 0;
  left: 0;
`;
const PageWrapper = styled.View`
  background-color: red;
  padding: 20px;
  border-radius: 8px;
  flex: 1;
  margin: 20px;
`;

const NotBug = () => (
  <View style={{ flex: 1 }}>
    <View style={{ height: 200, backgroundColor: 'blue', position: "absolute", top: 0, right: 0, left: 0 }} />
    <View style={{ backgroundColor: "red", padding: 20, flex: 1, margin: 20 }}>
      <Text>
        This should appear above backgroundThis should appear above background This should appear above background This should appear above
        above background This should appear above background This should appear above background This should appear above background This
        This should appear above background This should appear above background This should appear above background This should appear above
        background This should appear above background This should appear above background This should appear above background This should
        appear above background This should appear above background This should appear above background This should appear above background
        This should appear above background This should appear above background This should appear above background This should appear above
        background This should appear above background This should appear above background This should appear above background This should
        appear above background This should appear above background This should appear above background This should appear above background
      </Text>
    </View>
  </View>
);

export default Bug;

Any idea what would cause that ? as you can see this works with latest expo version : https://snack.expo.io/@afigueiredo/1fe053
Best regards

When you write flex: 1 in css-to-react-native, it expands to flex-grow: 1; flex-shrink: 1; flex-basis: 0 to match CSS.
The flex property in react-native is kinda legacy, in that it differs from the web standards. But their flex-grow, shrink and basis properties do match the web standards

Hi ! I attach a screen

I'll need to see both screenshots 😄
Did changing flex not work? Try playing around with that a bit. I'm not totally sure what you're trying to do, so I can't really give pointers here

So :
This doesn't work : (text is above but red is behind blue)

import React from "react";
import { Text, SafeAreaView } from "react-native";
import styled from "styled-components/native";

const Venue: React.FC<{}> = () => (
  <SafeAreaView style={{ flexGrow: 1 }}>
    <BuggingView />
    <PageWrapper>
      <Text>
        This should appear above backgroundThis should appear above background This should appear above background This should appear
        above above background This should appear above background This should appear above background This should appear above background
        This This should appear above background This should appear above background This should appear above background This should
        appear above background This should appear above background This should appear above background This should appear above
        background This should appear above background This should appear above background This should appear above background This should
        appear above background This should appear above background This should appear above background This should appear above
        background This should appear above background This should appear above background This should appear above background This should
        appear above background This should appear above background This should appear above background This should appear above
        background This should appear above background
        </Text>
    </PageWrapper>
  </SafeAreaView >
);
  const BuggingView = styled.View`
    height: 200;
    position: absolute;
    background-color: blue;
    top: 0;
    right: 0;
    left: 0;
  `;
  const PageWrapper = styled.View`
    background-color: red;
    padding: 20px;
    border-radius: 8px;
    flex-grow: 1;
    flex-shrink: 1;
    flex-basis: 0;
    margin: 20px;
  `;

But the exact same code without styled :

import React from "react";
import { Text, SafeAreaView, View } from "react-native";

const Venue: React.FC<{}> = () => (
  <SafeAreaView style={{ flexGrow: 1 }}>
    <View style={{ height: 200, backgroundColor: 'blue', position: "absolute", top: 0, right: 0, left: 0 }} />
    <View style={{ backgroundColor: "red", padding: 20, flexGrow: 1, flexShrink: 1, flexBasis: 0, margin: 20 }}>
      <Text>
        This should appear above backgroundThis should appear above background This should appear above background This should appear above
        above background This should appear above background This should appear above background This should appear above background This
        This should appear above background This should appear above background This should appear above background This should appear above
        background This should appear above background This should appear above background This should appear above background This should
        appear above background This should appear above background This should appear above background This should appear above background
        This should appear above background This should appear above background This should appear above background This should appear above
        background This should appear above background This should appear above background This should appear above background This should
        appear above background This should appear above background This should appear above background This should appear above background
      </Text>
    </View>
  </SafeAreaView >
);

As u can see, it's not related to flex box implementation.
Before 0.61-rc3 this work.
Any idea ?
Trobyss'

Thanks for those screenshots. So am I right in thinking the layout is correct, but the order is wrong. Does adding some z-indices fix it?

Nothing at all for the background :(

@jacobp100
I tried to update the app I'm working on to 0.61.0, and I'm seeing the same thing: the styles are messed up on Android, but not iOS.
I'm using CSS modules instead of styled components.

I found this from https://github.com/facebook/react-native/issues/26544

if view has a borderRadius other than undefined, then when switching to another screen, the view with borderRadius is rendered under all other views, even if you specify zIndex. Until you reload, all views on all screens with borderRadius (including the root) will be broken.

Looks like a serious React Native bug

Thanks for finding that — @Trobyss could you see if removing the border radius fixes the issue?

I created a new 0.61 and I'm trying to the examples from @Trobyss, but I'm not seeing the bug on Android using those examples.

I created a new 0.61 project and I'm trying to the examples from @Trobyss, but I'm not seeing the bug on Android using those examples.

@kristerkari i don't know if it helps, but i'm facing strange behaviour only on Android API Level 26
I think also this bug is related:

i don't know if it helps, but i'm facing strange behaviour only on Android API Level 26

I tried on two emulators with API 26, but still could not reproduce the bug with the examples from this thread. Maybe someone else could try to do the same thing and see if the bug can be reproduced?
I know that there is something broken with 0.61 because I saw styles being broken on Android in the other project that I updated from 0.60.

Removing border-radius seems to fix the issue for this example 👍

const Bug = () => {
  return (
    <View style={{ flex: 1 }}>
      <BuggingView />
      <PageWrapper>
        <Text>
          This should appear above backgroundThis should appear above background This should appear above background This should appear
          above above background This should appear above background This should appear above background This should appear above background
          This This should appear above background This should appear above background This should appear above background This should
          appear above background This should appear above background This should appear above background This should appear above
          background This should appear above background This should appear above background This should appear above background This should
          appear above background This should appear above background This should appear above background This should appear above
          background This should appear above background This should appear above background This should appear above background This should
          appear above background This should appear above background This should appear above background This should appear above
          background This should appear above background
        </Text>
      </PageWrapper>
    </View>
  );
};

const BuggingView = styled.View`
  height: 200;
  position: absolute;
  background-color: blue;
  top: 0;
  right: 0;
  left: 0;
`;
const PageWrapper = styled.View`
  background-color: red;
  padding: 20px;
  /* border-radius: 8px; */
  flex: 1;
  margin: 20px;
`;

https://github.com/react-native-community/releases/issues/146#issuecomment-536548800

I'm going to close this issue, but you're free to continue the discussion here if you wish


Dashboard G$ total suply should read info from mainnet

[x] upgrade to contracts v2
[x] ropsten + ethereum settings to possible networks
[x] create another instance of web3 called mainnetWeb3

network = fuse. use network fuse-mainnet for Contracts Address and use ropsten
network = staging. use network staging-mainnet for Contracts Address and use ropsten
network = production. use network production-mainnet for Contracts Address and use ethereum

[x] configure GoodDollar contract for totalSupply to work with mainnetWeb3 (GoodDollar used for other stats should still work with the regular web3)

The new branch created within required changes - https://github.com/GoodDollar/GoodDashboard/tree/next

@AnastasiiaOdnoshevna this can be tested on gooddashboard.herokuapp.com
see PR

@sirpy as I got it should be tested on the prod?

we have goodnext.netlify which is phase1 qa env

@sirpy @yaroslav-fedyshyn-nordwhale  Data in the charts or boxes is changed if the user claims the G$ or transfers to another wallet
Checked on NEXTorg V1.1.2
Desktop: Windows 10 // Google Chrome  84.0.4147.135


Improved Comments/Documentation

Majority of repo is lacking in terms of comments

I can do this.

@Reep236 could you write the comment documentation for the channelToData and dataToChannel functions. Just because you wrote them, and I don't want to document it wrong. I can do the rest of the scripts and functions though.

Alright. Seems like the comment documentation is done. I guess it is time to close this issue.


feat: next website

new cert-manager website based on next.js
Needs an .env file or environment variables set up:
DOCS_FALLBACK="README"
DOCS_PATH="content"
DOCS_FOLDER="docs"
NEXT_PUBLIC_ALGOLIA_KEY=""
NEXT_PUBLIC_ALGOLIA_ID=""
NEXT_PUBLIC_ALGOLIA_INDEX="docs"
DOCS_USE_MDX=false

Change request
keyboard navigation is incomplete on the refresh
http://localhost:3000/docs/

while the select for version is focused, pressing enter should open the dropdown (space works, but not enter)
the menu items on the left side are targetable by tabbing, but lack has no visible focus indicator
search box has no focus indicator

Thanks for the accessibility fixes.
I'd like to have the browser-native :focus outline property.
I think we can simply remove this CSS rule from global.scss:
a:focus, button:focus, input:focus, select:focus {
  outline: 2px solid transparent;
  outline-offset: 2px;
}

After that I am happy with the visual stuff.

I'd like to have the browser-native :focus outline property.

@jahrlin while totally possible, I'm not 100% sure that's what we want.
For example, this is how the search box would end up looking when focused (whether by keyboard or mouse).

It is quite common to customise the :focus styles. In fact even the current cert-manager site has custom :focus styles.
However, if you prefer to have the browser control that, we're happy to make the change

Having some trouble running the website locally. I ran the following commands at the root of the repo at this PR, but my browser is stuck "loading".
npm i
npm dev run

->
><EMAIL_ADDRESS>dev
> next dev

ready - started server on <IP_ADDRESS>:3000, url: http://localhost:3000
info  - Loaded env from /home/josh/go/src/github.com/cert-manager/website/.env

$ npm version
{
  'cert-manager.io': '2.0.0',
  npm: '8.4.1',
  node: '17.3.0',
  v8: '<IP_ADDRESS>-node.12',
  uv: '1.42.0',
  zlib: '1.2.11',
  brotli: '1.0.9',
  ares: '1.18.1',
  modules: '102',
  nghttp2: '1.46.0',
  napi: '8',
  llhttp: '6.0.4',
  openssl: '1.1.1m',
  cldr: '40.0',
  icu: '70.1',
  tz: '2021a3',
  unicode: '14.0'
}

As an aside, it doesn't look like npm is respecting SIGINTs (ctrl-C), and I have to close it using SIGKILL.

I think @JoshVanL's comment above might need addressing before this can be merged - I've had the same issue before, as has Joakim, and all 3 of us on different machines.

There are 3 public key paths which are served on the cert-manager website today. The following two work on a local checkout:

https://cert-manager.io/public-keys/cert-manager-keyring-2021-09-20-1020CF3C033D4F35BAE1C19E1226061C665DF13E.gpg
https://cert-manager.io/public-keys/cert-manager-pgp-2021-09-20-1020CF3C033D4F35BAE1C19E1226061C665DF13E.asc

This one doesn't work on a local checkout and appears to have been deleted.  This file can't move - it needs to exist at this path:

https://cert-manager.io/public-keys/cert-manager-pubkey-2021-09-20.pem

I found a great doc explaining the requirements on the cert-manager project's website when mentioning Jetstack as the "origin company": https://github.com/cncf/foundation/blob/main/website-guidelines.md
Several people have mentioned to me about the "Enterprise" heading on the refreshed site, and I think changing that to "Support" might be good, as well as changing the path to "/support" (it's currently "/enterprise").
In addition, the "Find Out More" link on that page is currently just a link to the same page: https://cert-manager.zntrd.cloud/enterprise/

In addition, the "Find Out More" link on that page is currently just a link to the same page: https://cert-manager.zntrd.cloud/enterprise/

What URL should this be pointing to pls?

I think https://www.jetstack.io/jetstack-secure/ would be a good start; we can always change it down the road.

I think @JoshVanL's comment above might need addressing before this can be merged - I've had the same issue before, as has Joakim, and all 3 of us on different machines.

There was a similar issue before. A clean checkout resolved the issue.

"Enterprise" renamed to "Support"
"Find out more" link updated

I'd like to have the browser-native :focus outline property.

@jahrlin while totally possible, I'm not 100% sure that's what we want. For example, this is how the search box would end up looking when focused (whether by keyboard or mouse).

It is quite common to customise the :focus styles. In fact even the current cert-manager site has custom :focus styles. However, if you prefer to have the browser control that, we're happy to make the change

Most important to me is that there is a high contrast indicator for focus, which we have - so I'm happy with the current state!
Holding for others
/lgtm
/hold

/remove-lgtm
I think the substance here is pretty much good to go, but I don't think this is ready to merge into master as is:

The deploys will fail without changing some netlify config at the least
There are changes on master which haven't been incorporated into the new site yet, leading to content "disappearing" if this goes live in its current state. It won't be hard to update this PR to include the changes, but that will need doing.
This PR (intentionally) doesn't include a solution for older versions of docs, and so merging to master means we'd lose old content until that solution is in place (which could be us doing the changes I described in a doc)

I think we need a deployment plan for this to be sure we don't cause an outage of the cert-manager website, and at the very least we might need a temporary branch in this repo (e.g. next-website) if the old docs are going to be merged in a separate PR.
If we do what I suggested in the doc - which I'll get started on now - that'll solve point number 3 for us quite nicely.

I changed the base to "next-website" so we can take a more careful approach to merging, and so that we can add new docs to that branch after they've been run through the script I've been working on :+1:

I've manually cherry picked the latest commit from zentered:feat/next-website to the next-website branch on the cert-manager/website repo, without any content. As such I think this PR is redundant and I'll close it; we can work against the next-website branch :+1:


Basic support for hubspot workflows

Adding functionality to add a contact to a workflow by email.

@cbisnett Would love a PR review when you get a chance. Thanks so much!


iOS: default to iPhone X simulator

We currently default to an iPhone 5S simulator. We should move this forward to iPhone X now that we require Xcode 9.
This is independent of device switching (#21).

It seems that the Xamarin team has discontinued this program? What a wonderful and powerful program.


Write a C program to convert hexadecimal to binary

Description
Write a C program to convert hexadecimal to binary
Hexadecimal is a base-16 number system. It uses sixteen digits: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, A, B, C, D, E, and F. The digits are called hexits. A hexit is the smallest unit of information in a computer. A hexit can be used to represent a single value, such as 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, A, B, C, D, E, or F, or it can be used to represent a single state, such as on or off.
Binary is a base-2 number system. It uses only two digits: 0 and 1. The digits are called bits. A bit is the smallest unit of information in a computer. A bit can be either 0 or 1. A bit can be used to represent a single value, such as 0 or 1, or it can be used to represent a single state, such as on or off.
To convert a hexadecimal number to binary, we can use the following algorithm:

Convert the hexadecimal number to decimal.
Convert the decimal number to binary.

Input  : A
Output : 1010

How to contribute

Save the solution in ConvertHexadecimalToBinary.c file
Add ConvertHexadecimalToBinary.c file in convert-hexadecimal-to-binary folder

!assign


[Snyk] Upgrade @salesforce/core from 2.36.1 to 2.36.3

This PR was automatically created by Snyk using the credentials of a real user.Snyk has created this PR to upgrade @salesforce/core from 2.36.1 to 2.36.3.

:information_source: Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.

The recommended version is 2 versions ahead of your current version.
The recommended version was released 21 days ago, on 2022-04-21.

Release notes

Package name: @salesforce/core

2.36.3 - 2022-04-21chore(release): 2.36.3 [ci skip]

2.36.2 - 2022-04-20chore(release): 2.36.2 [ci skip]

2.36.1 - 2022-04-14chore(release): 2.36.1 [ci skip]

    from @salesforce/core GitHub release notes

Commit messages

Package name: @salesforce/core

02da38c chore(release): 2.36.3 [ci skip]
16a5423 fix: log rotation errors (#562)
b19587c chore: use salesforce-cli context
b86faa2 chore(release): 2.36.2 [ci skip]
3e8d108 Merge pull request #567 from forcedotcom/bm/W-10657353
845fb17 Merge branch 'main' into bm/W-10657353
8e2900b chore: bump to 2.36.2
4a940f4 Merge pull request #535 from forcedotcom/bm/W-10657353
e6a2871 Merge branch 'main' into bm/W-10657353
4073395 chore: use optional chain
fa3b9cc test: add plugin-org to the list of nuts
ad09621 Merge remote-tracking branch 'origin/main' into bm/W-10657353
bce2a1a chore: public->private methods
0fde57d test: update test
36e531b chore: make methods public
4e6acde test: remove only
3dd61e3 test: for new command
2c0390b chore: remove logs
4fbcb9f chore: new sandboxStatus method

Compare

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information:
🧐 View latest project report
🛠 Adjust upgrade PR settings
🔕 Ignore this dependency or unsubscribe from future upgrade PRs

Updated in May 22


[AutoDiff] Add a missing cleanup for a zero value with differentiating 'store'.

Zeros emitted when differentiating a store needs to be cleaned up.

@swift-ci please test tensorflow

Adding a test.

@swift-ci please test tensorflow

@swift-ci please test tensorflow

@swift-ci please test tensorflow

They are unchanged. More tests coming.


Pagination arrows are missplaced

The arrow should be narrower and aligned with 'Older'.

Fixed with https://github.com/ribice/kiss/commit/64b18ec9033209186e9ca11c6bd71dbe910214cb


nfs-ganesha: 6.1 -> 6.2

Changelog: https://github.com/nfs-ganesha/nfs-ganesha/releases/tag/V6.2
mostly a bugfix release.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 351668

x86_64-linux

:white_check_mark: 3 packages built:

nfs-ganesha
nfs-ganesha.man
nfs-ganesha.tools


Add dateCreated field to AIX simple_components.json

We should also add a way to show this information in the help widget, similar to how we show the HELPURL for the extension.


Leaking goroutines

This is unrelated to #1004, as this also appears in 1.16.0.

Apparently comes from our usage of logrus. Again, I got a branch fixing that, but I need to bring another solution that doesn't change the main loop. If anyone has a solution (I don't have much time to look at this rn), please feel free to propose a patch.

It does not leak in 1.16.0 for us. We rolled back to that since .1 leaks both goroutines and memory:
here is a graph of go_goroutines{pod=~"kured.*"} showing the gooutine leak. The other issue already have memory graph.

The leak is from every time NewCommand i called you leak goroutine in logrus.WriterLevel

You want me to make a PR with the fix?

The leak is from every time NewCommand is called you leak goroutine in logrus.WriterLevel
This might also be related to the memoryleak.

From my quick glance a few days ago, that's EXACTLY what I understood.
In my fork, I am replacing quite a few calls with slog. The refactor is a bit big, so I prefer NOT bringing this refactor in as is, and I prefer remplementing a fix.
I am fine with you committing a PR, it will get us to land this quicker, IMO. When do you think you can propose this? I am available for a bit in the next hours, which should be enough to fix this with your help.
In terms of the memory leak, my guess was that it's not completely related. (The fact that we also append in the rebootAsRequired loop is crazy, and is also worth a fix).
Yet, IF the memory leak appeared in 1.16.1 (and a revert of 1.16.0 fixes the issue), this needs further investigation: Logrus didn't change. We changed go version and prom client. Go version could have an impact.
My guess is that we fix the goroutine leak first, then work on the rebootAsRequired (I would love a review if you're okay), then with thie cleaned up, we can find other big items.
Can you confirm that 1.16.0 is NOT having a memory leak for you @jonaz  ?

@evrardjp yes 1.16.0 have no memory or goroutine leaks. It might be related to go version yes.
Looking at the code it's strange it ever worked.. should have leaked always.
Im in CET timezone and can create PR tomorrow. We run kured on hundreds of vms so this impacted us a lot since we forgot limits on the deployment.

Sorry to hear that.
I just arrived home, so i can push something real quick.


--doctool should create directories if they don't exist

Running godot --doctool outside the build directory has this output:
Loading docs..
Loading docs from: ./modules/gdnative/doc_classes
Loading docs from: ./modules/stb_vorbis/doc_classes
Loading docs from: ./modules/opus/doc_classes
Loading docs from: ./modules/bullet/doc_classes
Loading docs from: ./modules/gdscript/doc_classes
Loading docs from: ./modules/gridmap/doc_classes
Loading docs from: ./modules/mobile_vr/doc_classes
Loading docs from: ./modules/enet/doc_classes
Loading docs from: ./modules/regex/doc_classes
Loading docs from: ./modules/theora/doc_classes
Loading docs from: ./modules/webm/doc_classes
Loading docs from: ./modules/visual_script/doc_classes
Loading docs from: ./doc/classes
Merging docs..
Erasing old docs at: ./doc/classes
Erasing old docs at: ./modules/bullet/doc_classes
Erasing old docs at: ./modules/enet/doc_classes
Erasing old docs at: ./modules/gdnative/doc_classes
Erasing old docs at: ./modules/gdscript/doc_classes
Erasing old docs at: ./modules/gridmap/doc_classes
Erasing old docs at: ./modules/mobile_vr/doc_classes
Erasing old docs at: ./modules/opus/doc_classes
Erasing old docs at: ./modules/regex/doc_classes
Erasing old docs at: ./modules/stb_vorbis/doc_classes
Erasing old docs at: ./modules/theora/doc_classes
Erasing old docs at: ./modules/visual_script/doc_classes
Erasing old docs at: ./modules/webm/doc_classes
Generating new docs..
ERROR: save_classes: Can't write doc file<EMAIL_ADDRESS>   At: editor/doc/doc_data.cpp:964.

It gives up if one of the directory paths doesn't exist, so I have to manually create all of them just to get the command to succeed. Is there any reason why the directories aren't created automatically?

On a related note, it seems that any docs generated with --doctool are missing all class and function descriptions. I guess there's a lot of work to be done in that area.

On a related note, it seems that any docs generated with --doctool are missing all class and function descriptions. I guess there's a lot of work to be done in that area.

Well, the descriptions are stored in the XML itself, so if the description wasn't there before (or if the file didn't exist) the generated parts won't have any description.

Problem solved. Solution: I'm a dumdum.
I thought --doctool simply dumped the documentation embedded in the executable as-is so it can be used in an external tool (which is what I was trying to do).  I guess it's meant to be used only when developing the engine. In that case, my issue with the directories is pretty much invalid because there's no reason to run it outside the build directory anyway.
I'm going to go ahead and close this issue and pretend it never happened.

Well it should still create the directories if missing.

Well it should still create the directories if missing.

Seems to me that there aren't any situations where the directories wouldn't already exist, though. Really what should happen is the line in godot -h explaining --doctool should be made less misleading, so other poor saps like myself don't try to use it for some unintended purpose.
It would be nice if --doctool could be used in the way I was trying to use it (generating standalone docs), but that seems like a separate issue entirely.


Move List and Item Operations into Separate Reducer and Context

Create a context for list/item data.
Create reducer for list/item operations.

After #202 is completed, appReducer can be renamed to listsReducer.

Commit: https://github.com/johneastman/todo/commit/eb7441c327fc80db9f0644b6f112ab30c96984b9


Resample portfolio data to consistent time-interval before charting.

Should resolve https://github.com/miguelmota/cointop/issues/157

Moving to #180


Set the distance from the photon field

Hello @andreatramacere,
how do I fix the distance of the blob from the target photon field?
For example if I want to consider the external Compton on the dusty torus I get, from the show_pars():
model parameters:
 Name             | Type                 | Units            | value         | phys. boundaries              | log
-------------------------------------------------------------------------------------------------------------------
 B                | magnetic_field       | G                | +1.000000e+00 | [+0.000000e+00,No           ] | False
 N                | electron_density     | cm^-3            | +1.302546e+03 | [+0.000000e+00,No           ] | False
 R                | region_size          | cm               | +1.600000e+01 | [+0.000000e+00,+3.000000e+01] | True
 R_DT             | DT                   | cm               | +5.000000e+18 | [+0.000000e+00,No           ] | False
 T_DT             | DT                   | K                | +1.000000e+02 | [+0.000000e+00,No           ] | False
 beam_obj         | beaming              |                  | +1.000000e+01 | [+1.000000e+00,No           ] | False
 gmax             | high-energy-cut-off  | Lorentz-factor   | +1.000000e+05 | [+1.000000e+00,+1.000000e+15] | False
 gmin             | low-energy-cut-off   | Lorentz-factor   | +1.000000e+02 | [+1.000000e+00,+1.000000e+05] | False
 p                | HE_spectral_slope    |                  | +2.800000e+00 | [-1.000000e+01,+1.000000e+01] | False
 tau_DT           | DT                   |                  | +1.000000e-01 | [+0.000000e+00,+1.000000e+00] | False
 z_cosm           | redshift             |                  | +6.959965e-02 | [+0.000000e+00,No           ] | False
-------------------------------------------------------------------------------------------------------------------

How do I evaluate the spectrum from different distances of the blob from the torus?
The Broad Line Region seems to have this R_H
 R_H              | Disk                 | cm               | +1.000000e+17 | [+0.000000e+00,No           ] | False

But I do not find the equivalent for the Torus.
Cheers!

Hi Cosimo, I need to add R_H to the DT in the python interface, thanks for spotting this problem! I will do it as soon as possible. Is it urgent?
Thanks a lot for the feedback

No it is not urgent.
Thanks!

Quick fix:
`j=Jet()
j.add_EC_component('EC_DT')
j._blob.R_H=1e21
`
R_H will not be show in show_pars() but will be effective. It is the distance of the  blob from the BH in cm

Thank you!

Ehm, I think it is not working
from jetset.jet_model import Jet
import matplotlib.pyplot as plt

jet = Jet(name="test", electron_distribution="pl")
jet.add_EC_component('EC_DT')

fig = plt.figure()

for r in (1e16, 1e17, 1e18):
    jet._blob.R_H = r
    jet.eval()
    ene, sed = jet.get_SED_points(name="EC_DT")
    plt.loglog(ene, sed, label=f"r={r}")

plt.ylim([1e-15, 1e-12])
plt.legend()
plt.show()
fig.savefig("test.png")

But really no rush, just wanted to point out.

As long as you are within the Torus radius, the photon field does not change (Ghisellini & Madau 1996). To see the effect you  have to start to approach R_DT (that as default is 5e18). But I have to admit that I did not check if the transition between R_H~<R_DT and R_H>~R_DT is correct. There is transition region that should  be interpolated.
 from jetset.jet_model import Jet
import matplotlib.pyplot as plt

jet = Jet(name="test", electron_distribution="pl")
jet.add_EC_component('EC_DT')

fig = plt.figure()

for r in (1e16, 1e17, 1e18,4E18,5E18,6E18,1E19,2E19):
    jet._blob.R_H = r
    jet.eval()
    ene, sed = jet.get_SED_points(name="EC_DT")
    plt.loglog(ene, sed, label=f"r={r}")

plt.ylim([1e-19, 1e-12])
plt.legend()
plt.show()
fig.savefig("test.png")

Hello @andreatramacere ,
Can you please tell me actually what is this disk parameter R_H and what is its physical meaning?
I found that the EC_disk component is very sensitive to the change in R_H. As I have no clue about this parameter, I am not confident enough to change its value.
It will be helpful if you give me some idea about R_H and its usage.

Hi @abhradeep-1996,
R_H is the distance between the BH and the emitting region. If R_H <R_BLR_in
(the BLR is modelled as a spherical shell with  inner radius R_BLR_in and outer radius R_BLR_out) or  R_H <R_DT (the photon field of the Dusty Torus is modelled as sphere of radius R_DT, even though the name seems misleading), you should get a constant energy density from the external photon field. As long as R_H start to get larger then R_BLR or R_DT, then the corresponding EC component should start to decrease. Of course, if R_H >R_BLR_out but R_H<D_T, then only the EC from the dusty torus will decrease. Anyhow, I am releasing a new version of the code, with an improved documentation and also a better implementation of the external Compton.
Please, do not hesitate to contact me if you have any doubt, you can also share jupyther notebooks if it is more convenient to you.
Cheers
Andrea

Thank you very much Sir for solving my confusion !


native pseudoclass overrides use 'initial' instead of the base default

I added a test that should fail in 'native pseudoclass style overriding block default styles when they must override a StyleMap style with "initial"'

Fixed


Generics: PECS Principle vs. Function Declaration

Hello, I've been grappling with some confusion regarding Java generics and am having trouble reconciling the principles of PECS (Producer-extends, Consumer-super) with the declaration syntax in Java's Function interface. I understand that PECS dictates using extends for producers (when reading from a collection) and super for consumers (when adding to a collection), but I'm unsure why the declaration Function<? super T, ? extends R> is structured the way it is. It seems counterintuitive to me.
My guess is that 'super' and 'extends' wildcards in Function<? super T, ? extends R> are related to the types that the function can accept as input (super T) and produce as output (extends R), and not adding or retrieving elements from collections?
Could someone shed some light on this or point me in the right direction? Thank you!

My guess is that 'super' and 'extends' wildcards in Function<? super T, ? extends R> are related to the types that the function can accept as input (super T) and produce as output (extends R), and not adding or retrieving elements from collections?

yes, that's right. when applying the PECS principle, use the perspective of the generic object in question - so for a Function, the Function consumes an input (? super T) and produces an output (? extends R). I too still find the PECS principle in general a little unintuitive, but maybe this perspective helps

Well said @samuelneo!

@samuelneo Yep, that does make more sense, thank you!


Cannot assign to read-only property 'config'

We're seeing this crash in react-native-gesture-handler when using the Zoom component inside a FlatList created with createZoomListComponent() and scrolling through the list.
The crash coincides with our upgrade from React Native 0.67 to 0.70 but the causality is not clear.
We're using react-native-reanimated-zoom v0.3.3

I found a way to fix this.
Instead of having the Zoom component surrounding each photo item in the FlatList, we surrounded the entire FlatList with Zoom and the crash is gone.


Re-open atom-runner window on start-up

It would be nice to re-open the atom-runner window the next time Atom is opened (only when it was open when Atom was closed, of course).
Is it even possible for an atom package to do that?

I think it might be possible, but I'm not sure. If you opened a PR that added this behavior I would likely accept it.

Closing. If you are interested in this, please submit a PR.


Allow automated allocation of external addresses (forward, load-balancers)

In a multitenant environment running with OVN, if one user in a project associates the external IP with the instance via forward - other users in other projects won't be able to track it. In this case one can never predict which IP they can pick for creating new forward.

Allowing seeing IP addresses consumed by other users on the system doesn't seem like a good approach as that causes unnecessary information leakage. However having the ability to just have LXD allocate an address from what's available would be quite valuable and would actually allow restricting things further so less trusted projects wouldn't even be allowed to request a particular address at all but instead only have access to automated allocation.

I believe what's even more important is that there is no concept of "port" related to forward. Due to this reason the assets are not deleted upon deletion of the VM, hence the IP addresses are not being released when the respective VM and port are being deleted.

Well, I agree that the floating IPs can be owned by the users irrespective to whether they are assigned to the VM. But in this case they should be in the pool of "available" address and not just statically associated with the internal IP.


Fix errors in construction of bound Proxies

Revisiting boundProxies found what I hope are the right fixes this time.
This PR addresses the following issues:

Constructing bound Proxy would call construct trap twice or if there wasn't a construct trap targetFunction would be called twice,
Reflect.construct in construct trap of bound Proxy would attempt to construct "this" and error as it's not a constructor (issue 4918)
Constructing a bound function via Reflect with a newTarget would ignore the newTarget.

Added test cases for these points and some related patterns that do work but weren't being tested and  which some other ways of fixing points 1-3 would break.
Also corrected the baseline for proxytest9.js which was testing the incorrect behaviour of construct traps for bound proxies being called twice.
The interaction of bound functions and proxies is complex enough that I'm afraid I'm confident that there'll be one or more bugs left after this, but this should be a reasonable improvement from the current state.
@sethbrenith I borrowed your test case from 4918 as the starting point for the cases here, I hope that's ok. Note I split it into two as it highlighted 2 different issues.
Fixes: #4918
Fixes: #5151

I've reworked this to fix and test #5151 as well.
I have however removed the piece around de-referencing a BoundFunction newTarget of a proxy back to the original function - I'm not at all sure that piece was right; and it isn't relevant to fixing the original cases - it was to do with a proxied bound function (and also maybe a bound bound function); but I'm going to leave those cases for now.

    Var targetFunction = boundFunction->targetFunction;

Could we specify up here that targetFunction is a RecyclableObject*, rather than using an unsafe cast later?

Refers to: lib/Runtime/Library/BoundFunction.cpp:130 in 27b18ff. [](commit_id = 27b18ff0ae201873cbf5964fcbab4c88e14647f3, deletion_comment = False)

Would you mind adding a test case for the issue #5151 that you also fixed?

I thought that #5151 was tested by doing the strictEqual asserts for the 2 Reflect.construct cases in the file I've added hence why I didn't add an explicit separate case.

I couldn't repro #5151 with proxies involved, only with a plain bound function.

In reply to: 388975046 [](ancestors = 388975046)

...or maybe I just wasn't trying hard enough. I probably got confused by the areEqual stuff. If you think the current test coverage is enough, then I'm fine with it.

In reply to: 388975642 [](ancestors = 388975642,388975046)


Runtime error on hugginface

https://huggingface.co/spaces/JackAILab/ConsistentID

@jolic The bugs have been fixed, thanks to the help of ZEROTeam. This is caused by the version upgrade of some packages ~


add account info alert

alert user don't transfer real token to the accounts

https://github.com/RetricSu/offckb/pull/65


Error in Success callbackId: PushNotification478999427 : TypeError: Cannot read property 'querySelector' of null

Expected Behaviour
when i with phonegap with app developer i am getting above Error
Actual Behaviour
 Error in Success callbackId: PushNotification1454691342 : TypeError: Cannot read property 'querySelector' of null
Reproduce Scenario (including but not limited to)
Sending a notification to  Android device while device is open
Platform and Version (eg. Android 5.0 or iOS 9.2.1)
Android 5.1.1
(Android) What device vendor (e.g. Samsung, HTC, Sony...)
Moto G (3d generation)
Cordova CLI version and cordova platform version
Plugin version
phonegap-plugin-push version 1.8.0

There is no querySelector code in the plugin, that should be yours


Implemented file dialog and ability to swap between tracks.

The debugger will now show a browse button allowing users to change track.

Latest version

I've also changed the


Choose the folders pinned to sidebar

Is your feature request related to a problem? Please describe.
Feature request: Choose the folders pinned to sidebar through the settings page (like "Pin OneDrive to the sidebar)
Describe the solution you'd like
Add ability to pin/unpin folders (desktop, documents, downloads, music...) via settings > preferences.
Add Fluent UI icons
Describe alternatives you've considered
Additional context

@SimoneRaspagni You can already unpin items from the sidebar by right clicking on them. You can also pin an item yourself by right clicking on a directory, and clicking on the pin option.


[Bug]fix flink 1.19 app mode

Purpose of the pull request

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:

same problem


katago: 1.9.1 -> 1.10.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/lightvector/katago/releases.
meta.description for katago is: "Go engine modeled after AlphaGo Zero"
meta.homepage for katago is: "https://github.com/lightvector/katago"
meta.changelog for katago is: ""
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
/nix/store/3ijwl9bfkqdc9nrvlv2cv06s22qhqr1l-katago-1.10.0/bin/katago passed the binary check.
1 of 1 passed binary check by having a zero exit code.
1 of 1 passed binary check by having the new version present in output.
found 1.10.0 with grep in /nix/store/3ijwl9bfkqdc9nrvlv2cv06s22qhqr1l-katago-1.10.0
found 1.10.0 in filename of file in /nix/store/3ijwl9bfkqdc9nrvlv2cv06s22qhqr1l-katago-1.10.0

Rebuild report (if merged into master) (click to expand)

3 total rebuild path(s)

3 package rebuild(s)

3 x86_64-linux rebuild(s)
0 i686-linux rebuild(s)
0 x86_64-darwin rebuild(s)
0 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
katago
katagoCPU
katagoWithCuda

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/3ijwl9bfkqdc9nrvlv2cv06s22qhqr1l-katago-1.10.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A katago https://github.com/r-ryantm/nixpkgs/archive/aa0f27c169b87ae899ea6c1ef0f34ae03dc72ed9.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/3ijwl9bfkqdc9nrvlv2cv06s22qhqr1l-katago-1.10.0
ls -la /nix/store/3ijwl9bfkqdc9nrvlv2cv06s22qhqr1l-katago-1.10.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

3 packages built:

katago
katagoCPU
katagoWithCuda

Maintainer pings
cc @omnipotententity for testing.

Moreover there is a new tensor core option that I wanted to expose.  I think I should just take care of this one.


Replace mechanism for single-threaded access to R-API

I'd like to simplify the single-threaded manner in which we access R-API. This is mainly to understand that, but there is definitely room for improvement.
The challenge is nested calls of single_threaded, which entails that the chosen lock shouldn't halt when the same thread repeatedly attempts to acquire it. Otherwise we are waiting for the same thread to finish execution, ergo deadlock.
ReentrantMutex from parking_lot fulfills this promise. However, commit c750eb0 didn't pass. Only one thing broke there, and I don't know why.
Note that there is a
std::thread::sleep(std::time::Duration::from_millis(1))

in current implementation, which means there is a 1ms for each nested call of single_threaded call associated with R-api. This might not be of importance in practice, and might not even appear on measurements, but it is still something.
How can you help?
I'm sure these approaches improves things somehow, but I haven't measured them. I am going to attempt to have a few commits that implements one approach, and another, and those could be tested against each other.
A possible case could be how long it takes to run cargo test, but that's a little circumstantial.

The reentrant mutex idea is failing.
I'm now experimenting with an idea from @wolvereness. Here the idea that each thread will have the lock, and
successive calls to single_threaded will first check if current thread has the lock, if not, proceed as usual, or otherwise attempt to acquire the lock!.

This actually passed CI, and it looks understandable, so I guess I'd like to have it reviewed.

Thanks for review @Wolvereness !

I'm now convinced that there is an issue with ExtendR, that is outside of the thread safety rs file, and it was probably masking before.
I'll try to explore what that issue is.
CI is passed from time to time.

A lot of places are lacking the single_threaded. I tried adding it different places.

Don't add single_threaded to ownership.rs. Why??

As far as I'm concerned, the change in this PR is correct. But there are missing cases of single_threaded still. This is beyond impossible to track down, as issue is only appearing on CI sometimes, and never locally.
Notes:
Deadlock on `pairlist_macro_works`

Access violation on `altrep_tests`

I'll slap on more single_threaded and hope they disappear.
I think this is revealing issues that were hidden before. Now also in the current altrep implementation.

[ ] Try again when #642 is reviewed & merged


Append details to the page

You can always check the current port through PowerShell too with below commands:
Get-ItemProperty -Path 'HKLM:\SYSTEM\CurrentControlSet\Control\Terminal Server\WinStations\RDP-Tcp' -name "PortNumber"
Ex:
PortNumber   : 3389
PSPath       : Microsoft.PowerShell.Core\Registry::HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Control\Terminal
Server\WinStations\RDP-Tcp
PSParentPath : Microsoft.PowerShell.Core\Registry::HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Control\Terminal
Server\WinStations
PSChildName  : RDP-Tcp
PSDrive      : HKLM
PSProvider   : Microsoft.PowerShell.Core\Registry
You can change RDP port by executing PowerShell commands too as example shown below by adding new RDP port as 3390
Add New RDP Port in Registry:
Set-ItemProperty -Path 'HKLM:\SYSTEM\CurrentControlSet\Control\Terminal Server\WinStations\RDP-Tcp' -name "PortNumber" -Value 3390
New-NetFirewallRule -DisplayName 'RDPPORTLatest' -Profile 'Public' -Direction Inbound -Action Allow -Protocol TCP -LocalPort 3390

Please note that unless you use MarkDown code block fencing, the text added to the page will not be shown as aligned as it is in the source file view here on GitHub. Any line breaks and additional spacing will be suppressed in the web page view. If you want to see how it may be displayed in the target page, use the Rich Diff view in your PR:

https://github.com/MicrosoftDocs/windowsserverdocs/pull/4799/files?short_path=a5b6195#diff-a5b619570de0114a80d09a624eeee154

Feel free to ask if you would like some help with MarkDown code block fence formatting.

Unfortunately, it is too tricky for me to add MarkDown code block suggestions for text modifications which can be merged directly by the PR owner, so I will instead post it here in this comment box:

You can also check the current port through PowerShell with the following command:
Get-ItemProperty -Path 'HKLM:\SYSTEM\CurrentControlSet\Control\Terminal Server\WinStations\RDP-Tcp' -name "PortNumber"

Output:
PortNumber   : 3389

PSPath       : Microsoft.PowerShell.Core\Registry::HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Control\Terminal Server\WinStations\RDP-Tcp

PSParentPath : Microsoft.PowerShell.Core\Registry::HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Control\Terminal Server\WinStations

PSChildName  : RDP-Tcp

PSDrive      : HKLM

PSProvider   : Microsoft.PowerShell.Core\Registry

You can change RDP port by executing PowerShell commands as shown in the example below, by adding a new RDP port as 3390.
Add New RDP Port in Registry:
Set-ItemProperty -Path 'HKLM:\SYSTEM\CurrentControlSet\Control\Terminal Server\WinStations\RDP-Tcp' -name "PortNumber" -Value 3390

New-NetFirewallRule -DisplayName 'RDPPORTLatest' -Profile 'Public' -Direction Inbound -Action Allow -Protocol TCP -LocalPort 3390

@vamsivellanki : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@vamsivellanki : Would you consider using MarkDown code block fencing, with additional code syntax highlighting where applicable (like ```powershell for the cmdlets) ?

I have created new pull request now with modified changes, you may close this.
https://github.com/MicrosoftDocs/windowsserverdocs/pull/5052

#please-close


Remove nuget package info from .NET sample metadata

Updated the readme metadata scripts to remove nuget package information.
Ran the script to update existing readme metadata files.

Changed the target branch from main to v.next, some file changes should be removed when v.next is updated by main.

Merged v.next into this feature branch to bring it up to date with the target branch,


Fix gazebo model direction

Solved the problem shown in #53 where Gazebo's 3D model is always facing the same direction, which was due to the fact that there was no value in AgentState's pose.orientation in the first place.
I've modified the code by referring to this.
https://github.com/srl-freiburg/pedsim_ros/blob/b21218347149657f0639ada23da8847f537811ce/pedsim_visualizer/src/sim_visualizer.cpp#L98

Thanks for this fix.


Add Gitness contributing guide

This PR adds the contributing guide for Gitness, which will help new contributors understand the contribution process.
Additionally, it proposes adding the good-first-issue label to issues, enabling new contributors to find relevant work more easily.
Finally, the PR includes the LICENSE section at the end of the README.md file.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Elfeed filter binding

When using Elfeed, I can't seem to filter specific tags. From the code I saw that elfeed-search-live-filter has been bound to s, but this only invokes evil-snipe. I had the same issue in my manually installed  version of Ranger, where s was also bound to a function from evil-snipe.

I've been struggling with this issue in evil-snipe for a while. If it isn't too much trouble, please try the following:
(push 'elfeed-show-mode evil-snipe-disabled-modes)
(push 'elfeed-search-mode evil-snipe-disabled-modes)

This isn't expected to work, but if it magically does, I'd like to know.
If it doesn't, add this to the above:
(defun evil-snipe-inhibit-hook ()
  (when (and (or evil-snipe-local-mode evil-snipe-override-local-mode)
             (not (eq major-mode 'fundamental-mode))
             (apply #'derived-mode-p evil-snipe-disabled-modes))
    (when evil-snipe-local-mode (evil-snipe-local-mode -1))
    (when evil-snipe-override-local-mode (evil-snipe-override-local-mode -1))))
(add-hook 'evil-snipe-local-mode-hook #'evil-snipe-inhibit-hook)
(add-hook 'evil-snipe-override-local-mode-hook #'evil-snipe-inhibit-hook)

This is a bit of a hack, but this problem has plagued evil-snipe for a while, and if it solves the problem, I suppose it's better than nothing. If it works, I'll push it to evil-snipe upstream.
Let me know!

After  the addition of:
(setq evil-snipe-disabled-modes '(magit-mode elfeed-show-mode elfeed-search-mode))

in your latest commit, together with
(push 'elfeed-show-mode evil-snipe-disabled-modes)
(push 'elfeed-search-mode evil-snipe-disabled-modes)

it  did the trick. Thank you!

Ah, I forgot to update this. Yeah, the recent evil-snipe commit fixed this problem. Glad it helped!


[TextField] Autocomplete/Autofill value [ By Browser password manger] overlap by InputLabel.

[x] The issue is present in the latest release.
[x] I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯
Text input value overlap by browser autocomplete .
Expected Behavior 🤔
Input label should be at top once data fill by browser such as chrome.
Steps to Reproduce 🕹
Steps:

https://vs9pe.csb.app/ for preview mode or https://codesandbox.io/s/inputadornments-material-demo-forked-vs9pe?file=/demo.tsx:3074-3075 for edit mode.

https://vs9pe.csb.app/ fill any text in both textfield.

click on submit.

On address bar browser ask to save password .just save it.

Then reload https://vs9pe.csb.app/ you will see the inputlabel overlay issue.

@Sandeep0695 Thanks for the detailed issue. I believe it's a duplicate of #22488.

Yes @oliviertassinari  , Its similar but #22488  already closed without proper resolution.
Can we have any solution ?

There are no proper solutions, it's a limitation of Chrome. You can force the shrink state of the label if you prefer.

I found that setting the value to value={something || ''} alleviated the problem in most cases.


One-page vs. multi-page website

Pro and cons list for one-page and multi-page website:
Pro one-page:

Easy navigation and consumption of content.
Easy to keep it minimal and simple (my current design goal).
Easy to organize information in the order that I would like people to see.

Con one-page:

Supposedly bad for SEO (but is SEO important for me?).

Pro multi-page:

Great scalability in the future.
Supposedly great for SEO.
Great for analyzing content consumption data via Google domain.

Con multi-page:

Multiple and uncontrollable entry point into to website (but is this necessarily bad?)
Confusing navigation, if not designed properly.

Right now, I am leaning towards constructing a one-page website, because I really like minimalism; however, if there are more benefits of multi-page that I can think of, I might reconsider in the future.

Just tested multi-page about page. Seems to work well for now. However, I would like to see it in one-page as well.

I have decided to go with simple and minimal for now. I will revisit this issue, if I need the multi-page advantage.


ParseFile with blob

ParseFile save supports Titanium Blob and File.
In Camera success callback, just set e.media to file.
var f = new Parse.File('profile.jpg',e.media.imageAsThumbnail(640));
f.save();

I found a some bug. I'll push new code ASAP.

fixed :)

Great!!


Release 0.2.0?

Any objection in cutting a release 0.2.0? This would help a bit for (finalizing) the integration of the new features in Spherely. Or Is there anything that needs to be addressed / implemented before?

I think we at least need to address https://github.com/paleolimbot/s2geography/issues/43 since I think that will affect your Conda situation.

For sure I would like to see that fixed, but on the other hand without a new release we would not even have support for projection at all (it would be new in 0.2), so give it's a bug in a new feature and not a regression, I think it is fine to release (unless someone would be able to look into it on the short term)

That would be wonderful!

Release is here: https://github.com/paleolimbot/s2geography/releases/tag/0.2.0
(waiting for the conda-forge bot to open a PR on https://github.com/conda-forge/s2geography-feedstock)
Thanks @paleolimbot and @jorisvandenbossche for the new features!


timer task

A way to schedule a task periodically. Should support in number of seconds or number of blocks.

Fixed by #63


fix GetService changed to return a non nullable

Presently GetService casts to a nullable return value object? or T?, now returns the value as a object or T

What kind of change does this PR introduce?

fix
What is the current behaviour?

Presently GetService casts to a nullable return value object? or T?
What is the new behaviour?

GetService casts to a nullable return value object or T
What might this PR break?
none expected
Please check if the PR fulfils these requirements

[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

Other information:
Test projects have the allow nullable applied

As discussed offline GetService probably should return nullable to indicate non registration or deliberate null.

i've done a branch https://github.com/reactiveui/splat/commit/f50a07287b0350543257ccd7370e5ded5b38e196 to think through the getservices bit. will look again over weekend

re-opening so i can track what i am looking at on getservices against this branch rather than diff master


Non-admin user sees grayed out list of all apps in all spaces

Currently non-admin users see a the stats for the apps in the targeted space and see a grayed out list of all apps in all spaces they have access to see.
I would like the ability for non-admin users to see the same list that admin users see with all the stats available for all apps in all spaces.

A clarification on your statement above.   Cf top does not use the "currently targeted org/space" information when displaying stats.   For non-admin users it grabs the first 50 apps that the /v2/apps API returns (which is normally the oldest 50 applications deployed to the platform for which the user has visibility).   Any applications over 50 are displayed as grayed out.
Back to your request -- if by non-admin you mean a specific group of users (e.g., cloud foundry operators) that are logged in with their own login and not the "admin" user but want to run cf top -- that is possible.  If on the other hand you are talking about normal developers that should not have admin like permissions - this is not possible.
Cloud Foundry through uaa and the cloud controller will only allow a user to see applications in orgs and spaces that the user has been given access to either directly or indirectly (via scopes).   That access is not something that cf top can override.
If a user or set of users (e.g., cloud foundry operators) need access to run cf top you can assign the appropriate scopes.  But be careful as giving cloud_controller.admin can give a user a lot of power.   See instructions in link below.
https://github.com/ECSTeam/cloudfoundry-top-plugin#assign-scope-if-privileged-mode-is-needed

Thanks for clarifying the current behavior.  My scenario is this:
I'm not a CF admin, but instead manage the production instances for a few hundred apps. I'm a space and org manager, but not an admin.  I see the problem of >50 apps are grayed out.
I would like to see everything I should have access to see.

Your only option is to request the following two scopes be added to your login id:
cloud_controller.admin
doppler.firehose
However this will give you access to everything running on the platform, not just the few hundred apps you are responsible for -- unless it's the same list.  i.e., you are responsible for all applications on the platform.
The reason cf top caps at 50 applications for non-admins is that a websocket must be opened for each application that is monitored.    50 persistent socket connections is a lot for 1 application / user.   If it wasn't capped we could open 100s of websockets which would not be good on the platform.   When you are an admin, all events can be streamed through 1 websocket, although cf top opens 2 by default to help ensure fast event processing.

@kkellner @deanhouseholder take a look at this https://github.com/ECSTeam/cloudfoundry-top-plugin/pull/15


Refactor to control reuse of opened webview editors

Preparation for https://github.com/getappmap/appmap-intellij-plugin/issues/533
Prepares for the Navie webview and cleans up a long-standing issue, that we were not fully implementing a WebViewEditorProvider for our Install Guide.
The code to focus on an already open, compatbiel webview editor is now reused in a better way.

:tada: This PR is included in version 0.55.0 :tada:
The release is available on:

v0.55.0
GitHub release

Your semantic-release bot :package::rocket:


[BUG] StickyHeader is not working as expected in table, After enabling it.

Describe the bug
StickyHeader is not working as expected in table, After enabling it.
<kyn-table
[striped]="true"
[stickyHeader]="true"
>

Need more information, or a CodeSandbox reproduction.

@Harshavardhan-Kanoj  did  you give the table container a fixed height so that it can scroll? If not, please do so.

@Harshavardhan-Kanoj https://kyndryl-design-system.github.io/shidoka-applications/?path=/story/components-datatable--sticky-header
please look at our story for an example

Closing since this has become stale with no new information.


Aver_Max.c

What the program do ?

In what programming language it is written?
C

This pull request do not contains files in specific folders. Please fix it and reopen


Fix pro pos rank#93

Fix #93

Codecov Report

Merging #94 into develop will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop      #94      +/-   ##
===========================================
+ Coverage    94.36%   94.38%   +0.01%
===========================================
  Files           21       21
  Lines          728      730       +2
===========================================
+ Hits           687      689       +2
  Misses          41       41

Impacted Files
Coverage Δ

espn_api/football/box_player.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26be2ae...fd886d6. Read the comment docs.


bump version in chocolately

What steps did you take and what happened:
If I run choco install octant I get version 0.24
What did you expect to happen:
It should install the newest version, right now is 0.25.
Environment:

Octant version 0.24
Kubernetes version: v1.23.3
OS: Windows 10

https://community.chocolatey.org/packages/octant/0.25.1


URLs in headers break Table of contents

If you put an URL in a header, it breaks the generated table-of-contents sidebar for docs pages.
To Reproduce
Steps to reproduce the behavior:
# some nice stuff ([url][])

[url]: https://google.com

in a docs page with toc=true.
Result:

(Page source at https://github.com/thomwiggers/thomwiggers.nl/blob/new-site/content/teaching/hacking-in-c-2020/syllabus.md)
Technical details:

Academic Version: adb09f8dabc937afc240ae6c25b5288d95b6071c
Hugo Version:

Hugo Static Site Generator v0.68.3-157669A0/extended linux/amd64 BuildDate: 2020-03-24T12:13:38Z

The ToC is generated by Hugo. Feel free to raise with Hugo team. You might wish to check that your Markdown is fully compliant with the CommonMark spec before raising it as a Hugo bug.


Ambiguous Challenge Instructions

Challenge Make Object Properties Private has an issue.
Please describe how to reproduce this issue, and include links to screenshots if possible.
Over the past couple days I've noticed a GH issue (#12385) and a few questions in the Javascript chat room about this challenge, all of which have all had to do with confusion about the purpose of the getGear and setGear functions. The challenge instructions explain private variables and private methods well, but doesn't explain the purpose of getters and setters.
I think adding a simple explanation of getters and setters without going too deep into encapsulation would benefit campers greatly. The new instructions would include something along these lines:

Getter functions such as getSpeed() are meant to simply return (get) the value of an object's private variable to the user without the user directly accessing the private variable.
Setter functions such as accelerate(change) are meant to modify (set) the value of an object's private variable based on the value passed into the setter function. This change could involve calculations, or even overwriting the previous value completely.

If people have other opinions on the current instructions or proposed changes, please share 😄

@robbawebba Thanks for the insight. Yep... I like the idea of more clarifications, but IMHO what you propose about getter and setter functions are more of a best practice/paradigm than just concept.
I am up for the change, but not really sure if this challenge's scope should be covering it or this should be a new challenge of itself.
/cc @FreeCodeCamp/moderators

Since the challenge asks you to define getGear and setGear I think the explanation would be welcome. Yes it is a paradigm, but it is a pretty standard one.
I'm :+1: for a change to the instructions

How about a one or two line introduction to Encapsulation? Along with private variables, it would serve as the basis for the need of getter and setter methods.

Does sound good. But again I am not convinced if all these should go into this challenge itself.

/cc @HKuz

@raisedadead I see what you mean about how encapsulation is more of a paradigm than a core concept of JavaScript, but I think that it does belong in this challenge because it is essentially already covering the "best practice" of encapsulation. It covers constructors for objects with private variables, and asks for campers to create public methods to access/modify the private variables (AKA encapsulation). So the challenge is already covering this topic but without explaining it fully. There's already sufficient explaination for constructors and private variables, but I think the discussion of setters and getters will help clear up any more confusion.

Thanks for flagging this for me, @raisedadead. So this challenge is in the current Object Oriented and Functional Programming section on FCC. Part of the curriculum expansion efforts created two new sections with new challenges (one for Objected Oriented Programming and one for Functional Programming) that will replace this one. The OOP section does cover encapsulation and private variables - if you're curious, you can check out the issue with the challenge list here. For getters and setters, the new ES6 section has a challenge specifically for the new get and set functions.
As for how to move forward - I really like how @robbawebba describes getter and setter up top. We can include it in the existing challenge, but know that ultimately, it'll be replaced once the curriculum expansion goes to production. I'd actually like to include those explanations in the ES6 challenge I linked to above. I think it would improve the challenge.
Of course, the timing to edit the new challenge right now is tough. The ES6 challenges are being pulled into the seed files this week as part of the big pull request to get the new challenges on the beta site. We may have to hang tight and wait for it to go live, then open an issue/PR to get that change in. In the meantime, I'll go edit the challenge on the issue, and we'll see if we beat Quincy's seeding efforts...

@robbawebba @HKuz thanks a lot for chiming in. From the way I see, if we do edit this challenge as you say it would be going into the same branch (staging) later.
So it's best as you say to let this wait and get this fixed in the curriculum expansion effort (even if this goes after an initial merge), as a second level pull request.
Count me in if you need help in anything, on merging it in.

@raisedadead @HKuz Sounds good for me! Thank you for the helpful information about the curriculum expansion - looking forward to it! I'd be happy to help if there's any way to get involved 🙂

@robbawebba sure thing, follow the issues on the https://github.com/FreeCodeCamp/CurriculumExpansion repo and join the conversation in the Contributors Chat room.


[Bug] Indium 1.0.29 & 1.0.30 for 1.20.x requires Sodium 0.5.8, but Sodium 0.5.8 is not available for 1.20.2

Indium 1.0.30 apparently supports all 1.20.x, including 1.20.2, and 1.0.29 supports 1.20.2-1.20.4, but the mod requires Sodium 0.5.8
However, Sodium 0.5.8 does not support 1.20.2, and therefore it is impossible for Indium 1.0.29 or 1.0.30 to actually run on 1.20.2
Sodium 0.5.8 doesn't seem to support 1.20.2 at all https://github.com/CaffeineMC/sodium-fabric/issues/2384

Vouch

Duplicate of #278! @RedrcknRbn Use https://modrinth.com/mod/indium/version/1.0.28+mc1.20.4


v 2021.4.0 causes ValueError's in HTTP calls

Since fsspec is used in intake/intake-catalog the latest version is causing issues reading from an HTTP Catalog
"/Users/donghunl/miniconda3/envs/intake_dal37/lib/python3.7/site-packages/intake_dal/dal_catalog.py", line 69, in __init__
    super(DalCatalog, self).__init__(path, autoreload, **kwargs)
  File "/Users/donghunl/miniconda3/envs/intake_dal37/lib/python3.7/site-packages/intake_nested_yaml_catalog/nested_yaml_catalog.py", line 75, in __init__
    super(NestedYAMLFileCatalog, self).__init__(path, autoreload, **kwargs)
  File "/Users/donghunl/miniconda3/envs/intake_dal37/lib/python3.7/site-packages/intake/catalog/local.py", line 565, in __init__
    super(YAMLFileCatalog, self).__init__(**kwargs)
  File "/Users/donghunl/miniconda3/envs/intake_dal37/lib/python3.7/site-packages/intake/catalog/base.py", line 113, in __init__
    self.force_reload()
  File "/Users/donghunl/miniconda3/envs/intake_dal37/lib/python3.7/site-packages/intake/catalog/base.py", line 172, in force_reload
    self._load()
  File "/Users/donghunl/miniconda3/envs/intake_dal37/lib/python3.7/site-packages/intake_dal/dal_catalog.py", line 87, in _load
    super()._load()
  File "/Users/donghunl/miniconda3/envs/intake_dal37/lib/python3.7/site-packages/intake/catalog/local.py", line 591, in _load
    text = f.read().decode()
  File "/Users/donghunl/miniconda3/envs/intake_dal37/lib/python3.7/site-packages/fsspec/implementations/http.py", line 457, in read
    return super().read(length)
  File "/Users/donghunl/miniconda3/envs/intake_dal37/lib/python3.7/site-packages/fsspec/spec.py", line 1449, in read
    out = self.cache._fetch(self.loc, self.loc + length)
  File "/Users/donghunl/miniconda3/envs/intake_dal37/lib/python3.7/site-packages/fsspec/caching.py", line 376, in _fetch
    self.cache = self.fetcher(start, bend)
  File "/Users/donghunl/miniconda3/envs/intake_dal37/lib/python3.7/site-packages/fsspec/asyn.py", line 72, in wrapper
    return sync(self.loop, func, *args, **kwargs)
  File "/Users/donghunl/miniconda3/envs/intake_dal37/lib/python3.7/site-packages/fsspec/asyn.py", line 53, in sync
    raise result[0]
  File "/Users/donghunl/miniconda3/envs/intake_dal37/lib/python3.7/site-packages/fsspec/asyn.py", line 20, in _runner
    result[0] = await coro
  File "/Users/donghunl/miniconda3/envs/intake_dal37/lib/python3.7/site-packages/fsspec/implementations/http.py", line 507, in async_fetch_range
    "Got more bytes (%i) than requested (%i)" % (cl, end - start)
ValueError: Got more bytes (117554) than requested (31)

Downgrading to 0.8.3 resolves the issue

Is the URL for the catalog you are trying to access public?

Is the URL for the catalog you are trying to access public?

It's public to our org but not externally accesible.

That makes it harder to investigate.
Reading only 31bytes sounds strange, but you might want to play with HTTPFileSystem directly to see how the file behaves, or requests to call the URL with various Range headers to see what works. The first thing you might want to try is HTTPFileSystem.info(url) to see whether the file size is correctly determined.

Issue is we don't call/use fsspec directly, but through intake/intake-catalog

I understand, but for the sake of debugging, I'll have to rely on you, since I can't access the URL.
fs = fsspec.filesystem("http")
fs.info(url)

(you can use pdb following your exception to find the actual URL)

I understand, but for the sake of debugging, I'll have to rely on you, since I can't access the URL.
fs = fsspec.filesystem("http")
fs.info(url)

(you can use pdb following your exception to find the actual URL)

ah of course, not a problem!

{'name': 'https://dataset-catalog-service.xxxxxxxxxxxxxxxxx', 'size': 31, 'type': 'file'}

size is way larger than 31 for sure :)

OK, so this is definitely the problem.
In the previous version, the size didn't matter if it was "small". This is the change; but apparently the behaviour of sizing was already wrong.
You could try
requests.head("https://dataset-...", headers={"Accept-Encoding": "identity"}).headers
requests.get("https://dataset-...", headers={"Accept-Encoding": "identity"}).headers
requests.get("https://dataset-...", headers={"Accept-Encoding": "identity"}).text

to see where that value is coming from. Those are the calls that fsspec is making.

If that is not the case, here is another you can try, to see if you get a useful error
requests.get("https://dataset-...",
    headers={"Accept-Encoding": "identity", "Range": "bytes=0-30"}).text

last one seems to read the whole catalog, and throws no error

The last one explicitly says "only send me 31 bytes"...
Any useful information from the others?

@smatzana , if you have no luck getting further debug info here, perhaps I can can help you look into it live next week.

Did you ever get any further debug information on what the server is doing? Otherwise, I would close this, since I don't know what I might be able to fix.

Apologies, I have had no time to look into it


Environment requirement for signing/fetching

When you do request_cert --environment dev this generates a unique ID which I assume is specific to that environment/request. I would assume that I should be able to do sign_cert <ID> and be able to drop the --environment dev from the command but this is not the case. What's interesting is that I can do sign_cert --environment other <ID> and it works. I think the requirement of --environment should be dropped altogether for the sign_cert and request_cert operations.
Thoughts?

The --environment other workaround is what I do as well. I have shell scripts like "request_cert_prod" and "request_cert_stage" but for signing I call the script "sign_cert".
The one use case that requiring an env supports today is multiple servers. If you had multiple environments spread across multiple servers (e.g. prod on server a and stage on server b). However, I know of exactly zero users of ssh-cert-authority that have multiple environments distributed across multiple servers .
The same issue extends to get cert as well.
I think this is good feedback. While the workaround is pretty simple and is "set it and forget it" I may as well patch this up.
I'll leave this issue open and plan to fix it.

Maybe another option is to simply have a default value for the environment option for those that don't want to use it?

If your configuration file only contains one environment the code is smart enough to not require the --environment flag. But when more than one environment is in the configuration file it throws its hands up in the air and makes the user choose.
In my workplace we have 5 ssh-cert-authority environments. So I have 5 scripts like these (stage, prod, yeti shared, yeti stage and yeti prod):
$ cat /usr/local/bin/request_cert_stage
#!/bin/bash
/usr/local/bin//ssh-cert-authority request --environment stage $@

Cool, I didn't realize it did that. That would totally solve my issue, thanks for the info. :smile:


Update IRIs containing problematic characters

Closes #3
Some IRIs contain parentheses in them, which makes serialization and deserialization break for packages like RDFlib. This PR updates some of those IRIs. This was done through Protege using it's rename IRI dialogue box.
CC @shivaram

Hi @cthoyt,
It looks good, I will accept your PR. Thanks!


Insecure Default Hash Algorithms for IPsec P2

Important notices
Before you add a new report, we ask you kindly to acknowledge the following:

[x] I have read the contributing guide lines at https://github.com/opnsense/core/blob/master/CONTRIBUTING.md
[x] I am convinced that my issue is new after having checked both open and closed issues at https://github.com/opnsense/core/issues?q=is%3Aissue

Describe the bug
When creating a new IPsec phase 2 entry per default MD5 and SHA-1 are selected, which are both insecure.
To Reproduce
Steps to reproduce the behavior:

Go to 'VPN' > 'IPsec' > 'Tunnel Settings'
Create a Phase 1 entry
Create a Phase 2 entry
Check default selection in "Hash Algorithms"

Expected behavior
MD5 and SHA-1 shall be unchecked and a secure (SHA-3) algorithm shall be checked.
Describe alternatives you considered
A clear and concise description of any alternative solutions or workaround you considered.
Screenshots

Relevant log files

Additional context
Maybe MD5 and SHA-1 (and DES) should even get an "insecure" label added in the GUI?
Environment
OPNsense 22.1 dev (amd64, OpenSSL).

@8191 how about https://github.com/opnsense/core/commit/dd1776030c2fac435be19d6dc82c9c9f5e442896? for most setups the aesgcm variants are the best option to use in terms of security and performance, so maybe best select those as defaults while here too.

Sorry, should have pulled before...

@AdSchellevis I just stumbled upon  this change in FreeBSD 13. It seems that most legacy algos are not even supported anymore.

That seems rather excessive and destructive oO

That does indeed seems rather excessive and destructive, it's also pretty weird removing non-recommended protocols, as they are, well, not recommend, but certainly not forbidden (https://wiki.strongswan.org/projects/strongswan/wiki/Changelog56#Version-561).
We should probably discuss reverting that commit on our end for 22.1, as this will cripple quite some setups for no valid reason.
In the long term we should drop it (as we can't maintain this level of deviation), but maybe a two step approach (remove from ui in 22.1 and completely as of 22.7/23.1) would be more user-friendly.
I missed it in the FreeBSD release notes, but does indeed state the following:

Removed support for IPsec algorithms deprecated by RFC 8221 as well as Triple DES

There is no point reverting stuff like https://cgit.freebsd.org/src/commit/?id=16aabb761c0a as it comes with a 1,5 year trail of functional removal and reworks of opencrypto kernel library. What we need to do is assess real world impact and offer appropriate migration notes.

👍 to temporarily reverting this for 22.1, but we should anyway add a warning maybe to the release notes of 22.1 (that those algos are now deprecated and subject of removal in 22.7) and I would even display a warning banner in the IPsec config page as long as one connection uses such an algo.

@fichtner Sorry didn't see your comment before.
Well now it's a bit late for migration notes and recommendations. We should have done this with 21.7.7... Don't you think?
It lies in the nature of a VPN that one wants to interface a device of a potential third party without direct control of their capabilities. A short transition phase would be appreciated by many users I'd assume...

Hm. Valid point, @fichtner
Well then the only option is to remove the algos and add this breaking change prominently to the release notes of 22.1 giving users the option to defer an update until their peers are ready.


How long should our secret be when generating the TOTP secret?

@fillup / @wcjr / @Baggerone
tl;dr - What balance do we want to strike between longer TOTP Key length (= more protection against... what?) vs. shorter code for a user to (possibly) type in?

default = 52 chars
Daplie demo = 32 chars
Authy in-app example = 16 chars
Slack = 16 chars

I had been using the default ({length: 32}), giving a TOTP Key (base32) string that is 52 characters long. That's really painful to try to type in (which is an option for users that can't scan a QR code).
The daplie demo generates a TOTP key 32 characters long, which seems to be a TOTP secret length of 20.
When manually typing the code into Authy, the example they give is 16 characters long, so a TOTP secret length of 10.
Slack also produces a code 16 characters long (so {length: 10}).
My inclination is to follow Slack's example, and generate codes that are 16 - 20 characters long.

fwiw, Google's is 32...
I'd be fine with 16.


[ENH] Force option inside import command

Laravel Version: 5.4
Adldap2-Laravel Version: 3.0
PHP Version: 7.1

Description:
I use import command to synchronize user with my db.
When i set up this script in cron i can use 'yes' command with pipe 'yes | php artisan adldap:import'
But i want to run import through laravel schedule command, so it's needed to have force option.
Steps To Reproduce:
Register import command in Kernel
protected function schedule(Schedule $schedule)
{
        $schedule
            ->command('adldap:import')
            ->hourly();
}

It would perform
Running scheduled command: 'php' 'artisan' adldap:import > '/dev/null' 2>&1

But it should be
protected function schedule(Schedule $schedule)
{
        $schedule
            ->command('adldap:import', ['--force'])
            ->hourly();
}

Oh, laravel provide "no interaction option"
-n, --no-interaction           Do not ask any interactive question


Connect elasticsearch with ipv6 address

When I connect my elsaticsearch with an ipv6 address like this:
ES_CLIENT = AsyncElasticsearch(
    hosts=['http://[2002:ac1f:91c8::<IP_ADDRESS>]:9200'],
    timeout=120,
    sniff_on_start=True,
    retry_on_timeout=True,
    max_retries=5,
    loop=self.loop
)

The connection will be failed because of the address will be converted to 2002:ac1f:91c8::<IP_ADDRESS>, and aiohttp can't establish the connection with that kind of address.
With this situation, I have prepared a pull request if you think this is a bug, or how can I connect my elasticsearch with IP address like that.

If aiohttp doesn't support connecting to these addresses then this issue should be raised in that project. We can't do much to work around this.


[Q] Is it safe to cache ~/.cabal ~/.ghc?

Given Michael Snoyman's article on Travis configuration for Stack and Cabal, I'm wondering if it's safe to do
cache:
  directories:
  - ~/.ghc
  - ~/.cabal
  - ~/.stack

without any thought to the .cabsnap or installation plan?

As far as scripts in this repository are concerned, caching ~/.ghc would break the builds. The dependencies and the package under test is installed there, so in some next run you'll definitely run into one occurence of Cabal Hell.

~/.cabal/packages are cached already though
~/.stack is safe to cache

Like @phadej said. However, the new cabal new-build feature uses ~/.cabal/store in place of ~/.ghc, and that one's safe to cache. But be careful when caching other parts of ~/.cabal as you'll easily end up with huge caches (in the order of ~1GiB), which I'm worrying that Travis admins may start noticing if this gets overboard...

Hmmm, the travis config over at updated-travis-config looks very similar to those here (they are based on those here). I peeked at a few well-known Haskell projects that seemed to be using the recommended scheme AFAICT…
I'd like to understood more, if I can press you further. Idris is still being tested with a v1-style script because we have to test the versions that folks will have by default in certain Linux distributions. We don't use Stack (on Travis at least). Could you explain why it's unsafe to cache ~./ghc and ~/.cabal (or throw some references at me!). I'd also like to understand why the "installplan.txt" diff is doing.
It would be great to cache binary builds of dependencies and even the "package under test" if possible.

installplan.txt is essentially a list of dependencies and their versions, so if something new comes we know when we should wipe a cache. We don't store installed packages directly in ~/.ghc as the global database would interfere with solving the install plan.
What we do here is poor man cabal sandboxes, and we use the sandbox only when stuff there is the one we'd install starting with clean table.
~/.cabal/packages/hackage.haskell.org for example stores the tarballs for downloaded packages, so it's likely to grow over time.

Okay, thanks.