send paid action

Send paid action's (ie account withdrawal) are unique in that no invoice paid to SN's node is generated. Because of this, we can't use the paid action state machine as-is (which transitions invoices and foreign key constrained related records).
To implement paid action's that don't involve an invoice paid to SN, we'll probably want to create another state machine that transitions purely based on Withdrawl records (as opposed to Invoice records).
Other than withdrawals, this is need for:

using SN's UI to pay for non-SN things directly from attached wallets
recording P2P receives that are NOT proxied

Problems:

(a) We can't determine if non-custodial receives (lnulp) that aren't proxied have been paid. We know the bolt11, but we have no idea whether it's been paid. This means we can't allow notifications and comments for these lnurlp initiated receives we don't know if money actually moved.
(b) If we allow someone to use their attached wallets to pay for non-SN things using our UI, we have a related problem. We can give the bolt11 to their wallet, but we don't know if the wallet succeeded in paying it UNLESS they return a preimage as part of the payment process (which most of them don't do).

(Withdrawals on the are pretty straightforward on a relative basis.)

Options:

don't support these things
support them but don't show if they're paid or not (and put up a disclaimer about it on every such send)
support them and proxy these payments anyway

for lnurlp (a), the stacker would choose between receiving fee credits OR sats with a 10% proxy fee
when a stacker is sending (b), the stacker would pay the outgoing fee upfront

I suspect (3) will be unpopular even if we drop the proxy fee to closely match the network fee, ie 3%. I suspect (2) will be confusing (... and lnurlp shouldn't be shown as a notification).

We can't determine if non-custodial receives (lnulp) that aren't proxied have been paid. We know the bolt11, but we have no idea whether it's been paid.

Why not? Most wallets support a method to lookup if an invoice has been paid, examples:

NWC: lookup_invoice
LNbits: GET /api/v1/payments/<payment_hash>
phoenixd: GET /payments/outgoing/<id>

etc.
isn't this what we need here?
same applies to (b)

For lnurlp we don't know who paid or with what wallet and don't have creds to make api calls.


Basic reading support and the beginnings of error handling

This makes it possible to read pixels, making the library usable for loading data. Some initial work towards simple error handling is included.

Ah!  I didn't expect to get contributions at such an early stage.  Your changes look good to me, and I'm happy to merge them.  :-)
If you plan to continue contributing, keep in mind that I plan to rework things a bit in the future, likely using bindgen for the low-level bindings rather than the hand-written ones I'm using now.  In other words, I consider the API to still very much be in flux!

Ah! I didn't expect to get contributions at such an early stage.

I needed the functionality and figured it'd be better not to start from scratch.

If you plan to continue contributing, keep in mind that I plan to rework things a bit in the future, likely using bindgen for the low-level bindings rather than the hand-written ones I'm using now. In other words, I consider the API to still very much be in flux!

I tried to make direct C++ bindgen work (stack-allocated classes would be neat) but kept hitting rough corners. Maybe you'll have better luck. #2 introduces the use of bindgen to generate the rust bindings for the C bindings, which at least somewhat reduces the maintenance load.


docs: v4.0 release notes

Description
v4.0 release notes :^)
Will not merge until we have stakeholders agreed on Umee v4.0 & PF v2.0.3

Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...

[ ] included the correct type prefix in the PR title
[ ] added ! to the type prefix if API or client breaking change
[ ] added appropriate labels to the PR
[ ] targeted the correct branch (see PR Targeting)
[ ] provided a link to the relevant issue or specification
[ ] added a changelog entry to CHANGELOG.md
[ ] included comments for documenting Go code
[ ] updated the relevant documentation or specification
[ ] reviewed "Files changed" and left comments if necessary
[ ] confirmed all CI checks have passed

Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...

[ ] confirmed the correct type prefix in the PR title
[ ] confirmed all author checklist items have been addressed
[ ] reviewed state machine logic
[ ] reviewed API design and naming
[ ] reviewed documentation is accurate
[ ] reviewed tests and test coverage
[ ] manually tested (if applicable)

dead links are definitely not dead 🤔


AzDO Issue #6380

https://dev.azure.com/dnceng/internal/_workitems/edit/6380

Release Note Category

[ ] Feature changes/additions
[ ] Bug fixes
[ ] Internal Infrastructure Improvements

Release Note Description
SQL cleaning

Wave 1 issue. Closing.


Graph Model, add_shared_node() how to deal with various batchsize inputs

I am use Graph Model for my experiment.
Now I have two inputs X1 and X2, they will share the same Convoltion Layer.
X1 has shape(batchsize1, feature_map, row, col)
X2 has shape(batchsize2, feature_map, row, col)
model.add_shared_node(Convolution2D(feature_map, conv_row, conv_col), name = 'Conv', inputs=[X1, X2], outputs=[Y1, Y2])
Here, it gives an error,
Expected input with shape**(batchsize1**, feature_map, row, col),
but previous layer has output_shape(batchsize2, feature_map, row, col)
How can I deal with various batchsize inputs use add_shared_node()?

The Graph API is getting deprecated. For graphs and shared layers, you should start using the functional API, currently found on branch keras-1. It will be released next week.


Update Go to 1.19.5

Signed-off-by: yanggang<EMAIL_ADDRESS>go1.19.5 (released 2023-01-10) includes fixes to the compiler, the linker, and the crypto/x509, net/http, sync/atomic, and syscall packages. See the [Go 1.19.5 milestone](https://github.com/golang/go/issues?q=milestone%3AGo1.19.5+label%3ACherryPickApproved) on our issue tracker for details.

go1.19 release

/test

rebased , but why trigger the close?


MC Landing Gear Don't Deploy at Correct Altitude at End of Mission

Describe the bug
Landing gear are enabled via a mixer to AUX1. Landing gear properly retract upon takeoff. When landing, the gear do not start to deploy until the copter is around 1m above the ground.
To Reproduce
Steps to reproduce the behavior:

Power on and wait for GPS lock
Uploaded mission. Mission End is set to "Return to Launch" gear-test.txt
Took off in mission mode
Verified during testing at two locations, 4 flights each.

Expected behavior
During the landing phase, landing gear should be commanded to deploy when RTL_DECEND_ALT, LAND_ALT_1, or LAND_ALT_2 is reached though I am not sure which it is (but would like to know).
Log Files and Screenshots
Flight Log showing a very quick flight with one waypoint:
https://logs.px4.io/plot_app?log=c57c04e0-a6bd-4f04-9fe2-eb986cbcc1b4
Drone (please complete the following information):

Tarot X6 (with Tarot retracts)
Pixhawk Cube 2.1
Here2 GNSS
PX4 1.9.2
QGC 3.5.5

Additional context
A file named lgear.aux.mix is placed in /fs/microsd/etc/mixers. This Tarot landing gear controller requires an PWM output of less than 1520 for the gear to retract and greater that 1520 for the gear to extend which is the reason for the (-) scaling. It has the following content:
M: 1
S: 0 7 -10000 -10000 0 -10000 10000

A file named config.txt is placed in /fs/microsd/etc with the following content:
set MIXER_AUX lgear
set PWM_AUX_OUT 1234
set PWM_AUX_DISARMED 1500
set PWM_AUX_MIN 1000
set PWM_AUX_MAX 2000
set PWM_AUX_RATE 50

The gear are working properly in mission mode on takeoff as well as manual mode using an RC channel assigned by RC_MAP_GEAR_SW.

The log posted above with generated with a mission that had Mission End set to "Return to Launch". I ran a test flight yesterday without the "Return to Launch" and added a discrete "Land" waypoint at the end of the mission. As before, the landing gear did not deploy at the end of the mission until the copter was a few feet off the ground.

I am pretty sure I found the bug but I am a newbie with PX4 and having some difficulty navigating through the code.
When a waypoint of type "land" is processed, there is a call to _generateLandSetpoints() to update the setpoint:
https://github.com/PX4/Firmware/blob/045f6233d4e77de87a2ef9ffe4e81b26bf9c50eb/src/lib/FlightTasks/tasks/AutoMapper/FlightTaskAutoMapper.cpp#L76
The gear state is updated in _generateLandSetpoints() here:
https://github.com/PX4/Firmware/blob/045f6233d4e77de87a2ef9ffe4e81b26bf9c50eb/src/lib/FlightTasks/tasks/AutoMapper/FlightTaskAutoMapper.cpp#L130
After _generateLandSetpoints() is called, the gear state is updated "if (_highEnoughForLandingGear())" and the "GEAR_DOWN" state is overwritten:
https://github.com/PX4/Firmware/blob/045f6233d4e77de87a2ef9ffe4e81b26bf9c50eb/src/lib/FlightTasks/tasks/AutoMapper/FlightTaskAutoMapper.cpp#L98
The GEAR_DOWN state will only "stick" once _highEnoughForLandingGear() is false which is hardcoded to 2m
https://github.com/PX4/Firmware/blob/045f6233d4e77de87a2ef9ffe4e81b26bf9c50eb/src/lib/FlightTasks/tasks/AutoMapper/FlightTaskAutoMapper.cpp#L181

I'm reviewing your changes and followed back where the above 2 meters altitude check comes from in case you're interested.
The first occurance of an altitude dependent automatic landing gear triggering comes from
https://github.com/PX4/Firmware/commit/d7683e97a30949f65287d5fa70c8abff161ffd99#diff-fc77c3ef569029d45764664c75d4b0c1R1529
and it was changed to the 2 meters you're seeing today in
https://github.com/PX4/Firmware/commit/bc406a122e35abcb23c075df56b0f279b18f95f2#diff-fc77c3ef569029d45764664c75d4b0c1R1569

The linked pull request is merged. This issue shall be fine to close, @mwiatt isn't it?


workflow gets stuck halfway without any errors

Summary
While running much-used workflow, it got stuck halfway. When running again, it keeps getting stuck, but not always at the same point. Earlier I was able to run this workflow succesfully with the same version on the same cluster, but now it freezes constantly around the same point. Logs of both the pods and workflow-controller do not show errors, the  Labeled pod completed message comes either really late (>12 hrs) or not at all, which containers have succeeded.
The Stuck workflow wait container reports:
time="2021-06-09T13:09:59.825Z" level=info msg="Killing sidecars"
time="2021-06-09T13:09:59.834Z" level=info msg="Alloc=7454 TotalAlloc=16239 Sys=71360 NumGC=5 Goroutines=9"

and workflow-controller keeps posting
Workflow step group node <wf-pod> not yet completed

There are no errors, but when trying to suspend the workflow, it errors with
Failed to suspended <wf-pod>: rpc error: code = DeadlineExceeded desc = Timeout: request did not complete within requested timeout 34s

Diagnostics

AKS v1.19.9
argo v2.12.5, running executor k8sapi, also tried with pns, but with same result
This worked with the same version on the same cluster some time ago

Timeline, gathered info from pod's wait and main, and workflow-controller pod. My workflow is quite long, literally >1k lines, so not really fit for inital post.
controller -- 2021-06-09T13:09:22.843	Pod node hlf-channels-gcrhl-1568537922 initialized Pending
wait -- 2021-06-09T13:09:24.684	Starting Workflow Executor
main -- 2021-06-09 13:09:24.984	Received block: 0 (application process start)
main -- 2021-06-09 13:09:25.588	Successfully submitted proposal to join channel (application process success and finalisation)
wait -- 2021-06-09T13:09:26.566	Alloc=7386 TotalAlloc=16087 Sys=70848 NumGC=5 Goroutines=8
controller -- 2021-06-09T13:09:55.650	Updating node hlf-channels-gcrhl-1568537922 status Pending -> Succeeded"
controller -- 2021-06-09T13:10:29.865	Updating node hlf-channels-gcrhl-1568537922 status Pending -> Succeeded
controller -- <every 20-30 minutes>	Updating node hlf-channels-gcrhl-1568537922 status Pending -> Succeeded
controller -- 2021-06-10T01:51:04.834	Labeled pod completed" namespace=pivt-hlf-acc pod=hlf-channels-gcrhl-1568537922

For this example, it took > 12 hrs for the pod to be labeled complete. In a newer run, this state is not reached after 5 days!!
The only thing the flow is susceptible to, is deletion.
Last words
I have no clue where to continue looking, I hope you guys may have some tips. I asked on slack, but without response.

Message from the maintainers:
Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.

Logs are interesting. Once a node changes from Pending to Succeeded it should not change again.
Can I ask you to test in v3.0?

Thanks for you response, I try to update, but now my controller pod is in a crash loop:
"LEADER_ELECTION_IDENTITY must be set so that the workflow controllers can elect a leader", I tried updating to newer subversions, etc. but with the excat same result. Didn't find out how I can set that env var in my terraform helm release of argo...

Allright, I managed to set that LEADER_ELECTION_IDENTITY to argo. that is out of the way.
Rerunning my flow, now with argo v3.0.7 gives the same behavior, unfortunately...
The workflow that is now stuck, from the controller's logs:
$ k logs -n argo argo-workflow-controller-5db8c85cfc-cbr2r  | grep hlf-channels-vtffm-2152098278
time="2021-06-16T12:29:57.526Z" level=info msg="Pod node hlf-channels-vtffm-2152098278 initialized Pending" namespace=pivt-hlf-acc workflow=hlf-channels-vtffm
time="2021-06-16T12:29:57.550Z" level=info msg="Created pod: hlf-channels-vtffm[12].channel--p0001p0005[2].update-channel--p0001p0005[0].maybe-update-channel--p0001p0005--apg(0) (hlf-channels-vtffm-2152098278)" namespace=pivt-hlf-acc workflow=hlf-channels-vtffm
time="2021-06-16T12:30:31.453Z" level=info msg="Setting node hlf-channels-vtffm-2152098278 outputs" namespace=pivt-hlf-acc workflow=hlf-channels-vtffm
time="2021-06-16T12:30:31.453Z" level=info msg="Updating node hlf-channels-vtffm-2152098278 status Pending -> Succeeded" namespace=pivt-hlf-acc workflow=hlf-channels-vtffm
time="2021-06-16T12:30:31.456Z" level=info msg="Outbound nodes of hlf-channels-vtffm-538289387 is [hlf-channels-vtffm-2152098278]" namespace=pivt-hlf-acc workflow=hlf-channels-vtffm
time="2021-06-16T12:30:31.456Z" level=info msg="Outbound nodes of hlf-channels-vtffm-1560427885 is [hlf-channels-vtffm-2152098278 hlf-channels-vtffm-2811071528]" namespace=pivt-hlf-acc workflow=hlf-channels-vtffm
time="2021-06-16T12:30:31.456Z" level=info msg="Outbound nodes of hlf-channels-vtffm-1560427885 is [hlf-channels-vtffm-2152098278 hlf-channels-vtffm-2811071528]" namespace=pivt-hlf-acc workflow=hlf-channels-vtffm
time="2021-06-16T12:30:31.456Z" level=info msg="Outbound nodes of hlf-channels-vtffm-3670454748 is [hlf-channels-vtffm-2152098278 hlf-channels-vtffm-2811071528]" namespace=pivt-hlf-acc workflow=hlf-channels-vtffm
time="2021-06-16T12:30:31.456Z" level=info msg="SG Outbound nodes of hlf-channels-vtffm-3670454748 are [hlf-channels-vtffm-2152098278 hlf-channels-vtffm-2811071528]" namespace=pivt-hlf-acc workflow=hlf-channels-vtffm
time="2021-06-16T12:31:05.636Z" level=info msg="Setting node hlf-channels-vtffm-2152098278 outputs" namespace=pivt-hlf-acc workflow=hlf-channels-vtffm
time="2021-06-16T12:31:05.636Z" level=info msg="Updating node hlf-channels-vtffm-2152098278 status Pending -> Succeeded" namespace=pivt-hlf-acc workflow=hlf-channels-vtffm
time="2021-06-16T12:31:05.639Z" level=info msg="Outbound nodes of hlf-channels-vtffm-538289387 is [hlf-channels-vtffm-2152098278]" namespace=pivt-hlf-acc workflow=hlf-channels-vtffm
time="2021-06-16T12:31:05.639Z" level=info msg="Outbound nodes of hlf-channels-vtffm-1560427885 is [hlf-channels-vtffm-2152098278 hlf-channels-vtffm-2811071528]" namespace=pivt-hlf-acc workflow=hlf-channels-vtffm
time="2021-06-16T12:31:05.639Z" level=info msg="Outbound nodes of hlf-channels-vtffm-1560427885 is [hlf-channels-vtffm-2152098278 hlf-channels-vtffm-2811071528]" namespace=pivt-hlf-acc workflow=hlf-channels-vtffm
time="2021-06-16T12:31:05.639Z" level=info msg="Outbound nodes of hlf-channels-vtffm-3670454748 is [hlf-channels-vtffm-2152098278 hlf-channels-vtffm-2811071528]" namespace=pivt-hlf-acc workflow=hlf-channels-vtffm
time="2021-06-16T12:31:05.639Z" level=info msg="SG Outbound nodes of hlf-channels-vtffm-3670454748 are [hlf-channels-vtffm-2152098278 hlf-channels-vtffm-2811071528]" namespace=pivt-hlf-acc workflow=hlf-channels-vtffm
time="2021-06-16T12:51:05.659Z" level=info msg="Setting node hlf-channels-vtffm-2152098278 outputs" namespace=pivt-hlf-acc workflow=hlf-channels-vtffm
time="2021-06-16T12:51:05.659Z" level=info msg="Updating node hlf-channels-vtffm-2152098278 status Pending -> Succeeded" namespace=pivt-hlf-acc workflow=hlf-channels-vtffm
time="2021-06-16T12:51:05.661Z" level=info msg="Outbound nodes of hlf-channels-vtffm-538289387 is [hlf-channels-vtffm-2152098278]" namespace=pivt-hlf-acc workflow=hlf-channels-vtffm
time="2021-06-16T12:51:05.661Z" level=info msg="Outbound nodes of hlf-channels-vtffm-1560427885 is [hlf-channels-vtffm-2152098278 hlf-channels-vtffm-2811071528]" namespace=pivt-hlf-acc workflow=hlf-channels-vtffm
time="2021-06-16T12:51:05.662Z" level=info msg="Outbound nodes of hlf-channels-vtffm-1560427885 is [hlf-channels-vtffm-2152098278 hlf-channels-vtffm-2811071528]" namespace=pivt-hlf-acc workflow=hlf-channels-vtffm
time="2021-06-16T12:51:05.662Z" level=info msg="Outbound nodes of hlf-channels-vtffm-3670454748 is [hlf-channels-vtffm-2152098278 hlf-channels-vtffm-2811071528]" namespace=pivt-hlf-acc workflow=hlf-channels-vtffm
time="2021-06-16T12:51:05.662Z" level=info msg="SG Outbound nodes of hlf-channels-vtffm-3670454748 are [hlf-channels-vtffm-2152098278 hlf-channels-vtffm-2811071528]" namespace=pivt-hlf-acc workflow=hlf-channels-vtffm

logs of the subflow's WAIT container:
time="2021-06-16T12:29:59.927Z" level=info msg="Starting Workflow Executor" version=v2.12.5
time="2021-06-16T12:29:59.930Z" level=info msg="Creating PNS executor (namespace: pivt-hlf-acc, pod: hlf-channels-vtffm-2152098278, pid: 23, hasOutputs: false)"
time="2021-06-16T12:29:59.931Z" level=info msg="Executor (version: v2.12.5, build_date: 2021-01-19T22:43:04Z) initialized (pod: pivt-hlf-acc/hlf-channels-vtffm-2152098278) with template: [redacted]"
time="2021-06-16T12:29:59.931Z" level=info msg="Waiting on main container"
time="2021-06-16T12:30:00.688Z" level=info msg="main container started with container ID: 350b080e11490296ff91717cc0afb56108334f6df9a2d7f05cff1a8f48d6a52b"
time="2021-06-16T12:30:00.688Z" level=info msg="Starting annotations monitor"
time="2021-06-16T12:30:00.698Z" level=info msg="Starting deadline monitor"
time="2021-06-16T12:30:00.699Z" level=info msg="containerID 350b080e11490296ff91717cc0afb56108334f6df9a2d7f05cff1a8f48d6a52b mapped to pid 38"
time="2021-06-16T12:30:00.699Z" level=info msg="Main pid identified as 38"
time="2021-06-16T12:30:00.699Z" level=warning msg="Failed to secure file handle on main container's root filesystem. Output artifacts from base image layer will fail"
time="2021-06-16T12:30:00.699Z" level=info msg="Waiting for main pid 38 to complete"
time="2021-06-16T12:30:01.699Z" level=info msg="Main pid 38 completed"
time="2021-06-16T12:30:01.699Z" level=info msg="Main container completed"
time="2021-06-16T12:30:01.699Z" level=info msg="No Script output reference in workflow. Capturing script output ignored"
time="2021-06-16T12:30:01.699Z" level=info msg="Capturing script exit code"
time="2021-06-16T12:30:01.699Z" level=info msg="Annotations monitor stopped"
time="2021-06-16T12:30:01.699Z" level=info msg="Getting exit code of 350b080e11490296ff91717cc0afb56108334f6df9a2d7f05cff1a8f48d6a52b"
time="2021-06-16T12:30:01.706Z" level=info msg="No output parameters"
time="2021-06-16T12:30:01.706Z" level=info msg="No output artifacts"
time="2021-06-16T12:30:01.706Z" level=info msg="Annotating pod with output"
time="2021-06-16T12:30:01.730Z" level=info msg="Killing sidecars"
time="2021-06-16T12:30:01.741Z" level=info msg="Alloc=7264 TotalAlloc=16223 Sys=70848 NumGC=5 Goroutines=9"

System resources look okay, I really don't get what is sinking this boat, suggestions are welcome and appreciated 😃

You, please can you use the v3.0.7 executor image too.

I think you must have something special with your workflow. Can you attach an example that reproduces the issue?

Thanks for the suggestions!
I deleted my installation of argo, and installed it again with ` kubectl apply -f  and after making the necessary service-account changes, I was finally able to run my workflow without issues and quite fast.
conclusion: something was really wrong with my helm-in-terraform deployment of argo-workflow.
thanks again for the suggestions and help, I will close this issue, and keep on digging where thing got screwed up in my own implementation.
Best,
Ludo


merge these models into editor inputs by extending resource editor model

Issue created from code comment with imdone.io

TODO: @sandy merge these models into editor inputs by extending resource editor model id:107
src/vs/workbench/parts/preferences/browser/preferencesService.ts:60
@imdone - Efficiently manage your project's technical debt. imdone.io

Issue closed by removing a comment.

TODO: @sandy merge these models into editor inputs by extending resource editor model id:107 gh:126
src/vs/workbench/parts/preferences/browser/preferencesService.ts:60
@imdone - Efficiently manage your project's technical debt. imdone.io


Gender balance initiative: what actions should we be taking now?

We’re launching the new Academy, and in order to avoid the quotas must now be clever about how we organically balance the applications.
I’ve done a couple of super basic things: reached out to some of the meetups and asked to speak at the end (especially women in tech, etc), and asked specifically for people to tag women on my linkedin post.
This is hardly even a start, however. What should we be doing?

Ideas:
a) launching an event of the Python meetup and/or Lisbon Data Science Meetup. This would have to have at least 50% women (or defeats the purpose), I believe we can do that by controlling the queues.
b) targeting a Google Ads campaign as women who know python. Not sure how much this would cost.
c) asking startup Lx to communicate the Academy in the newsletter, targeting the message specifically at women
d) asking to do talks at universities which aren't engineering schools
e) creating a "buddy system" in which each instructor agrees to chase and persuade at least 3 women to join
f) going through the mailchimp emails, inferring which ones are women and targeting a specific message at that group

Those are great ideas!
We (#marketing) had the idea for segmenting the mailing list + direct FB Ads for Women.
To achieve the quota - for the first wave - we have done the math to how many women we need on the mailing list. I need to check and I’ll write it here ASAP.

Great work Pedro, should we make a campaign (some facebook posts) where we advertise the success of women that were linked to LDSA?

All for it, the issue is that whenever we post on facebook / linkedin etc we reach a lot more dudes than dudettes, so it is not a great way to undo the balance. But promoting women in the Academy context is always a good idea.

Jose Medeiros is working on proposing a fb/IG Ads campaign target to women. We do believe that it’s important.
Here is the data/insights we’ve gathered from the previous batch to achieve the quota:
If we want 50 students on the first wave, considering that all of them convert from the subscribers list we need (with the same behavior of batch 2 as Jose+me researched) we would need an additional of +1.268 subscribers to our actual list.
Breaking down the numbers considering last year conversion rates that we need for this batch:

398 applicants
which 65 will have a score of 6 on the test
50 will pay
for the whole process we want 86 women to meet the 16% rate

Turned this into a Trello Board: https://trello.com/b/3RpihgI0/gender-equality-initiative
Please comment on each card to work on them. LET'S DO THIS THAING!

Hey Pedro,
I don’t have permission to see the board.
Enviado do meu iPhone
No dia 09/03/2019, às 18:18, Pedro Fonseca<EMAIL_ADDRESS>escreveu:

Turned this into a Trello Board: https://trello.com/b/3RpihgI0/gender-equality-initiative
Please comment on each card to work on them. LET'S DO THIS THAING!
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

@carol-Martins that's odd, it belongs to the LDSA org, are you logged in?


SelectState.selectedItem incorrectly typed?

Provide a general summary of the issue here
When using useSelect as described in https://github.com/adobe/react-spectrum/blob/main/packages/%40react-stately/list/src/useSingleSelectListState.ts the type of selectedItem is Node<T> (so not Node<T> | undefined).
This causes issues when turning on @typescript-eslint/no-unnecessary-condition and checking if selectedItem exists, because according to the type it can't be undefined.
🤔 Expected Behavior?
I would expect SelectState.selectedItem  to be typed as Node<T> | undefined.
😯 Current Behavior
When using useSelect as described in https://github.com/adobe/react-spectrum/blob/main/packages/%40react-stately/list/src/useSingleSelectListState.ts the type of selectedItem is Node<T> (so not Node<T> | undefined).
💁 Possible Solution
Type SelectState.selectedItem to be Node<T> | undefined.
🔦 Context
This is causing issues because from types it's not clear the value could possibly be undefined.
🖥 Steps to Reproduce
Can reproduce it here, at least you can inspect selectedItem and see that the type is Node<T>, eslint rule isn't complaining, I guess because it needs typing and isn't being run on codesandbox.
Version
3.28.0
What browsers are you seeing the problem on?
Other
If other, please specify.
No response
What operating system are you using?
Mac OS 14.0 (23A344)
🧢 Your Company/Team
No response
🕷 Tracking Issue
No response

We are incrementally adding support for Typescript's Strict Mode, so this should get handled here: https://github.com/adobe/react-spectrum/issues/3183. We plan on tackling more of these soon. I'll close this as a duplicate.


WIP：Update Inbound cluster LbEndpoint address to public ones instead of loopback

fixes: #14662

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: hzxuzhonghu
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pilot/OWNERS [hzxuzhonghu]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

I am not sure whether we should add both loopback and public addresses to the inbound cluster's LbEndpoints

@hzxuzhonghu: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-trustdomain.sh
47b7894ea5ad278a723041fe1e41992101120345
link
/test e2e-bookInfoTests-trustdomain-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-trustdomain.sh
47b7894ea5ad278a723041fe1e41992101120345
link
/test e2e-bookInfoTests-trustdomain-master

prow/e2e-bookInfoTests-v1alpha3.sh
47b7894ea5ad278a723041fe1e41992101120345
link
/test e2e-bookInfoTests-envoyv2-v1alpha3-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-trustdomain.sh
47b7894ea5ad278a723041fe1e41992101120345
link
/test e2e-bookInfoTests-trustdomain-master

prow/e2e-bookInfoTests-v1alpha3.sh
47b7894ea5ad278a723041fe1e41992101120345
link
/test e2e-bookInfoTests-envoyv2-v1alpha3-master

prow/e2e-simpleTests.sh
47b7894ea5ad278a723041fe1e41992101120345
link
/test e2e-simpleTests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-trustdomain.sh
47b7894ea5ad278a723041fe1e41992101120345
link
/test e2e-bookInfoTests-trustdomain-master

prow/e2e-bookInfoTests-v1alpha3.sh
47b7894ea5ad278a723041fe1e41992101120345
link
/test e2e-bookInfoTests-envoyv2-v1alpha3-master

prow/e2e-simpleTests.sh
47b7894ea5ad278a723041fe1e41992101120345
link
/test e2e-simpleTests-master

prow/e2e-simpleTests-minProfile.sh
47b7894ea5ad278a723041fe1e41992101120345
link
/test e2e-simpleTestsMinProfile-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-trustdomain.sh
47b7894ea5ad278a723041fe1e41992101120345
link
/test e2e-bookInfoTests-trustdomain-master

prow/e2e-bookInfoTests-v1alpha3.sh
47b7894ea5ad278a723041fe1e41992101120345
link
/test e2e-bookInfoTests-envoyv2-v1alpha3-master

prow/e2e-simpleTests.sh
47b7894ea5ad278a723041fe1e41992101120345
link
/test e2e-simpleTests-master

prow/e2e-simpleTests-minProfile.sh
47b7894ea5ad278a723041fe1e41992101120345
link
/test e2e-simpleTestsMinProfile-master

prow/e2e-simpleTests-cni.sh
47b7894ea5ad278a723041fe1e41992101120345
link
/test e2e-simpleTests-cni-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-trustdomain.sh
47b7894ea5ad278a723041fe1e41992101120345
link
/test e2e-bookInfoTests-trustdomain-master

prow/e2e-bookInfoTests-v1alpha3.sh
47b7894ea5ad278a723041fe1e41992101120345
link
/test e2e-bookInfoTests-envoyv2-v1alpha3-master

prow/e2e-simpleTests.sh
47b7894ea5ad278a723041fe1e41992101120345
link
/test e2e-simpleTests-master

prow/e2e-simpleTests-minProfile.sh
47b7894ea5ad278a723041fe1e41992101120345
link
/test e2e-simpleTestsMinProfile-master

prow/e2e-simpleTests-cni.sh
47b7894ea5ad278a723041fe1e41992101120345
link
/test e2e-simpleTests-cni-master

prow/integ-telemetry-k8s-presubmit-tests.sh
47b7894ea5ad278a723041fe1e41992101120345
link
/test integ-telemetry-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-trustdomain.sh
47b7894ea5ad278a723041fe1e41992101120345
link
/test e2e-bookInfoTests-trustdomain-master

prow/e2e-bookInfoTests-v1alpha3.sh
47b7894ea5ad278a723041fe1e41992101120345
link
/test e2e-bookInfoTests-envoyv2-v1alpha3-master

prow/e2e-simpleTests.sh
47b7894ea5ad278a723041fe1e41992101120345
link
/test e2e-simpleTests-master

prow/e2e-simpleTests-minProfile.sh
47b7894ea5ad278a723041fe1e41992101120345
link
/test e2e-simpleTestsMinProfile-master

prow/e2e-simpleTests-cni.sh
47b7894ea5ad278a723041fe1e41992101120345
link
/test e2e-simpleTests-cni-master

prow/integ-telemetry-k8s-presubmit-tests.sh
47b7894ea5ad278a723041fe1e41992101120345
link
/test integ-telemetry-k8s-presubmit-tests-master

prow/e2e-dashboard.sh
47b7894ea5ad278a723041fe1e41992101120345
link
/test e2e-dashboard-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-trustdomain.sh
47b7894ea5ad278a723041fe1e41992101120345
link
/test e2e-bookInfoTests-trustdomain-master

prow/e2e-bookInfoTests-v1alpha3.sh
47b7894ea5ad278a723041fe1e41992101120345
link
/test e2e-bookInfoTests-envoyv2-v1alpha3-master

prow/e2e-simpleTests.sh
47b7894ea5ad278a723041fe1e41992101120345
link
/test e2e-simpleTests-master

prow/e2e-simpleTests-minProfile.sh
47b7894ea5ad278a723041fe1e41992101120345
link
/test e2e-simpleTestsMinProfile-master

prow/e2e-simpleTests-cni.sh
47b7894ea5ad278a723041fe1e41992101120345
link
/test e2e-simpleTests-cni-master

prow/integ-telemetry-k8s-presubmit-tests.sh
47b7894ea5ad278a723041fe1e41992101120345
link
/test integ-telemetry-k8s-presubmit-tests-master

prow/e2e-dashboard.sh
47b7894ea5ad278a723041fe1e41992101120345
link
/test e2e-dashboard-master

prow/e2e_pilotv2_auth_sds.sh
47b7894ea5ad278a723041fe1e41992101120345
link
/test istio_auth_sds_e2e-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-trustdomain.sh
47b7894ea5ad278a723041fe1e41992101120345
link
/test e2e-bookInfoTests-trustdomain-master

prow/e2e-bookInfoTests-v1alpha3.sh
47b7894ea5ad278a723041fe1e41992101120345
link
/test e2e-bookInfoTests-envoyv2-v1alpha3-master

prow/e2e-simpleTests.sh
47b7894ea5ad278a723041fe1e41992101120345
link
/test e2e-simpleTests-master

prow/e2e-simpleTests-minProfile.sh
47b7894ea5ad278a723041fe1e41992101120345
link
/test e2e-simpleTestsMinProfile-master

prow/e2e-simpleTests-cni.sh
47b7894ea5ad278a723041fe1e41992101120345
link
/test e2e-simpleTests-cni-master

prow/integ-telemetry-k8s-presubmit-tests.sh
47b7894ea5ad278a723041fe1e41992101120345
link
/test integ-telemetry-k8s-presubmit-tests-master

prow/e2e-dashboard.sh
47b7894ea5ad278a723041fe1e41992101120345
link
/test e2e-dashboard-master

prow/e2e_pilotv2_auth_sds.sh
47b7894ea5ad278a723041fe1e41992101120345
link
/test istio_auth_sds_e2e-master

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
47b7894ea5ad278a723041fe1e41992101120345
link
/test istio-pilot-e2e-envoyv2-v1alpha3-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-trustdomain.sh
47b7894ea5ad278a723041fe1e41992101120345
link
/test e2e-bookInfoTests-trustdomain-master

prow/e2e-bookInfoTests-v1alpha3.sh
47b7894ea5ad278a723041fe1e41992101120345
link
/test e2e-bookInfoTests-envoyv2-v1alpha3-master

prow/e2e-simpleTests.sh
47b7894ea5ad278a723041fe1e41992101120345
link
/test e2e-simpleTests-master

prow/e2e-simpleTests-minProfile.sh
47b7894ea5ad278a723041fe1e41992101120345
link
/test e2e-simpleTestsMinProfile-master

prow/e2e-simpleTests-cni.sh
47b7894ea5ad278a723041fe1e41992101120345
link
/test e2e-simpleTests-cni-master

prow/integ-telemetry-k8s-presubmit-tests.sh
47b7894ea5ad278a723041fe1e41992101120345
link
/test integ-telemetry-k8s-presubmit-tests-master

prow/e2e-dashboard.sh
47b7894ea5ad278a723041fe1e41992101120345
link
/test e2e-dashboard-master

prow/e2e_pilotv2_auth_sds.sh
47b7894ea5ad278a723041fe1e41992101120345
link
/test istio_auth_sds_e2e-master

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
47b7894ea5ad278a723041fe1e41992101120345
link
/test istio-pilot-e2e-envoyv2-v1alpha3-master

prow/integ-mixer-k8s-presubmit-tests.sh
47b7894ea5ad278a723041fe1e41992101120345
link
/test integ-mixer-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-trustdomain.sh
47b7894ea5ad278a723041fe1e41992101120345
link
/test e2e-bookInfoTests-trustdomain-master

prow/e2e-bookInfoTests-v1alpha3.sh
47b7894ea5ad278a723041fe1e41992101120345
link
/test e2e-bookInfoTests-envoyv2-v1alpha3-master

prow/e2e-simpleTests.sh
47b7894ea5ad278a723041fe1e41992101120345
link
/test e2e-simpleTests-master

prow/e2e-simpleTests-minProfile.sh
47b7894ea5ad278a723041fe1e41992101120345
link
/test e2e-simpleTestsMinProfile-master

prow/e2e-simpleTests-cni.sh
47b7894ea5ad278a723041fe1e41992101120345
link
/test e2e-simpleTests-cni-master

prow/integ-telemetry-k8s-presubmit-tests.sh
47b7894ea5ad278a723041fe1e41992101120345
link
/test integ-telemetry-k8s-presubmit-tests-master

prow/e2e-dashboard.sh
47b7894ea5ad278a723041fe1e41992101120345
link
/test e2e-dashboard-master

prow/e2e_pilotv2_auth_sds.sh
47b7894ea5ad278a723041fe1e41992101120345
link
/test istio_auth_sds_e2e-master

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
47b7894ea5ad278a723041fe1e41992101120345
link
/test istio-pilot-e2e-envoyv2-v1alpha3-master

prow/integ-mixer-k8s-presubmit-tests.sh
47b7894ea5ad278a723041fe1e41992101120345
link
/test integ-mixer-k8s-presubmit-tests-master

prow/e2e-mixer-no_auth.sh
47b7894ea5ad278a723041fe1e41992101120345
link
/test e2e-mixer-no_auth-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-trustdomain.sh
47b7894ea5ad278a723041fe1e41992101120345
link
/test e2e-bookInfoTests-trustdomain-master

prow/e2e-bookInfoTests-v1alpha3.sh
47b7894ea5ad278a723041fe1e41992101120345
link
/test e2e-bookInfoTests-envoyv2-v1alpha3-master

prow/e2e-simpleTests.sh
47b7894ea5ad278a723041fe1e41992101120345
link
/test e2e-simpleTests-master

prow/e2e-simpleTests-minProfile.sh
47b7894ea5ad278a723041fe1e41992101120345
link
/test e2e-simpleTestsMinProfile-master

prow/e2e-simpleTests-cni.sh
47b7894ea5ad278a723041fe1e41992101120345
link
/test e2e-simpleTests-cni-master

prow/integ-telemetry-k8s-presubmit-tests.sh
47b7894ea5ad278a723041fe1e41992101120345
link
/test integ-telemetry-k8s-presubmit-tests-master

prow/e2e-dashboard.sh
47b7894ea5ad278a723041fe1e41992101120345
link
/test e2e-dashboard-master

prow/e2e_pilotv2_auth_sds.sh
47b7894ea5ad278a723041fe1e41992101120345
link
/test istio_auth_sds_e2e-master

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
47b7894ea5ad278a723041fe1e41992101120345
link
/test istio-pilot-e2e-envoyv2-v1alpha3-master

prow/integ-mixer-k8s-presubmit-tests.sh
47b7894ea5ad278a723041fe1e41992101120345
link
/test integ-mixer-k8s-presubmit-tests-master

prow/e2e-mixer-no_auth.sh
47b7894ea5ad278a723041fe1e41992101120345
link
/test e2e-mixer-no_auth-master

prow/integ-pilot-k8s-presubmit-tests.sh
47b7894ea5ad278a723041fe1e41992101120345
link
/test integ-pilot-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-trustdomain.sh
47b7894ea5ad278a723041fe1e41992101120345
link
/test e2e-bookInfoTests-trustdomain-master

prow/e2e-bookInfoTests-v1alpha3.sh
47b7894ea5ad278a723041fe1e41992101120345
link
/test e2e-bookInfoTests-envoyv2-v1alpha3-master

prow/e2e-simpleTests.sh
47b7894ea5ad278a723041fe1e41992101120345
link
/test e2e-simpleTests-master

prow/e2e-simpleTests-minProfile.sh
47b7894ea5ad278a723041fe1e41992101120345
link
/test e2e-simpleTestsMinProfile-master

prow/e2e-simpleTests-cni.sh
47b7894ea5ad278a723041fe1e41992101120345
link
/test e2e-simpleTests-cni-master

prow/integ-telemetry-k8s-presubmit-tests.sh
47b7894ea5ad278a723041fe1e41992101120345
link
/test integ-telemetry-k8s-presubmit-tests-master

prow/e2e-dashboard.sh
47b7894ea5ad278a723041fe1e41992101120345
link
/test e2e-dashboard-master

prow/e2e_pilotv2_auth_sds.sh
47b7894ea5ad278a723041fe1e41992101120345
link
/test istio_auth_sds_e2e-master

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
47b7894ea5ad278a723041fe1e41992101120345
link
/test istio-pilot-e2e-envoyv2-v1alpha3-master

prow/integ-mixer-k8s-presubmit-tests.sh
47b7894ea5ad278a723041fe1e41992101120345
link
/test integ-mixer-k8s-presubmit-tests-master

prow/e2e-mixer-no_auth.sh
47b7894ea5ad278a723041fe1e41992101120345
link
/test e2e-mixer-no_auth-master

prow/integ-pilot-k8s-presubmit-tests.sh
47b7894ea5ad278a723041fe1e41992101120345
link
/test integ-pilot-k8s-presubmit-tests-master

prow/istio-pilot-multicluster-e2e.sh
47b7894ea5ad278a723041fe1e41992101120345
link
/test istio-pilot-multicluster-e2e-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-trustdomain.sh
47b7894ea5ad278a723041fe1e41992101120345
link
/test e2e-bookInfoTests-trustdomain-master

prow/e2e-bookInfoTests-v1alpha3.sh
47b7894ea5ad278a723041fe1e41992101120345
link
/test e2e-bookInfoTests-envoyv2-v1alpha3-master

prow/e2e-simpleTests.sh
47b7894ea5ad278a723041fe1e41992101120345
link
/test e2e-simpleTests-master

prow/e2e-simpleTests-minProfile.sh
47b7894ea5ad278a723041fe1e41992101120345
link
/test e2e-simpleTestsMinProfile-master

prow/e2e-simpleTests-cni.sh
47b7894ea5ad278a723041fe1e41992101120345
link
/test e2e-simpleTests-cni-master

prow/integ-telemetry-k8s-presubmit-tests.sh
47b7894ea5ad278a723041fe1e41992101120345
link
/test integ-telemetry-k8s-presubmit-tests-master

prow/e2e-dashboard.sh
47b7894ea5ad278a723041fe1e41992101120345
link
/test e2e-dashboard-master

prow/e2e_pilotv2_auth_sds.sh
47b7894ea5ad278a723041fe1e41992101120345
link
/test istio_auth_sds_e2e-master

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
47b7894ea5ad278a723041fe1e41992101120345
link
/test istio-pilot-e2e-envoyv2-v1alpha3-master

prow/integ-mixer-k8s-presubmit-tests.sh
47b7894ea5ad278a723041fe1e41992101120345
link
/test integ-mixer-k8s-presubmit-tests-master

prow/e2e-mixer-no_auth.sh
47b7894ea5ad278a723041fe1e41992101120345
link
/test e2e-mixer-no_auth-master

prow/integ-pilot-k8s-presubmit-tests.sh
47b7894ea5ad278a723041fe1e41992101120345
link
/test integ-pilot-k8s-presubmit-tests-master

prow/istio-pilot-multicluster-e2e.sh
47b7894ea5ad278a723041fe1e41992101120345
link
/test istio-pilot-multicluster-e2e-master

prow/integ-security-k8s-presubmit-tests.sh
47b7894ea5ad278a723041fe1e41992101120345
link
/test integ-security-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: hzxuzhonghu
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: rshriram
If they are not already assigned, you can assign the PR to them by writing /assign @rshriram in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hzxuzhonghu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-trustdomain.sh
47b7894ea5ad278a723041fe1e41992101120345
link
/test e2e-bookInfoTests-trustdomain-master

prow/e2e-bookInfoTests-v1alpha3.sh
47b7894ea5ad278a723041fe1e41992101120345
link
/test e2e-bookInfoTests-envoyv2-v1alpha3-master

prow/e2e-simpleTests.sh
47b7894ea5ad278a723041fe1e41992101120345
link
/test e2e-simpleTests-master

prow/e2e-simpleTests-minProfile.sh
47b7894ea5ad278a723041fe1e41992101120345
link
/test e2e-simpleTestsMinProfile-master

prow/e2e-simpleTests-cni.sh
47b7894ea5ad278a723041fe1e41992101120345
link
/test e2e-simpleTests-cni-master

prow/integ-telemetry-k8s-presubmit-tests.sh
47b7894ea5ad278a723041fe1e41992101120345
link
/test integ-telemetry-k8s-presubmit-tests-master

prow/e2e-dashboard.sh
47b7894ea5ad278a723041fe1e41992101120345
link
/test e2e-dashboard-master

prow/e2e_pilotv2_auth_sds.sh
47b7894ea5ad278a723041fe1e41992101120345
link
/test istio_auth_sds_e2e-master

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
47b7894ea5ad278a723041fe1e41992101120345
link
/test istio-pilot-e2e-envoyv2-v1alpha3-master

prow/integ-mixer-k8s-presubmit-tests.sh
47b7894ea5ad278a723041fe1e41992101120345
link
/test integ-mixer-k8s-presubmit-tests-master

prow/e2e-mixer-no_auth.sh
47b7894ea5ad278a723041fe1e41992101120345
link
/test e2e-mixer-no_auth-master

prow/integ-pilot-k8s-presubmit-tests.sh
47b7894ea5ad278a723041fe1e41992101120345
link
/test integ-pilot-k8s-presubmit-tests-master

prow/istio-pilot-multicluster-e2e.sh
47b7894ea5ad278a723041fe1e41992101120345
link
/test istio-pilot-multicluster-e2e-master

prow/integ-security-k8s-presubmit-tests.sh
47b7894ea5ad278a723041fe1e41992101120345
link
/test integ-security-k8s-presubmit-tests-master

prow/istio-unit-tests.sh
d26fa688bd703698ac8b909515215b08f2643336
link
/test istio-unit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-trustdomain.sh
47b7894ea5ad278a723041fe1e41992101120345
link
/test e2e-bookInfoTests-trustdomain-master

prow/e2e-bookInfoTests-v1alpha3.sh
47b7894ea5ad278a723041fe1e41992101120345
link
/test e2e-bookInfoTests-envoyv2-v1alpha3-master

prow/e2e_pilotv2_auth_sds.sh
47b7894ea5ad278a723041fe1e41992101120345
link
/test istio_auth_sds_e2e-master

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
47b7894ea5ad278a723041fe1e41992101120345
link
/test istio-pilot-e2e-envoyv2-v1alpha3-master

prow/integ-mixer-k8s-presubmit-tests.sh
47b7894ea5ad278a723041fe1e41992101120345
link
/test integ-mixer-k8s-presubmit-tests-master

prow/e2e-mixer-no_auth.sh
47b7894ea5ad278a723041fe1e41992101120345
link
/test e2e-mixer-no_auth-master

prow/integ-pilot-k8s-presubmit-tests.sh
47b7894ea5ad278a723041fe1e41992101120345
link
/test integ-pilot-k8s-presubmit-tests-master

prow/istio-pilot-multicluster-e2e.sh
47b7894ea5ad278a723041fe1e41992101120345
link
/test istio-pilot-multicluster-e2e-master

prow/integ-security-k8s-presubmit-tests.sh
47b7894ea5ad278a723041fe1e41992101120345
link
/test integ-security-k8s-presubmit-tests-master

prow/istio-unit-tests.sh
d26fa688bd703698ac8b909515215b08f2643336
link
/test istio-unit-tests-master

prow/e2e-simpleTests-cni.sh
d26fa688bd703698ac8b909515215b08f2643336
link
/test e2e-simpleTests-cni-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-trustdomain.sh
47b7894ea5ad278a723041fe1e41992101120345
link
/test e2e-bookInfoTests-trustdomain-master

prow/e2e-bookInfoTests-v1alpha3.sh
47b7894ea5ad278a723041fe1e41992101120345
link
/test e2e-bookInfoTests-envoyv2-v1alpha3-master

prow/e2e_pilotv2_auth_sds.sh
47b7894ea5ad278a723041fe1e41992101120345
link
/test istio_auth_sds_e2e-master

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
47b7894ea5ad278a723041fe1e41992101120345
link
/test istio-pilot-e2e-envoyv2-v1alpha3-master

prow/integ-mixer-k8s-presubmit-tests.sh
47b7894ea5ad278a723041fe1e41992101120345
link
/test integ-mixer-k8s-presubmit-tests-master

prow/e2e-mixer-no_auth.sh
47b7894ea5ad278a723041fe1e41992101120345
link
/test e2e-mixer-no_auth-master

prow/istio-pilot-multicluster-e2e.sh
47b7894ea5ad278a723041fe1e41992101120345
link
/test istio-pilot-multicluster-e2e-master

prow/integ-security-k8s-presubmit-tests.sh
47b7894ea5ad278a723041fe1e41992101120345
link
/test integ-security-k8s-presubmit-tests-master

prow/istio-unit-tests.sh
d26fa688bd703698ac8b909515215b08f2643336
link
/test istio-unit-tests-master

prow/e2e-simpleTests-cni.sh
d26fa688bd703698ac8b909515215b08f2643336
link
/test e2e-simpleTests-cni-master

prow/integ-pilot-k8s-presubmit-tests.sh
d26fa688bd703698ac8b909515215b08f2643336
link
/test integ-pilot-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e_pilotv2_auth_sds.sh
47b7894ea5ad278a723041fe1e41992101120345
link
/test istio_auth_sds_e2e-master

prow/istio-pilot-multicluster-e2e.sh
47b7894ea5ad278a723041fe1e41992101120345
link
/test istio-pilot-multicluster-e2e-master

prow/integ-security-k8s-presubmit-tests.sh
47b7894ea5ad278a723041fe1e41992101120345
link
/test integ-security-k8s-presubmit-tests-master

prow/istio-unit-tests.sh
d26fa688bd703698ac8b909515215b08f2643336
link
/test istio-unit-tests-master

prow/e2e-simpleTests-cni.sh
d26fa688bd703698ac8b909515215b08f2643336
link
/test e2e-simpleTests-cni-master

prow/integ-pilot-k8s-presubmit-tests.sh
d26fa688bd703698ac8b909515215b08f2643336
link
/test integ-pilot-k8s-presubmit-tests-master

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
d26fa688bd703698ac8b909515215b08f2643336
link
/test istio-pilot-e2e-envoyv2-v1alpha3-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
47b7894ea5ad278a723041fe1e41992101120345
link
/test istio-pilot-multicluster-e2e-master

prow/integ-security-k8s-presubmit-tests.sh
47b7894ea5ad278a723041fe1e41992101120345
link
/test integ-security-k8s-presubmit-tests-master

prow/istio-unit-tests.sh
d26fa688bd703698ac8b909515215b08f2643336
link
/test istio-unit-tests-master

prow/e2e-simpleTests-cni.sh
d26fa688bd703698ac8b909515215b08f2643336
link
/test e2e-simpleTests-cni-master

prow/integ-pilot-k8s-presubmit-tests.sh
d26fa688bd703698ac8b909515215b08f2643336
link
/test integ-pilot-k8s-presubmit-tests-master

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
d26fa688bd703698ac8b909515215b08f2643336
link
/test istio-pilot-e2e-envoyv2-v1alpha3-master

prow/e2e_pilotv2_auth_sds.sh
d26fa688bd703698ac8b909515215b08f2643336
link
/test istio_auth_sds_e2e-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-security-k8s-presubmit-tests.sh
47b7894ea5ad278a723041fe1e41992101120345
link
/test integ-security-k8s-presubmit-tests-master

prow/istio-unit-tests.sh
d26fa688bd703698ac8b909515215b08f2643336
link
/test istio-unit-tests-master

prow/e2e-simpleTests-cni.sh
d26fa688bd703698ac8b909515215b08f2643336
link
/test e2e-simpleTests-cni-master

prow/integ-pilot-k8s-presubmit-tests.sh
d26fa688bd703698ac8b909515215b08f2643336
link
/test integ-pilot-k8s-presubmit-tests-master

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
d26fa688bd703698ac8b909515215b08f2643336
link
/test istio-pilot-e2e-envoyv2-v1alpha3-master

prow/e2e_pilotv2_auth_sds.sh
d26fa688bd703698ac8b909515215b08f2643336
link
/test istio_auth_sds_e2e-master

prow/istio-pilot-multicluster-e2e.sh
d26fa688bd703698ac8b909515215b08f2643336
link
/test istio-pilot-multicluster-e2e-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
d26fa688bd703698ac8b909515215b08f2643336
link
/test istio-unit-tests-master

prow/e2e-simpleTests-cni.sh
d26fa688bd703698ac8b909515215b08f2643336
link
/test e2e-simpleTests-cni-master

prow/integ-pilot-k8s-presubmit-tests.sh
d26fa688bd703698ac8b909515215b08f2643336
link
/test integ-pilot-k8s-presubmit-tests-master

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
d26fa688bd703698ac8b909515215b08f2643336
link
/test istio-pilot-e2e-envoyv2-v1alpha3-master

prow/e2e_pilotv2_auth_sds.sh
d26fa688bd703698ac8b909515215b08f2643336
link
/test istio_auth_sds_e2e-master

prow/istio-pilot-multicluster-e2e.sh
d26fa688bd703698ac8b909515215b08f2643336
link
/test istio-pilot-multicluster-e2e-master

prow/integ-security-k8s-presubmit-tests.sh
d26fa688bd703698ac8b909515215b08f2643336
link
/test integ-security-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Found that changing inbound cluster endpoints from <IP_ADDRESS> to podip will cause backward compatibility .

@hzxuzhonghu: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

I think @silentdai is working on this with a better solution.


Global cache HTML sizes

Too many cache misses. Should be a singleton. Cache on html string and width. Maybe we can shorten the string or grab some substr so we aren’t keying with huge strings.

Bug Report Dump (Auto-generated)

Version 1.11.0 (1943)
Device: iPhone 7 Plus (iOS 11.0.1)
TestFlight: false

Can we not just use the hash value of the html as the key?
Sent with GitHawk

Ya that’ll work! Even “\(width)\(html.hash)” would be perfect.
Sent with GitHawk


Fix links with anchor element

AEM has a lot of links using the anchor element to jump directly to an id of a page. This doesn't work in the Next.js solution because of the added .html part. Example from wind:
 UK Wind
Ideally, the url should just be href="#uk-wind" if it is on the same page, and without the .html  UK Wind  if it's on another page.

Fixed in the migration script.


[BUG] - use disabledFeatures=learningDashboard instead of learningDashboardEnabled=false

BBB 2.5 complains about:
WARN  o.b.api.ParamsProcessorUtil - [DEPRECATION] use disabledFeatures=learningDashboard instead of learningDashboardEnabled=false

This also applies to "breakoutRoomsEnabled=true".

From discussing this in the matrix channel, it would seem best to either create two dictionaries (default and custom config) that can be traversed in the template or define a name prefix like bbb_conf_* and use
lookup('ansible.builtin.varnames', '^bbb_conf_.+')
to access them in the template. The latter option would make it easier to override defaults.


Add macOS 11 to the GitHub Actions tests

Signed-off-by: Tim Smith<EMAIL_ADDRESS>

Yeah I'm struggling to find a dmg that has a pkg file in it that isn't something complex like Virtualbox. I'm tempted to just write some BS thing and poop out an omnibus package of it.


Binary operator functions failure?

Hi,
I run the following code which uses the binary operator function .mul to multiply a dataframe by 1.0 and then assert that the operation should result in the same dataframe, however, the test fails indeterminately?
import pandas as pd, numpy as np
from pandas.util.testing import assert_frame_equal
np.random.seed(42)

d_index = pd.date_range(start='2000-01-01', end='2015-07-01', freq='B')
t_index = np.sort(np.random.choice(d_index,2000,replace=False))
tmp = pd.DataFrame(np.ones((t_index.shape[0], 1000)), index=t_index)

def same_dataframes(df1,df2):
    try:
        assert_frame_equal(df1,df2)
    except:
        return False
    return True

for i in range(100):
    if not same_dataframes(tmp.mul(1.0, axis=1), tmp.mul(1.0, axis=1)):
        print i, 'The Frames Are Not Equal'

It returns the following:
2 The Frames Are Not Equal
4 The Frames Are Not Equal
9 The Frames Are Not Equal
17 The Frames Are Not Equal
20 The Frames Are Not Equal
62 The Frames Are Not Equal
63 The Frames Are Not Equal
67 The Frames Are Not Equal
69 The Frames Are Not Equal
85 The Frames Are Not Equal

Additionally, when I try the following it passes every time:
 for i in range(500):
     if not same_dataframes(tmp.apply(lambda x: x * 1.0), tmp.apply(lambda x: x * 1.0)):
         print i, 'The Frames Are Not Equal'

I tried running other binary operators such as .ge, .gt, .lt, .le and also received fails in random cases
Thank you

Seems ok to me
In [88]: np.array([ (tmp.mul(1.0,axis=1)).equals(tmp.mul(1.0,axis=1)) for i in range(100) ]).all()
Out[88]: True

you also didn't specify pd.show_versions().


Add coin swap category to wallet page

It comes to my mind, that some wallets have functionality that isn't covered by the website currently. Defi, coin swaps, and multi-currency (two of those have some overlap).
Coin swaps at least seems like a thing that people might wish to search for.

I think we should not promote coin swap if we want dogecoin adoption :)

0x9AA297eE92Ed11e6d688C9d8B345bBffE6177655

I think we should not promote coin swap if we want dogecoin adoption :)

If you want adoption... you'll need as many on-ramps as you can get?

Dono if I'm not thinking right, I see every swap a way for people to gamble inested of using it as it is

Gamblers be gambling regardless - they'll just do it on RH anyway. I'm not a gambler myself, yet I have ever since AMMs were a thing been using them. Better: the community has also used these, in combination with bridges, to buy people's locked up DOGE on Binance and provide them with means to exit an illiquid situation that they were victimized into without any wrongdoing of their own. To me, this means that there is a real and proven use-case for permissionless swaps.

I understand that many can start in a different coin and there is no easy way possible to swap

Yes, I think that liquidity is important, and I think that off-CEX liquidity is probably even more important. Both on- and off-ramps have legit use cases.

In your opinion, would you add it as a filter on wallets page

It could be useful in my opinion because this is an actual feature. Recommend to check with your lawyers whether you can do this though - since copyright was taken into "dogecoin foundation", you have hard compliance requirements for this website in 3 different jurisdictions.

Sorry the late reply, I had so many email notifications that only now at 2am I saw this :)
I will add it to the website in the morning :)


Opening a file, it stays inside the small window? Part II

Same issue as the other gentleman was having: https://github.com/kevinhwang91/rnvimr/issues/23. Everything is working fine, except that any file I open (for example .py) opens inside the pop up window.

Running :checkhealth rnvimr

health#rnvimr#check
========================================================================
## OS
  - OK: Name: Linux

## Ranger
  - OK: Version: ranger 1.9.3

## Python
  - OK: Version: 3.8.2 (default, Jul 16 2020, 14:00:26) [GCC 9.3.0]

## Pynvim
  - OK: Version: 0.4.1

## Ueberzug (optional)
  - OK: Ueberzug is ready

## RPC
  - OK: RPC echo: Neovim send "Give me five!" and receive "Give me five!"

Running a minimal configuration like this will also cause the error:

call plug#begin('~/.config/nvim/plugged')
Plug 'kevinhwang91/rnvimr'
tnoremap <silent> <M-i> <C-\><C-n>:RnvimrResize<CR>
nnoremap <silent> <M-o> :RnvimrToggle<CR>
tnoremap <silent> <M-o> <C-\><C-n>:RnvimrToggle<CR>
call plug#end()

I can't reproduce this issue.

I'm not sure what your config about rifle.conf, so please add let g:rnvimr_vanilla = 1 to your init.vim, it will make rnvimr use default config for ranger.

Do anyfile mean all files? It seems that rpc is broken.

g:rnvimr_vanilla = 1
This worked perfectly!
Though I don't know what is wrong with my rifle.conf file, here it is:
rifle.txt

-mime ^text,  label editor = nvim -- "$@"
+mime ^text,  label editor = ${VISUAL:-$EDITOR} -- "$@"

rnvimr will replace command of ${VISUAL:-$EDITOR}  with rpc request.

Hi @kevinhwang91
I've got the same issue even though I used g:rnvimr_vanilla = 1 in init.vim
Also, the colorschemes for ranger and rnvimr are different
Any help would be appreciated. Thanks


SCB-581 static data return instance count by domain

Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Make sure there is a JIRA issue filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
[ ] Each commit in the pull request should have a meaningful subject line and body.
[ ] Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
[ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Run go build go test go fmt go vet to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

Coverage decreased (-0.1%) to 73.402% when pulling 9716f5e18d2e1ef392dbb64943a7e668d46874f8 on aseTo2016:master into 772adf7f611d5deb9eebb3a7265f3a6ef350bd9b on apache:master.

Codecov Report

Merging #350 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #350      +/-   ##
==========================================
- Coverage   69.95%   69.92%   -0.03%
==========================================
  Files          17       17
  Lines        3418     3418
==========================================
- Hits         2391     2390       -1
  Misses        863      863
- Partials      164      165       +1

Impacted Files
Coverage Δ

server/service/rule.go
76.82% <0%> (-0.43%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 772adf7...9716f5e. Read the comment docs.


Correct issues affecting LGTM score.

Closes #877
Corrected coding issues in two files that affected the LGTM score.
Also added the LGTM badge to the Readme.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Apologies if I was not supposed to push the updated version of my branch. I just saw the "dismissed stale review" comment. Not sure if I was supposed to do something different. I'm reading up on that now. I'm very new to all this, so trying to get it right. Either way, lines 166-168 should now be corrected. Thanks.

Apologies if I was not supposed to push the updated version of my branch.

Nope, that's fine. Github just discards the review approval after any changes.

Merged, thank you!


PHP Notice:  Undefined variable: key_comment

Q
A

Issue Type
Bug

Deployer Version
3.3.0

Description
➤ Executing task deploy:prepare
PHP Notice:  Undefined variable: key_comment in phar:///usr/local/bin/dep/vendor/phpseclib/phpseclib/phpseclib/System/SSH/Agent.php on line 180

I think this is problem of phpseclib. You should report for phpseclib projects

strange because they changed it in head version https://github.com/phpseclib/phpseclib/blob/master/phpseclib/System/SSH/Agent.php
but in your composer it downloads older with that bug
$key->loadKey('ssh-rsa ' . base64_encode($key_blob) . ' ' . $key_comment);

Deployer using a stable version of phpseclib. But this change of phpseclib only exist on master branch and not include any stable version >= 2.0.
This problem will be resolved after phpseclib release a new version 2.x

Thx

ok, phpseclib released

Installing phpseclib/phpseclib (2.0.2)

Can you upgrade deployer.phar ?

Close this issue. Please follow #712

Hey guys, I'm still having this issue.

I'll try to upgrade phpseclib.


Definitive solution for Lock error not acquired/owned by you

@CheshireCaat
Hello, I would like to open a new issue to know if there is an example on the Lock error when you are in multi-thraeds, I have tried everything and I can not make sure not to have the error.
I'm attaching my code but I really don't see how it's possible that I still get the error.
To put it simply, in my current code I've generated a brand new engine in a folder, and as soon as I create a browser, I copy the engine and use it with setWorkingFolder
When I run just one task (say a scrapper on site A), I don't have any problems, but if I run my second scrapper on site B, after a few minutes I'll get the error.
Is there really a way to launch several scrappers with the package?
I can't hide the fact that I've been working full-time on this for 4 days now and I'm really starting to lose patience because it's putting me behind on all my projects :(
I can pay for durable solution if someone have
`
import { FetchOptions } from 'browser-with-fingerprints';
import crypto from 'crypto';
import fs from 'fs';
import { createCursor } from 'ghost-cursor-playwright';
import { homedir } from 'os';
import path from 'path';
import { BrowserContext } from 'playwright-core';
import { plugin } from 'playwright-with-fingerprints';
import { Logger } from '../../logger';
import { Proxy } from '../../proxy';
import { BrowserOptions } from '../../types/browser';
import { capsolverDefaultConfig, CapsolverOptions } from '../../types/capsolver';
import { nopechaDefaultConfig, NopechaOptions } from '../../types/nopecha';
import { sleep } from '../../utils';
import { humanClick, humaneMove, humanType } from '../humanize';
type InstanceOptions = {
browserOptions: BrowserOptions;
capsolverOptions?: CapsolverOptions;
nopechaOptions?: NopechaOptions;
proxy?: Proxy;
taskDuration?: number;
};
type PageOptions = {
useHumanization?: boolean;
blockImageDomains?: string[];
};
export class BrowserInstance {
private browser: BrowserContext | null = null;
readonly instanceOptions: InstanceOptions;
constructor(instanceOptions: InstanceOptions) {
	this.instanceOptions = instanceOptions;

	this.instanceOptions.taskDuration = this.instanceOptions.taskDuration || 10;

	if (this.instanceOptions.capsolverOptions) {
		const configPath = path.join(__dirname, '..\\..\\extensions\\capsolver\\assets\\config.json');
		const config = { ...capsolverDefaultConfig, ...this.instanceOptions.capsolverOptions };
		fs.writeFileSync(configPath, JSON.stringify(config));
	} else if (this.instanceOptions.nopechaOptions) {
		const manifestPath = path.join(__dirname, '..\\..\\extensions\\nopecha\\manifest.json');
		const config = { ...nopechaDefaultConfig, ...this.instanceOptions.nopechaOptions };
		const manifest = JSON.parse(fs.readFileSync(manifestPath, 'utf8'));
		manifest.nopecha = config;
		fs.writeFileSync(manifestPath, JSON.stringify(manifest));
	}

	// ignore unhandled playwright-with-fingerprint exceptions
	if ((global as any).ignoreUncaughtException !== true) {
		Logger.error('Uncaught exceptions are not being handled');
		(global as any).ignoreUncaughtException = true;
		(global as any).browserError = 0;
		process.on('uncaughtException', err => {
			console.error('uncaughtException:', err);
			(global as any).browserError++;
			if ((global as any).browserError > 50) {
				Logger.error('Too many browser exceptions, exiting process');
				process.exit(1);
			}
		});
	}
}

private async startBrowser() {
	// set extensions path
	const capsolverPath = path.join(__dirname, '..\\..\\extensions\\capsolver');
	const nopechaPath = path.join(__dirname, '..\\..\\extensions\\nopecha');

	// generate workdir
	if (!this.instanceOptions.browserOptions.defaultWorkerPath)
		this.instanceOptions.browserOptions.defaultWorkerPath = path.join(homedir(), 'Desktop', 'worker');

	if (!this.instanceOptions.browserOptions.workDir) {
		const enginesPath = path.join(__dirname, '..', '..', '..', '..', '..', 'engines');
		console.log(enginesPath);
		if (!fs.existsSync(enginesPath)) fs.mkdirSync(enginesPath, { recursive: true });

		const uuid = crypto.randomUUID();
		this.instanceOptions.browserOptions.workDir = path.join(enginesPath, uuid);
		fs.mkdirSync(this.instanceOptions.browserOptions.workDir);
	}

	// copy clean worker to workdir
	this.copyDirectory(
		this.instanceOptions.browserOptions.defaultWorkerPath,
		this.instanceOptions.browserOptions.workDir
	);

	plugin.setWorkingFolder(this.instanceOptions.browserOptions.workDir);

	// set tags
	const device: FetchOptions = {
		tags: this.instanceOptions.browserOptions.tags || ['Microsoft Windows', 'Chrome']
	};

	// if chrome device, get and set last version (use min/max browser version bc impossible use useBrowserVersion)
	if (device.tags && device.tags.includes('Chrome')) {
		const versions = await plugin.versions('extended');
		const browserVersion = versions[0]['browser_version'];
		const reducedBrowserVersion = parseInt(browserVersion.split('.')[0]);

		device.minBrowserVersion = reducedBrowserVersion;
		device.maxBrowserVersion = reducedBrowserVersion;
	}

	// if profile set, use it
	if (
		this.instanceOptions.browserOptions.profilePath &&
		fs.existsSync(this.instanceOptions.browserOptions.profilePath)
	) {
		plugin.useProfile(this.instanceOptions.browserOptions.profilePath, {
			loadFingerprint: true,
			loadProxy: true
		});
	}

	// fetch fingerprint
	const fingerprint = await plugin.fetch(this.instanceOptions.browserOptions.fingerprintSwitcherKey, device);
	const args = this.instanceOptions.browserOptions.args || [];
	plugin.useFingerprint(fingerprint);

	// loads captcha solvers extensions
	if (this.instanceOptions.capsolverOptions) args.push(`--load-extension=${capsolverPath}`);
	else if (this.instanceOptions.nopechaOptions) args.push(`--load-extension=${nopechaPath}`);

	// set proxy
	if (this.instanceOptions.proxy)
		plugin.useProxy(this.instanceOptions.proxy.fullAddress(), {
			detectExternalIP: true,
			changeGeolocation: true,
			changeWebRTC: true,
			changeTimezone: true,
			changeBrowserLanguage: true
		});

	// launch browser
	try {
		let isLaunch = false;
		await Promise.race([
			sleep(30000).then(() => {
				if (!isLaunch) throw '[BROWSER INSTANCE] Timeout during launch';
			}),
			new Promise((resolve, reject) => {
				plugin
					.launchPersistentContext(this.instanceOptions.browserOptions.profilePath, {
						headless: this.instanceOptions.browserOptions.headless,
						args
					})
					.then((browser: BrowserContext) => {
						isLaunch = true;
						this.browser = browser;
						resolve(browser);
					})
					.catch((error: any) => {
						reject(error);
						throw error;
					});
			})
		]);
	} catch (error) {
		(global as any).browserError++;
		if ((global as any).browserError > 50) {
			Logger.error('Too many browser exceptions, exiting process');
			process.exit(1);
		}
		throw error;
	}
}

public async init() {
	if (this.browser) throw 'Browser is already initialized';

	// blocks instance creation if one is already in progress
	let isPossibleToCreateBrowser = false;
	if (!fs.existsSync(`${process.env.TMP as string}\\lastBrowserGeneration.txt`))
		fs.writeFileSync(`${process.env.TMP as string}\\lastBrowserGeneration.txt`, '0');

	do {
		const lastBrowserGeneration = parseInt(
			fs.readFileSync(`${process.env.TMP as string}\\lastBrowserGeneration.txt`, 'utf8')
		);
		if (Date.now() - lastBrowserGeneration > 90000) {
			fs.writeFileSync(`${process.env.TMP as string}\\lastBrowserGeneration.txt`, Date.now().toString());
			isPossibleToCreateBrowser = true;
		} else await sleep(1000);
	} while (!isPossibleToCreateBrowser);

	try {
		const isBrowserCreated = await Promise.race([
			sleep(90000).then(() => false),
			this.startBrowser()
				.then(() => true)
				.catch(async error => {
					console.error(error);
					await sleep(90000);
					return false;
				})
		]);

		if (!isBrowserCreated) throw '[BROWSER INSTANCE] Timeout or error during browser creation';

		if (!this.browser) throw '[BROWSER INSTANCE] Browser failed to initialize';
	} catch (error) {
		if (this.browser) await this.close();
		throw error;
	} finally {
		await sleep(10000);
		fs.writeFileSync(`${process.env.TMP as string}\\lastBrowserGeneration.txt`, '0');
	}
}

public async newPage(options: PageOptions = {}) {
	if (!this.browser) throw '[BROWSER INSTANCE] Browser is not initialized';

	const page = await this.browser.newPage();
	if (options.useHumanization) {
		// @ts-ignore
		page.humaneMove = humaneMove;
		// @ts-ignore
		page.humanClick = humanClick;
		// @ts-ignore
		page.humanType = humanType;
		// @ts-ignore
		page.cursor = await createCursor(page);
	}

	if (options.blockImageDomains && options.blockImageDomains.length > 0) {
		await page.route('**/*', async route => {
			const request = route.request();

			if (request.resourceType() === 'image') {
				const url = request.url();
				for (const domain of options.blockImageDomains!) if (url.includes(domain)) return await route.abort();
			}

			return await route.continue();
		});
	}

	return page;
}

public async close() {
	if (!this.browser) throw '[BROWSER INSTANCE] Browser is not initialized';
	await this.browser.close();
}

public getBrowser() {
	return this.browser;
}

private copyDirectory(src: string, dest: string) {
	if (!fs.existsSync(dest)) fs.mkdirSync(dest, { recursive: true });

	const items = fs.readdirSync(src, { withFileTypes: true });

	items.forEach(item => {
		const srcPath = path.join(src, item.name);
		const destPath = path.join(dest, item.name);

		if (item.isDirectory()) this.copyDirectory(srcPath, destPath);
		else fs.copyFileSync(srcPath, destPath);
	});
}

}
`

I was able to run two browsers within the same process using most of your code, but with some caveats:
import { BrowserInstance } from './browser';

async function main() {
  const commonOptions = {
    headless: false,
    creationTimeout: 90000 * 10,
    fingerprintSwitcherKey: 'FINGERPRINT_KEY',
  };

  const instance1 = new BrowserInstance({
    browserOptions: {
      ...commonOptions,
      profilePath: './testProfile1',
    },
  });

  const instance2 = new BrowserInstance({
    browserOptions: {
      ...commonOptions,
      profilePath: './testProfile2',
    },
  });

  await Promise.allSettled([instance1.init(), instance2.init()]);
}

main();

First of all, you need to increase the timeout for launching the browser - for the entire method and for the launch itself. Where you have code whose result is saved in isBrowserCreated, you need to significantly increase it, because the engine may take much longer to download and decompress completely, otherwise errors are possible.
The same applies to the timeout in the section with the launchPersistentContext usage, where the timeout was doubled.
I have encountered a rare error that I have not seen before, related to the bas-remote-node package - I will definitely fix it in future updates, while you can patch it yourself. Right before this line, you need to add the following:

if (!fs.existsSync(this._scriptDir)) return;

With this in mind, your code worked for me without errors and launched two browsers, although I had to remove the import of some types and the use of extensions. If all this does not fix the problem, please send me the complete project with all types and data to repeat by email<EMAIL_ADDRESS>Or you can make a private repository and invite me, as it will be more convenient for you - I will look at it in my free time and try to identify the problem if it remains.

The problem is not at launch after several minutes, I would make a repo during the day that stimulates tasks to show my problem, thank for response

The problem is not at launch after several minutes, I would make a repo during the day that stimulates tasks to show my problem, thank for response

Hey bro, add me on discord snorlax1243 so we can properly discuss this

@CheshireCaat I've just thought about it, in view of the way I manage engines, wouldn't it be possible in my case to modify your code so that it doesn't lock the file?
Added @dr3adx

@Wizzzz you can try, at least for the bas-remote and for the browser-with-fingerprints. But it can lead to other issues, so in such case i can't help.

Hi, I'm back to give you an update on my last message.
Since I deactivated the lock on the package, I have no more lock problems. It's been 4 days now that I have no problems.
Here's the link to the modified package for those interested. You'll have to import it with npm using the github link, as I haven't posted it on npm.
If you want to reproduce my code, you have 2 choices, either download FastExecuteScriptProtected.x64, put it on your desktop and build a folder with your node in the same way as the package, all you have to do is 'setWorkingFolder' and the package will take care of the rest.
The second, faster option is to first extract FastExecuteScriptProtected.zip and build the folder yourself, then copy the folder for each instance you make.
You'll also need to create a powershell script that automatically deletes the folders you've created, because in less than 2 hours you're likely to run out of space on your machine (in my case, I've got 1to).
@CheshireCaat  On the other hand, I'm facing a problem I've had before, and I don't really know how to solve it. Sometimes, when I launch the browser, it never launches, and what's more, it completely blocks my node, making it impossible to continue except by shutting it down and relaunching manually. I do use 'setRequestTimeout', though, and I've even made a home-made timeout with promise.race
await Promise.race([ 				sleep(MAX_LAUNCH_TIMEOUT).then(() => { 					if (!isLaunch) throw '[BROWSER INSTANCE] Timeout during launch'; 				}), 				new Promise((resolve, reject) => { 					plugin 						.launchPersistentContext(this.instanceOptions.browserOptions.profilePath, { 							headless: this.instanceOptions.browserOptions.headless, 							args 						}) 						.then((browser: BrowserContext) => { 							isLaunch = true; 							this.browser = browser; 							resolve(browser); 						}) 						.catch((error: any) => { 							reject(error); 							throw error; 						}); 				})
If anyone has an idea for solving this problem, I'd be very happy to hear it, as it's currently my last problem with the package

@Wizzzz hi, please check your email, I replied to your message there.


[3.0.0-RC1] description about Encoding Object seems not consistent

Please refer to the following two description sections:
in the description of Special Considerations for multipart content

In scenarios where more control is needed over the Content-Type for multipart request bodies, an encoding attribute is introduced. This attribute is only applicable to multipart/* and x-www-form-urlencoded request bodies.

in the description field 'encoding' property in Media Type Object

Encoding of the media type. The encoding object SHOULD only apply to requestBody objects when the content type is multipart.

There should be no problem that "Encoding Object" applied to multipart/* content, but is it legal to be used on x-www-form-urlencoded content, too?

Believe it or not... this is why #954 is still open :(


[REQUEST] Add a DEI.md file to all Theme Builder repos, to obtain the CHAOSS Bronze DEI Badge

Suggestion/Concern
The FINOS DEI SIG is considering ways to measure the progress and impact of DEI initiatives. One step under consideration is to encourage all projects to include a DEI.md file in all FINOS repositories to obtain the CHAOSS Bronze DEI Badge
Proposed Solution
This issue can be closed when a DEI.md file exists in all related Theme Builder repositories and those repositories have the CHAOSS Bronze DEI Badge. We can highlight this in presentations and community building calls.
Tasks

[ ] Create a draft DEI.md file in dev for the A11y Theme Builder repo and include the following in each file based on these guidelines. Specific content areas needed include:

[ ] DEI Project Statement: Include a description of the scope of the DEI.md file. Explain that the file applies to a collection of repositories related to Theme Builder (including the SDK or other repositories). Include content attesting that:
[ ] A11y Theme Builder has reflected on DEI related to:

[ ] Project Access
[ ] Communication Transparency
[ ] Newcomer Experiences
[ ] Inclusive Leadership

[ ] DEI.md file closing statement:

A11y Theme Builder recognizes that the inclusion of the DEI.md file and the provided
reflection on the four DEI metrics does not ensure community safety nor community
inclusiveness. The inclusion of the DEI.md file and CHAOSS DEI review statement
signals that we are committed to continually improving our DEI by regularly reviewing
and reflecting on our project DEI practices, and on a regular and annual basis,
updating this statement and project policies in-line with the review findings.

If you do not feel that the DEI.md file appropriately addresses concerns you
have about community safety and inclusiveness, please let us, in the
[A11y Theme Builder project contacts?], know. You can do this by checking
out our Code of Conduct (link) to raise concerns you have with the
Code of Conduct team.

@PaulaPaul I am eager to collaborate, brainstorm ideas, and actively participate in achieving the shared goals

Thank you @vinfinity7 !  Would you like to create a draft DEI.md file for the project, based on the template? I'm happy to have a look and collaborate!

@PaulaPaul OK , i'll get into this


Add JetBrains extension

Description
Search and open JetBrains Toolbox projects
Type of change

[x] New extension

Screenshot

Checklist

[x] I read the contribution guidelines

Some weirdness with my fork, so closing this PR and opening a new one: #22


Adapt alias output rules in the input selection

Description
Currently if we consume an alias output, we remove the metadata feature if not also provided on the output side and also make the amount > min required storage deposit available
We have to change this, to:

keep the metadata feature if it contains a tbd issuer key
not make more amount available than needed for a tbd min required storage deposit for account outputs in 2.0, if such a metadata feature exists

Motivation
Keep prepared alias outputs compatible with account outputs
Are you planning to do it yourself in a pull request?
No.

Not needed, most users aren't expected to have such outputs and one can prevent using the output by sending it to another account or providing customInputs in the TransactionOptions


display time information

total duration, time remaining, current time something

make it more similar to a conventional video player


driver failed programming external connectivity on endpoint node-geth-1

Hello,
I am trying to run a base node on my own machine (Ubuntu 23.10). I currently have an L1 node running on the same machine with Nimbus for Beacon node and Geth for EC. I have not changed defaults so my understanding is that the OP_NODE_L1_ETH_RPC=http://localhost:8545 and OP_NODE_L1_BEACON=http://localhost:5052. Having set these env vars, I ran docker compose up which finished building and then stopped with this error:
Attaching to node-geth-1, node-node-1
Error response from daemon: driver failed programming external connectivity on endpoint node-geth-1 (cf60256aaa4abbcd3d968415b2d8e09ddf8d9c33485e2b23ebe5048768697781): Error starting userland proxy: listen tcp4 <IP_ADDRESS>:30303: bind: address already in use
I understand that :30303 is related to geth? Am I missing something in setup, or are there issues with running both nodes on the same machine, or something else?

After some more investigation, it could be an issue running the node-geth docker container and geth on the same machine. I believe this because I restarted my pc and spun up the docker containers which worked but then could not start geth on L1 due to a port being bound already. I am going to try changing some configs to see if I can get this working. Anyone else come across this? or trying to accomplish the same thing (single machine for L1 and base node)?

It seems to me that there are a lot of clashing references when running geth and op-geth on the same machine if you are just relying on the defaults. I would really appreciate what should be changed in the .env.mainnet (or .sepolia) and docker-compose.yml files to support running both nodes on the same machine. Alternatively, would it be easier to change the defaults of geth on L1 and keep the defaults of op-geth for the base node?
Thanks.

So I was able to finally get the node to begin syncing. I will detail what I did for other people wanting to run both an L1 Eth node and a Base node on the same machine.

First you have to setup your L1 clients. I used Geth and Nimbus (nimbus because it was easier on my limited resources). I didn't change any of the defaults so my Geth RPC endpoint was http://localhost:8545 and my Nimbus endpoint was http://localhost:5052. Both clients should be synced.
Because communication with the clients will originate from inside docker containers, you will need to open up the RPC and Beacon endpoints to these IPs. Now because I am in a safe environment and having nothing at risk, I just opened the endpoints to all traffic, however THIS IS NOT GOOD PRACTICE. My client startup commands are pasted below:
GETH
geth --mainnet --datadir data/ethereum/ --authrpc.addr localhost --authrpc.vhosts="localhost" --authrpc.port 8551 --authrpc.jwtsecret=/home/gavin/data/ethereum/geth/jwtsecret --cache 1024 --http --http.api="eth" --http.addr="<IP_ADDRESS>" --ws --ws.api="eth" --ws.addr="<IP_ADDRESS>"
NIMBUS
nimbus_beacon_node --el=http://localhost:8551 --jwt-secret=data/ethereum/geth/jwtsecret --data-dir=data/ethereum/nimbus --rest --rest-address="<IP_ADDRESS>"
Clone the Base node repo (link in the "Running a Base Node" doco).
In the env files for your network (mainnet or sepolia) update the OP_NODE_L1_ETH_RPC and OP_NODE_L1_BEACON endpoints to point to the endpoints of you L1 clients. Importantly, you cannot use "localhost" or <IP_ADDRESS> in your endpoints. Instead you need to identify the private IP address of your machine (if you are running your L1 clients in their own docker containers then you will need that IP?? - I'm actually not sure how that works). You can use this to find it. This is the IP address you should use instead of localhost.
In the .env file, I also updated OP_NODE_L2_ENGINE_RPC and OP_NODE_RPC_PORT to point to different ports as these clash with L1 Geth. For me, I used 9551 and 9545 respectively.
In the docker-compose.yml file, you will also need to update the ports for the geth service. Mine looks like this:

ports:
  - 9545:9545       # RPC
  - 9546:9546       # websocket
  - 30313:30313     # P2P TCP (currently unused)
  - 30313:30313/udp # P2P UDP (currently unused)
  - 7301:6060       # metrics

Don't forget to uncomment the env file in your docker-compose.yml file too (there are two instances, line 15 and 30).

Finally, I found that updating env vars didn't seem to have an effect when rebuilding container so I went ahead and updated the defaults in the geth-entrypoint file. Lines 6-8 were updated to look like this:
RPC_PORT="${RPC_PORT:-9545}"
WS_PORT="${WS_PORT:-9546}"
AUTHRPC_PORT="${AUTHRPC_PORT:-9551}"

now in the repo folder, running docker compose up --build will build and start both the geth and node containers. Syncing takes a while so I haven't been able to test this setup on a fully synced node. What you can do is, in another terminal, run geth attach http://localhost:9545 which will open a javascript console communicating with the op-geth instance. Running eth.chainId() should return the hex format of the base chain id. Running eth.blockNumber will also show you what block it is at in the syncing process.
Given how long it takes to sync, I am currently downloading the tar file as described in the docs to sync quicker. Quicker but still a not quick because the tar file is HUGE and it takes a while (15+ hrs for me) to download.


Support filtering the repositories page list

This required a bit of reworking of the adapters to use
a list instead of an array and that changed the signature
of the base class constructor which required updates to
all list adapters even those unaffected by the addition
of repository filtering.

Test Commit

This is not something you have doe yourself and it's also really old code. I'm closing this.


[Feature] Support aws sdk default behavior + assume role authentication

Support below grammar:
"aws.s3.use_aws_sdk_default_behavior"="true",
"aws.s3.iam_role_arn"="xxx"

What type of PR is this:

[ ] BugFix
[x] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Checklist:

[x] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto-backported to the target branch

[ ] 3.1
[ ] 3.0
[ ] 2.5
[ ] 2.4

[FE PR Coverage Check]
:disappointed: fail : 0 / 12 (00.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/connector/iceberg/glue/IcebergAwsClientFactory.java
0
5
00.00%
[144, 145, 192, 193, 196]

:large_blue_circle:
com/starrocks/credential/aws/AWSCloudCredential.java
0
7
00.00%
[138, 160, 161, 163, 164, 165, 169]

[FE PR Coverage Check]
:disappointed: fail : 0 / 12 (00.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/connector/iceberg/glue/IcebergAwsClientFactory.java
0
5
00.00%
[144, 145, 192, 193, 196]

:large_blue_circle:
com/starrocks/credential/aws/AWSCloudCredential.java
0
7
00.00%
[147, 148, 169, 171, 172, 174, 177]

[FE PR Coverage Check]
:disappointed: fail : 0 / 13 (00.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/connector/iceberg/glue/IcebergAwsClientFactory.java
0
4
00.00%
[144, 170, 194, 195]

:large_blue_circle:
com/starrocks/credential/aws/AWSCloudCredential.java
0
9
00.00%
[146, 147, 148, 167, 168, 170, 172, 173, 175]

[FE PR Coverage Check]
:disappointed: fail : 6 / 14 (42.86%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/connector/iceberg/glue/IcebergAwsClientFactory.java
0
5
00.00%
[144, 170, 194, 195, 196]

:large_blue_circle:
com/starrocks/credential/aws/AWSCloudCredential.java
6
9
66.67%
[146, 147, 148]

@Mergify backport branch-3.1


🧙🏻♀ Migrate to Dorothy

It would be worthly to give a dorothy a shot, there is feature to make dotfiles compatible between multiple operating systems and I belive more sane package management than one is made in chezmoi (currently I install packages by sh script)

Once started using home-manager usage of dorothy do not seem to provide any value into my system configuration.


feat: edge sidebar and other fixes

feat: sidebars work
Explain what this PR does.

are we going with these source / sink icons? @mshakira @vigith

we can replace before 0.11 release perhaps