auto functions checker, fix several cases of false warnings

prevent a few false warnings:

assert(0): function not designed to be called.
assert(false): function not designed to be called.
mixin("return" ...): try to find return in the literal.
extern(C) strlen(char*); : so obvious, same for @disable

more cases exist but they are not easily detectable.
Related to https://github.com/dlang/phobos/pull/4850#issuecomment-262364007.
@wilzbach, can you check if the cases that led you to disable the check are handled now ?

Note that it would be possible to skip visit() for a specific version() too. Stddoc seemed to be a problem but the additions made for assert() should do the job.

@wilzbach, can you check if the cases that led you to disable the check are handled now ?

Wow that managed to catch a lot of false positives - great job :)
It seems we only have the mixin problem left:
std/range/package.d(8943:28)[warn]: Auto function without return statement, prefer an explicit void
std/range/package.d(8948:81)[warn]: Auto function without return statement, prefer an explicit void
std/range/package.d(8955:28)[warn]: Auto function without return statement, prefer an explicit void
std/range/package.d(8960:81)[warn]: Auto function without return statement, prefer an explicit void
std/range/package.d(9126:14)[warn]: Auto function without return statement, prefer an explicit void
std/range/package.d(9133:14)[warn]: Auto function without return statement, prefer an explicit void
std/experimental/ndslice/iteration.d(135:15)[warn]: Auto function without return statement, prefer an explicit void
std/experimental/ndslice/iteration.d(244:15)[warn]: Auto function without return statement, prefer an explicit void

There are just eight occurrences of mixin returns in Phobos, so it might be an option to use the slightly more verbose return mixin(...) alternative there.
Btw you can check the result yourself by running make -f posix.mak style (and setting the flag to enabled of course).

Thanks, yesterday I was browsing all the files and I didn't get where the hell dscanner was called.
I'll ping again If I manage to handle these cases.

I'll ping again If I manage to handle these cases.

I don't know whether this is possible because AFAIK is Dscanner unable to expand mixins and verify that they indeed have a return statement. It would be quite fancy to use the D Frontend or the upcoming CTFE engine, but I guess these are larger projects :/

I'll ping again If I manage to handle these cases.

Btw in case you need a reduced test case, here's a simple one:
	assertAnalyzerWarnings(q{
		auto doStuff(){ mixin(_genSave());}
		private static string _genSave() @safe pure nothrow
        {
            return `import std.stdio;` ~
                   `return true`;
        }
	}, sac);

If the string is declared within the module that mixes it then it's possible to handle this case. But what will happen, like the previous changes, is not that the return is detected, it's more that a suspicious case of false detection is detected. This matches still to the policy of this check.


Uncaught Error: Cannot read property 'object' of undefinedTypeError: Cannot read property 'objec...

[Enter steps to reproduce below:]

...
...

Atom Version: 1.9.9
System: Mac OS X 10.11.6
Thrown From: Atom Core
Stack Trace
Uncaught Error: Cannot read property 'object' of undefined
TypeError: Cannot read property 'object' of undefined
at ObjectsRegistry.get (/Applications/Atom.app/Contents/Resources/electron.asar/browser/objects-registry.js:44:28)
at EventEmitter. (/Applications/Atom.app/Contents/Resources/electron.asar/browser/rpc-server.js:309:31)
at emitMany (events.js:121:13)
at EventEmitter.emit (events.js:195:7)
at EventEmitter. (/Applications/Atom.app/Contents/Resources/electron.asar/browser/api/web-contents.js:141:25)
at emitTwo (events.js:100:13)
at EventEmitter.emit (events.js:185:7)
At /Applications/Atom.app/Contents/Resources/electron.asar/renderer/api/remote.js:178

Error: Cannot read property 'object' of undefined
TypeError: Cannot read property 'object' of undefined
    at ObjectsRegistry.get (/Applications/Atom.app/Contents/Resources/electron.asar/browser/objects-registry.js:44:28)
    at EventEmitter.<anonymous> (/Applications/Atom.app/Contents/Resources/electron.asar/browser/rpc-server.js:309:31)
    at emitMany (events.js:121:13)
    at EventEmitter.emit (events.js:195:7)
    at EventEmitter.<anonymous> (/Applications/Atom.app/Contents/Resources/electron.asar/browser/api/web-contents.js:141:25)
    at emitTwo (events.js:100:13)
    at EventEmitter.emit (events.js:185:7)
  at metaToValue (/Applications/Atom.app/Contents/Resources/electron.asar/renderer/api/remote.js:178:13)
  at undefined.remoteMemberFunction (/Applications/Atom.app/Contents/Resources/electron.asar/renderer/api/remote.js:112:18)
  at AtomEnvironment.module.exports.AtomEnvironment.getWindowDimensions (/Applications/Atom.app/Contents/Resources/app.asar/src/atom-environment.js:631:29)
  at AtomEnvironment.module.exports.AtomEnvironment.storeWindowDimensions (/Applications/Atom.app/Contents/Resources/app.asar/src/atom-environment.js:665:36)
  at WindowEventHandler.module.exports.WindowEventHandler.handleWindowBlur (/Applications/Atom.app/Contents/Resources/app.asar/src/window-event-handler.js:182:35)
  at /Applications/Atom.app/Contents/Resources/app.asar/src/window-event-handler.js:3:61

Commands
     -1:19.3.0 core:copy (atom-text-editor.editor.is-focused.hyperclick)

Config
{
  "core": {
    "customFileTypes": {
      "source.ini": [
        ".buckconfig",
        ".flowconfig"
      ],
      "source.json": [
        ".arcconfig",
        "BUCK.autodeps"
      ],
      "source.python": [
        "BUCK"
      ]
    },
    "disabledPackages": [
      "tree-view"
    ],
    "themes": [
      "atom-dark-ui",
      "one-dark-syntax"
    ]
  },
  "editor": {
    "invisibles": {}
  }
}

Installed Packages
# User
.bin, vundefined (inactive)
atom-typescript, v10.1.6 (active)
editorconfig, v1.4.1 (active)
firewatch-syntax, v1.0.1 (inactive)
flow-syntax, v3.2.0 (inactive)
linter, v1.11.16 (active)
nuclide, v0.165.0 (active)
react, v0.16.0 (active)
atom-dark-syntax, v0.27.0 (inactive)
atom-dark-ui, v0.51.0 (active)
atom-light-syntax, v0.28.0 (inactive)
atom-light-ui, v0.43.0 (inactive)
base16-tomorrow-dark-theme, v1.1.0 (inactive)
base16-tomorrow-light-theme, v1.1.1 (inactive)
one-dark-ui, v1.3.2 (inactive)
one-light-ui, v1.3.2 (inactive)
one-dark-syntax, v1.2.0 (active)
one-light-syntax, v1.2.0 (inactive)
solarized-dark-syntax, v1.0.2 (inactive)
solarized-light-syntax, v1.0.2 (inactive)
about, v1.5.2 (active)
archive-view, v0.61.1 (active)
autocomplete-atom-api, v0.10.0 (active)
autocomplete-css, v0.11.1 (active)
autocomplete-html, v0.7.2 (active)
autocomplete-plus, v2.31.0 (active)
autocomplete-snippets, v1.11.0 (active)
autoflow, v0.27.0 (inactive)
autosave, v0.23.1 (active)
background-tips, v0.26.0 (active)
bookmarks, v0.41.0 (active)
bracket-matcher, v0.82.1 (active)
command-palette, v0.38.0 (inactive)
deprecation-cop, v0.54.1 (active)
dev-live-reload, v0.47.0 (active)
encoding-selector, v0.22.0 (active)
exception-reporting, v0.39.0 (active)
fuzzy-finder, v1.3.0 (active)
git-diff, v1.1.0 (active)
find-and-replace, v0.198.0 (active)
go-to-line, v0.31.0 (inactive)
grammar-selector, v0.48.1 (active)
image-view, v0.58.0 (active)
incompatible-packages, v0.26.1 (active)
keybinding-resolver, v0.35.0 (active)
line-ending-selector, v0.5.0 (active)
link, v0.31.1 (inactive)
markdown-preview, v0.158.1 (active)
metrics, v0.53.1 (active)
notifications, v0.64.1 (active)
open-on-github, v1.2.0 (inactive)
package-generator, v1.0.0 (inactive)
settings-view, v0.238.2 (active)
snippets, v1.0.2 (active)
spell-check, v0.67.1 (active)
status-bar, v1.4.1 (active)
styleguide, v0.47.1 (active)
symbols-view, v0.113.0 (inactive)
tabs, v0.98.1 (active)
timecop, v0.33.1 (active)
tree-view, v0.208.0 (inactive)
update-package-dependencies, v0.10.0 (active)
welcome, v0.34.0 (active)
whitespace, v0.32.2 (active)
wrap-guide, v0.38.1 (active)
language-c, v0.52.1 (active)
language-clojure, v0.21.0 (active)
language-coffee-script, v0.47.0 (active)
language-csharp, v0.12.1 (active)
language-css, v0.36.2 (active)
language-gfm, v0.86.0 (active)
language-git, v0.13.0 (active)
language-go, v0.42.0 (active)
language-html, v0.44.1 (active)
language-hyperlink, v0.16.0 (active)
language-java, v0.22.0 (active)
language-javascript, v0.119.0 (active)
language-json, v0.18.0 (active)
language-less, v0.29.3 (active)
language-make, v0.22.2 (active)
language-mustache, v0.13.0 (active)
language-objective-c, v0.15.1 (active)
language-perl, v0.35.0 (active)
language-php, v0.37.0 (active)
language-property-list, v0.8.0 (active)
language-python, v0.45.0 (active)
language-ruby, v0.68.5 (active)
language-ruby-on-rails, v0.25.0 (active)
language-sass, v0.52.0 (active)
language-shellscript, v0.22.3 (active)
language-source, v0.9.0 (active)
language-sql, v0.21.1 (active)
language-text, v0.7.1 (active)
language-todo, v0.28.0 (active)
language-toml, v0.18.0 (active)
language-xml, v0.34.8 (active)
language-yaml, v0.26.0 (active)

# Dev
No dev packages

What is this due? :octocat:

This is a duplicate of #11692 - feel free to subscribe there for updates.


[bugfix] Fix SingleSource when guessing of language fails

The SingleSource build system now raises an exception when
it fails to guess the programming language of the source file.

Add unittests.

Fixes #1546

Codecov Report

Merging #1619 (497b426) into master (e8f9253) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1619      +/-   ##
==========================================
+ Coverage   87.66%   87.68%   +0.01%
==========================================
  Files          44       44
  Lines        7283     7283
==========================================
+ Hits         6385     6386       +1
+ Misses        898      897       -1

Impacted Files
Coverage Δ

reframe/core/buildsystems.py
97.47% <100.00%> (+0.36%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8f9253...c579d36. Read the comment docs.

What is not so clear to me is how this was triggering the bug that we observed. Can you explain a bit?

So in our case, even though the sourcepath was non existent, the build system did not raise the exception during autodetection. Therefore, no actual compilation/build command was generated and the compilation script did nothing so it was not failing.

@jenkins-cscs retry dom


Build aar file gives an error : clang: error: no such file or directory: '/w' clang: error: no such file or directory: '/D_USE_MATH_DEFINES'

I ran this command :
bazel build -c opt --strip=ALWAYS --incompatible_restrict_string_escapes=false --host_crosstool_top=@bazel_tools//tools/cpp:toolchain --fat_apk_cpu=arm64-v8a,armeabi-v7a //mediapipe/examples/android/src/java/com/google/mediapipe/apps/aarexample:mediapipe_face_detection.aar
Error :
ERROR: C:/users/airan/_bazel_airan/q54j5q7i/external/XNNPACK/BUILD.bazel:3803:19: Compiling src/f32-dwconv2d-chw/gen/3x3p1-minmax-scalar-1x1-acc2.c failed: (Exit 1): clang failed: error executing command external/androidndk/ndk/toolchains/llvm/prebuilt/windows-x86_64/bin/clang -D__ANDROID_API__=29 -isystemexternal/androidndk/ndk/sysroot/usr/include/arm-linux-androideabi -target ... (remaining 95 argument(s) skipped)
clang: error: no such file or directory: '/w'
clang: error: no such file or directory: '/D_USE_MATH_DEFINES'
Target //mediapipe/examples/android/src/java/com/google/mediapipe/apps/aarexample:mediapipe_face_detection.aar failed to build
Use --verbose_failures to see the command lines of failed build steps.
INFO: Elapsed time: 129.535s, Critical Path: 63.41s
INFO: 294 processes: 135 internal, 150 local, 9 worker.
 :
ERROR: C:/users/airan/bazel_airan/q54j5q7i/external/ruy/ruy/BUILD:585:11: Compiling ruy/pack_arm.cc failed: (Exit 1): clang failed: error executing command external/androidndk/ndk/toolchains/llvm/prebuilt/windows-x86_64/bin/clang -D__ANDROID_API_=29 -isystemexternal/androidndk/ndk/sysroot/usr/include/arm-linux-androideabi -target ... (remaining 57 argument(s) skipped)
clang: error: no such file or directory: '/w'
clang: error: no such file or directory: '/D_USE_MATH_DEFINES'
clang: error: no such file or directory: '/std:c++17'
Target //mediapipe/examples/android/src/java/com/google/mediapipe/apps/aarexample:mediapipe_face_detection.aar failed to build
Use --verbose_failures to see the command lines of failed build steps.
INFO: Elapsed time: 15.118s, Critical Path: 12.77s
INFO: 143 processes: 129 internal, 14 local.

Hi @arianatri, We have recently released the Android FaceMesh API solutions in our repo . This are steps to work  with it. And if you still looking for AAR, have a look at this https://github.com/jiuqiant/mediapipe_face_detection_aar_example

I used this and got a bunch of errors and performance failures(mentioned these on another issue).


error TS2345: Argument of type 'PuppeteerNode' is not assignable to parameter

tsc && vite build && electron-builder --mac zip
electron/main/index.ts:10:42 - error TS2345: Argument of type 'PuppeteerNode' is not assignable to parameter of type 'typeof import("/Users/xucongyong/temp/electron-vite-project/node_modules/.store/@types+puppeteer-core@1.20.0/node_modules/@types/puppeteer-core/index")'.
Type 'PuppeteerNode' is missing the following properties from type 'typeof import("/Users/xucongyong/temp/electron-vite-project/node_modules/.store/@types+puppeteer-core@1.20.0/node_modules/@types/puppeteer-core/index")': createBrowserFetcher, errors, devices
10   const browser = await pie.connect(app, puppeteer);
~~~~~~~~~
Found 1 error in electron/main/index.ts:10

weird workaround but will work for sure:
const browser = await pie.connect(app, puppeteer as any);


Make fields, that should be immutable, immutable

We have several fields that should not be updated after creation of databases and now we have a webhook in place. So we can check for immutable fields and prevent them from being updated.
A good example can be found here: https://github.com/db-operator/db-operator/issues/25#issuecomment-1601064237
After a database is created from a template, it won't be recreated from another template unless it's removed first, so changing this field should not be possible.
So basically, the task is to find all fields that should be immutable and mark them as immutable

Closed by #32


update: add fulloverlay options to Slide component

adds option to have a full overlay on the slide component for slides that need more contrast

reference https://github.com/lonelyplanet/dotcom-video/issues/148


Swift mailer

1. Why is this change necessary?
Replace zend mail with swift mailer.
Features:
Redirect Plugin for redirect all mails to a address
NULL-Transporter: Disable mails in the backend
Global BBC Address
Additionally config for mailer_from, reply_to and return_path
mail() function is deprecated see swiftmailer/swiftmailer#866 (due to security reasons)
Sendmail is now the default transport
Sendmail is now a system requirement
2. What does this change do, exactly?
3. Describe each step to reproduce the issue or behaviour.
4. Please link to the relevant issues (if any).
5. Which documentation changes (if any) need to be made because of this PR?
6. Checklist

[ ] I have written tests and verified that they fail without my change
[x] I have squashed any insignificant commits
[x] This change has comments for package types, values, functions, and non-obvious lines of code
[x] I have read the contribution requirements and fulfil them.

Hey,
we don't want to switch to an already deprecated Mailer. If you want to create a Pull Request for Symfony Mailer, we would be very happy.


fix: only show 3 avatars in multi-user join system message

one-liner to make the system joined message only show as many avatars as are mentioned in text

this got fixed in #21443 so i'll close


Microsoft SQL Server + Native Types support

It appears to validate correctly:

But no autocomplete:

What do you mean there is not autocomplete?

OH! Craziness. I was trying to autocomplete @ms.VarChar. I didn't realize that DateTime limits the available options. Also was surprised to see DateTime2, I figured it was just picking up random stuff in the file. Cool implementation!


[Hardware][AMD] Update rocm base image and add openai server entrypoint

Update rocm base image to rocm/pytorch:rocm6.1.3_ubuntu22.04_py3.10_pytorch_release-2.1.2 and add openai server entrypoint.
We should bring some consistency to all docker images. Some doesn't have entrypoint, final target might have different names, ...

@hongxiayang @mawong-amd Are we ready to upgrade the ROCm and Ubuntu versions?

@hongxiayang @mawong-amd Are we ready to upgrade the ROCm and Ubuntu versions?

Team is working on upgrade to ROCm 6.2 ...

@hongxiayang When do you expect to land a PR? Should we merge that one in the meantime?

I am going to close this. @dgoupil Thank you for your effort.


Audio Embed Padding Issue

Hi Team,
There is a padding issue in this block. Please look into the below snap and do the needful.
https://www.aldevron.com/listen-to-shortening-the-time-from-start-to-finish
https://main--aldevron--hlxsites.hlx.page/qe-test/audio-embed

@Kummu007  - Please validate

This is working as expected, hence closing the ticket.


level filter

Hi @ondave
Is this how I should use the level filter ? https://oceanum-python.readthedocs.io/en/latest/oceanum.datamesh.html#oceanum.datamesh.query.Query.levelfilter
Getting the same dataset for both queries.
    query={ "datasource":"cmems_mod_glo_phy_my_0-083deg_p1d-m-timeseries",
            "parameters":{},
            "description":"Global ocean reanalysis daily mean fields timeseries",
            "variables":["uo"],
            "timefilter":{"type":"range","times":["2015-02-05T15:25:44+00:00","2015-02-15T08:35:00+00:00"],"resolution":"native","resample":"mean"},
            "geofilter":{"type":"bbox","geom":[-11.21287512999681,-4.787359104706401,9.256344251495753,9.723541591879712],"resolution":0.0},
            "coordfilter":[],
            "functions":[],
            "id":"c48eb64f8c0ed7de55eb2f814f3c6619"}
    ds = datamesh.query(query)

    query1 = query.copy()
    # add level filter
    query1["levelfilter"] = {"type" : 'series', "levels": [-10.],"interp" : "nearest"}
    ds1 = datamesh.query(query1)

Can't replicate this.,

Can you check:
pip install -U oceanum

Ok my bad, indeed it works with the latest upgrade, got confused between my conda environments.
Working also on the SCHISM data interpolated to fixed Z-layers.


Column chart bars fail to render randomly when columnWidth is 100%

Description
When set columnWidth to 100%, sometime bar could not be rendered.
Because SVG path data broke with exponential notation number.

Steps to Reproduce

Render column chart with options.plotOptions.bar.columnWidth = '100%'
Resize chart to good size.
Some bars could not rendered.

Expected Behavior
Render all bars.
Actual Behavior
Some bars could not be rendered.
Screenshots

Reproduction Link
https://codepen.io/tmyt/pen/QwLpWVr

fixed with this commit


How to reset the admin password?

For some reason, access to the admin panel has stopped ...
Sign in to start your session
These credentials do not match our records!!!
Login and password I did not change
During the installation I set such:
admin
password
Why does not it work now :(

Hello,
You can reset password by eloquent:
User::find(69)->update(['password' => '123456']);

You don't need to bcrypt the password before save, because system will do it automatically.


Port API Key security suggestions to the README

Right now, in the README, we suggest people not check their API key into the repo, we should do the same in this README like we do in the docs: https://ai.google.dev/tutorials/quickstart#android

Hi @logankilpatrick could you elaborate? The installation and usage section of the repo's README point to the quickstart you linked.
Is your suggestion that we include API Key security recommendations within the readme itself instead that in the pointed doc?


[sil-combine] Update fix_lifetime opts for ownership

The one opt we perform here is that we promote fix_lifetime on loadable
alloc_stack addresses to fix_lifetimes on objects by loading the underlying
value and putting the fix lifetime upon it.

@swift-ci smoke test


[openmvg] no absolute paths

For #20469

poke @autoantwort for response

@autoantwort Could you please resolve the conflicts?


Fingerprinting protection reference tests

Reviewer: @jonathanKingston
Description:
This is an integration of https://github.com/duckduckgo/privacy-reference-tests/tree/main/fingerprinting-protections reference tests.
Steps to test this PR:

If you are happy with how the code looks, and automatic tests pass, then we are good!

Automated tests:

[ ] Unit tests
[ ] Integration tests

Reviewer Checklist:

[ ] Ensure the PR solves the problem
[ ] Review every line of code
[ ] Ensure the PR does no harm by testing the changes thoroughly
[ ] Get help if you're uncomfortable with any of the above!
[ ] Determine if there are any quick wins that improve the implementation

PR Author Checklist:

[ ] Get advice or leverage existing code
[ ] Agree on technical approach with reviewer (if the changes are nuanced)
[ ] Ensure that there is a testing strategy (and documented non-automated tests)
[ ] Ensure there is a documented monitoring strategy (if necessary)
[ ] Consider systems implications

Hey @kdzwinel sorry I missed this, I think this is fine. Remove the shared directory now as we're not using it and we should be good to go.


Remove the project GOPATH directory layout assumption

Remove the project GOPATH directory layout assumption
No longer try to work from ../../../../src dir :)

This addresses #22 and #27.


Handle fallback to ASCII borders when running in legacy console (cmd.exe)

We know whether or not we're running in a legacy console (cmd.exe) which doesn't support true type fonts. If we are, we should automatically downgrade borders that use true type fonts to something that can be properly rendered.
var isLegacyConsole = console.Capabilities.LegacyConsole;

Fixed in 0.7.1-preview.0.1


Update examples

It looks as though the examples haven't been updated in a while. Right now all of the files look about the same

This is the only example which matters: https://github.com/stevelacy/gulp-stylus/blob/master/examples/gulpfile.js
I can delete the stylus files as this project is a plugin, not the main stylus repo.

Would be nice to have example of passing arguments.

All arguments have examples:
https://github.com/stevelacy/gulp-stylus/blob/master/README.md

I guess i was looking for this (passing locals to Accord and to be used in stylus files:
in gulpfule.js:
pipe(stylus({define:{'fontFace' : 'FranklinGothic'}}))

and then in index.styl:
  if fontFace == Roboto
    font-family: Roboto, sans-serif
  else if fontFace == FranklinGothic
    font-family: FranklinGothicURWCon-Dem, sans-serif

The pieces are there but having it visible can save a few hours of trial and error


Question: what was the scope of the Uniref database used for curatedMetagenomicData?

Noting that there are several flavors of Uniref available via humann2 download, which version is used for curatedMetagenomicData?
https://bitbucket.org/biobakery/humann2/wiki/Home#markdown-header-5-download-the-databases

We use the "full UniRef90 database (11.0GB, recommended)" that can be downloaded via humann2 download

Thanks for confirming, @edoardopasolli.


Code repetition while encoding nested messages

I'd like to introduce alternate constructors to reduce number of lines required to create and encode a message.
Example .proto
message ParentMessage {
  oneof msg {
    ChildMessage ChildMessage = 1
  }
}

message ChildMessage {
  oneof msg {
    GrandChildMessage GrandChildMessage = 1
  }
}

message GrandChildMessage = {}

How I currently have to structure my code:
{}
        |> grandChildMessage
        |> (\msg_ -> { msg = Just msg_ })
        |> childMessage
        |> (\msg_ -> { msg = Just msg_ })
        |> encodeParentMessage

How I would like to structure my code:
{}
  |> justGrandChildMessage
  |> justChildMessage
  |> encodeParentMessage

@anmolitor What do you think?

Hmm. I don't know if piping is the most maintainable and readable pattern here (although I generally like code written in pipeline style).
What happens if you add any more fields to one of the messages?
You probably have to restructure your code.
I suggest this instead:
let
  grandChildMessage = {}
  childMessage = { msg = Just <| GrandChildMessage grandChildMessage }
  parentMessage = { msg = Just <| ChildMessage childMessage }
in encodeParentMessage parentMessage

(right now this is not possible in the most recent version due to fromInternal/toInternal functions but it will be in 4.0.0.
I released a beta yesterday)


Expected 4 type arguments, but got 1.

I am getting this error can anyone help ?

This is the type definition of IStoreState
export interface IStoreState {
    languageName: string;
    enthusiasmLevel: number;
}

Is it duplicate to https://github.com/Microsoft/TypeScript-React-Starter/issues/136?

Not sure if this is the solution to it, but this worked for me
I imported EnthusiasmAction
import { EnthusiasmAction } from './actions/index';
and used like below
const store = createStore<IStoreState, EnthusiasmAction, any, any>(enthusiam, {
enthusiasmLevel: 1,
languageName: 'TypeScript'
});

If don't know what the type is, try to describe it as 'any'
const store = createStore<StoreState,any,any,any>(enthusiasm, {
enthusiasmLevel: 1,
languageName: 'TypeScript',
});

Didn't work, why it's closed and readme not updated

The solution presented by @haani104 is good, but for me was incomplete, i had to make tihis change in my /reducers/index.tsx:
import { Reducer } from "redux";

export const enthusiasm: Reducer = (
  state: StoreState,
  action: EnthusiasmAction
): StoreState => {
  switch (action.type) {
    case INCREMENT_ENTHUSIASM:
      return { ...state, enthusiasmLevel: state.enthusiasmLevel + 1 };
    case DECREMENT_ENTHUSIASM:
      return { ...state, enthusiasmLevel: state.enthusiasmLevel - 1 };
  }
  return state;
};

Basically, createStore expects a function of type Reducer as one of it arguments, and in the tutorial, we are declaring it as a plain function.


Temporary Credentials Not Working: can't get account aws id

Environment:
Jenkins ver 2.1
AWS CodeDeploy Plugin ver 1.11
May 03, 2016 3:22:20 PM hudson.ExpressionFactory2$JexlExpression evaluate
WARNING: Caught exception evaluating: descriptor.accountId in /$stapler/bound/d85fcff4-ade2-47d7-bddf-854bf0a8fea3/render. Reason: java.lang.reflect.InvocationTargetException
java.lang.reflect.InvocationTargetException
...
Caused by: com.amazonaws.AmazonClientException: Unable to load AWS credentials from any provider in the chain
at com.amazonaws.auth.AWSCredentialsProviderChain.getCredentials(AWSCredentialsProviderChain.java:131)
at com.amazonaws.services.identitymanagement.AmazonIdentityManagementClient.invoke(AmazonIdentityManagementClient.java:7398)
at com.amazonaws.services.identitymanagement.AmazonIdentityManagementClient.getUser(AmazonIdentityManagementClient.java:4219)
at com.amazonaws.services.identitymanagement.AmazonIdentityManagementClient.getUser(AmazonIdentityManagementClient.java:4231)
at com.amazonaws.codedeploy.AWSClients.getAccountId(AWSClients.java:104)
at com.amazonaws.codedeploy.AWSCodeDeployPublisher$DescriptorImpl.getAccountId(AWSCodeDeployPublisher.java:528)
i've tried adding the aws key\secret pair at all possible places - jenkins credentials, plugin configuration (under 'manage'), env-injected to specific job - all failed.
using the same pair at "Use Access/Secret keys" option works as expected.
Am i missing something?

Hi there,
Did you launch your instance with the right role? If yes, do you mind pasting your role here so that we can take a look at it?
The error you are getting: "Unable to load AWS credentials from any provider in the chain" seems to suggest that there is no role associated with the instance.

Cleaning up old issues - Closing this as there hasn't been a response. Please feel free to re-open if you are still having the problem.


Add CollectGarbage to the global object only in chakracore builds and only if requested

Fixes https://github.com/nodejs/node-chakracore/issues/499
IsCollectGarbageEnabled relies on "CollectGarbage" flag which can be set through jscript.config or passed to ch.exe.

Looks like we have a test that references CollectGarbage:
[202/1629 0.02] Failed -> ControlFlow/forInMisc.js
15:46:54 /mnt/j/workspace/Microsoft_ChakraCore/master/_no_jit_shared_ubuntu_linux_test_prtest/out/Test/ch -WERExceptionSupport -ExtendedErrorStackForTestHost -BaselineMode -nonative /mnt/j/workspace/Microsoft_ChakraCore/master/_no_jit_shared_ubuntu_linux_test_prtest/test/ControlFlow/forInMisc.js
15:46:54 Output: (at line 8)
15:46:54 ----------------------------
15:46:54 ReferenceError: 'CollectGarbage' is not defined
15:46:54 ----------------------------
15:46:54 Expected Output:
15:46:54 ----------------------------
15:46:54 randomprop0
15:46:54 ----------------------------
15:46:54 exit code: 0

Quite a few tests were failing. I've fixed corresponding rlexe.xml files as it seems the scripts' intent is to run GC.

In reply to: 377396075 [](ancestors = 377396075)

Were those tests actually triggering a GC previously? I thought that without explicit config flags, the CollectGarbage function existed but was a no-op?

Depends on the time when the test was written. If they were written prior to CL#1591331 (Sep 2016), like forInMisc.js, then they originally used to trigger GC. Then in 2016 the change made GS noop, which apparently didn't break the tests so it went unnoticed. I could also fix it the other way by removing the call to CollectGarbage from the tests but I don't know why the test authors felt compelled to run GC explicitly...

In reply to: 377437597 [](ancestors = 377437597)


The DSL helper function section is outdated

filename:helper-functions.md
content:
There is an error in the description of the rand_base function。
Need to change one rand_char --> rand_base,Now there are two functions with the same name。

Hello @Teaing,
Thank you for pointing it out. I've updated the DSL functions section in the associated PR.


add android related properties to decide requests

that was fast! is it possible to wrap all the extra properties as a JSON object? That would make the implementation on par with what the iOS SDK is doing.
i.e.
&properties={"$android_lib_version": "X.Y.Z", ...}
instead of
&$android_lib_version=X.Y.Z&...

Let me know what you think!


not run

Description
Describe your issue here.
What type of issue is this? (place an x in one of the [ ])

[ ] bug
[ ] enhancement (feature request)
[ ] question
[ ] documentation related
[x] example code related
[ ] testing related
[ ] discussion

Requirements (place an x in each of the [ ])

[ ] I've read and understood the Contributing guidelines and have done my best effort to follow them.
[ ] I've read and agree to the Code of Conduct.
[ ] I've searched for any related issues and avoided creating a duplicate issue.

Bug Report
Filling out the following details about bugs will help us solve your issue sooner.
Reproducible in:
package version:
node version:
OS version(s):
Steps to reproduce:

Expected result:
What you expected to happen
Actual result:
What actually happened
Attachments:
Logs, screenshots, screencast, sample project, funny gif, etc.

Hi @Snekha2001 - Did you intend to create this issue? If so can you please fill out details on the issue you're encountering and indicate that you've completed the requirements for submitting an issue?

Hi @Snekha2001 ! Closing this issue for now, as there isn't enough detail to investigate. Feel free to open this again if needed, just be sure to fill out details and acknowledge the requirements 🙇


Disabling Scan Mode in ESP32S3 Touch Interface  (IDFGH-9093)

Answers checklist.

[X] I have read the documentation ESP-IDF Programming Guide and the issue is not addressed there.
[X] I have updated my IDF branch (master or release) to the latest version and checked that the issue is present there.
[X] I have searched the issue tracker for a similar issue and not found a similar issue.

General issue report
Hi I am using the ESP32s3 touch peripheral to read Four different pads. in the TRM it is mentioned that "scan mode can be enabled by specifying the bit map of enabled touch pins in RTC_CNTL_TOUCH_SCAN_PAD_MAP in  RTC_CNTL_TOUCH_SCAN_CTRL_REG"
My question is how can I get multiple touch pads to sample simultaneously, I couldn't find an API function in the esp-idf v5.0 to do this, I also didn't find any useful information regarding it in the ESP32s3 TRM.   The reason I want to do that is to reduce the overall sensor delay.
I tried for two pads:
-setting the corresponding   RTC_CNTL_TOUCH_SCAN_PAD_MAP bits  to 0 ==>no pin start the measurement.
-setting the corresponding   RTC_CNTL_TOUCH_SCAN_PAD_MAP bits  to 1  ==>Both pins start the measurements but in scan mode.
--setting one pad  bit to 1  and  the other to 0 in   RTC_CNTL_TOUCH_SCAN_PAD_MAP will start the channels simultaneously but the the magnitude of the other channel is lower by 10 and it gives a false reading.

@L-KAYA any answer regarding this ?

Sorry for the late reply!
Unfortunately, the touch sensor in hardware only supports scanning the pads one by one. The register RTC_CNTL_TOUCH_SCAN_PAD_MAP  is to enable the pads which is supposed to be scanned, if the corresponding bit is not set, the touch sensor scanner will skip this pad, it's kinda enable logic.

@L-KAYA Thank you for the replay


Link to Code style guidelines in the pull request template

This is a common pain point for new contributors, as setting up pre-commit hooks will save a lot of time spent on CI.

Thanks!


Errors using the Actor Sample

Expected Behavior
For it to just work
Actual Behavior

First it complained of not being able to connect to the service. I started it up with this command(started fine)
dapr run --app-id myapp --app-port 5000 --dapr-http-port 5030 dotnet run

After debugging, I discovered that the Client defaulted to port 3500 and had no clue about port 5030, and was looking at an environment variable.
Side Note: Is there a better way to inform the client about which port to listen on?

So I set the environment variable in the Client as shown
Environment.SetEnvironmentVariable("DAPR_HTTP_PORT", "5030");

Now I get the error: "error finding address for actor type DemoActor with id abc", however,
a. It's registered as: actorRuntime.RegisterActor();, no id of course
b. It's created as: var actorId = new ActorId("abc");
c. With proxy code: var proxy = ActorProxy.Create(actorId, "DemoActor");

This is basically the demo code run with the only change being setting the environment variable

Note: I'm running the slim environment without Docker
Steps to Reproduce the Problem
See above

@samcov Placement service is required to run actors, Slim environment doesn't setup placement service or a state store. If you are just getting started with Dapr, I would suggest to use dapr init without slim option, so that your environment gets setup correctly.
I am closing this, please feel free to reopen if you need more info.

If that's the case, then what is possible with the slim environment?
Which samples work and which don't, maybe I missed this in the readme.

Please see following docs about slim and setting env without docker:
https://github.com/dapr/docs/tree/master/howto/self-hosted-no-docker#self-hosted-mode-without-containers

Thanks.


Not enough margin between logos and selection box on certain cases.

Certain case is when you have all three Virtualmin, Cloudmin and Webmin installed and replaced their names by custom strings. The logo section then overlaps the selection (or search) box, because of the following css style:
.select2 {     margin-top: 4px;     margin-bottom: 4px; }
Changing it to:
.select2 {     margin-top: 15px;     margin-bottom: 4px; }
helps in our case. Could you please consider when you have longer replacements names for Virtualmin, Cloudmin and Webmin like shown on the attachment.

Yes, I'll try. Thanks.

Isn't better to decrease line-height?

Well, actually, this is why we have an ability to inject .CSS code. Why not just:
#sidebar ul.navigation {
	margin-top: 15px;
}

I know about using CSS, but then custom modifications will get overriden by future releases, so that's why this kind of inconsistencies are good to be addressed on developer level.

No, this is why they are there. It's not overridden!
Got to Webmin->Webmin Configurations->Themes->Current Theme. At the very bottom fine Theme Extensions. Add that piece of code and hit save.
It's work for as long as you don't remove it manually.

Fair enough. Thanks!


Notes for agenda March 22 2023

Notes for meeting on March 22, 2023

Had some weird history issue so redid this PR on #222


Request with OData $select query option fails

When sending a request with the $select OData query option, the request will fail with HTTP status code 500 and error message "An internal server error has occurred".
Example request:
https://fef.msua06.manage.microsoft.com/ReportingService/DataWarehouseFEService/dates?$select=dateKey&api-version=beta
Example response:
{
"Message":"An internal server error has occurred - Operation ID (for customer support): 00000000-0000-0000-0000-000000000000 - Activity ID: 00000000-0000-0000-0000-000000000000 - Url: https://fef.msua06.manage.microsoft.com/ReportingService/DataWarehouseFEService/%24select%3DdateKey?api-version=beta - CustomApiErrorPhrase: "
}

Thanks Nick, we do not currently support $select (see https://docs.microsoft.com/en-us/intune/reports-api-url) but unfortunately it is returning a misleading HTTP 500 instead of 400. We are currently working on adding support for $select.

The work to support $select has been completed. Closing this issue.


What does "for the current environment" mean

This method creates a cookie with properties that have no setters.
The comment about CreateNew says it creates a cookie "for the current environment". The meaning of this is non-obvious.
The Append method's comment states: "To create a cookie, you can use the Microsoft.Azure.Functions.Worker.Http.HttpCookies.CreateNew method." This appears to be false because creating a cookie using this method doesn't appear to allow me to set the cookie's value or other attributes due to the lack of setters on the resulting IHttpCookie object.
What gives?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 81095906-a34f-1cef-f357-d86000f9ac0e
Version Independent ID: 640580c2-e54e-0e75-ff39-3233a8a7b2af
Content: HttpCookies.CreateNew Method (Microsoft.Azure.Functions.Worker.Http) - Azure for .NET Developers
Content Source: xml/Microsoft.Azure.Functions.Worker.Http/HttpCookies.xml
GitHub Login: @rloutlaw
Microsoft Alias: routlaw

Label prediction was below confidence level 0.6 for Model:ServiceLabels: 'Functions:0.15431267,Managed Identity:0.06788853,Docs:0.04231583'

This issue has been transferred to the repository where the Microsoft.Azure.Functions.Worker package is maintained as #775.


Upgrade AFJ and fix some bugs

Signed-off-by: Mostafa<EMAIL_ADDRESS>Summary of Changes
. Update AFJ to version 0.1.0-alpha.258
. Changed some APIs that corresponds to the new AFJ version
. Fixed nested scroll crash on Home Screen
. Disabled "Implicit" mediator pickup for default implementation (Developer had to have WS server handy to use that)
Related Issues
N/A
Pull Request Checklist
This is just a reminder about the most common mistakes. Please make sure that you tick all appropriate boxes. But please read our contribution guide at least once; it will save you a few review cycles!
If an item doesn't apply to your pull request, check it anyway to make it apparent that there's nothing to do.

[*] All commits contain a DCO Signed-off-by line (we use the DCO GitHub app to enforce this).
[*] Updated LICENSE-3RD-PARTY.md for any added dependencies or vendored components.
[*] Run prettier: npm run style-format
[*] Updated documentation for changed code and new or modified features.

If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!
PR template adapted from the Python attrs project.

duplicated, advise to merge previous PR from other contributors first


Update demo to use riff

add README

rebased and merged as https://github.com/markfisher/s1p2017-faas-demo/commit/0e33f98751612a27c72ad136bd76f68dd67106a3


STYLE: Use C++14 <type_traits> template aliases instead of nested types

Replaced uses of nested types from <type_traits> (from C++11) by the
corresponding C++14 template aliases. Removed the corresponding typename
keywords that were originally necessary. Did so by running the following
command, at the GNU bash prompt, from the root of the ITK source tree:
find . \( -iname itk*.cxx -or -iname itk*.hxx -or -iname itk*.h \) -exec perl -pi -w -e 's/typename std::(\w+)<(.+)>::type/std::$1_t<$2>/g;' {} \;

Original proposal of these C++14 template aliases:
Walter E. Brown, 2013-03-12, TransformationTraits Redux, http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2013/n3546.pdf
Walter E. Brown, 2013-04-18, TransformationTraits Redux, v2, http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2013/n3655.pdf
Related issue:
Loïc Joly, 15 October 2020, The "_t" and "_v" version of type traits should be used instead of "::type" and "::value", https://jira.sonarsource.com/browse/RSPEC-6020


Ruby LSP: indexing files: 0% completed hangs forever

Description
Hi. On my project, I see "Ruby LSP: indexing files: 0% completed" notification and progress spinner — they stay forever
Configuration:
VScode  1.91.0
Ruby LSP plugin v0.7.11
ruby-lsp in the project's bundle 0.17.6

Hi @argent-smith, can you try running ruby-lsp-doctor in your repo, and see if hangs.

can you try running ruby-lsp-doctor in your repo, and see if it hangs

Hi @andyw8, ruby-lsp-doctor doesn't hang

And also check for any errors in the Ruby LSP output panel.

It looks like this:

@andyw8 also, this works fine:
⟩ bundle exec ruby-lsp --time-index
Ruby LSP v0.17.6: Indexing took 9.86661 seconds and generated:
- Module: 14269
- Class: 9314
- Method: 72038
- InstanceVariable: 23228
- Accessor: 9433
- UnresolvedMethodAlias: 3000
- Constant: 7616
- SingletonClass: 3208
- UnresolvedAlias: 434

Thanks, please also check here for errors (choose Output, then select Ruby LSP):

Note: The ruby-lsp-doctor command is now ruby-lsp --doctor (https://github.com/Shopify/ruby-lsp/pull/2310)

I was having the same

Ruby 3.3.4
ruby-lsp 0.17.15

I run ruby-lsp --doctor and get no errors, and my editor nvim just hangs saying that it's at 0%.
Our issue: we needed to upgrade standard.

Note: I attempted to upload screenshots, but for some reason it's not working at the moment.

I'm getting a similar issue. Ruby LSP fail to start because it can load a gem required by a rubocop config in a parent folder which shouldn't even be in use since to project has its own. Either way, the gem is installed for the ruby version in use.
They are not installed in the current bundle though.
2024-10-23 11:03:21.224 [info] (rubocop-eightyfourcodes) Finished initializing Ruby LSP!
2024-10-23 11:03:21.473 [info] (rubocop-eightyfourcodes) Error processing initialized: /home/anders/.rbenv/versions/3.3.5/lib/ruby/gems/3.3.0/gems/rubocop-1.67.0/lib/rubocop/feature_loader.rb:46:in `rescue in rescue in load': cannot load such file -- rubocop-gitlab-security (LoadError)
...
	from /home/anders/.rbenv/versions/3.3.5/lib/ruby/gems/3.3.0/gems/ruby-lsp-0.20.1/lib/ruby_lsp/requests/support/rubocop_runner.rb:86:in `initialize'

I had a similar issue running  ruby-lsp  with  neovim . It always hang in "indexing files: 0%".
The harder part was that --doctor, logs, and debug didn't show any error; it only hung when the lsp was started within Neovim (installed via Mason).
In the end, the problem was that  .rubocop.yml file referenced rubocop-rails-omakase  in inherited_gem section, but we changed rubocop-rails-omakase for standardrb in the project Gemfile.
Removing that line solved the issue, or even removing the .rubocop.yml file solves the issue.

@mrbongiolo that's interesting, did you notice if you had anything printed to the output tab? I can understand the linting/formatting not working under those conditions, but if indexing broke too there's a chance that we're not handling errors gracefully somewhere.
Is having a .rubocop.yml file with the omakase thing, but using Standard enough to reproduce?


Export Certificate

This section in the article only describes how to export the app service certificate to pfx using CLI. This feature is also available via the portal. When we only include CLI or PowerShell as the way to accomplish a task we are giving the impression that the portal does not support this feature.
My ask is to add the steps for exporting a certificate to pfx via the portal.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: cc2ee874-df45-1de2-1b30-1fd75c7fd709
Version Independent ID: ee181722-8386-9842-407f-d0549012d2e9
Content: Add and manage TLS/SSL certificates - Azure App Service
Content Source: articles/app-service/configure-ssl-certificate.md
Service: app-service
GitHub Login: @cephalin
Microsoft Alias: cephalin

@amymcel Hello Amy, good to hear from you.
I have assigned the issue to the content author to investigate further and update the document as appropriate.

#reassign: msangapu-msft


Carousel Issue on Outlook iPhone SE app

#Howdy,
Issue: All three arrows appear on the Outlook Mobile client. This was using the code found here: https://mjml.io/try-it-live/components/carousel
Client: Outlook 2.9.1 on an iPhone SE

Any updates re: this issue or when we can expect a resolution?

@tyoung23 not something we're actively working on at the moment, so we don't have any ETA we can give.

I'm closing for now feel free to reopen if it's still the case Outlook client has been updated for a while now

While i know this issues was reported for Outlook i'm seeing it consistently on Apple Mail iOS14 and MacOS as well as Gmail.

How did you sent your email ? Just tested on iOS 14 and it works just fine.
Try with https://putsmail.com/

Okay, it was likely something on my end. We ended up not needing the carousel so I no longer have a test case to provide. I'll circle back if i run into this issue again.


Create a new page "Volunteer with us"

As a user I would like to share my details so that I can volunteer with FightPandemics.
Please create a new webpage with the below details:
Link: fightpandemics.com/volunteer-with-us
Use the below script for embedding the lists:

Make sure that this link is attached with the Join us as a volunteer / Join us as an ambassdor buttons on About us page
Link to help you accomplish the task: https://help.workable.com/hc/en-us/articles/115012801727-How-to-embed-jobs-on-your-website#:~:text=You can easily create a,your custom styling and formatting

Hi @ppagarawal I don't think this issue is MVP-Critical "Soft Launch" is it possible this can be launched with MVP- Release 1 instead?

is there a design template for the page, and I think, if it isn't stopping any of the major functionality, then I don't think it should be critical to the Soft Launch

@jyclam Hello there! Do you happen to still be working on this? Let me know :)

has anybody working o this issue? else I would love to work on this. Let me know

I don't think we still need this, but I am not sure.
@CamilaArias please confirm.

@Zaydme the new about us page has the Get Involved section that takes you to the workable site with the positions, I think that's good enough.


Receiving and returning audio & video files using FileResponse

First Check

[X] I added a very descriptive title to this issue.
[X] I used the GitHub search to find a similar issue and didn't find it.
[X] I searched the FastAPI documentation, with the integrated search.
[X] I already searched in Google "How to X in FastAPI" and didn't find any information.
[X] I already read and followed all the tutorial in the docs and didn't find an answer.
[X] I already checked if it is not related to FastAPI but to Pydantic.
[X] I already checked if it is not related to FastAPI but to Swagger UI.
[X] I already checked if it is not related to FastAPI but to ReDoc.

Commit to Help

[x] I commit to help with one of those options 👆

Example Code
tmp_file_dir = "/tmp/example-files"
Path(tmp_file_dir).mkdir(parents=True, exist_ok=True)

@media_router.post(
    path="/api/media-file",
    response_class=FileResponse,
)
async def post_media_file(file: UploadFile):
    """
    Receive File, store to disk & return it
    """
    # Write file to disk. This simulates some business logic that results in a file sotred on disk
    with open(os.path.join(tmp_file_dir, file.filename), 'wb') as disk_file:
        file_bytes = await file.read()

        disk_file.write(file_bytes)

        print(f"Received file named {file.filename} containing {len(file_bytes)} bytes. ")

        return FileResponse(disk_file.name, media_type=file.content_type)

Description
The example code I added accepts any file a user uploads, stores it to disk and returns it using a FileResponse.
This approach works nicely for images, however when uploading audio or video, the result cannot be displayed in the /docs properly and I assume the same would be the case for any consumer of the API.
I assume this is merely a matter of adding some metadata either to the file or the FileResponse but I was unable to find out what or how to add them.
Operating System
Linux
Operating System Details
No response
FastAPI Version
0.78.0
Python Version
3.10.4
Additional Context
No response

What you have done is correct... not sure if SwaggerUI supports audio playback.

@iudeen Thanks for the quick reply.
OpenAPI/Swagger does seem to support audio. At least it shows an audio player, but the controls are all disabled, indicating to me that it probably can't open the received data.
I also tested the API using PostMan: Both audio and video were playing but none of them had any sound.
When I downloaded the response from postman and played it using VLC media player, they worked fine. I'm assuming it has to do with encoding..

This code works. Swagger doc does a GET request. So you need to have your route as GET method.
from fastapi import FastAPI
from fastapi.responses import FileResponse

app = FastAPI()

@app.get(
    path="/api/media-file"
)
async def post_media_file():
    return FileResponse("audio.mp3", media_type="audio/mpeg")

works fine with curl:
curl --output test.mp3 -F<EMAIL_ADDRESS>http://localhost:8000/api/media-file
this returns a valid mp3 file with audio
the problem here is the swagger ui, when you upload a file through swagger the player tries to make a GET request to the same path. probably the html player doesnt support files from a post request.
You see that in the fastapi log:
INFO:     <IP_ADDRESS>:34792 - "POST /api/media-file HTTP/1.1" 200 OK INFO:     <IP_ADDRESS>:34792 - "GET /api/media-file HTTP/1.1" 405 Method Not Allowed

Thank you very much for the explanation. Since this seems to be an issue with OpenAPI/Swagger I don't suppose there's anything that can be done on the FastAPI side, I'll close the issue.

If you really need to listen to the audio file in the swagger ui you couldt try a html response where you return an audio element wirh the base64 encoded audio file as src. But im not sure if it will be rendered


error 404 & 504 after "error closing Chrome tab Error: not opened"

meteorjs 1.6.1
prerender-node 3.1.1
prerender 5.3.1
Chrome: HeadlessChrome/65.0.3325.181
ubuntu 16
not sure what happen, upgraded prerender-node from 2.7.5 to 3.1.1 and upgrade prerender not sure which version
i running 2 prerender at the same time, one at port 2000, another one at port 2001, not sure this cause the issue or not
2018-03-23T15:10:56.270Z error closing Chrome tab Error: not opened
at WebSocket.send (/www/lib/prerender/node_modules/ws/lib/WebSocket.js:355:18)
at Chrome.enqueueCommand (/www/lib/prerender/node_modules/chrome-remote-interface/lib/chrome.js:124:16)
at /www/lib/prerender/node_modules/chrome-remote-interface/lib/chrome.js:86:28
at new Promise ()
at Chrome.send (/www/lib/prerender/node_modules/chrome-remote-interface/lib/chrome.js:85:16)
at Object.handler [as closeTarget] (/www/lib/prerender/node_modules/chrome-remote-interface/lib/api.js:32:23)
at Promise (/www/lib/prerender/lib/browsers/chrome.js:146:22)
at new Promise ()
at Object.chrome.closeTab (/www/lib/prerender/lib/browsers/chrome.js:144:9)
at Object.server.finish (/www/lib/prerender/lib/server.js:274:16)
2018-03-23T15:10:56.668Z getting https://www.keepital.com/company/sg/miryoku-bistro-pte-ltd
2018-03-23T15:10:56.672Z Error: unexpected server response (404)
at ClientRequest._req.on (/www/lib/prerender/node_modules/ws/lib/WebSocket.js:651:26)
at emitOne (events.js:116:13)
at ClientRequest.emit (events.js:211:7)
at HTTPParser.parserOnIncomingClient (_http_client.js:551:21)
at HTTPParser.parserOnHeadersComplete (_http_common.js:116:23)
at Socket.socketOnData (_http_client.js:440:20)
at emitOne (events.js:116:13)
at Socket.emit (events.js:211:7)
at addChunk (_stream_readable.js:263:12)
at readableAddChunk (_stream_readable.js:250:11)
2018-03-23T15:10:56.673Z got 504 in 5ms for https://www.keepital.com/company/sg/miryoku-bistro-pte-ltd
.... and so on for few minutes, after that back to normal
2018-03-23T15:24:11.886Z Restarting Chrome
2018-03-23T15:24:11.887Z got 504 in 6ms for https://www.keepital.com/company/sg/oww-ii-limited
2018-03-23T15:24:11.897Z Chrome connection closed... restarting Chrome
2018-03-23T15:24:11.897Z Starting Chrome
2018-03-23T15:24:12.406Z Started Chrome: HeadlessChrome/65.0.3325.181
2018-03-23T15:24:21.596Z getting https://www.keepital.com/company/sg/aviation-equipment-leasing-pte-ltd/

I don't think running two instances of the Prerender server is a good idea since it's going to try to start two versions of Chrome on the same port for the websocket connection. I'd try to stick with 1 Prerender server running per machine.

Going to close this issue since it looks like the 2 instances of Chrome would cause this. You should only run 1 instance of the Prerender server and Chrome will start the tabs in different processes to scale with multi-cpu environments.

we use 1 instance for our core website with millions of pages and another instance for the rest of the websites (about 150 websites)
i remember when i implemented prerender in my server (quite sometime ago with PhantomJS), there is a limitation for each instance (something related to number of workers & iterations). that's the reason why we setup 2 instance to balance out the requests & render (1 for major website & another 1 for the rest of the website).
if i do it wrongly, can you please advise what's the best way to maximise the prerender to accept and render as many request as possible, and also we can balance out 50% request for major website and 50% for the rest of the websites.
thanks in advance

If you need them to be two separate Prerender servers, I'd suggest running them on different machines. If that's not necessary, try running one server and see if it can handle the load for both websites.


Custom command semantics

PRQ #99 adds a new mid-level semantics for commands.  This issue proposes opening up this mid-level semantics as a mini-language for adding custom commands.
Why?  Because this will allow us to express symbolic commands easier, mainly.  It also boosts our expressiveness story by allowing the user to 'choose' their atomic command set (while, at the Views level, the atomic commands are always fixed).
One possible syntax, shown in #104, is
atomic name(params) { microcode }

where
<params>         ::= <param> <params-rest>
<params-rest>    ::= <empty> | , <params>
<param>          ::= <class> <type> <lvalue-spec>
<class>          ::= shared | thread
<type>           ::= <prim-type> <array-spec>
<prim-type>      ::= int | bool
<array-spec>     ::= <empty> | [ <number> ] <array-spec>
<lvalue-spec>    ::= <identifier> | & <identifier>

<microcode>      ::= <microcode-step> <microcode-rest>
<microcode-rest> ::= <empty> | , <microcode>
<microcode-step> ::= <assign> | <forget> | <assume> | <conditional>
<assign>         ::= <lvalue> <- <expr>
<forget>         ::= forget <lvalue>
<assume>         ::= assume <expr>
<conditional>    ::= if (<expr>) { <microcode> } else { <microcode> }

where lvalue and expr are exercises left to the reader.
The idea is that if a parameter has a & before its name, it's restricted to being an lvalue, and appears in the write-to of the custom command.  Each possible path through the command must assign or forget the parameter.  The delimiter between microcode commands is , because it isn't sequential composition.
These atomic commands would only be allowed in angle brackets, to distinguish them from function calls (which might end up in Starling in the distant future).
Thus, CAS would become
atomic BCAS(shared bool &dest, thread bool &test, bool set)
{
    if (dest == test) {
        dest <- set, test <- test
    } else {
        dest <- dest, test <- dest
    }
}

// <BCAS(dest, test, set)>

and heap assignments from the LC list would become
atomic Unlock(shared int &heap, thread int prev)
{
    forget heap, %{unlock(#1)}(prev)
}

// <Unlock(heap, prev)>

The syntax can be tweaked around a lot though.

This would be very useful in the MCS queue (see #133) where we need a compareAndSet operation over Starling variables. I want to write something like the following:
method unlock (Node qnode) {
  ...
  < if (qnode == tail) {
        tail = null;
        test = true;
     } else {
        test = false
     }  > ;
  ...
}

The only way to do this at the moment is (I think) to piggyback on GRASShopper's if statement, which is dumb:
method unlock (Node qnode) {
  ...
  < test = ( tail == qnode );
    tail = %{ if ( [|test|] ) { [|qnode|] } else { [|tail|] } }; > ;
  ...
}

I think @MattWindsor91 also ran into this when he was trying to encode the Treiber stack.

Theoretically, atomic branches should be possible: they're supported in Microcode.
In practice, I'm not sure if the framing system will handle them properly.  I think it will?

If we can implement branches without the custom command syntax, that means that all we need to do for the custom command syntax itself is lambda abstraction.
At this stage I'd honestly propose getting rid of the < command >; syntax entirely in favour of <{ syntax; }>; (or, personally, I think <| command; |> would be nicer, as otherwise it'll get confusing as to what is allowed where.

Yeah, I think <| command; |> would be nicer given we use curly brackets for a bunch of other things.

I don't understand your first point: does this mean that branches are supported internally but aren't exposed by syntax?


Teardown tunnel automatically if peer's certificate expired

Handle this with periodic keepalive ticks. This is needed to avoid
hanging a connection even peer's certificate expired.
In case you use short-lived certificates (let's say 2 hours), current
behavior is a bit wrong, because the tunnel stays UP and RUNNING fine
unless restarted nebula service.
Signed-off-by: Donatas Abraitis<EMAIL_ADDRESS>

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

An optional feature on/off would be great as well to avoid breaking existing setups.

Can we please also have a notice "Node X's certificate has expired, tearing down connection" in the logs?

Gonna update that, also adding a test for this case.

@virtadpt added more logging regarding disconnection.

So, monitor output for "Invalid certificate status", and then suss out the value of vpnIp for the host that needs remediated.
Works for me.  I'll give it a try this weekend.

@virtadpt any chance you had tested it?

@rawdigits @nbrownus any chance to review this?

@ton31337 Not yet.  I'm still working 90 hour weeks.

Still, no?

I finally went off call yesterday.  I'll give it a try when I have a moment.

Any updates? :)


Any plan to V9 or V10 compatibility

Any plans on upgrading to Foundry V9 or V10?
Or is the project abandoned?

I have tested it on V9 and it works, but I stopped working for foundry modules


Enhancement: Store the current keys/ folder under the top-level repository/

Description

Right now repository/ just contains the published metadata. It would be nice to store the current keys, so that I don't have to cp from the previous repo ceremony directory when I chain init fromthe next. When I do that, I need to grab updated snapshot/timestamp from the published repository.
If I store keys/ in the published repo, then the previous repo always becomes repository/ and I don't need to search a ceremony directory for the old key material.
When I make this change, I'll start the playbook for orchestrating key ceremonies. Since this is a weird detail of the ceremony & repository folder structure
WDYT?
@haydentherapper @dlorenc
I'd like to make that change, I think it's benign and simplifies the management.

repository/repository is mirrored to GCS currently, and we don't need to mirror the keys too. One option which could increase clarity is having an output/ directory, and under that, keys/ and repository/. Do you think that would help?

Thanks! Yes, repository/repository$f files are mirrored, NOT repository/keys, so that wouldn't get mirrored, as far as I can tell.
https://github.com/sigstore/root-signing/actions/runs/2549597503/workflow#L46-L51

Completed


feature request: {clipboard1} {clipboard2} {clipboard3}.....

I use Beef to execute cmd code.
Sometimes I need to use several parameters, eg.
abcabc -i #{clipboard} clipboard2
But beef can only capture one clipboard
So can you add multi clipboard content support??
abcabc -i #{clipboard} -o #{clipboard2} ... ...
or clipboard-1 (wahtever)

Hi.
Unfortunately, Qt, the programming framework upon which Beeftext is built does not grant access to the 'clipboard history' feature of the latest versions of Windows. Implementing it myself is not impossible but would require quite some work and testing.
I keep your suggestion, but assign it a low priority. Do not expect it to be implemented in the near future.


Fix to RCTTestRunner so that RedBox errors are logged when piped thru…

Please select one of the following

[ ] I am removing an existing difference between facebook/react-native and Microsoft/react-native :thumbsup:
[ ] I am cherry-picking a change from Facebook's react-native into Microsoft/react-native :thumbsup:
[X] I am making a fix / change for the macOS implementation of react-native
[ ] I am making a change required for Microsoft usage of react-native

Description of changes
The RNTester RNTesterIntegrationTests suite is unreliable when run in Azure DevOps CI loops: only about 86% pass rate.   It was difficult to diagnose the problem because the logs would show that specific integration tests were failing with a RedBox message, but the contents of the RedBox message were not being logged.
The Azure DevOps build definition tests via xcodebuild and the results are piped to xcpretty which formats the xcodebuild output and generates a JUnit xml results file that ADO uses for analytics.   The RCTTestRunner.m file collects the RedBox error messages in an NSMutableArray and then does an RCTAssert using a formatted message string that formats the array using<EMAIL_ADDRESS>The '%@' format prints an array on multiple lines, but xcpretty will only print the first line of a multiline string.   Change the RCTAssert line so that the errors array is flattened into a single line string delimited by '\n' characters.
With the above fix to RCTTestRunner.m I was able to see that the integration tests were asserting because of the react warning 'Warning: Can\'t call setState (or forceUpdate) on an unmounted component. This is a no-op, but it indicates a memory leak in your application. To fix, cancel all subscriptions and asynchronous tasks in the componentWillUnmount method.%s', '\n    in RNTesterApp.   That was happening because a setState call could happen in the AsyncStorage callback after the component had unmounted: presumably because the test ran and concluded before AsyncStorage returned.   Changed RNTesterApp.ios.js and RNTesterApp.macos.js to maintain a _mounted field that is set and cleared in componentDidMount() and componentWillUnmount() and refrain from calling setState() if the flag is false.
Also fixed an ESLint error that somehow got committed to Libraries/WebSocket/WebSocket.js.
This will resolve bug 3237057.
Microsoft Reviewers: Open in CodeFlow

/azp run


address is not saved on checkout

Bug report
Title
saved address on checkout getting removed when removing product from the cart
Issue Description
saved address on checkout getting removed when removing product from the cart
Preconditions
1. framework Version- 1.3.1 Version (master)

Steps to reproduce
1. step1- add product to cart
2. step2- add new billing address and save
3. step3- now remove item from cart
4. step4- go to customer address

Expected result
the address should be added in address table once saved
Actual result
not getting any address
https://www.loom.com/share/445b90727c3645ad9a2e9c304a061c9f

Save addresses to cart API is not working,
Says,
ErrorException: Array to string conversion

Hi AkashWeybee
Can you attach screenshot with your data while calling API.

Hi AkashWeybee
Can you attach screenshot with your data while calling API.

Apologies, the Issue is from our side.
It's working as expected.


add a keybind to toggle forq on/off

no gui or anything needed just listen for keypresses in the console the way, say, mpv does
alternative is to use different yomichan modes to send to two instances of jpdb-connect, one which forqs and one which just adds to a deck for long-term card adding

I'm not too familiar how different yomichan modes or profiles work.
Would making the port configurable already be enough?
In the medium term I want to add a small (optional) egui window where one can toggle the settings.

lol i assumed the port was configurable, which was what you'd need to use for the second idea (each yomichan profile uses a separate url for the anki endpoint)

I made the port configurable in c664dff7ec9a905f475c644678403b2da7f627df


"Project panel" for a random folder

The project panel gives a lot of functionality to the file management. Adding of library assets, seeing the compiled classes in a SWF, etc. But it's root is restricted to the project file's folder.
The files panel can show every folder's content, but doesn't have all the added functionality, except "add to trusted folder". And doesn't have the tree structure.
My proposal is to allow creating a temporary "Project Panel" but without the project, to any arbitrary folder.
Or, a different approach, add a node in the main project panel, like the "References" node, to be a "folders" node, that will just open different folders in a tree structure.
And add the ability to "Add to library" or "Link in project" inside the Files tab.

I would like very much to support folders as implicit projects.
The problem is that such project would be tied to a target language (AS2, AS3, Haxe or no language), so if we choose to default to "no language" you wouldn't have any configuration/building support for AS or Haxe. Otherwise we would have to ask the user to choose a project type which may be annoying.

I was thinking not as an arbitraryproject for any folder, but rather an extention of the currently opened project. This way, the build target will be of the project, and the use of the new "project like" panel will be to manage resources, libraries, assets and class paths for the currently opened project (or solution), whitch are usually not in the project's folder.
This could be just another node in the reference section of the project panel, and not a completely different panel.

@itzikiap sounds interesting, can I ask what use cases do you have in mind for this feature?

For example, in the project I'm working on, the destination folder is outside of the project. So all the exported SWFs, and the assets and everything is in a different project.
While it is possible to just open an explorer window and navigate there (which is what I do), the project panel gives some more functionality, like inspecting the content of a SWF, which sometimes be very helpful.

I see, that makes sense. Maybe the upcoming solutions feature will include what you want.
For now, it would be convenient if it were possible to create a reference to a particular path (similar to a classpath reference), basically just for display purposes. Problem could be avoiding circular references (e.g. if your path reference to your deployment dir includes your project as a subdir, the reference probably shouldn't list the project dir as a child).


Broken Logout

Issue:
When clicking on the 'logout' dropdown on the Kubernetes dashboard shows its default login screen (provide token or kubeconfig) rather than going back to the kubernetes-dashboard-iam-proxy login screen. Reloading the site shows the correct UI.
Expected Behaviour:
When clicking on the 'logout' dropdown on the Kubernetes dashboard it logs out and shows the kubernetes-dashboard-iam-proxy login screen.

fixed by https://github.com/Nitro/kubernetes-dashboard-iam-proxy/pull/12


[Feature Request] Pomodoro Task Label

It would be awesome to have the ability to label the task at hand designated for the current pomodoro.
My first thought was that it could replace the 'FOCUS' text on the main screen (right-click and edit text?) so as to not reconfigure the UI layout. It could be a bit smaller in font size and auto-scroll within the clipping bounds for longer text (while a tooltip could contain the entire text for a quick hover preview).
Additionally, since I'm already asking :) , there could be a menu where you add them in before starting a new daily session and have it auto-populate the task label on the main screen as you progress through the day so you know what's coming up next.

@Splode I would like to contribute to this project. As I am new to open source anyone from team guide me on how should I get started. Also is there any discord or slack channel for this project?

@Splode I would like to contribute to this project. As I am new to open source anyone from team guide me on how should I get started. Also is there any discord or slack channel for this project?

@abhijeetgurle Glad you’re interested in contributing. Most of the issues here on GitHub involve new feature requests. There are some bugs and a few issues labeled as beginner-friendly. If you’re interested in developing one, continue the conversation in a particular issue.
The general workflow for contributing new features or fixes is:

Fork the repo
Develop locally
Create a pull request (PR)
Work through any feedback
Merge changes into project

There are also opportunities for contributing by testing on various platforms. Bug reports can be a helpful way to contribute, too.
There isn’t a Discord or Slack for Pomotroid.  Most of the project communication happens here on GitHub.
Hope this helps.

Thanks a lot. I love to be the part of the community.

Could this issue include a task list?
Similar to what https://pomofocus.io/ uses.


Login Failed

I try to download udemy videos. but it always shows the Login Failed error. But i give the Correct user name and password but it's not working.

@Aathi10Vel works fine for me and please follow issue reporting guideline.


remove docker.app from docker push targets

Fixes https://github.com/istio/istio/issues/19846

Closing in favor of #19847


Vue3 support

The name says it all, are there any thoughts to port the project to Vue (or Astro, etc.)?
Also, are there any strong points for keeping Next (and SSR) for this type of project?

There has being significant process to supporting more frameworks. The last time I discuss this topic was around 18 months ago in https://github.com/LiveDuo/destack/issues/28#issuecomment-955162556, might be a good time to share some more insights.
What happened since:

Supported React.js and as a side effect seperated the browser editor and the backend server (that saves the json files).
Improved Typescript support that made all migrations easier
Added support for multiple browser editors (now having Craft.js and Grapes.js)
Move the components data (ie. HTML source code and preview images) to the backend

So why does it mean to get Destack other frameworks such as SvelteKit and Nuxt:

Editor challenges: The editor is currently only in React. To get another framework working we'd need to transpile React down to HTML and then create wrapper components in each framework that appends that HTML to the dom when they are loaded in Vue, Svelte etc.
Server challenges: There are currently two ways to use the server. One is through Next.js API and the other is starting it directly as an NPM script (for React only projects). For for every fullstack framework (eg. SvelteKit, Nuxt) we'd need wrapper server functions that use the server endpoint. For frontend frameworks (eg. Svelte, Vue) we can use the existing standalone server implementation I think without problems.
Maintenance challenges: We'd need contributors to handle each of these problems as this project is something I work on my free time. Since I not as familiar with these other frameworks as I am with React and due to the limitations of time, it's better if other developers want to maintain that part of the project.

Hi, sorry for being a beginner,

have you considered adding mitosis or similar approach? it uses JSX but a little different from react and vue, and then can convert it to a variety of frameworks/libraries, so if a person learns that JSX he will be able to export to many frameworks/libraries.
there is another similar project called sveltosis, similar to mitosis but uses some html-like syntax instead of JSX, input code looks much smaller and cleaner, I don't know if its easier to learn or not and whether its as useful in larger projects or not.
it would be even better if instead of that kind of JSX or sveltosis if it uses JSON. which you can write directly or compile to it from JSX, html, etc.

Hey @abdulhakam, thanks for the suggestion.
It could be an involved and lengthy endeavour to use an intermediate compiler for React code like mitosis. Since I don't have enough hands on experience with these tools I can't really say whether it would be worth it or even if it's possible at all.
That's been said, ideas and PRs are welcomed and I try to give my opinion based on my experience developing this library.

So why does it mean to get Destack other frameworks such as SvelteKit and Nuxt:

Editor challenges: The editor is currently only in React. To get another framework working we'd need to transpile React down to HTML and then create wrapper components in each framework that appends that HTML to the DOM when they are loaded in Vue, Svelte etc.
Server challenges: There are currently two ways to use the server. One is through Next.js API and the other is starting it directly as an NPM script (for React only projects). For for every fullstack framework (eg. SvelteKit, Nuxt) we'd need wrapper server functions that use the server endpoint. For frontend frameworks (eg. Svelte, Vue) we can use the existing standalone server implementation I think without problems.
Maintenance challenges: We'd need contributors to handle each of these problems as this project is something I work on my free time. Since I not as familiar with these other frameworks as I am with React and due to the limitations of time, it's better if other developers want to maintain that part of the project.


Setting the requireAngular option

HI! Sorry to bother again. I had mistakes in my previous pull request and now the problem is it is not actually working, I mean the requireAngular is not an option. It is always set to it's default value.
I tried to solve this. I would appreciate if you review again and merge if OK. Thanks

@Ardeshir81 Also I would suggest to raise an issue in the further in case of any problems ;)


Use go 1.20

Let's see if it works

Broadly in favor of doing this. Can we set -buildvcs=false? Go 1.20 changed (read: broke) the handling of git worktrees. (although, git worktrees also wouldn't work inside a container even if they implemented it correctly (because the referenced .gitdir wouldn't be in the container); they just didn't recognize .git files prior to 1.20, so -buildvcs=auto didn't see a git repo)

Can we hold off on this until cloud moves to 1.20 (which I think is quasi blocked on the fact that some things make the linter oom with 1.20?) just so that it's almost possible to develop both of them on the same system/etc

I think that should be fixed by installing the right version of golangci-lint, unless there's a different OOM.

I'm giving this a second chance now, so we'll see. Still think we shouldn't get ahead of cloud but I don't think it matters.

I think that should be fixed by installing the right version of golangci-lint, unless there's a different OOM.

I'm giving this a second chance now, so we'll see. Still think we shouldn't get ahead of cloud but I don't think it matters.

I don't mind waiting until we do it in cloud repo first. Is there a PR for this?

I don't mind waiting until we do it in cloud repo first. Is there a PR for this?

Just made it!

Can we set -buildvcs=false?

Added GOFLAGS=-buildvcs=false to Makefile.
I also passed the variable to all docker build/buildx commands. But can we skip this part or it's required as well?


Support stdio streams in mock_device

This allows creation of a dummy device using socat commands like this:
$ socat -d -d pty,raw,echo=0,link=/dev/ttyACM0 "system:python3 test/mock_device.py,pipes"

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (9001c64) 86.74% compared to head (b416504) 86.74%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #25   +/-   ##
=======================================
  Coverage   86.74%   86.74%
=======================================
  Files           7        7
  Lines         792      792
=======================================
  Hits          687      687
  Misses        105      105

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Python 3.12 & Django 4.2 upgrade

This merge request aims to update the Python package to ensure seamless compatibility with Django 4.2 and Python 3.12. The following modifications have been implemented:
Django 4.2 Compatibility Updates:

[x] Updated references for ugettext_lazy to gettext_lazy.
[x] Upgraded package dependencies to versions compatible with Django 4.2.
[x] Reviewed and adjusted any deprecated Django features, replacing them with their updated counterparts.
[x] Ensured that existing functionality aligns with the latest Django ORM methods and query syntax.

Python 3.12 Compatibility Updates:

[x] Analyzed codebase for any potential issues related to Python 3.12.
[x] Updated syntax and libraries to ensure compatibility with Python 3.12 features and standards.
[x] Performed necessary adjustments to resolve any warnings or deprecation issues raised by Python 3.12.

Ref: https://sdelements.atlassian.net/browse/DEVOP-6777

Left a few comments but all minor stuff, +1


add pre-commit

I am using pre-commit hooks here. @kasperjo such hooks are used to reformat the code before it's getting pushed


train

Can this project not be trained except for data files in *.mhd format?

Of course. Please check your data directory.


Resize to frame using .scaleAspectFit via UIViewRepresentable [Question]

Love this library - brings huge missing SVG support to SwiftUI in general.
I'm struggling to understand how Macaw respects frame sizing. The following is the basic code I'm working with:
struct SVGViewController: UIViewRepresentable {
    func makeUIView(context: Context) -> SVGView {
        let rootNode = try! SVGParser.parse(resource: "Duck", ofType: "svg")
        let view = SVGView(node: rootNode, frame: CGRect.zero)
        view.contentMode = .scaleAspectFit

        return view
    }

    func updateUIView(_ activityIndicator: SVGView, context: Context) {

    }
}

struct MacawSVGView: View {
    var body: some View {
        SVGViewController().frame(width: 50, height: 100)
    }
}

Really the goal is simple - understand how Macaw can automatically scale the SVG to fit within the frame.
I did read about Content Mode removed preserveAspectRatio. Also note I'm working off from master as it seems to have Swift Package Manager support.

Alright - I think I tried everything. I assume there's a bug but any help would be greatly appreciated!

Went another route entirely. Closing

any suggestions to solve this bug?

@nadirabid what did you do?
@icearith did you find a solution?


testing: implement panicky testing.B struct

Fixes https://github.com/AdamKorcz/go-118-fuzz-build/issues/16
Caveat: I haven't tested if it works, not sure what's the easiest way to do that (I suppose that there must exist easier ways than modding my whole oss-fuzz setup to use my fork).
I took nearly all public functions of testing.B, except func (b *B) RunParallel(body func(*PB)), which would pull in yet more structs.
I made the Run panic, otherwise don't see any need to make it panic. Someone might invoke ReportAllocs in init for all I know.

Thank you. I will have to test this before merging.

Hm, it is still not complete. Need to add these methods: https://pkg.go.dev/testing#TB, and then also add the TB interface too.

It might be a problem to add TB because of this: https://github.com/golang/go/blob/983d90e11dd0e12a484def454530fe9f5de031fc/src/testing/testing.go#L900

It might be a problem to add TB ...

I don't think so. I mean, we're not actually implementing that interface, we just want to tick as many boxes in the testing package as possible, so that when we rewrite testing into the "github.com/AdamKorcz/go-118-fuzz-build/testing", we get as few compiler errors as possible.
Example: https://github.com/ethereum/go-ethereum/blob/a8617c6d4dbe0df8c67e1f5c2ecd76c3200dc18d/p2p/discover/v5wire/encoding_test.go#L524C2-L524C2
The TB is just used so that the method can be invoked both by regular tests and benchmarks, and if we're trying to make so we don't choke on B, then we should make it not choke on TB either.

Sg. Let me know when it is ready to be tested (and whether you have also tested it)

Yep, this is ready to be tested (but I have not yet done so)

I don't really see how this PR can break anything, but if it gets merged, I can test it out pretty quickly.
Alternatively, and probably better: if you put it in a branch, my oss-script can use it via go get xx@branch. It's just a huge hassle to install branch on a forked repo, because then I can't use go get, but need to install via source, and add remotes etc.

I will test this PR this week.

So, this B implementation is missing N, which needs to be added to the struct.
For my own purposes, I ended up implementing an alternative: https://github.com/holiman/gofuzz-shim.
It is corpus-incompatible with go-118-fuzz-build, since I realized that I wanted to totally change how the input from libfuzzer is used. That part is implemented here: https://github.com/holiman/gofuzz-shim/blob/main/input/reader.go#L102
Also, I did away with a lot of the code in the shimmer, making it so that the caller simply specifies what files to instrument.
This is the B I wound up using: https://github.com/holiman/gofuzz-shim/blob/main/testing/b.go . It uses a common which is shared with T --  much like the actual testing.T and testing.B under the hood. Feel free to use it if you want.


Allow users to update workflow

We should think the best way for editing workflows.
At the first moment I see 2 options:
1. Recreating the workflow (like a PUT operation)
Pros:

It is easier to implement, we should only override / recreate all the dag file content and keep the reference to it on our database.
Cons:
Despite it be a update, the user can't "undo" and go back to the "creation" state. The update would "create" a new workflow with the new data.
Users would need to wait for dag sync until can run the workflow. I can be annoying with slow git sync sometimes.

2. Updating workflow input arguments using dag config to inject new data into the template.
Pros:

Users can run an already created workflow with custom inputs without the need of creating a new one, would be a "edit and run" experience. It would make the experience of creating / editing / testing workflows much more fast, intuitive and productive.
The first state of the saved workflow are keep in database so if the user edit it and don't like the results it is not saved, the new inputs are running only in the specific manual triggered run.
We can still have the first option, but only when user decide to save the edited workflow with the new configuration parameters.
Cons:
It is harder to implement since we will need to update how we are injecting arguments into the dag template.

Necessary changes:

[ ] Add button to workflows list table that redirect user to the editor page with the workflow data.
[ ] Create patch endpoint for updating workflows.

Possible/Probably changes:

[ ] Update workflow Jinja template to accept inputs as variables
[ ] Update how we inject data into each workflow

@luiztauffer @nathan-vm @tdari FYI


Symfony bootstrap 4 theme

This pull request is related to #123.
I encountered the same problem raised by @codedmonkey and his solution solved the issue.

Updated default elements_selector to handle form theme while using bootstrap 4

I've received an email about BC breaks regarding this issue, well I told him to overwrite the option as I think that all in all, this change worth it 👍
For those interested:
Only Bootstrap 3: set the option elements_selector to > div
Only Bootstrap 4: set the option elements_selector to > fieldset

Maybe one nice solution is to allow to modify elements_selector with the given options? I tried that before submitting the pr, but didn't work (tbh i didn't go further in the why it did not).
Like, by default elements_selector: '> div, > fieldset', but overridable with options.
By the way i wrote > div, > fieldset because there are some cases where symfony still render a div tag in my project.
I use symfony 3.4 and bootstrap 4.
If my collection is a simple type (like TextType) it's rendered within a div, but when i work with a complex type (my use case was 3 selects) then symfony render the whole thing into a fieldset.

Overwritting elements_selector is possible in the options, strange that it didn't work for you. Code set the settings using a regular var settings = $.extend(true, {}, defaults, options); and thus it should work.

I think this pull request is also related to issue #105


[BUG] Userlist No Ending Date selection

Describe the bug
In the Userlist page, in the case Select Dates was chosen as Period, when clicked the submit button after choosing a Beginning Date but not choosing an Ending Date, no users should be listed and an error message should be shown: "Please select an Ending Date."
What Did You Want
As an admin user, I wanted to see if the Userlist period filter's Select Dates choice was working properly. In this scenario, I did not select an Ending Date and wanted to see an error message and no users listed.
To Reproduce
Steps to reproduce the behavior:

Login as admin and go to Admindashboard-Users.
Chose "Select Dates" in the "Choose a Period" combobox.
Click "Submit" to see the Beginning Date and Ending Date fields.
Select a date in the Beginning Date field.
Click "Submit" without selecting any date in Ending Date field.
See all users are listed from the selected beginning date until now.

Expected behavior
No users listed.
Under the "Submit" button, following error message should be shown: "Please select an Ending Date."
Result behavior
All users are listed.
No error message.
Screenshots
Desktop (please complete the following information):

OS: Windows
Browser: Chrome
Version: -

Additional context

Bug fixed.


drivers: led: led_pwm: add perceived brightness control

This new option adjusts the perceived brightness (%) to be proportional to the cube root of the LED PWM duty cycle.
This follows the CIELAB color space lightness calculation using the cube root of the relative luminance, see:
https://en.wikipedia.org/wiki/CIELAB_color_space.

Hi Simon,
Thanks for the review. If brightness correction is applied after the current PWM based LED driver then the resolution of the PWM hardware behind it is lost (due to quantisation to the 0-100 range of the API) and the resulting levels of perceivable brightness available to a user of the driver will be reduced. Other LED driver ICs like the LP503x have this feature built in as a configuration option (they call it logarithmic scale dimming).  When recently working on the PCA9685 driver https://github.com/zephyrproject-rtos/zephyr/pull/50314 and testing it with the LED PWM sample that the brightness increasing part of the LED sequence:
https://github.com/zephyrproject-rtos/zephyr/blob/main/samples/drivers/led_pwm/src/main.c#L61-L70
the roughly 60% to 100% range of the brightness scaling didn't appear to change in brightness.
Yes I definitely agree with you that the scope of this patch should probably be increased.
I would say a PWM driver should just control linear PWM but a LED driver that controls brightness that is most often intended for lighting for a human or a user interface for a human then it should ideally be able handle the needs of these use cases.  I'll write up an issue to describe the problem so it can be discussed some more.

Hi Simon, Thanks for the review. If brightness correction is applied after the current PWM based LED driver then the resolution of the PWM hardware behind it is lost (due to quantisation to the 0-100 range of the API) and the resulting levels of perceivable brightness available to a user of the driver will be reduced.

That's correct. Note that the API range should be moved to 0-255. From my experience, color correction reduced by this range is good enough.

Other LED driver ICs like the LP503x have this feature built in as a configuration option (they call it logarithmic scale dimming).

On this device, I am still using software gamma correction, because the hardware feature doesn't render LED effects correctly.

When recently working on the PCA9685 driver #50314 and testing it with the LED PWM sample that the brightness increasing part of the LED sequence:
https://github.com/zephyrproject-rtos/zephyr/blob/main/samples/drivers/led_pwm/src/main.c#L61-L70
the roughly 60% to 100% range of the brightness scaling didn't appear to change in brightness.

Yes. And it is also the case for most of the other LED and LED strip controllers which doesn't provide hardware correction. Plus you don't want to tie a driver with a specific algorithm. You want to be able to plug or apply the software correction algorithm of your choosing (it can be cube root of the relative luminance, gamma correction, or even a static conversion table given by the user) to any of the LED drivers.

Yes I definitely agree with you that the scope of this patch should probably be increased.

Please, increase the scope :)

I would say a PWM driver should just control linear PWM but a LED driver that controls brightness that is most often intended for lighting for a human or a user interface for a human then it should ideally be able handle the needs of these use cases. I'll write up an issue to describe the problem so it can be discussed some more.

Yes I agree. But this issue also exists for most of the LED and LED strip drivers. So let's fix them too.


Python 2 Support

Hi @ignertic. Can you please briefly outline what you did? Python 2 Support is a bit too obscure a commit message.  What changes did you make that led to the support of Python 2?


Cloud hypervisor + kata does not start when using high CPU & memory config

Description of problem
Creating a kata+clh k8s pod with huge amounts of CPU(>32 cores) and memory (>128GB) will always fail and the container will never start.  @jcvenegas  was able to reproduce this issue with Kata 1.11.1 and CLH 0.7
https://gist.github.com/jcvenegas/465be230a85b1800e23b4d7dda1d7add#file-guest-logs
Expected result
Kata + CLH can run VMs with large number of cores and memory
Actual result
Container will fail to start. @jcvenegas  has confirmed that CLH 0.8 version has a fix for this issue (https://github.com/cloud-hypervisor/cloud-hypervisor/issues/1132) and should fix the problem. Opening this bug to track the issue and close it once 1.11.x stable gets a CLH update (if needed).

@jcvenegas @amshinde @likebreath

@chavafg We need to add a test for this. Test both qemu and clh with large CPUs and memory config. I dont think the VMs we get from Azure will be adequate for this.

@amshinde agree, could this run on nightly basis? If so, we could use baremetal from aws.

This is fixed in master, was a fix after upgrade to cloud-hypervisor 0.9


Add GAP dataset

GAP dataset
Gender bias coreference resolution

This dataset already exists apparently, sorry :/
see
https://github.com/huggingface/datasets/blob/master/datasets/gap/gap.py
Feel free to re-use the dataset card you did for /datasets/gap

oh heck, my bad 🤦♂ sorry

I think you should also delete this branch.


Use a &'static str instead of String in AwsJsonRouter

Description
I noticed they key for the routes map could be a &'static str so I made this change to save some allocations.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

The allocation only occurs once at startup but this seems reasonable change. We'll probably need to tweak the code generation slightly too?


'static_cast': cannot convert from 'float' to 'ImGuiDir_'	imguibuilder\main\build_config.cpp	233

These 2 lines were
			case 23:
				custom_gui_style.WindowMenuButtonPosition	= static_cast<ImGuiDir_>( std::stof( line ) );
				break;
			case 24:
				custom_gui_style.ColorButtonPosition		= static_cast<ImGuiDir_>( std::stof( line ) );
				break;

but when I used (ImGuiDir)(...), it build and run fine.
like:
			case 23:
				custom_gui_style.WindowMenuButtonPosition	= (ImGuiDir)( std::stof( line ) );
				break;
			case 24:
				custom_gui_style.ColorButtonPosition		= (ImGuiDir)( std::stof( line ) );
				break;

But at end, when I try to generate code, it shows this error in image.

I did tests here in all ways and I didn't have the same problem, I tried with several controls and settings and it didn't give an error.
static_cast is correct, it's from a float to an enum, it doesn't make sense for this to be the cause of the problem.

Not sure why, but this error do appear on my PC, but not when I compile it via github vps.
The compiled files are now working fine without giving any error.
https://github.com/Code-Building/ImGuiBuilder/pull/11

Appears on my pc too. Same error. Everything up to date