prevents flavors creation with name already exists

Even if OpenStack Nova accepts flavors with same names the current
design based on flavor name as uniq identifier can't make that
condition possible.  This commit prevents it and make the process to
return correct a HTTP status code.
Signed-off-by: Sahid Orentino Ferdjaoui<EMAIL_ADDRESS>

Hum... I updated the branch flavor-uniq-name in sahid/dicot-api, I expected the PR to be updated as-well.
https://github.com/dicot-project/dicot-api/compare/master...sahid:flavor-uniq-name

In the last update I addressed what you suggested


add a scope to Chatbot.refresh to manage state efficiently

Being able to call the refresh method with designated scopes allow reading settings.json and efficiently modify the config object. For something like changing the experimental optional params, this would would avoid new class initializations.

This is still a good idea. I'll work on more DAGs and move to LangGraph to manage State, but the chatbot has a lot of goodies in it that will take time to port over.


PHOENIX-6962 Write javadoc for different mutation plans within Delete…

…Compiler

@tkhurana  Can you please review this PR for correctness? I am also not that familiar with the decisions involved in selecting mutation plan.

@jinggou There are other things to like serverside deletes need a config to be set. Only then server side deletes are enabled.

@tkhurana you meant any additional config on top of auto-commit?

oh i think it needs phoenix.client.enable.server.delete.mutations to be enabled, which is enabled by default but yeah we can mention this with auto-commit. we can specify: for server plan, auto-commit and server delete mutations should be enabled

@jinggou I would suggest you to run tests in DeleteIT and explore the various explain plans to get a better understanding of the scenarios where each plan is used.

@jinggou I would suggest you to run tests in DeleteIT and explore the various explain plans to get a better understanding of the scenarios where each plan is used.

@jinggou I would suggest you to run tests in DeleteIT and explore the various explain plans to get a better understanding of the scenarios where each plan is used.

I've run all tests in DeleteIT and try more by modifying delete statement. I've updated javadoc based on above comments. Feel free to comment more if you find anything is missing/incorrect. Thanks!

Thanks @jinggou

Thank you @jinggou, +1

@shahrs87 anything from you sir before closing this PR?


Filtering by spoken language (new option)

Currently we can only filter by language, date, and stars, we should also add --spoken-language option to filter by spoken language (Chinese, English, etc):

Github API can probably filter it for us, if not, we might have to scrape it from the website.
Remember to update the readme when adding a new option

I would like to work on this.

Ok @Saif807380 👍🏼

@hedythedev I checked out GitHub Search API documentation. There doesn't seem to be any query parameter for getting repos by spoken language. As for the image you mentioned, that is from the trending repos section. A get request on that url with the query parameters returns HTML  so I guess we will have to proceed with scraping. Let me know if there is any alternate way.


html-to-image library: Add video poster support

Task Description
html-to-image does not support video poster currently, causing some issues. We're using a local patch for that but also have a PR waiting to get merged upstream.
Upstream PR: https://github.com/bubkoo/html-to-image/pull/149

cc @merapi FYI

@barklund @merapi FYI the upstream PR got merged in so once a new version gets released, we can remove our patch.


Support for sparse data

Hi,
I think some data, e.g. the tmc2007, would be better loaded in as somewhat sparse format. How do you think?

Would be really cool to have it. Can you make a pull request of this?

I was thinking about this, too. But I did not yet find an appropriate representation of sparse data which does not rely on an external library (scipy). You can then read the arff file in a data structure which is the input to a scipy.sparse matrix (https://github.com/mfeurer/liac-arff/commit/2a39b56b7affa0143b575dd814f796360bc50639). If you have some suggestions on how to go on from the code which is in my repo, I will be happy to do a pull request.

How about using dictionary?
For example, in libsvm's python interface, they store sparse data in such format:
dense_fmt = [[0, 0, 1, 3, 0, 0, 5], ...]
sparse_fmt = [{2: 1, 3: 3, 6: 5}, ...]

How do you think?

That looks like a simple format. But I don't know how to go from that to something scikit-learn accepts.
What do you think about an argument to the ArffDecoder which determines the behaviour for sparse data? Right now this argument could take the values dense, list_of_dicts, coo.

I think passing an argument for specifying the type is very helpful! That's exactly what I want!

By the way, when using sparse format, would it be great if we turn nominal/category attributes to numeric (i.e., using integer: 0, 1, 2, ... to represent category) when returning?

The second thing is already implemented. I just checked and the documentation is not up to date. If you build the documentation on your computer, you will find an example of how to do that.
For the extra argument with the sparse data I would wait for the opinion of @renatopp before I will create a pull request.

Hi!
The extra argument seems fine to me, but it should be well documented. What options we would add right now?

dense: all values
coo: a list of rows, a list of cols, and a list of data
list_of_dicts: a list of dicts {col:value}
anything else?

The option names would be these?
Another thing to consider is how dump would be made (in implementation level).

With this, may be the time to split the module into several files, what do you think?

Hi,
yes, documentation is important. I think the three choices dense, coo and list_of_dicts are fine for now.  If you have a look at my prototype implementation I had before this issue, you can see that it is quite hacky. Therefore I also propose to add a new object data (and subclasses for dense, coo and list_of_dicts), which avoids the if-statements like here. The user would not see this, but get a plain python object as a return value. On the implementation side, we would need an encoder for each of these objects. If this makes sense, I can start implementing this as soon as I find some time for it.
Best,
Matthias

Please have a look at my pull request.


Manage overly complicated geometries

Sometimes, you have to search with overly complicated geometries coming from public datasets as OSM.
I have in mind the Grand Est region for example.
The big problem here is that some providers cannot ingest long WKTs and therefore the search has to be done on the convex_hull of the geometry to be ensure the query.
This leads to a side effect for non convex geometries: some queried tiles can be inside the convex hull but ouside the wanted geometry.

For now my workaround is to crunch the search result like this:
crunched_query = current_query.crunch(FilterOverlap(config={"minimum_overlap": 0.001}),
                                                  geometry=actual_aoi)

I don't know if a layer can be added in the search function to manage this usecase ?

Thanks @remi-braun for that interesting issue (and the nice image!).
There's actually internally already an attempt to simplify the sent WKT if it is too long:
        @staticmethod
        def convert_to_rounded_wkt(value):
            wkt_value = wkt.dumps(value, rounding_precision=COORDS_ROUNDING_PRECISION)
            # If needed, simplify WKT to prevent too long request failure
            tolerance = 0.1
            while len(wkt_value) > WKT_MAX_LEN and tolerance <= 1:
                logger.debug(
                    "Geometry WKT is too long (%s), trying to simplify it with tolerance %s",
                    len(wkt_value),
                    tolerance,
                )
                wkt_value = wkt.dumps(
                    value.simplify(tolerance),
                    rounding_precision=COORDS_ROUNDING_PRECISION,
                )
                tolerance += 0.1
            if len(wkt_value) > WKT_MAX_LEN and tolerance > 1:
                logger.warning("Failed to reduce WKT length lower than %s", WKT_MAX_LEN)
            return wkt_value

With WKT_MAX_LEN= 1600`.
It's applied to: theia, peps, sobloo, creodias, mundi and onda.
Did you observe this issue with one of these providers?

I faced it on SciHub 😅
The trick convex_hull + refinement is the most robust and easily implemented workaround I found.
I don't think this is really urgent, but I preferred highlighting this just in case

Ok I see! I guess that you access SciHub with the eodag-sentinelsat plugin. Its configuration could be updated to round the wkt if need be, similar to theia for instance:
https://github.com/CS-SI/eodag/blob/cfc291ff30ab84fcf4f11798dc012437b6154d1c/eodag/resources/providers.yml#L589
I'd bet that it would fix the issue with the Grand Est region.
An edge case with convex_hull + filter could be that we allow multipolygon geometry. For instance, locations=dict(country="FRA") selects continental France, Corsica, French Guyana... I have to check that a convex hull of this kind of shape doesn't result in a selected area too wide compared to the original area of interest. A more robust approach here would be to convert a multipolygon to polygons and then apply convex_hull + filter for as many requests as polygons.
Another one might be that if convex hull + filter is implemented for dag.seach, the results obtained (single page) could be empty if the search is made on a wide temporal frame. That would be unlucky, but the first results (20 by default) could actually be located within an area between the convex hull envelope and the original geometry envelope, so completely filtered out by the cruncher.
Despite these points, I think this is an important case and that we have to cover it somewhere in the docs. Let's also see what @sbrunato has to say about it :)
And yes don't hesitate to report here any issue that you experience with eodag, it helps us maintaining it and can inform anyone else who experiences the same issue.

eodag-sentinelsat v0.3.0 is ready to publish, but I will include this quick-fix to the provider configuration! Thanks for pointing at this out!


How to get child nodes scope from parent scope?

I need to be able to access a child scope from a parent scope but I am having a difficult time figuring this out. I read the docs and searched the issues but I'm not making progress. For the sake of this example let's just say we want to get the scope of the first child.
tree-node-content.html

    hi

controller.js
$scope.getFirstChildScope = function(scope){

    //All of these return undefined
    console.log(scope.$nodes);
    console.log(scope.$childNodesScope.$nodes);
    console.log(scope.$childNodesScope.$modelValue[0].$scope);
    console.log(scope.$childNodesScope.$modelValue[0].$nodeScope);

}

All of those methods return undefined. Is there any way to access child node scope from a parent scope?

It's worth noting that the way child nodes appears depends on your bounded variable(s).
For example, in my case I have the following template / data:

And thus, the child nodes are accessible as childPrograms property and not childNodes. For example, to search child nodes in my case would work as so:
function searchChildren(scope) {
    if (scope.childPrograms) {
        for (var i = 0; i < scope.childPrograms.length; i++) {
            if (searchChildren(scope.childPrograms[i])) {
                return true;
            }
        }
    }
    return false;
}


etcd host reordering triggering frequent api restarts.

Another thing noticed from testing:
  * openshift_create_master[Create master configuration file] action create
    * template[/etc/origin/master/master-config.yaml] action create
      ESC[32m- update content in file /etc/origin/master/master-config.yaml from 4ecc87 to 4f0dc5ESC[0m
      ESC[37m--- /etc/origin/master/master-config.yaml  2017-12-11 14:34:26.655966488 +0000ESC[0m
      ESC[37m+++ /etc/origin/master/.chef-master-config20171211-15064-39vg8f.yaml       2017-12-11 14:37:52.251797468 +0000ESC[0m
      ESC[37m@@ -74,8 +74,8 @@ESC[0m
      ESC[37m   certFile: master.etcd-client.crtESC[0m
      ESC[37m   keyFile: master.etcd-client.keyESC[0m
      ESC[37m   urls:ESC[0m
      ESC[37m-    - https://<IP_ADDRESS>:2379ESC[0m
      ESC[37m     - https://<IP_ADDRESS>:2379ESC[0m
      ESC[37m+    - https://<IP_ADDRESS>:2379ESC[0m
      ESC[37m     - https://<IP_ADDRESS>:2379ESC[0m
      ESC[37m etcdStorageConfig:ESC[0m
      ESC[37m   kubernetesStoragePrefix: kubernetes.ioESC[0m
      ESC[32m- restore selinux security contextESC[0m
      ESC[0m  Recipe: cookbook-openshift3::defaultESC[0m
    * service[Restart API] action restart

The above shows that a reordering of etcd hosts results in an API restart. This seems sub-obtimal, and causes issues. Going to investigate.

Trying and testing a fix on 'ordering' branch. library that generates 'server' arrays will be returned sorted.

Fixed and merged.


Pkg bug

Description
Changed text for package unavailable default state
Fixes # (issue)
Type of change
What is it?

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Documentation update
[ ] Tests update

Checklist:

[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] I run npm run lint:js:fix to check that my code is properly formatted

Codecov Report

Merging #286 (792f1ff) into master (41f2474) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #286   +/-   ##
=======================================
  Coverage   31.26%   31.26%
=======================================
  Files         102      102
  Lines        2095     2095
  Branches      605      605
=======================================
  Hits          655      655
  Misses       1319     1319
  Partials      121      121

Impacted Files
Coverage Δ

src/Routes/ImageManagerDetail/ImagePackagesTab.js
0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41f2474...792f1ff. Read the comment docs.


Update jscs to version 2.0

changes looks good to me but garant seems to have some issues.

Downloads from Midas fail occasionally, I haven't figured out why yet.

Okay so not specific to this branch. LGTM :+1:


Added LayoutValueResolve BuildContext extension

This simple feature adds the ability to resolve LayoutValue, using an extension on BuildContext, thus making this feature syntactically similar to other package's BuildContext extensions, such as context.watch() or context.read().
This
BreakpointValue(xs: 0.0, sm: 10.0).resolve(context)

is the same as
context.resolve(BreakpointValue(xs: 0.0, sm: 10.0))

I don't think this is a great idea. Using context.resolve() does not make it easier to use or understand compared to the inner method.
Class.resolveFrom(context), is a method already used in different classes inside the framework (eg CupertinoDynamicColor ), so context.resolve could mislead people as it is not straight forward that it is only related to layout values.
I can see context.layout.resolve(myValue) as a viable option, still don't see a great advantage.
context.read<int>() compared to Provider.of<int>(context), reduces significantly the code and makes it more understandable.
context.resolve(layoutValue) compared to layoutValue.resolve(context), is the same code and makes it less understandable. (even harder to use because missing extensions autoimport

OK I see your point here, makes sense to me.
Thanks for the feedback, closing this PR.


Slow compile

Describe the issue briefly here.
Environment Versions

OS Type: Ubuntu 19.04
Python version: Python 3.7.3
pip version:  pip 19.0.3
pip-tools version: pip-compile, version 3.7.0

Steps to replicate
I have a new environment with the following requirements.in:
Cython
torch
torchvision

when I run pip-compile it just hangs.
Here is the output of pip-compile -v:
Using indexes:
  https://pypi.org/simple

                          ROUND 1
Current constraints:
  Cython
  torch
  torchvision

Finding the best candidates:
  found candidate cython==0.29.10 (constraint was <any>)
  found candidate torch==1.1.0 (constraint was <any>)
  found candidate torchvision==0.3.0 (constraint was <any>)

Finding secondary dependencies:
  torchvision==0.3.0        requires numpy, pillow>=4.1.1, six, torch>=1.1.0
  torch==1.1.0 not in cache, need to check index

Expected result
Compiles normally
Actual result
Hangs on checking index?

Hello @Rizhiy,
Looks like torch package have large size. Would be nice to see progress-bar though.

The thing is, I haven't noticed that problem before, even though I was using torch with pip-compile for more than 6 months.

And on my other machine using python3.5 this problem doesn't seem to occur, although it does have faster CPU

And on my other machine using python3.5 this problem doesn't seem to occur, although it does have faster CPU

Let me guess, was it macosx?

Nope, both Linux

Nope, both Linux

Strange, because macox wheel weight 88.9 MB, but linux wheel - 676.9 MB.

What does it do when checking the package? Does it download it? Or does it hash the contents?

What does it do when checking the package? Does it download it? Or does it hash the contents?

It does download it (the same as pip install torch and speed checking index and install should be the same). It will hash if you pass --generate-hashes to the pip-compile.

Normally when I run pip-compile, I have already installed the package with pip. Is it possible to add functionality, such that pip-compile uses pip cached version of the package instead of downloading it again?

Is it possible to add functionality, such that pip-compile uses pip cached version of the package instead of downloading it again?

Actually it works this way. The pip-compile uses pip API to download package (to check dependencies), so it should use cached wheel for a package if it had been installed before. See:
# clear cache
$ rm -fr ~/Library/Caches/pip*

# make sure torch is not installed
$ pip uninstall torch
WARNING: Skipping torch as it is not installed.

# pip-compile torch
$ echo torch | pip-compile - -qo-

# See that pip uses cached torch
$ pip install torch
Collecting torch
  Using cached https://files.pythonhosted.org/packages/c9/e2/40f7f017437139e5dc076ea5ad4207da61250cc078bceef7d6f333c1d05c/torch-1.1.0-cp37-none-macosx_10_7_x86_64.whl

TBH, I don't see why it would take so long if it is already downloaded.

I don't use virtualenv, I use conda, can that be a problem?

Should work with conda.

I'm 99% sure that's the problem when pip-tools downloads large wheels. We need a progress-bar for that process.

@Rizhiy
Could you try your requirements.in with this version of pip-tools (#949)?
$ pip install git+https://github.com/atugushev/pip-tools.git@downloading-progress-bar#egg=pip-tools

$ pip-compile -v


Issue with the Cluster Witness Storage Account Name While trying to deploy the cluster

Note: For ease of issues and pull requests management and tracking, we kindly ask you to provide a meaningful and concise title to this issue and answer all questions to the best of your ability.

Is your issue related to a Jumpstart scenario, ArcBox, HCIBox, or Agora?
HCIBox
Describe the issue or the bug
I am trying to deploy the cluster as described in this section (https://azurearcjumpstart.io/azure_jumpstart_hcibox/cloud_deployment#azure-portal-azure-local-instance-validation-and-deployment) but the cluster witness storage account name parameter value is not accepting. Can you please assist

We are triaging the issue with azure portal experience of deploying arm templates.
Until the fix is in place, workaround is to use powershell/az cli to deploy the cluster using template:
powershell way:
New-AzResourceGroupDeployment `

-Name ExampleDeployment   -ResourceGroupName 20H2HSC1-rg
-TemplateFile  template_file_path `
-TemplateParameterFile parameter_file_path


remove fps on animation, just start frame

looks like the animation takes just "frames" the documentation says "fps starting frame" and changed to "starting frame"

Hi Jeff, long time :) Thanks.


Add prerequisites view

This pull request aims to add a view of the prerequisites for each discipline.
A simple popover has been added that activates after mouse hover, improving the user experience without affecting the current styling pattern (the feature also respects theme changes).

✨ Thanks for the contribution, @edilsonalves ! Feel free to add new features you feel that would be a good fit for this project.


ng update not resolving the correct NPM package when using npm:<name> syntax as version range

Command
update
Is this a regression?

[ ] Yes, this behavior used to work in the previous version

The previous version in which this bug was not present was
No response
Description
I searched through the issues and I did found some related issues but they weren't exactly the same:

https://github.com/angular/angular-cli/issues/23448
https://github.com/angular/angular-cli/issues/10624

Feel free to close this issue if you fill like it's a duplicate of another one.
I wanted to update my angular project to the latest version and I executed the command:
ng update @angular/cli @angular/core

In my project I have as a development dependency @types/web (TypeScript DOM declaration files) because I have private libraries that use my applications and I like to make sure that all my projects use the same version of declaration files and also I like to decouple the TypeScript compiler version from the declaration files version.
The dependecy in the package.json looks like the following:
"@typescript/lib-dom": "npm<EMAIL_ADDRESS>
You can see that the package hosted in NPM registry is @types/web but the name of the dependency store in node_modules is @typescript/lib-dom.
It's this way because TypeScript will search in /node_modules/@typescript/lib-dom to know if the declaration files have been installed independently. If the folder is not present, it will use the declaration files that come with the TypeScript compiler (/node_modules/typescript/lib/lib.dom.d.ts).
When I execute the ng update command, I get the following error:
✔ Packages successfully installed.
Using package manager: npm
Collecting installed dependencies...
Found 16 dependencies.
Fetching dependency metadata from registry...
✖ Migration failed: 404 Not Found - GET https://registry.npmjs.org/@typescript%2flib-dom - Not found
  See ".../angular-errors.log" for further details.

Basically, the Angular CLI is trying to fetch @typescript/lib-dom but this is not the name of the package, the correct name to fetch is @types/web.
Minimal Reproduction
I have created the following repository that reproduces the issue.
You don't need to clone it, you can follow the steps explained in the README.md:
https://github.com/jordimarimon/angular-cli-update-issue
Exception or Error
[error] HttpErrorGeneral: 404 Not Found - GET https://registry.npmjs.org/@typescript%2flib-dom - Not found
    at /tmp/angular-cli-packages-Fv6UlW/node_modules/npm-registry-fetch/lib/check-response.js:95:15
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async RegistryFetcher.packument (/tmp/angular-cli-packages-Fv6UlW/node_modules/pacote/lib/registry.js:87:19)
    at async Promise.all (index 3)
    at async /tmp/angular-cli-packages-Fv6UlW/node_modules/@angular/cli/src/commands/update/schematic/index.js:671:36
    at async callRuleAsync (/tmp/angular-cli-packages-Fv6UlW/node_modules/@angular-devkit/schematics/src/rules/call.js:77:18)

Your Environment
Angular CLI: 15.2.8
Node: 18.12.1
Package Manager: npm 9.5.1
OS: linux x64

Angular: 15.2.9
... animations, common, compiler, compiler-cli, core, forms
... platform-browser, platform-browser-dynamic, router

Package                         Version
---------------------------------------------------------
@angular-devkit/architect       0.1502.8
@angular-devkit/build-angular   15.2.8
@angular-devkit/core            15.2.8
@angular-devkit/schematics      15.2.8
@angular/cli                    15.2.8
@schematics/angular             15.2.8
rxjs                            7.8.1
typescript                      4.9.5

Anything else relevant?
No response

same issue

same issue.

@alan-agius4 , is this issue going to be taken care of soon?

There is not ETA for a fix for this, however PRs are most certainly welcome.

I just hit the same issue. Furthermore, I also tried adding an explicit override for the package along the lines of
"overrides": {   "@typescript/lib-dom": {     "@types/web" : "^0.0.99"   } }
(different package for me). No luck either.


Preliminary Tomcat 8 compatibility

This adds preliminary Tomcat 8 compatibility.
Only a few quick tests were done, but everything seems to work fine so far.

Great, @xdarklight!


Add various missing APIs to io-classes

resolves input-output-hk/ouroboros-network#2797
resolves input-output-hk/ouroboros-network#2650
resolves input-output-hk/ouroboros-network#3436
resolves input-output-hk/ouroboros-network#2588
resolves input-output-hk/ouroboros-network#2587
resolves input-output-hk/ouroboros-network#2586
TODO:

[ ] StrictTArray
[ ] StrictTSem
[ ] StrictTChan

It's probably not a bad idea to split the MonadSTM class into smaller pieces, following how the stm package is organised:

MoandSTM: which just provides STM, atomically, etc  and is a base class for all the other type classes.
MonadTVar
MonadTArray
MonadTBQueue
MonadTChan
MonadTMVar
MonadTQueue
MonadTSem


fix: Notification Progress doesn't update correctly

Description
I have been utilizing a this package for downloading video files, and overall, it has proven to be quite effective. However, I have encountered a minor issue wherein the notification displaying the download progress fails to update the current value accurately. Despite the download completing successfully in most cases, the notification progress tends to become stuck at around 70-80 percent.
Furthermore, on certain occasions, the package throws an error stating "connection closed." It would be highly beneficial if there were a built-in mechanism to automatically retry the download from the point at which it was interrupted. Additionally, it would be greatly appreciated if there were a manual option available to re-download the video if needed.
I have also observed that once the package encounters an error, it ceases to initiate any further downloads until the application is closed and reopened. This behavior seems to persist until the app is restarted.
These observations have been made while testing the package on Android 13.
Despite the aforementioned issues, I must acknowledge that this package has proven to be an invaluable asset. I sincerely appreciate your efforts and contributions in developing such a useful tool. Thank you very much.
Steps To Reproduce

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected Behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Additional Context
Add any other context about the problem here.

There should be a way to increase chunk size. By default, you're using 512 kilobytes. Can we improve the size? So we can download files much faster

@OttomanDeveloper for now no but i can will add option in next version
and for the notification issue i will check it

I found an issue. It downloads the file very slowly even if you have very fast internet.

@OttomanDeveloper can you provide me a link ? i will check it


Show how this/that might work

Document current behavior for 1998, 1999 and 2000

@mithunpaul08 just FYI, not to merge.  I'll erase it soon.

I'm expiring the example.  The branch will still be there for a little while.


Automated cherry pick of #2730: Fix panic bug in Antrea Policy

Cherry pick of #2730 on release-0.13.
#2730: Fix panic bug in Antrea Policy
For details on the cherry pick process, see the cherry pick requests page.

/test-all
/test-ipv6-all
/test-ipv6-only-all

/test-all
/test-ipv6-all
/test-ipv6-only-all

/test-all
/test-ipv6-all
/test-ipv6-only-all

Codecov Report

Merging #2761 (e5771a8) into release-0.13 (f456887) will decrease coverage by 19.46%.
The diff coverage is 70.00%.

@@                Coverage Diff                @@
##           release-0.13    #2761       +/-   ##
=================================================
- Coverage         60.94%   41.47%   -19.47%
=================================================
  Files               201      116       -85
  Lines             17286    14623     -2663
=================================================
- Hits              10535     6065     -4470
- Misses             5650     8044     +2394
+ Partials           1101      514      -587

Flag
Coverage Δ

kind-e2e-tests
?

unit-tests
41.47% <70.00%> (+0.53%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/agent/openflow/network_policy.go
75.18% <70.00%> (-0.53%)
:arrow_down:

pkg/agent/agent_linux.go
0.00% <0.00%> (-100.00%)
:arrow_down:

pkg/ovs/openflow/default.go
0.00% <0.00%> (-100.00%)
:arrow_down:

pkg/agent/config/node_config.go
0.00% <0.00%> (-100.00%)
:arrow_down:

pkg/apis/controlplane/helper.go
0.00% <0.00%> (-100.00%)
:arrow_down:

pkg/agent/cniserver/pod_configuration_linux.go
0.00% <0.00%> (-100.00%)
:arrow_down:

pkg/apis/controlplane/v1beta1/register.go
0.00% <0.00%> (-92.86%)
:arrow_down:

pkg/ovs/openflow/logs.go
9.52% <0.00%> (-90.48%)
:arrow_down:

pkg/apis/controlplane/register.go
0.00% <0.00%> (-88.24%)
:arrow_down:

pkg/agent/client.go
0.00% <0.00%> (-77.42%)
:arrow_down:

... and 164 more

/test-e2e
/test-windows-e2e
/test-ipv6-e2e

/test-e2e
/test-windows-e2e

/skip-e2e
As the only failure was related to testbed ssh configuration:
=== CONT  TestClusterIP
    service_test.go:48: Error when running command 'curl --connect-timeout 1 --retry 5 --retry-connrefused <IP_ADDRESS>:80' on Node 'antrea-e2e-for-pull-request-3300-md-0-5cf4d99645-hqzkm', rc: 0, stdout: , stderr: , error: error when retrieving SSH config for node 'antrea-e2e-for-pull-request-3300-md-0-5cf4d99645-hqzkm': unable to find 'HostName' for 'antrea-e2e-for-pull-request-3300-md-0-5cf4d99645-hqzkm' in SSH config
=== CONT  TestClusterIP/ClusterIP/Linux_Pod_on_different_Node_can_access_the_Service


As we changed to add a 5% summary cache some time ago, we should also…

… change default read to DIRECTIO.
That was an oversight at the time.
@geirst and @jobergum PR

@baldersheim Note that some config-model unit test must be updated:
java.lang.AssertionError: expected:<MMAP> but was:<DIRECTIO> 	at com.yahoo.vespa.model.search.NodeFlavorTuningTest.assertSummaryReadIo(NodeFlavorTuningTest.java:115) 	at com.yahoo.vespa.model.search.NodeFlavorTuningTest.require_that_summary_read_io_is_set_based_on_disk(NodeFlavorTuningTest.java:86)


Add integration test for MySQL 8.0

Automatic testing (currently in development) currently fails since the tool bundles MariaDB jdbc driver that takes precedence.
java.sql.SQLException: Client does not support authentication protocol requested by server. Consider upgrading MariaDB client. plugin was = caching_sha2_password

Tests added in enterprise. Tests currently fail due to #616.


Update spec2 to 4.3.5

Bump specs2 to 4.3.4 (closes #91)
Remove DisjunctionMatchers (closes #100)

it seems that #95 got stale

Confirmed! @mzuehlke  has signed the Individual Contributor License Agreement. Thanks so much

can you rebase against develop to resolve the conflicts?

I rebased the PR against develop

As part of hacktoberfest, we have a raffle to win Snowplow t-shirts.
To enter the raffle you can fill out this form: https://docs.google.com/forms/d/e/1FAIpQLSeBbwQMWD9w9CEvjKt1KblDVpMy9mHOvQXS6YMRYH3geM8pCw/viewform


Update to TrackV20script

TrackV20Script.js was updated to remove spelling mistake and add material from other V20 books.
Is it possible remove the Turning Undead Script from this pull? Sorry I am new to Git and I am still busy completing the code for the Turn Undead script (AD&D 2nd)

Unfortunately not. You have to remove the changes from your fork and then submit a new pull request. Do you want me to sit on this until you've completed your changes for the AD&D script or close this one and let you try again?

Hi Steve please just close it and let me try again once I have completed TurnUndead script


Move jackson modules to toolbox from api-library

Create a new package for our jackson related stuff.. called izettle-jackson
Moved these modules from api-library to this package:

BigDecimalModule
InstantRFC3339Module
UUIDModule

👍

Great initiative, @MrShish. 👍 😄


make-kdf and the digest parameter

When using the PBKDF algorithms with make-kdf, I would expect digest to accept either a keyword symbol or a symbol from the ironclad package, as is the convention for numerous other functions (make-digest, make-cipher, make-mac, etc.). However, it seems to only accept symbols from the ironclad package.
The documentation for make-kdf should also be improved to explicitly mention what digest should be.

Commit 0055c420a87e99afcc9de52574866613bac9ad6c should fix this bug.
Thanks for the report.

I've created a PR that clarifies the documentation as well. :-) See #17.

Merged, thanks.


Update python and ansible, remove preview image

Description of the change:

Updates Ansible to 2.15.0
Limits dependencies we manage by only including in the Pipfile:

ansible-core
ansible-runner
ansible-runner-http
kubernetes
urllib3 (need to pin this to a version <2 due to some issues encountered when running the testdata/ansible/memcached-operator with these changes)

Updates Python to 3.9 (minimum supported by Ansible 2.15.0)
Removes the ansible-2.11-preview image
Updates the base.Dockerfile to use multi-stage builds where Rust is installed before installing necessary python packages so that any architecture that may be missing prebuilt wheels can have the wheels built during the image build process.

Motivation for the change:

Prevent users from using out of date and no longer supported ansible, python packages, and ansible collections

Checklist
If the pull request includes user-facing changes, extra documentation is required:

[ ] Add a new changelog fragment in changelog/fragments (see changelog/fragments/00-template.yaml)
[ ] Add or update relevant sections of the docs website in website/content/en/docs

I think a lot (if not all) of the changes to things outside the release/ansible folder will end being synced downstream with the next upstream SDK release (v1.31.0). To prevent sync issues due to divergence I think we should hold this PR until v1.31.0 is downstreamed and then rebase this PR against the master branch.
/hold

Yea I just noticed that this is changing 410 files. That seems like a lot :)_

/hold cancel

/retest

I'm a bit confused about the 391 changed files. Is this typical, or is a rebase required here?

I'm a bit confused about the 391 changed files. Is this typical, or is a rebase required here?

@leifmadsen I think this is typical since we updated some dependencies that are required to be vendored in. I don't think the vendoring will be necessary once the cachito stuff is in but if I understand correctly in the meantime we need to still vendor the new versions in.

/retest-required

/retest-required

/test unit


Feature Request: Generate Protocol for Generated Service Interface

Currently, generated service files have the following pattern:
@interface MyGeneratedService : NSObject

- (void)myRpcWithRequest1:(MyRpcRequest1 *)request
                  handler:(void(^)(MyRpcResponse1 *_Nullable response, NSError *_Nullable error))handler;

- (void)myRpcWithRequest2:(MyRpcRequest2 *)request
                  handler:(void(^)(MyRpcResponse2 *_Nullable response, NSError *_Nullable error))handler;

...

@end

These services work great, but they have the general issue that when we wish to provide an alternate implementation (such as for testing or proxying calls), our only choices are:
(1) Casting through id
(2) Subclassing
(3) Manually creating a category.
Each of these have demerits if the service definition ever changes, as the compiler will not catch various cases.
What would be really helpful is this:
@protocol MyGeneratedService

- (void)myRpcWithRequest1:(MyRpcRequest1 *)request
                  handler:(void(^)(MyRpcResponse1 *_Nullable response, NSError *_Nullable error))handler;

- (void)myRpcWithRequest2:(MyRpcRequest2 *)request
                  handler:(void(^)(MyRpcResponse2 *_Nullable response, NSError *_Nullable error))handler;

@end

@interface MyGeneratedService : NSObject<MyGeneratedService>

@end

This would allow our code to pass objects around as an id, and be guaranteed at compile time that the contract is fulfilled.

This feature is already implemented :)


Implemented credentials filter functionality

Type of change

Enhancement / new feature
Refactoring

Description
Implemented credentials filter functionality:

Create credentials type and value dropdown
Implement credentials filter functionality in mock-server
Write query and schema

Checklist

[ ] Update/write design documentation in ./documentation/design
[ ] Edit tests and make sure they pass
[ ] Resolve all warnings
[ ] Update license
[ ] Write test cases for null checks in Unit Tests
[ ] Reference relevant issue(s) and close them after merging

The mock server part looks good to me. Thanks !


Problem with Troubles Codes

I want to obtains troubles codes of my ELM327, i'm using your api for OBD, but this library doesnt want to  give me the errors, this said me command OBD failure, I try to charge the application obd reader of your repository and i have the same problem. I think the aplication fail in this part
                ModifiedTroubleCodesObdCommand tcoc = new ModifiedTroubleCodesObdCommand();
                tcoc.run(sock.getInputStream(), sock.getOutputStream());
                result = tcoc.getFormattedResult();

but i don't undertand because.

Need logs please.

05-21 00:12:34.363    6079-7238/pt.lighthouselabs.obd.obd2 W/System.err﹕ pt.lighthouselabs.obd.exceptions.UnableToConnectException: Error running 03, response: SEARCHING...
UNABLETOCONNECT
05-21 00:12:34.364    6079-7238/pt.lighthouselabs.obd.obd2 W/System.err﹕ at java.lang.Class.newInstanceImpl(Native Method)
05-21 00:12:34.364    6079-7238/pt.lighthouselabs.obd.obd2 W/System.err﹕ at java.lang.Class.newInstance(Class.java:1319)
05-21 00:12:34.367    6079-7238/pt.lighthouselabs.obd.obd2 W/System.err﹕ at pt.lighthouselabs.obd.commands.ObdCommand.checkForErrors(ObdCommand.java:211)
05-21 00:12:34.367    6079-7238/pt.lighthouselabs.obd.obd2 W/System.err﹕ at pt.lighthouselabs.obd.commands.ObdCommand.readResult(ObdCommand.java:140)
05-21 00:12:34.367    6079-7238/pt.lighthouselabs.obd.obd2 W/System.err﹕ at pt.lighthouselabs.obd.commands.ObdCommand.run(ObdCommand.java:87)
05-21 00:12:34.367    6079-7238/pt.lighthouselabs.obd.obd2 W/System.err﹕ at pt.lighthouselabs.obd.obd2.TroubleCodes$GetTroubleCodesTask.doInBackground(TroubleCodes.java:210)
05-21 00:12:34.368    6079-7238/pt.lighthouselabs.obd.obd2 W/System.err﹕ at pt.lighthouselabs.obd.obd2.TroubleCodes$GetTroubleCodesTask.doInBackground(TroubleCodes.java:132)
05-21 00:12:34.368    6079-7238/pt.lighthouselabs.obd.obd2 W/System.err﹕ at android.os.AsyncTask$2.call(AsyncTask.java:287)
05-21 00:12:34.368    6079-7238/pt.lighthouselabs.obd.obd2 W/System.err﹕ at java.util.concurrent.FutureTask.run(FutureTask.java:234)
05-21 00:12:34.369    6079-7238/pt.lighthouselabs.obd.obd2 W/System.err﹕ at android.os.AsyncTask$SerialExecutor$1.run(AsyncTask.java:230)
05-21 00:12:34.370    6079-7238/pt.lighthouselabs.obd.obd2 W/System.err﹕ at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1080)
05-21 00:12:34.370    6079-7238/pt.lighthouselabs.obd.obd2 W/System.err﹕ at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:573)
05-21 00:12:34.371    6079-7238/pt.lighthouselabs.obd.obd2 W/System.err﹕ at java.lang.Thread.run(Thread.java:838)

You are not connected.

ELM321 is connected, this occure in your application android-obd-rearder too.

pt.lighthouselabs.obd.exceptions.UnableToConnectException: Error running 03, response: SEARCHING...UNABLETOCONNECT

This response comes from the ELM327 device.

i think @pires means that the  ELM327 is unable to connect to the car? e.g. the car is not responding because it is not running/powered  or the appropriate init and reset commands haven't been issued

Exactly! Thank you @nomwerp

ah!!! okay thanks!! should i change ELM 327 by other??

did you try it with the engine running?

he said me no data when i try to engine running

sorry, it's send me a lot of informar ion with engine running


Create callback returns 403 when promise already completed

Resolves #500

I totally forgot we do this so that any process creating a callback can just continue when the promise complete, duh! Will close this PR.
I discovered this "issue" when using the new callback cli. Let's just log a different message indicating "the promise is already completed" in this case.


fix: 修复柱状图区间及零点问题

👀 PR includes

✨ Feature

[x] 增加柱状图支持正负值区分的能力，and close #1324

🎨 Enhance

[ ] Code style optimization
[ ] Refactoring
[ ] Change the UI
[ ] Improve the performance
[ ] Type optimization

🐛 Bugfix

[x] 修复以前柱状图零点计算问题

🔧 Chore

[ ] Test case
[ ] Docs / demos update
[ ] CI / workflow
[ ] Release version
[ ] Other ()

📝 Description
以前的柱状图就支持区分正负的行为，但是以前的0点计算有问题，所以对已经所支持的以下三种行为进行区间和零点的修正
区间范围有正有负：

区间范围均为正：

区间范围均为负：

🔗 Related issue link

🔍 Self-Check before merge

[ ] Add or update relevant docs.
[ ] Add or update relevant demos.
[ ] Add or update test case.
[ ] Add or update relevant TypeScript definitions.

:tada: This PR is included in version @antv/s2-v1.22.0-alpha.1 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version @antv/s2-v1.22.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


[grpc] [arm-linux] Missing grpc plugins.

Enable grpc plugins for arm/arm64 build.
Describe the pull request

What does your PR fix? Fixes #
Enable grpc plugins for arm/arm64 build.

Which triplets are supported/not supported? Have you updated the CI baseline?
arm-linux/arm64-linux

Does your PR follow the maintainer guide?
Yes

hmm, seems grpc plugin can't be built for arm windows. That may be the reason why it is disabled in the past. Let me only enable for linux.

Thanks!


request for new icons

Feature request
Request you to add following icons:

Language (for i18n)
Accessibility
Scatter chart
Gauge chart
Dashboard
Heat map
Credit cards (specific for popular brands like Amex, visa and master )
For Maps:

Transportation types (cycle/bike, motor bike, walking, cab, car, rail, flight and bus)
Traffic light, traffic cone, tow-away, speed limit (20, 40, 60, 80) and other traffic signs
First responder (medical, fire, police).
Buildings (government, residential, hotel, individual house, apartment etc.)
Parking, parks, camping, tourist attraction, museum etc.
Routing

Unlink (complement icon for link icon which exists)

Social Media:

Instagram

Youtube

Snapchat

Dribbble

Xing

would be nice too!

Currency-Icons:

Euro

Dollar

Yen

Pounds

Locked folder
Opened folder
Tree view

Dollar sign please

Social Media:

Instagram
Youtube
Snapchat
Dribbble
Xing

would be nice too!

Telegram


discoverServices is broken

@pauldemarco
It seems like there is a long list of dicoverService() problems. I think the consent is that this needs at least a statement where you are with this and when these long-standing issues are fixed.
These are all open defects where many people desperately waiting for a solution or at least some shared thoughts. Any help or input on this would be great.
Maybe you could help us to understand when this method should be save to call. Commenting the method may be already enough to circumvent most of the questions people have. Also, regression/integration tests would be great to avoid reoccurring problems.
#509 #495 #426 #342 #276 #225

DiscoverServices should be called right after connecting to the device, typically in the BluetoothDeviceState handler after receiving the connected state.
I'm merging in some code to return an Exception when attempting this call on a device that's not connected.

@pauldemarco
Wouldn't it be better to be able to make this available before you connect to a device? Say if someone want to filter out a list of only approved device types for example.
Thanks!

@pauldemarco
Wouldn't it be better to be able to make this available before you connect to a device? Say if someone want to filter out a list of only approved device types for example.
Thanks!

That should be in AdvertismentData for you. If you are interested for other services (not advertised) you need to connect. Which makes the whole filter pointless as a connect/disconnect is costly.
So you can rely on these items within AdvertisementData:

localName
manufacturerData (if any)
serviceUUIDs

If your device matches then you can interrogate it which need a connection AFAK. Correct me if I am wrong.

discoverServices crashes my app without any error message. All i get is Lost connection to device. Exited (sigterm)

@pauldemarco discoverServices issue mentioned in that #535 issue is reproduced on your example app as well (https://github.com/pauldemarco/flutter_blue/tree/master/example)
I'm using Android 9 (Pie)
The steps:

start "flutter_blue_example"
scan for bt devices
connect to a bt device - "BT device 001"
hit "Back" 2 times to exit from app (app still running)
go back to "flutter_blue_example"  - "BT device 001" is displayed as connected - hit Open
hit "Refresh: icon (right to "Device is connected" text) - that code forces "device.discoverServices();" calling
the exception occurs:

E/flutter (21021): [ERROR:flutter/lib/ui/ui_dart_state.cc(177)] Unhandled Exception: PlatformException(discover_services_error, no instance of BluetoothGatt, have you connected first?, java.lang.Exception: no instance of BluetoothGatt, have you connected first?
E/flutter (21021): 	at com.pauldemarco.flutter_blue.FlutterBluePlugin.locateGatt(FlutterBluePlugin.java:660)
E/flutter (21021): 	at com.pauldemarco.flutter_blue.FlutterBluePlugin.onMethodCall(FlutterBluePlugin.java:354)
E/flutter (21021): 	at io.flutter.plugin.common.MethodChannel$IncomingMethodCallHandler.onMessage(MethodChannel.java:233)
E/flutter (21021): 	at io.flutter.embedding.engine.dart.DartMessenger.handleMessageFromDart(DartMessenger.java:85)
E/flutter (21021): 	at io.flutter.embedding.engine.FlutterJNI.handlePlatformMessage(FlutterJNI.java:692)
E/flutter (21021): 	at android.os.MessageQueue.nativePollOnce(Native Method)
E/flutter (21021): 	at android.os.MessageQueue.next(MessageQueue.java:326)
E/flutter (21021): 	at android.os.Looper.loop(Looper.java:181)
E/flutter (21021): 	at android.app.ActivityThread.main(ActivityThread.java:7073)
E/flutter (21021): 	at java.lang.reflect.Method.invoke(Native Method)
E/flutter (21021): 	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:493)
E/flutter (21021): 	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:964)

I will really appreciate if you could provide us with some ideas how to fix / workaround this.
Thanks!


Make newsletter signup more prominent.

The newsletter signup is hidden away.
Suggestions: try it above the fold, put it in the menu, link it in the footer.

Good point for possible tweak now, and certainly for upcoming redesign.


Start karma, run tests, close.

What is the proper way of starting karma, running the tests and closing it? Since this boilerplate uses PhantomJS, there is no point in keeping the instance open, as everything is automated. Some people may want this, but I don't. I'd rather use a switch or something to let it live on purpose.
Any idea?

--run-once was found on StackOverflow. That is resolved now :)


Fix bug that allowed the y-axis labels to overflow the plot vertically

Fixes https://github.com/VEuPathDB/web-components/issues/265

Just a reminder that we'll need to do an EDA components upgrade at some point. Could be done at the same time as faceting-title-and-empty-data perhaps.


Update UG branch by Qiyuan

Update the introduction part and features part in UserGuide.

Codecov Report

Merging #39 (a723ed5) into master (595fca5) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #39   +/-   ##
=========================================
  Coverage     72.15%   72.15%
  Complexity      399      399
=========================================
  Files            70       70
  Lines          1232     1232
  Branches        125      125
=========================================
  Hits            889      889
  Misses          311      311
  Partials         32       32

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 595fca5...a723ed5. Read the comment docs.


HIVE-23843: Improve key evictions in VectorGroupByOperator

https://issues.apache.org/jira/browse/HIVE-23843
TestVectorGroupByOperator has been modified to run with and without hive.vectorized.groupby.agg.enable.lrucache.

Observed good improvement in Q67.

Simplified and revised the patch. Q67 @ 10 TB scale shows good improvement (2050+ seconds --> 1500+ seconds) in internal cluster.


Add Server Stats

show disk usage
ram ussage
cpu usage
used raids
add external server?

This will be done in stackvitals


[Errno 111] Connection refused when signing a transaction

A reproducible test case or series of steps

I followed all the steps outlined in the part 2 of the blog post to deploy the whole stack using CDK. It threw the following error when I tried to sign an Ethereum transaction via the Lambda console.

{
  "errorMessage": "exception happened sending decryption request to Nitro Enclave: [Errno 111] Connection refused",
  "errorType": "Exception",
  "stackTrace": [
  "  File \"/var/task/lambda_function.py\", line 123, in lambda_handler\n    raise Exception(\"exception happened sending decryption request to Nitro Enclave: {}\".format(e))\n"
  ]
}

The transaction payload I used was the same as given in the example, e.g.

  {
    "operation": "sign_transaction",
    "transaction_payload": {
      "value": 0.0001,
      "to": "0xa5D3241A1591061F2a4bB69CA0215F66520E67cf",
      "nonce": 0,
      "type": 2,
      "chainId": 4,
      "gas": 100000,
      "maxFeePerGas":<PHONE_NUMBER>00,
      "maxPriorityFeePerGas":<PHONE_NUMBER>
    }
  }

The version of our code being used

Commit 1fa0d541af348f49fc6533e05232ac64b9991f93

Any modifications you've made relevant to the bug

N/A

Anything unusual about your environment or deployment

I noticed health checks failed on both of my EC2 instances, but those instances were still running and I could connect to them using a session manager.

Hi @0xYao ,
thanks for sharing this issue.
Is this issue related to #5 or #6  or did it happen in an unrelated deployment? Did the EC2 or load balancer health checks fail? Which region did you deploy the stack into?
Cheers,
David

Hi @0xYao , thanks for sharing this issue. Is this issue related to #5 or #6 or did it happen in an unrelated deployment? Did the EC2 or load balancer health checks fail? Which region did you deploy the stack into?
Cheers, David

I had to fix both #5 and #6 first to successfully deploy. The load balancer health checks failed and I deployed the stack into us-east-1.

Hi @0xYao, the load balancer health checks would just fail if the http_server docker container is not running on the EC2 instance. Can you please confirm that the docker container is up and running.
Just to make sure that I understand you correctly, you fixed the local build issue first (#6), executed the binary build step (./scripts/build_kmstool_enclave_cli.sh) and executed a cdk deploy with default settings to us-east-1?

Hi, I've seen this same issue.

A reproducible test case or series of steps

Part 2 of the blog post, setting post setting up the instances in cdk. The nitro-enclaves appear to come up but are in some odd state. describe-enclaves returns a null set despite the enclaves are up and running.
Evidence:

sh-4.2$ sudo su
[root@ip-10-0-195-156 bin]# nitro-cli describe-enclaves
[]
[root@ip-10-0-195-156 bin]# ps -ef | grep nitro-cli
root     13721 13712  0 10:49 ?        00:00:00 /bin/nitro-cli run-enclave --cpu-count 2 --memory 3806 --eif-path /home/ec2-user/app/server/signing_server.eif --enclave-cid 16
root     13730 13721  0 10:49 ?        00:00:00 [nitro-cli] <defunct>
root     13733     1 16 10:49 ?        00:00:09 /bin/nitro-cli run-enclave --cpu-count 2 --memory 3806 --eif-path /home/ec2-user/app/server/signing_server.eif --enclave-cid 16
root     13961 13753  0 10:50 pts/0    00:00:00 grep --color=auto nitro-cli
[root@ip-10-0-195-156 bin]#

Additionally the health checks are failing for the target groups. This appears related to the closed issues #4  and  #5.

The version of our code being used

7f96f2f0a7d2b5598fc474558bb614bccce33894

Any modifications you've made relevant to the bug

N/A

Anything unusual about your environment or deployment

Running everything in us-east-2


get Pair Extraordinaire?

I have coauthored commits on merged pull requests before.
But I didn't receive badge.
How can I fix that?

Hello, there!
You have to do this way.
1.create a branch and commit changes
2.get a collaborator to commit changes on the same branch
3.create a pull request
4.merge to default branch using squash and merge
If you have done this way before, plz check you merged using 'squash and merge'
Best Regards.

I have done this before using squash and merge

Well, if you have done this before, plz try again one more time.


What is the difference between onResult and onDecode?

Thanks for the awesome library! I am using it atm and saw that there is a onDecode and onResult. I was wondering what the difference between the two is. Thanks!

Both of them return the result.
onResult: Scan event handler for result object.
onDecode: Scan event handler for decode value.
The difference is that onDecode will return the QrCode value as a text and onResult will return more data.


"X" icon does not look good - Infowindow

Under which browser? I guess there was any zoom level applied because it is properly styled right now:
Chrome:

Firefox:


Remove EliminateAggDistinct optimizer rule, implement distinct aggs in Python

This PR attempts to remove the EliminateAggDistinct optimizer rule and instead handle distinct aggregations directly from the Python aggregate plugin using drop_duplicates.
This ideally should unblock the groupby related failures cropping up in #998 and resolve the existing groupby agg failures that we had seen in test_compatibility.py.

Codecov Report

Merging #1006 (ce1c13d) into main (7da66be) will increase coverage by 0.13%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1006      +/-   ##
==========================================
+ Coverage   80.47%   80.61%   +0.13%
==========================================
  Files          75       75
  Lines        4231     4235       +4
  Branches      765      767       +2
==========================================
+ Hits         3405     3414       +9
+ Misses        662      653       -9
- Partials      164      168       +4

Impacted Files
Coverage Δ

dask_sql/physical/rel/logical/aggregate.py
91.30% <100.00%> (+0.19%)
:arrow_up:

dask_sql/_version.py
35.31% <0.00%> (+1.41%)
:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Fix Ruby 2.7 keyword parameter deprecations

This fixes warning: Using the last argument as keyword parameters is deprecated; maybe ** should be added to the call and warning: Passing the keyword argument as the last hash parameter is deprecated when using Ruby 2.7 (see https://www.ruby-lang.org/en/news/2019/12/12/separation-of-positional-and-keyword-arguments-in-ruby-3-0/)

Coverage remained the same at 97.268% when pulling 1ed3af7d3e531cf383da18ec4f05002da5fc972f on jzzocc:master into 90cbf145cee9add1a0f86b268ac54b31a18002fa on igrigorik:master.

Coverage remained the same at 97.268% when pulling 1ed3af7d3e531cf383da18ec4f05002da5fc972f on jzzocc:master into 90cbf145cee9add1a0f86b268ac54b31a18002fa on igrigorik:master.


angularfire2

get error in angularfire2

@Bansi23 it seems to me that you have something wrong with your node_modules, have you properly ran npm install firebase @angular/fire --save or yarn add @angular/fire?

it solved it thanks I removed node module after I installed npm it's perfect working.

@Bansi23 glad to hear
please close this issue then


add KVASS

The description on the repo says:

if you vessel name isn't started with the Simulation pattern, then you need "to plan" your vessel before a launch. For the planning time management Kerbal Alarm Clock is used.

Should KAC be a dependency? It sounds like it's needed for this mod to work.

There is an option to disable a planning time and to leave only the simulation, so I don't want to make KAC a dependency on a CKAN, but I mixed up recommends and suggests: it should enable the KAC by default, so be "recommends"

Thanks for the submission! Merging...


Modify start-console.sh to replace previous env.list.

This allows environmental variables to be updated when the console starts.

/retest-required

/retest-required


function name in base color in Clojure

The function name after defn also after def.. is white. How can I change it?

Find out what your syntax file tags the name as, then add it with your desired color here:
https://github.com/sjl/badwolf/blob/master/colors/badwolf.vim#L433
Unfortunately it looks like the Clojure syntax file just tags this as clojureSymbol like all other normal symbols, so changing it would also change every other symbol.  If you want to highlight the function names differently you'll need to edit the syntax file to recognize them first.


DaemonSet can succeed before rollout finishes

Bug report
We've seen DaemonSet deploy succeed when the DS was actually only partially rolled out.
Our current success check looks like this:
    def deploy_succeeded?
      return false unless exists?
      rollout_data["desiredNumberScheduled"].to_i == rollout_data["currentNumberScheduled"].to_i &&
      rollout_data["desiredNumberScheduled"].to_i == rollout_data["numberReady"].to_i &&
      current_generation == observed_generation
    end

A you can see, it isn't looking at updatedNumberScheduled, so it will succeed the first time during the rollout that full availability is (temporarily) reached. Since DS can be configured to roll out in batches, this state can happen multiple times in the middle of the rollout.
@dturn @klautcomputing @mkobetic

Ironically, fixing this bug will probably make the short term cluster-services pain worse, but that needs to be fixed elsewhere.


neon-sso-session-proxy container image is very large: 249MB

The neon-sso-session-proxy is 249MB which seems way too big:

We should also verify that other container images for our services are not unreasonably large.

This is due to the ASP.NET base docker images being large:

I'm not sure that we can do anything about this besides ensuring that all of our sites all reference the same base image.

CLOSED: Nothing we can do.


Fix security-scan failures which are occurring after kube-bench and Go version upgrade.

Related issue: https://github.com/rancher/cis-operator/issues/142
Related PR: https://github.com/rancher/security-scan/pull/85

Validation Steps:

Deploy a Rancher Server
Create a 4 downstream cluster of following configurations for each rke1, rke2 and k3s:

Single node non-hardened cluster
Single node hardened cluster
Multi node non-hardened cluster (Each node with distinct roles i.e 1 cp, 1 etcd, 1 worker)
Multi node hardened cluster (Each node with distinct roles i.e 1 cp, 1 etcd, 1 worker)

Install rancher-cis-benchmark:v2.0.5-rc4 in each of the cluster with security-scan v0.2.8-rc3
Run CIS scans of all the profiles (1.6 1.20 1.23 permissive and hardened) and observe the results.

Expected Result:
All scans should pass

Validated the security scans on rancher server v2.6.7-rc3 for rke, rke2 and k3s.
Validations steps.

Created a rancher server v2.6.7-rc3.
Created following hardened downstream clusters.

RKE (Singlenode all role and multinode [1cp, 3worker, 3 etcd]
RKE2 (Singlenode all role and multinode [1cp, 3 worker, 3 etcd]
k3s (singlenode all role and multinode [1cp, 3 worker, 3 etcd]

Install a rancher-cis-benchmark:v2.0.5-rc4 in each of the cluster with security-scan v0.2.8-rc3.
Ran CIS scans of all the following cluster specific hardened profiles.

profile-hardened-1.6
profile-hardened-1.20
profile-hardened-1.23

Result: All the scans passed successfully.
Scan results.
RKE singlenode.

RKE Multinode.

RKE2 Singlenode.

RKE2 Multinode.

On rancher v2.6.7-rc3, created a downstream hardened k3s v1.23.9+k3s1 cluster and ran the permissive and hardened profile scans. All passed successfully:

Based on above validations, closing the issue.


fonts not found on android device

the suffix / make some android devices doesn't work properly

Thanks for spotting and fixing this!


suggested PR

Description

Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.

This checklist is used to make sure that common guidelines for a pull request are followed.

[ ] The PR title and description has followed the guideline in Submitting Pull Requests.

[ ] I adhere to the Command Guidelines.

[ ] I adhere to the Error Handling Guidelines.

doc

spam

Not spam

Please provide more detail and context about the PR.


windwos ros2-eloquent-debug  std::regex re(regex) running error

Hi, I am using ros2-eloquent-debug in windows, using visual studio 2015,
and I am building image_common package from https://github.com/ros-perception/image_common ,  and when I run list_transport project of image_common package, it failed when running list_transports.exe
So, I debug and find the reason is from pluginlib package from https://github.com/ros/pluginlib  ,there is a syntax error about std::regex re(regex); in split.hpp from C:\dev\ros2-eloquent-debug\include\pluginlib\impl\split.hpp 45 line, and the parameter regex of std::regex re(regex) will become "\\" in windows system, because C:\dev\ros2-eloquent-debug\include\pluginlib\impl\filesystem_helper.hpp already define #define CLASS_LOADER_IMPL_OS_DIRSEP '\\'
so std::regex re("\\") will fail when running project. It is running error, I already test in vs2015, vs2017, vs2019, they all run error  std::regex re("\\")
Because give me some advice, thanks,
jack

ROS 2 Eloquent officially only supports Visual Studio 2019 (see https://index.ros.org/doc/ros2/Releases/Release-Eloquent-Elusor/).
The C++ compiler in VS 2015 might just be too old to understand the used syntax. Therefore I will go ahead and close this ticket.

Reopening - I missed that you are describing a runtime error in the regex and that you see the same problem with VS 2019.

I try run the same project list_transports.exe in ros2-dashing-debug of
windows, finally, it also run error.
And also I debug, find problem is same, because of std::regex re("\"),
If you have some solution, please give me some advice
Thanks
, jack
Dirk Thomas<EMAIL_ADDRESS>于2019年12月5日周四 上午12:39写道：

Reopening - I missed that you are describing a runtime error in the regex
and that you see the same problem with VS 2019.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/ros/pluginlib/issues/170?email_source=notifications&email_token=AKSXUHNSOZATNKONP2UT5JTQW7MLTA5CNFSM4JVI7SB2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEF5UQYI#issuecomment-561727585,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKSXUHJLFQWFQ6GCKR2SBE3QW7MLTANCNFSM4JVI7SBQ
.


XSD datatype version mismatch

Describe the bug
The specified data types for the AAS of XSD Datatype Version 1.0 and the RDF data types (e.g. rdf:Langstring) of XSD Datatype Version 1.1 do not match.
RDF uses the referenced RDF 1.1 and therefore the XSD Datatypes version 1.1.
The datatypes defined for RDF 1.1 is https://www.w3.org/TR/rdf11-concepts/#xsd-datatypes and references the XSD Version 1.1 https://www.w3.org/TR/xmlschema11-2/#built-in-primitive-datatypes instead of the AAS Datatypes uses XSD Version 1.0 https://www.w3.org/TR/xmlschema-2/#built-in-primitive-datatypes
Where
Specification of Primitive and Simple Data Types in Version 3.0, 3.0.1 and 3.1
Screenshots

Additional context
No matter in which version RDF uses the XSD data types version 1.1

So far the only datatype Part 1 is using from RDF is langString, all other types from RDF are not used in the metamodel.
So from metamodel point of view we need to have a look at string and AASd-130. If the string definition in XML Schema 1.0 and 1.1 differs then we need to decide whether MultiLanguageProperties have a different string constraint than "normal" Properties with type xs:string.
The impact on the serialization formats, especially RDF is not clear to me.

RDF 1.1 references XML Schema Part 2 - Datatypes Version 1.1, indeed.
However, this has no effect on the AAS RDF serialisation, and is completely unrelated to the decision that AAS relies on XML Schema version 1.0. The AAS RDF serialisation only uses the native RDF datatypes xs:string, xs:boolean, and xs:base64byte, which are already in XML Schema Part 2 - Datatypes Version 1.0

So I think we face a pretty complex situation but have a pretty easy solution: Current state is fine, no changes needed :-).

2024-06-13 Workstream AAS Specs
accepted, we stay with XML Schema 1.0 data types although RDF is using XML Schema 1.1 data types.

solved in IDTA-01001-3-0-1: https://industrialdigitaltwin.org/wp-content/uploads/2024/06/IDTA-01001-3-0-1_SpecificationAssetAdministrationShell_Part1_Metamodel.pdf


OTA out of sync with jobs and not unsubscribing from all topics on failures

Describe the bug
OTA library entered state where it was out of sync with the OTA service. The device would immediately reject a new job as it believed it was associated to a previous job that didn't exist or wasn't active any longer.

179776 347670946 [OTA Task] [prvParseJobDoc] Busy with existing job. Ignoring.
179777 347670946 [OTA Task] [prvParseJobDoc] Error 1 parsing job document.
179778 347670946 [OTA Task] [prvParseJobDoc] Rejecting job due to OTA_JobParseErr_t 1
179796 347671098 [OTA Task] [prvOTA_Close] Context->0x005599a4

Additionally, after trying several times i received a subscription manager full error from the mqtt library.

179951 347887000 [OTA Task] [prvParseJobDoc] Job was accepted. Attempting to start transfer.
179952 347887000 [OTA Task] [OTA]	cnewImageStatus = 0
179953 347887092 [OTA Task] [prvPAL_GetPlatformImageState]	currentImageStatus = 0
179954 347887092 [OTA Task] Sending command to MQTT task.
179955 347887092 [MQTT] Received message 16fa0000from queue.
179956 347887092 [MQTT] Initiating MQTT subscribe.
179957 347887093 [MQTT] WARN: Subscription Manager full! No space left to store new subscriptions.
179958 347887093 [MQTT] MQTT_Subscribe failed!

Issues:
Seems like there are no timeouts for the OTA transfer and it is possible to enter some state where the subscriptions are not completely purged from the mqtt agent. Seems that the datastream subscription string is the most likely candidate as this string is unique per job/file chunk.
System information
Amazon FreeRTOS OTA Agent V1.0.0
Amazon FreeRTOS release 1.4.6
Custom platform - Cypress CYW43907
To reproduce

So far I am unable to develop a chain of events to reproduce this issue. I encountered this problem on two devices out of a pool of 100 performing updates.

Hi mckendree, I will add the other two issues #279 and #280 here, as they both stem out of the issue of OTA library being out of sync. Closing the other two issues.

@mradulan, sure no problem. I was trying to keep the issue separated from feature request.

Ran into this again.
The CYW43907 platform and low level WICED libraries always expect the first block to be received is a header in the first 4k of the image. Due to network traffic or what ever, on some devices this will tend to arrive at a later time resulting in an ota failure. I understand the OTA library doesn't care what order blocks are received in and I am fine with that... non issue.
After attempting ota about 6 times i ran into the subscription manager error again, this time i printed the subscriptions that were already allocated to the manager.

1549481350961,$aws/things/CC_C0_79_DF_56_D2/jobs/$next/get/accepted
1549481350961,$aws/things/CC_C0_79_DF_56_D2/jobs/notify-next
1549481350961,$aws/things/CC_C0_79_DF_56_D2/streams/AFR_OTA-cbc84b74-81db-482e-91c9-bef3bc1485fa/
1549481350962,$aws/things/CC_C0_79_DF_56_D2/streams/AFR_OTA-e3722a3a-dd8b-492a-82d5-25eb07165677/
1549481350962,$aws/things/CC_C0_79_DF_56_D2/streams/AFR_OTA-792e2603-8fd8-4314-b430-9a56a2427ca8/
1549481350962,$aws/things/CC_C0_79_DF_56_D2/streams/AFR_OTA-6ca38016-142f-4e67-8dbc-c5858f4c4be9/
1549481350962,$aws/things/CC_C0_79_DF_56_D2/streams/AFR_OTA-79270fea-cd35-4ff8-8d82-f622ad945151/
1549481350962,$aws/things/CC_C0_79_DF_56_D2/streams/AFR_OTA-f11e2369-d76d-4752-9fea-2f152ffbd5b5/

This clearly points to stream subscriptions being stuck in the manager with no way to remove them unless the unit either drops the mqtt connection (guessing this will clear the manager but not sure), or reset the board.
Thoughts?

yes it looks like the mqtt subscription manager should remove the jobs which are not active currently. We are debugging the code to why it is behaving incorrectly.

After looking at the chain of events in my serial log, I can see when there are error conditions in the OTA library, the Unsubscribe feature may fail. There are no retries in the OTA library so the topic becomes stuck in the subscription manager.

In aws_ota_agent.c,
I added retry loop to all subscribe, publish, and unsubscribe attempts (max 5 attempts), with a random 1s - 2s delay between attempts. This seems to resolve the issue.
It looks like the biggest issue relates to the failure to the publish the "FAILURE" status message, so the server keeps pumping blocks of data out. By adding the publish retry, the server eventually processes the publish message and responds with a PUBACK and then the unsubscribe works.
I can replicate this by modifying my prvPAL_WriteBlock to fail after some number of bytes written, like 12K while sending a file a order of magnitude larger, like 512K.
logCapture.txt

Thank you for the detailed report on how to reproduce this issue! We will look more closely at what happens when the prvPAL_WriteBlock method fails partway through an update as we continue to investigate.

We have figured out the root cause and are working on the fix. But no ETA so far.

Hi nmckendree,
Do you still have observe this issue when doing OTA ? Which Amazon FreeRTOS release are you currently using ?

Thanks for reporting the bug. We are still actively working on this and will merge the fix to master in coming releases.


Pronouns function

Description
Pronouns is becoming a common field for user profiles
Proposed solution
Use rand() to select from the JSON list of most common pronouns.
(I have a branch for this ready to go if this feature is wanted)
Alternatives considered
No response
Do you want to create a pull request?
Yes

Sounds good


error with navigationOptions title

the i18n work in all my app (android &ios)
I use redux and AsyncStorage to store the choosen langage by user to don't ask it each time.
Today is see that i forget to translate my StackNavigator navigationOptions title.
but it don't work for me. the StackNavigator's titles stays in the default langage  (french as my phone)
How to solve this please ?
/i18n/i18n.js
import I18n from "react-native-i18n";

I18n.fallbacks = true;
I18n.translations = {
  "en": require("./en.json"),
  "en-EN": require("./en.json"),
  "fr": require("./fr.json"),
  "fr-FR": require("./fr.json"),

};
export default I18n;

/settingPage.js
import I18n from '../i18n/i18n';
class SettingPage extends Component {

  static navigationOptions = {
	title: I18n.t("SettingPage.Settings"),               // it stay in french whatever choosen langage
	tabBarLabel: I18n.t("SettingPage.Settings"),
	tabBarIcon: ({ tintColor }) => <Icon name="cog" size={20} color="#fff" />
  };

  constructor(props) {
	super(props);		...
  }

  render() {
	return (
	  <View  >
		<Text>{I18n.t("SettingPage.Settings")}</Text>     // it is translated on real time
		 ....
	  </View>
	);
  }

/App.s :
 // my apps.s is very big, i use a StackNavigator and a TabNavigator, so i remove some parts
import I18n from './i18n/i18n';

const MyTabView = TabNavigator(
  {
	NvObs: { screen: NouvelleObservation },
	...
	Options: { screen: Optionpage }
  },
  { ...  }
);

class MyGlobalComponent extends Component {
  constructor(props) {
	super(props);
  }

  goToCamera = () => { this.props.navigation.navigate("NvObs"); };

  render() {
	return (
	  <View style={{ flex: 1 }}>
		<MyTabView
		  navigation={this.props.navigation}
		  screenProps={{ navigation: this.props.navigation }}
		/>

		<ActionButton  > ... </ActionButton>
	  </View>
	);
  }
}

MyGlobalComponent.router = MyTabView.router;

const StackView = StackNavigator({
  global: { screen: MyGlobalComponent},
  NvObs: { screen: NouvelleObservation },

  profile: { screen: ProfilePage },      // the title of this stacknavigator is not translated
  setting: { screen: SettingPage },      // the title of this stacknavigator is not translated
  dons: { screen: DonsPage },            // the title of this stacknavigator is not translated
  othersoft: { screen: OthersoftPage },  // the title of this stacknavigator is not translated
  login: { screen: LoginPage }           // the title of this stacknavigator is not translated
});

import * as actions from "./redux/actions";

export default class App extends Component {
  constructor(props) {
	super(props);
	this.state = { ...store.getState() };
	I18n.locale = store.getState().language ;
	this.unsubscribe = store.subscribe(() => {
	  const storestate = store.getState();
	  if(storestate.language!=null){
		I18n.locale = storestate.language ;
	  }
	});
  }
  render() {
	return (
	  <Provider store={store}>
		<View style={{ flex: 1 }}>
		  <StackView />
		</View>
	  </Provider>
	);
  }
}

Because all the static properties are executed before your store subscription function is set the locale from the store. The navigationOptions have to be lazy to work.
Change all static navigationOptions to lazy functions.
Before:
  static navigationOptions = {
	title: I18n.t("SettingPage.Settings"),               // it stay in french whatever choosen langage
	tabBarLabel: I18n.t("SettingPage.Settings"),
	tabBarIcon: ({ tintColor }) => <Icon name="cog" size={20} color="#fff" />
  };

After:
  static navigationOptions = () => ({
	title: I18n.t("SettingPage.Settings"),               // it stay in french whatever choosen langage
	tabBarLabel: I18n.t("SettingPage.Settings"),
	tabBarIcon: ({ tintColor }) => <Icon name="cog" size={20} color="#fff" />
  });

Also, if you don't need the device language, you can just use i18n-js directly.

@patlux not working for me...
// header navigation options
static navigationOptions = () => ({
title: I18n.t('settings'),
headerStyle: {
backgroundColor: '#4285f4',
},
headerTitleStyle: {
color: 'white'
}
});

@patlux It's not working for me.

not working for me as well

Because all the static properties are executed before your store subscription function is set the locale from the store. The navigationOptions have to be lazy to work.
Change all static navigationOptions to lazy functions.
Before:
  static navigationOptions = {
	title: I18n.t("SettingPage.Settings"),               // it stay in french whatever choosen langage
	tabBarLabel: I18n.t("SettingPage.Settings"),
	tabBarIcon: ({ tintColor }) => <Icon name="cog" size={20} color="#fff" />
  };

After:
  static navigationOptions = () => ({
	title: I18n.t("SettingPage.Settings"),               // it stay in french whatever choosen langage
	tabBarLabel: I18n.t("SettingPage.Settings"),
	tabBarIcon: ({ tintColor }) => <Icon name="cog" size={20} color="#fff" />
  });

With this change, all static navigationOptions are executed when the screen is entered.

You made my day Bro.. Excellent solution.

Solution above won't doesn't work in react-native for me. Ended up doing:
import React from "react";
import {Text} from "react-native";
import {useTranslation} from "react-i18next";

export const NavigationLabel = ({path}) => {
  const {t} = useTranslation();
  return <Text>{t(path)}</Text>;
};

static navigationOptions = () => ({
    title: <NavigationLabel path="Home" />
});

https://stackoverflow.com/questions/53484087/react-native-react-i18next-react-navigation-navigationoptions-update-issue


 Fix in https://github.com/kubernetes/kubernetes/pull/65609.

Fixed in https://github.com/kubernetes/kubernetes/pull/65609, thanks to @CaoShuFeng! :)
/close


Handling default attribute values

For XML with XSD-specified default values (like this), I'd like the option to tell cxml to fill in the defaults in the parsed JSON output. Right now, if the attribute is not specified in the XML, it won't appear in the JSON output, even if the XSD specifies a default value.
Any suggestions on where to refactor cxml (and maybe cxsd) to implement this?

There's big changes coming to cget / cxml / cxsd and I see you've been working on adding xpath support, which is very useful for the future. Maybe it we could collaborate in Gitter? I set up a room https://gitter.im/charto/cxml for this project.


Correction for raw affiliation Aeres University of Applied Sciences, Dronten, the Netherlands

Correction needed for raw affiliation Aeres University of Applied Sciences, Dronten, the Netherlands
raw_affiliation_name: Aeres University of Applied Sciences, Dronten, the Netherlands
new_rors: 03jnx2c74
previous_rors: 015d5s513
works_examples: W4389375968
contact: 55ec34dd4e7f8a6d32eabf981212f567:3a1a5bd1fe506df791ca @ hotmail.com

This issue was accepted and ingested by the OpenAlex team on 2024-10-10. The new affiliations should be visible within the next 7 days.


Parse TextSymbolizer template

Important: Please wait with merging this PR until

[x] this PR from geostyler-style
was merged.

With this PR it is possible to parse templates for TextSymbolizers. Simple text will be parsed as static text. Text in double curly braces ({{}}) will be interpreted as feature property. Combinations are possible.
If a template only contains simple text, an OpenLayers StyleText will be returned instead of an OlStyleFunction. This allows bidirectional parsing of those. If a template contains at least one set of double curly braces, an OlStyleFunction will be returned.
Also fixed parsing of fonts in TextSymbolizer.
Tests and testfiles were added/updated accordingly.

@terrestris/devs open for review


ghcr.io/cross-rs/cross does not work when container runs with --user option

Checklist

[X] I've looked through the issues and pull requests for similar reports

Describe your issue
The documentation suggests to run cross from inside a container like so:

docker run -v /var/run/docker.sock:/var/run/docker.sock -v .:/project -w /project my/development-image:tag cross build --target mips64-unknown-linux-gnuabi64

In general, this is wrong, because the container started from the my/development-image may run on behalf of a user different from the owner of the files in .. Usually, it runs on behalf of root. For example, ghcr.io/cross-rs/cross runs on behalf of root. This results in wrong ownership of files generated by cross (./target/**).
A proper way to run such tools is to use the --user option:

Pass the current user.
Pass the docker group to allow communicating via /var/run/docker.sock (which is readable and writable by root:docker).

But this does not work with ghcr.io/cross-rs/cross. See the detail below.
What target(s) are you cross-compiling for?
No response
Which operating system is the host (e.g computer cross is on) running?

[ ] macOS
[ ] Windows
[X] Linux / BSD
[ ] other OS (specify in description)

What architecture is the host?

[X] x86_64 / AMD64
[ ] arm32
[ ] arm64 (including Mac M1)

What container engine is cross using?

[X] docker
[ ] podman
[ ] other container engine (specify in description)

cross version
cross 0.2.5
Example
useradd appuser --create-home --groups docker --shell /bin/bash
su appuser --login

curl https://sh.rustup.rs -sSf | sh -s -- -y # See <https://rust-lang.github.io/rustup/installation/other.html>.
cargo new hello_world --bin
cd hello_world/

docker run \
	-v /var/run/docker.sock:/var/run/docker.sock:rw \
	-v /etc/passwd:/etc/passwd:ro \
	-v /etc/group:/etc/group:ro   \
	-v .:/app:rw -w /app          \
	--user "$(id -u):$(getent group docker | cut -d: -f3)" \
	-it ghcr.io/cross-rs/cross:edge cross build

Actual result
appuser@ip-10-69-41-133:~/hello_world$ docker run \
        -v /var/run/docker.sock:/var/run/docker.sock:rw \
        -v /etc/passwd:/etc/passwd:ro \
        -v /etc/group:/etc/group:ro   \
        -v .:/app:rw -w /app          \
        --user "$(id -u):$(getent group docker | cut -d: -f3)" \
        -it ghcr.io/cross-rs/cross:edge cross build
Error:
   0: could not execute `rustc --print target-list`
   1: Permission denied (os error 13)

Expected result
No such error.
Additional information / notes
Root cause

https://github.com/cross-rs/cross/blob/3bfc6d54c817a2991f610d258f3290906c97474f/docker/Dockerfile.cross#L5
https://github.com/cross-rs/cross/blob/3bfc6d54c817a2991f610d258f3290906c97474f/docker/cross.sh#L15

Rust is installed into /root/.cargo/bin/:
$ docker run -it ghcr.io/cross-rs/cross:edge which rustc
/root/.cargo/bin/rustc

Possible solution

Install Rust into some world-readable location on building ghcr.io/cross-rs/cross using the environment variables RUSTUP_HOME and CARGO_HOME. See https://rust-lang.github.io/rustup/installation/index.html#choosing-where-to-install.
Propose the proper docker run ... command in the documentation about "Docker in Docker".

Additional information
The official Docker image rust does not have such problem:
appuser@ip-10-69-41-133:~/hello_world$ docker run \
        -v /var/run/docker.sock:/var/run/docker.sock:rw \
        -v /etc/passwd:/etc/passwd:ro \
        -v /etc/group:/etc/group:ro   \
        -v .:/app:rw -w /app          \
        --user "$(id -u):$(getent group docker | cut -d: -f3)" \
        -it rust:latest rustc --version
rustc 1.72.1 (d5c2e9c34 2023-09-13)

because Rust is installed into /usr/local/cargo/bin:
$ docker run -it rust:latest which rustc
/usr/local/cargo/bin/rustc

I seem to have encountered this same problem, getting permission denied on reading files under /home/runner/ with the below command on CI ubuntu-latest image.
cross test --target aarch64-unknown-linux-gnu -- --nocapture


Security issues

Command npm audit returned the following list of errors with high severity:
  High            Arbitrary File Write

  Package         decompress

  Patched in      No patch available

  Dependency of   imagemin-pngquant [dev]

  Path            imagemin-pngquant > pngquant-bin > bin-build > decompress

  More info       https://npmjs.com/advisories/1217

  High            Arbitrary File Write

  Package         decompress

  Patched in      No patch available

  Dependency of   imagemin-pngquant [dev]

  Path            imagemin-pngquant > pngquant-bin > bin-build > download >
                  decompress

  More info       https://npmjs.com/advisories/1217

Is there a chance to fix this problem?

referencing: https://github.com/kevva/decompress/issues/71


Various fixes

Fixes

Workspace animation fix: left-to-right and right-to-left instead of just left-to-right (and enable it by default)
Fixed resize speed of y dimension (for tiled windows)

Added features

Adjustable splitratio dispatcher's speed (for example +0.1 instead of +)
Added a separate value for resize animation speed (for tiled windows)

(also sorry for that messy commit history... just check the files)

thanks!


Add Code Climate config and modify CircleCI config

Resolves #969
Proposed Changes

Add a local codeclimate.yml config
Modify the .circleci/config.yml to upload Istanbul LCOV reports to Code Climate

How to Test

Click the Code Climate Icon for this PR and confirm that the engines are running against project files, but not tests or stories
Click on the CircleCI icon to confirm that that test coverage info is getting set to Code Climate. Note: there seems to be no way to see these reports in Code Climate until this PR is merged.

Confirmed that Code Climate is only running against src code and not tests or storybook stories.

Confirmed that LCOV reports are being sent to Code Climate (or at least staged).


improvement: allow custom network ACL for specific subnets

fix #898
Description

Motivation and Context

Breaking Changes

How Has This Been Tested?

[ ] I have updated at least one of the examples/* to demonstrate and validate my change(s)
[ ] I have tested and validated these changes using one or more of the provided examples/* projects

[ ] I have executed pre-commit run -a on my pull request

this is an incorrect implementation - we can continue to discuss in the issue linked before any changes are proposed


Write unit tests

This project has almost no tests at all. To start somewhere, some unit tests should be written.
Given that this backend is powered by Spring Boot's dependency injection features and the such, tests should conform to adequate practices in order to execute as expected.
Tests are required at least for the following components:

REST Controllers
Exposed Services (consumed by REST controllers)
Security Services
CRUD Services

Before writing tests on a class, a specific issue should be created for them, so acknowledge it is being worked on.

I got to develop some unit tests for the first time and I've gotten around 25% of the codebase.
This link provides better insight on this.
The packages with utmost importance to be covered are:

org.trebol.jpa.conversion
org.trebol.jpa.predicates
org.trebol.operation.services

All that's left is #88...


Wrong month title displayed, in week view mode

In certain cases, the wrong month title is displayed, when browsing the Week view mode.
Reproduction:

Set a date which is really close to the beginning of the month. E.g. it's the 3rd of July.
The calendar view shows the following days:
30th of June (Sunday) until 6th of July (Saturday).
The current date is 3rd, as mentioned before, and it's selected.
Month title shows "June", instead of "July", even though we're both in July and the selected date is from July.

Expected:

The Month title reflects the selected day's month, instead of the month in which the week starts. In this case July instead of June.

We cannot fix this issue, and in our use case, the wrong month is displayed, which confuses the users. Even more so, because we have min/max dates, ranging from the current date to two weeks from now. As such, the user sees a month which is not even available for the current range or min/max selection.

The issue here is that in week mode, the month displayed is the month of the first day of the week.
When you collapse to week mode on the first week of the month, it's more than likely that the first day or first couple of days belong to the previous month, the title reflects the month of the first day of the week, so it appears that the previous month is selected.
AFAIK this is a pretty standard behavior for calendar UI components, though at first it may seem a little counter-intuitive.

This all makes sense, but if we're banning dates from the previous month, it doesn't make much sense to show that month in the title.
Could you possibly expose some functionality by which we'd able to show the month title of the selected day's month? To me, it seems like that's also quite reasonable in a date/time picker, as you'd want for the user to see the month of the selected day.


[react-aria] useTextField returns onBlur null instead of undefined

🐛 Bug Report
I do not know if this is intentional or not, but I think there is an issue with the useTextField hook in react-aria.
All event handlers returned are set to undefined when not defined except onBlur which is returned as null.
At first, it does not seem worrying, but when it comes to mergeProps things become a little more spicy.
In fact, when you try to merge props coming from react-aria with props coming for on another library (react-number-format in my case) then mergeProps results in onBlur defined as null so when activated, it prompts an error in console.
onBlur is not a function
I do not know if it is a constraint in the library code but it would be great if onBlur was returned as undefined. Plus it makes more sense considering all other handlers work like that.
💻 Code Sample
https://codesandbox.io/s/condescending-parm-s6wufv?file=/src/App.tsx
🌍 Your Environment
MacOs
React 18.2
With and without Vite 4.0.1

Looks like something we can fix here:
https://github.com/adobe/react-spectrum/blob/3155e4db7eba07cf06525747ce0adb54c1e2a086/packages/%40react-aria/interactions/src/useFocus.ts#L77-L78
We are incrementally updating our files to support typescript strict mode, so I think we would have caught this in the process eventually. Feel free to open a PR if you'd like, otherwise it should get fixed eventually.

@reidbarber Thanks for the reply & the explanation.
For the moment it is not an emergency as we found multiple workarounds. However in order to keep the code clear and concise, it would be great if this is fixed as soon as possible.
I will look into opening a PR

I've actually made this change here https://github.com/adobe/react-spectrum/pull/3801
It was causing an issue with mergeProps for us as well https://github.com/adobe/react-spectrum/pull/3801?notification_referrer_id=NT_kwDOAAqndbE0OTU2MDkxOTg2OjY5ODIyOQ#discussion_r1052734195

@snowystinger Awesome 👍


Request: Transmission/QBittorrent with Wireguard support

Idea of going through a VPN when downloading at home without using openvpn
Repo : https://github.com/vidurb/docker-transmission-wireguard
Repo : https://hub.docker.com/r/dyonr/qbittorrentvpn/
Repo : https://github.com/binhex/arch-qbittorrentvpn

Hi! Thanks for reaching out. Why use wireguard instead of openvpn?

Hi, as I understand, it's only an improvement on speed and cpu usage. As I don't have much time to allocate to the addons for the moment I'll put this on hold - but anyone having an idea on how to implement is free to propose a PR

This could be awesome, in a meantime I will setup an openvpn instance.

Sorry I've got too much work with already maintaining current addons, I won't be able to accept new requests for the moment

I'll close this issue as I don't intend to work on it at short term... One day perhaps I'll switch the base image to one that's supports it natively but I fear to break it for other users curently using it... Thanks for your understanding!


Fixed #94 and #95

Fixed issues #94 and #95.

@andrelsmoraes, good job! Merged and released ver 0.8.1 with npm.


[Helm Chart] Add optional service annotations

What this PR does / why we need it:
Add optional annotations to the Kubernetes Service created by the helm chart.  Annotations are helpful for human service discovery.
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): None
Special notes for your reviewer: none
Release note:

Added helm value `.Values.serviceAnnotations`

/assign @munnerz

Thank you for the PR and sorry for taking so long to review that!
We are always a little reluctant to add extra functionality to the Helm charts to avoid there being too many things to configure. But I think in this case it makes sense as there can be valid reasons for adding custom annotations to the services and, given that we already allow to configure labels, there is no reason to not configure annotations too.
I've deployed cert-manager with helm from this branch with and without the custom annotations set and saw that the custom annotations get passed correctly and the default annotations added by the chart remain there as expected.
/ok-to-test
/remove-lifecycle rotten

/kind cleanup

Thanks for the contribution 👍🏼
/lgtm
/approve

Hi!
It seems the changes introduced in this PR don't work properly due to wrong indentation.
When setting serviceAnnotations in the values.yaml I keep getting the following error when trying to add more than one annotation.
Error: YAML parse error on cert-manager/templates/service.yaml: error converting YAML to JSON: yaml: line 17: did not find expected key
Funny enough, everything works fine when I change only the indentation, here the example for service.yaml that works for me.
{{ toYaml .Values.serviceLabels | indent 4 }}
{{- end }}
  {{- if .Values.serviceAnnotations }}
  annotations:
{{ toYaml .Values.serviceAnnotations | indent 4 }}
  {{- end }}
spec:
  type: ClusterIP
  ports:

@jwenz723  will you verify the problem reported by @Fantaztig above?
We've just released https://github.com/jetstack/cert-manager/releases/tag/v1.7.0-beta.0
$ helm search repo jetstack/cert-manager --devel
NAME                                   	CHART VERSION	APP VERSION  	DESCRIPTION
jetstack/cert-manager                  	v1.7.0-beta.0	v1.7.0-beta.0	A Helm chart for cert-manager

Please create a bug report if you find this is indeed broken and submit a PR if possible before we do the 1.7.0 release on 26 January.

I tried to reproduce this by running helm install cert-manager jetstack/cert-manager -f helm-values.yaml --version v1.7.0-beta.0 -n cert-manager --create-namespace with the values file
$ cat helm-values.yaml
installCRDs: true
serviceAnnotations:
foo: bar
bar: baz
baz: foo
webhook:
  serviceAnnotations:
    foo: bar
    bar: baz
    baz: foo

but did not observe any errors with this particular configuration and the annotations got added to the cert-manger and cert-manager-webhook services as expected.

What I didn't realize at the time of reviewing this PR though is that we had already merged one PR with a similar change after this PR was open (https://github.com/jetstack/cert-manager/pull/3639)
It apears that it is the earlier change that doesn't work with multiple annotations.
If I attempt to install with the same values file, but with cert-manager v1.6.1, I get the error:
irbe@yamls$ helm install cert-manager jetstack/cert-manager -f helm-values.yaml -n cert-manager --create-namespace --version v1.6.1
Error: INSTALLATION FAILED: YAML parse error on cert-manager/templates/service.yaml: error converting YAML to JSON: yaml: line 15: did not find expected key

So it should work with multiple annotations from cert-manager v1.7.0-beta.0 onwards.
(There are also some duplicated fields in values.yaml as a result of merging both these PRs that I will remove. I wonder if we should enforce rebase to latest master before merging anything to prevent these kind of issues)

I guess this PR's release note can be updated as it is more like a bugfix now
/kind bug

I see, thanks for investigating and sorry for commenting this issue on the wrong PR!
I only searched for service annotations and wrote my comment on the first PR I saw. :)
We will update to 1.7 as soon as it's out then.

I see, thanks for investigating and sorry for commenting this issue on the wrong PR!

Thanks to you for raising the issue!

Sorry for all the release-note edits and label changes.
I've been trying to get the release-notes to make sense for the 1.7 release.


[DOCFIX] Fix broken links

Fixing broken links in 1.8 docs

@ZacBlanco PTAL

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/4007/
Test FAILed.

jenkins, test this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/4008/
Test PASSed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/4009/
Test FAILed.

jenkins, test this please

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/4010/
Test FAILed.

jenkins, test this please

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/4011/
Test FAILed.

I am fixing the flaky test in https://github.com/Alluxio/alluxio/pull/9184. Feel free to merge this PR if block on test AbstractFileSystemTest.cannotInitializeWithoutMasterHostname Expected exception: java.lang.IllegalArgumentException

jenkins, test this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/4013/
Test PASSed.

@apc999 can you re-add the 'Doc fix' label and merge this please?

@ns1123 do we need to apply the same patch to master branch?

@apc999 The flaky test only exists in branch 1.8.

@apc999 I'm going to remove the commit with the test fix. Lu will merge that in a separate PR

@ns1123  can you resolve the conflict?

@apc999 done

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/4050/
Test PASSed.

alluxio-bot, merge this please


Reviewing code structure

#7

The attribute draggable can be removed as it is not being changed when dragged to be stored on the objects


Comments should only allow basic Markdown, not HTML

See #436. Similar to how jsPerf v1 did it.

Fixed in #446