refactor(@vtmn/css): Tailwind CSS classes should not be prefixed with vtmn-

CSS classes from Tailwind CSS should not be prefixed (the subject of this issue, case 1)
Specific Vitamin CSS classes should be prefixed (not the subject of this issue, case 2)
Edit: I believe now that even specific Vitamin CSS should not be prefixed, other CSS frameworks don't do that (only on specific cases)

Example: flex vs vtmn-flex
Rationals:

Each time you read Tailwind doc, you have to keep in mind to add vtmn- => cognitive overhead
Each time you copy paste a Tailwind code snippet you have to add vtmn- => cognitive overhead
Your brain has 6 more characters to read before the actual important thing (flex vs vtmn-flex) => cognitive overhead
Code is longer and more difficult to read with no added value:

vs

(Btw when needed use a shorter prefix likevt- instead of vtmn-, for ex Bootstrap uses bs for data-* and CSS variables instead boot)
Source code where the prefix is added: https://github.com/Decathlon/vitamin-web/blob/a5505a9ff88b1310f5a18046d0d2e45c7c7d9363/packages/sources/css/presets/tailwind/index.js#L4

Hi @tkrotoff,
Thanks a lot for your proposal and I agree about cognitive overhead and the fact that some CSS classes are verbose...
Unfortunately for now it would be impossible for us to change this in this version of Vitamin because we cover 10,000-100,000 lines of code that would causes breaking changes and a lot of refactoring for consumers that uses this library since 2020.
That's why I tag you your issue "Next" in order to take in account your proposition for our next major release that we currently build.
Thank you very much.

impossible for us to change this

codemon
also export without the prefix

=> smooth transition
Meantime is there a hack to avoid polluting my code with vitmn- all over the place?

Hi @tkrotoff, I'll answer you on Slack :)

Hi @tkrotoff,
thanks for you suggestions here :)
As we discussed, there will be some changes regarding Tailwind and the naming of css classes (we'll opt for the shorter vt- prefix) in the next version of Vitamin we are working on.
I'm closing this issue for now, thanks again!


Remove automaton DSL from new frontend

Note that there are a lot of warnings in the old frontend after this change. I tried to just disable them with [@@@ocaml.warning "-.."] but maybe did something wrong. Since all that code is getting deleted soon I didn't bother investigating further. The only code I did remove from the old frontend was just what was needed to make kind2 compile.

The temporal operator last should be removed too. It was only used within the definition of an automaton.
I also found functions to print automata in lustre/lustrePath.ml, and a reference to automata in a comment in lustre/lustreDeclarations.ml. In addition, Ocaml 4.13 reports the following warning:
File "src/lustre/lustreAstInlineConstants.ml", line 358, characters 4-5:
358 |   | e -> e
          ^
Warning 11 [redundant-case]: this match case is unused.

@amarmaduke, could you please address these issues?
Thanks.

Hi, the recent release seems to have removed support for the automata. In my rough understanding, the automaton structure is more like a syntactic sugar but in some cases it may be possible to simplify the modeling. I am just curious about the decision and could you please tell me the reason?

Thank you for your feedback.


Question: Dungeon Boss Kill Points

Is there no way to calculate non mythic dungeon bosses?

I could take a look at the statistics API instead of relying on the achievement API for those numbers.


ref: restructure code directory

all source code is moved to src directory so that babel will not try to parse node_modules and will create dist folder after build

Too much modification, so discard this


Feat: Add axisLabelContainerStyle prop to AnimatedLineGraph component

Add a axisLabelContainerStyle (searching for a better name 😅) prop to the AnimatedLineGraph.
Problem:
PanGesture bubble gets cut off at very top/bottom of the graph. With an additional style prop the user could define paddingVertical or any other custom styles.

Is this ready for review?

@mrousavy Ready for review! This PR should be merged before #18, so the new horizontalPadding and verticalPadding props can be respected


Better success/error messaging after IOD submission

With the current implementation:

User submits their IOD(s)
Success/error messaging rendered at the bottom of the form

The problem with this is that the user may miss the feedback as the page returns to top of the form after submission. This is particularly evident in the SingleObservationForm component due to the length of the form.

A better solution would be perhaps be have a more pleasing user-experience like an animated pop-up modal.

@johngribbin This might be further improved by giving the user line-by-line feedback on success vs failure (perhaps clustering them until state changes from success/fail or fail/success).
I believe this would require more granular feedback from trusat-backend, but the success status could be returned in an array.

@interplanetarychris Agreed.


Fix a typo in docs page for github actions

Description
When reading the documentation, I noticed this word was ~mispelled~ using the British spelling rather than the American spelling which other pages use. Since there's an edit on github button, figured I'd just submit a fix!
Testing Instructions

Ah, damn...I guess this is actually a difference between british and american english. Other pages in the documentation, e.g. https://turbo.build/repo/docs/core-concepts/remote-caching, use the american spelling, so figure standardization is good!

Allow CI Workflow Run

[ ] approve CI run for commit: 46aa93f856efb9b114959f2102f3ec694e1240af

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

Allow CI Workflow Run

[ ] approve CI run for commit: 46aa93f856efb9b114959f2102f3ec694e1240af

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer


Configure Azure Pipelines

This pipeline configuration builds the application and produces a build for the Release configuration.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: kapilg09 sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


Add a Help menu with handy links.

As mentioned in https://github.com/4pr0n/ripme/issues/404#issuecomment-270857987
Getting Started
Open an Issue (link to issue pre-populated with a template which includes app version, etc.)
Contribute (link to GitHub)
Any further suggestions?

Maybe a general about section. Literally a one line description of the app. ?

The wiki entry on how to write a ripper

I think a general link to the wiki where the main page is rewritten or reorganized to be a good landing point for a user would probably be the best way to go about it without cluttering things.
README -> non-front-page of Wiki probably makes more sense for developers.
The front page of the Wiki could definitely include some developer links but should focus on how to get the most out of the program (like setting up a Tumblr API key for example -- see #415).


txt relocated

Mountainland Technical College txt file relocated for domain

mtec.edu
stu.mtec.edu

thanks!!

@gabserna Thank you for your patience while waiting for a review and processing your request. Pull request merged. Please start applying for JetBrains educational subscription at https://www.jetbrains.com/shop/eform/students in an hour, to allow the changes to propagate through JetBrains systems.

@gabserna Thank you for your patience while waiting for a review and processing your request. Pull request merged. Please start applying for JetBrains educational subscription at https://www.jetbrains.com/shop/eform/students in an hour, to allow the changes to propagate through JetBrains systems.


Find a suitable name for the plugin

Taskgraph as a name makes the user think, this plugin is only for organizing tasks. However, with the help of the plugin, a user can

Create mindmaps and quickly manifest ideas in tiddlers (wiki entries).
Create task-dependency graphs to organize and describe tasks.
Visualize topic structures to get an immediate grasp of topics and relations.

In general the user may create, visualize and describe any network-structure he/she has in mind.
So what name to choose?

TreePlugin

TreePlugin


User-agent short codes not working on M1 Macbook

Homework

[ x] I looked at nativefier --help and https://github.com/nativefier/nativefier/blob/master/API.md
[ x] I checked the Troubleshooting section of the README.
[ x] I searched existing issues, open & closed. Yes, my bug is new.
[ x] I'm using the latest version available at https://github.com/nativefier/nativefier/releases

Bug description
Running nativefier under arm64, the --user-agent shortcuts do not work, instead they are copied verbatim as the user agent.
Steps to reproduce
Give your full nativefier command and its logs, with the --verbose flag, on a public site:
nativefier 'https://www.whatismybrowser.com/detect/what-is-my-user-agent' --user-agent firefox

Expected behavior
What you expected to happen.
The user agent to be replaced with the firefox user agent.
Actual behavior

Context

Nativefier: (for example: 9.1.0) 43.1.3
Node.js: (for example: 14.6.0) v16.3.0
Npm: (for example: 6.14.7) 7.16.0
OS: (for example: Windows 10 build 1809) MacOS

This seems to affect Intel Macs too. I can reproduce on my 2011 Intel Mac mini running macOS 10.13 High Sierra.
❯ nativefier -v
43.1.3

~
❯ node -v
v16.3.0

~
❯ sw_vers
ProductName:	Mac OS X
ProductVersion:	10.13.6
BuildVersion:	17G14042

~

❯ nativefier 'https://www.whatismybrowser.com/detect/what-is-my-user-agent' --user-agent firefox --verbose

Running in verbose mode! This will produce a mountain of logs and is recommended only for troubleshooting or if you like Shakespeare.

Performing async options post-processing.
Inferring icon for https://www.whatismybrowser.com/detect/what-is-my-user-agent on darwin
Inferring icon from store for https://www.whatismybrowser.com/detect/what-is-my-user-agent on darwin
Allowed icon formats when building for darwin: [ '.icns', '.png', '.ico' ]
Inferring name for https://www.whatismybrowser.com/detect/what-is-my-user-agent
Got 249 icons from gitcloud
Max icon match score: 0
No relevant icon in store.
Trying to extract a .png icon from the page.
Fetched 26.8 kb page at https://www.whatismybrowser.com/detect/what-is-my-user-agent
Inferred title: What is my user agent? - WhatIsMyBrowser.com
Sanitized filename for What is my user agent? - WhatIsMyBrowser.com : What is my user agent - WhatIsMyBrowsercom
Got an icon from the page.
Writing 44.9 kb icon to /var/folders/x4/d6xhrn615_15s2bdvqp7rtw80000gr/T/nativefier-18-58-56-iconinfer--10113-ygElraAWiug5/icon.png
options {
  packager: {
    appCopyright: undefined,
    appVersion: undefined,
    arch: 'x64',
    asar: false,
    buildVersion: undefined,
    darwinDarkModeSupport: false,
    dir: '/Users/USER/.n/lib/node_modules/nativefier/app',
    electronVersion: '12.0.7',
    icon: '/var/folders/x4/d6xhrn615_15s2bdvqp7rtw80000gr/T/nativefier-18-58-56-iconinfer--10113-ygElraAWiug5/icon.png',
    name: 'What is my user agent - WhatIsMyBrowsercom',
    out: '/Users/USER',
    overwrite: true,
    platform: 'darwin',
    portable: false,
    targetUrl: 'https://www.whatismybrowser.com/detect/what-is-my-user-agent',
    tmpdir: false,
    upgrade: false,
    upgradeFrom: undefined,
    win32metadata: {
      ProductName: undefined,
      InternalName: undefined,
      FileDescription: undefined
    }
  },
  nativefier: {
    accessibilityPrompt: true,
    alwaysOnTop: false,
    backgroundColor: null,
    basicAuthPassword: null,
    basicAuthUsername: null,
    blockExternalUrls: false,
    bookmarksMenu: null,
    bounce: false,
    browserwindowOptions: undefined,
    clearCache: false,
    counter: false,
    crashReporter: undefined,
    disableContextMenu: undefined,
    disableDevTools: undefined,
    disableGpu: false,
    diskCacheSize: null,
    disableOldBuildWarning: false,
    enableEs3Apis: false,
    fastQuit: false,
    fileDownloadOptions: undefined,
    flashPluginDir: null,
    fullScreen: false,
    globalShortcuts: null,
    hideWindowFrame: undefined,
    ignoreCertificate: false,
    ignoreGpuBlacklist: false,
    inject: [],
    insecure: false,
    internalUrls: null,
    lang: undefined,
    maximize: false,
    nativefierVersion: '43.1.3',
    processEnvs: undefined,
    proxyRules: null,
    showMenuBar: false,
    singleInstance: false,
    titleBarStyle: null,
    tray: false,
    userAgent: 'firefox',
    userAgentOverriden: true,
    verbose: true,
    versionString: undefined,
    width: 1280,
    height: 800,
    minWidth: undefined,
    minHeight: undefined,
    maxWidth: undefined,
    maxHeight: undefined,
    widevine: false,
    x: undefined,
    y: undefined,
    zoom: 1
  }
}

Preparing Electron app...
Copying electron app from /Users/USER/.n/lib/node_modules/nativefier/app to /var/folders/x4/d6xhrn615_15s2bdvqp7rtw80000gr/T/nativefier-18-58-56-app--10113-l3FJdp1WbAbB
Writing app config to /var/folders/x4/d6xhrn615_15s2bdvqp7rtw80000gr/T/nativefier-18-58-56-app--10113-l3FJdp1WbAbB/nativefier.json
No files to inject, skipping copy.
Updating /var/folders/x4/d6xhrn615_15s2bdvqp7rtw80000gr/T/nativefier-18-58-56-app--10113-l3FJdp1WbAbB/package.json 'name' field to what-is-my-user-agent---whatismybrowsercom-nativefier-2b6c22

Converting icons...
Converting icon /var/folders/x4/d6xhrn615_15s2bdvqp7rtw80000gr/T/nativefier-18-58-56-iconinfer--10113-ygElraAWiug5/icon.png to /var/folders/x4/d6xhrn615_15s2bdvqp7rtw80000gr/T/nativefier-18-58-56-iconconv--10113-IWZpe8XCxzuh/icon.icns. Calling shell command: "/Users/USER/.n/lib/node_modules/nativefier/icon-scripts/convertToIcns" "/var/folders/x4/d6xhrn615_15s2bdvqp7rtw80000gr/T/nativefier-18-58-56-iconinfer--10113-ygElraAWiug5/icon.png" "/var/folders/x4/d6xhrn615_15s2bdvqp7rtw80000gr/T/nativefier-18-58-56-iconconv--10113-IWZpe8XCxzuh/icon.icns"
Conversion succeeded and produced icon at /var/folders/x4/d6xhrn615_15s2bdvqp7rtw80000gr/T/nativefier-18-58-56-iconconv--10113-IWZpe8XCxzuh/icon.icns
Copying icons if necessary
No copying necessary on macOS; aborting

Packaging...
App built to /Users/USER/What is my user agent - WhatIsMyBrowsercom-darwin-x64, move to wherever it makes sense for you and run the app bundle.

I apologize for the issue here. THis has been updated in our docs, but hasn't made it out to npm yet. Hopefully very soon!

I apologize for the issue here. THis has been updated in our docs, but hasn't made it out to npm yet. Hopefully very soon!

Truuuuuuuuuuue. Will remind to release fast when we merge stuff that updates the docs! Cutting a release later today, sorry for the hiccup everybody!

Say hi to useragent shortcodes in freshly-released 44.0.0, released now on npm! Thanks for the report. With that, closing, feel free to re-open if it's not working as intended.


Enable to use app.client with passed token for single workspace apps

Description
tl;dr
tl;dr - I propose that app.client should hold a token value when a fixed single workspace token is passed to App constructor. Refer to #250 to learn the context. If you have comments / feedback on this, please let us know within a few days.
How it currently works
As mentioned in #250, the following does not work as you may expect.
const app = new App({
  token: process.env.SLACK_BOT_TOKEN,
  signingSecret: process.env.SLACK_SIGNING_SECRET,
});
(async () => {
  const authTestResponse = await app.client.auth.test();
  console.log(authTestResponse);
})();

You will see the following error even when you pass a valid token as SLACK_BOT_TOKEN.
(node:95474) UnhandledPromiseRejectionWarning: Error: An API error occurred: not_authed
    at Object.platformErrorFromResult (/Users/ksera/github/bolt-starter/node_modules/@slack/web-api/dist/errors.js:51:33)
    at WebClient.apiCall (/Users/ksera/github/bolt-starter/node_modules/@slack/web-api/dist/WebClient.js:157:28)
    at processTicksAndRejections (internal/process/task_queues.js:97:5)

The reason is that the underlying token in app.client is undefined, while the client in listener arguments holds the passed value. As described here, this has been intentionally done in this line.
Possible workarounds as of v3.3
As mentioned in this comment, you can modify the internal token value in JavaScript. However, this approach does not work in TypeScript as the property is read-only.
(async () => {
  app.client.token = process.env.SLACK_BOT_TOKEN;
  const authTestResponse = await app.client.auth.test();
  console.log(authTestResponse);
})();

Why we are going to change
For a cleaner framework design, the team decided to intentionally set undefined token for the app.client as the instance is not yet initialized by an authorize function in Bolt app.
However, we have been receiving questions / requests like #250 (not only in GitHub issues but also in the community workspace) several times. @seratch proposed this internally, and the Bolt maintainer team discussed this topic again. Then, we reached a consensus that, regarding this specific use case (a single workspace app with a fixed access token), we can prioritize the convenience for developers over the framework design policies we had in the early days.
Pros/Cons
These are pros/cons of the change I propose here.
Pros:

Obviously, the behavior is more intuitive for developers
The Bolt dependency is usable not only for event handling but also for simple Web API calls
Bolt can provide a way to use app.client with a given token in TypeScript too

Cons:

A bit inconsistency with the cases where App constructor does not have token but has authorize or OAuth settings (the app.client.token exists only when the constructor takes token argument).

What type of issue is this? (place an x in one of the [ ])

[ ] bug
[x] enhancement (feature request)
[ ] question
[ ] documentation related
[ ] example code related
[ ] testing related
[ ] discussion

Requirements (place an x in each of the [ ])

[x] I've read and understood the Contributing guidelines and have done my best effort to follow them.
[x] I've read and agree to the Code of Conduct.
[x] I've searched for any related issues and avoided creating a duplicate issue.

This looks great! I wonder if in a token rotation world, we can assign a new token to app.client.token

Well I guess this solution is only for single workspace install. Should we consider assigning the token when users are using OAuth too?

@stevengill

Well I guess this solution is only for single workspace install. Should we consider assigning the token when users are using OAuth too?

In the case of OAuth supported apps, multiple bot tokens / user tokens can be associated with client. Thus, it's not possible to assign a fixed token in the case.
If an app uses OAuth only for bot token rotation along with a single workspace installation, it may be possible to enable app.client to hold refresh token in it. To make this happen, WebClient must have a feature to automatically refresh rotated tokens:
const app = new App({
    refreshToken: '...',
    clientId: '...',
    clientSecret: '...',
});

(async () => {
  // before calling auth.test API, a new access token will be retrieved by the refresh token
  await app.client.auth.test();
})();

I'm thinking to merge #948 by the end of this week. Write in if you have any comments on this.


Goodwe Hybrid: Use AC Power and not DC

Describe the bug
evcc is using Modbus Register 35191 to read current PV energy. This is the DC side of the inverter. Instead register 35138 "Total power of inverter" should be used which reflects the AC output of the inverter.
There is a difference in both values especially in the morning there is ~50W on DC and 0W on AC. The same in the evening. During the day the diff can be huge in some cases:

Steps to reproduce
none
Configuration details
use goodwe-hybrid template

Log details
none required

What type of operating system are you running?
Docker container
Version
0.123.3

evcc is using Modbus Register 35191 to read current PV energy. This is the DC side of the inverter. Instead register 35138 "Total power of inverter" should be used which reflects the AC output of the inverter.

This seems wrong: Power is a different physical measurement from Energy.
@premultiply we should remove pv energy from all templates- it may be wrong and it's not even used by evcc.

I'm referring to this line: https://github.com/evcc-io/evcc/blob/0705fca00aa19e009c31747f38ccf04e53ed6c27/templates/definition/meter/goodwe-hybrid.yaml#L67C14-L67C14
This should use register 35138.

That is energy. 35138 acoording to what you wrote is power. Energy is NOT Power. Closing.

As this is a hybrid inverter AC output metering is useless. It will return just a mixture of solar, battery and other self consumption. The only way to monitor a hybrid inverter is to get the dc metering on solar and battery paths.

EVCC displays generation in the UI now where there is actually none effectively. What evcc is reporting now is totally consumed internally within the inverter. DC side metering is useless unless there is some power on AC side or into batteries.
I'm referring to what the UI display as "Erzeugung" in german UI. This represents wrong value for goodwe hybrid. Wherever the value comes from.


build android library with two or more local aar libs failed at version 3.5.0

Expected Behavior

build android library with two or more local aar libs success in AS
Current Behavior

build failed
Context

I want build the library to aar for other project, but build failed.
Steps to Reproduce

when run command:  gradlew mylibrary:build
FAILURE: Build failed with an exception.

What went wrong:
Execution failed for task ':mylibrary:mergeDebugJavaResource'.

A failure occurred while executing com.android.build.gradle.internal.tasks.Workers$ActionFacade
More than one file was found with OS independent path 'classes.jar'

example project:  https://github.com/kawais/testapp
Your Environment

android stuido 3.5
windows 10

I ran into the same issue with an internal component and resolved by downgrading Gradle to 3.4.2. This issue still persists in Gradle 3.5.2.

Hi there, any solution found for this problem?

this problem still occurred in Gradle 3.5.3

this problem still occurred in Gradle 3.5.3

That's correct. If you want to "fix" it by downgrading, try using 3.4.3.

I couldn't downgrade the Gradle version, I fixed it by uploading the aar's to internal artifactory

I couldn't downgrade the Gradle version, I fixed it by uploading the aar's to internal artifactory

Interesting.. Can you share some details which files you uploaded?

@mzennis could you please describe how you did this:

I fixed it by uploading the aar's to internal artifactory

OK, here is a little update from my side on this issue. I'm using React native and latest versions of RN 0.63 uses gradle plugin 3.5.3 by default.
I tried to update to gradle plugin 3.6.4 and it seems to work, solving by the way this issue with aar files.
Hope this will help someone.

packagingOptions {
merge "classes.jar"
}

I fixed it by add this code in module bulid.gradle

I couldn't downgrade the Gradle version, I fixed it by uploading the aar's to internal artifactory

Interesting.. Can you share some details which files you uploaded?

I uploaded the aar library file that was previously local to the internal repository.
before:
implementation files('libs/mylibrary.aar')
now:
implementation 'com.xxx.xxx:mylibrary:1.0@aar'

Thank you for your interest in Gradle!
This is an issue with the Android Gradle Plugin which is developed by Google and cannot be addressed in the core of the Gradle Build Tool.
Please open such Android-related issues on the Android Issue Tracker at https://source.android.com/source/report-bugs


ion-view pushes to stack

When using <ion-view> in certain places (like a Modal), it can unexpectedly push a state to the stack and then show a back button incorrectly when the modal is closed.
Can we add a way to say this view will not push to the stack, or provide more clear ways of using the ion-view tags in modals and other non-navigational UIs?

@travisdahl Did you find a way to push to history stack? I need a similar feature


Fastlane version bump

Add the ability to specify a strategy for hockey action (#5514)
Fixup carthage dependencies option to be Array type (#5522)
[Carthage] Add option to pass in specific dependencies to update (#5500)
[Carthage] Ignore platform option case (#5504)
Remove initial confirmation prompt from init beta
Add fields and tests for init beta (#5516)
Checking the default team_id value in the Appfile. (#5478)
Also check for a default value from the Appfile (#5465)
[add_git_tag] Add commit option
Update code signing URL across the fastlane code base (#5451)

:+1:


Two tables on same page throwing error when sorting.

I'm submitting a ...  (check one with "x")
[x] bug report => search github for a similar issue or PR before submitting
[ ] feature request
[ ] support request => Please do not submit support request here

Current behavior
If I have two tables on the same page and try sort the second table, an error is thrown. I am defining a ngx-datatable-column as I want to use a cell template.
Expected behavior
Both tables should be sortable.
Reproduction of the problem
Plunker does not seem to be working?
To create it is very simple. All I did was create two tables in the same component as follows:
<ngx-datatable [rows]="table1" [rowHeight]="'auto'" [columnMode]="'flex'">
	<ngx-datatable-column name="Customer" prop="customerNumber">
         </ngx-datatable-column>
</ngx-datatable>
<ngx-datatable [rows]="table2" [rowHeight]="'auto'" [columnMode]="'flex'">
	<ngx-datatable-column name="Customer" prop="customerNumber"></ngx-datatable-column>
</ngx-datatable>

This resulted in the following error when I click on the column header in the second table:
EXCEPTION: Error in ./DataTableBodyComponent class DataTableBodyComponent - inline template:31:12 caused by: Expression has changed after it was checked. Previous value: 'true'. Current value: 'false'.

Table version: 6.0.0

Angular version: 2.3.1

Browser: Chrome

Language: TypeScript 2.1

Thanks,
Kevin.

+1

By any change is it possible that table1 and table 2 share that same objects? I saw a similar exception in case of shared data.

Ya, if they share the same column defs this will happen. I would have to copy columns to avoid this which would de-reference.

I don't think it is related to the shared columns. It is related to the same row objects and in particular $index that is added to the grid. It would be nice to share the row objects and have custom $index for each grid. You can check the plunk https://plnkr.co/edit/i4ayUTOuYQnFgvqbIP2m that shows two grids with with different columns objects but the same rows. open the console and start clicking on sort. See the error.
DataTableBodyComponent.html:30 ERROR Error: ExpressionChangedAfterItHasBeenCheckedError: Expression has changed after it was checked. Previous value: 'datatable-body-row datatable-row-even'. Current value: 'datatable-body-row datatable-row-odd'.
    at viewDebugError (errors.ts:30) [angular]
    at expressionChangedAfterItHasBeenCheckedError (errors.ts:29) [angular]
    at checkBindingNoChanges (util.ts:145) [angular]
    at checkNoChangesNodeInline (view.ts:438) [angular]
    at checkNoChangesNode (view.ts:519) [angular]
    at debugCheckNoChangesNode (services.ts:387) [angular]
    at debugCheckRenderNodeFn (services.ts:330) [angular]
    at Object.eval [as updateRenderer] (DataTableBodyComponent.html:30) [angular]
    at Object.debugUpdateRenderer [as updateRenderer] (services.ts:307) [angular]
    at checkNoChangesView (view.ts:368) [angular]
    at callViewAction (view.ts:694) [angular]
    at execEmbeddedViewsAction (view.ts:670) [angular]
    at checkNoChangesView (view.ts:368) [angular]
    at callViewAction (view.ts:694) [angular]
    at ____________________Elapsed_46507_ms__At__Mon_Apr_10_2017_10_20_21_GMT_0400__EDT_ (localhost)
    at getStacktraceWithUncaughtError (VM1058 long-stack-trace-zone.js:39) [angular]
    at new LongStackTrace (VM1058 long-stack-trace-zone.js:33) [angular]
    at Object.onScheduleTask (VM1058 long-stack-trace-zone.js:104) [angular]
    at ZoneDelegate.scheduleTask (VM1039 zone.js:378) [angular]
    at Object.onScheduleTask (VM1039 zone.js:274) [angular]
    at ZoneDelegate.scheduleTask (VM1039 zone.js:378) [angular]
    at Zone.scheduleTask (VM1039 zone.js:209) [angular]
    at Zone.scheduleEventTask (VM1039 zone.js:235) [angular]
    at zoneAwareAddListener (VM1039 zone.js:1370) [angular]
    at HTMLSpanElement.addEventListener (eval at createNamedFn (VM1039 zone.js:1476), <anonymous>:3:43) [angular]
    at DomEventsPlugin.addEventListener (dom_events.ts:37) [angular]
    at EventManager.addEventListener (event_manager.ts:32) [angular]
    at DefaultDomRenderer2.listen (dom_renderer.ts:110) [angular]
    at DebugRenderer2.listen (services.ts:906) [angular]
    at ____________________Elapsed_168_ms__At__Mon_Apr_10_2017_10_20_21_GMT_0400__EDT_ (localhost)
    at getStacktraceWithUncaughtError (VM1058 long-stack-trace-zone.js:39) [angular]
    at new LongStackTrace (VM1058 long-stack-trace-zone.js:33) [angular]
    at Object.onScheduleTask (VM1058 long-stack-trace-zone.js:104) [angular]
    at ZoneDelegate.scheduleTask (VM1039 zone.js:378) [angular]
    at Object.onScheduleTask (VM1039 zone.js:274) [angular]
    at ZoneDelegate.scheduleTask (VM1039 zone.js:378) [angular]
    at Zone.scheduleTask (VM1039 zone.js:209) [angular]
    at Zone.scheduleMicroTask (VM1039 zone.js:229) [angular]
    at scheduleResolveOrReject (VM1039 zone.js:758) [angular]
    at resolvePromise (VM1039 zone.js:707) [angular]
    at unpkg.com/zone.js@0.8.5/dist/zone.js:760:17 [angular]
    at Object.onInvokeTask (ng_zone.ts:253) [angular]
    at ZoneDelegate.invokeTask (VM1039 zone.js:397) [angular]
    at ____________________Elapsed_3_ms__At__Mon_Apr_10_2017_10_20_21_GMT_0400__EDT_ (localhost)
    at getStacktraceWithUncaughtError (VM1058 long-stack-trace-zone.js:39) [angular]
    at new LongStackTrace (VM1058 long-stack-trace-zone.js:33) [angular]
    at Object.onScheduleTask (VM1058 long-stack-trace-zone.js:104) [angular]
    at ZoneDelegate.scheduleTask (VM1039 zone.js:378) [angular]
    at Object.onScheduleTask (VM1039 zone.js:274) [angular]
    at ZoneDelegate.scheduleTask (VM1039 zone.js:378) [angular]
    at Zone.scheduleTask (VM1039 zone.js:209) [angular]
    at Zone.scheduleMicroTask (VM1039 zone.js:229) [angular]
    at scheduleResolveOrReject (VM1039 zone.js:758) [angular]
    at ZoneAwarePromise.then (VM1039 zone.js:847) [angular]
    at new ApplicationInitStatus (application_init.ts:47) [angular]
    at AppModuleInjector.createInternal (module.ngfactory.js [sm]:1) [angular]
    at AppModuleInjector.NgModuleInjector.create (ng_module_factory.ts:124) [angular]
    at NgModuleFactory.create (ng_module_factory.ts:97) [angular]

Seeing the same issue as @ipassynk. It also occurs if subsets of the same row collection are used in multiple tables without being deep cloned. I forked the above plunkr to show an example of this case https://plnkr.co/edit/iDzItKhvp2QcfZBMMqH4?p=preview.

What is the solution please?


Set the NU6 testnet activation height and network protocol version

Motivation
We need to update the consensus parameters for NU6 testnet.
Specifications
TBD: (We need to wait for the relevant NU6 deployment ZIP)
Complex Code or Requirements
No response
Testing
No response
Related Work
#4115
#8681
depends-on:  zcash/zips#878
depends-on:  zcash/librustzcash#1454

https://github.com/zcash/zips/pull/878

This issue is straightforward to do but it is blocked by several reasons:

The ZIP with the info we want to add is a draft: https://github.com/zcash/zips/pull/878
zcash_primitives need to have Nu6 data: https://github.com/zcash/librustzcash/pull/1454

Assuming we can have stable Nu6 in the next zcash_primitives release, we also need:

Deal with the release breaking changes and upgrade Zebra before adding the constant values.

CURRENT_NETWORK_PROTOCOL_VERSION needs to be bumped to 170_110 too so that peer candidates won't reject Zebra after NU6 is active.
We also need to set the Testnet activation height, this issue was closed mistakenly.

this is now done


Compilation errors with VS2015

When I compile the latest SDL_GPU with visual studio 2015, I get multiple syntaxes and undeclared identifiers errors.
Here is the full build log (in french).
logs.txt

The headers of the old SDL_GPU got mixed up in the compilation, it's working fine after fixing that.


Modify Data Management

Kourtney-- Can you modify the SAEL Lab Manual so that the Data Management Pages reflect the new information provided in the Data Analysis repo?
FWIW-- the Data Analysis will be specific to ADRIFT (at least for now) and we will update the Lab Manual in the future.
I'm still figuring out how I want to approach that with the shift in platforms (where nearly everything will change).
But for now, if you can ensure that the lab manual is as updated as possible, that would be great (since it may be viewed a LOT next week!. Thanks!

Yeah I can work on that, I can also update the analysis section! Do you want something similar to the hardware methods section, where we have an ADRIFT specific page that links to the main ADRIFT field methods website? I know it can be annoying to click around to different places but I think it might be better this way so if we update something in the data analysis methods it does not need to be changed in two places

For most things-- we want to update in one place (only)...  I am actually
deleting the Analysis Methods page (on the Adrift page, it will link to the
analysis repo). So-- ignore that one.
For the Data Methods-- I'm particularly keen, as you are (so far) the only
one to work on Obis, and you/taiki have put together a good approach for
ncei, etc... so I want that to be outlined enough so that they can see our
approach (it could come up). For these, I think it is probably best to have
a summary, and then the basic details, with a link to extended details (the
extremely detailed play by play). Do what you have now-- and we can update
as we go along.
(By June we can make sure this is updated in the Analysis Methods-- then I
think I will change that Repo to the Adrift Analysis Methods, so at that
point it will stay static as an archive).....
Does that make sense?
On Wed, Mar 13, 2024 at 9:03 PM Kourtney Burger @.***>
wrote:

Yeah I can work on that, I can also update the analysis section! Do you
want something similar to the hardware methods section, where we have an ADRIFT
specific page
https://sael-swfsc.github.io/SAEL-lab-manual/content/Hardware_ADRIFT.html
that links to the main ADRIFT field methods website? I know it can be
annoying to click around to different places but I think it might be better
this way so if we update something in the data analysis methods it does not
need to be changed in two places
—
Reply to this email directly, view it on GitHub
https://github.com/SAEL-SWFSC/SAEL-lab-manual/issues/10#issuecomment-1995804701,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AOC5FKATW6VGKCYJOW6FLQ3YYC5JBAVCNFSM6AAAAABEU2CZDGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOJVHAYDINZQGE
.
You are receiving this because you were assigned.Message ID:
@.***>

Got it! That sounds like a good plan, I will work on updating that


Percy forever waiting on snapshot to be uploaded

Building a ember 2.5 app. Testing with travis with parallel test suits. I've configured pretender to let percy through this.post('/_percy/:path', this.passthrough); and added the environment variable PERCY_PARALLEL_TOTAL=2 in travis.
I've only added one snapshot to a test. All tests pass on travis but percy is hanging.
The "Waiting for snapshot uploads... " message is displayed.
Test also run locally without error.

How are your tests parallelized?

I just checked in the database, and there were no snapshots uploaded for any of the builds pushed to your repo at all. This very likely means that the pretender config is not correct. I don't know of a great way to debug this, other than running in ember test --server — open up the Inspector in the browser, then refresh the page to run your tests again. Do you see an error about network requests being blocked?

@MondeSameWave — I now have a few different fixes for this particular issue, depending on what it actually is for you (there is a Pretender shutdown bug that may cause this), and/or some parallelization issues.
If you come back to this, let me know and I can help you debug! Feel free to reach out in the app as well.


802.1q VLAN Support

Hi,
I recently hooked up HassOS with KVM on my hypervisor. Since I've different VLAN's that Hass should work with, I set up two new network manager profiles for these, using the single virtio link as parent.
However, it seems that the 8021q kernel module is missing. Would it be possible to include that in future builds? For what it's worth, that's something really useful.
Personally, I can just add another virtio link to the VM and couple network manager profiles to their MACs, but devices with only a single physical NIC don't have that option.
Best regards
Robert

Feel free to make a PR 👍

@pvizeli Ok, do you have any hint on where to start with this? I'm absolutely unfamiliar with the HassOS buildroot architecture... Wouldn't it be enough to activate the building of 8021q somewhere globally for all architectures? Don't know whether userland software is missing as well, but since ip link says Operation not supported, I think the only missing part is the kernel module.

@efficiosoft You can get started by taking a look in buildroot-external/configs and taking a look at one of the configs to see where things are being configured from. Among other things, the kernel config/version/patches are specified here. If you want to enable this for all platforms, you'll need to update several kernel configs.

@efficiosoft due to somebody else's request, I wrote https://github.com/jtru/hassos/blob/getting-started-with-devel-guide/Documentation/getting_started_development.md yesterday. Maybe you find it helpful, too :) That, and knowing a bit about how the Linux' config system works, should be enough to get you started.

Yeah like @jtru have done it is fine. I will split this kernel config into a generic HassOS and linux version part later before next release come out.

@jtru Thanks for that howto, found it to be very helpful!
I added the module to buildroot-external/kernel/hassos-4_14.config and it's building currently... We'll see how long that takes :)

You're welcome :)
We arrived at the same conclusion, I think - I built tha OVA image with CONFIG_VLAN_8021Q=y set in the file you mentioned, and could successfully create a VLAN device wit htat kernel booted.

Ok, finally got the build run through. Creating VLAN interfaces works.


debug_traceTransaction custom EVM tracer not compatible with geth

Describe the bug
Geth's custom EVM tracer for the debug_traceTransaction API is documented in https://geth.ethereum.org/docs/developers/evm-tracing/custom-tracer
rETH's getPc() method on the log argument of the step function does not match geth's getPC() function
https://geth.ethereum.org/docs/developers/evm-tracing/custom-tracer#step
rETH is using a lower case c, while geth is using an uppercase C.
Steps to reproduce
The following request returns a list of program counters using log.getPc()
{
    "jsonrpc": "2.0",
    "method": "debug_traceTransaction",
    "params": [
        "0x6892b5c44e0ec2382f0e30d86dfaba11847f2ddc038a2cce30b5c3be4d08108b",
        {
            "tracer": "{data: [], fault: function(log) {}, step: function(log) { this.data.push(log.getPc()) }, result: function() { return this.data; }}"
        }
    ],
    "id": 1
}

The following using geth style log.getPC() does not return any results
{
    "jsonrpc": "2.0",
    "method": "debug_traceTransaction",
    "params": [
        "0x6892b5c44e0ec2382f0e30d86dfaba11847f2ddc038a2cce30b5c3be4d08108b",
        {
            "tracer": "{data: [], fault: function(log) {}, step: function(log) { this.data.push(log.getPC()) }, result: function() { return this.data; }}"
        }
    ],
    "id": 1
}

Node logs
No response
Platform(s)
Windows (x86)
What version/commit are you on?
reth Version: 0.1.0-alpha.17 Commit SHA: aac72f4 Build Timestamp: 2024-02-06T12:40:32.633974683Z Build Features: jemalloc Build Profile: maxperf
What database version are you on?
Current database version: 1
Local database version: 1
What type of node are you running?
Archive (default)
What prune config do you use, if any?
No response
If you've built Reth from source, provide the full command you used
No response
Code of Conduct

[X] I agree to follow the Code of Conduct

thanks!
fixed in the referenced PR


Deprecate tuning enum and trainer properties

What does this PR do?

Part of https://github.com/Lightning-AI/lightning/issues/11012
Addresses: https://github.com/Lightning-AI/lightning/pull/11089#discussion_r971871821
Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

[x] Was this discussed/approved via a GitHub issue? (not for typos and docs)
[x] Did you read the contributor guideline, Pull Request section?
[x] Did you make sure your PR does only one thing, instead of bundling different changes together?
[x] Did you make sure to update the documentation with your changes? (if necessary)
[x] Did you write any new necessary tests? (not for typos and docs)
[x] Did you verify new and existing tests pass locally with your changes?
[ ] Did you list all the breaking changes introduced by this pull request?
[x] Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

[x] Is this pull request ready for review? (if not, please submit in draft mode)
[x] Check that all items from Before submitting are resolved
[x] Make sure the title is self-explanatory and the description concisely explains the PR
[x] Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?
Make sure you had fun coding 🙃
cc @akihironitta @borda @rohitgr7 @tchaton

So many tests are failing...

yeah, forgot to remove the breakpoints.. 😅


fixed Path

I have a question / feature request.
Is it possible to have the webpack-stats.json relative path instead of the full path?
I am sharing my project with other developers, and not all of them have NPM installed. So I want to have the lastest version of the bundle in my git repository.
Is there a good way to do that?

We were doing this by extending the BundleTracker plugin:
    var RelativeBundleTracker = function(options) {
        BundleTracker.call(this, options);
    };
    RelativeBundleTracker.prototype = Object.create(BundleTracker.prototype);
    RelativeBundleTracker.prototype.writeOutput = function(compiler, contents) {
        var relativePathRoot = path.join(__dirname) + path.sep;
        _.forIn(contents.chunks, (bundle) => {
            _.forEach(bundle, (chunk) => {
                if (chunk.path.startsWith(relativePathRoot)) {
                    chunk.path = chunk.path.substr(relativePathRoot.length);
                }
            });
        });
        //contents.relativePathRoot = relativePathRoot;
        BundleTracker.prototype.writeOutput.call(this, compiler, contents);
    };
...
    plugins: [
        new RelativeBundleTracker({ filename: '.' + outputPath + 'webpack-stats.json', indent: 2 }),
    ],

A simpler and more general solution might be to allow for passing of a callback that can do any modifications you want to the contents that is about to be written.

I dont get it why this feature request is closed. I use the same workaround like @levic for half of year currently...

Fixed in https://github.com/owais/webpack-bundle-tracker/pull/29


Schema and JsonFormat annotations interaction

When fields in a class are annotated with io.swagger.v3.oas.annotations.media.Schema and com.fasterxml.jackson.annotation.JsonFormat, the schema annotation seems to be ignored.
A class specified as follows:
public class TestObject {
    @Schema(example = "10/31/2020", type = "string", format = "date"))
    private Date publicDate;

    @Schema(hidden = true)
    private Date hiddenDate;

    @Schema(hidden = true)
    @JsonFormat(
            shape = JsonFormat.Shape.STRING,
            pattern = US_DATE_FORMAT_STRING,
            timezone = REQUEST_TIMEZONE
    )
    private Date jsonFormattedDate;

}

The jsonFormattedDate is visible in the json with ISO format output and publicDate is displayed as ISO date format

I have the same issue here.


Broken in Stackblitz with Error: Cannot load native addon because loading addons is disabled: .../node.napi.glibc.node

Hi everyone,
I didn't see anything on the web about this issue, but it seems like classic-level doesn't work in the Stackblitz environment (many modules don't!)
What's the solution here? Would love a workaround!

Currently, WebContainers can only execute languages that are natively supported on the Web, including JavaScript and WebAssembly. It is not possible to run native addons which are usually implemented using native languages such as C++, unless they can be compiled to WebAssembly. Therefore, loading native addons is disabled by default via --no-addons in WebContainers. As a result, you may encounter an error that says: Cannot load native addon because loading addons is disabled.
The solution to this is to use an alternative to the native addon which is either fully implemented in JavaScript or can be compiled to WebAssembly.
— https://developer.stackblitz.com/platform/webcontainers/troubleshooting-webcontainers

TLDR, it's simply not supported.

Maybe this issue doesn't belong on this repo too since it's definitely not something I think classic-levels should add support for, but I did want to help with the SEO to direct people (if there is an alternative solution)

doesn't work in the Stackblitz environment

Stackblitz is a fork of Node.js, not Node.js itself.

@mcollina do you think anyone cares about using level in environments that don't support native/c addons? I have no idea if it's common. I can understand that "if you don't support native addons you kind of aren't NodeJS- it's an issue for stackblitz etc."
(fwiw I'm also ok w/ closing this issue/seeing if other people stumble on it over time?)
I ended up using memory-level because persistence wasn't super important for my app.

I don't know if StackBlitz provides access to web APIs like IndexedDB but if they do then browser-level is probably the best option, if you do need persistence. An alternative is https://github.com/Level/community/issues/63.
In any case, we can't add support for StackBlitz in classic-level because this module is specifically for Node.js.


Fix brew formulae and brew casks when the API is used

I'm not sure if this is an elegant solution but it gives an identical output to when HOMEBREW_NO_INSTALL_FROM_API is set, regardless of whether homebrew/core or homebrew/cask are tapped. Feel free to make any improvements.
Closes #15229

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes? Here's an example.

[x] Have you successfully run brew typecheck with your changes locally?
[x] Have you successfully run brew tests with your changes locally?

Switching to regex needed a few more changes than I expected due to the different find on macOS and Linux having different ways to turn on extended regex. sort -u is also replaced by sort -f because-u is now unnecessary thanks to the core taps being filtered out and -f is added to maintain a consistent order with sort -uf in items.sh. One interesting thing to note though is brew formulae returns an extra newline with the API enabled but brew casks doesn't. I'm not sure what causes it, whether it is dependent on the specific taps I have, or what negative effects it may cause for things like tab completion (if any). As always, feel free to make any edits.

sort -f was changed to sort -uf to maintain the existing behavior of removing duplicate short names when there are formulae with the same name in homebrew/core and a custom tap.

Thanks so much for your first contribution (hopefully of many)!  You rock, @Omoeba!


Update Datadog SDK to version 2.12.0

This PR has been created automatically by the CI
Updating Datadog SDK from version 2.11.0 to version 2.12.0: diff

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 78.31%. Comparing base (76ee187) to head (8205b62).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop     #284      +/-   ##
=============================================
+ Coverage      78.12%   78.31%   +0.20%
- Complexity       251      254       +3
=============================================
  Files             31       31
  Lines            914      913       -1
  Branches         114      114
=============================================
+ Hits             714      715       +1
+ Misses           148      147       -1
+ Partials          52       51       -1

see 2 files with indirect coverage changes


Resolve build failure using correct InSpec syntax

There's a whitespace issue, but I'll take care of that in the next hotfix PR for keep_awake resources updated.

Resolves #66


US121245 Add bongo tier 2

@cbelan-d2l hmm, the linting isn't loving the line breaks in the new SVGs you added


[Feature][Workflow relationship] Format time.

Purpose of the pull request
close #7122

Codecov Report

Merging #7123 (4d7a73a) into dev (9fffbdb) will increase coverage by 0.01%.
The diff coverage is n/a.

:exclamation: Current head 4d7a73a differs from pull request most recent head 80e06a5. Consider uploading reports for the commit 80e06a5 to get more accurate results

@@             Coverage Diff              @@
##                dev    #7123      +/-   ##
============================================
+ Coverage     40.52%   40.53%   +0.01%
  Complexity     3587     3587
============================================
  Files           647      647
  Lines         26375    26375
  Branches       2936     2936
============================================
+ Hits          10689    10692       +3
+ Misses        14689    14684       -5
- Partials        997      999       +2

Impacted Files
Coverage Δ

...he/dolphinscheduler/common/enums/SqoopJobType.java
0.00% <0.00%> (-88.89%)
:arrow_down:

...inscheduler/common/task/sqoop/SqoopParameters.java
74.00% <0.00%> (ø)

...e/dolphinscheduler/remote/NettyRemotingClient.java
53.52% <0.00%> (+1.40%)
:arrow_up:

...org/apache/dolphinscheduler/remote/utils/Host.java
40.00% <0.00%> (+2.22%)
:arrow_up:

...r/plugin/registry/zookeeper/ZookeeperRegistry.java
54.54% <0.00%> (+7.27%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fffbdb...80e06a5. Read the comment docs.


Add more ignore paths to codecov.yml

Seems like code cov is including package.json. Let's add a bunch of
paths to the ignore section.
Checklist

[x] PR is of reasonable size

This didn't seem to have any effect on code coverage. Odd. Not sure why that dependabot PR changed code coverage then.


Issue setting up own domain

I recently installed rainloop to a subdomain of my website, and I'm trying to add my own domain. How do I find my imap and smtp servers with available ports?

This is not a RainLoop issue. If you set up the mail server yourself, you should know host name/port. If you didn't, ask the one who provides the mail server. The settings are exactly the same as in any other mail client (like Thunderbird).


pragma-on-top false positive

reproducing from #117
I no longer get the error however there is an issue with the import rule as if you have experimental pragmas at the top of the file followed by imports, it throws:
^-- ERROR: Import statement must be at the top of the file.

If I move the imports at the top of the file followed by the pragmas, it then throws the expected
^-- WARNING: Pragma Directive "pragma solidity ^0.4.17;" should only be at the top of the file.

The only combination that works is if the pragma solidity ^0.4.17; is at the top, followed by the imports followed by the experimental pragmas. Which is clearly incorrect.

fixed in v1.0.8
cc @elenadimitrova


Anonymous Reviewers

Description
Ability for users to have a toggle in their profile page (by that i mean just the userpage but show some options if the user=currentuser).
Reviews would just display with "Anonymous" and default image (i'd be temted to keep the real discriminator though)
Bonus points if profile picture has different colours, based on discriminator maybe?
In relation to...
Other
Justification
Anonymity provides a shield for people to say what they really mean
Proposed Solution
No response
Additional Information
No response

As in you can leave an anonymous review or you toggle on anonymous and all your reviews turn anonymous and then toggle back?

Second one, basically an option per user to toggle the username (and image if possible) to a generic alternative

While I do really like this idea, I don't think I can justify doing a whole rewrite of the codebase to do it properly and not just show a different name and leave all the sensitive info in the user object. I may add a .env to provide a list of ids that can log in, preventing strangers from being able to see reviews


Using FaceGeometryPipelineCalculator in Python

Is it possible to use FaceGeometryPipelineCalculator through mp.CalculatorGraph() in Python on face_mesh solution output landmarks?

Hi @alexrichardson21, Thanks for sharing your query. Could you please elaborate your use case to understand the query much better. Thanks!

Hi @alexrichardson21, Could you please respond to my above comment. Thanks!

We are closing this issue as of now,  Due to lack of activity on it.


docker env variable introduce？

Thanks for the DTM project. Could you please provide a description of the Docker env variable?
      STORE_DRIVER: xxx
      STORE_HOST: xxx
      STORE_USER: xx
      STORE_PASSWORD: 'xxx'
      STORE_PORT: xxx

see: https://dtm.pub/deploy/base.html#dtm配置


Return a valid Coder for any subtype of Mutation on HBaseCoderProviderRegistrar

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

[ ] Make sure the PR title is formatted like:
[BEAM-<Jira issue #>] Description of pull request
[x] Make sure tests pass via mvn clean verify.
[ ] Replace <Jira issue #> in the title with the actual Jira issue
number, if there is one.
[ ] If this contribution is large, please file an Apache
Individual Contributor License Agreement.

R: @lukecwik

Coverage decreased (-0.007%) to 70.611% when pulling 94f6f0216ef7fcc6a1c2d7f9d929ca77a8c69116 on iemejia:simplify-hbase-coder-provider into 698b89e2b5b88403a5c762b039d3ec8c48b25b26 on apache:master.

Coverage increased (+0.007%) to 70.849% when pulling 6b6d20d9dc5afa0c1d8520cf6dbc98e6488a58a2 on iemejia:simplify-hbase-coder-provider into a40d11c8e6f9a364105972eeaaa6591711471be9 on apache:master.

Thanks for the idea and the review @lukecwik


Update Spree dependency to 3.1.0

Spree 3.1.0 release notes
Spree 3.1.0 upgrade guide

done via https://github.com/spark-solutions/spark-starter-kit/pull/26


Volume list

Closes #2202

Coverage increased (+0.2%) to 72.487% when pulling 499e8c337d17353867d44e76c06d6ba841a03cae on na3d:vol-list into 2e0a6503310838639195ab0cae002cfd45f2e71f on linode:develop.

Coverage increased (+0.2%) to 72.508% when pulling 42b1998464ec58c50e2938eca148afc29ad4e2b1 on na3d:vol-list into 2e0a6503310838639195ab0cae002cfd45f2e71f on linode:develop.

Coverage increased (+0.2%) to 72.492% when pulling fc2d2092c7a25bf640f5e3cb659b92a8e32a6d60 on na3d:vol-list into 2e0a6503310838639195ab0cae002cfd45f2e71f on linode:develop.

Coverage increased (+0.2%) to 72.485% when pulling 9ee4362458b7a10377cec954136215c65de2662c on na3d:vol-list into 2e0a6503310838639195ab0cae002cfd45f2e71f on linode:develop.

Coverage increased (+0.2%) to 72.485% when pulling 75324aae508c18ec43324bacf5de00dfcda54abe on na3d:vol-list into 2e0a6503310838639195ab0cae002cfd45f2e71f on linode:develop.

Coverage increased (+0.2%) to 72.485% when pulling e30f81c399cc44bed50be80ddfd39d5c2e94d691 on na3d:vol-list into 2e0a6503310838639195ab0cae002cfd45f2e71f on linode:develop.

Coverage increased (+0.2%) to 72.485% when pulling e30f81c399cc44bed50be80ddfd39d5c2e94d691 on na3d:vol-list into 2e0a6503310838639195ab0cae002cfd45f2e71f on linode:develop.


[1503] Extend providers endpoint

Context
Our frontend requires more of the provider data for course#preview and further down the line; editing of provider enrichments
Changes proposed in this pull request
Expose more provider data
Guidance to review
i.e. /api/v2/providers/1CS
Checklist

[x] Make sure all information from the Trello card is in here
[x] Attach to Trello card
[x] Rebased master
[x] Cleaned commit history
[x] Tested by running locally

 Expose provider enrichment data

Here's the PR that commented out those lines: https://github.com/DFE-Digital/manage-courses-backend/pull/226


Selected dates highlight on multiple inline DatePickers

Hi!
When I have two inline datepickers, one next to the other, if I change the date on one, the CSS highlight disappears on the other. I'd like to keep the highlight and the "selected" class active on both datepickers.
Is this normal behaviour, and is there any way to keep the "selected" class on both datepickers separately?

The highlight will always appear on the selected date passed into the picker.  Are you sure you're passing in the correct dates?


Create Base Objects for the standard content types

Currently there is a lot of logic that is engrained into some of the core class objects (especially site).
It would be good to introduce a little composition into the base Objects that separate attribution and functionality.
This would allow us to use the attributed class for things like typehinting or attribute checking.
This could also be accomplished using some third-party attribute builders (attrs, pydantic)

in 2023.12 updates we've added the theme_manager and plugin_manager to own much of the content. It does feel a little redundant but the separation of concerns does make things like testing easier.

A potential managers would be route manager (not a priority as we only manage a route list).


Weekdays printing NA after 28 entries

Hello,
Thank you for creating this tool!
I am working with GeneActive data that has 33 entries. I noticed that after 28 days of tracking , the weekday is not getting printed automatically, and some weekend/weekday based summaries are incorrect as a result. I looked up the source code and found that in g.analyze.R on line 445 weekdays were repeated only 28 times. I currently changed  that part for myself  and the function runs correctly in my namespace in R, but lifting that 28 day limit can potentially help other people that work with long tracking periods. Thank you!

Thanks, we will incorporate this in the next release.

Thank you!


Unable to pull/push to a registry on Centos from Docker on Windows

Expected behavior
I should be able to pull/push my image on docker on windows to a Docker registry on Centos which has been TLS enabled. The crt files has been added to both Trusted Root Certification Authorities and Intermediate Certification Authorities.
Actual behavior
x509: certificate signed by unknown authority
Information about the Issue
Steps to reproduce the behavior

Setup a docker registry with TLS enabled on CentOS
Run a push to the domain with registry enabled at 5000 port.

Resolved the issue by adding PFX to trust store and restarting docker service


Use PG environment variables to complement connection string in Connection

Attempting to use the PG environment variables https://www.postgresql.org/docs/current/libpq-envars.html, e.g.:
$ set | grep PG
PGDATABASE=timescale
PGHOST=localhost
PGPASSWORD=xxx
PGPORT=5434
PGUSER=aaa

I expected to LibPQ.Connection("") to use these vars that weren't supplied in connection string. However it seems they are not.
Am I missing something or does LibPQ.Connection() not use environment?

Funnily enough export ing my PG vars again seem to solve the issue and LibPQ.Connection() does in indeed use them. Still unsure what happened before even though I could see the vars with set command but I guess its not a problem with LibPQ!


refactor: revamped element characteristics

Download Artifacts :

win-ia32
win-x64
linux-x64

Download Artifacts :

win-ia32
win-x64
linux-x64


[Loading Flashlight models into PyTorch model] How can I load a flashlight model into a PyTorch format?

Question
Thanks a lot for the great library! With @cwkeam we are working on porting the multi-lang-CTC model: https://github.com/flashlight/wav2letter/tree/main/recipes/mling_pl into PyTorch to make it more accessible for the speech community.
The model is stored in the cereal format here: https://dl.fbaipublicfiles.com/wav2letter/mling_pl/checkpoint_cv_finetune.bin and we were wondering how to convert this format so that it can be read by torch.load(...).
Maybe is a first question:

How can one load Flashlight arrays into Pytorch tensors?

cc @lorenlugosch

Thanks @patrickvonplaten and @cwkeam for working on porting M-CTC-T!
This script by @tlikhomanenko for loading Flashlight tensors into PyTorch might help: https://github.com/flashlight/wav2letter/blob/main/recipes/utilities/convlm_serializer/save_pytorch_model.py
I'll look into this as well when I have more time.

Oh, actually that might be specifically for a convolutional model


CloudWatch section

Need to start this! (Under construction is fine.)

I'm working through this and should have something in a few days.

I believe this can be closed now?

Indeed! Thanks to contributions from both of you! @bgdnlp @JCBarry .


binding detection does not work

Multiple keystrokes without release are not properly detected and therefore the shortcut is not fired.
See for example the following Codepen. Here I just try to trap and handle "Cmd+R", when it is not properly detected it is caught Chrome and produces a page reload.
The sequence is:

press "Cmd" and do not release
press "0" (zero, like reset zoom)
press "R" (like reload page)

Use this debug page: https://cdpn.io/pen/debug/gOBvOXr?authentication_hash=ZoABapBwEZGr
The source of this repro: https://codepen.io/artola-the-decoder/pen/gOBvOXr
The expected behaviour is that after a non control key (I mean when a letter, number or symbol) is pressed, the logic should restart.
This sequence executed above: CMD + 0 + R, should be treated as CMD + 0 and CMD + R.
Here the same example refactored with mousetrap and it works as expected: https://codepen.io/artola-the-decoder/pen/zYmRxVB

I have a similar issue:

setup, command+left: action1, command+right: action2
press command and hold.
press left, and release, action1 triggered.
press right, system ring a bell warning. action 2 not triggered.

this breaks in v3.10.3, works as expected in v3.10.2

@magicdawn You can reproduce your error. https://codepen.io/jaywcjlove/pen/xxQdNQp?editors=0010
https://github.com/jaywcjlove/hotkeys-js/blob/8b8d7d968a836468b5ed09ed2abd76189cc5cdf4/src/index.js#L282
https://github.com/jaywcjlove/hotkeys-js/blob/8b8d7d968a836468b5ed09ed2abd76189cc5cdf4/src/index.js#L303

@jaywcjlove

v3.10.2 https://codepen.io/magicdawn/pen/dyQWBow?editors=1010
v3.10.3 https://codepen.io/magicdawn/pen/JjeNQYB?editors=1010

Key sequence

press command and hold.
press left and release, expect you pressed command + left
press right and release, expect you pressed command + right

v3.10.2 works as expected, v3.10.3 step 3 not showing

@magicdawn Upgrade v3.10.4

@jaywcjlove It seems that the fix does not work for the above mentioned example, upgraded to v3.10.4:
https://codepen.io/artola-the-decoder/pen/gOBvOXr

@artola https://codepen.io/jaywcjlove/pen/NWEgNqo?editors=1010
import hotkeysJs from<EMAIL_ADDRESS>
window.addEventListener("DOMContentLoaded", (event) => {
  const button = document.querySelector('button');

  button.focus();

  hotkeys('command+r,command+r+0', undefined, (keyboardEvent, hotkeysEvent) => {
    keyboardEvent.preventDefault();
    keyboardEvent.stopPropagation();

    button.innerHTML = "prevented";

    return false;
  });
});

This sequence executed above: CMD + 0 + R, should be treated as CMD + 0 and CMD + R.

Thanks @jaywcjlove. But look in my original issue, my expectation is:
This sequence executed above: CMD + 0 + R, should be treated as CMD + 0 and CMD + R.

If that is fulfilled, then the code should trap the keystrokes and avoid a page reload without changing the listeners, but it does not:
import hotkeysJs from<EMAIL_ADDRESS>
window.addEventListener("DOMContentLoaded", (event) => {
  const button = document.querySelector('button');

  button.focus();

  hotkeys('command+r', undefined, (keyboardEvent, hotkeysEvent) => {
    keyboardEvent.preventDefault();
    keyboardEvent.stopPropagation();

    button.innerHTML = "prevented";

    return false;
  });
});

@jaywcjlove

v3.10.2 https://codepen.io/magicdawn/pen/dyQWBow?editors=1010
v3.10.3 https://codepen.io/magicdawn/pen/JjeNQYB?editors=1010

Key sequence

press command and hold.
press left and release, expect you pressed command + left
press right and release, expect you pressed command + right

v3.10.2 works as expected, v3.10.3 step 3 not showing

I have a similar problem:
setup:[cmd+shift+k] and [cmd+shift+b] shortcuts

press [cmd+shift] , and hold them
press k, it worked.
release k and press b， it doesn't work.

I think may be you have fixed problem about [cmd+] but not [cmd+shift+].


vamp-ir halo2 verify exits with status 0 for invalid proofs

I'd expect invalid proofs to output a non-zero status code to indicate an error. At least the halo2 backend will print the failure, but exit as if verification had been a success.

Good catch. We are also working to improve error reporting #80 and this dovetails nicely.


[BUG] Error When Launching Custom Models with Xinference [BUG]

I executed the following command to start Xinference:
xinference-local --host <IP_ADDRESS> --port 9997
I successfully started a rerank model, bge-reranker-large, and everything worked fine. However, when I attempt to launch custom embedding models, specifically e5-mistral-7b-instruct or a custom LLM model like MetaMath-Cybertron, I encounter the error detailed below:
(inference) gpt-lab@gpt-lab-tower:~$ xinference-local --host <IP_ADDRESS> --port 9997 2024-01-08 19:23:07,544 xinference.core.supervisor 12284 INFO     Xinference supervisor <IP_ADDRESS>:12783 started 2024-01-08 19:23:07,606 xinference.core.worker 12284 INFO     Xinference worker <IP_ADDRESS>:12783 started 2024-01-08 19:23:07,607 xinference.core.worker 12284 INFO     Purge cache directory: /home/gpt-lab/.xinference/cache 2024-01-08 19:23:12,153 xinference.api.restful_api 12171 INFO     Starting Xinference at endpoint: http://<IP_ADDRESS>:9997 2024-01-08 19:23:31,724 - modelscope - INFO - PyTorch version 2.1.2 Found. 2024-01-08 19:23:31,724 - modelscope - INFO - Loading ast index from /home/gpt-lab/.cache/modelscope/ast_indexer 2024-01-08 19:23:31,852 - modelscope - INFO - Loading done! Current index file version is 1.10.0, with md5 68c0b64cc2fe9141b85988e677fba775 and a total number of 946 components indexed 2024-01-08 19:24:06,531 xinference.model.embedding.core 12284 INFO     Embedding model caching from URI: /home/gpt-lab/Bureau/models/e5-mistral-7b-instruct 2024-01-08 19:24:06,532 xinference.model.embedding.core 12284 INFO     Embedding cache /home/gpt-lab/Bureau/models/e5-mistral-7b-instruct exists Loading checkpoint shards:  50%|███████████████████████████                           | 1/2 [00:20<00:20, 20.92s/it]2024-01-08 19:25:47,995 xinference.core.worker 12284 ERROR    Failed to load model e5-mistral-7b-instruct-1-0 Traceback (most recent call last):   File "/home/gpt-lab/miniconda3/envs/inference/lib/python3.11/site-packages/xinference/core/worker.py", line 381, in launch_builtin_model     await model_ref.load()   File "/home/gpt-lab/miniconda3/envs/inference/lib/python3.11/site-packages/xoscar/backends/context.py", line 226, in send     result = await self._wait(future, actor_ref.address, send_message)  # type: ignore              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^   File "/home/gpt-lab/miniconda3/envs/inference/lib/python3.11/site-packages/xoscar/backends/context.py", line 115, in _wait     return await future            ^^^^^^^^^^^^   File "/home/gpt-lab/miniconda3/envs/inference/lib/python3.11/site-packages/xoscar/backends/core.py", line 84, in _listen     raise ServerClosed( xoscar.errors.ServerClosed: Remote server unixsocket:///3220176896 closed 2024-01-08 19:25:48,381 xinference.api.restful_api 12171 ERROR    [address=<IP_ADDRESS>:12783, pid=12284] Remote server unixsocket:///3220176896 closed Traceback (most recent call last):   File "/home/gpt-lab/miniconda3/envs/inference/lib/python3.11/site-packages/xinference/api/restful_api.py", line 444, in launch_model     model_uid = await (await self._get_supervisor_ref()).launch_builtin_model(                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^   File "/home/gpt-lab/miniconda3/envs/inference/lib/python3.11/site-packages/xoscar/backends/context.py", line 227, in send     return self._process_result_message(result)            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^   File "/home/gpt-lab/miniconda3/envs/inference/lib/python3.11/site-packages/xoscar/backends/context.py", line 102, in _process_result_message     raise message.as_instanceof_cause()   File "/home/gpt-lab/miniconda3/envs/inference/lib/python3.11/site-packages/xoscar/backends/pool.py", line 657, in send     result = await self._run_coro(message.message_id, coro)     ^^^^^^^^^^^^^^^^^   File "/home/gpt-lab/miniconda3/envs/inference/lib/python3.11/site-packages/xoscar/backends/pool.py", line 368, in _run_coro     return await coro   File "/home/gpt-lab/miniconda3/envs/inference/lib/python3.11/site-packages/xoscar/api.py", line 384, in __on_receive__     return await super().__on_receive__(message)  # type: ignore     ^^^^^^^^^^^^^^^^^   File "xoscar/core.pyx", line 558, in __on_receive__     raise ex   File "xoscar/core.pyx", line 520, in xoscar.core._BaseActor.__on_receive__     async with self._lock:     ^^^^^^^^^^^^^^^^^   File "xoscar/core.pyx", line 521, in xoscar.core._BaseActor.__on_receive__     with debug_async_timeout('actor_lock_timeout',     ^^^^^^^^^^^^^^^^^   File "xoscar/core.pyx", line 526, in xoscar.core._BaseActor.__on_receive__     result = await result     ^^^^^^^^^^^^^^^^^   File "/home/gpt-lab/miniconda3/envs/inference/lib/python3.11/site-packages/xinference/core/supervisor.py", line 573, in launch_builtin_model     await _launch_one_model(rep_model_uid)     ^^^^^^^^^^^^^^^^^   File "/home/gpt-lab/miniconda3/envs/inference/lib/python3.11/site-packages/xinference/core/supervisor.py", line 542, in _launch_one_model     await worker_ref.launch_builtin_model(     ^^^^^^^^^^^^^^^^^   File "xoscar/core.pyx", line 284, in __pyx_actor_method_wrapper     async with lock:   File "xoscar/core.pyx", line 287, in xoscar.core.__pyx_actor_method_wrapper     result = await result     ^^^^^^^^^^^^^^^^^   File "/home/gpt-lab/miniconda3/envs/inference/lib/python3.11/site-packages/xinference/core/utils.py", line 35, in wrapped     ret = await func(*args, **kwargs)     ^^^^^^^^^^^^^^^^^   File "/home/gpt-lab/miniconda3/envs/inference/lib/python3.11/site-packages/xinference/core/worker.py", line 381, in launch_builtin_model     await model_ref.load()     ^^^^^^^^^^^^^^^^^   File "/home/gpt-lab/miniconda3/envs/inference/lib/python3.11/site-packages/xoscar/backends/context.py", line 226, in send     result = await self._wait(future, actor_ref.address, send_message)  # type: ignore     ^^^^^^^^^^^^^^^^^   File "/home/gpt-lab/miniconda3/envs/inference/lib/python3.11/site-packages/xoscar/backends/context.py", line 115, in _wait     return await future     ^^^^^^^^^^^^^^^^^   File "/home/gpt-lab/miniconda3/envs/inference/lib/python3.11/site-packages/xoscar/backends/core.py", line 84, in _listen     raise ServerClosed(     ^^^^^^^^^^^^^^^^^ xoscar.errors.ServerClosed: [address=<IP_ADDRESS>:12783, pid=12284] Remote server unixsocket:///3220176896 closed
For context, I have CUDA 12.3, PyTorch with CUDA support, and two GTX 1080ti GPUs, each with 12GB VRAM.
Is the issue related to insufficient VRAM, or could there be another problem? Any insights or suggestions would be greatly appreciated

from sentence_transformers import SentenceTransformer
model = SentenceTransformer(your_model_path)

Run the code above and check if it works.

It works fine when used alone, but when running simultaneously with another model, such as bge-reranker-large, it does not work as shown in the image below. I have the impression that the VRAM resources of the two graphics cards are not being fully or correctly utilized.


Limit number of results

Hello,
Is that possible to limit the number of results per provider ?
Thanks !

@chicungunya yes, in Burst settings.


Minor code edit

(!) The names and arguments of some functions have been changed.
The code is given in a single "standard":

camelCase variables --> snake_case ;
text_draw, paint_job, text_label --> textdraw, paintjob, textlabel ;
example_1_variable, color_1... --> example1_variable, color1... ;
playerid, modelid, actorid.... --> player_id, model_id, actor_id.... ;

And more.

Hi again : https://github.com/pysamp/PySAMP/pull/99/commits/949166837592512f117b251ca1020c7720d16a4a#diff-fdd6d9bd391be82a048c2bf8118dfd479302fb73017aa3f359abb60235ca612cR1980
Here I think the argument name is misleading. It is a boolean argument and the argument name could indicate its a list of names.. Wouldn't it be better to keep the legacy naming on these functions as they are directly wrapping the pawn natives? 😊 The same goes to the other function wrappers that take booleans.

For example here we need to be super careful with argument naming, as a "true" value here: https://github.com/pysamp/PySAMP/pull/99/commits/949166837592512f117b251ca1020c7720d16a4a#diff-172ce6dd858ee66b6f2a93357f8347a1983fb80fe00eb778510ed08b1e85e60fR219
Will disable. Without the correct argument name, its hard to know what the boolean does. Otherwise we need to explicitly state it in docstring (for visibility) :)

Also these removed newlines will break the sphinx documentation, so please revert these changes done with newline removals before and after tables, notes and macros where this is done https://github.com/pysamp/PySAMP/commit/949166837592512f117b251ca1020c7720d16a4a#diff-f9c6d43524893ca43d296c52a6ec7948b387a05f56f13a2adba62b0e425fef68L204

Also these removed newlines will break the sphinx documentation, so please revert these changes done with newline removals before and after tables, notes and macros where this is done 9491668#diff-f9c6d43524893ca43d296c52a6ec7948b387a05f56f13a2adba62b0e425fef68L204
You can test documentation generation locally by installing the requirements.txt modules, and then enter pysamp/docs and run make html In order to check the result you can run a local webserver and enter the generated HTML files locally inside the docs folder 👍

This happened due to copying from Github, I didn't notice)

Most of these are great, thanks! Some of these I'm not sure I agree with, eg. the ones that revert changes to argument names that we purposefully made more explicit ; but more generally, can you please rebase this onto main since @Ykpauneu fixed some of these already? Thanks :-D


mongo wrappers

Changes:

Added glry_core/glry_persist.go with helper funcs that will reflectively insert fields
Added missing quote on struct tag
Accidentally Added incoming changes to main because I suck at git

Considerations:

Reflection is dangerous but in this case prevents us from having to write separate wrappers for each type being inserted into the database. A possible option that would allow us to avoid reflection would be to write an interface that has funcs such as CreateId() GLRYdbId, SetVersion(ver int64), SetLastUpdated(time float64), and SetCreationTime(time float64) and ensure that each struct we are using as a mongo document implements that interface. This will increase type safety but require us to implement each of those funcs for each of the structs.
Do we need an individual id type for each structs id field or can we use GLRYdbId like I have implemented? I cannot think of a way to generically fill id field if the type of the id differs from struct to struct
Is there a better package to put glry_persist.go?
Currently the GLRYpersister interface is general enough where if we decided we hated mongo and wanted to move somewhere else to a different database provider we could. Because of this, however, each implementation then requires us to check make type checks to ensure fields are of types that correspond to mongo options, etc.. Should GLRYpersister be this generic or should we assume that mongo is going to be our provider and switch fields with interface{} to *options.SomeMongoOptions

first off, this is tremendous work. wow!!!
so my understanding was that we would write wrappers around the ones we're currently using with gf_core, such as Mongo__insert, MongoFind, etc. these wrappers would receive the bson.M queries and simply append things we know we'd like to append, like creation time, filtering out "deleted": true, and so on. did not expect such low level wrappers!
happy to discuss in person, but again, whatever makes sense for your setup and would be most helpful to you. if we do take things into our own hands, i'd be curious if we can store and edit deep objects, such as nested objects or slices.

This will increase type safety but require us to implement each of those funcs for each of the structs.

yeah that seems like overkill haha

Do we need an individual id type for each structs id field or can we use GLRYdbId like I have implemented? I cannot think of a way to generically fill id field if the type of the id differs from struct to struct

let's use a general ID. in fact, i'm down to moving away from having it be dependent on any parameters (such as ...Fields) and simply generate an md5 based on timestamp. collision should be minimal if we use nanosecond-level precision

Is there a better package to put glry_persist.go?

makes sense where it is!

Should GLRYpersister be this generic or should we assume that mongo is going to be our provider and switch fields with interface{} to *options.SomeMongoOptions

i vote we assume we will be sticking with mongo in the medium to long run, no need to overengineer at this stage

so my understanding was that we would write wrappers around the ones we're currently using with gf_core, such as Mongo__insert, MongoFind, etc. these wrappers would receive the bson.M queries and simply append things we know we'd like to append, like creation time, filtering out "deleted": true, and so on. did not expect such low level wrappers!

Newest commit uses gf_core instead of mongo lib. My only hesitation here is that gf_core does not allow us to specify any mongo specific options for insertion or updating and inconsistently does allow for mongo options on the find func. It is also inconsistent about using the mongo.Collection type versus passing in a string and having the collection be established under the hood. If you look at gf_core.Mongo__insert's parameters versus gf_core.Mongo__upsert you can see that one takes a string for collection and one takes the type *mongo.Collection. Either way, looking at gf_cores mongo funcs reveals that they are mostly to gracefully handle mongo errors with gf_core.Gf_error so we could go either way and it should be fine.
Also forgot to include the deleted: true in my initial commit, added it in most recent commit.

let's use a general ID. in fact, i'm down to moving away from having it be dependent on any parameters (such as ...Fields) and simply generate an md5 based on timestamp. collision should be minimal if we use nanosecond-level precision

Sounds good, reflected in newest commit.
Finally, the reason why the insert and update seem so low level and use reflection is because upon insertion and update, we are using structs with bson tags instead of a bson.M or bson.D. It's easy to append values to a bson.M or bson.D but unfortunately requires reflection for hot-insertion of fields on a struct. For Find(), however, we are using a bson.M as a filter which can be appended to and therefore does not require reflection, yay!

@bennycio thank you for the thorough explanations! i remember our discussion now, makes sense to have lower level control over the mongo library especially if we can only upsert from gf_core

For some reason in most recent commit, the update method requires that the bson id field has ,omitempty or it complains that we can't update an immutable field. The current update being used for the db nft does not have this problem but I cannot see a difference between that update and this more generic update other than the reflection. If anyone can figure out why this might be happening I would be very happy!

PR looking pretty good at this point with aggregation able to solve the problem of filling nested documents. Something to consider now is that most our find operations are being decoded and unmarshalled directly onto a struct. This works because in the db, each document holds its sub documents as an array of strings (array of ids) which corresponds to the go structs which also hold an array of strings for ids. In aggregation, however, the returned set of documents replaces that array of strings to an array of sub documents which does not correspond to the go struct meaning we cannot directly unmarshall this onto any struct. We have a few options plus anything anyone else can think of:

We replace the struct field of array of ids to an array of structs and ensure that on insert, rather than adding each struct we loop through the child structs and only add the id. This would make the insertion process a bit more complicated and more manual.
We create a copy struct where the only difference is that instead of array of ids there are arrays of structs. This would cause some code duplication but to make it clear we could name them something like GLRYnftInsert and GLRYnft/GLRYnftResponse seeing as the one with the array of strings will most likely only be used during the insertion process.
We do not even unmarshall onto a struct and instead turn it straight into json to be returned by the api. This would our options with regards to handling the data on the backend before it reaches the front end but if all we are doing is finding and returning data without touching it in between, this could work.
Two struct fields for the array of string ids and the array of structs. This could cause some inconsistencies where a struct might have both arrays filled (duplicate information) or just one filled.

Let me know what you think!

@bennycio thank you for the analysis. i think we should definitely go with option 2, which is to create a separate struct that represents the response from the aggregation query, regardless of code duplication. aggregations are super flexible and we can return all kinds of custom data that may look very different than simply an embedded object (such as adding a new "count" field that represents how many documents were returned, etc.).
we should decouple the structs and have two separate representations, i.e., the shape of the stored data vs. the shape of the exposed/returned data


iOS checks isMainThread before UIApplication is started

https://github.com/tomaka/winit/blob/808638fee3967d02023b02de2b90caaddb2d2f65/src/platform/ios/mod.rs#L212
Does this actually work?
isMainThread will return false  if it's checked outside UIApplication and as far as I can see, the event loop is created before the Window and it's the Window that starts UIApplication

Why did you close this?

I wasn’t sure how the jmp stuff works, since I assume it works I guess it’s because a UIApplicationMain is already setup somehow magically.

The app finishes launching before anything in the setjmp block is executed, but that happens in Window::new, not EventsLoop::new. The isMainThread check will thus always happen before UIApplicationMain, at least as far as I can tell.

It's quite possible that it's never really been tested, and might've just been added at the same time as the equivalent check on macOS.

I will look into this as part of the EventLoop 2.0 rewrite.

It has the expected behavior in my simple tests (returns false on a pthread other than the main thread, and true on the main thread even before UIApplicatinMain), and this SO post backs that up (SO is never wrong right?).
On the other hand, I couldn't find any documentation explicitly saying that this was OK.

I haven't found any documentation that suggests this wouldn't be okay, and since it works, I think we're safe!


Update replication-with-sql-database-managed-instance.md

We need to address documentation discrepancy,  leading to misconfiguration, when customers using Access Key instead of Connection String.

@alvorob : Thanks for your contribution! The author, @MashaMSFT, has been notified to review your proposed change.

#sign-off


Generate .d.ts bundle from source

I nerd-sniped myself in https://github.com/sveltejs/kit/pull/9895#issuecomment-1546652246 — I've created a small library, dts-buddy (couldn't think of a better name), for generating .d.ts bundles.
It's currently missing two important features:

[x] only exporting the things you actually want to export, instead of everything
[ ] sourcemaps

Also, virtual modules like __sveltekit/environment are currently a TODO. We also need to

[ ] update the doc generation logic

Once those things are fixed, I think this gives us the best of all possible worlds — everything is derived from source (no more duplicating function definitions inside the hand-authored .d.ts files), and 'go to definition' will finally work properly. We also get to delete a bunch of stuff.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

[x] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
[ ] This message body should clearly illustrate what problems it solves.
[ ] Ideally, include a test that fails without this PR but passes with it.

Tests

[ ] Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

[ ] If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

This basically works, which I'm quite excited about. Particularly since posting a Twitter poll that shows overwhelmingly that developers are frustrated with not being able to go to source when using libraries:

The one thing I can't figure out a solution for is the ActionFailure stuff. Basically, the generated types in $types.d.ts that are responsible for exporting a SubmitFunction<Success, Failure> referenced here...
https://github.com/sveltejs/kit/blob/e5636893ac8cfbdec27cb10f4ab32f7c59145c47/packages/kit/src/core/sync/write_types/test/actions/%2Bpage.server.js#L39
...are instead exporting a SubmitFunction<Success & Failure, never>, because T extends Kit.ActionFailure is misfiring. The solution eludes me. If someone can think of a smart way to handle this, they will have my eternal gratitude.
There's a couple of other problems to fix, but that's the biggest I think.

One compromise — had to expose __sveltekit/paths and __sveltekit/environment. Couldn't come up with a better solution that wouldn't have involved a lot more work.
That said, I realised just now that we're currently messing up by referencing these modules anyway, and need to come up with a different solution. Both of them indirectly reference the app version, which defeats the goal of maintaining hash stability between deployments. I therefore think we need to rethink how that's implemented, but that's out of scope of this PR so I'm going to punt on it for now.


Rancher UI: Reduce the Number of Steps Associated with Branching for a Release

We currently have a lot of manual chores associated with releasing the UI repo, which can be time-consuming and prone to human error. To streamline the process and reduce the number of steps, we can consider the following:

Modify build-static to read the version number from the package file automatically instead of manually updating the version number.
Update drone.yaml to fetch the version number from the git branch or tag to avoid manually updating the version number.
Parametrize the version number in the README.md file and use the git branch, if possible, to avoid manually updating the version number.
Explore using the GitHub version bot to automate the release process and bump the release for each version.

We will continue to release Rancher UI for the foreseeable future, so automating these steps will help improve efficiency and reduce the chance of keying errors during our release process.
Example
This is an example of all the steps performed each time we branch Rancher UI for a release:

https://github.com/rancher/ui/pull/5013/files

This would align nicely with what the backend is targeting: cutting an RC or doing a release without manually pinging UI.


Adding a CSS class to identify the Test panel button

This will allow plugin authors to style test panel button.

cherrypicked


add rule no-absolute-imports

i need this to rewrite absolute import paths of a web app
to make it work on github pages, where i need relative import paths

I'll publish it later to npmjs

thanks
no need to hurry with publishing

test script in
https://stackoverflow.com/questions/68788133/how-to-convert-absolute-imports-to-relative-imports-with-rollup-js/78002835#78002835


Create .travis.yml

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@339448f). Click here to learn what that means.
The diff coverage is n/a.

:exclamation: Current head 04fdae0 differs from pull request most recent head 8cce91c. Consider uploading reports for the commit 8cce91c to get more accurate results

@@           Coverage Diff           @@
##             main       #1   +/-   ##
=======================================
  Coverage        ?   39.58%
  Complexity      ?       10
=======================================
  Files           ?        1
  Lines           ?       48
  Branches        ?        9
=======================================
  Hits            ?       19
  Misses          ?       24
  Partials        ?        5

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 339448f...8cce91c. Read the comment docs.


Fixes issue with replacing the root node

Is it straightforward to test this?  @Hixie

The CL is fine.  We need to get into the habit of testing things when we fix them.  We're starting to reach a point in the project where we need a bit more stability.
lgtm.


Measuring duration of beforeAll, afterAll, beforeEach, afterEach

Hey!
Is it possible somehow to get information about tests beforeAll, afterAll, beforeEach, afterEach duration?
For some integration tests I have complex setup and want to be aware how long it takes as test execution duration seems not include execution of those steps.
Thanks in advance for any suggestions! As I couldn't find anything for now I just measure duration manually and log it in test logs but it is very hacky and hard later retrieve those times.
Regards,
Sebastian

@sebarys Sorry for the late response, I don't really have a good solution, but perhaps Informer combined with Reporter can be a better options than logs, here's some info for Informer in its scaladoc:
https://www.scalatest.org/scaladoc/3.2.14/org/scalatest/Informer.html
Hope this helps.
Cheers.


Making yoga template fully responsive

Issue Type:

[x] Bug Report
[ ] Feature Request
[ ] Documentaion

Describe the bug
There is a folder named Yoga template in the Cool-Front-End-Templates repo. Make that template fully responsive.
Screenshots

I Would like to work on this issue under GSSoC'22.

@abhinav80066 go ahead

@abhinav80066 do you have any updates? If the PR is not submitted within 3/4 days, the issue would be passed onto to you @pujthej

@VidhiBhatt01 Hi it's been 7 days can you assign this to me?

@pujthej go ahead


Improve logging

Log end of epoch information to file

@Devin-Taylor How do you feel a

@alecokas can we close this now? Changes have been merged.


remove hotfix

@adebowaledaniel this fixes the "or True" thing from the previous PR... I should have just fixed it in that one but needed to merge to make something else work. Now the tests pass.


Could not open CONNECT tunnel with proxy

Hey there,
Would love to test your project, but looks like it's not working anymore today
Or maybe I just use it the wrong way...
All my requests look like:
Could not open CONNECT tunnel with proxy zagent1495.hola.org:22222 [{'status': 403, 'reason': b'Auth Failed'}]
or
Connection was refused by other side: 61: Connection refused.
Thanks,
Tim

Hello,
I don't experience such problems, not sure why they've banned you.


feat(zetaclient): disable EIP-1559

Related:

https://github.com/zeta-chain/node/issues/3221

Shouldn't the base branch be v23?

We also need the ZetaClient to not vote new priorityFee, this is actually what would mitigate the bug in the gas stability pool logic

With recent changes, all EVMs should have observer.priorityFeeConfig.supported = false which effectively forces priorityFee to zero for all votes


⚠ TROJAN 🇺🇸 United States USO 1 has degraded performance

In e122e41, TROJAN 🇺🇸 United States USO 1 (https://ust-2.opensvr.net/) experienced degraded performance:

HTTP code: 200
Response time: 19052 ms

Resolved: TROJAN 🇺🇸 United States USO 1 performance has improved in c0c88ea.


💡 [REQUEST] - Images should be placed from top if it's portrait and should come in middle if it's landscape.

Start Date
No response
Implementation PR
No response
Reference Issues
No response
Summary
Currently, the behavior for portrait and landscape images in the story container needs to be adjusted. For portrait-oriented images, the images should be aligned to the top of the container.
For landscape-oriented images, they should be centered vertically within the container to maintain visual balance and proper user experience. This change would enhance the way stories are displayed, ensuring better visual adaptability for different image dimensions.
Basic Example
No response
Drawbacks
No response
Unresolved questions
No response

I would like to work on this issue

Hi..
Intrested to work in this issue.
Can you please assign it to me?

@SiddhanthKapoor , Do you have any updates on this issue ?

@SiddhanthKapoor , Do you have any updates on this issue ?

yes , I'll be making a pull request within 2 days

@SiddhanthKapoor I suggest you to check out this #54 PR, as i think this issue has been fixed here, you can try adjusting the height of story view. so that it appears in a single viewport without scrolling in desktop or mobile view.

Done !


Fix plugin name and URL

I found and then fixed a broken link of text-plugin-ruby and also fixed its name.

GoGo！

LGTM 💛


Allow apps to handle partial datatype tag match

Currently, datatype tags are mainly matched with strict array comparison; all elements, all in order - rather than a partial matching order independently.
In a sense, I need to update the comparison logic to use something like $all operator in mongoDB
Then, we could start allowing our apps to set more specific datatype_tags and still allowing user to find datasets that matches datatype tag criteria.

As far as I know, there is no code that's doing the tags array comparison without using $all.  I am not sure why I thought I needed to open this issue, but if there is any occurrence of such issue, I will need to treat it as a bug fix.