[ci] Mount buildkite agent on Docker container to upload benchmark results

CI AWS pipeline is not showing benchmarks results on the build because the buildkite agent is not living in the Docker container that benchmark job runs in. This is to mount BK agent in the container and fix the path to buildkite-agent so results can be uploaded and displayed on the BK build.

It's now not showing in GCP build but I think it is fine for now!


fix: update svelte to 3.37.0

Incidentally this fixes #149.
TODO:

[x] add tests that this doesn't break older versions of Svelte before the mount/disconnected fixes
[x] figure out why svelte 3.38.0 causes one of the tests to break

Hm, this causes a memory leak because disconnecting the custom element no longer destroys the Svelte component, which means that the ResizeObserver action's destroy() is never called. Interesting puzzle.

Realized tests for old Svelte probably aren't possible. I think since I'm not going to make Svelte a peerDependency I should just add a note to the readme that if you're using import Picker from 'emoji-picker-element/svelte' then you should make sure it's a roughly compatible Svelte version.

The failed test in Svelte 3.38.0 is due to changing the order of items in a keyed each block, so it looks like the same issue as https://github.com/sveltejs/svelte/issues/6444
Svelte 3.38.0 also seems to increase the code side a fair amount, apparently due to hydration code being added, even though the component is not hydratable. Seems due to: https://github.com/sveltejs/svelte/commit/10e3e3dae8dbd0bf3151c162949b8bf76dc62e8b

I filed a bug about the size increase: https://github.com/sveltejs/svelte/issues/6462
Due to that and the keyed each bug, we'll probably want to hold off on updating to Svelte 3.38.0+ for now.


Fix a issue in BundlePlugin

When I do gradle in Small/Android/DevSample, I get a message:
FAILURE: Build failed with an exception.

* Where:
Build file '/xxxx/Small/Android/DevSample/build.gradle' line: 24

* What went wrong:
A problem occurred evaluating root project 'DevSample'.
> Failed to apply plugin [class 'net.wequick.gradle.AppPlugin']
   > Cannot invoke method startsWith() on null object

It'll throw java.lang.NullPointerException from BundlePlugin if we don't specified the gradle task, so I did something to fix.
And it works:
Welcome to Gradle 2.6.

To run a build, run gradle <task> ...

To see a list of available tasks, run gradle tasks

To see a list of command-line options, run gradle --help

To see more detail about a task, run gradle help --task <task>

BUILD SUCCESSFUL

Nice work. Thanks.


procmail: unbreak "make install"

procmail's Makefile lacks a ".PHONY: install" line, which turns "make
install" into a no-op, at least on macOS.  Insert one.
Motivation for this change
nix-env -i procmail would not install anything into the store.
Things done

[ ] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[ ] NixOS
[X] macOS
[ ] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[X] Tested execution of all binary files (usually in ./result/bin/)
[X] Fits CONTRIBUTING.md.

make install works fine on linux, so could you please mention in the comment that this is a mac-specific fix?  Otherwise somebody might accidentally remove it in the future.
LGTM otherwise.

It'd be nice to have upstream fix this. It's their bug.

I don't think upstream is active anymore as http://www.procmail.org/ is down and latest release is from 2001 according to Wikipedia.

Bjørn Forsman<EMAIL_ADDRESS>writes:

It'd be nice to have upstream fix this. It's their bug.

It would, but procmail hasn't had an upstream for probably a decade or
so.

Gabriel Ebner<EMAIL_ADDRESS>writes:

make install works fine on linux, so could you please mention in the
comment that this is a mac-specific fix?  Otherwise somebody might
accidentally remove it in the future.

Good point, done.  Thanks for the review!


Add Function Formatting via LaTeX in Sphinx

There are various areas in the docstrings where formulae are present. Having this formatted properly to play nicely with LaTeX would be optimal.
Tutorial for using LaTeX to generate formulae inside of sphinx.

@tgsmith61591 I will do my best to identify these areas and reformat. Please notify me of areas that do not have a formula where it would be advantage to put one and I will do so :)

[ ] n_iter and cv of skutil.h2o.H2OGainsRandomizedSearchCV
[ ] main docstringskutil.h2o.H2OInteractionTermTransformer
[ ] clean up one-offs in the process:

I have created a pull request pull #15 to pull the changes into this repos LaTeX branch. The idea is to let travis hit the changes before we feel comfortable merging into develop :).

pull #15 resolved so closing issue.


Animation stuck in initial state after calling Anim reset

Thread: https://forum.playcanvas.com/t/anim-system-issues/26559
Project https://playcanvas.com/project/957771/overview/unable-to-transition-after-reset
Repro steps:
Press P to start Punch Animation
Press R during any time of the animation to call reset() on the anim component
Animation is back in Idle
Press P again
Expected Result is that the punch animation should play again but it does not

Fixed in #5392


Adding mbed-os/features/storage to mbed/features/storage (before dele…

Overview
This PR relates to the work item listed below:

From: Sam Grove
Sent: 21 July 2016 05:04
Subject: Re: Path to 16.07 Public Release

Update EoD 20th July

Software / Docs / Integration:
4.	[Simon H.] Move mbed-os/features/storage to mbed/features/storage – working with brian on GCC only tests and failure with GCC build flag change
4.1.	Requires update to core.lib and Delete mbed-os/features

Status
This PR should not be merged until the regression tests can be successfully run on master without this PR being accepted. I have been unable to do mbed test --run on the test and get them to run. This may be the new tools PR here:
Adding test frameworks and test sources  #2197
https://github.com/mbedmicro/mbed/pull/2197
or a problem around my setup.

This PR should not be merged until the regression tests can be successfully run on master without this PR being accepted. I have been unable to do mbed test --run on the test and get them to run

cc @bridadan @sg-

https://github.com/mbedmicro/mbed/pull/2250

https://github.com/mbedmicro/mbed/pull/2233

https://github.com/mbedmicro/mbed/pull/2250


Umang-Hello world

What does this PR do?
What issues does this PR fix or reference?
#
The PR fulfills these requirements:
[ ] Tests for the proposed changes have been added/updated.
[ ] Code linting and formatting was performed.
Functionality Before
<insert gif and/or summary>
Functionality After
<insert gif and/or summary>

Change from Umang_1606


Bank Account - "Please provide a valid website" error is shown

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: v9.0.43-2
Reproducible in staging?: Y
Reproducible in production?: Y
Issue was found when executing this PR: https://github.com/Expensify/App/pull/49957
Email or phone of affected tester (no customers<EMAIL_ADDRESS>Issue reported by: Applause Internal Team
Action Performed:

Log in to an account
Create a workspace > Enable Workflow > Connect bank account > Connect online with plaid
Continues the flow until you reached "Company website" page
Write invalid email
Click "next"
After the error is show, clear the invalid email and go back.
Return to "Company website" page

Expected Result:
"Please provide a valid website" error is not shown
Actual Result:
"Please provide a valid website" error is shown and it is not dismissed even after navigating back
Workaround:
Unknown
Platforms:

[ ] Android: Native
[x] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos
https://github.com/user-attachments/assets/d476d2c7-58d4-416e-ba6b-6e00a1e641f0

View all open jobs on GitHub

@anmurali  FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

Proposal
Please re-state the problem that we are trying to solve in this issue.

"Please provide a valid website" error is shown and it is not dismissed even after navigating back

What is the root cause of that problem?

The company website has company tax as its previous step.

When we start the bank account until reach company tax. Now click the "Next" button will call UpdateCompanyInformationForBankAccount with website data is "". There is no error returned by BE here.

Then, it redirects to company website. Here when we type something like "https://123" and then reset to "https://", it saved website: https://" to the reimbursementAccountDraft```.

Then we go back to company tax page. Here, if we click "Next" button, it will call UpdateCompanyInformationForBankAccount with website data is "https://" and it is invalid value and as a result, BE returns onyx error:

{
    "onyxMethod": "merge",
    "key": "reimbursementAccount",
    "value": {
        "errors": {
            "1727918521418387": "Please provide a valid Website"
        }
    }
}

So the "Please provide a valid Website" error message is shown.

What changes do you think we should make in order to solve the problem?

When we are in company website page and go back, we need to clear the reimbursementAccountDraft.website if its value is https://.

So in here we introduce a ref const websiteRef = useRef() to keep track the company website input. Then add onChangeText={(t) => (websiteRef.current = t)} to InputWrapper.

Finally, add cleanup function:

    useEffect(() => {
        return () => {
            if (defaultWebsiteExample === websiteRef.current) {
                BankAccounts.addBusinessWebsiteForDraft(null);
            }
        };
    }, []);

What alternative solutions did you explore? (Optional)

Proposal
Please re-state the problem that we are trying to solve in this issue.

"Please provide a valid website" error is shown and it is not dismissed even after navigating back

What is the root cause of that problem?

The company website is a step that occurs after the company tax step.

When starting the bank account setup and reaching the company tax page, clicking the "Next" button triggers the UpdateCompanyInformationForBankAccount function, passing the website data as "". No error is returned by the backend here.

Next, it redirects to the company website page. If you input something like "https://123" and then reset it to "https://", the system saves website: "https://" in the reimbursementAccountDraft.

When navigating back to the company tax page, clicking the "Next" button again triggers UpdateCompanyInformationForBankAccount with the website data as "https://", which is an invalid value. As a result, the backend returns an Onyx error:

{
    "onyxMethod": "merge",
    "key": "reimbursementAccount",
    "value": {
        "errors": {
            "1727918521418387": "Please provide a valid Website"
        }
    }
}

So the "Please provide a valid Website" error message is shown.

What changes do you think we should make in order to solve the problem?

When we are in company website page and go back, we need to clear the reimbursementAccountDraft.website if its value is https://.

So in here we introduce a ref const websiteRef = useRef() to keep track the company website input. Then add onChangeText={(t) => (websiteRef.current = t)} to InputWrapper.

Finally, add cleanup function:

    useEffect(() => {
        return () => {
            if (defaultWebsiteExample === websiteRef.current) {
                BankAccounts.addBusinessWebsiteForDraft(null);
            }
        };
    }, []);

What alternative solutions did you explore? (Optional)

The above useEffect can be:

    useEffect(() => {
        return () => {
            if (!ValidationUtils.isValidWebsite(values.website)) {
                BankAccounts.addBusinessWebsiteForDraft(null);
            }
        };
    }, []);

Proposal
Please re-state the problem that we are trying to solve in this issue.
Bank Account - "Please provide a valid website" error is shown
What is the root cause of that problem?
Error is not clearing at the time of previous page.
https://github.com/Expensify/App/blob/3b15d846bbe591631f05604fd6a512c2acbd6247/src/pages/ReimbursementAccount/BusinessInfo/BusinessInfo.tsx#L111-L113
What changes do you think we should make in order to solve the problem?
Code should be like this
 } else {
 FormActions.clearErrorFields(formId);
 FormActions.clearErrors(formId);
     prevScreen();
 }

What alternative solutions did you explore? (Optional)

Not overdue, issue is assigned to @mkzie2

@ishpaul777 is paid
@mkzie2 - your offer is here

@mkzie2 - your offer is here

@anmurali I accepted, it can be paid out and closed


Bug: Doesn't suggest anything for first tag in a list

Can you reproduce this? I find it hard to believe that you wouldn't have noticed it! So I guess it's something weird happening with my setup. I'm on Debian/Linux.
To reproduce:

Create a note with the following content:

---
tags: []
---

Start typing a tag between the brackets. No tag suggestions appear.
Type the first tag followed by a comma and space (or even just the comma and space with no tag before it):

---
tags: [sometag, ]
---

Start typing a second tag, and the tag suggestions appear as expected.

Had the same problem on Windows. As a workaround, adding a space after the opening bracket seems to let the first tag use autocomplete as expected.

Had the same problem on Windows. As a workaround, adding a space after the opening bracket seems to let the first tag use autocomplete as expected.

Same here on OS X 11.6.5 with Obsidian v0.14.2.

I am also running into this problem on linux

Had the same problem on Windows. As a workaround, adding a space after the opening bracket seems to let the first tag use autocomplete as expected.

Same bug and same workaround here on MacOS Monterey 12.3.1 and Obsidian v0.14.5.

Same problem on Linux here, hope it get fixed soon, and thank you for this very needed plugin.


Bitmap index performance results

What changes were proposed in this pull request?
Based on #349 and #350, three metrics are added. All of them are significantly reduced.

index file size.
query time.
index creation time.

How was this patch tested?
mvn clean test package

lgtm. pending on code conflict

Just fixed. Thanks Linhong!


samples: migrate samples from GoogleCloudPlatform/java-docs-samples /vision/automl

@eaball35 PTAL It should be fixed now.


Dev/2.1.2

Codecov Report
Base: 19.30% // Head: 19.61% // Increases project coverage by +0.31% :tada:

Coverage data is based on head (c0d9f0d) compared to base (f184fd7).
Patch coverage: 97.29% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main       #7      +/-   ##
==========================================
+ Coverage   19.30%   19.61%   +0.31%
==========================================
  Files          32       32
  Lines        5324     5250      -74
  Branches      889      829      -60
==========================================
+ Hits         1028     1030       +2
+ Misses       4279     4204      -75
+ Partials       17       16       -1

Impacted Files
Coverage Δ

guitool_ibeis/api_item_model.py
16.88% <83.33%> (+0.43%)
:arrow_up:

guitool_ibeis/__init__.py
69.84% <100.00%> (+37.46%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Create React App

I am not sure if this should be possible at all but I will leave it here anyways:
After deploying an app that was created with create rect app I am getting this warning:
> (node:310) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 1): Error: Exited with code 3
And in the browser:
Failed to compile.

Error in ./src/index.js
Module build failed: Error: EACCES: permission denied, mkdir '/home/nowuser/src/node_modules/.cache'
    at Error (native)
 @ multi main

Try this: https://github.com/xkawi/create-react-app-now

I was getting a similar error, @0xsven . What ended up working was running create-react-apps's build script and subsequently using [now serve](https://github.com/zeit/now-serve) to ns build.

@kevmannn
I might be doing it wrong but ns build . or ns build are telling me: Specified path doesn't exist!

Hello @0xsven. Do you have this resolved?
Here is a step-by-step for using create-react-app with now-serve. The steps assume that you have already installed now-serve and create-react-app.

create your react app: create-react-app hello-world
go into the created react app: cd hello-world
build your react app for production: npm run build
deploy with now serve, ignoring any warnings (see note below): ns build

I tested these exact steps and they worked for me. Looking at your posts, maybe you left out step 2 or 3.
Let us know if this resolves your issue so we can either close it or get your system working.
Note: One of the files created by the create-react-app will be larger than 1MB and will not be included in the now deployment unless you have a pay plan. The good news is that this file is a .js.map file and will not be required for your site to function.

@codyzu
This worked! Thank you.
now and react. Such a powerful combination.

@0xsven great! Glad to read you got this worked out and I agree... now is real game changer!
Happy deployments!!!

According to Zeit, now-serve has been deprecated: https://zeit.co/blog/now-static
I feel like there should be better instructions somewhere regarding how to correctly deploy create-react-app on Now. The blog post is vague and not completely helpful.

With now-serve being deprecated, I'm trying to use the now command and getting the cache error noted above.

The error sounds like it's starting the dev server after deployed...

Following helped me, actually should work for any SPA. Add serve module to package.json dev dependencies and custom "now-start" script:
#yarn add --dev serve

//package.json
"scritps"
    "now-start": "serve ./build --single"

I'm deploying the build folder like suggested above, but how do you handle a catch all route to load index.html on every route with create-react-app and Now?

This comment seems like the best way to deploy CRA to Now: https://github.com/zeit/now-cli/issues/160#issuecomment-276235888
It essentially mimics what now-serve did.


Added Accept header in http client to be specification conform

Added Accept header in http client to be specification conform
See http://www.jsonrpc.org/historical/json-rpc-over-http.html#http-header

Thanks for providing the reference.  I may need to look at the response HTTP status as well.  I'm not sure if xmlrpc uses a similar table to correlate application level fault codes to HTTP status and whether many clients really do anything with it.

Okay. I wanted to integrate it in an infrastructure that has set up an
JSON-RPC server with the qjsonrpc library (C++/Qt), that's how I got to
the missing header.
On 23.07.2015 18:28, Steve Gieseking wrote:

Thanks for providing the reference. I may need to look at the response
HTTP status as well. I'm not sure if xmlrpc uses a similar table to
correlate application level fault codes to HTTP status and whether
many clients really do anything with it.
—
Reply to this email directly or view it on GitHub
https://github.com/sgieseking/anyrpc/pull/1#issuecomment-124160008.


Fix core not found issue for SyntheticGCWorkload_DoubleMap_J9

running test in REPORTDIR in order to archive core file

Signed-off-by: Renfei Wang<EMAIL_ADDRESS>

Please provide the Grinder link. Thanks

It’s in internal Jenkins: job/Grinder/6279/


Does 1.5.0 not suppurt CUDA 9.1? It worked with CUDA 9.0 but not 9.1

I installed 1.5.0, and tying to import tensorflow, but it said that 'cannot find cudart64_90.dll'.
Then I installed the CUDA 9.0, and then everything works fine.
So I want to make sure than does 1.5.0 not support CUDA 9.1 or I have something installed wrong?

@richardmark Following instructions to install Cuda 9.0 on Ubuntu (apt-get) doesn't work, it will still install 9.1.

It works for me, but you have to specify the version so that it won't pick 9.1 automatically. Steps:

apt-cache show cuda | grep Version
Write down the full 9.0.? version
apt-get install cuda=FULL-VERSION-CODE

Also, make sure to run apt-get update before any of this, after you download the installer for 9.0.

@rubenlg i followed the instructions on NVIDIA website:
wget http://developer.download.nvidia.com/compute/cuda/repos/ubuntu1604/x86_64/cuda-repo-ubuntu1604_9.0.176-1_amd64.deb
dpkg -i cuda-repo-ubuntu1604_9.0.176-1_amd64.deb
apt-key adv --fetch-keys http://developer.download.nvidia.com/compute/cuda/repos/ubuntu1604/x86_64/7fa2af80.pub
apt-get update
apt-get install -y cuda
The above doesn't work. I will try your suggestion, thanks.

i'm using cuda 9.1 and cudnn 7.1.13 with tensorflow 1.5.0 building from the source ,my laptop configuration i5 4200h 8go ram and gtx950m , and it work for me,
to build use Bazel and gcc 4.8 g++ 4.8


[network] fix conn_limit underflow error

Connection limit was underflowing on an unsigned number causing panics.
This should replace it without causing underflow.

perfect!
@bors-libra r+

:pushpin: Commit fc68df7 has been approved by phlip9

@bors-libra r-
hint on slightly more readable code / rusty code

feel free to land as is, just wanted to give another approach.

feel free to land as is, just wanted to give another approach.

I figured there'd be a more "rusty" way to do it

@bors-libra r=phlip9

:pushpin: Commit 95e9fc6 has been approved by phlip9

:hourglass: Testing commit 95e9fc66a6d00e0ffd2ee14351e1c1d2bfe76534 with merge 4f5f9c9f0eca447a35a92ca92588e75fa67e1d5b...

:sunny: Test successful - checks-actions_land_blocking_test, checks-circle_commit_workflow
Approved by: phlip9
Pushing 4f5f9c9f0eca447a35a92ca92588e75fa67e1d5b to master...


Subtract merge layer

With the merge method being deprecated by end of 8/2017, there needs to be a way to define a subtraction of two layers. This Subtract layer takes exactly two tensors and returns the difference.

All the tests passed, but the pull request failed. Is this related to this request, or possibly another issue?

It's a temporary file system-related issue with Travis. Cause unclear; maybe Travis itself, or a recent update to pytest.


Fetching & Processing will sometimes only produce .JSON

Doing 'colors fetch --all && colours process' doesn't seem to work. 'colors fetch && colors process' seems to get .JSONS for all apart from copic and prismacolour which seems to not have an attribute called 'fetch_all'? Doing the colours individually does the same, except pantone and dulux now add all the other file formats; ral stays the same at just .JSON?

OS: Ubuntu 20.04 running KDE Plasma 5.18.5

Looks like an interesting project. I work as admin/marketing for a window/door company so RAL in GIMP is a timesaver, so I will be grateful to any help :)
Aaron

As I recall correctly, just call colors fetch, without --all - let me know if that works, otherwise please provide your error log :fox_face:

@AaronMishaling I saw that you've given this project a star, so I guess my suggestion worked for you?
Closing this issue, thanks again!


Support for linked smart objects

Is it possible we'll see support for linked smart objects in near future? Maybe it's already there and I'm just not doing something right...
I am thinking of having several PSD templates where I have one or more linked smart objects with transformations, distortions, layers, etc. Then in a web service users can upload their own images that would be swapped with the linked smart objects. This would make it really easy to render complex and custom images. You could literally just copy the wanted images into a tmp folder (that originally contained linked smart objects) and render the custom image. It would be immensely helpful as transformations, overlays etc is much easier to just do in Photoshop than imagemagick or similar.
Simple example could be a 3D rendered living room where users could upload their own pictures which would be added to the picture frames in the render.

+1, I'd like to get the filename/path of the linked smart object layer. How to do this with psd.js?

+1, this is a really important feature for me

As this is something many people want, I will mark this to be looked at for the vanilla rewrite.

HI fabulousduck,
Can you help me this issue?

+1

Is it possible we'll see support for linked smart objects in near future? Maybe it's already there and I'm just not doing something right...
I am thinking of having several PSD templates where I have one or more linked smart objects with transformations, distortions, layers, etc. Then in a web service users can upload their own images that would be swapped with the linked smart objects. This would make it really easy to render complex and custom images. You could literally just copy the wanted images into a tmp folder (that originally contained linked smart objects) and render the custom image. It would be immensely helpful as transformations, overlays etc is much easier to just do in Photoshop than imagemagick or similar.
Simple example could be a 3D rendered living room where users could upload their own pictures which would be added to the picture frames in the render.

@jimlei  have you find solution for this?

+1 it's very nice feature

+1 We still want this in 2020 too

i'm not too sure on how to translate this to pdf.js but there is a python version of this sort of thing -- https://github.com/psd-tools/psd-tools/blob/master/src/psd_tools/api/smart_object.py


Landscape MiniMap: Add interactions (hover, selection, ...) to match current landscape state

https://github.com/jhipster/jhipster-lite/assets/62770167/c7f22822-1b0d-47eb-a22b-3728c4d12666

Thanks again @abdelfetah18 :-)


Achievement - Ideas

Ideas for achievement for issue #141

Currently have three main ideas for achievement:

achievement based on number of questions posted;
number of replies;
and number of replies based on certain tags.

To do those, you probably have to change the database accordingly. Take notes of those changes so I can update the database script.

Currently have 3 different type of achievements: number of question posted, number of upvotes and number of replies based on tags for sprint 4.


Added Sliver List

I have added Sliver List & preview/demo of it. Kindly Approve the changes.

Thank you!
Do let me know for further opportunities !
Anirudh Kolwadkar
On Tue, 23 Jun 2020, 21:45 Ravindra Kumar<EMAIL_ADDRESS>wrote:

Merged #6 https://github.com/TakeoffAndroid/flutter-examples/pull/6
into master.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/TakeoffAndroid/flutter-examples/pull/6#event-3473741719,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ALBUHVUBKLCYBU6UKF6RGB3RYDIKBANCNFSM4OFWWPSA
.


Requirements file is missing

Following the instructions in the README.md, the requirements.txt file is missing.

Thank you for the feedback.
The requirements.txt has been uploaded.
https://github.com/Wuuu3511/GoMVS#:~:text=4 days ago-,requirements.txt,-update rq.txt


Adding support for debug logs in executed functions.

Description
Changing the default log level to Debug. The configuration of the log levels is set at the host.json.
FYI @stefanushinardi @anthonychu

Fixes #735

PR information

[x] The title of the PR is clear and informative.
[x] There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
[x] If applicable, the PR references the bug/issue that it fixes in the description.
[x] New Unit tests were added for the changes made and CI is passing.

Quality of Code and Contribution Guidelines

[x] I have read the contribution guidelines.

I remember @ankitkumarr and I once dealt with a CRI where a customer's application performance got impacted due to too many logs from azure-storage-blob.
Since we're now enabling debug in Python in the root logger, I expect to see a bit more logger.debug from azure-storage-blob. (e.g. https://github.com/Azure/azure-storage-python/blob/4e03ff8c9d6c76a38666a8ceb8937593e93fb7eb/azure-storage-common/azure/storage/common/_auth.py#L93.)
I think it would be great if you can create some test cases with a host.json that controls the log level, and see if the host actually filters our worker logs.
https://docs.microsoft.com/en-us/azure/azure-functions/functions-host-json#sample-hostjson-file
    "logging": {
        "logLevel": {
          "Function.MyFunction": "Information",
          "default": "None"
        }

I think it would be great if you can create some test cases with a host.json that controls the log level, and see if the host actually filters our worker logs.
https://docs.microsoft.com/en-us/azure/azure-functions/functions-host-json#sample-hostjson-file

Done - added a new set of tests with Information log level (default) set to confirm debug logs are not sent.


Charset issue

Hello, I have a Symfony 3 project with iso charset and getting strange charater problems

Is ther any chance to change to iso?

@jakobeissler Can you give me more informations such as your Symfony verson, your PHP version and your bundle version. Additionally, what is you page encoding? UTF-8?

Sure:

Symfony version: 3.1.8
PHP version: 5.6
Bundle version: 4.0
Page encoding ISO-8859-1

php.ini encoding by default is UTF-8

Hum Isn't it the issue? PHP generated UTF-8 chars whereas you specify it as ISO-8859-1 in your page. Why are you doing such strategy?

Because our Oracle database is encoded with ISO-8859-1. Shouldn't ckeditor assume HTMLs charset?

I have never played with CKEditor charset... (UTF-8 everywhere...). IMO, it should rely on your page encoding but I'm not a CKEditor expert.. Maybe there is an option in order to specify the encoding to the CKEditor. I don't know need more research...

What we can try is to put a charset utf-8 on the each script tags. Update here in your vendor by adding charset="utf8" on all script tags and give a try. Then, come back here and give me some feedbacks :)

I tried but it didn't work.

I have also played with this config options... no result:
'entities' => true,
					'entities_latin' => true,
					'basicEntities' => true,

I need to set up a fork of the Symfony SE & give it a try...

OK, just one thing, i've the following function in AppKernel.php because i need to force the charset for my entire site to iso-8859-1:
public function getCharset()
    {
        return 'ISO-8859-1';
    }

If i remove that function or change it to UTF-8, ckeditor works as expected.

Ok thanks for this information. Anything else I should know before give it a try? Do we agree you put <meta charset="ISO-8859-1"> in the head of your page?

Yes that is correct. Thank you.

@jakobeissler So... after almost one hour of debug, i think I got it... The issue seems coming from how CKEditor loads its translation files.
I notice that all broken texts comes from a translation file loaded by CKEditor itself and since the page uses ISO-8895-1 as charset, I think the browser directly interprets this file with this encoding whereas the file is encoding using UTF-8...
I have updated my nginx conf by forcing the UTF-8 encoding on this specific files (using the charset option on the entire CKEditor directory) and then everything is working fine.

That is interesting. Just a quick question, where are the language files loaded from? I tried to edit manually the file vendor/egeloen/ckeditor-bundle/Resources/public/lang/ but no change, it seems they are loaded from a different location.
For a different approach i could try to override the language file with correct values but i can't figure out from where they are loaded.

@jakobeissler I can't find where it loads it since the javascript is minnified... but IMO, you have copied your file in the web directory with bin/console assets:install and so, updating the file in the vendor is not enought, you need to re-install assets in the web directory.
Futhermore editing file in the vendor is definitively not the way to go since when you will deploy your app, the vendor is downloaded from the source... If you wan to use your own version of CKEditor, the bundle supports it: http://symfony.com/doc/current/bundles/IvoryCKEditorBundle/usage/version.html

OK, i found out that the language file that is loades is: web/budnles/ivoryckeditor/lang/es.js
Is i open this file i see the text like this:
"checkbox":"Casilla de VerificaciÃ³n"
That doesn't look quit right does it?

Hum, this is weird when I open it using https://github.com/egeloen/IvoryCKEditorBundle/blob/master/Resources/public/lang/es.js it looks good.

I deleted the assets folder and installed again:
php bin/console assets:install web
Didn't work.

When you say, I open the file and see "checkbox":"Casilla de VerificaciÃ³n", where do you open it? in your browser? in your IDE?

You are right, it is the IDE (Netbeans), opening the file in browser displays the language file ok.

OK, so your IDE detects the file as ISO-8895-1... You have do something manually to get this behavior? My IDE (PHPStorm) detects the file as UTF-8 automatically.
An other alternative is to use dos2unix with the -iso option in order to convert all CKEDitor files using ISO-8895-1.

I set the charset in projects properties. When i deploy the symfony project to production server (linux) it doesn't work neither so has nothing to do with the IDE. I set up another ckeditor without bundle and it is working ok. I give up.

Never give up :) Maybe it is related on the way I update CKEditor, where do you download CKEditor? In the bundle, I rely on this custom script: https://github.com/egeloen/IvoryCKEditorBundle/blob/master/Resources/bin/ckeditor-sync.sh

It came with a template I bought (metronic). Ckeditor version is 4.4.5

Can you run my script and remove the last line (dos2unix) and re-install assets in the web directory?

Didn't work

NO!!! wait, it DID work... I just had to clear the browsers cache.

So, what does work? Removing the dos2unix line? or it works by default? or something else?

I executed the .sh script without the last line, installed assets and it is working on my localhost and on production server. It has definitely to do with:
find $ckeditorPath -type f -exec dos2unix {} \;

Ok, so there is something to fix. I can't remember why I needed to convert Windowd EOL to Unix ones... Need to search through the git history... Hopefully, you don't give up :)

Ok, many many thanks for the help. Please let me know when you tag a new version with the fix so I can install with composer.
This is a great and very neccesary bundle.

Here we are, your issue will be fixed by the referenced PR :)

@jakobeissler I just release 5.0.1

Thank you, it's working!!!


Do not exclude README.md

I just got a comment on a package I initialized with this template that README.md should not be excluded. I guess the same goes for CHANGELOG.md.

https://github.com/typst/packages/pull/747 for reference
README.md should in principle be enough for packaging for Universe. The reasons for not excluding something as I understand them are basically

it's necessary for using the package (typ files and assets that are part of the package, not e.g. documentation)
it's necessary for publishing on Universe (certain metadata files including the README)

Some other files are part of the PR but still excluded: you want working links to those on the Universe page, but it's not necessary for Typst to download them when they are imported. Manuals and documentation assets are classic examples.
I think CHANGELOG.md falls more in the "exclude this" category, but it's relatively useful to have locally for its size, so it's probably worth including it too.
If there's no other opinions on this, I'll make this change sometime today.


feat: Add contact form

Resolves: OCM-18

Closing since some github issue with commits refreshing.


Cannot login in windows

Description
When logging in windows using latest version of CLI I get:
Failed to verify ID Token: oidc: token is expired (Token Expiry: 2021-07-30 10:17:46 +0100 BST)

Steps to reproduce

Install rhoas cli on your system (download binary https://github.com/redhat-developer/app-services-cli/releases/tag/v0.27.0-alpha1)
Execute rhoas login
View error in browser (after you log in)

CC @pmuir

Current workaround for it is to login using token:
rhoas login --token=token
Where token comes from https://cloud.redhat.com/openshift/token

I have tested logging in on Windows 10 using multiple scenarios and environments and could not reproduce this error.
Latest development version:

Command Prompt (0.27.0-alpha1):

Powershell (0.27.0-alpha1):


Basins cause "Failed to store chunk [x, z]" error in log and eventually crashes servers

Describe the Bug
I'm playing on a multiplayer server using a custom pack that contains create for the past week or so. Due to how I setup the pack the create mod is gated behind other content and I was the first person on the server to unlock/use create related items. After building an early game setup using a windmill/sailblocks + a press + a mixer/basin I noticed the same error being spammed in the log file:
[03:08:24] [IO-Worker-7/ERROR]: Failed to store chunk [-33, 128] java.util.ConcurrentModificationException: null         at Not Enough Crashes deobfuscated stack trace.(1.18.1+build.22) ~[?:?]         at java.util.HashMap$HashIterator.nextNode(HashMap.java:1597) ~[?:?]         at java.util.HashMap$KeyIterator.next(HashMap.java:1620) ~[?:?]         at net.minecraft.nbt.NbtCompound.write(NbtCompound:163) ~[?:?]         at net.minecraft.nbt.NbtIo.write(NbtIo:118) ~[?:?]         at net.minecraft.nbt.NbtIo.write(NbtIo:83) ~[?:?]         at net.minecraft.world.storage.RegionBasedStorage.write(RegionBasedStorage:79) ~[?:?]         at net.minecraft.world.storage.StorageIoWorker.write(StorageIoWorker:174) ~[?:?]         at net.minecraft.world.storage.StorageIoWorker.writeResult(StorageIoWorker:164) ~[?:?]         at net.minecraft.util.thread.TaskQueue$PrioritizedTask.run(TaskQueue:59) ~[?:?]         at net.minecraft.util.thread.TaskExecutor.runNext(TaskExecutor:91) ~[?:?]         at net.minecraft.util.thread.TaskExecutor.runWhile(TaskExecutor:146) ~[?:?]         at net.minecraft.util.thread.TaskExecutor.run(TaskExecutor:102) ~[?:?]         at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136) [?:?]         at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635) [?:?]         at java.lang.Thread.run(Thread.java:833) [?:?]
The error only occurs when the chunk in question was unloaded in a specific way (I log off the server OR I travel far away from the chunk so it unloads and then I change dimensions by going through a nether portal). The only things in chunk [-33, 128] were some shafts, a belt, a mechanical press, and a mixer+basin. I knew of a bug on forge related to basins that was fixed recently so that was the first thing that I removed and the error/log spam went away so I think that is most likely the culprit,
Before I removed the basin the above error was spammed in the log until eventually the server crashed. Crash report can be found in a pastebin linked below
Reproduction Steps

Play on a multiplayer server?
Place a basin in a chunk away from spawn chunks
Log off the server OR travel far enough away from the basin chunk so that it unloads then enter the nether
Check the log for "Failed to store chunk [x.z]" error and wait long enough for the server to crash (it doesn't crash instantly)

Expected Result
Basins don't cause problems
Screenshots and Videos
No response
Crash Report or Log
https://pastebin.com/ZvKBXcxn
Operating System
Client = Windows, Server = Linux
Mod Version
0.4.0c
Minecraft Version
1.18.1
Other Mods
see crash report
Additional Context
I was using this build of create btw: https://github.com/Fabricators-of-Create/Create/actions/runs/1775103261

Can't reproduce. Try on the latest commit, and if it happens again can you provide a world download?

I am also getting this report in the logs however, the server has not crashed yet. I am also running a modpack with create being one of them. This is the log that I get - https://pastebin.com/9Nztz2mF. Modpack w/ list, mods and the world. - https://drive.google.com/drive/folders/1y1S2hN5mk6Kfo3BT3XWj_dbCdN2qKyrc?usp=sharing.

I still can't reproduce it locally. I think it might be an issue with NBT tag instances being shared across threads somehow.

if it's a mod conflict issue our packs share a few mods but the ones that might be the first ones to check are ferritocore or starlight.

This is more of a issue with the forge version supporting modded storages you can make a issue about it their or make a addon

Wrong issue sorry

I threw together a little mod to print some debug info to the logs.
BEWARE - this will prevent the original exception from being thrown. I have no idea what the implications of this are, but it might brick your world. MAKE A BACKUP
Inside this zip is a mod jar. Install it and try to get it to happen again. Instead of a big error, you should see a line saying CME in tag write! with some information below  it in the log.
catastrophic_failure.zip
Once it happens, please send the log here.

Currently updated most of the mods to their latest versions, including create. Unfortunately starlight and phosphor don't work properly with the new version (Probably because of fabric 0.13.1), there are no errors in the logs and the weird over stressed issue has disappeared, which is a good thing 😅. Here's the logs in case you need them - https://pastebin.com/TcGFZJ4F

This log is either cut off or very early into server start. Install the mod, and just play as normal, trying to reproduce the error. Check the logs for any CME in tag write!s and if there are any, send them here.

any updates?

Some unexpected irl stuff happened to me so I haven't had a chance to make a backup/get the debug mod on the server. I should have some time on Sunday

Some reason can’t get the basin error, but with updating to the new ver create, I am getting weird chunk bugs. Water does not move, neither does lava - breaks cobble contraptions and some chunks are still “night” and spawn hostile mobs. Only happens to chunks with a create mods. No errors in logs.

this is probably also a duplicate of #141, reopen if this turns out to not be the case.


I'm not actually creating AVIF images in the picture plugin

It looks like my AVIF images are actually just a copy of the original JPEG/PNG. Oops.

Fixed!


clerk: fix reference to wrapped binary in wrapper

Due to the use of pushd/cd the reference to the wrapper binary was a relative path.  This does not work in general as it is depending on the working directory where the wrapper is executed.

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[x] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Ping for maintainers @anderspapitto and @wineee.
Building before and after this change and running diff -r old/ new/ results in
diff -r old/bin/clerk new/bin/clerk
39c39
< exec -a "$0" "./.clerk-wrapped"  "$@"
---
> exec -a "$0" "/nix/store/mfv9g2lbpiz20yzfpnk8x9yxfpv6j4kw-clerk-0-unstable-2024-02-20/bin/.clerk-wrapped"  "$@"
diff -r old/bin/clerk_rating_client new/bin/clerk_rating_client
39c39
< exec -a "$0" "./.clerk_rating_client-wrapped"  "$@"
---
> exec -a "$0" "/nix/store/mfv9g2lbpiz20yzfpnk8x9yxfpv6j4kw-clerk-0-unstable-2024-02-20/bin/.clerk_rating_client-wrapped"  "$@"
diff -r old/lib/systemd/user/clerk_rating_client.service new/lib/systemd/user/clerk_rating_client.service
7c7
< ExecStart=/nix/store/08daa6vf6wmhl2sdcav3cjlkbcanip0m-clerk-0-unstable-2024-02-20/bin/clerk_rating_client
---
> ExecStart=/nix/store/mfv9g2lbpiz20yzfpnk8x9yxfpv6j4kw-clerk-0-unstable-2024-02-20/bin/clerk_rating_client
diff -r old/share/systemd/user/clerk_rating_client.service new/share/systemd/user/clerk_rating_client.service
7c7
< ExecStart=/nix/store/08daa6vf6wmhl2sdcav3cjlkbcanip0m-clerk-0-unstable-2024-02-20/bin/clerk_rating_client
---
> ExecStart=/nix/store/mfv9g2lbpiz20yzfpnk8x9yxfpv6j4kw-clerk-0-unstable-2024-02-20/bin/clerk_rating_client

I guess this was introduced in b1b1176946e8ea915b3c4d1b469b52d92e48b7bb.  Did it work for anybody since then? Or did the behaviour of wrapProgram change?

Thanks, are you interested in adding yourself as a maintainer? I haven't used clerk for a long time

I am also not using clerk, I wanted to try it out and found this bug.


Fix #2837: remove (y, x) from the comment

:+1:

I thought the idea was to add a "Note the order of parameters given is (y, x)".

i think it should have been
  /**
       * Returns the angle (in radians) from the X axis to a point (x,y).
       * @param y A numeric expression representing the cartesian y-coordinate.
       * @param x A numeric expression representing the cartesian x-coordinate.
       */

instead of
  /**
       * Returns the angle (in radians) from the X axis to a point (y,x).
       * @param y A numeric expression representing the cartesian y-coordinate.
       * @param x A numeric expression representing the cartesian x-coordinate.
       */


Bump harvester node driver to v0.5.0

Signed-off-by: chrisho<EMAIL_ADDRESS>This PR updates Harvester Node Driver to version v0.5.0
Related Issue:
https://github.com/harvester/harvester/issues/2316

merged the PR on behalf of the Harvester team.


(question)Is this support solidus?

Hi, there.
I'm interested in using this gem with Solidus but it seems to work only with Spree whose source code is going to be closed (I'm not sure the detail)...
Is there any plan to support Solidus or another gem forked from this?
or should we use Spree?

Hi @k-kawa,
We're looking at adding support for Solidus v1.2.2 now
We have a WIP pull request open (see https://github.com/komoju/spree_komoju/pull/49)
I'll let you know once we've finished :-)

What a quick response with pull request!!
Thank you, @rramsden
btw, are you a developer inside Komoju?
I made an account today and found it cool and easy to get started!

Yes I work for Komoju. Thanks for the feedback! :smile:

:+1:


load (c-c c-l) is stuck with "Loading .."

I had vs code with agda-mode working - installed following instructions on a system build with debian and using cabal. Then I deleted the .cabal/store folder (it had accumulated too much old stuff) and rebuild anything I remembered, including cabal install for agda-mode producing als executable.
After removing and (re-)install of agda-mode in VS Code, the load command was available, but showed only "Loading ..." but did not advance. After several repeats of disable, uninstall, install... eventually the agda-mode worked again correctly.
What is the proper sequence of completely reinstall agda-mode? Could you include a bit more information, where stuff is cached, to understand which steps are needed?
Thank you for a very nice tool!

I think the only proper way of reinstalling agda-mode (specifically, the editor extension itself, not including agda or als), is by clicking uninstall and then install in Extensions, nothing fancy really.
agda and als installed via stack or cabal is also pretty standard (please don't ask me how).
However, als installed by agda-mode is a different story, because it's downloaded by agda-mode when it cannot find agda nor als in PATH. The downloaded artifacts are stored in ExtensionContext.storagePath, I'll close this issue when there's a command for clearing those artifacts.

For some reason, the uninstall and install sequence did not work. I assume there is somewhere something left in the uninstall step, What is necessary after the uninstall to finalize it? closing VS Code? just a restart?  I had 'agdaand laterals` in my my search PATH. Perhaps it was some process which took a while to clean or reconstruct something?
In any case, in the end it worked again. Thank you for looking into it!

I'm stuck on this issue as well now! I tried poking around through the output windows in VSCode but didn't find anything noteworthy. How to debug what's wrong?

Same issue, running the binary /usr/bin/als gives no unexpected error

Got hit by the same issue. Trying to use ALS with the v0.3.11 of agda-mode resulted in an endless "Loading ...", while the Emacs connection worked correctly.
After checking the VSCode logging panels, I noticed that the error described in #116 was in there (see below). After downgrading to the v0.3.9 of agda-mode (as suggested in the linked issue), the ALS connection ended up firing correctly.

Maybe those two issues are actually the same in the current version of this extension?


Introduce storage classes

Description
Added Storage Classes feature.
Changes proposed in this pull request:

Added Storage in LeftNav menu
Added Storage List and Detail view
Added Create and Edit modal with YAML editor
Added PersistantVolumes connected to storage class

Related issue(s)
Closes #530

/retest

/test pre-busola-integration-test-k3s

/test pre-busola-integration-test-k3s

/test pre-busola-integration-test-k3s

/test pre-busola-integration-test-k3s

/test pre-busola-integration-test-k3s

/test pre-busola-integration-test-k3s

/retest

/retest

/retest

/test pre-busola-integration-test-k3s

/retest

/test pre-busola-integration-test-k3s

/test pre-busola-integration-test-k3s

/test pre-busola-integration-test-k3s


Update older CIPs for revised CIP-0001

The CIP-0001's rework has been merged. In this rework, we've changed the preamble header structure and renamed some of the sections. Thus, for the sake of consistency, we'll need to update past CIPs to reflect this new structure. This issue is meant to help organizing the work around that.  For each CIP, we need to:

Convert Authors to an actual bullet-point list (one name per line, starting with -)
Remove any field that is no-longer supported (e.g. type)
Add a Discussions field with a list (same as authors) of links to past discussions. At the very least, this should contain a link to the original PR (git log comes in handy to figure this out).
Add any other new fields specified by CIP-0001 (Category, Implementors...).
Some sections have been renamed and need to follow the structure given by the new CIP template. In particular, the path to active needs to divided into two sub-sections. It may very much be the case for older CIPs that the path to active is incomplete; which should be reflected in the new structure (CIPs without implementors or implementation plan shall be explicitly labelled as such).
Update the top level README.md if there is a status change for this CIP in the table.

Warning We may introduce categories as we see fit; however, categories that would refer to specific areas of the ecosystem (e.g. Ledger which also applies to RSS proposals) need to be endorsed by the respective teams of maintainers. Until this happens, we should refrain from using these categories and simply use N/A in the meantime.

In terms of process; here below is a list of all (currently) merged CIPs; Each item can be converted into issue and assigned to one person. Thus, if you intend to help, make an issue out of one of the point, assign it to you and make a follow-up PR with the changes. Once all CIPs have been updated, we should be able to repair the website build.

[x] CIP-0001 | Adjust preamble and structure w.r.t CIP-0001
[x] #390
[x] #397
[x] #400
[x] #451
[ ] CIP-0006 | Adjust preamble and structure w.r.t CIP-0001
[x] #532
[ ] CIP-0008 | Adjust preamble and structure w.r.t CIP-0001
[ ] CIP-0009 | Adjust preamble and structure w.r.t CIP-0001
[ ] CIP-0010 | Adjust preamble and structure w.r.t CIP-0001
[ ] CIP-0011 | Adjust preamble and structure w.r.t CIP-0001
[ ] CIP-0012 | Adjust preamble and structure w.r.t CIP-0001
[x] #402
[ ] CIP-0014 | Adjust preamble and structure w.r.t CIP-0001
[ ] CIP-0015 | Adjust preamble and structure w.r.t CIP-0001
[ ] CIP-0016 | Adjust preamble and structure w.r.t CIP-0001
[ ] CIP-0017 | Adjust preamble and structure w.r.t CIP-0001
[ ] CIP-0018 | Adjust preamble and structure w.r.t CIP-0001
[ ] CIP-0019 | Adjust preamble and structure w.r.t CIP-0001
[ ] #410
[ ] CIP-0021 | Adjust preamble and structure w.r.t CIP-0001
[ ] CIP-0022 | Adjust preamble and structure w.r.t CIP-0001
[x] #533
[x] #534
[ ] CIP-0025 | Adjust preamble and structure w.r.t CIP-0001
[ ] CIP-0026 | Adjust preamble and structure w.r.t CIP-0001
[ ] CIP-0027 | Adjust preamble and structure w.r.t CIP-0001
[ ] CIP-0028 | Adjust preamble and structure w.r.t CIP-0001
[ ] CIP-0029 | Adjust preamble and structure w.r.t CIP-0001
[ ] CIP-0030 | Adjust preamble and structure w.r.t CIP-0001
[ ] CIP-0031 | Adjust preamble and structure w.r.t CIP-0001
[ ] CIP-0032 | Adjust preamble and structure w.r.t CIP-0001
[ ] CIP-0033 | Adjust preamble and structure w.r.t CIP-0001
[ ] CIP-0034 | Adjust preamble and structure w.r.t CIP-0001
[ ] CIP-0035 | Adjust preamble and structure w.r.t CIP-0001
[ ] CIP-0036 | Adjust preamble and structure w.r.t CIP-0001
[ ] CIP-0037 | Adjust preamble and structure w.r.t CIP-0001
[ ] CIP-0040 | Adjust preamble and structure w.r.t CIP-0001
[ ] CIP-0042 | Adjust preamble and structure w.r.t CIP-0001
[ ] CIP-0049 | Adjust preamble and structure w.r.t CIP-0001
[ ] CIP-0052 | Adjust preamble and structure w.r.t CIP-0001
[ ] CIP-0054 | Adjust preamble and structure w.r.t CIP-0001
[ ] CIP-0055 | Adjust preamble and structure w.r.t CIP-0001
[ ] CIP-0059 | Adjust preamble and structure w.r.t CIP-0001
[ ] CIP-0060 | Adjust preamble and structure w.r.t CIP-0001
[ ] CIP-0067 | Adjust preamble and structure w.r.t CIP-0001
[ ] CIP-0068 | Adjust preamble and structure w.r.t CIP-0001
[ ] CIP-0071 | Adjust preamble and structure w.r.t CIP-0001
[x] #535
[ ] CIP-0381 | Adjust preamble and structure w.r.t CIP-0001
[ ] CIP-1852 | Adjust preamble and structure w.r.t CIP-0001
[ ] CIP-1853 | Adjust preamble and structure w.r.t CIP-0001
[ ] CIP-1854 | Adjust preamble and structure w.r.t CIP-0001
[ ] CIP-1855 | Adjust preamble and structure w.r.t CIP-0001
[x] CIP-9999 | Adjust preamble and structure w.r.t CIP-0001

@KtorZ before we get too far into this list, can we reformat the items in the outline above from e.g. :

Adjust preamble and structure of CIP-0003 to abide by new CIP-0001

to

CIP-0003 | Adjust preamble and structure to abide by new CIP-0001

Otherwise the email notifications for all these new PRs and issues will be hard to tell apart, with the distinguishing element so deep into the title.  They'll still collate as currently above but will require a wider screen to view.  There could also be some historical benefit to using the same format that we use for all our other issues & PRs... rather than having them all stand out as parts of a once-off editing process.
If you and @crptmppt @SebastienGllmt agree I can easily script that change... as could you, but I'm ready, willing & motivated to do it right now 😎

Done!

@Ryun1 @KtorZ with the new versioning clarification proposed in https://github.com/cardano-foundation/CIPs/pull/563 I think we might also have to add version treatment to the outline of things to do here... if possible (this could depend on communication with authors & other proponents, which might not be possible).

@KtorZ @Ryun1 @Crypto2099 my Catalyst Fund 10 project has been approved, with filing PRs for all of these as the Q4 2023 milestone. 😬 I've added it to the CIP meeting agenda today so we can talk about how the editorial process would best proceed for these. 😇

FYI as of now, I've created issues for all the CIP remediations above & linked each one of the unresolved issues to one of 41 new PRs which we can work on refining, approving & merging some time soon in the New Year. 🎉

Great work on this @rphair 💪
Im sure it will feel very satisfying to press the close issue button 🤠

Thanks for the great backup & insight... you guys are awesome 🤩


new extension preference - Add Calendar focus on command completion

Description
New extension preference - A checkbox for focusing on Calendar on command completion.

Hi @bascomb 👋
Do you mind checking the linter and @mblode do you mind checking this 😊

@pernielsentikaer Fixed issues I think.  (Upgraded Node/Npm, formatted index.tsx, ran "npm run lint", no lint issues found)


add excentre calculator

With reference to issue #1208
Added excentre calculator

@sairish2001 Is my PR ready to merge?


Customise & match lighting conditions to the ones from Poly

I''m trying to host some models on my website, the same ones I was hosting on Poly before.
The problem is that the lighting conditions and appearance are very different, as you can see in the screenshots (1st photo is hosting from Poly / 2nd photo is self-hosting on website).
When hosting directly on my site the model texture becomes glossy and the lighting changes as well. I tried using a skybox or environment-image with an image a user uploaded here, but the model became completely dark (3rd screenshot).
Is there a way to match the lighting conditions to the ones that are used when hosting and serving from Poly?

@nick-sp Can you post links to these examples? That would give me a much better chance of understanding what's wrong.

If I may hijack this thread @elalish I am having the same issue. When I apply any skybox or environment image I get the third image @nick-sp posted.
https://glitch.com/edit/#!/join/e3a84155-04fe-402e-bf5c-d64c46980c60
This is a link to my glitch project illustrating the issue. With no hdri the colours show correctly and the model also looks fine on https://gltf-viewer.donmccurdy.com/ so I'm assuming it's not a model issue.
Side note, I can't seem to host my .glb files anywhere but on glitch and succesfully load the model viewer. Squarespace, googledrive, anonfile, and I think amazon don't ever load. But that's a different issue to the above.

@gproud It looks like it's either failing to find or failing to decode your hdri. Can you try some examples from HDRI Haven? You might also want to check just serving it locally. As for not working on googledrive and such, I think the problem is that you need the CORS headers set properly; there should be console warnings about that.

Hi @elalish thanks for responding, I have used the example hdri on the model-viewer site and the current is a second from hdri haven, both 1k.
This isn't my natural arena, so I will look into what you mean by CORS and let you know how I get on with that.

@gproud Yeah, I'm seeing this in the console on your website, so I think CORS is the answer:
Access to XMLHttpRequest at 'https://cube-sealion-kxw7.squarespace.com/s/piazza_san_marco_1k.hdr' from origin 'https://www.proud-studio.com' has been blocked by CORS policy: No 'Access-Control-Allow-Origin' header is present on the requested resource.

@elalish Just to update you, I've managed to get around it with a CORS proxy for the moment (https://cors-anywhere.herokuapp.com/), I feel that it has marginally increased load times, but that may just be because it is loading the HDR as well now.
I'm very grateful for your help and work on this project!

@elalish However, now on iOS the same .usdz file which was held on glitch, now called through the proxy, returns a 'object requires a newer version of iOS' when going into AR mode. The glitch source stills works fine, it's only when calling the file through the proxy that it is unhappy.

@elalish Bafflingly calling the .usdz directly doesn't seem to have the same issues as calling the .glb or HDR as described, so it's seemingly all in working order

@gproud That is strange, but sounds like an iOS error. Hopefully the apple forums can help out. If you figure it out, please let us know here!


Fixed #3811: Effect of parent's IsEnabled on DropDownButton

The changes made in this pull request
This pull request fixes a regression in v2.0 where changing a parent's IsEnabled to true does not enable the DropDownButton.
Closed Issues
#3811

@yjagota Thanks for trying to solve the issue. Binding to the IsEnabled property of the parent is not a good approach and doesn't solve the real bug. The issue comes from the inner Button which set's the IsEnabled property twice. After that the control IsEnabled property will never get an update. To fix this I implemented the ICommandSource for DropDownButton and SplitButton in #3819 which fixes the issue.

Yes. I saw the commit. Sorry for the half baked fixes for both issues. These both were my first pull request submissions, so I learned how to submit pull requests and also learned that I should be way more careful when posting them. :) And thanks again for fixing the issues and giving us this awesome package. I hope I can make a worthwhile contribution to the project someday. Take care and stay safe.


Bug: Enforcer options object is altered

This seems to be an issue since this line was changed.
When running the enforcer multiple times with the same options object the second pass will throw an error:
options.exceptionSkipCodes.reduce is not a function

What seems to happen is that in the first pass options.exceptionSkipCodes is changed from an array to an object. This change is a side effect that causes the error to be thrown on the second pass where it essentially tries to do {}.reduce() instead of [].reduce().
It looks like the same side effect is created for options.exceptionEscalateCodes on this line
I've solved this for now by cloning my options object before passing it to the enforcer.

Thanks for the bug report and awesome research identifying the problem. I've made a fix in 1.10.3 and have published it to NPM.


[Project Addition] Predicting Molecular Properties

ML-Crate Repository (Proposing new issue)
:red_circle: Project Title: Predicting Molecular Properties
:red_circle: Aim: To perform Exploratory Data Analysis (EDA) on the datasets and predict the scalar_coupling_constant between atom pairs in molecules using ML/DL models.
:red_circle: Dataset:  https://www.kaggle.com/competitions/champs-scalar-coupling/data
:red_circle: Approach: Try to use 3-4 algorithms to implement the models and compare all the algorithms to find out the best fitted algorithm for the model by checking the accuracy scores. Also do not forget to do an exploratory data analysis before creating any model.

📍 Follow the Guidelines to Contribute in the Project :

You need to create a separate folder named as the Project Title.
Inside that folder, there will be four main components.

Images - To store the required images.
Dataset - To store the dataset or, information/source about the dataset.
Model - To store the machine learning model you've created using the dataset.
requirements.txt - This file will contain the required packages/libraries to run the project in other machines.

Inside the Model folder, the README.md file must be filled up properly, with proper visualizations and conclusions.

:red_circle::yellow_circle: Points to Note :

The issues will be assigned on a first come first serve basis, 1 Issue == 1 PR.
"Issue Title" and "PR Title should be the same. Include issue number along with it.
Follow Contributing Guidelines & Code of Conduct before start Contributing.

:white_check_mark: To be Mentioned while taking the issue :

Full name :  S G V Kamalakar

GitHub Profile Link : Sgvkamalakar

Participant ID (If not, then put NA) : NA

Approach for this Project:

   - Data preprocessing and transformation.
   - EDA and visualization.
   - Feature Engineering.
   - Training ML models like RF, DT, SVM, KNN, Linear regressor, and other ML regressors for predicting the `scalar_coupling_constant` and evaluating the best-fitted model for the dataset.
   - Utilizing the power of Neural Networks and Graph Neural Networks which can be best fitted for molecular data.
   - Making predictions using best-fitted models.

What is your participant role? (Mention the Open Source Program name. Eg. HRSoC, GSSoC, GSOC etc.): SSOC S3

Happy Contributing 🚀
All the best. Enjoy your open source journey ahead. 😎

@abhisheks008, assign this issue to me!! 🙂

Assigned @Sgvkamalakar


visibility on black-on-white terminals

creating this dedicated issue for the comment by @dreirund in #1 :

However I see that you have hard-coded a colour scheme that is not well
visible on black-on-white terminals. Can you include some way to make
it compatible with light terminal colour schemes?, e.g.

by allowing to specify the colour scheme,
by allowing a non-coloured version,
by autodetecting (I don't know if it is possible) the terminal
colours?

@dreirund, here are two examples of what it looks like on my machine, if i switch to a black-on-white terminal:

hope this matches what you see?
if yes, could you please explain what you are missing, in terms of readability?

here are two examples of what it looks like on my machine, if i switch to a black-on-white terminal:

Here a screenshot of optimal-congress --help:

The coloured parts are not easily readable (for me).

@dreirund, thanks for the visual example.
unfortunately, on my machine i get the same output on black and white, also for --help.
this stackoverflow answer suggests that installting typer without any extras (compared to as in pip install typer[all]) should result in a non-color output.
interestingly, this project's pyproject.toml does not define any extras for typer.
but if i change the typer dependency definition in pyproject.toml to "typer = { version = "^0.9.0", extras = ["all"] }, i can resproduce the colorful output you see.
but i agree with you: the colors are not needed, and may only cause trouble in terms of readability.
do you see an option to change your build settings, to avoid installing typer's extras (esp. rich and colorama)?

Ahoj,
I use my distrubution packaging and do not any manual python stuff.
Installed on my system is python-typer version 0.9.0.
I don't know anything how python specific packaging stuff works, I hade "third party" packaging that interferes with system packaging.
But I see in your pyproject.toml that there indeed is typer listed:
[...]
[tool.poetry.dependencies]
[...]
typer = "^0.9.0"
[...]

python-rich and python-colorama I cannot uninstall from my system since they are required by other packages.
Anyway, if some random presence of packages changes colouring in an uncontrolled way: Wouldn't then be the clean way of doing it to program the software that it either always does colouring or never does, but not dependend on the presence of random unrelated packages?
Regards!

.. setting the environment variable NO_COLOR (i.e. having at present, regardless of the value) disables colouring for me.

@dreirund, i ike the idea of adding color management, and then setting it to no colors.
and thanks a lot for pointing to the right env variable.
i will cook up a color fix soon, that will probably add rich as a dependency and will set the environmental variable programmatically.

@dreirund , the fix is now released. could you be so kind and check if your Arch build is now without colors, even if you are not setting NO_COLOR yourself?

could you be so kind and check if your Arch build is now without
colors, even if you are not setting NO_COLOR yourself?

Checked & works.

great to hear!


TP-Link Tapo C225 auth fails after camera update to 1.0.27

Hi,
in reference to #733, it looks like the new firmware 1.0.27 for the Tapo C225 introduces the same authentication issues as on the C210. All three of my C225 now show log "streams: 401 unauthorized".
Previously, I've been passing the credentials in cleartext via:
    kueche:
      - tapo://{FRIGATE_PASSWORD_TAPO}@{FRIGATE_CAM_KUECHE_EG}

However I've now tested it with an SHA265 hashed password but that didn't solve it either.
Happy to provide all logs needed.
Thanks alot for go2rtc, really appreciate it!

So I've tested all combinations I could think off this evening.
I can stream it using rtsp just fine, however this way I don't have two way audio.
For reference, the variables I'm using are:
FRIGATE_USERNAME_TAPO -> The username set as local user in the Tapo App
FRIGATE_PASSWORD_TAPO_CLEAR -> Clear Text Password (for testing I've set it to be the same as the cloud account
FRIGATE_PASSWORD_TAPO_SHA256 -> Password hashed as SHA in uppercase
FRIGATE_PASSWORD_TAPO_MD5 -> Password hashed as MD5 in uppercase
This works via rtsp:
    # Camera Küche EG
    kueche:
      - rtsp://{FRIGATE_USERNAME_TAPO}:{FRIGATE_PASSWORD_TAPO_CLEAR}@{FRIGATE_CAM_KUECHE_EG}:554/stream1
      - ffmpeg:kueche_sub#audio=opus
    kueche_sub:
      - rtsp://{FRIGATE_USERNAME_TAPO}:{FRIGATE_PASSWORD_TAPO_CLEAR}@{FRIGATE_CAM_KUECHE_EG}:554/stream2
      - ffmpeg:kueche_sub#audio=opus

    # Camera Wohnzimmer EG
    wohnzimmer:
      - rtsp://{FRIGATE_USERNAME_TAPO}:{FRIGATE_PASSWORD_TAPO_CLEAR}@{FRIGATE_CAM_WOHNZIMMER_EG}:554/stream1
      - ffmpeg:wohnzimmer_sub#audio=opus
    wohnzimmer_sub:
      - rtsp://{FRIGATE_USERNAME_TAPO}:{FRIGATE_PASSWORD_TAPO_CLEAR}@{FRIGATE_CAM_WOHNZIMMER_EG}:554/stream2
      - ffmpeg:wohnzimmer_sub#audio=opus

    # Camera Flur EG
    flur:
      - rtsp://{FRIGATE_USERNAME_TAPO}:{FRIGATE_PASSWORD_TAPO_CLEAR}@{FRIGATE_CAM_FLUR_EG}:554/stream1
      - ffmpeg:flur_sub#audio=opus
    flur_sub:
      - rtsp://{FRIGATE_USERNAME_TAPO}:{FRIGATE_PASSWORD_TAPO_CLEAR}@{FRIGATE_CAM_FLUR_EG}:554/stream2
      - ffmpeg:flur_sub#audio=opus

However I can't find a working way via the tapo:// protocol.
Before the update to 1.0.27 I was using this just fine:
- tapo://{FRIGATE_PASSWORD_TAPO_CLEAR}@{FRIGATE_CAM_KUECHE_EG}
The variations I've tested to no avail are:
- tapo://admin:{FRIGATE_PASSWORD_TAPO_CLEAR}@{FRIGATE_CAM_KUECHE_EG}
- tapo://admin:{FRIGATE_PASSWORD_TAPO_SHA256}@{FRIGATE_CAM_KUECHE_EG}
- tapo://admin:{FRIGATE_PASSWORD_TAPO_MD5}@{FRIGATE_CAM_KUECHE_EG}
- tapo://{FRIGATE_USERNAME_TAPO}:{FRIGATE_PASSWORD_TAPO_CLEAR}@{FRIGATE_CAM_KUECHE_EG}
- tapo://{FRIGATE_USERNAME_TAPO}:{FRIGATE_PASSWORD_TAPO_SHA256}@{FRIGATE_CAM_KUECHE_EG}
- tapo://{FRIGATE_USERNAME_TAPO}:{FRIGATE_PASSWORD_TAPO_MD5}@{FRIGATE_CAM_KUECHE_EG}
- tapo://{FRIGATE_PASSWORD_TAPO_CLEAR}@{FRIGATE_CAM_KUECHE_EG}
- tapo://{FRIGATE_PASSWORD_TAPO_SHA256}@{FRIGATE_CAM_KUECHE_EG}
- tapo://{FRIGATE_PASSWORD_TAPO_MD5}@{FRIGATE_CAM_KUECHE_EG}

Anyone has an idea?

On my C210 with latest fw it works like this
<EMAIL_ADDRESS>(I use the same pw for cloud/local)
at least in frigate I am not able to use templates for this or go2rtc dies.

Confirmed, TP-Link C210 v2.0 FW 1.3.11 work's with tapo://cloud_password_in_clear_text@Camera_IP

I need remote access to this stream to check the problem (8800 camera port)
https://github.com/AlexxIT/go2rtc/wiki/Tunnel-RTSP-camera-to-Intenet

@RobinBeismann I also have C225 (firmware 1.0.27) and my configuration in go2rtc.yaml is as follows:
tapo_camera:      - tapo://admin:[sha256-cloud-password]@[camera IP-address]
Cloud and local passwords are different.
I have the stream and it goes with audio. But I can't get camera microphone to work (two-way audio).


Add default whitelist to rule Common Ransomware Extensions

The rule ESCU - Common Ransomware Extensions triggers false positives from files generated by the Upgrade Readiness App (python_upgrade_readiness_app).

Those are generated from the application:

We could exclude them automatically through the common_ransomware_extensions_filter macro.  For example:
NOT (file_name IN("jura_entry.lock", "pura_entry.lock") file_path="*/etc/apps/python_upgrade_readiness_app/local").

This has been fixed in #2054 and will ship in the next tagged release.


VSCode can not switch between vscode windows.

Windows 10 x64
vscode 1.22.2 x64
When we open more than one vscode window. I try to switch another vscode window. but the previous windows persist in front, so i failed to switch to other window.

This sounds like an issue with your Windows installation and nothing VS Code can do about.

No, I means two vscode editor windows can not switch one to another.

ping @bpasero
The problem exists. it's about vscode editor window. I can not switch between two or more vscode editor windows


error while using ./zzlibx264.sh  script during installation

Saving to: 'libx264.tar.gz'
[ <=>                                                                                ] 932,833     5.60MB/s   in 0.2s

2020-07-19 21:31:35 (5.60 MB/s) - 'libx264.tar.gz' saved [932833]
Found no assembler
Minimum version is nasm-2.13
If you really want to compile without asm, configure with --disable-asm.
What should be the course of action here?

I met the same problem, how did you solve it?


New Tcache bins attack on 2.27 and later for arbitrary write

This attack will give arbitrary write by Tcache list poisoning.
I propose the name House Of Mango.
This is just a PoC I will refine the code and comments readability once the idea is validated.

I think the idea is not very clear at the moment. I like the idea of bypassing double free protection by put the same chunk into two different tcache. However, the current idea requires two different primitives: 1. size overwrite, 2. double free. And either of them can give us arbitrary write primitive on its own.
I think you can check out house_of_botcake and get some inspiration for improvement. The idea is similar, but it puts the same chunk into tcachebin and unsortedbin. The neat thing about that technique is it only needs a double free.

I have made some changes to the code now you only need double-free primitive. This attack could be thought of as another version of the house of botcake and could be little more flexible as you don't have to fill tcache.

Actually, the new version doesn't use overwrite primitive but a UAF. Normal program won't realloc a chunk after it is freed.

very similar to https://faraz.faith/2019-10-12-picoctf-2019-heap-challs/#zero_to_hero

Hey there, the one thing that sticks out to me is using the realloc function to exploit a double free. After seeing this, I played around with it for quite a while and realized that realloc can do a some interesting things:

If the chunk being asked for is the same size as the original chunk, we can infinitely get the same chunk back. This allows for the an infinite amount of pointers to point to the same memory. This is, of course, an unexpected use case. But, I feel this whole repository is just that haha.
Let's assume that we have freed this chunk once (so, it's in some bin) already and want to realloc it to cause a double free. If the chunk is being requested to realloc is SMALLER than the original, then we can get back the first half via the call to realloc and put the second half into another bin. Now, we have the FULL chunk in some bin, the other half of the realloc call in another bin and the first part of this chunk being used. This is a half UAF and a half double free!

When testing the second piece of functionality, I noticed that this works very well with tcache and smallbins! Then, kind of works because the unsorted bin validates the new size of the chunk, which means we can only overlap first half of the realloc chunk with this. Finally, the fastbins and largebins do not work because the chunk size is validated prior to removal.

int main(){

	int a;
	scanf("%d\n", &a);

	puts("Realloc double free exploitation with tcache.");
	puts("Allocate 0x70 sized chunk and put a chunk into the tcache.");
	// TCache sized chunk
	uint64_t* victim = malloc(0x70);

	printf("Victim address: %p\n", victim);

	// Free the chunk for the first time
	free(victim);

	/*
	The 'victim' chunk is already in the tcache
	(depending on the version). So, we are going to call 'realloc'
	on this chunk, which acts as a 'double free'.

	If we SHRINK get the same the size of the chunk via realloc, it will return
	us the first part of the chunk which is already in the bin
	(creating a  UAF) and the other half will go into another bin,
	undetected to create a double free-like situation.
	*/
	puts("Double free tcache chunk with call to realloc.");
	puts("Realloc call not return the chunk to the allocator. Otherwise double free will be triggered.");
	puts("Here, we will realloc 0x20 (0x30 sized chunk) to split our original 0x80 sized chunk.");
	// ---------- Vulnerability --------
	uint64_t* realloced_victim = realloc(victim, 0x20);
	printf("Realloced Victim: %p\n", realloced_victim);
	// -----------------------

	puts("Now, we have the first half of the tcache chunk in 'realloced_victim'.");
	puts("And the second half within a different tcache bin.");
	puts("All while the original chunk is still in the tcache.");

	puts("Get full chunk from the tcache bin");
	// Gets the chunk that we allocated originally and freed
	uint64_t* full_chunk = malloc(0x70);
	printf("Full Chunk: %p\n", full_chunk);

	puts("Get second half of the tcache chunk");
	// Gets the chunk that we split from the OG chunk
	uint64_t* split_chunk = malloc(0x40);
	printf("Split Chunk: %p\n", split_chunk);

	printf("Realloc chunk (%p) overlaps with the first 0x30 bytes of full_chunk (%p)\n", realloced_victim, full_chunk);
	printf("Split chunk (%p) overlaps the final 0x60 bytes of full_chunk (%p)\n", split_chunk, full_chunk);
}


[Request] DeviantArt error 403 login problem

Ripme version: 1.7.95
Java version: OpenJDK Runtime Environment (build 11.0.11+9-Ubuntu-0ubuntu2.18.04)
Operating system: Lubuntu 18.04 LTS

Hi, i'm trying this app, the first site I've tested is DeviantArt, I noticed that the site need the user to login in order to download albums. What I suggest is: is it good to implement a function where, inside the app, the user submits DeviantArt login credentials, then RipMeApp saves it so it is possible to rip from deviantart?

sounds good, would be excellent if you d create a pull request.

I noticed that in DeviantArtripper.java the login function is implemented, so the Error 403 it's a bug. Need further investigation


Call ToString for template literal placeholders

We were not calling ToString correctly for template literal
placeholder expressions. This lead to cases where we ended up with
calling valueOf instead as required by a + b.
Fixes #1836

@caitp I got lazy and reused your tests.

@johnjbarton PTAL

LGTM

According to 5.1 spec  regarding Addition Operator (+)

If Type(lprim) is String or Type(rprim) is String, then
Return the String that is the result of concatenating ToString(lprim) followed by ToString(rprim).

So ""+expr would be calling toString(). So I wonder if its a V8 issue?
So happens IE calls toString() when using ""+expr and it calls valueOf() when using expr+expr
thoughts?

thoughts?

Try "" + ({ toString: function() { return "A"; }, valueOf: function() { return "B"; } }) in any browser

@pflannery "" + v first calls ToPrimitive(v) before calling ToString on the result of that.

Thanks. It looks like I got my Strings in a twist ;). I see now I misread the followed by ToString(**rprim**) part of the spec.

Not going to do this one at the moment.


Increase wasm (smart contract) max memory to 33MiB

There is a requirement to support a 32MiB dataset in wasm memory. Make the maximum memory allowed 33MiB. 33 was chosen via fair dice roll; if we feel 32.064 is the most we want to push we can easily change it.
See each individual commit for a better description of changes. Most notable is that I had to disable the unit test that mixes sbrk() and malloc() because I modified malloc's heap growth to always create heaps on wasm page boundaries.

Just occurred to me that all of tests/wasm_tests have been disabled on the large test PR that recently went in (and was included in the sync to master on this branch). Recommending to delay this PR until the tests are reenabled as I think some of those tests may fail and need proper modifications.


⚠ Guya.moe Proxied has degraded performance

In 70903ef, Guya.moe Proxied (https://ice.guya.moe/) experienced degraded performance:

HTTP code: 200
Response time: 12075 ms

Resolved: Guya.moe Proxied performance has improved in 4005ea2 after 1 hour, 21 minutes.


Attempting to increase output to 16k results in crash during output

Increased max_new_tokens to 16384 and received the following crash. Code is updated as of creation of this issue. The prompt was a bit long having an additional 250 lines of source code context.
Unfortunately, Between this and another reported issue (updated) I have not been able to get a useful number of response tokens for coding purposes out of KT.
Oct 24 11:37:11 sv-ai kernel: NVRM: Xid (PCI:0000:01:00): 43, pid=63681, name=pt_main_thread, Ch 0000000c
Oct 24 11:37:11 sv-ai ktransformers[63681]: ../aten/src/ATen/native/cuda/IndexKernel.cu:92: operator(): block: [0,0,0], thread: [0,0,0] Assertion -sizes[i] <= index && index < sizes[i] && "index out of bounds" failed.
Oct 24 11:37:11 sv-ai ktransformers[63681]: ../aten/src/ATen/native/cuda/IndexKernel.cu:92: operator(): block: [0,0,0], thread: [1,0,0] Assertion -sizes[i] <= index && index < sizes[i] && "index out of bounds" failed.
Oct 24 11:37:11 sv-ai ktransformers[63681]: ../aten/src/ATen/native/cuda/IndexKernel.cu:92: operator(): block: [0,0,0], thread: [2,0,0] Assertion -sizes[i] <= index && index < sizes[i] && "index out of bounds" failed.
Oct 24 11:37:11 sv-ai ktransformers[63681]: ../aten/src/ATen/native/cuda/IndexKernel.cu:92: operator(): block: [0,0,0], thread: [3,0,0] Assertion -sizes[i] <= index && index < sizes[i] && "index out of bounds" failed.
Oct 24 11:37:11 sv-ai ktransformers[63681]: ../aten/src/ATen/native/cuda/IndexKernel.cu:92: operator(): block: [0,0,0], thread: [4,0,0] Assertion -sizes[i] <= index && index < sizes[i] && "index out of bounds" failed.
Oct 24 11:37:11 sv-ai ktransformers[63681]: ../aten/src/ATen/native/cuda/IndexKernel.cu:92: operator(): block: [0,0,0], thread: [5,0,0] Assertion -sizes[i] <= index && index < sizes[i] && "index out of bounds" failed.
Oct 24 11:37:11 sv-ai ktransformers[63681]: ../aten/src/ATen/native/cuda/IndexKernel.cu:92: operator(): block: [0,0,0], thread: [6,0,0] Assertion -sizes[i] <= index && index < sizes[i] && "index out of bounds" failed.
Oct 24 11:37:11 sv-ai ktransformers[63681]: ../aten/src/ATen/native/cuda/IndexKernel.cu:92: operator(): block: [0,0,0], thread: [7,0,0] Assertion -sizes[i] <= index && index < sizes[i] && "index out of bounds" failed.
Oct 24 11:37:11 sv-ai ktransformers[63681]: ../aten/src/ATen/native/cuda/IndexKernel.cu:92: operator(): block: [0,0,0], thread: [8,0,0] Assertion -sizes[i] <= index && index < sizes[i] && "index out of bounds" failed.
Oct 24 11:37:11 sv-ai ktransformers[63681]: ../aten/src/ATen/native/cuda/IndexKernel.cu:92: operator(): block: [0,0,0], thread: [9,0,0] Assertion -sizes[i] <= index && index < sizes[i] && "index out of bounds" failed.
Oct 24 11:37:11 sv-ai ktransformers[63681]: ../aten/src/ATen/native/cuda/IndexKernel.cu:92: operator(): block: [0,0,0], thread: [10,0,0] Assertion -sizes[i] <= index && index < sizes[i] && "index out of bounds" failed.
Oct 24 11:37:11 sv-ai ktransformers[63681]: ../aten/src/ATen/native/cuda/IndexKernel.cu:92: operator(): block: [0,0,0], thread: [11,0,0] Assertion -sizes[i] <= index && index < sizes[i] && "index out of bounds" failed.
Oct 24 11:37:11 sv-ai ktransformers[63681]: ../aten/src/ATen/native/cuda/IndexKernel.cu:92: operator(): block: [0,0,0], thread: [12,0,0] Assertion -sizes[i] <= index && index < sizes[i] && "index out of bounds" failed.
Oct 24 11:37:11 sv-ai ktransformers[63681]: ../aten/src/ATen/native/cuda/IndexKernel.cu:92: operator(): block: [0,0,0], thread: [13,0,0] Assertion -sizes[i] <= index && index < sizes[i] && "index out of bounds" failed.
Oct 24 11:37:11 sv-ai ktransformers[63681]: ../aten/src/ATen/native/cuda/IndexKernel.cu:92: operator(): block: [0,0,0], thread: [14,0,0] Assertion -sizes[i] <= index && index < sizes[i] && "index out of bounds" failed.
Oct 24 11:37:11 sv-ai ktransformers[63681]: ../aten/src/ATen/native/cuda/IndexKernel.cu:92: operator(): block: [0,0,0], thread: [15,0,0] Assertion -sizes[i] <= index && index < sizes[i] && "index out of bounds" failed.
Oct 24 11:37:11 sv-ai ktransformers[63681]: ../aten/src/ATen/native/cuda/IndexKernel.cu:92: operator(): block: [0,0,0], thread: [16,0,0] Assertion -sizes[i] <= index && index < sizes[i] && "index out of bounds" failed.
Oct 24 11:37:11 sv-ai ktransformers[63681]: ../aten/src/ATen/native/cuda/IndexKernel.cu:92: operator(): block: [0,0,0], thread: [17,0,0] Assertion -sizes[i] <= index && index < sizes[i] && "index out of bounds" failed.
Oct 24 11:37:11 sv-ai ktransformers[63681]: ../aten/src/ATen/native/cuda/IndexKernel.cu:92: operator(): block: [0,0,0], thread: [18,0,0] Assertion -sizes[i] <= index && index < sizes[i] && "index out of bounds" failed.
Oct 24 11:37:11 sv-ai ktransformers[63681]: ../aten/src/ATen/native/cuda/IndexKernel.cu:92: operator(): block: [0,0,0], thread: [19,0,0] Assertion -sizes[i] <= index && index < sizes[i] && "index out of bounds" failed.
Oct 24 11:37:11 sv-ai ktransformers[63681]: ../aten/src/ATen/native/cuda/IndexKernel.cu:92: operator(): block: [0,0,0], thread: [20,0,0] Assertion -sizes[i] <= index && index < sizes[i] && "index out of bounds" failed.
Oct 24 11:37:11 sv-ai ktransformers[63681]: ../aten/src/ATen/native/cuda/IndexKernel.cu:92: operator(): block: [0,0,0], thread: [21,0,0] Assertion -sizes[i] <= index && index < sizes[i] && "index out of bounds" failed.
Oct 24 11:37:11 sv-ai ktransformers[63681]: ../aten/src/ATen/native/cuda/IndexKernel.cu:92: operator(): block: [0,0,0], thread: [22,0,0] Assertion -sizes[i] <= index && index < sizes[i] && "index out of bounds" failed.
Oct 24 11:37:11 sv-ai ktransformers[63681]: ../aten/src/ATen/native/cuda/IndexKernel.cu:92: operator(): block: [0,0,0], thread: [23,0,0] Assertion -sizes[i] <= index && index < sizes[i] && "index out of bounds" failed.
Oct 24 11:37:11 sv-ai ktransformers[63681]: ../aten/src/ATen/native/cuda/IndexKernel.cu:92: operator(): block: [0,0,0], thread: [24,0,0] Assertion -sizes[i] <= index && index < sizes[i] && "index out of bounds" failed.
Oct 24 11:37:11 sv-ai ktransformers[63681]: ../aten/src/ATen/native/cuda/IndexKernel.cu:92: operator(): block: [0,0,0], thread: [25,0,0] Assertion -sizes[i] <= index && index < sizes[i] && "index out of bounds" failed.
Oct 24 11:37:11 sv-ai ktransformers[63681]: ../aten/src/ATen/native/cuda/IndexKernel.cu:92: operator(): block: [0,0,0], thread: [26,0,0] Assertion -sizes[i] <= index && index < sizes[i] && "index out of bounds" failed.
Oct 24 11:37:11 sv-ai ktransformers[63681]: ../aten/src/ATen/native/cuda/IndexKernel.cu:92: operator(): block: [0,0,0], thread: [27,0,0] Assertion -sizes[i] <= index && index < sizes[i] && "index out of bounds" failed.
Oct 24 11:37:11 sv-ai ktransformers[63681]: ../aten/src/ATen/native/cuda/IndexKernel.cu:92: operator(): block: [0,0,0], thread: [28,0,0] Assertion -sizes[i] <= index && index < sizes[i] && "index out of bounds" failed.
Oct 24 11:37:11 sv-ai ktransformers[63681]: ../aten/src/ATen/native/cuda/IndexKernel.cu:92: operator(): block: [0,0,0], thread: [29,0,0] Assertion -sizes[i] <= index && index < sizes[i] && "index out of bounds" failed.
Oct 24 11:37:11 sv-ai ktransformers[63681]: ../aten/src/ATen/native/cuda/IndexKernel.cu:92: operator(): block: [0,0,0], thread: [30,0,0] Assertion -sizes[i] <= index && index < sizes[i] && "index out of bounds" failed.
Oct 24 11:37:11 sv-ai ktransformers[63681]: ../aten/src/ATen/native/cuda/IndexKernel.cu:92: operator(): block: [0,0,0], thread: [31,0,0] Assertion -sizes[i] <= index && index < sizes[i] && "index out of bounds" failed.
Oct 24 11:37:11 sv-ai ktransformers[63681]: ../aten/src/ATen/native/cuda/IndexKernel.cu:92: operator(): block: [0,0,0], thread: [32,0,0] Assertion -sizes[i] <= index && index < sizes[i] && "index out of bounds" failed.
Oct 24 11:37:11 sv-ai ktransformers[63681]: ../aten/src/ATen/native/cuda/IndexKernel.cu:92: operator(): block: [0,0,0], thread: [33,0,0] Assertion -sizes[i] <= index && index < sizes[i] && "index out of bounds" failed.
Oct 24 11:37:11 sv-ai ktransformers[63681]: ../aten/src/ATen/native/cuda/IndexKernel.cu:92: operator(): block: [0,0,0], thread: [34,0,0] Assertion -sizes[i] <= index && index < sizes[i] && "index out of bounds" failed.
Oct 24 11:37:11 sv-ai ktransformers[63681]: ../aten/src/ATen/native/cuda/IndexKernel.cu:92: operator(): block: [0,0,0], thread: [35,0,0] Assertion -sizes[i] <= index && index < sizes[i] && "index out of bounds" failed.
Oct 24 11:37:11 sv-ai ktransformers[63681]: ../aten/src/ATen/native/cuda/IndexKernel.cu:92: operator(): block: [0,0,0], thread: [36,0,0] Assertion -sizes[i] <= index && index < sizes[i] && "index out of bounds" failed.
Oct 24 11:37:11 sv-ai ktransformers[63681]: ../aten/src/ATen/native/cuda/IndexKernel.cu:92: operator(): block: [0,0,0], thread: [37,0,0] Assertion -sizes[i] <= index && index < sizes[i] && "index out of bounds" failed.
Oct 24 11:37:11 sv-ai ktransformers[63681]: ../aten/src/ATen/native/cuda/IndexKernel.cu:92: operator(): block: [0,0,0], thread: [38,0,0] Assertion -sizes[i] <= index && index < sizes[i] && "index out of bounds" failed.
Oct 24 11:37:11 sv-ai ktransformers[63681]: ../aten/src/ATen/native/cuda/IndexKernel.cu:92: operator(): block: [0,0,0], thread: [39,0,0] Assertion -sizes[i] <= index && index < sizes[i] && "index out of bounds" failed.
Oct 24 11:37:11 sv-ai ktransformers[63681]: ../aten/src/ATen/native/cuda/IndexKernel.cu:92: operator(): block: [0,0,0], thread: [40,0,0] Assertion -sizes[i] <= index && index < sizes[i] && "index out of bounds" failed.
Oct 24 11:37:11 sv-ai ktransformers[63681]: ../aten/src/ATen/native/cuda/IndexKernel.cu:92: operator(): block: [0,0,0], thread: [41,0,0] Assertion -sizes[i] <= index && index < sizes[i] && "index out of bounds" failed.
Oct 24 11:37:11 sv-ai ktransformers[63681]: ../aten/src/ATen/native/cuda/IndexKernel.cu:92: operator(): block: [0,0,0], thread: [42,0,0] Assertion -sizes[i] <= index && index < sizes[i] && "index out of bounds" failed.
Oct 24 11:37:11 sv-ai ktransformers[63681]: ../aten/src/ATen/native/cuda/IndexKernel.cu:92: operator(): block: [0,0,0], thread: [43,0,0] Assertion -sizes[i] <= index && index < sizes[i] && "index out of bounds" failed.
Oct 24 11:37:11 sv-ai ktransformers[63681]: ../aten/src/ATen/native/cuda/IndexKernel.cu:92: operator(): block: [0,0,0], thread: [44,0,0] Assertion -sizes[i] <= index && index < sizes[i] && "index out of bounds" failed.
Oct 24 11:37:11 sv-ai ktransformers[63681]: ../aten/src/ATen/native/cuda/IndexKernel.cu:92: operator(): block: [0,0,0], thread: [45,0,0] Assertion -sizes[i] <= index && index < sizes[i] && "index out of bounds" failed.
Oct 24 11:37:11 sv-ai ktransformers[63681]: ../aten/src/ATen/native/cuda/IndexKernel.cu:92: operator(): block: [0,0,0], thread: [46,0,0] Assertion -sizes[i] <= index && index < sizes[i] && "index out of bounds" failed.
Oct 24 11:37:11 sv-ai ktransformers[63681]: ../aten/src/ATen/native/cuda/IndexKernel.cu:92: operator(): block: [0,0,0], thread: [47,0,0] Assertion -sizes[i] <= index && index < sizes[i] && "index out of bounds" failed.
Oct 24 11:37:11 sv-ai ktransformers[63681]: ../aten/src/ATen/native/cuda/IndexKernel.cu:92: operator(): block: [0,0,0], thread: [48,0,0] Assertion -sizes[i] <= index && index < sizes[i] && "index out of bounds" failed.
Oct 24 11:37:11 sv-ai ktransformers[63681]: ../aten/src/ATen/native/cuda/IndexKernel.cu:92: operator(): block: [0,0,0], thread: [49,0,0] Assertion -sizes[i] <= index && index < sizes[i] && "index out of bounds" failed.
Oct 24 11:37:11 sv-ai ktransformers[63681]: ../aten/src/ATen/native/cuda/IndexKernel.cu:92: operator(): block: [0,0,0], thread: [50,0,0] Assertion -sizes[i] <= index && index < sizes[i] && "index out of bounds" failed.
Oct 24 11:37:11 sv-ai ktransformers[63681]: ../aten/src/ATen/native/cuda/IndexKernel.cu:92: operator(): block: [0,0,0], thread: [51,0,0] Assertion -sizes[i] <= index && index < sizes[i] && "index out of bounds" failed.
Oct 24 11:37:11 sv-ai ktransformers[63681]: ../aten/src/ATen/native/cuda/IndexKernel.cu:92: operator(): block: [0,0,0], thread: [52,0,0] Assertion -sizes[i] <= index && index < sizes[i] && "index out of bounds" failed.
Oct 24 11:37:11 sv-ai ktransformers[63681]: ../aten/src/ATen/native/cuda/IndexKernel.cu:92: operator(): block: [0,0,0], thread: [53,0,0] Assertion -sizes[i] <= index && index < sizes[i] && "index out of bounds" failed.
Oct 24 11:37:11 sv-ai ktransformers[63681]: ../aten/src/ATen/native/cuda/IndexKernel.cu:92: operator(): block: [0,0,0], thread: [54,0,0] Assertion -sizes[i] <= index && index < sizes[i] && "index out of bounds" failed.
Oct 24 11:37:11 sv-ai ktransformers[63681]: ../aten/src/ATen/native/cuda/IndexKernel.cu:92: operator(): block: [0,0,0], thread: [55,0,0] Assertion -sizes[i] <= index && index < sizes[i] && "index out of bounds" failed.
Oct 24 11:37:11 sv-ai ktransformers[63681]: ../aten/src/ATen/native/cuda/IndexKernel.cu:92: operator(): block: [0,0,0], thread: [56,0,0] Assertion -sizes[i] <= index && index < sizes[i] && "index out of bounds" failed.
Oct 24 11:37:11 sv-ai ktransformers[63681]: ../aten/src/ATen/native/cuda/IndexKernel.cu:92: operator(): block: [0,0,0], thread: [57,0,0] Assertion -sizes[i] <= index && index < sizes[i] && "index out of bounds" failed.
Oct 24 11:37:11 sv-ai ktransformers[63681]: ../aten/src/ATen/native/cuda/IndexKernel.cu:92: operator(): block: [0,0,0], thread: [58,0,0] Assertion -sizes[i] <= index && index < sizes[i] && "index out of bounds" failed.
Oct 24 11:37:11 sv-ai ktransformers[63681]: ../aten/src/ATen/native/cuda/IndexKernel.cu:92: operator(): block: [0,0,0], thread: [59,0,0] Assertion -sizes[i] <= index && index < sizes[i] && "index out of bounds" failed.
Oct 24 11:37:11 sv-ai ktransformers[63681]: ../aten/src/ATen/native/cuda/IndexKernel.cu:92: operator(): block: [0,0,0], thread: [60,0,0] Assertion -sizes[i] <= index && index < sizes[i] && "index out of bounds" failed.
Oct 24 11:37:11 sv-ai ktransformers[63681]: ../aten/src/ATen/native/cuda/IndexKernel.cu:92: operator(): block: [0,0,0], thread: [61,0,0] Assertion -sizes[i] <= index && index < sizes[i] && "index out of bounds" failed.
Oct 24 11:37:11 sv-ai ktransformers[63681]: ../aten/src/ATen/native/cuda/IndexKernel.cu:92: operator(): block: [0,0,0], thread: [62,0,0] Assertion -sizes[i] <= index && index < sizes[i] && "index out of bounds" failed.
Oct 24 11:37:11 sv-ai ktransformers[63681]: ../aten/src/ATen/native/cuda/IndexKernel.cu:92: operator(): block: [0,0,0], thread: [63,0,0] Assertion -sizes[i] <= index && index < sizes[i] && "index out of bounds" failed.
Oct 24 11:37:11 sv-ai kernel: pt_main_thread[63681]: segfault at 0 ip 0000709ea8ace279 sp 00007fff53546ca0 error 4 in libcuda.so.560.35.03[709ea86b0000+4b6000] likely on CPU 113 (core 49, socket 0)
Oct 24 11:37:11 sv-ai kernel: Code: 84 dc 00 00 00 83 3d 9d c4 c6 01 02 48 8b 0f 77 09 f6 05 a1 c4 c6 01 01 74 10 44 8b 05 94 c4 c6 01 45 85 c0 0f 84 97 00 00 00 <48> 8b 09 4c 8b 41 70 8b 4f 10 4c 01 c1 48 29 ca 8b 48 20 01 f2 48

Could you please provide the yaml file and launch command? Based on the above error message, we cannot determine which operator the error occurred in.


making env vars conditional

It will be rare, but some applications don't need user-supplied env-vars. This makes envs conditional.

Envs should already be conditional via the with block:
# Source: application/templates/deployment.yaml
apiVersion: apps/v1
kind: Deployment
metadata:
  name: RELEASE-NAME
  labels:
    app.kubernetes.io/name: RELEASE-NAME
    app.kubernetes.io/managed-by: massdriver.cloud
spec:
  replicas:
  selector:
    matchLabels:
      app.kubernetes.io/name: RELEASE-NAME
  template:
    metadata:
      labels:
        app.kubernetes.io/name: RELEASE-NAME
    spec:
      serviceAccountName: RELEASE-NAME
      containers:
        - name: RELEASE-NAME
          image: ":"
          imagePullPolicy: Always
          resources:

Oh interesting, I  thought I observed it adding blanks for this and for the args but I ran a local template too and lgtm 👍


MySQL database example

This feature creates an example usage of MySQL database brick

I have read the CLA Document and I hereby sign the CLA


Crash on start RE8

Hi!
I am very much not an expert. I downloaded the files and put them in the folder of the game.
The game crashes almost immediately. I am attaching the "re2_framework_log" file.  Thanks for any help
re2_framework_log.txt
!

EMPRESS Version? Doesnt work at all for now

exact the same Problem here..

@praydog

same problem to me: Failed to initialize REFramework on DirectX 12
any solution at now?


Do not fetch filter element with querySelectorAll...

This PR removes querySelectorAll calls and uses the is method of the element (through angular.element) to match the event's source (or target) against the filtered selector.
This should resolve #26 without big performance issues.

is is not part of Angular's jqLite, this introduces a dependency on jQuery.
is also does not perform the same action as node.contains.  As is only checks if target is one of the elms; not if the target is within one of the elms. What is needed would be more similar to jQuery's $.contains.  But again, we don't want to depend on jQuery and jqLite doesn't support it. So we use the native node.contains (which is probably what $.contains would eventually call.) The issue here is that node.contains needs nodes and not selectors, so we must turn the selectors into a list of node and check them one at a time.
Really, to solve the issue, we can move the document.querySelectorAll up to the event handler before the for loop to make sure we check the selectors against the current elements on the page at the time of the click. But in that lies the performance issue as all of this would be happening on each and every click; multiplied by the amount of times this directive is on the page.

closing this seems a reasonable decision given the dependency it introduces. :+1: