Vary favicon by domain

I serve multiple domains from a single Express app and would like to be able to change the favicon for each domain. ie: I want to vary the image file I choose to pass to favicon() based on req.hostname. The hostnames are chosen by the users and are sometimes only different by the sub-domain.
I can't see a way to vary the favicon chosen based on req.hostname and reading this issue it seems there may not be a way to do so.

I'm not 100% sure I understand what you're trying to do? Do you think whipping up a proposal PR would help?

Good plan. I've added PR #32 as a potential implementation

Could you do this? Just a thought based on the current usage pattern in the README.
var exampleIcon = favicon(...);
var defaultIcon = favicon(...);

app.use(function (req, res, next) {
  if (req.hostname === 'example.com') {
    return exampleIcon(req, res, next);
  }

  return defaultIcon(req, res, next);
});

Conversation conclusion in the PR: https://github.com/expressjs/serve-favicon/pull/32#issuecomment-260845762


json::parse(...) vs json j; j.parse(...)

I was wondering if there is a reason that a call to parse on a json object just returns a null json object? The same input seems to parse without issue using the jason::parse call.
For example the following program:
{
    std::string input("{\"happy\":true,\"pi\":3.141}");
    json j;
    j.parse(input);
    std::cout << j.dump() << std::endl;
    j=json::parse(input);
    std::cout << j.dump() << std::endl;
}

Results in (osx):
null
{"happy":true,"pi":3.141}

In the upper example, you create a json object j which is initially null. In line 4, you basically call the static function json::parse(input); which returns the result of the deserialization. As this result is not stored, j remains unchanged. In line 6, you make the same call, but store the result in j, yielding the expected result.
Again: parse is not a member function, but a static function. Calling it as a member function is syntactically OK, but does not change the object you call it from.

The parse function is static.  There is no such thing as calling it "on an object", except that C++ allows you to identify the static function to call using an object instead of the class name.
Your code is equivalent to this:
std::string input("{\"happy\":true,\"pi\":3.141}");
json::parse(input);
std::cout << json().dump() << std::endl;
json j=json::parse(input);
std::cout << j.dump() << std::endl;

Heh, I saw @nlohmann's answer appear just as I clicked the Comment button.  :)

Same here, but Github claims I was 3 seconds faster ;)

Ah, thank you. I had not noticed that it was a static method.


fix(moodle): support tiny plugins

Checklist:

[x] Have you added an explanation of what your changes do and why you'd like them to be included?
[ ] Have you updated or added documentation for the change, as applicable?
[x] Have you tested your changes on all related environments with successful results, as applicable?

Type of Changes:

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

What is the current behavior? (link to any open issues here)
https://github.com/krestomatio/container_builder/issues/144
What is the new behavior (if this is a feature change)?
N/A
Other information:

/ok-to-test

/approve


workbox-precaching routes are not compatible with other packages

Library Affected:
workbox-precaching
The addRoute() (and by extension precacheAndRoute()) method in workbox-precaching adds its own fetch event listener + cache-first response logic rather than depending on the Router and Route modules from workbox-routing and the CacheFirst module from workbox-strategies.
This is not ideal for a few reasons:

Code is duplicated and needs to be tested twice
Logging for precached routes is different from logging for all other routes
Precache route handlers are not exposed to the developer, so they can't be reused with workbox-streams code (instead, developers have to create their own CacheFirst strategy instances anyway).

Similarly, the configuration options that addRoute() and precacheAndRoute() offer is not accessible to other routes.
I'm sure there's historical reasons for (from the sw-precache/sw-toolbox merge), but I think we should explore whether it would be possible to consolidate these features in the future.
IMO, ideally, workbox-precaching would depend on workbox-routing and workbox-strategies, and the configuration options for customizing preaching routes could be added to the workbox-routing package and thus available to all routes.

I do vote for @philipwalton for this, since it'll expose all options of workbox-strategies to precache eventually resolving issue #1760. By default it should depend on CacheFirst / CacheFirst strategy.

I do vote for @philipwalton for this, since it'll expose all options of workbox-strategies to precache eventually resolving issue #1760 and add great flexibility. By default it should depend on CacheFirst / CacheFirst strategy.
After this developers can use other strategies for precache like staleWhileRevalidate, etc, refer https://stackoverflow.com/questions/54651722/how-can-i-set-a-default-setcatchhandler-with-google-workbox-v4 and #1897.


Fix a "defined but not used" warning when enabling ssl-trace

Checklist

[x] CLA is signed

Description of change

Pushed. Thanks.


Make Register Update Flattening a Transform and Delete Dangling Nodes

Fixes #681
This pulls the register update flattening out of the actual Emitter logic into a separate transform (that is run in the VerilogEmitter). It follows running that transform with DeadCodeElimination to elimination any dangling logic.
This currently fails 1 test, the test for supporting registers with no ports. The 2nd run of DeadCodeElimination fails because the first run deletes the only module. I'm thinking this test is nonsensical but maybe DCE should be careful not to delete the top module even if it has no ports?
I'm also wondering if the two runs of DCE are necessary, we could just run it once but it seems weird to do that in the Verilog compiler only rather than in the transform LowFirrtlOptimization. That being said, it really seems to me that the mux tree flattening should be part of the Verilog Emitter's set of transforms since it is really only needed for Verilog emission. Maybe there's some way to restructure transform ordering to make this cleaner...

Ensure -no-dce opt prevents both DCEs from running

Is this ready for review?

I've addressed the feedback!


Commit message from CommitPack unused?

Hey folks,
Nice work! Something came to mind as I browsed your code: it looks like you only used the commit subject from CommitPack during training of OctoCoder. Is that correct? (I'm concluding it based on what you have said in #9 regarding the format, and the contents of the repository here).
Did you guys experiment with using the commit message as well? Or was there a reason you decided not to use it?
Thanks!

Yes that's correct. The reason is that the message is usually exactly the same. If it's not the same it often includes external references which we don't want.
You can browse samples here: https://huggingface.co/datasets/bigcode/commitpackft/viewer/kotlin?row=1


Using HTML inside Popovers

How do you render HTML content inside popover? I tried something like:
TbHtml::popover('', false, 'Products:
 Services:', array('html'=>true));

but it didn't work. The rendered HTML was:

Is it possible to render something like:

Or maybe setting html attribute for popover?
$('.popover-with-html').popover({ html : true });

One quick fix is Open tbapi.php at extensions/bootstrap/components
Add a line inside registerPopover function as $options['html']=true; when $options['selector'] is set


LED Wiring Sequence

Hi, first of all thanks for the development you did for this project.
I have a question regarding the order of the LED segments....
Which order do I wire the "Colon Separator" and the "Downlight" LEDs?
I am assuming they are wired after the "time digits", but which ones go first, the downlight or the colon??
and is there a config for the number of "downlight" leds?

The colon separator goes between the hours and minutes so using this image that would be between 14 and 15. Any LEDs that will come after the very last part (part 23 using that image) will be used as a downlight. Or as i wrote in #2:

252 LEDs for the clock and 14 LEDs as down lights will equal 266 LEDs, so just set this as your pixel count in the wled settings and you are good to go. My effect calculates how many leds are needed (in your case 4x7x9 = 252) and uses every pixel that will come after that as a downlight. So 253-262 will be downlights.

But make sure you enable the colon separator as described in the readme and set the correct led count.

Thanks


missing documentation

There is no documentation on the management server created during the deployment.

@swathibhat1 let's created this item in the features backlog to time the work on it.


Add example project

This pull request adds the example project provided from VS.
It also adds the resources folder to show file icons.

Need to squash the pull request!


Static pods being recycled on TP cluster

What happened:
The static pods on TP master nodes were recycled after the cluster is set.
sonyali@sonya-uswest2:~/go/src/k8s.io/arktos$ ./_output/dockerized/bin/linux/amd64/kubectl --kubeconfig=./test/kubemark/resources/kubeconfig.kubemark-tp-2 get pods -AT
TENANT   NAMESPACE     NAME                                                           HASHKEY               READY   STATUS    RESTARTS   AGE
system   kube-system   etcd-empty-dir-cleanup-rel022621-2x500-kubemark-tp-2-master<PHONE_NUMBER>574742017   0/1     Pending   0          3s
system   kube-system   etcd-server-events-rel022621-2x500-kubemark-tp-2-master<PHONE_NUMBER>917778344   0/1     Pending   0          5s
system   kube-system   etcd-server-rel022621-2x500-kubemark-tp-2-master<PHONE_NUMBER>134919778   0/1     Pending   0          5s
system   kube-system   kube-addon-manager-rel022621-2x500-kubemark-tp-2-master<PHONE_NUMBER>066034443   0/1     Pending   0          2s
system   kube-system   kube-apiserver-rel022621-2x500-kubemark-tp-2-master<PHONE_NUMBER>81931563    0/1     Pending   0          5s
system   kube-system   kube-controller-manager-rel022621-2x500-kubemark-tp-2-master<PHONE_NUMBER>784413759   0/1     Pending   0          5s
system   kube-system   kube-scheduler-rel022621-2x500-kubemark-tp-2-master<PHONE_NUMBER>91752828    0/1     Pending   0          5s
system   kube-system   kubernetes-dashboard-57d4548978-b5mx6<PHONE_NUMBER>75403707    1/1     Running   9          30m
system   kube-system   metadata-proxy-v0.1-gxmv4<PHONE_NUMBER>074255224   0/2     Pending   0          27m
sonyali@sonya-uswest2:~/go/src/k8s.io/arktos$ ./_output/dockerized/bin/linux/amd64/kubectl --kubeconfig=./test/kubemark/resources/kubeconfig.kubemark-proxy get pods -AT
TENANT   NAMESPACE     NAME                                                           HASHKEY               READY   STATUS    RESTARTS   AGE
system   kube-system   etcd-empty-dir-cleanup-rel022621-2x500-kubemark-tp-1-master<PHONE_NUMBER>574742017   1/1     Running   0          11s
system   kube-system   etcd-server-events-rel022621-2x500-kubemark-tp-1-master<PHONE_NUMBER>471478084   1/1     Running   0          13s
system   kube-system   etcd-server-rel022621-2x500-kubemark-tp-1-master<PHONE_NUMBER>973656951   1/1     Running   0          13s
system   kube-system   kube-addon-manager-rel022621-2x500-kubemark-tp-1-master<PHONE_NUMBER>066034443   1/1     Running   0          11s
system   kube-system   kube-apiserver-rel022621-2x500-kubemark-tp-1-master<PHONE_NUMBER>027077171   1/1     Running   0          13s
system   kube-system   kube-controller-manager-rel022621-2x500-kubemark-tp-1-master<PHONE_NUMBER>35741203    1/1     Running   0          11s
system   kube-system   kube-scheduler-rel022621-2x500-kubemark-tp-1-master<PHONE_NUMBER>91752828    1/1     Running   1          10s
system   kube-system   kubernetes-dashboard-57d4548978-7mqb4<PHONE_NUMBER>236258716   0/1     Pending   0          35m
system   kube-system   metadata-proxy-v0.1-dbq6w<PHONE_NUMBER>770946384   0/2     Pending   0          28m
sonyali@sonya-uswest2:~/go/src/k8s.io/arktos$ ./_output/dockerized/bin/linux/amd64/kubectl --kubeconfig=./test/kubemark/resources/kubeconfig.kubemark-tp-1 get pods -AT
TENANT   NAMESPACE     NAME                                                           HASHKEY               READY   STATUS    RESTARTS   AGE
system   kube-system   etcd-empty-dir-cleanup-rel022621-2x500-kubemark-tp-1-master<PHONE_NUMBER>574742017   0/1     Pending   0          0s
system   kube-system   etcd-server-events-rel022621-2x500-kubemark-tp-1-master<PHONE_NUMBER>471478084   1/1     Running   0          18s
system   kube-system   etcd-server-rel022621-2x500-kubemark-tp-1-master<PHONE_NUMBER>973656951   1/1     Running   0          17s
system   kube-system   kube-addon-manager-rel022621-2x500-kubemark-tp-1-master<PHONE_NUMBER>066034443   1/1     Running   0          16s
system   kube-system   kube-apiserver-rel022621-2x500-kubemark-tp-1-master<PHONE_NUMBER>027077171   1/1     Running   0          17s
system   kube-system   kube-controller-manager-rel022621-2x500-kubemark-tp-1-master<PHONE_NUMBER>35741203    1/1     Running   0          16s
system   kube-system   kube-scheduler-rel022621-2x500-kubemark-tp-1-master<PHONE_NUMBER>91752828    1/1     Running   1          17s
system   kube-system   kubernetes-dashboard-57d4548978-7mqb4<PHONE_NUMBER>236258716   0/1     Pending   0          36m
system   kube-system   metadata-proxy-v0.1-dbq6w<PHONE_NUMBER>770946384   0/2     Pending   0          28m

What you expected to happen:
all pods in kube-system namespace are keeping running status, no restart after cluster start up.
How to reproduce it (as minimally and precisely as possible):
sonyali@sonya-uswest2:~/go/src/k8s.io/arktos$ export KUBEMARK_NUM_NODES=1000 NUM_NODES=12 SCALEOUT_TP_COUNT=2
sonyali@sonya-uswest2:~/go/src/k8s.io/arktos$ export MASTER_DISK_SIZE=300GB MASTER_ROOT_DISK_SIZE=300GB KUBE_GCE_ZONE=us-west2-b MASTER_SIZE=n1-highmem-64 NODE_SIZE=n1-highmem-16 NODE_DISK_SIZE=300GB GOPATH=$HOME/go KUBE_GCE_ENABLE_IP_ALIASES=true KUBE_GCE_PRIVATE_CLUSTER=true CREATE_CUSTOM_NETWORK=true KUBE_GCE_INSTANCE_PREFIX=${RUN_PREFIX} KUBE_GCE_NETWORK=${RUN_PREFIX} ENABLE_KCM_LEADER_ELECT=false ENABLE_SCHEDULER_LEADER_ELECT=false ETCD_QUOTA_BACKEND_BYTES=8589934592 SHARE_PARTITIONSERVER=false LOGROTATE_FILES_MAX_COUNT=50 LOGROTATE_MAX_SIZE=200M KUBE_ENABLE_APISERVER_INSECURE_PORT=true KUBE_ENABLE_PROMETHEUS_DEBUG=true KUBE_ENABLE_PPROF_DEBUG=true TEST_CLUSTER_LOG_LEVEL=--v=2 HOLLOW_KUBELET_TEST_LOG_LEVEL=--v=2 SCALEOUT_CLUSTER=true

sonyali@sonya-uswest2:~/go/src/k8s.io/arktos$ ./cluster/kube-up.sh
sonyali@sonya-uswest2:~/go/src/k8s.io/arktos$ ./test/kubemark/start-kubemark.sh

Anything else we need to know?:
Logs can be found under GCP project: workload-controller-manager on sonya-uswest2: /home/sonyali/logs/perf-test/gce-500/arktos/rel022621-2x500
Environment:

Arktos version (use kubectl version):
···
32849a616d5 (HEAD, upstream/master) Promote admissionreview to v1 (#998)
103eaa9e749 Scheduler to connect to RP directly via separated client (#991)
2a8a5a5b5e7 fix kubelet permission issue in kube-up (#996)
08b0449c661 Promote admission webhook API to v1 (#981)
15e3e1e71fe (master, kubeletfailedregisternodes) add hack/arktos_cherrypick.sh to ensure cherrypick comments added when cherrypick from kubernetes (#990)
b0500d6dddb fix issue 655 (#992)
d11162827dc Consistent etcd key path (#989)
e679af091ff Use HTTPS as etcd-apiserver protocol when mTLS is enabled (#987)
3ade1409039 Use secure communication for client <--> proxy communication, cleanup unnecessary config files (#986)
1ffad5ca6a0 Read Arktos version from file instead of environment variable (#985)
b1b051adfdd Fix GCE deployment and arktos-up to correctly enable Vertical Scaling feature (#979)
54bb67006c9 Show more detailed message for file-updated-check (#984)
21c6205b999 Openapi addimportalias (#965)
···
Cloud provider or hardware configuration:
OS (e.g: cat /etc/os-release):
Kernel (e.g. uname -a):
Install tools:
Network plugin and version (if this is a network-related bug):
Others:

even when the mirrored pods were recycled repeated, the actually static pod processes on the master node is kept, ie. the processes are NOT restarted. so essential functionality of the master is NOT affected.
this is mostly fixd in PR 1001,  as with PR1001, only pods being in the recycled state is the dashboard pod, which is not impact perf testing.

#1042  has the root cause and suggested proper fix of this bug.

Fixed.


Refactor Flask config loading

Currently there are two issues for config class:

They all resides in one file, makes it harder to track
Local copy of a custom config needs to set "ENV_NAME" for them to be grouped together.

This refactor tries to setup a mini-framework, such that "FLASK_ENV" directly maps to a module (with the same name), that has "Config" and "LocalConfig" class.
This makes it much easier to add a custom DC config. In this PR, a top level "custom_dc" folder is created to hold a "custom.py" template config module which is readily used. This folder will also contain other static files.

Thanks for the review!


improve translate

improve translate, based on 翻译探讨 #53

原文：

What we are, unapologetically, is hostile to people who seem to be unwilling to think or to do their own homework before asking questions. People like that are time sinks — they take without giving back, and they waste time we could have spent on another question more interesting and another person more worthy of an answer. We call people like this “losers” (and for historical reasons we sometimes spell it “lusers”).

We realize that there are many people who just want to use the software we write, and who have no interest in learning technical details. For most people, a computer is merely a tool, a means to an end; they have more important things to do and lives to live. We acknowledge that, and don't expect everyone to take an interest in the technical matters that fascinate us. Nevertheless, our style of answering questions is tuned for people who do take such an interest and are willing to be active participants in problem-solving. That's not going to change. Nor should it; if it did, we would become less effective at the things we do best.

翻译：
尽管如此，我们只为那些真正有兴趣并愿意积极参与问题解决的人调整回答问题的风格。这点不会变，也不该变：否则，我们就是在最擅长的事情上降低效率。
翻译说明：
这里有两个大家争论比较大的地方：一是第一句话过长以及中英文表达风格差异带来的翻译困难；二是关于“不该变”那里的直翻表达冗余问题。

在这里，参照原文（在 do 处加了斜体强调），并结合上下文语义（前面讲了一些人只索取而不回报），增加了加粗的“只”和“真正”来尽可能传达出作者的真实含义。在这里，强调的是为谁服务，所以将“只为……的人”放在句子前面。
对于表达冗余问题，参考了上面@sailist 的翻译，并结合原文表达，更改为上述翻译版本。

Thanks for reporting the bug, we'll work on fixing it ASAP

你干啥啊，主人不在，我陪您玩啊~


nb option defaults

defaults for setting up notebooks

@marqh Nice :+1:

Coverage decreased (-0.9%) to 73.148% when pulling 08c91a64aea6be7d5cc406cfa78f161f01aef43c on marqh:defaults into 02afe1d80831bbed7cacb21632f08955951d8058 on SciTools:master.


Swift 3 Support

I've got my fork running the latest commit from master, and I have already started porting things over to Swift 3 in my private projects. Anyone else planning to work on this or should I just post my version in the near future?

It would be great to get a working version using Swift 3. It's impossible for automated migration tools to convert this library from Swift 2 to Swift 3 because the Collection indexing model has changed so radically.

I was about to start converting to swift3.. have you already finished, or do you have a decent starting point?
Thanks!

I've just had a look at converting things over. I'm not as familiar with the newer Sequence hierarchy in Swift as the old one, so any help is more than welcome. I've created a Swift 3 branch for the conversion.

Anything new?

Here is my own port of NestedSequences.swift though some type names should also change to reflect Swift 3 semantics such as TransposeGen -> TransposeIter. Use at your own risk. :)
// MARK: - Eager

// MARK: Cartesian Product

private extension IteratorProtocol where Element : Collection {
  mutating func product() -> [[Element.Iterator.Element]] {
    guard let x = next() else { return [[]] }
    let xs = product()
    return x.flatMap { h in xs.map { [h] + $0 } }
  }
}

public extension Sequence where Iterator.Element : Collection {

  /// Returns a cartesian product of self
  /// ```swift
  /// [[1, 2], [3, 4]].product()
  /// [[1, 3], [1, 4], [2, 3], [2, 4]]
  /// ```

  public func product() -> [[Iterator.Element.Iterator.Element]] {
    var g = makeIterator()
    return g.product()
  }
}

public extension Sequence where Iterator.Element : Sequence {

  /// Returns a cartesian product of self
  /// ```swift
  /// [[1, 2], [3, 4]].product()
  /// [[1, 3], [1, 4], [2, 3], [2, 4]]
  /// ```

  public func product() -> [[Iterator.Element.Iterator.Element]] {
    return map(Array.init).product()
  }
}

/// Cartesian product
/// ```swift
/// product([1, 2], [3, 4])
/// [[1, 3], [1, 4], [2, 3], [2, 4]]
/// ```

public func product<C : Collection>(_ cols: C...) -> [[C.Iterator.Element]] {
  return cols.product()
}

/// Cartesian product
/// ```swift
/// product([1, 2], [3, 4])
/// [[1, 3], [1, 4], [2, 3], [2, 4]]
/// ```

public func product<S : Sequence>(_ cols: S...) -> [[S.Iterator.Element]] {
  return cols.product()
}

// MARK: Transposition

private extension Sequence {
    func mapM<U>( _ transform: (Iterator.Element) -> U?) -> [U]? {
    var result: [U] = []
    result.reserveCapacity(underestimatedCount)
    for e in self {
      if let r = transform(e) { result.append(r) } else { return nil }
    }
    return result
  }
}

public extension Sequence where Iterator.Element : Sequence {

  /// Returns a transposed self
  /// ```swift
  /// [[1, 2, 3], [1, 2, 3], [1, 2, 3]].transpose()
  ///
  /// [[1, 1, 1], [2, 2, 2], [3, 3, 3]]
  /// ```

  func transpose() -> [[Iterator.Element.Iterator.Element]] {
    return Array(TransposeSeq(seq: self))
  }
}

// MARK: - Lazy

// MARK: Cartesian Product
/// :nodoc:
public struct ProdGen<C : Collection> : IteratorProtocol {

  fileprivate let cols: [C] // Must be collections, not sequences, in order to be multi-pass

  fileprivate var gens: [C.Iterator]
  fileprivate var curr: [C.Iterator.Element]
  /// :nodoc:
  public mutating func next() -> [C.Iterator.Element]? {

    for i in gens.indices.reversed() { // Loop through generators in reverse order, rolling over
      if let n = gens[i].next() {     // if generator isn't finished, just increment that column, return
        curr[i] = n
        return curr
      } else {                        // generator is finished
        gens[i] = cols[i].makeIterator()  // reset the generator
        curr[i] = gens[i].next()!     // set the current column to the first element of the generator
      }
    }
    return nil
  }

  fileprivate init(cols: [C]) {
    var gens = cols.map{$0.makeIterator()}
    self.cols = cols
    curr = gens.dropLast().indices.map{gens[$0].next()!} + [self.cols.last!.first!]
    /**
    set curr to the first value of each of the generators, except the last: don't
    increment this generator, so that the first value returned contains it.
    */
    self.gens = gens
  }
}
/// :nodoc:
public struct ProdSeq<C : Collection> : LazySequenceProtocol {
  fileprivate let cols: [C]
  /// :nodoc:
  public func makeIterator() -> ProdGen<C> {
    return ProdGen( cols: cols )
  }
  /// :nodoc:
  public func underestimateCount() -> Int {
    return cols.reduce(1) { (n,c) in n * c.underestimatedCount }
  }
}

/// Lazy Cartesian Product
/// ```swift
/// lazyProduct([1, 2], [3, 4])
///
/// [1, 3], [1, 4], [2, 3], [2, 4]
/// ```

public func lazyProduct<C : Collection>
  (_ cols: C...) -> ProdSeq<C> {
    return ProdSeq(cols: cols)
}

/// Lazy Cartesian Product
/// ```swift
/// lazyProduct([1, 2], [3, 4])
///
/// [1, 3], [1, 4], [2, 3], [2, 4]
/// ```

public func lazyProduct<S : Sequence>
  (_ cols: S...) -> ProdSeq<[S.Iterator.Element]> {
    return ProdSeq(cols: cols.map(Array.init))
}

public extension Sequence where Iterator.Element : Sequence {

  /// Lazy Cartesian Product
  /// ```swift
  /// [[1, 2], [3, 4]].lazyProduct()
  ///
  /// [1, 3], [1, 4], [2, 3], [2, 4]
  /// ```

  func lazyProduct() -> ProdSeq<[Iterator.Element.Iterator.Element]> {
    return ProdSeq(cols: map(Array.init))
  }
}

public extension Sequence where Iterator.Element : Collection {

  /// Lazy Cartesian Product
  /// ```swift
  /// [[1, 2], [3, 4]].lazyProduct()
  ///
  /// [1, 3], [1, 4], [2, 3], [2, 4]
  /// ```

  func lazyProduct() -> ProdSeq<Iterator.Element> {
    return ProdSeq(cols: Array(self))
  }
}

// MARK: Transposition
/// :nodoc:
public struct TransposeGen<T, G : IteratorProtocol> : IteratorProtocol where G.Element == T {
  fileprivate var gens: [G]
  /// :nodoc:
  mutating public func next() -> [T]? {
    return gens.indices.mapM { i in gens[i].next() }
  }
}
/// :nodoc:
public struct TransposeSeq<
    S : Sequence> : LazySequenceProtocol where
    S.Iterator.Element : Sequence
{
    fileprivate let seq: S
    /// :nodoc:
    public func makeIterator()
        -> TransposeGen<S.Iterator.Element.Iterator.Element, S.Iterator.Element.Iterator>{
            return TransposeGen(gens: seq.map { g in g.makeIterator() })
    }
}

public extension TransposeSeq where S: Collection {
    public var underestimatedCount: Int {
        return seq.first?.underestimatedCount ?? 0
    }
}

public extension LazySequenceProtocol where Iterator.Element: Sequence {

  /// Returns a lazily transposed self
  /// ```swift
  /// lazy([[1, 2, 3], [1, 2, 3], [1, 2, 3]]).transpose()
  ///
  /// [1, 1, 1], [2, 2, 2], [3, 3, 3]
  /// ```
  func transpose() -> TransposeSeq<Self> {
    return TransposeSeq(seq: self)
  }
}


sign in/ sign up page

page 1: login on same page.
page 2: sign up for a user
page 3: [already created as bunkerowner] sign up as business.
linked to one another

Lets try to use google or facebook api for sign in as well.
Or idk use 0auth??
Commenting to remember


register_field not working

I've browsed the code and it doesn't seem to be making any requests. In any case, I'm trying to add a field like current_user.leads.register_field("CustomXX", "textarea") and it doesn't add it.
-R.

Sobject.register_field is not meant to be public- it's definitely undocumented.  The fact that's it's public is just a mistake.  I'll correct that in a later version

So you can't create a salesforce field?

There is no support in Salesforce's REST API for creating new Sobject types or fields.  Since the gem just wraps the API, the gem can't do that either.

Ok, thanks.


Avoid using href for choosing tabs.

Hi there,
I was having an issue with working with href attribute. The href attribute modifies the url and can mess up any routing that I had set up. So to avoid breaking my routing, Instead of doing

I made the html look like this.

Then i had to change some of the js. Replacing all calls getting the hash to getting dataset.tab.
So this worked as a quick fix but I'm not sure if it is the best idea. All  tags should have an href so the html tags should probably be changed if you remove the href.
Maybe it would work better if you pass it in as an option to the leaflet-sidebar? I'm not sure if you have any thoughts on this but I thought it was interesting.

Looks good but does not working in IE <= 10 (dataset is not supported).
But it is easy to make it working. Just change
child.firstChild.dataset.tab

into
child.firstChild.getAttribute('data-tab')

and
this._sidebar.open(this.firstChild.dataset.tab.slice(1));

into
this._sidebar.open(this.firstChild.getAttribute('data-tab').slice(1));

I think this should be fixed in the current master branch. I'm still using the href attribute, but the URL is no longer modified.


Explore declarative-query system for Context

... and/or ability to late-bind BOXED or PROFILE stores.

Explored notion of a query-system, went with a simpler protocol in #2906.
Will make a new ticket for late-binding context stores.


Deprecated NOAA library

After building I'm now getting a warning for using a deprecated noaa consumer.  Can this project switch to the new library?
2016/04/18 09:21:35 Starting DataDog Firehose Nozzle...
2016/04/18 09:21:35 You are using a deprecated noaa consumer (noaa.Consumer).  Please switch to 'github.com/cloudfoundry/noaa/consumer'.Consumer at your earliest convenience.
2016/04/18 09:21:50 Posting 835 metrics

@mjseid We recently changed NOAA's implementation. We will be moving to the new consumer package soon.

Fixed with this PR


Update fs2-core, fs2-io, ... to 3.0.1

Updates

co.fs2:fs2-core
co.fs2:fs2-io
co.fs2:fs2-reactive-streams

from 3.0.0 to 3.0.1.
GitHub Release Notes - Changelog - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Files still referring to the old version number
The following files still refer to the old version number (3.0.0).
You might want to review and update them manually.
.github/workflows/ci.yml
project/Http4sPlugin.scala
website/src/hugo/content/changelog.md

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "co.fs2" } ]

labels: library-update, semver-patch, old-version-remains

The build failure is an ip4s issue.


Note browser is slow

I'm running an external process for each of the notes and it takes more than it should to display them.

For those who also notice the lag in the note browser, you can :set grepprg=grep\ -n as a temporary solution.

This issue is caused by #9.


.NET enterprise chat app

Summary
Describe your changes here.
Fixes #Issue_Number (if available)

Internal previews

📄 File
🔗 Preview link

docs/azure/ai/get-started-app-chat-template.md
CustomerIntent: As a .NET developer new to Azure OpenAI, I want deploy and use sample code to interact with app infused with my own business data so that learn from the sample code.

Wow, this looks really familiar 🤓


Add a hotkey to toggle Moderation mode while holding a key, like SHIFT on Discord.

Checklist

[X] I'm reporting a problem with Chatterino
[X] I've verified that I'm running the most recent nightly build or stable release
[X] I've looked for my problem on the wiki
[X] I've searched the issues and pull requests for similar looking reports

Describe your issue
Suggestion to add a hotkey to toggle Moderation mode while holding a key, like SHIFT on Discord.
When that is done, this icon here

goes like this

and all uhhhh features that it would do are now on
Screenshots
No response
OS and Chatterino Version
none

I'm not so sure that this will work because enabling moderation mode needs to reposition all messages. Having the message you want delete slide away from the cursor isn't a very good experience.

well, peepoShrug
on Discord the icons within that context menu repositino as well

Bumping this if I may, an on/off toggle would be really useful whether it's held or just a switch. Repositioning wouldn't be a problem.

There is an issue here. The chat input box is focused at all times even if you click on the chat window. I think this is wanted.
Which would make adding this feature a bit complicated. You don't want buttons to appear everytime you press SHIFT, because it's also used to capitalize letters, hence why it might be an issue because the chat input box is focused.

But a pure button toggle like that mod sword, sounds possible. I forgot what buttons though.

Bumping this if I may, an on/off toggle would be really useful whether it's held or just a switch. Repositioning wouldn't be too much of a problem.

You can currently bind a key to switch the moderation mode by adding a hotkey like this:

For the hoverable buttons, I'll link to https://github.com/Chatterino/chatterino2/discussions/5490 and https://github.com/Chatterino/chatterino2/discussions/4185 for completeness (these are requests for reply buttons, but as noted in some comments, these could be extended).

For the hoverable buttons, I'll link to #5490 and #4185 for completeness (these are requests for reply buttons, but as noted in some comments, these could be extended).

🤔


Numba needs NumPy 1.20 or less

Hi, I just installed GeoPPI on CentOS Linux (release 7.9.2009) x86_64 linux system. Everything in the instal instructions went smoothly (very nice instructions!). But, when I tried to run the example, I got the above error. The full output (with my home dir replaced by <myhome>) is:
(ppi) bash-4.2$ python run.py data/testExamples/1PPF.pdb  TI17F  E_I
Traceback (most recent call last):
  File "run.py", line 6, in <module>
    from models import *
  File "<myhome>/standley/code/git/GeoPPI/models.py", line 4, in <module>
    from torch_geometric.data import DataLoader
  File "<myhome>/code/miniconda2/envs/ppi/lib/python3.8/site-packages/torch_geometric/__init__.py", line 5, in <module>
    import torch_geometric.transforms
  File "<myhome>/code/miniconda2/envs/ppi/lib/python3.8/site-packages/torch_geometric/transforms/__init__.py", line 36, in <module>
    from .gdc import GDC
  File "<myhome>/code/miniconda2/envs/ppi/lib/python3.8/site-packages/torch_geometric/transforms/gdc.py", line 2, in <module>
    import numba
  File "<myhome>/code/miniconda2/envs/ppi/lib/python3.8/site-packages/numba/__init__.py", line 198, in <module>
    _ensure_critical_deps()
  File "<mypath>miniconda2/envs/ppi/lib/python3.8/site-packages/numba/__init__.py", line 138, in _ensure_critical_deps
    raise ImportError("Numba needs NumPy 1.20 or less")

I tried deactivating and reactivating the ppi environment, but that didn't help. Have you seen this error before?

When I force conda to install numpy 1.20, I get other errors:
UnsatisfiableError: The following specifications were found
to be incompatible with the existing python installation in your environment:

Specifications:

  - numpy=1.20 -> python[version='>=3.7,<3.8.0a0|>=3.9,<3.10.0a0|>=3.8,<3.9.0a0']

Your python: python=2.7

If python is on the left-most side of the chain, that's the version you've asked for.
When python appears to the right, that indicates that the thing on the left is somehow
not available for the python version you are constrained to. Note that conda will not
change your python version to a different minor version unless you explicitly specify
that.

The following specifications were found to be incompatible with your system:

  - feature:/linux-64::__glibc==2.17=0
  - feature:|@/linux-64::__glibc==2.17=0
  - numpy=1.20 -> libgcc-ng[version='>=7.3.0'] -> __glibc[version='>=2.17']

Your installed version is: 2.17

Hi, I met the same "ImportError("Numba needs NumPy 1.20 or less")" when I run this project with Python 3.8.5 and MacOSX 12.1.
I force conda to install numba then this error is fixed.

Hi, I have some similar problem in running this project. Instead of those error, I got
Traceback (most recent call last):
  File "run.py", line 5, in <module>
    import torch, pickle
ModuleNotFoundError: No module named 'torch'

But it was installed before, have you run into this error?
I really appreciate any helps.


Create email templates

These are the templates to implement as plain HTML to configure SES with them.
SES Docs > https://docs.aws.amazon.com/ses/latest/dg/send-personalized-email-api.html
The images in the email should be uploaded in the S3 public bucket. They should also be stored in the repo.
Template designs

[ ] New application OCP admin: https://www.figma.com/file/mQqkGtTfNEBdfk4QdfNYIO/OCP-Data-Registry-Design?type=design&node-id=442-3117&t=ZGzh5x7zMAwvmP8g-4
[ ] Overdue application OCP admin: https://www.figma.com/file/mQqkGtTfNEBdfk4QdfNYIO/OCP-Data-Registry-Design?type=design&node-id=472-3181&t=ZGzh5x7zMAwvmP8g-4
[ ] New application FI user: https://www.figma.com/file/mQqkGtTfNEBdfk4QdfNYIO/OCP-Data-Registry-Design?type=design&node-id=424-2388&t=ZGzh5x7zMAwvmP8g-4
[ ] Overdue application FI: https://www.figma.com/file/mQqkGtTfNEBdfk4QdfNYIO/OCP-Data-Registry-Design?type=design&node-id=440-2492&t=ZGzh5x7zMAwvmP8g-4
[ ] * New Account Created: https://www.figma.com/file/mQqkGtTfNEBdfk4QdfNYIO/OCP-Data-Registry-Design?type=design&node-id=559-3795&t=ZGzh5x7zMAwvmP8g-4

Python AWS SDK  to be used
https://docs.aws.amazon.com/ses/latest/dg/send-an-email-using-sdk-programmatically.html

Is it necessary to upload to S3? I am fine with serving them from the same container as the frontend.

its not necessary, it  was just an option, we will serve it from the same URL as the front, as you mention, so we dont compromise any sensitive data in S3 .

@yolile,
In the Figma templates for the emails, we have the phrase 'View this email in your browser' above the header.
What is the expected functionality for this?
Is it meant to serve a webpage with the same content, or does it serve another purpose?
Thanks!

cc @sabahfromlondon

Is it meant to serve a webpage with the same content

Yes!

@nahu lInk al PR
https://github.com/open-contracting/credere-backend/pull/48

Closing as completed


Add Catppuccin variants

I can add the old one back if you want.

yes keep the original one and add these as extras

Alright I added it back


Initial implementation of System.Threading.Tasks.Channels

Prototype of a new System.Threading.Tasks.Channels library, which provides data structures for handing off data between producers and consumers.  The included README.md provides an overview of the library and its exposed functionality.
An initial set of functional tests are included, with ~95% line and branch coverage.
Further work is desired to expose more operations over channels, provide additional built-in channel implementations, and optimize the existing channel and operator implementations further.

cc @KrzysztofCwalina, @ljw1004, @Petermarcu, @MadsTorgersen, @bleroy

I think this line in the README:
```WaitToRead```/```WriteAsync```

would be less confusing as:
```WaitToReadAsync```/```WaitToWriteAsync```

Also, I would really like to see a separate Deque collection proposal. .NET has long needed one, as illustrated by the SimpleQueue included here and other places. Ditto for IAsyncEnumerator - it feels as though that would be a type with wider application than Channels.

I think this line in the README

Yes, that's just a typo, I'll fix it.

Ditto for IAsyncEnumerator

Yes, I included it here simply as a convenient place to put it.  If it were to be included in the framework, it would certainly be put somewhere more general, especially with language support depending on it.

as illustrated by the SimpleQueue included here and other places

Didn't quite understand this... SimpleQueue isn't a deque, it's just a regular queue without some of the (small) overheads of Queue<T>.

Didn't quite understand this... SimpleQueue isn't a deque, it's just a regular queue without some of the (small) overheads of Queue.

You're right, of course. Not sure why I was thinking it was a deque. :)

Just a quick note to say the link to the readme in the first post is now broken - it should be to https://github.com/stephentoub/corefxlab/tree/master/src/System.Threading.Tasks.Channels (and possibly having README.md tack on there if you wish) instead of https://github.com/stephentoub/corefxlab/blob/initial_channels/src/System.Threading.Tasks.Channels/README.md

Thanks, @IanYates.  I've now fixed the link.

I think a sentence or two on what's ValueTask<T> and what is it for would be nice as It's part of the public API but isn't a common concept (as far as I know).

I think a sentence or two on what's ValueTask

Sure, I can add that.

Am I missing something?

Probably not.  I likely just neglected to remove the unsafe annotation after some experiments with different implementations.  I'll take a look and remove them assuming it's possible.


Search for expired, but not replaced drafts

Description
The search options only offer to search for both of expired and replaced drafts, or none of them.
I usually don't care about replaced drafts, they are pure noise in a search.
Recently, they are even the first item, further obscuring what I am looking for.
(It does not help that there is no disclosure triangle for the different status values, so I can't even click the noise away.)
Code of Conduct

[X] I agree to follow the IETF's Code of Conduct

It's running an older database snapshot, but see if https://search.dev.ietf.org/ lets you search for what you want with less grief.

On 2023-12-05, at 15:31, Robert Sparks @.***> wrote:

It's running an older database snapshot, but see if https://search.dev.ietf.org/ lets you search for what you want with less grief.

The search is fine.
(I wouldn’t mind a date cutoff, but sorting also helps.)
The result is missing columns like the date, which are important to sort on (which doesn’t exist in the first place).
Grüße, Carsten


Missing refresh

Describe the bug
For tutorials that are supposed to show a reduced block view in the first step, this function is missing. Instead, the full block categories is shown. By switching to the next step and then back, the tutorial window is freshed and the desired reduced view is displayed.
To Reproduce
Steps to reproduce the behavior:

Go to 'tutorials'
Click on 'Hallo Calliope'
Click on 'OK'
See step 1 with the view of the full block categories
Click on '2' and back to '1' to see the reduced block view

Expected behavior

A clear and concise description of what you expected to happen.

Screeshots

Device information

Type all devices [Desktop/tablet/smartphone]
OS: [e.g. windows], including version
Browser [e.g. chrome, firefox], including version

Additional context

Add any other context about the problem here.

getestet und geschlossen


Dog Face Detection Using DL

Pull Request for DL-Simplified 💡
Issue Title : Dog Face Detection using DL

Aim of the project : To detect dog face in the given imge
Name: Rithish S
GitHub ID: Rithish5513U
Email ID<EMAIL_ADDRESS>**Idenitfy yourself: GSSoc'24 Contributor

Closes: #240
Describe the add-ons or changes you've made 📃
I have created a Dog Face Detection Model Using YOLOv8 Model
I chose this model because it is best suited for object detection tasks.
Further I didn't use any other model because I face trouble with the amount of time it is taking to train the model. I have waited for a full night for the model to train because of the size of the dataset. Here the task is to detect dog face in the image and make a bounding box for the detected image. So I have trained YOLOv8 model.
Performance Metrics
Here I have not used Accuracy and Loss function. It is because of the bounding boxes and the problem is not about classification.
The performance metrices used here are :

Confidence Curve
Precision-Recall Curve
Precision-Confidence Curve
Recall-Confidence Curve

How Has This Been Tested? ⚙
I have verified the model prediction with the actual results. I have tested it by the above mentioned metrics and by manually viewing each images.
I have first trained YOLOv8 model and then I have predicted the output and tested it with the original results and gave the results accordingly.
Checklist: ☑

[ x] My code follows the guidelines of this project.
[ x] I have performed a self-review of my own code.
[x ] I have commented my code, particularly wherever it was hard to understand.
[ x] I have made corresponding changes to the documentation.
[x ] My changes generate no new warnings.
[ x] I have added things that prove my fix is effective or that my feature works.
[x ] Any dependent changes have been merged and published in downstream modules.

Can i do the other models in new notebook file or should i do it in the same notebook??

Can i do the other models in new notebook file or should i do it in the same notebook??

You can update the existing notebook and add models one after another.

@abhisheks008 I can't upload my notebook in github. If i upload, it shows only half of the page. What can I do

I actually worked on a different notebook and merged those after u said and i dont know what happenned. Even if i upload, it only uploading half of the file

@abhisheks008 If i download it again from github it shows full code. I'm so confused

@abhisheks008 If i download it again from github it shows full code. I'm so confused

Then put the files separately. But in the README mention all the implemented models and document them all.

@abhisheks008 I dont have loss function metric in YOLO and i have confidence instead of accuracy in Yolo can i provide the confidence as the performance for yolo model and for other 2 models i.e., mobilet ssd and vgg- i will provide accuracy and loss function??

@abhisheks008 I dont have loss function metric in YOLO and i have confidence instead of accuracy in Yolo can i provide the confidence as the performance for yolo model and for other 2 models i.e., mobilet ssd and vgg- i will provide accuracy and loss function??

No issues. Just need a parameter to judge/check which is the best fitted model for this dataset.

@abhisheks008 A help needed from the mentor. I have used different email of github for doing this project contribution. But my mail while I register for GSSoc'24 is<EMAIL_ADDRESS>Pls add the contribution points to this mail. Now i have changed my primary mail address in github to this<EMAIL_ADDRESS>


Update SparkDataSet's doc and add support for fsspec

Signed-off-by: Nok Chan<EMAIL_ADDRESS>Description

Close https://github.com/kedro-org/kedro-plugins/issues/117
The final decision is to just update the doc and add support for fsspec.filesystem since the DatabricksFileSystem isn't useful for the Spark usecase.

To summarise the current issue:
Summary

When dbfs/ not include in path:❌

Spark will always add dbfs/ prefix - see https://docs.databricks.com/files/index.html#understand-default-locations-with-examples
_fetch_latest_version will use os library, by default it doesn't use the dbfs as root - as a result it can't find the file because Spark saved it in dbfs/filepath but os is looking in filepath

This is why when versioned: True + dbfs/ not used in the filepath it cannot load the data successfully.

When /dbfs is included in path: ✅
kedro strip the "dbfs" in the dataset - When using Spark it adds the dbfs/ prefix

SparkDataSet try to save in filepath - Databricks will automatically add dbfs/ prefix which saving it in dbfs/filepath
_fetch_latest_version using os.glob("dbfs/filepath") - finding the correct version

Alternative - Use fsspec DatabrickFileSystem?:

Tried DatabricksFileSystem - from fsspec.implementations.dbfs import DatabricksFileSystem
This could work in theory and you can pass the token as credentials. However it isn't that useful since you almost always run on Databricks, therefore you don't really want to authenticate via a token. This will be only useful when you try to access dbfs while you are running a program outside of Databricks.
It really only affect Spark, so conditioning in Spark seems inevitable to me. Even if fsspec works, as long as we use Spark to handle save/write it will have discrepancy between fsspec and spark

Anything we can do?

We should advise user always use dbfs prefix ✅ - We did it already.
We can potentially remove this block of condition and just let fsspec do the work. The dbfs logic still need to be kept though, the condition is only special to dbfs or hdfs

Development notes

Add generic support using fsspec.filesystem
Add documentation to explain clearly why the condition only apply to SparkDataSet
Remove deprecation warning - since that warning has been there for many years already. I don't think it's kedro responsibility to flag Spark is not supporting s3n

During development, I find it weird we actually didn't support filesystems other than s3. I was keen to remove the special condition for s3 but it exists for a legacy bug (not sure if it is still a problem). IMO, I don't think that should be an issue since it should affect everything not just Spark.
However, I still keep it as I rather handle this conservatively since this is an important dataset and many legacies behind it. Once we open up this for things like gcs, it will give us more signal if that legacy bug still exists or not.
glob_function = partial(_s3.glob, refresh=True)  - This is the extra condition check for s3 - otherwise it should be just fine to use fsspec.filesystem to handle.
Additional notes (skip for review purpose)
Note:
I also found the hdfs tests are always wrong, I suspect no one actually uses it and I think it's a signal that we may need to re-work this dataset at some point. It's not a high priority now, but I think we stack up a lot of technical debts in this dataset already/
Some observations:

Is the hdfs client useful at all? Some of the tests has not been running correctly for years
We don't have anything other than s3 supported
The dataset invents it own _split_filepath logic which resembles get_protocol_and_path a lot, the only difference is the hdfs pathway, is this actually a bug that we should fix in kedro?
The use of fs_prefix and protocol is confusing, some of the code is read via fsspec some is read with Spark directly. I suspect it will break since there are inconsistencies. It works fine for s3 and dbfs which is the majority of our user base I suspect.
Overall it just looks a lot different from other datasets, partly due to the I/O is mainly via Spark instead of fsspec

I want to refactor this dataset but I am not comfortable to do this because we don't have good coverage, maybe we will look at this again some day.
Checklist

[ ] Opened this PR as a 'Draft Pull Request' if it is work-in-progress
[ ] Updated the documentation to reflect the code changes
[ ] Added a description of this change in the relevant RELEASE.md file
[ ] Added tests to cover my changes

@jmholzer I think this broke Azure DataLake Storage Gen2. I updated from kedro 0.18.8 to this version of kedro-datasets and am getting this error now:
Protocol not known: abfss.
I think the issue is the fact that the last else strips ://

Hi @jptissot , thanks for flagging this. For visibility, can you open an issue with the full traceback? Feel free to link back to this PR

@astrojuanlu Of course, I will try to get the traceback for you. I found another solution in the meantime to use abfs instead of abfss.


Do not prefix config/manifests resources

/cc @mresvanis

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 71.63%. Comparing base (fa23a9b) to head (227e9f9).
Report is 46 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #796      +/-   ##
==========================================
- Coverage   79.09%   71.63%   -7.46%
==========================================
  Files          51       65      +14
  Lines        5109     4474     -635
==========================================
- Hits         4041     3205     -836
- Misses        882     1073     +191
- Partials      186      196      +10

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

/cherry-pick release-2.1

/lgtm

/lgtm


Update scala-library to 2.13.7

Updates org.scala-lang:scala-library from 2.13.5 to 2.13.7.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scala-lang", artifactId = "scala-library" } ]

labels: library-update, early-semver-patch, semver-spec-patch, commit-count:1

Codecov Report

Merging #168 (d7ef6a3) into main (62b096b) will increase coverage by 0.52%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #168      +/-   ##
==========================================
+ Coverage   59.25%   59.77%   +0.52%
==========================================
  Files         158      158
  Lines        3259     3259
  Branches      101      101
==========================================
+ Hits         1931     1948      +17
+ Misses       1328     1311      -17

Impacted Files
Coverage Δ

...health/windows/actor/HealthSignalWindowActor.scala
94.73% <0.00%> (+1.50%)
:arrow_up:

...StreamsUpdatePartitionsOnStateChangeListener.scala
91.42% <0.00%> (+8.57%)
:arrow_up:

.../surge/kafka/streams/KafkaStreamManagerActor.scala
67.53% <0.00%> (+10.38%)
:arrow_up:

...windows/stream/actor/HealthSignalStreamActor.scala
60.00% <0.00%> (+26.66%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62b096b...d7ef6a3. Read the comment docs.


setup_enterprise.ps1 not updated to use new database files

🐛 Bug Report
Powershell install script is calling out the old database filenames and there is no error checking to see if the files exist before or after the copy command.
Currently is
# Copy database files to user directory
New-Item -ItemType directory -Path C:\CSETDatabase -Force
Copy-Item -Path database\CSETWeb12024.mdf -Destination C:\CSETDatabase\CSETWeb.mdf -Force
Copy-Item -Path database\CSETWeb12024_log.ldf -Destination C:\CSETDatabase\CSETWeb_log.ldf -Force

Should be
# Copy database files to user directory
New-Item -ItemType directory -Path C:\CSETDatabase -Force
Copy-Item -Path database\CSETWeb12120.mdf -Destination C:\CSETDatabase\CSETWeb.mdf -Force
Copy-Item -Path database\CSETWeb12120_log.ldf -Destination C:\CSETDatabase\CSETWeb_log.ldf -Force

Thanks for catching this. Perhaps a better solution would be for us to allow for passing in the database version via command line arguments and avoid hardcoding that into the script. I will make sure to add a work ticket to get this updated.

A ticket has been created and we will be looking into this issue.

I changed the script to this to just copy whatever database was there and it works as expected.
# Copy database files to user directory New-Item -ItemType directory -Path C:\CSETDatabase -Force Copy-Item -Path database\CSETWeb*.mdf -Destination C:\CSETDatabase\CSETWeb.mdf -Force Copy-Item -Path database\CSETWeb*_log.ldf -Destination C:\CSETDatabase\CSETWeb_log.ldf -Force

This issue has been resolved in https://github.com/cisagov/cset/pull/4007. @adamz01h Thank you for the suggested change.


fix: Improve multipart form body user interface

Description

Dropdown components can now be of two different types, stand-alone or form connected. Multi-part form body has been developed to match design.
Fixes error that occurs when user fills second key-value pair before first one

Fixes #7006
Fixes #7463
Type of change

Bug fix (non-breaking change which fixes an issue)
Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?
Jest test to check that when user fills second key-value pair before first one, no error is thrown.
Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

Test coverage results :test_tube:
:green_circle: Total coverage has increased
// Code coverage diff between base branch:release and head branch: multipart-form-body-design-update

Status
File
% Stmts
% Branch
% Funcs
% Lines

:green_circle:
total
54.82 (0.03)
36.51 (0.01)
33.96 (0)
55.36 (0.01)

:green_circle:
app/client/src/components/editorComponents/DropdownComponent.tsx
23.19 (4.59)
13.79 (0.89)
5.56 (-0.32)
25.42 (3.03)

:green_circle:
app/client/src/components/editorComponents/form/fields/KeyValueFieldArray.tsx
51.92 (0.94)
29.09 (0)
0 (0)
52.94 (0.94)

:red_circle:
app/client/src/transformers/RestActionTransformer.ts
95.83 (0)
80 (-1.82)
100 (0)
100 (0)

:red_circle:
app/client/src/utils/autocomplete/TernServer.ts
50.47 (-0.24)
38.26 (-0.87)
36.21 (0)
55.08 (-0.27)

:green_circle:
app/client/src/widgets/ButtonWidget/component/index.tsx
45.05 (0)
22.22 (0.83)
36 (0)
42.86 (0)

Please add comments to all the files you have changed

In the latest commit, I have added comments in particularly hard-to-understand areas


Producer retry logic does not preserve order (during a leader failure/election)

Steps to reproduce

start 2 kafka brokers (ports 9092, 9093)

create mytopic with replication-factor of 2
./bin/kafka-topics.sh --zookeeper localhost --topic mytopic --create --partitions 1 --replication-factor 2

start a consumer in a loop
var consumer = new Kafka.SimpleConsumer({connectionString: 'localhost:9092, localhost:9093'})
consumer.init().then(function () {
  consumer.subscribe('mytopic', [], function (messageSet, topic, partition) {
    messageSet.forEach(function (m) {
      console.log(topic, partition, m.offset, m.message.value.toString('utf8'));
    });
  });
});

configure no-kafka producer with max attempts and delay long enough to survive rebalancing
var producer = new NoKafka.Producer({
  connectionString: 'localhost:9092, localhost:9093',
  clientId: 'producer',
  timeout: 100,
  retries: {
      attempts: 10,
      delay: 1000
  }
});

run no-kafka producer in loop
var counter = 0;
setInterval(function() {
  producer.send({
      topic: 'mytopic',
      message: { value: 'message #' + counter },,
      partition: 0
  })
  .catch(function(err) { console.log('promise rejection', err); })
  .then(function(err) { console.log('promise fulfillment', err.error); });
}, 1000)

kill -9 whichever broker is the leader for mytopic:0

Observe the messages be sent in reverse order when the new leader is elected

It happens because each message is sent and thus retried individually, each in its own delay and attempt loop. You are also not waiting for the previous message to be successfully fulfilled before sending next one. This scenario quite possibly can result in random order as well. Of course it sounds bad, but consider the following scenario:

message M0 is followed by message M1 (M1 is sent after 1000 ms since M0 was sent)
message M0 is destined to Broker0, M1 to Broker1
Broker0 dies before M0 reached it
message M0 is now retried in a loop, for 10  seconds
message M1 is successfully delivered
the order is reversed

So you can only expect the messages to be received by Kafka in a specific order when you wait for successful delivery confirmation for each message before sending next one. Otherwise, even in a fully connected Kafka cluster the latency of different brokers can result in message reorder.


Add support for safari

If https://stackoverflow.com/a/18256077 is still correct, this should allow Safari to get the icon in less requests. Apple docs are bad, but essentially the precomposed means that IOS will not apply an glaze effect on top of the icon, which I think is a plus.

I was unable to create a backport for 1.19. @lunny, please send one manually. :tea:
go run ./contrib/backport 24697
...  // fix git conflicts if any
go run ./contrib/backport --continue

Let's not then

Yeah, I thought this would be a safe auto backport 😆


fixed isArrayLike returning true for 0

before:
_.size(0) //undefined
_.size(1) //0

after:
_.size(0) //0
_.size(1) //0

There are probably other methods that are broken for the value 0 but _.size is how I discovered the bug.

The only other affected method is _.shuffle:
_.shuffle(0) == [undefined];
_.shuffle(1) == [];

This test is sufficient and a good catch. Thanks @smelnikov!

Also found _.sample is affected:
_.sample(0, 1) == [undefined];
_.sample(1, 1) == []

@jashkenas: Mind cutting a 1.8.3 bugfix release?

Sure — but let's wait for a medium period of time before doing it. (Like, end of the week?) I'd imagine there are a number of minor things that can go in...

:+1:


Add ngrok support

https://ngrok.com/

Whats the usecase?

One example: exposing your dev server to a mobile device.

I'm not 100% yet on this, but came across it and thought it could be an interesting addition.  I'm interested in hearing the experiences of others here.

Mobile devices in my LAN can access the dev machines local IP, which can be logged on starting the server. Seems easier to me :)

I've found ngrok to be very useful, while testing on mobile devices (especially, the ones that aren't yours or not on the same LAN) as well as debugging a particular build with someone remote (user or dev). It saves a lot of pain in a lot of such cases and I think is a good developer experience default.

for remote debugging or mobile devices that are not on the same LAN i prefer deploying to (now)[https://zeit.co/now] nowadays.

Ngrok does something very close to now. What about a feature branch?

Yeah, with now it isn't really needed.  We need to keep encouraging people to try now. :)

I'll close this, if the need ever arises we can discuss it again.


Can't resolve 'happypack/loader?id=jsx'

Bug Report
Describe the bug
When I'm building, I'm getting the error
<EMAIL_ADDRESS>./.docz/app/index.jsx
Module not found: Can't resolve 'happypack/loader?id=jsx' in 'C:\Users\thib3\repos\styleguide'

To Reproduce

clone this repo : https://github.com/thib3113/styleguideBug
launch npm run docz:build
See error

A clear and concise description of what you expected to happen..
Something working
Environment

OS: Windows 10
Node/npm version: Node 10.4, Npm 6.4.1

Maybe related, i'm getting this error in my repo:
Module build failed (from ./node_modules/happypack/loader.js):
Error: [BABEL] /Users/justinkchen/workspace/set-protocol-docs/.docz/app/index.jsx: You gave us a visitor for the node type PrivateName but it's not a valid type (While processing: "/Users/justinkchen/workspace/set-protocol-docs/node_modules/babel-preset-docz/dist/index.js$2")
    at Array.reduce (<anonymous>)

@justinkchen  I think it's not the same error, you had an error message :

You gave us a visitor for the node type PrivateName but it's not a valid type
It's say you maybe had an error in one of your component .

Hmm...but for some reason it works on older version on docz, not on 0.11.1

Hi @thib3113, you forgot to add docz as devDependency on your project... I just ran these commands and everything works fine for me:
$ npm install --save-dev docz
$ npm run docz:dev

Hum, I need to retry this morning . But if I remember, installing docz in
local ( !global ) , produce uglyfying error . ( I'll retry )
Le mar. 11 sept. 2018 à 07:28, Pedro Nauck<EMAIL_ADDRESS>a
écrit :

Hi @thib3113 https://github.com/thib3113, you forgot to add docz as
devDependency on your project... I just ran these commands and everything
works fine for me:
$ npm install --save-dev docz
$ npm run docz:dev
https://camo.githubusercontent.com/b6a08348a1d56be047e809c89cf8e5708aa7b4b7/68747470733a2f2f63646e2d7374642e64707263646e2e6e65742f66696c65732f6163635f3634393635312f737449546354
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/pedronauck/docz/issues/313#issuecomment-420151415,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFPCQhOoz5f6TUeNtbep0JZIDtfCRIQCks5uZ0oNgaJpZM4Wfyan
.

@pedronauck : After re-reading your answer . My bug is "building", so npm run build !
With docz in devdependencies :
image
I've found an issue when you just answer "some dependencies can't be minified", but I've try with only one dependencies "docz", and this don't work .

I get this error too when running build. docz is added to my dev dependencies.


Add ACCUM_BATCHES

--accum-batches $ACCUM_BATCHES

enables the proper honoring of ACCUM_BATCHES in the fine-tuning workflow


Enhancement: Enable trim_array_spaces fixer

This PR

[x] enables the trim_array_spaces fixer
[x] runs make cs

💁♂ For reference, see https://github.com/FriendsOfPHP/PHP-CS-Fixer/tree/v2.8.0#usage:

trim_array_spaces [@Symfony]
Arrays should be formatted like function/method arguments, without leading or trailing single line space.

👍

Thank you, @mdwheele!


Edited cesium workers to work with webpack worker-loader

Actually just realised this'll break terriajs#master - better to leave it for now


Add language zh-TW

Hey @hugoalh, I'm currently in the process of relicensing Goblin Traders. I would like your permission to relicense your contributions to Goblin Traders under MIT. Thank you.

Hey @hugoalh, I'm currently in the process of relicensing Goblin Traders. I would like your permission to relicense your contributions to Goblin Traders under MIT. Thank you.

@MrCrayfish, I agree to this relicensing.


Australia phone verification Continue Button gray out

I am located in Australia, one of my friend told me about this awesome app.
When I tried to register my phone number (the carrier is Telstra) using keybase windows app, the continue button is gray out, but I tried to enter my friend's or my partner's number (same carrier as Telstra), the button turns green, I've been using my number for years, not sure what's going on.
Please see image below:

Sorry about that. If you type your number on https://catamphetamine.github.io/libphonenumber-js/, does it show up as "Valid"?

Sorry about that. If you type your number on https://catamphetamine.github.io/libphonenumber-js/, does it show up as "Valid"?

Thanks for your reply, the Valid show up as false. Please see image below. I've been using this number for years, and I used it to verify my bank account, gmail, fb and twitter.

Doesn't work for me as well, my number is 0483580xxx, seems like libphonenumber-js doesn't recognise mobile starts with 0483.

Okay, we just pushed out a new Linux nightly build with the fix. You can get it here: https://keybase.io/docs/linux-user-guide#nightly-builds.
Otherwise, we will do a full release sometime this week, so you could wait for that instead. Thanks!

Works now, great job.


Run inference on Baskerville

Run MultiEURLEX data through pipeline, saving output.
Requires saving of output in order to calculate error and uncertainty.

[ ] OCR
[x] Translation
[x] Topic

Starting work on this branch. Currently we can run single components on baskerville, will start writing the bash scripts and configs.


[pointer] Rename Any -> Unknown, remove aliasing

Don't implement Aliasing for Unknown - every Ptr always has some aliasing that is known at construction.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 87.67%. Comparing base (85a12e2) to head (e4ae056).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1909      +/-   ##
==========================================
+ Coverage   87.66%   87.67%   +0.01%
==========================================
  Files          17       17
  Lines        5968     5973       +5
==========================================
+ Hits         5232     5237       +5
  Misses        736      736

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Create common setting dialog

Saving on this dialog should be reflected to currently opened and later created console view tabs

Looks like not too much to save in this settings:

Maybe checkbox and color selector if possible per line,

Maybe main panel should be a tab pane or something else to organize different tools settings in the same window.

Decided to replace with actions group on action toolbar of each tab.
Persistence should be done via settings component with mapping file name to tab settings state.


Question about the One-shot tuning Text-to-Video algorithm

Hello, I have some question about the pipeline of One-shot tuning Text-to-Video algorithm. I am confused about how the algorithm below is reflected in the One-shot tuning code.

In the paper, it said 'The total number of frames of the video is S ∗ N + M'
In the code, the for loop is 'for i in range(0,video_length-clip_length+1,clip_length):'
Is it means S==M in this code?
Thank you very much!

When decoding with the VAE or run_isolated is set to true, S=M.
When using ddim_inversion_long or gen_long, S = Stride, M=clip_length.
And I just find a typo there, the total number of frames should be S*(N-1)+M. Thanks for your issue, and I will re-correct it when uploading a newer version.


Use a CSS pre-processor.

Looking at some of the style sheets, I think it would be a benefit to use a pre-processor like SASS.
It would need to install Ruby as it is based on RUby but again we can setup both installations as part of the npm install.
Whats peoples views on this?

Having spoken to @janodvarko  this evening its clear that a CSS Pre-processor would not benefit the project at this moment. I also have a better understanding how the platform refers to these files and in fact does not have to do multiple HTTP requests for the various files etc.


Is Branch Predictor working for Minor and DerivO3?

I'm having problem retrieving the BTB hit rate for both Minor and DerivO3.
The problem for Minor is that, inside of the branch predictor bpred_unit,cc, it uses functions like static_inst.isControl(), static_inst.isConditional() etc, which use instruction flags to decide if this is a branch. While at the fetch stage when we do prediction, the instruction flags have not been decided yet and always has a default all-zero.
Previously I brute force one program to get all of its branch PCs (conditional, unconditional, branch etc), creating a list. Every time those instructions are called, I just searched those lists.
This works for Minor. But in DeriveO3, there is yet another problem. The function inst->branchTarget() called in decode_impl.hh is simply not implemented. In static_inst.cc, the function simply output a panic.
TheISA::PCState
StaticInst::branchTarget(const TheISA::PCState &pc) const
{
panic("StaticInst::branchTarget() called on instruction "
"that is not a PC-relative branch.");
M5_DUMMY_RETURN;
}
I'm wondering if there's something wrong with my configuration. Since the main objective for me to run gem5 is to get a BTB hit rate, I'm in urgent need to make this work. Thank you so much for your help!

I am currently closing all issues on github and disabling the issue support.
If you have general gem5 questions, please use the gem5-users mailing list (http://www.gem5.org/mailman/listinfo/gem5-users).
Please report any issues/bugs to the gem5-dev mailing list (http://www.gem5.org/mailman/listinfo/gem5-dev). However, gem5 is an open source project, so you are encoraged to fix any bugs/issues you find an submit a review request on our review site: https://gem5-review.googlesource.com
More details can be found in the CONTRIBUTING file: https://gem5.googlesource.com/public/gem5/+/master/CONTRIBUTING.md


Remove ESDoc related stuff

Hi everyone. Here's a cleanup PR. I'm not completely sure that this should be done, so I've split code changes to three commits, where I hope that at least one or two of them might be merged, if not all.

I removed a script that was added with this commit 2ef4682f. Based on #4771, ESDoc is removed, so it makes sense to remove it now.
Also, since @owner is removed (51a860b6) from most of the docs, I have removed almost all other @owner leftovers. There's only one place where @owner appears: Observable's create method.
Since ESDoc is not being used anymore, it makes sense not to have block comments that clearly stated that they were used to affect ESDoc.

Please let me know if these changes make sense. If some of them don't, I can remove them.

This is an amazing pull request. Thanks a lot for taking care of this. I need to check it out locally. I'll try to take care of this, this weekend and come back to you!

Thank you @niklas-wortmann. I hope you won't have problems when you try this.

Hey @niklas-wortmann, since this PR changes lots of files, a since lots of conflicts occur over time, please let me know once you start your review, so I can rebase and resolve conflicts at that time. Or, if you want to do it on your own, please do.

pinging @cartant, @kolodny, @benlesh just to double check that this does not affect the generated d.ts files

🤷♂ I wouldn't worry about it IMO, if folks start complaining then we can see what we can do. My gut tells me this is already pretty safe


In-line comments or suggested changes

Describe the feature you'd like
It would be rad if users could make in-line comments and/or suggested edits to documents.
Describe the benefits this would bring to existing BookStack users
This would improve the effort of collaboration on a single document currently we have are fighting over draft versions, and want to make in-line comments instead.
Can the goal of this request already be achieved via other means?
There are comments at the bottom of the page to make your suggestions, but its constant scrolling to go to the comments and then back up to the section the comment is commenting about.
Have you searched for an existing open/closed issue?

[X] I have searched for existing issues and none cover my fundamental request

How long have you been using BookStack?
3 months to 1 year
Additional context
No response

Thanks for the request @nharris-lmg, but I feel #1265 already covers the fundamental request here so I'm going to close this off as a duplicate.

but its constant scrolling to go to the comments and then back up to the section the comment is commenting about.

In a recent release I made comments also available in the editor sidebar to help with feedback/editing flow.
I do intent to continue improvements to the utility of comments in upcoming releases, for which inline commenting at some level may factor into.

Ah sorry I didn't see that one.
We are going to update our current deployment to check out those changes.


i18n(pt-BR): Initial setup + getting-started.mdx

What kind of changes does this PR include?

Changes or translations of Starlight docs site content

Description
This PR starts the PT-BR translation for Starlight. By tomorrow, most pages will have open PRs already.

size-limit report 📦

Path
Size

/index.html
13.21 KB (+0.3% 🔺)

/_astro/*.js
16.55 KB (0%)

/_astro/*.css
8.55 KB (0%)

Was about to approve and then BOOM merged! Thanks for taking the initiative and adding this @Yan-Thomas and thank you for reviewing @Alynva 🌟


Using componentDidUpdate means that geocoder will not render on initial load

First off, useful thing that you made. Thanks!
I'm attempting to add geocoder functionality to our map component for Civic (https://github.com/hackoregon/civic), and decided to give using your package a try.
I was able to get it working, but the geocoder won't render on initial load until after you interact with the map.
Looking at your code, you are using componentDidUpdate to check for the presence and render the geocoder. This means that the geocoder will only appear after component updates, not on initial load. A quick fix would be to call the same code in componentDidMount.
Here's my code:
https://github.com/hackoregon/civic/pull/363/files#diff-d00726a23a264cadbb4187a041e71c16
Let me know if you have questions!

Thanks for catching that. I didn't notice because I resize the map on page load in my example which triggers the update.
I didn't use componentDidMount because the mapRef is undefined in that context.
For now, I'll just post a quick fix by force updating in componentDidMount. When I have more free time, I'll think of a better fix and actually write some tests.


moved ldap related functionality to shared

Moved ldap related functionality to shared

Coverage remained the same at 75.41% when pulling 77fb056967a102cbd89390982585b61767ce9fa7 on xdurvak:ldapauth into 3e4f983cdc2d4bb92a47f589c6e465895e495ae7 on Ericsson:master.


Async widget always... "Call to undefined method App\Widgets\LastPayments::getName()"

I am trying to make an async widget but when loading the view I always get the same error, this is the code of my widget
<?php

namespace App\Widgets;

use Rinvex\Widgets\Models\AbstractWidget;
use App\Models\Payment;

class LastPayments extends AbstractWidget
{
   protected $reloadTimeout = 180;

    public function make()
    {
    	$payments= Payment::with(['user'])
    	                   ->take(5)
    	                   ->orderBy('paymentid', 'DESC')
    	                   ->get();

        return view('dashboard.widgets.last_payments')->with('payments', $payments);
    }

    public function placeholder()
   {
    	return 'Loading...';
    }
}

And here is the code of mi blade view
<div class="col-lg-6 col-md-6 col-sm-6 col-12">
      {{ @widget('App\Widgets\LastPayments', [ ], true) }}
</div>

Laravel error

Issue fixed in https://github.com/rinvex/laravel-widgets/commit/5df000ff315fb0d188e38fccff2865607bdf771e


Weird Attribute error when calling speadsheet via service account

Expected Behavior
Making variable with access to the spreadsheet data
Actual Behavior
Traceback (most recent call last):
  File "/Users/dim/.local/lib/python3.7/site-packages/IPython/core/interactiveshell.py", line 3326, in run_code
    exec(code_obj, self.user_global_ns, self.user_ns)
  File "<ipython-input-2-b3f2c15efbc2>", line 1, in <module>
    runfile('/Users/dim/PycharmProjects/bioprocess_modelling/Bellossom/test.py', wdir='/Users/dim/PycharmProjects/bioprocess_modelling/Bellossom')
  File "/Users/dim/Library/Application Support/JetBrains/Toolbox/apps/PyCharm-C/ch-0/201.8743.11/PyCharm CE.app/Contents/plugins/python-ce/helpers/pydev/_pydev_bundle/pydev_umd.py", line 197, in runfile
    pydev_imports.execfile(filename, global_vars, local_vars)  # execute the script
  File "/Users/dim/Library/Application Support/JetBrains/Toolbox/apps/PyCharm-C/ch-0/201.8743.11/PyCharm CE.app/Contents/plugins/python-ce/helpers/pydev/_pydev_imps/_pydev_execfile.py", line 18, in execfile
    exec(compile(contents+"\n", file, 'exec'), glob, loc)
  File "/Users/dim/PycharmProjects/bioprocess_modelling/Bellossom/test.py", line 15, in <module>
    range=range_name).execute()
  File "/Users/dim/opt/anaconda3/lib/python3.7/site-packages/googleapiclient/_helpers.py", line 134, in positional_wrapper
    return wrapped(*args, **kwargs)
  File "/Users/dim/opt/anaconda3/lib/python3.7/site-packages/googleapiclient/http.py", line 901, in execute
    headers=self.headers,
  File "/Users/dim/opt/anaconda3/lib/python3.7/site-packages/googleapiclient/http.py", line 177, in _retry_request
    resp, content = http.request(uri, method, *args, **kwargs)
  File "/Users/dim/opt/anaconda3/lib/python3.7/site-packages/oauth2client/transport.py", line 159, in new_request
    credentials._refresh(orig_request_method)
  File "/Users/dim/opt/anaconda3/lib/python3.7/site-packages/oauth2client/client.py", line 749, in _refresh
    self._do_refresh_request(http)
  File "/Users/dim/opt/anaconda3/lib/python3.7/site-packages/oauth2client/client.py", line 774, in _do_refresh_request
    body = self._generate_refresh_request_body()
  File "/Users/dim/opt/anaconda3/lib/python3.7/site-packages/oauth2client/client.py", line 1484, in _generate_refresh_request_body
    assertion = self._generate_assertion()
  File "/Users/dim/opt/anaconda3/lib/python3.7/site-packages/oauth2client/service_account.py", line 385, in _generate_assertion
    key_id=self._private_key_id)
  File "/Users/dim/opt/anaconda3/lib/python3.7/site-packages/oauth2client/crypt.py", line 97, in make_signed_jwt
    signature = signer.sign(signing_input)
AttributeError: 'list' object has no attribute 'sign'

Steps to Reproduce the Problem
from googleapiclient.discovery import build
from oauth2client.service_account import ServiceAccountCredentials

scopes = ['https://www.googleapis.com/auth/spreadsheets',
          'https://www.googleapis.com/auth/drive']
spreadsheet_id = '1BfUXYVHOn-LWczAZroOzYQqliqm80jNCsh5zZxvR0Pk'
credentials_path = "/Users/dim/PycharmProjects/bioprocess_modelling/Bellossom/credentials.json"
range_name = 'Class equipment_list!A:Z'

credentials = ServiceAccountCredentials(credentials_path, scopes)

service = build('sheets', 'v4', credentials=credentials)
result = service.spreadsheets().values().get(
    spreadsheetId=spreadsheet_id,
    range=range_name).execute()

Specifications

Python 3.7.4
macOS Catalina 10.15.2

Use one of the class methods for creating the service accounts instead (it expects different args than what you're supplying.) See https://oauth2client.readthedocs.io/en/latest/source/oauth2client.service_account.html#oauth2client.service_account.ServiceAccountCredentials.from_json_keyfile_name


Fix Configlet Updates

During one of the refactoring exercises, we have introduced a bug that prevents updates from going in.

closed by #80


AvroSerializerConfig has some missing PropertyNames in the 1.8.2. release

Description
SubjectNameStrategy Property of AvroSerializerConfig class is missing in 1.8.2. release.
How to reproduce
Try to setting up the SubjectNameStrategy in AvroSerializerConfig. Not possible because AvroSerializerConfig does not contain a definition for "SubjectNameStrategy" .
var avroSerializerConfig = new AvroSerializerConfig
{
// optional Avro serializer properties:
BufferBytes = 100,
AutoRegisterSchemas = false,
SubjectNameStrategy = SubjectNameStrategy.Topic  //missing property
        };

Checklist
Please provide the following information:

[ ] A complete (i.e. we can run it), minimal program demonstrating the problem. No need to supply a project file.
[1.8.2 ] Confluent.Kafka nuget version.
[ ] Apache Kafka version.
[ ] Client configuration.
[ ] Operating system.
[ ] Provide logs (with "debug" : "..." as necessary in configuration).
[ ] Provide broker log excerpts.
[ ] Critical issue.

this property exists:
https://github.com/confluentinc/confluent-kafka-dotnet/blob/1.8.x/src/Confluent.SchemaRegistry.Serdes.Avro/AvroSerializerConfig.cs#L136
https://github.com/confluentinc/confluent-kafka-dotnet/blob/1.8.x/src/Confluent.SchemaRegistry/SubjectNameStrategy.cs#L40


Unreal 5 Support

Is your feature request related to a problem? Please describe.
Hey there, cool tool! It would be great to also open ue5 uassets? Is it planned to have this option in the future, or is it already somehow working? Currently I get a System.ArgumentOutOfRangeException when trying to open an ue5 animation montage uasset.
Describe the solution you'd like
Support ue5.
Describe alternatives you've considered
I checked if there are other tools out there, but yours seems to be the most actively maintained.
Additional context

Duplicate of atenfyr/UAssetAPI#36


Add scheduled task section to best practices #958

Linked to the learn how-to for scheduling a task. Added a reverse link in each translation to the best practices.
See screenshot of the new section in issue #958.

Reviewed by Margrethe


Can Bus Filter ID´s and Formating Messages.

Thanks sandeepmistry for the Library!
I need a litte help with my Code.
I am working with a ESP32 and a TI SN65HVD230. Everything works fine and I can Monitor RPM and Speed from the Can Bus on my Smart fortwo Car.
my next goal is to show up Gears, I know that the transmission ECU is ID 0x418 and I also know how the message is set up.
for example:
"ID = 0x418 Message = 4E FE 32 25 00 4E FE 37" This is for Neutral
"ID = 0x418 Message ="52 FE 30 68 BB 52 FE 30" This is for Reverse
I only tried a Filter with ID: =0x148
And Print the Bus to Console, what I Got is only 4 Bytes messanges and I need a 32 Byte variable to compare / mask.
(if ID == 418 && Messsage == 4E FE 32 25 00 4E FE 37)
{
Serial.print("Neutral");
}

This is the Console Log:
------------------------------------
30
69
0
4E
FE
31
6A
0
4E
FE
35
6B
0
4E
FE
30
6C
0
.
.
.
-------------------------------------

there is so little information about the ESP32 Can Controller out there, so how to work this out.
maybe someone can help me out

i'm using this code after change frequency to 8e6
but in serial moniteur i still have just this line CAN OBD-II engine RPM with no ather error
can you help me ?
#include <CAN.h>
// Most cars support 11-bit adddress, others (like Honda),
// require 29-bit (extended) addressing, set the next line
// to true to use extended addressing
const bool useStandardAddressing = true;
void setup() {
Serial.begin(9600);
Serial.println("CAN OBD-II engine RPM");
// start the CAN bus at 500 kbps
if (!CAN.begin(500E3)) {
Serial.println("Starting CAN failed!");
while (1);
}
// add filter to only receive the CAN bus ID's we care about
if (useStandardAddressing) {
CAN.filter(0x7e8);
} else {
CAN.filterExtended(0x18daf110);
}
}
void loop() {
if (useStandardAddressing) {
CAN.beginPacket(0x7df, 8);
} else {
CAN.beginExtendedPacket(0x18db33f1, 8);
}
CAN.write(0x02); // number of additional bytes
CAN.write(0x01); // show current data
CAN.write(0x0c); // engine RPM
CAN.endPacket();
// wait for response
while (CAN.parsePacket() == 0 ||
CAN.read() < 3 || // correct length
CAN.read() != 0x41 || // correct mode
CAN.read() != 0x0c); // correct PID
float rpm = ((CAN.read() * 256.0) + CAN.read()) / 4.0;
Serial.print("Engine RPM = ");
Serial.println(rpm);
delay(1000);
}


Fix send pong message to only authorized channel

ISSUE TYPE

Bug fix Pull Request

SUMMARY
Fixes #205

Closing as per the discussion: https://github.com/infracloudio/botkube/issues/205#issuecomment-543685682


fail again when building for linux

What is your question?
Error: In file included from include/llua/Lua_helper.h:10,
from ./src/boot.cpp:754:
/media/pietro/Jogos/lime/linc_luajit/git//linc/linc_lua.h:12:10: fatal error: ../lib/Lua/src/lua.hpp: Arquivo ou diretório inexistente
12 | #include "../lib/Lua/src/lua.hpp"
|          ^~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
i forgot how to fix

what are you trying to build?

Psych Engine

Did you install Lua? Try running ```sh
haxelib git linc_luajit https://github.com/nebulazorua/linc_luajit.git

Run this in a terminal haxelib git linc_luajit https://github.com/AndreiRudenko/linc_luajit


Difficulties writing an alias with name_mapper

Hey, I have just started using flow and I am having a difficulty with telling it to correctly work with import path aliases.
Here is my code:
File structure:

.flowconfig
webpack.config.js
/node_modules
/apps

/src

/sagamore

sagamore_global.js
/lib

prevent_default.js

.flowconfig:
[ignore]
.*/node_modules/fbjs/.*
.*/node_modules/flux/.*
.*/node_modules/config-chain/.*
.*/node_modules/npmconf/.*
.*/node_modules/y18n/.*

[options]
module.name_mapper='sr\/(.*)' -> '<PROJECT_ROOT>/src/sagamore/\1'

webpack.config.js:
...
  resolve: {
    alias: {
      sr: path.join(__dirname, 'apps/src/sagamore'),
    }
  }
...

apps/src/sagamore/lib/prevent_default.js:
// @flow
import Sagamore from 'sr/sagamore_global'

apps/src/sagamore/sagamore_global.js:
export default true

I have tried setting module.system=haste but it didn't help.
Setting a direct regexp like module.name_mapper='sr\/sagamore_global' -> '<PROJECT_ROOT>/src/sagamore/sagamore_global' helps but obviously that's not an ideal solution.
Is this a bug? Or am I doing something wrong? Please give me an idea [: Thanks!

The two things that stand out to me are that you haven't escaped your group-parens and that you've escaped a backslash that doesn't need to be escaped.
Does something like the following fix things? sr/\(.*\)
(We use ocaml's regexp engine, which is a bit different from most others in this regard)

Ooh yeah @jeffmo it fixed my problem! This issue can be closed.
Thank you! Want me to open a PR with a similar example added to the documentation?

@cbrwizard That would be awesome!
FWIW: In the medium/longer term we're planning to switch to a better, more fully-featured regexp engine than ocaml's built-int one -- so hopefully that will make this a little simpler. Docs in the meantime are a good idea, though.


Overlapping Modals in Share Functionality

When attempting to share a message in the Zulip Flutter app by right-clicking, users encounter an issue where two modal dialogs appear simultaneously. Initially, a small message indicating "sharing failed" pops up, followed by another modal prompting users to share with specific individuals. However, the "sharing failed" message remains visible underneath the second modal, causing confusion and cluttering the interface.
https://github.com/zulip/zulip-flutter/assets/152219936/cec814af-e5bc-4937-8db2-1b68b53c4bdf

Thanks for the screen recording! Is this an issue you've also seen when you run the app on Android or iOS, or just on your computer like that?

Yes, I've been testing the Zulip Flutter app exclusively on my computer, and I encountered this issue during my usage. I haven't tested it on mobile devices like Android or iOS yet.

Thanks for the report. I'm closing this because our desktop support is for development only, and doesn't include platform integrations (like "share a message").
It looks like we hadn't previously written this down anywhere in the tree, so I've just now gone and added it — please take a look at the new "Desktop support" section at the end of the README, and let us know if anything's unclear after reading that.
(The one place we'd previously discussed this was in a chat message a while ago when the Flutter app was a new prototype. Naturally that's not a place we expect contributors to have read.)


sync release 0.17.x branch

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area libsinsp

Does this PR require a change in the driver versions?
No

What this PR does / why we need it:
sync release 0.17.x branch
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

NONE

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: LucaGuerra
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [LucaGuerra]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash: 92a9154e8aba1133cf412e682e686a902d6cad09

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Andreagit97, LucaGuerra
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Andreagit97,LucaGuerra]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


RADAR target bearing is wrong depending on orientation

What steps will reproduce the problem?
1. Start radar with a target at a distance from your location.
2. Turn around 360 degrees, stopping at each 90 degree interval.
3. Notice the inaccurate bearing at some of the intervals.

Occasionally this bug will also cause the target (blip) to race away in the
opposite direction as you approach it. On the other hand, the distance
indicator at the bottom will decrease properly showing the correct values
as you approach. Suggesting that the issue is with the bearing calculation
only.

Using RADAR 1.0. Problem verified by at least three other users.

(RADAR is really cool by the way.)

Original issue reported on code.google.com by<EMAIL_ADDRESS>on 3 Nov 2008 at 4:57

I've been doing some debugging of RADAR and have found that my device is giving
bad
orientation values. The bearing code in RADAR is solid. Someone can close this
issue.

Original comment by<EMAIL_ADDRESS>on 4 Nov 2008 at 9:28

Resolving.  Note that IIRC Radar is using the compass, which on the G1 does
indeed
need to be calibrated periodically.  (Error can accumulate in the part in use.)
Calibration involves waving the device around in a 3D figure-8 pattern;  do
this for
around 30 seconds, and the compass accuracy should improve.

Original comment by<EMAIL_ADDRESS>on 13 Nov 2008 at 10:02

Changed state: Invalid

hi! for me and anyone else outhere.... how do i run the radar program on my g1?
i see it in the installed
applications..... would love functionality that would combine radar with google
maps so that i could switch
to radar view and would direct me toward waypoint....

ideas?

Original comment by<EMAIL_ADDRESS>on 20 Nov 2008 at 5:08

I used radar in my application and after calibrating it. The distance and the
bearing
seem incorrect. I am passing the lat and long of the point I am trying to reach
and
the distance on the radar would not change as well.

my code:

 Intent i = new Intent("com.google.android.radar.SHOW_RADAR");
      	    i.putExtra("latitude", locode.getLatitudeE6()/1E6);
      	    i.putExtra("longitude", locode.getLongitudeE6()/1E6);
      	    startActivity(i);

Original comment by<EMAIL_ADDRESS>on 8 Jun 2009 at 7:25


translate-attr having problems with dashes in the attribute name aria-label becomes aria_label

Subject of the issue
Hi,
I am using something like this
translate-attr="{ARIA_LABEL:'Products.Create_Product.Delete'}"
and while inspectig it has created and attribute like this:
aria_label = "Borrar Producto"
instead of
aria-label = "Borrar Producto"
I just updated to angular-translate v. 2.13.1 and the problem is stil there
Your environment

2.13.1
1.5.6
Chrome Version 55.0.2883.95 (64-bit) / Mac OS

Steps to reproduce
I have a button like this:
<button class="bytemark-text-button"
ng-click="undelete($event,id)"
    translate-attr="{ARIA_LABEL:'Products.Create_Product.Undelete'}"
    translate="Products.Create_Product.Undo"
    ng-if="id.deleted">

UNDO

Expected behaviour
It should translate the aria label and it does but with the wrong attribute name
aria-label = "Deshacer"
Actual behaviour
aria_label = "Deshacer" // underscore instead of dash

Well, you have used the name ARIA_LABEL, so it will be aria_label (small cases). That is not an issue, actually.
Anyway, as usual:
As we had already mentioned in the issue's template, we need a working and as minimal as possible demo covering your specific use case or issue.
Follow these steps:

Please open this plnkr base.
Fork it (at the top left).
Ensure the version of AngularJS and angular-translate is correct.
Ensure all angular-translate plugins are available; reduce and remove anything you can.
Write a minimal as possible demo for your specific issue.
Save and freeze. Provide us the final link to your demo.

Hi knalli,
Thanks for the prompt response but it doesn't work.
I changed the case, the code looks like this now:

UNDO

I changed the case and this the html generated:
Deshacer
so the aria-label property is still being written as aria_label and the screen reader can't parse it.
-Carlos

Plunker here:
https://embed.plnkr.co/lkaSKP4aM5Q6BFlLGGdy/

As I said already: Use the correct attribute name, ARIA_LABEL is not correct: https://plnkr.co/edit/ExYPNRpRl8f6cmkbORjJ?p=preview

Cool. Got it. So, the syntax is different with dashed attributes. Do you need help updating the documentation?

There is no different syntax: It takes the given property name and uses it as an attribute name. Both keys aren't the same.

If you think there should be an addition in the docs, you are welcome for any suggestions (just as a pull request, our docs are in the source code).

The doc reads as this:
<ANY translate-attr="{ ATTRIBUTE_NAME: 'TRANSLATION_ID' }"></ANY>

The actual functioning code here is
<ANY translate-attr="{ 'ATTRIBUTE_NAME_WITH_DASHES': 'TRANSLATION_ID' }"></ANY>

Thanks a lot

That does not make sense. There cannot be any "magic" code because attribute cases are important for some other parties (clients, frameworks). Just because AJS supports several formats (like ngIf vs ng-if vs ng:if ng data-ng-if) that does not mean they are the same.
In addition, in this case also useful: translate-attr translate-attr-aria-label="ariaLabel". Plnkr updated.
A docs PR would be still nice, but we can close this, I guess.

My point is not the case but the quotes around the attribute name when it contains a hyphen in the name. I assumed the ATTRIBUTE_NAME was just a placeholder not an actual style suggestion (as in, it should be all caps).
So, attribute without dashes no quotes needed, attributes with dashes in the name need quotes in the name.


[tool_crash] FileSystemException: Deletion failed, OS Error: The system cannot find the path specified., errno = 3

Command
flutter pub get

Steps to Reproduce

...
...
...

Logs
FileSystemException: Deletion failed, OS Error: The system cannot find the pat

Please provide the full log or submit the issue using the link provided in that crash.


feat: add experimental tracelog provider

What this PR does / why we need it
Adds an experimental trace logger which can log all info available in the call context.
JIRA ID: DTSS-795
Notes for your reviewers
This is a prototype of the proposal described in this doc but without any invasive refactoring of pkg/trace itself (as that can be done separately).
This change restructures pkg/trace to allow adding an experimental trace logger which can log extra info in trace.StartCall/trace.EndCall.
Note that the experimental tracelogger itself is in x/tracelog and as such we can iterate on it without backwards compatibility issues.
Also note while this change adds trace.AddProvider, there is no major refactoring of trace itself as that is deferred to separate PR.

I just finished looking this over. Not approving it because its in draft form right now, but this looks great already.

At the moment we don't really plan on reworking the existing logger, DT is going to budget redoing this in the future with some short-term hacks for costing. Closing this based on that, if you'd like to continue this PLEASE let us know and we can chat about the path forward!


p14s: do not include acpi_backlight on newer kernel versions

Description of changes
Please test @itc-ger
Things done

[ ] Tested the changes in your own NixOS Configuration
[ ] Tested the changes end-to-end by using your fork of nixos-hardware and
importing it via <nixos-hardware> or Flake input

bors merge