Long time between calls to training_step when there are multiple optimizers

I have a GAN model with two optimizers that is running 30-40% slower in lightning than without. I've discovered that the lost time comes between the end of training_step for optimizer_idx 0 and the start of the call for optimizer_idx 1. There is 120ms of time (cpu, not wall) spent there. 30ms of that time is the backwards step. The other 90ms is unaccounted for. Note that after optimizer_idx 1 is run, there is only 20ms cpu time before optimizer_idx 0 is called again for the next batch.
So why might there be extra time between the optimizers?
This is happening in both the latest release as well as master.
Thanks!

I think this might actually be more of a bug than a question. I can reproduce this on the sample gan.py as well. Each forward step takes 130ms, and there are 270ms between forward steps, of which only 180ms is used for the backwards step. Again, leaving 90ms of processing overhead, which is simply too much for real use.

ummm thanks for highlightning the potential speed issues. @Borda @jeremyjordan mind looking into this?

well all mentioned func contains look with converting from Tensor to native types aka v.item()

@karlinjf talking about GAN are you using the PL example or your own GAN?

Both the PL example and my own GAN had the 90ms of overhead between iterations.

Ah, it's not quite the same. in the PL example GAN most of that type is going to the step function. I don't see any problem with that. It appears to be just my GAN then, and I've sprinkled some timing functions around and it appears to be taking a long time in the type_as() method in TensorRunningMean.append. I'll look closer.

Ah, perhaps:
        if self.memory.type() != x.type():
             self.memory.type_as(x)

Is supposed to be:
        if self.memory.type() != x.type():
            self.memory = self.memory.type_as(x)

That's already fixed by b8ff9bc1d242a18f5e7147f34d63f43fcdd0e50. Hmm, but I'm still much slower. Will investigate more, you can ignore this issue for now while I track it down.

Here is what happens with generative_adversarial_network.py on tip-of-tree 3f1e4b953f84ecdac7dada0c6b57d908efc9c3d3:
master: 14.3 it/s
Comment out self.detect_nan_tensors(loss): 16.4 it/s
Change TensorRunningAccum.append's  x = x.to(self.memory) to self.memory = self.memory.to(x): 16.65 it/s
And on my own GAN on lightning:
master: 6.78 it/s
Comment out self.detect_nan_tensors(loss):8.08 it/s
So it seems like detect_nan_tensors should either be optimized or dropped, as it's very expensive.
That change fixes half of the gap between my own setup and my setup with lightning. Will continue digging.

Sorry about the nan detection perf issue, but it is now disabled by default.
Were you able to further close the performance gap?

No worries. There is still a good ways to go. #1576 was another big chunk. I believe the rest comes from .item() calls in the likes of add_tqdm_metrics and the like.

I think there is no way around calling .item(). However, we could update the progress bar metrics with the refresh rate, and then it would be possible to set the refresh rate and only get calls to .item() when the bar is actually getting updated. It would require some refactoring though, because the progress bar is now a callback.


Control flow improvements, switched test framework to pytest

Codecov Report

Merging #29 (2d58378) into main (4832896) will decrease coverage by 7.01%.
The diff coverage is 89.55%.

@@            Coverage Diff             @@
##             main      #29      +/-   ##
==========================================
- Coverage   85.52%   78.50%   -7.02%
==========================================
  Files          18       11       -7
  Lines         677      442     -235
==========================================
- Hits          579      347     -232
+ Misses         98       95       -3

Flag
Coverage Δ

unittests
78.50% <89.55%> (-7.02%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

h2p_parser/dict_reader.py
100.00% <ø> (+11.76%)
:arrow_up:

h2p_parser/h2p.py
92.06% <50.00%> (-1.38%)
:arrow_down:

h2p_parser/cmudictext.py
88.00% <87.17%> (+0.50%)
:arrow_up:

h2p_parser/dictionary.py
94.23% <87.50%> (+1.92%)
:arrow_up:

h2p_parser/filter.py
100.00% <100.00%> (ø)

h2p_parser/format_ph.py
100.00% <100.00%> (ø)

h2p_parser/pos_parser.py
100.00% <100.00%> (ø)

tests/test_dict_reader.py

... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4832896...2d58378. Read the comment docs.


memory of snow

memory of snow

歌曲信息

专辑：とある科学の超电磁炮 OP2LEVEL5-Judgelight-
作词：fripSide
作曲：八木沼悟志
编曲：八木沼悟志
歌手：fripSide

谱
#2#3#4#5#3 #1 #2#1(7)#1
#2#3#4#5#3 #3#1 #2#3#4#5#6
#2#3#4#5#3 #1 #2#1(7)#1
(#67)#4 #3#2#1#3 #3#3#2#2

(7)#4#5 #4#3#2#1
#1[#1]7#6 #3#4#5 #4#3#4#2
(77)#4#4 #3#2 #1#1#5#5
#4#3#4 #2#3 #4#3#4 #5 #4#4#3#3

#2#3#4#5#6 #2#3#4 #5#6#5#4 #5#6#6
[#1#1]7 #6#57#6 #5#4#57 7#6#6
#2#3#4#5#6 #2#3#4 #5#6#5#4 #5#6#6
#5#5#4 #3#4#5#4 #3#3#2#2

#2#3#4#5#6 #2#3#4 #5#6#5#4 #5#6#6
[#1#1]7 #6#57#6 #5#4#57 7#6#6
#2#3#4#5#6 #2#3#4 #5#6#5#4 #5#6#6
[#1#1#2 #3#4#3#1 #1#1#3#2]

#2#3#4#5#3 #1 #2#1(7)#1
#2#3#4#5#3 #3#1 #2#3#4#5#6
#2#3#4#5#3 #1 #2#1(7)#1
(#67)#4 #3#2#1#3 #3#3#2#2

(7)#4#5 #4#3#2#1
#1[#1]7#6 #3#4#5 #4#3#4#2
(77)#4#4 #3#2 #1#1#5#5
#4#3#4 #2#3 #4#3#4 #5 #4#4#3#3

#2#3#4#5#6 #2#3#4 #5#6#5#4 #5#6#6
[#1#1]7 #6#57#6 #5#4#57 7#6#6
#2#3#4#5#6 #2#3#4 #5#6#5#4 #5#6#6
#5#5#4 #3#4#5#4 #3#3#2#2

#2#3#4#5#6 #2#3#4 #5#6#5#4 #5#6#6
[#1#1]7 #6#57#6 #5#4#57 7#6#6
#2#3#4#5#6 #2#3#4 #5#6#5#4 #5#6#6
[#1#1#2 #3#4#3#1 #1#1#3#2]

间奏略

#2#3#4#5#6 #2#3#4 #5#6#5#4 #5#6#6
[#1#1]7 #6#57#6 #5#4#57 7#6#6
#2#3#4#5#6 #2#3#4 #5#6#5#4 #5#6#6
[#1#1#1 #3#4 #3#3#2#2]

#4#3 #2#3#4#5#6 #2#3#4 #5#6#5#4 #5#6#6
[#1#1]7 #6#57#6 #5#4#57 7#6#6
#2#3#4#5#6 #2#3#4 #5#6#5#4 #5#6#6
#5#5#4 #3#4#5#4 #3#3#2#2

3#4567 3#45 6765 677
[221] 76[1]7 656[1] [1]77
3#4567 3#45 6765 677
[223] [#45#42] [22#43--]

记谱：zgyharp1

某科学的超电磁炮(とある科学の超電磁砲)


No templates matched the input template name: blazorserver.

Problem encountered on https://dotnet.microsoft.com/learn/aspnet/blazor-tutorial/create
Operating System: windows
Provide details about the problem you're experiencing. Include your operating system version, exact error message, code sample, and anything else that is relevant.
No templates matched the input template name: blazorserver.

Can you let us know what's the output of the dotnet --info command?


Update documentation to require python 2.7

2.6 is ancient, and AFAIK we have no CentOS 6 machines any more.
Any objections?
It would be good to start going to python 3, but let's go one step at a time.

No objections here.
For posterity: the conversation in #680 provides some context; basically @kylehogan submitted code that requires 2.7+ and I mentioned that we should be explicit about what to support.
re: the python 3 thing, another intermediate step would just be writing portable code, which isn't actually that hard. The six library smooths over most of the pain points. And we can add 3.x to our travis matrix; I believe there's even a "fail ok" option we could use in the interim, while stuff isn't fully portable still. I don't really care about python 3 myself, but I'll happily review PRs to improve portability.

I agree with removing obsolete things and improving portability

The README says that we require python 2.7, so that portion is solved, but I like the thoughts from @zenhack for slowly transitioning to python 3, so let's make this issue about that.

six ?
python 2to3?

@xuhang57, the trouble with 2to3 is that it leaves your code in a state where it only works with python 3, which is not a leap I'm willing to make just yet; there are a lot of systems out there where python 2 is still the default.
re six: what is your question exactly?
Like I mentioned above, step 1 is probably to add python 3 to the build matrix with a "fail ok" setting, so we can see what's working and what's not. From there we can start fixing stuff.

Oh, sorry, I was just writing all packages I know that might be helpful for translating python2 to 3.
And what you said about step 1 makes sense to me. But should we create a new branch or even a repo to get started testing? I feel like it makes sense to give it a try and see what we need for the process as early as we could.

@xuhang57, I think someone should submit a PR that adds an item to our build matrix to run the tests against python 3, and flags them allowed to fail. We're doing this for obmd for the (unreleased) master branch of Go, see:
https://github.com/CCI-MOC/obmd/blob/master/.travis.yml#L9-L10
We'll review and merge that PR, which will no doubt have a bunch of failures on python 3. From there we can start submitting PRs fixing the various tests.

Just pushed this to a branch:
https://github.com/zenhack/hil/commit/80b536b6bb83be02c5b169d6aeaf304d27b1d39b
If travis seems to do the right thing with that, I'll submit a pr.

virtualenv seems failed: https://travis-ci.org/zenhack/hil/jobs/344563309
I feel like that is because it should use virtualenv3 rather than virtaulenv which is using the Python 2

It looks more like some ubuntu package installation failure. I think we can just rerun the travis test to see how it goes.
I agree with @zenhack  that the python3 migration should be a long term job. We just don't have enough developers right now.

Yeah, that looks like some kind of transient network failure. I just restarted the build, we'll see how it goes.

Failed again. Related:
https://github.com/travis-ci/travis-ci/issues/9112
But I think this may not be the only issue. I just pushed another commit that tries using 3.4; see the comment there. We'll see if it does any better.

Should we use this issue to keep track of the Python 3 support? We just started

Works for me.
Quoting Lucas H. Xu (2018-03-06 14:08:56)

Should we use this issue to keep track of the Python 3 support? We just
started

So, we should probably come up with a triage strategy for this; we're running the CI against python 3, but that as far as I can see nobody (including myself) is really paying attention to it.

Maybe having a doc/list to keep track of the problems we have known and whoever fixes a/a few problem(s), also updates the doc/list?

It's a bit hard to just enumerate a list when what we're seeing is a test suite that fails up-front. Right now we're getting an error early on. Ideally we'd be able to impose a rule of no new test failures. Might be hard to automate that.

Bringing this up again, I'd like to start tackling this. We've got some time, but I'd like to switch over before python 2.7 goes EOL in 2020. This isn't as hard a deadline as it seems; as long as it's the system default on supported versions of RHEL it'll still get security patches, and it hasn't gotten much else in a looong time, so frankly the PSF dropping support is more symbolic than anything else. That said, I think it's worth it to start the porting work. Once hil-vpn is ready to deploy, I think I'll shift my efforts over to this. I may do some bits in parallel when the review pipeline gets deep.


Bed file upload?

Hi,
This is a very cool tool, so thank you very much. I have so far made a "dual assembly" (http://lh3.github.io/2021/10/10/introducing-dual-assembly)  with Nanopore reads and have made input files with the vrpg_preprocess.py script for VRPG. Right now, I have been using Heng Li's minigraph to call SV's such as this example command:
/home/jelber43/git/minigraph/minigraph -xasm -l10k --call out.gfa ../newAssDir/hg001.1.fa -t 10 > hg001.1.bed

then manually copying and pasting the regions of the BED file above into VRPG.
As a feature request, might it be possible to upload a BED file and be able to scroll through the BED file entries?

Dear Jean,
Many thanks for the suggestion! And sorry for the belated response! During the past a few months, we have been busy with introducing a feature that enables VRPG to visualize pangenome graph together with genome annotation features, which have been incorporated into the current version of VRPG and its webserver (https://www.evomicslab.org/app/vrpg/). In the same time, we are working on developing a genome graph based SV caller right now, which we hope to introduce to the community soon. Your suggested feature is definitely a nice addition to VRPG and we will try to make it happen in coming months. :-)
Best,
Jia-Xing and Zepu


Any version of the plugin no longer works with Phonegap build version CLI.5.2.0 or greater.   .

Use to work great but now build rejects this plugin.   I have tried various formats of the thing in config.xml such as
<gap:plugin name="nl.kingsquare.background-audio" version="1.0.1" />
.
Nothing seems to build.  I desperately need this plug-in to function in my app.  Any help would be appreciated.

I second this. Until last month it was working fine. Now I get the error:
Error - The following plugin, plugin version or a dependancy of this plugin is not on npm: nl.kingsquare.background-audio
In my config.xml the plugin is added like this:

I also tried:

<gap:plugin name="nl.kingsquare.background-audio" version="1.0.1" />

OK, I figured it out with the help of Phonegap Build Forum.
Actually, the correct config.xml entry should be:
<plugin name="nl.kingsquare.cordova.background-audio" source="npm" />
The readme.md says it should be:
<gap:plugin name="nl.kingsquare.background-audio" />
This doesn't work anymore. The source must be NPM and the plugin ID is different there.
I proposed a change to readme.md to correct this.

I will look into this. Currently the app this was made for does not experience this problem. Though I have understood that we no longer use pgb for that app :-S

@miguelbn PR? "I proposed a change to readme.md to correct this."

maybe @EddyVerbruggen https://github.com/EddyVerbruggen/cordova-plugin-backgroundaudio/


Allow numbers inside the BASE URL

While normally avoided, some domains contains numbers, so I'm proposing to add 0-9 to your regex, if gotrue support it.

I'm not sure what GoTrue requires, but I'll go along with it.


add topics

I suggest adding topics such as linear-algebra, lapack in the About section at https://github.com/tlapack/tlapack.

Well noted! Thank you, @Beliavsky! I added the topics as suggested.


[Confirm] No this in pure function

https://github.com/KleeGroup/focus-components/blob/cc637e5edfbbd2b0ee035b5d897fd7a10fe4cb67/src/components/confirm/index.js#L39

Delivered in 2.2.0


Can not differentiate with a selected or unselected option with empty value

I have a multiple select.
One option is  with value=''. When toggling that option, change events are fired ok, but there is no (easy) way of knowing if the value is selected or not.
In the change event, this.value equals '' and this.getSelectedOptions() returns the option with empty value even when its not selected.
A related issue, if there is another value selected and you toggle the empty value, number of selected values keeps increasing.
I think it would be better to use undefined or null as the "nothing is selected" value. (would be a breaking change though)
I worked around these issues in the change handler:
const value = this.virtualSelect.options.filter(o => o.isSelected).map(o => o.value);
this.virtualSelect.setValue(value, false);

@kurkle thanks for letting me know it.
I will check and handle this case


Minimum cost to generate n cells in the container starting from one cell

🚀 Feature
There's a scientist is interested in budding of cells. He has one container which initially contains only a single cell. Now he wants n number of cells in his container. So he can change the number of cells in container in 3 different ways -:
1.Double the number of cells present in the container.
2.Increase the number of cells in the container by 1.
3.Decrease the number of cells in the container by 1.
Now, all the above operations have different costs associated with them x,y,z respectively for above operations. Help him in finding the minimum cost to generate n cells in the container starting from one cell .
Example:

Input: 5 2 1 3
Output: 4
2)Input: 7 4 2 3
Output: 10

Have you read the Contributing Guidelines on Pull Requests?
Yes
Motivation
This enhances problem solving skills and competitive thinking as well.
This a competitive programming question.
Pitch
Helps in enhancing dynamic programming skills
I want to work on this issue in C++ as a participant of GSSOC'21

/assign


Duplicate function buttons

Functional options like 'shutdown', 'reboot' appear multiple times.
Maybe #3 is the culprit.

#3 has nothing to do with it but rather rEFInd not replacing the showtools list with the one we want. Or a very specific setup-centric problem.
Closing with cbf8229.


Error running Gradle on flutter build

When i trying to run any project in Emulator or Physical Device i get same error:
flutter run
Launching lib/main.dart on SM J600F in debug mode...
Initializing gradle...                                              4,3s
Resolving dependencies...
* Error running Gradle:
ProcessException: Process
"C:\Users\maxpu\Documents\DEV\Flutter_Pojects\test_app\android\gradlew.bat"
exited abnormally:
FAILURE: Build failed with an exception.
* What went wrong:
org/gradle/launcher/daemon/protocol/DaemonMessageSerializer$BuildSerializer
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.
* Get more help at https://help.gradle.org
  Command:
  C:\Users\maxpu\Documents\DEV\Flutter_Pojects\test_app\android\gradlew.bat
  app:properties
Please review your Gradle project setup in the android/ folder.

Steps to Reproduce

Created new project in Android Studio
run in console "flutter pub get"
run in console "flutter run"

Logs
$ flutter run --verbose
[  +63 ms] executing: [C:\Flutter\] git log -n 1 --pretty=format:%H
[ +224 ms] Exit code 0 from: git log -n 1 --pretty=format:%H
[   +6 ms] 7a4c33425ddd78c54aba07d86f3f9a4a0051769b
[   +1 ms] executing: [C:\Flutter\] git describe --match v*.*.* --first-parent
--long --tags
[ +195 ms] Exit code 0 from: git describe --match v*.*.* --first-parent --long
--tags
[   +2 ms] v1.5.4-hotfix.2-0-g7a4c33425
[  +23 ms] executing: [C:\Flutter\] git rev-parse --abbrev-ref --symbolic @{u}
[ +191 ms] Exit code 0 from: git rev-parse --abbrev-ref --symbolic @{u}
[   +1 ms] origin/stable
[        ] executing: [C:\Flutter\] git ls-remote --get-url origin
[ +162 ms] Exit code 0 from: git ls-remote --get-url origin
[   +1 ms] https://github.com/flutter/flutter.git
[ +243 ms] executing: [C:\Flutter\] git rev-parse --abbrev-ref HEAD
[ +183 ms] Exit code 0 from: git rev-parse --abbrev-ref HEAD
[   +1 ms] stable
[ +137 ms] executing:
C:\Users\maxpu\AppData\Local\Android\sdk\platform-tools\adb.exe devices -l
[ +138 ms] Exit code 0 from:
C:\Users\maxpu\AppData\Local\Android\sdk\platform-tools\adb.exe devices -l
[   +2 ms] List of devices attached
           520059e5c05b357b       device product:j6ltecis model:SM_J600F
           device:j6lte transport_id:1
[  +29 ms] C:\Users\maxpu\AppData\Local\Android\sdk\platform-tools\adb.exe -s
520059e5c05b357b shell getprop
[ +324 ms] Artifact Instance of 'FlutterWebSdk' is not required, skipping
update.
[  +13 ms] Artifact Instance of 'WindowsEngineArtifacts' is not required,
skipping update.
[   +3 ms] Artifact Instance of 'MacOSEngineArtifacts' is not required, skippingupdate.
[   +3 ms] Artifact Instance of 'LinuxEngineArtifacts' is not required, skippingupdate.
[   +2 ms] Artifact Instance of 'FuchsiaCacheArtifacts' is not required,
skipping update.
[ +336 ms] ro.hardware = samsungexynos7870
[  +75 ms] Launching lib/main.dart on SM J600F in debug mode...
[  +42 ms] Initializing gradle...
[   +3 ms] Using gradle from
C:\Users\maxpu\Documents\DEV\Flutter_Pojects\test_app\android\gradlew.bat.
[ +231 ms] executing:
C:\Users\maxpu\Documents\DEV\Flutter_Pojects\test_app\android\gradlew.bat -v
[+1951 ms]
                    ------------------------------------------------------------
                    Gradle 4.10.2
                    ------------------------------------------------------------

                    Build time:   2018-09-19 18:10:15 UTC
                    Revision:     b4d8d5d170bb4ba516e88d7fe5647e2323d791dd

                    Kotlin DSL:   1.0-rc-6
                    Kotlin:       1.2.61
                    Groovy:       2.4.15
                    Ant:          Apache Ant(TM) version 1.9.11 compiled on
                    March 23 2018
                    JVM:          1.8.0_152-release (JetBrains s.r.o 25.152-b01)
                    OS:           Windows 10 10.0 amd64
[  +24 ms] Initializing gradle... (completed in 2,2s)
[   +2 ms] Resolving dependencies...
[   +1 ms] executing:
[C:\Users\maxpu\Documents\DEV\Flutter_Pojects\test_app\android\]
C:\Users\maxpu\Documents\DEV\Flutter_Pojects\test_app\android\gradlew.bat
app:properties
[+1463 ms]
                    FAILURE: Build failed with an exception.

                    * What went wrong:
                    org/gradle/launcher/daemon/protocol/DaemonMessageSerializer$
                    BuildSerializer

                    * Try:
                    Run with --stacktrace option to get the stack trace. Run
                    with --info or --debug option to get more log output. Run
                    with --scan to get full insights.

                    * Get more help at https://help.gradle.org
[   +9 ms] Resolving dependencies... (completed in 1,5s)
[   +7 ms] * Error running Gradle:
           ProcessException: Process

"C:\Users\maxpu\Documents\DEV\Flutter_Pojects\test_app\android\gradlew.bat"
           exited abnormally:

           FAILURE: Build failed with an exception.

           * What went wrong:

org/gradle/launcher/daemon/protocol/DaemonMessageSerializer$BuildSerializer

           * Try:
           Run with --stacktrace option to get the stack trace. Run with --info or --debug
           option to get more log output. Run with --scan to get full insights.

           * Get more help at https://help.gradle.org
             Command:

C:\Users\maxpu\Documents\DEV\Flutter_Pojects\test_app\android\gradlew.bat
             app:properties

[  +25 ms] "flutter run" took 5 026ms.
[   +1 ms] "flutter run" took 5 026ms.
Please review your Gradle project setup in the android/ folder.

#0      throwToolExit (package:flutter_tools/src/base/common.dart:24:3)
#1      _readGradleProject (package:flutter_tools/src/android/gradle.dart:158:7)<asynchronous suspension>
#2      _gradleProject (package:flutter_tools/src/android/gradle.dart:111:34)
<asynchronous suspension>
#3      getGradleAppOut (package:flutter_tools/src/android/gradle.dart:105:29)
<asynchronous suspension>
#4      AndroidApk.fromAndroidProject
(package:flutter_tools/src/application_package.dart:154:23)
<asynchronous suspension>
#5      ApplicationPackageFactory.getPackageForPlatform
(package:flutter_tools/src/application_package.dart:46:32)
<asynchronous suspension>
#6      FlutterDevice.runHot
(package:flutter_tools/src/resident_runner.dart:345:56)
<asynchronous suspension>
#7      HotRunner.run (package:flutter_tools/src/run_hot.dart:253:39)
<asynchronous suspension>
#8      RunCommand.runCommand
(package:flutter_tools/src/commands/run.dart:428:37)
<asynchronous suspension>
#9      FlutterCommand.verifyThenRunCommand
(package:flutter_tools/src/runner/flutter_command.dart:559:18)
#10     _asyncThenWrapperHelper.<anonymous closure>
(dart:async-patch/async_patch.dart:77:64)
#11     _rootRunUnary (dart:async/zone.dart:1132:38)
#12     _CustomZone.runUnary (dart:async/zone.dart:1029:19)
#13     _FutureListener.handleValue (dart:async/future_impl.dart:126:18)
#14     Future._propagateToListeners.handleValueCallback
(dart:async/future_impl.dart:639:45)
#15     Future._propagateToListeners (dart:async/future_impl.dart:668:32)
#16     Future._complete (dart:async/future_impl.dart:473:7)
#17     _SyncCompleter.complete (dart:async/future_impl.dart:51:12)
#18     _AsyncAwaitCompleter.complete (dart:async-patch/async_patch.dart:28:18) #19     _completeOnAsyncReturn (dart:async-patch/async_patch.dart:294:13)
#20     RunCommand.usageValues (package:flutter_tools/src/commands/run.dart)
#21     _asyncThenWrapperHelper.<anonymous closure>
(dart:async-patch/async_patch.dart:77:64)
#22     _rootRunUnary (dart:async/zone.dart:1132:38)
#23     _CustomZone.runUnary (dart:async/zone.dart:1029:19)
#24     _FutureListener.handleValue (dart:async/future_impl.dart:126:18)
#25     Future._propagateToListeners.handleValueCallback
(dart:async/future_impl.dart:639:45)
#26     Future._propagateToListeners (dart:async/future_impl.dart:668:32)
#27     Future._complete (dart:async/future_impl.dart:473:7)
#28     _SyncCompleter.complete (dart:async/future_impl.dart:51:12)
#29     _AsyncAwaitCompleter.complete.<anonymous closure>
(dart:async-patch/async_patch.dart:33:20)
#30     _rootRun (dart:async/zone.dart:1124:13)
#31     _CustomZone.run (dart:async/zone.dart:1021:19)
#32     _CustomZone.bindCallback.<anonymous closure>
(dart:async/zone.dart:947:23)
#33     _microtaskLoop (dart:async/schedule_microtask.dart:41:21)
#34     _startMicrotaskLoop (dart:async/schedule_microtask.dart:50:5)
#35     _runPendingImmediateCallback
(dart:isolate-patch/isolate_patch.dart:115:13)
#36     _RawReceivePortImpl._handleMessage
(dart:isolate-patch/isolate_patch.dart:172:5)

$ flutter analyze
Analyzing test_app...
No issues found! (ran in 32.4s)

$ flutter doctor -v
[√] Flutter (Channel stable, v1.5.4-hotfix.2, on Microsoft Windows [Version
    10.0.18356.16], locale uk-UA)
    • Flutter version 1.5.4-hotfix.2 at C:\Flutter
    • Framework revision 7a4c33425d (9 weeks ago), 2019-04-29 11:05:24 -0700
    • Engine revision 52c7a1e849
    • Dart version 2.3.0 (build 2.3.0-dev.0.5 a1668566e5)

[√] Android toolchain - develop for Android devices (Android SDK version 29.0.0)
    • Android SDK at C:\Users\maxpu\AppData\Local\Android\sdk
    • Android NDK location not configured (optional; useful for native profiling
      support)
    • Platform android-29, build-tools 29.0.0
    • Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build
      1.8.0_152-release-1343-b01)
    • All Android licenses accepted.

[√] Android Studio (version 3.4)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin version 37.0.1
    • Dart plugin version 183.6270
    • Java version OpenJDK Runtime Environment (build
      1.8.0_152-release-1343-b01)

[√] VS Code, 64-bit edition (version 1.35.1)
    • VS Code at C:\Program Files\Microsoft VS Code
    • Flutter extension version 3.2.0

[√] Connected device (1 available)
    • SM J600F • 520059e5c05b357b • android-arm • Android 9 (API 28)

• No issues found!

Solved this by changing Gradle version in android\gradle\wrapper\gradle-wrapper.properties from 4.10.2 to 5.5.
Also changed it in Flutter_DIR\packages\flutter_tools\templates\app\android.tmpl\gradle\wrapper\gradle-wrapper.properties so that all new projects was with this fix.
New gradle-wrapper.properties:
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-5.5-all.zip


Micrometer Observation

This PR adds support for Micrometer Observation instrumentation of Apache CXF.
NOTE: This PR is heavily influenced by Brave's implementation.
Dependencies

Adds micrometer tracing
Adds zipkin sender

CXF metrics project

Now also does tracing (TODO: maybe this should be done in a separate module?)
Adds dependency on rt-management since metrics will now also be related to tracing
Adds dependency to Micrometer Observation
Is a copy of the Brave Tracing module but adopted to Micrometer Observation API
Uses low and high cardinality tags basing on OpenTelemetry Semantic Conventions for RPC and HTTP (JaxRs) from 19.07.2023. VERY IMPORTANT: This doesn't mean that this project is OTel Semantic Convention compliant!!!
Uses ObservationDocumentation that using https://micrometer.io/docs/observation#_documentation_generation could generate asciidoctor documentation of observability data

Spring Boot

adds MicrometerObservationAutoConfiguration that registers Features as beans

Tests

reused existing Brave tests with Micrometer Observation, altered existing tagging and naming defaults to make the test pass with Brave tagging and naming defaults
reused existing Boot tests to additionally assert observation based metrics and traces

TODO ? :

maybe the code shouldn't be in CXF metrics module but a completely separate one?
add Javadocs?
add documentation - where should it be added?

Screenshots from Zipkin:

Fixes https://issues.apache.org/jira/browse/CXF-8817

Thanks a lot for the pull request @marcingrzejszczak !

Now also does tracing (TODO: maybe this should be done in a separate module?)

This is the way CXF structures the integrations: the tracing is separated from metrics (integration/tracing). Could you please split them into separate modules? Thank you.

@reta I've moved the Micrometer Observation integration under the tracing folder. The integration allows you to actually not have tracing at all and in essence is tracing agnostic, however for the sake of consistency I put it under the tracing folder

@reta I've moved the Micrometer Observation integration under the tracing folder. The integration allows you to actually not have tracing at all and in essence is tracing agnostic, however for the sake of consistency I put it under the tracing folder

Thanks a lot @marcingrzejszczak , there are some failures in the build, could you please take a look? thank you
Caused by: java.lang.IllegalStateException: Failed to introspect Class [org.apache.cxf.spring.boot.autoconfigure.micrometer.MicrometerObservationAutoConfiguration] from ClassLoader [jdk.internal.loader.ClassLoaders$AppClassLoader@5cb0d902]
	at org.springframework.util.ReflectionUtils.getDeclaredMethods(ReflectionUtils.java:483)
	at org.springframework.util.ReflectionUtils.doWithMethods(ReflectionUtils.java:360)

Hey @reta . I've applied all the suggestions and rebased the branch against main. Anything else you would like me to do?

LGTM!


chore: do not run panvimdoc on tag

:tada: This PR is included in version 1.0.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


When running in console mode, it should run properly

Specially when you are running under the debugger to ensure your test is correct, there shouldnt be any failure.
For example I had to resort to:
public class BenchBase
    {
        protected void ExecuteBenchmark( Action action )
        {
            if ( Debugger.IsAttached )
            {
                action();
            }
            else
            {
                foreach (var iteration in Benchmark.Iterations)
                {
                    using (iteration.StartMeasurement())
                    {
                        action();
                    }
                }
            }
        }
    }

It could be great that you can have a ConsoleIteration running instead. If that is not possible a NullIteration at least so we dont get a NullReferenceException

@redknightlois, can you tell me a bit more about the failure that you saw here?

Closing prior to archive.

Closing prior to archive.


Upgrade Tabler icons to v1.119.0

This PR bumps the Tabler icon set version from 1.70.0 to 1.119.0, adding many new icons.

Not sure whether I did this correctly--I imagine one (or multiple) of the build commands need to be rerun and the package version bumped. Hoping to at least kick off the upgrade process for this icon set here, though. Let me know @x64Bits if there are changes I should make to this PR to help make that happen.

Hello @sebastiansandqvist, will review this PR, sorry for the late response i was so much busy, in first instance this looks well, but today at the end of the day i promise to review everything, thanks.

I have tried to run the build locally but I get this error:
var ry = item.attr('ry').value || 0;
                        ^
TypeError: Cannot read properties of undefined (reading 'value')
    at Object.exports.fn (/Users/izsabo/code/solid-icons/lib/node_modules/svgo/plugins/convertEllipseToCircle.js:22:31)

It seems to be related with SVGO the lib are currently using an old version for the svg optimization, @aminya have this PR open, i'm going to take a look this tomorrow, merge that PR first.

I'm currently building and uploading the icons with the table icons v1.119.0, thanks for the contribution.


buck: 2<IP_ADDRESS> -> 2<IP_ADDRESS>

Motivation for this change
closes #119224
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 119247 at 8da4120a run on x86_64-linux 1

1 package built successfully:

buck

3 suggestions:

warning: missing-patch-comment
Please add a comment on the line above, explaining the purpose of this patch.
Near pkgs/development/tools/build-managers/buck/default.nix:14:15:
   |
14 |   patches = [ ./pex-mtime.patch ];
   |               ^

warning: missing-phase-hooks
installPhase should probably contain runHook preInstall and runHook postInstall.
Near pkgs/development/tools/build-managers/buck/default.nix:31:3:
   |
31 |   installPhase = ''
   |   ^

warning: missing-phase-hooks
buildPhase should probably contain runHook preBuild and runHook postBuild.
Near pkgs/development/tools/build-managers/buck/default.nix:22:3:
   |
22 |   buildPhase = ''
   |   ^

cc @HolgerPeters


update error message with contact info and explanation that url may have migrated

this is for fedora
is there a way for the repository frontend to tell when an object is compound, and display a more informative error message until we have the compound object viewer working?
like for https://specialcollections.du.edu/object/cdpsm:177 it'd be good if it told a user to contact<EMAIL_ADDRESS>if they have questions about how to access it
not a high priority, I was just thinking about it because they got a reference question downstairs about the American Alpine Club oral histories (of which that is one)

change for new and old instance

Added the contact info message for all objects that can not be displayed

done


[PP-1818] implement month active user data

Description
This update includes the following changes:

The patron object now has a uuid field.
Patrons can erase their activity history with a PUT to  the /patrons/me/erase_activity_history endpoint.
The uuid is passed to the s3 analytics provider.

Motivation and Context
https://ebce-lyrasis.atlassian.net/browse/PP-1818

How Has This Been Tested?

Checklist

[ ] I have updated the documentation accordingly.
[ ] All new and existing tests passed.

You may have considered this already, but while looking into PP-1863, I was reminded that we have a credential type of Credential.IDENTIFIER_TO_REMOTE_SERVICE that might be suitable for this purpose or as a template for associating an identifier with a patron, but without modifying the patron table.
Sorry to lob in a hand grenade 💣 at this stage. Feel free to do -- or not do ("There is no try?") -- what you will with this information.

@tdilauro :  I appreciate your suggestion.  And I like it.  I can't think of a good reason not to do it that way other than that I did it this way and it works and is done and I feel like I need to move on.  But I suppose if we wanted to rework it in the future it would not be a heavy lift to do it.


'install' is deprecated, use 'async_install' instead

Describe the bug

every time I'm trying to install it i get error
Logger: hacs.repository.plugin.maxwroc.battery-state-card
Source: custom_components/hacs/repositories/helpers/methods/installation.py:17
First occurred: 7:33:38 PM (1 occurrences)
Last logged: 7:33:38 PM
'install' is deprecated, use 'async_install' instead
trying to install version v1.3.7
im running
HassOS 4.10
Home Assistant 0.110.6
Supervisor 227

This error doesn't come from my card and seems to be related to HACS. Please make sure you have the most recent version of HACS and if error persists report it on HACS repo


nvs error codes missing from esp_err_to_name... __has_include("nvs.h") is false (IDFGH-1438)

Using cmake with the esp32-2019r1-rc2 toolchain, #if __has_include("nvs.h") is evaluating to false in esp_err_to_name.c
I have nvs_flash included in my COMPONENT_REQUIRES setting, but the nvs component include directory is not being added to the compile line for esp_err_to_name.c

@bpietsch Sorry for getting back to you so late. Thanks for reporting the issue. Would you please help provide more details as suggested in the issue template? Thanks.


Update 2394-async_await.md

'block_on' function might have been moved from futures module to futures::executor module. I wonder if the dependency used there should be state explicitly?

We don't really have a policy if RFCs get updated after acceptance. I'll let the lang team decide if they want to merge this or not, but in general, RFCs are not a spec, and you can't assume they're what's actually in the language.
r? @rust-lang/lang

I don't see any problem with merging this change, but I don't want anyone getting the idea that every past RFC will remain accurate in the future and should be kept up to date.

I think we should merge it, though I agree that we don't have a general rule towards keeping RFCs fully up to date.


Increased number of iterations for pbkdf2_sha256.

Increased number of iterations for pbkdf2_sha256.
OWASP recommendation (double number of iterations every 2 years)

Please see https://groups.google.com/d/topic/django-developers/Qab-hRG-SKs/discussion for our methodology.


add converter

run bash convert.sh will convert notebooks into markdown files, which can be merged into mxnet directly

Thanks Mu!


VS Code fails to highlight syntax properly if type of return value provided

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version: 1.81.0 (Universal)
OS Version: macOS 13.4.1 (c), BuildVersion: 22F770820d

Steps to Reproduce:

Select the color scheme "Github Dark";
Create a Python file and write a function with a type hint which indicates the type of the return value; e.g.

# Xuan Chen - Aug 4, 2023

def get_list(some_val: int, other_val: int) -> list[int]:
    return [some_val, other_val]

if __name__ == "__main__":
    # The color of "if" is black, which should be red in this color scheme
    # The color of "__main__" is also black, which should be dark blue in this color scheme
    print(get_list(2023, 8))

I found that some of the lines under the function appear in improper colors.
Note: This problem occurs no matter which color scheme I select.

Just a supplementary question, whether pylance also fails and keeps showing loading? i got such problem.

I'm not seeing this on our latest prerelease build (2024.2.105). I'm closing this under the assumption that it is fixed. If you are still seeing this behavior, please reopen -- we'll need additional details on how to repro this.


[Publisher] Displaying incorrect no.of API products

When API products are deleted, the products are no longer displayed in the API Products page, but the count is not updated at the top left corner.
Here I have created 2 API products and deleted 1, but it still shows "Displaying 2 API Product(s)", which should be shown as 1.

This issue is intermittent and can be observed for APIs Listing as well.

Fixed with https://github.com/wso2/carbon-apimgt/pull/7513


Investigating LLVM as a general backend for x86, x64 and arm64 code generation

Per our chat on gitter.im/dotnet/corert today, we are investigating whether or not it makes sense for us to put some work into getting LLVM as a backend for CoreRT. (For a full context of why we need that, please refer to the gitter conversation, or feel free to contact me directly)
Thanks to all the great work that's already been done via LLVM for wasm, perhaps the project wouldn't be as crazy as I immediately think.
With help from @MichalStrehovsky and @yowl, and based on Michal's zerosharp code, I got a tiny little no-corelib Hello world to compile via LLVM an x86 Mac executable:
https://github.com/dotnet/corert/compare/master...christianscheuer:macllvm
To test it, make sure to install the prerequisites (it needs llvm 10.0 and the MacOS 10.13 SDK installed, see the README for more info), then build CoreRT in Debug and skip the tests: ./build.sh skiptests, then go into the tests/src/llvm directory and run ./build.sh.
It will run CSC to compile to IL, run the modified ILC from the repo to compile to bitcode (which uses the WebAssembly LLVM backend with some hardcoded modifications) - and then use the installed LLVM 10 linker (it needs to be the same major version of LLVM that's used to produce the bitcode, and we're using libLLVM 10 to produce the bitcode) to produce a runnable executable. It then runs it, it prints Hello world and returns 42 :)
--
Now all of this raises a bunch of questions it would be great to get your input to.

Assuming that we would be going down this path, I expect the first step would be to look at how to refactor the WebAssembly backend so that a new, generic ILToLLVMImporter can be created as a base class, and have ILToWebAssemblyImporter inherit from that, as well as other derived classes for the new x86, x64, arm64 targets (or, some other structure). For example, I suspect many opcode importers, stack management etc. should be the same no matter if the "architecture" is wasm or x64 (accounting for different pointer sizes), so there should be a lot of code that can be reused. Things like the shadow stack however I don't think we'll need for anything but wasm, if I understand the reasons behind it correctly, so there would be a challenge to see how to structure the code so both a shadow stack based and regular stack based version can coexist.
So the question is - with all of this in mind: How would you approach code structuring of such an endeavor?
Obviously we can do a clean copy-paste into a different directory, but I thought the two implementations could benefit from each other if they were linked...

Overall engineering plan
What would be the best way to approach the rest of the bringup, once that initial refactor has been done? What would be the best order of x64-ifying it (ie. add support for 8 byte pointer sizes, potentially remove the shadow stack, etc.)
Any other considerations?

I dont believe Emscripten nor LLVM (https://reviews.llvm.org/D68254) support wasm64 yet, but it is planned so would be good to make any 64 bit refactoring available to Wasm also.

There are short term, medium term, and long term aspects to this work.
The short term aspect is that the CoreRT repo is getting migrated to the runtimelab repo (https://github.com/dotnet/runtimelab/issues/4) and this work is likely to happen this summer (I just got green light to spend ~20% of my worktime on this in the coming weeks). As part of the move we will be switching build tooling to the one used to build the official runtime. This is mostly a good thing: the CoreRT repo is currently built using tools that were current as of .NET Core 2.0 and are starting to hit limits (we can no longer update CoreLib because it now uses prerelease C# 9.0 and we cannot consume that compiler in this repo anymore without significant build work). Once the move to runtimelab is done, it will be much easier to keep CoreRT current (just integrate from runtime master branch). The impact is that there will be churn in how the product is built/tested in the coming months. In the first phase we would be moving the more mature parts of the project (i.e. RyuJIT-based codegen). The more experimental parts of the project (CppCodegen, LLVM-WASM, Interpreter, JIT, etc.) would come later, potentially to separate branches of the official runtimelab repo (we would have a dialog on this in the coming months).
The medium term aspect is how to organize codesharing between LLVM backends targeting physical architectures vs WASM in the CoreRT AOT compiler. My gut feel would be to shoot for a ILCompiler.LLVM assembly where most of ILCompiler.WebAssembly would move to. Then build a structure where the bare LLVM importer has some virtual methods that the WebAssembly-specific backend can override. I expect the main differences would be around parameter passing and stack management. We might even just consider renaming ILCompiler.WebAssembly to ILCompiler.LLVM and have ifs in places. We definitely want to share as much as possible.
The long term aspect is also about sharing. .NET (especially code in CoreLib) is getting excessively reliant on optimization RyuJIT can do. For example, to get good performance with C# async, the code generator needs to do devirtualization and boxing elimination. Most of these managed optimizations happen in RyuJIT’s importer (the part of the code generator that reads IL and transforms it to RyuJIT’s IR) – a possible different route for LLVM would be to plug into RyuJIT’s IR to take advantage of all the managed optimizations that RyuJIT does while importing IL into IR. The existing LLVM optimization passes are not capable of doing the kind of managed-code-specific optimizations that RyuJIT does in the importer (e.g. optimize typeof(X).IsValueType into a compile-time constant, etc.). Without plugging into RyuJIT’s importer, any high performance LLVM backend will be playing catch-up to RyuJIT’s managed optimizations. There are years worth of work in RyuJIT to catch up to and more of these managed-code-specific optimizations are going into RyuJIT all the time. The current approach with the LLVM-WASM is good, clean, green-field architecture, but it will have hard time achieving same or better performance compared to RyuJIT on platforms that RyuJIT targets.

A RyuJit to LLVM bridge would be interesting (similar to how mono bridges to LLVM) for a number of reasons.
It would nice to be able to run this as an optional mode for the regular runtime as well. LLILC has some of the tech needed to go from LLVM back to the data structures the runtime expects.
My guess is you'd want to bridge over fairly late, at the lower/codegen stages of the RyuJit pipeline.
I'd be happy to consult/help with this, though not sure how much time I'll have available.

Thank you both for the thorough answers.
@MichalStrehovsky wrt the medium term aspect vs the long term (ie. LLVM based off of importing IL straight from the source, vs. reading RyuJit IR): Is there any possible path you can see where the medium term work (furthering IL->LLVM for x64+ARM64) wouldn't be in vain? For example, would it make sense to have the RyuJit IR be represented/converted back to IL, as a way to be able to share the code with how we do IL->LLVM in the current wasm backend - or would that defeat the purpose somewhat by losing potentially valuable information from the RyuJit IR?
@AndyAyersMS just out of curiosity and trying to understand how all this works - why would there be / is there a need to go from LLVM back to the runtime data structures? What's the tech LLILC has that helps with this?
On another note, it sounds to me like we should wait while the repo migration gets done before embarking on any further LLVM experimentation / prep of the refactor needed for LLVM sharing both wasm and physical archs, if I'm reading you correctly.
My completely unsolicited 2 cents on repo structuring for runtimelab would be to not rely on branches for experiments, as it quite effectively makes it needed to do tons of git-hackery in order to potentially combine experiments. (Although I understand the sentiment from a collaboration perspective).

would it make sense to have the RyuJit IR be represented/converted back to IL

That is very hard / impossible. We tried this in the past with a different compiler and it did not work well.

What's the tech LLILC has that helps with this?

gcinfo encoding, for example.

My completely unsolicited 2 cents on repo structuring for runtimelab would be to not rely on branches for experiments, as it quite effectively makes it needed to do tons of git-hackery in order to potentially combine experiments.

What git hackery are you concerned about? The NativeAOT branch that we're setting up for CoreRT is basically just another fork of the dotnet/runtime master branch - I expect most experiments in the runtime space would follow that pattern - integrating between those is really just about integrating two branches. There are other branches, like the DllImportGenerator branch that would require hackery to merge, but those have different characteristics.
Eventually, once an experiment graduates, it would be simply copied over to the runtime repo, per dotnet/runtime#35609.

Maybe I misunderstood the definition of an experiment. It just sounded like CoreRT-regular, CoreRT with JIT, CoreRT-LLVM-wasm, CoreRT-LLVM-physical etc. all would end up on separate branches, so if I wanted to consume a combination of say the experimental JIT and experimental LLVM, I'd have no way to point to a single commit or version, but would have to maintain my own branch integrating those together. Not sure if that would be easy or complex, it just sounds a bit like busywork and moving complexity to the consumer.
I guess I'm also basing this off of that it appears experiments are experiments for a very long while before graduating, even if they're already usable :) So my point was just that however you do it that I hope it's not gonna be more complex to consume the "experimental" builds. For example, we really like the fact that we can consume ready-built CoreRT packages today, and I think such a scheme is very good for adoption. If now I could just add a flag in the .csproj to include say JIT or LLVM that would be my preferred scheme, if they co-existed. I'm sure there are good reasons for why you cannot do it, but there's a big difference from consuming the experiments by enabling a flag somewhere to having to maintain our own branch merging other branches together and understanding potential conflicts between such branches.
But again I might be misunderstanding - so I'll just watch what you do and I'm sure you've thought of these things.

I see. I would expect LLVM-wasm and LLVM-physical to be in the same branch if they're both based on LLVMSharp (and not the RyuJIT IR plan). Whether that branch is NativeAOT or some "NativeAOT-LLVM", we'll decide/discuss based on practicality. The practical consideration includes things like "the runtime repo already handles Emscripten-based builds and we should definitely hook into that, but that also means that whenever dotnet/runtime repo upgrades emscripten and there's fallout from that, fixing the fallout is a prerequisite to a successful refresh from dotnet/runtime" (and similarly, whenever there's a RyuJIT change that requires followup, resolving that is blocking successful integrations). I don't have a good sense right now on how many difficulties we would be facing in integrations and that's why I don't have much to say. We'll want to keep NativeAOT pretty up-to-date with dotnet/runtime master because it proved useful in the past to root cause unexpected regressions.
We'll definitely have NuGet packages for all runtimelab experiments.

The practical consideration includes

Another factor to consider is level of maturity of different experiments. CoreRT repo kept experiments with very different maturity levels in the same branch and build that did help with clarity.

@jkotas Did you mean "did not help with clarity"?

Yes, fixed.

if they're both based on LLVMSharp (and not the RyuJIT IR plan).

Why does using LLVMSharp preclude RyuJIT IR?

Why does using LLVMSharp preclude RyuJIT IR?

It doesn't - it just felt that two different experiments with a dependency on LLVM in the same branch could be troublesome. But maybe it's not that much trouble - e.g. they don't need to use the same version of LLVM. As long as we don't have to build LLVM from source twice, it should be fine for them to be in a single branch.


iOS App running on iOS 14 crashes every-time new push comes #1569

Device iPhone X
version- iOS 14 beta version.
App is crashing every time once new push come.
anyone have solution for this.

Getting same issue, Can someone please check this , app is crashing on push only in iOS 14

iOS 14 is released today, and we're experiencing this in our production app right now.

The crash happens consistently when a push notification comes in on an iOS 14 device, in this code block (line 287 of RNCPushNotificationIOS.m):

It seems that the crash is related to this addition to AppDelegate.m required by the push-notification-ios's README:
// Required for the notification event. You must call the completion handler after handling the remote notification.
- (void)application:(UIApplication *)application didReceiveRemoteNotification:(NSDictionary *)userInfo
fetchCompletionHandler:(void (^)(UIBackgroundFetchResult))completionHandler
{
  [RNCPushNotificationIOS didReceiveRemoteNotification:userInfo fetchCompletionHandler:completionHandler];
}

When I comment out [RNCPushNotificationIOS didReceiveRemoteNotification:userInfo fetchCompletionHandler:completionHandler];, no crash occurs with iOS 14. But there may be unintended side effects? Maintainers and knowledgeable folks, please advise.
Here is the Xcode debug console output at the time of the crash:
2020-09-16 22:40:16.390423-0500 Skale[1427:180516] [assertion] Error acquiring assertion: <Error Domain=RBSAssertionErrorDomain Code=3 "Target is not running or required target entitlement is missing" UserInfo={RBSAssertionAttribute=<RBSDomainAttribute| domain:"com.apple.webkit" name:"Background" sourceEnvironment:"(null)">, NSLocalizedFailureReason=Target is not running or required target entitlement is missing}>
2020-09-16 22:40:16.390553-0500 Skale[1427:180516] [ProcessSuspension] 0x1175611c0 - ProcessAssertion: Failed to acquire RBS Background assertion 'WebProcess Background Assertion' for process with PID 1431, error: Error Domain=RBSAssertionErrorDomain Code=3 "Target is not running or required target entitlement is missing" UserInfo={RBSAssertionAttribute=<RBSDomainAttribute| domain:"com.apple.webkit" name:"Background" sourceEnvironment:"(null)">, NSLocalizedFailureReason=Target is not running or required target entitlement is missing}
2020-09-16 22:40:16.397587-0500 Skale[1427:180516] [assertion] Error acquiring assertion: <Error Domain=RBSAssertionErrorDomain Code=3 "Target is not running or required target entitlement is missing" UserInfo={RBSAssertionAttribute=<RBSDomainAttribute| domain:"com.apple.webkit" name:"Background" sourceEnvironment:"(null)">, NSLocalizedFailureReason=Target is not running or required target entitlement is missing}>
2020-09-16 22:40:16.397667-0500 Skale[1427:180516] [ProcessSuspension] 0x117561240 - ProcessAssertion: Failed to acquire RBS Background assertion 'WebProcess Background Assertion' for process with PID 1431, error: Error Domain=RBSAssertionErrorDomain Code=3 "Target is not running or required target entitlement is missing" UserInfo={RBSAssertionAttribute=<RBSDomainAttribute| domain:"com.apple.webkit" name:"Background" sourceEnvironment:"(null)">, NSLocalizedFailureReason=Target is not running or required target entitlement is missing}
2020-09-16 22:40:23.704512-0500 Skale[1427:180688] [connection] nw_read_request_report [C8] Receive failed with error "Software caused connection abort"
2020-09-16 22:40:23.710848-0500 Skale[1427:180688] [connection] nw_read_request_report [C23] Receive failed with error "Software caused connection abort"
2020-09-16 22:40:23.711262-0500 Skale[1427:180688] [connection] nw_read_request_report [C15] Receive failed with error "Software caused connection abort"
2020-09-16 22:40:23.711968-0500 Skale[1427:180688] [connection] nw_read_request_report [C14] Receive failed with error "Software caused connection abort"
2020-09-16 22:40:23.715756-0500 Skale[1427:180688] [connection] nw_read_request_report [C21] Receive failed with error "Software caused connection abort"
2020-09-16 22:40:23.716220-0500 Skale[1427:180688] [connection] nw_read_request_report [C17] Receive failed with error "Software caused connection abort"
2020-09-16 22:40:23.750165-0500 Skale[1427:180688] Connection 1: received failure notification
2020-09-16 22:40:23.750264-0500 Skale[1427:180688] [connection] nw_flow_add_write_request [C1 <IP_ADDRESS>:8081 failed channel-flow (satisfied (Path is satisfied), viable, interface: en0, ipv4, ipv6, dns)] cannot accept write requests
2020-09-16 22:40:23.750310-0500 Skale[1427:180688] [connection] nw_write_request_report [C1] Send failed with error "Socket is not connected"
2020-09-16 22:40:23.773660-0500 Skale[1427:180688] Connection 16: received failure notification
2020-09-16 22:40:23.773720-0500 Skale[1427:180688] [connection] nw_flow_add_write_request [C16.1 <IP_ADDRESS>:443 failed channel-flow (satisfied (Path is satisfied), viable, interface: en0, ipv4, ipv6, dns)] cannot accept write requests
2020-09-16 22:40:23.773755-0500 Skale[1427:180688] [connection] nw_write_request_report [C16] Send failed with error "Socket is not connected"
2020-09-16 22:40:23.774000-0500 Skale[1427:180688] Connection 18: received failure notification
2020-09-16 22:40:23.774857-0500 Skale[1427:180688] [connection] nw_flow_add_write_request [C18.1 <IP_ADDRESS>:443 failed channel-flow (satisfied (Path is satisfied), viable, interface: en0, ipv4, ipv6, dns)] cannot accept write requests
2020-09-16 22:40:23.775031-0500 Skale[1427:180688] [connection] nw_write_request_report [C18] Send failed with error "Socket is not connected"
2020-09-16 22:40:23.775966-0500 Skale[1427:180688] Connection 19: received failure notification
2020-09-16 22:40:23.776011-0500 Skale[1427:180688] [connection] nw_flow_add_write_request [C19.1 <IP_ADDRESS>:443 failed channel-flow (satisfied (Path is satisfied), viable, interface: en0, ipv4, ipv6, dns)] cannot accept write requests
2020-09-16 22:40:23.776042-0500 Skale[1427:180688] [connection] nw_write_request_report [C19] Send failed with error "Socket is not connected"
2020-09-16 22:40:23.777389-0500 Skale[1427:180688] Connection 20: received failure notification
2020-09-16 22:40:23.778188-0500 Skale[1427:180688] [connection] nw_flow_add_write_request [C20.1 <IP_ADDRESS>:443 failed channel-flow (satisfied (Path is satisfied), viable, interface: en0, ipv4, ipv6, dns)] cannot accept write requests
2020-09-16 22:40:23.778458-0500 Skale[1427:180688] [connection] nw_write_request_report [C20] Send failed with error "Socket is not connected"
2020-09-16 22:40:23.778798-0500 Skale[1427:180688] Connection 24: received failure notification
2020-09-16 22:40:23.778835-0500 Skale[1427:180688] [connection] nw_flow_add_write_request [C24.2 <IP_ADDRESS>:443 failed channel-flow (satisfied (Path is satisfied), viable, interface: en0, ipv4, ipv6, dns)] cannot accept write requests
2020-09-16 22:40:23.778864-0500 Skale[1427:180688] [connection] nw_write_request_report [C24] Send failed with error "Socket is not connected"
2020-09-16 22:40:23.781361-0500 Skale[1427:180688] Connection 27: received failure notification
2020-09-16 22:40:23.783075-0500 Skale[1427:180688] [connection] nw_flow_add_write_request [C27.1 <IP_ADDRESS>:443 failed channel-flow (satisfied (Path is satisfied), viable, interface: en0, ipv4, ipv6, dns)] cannot accept write requests
2020-09-16 22:40:23.783238-0500 Skale[1427:180688] [connection] nw_write_request_report [C27] Send failed with error "Socket is not connected"
2020-09-16 22:40:23.783869-0500 Skale[1427:180688] Connection 13: received failure notification
2020-09-16 22:40:23.783911-0500 Skale[1427:180688] [connection] nw_flow_add_write_request [C13 <IP_ADDRESS>:8081 failed channel-flow (satisfied (Path is satisfied), viable, interface: en0, ipv4, ipv6, dns)] cannot accept write requests
2020-09-16 22:40:23.783943-0500 Skale[1427:180688] [connection] nw_write_request_report [C13] Send failed with error "Socket is not connected"
2020-09-16 22:40:23.798754-0500 Skale[1427:180688] Connection 11: received failure notification
2020-09-16 22:40:23.798826-0500 Skale[1427:180688] [connection] nw_flow_add_write_request [C11 <IP_ADDRESS>:8081 failed channel-flow (satisfied (Path is satisfied), viable, interface: en0, ipv4, ipv6, dns)] cannot accept write requests
2020-09-16 22:40:23.798865-0500 Skale[1427:180688] [connection] nw_write_request_report [C11] Send failed with error "Socket is not connected"
2020-09-16 22:40:23.801061-0500 Skale[1427:180688] Connection 22: received failure notification
2020-09-16 22:40:23.801110-0500 Skale[1427:180688] [connection] nw_flow_add_write_request [C22 <IP_ADDRESS>:8081 failed channel-flow (satisfied (Path is satisfied), viable, interface: en0, ipv4, ipv6, dns)] cannot accept write requests
2020-09-16 22:40:23.801142-0500 Skale[1427:180688] [connection] nw_write_request_report [C22] Send failed with error "Socket is not connected"

@saurabh874 @San10694 the workaround I'm currently deciding on is to comment out line 287 of RNCPushNotificationIOS.m (completionHandler(result);). This allows the app to receive push notifications while avoiding crashes and keep the ability to trigger local notifications.

Any progress on this? Every new push notification crashes devices running iOS 14 on our production app at the moment 😢

Same issue

same issue, any update?

@saurabh874 @San10694 the workaround I'm currently deciding on is to comment out line 287 of RNCPushNotificationIOS.m (completionHandler(result);). This allows the app to receive push notifications while avoiding crashes and keep the ability to trigger local notifications. There may still be some side effects that I'm not aware of; perhaps a maintainer can provide some insight?

how would you disable it only for iOS 14 though? could you show your snippet to how you are disabling the line?

did anyone managed to solve it?

https://github.com/react-native-community/push-notification-ios/issues/163#issuecomment-693818811 This workaround is works for me but I suppose no new update

@saurabh874 @San10694 the workaround I'm currently deciding on is to comment out line 287 of RNCPushNotificationIOS.m (completionHandler(result);). This allows the app to receive push notifications while avoiding crashes and keep the ability to trigger local notifications. There may still be some side effects that I'm not aware of; perhaps a maintainer can provide some insight?

Work around also worked for me.

I am facing the same issue on react native 0.63.3, ios 14.0.1.

I am noticing this too on my app since ios 14

Hello! I'm trying to address this issue with my iOS14 device, but I'm unable to reproduce the issue.
onFinishRemoteNotification mentioned in comment https://github.com/react-native-push-notification-ios/push-notification-ios/issues/163#issuecomment-693797255 seems to be called fine on my side.
Would someone be able to create a reproduction repo for this issue?

@Naturalclar Yes Still we are facing same issue. and this issue is come only when app is in foreground.

Hello! I'm trying to address this issue with my iOS14 device, but I'm unable to reproduce the issue.
onFinishRemoteNotification mentioned in comment #163 (comment) seems to be called fine on my side.
Would someone be able to create a reproduction repo for this issue?

You only need device on ios 14 and app in foreground receiving push

I'm using an iOS 14.1 device (iPhone 7) tried both local notification and push notification (using Pusher), tried both foreground and background but the notification seems to work fine.
I'm using the example app in this repo.

It will help if some one can provide a repository that will reproduce the crash so I could investigate further :)

Hi @Naturalclar
it will very helpful if you to comment out line 287 of RNCPushNotificationIOS.m (completionHandler(result);)
because i comment out this line and it is perfectly working.

tried on fresh RN 0.63.3 with GCM push notification - crash on every device with iOS 14+, maybe push provider is the reason

btw on simulator push notifications works perfect even in foreground, got crash only in test flight and production

Any updates?
I'm also getting this on RN 0.59.9, iOS 14+, iPhone12,3

I have same issue, commenting completionHandler(result) is not safe solution.

Also having the same issue on RN 0.61.4, iOS 14+. Was able to resolve by commenting the line recommended above, but following to see if the issue is resolved.

I've released 1.7.5-beta.0 with potential fix for this.
I wasn't able to reproduce the crash with the original package, so could someone verify that this change fixes the crash?

Sorry, 1.7.5-beta.0 didn't fixed my problem.
After commenting out completionHandler(result) like before, crash didn't occur

released v1.8.0 that should fix the issue

Thanks @Naturalclar! Can you share what was the issue, and why moving completionHandler() resolves it?

can confirm, version 1.8.0 not crashing anymore, but foreground push is not visible (event is firing)

@tmmgn  I'm using PushNotificationIOS.presentLocalNotification for iOS instead of PushNotification.localNotification , maybe it can resolve your problem.

I was facing the same problem in one of my projects, it seems that Apple has changed some very important aspects of Push notifications which affected many apps out there. It was possible to fix this issue following the steps posted by the user "edelabar_pmd" on their official forum: https://developer.apple.com/forums/thread/660149
Although after following the changes in the link above I found out that all these errors were gone for users running the app on iOS 14.2. I imagine it could be a very strong lead to first try building the app in this version before trying to change anything in the code (as this probably seems to be Apple's mistake, not the library's).

if you use RN 0.63.2 and fire-base ver 5.6.x Please follow the following link. It worked for me !!!!

i have same issue and solved with remove firebase messaging, in this case i remove @react-native-firebase/messaging


Implement IHttpResetFeature in Kestrel

#10886 We already had the ResetAndAbort functionality, we just needed a feature to expose it.

Should this raise the RequestAborted cancellation token in TestServer when called?

@JamesNK if we implemented it in TestServer... It's a specialized Abort.
That said, this is a weird one to implement in TestServer, there's no way to surface the reset to the client.

Abort (and CompleteAsync) in TestServer should probably return the HttpResponseMessage to the client immediately instead of waiting for the request delegate to complete. That would be a non-minor change.
I think at least we can make it raise the CT like Abort does - https://github.com/aspnet/AspNetCore/pull/9975

TestServer should already be returning the response message when you write/flush the response body. Making CompleteAsync work on top of that should be trivial, it just needs to additionally close the response body.
Abort on TestServer should throw on the client, not return a response message.
I'd be tempted to only expose IHttpResetFeature in TestServer for request that set the request protocol to HTTP/2.
IHttpResetFeature in TestServer behaving the same as Abort seems like a good start.
I can do a follow-up PR for TestServer CompleteAsync and Reset.


[DOC] Update schemas discover docs.

What changes were proposed in this pull request?
This PR is related to https://github.com/Qihoo360/XSQL/pull/70 and update the docs.
How was this patch tested?
No UT.

LGTM

@WeiWenda Thanks.


No login with admin on HTTP

When trying to log in to the admin-domain on a server with allow-http, the login page is displayed correctly, but whenever you enter the correct token, the page redirects to back the login page without any error on the web UI or console.
This happens because the Cookie is set with Secure Flag upon successful authentication (ui_handler.go:494). Since the request was done over HTTP, the cookie is not set and no error is displayed. Normally after the cookie is set, the page redirects to /tunnels, but since there is no access token cookie, the web UI redirects again to the login page.
I agree with the reasoning behind setting the cookie to secure and accessing the admin panel over HTTP is not a good idea (in production environments). However, because the admin domain can be accessed over HTTP and there is no error message, it causes some confusion.
Either accessing the admin-domain should be blocked when using HTTP, even if the allow-http flag is set or the Cookie must be set to Secure:False when accessing via HTTP.
I don't know if the  Secure:False cookie will be overwritten when accessing the admin-domain again using HTTPS. If you are working with standard ports (80 & 443) the insecure cookie set using HTTP should be accessible from HTTPS, but it will send the cookie information in plan text and this creates a new security issue. In this instance the set cookie needs to be investigated, if determined that it's unsecure, it should be removed and updated with a secure cookie. This introduces a lot of complexity and the easiest option would probably be to disable admin-domain access over HTTP altogether.

I agree, HTTP access to the admin domain should be blocked.

So, how can we connect to an admin-domain that is not using ports 80/443?

@retiolus I don't think this is currently possible. That would send a security cookie unencrypted over the internet, which is not a good idea. You need to either use the built-in TLS cert capabilities of boringproxy, or put it behind another reverse proxy which handles TLS termination.


Accordion doesn't open unless I refresh the browser

Description: I have the accordion component on a page and when going to that page from the home page and I click on one of the tabs, nothing happens and the tab doesn't open. Now if I refresh the browser while already on the page, the accordion then will open on click.

Hey @brianshimkus,
What tech stack are you using? Is there any online preview?
Thanks.

@zoltanszogyenyi This is a site that was created with Create React App. I don't have an online preview as this is for work and in a private repo for the time being.
Unless the accordion is on the originally rendered route, it won't work and I have to refresh the browser to get it to work again.

@zoltanszogyenyi I think this is the same issue as #86

what is ur solution ?

@zoltanszogyenyi This is a site that was created with Create React App. I don't have an online preview as this is for work and in a private repo for the time being.
Unless the accordion is on the originally rendered route, it won't work and I have to refresh the browser to get it to work again.

Same problem here. I'm using Nuxt3.

fasaya your saved my day 😊👌


Incorrect closing tag

On the liquid page documentation page :https://www.11ty.dev/docs/languages/liquid/#shortcodes
In the example that precedes the text "Note that you can put any Liquid tags or content inside ...", if I am not misunderstanding the documentation, it should close with enduser2 and not enduser.
It caused me a little confusion, being relatively new to the liquid syntax.

Thank you!


Feature/xaptc 57

changed response types and added delete test file methods

that <= 1 was a typo, should have been < 1 . I changed it now

Can we add a unit test to test that filename of 1 character is valid. Thanks!


cannot install on archlinux

$ sudo make install                                                           # ~/Downloads/Src/pmenu > master ?
mkdir -p /usr/local/bin
mkdir -p /usr/local/share/man/man1
m 755 pmenu /usr/local/bin/pmenu
make: m: No such file or directory
make: [Makefile:37: install] Error 127 (ignored)
m 644 pmenu.1 /usr/local/share/man/man1/pmenu.1
make: m: No such file or directory
make: [Makefile:38: install] Error 127 (ignored)

Fixed.


Utilize RGB or depth sensor data

Hi, thanks to your great work.
I want to re-implement your previous work with Depth camera information(https://www.mdpi.com/2079-9292/9/3/411) from this repo.
I checked that the valid rgb output from the vision camera mounted on the robot in gazebo and Rviz. But how do I get transfrom gazebo topic to ROS topic? Can I declare a new subscriber for the vision data like other subscribers declared in velodyne_env.py?
(this topic is related with #14 by Barry2333)
thanks,

Hi,
I am not sure what you mean by "get transfrom gazebo topic to ROS topic"? Can you explain that?
Yes, you should be able to add the depth camera to the robot. I think it is already attached, but not sure if it is publishing anything. Then you would need to create a subscriber in velodyne_env.py file just like any other subscriber and use the data as input into the network.
That paper was based on tensorflow base though, and I do not have that code anymore, so you would have to recreate that from the paper.


make api stable

Description & Motivation
The APIs are changing too frequently and are not backward compatible. When I upgraded from 1.8 to 2.0, I had to rewrite almost all of my code related to Lightning. TensorFlow is like that, but PyTorch is not, which is why PyTorch is more popular.
Pitch
No response
Alternatives
No response
Additional context
No response
cc @borda

yes, we are high;y committed to API stability from 2.0 onwards.
and apology for the inconvenience you had with updates :rabbit:

@ares89 Thanks for bringing this up!
Lightning 2.0 marks a new chapter for us. In the release notes here, we announced to the community:

To make the research experience better, we are introducing 2.0:
No API changes – We commit to backward compatibility in the 2.0 series

We went over the entire API in 1.9.x and overhauled it in 2.0. The core APIs are stable and every public function/method/class will get backward compatibility in the entire 2.x series. In very few cases, we explicitly marked APIs experimental in the docstring, these are the only ones that might change, but only if needed.
If you look at the current changelog for 2.1 for example, which has been in development for several months now, we only currently have 6 API deprecations and 3 removed APIs that are very niche and marked experimental. This list won't really change much until 2.1. These numbers are in very stark contrast to all our previous releases.
In conclusion, the upgrade process from 2.0 to 2.1 and onward will be an absolute breeze!
I hope this convinces you that we are on a good path and we're happy to hear your thoughts.
cc @lantiga


ci: change default dialect to bolt

We want to deprecated Bolt, so let's avoid updating this default :)


test_kernel_systicks from tests/portability/cmsis_rtos_v1 fails on nrf platforms

Describe the bug
The test case test_kernel_systicks from tests/portability/cmsis_rtos_v1 test suite fails consistently at nrf platforms: (nrf52dk_nrf52832, nrf52840dk_nrf52840 and nrf9160dk_nrf9160)
To Reproduce
Steps to reproduce the behavior:

run in zephyr dir ./scripts/sanitycheck --testcase-root ./tests/portability/cmsis_rtos_v1 --device-testing -p nrf52dk_nrf52832 -v -v --device-serial /dev/ttyACM0
See error

Expected behavior
The test case test_kernel_systicks passes on nrf platforms
Impact
not clear
Screenshots or console output
DEBUG   - DEVICE: Assertion failed at CMAKE_SOURCE_DIR/src/kernel_apis.c:58: test_kernel_systick: (diff <= max && diff >= min is false)
DEBUG   - DEVICE: start 991 stop 34848 (diff 1033233) wait 1000000
DEBUG   - DEVICE:
DEBUG   - DEVICE: FAIL - test_kernel_systick
DEBUG   - DEVICE: ===================================================================
DEBUG   - DEVICE: starting test - test_thread_apis
DEBUG   - DEVICE: PASS - test_thread_apis
DEBUG   - DEVICE: ===================================================================
[...]
DEBUG   - DEVICE: Test suite test_cmsis_apis failed.
DEBUG   - DEVICE: ===================================================================
DEBUG   - DEVICE: PROJECT EXECUTION FAILED
INFO    - 1/1 nrf52dk_nrf52832          tests/portability/cmsis_rtos_v1/portability.cmsis_rtos_v1 FAILED Failed (device 15.061s)
ERROR   - see: /home/maciej/zephyrproject2/zephyr/sanity-out/nrf52dk_nrf52832/tests/portability/cmsis_rtos_v1/portability.cmsis_rtos_v1/handler.log

INFO    - 0 of 1 tests passed (0.00%), 1 failed, 0 skipped with 0 warnings in 20.19 seconds
INFO    - In total 1 test cases were executed on 1 out of total 255 platforms (0.39%)
INFO    - 1 tests executed on platforms, 0 tests were only built.

Hardware distribution summary:

| Board            | ID   |   Counter |
|------------------|------|-----------|
| nrf52dk_nrf52832 |      |         1 |

Environment:

OS:  Linux,
Toolchain Zephyr SDK
Commit SHA b5764f9902

Additional context
The test seems to pass on other platforms (https://testing.zephyrproject.org/daily_tests/v2.3.0-rc2/report/index.html). The value for diff supposed to be between min 990000 and max 1010000
From running it 3 times per platform I've got diff eq. to:
nrf52dk_nrf52832: 1032470, 1033355 and 1033843
nrf52840dk_nrf52840: 981140, 980743 and 981384
nrf9160dk_nrf9160: 1127929, 1121948 and 1121459

The diff values per platform look precise (close to each other) but inaccurate (far from expected value). Could it be some calibration issue?

@nordic-krch if you have a chance, could you take a quick look please?

The test continues to fail for nrf9160. The values for diff when failing are still close to the ones reported before (on my board, I am not sure if this value is the board- or platform- characteristic). As I mentioned in an earlier comment it looks like not a precision issue but an accuracy one.
I would imagine that performing some clock calibration for a board as an initial step could solve these problems. Maybe this would also help with other clock related issues?

Here is the story: nrf9160 in practice will work only with LFXO (high precision) but when starting it initially runs from LFRC because LFXO has 200ms startup time and LFRC has 600uS. Because of that assumption (LFXO is a must) LFRC has no calibration and 30% tolerance. This test runs before switching to LFXO and because of that results are so poor.
problem would be fix by #27398 (require clock stabilization) but it won't get in for 2.4 since it is not a bugfix unless we push (@carlescufi ?). Workaround is to add busy wait there.

The diff values per platform look precise (close to each other) but inaccurate

They will always be a bit inaccurate because busy wait runs from HF RC which has 8% accuracy. Additionally, even when LF XTAL is configured test may be executed before it is stabilized. Again this would be solved by #27398.


IE8/IE9 bug: hash history + Iframe = fail

http://benalman.com/code/projects/jquery-hashchange/examples/bug-webkit-hash-iframe/
That example page documents a Safari/Chrome/Webkit issue with hashchange in an iframe (which has since been fixed by chrome).
However, it makes no mention that the same bug exists in IE8/9.  Changing the hash inside an iframe in IE8/9 does not add to the browser history.
In this aspect, IE8/9 are actually worse handling hashchange than IE6/7.  With IE 6/7, the special approach in the hashchange plugin that uses another hidden iframe works, even when the content being tracked is in an iframe.  I tried changing the code to use that approach for IE8/9 as well, but it doesnt work because hitting the back button on a page with an iframe is not changing the iframe's hash value.  Thus, polling doesn't overcome this issue either.
I'm at a complete loss for working though this issue for my site.  Unfortunately I dont have the option of not running in an iframe - it is a facebook application, which runs on the FB site inside an iframe.
BTW, I did pick up this tidbit to confirm the functionality I am seeing: http://msdn.microsoft.com/en-us/library/cc288209(v=vs.85).aspx
"Windows Internet Explorer 8. The browser's Back and Forward buttons do not generate onhashchange events for frames or iframes; instead, the frame is refreshed each time."

The same here.
If you go back in an IE9 hashchanged frame, the URL you retrieve with Javascript (window.location) is still the same, from before the click on the Back button. But the URL in the properties for the frame has changed to what you would expect.
I've tried to find a solution by using (parts of) the hashchange code for IE6/7, with the iframe. But nothing even close to elegant.

I have the same issue with IE8. I'm trying to solve this problem, but no clues so far.

Hey hi!!!, any update on this issue?

Same issue.
IE11,version: 11.0.9600.16428.
hash history+frame.


Altair does not render 64 bit integers correctly

Describe the bug
Larger 64 bit integers get truncated in Altair.
To Reproduce
I think this should be reproducible with any GraphQL API that returns 64 bit integers (larger than a certain value) in extensions section.
Expected behavior
The integer should be rendered as returned by the API.
Screenshots

The number underlined in RED gets rendered as<PHONE_NUMBER>613809000. However, the API actually returns<PHONE_NUMBER>613809272.
Desktop (please complete the following information):

OS: Windows

Additional context
I think this behavior has something to do with the GraphQL spec that does not support 64 bit integers. But I think the current behavior is a little misleading as it silently truncates the numbers (even in extensions section of the response). Can we start support 64 bit integers in Altair?

https://www.npmjs.com/package/json-bigint

Thanks for reporting this! I'd look into it as soon as I can.


C Media：A question about aeron_driver_receiver_do_work？

In fuction aeron_driver_receiver_do_work ：
struct mmsghdr mmsghdr[AERON_DRIVER_RECEIVER_NUM_RECV_BUFFERS];
.......
int poll_result = aeron_udp_transport_poller_poll(
&receiver->poller,
mmsghdr,
AERON_DRIVER_RECEIVER_NUM_RECV_BUFFERS,
aeron_receive_channel_endpoint_dispatch,
receiver);
if (poll_result < 0)
{
    AERON_DRIVER_RECEIVER_ERROR(receiver, "receiver poller_poll: %s", aeron_errmsg());
}

for (int i = 0; i < poll_result; i++)
{
    bytes_received += mmsghdr[i].msg_len;
    work_count++;
}

//AERON_DRIVER_RECEIVER_NUM_RECV_BUFFERS = 2
Is there a possibility that poll_result  is greater than 2? Maybe something is wrong？

It shouldn't. Can you provide an example where it is?

I see what you mean. Yes, it might be possible if there is more than 1 transport and there is more than 1 packet waiting. Is that what you are seeing? Or was this just from inspection?

Went ahead and rewrote this in eca92b1b46b9863b5d16d6304b5df35bc881d022

I see what you mean. Yes, it might be possible if there is more than 1 transport and there is more than 1 packet waiting. Is that what you are seeing? Or was this just from inspection?

I added a line of logs and printed them out： aeron_driver_receiver_do_work poll_result=3, bytes_received=32. It shows that the array mmsghdr  is out of bounds.


Coolest Projects title on the forums navbar says '2015' instead of '2016'

See here: https://forums.coderdojo.com/
'COOLESTPROJECTS2015' in the navbar should be 'COOLESTPROJECTS2016'
cc @rosalanghammer

The JavaScript that is on www.coderdojo.com needs to be implemented on all other sites. It pulls the menu items from the wordpress install on www.coderdojo.com and makes it easy to manage them in one place.

Look like the "Global Menu" has been removed from all sites.

Close was accidental. Reopened

I think it would be ideal if a configuration by a non-technical person of the nav bar was to be implemented that it pull centrally from the Zen API instead of Wordpress.

Navbar is going to be redesigned to be global upon the whole websites ( Commercial/WP, Zen, Kata) I'm just going to quick fix this as the event is oncoming.


Remove "Online" from branding

Docs Build status updates of commit 158ec7a:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/OfficeDev/office-js-docs-pr, working directory: W:\1emz-s, target branch: HEAD, target branch commit: 91434193bd26cbfb9f823ae643926f86af4b9c05, source commit: 158ec7a36c6e10b3fc3865a62ff963aa393d7ee5.

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Due to conflicts, I'm going to close this PR, reclone the repo and start over!


feat(pipeline): support addons resources for pipeline

fix #650

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Looks rad!
Our build execution role has permissions to put to s3?

Yes we have!


add apptype support in usercreate contract

Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Add support for appType in userCreate contract, to differentiate which app sent the invite request

Contribution checklist:

[x] I have reviewed the documentation for the workflow.
[x] Validation tools were run on swagger spec(s) and have all been fixed in this PR.
[ ] The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

[x] Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

[ ] If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

@NullMDR , can you pls have a look at the SDK automation failures which is about package resolve error.

Can one of the admins verify this patch?

/azp run automation - sdk

/azp run automation - sdk

@ryansbenson we reverted the change for the query parameter. We will do it with the next api-version update. Can you review again?

@sanjaiganesh can you take a look at this PR? We have incorporated the changed arm requested.

@raych1 can you take a look at this PR? It is almost ready to merge


Fix small memory leak in PackedSourcePCK::try_open_pack

Leak info
Direct leak of 56 byte(s) in 1 object(s) allocated from:
    #0 0x7f99f2814448 in malloc (/lib/x86_64-linux-gnu/libasan.so.5+0x10c448)
    #1 0xf7fee58 in Memory::alloc_static(unsigned long, bool) core/os/memory.cpp:85
    #2 0xf7fee58 in operator new(unsigned long, char const*) core/os/memory.cpp:42
    #3 0xfdc5515 in PackedSourcePCK::try_open_pack(String const&, bool) core/io/file_access_pack.cpp:139
    #4 0xfd94122 in PackedData::add_pack(String const&, bool) core/io/file_access_pack.cpp:43

Thanks!


update URL in banner

change from: https://zenorocha.github.io/clipboard.js to https://clipboardjs.com/

THanks @coliff!


MGFF11.SA don't return right quote

Hi,  I am trying to get data from MGFF11.SA ticker and I receive the following return:
Appreciate if you can help.
Thanks!
Traceback (most recent call last):
  File "ya.py", line 6, in <module>
    print(msft.info)
  File "C:\Users\Sobreie\Downloads\WPy64-3830\python-3.8.3.amd64\lib\site-packages\yfinance\ticker.py", line 138, in info
    return self.get_info()
  File "C:\Users\Sobreie\Downloads\WPy64-3830\python-3.8.3.amd64\lib\site-packages\yfinance\base.py", line 415, in get_info
    self._get_fundamentals(proxy)
  File "C:\Users\Sobreie\Downloads\WPy64-3830\python-3.8.3.amd64\lib\site-packages\yfinance\base.py", line 286, in _get_fundamentals
    self._institutional_holders = holders[1]
IndexError: list index out of range

Hey there, try applying the fixes described in PR #179.
Just be aware that that fix returns inconsistent data for non-US tickers.


Could not load the "package.json". Make sure the workspace is valid.

Problem
The extensions is not able to load the workspace. In src/extension.ts on line 23, workspace.uri.path returns the path prefixed with '/'.
VS Code Error
Could not load the "package.json". Make sure the workspace is valid.
Potential Fix
In src/extension.ts on line 23, replace workspace.uri.path with workspace.uri.fsPath.
Platform
Version: 1.46.1 (user setup)
Commit: cd9ea6488829f560dc949a8b2fb789f3cdc05f5d
Date: 2020-06-17T21:13:20.174Z
Electron: 7.3.1
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Windows_NT x64 10.0.17763

Thanks for digging into this early release - and also providing a fix for the issue!
Much appreciated :beers:

Landed in develop.


How to take a photo using CustomRendererView sample?

Hi! I'm follow CustomRendererView sample in my app. Now I can see camera preview, How to take a photo using this sample? (Take a picture from camera preview programmatically)
Note: I DO NOT use MediaPlugin because it will open a camera UI, it break my app design concept!

Chi tiết tài liệu
⚠ Không chỉnh sửa phần này. Điều này là bắt buộc cho docs.microsoft.com ➟ Vấn đề khi liên kết GitHub.

ID: e3b172d5-2dc1-88e7-ca23-96e87ae24a42
Version Independent ID: 1ca93300-738f-4af7-b47c-0e170b7205a4
Content: Implementing a View - Xamarin
Content Source: docs/xamarin-forms/app-fundamentals/custom-renderer/view.md
Service: unspecified
GitHub Login: @davidbritch
Microsoft Alias: dabritch

Hi @nguyenthanhliemfc - the purpose of this doc is merely to demonstrate the concepts for creating custom renderers. We cannot offer specific answers or support via this site.
You might find the source code for the MediaPlugin useful: https://github.com/jamesmontemagno/MediaPlugin/blob/master/src/Media.Plugin.iOS/MediaImplementation.cs#L107
You can also visit https://www.visualstudio.com/vs/support/ for available support options.


build: upgrade to webpack 4

See https://github.com/Semantic-Org/Semantic-UI-React/pull/2596#pullrequestreview-100998473. As mentioned in the review karma-webpack-with-fast-source-map will cause problems because it only supports webpack 3

I am going to go ahead and close this for housekeeping. There are still far too many dependencies out there that are still not ready to support Webpack 4. We can address this again at a later date when the overall webpack community has reached stable adoption. create-react-app is still only using Webpack 3 as well.


doc: add runtime reconfiguration design doc

Fix https://github.com/coreos/etcd/issues/3014

LGTM. defer to @robszumski

Don't we need to link to this new doc from the runtime reconfig doc?

Don't we need to link to this new doc from the runtime reconfig doc?

We do link it from runtime reconfig doc. See the first changed file in the commits.

LGTM


Upgrade nix to 0.7.0 and libc to 0.2.16

This fixes mio on FreeBSD (#456)

Thanks for the PR! Merged as https://github.com/carllerche/mio/commit/da1f4065f904198b2856715677a47a175e99e4cb


Better docs on webhooks

Not sure the proper way to go about this and I can't find any docs or examples that seem relevant.  Specifically, I need to add some functionality to invoice.payment_succeeded and invoice.payment_failed.  Not sure if I need to override the webhook methods or catch signals for those events or what..

@paltman  ^

@jhanda1 yes, we should add documentation for this under webhooks section of the docs (#217).
In short, you'll want to set up a receiver for the invoice.payment_succeeded event.  I haven't tested the code but it would be something like:
from django.dispatch import receiver

from pinax.stripe.signals import WEBHOOK_SIGNALS

@receiver(WEBHOOK_SIGNALS["invoice.payment_succeeded"])
def handle_payment_succeeded(sender, event, **kwargs):
    pass  # do what it is you want to do here

the event object is a models.Event instance with all the data necessary to do what you want to do.


Bump lxml, fix bug, add unit test

Fixes ibm was where incorrect tags and duplicate values were being submitted on multinode clusters.
The issue was around the usage of xpath:
https://www.bennadel.com/blog/2142-using-and-expressions-in-xpath-xml-search-directives-in-coldfusion.htm

So, given some sub-node, "x", the XPath:
//y
... will still find any node, "y", located anywhere within the XML tree. But, the XPath:
.//y
... will find any node, "y", that is a descendant of the node "x." In other words, preceding the "//" expression with a "." tells the XML search engine to execute the search relative to the current node reference.

The test case that was missing and causing the issue is when there are multiple nodes in the cluster. The lib bump is not really necessary but probably does not hurt.

Oh you need to run ddev dep as you updated a requirement.


Refactoring/bookmarks

Just putting this out here for now so people can take a look. I know the other PR would probably also be changed if this gets pulled in first, or this will need to be changed if the other one gets pulled in first. I'll fix the changes if that happens.
I created a new bookmark class which keeps track of a (begin, end) tuple which acts as an inclusive interval. All comparisons between bookmarks will only compare their intervals (since this would be useful when using bisect. Note that this means that two bookmarks with different data but equal ranges will be 'equal' to each other).

How would I best rewrite https://github.com/google/ci_edit/pull/147/commits/c1231fd201b97d16247cd3edb36ed44326170225 on top of this?

I think for your code, your upperLimit would just have to become a Bookmark with whatever value its supposed to bisect at.
All references to some bookmark[0] should be changed to bookmark.range
bookmark[1] -> bookmark.data
bookmark[0][0] -> bookmark.begin
bookmark[0][1] -> bookmark.end
range is also just a tuple so you can do
begin, end = bookmark.range

Yeah, it's just that the other PR doesn't work with this behavior.
More specifically, if begin < upper < end, it's skipping the bookmark.

Though you should wait until this is PR is accepted first before updating your PR.

I just tested the code on your branch and it seems to be working fine with this PR. I only did it quite quickly as I'm not completely sure of how the bookmarkMove function actually works, but it seemed to retain the same functionality.
You can take a look at it and play around with it here: https://github.com/aaxu/ci_edit/tree/androbin/bookmark
Although I think I may have found a 'bug' with your branch, which I'll post a follow up on your PR.

Yeah, it works with the code from c1231fd201b97d16247cd3edb36ed44326170225.
It has the bug described above using bisect.bisect_left(self.bookmarks, Bookmark(upper, upper)).

Oh I see what you mean. In that case, we could do something like this maybe?
begin = bisect.bisect_left(self.bookmarks, Bookmark(upper, upper)) - 1
# Check if self.bookmarks[begin] 'shows up on screen', ie: self.bookmark[begin].end >= self.view.scrollRow.
# If so, move this bookmark, else skip.

Hmm, you mean because we won't encounter overlapping bookmarks?
If so, we'd still have to begin = max(... - 1, 0), right?

Yes, dealing with intervals that don't overlap makes things much easier, so I think the implementation above would work, with the begin = max(... - 1, 0).

Shouldn't the Bookmark.data keys be fields?

I'm not too sure what you mean. It's just a dictionary, which you can set to store any information you want. It's not necessarily any field intrinsic to the Bookmark object itself, if that answers your question.

Let me put it this way: Does this dictionary have a well known set of keys?
Note: I am specifically asking because of the "old positions" thing.
They should be about as "intrinsic" as begin and end.

I'm not sure. I needed the begin and end fields in order to implement the comparison functionality, and it was the minimum that I needed. I don't know if we want to hardcode the other fields into this bookmark object. We essentially do this all in the dataToBookmark function, so I don't see a reason to hardcode it in to the class itself. This would also let us give us one less point to maintain, in case we decide to add more data to the dictionary. What do you think?

Hmm, since the data in question is both declared and used/changed in actions.py, I think we are fine.
Otherwise it would have been nice to have that function inside the Bookmark class.

Branch should be up to date now. I fixed the bookmark tests to use the new bookmark object. Passing tests are still passing.

I see that float('inf') could be useful. But I ain't quite sure how.
Would rather not have any part of the code have to deal with potential infinities.

That is for the case if we have a bookmark (x, y) and our needle begins at x, then the only way to guarantee that bisect_right goes past (x, y) is if our needle ends after y. This is just so that we don't have to check if there is a bookmark after where our needle ended and don't have to check if that bookmark should be included or not.
I don't think the infinity here poses any issues since it is never saved as a state and used only for the needle, but I'm willing to change it to the extra check implementation if you're still opposed to it.

We are currently only doing comparison, no arithmetic.
As long as don't need length = end - begin, we should be fine.

Okay I've actually just removed the inf. It turns out there's no need for extra case checks.

Bookmarks will now automatically cast range values to integers (in case we do arithmetic and end up passing a floating point number in)

What is left to do for this PR?

Just waiting for it to undergo review