fix gradio vl stop words

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily receiving feedbacks. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
Please describe the motivation of this PR and the goal you want to achieve through this PR.
Modification
Please briefly describe what modification is made in this PR.
BC-breaking (Optional)
Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist

Pre-commit or other linting tools are used to fix the potential lint issues.
The modification is covered by complete unit tests. If not, please add more unit tests to ensure the correctness.
If the modification has a dependency on downstream projects of a newer version, this PR should be tested with all supported versions of downstream projects.
The documentation has been modified accordingly, like docstring or example tutorials.

Does it influence triton server and its gradio demo?

We are going to deprecate TIS with the turbomind backend. We can skip the TIS part integration in gradio


requirements.txt file is missing

there is  no requirements.txt file in the project

Thanks for pointing out. Requirements file has now been added with updated instructions


Improve Group2GroupCache computation

References

Possible fix for #8197

Description
Changes the way the Group2GroupCache table is computed to improve its performance.
Instructions for Reviewers
Previous implementation
The Group2GroupCache table is computed by the GroupServiceImpl::rethinkGroupCache method.
In the older version the table is deleted and computed from scratch every time a group operation (adding/removing a group or subgroup) is performed.
The previous rethinkGroupCache implementation follows these basic steps:

reads from the DB a Map<UUID, Set<UUID>>, mapping the parent group UUID to a set of its immediate child groups UUIDs
updates the sets of children, adding all children's children recursively
deletes the current `Group2GroupCache table
iterates over each map entry to store in the new cache table:

first, gets the Group entity from the parent and child UUIDs
checks if this (parent, child) pair already exists in the table
then, creates the new row

Running a Intellij IDEA profiler, it turned out that most of the time was spent on these last three steps, specially i and ii.
i. This is necessary because we get only UUIDs from the GroupDAO, and to create the Group2GroupCache entity we need to pass the related Group entities.
ii. This operation seems unnecessary. Since the data is stored in a Map<UUID, Set<UUID>>, where the key is the parent, there will never be a duplicated (parent, child) pair.
iii. Becomes costly because the entire table is deleted and rewritten
PR changes
The changes made to address those points above are:

Adds a unique constraint to the Group2GroupCache to assert the data integrity
In Group2GroupCacheDAO:

Adds a method to get the entire table as a Set<Pair<UUID, UUID>>
Adds a method to delete a single row, given parent and child UUIDs
Adds a method to create a new row, given parent and child UUIDs

In GroupServiceImpl::rethinkGroupCache

Reads the current Group2GroupCache table and stores it in a Set
Creates the updated cache table in another Set, only in memory
Computes the set differences and find which rows to delete and to add
Executes the individual create/delete operations using the Group2GroupCacheDAO

@vitorsilverio also contributed to this PR.
Testing
An easy way to test is to log in as an admin on the front-end, go to any collection, Edit Collection > Assign roles tab > open some group, like Submitters, Add Subgroup, search and add any subgroup or delete a current one.
Note that you will need to have a fair amount of groups in the DSpace instance, so the operation is slow in the previous implementation.
In our tests we had around 5k groups, which generated a 13k rows cache table.
In the previous version any group/subgroup operation took about 90s, and in this PR between 1s to 3s.
Checklist

[x] My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
[x] My PR is small in size (e.g. less than 1,000 lines of code, not including comments & integration tests). Exceptions may be made if previously agreed upon.
[x] My PR passes Checkstyle validation based on the Code Style Guide.
[x] My PR includes Javadoc for all new (or modified) public methods and classes. It also includes Javadoc for large or complex private methods.
[ ] My PR passes all tests and includes new/updated Unit or Integration Tests based on the Code Testing Guide.
[x] My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
[ ] If my PR includes new libraries/dependencies (in any pom.xml), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
[ ] If my PR modifies REST API endpoints, I've opened a separate REST Contract PR related to this change.
[ ] If my PR includes new configurations, I've provided basic technical documentation in the PR itself.
[x] If my PR fixes an issue ticket, I've linked them together.

Do we need a database migration to (a) account for the additional constraint, and (b) deal with possible existing violations of the new constraint in the data?

Would it be beneficial to add a unique index on (parent_id, child_id) in the database to optimize the performance of this DELETE query:
delete from group2groupcache g WHERE g.parent_id = :parent AND g.child_id = :child

New index:  that is essentially what the new constraint does.

@mwoodiupui , I'm not sure if Hibernate / JPA forces Postgres to automatically add a unique index when this annotation is used:
@Table(name = "group2groupcache", uniqueConstraints = { @UniqueConstraint(columnNames = {"parent_id", "child_id"}) })

https://www.baeldung.com/jpa-unique-constraints#2-defining-unique-constraints
suggests that it does.  Enforcement of the constraint would be rather inefficient without such an index.
Creating the constraint in a migration would remove all doubt.

Since spring.jpa.hibernate.ddl-auto is not set in the DS code base (which is appropriate for production environments), it’s possible that Spring JPA/Hibernate does not modify the current database schema. In this case, we may need to explicitly instruct Flyway to add the index constraint.

Do we need a database migration to (a) account for the additional constraint, and (b) deal with possible existing violations of the new constraint in the data?

It seems that the current implementation does a test in rethinkGroupCache to avoid duplicates every time the cache table is recreated:
https://github.com/DSpace/DSpace/blob/1b16a55335101ddec7776c020bee30ff1ac17d36/dspace-api/src/main/java/org/dspace/eperson/GroupServiceImpl.java#L683
https://github.com/DSpace/DSpace/blob/1b16a55335101ddec7776c020bee30ff1ac17d36/dspace-api/src/main/java/org/dspace/eperson/GroupServiceImpl.java#L730-L736

@autavares-dev , @tdonohue: I recommend adding a unique constraint at the database level (using a Flyway script). This will not only enforce data integrity but also create a combined index, which will significantly improve the performance of all database queries that involve both parent_id and child_id.

Does it make sense to create a PK constraint instead? Since child_id and parent_id will never be null.
There is also the methods (not changed by this PR) findByParent and findByChildren in the DAO. Creating individual indexes for each column might also be a good idea.

I'm a bit concerned about letting our migrations get out-of-sync. with the actual schema design.

I feel we need to come to a quick consensus on this PR to move it forward quickly.  I don't want this fix to miss the 8.1 bug-fix release.
@autavares-dev : Can we just add a unique constraint on the database for now as @saschaszott requested?  Then we can get this merged quickly and move all other discussions to a later ticket or PR.

I was about to create the migration script, but went to check in the database and the indexes already exists (7.6.2):

@autavares-dev , the primary key constraint on parent_id, child_id was introduced in DSpace 6 through the migration script V6.0_2015.03.07__DS-2701_Hibernate_migration.sql:
ALTER TABLE Group2GroupCache add primary key (parent_id,child_id);

It seems there is a discrepancy between the actual database schema in DSpace and the corresponding JPA entity annotations. @tdonohue , would it make sense to create a new ticket to systematically identify and address such differences?

I've created a ticket to analyse the schema differences in more detail: https://github.com/DSpace/DSpace/issues/10108

@autavares-dev , just a design question: is it be possible to move the logic in rethinkGroupCache entirely to the database layer and perform the necessary updates in table group2groupcache using SQL? This would eliminate the need to load all the table data into main memory.

@saschaszott , I think that making a single query for INSERTS and another one for DELETES can be done without much difficulty.
However, in order to not load the entire table into memory, it would be necessary to create a single SQL query that does the same as the computeNewCache method, which calculates the flattened group hierarchy of the Group2Group table.

If we clean up the migration/annotation mismatch soon then I have no objections to deferring some or all of it now.

Doing the calculation in the DBMS sounds like (a) a good idea, (b) something that could be deferred to another improvement, and (c) possibly a case for a stored procedure if there is no relational way to express it.

@mwoodiupui, we can address the topic of moving "heavy" data manipulation processes to the database layer in a separate ticket. I can create a ticket.

As this is at +2 and we've spun other discussions off into separate tickets, I'm going to merge this as-is.  Thanks again @autavares-dev !
As necessary, any follow-up work can occur in future PRs.


Length of (0/0) equals 3 ("Nan")

Expected Behavior
Please describe what should happen
I've been experimenting with (0/0), which returns the value Nan (not suprising). Plugging in this "Nan" block into numerical inputs treats it as if it were zero. So far, so good.
Actual Behavior
Describe what actually happens
But, when plugging in the (0/0) block into string inputs, it treats it as if it were "Nan". Length of (0/0) is the same as Length of (Nan), which is three. I've also tried it with some other blocks with string inputs, with similar results (e.g. () contains (), say ())
I know this is not a huge bug, but I can imagine quite a few people being confused over this. I know Javascipt, and if someone could point me to where the code for the division block is, I'd be happy to add some basic code to replace "Nan" with 0.
Steps to Reproduce
Explain what someone needs to do in order to see what's described in Actual behavior above
Pretty self explanitory. Try these blocks:
length of((0/0))
say ((0/0))
(Nan) contains ((0/0))
Operating System and Browser
e.g. Mac OS 10.11.6 Safari 10.0
Win 10, chrome 64.
Though, I'd imagine this being a cross-browser bug. (I've tried firefox. It has similar results). #

Sorry, I just realized this issue really belongs in scratch/vm. I'll close this one and post it there.

@Clark-E - Note that this is the same behavior as in Scratch 2.0; may be worth considering that changing this could break compatibility. Also, 5 divided by 0 is not 0, but I don't want to argue about how the behavior of should be myself :P


An enemy doesn't die if killed from right

The bottom right enemy is not killed or despawned when kill from the right

See issue 604594498


Generates and labels Volume*SnapshotClass

Changes
Have storage claim controller own VolumeGroupSnapshotClass with the required labels for RDR added to both VGSC and VSC.
RHSTOR-5795

/cc @rewantsoni

/cc @Madhu-1

Content wise this PR doesn't depend on PR at ocs-operator end right?

See #2661

adding a soft LGTM and waiting for others to review

@raaizik can we split this in to Two PR's one for volumesnapshotclass and another one for volumegroupsnapshotclass? we can get the volumesnapshotclass PR merged and we can visit the volumegroupsnapshotclass PR once we have the feature in betav1 state.


Add Docusaurus site

Changes

Configured Docusaurus and added a few doc pages (installation, examples, contributing, changelog)
note: Used new naming (rescript-apollo-client)

Running the doc site locally
Installation
yarn install

Local Development
yarn start

Next Steps

Decide on how we want to setup Github page for the doc site. Instructions can be found here: https://docusaurus.io/docs/en/publishing#using-github-pages
Add CI to auto deploy?
Add some documentation on how to add/change documentation :P

Awesome! Thank you!! This is the last thing I wanted to get up before officially releasing and switching to rescript-apollo-client. I don't know much about docusaurus, but let's just merge this and start playing around and adding more content?

Scaffold is up here https://reasonml-community.github.io/reason-apollo-client/


Draw variants transcript and protein

@ielis @lnrekerle
This PR adds the drawing code as well as a test case for the VariantValidator response. The function, parse_response, line 157 of _vv.py, will also need to be changed -- to me it looks as if the code is expecting a different JSON structure from what we actually get -- I added the test case to understand the structure. Unless there is some other code that only passes part of the response, it is wrong
PLEASE ADD DOCUMENTATION TO ALL FUNCTIONS LIKE THIS! It would be a lot easier to contribute code if the main assumptions and goals of each function were documented --

The function, parse_response, line 157 of _vv.py, will also need to be changed -- to me it looks as if the code is expecting a different JSON structure from what we actually get -- I added the test case to understand the structure. Unless there is some other code that only passes part of the response, it is wrong PLEASE ADD DOCUMENTATION TO ALL FUNCTIONS LIKE THIS! It would be a lot easier to contribute code if the main assumptions and goals of each function were documented --

That function was originally written by @ielis, but I can take a look at it and see if I can recreate and fix the bug. I do think that this PR as it is is ready to be pushed.

I am going to merge this, and now the code seems to be working again. I am not changing _vv.py now but we may need to do so, but let's make that a separate PR


Addition of data type check to schema validation

Introduce data type checking for data tables, making sure that columns have the correct type.
Introduce at the same time clearer numpy data types (float32, float64), as we had issues in the past with getting this right.

@VictorBarbosaMartins - I've followed your suggestions, thanks for this.
Waiting for the tests and will then merge.

Thanks for considering my comments, I think we are good to go!


Community landing page doesn't show Community Name in Header

Here is the Community search page:

Here is one of the questions:

@lsabor this is expected. This behavior is intentional. The community name is hidden in the header by design when it is already displayed in the heading section. As you scroll down, it will reappear.
https://github.com/user-attachments/assets/a46bcd8e-f27d-42e7-a3fb-8cef1b676c7e

@SylvainChevalier @aseckin could you please check if we should actually fix this?

seems fine to me, closing.


Mongo config provider

should we have a factory that can initialize the config provider based on config?

@ankurjain86 Yep, will implement. I pushed another commit which documents and fixes config caching. Please check it out


Add sandboxing on Windows

Not exactly sure what this will look like yet, but Windows Sandbox looks promising.
I'm basically looking for:

Ability to run arbitrary programs inside the sandbox, read stdout/stderr, and know when they exit (and if it was successful)
Not messing up the system registry while providing packages
Ability to shut off network access
Shared folders (would be nice to have read-only mounts, but not as necessary)

I am porting Nix to Windows (upstream), btw, so I am curious what you will find.

Note that windows sandbox is a full Hyper-V VM, running its own full OS instance. You don't have a full virtual disk image, but this seems much heavier than you'd want.
I think you'd fare better starting from AppContainer. But I've never found very much about the actual low-level APIs or really dug deeply into this.(https://learn.microsoft.com/en-us/windows/win32/secauthz/appcontainer-for-legacy-applications- has some) - the main usage is things installed via MSIX, where the app packaging does the containerizing.

Nice, thanks for the pointers! I'll take a look. I am not super well-versed in low-level Windows stuff, so learning what's out there is helpful.

Linkdumping a few more things I found in the past:

https://scorpiosoftware.net/2019/01/15/fun-with-appcontainers/
https://github.com/zodiacon/RunAppContainer have some more more info
Maybe this can even summon @zodiacon to say whether I'm crazy

https://chromium.googlesource.com/chromium/src/+/HEAD/docs/design/sandbox.md and https://github.com/chromium/chromium/tree/main/sandbox/win are another reference -and this is built out of AppContainer - though not through the documented high-level API (CreateAppContainerProfile), but instead through undocumented lower-level pieces like CreateLowBoxObjectDirectory, NtCreateLowBoxToken (LowBox is an old name for AppContainer, combining the "Low" integrity level that you're restricted to with the "Box" aspect of having a separate namespace for most kernel objects.


New skip method

Fixes #245
Docs PR https://github.com/apollostack/react-docs/pull/70
TODO:

[x] If this PR is a new feature, reference an issue where a consensus about the design was reached (not necessary for small changes)
[x] Make sure all of the significant new logic is covered by tests
[x] Rebase your changes on master so that they can be merged easily
[x] Make sure all tests and linter rules pass
[x] Update CHANGELOG.md with your change
[x] If this was a change that affects the external API, update the docs and post a link to the PR in the discussion

Awesome!

The old API doesn't seem to work after this PR (in our case). Moreover, adding a deprecation warning would help us figure out we need to migrate. Maybe 0.5.8 should have been 0.6.0, too much feature changes at once: this broke our app.

@rricard what is broken? The old API is still covered in testing https://github.com/apollostack/react-apollo/blob/master/test/react-web/client/graphql/queries-1.test.tsx#L321-L345
We aren't even planning on removing it as it allows for a different kind of skipping

I saw the test, but it seem to change the skipping behavior all at once: for instance the old test doesn't cover the case where I have two queries at once mutally skipping themselves. What I see are cancellations of the non-skipped query because the other query has been skipped.

I'll try to write a test for that. All I'm asking is maybe, while adding new APIs or refactors, don't just increment the patch number. Increment the minor version number instead. That way npm won't get the patch version right away, potentially breaking the app

Have you tried with 0.5.9? 0.5.9 fixes a bunch of skip related bugs, some
of which may have been new with 0.5.8.
On Oct 12, 2016 5:08 AM, "Robin Ricard"<EMAIL_ADDRESS>wrote:

I'll try to write a test for that. All I'm asking is maybe, while adding
new APIs or refactors, don't just increment the patch number. Increment the
minor version number instead. That way npm won't get the patch version
right away, potentially breaking the app
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/apollostack/react-apollo/pull/253#issuecomment-253195863,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABBVK8NHNZBUdeEpuCj3sHfy8b5uQi0ks5qzM2ngaJpZM4KRZWk
.

We tried with 0.5.9. Bottom line is, with this kind of change: the safe path is to go with a new minor version...

@rricard yeah, I hear you. Maybe this is something we should do for Apollo Client as well.

Admittedly, the "patch" and "minor" fields mean something a little different with 0.* semvers, but this makes a lot of sense.
@rricard That said, we didn't intend to break anything about the original skip feature other than fixing some blatant bugs. Can you file an issue for what broke in your app?

@helfer already talked with @stubailo about that, I think client is figured out, current refactor will go to an another minor number and/or a prerelease cycle (we have to figure out how to do that with npm though :wink:!)
@glasser I know, I'm more trying to think about a threshold of refactor where we should start to think that something may break ... even if current tests won't catch it. What I'm saying is, that would just avoid the case where someone is tracking ^0.X.0 and a patch version would make fail a CI or a deployment, I think that increasing the minor where we're not quite completely sure would ensure we don't kill those. However, from now on and before the 1.0, I'll track exact patch versions.

Now, let's write some failing tests! 😉 ...and a fix! 🎉

See #271 for reproduction and bug tracking of the issue


feat: Include provided locations in cyclonedx sbom report utilizing evidence key.

The cycloneDX report needs to be enriched with the file location where the products are found. This should follow the cycloneDX format which utilizes Evidence field with Occurrences to show locations.

The locations of products would be provided in
https://github.com/intel/cve-bin-tool/blob/3f15be82b8cd87108642b2c2a9fa800b88e479be/cve_bin_tool/output_engine/__init__.py#L906
and the lib4sbom is expected to handle this and include locations in report

See commit


✏  Fix markdown in DateTime doc

Seel DateTime formats list at: https://typer.tiangolo.com/tutorial/parameter-types/datetime/

Closing as the older PR #220 contains the same fix, but thanks again!


Added issue with diabetes target class and deprecate issue with fetch_mldata

…_mldata

The pull request resolve above issue

Looks good to me.
Thank you for your pull request!


Rebased Mass Storage

#204. Rebased since I've caused conflicts for it at least twice. Also drops the eclipse stuff.

May Git have mercy on my soul!
Also thank you immensely for rebasing this- it was top of my list to look into.


CI: Verify OpenAPI definition files

What this PR changes/adds

Make OpenAPI output reproducible (sorted)
Update CI to fail if OpenAPI generated output doesn't match committed files. Outputs diff in build logs in case of errors

Why it does that
Repository contains OpenAPI YAML definitions generated from files. These must be manually updated and can go out of sync.
We want the OpenAPI definition along the code in git, so we can immediately pinpoint breaking changes in the API contract in PRs.
Further notes
Moved check job to same workflow as all other checks (verify.yaml) for consistency.
Need to post-process YAML to sort it to obtain a comparable diff. Created PR in plugin to solve this: https://github.com/kpramesh2212/openapi-merger-plugin/pull/11, when the plugin is updated, we can simplify the pipeline.
Sample failing job: https://github.com/agera-edc/DataSpaceConnector/runs/6443856078?check_suite_focus=true
Linked Issue(s)
Closes #1238
Checklist

[ ] added appropriate tests?
[ ] performed checkstyle check locally?
[ ] added/updated copyright headers?
[ ] documented public classes/methods?
[ ] added/updated relevant documentation?
[ ] added relevant details to the changelog? (skip with label no-changelog)
[ ] formatted title correctly? (take a look at the CONTRIBUTING and styleguide for details)

Codecov Report

Merging #1312 (031f554) into main (70271b5) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1312   +/-   ##
=======================================
  Coverage   67.51%   67.51%
=======================================
  Files         717      717
  Lines       15749    15749
  Branches     1051     1051
=======================================
  Hits        10633    10633
  Misses       4633     4633
  Partials      483      483

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70271b5...031f554. Read the comment docs.


feat: allow to get control value from MockControlValueAccessor

Hi @everkin, might you create an issue and describe the problem there first? There's no __value in the ControlValueAccessor and it's unclear why it should be implemented then.


Publishing to cloudrun with immutable mode?

I'm a bit confused about immutable mode and publishing to cloudrun. (I want to publish with immutable mode so that I can support database downloads.)
Running datasette publish cloudrun --extra-options="-i example.db" leads to an error:

Error: Invalid value for '-i' / '--immutable': Path 'example.db' does not exist.

However, running datasette publish cloudrun example.db not only works but seems to publish in immutable mode anyway! I'm seeing this both with /-/databases.json and the fact that downloads are working.
When I just datasette serve locally, this succeeds both ways and works as expected.

the only mode that publish cloudrun supports right now is immutable


Update Vue School summer banner

This PR updates the banner introduced by https://github.com/vuejs/pinia/pull/1407
The banner at the top of https://pinia.vuejs.org/ informs users about Vue School’s Summer Sale promotion.
The banner is closable and opens Vue School's Summer Sale promo page in a new tab. The banner will not reappear if a user has closed it (stored in localStorage).
Please note that this banner includes a countdown. The component uses @chenfengyuan/vue-countdown.
Click here to see screenshots of the banner

Codecov Report

Merging #1457 (22f2fc1) into v2 (b638245) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##               v2    #1457   +/-   ##
=======================================
  Coverage   97.59%   97.59%
=======================================
  Files           9        9
  Lines         416      416
  Branches      109      109
=======================================
  Hits          406      406
  Misses          5        5
  Partials        5        5

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b638245...22f2fc1. Read the comment docs.


Bot doesn't accept accounts

A few users and I have tried adding our accounts via the Add Accounts page on Orianna Bot. Unfortunately it isn't quite working after having waited a period of time.

Resolved in d17d7ce.


Suggestion: setenv(cmd; dir=target) instead of cd(target) do

This is a more general suggestion and I do remember that CmdStan.jl is (or soon will be?) deprecated, but I'm putting it here because I'm most likely to make a PR related to it here after your feedback.
It is safer to use run(setenv(cmd, ENV; dir=target)) than cd(target) do run(cmd) because cd() changes the caller's working directory (for all threads in a multithreaded situation) while setenv(cmd, environment; dir=path) only changes the working directory of the running command.
This is something of a continuation of the push towards absolute paths to make Stan safely usable in a parallel manner. Currently I use within-chain parallelization, which works pretty well, but fitting 4 models serially with 4 chains and 4 CPUs per chain is less CPU efficient (and slower) than fitting 4 models in parallel with 4 chains and 1 CPU per chain.
Here is a demo:
mkdir -p test
echo '#/!/bin/bash' > test/athing.sh
echo 'sleep 2' >> test/athing.sh
echo 'ls' >> test/athing.sh
chmod +x test/athing.sh

pwd

JULIA_NUM_THREADS=2 julia
# below is in the Julia REPL and should be run all at once
pwd()
@async run(setenv(`./athing.sh`, ENV; dir="test"))
pwd()
# Now it should print out the contents of the test directory we just made

Do you want me to switch the various cd + run commands to use this?

Hi @Byrth,
Thank you for looking into this and yes if you can update the examples using the cd + run approach, that would be great.
Best,
Rob

Thanks a lot @Byrth. Will merge as v 6.2.0!

No problem, thanks for the quick merge!

Thank you!
About 2 months after cmdstan v2.27.0 is released I'll try to set some time aside to update the Stan Language used in the examples, e.g. from the release notes:
 As opposed to the previously used syntax for arrays:

real a[5];
matrix[3,3] b[5];
vector[3] c[5];

we recommend switching to the new equivalent array syntax:

array[5] real a;
array[5] matrix[3,3] b;
array[5] vector[3] c;

At the same time I can update the examples to using setenv().

Hrm. I guess I missed what the examples were.
Sorry about that. It is nice to see the updated array[size] syntax, though. I did not know that change had been made.

I meant e.g. the bernoulli.jl example in CmdStan.jl:
######### CmdStan program example  ###########

using CmdStan

ProjDir = @__DIR__
cd(ProjDir) do

  bernoullimodel = "
  data {
    int<lower=1> N;
    int<lower=0,upper=1> y[N];
  }
  parameters {
    real<lower=0,upper=1> theta;
  }
  model {
    theta ~ beta(1,1);
    y ~ bernoulli(theta);
  }
  ";

  observeddata = Dict("N" => 10, "y" => [0, 1, 0, 1, 0, 0, 0, 0, 0, 1])

  # Preserve these variables outside cd/do block.
  global stanmodel, rc, samples, cnames, df

  stanmodel = Stanmodel(name="bernoulli", model=bernoullimodel,
    printsummary=false);

  rc, samples, cnames = stan(stanmodel, observeddata, ProjDir, CmdStanDir=CMDSTAN_HOME);

  if rc == 0
    # Fetch cmdstan summary as a DataFrame
    df = read_summary(stanmodel)

    df |> display
    println()

    df[df.parameters .== :theta, [:mean, :ess, :r_hat]] |> display
  end

end # cd block

But I guess that is still ok.

yes, I believe that they now no longer need the cd() block, but it also doesn't hurt because it controls where the tmp directory gets made.


Permission denied: 'C:\agent-01\_work\_temp\.azclitask\msal_token_cache.bin.lockfile'

From Azure DevOps we use an Azure CLI task to execute a powershell script in which an access token is fetched using az account get-access-token. The access token is then used to make a call to our own API.
This works ok most of the times, but every now and then we get the following exception: Permission denied: 'C:\agent-01\_work\_temp\.azclitask\msal_token_cache.bin.lockfile'**.
The following powershell script is used inside the Azure CLI task:

$audience = 'xxx'
$url = 'xxx'
$accessToken = & az account get-access-token --resource=$audience --query accessToken
$accessToken = $accessToken.Trim('"')
$headers = @{
"Content-Type"="application/json"
Authorization="Bearer $accessToken"
}
Invoke-WebRequest -Uri $url -Method Post -Headers $headers -UseBasicParsing
See the following entire log (removed some sensitive lines):
2021-12-19T19:07:38.6202884Z ==============================================================================
2021-12-19T19:07:38.6203151Z Task         : Azure CLI
2021-12-19T19:07:38.6203551Z Description  : Run Azure CLI commands against an Azure subscription in a PowerShell Core/Shell script when running on Linux agent or PowerShell/PowerShell Core/Batch script when running on Windows agent.
2021-12-19T19:07:38.6203938Z Version      : 2.1.2
2021-12-19T19:07:38.6204170Z Author       : Microsoft Corporation
2021-12-19T19:07:38.6204451Z Help         : https://docs.microsoft.com/azure/devops/pipelines/tasks/deploy/azure-cli
2021-12-19T19:07:38.6204769Z ==============================================================================
2021-12-19T19:07:39.5811018Z [command]C:\Windows\system32\cmd.exe /D /S /C ""C:\Program Files (x86)\Microsoft SDKs\Azure\CLI2\wbin\az.cmd" --version"
2021-12-19T19:07:43.7227332Z WARNING: You have 2 updates available. Consider updating your CLI installation with 'az upgrade'
2021-12-19T19:07:43.7227729Z
2021-12-19T19:07:43.7228002Z Please let us know how we are doing: https://aka.ms/azureclihats
2021-12-19T19:07:43.7229107Z and let us know if you're interested in trying out our newest features: https://aka.ms/CLIUXstudy
2021-12-19T19:07:43.7229662Z azure-cli                         2.30.0 *
2021-12-19T19:07:43.7229816Z
2021-12-19T19:07:43.7230093Z core                              2.30.0 *
2021-12-19T19:07:43.7230343Z telemetry                          1.0.6
2021-12-19T19:07:43.7230483Z
2021-12-19T19:07:43.7230733Z Python location 'C:\Program Files (x86)\Microsoft SDKs\Azure\CLI2\python.exe'
2021-12-19T19:07:43.7231215Z Extensions directory 'C:\Users\WEB_DEP_LSV.azure\cliextensions'
2021-12-19T19:07:43.7231403Z
2021-12-19T19:07:43.7231718Z Python (Windows) 3.8.9 (tags/v3.8.9:a743f81, Apr  6 2021, 13:22:56) [MSC v.1928 32 bit (Intel)]
2021-12-19T19:07:43.7231927Z
2021-12-19T19:07:43.7232163Z Legal docs and information: aka.ms/AzureCliLegal
2021-12-19T19:07:43.7232320Z
2021-12-19T19:07:43.7232392Z
2021-12-19T19:07:43.7388607Z Setting AZURE_CONFIG_DIR env variable to: C:\agent-01_work_temp.azclitask
2021-12-19T19:07:43.7393705Z Setting active cloud to: AzureCloud
2021-12-19T19:07:43.7401670Z [command]C:\Windows\system32\cmd.exe /D /S /C ""C:\Program Files (x86)\Microsoft SDKs\Azure\CLI2\wbin\az.cmd" cloud set -n AzureCloud"
2021-12-19T19:07:53.1060535Z [command]C:\Windows\system32\cmd.exe /D /S /C ""C:\Program Files (x86)\Microsoft SDKs\Azure\CLI2\wbin\az.cmd" login --service-principal -u *** "--password=***" --tenant *** --allow-no-subscriptions"
2021-12-19T19:07:55.9559946Z [command]C:\Windows\system32\cmd.exe /D /S /C ""C:\Program Files (x86)\Microsoft SDKs\Azure\CLI2\wbin\az.cmd" account set --subscription 62d3d9f9-d154-4e4e-abdc-975b9394edfb"
2021-12-19T19:07:56.3152597Z [command]C:\Windows\System32\WindowsPowerShell\v1.0\powershell.exe -NoLogo -NoProfile -NonInteractive -ExecutionPolicy Unrestricted -Command ". 'C:\agent-01_work_temp\azureclitaskscript1639940859512.ps1'"
2021-12-19T19:07:57.5298709Z ERROR: The command failed with an unexpected error. Here is the traceback:
2021-12-19T19:07:57.5300700Z ERROR: [Errno 13] Permission denied: 'C:\agent-01\_work\_temp\.azclitask\msal_token_cache.bin.lockfile'
2021-12-19T19:07:57.5301111Z Traceback (most recent call last):
2021-12-19T19:07:57.5301490Z   File "D:\a\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\knack/cli.py", line 231, in invoke
2021-12-19T19:07:57.5301963Z   File "D:\a\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/core/commands/init.py", line 657, in execute
2021-12-19T19:07:57.5302496Z   File "D:\a\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/core/commands/init.py", line 720, in _run_jobs_serially
2021-12-19T19:07:57.5303003Z   File "D:\a\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/core/commands/init.py", line 691, in _run_job
2021-12-19T19:07:57.5303495Z   File "D:\a\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/core/commands/init.py", line 328, in call
2021-12-19T19:07:57.5303985Z   File "D:\a\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/core/commands/command_operation.py", line 121, in handler
2021-12-19T19:07:57.5304546Z   File "D:\a\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/command_modules/profile/custom.py", line 74, in get_access_token
2021-12-19T19:07:57.5305045Z   File "D:\a\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/core/_profile.py", line 382, in get_raw_token
2021-12-19T19:07:57.5305589Z   File "D:\a\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/core/auth/msal_authentication.py", line 128, in get_token
2021-12-19T19:07:57.5306082Z   File "D:\a\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\msal/application.py", line 1589, in acquire_token_for_client
2021-12-19T19:07:57.5306777Z   File "D:\a\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\msal/oauth2cli/oauth2.py", line 735, in obtain_token_for_client
2021-12-19T19:07:57.5307256Z   File "D:\a\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\msal/oauth2cli/oidc.py", line 115, in _obtain_token
2021-12-19T19:07:57.5307724Z   File "D:\a\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\msal/oauth2cli/oauth2.py", line 771, in _obtain_token
2021-12-19T19:07:57.5308166Z   File "D:\a\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\msal/application.py", line 523, in
2021-12-19T19:07:57.5309052Z   File "D:\a\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\msal/token_cache.py", line 307, in add
2021-12-19T19:07:57.5309483Z   File "D:\a\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\msal/token_cache.py", line 113, in add
2021-12-19T19:07:57.5309921Z   File "D:\a\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\msal/token_cache.py", line 237, in __add
2021-12-19T19:07:57.5310366Z   File "D:\a\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\msal_extensions/token_cache.py", line 43, in modify
2021-12-19T19:07:57.5310834Z   File "D:\a\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\msal_extensions/cache_lock.py", line 29, in enter
2021-12-19T19:07:57.5311296Z   File "D:\a\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\portalocker/utils.py", line 199, in enter
2021-12-19T19:07:57.5311748Z   File "D:\a\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\portalocker/utils.py", line 128, in acquire
2021-12-19T19:07:57.5312206Z   File "D:\a\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\portalocker/utils.py", line 175, in _get_fh
2021-12-19T19:07:57.5312685Z PermissionError: [Errno 13] Permission denied: 'C:\agent-01\_work\_temp\.azclitask\msal_token_cache.bin.lockfile'
2021-12-19T19:07:57.5531954Z To open an issue, please run: 'az feedback'
2021-12-19T19:07:57.7120197Z You cannot call a method on a null-valued expression.
2021-12-19T19:07:57.7120881Z At C:\agent-01_work_temp\azureclitaskscript1639940859503_inlinescript.ps1:8
2021-12-19T19:07:57.7121199Z char:1
2021-12-19T19:07:57.7121408Z + $accessToken = $accessToken.Trim('"')
2021-12-19T19:07:57.7121671Z + ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2021-12-19T19:07:57.7121996Z     + CategoryInfo          : InvalidOperation: (:) [], ParentContainsErrorRec
2021-12-19T19:07:57.7122274Z    ordException
2021-12-19T19:07:57.7122523Z     + FullyQualifiedErrorId : InvokeMethodOnNull
2021-12-19T19:07:57.7122756Z
2021-12-19T19:07:57.7366960Z ##[error]Script failed with exit code: 1
2021-12-19T19:07:57.7377966Z [command]C:\Windows\system32\cmd.exe /D /S /C ""C:\Program Files (x86)\Microsoft SDKs\Azure\CLI2\wbin\az.cmd" account clear"
2021-12-19T19:07:58.2877316Z ##[section]Finishing: trigger deployment endpoint

@jiasli for awareness

Duplicate of #20273


Added CoreServices as a dependency for mariadb.

MariaDB should finally work on pure darwin :)

cc @pikajude

Commit 5d4595621d28ebcb6106b300488ac0f8b7a09a9d fixes this.


Implement Database.command, at least the ping command

My application health check is sending a ping command but I noticed command method is not implemented in Database, leading to command being interpreted as a Collection.
Maybe we could foresee a first implementation only handling 'ping' command and returning {'ok': 1.0} ?

Hi @Colin-b, thanks for reporting. We should at least implement a placeholder that raises a NotImplementedError and once we have that, it would be trivial to implement the ping command.
I'll keep this one as a bug until we get the NotImplementedError.

@Colin-b please review #471.

Thanks a lot for the quick fix! Should I let you close this issue once merged?

GitHub will do it automatically because of the string "Fixes #469" in the commit message.


Also, clean up pre-commit hook.

Any ideas on how to avoid the code duplication? Includes won't work since these files will be symlinked. Although from the Makefile invocation it seems that $PWD is the root directory of the repo? Or are we just assuming that git commands are run from there? Hmm...

It looks like the hooks will always run in the root of the repo. So maybe we could just assume relative paths resolve from there?
We could also try to source other scripts in the repo relative to a readlink or realpath on the $BASH_SOURCE? The main annoying thing about doing that is that those commands work differently on Mac and Linux.

Agh, another constraint I forgot about is that these files are also symlinked to from the kbfs repo -- so if we include stuff from these files, that won't work anymore. :/
So I think duplicating the code here is the least bad thing to do, at least for now.

The kbfs repo links to hooks that are defined in client? :|

The KBFS repo doesn't have any links, but the current practice is to just use client's hooks:
lrwxr-xr-x   1 akalin  staff    67 May 29  2015 pre-push -> /Users/akalin/go/src/github.com/keybase/client/git-hooks/pre-commit

:+1:

Per our discussion, added comments re. factoring out common code in the future, but pushing as-is for now.


REL: Bump version to beta-18

Thanks you! BTW - will you have any notes for the changelog?

Yes, for sure!
On (Nov-06-18|14:47), Matthew Dillon wrote:

Thanks you! BTW - will you have any notes for the changelog?
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
https://github.com/qiime2/q2-emperor/pull/69#issuecomment-436437569


dllReferencePlugin Invalid Options

Bug report

What is the current behavior?
I got the following error using dllReferencePlugin

If the current behavior is a bug, please provide the steps to reproduce.
I  got a project by  create-react-app,but i didn't use eject, and instead of react-app-rewired and customize-cra to override configuration
reproduce stpes:
1、I generate a dll configuration first。
2、yarn start

const dependencies = require('../package.json').dependencies;
const { resolveApp } = require('./webpackFactory');
const webpack = require('webpack');
const { CleanWebpackPlugin } = require('clean-webpack-plugin');
const chalk = require('chalk');
const pullAll = require('lodash/fp/pullAll');
const { dllDir, dllManifest } = require(resolveApp('webpack/utils/paths'));
const dllConfig = {
  entry: {
    vendor: pullAll(['webpack', 'webpack-cli', 'react-scripts', 'normalize.css.less', 'germa-mobile'])(Object.keys(dependencies)),
  },
  resolve: {
    alias: {
      irComponents: resolveApp('node_modules/germa-mobile/lib')
    },
    extensions: ['.js', '.less', '.json', 'jsx']
  },
  output: {
    path: dllDir,
    filename: '[name]_[hash:8].js',
    library: '[name]_[hash:8]'
  },
  plugins: [
    new CleanWebpackPlugin({
      cleanOnceBeforeBuildPatterns: [dllDir]
    }),
    new webpack.DllPlugin({
      context: dllDir,
      path: dllManifest,
      name: '[name]_[hash:8]',
    })
  ]
};

const complier = webpack(dllConfig);

complier.run(err => {

  if (!err) {
    console.log(chalk.yellow('dll generate'));
  }
});

when I using:
const addWebpackPlugins = () => config => {
  const plugins = [
    new HardSourceWebpackPlugin(),
    new webpack.DllReferencePlugin({
      context: resolveApp(''),
      manifest: dllManifest,
    })
  ];
  if (config.plugins) {
    config.plugins = config.plugins.concat(plugins);
  } else {
    config.plugins = plugins;
  }
  return config;
};

What is the expected behavior?

Other relevant information:
webpack version:  4.41.0
Node.js version: 10.16.2
Operating System: mac os
Additional tools:

sorry, I get manifest an undefined.now I resolved the problem


Implementing undo functionality

Hi,
Is there a way I can bring old cards back after it has been swiped left? Also, is there an animation to bring card back?
If I don't add
                     public void removeFirstObjectInAdapter() {
                                    articles.remove(0);
                                    adapter.notifyDataSetChanged();
                                    Log.d("LIST", "removed object!");
                                }

then the next card just freezes.
Thanks,
Arpit

These are 2 different topics. For the second you need this code to remove the item from the adapter. The adapter will take and animate always the top (first) view.

Regarding undo I opened #168


Update MD file on new branch 2017-11-14_19-24-33

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

split/updateTestRef1.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Enabling JIT on a VM doesn't work with custom RBAC roles on resource groups

When using a custom RBAC role, I can't get it to enable JIT VM access using the permissions
Microsoft.Security/locations/jitNetworkAccessPolicies/write and Microsoft.Compute/virtualMachines/write on the resource group scope, as per the article.
If I assign the role at the subscription level, it works. If I assign the role on the resource group in which the VM lives, it fails, because if I try the hardcoded defaults' VM way of enabling JIT, I see:

Just-in-time VM access
To improve security, enable just-in-time VM access.
Upgrade your Microsoft Defender for Cloud subscription to enable a just-in-time access

And in Microsoft Defender for Cloud, I see "Limited Permissions" warning beside my subscription under Environment settings.
Here is the JSON dump of this custom role's permissions:
"permissions": [
            {
                "actions": [
                    "Microsoft.Compute/virtualMachines/write",
                    "Microsoft.Compute/virtualMachines/start/action",
                    "Microsoft.Compute/virtualMachines/runCommand/action",
                    "Microsoft.DBforPostgreSQL/assessForMigration/action",
                    "Microsoft.DBforPostgreSQL/privateEndpointConnectionsApproval/action",
                    "Microsoft.DBforPostgreSQL/register/action",
                    "Microsoft.DBforPostgreSQL/checkNameAvailability/action",
                    "Microsoft.DBforPostgreSQL/serverGroupsv2/privateEndpointConnectionsApproval/action",
                    "Microsoft.DBforPostgreSQL/serverGroupsv2/privateEndpointConnections/write",
                    "Microsoft.DBforPostgreSQL/serverGroupsv2/privateEndpointConnectionProxies/write",
                    "Microsoft.DBforPostgreSQL/serverGroupsv2/privateEndpointConnectionProxies/validate/action",
                    "Microsoft.DBforPostgreSQL/servers/queryTexts/action",
                    "Microsoft.DBforPostgreSQL/servers/resetQueryPerformanceInsightData/action",
                    "Microsoft.DBforPostgreSQL/servers/privateEndpointConnectionsApproval/action",
                    "Microsoft.DBforPostgreSQL/servers/write",
                    "Microsoft.DBforPostgreSQL/servers/administrators/write",
                    "Microsoft.DBforPostgreSQL/servers/privateEndpointConnectionProxies/validate/action",
                    "Microsoft.DBforPostgreSQL/servers/privateEndpointConnectionProxies/write",
                    "Microsoft.DBforPostgreSQL/servers/privateEndpointConnections/write",
                    "Microsoft.DBforPostgreSQL/servers/configurations/write",
                    "Microsoft.DBforPostgreSQL/servers/providers/Microsoft.Insights/diagnosticSettings/write",
                    "Microsoft.DBforPostgreSQL/servers/firewallRules/write",
                    "Microsoft.DBforPostgreSQL/servers/firewallRules/delete",
                    "Microsoft.DBforPostgreSQL/servers/databases/write",
                    "Microsoft.DBforPostgreSQL/servers/virtualNetworkRules/write",
                    "Microsoft.Resources/deployments/validate/action",
                    "Microsoft.Network/networkInterfaces/write",
                    "*/read",
                    "Microsoft.Network/virtualNetworks/write",
                    "Microsoft.Resources/deployments/write",
                    "Microsoft.Network/virtualNetworks/subnets/join/action",
                    "Microsoft.Network/publicIPAddresses/write",
                    "Microsoft.Network/networkInterfaces/join/action",
                    "Microsoft.Network/networkSecurityGroups/write",
                    "Microsoft.Security/locations/jitNetworkAccessPolicies/initiate/action",
                    "Microsoft.Network/networkSecurityGroups/join/action",
                    "Microsoft.Network/publicIPAddresses/join/action",
                    "Microsoft.Compute/virtualMachines/deallocate/action",
                    "Microsoft.Security/locations/jitNetworkAccessPolicies/write"
                ],
                "notActions": [],
                "dataActions": [],
                "notDataActions": []
            }

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 9a9c967c-6cad-c769-822f-118903df2971
Version Independent ID: 46e29bac-0bc8-a4cb-9840-9085a6f843fa
Content: Understanding just-in-time virtual machine access in Microsoft Defender for Cloud
Content Source: articles/defender-for-cloud/just-in-time-access-overview.md
Service: defender-for-cloud
GitHub Login: @ElazarK
Microsoft Alias: elkrieger

@rtrad89
Thanks for your feedback! I've assigned this issue to the author who will investigate and update as appropriate.

@ElazarK
Could you Please review this and update as appropriate.

#reassign:bmansheim

Hi @rtrad89 . Thanks for opening an issue for this. I don't see it addressed in the documentation, and it probably will require support expertise. Please open a support case to get your question addressed, and then re-open this issue with the answer so we can add it to the docs to help others with the same question.
#please-close


Error applying pods/echod: admission webhook denied the request without explanation

When I run the following, I get the error:
$ kubectl apply -f pods/echod.yaml Error from server: error when creating "pods/echod.yaml": admission webhook "image-signature.hightowerlabs.com" denied the request without explanation
The nginx pod creation is denied, as expected.  I don't see anything obvious in the pod logs.
My kubectl version:
$ kubectl version Client Version: version.Info{Major:"1", Minor:"10", GitVersion:"v1.10.3", GitCommit:"2bba0127d85d5a46ab4b778548be28623b32d0b0", GitTreeState:"clean", BuildDate:"2018-05-21T09:17:39Z", GoVersion:"go1.9.3", Compiler:"gc", Platform:"windows/amd64"} Server Version: version.Info{Major:"1", Minor:"10", GitVersion:"v1.10.3", GitCommit:"2bba0127d85d5a46ab4b778548be28623b32d0b0", GitTreeState:"clean", BuildDate:"2018-05-21T09:05:37Z", GoVersion:"go1.9.3", Compiler:"gc", Platform:"linux/amd64"}

Tried a different k8s cluster (AWS EKS running k8s v1.10.3), and everything worked as expected.
Cluster which was returning this error was a Heptio cluster (k8s v1.10.3)...finally figured out the admission controller webhook wasn't configured properly.


fix broken links

/cc: @richlander - the commit has the right content but somehow the rebase you did earlier caused  this commit to pick up the comment from #647 PR

If it just has the wrong message, try "git commit --amend" and then re-push the commit.

@richlander commit amend worked


Accordion: component should support transitions

Steps
Use the Accordion component here from the docs: https://react.semantic-ui.com/modules/accordion#accordion-example-standard
import React from 'react'
import { Accordion, Icon } from 'semantic-ui-react'

const AccordionExampleStandard = () => (
  <Accordion>
    <Accordion.Title>
      <Icon name='dropdown' />
      What is a dog?
    </Accordion.Title>
    <Accordion.Content>

        A dog is a type of domesticated animal. Known for its loyalty and faithfulness,
        {' '}it can be found as a welcome guest in many households across the world.

    </Accordion.Content>
    <Accordion.Title>
      <Icon name='dropdown' />
      What kinds of dogs are there?
    </Accordion.Title>
    <Accordion.Content>

        There are many breeds of dogs. Each breed varies in size and temperament.
        {' '}Owners often select a breed of dog that they find to be compatible
        with their own lifestyle and desires from a companion.

    </Accordion.Content>
    <Accordion.Title>
      <Icon name='dropdown' />
      How do you acquire a dog?
    </Accordion.Title>
    <Accordion.Content>

        Three common ways for a prospective owner to acquire a dog is from pet shops,
        {' '}private owners, or shelters.

 A pet shop may be the most convenient way to buy a dog.
        {' '}Buying a dog from a private owner allows you to assess the pedigree and
        {' '}upbringing of your dog before choosing to take it home. Lastly, finding your dog
        {' '}from a shelter, helps give a good home to a dog who may not find one so readily.

    </Accordion.Content>
  </Accordion>
)

export default AccordionExampleStandard

Expected Result
The user should see an Accordion with content expanding in and out such as the one here: https://semantic-ui.com/modules/accordion.html
Actual Result
Accordion content does not animate and instead is immediately visible or hidden.
Version
0.73.1

Please note, no Transitions are included in this library, yet.
Transitions are a work in progress.  We've recently merged <Transition /> and now <Accordion /> refactoring that should make this possible.
I'll leave this issue open for tracking its implementation here.

tracked here now
https://github.com/Semantic-Org/Semantic-UI-React/issues/2114

We need transitions ASAP, please

I can chip in $25. How about others?

@MaevskiyE @moaxaca This is an open source project. All PRs are welcome from the community on anything tagged with "Help Wanted". If this feature is something you need, I would encourage you to take a shot at enhancing the project and submitting something.
@Maxhodges I am not too familiar with the tools for this, but I know open source bounty systems exist if you wanted to try to set something up on one of them to reference here. Adding additional comments into the tracking issue saying how much money you can chip in is unfortunately probably not going to help.

@brianespinosa @levithomason
I would be happy to do some of this work assuming somebody hasn't already tackled it. Is there a branch available or a roadmap with assignees? Or is this feature completely unimplemented? I am not big on making PR's without discussing some sort of technical design especially on items that have cross-cutting concerns.
To create a more productive dialog on what is completed and what needs to be completed.  Is this really as simple as adding Transition into the life cycle hooks of Accordion & AccordionContent?

@moaxaca That sounds awesome! 💪
This issue is being kept open to track the status of this task. In Github if you mention a task in a PR it will show up linked in the comment history here. Based on that, there is no PR open referencing this issue that is being worked on. I'd recommend the best thing to do would be to comment here that you are taking this task, and get a baseline PR open referencing the issue. That will also give the community the ability to discuss the work over actual code versus discussion over theoretical solutions.
@layershifter will probably be your best resource once you have a PR up on this. The complexity I believe here is not in adding Transition, which does need to be done, but in managing the transition when the AccordionContent becomes inactive.
This is not going to work out of the box with the Component API. It will only work automatically with the shorthand API.

@brianespinosa I will look into this over the weekend and try to come up with a path to implementation (Hopefully a PR).

@moaxaca  any luck on this?

@balramsinghindia the issue history is available to everyone. If you look above your comment you will see a PR working on this. You can follow along there. Repeated questions about how things are going without looking through the issue history is not helpful.

@balramsinghindia there are a few paths toward a solution. I have a working example, but it might not scale through the whole code base. This Transition API is new and this is its first implementation in an existing module.
This warrants some technical discussion but assuming we have a quick response time and can agree on a design direction it should be done shortly.

For some reason the associated PR was closed. Too bad, as I'd also like this feature to come to fruition.

don't hold your breath! we were waiting for over a year. We've moved on to Vuejs with Vuetify.

Didn't mean to sound hateful. Was frustrated but not hateful! I understand the constraints. It's just a fact we'd been waiting for a year. I'm not a React dev; more of a product manager. VueJs and Vuetify are free btw (MIT License). The Vuetify team sells a theme, but the Vuetify UI component framework is open sourced and supported by sponsors and Patreon backers.
btw I setup and maintain the official SUI forms at https://forums.semantic-ui.com/
would anyone like to take over? the only cost is the Digital Ocean hosting ($10 monthly).
It was a bit of work to setup and get started, so I hate to just throw it away, but we aren't building with SUI anymore, so if anyone wants to take over you're welcome to it. Otherwise it will do dark at the end of this month.
Cheers!

btw regarding funding ,you might to see if you quality for TideLift
We’re offering a guaranteed minimum $10,000 over the next 24 months to select projects. See if your project is eligible.
https://tidelift.com/about/lifter

I really need this feature asap. Any updates?

Any updates on the PR ?

You can use some max-height css hacks to create the expand/collapse animation.  I was able to mimic the animations from https://semantic-ui.com/modules/accordion.html with the following css adjustments.
css
.ui.accordion:not(.styled) .title~.content:not(.ui) {
  /* padding: .5em 0 1em; */
  padding: 0;
}
.ui.accordion .title~.content {
  /* display: none; /*
  display: block;
}
.expand {
  transition: .4s max-height ease-out, .4s opacity ease-out;
  max-height: 0;
  opacity: 0;
  overflow: hidden;
}
.active.expand {
  max-height: 1000px;
  opacity: 1;
}

js
<Accordion>
  <Accordion.Title>{...}</Accordion.Title>
  <Accordion.Content className="expand">
    {...}
  </Accordion.Content>
</Accordion>

While not quite fully dynamic, the expanded state of my Accordion is never going to be greater than 1000px and works for my implementation.  Using max-height and overflow:hidden we are able to use the css transition property to simulate animating the opening and closing action instead of simply toggling between display:none and display:block.
To make this dynamic, I believe you will need to expose the ref attribute on <Accordion.Content> to be able to calculate and set it's max-height, using the method outlined in w3schools Animated Accordion (Slide Down).

The react-animate-height library seems to do a better job compared to using semantic's transition group. The animation is much cleaner and children are not unmounted and remounted.
<Accordion
  fluid
  activeIndex={this.state.activeAccordion}
  onTitleClick={this.handleAccordionClick}
  panels={someData.map((data, i) => ({
    key: i,
    title: (
      <Accordion.Title>
        {/* children */}
      </Accordion.Title>
    ),
    content: (AccordionContent, { key, active }) => (
      {/* Not Using AccordionContent to avoid instant showing/hiding */}
      {/* as a result of display: none/block */}

        <AnimateHeight animateOpacity duration={300} height={active ? 'auto' : 0}>
          {/* children */}
        </AnimateHeight>

    ),
  }))}
/>

This is using the short hand version of Accordion but the same can be achieved using the longer implementation.

I'm using SUI's Transition component for showing transition on both expanding and collapsing.
Accordion: https://react.semantic-ui.com/modules/accordion/#usage-exclusive
Transition: https://react.semantic-ui.com/modules/transition
In the example, I'm using inexclusive version of Accordion, which can easily be changed to regular one if anyone wants.
Checkout my current implementation here:
https://codesandbox.io/s/lry6k6x6ol

@maverickdude I think people want the transition on the height of the content.


room gone error message stacks on top of each other

Describe the bug
clicking the back button to go to the previous page when the previous page is a room that no longer exists redirects you to the homepage again if you keep clicking back it keeps redirecting and displays the 'room gone' flash message everytime
To Reproduce
Steps to reproduce the behavior:

Go to a room
end it and you should be redirected to the home page
click the back button as many times as you want
See error

Expected behavior
the error message should be displayed once, or display a 404 page instead.
Screenshots

Probably a duplicate of #2157


Not building on OS X

[:~] $ brew install pcre
Warning: pcre-8.40 already installed
[:~] $ brew install libuv
Warning: libuv-1.11.0 already installed
[:~] $ brew install ossp-uuid
Warning: ossp-uuid-1.6.2_2 already installed

[~/git/siridb-server/Release] master ± make
Building file: ../src/xpath/xpath.c
Invoking: GCC C Compiler
gcc -I../include -O3 -Wall -I/usr/local/include -c -fmessage-length=0 -MMD -MP -MF"src/xpath/xpath.d" -MT"src/xpath/xpath.o" -o "src/xpath/xpath.o" "../src/xpath/xpath.c"
../src/xpath/xpath.c:13:10: fatal error: 'linux/limits.h' file not found
#include <linux/limits.h>
         ^
1 error generated.
make: *** [src/xpath/xpath.o] Error 1

[:~] $ gcc -v
Configured with: --prefix=/Applications/Xcode.app/Contents/Developer/usr --with-gxx-include-dir=/usr/include/c++/4.2.1
Apple LLVM version 8.1.0 (clang-802.0.42)
Target: x86_64-apple-darwin16.5.0
Thread model: posix
InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin

Removed line #include <linux/limits.h> which was not required. (limits is imported as #include <limits.h>)


Update mesos readme

Improve readability by numbering required steps, lettering choice steps, and adding slightly more information on what each guide contains.

derp. should PR to upstream, not my own fork...


Support security demo script changes

Description
There were recent changes to security demo configuration setup which now requires a custom admin Password to be setup for OpenSearch version 2.12.0 and above.
This PR adds appropriate code changes to support the nightly benchmark runs.
Issues Resolved
https://github.com/opensearch-project/security/issues/3624
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Can you please make sure piplock is not updating all other versions as well? And only the necessary package is installed?

I only added the new version, I am not sure how I can stop pipenv to not update other dependencies. I believe we have appropriate version restrictions on each requirements and pipenv honors that while updating. Should be safe.

Can you please make sure piplock is not updating all other versions as well? And only the necessary package is installed?

I only added the new version, I am not sure how I can stop pipenv to not update other dependencies. I believe we have appropriate version restrictions on each requirements and pipenv honors that while updating. Should be safe.

Sometimes that break too. Mostly because of the underlying docker images during runs being different depending on the platform. We can merge this as if and monitor for any failures.

Looks like code cov is complaining about need_strong_password. Maybe just add a small assert for that? Looks good overall. Need to get similar change in for cluster cdk as well.

Yeah, it can nit-picky. The condition is actually tested in tests/tests_test_workflow/test_benchmark_workflow/benchmark_test/test_benchmark_test_suite.py where I am asserting a string password is present in the docker command.


Smelter not working

Switched to NoSmokeStayLit from FuelEternal, smelter has coal and ore, but doesn't do anything. Tried to build a new smelter from scratch outside to see if the change in the mod broke something on the existing one, newly built one outside also doesn't work. Seems that with:
Smelter Enable Smoke = true (smelter doesn't function) (made sure to build one outside so it has all the space it needs, still doesnt)
but
Smelter Enable Smoke = false (smelter does)
Tested on a dedicated server with one client connected.
Only other mods I have installed that touches smelter (as far as I know) are:
Smoothbrain-ConversionSizeAndSpeed
OdinPlus-OdinsCraftyBoxes

Yea it's a bug in the mod.  I found it yesterday.  I plan to update it today for a fix.  It's a stray line of code that was copied in when I moving functions around.  Thanks again.

New version on Nexus and Thunderstore fixes this issue. Thanks again.


--skip-install doesn't work

Describe the Bug
--skip-install doesn't work
Which package is affected (leave empty if unsure)
No response
Link to the code that reproduces this issue
no link
To Reproduce
    "email": "email dev --dir src/emails --port 4000 --skip-install"

Expected Behavior

What's your node version? (if relevant)
No response

I am experiencing the same issue

The published NPM version has not been updated in months while the repo and site have been being updated.


Interfacing with platform models, support TF model serving

[x] Interface the plugin models with python backend.
[x] Implement the tensorflow model serving in model.py(src/resources/plugin_models/tensorflow_savedmodel/model.py)
[x] Ship TF package and dependency (ongoing) - Decided to let users install dependencies by themselves

We probably need testing for all the parameters parsing too.

I am working on adding testing as a separate ticket.


Installation waits for nothing

Windows PowerShell
Copyright (C) Microsoft Corporation. All rights reserved.

PS C:\WINDOWS\system32> npm install --global --production windows-build-tools

><EMAIL_ADDRESS>postinstall C:\Program Files\nodejs\node_modules\windows-build-tools
> node ./lib/index.js

Downloading BuildTools_Full.exe
Downloading python-2.7.14.amd64.msi
[>                                            ] 0.0% (0 B/s)
Downloaded python-2.7.14.amd64.msi. Saved to C:\Users\Jens\.windows-build-tools\python-2.7.14.amd64.msi.

Starting installation...
Launched installers, now waiting for them to finish.
This will likely take some time - please be patient!

Status from the installers:
---------- Visual Studio Build Tools ----------
Successfully installed Visual Studio Build Tools.
------------------- Python --------------------

=== Logging stopped: 2/24/2018  22:12:22 ===
Terminate batch job (Y/N)? y
PS C:\WINDOWS\system32> npm install --global --production windows-build-tools

><EMAIL_ADDRESS>postinstall C:\Program Files\nodejs\node_modules\windows-build-tools
> node ./lib/index.js

Downloading BuildTools_Full.exe
Downloading python-2.7.14.amd64.msi
[>                                            ] 0.0% (0 B/s)
Downloaded python-2.7.14.amd64.msi. Saved to C:\Users\Jens\.windows-build-tools\python-2.7.14.amd64.msi.

Starting installation...
Launched installers, now waiting for them to finish.
This will likely take some time - please be patient!

Status from the installers:
---------- Visual Studio Build Tools ----------
Successfully installed Visual Studio Build Tools.
------------------- Python --------------------

=== Logging stopped: 2/24/2018  22:31:08 ===

reproduces 100%(the output is the second try)
I expect that it will be installed successfully too, or even an error message.
Unfortunately, I used the wrong tags, because I didn't found duplicates.

I have the same issue. It stops after  ----------------------------------- Python ----------------------------------


[Acceptance Test] Visualize Pi Devices in a Table

Description and Goal of Test
Display a list of Pi Devices in a table, and the information of a Pi Device after selecting one from the table.
Acceptance Criteria

[x] Display Pi Devices in a table
[x] Click a Pi Device to see its attributes
[x] Apply filters to change the table of Pi Devices

Reviewed the devices table on the above mentioned tasks with @DerekRuiz  @shash3
Great work! thanks guys!


Fix wrong arguments of audio trim

Match trim arguments frame_length and hop_length with hyper parameters fft_size and hop_size. That commit improves the training speed to convergence.

In my opinion, librosa.effects.trim don't have to have same frame_length and hop_length to STFT parameters.

I'm a little bit with @a3626a on this one.
For librosa.trim on my Finnish dataset I had to adjust the top_db slightly to get nice and snug silence.
For the frame_length, if you increase it too much, you won't find the small silences.  It is not clear from this PR that what the values will be for frameand hop.
Maybe your idea is that the trimmed audio will match the fft_window length giving some extra boost? Which it won't, because the audio files will be of varying length depending on the original length - trimmed bits.
So my guess is that you setting the trim values as fft_size and hop_size made them smaller than the  librosa.trim defaults. That is more like a lucky coincidence. Instead of convolving the existing hyperparameters, you should just add 3 more: trim_top_db=60, trim_frame_length=2048, trim_hop_length=512.
Then users can set them to fit their datasets, AND can control the fft_size and hop_size independently.

I guess so. For more experiments, I do not think the arguments do much matter with convergence. The PR is not necessary as I thought.


IPv6: No route to host

Important notices
Before you add a new report, we ask you kindly to acknowledge the following:

[x] I have read the contributing guide lines at https://github.com/opnsense/core/blob/master/CONTRIBUTING.md
[x] I am convinced that my issue is new after having checked both open and closed issues at https://github.com/opnsense/core/issues?q=is%3Aissue

Describe the bug
After the upgrade from 21.7.7, there is a problem with IPv6 routing, unable to assign v6 addresses to LAN devices, and found a lot of Error dhcpd send_packet6: No route to host in the DHCP log.
At the same time, the default IPv6 route for the WAN interface becomes a link-local address. Testing the connection using either the WAN or LAN interface for this address will return an error. Even though both the WAN and LAN interfaces have acquired valid IPv6 addresses. But the router itself can access the IPv6 network normally whether it is the LAN or the WAN interface. That said, I suspect that only other devices on this router's LAN interface are affected.
To Reproduce
Steps to reproduce the behavior:

Do upgrade from 21.7.7
Make a device on the LAN re-request a dhcp address
Navigate to /ui/diagnostics/log/core/dhcpd
See error
Navigate to /system_gateways.php
Copy WAN_DHCP6 (active) gateway, it start with fe80::
Navigate to /diag_ping.php
Paste the gateway to host
Select protocol to IPv6 and src to WAN or LAN
Ping
Got error ping6: sendmsg: No route to host both WAN and LAN
Try ping 2001:4860:4860::8888
Everythin OK

Expected behavior
The router itself and other devices it routes should normally obtain IPv6 addresses and access the IPv6 network normally.
Describe alternatives you considered
Reinstalling back to 21.7.7 or earlier fixes the issue, but it's not a good solution as we need to get updates for functionality and security.
Screenshots

Relevant log files
Using the opnsense-log tool seems to only get the system log, i.e. the contents of /var/log/system/latest.log, I checked its contents and it doesn't seem to help with the issue.
Additional context
The WAN interface uses DHCPv6 to obtain addresses, and the LAN interface uses the tracking interface.
The WAN interface obtains a prefix of /56, and the DHCPv6 service shows that the available prefix delegation size is 57.
Environment
OPNsense 22.1.4_1-amd64
FreeBSD 13.0-STABLE
OpenSSL 1.1.1n 15 Mar 2022
Intel(R) Celeron(R) CPU J3455 @ 1.50GHz (4 cores, 4 threads)
I211 Gigabit Network Connection

#5626 maybe related to this issue.

@KagurazakaNyaa if you want to ping link-local please use link-local setting from ping GUI utility. There's no reason it shouldn't work and I don't think it was ever possible to ping from GUA to link-local...

OK, then it looks like it shouldn't be related to this issue, the reason I mentioned it is that before the upgrade the default IPv6 route started with 240e:

Can you try a connectivity audit from the firmware GUI first to see if IPv6 works internally or not?

Can you try a connectivity audit from the firmware GUI first to see if IPv6 works internally or not?

Yes, it works and the router itself can access the IPv6 network just fine.
Then I think, the crux of the problem should be that the IPv6 communication from the router to the LAN device cannot work properly.
I noticed that the LAN interface does not currently have a link-local address. Is this normal?

If dhcpd is erroring it would complain about an address no longer in use, which is definitely strange. Can you share an ifconfig on your LAN device?

Also what's in /var/etc/dhcp6c.conf ?

On router:
root@router:~ # cat /var/etc/dhcp6c.conf
interface pppoe0 {
  send ia-na 0; # request stateful address
  send ia-pd 0; # request prefix delegation
  request domain-name-servers;
  request domain-name;
  script "/var/etc/dhcp6c_wan_script.sh"; # we'd like some nameservers please
};
id-assoc na 0 { };
id-assoc pd 0 {
  prefix-interface bridge0 {
    sla-id 1;
    sla-len 8;
  };
};

On an arch linux vm:
╭─root@dev in ~
╰$ ifconfig
docker0: flags=4163<UP,BROADCAST,RUNNING,MULTICAST>  mtu 1500
        inet <IP_ADDRESS>  netmask <IP_ADDRESS>  broadcast <IP_ADDRESS>
        inet6 fe80::42:5dff:fef1:f52a  prefixlen 64  scopeid 0x20<link>
        ether 02:42:5d:f1:f5:2a  txqueuelen 0  (Ethernet)
        RX packets 115928  bytes 78381851 (74.7 MiB)
        RX errors 0  dropped 0  overruns 0  frame 0
        TX packets 172847  bytes 211387185 (201.5 MiB)
        TX errors 0  dropped 0 overruns 0  carrier 0  collisions 0

ens192: flags=4163<UP,BROADCAST,RUNNING,MULTICAST>  mtu 1500
        inet <IP_ADDRESS>  netmask <IP_ADDRESS>  broadcast <IP_ADDRESS>
        inet6 fe80::e29:7387:6bff:ad6c  prefixlen 64  scopeid 0x20<link>
        ether 00:50:56:ad:6f:f1  txqueuelen 1000  (Ethernet)
        RX packets 4620951  bytes<PHONE_NUMBER> (2.9 GiB)
        RX errors 0  dropped 0  overruns 0  frame 0
        TX packets 1284993  bytes 681487754 (649.9 MiB)
        TX errors 0  dropped 0 overruns 0  carrier 0  collisions 0

lo: flags=73<UP,LOOPBACK,RUNNING>  mtu 65536
        inet <IP_ADDRESS>  netmask <IP_ADDRESS>
        inet6 ::1  prefixlen 128  scopeid 0x10<host>
        loop  txqueuelen 1000  (Local Loopback)
        RX packets 674911  bytes<PHONE_NUMBER> (982.5 MiB)
        RX errors 0  dropped 0  overruns 0  frame 0
        TX packets 674911  bytes<PHONE_NUMBER> (982.5 MiB)
        TX errors 0  dropped 0 overruns 0  carrier 0  collisions 0

veth356a6fc: flags=4163<UP,BROADCAST,RUNNING,MULTICAST>  mtu 1500
        inet6 fe80::f074:97ff:fe80:c6f3  prefixlen 64  scopeid 0x20<link>
        ether f2:74:97:80:c6:f3  txqueuelen 0  (Ethernet)
        RX packets 37552  bytes 35408193 (33.7 MiB)
        RX errors 0  dropped 0  overruns 0  frame 0
        TX packets 94918  bytes 35555360 (33.9 MiB)
        TX errors 0  dropped 0 overruns 0  carrier 0  collisions 0

veth826d544: flags=4163<UP,BROADCAST,RUNNING,MULTICAST>  mtu 1500
        inet6 fe80::ce7:39ff:fe47:1d9f  prefixlen 64  scopeid 0x20<link>
        ether 0e:e7:39:47:1d:9f  txqueuelen 0  (Ethernet)
        RX packets 7  bytes 858 (858.0 B)
        RX errors 0  dropped 0  overruns 0  frame 0
        TX packets 52764  bytes 26111386 (24.9 MiB)
        TX errors 0  dropped 0 overruns 0  carrier 0  collisions 0

Devices on the LAN can now only obtain IPv4 addresses.

bridge0 is your LAN? bridges don't have link-local addresses unless set in GUI. But if bridge0 isn't your LAN you should change the tracker to use LAN interface really and not the bridge. This stuff can be bridged, but depending on what is being bridged it can get fragile really quickly.

Yes, bridge0 is the LAN interface and it contains three physical interfaces.
It worked, after I enabled the link-local of bridge0.
Thank you very much!

ok happy to hear :)


Generate Tests

Need to test all page loads, form submissions, and DB retrieval.

The perfect ID number.  Serendipitous.

Need to generate full CRUD tests for Magicians.

Let's do a page-load test on the Project home page and GitHub home pages in M3

Implemented full-up CRUD tests for Sets, Routines, Magicians and Materials.  The design pattern for the tests is not the standard Fluentlenium design pattern.  Someday, if we have time, I'd like to:

Consolidate all of the browser.goTo() calls into Page calls that return the class of the new page.  This way, if we change a button or nav, we only need to change it in one place.
Consolidate all of the click() calls into Page calls.  Same reason, centralize the logic.

The real challenge is that we really need a Page (that is classes in tests.pages) for every page. Then, we need to get pages to create/return other pages as we click from page to page.  Right now, I simply hold all state in the browser class.


OTel SpanLink results in ClassCastException

Describe the bug
The OTelSpanBuilder is unable to handle linked AutoValue_ImmutableSpanContext.
Should io.opentelemetry.api.trace.SpanContext.create() be instrumented and return a OTelSpanContext instead?
java.lang.ClassCastException: class io.opentelemetry.api.internal.AutoValue_ImmutableSpanContext cannot be cast to class co.elastic.apm.agent.opentelemetry.tracing.OTelSpanContext (io.opentelemetry.api.internal.AutoValue_ImmutableSpanContext is in unnamed module of loader 'app'; co.elastic.apm.agent.opentelemetry.tracing.OTelSpanContext is in unnamed module of loader co.elastic.apm.agent.bci.classloading.IndyPluginClassLoader @7853756f)
	at co.elastic.apm.agent.opentelemetry.tracing.OTelSpanBuilder.startSpan(OTelSpanBuilder.java:198)

https://github.com/elastic/apm-agent-java/blob/0e1fb43f64076fe77f739609513a1f8e7e1cff18/apm-agent-plugins/apm-opentelemetry/apm-opentelemetry-plugin/src/main/java/co/elastic/apm/agent/opentelemetry/tracing/OTelSpanBuilder.java#L198
Steps to reproduce
final Tracer tracer = GlobalOpenTelemetry.get()
    .tracerBuilder("")
    .setInstrumentationVersion("0.10.0")
    .build();

final SpanContext parentSpanContext = SpanContext.create(
  "f1f6ae85a6cbd46ef0fc12ca201a5954", "e9effc2a1b309797", TraceFlags.getDefault(), TraceState.getDefault());

final Span span =  tracer
    .spanBuilder("queue.task")
    .setSpanKind(SpanKind.CONSUMER)
    .setParent(Context.current())
    .addLink(parentSpanContext)
    .startSpan();

Expected behavior
The linked span context should work as expected.
Solution
I began implementing a SpanContextOpenTelemetryInstrumentation, but was unable to set the traceId in TraceContext without using reflection.
public class SpanContextOpenTelemetryInstrumentation extends AbstractOpenTelemetryInstrumentation {

    @Override
    public ElementMatcher<? super TypeDescription> getTypeMatcher() {
        return named("io.opentelemetry.api.trace.SpanContext");
    }

    @Override
    public ElementMatcher<? super MethodDescription> getMethodMatcher() {
        return named("create");
    }

    @Override
    public String getAdviceClassName() {
        return "co.elastic.apm.agent.opentelemetry.SpanContextOpenTelemetryInstrumentation$SpanContextOpenTelemetryAdvice";
    }

    public static class SpanContextOpenTelemetryAdvice {
        @Advice.AssignReturned.ToReturned
        @Advice.OnMethodExit(suppress = Throwable.class, onThrowable = Throwable.class, inline = false)
        public static OTelSpanContext onExit(@Advice.Argument(0) String traceHexId, @Advice.Argument(1) String spanHexId) {
            Id traceId = Id.new128BitId();
            traceId.fromHexString(traceHexId, 0);

            Id spanId = Id.new64BitId();
            spanId.fromHexString(spanHexId, 0);

            // TODO handle traceFlags and traceState

            TraceContext traceContext = TraceContext.ofId(spanId, GlobalTracer.get().require(ElasticApmTracer.class)); <--- new static factory method

            return new OTelSpanContext(traceContext);
        }
    }
}

Hi,
I've managed to reproduce the error that you are facing here and the agent should not trigger a ClassCastException and should instead either silently ignore or issue a warning.
The problem here is that you are manually creating a SpanContext with OpenTelemetry API and using this as a span link. Our OpenTelemetry implementation currently does not support arbitrary SpanContext like you did.
Can you elaborate a bit on the use-case that you are trying to achieve here ? Maybe there is a simpler option by using a span attribute as a work-around for your use case.

I have just implemented a "work-around" that just properly warns that using arbitrary spans context is not supported with the otel bridge. https://github.com/elastic/apm-agent-java/pull/3672
A snapshot is available here if you'd like to test it.

Hi,
I've managed to reproduce the error that you are facing here and the agent should not trigger a ClassCastException and should instead either silently ignore or issue a warning.
The problem here is that you are manually creating a SpanContext with OpenTelemetry API and using this as a span link. Our OpenTelemetry implementation currently does not support arbitrary SpanContext like you did.
Can you elaborate a bit on the use-case that you are trying to achieve here ? Maybe there is a simpler option by using a span attribute as a work-around for your use case.

Thanks for the reply.
Our goal is to spin up new trace per asynchronous job, and associate the newly created trace with the one that enqueued the job. Similar to what is described here; https://opentelemetry.io/docs/concepts/signals/traces/#span-links
Request (Trace 1) --> Enqueue Job (metadata: parentTraceId, parentSpanId) -> Asynchronous Job Executed (Spin up Trace 2, and associated with Trace 1).
Is this achievable using the otel bridge?

Do you have a strong requirement to use Elastic APM agent here ?
As you are already using the OpenTelemetry API, it might be more natural to use an opentelemetry agent and not the opentelemetry bridge in our APM agent.
I would suggest to use our new opentelemetry java distribution or the upstream opentelemetry instrumentation agent, the data captured by those can be ingested as-is in APM.

Will the https://github.com/elastic/elastic-otel-java/ be replaced by the apm-agent-java, in the long run?

The classic Elastic APM Java agent has many features not yet available in the OpenTelemetry distribution. We are implementing these in our distribution and gradually contributing these upstream to OpenTelemetry. This is likely to take some time, so the long run could be quite long and ultimately it will come down to customer demand. Which is a long-winded way of saying maybe

We migrated to the opentelemetry-agent in the end, and it works fine with span links. Thanks for the feedback!


[Bug] Leaf logo appears distorted and unclear due to imperfect rounding

Issue Description:
The logo currently appears with imperfect rounding, making it look uneven. Additionally, the logo is rendering behind other elements on the page, which affects its visibility.
Expected Behavior:
The logo should have a perfectly rounded appearance.
The logo should always stay in front of other page elements to ensure it's clearly visible.
Suggested Fix:
Ensure proper CSS styling to create a perfectly rounded logo.
Adjust the z-index or other positioning properties to keep the logo in the foreground.

Hello @anuragverma108
Could you please assign the "Hacktoberfest" label to this issue? I’d love to work on it as part of Hacktoberfest.
Thank you!

Thanks for creating the issue in WildGuard! The issue has been assigned to you.
Before you start working on your PR, please make sure to:

⭐ Star the repository if you haven't already.
Pull the latest changes to avoid any merge conflicts.
Attach before & after screenshots in your PR for clarity.
Include the issue number in your PR description for better tracking.

Don't forget to follow @anuragverma108 – Project Admin & @PriyaGhosal -Project Collaborator  – for more updates!
We're excited to see your contribution as part of Hacktoberfest 2024! 🎉
Happy open-source contributing!


Java decompiler failure: Error getting pcode snippet for java 8 streams

Describe the bug
The decompiler throws the error when attempting to view a function that utilizes java 8 streams.
  Low-level Error: Error getting pcode snippet: class
       ghidra.javaclass.format.constantpool.ConstantPoolInterfaceMethodReferenceInfo cannot be cast
       to class ghidra.javaclass.format.constantpool.ConstantPoolMethodReferenceInfo
       (ghidra.javaclass.format.constantpool.ConstantPoolInterfaceMethodReferenceInfo and
       ghidra.javaclass.format.constantpool.ConstantPoolMethodReferenceInfo are in unnamed module of
       loader ghidra.GhidraClassLoader @27abe2cd)

To Reproduce

Save the following snippet into a file named Foo.java
Compile the code using javac Foo.java
Open Ghidra and import Foo.class
Auto analyze Foo.class
Go to the symbol tree and click on main under the Functions folder
View the decompiler output Ctrl + E

import java.util.stream.IntStream;

class Foo {
  public static void main(String[] args) {
    // print values 1 - 10 using IntStream
    IntStream.rangeClosed(1, 10).forEach(i -> System.out.println(i));
  }
}

Expected behavior
The expected behavior is for the decompiler to produce java code
Environment
OS: Linux (Arch)
Java Version: 1.8.0_212
Ghidra Version: 9.0.1

Thanks for reporting this!

Thanks for reporting this!

Fixed for 9.1.


A call to neo4jCollection.find().fetch() can lead to Meteor constantly refreshing a template

You can find a repository with a description and demonstration of this bug here:
https://github.com/blackslate/Neo4j-churn/tree/master

+1 I have the same behaviour using ReactMeteorData mixins:
var Main = React.createClass({
mixins: [ReactMeteorData],
getMeteorData() {
Tops.subscribe('topWords', {}, 'w')
return {
tops: Tops.find().fetch()
}
},
render() {
return (
Hello
)
}
})

HI @schabluk ,
Currently I can only offer to use non-reactive driver as it well supported and up to date.
New updated reactivity driver planned to release in 2 months (I hope new version of Neo4j will be release during 2 months and features of new Bolt protocol will be expanded)

Hi @dr-dimitru,
The problem is gone, I had it with react package in ver. 0.14.1, with 0.14.3 it's working well.

Still experience this problem.


Added in Filter details in DeveloperGuide.adoc and attempted to handle prefix in FilterCommand.

Pull Request Test Coverage Report for Build 219

0 of 0   changed or added relevant lines in 0 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage remained the same at 60.977%

Files with Coverage Reduction
New Missed Lines
%

src/main/java/seedu/address/model/person/ContainsKeywordsPredicate.java
1
0.0%

Totals

Change from base Build 218:
0.0%

Covered Lines:
1261

Relevant Lines:
2068

💛  - Coveralls


fix: tx and address page summary mobile style

:tada: This PR is included in version 1.143.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


[WIP] Closing goroutines safely

Signed-off-by: ganeshpatro321<EMAIL_ADDRESS>

Lets finish this up. @Harkishen-Singh

@ganeshpatro321 @Harkishen-Singh Inactivity on this one. Might consider closing it now and reopening a fresh one


Add a modal to profile

Switch branch to add_profile

[ ] add a button on Profile that opens up a modal
[ ] users should be able to change username, description
[ ] add validation username should not be blank
[ ] add a button that submits the update
[ ] add a button to cancel and show a warning

Can I work on this?

@redxzeta Created a pull request, Please take a look: https://github.com/redxzeta/Awesome-Adoption/pull/210