Configuration refactoring - thoughts and suggestions welcome!

Configuration has been a topic of discussion for quite some time now, so I thought it'd be a good idea to get all those thoughts in one place and hopefully solicit some user thoughts as well.
From my understanding, the current purposes of configs are:

make it easy for people to get up and running
get all parameters in one place for ease of setting up experiments and making them interpretable
keep signatures simple, which makes it easy to create arbitrary things from one big blob

The current issues I'm having with configs are:

they are somewhere between a dictionary and a blob-object, which makes them confusing
they aren't serializable, so I have to create config wrappers around Configurations.  Eww.
defaults and unused parameters make it challenging to know what's really being used.

My personal opinion is that we can keep benefits (1) and (2) above and get rid of all three issues all in exchange for the small sacrifice of benefit (3).  In fact, I don't know how much of a benefit (3) is, as it obfuscates the true parameters of all objects in the codebase.
I would propose doing so by putting the burden of the parameter creation and passing into the constructors of objects onto the user.  Any intermediate user will have experience creating parameter/config generation wrappers. Less experienced users who want to get up and running quickly can still use the same JSON objects you've already written with something like this when actually creating the objects downstream:
SomeObject(config_dict['some_key'], config_dict['another_key'])
Users who want to create defaults can do this:
SomeObject(config_dict.get('some_key', default_value), config_dict.get('another_key', another_default_value))
Which to me is a much more clear way of going about defaults.
The side benefit of all of this is that you aren't stuck supporting configurations for users.  Configuration and deployment are two challenging parts of any project, and I personally would prefer everyone's time spent on RL, not trying to solve a fundamental CS issue (configuration!) that in the end is always problem-specific, and no matter how hard we try, never suits everyone's needs.

First, a question for clarification: Do you mean that the parameters are passed as 'proper' arguments, i.e. for instance VPGAgent(learning_rate=..., discount=..., gae_lambda=..., etc) instead of VPGAgent(config)?

@AlexKuhnle after my experiences so far, that would be my preference.  I know that won't be universal.

Moreover, here some ideas or partially already implemented things in my local version:

We currently transform every sub-dict of a Configuration into another Configuration, something which by now turns out to be quite bad and counter-intuitive. Here I would suggest taking the Configuration as one-layer collection of parameters instead (which can be dictionaries).
For more 'historical' reasons we have singled out some parameters as top-level, where really they should be sub-parameters. This includes leaning_rate as sub-parameter for optimizer as well as memory_capacity as part of memory, and some others. Proposal is obviously to move them where they belong.
We currently have default_config dicts defined in all the classes where a parameter is used. With more recent work on the long-promised optimizers, I'm more and more inclined to, first, potentially break the symmetry between models and agents and, second, move all default values into the final algorithm-specific Agent implementation, of which there could be many (original DQN, double DQN, prioritized DQN, specific DQN used in whatever paper, etc)...
Particularly the last point only leaves the question whether the parameters should be moved through as one object or as many arguments. In particular, there are some arguments, most notably states and actions, which are somewhat different from the usual hyperparameters, hence for them I would be inclined to single them out.

@AlexKuhnle i'd like to add network to your last point of states and actions being different from usual hyperparameters.

Good point, and yet another slightly different 'hyperparameter'. What I'm more or less happy with is the way we have one uniform interface to either use pre-defined (say, optimizer='adam') or custom functions/classes by passing either the function or the 'python path' (say, optimizer=my_module.my_optimizer.Optimizer). In fact, one could do something similar for the network (or, it is kind of done, but only kind of...).

@AlexKuhnle I agree the uniform interface is nice.  Could we achieve that while also creating the instances on the user-side with something like this?
Optimizer = tensorforce.defaults.AdamOptimizer()
or (custom)
Optimizer = my_module.my_optimizer.Optimizer(*args, **kwargs)
and then calling Experiment (based on my above) or Runner (current) with Runner(my_agent, my_network, ..., my_optimizer).

Hmm, I guess it could be done, but is it a problem if you have to pass the callable? My thought is that you can always create a wrapper lambda expression, like lambda x: my_module.my_optimizer.Optimizer(x, y, z). But anyway, should be easily doable by modifying the util functions used in these cases.

When I just started using (tensorforce) it was really a bit painful to get to the bottom of the configuration so I do think this really is one of the main points we should work on.
I thought about improving documentation so people do not bump into the same issues as I did, but if the configuration itself will be updated, I would rather help on that then, so please update if you can use some help.

The new version will handle configs somewhat differently, and is inspired by the discussion here, hence let's continue this discussion in a week or so... It will of course never be perfect, but it's an attempt to get rid of some obvious problems that repeatedly came up.

The new version still uses a Configuration object, which now merely acts as a 'container' for all hyperparameters. State/action/network specifications are separate arguments. Default values are only specified in the final Agent sub-class and only the relevant ones for this implementation, like in VPGAgent. It's possible to pass initialized instances, or alternatively pass something like {'type': 'my_module.MyOptimizer', 'arg1': XXX, 'arg2': YYY, ...} to achieve the same.
Is there anything else you think is clearly not ideal?

When I asked @michaelschaarschmidt who the core audience was, he said it was people who would be capable of working as a ML engineer.  Given that, I would personally ditch configs altogether and put the burden of creating initialized instances of the core components of a run on the user.  You can still have "off the shelf" examples, they just wouldn't exist via configs.
It seems like the Configuration object just creates overhead/maintenance for the team, and creates mysterious issues for the user.
These are personal opinions, and although they are strong, they are weakly-held.  I support whatever you and the team decides.
Should you proceed with the Config route, I would request a very easy-to-use method where I can get a fully-correct version of the actual config that was used for the run, after any possible mutations downstream from the point I pass it in.  I'm sure I'm not alone in wanting to verify what my run is using is actually what I think it is.

But, to answer your question about things that are clearly not ideal: nothing right now.  This would be require another refactoring, and I know now isn't the time.

I definitely like the alternative without any Configuration object as well. The only annoying 'issue' with that would be that there might be 20+ arguments to pass through quite a few constructors (particularly all the options required in the 'last' object of the constructor chain, the Model), while the upside would be that everything is very explicit. The former could probably be improved by introducing container dicts for logging and tf_session or so, similar to values like optimizer.
To be clear, this aspect of the Configuration object acting as a 'container' is the only difference to getting rid of it entirely, since all default_config objects and changing values doesn't happen anymore, so the only place where the config object changes is in the Agent subclasses like VPGAgent. So removing the Configuration object really is no big deal anymore. The more I think about it, I agree that it might be best to just finally get rid of it entirely (e.g. more straightforward documentation of parameters as constructor arguments). I'll ask the others what they think...

From the user perspective I agree with removing the Configuration object. I recently started using tensorforce and it would be much easier if all arguments were available at constructors, instead I had to read docs, library code and ask on Gitter. Just my personal experience, perhaps it does not generalize to others.

@AlexKuhnle I know better documentation is on the roadmap for the project as well, and that's a lot easier and better supported via parameters in constructors than it is in comments in configuration files or in-line in examples.
Long constructors can be annoying, but they are also a subtle nudge for people to take more time considering what they're doing and learning about what factors really influence their experiments.

Totally agree, I'm convinced. :-)

Yes!  Well - let me know if you want me to change the title of this issue at any point to "Remove Configuration - Pass Parameters in Constructors" or something like that.

Nah, that's alright, we'll just try to close it soon...

Just to let you know: We decided that we will first try to merge the dev branch with master asap (probably today), and then probably integrate this change as a minor version update in the next weeks.

This will hopefully be finished this weekend by @michaelschaarschmidt, just to let you know @trickmeyer.

Configuration object is gone and I hope everyone is (largely) happy with this so we can avoid breaking changes for a while


Episode end

Adding a feature for manually ending an episode, to provide demonstrations of different lengths for example.

the game can now be prematurely ended via the escape key


BAU Attempt to fix pact port in use errors

Selfservice tests fail regularly with the error:
Error: Port 'XXXXX' is already in use by another process
The pact-node provider will by default use an available random port if no port is specified
https://www.npmjs.com/package/@pact-foundation/pact-node
Remove our code to get a random port without checking availability and use the assigned port in the URL used by the client in the pact test.

Is productsApiKey not necessary?

It wasn't used by the function that accepted it as a parameter


Visual Studio Code plugin does not work

The Visual Studio Code plugin does not work. Here is the error output of the language server:
flag provided but not defined: -stdio
Usage of protobuf-language-server:
  -listen string
    	address on which to listen for remote connections
  -logs string
    	logs file path (default "C:\\Users\\itsame/.protobuf-language-server.log")
[Error - 4:28:46 PM] Server initialization failed.
  Message: Pending response rejected since connection got disposed
  Code: -32097
[Info  - 4:28:46 PM] Connection to server got closed. Server will restart.
true
[Error - 4:28:46 PM] protobuf-language-server client: couldn't create connection to server.
  Message: Pending response rejected since connection got disposed
  Code: -32097

Apparently the server gets started with incompatible arguments.
I downloaded and installed everything fresh from Github (274197af43657986e7c950fef90cfb190ea5a5e7) after the downloadable plugin from the registry did not work, but the effect is the same.

https://github.com/lasorda/protobuf-language-server/pull/21 this commit fix vscode

@BrotifyPacha check this

Yeah, your fix should do it.
Apparently vscode sends -stdio argument to language servers. It wasn’t an issue previously because main() wasn’t calling flag.Parse() before i refactored it.


http: netty does not upgrade to https

Expected behavior
Netty handles the HTTP response or upgrades it to https
Actual behavior
Netty handles to https requests fine but fails on http request eg resets connection (upgrade-Insecure-Requests
1 does not change anything)
Steps to reproduce
Netty pipeline with SSLHandler, HttpRequestDecoder, HttpObjectAggregator, HttpResponseEncoder and HttpContentCompressor
Minimal yet complete reproducer code (or URL to code)
https://hastebin.com/afabacevag.java
The SSL context is a self-signed one
Netty version
4.1.24.Final
JVM version (e.g. java -version)
java-8-openjdk-amd64
OS version (e.g. uname -a)
Linux 4.15.0-20-generic #21-Ubuntu SMP Tue Apr 24 06:16:15 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Please provide more details.... Like how exactly you test it, what exception, what you expect etc.

No exceptions. I just added the ssl handler to a project and if I access with https I don't get redirected the requests with http are just not handled

I really don't see an opertunity to allow https and redirect http to https.
In SSLHandler#decodeJdkCompatible directly calls setHandshakeFailure() both of the methods are private so there is no change to avoid that Http request are blocked by the SSLHandler

OptionalSslHandler is the key here. After reading this https://github.com/netty/netty/pull/6438


Reservation file for MP proposal numbers?

I ran into an issue when I created the proposal for MicroProfile 1.1.  I just looked at the "proposals" subdirectory and saw the next logical number was 0005.  But, because of other in-flight proposals, this number was already in use by the JWT proposal.  So, how can someone know what the proper proposal number should be?
My suggestion is to just create a top-level file that can easily be updated with the MP proposal number along with the title of the proposal.  As new proposals arise, we could update that file so that everyone can see at a glance all of the proposal numbers and associated titles.
I'm open to other ideas.  I'm just looking for something simple so that future proposals don't hit the same problem that I did.  Thanks.

closing as out of date with proposal changes


MAX_PAGE_SIZE limited to 200

WSAPI actually supports 2000 now.

@ferentchak, :poop:

I upped it to 2000 & added a pull request. Thanks.

Fix in just released v3.3.1.  I actually just totally trashed the max page size enforcement, since WSAPI will enforce the limits, and now we don't have to change it again here in the future if it changes again.


I was denied to access your git

I can't git clone https://github.com/eriklindernoren/PyTorch-GAN
Error message is below.
fatal: could not create work tree dir 'PyTorch-GAN'
Why does this error happen?

Maybe you don't have write permissions in the directory where you're trying to clone the repo?
See: https://stackoverflow.com/questions/16376035/fatal-could-not-create-work-tree-dir-kivy

네이버 메일 앱에서 보냈습니다.
-----Original Message-----
보낸사람: "Erik Linder-Norén"<EMAIL_ADDRESS>받는사람: "eriklindernoren/PyTorch-GAN"<EMAIL_ADDRESS>참조: "bylee" yhungkr@naver.com,"Author"<EMAIL_ADDRESS>날짜: 2018.09.01 오전 04:12:30
제목: Re: [eriklindernoren/PyTorch-GAN] I was denied to access your git (#19)
Maybe you don't have write permissions in the directory where you're trying to clone the repo?
See: https://stackoverflow.com/questions/16376035/fatal-could-not-create-work-tree-dir-kivy
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

I'll close this one because of inactivity.


How can i import js file from node_modules?

import someModule from 'someModule'

The  from 'someModule' looks in the node_modules folder for a module of that name.


Rebuild 3.5.1 for icu, libtiff and pango

As long as we support both R versions, we regulary need to rebuild 3.5.1.
I branched off https://github.com/conda-forge/r-base-feedstock/commit/9070b22a3c9c5198e915e41baca5d79958295a32, can someone create a branch here that the PR could target?

Checklist

[x] Used a fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@conda-forge-admin, please re-render.

Hi! This is the friendly automated conda-forge-webservice.
I tried to re-render for you, but it looks like there was nothing to do.

Hi! This is the friendly automated conda-forge-linting service.
I was trying to look for recipes to lint for you, but it appears we have a merge conflict.
Please try to merge or rebase with the base branch to resolve this conflict.
Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

@conda-forge/r-base Can someone create a branch so that the CI will run again? Updating the build number makes this branch conflicting with master.

Done

You should branch off of 37c7da842b6bc843a1943ed2993a1f1e2322d19e

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

This sadly fails with OpenBLAS problems I'm not aware on how to fix.

@conda-forge/r-base I've incorporated the blas changes from master and now the build passes

The blas changes should be reverted. They were only added to 3.6.1 because they are incompatible with existing R packages.

What should then be done here?

Reverted the BLAS changes and now pinned to the old openblas build. Not really fond about this but hope that works.

Thanks


reporting API

WHAT DOES THIS PR DO?
The API intend to easy reporting for each grid
Example how to run
http://<IP_ADDRESS>:5000/grid/report
{
"grid_id": "64b7ba65d7249f0029fecdbd",
"start_time": "2023-01-01T00:00",
"end_time": "2023-12-30T00:00"
}

[ ] Item 1
[ ] Item 2

WHAT ISSUES ARE RELATED TO THIS PR?

Jira cards

[]

GitHub issues

Closes #

HOW DO I TEST OUT THIS PR?

[x] Analytics: Link to Analytics README
[ ] Auth Service: Link to Auth Service README
[ ] Calibrate: Link to Calibrate README
[ ] Data Proxy: Link to Data Proxy README
[ ] Device Monitoring: Link to Device Monitoring README
[ ] Device Registry: Link to Device Registry README
[ ] Device Status: Link to Device Status README
[ ] Device Uptime: Link to Device Uptime README
[ ] Exceedances: Link to Exceedances README
[ ] Firebase: Link to Firebase README
[ ] GP Model: Link to GP Model README
[ ] Incentives: Link to Incentives README
[ ] Kafka Connectors: Link to Kafka Connectors
[ ] Locate: Link to Locate README
[ ] Metadata: Link to Metadata README
[ ] Predict: Link to Predict README
[ ] Spatial: Link to Spatial
[ ] View: Link to View README
[ ] Workflows: Link to Workflows README

WHICH ENDPOINTS SHOULD BE READY FOR TESTING?:

[ ] Endpoint 1
[ ] Endpoint 2

ARE THERE ANY RELATED PRs?

[ ] Related PR 1
[ ] Related PR 2

ensure the url on line 24 is read from the config file,
-update the naming for the routes as discussed

This was resolved

While the time is local, the GMT should also reflect the local GMT. This is for Lagos and we are on GMT+1

The issue has been resolved instead of GMT it shows +01 for Nigeria +0300 for Uganda


REeplace deprecated method with the correct one

Description
Removed getTotalLength method from assembly info, as it is deprecated and replaced with getRefLength
Use case
After deprecated methods removal, build fails as we use one deprecated method in Assembly.pm
Benefits
Correct endpoint work
Possible Drawbacks
Not found
Testing
No
Changelog
endpoint assembly_info doesn't have "base_pairs" parameter any more.

Changes look fine, field should have been removed a while ago

Travis failures are on variation endpoints and are not related to this change.
Has the Variation team been informed?


Added support for raw/command forwarding

They are implemented as a /raw pseudo-command in tg side and a configurable prefix .tg_ to replace telegram's / prefix at IRC side.
Syntax checks needed since I am too lazy to learn py or to check it.

If this works, users at #archlinucn and #linuxba can play with @PeterCxy's bot.


imageToViewportRectangle not working as expected

I am using OpenSeadragon to view an image and crop regions from it. The cropped regions are stored in a database using their image coordinates (in pixels). I want the cropped images to appear when I reopen the page.
I can add the overlay if I do the following
var overlayElement = document.createElement('div');
overlayElement.id = 'region_box_' + String(region_num);
overlayElement.style.border = "4px solid green";
var rect = new OpenSeadragon.Rect({{region.x}}/viewer.source.width;, {{region.y}}/ viewer.source.height, {{region.width}}/viewer.source.width;, {{region.height}}/viewer.source.height)

viewer.addOverlay(overlayElement, rect);

Is there a better way to do this? I had expected this to work, but it does not transform the coordinates at all so I must be using it incorrectly:
rect = viewer.viewport.imageToViewportRectangle({{region.x}}, {{region.y}}, {{region.width}}, {{region.height}})

may be this help http://openseadragon.github.io/examples/ui-tiledimage-polygon-cropping/
const x1 = region.x , y1 = region.y
const x2 = region.x + region.width , y2 = region.y + region.height
var examples = [
  [ { x: x1, y: y1 }, { x: x2, y: y1 }, { x: x2, y: y2 }, { x: x1, y: y2 } ]
]
var tiledImage = viewer.world.getItemAt(0);
tiledImage.setCroppingPolygons(examples);
viewer.forceRedraw();

That is very interesting - thank you for sharing. I am not currently cropping, but useful to know.
On a related note, viewer.source is null and errors when I view my page in Firefox, but it works in Safari.
Oddly, on some deep zoom images, the boxes are the in the correct position, but for others they are not. Is there a better way to convert from image coordinates to viewer coordinates?

I think you looking for how we convert image coordinate system to OpenSeadragon viewer coordinate system imageToViewportCoordinates

You are completely right. I was trying to use imageToViewportCoordinates the other day and it wasn't working, but now I suspect I just had a typo :)

Happy to know that you resolve the issue!

Correction, the problem is stranger than I thought. The code works in Safari and Chrome, but in Firefox, imageToViewportRectangle and imageToViewportCoordinates just return the values that are passed in (the image coordinates). On top of that, viewer.source is null in Firefox as well. I'm wondering if this has something to do with the viewer not being loaded when the code is executed (I seem to remember an issue like this existing in the past). However, to avoid this, the viewer is loaded first, and then all my calls to it regarding coordinates and adding blocks are in a $(document).ready() block.

Yeah, you'll definitely want to make sure the image is loaded. Put it inside a viewer.addHandler('open', function() { ... }).

Yeah, you'll definitely want to make sure the image is loaded. Put it inside a viewer.addHandler('open', function() { ... }).

That fixed it - thanks!


Fix syntax error in KeyValueType.php

Syntax error causing the bundle to be non functional
Please merge asap.

thanks! I should've checked better before merging the previous one

Thanks alot @Burgov


Layout for Risk History (EXPOSUREAPP-4577)

looking good so far for first version.
could you provide a string res too(or did the process changed)? maybe first version according to ticket or our designtool

looking good so far for first version.
could you provide a string res too(or did the process changed)? maybe first version according to ticket or our designtool

looking good so far for first version.
could you provide a string res too(or did the process changed)? maybe first version according to ticket or our designtool

Yes, currently working on that 👍

looking good so far for first version.
could you provide a string res too(or did the process changed)? maybe first version according to ticket or our designtool

Yes, currently working on that 👍


I can't use /setworld

I can't use /setworld anywhere, i used /help setworld and says "No command called "setworld" found."
i'm the admin of the server

Do not delete the issue template if it's a bug report. I need to know which branch are you using. I can assume you're using master.

yes, i'm using nabBot - master, is this what u need to know?

Any other messages? Any messages on console?
I just tested master branch, and it works fine for me.

i have this problem too, can u help me?

@Prossaicom Please refer to
https://github.com/Galarzaa90/NabBot#requirements
and
https://github.com/Galarzaa90/NabBot#installing-and-running
From what I can see on this error, you are missing the requests python module.

I installed "requests" and now it works fine, thanx everyone :DDD
nice bot, btw


chore(narrow tearsheet header): border bottom fix

Contributes to #2001
Inconsistencies PAL guidance and storybook component narrow tearsheet

What did you change?
Provided border bottom to the header of narrow tearsheet
How did you test and verify your work?
storybook

@elycheea  padding updated. Kindly verify


Investigate not requiring a custom domain

Is it possible to not require a custom domain? Could add a lot of friction to the deployment process.

Getting new users to development, yarn start, as quickly as possible. Production can require a bit more setup


Various optimizations

Applying various (mostly minor) optimizations

avoid initial reference counting for id_type
switch more allocations to use internal_allocator (mostly important for Windows)
avoid memory allocations
fix problem in AGAS resolve_gid
avoid decref handling for purely local components

Improving error message

listing component types in error message of component type instance counter

@sithhell this is fine now as well.

These changes were mostly minor


What went wrong:
Execution failed for task ':camera:compileReleaseJavaWithJavac'.

Compilation failed; see the compiler error output for details.

Follow up https://github.com/flutter/flutter/issues/89578 . After the new version of camera has published, run flutter pub upgrade.


Using roomHint on RequestSync

Hi there!
We're using RequestSync allow the user to add new devices after the initial Sync is done, and we'd like to have those new devices to be added in their correct room.
However, this doesn't happen and, following #112, seems like roomHint only works in the first Sync.
Is there a way to have those newly added devices added to their rooms without needing to unlink and relink again?

From the user's perspective, the devices will show up in their account in an undefined group. From there, they'd have to manually add each new device to a given room in the Home Graph.

Yeah, this is the current behavior.
I was asking if is there a way to have roomHint work for RequestSync too because you can't really ask to an user to manually set rooms for 20+ devices.

Hi @SS-TT, since this is not an issue with the Node.js sample code, I would recommend you file this on our public issue tracker. The behavior you are describing is governed mostly by how the Google Home app responds to the data provided in SYNC (rather than the API surface itself) and we can get it routed to the right people to evaluate there.


Remove --pod-cidr from docs

Follow-up #31667
/kind cleanup
/language en

@reylejano PTAL

Follow up to PR https://github.com/kubernetes/website/pull/31667
The --pod-cidr parameter is deprecated see https://kubernetes.io/docs/reference/command-line-tools-reference/kubelet/
/lgtm

Cancelling my lgtm until a tech review
/remove lgtm

Cancelling my lgtm until a tech review
/lgtm cancel

@kubernetes/sig-node-pr-reviews We're hoping for a tech review of the above so we can move ahead with this PR, thanks muchly

To get reviews from SIG Node people, I have put this PR in the Slack sig-node channel to get more attention: https://kubernetes.slack.com/archives/C0BP8PW9G/p1651041175711359

/lgtm

While the point of the PR to remove --pod-cidr is valid....
The entire page needs a full tech review and update as the contents are out of date.

Can this PR be merged as is--given its limited scope of removing --pod-cidr?
If the rest of the page needs to be updated we should open a new issue to manage that work.

While the point of the PR to remove --pod-cidr is valid....
The entire page needs a full tech review and update as the contents are out of date.

Can this PR be merged as is--given its limited scope of removing --pod-cidr?
If the rest of the page needs to be updated we should open a new issue to manage that work.

IMO yes.

/approve
Thanks everyone!


feat: mapped layout props for view component

Summary
This PR adds mapping for layout props, it maps
marginInlineStart: 'marginStart',
marginInlineEnd: 'marginEnd',
marginBlockStart: 'marginTop',
marginBlockEnd: 'marginBottom',
paddingInlineStart: 'paddingStart',
paddingInlineEnd: 'paddingEnd',
paddingBlockStart: 'paddingTop',
paddingBlockEnd: 'paddingBottom',

as requested on https://github.com/facebook/react-native/issues/34425

Changelog

[General][Added] - Added CSS logical properties by mapping layout props.
Test Plan

<View
  style={[
    {
      marginBlockStart: 5,        // maps to "marginTop"
      borderWidth: 1,
      borderRadius: 5,
      padding: 5,
    }
  ]}>
  <Text style={{fontSize: 11}}>Hello World!</Text>
</View>

What about shorthands? See https://github.com/facebook/react-native/issues/34425#issuecomment-1236664129

What about shorthands? See #34425 (comment)

Hello @necolas, Should we include this props as well?

Yes let's include those too. Thanks

Please can we add unit tests / examples for this?

@mayank-96 could you rebase the PR, please?

Hello @cipolleschi, I'm rebasing it.

Hello @cipolleschi, I have rebased the PR and also shifted the shared code to the stylesheet directory by adding a helper function for mapping as @necolas said. Please check if it is the right way to do so that I can add it for other components as well like Text and TextInput.

There are still a number of issues in this PR that need to be resolved before moving forward: consistency of how the work is done across components, typos in variable names, and unit tests for the processing. It should then be rebased too. Thanks

@mayank-96 please rebase and resolve conflicts again, then @cipolleschi can import it. Thanks!

If you touched the type definitions, remember to update also the typescript types!

@mayank-96 ping

Hello @necolas, sorry I couldn't respond you earlier due to some health issues. I'll rebase this PR today itself.

This patched broke text layout internally and needed to be backed out

Okay, I'll have a look into this.

This PR can't be imported anymore. I've opened a new PR with fixes and tests #35316


[BEAM-13365] [Playground] Add Pipelines options text field to the frontend

I added the pipeline options text field to the frontend. It's the initial version and will be redesigned in the future.
Pipeline options text field accepts value in the format "--key value --key2 value2". Initially, it's equal to the pipeline options from the example.
https://issues.apache.org/jira/browse/BEAM-13365
PR depends on the backend changes from:
https://github.com/apache/beam/pull/16127
https://github.com/apache/beam/pull/16119

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

R: @damondouglas
cc: @pabloem

this needs a rebase @ElessarST

this needs a rebase @ElessarST

Thanks, I will do it after https://github.com/apache/beam/pull/16127 , because this PR depends on it.

sounds good

LGTM


translate persianalphabet to english in sluggable

I use this package on Laravel-5.8 version 4.8 in PHP 7.4 and I follow all instructures and set the method in config/sluggable.php:
'method' => function($string, $separator = '-') {
        $_transliteration = ["/ö|œ/" => "e",
            "/ü/" => "e",
            "/Ä/" => "e",
            "/Ü/" => "e",
            "/Ö/" => "e",
            "/À|Á|Â|Ã|Å|Ǻ|Ā|Ă|Ą|Ǎ/" => "",
            "/à|á|â|ã|å|ǻ|ā|ă|ą|ǎ|ª/" => "",
            "/Ç|Ć|Ĉ|Ċ|Č/" => "",
            "/ç|ć|ĉ|ċ|č/" => "",
            "/Ð|Ď|Đ/" => "",
            "/ð|ď|đ/" => "",
            "/È|É|Ê|Ë|Ē|Ĕ|Ė|Ę|Ě/" => "",
            "/è|é|ê|ë|ē|ĕ|ė|ę|ě/" => "",
            "/Ĝ|Ğ|Ġ|Ģ/" => "",
            "/ĝ|ğ|ġ|ģ/" => "",
            "/Ĥ|Ħ/" => "",
            "/ĥ|ħ/" => "",
            "/Ì|Í|Î|Ï|Ĩ|Ī| Ĭ|Ǐ|Į|İ/" => "",
            "/ì|í|î|ï|ĩ|ī|ĭ|ǐ|į|ı/" => "",
            "/Ĵ/" => "",
            "/ĵ/" => "",
            "/Ķ/" => "",
            "/ķ/" => "",
            "/Ĺ|Ļ|Ľ|Ŀ|Ł/" => "",
            "/ĺ|ļ|ľ|ŀ|ł/" => "",
            "/Ñ|Ń|Ņ|Ň/" => "",
            "/ñ|ń|ņ|ň|ŉ/" => "",
            "/Ò|Ó|Ô|Õ|Ō|Ŏ|Ǒ|Ő|Ơ|Ø|Ǿ/" => "",
            "/ò|ó|ô|õ|ō|ŏ|ǒ|ő|ơ|ø|ǿ|º/" => "",
            "/Ŕ|Ŗ|Ř/" => "",
            "/ŕ|ŗ|ř/" => "",
            "/Ś|Ŝ|Ş|Ș|Š/" => "",
            "/ś|ŝ|ş|ș|š|ſ/" => "",
            "/Ţ|Ț|Ť|Ŧ/" => "",
            "/ţ|ț|ť|ŧ/" => "",
            "/Ù|Ú|Û|Ũ|Ū|Ŭ|Ů|Ű|Ų|Ư|Ǔ|Ǖ|Ǘ|Ǚ|Ǜ/" => "",
            "/ù|ú|û|ũ|ū|ŭ|ů|ű|ų|ư|ǔ|ǖ|ǘ|ǚ|ǜ/" => "",
            "/Ý|Ÿ|Ŷ/" => "",
            "/ý|ÿ|ŷ/" => "",
            "/Ŵ/" => "",
            "/ŵ/" => "",
            "/Ź|Ż|Ž/" => "",
            "/ź|ż|ž/" => "",
            "/Æ|Ǽ/" => "E",
            "/ß/" => "s",
            "/Ĳ/" => "J",
            "/ĳ/" => "j",
            "/Œ/" => "E",
            "/ƒ/" => ""];
        $quotedReplacement = preg_quote($separator, '/');
        $merge = [
            '/[^\s\p{Zs}\p{Ll}\p{Lm}\p{Lo}\p{Lt}\p{Lu}\p{Nd}]/mu' => ' ',
            '/[\s\p{Zs}]+/mu' => $separator,
            sprintf('/^[%s]+|[%s]+$/', $quotedReplacement, $quotedReplacement) => '',
        ];
        $map = $_transliteration + $merge;
        unset($_transliteration);
        return preg_replace(array_keys($map), array_values($map), $string);
    },

SlugMaker model code:
<?php

namespace App;

use Illuminate\Database\Eloquent\Model;
use Cviebrock\EloquentSluggable\Sluggable;

class SlugMaker extends Model
{
    use Sluggable;

    protected $fillable = ['title'];

    /**
     * Return the sluggable configuration array for this model.
     *
     * @return array
     */
    public function sluggable(): array
    {
        return [
            'slug' => [
                'source' => 'title'
            ]
        ];
    }
}

how I use in the controller:
$title = $request->input('title');

        $slug = SlugMaker::create([
            'title' => $title,
        ]);

        return $slug;

my problem is when it creates a slug from the title it translates the Persian alphabet to English, Persian alphabet is the same as the Arabic alphabet
where I did wrong in my code?

Closing due to no response.  Feel free to re-open or comment if you are still having issues.


I'm doing what it is asking

Challenge Use a CSS Class to Style an Element has an issue.
User Agent is: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/50.0.2661.102 Safari/537.36.
Please describe how to reproduce this issue, and include links to screenshots if possible.
My code:

CatPhotoApp

Kitty ipsum dolor sit amet, shed everywhere shed everywhere stretching attack your ankles chase the red dot, hairball run catnip eat the grass sniff.

Please read all the instructions in the left-hand panel.
If you have any further questions, please use the Help button first.

@jhoove4 thanks for the issue but if you get stuck with a challenge, please first ask questions to the Help Room. Happy coding!


Null Object Reference upon starting song

Describe your bug here.
So I have added a new combo counter (following the tutorial from GameBanana), but after that I've had lots of trouble with compiling the game. Now whenever I try to enter a song it gives me a Null Object Reference error saying that something is.. It's not even possibly understandable what does it say.
Error:

Command Prompt/Terminal logs (if existing)
No response
Are you modding a build from source or with Lua?
Source
What is your build target?
Windows
Did you edit anything in this build? If so, mention or summarize your changes.
Yes, I edited PlayState.hx and tried to change the combo counter

Not a bug since you edited the game, check line 1212

Not a bug since you edited the game, check line 1212

Oh, sorry about that. But at line 1212 theres nothing. naeRating is my variable I put for a custom combo counter

Seems like the object doesn't exist

Check to make sure all the assets used in the song exist, (Character's .PNGs, background assets, son on) this happens in both source and lua. As well as check the .JSON of the characters in the song to make sure you didn't misspell anything.


Adding assets2 and moving all external links to the static assets.

Fixes #225
NPM is used to create assets2 in the first place.
If approach is accepted we can use NPM to create all assets.
w3counter tracker is not placed in static assets as this will not work in a disconnected instance

@ianwatsonrh does this break the w3counter functionality ? I understand it won't work in a disconnected environment

@noelo The javascript code injected via https://www.w3counter.com/tracker.js?id=129401 injects code that will send analytic information to the external w3counter api endpoint.
As the analytic requests wont work in a disconnected environment, as they wont be able to hit the w3counter api endpoint, I think its sufficient to also leave this in as an external source.
This will result in a single failure to load the src rather than repeated failures that the endpoint is unreachable during application use

@noelo changed this to merge to disconnected branch

@ianwatsonrh thanks. Much appreciated


setarch: i386: Unrecognized architecture

Trying to run the container I get this error and it exits

Not sure if there's a 'proper' way to have this work but adding --security-opt=seccomp=unconfined to the docker command works.

Thanks for reporting this, and adding a temporary workaround. Can you please just confirm which version of docker you are using, and if you made any changes to the Dockerfile?

I set to use XPRA and GITWATCH other than that no changes.
Docker version 1.12.6, build 78d18021ec

So I have done some research, and discovered that there is something called Seccomp security profiles for Docker (https://docs.docker.com/engine/security/seccomp/). The reason I am unable to reproduce this issue myself is because I run a build of docker that most probably was not built with seccomp.
I discovered this from http://www.bay12forums.com/smf/index.php?topic=145944.245;wap2, which mentions that "personality" is one of the system calls being blocked by default. This page also mentions the same workaround, to add --security-opt=seccomp=unconfined to the docker command.
Right now I can think of two choices:

Document this workaround with an explanation in the README.
Provide my own seccomp profile, based on https://github.com/docker/docker/blob/master/profiles/seccomp/default.json but with changes that permit the system calls required.

Looking at other projects that have run into a similar issue (https://github.com/jlund/docker-chrome-pulseaudio/issues/8, and https://github.com/solita/docker-systemd) we see one of the above choices being used.
Option number 2 to me does not sound feasible in the long term, so for now I think the best option is to document the workaround. Hopefully as this feature becomes more common a better method to enable certain system calls for Dockerfiles turns up.


php artisan make:rule Uppercase --invokable produces The "--invokable" option does not exist.

Laravel Version: 9.17.0
PHP Version: 8.0.2

Description:
Following docs  https://laravel.com/docs/9.x/validation#custom-validation-rules I tried to run:
php artisan make:rule Uppercase --invokable which produces The "--invokable" option does not exist.

9.19.0 Fixes the issue


Would like to add Indexes property in the MetaBuilder class

I am really loving the library. I am using this to generate ORM for ServiceStack.OrmLite and would like to add a string enumeration for Indexes in the MetaBuilder so on my application startup I can not only generate the tables but also the indexes.
I am also willing to submit a pull request.

added PR https://github.com/aeslinger0/sqlsharpener/pull/11. I see that this project has activity done in the last month so it would be great if it can be reviewed and included.


[Feature]: Stats Page - Enable creating a link to a specific season's leaderboard

Feature Summary
Currently the Stats page uses internal data/variables to manage which season is currently selected. It would be better if the selection were managed via a url param, so that you could then copy the url and send it to someone, bringing them directly to the season you were looking at when you copied the url.
Detailed Description
Notice how these two seasons both have the same url: https://cuttle.cards/#/stats

If you send someone the url https://cuttle.cards/#/stats, they will always be brought to the latest season. It would be better if you could specifically link someone to the Spades 2022 season with a url like https://www.cuttle.cards/#/stats?seasonIndex=3
This season index should be loaded from the url when the page is created, and it should be updated whenever the dropdown is used to select another season. All of the changes should be doable using only src/client/js/views/Stats.vue

@itsalaidbacklife I'll attempt to look into this!

Working on this!


[itbit] properly cast List of open orders to Array

Previous code was causing a ClassCastException.

What's wrong with orders.toArray(new ItBitOrder[orders.size()]) ?

I don't see anything wrong with that approach. Honestly I'm not familiar
enough with the internals of ArrayList or Arrays to know which is more
efficient at copying the List to an array, but I would think they perform
similarly - please correct me if I am wrong. My understanding is that both
methods will iterate the List and copy to a typed array with the specified
size.
On Mon, Aug 24, 2015 at 12:43 AM, Rafał Krupiński<EMAIL_ADDRESS>wrote:

What's wrong with orders.toArray(new ItBitOrder[orders.size()]) ?
—
Reply to this email directly or view it on GitHub
https://github.com/timmolter/XChange/pull/1050#issuecomment-134075476.


aling buttons

Related Issue
[Cite any related issue(s) this pull request addresses. If none, simply state "None”]
@Suchitra-Sahoo
Feat: Redesing cart #1162
close #1162
Description
[Please include a brief description of the changes or features added]

added cart ui and make it fully functionals

Type of PR

[ ] Bug fix
[x] Feature enhancement
[ ] Documentation update
[ ] Other (specify): _______________

Screenshots / videos (if applicable)
[Attach any relevant screenshots or videos demonstrating the changes]

Checklist:

[x] I have performed a self-review of my code
[x] I have read and followed the Contribution Guidelines.
[x] I have tested the changes thoroughly before submitting this pull request.
[x] I have provided relevant issue numbers, screenshots, and videos after making the changes.
[x] I have commented my code, particularly in hard-to-understand areas.

Additional context:
[Include any additional information or context that might be helpful for reviewers.]

@Suchitra-Sahoo
i fetched upstream and aling quantity buttons
please add level 3 and merge it

@Suchitra-Sahoo
I request you
Please check this and merge it
And give level 3
I completed my task as you said

@Suchitra-Sahoo
kindly please check this and merge it
if you think my code is good enough to get level 3
please assign it

The alignment issue is resolve but the checkout option is still working even if there is no products in cart. Also I asked to apply some style on increase and decrease button.


Invalid reply URL for hard-coded Application ID

Describe the bug
Invalid reply URL when trying to log in through the Docker container.  The "Running In Docker" steps do mention needing to map a data directory for a SQLite database but they don't note what that directory in the container is.  Is it /app?
To Reproduce
Steps to reproduce the behavior:
As far as I can tell, it's as simple as "create a Docker container following https://github.com/isaacrlevin/PresenceLight/blob/main/worker-README.md#running-in-docker.  Whatever Reply URLs are configured in the default Application likely won't match my domain.
Expected behavior
I would expect to be able to log in and start configuring PresenceLight.
Screenshots

Further details

OS: [e.g. iOS]
PresenceLight App Type (Desktop, Blazor) Docker
PresenceLight Build (Nightly, Store, etc) Latest
PresenceLight Version (The # in About) Unable to access application.
Did you clear settings.json? (C:\Users\username\AppData\Local\Packages\37828IsaacLevin.197278F15330A.SomeValue\LocalState\settings.json  It's a Docker container, settings clear on startup.
ASP.NET Core version Development

That is a known issue with AAD, you can't have wildcard or dynamic redirect uris. The IP for my instance is <IP_ADDRESS>. There is no db in this project so I'm guessing I copy pasted the wrong thing.
I will update the Readme to account for those 2 points. If you use the above IP it will work.

That is a known issue with AAD, you can't have wildcard or dynamic redirect uris. The IP for my instance is <IP_ADDRESS>. There is no db in this project so I'm guessing I copy pasted the wrong thing.
I will update the Readme to account for those 2 points. If you use the above IP it will work.

Would it be possible to expose a directory that I can mount to persistent storage in which I can configure AAD using my own application registration?

Would it be possible to expose a directory that I can mount to persistent storage in which I can configure AAD using my own application registration?

After plugging away at this, you can totally map specific files from persistent storage to a location inside the Docker container, and this works well enough.
In Unraid it looks like this:

This allowed me to define my own Application in Azure to use my own reply URL.

After plugging away at this, you can totally map specific files from persistent storage to a location inside the Docker container, and this works well enough.
In Unraid it looks like this:

This allowed me to define my own Application in Azure to use my own reply URL.

Cool, I was going to mention you can mount the appsettings.json directly. Glad you got it working :)

Cool, I was going to mention you can mount the appsettings.json directly. Glad you got it working :)


Fix NavigationMenuPopover component that override bottom  Navigation component

Description
When you click the burger button in top-right of page, you can see the popup of NavigationMenuPopover component. The problem appear when you open the page with the small phone like Iphone 5.

Expected Behaviour
The NavigationMenuPopover doesn't not override bottom Navigation component. Maybe better make NavigationMenuPopover scrollable.
Additional Information

@all-contributors please add @albarranaufala for bug

Is this up for grabs? Maybe I can help this one.


Stopped working in messages

typing in an emoji that doesn't appear in shortcuts breaks Macmoji .
Steps to reproduce:

type ":pear:"  in messages on Mac
delete pear and then type ":phone:"
delete phone and type ":pear:"     again

Interesting… I have noticed weird behavior like this before unfortunately 😞
My theory is that it has to do with the auto-correct system trying to get out of your way when it thinks you're repeatedly trying to correct it.
Closing for now since Macmoji itself isn't involved. Have you checked out Rocket yet? Might be a more robust solution for you!


Revamp prototype features and transforms

This PR is a large overhaul of what we currently have for prototype features and transforms. For larger changes, individual PRs were send to this branch.

This PR reimplements the New Transforms API and is the result of offline discussions with @pmeier and @vfdev-5. It's not the final adopted solution but the latest candidate. More ideas will be discussed soon.
Here I summarize the main point of this solution:

There are 2 types of kernels. The high-level ones (such as resize()) which can handle all types of input and the low-level ones (such as resize_image())  which handle specific types.
High-level kernels are located here. They receive inputs of various types (such Image, BoundingBox etc) and are responsible for dispatching to the correct low-level kernel by using the rich meta-data available on the custom types. Usually they are a thin layer that mostly maps types to operations but sometimes additional massaging is required prior calling the low-level kernel. High-level kernels are not JIT-scriptable.
Low-level kernels are located here. They are specialized for each type of input and operate on raw PyTorch Tensors (or PIL Images) and thus they require passing to them all the necessary meta-data required to perform the calculations. The low-level kernels are JIT-scriptable and can be used by downstream libraries without requiring using the proposed Feature types of TorchVision.
The dispatching is currently performed a simple annotation mechanism. This targets to remove most of the boilerplate code for 90% of simple cases that just map an input to a kernel. Thus in most cases, the main body of the high-level kernel is omitted. Nevertheless, there are some cases where extra massaging is needed for specific types. When this is needed, we pass None to the mapping and the actual handling of the dispatch happens on the body of the kernel.
It's worth noting that kernels of the same operation (such as resize) might require different input parameters for different types (example 1 vs 2). Thus currently, the dispatcher just receives args/kwargs and forwards them to the low-level kernels. Occasionally we enhance these parameters with available meta-data to avoid explicitly requiring them (TBD if overwriting meta-data will be allowed). In the documentation, we link to the low-level kernels to show which parameters are needed for the operation.


Update Composer dependencies (2023-04-08-00-12)

Visual regression test passed!
View the visual regression test report


Use no-cors mode for fetching link-meta

I don't have the full build pipeline installed to test this, but this should fix the "Failed to fetch link" errors currently experienced when embedding most links in the web app.

👋 I already have a PR open for this https://github.com/bluesky-social/social-app/pull/716

FWIW this was tried and doesn't solve it. The fix in #716 is to introduce a proxy


pfm_default value is used when the value is left empty in ProfileCreator

If the profile manifest has a pfm_default value set for a key and I attempt to leave the value empty in ProfileCreator, the resulting Configuration Profile's XML shows the pfm_default value instead of being empty. I believe the GUI should be respected over the pfm_value.

@bp88 Can you give an example?  what's the pfm_type of the preference?  I've tried a couple different ones but can't produce.


Add Dasan Hangang Middle School

Dasan Hangang Middle School

Website: dshangang.ms.kr
Address: (12284) 20, Dasanjigeum-ro 145beon-gil, Namyangju-si, Gyeonggi-do, Republic of Korea

@cog25 Please provide us with a proof, which shows that the school recognizes the domain you are submitting as an official email domain for the students.
You can provide us with any of the following:

A copy of instruction (a hard-copy or electronic one) given to you by the school that tells you to use an email address in this email domain
An URL of a page at the official school website that says that students use this email domain
A reference to a recognized journal where an article was published by someone from the school, with explicit affiliation to the school, and e-mail address from the email domain
A WHOIS data that link the email domain to the school somehow
A copy of official letter from the school representative saying that the school provides e-mail addresses in this domain to the students
Anything else that can prove this fact in similar way, i.e. can be verified independently.

@philipto https://who.is/whois/goe.go.kr shows this domain's owner is GYEONGGI office of education.
Our school's address includes gyeonggi(-do).
Also, this article shows only students(or theachers) can use it(checked by school's IT manager).

@philipto  I think this case is same as #12132.

@cog25 Thank you very much for the clarification. You are correct. Pull request merged.


Making save_to_well_known_file() save with 0600 permission.

Fixes #144.
H/T to http://stackoverflow.com/a/5624691/1068170 and
http://stackoverflow.com/a/5337329/1068170

Coverage increased (+0.05%) to 64.73% when pulling ebcf57ca12bbb458a09398abe19e2278a281caa6 on dhermes:fix-144 into fd054dcdcc5f6a4d3a0b7a29f410f415f342044c on google:master.

LGTM.
Do you need someone to pull this request in?

Yes I don't have merge privileges. But the build failed
https://travis-ci.org/google/oauth2client/jobs/55736796
I need to update so that the correct octal syntax is used for Python 3: 0o0600

@anthmgoogle I just updated the PR with the fix.
Waiting on new build: https://travis-ci.org/google/oauth2client/builds/55836779

There is a manual test step that should be done here also:

Take a sample using the get_application_default auth feature to call a Google API.
Use the Google Cloud SDK and run gcloud_auth_login and confirm the prompt.
Verify that this enables the sample to work. It should pick up the credential file saved gcloud auth login.
Patch this change into the copy of this code in the Cloud SDK.
Repeat steps 2-3 to verify there is no regression.

Good call! I discovered it doesn't over-write permissions of an existing file. Will update and create a corresponding unit test.

@anthmgoogle I edited the version of oauth2client.client in the SDK and confirmed this all works as expected. New unit test and code change in the second commit just pushed.

Coverage increased (+0.11%) to 64.8% when pulling f40f97c38c0fd54d84561f662bfa2143532e1b2a on dhermes:fix-144 into fd054dcdcc5f6a4d3a0b7a29f410f415f342044c on google:master.

Coverage increased (+0.11%) to 64.8% when pulling f40f97c38c0fd54d84561f662bfa2143532e1b2a on dhermes:fix-144 into fd054dcdcc5f6a4d3a0b7a29f410f415f342044c on google:master.

Revision LGTM.

Great @craigcitro care to merge?

@dhermes Squash commits? It's not clear why there should be two commits for this change; it looks like it's only an artifact of the trajectory this code took through review.

SGTM @nathanielmanistaatgoogle
I like the way you think! (I try to be the "fewer commits" stickler, but usually get shot down.)

Coverage increased (+0.11%) to 64.8% when pulling 21c24584792fe7a4ca5b4c753658de966a39d4f9 on dhermes:fix-144 into f79c2cd301fd49489c41ca1158cb09e0af4ad191 on google:master.


Fixed test_folders test to check for new folders in repository

Changed from set difference to set symmetric difference. Test will now fail if there are more folders in the repository than listed in the expected_dirs variable.

Thanks @ESKYoung. I'm actually rewriting the test suite in #162 right now where direct list comparisons in pytest give symmetric difference. Good catch though. Closing for now.


Fix for Chat2

Idk if it was the right way of doing it, but it does fix the issue in #19.

Thank you~


Update language-r.cson

I made few corrections

This package is no longer maintained. All issues and PRs have been and will be closed. This is remaining published in the Atom package repository so that people can find it to fork it and create their own version. Hopefully one of them will create a new maintained version.


eslint import/named complains about your named exports

import { Bar } from 'react-chartjs-2';

$ npm list react-chartjs-2
└──<EMAIL_ADDRESS>
$ eslint imports/modules/Stats/components/HeroLineBarChart.js

.../imports/modules/Stats/components/HeroLineBarChart.js
  9:10  error  Bar not found in 'react-chartjs-2'  import/named

I don't see any obvious problem, looking at your code, but thought you should know about this lint/import complaint...

hey @zeroasterisk ,
Thanks for reaching out, will check this one.
Despite the eslint throwing, you are able to use the lib right?
Thanks,

Are you using https://github.com/benmosher/eslint-plugin-import for import/named rule?

Yes, it is working correctly, no problems aside from linter.
I am using that esling plugin, and it's working correctly for my many other packages and local files

@zeroasterisk Is this still considered a open issue? Thanks!

@zeroasterisk for now I'm closing this. Feel free to reopen if the problem persists.

sorry - I wasn't keeping up on emails - I'm not using this project currently so I don't know - therfore closing is fine - thanks!


Handbook/Hubspot: G-mail extension content update

Description
To make it easier for our contacts to book meetings with our sales team, I've added steps to streamline the process by leveraging the HubSpot extension for Gmail.
Related Issue(s)

Checklist

[x] I have read the contribution guidelines
[x] I have considered the performance impact of these changes
[ ] Suitable unit/system level tests have been added and they pass
[ ] Documentation has been updated

Thanks @Yndira-E, looks good. I'll let the sales team merge!


deny disabling security hub

This SCP prevents users or roles in any affected account from disabling AWS Security Hub, deleting member accounts or disassociating an account from a master Security Hub account.
https://jira.schubergphilis.com/browse/CCV-162

LGTM, have you tested this out in the gct-am landing zone?

LGTM, have you tested this out in the gct-am landing zone?

Yes I have and figured we might need to add an additional policy as well to deny disabling standards.


Added subcommand feature.

FYI: For people who want to use subcommand feature (or zsh/bash completion generator), you can try CLIFramework https://github.com/c9s/CLIFramework

-1 As the user can easily implement this in their application by handling routing for sub commands I don't think this is something with a high priority.
$filename = array_shift($argv);
$subcommand = array_shift($argv);

switch($subcommand) {
    case 'command1':
        array_unshift($argv, "{$filename} {$subcommand}");
        $cmd = new Commando\Command($argv);
    .... etc.


Update bulk OpenNeuro annotations following Neurobagel vocab changes

Relevant vocab-related changes
Namespace used for healthy controls/subject groups (JSON)

https://github.com/neurobagel/api/issues/180
https://github.com/neurobagel/bagel-cli/issues/139
https://github.com/neurobagel/documentation/issues/87

Age heuristics (JSON)

https://github.com/neurobagel/bagel-cli/issues/128

Incorporation of nb term vocabulary (graph database)

https://github.com/neurobagel/api/issues/186

Steps to perform update

[x] Replace outdated TermURLs (for healthy control, age transformations) in all JSON files in https://github.com/neurobagel/openneuro-annotations

[x] purl:NCIT_C94342 -> ncit:C94342
[x] nb:{float,int,euro,bounded,iso8061} -> nb:{FromFloat,FromInt,FromEuro,FromBounded,FromISO8061}

note: no instances of nb:iso8061

[x] Fetch changes from upstream repos into OpenNeuroDatasets-JSONLD forks, and push the updated JSONs to the forks (😬)
[x] Manually push updated JSONs to OpenNeuroDatasets-JSONLD repos for datasets that did not succeed the fork update

this was done using https://github.com/OpenNeuroDatasets-JSONLD/.github/blob/main/code/update_json to preserve original indentation of participant.json files

[x] Rerun the CLI on the updated JSONs and regenerate JSONLD files

[x] Ensure filepaths are from dataset root (included in https://github.com/neurobagel/bulk_annotations/pull/35)
[x] Log IDs of failed datasets and compare to JSONLDs currently in https://github.com/neurobagel/openneuro-annotations

[x] Update JSONLDs in https://github.com/neurobagel/openneuro-annotations

[ ] https://github.com/neurobagel/openneuro-annotations/pull/6)

[x] Update data in ON graph

For reviewer:
You can check the changes to the open_neuro:

A participant-level query for healthy controls should now return a non-empty list
A GET request to the /attributes/{data_element_URI} endpoint should still return a list of the instances used in the graph (since the vocabulary file has been added back to the graph after clearing it for the data update)
Sending a SPARQL query using Stardog Studio for the number of datasets in the graph should return 340:

SELECT (COUNT(*) as ?datasets)
WHERE {
    SELECT DISTINCT ?dataset
    WHERE {
        ?dataset a nb:Dataset;
                nb:hasLabel ?dataset_name
    }
}

Note that while 341/441 total ON datasets succeeded the CLI step (with manual help in the case of 1 dataset) and had JSONLD files generated, only 340 were successfully uploaded because one JSONLD (ds002000) had NaN values for age which cannot be parsed. This is due to the JSON for this dataset not including "NaN" in the missing values for age, and the CLI then converting that to a float value -> nan.

This is due to the JSON for this dataset not including "NaN" in the missing values for age, and the CLI then converting that to a float value -> nan.

Would it make sense to just add this value to the hard-coded default missing values here: https://github.com/neurobagel/bulk_annotations/blob/313447e642324684a3e2e39d2f35a7661206653d/process_annotation_to_dict.py#L105

One more question @alyssadai: is the new graph already live for the openneuro API? If I'm running an empty query through the query tool I get 334 datasets, 16206 subjects which might be the old number, but I cannot recall exactly

Hey @surchs,

Would it make sense to just add this value to the hard-coded default missing values here: https://github.com/neurobagel/bulk_annotations/blob/313447e642324684a3e2e39d2f35a7661206653d/process_annotation_to_dict.py#L105

I think that looks right. If I understand/remember the code correctly the other function with hardcoded missing values get_missing in that script is for handling the discrete columns, right? So I think the function you indicated would be the right spot to address the current issue.

is the new graph already live for the openneuro API? If I'm running an empty query through the query tool I get 334 datasets, 16206 subjects

Yes, the live graph contains the updated OpenNeuro data. You can also confirm this by querying for healthy controls - previously this would have returned nothing since the in-graph TermURLs for healthy control were out of date with our other tools.
I think we ran into this issue previously of not all datasets/subjects in the graph being returned in an empty query. I’ll investigate this again tmrw but I think our hypothesis last time was that the current query sent by the API assumes there's at least one session per subject in each dataset, but subjects with only phenotypic data currently don't have sessions due to our data model. As a result, it’s possible that datasets with subjects who have imaging data that can’t be modelled somehow just never match any API query to the graph (?).
TLDR, I think this is a problem with our query template in the API rather than those “missing” datasets not actually being in the graph. You can confirm this also by running a simple query to count the datasets in the graph in Stardog Studio, which should return 340.

That sounds reasonable as an explanation. I would say we close this issue here and then

[ ] make a new issue to investigate / reproduce and fix the issue of fewer than expected datasets being returned
[ ] Make a note of the one dataset with nan that we couldn't process. We can then check whether we're about to correctly handle the missing values with the annotation tool.

I think it makes more sense to address the missing values like this instead of adding more workarounds a I initially suggested.
Could you create the new tracking issue for the #dataset mismatch and then close?


Is the Zero 2 W supported?

Hello,
so the PI's are really scarce right now here in good ol Germany. I have only a Rasperry PI 2 W. Am I wrong or could I use this instead of the 3? Because they have the same Cortex-A53 64-bit, right?

Never tested it on one, but looks like it should work, at least CPU wise. I don’t know if they changed anything in the address map.
It seems to have only 512 MiB DRAM. From the top of my head I can’t remember right now if I made any assumptions about DRAM size somewhere.
Give it a try with the rpi3 BSP.


Error functions for general std::vector types

Summary:
We need error functions for general std::vector types.
Description:
Currently, we don't have check functions that can be called directly on
*std::vector<Eigen::Matrix<T_s, R, C> >
*std::vector<std::vector<T_s> >
For example, it isn't possible to do:
void foo(const std::vector<Eigen::MatrixXd>& x) {
  check_not_nan(x);
}

Instead, we need to loop through the vector and call check on each element:
void foo(const std::vector<Eigen::MatrixXd>& x) {
  for (size_t i = 0; i < x.size(); ++i)
    check_not_nan(x[i]);
}

This makes the exceptions that are thrown by the element-wise checks inscrutable because the index of the vector is lost to the exception.
Current Version:
v2.11.0

If you create an issue, please add labels, milestone and assignee.  Thanks.  I added them for this one.

Thanks, Bob. Sorry about that.

There are examples already of functions that test vectors that we can follow to extend the ones that aren't defined for vectors yet.  We should really extend all of our error functions to work componentwise on containers of all types.  A recursive template pattern should be able to generalize to all of our containers following the pattern we used for vectorizing scalar functions.  Somehow we need to figure out how to make the error messages lazy, though, because it'd be too expensive to start passing down strings that get constructed every time we test bounds.

See #366 for a related issue.


Show on App Launch: Fix no option selected on rotation

Task/Issue URL: https://app.asana.com/0/1207908166761516/1208637287651029/f
Description
Steps to test this PR
Feature 1

[ ]
[ ]

UI changes

Before
After

!(Upload before screenshot)
(Upload after screenshot)

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#5200  👈
#4944 : 3 other dependent PRs (#4946 , #5050 , #5127 )
develop

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @mikescamell and the rest of your teammates on  Graphite


Add TREC-COVID round 4 baselines

generate_round4_baselines.py for generating the runs.
generate_round3_baselines.py for generating the r3 runs.

I'm aware of code duplication being an issue, but I wanted to get the scripts written first - we can circle back and refactor later.
@rodrigonogueira4 @ronakice @x65han can you actually run the script and check?

I will do!

I will until one more verification, either @x65han or @rodrigonogueira4 and then merge.

Verified!


p2p: Add function call abstraction for events

Add abstraction over channels
let (tx, rx) = oneshot::channel();
self.tx_swarm
    .send(event::SwarmEvent::AdjustPeerScore(peer_id, score, tx))
    .await
    .map_err(P2pError::from)?;
let _ = rx.await.map_err(P2pError::from)?;

becomes
match swarm_sender.adjust_peer_score(1, 100).await? {
    Ok(res) => {},
    Err(err) => println!("failed to adjust score: {:?}", err),
}

TODO:

add tracing(?)

This seems to be dead. Any benefit from pursuing this?

I'm thinking that the proc-macro is an overkill here.


Update Export-SPAccessServicesDatabase.md

Filled in place holders and created example.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

sharepoint/sharepoint-ps/sharepoint-server/Export-SPAccessServicesDatabase.md
:white_check_mark:Succeeded
View (sharepoint-ps)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

sharepoint/sharepoint-ps/sharepoint-server/Export-SPAccessServicesDatabase.md
:white_check_mark:Succeeded
View (sharepoint-ps)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

sharepoint/sharepoint-ps/sharepoint-server/Export-SPAccessServicesDatabase.md
:white_check_mark:Succeeded
View (sharepoint-ps)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


H3 interop fixes

Fixes needed to get better results at interop, along with some tooling and tracing.

LGTM (pending test fixes).

I think this is ready now.


Load one page at a time

Initial market data load is gumming up the works.  Only load 1 page of markets at a time to speed it up.

Speedy loading in 215f12f7699fc29290ee481edfaaefd61040c15e.


Contacts and PhysicsDirectBodyState3D

Two changes to PhysicsDirectBodyState3D and some associated classes. Both related to the way contact information is stored and passed to the scripting language.
The first modification makes it possible to compute the impact velocity at the time of contact.  For that both the velocity of the state object as well as the collider at the point and time of contact are needed.  Velocities can be obtained in "on_body_entered()", but these are after collision has been resolved and don't reflect the velocities at the moment of impact.
The original "get_contact_collider_velocity_at_position()" method was returning not the velocity of the collider, but the velocity of the state body. This method was changed to return the collider's velocity, and a new method "get_contact_local_velocity_at_position()" was added to return the velocity of the state object.  Changes were made to the contact structure to store the new velocity.  With these changes the impact velocity (or speed in this case) can be computed as:
var state = PhysicsServer3D.body_get_direct_state(self)
...
var vel1 = state.get_contact_local_velocity_at_position(i)
var vel2 = state.get_contact_collider_velocity_at_position(i)
vat normal = state.get_contact_local_normal()
var contact_speed = normal.dot(vel1 - vel2)

Anyone relying on the previous behavior of "get_contact_collider_velocity_at_position()" would have to switch to the new method.
The second changes the values returned by "get_contact_local_position()" and "get_contact_collider_local_position()".  The physics engine resolves collisions in world space relative to the A body in a GodotBodyPair3D pair. Body B is oriented in world space but translated relative to body A.  Contact information was stored in this A relative space and body_B's contact position was always in this space. These values were being returned as is, which is incorrect half the time.  The state objects contacts are mirror's (almost) of each other, so if your object was body B in the pair, then your contact position would be in the wrong space. If you were body A in a pair, then the collider's position would be in the wrong space.

# Works fine if state body is body_A in the body pair, but returns an incorrect value if this contact was body_B
var pos = state.get_contact_local_position(i)

# Same here, works half the time.
var pos = state.get_contact_collision_position(i)

This change amends the contacts to always store and return positions relative to their respective objects.
Bugsquad edit: This closes https://github.com/godotengine/godot-proposals/issues/4184.
Physics squad edit: Fixes https://github.com/godotengine/godot/issues/75803.

Thanks for opening a pull request :slightly_smiling_face:
Feature pull requests should be associated to a feature proposal to justify the need for implementing the feature in Godot core. Please open a proposal on the Godot proposals repository (and link to this pull request in the proposal's body).

Could you please make a separate PR with only the bugfix for get_contact_local_position and get_contact_collider_position in Godot Physics? In general we prefer each PR to do one thing, and bugfixes are easier to get merged than feature proposals. (When the bugfix PR is merged, the feature proposal PR can be rebased on top of it.)

I dont know much about this stuff myself. I am struggling with get_contact_local_postion() and a google search lead me here. From what I understand you fixed the function. What Id like to know is how can I impliment the fix.
On that topic, I did some reading on whatever you wrote and I was looking at the code there by [Contact collider pos now relative to it's origin]. I see on line 363 and 367 (the new). It says: "if (B->can_report_contacts())" on both lines. I would imagine one of those lines should be "if (A...". Idk, just something I noticed. Sorry for back etiquette. I dont actually know anything about github. just created account to ask this.

@rburing I’m out of town for until the end of the week, but could look at a new PR then. After perusing the docs more carefully, I think the implementation of “ get_contact_collider_velocity_at_position()” is actually a bug and so this change does not break compatibility.  The only new feature being propose is the new function “ get_contact_velocity_at_position()”
@chabi211 I’ll take a look at the code you mentioned when I get back. A separate PR with the just the local position fixes should be easier for you to merge in.

Was using contact reporting in 3.5 and am probably experiencing this mirrored 50% of the time bug. Same object already in the scene reporting opposite collision points vs that object instanced. Could be they spawn as body B in the pair instead of A.

Import comment here for this PR. So I tried to take the changes and apply them to 3.5 without the added velocity feature, and I found a bug in the proposed reporting fix.
In godot_body_pair_3d.cpp on line 363 in the updated code, it should test A if it can report contacts. Instead it tests B twice and A never reports. So when I tried the changes as is it fixed 1/2 of the problem. Changing line 363 to
if (A->can_report_contacts()) {
accomplishes the fix.
I'm using Godot 3.5 and now my stuff is working. I hope you guys get this resolved!

@evanrinehart Thanks for catching that

This issues seems to be fixed but is awaiting review?
Just wanted to add the following:
When a collision occurs two contacts will be reported, one for each collider. The first contact gets reported correct, the second one seems to get a copy of that contact but does not translate the position into its own location. The contact normal does work correctly.
So, exact half of all contacts get the wrong positions.
bang.zip
Would love to see this fixed but im not the c++ guy and i dont know if i can help with the needed review.

@D2klass, I need to address the can_report_contacts() error first and we'll see after that. Rburing suggested I split the PR up into bug fixes vs. the new feature.  Probably what I should have done to start with, but I just don't have time to work on this at the moment. If I get time I'll fix the contacts and re-post but unfortunately godot is on the backburner at the moment.

Updated to the latest version of the main branch and corrected issues related to that. Also fixed the error found by evanrinehart.

Still using a hacked version of 3.5 with the fix for this bug, which as I understand it still exists in godot 4. I hope it doesn't get forgotten now that it's over a year later and godot 4 is getting a lot of work.

@evanrinehart From a brief test it looks like this PR still fixes a bug.
I think the method get_contact_velocity_at_position should be renamed get_contact_local_velocity_at_position, so that we have all the get_contact_local_* methods with the same prefix, similar to get_contact_collider_*.
(IMHO the _at_position suffix is a bit verbose, but to preserve compatibility we can keep it for now.)
I think it's okay to put the new method and the bugfix in this same PR. @tgift could you please rebase?

I'll try to bring the PR up to date this weekend and I'll look at the possible name change. Will have to refresh my memory on all of this.

Rebased and conflicts resolved. @rburing I looked at the function names and you are correct. I renamed "get_contact_velocity_at_position" to "get_contact_local_velocity_at_position" to be more consistent.

Thanks @tgift, the changes look great now.  Only information about the final version of the commit is relevant. After that it will be ready to merge.

Thanks!

Yay! No more hacks needed for damage on collision <3


Removed duplicate Morale Boost method

@wchill
https://github.com/wchill/steamSummerMinigame/blob/master/autoPlay.js#L528-575
It came back as it is still in there :/

LOL, I'll deal with it later


Changing the reserved word row to row1 to avoid conflict

Closes sap/fundamental#
[HDBProcedure] Reserved word row #1288
New
While intercepting files during migration we change the reserved word row to row1

Isn't this a limitation of the parser and if it is, shouldn't the grammar be changed instead of the application code?

Isn't this a limitation of the parser and if it is, shouldn't the grammar be changed instead of the application code?

As discussed offline with @SAtanasovv , we would extend the grammar at a later point if necessary


generate css classes for highlightjs support

This PR adds the plugin markdown-it-highlightjs to the mix, which just adds some additional CSS classes to code blocks.
With this change, including the highlightjs script + css will make code blocks pretty.
Including these two lines in the header and/or footer will make things pretty (this would need to be done manually by the user in their header/footer):
<link rel="stylesheet" href="//cdnjs.cloudflare.com/ajax/libs/highlight.js/8.6/styles/default.min.css">
<script src="//cdnjs.cloudflare.com/ajax/libs/highlight.js/8.6/highlight.min.js"></script>

I thought about exposing this as another option, but it seems useful for all (and fairly inert if folks don't care about adding the highlightjs script).
What do you think?

hmm @ngoldman you're not watching this repo anymore? :(

@Flet woops! didn't catch this for some reason. lgtm :+1:


Tests and thread safety

Tests for web package.
Tests are now run with the -race flag for detecting race conditions.
Job struct now has a mutex for avoiding race conditions.
Top level tonic tests for setting logger and running a simple action and getting the messages out of the job.

The coverage still isn't very high, but we're getting there.

Sorry about that.  Bad push.  This PR should be left alone.  There's some other tests being written, but that's in progress and will come in a separate PR.


status: 403 Forbidden: authentication failed

status 403...  id and pass works via unifi UI.  I suspect this is an issue with udmse? Thoughts? unifi ver 3..0.13

date
stream
content

2023-01-11T23:06:02.791975244Z
stdout
2023/01/11 23:06:02.791679 logger.go:27: [ERROR] metric fetch for InfluxDB failed: re-authenticating to https://<IP_ADDRESS>: unifi controller: (user: unifipoller): https://<IP_ADDRESS>/api/auth/login (status: 403 Forbidden): authentication failed

2023-01-11T23:06:02.791821824Z
stdout
2023/01/11 23:06:02.791627 updateweb.go:213: [DEBUG] Requested https://<IP_ADDRESS>/api/auth/login: elapsed 429ms, returned 102 bytes

2023-01-11T23:06:02.362883999Z
stdout
2023/01/11 23:06:02.362602 updateweb.go:213: [DEBUG] Requesting https://<IP_ADDRESS>/api/auth/login, with params: true, cookies: 0

2023-01-11T23:06:02.362741309Z
stdout
2023/01/11 23:06:02.362520 updateweb.go:213: [DEBUG] Using NEW UniFi controller API paths for https://<IP_ADDRESS>/

2023-01-11T23:06:02.306091261Z
stdout
2023/01/11 23:06:02.305167 updateweb.go:213: [DEBUG] Requesting https://<IP_ADDRESS>/ to determine API paths

2023-01-11T23:06:02.305551141Z
stdout
2023/01/11 23:06:02.305117 updateweb.go:193: [INFO] Re-authenticating to UniFi Controller: https://<IP_ADDRESS>

The first log line there indicates invalid credentials. The 405 you are getting is because the browser will always perform a GET, it’s a POST, hence the 405 (method not allowed).
The 403 is saying the credentials aren’t valid, so I’d start there

Sorry for being slow.  The creds are valid as I've used it to log in.  This setup was using docker in synology but if i use the same exact credsafter creating a linux VM on synology it worked.  Not sure what the difference is here

It's a local account.  I didn't make any changes to the acct, just spun up unpoller on the vm, put the creds in and it worked right away.  I honestly don't know what the differences was. Same pw, same userid

I feel like there is some rate limiting at play here....


Add Multiple Inline Items to Paragraph element crash app

Describe the bug
i want to add multiple inline items to Paragraph element, but i get error
Paragraph currentParagraph = new Paragraph();
            var listviewItems = quranListView.Items;
            foreach (var item in listviewItems)
            {
                var container = quranListView.ContainerFromItem(item) as ListViewItem;
                var richTextBlock = container.ContentTemplateRoot as RichTextBlock;
                var paragraph = (Paragraph) richTextBlock.Blocks?.FirstOrDefault();
                foreach (var inlineItem in paragraph.Inlines)
                {
                    currentParagraph.Inlines.Add(inlineItem);
                }
            }

but if use

Steps to reproduce the bug
1.Create a new WinUI 3 app
2.create a listview with datatemplate
3. put richtextblock with paragraph and inline items
4. get listview items and find paragraph from datatemplate
5. try to add inline items to a new paragraph element
Expected behavior
No response
Screenshots
No response
NuGet package version
1.1.1
Packaging type
Packaged (MSIX)
Windows version
Windows 11 version 21H2 (22000)
IDE
Visual Studio 2022
Additional context
No response

Just prevent closure

This is expected behavior.  The error being raised is actually AG_E_MANAGED_ELEMENT_ASSOCIATED which means that the element you are attempting to add to a parent, is already parented to a different element.  In this example, an Inline element is being retrieved from one paragraph and then an attempt is to add it into another.
There are two ways you might get around this.
The first is to remove the item from first paragraph before trying to add it to the new paragraph:
         while (paragraph.Inlines().Size())
         {
             auto inlineItem = paragraph.Inlines().GetAt(0);
             paragraph.Inlines().RemoveAt(0);
             currentParagraph.Inlines().Append(inlineItem);
         }

And the second is to duplicate the item:
         foreach(var inlineItem in paragraph.Inlines)
         {
            auto run = inlineItem.as<Run>();
            Run newRun;
            newRun.Text(run.Text());
            currentParagraph.Inlines.Add(newRun);
         }

It is regrettable that we don't have a better error message for this, but we already have several work items related to making that better.  So closing this as by design.


mo.ui.anywidget doesn't show the api of widgets

Describe the bug
https://github.com/user-attachments/assets/d9e96a18-4078-46d4-8ddf-92e9edab87c6
Environment
{
  "marimo": "0.9.20",
  "OS": "Darwin",
  "OS Version": "24.0.0",
  "Processor": "arm",
  "Python Version": "3.12.7",
  "Binaries": {
    "Browser": "--",
    "Node": "v23.2.0"
  },
  "Dependencies": {
    "click": "8.1.7",
    "docutils": "0.21.2",
    "itsdangerous": "2.2.0",
    "jedi": "0.19.2",
    "markdown": "3.7",
    "narwhals": "1.13.3",
    "packaging": "24.2",
    "psutil": "6.1.0",
    "pygments": "2.18.0",
    "pymdown-extensions": "10.12",
    "pyyaml": "6.0.2",
    "ruff": "0.7.3",
    "starlette": "0.41.2",
    "tomlkit": "0.13.2",
    "typing-extensions": "4.12.2",
    "uvicorn": "0.32.0",
    "websockets": "12.0"
  },
  "Optional Dependencies": {
    "anywidget": "0.9.13"
  }
}

Code to reproduce
import marimo as mo

import anywidget
import traitlets

class Foo(anywidget.AnyWidget):
    _esm = ""
    _css = ""

    def foo(self, arg_1, arg_2):
        """A dummy method."""
        return arg_1 + arg_2

mo_widget = mo.ui.anywidget(Foo())
widget = Foo()

mo_widget.foo(1, 2)

widget.foo(1, 2)

In case anyone else has ideas, I tried adding this code to class anywidget's __init__:
        # Copy annotations
        self.__annotations__ = getattr(widget.__class__, "__annotations__", {})
        # Add runtime-discovered attributes to annotations
        for name in dir(widget):
            if not name.startswith("_"):
                attr = getattr(widget, name)
                self.__annotations__[name] = type(attr)

but it did not end up working


az sql server list giving CLIInternalError on arm64

Describe the bug
az sql server list results in:
ERROR: CLIInternalError: The command failed with an unexpected error. Here is the traceback:
ERROR: cannot import name 'ImportExistingDatabaseDefinition' from 'azure.mgmt.sql.models' (/usr/lib/python3/dist-packages/azure/mgmt/sql/models/__init__.py)
Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/knack/cli.py", line 233, in invoke
    cmd_result = self.invocation.execute(args)
  File "/usr/lib/python3/dist-packages/azure/cli/core/commands/__init__.py", line 558, in execute
    self.commands_loader.load_arguments(command)
  File "/usr/lib/python3/dist-packages/azure/cli/core/__init__.py", line 481, in load_arguments
    loader.load_arguments(command)  # this adds entries to the argument registries
  File "/usr/lib/python3/dist-packages/azure/cli/command_modules/sql/__init__.py", line 27, in load_arguments
    from azure.cli.command_modules.sql._params import load_arguments
  File "/usr/lib/python3/dist-packages/azure/cli/command_modules/sql/_params.py", line 11, in <module>
    from azure.mgmt.sql.models import (
ImportError: cannot import name 'ImportExistingDatabaseDefinition' from 'azure.mgmt.sql.models' (/usr/lib/python3/dist-packages/azure/mgmt/sql/models/__init__.py)

To Reproduce
ARM64 arch. Dockerfile:
FROM debian:bullseye

RUN apt-get update
RUN apt-get install --yes python3 python3-pip
RUN apt install --yes azure-cli

I then run a script which does:

az login with username, password, tenant for a service principal - works
az account set --subscription "my sub here" - works
az sql server list - fails as above

Expected behavior
List of servers returned, as works with mcr.microsoft.com/azure-cli:latest image (on amd64 it works... arm64 build is broken)
Environment summary

arm64 arch
kubernetes
debian:bullseye
latest azure-cli installed via apt as above

route to service team


Update silicon-labs-vcp-driver to 5.0.3

After making all changes to the cask:

[x] brew cask audit --download {{cask_file}} is error-free.
[x] brew cask style --fix {{cask_file}} left no offenses.
[x] The commit message includes the cask’s name and version.

Thanks for the PR!


wrong Gdocs link in yara/docs/gettingstarted.rst

In yara/docs/gettingstarted.rst is wrong google docs link to Windows binaries.
Please update link to https://drive.google.com/drive/folders/0BznOMqZ9f3VUek8yN3VvSGdhRFU

Already fixed.


IOU Contract and resolve address conflict in test_fungible_instance()

IOU Contract and resolve address conflict in test_fungible_instance()

Merged in https://github.com/HydraChain/hydrachain/commit/3e833386faef1a10e02650df99f61ae173ad3d64


No highlighting on fresh VS2017 installation

I've been reading the previous issues and trying every solution, including disabling all the other extensions and reinstalling VS2017 Community (15.3.5). The issue is that no highlighting ever appears on my shader files, and there is no nShader section under Options although "Shader Language" does appear under the Text Editor section. Enabling, disabling, and reinstalling the extension doesn't seem to do anything either, except that with the extension enabled I get no highlighting at all and with it disabled I get the basic highlighting. Opening the file through a solution, manually, or creating a new shader file results in the same thing.
The extension appears in About section, and there are no errors. Going through the activity log and searching for "nShader" yields zero results. Don't really know where to go from there.

I have the same issue.

Same issue here, VS2017 Enterprise 15.4, got the "Shader Language" title under 'Options->Text Editor', but no highlight in editor view, no 'Nshader- ...' titles under 'Options->Environment->Fonts and Colors'.

Same here with VS2017 Enterprise 15.3.4

Same issue on Community 15.4.2. Hoping this gets fixed soon.

Let us just clone the repo, debug the source, and pull request?

can used for vs2017?

Same here,
VS 15.4.4
NShader 2.4

Fixed mine by manually adding the file extensions under Options->Text Editor->File Extension

MStachowicz Could you tell us what version of VS you are using? I have tried that, but it didn't fix the problem for me.

@Schmerzmittel Hey VS is 15.4.4 using NShader 2.4

Okay, guys. I think I figured out something. My VS was in different language. When I changed it to English, the shader started to work again.

Same issue here. Visual Studio is using English.
Mapping the extensions to NShader did not work.

Same here, the .fs file extension had a bit of highlighting before using NShader, after adding .fs to the list it became just plain white text in the editor.

I checked the install log and it said:
Skipping 'C:\Users\<username>\AppData\Local\Microsoft SDKs' as if it doesn't exist The extension with ID 'NShader.51a01e9d-eb56-4ee2-a9fd-8212bf6bf2b1' is not installed to Visual Studio Community 2017.
So I added the folder 'Microsoft SDKs' to '\AppData\Local\', reinstalled it, and it worked! Although the install log still said:
The extension with ID 'NShader.51a01e9d-eb56-4ee2-a9fd-8212bf6bf2b1' is not installed to Visual Studio Community 2017.

@rienik Thanks, i can confirm that fixed the issue for me as well.

@rienik Dang, that works indeed! Maybe some additional info: Highlighting used to work until I've updated Visual Studio 2017 some days ago. Also installed the latest Windows SDK in addition to previously installed Windows SDKs.

@rienik your solution works for me as well. Thanks.

The issue seems to have reappeared for me.

Happened again after Windows update KB4074588. Microsoft SDKs  folder was gone => re-created it, re-installed NShader => worked again.

I am rather certain this is extension is simply broken on VS2017.

Brand new update to VS2017 Enterprise 15.7.3
Created "Microsoft SDKs" folder in my "AppData/Local" directory
Installed latest NShader VSIX (2.4)
Added "frag" and "vert" to open with Nshader in "Tools->Options->Text Editor->File Extension"
Open ".frag" and ".vert" file in VS after restarting and.... NOTHING! No highlighting, no nothing. Might as well just be a regular text document.

Sorry I just haven’t had time to maintain this lately. I would suggest you give HLSL Tools a try https://github.com/tgjones/HlslTools
I’m also happy to take pull requests that fix bugs. I won’t have time to look at these bugs for another couple of months at the earliest.

On 6 Jun 2018, at 6:13 am, ForeverZer0<EMAIL_ADDRESS>wrote:
I am rather certain this is extension is simply broken on VS2017.
Brand new update to VS2017 Enterprise 15.7.3
Created "Microsoft SDKs" folder in my "AppData/Local" directory
Installed latest NShader VSIX (2.4)
Added "frag" and "vert" to open with Nshader in "Tools->Options->Text Editor->File Extension"
Open ".frag" and ".vert" file in VS after restarting and.... NOTHING! No highlighting, no nothing. Might as well just be a regular text document.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Thanks for you work and you comments, @samizzo !
HlslTools do not provide GLSL highlighting, do they?


[BUG] DummyClassifier link from the Estimator Overview Page leads to a 404 page

Describe the bug
In the Estimator Overview page, the link to DummyClassifier leads to "404 Documentation page not found"
Steps/Code to reproduce the bug

Go to Estimator Overview page
Click on DummyClassifier
See the result

Expected results
The DummyClassifier link should have linked to the actual DummyClassifier Documentation
Actual results

Versions
No response

I could work on this.
Let me know if any more detail is needed.

thanks, would appreciate a fix


windows 10 WSL gives error

Hi. I've just installed the plugin on Windows 10's WSL. I use oh my zsh and followed the installation as noted here.
After opening new shell, plugin gives following error. How to fix?
[oh-my-zsh] Insecure completion-dependent directories detected:
drwxrwxrwx 1 user user 4096 Oct 17 01:25 /home/user/.oh-my-zsh/custom/plugins/zsh-autosuggestions

[oh-my-zsh] For safety, we will not load completions from these directories until
[oh-my-zsh] you fix their permissions and ownership and restart zsh.
[oh-my-zsh] See the above list for directories with group or other writability.

[oh-my-zsh] To fix your permissions you can do so by disabling
[oh-my-zsh] the write permission of "group" and "others" and making sure that the
[oh-my-zsh] owner of these directories is either root or your current user.
[oh-my-zsh] The following command may help:
[oh-my-zsh]     compaudit | xargs chmod g-w,o-w

[oh-my-zsh] If the above didn't help or you want to skip the verification of
[oh-my-zsh] insecure directories you can set the variable ZSH_DISABLE_COMPFIX to
[oh-my-zsh] "true" before oh-my-zsh is sourced in your zshrc file.

Fixed. I ran the command as suggested in the output.
compaudit | xargs chmod g-w,o-w ~/.oh-my-zsh

It fixed the error.


IOU - The chat window is blank after I edit the description

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: <IP_ADDRESS>
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Issue found when executing PR https://github.com/Expensify/App/pull/36287
Action Performed:

Create a money request with a description
Navigate to the description edit page
Edit the description

Expected Result:
User should see the IOU details.
Actual Result:
On web, the chat window is blank after I edit the description. On Android and iOS native and mWeb, I'm taken to the LHN after editing.
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence
https://github.com/Expensify/App/assets/93399543/2af95ca8-94a4-4f72-a4f6-525793d986ca
View all open jobs on GitHub

We think that this bug might be related to #vip-vsb
CC @quinthar

This issue is on staging but not on dev

On Android and iOS native and mWeb, I'm taken to the LHN after editing.

I also see this on iOS Native, v1.4.39-7

Ok I confirmed this is NOT happening in dev, so it must have been fixed somewhere (as a contrib mentioned here)

Fixed by https://github.com/Expensify/App/pull/36329

no payment needed here


TypeError: createRouterMock is not a function

Reproduction
I've installed the "vue-router-mock" package and I created "jest.setup.js" file as in the documentation and i got the error after running a test.
Jest throws the following error.
TypeError: createRouterMock is not a function.
Steps to reproduce the behavior
Dev Dependencies:

"vue-router-mock": "0.0.3"
"@jest/types": "^27.0.2"
"@vue/test-utils": "2.0.0-rc.15"
"vue-jest": "^5.0.0-0"
"typescript": "~4.1.5"

Expected behavior
Tests pass with no error.
Actual behavior
TypeError: createRouterMock is not a function
  3 |
  4 | // create one router per test file
> 5 | const router = createRouterMock();
    |                ^
  6 | beforeEach(() => {
  7 |   injectRouterMock(router);
  8 | });

  at Object.<anonymous> (tests/unit/jest.setup.js:5:16)
      at Array.forEach (<anonymous>)

Additional information
I've tried another "@vue/test-utils" versions(2.0.0-0, 2.0.0-rc.4) but i got same error.

You need to import it . If that's not it, please provide a boiled down reproduction with updated dependencies (e.g. TS)

You need to import it . If that's not it, please provide a boiled down reproduction with updated dependencies (e.g. TS)

I've already imported. Here's my jest.setup.ts:
const { config } = require("@vue/test-utils");
const { VueRouterMock, createRouterMock, injectRouterMock } = require("vue-router-mock");

// create one router per test file
const router = createRouterMock();
beforeEach(() => {
  injectRouterMock(router);
});

// Add properties to the wrapper
config.plugins.VueWrapper.install(VueRouterMock);

And i didn't understand second sentence. I'm trying with updated packages like<EMAIL_ADDRESS>but i got same error.

Hey, i found the problem.
If you have "vue-router" map in "moduleNameMapper" in jest.config.js like this:
jest.config.js

moduleNameMapper: {
   "vue-router": "<rootDir>/node_modules/vue-router/",
}

"vue-router-mock" throws "TypeError: createRouterMock is not a function" error. I've removed and there's no error here. :)