NSString tests fail on OSX (URL/file-related)

[ RUN      ] NSString.FromContentsOfURL
Foundation/ReferenceFoundation/TestNSString.mm:226: Failure
Expected: (nullptr) != (testFileURL), actual: NULL vs NULL
URL for NSStringTestData.txt is nil
[  FAILED  ] NSString.FromContentsOfURL (1 ms)
[ RUN      ] NSString.FromContentOfFile
Foundation/ReferenceFoundation/TestNSString.mm:245: Failure
Expected: (nullptr) != (testFilePath), actual: NULL vs NULL
[  FAILED  ] NSString.FromContentOfFile (1 ms)
[ RUN      ] NSString.StringByResolvingSymlinksInPath
Foundation/ReferenceFoundation/TestNSString.mm:644: Failure
Value of: expected
Actual: /
Expected: result
Which is: /private
For absolute paths, all symbolic links are guaranteed to be removed.
[  FAILED  ] NSString.StringByResolvingSymlinksInPath (1 ms)

Reassigned to self - hit this while fixing https://github.com/Microsoft/WinObjC/issues/777, the same fix works.


JavaScript: Add tar-stream extraction to ZipSlip query.

Let me know if the change note is formatted properly according to convention. I tried looking around the other recent change notes for reference.

Here are some suggestions for other packages to investigate, they all seem to use a fairly similar API:

https://www.npmjs.com/package/adm-zip
https://www.npmjs.com/package/yauzl

these two look worth modelling, but I don't think I'm going to get around to it right now.

https://www.npmjs.com/package/decompress

I'm looking for a part of this api surface that lets you get file contents in order to write yourself, and I only see 'extract everything for me', just like tar.

https://www.npmjs.com/package/unzipper

This one was easy to add, since it's a drop in replacement for unzip, so I did.


Executable runs and the process dies shortly after, no beacon / shell

Since the max shellcode size update (thank you for this, really looking forward to the tool), Alaris will build the payload (following your exact cobaltstrike steps to generate the SC, but the executable doesnt result in a beacon. All other payloads from CS work fine, so my setup is ok. ideas? watching the process is task manager shows it run for about 10 seconds and close, no endpoint security.

Alaris has some code that overwrites 500 bytes of the shellcode with null bytes after about 9 seconds or so.
  // Overwrite shellcode with null bytes
  Sleep(9999);
  uint8_t overwrite[500];
  NtWriteVirtualMemory(hProcess, mem, overwrite, sizeof(overwrite), 0);

I'm assuming this is your issue as you have large shellcode which, takes longer to load and execute within the hollowed process. Essentially, I'm clobbering 500B of you shellcode too soon. Feel free to comment this code out if you need or simply change the Sleep(); to a larger number.


originalEvent.composedPath() return empty array

Describe the bug
when use composedPath in bindKeyCombo callback, return empty array.
bindKeyCombo('Meta + z', (e) => {
    const path = e.originalEvent.composedPath(); // path is []
});

The issue seems to be that callback exec in next micro task
https://stackoverflow.com/questions/62181537/why-does-composedpath-on-event-returns-different-value-when-delayed
Expected behavior
return true array
Additional context
Add any other context about the problem here.

I'll have a look at this today. Out of curiosity, what are you using the method for?

@Senasiko have a look at #3 if you wish. I'll be adding a test case to verify the fix as well as test the new mapper function before it's merged. Given that you have looked through the code, and that this PR should fix your use case I'd be interested in your thoughts.

Ok, I've added a few tests and fixed a bug. Next is updating the docs. I'll take a pass at that tonight, then I should be able to roll out a release shortly after that.

Sorry that took so long. The latest release has your composedPath now.


Remove the windows forms ui and switch the release build to create a windows+linux release with the avaloniaUI project (50points)

[ ] build for windows with release asset
[ ] build for linux with release asset
[ ] does the auto-update for windows still work?


Support persisting splits in reconnected terminals across window reloads

Currently when remotes reconnect terminals the split terminals get flattened into their own terminals. This is mainly an issue of how we want to persist that knowledge across sessions and make sure the remote agent stores it (eg. splitIndex: number may be enough). Note also that split terminals are naturally smaller so they have non-standard dimensions, not sure we need to do anything special to handle dimensions differently as resize events are recorded.
Ideally there may need to be some logic/checks to ensure split terminals get adopted together so they cannot be split up. This will probably involve the introduction of the terminal tab idea on the server.

Isn't this https://github.com/microsoft/vscode/issues/109244 ?


Update to hyper 0.7

Trying to use this crate (or crates that depend on it) in junction with hyper 0.7 cause a native linking error with openssl-sys. This resolves it by updating to hyper 0.7, and implementing the two other required methods for the NetworkStream trait introduced in 0.7
The error:
native library `openssl` is being linked to by more than one version of the same package, but it can only be linked once; try updating or pinning your dependencies to ensure that this package only shows up once

  openssl-sys v0.7.1
  openssl-sys v0.6.7

Thanks!


[Minor][thread-safe-queue]: Prevent extra move for get-methods with nrvo

Motivation https://godbolt.org/z/jTd99xzf1

sorry, i am not able to compile it locally

Ok looks like some tests are failing. I'll have to investigate a bit more if you can't build it locally.

I tried it on my home ubuntu 22.04 with gcc-11. Everything is fine, it is not possible to reproduce the crash.

@jirol9xa Unfortunately, this is the nature of something as low level as a thread pool. Even if it's no locally reproducible, it is still likely a bug somewhere.
Were you able to run it with thread sanitizer enabled and/or asan?

I'll try this out later on on PopOS and Ubuntu 24.04 to see if it's reproducible.

Tried to run with tsan, and had an error even if running from trunk =)) Pretty sure I am doing something wrong

Oh no, there might be a bug then. What error do you see?

CMake Error at /home/voffk4/fast-thread-pool/build/_deps/doctest-src/scripts/cmake/doctestAddTests.cmake:45 (message): Error running test executable 'thread-pool/build/test/thread-pool-tests':
Result: 66
Output:

I was able to reproduce this. https://stackoverflow.com/questions/77850769/fatal-threadsanitizer-unexpected-memory-mapping-when-running-on-linux-kernels this stackoverflow helped me find a workaround. Setting  sudo sysctl vm.mmap_rnd_bits=28 fixed the build issue for me, but I think TSan is giving false positives. I'll have to dig in a bit more. When I run the tests without TSan they all pass.

Welp, I re-ran the test and it passed this time :man_shrugging:


Do you support timeout?

Some command fails because run a long time.

This bundle use ssh2  that doesn't support timeout option.
I leave you an interesting discussion about this on stackoverfow.


Online Buildpack uses wrong golang version

https://github.com/cyberark/cloudfoundry-conjur-buildpack/pull/38 updated the golang version for the buildpack to 1.12, including a non-backward compatible API change for obtaining the home directory.
The online buildpack, however, is still installing go 1.11.
It looks like this wasn't caught before because of a bug in the online buildpack integration test: https://github.com/cyberark/cloudfoundry-conjur-buildpack/blob/master/ci/features/integration.feature#L32

@micahlee It would be good to update the guidelines for this in CONTRIBUTING.md - that's where I looked to find out where to update the go version, and this was missing there.


Use with julia-1.1.0

I am struggling to modify the cabal file to get this repo to work with julia-1.1.0, but I think it's because my experience with nix is severely lacking. Do you know of a quick way in which to get this repo building using julia-1.1.0?
I have tried modifying the library: include-dirs and executable: ld-options cabal fields to point to the derivation of julia-1.1.0 that I want to use in my /nix/store and have also modified the the default.nix file to use a newer nixpkgs revision that includes julia-1.1.0. However, no matter what I tweak or modify I can't seem to get the project building.
This is the output of my build:
$ nix-build
these derivations will be built:
  /nix/store/n5ynz60wd1zbfz32wmnrjdblhdj8i94f-julio-<IP_ADDRESS>.drv
building '/nix/store/n5ynz60wd1zbfz32wmnrjdblhdj8i94f-julio-<IP_ADDRESS>.drv'...
setupCompilerEnvironmentPhase
Build with /nix/store/cclv7n6jr311i5ywwkms1m3iz4lsg37j-ghc-8.6.3.
unpacking sources
unpacking source archive /nix/store/axjdhld7rb2gzivfsppz5033a8nz6wf9-Julio
source root is Julio
patching sources
compileBuildDriverPhase
setupCompileFlags: -package-db=/build/setup-package.conf.d -j4 -threaded
[1 of 1] Compiling Main             ( Setup.hs, /build/Main.o )
Linking Setup ...
configuring
configureFlags: --verbose --prefix=/nix/store/hakfcg18h12564jj300gyr7r9br0zfwj-julio-<IP_ADDRESS> --libdir=$prefix/lib/$compiler --libsubdir=$abi/$libname --docdir=/nix/store/68snhp2lz2plb7bw0q27wpan2x39wcjq-julio-<IP_ADDRESS>-doc/share/doc/julio-<IP_ADDRESS> --with-gcc=gcc --package-db=/build/package.conf.d --ghc-option=-j4 --disable-split-objs --enable-library-profiling --profiling-detail=exported-functions --disable-profiling --enable-shared --disable-coverage --enable-static --disable-executable-dynamic --enable-tests --disable-benchmarks --enable-library-vanilla --enable-library-for-ghci --ghc-option=-split-sections --extra-lib-dirs=/nix/store/mi5krns5p204a3rdn1rj4ajnbqn2809i-ncurses-6.1-20181027/lib --extra-lib-dirs=/nix/store/rd7n0v6mymvyqbw3d307caqc23c8kc71-gmp-6.1.2/lib --extra-include-dirs=/nix/store/va0yp1gqd43vsrw7g11jfibyrbx85nsw-julia-1.0.3/include --extra-lib-dirs=/nix/store/va0yp1gqd43vsrw7g11jfibyrbx85nsw-julia-1.0.3/lib --extra-include-dirs=/nix/store/va0yp1gqd43vsrw7g11jfibyrbx85nsw-julia-1.0.3/include --extra-lib-dirs=/nix/store/va0yp1gqd43vsrw7g11jfibyrbx85nsw-julia-1.0.3/lib
Using Parsec parser
Warning: julio.cabal:40:3: Unknown field: "extra-include-dirs"
Configuring julio-<IP_ADDRESS>...
Dependency base -any: using base-<IP_ADDRESS>
Dependency base -any: using base-<IP_ADDRESS>
Dependency julio -any: using julio-<IP_ADDRESS>
Source component graph:
    component lib
    component exe:main dependency lib
Configured component graph:
    component julio-<IP_ADDRESS>-DMRJo63rNoMGI9H31QyV3 include base-<IP_ADDRESS>
    component julio-<IP_ADDRESS>-Fy1D3OMEBqA5xcvYIikbmt-main
        include base-<IP_ADDRESS>
        include julio-<IP_ADDRESS>-DMRJo63rNoMGI9H31QyV3
Linked component graph:
    unit julio-<IP_ADDRESS>-DMRJo63rNoMGI9H31QyV3
        include base-<IP_ADDRESS>
        Julia=julio-<IP_ADDRESS>-DMRJo63rNoMGI9H31QyV3:Julia
    unit julio-<IP_ADDRESS>-Fy1D3OMEBqA5xcvYIikbmt-main
        include base-<IP_ADDRESS>
        include julio-<IP_ADDRESS>-DMRJo63rNoMGI9H31QyV3
Ready component graph:
    definite julio-<IP_ADDRESS>-DMRJo63rNoMGI9H31QyV3 depends base-<IP_ADDRESS>
    definite julio-<IP_ADDRESS>-Fy1D3OMEBqA5xcvYIikbmt-main
        depends base-<IP_ADDRESS>
        depends julio-<IP_ADDRESS>-DMRJo63rNoMGI9H31QyV3
Using Cabal-<IP_ADDRESS> compiled by ghc-8.6
Using compiler: ghc-8.6.3
Using install prefix:
/nix/store/hakfcg18h12564jj300gyr7r9br0zfwj-julio-<IP_ADDRESS>
Executables installed in:
/nix/store/hakfcg18h12564jj300gyr7r9br0zfwj-julio-<IP_ADDRESS>/bin
Libraries installed in:
/nix/store/hakfcg18h12564jj300gyr7r9br0zfwj-julio-<IP_ADDRESS>/lib/ghc-8.6.3/x86_64-linux-ghc-8.6.3/julio-<IP_ADDRESS>-DMRJo63rNoMGI9H31QyV3
Dynamic Libraries installed in:
/nix/store/hakfcg18h12564jj300gyr7r9br0zfwj-julio-<IP_ADDRESS>/lib/ghc-8.6.3/x86_64-linux-ghc-8.6.3
Private executables installed in:
/nix/store/hakfcg18h12564jj300gyr7r9br0zfwj-julio-<IP_ADDRESS>/libexec/x86_64-linux-ghc-8.6.3/julio-<IP_ADDRESS>
Data files installed in:
/nix/store/hakfcg18h12564jj300gyr7r9br0zfwj-julio-<IP_ADDRESS>/share/x86_64-linux-ghc-8.6.3/julio-<IP_ADDRESS>
Documentation installed in:
/nix/store/68snhp2lz2plb7bw0q27wpan2x39wcjq-julio-<IP_ADDRESS>-doc/share/doc/julio-<IP_ADDRESS>
Configuration files installed in:
/nix/store/hakfcg18h12564jj300gyr7r9br0zfwj-julio-<IP_ADDRESS>/etc
No alex found
Using ar found on system at:
/nix/store/3xwc1ip20b0p68sxqbjjll0va4pv5hbv-binutils-2.30/bin/ar
No c2hs found
No cpphs found
No doctest found
Using gcc version 7.4.0 given by user at:
/nix/store/isg8rxaxkijl9x3hr2gzsf8pqfnqxg3k-gcc-wrapper-7.4.0/bin/gcc
Using ghc version 8.6.3 found on system at:
/nix/store/cclv7n6jr311i5ywwkms1m3iz4lsg37j-ghc-8.6.3/bin/ghc
Using ghc-pkg version 8.6.3 found on system at:
/nix/store/cclv7n6jr311i5ywwkms1m3iz4lsg37j-ghc-8.6.3/bin/ghc-pkg
No ghcjs found
No ghcjs-pkg found
No greencard found
Using haddock version 2.22.0 found on system at:
/nix/store/cclv7n6jr311i5ywwkms1m3iz4lsg37j-ghc-8.6.3/bin/haddock
No happy found
Using haskell-suite found on system at: haskell-suite-dummy-location
Using haskell-suite-pkg found on system at: haskell-suite-pkg-dummy-location
No hmake found
Using hpc version 0.67 found on system at:
/nix/store/cclv7n6jr311i5ywwkms1m3iz4lsg37j-ghc-8.6.3/bin/hpc
Using hsc2hs version 0.68.5 found on system at:
/nix/store/cclv7n6jr311i5ywwkms1m3iz4lsg37j-ghc-8.6.3/bin/hsc2hs
Using hscolour version 1.24 found on system at:
/nix/store/r3znaf3bqz465zg3ja5garkalxfxzskd-hscolour-1.24.4/bin/HsColour
No jhc found
Using ld found on system at:
/nix/store/lwdkm354f3zzsvkf7pqmnc8w6r164b42-binutils-wrapper-2.30/bin/ld
No pkg-config found
Using runghc version 8.6.3 found on system at:
/nix/store/cclv7n6jr311i5ywwkms1m3iz4lsg37j-ghc-8.6.3/bin/runghc
Using strip version 2.30 found on system at:
/nix/store/3xwc1ip20b0p68sxqbjjll0va4pv5hbv-binutils-2.30/bin/strip
Using tar found on system at:
/nix/store/6y95ihqqw5ws23mp74f919d5q49jin9l-gnutar-1.30/bin/tar
No uhc found
Setup: Missing dependency on a foreign library:
* Missing (or bad) C library: julia
This problem can usually be solved by installing the system package that
provides this library (you may need the "-dev" version). If the library is
already installed but in a non-standard location then you can use the flags
--extra-include-dirs= and --extra-lib-dirs= to specify where it is.If the
library file does exist, it may contain errors that are caught by the C
compiler at the preprocessing stage. In this case you can re-run configure
with the verbosity flag -v3 to see the error messages.

builder for '/nix/store/n5ynz60wd1zbfz32wmnrjdblhdj8i94f-julio-<IP_ADDRESS>.drv' failed with exit code 1
error: build of '/nix/store/n5ynz60wd1zbfz32wmnrjdblhdj8i94f-julio-<IP_ADDRESS>.drv' failed

The revision I am attempting to use is: bfc3789

@tdietert thanks for reaching out. I've recently updated the nixpkgs version as well as the Julia version to 1.1.0 (as of this commit). Just clone and nix-build, it will all work.
The julia package in nix has a non-standard directory structure for /lib and /include and no .pc file to configure this properly, so it doesn't play well with nix. This commit uses pkgconfig properly to configure Julia's include / lib dirs while removing the need to hardcode nix paths into the cabal file. Let me know if you need anything else or would like to collaborate further on this project. ✌

Wonderful, thank you so much! :pray: I'm currently writing a multi-process/distributed-process map/reduce style program that evaluates some computationally intensive algorithm written in julia in parallel.
If I run into any issues, suggestions, or extensions of the julia interface, I'll let you know via issue or PR :+1:

Sounds pretty awesome, definitely keep me appraised of the progress !


PVE001: suggested merging of blacklist bitmap into reserveData

The auditor  suggested to make use of the existing reserveData instead of creating a new storage slot, to have a cleaner interface. The suggestion is very helpful and was implemented in the fix https://github.com/Kinza-Finance/KZA-lending/pull/55


Analysis Refactoring

Move data preprocessing to separate module: #220 #225

[x] read from json
[x] remove outliers
[x] fill gaps
[x] resample [switch to month start default]
[x] smooth
[x] write to csv

Modify analysis code for compatiability with above #217

[x] autocorrelation
[x] feature vectors #186
[x] time series #170
[x] detrending [dropped averaged time series detrending - detrend only on sub-image level]

misc:

[x] fix spatial plot [still a bit hacky at the moment]
[x] fix tests [+ fix for #230]
[x] merge from develop after #233 is merged and add compatibility

Analysis console output improved, but still lots of ugly warnings from the AR1 model:
/Users/svanstroud/miniconda3/envs/ds4sd/lib/python3.8/site-packages/statsmodels/tsa/base/tsa_model.py:159: ValueWarning: No frequency information was provided, so inferred frequency MS will be used.   warnings.warn('No frequency information was'

@samvanstroud  I tried to run the new pipeline and it was crashing with Matplotlib backend error that we have seen before. I solved by moving to matplotlib 3.1 as recommended here. I pushed the change into this branch.

Thanks for finding and fixing that @crangelsmith. I added a small bug when plotting S2+L8 overlays. If any work is dependent on this feel free to merge, otherwise we can wait for Friday :)


Remove version: NelsonNumericalSoftware.Nelson version <IP_ADDRESS>7

[Automated] It returns code over 400 in all urls
Microsoft Reviewers: Open in CodeFlow

URL: https://github.com/Nelson-numerical-software/nelson/releases/download/v0.5.5/Nelson-<IP_ADDRESS>7-x86-64.exe
Response Error: The remote server returned an error: (404) Not Found.
(Automated message - build 911)


Bug in Scroll function

Hello, thank you for this nice driver. I was making some changes to use the scroll function with the "modRev" on. It is working fine now, I made a fork... But I found a fatal bug in this function. In the original file, we have
for (i = 8 * N; i >= 0; i-- )
when we should have
for (i = 8 * N - 1; i >= 0; i--)
because here
if ((i + 1) % N) frameBuffer[i + 1] |= (n << 7);
we can see, when i == 8 * N, it will write at 8 * N + 1, outside the frameBuffer array : [0; 8 * N [

Hi, I just pushed a new branch (rotation) that addresses this problem. I have rewritten the code not to do a "look ahead" or "look back". I'd be happy if you could take a look and check if I didn't break it even more :)

Ah, one more thing. I have made changes this code that inverts display so that the framebuffer always contains the same data and it's inverted only when it's being written to the hardware.

More than pretty good news, and I feel it a great idea, this will allow us to work on the buffer without to think further :) I was close to rewrite some parts for the issue with different hardwares when I saw you are already working on with other contributors too :)
I really like your driver, simple but efficient, it will preserve memory for the project.
I will look further for this new branch

If I get no more complaints about the new scrolling code I will close this issue. Feel free to test branch "rotation" any time.

For now, rotation driver is working fine for me, that s pretty cool, these adjustments were the missing part from your driver. If I find something wrong, I will report. Have a nice day.

Okay, thanks for checking. I close the issue.


Support unpacking of model as tar/zip file for s3

/kind feature
Describe the solution you'd like
We are trying to marry  "KF Pipelines + KF Artifacts + KF Serving" in a nice use-case where we train a (sklearn) model using KFP, store it as an output artifact to the artifact store of pipelines (minio) and then deploy that model directly from the artifact store using KFServing. The problem we are facing is that the output artifacts are by default stored as .tgz , so even a .joblib blob model object is still wrapped into .tgz  at creation time of the artifact in minio. On the other end, the default KF serving application server expects a .joblib file, not a .tgz.
We're using the s3 protocol to load the model file from minio to the kfserving pod.
We already discussed with @yuzisun in the Kubeflow slack, and he pointed out that unpacking of a model (in the storage-initializer container) is currently only supported for http:
see this example
see the code
I'm opening this issue to first of all start a discussing on how to go about this.
I can already add that, if it's decided to add support to s3 for the extraction of a model file, we at Credo are happy to help :slightly_smiling_face:

Copying part of the discussion from Slack:
@yuzisun would you let us know pls if OK with you to integrate the fix of the issue 1569 (see above in the thread) once we PR the fix?
@yuzisun: sounds good, How do you plan fix this?
Well, high-level speaking we would add the same functionality for unpacking the .tar.gz as currently implemented in _download_from_uri() (source) to _download_s3() as well. Sounds ok?

Hi! Are there any update on this? Thanks!

I need this functionality too!
Any update here?


Reapply PCL package blocks

Reverts pulumi/pulumi-converter-terraform#231 which was a revert of https://github.com/pulumi/pulumi-converter-terraform/commit/ccb6e15d26933d24e89075b1b6cb85749f522f2a
The goal is to try to integrate this without regressing #224

change the provider parameterized name to just be the same as provider "name"
Do a better check for if it is pulumiverse, use https://github.com/pulumi/pulumi/blob/master/pkg/util/plugin.go, and https://github.com/pulumi/ci-mgmt/blob/master/provider-ci/providers.json merged
see if it works and split the initial block from the param block additions

Moved to #239 and #240


bitcoin: <IP_ADDRESS> -> 0.5.1

I have also updated the dependencies for bitcoin:

qt4 is updated to qt5
miniupnpc 1 is updated to miniupnpc 2
zeromq dependency has been added to enable ZeroMQ support.

Motivation for this change
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[X] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[X] Tested execution of all binary files (usually in ./result/bin/)
[X] Fits CONTRIBUTING.md.

oops, wrong version numbers in title.


It's too slow to download the saliency_map from google cloud in China.

Can you just share the saliency_map in the way of zip file, and not using the goole cloud?
I'm crying downloading this.

ok then, Onedrive or Dropbox is available?
Otherwise, could you suggest an alternative way?

Thank you， I‘ve downloaded the saliency_maps from your link. It might be the newwork reason.


failed to mount secrets store object content, provider not found: provider aws

Describe the bug
E0515 13:21:11.025544       1 nodeserver.go:235] "failed to mount secrets store object content" err="error connecting to provider \"aws\": provider not found: provider \"aws\"" pod="myns/mypod-74679c49bf-f7trm"
I0515 13:21:11.025580       1 nodeserver.go:81] "unmounting target path as node publish volume failed" targetPath="/var/lib/kubelet/pods/f5bcf484-9b77-4ccd-ac85-3319c8f7c1e1/volumes/kubernetes.io~csi/secrets-store-inline/mount" pod="myns/mypod-74679c49bf-f7trm"

To Reproduce

Install secrets-store-csi-driver helm chart with 1.1.2 version
install csi-secrets-store-provider-aws helm chart with 0.0.2 version
create pod with csi driver secrets-store.csi.k8s.io volume which injects file to the pod

Environment:
Kubernetes EKS version v1.22.6-eks-14c7a48
Additional context
my pod describe logs
kubectl -n myns describe pod mypod-74679c49bf-f7trm

Events:
  Type     Reason       Age                    From               Message
  ----     ------       ----                   ----               -------
  Normal   Scheduled    11m                    default-scheduler  Successfully assigned myns/mypod-74679c49bf-f7trm to ip-10-102-60-11.ec2.internal
  Warning  FailedMount  5m37s                  kubelet            MountVolume.SetUp failed for volume "secrets-store-inline" : kubernetes.io/csi: mounter.SetUpAt failed to get CSI client: driver name secrets-store.csi.k8s.io not found in the list of registered CSI drivers
  Warning  FailedMount  5m13s (x2 over 9m46s)  kubelet            Unable to attach or mount volumes: unmounted volumes=[secrets-store-inline], unattached volumes=[aws-iam-token secrets-store-inline kube-api-access-ttgwq]: timed out waiting for the condition
  Warning  FailedMount  92s (x12 over 11m)     kubelet            MountVolume.SetUp failed for volume "secrets-store-inline" : rpc error: code = Unknown desc = failed to mount secrets store objects for pod myns/mypod-74679c49bf-f7trm, err: error connecting to provider "aws": provider not found: provider "aws"
  Warning  FailedMount  42s (x3 over 7m30s)    kubelet            Unable to attach or mount volumes: unmounted volumes=[secrets-store-inline], unattached volumes=[secrets-store-inline kube-api-access-ttgwq aws-iam-token]: timed out waiting for the condition

csi-secrets-store-provider-aws logs
kubectl -n kube-system logs -f system-csi-secrets-store-provider-aws-fg7ff
I0504 10:23:46.572837       1 main.go:32] Starting secrets-store-csi-driver-provider-aws version 1.0.r2-2<IP_ADDRESS>.34
I0504 10:23:46.574142       1 main.go:77] Listening for connections on address: /etc/kubernetes/secrets-store-csi-providers/aws.sock

secrets-store-csi-driver node-driver-registrar logs
kubectl -n kube-system logs -f secrets-store-csi-driver-lvd28 -c node-driver-registrar
I0515 13:19:08.291404       1 main.go:166] Version: v2.5.0
I0515 13:19:08.291434       1 main.go:167] Running node-driver-registrar in mode=registration
I0515 13:19:08.291912       1 main.go:191] Attempting to open a gRPC connection with: "/csi/csi.sock"
I0515 13:19:08.291935       1 connection.go:154] Connecting to unix:///csi/csi.sock
I0515 13:19:09.292814       1 main.go:198] Calling CSI driver to discover driver name
I0515 13:19:09.292843       1 connection.go:183] GRPC call: /csi.v1.Identity/GetPluginInfo
I0515 13:19:09.292848       1 connection.go:184] GRPC request: {}
I0515 13:19:09.300057       1 connection.go:186] GRPC response: {"name":"secrets-store.csi.k8s.io","vendor_version":"v1.1.2"}
I0515 13:19:09.300149       1 connection.go:187] GRPC error: <nil>
I0515 13:19:09.300157       1 main.go:208] CSI driver name: "secrets-store.csi.k8s.io"
I0515 13:19:09.300341       1 node_register.go:53] Starting Registration Server at: /registration/secrets-store.csi.k8s.io-reg.sock
I0515 13:19:09.300514       1 node_register.go:62] Registration Server started at: /registration/secrets-store.csi.k8s.io-reg.sock
I0515 13:19:09.300652       1 node_register.go:92] Skipping HTTP server because endpoint is set to: ""
I0515 13:19:09.608123       1 main.go:102] Received GetInfo call: &InfoRequest{}
I0515 13:19:09.608301       1 main.go:109] "Kubelet registration probe created" path="/var/lib/kubelet/plugins/csi-secrets-store/registration"
I0515 13:19:09.650343       1 main.go:120] Received NotifyRegistrationStatus call: &RegistrationStatus{PluginRegistered:true,Error:,}

secrets-store-csi-driver secrets-store logs
kubectl -n kube-system logs -f secrets-store-csi-driver-lvd28 -c secrets-store
I0515 13:19:08.498123       1 exporter.go:35] "initializing metrics backend" backend="prometheus"
I0515 13:19:08.499840       1 main.go:181] starting manager
I0515 13:19:08.600672       1 secrets-store.go:46] "Initializing Secrets Store CSI Driver" driver="secrets-store.csi.k8s.io" version="v1.1.2" buildTime="2022-03-30-21:59"
I0515 13:19:08.600878       1 server.go:120] "Listening for connections" address="//csi/csi.sock"
I0515 13:19:09.609204       1 nodeserver.go:359] node: getting default node info
E0515 13:21:11.025544       1 nodeserver.go:235] "failed to mount secrets store object content" err="error connecting to provider \"aws\": provider not found: provider \"aws\"" pod="myns/mypod-74679c49bf-f7trm"
I0515 13:21:11.025580       1 nodeserver.go:81] "unmounting target path as node publish volume failed" targetPath="/var/lib/kubelet/pods/f5bcf484-9b77-4ccd-ac85-3319c8f7c1e1/volumes/kubernetes.io~csi/secrets-store-inline/mount" pod="myns/mypod-74679c49bf-f7trm"
E0515 13:23:13.066343       1 nodeserver.go:235] "failed to mount secrets store object content" err="error connecting to provider \"aws\": provider not found: provider \"aws\"" pod="myns/mypod-74679c49bf-f7trm"
I0515 13:23:13.066374       1 nodeserver.go:81] "unmounting target path as node publish volume failed" targetPath="/var/lib/kubelet/pods/f5bcf484-9b77-4ccd-ac85-3319c8f7c1e1/volumes/kubernetes.io~csi/secrets-store-inline/mount" pod="myns/mypod-74679c49bf-f7trm"
E0515 13:25:15.163767       1 nodeserver.go:235] "failed to mount secrets store object content" err="error connecting to provider \"aws\": provider not found: provider \"aws\"" pod="myns/mypod-74679c49bf-f7trm"

And I'm getting same issue. Any update?

Am getting same issue. Any workaround?

For my case, I have some Taint Nodes which the current [secrets-store-csi-driver-provider-aws](https://github.com/aws/secrets-store-csi-driver-provider-aws) deployment cannot tolerate, if you change the Tolerations to

I am running windows container and after upgrading csi driver with --set grpcSupportedProviders=”aws” I can bypass this issue and got below error. Any input appreciated :)
Warning  FailedMount        21s (x7 over 53s)  kubelet                  MountVolume.SetUp failed for volume "secrets-store-inline" : kubernetes.io/csi: mounter.SetUpAt failed to determine if the node service has VOLUME_MOUNT_GROUP capability: rpc error: code = Unavailable desc = connection error: desc = "transport: Error while dialing dial unix C:\var\lib\kubelet\plugins\csi-secrets-store\csi.sock: connect: No connection could be made because the target machine actively refused it."

It seems like aws hasn't been added as a gRPC provider.  This was a known issue in earlier versions of the secrets-store-csi-driver, but should have since been fixed.  I can recommend a few ways to fix this:

Upgrade the secrets-store-csi-driver to the most recent version.
As @RagunathTH pointed out, add --set grpcSupportedProviders=”aws” to the installation arguments of the secrets-store-csi-driver.  This will be dependent on the way you are installing the csi driver, but as an example install using helm:

helm install -n kube-system csi-secrets-store secrets-store-csi-driver/secrets-store-csi-driver --set grpcSupportedProviders=”aws”
If neither of these end up resolving, try posting some minimally reproducible steps here.


README Formatting Updated

The markdown for the links to our GitHub profiles was incorrect.

The c/c++ CI/ Build (pull_request) fails some checks. https://github.com/apps/github-actions

@melippmann I just changed the readme markdown file so the build should not be failing. The c-cpp.yml file which was added in the .github directory is trying to run "./configure", but that's not anywhere in the repo so this is most likely why it is failing to build.

is this dead or just waiting to be merged?


Replacement for PENXOR

A lot of old mircoworlds use PENXOR, and we need to find some sort of replacement for them.

I don't believe we're actually planning on replacing this, and most of the old microworlds that used it have been updated.


inplace/bin/haddock expects threaded rts (HSrts_thr)

Or at least that's what I think HSrts_thr is, the threaded rts variant.
/------------------------------------------------------------\
| Run Ghc Stage2 (package = haddock)                         |
|     input: utils/haddock/stage2/build/Main.o (and 55 more) |
| => output: inplace/bin/haddock                             |
\------------------------------------------------------------/
ld: library not found for -lHSrts_thr
clang: error: linker command failed with exit code 1 (use -v to see invocation)
`clang' failed in phase `Linker'. (Exit code: 1)
shakeArgsWith   0.000s    0%
Function shake  0.020s    0%
Database read   0.532s    0%
With database   0.021s    0%
Running rules  60.154s   99%  =========================
Total          60.727s  100%
Error when running Shake build system:
* inplace/bin/haddock
user error (Development.Shake.cmd, system command failed
Command: inplace/bin/ghc-stage2 -hisuf hi -osuf o -hcsuf hc -static -hide-all-packages -no-user-package-db -package-id Cabal-<IP_ADDRESS> -package-id array-<IP_ADDRESS> -package-id base-<IP_ADDRESS> -package-id bytestring-<IP_ADDRESS> -package-id containers-<IP_ADDRESS> -package-id deepseq-<IP_ADDRESS> -package-id directory-<IP_ADDRESS> -package-id filepath-<IP_ADDRESS> -package-id ghc-8.1 -package-id ghc-boot-8.1 -package-id transformers-<IP_ADDRESS> -package-id xhtml-3000.2.1 -i -iutils/haddock/stage2/build -iutils/haddock/stage2/build/autogen -iutils/haddock/driver -iutils/haddock/haddock-api/src -iutils/haddock/haddock-library/vendor/attoparsec-<IP_ADDRESS> -iutils/haddock/haddock-library/src -Iutils/haddock/stage2/build -Iutils/haddock/stage2/build/autogen -I/Users/angerman/Projects/Haskell/ghc/compiler/. -I/Users/angerman/Projects/Haskell/ghc/compiler/parser -I/Users/angerman/Projects/Haskell/ghc/compiler/utils -I/Users/angerman/Projects/Haskell/ghc/compiler/../rts/dist/build -I/Users/angerman/Projects/Haskell/ghc/libraries/process/include -I/Users/angerman/Projects/Haskell/ghc/libraries/directory/include -I/Users/angerman/Projects/Haskell/ghc/libraries/unix/include -I/Users/angerman/Projects/Haskell/ghc/libraries/time/lib/include -I/Users/angerman/Projects/Haskell/ghc/libraries/containers/include -I/Users/angerman/Projects/Haskell/ghc/libraries/bytestring/include -I/Users/angerman/Projects/Haskell/ghc/libraries/base/include -I/Users/angerman/Projects/Haskell/ghc/libraries/integer-gmp/include -I/Users/angerman/Projects/haskell/ghc/rts/stage1/build -I/Users/angerman/Projects/haskell/ghc/includes -I/Users/angerman/Projects/haskell/ghc/includes/dist-derivedconstants/header -optP-include -optPutils/haddock/stage2/build/autogen/cabal_macros.h -funbox-strict-fields -Wall -fwarn-tabs -O2 -threaded -XHaskell2010 -optP-DIN_GHC_TREE -odir utils/haddock/stage2/build -hidir utils/haddock/stage2/build -stubdir utils/haddock/stage2/build -rtsopts -H32m -O2 -Wall -fwarn-tabs -no-auto-link-packages -optl-liconv -optl-lm -optl-ldl -optl-L/Users/angerman/Projects/Haskell/ghc/libraries/xhtml/stage1/build -optl-L/Users/angerman/Projects/Haskell/ghc/compiler/stage1/build -optl-L/Users/angerman/Projects/Haskell/ghc/libraries/hpc/stage1/build -optl-L/Users/angerman/Projects/Haskell/ghc/libraries/hoopl/stage1/build -optl-L/Users/angerman/Projects/Haskell/ghc/libraries/ghci/stage1/build -optl-L/Users/angerman/Projects/Haskell/ghc/libraries/transformers/stage1/build -optl-L/Users/angerman/Projects/Haskell/ghc/libraries/template-haskell/stage1/build -optl-L/Users/angerman/Projects/Haskell/ghc/libraries/ghc-boot/stage1/build -optl-L/Users/angerman/Projects/Haskell/ghc/libraries/Cabal/Cabal/stage1/build -optl-L/Users/angerman/Projects/Haskell/ghc/libraries/process/stage1/build -optl-L/Users/angerman/Projects/Haskell/ghc/libraries/pretty/stage1/build -optl-L/Users/angerman/Projects/Haskell/ghc/libraries/directory/stage1/build -optl-L/Users/angerman/Projects/Haskell/ghc/libraries/unix/stage1/build -optl-L/Users/angerman/Projects/Haskell/ghc/libraries/time/stage1/build -optl-L/Users/angerman/Projects/Haskell/ghc/libraries/filepath/stage1/build -optl-L/Users/angerman/Projects/Haskell/ghc/libraries/binary/stage1/build -optl-L/Users/angerman/Projects/Haskell/ghc/libraries/containers/stage1/build -optl-L/Users/angerman/Projects/Haskell/ghc/libraries/bytestring/stage1/build -optl-L/Users/angerman/Projects/Haskell/ghc/libraries/deepseq/stage1/build -optl-L/Users/angerman/Projects/Haskell/ghc/libraries/array/stage1/build -optl-L/Users/angerman/Projects/Haskell/ghc/libraries/base/stage1/build -optl-L/Users/angerman/Projects/Haskell/ghc/libraries/integer-gmp/stage1/build -optl-L/Users/angerman/Projects/Haskell/ghc/libraries/ghc-prim/stage1/build -optl-L/Users/angerman/Projects/haskell/ghc/rts/stage1/build utils/haddock/stage2/build/Main.o utils/haddock/stage2/build/Documentation/Haddock/Parser.o utils/haddock/stage2/build/Documentation/Haddock/Parser/Monad.o utils/haddock/stage2/build/Documentation/Haddock/Types.o utils/haddock/stage2/build/Documentation/Haddock/Doc.o utils/haddock/stage2/build/Data/Attoparsec.o utils/haddock/stage2/build/Data/Attoparsec/ByteString.o utils/haddock/stage2/build/Data/Attoparsec/ByteString/Buffer.o utils/haddock/stage2/build/Data/Attoparsec/ByteString/Char8.o utils/haddock/stage2/build/Data/Attoparsec/ByteString/FastSet.o utils/haddock/stage2/build/Data/Attoparsec/ByteString/Internal.o utils/haddock/stage2/build/Data/Attoparsec/Combinator.o utils/haddock/stage2/build/Data/Attoparsec/Internal.o utils/haddock/stage2/build/Data/Attoparsec/Internal/Fhthagn.o utils/haddock/stage2/build/Data/Attoparsec/Internal/Types.o utils/haddock/stage2/build/Data/Attoparsec/Number.o utils/haddock/stage2/build/Documentation/Haddock/Utf8.o utils/haddock/stage2/build/Documentation/Haddock/Parser/Util.o utils/haddock/stage2/build/Documentation/Haddock.o utils/haddock/stage2/build/Haddock.o utils/haddock/stage2/build/Haddock/Interface.o utils/haddock/stage2/build/Haddock/Interface/Rename.o utils/haddock/stage2/build/Haddock/Interface/Create.o utils/haddock/stage2/build/Haddock/Interface/AttachInstances.o utils/haddock/stage2/build/Haddock/Interface/LexParseRn.o utils/haddock/stage2/build/Haddock/Interface/ParseModuleHeader.o utils/haddock/stage2/build/Haddock/Interface/Specialize.o utils/haddock/stage2/build/Haddock/Parser.o utils/haddock/stage2/build/Haddock/Utils.o utils/haddock/stage2/build/Haddock/Backends/Xhtml.o utils/haddock/stage2/build/Haddock/Backends/Xhtml/Decl.o utils/haddock/stage2/build/Haddock/Backends/Xhtml/DocMarkup.o utils/haddock/stage2/build/Haddock/Backends/Xhtml/Layout.o utils/haddock/stage2/build/Haddock/Backends/Xhtml/Names.o utils/haddock/stage2/build/Haddock/Backends/Xhtml/Themes.o utils/haddock/stage2/build/Haddock/Backends/Xhtml/Types.o utils/haddock/stage2/build/Haddock/Backends/Xhtml/Utils.o utils/haddock/stage2/build/Haddock/Backends/LaTeX.o utils/haddock/stage2/build/Haddock/Backends/HaddockDB.o utils/haddock/stage2/build/Haddock/Backends/Hoogle.o utils/haddock/stage2/build/Haddock/Backends/Hyperlinker.o utils/haddock/stage2/build/Haddock/Backends/Hyperlinker/Ast.o utils/haddock/stage2/build/Haddock/Backends/Hyperlinker/Parser.o utils/haddock/stage2/build/Haddock/Backends/Hyperlinker/Renderer.o utils/haddock/stage2/build/Haddock/Backends/Hyperlinker/Types.o utils/haddock/stage2/build/Haddock/Backends/Hyperlinker/Utils.o utils/haddock/stage2/build/Haddock/ModuleTree.o utils/haddock/stage2/build/Haddock/Types.o utils/haddock/stage2/build/Haddock/Doc.o utils/haddock/stage2/build/Haddock/Version.o utils/haddock/stage2/build/Haddock/InterfaceFile.o utils/haddock/stage2/build/Haddock/Options.o utils/haddock/stage2/build/Haddock/GhcUtils.o utils/haddock/stage2/build/Haddock/Syb.o utils/haddock/stage2/build/Haddock/Convert.o utils/haddock/stage2/build/Paths_haddock.o -o inplace/bin/haddock
Exit code: 1
Stderr:
ld: library not found for -lHSrts_thr
clang: error: linker command failed with exit code 1 (use -v to see invocation)
`clang' failed in phase `Linker'. (Exit code: 1)
)

As haddock requires threaded rts, this can only be fixed, once #100 is done. In the meantime setting
buildHaddock = return False

in Settings/User.hs.

Now fixed. Haddock documentation is not built by default though, use --haddock flag to enable it.
Note: threaded way still needs a lot of work.


Add DCASH - Diabolo Token

[x] I will not ping the Discord about this pull request.

Please provide the following information for your token.
Please include change to the src/tokens/solana.tokenlist.json file in the PR
At minimum each entry should have

Token Address: 26W4xxHbWJfrswaMNh14ag2s4PZTQuu2ypHGj6YEVXkT
Token Name: Diabolo Token
Token Symbol: DCASH
Logo: https://i.imgur.com/257YKjG.png
Link to the official homepage of token: https://diabolo.io

please store logo in this repo under assets/mainnet/

The logo is now added under assets/mainnet/, is that ok?


REVM Tracing Followups

Component
Forge
Have you ensured that all of these are up to date?

[X] Foundry
[X] Foundryup

What version of Foundry are you on?
forge 0.2.0 (e881b75 2022-03-25T00:06:50.568028+00:00)
What command(s) is the bug in?
forge t -vvvv
Operating System
macOS (M1)
Describe the bug
Tracing doesn't seem to always decode correctly. Take for example lil-web3: https://github.com/m1guelpf/lil-web3/
ECRECOVER doesn't get decoded
The following is a call to Ecrecover which we are not decoding. I think we should be decoding it, independently of concerns about new precompiles added in L2s etc.
0x0000…0001::e9435c05(aa81190ba1e7e19f6372616fa7b535045c95be4afcfe0412f0fd9158000000000000000000000000000000000000000000000000000000000000001cc86807a88242d73ca11a9cfb15f54b4ea3793429728ed741d7ca77b17820637b781fb4e20122cda8916eb6dc52e950029dc2e3f5e18c34c87e636a41b9ef7c32)

$ forge t -vvvv -m testRevertsWhenCallReverts

Output

Contract ABI Functions & Events are not decoded
 forge t -m testCanSplitToken -vvvv --force

I've confirmed this is not a caching issue by usage of the --force flag and by rm -rf'ing the cache. I tried moving the new TestNFT() call from setUp() to the constructor, and it didn't seem to change anything, so the fuzzy deploy logic seems to be OK.
I wonder if this has to do with using the ERC721 as a dependency, vs explicitly declaring it in the contract?

we should see what the delta is between the runtime code from the output and the deployed runtime code
our diff_score is quite naive so probably could use with an expansion of scope/sophistication


acknowledge use of code copied from Apache Cassandra

https://github.com/apache/incubator-pekko-persistence-cassandra/blob/5ca43b58c6fe74b29cce776797d250085446fc49/core/src/main/scala/org/apache/pekko/persistence/cassandra/compaction/LeveledCompactionStrategy.scala#L19
https://github.com/apache/incubator-pekko-persistence-cassandra/blob/5ca43b58c6fe74b29cce776797d250085446fc49/core/src/main/scala/org/apache/pekko/persistence/cassandra/compaction/SizeTieredCompactionStrategy.scala#L19
https://github.com/apache/incubator-pekko-persistence-cassandra/blob/5ca43b58c6fe74b29cce776797d250085446fc49/core/src/main/scala/org/apache/pekko/persistence/cassandra/compaction/BaseCompactionStrategy.scala#L21

is it possible just to reference the Cassandra code directly (jar dependency)?
if not, we need entries in our LICENCE and NOTICE acknowledging the copying of this code
we should probably replace our Pekko ASF header with Apache Cassandra ASF header (which is the standard one, unmodified)

https://github.com/apache/cassandra/blob/cassandra-2.2/src/java/org/apache/cassandra/db/compaction/AbstractCompactionStrategy.java

#100 merged


Add github action to auto label issues

Add github action to auto label issues with gssoc21 label when contributor asks to work under gssoc21.

I would love to work on this issue as a part of the girl script summer of code. Kindly assign it to me @sanjay270899

@muthuannamalai12 Go Ahead!

@muthuannamalai12 Update?

@muthuannamalai12 Update?

Sorry for the delay I have created a pull request now


imp(all): Move latest changes from Evmos main (incl. SDK v50)

This PR moves the latest changes from the https://github.com/evmos/evmos main branch into the OS repository. This includes a bunch of dependency bumps and other refactors, most notably bumping the Cosmos SDK version to v0.50.9.

Summary by CodeRabbit

New Features

Introduced a benchmarking suite for performance testing of various transaction types in the Evmos blockchain.
Added an integration test suite for validating Cosmos transaction execution and reward management scenarios.

Improvements

Streamlined transaction creation and signing processes, enhancing clarity and maintainability.
Enhanced account management capabilities within the test suite.

Bug Fixes

Improved accuracy in gas wanted calculations across multiple transaction types.

Documentation

Updated testing framework to ensure comprehensive coverage for transaction handling and performance analysis.

@MalteHerrmann we should add some branch protection rule because ATM I could squash and merge without any approval of the PR.

@MalteHerrmann we should add some branch protection rule because ATM I could squash and merge without any approval of the PR.

I'll update the configuration tomorrow morning!

LGTM! 🚀


Fix #1176: Working  functionality.

Fix _id_s of inputs.

@narayanaditya95 thank you for quick response. The only thing that I'd improve is the commit message, but this is a minor issue so let's merge it.

@narayanaditya95 and I think it would be better to stick with "status: needs code review" label instead of "request a review" functionality.

Ref #1176.
@narayanaditya95 one more thing, please always duplicate the issue ID in the description, otherwise it's not crosslinked. Sorry for being so nitpicky.


feature to execute java code

in the case of quick response required project, ATE xml script might not fulfill the needs of the automation scripting. If the QA automation personnel has knowledge of coding in Java, ATE should be able to let the coder to quickly write some java script to run this ate xml scripts together.

done


chore(release): v1.5.0 🎉

:robot: I have created a release beep boop
1.5.0 (2024-08-03)
Features

uuid: expose genTestUuid procedure (2c17d2c)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/ehmpathy/test-fns/releases/tag/v1.5.0 :sunflower:


Perfect backwards compatibility policy

Curious to hear thoughts on this one - especially from @baggiponte
Narwhals follows a strict subset of the Polars API. What happens if/when some part of this subset gets changed in Polars itself?
For example:

pre 1.0, Polars coalesces overlapping columns in left joins by default
post 1.0, it won't by default

So, what do we do in Narwhals? I'd suggest allowing people to specify which API version they want to follow in pyproject.toml, e.g.:
[tool.narwhals]
api_version = "0.20"

Then:

if somebody specifies api_version = "0.20" in pyproject.toml, then we promise to keep giving them the pre 1.0 behaviour indefinitely (coalesce by default in left joins)
if somebody specifies api_version = "1.0" in pyproject.toml (or if they don't specify it), then we give them the post 1.0 Polars behaviour (don't coalesce by default in left joins)

The idea is that if you implement your library using Narwhals, then so long as you specify an api_version in pyproject.toml, then your code should preserve the same behaviour indefinitely. You may occasionally need to bump your minimum Narwhals package version (so we can deal with working around upstream changes in pandas/Polars/etc), but you should never need to rewrite your dataframe logic, it'll be perfectly backwards-compatible.

Very keen to also get @FBruzzesi and @koaning 's take on this, as consumers. Would you appreciate / be open to specifying a Narwhals api_version in your pyproject.toml, in exchange for the promise that the Narwhals API you use won't change?

So long as we stick to fundamental dataframe operations, and a strict subset of Polars (rather than trying to reimplement everything...) then I think this should be doable!

That can totally work for me, but I am not 100% sure if my tools would really suffer that much from the problems that you describe specifically. A lot of my transformations are stateless things.

From a narwhals user perspective I think this is ideal scenario, leading to minimal/no changes.
I am mostly thinking and concerned  about all the issues with narwhals internals rather than the benefits of this multiple polars api version support. Here a few that comes to mind:

Behaviour changes: it may be some manual effort but fairly straightforward to deal with when one know which version to support.
Methods renaming and/or deprecation: same as above
Keyword renaming and/or deprecation: I noticed that it is happening quite a bit now, before the 1.0 release. This feels significantly harder to deal with in my opinion.

On a similar consideration, how are pandas-like changes dealt with internally to be mapped to the same result? Is there any such situation?

Yeah we already have to do this for some older pandas versions:
https://github.com/narwhals-dev/narwhals/blob/fcd7292dc659cb9adf4bbd6309a68b9492ace014/narwhals/_pandas_like/group_by.py#L164-L167
Most of the Polars renamings deprecations happened for methods a bit on the fringe rather than the fundamental ones - but still, even then, we have to do deal with it sometimes:
https://github.com/narwhals-dev/narwhals/blob/509c370040ba9a00244688184c198163dd2daa5c/narwhals/dataframe.py#L93-L102

This feels significantly harder to deal with in my opinion.

true, but I think we can manage

From a narwhals user perspective I think this is ideal scenario, leading to minimal/no changes.

glad to read this 😄 going to see how hard it is to make this happen then, because API changes in pandas/polars do seem to be a major source of headaches for people trying to build tools on top of them

I think it might still affect even stateless things - suppose for example that Polars renamed shift to lag. scikit-lego uses nw.col(...).shift, so if we were to follow Polars in Narwhals and also rename it, we'd break your code

Fair! But still, the proposed solution sounds totally fine to me.
The only awkward thing that comes to mind is if there is a conflicting dependency. Say, scikit-playtime uses v20 and scikit-lego uses v21. I don't know how realistic this scenario is, but I might imagine a headacke happening here. I don't think there's a way to have two narwhals versions in a single venv.

I think that could still be fine - for code called from scikit-playtime, Narwhals would use the v20 API, and for code called from scikit-lego, it would use the v21 API
(side-note, and I know it's not the point of your comment, but there won't be a v0.20, because the next Polars version is 1.0! 🥳 🍾 🌶 )

Just jumping in the discussion ;).
Does having the info only in the pyproject.toml and thus metadata of the package kind of brittle: is there some settings that this info can be completely overlooked depending on the way the package is installed?

nw = StableNarwhals('0.20.0')

So here the solution is more internal to the source code and thus more explicit. In scikit-learn, it makes me think about the config_context or the set_config that will set some global setting.
with nw.config_context(api_version="0.20"):
    def func_1(df_any):
        ...

or without a context manager:
nw.set_config(api_version="0.20")

def func_1(df_any):
    ...

I can imagine a third-party library to call the set_config into the my_project/__init__.py to set the api version.

I'm late to the party! I basically agree with Guillaume. While it's cool to have the StableAPI (though I'd like to put forward the motion to call it Narwhalificator), I think a global config that can be used as a decorator/context manager makes sense. It's low effort and can be used locally in an efficient manner. Also it does not force you to import the nw object you created somewhere in your library.

Thanks @baggiponte ! I also like the look of just putting
nw.set_config(api_version='0.20')

in skbeer/__init__.py, I just don't know how that works in practice. How would you implement this, so that the api_version that's set in skbeer/__init__.py only takes effect for calls to Narwhals made from within skbeer?

It needs to be possible that:

skbeer uses Narwhals with api_version 0.20
skwine uses Narwhals with api_version 1.0
a user has both installed, and nothing breaks

That's something I haven't considered! @glemaitre how does it work with sklearn?

@glemaitre how does it work with sklearn?

We don't implement such thing so I did not think about the problem :)

a  user has both installed, and nothing breaks

So somehow, you want to register the api_version to a package level. The only thing that I can think of is to have a global dict, where you either use the default or then register a my_package_api_version to not overwrite.
But devil is in the details, maybe implementing this is just to much of a spaghetti code.

Thanks everyone for your inputs 🙏
I've tried implementing this in https://github.com/narwhals-dev/narwhals/pull/331 . It's not finished, but it works well enough that I can test it out in scikit-lego and see what the impact is
Here is what the diff looks like (all tests pass, and this is backwards-compatible - you have the option to use narwhals.StableAPI, but you don't have to, you can just import narwhals as nw and pray for the best):
diff --git a/sklego/linear_model.py b/sklego/linear_model.py
index 99f689b..cc896cc 100644
--- a/sklego/linear_model.py
+++ b/sklego/linear_model.py
@@ -9,7 +9,7 @@ from abc import ABC, abstractmethod
 from inspect import signature
 from warnings import warn

-import narwhals as nw
+from sklego._narwhals import nw
 import numpy as np
 from scipy.optimize import minimize
 from scipy.special._ufuncs import expit
diff --git a/sklego/meta/_grouped_utils.py b/sklego/meta/_grouped_utils.py
index 97180ab..a6657c9 100644
--- a/sklego/meta/_grouped_utils.py
+++ b/sklego/meta/_grouped_utils.py
@@ -2,7 +2,7 @@ from __future__ import annotations

 from typing import List

-import narwhals as nw
+from sklego._narwhals import nw
 import pandas as pd
 from scipy.sparse import issparse
 from sklearn.utils import check_array
diff --git a/sklego/meta/_shrinkage_utils.py b/sklego/meta/_shrinkage_utils.py
index 0c82bf2..0398af4 100644
--- a/sklego/meta/_shrinkage_utils.py
+++ b/sklego/meta/_shrinkage_utils.py
@@ -1,6 +1,6 @@
 from functools import partial

-import narwhals as nw
+from sklego._narwhals import nw
 import numpy as np
 from sklearn.utils.validation import check_is_fitted

diff --git a/sklego/meta/grouped_predictor.py b/sklego/meta/grouped_predictor.py
index 1cf3770..ef0941a 100644
--- a/sklego/meta/grouped_predictor.py
+++ b/sklego/meta/grouped_predictor.py
@@ -1,7 +1,7 @@
 from copy import deepcopy
 from typing import List, Union

-import narwhals as nw
+from sklego._narwhals import nw
 import numpy as np
 import pandas as pd
 from sklearn import clone
diff --git a/sklego/meta/grouped_transformer.py b/sklego/meta/grouped_transformer.py
index 0a731b2..1a77818 100644
--- a/sklego/meta/grouped_transformer.py
+++ b/sklego/meta/grouped_transformer.py
@@ -1,6 +1,6 @@
 from typing import Union

-import narwhals as nw
+from sklego._narwhals import nw
 import numpy as np
 from sklearn.base import BaseEstimator, MetaEstimatorMixin, TransformerMixin, clone
 from sklearn.utils.validation import check_is_fitted
diff --git a/sklego/meta/hierarchical_predictor.py b/sklego/meta/hierarchical_predictor.py
index 01f9a51..8096707 100644
--- a/sklego/meta/hierarchical_predictor.py
+++ b/sklego/meta/hierarchical_predictor.py
@@ -1,6 +1,6 @@
 from warnings import warn

-import narwhals as nw
+from sklego._narwhals import nw
 import numpy as np
 import pandas as pd
 from joblib import Parallel, delayed
diff --git a/sklego/meta/regression_outlier_detector.py b/sklego/meta/regression_outlier_detector.py
index 7ba2230..9ecb0e7 100644
--- a/sklego/meta/regression_outlier_detector.py
+++ b/sklego/meta/regression_outlier_detector.py
@@ -1,4 +1,4 @@
-import narwhals as nw
+from sklego._narwhals import nw
 import numpy as np
 from sklearn import clone
 from sklearn.base import BaseEstimator, OutlierMixin
diff --git a/sklego/model_selection.py b/sklego/model_selection.py
index edc8f86..74df119 100644
--- a/sklego/model_selection.py
+++ b/sklego/model_selection.py
@@ -3,7 +3,7 @@ from datetime import timedelta
 from itertools import combinations
 from warnings import warn

-import narwhals as nw
+from sklego._narwhals import nw
 import numpy as np
 import pandas as pd
 from sklearn.exceptions import NotFittedError
diff --git a/sklego/pandas_utils.py b/sklego/pandas_utils.py
index e78da98..02ee895 100644
--- a/sklego/pandas_utils.py
+++ b/sklego/pandas_utils.py
@@ -2,7 +2,7 @@ import datetime as dt
 import inspect
 from functools import partial, wraps

-import narwhals as nw
+from sklego._narwhals import nw
 import numpy as np
 from scipy.ndimage import shift

diff --git a/sklego/preprocessing/pandastransformers.py b/sklego/preprocessing/pandastransformers.py
index 1d516c3..bc68bfd 100644
--- a/sklego/preprocessing/pandastransformers.py
+++ b/sklego/preprocessing/pandastransformers.py
@@ -3,7 +3,7 @@ from __future__ import annotations
 import warnings
 from typing import Any

-import narwhals as nw
+from sklego._narwhals import nw
 from narwhals.dependencies import get_pandas
 from sklearn.base import BaseEstimator, TransformerMixin
 from sklearn.utils.validation import check_is_fitted
diff --git a/sklego/preprocessing/projections.py b/sklego/preprocessing/projections.py
index b99df9f..1d1ae2c 100644
--- a/sklego/preprocessing/projections.py
+++ b/sklego/preprocessing/projections.py
@@ -1,4 +1,4 @@
-import narwhals as nw
+from sklego._narwhals import nw
 import numpy as np
 from sklearn.base import BaseEstimator, TransformerMixin
 from sklearn.utils import check_array

I think this is fairly minimal, and gives a way to promise consumers: code you write today will keep working x years from now.
This is inspired by Rust editions, so there is a working precedent for doing this, just not (as far as I'm aware) in the Python space
Any feedback on the design? Would you use this? Does any part of it risk being confusing? 🙏

@MarcoGorelli Have you considered having different classes for the different editions? StableAPIv1, StableAPIv2...
Without that, I don't know how static types can reflect things like cum_sum in 1.0 becoming cumulative_sum in 2.0.
(Also, hello from the Shiny team--we're thinking about using Narwhals for our various dataframe related features!)

Thanks @jcheng5 for your input! Indeed, static types are in issue in the proposal I'd written previously
Something I'm trying out is
import narwhals.stable.v0_20 as nw
# import narwhals.stable.v1_0 as nw

in which things seem to be behaving a lot more nicely
Also, that's amazing that you're considering Narwhals for use in Shiny 🙏 ! Please do let me know if there's anything I can do on the Narwhals side that would make it easier for (e.g. any missing features you need?), and feel free to book time on https://calendly.com/marcogorelli if that would be easier over a call

@MarcoGorelli Have you considered having different classes for the different editions? StableAPIv1, StableAPIv2...

Alright, this took some effort, but narwhals.stable.v1_0 is now implemented in https://github.com/narwhals-dev/narwhals/pull/410
There's several check to ensure it stays up-to-date with the main namespace
I've also sneakily added Expr._taxicab_norm, so we can make as-realistic a test as possible that, in narwhals.stable.v1_0, we can rename it to Expr._l1_norm with this affecting the main namespace


Error: Mic icon not visible in dark mode.

Describe the Error
Error: Mic icon not visible in dark mode.
Expected behavior
A white color icon for mic or a white bg required in dark mode.
Additional context
It is present in black but not visible unless hovered for user in dark mode
###Screenshot of the issue

Resolved the issue with pr #1021


Possibility to get original response.

*add - lastResponse to SoapClient - possibility to get lastResponse xml/string for monitoring etc

Pull Request Test Coverage Report for Build 344

2 of 3 (66.67%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.2%) to 89.459%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/SoapClient.php
2
3
66.67%

Totals

Change from base Build 323:
-0.2%

Covered Lines:
331

Relevant Lines:
370

💛  - Coveralls

This is needed to get last response as it was - for monitoring, debugging etc. We have to log all the communication as it was done - so we need the original response too.


"Beceni" is listed in the drop-down menu

Description:
"Beceni" is listed in the drop-down menu alongside its corresponding county and commune, according to the law
Precondition:
The website is up an running.

Step 1
Type "Beceni" in the search bar.

Expected results
The location is listed in the drop-down menu as "Beceni, Buzău".


Support Raw Cell for jupyter notebook

Feature: Notebook Editor, Interactive Window, Python Editor cells

Description
Currently vscode-python supports only Code mode and Markdown mode for cells, while Raw cell is not allowed, and the Raw cells in other ipynb files are renderd as blank chunk.

Thanks for the suggestion

+1, the lack of this feature makes Jupyter in VS Code unusable in my case, raw cells are often used by myself and colleagues.

+1, I'm troubled with the unavailliblity of this feature in VsCode as our members use it on a daily basis and boom VsCode doesnt have it. Please Add them to VsCode.

VSCode Native Notebook (Don)

We open raw cells as raw language and VSC displays them as Plain text`, possibly because VSC doesn't support the language
Internal Notes:

Add support for raw as a language or use plain text as a language
Can we contribute to a 3rd type of cell (like markdown and code)
Using raw as a language doesn't really work, as its not a language but another cell type.


Cannot run calcDenseVelocity with campars=None

https://github.com/PennyHow/PyTrx/blob/cd614be2ea3800095ce7eadbe018580a04e55397/PyTrx/Velocity.py#L674
calcDenseVelocity should be able to run with campars = None but, campars is indexed as a list therefore runs into an error if it is not supplied. I wanted to run calcDenseVelocity on two orthoimages resampled in the same grid, and therefore did not need any camera parameters or DEMs. The docstring suggests that the function can be run without campars. It should be stated clearly whether or not campars is needed for the function.

Thanks for flagging this. We have now added additional functionality, with image grid seeding and DEM grid seeding - seedGridIM and seedGridDEM. So now, if the campars variable is None then the grid will be seeded from the image rather than the input DEM.
https://github.com/PennyHow/PyTrx/blob/a4fb76986dda98b5432c43d65c704915cafc2904/PyTrx/Velocity.py#L677-L680
I'd really like you to check that this is working before we put it into the next PyTrx release. Please could you clone the newest version of our development branch, and see if it works with your workflow.


Increase brightness of click /focus highlight across components

Current theme examples:

Next theme:

@KrooshalUX Do you mind adding screenshots when you get a chance here? I think I remember the issue, but I want to make sure we fix the right thing.

@joshuarrrr  updated with examples from discover. SEeing them side-by-side, this may be OK. The dark mode on both current and next are equally dull and blend in with their respective backgrounds, so we may want to address the overall way this is implemented?

Should be done with #948


[download-microservice] Refactor: Clarify Execution, make bin finding clearer

This PR first addresses some great points @DeeDeeG brought up about code clarity, and aims to make things much more clear in behavior.
Secondly, since a refactor was already taking place, this PR removes likely the biggest portion of code. That is finding the bins. Previously this was a big long if...else which has no been replaced by a simple object, that allows easy lookup and definition of how to find each bin.
The ./bin.js file exports an object where the top level key is the OS for each supported platform, which itself then has a top level key to each type of supported installation on said platform. From there the following keys are supported to execute a check against the binary asset name:

startsWith: Executes string.startsWith(value)
endsWith: Executes string.endsWith(value)
endsWithNot: Executes !string.endsWith(value)

This way instead of repetitive code, with the definitions of how we find the binaries obscured within it, we instead have a single function decode this object into code with the clarity of the definitions being much more important.

Just going to plunk down a link to a branch I was working on, as I hadn't see you were working on this!
https://github.com/pulsar-edit/package-frontend/compare/main...DeeDeeG:package-frontend:download-refactor-plus-more-error-handling
I can have a look at what you've got here as well, but maybe I shouldn't have suggested changes, bopped offline, gone in a meditative trance editing these files a ton, watched some media, eaten a meal or two, and then come back online several hours later to see you've already done it yourself!

Premise as per the PR description sounds really good, and kind of reaches all the things I wasn't bold enough to reach for as a contributor as opposed to original author. Probably gonna be pretty good, but I've been neck deep in the previous way of doing it for a few hours off and on, lol. So it'll take me a bit to absorb all these changes, but I think it's looking good at a first glance as well.

@DeeDeeG I gotta say, I really love the changes you have on your branch.
If you want we can build these off of each other, or I can simplify mine to only focus on the bin search changes, since that is what I care most about in this PR. Since otherwise I'd say your clarification and safety changes are much more thorough and functional than what I've got here

My favorite stuff in mine lives in index.js and might not conflict with your PR that much? That stuff can be slotted in independently of my changes in utils.js (thanks to the concerns being very cleanly separated by the original author I might point out) and I think your new approach by making all the binary info be data rather than directly as logic is really clean conceptually, so I might lean pretty heavily toward your stuff in utils.js and bins.js, as my first instinct here as I'm getting up to speed with your changes.
Reading as I go, lol.

Also, I have a small thing on utils.js that helps dev mode work, if an auth token 12345 is supplied, GitHub will reject it with an error, so I delete the Auth token bearer header thing in "dev mode":
https://github.com/DeeDeeG/package-frontend/blob/007e7a2654a4773de3bdc48770249dacb8e35a41/microservices/download/utils.js#L28-L32
Would love to see something along those lines to be able to test the microservice without auth some way.

Woot, thanks for everything on this one @DeeDeeG
Lets get it merged and pushed to prod!


Add run_exports

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

Closes #1

See https://github.com/conda-forge/libcint-feedstock/issues/1#issuecomment-961225839 for reference.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@conda-forge-admin, please rerender

Couple of questions:

Upstream follows SemVer so the pin should be correct but should I confirm that explicitly?
Should the package be added to conda-forge pinning? I'm using it as a dependency in a different package.

Looks good!
It's not strictly necessary to add it to conda-forge-pinnings if it's only used by one/few other packages. But it's always a good idea! It will make you get automated migrations should the version here change beyond the run exports.


[Feature] Add MapConstructor in backend

What type of PR is this：

[ ] BugFix
[x] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Which issues of this PR fixes ：

Fixes #
Problem Summary(Required) ：

Implement Map Constructor in Backend.
This function constructs a map from the key array and value array. For example:
map([1,2], [3,4]) will construct a map {1:3,2:4}

run starrocks_be_unittest


Add package.xml

🎉 New feature
Summary
Add package.xml based on dependencies found in .github/ci/packages.
This is to test out using vendor packages to provide Gazebo packages to ROS users (see https://github.com/gazebo-tooling/release-tools/issues/1117).
Test it

Checklist

[ ] Signed all commits for DCO
[ ] Added tests
[ ] Added example and/or tutorial
[ ] Updated documentation (as needed)
[ ] Updated migration guide (as needed)
[ ] Consider updating Python bindings (if the library has them)
[ ] codecheck passed (See contributing)
[ ] All tests passed (See test coverage)
[ ] While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Needs https://github.com/gazebosim/gz-tools/pull/140 to fix windows.


Install script UX: ask to load wireguard mod & install missing deps for Debian repo

Fixes firezone/product#449 (bullets 1 & 2)
This PR will install potentially missing dependencies Cloudsmith needs to make
it less noisy with NOPE warnings. I also added a prompt to load the wireguard
kernel module from the script if the user chooses to do so. It follows from our
previous pattern of prompts in the script.

Pull Request Test Coverage Report for Build a5ee745a496a9a7c73c734dfd430957c4966e78d-PR-907

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 67.521%

Totals

Change from base Build 0a7c16af17eba143659c7f7702f71c4b868e9282:
0.0%

Covered Lines:
1054

Relevant Lines:
1561

💛  - Coveralls


feature:server zookeeper digest support

Ⅰ. Describe what this PR did
server zookeeper digest support
Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews

Codecov Report

Merging #2368 into develop will decrease coverage by 0.16%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             develop    #2368      +/-   ##
=============================================
- Coverage       51.6%   51.44%   -0.17%
+ Complexity      2693     2691       -2
=============================================
  Files            517      517
  Lines          16734    16734
  Branches        2039     2009      -30
=============================================
- Hits            8636     8609      -27
- Misses          7290     7291       +1
- Partials         808      834      +26

Impacted Files
Coverage Δ
Complexity Δ

...obuf/convertor/BranchRegisterRequestConvertor.java
90.47% <0%> (-9.53%)
3% <0%> (ø)

...otobuf/convertor/GlobalBeginResponseConvertor.java
92.59% <0%> (-7.41%)
3% <0%> (ø)

...otobuf/convertor/GlobalStatusRequestConvertor.java
93.75% <0%> (-6.25%)
3% <0%> (ø)

...otobuf/convertor/GlobalCommitRequestConvertor.java
93.75% <0%> (-6.25%)
3% <0%> (ø)

...obuf/convertor/GlobalRollbackRequestConvertor.java
93.75% <0%> (-6.25%)
3% <0%> (ø)

...protobuf/convertor/RegisterTMRequestConvertor.java
94.73% <0%> (-5.27%)
3% <0%> (ø)

...protobuf/convertor/RegisterRMRequestConvertor.java
90.47% <0%> (-4.77%)
3% <0%> (ø)

...tobuf/convertor/BranchReportResponseConvertor.java
95.45% <0%> (-4.55%)
3% <0%> (ø)

...otobuf/convertor/BranchReportRequestConvertor.java
95.45% <0%> (-4.55%)
3% <0%> (ø)

...buf/convertor/BranchRegisterResponseConvertor.java
95.83% <0%> (-4.17%)
3% <0%> (ø)

... and 14 more

@a364176773  Thanks.Please add these new configuration items in all places.
https://github.com/seata/seata/blob/develop/seata-spring-boot-starter/src/main/java/io/seata/spring/boot/autoconfigure/properties/registry/RegistryZooKeeperProperties.java
https://github.com/seata/seata/blob/develop/seata-spring-boot-starter/src/main/java/io/seata/spring/boot/autoconfigure/properties/registry/ConfigZooKeeperProperties.java
https://github.com/seata/seata/tree/develop/script/client/spring
https://github.com/seata/seata/tree/develop/script/client/conf

@a364176773 Thanks.Please add these new configuration items in all places.
https://github.com/seata/seata/blob/develop/seata-spring-boot-starter/src/main/java/io/seata/spring/boot/autoconfigure/properties/registry/RegistryZooKeeperProperties.java
https://github.com/seata/seata/blob/develop/seata-spring-boot-starter/src/main/java/io/seata/spring/boot/autoconfigure/properties/registry/ConfigZooKeeperProperties.java
https://github.com/seata/seata/tree/develop/script/client/spring
https://github.com/seata/seata/tree/develop/script/client/conf

this pr is to supplement the missing data last time

@a364176773 Thanks.Please add these new configuration items in all places.
https://github.com/seata/seata/blob/develop/seata-spring-boot-starter/src/main/java/io/seata/spring/boot/autoconfigure/properties/registry/RegistryZooKeeperProperties.java
https://github.com/seata/seata/blob/develop/seata-spring-boot-starter/src/main/java/io/seata/spring/boot/autoconfigure/properties/registry/ConfigZooKeeperProperties.java
https://github.com/seata/seata/tree/develop/script/client/spring
https://github.com/seata/seata/tree/develop/script/client/conf

already done.


Support an exec hook execution driver

Currently, lakeFS supports only Webhooks. While easy to understand, they are not always easy in terms of operations:

They require a server to be deployed and provide an uptime SLA
They require setting up network communication between said server and lakeFS
Depending on security protocols, they often require some sort of authetication
They make very simple things more complex than needed (i.e. a one-liner in bash now needs to be wrapped in a web application)
They make it hard to experiment locally, if lakeFS is running in Docker container due to Docker networking woes (a Docker container by default cannot access network ports of the hosting machine)

To make hooks easier to get started with, lakeFS should support a simpler type of hooks - that execute some behavior directly by the lakeFS server.
This could be calling out to a command line directly, doing docker run on a provided image, or integrating with existing orchestration/scheduling tools that already exist in the organization such as Kubernetes (discovery required)

@ozkatz can we close this one?
https://github.com/treeverse/lakeFS/blob/0ca69c4f0f7550e8af4e513a305a6c8732ae5d3a/design/rejected/k8s-job-hook.md

Yes. As we're rethinking how to execute hooks in a better way, I suggest closing this issue in the meantime as it is unlikely to be implemented in its current form.


Is there a way to transfer 3des?

Is there a way to transfer 3des?

I'm not sure what you mean by "transfer 3des" can you explain?

This plug-in can only encrypt des？ I want to use 3des.

There is a triple des encoder as well

How do I pass the key and initialization vector to encrypt my string?
Please look at one example from Microsoft, I would like to mimic the same using your flutter APIs.
https://docs.microsoft.com/en-us/dotnet/api/system.security.cryptography.tripledescryptoserviceprovider?view=netframework-4.7.2
Thanks

Hi @johnpryan,
Can you answer my previous question. I'm badly looking for initial vector support with tripledes APIs. Thanks.

Hi @johnpryan,
Can you answer my previous question. I'm badly looking for initial vector support with tripledes APIs. Thanks.

Same issue here. How do I do 3DES encryption assuming the code example is for DES

Hi @johnpryan,
Can you answer my previous question. I'm badly looking for initial vector support with tripledes APIs. Thanks.

Hi @johnpryan thanks for writing the library 👱♂
Same issue here. How do I do 3DES encryption assuming the code example is for DES


Should reloader load in a go routine or not?

// refreshAsync reloads value in a go routine or using custom executor if defined.
func (c *localCache) refreshAsync(en *entry) bool {
	if en.setLoading(true) {
		// Only do refresh if it isn't running.
		if c.reloader == nil {
			go c.refresh(en)
		} else {
			c.reload(en)
		}
		return true
	}
	return false
}

Inspecting the code, I find that the loader refresh in a new go routine, while reloader reload in the current routine. Why the difference? Should we define the loader load in new go routine, or current routine?

reloader is a user-defined way to refresh cache entries, e.g. using a pool to avoid creating a new goroutine for each refresh.
loader is a cache loader function, must be synchronous.


Error: File chooser handling does not work with multiple connections to the same page

Steps to reproduce
Tell us about your environment:

Puppeteer version: 1.19.0
Platform / OS version: Ubuntu 19.04
Node.js version: v12.6.0

What steps will reproduce the problem?

 config.chrome_options.push(
 `--disable-extensions-except=${extensionPath}`,
 `--load-extension=${extensionPath}`,
 `--proxy-server=${proxy_server}`)
 if (config.executable_path === "" || config.executable_path === false) {
 	this.browser = await puppeteer.launch({
 		headless: config.chrome_headless,
 		args: config.chrome_options,
 		defaultViewport: {"width": 1024, "height": 768}
 	});
 } else {
 	this.browser = await puppeteer.launch({
 		headless: config.chrome_headless,
 		args: config.chrome_options,
 		executablePath: config.executable_path,
 		defaultViewport: {"width": 1024, "height": 768}
 	});
 }
 bot = await this.browser.newPage();
 bot.setViewport({"width": 1024, "height": 768});
 let user_agent = await this.browser.userAgent();
 bot.setUserAgent(user_agent.replace("Headless", ""));

 await this.bot.emulate(iPhone);
 let selector = "span[aria-label=\"New Post\"]";
 await this.bot.waitForSelector(selector, {timeout: 5000});
 await this.utils.sleep(this.utils.random_interval(3, 4));
 var filePath = path.relative(process.cwd(), this.config.assets_path + photo);
 const [fileChooser] = await Promise.all([

 this.bot.waitForFileChooser(),

 this.bot.click(selector),

 ]);
 await fileChooser.accept([filePath]);

What is the expected result?
Upload file.
What happens instead?
Error: File chooser handling does not work with multiple connections to the same page

same issue with puppeteer.connect

I'm facing exactly the same issue:
Error: File chooser handling does not work with multiple connections to the same page
But only happens in docker. It's working fine on Mac and Windows machines.

Occurs when using electron-builder.

Yeah, I'm seeing the same issue when running locally on Mac, are there specific configuration changes that eliminate this issue?

For Windows 10 I solved the problem by using chromium instead of chrome.

@Ermolaev-Nikolay thanks!  Using Chromium worked for me as well - would be nice to have the functionality within both though.


Distribution is calculated apparently wrong

Distribution should be owned items by users / unique owners
Target collection

Ref https://github.com/kodadot/nft-gallery/issues/978


Slide gesture to adjust intensity of presets

Calin-daire,
Thanks for creating this.  I was looking for API to develop my aforementioned request and found your app.
Will you please consider implement this or share some pointers on how to implement this that I may try to contribute a PR?
Basically I want a quick way to adjust the overall intensity while preserving the preset's fixed ratio of warm/cold light.
A slide gesture would be great, but failing that, having that option within your app will suffice - oh this latter option might be a easier PR... let me check your code again.
Tim

The implementation changed in new FW of onyx (3.4). User sets the warmth and brightness instead of "cold" and  "warm" light.


formatWebpackMessages swallows the filename with Webpack 5 and TypeScript

Describe the bug
When running a TypeScript project created with the latest create-react-app (5.0.1), TypeScript compile errors will not include the filename that the error occurred in. This can make tracking down errors tedious.
The cause appears to be how Webpack 5 formats errors combined with how formatWebpackMessages processes those errors. The message object passed to formatMessage in formatWebpackMessages.js contains separate message and file properties and in the case of TypeScript errors, the file name is not included in the message property, only the file property.
As a workaround for myself I have changed the formatMessage function to include the file property. This is hacky, since for one thing it duplicates the filename in the case that the message property includes the filename, but gets me past having to search for the file manually.
I changed lines 22-23 from
  } else if ('message' in message) {
    lines = message['message'].split('\n');

to
  } else if ('message' in message) {
    lines = message['message'].split('\n');

    if ('file' in message) {
      lines.unshift(message.file);
    }

Did you try recovering your dependencies?
Not Applicable
Which terms did you search for in User Guide?
Not Applicable
Environment
Environment Info:
current version of create-react-app: 5.0.1
running from C:\Users\prijks\AppData\Local\npm-cache_npx\c67e74de0542c87c\node_modules\create-react-app
System:
OS: Windows 10 10.0.19042
CPU: (20) x64 Intel(R) Core(TM) i9-10900X CPU @ 3.70GHz
Binaries:
Node: 16.13.0 - C:\Program Files\nodejs\node.EXE
Yarn: Not Found
npm: 8.1.0 - C:\Program Files\nodejs\npm.CMD
Browsers:
Chrome: Not Found
Edge: Spartan (44.19041.1266.0), Chromium (101.0.1210.32)
Internet Explorer: 11.0.19041.1566
npmPackages:
react: ^18.1.0 => 18.1.0
react-dom: ^18.1.0 => 18.1.0
react-scripts: 5.0.1 => 5.0.1
npmGlobalPackages:
create-react-app: Not Found
Steps to reproduce

Create a new app with npx create-react-app react-webpack-message-test --template cra-template-typescript
Introduce a TypeScript error to the app (e.g. by adding an invalid import to App.tsx) - note that it needs a TypeScript error and not a syntax error
Compile with npm run build

Expected behavior
Compile error includes the filename
Actual behavior
Compile error does not include the filename. The output I get when running the steps above is:
> react-scripts build

Creating an optimized production build...
Failed to compile.

TS2307: Cannot find module 'not-a-real-thing' or its corresponding type declarations.
    1 | import React from 'react';
    2 | import logo from './logo.svg';
  > 3 | import foobar from 'not-a-real-thing';
      |                    ^^^^^^^^^^^^^^^^^^
    4 | import './App.css';
    5 |
    6 | function App() {

Note there is no filename in that output.
Reproducible demo
Demo
Clone the demo, then install dependencies, then run the build script.
Can also be reproduced by creating a project following the reproduce steps above

I'm hitting the same problem.
Not knowing the file in which the build error has occurred can make it difficult to locate the error in a codebase of non-trivial size.

Seeing the same issue. Also seems to be reported on stackoverflow here by two other users: https://stackoverflow.com/questions/71179647/getting-a-filename-from-react-scripts-build

https://github.com/facebook/create-react-app/pull/12712


non rooted option

How do I install this without root?

check the readme

Oh I thought maybe I needed something different but it worked thanks. Will there be a auto updating version or will i need to re-download it everytime there's an update?

Oh I thought maybe I needed something different but it worked thanks. Will there be a auto updating version or will i need to re-download it everytime there's an update?

Discord update, yes. Revenge update, no.


Broken link to user guide

Link to user guide at the end of the getting started guide to troubleshooting section is broken
https://www.kubeflow.org/docs/started/getting-started/

Still broken.

Ran a broken link checker docker run --rm ktbartholomew/link-checker https://www.kubeflow.org/
We have 16 broken links:
[ BROKEN ] URL:      https://www.kubeflow.org/docs/started/getting-started/user_guide.md
           Error:    Error: Not Found
           Referrer: https://www.kubeflow.org/docs/started/getting-started/
           Element:  user guide
[ BROKEN ] URL:      http://<IP_ADDRESS>:8000/
           Error:    Error: connect ECONNREFUSED <IP_ADDRESS>:8000
           Referrer: https://www.kubeflow.org/docs/about/user_guide/
           Element:  <a href="http://<IP_ADDRESS>:8000">http://<IP_ADDRESS>:8000
[ BROKEN ] URL:      https://www.kubeflow.org/docs/about/user_guide/components/jupyterhub
           Error:    Error: Not Found
           Referrer: https://www.kubeflow.org/docs/about/user_guide/
           Element:  documentation
[ BROKEN ] URL:      https://github.com/kubeflow/kubeflow/blob/master/user_guide.md
           Error:    Error: Not Found
           Referrer: https://www.kubeflow.org/docs/about/user_guide/
           Element:  see here
[ BROKEN ] URL:      http://localhost:8080/
           Error:    Error: connect ECONNREFUSED <IP_ADDRESS>:8080
           Referrer: https://www.kubeflow.org/docs/started/getting-started-minikube/
           Element:  http://localhost:8080/
[ BROKEN ] URL:      http://localhost:8000/
           Error:    Error: connect ECONNREFUSED <IP_ADDRESS>:8000
           Referrer: https://www.kubeflow.org/docs/started/getting-started-minikube/
           Element:  http://localhost:8000/
[ BROKEN ] URL:      https://www.kubeflow.org/docs/about/contributing/CODE_OF_CONDUCT.md
           Error:    Error: Not Found
           Referrer: https://www.kubeflow.org/docs/about/contributing/
           Element:  Code of Conduct
[ BROKEN ] URL:      https://github.com/issues?utf8=%E2%9C%93&q=is%3Aopen+is%3Aissue+org%3Akubeflow+archived%3Afalse+label%3A%22good+first+issue%22
           Error:    Error: Not Found
           Referrer: https://www.kubeflow.org/docs/about/contributing/
           Element:  good first issue
[ BROKEN ] URL:      https://github.com/issues?utf8=%E2%9C%93&q=is%3Aopen+is%3Aissue+org%3Akubeflow+archived%3Afalse+label%3A%22help+wanted%22
           Error:    Error: Not Found
           Referrer: https://www.kubeflow.org/docs/about/contributing/
           Element:  help wanted
[ BROKEN ] URL:      https://github.com/issues?utf8=%E2%9C%93&q=is%3Aopen+is%3Aissue+org%3Akubeflow+archived%3Afalse+label%3A%22starter%22
           Error:    Error: Not Found
           Referrer: https://www.kubeflow.org/docs/about/contributing/
           Element:  starter
[ BROKEN ] URL:      https://github.com/kubernetes/contrib/blob/master/ingress/controllers/gce/examples/health_checks/READMEmd
           Error:    Error: Not Found
           Referrer: https://www.kubeflow.org/docs/started/getting-started-gke/
           Element:  K8s docs
Crawl complete! Broken: 16 Broken/Total: 0.02792

/assign @jlewi


Fix global phase coming from optimize_1q_gates

Summary
This PR fixes #3083.
Details and comments

I refactored the function def run(self, dag) in several functions to increase readability
New function def can_combine(self, left_node, right_node) checks if it is possible to combine two nodes preserving the global phase
Update def test_optimize_to_nothing(self) to respect global phase
Included the function def test_global_phase(self) to test issue #4036

Hi @1ucian0 and @ajavadia, this PR is outdated and I think it can be closed.

Hi @1ucian0 and @ajavadia, this PR is outdated and I think it can be closed.

Is it because #3083 is already solved?

Is it because #3083 is already solved?


Implement sighash

This can be merged as-is with the understanding that no other code should be using it yet, and the associated issue 306 is not complete, to unblock a reorg of the zebra-chain crate.

@yaahc I can merge this by squashing, but a rebase has conflicts

squash is preferred, tyty


Add Support for PKCS8 DER/PEM writing

Enhancement
Currently mbedtls can not write private keys in PKCS8 format, although it is able to parse PKCS8 format.

Since PKCS8 also supports not-yet existing key types since it is extendable it would be a future proof format for key exchange.
Another reason would be that some TLS implementations do not support PKCS1 for private key exchange (like JAVA).

Adding support for PKCS8 PEM/DER writing should be relatively simple since it is only an added envelope.

I'll second this request! I just had to learn enough ASN1 to extract the public and private from the SEC1 output of mbedtls_pk_write_key_der() and re-write it as PKCS8 (in Swift.. so not a lot of prior art). My brain is still hurting.

I just put my implementation in a pull request: https://github.com/ARMmbed/mbedtls/pull/1759
The pull request is against development, but it should also apply to 2.8.0, which I used for development/testing.

PR fixing this issue was opened in #1759 , superseded by https://github.com/ARMmbed/mbedtls/pull/2413


Use artifactType from image manifest

This updates the guidance to use the artifactType value first, and fall back to the config.mediaType when determining the artifactType to set in the referrers response. This should be merged after https://github.com/opencontainers/image-spec/pull/1043 is approved.

lgtm

@andaaron

From the perspective of the consumer of the API does it matter if the match is made on the config descriptor mediaType or the artifactType? I guess if someone codes a client which handles a limited types of artifacts it doesn't matter, because he can handle each case individually by verifying the artifactType value, but I think there should be a way to distinguish the source of the artifact type value in the reply itself to handle more generic cases.

I'm looking at it from a progressive upgrade with backwards compatibility. An existing artifact that has a dedicated config blob and media type can continue using that to avoid impacting existing clients. A new artifact that needs a config blob, but also wants a specific artifactType can do that, and find itself using that artifactType. And a new artifact without a config blob is required to specify an artifactType because "scratch" isn't the real artifact type.
I'm hoping that artifacts with a specific type will be created according to some spec from that artifact producer, and have the fields set consistently according to their spec (e.g. all Helm charts follow a Helm spec). From the listing we shouldn't care how the artifactType value was determined, only that it has a specific value that we want.

@sudo-bmitch
If you put it like this (all tooling will eventually converge to check artifactType first, or will have special handling for individual artifact specs), then it makes sense.

@andaaron the goal of the phrasing is to say "check artifactType first, and fall back to using config.mediaType". Suggestions for better wording in the spec is welcome, because I'm not happy with it either.

@andaaron the goal of the phrasing is to say "check artifactType first, and fall back to using config.mediaType". Suggestions for better wording in the spec is welcome, because I'm not happy with it either.

I'm fine with the wording as long as the other consumers of the image spec use the same rationale when reading a manifest. That was my concern.

@mikebrow can I get a re-approve? (adding jons suggestion dismissed your review)

This has been updated with the changes from today's meeting. PTAL.


wellness settings (hide numbers etc)

Is your feature request related to a problem? Please describe.
Other clients I've seen have various "wellness settings" such as turning off various metric numbers like boost/like counts, follower counts, notification counts, as well as various accessibility options.
Describe the solution you'd like
I would like it if Phanpy had similar settings to promote wellness/reduce social media anxiety.
Describe alternatives you've considered
Clients with these types of settings include Elk and Enafore. Screenshots below of the settings they have for inspiration here.
Additional context

hi! i’d also really love to have these features. i mostly lurk, but i posted something recently that had some amount of interaction, and the bell icon having a dot really stressed me out. i would love to be able to turn off that button and only view notifications from the dropdown. all these other features would also be great, but that one is the big one to me

PR #849 could address some (but not all) of these


Mangos Bot addon compatibility

It's essential that this module work w/ this addon:
https://github.com/ike3/mangosbot-addon
The only thing I've found that might help me figure out what commands are available in it's current form is here:
https://github.com/ZhengPeiRu21/mod-playerbots/issues/5

Because this is ported from same IKE3 source, the addon should only need minor adjustment. I think the largest difference is AzerothCore playerbot commands begin with ".playerbot" prefix - if addon is changed to account for this, much of it I think should work.

I've started making progress on this, not totally working yet but it's a start:
https://github.com/whipowill/wow-addon-playerbot

Thank you for starting on updating the addon! When it is ready to level of would like others to test, please let me know and I will include it in the README for the module.

I repushed this addon as force to overwrite what I had before, I had started w/ the wrong code.  Now starting w/ the right code, I only had to make minimal changes.  I think this new version is ready to go.
The issues I'm experiencing now is that the bot itself, server-side, just won't do what I am telling him to do -- but according to this addon, the commands are being sent correctly and are being received correctly, it's just the bot code server-side won't do it right.

Just a heads up, I'm putting together all the known/available chat commands in a tidy list here:
https://github.com/whipowill/wow-addon-playerbots/blob/master/MANUAL.md


Documentation update, user exposed interface cleanup

See individual commit messages and haddock pages for more details.
This is mostly cosmetic changeset with no or minimal (see one of the commit messages) functionality change.
We still need the Gauge monad to be exposed (Gauge, askConfig etc.) for allowing the use of runBenchmark function by users, though I doubt if anyone will really need this function. To be consistent either we do not expose this function or expose the minimal types needed to use this.
It should be noted that the module structuring is not the same as Criterion and therefore existing criterion code (imports) may have to be massaged a bit to adapt. Just importing Gauge should bring everything a user needs (except Gauge.Analysis which nobody would ever need and we want to keep it separate, so I kept it out of Gauge). Though individual modules are also available for import.

Thanks. I'm a bit concerned that we are diverging more and more in breaking way with the user facing API.

@vincenthz we need to give it a thought and take a stand on general policy. Do we want the existing benchmarks to build 1) without any change whatsoever, 2) with minor changes, or 3) break away freely. We can also keep compatibility modules/APIs for that purpose wherever possible. We need to decide on it before we release and we can make relevant changes.
I do not have a strong opinion on it. I think it may be useful initially to keep compatibility with criterion so that people can try it without having to change something in their existing code, just replace criterion with gauge and that's it. Maybe we can break the rarely used APIs but keep the commonly used ones compatible. Criterion exposes a lot of APIs I hardly use a tiny set of it and would never ever use a large set.

Before we release we can do a compatibility inspection and fix things where required. Let me know I can help with that.


Maximum Callstack Size exceeded on opening the cg.html file

Hello,
I was eager to try out this tool today on a React App that needs cleaning up, i managed to run the command jelly -j cg.json -m cg.html ./src -b ./ --ignore-dependencies, but when opening the html file i'm getting the following:
cytoscape.min.js:29 Uncaught RangeError: Maximum call stack size exceeded
    at new Zo (cytoscape.min.js:29:74836)
    at $o.spawn (cytoscape.min.js:29:75060)
    at Qe.<anonymous> (cytoscape.min.js:29:31530)
    at Qe.children (cytoscape.min.js:29:30694)
    at Qe.descendants (cytoscape.min.js:29:32139)
    at Qe.dirtyStyleCache (cytoscape.min.js:29:63716)
    at bs.checkTriggers (cytoscape.min.js:32:19950)
    at p (cytoscape.min.js:32:15454)
    at bs.applyParsedProperty (cytoscape.min.js:32:17820)
    at bs.applyContextStyle (cytoscape.min.js:32:13077)

I'm guessing i've analysed too many files for the browser to handle, but it could be something else 🤔

Looks like the analyzer completed but the visualizer, which is based on Cytoscape.js, can't handle the large call graph. Try with a smaller program.

Yep it works with a rather small other project.
Do you happen to know a tool out there that happens to be able to support bigger projects?

For visualizing huge graphs? No, sorry. But a better approach is probably to tweak the generation of the HTML file (in src/output/visualizer.ts) such that it includes information only for selected packages or modules. Pull requests are welcome :-)


[Network]Add new command: az network application-gateway waf-config list-dynamic-rule-sets

Related command

closed: https://github.com/Azure/azure-cli/issues/27580
Description

Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change
[Component Name 2] az command b: Add some customer-facing feature

This checklist is used to make sure that common guidelines for a pull request are followed.

[ ] The PR title and description has followed the guideline in Submitting Pull Requests.

[ ] I adhere to the Command Guidelines.

[ ] I adhere to the Error Handling Guidelines.

Network

Can we use latest version instead of 2022-05-01?


Issue 328

Duh! Don't merge this quite yet... referencing the PR #! not the actual issue, i.e. #327

And running the test isn't enough, I should also check on the result!... Looks like I broke something. Fixing all this right now

Fixes needed to resolve these test failures - will open a new PR once fixed