Quick setup of Priority roads

Fixes #541
related #542
related #568: undo delete option.
Usage:

select priority sign tool.
Ctrl+click to quick setup priority junction
Ctrl+Shift+Click to do the same to multiple segments.

Situations handled: *

minor road joins main avenue
Split 2 way road into one-way roads
semi-roundabout
no yield required when lane arithmetic is observed

* see https://github.com/krzychu124/Cities-Skylines-Traffic-Manager-President-Edition/issues/541#issuecomment-557296554 for test city and more information.
Crowdin:
I asked krzychu to add crowding keys. I also modified tutorial and hotkey corwdin texts (waiting for approval)
FYI:
EDIT: @krzychu124 did not respond. Can anyone please add these keys?
Options.csv:
"MassEdit.Group.Priority roads"->"Priority roads"
"Priority roads.Option:Allow left turns"->"Allow cars to turn left from/into main road (not recommended)"
"Priority roads.Tooltipn:Allow left turns"->"If enabled lane arrows are untouched and cars can cross road median (does not apply when splitting avenue)."
"Priority roads.Option:Enter blocked yield road"->"Allow cars on yield road to enter blocked main road"
"Priority roads.Option:Stop signs on entry"->"Use stop signs when entering main road"
"Priority roads.Tooltip:Stop signs on entry"->"If enabled, puts stop signs on roads entering the main road. If disabled, puts yield signs instead"
"Priority roads.Option:Allow pedestrian crossings on main road"->"Allow pedestrian crossings on main road"

I made the mass edit overly to last a second after processing is done so that the user has some visual feedback that something has happened.

@aubergine10  ick this junction the overlays show but it's difficult to work out which roads they apply to (particularly the junction restriction overlays).

If you go to options and activate the relevant overlays you will see that here too it's difficult to work out which roads they apply to
If you go to junction restrictions but do not select any junction again you will see the overlays but here too it's difficult to work out which roads they apply to .
Only if you select a junction, the overlays will go to a good position.
Nothing to do with this issue, but if you like you can create an issue to address this problem.

@aubergine10

Avoid negative option effects:
Would be better as:
* Pedestrians can cross to center of roundabout (off by default)
* Pedestrians can cross roads entering/exiting the roundabout (on by default)

The default behavior is pedestrians can cross all junctions. I am trying to override the default behavior.
If the options are turned off, my code will not alter the previous state  pedestrian crossings. which is different than turning them on and off.
for example consider the scenario if the user has built  a bridge over one of the roads connected to the roundabout and therefore has banned pedestrian crossings on that one entry. but other entries do allow pedestrian crossings. What should the user do if he does not want my code to touch the crosswalks?
It would be wired to have an option to say pedestrians can walk to the center of the roundabout! why would I enable crossings to the center if they were previously banned.
If you really do not like negatives I can modify it to something like this.

Fix pedestrian crossings to the center of the roundabout or
Ban pedestrian crossings to the center of roundabout.

In any case this is about roundabout changes from the other pull request

Note again terrible placement of vehicle restrictions persistent overlay. The 'enter blocked junction' is applied to one-way the road entering from the right.

hmmm ... this looks like to semi roundabout case in my code. I am surprised it did not work. I will look into this.

@aubergine10

When applying to route, it looks like it's selecting the route based on direction however in some cases that is not ideal.
What I was expecting as end user:

Maybe it should try and follow same type of road, checking first the "expected onwards" direction and if it finds different road first check if any left/right roads seem to be be continuation of original road?
Maybe Alt modifier could affect that behaviour (Alt = try and stick to original road type even if it goes left/right)?

I have some bad news and some good news.
Bad news:
the previous shit-click also has this "problem". unlike my roundabout review I have not add clever traversal but use the already existing traversal function. whats more is that if the road turns I ignore lane arrows. Reasons:

high priority main roads do not have sharp turns.(no normally anyway)
there are too many different possibilities. I just found it simpler to check for common cases where the road is straight.

adding alt modifier is too much. too many modifiers can confuse the user.
The issue you mention was on my mind when writing the code but I decided to ignore it because:
Good news:
when #631 is merged you can select your path. considering road selection is a thing I decided to keep my traversal code simple.
 I should not try to do everything in one review. This condition should be handled in another issue.

hmmm ... this looks like the semi roundabout case in my code. I am surprised it did not work. I will look into this.

Could it be caused by the fact I had lane connectors on that junction prior to Ctrl+Click?

@aubergine10

Could it be caused by the fact I had lane connectors on that junction prior to Ctrl+Click?

its a bug with LHT
RHT works:

I am on it.

@aubergine10 I fixed some intermittent bugs and merge issues. semi roundabout problem with LHT is also fixed. Should work now.

Looking better!
The temporary overlays (eg. junct restrictions) still disappear too fast; should be at least 3-5 seconds for the Ctrl+Click and maybe 10-15 seconds for Ctrl+Shift+Click.

The "left" in this option caption is going to be problematic for LHT cities, it's already seeped in to the planned translation:

"Priority roads.Option:Allow left turns"->"Allow cars to turn left from/into main road (not recommended)"

Consider "far-side" or "cut across oncoming traffic" so it's direction agnostic?

Would there be any merit in having an option to define whether cims can cross main road when doing Ctrl+Shift+Click? For a single junction, I can happily prevent them crossing, but for entire route it's a bit risky.
Consider this single road, for example, which has about a dozen roads joining it... If I disable crossings all the way down the road, it's going to be a nightmare for cims to navigate across it:

Could maybe have (enabled by default):

"Priority roads.Option:Allow pedestrian crossings on main road on long routes"->"Allow pedestrian crossings on main road on long routes"

I fixed some intermittent bugs and merge issues. semi roundabout problem with LHT is also fixed. Should work now.

https://github.com/krzychu124/Cities-Skylines-Traffic-Manager-President-Edition/pull/621#issuecomment-580949890 confirmed as fixed.

"Priority roads.Option:Allow pedestrian crossings on main road on long routes"->"Allow pedestrian crossings on main road on long routes"

I don't like that one... What about:

"Allow pedestrian crossings on main road on routes longer than (default: XX)"

and then being able to set a unit. "long routes" appears to be too subjective and it is fixed without possibility to change.

"Allow pedestrian crossings on main road on routes longer than (default: XX)"
and then being able to set a unit. "long routes" appears to be too subjective and it a fixed distance without possibility to change.

In-game, user generally has no sense of length or dimensions of anything. Stuff is just "big or small", not "x km". Without using something like Measure It! mod, user wouldn't have a clue what length to set.
The issue I have with how it works currently is that the user could unknowingly cause mass problems due to disabled ped crossings, and they might not even be aware that some junction far off-screen had it's crossings disabled. In the screenshot I posted, I'd have to go manually check every junction along that massive road to work out if there were going to be issues with ped crossings.
Note that all the other settings (priority signs, and the other junction restrictions) won't break pathfinding. So it's specifically the ped crossings that are the issue. Maybe the solution is to make it so the ped crossings can only be disabled when applying to single junction? That way there's no chance of user making massive long road uncrossable.

@aubergine10

Would there be any merit in having an option to define whether cims can cross main road when doing Ctrl+Shift+Click? For a single junction, I can happily prevent them crossing, but for entire route it's a bit risky.
Consider this single road, for example, which has about a dozen roads joining it... If I disable crossings all the way down the road, it's going to be a nightmare for cims to navigate across it:

Could maybe have (enabled by default):

"Priority roads.Option:Allow pedestrian crossings on main road on long routes"->"Allow pedestrian crossings on main road on long routes"

Just imagine! you have a junction so important that cars may not take the far turn but pedestrians can walk right across!  High priority roads have pedestrian bridges or traffic lights. In your case it would be more appropriate to use shift-click to apply only priority signs.
It just occurred to me we can make the "priority road" VS "high priority road" terminology a thing.

It just occurred to me we can make the "priority road" VS "high priority road" terminology a thing.
That may be the solution we need

I love the conepot of priority vs. high priority.
In UK, pedestrians always have right of way (humans >> machines), except where it is simply too dangerous for them to be crossing roads (safety > painful death). Examples:

"B" road: Pedestrians cross wherever they want
"A" road: Pedestrians can cross wherever they want, but they usually head for marked crossing point (zebra or pelican crossing) if there is one nearby
"Dual carriageway": (Car) Priority road - pedestrians should use marked crossings or ped bridges/tunnels
"Motorway": High (car) priority roads - pedestrians must use bridges/tunnels

We could use Alt modifier to distinguish between high and normal car priority:

Control+Click = normal car priority
Alt+Control+Click = high car priority

And add Shift to those shortcuts for "apply to route" mode.

^ Updated comment above several times might need re-reading

For docs, could you elaborate on what this means:

no yield required when lane arithmetic is observed

@aubergine10

EDIT: Just realised there is no temporary display of overlays; it was just be holding and releasing Ctrl key lol

I don't know the context you are taking about but the mass edit overlay should show for a short time after you CTRL-SHIFT-CLICK

I don't know the context you are taking about but the mass edit overlay should show for a short time after you CTRL-SHIFT-CLICK

I was referring to just the single-junction Ctrl+Click thinking that had delay on the overlays (it was actually just delay between me ctrl+click and me releasing ctrl key).
Will retest the ctrl+shift+click in a moment.

I was referring to just the single-junction Ctrl+Click thinking that had delay on the overlays (it was actually just delay between me ctrl+click and me releasing ctrl key).

Ctrl+Click as well as CTRL+Shift+Click should continue to show the overlay a few seconds after the click (after all the processing is done to be more accurate).
CTRL+Shift+Click is like pressing CTRL+Click on every junction on the highlighted road.

Just tested again:

Ctrl+Click = about 1.5-2 seconds
Ctrl+Shift+Click = same

Maybe Ctrl+Click should be 3 seconds, and Ctrl+Shift+Click should be 3 * num_junctions up to a max of 15 seconds?

Just tested again:
* Ctrl+Click = about 1.5-2 seconds
* Ctrl+Shift+Click = same

Its one second after all processing is done:
            // keep active for one more second so that the user
            // has a chance to see the new traffic rules.
            MassEditOVerlay.SetTimer(1);

Maybe Ctrl+Click should be 3 seconds, and Ctrl+Shift+Click should be 3 * num_junctions up to a max of 15 seconds?

why? do you know its one second AFTER all processing is done and not before

Ok, we can revisit the timer thing at later date after overlays are optimised.
What about this: https://github.com/krzychu124/Cities-Skylines-Traffic-Manager-President-Edition/pull/621#issuecomment-582545064

Just a side note
In real world road priority for pedestrians is tightly coupled with speed limit on that street and how many lanes that road has. So say under 20mph/30kmph that will be pedestrians priority; Then 30mph/50kmph it is ok to cross (always can cross if there is a traffic light), and over that pedestrians can't cross at all without a traffic light being green for them.
How to display that is another question :)

@aubergine10 I am really bad at road numbers. It seems British numbering system is much better than Israel:
https://en.wikipedia.org/wiki/Great_Britain_road_numbering_scheme
It also depends on number of digits the A road has.
Examples of A road and B road on google:

https://en.wikipedia.org/wiki/A4226_road#/media/File:A4226_near_Weycock_Cross.jpg
https://upload.wikimedia.org/wikipedia/commons/0/0a/A4226_near_Weycock_Cross.jpg
https://www.google.com/maps/@52.421688,-1.7863173,3a,75y,227.95h,92.1t/data=!3m6!1e1!3m4!1s5dJsrtpJ0MVisNblDTPVxQ!2e0!7i13312!8i6656
https://goo.gl/maps/huBkVSuZ9FdS4RWZ6

In the roads above cars can mostly turn left and right:
in this one left turn is forbidden but the road joining it is auxiliary roadSo you should not use the high priority modifier (CTRL).
In my road selection panel I can provide profiles(maybe even customizable) for multiple different levels of roads.
but for the sake of this review I think what I am doing is good enough. you can always change the options.

but we already have shift click for low priority (priority sings only) CTRL for high priority.

True, but it doesn't set the enter blocked junction stuff.
Also, Ctrl seems to be setting it's place as the "multitool tool". Whereas Shift will just propagate basic tool down the road, Ctrl+Shift would apply other tools too (junction restricitons, lane arrows, etc...) hence desire for Alt+Ctrl and Alt+Ctrl+Shift.

Shift = single tool propagate
Ctrl+Shift = multi-tool propagate
Alt+Ctrl+Shift = alternate multi-tool propagate

Also, Ctrl seems to be setting it's place as the "multitool tool". Whereas Shift will just propagate basic tool down the road, Ctrl+Shift would apply other tools too (junction restricitons, lane arrows, etc...) hence desire for Alt+Ctrl and Alt+Ctrl+Shift.

in comparison CTRL+SHIFT does the following:

remove two crossings from main road
add yield sign on connected road[s]
ban far turn on connected road[s]
ban far turn[s] on main road
go through blocked junction on main road.
Even remembering all this requires a lot of energy. let alone applying them all to several junctions with no mistakes.

so ALT+CTRL+Shift only sets priority signs and go through blocked junction? that is something that can be easily done manually. if the objective is to set go through blocked junction on multiple junctions at once it should be part of bulk edit feature in junction restriction.
If you still feel strongly about ALT+CTRL+Shift I can add it but in my opinion its too much and it only confuses people.

With the way it currently stands, if I want alternate crossing mode (either remove or don't remove, ie. opposite of whatever is set in mod options) I have two options which are both clunky:

Change mod options:

Exit all the way to pause menu
Select options, find TMPE in list
Go to policies tab, change option
Exit from options
Go back in to tool, use the shortcut
or...

Switch tools:

Apply the usual shortcut in priority tool
Switch to junction restrictions tool
Select junction
Change crossings
Potentially for several junctions

Having Alt key temporarily toggle what happens to crossings over main road would be much easier.
From user perspective, I don't think they will try and remember what Ctrl modifier does (as it's a bit differnet depending on each junction). The Alt modifier will just be: "Whatever Ctrl would do, but invert what happens to crossings over main road"
Like, if I want normal behaviour (remove crossings) along route, except on couple of junctions, I could:

Ctrl+Shift+Click the route
Alt+Ctrl+Click the two junctions

No need to change tools or mod options, just very fluid and quick interaction with my roads using one tool.

BTW, I'm already using this bulk applicator all over my city, it's awesome!!

@aubergine10  Having Alt key temporarily toggle what happens to crossings over main road would be much easier.
From user perspective, I don't think they will try and remember what Ctrl modifier does (as it's a bit differnet depending on each junction). The Alt modifier will just be: "Whatever Ctrl would do, but invert what happens to crossings over main road"
Like, if I want normal behaviour (remove crossings) along route, except on couple of junctions, I could:
Ctrl+Shift+Click the route
Alt+Ctrl+Click the two junctions

What happens to lane arrows?
having the alt key doing opposite of what crossings do in the options is strange. maybe remove that option?  maybe provide a panel like the one in roundabout mod? maybe we can do this in the road selection panel? I feel like we are rushing in the ALT modifier. lets open an issue about this so that we can have some proper discussion. It would be wrong to shove it in a code review last minute.

EDIT: isn't it illegal to block junctions when cars joining the road can take the far turn?

Where I live, that's only illegal if there's markings on the ground meaning as such. Otherwise, it's legal

Translation keys work.

@aubergine10 I created a branch with the ALT key just for you! https://github.com/kianzarrin/Cities-Skylines-Traffic-Manager-President-Edition/tree/AltPriorityRoad
the alt key force applies pedestrian crossing regardless of the options.
alt+ctrl+shift+click (road)
alt+ctrl+click (junction)

@kvakvs @krzychu124 : Please test this PR. I'd ideally like to get it published to LABS this weekend so end-users can start testing. It's the main "new feature" of v11.1 release.

Motorway merge 2+1=3
Lane arithmetic is observed
Yield is produced too

Good catch!!

OK made 2 fixes:
Fix number 1: fix for counting lanes of Asym roads.
Fix number 2: better isSemiRoundabout detection and I call fix functions from roundabout utility.
Screanshot 1: Only Fix number 1.
ScreanShot 2 and 3: Both fixes.

Testing...

@aubergine10 is it me, or delete button was changed from recycle bin to x

@krzychu124  I'm worried a bit about those lock thingies (I think it won't work - you probably need to lock whole instance).

Whole instance of what? Can you please elaborate. I don't have too much experience in multi-threading. What can go wrong here? what should I do?
@aubergine10 @kvakvs  any ideas?

@aubergine10 is it me, or delete button was changed from recycle bin to x

I has always been x for me. maybe I should merge.

v10.21.1

Regards to locking: https://stackoverflow.com/a/505604

IMO that button doesn't matter too much; I think at some point the Priority Signs UI workflow needs changing to something more like junction restrictions. So I wouldn't delay merging this becaue of that button.

Just noticed a change when I was testing priority bug, you can merge it :wink:

v10.21.1

Regards to locking: https://stackoverflow.com/a/505604

Regards to locking: https://stackoverflow.com/a/505604
@aubergine10 I don't see it. In the link you sent Its returning a class by ref. I do not return a class. I return bolean. DateTime is also a struct (which i don't return). I am not even using any byref values let alone mishandling them.

Am I missing something. is there another problem maybe?


[Task]: Fix revote doesn't show if stronghold was originally locked when initiating manage vote

Task description
If you login to a profile that is already voting and stronghold is locked, if you go to manage vote - after the voting power increase or decrease transaction the revote popup does not open. However, if you start the flow with stronghold unlocked the revote popup correctly opens.
Requirements
Fix the issue
Creation checklist

[X] I have assigned this task to the correct people
[X] I have added the most appropriate labels
[X] I have linked the correct milestone and/or project

I couldn't reproduce the issue anymore.


WHY?

https://i.imgur.com/BfTWJZV.jpg

https://i.imgur.com/UqCE5v0.jpg

How is this something worth reporting?
I can understand maybe suggesting to change the error message for broken webpages... but there is nothing wrong with the credits at the bottom of the second image. Complaints like this just pointlessly clog up issue trackers.
-_-

@KarinaAE123 @trytip Yeah, what is the issue here. Is the issue because the page crashed, it says aw, fuck, or that I appended my name to the copyright.
Im going to assume all of them, so:

Is this page using WebRTC?
I added this as an easter egg, I might change it so as not to offend some humans who use thorium.
This is not an issue, literally every Chromium based browser adds their own copyright. AND, many (I'm looking at you, Brave, Edge, Opera) remove Chromium from it entirely, which I think is a disservice. While I put alot of work into Thorium, it is not nearly as much as the Chromium team does, so I put my name after theirs not only here, but in the headers of source code files as well. What exactly is your issue with this?


TypeError with GPO_Listener

When trying to connect a client via the GPO_Listener or with a very simple own listener Client, the Server throws the following Exception: TypeError: Cannot read property 'id' of undefined. The stack says the Error occurs in Line 541, seems like  getDeviceByDeviceId() uses an undefined array of devices?
Connecting a Listener via Web Interface runs correctly.

This will be fixed in the next release! A workaround is to make sure to you are using a valid Device Id in your gpo config file.

This is fixed in the latest release, so please go and test that! If it's not fixed, you can re-open this.


mdanalysis_trajectory.ipynb example needs to be updated to avoid frame_index=0 when looping

Since this now indicates a reset, topology etc would need to be resent, so the example is misleading.

There's an unused current_frame_index in there that should probably just monotonically increase and be used as the frame index for sending


Minus and the numbers disappear when radixPoint and groupSeparator is set

This is my settings for the inputmask :
$('.rupiah').inputmask('currency', {
  allowMinus: true,
  prefix: 'Rp. ',
  radixPoint: ',', // comma
  groupSeparator: ".", // point
});

I have an input field to input a currency in rupiah format. What happen now is :
Type 1000
Result Rp. 1.000,00 ✅
Type 1000,55
Result Rp. 1.000,55 ✅
Type 1000,55 then - (negative)
Result Rp. 1.000,55 then when I type negative, the result become Rp. 0,00 ❌
But, when I comment the radixPoint and groupSeparator (default format), the issue is gone, but that's not the result that I want.
$('.rupiah').inputmask('currency', {
  allowMinus: true,
  prefix: 'Rp. ',
  // radixPoint: ',', // comma
  // groupSeparator: ".", // point
});

Type 1000
Result Rp. 1,000.00 ✅
Type 1000,55
Result Rp. 1,000.55 ✅
Type 1000,55 then - (negative)
Result Rp. 1,000.55 then when I type negative, the result become -Rp. 1,000.55 ✅
Can someone help me where I go wrong in the inputmask config?
Thank you...

I've ran into this issue as well, and this behaviour seems to be caused by the groupSeparator being part of the prefix/suffix. During "onBeforeWrite", this causes the regexp to fail and find no matches:
https://github.com/RobinHerbots/Inputmask/blob/5.x/lib/extensions/inputmask.numeric.extensions.js#L515


[v5] Do not swallow errors

@Andarist Will need help with the couple of tests that are failing. They should expect an unhandled rejection, but I'm unsure of how to best test that in Jest.


Add grpc window size config and change the default value

Add GrpcInitialWindowSize and GrpcInitialConnWindowSize and change their default value from 1GiB to 128MiB.
The default value 1GiB may cause a TiDB OOM issue, see https://github.com/pingcap/tidb/issues/49353.
The initial default value came from this PR https://github.com/pingcap/tidb/pull/3377 where the author referred to https://github.com/pingcap/tidb/pull/3377#discussion_r119979139 as the evidence to justify the 1GiB default value. In this referenced document,  the http2-window size is set to 1MiB and http2-connection-window is set to 1GiB. However, this document did not clearly describe how the test was done. I guess the key factor in getting faster results is changing http2-window from 64KiB to 1MiB, not changing http2-connection-window to 1GiB because at the top of the doc said the speed was just 4MiB/s if not using http2.
There is a lot of evidence that 1GiB is too large.

If these two values are not set, grpc-go will use the dynamic window size and the maximum of this dynamic window size is 16MiB. https://github.com/grpc/grpc-go/blob/dadbbfa2863a67ed640aac924b7b7fd18b50a429/internal/transport/bdp_estimator.go#L30
In cockroachdb master branch, the default values of GrpcInitialWindowSize and GrpcInitialConnWindowSize are 2MiB and 32MiB, respectively. The maximum of these two values is 64MiB. https://github.com/cockroachdb/cockroach/blob/master/pkg/rpc/settings.go#L69-L70. (https://github.com/cockroachdb/cockroach/pull/111255)

As a result, changing both default values to 128MiB will not likely cause performance issues but will likely reduce many TiDB OOM issues.

/run-all-tests

/merge


Unknown error: 'tmdb_movie'

I get the following error when using tmdb_movie_details:
[2021-03-06 11:15:13,502] [builder.py:192]            [INFO]     | Scanning STEINS;GATE Collection                                                                    |
[2021-03-06 11:15:13,502] [builder.py:219]            [DEBUG]    |                                                                                |
[2021-03-06 11:15:13,503] [builder.py:220]            [DEBUG]    | Method: template                                                                                |
[2021-03-06 11:15:13,503] [builder.py:221]            [DEBUG]    | Value: ordereddict([('name', 'Movie'), ('movie', 225745)])                                         |
[2021-03-06 11:15:13,503] [builder.py:219]            [DEBUG]    |                                                                                |
[2021-03-06 11:15:13,503] [builder.py:220]            [DEBUG]    | Method: tmdb_movie_details                                                                         |
[2021-03-06 11:15:13,503] [builder.py:221]            [DEBUG]    | Value: 225745                                                                                |
[2021-03-06 11:15:14,199] [builder.py:219]            [DEBUG]    |                                                                                |
[2021-03-06 11:15:14,199] [builder.py:220]            [DEBUG]    | Method: sync_mode                                                                                |
[2021-03-06 11:15:14,199] [builder.py:221]            [DEBUG]    | Value: sync                                                                                |
[2021-03-06 11:15:14,199] [builder.py:219]            [DEBUG]    |                                                                                |
[2021-03-06 11:15:14,199] [builder.py:220]            [DEBUG]    | Method: collection_order                                                                           |
[2021-03-06 11:15:14,199] [builder.py:221]            [DEBUG]    | Value: release                                                                                |
[2021-03-06 11:15:14,209] [config.py:396]             [INFO]     |                                                                                |
[2021-03-06 11:15:14,210] [config.py:398]             [INFO]     | Sync Mode: sync                                                                                |
[2021-03-06 11:15:14,335] [builder.py:570]            [DEBUG]    |                                                                                |
[2021-03-06 11:15:14,335] [builder.py:571]            [DEBUG]    | Method: tmdb_movie                                                                                |
[2021-03-06 11:15:14,336] [builder.py:572]            [DEBUG]    | Values: [225745]                                                                                |
[2021-03-06 11:15:14,336] [builder.py:592]            [INFO]     |                                                                                |
[2021-03-06 11:15:14,336] [builder.py:593]            [DEBUG]    | Value: 225745                                                                                |
[2021-03-06 11:15:14,336] [tmdb.py:171]               [DEBUG]    | Data: 225745                                                                                |
[2021-03-06 11:15:14,337] [tmdb.py:240]               [INFO]     | Processing TMDb Movie: (225745) Steins;Gate: The Movie − Load Region of Déjà Vu (1 Movie)          |
[2021-03-06 11:15:14,337] [tmdb.py:244]               [DEBUG]    | TMDb IDs Found: [225745]                                                                           |
[2021-03-06 11:15:14,337] [tmdb.py:245]               [DEBUG]    | TVDb IDs Found: []                                                                                |
[2021-03-06 11:15:14,419] [util.py:717]               [INFO]     | STEINS;GATE Collection | = | Steins;Gate: The Movie − Load Region of Déjà Vu                       |
[2021-03-06 11:15:14,420] [util.py:717]               [INFO]     | 1 Movie Processed                                                                                |
[2021-03-06 11:15:14,420] [builder.py:724]            [INFO]     |                                                                                |
[2021-03-06 11:15:14,420] [builder.py:731]            [INFO]     | 0 Movie Removed                                                                                |
[2021-03-06 11:15:14,420] [builder.py:732]            [INFO]     |                                                                                |
[2021-03-06 11:15:14,427] [builder.py:737]            [INFO]     | Detail: tmdb_movie_details updated Collection Summary                                              |
[2021-03-06 11:15:14,474] [builder.py:774]            [INFO]     | Detail: collection_order updated Collection Order to release                                       |
[2021-03-06 11:15:14,474] [builder.py:788]            [DEBUG]    | {'summary.value': 'One year after the events of the anime, Rintarou begins to feel the repercussions of extensive time travel, and eventually completely fades from reality. Kurisu, being the only companion to remember him, now must find a way to bring him back.', 'summary.locked': 1} |
[2021-03-06 11:15:14,639] [builder.py:791]            [INFO]     | Details: have been updated                                                                         |
[2021-03-06 11:15:14,640] [util.py:660]               [DEBUG]    | Traceback (most recent call last):                                                                 |
                                                                 |   File "/home9/calboi/Plex-Meta-Manager/modules/config.py", line 418, in update_libraries
                                                                 |     builder.update_details(plex_collection)
                                                                 |   File "/home9/calboi/Plex-Meta-Manager/modules/builder.py", line 858, in update_details
                                                                 |     elif "tmdb_movie_details" in self.posters:          set_image("tmdb_movie", self.posters)
                                                                 |   File "/home9/calboi/Plex-Meta-Manager/modules/builder.py", line 837, in set_image
                                                                 |     else:                                               collection.uploadPoster(url=images[image_method])
                                                                 | KeyError: 'tmdb_movie'
                                                                 |
[2021-03-06 11:15:14,640] [config.py:425]             [ERROR]    | Unknown Error: 'tmdb_movie'

Similar errors occur when using tmdb_show_details or tmdb_collection_details. But it seems the collections are updated properly.

should be fixed in the develop branch


🐘 Hold deserialized objects in mem in order to return single instances of objs with the same id

v2 serializer in core made this change and it wasn't propagated to py. requested by tom here:
https://speckle.community/t/circular-references-detaching-objects-in-python/3071
will need to adjust brep deserialisation and test for any weirdness in blender with this change (are there any other objs that are likely to have the same id where this could be an issues?)
see https://github.com/specklesystems/speckle-sharp/pull/823

As far as I'm aware, BREPs are the only place where this is an issue we need to carefully consider the way to deal with this. No other class uses the OnDeserialized attribute.


Problem_Statement_58

Take input of any word from the user and write a program to find out the number
of the permutations of letters of that word.

I'm Disha Morye from CCEW, Pune. I would like to work on this issue

Go Ahead! Submit your Code in "Solutions" folder. Deadline is 3 Oct' 21, 11: 59 pm

I have submitted the pull request.
Kindly check it
Thank you!


Prettier

Please review as ASAP as possible.

I can't find a .prettierrc. Shouldn't we add a .prettierrc to get consistent prettier output?


chore: version packages

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and publish to npm yourself or setup this action to publish automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
<EMAIL_ADDRESS>Note: Version bump only for package @stacks/auth
<EMAIL_ADDRESS>Note: Version bump only for package @stacks/bns
<EMAIL_ADDRESS>Features

cli option to decode serialized Clarity values (#1599) (25c821b)

<EMAIL_ADDRESS>Note: Version bump only for package @stacks/common
<EMAIL_ADDRESS>Note: Version bump only for package @stacks/encryption
<EMAIL_ADDRESS>Note: Version bump only for package @stacks/network
<EMAIL_ADDRESS>Note: Version bump only for package @stacks/profile
<EMAIL_ADDRESS>Note: Version bump only for package @stacks/stacking
<EMAIL_ADDRESS>Note: Version bump only for package @stacks/storage
<EMAIL_ADDRESS>Bug Fixes

add address alias for principal (bd96bb5)
add generic principal helper (25176ce)

<EMAIL_ADDRESS>Note: Version bump only for package @stacks/wallet-sdk

Codecov Report
Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (debeb00) 66.18% compared to head (5bea0a0) 66.32%.
Report is 32 commits behind head on main.

:exclamation: Current head 5bea0a0 differs from pull request most recent head a2ae51e. Consider uploading reports for the commit a2ae51e to get more accurate results

Files
Patch %
Lines

packages/transactions/src/clarity/prettyPrint.ts
93.33%
3 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1586      +/-   ##
==========================================
+ Coverage   66.18%   66.32%   +0.14%
==========================================
  Files         118      119       +1
  Lines        8640     8686      +46
  Branches     1908     1936      +28
==========================================
+ Hits         5718     5761      +43
- Misses       2685     2688       +3
  Partials      237      237

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


add task 'printDependencyLocations'

This code adds a task "Print Dependency Locations" which just prints the locations of each dependency on the filesystem. I have found this useful to have when wanting to check dependencies by hand.

It's been almost three years, closing commit


[<IP_ADDRESS>] Errors consuming collectd "battery" plugin values

When I enable collectd's battery plugin and configure its types.db (cf. https://github.com/collectd/collectd/issues/1338) to send capacity as a 'GAUGE', i.e.:
capacity        value:GAUGE:0:U

I get errors trying to query the measurement in the Influx (<IP_ADDRESS>) console:
> select * from battery_
ERR: invalid character 'j' looking for beginning of value

If I instead configure capacity as ABSOLUTE in collectd, i.e.:
capacity        value:ABSOLUTE:0:U

I am able to query the values in the Influx console:
> select * from battery_
name: battery_
--------------
time				host		instance	type		type_instance	value
2015-11-05T22:05:18.004543Z	mbp.local	0		capacity	charged		9.221120237041091e+18
2015-11-05T22:05:18.004544Z	mbp.local	0		capacity	discharged	9.221120237041091e+18
2015-11-05T22:05:18.004545Z	mbp.local	0		capacity	degraded	9.221120237041091e+18
2015-11-05T22:05:27.746246Z	mbp.local	0		capacity	charged		9.221120237041091e+18
2015-11-05T22:05:27.746252Z	mbp.local	0		capacity	discharged	9.221120237041091e+18
2015-11-05T22:05:27.746255Z	mbp.local	0		capacity	degraded	9.221120237041091e+18
2015-11-05T22:05:37.667902Z	mbp.local	0		capacity	charged		9.221120237041091e+18
2015-11-05T22:05:37.667908Z	mbp.local	0		capacity	discharged	9.221120237041091e+18
2015-11-05T22:05:37.66791Z	mbp.local	0		capacity	degraded	9.221120237041091e+18

However, they don't seem to be stored as numbers, and downstream Grafana doesn't seem to understand them as such.
I've looked at the few issues discussing nuances of integer-parsing in Influx, e.g. #3583 and #4433, and it seems like Influx <IP_ADDRESS> should be able to handle values that look like 9.221120237041091e+18 (as floats?), and yet something is going wrong and I'm not sure how to debug from here. Any pointers as to why the battery values are being rejected as GAUGEs would be appreciated. Thanks!

I have limited familiarity with collectd, but every other instance of InfluxDB spitting out ERR: invalid character 'j' looking for beginning of value has turned out to be because of NaN values. Does collectd spit out NaN for gauges?

However, they don't seem to be stored as numbers, and downstream Grafana doesn't seem to understand them as such.

It is possible they are going in as strings, although InfluxDB does understand scientific notation for floats and should store them as numbers. Does SELECT SUM(value) FROM battery_ return something reasonable?

hm yea when I have collectd send them as ABSOLUTE and I have the 9.221120237041091e+18 values, I can sum them as you suggest:
> select sum(value) from battery_
name: battery_
--------------
time			sum
1970-01-01T00:00:00Z	5.532672142224654e+19

> select sum(value) from battery_
name: battery_
--------------
time			sum
1970-01-01T00:00:00Z	1.1065344284449309e+20

Trying to plot them in Grafana, I see:

So maybe the issue is Grafana's handling of numbers this large?
In any case, influx seems to be correctly consuming collectd ABSOLUTEs as floats so we can close this.


[WIP] Searchpicks module

Moves editors picks out of wagtailsearch into a new module called contrib.wagtailsearchpicks.
This makes "Promoted search results" optional and also resolves the two-way dependency between wagtailsearch and wagtailcore
TODO:

[ ] Move EditorsPick model
[ ] Add {% get_editors_picks %} templatetag
[ ] Move locale files
[ ] Documentation

Is this an opportunity to finally rid the code of references to  "Editor's picks"? The term has already been agreed as confusing and only exists in a few places where it was harder to remove. It's ostensibly known as "Promoted search results".
If a short name is desirable for some situations "Promoted search" is only 2 chars longer than "Editors picks"  and would at least unify the names somewhat.

Ready for review

Sorry to return to this, but are we really going for wagtailsearchpicks over wagtailpromotedsearch or wagtailsearchpromo or similar? Continuing this mixture of terminology "picks" vs "promoted" seems undesirable if we've finally got a chance to move to something uniform.

Agreed to use "wagtailsearchpromotions".

Renamed SearchPick model to SearchPromotion
Renamed wagtailsearchpicks app to wagtailsearchpromotions

Looks good!

I see there are several places that still refer to "Editor's Picks" / "search picks", some more visible/important to fix than others - for example, the success message on add/edit, and the related_name on the SearchPromotion model.
The migrations worked well when I tried them, and successfully preserved existing search pick data - but I see the logic in there is a bit fiddly. It would be good to have some comments in there to explain what's going on, to make me more confident that it's going to work in all situations (for example, running the wagtailsearch.0003_remove_editors_pick migration before the new module has been added to INSTALLED_APPS).
Please could you write an 'upgrade considerations' item for the release notes, explaining what existing site owners need to do?

I see there are several places that still refer to "Editor's Picks" / "search picks", some more visible/important to fix than others - for example, the success message on add/edit, and the related_name on the SearchPromotion model.

I left the UI as it is as it's wrong on master anyway (was planning on doing this in a seprate PR).
Since we're no longer recommending users access promoted results using the Query object, I didn't see much benefit to changing the related name (and most implementations using promoted results will be using this related name).

Done!

Rebased

:+1:  Man, don't forget change de name for wagtailssearchpromotions to searchpromotions.

Removed the upgrade consideration commit (so I don't have to keep rebasing this branch). You can fing the commit for it here: https://github.com/kaedroho/wagtail/commit/1f4a8ec79c3d10834959e918ff3404e0146da452

Happy for me to merge this? I got a couple of changes to make that depend on this

Merged.

Removed the upgrade consideration commit (so I don't have to keep rebasing this branch). You can find the commit for it here: kaedroho@1f4a8ec

For future reference, please don't do this. Fixing merge conflicts that arise while a PR is awaiting review is my responsibility as the reviewer, and it's easier to do that when it's part of the PR than when it's an orphaned commit on someone else's fork... :-)


Tag 2.0 release

Look into the var_dump() on the SM and gracefully handle it.
Update the CONST to 2.0.0
Tag it on a release

Completed. Tagged 2.1.0-alpha and 2.1.0-alpha2 and 2.0


Naming consistency across Config structs

ShardConfig builds into a Config, but then you start with a Config in the Command module. I would suggest explicit XConfig and XConfigBuilder names across the board, but being consistent in scheme is a minimum I would ask for in this issue.

Yeah I agree that we should probably rename the structs, at least that would make it more clear what is happening. Currently you have to add a lot like use some::Config as SomeConfig; and that is not too userfriendly.


Adding effect to Word Scramble Game

Want to add effects to the Word Scramble game.  Please assign me this issue under JWOC '24.

@Purwanshi08 you need to complete previous issue assigned first..

@Purwanshi08 you need to complete previous issue assigned first..

i can work on this, if the assigned mentee couldnt do it in the given time. under jwoc 2024 please assign me


undo readme

Codecov Report

Merging #3806 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3806      +/-   ##
==========================================
- Coverage   40.88%   40.85%   -0.03%
==========================================
  Files        2174     2174
  Lines       70772    70772
  Branches     9743     9743
==========================================
- Hits        28936    28916      -20
- Misses      39078    39096      +18
- Partials     2758     2760       +2

Impacted Files
Coverage Δ

...npoint/rpc/server/SimpleServerMessageListener.java
80% <0%> (-20%)
:arrow_down:

...p/pinpoint/rpc/client/WriteFailFutureListener.java
56.25% <0%> (-18.75%)
:arrow_down:

...vercorp/pinpoint/rpc/packet/ServerClosePacket.java
52% <0%> (-16%)
:arrow_down:

...vercorp/pinpoint/rpc/packet/ClientClosePacket.java
55.55% <0%> (-11.12%)
:arrow_down:

...rp/pinpoint/rpc/server/PinpointServerAcceptor.java
84.96% <0%> (-5.27%)
:arrow_down:

...orp/pinpoint/rpc/server/DefaultPinpointServer.java
78.24% <0%> (-2.11%)
:arrow_down:

...java/com/navercorp/pinpoint/rpc/DefaultFuture.java
72.5% <0%> (-1.67%)
:arrow_down:

...ofiler/sender/StandbySpanStreamDataSendWorker.java
85.07% <0%> (+1.49%)
:arrow_up:

...m/navercorp/pinpoint/test/OrderedSpanRecorder.java
72.11% <0%> (+1.92%)
:arrow_up:

...navercorp/pinpoint/rpc/common/SocketStateCode.java
85.36% <0%> (+2.43%)
:arrow_up:

... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af80bc3...9685533. Read the comment docs.


Game - 2048

Summary
The most addictive game of... 2014. Let's call this the anniversary edition.
Technical Spec
Needs a rock to run on. It's... not hard. Requires only basic functions of the swadge.
UI
Uses A or B to accept some results, uses directional controls to move blocks. Start resets the game.
No assets are requires aside from two fonts. An updated splash screen might need more?
Screenshots
Title:

Gameplay:

Player reaches 2048:

Game Over:

Features planned for 1.1

LEDs that color based on highes score block and pulse during a merge
Sounds
Better splash screen
High score saving
Fix colors of blocks to be easily discerned (Green blocks are too similar)

Woo! For the blocks, have you considered using sprites instead of flat colors? That way you could get textures or something cute idk.

Also this would be hilarious to play with tilt controls

Movement controls should be easy enough to roll into 1.1.
I'm worried about identification of blocks if I make them too busy with sprites. It might be a good idea to use circles for the higher level ones just so they're visually distinct and then I can reuse colors, but since I already have a problem with recognition, I don't think making a pattern is a good idea.

Up to you, though I'll note that for the color-challenged, like myself, differentiating something like stripes v. polka dots is much easier

Wasn't thinking about that. Let me see what I can do.

You can also do cool things like use a different, bigger font, and have some blending around font edges. I wouldn't worry too much about the set of tiles. Art can always be filled in later, and with community help if that's your jam :)

I'm very much not an art person. I'll take all the help I can get in the art department.

Version 1.1:

New, easier to read sprites for the tiles
Sounds for button clicks and BGM
A new splash screen with visual interest and high score displayed
High score saved between resets
LEDs on the side now illuminate to help show player which direction the blocks moved, or if they didn't move
LEDs also provide more visual interest in non-gameplay modes


reset trigger message when everything is ok

Coverage increased (+0.01%) to 96.442% when pulling 0d7594cb1baf699dadd600b7169cd5cbcc4e40a4 on hysteresis_for_graphite into ead5e7d1798ecf63d15dd86ccc78be934b694c46 on develop.

👍

:+1:

Coverage increased (+0.01%) to 96.442% when pulling a43b38dbd297d90fc8e1ac9fd4282efbd93eee0f on hysteresis_for_graphite into ead5e7d1798ecf63d15dd86ccc78be934b694c46 on develop.


Add link to SPARQL Connector

We've built a connector for sources implementing the SPARQL protocol and would like to have it published on the Community Connectors Gallery. Thank you in advance!

I signed it!

I signed it!

This looks great, thanks for the PR.

@diminishedprime Awesome! Will it be listed in the Data Studio gallery?


Fix testing of half-precision fma.

Half-precision functions are generally tested against the single-precision reference. This causes double rounding: first to single precision, then from there to half precision. For the most part, it is good enough, but specifically in the case of fma, a correctly rounded result is required and is not obtained, for instance for arguments 0x1.eacp+7, 0x1.3f4p+4, 0x1.c04p+14, which produce an exact result of 0x1.065fffp+15 which should be rounded to half-prefcision 0x1.064p+15, but was previously first rounded to single-precision 0x1.066p+15, and from there to half-precision 0x1.068p+15. Testing against reference_fmal gives us sufficient precision that double rounding does not cause issues.
The f_fma(..., FLUSHED) calls for FTZ testing cannot be updated the same way but do not need to be: these calls all have at least one constant operand of zero. If one operand is zero, double rounding cannot be an issue.

The f_fma(..., FLUSHED) calls for FTZ testing cannot be updated the same way but do not need to be: these calls all have at least one constant operand of zero. If one operand is zero, double rounding cannot be an issue.

I do think there is an issue there too, the FTZ handling appears to only check for results that are subnormal in single precision, rather than results that are subnormal in half precision, but that is separate from the issue that I am trying to fix here.

The "Check code format" is failing because it does a clang-format of the diff to main, not of the diff to the PR's target branch. The errors are issues on the fp16-staging branch, not new issues in this PR, and I think I should ignore them?

Merging as discussed in the February 6th teleconference.


Tags not synchronizing correctly

Hi, I started using Errands on my desktop, in my phone I have Tasks.org and I noticed when I change tags in Errands, the changes doesn't show in Tasks.org. I have checked the changes and I noticed that in CalDav there are more categories parameters like e.g.:
CATEGORIES:tag1
CATEGORIES:tag2

but it should be:
CATEGORIES:tag1,tag2 right? At least this is what I see when I check what comes out of Tasks.org.
When I try to actually create a new task in Errands and I add more than one tag, I see only the first one e.g.:
CATEGORIES:tag1
its possible that Errands ignore the CATEGORIES parameter if its not in particular place in the message, and there is probably issue with collecting all the tags in one parameter as well (the rest being omitted).

Yeah, can confirm this. I'll look into it now.

Okay, it was only one line. Fixed in f0531ead327eeeda9f1be181adb52f16bebc2fdc. I'll create a release with fix.

wow you are super fast, thanks a lot!

I've pushed update on flathub, don't know how long it will take the update to arrive, probably several hours. Thanks for report!

Hi @mrvladus it still happens. I have the latest version I tried to create new task. First I gave it only 1 tag and synchronized. Then I added second and synchronized and it is split again, there is CATEGORIES twice again.
I wonder if I have issue installing the new version though? My flatpak manager shows I have the latest, but when I click on "About" in the app I see 46.0 (not 46.0.1) any chance you didn't update the version in about? Thanks!

I've made a typo in version number. New version is 46.0ю1 :)

Cool, now I see this, maybe some cache or something. Anyway now the categories are in one CATEGORIES. Interesting is that it still doesn't show in Tasks.org (but that is probably their bug now, unless there is something about ordering the properties.. Thanks a lot.

Flathub is just taking too long to push updates for some reason.

If you are curious I added the bug to Tasks.org here: https://github.com/tasks/tasks/issues/2868
I attached there full message in order to see if order play some role. :smile:


Mail received and in maildir, but 0 messages displayed

I am using the mailhog/mailhog:latest docker image (updated yesterday) with the following environmental variables set:
MH_SMTP_BIND_ADDR=...
MH_STORAGE=maildir
MH_MAILDIR_PATH=/maildir/
Mail comes in and is stored in the maildir, but when I load the UI, it shows 0 new messages.
What's going on here?

Problem solved.
In the data directory I had created a test directory (only for checking file rights).
After deleting this directory, the emails were displayed in the web UI.


Empty data in TwigColumn

Hi :) I have a simple test app in Symfony 4.4.x and this bundle in version 0.5.x (i'm test all version to 0.5.3).
I have simple table looks like:
    public function test(Request $request, DataTableFactory $datatableFactory): Response
    {
        $table = $datatableFactory->create([])
            ->setMethod(Request::METHOD_POST)
            ->setName('test')
            ->add('id', TextColumn::class, ['label' => 'id'])
            ->add('name', TwigColumn::class, ['label' => 'Name',
            'searchable' => false,
            'className' => 'bold',
            'template' => 'test/test2.html.twig'])
            ->createAdapter(ORMAdapter::class, [
                'entity' => User::class
            ])
            ->handleRequest($request);

        if ($table->isCallback()) {
            return $table->getResponse();
        }

        return $this->render('test/index2.html.twig', [
            'controller_name' => 'TestController',
            'datatable' => $table
        ]);
    }

And I'm dump row variable. And i see only this value of entity field which are is added by in the table fields. For example i have entity User with fields id, firstname, lastname, password, roles (with data stored in db)
When in table initialization i add column with field firstname, firstname is also visiable in dump in TwigColumn. But when is not added field is null. Can anyone have idea why?

This is intended behavior, the automatic query generator only selects fields which explicitly participate in the rendering, ie. through being added as columns. This avoids blowing up servers as the only other viable default is to select everything.
If you need to deviate from default behavior and select 'secondary fields', customize the query per the documentation to fit your needs.


Eliminate buffer copy bug in BGZFSplitGuesser.

In the existing BGZFSplitGuesser code, data from the InputStream is copied into a byte array, which is used as a buffer for finding the next BGZF block start. Previously, this code assumed that a non-negative return from the read call meant that the full amount of bytes requested were copied. This does not always happen, which can break the split guessing code. This patch adds logic to make sure that the buffer is filled.
Additionally, this patch rewrites the BGZF header guessing code. I did this as a debugging process (i.e., to better understand where the error was occurring) and I don't think it makes a big impact on correctness. It does seem to be slightly more performant; the ByteBuffer copy seems to be pretty slow. @tomwhite If you'd rather not rewrite that function, let me know, and I can take it out for later.

Coverage increased (+0.05%) to 62.042% when pulling a52a77225bb462957f13a904d86a85b2ef0080ab on fnothaft:bgzf-codec-incomplete-copy into ee35e91cb8f4a40f5b8ca11d839e06d412475be9 on HadoopGenomics:master.

@fnothaft I noticed that this logic is somewhat duplicated with BAMSplitGuesser. In fact, the same thing has been fixed there: https://github.com/HadoopGenomics/Hadoop-BAM/blob/master/src/main/java/org/seqdoop/hadoop_bam/BAMSplitGuesser.java#L126-L137. So you could use the same approach in BGZFSplitGuesser.
Do you have a way of testing this?
There are actually three split guessers: BAMSplitGuesser, BCFSplitGuesser, and BGZFSplitGuesser. The first two subclass BaseSplitGuesser so they can share some code, so maybe BGZFSplitGuesser could subclass it too, to share the implementation of guessNextBGZFPos. That's slightly different to this issue though, so should probably be done separately.
I would break out the changes to the BGZF header guessing to a separate PR. That should cover the other split guessers too.

Hi @tomwhite! Indeed, I was noticing that there are 3 split guessers as I was testing and working on this. I have been testing this on a mix of BGZF'ed FASTQs and VCFs. If you'd prefer, I can make BGZFSplitGuesser extend BaseSplitGuesser and then redo this using the logic from https://github.com/HadoopGenomics/Hadoop-BAM/blob/master/src/main/java/org/seqdoop/hadoop_bam/BAMSplitGuesser.java#L126-L137. The changes in the BGZF header detection code were more for debugging than anything, but they do appear to improve performance. I'm thinking I'll split the BaseSplitGuesser and array copy fix into a separate PR, and then we can review the BGZF header detection changes later. I'd love to get the array copy bug fixed in 7.9.0.

@fnothaft sounds good. Do you want to close or rename this PR now that #149 is in?

I'll close this for now. Thanks @tomwhite!


Add sub commands

Add init sub commands to create application in current directory
Add create sub commands to take path option
make Create Sub command create a new folder in the te current directory if the path is not provided using sample ths create --path app

fixed


Songs mashup new project

Type of change

[ ] Added SongsMashup project with Flask Connectivity
[ ] Currently Works On local Machine with all the libraries

Changes proposed in this pull request

Project name : SongsMashup

Short description : Flask Based Web App can produce mashup for any singer with songs available on youtube where a user enters the duration of each  song along with no of songs It doesn't use Youtube API but uses a third party API for youtube Work

Checklist

[ ] The code is Python 3 compatible
[ ] I have added relevant comments in my file to make code understandable
[ ] I have added my project in a folder which includes all the necessary files

Looks good to me
Happy Hacktoberfest 🎉


Will kongserver how to achieve dynamic api update with the etcd or consul

Now I have the latest docker environment and a kong container that needs to be updated automatically with the etcd or consul components. Valid API functionality, I am considering using consul, what should I do now? Or kong recommended and docker with what to find and register components

I believe this has been answered here: https://github.com/Mashape/kong/issues/1095. In short, point Kong's DNS to the server provided by Consul, or if you have multiple Consul instances, Kong -> Load Balancer -> Consul. Then just register your services on Consul as normal.

If you are running Kong in a Docker environment, please take some time to look at the official Docker Compose distribution which already registers Kong nodes automatically to both Consul and the LB: https://github.com/Mashape/docker-kong/tree/master/compose

Nginx role is to do load balancing kongserver?


Linux: add reboot() and constants

Add declarations from sys/reboot.h and linux/reboot.h. Initially originated as nix-rust/nix#386.

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.
If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.
Please see the contribution instructions for more information.

Should the rest of reboot declarations be in notbsd/mod.rs, or should I copy the declarations to notbsd/android, or are they somehow included from notbsd/linux/mod.rs (doesn't seem to be the case, but there are lots of functions there and just several in notbsd/android)?

If they're shared among all the platforms under notbsd (Android + Linux) then it should be fine to place the definitions in notbsd/mod.rs, but copying is also fine. Looks like CI is green here so I'd be good merging, but do you wanna juggle around the declarations a bit?

I'm not really sure whether the same stuff is available under Android: Android is Linux anyway, but it may well be glibc-specific stuff.
Let me try to put them into notbsd and see if that breaks the Android build.

OK, so it does break the Android build. Reverting.

Feel free to merge this (or should we play the rebasing/squashing game?).

Nah this is fine, thanks again!

Thanks! When can I expect this to be released (e.g. to use it in nix)?

Would it be possible for nix to use a git version of libc for now? I can be sure to make a release right before a nix release, but we just made a release yesterday I believe for another nix-requested PR :)

That being said, I certainly don't mind making another release!

Filed nix-rust/nix#387 for nix to track libc's master

Thanks! I'll add some comments over there as well.


SEP-24: add refund_memo and refund_memo_type support

PR Checklist
PR Structure

[x] This PR has reasonably narrow scope (if not, break it down into smaller PRs).
[x] This PR avoids mixing refactoring changes with feature changes (split into two PRs
otherwise).
[x] This PR's title starts with name of package that is most changed in the PR, ex.
paymentservice.stellar, or all or doc if the changes are broad or impact many
packages.

Thoroughness

[ ] This PR adds tests for the most critical parts of the new functionality or fixes.

What
Adds refund_memo and refund_memo_type support to SEP-24 POST /transactions/withdraw/interactive request.
Why
This was added to SEP-24. (#1321)

Something went wrong with PR preview build please check

@lijamie98 I noticed an inconsistencies with the SEP while making this change:
account is not required for SEP-24 POST /transactions/withdraw/interactive, but the service raises an error if its not specified. It should default to the authenticated account.
I noticed account is required for SEP-24 POST /transations/deposit/interactive though. This is an inconsistency and we should update the SEP so that account is optional just like the withdraw endpoint, and then we'll update the Anchor Platform to match it.

Something went wrong with PR preview build please check

Reference Server Preview is available here:https://anchor-ref-pr730.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr730.previews.kube001.services.stellar-ops.com/

@lijamie98 I noticed an inconsistencies with the SEP while making this change:
account is not required for SEP-24 POST /transactions/withdraw/interactive, but the service raises an error if its not specified. It should default to the authenticated account.
I noticed account is required for SEP-24 POST /transations/deposit/interactive though. This is an inconsistency and we should update the SEP so that account is optional just like the withdraw endpoint, and then we'll update the Anchor Platform to match it.

Hey @JakeUrban, I will submit a PR for the inconsistency.
The SEP does not specify the account in deposit as optional. https://github.com/stellar/stellar-protocol/blob/master/ecosystem/sep-0024.md#request
I think it is a bug in SEP24. Can you confirm?

not seeing any test coverage


Implement architecture for component JS to talk to other component JS

Current behavior

Components are initialized within their package scope, such as on here, so don't provide an opportunity for other components to listen to events on them or to call methods on their API (such as show/hide or whatever).

Expected behavior

Particular components are able to listen to events on other components and call public methods on those other component's API.

Related to https://github.com/cfpb/capital-framework/issues/667


[BEAM-2379] Avoid reading projectId from environment variable in tests.

SpannerOptions.Builder requires projectId to be not-null.
Was green because I had GOOGLE_APPLICATION_CREDENTIALS configured on my dev machine. Same for Jenkins, I guess.

R: @jbonofre
If LGTY can you test manually and merge? Jenkins seems broken right now so have to do it manually.

Thanks ! Let me review and test locally.


Optionally show saved variables and other grad_fn attrs

Pytorch master now has python bindings for saved variables and other non-tensor attrs. This PR adds support to display what pytorch now provides. See https://github.com/pytorch/pytorch/pull/52451
We also:

Make accumulate grad node explicit
Add capability to see view relationship between output tensor and its base from (https://github.com/alband/pytorchviz/tree/more_elements) by @albanD
As seen below, we have to make the font monospace so the attrs display neatly

Examples:

Did you run the tests locally?

The JIT tests I think have been failing since pt version 1.0? https://github.com/szagoruyko/pytorchviz/issues/27
Otherwise tests are fine.


[6.0] Disable sil verify all triggers verifier without asserts sil

Explanation: Disable test/SILOptimizer/sil_verify_all_triggers_verifier_without_asserts because it's causing a hang out Linux bots.
Scope: Disabling the test
Issues: Causing hangs in CI when building non assert toolchain for Linux platforms
Original PRs: https://github.com/swiftlang/swift/pull/76424
Risk: Low
Testing: Toolchain CI bot
Reviewers: @nate-chandler

@swift-ci test


Stackoverflow when using ReplaceChild

I just upgraded the dependency on html-agility-pack from an older version to 1.11.52 and suddenly started to get Stack overflow exceptions.
1. Description
The problem happens in a couple of areas that I have identified.
Using ReplaceChild (when replaced node has already been added to something else)
wrapperDivNode.ChildNodes.Add(nestedTable);
node.ParentNode.ReplaceChild(wrapperDivNode, nestedTable);

(details below)
and:
node.Attributes.RemoveAll();

The workaround here was to just iterate a new list and remove:
 foreach (var attr in node.Attributes.ToList())
 {
     node.Attributes.Remove(attr);
 }

There is a sample of the problem:
var tables = doc.DocumentNode.SelectNodes("//table");

if (tables != null && tables.Any())
{

    foreach (var table in tables)
    {
        var nestedTable = table;

        if (nestedTable != null)
        {
            // Wrap the table in a div "table-wrapper" so that we can apply "mobile table"-css.
            var wrapperDivNode = HtmlNode.CreateNode("

");

            wrapperDivNode.ChildNodes.Add(nestedTable);

            nestedTable.ParentNode.ReplaceChild(wrapperDivNode, nestedTable);

        }

    }
}

2. Exception
Could not get a good stack trace because of the stack overflow.
3. Fiddle or Project
Error:
https://dotnetfiddle.net/YJJ2jq
Moving the "ReplaceChild" before the "ChildNodes.Add" makes it work:
https://dotnetfiddle.net/sJCUmN
This used to work in older versions and it might be fair that it does not work but there should be a better exception and not a stack overflow.
Works:
4. Any further technical details
Add any relevant detail can help us, such as:

HAP version:
NET version Framework 4.7.2

Hello @enkelmedia ,
Thank you for the project. My developer will look at it.
Best Regards,
Jon

Sponsorship
Help us improve this library
Performance Libraries
context.BulkInsert(list, options => options.BatchSize = 1000);
Entity Framework Extensions • Dapper Plus
Runtime Evaluation
Eval.Execute("x + y", new {x = 1, y = 2}); // return 3
C# Eval Function

Hello @enkelmedia ,
A custom exception pointing to this issue has been added in the v1.11.53
The issue was caused because the ChildNodes of a Child contained the same list of ChildNodes as his parent, which led to a stack overflow exception. See this part: https://github.com/zzzprojects/html-agility-pack/blob/7c35d8f8f698a76a57dafe22d3d23b65b3815cd3/src/HtmlAgilityPack.Shared/HtmlNode.cs#L1003-L1016
Another way to make it work is to clone the current node that you want to replace and use it:
if (tables != null && tables.Any())
{
	foreach (var table in tables)
	{
		var nestedTable = table.Clone();

		// Wrap the table in a div "table-wrapper" so that we can apply "mobile table"-css.
		var wrapperDivNode = HtmlNode.CreateNode("

");

		wrapperDivNode.ChildNodes.Add(nestedTable);

		table.ParentNode.ReplaceChild(wrapperDivNode, table);
	}
}

Let me know if everything is fine for you or there is something else related to this issue.
Best Regards,
Jon

Are you finding this library useful? If so, please consider supporting its continued development by becoming a sponsor.
Additionally, if you think your enterprise would benefit from this library, we encourage you to suggest they become a sponsor as well. Your support will help ensure this library remains alive and well-supported.


[RI-675] Pin OSA_TEST_RELEASE and OSA_UPPER_CONSTRAINTS

Due to ongoing upstream improvements we need to pin the
OSA_TEST_RELEASE and OSA_UPPER_CONSTRAINS that we're using for
linting via tox. This adds both of those variables to functions.sh
as well as provides the ability to specify SHAs via the command-line.
JIRA: RI-675
based-on: 1997378f144fea2ad8e2729c0c25a8f383812ccb
Issue: RI-675

Thank you for submitting a pull request to this project!
Once all check jobs have passed and the pull request has received a
sufficient number of reviews, the repository's gate jobs can be triggered by
adding a comment of :shipit: to this pull request.
When the gate jobs have completed successfully, this pull request will get
merged automatically.


added it to data.json

will be a bit hard to differentiate can i just add an object named itememotes or somehting and give it vaules,
thanks.

If you believe so, you can add them as a sub-dictionary, perhaps emojis: {items: {}} ? Also, make them lowercase as items are case insensitive

ok so i do what u said rn


Special reason for this single kernel to be 3?

Is there any special reason why this only kernel=3? seems like copy paste :)
https://github.com/lucidrains/audiolm-pytorch/blob/d8d5798773edc2edba9d92d293039db893bd234b/audiolm_pytorch/soundstream.py#L347

thanks for reviewing the architecture :smiley:
it looks like i followed their diagram, and if you look at the bottom, they have k=3 for some reason

i see, once again referring to Encodec they seem to keep it simple:
input/output kernels = 7, residual kernel=3, and strangely enough they have only 1 residual unit inside encoder block

the details probably don't matter all that much
biggest conceptual leap is the residual quantization, and i squeezed in local attention (and just now a learned multi-headed EMA), which should both improve it even more

regardless, thanks for looking everything over! 🙏


Integration tests crash if Debug option is set to "all" on Windows

Description
After upgrading from version 1.5.2 to 1.6.3 some integration tests crash most of the time with the following message:
The active test run was aborted. Reason: Test host process crashed : %7|1617091644.569|BRKMAIN|rdkafka#producer-1| [thrd::0/internal]: :0/internal: Enter main broker thread
%7|1617091644.569|WAKEUPFD|rdkafka#producer-1| [thrd:app]: <IP_ADDRESS>:9092/bootstrap: Enabled low-latency ops queue wake-ups
%7|1617091644.569|BROKER|rdkafka#producer-1| [thrd:app]: <IP_ADDRESS>:9092/bootstrap: Added new broker with NodeId -1
%7|1617091644.569|CONNECT|rdkafka#producer-1| [thrd:app]: <IP_ADDRESS>:9092/bootstrap: Selected for cluster connection: bootstrap servers added (broker has 0 connection attempt(s))
%7|1617091644.569|INIT|rdkafka#producer-1| [thrd:app]: librdkafka v1.6.1 (0x10601ff) rdkafka#producer-1 initialized (builtin.features gzip,snappy,ssl,sasl,regex,lz4,sasl_gssapi,sasl_plain,sasl_scram,plugins,zstd,sasl_oauthbearer, SSL ZLIB SNAPPY SASL_SCRAM PLUGINS HDRHISTOGRAM, debug 0xfffff)
%7|1617091644.569|CONF|rdkafka#producer-1| [thrd:app]: Client configuration:
%7|1617091644.569|CONF|rdkafka#producer-1| [thrd:app]:   client.software.name = confluent-kafka-dotnet
%7|1617091644.569|CONF|rdkafka#producer-1| [thrd:app]:   client.software.version = 1.6.1
%7|1617091644.569|CONF|rdkafka#producer-1| [thrd:app]:   metadata.broker.list = <IP_ADDRESS>:9092
%7|1617091644.569|CONF|rdkafka#producer-1| [thrd:app]:   debug = generic,broker,topic,metadata,feature,queue,msg,protocol,cgrp,security,fetch,interceptor,plugin,consumer,admin,eos,mock,assignor,conf,all
%7|1617091644.569|CONF|rdkafka#producer-1| [thrd:app]:   dr_msg_cb = 00007FF9EA243544
%7|1617091644.569|BRKMAIN|rdkafka#producer-1| [thrd:<IP_ADDRESS>:9092/bootstrap]: <IP_ADDRESS>:9092/bootstrap: Enter main broker thread
%7|1617091644.569|CONNECT|rdkafka#producer-1| [thrd:<IP_ADDRESS>:9092/bootstrap]: <IP_ADDRESS>:9092/bootstrap: Received CONNECT op
%7|1617091644.569|STATE|rdkafka#producer-1| [thrd:<IP_ADDRESS>:9092/bootstrap]: <IP_ADDRESS>:9092/bootstrap: Broker changed state INIT -> TRY_CONNECT
%7|1617091644.569|BROADCAST|rdkafka#producer-1| [thrd:<IP_ADDRESS>:9092/bootstrap]: Broadcasting state change
%7|1617091644.569|CONNECT|rdkafka#producer-1| [thrd:<IP_ADDRESS>:9092/bootstrap]: <IP_ADDRESS>:9092/bootstrap: broker in state TRY_CONNECT connecting
%7|1617091644.569|STATE|rdkafka#producer-1| [thrd:<IP_ADDRESS>:9092/bootstrap]: <IP_ADDRESS>:9092/bootstrap: Broker changed state TRY_CONNECT -> CONNECT
%7|1617091644.569|BROADCAST|rdkafka#producer-1| [thrd:<IP_ADDRESS>:9092/bootstrap]: Broadcasting state change
%7|1617091644.569|CONNECT|rdkafka#producer-1| [thrd:<IP_ADDRESS>:9092/bootstrap]: <IP_ADDRESS>:9092/bootstrap: Connecting to ipv4#<IP_ADDRESS>:9092 (plaintext) with socket 1356
%7|1617091644.570|CONNECT|rdkafka#producer-1| [thrd:<IP_ADDRESS>:9092/bootstrap]: <IP_ADDRESS>:9092/bootstrap: Connected to ipv4#<IP_ADDRESS>:9092
%7|1617091644.570|CONNECTED|rdkafka#producer-1| [thrd:<IP_ADDRESS>:9092/bootstrap]: <IP_ADDRESS>:9092/bootstrap: Connected (#1)
%7|1617091644.570|FEATURE|rdkafka#producer-1| [thrd:<IP_ADDRESS>:9092/bootstrap]: <IP_ADDRESS>:9092/bootstrap: Updated enabled protocol features +ApiVersion to ApiVersion
%7|1617091644.570|STATE|rdkafka#producer-1| [thrd:<IP_ADDRESS>:9092/bootstrap]: <IP_ADDRESS>:9092/bootstrap: Broker changed state CONNECT -> APIVERSION_QUERY
%7|1617091644.570|BROADCAST|rdkafka#producer-1| [thrd:<IP_ADDRESS>:9092/bootstrap]: Broadcasting state change
%7|1617091644.570|SEND|rdkafka#producer-1| [thrd:<IP_ADDRESS>:9092/bootstrap]: <IP_ADDRESS>:9092/bootstrap: Sent ApiVersionRequest (v3, 52 bytes @ 0, CorrId 1)
%7|1617091644.571|RECV|rdkafka#producer-1| [thrd:<IP_ADDRESS>:9092/bootstrap]: <IP_ADDRESS>:9092/bootstrap: Received ApiVersionResponse (v3, 396 bytes, CorrId 1, rtt 0.81ms)
%7|1617091644.571|APIVERSION|rdkafka#producer-1| [thrd:<IP_ADDRESS>:9092/bootstrap]: <IP_ADDRESS>:9092/bootstrap: Broker API support:
%7|1617091644.571|APIVERSION|rdkafka#producer-1| [thrd:<IP_ADDRESS>:9092/bootstrap]: <IP_ADDRESS>:9092/bootstrap:   ApiKey Produce (0) Versions 0..8
%7|1617091644.571|APIVERSION|rdkafka#producer-1| [thrd:<IP_ADDRESS>:9092/bootstrap]: <IP_ADDRESS>:9092/bootstrap:   ApiKey Fetch (1) Versions 0..12
%7|1617091644.571|APIVERSION|rdkafka#producer-1| [thrd:<IP_ADDRESS>:9092/bootstrap]: <IP_ADDRESS>:9092/bootstrap:   ApiKey Offset (2) Versions 0..5
%7|1617091644.571|APIVERSION|rdkafka#producer-1| [thrd:<IP_ADDRESS>:9092/bootstrap]: <IP_ADDRESS>:9092/bootstrap:   ApiKey Metadata (3) Versions 0..9
%7|1617091644.571|APIVERSION|rdkafka#producer-1| [thrd:<IP_ADDRESS>:9092/bootstrap]: <IP_ADDRESS>:9092/bootstrap:   ApiKey LeaderAndIsr (4) Versions 0..4
%7|1617091644.571|APIVERSION|rdkafka#producer-1| [thrd:<IP_ADDRESS>:9092/bootstrap]: <IP_ADDRESS>:9092/bootstrap:   ApiKey StopReplica (5) Versions 0..3
%7|1617091644.571|APIVERSION|rdkafka#producer-1| [thrd:<IP_ADDRESS>:9092/bootstrap]: <IP_ADDRESS>:9092/bootstrap:   ApiKey UpdateMetadata (6) Versions 0..6
%7|1617091644.571|APIVERSION|rdkafka#producer-1| [thrd:<IP_ADDRESS>:9092/bootstrap]: <IP_ADDRESS>:9092/bootstrap:   ApiKey ControlledShutdown (7) Versions 0..3
%7|1617091644.571|APIVERSION|rdkafka#producer-1| [thrd:<IP_ADDRESS>:9092/bootstrap]: <IP_ADDRESS>:9092/bootstrap:   ApiKey OffsetCommit (8) Versions 0..8
%7|1617091644.571|APIVERSION|rdkafka#producer-1| [thrd:<IP_ADDRESS>:9092/bootstrap]: <IP_ADDRESS>:9092/bootstrap:   ApiKey OffsetFetch (9) Versions 0..7
%7|1617091644.571|APIVERSION|rdkafka#producer-1| [thrd:<IP_ADDRESS>:9092/bootstrap]: <IP_ADDRESS>:9092/bootstrap:   ApiKey FindCoordinator (10) Versions 0..3
%7|1617091644.571|APIVERSION|rdkafka#producer-1| [thrd:<IP_ADDRESS>:9092/bootstrap]: <IP_ADDRESS>:9092/bootstrap:   ApiKey JoinGroup (11) Versions 0..7
%7|1617091644.571|APIVERSION|rdkafka#producer-1| [thrd:<IP_ADDRESS>:9092/bootstrap]: <IP_ADDRESS>:9092/bootstrap:   ApiKey Heartbeat (12) Versions 0..4
%7|1617091644.571|APIVERSION|rdkafka#producer-1| [thrd:<IP_ADDRESS>:9092/bootstrap]: <IP_ADDRESS>:9092/bootstrap:   ApiKey LeaveGroup (13) Versions 0..4
%7|1617091644.571|APIVERSION|rdkafka#producer-1| [thrd:<IP_ADDRESS>:9092/bootstrap]: <IP_ADDRESS>:9092/bootstrap:   ApiKey SyncGroup (14) Versions 0..5
%7|1617091644.571|APIVERSION|rdkafka#producer-1| [thrd:<IP_ADDRESS>:9092/bootstrap]: <IP_ADDRESS>:9092/bootstrap:   ApiKey DescribeGroups (15) Versions 0..5
%7|1617091644.571|APIVERSION|rdkafka#producer-1| [thrd:<IP_ADDRESS>:9092/bootstrap]: <IP_ADDRESS>:9092/bootstrap:   ApiKey ListGroups (16) Versions 0..4
%7|1617091644.571|APIVERSION|rdkafka#producer-1| [thrd:<IP_ADDRESS>:9092/bootstrap]: <IP_ADDRESS>:9092/bootstrap:   ApiKey SaslHandshake (17) Versions 0..1
%7|1617091644.571|APIVERSION|rdkafka#producer-1| [thrd:<IP_ADDRESS>:9092/bootstrap]: <IP_ADDRESS>:9092/bootstrap:   ApiKey ApiVersion (18) Versions 0..3
%7|1617091644.571|APIVERSION|rdkafka#producer-1| [thrd:<IP_ADDRESS>:9092/bootstrap]: <IP_ADDRESS>:9092/bootstrap:   ApiKey CreateTopics (19) Versions 0..6
%7|1617091644.571|APIVERSION|rdkafka#producer-1| [thrd:<IP_ADDRESS>:9092/bootstrap]: <IP_ADDRESS>:9092/bootstrap:   ApiKey DeleteTopics (20) Versions 0..5
%7|1617091644.571|APIVERSION|rdkafka#producer-1| [thrd:<IP_ADDRESS>:9092/bootstrap]: <IP_ADDRESS>:9092/bootstrap:   ApiKey DeleteRecords (21) Versions 0..2
%7|1617091644.571|APIVERSION|rdkafka#producer-1| [thrd:<IP_ADDRESS>:9092/bootstrap]: <IP_ADDRESS>:9092/bootstrap:   ApiKey InitProducerId (22) Versions 0..4
%7|1617091644.571|APIVERSION|rdkafka#producer-1| [thrd:<IP_ADDRESS>:9092/bootstrap]: <IP_ADDRESS>:9092/bootstrap:   ApiKey OffsetForLeaderEpoch (23) Versions 0..3
%7|1617091644.571|APIVERSION|rdkafka#producer-1| [thrd:<IP_ADDRESS>:9092/bootstrap]: <IP_ADDRESS>:9092/bootstrap:   ApiKey AddPartitionsToTxn (24) Versions 0..2
%7|1617091644.571|APIVERSION|rdkafka#producer-1| [thrd:<IP_ADDRESS>:9092/bootstrap]: <IP_ADDRESS>:9092/bootstrap:   ApiKey AddOffsetsToTxn (25) Versions 0..2
%7|1617091644.571|APIVERSION|rdkafka#producer-1| [thrd:<IP_ADDRESS>:9092/bootstrap]: <IP_ADDRESS>:9092/bootstrap:   ApiKey EndTxn (26) Versions 0..2
%7|1617091644.57

Test Run Aborted.

The problem only appears on Windows, I tested on Ubuntu 20.04 as well and it works fine there.
The issue seems to originate from the disposal of the producer and consumer, and only if the the Debug option is set to all in the producer/consumer config. If the default Debug option is used the test succeeds.
The test also succeeds if a 2 second sleep is added before the Dispose calls in the tearDown
After further investigation I discovered that the problem only appears due to a specific commit in librdkafka introduced in the 1.6.0 release:  bfdeb265 Destroy coord and metadata caches after signalling termination to broker threads
Specifically in this commit moving the rd_kafka_metadata_cache_destroy call after decommissioning the brokers causes the issue. Reverting this change also fixes the problem. Unfortunately I am not sure what's the correlation between the issue and the change in the commit.
How to reproduce
[TestInitialize]
public void setUp() {
    LOG.Info(string.Format("{0} | {1}", TestContext.TestName, "setUp()"));
    var adminCfg = new AdminClientConfig {
        BootstrapServers = "<IP_ADDRESS>:9092",
        Debug = "all"
    };
    adminClient = new AdminClientBuilder(adminCfg).Build();
    adminClientService = new KafkaAdminClientService(adminClient, clusterName: "aa");
    var producerCfg = new ProducerConfig {
        BootstrapServers = "<IP_ADDRESS>:9092",
        Acks = Acks.All,
        Debug = "all"
    };
    producer = KafkaClientFactory.createProducer<long, string>(producerCfg);
    var consumerCfg = new ConsumerConfig {
        BootstrapServers = "<IP_ADDRESS>:9092",
        GroupId = "default",
        MetadataMaxAgeMs = 5000,
        EnablePartitionEof = true,
        EnableAutoCommit = false,
        AutoOffsetReset = AutoOffsetReset.Earliest,
        Debug = "all"
    };
    consumer = KafkaClientFactory.createConsumer<long, string>(consumerCfg);
}

[TestCleanup]
public void tearDown() {
    LOG.Info(string.Format("{0} | {1}", TestContext.TestName, "tearDown()"));
    consumer.Close();
    producer.Dispose();
    adminClient.Dispose();
    Assert.AreEqual(0, Library.HandleCount, "Library.HandleCount > 0 after teardown. -- Dangling resource bug maybe?");
}

[TestMethod, Timeout(60 * 1000), TestCategory("SingleBroker")]
public void weCanCreateTopics() {
    producer.ProduceAsync("test_topic", new Message<long, string> { Value = "test" }).Wait();
    var topicListing = adminClientService.getTopicListing();
    Assert.IsTrue(topicListing.Contains(topicName));
}

Checklist
Please provide the following information:

[X] A complete (i.e. we can run it), minimal program demonstrating the problem. No need to supply a project file.
[X] Confluent.Kafka nuget version: 1.6.3, librdkafka version 1.6.1
[X] Apache Kafka version: 2.7.0
[X] Client configuration.
[X] Operating system: Windows 10
[X] Provide logs (with "debug" : "..." as necessary in configuration).
[X] Provide broker log excerpts.
[ ] Critical issue.

thanks for reporting. do you see this with 1.7.0-RC4 (now on nuget)?

Thanks for the update! I ran my test suite with version 1.7.0-RC4 and the issue does not appear anymore.

great! thanks for checking. i do have recollection of reviewing a related PR on librdkafka, so I assume it's been resolved.


Disable the ClientMonitoring cluster APIs on Darwin for now.

It's not quite stable enough to ship as public API yet.
Adds wasRemoved checks to various places so we handle removals better in our codegen.

Fast-tracking platform-specific change with platform owner review.


Cannot load saved trained models

Hello,
I tried to run the examples in the plotting.ipnyb notebook but could not load any of the provided trained models.
(I'm loading the models on a CPU device and had to had map_location=DEVICE when loading the model)
Here's a an example of the issue for the 05_experimental_training_datasets_pyg dataset and fine_tuned_best_model.pt checkpoint:
Running this code:
r, val_x = [], []
for i in range(nr_of_training_runs):
    base = f'{wdr_dir}/trained_models/training_run_{i}/'
    checkpoint = torch.load(f"{base}/fine_tuned_best_model.pt", map_location=DEVICE)
    model.load_state_dict(checkpoint["model_state_dict"])

Results in the following error:

KeyError                                  Traceback (most recent call last)
Input In [27], in <cell line: 63>()
     64 base = f'{wdr_dir}/trained_models/training_run_{i}/'
     65 checkpoint = torch.load(f"{base}/fine_tuned_best_model.pt", map_location=DEVICE)
---> 66 model.load_state_dict(checkpoint["model_state_dict"])
     67 model.eval()
     68 model.to(device=DEVICE)

File ~/miniforge3/envs/armpytor/lib/python3.8/site-packages/torch/nn/modules/module.py:1483, in Module.load_state_dict(self, state_dict, strict)
   1480         if child is not None:
   1481             load(child, prefix + name + '.')
-> 1483 load(self)
   1484 del load
   1486 if strict:

File ~/miniforge3/envs/armpytor/lib/python3.8/site-packages/torch/nn/modules/module.py:1481, in Module.load_state_dict.<locals>.load(module, prefix)
   1479 for name, child in module._modules.items():
   1480     if child is not None:
-> 1481         load(child, prefix + name + '.')

File ~/miniforge3/envs/armpytor/lib/python3.8/site-packages/torch/nn/modules/module.py:1481, in Module.load_state_dict.<locals>.load(module, prefix)
   1479 for name, child in module._modules.items():
   1480     if child is not None:
-> 1481         load(child, prefix + name + '.')

    [... skipping similar frames: Module.load_state_dict.<locals>.load at line 1481 (2 times)]

File ~/miniforge3/envs/armpytor/lib/python3.8/site-packages/torch/nn/modules/module.py:1481, in Module.load_state_dict.<locals>.load(module, prefix)
   1479 for name, child in module._modules.items():
   1480     if child is not None:
-> 1481         load(child, prefix + name + '.')

File ~/miniforge3/envs/armpytor/lib/python3.8/site-packages/torch/nn/modules/module.py:1477, in Module.load_state_dict.<locals>.load(module, prefix)
   1475 def load(module, prefix=''):
   1476     local_metadata = {} if metadata is None else metadata.get(prefix[:-1], {})
-> 1477     module._load_from_state_dict(
   1478         state_dict, prefix, local_metadata, True, missing_keys, unexpected_keys, error_msgs)
   1479     for name, child in module._modules.items():
   1480         if child is not None:

File ~/miniforge3/envs/armpytor/lib/python3.8/site-packages/torch/nn/modules/module.py:1380, in Module._load_from_state_dict(self, state_dict, prefix, local_metadata, strict, missing_keys, unexpected_keys, error_msgs)
   1348 r"""Copies parameters and buffers from :attr:`state_dict` into only
   1349 this module, but not its descendants. This is called on every submodule
   1350 in :meth:`~torch.nn.Module.load_state_dict`. Metadata saved for this
   (...)
   1377         :meth:`~torch.nn.Module.load_state_dict`
   1378 """
   1379 for hook in self._load_state_dict_pre_hooks.values():
-> 1380     hook(state_dict, prefix, local_metadata, strict, missing_keys, unexpected_keys, error_msgs)
   1382 persistent_buffers = {k: v for k, v in self._buffers.items() if k not in self._non_persistent_buffers_set}
   1383 local_name_params = itertools.chain(self._parameters.items(), persistent_buffers.items())

File ~/miniforge3/envs/armpytor/lib/python3.8/site-packages/torch_geometric/nn/dense/linear.py:140, in Linear._lazy_load_hook(self, state_dict, prefix, local_metadata, strict, missing_keys, unexpected_keys, error_msgs)
    137 def _lazy_load_hook(self, state_dict, prefix, local_metadata, strict,
    138                     missing_keys, unexpected_keys, error_msgs):
--> 140     weight = state_dict[prefix + 'weight']
    141     if is_uninitialized_parameter(weight):
    142         self.in_channels = -1

KeyError: 'convs.0.nn.lins.0.weight'

I believe this is a result of a pytorch-geometric version mismatch.
We have experienced this ourselves --- the models were saved with pyg                       2.0.1, and that is also the version that is needed to load the weights.


Onigashima .lua script will not run

(I have basically 0 coding experience so I apologize for my potential ineptitude here)
Hello! I recently found this project and was interested in trying it out with Shin Onigashima, but I've been having trouble getting the .lua file for the game working. As far as I'm aware I've properly followed every step of the guide, but when I run the .lua script the Windows command prompt opens and closes immediately, and nothing else happens after that. I'm running the game on Mesen 0.9.9, and I have everything set up in the same directory, including the emulator and the rom.
I'm not sure what I'm doing wrong here, so your help would be very much appreciated. Thank you in advance, and sorry to bother you!

Sorry that I missed this for so long!  It sounds like you are trying to run the script from outside the emulator.  The command prompt shouldn't ever open.  The emulator should have an option for Lua scripts somewhere, and you need to open the Lua script in the emulator.  I seem to remember it was different on Windows than on Linux and I don't have a Windows machine available to me at the moment so I don't remember exactly where it is, but there should be some menu option that says "Script Window" or something.

Oh that's exactly where it was! I had no idea you could open scripts like that on Mesen haha.
However, when I tried to run the script it gave me an "invalid escape sequence" error on the first line, where you paste the directory.

Did you use backslashes in the directory?  I think you need to use forward slashes.

I did, and that seemed to be the issue there, although I also had to add a slash in front of mesen.lua on the next line so it would stop reading the file name as part of the directory lol (I don't know if this actually fixed that issue but it seemed to stop the error at least). But now when I try to run the script it shows me this:

Are you sure it's not working?  The script doesn't kick in until a new message appears, and I left the title screen untranslated.  Try starting the script on the title screen and then pressing start to see if the message there is still in Japanese.

I just tried that now and yeah it's still in Japanese. The text you see when you sit on the title screen for long enough isn't changed either, if that was also translated.

Oh looking into this a bit more it seems like it can't open the file "onigashima_messages.bin" for some reason.  You can try adding e.log(messages_filename) right before line 58 to see what file the script is trying to open.
...also, I just now realized I accidentally put "rb" as an argument to assert, not io.open.  That might have actually been the cause of a bunch of issues I've had in the past.  You might get a more helpful error message if on line 58 you move the ) after messages_filename to the end of the line next to the other ).  I'll fix this myself at some point soon, but I need to test that it won't break anything first.

I followed what you said and this is the error message that I got (the blank spots in the directory are my actual name lol):

Since this was an issue I was having before (with it combining mesen.lua into the directory improperly) i added forward slashes to the messages and options .bin files, and it actually started working from this! I've only skimmed through the game a little bit so far but the script seems to be running fine. I don't know how helpful that would be for you though haha.


Installing release 2.3 appears to install 2.2

I have installed SpeechPy as part of my review of the package. Installing the package, I found a minor issue with the version number: I explicitly checked out the '2.3' release for installation whereas the install script output refers to version 2.2:
$ python setup.py develop
running develop
running egg_info
creating speechpy.egg-info
writing speechpy.egg-info/PKG-INFO
writing dependency_links to speechpy.egg-info/dependency_links.txt
writing requirements to speechpy.egg-info/requires.txt
writing top-level names to speechpy.egg-info/top_level.txt
writing manifest file 'speechpy.egg-info/SOURCES.txt'
reading manifest file 'speechpy.egg-info/SOURCES.txt'
reading manifest template 'MANIFEST.in'
writing manifest file 'speechpy.egg-info/SOURCES.txt'
running build_ext
Creating /home/tha/.conda/envs/joss-review-tmp/lib/python3.6/site-packages/speechpy.egg-link (link to .)
Adding speechpy 2.2 to easy-install.pth file

Installed /home/tha/other-repo/speechpy
Processing dependencies for speechpy==2.2
Searching for numpy==1.14.3
Best match: numpy 1.14.3
Adding numpy 1.14.3 to easy-install.pth file

Using /home/tha/.conda/envs/joss-review-tmp/lib/python3.6/site-packages
Searching for scipy==1.1.0
Best match: scipy 1.1.0
Adding scipy 1.1.0 to easy-install.pth file

Using /home/tha/.conda/envs/joss-review-tmp/lib/python3.6/site-packages
Finished processing dependencies for speechpy==2.2

I suspect this is just some configuration text string that was not properly updated for the 2.3 release?

@ThomasA Thank you so much for declaring the issue. You are absolutely correct.
The version text string has been modified and the package has been updating to PyPi with the correct version.

@ThomasA Please close this issue once you realized the problem has been resolved. Thanks!


Update to 1.7.4

add doc for 1.7.3 and 1.7.4

Please clean up the yarn.lock file and re-run yarn install to install the dependencies, and fix the linking problem (no spaces in the link address)


Feature: add readonly attribute support for text field

resolves https://github.com/baoagency/polaris_view_components/issues/302

Would it makes sense for this to be true as well when disabled is passed based on #302?

@dan-gamble - My fear with that would be that any code which un-disables a field, would not know it now also has to remove readonly (unless you have a stimulus controller which syncs them in the library). So maybe a good idea to leave readonly to be set explicitly?

Makes total sense @forsbergplustwo. Just wasn't sure if this would work differently to "native" Rails if it didn't.

@dan-gamble - Yeah good question. Guess we want forms to act as natively as possible, so maybe worth doing as you suggested.

Hey @dan-gamble, I didn't get the point why we should set the field to true when disabled is also true. There are two different attributes specified for different purposes. Here is a definition: https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes/readonly#attribute_interactions
So I believe that it's reasonable to leave this PR as is

@k0va1 Thanks for the PR!
@dan-gamble In Rails disabled=true doesn't add readonly attribute automatically. Just double-checked it. So let's keep this PR as is.


Add Figma Contribution Guide

I added a simple Figma contribution guide to make it easier for new contributors to get started, as I saw that help was requested.

Awesome work, thank you so much!


Incomplete documentation for firebase-ui-auth

There are few neat features in new release. Unfortunately there seems to be no documentation available (at least I weren't able to find one :D) . For example the new sign up feature is awesome, but I need to create few fields for each registered user. Or (different case) I'd like to be able to disable the sign up feature. How would one go about that?
Keep up the awesome work :+1:

@brezinajn thanks for trying the library. We are definitely working on expanding the documentation to cover the whole API surface.
If you have specific questions about the API I'm happy to answer them here.

I'd like to know if there is possibility to disable the sign up.

Hello! I had an issue with firebase. For dummy users, I was providing 3-4 lettered passwords, but firebase needs at least 6 characters. Could I modify the documentation accordingly? :)

@sathe-aditya did the UI not tell you to use a 6 character password?  When I try to use a short password I see the error on screen "Strong passwords have at least 6 characters and a mix of letters and numbers".

I am going to close this issue as it's pretty old and not specific enough to address.  @brezinajn @sathe-aditya if you see anything in the documentation that you want to change, please send over a PR!


cmd/go: running go build ./... returns an exit code of 0 even if there are compile errors

version: go version go1.4 darwin/amd64
operating system: OSX 10.10.2
Running go build ./... returns an exit code of 0 even if there are compile errors. For example, running go build ./... in a directory containing a single file that contains parse errors:
$ go build ./...
... build errors ...
$ echo $?
0

This does not, however, happen when simply running go build .:
$ go build .
... build errors ...
$ echo $?
1

Running go build ./... reports the parse errors while evaluating the wildcard ./.... The rule for wildcards is to ignore directories without Go source code or for which the Go source code is malformed. Maybe that's a mistake.

what aboult go test ./...

@xjewer this issue is closed, please try go 1.7beta1 and open a new issue if necessary.

my bad, go test ./... work properly 👌


Select apps of interest from the playstore

Initial work to download reviews from the app store. More work to do:

allow code to break and resume to reduce issues when downloading large numbers of reviews
it's a bit unsatisfactory having to copy the innerHTML from a web browser DOM Inspector to access the apps for a given category; might want to consider Selenium in future

Checklist:

[ ] I have refactored my code out from notebooks
[ ] I have checked the code runs
[ ] I have tested the code
[ ] I have run pre-commit and addressed any issues not automatically fixed
[ ] I have merged any new changes from dev
[ ] I have documented the code

[ ] Major functions have docstrings
[ ] Appropriate information has been added to READMEs

[ ] I have explained the feature in this PR or (better) in output/reports/
[ ] I have requested a code review

Addressed all issues save error handling and catching specific exceptions, which I'll address in a separate issue