Backspace should delete items in multiselect dropdowns

Fixes #1547
Not sure why there was an if statement to prevent deletion of multiple items when not searching, but it means the component is not accessible to keyboard users. This removes that restriction.

Codecov Report

Merging #1548 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1548      +/-   ##
==========================================
- Coverage   99.74%   99.74%   -0.01%
==========================================
  Files         141      141
  Lines        2381     2380       -1
==========================================
- Hits         2375     2374       -1
  Misses          6        6

Impacted Files
Coverage Δ

src/modules/Dropdown/Dropdown.js
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf09457...c921a75. Read the comment docs.

Hm, I'm not sure about this one.  There is no input because there is no search prop, hence, there is nothing to press backspace in.  In order to remove labels on backspace, there needs to be a cursor to indicate to the user that they can do this.  Otherwise, I fear it will be confusing.
It would also deviate from SUI core as the core dropdown does not behave this way: https://semantic-ui.com/modules/dropdown#multiple-selection

would it be acceptable to add some kind of cursor to give that indication? Or are you disinclined to fix this issue because SUI core doesn't handle it?

The primary concern for me is the UX.  I think backspace behavior is best suited for controls which accept keyboard input and show an input cursor.  Although we could add a readonly input in order get a cursor, I think it'd be confusing to users as to why there is a cursor and backspace works but they are unable to type anything.
This does raise the question, rather than adding a faux cursor and new backspace functionality to a non-search Dropdown, why not use a search Dropdown?  This would add the cursor, allow backspace, and the user can type into the dropdown.
If there is a hard requirement here for not allowing search but still allowing backspace, you can always wrap the Dropdown, handle backspace, and control the options.  Something like:
handleKeyDown = e => {
  const { options } = this.state
  if (e.key === 'Backspace') {
    this.setState({ options: options.slice(0, options.length - 1)
  }
}

<Dropdown onKeyDown={this.handleKeyDown} options={this.state.options} />

I will close this for now.  If we get more requests, I'll reopen this one and perhaps change my views on it.  I do appreciate your input and effort to help improve this library.


Use linear time algorithm for topological sorting. (Fixes #6285)

This change splits determining the computation graph depth into two phases:

Traversal happens in the same order as previously, but nodes are only appended to a list that is sorted in order of decreasing depth. This means that the work of updating the depth for each node is does not have to be repeated for shared subgraphs, and the algorithm can completely ignore nodes it has already seen once. This means that the runtime will be linear in the number of nodes.
The actual node depths are then determined by a single pass across all nodes.

Because the layer ordering only depends on the layer depth and the time the layer is first seen during traversal, the observable outputs are completely identical to the current implementation.
With this change, make_left_tower and make_right_tower from #6285 run in exactly the same time, which is not observably slower than the current implementation, even for hundreds of nodes.

Because the layer ordering only depends on the layer depth and the time the layer is first seen during traversal, the observable outputs are completely identical to the current implementation.

Preserving layer order is necessary to ensure backwards compatibility of saved models. Are there empirical guarantees that the order is preserved? (e.g. a unit test covering fairly complex models -- Inception V3 maybe)

The best way to test this would probably be to save the model weights using the old layer sorting code and test that the model predictions are as expected after restoration. But I assume you won't want to put a full Inception model in the Keras repository just for testing.
Barring that, I check that the layers have the correct classes and have weights of the correct shape. This still doesn't rule out identically shaped layers with different weights swapping places, but there are enough differently shaped layers in parallel, that such an error should be caught anyway.
I wasn't sure where to put the test data, so I just added it as two long lists inside the test code.

Simply running this script with the master branch and this PR and checking that the predictions are the same would be enough. You can also do this for ResNet50 and Xception.

When you wrote "unit test", I thought you meant adding one to the automated test suite. I guess it can't hurt to have the sanity check in there.
Anyway, running the three scripts on a random picture (is elephant.jpg supposed to be some standard test image?), I get byte-identical outputs on the two different branches.

LGTM. Please revert the test you added in test_topology.py. A one-time test is enough here, because we're only trying to test correctness, whereas unit tests exist mostly to avoid breaking things when making changes in the future.

I removed the extra commits.


Set $? correctly for command expression with redirections

PR Summary
Fix #16033
This PR makes a small update to ShouldSetExecutionStatusToSuccess(PipelineAst) to not exclude single expression with redirections, so that $? can be set to true properly for single-element pipeline that only contains a command expression with redirections.
PR Checklist

[x] PR has a meaningful title

Use the present tense and imperative mood when describing your changes

[x] Summarized changes
[x] Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
[x] This PR is ready to merge and is not Work in Progress.

If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.

Breaking changes

[x] None
OR
[ ] Experimental feature(s) needed

[ ] Experimental feature name(s):

User-facing changes

[x] Not Applicable
OR
[ ] Documentation needed

[ ] Issue filed:

Testing - New and feature

[ ] N/A or can only be tested interactively
OR
[x] Make sure you've added a new test if existing tests do not effectively test the code changed

Tooling

[x] I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.

Do we already have regression tests verifying that the (command) vs command still behaves as expected?

@iSazonov Thanks for adding the needed labels!
@vexx32 Are you concerned about the paren expression specifically? Can yo please provide a couple examples to show what you think could be regressed?

The change that (seemingly) caused this one to crop up was the change for (Invoke-Cmd) where Invoke-Cmd would set $? to false if it fails, but in parentheses it would fail to set it correctly.
So I guess a test case would be:
function fail {
    [CmdletBinding()]
    param()
    try { throw } catch { $PSCmdlet.WriteError($_) }
}

fail
$? | Should -BeFalse
(fail)
$? | Should -BeFalse

Backport rejected as this does not meet the bar. This will cause a change in behavior for 7.0.x and 7.1.x.

@vexx32 It still behaves as expected, but I don't know if we have such test already. I can add one if not.


Makefile.prow GOFLAGS= when go install

Prow complaining during go install only.
go: parsing $GOFLAGS: non-flag "\"-mod=mod\""

Thank you for contributing to Velero!
Please add a summary of your change
Does your change fix a particular issue?
Fixes #(issue)
Please indicate you've done the following:

[ ] Accepted the DCO. Commits without the DCO will delay acceptance.
[ ] Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
[ ] Updated the corresponding documentation in site/content/docs/main.

/lgtm


Cannot create ClusterIssuers when upgrading a helm release

Describe the bug:
Cannot create the ClusterIssuers, because the webhook /mutate fails with context deadline exceeded.
Expected behaviour:
After I installed cert-manager from the helm chart (to a separate namespace), I wanted to update my application's release. The release included two ClusterIssuer (letsencrypt-staging and letsencrypt-prod). After I ran helm upgrade --namespace app app ./app I received the following error:
Error: UPGRADE FAILED: failed to create resource: Internal error occurred: failed calling webhook "webhook.cert-manager.io": Post https://cert-manager-webhook.cert-manager.svc:443/mutate?timeout=30s: dial tcp <IP_ADDRESS>:443: i/o time out
and sometimes I got:
Error: UPGRADE FAILED: failed to create resource: Internal error occurred: failed calling webhook "webhook.cert-manager.io": Post https://cert-manager-webhook.cert-manager.svc:443/mutate?timeout=30s: context deadline exceeded
(Seems to be random?)
I found several similar issue on GitHub but none of the workarounds worked. If I comment out the Issuer creation template in Helm, the app can be deployed. I allowed every port now on DigitalOcean's firewall. I'm not sure how can I check if the control plane can access the pod (I guess that's the reason it cannot call the webhook?)
Anything else we need to know?:
Environment details::

Kubernetes version (e.g. v1.10.2): Client: 1.16.6, Server: 1.17
Cloud-provider/provisioner (e.g. GKE, kops AWS, etc): DigitalOcean Manager Kubernetes
cert-manager version (e.g. v0.4.0): 0.15.0
Install method (e.g. helm or static manifests): Helm chart

/kind bug

before upgrade, what's the version?

Always used 0.15 for cert-manager. It even happens if I reinstall the cert-manager chart. Only happens if the chart wants to update/create the ClusterIssuer type manifests. Should I skip the issuer template if they are already created? I thought I can keep them in my charts.
I attached the ClusterIssuers's template file:
{{ $rlsName := .Release.Name }}
{{- if .Values.defineIssuers }}
{{- range .Values.issuers  -}}
apiVersion: cert-manager.io/v1alpha2
kind: ClusterIssuer
metadata:
  name: {{ .name }}
spec:
  acme:
    # Email address used for ACME registration
    email: {{ .email }}
    server: {{ .server }}
    privateKeySecretRef:
      # Name of a secret used to store the ACME account private key
      name: {{ .name }}-private-key
    # Add a single challenge solver, HTTP01 using nginx
    solvers:
      - dns01:
          digitalocean:
            tokenSecretRef:
              name: {{ $rlsName }}-digitalocean-dns
              key: access-token
---
{{- end }}
{{- end }}

/triage support
Can you check the status of the webhook pod? I never had any issues with the webhook myself on DO.

All looking good so far:
helm git:master ❯ kubectl get pods --namespace cert-manager                                                                                ⏎ ✹

NAME                                       READY   STATUS    RESTARTS   AGE
cert-manager-766d5c494b-ptskw              1/1     Running   0          16h
cert-manager-cainjector-6649bbb695-vm6dh   1/1     Running   0          16h
cert-manager-webhook-68d464c8b-dpqtl       1/1     Running   0          16h

I ran my deploy command again, and checked the logs on the webhook pod:
W0526 15:28:55.654467       1 client_config.go:543] Neither --kubeconfig nor --master was specified.  Using the inClusterConfig.  This might not work.
I0526 15:28:55.656102       1 webhook.go:63]  "msg"="using dynamic certificate generating using CA stored in Secret resource"  "secret_name"="cert-manager-webhook-ca" "secret_namespace"="cert-manager"
I0526 15:28:55.656572       1 server.go:139]  "msg"="listening for insecure healthz connections"  "address"=":6080"
I0526 15:28:55.656653       1 server.go:152]  "msg"="listening for secure connections"  "address"=":10250"
I0526 15:28:55.656694       1 server.go:178]  "msg"="registered pprof handlers"
I0526 15:28:55.670812       1 reflector.go:175] Starting reflector *v1.Secret (1m0s) from external/io_k8s_client_go/tools/cache/reflector.go:125
I0526 15:28:55.706412       1 authority.go:248]  "msg"="Detected change in CA secret data, notifying watchers..."
I0526 15:28:56.656971       1 dynamic_source.go:171]  "msg"="Generating new ECDSA private key"
I0526 15:28:56.662493       1 dynamic_source.go:186]  "msg"="Signing new serving certificate"
I0526 15:28:56.685027       1 dynamic_source.go:192]  "msg"="Signed new serving certificate"
I0526 15:28:56.691712       1 dynamic_source.go:198]  "msg"="Updated serving TLS certificate"

these are all logs from yesterdays, seems like nothing has reached the pod
Could it be that the DO VPC interferes with K8S internal IPs?

Thats weird. I re-created the whole cluster and now everything seems to be working. I'll close this for now, but will report back if anything changes or if I could find out what seem to broke the webhook.


Use Metadata10 to parse PKG-INFO of legacy editable

It turns out setuptools often uses Metadata-Version 2.1 in their PKG-INFO: https://github.com/hauntsaninja/setuptools/blob/4e766834d72623f3b938f1d4148547ea73af1bf5/setuptools/dist.py#L64
Metadata23 requires Metadata-Version of at least 2.2.
This means that uv doesn't actually recognise legacy editable installations from the most common way you'd actually get legacy editable installations (works great for most legacy editables I make at work though!)
Anyway, over here we only need the version and don't care about anything else. Rather than make a Metadata21, I just add a version field to Metadata10. The one slightly tricky thing is that only Metadata-Version 1.2 and greater guarantee that the version number is PEP 440 compatible, so I store the version in Metadata10 as a String and only parse to Version at time of use.
Also did you know that back in 2004, paramiko had a pokemon based versioning system?

Thanks! LGTM.


All targets are run when a file is renamed by Webstorm

I am using Webstorm on Windows 8.1 for my development environment. I setup my watch target as follows:
...
watch: {
injectJS: {
      files: 'client/**/*.js'
      tasks: ['injector:scripts']
      }
jade: {
     files: 'client/**/*.jade'
     tasks: ['compileJade']
    }
}
...

I then run grunt watch from command line and go about editing files in Webstorm. The problem is that when I change a file in Webstorm (for instance a .jade file), it looks like webstorm first renames the file to filename.jade___jb_old___. From looking in the source code, this then triggers a rename event on all the watch targets, which in turns queues up the all the tasks to be run again. In the example above, both injector:scripts and compileJade tasks are run again.

It seems to be an issue with Gaze - when a file changes, Gaze emits the event on all Gaze instances. Because watch does something like (pseudocode), tasks for all targets are run:
forEach(targets, function(target){
      new Gaze(target.pattern, function(err){
              this.on('all', function(){
                   target.task.run()})})})

Is this expected?

Changing the gaze version to 0.5.1 fixes the problem for now.


Count chars when creating SourceAnnotation

Fixes https://github.com/rust-lang/rustfmt/issues/6083.
In annotate snippets it takes the length of the string by char count https://github.com/rust-lang/annotate-snippets-rs/blob/master/src/renderer/display_list.rs#L935, both on 0.9 and 0.10, but in the code here the
length is taken by byte-index.
Since the user's string has chars that do not correspond 1-to-1 with byte-indices there's a range-mismatch and a following panic.
It only occurs in some cases and was fairly hard to reproduce, I think it has something to do with max line-count as well, and that's when it blows up.
I'm not so familiar with this repo, I can't get the test to pass. The source can't be formatted, since the comment would be lost, but if that's disabled rustfmt will err on trailing whitespace and I don't know if that can be disabled, but the test really checks that rustfmt doesn't panic, so maybe it just doesn't fit into this mould.
E: I put the test-file under its own directory and added it to the dont_emit_ice_test instead.
Can easily be reproduced by running rustfmt tests/issue-6083/issue_6083.rs vs cargo run --bin rustfmt -- tests/issue-6083/issue_6083.rs on this branch.

@MarcusGrass thanks for looking into this! I came to the same conclusion regarding chars vs bytes when I looked into this a while ago. I'll follow up when I've had a chance to take a look at this / refresh my memory on what I was looking into previously. This has been a long standing issue and I'd be very glad if we could fix it!


Feature requests - motion sensor and arm/disarm history

First of all, a big thank you for the work with this. I am successfully integrating my Lupus Alarm with Home Assistant.
However, there are some bits and pieces missing and I though I could maybe be of assistance in some way.
Firstly, there seems to be no way to see the history of who armed or disarmed the alarm, which is displayed looking at the alarm panel in a web browser.
Secondly, motion sensors are not available. I only have one, but it would be nice to see if there has been any motion in the house.
I'll be glad to help out with testing (within Home Assistant) if there is anything I can do.
Thank you!

The status of the motion sensor is not transmitted into the webinterface of the Lupus, so it's impossible to read these states. The history of arming could be possible, you have to find a similiar example integrated in hass.

Yes, you are right, it is not shown in the alarm panel. I have another hass instance, which integrates Sector Alarm. It shows me the "changed_by" attribute. My Lovelace code for that looks like this:
  - type: custom:button-card
    entity: alarm_control_panel.sector_alarm_02602218
    show_label: false
    show_name: true
    show_icon: true
    show_last_changed: true
    name: >
      [[[
      return "Ändrad av " + entity.attributes.changed_by
      ]]]

You can always just run a file sensor (https://www.home-assistant.io/integrations/file/) on the hidden history file which is inside your home and revealed by:
ls -la

So question is, do you still need the history even when you have the logbook?

Yes, I really would like to read the history of the Lupus Alarm too. If we consider the following json history data retrieved from lupupy, some of it but not all will show in the log book.
    {
        "a": "Disarm",
        "d": "09/16",
        "s": "Webserver",
        "t": "17:48"
    },
    {
        "a": "Arm",
        "d": "09/16",
        "s": "Front door, Keypad, Cilla",
        "t": "18:12"
    },
    {
        "a": "Eingang",
        "d": "09/16",
        "s": "Front door, Türkontakt",
        "t": "21:32"
    },
    {
        "a": "Disarm",
        "d": "09/16",
        "s": "Front door, Keypad, Tomas",
        "t": "21:33"
    }

The log book will show e.g. the following:

But it will not show who armed or disarmed the alarm with the keypad, which the Lupus history tells me.
For that purpose, it would be nice to at least have the attribute "changed_by", and if adding that I guess it wouldn't be too difficult to implement the attribute "last_changed", which could be easily be read and displayed in hass.

So question is, do you still need the history even when you have the logbook?
https://github.com/royto/logbook-card
This card is basically what you are looking for.

I will look into this card also, but it won't cater for all of my needs as some data is only available in the Lupus history.

https://www.home-assistant.io/blog/2020/11/18/release-118/
The logbook card is now a part of the official hass release.

Ok, I don't have the possibility to test this right now, but are you sure all the history will be visible in the logbook card or only the data that was available in the previous logbook card?

As stated, it would be an absolute Nightmare to import the messages from the lupusec webserver to homeassistant. I would just point all users to use hass and not the lupusec app.


Data bug with GY-273

This compass always reports west facing directions. At a quick glance, it looks like we're not getting numbers below 128, so I'm guessing there's a signed math bug somewhere.

I'm pretty sure my compass wasn't calibrated properly, so closing


Algorithmic art - @rafpinter contribution to vernissage webpage

Adding my contribution to our page!

splendid!
thank you @rafpinter


add pip options to install.doc

The docstring should already be set with introduction to pipster.install(), but then after the function is declared, do something like...
install.__doc__ += pip_options_docstring()

The command options can be taken from pipster.install.install_cmd, and it looks like the best approach would be to create a custom formatter, similar to those found in pip._internal/cli/parser.py.

Be sure to add a note to the README about this (next to the part about not guaranteeing valid arguments)


OSD-15146

Secondary SSS template to support acceptance controller deployments of AVO independently from the resources it manages.

/hold

/unhold

Codecov Report

Merging #130 (2a5d0bc) into main (6eebe14) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #130   +/-   ##
=======================================
  Coverage   42.90%   42.90%
=======================================
  Files          29       29
  Lines        1508     1508
=======================================
  Hits          647      647
  Misses        785      785
  Partials       76       76

Can you update the title of this PR to something more descriptive?

Applied suggestions from @mjlshen & @tonytheleg, thank you!

Thanks @robotmaxtron !
/lgtm
/approve


Fix parsing doubles on systems with radix char other than '.'

Fixes #45

I merged #66 instead because that looks to be more portable (there are a number of users on Windows platforms).


Grammatical error

Challenge Build a Personal Portfolio Webpage has an issue.
The grammar is a little off, in one of the User Story lines.
Change to:

I can navigate

instead of

I navigate

Thanks @FlameFractal .
First timer issue!
Change this line of code to reflect the suggestion as mentioned above:
https://github.com/FreeCodeCamp/FreeCodeCamp/blob/staging/seed/challenges/01-front-end-development-certification/basic-ziplines.json#L202
Please follow the Guidelines for Contributing.

I can work on this if posible :)

@xtatanx Thanks a lot for your interest but you already have a PR open, let's keep this for first timers. Please look into the open help wanted issues instead.
Thanks once again, and happy fixing!

Ohhh ok sure no problem :) thanks to you guys!


Sealed::DEBUG_STR is publicly accessible

Background: We use v0.14s PageSize::SIZE_AS_DEBUG_STR in the Hermit loader (src/arch/x86_64/paging.rs#L31), which can be easily replaced.
I interpret the discussion in https://github.com/rust-osdev/x86_64/pull/404 so that the intention was to remove Sealed::DEBUG_STR from the public API.
This issue is to inform you that while the Sealed trait is not nameable, you can still use DEBUG_STR when using generics:
use x86_64::structures::paging::{PageSize, Size4KiB};

/// Compiles just fine.
pub fn generic<S: PageSize>() -> &'static str {
    S::DEBUG_STR
}

/// Compiles just fine.
pub fn concrete() -> &'static str {
    generic::<Size4KiB>()
}

/// Does not compile because `Sealed` is not in scope.
pub fn not_generic() -> &'static str {
    Size4KiB::DEBUG_STR
}

I am not sure if this is actually a rustc issue or not.

Thanks for reporting! I definitely see that this is confusing.

I am not sure if this is actually a rustc issue or not.

See https://github.com/rust-lang/rust/issues/67105 and https://github.com/rust-lang/rust/issues/83882. It looks like the is no consensus on what should be the expected behavior yet (forbid access in generic code or allow access in non-generic code too).

I think it should be possible to move the DEBUG_STR constant to a separate, private trait. Looking into it right now.

It kind of works, but it leads to a lot of additional bounds on the new private trait: https://github.com/rust-osdev/x86_64/commit/a5585ef240c553a2a13b19dc34fe864f76a12180 . I don't think that this is an improvement...

I guess the alternative would be to commit to having this part of the public API even though that was not what we wanted in https://github.com/rust-osdev/x86_64/pull/404, right?

Yes, but in that case we should probably redefine the DEBUG_STR constant in the respective child traits. Otherwise it's not included in the docs and only accessible using generics.

https://github.com/rust-osdev/x86_64/blob/a5585ef240c553a2a13b19dc34fe864f76a12180/src/structures/paging/mapper/mod.rs#L113
This makes it impossible for users to add their own generic implements because they can't name DebugOutput, doesn't it?

Yes it does, at least in the current implementation. Maybe it's possible to avoid this somehow, but it's probably not worth the trouble. So exposing DEBUG_STR is probably the better solution.

https://github.com/rust-osdev/x86_64/blob/a5585ef240c553a2a13b19dc34fe864f76a12180/src/structures/paging/mapper/mod.rs#L113
This makes it impossible for users to add their own generic implementations because they can't name DebugOutput, doesn't it?

Isn't that what you meant with https://github.com/rust-osdev/x86_64/pull/404 anyway?

Users should never implement this trait themselves. [...]

https://github.com/rust-osdev/x86_64/blob/a5585ef240c553a2a13b19dc34fe864f76a12180/src/structures/paging/mapper/mod.rs#L113
This makes it impossible for users to add their own generic implementations because they can't name DebugOutput, doesn't it?

Isn't that what you meant with #404 anyway?

Users should never implement this trait themselves. [...]

#404 is meant to prevent users from implementing PageSize on their own types. What I meant with my comment was that with the changes in a5585ef240c553a2a13b19dc34fe864f76a12180, it would be impossible for users to create generic implementations of Mapper<S>.


Issues deploying on live Vercel server

I'm able to install everything with no issues or error in dev, but unable to deploy to vercel.
I'm using Nuxt UI Pro if that helps any.

Can you please provide a minimum reproducible example repo as well as any logs?

Closing this, as no reproduction was provided.


"not charging" battery status

When the battery is not charging (because plugged in and fully charged) there is no output for the battery.
 macchina -d shows
Readout "Battery" failed with message: Got an unexpected value "not charging" reading battery status
which is normal because there is no matching branch for that status in
libmacchina/src/linux/mod.rs -> LinuxBatteryReadout::status
Would be a nice enhancement to have..
but perhaps not possible for all os systems so it was left out intentionally...

I saw this issue, and I had a similar thought about a battery crate a while ago (https://github.com/svartalf/rust-battery/pull/100).
Turns out on linux, the file to read the battery state from will have "not_charging" if the battery is plugged in but not charging.
I think it would be easy for the linux module of libmacchina, since we would only have to add a branch to the match statement for the battery status, but each OS battery status function would need to have a different implementation of the "not charging" status were to show on every supported OS.
i.e it will be a bit tricky on windows:

    fn status(&self) -> Result<BatteryState, ReadoutError> {
        let power_state = WindowsBatteryReadout::get_power_status()?;

        match power_state.ACLineStatus {
            0 => Ok(BatteryState::Discharging),
            1 => Ok(BatteryState::Charging),
            a => Err(ReadoutError::Other(format!(
                "Unexpected value for ac_line_status from win32 api: {a}"
            ))),
        }
    }

...

impl WindowsBatteryReadout {
    fn get_power_status() -> Result<SYSTEM_POWER_STATUS, ReadoutError> {
        let mut power_state = SYSTEM_POWER_STATUS::default();

        if unsafe { GetSystemPowerStatus(&mut power_state) }.as_bool() {
            return Ok(power_state);
        }

        Err(ReadoutError::Other(String::from(
            "Call to GetSystemPowerStatus failed.",
        )))
    }
}

I was thinking we could try reading from the BatteryFlag byte from the SYSTEM_POWER_STATUS struct, along with the ACLineStatus; we can see if its charging with the current code with ACLineStatus, but theoretically we can also check if the battery is plugged in and not charging if ACLineStatus is 1, and check if BatteryFlag is 0 (battery is not charging and is in between high and low capacity). We could also switch ACLineStatus altogether, since BatteryFlag has a charging value we can match against (Windows API for reference https://learn.microsoft.com/en-us/windows/win32/api/winbase/ns-winbase-system_power_status).
I’d love to hear any thoughts or suggestions on this approach, as part of me thinks there is an easier way to do this.


Declarative Shadow Root

See: https://developer.chrome.com/articles/declarative-shadow-dom/
Short explainer: With declarative shadow root HTML components can be server-side rendered.

never mind, sorry


created my own page!

of course I forgot to checkout my own branch but please be forgiving, it's my very first pull request on github!!!

Welcome to github!  I'm glad to be your first interaction on GH, Unfortunately, your file does not follow the rules and cannot be merged just yet:
You are missing your GITHUB URL (https://github.com/nrsalmon) in your HTML file.

Awesome, Thanks!


Call to Action & Accordion: Primary and Tertiary variation

https://taskman.eionet.europa.eu/issues/151844
https://taskman.eionet.europa.eu/issues/151845

@eea-jenkins build storybook

@g-stamatis a lot of pull requests still contain commits from other pull requests. Please again ensure that when a feature is worked upon it's from the develop branch without any changes from other pull requests


StackView: Integration with HTML5 History API

From<EMAIL_ADDRESS>on August 01, 2012 10:46:32
Integrate the StackView with the HTML5 Hisotry API so that users can use their browser's history controls (mainly back and forth) to manipulate their location in the stack view.
Resources: http://www.whatwg.org/specs/web-apps/current-work/multipage/history.htmlhttp://diveintohtml5.info/history.html
Original issue: http://code.google.com/p/foam-framework/issues/detail?id=8

This is handled using the memento system. See eg. foam.memento.MementoMgr and foam.memento.PushStateMementoMgr.


Set host_name_attribute when using _load_databag_config

When using _load_databag_config recipe, host_name_attribute was being set correctly, but not when using _load_default_config. This feature was added in version 7.0.9.

Will close this PR (sorry) because I'm about to release version 7.1.0 which also contains this fix.


Require tests in %%versioned_binable modules

The linter already enforces that the first argument to Of_binableN functors is a stable-versioned module.
But the serialization of a type could also change if the second argument with to_binable and of_binable functions changes. The script to detect changes is not enough -- the second argument could pull in a new definition of to_binable, say, while the text does not change.
So %%versioned_binable should require a Tests submodule, just as %%versioned_asserted does.

That said, almost every stable-versioned type is vulnerable to a changed-semantics-of-stable-text change.
If we have a type definition:
type t = Foo.Stable.V1.t

the module named Foo could change over time. We don't require serialization tests in this case (it would be too much trouble to do for each type definition).
So the CI scripts that detect changes to stable-versioned types would not detect such a change. Maybe we just live with the possibility that the second argument to Of_binable functors could also change, and hope that developers know they should not change such argument.


Can I switch back from Preview Channel and get previous version VS4Mac?

If I switch back to stable will I get previous version of VS4Mac
[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b8f3608c-d434-e892-85db-032af35f919b
Version Independent ID: d546284e-5cd8-6a41-790b-5302b628d357
Content: Updating Visual Studio for Mac - Visual Studio 2019 for Mac
Content Source: mac/update.md
Product: visual-studio-mac
Technology: vs-ide-install
GitHub Login: @asb3993
Microsoft Alias: amburns

Thanks for your question. It looks like you're working through an issue with your scenario or implementation, rather than an issue with the documentation. Here are a couple of options where you might consider asking your question:

Azure DevOps on Stack Overflow
Azure DevOps Support Bot


chore(deps): upgrade jenkins-x/jx3-pipeline-catalog to version 3.10.160

from: https://github.com/jenkins-x/jx

/retest


Submissions for 2021 not working- says needs to comply with 2020 guidelines

Information

OS & version:  Windows 10
Docker version: Docker version 19.03.8, build afacb8b

Expected behavior
Trying to use it with test files for 2021 and it appears to be expecting 2020, according to the error we're getting
Actual behavior
Error message when submitting with a 2021 formatted file:
"The file is not a QRDA-III XML document. Please ensure that the submission complies with the 2020 implementation guide. https://ecqi.healthit.gov/sites/default/files/2020-CMS-QRDA-III-Eligible-Clinicians-and-EP-IG-v1.1-508.pdf#page=19"
Steps to reproduce
Submit file for 2021
Other details
Wondering if it's yet been updated for 2021 and if not, what might be the ETA?

Hi @kdd21
Conversion of 2021 QRDA-III files has not been updated yet. An ETA will most likely be around August or September before we get public releases out.


Migration

Full migration framework has been put in place.
Migration from schema version 4 and forward is supported.

Needs PR #83 before it can be merged


Adds the gtfsio R package to the "GTFS Libraries" section

Adds the gtfsio R package to the "GTFS Libraries" section

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thanks for this contribution @rafapereirabr!


[Snyk] Security upgrade zipp from 3.15.0 to 3.19.1

This PR was automatically created by Snyk using the credentials of a real user.![snyk-top-banner](https://github.com/andygongea/OWASP-Benchmark/assets/818805/c518c423-16fe-447e-b67f-ad5a49b5d123)
Snyk has created this PR to fix 1 vulnerabilities in the pip dependencies of this project.
Snyk changed the following file(s):

requirements-dev.txt

⚠ Warning
```
flake8 5.0.4 has requirement pycodestyle<2.10.0,>=2.9.0, but you have pycodestyle 2.10.0.
</details>

---

> [!IMPORTANT]
>
> - Check the changes in this PR to ensure they won't cause issues with your project.
> - Max score is 1000. Note that the real score may have changed since the PR was raised.
> - This PR was automatically created by Snyk using the credentials of a real user.
> - Some vulnerabilities couldn't be fully fixed and so Snyk will still find them when the project is tested again. This may be because the vulnerability existed within more than one direct dependency, but not all of the affected dependencies could be upgraded.

---

**Note:** _You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs._

For more information: <img src="https://api.segment.io/v1/pixel/track?data=eyJ3cml0ZUtleSI6InJyWmxZcEdHY2RyTHZsb0lYd0dUcVg4WkFRTnNCOUEwIiwiYW5vbnltb3VzSWQiOiIxZGMxY2YzZC0xNzJlLTQ1ZTQtODJmMy0wYWU1NDliZjk4MjciLCJldmVudCI6IlBSIHZpZXdlZCIsInByb3BlcnRpZXMiOnsicHJJZCI6IjFkYzFjZjNkLTE3MmUtNDVlNC04MmYzLTBhZTU0OWJmOTgyNyJ9fQ==" width="0" height="0"/>
🧐 [View latest project report](https://app.snyk.io/org/broker/project/251adca4-d78b-48d2-a9dc-a51ffa7fd1ab?utm_source=github&utm_medium=referral&page=fix-pr)
📜 [Customise PR templates](https://docs.snyk.io/scan-using-snyk/pull-requests/snyk-fix-pull-or-merge-requests/customize-pr-templates)
🛠 [Adjust project settings](https://app.snyk.io/org/broker/project/251adca4-d78b-48d2-a9dc-a51ffa7fd1ab?utm_source=github&utm_medium=referral&page=fix-pr/settings)
📚 [Read about Snyk's upgrade logic](https://support.snyk.io/hc/en-us/articles/360003891078-Snyk-patches-to-fix-vulnerabilities)

---

**Learn how to fix vulnerabilities with free interactive lessons:**

🦉 [Learn about vulnerability in an interactive lesson of Snyk Learn.](https://learn.snyk.io/?loc=fix-pr)

[//]: # 'snyk:metadata:{"customTemplate":{"variablesUsed":[],"fieldsUsed":[]},"dependencies":[{"name":"zipp","from":"3.15.0","to":"3.19.1"}],"env":"prod","issuesToFix":[{"exploit_maturity":"Proof of Concept","id":"SNYK-PYTHON-ZIPP-7430899","priority_score":141,"priority_score_factors":[{"name":"confidentiality","value":"none"},{"name":"integrity","value":"none"},{"name":"availability","value":"high"},{"name":"scope","value":"unchanged"},{"name":"exploitCodeMaturity","value":"proofOfConcept"},{"name":"userInteraction","value":"none"},{"name":"privilegesRequired","value":"none"},{"name":"attackComplexity","value":"low"},{"name":"attackVector","value":"local"},{"name":"epss","value":0.01055},{"name":"isTrending","value":false},{"name":"publicationDate","value":"Tue Jul 09 2024 09:06:36 GMT+0000 (Coordinated Universal Time)"},{"name":"isReachable","value":false},{"name":"isTransitive","value":true},{"name":"isMalicious","value":false},{"name":"businessCriticality","value":"high"},{"name":"relativeImportance","value":"medium"},{"name":"relativePopularityRank","value":99},{"name":"impact","value":5.99},{"name":"likelihood","value":2.35},{"name":"scoreVersion","value":"V5"}],"severity":"medium","title":"Infinite loop"}],"prId":"1dc1cf3d-172e-45e4-82f3-0ae549bf9827","prPublicId":"1dc1cf3d-172e-45e4-82f3-0ae549bf9827","packageManager":"pip","priorityScoreList":[141],"projectPublicId":"251adca4-d78b-48d2-a9dc-a51ffa7fd1ab","projectUrl":"https://app.snyk.io/org/broker/project/251adca4-d78b-48d2-a9dc-a51ffa7fd1ab?utm_source=github&utm_medium=referral&page=fix-pr","prType":"fix","templateFieldSources":{"branchName":"default","commitMessage":"default","description":"default","title":"default"},"templateVariants":["updated-fix-title","pr-warning-shown","priorityScore"],"type":"auto","upgrade":[],"vulns":["SNYK-PYTHON-ZIPP-7430899"],"patch":[],"isBreakingChange":false,"remediationStrategy":"vuln"}'

🎉 Snyk hasn't found any issues so far.
✅ code/snyk check is completed. No issues were found. (View Details)


TypeError("'NoneType' object is not callable")

Since yesterday, my documentation has been broken with the following error:
writing output... [ 14%] api/modules
Theme error:
An error happened in rendering the page api/modules.
Reason: TypeError("'NoneType' object is not callable")
make: *** [html] Error 2

It's in the templated API page, but that used to work and works in RtD's theme. Forcing the version to 0.0.30 solves the issue. It's in boost-histogram.readthedocs.io / GitHub.com/scikit-hep/boost-histogram.

(PS: This looks like an error that MyPy would catch. ;) )

hmmmm - that's a bummer :-/ sorry it regressed for you! Did you happen to figure out what was going on here? I'll mark it as a bug

Not yet, but haven't had time to investigate properly.

This may have been fixed, can you upgrade and try again?

Seems to be fixed, thanks!

hooray! :-)


[NFR] some really usefull methods

(I am not sure if the current version has any stuff to the following methods or not)
Adding the following methods can empower Phinx even more:
$tables=$this->getTables();
foreach($tables as $table){
   $table->dump('/backups/myDb/'.$table->getName.'.sql');
   $table->changeEngine('innodb')->convertCharset('utlf8_general_ci')->resetAutoIncrement();
}

Phinx won't do data exporting, other tools are better suited for this.
I will support the utility methods if I see more support from the community

Hey Rob, I agree with @salarmehr that these could be quite helpful.  I'm thinking of a situation where you might want to back up a table to specified location (e.g. file, S3) in your up() function, and restore the table from that backup file in your down() function.
We are currently looking into using Phinx in our project and having this functionality would be quite helpful.


Enable the ability to search for Laboratories

Ticket created by @richardchenca :

It looks like search-core does nothing with laboratory context products. If deliberate, that's fine. If overlooked, I suggest we make those searchable, but feel free to talk me out of it.
Proof: I just ingested, with other context products, into pds-gamma:
urn:nasa:pds:context:facility:laboratory.sbu_cpex
urn:nasa:pds:context:instrument:sbu_cpex.ftir
urn:nasa:pds:context:instrument:sbu_cpex.raman
then ran search-core. I can find the two instruments, but I can't find the laboratory. Also, the data collections that lid_reference those three return links to the instrument but not the laboratory, e.g.
https://pds-gamma.jpl.nasa.gov/ds-view/pds/viewCollection.jsp?identifier=urn%3Anasa%3Apds%3Alab_shocked_feldspars%3Adocument&version=1.0

This may require an update to both Harvest and Registry. Not sure where the issue lies.

Moving to Backlog because this should be captured by search overhaul. will keep as an issue so we are sure to have this possible.


Feat/improved path params

Description

Contribution Checklist:

[x] The pull request only addresses one issue or adds one feature.
[x] The pull request does not introduce any breaking changes
[ ] I have added screenshots or gifs to help explain the change if applicable.
[x] I have read the contribution guidelines.
[x] Create an issue and link to the pull request.

Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.
Publishing to New Package Managers
Please see here for more information.

Thanks for the work on this one!
I just wanted to note that this seems to prevent older versions of Bruno from being able to see or open requests that use the new params:query notation. The request files don't appear in the sidebar at all. It would be nice if Bruno could still show the file exists, but then give an error that it's not parseable. (I was using Bruno v1.18.0 and tried to use requests shared from someone who created them in v1.28.0 using params:query.


Warnings with Bluebird

If I use Bluebird as Promise implementation I get the following warning on every rejected request:
Warning: a promise was rejected with a non-error: [object Object]
    at settle (eval at <anonymous> (http://localhost:8080/app.js:2925:2), <anonymous>:16:5)
From previous event:
    at dispatchRequest (eval at <anonymous> (http://localhost:8080/app.js:2883:2), <anonymous>:11:10)

What version of axios are you using?

@mzabriskie 0.12.0

Okay, I see. This is fixed by #345.
Thanks!

@levrik How you integrate Bluebird to Axios ? Need help plz!

@zmts Just looked into my code and found this:
import Promise from 'bluebird';

// overwrite native Promise implementation with Bluebird's (for axios)
window.Promise = Promise;


Cell overlay for RowID cell is not functional

The cell overlay for the RowID can be activated, but it will not contain any content. The reason is that it does not currently implement the getEditor property: https://github.com/glideapps/glide-data-grid/blob/47bae1e604add604e49ee34a8dc4bfbc18b6bd4f/packages/core/src/data-grid/cells/row-id-cell.tsx
A fix would be to either change the allowOveraly to always be false like it is done with BooleanCell or to provide a (read-only) editor implementation for the RowIDCell  as well (based on the text cell editor). I would prefer that the RowID cell also has a cell overlay, it's probably debatable if it needs actual editing support or if read-only would be enough for most use cases.

Should be easy enough to give it a full editor. Maybe default it to read only?

Yep, I think full editor with read-only default would be the most flexible solution 👍

Fixed


Version 3.x

The current readme for this repo references cordova-plugin-ionic-webview version 3.x, and even has steps on how to migrate to 3.x.
However the latest version I see in npm is 2.3.1, and the documentation on npm is different (it has steps on migrating to 2.x).
Could someone please clarify if there is a 3.x version, and if so can it be published to npm with appropriate documentation?

Sorry about that, we use master as the development branch and we didn't want to release the major version during Christmas.
It's published now.


希望支持qwen1.5-32B(awq\gptq)

Is your feature request related to a problem? Please describe
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

Addressed by #1249 , will be included in the v0.10.1


Update Composer dependencies (2020-11-06-00-14)

Visual regression test passed!
View the visual regression test report


Fix IllegalStateException thrown when creating build operations with included builds

Context

Contributor Checklist

[ ] Review Contribution Guidelines
[ ] Sign Gradle CLA
[ ] Check "Allow edit from maintainers" option in pull request so that additional changes can be pushed by Gradle team
[ ] Provide integration tests (under <subproject>/src/integTest) to verify changes from a user perspective
[ ] Provide unit tests (under <subproject>/src/test) to verify logic
[ ] Update User Guide, DSL Reference, and Javadoc for public-facing changes
[ ] Ensure that tests pass locally: ./gradlew <changed-subproject>:check

Gradle Core Team Checklist

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation
[ ] Recognize contributor in release notes

@jjohannes @eljobe could you guys take a look at this and see if it looks reasonable?
I tried creating the same kind of failure by using our BuildOperationsFixture, but I couldn't cause a failure.

@jjohannes you can hold off looking at this.  I have another approach that doesn't allow the build name to change while executing.

We're not going to finish this soon.


[eslint-plugin-lit-a11y]: implement label-has-associated-control

See: https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/master/docs/rules/label-has-associated-control.md
label-has-associated-control
Enforce that a label tag has a text label and an associated control.
There are two supported ways to associate a label with a control:

Wrapping a control in a label tag.
Adding the for attribute to a label and assigning it a DOM ID that indicates an input within scope of the label.

This rule checks that any label tag (or an indicated custom element that implements label internally) either

wraps an input element or

has a for attribute and that the label tag has text content.

Rule details
This rule takes one optional object argument of type object:
{
  "rules": {
    "lit-a11y/label-has-associated-control": ["error", {
      "labelCustomElements": [
        "custom-label",
        {
          "tagName": "slotted-label",
          "slot": ["input"]
        }
      ],
    }],
  }
}

labelCustomElements is a list of custom elements that should be considered labels. If a string is provided, it's assumed that the control is slotted in the anonymous slot. If an object is provided, the control must be slotted into one of the indicated slots.
Fail
html`

  <input type="text" />
  Surname
`;

Succeed
html`

  <input id="foo"/>

    <input type="text" />
    Surname

`;
}

Accessibility guidelines

WCAG 1.3.1
WCAG 3.3.2
WCAG 4.1.2

For this one, we should well-clarify the relationships across shadow boundaries


feat(example): Error Page

Related issue
Closes #757
Scope of work
Created Error page example
Checklist

[x] No commented blocks of code left
[x] Run tests and docs
[x] Self code-reviewed

If applicable:

[x] I followed composition rules for my component
[x] I tested the component in most common device sizes (can be tested in Storybook from viewport addon in top menu)

You can move icons svgs to icons.js

@pspaczek updated :)

thanks @martaradziszewska


The Grand 2.0 Todo List

Bucket Types
Continuation of issue #175

[X] Add buckets to RiakObjectId
[x] Add Integration Tests for Bucket Types

Data Types
Continuation of issue #166
Data Types

[x] Counter
[x] Set
[x] Maps
[x] Integration Tests

Bucket Types

[*] Assign a CRDT to a bucket/bucket type Command line only
[x] Integration Tests

Security
Nothing done, all todo.
See https://github.com/basho/riak-java-client/commit/00e7748e202eb95ac108d3ccf7ad92f53688c909 for Java details.

[x] :allthethings:

Yokozuna Support
Recommending users use the Solr.Net library for real usage.
:bulb: Could (in the future) have a CorrugatedIron.Search package that's external that pulls in that library, and autoconfigures connections based on your config file settings.

[x] Add Yokozuna administrative functions / interface.
[x] Simple Search (pass simple query via PB)

MapReduce

[x] Fix parameters to include namespaces/bucket types

Strong Consistency

[x] Add property to bucket to query if it's a strongly consistent bucket or not.

Cleanup / Tech Debt

[x] Mark any (bucket, key) interfaces in the system as [Obsolete], offer replacement with (RiakObjectId) instead. RiakObjectId
[x] Obsolete any HTTP interfaces / support. (Hard delete in 2.0, or warn and delete in 2.1?)
[*] Fix Async. **Moved to #248 **
[*] Fix any unit/integration tests that are deferred or non-deterministic **Moved to #248 **
[x] Streaming 2i Queries - Test / Implement?

All major items done. See #249 for remaining small tasks, and #248 for post-2.0 cleanup.


inspector of template transformation result to reveal whole transformation chain up to data source

Problem
XSLT has been banished from development community due to lack of discoverability during development process. The best what XML stack offered was done on XSLT debugger level:

a breakpoint on particular node in data source
a breakpoint and step-by-step execution
transformation rules stack and scope variables inspection

To make things worse, the XSLT transformation debugger is not available in browser.. What SaxonJS and Altova been thinking about? 😛
While those debugging capabilities are essential to code execution troubleshooting, those are not giving the live check capabilities Web developers used to: the easiness of element inspection and exploration of its properties. With shadow DOM slots it goes even further and given ability to drill into the slot source. When introducing more complex transformations, it would be essential to give same ability to drill over transformation phases up to the data source. Otherwise web development community would seek straight way of debugging the UI, most likely in JS world.

implementation notes
Whether it is a injectable into page utility ( sample ), or dev tools as browser plugin, or eventually in native browser, the underlying implementation would do the same.

Interrupt the transform routine
process the input XML and inject the attribute which would allow to identify the source ( like full XPath )
process the transformation to inject the current XSLT transformation rule location into output DOM.
To insulate the debug data it would be under own XML namespace.
since debug data are verbose, those have to be hidden in DOM inspector by default with ability to enable visibility.

The drilling through transformations would began from the result of latest which is a DOM node in browser. The input data and transformation rule reflect the call stack level. Each level would have a reference to the previous one. Traversing over transformation stack would switch the data and transformation view to current scope.
Since data DOM and transformation in inspector always would go in pairs, the default layout  would comprise 3 view

transformation stack
data panel with data hierarchy and current pointer in it, tabs for different data sources.
transformation panel with current template(XSLT) and tabs of loaded templates

Just thinking aloud... the feature complete dev tool is quite long to make. What is MVP?

Enable debugging (and discoverability) by exposing the data and template

as "copy XML+ XSLT combo " menu item
copy data(XML, JSON)
copy template
jump to custom element declaration( DCE only ), not sure about declaration in JS

preview data and template , hover/focus on the "transformation" badge
Ability to change the template and data inline. The template is a usual DOM in DCE and modifying this DOM can trigger instances re-render.
? enable debugger breakpoints and step-through. Does SaxonJS have a debug API?

The drill from UI element down to data is out of MVP but would make a next generation of dev tools.

Created browser plugin for data (XML) and template(XSLT) inspection in Chrome devtools
https://github.com/EPA-WG/custom-element-chrome-plugin


Fix for: Issue-36 Toast values are not getting encrypt...

Toast values are inserted into toast relations directly by the core, so the trick is sending the encrypted data to the core before it gets externalized. Similarly, when creating the tuple with toasted value, decrypt the toated chunks before constructing the resulting tuple.

Syncing my fork automatically closed the PR. New PR for same issue can be found at
https://github.com/Percona-Lab/postgres-tde-ext/pull/48


PR #8839 revealed the cause of the Istio test failing; re-enable the test
accordingly by reverting the commit which disabled it.
Signed-off by: Ian Vernon<EMAIL_ADDRESS>Waiting to merge this until the actual fix is merged to master.

This change is

Coverage increased (+0.02%) to 44.208% when pulling 4d7df9b616c123e47aa2c31ea0dbc5e93eba36f7 on pr/ianvernon/re-enable-istio-test into 97fdb19412a32bf54a43c685e171b733b0f81c9d on master.

test-me-please


Change arguments in fn attr from ToString to Into

[x] Implementation
[x] Update contracts
[x] CHANGELOG entry
[x] MIGRATING entry

Hi, @webmaster128. I have a question. I feel using ToString is more useful. Why this change is needed or what is the incentive of this PR?

@loloicci ToString always created a clone of the input to a new string. Using Into<String> only creates a clone if you don't input a String if your give it a &str or something similar. If you pass in an owned String, no clone is created.

@webmaster128 Oh, performance reason. I did not know that. Thank you!


SQLSTATE [42S02]: Base table or view not found: 1146 Table '.watches' doesn't exist

Describe the Bug
Bug appeared after updating from 23.06.2 to 23.08.2.  The error happens after an edit is saved and only appears once for each document that is edited.
Steps to Reproduce

Within Bookstack webpage, open a previously created page
Edit the page, and then save.  You don't need to make any changes at all
Then the error displays
Refresh the page and the change is saved and updated.
Edit the same page again and the error does not appear.

Expected Behaviour
After an edit is made the page is saved and then displayed.
Screenshots or Additional Context

Browser Details
No response
Exact BookStack Version
v23.08.2

Hi @jameskeel,
Did you run the php artisan migrate step during upgrade to this version, and if so did you see any errors?
What is the output if you re-run that update step command?

Thank you @ssddanbrown for the speedy reply.  I don't recall any errors but I'll run it again after hours tonight and keep you posted.

Good to hear that solved it! Will therefore close this off.


[grunt-build-release] Fix permissions extracting downloaded ZIP

Running cd build & grunt build-release-download results in an extracted folders readable only by root.
Let's fix this

It seems that on some OS the empty folders are not created...
I think that we should use the unzip instead of letting Download extract the archive...


Fails to compile w/ color 0.0.7

The JSON files specifies ~>0.0.5 for the color package. This causes compilation to fail with color 0.0.7 as follows:
../../../.dub/packages/color-0.0.7/color/std/experimental/color/package.d:534:19: error: @nogc function 'std.experimental.color.colorFromStringImpl
' cannot call non-@nogc function 'std.experimental.color.colorFromStringImpl.streqi'
         if (streqi(str, k))
                   ^

Modifying the JSON to ==0.0.5 allows ggplotd to compile.

Sorry, realized this appears to be an issue with my installed toolchain not ggplotd.

Last time I tried the color package didn't work on its own. That was why I pulled it into ggplotd. Does it work on its own nowadays?


Crash when selecting menu command using keyboard

Hello,
I get a crash when selecting a menu item using the keyboard. The debugger shows the problem in
menu_drawer::send_shortkey(). The menu_->owner variable of the menu_type is not initialized.
If i select the menu item using the mouse everything works fine.
Nana C++ version 1.5.4 with Visual Studio 2017.

Thank you for reporting this issue, I will check it.

Thank you for your fast reply. To be more specific the menu_ member variable is not initialized.
menu.cpp (line 630):
...
else if (item_ptr->flags.enabled)
   fn_close_tree_();
   if (item_ptr->event_handler)
   {
       item_proxy ip{ index, menu_->owner };
       item_ptr->event_handler.operator()(ip);
    }
    return 1;
}

...

Fixed, Thank you for the information!


Update database for int and EC channels

This PR is for several internacional channels (from Wikipedia). Also add new channels from Ecuador.

Great job!


msgpack: Improve perf

Following the #1, #6
The final condition for this package to be adopted is probably the performance.
It already has an advantage in terms of bundle size and compatibility, but we don't want to leave performance as an area of trade-off

I'm going to try Rewriting in ReScript for the Encoder as well, as I've seen the improvements from #6.
I can provide settings for ReScript if anyone wants.


Check.Hash should have Adds for all public properties etc

Will be explicit in terms of what it's checking like all public properties recursive.
This will make it more robust compared to FluentAssertions BeEquivalentTo which can sometimes return true when there are differences and more powerful than Verify as it doesn't need to commit any files.

I almost fell in to the reflection trap. It would be a nightmare of corner cases (e.g. collections) as seen in FluentAssertions and Verify.
Much better to just check the field count in the regression for each type. Then the tests needing to be updated will fail when the fields change.
public static class RegressionExtensions
{
    public static void Add(this IRegression h, BusinessObject o)
    {
        h.Add(o.Id);
        h.Add(o.Name);
        h.Add(o.StartDate);
        h.Add(o.EndDate);
        h.Add(o.Total);
        CheckFieldCount(o, 5);
    }

    static void CheckFieldCount(object o, int expected)
    {
        var fields = o.GetType().GetFields(AllInstanceFields);
        if(fields.Length != expected)
            throw new Exception($"{o.GetType().Name} has {fields.Length} fields not {expected}");
    }

    readonly static BindingFlags AllInstanceFields = BindingFlags.Instance | BindingFlags.Public | BindingFlags.NonPublic;
}


Add World Bank as new agency

The World Bank "World Integrated Trade Solution" is available vis SDMX. The user guide is available here: http://wits.worldbank.org/data/public/WITSAPI_UserGuide.pdf. The following block seems to work.
        'WBG_WITS': {             'name': 'WBG_WITS',             'url': 'http://wits.worldbank.org/API/V1/SDMX/V21/rest',             'resources': {                 'data': {                     'headers': {},                 },             }         },

Thanks. Have you been able to make a request? Please note that in the
dev Version on github you can not pass a json string to a method of
Request class, I believe it is named add_agency or something. So you
can add the WITS agency manually and make all Kinds of requests.
I would be very happy to add the agency if it works.
It appears that other data offerings of WB have an SDMX API as well.
But docs are poor, eg. which SDMX Version is unclear.
Thanks again!
Leo
On 05/06/2017, David Bailey<EMAIL_ADDRESS>wrote:

The World Bank "World Integrated Trade Solution" is available vis SDMX. The
user guide is available here:
http://wits.worldbank.org/data/public/WITSAPI_UserGuide.pdf. The following
block seems to work.
        'WITS': {             'name': 'WITS',             'url': 'http://wits.worldbank.org/API/V1/SDMX/V21/rest',             'resources': {                 'data': {                     'headers': {},                 },             }         },
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/dr-leo/pandaSDMX/issues/52

Hey Leo,
Yes, it works well. I've simply added the above config to my local api.py file. I'm running pandaSDMX 0.6.1 installed via pip so I'm a little behind what is here on GitHub. Below is an example based on your documentation. The API documentation is at http://wits.worldbank.org/data/public/WITSAPI_UserGuide.pdf.
Thanks,
David
wits = Request('WBG_WITS')
cat_response = wits.categoryscheme()
dsd_id = cat_response.dataflow['DF_WITS_TradeStats_Trade'].structure.id
dsd_response = wits.datastructure(resource_id = dsd_id)
dsd = dsd_response.datastructure[dsd_id]
dsd.dimensions.aslist()

data_response = wits.data(resource_id = 'DF_WITS_TradeStats_Trade', key = {'FREQ': 'A', 'REPORTER': 'DEU', 'PARTNER': 'USA', 'PRODUCTCODE': 'Fuels', 'INDICATOR': 'XPRT-TRD-VL'}, params = {})

Hi David,
thanks. Looks awesome. It will go into v0.7 to be relased in a few days

hopefully.

Leo
Am 09.06.2017 um 11:40 schrieb David Bailey:

Hey Leo,
Yes, it works well. I've simply added the above config to my local
api.py file. I'm running pandaSDMX 0.6.1 installed via pip so I'm a
little behind what is here on GitHub. Below is an example based on
your documentation. The API documentation is at
http://wits.worldbank.org/data/public/WITSAPI_UserGuide.pdf.
Thanks,
David
|wits = Request('WBG_WITS') cat_response = wits.categoryscheme() dsd_id
= cat_response.dataflow['DF_WITS_TradeStats_Trade'].structure.id
dsd_response = wits.datastructure(resource_id = dsd_id) dsd =
dsd_response.datastructure[dsd_id] dsd.dimensions.aslist()
data_response = wits.data(resource_id = 'DF_WITS_TradeStats_Trade',
key = {'FREQ': 'A', 'REPORTER': 'DEU', 'PARTNER': 'USA',
'PRODUCTCODE': 'Fuels', 'INDICATOR': 'XPRT-TRD-VL'}, params = {}) |
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/dr-leo/pandaSDMX/issues/52#issuecomment-307344827,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADA58uBll-huNY7QruxrOhIxnbYs1_aMks5sCRMogaJpZM4Nvsj7.

btw: You don't need to query the category-scheme. You need the dataflows
so you con do:

flows_resp = wits.dataflow()

Then select the dataflow you want, extract the DSD ID etc.
The docs may be a bit misleading.
Am 09.06.2017 um 11:40 schrieb David Bailey:

Hey Leo,
Yes, it works well. I've simply added the above config to my local
api.py file. I'm running pandaSDMX 0.6.1 installed via pip so I'm a
little behind what is here on GitHub. Below is an example based on
your documentation. The API documentation is at
http://wits.worldbank.org/data/public/WITSAPI_UserGuide.pdf.
Thanks,
David
|wits = Request('WBG_WITS') cat_response = wits.categoryscheme() dsd_id
= cat_response.dataflow['DF_WITS_TradeStats_Trade'].structure.id
dsd_response = wits.datastructure(resource_id = dsd_id) dsd =
dsd_response.datastructure[dsd_id] dsd.dimensions.aslist()
data_response = wits.data(resource_id = 'DF_WITS_TradeStats_Trade',
key = {'FREQ': 'A', 'REPORTER': 'DEU', 'PARTNER': 'USA',
'PRODUCTCODE': 'Fuels', 'INDICATOR': 'XPRT-TRD-VL'}, params = {}) |
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/dr-leo/pandaSDMX/issues/52#issuecomment-307344827,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADA58uBll-huNY7QruxrOhIxnbYs1_aMks5sCRMogaJpZM4Nvsj7.


Fix mounting of multiple ember apps in Rails' routes

Because mount_ember_app :frontend, to: "/" catches everything, mount_ember_app :admin_panel, to: "/admin_panel" would be never reached if specified below the frontend route.

Thanks!


PHP Notice:  "Trying to access array offset on value of type int" in Zend/Locale/Format.php

On PHP version 7.4.15
Using shardj/zf1-future version 1.19.0 (latest at this time)
The exact error message is:
PHP Notice:  Trying to access array offset on value of type int in /home/vagrant//vendor/shardj/zf1-future/library/Zend/Locale/Format.php on line 527
The line of code that breaks in shardj/zf1-future/library/Zend/Locale/Format.php is:
if (!empty($input) && ($input[0] == $symbols['decimal'])) {
where $input is an integer.
Any help you can provide is very much appreciated.  If you can repro or have reports of a similar/same issue and decide to fix, please advise, and I'll help if I can.

$input should be a string

@Shardj here's an actual full call stack for the error:
[24-Feb-2021 14:43:19 America/New_York] PHP Notice: Trying to access array offset on value of type int in /home/vagrant/someapp/vendor/shardj/zf1-future/library/Zend/Locale/Format.php on line 527
PHP Stack trace:
PHP  1. {main}() /index.php:0
PHP  2. Zend_Application->run() /home/vagrant/someapp/public/index.php:96
PHP  3. Zend_Application_Bootstrap_Bootstrap->run() /home/vagrant/someapp/vendor/shardj/zf1-future/library/Zend/Application.php:384
PHP  4. Zend_Controller_Front->dispatch() /home/vagrant/someapp/vendor/shardj/zf1-future/library/Zend/Application/Bootstrap/Bootstrap.php:105
PHP  5. Zend_Controller_Dispatcher_Standard->dispatch() /home/vagrant/someapp/vendor/shardj/zf1-future/library/Zend/Controller/Front.php:954
PHP  6. Zend_Controller_Action->dispatch() /home/vagrant/someapp/vendor/shardj/zf1-future/library/Zend/Controller/Dispatcher/Standard.php:308
PHP  7. OurController->postAction() /home/vagrant/someapp/vendor/shardj/zf1-future/library/Zend/Controller/Action.php:516
PHP  8. Our_Validate_Model->isValid() /home/vagrant/someapp/application/modules/api/controllers/OurController.php:433
PHP  9. Our_Validate_Model->isValidElements() /home/vagrant/someapp/library/Our/Validate/Model.php:111
PHP 10. Zend_Form_Element->isValid() /home/vagrant/someapp/library/Our/Validate/Model.php:495
PHP 11. Our_Validate_Chain->isValid() /home/vagrant/someapp/vendor/shardj/zf1-future/library/Zend/Form/Element.php:1448
PHP 12. Zend_Validate_Float->isValid() /home/vagrant/someapp/library/Our/Validate/Chain.php:26
PHP 13. Zend_Locale_Format::isFloat() /home/vagrant/someapp/vendor/shardj/zf1-future/library/Zend/Validate/Float.php:124
PHP 14. Zend_Locale_Format::isNumber() /home/vagrant/someapp/vendor/shardj/zf1-future/library/Zend/Locale/Format.php:679
[24-Feb-2021 14:43:19 America/New_York] PHP Notice: Trying to access array offset on value of type int in /home/vagrant/someapp/vendor/shardj/zf1-future/library/Zend/Locale/Format.php
(I've replaced a few folder names just to obfuscate the proprietary info.)
As you can see, our code has a custom validator at Our/Validate/Chain.php which calls back into Zend_Validate_Float->isValid(), which calls the functions inside Zend_Locale_Format, where the error occurs.  Here's the final call from our code into zf1-future:

Thanks for your reply

Looks like whoever wrote Float.php didn't pay much attention to ints. I've committed a fix and I'll make a minor release

Thank you @Shardj

Thanks for this fix, but Just a follow-up that this is now causing issue for us. Previously an integer value was valid, but now it's invalid, so an API breakage.
The Float validator previous accepted and int value happily as being a subset of floats. Now this change is in place '1' is a valid float but (int)'1' isn't which seems wrong.
Wouldn't a better fix be to either, 1) accept an int, or 2) cast the int to a string and go through the locale validation (although the second option seems redundant.

FYI, this is a change in PHP7.4: https://wiki.php.net/rfc/notice-for-non-valid-array-container,
I'll write a new pull request shortly with the correct behaviour.


v2 reproducibility issue with asset hash file names

Describe the bug
When constructing a static bundle using SvelteKit version 2, the process results in the creation of assets with filenames that are not reproducible. Each build iteration leads to the generation of new filenames, distinguished by their unique hashes.
Additionally, attempts to define a custom file naming strategy through Rollup's output-assetfilenames configuration seem to be ineffective, as they do not produce the expected results.
Reproduction
git clone https://github.com/peterpeterparker/my-app-hash
cd my-app-hash
npm ci
npm run build
// observe hash. e.g. build/_app/immutable/chunks/stores.GflRvHvF.js
npm run build
// observe new hash. e.g. build/_app/immutable/chunks/stores.nX1Zqub0.js
Excpectation
Build should be reproducible and without any changes, should lead to always generate the same file names' hashes.
Furthermore, supporting Rollup option should allow developer to provide their own file name strategy.
Logs
No response
System Info
❯ npx envinfo --system --binaries --browsers --npmPackages "{svelte,@sveltejs/*,vite}"

  System:
    OS: macOS 14.1.1
    CPU: (8) arm64 Apple M2
    Memory: 2.08 GB / 16.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 18.16.0 - /usr/local/bin/node
    Yarn: 1.22.19 - /opt/homebrew/bin/yarn
    npm: 9.6.1 - /opt/homebrew/bin/npm
  Browsers:
    Brave Browser: <IP_ADDRESS>
    Chrome: 120.0.6099.109
    Firefox: 121.0
    Safari: 17.1
  npmPackages:
    @sveltejs/adapter-static: ^3.0.1 => 3.0.1
    @sveltejs/kit: ^2.0.6 => 2.0.6
    @sveltejs/vite-plugin-svelte: ^3.0.1 => 3.0.1
    svelte: ^4.2.8 => 4.2.8
    vite: ^5.0.10 => 5.0.10

Severity
blocking an upgrade
Additional Information
No response

This seems unlikely to be an issue in SvelteKit, but rather with Vite, so would probably be better reported there. See https://github.com/sveltejs/kit?tab=readme-ov-file#bug-reporting for more details

Vite 👉 https://github.com/vitejs/vite/issues/15555


undefined is not an object(evaluating 'RNFetchBlob.DocumentDir')

Installed react-native-fetch-blob version 0.10.8. And my react native version is 0.55.4. Receive the error
"undefined is not an object(evaluating 'RNFetchBlob.DocumentDir')" when i require RNFetchBlob in my component . Have followed the instructions . Using manual linking and also using react-native link but still receive the error. I'm trying this on my android phone using react-native run-android in development . Need help urgently

I have the same issue. Please look into it

@Spursh  I fix it , just follow the linking instructions , either manual or using react-native link. You have to make sure the app is actually recompiling


Do not show privacy notice question in check answers page

This means if the answer is no they just see a blank Check Answers page? Is that expected here?

This means if the answer is no they just see a blank Check Answers page? Is that expected here?

ooh, that's a good point, @paulrobertlloyd, what do you think?

I think we ignore this ticket for now and close this PR – where the privacy notice appears is something we’re looking at again in design.


[WIP] ETH/ERC20 Support

This is still a WIP. It's mostly done on our end but currently blocked by a few issues in marketmaker before we can merge:
~~https://github.com/artemii235/SuperNET/issues/56~~ Resolved
~~https://github.com/artemii235/SuperNET/issues/57~~ Resolved
These issues are related but don't need to block our work:
https://github.com/artemii235/SuperNET/issues/58
https://github.com/artemii235/SuperNET/issues/59

Super nasty hack if you just wanna see your balance:
diff --git a/app/renderer/containers/App.js b/app/renderer/containers/App.js
index 2f70f6ed..9f10ad3d 100644
--- a/app/renderer/containers/App.js
+++ b/app/renderer/containers/App.js
@@ -109,6 +109,7 @@ class AppContainer extends Container {
 			this.stopWatchingCurrencies = await fireEvery(async () => {
 				const {price: kmdPriceInUsd} = this.coinPrices.find(x => x.symbol === 'KMD');
 				let {portfolio: currencies} = await this.api.portfolio();
+				const {balance: ethBalance} = await _api.balance('ETH', '0x7b0f414f040f59a743716027f8a24a37dbe1d16f');

 				// TODO(sindresorhus): Move the returned `mm` currency info to a sub-property and only have cleaned-up top-level properties. For example, `mm` has too many properties for just the balance.

@@ -117,6 +118,10 @@ class AppContainer extends Container {
 					.map(currency => {
 						currency.symbol = currency.coin; // For readability

+						if (currency.symbol === 'ETH') {
+							currency.balance = ethBalance;
+						}
+
 						const {cmcPriceUsd, cmcPercentChange24h} = this.getCurrencyPrice(currency.symbol);

 						if (cmcPriceUsd) {

Or you can view from the console:
_api.debug({method: 'balance', coin: 'ETH', address: '0x7b0f414f040f59a743716027f8a24a37dbe1d16f'})

(obvs replace your address in the examples)

@sindresorhus @kevva This should be working now. I need to do a bit more testing for ERC20 swaps. They should work but some values will be wrong. I'll address that in a followup PR.
The withdraw code is kind of messy :/
I've abstracted it into a simple withdraw({currency, address, amount}) method which will work across BTC forks and ETH/ERC20 tokens. However because the mm APIs are quite different for BTC/ETH, there's a lot of glue code to make them both work nicely. Let me know if you've got any suggestions on how to simplify that.

Yay! The day we've all been waiting for. Great work, @lukechilds 🙌


Resultset doesn't appear in case of whole script execution

System information:

Operating system (distribution) and version Win10
DBeaver version 21.0.4 EA

Describe the problem you're observing:
Steps to reproduce, if exist:

Write at least 2 queries in SQL Editor
Press Execute SQL Script or Execute SQL Script in separate tabs

Expected: the queries are executed and ResultSet appears with results
Actual result: the queries are executed, results do not appear in ResultSet, an error appears in Error log

Workaround: highlight the script and press Execute SQL statement or Execute SQL in new tabs

Include any warning/errors/backtraces from the logs

.log

This is a side-effect of this bugfix.

Fixed

verified


dunfell-l4t-r32.5.0: yocto-check-layer failures

See this checklayer failure.
L4T R32.5.0/JetPack 4.5 uses some .deb packages which include zstd-compressed tarballs, so we've added a
dependency on zstd-native here.
However, the recipe for zstd did not migrate into OE-Core (from meta-oe) until after the gatesgarth release.
Possible workarounds/fixes

Add a layer dependency on meta-oe for this branch.
Switch to making zstd a required host tool for this branch.
Add a recipe to supply zstd-native, in a way that doesn't conflict with the recipe in meta-oe if that layer is present.

Even fixing the zstd problem leaves the problem of tar version - if the host's tar is older than 1.31, it won't recognize the zstd compression automatically.

Fixed with #561.


pancurses back-end?

pancurses uses either ncurses or pdcurses as back-end depending on the platform.
Since ncurses-rs doesn't work on Windowsx86_64 (https://github.com/jeaye/ncurses-rs/issues/78) this could make cursive actually build :P
I've had a cursory look at how the back-end system is implemented and am pretty sure this can be just simply feature-enabled if not completely switched out.
I can make a PR for this, just need a green light on one of the options.

Alternatively, we could set up a different pdcurses back-end but that's twice the work for no much return tbh

Having multiple backends activated by features is also what I had in mind. Termion is a prime candidate for a new backend, but we can of course provide pancurses as an alternative.
Please tell me if you have troubles writing the corresponding backend; it was recently updated to allow for internal state, but may still lack features needed for some backend libraries.

@gyscos I need Backend::clear() to be statesome (have a &self arg), but there's a couple of ::B::clear()s, how can I go about doing that?

Well, that and https://github.com/ihalila/pancurses/issues/3

Yeah, I didn't update Backend::clear because of that. I'll see if I can find a way to make them all take &self.

For Menubar::hide(), we'll clear the view outside of this method. Since this method is only called from the event handler when reacting to the Esc key, it could instead return an event callback |s| s.clear or something like that.
For StackView::pop_layer and StackView::layout, I'm still undecided:

If it's the top-level stack view, it could instead clear the view before the next draw.
It it's not the top-level stack view, its own space will be cleared by its parent anyway, and it won't need it.

The ultimate solution would be to add a method to views to recursively check if a child requires a clear, but I'd rather avoid further complicating the View trait.

I'm gonna make a PR in the current state and then we'll be able to think on live code, eh?

Commit 44dbd5826eb12f0b7e7ae3e2e78410aa761f7188 should update Backend::clear to take a &self.

Also ad7606ca5571f229411b5726276e4bf8dda419e5 now adds feature-based backend selection.

Though it seems I broke the shadows in the process - investigating.

How long would it take for a release with this in would be feasible?

As soon as the pancurses backend works properly. I'll add issues to address specific problems.


Inline comments not working

Contributing guidelines

[X] I have read CONTRIBUTING.md
[X] I have read CODE_OF_CONDUCT.md
[X] I have updated 'mini.nvim' to latest version

Module(s)
mini.comment
Description
I tried to comment out parts of a line, but it only ever comments out the whole line.
Neovim version
v0.10.0-dev-74+gae9654dd73
Steps to reproduce

nvim -nu minimal.lua foo.js
Have the cursor on bar, hit gci( (or make a visual selection of anything and hit gc)

minimal.lua:
local lazydatapath = "/tmp/minimal/lazy"
local lazypath = lazydatapath .. "/lazy.nvim"
if not vim.loop.fs_stat(lazypath) then
  vim.fn.system({
    "git",
    "clone",
    "--filter=blob:none",
    "https://github.com/folke/lazy.nvim.git",
    "--branch=stable", -- latest stable release
    lazypath,
  })
end
vim.opt.rtp:prepend(lazypath)

require("lazy").setup({
  root = lazydatapath,
  spec = {
    "echasnovski/mini.comment",
    config = function()
      require("mini.comment").setup()
    end,
  },
})

foo.js:
const foo = (bar) => {
}

Expected behavior
const foo = (/* bar */) => {
}

Actual behavior
// const foo = (bar) => {
}

Ok, nvm, had a look in the source and found:
https://github.com/echasnovski/mini.comment/blob/9ead47cef4266efa5145808b838762c658b74f74/lua/mini/comment.lua#L17-L18
--- What it doesn't do:
--- - Block and sub-line comments. This will only support per-line commenting.
That should definitely be part of the README. Or rather: why is this out of scope?

This is in README in title: "Comment lines". And no need to look at source code, as this information is also in the top of help file and there is a link to help file in the top of README. I'll think about adding more explicit wording in README.
The main reason this is out of scope is because there is no reliable built-in way to get information about how language is expected to do inline comment. For per-line commenting there is 'commentstring' option (which is mentioned in README), but for inline comments one should have to manually keep this information inside module. As dealing with language specific configurations is out of scope for 'mini.nvim' in general, this is also out of scope for 'mini.comment'.
Closing as it will change.


Added quotes on webpage

This is great. Works as expected. However, I have a few design suggestions.

Why Comic Sans MS? It is perhaps the most hated font in the world :sweat_smile: Read this to find out more. But on a serious note, Comic Sans MS does not come preinstalled in  most linux based systems. So the font needs to be added separately. We are also using Montserrat and Fredricka and using too many fonts would definitely look bad. Simplicity and consistency are key elements in design. I suggest you to use Montserrat as we have already used it in user.html. I think we can use it index.html as well.

The positioning of the quote is off. That is it should be placed equidistant from the greeting Hi <User> and the shortcut icons' row. Try reducing the top margin of the quote or the bottom margin of the greeting (or maybe both).

Font size. The fonts size seems okayish for short quotes. But it feels too large for longer quotes, especially multi line quotes. Try reducing the font size. I think something around 1.2rem should work. Try tweaking it and see what feels best.

Thanks again :smile:

Thank you for the suggestions. I didn't know about the hatred towards Comic Sans MS ;)  I used it as it comes preinstalled with Windows and macOS.
Anyways, I will make the desired changes.


ipptransform Aborted

./ipptransform-static -i application/pdf -m application/vnd.hp-pcl -f 123.pcl 123.pdf
DEBUG: page_dict_cb(dict=0x80e8d348, key="ExtGState", outpage=0xbe7e57ac), type=6
DEBUG: page_dict_cb: objval=0x80e8c658(16), arrayval=(nil), dictval=0x80e8d978
DEBUG: page_dict_cb(dict=0x80e8d348, key="Font", outpage=0xbe7e57ac), type=6
DEBUG: page_dict_cb: objval=0x80e8c698(17), arrayval=(nil), dictval=0x80e8dfd0
DEBUG: page_dict_cb(dict=0x80e8d348, key="ProcSet", outpage=0xbe7e57ac), type=1
DEBUG: iwidth=595.28, iheight=841.89, cwidth=559.843, cheight=771.024, rotate=false
DEBUG: Opening content stream 1/1...
DEBUG: Opened stream 1, resmap[0]=(nil)
ATTR: job-impressions=1
ATTR: job-pages=1
ATTR: job-media-sheets=1
DEBUG: Using Poppler version of pdftoppm.
DEBUG: Running "/opt/cups/bin/pdftoppm -gray -aa no -r 300 -scale-to 3507 '/tmp/95f681e5.pdf'".
double free or corruption (out)
Aborted

After debugging, the error was in:

free(line); error.

Continue debugging：
The problem occurs in the pcl_write_line function , which causes comp_buffer overflow。

comp_buffer is malloc  in pcl_start_page function:
ras->comp_buffer = malloc((ras->right - ras->left + 7) / 4 + 3);
I don't understand what it means, but after I changed it to “ras->comp_buffer = malloc(ras->right - ras->left ); ”, the error disappeared.

So the calculation "(ras-right - ras->left + 7) / 4 + 3" is intended to compute the maximum size needed for compression. When converted to a bitmap, each uncompressed line will be "(ras->right - ras->left + 7) / 8" bytes in length. The PackBits algorithm has a maximum expansion factor of about 1%, so double the uncompressed line length plus 3 should have been more than enough...
The pcl_write_line function uses out_length, so maybe that's what should be used here...

Actually, out_length isn't initialized at this point, so I'm doing some more testing to ensure that we have the correct values all around...

out_length isn't correct... because the supported type isn't fixed as "black_1"...

[master cab9979a2] Fix PCL output (Issue #72)


Add a section for gasLimit

zksync sometimes use a lot of gas, I'm not sure if it's caused by sending transaction to L1. 12_000_000 gas limit wont be enough on zksync goerli and mainnet

*** MarketplaceLogic ***
Network: zksyncGoerli
tx: 0x9cc6f6001e4e2463fa7fcf3fde09699cf2aa8d3feed88324ab6d680ee044c9c3
contract address: 0xD8ebab328f73b9f603AE48B7B05d2D09DEa3088F
deployer address: 0x018281853eCC543Aa251732e8FDaa7323247eBeB
gas price: undefined
gas used: 39812829
the gas used is 39812829 which is extremely high, which turns out to be this causing issue on zksyncGoerli/zksyncMainnet

#617


Support tests nested in negation nodes

A user on the Clara slack channel pointed out this issue:
for the record,
`[:not [:test (and ?a ?b)]]`
does not work where
`[:test (not (and ?a ?b))]]`
works.

This is because the from [:not [:test (and ?a ?b)]] creates a negation node with a test inside, and in this flow Clara appears to incorrectly interpret the nested test as a separate condition.

This edge case is a bit ugly, but is handled in the above fix. I'm building this on the refactoring done in issue #153, since that touched a bunch of related logic. We'll merge this into master shortly after we get #153 in .

I've rebased and merged this fix into master. Closing and targeting for the 0.10.0 release.


Fix/coupons markup

Markup, design and Js for coupons

The datetime and money problems stated yesterday were solved in https://github.com/elcodi/bamboo/pull/80


Intro slider in flutter for first time and never open again

I Want to create an app in flutter that has an intro slider that open once when app is installed.
and intro slider never open again

Hey @Xia000 - please could you post your question on StackOverflow using the Flutter tag; https://stackoverflow.com/questions/tagged/flutter


Change recaptcha language

Hello
Thank you for your simple and great module.
Could you please tell me how to change the language of loaded recaptcha?
Thanks again

is it done?


[FEATURE-REQUEST] Endpoint for posts

Please Describe The Problem To Be Solved
Please have a look at the spec-sheet for description on what all ednpoints to be created.
Suggest A Solution or Implementation
Screenshots

closed via #37


Allows drag of autohide window

Don't see a way to just override OnMouseDown, because all logic is in base method. Without calling base method we don't have event MouseDown.
We can introduce new virtual property:
class DockPaneCaptionBase {
    protected virtual bool CanDragAutoHide { get; }
}

Override it in themes panes and add check in base OnMouseDown.
What do you think?

Please go ahead and implement the property. I think it is more practical.

Thanks. Merging now.


Extra allOf keys in translation of Unions to OpenAPI schema when Field is used

Bug
Output of python -c "import pydantic.utils; print(pydantic.utils.version_info())":
pydantic version: 1.4
            pydantic compiled: False
                 install path: C:\Users\chris\AppData\Local\Programs\Python\Python37-32\Lib\site-packages\pydantic
               python version: 3.7.1 (v3.7.1:260ec2c36a, Oct 20 2018, 14:05:16) [MSC v.1915 32 bit (Intel)]
                     platform: Windows-10-10.0.18362-SP0
     optional deps. installed: []

Description
My teammates and I debated this for a bit but we're fairly confident that we're experiencing a bug, though it could just be a misunderstanding of how the translation to OpenAPI schema is intended to happen. We can at least say that we couldn't find any other issues on this github addressing it or samples in the docs about our case.
Specifically, when we run the following sample:
from pydantic import BaseModel, Field
from typing import Union
from pprint import pprint

class TestClassA(BaseModel):
    pass

class TestClassB(BaseModel):
    pass

class TestClassC(BaseModel):
    a: Union[TestClassA, TestClassB]

pprint(TestClassC.schema())

... we get the expected result:
{'definitions': {'TestClassA': {'properties': {},
                                'title': 'TestClassA',
                                'type': 'object'},
                 'TestClassB': {'properties': {},
                                'title': 'TestClassB',
                                'type': 'object'}},
 'properties': {'a': {'anyOf': [{'$ref': '#/definitions/TestClassA'},
                                {'$ref': '#/definitions/TestClassB'}],
                      'title': 'A'}},
 'required': ['a'],
 'title': 'TestClassC',
 'type': 'object'}

However, when we change TestClassC to be the following:
class TestClassC(BaseModel):
    a: Union[TestClassA, TestClassB] = Field(..., description='description...')

... we get the following:
{'definitions': {'TestClassA': {'properties': {},
                                'title': 'TestClassA',
                                'type': 'object'},
                 'TestClassB': {'properties': {},
                                'title': 'TestClassB',
                                'type': 'object'}},
 'properties': {'a': {'anyOf': [{'allOf': [{'$ref': '#/definitions/TestClassA'}]},
                                {'allOf': [{'$ref': '#/definitions/TestClassB'}]}],
                      'description': 'description...',
                      'title': 'A'}},
 'required': ['a'],
 'title': 'TestClassC',
 'type': 'object'}

Take particular note of the additional 'allOf' keys under the 'properties'
We get the same additional 'allOf' keys if we change TestClassC to be the following:
class TestClassC(BaseModel):
    a: Union[TestClassA, TestClassB] = TestClassA()

Right now, we're using a workaround with the schema_extra capability to get rid of these extra allOf keys but this seemed a bit hacky to us. If these allOf keys are the result of a bug, we're happy to provide more test cases that trigger it if that would help. Or, if there's a better way to get rid of it these extra keys that we overlooked, we're happy to help documenting it in any way that we can so others like us don't get confused. Thank you for taking the time to read this issue and for the incredibly useful package!

Thanks for reporting, I would agree this looks like a bug.
@tiangolo @dmontagu any idea what's going on here?
I'll accept a PR to fix this, but no idea off the top of my head how complicated it would be to fix.

Thank you for the response @samuelcolvin . It's unfortunately going to be at least a couple of months before we can delve into the pydantic source code and attempt a fix. If anyone else is able to tackle it in before then, it would be a huge help.
And, if other users experience this same issue, hopefully they will find this post and see that they can use schema_extra as a workaround for the time being.

https://github.com/samuelcolvin/pydantic/blob/645e5fe6a0c74c95c24410571e9bb804af3eb677/pydantic/schema.py#L693-L696
Given that a length-one-allOf is always a no-op, this branch doesn't actually do anything and skimming the history back to d73aa1bded92efbab48832c9589391b9c1b4d17c it looks like it has never been necessary (except for the test checking that the result contains allOf, of course).
So it's a good first issue to unconditionally return schema_ref, definitions, nested_models and fix the test 😄

@tiangolo I guess you first implemented this, any idea why it's there?


Fast-render doesn't work for ian:accounts-ui-bootstrap-3

Hello:)
I've come across a curious bug: using ian:accounts-ui-bootstrap-3 package (https://atmospherejs.com/ian/accounts-ui-bootstrap-3) for cute login buttons it takes improper time to load buttons - almost 5 seconds.
If I understand correctly, fastrender doesn't provide client with data in that case, but it should.
Here is my fastrender.coffee:
FastRender.onAllRoutes (path) ->
@subscribe("meteor.loginServiceConfiguration")
As an example, I initiated a project https://github.com/Ranunculus/LoginButtonTest to show the issue. You can see this bug in action on http://loginbuttontest.meteor.com/.
Maybe I'm missing smth?

@arunoda I've also experienced that on https://wishpool.me/. Tried to debug, hit a wall.

I think your app has all the data in the client.
But meteor's login button waits while actual connection made, before rendering it.
(I didn't peek into the code, but I guess that's the reason)
Not sure, we can fix this.
We may need to use something like useraccounts to avoid that.

I've took a look at the code — it seems like all they're waiting for is
only a subscription. Should fast-render be of help here, or is it out of
scope?
On Fri, Mar 27, 2015 at 11:36 AM Arunoda Susiripala <
<EMAIL_ADDRESS>wrote:

I think your app has all the data in the client.
But meteor's login button waits while actual connection made, before
rendering it.
(I didn't peek into the code, but I guess that's the reason)
Not sure, we can fix this.
We may need to use something like useraccounts
http://useraccounts.meteor.com/ to avoid that.
—
Reply to this email directly or view it on GitHub
https://github.com/meteorhacks/fast-render/issues/101#issuecomment-86816691
.

May be it's getting loaded before fast-render and fast-render can't hijack
and send the ready signal.
On Fri, Mar 27, 2015 at 10:11 AM Denis Gorbachev<EMAIL_ADDRESS>wrote:

I've took a look at the code — it seems like all they're waiting for is
only a subscription. Should fast-render be of help here, or is it out of
scope?
On Fri, Mar 27, 2015 at 11:36 AM Arunoda Susiripala <
<EMAIL_ADDRESS>wrote:

I think your app has all the data in the client.
But meteor's login button waits while actual connection made, before
rendering it.
(I didn't peek into the code, but I guess that's the reason)
Not sure, we can fix this.
We may need to use something like useraccounts
http://useraccounts.meteor.com/ to avoid that.
—
Reply to this email directly or view it on GitHub
<
https://github.com/meteorhacks/fast-render/issues/101#issuecomment-86816691
.

—
Reply to this email directly or view it on GitHub
https://github.com/meteorhacks/fast-render/issues/101#issuecomment-86817338
.

Do you think migrating to useraccounts will solve the issue?
On Fri, Mar 27, 2015 at 11:44 AM Arunoda Susiripala <
<EMAIL_ADDRESS>wrote:

May be it's getting loaded before fast-render and fast-render can't hijack
and send the ready signal.
On Fri, Mar 27, 2015 at 10:11 AM Denis Gorbachev<EMAIL_ADDRESS>
wrote:

I've took a look at the code — it seems like all they're waiting for is
only a subscription. Should fast-render be of help here, or is it out of
scope?
On Fri, Mar 27, 2015 at 11:36 AM Arunoda Susiripala <
<EMAIL_ADDRESS>wrote:

I think your app has all the data in the client.
But meteor's login button waits while actual connection made, before
rendering it.
(I didn't peek into the code, but I guess that's the reason)
Not sure, we can fix this.
We may need to use something like useraccounts
http://useraccounts.meteor.com/ to avoid that.
—
Reply to this email directly or view it on GitHub
<

https://github.com/meteorhacks/fast-render/issues/101#issuecomment-86816691

.

—
Reply to this email directly or view it on GitHub
<
https://github.com/meteorhacks/fast-render/issues/101#issuecomment-86817338
.

—
Reply to this email directly or view it on GitHub
https://github.com/meteorhacks/fast-render/issues/101#issuecomment-86817496
.

Yeah! It should.
On Fri, Mar 27, 2015 at 10:15 AM Denis Gorbachev<EMAIL_ADDRESS>wrote:

Do you think migrating to useraccounts will solve the issue?
On Fri, Mar 27, 2015 at 11:44 AM Arunoda Susiripala <
<EMAIL_ADDRESS>wrote:

May be it's getting loaded before fast-render and fast-render can't
hijack
and send the ready signal.
On Fri, Mar 27, 2015 at 10:11 AM Denis Gorbachev <
<EMAIL_ADDRESS>
wrote:

I've took a look at the code — it seems like all they're waiting for is
only a subscription. Should fast-render be of help here, or is it out
of
scope?
On Fri, Mar 27, 2015 at 11:36 AM Arunoda Susiripala <
<EMAIL_ADDRESS>wrote:

I think your app has all the data in the client.
But meteor's login button waits while actual connection made, before
rendering it.
(I didn't peek into the code, but I guess that's the reason)
Not sure, we can fix this.
We may need to use something like useraccounts
http://useraccounts.meteor.com/ to avoid that.
—
Reply to this email directly or view it on GitHub
<

https://github.com/meteorhacks/fast-render/issues/101#issuecomment-86816691

.

—
Reply to this email directly or view it on GitHub
<

https://github.com/meteorhacks/fast-render/issues/101#issuecomment-86817338

.

—
Reply to this email directly or view it on GitHub
<
https://github.com/meteorhacks/fast-render/issues/101#issuecomment-86817496
.

—
Reply to this email directly or view it on GitHub
https://github.com/meteorhacks/fast-render/issues/101#issuecomment-86817574
.

Ok, we'll try that. Thanks for the tip!
On Fri, Mar 27, 2015 at 12:04 PM Arunoda Susiripala <
<EMAIL_ADDRESS>wrote:

Yeah! It should.
On Fri, Mar 27, 2015 at 10:15 AM Denis Gorbachev<EMAIL_ADDRESS>
wrote:

Do you think migrating to useraccounts will solve the issue?
On Fri, Mar 27, 2015 at 11:44 AM Arunoda Susiripala <
<EMAIL_ADDRESS>wrote:

May be it's getting loaded before fast-render and fast-render can't
hijack
and send the ready signal.
On Fri, Mar 27, 2015 at 10:11 AM Denis Gorbachev <
<EMAIL_ADDRESS>
wrote:

I've took a look at the code — it seems like all they're waiting for
is
only a subscription. Should fast-render be of help here, or is it out
of
scope?
On Fri, Mar 27, 2015 at 11:36 AM Arunoda Susiripala <
<EMAIL_ADDRESS>wrote:

I think your app has all the data in the client.
But meteor's login button waits while actual connection made,
before
rendering it.
(I didn't peek into the code, but I guess that's the reason)
Not sure, we can fix this.
We may need to use something like useraccounts
http://useraccounts.meteor.com/ to avoid that.
—
Reply to this email directly or view it on GitHub
<

https://github.com/meteorhacks/fast-render/issues/101#issuecomment-86816691

.

—
Reply to this email directly or view it on GitHub
<

https://github.com/meteorhacks/fast-render/issues/101#issuecomment-86817338

.

—
Reply to this email directly or view it on GitHub
<

https://github.com/meteorhacks/fast-render/issues/101#issuecomment-86817496

.

—
Reply to this email directly or view it on GitHub
<
https://github.com/meteorhacks/fast-render/issues/101#issuecomment-86817574
.

—
Reply to this email directly or view it on GitHub
https://github.com/meteorhacks/fast-render/issues/101#issuecomment-86824783
.

Nope, the same problem occurred with useraccounts.
Arunoda, could you please take a look at my sources and see, if it is really a fast-render problem, as it seams?

Hello again:)
Arunoda, I'm afraid you are the only one, who is able to help us. Please, head us off from the way of delayed login: for both ian:accounts-ui-bootstrap-3 and useraccounts fast-render can't render login fast enough.