H2 Assertsion at Http2DependencyTree::deactivate

Fixed #2208
H2 Assert fails sometimes at Http2DependencyTree::deactivate.
There is a problem, when we received the reprioritize frame. The priority queue will be changed.
This event will happen again, when client abort.
This pr only fixes the trigger by h2load.
By the way,  @masaori335 why do we use this assertion? :-)

The priority queue's entry is in chronological order,  Queue is better than DLL if we try to remove the bottom entry (actually, it is first one in the list).

The assertion assumes when ATS deactivate a node, it's the top node of priority tree.
But it looks like it's wrong when ATS delete streams. Because ATS pickup a stream from stream list not from priority tree.
So, I think just removing the assertion is fine.

I'm fine to change the data structure of stream_list from DLL to Queue. But as you said, this will fix only h2load case.
If TS needs to close a stream by some error and the stream is not top node of priority queue, this assertion will be occur.

@masaori335 Thanks for reviewing. As you comment above, I remove the unused code ! Can you please review again?

I'd rather use C++ style casts (e.g. static_cast).

Thanks, I'll updated later !

@masaori335 @maskit updated! Please review again !

@masaori335 @maskit updated! Please review again !

@masaori335 Is this a candidate for a v7.1.1 release ? If so, please add it to the 7.x project.

Why this is a candidate for 7.x

To make HTTP/2 Priority Feature correct
To later backport easier, because the data structure of stream_list is changed

Which version(s) of 7.x it should go to.

v7.1.1

Cool. I'm testing latest master on Docs (with this patch) right now. However, this does not cherry-pick cleanly to the 7.1.x branch, so can you please make a PR against that branch as well?


sky130B missing MINENCLOSEDAREA

Fix a bug in fix_techlefB.py

@RTimothyEdwards just checking on this.

Pulled and merged.


Added slice interface to Centroids

Hi,
seems good to have ability to pass pre-allocated buffer to Centroids function to avoid allocations. I'll be fine to receive a feedback if something should be improved.
Thanks, Ilya.

hello guys, how do you think about to merge it. If you have any idea how to redo it in a better way, please let me know. Thank you.

@Tthread awesome!  much better with pre-allocated buffer


Rename seed-default and seed-secrets

Per discussion in #91,  I created a new issue to bring this up
===================
@pdettor I just curious, are the names seed-secret and seed-defaults configurable? If we put them into the end-user's namespace where the service/bind resource being created, I would like to use a more explicitly name , i.e. secret-ibm-cloud-operator and config-ibm-cloud-operator to avoid the deletion by end-user.
Answered by @vazirim
@cdlliuy Sure, we can rename.
===================

This item is already part of #91


feat: Utilise mysql2 package instead of mysql

I know there already is a PR for this but I also look into the tests and updated the packages.
The db-migrate is the best migration lib out there currently but it is lacking support for newer versions of MySQL ^8.0.4 because of the older mysql package do not have a support for the new authentication with the "caching_sha2_password" plugin.
We have been waiting for this PR to fix this issue for some time now with no progress.
The package mysql2 has already working support for MySQL 8.0.21 authentication.
mysql2 is mostly API compatible with mysqljs.
Tested on MySQL 5.7.31 and 8.0.21
Let me know what you think.

Released db-migrate-mysql8 as a substitute
Just use "driver": "mysql8" in database.json.


erc20 transfer function would create another transaction that differ from erc20's transaction and then lost important info

What happened?
    let contractEthreumAddress = EthereumAddress(contractAddress)!
    let erc20 = ERC20(web3: web3, provider: web3.provider, address: contractEthreumAddress)
    guard let writeOP = try? await erc20.transfer(from: EthereumAddress(fromAddress)!, to: EthereumAddress(toAddress)!, amount: amount) else {
        return nil
    }

    var transaction = writeOP.transaction
    /// lose, need to add back
    transaction.from = erc20.transaction.from
    transaction.to = contractEthreumAddress
    transaction.callOnBlock = .latest

writeOP.transaction is different to erc20.transaction. They are 2 different instances. And writeOP.transaction lose the from & to & callOnBlock information.
if I donot add the last three codes, when I call web3.eth.send(raw)，it just returns nil.
Library version
3.06

writeOP.transaction is different to erc20.transaction. They are 2 different instances.

That's definitely the bug. It's kinda easy to be fixed one, since it appears that ERC20.tx property never assigns to a Contract.tx property which they should.
I've provided a quick fix for it. So I think this given case would be fixed within a week or so.
Thanks for point this out.

Anyway, please be aware, that the fix fixed only the one given case of the error that are all ERC* types affected. Thus more general #712 issue has been created.

Thank you for your timely reply.


Added moderation features like automatic mute & unmute as per infractions and added mute & unmute commands

Forgot to include the updated requirements.txt. Closed this PR and created a new one.


Add opensds service broker module

What this PR does / why we need it:
Recently we have finished the latest work of integrating OpenSDS Controller project with Service Catalog project to provide policy-based storage orchestration service. So we want to push the driver called service-broker which plays the shim layer for transfering the request into controller project.
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
Special notes for your reviewer:
Release note:

LGTM


Skipped tests and subtest support

It is finally time to implement skipped tests. Issues #8 and #18 both implement test skipping, but they all failed some tests. With the refactoring of the test framework in #25, it was easy to add version-specific conditions to the gold files.
This work is based on issue #18, with working tests on Py2.6, and also adds subtest support. Note that this issue creates conflicts with the gold file in #26, but I fixed these in my own master branch (see https://github.com/ralphje/teamcity-python/blob/master/tests/test_output/test-unittest.output.gold that merges all my pull requests)

Manually ported to master branch, thanks


[BEAM-1296] Providing a small dataset for "Apache Beam Mobile Gaming …

A dataset "gs://apache-beam-samples/game/gaming_data*.csv" for "Apache Beam Mobile Gaming Pipeline Examples" is so huge (about 2 chunks of ~12 GB) and it takes long time to download the dataset. It might pose difficulties to Apache Beam beginners who want to try "Apache Beam Mobile Gaming Pipeline Examples" quickly.
I've added a sample dataset for the Mobile Gaming example for quick testing locally.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

Post-Commit Tests Status (on master branch)

Lang
SDK
Apex
Dataflow
Flink
Gearpump
Samza
Spark

Go

---
---

---
---

Java

Python

---

---
---

XLang
---
---
---

---
---
---

Pre-Commit Tests Status (on master branch)

---
Java
Python
Go
Website

Non-portable

Portable
---

---
---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

retest this please

Thanks for helping to generate the data. Maybe we should push it to a GCS bucket instead of keeping it in the Github repo?

I can push your file to the GCS bucket. I am just wondering if you think that's a good idea? If so, we'd have to amend the docstring.

Yeah that sounds like a good idea, file is kinda small so friends will be able to download it :fire:

Alright, I've uploaded the file to gs://apache-beam-samples/game/small/gaming_data.csv. Can you check that it's accessible? If so, for this PR, could you:

Remove the file
Update the documentation to point to gs://apache-beam-samples/game/small/gaming_data.csv for the small dataset?

The file is in fact accessible.
I've deleted the previous file and updated the comment.
I left the default original input as it is, because we just want a lighter alternative
xoxo

Thanks!


[WIP] Adds update_task_registry

What is this PR trying to achieve?
Modify the task registry so that it reflects the status of the running tasks.
This is in order to report on the status of a task requested through the register_ecs_task lambda.
Who is this change for?
For: https://github.com/wellcometrust/platform/issues/1005
Have the following been considered/are they needed?

[ ] Deployed new versions
[ ] Run terraform apply.

For: https://github.com/wellcometrust/platform/issues/1005

Closing as 😕


[ko] Update outdated files in dev-1.22-ko.4 (M43-M55)

Related issue: #30846

[ ]  M43.  content/en/docs/reference/kubectl/overview.md  | 1(+XS) 1(-)
[ ]  M44.  content/en/docs/reference/labels-annotations-taints.md  | 13(+S) 4(-)
[ ]  M45.  content/en/docs/reference/tools/_index.md  | 16(+S) 0(-)
[ ]  M46.  content/en/docs/reference/using-api/client-libraries.md  | 1(+XS) 0(-)
[ ]  M47.  content/en/docs/reference/using-api/health-checks.md  | 4(+XS) 4(-)
[ ]  M48.  content/en/docs/setup/production-environment/container-runtimes.md  | 1(+XS) 1(-)
[ ]  M49.  content/en/docs/setup/production-environment/tools/kubeadm/install-kubeadm.md  | 1(+XS) 1(-)
[ ]  M50.  content/en/docs/setup/production-environment/tools/kubespray.md  | 5(+XS) 5(-)
[ ]  ~M51.  content/en/docs/setup/production-environment/windows/intro-windows-in-kubernetes.md  | 1(+XS) 1(-)~

#30364

[ ]  M52.  content/en/docs/tasks/access-application-cluster/access-cluster.md  | 1(+XS) 109(-)
[ ]  M53.  content/en/docs/tasks/access-application-cluster/connecting-frontend-backend.md  | 1(+XS) 1(-)
[ ]  M54.  content/en/docs/tasks/access-application-cluster/list-all-running-container-images.md  | 2(+XS) 2(-)
[ ]  M55.  content/en/docs/tasks/administer-cluster/access-cluster-services.md  | 12(+S) 1(-)

[ ] D1. content/en/docs/tasks/administer-cluster/highly-available-control-plane.md

/language ko

/assign

/lgtm


handle_link_maintenance_start is using new Links references that don't exist on self.links

handle_link_maintenance_start is using Link instance references that don't exist on topology self.links, as a result trying to disable then would lead to inconsistency in the graph since topology owns the self.links when building the topology and publishing it to subscribers. I think maintenance should consume the disable rest endpoint, and then we could also parametrize the reason, and rely on topology to change accordingly the admin status of link and notify the subscribers, that way having this responsibility in a single place. We might also need to support a list of items to perform a single call.

Fixed with #147


Add Arduino support

Once all existing frameworks are supposed, one can think about expanding  / creating an Arduino core for these boards.

Done for CH32V003 in https://github.com/Community-PIO-CH32V/platform-ch32v/commit/2f95c188d471f2e1087c3d5803c5c2345387887a

Hello. When can we expect the addition of functions analogRead analogWrite AttachInterrupt for Arduino part ? I've tried changing the adc-tempo example to read voltages, but it's hard for me. Perhaps there are working pieces of code for these functions?

Great, thanks a lot.
https://github.com/openwch/arduino_core_ch32
This is what I need now!

https://github.com/openwch/arduino_core_ch32  Now has native Arduino SPI implementation..
I tried adding it as a custom core to CH32V framework but failed. I think adding it now, especially for CH32V003 will be a big step in getting low cost projects going.
I can try adding it myself if there is any documentations on doing so, if not I think it will be very beneficial to add this core at least for V003.

This core is already supported for CH32V003. Please see project's https://github.com/Community-PIO-CH32V/platform-ch32v/tree/develop/examples/blinky-arduino platformio.ini file.

Closing since a lot of boards are supported in the OpenWCH Arduino core now. New boards will be synced here as they gain support in that core.


fix documentation for SECURITY.md

grammatical fixes in examples of sandboxing tools (remove an extra comma)

I signed it!

To be consistent with the rest of our usage, which generally favors the comma after both "i.e." and "e.g.", I'm inclined to close this.
There's no consensus on what the "correct" way to do this is, see, e.g., here.


[Tests-Only] Up download single file shares

Get results of file download tests...
Actually interested in apiShareManagement/acceptSharesToSharesFolder.feature:15 (and similar where the downloaded file is empty)

https://cloud.drone.io/cs3org/reva/2546/5/7
 Scenario: When accepting a share of a file, the received file is accessible                                                # /drone/src/tmp/testrunner/tests/acceptance/features/apiShareManagement/acceptSharesToSharesFolder.feature:15
    Given the administrator has set the default folder for received shares to "Shares"                                       # OccContext::theAdministratorHasSetTheDefaultFolderForReceivedSharesTo()
    And parameter "shareapi_auto_accept_share" of app "core" has been set to "no"                                            # AppConfigurationContext::serverParameterHasBeenSetTo()
    And user "Alice" has shared file "/textfile0.txt" with user "Brian"                                                      # FeatureContext::userHasSharedFileWithUserUsingTheSharingApi()
    When user "Brian" accepts share "/textfile0.txt" offered by user "Alice" using the sharing API                           # FeatureContext::userReactsToShareOfferedBy()
    Then the content of file "/Shares/textfile0.txt" for user "Brian" should be "ownCloud test text file 0" plus end-of-line # FeatureContext::contentOfFileForUserShouldBePlusEndOfLine()
      The downloaded content was expected to be 'ownCloud test text file 0
      ', but actually is ''. HTTP status was 404
      Failed asserting that two strings are equal.
      --- Expected
      +++ Actual
      @@ @@
      -'ownCloud test text file 0\n
      -'
      +''

It gets a 404 - not found

Hm, I am testing this with ocis ...
go.mod has
replace github.com/cs3org/reva => ../reva
replace github.com/owncloud/ocis-reva => ../ocis-reva

reva uses this branch ...
and the tests like this:
✗ make test-acceptance-api \
TEST_SERVER_URL=https://localhost:9200 \
TEST_OCIS=true \
OCIS_REVA_DATA_ROOT=/var/tmp/reva/ \
SKELETON_DIR=apps/testing/data/apiSkeleton \
BEHAT_FILTER_TAGS='~@notToImplementOnOCIS&&~@toImplementOnOCIS' \
BEHAT_FEATURE='tests/acceptance/features/apiShareManagement/acceptSharesToSharesFolder.feature'
composer install
PHP Warning:  PHP Startup: Unable to load dynamic library 'xmlrpc.so' (tried: /usr/lib/php/modules/xmlrpc.so (/usr/lib/php/modules/xmlrpc.so: cannot open shared object file: No such file or directory), /usr/lib/php/modules/xmlrpc.so.so (/usr/lib/php/modules/xmlrpc.so.so: cannot open shared object file: No such file or directory)) in Unknown on line 0
Loading composer repositories with package information
Installing dependencies (including require-dev) from lock file
Nothing to install or update
Package container-interop/container-interop is abandoned, you should avoid using it. Use psr/container instead.
Package guzzlehttp/ringphp is abandoned, you should avoid using it. No replacement was suggested.
Package guzzlehttp/streams is abandoned, you should avoid using it. No replacement was suggested.
Package jakub-onderka/php-console-color is abandoned, you should avoid using it. Use php-parallel-lint/php-console-color instead.
Package jakub-onderka/php-console-highlighter is abandoned, you should avoid using it. Use php-parallel-lint/php-console-highlighter instead.
Package patchwork/jsqueeze is abandoned, you should avoid using it. No replacement was suggested.
Generating optimized autoload files
Composer cleaner: Removed 5 files or directories.
composer bin behat install --no-progress
PHP Warning:  PHP Startup: Unable to load dynamic library 'xmlrpc.so' (tried: /usr/lib/php/modules/xmlrpc.so (/usr/lib/php/modules/xmlrpc.so: cannot open shared object file: No such file or directory), /usr/lib/php/modules/xmlrpc.so.so (/usr/lib/php/modules/xmlrpc.so.so: cannot open shared object file: No such file or directory)) in Unknown on line 0
Loading composer repositories with package information
Installing dependencies (including require-dev) from lock file
Nothing to install or update
Generating autoload files
ocramius/package-versions: Generating version class...
ocramius/package-versions: ...done generating version class
32 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
./tests/acceptance/run.sh --type api
Script path: /home/jfd/Repositories/core/tests/acceptance
Not using php inbuilt server for running scenario ...
Updating .htaccess for proper rewrites

Running apiShareManagement tests tagged ~@skipWhenTestingRemoteSystems&&~@skipOnOcV&&~@skipOnOcV&&~@skipOnOcV&&~@notToImplementOnOCIS&&~@toImplementOnOCIS&&@api&&~@skip
PHP Warning:  PHP Startup: Unable to load dynamic library 'xmlrpc.so' (tried: /usr/lib/php/modules/xmlrpc.so (/usr/lib/php/modules/xmlrpc.so: cannot open shared object file: No such file or directory), /usr/lib/php/modules/xmlrpc.so.so (/usr/lib/php/modules/xmlrpc.so.so: cannot open shared object file: No such file or directory)) in Unknown on line 0
@api @files_sharing-app-required
Feature: accept/decline shares coming from internal users to the Shares folder
  As a user
  I want to have control of which received shares I accept
  So that I can keep my file system clean

  Background:                                                                     # /home/jfd/Repositories/core/tests/acceptance/features/apiShareManagement/acceptSharesToSharesFolder.feature:7
    Given using OCS API version "1"                                               # FeatureContext::usingOcsApiVersion()
    And using new DAV path                                                        # FeatureContext::usingOldOrNewDavPath()
    And these users have been created with default attributes and skeleton files: # FeatureContext::theseUsersHaveBeenCreated()
      | username |
      | Alice    |
      | Brian    |

  Scenario: When accepting a share of a file, the received file is accessible                                                # /home/jfd/Repositories/core/tests/acceptance/features/apiShareManagement/acceptSharesToSharesFolder.feature:15
    Given the administrator has set the default folder for received shares to "Shares"                                       # OccContext::theAdministratorHasSetTheDefaultFolderForReceivedSharesTo()
    And parameter "shareapi_auto_accept_share" of app "core" has been set to "no"                                            # AppConfigurationContext::serverParameterHasBeenSetTo()
    And user "Alice" has shared file "/textfile0.txt" with user "Brian"                                                      # FeatureContext::userHasSharedFileWithUserUsingTheSharingApi()
    When user "Brian" accepts share "/textfile0.txt" offered by user "Alice" using the sharing API                           # FeatureContext::userReactsToShareOfferedBy()
    Then the content of file "/Shares/textfile0.txt" for user "Brian" should be "ownCloud test text file 0" plus end-of-line # FeatureContext::contentOfFileForUserShouldBePlusEndOfLine()

  Scenario: When accepting a share of a folder, the received folder is accessible                                                     # /home/jfd/Repositories/core/tests/acceptance/features/apiShareManagement/acceptSharesToSharesFolder.feature:22
    Given the administrator has set the default folder for received shares to "Shares"                                                # OccContext::theAdministratorHasSetTheDefaultFolderForReceivedSharesTo()
    And parameter "shareapi_auto_accept_share" of app "core" has been set to "no"                                                     # AppConfigurationContext::serverParameterHasBeenSetTo()
    And user "Alice" has shared file "/PARENT" with user "Brian"                                                                      # FeatureContext::userHasSharedFileWithUserUsingTheSharingApi()
    When user "Brian" accepts share "/PARENT" offered by user "Alice" using the sharing API                                           # FeatureContext::userReactsToShareOfferedBy()
    Then the content of file "/Shares/PARENT/parent.txt" for user "Brian" should be "ownCloud test text file parent" plus end-of-line # FeatureContext::contentOfFileForUserShouldBePlusEndOfLine()

  @skipOnOcV10 @issue-37883
  Scenario: When accepting a share of a file, the response is valid                                                         # /home/jfd/Repositories/core/tests/acceptance/features/apiShareManagement/acceptSharesToSharesFolder.feature:30
    Given the administrator has set the default folder for received shares to "Shares"                                      # OccContext::theAdministratorHasSetTheDefaultFolderForReceivedSharesTo()
    And parameter "shareapi_auto_accept_share" of app "core" has been set to "no"                                           # AppConfigurationContext::serverParameterHasBeenSetTo()
    And user "Alice" has shared file "/textfile0.txt" with user "Brian"                                                     # FeatureContext::userHasSharedFileWithUserUsingTheSharingApi()
    When user "Brian" accepts share "/textfile0.txt" offered by user "Alice" using the sharing API                          # FeatureContext::userReactsToShareOfferedBy()
    Then the OCS status code should be "100"                                                                                # OCSContext::theOCSStatusCodeShouldBe()
      OCSContext::getOCSResponseStatusCode Received empty response where XML was expected (Exception)
    And the HTTP status code should be "200"                                                                                # FeatureContext::thenTheHTTPStatusCodeShouldBe()
    And the fields of the last response to user "Alice" sharing with user "Brian" should include                            # FeatureContext::checkFieldsOfLastResponseToUser()
      | share_with             | %username%            |
      | share_with_displayname | %displayname%         |
      | file_target            | /Shares/textfile0.txt |
      | path                   | /Shares/textfile0.txt |
      | permissions            | share,read,update     |
      | uid_owner              | %username%            |
      | displayname_owner      | %displayname%         |
      | item_type              | file                  |
      | mimetype               | text/plain            |
      | storage_id             | ANY_VALUE             |
      | share_type             | user                  |
    And the content of file "/Shares/textfile0.txt" for user "Brian" should be "ownCloud test text file 0" plus end-of-line # FeatureContext::contentOfFileForUserShouldBePlusEndOfLine()

  @skipOnOcV10 @issue-37883
  Scenario: When accepting a share of a folder, the response is valid                                                                # /home/jfd/Repositories/core/tests/acceptance/features/apiShareManagement/acceptSharesToSharesFolder.feature:52
    Given the administrator has set the default folder for received shares to "Shares"                                               # OccContext::theAdministratorHasSetTheDefaultFolderForReceivedSharesTo()
    And parameter "shareapi_auto_accept_share" of app "core" has been set to "no"                                                    # AppConfigurationContext::serverParameterHasBeenSetTo()
    And user "Alice" has shared file "/PARENT" with user "Brian"                                                                     # FeatureContext::userHasSharedFileWithUserUsingTheSharingApi()
    When user "Brian" accepts share "/PARENT" offered by user "Alice" using the sharing API                                          # FeatureContext::userReactsToShareOfferedBy()
    Then the OCS status code should be "100"                                                                                # OCSContext::theOCSStatusCodeShouldBe()
      OCSContext::getOCSResponseStatusCode Received empty response where XML was expected (Exception)
    And the HTTP status code should be "200"                                                                                # FeatureContext::thenTheHTTPStatusCodeShouldBe()
    And the fields of the last response to user "Alice" sharing with user "Brian" should include                                     # FeatureContext::checkFieldsOfLastResponseToUser()
      | share_with             | %username%           |
      | share_with_displayname | %displayname%        |
      | file_target            | /Shares/PARENT       |
      | path                   | /Shares/PARENT       |
      | permissions            | all                  |
      | uid_owner              | %username%           |
      | displayname_owner      | %displayname%        |
      | item_type              | folder               |
      | mimetype               | httpd/unix-directory |
      | storage_id             | ANY_VALUE            |
      | share_type             | user                 |
    And the content of file "/Shares/PARENT/parent.txt" for user "Brian" should be "ownCloud test text file parent" plus end-of-line # FeatureContext::contentOfFileForUserShouldBePlusEndOfLine()

--- Failed scenarios:

    /home/jfd/Repositories/core/tests/acceptance/features/apiShareManagement/acceptSharesToSharesFolder.feature:30
    /home/jfd/Repositories/core/tests/acceptance/features/apiShareManagement/acceptSharesToSharesFolder.feature:52

4 scenarios (2 passed, 2 failed)
38 steps (30 passed, 2 failed, 6 skipped)
2m59.98s (15.60Mb)
runsh: Total 4 scenarios (2 passed, 2 failed)
runsh: Exit code of main run: 1
runsh: Total unexpected failed scenarios throughout the test run:
apiShareManagement/acceptSharesToSharesFolder.feature:30
apiShareManagement/acceptSharesToSharesFolder.feature:52
runsh: There were no unexpected success.
make: *** [Makefile:207: test-acceptance-api] Fehler 1

PR #1172 bumps the core commit id to get this little bit of test code change from core.

OK - it might work with ocis storage.
I was getting ocis storage CI running in #1165
I also ran litmus with ocis storage, but it got a fail. See PR #1166 - so I thought it will be good to understand that fail first, before running loads of API tests.


Add kindpod specifics

Added clarifications when matching managed/umanaged Pods. Link to discussion

@rdavyd I understand that you would like some clarification on how the auto-gen controller will work for Pods and also a reminder note in the Selecting Resources page. I will take these ideas and figure out a way to put them into the docs in a more integrated way. I think this will be easier than trying to alter your PR, so although I'm closing it, this will go into a task for the next docs update. Thanks for bringing this up.


Static file serving doesn't support symlinks

I noticed that Fresh will return 404s for symlinked files placed in the static/ directory. I didn't dig too deeply, but I suspect this could be due to an explicit followSymlinks: false option here.
I'm unsure if this is intentional behavior. If it is, it might be worth mentioning this behavior in the corresponding docs, since I'm probably not the only one who will try this.
I'd also gently suggest that supporting symlinks would be a good thing. I just tested the Golang equivalent (http.FileServer) and it handles symlinks as you'd expect.

I'm -1 on allowing symlinks. Seems like a pretty big possible security hole if everyone isn't writing perfect code.

@lino-levan

Seems like a pretty big possible security hole

I think that's a fair concern any time symlinks are involved, but I think in this case, favoring security over composability and principle-of-least-surprise is not the right tradeoff.
Up to this point, we're just talking about personal preferences, but maybe I can try to add a bit more data into the conversation. I'm not aware of any general security principles that advise against using symlinks for static file serving; in fact, following symlinks is default behavior in most of the contexts I can think of. In terms of programming environments, I already mentioned Go, but Express static file serving works this way too. I didn't try it out, but I also wouldn't be surprised if nginx and Apache work this way. As a final example, I will also point out that "follow symlinks" seems to be Deno's own philosophy, because --allow-read will also respect symlinks.
That said, my knowledge of the domain may not be the same as yours. Do you have examples or links to writeups that suggest that static file serving with symlinks is something that should be avoided in general?

It depends on the context I tend to avoid symlinks and http servers in general. What are the advantages of following symlinks? I've never heard of this being used in static file server. What is the use case?

I've just stumbled upon a frankly fringe usecase:
https://resium.reearth.io/installation
I managed to get it to work in fresh up until the point resium wants to fetch stuff from cesium under the /cesium path.

I tried to fix this by making a symlink (like described in the installation guide above for Next.js) for<EMAIL_ADDRESS>in static/cesium, but yeah, it obviously doesn't work because fresh doesn't support symlinks (at least for static assets, I guess?).
The workaround I'll try is copying the files over in my deno dev task before it starts fresh, as that's also apparently the recommended solution for webpack users of resium.
But yeah, I agree with @jeffomatic that fresh should support symlinks here, but obviously as an opt-in flag. Or, could something like this be implemented in a fresh plugin?

+1 for symlink support. (why not make it possible to opt-in in the .static() method?)

Please support symlinks, I just hit this issue, and wasted a couple of hours trying to work out why it wasn't working, it not occuring to me that something that every single web server I used previously used has supported.
It would be great if security arguments against are referenced with actual use cases.
There are lots of use cases for using symlinks. I don't understand the security implications: I control the code, the server, the deployment. Symlinks can be used when copying is more work, and copying can lead to stale files.


decouple gc worker from Storage

Question
I find that the Storage only bypass async_gc function to GC worker for outside GC, so I think it is better to decouple GC worker from Storage and let outside call GC worker directly.
This can simplify Storage dependence because GC worker depends on raftstore. Maybe this can decrease compiling time too.

Hi,I'm new in tikv :).
Does this mean we should move the GCWorker from  Storage to Service, and call it directly in future_gc ?

Thanks @FateTHarlaown
Mostly it is 'Yes', you can have a try.
You can ask @MyonKeminta for help if necessary.

@MyonKeminta  I meet some problems and myabe need some advice....
The GCWorker was definded in src/storage/gc_worker.rs. To decouple, I think the defination file  should be moved to src/server/service/ and inited  and called from Service, but the test test_storage_gcworker_busy was write together with Storage in tests/failponts/cases/test_storage.rs. I'm not sure how to deal with these cases, maybe create a new test file?

@FateTHarlaown Thansk for your help! Feel free to create new file for it, since it's not suitable for any existing files.

@FateTHarlaown There seems to be an mistake. GCWorker can be moved to src/server but not src/server/service, since src/server/service contains only gRPC services, and GCWorker is an inner module. Please note it.

@MyonKeminta Thanks. I realized I made a mistake when I want to move it.......

@FateTHarlaown The structure of the config is being changed in another PR. I suggest you don't change config for now, and leave it for our further work.

@MyonKeminta I found SyncTestStorage also called Storage:: async_gc in SyncTestStorage::gc. At fist, I thougt it was also a kind of  Storage(for test)  and try to move gc outside，but I found it was depended by many tests  and I must change a lot to do this . I don't how to deal with  SyncTestStorage, mybe just add GCWorker member to it，and directly GCWorker rather its Storage member ?

If it's hard to remove SyncTestStorage::gc, I think it's ok to add GCWorker member to SyncTestStorage. At least I think it's ok in your first PR (to reduce the PR's size). If necessary, we can continue refactoring SyncTestStorage later.

@MyonKeminta I found it can't pass the test test_client_stop. I have no idea about the reason ,  so I check out  master branch, but it failed  again. Does this case has some requirements for my local environment?

@overvenus PTAL about the failing test

Hi @FateTHarlaown
The test failed due to receive request timeout, usually it should be fast, less than 100ms. I don't have any idea why it fails, could you paste the test log?

@overvenus Thanks a lot for your help!
I run make dev in master branch, git status is
 ~/src/tikv   master ⍟1  git status                                                                                 2 ↵  10:23:10
On branch master
Your branch is up to date with 'origin/master'.

nothing to commit, working tree clean

make dev output is
 ~/src/tikv   master ⍟1  make dev                                                                                 SIGPIPE(13) ↵  10:28:06
info: component 'rustfmt' for target 'x86_64-apple-darwin' is up to date
info: component 'clippy' for target 'x86_64-apple-darwin' is up to date
    Finished dev [unoptimized + debuginfo] target(s) in 0.72s
export DYLD_LIBRARY_PATH=":/lib" && \
	export LOG_LEVEL=DEBUG && \
	export RUST_BACKTRACE=1 && \
	cargo test --no-default-features --features " jemalloc sse failpoints" --all  -- --nocapture && \
	cargo test --no-default-features --features " jemalloc sse failpoints" --all --bench misc  -- --nocapture  && \
	if [[ "`uname`" == "Linux" ]]; then \
		export MALLOC_CONF=prof:true,prof_active:false && \
		cargo test --no-default-features --features " jemalloc sse failpoints,mem-profiling"  --bin tikv-server -- --nocapture --ignored; \
	fi
    Finished dev [unoptimized + debuginfo] target(s) in 0.43s
     Running target/debug/deps/backup-e8071beaaab64e1c

running 9 tests
test endpoint::tests::test_cancel ... ok
test endpoint::tests::test_scan_error ... ok
test endpoint::tests::test_adjust_thread_pool_size ... ok
test endpoint::tests::test_seek_range ... ok
test endpoint::tests::test_thread_pool_shutdown_when_idle ... ok
test writer::tests::test_writer ... ok
test endpoint::tests::test_handle_backup_task ... ok
thread 'service::tests::test_client_stop' panicked at 'called `Result::unwrap()` on an `Err` value: Timeout', src/libcore/result.rs:1165:5
stack backtrace:
   0: backtrace::backtrace::libunwind::trace
             at /Users/vsts/.cargo/registry/src/github.com-1ecc6299db9ec823/backtrace-0.3.35/src/backtrace/libunwind.rs:88
   1: backtrace::backtrace::trace_unsynchronized
             at /Users/vsts/.cargo/registry/src/github.com-1ecc6299db9ec823/backtrace-0.3.35/src/backtrace/mod.rs:66
   2: std::sys_common::backtrace::_print
             at src/libstd/sys_common/backtrace.rs:47
   3: std::sys_common::backtrace::print
             at src/libstd/sys_common/backtrace.rs:36
   4: std::panicking::default_hook::{{closure}}
             at src/libstd/panicking.rs:200
   5: std::panicking::default_hook
             at src/libstd/panicking.rs:214
   6: std::panicking::rust_panic_with_hook
             at src/libstd/panicking.rs:477
   7: std::panicking::continue_panic_fmt
             at src/libstd/panicking.rs:384
   8: rust_begin_unwind
             at src/libstd/panicking.rs:311
   9: core::panicking::panic_fmt
             at src/libcore/panicking.rs:85
  10: core::result::unwrap_failed
             at src/libcore/result.rs:1165
  11: core::result::Result<T,E>::unwrap
             at /rustc/c6e9c76c59e3c10acd63ca9ec157a8894ea1a068/src/libcore/result.rs:933
  12: backup::service::tests::test_client_stop
             at components/backup/src/service.rs:149
  13: backup::service::tests::test_client_stop::{{closure}}
             at components/backup/src/service.rs:107
  14: core::ops::function::FnOnce::call_once
             at /rustc/c6e9c76c59e3c10acd63ca9ec157a8894ea1a068/src/libcore/ops/function.rs:227
  15: <alloc::boxed::Box<F> as core::ops::function::FnOnce<A>>::call_once
             at /rustc/c6e9c76c59e3c10acd63ca9ec157a8894ea1a068/src/liballoc/boxed.rs:922
  16: __rust_maybe_catch_panic
             at src/libpanic_unwind/lib.rs:80
  17: std::panicking::try
             at /rustc/c6e9c76c59e3c10acd63ca9ec157a8894ea1a068/src/libstd/panicking.rs:275
  18: std::panic::catch_unwind
             at /rustc/c6e9c76c59e3c10acd63ca9ec157a8894ea1a068/src/libstd/panic.rs:394
  19: test::run_test::run_test_inner::{{closure}}
             at src/libtest/lib.rs:1413
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.
test service::tests::test_client_stop ... FAILED
test endpoint::tests::test_busy ... ok

failures:

failures:
    service::tests::test_client_stop

test result: FAILED. 8 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out

I can't find some information about the reason.

@overvenus  I fetched the latest master branch and moved the repo to a ubuntu pc, then it passed the tests. It seems that this was caused by my local mac os environment(though I have not find the reason...).

@FateTHarlaown
It occurred to me that the timeout may be caused by the env var http_proxy!
$ http_proxy=http://<IP_ADDRESS>:1234 cargo test -p backup
    Finished dev [unoptimized + debuginfo] target(s) in 0.25s
     Running /home/stn/tikv/target/debug/deps/backup-819e20533e8a5c6b

running 9 tests
test endpoint::tests::test_adjust_thread_pool_size ... ok
test endpoint::tests::test_cancel ... ok
test endpoint::tests::test_handle_backup_task ... ok
test endpoint::tests::test_scan_error ... ok
test endpoint::tests::test_seek_range ... ok
test endpoint::tests::test_thread_pool_shutdown_when_idle ... ok
test endpoint::tests::test_busy ... ok
test service::tests::test_client_stop ... FAILED
test writer::tests::test_writer ... ok

failures:

---- service::tests::test_client_stop stdout ----
thread 'service::tests::test_client_stop' panicked at 'called `Result::unwrap()` on an `Err` value: Timeout', src/libcore/result.rs:1165:5
stack backtrace:
   0: backtrace::backtrace::libunwind::trace
             at /cargo/registry/src/github.com-1ecc6299db9ec823/backtrace-0.3.35/src/backtrace/libunwind.rs:88
   1: backtrace::backtrace::trace_unsynchronized
             at /cargo/registry/src/github.com-1ecc6299db9ec823/backtrace-0.3.35/src/backtrace/mod.rs:66

You can try unset http_proxy before running make dev.


[Event Change Request] codeunit 63  "Sales-Explode BOM" - multiple publishers

Hello, would it be possible to add OnExplodeBOMCompLinesOnAfterToSalesLineInsert2 event to codeunit 63  "Sales-Explode BOM", like this:
There is an existing event OnExplodeBOMCompLinesOnAfterToSalesLineInsert( that has been updated with additional parameters.
    local procedure ExplodeBOMCompLines(SalesLine: Record "Sales Line")
...
                  OnInsertOfExplodedBOMLineToSalesLine(ToSalesLine, SalesLine, FromBOMComp, SalesHeader, LineSpacing);

                 ToSalesLine.Insert();
                 OnExplodeBOMCompLinesOnAfterToSalesLineInsert(ToSalesLine, SalesLine, FromBOMComp, SalesHeader);
//Existing->                OnExplodeBOMCompLinesOnAfterToSalesLineInsert(ToSalesLine, SalesLine, FromBOMComp, SalesHeader);
>                 OnExplodeBOMCompLinesOnAfterToSalesLineInsert2(ToSalesLine, SalesLine, FromBOMComp, SalesHeader, NextLineNo); //New Event

                 ToSalesLine.Validate("Qty. to Assemble to Order");

                 if (ToSalesLine.Type = ToSalesLine.Type::Item) and (ToSalesLine.Reserve = ToSalesLine.Reserve::Always) then

      [IntegrationEvent(false, false)]
//Existing->    local procedure OnExplodeBOMCompLinesOnAfterToSalesLineInsert(ToSalesLine: Record "Sales Line"; SalesLine: Record "Sales Line"; FromBOMComp: Record "BOM Component"; SalesHeader: Record "Sales Header")
     local procedure OnExplodeBOMCompLinesOnAfterToSalesLineInsert2(ToSalesLine: Record "Sales Line"; SalesLine: Record "Sales Line"; FromBOMComp: Record "BOM Component"; SalesHeader: Record "Sales Header"; var NextLineNo: Integer)
     begin
     end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 53874.


Add sw:admin:login for instant backend login

1. Why is this change necessary?
It is not necessary. This is merely for convenience.
2. What does this change do, exactly?
A new command is introduced to the CLI: sw:admin:login
It generates a one-time-password for a backend user that is valid for 30 seconds. The username and the generated password are composed into a url to the backend login controller.
3. Describe each step to reproduce the issue or behaviour.

Run sw:admin:login in CLI.
Open the link.
You are now logged into the backend 🚀

4. Please link to the relevant issues (if any).
None.
5. Which documentation changes (if any) need to be made because of this PR?
I don't know.
6. Checklist

[ ] I have written tests and verified that they fail without my change
[x] I have squashed any insignificant commits
[x] This change has comments for package types, values, functions, and non-obvious lines of code
[x] I have read the contribution requirements and fulfil them.

We decided to close this PR because of time constraints and limited overall benefit to the product. If this change is still important to you, please create a new issue on https://issues.shopware.com so people can up-vote this feature.
For more information about our contribution guidelines, see https://developers.shopware.com/contributing/contribution-guideline/.


Socket.io shouldn't use ws < 0.7 in any of its depedencies (recursively)

At least on Linux  with v0.10.25. ws throws nasty errors such as the following:
"
/home/pskocik/.node/lib/node_modules/instant-markdown-d/node_modules/socket.io/node_modules/engine.io/node_modules/ws/lib/Receiver.js:290
if (mask != null && buf != null) bufferUtil.unmask(buf, mask);
"                                              ^
Socket.io still  depends on these old versions of ws via engine.io-client, which depends on engine.io 1.5.1, which brings dependencies on old ws's.. From my command line:
pskocik@ProBook:~/repos/socket.io (master *=)
$ find . -name package.json -exec grep '"ws":' {}    ;
"ws": "0.7.1",
"ws": "0.4.x"
"ws": "0.6.5",
pskocik@ProBook:~/repos/socket.io (master *=)
$ find . -name package.json -exec grep '"ws":' {} -l   ;
./node_modules/engine.io/package.json
./node_modules/socket.io-client/node_modules/engine.io-client/node_modules/ws/wscat/package.json
./node_modules/socket.io-client/node_modules/engine.io-client/package.json

This is actually identical to #1606 . Could we please get this fixed?

it has already been fixed, thanks.


no bug but a request .

What happened?
@camenduru there is no issue but there is a request ,when you are going to update the sage maker there are some people using it right .love your work bro .so please update the sage-maker repository
Colab cell output
.

Which colab and model(s) were you using when the error occurred?
.
Which Public WebUI Colab URL were you using when the error occurred?
remote.moe
If you used HiRes mode when the error occurred, please provide the Hires info
.

maybe solved please check our discord


403 Forbidden in a new project

Describe the bug
I installed the platform to new Laravel project by reading the documentation (successfully installed), but after logging for entering to admin panel I have got the error 403 forbidden .
Screenshots(Google Disk) and I don`t touch other files, besides user migration, seeder and factory
Desktop (please complete the following information):

OS: Windows 10 x64
Browser Yandex
Browser Version latest
OS Version: 21H1

Server (please complete the following information):

Platfrom Version: 12.0
Laravel Version: 9.1
PHP Version:  8.1
Database:  MySql
Database Version:  8.0

I am having the same issue, any solutions?

Okay, I had to debug the package itself and I found out you need to set a role and add the role to the roles table, and set up the permission and the relationship. it doesn't automatically happen when you  add a user

Okay I found a seeder(OrchidDatabaseSeeder) but it doesn't mention the documentation

Hi @spmsupun It's all right. When executing a command, the user is allocated individual permissions. You don't have to add roles. I can assume that your inherited model does not have a cast property:
/**
 * The attributes that should be cast to native types.
 *
 * @var array
 */
protected $casts = [
    'permissions'          => 'array',
    //...
];

ahh yeah,it works. I wished I had known this before I went through all the trouble 😅


elastalert does not create documents in the index elastalert_status and no alerts seem to trigger?

How do i know if it loaded my rules when running it?
The elastalert_status index is empty and im using the following command python -m elastalert.elastalert --verbose --config /etc/elastalert/config.yaml.
The file /etc/elastalert/config.yaml contains the row rules_folder: /etc/alestalert/rules and that folder contains 9 yaml files. the output i get in the console is:
python -m elastalert.elastalert --verbose --config /etc/elastalert/config.yaml
INFO:elastalert:Sleeping for 299 seconds
INFO:elastalert:Sleeping for 299 seconds
INFO:elastalert:Sleeping for 299 seconds
...

Im using the ES5 branch if that matters..
When i use elastalert-test-rule with the same config and a specific rule they work as intended..
What am i missing?

rules_folder: /etc/alestalert/rules Is that a typo in the github issue or the actual file?

Im unsure what you are asking so ill just post my config.yaml
config.yaml
# This is the folder that contains the rule yaml files
# Any .yaml file will be loaded as a rule
rules_folder: /etc/alestalert/rules

# How often ElastAlert will query Elasticsearch
# The unit can be anything from weeks to seconds
run_every:
  minutes: 5

# ElastAlert will buffer results from the most recent
# period of time, in case some log sources are not in real time
buffer_time:
  minutes: 15

# The Elasticsearch hostname for metadata writeback
# Note that every rule can have its own Elasticsearch host
es_host: localhost

# The Elasticsearch port
es_port: 9200

# Optional URL prefix for Elasticsearch
#es_url_prefix: elasticsearch

# Connect with TLS to Elasticsearch
#use_ssl: True

# Verify TLS certificates
#verify_certs: True

# GET request with body is the default option for Elasticsearch.
# If it fails for some reason, you can pass 'GET', 'POST' or 'source'.
# See http://elasticsearch-py.readthedocs.io/en/master/connection.html?highlight=send_get_body_as#transport
# for details
#es_send_get_body_as: GET

# Option basic-auth username and password for Elasticsearch
#es_username: someusername
#es_password: somepassword

# The index on es_host which is used for metadata storage
# This can be a unmapped index, but it is recommended that you run
# elastalert-create-index to set a mapping
writeback_index: elastalert_status

# If an alert fails for some reason, ElastAlert will retry
# sending the alert until this time period has elapsed
alert_time_limit:
  days: 2

# Email configuration
# unsure if this works, will have to test what smtp needs to work
smtp_host: "smtp.somewhere.com"
from_addr<EMAIL_ADDRESS>
# a list of email addresses to send alerts to
email:
-<EMAIL_ADDRESS>

@Qmando im blind thanks its a typo!


Fallback on response.rawRequest.header.Authorization for old browsers

Duplicate with #50 but for version 0.5.0.
It seems my grunt dist command has made many changes in the dist/stormpath.js file...

Thank you you for this PR.  I can confirm that with Firefox 20 the Authorization header is not read.  However this proposed change won't work:
var newToken = response.headers.authorization || response.rawRequest.headers.Authorization;

This is because response.rawRequest.headers.Authorization is referencing the header of the request, not the response.  We have to read the header of the response, as this header contains the new authorization token that must be used to authenticate the next request.
I will continue looking at this issue with Firefox 20 to see if there is a solution for reading the Authorization header, but I will close this PR as it does not solve the issue.

Good point.
I checked on the xhr modules to see if the fix can be done there but I'm not sure it's possible : it seems there is no work around to retrieve all headers when this bug happens, we can only retrieve a specific one ("Authentication" here).

Hey again, I was able to figure this one out!  I just published the fix as 0.5.2, can you update to this version and confirm that the problem with Firefox < 21 is solved?  The solution was to use xmlHttpRequest.getResponseHeader() to ask for a specific header, in stead of relying on all headers to be pulled from xmlHttpRequest.getAllResponseHeaders().  Thanks for finding this bug for us!

Hello @robertjd, thanks for the quick fix.
I tried the 0.5.2 version, unfortunately I think it breaks the login process (and maybe other actions).
With chrome, I have the following error Refused to get unsafe header "Authorization" and the referenced line seems to be your commit:
g = b.headers.authorization || b.rawRequest.getResponseHeader && b.rawRequest.getResponseHeader("Authorization")

I tried to use the 0.5.1 version for now, unfortunately our ID Site angular app has forked from yours and will require to be upgraded to be able to use the 0.5.1 version of stormpath.js.


CLOSE_WAIT with hdfs repository plugin

From @JasonBian on July 1, 2015 10:44
when I use hdfs-repository plugin to create snapshot,there is a issue: Cannot assign requested address, there are too many CLOSE_WAIT
Copied from original issue: elastic/elasticsearch#11971

@JasonBian Unfortunately there's no much we can do. The latest repository-hdfs (2.1.0) is more aggressive in closing the underlying HDFS FileSystem which in turn leaks the TCP connections that you see in the first place.
See #220 for more background info.

Closing the issue...

        thanks，I have changed the source code of the plugin and compiled it to fix the issue 发自网易邮箱大师
        在2015年10月29日 20:04，Costin Leau 写道:Closed #492.

—Reply to this email directly or view it on GitHub.

@JasonBian Is there a specific fix that you have applied? If it's part of the project you can simply download it as it is being deployed in maven with each release.


rpcmetatdata holds x-goog-request-params and google-cloud-resource-prefix

rpcmetatdata holds x-goog-request-params and google-cloud-resource-prefix. This is as per the approach 2 discussed in #190

Please rebase, do not merge, and let me know when it is ready for review again.

rebase with skip option, please review

Can you remind me what did we decide with respect to namespaces?

Argh... I meant unit tests.

i could see following in our discussion

For the integration tests: we can use an embedded server, like the one in the bigtable/benchmarks/ directory to verify the requests include the right metadata. But again, the unit tests kind of cover that, so maybe they would be redundant. I propose that your write the unit tests and then we decide.

I will create a new issue and will take it from there.

#347 created for unit tests with exmbedded server

Thank you for staying patient and hanging on through the long review and the last minute changes!


toObject() and toArray() yielding incorrect Month as Integer

Console outputs:
Mon Apr 09 2018 16:10:02 GMT-0400 (Eastern Daylight Time)
4/9/2018, 4:10:02 PM
240
Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/65.0.3325.181 Safari/537.36
2.18.1
Using either method toArray() or toObject() and getting back the wrong month.

Note that months are zero-indexed, so January is month 0.
https://momentjs.com/docs/#/get-set/month/
Please re-open if you have other questions.


RPM: Ostree changes 🚀

When running on Ostree base operation system, wrting to /var is not
allowed at all, and things like enable linger for flotta agent is
not possible.
At the same time creating folders for user flotta was difficult because
when running it flotta user is not in place yet.
With this change, flotta-agent rpm is compatible with ostree OS, in this
case Red Hat enterprise Linux for Edge.
The main changes are:

Adding sysusers.d file to enable users.
Adding /etc/tmpfiles.d config to create files based on systemd

Signed-off-by: Eloy Coto<EMAIL_ADDRESS>

Cool changes! Thanks! Can you please attach to commit msg or to PR link to documentation of this?


[bugfix]Unable to submit pipeline job pointing to a registered component

Description

add validation logic in component level in case that customer register an invalid component and then we will skip validation when job refer to a remote component
one case client side cannot handle is that customer use a remote component and also overwrite conf setting in job level, since we won't get remote component spec.

Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:

[x] The pull request does not introduce [breaking changes]
[ ] CHANGELOG is updated for new features, bug fixes or other significant changes.
[ ] I have read the contribution guidelines.

General Guidelines and Best Practices

[x] Title of the pull request is clear and informative.
[ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[ ] Pull request includes test coverage for the included changes.

API change check
API changes are not detected in this pull request.


Symlink Material Design Icons into Dart packages in the out dir

Otherwise they won't be visible to the web server.

lgtm


Investigate equations for steering logic

Complete when this issue has the information regarding steering logic posted here. Either directly or a link to a document describing the equation and algorithm.
Should provide steering logic for the following modes:

[ ] Translation Mode (also called crab mode)
[ ] Spin Mode
[ ] Drive Mode

Replaced by #139


[2.4] Extend kubectl agent deploy retries, improve log

Issue(s):

No logging available around clusterdeploy/kubectl actions
Randomly an error is seen during cluster provisioning when applying agent YAML

Solution:

Add (debug) logging on the clusterdeploy/kubectl actions
Extend retries and sleep for kubectl apply for agent YAML to give it a bit more time to be applied, also added logging (and redacted the token in the logging)

https://github.com/rancher/rancher/issues/24996


composer create-project namelesscoder/patternlab-fluid-edition thows InvalidArgumentException

Hi there,
After composer create-project namelesscoder/patternlab-fluid-edition thows
[InvalidArgumentException]
  Could not find package namelesscoder/patternlab-fluid-edition with stability stable.

Until a true 1.0.0 version is released you will have add -s dev to the composer create-project command. This allows dev stability as base for the project. Won't be necessary when the final release is made!

uhm, maybe could be good to have it in the readme until true 1.0.0 is released :D Thanks I will try it right away


mvp

true

This issue used for marketing, see https://gist.github.com/brianzelip/34c7ae7fae90122c45d624fb20aa670b.


[$250] Web - Scan - Selecting a receipt to be scanned is duplicated in the report

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 9.0.60-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5200040
Email or phone of affected tester (no customers<EMAIL_ADDRESS>Issue reported by: Applause Internal Team
Action Performed:
Preconditions:

User A as the workspace admin invites a new account as an employee

Log in with the new employee's account in incognito mode.
Go to WS as an employee, click on the "+" option
Click on the "Create an expense" feature.
Select a receipt to Scan.
Double-click on a receipt, which can be PDF or JPG.
Click on the "Submit Expense" button.
Upload a new receipt to be scanned to the WS with the normal process, click on open, and then on the submit expense button.

Expected Result:
It should take me to the WS chat and only one receipt selected for scanning should appear in the report.
Actual Result:
It does not take me to chat from the workspace where you uploaded the receipt likewise the same receipt appears twice in the report, and it shows a debt of 0.00 in the WS Chat.
Workaround:
Unknown
Platforms:

[ ] Android: Standalone
[ ] Android: HybridApp
[ ] Android: mWeb Chrome
[ ] iOS: Standalone
[ ] iOS: HybridApp
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
https://github.com/user-attachments/assets/6e22ffed-3e37-4a02-b367-ab9543653a0a

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021859546008607352773
Upwork Job ID:<PHONE_NUMBER>607352773
Last Price Increase: 2024-11-21

Issue OwnerCurrent Issue Owner: @mananjadhav

Oh ok, I think I might get it now. I'll update the bug report, though I think this is saying that QA was able to get two individual expense previews to show, when there should have been just one.

Still waiting on proposals

Waiting on proposals. Commenting as it shows overdue on me.

Hi, I'm Viktoryia from Callstack - expert contributor group - and I would like to work on this issue.

I've followed the test steps and wasn't able to reproduce the issue:
https://github.com/user-attachments/assets/edf857b1-be7c-4fd9-b859-d3d389f9e1d4
Do I miss anything?

Issue not reproducible during KI retests. (First week)

Looks like it isn't reproducible anymore?

Closing in that case.


ALS007 Alignment vertical shape representation

ALS007 restricts representation to a gradient curve.
However, in the Alignment documentation it notes that several types of curves might be used for geometric representation (refer Geometric perspective)
https://ifc43-docs.standards.buildingsmart.org/IFC/RELEASE/IFC4x3/HTML/lexical/IfcAlignment.htm
I would request that this check also permit  the vertical alignment representation be an indexed poly curve or polyline (which I'm reverting to when
an alignment has transition segments that are not supported in IFC.
I've attached a test file that presently fails. Note that the horizontal passes using the indexed polycurve.
00_LRT_BIM-Station_Platform edge_dummyNB.zip

Interesting angle. And thanks for the example file. A few thoughts, but I'd like to hear from @peterrdf @civilx64 @RickBrice @JanErikHoel and others implementing alignment.

I've always read the documentation as "these are all possible geometries that can be used to describe the alignment (curve)", and not so much one specific layout (in this case vertical) of the alignment. But indeed, docs might be too vague here. Should we improve it? Let's see how
I see the current concept template for vertical explicitly talks only of IfcGradientCurve. However, the current concept template for horizontal talks only of IfcCompositeCurve, while the Validation Service rule allows for other representations. Am I right @civilx64? Which one of the two: concept template missing, or documentation of IfcAlignment to be clarified
I understand you're reverting to polyline/curves when vertical transitions are not supported by IFC. Out of curiosity, which are these transitions?

On the one hand, for consistency, sure, we've been incrementally adding indexedpoly to other parts of the schema as well, such as polygonal bounded halfspace.
But the association to segments on the business logic side scares me a bit:

(a) Do we have to make abundantly clear than that one (indexed) poly is only intended to function as approximation within a single segment on the business logic?
(b) Or do we also envision multiple business segments being folded into a single polyline. Or what if there is no business logic? Is a polyline then equivalent to multiple linear segments? What about polyline of a single segment, is that equivalent to an IfcLine?

I would vote for (a)

In this particular example, it's an offset alignment.  So the transition segment is an "offset clothoid".  I'm not an expert in this, but it seems to me that an offset of a clothoid, is not another clothoid but would be a spline.
This causes other challenges in IFC, where we have IfcOffsetCurveByDistances but that would be for another discussion. (perhaps that should be constrained to only support specific segment types).
I personally do think that it's useful to have a footprint representation of the horizontal, and vertical.  If these are associated with the alignment, I would suggest they might be explicitly associated with vertical and horizontal elements (but I could accept that it is not permitted).
I would agree that it should somehow be nominated that the alignment was approximated, even informally.  There was a clear stance that IFC would only support a limited, standard set of transitions.  However there is still a value to being able to exchange or visualize alignments beyond this, which I believe is why indexed polycurves are documented as a valid representation.
I don't think the suggestion of a works by Thomas, there is no userdefined enumeration possible within https://ifc43-docs.standards.buildingsmart.org/IFC/RELEASE/IFC4x3/HTML/lexical/IfcAlignmentHorizontalSegmentTypeEnum.htm
At the moment, there is no business logic in my provided file for the horizontal for that reason.  But perhaps it's better to turn a transition segment into multiple linear segments (denominating somehow that these multiple linear segments to approximate a singular transition).  The length of the horizontal alignment would deviate from the original alignment, but perhaps it's within tolerance.

@jmirtsch Thanks for raising this issue.
There is a lot to unpack here.
And we need to be very specific in our terminology so that there is clarity on whether we are discussing the entire overall alignment as a whole; a horizontal, vertical, or cant layout; or an individual segment within one of those layouts.
Likewise any discussion of entity type for representation needs to be specific about which semantic entity type it is representing.
That said, here goes:

I would request that this check also permit the vertical alignment representation be an indexed poly curve or polyline (which I'm reverting to when
an alignment has transition segments that are not supported in IFC.

IfcGradientCurve is the only valid class for representation of IfcAlignmentVertical.
This is because its coordinates and directions are defined in the (distance along, height) parameter space.
This information is abstract and shapeless unless these coordinates and directions are transferred onto a horizontal footprint.
IfcGradientCurve does this via the ParentCurve attribute, which is not available on indexed poly curve or polyline.

I've always read the documentation as "these are all possible geometries that can be used to describe the alignment (curve)", and not so much one specific layout (in this case vertical) of the alignment.

Absolutely correct: IfcIndexedPolyline and IfcIndexedPolyCurve are valid as representations of IfcAlignment but not for IfcAlignmentHorizontal, IfcAlignmentVertical, or IfcAlignmentCant.

However, the current concept template for horizontal talks only of IfcCompositeCurve, while the Validation Service rule allows for other representations. Am I right @civilx64? Which one of the two: concept template missing, or documentation of IfcAlignment to be clarified

I believe that ALS006 is currently incorrect and should only allow IfcCompositeCurve as representation of IfcAlignmentHorizontal.  However that is not explicitly spelled out in documentation for IfcAlignmentHorizontal or any of the concept templates:
<IP_ADDRESS>.1 correctly lists polyline and indexed poly curve as valid for IfcAlignment.
The following three concepts <IP_ADDRESS>.1.1, .2, and .3 tie IfcCompositeCurve, IfcGradientCurve, and IfcSegmentedReferenceCurve to horizontal, vertical, and cant layouts, respectively but they are denoted as representations of IfcAlignment.
What is missing are three concept templates to further clarify IfcCompositeCurve, IfcGradientCurve, and IfcSegmentedReferenceCurve as representations of IfcAlignmentHorizontal, IfcAlignmentVertical, and IfcAlignmentCant, respectively.
Associating these representations to the alignment layouts in a 1:1 manner is much cleaner (IMO) than having multiple representations on IfcAlignment - especially when there is re-use of a horizontal layout with multiple
vertical layouts.
The current state of these concept templates corresponds to what I have personally noted in practice - representations associated to IfcAlignment and to the segments, but not to the layouts.
Up until now I had no idea why this might have happened but now it seems to correspond to the documentation and not be a random coincidence.

(a) Do we have to make abundantly clear than that one (indexed) poly is only intended to function as approximation within a single segment on the business logic?

The indexed poly is required for segments that don't fit within the domain of enumerated types for transitions.
Therefore it is impossible to associate this category of segment to a single business logic segment because it would not correspond to any available values for IfcAlignmentHorizontalSegmentTypeEnum, IfcAlignmentVerticalSegmentTypeEnum, or IfcAlignmentCantSegmentTypeEnum.
So by extension, one (indexed) poly can only represent IfcAlignment - not any of the layouts and not any of the segments.

(b) Or what if there is no business logic?

These situations actually require that there is no business logic for the H, V, and C layouts - and by extension their constituent segments.
In other words, there is to be no IfcAlignmentHorizontal, IfcAlignmentVertical, or IfcAlignmentCant nested under IfcAlignment.
And that is why @jmirtsch has (correctly IMO) headed down the path of not having business logic in these cases.

However there is still a value to being able to exchange or visualize alignments beyond this, which I believe is why indexed polycurves are documented as a valid representation.

I agree on both points and re-emphasize that these classes are valid for representation of IfcAlignment only.

The length of the horizontal alignment would deviate from the original alignment, but perhaps it's within tolerance.

This could be addressed by providing IfcReferents at various intervals along the polyline or poly curve approximation that correspond to the actual distance along the original alignment.
This is a common practice in GIS where a "measure" value associated to a given point on a polyline geometry is not exactly equal to the calculated accumulated distance along the linear reference.

Pausing a bit to reflect on my experience in industry - this discussion agrees with how authoring tools are used in practice where features offset from a "pure" alignment are still referred to as alignments - because they carry the concept of defining sweeps and placements based on distance along - but do not correspond to exact segmental constructs of line, circular arc, clothoid, etc.  Correlating to IFC schema, these offset alignments would best be exchanged as IfcAlignment with 2D or 3D polyline / polycurve geometry with no business logic or definition of individual segments.

I'm not an expert in this, but it seems to me that an offset of a clothoid, is not another clothoid but would be a spline.

correct - there is not a parallel clothoid in the same way there is a parallel circle.
Sorry I haven’t fully engaged in the discussion. I’ve been traveling.

@civilx64 has done a great job breaking this down. My read is that poly line is for approximations of IfcAlignment when the full detail is not available.

greater interoperability for alignments is achieved via polyline & polycurve than IfcOffsetCurveByDistances.

Why is this the case? IfcOffsetCurveByDistances Is ultimately tied to an IfcGradientCurve which should have good interoperability. I’ve been computing points on the offset curve by evaluating the BasisCurve then applying the offsets.
There are some issues with the application of IfcOffsetCurveByDistances as discussed here https://github.com/buildingSMART/IFC4.x-IF/issues/139
what vertical transition curve is missing?

An importing application does not need to do any calculations when importing polyline or polycurve because the (x, y, z) coordinates of the shape are explicitly provided.  With IfcOffsetCurveByEdges an importing application needs to be able to calculate these points along an alignment.
This is similar to industry experience with exchanging surface data via LandXML.  A surface can be defined via its SourceData or its Definition. The SourceData represents the collection of data used to generate the surface, whereas the Definition contains the faces and points that define the surface.
An Information Exchange involving LandXML surfaces containing SourceData only requires the receiving application to be able to compute the corresponding constrained Delauny triangulation.  Experience has shown that each vendor implements this slightly differently, particularly when it comes to trimming triangles at the boundary.  Conversely, exchanging the Definition ensures that the receiving application will load the exact same number of triangle faces with the exact same coordinates as the authoring tool.
There is certainly some of my personal opinion sneaking in here but I see it as "wider range of applications able to import the data = greater interoperability".

Good discussion. Let me first only answer the last part from @civilx64. If I understand it correctly it is the choice between SourceData (in my words design intent) and Definition (generated mesh / poly line). Really good point as I think there are different opinions in what IFC should carry. My personal opinion is that IFC should (only) carry SourceData, two main reasons: (in my perception the Definition is purely a interpretation of the used application of the essence of geometrical content, I agree this is almost always different for each individual application but I don't see an issue in this): 1. the non-geometrical semantics is also SourceData (I see this as the key purpose of IFC itself, i.e. an integrated snap-shot of the geometrical and non-geometrical source data) 2. there are many other formats that solved the problem of exchanging Definition (Collada, glTF, OBJ, OpenUSD), they can do this much better than IFC is capable of doing.
I know many poeple see this different and would like to see IFC moving into exchanging Definition data for geometry. In my perception like an bsDD + instantiation + existing 'simple' geometry exchange format. I am clearly not in favor of this road and would see IFC fanishing into more general / widespread formats this way, a pity as there is great value in domain wide agreement of a baseline ofa format specification for exchanging SourceData (with highly semantical non-gteometrical and geometrical definition).

Since Evandro asked me for feedback in the the comment far up, I pitch in a couple of comments:

The alignment is of course THE most important geometry element for infrastructure. For some projects, like rural roads e.g., the alignment geometry doesn't need to be 100 accurately represented in the construction software at site (could be represented as polyline consisting of small straight segments e.g.). But for other projects, like high speed railway e.g., the alignment geometry representation in the construction software need to be 100% correct everywhere, for all "three dimensions": Horizontal, vertical, Cant, including all points along transition curves. For the high accuracy use cases, we can't risk that the receiving software at site interpret the alignment source data differently than the design software. I therefore think is is important that IFC has the possibility to carry also the accurate geometry definition, including all transition curve types.

If map conversion is involved, we have the same situation as for offset: A clothoid is not a clothoid anymore e.g.. But this is probably handled/covered by the map conversion concepts in IFC?

Hi @JanErikHoel, sorry to dive into details directly :-) Just triggering on your comment 'we can't risk that the receiving software at site interpret the alignment source data differently than the design software' that I of course fully agree with from a conceptual point of view.
I think there are two versions of this statement:

we need a polyline or other segmented solution (maybe as alternative representation) to be sure the receiving application uses exactly the same (offset) curve to cover for inconsistencies in the standard / documentation and potential issues in the different implementations (note that 'tilt' is currently not able to be carried by a polyline)
different software will most probably differently apply segmentation (and minor always existing inconsistencies in end / start points of segments) to semantic curve types like Clohoid's and higher order Spirals or even circle segments etc.

The second statement means that when defining semantic geometry definitions as we do now for transition curve geometry almost always will generate slightly different geometry looking at two different applications. In my perception this is not an issue, but maybe I am wrong.
The first statement is a very good point but I am not sure we are talking about this here. Maybe we should think of adding an alternative 'measured representation' or 'calculated representation'?


download or scroll button for scan reports

After doing a particular scan the report is incomplete and cant be scrolled. A download button to download the complete scan or maybe a scrollable button will be helpful.

Can you provide a screenshot where you could not scroll it?

@soumdatta81  browsing to http://localhost:8080/api/helm/charts will giver you a JSON representation of the charts installed
you will need to set a x-kubecontext: header if you have multiple kubectl context
you can list the context form a helm-dashboard point of view by browsing to
http://localhost:8080/api/kube/contexts

I see scrolls for scan results. Closing this as invalid


Fix bundle install step on CI for TruffleRuby

Currently CI builds agains TruffleRuby 22.3.1 are failed on the bundle install step.
...
Fetching webrick 1.7.0
  Installing webrick 1.7.0
  Fetching yard 0.9.28
  Installing yard 0.9.28
  --- ERROR REPORT TEMPLATE -------------------------------------------------------

...
  NoMethodError: undefined method `full_name' for nil:NilClass
    /home/runner/.rubies/truffleruby-22.3.0/lib/mri/bundler/installer/parallel_installer.rb:124:in `block (2 levels) in check_for_unmet_dependencies'
    /home/runner/.rubies/truffleruby-22.3.0/lib/mri/bundler/installer/parallel_installer.rb:123:in `each'
    /home/runner/.rubies/truffleruby-22.3.0/lib/mri/bundler/installer/parallel_installer.rb:123:in `block in check_for_unmet_dependencies'
    /home/runner/.rubies/truffleruby-22.3.0/lib/mri/bundler/installer/parallel_installer.rb:122:in `each'
    /home/runner/.rubies/truffleruby-22.3.0/lib/mri/bundler/installer/parallel_installer.rb:122:in `check_for_unmet_dependencies'
    /home/runner/.rubies/truffleruby-22.3.0/lib/mri/bundler/installer/parallel_installer.rb:[100](https://github.com/omniauth/omniauth/actions/runs/3970157787/jobs/6805553917#step:3:106):in `call'
    /home/runner/.rubies/truffleruby-22.3.0/lib/mri/bundler/installer/parallel_installer.rb:71:in `call'
    /home/runner/.rubies/truffleruby-22.3.0/lib/mri/bundler/installer.rb:262:in `install_in_parallel'
    /home/runner/.rubies/truffleruby-22.3.0/lib/mri/bundler/installer.rb:209:in `install'
    /home/runner/.rubies/truffleruby-22.3.0/lib/mri/bundler/installer.rb:89:in `block in run'
    /home/runner/.rubies/truffleruby-22.3.0/lib/mri/bundler/process_lock.rb:12:in `block in lock'
    <internal:core> core/io.rb:670:in `open'

https://github.com/omniauth/omniauth/actions/runs/3970157787/jobs/6805553917
I assume that the issue is related to invalid/incorrect cached Gemfile.lock file as far as locally I cannot reproduce the issue.
Removing bundler-cache: true option in the TruffleRuby workflow solves the issue.
I tried also to invalidate cache with cache-version option (https://github.com/ruby/setup-ruby#dealing-with-a-corrupted-cache) but it seems it doesn't work as I expected. My attempts are available in a fork repository https://github.com/andrykonchin/omniauth.

Yeah, it's a downside.
But looks like installing dependencies without caching works faster than using a broken cache.
A job without caching (link) - installing dependencies takes 34 s.
Jobs with caching enabled (link, link, link) - take 57s, 57s and 1m 5s.
I will probably create a issue for setup-ruby - to clarify how cache-version is supposed to work as far as it would a proper solution here.

Ah, I forgot truffle Ruby has its own CI file, I'm fine with that in that case since it won't effect the other runtimes

Thank you!

@andrykonchin new errors in truffle, mind taking a look?

Failing specs (2 failed jobs) agains TruffleRuby 22.3.1 should be fixed by my another PR (https://github.com/omniauth/omniauth/pull/1105).

Failed job with truffleruby-head looks like a transient failure (it looks to me caused by concurrent access to Hash).


Camera zoom plugin is causing game crash when zooming too much

As reported in Discord, when zooming in with camera zoom enabled near Chambers Of Xeric, the game crashes (but without anything in log). The sidebar is still interactable so it is just applet exploding.
game-crash
sidebar-working
application.log

This is a crash from Rasterizer3D_zoom being set to 0 from the extended zoom in distance


Comment hide menu doesn't work

Reproduction:

Clicking on the three dots in a comment header and clicking on "Hide" (in a repo where you have write access)

No menu opens with the extension enabled.

L
O
L
We're breaking our own features. Hotfix coming to the stores soon.


faker-cli should be a separate gem

Checklist

[x] Invite @akabiru  to be collaborator of this repository
[x] Move original fakerbot repository to organization
[ ] Publish faker-cli as a separate gem
[ ] Grant admin access to @stympy, @akabiru, @vbrazo on Rubygems.org

@akabiru thanks 👍

Cheers Vitor, I have some time. I'll amend amend the namespaces shortly. 👍 🙂

I'm not able to push the gem to Rubygems.org. We'll need your help on that @akabiru
(base) VOLIVEIRA-MBP:faker-cli voliveira$ gem push faker-cli-0.4.5.gem
Pushing gem to https://rubygems.org...
You do not have permission to push to this gem. Ask an owner to add you with: gem owner faker-cli --add<EMAIL_ADDRESS>(base) VOLIVEIRA-MBP:faker-cli voliveira$ gem owner faker-cli --add<EMAIL_ADDRESS>Adding<EMAIL_ADDRESS>You do not have permission to manage this gem.

Hey Vitor,
Sure thing.
Will try and address this as soon as possible.
I’m afk but should have access in the next 24hrs.
Best,
On Sun, 7 Jul 2019 at 9:08 pm, Vitor Oliveira<EMAIL_ADDRESS>wrote:

I'm not able to push the gem to Rubygems.org. We'll need your help on that
@akabiru https://github.com/akabiru
(base) VOLIVEIRA-MBP:faker-cli voliveira$ gem push faker-cli-0.4.5.gem
Pushing gem to https://rubygems.org...
You do not have permission to push to this gem. Ask an owner to add you with: gem owner faker-cli --add<EMAIL_ADDRESS>(base) VOLIVEIRA-MBP:faker-cli voliveira$ gem owner faker-cli --add<EMAIL_ADDRESS>Adding<EMAIL_ADDRESS>You do not have permission to manage this gem.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/faker-ruby/faker-cli/issues/26?email_source=notifications&email_token=AED6ORZ32MH4SRGNLV5HFWLP6IWJFA5CNFSM4H6TR2U2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZLQKRA#issuecomment-509019460,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AED6ORZE2A4JRUTTFJAI3TLP6IWJFANCNFSM4H6TR2UQ
.

--
Austin Kabiru
Software Engineer / +254.714.665.734
Twitter: @akabiru_  GitHub: @akabiru

@vbrazo Looks like somebody alrealy owns faker-cli on ruby gems https://rubygems.org/gems/faker-cli
⋊> ~/p/a/faker-cli on master ◦ gem owner faker-cli                                  21:15:05
Owners for gem: faker-cli
-<EMAIL_ADDRESS>
Seems like we have to go with another name.
Some options off the top of my head:
1.) faker-cli-ruby - not as nice
2.) faker-bot - namespace Faker::Bot instead of Faker::CLI
3.)fakerbot (original name, I own this one)

@stympy which one would you prefer: fakerbot or faker-bot?

Let's do faker-bot.

@stympy @akabiru I've just granted access for your users on Rubygems.org. Now you can release new faker-bot versions.


[Cordova] Cordova build separate arch apks

It's fine to pack cordova apps

https://crosswalk-project.org/jira/browse/XWALK-5867

@haoyunfeix , @qiuzhong, please help to review it.

LGTM


Adding an overload to MockFileData that takes an object

I did this originally as PR 389 but this was rejected for the following reasons:
<... snip ...>
Thanks for your work, but I don't think this is something that needs to be in System.IO.Abstractions for the following reasons:

* the discoverability of the new overload is low, I wouldn't intuitively know what it does
* this is a low-level library for IO operations that should stay focused
* it is easy (and IMO more flexible) to do the serialization on top of S.IO.A
<... snip ...>
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

I was told to first start an issue if I wanted to contribute. So I will.

My first point would be, the discoverability would be covered by Intellisense the same as any other method in the TestingHelpers library. The PR contained a ///summary block, if that was lacking it can be changed but that's par for discoverability.

Secondly, this is NOT an add to System.IO.Abstractions. It is an add to the TestingHelpers library. Without things like this I am forced to wrap the wrapper. This seriously diminishes the use of TestingHelpers library.

Lastly, I thought the TestingHelpers library WAS on top of S.IO.A. So I'm at a loss to address this point. Is there something I'm not seeing?

FWIW, my view on this is that it's really a very application-specific thing to want to do.
If you're going to add support for binary object serialization, why isn't there the same thing for XML, JSON, protocol buffers, CSV, YAML, etc?
They're all arguably equivalent, and arguably used more these days than proprietary .NET serialisation. The reason why not is that this isn't the right layer at which to add such support, as it's really too domain-specific. Yes, it's obviously possible to do it, but it increases the surface area and maintenance effort of the API. If you use binary serialisation a lot it's not exactly hard to add an extension method that does this for you (and that you can use across all IFileSystem implementations).

Thanks for the feedback. I see what was meant now by "this is a low-level library for IO operations that should stay focused". I'm not used to thinking about "everyone that will use this, ever, for any reason".
This also gives me ideas on how to approach my object serialization.
Again, appreciate it.


Change Info On Page?

How Do I Change The Info On The New Tab

Do you mean the message gretting the user??
It changes based on time automatically.

I want to know how to change the username and websites, I changed the username and links, and the names of one of the categories and it dissapeared.

It also bricks the google search bar.

You should have pasted the code as text. The image makes it difficult to debug.
I think you should try removing the commas , at the end of line 12 & line 26.

@iisGmoney Can you also check if there are errors thrown by JS?
Just open developer tools using Ctrl+Shift+i and check the console.

Yup, index.html:1 Uncaught (in promise) SyntaxError: Unexpected token ] in JSON index.html : 1 at position 538.

Make the changes as suggested by @haideralipunjabi , the issue is because of those extra commas.

Thanks


Support for pluggable proxy layer

I was wondering what your views are in making the proxy layer pluggable which would allow me to use nginx instead of haproxy. I didn't want to prematurely start coding so wanted to hear your opinion first.
@igor47

@yagnik I've been pretty interested in that for a while. I started down that path with the config generators refactor, but I didn't finish the job. There are only really two blockers:

There is still some coupling between haproxy as the output format and the service watchers, but it should be straightforward to remove.
We'd have to make it ok to have 'nginx' or w.e. at the top level instead of just haproxy

Neither of these is tough, but it is tough to say "this works" without running it in production, and while I can't speak for airbnb I can say that we (Yelp) are reasonably happy with haproxy as the core routing component now that we figured out how to restart it without dropping traffic.

@jolynch what was your reason for using nginx instead of haproxy ?
The part that got me concerned is your post http://engineeringblog.yelp.com/2015/04/true-zero-downtime-haproxy-reloads.html which I believe is not a problem in nginx land cause process swapping doesn't happen. Is that the same reason you thought about using nginx ?

@yagnik Yes we considered switching to nginx due to the reload issue, especially as PaaSTA matured and we found out that SmartStack would be restarting HAProxy basically all the time.
However, since our zero downtime reload strategy shipped 8 months ago and we invested serious effort in performance tuning our HAProxy configs we've had relatively few problems with HAProxy itself. We're trying to work with the HAProxy maintainers to complement their currently supported dynamic changing of hostnames (in 1.6) with dynamic changing of ports, which would mean that we could theoretically pre-populate and then swap in and out as we get backends, although I'd still be worried about some of the stuff we can only do on reload. On the other hand Linux 4.4 will ship with a sweet refactor to the TCP SYN handling stack which will fix the 3WHS bug in Linux (causes most of HAProxy's dropped packets with SO_REUSEPORT) and if Eric and co. can figure out this patch then HAProxy will be 100% hitless on a reload.
I guess what I'm trying to say is that we've spent a lot of effort finely tuning HAProxy for high availability and performance, so investing in nginx seems like a hard move for us especially when Linux might finally fix their SO_REUSEPORT implementation. It's worth noting that "switching to nginx" isn't a silver bullet. Nginx is still a relatively young load balancer (i.e. just recently gained the capability to load balance TCP in the open source version, last I checked healthchecks are still part of nginx+ only, etc ...), and there is no guarantee that it won't have some other show stopping problem.
All that being said, I'd love if there was a nginx output format for Synapse, it's just hard for me to find time to work on it, but I'd be happy to help in any way I can.

thanks @jolynch sorry about the delayed reply. Also curious do you guys use chef/puppet for continuous  deployment to all nodes for synapse/nerve ? How do you guys manage versioning in that case ?
In the mean time I'll pull away some time for getting nginx support, wait for my pr :)

@yagnik Yea we basically build debian packages of synapse nerve, synapse-tools and nerve-tools using Docker. We have some glue puppet modules that tie together a synapse and nerve puppet module which basically install the aforementioned packages and setup cron jobs to run the jobs from synapse-tools and nerve-tools.
One of these days we'll get our act together and make a "how to smartstack at scale" website or something with a single binary you can curl and pipe to ba^H^H... I mean a debian package or something.

Never got around to doing this and we went ahead with haproxy too and now haproxy doesn't have a reload issue: https://www.haproxy.com/blog/truly-seamless-reloads-with-haproxy-no-more-hacks/ so happy with that.
As an aside we ended up building an rpm using omnibus: https://github.com/yagnik/omnibus-smartstack and use dendrite:https://github.com/yagnik/dendrite to build nerve and synapse config.
Going to close this issue for now.

Thanks for all the help @jolynch !

@yagnik oh also fwiw Synapse supports this now through config generators :-)
See the readme for how to do it and https://github.com/jolynch/synapse-nginx for an example of a proxy plugin.

:+1:


return data

my app is not returning the data below.
smiling":0,"eulerX":0,"rightEyeOpen":0,"leftEyeOpen":0,"id":0,"eulerY":0,"eulerZ":0,
the rest works just fine.
{"data":[{"smiling":0,"eulerX":0,"rightEyeOpen":0,"leftEyeOpen":0,"id":0,"eulerY":0,"eulerZ":0,"points":[{"x":367.5,"y":165.625},{"x":330,"y":158.125},{"x":256.875,"y":154.375},{"x":200.625,"y":165.625}, ....

Try adjusting the following start function options values.
・landmarks
・classification
・faceTrack
・contour


Refinery 1.6.0 Docker image fails to start without arguments

Versions

Refinery: 1.6.0 (Docker image)

Steps to reproduce

Create refinery.toml and rules.toml in a subdir called conf
Run docker run -v $(pwd)/conf:/etc/refinery honeycombio/refinery:1.6.0
The container exits immediately with an error message:

$ ls conf/
refinery.toml  rules.toml
$ docker run -v $(pwd)/conf:/etc/refinery honeycombio/refinery:1.6.0
command line parsing error - call with --help for usage
$

Additional context
In 1.5.2, the container started with no arguments:
$ docker run -v $(pwd)/conf:/etc/refinery honeycombio/refinery:1.5.2
time="2021-11-10T15:45:45Z" level=info msg="using specific identifier from config" identifier=<IP_ADDRESS>
time="2021-11-10T15:45:46Z" level=info msg="Peer list has changed. New peer list: [http://<IP_ADDRESS>:28957 http://<IP_ADDRESS>:22052 http://<IP_ADDRESS>:12346]"
...

Thank you for reporting @martinmcnulty! We'll get this fixed up.

Hey @martinmcnulty - we released v1.6.1 with a fix. Let us know if you have any more issues.

Looks good! Thanks!


add a flag mechanism for FE to control all BEs' behaviour

Is your feature request related to a problem? Please describe.
Now, Doris lack a mechinism for FE to control all BEs. To solve the issue #2245 's  problem No.2, we need a ability like this to set all BE's default rowset type and compaction rowset type. This mechanism can also be used for other purposes.
Here my basic design:

add a field(maybe use binary format for extensible) in heartbeat message between FE and BE
treat the flag field as bitmap, different bit stands for different function.
add a http request to set the flag in FE
BE can parse the flag to do the different functions.

There are two flag bits for Issue #2245, one for set the default rowset type to BETA; one for set the default compaction type to BETA.

set default rowset type to beta, just use the set command as following:
set GLOBAL heartbeat_flags = 1;
or
set GLOBAL heartbeat_flags = SET_DEFAULT_ROWSET_TYPE_TO_BETA;


Issue with buffering every second

First of all thanks for this integration.
I have two unifi RTSP streams in my Home Assistant UI. When I enable webrtc on them, they stream perfectly but without any sound. If I disable webrtc, I get sound but every second or so I see a spinning circle and after a few seconds of spinning I see a few new frames. This is on my OnePlus Android phone with the Home Assistant app. On my desktop Chrome this mode works perfectly, there is sound and no spinning circle (buffering). I require audio though...
Is there a way maybe to increase the buffer size to prevent this? Or could something else be causing this?

I tried several tablets over the last few days;
Samsung Tab A8
Samsung S6 Lite
Samsung S7 FE
and Samsung S8
(They looked at me funny at bestbuy)
All have this bug for me.
The streams all work flawlessly on Android VLC.
Does anyone have an idea?

OK, I finally resolved my problem.
My Fire HD 10 9th generation was running an older version of webview.
All you have to do is to check for latest updates and update your OS, this will also install the latest version of the webview.
After doing that I have smooth video playback and I'm very happy.
Hope this solution works for others.
Update your OS and this will also update the webview.

OK, I finally resolved my problem. Fully Kiosk Browser on my Fire HD 10 9th generation was using an older version of webview. All you have to do is to check for latest updates and update your Fire OS (or any OS your tablet uses), this will also install the latest version of the webview. After doing that I have smooth video playback running on fully kiosk browser and I'm very happy. Hope this solution works for others. Update your OS and this will also update the webview.

Could you share your webview version? Mine is updated and I get this problem on both a S8 and a S7FE, which should be able to run this I assume

When you disabling WebRTC - you using MSE. MSE Cons: jumps over frames. I don't know if this can be fixed

I'm running into this issue too. What's interesting to me is that I don't see the same issue with RTSPtoWeb library when using MSE on the same stream. Any idea why that might be the case? @AlexxIT

The webview version on my Amazon firetab was very old. I updated the OS and it's OK now. The OS update updated the webview.
Sent from Yahoo Mail on Android
On Thu, 14 Apr 2022 at 5:52, @.***> wrote:
I'm running into this issue too. What's interesting to me is that I don't see the same issue with RTSPtoWeb library when using MSE on the same stream. Any idea why that might be the case? @AlexxIT
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.Message ID: @.***>

RTSPtoWeb may have some fixes and new library versions


Whe populating dictionary, ask for types

In GitLab by @jakebeal on Feb 1, 2019, 21:09
When the user chooses to say that something is a new term and should be added to the dictionary, they should have a menu of types that will determine what sheet and mark it ends up with. Some things (like CHEBI or Definition URI) should be able to be set in an optional blank.

In GitLab by @jakebeal on Mar 12, 2019, 11:06
assigned to @sumorok

In GitLab by @jakebeal on May 7, 2019, 11:13
Done in "add to synbiohub" dialog

In GitLab by @jakebeal on May 7, 2019, 11:13
closed


grype: 0.74.0 -> 0.74.1

Diff: https://github.com/anchore/grype/compare/refs/tags/v0.74.0...v0.74.1
Changelog: https://github.com/anchore/grype/releases/tag/v0.74.1
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 281712 run on x86_64-linux 1

1 package built:

grype