Incorrect copyright notice in license file

The LICENSE file contains this copyright notice:
Copyright (c) 2018 The Python Packaging Authority

But it doesn't reflect norminette authors.

Im sorry but I believe this is expected.
How/what do you expect us to put there instead?

Im sorry but I believe this is expected.
How/what do you expect us to put there instead?

Looks like the MIT license
https://choosealicense.com/licenses/mit/
Which, unmodified, contains this line:

Copyright (c) [year] [fullname]

To which you should do:

Replace [year] with the current year and [fullname] with the name (or names) of the copyright holders.

I think Exagone313 is assuming that the license should be for Norminette, and thus signed with year and license holders of Norminette.
Now it is, instead, attributing the whole Norminette project to fall under the copyright of "The Python Packaging Authority".

Unless the "root" part of this project is forked from some python package thing. In which case you'd expect another license file in the "norminette" directory.

Looks like the MIT license
https://choosealicense.com/licenses/mit/
Which, unmodified, contains this line:

Copyright (c) [year] [fullname]

To which you should do:

Replace [year] with the current year and [fullname] with the name (or names) of the copyright holders.

I think Exagone313 is assuming that the license should be for Norminette, and thus signed with year and license holders of Norminette.
Now it is, instead, attributing the whole Norminette project to fall under the copyright of "The Python Packaging Authority".

Unless the "root" part of this project is forked from some python package thing. In which case you'd expect another license file in the "norminette" directory.

Thanks a lot for the clarification.
I'll update the license with the next fixes.

Thanks a lot for the clarification.
I'll update the license with the next fixes.


Improve the Module Author Guide and add a recipe

Describe the feature
Hello 👋,
I'm developing a Nuxt module and I found that the Module Author Guide, https://nuxt.com/docs/guide/going-further/modules is not clear on many points, particularly the templates section. When you want to do something that is not clearly explained, it's hard to know how to do it because the 'why' things are made like this is missing. (I have to deep dive into nuxt/kit source code many times).
Also, having a recipe that explain, step by step, the way to build a module could really helps.
WDYT and could I work on it?
Additional information

[X] Would you be willing to help implement this feature?
[ ] Could this feature be implemented as a module?

Final checks

[X] Read the contribution guide.
[X] Check existing discussions and issues.

Would love your improvements! 🙏

see https://github.com/nuxt-hub/core/pull/168 for more structural informations

Create a utility isPrepare or isCLI ? But talk about the possible usage of _prepare (https://github.com/nuxt/nuxt/blob/d439da919914ff0e1de7bb48e7a41a0db7362409/packages/schema/src/config/internal.ts#L15) to avoid unnecessary computation.

See this tweet about build time vs runtime
https://x.com/danielcroe/status/1845147251556913526?t=iw-Co4Pavceh-opTiwPAhQ&s=19

#imports? What is this and how to use it? https://discord.com/channels/1216160300965826580/1216160303604170774/1295638603614912552


Station is not playing

Good afternoon! When starting playback from the  http://radio.btuner.ru:8000/live.ogg, an error occurs during playback. I hope for your help.

Hey @Zevsus, the .ogg format is not supported natively in iOS, we had a discussion about this in this issue: https://github.com/analogcode/Swift-Radio-Pro/issues/102


[HOLD #37788][Simplified Collect][Taxes] Create WorkspaceTaxesSettingsForeignCurrency

Implement this section of the Simplified Collect: Taxes doc
cc @kosmydel @filip-solecki

The PR is merged

@luacmartins Am I assigned to this issue? Because I reviewed the PR

Yes, just assigned you. Thanks for the ping!

Hmm actually, I think we can close these issues and keep it all in https://github.com/Expensify/App/issues/37788, since the same PR closed 4 issues.

Closing this issue to keep it all in https://github.com/Expensify/App/issues/37788


Repo is opened - trivially to lock out

fn main() {
   zbox::RepoOpener::new().create(true).open("file://./data", "password").unwrap();
}

cargo watch -x run
Cargo watch will immediately restart due to the data directory changing.
This results in a Error::RepoOpened error on the second run, due to the repo.lock file, without the API offering a way to recover (by just deleting the lock file).
The lockfile should probably store the process id and delete itself if it doesn't match.
(of course watch should ignore the data directory in real use, but this demonstrates a problem)

Keep watching on ZboxFS data folder is not good idea, you probably only need to watch source code change. For example, using below command will only watch src, tests and examples folder.
cargo watch -w src -w tests -w examples -x 'run --example zbox_demo --features storage-file -- --nocapture'

Another option is, If you're really sure what you're doing, you can break the exclusive repo access promise by using force option, which will open repo regardless lock file. But be cautious because this can potentially corrupt your repo data.
RepoOpener::new().force(true).open("file://your_repo", "pwd").unwrap();

Documentation for force option is here: https://docs.rs/zbox/0.8.7/zbox/struct.RepoOpener.html#method.force

You missed this line:
(of course watch should ignore the data directory in real use, but this demonstrates a problem)
I just stumbled over this before adding a --ignore flag.
The point was this could occur in real live when the application crashes.
I didn't see the force option though.
I have implemented a pid lockfile , but this would be helpful to include out of the box.

Sorry I missed that line.
I think there is a case when using lock file regardless it contains pid or not. For an example, process A opened a repo and it crashed with lock file undeleted, and another process B started and it sees the pid lock file is different. How process B deal with this situation? If process B forcefully delete that pid file to clear the lock, how it distinguishes the case if process A is still running?
So the trade-off is to use force option, it can open repo regardless the lock but at the cost there might be chances data get corrupted.


Refresh ORAS governance guide and process

As the ORAS community is growing fast in recent months, we see new contributors are being more active and subprojects/repos are newly created, there were also a few maintainers/owners not active in the 6 months.
As a CNCF Sandbox project, we need to look back at the existing ORAS governance guide and process, refresh them to adapt our community status and growth, and ensure the ORAS community has a healthy and open governance model. I will use the CNCF Project Guidance as a reference.
I would like to use this issue to list the key items we need to implement and gather further ideas for shaping good governance. I believe it will incentivize more users to become long-term, active, and engaged members of the community if we have a healthy governance model and documents. Let us know if you have any suggestions.

[ ] Have a clear process of setting up a new subproject/repository and document it in the ORAS governance guide
[ ] Have the correct code owner file (CODEOWNERS) in each repo. Currently, it mistakenly uses the markdown file as the code owner file in each repo, e.g. OWNERS.md
[ ] Have a central place to list all subproject maintainers and owners, then sync it to the CNCF maintainer list. It relates to https://github.com/oras-project/community/issues/23
[ ] Have a clear contributing guide for code and non-code contributions on the website, serving the major ORAS subprojects. It relates to https://github.com/oras-project/community/issues/20 and https://github.com/oras-project/oras-www/pull/90
[ ] Define a new role for the subproject maintainer; have clear criteria for nominating and onboarding a new maintainer. Document it in the ORAS governance guide
[ ] Ask the inactive subproject/org owners regarding their willingness to reserve or step down
[ ] Have matched permissions and GitHub Team members configured. Currently, they are misconfigured or outdated

In addition, the security policy and branch policy should be considered and added for the second phase.

CODEOWNERS files are created according the OWNERS.md file per repository.
New maintainers should be onboarded to MAINTAINERS.md and CODEOWNERS. OWNERS.md should only contain owners / admins.
Here are the PR links to individual repositories.

https://github.com/oras-project/oras/pull/811
https://github.com/oras-project/oras-go/pull/444

I think we should have separate issue for each of the work items above so we can have a discussion about the updates before we make those. Else we will bulk the discussions in this issue and it will not be clear what the outcome is. Governance changes are important and each individual change should be discussed separately. I have filed #33 for addressing the first from the list above.


Restructure spaces client and test error handling

Description

Testing Instructions

We don't need this, we directly use the correct path


Remove esversion from .jshintrc

This is done, because latest jshint complains this as an error:
ES5 option is now set per default.

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from the review on Reviewable.io


Local Auth

[x] Finger print feature crash
Disable that function add user account and menu

Fixed on iOS platform


[Backend] bug when you try to edit a future expense

When you try to update a future expense, setting today date and putting a value in the amount, you will receive a error "you can't register future expense", because the backend is not using the new date to validate but the old date.
we need to figure out some way to keep this validation but validate this after all data be updated.

If I remove this validation is not a problem at all. but I created it because of the objective. It's impossible to waste a money in the future. If you are planning a waste in the future you can create a expense with 0 amount and some budget as 50 euros for example. but you will pay this bill in the future. and then when you pay you can update the value. I think like this to avoid some misinformation for user. for example you put that you already paid something to day 20 and think that you have save some money and you can waste this money with another thing, but in really you will need to pay that in the future.
In this example you can see that I created a plan that I'll have to pay a rent on 15/12/2024 in the future. But just the budget without value because I don't pay it yet.

If I remove this validation is not a problem at all. but I created it because of the objective. It's impossible to waste a money in the future. If you are planning a waste in the future you can create a expense with 0 amount and some budget as 50 euros for example. but you will pay this bill in the future. and then when you pay you can update the value. I think like this to avoid some misinformation for user. for example you put that you already paid something to day 20 and think that you have save some money and you can waste this money with another thing, but in really you will need to pay that in the future.
In this example you can see that I created a plan that I'll have to pay a rent on 15/12/2024 in the future. But just the budget without value because I don't pay it yet.

This issue will be resolved when we solve another issues created to manage all dates to UTC date.


Send BTC-pin: remove misleading "(PIN-PROTECTED)" from some places

but not from the field Transfer from

Hi,  is this issue available? it would be my first one on this project.

Hi,  is this issue available? it would be my first one on this project.

@iower do you have some steps to reproduce it? As far as I have seen, the default screen does not show the tag pin-protected:

@iower do you have some steps to reproduce it? As far as I have seen, the default screen does not show the tag pin-protected:

Hi, you need create new Bitcoin wallet with PIN option

Choose bitcoin on first screen
Choose pin option


Fix the grayscale animation in our samples

This includes two changes:

Remove @-webkit-keyframes, which has the exact same browser support level as the changes in #12533
Add -webkit-filter to @keyframes (without prefix) so browsers (most notably, Chrome 43-52) don't ignore the unprefixed filter

cc @ficristo

LGTM, thank you.
Seeing the bg leftover I think we shoul have something like https://github.com/adobe/brackets/pull/11610...
The failures on travis are the usual rate API limit.


Update to use customized Bootstrap theme 3.x

Currently, the documentation references the customization of boostrap 2x
Objective is allow to include customized bootstrap theme 3x (see https://getbootstrap.com/docs/3.3/customize/).
See Reflow Themes

Any chance to be able to use offline theme?

@solomax which theme.
I'm working on #28 allowing to add web dependencies (boostrap,jquery...) and also bootswatch theme. See latest commit.
I created a module "reflow-default-webdeps" and after You are just need set in site.xml true and add following in pom.xml
<plugin>
        <groupId>org.apache.maven.plugins</groupId>
        <artifactId>maven-dependency-plugin</artifactId>
        <executions>
          <execution>
            <id>unpack</id>
            <phase>pre-site</phase>
            <goals>
              <goal>unpack</goal>
            </goals>
            <configuration>
              <artifactItems>
                <artifactItem>
                  <groupId>io.github.devacfr.maven.skins</groupId>
                  <artifactId>reflow-default-webdeps</artifactId>
                  <version>${project.version}</version>
                  <type>jar</type>
                  <overWrite>false</overWrite>
                  <!-- exclude all highlight styles except the theme in highlightJsTheme property -->
                  <includes>**/css/**/*.css,**/fonts/*,**/js/*.js,**/js/languages/*,**/js/styles/${highlightJsTheme}.min.css</includes>
                </artifactItem>
              </artifactItems>
              <outputDirectory>${project.build.directory}/site</outputDirectory>
            </configuration>
          </execution>
        </executions>
      </plugin>

You can play with includes and excludes element to fine tune.

Hello @devacfr,
just have tried 1.4.3-SNAPSHOT (local build)
And it copies resources! Thanks for that
The only issues I see: following css classes are missing: alert-primary card-text and maybe some more

hi @solomax,
I'm looking for why there not all bootstrap classes, I'm going resolve this problem (maybe).

Hi @solomax,
yes, in cerulean theme, alert-primary is missing, card is component of bootstrap 4. I would finalize with bootstrap 3 before begin to work on bootstrap 4.
After, I can create sub-modules specific to bootstrap 4, give me feedback!!

@devacfr my bad, I should check this :(
Let me me when it will be time to test :)

@solomax, I don't know if it works correctly with bootstrap 4...

OK, I'll re-test with bootstap3 and will report the results :)

@solomax that doesn't work with bootstrap 4

@devacfr are you planning to release 1.5.0?

@solomax, I planned to release a beta version.  Are you agree ?
I planned this week also release a beta version 2.0.0-beta supporting bootstrap 4x and documentary support (#19).

Wow :)
both betas are OK :)
I'll try to test both :)

@devacfr
this is actually why I initially would like to wait for bootstrap4 support
To change everything to 4 :)
I can test develop locally, would it help?

@solomax,
yes, thank you in advance. All remarks are welcome. for comment write in issue #19 please.


Don't add Basin / static if there are no flows

One thing I didn't realize about #1079, is that we can make most example models shorter!

Ah, nice catch!


update logic for the factorizations done in the core

Q
A

Bug Fix?
no

New Feature?
yes

BC Breaks?
yes

Deprecations?
no

Fixed Tickets

License
MIT

Hmm, why is PHPSpec telling me there are no specs? When I run them locally I do get a result.
Please don't be a case sensitive issue...


Add Mail Rules

Need to add mail processing rules so that emails can be organized, classified or trashed based on certain conditions.

Before anyone implements this, please discuss on this Issue about your approach to make sure we're good with it

@seesemichaelj - I was wondering if we can get mail rules preferences activated again!
See below:

oh your issue didn't really state that it was existing thing. i'm guessing thats a plugin? does it work?

Yes!  It does.  I wonder why this was removed when it works and can be immensely helpful!


Fixing returning type in categorical.as_known

Executed: py.test dask/dataframe --verbose
2733 passed, 299 skipped, 9 xfailed, 773 warnings in 352.25 second
Fixing the issue #3784.

Thanks. Could you add a test to ensure that we don't introduce changes in the future that break your fix? It can go in dask/dataframe/tests/test_categorical.py

Any update here ?
@Sriharsha-hatwar do you time to add a test here?

Was busy lately, will add it in a day or two.
On Wed 29 Aug, 2018, 19:59 Matthew Rocklin<EMAIL_ADDRESS>wrote:

Any update here ?
@Sriharsha-hatwar https://github.com/Sriharsha-hatwar do you time to
add a test here?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/dask/dask/pull/3888#issuecomment-416973870, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AOI8JzFhgTQ04BJLMBa2_62VL9hT2crgks5uVqU0gaJpZM4WDFVh
.

No rush.  Thank you for doing this work.  I appreciate it.

As far as my understanding goes, I have understood that the fix for this issue was for only known categorical and it was returning of type
 <dask.dataframe.categorical.CategoricalAccessor>
And after the fix it would return,
<class 'dask.dataframe.core.Series'>
So for the testcase I will create a known categorical column and check the return type of the function as_known() to whether its a dask series or not.

Hey @TomAugspurger  and @mrocklin I have added the regression test case for the fix. Please review and comment if any changes need to be looked into. Thanks :)

Its fixed, Thanks.

Thanks!


[FR] Include fuzzy matching for diacritics

Greetings,
I was happy to see you added support for fuzzy matching.
I am using a native language (Hungarian) that has a lot of compound words, accented characters and agglutinations.
It would be a nice improvement to have the plugin look for matches across a range of similar sounds/letters: aáäā etc., and the same for e, i, o, u (including ü, ű, of course).
Thus, if I write korny, környezet would pop up, for instance.
Excited for future implementations of this.
ありがとう
Cheers,
Zan

Thank you for your FR, @zanodor :)
Your suggestion looks good. I'll implement it by adding options if there is no or little performance degrade 👍

@zanodor
I have released in obsidian-various-complements-plugin-beta v8.1.0-beta1 🚀
If you use BRAT, please confirm whether it works as you expected.

No, there is not.
If you want it, please create a new issue. But users should set all the patterns they want to use.

Released in 8.1.0 🚀


Moving containerattached resource to v1beta1 version

Add containerattachedresource to v1beta1 version
Fixes #207
I have:

[x] Run make reviewable test to ensure this PR is ready for review.

How has this code been tested
create eks cluster with eksctl, apply manifests to the eks cluster and created containerattached cluster resource. Verified the cluster is attached successfully in GCP console.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Require status checks changed could you please rebase this PR?

Due to a lack of activity on this PR, we are proceeding with closing it for now. If you are interested in seeing this PR through or believe it was closed in error please re-open the PR and add a comment to it.


FS: Add "Create a new account" button on the Home page when accounts list is short

WORK IN PROGRESS


Bump Python beam-master containers

For update to dependencies to match https://github.com/apache/beam/pull/16227

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

R: @tvalentyn

LGTM


Improve Grafana dashboard in samples

Improve upon the currently provided dashboards (samples/).
Another goal for this change would be to align the look-and-feel for the Timescale-backed dashboard (this extension), the xk6-output-influxdb, and xk6-output-prometheus-remote possibly with the output provided by the k6 Cloud App. This would provide a consistent user experience for the varied data sources.
Ideally, this dashboard would be promoted to the Grafana site as the "official" dashboard for displaying k6 metrics backed by TimescaleDB datasources.
This issue may supersede the need for #5.

Consider optimizing the data model to support a dashboard that works with large volumes of test data. In our case we have created a significant number of materialized views and related policies to keep updated.


fix(pkg/*): Fix service selector match logic

Description:
This PR fixes a bug in how service selectors are matched against pod
labels. If there were no selectors for a service it was considered as a
match. With the changes in this PR services without selectors are not
considered for a match.
Note: This will break the current implementation of routes v2 (a feature under test), but I will tackle this  with issue #2545
Fixes #2578
Signed-off-by: Sneha Chhabria<EMAIL_ADDRESS>Affected area:

New Functionality      [ ]
Documentation          [ ]
Install                [ ]
Control Plane          [ ]
CLI Tool               [ ]
Certificate Management [ ]
Networking             [ ]
Metrics                [ ]
SMI Policy             [ ]
Security               [ ]
Tests                  [ ]
CI System              [ ]
Performance            [ ]
Other                  [ ]

Please answer the following questions with yes/no.

Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution? no

Codecov Report

Merging #2579 (3b2dad0) into main (861a25f) will decrease coverage by 0.01%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##             main    #2579      +/-   ##
==========================================
- Coverage   62.93%   62.92%   -0.02%
==========================================
  Files         154      154
  Lines        7133     7139       +6
==========================================
+ Hits         4489     4492       +3
- Misses       2627     2630       +3
  Partials       17       17

Flag
Coverage Δ

unittests
62.92% <66.66%> (-0.02%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/catalog/xds_certificates.go
92.00% <50.00%> (-0.86%)
:arrow_down:

pkg/endpoint/providers/kube/client.go
78.43% <50.00%> (-0.57%)
:arrow_down:

pkg/kubernetes/client.go
87.31% <100.00%> (+0.19%)
:arrow_up:

pkg/envoy/route/config.go
95.20% <0.00%> (-0.80%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 861a25f...3b2dad0. Read the comment docs.


Remove max-width from content

I don't see the reasoning why Read the docs added a max-width of 800px to the contents of the documents, it only makes the reader have to scroll more and it wastes 40% of the screen space. This small CSS change will remove that so it will use the full width of your screen.

Thank you for this contribution. We don't plan to make any edits to the default Read the Docs theme at this time because we plan to switch to a custom theme.


Revert "suite: Implement --sleep-before-teardown option"

This reverts commit c81ee9618faa6aeb56a4cc741e9f937b287b065e, which
broke the sequential and parallel tasks.
Fixes: https://tracker.ceph.com/issues/36230
Signed-off-by: Nathan Cutler<EMAIL_ADDRESS>

I completely forgot about the sequential and parallel tasks when I implemented this feature initially. Reverting it for now; will come back with an version 2.0 later.


Link field returning the git link instead of the homepage

Is there any way to display the git homepage url instead of the git clone url in the report?
Right now, field=link returns git+https://github.com/axios/axios.git instead of returning the repo homepage url https://github.com/axios/axios.

Technically it would be no problem to make the 'homepage' field as an additional optional field to license-report.
But we wanted to avoid an inflation of fields in license-report - in the end, we would take all fields from the package.json 😄 .
So I think it is time to think about adding new fields by configuration (i,e, by settings in the config file).
Give me a few days.

That'd be awesome. Thank you!

fixed by pr #125.


[BUG]: Repository JSON null but Config YAML not

Describe the bug
If the Config settings are not null, but the settings in the YAML are you get errors when it tries to reference values in the repo settings.
To Reproduce
Steps to reproduce the behavior:

Set all your PR Options in a repo to none - remove all status checks, overrides, etc.
Configure Settings.YAML to populate status checks and who can close / override pull request options etc.
Run the action'
See error

Expected behavior
It should show them as a difference rather than throwing an error because a dictionary key is missing.
Screenshots
Sorry, didn't take any, but provided steps to reproduce.
Desktop (please complete the following information):

OS: Win10
Browser Edge
Version 101.0.1210.39 (Official build) (64-bit)

Additional context
Came across it when I was testing the PR for status checks.  That PR has this fixed.
Fixed in #28

Will be released in https://github.com/andrewthetechie/gha-repo-manager/pull/26


Rotation changes often when playing valorant

Play with rotation set to -3.
When I play valorant, every few minutes it seems like the rotation changes to 0 or -6 but it actually hasn't changed when i check raw accel.
The rotation can mismatch outside of valorant with valorant.
Turning off raw input buffer in val settings fixes the issue (temporarily)
I just upgraded to Windows11 so that is likely related
How can i help debug this issue?

i think you are rotating your hand

Dude… I’ve used rawAccel for a year on windows 10 without problems. I would know if I was rotating my hand.
Windows 11 was the only changed factor

Please review the source code. Raw Accel works as a compiled kernel driver. If any portion of RA is acting on your mouse counts (for example, sensitivity mult) then it is all working as it is all compiled from the same module. In this way RA has not changed since the release of Windows 11 which also did not change the way Windows kernel drivers work. If you think otherwise, provide a measurement.


IPFS: remove Go dependency and exec Kubo binary instead

@ktock Would that be possible?

Most of ipfs-related parts in nerdctl are the access to kubo daemon API so I guess it's possible.

If executing kubo is difficult, we can also consider reimplementing the HTTP API client with minimum dependencies


Package load failed

LegacySitePackage failed for package [RPackage]
Source: 'System.ComponentModel.Composition' Description: No exports were found that match the constraint:
ContractName Microsoft.VisualStudio.R.Package.Shell.IApplicationShell
RequiredTypeIdentity Microsoft.VisualStudio.R.Package.Shell.IApplicationShell

MEF circular dependency


fitView() sometimes fails after flow initialization - REPRODUCED

What platform were you using when you found the bug?
React Flow / Svelte Flow version: @xyflow-12.3.4
Browser and version: Latest Chrome, Edge
OS and version: Windows 10
Live code example
https://codesandbox.io/p/sandbox/upbeat-proskuriakova-ydty3l
Describe the Bug
Sometimes the fitView() function fails to properly fit flow nodes to the view. I created a CodeSandbox example to illustrate this issue. I implemented the solution proposed in #4793 by @peterkogo, but it doesn't always work. I've also tried calling fitView() after all nodes have been updated with new values, but this approach is also unreliable.
Steps to reproduce the bug or issue
Click the Refresh button a few times in the linked example to see that nodes often fail to fit the view.
Expected behavior
fitView() must always be reliable
Screenshots or Videos
No response
Additional context
No response

@bsvetlik thanks for the reproduction, I will investigate what exactly is happening here.
In the meantime: If you have all information about the flow upfront (layouting, dimensions) and you can accept remounting the component, you can simply just set thefitView property on the main React Flow Component, which should work 100% of the time.

If there is some kind of hell for coding sins, this might be the ticket to get there - but it works:
    window.requestAnimationFrame(() => {
      window.requestAnimationFrame(() => {
        fitView();
      });
    });

@peterkogo In this case, I don't have node positions and calculate them using an auto-layout algorithm.
The problem lies in getFitViewNodes() within @xyflow/system/dist/esm/index.js. It returns an empty set of nodes because their measured width and height properties are undefined. Using node.width and node.height would resolve this issue, but might not be suitable for other scenarios.
function getFitViewNodes(nodeLookup, options) {
...
    nodeLookup.forEach((n) => {
        const isVisible = n.measured.width && n.measured.height ... // Always false
        if (isVisible && (!optionNodeIds || optionNodeIds.has(n.id))) {
            fitViewNodes.set(n.id, n);
        }
    });
    return fitViewNodes;
}

I'm also facing this bug 😢 . Somehow the fitView doesn't work when my nodes and edges are updated

GiancarlosIO Thanks for sharing your solution.
I found a workaround using the internal fitView() function from @xyflow/system/index.js

To avoid drawing nodes in incorrect positions before initialization,
the state initially uses empty arrays for nodes and edges.
After applying the auto-layout algorithm, call an internal fitView() function
to properly position the nodes within the view.
Finally, once the nodes are correctly positioned, the state is updated
with the actual nodes and edges for rendering.

import { fitView } from '@xyflow/system';
...
  const [nodes, setNodes, onNodesChange] = useNodesState([]);
  const [edges, setEdges, onEdgesChange] = useEdgesState([]);
...
  const onInit = () => {
     layoutFlow(model.nodes, model.edges);
  };

  const layoutFlow = async (nodes, edges) => {
    const layoutedNodes = layoutGraph(nodes, edges); // auto-layout nodes

    const { width, height, panZoom } = store.getState();
    await fitView({ nodes: layoutedNodes, width, height, panZoom }, { maxZoom: 1, minZoom: 0.1, duration: 0 })

    setNodes([...layoutedNodes]);
    setEdges([...edges]);
  };


Phase plan

Phase 1: Design the solution through a state machine diagram.
Deadline: 06/11
Phase 2: Hardware and software setup of GPIO, ADC, DAC, I2C and sensors
Deadline: 08/11
Phase 3: Integrate DMA for critical peripherals.
Deadline: 09/11
Phase 4: Implement UART communication to transmit sensor data to a remote station.
Deadline: 11/11
Phase 5: Test and debug the complete system, ensuring smooth, responsive operation in all scenarios.
Deadline: 12/11

Phase 1: Design the solution through a state machine diagram.
Tasks:

[ ] State machine: add display functionality @daviddaguero
[ ] Requirements document: @daviddaguero
[ ] Requirements,
[ ] A high-level project description (one paragraph).
[ ] Define the main objectives and success criteria for the project.
[ ] Schematic: @lujanlaspina
[ ] A brief overview of the hardware used (microcontroller type, sensors, actuators, etc.).
[ ] Circuit schematics in image or SVG format detailing the connections of all components.
[ ] A hardware setup guide describing how components should be physically connected.
[ ] Block diagrams or flowcharts representing the system architecture. @sofiavalos
[ ] Define the main modules, their purpose, and how they interact. (Github wiki) @sofiavalos

Phase 2: Hardware and software setup of GPIO, ADC, PWM, I2C and sensors
Tasks
General configuration:

[ ] GPIO Configuration: assigned to @sofiavalos
[ ] ADC Configuration: assinged to @lujanlaspina
[ ] PWM Configuration: assigned to @sofiavalos
[ ] I2C Configuration: assigned to @daviddaguero

System response

[ ]  Door functions: assigned to @lujanlaspina
[ ] Fan functions: assigned to @daviddaguero

Alarm and notification

[ ] Alarm functions: assigned to @lujanlaspina
[ ] Battery status indication functions: assigned to @sofiavalos
[ ] Display functions: assigned to @sofiavalos

Main

[ ] Free RTOS: assigned to @daviddaguero
[ ] Function calls: assigned to @daviddaguero
[ ] Handlers: assigned to @lujanlaspina


Improve concurrency

Resolves #513 .

Resolves #513 .

lets leave https://github.com/AgnostiqHQ/covalent/issues/513 open... since its not really known for certain that multiprocessing/multi-threading is not a viable alternative for many simultaneous users when self-hosting. Going to need more testing in upcoming sprints.

100% Agree, just wanted to connect this PR to that issue for keeping track somehow, since we've had situations before where we couldn't pin point the commit when a feature was introduced.

We can merge this and reopen that issue afterwards.

We can merge this and reopen that issue afterwards. If that works?

Awesome... sounds good!

Because it is still partially resolving that issue with the current develop-covalent.


Added documentation for tab switcher feature.

This PR is for #12505
Testing Plan:
GIFs or Screenshots:

Thanks for working on this @Arpitpundir!  I think this is too much in the weeds and off-focus for the type of documentation we had in mind, so I'm closing this PR.


convert failure in group

I will fix this soon (promise).
=== prop_convert_is_well_typed from test/Icicle/Test/Source/Convert.hs:30 ===
*** Failed! Falsifiable (after 966 tests):
QueryWithFeature:
  Query: group fold (statler
           ,kermit) = (group kermitnow
                       ~> "cartman")
~> (latest 1 ~> kermitnow)
  Now: kermitnow
  Output: statler
  Type: Unit
  Name: kermitfeaturename
  Time: kermittimename
  Key: "token"
feature kermitfeaturename
~> group fold (statler
              ,kermit) = (group kermitnow
                          ~> "cartman")
~> (latest 1 ~> kermitnow)
Program (core$0 : Unit, core$1 : FactIdentifier, core$2 : Time, core$3 : SNAPSHOT_TIME)
Precomputations:

Streams:
  STREAM_FOLD (core$6 : (Option String, Map Time Unit))
    INIT:
      pair# (None) (Map [])
    KONS:

        let core$24 = fst# core$6
        let core$22 = snd# core$6
        let core$25 = some# ("token")
        let core$23 = Map_insertOrUpdate#
          (\core$8 ()) (()) core$3 core$22
         in if# core$6 (pair# core$25 core$23) (eq# core$24 core$25)

Postcomputations:
  core$17              = Map_fold#
                           (\core$14 \core$9 \core$11 Map_insertOrUpdate#
                             (\core$13 core$13) ("cartman") core$9 core$14) (Map []) (snd# core$6)
  core$4               =
                           let core$21 = Map_fold#
                             (\core$5 \statler$core$18 \kermit$core$19 Latest_push# core$5 core$1 core$3) (Buf []) core$17
                            in Latest_read# core$21

Returning:
  statler              = core$4

Left (ProgramErrorPost (ExpErrorVarNotInEnv (Name {nameHash =<PHONE_NUMBER>069689063, nameBase = NameMod (Variable "core") (NameBase (Variable "1"))})))

simpler example:
> feature cylon ~> group fold (k,v) = (group time ~> 0) ~> newest v
- Core (simplified):
Program (conv$0 : (Sum Error Int), conv$1 : FactIdentifier, conv$2 : Time, conv$3 : SNAPSHOT_TIME)
Precomputations:

Streams:
  STREAM_FOLD (conv$6 : Map Time Unit)
    INIT:
      Map []@{Map Time Unit}
    KONS:

        let simp$5 = snd#@{(Sum Error Int), Time} conv$0
         in Map_insertOrUpdate#@{(Time,Unit)}
          (\conv$8@{Unit} ()@{Unit}) (()@{Unit}) simp$5 conv$6

Postcomputations:
  conv$17              = Map_fold#@{(Time,Unit)}@{Map Time Int}
                           (\conv$14@{Map Time Int} \conv$9@{Time} \conv$11@{Unit} Map_insertOrUpdate#@{(Time,Int)}
                             (\conv$13@{Int} conv$13) (0@{Int}) conv$9 conv$14) (Map []@{Map Time Int}) conv$6
  conv$4               =
                           let simp$0 = Map_fold#@{(Time,Int)}@{(Int, Buf 1 ((Sum Error Int), Time))}
                             (\conv$5@{(Int, Buf 1 ((Sum Error Int), Time))} \k$conv$18@{Time} \v$conv$19@{Int}
                               let conv$40 = snd#@{Int, Buf 1 ((Sum Error Int), Time)} conv$5
                                in pair#@{Int, Buf 1 ((Sum Error Int), Time)} v$conv$19 (Latest_push#@{Buf 1 ((Sum Error Int), Time)} conv$40 conv$1 conv$0)) ((0, Buf [])@{(Int, Buf 1 ((Sum Error Int), Time))}) conv$17
                           let simp$1 = fst#@{Int, Buf 1 ((Sum Error Int), Time)} simp$0
                           let simp$2 = snd#@{Int, Buf 1 ((Sum Error Int), Time)} simp$0
                           let simp$3 = Latest_read#@{Array ((Sum Error Int), Time)} simp$2
                           let simp$4 = Array_fold#@{((Sum Error Int), Time)}@{(Sum Error Int)}
                             (\conv$26@{(Sum Error Int)} \conv$25@{((Sum Error Int), Time)}
                               let s$reify$2$conv$34 = Sum_fold#@{(Error,Int)}@{(Sum Error Int)}
                                 (\reify$0$conv$29@{Error} if#@{(Sum Error Int)} (right#@{Error, Int} simp$1) (left#@{Error, Int} reify$0$conv$29) (eq#@{Error} (ExceptFold1NoValue@{Error}) reify$0$conv$29))
                                 (\reify$1$conv$31@{Int} right#@{Error, Int} simp$1) conv$26
                                in s$reify$2$conv$34) (Left ExceptFold1NoValue@{(Sum Error Int)}) simp$3
                            in simp$4

Returning:
  repl                 = conv$4

- Core type error:
Post error:
    Variable not bound: conv$1

- Core evaluation:
[foo, 0]

while k and v has temporality Element, they aren't facts so they have no fact identifiers... I'm not quite sure how to cleanly deal with this? @amosr

wow. this is crazy.
at the moment we are assuming that Latest_push# is only called in stream part, which turns out isn't true.
in this case the time is part of the fact input, so the group should be "infected by the bubblegum" and have to keep the fact identifier around inside the group. then when we fold over it at the end we can use that one. this is hard though.
what would happen if we didn't have time? can you do this:
feature cylon ~> group fold (k,v) = (group 0 ~> 0) ~> newest v

this might look like it doesn't need a fact identifier, but it actually does, because the result depends on whether there are any facts or not. if no facts came in, this would give NA, if something, 0. so for the internal snapshot it needs to remember that there was a fact last time, which might as well just be the last seen fact.
we could "infect" all groups with the last seen fact identifier for each key, but it doesn't really matter in terms of correctness of the internal snapshot, since "big data mode" won't allow this particular query through.
I'm tempted to just bind a dummy fact identifier for the pre and postcomputations, since if a buffer occurs there it means either A) we're not in big data mode, or B) we are in big data mode and there's already a window or latest in the stream section, which will mark the identifiers anyway.
probably best to talk about this one in person

yeah, I am considering just using dummy fact identifiers for pre and post-computations too, I think that's the easiest way..... putting this off until we talk about it some more though.

ah.. did we change the invariant checker to allow latests inside group folds by accident - maybe during group-in-group?
Before:
> feature salary ~> group fold (k,v) = (group time ~> 0) ~> latest 1 ~> v
                                                                   λλλλ
REPL Error:
Check error:
  Context is not allowed at 1:66
  Context: latest 1
  Extra information:
    Latest is not allowed inside group-fold or another latest.
    If you are using latest inside a latest, you should be able to rewrite your query to use a single latest.
    Note that 'newest' is implemented using latest, but if you have `latest 5 ~> newest value` you might be able to just use `newest value`.

After:
> feature salary ~> group fold (k,v) = (group time ~> 0) ~> latest 1 ~> v
- Core type error:
Post error:
    Variable not bound: conv$1

- Core evaluation:
[]

@amosr yeah, you're right, that happened.... should we just change the invariant checker back?

certainly easier.. I don't know whether latest inside group fold is particularly useful - since the group fold loops through the sorted keys, "latest 1" would be the last key. probably not interesting

latests are banned in group folds now


Caterpie to Beedril Egg Cycles

For the six pokemon in that range, isn't the hatch counter meant to be 10, not 15?
(i'm probably wrong)

All the data should be correct as of X/Y, but If you have a source that disagrees we'd love to see it.

Closing due to lack of any follow-up.


Import via buffer protocol

@H-Plus-Time I think this is a bit cleaner than what you have in #56

Much nicer - yeah, I was very wary of transmute, this looks like a better alternative :smile: .
With the GIL lock, that pretty much only applies at buffer protocol import time, yeah?
Vectorized search would be a nice thing to have (unless it's obviated by tree to tree intersection candidates), and I'd imagine GIL locking would be a pain there.

With the GIL lock, that pretty much only applies at buffer protocol import time, yeah?

In theory, I think you're supposed to hold the GIL for the entire lifetime of the slice. But IMO I think it would be ok to make clear in the documentation that the input must not be mutated.

Vectorized search would be a nice thing to have

You mean searching a tree for lots of boxes at once, not just a single box? We could provide a naive implementation that does the loop in Rust. I suppose that's a separate concept from tree to tree intersection.
In case you're looking for a place to contribute and/or it's something you want to use 😄 , I implemented tree to tree intersection myself (as in, not something I ported from flatbush.js) and it appears to have a bug that I haven't had time to look into. See https://github.com/kylebarron/geo-index/issues/42 and https://github.com/kylebarron/geo-index/pull/51

I think I tried to generalize too soon and it became more work than I expected 😢 . Probably not worth trying to support non-float box types yet

Also I was thinking of trying to support both numpy and arrow input, but that seems a little hard. In general I'm trying to move towards arrow-first, but it seems wrong to not support arrow here.

It would probably be simplest to separate out the constructors for numpy and arrow. The consumer can deal with that. So we'd have
RTree.from_interleaved
RTree.from_separated
RTree.from_arrow

where the from_arrow version will look for a geoarrow box array.

I think I tried to generalize too soon and it became more work than I expected 😢 . Probably not worth trying to support non-float box types yet

Yup, that's midnight-brain, I know it well 😬

It would probably be simplest to separate out the constructors for numpy and arrow. The consumer can deal with that. So we'd have
RTree.from_interleaved
RTree.from_separated
RTree.from_arrow

where the from_arrow version will look for a geoarrow box array.

Yeah, may as well - the python tendency toward methods that take basically anything (as in lists of dicts OR dicts of lists OR random type X) and flag out how it's interpreted... Is maybe not a great thing to perpetuate.

Often my midnight brain is very productive 😛

Yeah, may as well - the python tendency toward methods that take basically anything (as in lists of dicts OR dicts of lists OR random type X) and flag out how it's interpreted... Is maybe not a great thing to perpetuate.

I'm definitely not a fan of accepting any kind of input. Especially now that we have good type checking in Python, each method should take only one kind of input. I was mostly thinking that arrow and numpy arrays could be interchangeably accepted. But I think separating into from_arrow is fine

In https://github.com/kylebarron/arro3/pull/204 I figured out a way to have Python-backed Arrow Array objects. So we can interpret a numpy numeric array as a non-null Arrow array without any memory copies.
geo-index doesn't necessarily use Arrow, but it may be worth it to use pyo3-arrow in the python bindings, because then we can accept either numpy or arrow input for the tree

And in https://github.com/kylebarron/arro3/pull/208 I automatically handle multidimensional numpy arrays as input, converting them (zero-copy) to nested fixed size lists


public Type GetPropertyValueType misses PropertyTypeAlias

Since Umbraco 7.1.5 when you use Property Value Converters there is a method available called GetPropertyValueType: http://our.umbraco.org/documentation/extending-umbraco/property-editors/value-converters-v7#PropertyValueType
In this method you can see what the alias of the property is based on the propertyType.PropertyTypeAlias value. For Archetype properties this value is null. I've got a situation where based on the propertyType.PropertyTypeAlias value I need to return a different type.

Closing due to inactivity.


[CWS] Add DNS id field in SecL

What does this PR do?

This PR introduces the ability to filter CWS dns rules on the DNS request ID (dns.id).
Motivation

This was introduces to allow filtering out events from a service that might be using a custom DNS id for homemade communication.
Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Reviewer's Checklist

[ ] If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
[ ] Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
[ ] A release note has been added or the changelog/no-changelog label has been applied.
[ ] Changed code has automated tests for its functionality.
[ ] Adequate QA/testing plan information is provided if the qa/skip-qa label is not applied.
[ ] At least one team/.. label has been applied, indicating the team(s) that should QA this change.
[ ] If applicable, docs team has been notified or an issue has been opened on the documentation repo.
[ ] If applicable, the need-change/operator and need-change/helm labels have been applied.
[ ] If applicable, the k8s/<min-version> label, indicating the lowest Kubernetes version compatible with this feature.
[ ] If applicable, the config template has been updated.

Next step: maybe add a discarder kernel-side


Support for UNION

Hi do you plan for adding UNION keyboard support with api like this:
db.selectFromRoom().roomKeyIn(list).union()
.createdTimeLt(123).union()
....
.toList()

Thanks

Sounds great.
BTW what you expect the result type and value for UNION? Do you have an example models?

I in general asked for this, one reason that this is beneficial is that we can not combine  AND  and OR clauses together when we need to run a reletivey complex query
example :
table chatRoom {
roomKey string
updatedTime int
isPined bool
archived bool
}

select * from chatroom where isPined = 1
union
select * from chatroom where archived = 0 AND updatedTime > 123
union
order by updatedTime desc

this is just an sample to illustrate my point for combing multiple where clause with diffrent OR and AND.

@jozn
You can use rawQuery , see https://github.com/gfx/Android-Orma#raw-queries


How to sharing variables that define in other jobs?

Description
First check workflow.
https://github.com/ghkdqhrbals/spring-chatting-server/actions/runs/6919452901/job/18822869104

As you can see, ECR_URL and NEW_VERSION variable is missing in workflow
What I want to solve
How to share variables in other jobs?

Can get NEW_VERSION but not ECR_URL


remove unworkable luis region

Description
Fix this Issue
Remove unavailable luis region and set "WestUs" as default.
Task Item
https://github.com/microsoft/BotFramework-Composer/issues/1459
https://github.com/microsoft/BotFramework-Composer/issues/1500
Type of change
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Code refactor (non-breaking change which improve code quality, clean up, add tests, etc)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Doc update (document update)

Checklist

[ ] I have added tests that prove my fix is effective or that my feature works
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have functionally tested my change

Screenshots

We want to keep WestUS as the only option in the dropdown. We keep the control and will add other regions as they become available. bonus: inspect office-ui-fabric-react to see if we can set this value by default.

We want to keep WestUS as the only option in the dropdown. We keep the control and will add other regions as they become available. bonus: inspect office-ui-fabric-react to see if we can set this value by default.

Ok, I only remove the other options and keep original control. I use defaultSelectedKey to set this value by default.


Wrapper: missed check in highlight method

Hello, it is very helpful library! Thank you so much)
It seems you missed check with your own method in wrapper highlight method.
I'm not sure is it good practice or not to use elasticsearch without query or use it with wildcard, but in  this case we need to check that _data  contains key "highlights" and _data['highlights'] contains key which is equal to attribute name.
Moreover - you already have this method!)

Makes sense actually, thanks!


Obtain manipulability measure

Hi,
I'm a student and I'm trying to use MuJoCo for control a Baxter robot with Robosuite .
I'm looking for some help with manipulability measure. I find the Jacobian matrix of the robot in function of the joint's variables using sympy. Then I computed the manipulability measure and derived it in order to find the velocities to apply to the joints. However, when I try to evaluate the obtained function in a certain configuration, it takes so much time for the first computation and then the simulation crashes during a second computation. The robot in particular has 7 dof, so the resulting Jacobian has a lot of terms.
Is there a way to better perform calculations or to obtain the manipulability measure for a certain configuration, in order to speed up the simulation?
Here is a model which explains my question:
---first I compute the Jacobian as J and w is the manipulability measure.--
arg=J*J_trans
determinant=arg.det(method='lu')
w=sp.sqrt(determinant)
qo_dot=sp.zeros(7,1)
qo_dot[0]=sp.Matrix([[w.diff(q1)]])

qo_dot[1]=sp.Matrix([[w.diff(q2)]])

qo_dot[2]=sp.Matrix([[w.diff(q3)]])

qo_dot[3]=sp.Matrix([[w.diff(q4)]])

qo_dot[4]=sp.Matrix([[w.diff(q5)]])

qo_dot[5]=sp.Matrix([[w.diff(q6)]])

qo_dot[6]=sp.Matrix([[w.diff(q7)]])

--then at each iteration i perform the following calculations, being actual_q the actual values of the joints--
q1, q2, q3, q4, q5, q6, q7 = sp.symbols('q1 q2 q3 q4 q5 q6 q7')
q_dot_num=Ko*np.array(q_dot.subs({q1: actual_q[0],q2: actual_q[1],q3: actual_q[2],q4: actual_q[3],q5: actual_q[4],q6: actual_q[5],q7: actual_q[6],}).evalf()).astype(float)
Thanks,
Alessandro

Why are you using sympy when MuJoCo computes super fast analytic Jacobians (literally in microseconds)?
https://mujoco.readthedocs.io/en/latest/APIreference/APIfunctions.html#mj-jac

@aleada23 See https://github.com/google-deepmind/mujoco/issues/411.

I checked #411 but I'm not able to find a solution, sorry.
I'll try to better explain my problem.
I computed the Jacobian and the function called manipulability measure:

After that in order to find the desired joionts' velocities I did:
.
It takes long time to do computation so I saved the resulting q_zero_dot using pickle so I don't need to do calculations each time I start the simulation.
Everything was done considering the symbolic values, so at each step of my robot I can obtain the resulting velocities simply substituting the joint variables with their actual value. Here I have the problem, the substitution of symbolic values with reals takes too long at each step.
How can I modify this process to save time during simulation? Is it possible to quickly derive the velocities at each step?
Or can I evaluate the Jacobian with actual value first and then do the derivative of w without symbolic values?
Thank you

You don't need any of the symbolic computation. Stop doing that.

I was wondering how to do this without symbolic... if anyone can explain or tell me if there are any examples


<EMAIL_ADDRESS>hash check failed

attempting to install rsync and getting hash check fail.
~ $ scoop install rsync
Installing 'rsync' (5.7.2) [64bit]
cwrsync_5.7.2_x86_free.zip (819 B) [==========================================================================] 100%
Checking hash of cwrsync_5.7.2_x86_free.zip... ERROR Hash check failed!
App:       rsync
URL:       https://www.itefix.net/dl/cwrsync_5.7.2_x86_free.zip
Expected:  c61258fe6d1ab9af7b0a45fb166b0c69ee13bdf971d4a3b486b8d1e33425fcf5
Actual:    af8ad11ab64316a5424d115c9a25edc3400559cff6edef0bc8a3b5943f6e8650

Please create a new issue by using the following link and paste your console output:
https://github.com/lukesampson/scoop/issues/new?title=rsync%405.7.2%3a+hash+check+failed
~ $

https://www.itefix.net/dl/cwrsync_5.7.2_x86_free.zip is not a zip file.
Now it is a PGP signature file.

I sent a notice to www.itefix.net.

Duplicate #2295


Removes used InjectConnection import from '@nestjs/mongoose'

Removes the used import InjectConnection, please add an exception for it.

🎉 This issue has been resolved in version 1.2.4 🎉
The release is available on:
Visual Studio Marketplace
GitHub release
Your semantic-release bot 📦🚀


Should I extract all the file from librispeech, and where to find the train.csv?

Thanks to Namju Kim and Kyubyong Park. The newer version seems to be very awesome. Not only did you add the testing and training set but also add more corpus.
However I am confused that should I extract all the tar.gz file of Librispeech or can I use just some of them due to limited download time?
I have tried just some of data but the python preprocess.py show some error.
# python preprocess.py
Traceback
 (most recent call last):
  File "preprocess.py", line 193, in <module>
    csv_f = open('asset/data/preprocess/meta/train.csv', 'w')
IOError: [Errno 2] No such file or directory: 'asset/data/preprocess/meta/train.csv'
I don't know where to get the .csv file.

You have to manually create the /preprocess/meta and /preprocess/mfcc subdirectories for the script to work.

Thanks @mgfcm . It works.

@abc1199281 @mgfcm I've updated preprocess.py to create directories if not exist.  Thanks for your information.

I want to train and test the model on my own data. Can someone please mention what the file format of the csv file inside /asset/data/preprocess/meta/filename.csv should be? For ex: columns of files and specifications of the audio files.


shared thread pools, closes #5

Multiple Happy plugin instances can now share the same thread pool. Very effective when some instances have way fewer files than others in which case their threads used to be idle most of the time.

Current coverage is 82.58%

Merging #20 into master will increase coverage by +1.21% as of e1f0a02

@@            master     #20   diff @@
======================================
  Files           19      19
  Stmts          612     620     +8
  Branches       102     103     +1
  Methods          0       0
======================================
+ Hit            498     512    +14
+ Partial         38      37     -1
+ Missed          76      71     -5

Review entire Coverage Diff as of e1f0a02

Powered by Codecov. Updated on successful CI builds.


Intermittent problem - Clicking on in planner causes the quick add bar to disappear

Seeing this occur - not every time - clicking on the quick add option causes it to disappear. No error is logged in the console log:

Leaving and returning to the planner restores the quick add bar.

@ldimaggi again, can not verify over here. You did click on the "Create Work Item" label on the closed quick add to trigger this, correct?

Yes - but - this is a diff problem - as is shown in the screenshot - the quick add simply disappeared.

This issue was moved to fabric8io/fabric8-planner#2019


Match files named Dockerfile

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thanks @dcecile! This will be released in 0.2.0 once the CI finishes.

Great! :)
Hmm I tried to update to the released 0.2.0, but it's not detecting my Dockerfile. I tried using dpring 0.18.1. Was there another place in this repo that needed a change?
Here are the steps using a test repo I created:
git clone https://github.com/dcecile/dprint-dockerfile-test.git
cd dprint-dockerfile-test
npm install
./node_modules/.bin/dprint check
./node_modules/.bin/dprint output-file-paths

(Only other.dockerfile is resolved, not Dockerfile.)

@dcecile thanks for the reproduction. It was a bug in the CLI and should be fixed now in 0.18.2 (it wasn't properly handling casing).

:smiley: It's working for me now with 0.18.2. Thank you!


Basic test case: copr build only

This test case is triggered automatically by our validation script.
- job: copr_build
  trigger: pull_request
  metadata:
    targets:
    - fedora-all

/packit rebuild-failed

/packit-stg build

/packit-stg build

/packit-stg build

/packit build

/packit build

/packit-stg build

/packit-stg build

/packit build

/packit-stg build

/packit-stg build

/packit-stg build

/packit-stg build

/packit-stg build

/packit-stg build

/packit-stg build

/packit-stg build

/packit-stg build

/packit-stg build

/packit-stg build

/packit-stg build

/packit-stg build

/packit-stg build

/packit-stg build

/packit-stg build

/packit-stg build

/packit-stg build

/packit-stg build

/packit-stg build

Project github.com/packit/hello-world.git is not on our allowlist!

/packit-stg build

/packit build

/packit-stg build

/packit-stg build

/packit build

/packit-stg build


Processing: Add ignore rules for Linux ARM exports

Reasons for making this change:
Since Processing version 3.0.1 you can compile Linux ARM versions of your Processing sketch, distinct from the regular 32 and 64 bit Linux exports.
Links to documentation supporting these rule changes:

https://github.com/processing/processing/releases/tag/processing-0247-3.0.1

@Niels-NTG thanks!


Unable to prepare setup for platform lutron_caseta_pro.cover: Platform not found (cannot import name 'CoverEntity' from 'homeassistant.components.cover'

Running 109.6 and updated to the latest version. After the update I get the error above (three times for CoverEntity, SwitchEntity and LightEntity).
Is this an update for 110 that breaks 109 ?
Thank you.

Sorry, just updated the component to fix #56 for Home Assistant 0.110.
Here is the old version for 0.109.x:
https://github.com/upsert/lutron-caseta-pro/archive/c455e1923e42c81568986e44dce8562d87af11c4.zip

I have the same issue; should I upgrade to .110 to fix this?

My perspective: given that there are 400+ replies to the blog post announcing 0.110, I think I'm going to let that settle down a bit before upgrading.  The rollback posted by @upsert works fine for now!

upsert, -
Thank you for the 109.x version, all works again !!!


fix: make sure ament_package() is called when CUDA is not found

Description
Resolves https://github.com/autowarefoundation/autoware.universe/issues/7916
Related links

https://github.com/autowarefoundation/autoware.universe/issues/7916

How was this PR tested?
Install Autoware on machines without CUDA installed and run source install/setup.bash
Notes for reviewers
None.
Interface changes
None.

Effects on system behavior
None.

It looks like some packages (like lidar_apollo_instance_segmentation) uses if(NOT ${tensorrt_common_FOUND}) and causes failure with this change. I will think about some solutions to fix this issue in more clean way.


First-Class Array Abstractions

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

Currently Array are wrappers around an ArrayData, storing it as a member of the array. This is redundant, confusing and results in API friction.
Describe the solution you'd like

I would like the Array implementations to just store their constituent parts, in the same vein as the typed ArrayData abstractions experimented with under https://github.com/apache/arrow-rs/issues/1799 did. This would involve the following

Add Array::nulls(&self) -> Option<&NullBuffer>
Add Array::to_data(&self) -> ArrayData
Implement Array::slice, Array::data_type, Array::len, Array::get_buffer_memory_size, etc... for each Array
Deprecate Array::data,  Array::data_ref and Array::offset

Describe alternatives you've considered

Additional context

https://github.com/apache/arrow-rs/issues/3879

label_issue.py automatically added labels {'arrow'} from #3877

label_issue.py automatically added labels {'parquet'} from #3930


e164 Mustache filter transforms UK phone number into US phone number

I configured a new UK mobile phone number today, which failed to make calls due to an invalid caller id.
I am using the generic TwiML Bin from the guide, which extracts the phone number from the SIP Domain:
<?xml version="1.0" encoding="UTF-8"?>
<Response>
  <Dial callerId="{{#e164}}{{SipDomain}}{{/e164}}">{{#e164}}{{To}}{{/e164}}</Dial>
</Response>

The e164 Mustache filter used to extract my own phone number from the SIP Domain no longer works with that UK phone number. The caller id is reported as invalid.
I reproduced the issue using a fake UK phone number, which I included in the example below:
<?xml version="1.0" encoding="UTF-8"?>
<Response>
  <Dial callerId="{{#e164}}44-7355-547122.sip.twilio.com{{/e164}}">{{#e164}}{{To}}{{/e164}}</Dial>
</Response>

The error log shows the resulting value, which is quite unexpectedly a US Phone number:
invalidCallerId: "+17355547122"

I have also tried prefixing the value with a +
<?xml version="1.0" encoding="UTF-8"?>
<Response>
  <Dial callerId="{{#e164}}+44-7355-547122.sip.twilio.com{{/e164}}">{{#e164}}{{To}}{{/e164}}</Dial>
</Response>

which makes no difference:
invalidCallerId: "+17355547122"

Let's check whether the {{To}}value is affected by this issue as well:
<?xml version="1.0" encoding="UTF-8"?>
<Response>
  <Dial callerId="{{#e164}}+44-7355-547122.sip.twilio.com{{/e164}}">{{#e164}}+44-7355-547122{{/e164}}</Dial>
</Response>

Yes, the number is transformed in the same way, as shown in the logs:
<?xml version="1.0" encoding="UTF-8"?>
<Response>
    <Dial callerId="+17355547122">+17355547122</Dial>
</Response>

Calling the same UK phone number results in a correct conversion, however, in the {{To}} number.
The number is received by Twilio as:
To<EMAIL_ADDRESS>
and correctly transformed to:
+447355547122

Let's try different values:
{{#e164}}+447355547122{{/e164}} -> +447355547122
{{#e164}}+44-7355547122{{/e164}} -> +447355547122
{{#e164}}447355547122{{/e164}} -> +447355547122

{{#e164}}44-7355-547122{{/e164}} -> +17355547122
{{#e164}}+44-7355-547122{{/e164}} -> +17355547122
{{#e164}}+44-7-355547122{{/e164}} -> +17355547122

{{#e164}}0044-7355-547122{{/e164}} -> 0044-7355-547122

The {{#e164}} results in a different phone number depending on the presence and the position of the dashes which separate groups of digits in the phone number.

I have reported this issue to Twilio for their consideration.
As a workaround, I now recommend, for any new phone number, to remove all dashes from the phone number value used as unique SIP domain.
There is no point in changing the configuration of existing phone numbers. If your number works correctly, it means that it is not affected by the unexpected conversion to a different country when getting through the e164 Mustache filter.


Disable internal-search when using group options with an empty list displays an object as item

Hi
In my project, I'm using vue-multiselect with group options and an ajax based list, so I disabled the internal search with :internal-search="false" and I just found an issue when one of the group list is empty.
When a group list is empty, it will display the Json object as an item: https://jsfiddle.net/tetr7v1x/2/

Working fine when removing :internal-search="false"

I had another problem with this option and ajax request. When value query got space or dash or quote, like word-o'something or word- osomething. My props filled up but nothing was rendered. I added :internal-search="false" and boom everything was fine.

This should not happen on the current master. Preparing a new release.


Key press effect

Suggestion: Add key press effect to the available effects for color zones. If it gets selected there should be two options for color: background and keypress color. Also, if you do add this, it would be nice if the keypress color could be random. So for example a white background with random color keypress for that "rainbow" effect but with keypresses.
Not sure if this is the right way to use github, just couldn't find anywhere else to give feedback so I thought why not?

Sorry for the late response. Next version will basically break down each profile into their own "layers", so people can select an Interactive layer and set what they want for each profile. Another cool thing that you can do is combine multiple interaction layers to create various effects.
Demo:


Remove the contentmenu usage, from PresentationMode, since it's no longer working

This feature was Firefox-specific, and it's now been removed from the HTML specification and it's disabled by default starting with Firefox 85. Hence it seems completely unnecessary to keep this code in the default viewer.
Please refer to https://groups.google.com/g/mozilla.dev.platform/c/tc11BCenm2c and the resources that it links to.

/botio-linux preview

Thanks!


Build notifications support with AWS Chatbot

Is your feature request related to a problem? Please describe.
AWS Chatbot offers a convenient way to publish build notifications to Slack from AWS Developer Tools, AWS CloudFormation and others and is an approved Slack application for our organization. However, it does not currently support Amplify builds. I see the following error in CloudWatch Logs.
Event received is not supported (see https://docs.aws.amazon.com/chatbot/latest/adminguide/related-services.html ):
{
    "subscribeUrl": null,
    "type": "Notification",
    "signatureVersion": "1",
    "signature": "fUiwL20YlWZBs1U81vvuAvvzUrQrF0xM2OtBg2UjDo3/YqCIpa/ZEBTMny8hla8Rr5z2SPWSep/W8Id2sSadcxhzFv3EsZ+uNQAfgextxLVr/d5kv5rtBSLI6iQAFbLxWyTVT+SzrTqPrAJF9BzNpM6cCH7h+cFA+aNzfKwLGlefBbzS+T/iwTc8Qt/CZWi3zTS+O86MCMLeaf0ezTQm5Q0ljt0DvGIz5qH/A1dZiGqqA8MuAphoY0r4QSnEQYGoLwMyJBclJNd/MWseIGxoFelOdoSnPvIQzlhUYua/8xVhKUTC3p1seXj6GpAedbzoVWPevmt7U/S2V6uOCthWUg==",
    "topicArn": "arn:aws:sns:us-west-2:XXXXXXXXXXXX:amplify-d1ywkiq91ymgkd_AMPLIBRANCHSENTINEL",
    "signingCertUrl": "https://sns.us-west-2.amazonaws.com/SimpleNotificationService-a86cb10b4e1f29c941702d737128f7b6.pem",
    "messageId": "01661a60-7a0a-511a-ab2a-4dc6be296397",
    "message": "Build notification from the AWS Amplify Console for app: https://master.d1ywkiq91ymgkd.amplifyapp.com/. Your build status is STARTED. Go to https://console.aws.amazon.com/amplify/home?region=us-west-2#d1ywkiq91ymgkd/master/19 to view details on your build. ",
    "subject": null,
    "unsubscribeUrl": "https://sns.us-west-2.amazonaws.com/?Action=Unsubscribe&SubscriptionArn=arn:aws:sns:us-west-2:XXXXXXXXXXXX:amplify-d1ywkiq91ymgkd_AMPLIBRANCHSENTINEL:***REDACTED***",
    "timestamp": "2020-08-07T02:52:19.481Z",
    "token": null
}

Describe the solution you'd like
Amplify already creates an SNS topic for pushing email notifications. The SNS topic could be used as a notification source for Chatbot as well once its supported.

Thanks for the suggestion - I'll label this as a new feature request and get it into our backlog.

@ganipcanot Do you have a rough timeline of when this could be implemented? 🙏

Great feature
Is there an estimated time to add it?

👍 on this feature request. any updates here would be highly appreciated.

Also tried to implement the same and got to the exact same point.

Any plan to tackle this one this year? In the backlog since August 2020. Would be super awesome to get this feature <3 :)

Yes, I also really need this feature, AWS Chatbot notifications for codebuld are great!

joining the wait...

Maybe someone can share a workaround?

Closing this in favor of #271.

I was able to set up an Event Grid rule that got this more or less working. I then added the Chatbot as a subscription to the SNS topic. The transformed event is able to be read by the chatbot, but it's not super pretty. If someone could find better documentation for what inputs the ChatBot looks for, this could be improved.
Event Pattern:
{
  "detail": {
    "appId": ["<<my amplify app id>>"],
    "jobStatus": ["SUCCEED", "FAILED", "STARTED"]
  },
  "detail-type": ["Amplify Deployment Status Change"],
  "source": ["aws.amplify"]
}

Target:
SNS Topic
Input Transformer:
{"account":"$.account","appId":"$.detail.appId","branch":"$.detail.branchName","detail-type":"$.detail-type","id":"$.id","jobId":"$.detail.jobId","region":"$.region","resources":"$.resources","source":"$.source","status":"$.detail.jobStatus","time":"$.time","version":"$.version"}

{
	"version": <version>,
	"id": <id>,
	"detail-type": "<status> build status from the AWS Amplify Console for app: https://<branch>.<appId>.amplifyapp.com/. Go to https://console.aws.amazon.com/amplify/home?region=<region>#<appId>/<branch>/<jobId> to view details on your build. ",
	"detail": "<status> build status from the AWS Amplify Console for app: https://<branch>.<appId>.amplifyapp.com/. Go to https://console.aws.amazon.com/amplify/home?region=<region>#<appId>/<branch>/<jobId> to view details on your build. ",
	"source": <source>,
	"account": <account>,
	"time": <time>,
	"region": <region>,
	"resources": <resources>
}


missing screenshot in elisp/tests

The link to the screenshot is not valid:
https://x.exercism.io/v3/tracks/elisp/docs/img/dual-pane.png

Where are you seeing this link?

here:
https://exercism.io/tracks/elisp/tests
In the last paragraph: Suggestions

Thanks! Opened a PR.


Support for MacOS executors

Describe Request:
The orb does not seem to work on MacOS.
The setup step fails as follows:
#!/bin/bash --login -eo pipefail
Install() {
    PARAM_DD_API_KEY=$(eval echo "\$$PARAM_DD_API_KEY")

    if [[ -n "${DD_SITE}" ]]; then
        PARAM_DD_SITE=${DD_SITE}
    fi

    DD_API_KEY=${PARAM_DD_API_KEY} DD_AGENT_MAJOR_VERSION=${PARAM_DD_AGENT_MAJOR_VERSION} DD_SITE=${PARAM_DD_SITE} \
        DD_HOSTNAME="none" DD_INSTALL_ONLY="true" DD_APM_ENABLED="true" \
        bash -c "$(curl -L https://s3.amazonaws.com/dd-agent/scripts/install_script.sh)"

    if [ "$UID" = "0" ]; then export SUDO=''; else export SUDO='sudo'; fi
    $SUDO find /etc/datadog-agent/conf.d/ -iname "*.yaml.default" -delete
    $SUDO service datadog-agent start
}

# Will not run if sourced for bats-core tests.
# View src/tests for more information.
ORB_TEST_ENV="bats-core"
if [ "${0#*$ORB_TEST_ENV}" == "$0" ]; then
    Install
fi

  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 26191  100 26191    0     0   154k      0 --:--:-- --:--:-- --:--:--  153k
mknod: node type must be 'b' or 'c' or 'w'.

Exited with code exit status 1

CircleCI received exit code 1

Orb version<EMAIL_ADDRESS>

Hello 👋 ,
Currently the orb only works for Ubuntu and Debian based systems. Sorry for the inconvenience I have a task pending to add support for more OS in the upcoming months.

Thank you for the quick response! I assumed this is not supported when I saw the error :)


🐛 [BUG] DoWork gets never called

Describe the bug
I have a very simple Job like this:
public class Test : CronJobService
    {
        public TimTest(ICronConfiguration<TrainingsReminderJob> cronConfiguration)
            : base(cronConfiguration.CronExpression, cronConfiguration.TimeZoneInfo, cronConfiguration.CronFormat)
        {
        }

        public override Task StartAsync(CancellationToken cancellationToken)
        {
            Log();
            return base.StartAsync(cancellationToken);
        }

        public override Task ScheduleJob(CancellationToken cancellationToken)
        {
            Log();
            return base.StartAsync(cancellationToken);
        }

        public async override Task DoWork(CancellationToken cancellationToken)
        {
            await DoMyWorkAsync();
            return base.DoWork(cancellationToken);
        }

I set it up like this:
services.ApplyResulation<Test>(options =>
            {
                options.CronExpression = "* * * * *";
                options.TimeZoneInfo = TimeZoneInfo.Local;
                options.CronFormat = Cronos.CronFormat.Standard;
            });

So it should run every minute. I can see in my logs, that Startasync and ScheduleJob are being called, but DoWork is called never. What am I doing wrong?

I found the issue - it was obviously on my side. I've used a wrong startup-options-class in the constructor of my job. Basically one of another job as can be seen in the coding above (TrainingsreminderJob). So it used a different configuration and not the one I setup to test the job.


"Invalid user settings" message should be more clear

When trying to edit my user settings in ZNC 1.6.1, I randomly got an "Invalid user settings" error when trying to save them in the web interface. It turns out that Firefox was filling in my stored password despite the autocomplete=off markup, and as a consequence it didn't match the password confirmation input field.
ZNC should give more user-friendly feedback by actually indicating which settings were invalid (in this case: "Passwords do not match" or something similar).

Do you happen to be using patched ZNC (the SSL patch or some third party webadmin theme (firre is especially problematic with these issues))? If not, you are probably trying to set some setting as invalid such as emptying realname.
ICU support doesn't affect anything else than charset and if you want it, install libicu-dev (you didn't read the bug reporting guidelines as your OS is missing so I am doing Debian assumption) and recompile ZNC.

Nevermind, I might have found the issue - I do have the main login for ZNC stored in the browser's password manager, but despite the autocomplete=off markup, Firefox seems to keep filling in the password when first visting the page and as such it doesn't match the empty confirm password field.
Nevertheless, it would have been useful if ZNC actually told me e.g. that passwords don't match, rather than making me guess which of the dozens of options on this page is not configured correctly.

Please open separate issue for that or make it clear in the title what this issue is about.

I've edited the title and initial description to be more clear.

I would change the title to Say "Passwords don't match" instead of "Invalid user settings", but maybe the current one is more clear as there are more things that can be invalid too.

Yes, that's my point with the title: ZNC knows exactly which settings are invalid (otherwise it could not emit this error message), so it should tell the user exactly what is wrong - not only for the password fields.

:+1: for this. Noticed this today as well, would be nice to have!

:+1: Thank you! I have been having this problem for a while, but thanks to this issue, I finally know the source of the problem.

Ran into this issue today as well (in Firefox). Might be worth trying some of the tricks mentioned here: https://developer.mozilla.org/en-US/docs/Web/Security/Securing_your_site/Turning_off_form_autocompletion - especially the autocomplete="nope" to trick the browser to not autocomplete.
My guess is that it would also be possible to work around this by using a different name for the input field: Password: <input name="something_random" autocomplete="nope" />.

Same issue happened to me. :+1: on this issue.

@xintron autocomplete="nope" still causes FireFox to autocomplete :-(

@DarthGandalf: The title of the issue was chosen because it was not just about the password field (even though most people seemed to only be concerned about that). Your commit only fixed that part of the problem, so I think the issue should remain open under the old title. There are still other situations where the "invalid user settings" message is not descriptive enough.

@sagamusix ok. I fixed both issues though, in 2 commits.

this is annoying. until i actually stumbled across this and found out that i have to blank the password field i was deleting and resetting up accounts just to get back to changing settings and is still an issue with the latest version of znc. an error messages "SHOULD" always return the setting that caused the error not just that an error occurred and leave it at that. this is a bug still present in the latest version.


Official Alpine and adjust NGINX settings

Official Alpine image (alpine:3.3).
A little bit improved image instruction, reduced size image from 232 MB till 216.3 MB
Disabled access_log at all.
Adjusted NGINX settings (basically i copied them from origin ADOP-Proxy).

LGTM.
Let me know once it's ready to be tagged please.


npm install fails

I tried to set up a dev version of the extension, but npm install fails when compiling src/widget.ts:
src/widget.ts(22,26): error TS2497: Module '"/home/david/src/jupyterlab_geojson/node_modules/@types/lodash/isEqual/index"' resolves to a non-module entity and cannot be imported using this construct.

Here's npm-debug.log.
I know little about TypeScript, but this issue helped me devise a workaround which seems to do the job (in the sense that npm install completes without errors):
diff --git a/src/widget.ts b/src/widget.ts
index 221bcc2..59ad321 100644
--- a/src/widget.ts
+++ b/src/widget.ts
@@ -19,7 +19,8 @@ import {

 import * as leaflet from 'leaflet';

-import * as isEqual from 'lodash/isEqual';
+// import * as isEqual from 'lodash/isEqual';
+var isEqual = require('lodash/isEqual');

 /**

But since I suppose the current code worked for you, the fix should rather be that there's a difference in my environment which has to be accounted for?

The current version doesn't use Typescript so this should be resolved 👍

Indeed, thanks a lot! I'm hoping to glean some inspiration from jupyterlab_geojson as to how to go about building a JupyterLab extension, so this is much appreciated :)

@dlukes Check out https://github.com/jupyterlab/mimerender-cookiecutter. It now support both jupyterlab and notebook extensions and if you're familiar/open to use React, then creating a mimerender extension is as easy as creating a single React component.

Thanks, will do!


Fix broken links

Previously, links to notebooks had included the current directory in the relative path and therefore fail to resolve.

Thank you!!


Issue 430: Make cargo release non-interactive.

Change log description

Adds --no-confirm flag to the cargo release command.

Purpose of the change
Fixes #430
What the code does

Makes the cargo release non-interactive.

How to verify it

All github actions should pass.

Codecov Report

Merging #431 (70d8cff) into master (c881158) will decrease coverage by 13.27%.
The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #431       +/-   ##
===========================================
- Coverage   72.65%   59.38%   -13.27%
===========================================
  Files          49       48        -1
  Lines       12403    11314     -1089
  Branches    12403    11314     -1089
===========================================
- Hits         9011     6719     -2292
- Misses       3392     4595     +1203

see 11 files with indirect coverage changes


Display MANE select option only for human in Variant Recorder (duplicate)

MANE select option in Variant Recorder was being displayed for all species, despite it only being available for human in the data. This was fixed in the code in both Perl and JavaScript side.
Related PR: #605
Sandbox link: http://wp-np2-1e.ebi.ac.uk:8310/Homo_sapiens/Tools/VR

Notes from investigation and discussion:
Cause of the issue is selectToToggle is broken due to https://github.com/Ensembl/ensembl-webcode/blob/release/108/htdocs/components/00_jquery_selecttotoggle.js#L32
https://github.com/Ensembl/ensembl-webcode/pull/908
But Chicken breeds or other species that have . in their names would still break. But that is minor and can be fixed after release 109

Hi @imransl, thanks for the update. I cannot select different species on your sandbox but by testing on my sandbox I can confirm the option mane is not available for other species - I tested the main species we have in variation.
Unfortunately, we have the same issue in VEP. Options like SpliceAI should only be available for human but they are displayed for all species.

This PR is apparently in the wrong branch. Closing this for #661.

Hi @imransl, thanks for the update. I cannot select different species on your sandbox but by testing on my sandbox I can confirm the option mane is not available for other species - I tested the main species we have in variation. Unfortunately, we have the same issue in VEP. Options like SpliceAI should only be available for human but they are displayed for all species.

Thanks for testing @dglemos. I have fixed these issues in two different PRs, one in public-plugins itself and the other in ensembl-webcode. I had to close this PR since it is in the wrong branch.


improvement let default value of alter and load timeout sui…

…table for most cases
It is frustrated that a long running job fails due to small timeout. Actually, users do not expect a timeout for a log running job.
Proposed changes
Issue Number: close #xxx
Problem summary
Describe your changes.
Checklist(Required)

Does it affect the original behavior:

[ ] Yes
[ ] No
[ ] I don't know

Has unit tests been added:

[ ] Yes
[ ] No
[ ] No Need

Has document been added or modified:

[ ] Yes
[ ] No
[ ] No Need

Does it need to update dependencies:

[ ] Yes
[ ] No

Are there any changes that cannot be rolled back:

[ ] Yes (If Yes, please explain WHY)
[ ] No

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

LGTM


Error feedback channel

This PR adds a mechanism through which the library user/caller can receive feedback on connectivity errors that happen in the library. Previously, if a connection error occurred, the caller could not react to it.
This addition is backwards compatible and doesn't change the behaviour of old code that uses this library.

thanks

@nustiueudinastea
Hey Alex, I see the changes you made to this library.
I also am taking a stab at robustifying the library also.
(in a fork at my github page, the original author gave me maintainer privs,
but he has also allowed me to link to my fork)
This file documents the approach I am taking.
Let me know if you have questions.
There is a new repo, and you can post questions here:
https://github.com/cameronelliott/janus-go
😄
_

@nustiueudinastea Alex, are you interesting in maintaining/being the main fork of this project? (emailed you, but haven't heard back)

@nustiueudinastea Alex, are you interesting in maintaining/being the main fork of this project? (emailed you, but haven't heard back)

@cameronelliott I replied to your email but your email server blacklisted my email server for some reason.

@cameronelliott I replied to your email but your email server blacklisted my email server for some reason.

@nustiueudinastea Let's discuss it here.

are you a maintainer on this repo?
do you want to be a maintainer on this repo?

Can I link to your repo in the readme on this repo?

@cameronelliott

No
Sure, I can do it.
Please do. I will do changes there and try to keep this repo in sync.

@cameronelliott

No
Sure, I can do it.
Please do. I will do changes there and try to keep this repo in sync.

@notedit I think @nustiueudinastea might be a better candidate to be the new maintainer of this repo.
Would you please consider adding him as a maintainer?
I have shifted away from Janus use at this time.

@notedit I think @nustiueudinastea might be a better candidate to be the new maintainer of this repo.
Would you please consider adding him as a maintainer?
I have shifted away from Janus use at this time.


[FEATURE]

Is your feature request related to a problem? Please describe.
The new feature to change chat message timestamps to use the SC time is great. However, it does show the HH:mm even if I'm not really using it (I don't synch SC with the clock, or use time, as opposed to date, in any way).
Also, as I haven't set or used time in any way, I don't know why all chat messages appear with 00:05. That's surely not a bug but piloting error, but again, I don't use time with SC, just dates, and I have time disabled everywhere AFAIK.
Describe the solution you'd like
Just an option to specify I don't want time in my timestamps (paradoxical, but true).
Describe alternatives you've considered
I tried to use CSS to just make the HH:mm part invisible, but the whole timestamp is a single span entity.

You can customize this using Chat Message Timestamp Format option in the configuration under Display Options. Just remove the HH:mm from the format and the time will no longer show.

Yes.  Sorry for the noise.

No worries!


Compatibility / Interop with other RTOS

I am very excited to try SRP-style scheduling for more of my projects.
The majority of applications I work on involve some form of mainstream wireless communication (bluetooth, wifi, etc). And, normally the IC mfr. provides some software integrating with a popular RTOS. For example, nrf52 Bluetooth using the Nordic Softdevice, or NimBLE stack running on Apache MyNewt/Zephyr RTOS. Preemptive scheduling or cooperative scheduling is typically used, and in my experience applications integrate + use the same RTOS.
My question is: can crect be used alongside these RTOSes? Does one scheduler fit within another (e.g. crect acts as a blackbox/task within the preemptive RTOS? (or, vice versa, perhaps the RTOS is treated as a blackbox/resource within crect?)
Any tips/suggestions/ideas are welcome (especially if it is a straightforward “no, you cannot do this”)

Hi sorry for the late reply here.
What you are looking for is indeed possible, though not supported. I moved to Rust, and continued this project there and we did develop what you are looking for.
If you let the SRP based system handle interrupts, one can run a normal task/thread scheduler in the idle task. Then you would keep all guarantees that is connected to SRP while keeping the full power of an operating system (with threads/tasks).
If you want to give it a try I'd recommend to start with a simple round robin scheduler in idle and go from there. :)
If you want to check out the Rust project, you can go here: www.rtfm.rs
Good luck!


Add method for updating a pull request review

Fixes: #1174

Add UpdateReview to PullRequestReview.
Add its test.

Thank you, @gauntface!
Merging.

Thank you very much, @gmlewis and @gauntface ! :)


Fix stopwatch and windows startup

Rewrote and organized Stopwatch.
Added EnsureStartWithWindows(bool) method.

@RyanThiele I need an error resolved for this pull request. It comes with some errors that I don't get resolved in stopwatch actions and program.cs


Gather trivy metrics using starboard-exporter

Currently starboard don't expose any metrics from trivy CVE reports.
There is a discussion ongoing in the starboard community about this but it will take some time before anything happens.
In the meantime let's use starboard-exporter.

There is a helm chart in: https://github.com/giantswarm/starboard-exporter and it can be installed using:
helm repo add giantswarm https://giantswarm.github.io/giantswarm-catalog
helm repo update
helm upgrade -i --name starboard-exporter --namespace starboard-operator --version 0.1.2 giantswarm/starboard-exporter

But currently it got a bit to much rbac access and enforces PSP so that is why I use my own chart in this PR. I have created a PR: https://github.com/giantswarm/starboard-exporter/pull/27 with them where I have done some cleanup but more is needed.
When this PR get's merged I will create a new issue going over to there helm chart instead

Starboard is apparently not available in eks core. I will create a seperate PR to fix this. I still add the variable so we can add and disable the metric to be consistent with aks core.

The metric that gets generated looks like this:
starboard_exporter_vulnerabilityreport_image_vulnerability_severity_count{container="starboard-exporter", endpoint="metrics", image_digest="sha256:e9fb216ace49dfa4a5983b183067e97496e7a8b307d2093f4278cd550c303899", image_namespace="ingress-nginx", image_repository="ingress-nginx/controller", instance="<IP_ADDRESS>:8080", job="starboard-exporter", namespace="starboard-operator", pod="starboard-exporter-76c8f9c44b-lcw6m", report_name="replicaset-ingress-nginx-controller-5f5977bd4-controller", service="starboard-exporter", severity="HIGH"}

The starboard-exporter team have decided to minimize the number of labels that generated by only provide a count of how many CVE:s and it's different severity in there metric by default. This is possible to change if we want more information.
But personally I agree with them and think this should be a indicator about something that you need to look deeper in to.
But if want to get the exact CVE id that is possible but it will generate lots of metrics.


Feature request: Maximum transfer total

Now with the Google policy of maximum 750GB per 24hrs, I think it would come in handy to have a flag where the maximum transferred total can be specified. When this total is reached, rclone should just stop.
For example, I'm currently copying an existing remote to a new remote but I also would like to add new stuff.
The copy will now take several days but if this copy always maxes out the 750GB, I'm never able to add new stuff.
So for example, if I could set --max-transfer-total 700GB
That means that I always have 50GB headroom and my drive uploads are still working.

While not ideal, --bwlimit 8500 would limit your upload to ~700GB a day.
Do you have an idea how this would work for mounts, though? Just exiting might leave the mount in an undesirable state…

Good one. I didn't think of --bwlimit as a workaround. I'm going to try that.
As for mounts, I have no idea but I assume there will be weird results when the Google limit kicks on an active mount anyways.
Maybe the option should only work with copy, moveto, sync etc.?

I've been using the --bwlimit as a workaround for 2 weeks now and it works ok. However, I still think it would make sense to be able to set a maximum. That way I can just upload whatever is possible for the day and be done with it.
Right now, with multiple remotes, I have multiple rclone's running 24/7 while that isn't necessary.

This would make scripting especially useful to switching remotes when a specific amount is uploaded.

This item is definitely done as we have a few options now for Google's quota limits so I'm going to close this one out.
If you have a different view, let me know and we can discuss. Thanks!


Unable to update to latest ruby-lsp 0.22.0 with this gem installed

With this gem installed, I am unable to update ruby-lsp to the latest 0.22.0 release since ruby-lsp-rails is pinned to ruby-lsp versions (>= 0.21.2, < 0.22.0). I know 0.22.0 was just released earlier today, but I wanted to get this issue in so any possible compatibility problems can be determined with this gem and ruby-lsp 0.22.0.

Thank you for the report. We always keep a tight constraint because the add-on API is still going through a lot of breaking changes as we understand how to make the most out of it.
Whenever there are new breaking changes, we typically get to them within a few days.
#529 will addresses the breaking changes and we need #527 and #530 to cut a release.

This is completed since v0.3.27.


feat: first implementation

Checklist

[ ] npm test passes
[ ] tests and/or benchmarks are included
[ ] documentation is changed or added
[ ] commit message follows commit guidelines

Affected core subsystem(s)

Description of change

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@570bb64). Click here to learn what that means.
The diff coverage is 76.92%.

@@            Coverage Diff            @@
##             master       #1   +/-   ##
=========================================
  Coverage          ?   76.92%
=========================================
  Files             ?        1
  Lines             ?       26
  Branches          ?        0
=========================================
  Hits              ?       20
  Misses            ?        6
  Partials          ?        0

Impacted Files
Coverage Δ

app/extend/application.js
76.92% <76.92%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 570bb64...ec00422. Read the comment docs.


lib: rbtree: Add RB_FOR_EACH macro for iterative enumeration

Works mostly like the list enumeration macros.  Implemented by fairly
clever alloca trickery and some subtle "next node" logic.  More
convenient for many uses, can be early-exited, but has somewhat larger
code size than rb_walk().
Signed-off-by: Andy Ross<EMAIL_ADDRESS>

Codecov Report

Merging #7481 into master will increase coverage by 0.02%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #7481      +/-   ##
==========================================
+ Coverage   55.25%   55.27%   +0.02%
==========================================
  Files         467      467
  Lines       51656    51686      +30
  Branches     9889     9898       +9
==========================================
+ Hits        28541    28570      +29
- Misses      19205    19206       +1
  Partials     3910     3910

Impacted Files
Coverage Δ

include/misc/rb.h
100% <ø> (ø)
:arrow_up:

lib/rbtree/rb.c
96.56% <100%> (+0.37%)
:arrow_up:

tests/lib/rbtree/src/main.c
98.03% <100%> (+0.14%)
:arrow_up:

lib/posix/pthread.c
69.34% <0%> (-0.51%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 486c5a5...b7e271f. Read the comment docs.

Test failures seem to be down to some of our toolchains not finding their alloca.h correctl.y...

Yeah, it might be better to use VLA rather than alloca() due to differences in toolchains.

Unfortunately I can't find a way to make VLA work in this context, where the term has to appear as an rvalue inside a structure literal.  Rather I could make it work with a gcc compound expression (and maybe with some clever use of an always_inline attribute), but at that point we know we're in gcc and might as well have used ___builtin_alloca() in the first place.

Compound literals are a standard C99 feature.

Sorry, I wrote "compound expression" when I meant "statement expression".  The problem we have here is that we would need to take a VLA declaration of the form:
char is_left_mem[tree->max_depth];

And return its address in a structure literal of the form
{ .is_left = is_left_mem, }
All in the first expression of a for() loop which allows for just one declaration.   With a compount statement I could (in theory, I didn't try) do this by declaring the memory then returning the struct literal.  Similarly always_inline could presumably be used to return a pointer to a VLA which was guaranteed to be on the stack of the caller (but I couldn't make this work).
But both of those are gcc extensions anyway, so they're fundamentally no more or less portable than __builtin_alloca().  And alloca() is standard C and has the advantage of plausibly working on non-gnu toolchains too.


APP-2888: add skipped errors field for api

If there are cloud validations that fail on config retrieval, we want to return that the user but not actually return an error. This accomplishes that.
Goes hand-in-hand with:
https://github.com/viamrobotics/app/pull/2672
https://github.com/viamrobotics/rdk/pull/3078

this needs to be merged in first
and then RDK + then APP

@stevebriskin does this require a scope?

Yes. The new flow is pretty unclear to me and this new field feels like a pretty hacky addition to the most critical rdk<->app api.