Error: "insufficient_scope" when accessing androidpublisher despite scopes & IAM permissions

Hi, I've run in to an issue attempting to verify Google Play payments in a Cloud Run instance. I already successfully use this googleapis package in numerous CloudRun instances and utilise many of the GCP services with it ,however when I try and use the androidpublisher API I get the following error:

Access was denied (www-authenticate header was: Bearer realm="https://accounts.google.com/", error="insufficient_scope", scope="https://www.googleapis.com/auth/androidpublisher").

Access was denied (www-authenticate header was: Bearer realm="https://accounts.google.com/", error="insufficient_scope", scope="https://www.googleapis.com/auth/androidpublisher").
package:googleapis_auth/src/auth_http_utils.dart 40                      AuthenticatedClient.send
===== asynchronous gap ===========================
package:_discoveryapis_commons/src/api_requester.dart 69                 ApiRequester.request
===== asynchronous gap ===========================
package:googleapis/androidpublisher/v3.dart 4191                         PurchasesProductsResource.get
===== asynchronous gap ===========================
package:cloud_functions_core/src/payments/providers/google_play.dart 33  GooglePlayPaymentProvider._updateConsumablePurchase
===== asynchronous gap ===========================
package:cloud_functions_core/src/payments/providers/google_play.dart 22  GooglePlayPaymentProvider.updateReceipt
===== asynchronous gap ===========================
package:cloud_functions_core/src/payments/payment_processor.dart 92      PaymentProcessor.processPurchaseReceipt
===== asynchronous gap ===========================
package:payment_queue/functions.dart 40                                  function

I'm creating the authenticated client with the necessary scopes:

Dart code to generate authenticated client

class GapiLiveService implements GapiService {
  final List<GapiServices> scopes;
  final String? credentials;

  GapiLiveService(this.scopes, {this.credentials});

  @override
  Future<AutoRefreshingAuthClient> get client async {
    List<String> _scopes = <String>[];

    for (final s in this.scopes) {
      _scopes.addAll(GapiService.serviceScopes[s]!);
    }

    print(
        'Created GAPI client (${credentials != null ? 'Creds provided' : 'viaAppDefault'}) with scopes: ($_scopes)');

    return (credentials != null)
        ? await _fromCredentials(_scopes)
        : await clientViaApplicationDefaultCredentials(
            scopes: _scopes, baseClient: http.IOClient());
  }

This code prints out the following log entry:
Created GAPI client (viaAppDefault) with scopes: (
  [
    https://www.googleapis.com/auth/datastore,
    https://www.googleapis.com/auth/cloud-platform,
    https://www.googleapis.com/auth/androidpublisher
  ]
)

I have a IAM profile specifically for this Cloud Run instance with the necessary permissions:

Android Management User
Cloud Filestore Editor
Firebase Admin
Pub/Sub Publisher
Secret Manager Secret Accessor

(However I don't think these are part of the issue as this is a scope error rather than permission error)
Before the instance hits the scope error, it successfully makes a couple of Firestore requests so I know the permissions and scopes are working as expected for that service.
I've been looking at this bug all afternoon and I've checked everything numerous times. I hoped maybe someone might spot something I'm doing wrong or perhaps I've stumbled upon a bug with this API?
Thanks

I don't think this has anything to do with this package, in general. If there's a bug, let us know.
Otherwise, I'd start at https://developers.google.com/android-publisher – dig into support options, etc!

Hallelujah!! Phew I finally got to the bottom of it and got this working.
I think it could be described as a bug @kevmoo -or at least a misleading error message. The error I get through the GCP 'test this method' tool was this:
{
  "error": {
    "code": 403,
    "message": "The project id used to call the Google Play Developer API has not been linked in the Google Play Developer Console.",
    "errors": [
      {
        "message": "The project id used to call the Google Play Developer API has not been linked in the Google Play Developer Console.",
        "domain": "androidpublisher",
        "reason": "projectNotLinked"
      }
    ]
  }
}

-which was much more useful than the insufficient_scope error I was getting from googleapis package. Ideally the googleapis package could provide this specific error? If not then it would be useful to add a notice to the documentation explaining this API has specific credentials requirements? Unlike all the others APIs in the googleapis package, this API can only be queried by using credentials that are linked to your google play developer account and setting that all up is non-trivial.
In case anyone else ends up here with the same issue, this was my solution:
It turns out can only have a single project linked to your Google Play developer account.  Here was my solution:

Go to Google Play Developer Console -> Settings -> API Access and link or create a cloud project (NB: Not the same one your app uses, this should be a generic project)
Create a service worker using this new google cloud project
Go back to Play Console API Access and grant this service worker access to view financial information and manage orders.
Also on the API access screen add permission to your individual apps that this service worker will be querying
Downloaded the JSON key file for this service worker &  add this to the Google secrets manager & expose the secret to my cloud run instance
Retrieve the service worker key in code and then provide it when creating the GAPI client (including the necessary androidpublisher scope).
If you get permission denied error at first, it could be this bug or could be that you need to wait up to 48 hours for the google play permissions to activate (this is so ridiculous!).


narrows reducer: Fix bad sort in an edge case.

It turns out that sort without an explicit comparison function
has surprising behavior -- it converts everything to strings, and
compares the UTF-16 sequences.  So e.g.

[11, 2, 22, 1].sort()
[ 1, 11, 2, 22 ]

This makes it acceptable really only for sorting strings, and even
then only for identifier-like strings.
For numbers, the right pattern is:

[11, 2, 22, 1].sort((a, b) => a - b)
[ 1, 2, 11, 22 ]

A quick grep for nullary sort finds we've mostly handled this
correctly; but a quick grep finds one exception, where we're using
nullary sort on numbers.
Fix the sort.
Happily this isn't a very common codepath, so it isn't likely many
users have hit this bug.
Fixes: #3752

Tested and confirmed against a set of starred messages on CZO. :+1:

Thanks for the review and test!


Shouldn't build-backend be optional?

No. There's no default fallback in PEP517. It must be explicitly stated.

There's this comment in the PEP:

If the pyproject.toml file is absent, or the build-backend key is missing, the source tree is not using this specification, and tools should revert to the legacy behaviour of running setup.py (either directly, or by implicitly invoking the setuptools.build_meta:legacy backend).

The question here is whether pep517.build is purely a mechanism for building projects that use PEP 517, or whether it's a general build tool. My instinct says that it should only try to build PEP 517 style source trees, which means I'd agree that pep517.build should fail if there's no pyproject.toml or build-backend is missing.
The OP didn't give any information on what happens currently, but it's possible that we could give a more informative error if we're given a legacy-style source tree, but that's about as far as I'd go.
https://github.com/pypa/pip/issues/7740 is based on the idea that pep517.build is a general build tool, so adding docs clarifying what pep517.build is intended for would be good as well.

We do already have a compat_system function which loads the buildsystem information, with the setuptools PEP 517 backend as a default if it's missing:
https://github.com/pypa/pep517/blob/0f19610063ed1c9d6bef020df2b724a542a15beb/pep517/build.py#L39-L55
I think it would not be unreasonable to use this for pep517.build.

The question here is whether pep517.build is purely a mechanism for building projects that use PEP 517, or whether it's a general build tool

@takluyver your thoughts on this?
Honestly, I'm 80% there in terms of building a "packagebuilder" library pulled out of pip, that pip starts using for handling all the package building logic; and making that depend on / adopt-into-itself wrappers from pep517. If we want pep517 to be the general purpose build tool, I'll move the code here instead elsewhere. 🙃
If no one is opposed to this happening, given that @pfmoore is now gonna work on the resolver, I'm feeling like I should spend some cycles on this.

AFAIK, a 'general purpose build tool' can now be built entirely around the PEP 517 APIs, simply by using the setuptools legacy backend as the default when a package doesn't specify anything else. I'm happy for that to be part of the pep517 package.
I think the biggest gap is build isolation. I didn't want to depend on virtualenv, because I see this library as a relatively low-level piece of infrastructure. So I hacked together a rough-and-ready BuildEnvironment which doesn't really do isolation, but provides a separate place to install build dependencies.
I guess that the future of this package depends on how you plan to solve that. If there's a lightweight solution, maybe pep517 can be the generic 'packagebuilder'. If it's going to be more heavyweight (e.g. depending on virtualenv), there might be value in a separate low-level package for calling pep517 hooks in a subprocess.

So I hacked together a rough-and-ready BuildEnvironment which doesn't really do isolation, but provides a separate place to install build dependencies.

I am making a metapackaging tool, and one of its features should be converting wheels into distro-specific packages. I mean I need something to install wheels into a separate directory, but have the contents be as if it was installed into another directory. I mean when distro-specific package is installed, it goes to /usr, but when a wheel is needed to be installed for my purposes, it should go to for example ./destdir, but the things generated during installation into ./destdir, i.e. console_scripts, should have the paths that are hardcoded as if it was installed into /usr. Is your solution useful for that?

I think the biggest gap is build isolation.

I sincerelly hope I will be able to disable it without patching pep517 source code or replacing it with an another package.

it should go to for example ./destdir, but the things generated during installation into ./destdir, i.e. console_scripts, should have the paths that are hardcoded as if it was installed into /usr. Is your solution useful for that?

I don't think so, no.

I sincerelly hope I will be able to disable [build isolation] without patching pep517 source code

I think pep517 will always have a lower layer that leaves all isolation and dependency installation to the caller (the Pep517HookCaller interface). My question in this thread is just about whether the layer on top of that should be part of the same package, or installed separately.

With a pypa/build tool on-the-way, I think it's clear that this usecase should be solved by using that. I'm going to go ahead and close this issue eagerly.


Simplify the DCA handling for return nodes.

Description
This simplifies the handling of return nodes during dead code analysis.
Here is the updated graphs for this example:
script;
fn main() -> u64 {
    return 1;
    return 0
}

Before:

After:

Checklist

[x] I have linked to any relevant issues.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] I have updated the documentation where relevant (API docs, the reference, and the Sway book).
[x] I have added tests that prove my fix is effective or that my feature works.
[x] I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
[x] I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
[x] I have requested a review from the relevant team or maintainers.

TL;DR

The PR removes the double edge from the return node to its contained nodes which was a bug :+1:
Moving the "return" edge from the return to the content might actually lead to more complex graphs if we have more then one node in the content.
Can we also remove the "return" edge going from the implicit return to the "main" fn exit?
I see PR as going in the right direction, because to properly handle divergence we will need to dig into the return's content and not only directly connect return to the exit node.

Detailed thoughts
Ha ha, I was thinking about that very same TODO comment today, while pondering on the background thread about our deterministically_aborts + Never + match + TypeInfo::Unknown combo of issues :smile: Though my thinking was more on the question of divergence which was not in focus of this PR.
My thoughts. Removing the double edge from the return node to its content is a simplification. That was definitely a bug before, adding an edge after it was already added in the connect_expression.
Moving the "return" line from the return to the content node might be seen as a simplification, but it looks to me more as a matter of taste. For example, if there are more than one node in the return content like in this example, one might argue that we actually got a more complex graph with more edges (assuming we remove the double edge):
fn main() -> [u64;3] {
    return [1, 2, 3];
    return [1, 2, 3]
}

Before:

After:

But still I think the new approach moves us in the right direction, where we will need to inspect the return content and check for divergence. This is what I planed to do after sorting out the deterministically_abort issue.
What I want to say, in an example like the one below, we cannot simply connect all the parts of the content to the exit node or mark them as reachable. The variable a is not reachable and it should be reported as such, but DCA currently does not marks it as such, because in both the new and old implementation of return it assumes that whatever is in return will be reachable which must not be the case.
fn main() -> [u64;3] {
    let a = 123u64;
    return [0u64, return [1, 2, 3], a];
}

For the same example, Rust will properly report that a is not reachable because of the preceeding return [1, 2, 3].
But sorry, I went a bit too far, divergence is way out of scope of this PR :smile:
A detail perhaps being relevant to this PR is that one "return" edge going from the implicit return to the "main" fn exit. Can we also remove that edge or it needs to stay?


Settings saving spinner invisible in night mode (and looks bad in light mode)

I was seeing the loading spinner state after clicking "save" had the spinner missing, and realized the problem was that it's invisible in night mode.
@shubhamdhama FYI.

@zulipbot claim


add compatibility to requests-cache = 0.8

requests-cache 0.8 is a dependency of pygbif and was recently updated to 0.8.
This version breaks compatibility with this package
  ModuleNotFoundError: No module named 'requests_cache.core

I suggest, to freeze the dependency to 0.7.4 fo rnow

sounds good. I use 0.7.4 now in gbif-df. But maybe its good to issue a minor release of pygbif sooner rather than later


BUG: model.close and applicaton.close dont work

Describe the bug
When calling the close method nothing happens
To Reproduce
Steps to reproduce the behavior:

Create API Connection to a RSTAB Model
Call model.close or application.close
see error  or in this case nothing
Expected behavior
I ex

Screenshots
i expect the model to close when i call model.close and the application to close when i call application.close
Desktop (please complete the following information):
OS: e.g. WIN 10 PRO Version 10.0.19043 Build 19043
RSTAB 9.01.0008

Additional context
Add any other context about the problem here.

Hi @talSas,
I have checked this issue and I'm not able to reproduce it. I use public void close_model(int index, bool save_changes) for closing of model and  public void close_application() for closing of application. Please can you try to use the RSTAB 9.01.009?

Hey,
yes you are right with the methods RstabApplicationClient.close_application() and
RstabApplicationClient.close_model(int no, bool saveChanges)
the closing of the application and the model works.
Besides these methods there are RstabModelClient.Close()
and a simple RstabApplicationClient.Close()
these last two methods have no function, respectively no recognizable one.
Not even in RSTAB 9.01.009.
Best regards

Ah, I did not know them. They are from parent class ClientBase. See documentation here https://docs.microsoft.com/en-us/dotnet/api/system.servicemodel.clientbase-1?view=dotnet-plat-ext-6.0.
Close() | Causes the ClientBase object to transition from its current state into the closed state. If I got it right, you close connection with Server - disconnect from model in RSTAB or application itself. Once used you will need to reconnect.

Ah, I did not know them. They are from parent class ClientBase. See documentation here https://docs.microsoft.com/en-us/dotnet/api/system.servicemodel.clientbase-1?view=dotnet-plat-ext-6.0.
Close() | Causes the ClientBase object to transition from its current state into the closed state. If I got it right, you close connection with Server - disconnect from model in RSTAB or application itself. Once used you will need to reconnect.

ah okay, I didn't know that either. Thanks for the explanation.

You are welcome


Rewrite soft-contacts algorithm

For maintainability purpose, the algorithm has been rewritten to operate on an individual point, and then applied model-wise through jax.vmap
The computation of the position and velocities of the collidable points now does not longer use removed jax.experimental resources

cc @fl-ferr


oqsx_key_fromdata returns success when no private and public are provided

Hey!
I've been playing with oqs provider. I noticed that in oqsx_key_fromdata that if the user screws up and doesn't provide a priv and does not provide a pub OSSL_PARAM, that success is returned. Would it make more sense to only return 1 if something was successfully imported?

Thanks for the report @Martyrshot . For this function, indeed, it's not sensible to return OK if both parameters are missing. Please feel free to check whether #296 fixes the issue in your eyes. This is mostly due to the fact that this function is used throughout the provider and sets necessary logic for private only, public only, or complete key pairs.
In general, though, if a user is calling a function without parameters properly set thus leading to a no-operation is not something the provider needs (or IMO sensibly ought) to report: The resultant behaviour (of incorrectly called param getters and setters) will become (more) obvious (to the user) later -- then at the actual operation. As an example, should it be considered an error to not pass a bit length param to a key gen initialization? I don't think so: Rationale: A wrong size parameter passed as parameter to a key gen context creation generally cannot be detected as an error (unlike a completely missing parameter). Both user mistakes will become obvious(ly understandable to the user) at the actual key gen operation, though.


Feature/1113

#1113
Ready for review in branch feature/1113 at http://localhost:3030/toggle
NOTE: The color of the checked state is a little different from the design. I used the same color as the checked checkboxes instead of the darker one. Best to keep it the same for theming purposes. See https://github.com/SAP/techne/pull/1200/files#diff-e5af031203d514a0a6eab99b64f3d668R18

@xak
One detail missing: Hover border effect like checkboxes and radio buttons is missing

@joseegm Hover state is there now.


Fix iso provider web

Builds on top of #81 to fix #80.
Fixes types problems and properly adds utils package to the isomorphic dependencies.

Link T-14651


Mikrotik integration device name

The problem

Mikrotik integration allows changing both device_id and name, however, changing those, doesn't change name in Mikrotik integration under device column.
Environment

Home Assistant release with the issue: 0.105
Last working Home Assistant release (if known):
Operating environment (Hass.io/Docker/Windows/etc.): Docker
Integration causing this issue: Mikrotik
Link to integration documentation on our website: https://www.home-assistant.io/integrations/mikrotik/

Problem-relevant configuration.yaml

Added though integrations page.

Traceback/Error logs

Additional information

I have changed names for all of the devices above, however, they still show this name in this specific page.

Hi @klejejs , can you show us a screenshot of one of the devices page. Did you rename the device itself or only the device_tracker entity?

Oh, I am sorry. I only renamed the entity. My bad. Thank you!


minor grammatical changes

[ x] I have read freeCodeCamp's contribution guidelines.
[ x] My pull request has a descriptive title (not a vague title like Update index.md)
[ x] My pull request targets the master branch of freeCodeCamp.
[ x] None of my changes are plagiarized from another source without proper attribution.
[ x] All the files I changed are in the same world language (for example: only English changes, or only Chinese changes, etc.)
[ x] My changes do not use shortened URLs or affiliate links.

Closes #XXXXX

Hi @mmmeyers

[ ] My pull request has a descriptive title (not a vague title like Update index.md)

Did you get a chance to follow the checklist? Can you please update the PR to be more meaningful for maintainers to be able to review your pull request.


Use klog instead of glog

What this PR does / why we need it:
glog and klog are incompatible because they use the same flagnames. Switching over, because all our dependencies started using klog.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
none

/fyeah
/lgtm

/retest

/retest


ts: Migrate feedback_widget to TypeScript.

This PR migrates feedback_widget module to TypeScript.

Self-review checklist

[x] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[x] Explains differences from previous plans (e.g., issue description).
[x] Highlights technical choices and bugs encountered.
[x] Calls out remaining decisions and concerns.
[x] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[x] Each commit is a coherent idea.
[x] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[x] Visual appearance of the changes.
[x] Responsiveness and internationalization.
[x] Strings and tooltips.
[x] End-to-end functionality of buttons, interactions and flows.
[x] Corner cases, error conditions, and easily imagined bugs.

@timabbott This is passing all tests now, ready for your review now.

Cool, one question which probably will have the answer in the form of what TypeScript error we get; otherwise looks fine.
(We could pick better names maybe, but this is a pretty low importance module and I'm not sure I want to spend the time on it)

OK, that seems reasonable, merged, thanks @Lalit3716!

Though maybe it's worth looking as a follow-up at whether we should be using this: https://www.typescriptlang.org/docs/handbook/2/functions.html#declaring-this-in-a-function as suggested in the https://typescript-eslint.io/rules/unbound-method; I've no idea if that's a good idea.


Upgrade to Bitcoin Core 0.16.0

Make sure that the api supports Bitcoin core 0.16.0. Check what changes are required to support the new bech32 addresses, and the removal of the Account feature (which was deprecated since 0.15).

The  Bitcoin API function that has been removed in 0.16.0 that we have been using is getinfo, which we used to use to check if the requested node is running testnet or mainnet. This has been replaced by calling getblockchaininfo instead and checking the chain argument.
There are however several account features that are used that are deprecated in 0.16.0, and need to be changed in the future.


Fix trailing comma error in stages macro.

Fixes #62. Turns out a ! character was missing from the macro definition.

The loss in coverage is due to the added test. The system code there is executed by the test.


full term table should include both labels and structured comment names

https://genomicsstandardsconsortium.github.io/mixs/term_list/
only has the latter

Can be closed by PR #784


Add tags support

We use ekg to connect up to datadog, and the latter supports breaking out metrics by "tags" but ekg doesn't seem to offer a way to do this?
It would be nice to add tags support to ekg. I'm open to working on this if the maintainers are up for it, and willing to give a little guidance.

I have nothing against, as long as it doesn't overcomplicate the interface for people who don't need tags.
/cc @tibbe


community: add Teradata Document Loader

Description:
This pull request introduces a new document loader for Teradata. The teradata.py loader allows LangChain to interact with Teradata databases, facilitating the retrieval and loading of records as documents stored within Teradata.
Issue:
N/A
Dependencies:
This implementation requires teradatasql as a dependency for interacting with Teradata databases.
Twitter handle: https://twitter.com/janeth_graziani
Unit Tests:
I have included unit tests to validate the functionality of the Teradata document loader without requiring network access. I will also provide an example Jupyter notebook to showcase how to use this integration.
I have run make format, make lint, and make test in accordance with the LangChain contribution guidelines.

Hi @efriis ! Thank you so much for reviewing this PR. I have included a Jupyter notebook example. It is ready for your review.

Hi @efriis. Checking in on this. Is there anything I can do to make sure it passes the CI tests so it can be merged? Thank you so much :)

closing for now - happy to take another look if you get lint/testing passing locally! https://python.langchain.com/v0.2/docs/contributing/testing/ https://python.langchain.com/v0.2/docs/contributing/code/setup/#formatting-and-linting


Make flyers beautiful and standard

Just a crazy idea for now. More research is needed.
Promoters create flyers in PDF (it's probably USAC requirement to be in PDF, need to research that). But they all look custom, inconsistent and in 99.99999999% plain ugly (sorry promoters). It's hard to navigate visually and find important information, so it would be nice to have a standard flyer format. Couple of statements:

information if flyers is mostly same
race details, location, distance, start times, categories, etc
promoter info
arbitrary notes
entry fees and links on registration pages + instructions
sponsor logos
tbd

So having a nice online builder that can produce PDF (if that is required by USAC) may be a good tool for promoters and this would remove the need to enter category/start times information manually if everybody would use that.

haha Freedom from ugly flyers ^^

I like this idea, I just don't understand how it would look. Like some app or just html page with fields to fill?

@Me4ta html page at rcn.io/flyers/new to create one, would present you with fields to fill on the left side + realtime preview how it looks on the right side.
Buttons "Save" and "Download as PDF" and optionally "Copy link to PDF" (we need to think this through)


One more thing

Basically #3 but cleaned up

@homu r+

:pushpin: Commit 99b8e62 has been approved by badboy

:hourglass: Testing commit 99b8e62 with merge b5d7fcb...

:sunny: Test successful - status


dev: UI overhaul

I'm looking into Polymer - seems to allow nice separation between view and API?
Though I'm not much of a frontend coder (yet).

Since opening this one I've hacked enough CSS and GopherJS into the dev version to be worthy of "probably less ugly" and possibly even "almost usable", which I'll call an improvement. It's a lofty goal but not precisely specified, so it's time to close this issue.


Added options for number column - prefix, suffix and separator option

Hey,
I wanted to get the codebase better, so I tried to implement something simple first.
So I thought #636 might be an easy start.
Would be great to get some feedback on the changes I made.

I implemented an options field for prefix, suffix and separator. Only the display value changes, when editing the field, the raw number will be shown.
PS. kinda new to OS, so don't know what else to write

Could you please make these changes on a child branch of dev instead of master? Merging master into dev goes against the branching strategy that I have setup of <feature> -> dev -> master

First identify that commits that you want to move from your branch. You can find the commit hashes using git log
Next checkout dev branch

   git checkout dev
   git pull origin dev

Create a new branch off of dev

git checkout -b <your-branch-name>

Use the git cherry-pick command to apply the desired commits to your new branch created off of dev. Replace [commit1], [commit2], etc., with the actual commit hashes you want to move:

   git cherry-pick [commit1] [commit2] ...

Resolve any conflicts that may arise during the cherry-pick process. After resolving conflicts, continue the cherry-pick process by running:

   git cherry-pick --continue

Once all the commits have been cherry-picked successfully, you can push your changes to the remote

   git push origin <your-branch>

Open a new pull request for that branch

Sorry, I actually wanted to do the cherry-picking, but had my hands full the last days. Next time I'll write, that I'm gonna do it :)


Video volume slider has no effect

I set the video volume slider in every shelf to 0 but I still get video sound when I mouseover a game.

fixed in 2.12.5

Can confirm its fixed. Thanks.


[Suggestion] Port to Forge

I have been using this mod for a long while now and it is so useful for my datapack creations.. It allows me to create custom togglable armor using a hotkey and trigger commands. The only problem is that my minecraft server with me and my friends on 1.20.4 requires forge. It would be amazing if you could port it to forge or something like that.. It's okay if you cannot. If not, it would be nice if you could provide me with a link to a mod that allows me to run this mod on forge..

My Toggleable Stealth armor that allows to completely make player invisible including particles and sound effects. Also hides nametag when full set is equipped. Is impervious to spectacles that I made that allow to see invisible players within 30 blocks translucently for 30 seconds.

I don't currently have plans to port this mod to Forge. I don't have experience with Forge and I currently lack the time and energy to learn it. I'm not saying it won't happen but it's not something I can commit to or provide a timeline for at the moment


Date searches aren't working

Looks like maybe the log is getting truncated too early during search.

Generate both date types for auth.log search and run union search.


Testing readme examples

Update readme examples so they run on the current master branch
implementation.
Update the formatting so that short examples are easier to new users
to paste into the repl

@tpoulsen I've updated the readme tests to better match the readme


Nuget Package Error

Getting this error when trying to install Meeg.Kentico.ContentComponents on my MVC Site:
Error		Could not install package 'Meeg.Kentico.ContentComponents.Cms 0.1.0'. You are trying to install this package into a project that targets '.NETFramework,Version=v4.6.1', but the package does not contain any assembly references or content files that are compatible with that framework. For more information, contact the package author.
If you can republish awesome, i'm actually needing this for a demonstration at a talk I'm giving on Data Modeling and would love to give a plug in for it :)

Adding a new note to this, it looks like this was built in 4.7.2, which Kentico 12 is available in 4.6.1 upwards, so this module cannot be installed on any Kentico instance that is using the base .net framework.
Is there anyway you could repackage this in 4.6.1, since that can be used on any K12 instance 4.6.1 upwards?

Hi @KenticoDevTrev thanks for getting in touch. The first thing I do on a new Kentico project is update the target framework and I hadn't considered the impact of that in relation to these packages. Targeting the lowest possible framework version makes sense. I can't think of anything in these particular packages that requires 4.7.2 so dropping back to 4.6.1 shouldn't be an issue.
As soon as I get the time I will look at doing so. No promises, but when is your demo?

It's Saturday but no big rush, I forked it, changed the frameworks and integrated it manually and got it working without the nuget package, pretty slick! Looking forward to when it's installable in the nuget package!

Also Matt is wondering why you didn't tell him about this ;)

Any luck on the rebuild in 4.6.1?  I'm going to do a manual install of it again, if you can get it rebuilt on 4.6.1 that would really rock!

Hi @KenticoDevTrev, it's taken me a while to get to this, but I will push a new release some time this weekend that will include this and a fix for #3.


Day 408

Good morning! Here's your coding interview problem for today.
This problem was asked by Facebook.
Given an array of numbers representing the stock prices of a company in chronological order and an integer k, return the maximum profit you can make from k buys and sells. You must buy the stock before you can sell it, and you must sell the stock before you can buy it again.
For example, given k = 2 and the array [5, 2, 4, 0, 1], you should return 3.

Identical to Day 130: https://github.com/vaskoz/dailycodingproblem-go/issues/265


Type of universityRankingRange is incorrect in usage of UserPreferences in ServerProfileDataAccessObject

In the try body of the getProfile() function in ServerProfileDataAccessObject, the typing and functions used are on an ArrayList object instead of a finite list of integers Integers[]. There's going to be some typing errors when I try to use that function to return profiles, so the functions used to format the input from the responseBody are going to have to be manipulated somewhat

Should be fixed, see #129


Forever doesn't start the server

Upon a clean install I have the following layout and content!
screenshot from 2015-03-01 15 04 41
When i run app.js it tells me SERVER JS!
Running node build.js results in clean -> compileStylus, compileLivescript, compileLess, compileJade, compileCopy, compileCoffeescript, compileBabel - Start and Finish.
However the server (build/server/app.js) doesn't start!
So my program gets compiled but it doesn't get started

This should be fixed with 1.5.1, can you confirm this @hawkerboy7 ?

It's fixed! Thx!


Update installation documentation for the new CRD helm chart

update quick start install instructions
update quick start uninstall instructions

fixed


#DeprecateInputDefSources Deprecate "sources()" method in InputDef and rely on the AnnotationTag to determine if Injection is needed

If this change is made, the auto-generated GraphQL Aggregator Vajrams will no longer work because they don't have facet fields in the facets class. This change can be made only after the code generator is changed to generate VajramDef class with _Facets class instead of generating the Impl class.


[1.20.4 Fabric Server] Crashing on Startup

Hello, I recently updated to 1.20.4 from 1.20.1 and went through the appropriate V2 to V3 migration, but something isn't quite working right.
Until then, I'll not have the mod.
Here is a pastebin of the log:
https://pastebin.com/Cqc0aYxU
Any help would be appreciated!
Thanks
Edit:
Using the 3.0.1 version from Modrinth

Caused by: shadow.hypherionmc.moonconfig.core.conversion.InvalidValueException: Unexpected element of type class java.lang.Long in collection of objects

I suspect this is something we missed in the migration guide, but channel ids now need to be wrapped in "".
So if the id was 12345657 in V2, it must be "12345657" in v3

Okay, let me check through all that and I will post back!

All of those were in "".
When I updated, I let the mod create an empty config file for me. That way, I could copy and paste what I needed to.
Perhaps it is something that I overlooked. It wouldn't be the comma and space to separate the role ids would it?
`#General Mod Config
[general]
#Should the mod be enabled or not
enabled = true
#Enable Additional Logging. Used for Fault Finding. WARNING: CAUSES LOG SPAM!
debugging = false
#Internal version control. DO NOT TOUCH!
configVersion = 14
#Config specific to the discord bot
[botConfig]
#The token of the Discord Bot to use. This will be encrypted on first load. See https://sdlink.fdd-docs.com/initial-setup/ to find this
botToken = "removed"
#How often the Bot Status will update on Discord (in Seconds). Set to 0 to disable
statusUpdateInterval = 30
#Control what the Discord Bot will display as it's status message
[botConfig.botStatus]
	#Do not add Playing. A status to display on the bot. You can use %players% and %maxplayers% to show the number of players on the server
	status = "Enjoying Minecraft with %players%/%maxplayers% players"
	#The type of the status displayed on the bot. Valid entries are: PLAYING, STREAMING, WATCHING, LISTENING, CUSTOM_STATUS
	botStatusType = "CUSTOM_STATUS"
	#The URL that will be used when the "botStatusType" is set to "STREAMING", required to display as "streaming".
	botStatusStreamingURL = "https://twitch.tv/twitch"

#Define how the bot should handle channel topic updates on the chat channel
[botConfig.topicUpdates]
	#Should the bot update the topic of your chat channel automatically every 6 Minutes
	doTopicUpdates = false
	#A topic for the Chat Relay channel. You can use %player%, %maxplayers%, %uptime% or just leave it empty.
	channelTopic = "Playing Minecraft with %players%/%maxplayers% people | Uptime: %uptime%"

#Configure the in-game Discord Invite command
[botConfig.invite]
	#If this is defined, it will enable the in-game Discord command
	inviteLink = "removed"
	#The message to show when someone uses /discord command. You can use %inviteurl%
	inviteMessage = "Hey, check out our discord server here -> %inviteurl%"

#Config relating to the discord channels and webhooks to use with the mod
[channelsAndWebhooks]
#A DIRECT link to an image to use as the avatar for server messages. Also used for embeds
serverAvatar = ""
#The name to display for Server messages when using Webhooks
serverName = "Minecraft Server"
#Config relating to the discord channels to use with the mod
[channelsAndWebhooks.channels]
	#REQUIRED! The ID of the channel to post in and relay messages from. This is still needed, even in webhook mode
	chatChannelID = "1063934145320976444"
	#If this ID is set, event messages will be posted in this channel instead of the chat channel
	eventsChannelID = "1063934145320976444"
	#If this ID is set, console messages sent after the bot started will be relayed here
	consoleChannelID = "0"

#Config relating to the discord Webhooks to use with the mod
[channelsAndWebhooks.webhooks]
	#Prefer Webhook Messages over Standard Bot Messages
	enabled = false
	#The URL of the channel webhook to use for Chat Messages. Will be encrypted on first run
	chatWebhook = ""
	#The URL of the channel webhook to use for Server Messages. Will be encrypted on first run
	eventsWebhook = ""
	#The URL of the channel webhook to use for Console Messages. DOES NOT WORK FOR CONSOLE RELAY! Will be encrypted on first run
	consoleWebhook = ""

#Configure which types of messages are delivered to Minecraft/Discord
[chat]
#Use linked account names in Discord/Minecraft messages, instead of the default ones
useLinkedNames = true
#Convert Discord to MC, and MC to Discord Formatting
formatting = true
#Should console messages be sent to the Console Channel
sendConsoleMessages = false
#The type of image to use as the player icon in messages. Valid entries are: AVATAR, HEAD, BODY, COMBO
playerAvatarType = "HEAD"
#Should messages sent with TellRaw be sent to discord as a chat? (Experimental)
relayTellRaw = true
#Should the entire command executed be relayed to discord, or only the name of the command
relayFullCommands = false
#Should messages from bots be relayed
ignoreBots = true
#Should SERVER STARTING messages be shown
serverStarting = true
#Should SERVER STARTED messages be shown
serverStarted = true
#Should SERVER STOPPING messages be shown
serverStopping = true
#Should SERVER STOPPED messages be shown
serverStopped = false
#Should the chat be relayed
playerMessages = true
#Should Player Join messages be posted
playerJoin = true
#Should Player Leave messages be posted
playerLeave = true
#Should Advancement messages be posted
advancementMessages = true
#Should Death Announcements be posted
deathMessages = true
#Should Messages from the /say command be posted
sendSayCommand = true
#Should commands be posted to discord
broadcastCommands = false
#Commands that should not be broadcast to discord
ignoredCommands = ["particle", "login", "execute"]
#Allow mentioning discord roles, users and channels from Minecraft Chat
allowMentionsFromChat = true
#Change the format in which messages are displayed
[messageFormatting]
#Prefix to add to Minecraft when a message is relayed from Discord. Supports MC formatting. Use %user% for the Discord Username
mcPrefix = "§e[Discord]§r %user%: "
#Server Starting Message
serverStarting = "Server is booting up..."
#Server Started Message
serverStarted = "Server boot up complete"
#Server Stopping Message
serverStopping = "Server is shutting down..."
#Server Stopped Message
serverStopped = "Server has stopped..."
#Player Joined Message. Use %player% to display the player name
playerJoined = "%player% has joined the server!"
#Player Left Message. Use %player% to display the player name
playerLeft = "%player% has left the server!"
#Achievement Messages. Available variables: %player%, %title%, %description%
achievements = "%player% has made the advancement [%title%]: %description%"
#Chat Messages. THIS DOES NOT APPLY TO EMBED OR WEBHOOK MESSAGES. Available variables: %player%, %message%
chat = "%message%"
#Death Messages. Available variables: %player%, %message%
death = "%player% %message%"
#Command Messages. Available variables: %player%, %command%
commands = "%player% executed command: %command%"
#Change in which channel messages appear
[messageDestinations]
#Control where CHAT messages are delivered
[messageDestinations.chat]
	#The Channel the message will be delivered to. Valid entries are CHAT, EVENT, CONSOLE
	channel = "CHAT"
	#Should the message be sent using EMBED style messages
	useEmbed = true
	#Embed Layout to use
	embedLayout = "default"

#Control where START messages are delivered
[messageDestinations.start]
	#The Channel the message will be delivered to. Valid entries are CHAT, EVENT, CONSOLE
	channel = "EVENT"
	#Should the message be sent using EMBED style messages
	useEmbed = true
	#Embed Layout to use
	embedLayout = "default"

#Control where STOP messages are delivered
[messageDestinations.stop]
	#The Channel the message will be delivered to. Valid entries are CHAT, EVENT, CONSOLE
	channel = "EVENT"
	#Should the message be sent using EMBED style messages
	useEmbed = true
	#Embed Layout to use
	embedLayout = "default"

#Control where JOIN messages are delivered
[messageDestinations.join]
	#The Channel the message will be delivered to. Valid entries are CHAT, EVENT, CONSOLE
	channel = "EVENT"
	#Should the message be sent using EMBED style messages
	useEmbed = true
	#Embed Layout to use
	embedLayout = "default"

#Control where LEAVE messages are delivered
[messageDestinations.leave]
	#The Channel the message will be delivered to. Valid entries are CHAT, EVENT, CONSOLE
	channel = "EVENT"
	#Should the message be sent using EMBED style messages
	useEmbed = true
	#Embed Layout to use
	embedLayout = "default"

#Control where ADVANCEMENT messages are delivered
[messageDestinations.advancements]
	#The Channel the message will be delivered to. Valid entries are CHAT, EVENT, CONSOLE
	channel = "EVENT"
	#Should the message be sent using EMBED style messages
	useEmbed = true
	#Embed Layout to use
	embedLayout = "default"

#Control where DEATH messages are delivered
[messageDestinations.death]
	#The Channel the message will be delivered to. Valid entries are CHAT, EVENT, CONSOLE
	channel = "EVENT"
	#Should the message be sent using EMBED style messages
	useEmbed = true
	#Embed Layout to use
	embedLayout = "default"

#Control where COMMAND messages are delivered
[messageDestinations.commands]
	#The Channel the message will be delivered to. Valid entries are CHAT, EVENT, CONSOLE
	channel = "EVENT"
	#Should the message be sent using EMBED style messages
	useEmbed = false
	#Embed Layout to use
	embedLayout = "default"

#Control where messages that match none of the above are delivered
[messageDestinations.custom]
	#The Channel the message will be delivered to. Valid entries are CHAT, EVENT, CONSOLE
	channel = "EVENT"
	#Should the message be sent using EMBED style messages
	useEmbed = false
	#Embed Layout to use
	embedLayout = "default"

#Manage access to your server, similar to whitelisting
[accessControl]
#Enable Access Control
enabled = true
#Does the player need to be a member of your discord to join
requireDiscordMembership = true
#Can players verify multiple Minecraft Accounts
allowMultipleAccounts = false
#Optional: The player requires any of these roles to be able to join your server
requiredRoles = [1092609240293707783,<PHONE_NUMBER>574399488,<PHONE_NUMBER>349492800]
#Optional: Players with these roles will never be allowed access to your server
deniedRoles = [1065533343824887818]
#Optional: Role name or ID to assign to verified player accounts
verifiedRole = "1094388955291603005"
#Should players with verified accounts, be banned from Minecraft if they get banned on discord
banPlayerOnDiscordBan = true
#Should members with verified accounts, be banned from discord when they are banned on Minecraft
banMemberOnMinecraftBan = false
#Configure messages shown to players when they don't meet verification requirements
[accessControl.verificationMessages]
	#The message shown to players that are not verified
	accountVerification = "This server requires account verification. Your verification code is: {code}. Please visit our discord server for instructions on how to verify your account."
	#Message to show to players that are not a member of your discord
	nonMember = "Please join our discord server at 'https://discord.gg/8jpgdXXstQ' to apply to join."
	#Message to show when player doesn't have one of the required roles. Use {roles} to display the names of configured roles
	requireRoles = "Sorry, but you require any of the following roles: {roles}"
	#Message to show when player has a role from the deniedRoles list
	roleDenied = "Sorry, but your whitelist application was denied, thus you can't access this server."

#Execute Minecraft commands in Discord
[minecraftCommands]
#Allow executing Minecraft commands from Discord
enabled = false
#Command Prefix. For example ?weather clear
prefix = "?"
#List of command permissions
permissions = []
#Configure messages that will be ignored when relaying to discord
[ignoredMessages]
#Filter certain types of messages from being relayed back to discord
ignoredMessages = true
#List of entries to process
entries = []
#Ignore messages sent from certain threads
ignoredThreads = []`

requiredRoles = [1092609240293707783,<PHONE_NUMBER>574399488,<PHONE_NUMBER>349492800]
deniedRoles = [1065533343824887818]

These all need to be in ""
For reference: SDLink Beta Docs

Oooh, I must have missed that initially facepalm

Cheers!


Move network policies out of team service object

WHY

Network policies are about workloads (Pods) not services
Egress policies are namespace wide

User Story
AS A A team user
I WANT TO to access team network policies from the left side menu AND and use Pod labels to assign the ingress Policies
SO I can define them independently from workloads and services AND I can also allow traffic from namespaces that do not belong to any team
Acceptance criteria
GIVEN existing networkPolicy object in each team service
WHENI upgrade Otomi to a new version
THENAll the policies are migrate from <team>.services.[*].networkPolicy to <team>. networkPolicies[*]
GIVEN podSelector that is applicable only to the ingressPrivate (not to egressPublic)
WHEN I upgrade Otomi to a new version
THEN podSelector is migrated under the ingressPrivate property AND renamed to fromLabel
GIVEN ingressPrivate property with team and service properties
WHEN I upgrade Otomi to a new version
THEN team property is renamed to fromNamespace
AND team property values prefixed with team-
AND service property is renamed to toLabel
Definition of done

[ ] Relevant PRs are merged
[ ] Tested by peer
[ ] Updated documentation reviewed by peer
[ ] Short demo video recorded and stored on google drive (if applicable)

example:
netpol:
   - type: ingressPrivate
      name: my-net
     toNamespace: team-a
     fromNamespace: team-b
     toLabel:
      - a=b
     fromLabel:
      - a=b
   - type: ingressPrivate
     name: my-net-2
     toNamespace: team-a
     fromNamespace: team-b
     toLabel:
      - a=b
     fromLabel:
      - a=b
    - type: ingressPrivate
      name: toGoogle
      domain: https://google.com

I am going to perform some tests and will update documentation about testing & troubleshooting netpols.


solc: Better file tree output if incompatible versions are detected

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
The current output if incompatible versions are detected is not really easy on the eye
Describe the solution you'd like
A clear and concise description of what you want to happen.
tree like output with incompatible files highlighted
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

^@mattsse what did you have in mind here? (separately: can you maybe delete the template output if it's unused?)

If we encounter incompatible imports then we print all of them which can get quite large and it's not immediately obvious which file(s) are incompatible.
this error message should be improved with

better formatting
highlighting incompatible compilers

ref #1023


feat: allow readable in run block

SSIA

Codecov Report
Patch coverage: 97.50% and project coverage change: -0.57% :warning:

Comparison is base (a9d5e9f) 100.00% compared to head (a5a39af) 99.43%.

Additional details and impacted files
@@             Coverage Diff             @@
##            master      #18      +/-   ##
===========================================
- Coverage   100.00%   99.43%   -0.57%
===========================================
  Files            7        7
  Lines          522      534      +12
  Branches        82       88       +6
===========================================
+ Hits           522      531       +9
- Misses           0        3       +3

Files Changed
Coverage Δ

test_stream.ts
99.40% <97.50%> (-0.60%)
:arrow_down:

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Reference docs for azure-keyvault v1 gets re-directed to use the preview moniker instead of legacy

This is the API reference docs link for the azure-keyvault package: https://docs.microsoft.com/en-us/python/api/overview/azure/keyvault. Unfortunately this link gets re-directed in a way such that it gets the query parameter view=azure-python-preview which makes the page use the "preview" moniker. It should be using view=azure-python-previous instead so that the "legacy" moniker is used and the right content gets rendered for azure-keyvault.
Found during #15110
Nice catch @mccoyp!

This seems to have been resolved -- following the link in the description or the version 1.x.x "Reference" link in the KV overview page leads to the correct, legacy page. Closing as a result, thank you!

This seems to have been resolved -- following the link in the description or the version 1.x.x "Reference" link in the KV overview page leads to the correct, legacy page. Closing as a result, thank you!


Modify content structure of "Deploy your Smart Contracts" and get back custom-css to modify sidebar

Did a couple of small tweaks to deploy-smart-contracts.mdx to make the content more readable, and got back custom.css to the repo and uncommented it on Docusaurus config.
List of changes:

Set headers for each step of Deploy Smart Contracts.
Create a new section in Deploy Smart Contracts for Third Party APIs in Production-Level Apps,
Initial css config for sidebar level 2 items to make the sidebar more readable.

We can work from here and set more styles when needed for the rest of the Docs.
Solves #8, #9

We can completely ignore this suggestion

Regarding Generating accounts section :

Should we do this to make yarn generate, DEPLOYER_PRIVATE_KEY in .env and yarn account more prominent similar to other commands, and easily copy and pastable?

Generate a new account or add one to deploy the contract(s) from.
The deployer account is ...... script.
You can generate a random account / private key with :
yarn generate

yarn generate will create a random account and add the DEPLOYER_PRIVATE_KEY to the .env  file
OR
add manually add private key of your crypto wallet in packages/hardhat/.env :
DEPLOYER_PRIVATE_KEY=yourWalletPrivateKey

You can check the generated account and its balance with :
yarn account

But don't if this make that section a bit long and boring, that's why we can completely skip this suggestion 🙌!!!

You can check the configured (generated or manually set) account and balances with:

Yes you are correct!! it shows the account address and its balance in both cases if you have put it manually or used yarn generate

I've done a few changes to point # 2, let me know what do you think @technophile-04

Modified # 2:

Tysm Pablo 🙌, looks great to me !!

Tysm Pablo 🙌, looks great to me !!

Cool! I've just pushed those tweaks, let's merge it and continue working from here 💪


pauxpow exception

Running at qt, at random times we'd see the dreaded pauxpow runtime error and crash

nothing from me so-far, @mca confirmed he's not getting the error, keeping open for further testing

I've also not been able reproduce on the latest 2.1.2 test candidate and I know Keyare has been unable to reproduce as well. Given the confirmation from multiple sources I'm closing.


Store workspace folder paths in the same format across OS (forward slash)

VSCode Version: Code - Insiders 1.16.0-insider (d0d00e882437092f521d2d7893cc56ee296d278f, 2017-08-29T07:05:40.998Z)
OS Version: Windows_NT x64 10.0.15063

This is a follow-up of #33188. When adding or removing files from a workspace and saving, the following:
{
	"folders": [
		{
			"path": "Arcade/Breakout"
		}
	]
}

turns into:
{
	"folders": [
		{
			"path": "Arcade\\Breakout"
		}
	]
}

on Windows. The reverse is true for Linux - it turns backward slashes into forward slashes.
It actually looks like backslash paths still work on Linux, and vice-versa. However, this could still be annoying if the code-workspace file is checked into a repo and you're working with people using different operating systems. It would make the diff way bigger than it has to be when modifying the workspace.
How about always using forward slashes?

Let's fold into https://github.com/Microsoft/vscode/issues/33270

Not sure I follow that argument. You can also manually change them to absolute paths. So how did defaulting to relative paths help? ;)

@Gama11 if the user changed the path property in a way that does not match our rules, then I think we should keep the path untouched and follow the rules. It is actually quite simple:

preserve slash vs backslash
preserve absolute vs relative paths

@Gama11 oh I see what you mean, yeah our default could be to just use forward slashes.

Pushed changes to use forward slash if we detect that other paths in the file use forward slash as well.


Add moto to local.txt

Description

Checklist:

[X] I've made sure that tests/test_cookiecutter_generation.py is updated accordingly (especially if adding or updating a template option)
[X] I've updated the documentation or confirm that my change doesn't require any updates

I've added Moto, a mock AWS service library, designed to for helping test your boto3 code.
Rationale

Although this repository doesn't use boto3 in development since it uses Django-storages, for others writing stuff like presigned posts or testing other methods of uploading media (e.g. ML checking if the image has at least one face), it'd be great to have something like this.
That's when moto comes in: instead of continuously sending requests to your S3 bucket especially during CI, incurring lots of costs, just use the mock service during testing.

Thanks for suggesting this.
It's true that moto can be quite convenient, but it's not a must have IMO. Not everyone will need it, and it comes at a cost, with a long list of dependencies. Depending on the services that one need to mock, it needs some extra dependencies.
For the above reasons, I'm -1 on adding this.


It looks awesome but I couldn't install it.

Awesome work, but hasnt able to make it work. I created a python_scripts folder inside the config root folder, inside I have placed the sensor.py and I added the yaml to the configuration.yaml, but it shows as invalid niu component is not a component. if you can write install instructions it would help a lot, I was able to get my token already dont know if that helps. Thank you, keep the great work!

added some lines, will this help ? (you do not need python_scripts and\or token, component will handle this)


add rbacconfig validation (fixing istio-pilot crash)

fixed #7322

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: adamglt
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: ayj
If they are not already assigned, you can assign the PR to them by writing /assign @ayj in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pilot/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Hi @adamglt. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

wrong branch. send to release-1.0 please

reopening


[Feature] Want to add toggle button to change theme white to black

Description
I want to add a toggle button to change the theme of the website from white to black, It will improve the UI of the website as well as  user experience
kindly assign me this issue.
Screenshots

Checklist

[X] I have checked the existing issues
[X] I have read the [Contributing Guidelines]
[X] I have read the discussion tab thoroughly and got the project idea
[X] I am willing to work on this issue (optional)
[X] I am a GSSoC'23 contributor

@HimanshuNarware some one is working on this #470


Introduce DefensiveMin and DefensiveMax

Introduces traits for defensive_min, defensive_strict_min, defensive_max, defensive_strict_max
closes #12550

Not quite what I imagine. I think we can do better, see my suggestion.

I have done as suggested @kianenigma

Pushing forward now so we can get it merged…

bot rebase

bot merge


Halzy/GitHub actions

bors r+

bors r+

bors retry

bors retry

bors retry

bors retry

bors retry

bors retry

bors retry

bors retry

bors retry

bors retry


Missing functions in undo_redo class

There are no

get_action_count() or get_actions_count()
get_current_action()

methods in the UndoRedo class.
But they are needed if you want to use the class in your own project. I know its more for editor stuff made (internally). But when you want to use the class, this methods are missing, so you can visualize undo redo buttons with the count of actions and on which action index he is already.
int UndoRedo::get_action_count() const {
	return actions.size();
}

int UndoRedo::get_current_action() const {
	return current_action;
}

If you want to use in a game first make sure it works when you export the game, editor classes are only available in the editor.

Feature and improvement proposals for the Godot Engine are now being discussed and reviewed in a dedicated Godot Improvement Proposals (GIP) (godotengine/godot-proposals) issue tracker. The GIP tracker has a detailed issue template designed so that proposals include all the relevant information to start a productive discussion and help the community assess the validity of the proposal for the engine.
The main (godotengine/godot) tracker is now solely dedicated to bug reports and Pull Requests, enabling contributors to have a better focus on bug fixing work. Therefore, we are now closing all older feature proposals on the main issue tracker.
If you are interested in this feature proposal, please open a new proposal on the GIP tracker following the given issue template (after checking that it doesn't exist already). Be sure to reference this closed issue if it includes any relevant discussion (which you are also encouraged to summarize in the new proposal). Thanks in advance!


fix: resetoption

:tada: This PR is included in version 4.26.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Check against macCatalyst for ImageAnalyzer as it doesn't compile

Should fix the issue of https://github.com/JanGorman/Agrume/pull/332#issuecomment-1269324959

Thank you!!
On Sat, Dec 17, 2022 at 2:09 AM Jan Gorman @.***> wrote:

Merged #341 https://github.com/JanGorman/Agrume/pull/341 into master.
—
Reply to this email directly, view it on GitHub
https://github.com/JanGorman/Agrume/pull/341#event-8058418623, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ABGTZ25AR7H5EUWSONKVOUTWNSO23ANCNFSM6AAAAAASUYT7AM
.
You are receiving this because you authored the thread.Message ID:
@.***>


[Bug] The sensor connected_devices of the router empty after adding an AP

The problem
The sensor *_connected_devices of the router remains empty after adding an AP.
The *_connected_devices sensor of the AP starts showing the devices connected to the network.
Disabling the AP and reloading the router solves the problem.

Your device model
RT-AX88U_Pro
Firmware type
Stock
Firmware version
<IP_ADDRESS>.102_33308-gfb75e0b_344-g69f33
Integration version with the issue
0.28.0
Method of the integration installation
HACS
What version and type of Home Assistant installation do you use
Core 2024.1.6
Is there anything useful in the logs?
None available even with debugging enabled.

Diagnostics information
config_entry-asusrouter-24157713f05cc3733c2cac5119406cfd.json.txt
Additional information
No response

Hello. Sorry to hear, you are experiencing issues. Can you please explain a bit more about the topology of your network, so that I can reproduce the issue and fix it.
You have your main router with a part of devices connected to it + an AP connected to the router via cable and having some wireless clients? But this is not in AiMesh mode?

Hi @Vaskivskyi,
Indeed I have a RT-AX88U_Pro which acts as a AiMesh router, x2 TUF-AX5400 and x1 RT-AX88U all 3 acting as AiMesh nodes over 5GHz and x1 RT-AC87U connected via ethernet cable which acts as non-AiMesh AP (it does not support AiMesh).
All devices are on the latest official firmware.

My Connected Devices list is also empty. I have a RT-AX58U ,Tenda O1 outdoor AP, Cisco 2702 AP. But during Connected Devices configuration the List of clients to filter is not empty.

Just to add that if I add the same AP as an AiMesh Node, I don't encounter these issues, but of course I don't see which devices are connected through this AP.

The last version where I could see both sensors showing the number of connected devices was 0.26.0.
The same issue happens if I use Merlin firmware and if i connect the AiMesh nodes over ethernet.
In conclusion the bug is the result of a change introduced in 0.27.0.

The same as for #783. The issue is in the list of things to be done. It's not forgotten. Unfortunately, the AP support seems to not work correctly in different ways, so I don't know yet whether the whole AP support should be changed or some parts can be fixed independently


Luau Recap March 2021

OKd by @zeux on slack https://roblox.slack.com/archives/CFEM4TAV6/p1617130330434300


Docs changes to Binary Classification Example

Improve the docs of the Binary Classification Example:

Reformatted and added comments in the two train configuration files consistent (e.g., doing diff on command line can show what the difference is)
Added a note about train_linear.conf that was part of the example yet with no reference in README (which I found quite surprising as a newbie in this project)
Used GitHub-flavoured Markdown to make notes (so they stand out properly IMHO)

These are the changes I found helpful while reviewing the example (that I would've done on a side for further learning but I thought I'd propose them to be included in the project for others).
HTH ❤

@microsoft-github-policy-service agree

It's been over a year since the last commit here, so I'm going to assume this is abandoned and close this. Thanks very much for your interest in LightGBM. We'd be happy to have you come contribute in the future if you have time to work with us.


go.obo uploaded on 01-Dec-2019

Is the go.obo file uploaded on the data web page on 01-Dec-2019 the GO version of 2019? Are the train_data.pkl and test_data.pkl files, uploaded on 02-Dec-2019, generated from this go.obo (2019) and the UniProt version of 2019?

Yes, if you look at the first lines in go.obo file you can find the release data which says "releases/2019-01-26".
The train and test data should use this version, but I'm not sure. Better to use the archived files. For the data generated
in 2019, there is data-2019.tar.gz file.


add failing test multi model

Hi,
just added a failing test of scatter with many models. I had to modify the dfs0 file of HKZA.
All the other tests pass despite this change . I realized that if my model results have different item names then the mean_skill fails. You will see it (I changed the item name in the dfs0 from ´Hm0´  to ´Hm0_a´)

Isn't your example a bit contrived? Or does it make sense to you?
The purpose of a multi-model compare is to compare multiple models in a consistent way, if you connect model1 with obs1 and model2 with obs2 the comparison is not fair.
This is why the mean_skill() calculation fails, since it assumes that all models are connected to all observations.
But this should of course be flagged earlier, or the logic of the mean_skill() have to be adapted to to handle that some observations are not present in some models.

My problem is the following, which is how I found this bug.
I have actually a single model, just 1 model, which is a dfs0 with 3 columns (Point1, Point2 and Point3)
I have measurements in these 3 points, also as another dfs0.
When I connect that single model to the measurements, since it is a dfs0 and not a dfsu, I create my pairs of model/observation , and then add them to each other (I create connector 1, then I add connector 2 and lastly connector 3).
Then I want to see the mean_skill of my one model, and for some reason fmskill thinks it is 3 differents models, despite I give the same model name to my 3 model results.
And then it crashes.

@daniel-caichac-DHI, I lost track of this one? Is this still a problem? Could I please ask you to test it?

I can test it properly! but next week though :D

Let's close this I propose.


Remove distributed event bus & refactor migrations

Closes https://github.com/abpframework/abp/issues/11967

This PR is draft due to solution of distributed lock usage

Solved the synchronized migrations issue by implementing locking and re-try mechanism


engine.Evaluate("library(xgboost)") throws StackOverflow error.

My environment:
Windows 7 -  64
Visual Studio 2015
Version: R 3.4.4
R platform: i386-w64-mingw32
Not able to load library although the library xgboost is installed and located in R_HOME library folder.
Other library catools can be loaded fine. However, xgboost throws Stackoverflow error.

Curious if you have tested it with other versions of R, or just 3.4.4?

I tested this on:
Windows 10 - 64
Visual Studio 2015
Version: R 3.4.0 and 3.4.4
For each version of R, I used this code and did not get an exception.  Just curious how to replicate the same issue you're seeing.  I will note that I pulled down R.NET from NuGet and used that.  Are you using a locally built version?
https://gist.github.com/lrasmus/1decc4c4af6dc61e45167a64b638c2f0
using RDotNet;

namespace RDotNetTester
{
    class Program
    {
        static void Main(string[] args)
        {
            REngine.SetEnvironmentVariables();
            var engine = REngine.GetInstance(null, true, null);
            engine.Evaluate("library(xgboost)");
        }
    }
}

I only tested againts R3.4.4
I'm using .R NET package from nuget as well.
My packages are:
<packages>
  <package id="Antlr" version="<IP_ADDRESS>04" targetFramework="net461" />
  <package id="bootstrap" version="3.0.0" targetFramework="net461" />
  <package id="DynamicInterop" version="0.8.1" targetFramework="net461" />
  <package id="jQuery" version="1.10.2" targetFramework="net461" />
  <package id="jQuery.Validation" version="1.11.1" targetFramework="net461" />
  <package id="Microsoft.AspNet.Mvc" version="5.2.3" targetFramework="net461" />
  <package id="Microsoft.AspNet.Razor" version="3.2.3" targetFramework="net461" />
  <package id="Microsoft.AspNet.Web.Optimization" version="1.1.3" targetFramework="net461" />
  <package id="Microsoft.AspNet.WebPages" version="3.2.3" targetFramework="net461" />
  <package id="Microsoft.CodeDom.Providers.DotNetCompilerPlatform" version="1.0.0" targetFramework="net461" />
  <package id="Microsoft.jQuery.Unobtrusive.Validation" version="3.2.3" targetFramework="net461" />
  <package id="Microsoft.Net.Compilers" version="1.0.0" targetFramework="net461" developmentDependency="true" />
  <package id="Microsoft.Web.Infrastructure" version="<IP_ADDRESS>" targetFramework="net461" />
  <package id="Modernizr" version="2.6.2" targetFramework="net461" />
  <package id="Newtonsoft.Json" version="6.0.4" targetFramework="net461" />
  <package id="R.NET" version="1.7.0" targetFramework="net461" />
  <package id="Respond" version="1.2.0" targetFramework="net461" />
  <package id="WebGrease" version="1.5.2" targetFramework="net461" />
</packages>

The details error is:
An unhandled exception of type 'System.StackOverflowException' occurred in RDotNet.dll
In
{System.Collections.ListDictionaryInternal}

Thanks for the details - I updated my project to match, so it's now building against .NET 4.6.1 and I've installed all of the same packages (although they are not needed in my instance, but just to get on the same ground).
Unfortunately I don't get the exception.  I was wondering if you could create a simple command line project based on the code I had posted before and see if you can replicate the problem?  You're not the only one seeing this - there's a SO post with the same general approach and error.

Thank you for your suggestion,
I tried creating simple console application and it works fine.
However, using MVC web application on the same settings it throws the error.
What could be the solution?
Thanks,
-Abi

Ahhh!  Okay, that's good to know.  I'll try and replicate this with a simple MVC web application to see if I can get the exception now.

So, I think I've somewhat replicated your problem - but what's odd is I get a different exception.  I created a simple MVC controller and call the following code:
REngine.SetEnvironmentVariables();
var engine = REngine.GetInstance();
engine.Evaluate("library(caTools)");
engine.Evaluate("library(xgboost)");

It loads caTools fine, and throws an RDotNet.EvaluationException when trying to load xgboost (not StackOverflow):
RDotNet.EvaluationException was unhandled by user code
  HResult=-2146233088
  Message=Error: package or namespace load failed for 'xgboost' in inDL(x, as.logical(local), as.logical(now), ...):
 unable to load shared object 'C:/Program Files/R/R-3.4.4/library/stats/libs/i386/stats.dll':
  LoadLibrary failure:  The specified module could not be found.

  Source=RDotNet
  StackTrace:
       at RDotNet.REngine.Parse(String statement, StringBuilder incompleteStatement)
       at RDotNet.REngine.<Defer>d__46.MoveNext()
       at System.Linq.Enumerable.LastOrDefault[TSource](IEnumerable`1 source)
       at RDotNet.REngine.Evaluate(String statement)
       at RDotNetTest.Controllers.DefaultController.Index() in C:\Development\RDotNetTest\RDotNetTest\Controllers\DefaultController.cs:line 18
       at lambda_method(Closure , ControllerBase , Object[] )
       at System.Web.Mvc.ActionMethodDispatcher.Execute(ControllerBase controller, Object[] parameters)

I was wondering where and how you're initializing the REngine in your application, and how you're calling code to execute?  Are you doing it all from within a single controller action?

I'm having the same problem.  It happens for some libraries (e.g. plyr, dplyr, tidyr, xml2) and not others (e.g. sqldf, jsonlite).  The thing is that this only happens when I'm testing/running in IIS Express and not in Console app or MS Test classes.  Here are my specs:
R 3.4.3
R.NET 1.7.0
VS 2017 (.NET Framework 4.5.2)
I've tried using 32-bit and 64-bit R and same results.

Hi Luke,
Sorry for getting back to you late.
I was calling the library directly from controller in one action.
Thanks,
Abi
On Fri, 27 Apr 2018, 09:59 Luke R<EMAIL_ADDRESS>wrote:

So, I think I've somewhat replicated your problem - but what's odd is I
get a different exception. I created a simple MVC controller and call the
following code:
REngine.SetEnvironmentVariables();
var engine = REngine.GetInstance();
engine.Evaluate("library(caTools)");
engine.Evaluate("library(xgboost)");
It loads caTools fine, and throws an RDotNet.EvaluationException when
trying to load xgboost (not StackOverflow):
RDotNet.EvaluationException was unhandled by user code
HResult=-2146233088
Message=Error: package or namespace load failed for 'xgboost' in inDL(x, as.logical(local), as.logical(now), ...):
unable to load shared object 'C:/Program Files/R/R-3.4.4/library/stats/libs/i386/stats.dll':
LoadLibrary failure:  The specified module could not be found.
Source=RDotNet
StackTrace:
at RDotNet.REngine.Parse(String statement, StringBuilder incompleteStatement)
at RDotNet.REngine.d__46.MoveNext()
at System.Linq.Enumerable.LastOrDefault[TSource](IEnumerable`1 source)
at RDotNet.REngine.Evaluate(String statement)
at RDotNetTest.Controllers.DefaultController.Index() in C:\Development\RDotNetTest\RDotNetTest\Controllers\DefaultController.cs:line 18
at lambda_method(Closure , ControllerBase , Object[] )
at System.Web.Mvc.ActionMethodDispatcher.Execute(ControllerBase controller, Object[] parameters)
I was wondering where and how you're initializing the REngine in your
application, and how you're calling code to execute? Are you doing it all
from within a single controller action?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/jmp75/rdotnet/issues/74#issuecomment-384840892, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAc5tgXpx3pVJThUwliGsE9ORcofJKJuks5tsnt2gaJpZM4TR_-j
.

@mentezam-nf  @abidzar @lrasmus   I have not looked in details, nor reproduced, and I do little to no web dev, but my understanding is that IIS expect thread safe code, and the R engine is NOT thread safe. I may be off the mark here but my experience is that IIS and R via R.NET do not play well.

Yes, I'm aware of the threading issue but I don't think that this is the problem here.  I've already put in code to synchronize thread access to the REngine instance.  The problem happens when calling library() on the packages that I mentioned.  It throws a StackOverflowException.

I figured out the issue.  I posted my solution on SO:
https://stackoverflow.com/questions/49623768/an-unhandled-exception-of-type-system-stackoverflowexception-occurred-in-rdotn/50381186#50381186


ENH: scipy.stats: add multivariate hypergeometric distribution

Reference issue
Closes #12585
What does this implement/fix?
This PR implements the multivariate hypergeometric distribution in scipy.stats module!

[x] Documentation suite for the methods of the distribution
[x] Tests for all the added methods of the distribution

@mdhaber

I also tested the time taken by rvs method implemented vs numpy's generator:
In [1]: import numpy as np

In [2]: from scipy.stats import multivariate_hypergeom as mvhg

In [3]: rng = np.random.Generator(np.random.PCG64())
In [4]: m = np.random.randint(0, 100, 100)

In [5]: n = np.random.randint(0, m.sum())

In [6]: n
Out[6]: 75

In [7]: m
Out[7]:
array([28, 63,  1, 78, 49, 89,  0, 37, 35, 99, 87, 38,  3, 14, 38, 61, 35,
       32, 86, 44, 91, 20, 72, 15, 19, 86, 29, 25, 80,  7, 18, 49, 95, 40,
       11, 53, 72,  8, 17,  8, 69,  2, 42, 27,  0, 58, 91,  3, 51, 23, 92,
       54, 17, 40, 44, 90, 12, 60, 41, 63, 28, 81, 55, 66, 92, 76, 68, 59,
       69, 87, 41, 22, 68, 65, 42, 68, 43, 80,  2, 63, 12, 48,  4, 25, 11,
       82, 86,  8, 51, 90, 26, 74, 49,  3, 54, 16,  9, 34, 73, 37])

In [8]: %time _ = mvhg.rvs(m=m, n=n, size=1000)
CPU times: user 62.5 ms, sys: 0 ns, total: 62.5 ms
Wall time: 50.9 ms

In [9]: %time _ = mvhg.rvs(m=m, n=n, size=1000, random_state=rng)
CPU times: user 31.2 ms, sys: 15.6 ms, total: 46.9 ms
Wall time: 21.8 ms

NumPy's generator is more than twice as fast!
Some more tests:
In [10]: %time _ = mvhg.rvs(m=np.repeat(m, 2), n=n*2, size=1000)
CPU times: user 109 ms, sys: 0 ns, total: 109 ms
Wall time: 106 ms

In [11]: %time _ = mvhg.rvs(m=np.repeat(m, 2), n=n*2, size=1000, random_state=rng)
CPU times: user 46.9 ms, sys: 0 ns, total: 46.9 ms
Wall time: 40.8 ms

In [12]: %time _ = mvhg.rvs(m=np.repeat(m, 3), n=n*3, size=1000)
CPU times: user 156 ms, sys: 0 ns, total: 156 ms
Wall time: 150 ms

In [13]: %time _ = mvhg.rvs(m=np.repeat(m, 3), n=n*3, size=1000, random_state=rng)
CPU times: user 62.5 ms, sys: 0 ns, total: 62.5 ms
Wall time: 60.3 ms

In [14]: %time _ = mvhg.rvs(m=np.repeat(m, 30), n=n*30, size=1000)
CPU times: user 1.55 s, sys: 31.2 ms, total: 1.58 s
Wall time: 1.58 s

In [15]: %time _ = mvhg.rvs(m=np.repeat(m, 30), n=n*30, size=1000, random_state=rng)
CPU times: user 656 ms, sys: 31.2 ms, total: 688 ms
Wall time: 691 ms

I wouldn't worry about the speed too much. IMO speeding up the RVS does not need to be in scope. You're already using the faster NumPy alternatives when the provided seed is of the appropriate type, right?

You're already using the faster NumPy alternatives when the provided seed is of the appropriate type, right?

Yes. When the random_state is a numpy generator, it will use the new numpy distribution to sample where are fast enough!

@tirthasheshpatel Thanks for the quick turnaround. I'll try to take another look tomorrow. In the future, please let me resolve the comments. Also, your commit messages are much better than most, but still, please take a look at https://scipy.github.io/devdocs/dev/contributor/development_workflow.html for our standard acronyms. It doesn't mention it there, but I was taught to include the submodule name after the acronym like with your first commit, e.g. STY: stats: ignore PEP8 E129 'same indent' warning. (Although I think another way around that is a second indent, right?)

Although I think another way around that is a second indent, right?

I think that works too. IMO, the current fix is more natural.

I think we're pretty close. The biggest remaining things seem to be that we need "ground truth" values in the tests, and we need to figure out a workaround for the remaining RuntimeWarnings.

The biggest remaining things seem to be that we need "ground truth" values in the tests, and we need to figure out a workaround for the remaining RuntimeWarnings.

Both of these have been addressed and tested now. Can you please experiment and confirm that there is no RuntimeWarning for any inputs?

Where does covariance matrix ground truth come from, though?

I have used [2]_ for that. I will add a comment pointing to the references.

Is logpmf just the log of the output from R? (Or did you find a logpmf function in R?)

dmvhyper accepts an argument log to evaluate the logpmf

@mdhaber Thank you for all the helpful reviews and suggestions.

Hey @mdhaber
Just seeing your ping on this now (been a bit behind on scipy GitHub notices), did you still want me to take a look here?
I can probably take a look at this next weekend.
-L

On Sep 20, 2020, at 12:40 PM, Matt Haberland<EMAIL_ADDRESS>wrote:

@mdhaber commented on this pull request.
I don't think I'll have much more to say about pmf, logpmf, mean, and var after this. If I want any more doc changes, I'll propose them myself in another PR after this is merged. I haven't checked covar or rvs. @rlucas7 would you be interested in taking a look?
In scipy/stats/tests/test_multivariate.py:

   assert_allclose(vals4, np.NAN, rtol=1e-8)

   vals5 = multivariate_hypergeom.logpmf(x=[[1, 2], [3, 4]],

                                         m=[[-4, -6], [-5, -10]],

                                         n=[3, 7])

   assert_allclose(vals5, [np.nan, np.nan], rtol=1e-8)

   vals6 = multivariate_hypergeom.logpmf(x=[-3, 4], m=[-5, 10], n=1)

   assert_allclose(vals6, np.nan, rtol=1e-8)

   vals7 = multivariate_hypergeom.logpmf(x=[1, 11], m=[10, 1], n=12)

   assert_allclose(vals7, np.nan, rtol=1e-8)

   vals8 = multivariate_hypergeom.logpmf(x=[1, 11], m=[10, -1], n=12)

   assert_allclose(vals8, np.nan, rtol=1e-8)

Would be good to have one above test where x.sum() != n is the only thing that is wrong.
⬇ Suggested change

   vals9 = multivariate_hypergeom.logpmf(x=[3, 3], m=[5, 10], n=7)

   assert_equal(vals9, np.NINF)

In scipy/stats/tests/test_multivariate.py:

@@ -1635,6 +1637,191 @@ def test_haar(self):
res = kstest(x.ravel(), uniform(-np.pi, 2*np.pi).cdf)
assert_(res.pvalue > 0.05)

+class TestMultivariateHypergeom(object):

def test_logpmf(self):

   # Ground truth value from R dmvhyper

   vals1 = multivariate_hypergeom.logpmf(x=[3, 4], m=[5, 10], n=7)

   assert_allclose(vals1, -1.119814, rtol=1e-6)

   vals2 = multivariate_hypergeom.logpmf(x=[3, 4], m=[5, 10], n=0)

   assert_allclose(vals2, np.NAN, rtol=1e-8)

If you agree with the comment above, it would be good to add another check for n < 0, because that should be NAN. You can pick n=0 balls from the urn, but it doesn't make sense to pick n=-1 balls from the urn.
In scipy/stats/tests/test_multivariate.py:

@@ -1635,6 +1637,191 @@ def test_haar(self):
res = kstest(x.ravel(), uniform(-np.pi, 2*np.pi).cdf)
assert_(res.pvalue > 0.05)

+class TestMultivariateHypergeom(object):

def test_logpmf(self):

   # Ground truth value from R dmvhyper

   vals1 = multivariate_hypergeom.logpmf(x=[3, 4], m=[5, 10], n=7)

   assert_allclose(vals1, -1.119814, rtol=1e-6)

   vals2 = multivariate_hypergeom.logpmf(x=[3, 4], m=[5, 10], n=0)

   assert_allclose(vals2, np.NAN, rtol=1e-8)

   vals3 = multivariate_hypergeom.logpmf(x=[-3, 4], m=[5, 10], n=7)

val7 has x > m, but it also has m.sum != n. Would be good to have an independent check of x > m.
In scipy/stats/tests/test_multivariate.py:

@@ -1635,6 +1637,191 @@ def test_haar(self):
res = kstest(x.ravel(), uniform(-np.pi, 2*np.pi).cdf)
assert_(res.pvalue > 0.05)

+class TestMultivariateHypergeom(object):

def test_logpmf(self):

   # Ground truth value from R dmvhyper

   vals1 = multivariate_hypergeom.logpmf(x=[3, 4], m=[5, 10], n=7)

   assert_allclose(vals1, -1.119814, rtol=1e-6)

   vals2 = multivariate_hypergeom.logpmf(x=[3, 4], m=[5, 10], n=0)

   assert_allclose(vals2, np.NAN, rtol=1e-8)

   vals3 = multivariate_hypergeom.logpmf(x=[-3, 4], m=[5, 10], n=7)

You don't necessarily need these comments, but they help check that we're covering all the different cases.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

That would be terrific @rlucas!
Thanks for resolving merge conflicts @tirthasheshpatel.

@rlucus you asked about "quantile". You will find that there are a lot of things that are not ideal about this PR in order to be consistent with scipy.stats.multinomial; this is one of them. For now, we're keeping these things consistent, then it would be really nice to fix them both up at the same time.

@rlucas7 Thanks for the review! I have tried to address all. Please let me know if i missed something...

Looking over this again, so re-opening, I'm confused here. A quantile

@rlucas7 s you asked about "quantile". You will find that there are a lot of things that are not ideal about this PR in order to be consistent with scipy.stats.multinomial; I think this is one of them. For now, let's keep these two consistent, then it would be really nice to fix them both up at the same time. I don't think we should ask @tirthasheshpatel to do that as part of this PR.

Yes thanks for pointing this out @mdhaber I agree no need to bikeshed :)

Thank you for taking a look!

My pleasure. I'll take a look to clarify on this one open issue where I (somehow) commented on blank lines :)

@mdhaber are you ok with the changes here? They look good to me, this distribution will be a nice addition to stats.

Thanks, @WarrenWeckesser for the review. Really helpful. I have addressed all the documentation comments except the big one with size issues. Please feel free to ping if I missed anything!

@tirthasheshpatel, there is a problem with the rvs method:
In [6]: import scipy

In [7]: scipy.__version__
Out[7]: '1.6.0.dev0+d2a1c98'

In [8]: from scipy.stats import multivariate_hypergeom

A basic example, which uses size=1 by default:
In [10]: multivariate_hypergeom.rvs([1, 3, 9], 5)
---------------------------------------------------------------------------
ValueError                                Traceback (most recent call last)
<ipython-input-10-fd2505ebd1ae> in <module>
----> 1 multivariate_hypergeom.rvs([1, 3, 9], 5)

~/mc37scipymaster/lib/python3.7/site-packages/scipy-1.6.0.dev0+d2a1c98-py3.7-macosx-10.9-x86_64.egg/scipy/stats/_multivariate.py in rvs(self, m, n, size, random_state)
   4678
   4679         if size == 1:
-> 4680             return rvs.squeeze(-1)
   4681         return rvs
   4682

ValueError: cannot select an axis to squeeze out which has size not equal to one

Now try with size=None, which should generate a single variate:
In [11]: multivariate_hypergeom.rvs([1, 3, 9], 5, size=None)
---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
<ipython-input-11-ed5f23f9cd57> in <module>
----> 1 multivariate_hypergeom.rvs([1, 3, 9], 5, size=None)

~/mc37scipymaster/lib/python3.7/site-packages/scipy-1.6.0.dev0+d2a1c98-py3.7-macosx-10.9-x86_64.egg/scipy/stats/_multivariate.py in rvs(self, m, n, size, random_state)
   4663             size_ = (size, )
   4664
-> 4665         rvs = np.empty(size_ + (m.shape[-1], ), dtype=m.dtype)
   4666         rem = M
   4667

TypeError: unsupported operand type(s) for +: 'NoneType' and 'tuple'

I'm working on a fix for this particular problem, and for handling size as I suggested in an earlier comment. A couple changes that I'd like to see are (1) change the default size to None (as it is in multinomial and in the numpy random methods), and (2) eliminate all uses of squeeze for changing the final shape.
We currently don't have a written specification for exactly how the multivariate distribution are supposed to handle broadcasting, nor how broadcasting of the parameters interacts with the size parameter of the rvs method, so I'll work on writing up some notes on that while I work on the code.

change the default size to None (as it is in multinomial and in the numpy random methods)

Done!

eliminate all uses of squeeze for changing the final shape

I have eliminated all except one which is necessary to handle a case in the previous comment. When the size=None, the first dimension will be one (because size_=1) that needs to be squeezed for compatibility with numpy. For other conditions, I have removed squeezing as you said.

Thanks, @WarrenWeckesser for the explanation of the behavior when size=None. It should be fixed now. I guess all your comments addressed now, right?

I'm not sure what happened with appveyor and travisci when I pushed a batch a small changes.  Closing and reopening to try again.

@rlucas7, I think the change that you requested was related to the use of NumpyVersion.  That is no longer being imported.  Could you take another look and update your review when you get a chance?

@rlucas7 I haven't reviewed recently, but what i saw before was good, so with +2 LGTM!
When you merge, please modify the line about multivariate t in the 1.6.0 release notes e.g.:
The multivariate t distribution has been added as scipy.stats.multivariate_t, and the multivariate hypergeometric distribution has been added as scipy.stats.multivariate_hypergeom.

Thanks for the ping @mdhaber
Thanks @tirthasheshpatel for sticking with this one until it gets merged.
And thanks  @mdhaber and @WarrenWeckesser for the reviewing
squash and merged-glad to have this in 1.6.0.

Glad I could help. This was a lot of fun to do.
Thanks, @mdhaber, @rlucas7, and @WarrenWeckesser for all the reviews and help!


Joinorder

This change is to adjust the join order of multi-table join so that the join conditions can be correctly pushed down to the Join Operator.

Can one of the admins verify this patch?

To help with the review it can be useful to put the JIRA your changes relate to in the title (e.g. [SPARK-...] details)

@flyson How is this change compared to https://github.com/apache/spark/pull/10073 ?

@flyson please file a JIRA and put it in the title. See how other patches are opened.

Thanks for the pull request. I'm going through a list of pull requests to cut them down since the sheer number is breaking some of the tooling we have. Due to lack of activity on this pull request, I'm going to push a commit to close it. Feel free to reopen it or create a new one.


DSND-1448 Implement officer appointment filtering

Integrate filtering on active roles into current sort aggregation.
Tested locally.

DSND-1448

Tested locally.


Merge 15.3 to master.

@dotnet-bot test OSX Build for CoreCLR please
I'd really like to get to the bottom of this occasional @/%40 thing.

User a we her thing.


Runing nodegit in Electron

Hi, I installed nodegit 0.26.5 via npm and import the package in the renderer part of my Electron application. During compilation I receive this error below:
WARNING in ./node_modules/nodegit/dist/nodegit.js
Module not found: Error: Can't resolve '../build/Release/nodegit.node' in '/Users/steve/Documents/git/git_reader/node_modules/nodegit/dist'

ERROR in ./node_modules/nodegit/dist/nodegit.js
Module not found: Error: Can't resolve '../build/Debug/nodegit.node' in '/Users/steve/Documents/git/git_reader/node_modules/nodegit/dist'
ERROR in ./node_modules/nodegit/dist/nodegit.js
Module not found: Error: Can't resolve '../package' in '/Users/steve/Documents/git/git_reader/node_modules/nodegit/dist'

I found a variety of issues on the web regarding this, but I don't understand the solution. Is this caused by the Release build although I run a debug build of my electron app? Thank you very much!
Below are some files for context:
.npmrc
runtime = electron
save=true
save-exact=true
target_arch = x64
target = 1.7.9
dist_url = https://atom.io/download/electron
build_from_source = true
home=~/.electron.gyp npm install
msvs_version = 2017
python = 2.7

packages.json
...
    "electron": "9.0.4",
    "electron-builder": "22.7.0",
    "electron-reload": "1.5.0",
    "nodegit": "0.26.5",
...

Also seem to have this issue starting today.

I created a repo, which I forked from a boilerplate template. I only added nodegit and @types/nodegit as a dependency and imported it in details.component.ts
https://github.com/Githubber2021/electron-nodegit-error
git clone https://github.com/Githubber2021/electron-nodegit-error.git
npm install
npm run electron:local

I have the same issue, but on Windows. The error messages look the same
WARNING in ./node_modules/nodegit/build/Release/nodegit.node 1:2
Module parse failed: Unexpected character '�' (1:2)
You may need an appropriate loader to handle this file type, currently no loaders are configured to process this file. See https://webpack.js.org/concepts#loaders
(Source code omitted for this binary file)

ERROR in ./node_modules/nodegit/dist/nodegit.js
Module not found: Error: Can't resolve '../build/Debug/nodegit.node' in 'D:\git\electron-nodegit-error\node_modules\nodegit\dist'
ERROR in ./node_modules/nodegit/dist/nodegit.js

Hi.
Check if you have a reference to the package inside any page that is handled by the renderer. You cannot import nodegit in those source files, even if you're only using the types.

Hi.
Check if you have a reference to the package inside any page that is handled by the renderer. You cannot import nodegit in those source files, even if you're only using the types.

I only import it inside the preload (Node enabled)

Can you elaborate that in simpler terms? Does that mean I cannot use nodegit in the renderer part of my app? Just wondering, eg how GitLraken for instance does this

Thank you! Can you elaborate that in simpler terms? Does that mean I cannot use nodegit in the renderer part of my app? Just wondering, eg how GitLraken for instance does this

All calls and references must be made from the main process. So your renderer process should communicate with the main process somehow.
There's plenty of documentation online about this particular subject

Can you try to install the 0.26.4 version and sees if it`s working? And are you sure the postinstall process calls electron-builder to rebuild dependencies to use with Electron?

@vlceberg thank you for the explanation! I am just wondering, oyed said “suddenly” it doesn’t work for him anymore @oyed  did we just run into the same error message because my mistake, because it indeed seems I just made the simple mistake to execute that in the rendered part.
P.s. would the version downgrade have any difference to me then?

@vlceberg thank you for the explanation! I am just wondering, oyed said “suddenly” it doesn’t work for they anymore @oyed did we just run into the same error message because in my case, it seems I just made the simple mistake to import that in the render part.
P.s. would the version downgrade have any difference to me then?

I don't know. I use Electron and version 0.26.4 of nodegit and it works fine.

I dont know if this helps.
But version 0.26.4 and 0.27.0 works fine as long as I run in in the background process/main.
If I try and run it in any frontend preload where I use nodejs express/fs etc it fails (dev console disconnects)

I dont know if this helps.
But version 0.26.4 and 0.27.0 works fine as long as I run in in the background process/main.
If I try and run it in any frontend preload where I use nodejs express/fs etc it fails (dev console disconnects)
I have the same problem.
And when I test it in a test repo,it works fine.
but when i import it in my electron project,it was broken.
Maybe this reason , but my preload will mount all modules....


Create 4thSide.py

Please CONTRIBUTING.md, you don't have to make a different file for it, there's an order.

As @ieshaan12, this pr does not fit our contributing guidelines. Please read CONTRIBUTING.md and follow the general format for generators before opening another pull request. Thanks.


spring-web library outdated with CVE-2016-1000027 high severity issue

Hi,
Looks like the used /opt/shinyproxy/shinyproxy.jar:BOOT-INF/lib/spring-web-5.2.12.RELEASE.jar has a nastily security issue CVE-2016-1000027 with high severity.
Would it be possible to use a more recent version.

Hi
Thanks for reaching out for this issue. The referenced CVE is not a vulnerability in the Spring framework per se, only when using the org.springframework.remoting.httpinvoker.* classes in a wrong (i.e. insecure) way makes your application vulnerable. Luckily we are not using any of the org.springframework.remoting.httpinvoker classes, beans or code.
Unfortunately currently lots of vulnerability scanners (e.g. NexusIQ) will report this CVE. You can find more information here:  https://github.com/spring-projects/spring-framework/issues/24434 and https://stackoverflow.com/questions/60193808/sonatype-scan-shows-spring-web-is-vulnerable
If you believe that we are actually vulnerable, please contact back with more information.
Thanks!

Hi
Since I believe your question is answered, I'm closing this question.
However, as always feel free to re-open this issue or open a new issue if you encounter any issue

is Vulnerability CVE-2016-1000027 for spring-web will fixed in 5.3.25