Documentation version

Two additional files could be useful in doc/base :

A file with just the documentation's version (or engine major version + minor version/build) for avoid to load and parse the entire file.
A second file with the conventions and structure used (recently the codeblock tag has been added)

A file with just the documentation's version (or engine major version + minor version/build) for avoid to load and parse the entire file.

For that you can use version.h. The documentation version is the same as the engine version.

I have just found a version.py file. But the minor version isn't incremented for each small change in the file (between 2.x and 2.x + 1 classes.xml can be modified more than 1 time), that is not exactly what i search.

Well we won't start having a static versioning of the documentation for each new commit made on it, it would be unmanageable. You can parse the git commit hash or the git log to infer how many times it changed since the last time you checked, or something like that.

I don't know how do that, it seems complicated for so little. This version number would be just indicative, it has not need to be strictly incremented at each modification, only for the significants changes.

It's a bit unclear what you're asking for. The documentation is kept in sync with the source code. When the source code changes, we try to update the documentation accordingly. We also try to document existing features that are not documented yet. What would be the criterion to decide that the documentation version should be bumped? "Significant" is quite subjective.
You don't state it, so it's left to us to do the guesswork, but I guess you want this to decide when you should update your standalone documentation reader. Just make it check if there was a new commit since the last time and download the file if there was. There is no reason not to use the latest version of the documentation, for a given branch (2.0 or master).

Ideally it should be incremented when the API has been modified, or when a description has been improved. But for spelling mistakes or minor cosmetics changes it could be forgotten.
I don't know how to communicate with GitHub without git. I have tried another method with the last modification date of the file but it doesn't work.

Well that won't happen, it would be unmaintainable to have to force documenters to bump an arbitrary version number in a file each time they touch the class reference.
You can get e.g. the last modification date with:
git log -1 --format="%ad" -- doc/base/classes.xml

And infer a version number from it (e.g. master_20160411).

A second file with the conventions and structure used (recently the codeblock tag has been added)

I moved this part to https://github.com/godotengine/godot-docs/issues/122
For the first part, closing as wontfix as per the above discussion.


[FEATURE] ISM new parameter for explain API

The ISM policy currently applied to the index could be an outdated one if the user update the policy using the update policy API.
We add a parameter to explain API in this PR. So user can use this to see the currently applied policy, and can compare it with the result of get policy API to know if the currently applied policy is an outdated one.
For the documentation, we need to mention this newly added parameter of explain API releasing in 1.3.
And the problem of outdated applied policy should be mentioned in update policy API, so that user can know this when they are updating the policy.

Closed with #447


Bryan/dev 14 graphql preferences docs

Description
Adding docs for graphql preferences page
Related issues
Fixes DEV-14

Closing, not sure why wasn't on latest


Invoke-Command: improve handling of variables with $using: expression

PR Summary
This PR improves Invoke-Command's handling of cases that combine $using: expressions with variable namespace notation when the -ComputerName parameter is used.
Fixes #9204
Fixes #16019
PR Context
When the -ComputerName parameter is used, Invoke-Command is unable to check which version of PowerShell is available on the remote computer and assumes v2.0. Because PowerShell 2.0 can't parse $using: expressions, the ScriptBlock is modified before sending, with $using: variables renamed to replace the $using: expression with $__using_.  Currently, the code that renames these variables doesn't check whether the variable path is qualified.  In cases where variable namespace notation is used, this code produces variable names like $__using_env:foo, preventing the remote computer from parsing the variables correctly.  The changes in this PR add handling for qualified variable paths, producing variable names like $__using_env_foo
This PR does not fix all issues with the handling of $using: expressions.  Variable names that include special characters still aren't parsed correctly, for instance.  Since a user technically could name a variable $__using_env_foo, this might be considered an "unlikely grey area" breaking change. Long-term, it might be worth reconsidering how Invoke-Command handles the -ComputerName parameter; always falling back to v2.0 seems unnecessarily restrictive.
PR Checklist

[x] PR has a meaningful title

Use the present tense and imperative mood when describing your changes

[x] Summarized changes
[x] Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
[ ] This PR is ready to merge and is not Work in Progress.

If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.

Breaking changes

[ ] None
OR
[ ] Experimental feature(s) needed

[ ] Experimental feature name(s):

User-facing changes

[x] Not Applicable
OR
[ ] Documentation needed

[ ] Issue filed:

Testing - New and feature

[x] N/A or can only be tested interactively
OR
[ ] Make sure you've added a new test if existing tests do not effectively test the code changed

Tooling

[x] I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
OR
[ ] I have considered the user experience from a tooling perspective and opened an issue in the relevant tool repository. This may include:

[ ] Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode
(which runs in a different PS Host).

[ ] Issue filed:

[ ] Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.

[ ] Issue filed:

[ ] Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).

[ ] Issue filed:

[ ] Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).

[ ] Issue filed:

When the -ComputerName parameter is used, Invoke-Command is unable to check which version of PowerShell is available on the remote computer and assumes v2.0.

I wonder why we need the workaround if we can prepare full fix.
If I understand correctly, with  ComputerName we create new runspace but do not open it in CreateHelpersForSpecifiedComputerNames(), as result we can not detect remote PowerShell version. So I guess we need to open the new runspace in CreateHelpersForSpecifiedComputerNames().

When the -ComputerName parameter is used, Invoke-Command is unable to check which version of PowerShell is available on the remote computer and assumes v2.0.

I wonder why we need the workaround if we can prepare full fix.
If I understand correctly, with ComputerName we create new runspace but do not open it in CreateHelpersForSpecifiedComputerNames(), as result we can not detect remote PowerShell version. So I guess we need to open the new runspace in CreateHelpersForSpecifiedComputerNames().

Implementing proper version detection for the -ComputerName parameter seems preferable to me as well.  Since the current behavior (falling back to v2) is documented at various points in the code comments, it seemed to be an intentional design choice, maybe based on factors I wasn't aware of.  Honestly, this is the first pull request I've submitted, and I didn't want to overstep with a potentially significant change to how Invoke-Command connections work, so I went with a more conservative fix, but I'm not married to it.

Can I get some guidance on the two tests that have failed?  It looks like Invoke-WebRequest failed to reach a URI, but I can't see how my changes would have affected that cmdlet.  Is it possible the resource was just unavailable when the test was run?
I'd also appreciate any suggestions on writing a Pester test for this issue.  I don't think any of the current remoting tests target a remote computer, so they don't offer much guidance.  So far I've been testing against computers available to me, but obviously that's too context-dependent to be of use to anyone else.  Are there any designated endpoints for this sort of testing?

I restarted CI-static.

I really wish this had made it into 7.2, waiting for 7.3 for an essential fix like this really sucks.

@PowerShell/powershell-maintainers
We only take security fixes and regression to LTS.  This is appropriate for 7.3.  Rejecting back-port.


Android crash when I try to type with my cell phone keypad.

Operating system or device, Godot version, GPU Model and driver (if graphics related):
LG G3 (d855), 4f39ce3
Issue description:
Godot crash when I try insert anything in LineEdit component without any log.

godot version?

Master branch
Em 28 de set de 2017 16:22, "volzhs"<EMAIL_ADDRESS>escreveu:

godot version?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/godotengine/godot/issues/11664#issuecomment-332922115,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABUqnbvfcv8d82Gv9GcinlGyxdO6DIq9ks5sm-PxgaJpZM4Pnrg-
.

then, revision number?

4f39ce3

I can reproduce this on commit https://github.com/godotengine/godot/commit/18d3ba0c50ac073a4588388a6bdc71cfee44ea1f, on a Samsung Galaxy S7 edge running Android 7.0. Selecting text works, but typing or erasing anything will cause the app to crash.
Exemple project: android_lineedit_bug.zip

Confirmed on Nexus 5x with build from Oct 8 (commit e4dc1f93).

related PR was merged.
@guilhermefelipecgs can you test it with the latest commit?

Fixed by #11775 according to the PR author; please comment so that we reopen it if you can't confirm it.


Use mixed additions for the Sum implementation for SW curves

Description
The Sum implementation mentioned in #288 converts the GroupAffine into GroupProjective. Indeed this is not necessary. One can simply use the mixed-type addition, which is faster.
A unit test for Sum is also added.

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

[x] Targeted PR against correct branch (master)
[x] Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
[x] Wrote unit tests
[x] Updated relevant documentation in the code
[x] Re-reviewed Files changed in the Github PR explorer

N/A: This one is too small for a CHANGELOG item.

[ ] Added a relevant changelog entry to the Pending section in CHANGELOG.md

There is a problem with fold: add_assign_mixed is "assign" so that it does not return the added result.

just discovered a method named add_mixed. Will just that one instead.

Ok, sounds good!


Login Unit Testing (PR #1)

This PR is the first of (hopefully) two for introducing unit tests to the login portion of the application. This PR includes all of the relevant unit tests, although some need further work, and so have the annotation @Ignore
In comments below, I will talk through one of the unit test files so everyone who has not encountered a unit test before can understand it.
Unit tests are designed to test small bits of functionality in our files. For example:
fun multiply(x) {
   return x * x
}

This function should always return 9 when passed the parameter of 3. If the output is 12, the unit test will pick up the error and prevent a merge to master. Either:

The logic of the function has been broken, and so needs to be fixed.
Or, We have decided to change the logic of the function, and the unit test needs to be updated accordingly.

I'm not very familiar with Unit Testing but it looks good to me


How do I edit an existing document template?

I am tasked with updating a number of complex existing document templates for a small text change and I am not finding any documentation on how to do this.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c248681b-9d1c-15c2-fbe7-ba877bf24037
Version Independent ID: c2ba677e-83f4-3e34-d663-42cfa3e89f06
Content: Create and deploy Word templates (Dynamics 365 for Marketing)
Content Source: ce/marketing/manage-word-templates.md
Service: dynamics-365-marketing
GitHub Login: @kamaybac
Microsoft Alias: kamaybac

Hi @rdegrove , I believe you'll need to download each uploaded template, make your changes, and then upload each of them again as new templates in Dynamics 365. Finally, delete the old templates if you don't need them anymore.

Thanks, yes, I figured that out. Had to use XrmToolBox.


Add Wetterdienst to the "Data Mining" section

Hi there,
first things first: Thank you for conceiving and maintaining this excellent repository.
Thanks @mmaelicke for adding dwdweather2 through #9 and also  thanks to @schymans and @rcnijzink for adding comments on that the other day.
I just wanted to give you a quick heads-up that we moved on and are developing Wetterdienst these days. We also just recognized that @raoulcollenteur already included it at [1].
So, I wanted to humbly ask about early feedback in this regard. Shall we just submit a pull request which adds Wetterdienst to the Data Mining section [2] or are there also other things to take care about?
With kind regards,
Andreas.
[1] https://github.com/raoulcollenteur/Python-Hydrology-Tools#data-collection
[2] https://github.com/Open-Environmental-Science/awesome-open-hydrology#data-mining
cc @gutzbenj

Hey @amotl ,
Just had a look at Wetterdienst and that one looks great and, indeed, awesome!
I think submitting a pull request is the way to go. There is the awesome manifesto to spot the important stuff that has to be in the linked repository. I think Wetterdinst is really, really well maintained and developed, so that will be fine.
Contributing guidelines are also available, but I think you are well familiar with the process @amotl

Hi again,
thank you already for the kind words, @mmaelicke. We are currently busy but look forward to come back here and submit a pull request for adding Wetterdienst.
Keep up the spirit and with kind regards,
Andreas.

This is really cool, thanks! If you are too busy, one of us could also create such a PR, but it would be much better if you as a developer could do it for more direct and faster communication.


Update schema to match specification

The TPC-DS specification version 3.2.0 defines many columns as "integer" and defines integer as a 64-bit type (section <IP_ADDRESS>). We were defining these columns with Spark Integer rather than Long.
The spec also defines many columns (notably those ending with _sk) as identifier type. The definition is that "the column shall be able to hold any key value generated for that column". We had previously run into data not fitting in https://github.com/NVIDIA/spark-rapids-benchmarks/pull/9#issuecomment-1138379596 and had changed store_returns.sr_ticket_number from Int to Long without changing the corresponding store_sales.ss_ticket_number to the same type and this introduces unnecessary casts into some queries.
The spec does not define a specific number of bits for the identifier type, so maybe it is valid to use different types on a case by case basis (per table).
This PR aims to make the schema match the specification:
Changes in this PR:

Change ss_ticket_number IntegerType to LongType
Changed all fields defined as integer in the spec to LongType
Made time_dim.t_time ~nullable~ non-nullable
Changed customer.c_last_review_date_sk from CharType(10) to LongType

Note that I did not check the maintenance schema.

I am going to revert the global change from int to long and just change this for the ticket number field for now.

I am a little afraid that this change will cause our daily benchmark CI fail as we have a data validation step to check if output of CPU/GPU are the same. Will the type change result in the different in output data? We are using a fixed CPU output as comparable object.
Most of the change are from Interger to Long, which should be ok.  only c_last_review_date_sk is from Char to Integer.

This LGTM, my one comment was that we could alias the types such that there is an IdentifierType that happens to be defined as IntegerType. That way we can add a comment at the top stating why it exists, and makes it clear the schema entries that have IdentifierType should be handled separately from other integral types.

I like this idea. Perhaps we can have both identifierIntType and identifierLongType defined to make it clear which one we are using for each primary/foreign key pair.

Most of the change are from Interger to Long, which should be ok. only c_last_review_date_sk is from Char to Integer.

c_last_review_date_sk is only referenced in query 30, so it may impact that one (it is used in projection and sort order, so quite possible order of output could change).

I like this idea. Perhaps we can have both identifierIntType and identifierLongType defined to make it clear which one we are using for each primary/foreign key pair.

I didn't realize there were long identifiers, but if there are and there would be a difference with other column types you have switched to LongType (aka. integer), that seems like a good thing to define in the types.

Should we add potentially in a separate PR:

some warning that the schema changed and the user might have to have to regenerate the stale schema in an external catalog?
or even validation to actually check for this and warn the user only if that's the case ?


Export cloudkms algorithm parsing functions and add method for accessing KeyManagementClient

Closes: #194
Closes: #201
Description
This PR makes the cloudkms algo parsing functions exported and adds a KMSClient() method for accessing the KeyManagementClient directly (e.g. for closing the client as requested in #194). Original PR #204, this PR contains the suggested modifications.

For contributor use:

[x] Targeted PR against master branch
[x] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
[x] Code follows the standards mentioned here.
[ ] Updated relevant documentation
[x] Re-reviewed Files changed in the Github PR explorer
[ ] Added appropriate labels

ping @psiemens @turbolent :)

@nanuuki do you still need this feature?

@sideninja yes, it would be very useful :)


Commit reliability on client after receiving ACK

From RFC 8832
https://www.rfc-editor.org/rfc/rfc8832.html#name-procedures, messages should be ordered till dialing/opening side receives ACK.
After the DATA_CHANNEL_OPEN message has been sent,
the sender of that message MAY start sending messages
containing user data without waiting for the reception
of the corresponding DATA_CHANNEL_ACK message. However,
before the DATA_CHANNEL_ACK message or any other message
has been received on a data channel, all other messages
containing user data and belonging to this data channel
MUST be sent ordered, no matter whether the data channel
is ordered or not. After the DATA_CHANNEL_ACK or any
other message has been received on the data channel,
messages containing user data MUST be sent ordered on
ordered data channels and MUST be sent unordered on
unordered data channels. Therefore, receiving a message
containing user data on an unused stream indicates an error.
In that case, the corresponding data channel MUST be closed,
as described in [RFC8831].

Without waiting, the data channel open failed on Accept side as the first message did not have PPI of DCEP. It got a user message and that caused the Accept to fail.
Description
Reference issue
Fixes #...

Thank you @boks1971 !
wanna tag and put in /v3 and /v4 I believe we have an open issue because of this.
You can override the CI failure. I’m not sure why it started falling yesterday will fix today

Thank you @boks1971 !
wanna tag and put in /v3 and /v4 I believe we have an open issue because of this.
You can override the CI failure. I’m not sure why it started falling yesterday will fix today

Can do that @Sean-Der . But, GH is not allowing me to override (greyed out button). Lint is failing on deps.

@Sean-Der Renovate PR updated the tag (I created v1.5.9 with this change) in master of pion/webrtc.
I am trying to update /v3 and getting the following
% go get -u github.com/pion/datachannel
go: upgraded github.com/pion/datachannel v1.5.8 => v1.5.9
go: upgraded github.com/pion/sctp v1.8.19 => v1.8.33
raja@Rajas-MacBook-Pro webrtc % go mod tidy
go: github.com/pion/webrtc/v3 imports
	golang.org/x/net/proxy loaded from<EMAIL_ADDRESS>	but go 1.16 would select v0.27.0
go: github.com/pion/webrtc/v3/examples/trickle-ice imports
	golang.org/x/net/websocket loaded from<EMAIL_ADDRESS>	but go 1.16 would select v0.27.0
go: github.com/pion/webrtc/v3 imports
	github.com/pion/dtls/v2/pkg/crypto/elliptic imports
	golang.org/x/crypto/curve25519 loaded from<EMAIL_ADDRESS>	but go 1.16 would select v0.25.0
go: github.com/pion/webrtc/v3 imports
	github.com/pion/ice/v2 imports
	golang.org/x/net/ipv4 loaded from<EMAIL_ADDRESS>	but go 1.16 would select v0.27.0
go: github.com/pion/webrtc/v3 imports
	golang.org/x/net/proxy imports
	golang.org/x/net/internal/socks loaded from<EMAIL_ADDRESS>	but go 1.16 would select v0.27.0
go: github.com/pion/webrtc/v3 imports
	github.com/pion/dtls/v2 imports
	github.com/pion/dtls/v2/pkg/protocol/extension imports
	golang.org/x/crypto/cryptobyte loaded from<EMAIL_ADDRESS>	but go 1.16 would select v0.25.0
go: github.com/pion/webrtc/v3 imports
	github.com/pion/dtls/v2 imports
	github.com/pion/transport/v2/udp imports
	golang.org/x/net/ipv6 loaded from<EMAIL_ADDRESS>	but go 1.16 would select v0.27.0
go: github.com/pion/webrtc/v3 imports
	github.com/pion/dtls/v2 tested by
	github.com/pion/dtls/v2.test imports
	golang.org/x/net/nettest loaded from<EMAIL_ADDRESS>	but go 1.16 would select v0.27.0
go: github.com/pion/webrtc/v3 imports
	github.com/pion/dtls/v2/pkg/crypto/elliptic imports
	golang.org/x/crypto/curve25519 imports
	golang.org/x/crypto/curve25519/internal/field loaded from<EMAIL_ADDRESS>	but go 1.16 would fail to locate it in<EMAIL_ADDRESS>go: github.com/pion/webrtc/v3 imports
	github.com/pion/ice/v2 imports
	github.com/pion/mdns imports
	golang.org/x/net/dns/dnsmessage loaded from<EMAIL_ADDRESS>	but go 1.16 would select v0.27.0
go: github.com/pion/webrtc/v3 imports
	github.com/pion/ice/v2 imports
	golang.org/x/net/ipv4 imports
	golang.org/x/net/bpf loaded from<EMAIL_ADDRESS>	but go 1.16 would select v0.27.0
go: github.com/pion/webrtc/v3 imports
	github.com/pion/ice/v2 imports
	golang.org/x/net/ipv4 imports
	golang.org/x/net/internal/iana loaded from<EMAIL_ADDRESS>	but go 1.16 would select v0.27.0
go: github.com/pion/webrtc/v3 imports
	github.com/pion/ice/v2 imports
	golang.org/x/net/ipv4 imports
	golang.org/x/net/internal/socket loaded from<EMAIL_ADDRESS>	but go 1.16 would select v0.27.0
go: github.com/pion/webrtc/v3 imports
	github.com/pion/ice/v2 imports
	golang.org/x/net/ipv4 imports
	golang.org/x/sys/unix loaded from<EMAIL_ADDRESS>	but go 1.16 would select v0.22.0
go: github.com/pion/webrtc/v3 imports
	github.com/pion/ice/v2 imports
	golang.org/x/net/ipv4 imports
	golang.org/x/sys/windows loaded from<EMAIL_ADDRESS>	but go 1.16 would select v0.22.0
go: github.com/pion/webrtc/v3 imports
	github.com/pion/srtp/v2 imports
	github.com/pion/transport/v2/utils/xor imports
	golang.org/x/sys/cpu loaded from<EMAIL_ADDRESS>	but go 1.16 would select v0.22.0
go: github.com/pion/webrtc/v3 imports
	golang.org/x/net/proxy tested by
	golang.org/x/net/proxy.test imports
	golang.org/x/net/internal/sockstest loaded from<EMAIL_ADDRESS>	but go 1.16 would select v0.27.0
go: github.com/pion/webrtc/v3 imports
	github.com/pion/dtls/v2 imports
	github.com/pion/dtls/v2/pkg/protocol/extension imports
	golang.org/x/crypto/cryptobyte imports
	golang.org/x/crypto/cryptobyte/asn1 loaded from<EMAIL_ADDRESS>	but go 1.16 would select v0.25.0
go: github.com/pion/webrtc/v3 imports
	github.com/pion/ice/v2 imports
	golang.org/x/net/ipv4 tested by
	golang.org/x/net/ipv4.test imports
	golang.org/x/net/icmp loaded from<EMAIL_ADDRESS>	but go 1.16 would select v0.27.0
go: github.com/pion/webrtc/v3/e2e tested by
	github.com/pion/webrtc/v3/e2e.test imports
	github.com/sclevine/agouti tested by
	github.com/sclevine/agouti.test imports
	github.com/onsi/gomega imports
	github.com/onsi/gomega/matchers imports
	golang.org/x/net/html/charset loaded from<EMAIL_ADDRESS>	but go 1.16 would select v0.27.0
go: github.com/pion/webrtc/v3/e2e tested by
	github.com/pion/webrtc/v3/e2e.test imports
	github.com/sclevine/agouti tested by
	github.com/sclevine/agouti.test imports
	github.com/onsi/gomega imports
	github.com/onsi/gomega/matchers imports
	golang.org/x/net/html/charset imports
	golang.org/x/net/html loaded from<EMAIL_ADDRESS>	but go 1.16 would select v0.27.0
go: github.com/pion/webrtc/v3/e2e tested by
	github.com/pion/webrtc/v3/e2e.test imports
	github.com/sclevine/agouti tested by
	github.com/sclevine/agouti.test imports
	github.com/onsi/gomega imports
	github.com/onsi/gomega/matchers imports
	golang.org/x/net/html/charset imports
	golang.org/x/text/encoding loaded from<EMAIL_ADDRESS>	but go 1.16 would select v0.16.0
go: github.com/pion/webrtc/v3/e2e tested by
	github.com/pion/webrtc/v3/e2e.test imports
	github.com/sclevine/agouti tested by
	github.com/sclevine/agouti.test imports
	github.com/onsi/gomega imports
	github.com/onsi/gomega/matchers imports
	golang.org/x/net/html/charset imports
	golang.org/x/text/encoding/charmap loaded from<EMAIL_ADDRESS>	but go 1.16 would select v0.16.0
go: github.com/pion/webrtc/v3/e2e tested by
	github.com/pion/webrtc/v3/e2e.test imports
	github.com/sclevine/agouti tested by
	github.com/sclevine/agouti.test imports
	github.com/onsi/gomega imports
	github.com/onsi/gomega/matchers imports
	golang.org/x/net/html/charset imports
	golang.org/x/text/encoding/htmlindex loaded from<EMAIL_ADDRESS>	but go 1.16 would select v0.16.0
go: github.com/pion/webrtc/v3/e2e tested by
	github.com/pion/webrtc/v3/e2e.test imports
	github.com/sclevine/agouti tested by
	github.com/sclevine/agouti.test imports
	github.com/onsi/gomega imports
	github.com/onsi/gomega/matchers imports
	golang.org/x/net/html/charset imports
	golang.org/x/text/transform loaded from<EMAIL_ADDRESS>	but go 1.16 would select v0.16.0
go: github.com/pion/webrtc/v3/e2e tested by
	github.com/pion/webrtc/v3/e2e.test imports
	github.com/sclevine/agouti tested by
	github.com/sclevine/agouti.test imports
	github.com/onsi/gomega imports
	github.com/onsi/gomega/matchers imports
	golang.org/x/net/html/charset imports
	golang.org/x/net/html imports
	golang.org/x/net/html/atom loaded from<EMAIL_ADDRESS>	but go 1.16 would select v0.27.0
go: github.com/pion/webrtc/v3/e2e tested by
	github.com/pion/webrtc/v3/e2e.test imports
	github.com/sclevine/agouti tested by
	github.com/sclevine/agouti.test imports
	github.com/onsi/gomega imports
	github.com/onsi/gomega/matchers imports
	golang.org/x/net/html/charset imports
	golang.org/x/text/encoding imports
	golang.org/x/text/encoding/internal/identifier loaded from<EMAIL_ADDRESS>	but go 1.16 would select v0.16.0
go: github.com/pion/webrtc/v3/e2e tested by
	github.com/pion/webrtc/v3/e2e.test imports
	github.com/sclevine/agouti tested by
	github.com/sclevine/agouti.test imports
	github.com/onsi/gomega imports
	github.com/onsi/gomega/matchers imports
	golang.org/x/net/html/charset imports
	golang.org/x/text/encoding/charmap imports
	golang.org/x/text/encoding/internal loaded from<EMAIL_ADDRESS>	but go 1.16 would select v0.16.0
go: github.com/pion/webrtc/v3/e2e tested by
	github.com/pion/webrtc/v3/e2e.test imports
	github.com/sclevine/agouti tested by
	github.com/sclevine/agouti.test imports
	github.com/onsi/gomega imports
	github.com/onsi/gomega/matchers imports
	golang.org/x/net/html/charset imports
	golang.org/x/text/encoding/htmlindex imports
	golang.org/x/text/encoding/japanese loaded from<EMAIL_ADDRESS>	but go 1.16 would select v0.16.0
go: github.com/pion/webrtc/v3/e2e tested by
	github.com/pion/webrtc/v3/e2e.test imports
	github.com/sclevine/agouti tested by
	github.com/sclevine/agouti.test imports
	github.com/onsi/gomega imports
	github.com/onsi/gomega/matchers imports
	golang.org/x/net/html/charset imports
	golang.org/x/text/encoding/htmlindex imports
	golang.org/x/text/encoding/korean loaded from<EMAIL_ADDRESS>	but go 1.16 would select v0.16.0
go: github.com/pion/webrtc/v3/e2e tested by
	github.com/pion/webrtc/v3/e2e.test imports
	github.com/sclevine/agouti tested by
	github.com/sclevine/agouti.test imports
	github.com/onsi/gomega imports
	github.com/onsi/gomega/matchers imports
	golang.org/x/net/html/charset imports
	golang.org/x/text/encoding/htmlindex imports
	golang.org/x/text/encoding/simplifiedchinese loaded from<EMAIL_ADDRESS>	but go 1.16 would select v0.16.0
go: github.com/pion/webrtc/v3/e2e tested by
	github.com/pion/webrtc/v3/e2e.test imports
	github.com/sclevine/agouti tested by
	github.com/sclevine/agouti.test imports
	github.com/onsi/gomega imports
	github.com/onsi/gomega/matchers imports
	golang.org/x/net/html/charset imports
	golang.org/x/text/encoding/htmlindex imports
	golang.org/x/text/encoding/traditionalchinese loaded from<EMAIL_ADDRESS>	but go 1.16 would select v0.16.0
go: github.com/pion/webrtc/v3/e2e tested by
	github.com/pion/webrtc/v3/e2e.test imports
	github.com/sclevine/agouti tested by
	github.com/sclevine/agouti.test imports
	github.com/onsi/gomega imports
	github.com/onsi/gomega/matchers imports
	golang.org/x/net/html/charset imports
	golang.org/x/text/encoding/htmlindex imports
	golang.org/x/text/encoding/unicode loaded from<EMAIL_ADDRESS>	but go 1.16 would select v0.16.0
go: github.com/pion/webrtc/v3/e2e tested by
	github.com/pion/webrtc/v3/e2e.test imports
	github.com/sclevine/agouti tested by
	github.com/sclevine/agouti.test imports
	github.com/onsi/gomega imports
	github.com/onsi/gomega/matchers imports
	golang.org/x/net/html/charset imports
	golang.org/x/text/encoding/htmlindex imports
	golang.org/x/text/language loaded from<EMAIL_ADDRESS>	but go 1.16 would select v0.16.0
go: github.com/pion/webrtc/v3/e2e tested by
	github.com/pion/webrtc/v3/e2e.test imports
	github.com/sclevine/agouti tested by
	github.com/sclevine/agouti.test imports
	github.com/onsi/gomega imports
	github.com/onsi/gomega/matchers imports
	golang.org/x/net/html/charset imports
	golang.org/x/text/encoding/htmlindex imports
	golang.org/x/text/encoding/unicode imports
	golang.org/x/text/internal/utf8internal loaded from<EMAIL_ADDRESS>	but go 1.16 would select v0.16.0
go: github.com/pion/webrtc/v3/e2e tested by
	github.com/pion/webrtc/v3/e2e.test imports
	github.com/sclevine/agouti tested by
	github.com/sclevine/agouti.test imports
	github.com/onsi/gomega imports
	github.com/onsi/gomega/matchers imports
	golang.org/x/net/html/charset imports
	golang.org/x/text/encoding/htmlindex imports
	golang.org/x/text/encoding/unicode imports
	golang.org/x/text/runes loaded from<EMAIL_ADDRESS>	but go 1.16 would select v0.16.0
go: github.com/pion/webrtc/v3/e2e tested by
	github.com/pion/webrtc/v3/e2e.test imports
	github.com/sclevine/agouti tested by
	github.com/sclevine/agouti.test imports
	github.com/onsi/gomega imports
	github.com/onsi/gomega/matchers imports
	golang.org/x/net/html/charset imports
	golang.org/x/text/encoding/htmlindex imports
	golang.org/x/text/language imports
	golang.org/x/text/internal/language loaded from<EMAIL_ADDRESS>	but go 1.16 would select v0.16.0
go: github.com/pion/webrtc/v3/e2e tested by
	github.com/pion/webrtc/v3/e2e.test imports
	github.com/sclevine/agouti tested by
	github.com/sclevine/agouti.test imports
	github.com/onsi/gomega imports
	github.com/onsi/gomega/matchers imports
	golang.org/x/net/html/charset imports
	golang.org/x/text/encoding/htmlindex imports
	golang.org/x/text/language imports
	golang.org/x/text/internal/language/compact loaded from<EMAIL_ADDRESS>	but go 1.16 would select v0.16.0
go: github.com/pion/webrtc/v3/e2e tested by
	github.com/pion/webrtc/v3/e2e.test imports
	github.com/sclevine/agouti tested by
	github.com/sclevine/agouti.test imports
	github.com/onsi/gomega imports
	github.com/onsi/gomega/matchers imports
	golang.org/x/net/html/charset imports
	golang.org/x/text/encoding/htmlindex imports
	golang.org/x/text/language imports
	golang.org/x/text/internal/language imports
	golang.org/x/text/internal/tag loaded from<EMAIL_ADDRESS>	but go 1.16 would select v0.16.0

To upgrade to the versions selected by go 1.16, leaving some packages unresolved:
	go mod tidy -e -go=1.16 && go mod tidy -e -go=1.17
If reproducibility with go 1.16 is not needed:
	go mod tidy -compat=1.17
For other options, see:
	https://golang.org/doc/modules/pruning
go: github.com/pion/webrtc/v3 imports
	golang.org/x/net/proxy loaded from<EMAIL_ADDRESS>	but go 1.16 would select v0.27.0
go: github.com/pion/webrtc/v3/examples/trickle-ice imports
	golang.org/x/net/websocket loaded from<EMAIL_ADDRESS>	but go 1.16 would select v0.27.0
go: github.com/pion/webrtc/v3 imports
	github.com/pion/dtls/v2/pkg/crypto/elliptic imports
	golang.org/x/crypto/curve25519 loaded from<EMAIL_ADDRESS>	but go 1.16 would select v0.25.0
go: github.com/pion/webrtc/v3 imports
	github.com/pion/ice/v2 imports
	golang.org/x/net/ipv4 loaded from<EMAIL_ADDRESS>	but go 1.16 would select v0.27.0
go: github.com/pion/webrtc/v3 imports
	golang.org/x/net/proxy imports
	golang.org/x/net/internal/socks loaded from<EMAIL_ADDRESS>	but go 1.16 would select v0.27.0
go: github.com/pion/webrtc/v3 imports
	github.com/pion/dtls/v2 imports
	github.com/pion/dtls/v2/pkg/protocol/extension imports
	golang.org/x/crypto/cryptobyte loaded from<EMAIL_ADDRESS>	but go 1.16 would select v0.25.0
go: github.com/pion/webrtc/v3 imports
	github.com/pion/dtls/v2 imports
	github.com/pion/transport/v2/udp imports
	golang.org/x/net/ipv6 loaded from<EMAIL_ADDRESS>	but go 1.16 would select v0.27.0
go: github.com/pion/webrtc/v3 imports
	github.com/pion/dtls/v2 tested by
	github.com/pion/dtls/v2.test imports
	golang.org/x/net/nettest loaded from<EMAIL_ADDRESS>	but go 1.16 would select v0.27.0
go: github.com/pion/webrtc/v3 imports
	github.com/pion/dtls/v2/pkg/crypto/elliptic imports
	golang.org/x/crypto/curve25519 imports
	golang.org/x/crypto/curve25519/internal/field loaded from<EMAIL_ADDRESS>	but go 1.16 would fail to locate it in<EMAIL_ADDRESS>go: github.com/pion/webrtc/v3 imports
	github.com/pion/ice/v2 imports
	github.com/pion/mdns imports
	golang.org/x/net/dns/dnsmessage loaded from<EMAIL_ADDRESS>	but go 1.16 would select v0.27.0
go: github.com/pion/webrtc/v3 imports
	github.com/pion/ice/v2 imports
	golang.org/x/net/ipv4 imports
	golang.org/x/net/bpf loaded from<EMAIL_ADDRESS>	but go 1.16 would select v0.27.0
go: github.com/pion/webrtc/v3 imports
	github.com/pion/ice/v2 imports
	golang.org/x/net/ipv4 imports
	golang.org/x/net/internal/iana loaded from<EMAIL_ADDRESS>	but go 1.16 would select v0.27.0
go: github.com/pion/webrtc/v3 imports
	github.com/pion/ice/v2 imports
	golang.org/x/net/ipv4 imports
	golang.org/x/net/internal/socket loaded from<EMAIL_ADDRESS>	but go 1.16 would select v0.27.0
go: github.com/pion/webrtc/v3 imports
	github.com/pion/ice/v2 imports
	golang.org/x/net/ipv4 imports
	golang.org/x/sys/unix loaded from<EMAIL_ADDRESS>	but go 1.16 would select v0.22.0
go: github.com/pion/webrtc/v3 imports
	github.com/pion/ice/v2 imports
	golang.org/x/net/ipv4 imports
	golang.org/x/sys/windows loaded from<EMAIL_ADDRESS>	but go 1.16 would select v0.22.0
go: github.com/pion/webrtc/v3 imports
	github.com/pion/srtp/v2 imports
	github.com/pion/transport/v2/utils/xor imports
	golang.org/x/sys/cpu loaded from<EMAIL_ADDRESS>	but go 1.16 would select v0.22.0
go: github.com/pion/webrtc/v3 imports
	golang.org/x/net/proxy tested by
	golang.org/x/net/proxy.test imports
	golang.org/x/net/internal/sockstest loaded from<EMAIL_ADDRESS>	but go 1.16 would select v0.27.0
go: github.com/pion/webrtc/v3 imports
	github.com/pion/dtls/v2 imports
	github.com/pion/dtls/v2/pkg/protocol/extension imports
	golang.org/x/crypto/cryptobyte imports
	golang.org/x/crypto/cryptobyte/asn1 loaded from<EMAIL_ADDRESS>	but go 1.16 would select v0.25.0
go: github.com/pion/webrtc/v3 imports
	github.com/pion/ice/v2 imports
	golang.org/x/net/ipv4 tested by
	golang.org/x/net/ipv4.test imports
	golang.org/x/net/icmp loaded from<EMAIL_ADDRESS>	but go 1.16 would select v0.27.0
go: github.com/pion/webrtc/v3/e2e tested by
	github.com/pion/webrtc/v3/e2e.test imports
	github.com/sclevine/agouti tested by
	github.com/sclevine/agouti.test imports
	github.com/onsi/gomega imports
	github.com/onsi/gomega/matchers imports
	golang.org/x/net/html/charset loaded from<EMAIL_ADDRESS>	but go 1.16 would select v0.27.0
go: github.com/pion/webrtc/v3/e2e tested by
	github.com/pion/webrtc/v3/e2e.test imports
	github.com/sclevine/agouti tested by
	github.com/sclevine/agouti.test imports
	github.com/onsi/gomega imports
	github.com/onsi/gomega/matchers imports
	golang.org/x/net/html/charset imports
	golang.org/x/net/html loaded from<EMAIL_ADDRESS>	but go 1.16 would select v0.27.0
go: github.com/pion/webrtc/v3/e2e tested by
	github.com/pion/webrtc/v3/e2e.test imports
	github.com/sclevine/agouti tested by
	github.com/sclevine/agouti.test imports
	github.com/onsi/gomega imports
	github.com/onsi/gomega/matchers imports
	golang.org/x/net/html/charset imports
	golang.org/x/text/encoding loaded from<EMAIL_ADDRESS>	but go 1.16 would select v0.16.0
go: github.com/pion/webrtc/v3/e2e tested by
	github.com/pion/webrtc/v3/e2e.test imports
	github.com/sclevine/agouti tested by
	github.com/sclevine/agouti.test imports
	github.com/onsi/gomega imports
	github.com/onsi/gomega/matchers imports
	golang.org/x/net/html/charset imports
	golang.org/x/text/encoding/charmap loaded from<EMAIL_ADDRESS>	but go 1.16 would select v0.16.0
go: github.com/pion/webrtc/v3/e2e tested by
	github.com/pion/webrtc/v3/e2e.test imports
	github.com/sclevine/agouti tested by
	github.com/sclevine/agouti.test imports
	github.com/onsi/gomega imports
	github.com/onsi/gomega/matchers imports
	golang.org/x/net/html/charset imports
	golang.org/x/text/encoding/htmlindex loaded from<EMAIL_ADDRESS>	but go 1.16 would select v0.16.0
go: github.com/pion/webrtc/v3/e2e tested by
	github.com/pion/webrtc/v3/e2e.test imports
	github.com/sclevine/agouti tested by
	github.com/sclevine/agouti.test imports
	github.com/onsi/gomega imports
	github.com/onsi/gomega/matchers imports
	golang.org/x/net/html/charset imports
	golang.org/x/text/transform loaded from<EMAIL_ADDRESS>	but go 1.16 would select v0.16.0
go: github.com/pion/webrtc/v3/e2e tested by
	github.com/pion/webrtc/v3/e2e.test imports
	github.com/sclevine/agouti tested by
	github.com/sclevine/agouti.test imports
	github.com/onsi/gomega imports
	github.com/onsi/gomega/matchers imports
	golang.org/x/net/html/charset imports
	golang.org/x/net/html imports
	golang.org/x/net/html/atom loaded from<EMAIL_ADDRESS>	but go 1.16 would select v0.27.0
go: github.com/pion/webrtc/v3/e2e tested by
	github.com/pion/webrtc/v3/e2e.test imports
	github.com/sclevine/agouti tested by
	github.com/sclevine/agouti.test imports
	github.com/onsi/gomega imports
	github.com/onsi/gomega/matchers imports
	golang.org/x/net/html/charset imports
	golang.org/x/text/encoding imports
	golang.org/x/text/encoding/internal/identifier loaded from<EMAIL_ADDRESS>	but go 1.16 would select v0.16.0
go: github.com/pion/webrtc/v3/e2e tested by
	github.com/pion/webrtc/v3/e2e.test imports
	github.com/sclevine/agouti tested by
	github.com/sclevine/agouti.test imports
	github.com/onsi/gomega imports
	github.com/onsi/gomega/matchers imports
	golang.org/x/net/html/charset imports
	golang.org/x/text/encoding/charmap imports
	golang.org/x/text/encoding/internal loaded from<EMAIL_ADDRESS>	but go 1.16 would select v0.16.0
go: github.com/pion/webrtc/v3/e2e tested by
	github.com/pion/webrtc/v3/e2e.test imports
	github.com/sclevine/agouti tested by
	github.com/sclevine/agouti.test imports
	github.com/onsi/gomega imports
	github.com/onsi/gomega/matchers imports
	golang.org/x/net/html/charset imports
	golang.org/x/text/encoding/htmlindex imports
	golang.org/x/text/encoding/japanese loaded from<EMAIL_ADDRESS>	but go 1.16 would select v0.16.0
go: github.com/pion/webrtc/v3/e2e tested by
	github.com/pion/webrtc/v3/e2e.test imports
	github.com/sclevine/agouti tested by
	github.com/sclevine/agouti.test imports
	github.com/onsi/gomega imports
	github.com/onsi/gomega/matchers imports
	golang.org/x/net/html/charset imports
	golang.org/x/text/encoding/htmlindex imports
	golang.org/x/text/encoding/korean loaded from<EMAIL_ADDRESS>	but go 1.16 would select v0.16.0
go: github.com/pion/webrtc/v3/e2e tested by
	github.com/pion/webrtc/v3/e2e.test imports
	github.com/sclevine/agouti tested by
	github.com/sclevine/agouti.test imports
	github.com/onsi/gomega imports
	github.com/onsi/gomega/matchers imports
	golang.org/x/net/html/charset imports
	golang.org/x/text/encoding/htmlindex imports
	golang.org/x/text/encoding/simplifiedchinese loaded from<EMAIL_ADDRESS>	but go 1.16 would select v0.16.0
go: github.com/pion/webrtc/v3/e2e tested by
	github.com/pion/webrtc/v3/e2e.test imports
	github.com/sclevine/agouti tested by
	github.com/sclevine/agouti.test imports
	github.com/onsi/gomega imports
	github.com/onsi/gomega/matchers imports
	golang.org/x/net/html/charset imports
	golang.org/x/text/encoding/htmlindex imports
	golang.org/x/text/encoding/traditionalchinese loaded from<EMAIL_ADDRESS>	but go 1.16 would select v0.16.0
go: github.com/pion/webrtc/v3/e2e tested by
	github.com/pion/webrtc/v3/e2e.test imports
	github.com/sclevine/agouti tested by
	github.com/sclevine/agouti.test imports
	github.com/onsi/gomega imports
	github.com/onsi/gomega/matchers imports
	golang.org/x/net/html/charset imports
	golang.org/x/text/encoding/htmlindex imports
	golang.org/x/text/encoding/unicode loaded from<EMAIL_ADDRESS>	but go 1.16 would select v0.16.0
go: github.com/pion/webrtc/v3/e2e tested by
	github.com/pion/webrtc/v3/e2e.test imports
	github.com/sclevine/agouti tested by
	github.com/sclevine/agouti.test imports
	github.com/onsi/gomega imports
	github.com/onsi/gomega/matchers imports
	golang.org/x/net/html/charset imports
	golang.org/x/text/encoding/htmlindex imports
	golang.org/x/text/language loaded from<EMAIL_ADDRESS>	but go 1.16 would select v0.16.0
go: github.com/pion/webrtc/v3/e2e tested by
	github.com/pion/webrtc/v3/e2e.test imports
	github.com/sclevine/agouti tested by
	github.com/sclevine/agouti.test imports
	github.com/onsi/gomega imports
	github.com/onsi/gomega/matchers imports
	golang.org/x/net/html/charset imports
	golang.org/x/text/encoding/htmlindex imports
	golang.org/x/text/encoding/unicode imports
	golang.org/x/text/internal/utf8internal loaded from<EMAIL_ADDRESS>	but go 1.16 would select v0.16.0
go: github.com/pion/webrtc/v3/e2e tested by
	github.com/pion/webrtc/v3/e2e.test imports
	github.com/sclevine/agouti tested by
	github.com/sclevine/agouti.test imports
	github.com/onsi/gomega imports
	github.com/onsi/gomega/matchers imports
	golang.org/x/net/html/charset imports
	golang.org/x/text/encoding/htmlindex imports
	golang.org/x/text/encoding/unicode imports
	golang.org/x/text/runes loaded from<EMAIL_ADDRESS>	but go 1.16 would select v0.16.0
go: github.com/pion/webrtc/v3/e2e tested by
	github.com/pion/webrtc/v3/e2e.test imports
	github.com/sclevine/agouti tested by
	github.com/sclevine/agouti.test imports
	github.com/onsi/gomega imports
	github.com/onsi/gomega/matchers imports
	golang.org/x/net/html/charset imports
	golang.org/x/text/encoding/htmlindex imports
	golang.org/x/text/language imports
	golang.org/x/text/internal/language loaded from<EMAIL_ADDRESS>	but go 1.16 would select v0.16.0
go: github.com/pion/webrtc/v3/e2e tested by
	github.com/pion/webrtc/v3/e2e.test imports
	github.com/sclevine/agouti tested by
	github.com/sclevine/agouti.test imports
	github.com/onsi/gomega imports
	github.com/onsi/gomega/matchers imports
	golang.org/x/net/html/charset imports
	golang.org/x/text/encoding/htmlindex imports
	golang.org/x/text/language imports
	golang.org/x/text/internal/language/compact loaded from<EMAIL_ADDRESS>	but go 1.16 would select v0.16.0
go: github.com/pion/webrtc/v3/e2e tested by
	github.com/pion/webrtc/v3/e2e.test imports
	github.com/sclevine/agouti tested by
	github.com/sclevine/agouti.test imports
	github.com/onsi/gomega imports
	github.com/onsi/gomega/matchers imports
	golang.org/x/net/html/charset imports
	golang.org/x/text/encoding/htmlindex imports
	golang.org/x/text/language imports
	golang.org/x/text/internal/language imports
	golang.org/x/text/internal/tag loaded from<EMAIL_ADDRESS>	but go 1.16 would select v0.16.0

Can you advise what we should do here?

Tests do work though although go mod tidy output the ☝ . go.sum has both new and old versions of datachannel and sctp. It does not get tidied up. The diff looks like this
 % git diff
diff --git a/go.mod b/go.mod
index 91dc415..80f2d42 100644
--- a/go.mod
+++ b/go.mod
@@ -3,7 +3,7 @@ module github.com/pion/webrtc/v3
 go 1.17

 require (
-       github.com/pion/datachannel v1.5.8
+       github.com/pion/datachannel v1.5.9
        github.com/pion/dtls/v2 v2.2.12
        github.com/pion/ice/v2 v2.3.34
        github.com/pion/interceptor v0.1.29
@@ -11,7 +11,7 @@ require (
        github.com/pion/randutil v0.1.0
        github.com/pion/rtcp v1.2.14
        github.com/pion/rtp v1.8.7
-       github.com/pion/sctp v1.8.19
+       github.com/pion/sctp v1.8.33
        github.com/pion/sdp/v3 v3.0.9
        github.com/pion/srtp/v2 v2.0.20
        github.com/pion/stun v0.6.1
diff --git a/go.sum b/go.sum
index 7127195..f0f04fb 100644
--- a/go.sum
+++ b/go.sum
@@ -42,6 +42,8 @@ github.com/onsi/gomega v1.17.0 h1:9Luw4uT5HTjHTN8+aNcSThgH1vdXnmdJ8xIfZ4wyTRE=
 github.com/onsi/gomega v1.17.0/go.mod h1:HnhC7FXeEQY45zxNK3PPoIUhzk/80Xly9PcubAlGdZY=
 github.com/pion/datachannel v1.5.8 h1:ph1P1NsGkazkjrvyMfhRBUAWMxugJjq2HfQifaOoSNo=
 github.com/pion/datachannel v1.5.8/go.mod h1:PgmdpoaNBLX9HNzNClmdki4DYW5JtI7Yibu8QzbL3tI=
+github.com/pion/datachannel v1.5.9 h1:LpIWAOYPyDrXtU+BW7X0Yt/vGtYxtXQ8ql7dFfYUVZA=
+github.com/pion/datachannel v1.5.9/go.mod h1:kDUuk4CU4Uxp82NH4LQZbISULkX/HtzKa4P7ldf9izE=
 github.com/pion/dtls/v2 v2.2.7/go.mod h1:8WiMkebSHFD0T+dIU+UeBaoV7kDhOW5oDCzZ7WZ/F9s=
 github.com/pion/dtls/v2 v2.2.12 h1:KP7H5/c1EiVAAKUmXyCzPiQe5+bCJrpOeKg/L05dunk=
 github.com/pion/dtls/v2 v2.2.12/go.mod h1:d9SYc9fch0CqK90mRk1dC7AkzzpwJj6u2GU3u+9pqFE=
@@ -65,6 +67,8 @@ github.com/pion/rtp v1.8.7/go.mod h1:pBGHaFt/yW7bf1jjWAoUjpSNoDnw98KTMg+jWWvziqU
 github.com/pion/sctp v1.8.18/go.mod h1:P6PbDVA++OJMrVNg2AL3XtYHV4uD6dvfyOovCgMs0PE=
 github.com/pion/sctp v1.8.19 h1:2CYuw+SQ5vkQ9t0HdOPccsCz1GQMDuVy5PglLgKVBW8=
 github.com/pion/sctp v1.8.19/go.mod h1:P6PbDVA++OJMrVNg2AL3XtYHV4uD6dvfyOovCgMs0PE=
+github.com/pion/sctp v1.8.33 h1:dSE4wX6uTJBcNm8+YlMg7lw1wqyKHggsP5uKbdj+NZw=
+github.com/pion/sctp v1.8.33/go.mod h1:beTnqSzewI53KWoG3nqB282oDMGrhNxBdb+JZnkCwRM=
 github.com/pion/sdp/v3 v3.0.9 h1:pX++dCHoHUwq43kuwf3PyJfHlwIj4hXA7Vrifiq0IJY=
 github.com/pion/sdp/v3 v3.0.9/go.mod h1:B5xmvENq5IXJimIO4zfp6LAe1fD9N+kFv+V/1lOdz8M=
 github.com/pion/srtp/v2 v2.0.20 h1:HNNny4s+OUmG280ETrCdgFndp4ufx3/uy85EawYEhTk=


Getting an error: NullInjectorError: No provider for OutletService!

When trying to include this package in an angular app, i get the following error:
ERROR NullInjectorError: R3InjectorError(AppModule)[OutletService -> OutletService -> OutletService]:
NullInjectorError: No provider for OutletService!
here is my app.module.ts
import { BrowserModule } from '@angular/platform-browser';
import { NgModule} from '@angular/core';
import { AppRoutingModule } from './app-routing.module';
import { AppComponent } from './app.component';
import { HashLocationStrategy, LocationStrategy } from '@angular/common';
import { FormsModule, ReactiveFormsModule } from '@angular/forms';
import { DynamicHooksModule, HookParserEntry } from 'ngx-dynamic-hooks';
import { KrakenButtonModule, KrakenButtonComponent } from 'kraken-button';
const componentParsers: Array<HookParserEntry> = [
 {component: KrakenButtonComponent}
];
@NgModule({
  declarations: [
    AppComponent,
],
 imports: [
    BrowserModule,
    AppRoutingModule,
    DynamicHooksModule,
providers: [
    {provide: LocationStrategy, useClass: HashLocationStrategy}
  ],
  entryComponents: [],
  bootstrap: [AppComponent]
})
export class AppModule {
  constructor() {
  }
}
And in my component html file i have:
<ngx-dynamic-hooks [content]="content" [context]="context" [options]="{sanitize: false}"></ngx-dynamic-hooks>
My component ts file has:
public content: any;
public context: any;
What could be causing this error? I have previous added this package to a few component libraries with no problems, but this is the first time I'm trying to use it within an angular app. I'm running angular 15

Hello there,
is it possible that you just forgot to call forRoot on the module? Like so:
  imports: [
      BrowserModule,
      AppRoutingModule,
      DynamicHooksModule.forRoot({
        globalParsers: componentParsers
      }),
  ]

It would kind of explain the error, as without forRoot, the components would be imported, but not the services, resulting in the ngx-dynamic-hooks-component not finding OutletService.

yeah, that was it, man, thanks so much! And also for the quick response. I was going to wrap up for the day, I figured I may get a response tomorrow lol. Now you kept me working!

Ha, no problems man. Always happy when its not a bug with the library 😄

One more issue im running into. Im not able to use [(ngModel)].  If I have ngModel on the a component that im passing into ngx-dynamic-hooks [content]="content", the component will not render. Is that by design?

Are you using [(ngModel)] directly in the content string? Kind of like so:  let content = "... <input [(ngModel)]="somevariable"> ..."?
Because that unfortunately won't work. ngModel is ultimately a directive and the library does not parse directives, only selectors for loading components (hooks).
It should function however inside a component that was loaded by the library. If the content string is let content = "<app-somecomponent></app-somecomponent>" and in the template of SomeComponent you then use [(ngModel)], it should work again.

ok, that makes sense. So a component that has ngModel within it will work fine, it just wont work if its a part of the component wrapper like this <my-component [(ngModel)]="myVar"></my-component>

Yes, indeed.
Similarly, Angular template syntax like *ngIf, *ngFor, etc. also will not work directly in the content string. This is because the library simply takes that content string, looks for any component you (typically) registered via forRoot() and simply loads them in place of their hook/selector. It does nothing else.
Loading directives dynamically is impossible last I checked and even if not, at that point, you'd be basically mimicing building a Angular template compiler. Not in the scope of this library.
However, in the components the library has loaded, you can then once again use any Angular magic that you want, just like with any other component in your app.


How can I run it locally with nginx

I'm trying to run static server (not uikit.html) locally with nginx, cuz i detect nginx.conf file.

I included local nginx.conf in main config.
I ran build.js.

My directories structures:
projects/
  logux-*
  logux.io

Root nginx config have:
# ...
listen       8080;
server_name  localhost;
# ....
location / {
            root   "C:\projects";
            index  index.html index.htm;
}
# ...

And http://localhost:8080/logux.io/ cannot reachable
Which steps i miss?
I'm on windows 10, but can switch to linux.
Thanks

There is a simple server yarn start:build.
Running with nginx is complicated. This case is for servers. But if you want to try it you should build Docker image by npx ssdeploy build and then run Docker image.
I will improve docs.

I added docs https://github.com/logux/logux.io#development


Add ansible-runtime.json schema for meta/runtime.yml

We need a JSON schema to check validity of meta/runtime.yml files.
References:

https://docs.ansible.com/ansible/devel/dev_guide/developing_collections_structure.html
https://github.com/ansible-community/ansible-lint/issues/1721

I'll try to come with something.

@ziegenberg Did you had time to do anything towards this? Asking as I was considering doing it myself today.

Go ahead!


Improve readability of the README

It's just small stuff but hopefully it'll make it a little more
pleasant to read.

@Geal I fixed the be_i32 thing and removed the semicolons, tell me if there's anything else you'd like me to change 😃

it's alright, thanks!


Add an overview of the contents to Q# standard libraries page

https://docs.microsoft.com/en-us/azure/quantum/user-guide/libraries/, for example, does a great job of offering a quick review of what the sub-pages of it do, allowing for easier navigation. It would be great to add a similar review to this page.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 444f8056-d62d-c359-8c63-cd35798e94ff
Version Independent ID: 0f3bb81a-fc74-7f11-3a53-a0a7770eb341
Content: Introduction to Microsoft Q# standard libraries - Azure Quantum
Content Source: articles/user-guide/libraries/standard/index.md
Service: azure-quantum
Sub-service: qsharp-guide
GitHub Login: @QuantumWriter
Microsoft Alias: martinro

Workitem created at DevOps #1866258


Task 360-362 : "Yes, and" response generation and classification.

These tasks are from Grounding Conversations with Improvised Dialogues .
Please review it.

@kuntalkumarpal, can you review these tasks?

Resolved the capitalization issue for task file names.

@Maitreyapatel
Let's hear from @kuntalkumarpal regarding the reviews and then you can fix.

@Maitreyapatel @swarooprm
Task 362 : Definition
Given the prompt and response pair, classify the them to "yes" if response is "yes, and" type. Otherwise classify it as "no".
The Task needs only one response.

Rest of the tasks look good to me

Hi @kuntalkumarpal ,
I think, there is misunderstanding here. In case of task362, there are two responses as input (i.e., "Response 1" and "Response 2") and model has to detect which one is appropriate.  Also, I think, you are referring to task361. I have modified the definition slightly avoid any ambiguity.
Thanks!

@Maitreyapatel @swarooprm Looks good to me

@Maitreyapatel, these are good tasks. Just make sure that labels are balanced. I saw in task 361 that, most of the answers are yes.
I was wondering if all the next dialogues in a conversation fall in to this category of "yes and .." because in instances of 360, I saw this pattern. The output does not always agree on the input, but continues conversation on that. Let me know what do you think about it?

@swarooprm I rechecked and for task361 labels are well balanced. Here, "yes" class has ~3100 and "no" class has ~3200 instances.
Yes, they do fall in the category of "yes and ...". For example, agreeing with previous dialogue is definitely "yes, and ...", but without stating whether you agree with the previous dialogue also falls into this category as you are not opposing the fact. But if you oppose it by directly saying no or arguing the facts then this falls into opposite category .


Drawer screens and Profile Page

Description
Addition of drawer screens as mentioned in Issue #50
closes #50

Build Status

Hello @nayakastha , That's a great improvement to the code. Have a pinch of paitence while the reviewer gets impressed by the changes you made. Here are some doggos for company while you are waiting for the merge and marching ahead with your Hacktoberfest Contributions, Check your Dashboard for more information on Hacktoberfest. Stay safe 🚀 .

Such an amazing gif

closes #52

@nayakastha Will suggest you to just keep the privacy policy page as an external link/webview.

https://sites.google.com/view/apticheprivacypolicy/home


Error in building the broker using Maven

When I attempt to build the broker using the command line :
mvn clean install
I get this error:
[INFO] --------------------< io.pivotal.cf.broker:broker >---------------------
[INFO] Building broker 2.0.0
[INFO] --------------------------------[ jar ]---------------------------------
[WARNING] The POM for io.pivotal.cf.broker:connector:jar:2.0.0 is missing, no dependency information available
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 1.326 s
[INFO] Finished at: 2018-05-11T11:39:29-05:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal on project broker: Could not resolve dependencies for project io.pivotal.cf.broker:broker:jar:2.0.0: Failure to find io.pivotal.cf.broker:connector:jar:2.0.0 in https://repo.spring.io/libs-milestone was cached in the local repository, resolution will not be reattempted until the update interval of milestone has elapsed or updates are forced -> [Help 1]
Please advise.
Thanks

hi devheroo, did you do this build from the root directory of the project, or from inside the broker directory? try mvn clean install from the mssql-server-broker dir and let me know what you see. Thanks.

have not heard back on this, so am closing for now. let me know if you are continuing to see this issue.


fix: false decryption fix

Fixes #7053

#7066  👈
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @benesjan and the rest of your teammates on  Graphite

It's broken:
Compiling AddressNote for whatever reason results in an note type id which later on fails with parser error:

I tried increasing the note id size to 8 bytes from 4 and it fails and once again for the addressnote type id. And once again it's triggered by that specific note type id value (tried hardcoding it and it fails for all notes). If I tweak the value in any way, then it all compiles.
I also just tried taking the u32 value in the compute_note_type_id func and cast it to u64 with the same result.
For all the other contracts which don't use AddressNote there is no issue present.

Benchmark results
Metrics with a significant change:

batch_insert_into_append_only_tree_32_depth_ms (256): 131 (-63%)
batch_insert_into_append_only_tree_32_depth_hash_ms (256): 0.450 (-63%)
batch_insert_into_indexed_tree_20_depth_ms (256): 182 (-59%)
batch_insert_into_indexed_tree_20_depth_hash_ms (256): 0.481 (-59%)
avm_simulation_time_ms (Token:transfer_public): 39.0 (-33%)
l2_block_processing_time_in_ms (4): 756 (-57%)

Detailed results
All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call  to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.
This benchmark source data is available in JSON format on S3 here.
Proof generation
Each column represents the number of threads used in proof generation.

Metric
1 threads
4 threads
16 threads
32 threads
64 threads

proof_construction_time_sha256_30_ms
11,381
3,067 (-1%)
1,480 (-15%)
1,633 (+11%)
1,461

proof_construction_time_sha256_100_ms
44,665
12,012
5,647
5,566
5,462 (-1%)

proof_construction_time_poseidon_hash_ms
78.0
34.0 (-3%)
34.0
58.0 (+2%)
87.0 (-2%)

proof_construction_time_poseidon_hash_30_ms
1,516
419
202
219 (-4%)
266 (-1%)

proof_construction_time_poseidon_hash_100_ms
5,736
1,564 (-1%)
725
804 (+3%)
793 (-1%)

L2 block published to L1
Each column represents the number of txs on an L2 block published to L1.

Metric
4 txs
8 txs
16 txs

l1_rollup_calldata_size_in_bytes
1,412
1,412
1,412

l1_rollup_calldata_gas
9,464
9,464
9,452

l1_rollup_execution_gas
610,285
610,285
610,273

l2_block_processing_time_in_ms
:warning: 756 (-57%)
1,414
2,702 (-8%)

l2_block_building_time_in_ms
25,738 (-11%)
51,264 (-2%)
101,044 (-13%)

l2_block_rollup_simulation_time_in_ms
25,640 (-11%)
50,962 (-2%)
100,688 (-13%)

l2_block_public_tx_process_time_in_ms
22,033 (-12%)
47,201 (-2%)
96,960 (-12%)

L2 chain processing
Each column represents the number of blocks on the L2 chain where each block has 8 txs.

Metric
3 blocks
5 blocks

node_history_sync_time_in_ms
6,999
9,851 (-1%)

node_database_size_in_bytes
12,161,104
16,072,784

pxe_database_size_in_bytes
16,254
26,813

Circuits stats
Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Function
time_ms
bytecode_size_in_bytes

GasToken:_increase_public_balance
69.0 (+1%)
13,873

GasToken:set_portal
17.1
3,495

Token:constructor
92.9
24,207

FPC:constructor
63.5 (+3%)
13,893

GasToken:mint_public
52.3 (+1%)
10,241

Token:mint_public
64.5 (-16%)
19,216

Token:assert_minter_and_mint
243 (+9%)
13,034

AuthRegistry:set_authorized
32.3 (+1%)
7,869

FPC:prepare_fee
83.3 (-1%)
15,187

Token:transfer_public
:warning: 39.0 (-33%)
31,425

FPC:pay_refund
69.8 (+20%)
20,080

Benchmarking:increment_balance
2,687 (-5%)
15,465

Token:_increase_public_balance
57.1 (-1%)
15,089

FPC:pay_refund_with_shielded_rebate
53.0 (+2%)
21,167

Public DB Access
Time to access various public DBs.

Function
time_ms

get-nullifier-index
0.184 (-1%)

Tree insertion stats
The duration to insert a fixed batch of leaves into each tree type.

Metric
1 leaves
16 leaves
64 leaves
128 leaves
256 leaves
512 leaves
1024 leaves

batch_insert_into_append_only_tree_16_depth_ms
10.3 (-5%)
16.8 (-4%)
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_16_depth_hash_count
16.8
31.7
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_16_depth_hash_ms
0.596 (-5%)
0.515 (-5%)
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_32_depth_ms
N/A
N/A
48.5 (-5%)
76.9 (+2%)
:warning: 131 (-63%)
245
476 (+2%)

batch_insert_into_append_only_tree_32_depth_hash_count
N/A
N/A
95.9
159
287
543
1,055

batch_insert_into_append_only_tree_32_depth_hash_ms
N/A
N/A
0.494 (-5%)
0.472 (+2%)
:warning: 0.450 (-63%)
0.443
0.443 (+2%)

batch_insert_into_indexed_tree_20_depth_ms
N/A
N/A
59.3 (-5%)
111 (-5%)
:warning: 182 (-59%)
352
693 (+1%)

batch_insert_into_indexed_tree_20_depth_hash_count
N/A
N/A
109
207
355
691
1,363

batch_insert_into_indexed_tree_20_depth_hash_ms
N/A
N/A
0.502 (-4%)
0.499 (-5%)
:warning: 0.481 (-59%)
0.476
0.476 (+1%)

batch_insert_into_indexed_tree_40_depth_ms
N/A
N/A
72.6 (-6%)
N/A
N/A
N/A
N/A

batch_insert_into_indexed_tree_40_depth_hash_count
N/A
N/A
133
N/A
N/A
N/A
N/A

batch_insert_into_indexed_tree_40_depth_hash_ms
N/A
N/A
0.517 (-7%)
N/A
N/A
N/A
N/A

Miscellaneous
Transaction sizes based on how many contract classes are registered in the tx.

Metric
0 registered classes
1 registered classes

tx_size_in_bytes
85,672
670,983

Transaction size based on fee payment method
| Metric |  |
| - |  |


Grid with 1 item fails to render

If you only add one string to the grid, it will fail and return None.
Here is the example code:
extern crate term_grid;
use term_grid::{Grid, GridOptions, Direction, Filling};

fn main() {
    let mut grid = Grid::new(GridOptions {
        direction:  Direction::TopToBottom,
        filling:    Filling::Spaces(2),
    });

    for i in 0..1 {
        grid.add(format!("{}", 2_isize.pow(i)).into())
    }

    if let Some(grid_display) = grid.fit_into_width(40) {
        println!("{}", grid_display);
    }
    else {
        println!("Couldn't fit grid into 40 columns!");
    }
}

Well this definitely looks like a bug. Thanks for the report! I'll work on a fix.

Fixed in 49344de0ddfbc51e93827d2848d979821ca904f8


Has HTTPS been removed?

I am trying to use this to host a server however I need to use HTTPS and it seems that this is no longer possible in the latest version so I have had to downgrade. Is this the case and if not is there any documentation on how to use it?

👋
We decided to drop HTTPS support from the core of the package, since there are just too many variants to support and getting it proper is difficult.
Aside of that, your serve instance should at least have some form of load balancer or proxy on top, otherwise what will happen if serve crashes/goes down?
However, as you can see here adding the new middleware to a HTTPS server only takes one line:
await handler(request, response);

In turn, I suggest either putting your app behind an LB/proxy or create a .js file for the server.

In turn, I suggest either putting your app behind an LB/proxy or create a .js file for the server.

But how about local development use-cases. I use serve to simply host some static files locally. Also, it is preferred to do this via https, because of various reasons, very well described in this thread by Kyle Simpson.
Currently I have to stick with serve@6, but it doesn't seem future-proof. Does anyone know another package, that has necessary features and is easy to use as serve?

I would enjoy https for local/dev like @just-boris, too 🙏


after enabling istio  In a namespace evoy is not running with Readiness probe failed: HTTP probe failed with statuscode: 503

In the event of pod
Normal   Created    11m                   kubelet, k8s-worker-0  Created container istio-proxy
Normal   Started    11m                   kubelet, k8s-worker-0  Started container istio-proxy
Warning  Unhealthy  106s (x298 over 11m)  kubelet, k8s-worker-0  Readiness probe failed: HTTP probe failed with statuscode: 503
[root@k8s-master-0 ~]#
Proxy logs say
ful, 0 rejected
[Envoy (Epoch 0)] [2020-04-29 14:43:53.534][19][warning][config] [bazel-out/k8-opt/bin/external/envoy/source/common/config/_virtual_includes/grpc_stream_lib/common/config/grpc_stream.h:91] gRPC config stream closed: 14, upstream connect error or disconnect/reset before headers. reset reason: connection failure
2020-04-29T14:43:54.323650Z	info	Envoy proxy is NOT ready: config not received from Pilot (is Pilot running?): cds updates: 0 successful, 0 rejected; lds updates: 0 successful, 0 rejected

Please fill out the full issue template, especially information on your environment and istio version/install steps. Generally this error means trouble connecting to pilot

I think u r correct
[root@k8s-master-0 ~]# kubectl get po -A -o wide | grep pilot
mvnr-paas          istio-pilot-845c7cd8b5-lr9tw                          1/2     Running            1          6d20h   <IP_ADDRESS>   k8s-worker-0
[root@k8s-master-0 ~]#
Events:
Type     Reason     Age                       From                   Message

Warning  Unhealthy  4m15s (x56581 over 3d6h)  kubelet, k8s-worker-0  Readiness probe failed: Get http://<IP_ADDRESS>:8080/ready: dial tcp <IP_ADDRESS>:8080: connect: connection refused

Closing as we do not have the required info to debug this further


cnf ran: add ZTP verify BIOS settings test case

ZTP BIOS test added: Compare requested BIOS settings to current BIOS settings

/lgtm


Filtered Event Streams

Allows EventStream[T] to be conditionally selected at dispatch time. This allows better listening capabilities per event type.

Added NewFilteredEventStream(condition EventCondition[T]) EventStream[T] to dispatcher.
Added AddFilteredEventHandler(handler EventHandler[T], condition EventCondition[T]) HandlerID to dispatcher

Made race fixes for some of the unit tests

@nikovacevic Is this PR targeting v1.94? If so, can I add the label?


Fixes a warning

Fixes a .characters warning.

@gmosx Well, I can see you are registered on cla-assistant even though the check on PR doesn't seem to have updated properly (even though I tried to get it to be.) So merging.

Thanks for the fix, sorry it took so long to merge!

Thanks.

@tunniclm are you going to tag 2.0.1?


WebSphere Portal to React modernization

Many customers are migrating from proprietary extensions to J2EE portlets in traditional ecommerce systems built on WebSphere portal. Have any of these types of apps been migrated to newer UX frameworks like React. Any samples in CodeNet?

It is unlikely CodeNet will have samples, because CodeNet programs are
mostly restricted to system standard libraries.
-Julian
On Sun, Mar 5, 2023 at 3:29 PM sridhariyengar @.***>
wrote:

Many customers are migrating from proprietary extensions to J2EE portlets
in traditional ecommerce systems built on WebSphere portal. Have any of
these types of apps been migrated to newer UX frameworks like React. Any
samples in CodeNet?
—
Reply to this email directly, view it on GitHub
https://github.com/IBM/Project_CodeNet/issues/55, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAMTO7Q4PV6U4S6OKSWLDI3W2TZUJANCNFSM6AAAAAAVQLYLSI
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>


Prime (') symbol in atom name

I'm trying to represent this PDB file:
HETATM 4635  C3' BPG A   1      49.533  82.766  53.536  1.00 17.33           C
HETATM 4636  O3' BPG A   1      50.688  81.981  53.415  1.00 21.50           O
HETATM 4637  C2' BPG A   1      50.128  84.079  53.994  1.00 15.61           C
HETATM 4638  C12 BPG A   1      49.009  84.977  54.509  1.00 16.58           C
HETATM 4639  C1' BPG A   1      48.333  84.409  55.780  1.00 16.82           C
HETATM 4640  N9  BPG A   1      47.200  85.204  56.278  1.00 16.03           N
HETATM 4641  C4  BPG A   1      45.903  85.363  55.703  1.00 14.66           C
HETATM 4642  N3  BPG A   1      45.462  84.786  54.595  1.00 12.56           N
HETATM 4643  C2  BPG A   1      44.169  85.040  54.341  1.00 13.59           C
HETATM 4644  N2  BPG A   1      43.617  84.472  53.228  1.00 16.32           N
HETATM 4645  N1  BPG A   1      43.370  85.890  55.069  1.00 14.33           N
HETATM 4646  C6  BPG A   1      43.808  86.524  56.224  1.00 14.72           C
HETATM 4647  O6  BPG A   1      43.050  87.250  56.844  1.00 12.55           O
HETATM 4648  C5  BPG A   1      45.192  86.201  56.521  1.00 14.85           C
HETATM 4649  N7  BPG A   1      46.001  86.604  57.584  1.00 17.67           N
HETATM 4650  C8  BPG A   1      47.132  85.979  57.381  1.00 16.81           C
HETATM 4651  C04 BPG A   1      45.389  81.838  50.488  1.00 15.62           C
HETATM 4652  C05 BPG A   1      45.899  81.921  51.803  1.00 13.08           C
HETATM 4653  C06 BPG A   1      45.324  82.795  52.708  1.00 13.65           C
HETATM 4654  C01 BPG A   1      44.236  83.572  52.332  1.00 15.32           C
HETATM 4655  C02 BPG A   1      43.718  83.481  51.018  1.00 15.30           C
HETATM 4656  C03 BPG A   1      44.283  82.607  50.108  1.00 13.21           C
Due to the prime symbols in the first, second, third and fifth rows, the representations is the following:

If I add backslashes to the prime symbols, then the representation is correct, but I think that's not the best practice.
Is there any parameter in NGL that warns that the file must be parsed considering the prime symbols?
Thanks.

the group was wrongly detected as a coarse grained DNA residue, fixed it by adding better cg detection (check atom count to avoid false positives, see 71f072f060e9ef4a7a2cfd7159bf220ff02424b4)

Hi Alexander, it works.
Just a thing: After changing from 0.10.5-13 to 0.10.5-19 I've detected that there is a small delay charging PDB files, and if I start an animation automatically after loading the file (it doesn't matter if it's a setSpin or a representation as a trajectory), the file is not shown until I pass the mouse over the viewport. I've fixed that putting the call to animation inside a setTimeOut of 1 second. Should I report that as a new bug?
Thanks one more time.

Should I report that as a new bug?

I felt the delay too. #369

Should I report that as a new bug?

yes please


Yes, I downloaded the newest version on spigot today.
Description of the bug
Some heads are using default player texture
Have you been able to reproduce the bug more than once?
Every time when starting the server
Has a debug report been generated?
/headsplus debug dump did not work (I tried both client and server console)
Required information

Server version: 1.16.1
HeadsPlus version: v6.10.11
Whether or not the plugin uses MySQL: no
Server type (e.g Spigot, Paper): PaperMC (build 108)
Uses Vault: yes
I'm using only the heads that come with default config (no custom heads)

Additional information
latest log: https://hastebin.com/efozeretas.sql

Can you send your mobs.yml and customheads.yml files?

Mobs.yml: https://hastebin.com/ipuhajurin.cs
Customheads.yml: https://hastebin.com/sibiwunaje.coffeescript

For whatever reason, your customheads.yml file didn't update correctly; try resetting the file and reloading the plugin from there. I thought I fixed this bug a while ago and I don't get why it disappeared. If you updated to a version before this that didn't contain the fix though, that may be why.
As for the dump command, I believe that is a permission issue. I will attempt to introduce a workaround for it in the following update.

I deleted both files and after restarting everything works fine. Maybe it's my fault, because I didn't update in a while and skipped some versions. Thanks for your help!
Dump still doesn't work though. Should I close this thread?

It's all good, and I should be able to handle the dump command (and others) in my own time. My current perception is that it's just a permissions problem which I can resolve easily myself.

Okay, again, thanks for your help!


… is not properly handled

The ampersand in … is re-encoded, which doesn't seem to happen for other html encoded characters, for example the output of:

LinkifyHtml("
Here is a link and an extra space: google.com

Here is a link and a greater-than: google.com >

Here is a link and an ellipsis: google.com …
");

is:

Here is a link and an extra space: google.com  Here is a link and a greater-than: google.com >Here is a link and an ellipsis: google.com …

This means that while everything else I render as html looks right, an ellipsis ends up looking like …
I'd love to know if I'm doing something wrong here.
Thanks!

Coming back to this, I have found that this happens for almost all encoded symbols. I will write some workaround function to take care of this in the meantime unless anyone can tell me what I'm doing wrong. As far as I can tell, the only encoded symbols that work are the five in @nfrasser/simple-html-tokenizer/src/generated/html5-named-char-refs.ts, though I haven't taken the time to determine whether that is what is making them work...

Hi @gravelfox, thanks for reporting. This should be fixed in the latest v4.1.3

Rad, thank you! I am not proud of how hacky my workaround was and will be very happy to back it out!


Create a method for intercepting contexts

We sometimes want to have one theme for half the page, and another for the other half. How can users intercept the theme context provider to substitute another value?

This is particularly difficult because the way we communicate theme contexts is using the method proposed in the protocol suggested by @benjamind . This uses a callback to pass the context, which can't be intercepted in the same way an event might.

Not sure what you mean. Context protocol is explicitly event based and supports use cases like having multiple separate DOM trees serviced by different context providers.

@benjamind I thought about this some more after you left this comment, and I think I understand what you're saying.
We were discussing a component one of our designers made that has two halves of a screen -- the top, which is the light or dark theme, depending on a user selection, and the bottom, which is the other theme. If I understand correctly, to implement this, my components in both sections will fire the event requesting the theme context, but the inverse section will have its propagation stopped by "theme inverter" component, which listeners for events from the root contents, and emits the theme values for the inverse theme in place of the regular theme values?
I was thinking of trying to interrupt the values as they are passed along the callback chain instead, which I think is where I went awry. I was thinking we'd have to call a chain of callbacks so an intermediate could change the theme value after we've initiated a theme change, but that's far too late -- I need to have already set up the context providers correctly by then.


Request to Add Product in Start Flutter

Hello,
I am Maheshwari from team GeekyAnts. On behalf of Start Flutter, we add open source products which we find helpful to the community & also we provide credits to author itself.
Let me know if you are interested showcase your product in our open source website.
If yes, then I request you to add MIT Licence in your repo.
Looking forward to hear from you

Sure you can go ahead..


Cubed vs dask.array: Convergent evolution?

For a while I've been thinking that Cubed and dask.array are potentially on a path of convergent evolution to a very similar design. After talking to @phofl at length at the NumFOCUS summit, I feel more confident in this - some explicit similarities below.
Dask is becoming more similar to Cubed:

Dask Expressions for arrays are basically a cubed.Plan. They are both intended to allow high-level optimizations (at the ~array-API level) before anything is materialized, and avoid materialization of each step until execution. The latter is meant to solve the scaling problem of a scheduler dealing with very large numbers of chunks (because the graph size then scales with number of arrays but not with number of chunks). There is lots of recent work on expressions for dask dataframes but expressions for dask.array haven't been implemented yet.
Dask P2P rechunking was introduced to deal with the pathological all-to-all rechunk case, and I understand is now the default. This is in response to the same complaints of unbounded unpredictable memory usage that motivated cubed. Both P2P and the Rechunker algorithm are similar in that they spill to disk in order to limit RAM usage. (@phofl tells me that many of these complaints about dask were in fact caused by scheduling bugs rather than design issues though.)
Task annotations (or some similar feature) in dask that track memory usage have been suggested before, but would be effectively replicating what the cubed.Spec allows you to track by design. (Interestingly @phofl said that tracking memory usage per-task is mostly useful for arrays rather than for dataframes, because dataframe partitions aren't of known length in general, and weird datatypes in dataframes make it hard to estimate memory usage.) Again this is not yet implemented in dask AFAIK.

Cubed could become more similar to Dask:

We want to run cubed efficiently on HPC (#467) and single-machine (#492), like dask can. Cubed can currently run on single-machine and there is recent work to make it run on HPC via Dragon (https://github.com/cubed-dev/cubed/pull/555).
Outside of a Cloud serverless context, cubed's task-based rechunk-via-disk algorithm is very often inefficient. Optimising rechunks by not using the disk becomes possible on HPC/single-machine. Doing this in-memory (https://github.com/cubed-dev/cubed/issues/502) is more similar to how dask will if using threads and a LocalCluster (I believe). This hasn't been tried yet.
On a cluster you could also use communication instead of writing to disk to perform the rechunk - if Cubed used Dragon's distributed dict to do its zarr rechunk without writing to disk that would effectively be a rechunk via communication (with Dragon being the communication layer), and be more similar to dask. Generally every time cubed avoids using the worst-case on-disk rechunker algorithm, it would be an optimization that makes it behave more similarly to dask. This distributed dict idea also hasn't been tried yet.

Cubed-on-dask

If you took a Cubed plan and taught Cubed's Dask executor that you actually wanted to use dask's P2P rechunking algorithm to execute the rechunk steps, then cubed-on-dask would become rather similar to dask-on-dask...

Remaining differences:

Project scope: cubed is just arrays vs dask is arbitrary DAGs.
Level of technical debt / maturity - dask has more techical debt but is also much more mature.
Flexibility of executors - because cubed breaks everything down into embarrassingly parallel map/rechunk steps, you can imagine writing a cubed executor to run on almost anything (it just might be inefficient). Whilst it's possible (e.g. dask on ray, I don't think it's so simple to make dask run arbitrary graphs on a new executor.
P2P rechunking doesn't allow specifying memory usage, it just means it will be constant (correct me if that's wrong).
Dask has no way to deploy truly serverlessly like cubed can because it assumes you have the ability to communicate between workers / with the workers.
Environments / containers / propagating dependencies to workers is handled quite differently.

I don't know if there is an action item here but I wanted to raise it for discussion.

Thanks @TomNicholas, this is very interesting!


[SPARK-38787] [SS] Replace found value with non-null element in the remaining list for key and remove remaining null elements from values in keyWithIndexToValue store for stream-stream joins

What changes were proposed in this pull request?

In stream-stream joins, for removing old state (watermark by value), we call the removeByValue function with a removal condition. Within the iterator returned, if we find null at the end for matched value at non-last index, we are currently not removing and swapping the matched value. With this change, we will find the first non-null value from end and swap current index with that value and remove all elements from index + 1 to the end and then drop the last element as before.
Why are the changes needed?

This change fixes a bug where we were not replacing found/matching values for removeByValue when encountering nulls in the symmetric hash join code.
Does this PR introduce any user-facing change?

No
How was this patch tested?

Added a unit test for this change with nulls added. Here is a sample output:
Executing tests from //sql/core:org.apache.spark.sql.execution.streaming.state.SymmetricHashJoinStateManagerSuite-hive-2.3__hadoop-3.2
-----------------------------------------------------------------------------
2022-04-01 21:11:59,641 INFO  CodeGenerator - Code generated in 225.884757 ms
2022-04-01 21:11:59,662 INFO  CodeGenerator - Code generated in 10.870786 ms
Run starting. Expected test count is: 4
…
===== TEST OUTPUT FOR o.a.s.sql.execution.streaming.state.SymmetricHashJoinStateManagerSuite: 'StreamingJoinStateManager V2 - all operations with nulls' =====

2022-04-01 21:12:03,487 INFO  StateStore - State Store maintenance task started
2022-04-01 21:12:03,508 INFO  CheckpointFileManager - Writing atomically to /tmp/spark-d94b9f11-e04c-4871-aeea-1d0b5c62e292/0/0/left-keyToNumValues/_metadata/schema using temp file /tmp/spark-d94b9f11-e04c-4871-aeea-1d0b5c62e292/0/0/left-keyToNumValues/_metadata/.schema.9bcc39c9-721e-4ee0-b369-fb4f516c4fd6.tmp
2022-04-01 21:12:03,524 INFO  CheckpointFileManager - Renamed temp file /tmp/spark-d94b9f11-e04c-4871-aeea-1d0b5c62e292/0/0/left-keyToNumValues/_metadata/.schema.9bcc39c9-721e-4ee0-b369-fb4f516c4fd6.tmp to /tmp/spark-d94b9f11-e04c-4871-aeea-1d0b5c62e292/0/0/left-keyToNumValues/_metadata/schema
2022-04-01 21:12:03,525 INFO  StateStore - Retrieved reference to StateStoreCoordinator: org.apache.spark.sql.execution.streaming.state.StateStoreCoordinatorRef@374ccb9
2022-04-01 21:12:03,525 INFO  StateStore - Reported that the loaded instance StateStoreProviderId(StateStoreId(/tmp/spark-d94b9f11-e04c-4871-aeea-1d0b5c62e292,0,0,left-keyToNumValues),47925997-9891-4025-a36a-3e18bc758b50) is active
2022-04-01 21:12:03,525 INFO  HDFSBackedStateStoreProvider - Retrieved version 0 of HDFSStateStoreProvider[id = (op=0,part=0),dir = /tmp/spark-d94b9f11-e04c-4871-aeea-1d0b5c62e292/0/0/left-keyToNumValues] for update
2022-04-01 21:12:03,525 INFO  SymmetricHashJoinStateManager$KeyToNumValuesStore - Loaded store StateStoreId(/tmp/spark-d94b9f11-e04c-4871-aeea-1d0b5c62e292,0,0,left-keyToNumValues)
2022-04-01 21:12:03,541 INFO  CheckpointFileManager - Writing atomically to /tmp/spark-d94b9f11-e04c-4871-aeea-1d0b5c62e292/0/0/left-keyWithIndexToValue/_metadata/schema using temp file /tmp/spark-d94b9f11-e04c-4871-aeea-1d0b5c62e292/0/0/left-keyWithIndexToValue/_metadata/.schema.fcde2229-a4fa-409b-b3eb-751572f06c08.tmp
2022-04-01 21:12:03,556 INFO  CheckpointFileManager - Renamed temp file /tmp/spark-d94b9f11-e04c-4871-aeea-1d0b5c62e292/0/0/left-keyWithIndexToValue/_metadata/.schema.fcde2229-a4fa-409b-b3eb-751572f06c08.tmp to /tmp/spark-d94b9f11-e04c-4871-aeea-1d0b5c62e292/0/0/left-keyWithIndexToValue/_metadata/schema
2022-04-01 21:12:03,558 INFO  StateStore - Retrieved reference to StateStoreCoordinator: org.apache.spark.sql.execution.streaming.state.StateStoreCoordinatorRef@1ea930eb
2022-04-01 21:12:03,559 INFO  StateStore - Reported that the loaded instance StateStoreProviderId(StateStoreId(/tmp/spark-d94b9f11-e04c-4871-aeea-1d0b5c62e292,0,0,left-keyWithIndexToValue),47925997-9891-4025-a36a-3e18bc758b50) is active
2022-04-01 21:12:03,559 INFO  HDFSBackedStateStoreProvider - Retrieved version 0 of HDFSStateStoreProvider[id = (op=0,part=0),dir = /tmp/spark-d94b9f11-e04c-4871-aeea-1d0b5c62e292/0/0/left-keyWithIndexToValue] for update
2022-04-01 21:12:03,559 INFO  SymmetricHashJoinStateManager$KeyWithIndexToValueStore - Loaded store StateStoreId(/tmp/spark-d94b9f11-e04c-4871-aeea-1d0b5c62e292,0,0,left-keyWithIndexToValue)
2022-04-01 21:12:03,564 INFO  CheckpointFileManager - Writing atomically to /tmp/spark-d94b9f11-e04c-4871-aeea-1d0b5c62e292/0/0/left-keyWithIndexToValue/1.delta using temp file /tmp/spark-d94b9f11-e04c-4871-aeea-1d0b5c62e292/0/0/left-keyWithIndexToValue/.1.delta.86db3ac9-aa68-4a6b-9729-df93dc4b8a45.tmp
2022-04-01 21:12:03,568 INFO  CheckpointFileManager - Writing atomically to /tmp/spark-d94b9f11-e04c-4871-aeea-1d0b5c62e292/0/0/left-keyToNumValues/1.delta using temp file /tmp/spark-d94b9f11-e04c-4871-aeea-1d0b5c62e292/0/0/left-keyToNumValues/.1.delta.9673bc1b-2bbe-412d-a0af-69f237cde31e.tmp
2022-04-01 21:12:03,572 WARN  SymmetricHashJoinStateManager - `keyWithIndexToValue` returns a null value for index 4 at current key [false,40,10.0].
2022-04-01 21:12:03,574 WARN  SymmetricHashJoinStateManager - `keyWithIndexToValue` returns a null value for index 3 at current key [false,40,10.0].
2022-04-01 21:12:03,576 WARN  SymmetricHashJoinStateManager - `keyWithIndexToValue` returns a null value for index 3 at current key [false,60,10.0].
2022-04-01 21:12:03,576 WARN  SymmetricHashJoinStateManager - `keyWithIndexToValue` returns a null value for index 1 at current key [false,40,10.0].
2022-04-01 21:12:03,577 INFO  SymmetricHashJoinStateManager$KeyToNumValuesStore - Aborted store StateStoreId(/tmp/spark-d94b9f11-e04c-4871-aeea-1d0b5c62e292,0,0,left-keyToNumValues)
2022-04-01 21:12:03,577 INFO  HDFSBackedStateStoreProvider - Aborted version 1 for HDFSStateStore[id=(op=0,part=0),dir=/tmp/spark-d94b9f11-e04c-4871-aeea-1d0b5c62e292/0/0/left-keyToNumValues]
2022-04-01 21:12:03,577 INFO  SymmetricHashJoinStateManager$KeyWithIndexToValueStore - Aborted store StateStoreId(/tmp/spark-d94b9f11-e04c-4871-aeea-1d0b5c62e292,0,0,left-keyWithIndexToValue)
2022-04-01 21:12:03,577 INFO  HDFSBackedStateStoreProvider - Aborted version 1 for HDFSStateStore[id=(op=0,part=0),dir=/tmp/spark-d94b9f11-e04c-4871-aeea-1d0b5c62e292/0/0/left-keyWithIndexToValue]
2022-04-01 21:12:03,580 INFO  StateStore - StateStore stopped
2022-04-01 21:12:03,580 INFO  SymmetricHashJoinStateManagerSuite -

===== FINISHED o.a.s.sql.execution.streaming.state.SymmetricHashJoinStateManagerSuite: 'StreamingJoinStateManager V2 - all operations with nulls' =====
…
2022-04-01 21:12:04,205 INFO  StateStore - StateStore stopped
Run completed in 5 seconds, 908 milliseconds.
Total number of tests run: 4
Suites: completed 1, aborted 0
Tests: succeeded 4, failed 0, canceled 0, ignored 0, pending 0
All tests passed.
2022-04-01 21:12:04,605 INFO  ShutdownHookManager - Shutdown hook called
2022-04-01 21:12:04,605 INFO  ShutdownHookManager - Deleting directory /tmp/spark-37347802-bee5-4e7f-bffe-acb13eda1c5c
2022-04-01 21:12:04,608 INFO  ShutdownHookManager - Deleting directory /tmp/spark-9e79a2e1-cec7-4fbf-804a-92e63913f516

@HeartSaVioR - Could you please review ? Thx

Probably clarify in the PR comment that this relates to stream-stream joins.

Done - Updated the PR title as well as description noting that the change relates to stream-stream joins

Can one of the admins verify this patch?

GA was green in e7331c1 and the new change e9eec52 only touches the code comment.
Thanks! Merging to master/3.3/3.2.

cc. @MaxGekk This got into Spark 3.3, since it's a part of correctness bug fix. Sorry I missed to mention the release manager.


fix: typo + missing var for cni_helper + Affinity issue with cni_helper

I had an issue with some things (missing var and missing "=" because I hate typos.
Also had a weird issue with the node affinity var not working, as is I had the following error:
clusterrolebinding.rbac.authorization.k8s.io/cni-metrics-helper created
error: error validating "STDIN": error validating data: ValidationError(Deployment.spec.template.spec.containers[0]): unknown field "nodeAffinity" in io.k8s.api.core.v1.Container; if you choose to ignore these errors, turn validation off with --validate=false
[terragrunt] 2019/02/22 16:23:07 Error running hook cni_metrics_helper with message: exit status 1
[terragrunt] 2019/02/22 16:23:07 Hit multiple errors:
Hit multiple errors:
exit status 1

Moving the ${var.cni_metrics_helper["use_kiam"] ? indent(6, var.cni_metrics_helper["deployment_scheduling_kiam"]) : indent(6, var.cni_metrics_helper["deployment_scheduling"] ) } line before container spec seems to resolve the issue.

Thanks @RiceBowlJr it was already fix, check the latest release


Implement Batch Renormalization in TF

See paper: https://arxiv.org/pdf/1702.03275.pdf
Keras implementation: https://github.com/ajbrock/Neural-Photo-Editor/blob/master/layers.py#L35

Looks like it has been implemented in tensorpack: https://github.com/ppwwyyxx/tensorpack/blob/3f238a015b941041e58ed43e63d5306dbae979fc/tensorpack/models/batch_norm.py#L208

how can we set the values of rmax and dmax?

@cancan101 @hengck23 Here is my implementation. I also provide my code for set the RMAX and DMAX.
Basic usage:
`batch_renorm_decay=0.9
batch_renorm_epsilon=0.001
global_step = tf.train.get_global_step()
RMAX_decay = ops.adjust_max(global_step, 200, 800, 1, 3, name='RMAXDECAY')
DMAX_decay = ops.adjust_max(global_step, 200, 600, 1, 5, name='DMAXDECAY')
batch_renorm_params = {
'renorm': True,
'RMAX': RMAX_decay,
'DMAX': DMAX_decay,
'decay': batch_renorm_decay,
'epsilon': batch_renorm_epsilon,
}
with slim.arg_scope([slim.conv2d, slim.fully_connected], activation_fn=tf.nn.relu,
normalizer_fn=ops.fused_batch_norm,
normalizer_params=batch_renorm_params) as scope:
`
BTW, my implementation is fully compatible with TF's batch_norm.

I have submitted a quick PR with the renorm parameter

Looks like this got added in https://github.com/tensorflow/tensorflow/pull/9059/commits/55c809b62d688637813c828301e528cb2fbcc54b.

But no support for fused batch norm :(

This issue solved. Any future discussion re: fused batch re-norm can be found at: https://github.com/tensorflow/tensorflow/issues/9141.


Small fixes

Fix eat_with_lead achievement referencing old effect registry name (stunned -> stunning)
Fix glance_brick_stairs recipe using an invalid pattern key
Added more lead tags to the lead source tag
Simplified check for lead in inventory to apply debuffs for lead in inventory
Run data gen

Your work is very much appreciated


Make generated apks contain version name and code

Its cool to know which version contains the apk easy.

Don't you have to use $ to reference the version name and codes?

Current coverage is 81.14%

Merging #165 into master will not affect coverage as of 55f7bc7

@@            master    #165   diff @@
======================================
  Files           38      38
  Stmts          557     557
  Branches        47      47
  Methods          0       0
======================================
  Hit            452     452
  Partial         29      29
  Missed          76      76

Review entire Coverage Diff as of 55f7bc7

Powered by Codecov. Updated on successful CI builds.

👍

👍

👍 (checked locally)

Guys why codecov failed?

@danielgomezrico It might just be an issue with codecov. The check on my PR is failing too.

It fine, diffing code coverage between branches is not trivial.

@danielgomezrico thanks!


feature/#485 changes read me

Also updated wiki

Coverage decreased (-0.008%) to 51.064% when pulling f68ca8c33ef2c2d9f144d05e502c4eed9f4a4667 on featur/#485-update-readme into dbc4a1a26ddb16a0b4f79f7261e23938943b254a on develop.


Migrate from SDL2 to GLFW.

As per #104 and #106 , SDL2 is breaking in multiple places that are completely unexpected, at least on windows.
It appears modern GLFW may work better for our needs.
This means replacing things such as sdl_image with libpng, but I don't personally mind that as one of the main developers working on the graphics pipelines. It also has better support for Vulkan OOTB, it seems, unlike SDL2.
I am very much for this, given the duct tape in #98 to get around one of these issues.

One area of concern is Mobile development, primarily iOS. Seeing as that we don't have anyone truly experienced in iOS development ATM, we may need to research this for alternatives - however due to the recent Apple ecosystem changes, I think we are safe to say this shouldn't be a blocker for us.
As far as Android is comcerned, @RubyNova mentioned having a plan for NDK/native support.

For what its worth, even if we don't decide to use GLFW, SDL2 is clearly giving us build problems amongst other issues. I'm pretty concerned we'll just end up fighting the library more and more as time goes on.

Just a quick update on this ticket - after talking with @tannergooding on discord, the previously mentioned wontfix issue with the window resizing has actually now been resolved. This was a mistake on my part for, I guess, failing to google the right things as I was only ever shown the event we were using originally. My bad.

Something I noticed with SDL2 is that what subsystems it uses depends on what was available on box when you compiled and that it will compile even if no "base" exists.
So, for example, if you compile SDL2 and libx11-dev is installed, it will use X11 when creating the Window and won't work with wayland or xcb. This can lead to surprise failures at runtime as it won't be able to find a valid video or audio device.
We should check the behavior of glfw and see if it is any better here. It would be nice if there was some dynamic binding support (like you would get in C#) where it can try a range of backends and pick whichever works.