Running empty query throwing HTTP500 on web

Steps to Repro

open ask.astronomer.io
Do not provider any question and hit enter

https://astronomer.slack.com/archives/C05QJA9LTR9/p1699264170253819?thread_ts=1699264162.183799&cid=C05QJA9LTR9

@vatsrahul1001 can you test this please in dev and confirm?

Tested working fine now


Make it super easy to add new pages, more improvements inside

New Changes!

It is now a single page site
Load page contents under the navbar from a content-pages folder with jquery
Add a hashtag to the URL corresponding to the content page loaded from the content-pages
folder.
Add an event-registration page
Center the footer
Fulfill #1
Somewhat redesign the entire website
Get rid of redundant HTML and load it with jquery from a templates folder
Merge the about and home page
remove unnecessary <br />
fade the page contents in when clicking on buttons

Live demo: https://powerlated.net/gmvcsc.github.io
Also, are we supposed to have write access to the repo?

@Powerlated, we appreciate your help but please stop working on this repository until I verify who you are. Thanks.

@Powerlated, what you did looks good but I need to have control of the changes that we are making to the page. Wait for me to assign you an issue. Thanks.


[🐜] Cancel pledge success bug

📲 What
The user should see a snackbar when they've successfully canceled a pledge.
🤔 Why
So they know it was successfully canceled!
🛠 How

Renamed hideRewardsFragmentClicked to hideRewardsSheetClicked.
Alphabetized private methods in ProjectActivity
In ProjectActivity.showCancelPledgeSuccess, we show the snackbar after the animDuration delay.
I also found a bug where if you hit the back button immediately after clicking Cancel my pledge, the scrim didn't hide.

👀 See
(I'm faking the call so the pledge is not actually canceled)

After 🦋

📋 QA

Enable the Native Checkout feature flag in the Internal Tools.
Navigate to a live project you've backed. (The simplest way is to open your profile or just back a new project.
Click the Manage button.
Click the Manage your pledge button of your currently pledged reward.
Click the Cancel pledge button.
Click the Yes, cancel my pledge

Note: Right now the server cannot successfully cancel a pledge that was created on staging so the error message pops up.
Story 📖
Trello Story

 User Can Cancel Pledge


Fix Concurrent access prevented in SkyDB error after test shutdown

PULL REQUEST
Overview
It looks like when a test is unexpectedly quit, any open locks for SkyDB V2
entries stay open.
I figured we could avoid this by using random keys per test, instead of a single
pair of keys for all tests.
It's not clear yet whether this is a problem in production as the community has
not reported it. But this PR will make CI test output easier to read and debug.
Checklist

[x] All git commits are signed. (REQUIRED)
[x] All new methods or updated methods have clear docstrings.
[x] Testing added or updated for new methods.
[x] Verified if any changes impact the WebPortal Health Checks.
[x] Appropriate documentation updated.
[x] Changelog file created.

Issues Closed

I figured we could avoid this by using random keys per test, instead of a single
pair of keys for all tests.

By consolidating the tests we also avoid subsequent tests failing if an earlier one fails. Example:
https://github.com/SkynetLabs/nodejs-skynet/runs/6934459689?check_suite_focus=true


Update README.md

make more explicit for people like me. feel free to reject if this is too silly.

Thanks!


crystal : new package at 0.31.1

Description of package
This binary version of Crystal Language compiler and it utilities, i had no idea to build since this packages is self-hosted in it language. need crystal to build crystal :)
Checklist

[x] Latest upstream version.
[x] I agree to maintain this package (required).
[x] I agree to notify KISS if I can no longer maintain this package (required).

The problem of crystal here is not that far off from the rust problem. However, we can't just trust binaries outright. So a bootstrap will be needed if crystal isn't already installed.
I suggest you to take a look at how Void or Alpine (since they're, in a sense, the closest ones to KISS) Linux builds crystal.


Should be add changelog/history???

Should be add changelog/history???

Will be added in future releases. For now version history can be view at https://github.com/xamfoo/reactive-obj/releases


Error while extracting pak files from Valorant after Patch 2.11

So... I've tried using every UE4 version from 4.22 to 4.27. All I get is this error.
Memory: bad allocation size -2037681352 bytes
appMalloc: size=-2037681352 (total=34 Mbytes) <- FArray::Empty: -885634662 x 12 <- FPackageFileSummary::Serialize4 <- FPackageFileSummary<<: Ver=0/0 <- UnPackage::UnPackage: /Engine/Animation/AresAnimBoneCompressionSettings.uasset, ver=517/0, game=ue4.22 <- UnPackage::LoadPackage(info): /Engine/Animation/AresAnimBoneCompressionSettings.uasset <- ScanContent <- UIMenuItem::HandleCommand <- UIMenu::Popup <- UIBaseDialog::WndProc <- UIBaseDialog::CustomMessageLoop <- UIBaseDialog::ShowDialog: modal=1, title="Choose a package to open" <- CUmodelApp::ShowPackageUI <- Main: umodel_build=1556
I'm new to this stuff tho.

VALORANT is currently on 4.25 and UModel needs some small modification since 2.02 to work (https://github.com/gildor2/UEViewer/pull/206)
You can either build the linked fork yourself or use spiritovod's build: https://www.gildor.org/smf/index.php/topic,7040.msg39129.html#msg39129


Enhance unbind and deprovision test cases

Signed-off-by: leonwanghui<EMAIL_ADDRESS>This patch is first part of #66 , focusing on unbind and deprovision scenario.

@norshtein @mattmcneeney One more please

@zhongyi-zhang @norshtein Please take a look at this patch, thanks!

LGTM


Create new test

Thank you for your pull request.
It doesn't contain a test as described, just a single empty line.
If you can add the content you meant to include and resubmit your pull request I can take another look. If I can assist you with this in any way just let me know.


[WIP] Handle invalid type gracefully

@nonninz I need to your advice to handle this case. I have two solutions :

put the body of wrap_with_size in a rescue block and handle any invalid input
change data_to_bin to return an ok tuple/error.

I came to this part of the code since we have a case in production. It was in the integration phase. So it was not the case that an OEM change the value but still good to handle this scenario

@slashmili interesting problem. I have some ideas, but it depends what do we want the call to *State.to_bin/1 result in this case? Do we want to skip the property, raise...

@slashmili interesting problem. I have some ideas, but it depends what do we want the call to *State.to_bin/1 result in this case? Do we want to skip the property, raise...

If we emit error/warning and skip the property is good enough for me.
If we want to go extra mile, we can put failure message into that property. I don't like the idea since it's unexpected that the convertor inject data to the requested data.
Hopefully we can prevent this when we run State.put_value by checkin the unit type. but that I suppose that require more work and changes.

If we emit error/warning and skip the property is good enough for me.

Ok. Then let's see the two options.
put the body of wrap_with_size in a rescue block and handle any invalid input
Then we would have it like:
defp wrap_with_size(prop, field, conversion_fun) do
  try do
    value = Map.get_lazy(prop, field, fn _ -> raise SomeError end)
    id = @prop_name_to_id[field]
    binary_value = conversion_fun.(value) # may raise SomeError
    size = byte_size(binary_value)
    <<id, size::integer-16, binary_value::binary>>
  rescue
    SomeError -> <<>>
  end
end

PRO: Don't need to change any code
CON: Less elixir way
Change data_to_bin to return an ok tuple/error.
Then we would have it like:
defp wrap_with_size(prop, field, conversion_fun) do
  with {:ok, value} <-  Map.fetch(prop, field),
          {:ok, binary_value} <- conversion_fun.(value) do
      id = @prop_name_to_id[field]
      size = byte_size(binary_value)
      <<id, size::integer-16, binary_value::binary>>

  else
    _ -> <<>>
   end
end

PRO: More elixir way
CONS:

Need to change all instances of: data_to_bin, failure_to_bin, timestamp_to_bin, availability_to_bin!!
The recursion of data_to_bin and custom_type_to_bin is very complicated and this may break it in ways difficult to debug... I have lost a lot of hair debugging those during the years 😅

Honestly I'd much rather go for the try version... 😬

Hopefully we can prevent this when we run State.put_value by checkin the unit type. but that I suppose that require more work and changes.

Yes having a data validation step there is in the backlog... has it been for a while actually. That would be great

@nonninz Thanks!
So TBH I did go through adding tuple return for data_to_bin but I couldn't make it work. specially the places that we call it in Enum.map ...
Ok I'll go with try block and log the error so we can fix the possible issues

@nonninz thanks again for the brainstorming!
I ended up using try block and I think know we have a a really good solution in place. our convertor doesn't throw errors anymore. It allows us to handle the requests safer without disturbance in our services.
e.g:
    test "converts invalid input to failure property" do
      state = %RooftopControlState{
        sunroof_tilt_state: %Property{data: :boo}
      }

      new_state =
        state
        |> RooftopControlState.to_bin()
        |> RooftopControlState.from_bin()

      assert new_state.sunroof_tilt_state == %AutoApi.Property{
               failure: %{description: "not able to serialize the value", reason: :format_error}
             }
   end


Activate ModifierReused twitter/compose-rules and fix ./gradlew composeLint

Idea Description
You can activate it in https://github.com/DroidKaigi/conference-app-2022/blob/main/detekt.yml
And please fix ./gradlew composeLint.
Reference images and links
https://github.com/DroidKaigi/conference-app-2022/blob/main/detekt.yml
https://twitter.github.io/compose-rules/rules/

I'd like to try this issue. 🙋♂

Thanks! Assigned


Feat: Introduce UNSTABLE_ProductLogo component #DS-1350

Description

Additional context

Issue reference

Changes unknown
when pulling 735b63d74c292d1b498273227971af6088aaa3fc on feat/ds-1350-introduce-product-logo
into ** on main**.

coverage: 78.227% (+0.09%) from 78.141%
when pulling 36f68bf3d84ca29734e9400c564bb352d9193ccd on feat/ds-1350-introduce-product-logo
into 479773655bf23e2c66596a81b568a71d9e484289 on main.

Changes unknown
when pulling 36f68bf3d84ca29734e9400c564bb352d9193ccd on feat/ds-1350-introduce-product-logo
into ** on main**.

Changes unknown
when pulling 36f68bf3d84ca29734e9400c564bb352d9193ccd on feat/ds-1350-introduce-product-logo
into ** on main**.

coverage: 78.227% (+0.09%) from 78.141%
when pulling dd39c9f21302702390a1cfa9cc9a11935abc8db4 on feat/ds-1350-introduce-product-logo
into 479773655bf23e2c66596a81b568a71d9e484289 on main.

🙏 @dlouhak Please, check a web package part of this PR, thank you :-)

coverage: 78.227% (+0.09%) from 78.141%
when pulling e7fdd1ecc8568051805aeef5fdc8a0efac9af861 on feat/ds-1350-introduce-product-logo
into 479773655bf23e2c66596a81b568a71d9e484289 on main.

coverage: 78.227% (+0.09%) from 78.141%
when pulling e9750c6a2212381b280f4afda60cde75355752ac on feat/ds-1350-introduce-product-logo
into bc192d1c1959cfea21ac99342be667f47c6a4dd8 on main.

Changes unknown
when pulling e9750c6a2212381b280f4afda60cde75355752ac on feat/ds-1350-introduce-product-logo
into ** on main**.

coverage: 78.214% (+0.07%) from 78.141%
when pulling 86976b23dc4d9e081a52ad329f97a23784babcfd on feat/ds-1350-introduce-product-logo
into bc192d1c1959cfea21ac99342be667f47c6a4dd8 on main.

coverage: 78.214% (+0.07%) from 78.141%
when pulling f84fc2f5e80320173f5fdc22c7b65fa25679a02c on feat/ds-1350-introduce-product-logo
into bc192d1c1959cfea21ac99342be667f47c6a4dd8 on main.

coverage: 78.214% (+0.07%) from 78.141%
when pulling f84fc2f5e80320173f5fdc22c7b65fa25679a02c on feat/ds-1350-introduce-product-logo
into bc192d1c1959cfea21ac99342be667f47c6a4dd8 on main.

Just a minor suggestion or nice-to-have: when switching the isInverted prop in the Storybook, it will be nice when the SVG changes from the white one to dark/colored one, e.g. when switched isInverted to false the logo will disappear (white logo on white background).

coverage: 78.214% (+0.07%) from 78.141%
when pulling 2ee3b9aae666b361f99ecf6608ed1eec1148913e on feat/ds-1350-introduce-product-logo
into bc192d1c1959cfea21ac99342be667f47c6a4dd8 on main.

coverage: 78.214% (+0.07%) from 78.141%
when pulling 2ee3b9aae666b361f99ecf6608ed1eec1148913e on feat/ds-1350-introduce-product-logo
into bc192d1c1959cfea21ac99342be667f47c6a4dd8 on main.

coverage: 78.214% (+0.07%) from 78.141%
when pulling dee68670854542f00eaa4d8e645398c0be784d23 on feat/ds-1350-introduce-product-logo
into bc192d1c1959cfea21ac99342be667f47c6a4dd8 on main.

Just a minor suggestion or nice-to-have: when switching the isInverted prop in the Storybook, it will be nice when the SVG changes from the white one to dark/colored one, e.g. when switched isInverted to false the logo will disappear (white logo on white background).

IMHO This is actually not an easy task in the storybook. I spent several hours on it and could not come up with a good solution. I tried to refactor it now one more time, so I hope it will be better 😉

coverage: 78.214% (+0.07%) from 78.141%
when pulling ed337a892c1c237f4590246b166506a2d4699409 on feat/ds-1350-introduce-product-logo
into e8a50d963066244dbd5a9451989f489415f9e5bb on main.

coverage: 78.294% (+4.5%) from 73.789%
when pulling e58c8661de29603441e166c4a4272f2894bb550c on feat/ds-1350-introduce-product-logo
into 79f55b4960ed3d190aea65b0d67480c0a5db1753 on main.


Add code coverage

pip install coveralls --quiet

nosetests -v --with-coverage --cover-package=constraint

Enable Coveralls also https://coveralls.io/


terminal mess up after quit fix

the terminal come to mess up after quit douban.fm, it looks like below:

👍


allow multiple sources in firewalld_zone_source

Will break existing playbooks however will allow the user to configure multiple sources for each zone in firewalld_zone_source.

Not sure if this is the most appropriate way of doing this, any comments?

Thank you for this pull request! It's a good ideaa dn I like it, but can you modify your code to avoid the duplicate definition of the zone name?
firewalld_zone_source:           trusted:             source: "<IP_ADDRESS>/24"             name: trusted
It would be nice if the name attribute isn't needed.

I'm sorry, my fault, now I do understand it. But can you rename the name attribute to zone, please? Afterwards I will test and merge it.

I have made the requested changes, let me know if there are any issues, thanks!

Thank you for supporting this ansible role!


oldView.$el doesn't exist

Hi! Great plugin, love it!
The only one issue I have is:
if I don't have old view it cause a error because oldView.$el doesn't exist
in this case, I propose to call show instead of showAnimated inside plugin.
This is common case when you show your view first time inside region

Hi Dmitry
Thanks for your feedback.
I will fix the issue tomorrow and will prepare the bower rep as well soon.
Many thanks and let me know any further thoughts.
Marcin
/Marcin Krysiak
2015-05-18 17:41 GMT+01:00 Dmitry Dudin<EMAIL_ADDRESS>
Hi! Great plugin, love it!
The only one issue I have is:
if I don't have old view it cause a error because oldView.$el doesn't exist
in this case, I propose to call show instead of showAnimated inside plugin.
This is common case when you show your view first time inside region
—
Reply to this email directly or view it on GitHub
https://github.com/marcinkrysiak1979/marionette.showAnimated/issues/3.

Hi Nedudi
I just fixed the issue and it should be fine now
Many thanks
Marcin


Exhaustive fix for minor ICE "e2ir: cannot cast" (and fixes one reopened regression)

I hope that this PR will be a final step toward to replace the ICE with a simple assert(0).
And also fixes following related issues:

Issue 14093 - [REG2.065] __traits(compiles, cast(Object)(tuple)) is true even if it doesn't compile.
It's reopened regression. Will be fixed properly.

Issue 14629 - Type system breaking and wrong code bugs in casting reference types to typeof(null)
It's type system breaking and wrong-code issue. Currently a cast to typeof(null) from any other reference types sometimes returns a "non-zero null" pointer - it's just wrong. It should be disallowed.

Auto-merge toggled on

This commit seems to have introduced the following regression: https://issues.dlang.org/show_bug.cgi?id=14737


fix: handle bad keyfiles

closes #141

moved the logic of fetching sa_credentials to a method
handled exception while fetching sa_credentials from keyfiles
added error log for all the malformed keyfiles

Please accept Google CLA before we can proceed with review of this code.


Remove :Format command.

This was sort of left over from when I just started the plugin and was
also creating extra LSP helper commands. This is the last one left that
I sort of just forgot about, and it probably just shouldn't be in here.
All it's doing is just calling vim.lsp.buf.formatting(), so it can
very easily be mapped locally. Plus most people may already have this
mapped directly calling that anyways.
Plus, is is also conflicting with another plugin:
https://github.com/mhartington/formatter.nvim/issues/35

This also sort of relates to https://github.com/scalameta/nvim-metals/issues/120, which I'll take care of later this week.


refactor(CLI): more idiomatic output writing for "list packages"

The DisplayPackages function is modified to take an io.Writer into which it'll write. This better conforms with go idioms and makes testing easier.
In the process of doing so, a customized tabwriter is implemented to make working with tabwriter more uniform. Helpers for instantiation and writing a table from a 2-D slice of strings make the code easier to read, and should make changes to the output less error prone (less fiddling with '\t' and other spacings).
For testing, among other things, I did:
diff <(bin/eksctl-anywhere list packages --source cluster) <(~/bin/eksctl-anywhere list packages --source cluster)
diff <(bin/eksctl-anywhere list packages --source registry --kube-version 1.23)  <(~/bin/eksctl-anywhere list packages --source registry --kube-version 1.23)

Which indicates the results are identical.
Issue #, if available:
Description of changes:
Testing (if applicable):
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/approve

Looks good overrall. Just a couple of nit and probably the test coverage and should be good to go.

/lgtm
/approve


TreeView selection

[ ] Enable selecting multiple samples in the tree view
[ ] Store the selected samples in a dynamic list (I'd suggest we create a list selectedSamples in LoadedData and update it via a change listener of whatever property the treeview has for its selected entries)
[ ] Link this to the RadioButtons in #11

Also have a Select dropdown on top of samples view with options:
All
None
Revert
by metadata -> metadataX ->possibleValues (when this is available)

Used a different selection model, because the one I tried so far
has proven itself to be very annoying to handle adding and removing samples from the selected list while
selecting and unselecting different samples.
Needs to be optimized concerning memory though.


refactor: 💡 Migrate SQFormGuidedWorkflow to TS

BREAKING CHANGE: 🧨 SQFormGuidedWorkflow prop 'actionButton' renamed to 'actions'. Removed
props 'isPanelExpanded' and 'expandPanel'
✅ Closes: #567

Looks like the tests are failing. As a side note, instead of running jest watch mode, give the Jest VS Code extension a try. It makes viewing the failing tests easier than trying to scroll through a terminal window

Apparently I never learn my lesson about these darn tests. i always forget about them but I guess that's why we have a CI, right? To be fair, though, I'm not changing functionality so the tests shouldn't be failing.


🐛 Bug Report: umlaut changing when downloading file

👟 Reproduction steps
upload a .zip file with the letter "ö" in it, it get's displayed correctly, then download
👍 Expected behavior
ö should stay ö even when downloaded
👎 Actual Behavior
the filename replaces the "ö" with an "ý"
🌐 Browser
Firefox

Strange, this bug doesn't occur for me. Which version of Pingvin Share and operating system are you using?

Closing this because there was no response. Feel free to comment if this issue still occurs.


Segmentation fault on ARM64

Checklist

Have you pulled and found the error with jc21/nginx-proxy-manager:latest docker image? Yes
Are you sure you're not using someone else's docker image? Yes
Have you searched for similar issues (both open and closed)? Yes

Describe the bug
I got a segmentation fault when I try to run the container using the docker-compose.yml from here: https://nginxproxymanager.com/setup/#running-on-raspberry-pi-arm-devices .
Same error with NPM tags 2.9.3, 2.8.0, github-develop
Here is the log:
app_1  | [5/26/2021] [6:06:36 PM] [Global   ] › ℹ  info      Generating MySQL db configuration from environment variables
app_1  | [5/26/2021] [6:06:36 PM] [Global   ] › ℹ  info      Wrote db configuration to config file: ./config/production.json
app_1  | [5/26/2021] [6:06:38 PM] [Migrate  ] › ℹ  info      Current database version: none
app_1  | ./run: line 18:   229 Segmentation fault      (core dumped) node --abort_on_uncaught_exception --max_old_space_size=250 index.js
app_1  | [5/26/2021] [6:06:40 PM] [Migrate  ] › ℹ  info      Current database version: none
app_1  | ./run: line 18:   271 Segmentation fault      (core dumped) node --abort_on_uncaught_exception --max_old_space_size=250 index.js
app_1  | [5/26/2021] [6:06:41 PM] [Migrate  ] › ℹ  info      Current database version: none
app_1  | ./run: line 18:   294 Segmentation fault      (core dumped) node --abort_on_uncaught_exception --max_old_space_size=250 index.js
app_1  | [5/26/2021] [6:06:43 PM] [Migrate  ] › ℹ  info      Current database version: none
app_1  | ./run: line 18:   307 Segmentation fault      (core dumped) node --abort_on_uncaught_exception --max_old_space_size=250 index.js
app_1  | [5/26/2021] [6:06:45 PM] [Migrate  ] › ℹ  info      Current database version: none
app_1  | ./run: line 18:   320 Segmentation fault      (core dumped) node --abort_on_uncaught_exception --max_old_space_size=250 index.js

Operating System

Oracle Linux 8: Image: Oracle-Linux-Cloud-Developer-8.3-aarch64-2021.05.12-1
Podman / Docker -> same error

$ lscpu
Architecture:        aarch64
Byte Order:          Little Endian
CPU(s):              2
On-line CPU(s) list: 0,1
Thread(s) per core:  1
Core(s) per socket:  2
Socket(s):           1
NUMA node(s):        1
Vendor ID:           ARM
Model:               1
Stepping:            r3p1
BogoMIPS:            50.00
NUMA node0 CPU(s):   0,1
Flags:               fp asimd evtstrm aes pmull sha1 sha2 crc32 atomics fphp asimdhp cpuid asimdrdm lrcpc dcpop asimddp ssbs

Sounds like this docker-node issue, could you check whether the code in that issue also results in a segmentation fault?

@chaptergy no... it's running ok:
$ docker run --rm --entrypoint sh -it node:alpine
/ # node
Welcome to Node.js v16.1.0.
Type ".help" for more information.
>

Hm, then I'm not sure I can help with that, sorry. Maybe someone from the community has an idea what could cause this. It would also be useful to know if this happens on any ARM64 machine, but if I remember correctly, there were people which were able to set it up on a Rasperry Pi with 64 bit.

I've run this on a VPS's VM using both mariadb and sqlite, the CPU is an ampere altra which is a server grade ARM processor and i have the same issue
./run: line 18:  1750 Segmentation fault      (core dumped) node --abort_on_uncaught_exception --max_old_space_size=250 index.js, the VM has 4 cores, 16GB of ram

Maybe someone could install the segfault-handler on their instance and register it in /app/index.js? Maybe that could provide some information of what causes this.

I would have to assume this is one of 2 reasons:

node installed on there is faulty or
a compiled node_module is faulty

Hi, I have a stack trace from a segfault
Environment is ARM Ampere (Oracle Cloud)
PID 17999 received SIGSEGV for address: 0x28
/app/node_modules/segfault-handler/build/Release/segfault-handler.node(+0x2dd0)[0xfffe34202dd0]
linux-vdso.so.1(__kernel_rt_sigreturn+0x0)[0xfffe367005c8]
node(_ZN2v88internal18CodeObjectRegistry32RegisterNewlyAllocatedCodeObjectEm+0x20)[0xdc89c8]
node(_ZN2v88internal4Heap11AllocateRawEiNS0_14AllocationTypeENS0_16AllocationOriginENS0_19AllocationAlignmentE+0x26c)[0xe0d044]
node(_ZN2v88internal4Heap34AllocateRawWithRetryOrFailSlowPathEiNS0_14AllocationTypeENS0_16AllocationOriginENS0_19AllocationAlignmentE+0x30)[0xe14158]
node(_ZN2v88internal7Factory11CodeBuilder13BuildInternalEb+0x104)[0xde9204]
node(_ZN2v88internal7Factory11CodeBuilder5BuildEv+0x10)[0xde9a10]
node(_ZN2v88internal25RegExpMacroAssemblerARM647GetCodeENS0_6HandleINS0_6StringEEE+0xd00)[0x13897c8]
node(_ZN2v88internal14RegExpCompiler8AssembleEPNS0_7IsolateEPNS0_20RegExpMacroAssemblerEPNS0_10RegExpNodeEiNS0_6HandleINS0_6StringEEE+0x154)[0x10bdd3c]
node(_ZN2v88internal10RegExpImpl7CompileEPNS0_7IsolateEPNS0_4ZoneEPNS0_17RegExpCompileDataENS_4base5FlagsINS0_8JSRegExp4FlagEiEENS0_6HandleINS0_6StringEEESF_bj+0x3c8)[0x10d96b0]
node(_ZN2v88internal10RegExpImpl15CompileIrregexpEPNS0_7IsolateENS0_6HandleINS0_8JSRegExpEEENS4_INS0_6StringEEEb+0x164)[0x10d9c1c]
node(_ZN2v88internal6RegExp15IrregexpPrepareEPNS0_7IsolateENS0_6HandleINS0_8JSRegExpEEENS4_INS0_6StringEEE+0x158)[0x10da728]
node(_ZN2v88internal10RegExpImpl12IrregexpExecEPNS0_7IsolateENS0_6HandleINS0_8JSRegExpEEENS4_INS0_6StringEEEiNS4_INS0_15RegExpMatchInfoEEE+0x84)[0x10da7fc]
node(_ZN2v88internal18Runtime_RegExpExecEiPmPNS0_7IsolateE+0x1a4)[0x112c964]
node[0x14638cc]
Segmentation fault (core dumped)

Update on this, appears to be a bug on nodes end that they've resolved in node 16+. I did an update to node 16.6.2 and it resolved the segfault.

Alrighty, I'll update the base node version to 16 and see what breaks

There was a bit of a delay, upstream docker image changes caused builds to fail for a while.
You can now verify this is fixed with this image:
jc21/nginx-proxy-manager:github-develop

it's using node v16.6.2 currently.
If it's all working please close this issue :)


Logging Refactoring

Other little changes, mainly about logging and errors, in order to improve the overall modularity of the script:

errors have been replaced by exceptions;
error() function has been removed;
logging level is now set in main function instead of SpeedTest class;
print() statement in chooseserver() function has been replaced with a logging.info();
stack trace will be printed only in verbose mode;
main() function parses args and then calls a new function perform_speedtest() to run the actual speedtest.

Not sure about the advantage of splitting main() to perform_speedtest() but everything else sounds great, thanks :+1:


Fix TOSA HardSwish Table generation for int8 inputs

More closely match tflite kernel behaviour for integers when calculating HardSwish table
Change-Id: I32a1338fb15d3505d4bea432a8523c79d8f5da7a

Hi @rsuderman Can you please review this PR ? Thank you!

Hi @rsuderman Can you please review this PR ? Thank you!

Hi @jamwar01 Can you please resolve conflicts? Thank you!

Hi @jamwar01 Can you please resolve conflicts? Thank you!

Conflicts have been resolved, thanks!

Hi @jamwar01 Can you please resolve conflicts? Thank you!

Hi @jamwar01 Can you please resolve conflicts? Thank you!

Hi @jamwar01  I'm going to go ahead and close this PR, because it seems to have stalled. If you're still interested in pursing this (and responding to my comments), please feel free to reopen! Thank you for your contribution!

Hi @gbaned, I have resolved the conflicts and opened a new PR for this:
https://github.com/tensorflow/tensorflow/pull/62829


icons

Add support for icons (e.g. Button startIcon)

Yes, the challenge for Toolpad will be on how to avoid loading the whole catalog for displaying 1 icon


Fixed typo "distrbuted"->"distributed"

Many thanks for the pull, all looks good. Merging.

And just for posterity sake, CLA was already signed.


Update CONTRIBUTING.md

Currently, the top of CONTRIBUTING.md still uses information relevent to justdeleteme, which is not relevant to this project, e.g.:

url: The url of the account-deletion page. If no such page exists, the url should be a contact or help page explaining the process of account deletion.

or:

domains: This is used by the Chrome extension

This should be updated to match justwhatsthedata instead.

Agreed, the project seems abandoned for now unfortunately. With better guidelines it could be great, but the premise is pretty ambitious and I imagine it would be hard to compare services to each other.


Cross spec validation of embedded schemas

Let's consider a multi-spec (compound) schema:
{
  "$schema": "https://json-schema.org/draft/2020-12/schema",
  "$ref": "#/$defs/draft2019",
  "$defs": {
    "draft2019": {
      "$schema": "https://json-schema.org/draft/2019-09/schema",
      "$id": "urn:nested",
      "items": [{
        "type": "string"
      }]
    }
  }
}

items is not valid as per draft2020 but is valid for draft2019. Now it fails because the whole JSON is validated against draft2020 meta-schema + embedded schemas individually. This is not a valid behavior according to specification (https://json-schema.org/draft/2020-12/json-schema-core#name-validating).

Update: this can possibly be achieved by wrapping a JsonNode in a special implementation that filters out embedded schemas. To be checked


[1.12] docker doesn't cleanup "faulty" service containers

When spinning up a service that fails to start, or exits within 10 seconds (so is considered not "up"), docker keeps spinning up new containers, without cleaning up failed containers, eventually leading to the node running out of resources.
To reproduce;
docker service create --name faulty --replicas 3 alpine sh

Then watch as the number of stopped containers keeps increasing:
watch docker ps -a

/cc @stevvooe we discussed this last week

Related to https://github.com/docker/docker/issues/23704 and #23706

Tried this as of rc3. It looks the behavior is somewhat mitigated through the task history limit.
Create a bad service:
$ docker service create --name redis ressteve

After a bit, we see we have several tasks:
$ docker service tasks redis -a | wc -l
      11

This will stay stable at 10 tasks, since the default task history limit is 10 and we have one replica. If we don't like this limit, we can change it
$ docker swarm update --task-history-limit 5
Swarm updated.

After a bit, we see the list has been truncated to 5 entries:
$ docker service tasks redis -a | wc -l
       6

I also tried this with the following, to ensure this works for bad containers:
$ docker service create alpine sh

Using docker ps, we see that we hold at 5 containers:
$ docker ps -a | grep angry | wc -l
       5

I changed the title, as this is not actually DOS.
This all works do to something called a "task assignment set" and the amount of history we keep for failed tasks. While new containers may be created after each failure, the total number is limited by the number of replicas per service times the task history limit. For example, if we scale to 10 replicas, we can see there are 5 (task history limit) * 10 replicas containers:
$ docker service scale angry_volhard=10
angry_volhard scaled to 10
$ docker ps -a | grep angry | wc -l
      50

The main reason to have this level of control is to enable debugging a container. In cases where failures are very quick, this history limit will result in a situation where a target container may disappear, but it still allows some window.
Admittedly, I think swarmkit could probably backoff to reduce the rate at which new containers are created as failures are encountered.

Thanks @stevvooe looks like it's not that big of an issue then; I just recalled the conversation we had earlier while talking with @tiborvass and did a quick test before opening this issue. Let me make this a "P3", as I don't think this should be a show-stopper (but something we may want to improve on)

@thaJeztah We should document the above to demonstrate this behavior. cc @sfsmithcha
Note that I did find a removal bug in this process. After generating these examples and removing the service, I still have the following:
$ docker ps -a -f name=angry
CONTAINER ID        IMAGE               COMMAND             CREATED             STATUS              PORTS               NAMES
c4683915c083        alpine:latest       "sh"                20 hours ago        Created                                 angry_volhard.8.158923tb8caod0qe8l29393un
eb063366c99a        alpine:latest       "sh"                20 hours ago        Created                                 angry_volhard.4.cd1jwcz7m8tbj0o4tuhpkj89w
4b17aa0280d5        alpine:latest       "sh"                20 hours ago        Created                                 angry_volhard.6.dxm3enk1xqvnz77kni8f4lpfo

I am pretty sure this is unrelated to your original complaint, but I need to track this down, nonetheless.

@thaJeztah Are we still seeing this?
I think there is a tertiary error causing removal to fail but I haven't seen the log message in the wild. We need to focus on separating these by root cause.
If we are still seeing this around code freeze, we'll have to add a task reaper to swarmkit but that is a nuclear option and will hide bugs.

I think it works correctly;
docker service create --name faulty nginx:alpine sh

This climbs up to +/- 16 old containers, but that seems to be just because it cannot remove old containers fast enough.
Fixing the service makes the amount of containers go back to 5 (1 running, and 4 old tasks);
docker service update --args "nginx -g 'daemon off;'" faulty

CONTAINER ID        IMAGE                                                                           COMMAND                  CREATED             STATUS                      PORTS               NAMES
b06788fb0d4e        nginx@sha256:5c6be3514a00db611371806c5aeb510dfd285a4b8261c6e5c3323387e396b66b   "nginx -g 'daemon ..."   30 seconds ago      Up 27 seconds               80/tcp, 443/tcp     faulty.1.d2oyympb32dbba22q4cfjsbit
19fb783c3c46        nginx@sha256:5c6be3514a00db611371806c5aeb510dfd285a4b8261c6e5c3323387e396b66b   "sh"                     36 seconds ago      Exited (0) 29 seconds ago                       faulty.1.9cyqj59cbef4xtsn3w4dbbsol
ef61d6a529d4        nginx@sha256:5c6be3514a00db611371806c5aeb510dfd285a4b8261c6e5c3323387e396b66b   "sh"                     42 seconds ago      Exited (0) 36 seconds ago                       faulty.1.j1454pjtc06bjkxhcqxgj3b46
62970591e5da        nginx@sha256:5c6be3514a00db611371806c5aeb510dfd285a4b8261c6e5c3323387e396b66b   "sh"                     48 seconds ago      Exited (0) 42 seconds ago                       faulty.1.1crpq72i9yxggltzoavd7oydz
467c640169ab        nginx@sha256:5c6be3514a00db611371806c5aeb510dfd285a4b8261c6e5c3323387e396b66b   "sh"                     55 seconds ago      Exited (0) 48 seconds ago                       faulty.1.lu27u18z8adquddoooga35fhm

One thing I tried, is to use the new --update-max-failure-ratio option, however this does not work for creating a service. I wonder if we should consider doing that, I'll open a new issue for that.


Implement blinking foreground color

the timing is controlled by a CTC channel
there's a 'blinking' bit in PIO B
open questions:

is the blinking bit controlled by the CTC interrupt, or is this a global override?

Fixed


Handle missing bones of skeletal animations more gracefully

Fixes https://github.com/playcanvas/engine/issues/850
I confirm I have signed the Contributor License Agreement.

This looks good - thanks! 👍
Are you sure you signed the Contributor License Agreement? I can't find your GitHub username...

Oh, I probably messed up when submitting the CLA. I resubmitted it. (Though, really, my phone number? That's absolutely private information.)

Hmm, well, you can be assured that your phone number is kept completely confidential. The spreadsheet to which contributor details is recorded to has never actually been used (and may never be), but we record this info anyway. It would certainly never, under any circumstances, be shared with a third party!
(To be honest, you could put in a fake number and it wouldn't make a difference. I guess it's more in your interest that it's accurate in case something potentially in your interest requires us to contact you in the future about your contributions).

And thanks for this fix, BTW! It's been bugging me for a long time, so it's much appreciated!

@willeastcott Great to hear that my information will be kept safe! Also, thank you for so quickly responding to my PR and merging it; this issue was bugging me as well.


[Advanced] Allow to display "unconfirmed" transactions

What is this feature about? (1 sentence)
This allows advanced users to display transactions without a confirmation in their tx list.
Why is it needed? What is the value? For whom do we build it?

Currently the web interface only displays transactions that have at least one confirmation by an owner or by a delegate. That's for security reasons.
We know of some teams that would like to add transactions that don't have a confirmation yet.

High-level overview of the feature

This is an advanced feature
There could be a "toggle" in the settings to show unconfirmed transactions.

Misc

Filtering is done via a flag on the endpoint

Updates

Nov 6, Tobi: Add details

For advanced user that use scripts to interact with the Safe services it might be useful to be able to also see transactions without confirmations.

@rmeissner Do we have any specific feedback of teams that require that? GP?

That was from the synthetix team iirc.

Closed for the moment as it does not seem to be relevant enough.


Not working on some app - App those use custom camera

Summary and context of the enhancement
I was using a barcode scanner app(It's my company app) In the old version of my company app was working with pict2cam perfectly but now they use a custom camera maybe using CameraX. Now when click on the camera button camera will open without any popup. Can you fix it or maybe provide a solution?
I'm using android 8.1
I also tried with an android emulator with android 7.0+7.1

Hello!
Unfortunately Pict2Cam can only hook into apps that take pictures with an external application, as mentioned in the help section of the app.
If the app that you're using now bundles their own camera implementation, Pict2Cam won't work any longer with it, I'm afraid.
Sorry and regards.


Swap out block explorer for OEV Network

Closes #456
Relates to https://github.com/api3dao/oev-dashboard/issues/191

LGTM

@hiletmis Milkomeda C1 testnet seems to be having trouble, can I merge anyway?

@aquarat providers check can be ignored as long as it is not related to active chains


dlopen in temp mirrord-bin SIP-patch directory

Bug Description
In some scenarios, when running a binary that is protected by SIP, after patching and running dlopen will be called on a path that is inside the mirrord-bin directory. We should hook calls to dlopen and strip the mirrord-bin dir from the path, like we do in file operations edit: dlopen is called before the layer is loaded so a normal hook won't help.
Steps to Reproduce

brew install --cask pgadmin4
mirrord exec /Applications/pgAdmin\ 4.app/Contents/MacOS/pgAdmin\ 4
get this error:dlopen /var/folders/4l/810mmn597cx7zy5w2bk11clh0000gn/T/mirrord-bin/Applications/pgAdmin 4.app/Contents/MacOS/../Frameworks/nwjs Framework.framework/Versions/109.0.5414.87/nwjs Framework: dlopen(/var/folders/4l/810mmn597cx7zy5w2bk11clh0000gn/T/mirrord-bin/Applications/pgAdmin 4.app/Contents/MacOS/../Frameworks/nwjs Framework.framework/Versions/109.0.5414.87/nwjs Framework, 0x0101): tried: '/var/folders/4l/810mmn597cx7zy5w2bk11clh0000gn/T/mirrord-bin/Applications/pgAdmin 4.app/Contents/MacOS/../Frameworks/nwjs Framework.framework/Versions/109.0.5414.87/nwjs Framework' (no such file), '/System/Volumes/Preboot/Cryptexes/OS/var/folders/4l/810mmn597cx7zy5w2bk11clh0000gn/T/mirrord-bin/Applications/pgAdmin 4.app/Contents/MacOS/../Frameworks/nwjs Framework.framework/Versions/109.0.5414.87/nwjs Framework' (no such file), '/var/folders/4l/810mmn597cx7zy5w2bk11clh0000gn/T/mirrord-bin/Applications/pgAdmin 4.app/Contents/MacOS/../Frameworks/nwjs Framework.framework/Versions/109.0.5414.87/nwjs Framework' (no such file), '/Library/Frameworks/nwjs Framework.framework/Versions/109.0.5414.87/nwjs Framework' (no such file), '/System/Library/Frameworks/nwjs Framework.framework/Versions/109.0.5414.87/nwjs Framework' (no such file, not in dyld cache).zsh: abort

Backtrace
No response
Relevant Logs
No response
Your operating system and version
macOS 13.3
Local process
/Applications/pgAdmin 4.app/Contents/MacOS/pgAdmin 4: Mach-O 64-bit executable x86_64
Local process version
No response
Additional Info
No response

This issue was fixed in #1603, but running pgAdmin with mirrord still does not work, tracking that in #1629.


Add getter for the Modifiers struct to Keyboard

Closes #39

Please run cargo fmt and squash the change into the last commit. Thank you!

Squash the change into the last commit. Thank you!

You can squash merge with GitHub: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/incorporating-changes-from-a-pull-request/about-pull-request-merges#squash-and-merge-your-commits

Yes, I am aware how Github works.
My default position is that any proposed set of git commits should form a reasonable and understandable set of changes. Formatting should be squashed into whichever commit changed the line that broke the formatting check. In this case, there is only one change and I am happy to squash it for you.


Impossible to have an interface as inBean

https://github.com/xebia-france/selma/issues/119

The tests uses Java8 classes whereas we tend support also Java 6 and 7. Can you replace Java8 specific code before I can merge ?

sorry I did not see the travis build was failed

Thanks @loutente


patch_cli_runner was removed and it appears that raven no longer automatically sends django command errors

The default sys.excepthook should capture it. With which version of Django do you see it?

I don't have context for the original issue, but I think I may be encountering a similar problem, where exceptions in my management commands are not being captured by Raven.
As an example, I created a dummy command that just raises an exception in its handle method. In Raven versions <5.24.0, running the command via ./manage.py mycommand will present the exception message on the console, along with a message along the lines of Sentry is attempting to send 2 pending error messages, and the exception will make it to a dummy Sentry project I've set up. In Raven versions >=5.24.0, running the command simply dumps the exception message to the console, and the exception does not make it to the Sentry project.
I've tested this on Django 1.10.3 and 1.9.9 with the same results.
My Raven and logging configs are the following:
RAVEN_CONFIG = {
  "dsn": "<mydsn>",
}
LOGGING = {
  "version": 1,
  "disable_existing_loggers": False,
  "root": {
    "level": "INFO",
    "handlers": ["sentry"],
  },
  "handlers": {
    "sentry": {
      "level": "WARNING",
      "class": "raven.contrib.django.raven_compat.handlers.SentryHandler",
    }
  }
}

In addition, I have a custom client class (basically just a subclass of the DjangoClient that passes install_sql_hook=False). I have included it in my Django settings.py file as so:
SENTRY_CLIENT = "path.to.my.client"

I've tried to investigate this issue by seeing how the custom excepthook is set up in Raven here. It appears that sys.excepthook is only set when the Client is instantiated, but it doesn't seem like the Client is getting instantiated when the management command is run.
Please let me know if any additional information would be helpful.

Can you paste the actual traceback you get on the console? I wonder if Django now catches those exceptions itself and reports them.

Traceback (most recent call last):
  File "./manage.py", line 13, in <module>
    execute_from_command_line(sys.argv)
  File "/home/ck/env/lib/python2.7/site-packages/django/core/management/__init__.py", line 367, in execute_from_command_line
    utility.execute()
  File "/home/ck/env/lib/python2.7/site-packages/django/core/management/__init__.py", line 359, in execute
    self.fetch_command(subcommand).run_from_argv(self.argv)
  File "/home/ck/env/lib/python2.7/site-packages/django/core/management/base.py", line 294, in run_from_argv
    self.execute(*args, **cmd_options)
  File "/home/ck/env/lib/python2.7/site-packages/django/core/management/base.py", line 345, in execute
    output = self.handle(*args, **options)
  File "/home/ck/myproject/apps/test/management/commands/mycommand.py", line 6, in handle
    raise Exception("This is a dummy exception")
Exception: This is a dummy exception

I am using djanog 1.9 and raven-5.32.0. raven no longer automatically sends django command errors

With django 1.9 and raven==5.11.0. It works perfectly.

I am having similar problems, even when I add explicit logging calls in my manage.py - the messages are simply not being sent to Sentry:
    logger = logging.getLogger("manage.py")
    try:
        execute_from_command_line(sys.argv)
    except Exception:
        logger.exception(" ".join(sys.argv))

The "Configuring Raven for host" message does not appear on the console, nor any messages about sending messages to Sentry.
I have exactly the same behaviour as reported before - raven 5.23 works fine (including all the expected debug messages on the console), while 5.24 (as well as 5.32 and presumably all in between) does not work at all in this situation - whether with explicit logging calls or with sys.excepthook.
I have also tried with and without this call added to my manage.py, in case there was a problem setting up logging:
logging.config.dictConfig(settings.LOGGING)

but this made no difference.
For reference, I'm using Django 1.8.16. My logging set up is almost exactly the same as example one - https://docs.sentry.io/clients/python/integrations/django/#integration-with-logging (obviously I have a few extra things, but nothing that should affect this). I do not have a custom SENTRY_CLIENT
Is there any more information needed, or can we remove that tag? With latest Raven, and all supported Django versions, (Django 1.8 to 1.10), there doesn't seem to be any way to get Sentry integration with manage.py commands at all.

@mitsuhiko  Can we have some attention to this? For Django, latest Raven client (up to 5.32.0) does not send any messages to Sentry outside request/response cycle.

@spookylukey i think this is largely just blocked because it's not clear how to solve it. Why does this not bubble up to the default except hook. Did this change in Django?

@mitsuhiko trying to debug this further, I can't reproduce my exact problem with a barebones Django project - namely, all logging through Sentry with client 5.24 and greater doesn't send messages. This ought to have been easier to debug, there must be some issue specific to my setup.
Debugging the default except hook thing might be harder, I don't know how to start with that.

@mitsuhiko After a brief investigation, it looks like the default sys.excepthook is not being successfully patched by raven when using management commands. As a result, raven's custom exception handling is not being triggered.
The patching of sys.excepthook appears to only happen when the raven Client is instantiated (https://github.com/getsentry/raven-python/blob/c69abaa1506a426802e979c7f8c6a4ab0ef9c4d7/raven/base.py#L216). However, when a management command is run, no Client is being instantiated, which means that sys.excepthook remains unchanged (I checked whether the Client gets instantiated by just dumping a print statement in its __init__ method, and I also printed sys.excepthook from within the command's handle method and it displayed the default <built-in function excepthook> rather than the expected <function handle_exception at ...>).
Is there a way to force the Client to be instantiated as part of bootstrapping the management command?

Since the conversation around this is spare, here is the issue:

Old versions of Django bubbled up exceptions to the system
We originally patched Django's management commands to capture those exceptions
We then added sys.except_hook, which also captured those same exceptions
Due to duplicate errors, we removed the Django one-off (since sys.except_hook covered it)
Django changed behavior and no longer bubbles up exceptions to the system

FYI I'm working on a patch for this. I think we can just hook apps in 1.7+ and runtime patch in older versions.

Hello,
I see this issue is marked as closed. With recent Django and Raven version, should the exceptions from management commands be reported to Sentry? Are there any additional steps to set them up?
I tested with this simple command:
from django.core.management.base import BaseCommand

class Command(BaseCommand):
    def handle(self, *args, **options):
        raise ValueError("hello from management command")

I got a traceback in console but nothing in Sentry website. I did not see "Sentry is attempting to send 1 pending error messages" output either.
I tested with Django 1.10.5 and 1.11, and with Sentry 6.0.0. Exceptions from request-response cycle do get reported.

I guess this was fixed on the 5.x branch, and also on master for 6.x, but we haven't yet cut 6.1 with this fix. Unsure what is blocking this tag though.

Thank you for the quick response!
It indeed works if I install raven==5.33.0 so I will use that for now...


const and stuff

just minor tweaking on main.js

TEST 1: success.

Nice - can't believe I missed the quotation marks around 0x03 for years though

hi, this is his alternative account.
i was compromised both my gmail and github account.


Add a heroimage and buttons to README.md

This change is

@justin808 Where should we store images?


How to evaluate information retrieval task?

I do not find any evaluation function for information retrieval tasks, such as SimpleCalendarFirstEventAfterStartTime. Do I miss something?

Are you talking about how to run information retrieval tasks? Or are you wondering how the code works? For the first part, you can do:
python run.py \
  --suite_family=android_world \
  --agent_name=t3a_gpt4 \
  --perform_emulator_setup \
  --tasks= SimpleCalendarFirstEventAfterStartTime \  # Optional: Just run on a subset.

In terms of how the code works the task is defined in a proto. The information retrieval tasks use a different structure in the code, using a proto. Then all information_retrieval tasks share a common is_successful (link) which uses the proto to check for success.


Broken on Chrome Canary

Today IR stopped working for me on latest OS X Canary – my 404 route always renders. Works fine on latest vanilla Chrome.
On page load:
iron_middleware-stack.js:198 Uncaught Error: Handler with name 'route' already exists.

Fixed by 7e6da3b

Hi @lorensr, is this in production? I'm having this issue with my app after updating Chrome stable (it's not even Canary) today. Where is commit 7e6da3b? Can't see it anywhere... Cheers

This is in the latest version. For more info see #1513


If provider flag not given to e2e tests, exits(1) with misleading message.

running  go run ./cmd/e2e/e2e.go directly from source without --provider, you get a message that conformance test is going to run, but then, it kube just exits(1).
We should notify that its a failure and we are exiting, shouldn't we?

You should be running this using the wrapper(s). See https://github.com/GoogleCloudPlatform/kubernetes/blob/master/docs/devel/development.md

possibly saying "run with wrappers..." would be better if explicit in the main method.


added cython version for data_overlap

I added a cython implementation of the data_overlap function. This makes this method which was quite slow for large datasets much faster.

Codecov Report
Patch coverage: 45.65% and project coverage change: -0.36% :warning:

Comparison is base (3d3c4d4) 80.46% compared to head (d17c75a) 80.10%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #97      +/-   ##
==========================================
- Coverage   80.46%   80.10%   -0.36%
==========================================
  Files          14       14
  Lines        2375     2393      +18
==========================================
+ Hits         1911     1917       +6
- Misses        464      476      +12

Files Changed
Coverage Δ

dadapy/_utils/density_estimation.py
74.52% <ø> (ø)

dadapy/_utils/discrete_functions.py
73.36% <ø> (ø)

dadapy/id_discrete.py
79.54% <ø> (ø)

dadapy/metric_comparisons.py
65.87% <22.22%> (-1.97%)
:arrow_down:

dadapy/id_estimation.py
83.59% <71.42%> (-1.33%)
:arrow_down:

dadapy/base.py
85.56% <100.00%> (-0.30%)
:arrow_down:

dadapy/clustering.py
90.85% <100.00%> (+0.07%)
:arrow_up:

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Unable to access {created.strftime} in move action

I upgraded to v3, and having a problem with one of my existing rules
It moves a data.ofx to another dir, and also renames it to have a "YYYYMMDD" prefix, based on the creation date of the source file
rules:
  - name: "Copy OFX to syncbox"
    locations: ~/dev/barclays
    subfolders: false
    filters:
      - extension: ofx
      - name:
          match: data
          case_sensitive: false
      - created
    actions:
      - echo: "Copying OFX to syncbox/accounts/{created.strftime('%Y%m%d - Barclays.ofx')}"
      - move:
         dest: "~/syncbox/accounts/{created.strftime('%Y%m%d - Barclays.ofx')}"
         on_conflict: overwrite
    tags:
      - barclays

Whilst I can access created.strftime in the echo command, when I then use it in the dest of a move command it fails.
[carpii@beep:~]$ org --version
organize v3.0.0

[carpii@beep:~]$ org run --tag barclays
Config: "/home/carpii/.config/organize/config.yaml"

⚙ Rule #2: Copy OFX to syncbox ───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
/home/carpii/dev/barclays
  ./data.ofx
    - (echo) Copying OFX to syncbox/accounts/20240111 - Barclays.ofx
    - (move) ERROR! Missing value for template: 'builtin_function_or_method object' has no attribute 'strftime'. Maybe you forgot a filter?

success 0 / fail 1

Hi thanks for reporting! I've written multiple tests and cannot reproduce this. Which OS and python version are you on?

Hi,
I'm using Arch 6.6.9-arch1-1 and python 3.11.6
organize is out of date on Arch repos, and then installed into a virtual env using pipx install "organize-tool[texttract]"

I created a simpler example which does work, although it's not that clear whats different
> touch ~/foo.bar
  - name: "Rename FOO"
    locations: ~/
    subfolders: false
    filters:
      - extension: bar
      - name:
          match: foo
          case_sensitive: false
      - created
    actions:
      - echo: "Rename foo.bar to {created.strftime('%Y%m%d - foo.bar')}"
      - move:
         dest: "~/{created.strftime('%Y%m%d - foo.bar')}"
         on_conflict: overwrite
    tags:
      - foobar

Config: "/home/carpii/.config/organize/config.yaml"

⚙ Rule #2: Rename FOO ──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
/home/carpii
  ./foo.bar
    - (echo) Rename foo.bar to 20240112 - foo.bar
    - (move) Move to /home/carpii/20240112 - foo.bar

success 1 / fail 0

No problem, thanks for the clarification!


The Evil Dead TAP 2698

Hi
I am having some problems loading this TAP file. The tapuino is a wagiminator SMD model running 2.10.0 firmware.
Every other TAP files seems to load ok (Rambo, Transformers, etc).
I have tried 250425 long board and seem to have more success on this revision. Game mostly loads but gameplay doesn't seem 100% correct so most likely some loading problems.
On a 250469 shortboard the game will not load not successfully. On loading, the game is found correctly and at around 10% loading there is a pause, then the expected rainbow loading screen appears which should last till end of the loading but at around 12% the loading screen will go a bluish colour and stay like that to 100%.
Do you have any ideas or possible solutions? Thankyou in advance for your time and assistance.
Cheers BT

Hi C64Retro
I have just downloaded the game and tested it in vice, it stops at counter 11, so i downloaded another copy from archive.org and that loaded fine so maybe your copy are corrupt? Just a thought. Sincerely

Hi
I have tried the archive .org version and that works fine. So I am wondering why the version form C64Tapes-org (evil dead 2698) is not working? This version loads on my C64 winvice and with the ultimate II cart with tape adapter. Also checks out ok with tapcleanfe.
Cheers BT


fix https://github.com/spring-cloud/spring-cloud-netflix/issues/2330

@eacdy Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.

@eacdy Thank you for signing the Contributor License Agreement!

Codecov Report

Merging #2344 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #2344      +/-   ##
==========================================
- Coverage   68.01%   67.99%   -0.02%
==========================================
  Files         231      231
  Lines        8138     8131       -7
  Branches     1013     1011       -2
==========================================
- Hits         5535     5529       -6
+ Misses       2217     2216       -1
  Partials      386      386

Impacted Files
Coverage Δ

...rk/cloud/netflix/feign/FeignClientFactoryBean.java
66.66% <ø> (-0.67%)
:arrow_down:

...ork/cloud/netflix/feign/FeignClientProperties.java
61.22% <0%> (-1.04%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b6889b...f869b79. Read the comment docs.

See https://github.com/spring-cloud/spring-cloud-netflix/issues/2330#issuecomment-338355211


Filter on albums page.

Good day dev. When filtering files by Video/animations/images or otherwise, it would be quite useful if the files can be collated in the albums view in their respective folders minus the filtered media.
I am cognizant that this can be done from the 3 dot menu, however you are only left with a long strip of images etc. to scroll through, which can be tedious at times and confusing to keep track of folders and files as everything is mixed into one long vertical strip.
Appreciate you're continued dedication to this gem 💎 you have created.

My apologies, back to the first issue. I made a screen recording in hopes this will provide better clarity as to what I was suggesting.
https://drive.google.com/file/d/1t0GK345EFpU4JlWHEz_00H6YLq5-spu1/view?usp=drivesdk

Thanks for the video, this was helpful.
I understand what you want but i don't intend to do it that way.
As for the Stats, i think you missed what i suggested. Here's a video where you can see the flow: https://drive.google.com/file/d/1azSsBMHNnSmFW8jfHVIbC2l4o8klpvjz/view?usp=drivesdk

Glad my video was of some use.
I completely understand at this time.
Really appreciate you're energy towards my issue. Even more so than the app, you sir are the real gem. Looking forward to raising more meaningful issues in the future🙏


Automated Package Upgrade

:tada: This PR is included in version 27.1.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


How to get normal/clean numerical output display?

I raised this issue when this "problem" occurred with release 0.24.1 but I really need to know how to get around/fix it.
This code:
x = "73376604975172941348239581622402173809".to_big_i
print "factors  of #{x} are: "; print " => ", tm { print '\n', x.factors }
puts

currently produces this output for versions > 0.23.1
factors of<PHONE_NUMBER>5172941348239581622402173809 are:
[[3_big_i, 1], [127_big_i, 1], [2388286630369_big_i, 1], [80639196284734379234981_big_i, 1]] => 00:00:00.118

I don't want numerical type references in my output display.  What do I have to do so the output displays normal/clean numerical values?
factors of<PHONE_NUMBER>5172941348239581622402173809 are:
[[3, 1], [127, 1], [2388286630369, 1], [8063919628473437923498, 1]] => 00:00:00.118

Proposal:
What about leaving type suffix in the PrettyPrint pp/pp! but removing them in the normal inspect.
When I have doubt and want to double check the type information with a print-debugging I use pp. And when I want a more human friendly output using p/puts/print should be enough.
This will leave puts array without suffix, but pp! array will have the type suffix.
I still found it a bit to noisy also the suffix and it does not gives information of the union that might hold that data. So I sometimes might use pp!({x, x.class, typeof(x)}) to get all the information I need.

Closed in #7525


Update standalone.md

If you just copy/paste into powershell this fails... could just be on a single line?
Summary
Describe your changes here.
Fixes #Issue_Number (if available)

Internal previews

📄 File
🔗 Preview link

docs/fundamentals/dashboard/standalone.md
Standalone .NET Aspire dashboard

@IEvangelist did I do this right?

@IEvangelist did I do this right?

@jamesmontemagno yes! Perfect, looks great... Feel free to set this as "Ready to review" and I'll approve/merge.


Resuming from a monolithic FSDP checkpoint times out on multinode

Description
When loading a monolithic checkpoint on multiple nodes, scattering the FSDP optimizer state dict times out.
It seems that the local rank 0s (except global rank 0) end up waiting for an AllReduce, while all other ranks are performing a Broadcast of the optimizer state. Hence, the error does not happen on a single node. With 16 nodes, 15 rank 0s time out on an AllReduce. See example log with 2 nodes below.
Environment
This is on an AMD MI250X system which could be relevant if it's e.g. a RCCL issue. But I believe the bug is more likely to be in either composer or PyTorch. Using PyTorch 2.2.1 (stable) with ROCm 5.7.
Steps to reproduce the behavior:

Save a monolithic FSDP checkpoint.
Load it again on multiple nodes.

Log snippet - 2 nodes

0: ========================= ROCm System Management Interface =========================
0: =================================== Concise Info ===================================
0: GPU  Temp (DieEdge)  AvgPwr  SCLK    MCLK     Fan  Perf  PwrCap  VRAM%  GPU%
0: 0    36.0c           93.0W   800Mhz  1600Mhz  0%   auto  500.0W    0%   0%
0: 1    37.0c           N/A     800Mhz  1600Mhz  0%   auto  0.0W      0%   0%
0: 2    31.0c           93.0W   800Mhz  1600Mhz  0%   auto  500.0W    0%   0%
0: 3    37.0c           N/A     800Mhz  1600Mhz  0%   auto  0.0W      0%   0%
0: 4    32.0c           87.0W   800Mhz  1600Mhz  0%   auto  500.0W    0%   0%
0: 5    40.0c           N/A     800Mhz  1600Mhz  0%   auto  0.0W      0%   0%
0: 6    30.0c           91.0W   800Mhz  1600Mhz  0%   auto  500.0W    0%   0%
0: 7    35.0c           N/A     800Mhz  1600Mhz  0%   auto  0.0W      0%   0%
0: ====================================================================================
0: =============================== End of ROCm SMI Log ================================
0: Rank 0 CPU affinity: pid 50746's current affinity mask: fefefefefefefefe
1:
1:
1: ========================= ROCm System Management Interface =========================
1: =================================== Concise Info ===================================
1: GPU  Temp (DieEdge)  AvgPwr  SCLK    MCLK     Fan  Perf  PwrCap  VRAM%  GPU%
1: 0    40.0c           90.0W   800Mhz  1600Mhz  0%   auto  500.0W    0%   0%
1: 1    40.0c           N/A     800Mhz  1600Mhz  0%   auto  0.0W      0%   0%
1: 2    32.0c           92.0W   800Mhz  1600Mhz  0%   auto  500.0W    0%   0%
1: 3    37.0c           N/A     800Mhz  1600Mhz  0%   auto  0.0W      0%   0%
1: 4    41.0c           84.0W   800Mhz  1600Mhz  0%   auto  500.0W    0%   0%
1: 5    36.0c           N/A     800Mhz  1600Mhz  0%   auto  0.0W      0%   0%
1: 6    34.0c           85.0W   800Mhz  1600Mhz  0%   auto  500.0W    0%   0%
1: 7    41.0c           N/A     800Mhz  1600Mhz  0%   auto  0.0W      0%   0%
1: ====================================================================================
1: =============================== End of ROCm SMI Log ================================
1: Rank 1 CPU affinity: pid 11007's current affinity mask: fefefefefefefefe
0: Launching on nid006999 (0/2), NODE_RANK=0, WORLD_SIZE=16 master nid006999 port 9999, GPUs 8, ROCm: True
1: Launching on nid007000 (1/2), NODE_RANK=1, WORLD_SIZE=16 master nid006999 port 9999, GPUs 8, ROCm: True
...
1: nid007000:11641:20665 [0] NCCL INFO comm 0x386532f0 rank 1 nranks 2 cudaDev 0 busId c1000 localSize 112 used 8406640 bytes - Init COMPLETE
0: nid006999:51377:62817 [0] NCCL INFO comm 0x2460a1a0 rank 0 nranks 2 cudaDev 0 busId c1000 localSize 112 used 8406640 bytes - Init COMPLETE
0: 2024-03-02 20:38:26,759: rank0[51377][MainThread]: DEBUG: composer.utils.reproducibility: Restoring the RNG state
1: 2024-03-02 20:38:26,765: rank8[11641][MainThread]: DEBUG: composer.utils.reproducibility: Restoring the RNG state
1: 2024-03-02 20:38:26,765: rank8[11641][MainThread]: DEBUG: composer.core.state: Finished wrapping model with FSDP.
1: 2024-03-02 20:38:26,765: rank8[11641][MainThread]: DEBUG: composer.core.state: Loading algorithms into state.
1: 2024-03-02 20:38:26,765: rank8[11641][MainThread]: DEBUG: composer.core.state: Loading callbacks into state.
1: 2024-03-02 20:38:26,765: rank8[11641][MainThread]: DEBUG: composer.core.state: Loading dataset_state into state.
1: 2024-03-02 20:38:26,773: rank8[11641][MainThread]: DEBUG: composer.core.state: Loading optimizers into state.
0: 2024-03-02 20:38:26,811: rank0[51377][MainThread]: DEBUG: composer.core.state: Finished wrapping model with FSDP.
0: 2024-03-02 20:38:26,812: rank0[51377][MainThread]: DEBUG: composer.core.state: Loading algorithms into state.
0: 2024-03-02 20:38:26,812: rank0[51377][MainThread]: DEBUG: composer.core.state: Loading callbacks into state.
0: 2024-03-02 20:38:26,812: rank0[51377][MainThread]: DEBUG: composer.core.state: Loading dataset_state into state.
0: 2024-03-02 20:38:26,819: rank0[51377][MainThread]: DEBUG: composer.core.state: Loading optimizers into state.
1: 2024-03-02 20:38:27,006: rank8[11641][MainThread]: DEBUG: composer.core.state: Loading FSDP optimizer with fsdp_state_dict_type=full
0: 2024-03-02 20:38:27,006: rank0[51377][MainThread]: DEBUG: composer.core.state: Loading FSDP optimizer with fsdp_state_dict_type=full
1: [rank8]:[E ProcessGroupNCCL.cpp:523] [Rank 8] Watchdog caught collective operation timeout: WorkNCCL(SeqNum=29, OpType=ALLREDUCE, NumelIn=1, NumelOut=1, Timeout(ms)=600000) ran for 600604 milliseconds before timing out.
0: [rank0]:[E ProcessGroupNCCL.cpp:523] [Rank 0] Watchdog caught collective operation timeout: WorkNCCL(SeqNum=30, OpType=BROADCAST, NumelIn=131072000, NumelOut=131072000, Timeout(ms)=600000) ran for 600645 milliseconds before timing out.

To be clear, all other ranks are participating in the Broadcast op. Here's rank 9:

1: 2024-03-02 20:38:27,006: rank9[11642][MainThread]: DEBUG: composer.core.state: Loading FSDP optimizer with fsdp_state_dict_type=full
1: [rank9]:[E ProcessGroupNCCL.cpp:523] [Rank 9] Watchdog caught collective operation timeout: WorkNCCL(SeqNum=29, OpType=BROADCAST, NumelIn=131072000, NumelOut=131072000, Timeout(ms)=600000) ran for 600627 milliseconds before timing out.

@rlrs just to clarify, are you downloading this checkpoint from an object store? I've seen this before if the download is slower than the nccl timeout.
Our unit and regression tests all seem to be passing for this which match the repro steps -- is there anything else you would suspect?
Could you also include your Composer version?

The checkpoint is on a Lustre distributed filesystem. My understanding of the loading is that, at the point where I see a timeout, the state dict is already loaded into memory by each local rank 0 (I have load_monolith_rank0_only=True, use_orig_params=False and sync_module_states=True in my FSDP config, as required).
It seems to fail when sending the optimizer state to the other GPUs though. From what I can tell, it's probably on this line.
I can try moving the checkpoint to some faster storage and see if it helps, but I suspect that's not it.
Ah, and here's composer_collect_env from one of the nodes.

Collecting system information...
System Environment Report
Created: 2024-03-04 11:00:01 EET
PyTorch information
PyTorch version: 2.2.1+rocm5.7
Is debug build: False
CUDA used to build PyTorch: N/A
ROCM used to build PyTorch: 5.7.31921-d1770ee1b
OS: Ubuntu 22.04.3 LTS (x86_64)
GCC version: (Ubuntu 11.4.0-1ubuntu1~22.04) 11.4.0
Clang version: 17.0.0 (https://github.com/RadeonOpenCompute/llvm-project roc-5.7.0 23352 d1e13c532a947d0cbfc94759c00dcf152294aa13)
CMake version: version 3.26.3
Libc version: glibc-2.35
Python version: 3.10.13 (main, Sep 11 2023, 13:44:35) [GCC 11.2.0] (64-bit runtime)
Python platform: Linux-5.14.21-150400.24.81_12.0.75-cray_shasta_c-x86_64-with-glibc2.35
Is CUDA available: True
CUDA runtime version: Could not collect
CUDA_MODULE_LOADING set to: LAZY
GPU models and configuration: AMD Instinct MI250X (gfx90a:sramecc+:xnack-)
Nvidia driver version: Could not collect
cuDNN version: Could not collect
HIP runtime version: 5.7.31921
MIOpen runtime version: 2.20.0
Is XNNPACK available: True
CPU:
Architecture:                       x86_64
CPU op-mode(s):                     32-bit, 64-bit
Address sizes:                      48 bits physical, 48 bits virtual
Byte Order:                         Little Endian
CPU(s):                             128
On-line CPU(s) list:                0-127
Vendor ID:                          AuthenticAMD
Model name:                         AMD EPYC 7A53 64-Core Processor
CPU family:                         25
Model:                              48
Thread(s) per core:                 2
Core(s) per socket:                 64
Socket(s):                          1
Stepping:                           1
Frequency boost:                    enabled
CPU max MHz:                        2000.0000
CPU min MHz:                        1500.0000
BogoMIPS:                           3992.45
Flags:                              fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ht syscall nx mmxext fxsr_opt pdpe1gb rdtscp lm constant_tsc rep_good nopl nonstop_tsc cpuid extd_apicid aperfmperf rapl pni pclmulqdq monitor ssse3 fma cx16 pcid sse4_1 sse4_2 x2apic movbe popcnt aes xsave avx f16c rdrand lahf_lm cmp_legacy svm extapic cr8_legacy abm sse4a misalignsse 3dnowprefetch osvw ibs wdt tce topoext perfctr_core perfctr_nb bpext perfctr_llc mwaitx cpb cat_l3 cdp_l3 invpcid_single hw_pstate ssbd mba ibrs ibpb stibp vmmcall fsgsbase bmi1 avx2 smep bmi2 erms invpcid cqm rdt_a rdseed adx smap clflushopt clwb sha_ni xsaveopt xsavec xgetbv1 xsaves cqm_llc cqm_occup_llc cqm_mbm_total cqm_mbm_local clzero irperf xsaveerptr rdpru wbnoinvd amd_ppin arat npt lbrv svm_lock nrip_save tsc_scale vmcb_clean flushbyasid decodeassists pausefilter pfthreshold avic v_vmsave_vmload vgif v_spec_ctrl umip pku ospke vaes vpclmulqdq rdpid overflow_recov succor smca fsrm
Virtualization:                     AMD-V
L1d cache:                          2 MiB (64 instances)
L1i cache:                          2 MiB (64 instances)
L2 cache:                           32 MiB (64 instances)
L3 cache:                           256 MiB (8 instances)
NUMA node(s):                       4
NUMA node0 CPU(s):                  0-15,64-79
NUMA node1 CPU(s):                  16-31,80-95
NUMA node2 CPU(s):                  32-47,96-111
NUMA node3 CPU(s):                  48-63,112-127
Vulnerability Gather data sampling: Not affected
Vulnerability Itlb multihit:        Not affected
Vulnerability L1tf:                 Not affected
Vulnerability Mds:                  Not affected
Vulnerability Meltdown:             Not affected
Vulnerability Mmio stale data:      Not affected
Vulnerability Retbleed:             Not affected
Vulnerability Spec rstack overflow: Mitigation; safe RET, no microcode
Vulnerability Spec store bypass:    Mitigation; Speculative Store Bypass disabled via prctl and seccomp
Vulnerability Spectre v1:           Mitigation; usercopy/swapgs barriers and __user pointer sanitization
Vulnerability Spectre v2:           Mitigation; Retpolines, IBPB conditional, IBRS_FW, STIBP always-on, RSB filling, PBRSB-eIBRS Not affected
Vulnerability Srbds:                Not affected
Vulnerability Tsx async abort:      Not affected
Versions of relevant libraries:
[pip3] numpy==1.26.4
[pip3] onnx==1.14.0
[pip3] onnxruntime==1.15.1
[pip3] pytorch-ranger==0.1.1
[pip3] pytorch-triton-rocm==2.2.0
[pip3] torch==2.2.1+rocm5.7
[pip3] torch-optimizer==0.3.0
[pip3] torchaudio==2.2.1+rocm5.7
[pip3] torchmetrics==1.3.1
[pip3] torchvision==0.17.1+rocm5.7
[pip3] triton==2.2.0
[conda] No relevant packages
Composer information
Composer version: 0.20.1
Composer commit hash: None
Host processor model name: AMD EPYC 7A53 64-Core Processor
Host processor core count: 64
Number of nodes: 1
Accelerator model name: AMD Instinct MI250X
Accelerators per node: 1
CUDA Device Count: 8

Hey @rlrs would it be at all possible for you to test using an object store instead of a networked file system? I'm not able to reproduce your issue on our clusters with object store, so trying to rule out pieces :)

I could probably use an object store, but the code gets way past loading the state dictionary. It gets to broadcasting the model state, which works just fine, and then broadcasting the optimizer state, which apparently times out.
After a lot of debugging, I've found the following.
On this line in PyTorch, unflat_osd is {} only on local rank 0s, despite being broadcast just above.
I verified this by adding logging just after the broadcast, logger.warning(f"unflat_osd is empty? {unflat_osd == {}}"). Here are the relevant log lines (I also have NCCL_DEBUG_SUBSYS=COLL for some information about what's going on).

0: 2024-03-05 18:22:57,443: rank0[66246][MainThread]: DEBUG: composer.core.state: Loading FSDP optimizer with fsdp_state_dict_type=full
1: 2024-03-05 18:22:57,443: rank8[11040][MainThread]: DEBUG: composer.core.state: Loading FSDP optimizer with fsdp_state_dict_type=full
1: nid006494:11040:11040 [0] NCCL INFO Broadcast: opCount 1a sendbuff 0x14e70dc04400 recvbuff 0x14e70dc04400 count 8 datatype 0 op 0 root 0 comm 0xb794560 [nranks=16] stream 0xb78fbe0
0: nid006493:66246:66246 [0] NCCL INFO Broadcast: opCount 1a sendbuff 0x14f442223000 recvbuff 0x14f442223000 count 8 datatype 0 op 0 root 0 comm 0xb792c80 [nranks=16] stream 0xbc3a8a0
0: nid006493:66246:66246 [0] NCCL INFO Broadcast: opCount 1b sendbuff 0x14f442204400 recvbuff 0x14f442204400 count 125304 datatype 0 op 0 root 0 comm 0xb792c80 [nranks=16] stream 0xbc3a8a0
0: [rank0]:[2024-03-05 18:22:57,603] torch.distributed.fsdp._optim_utils: [WARNING] unflat_osd is empty? False
...
1: [rank8]:[2024-03-05 18:22:57,623] torch.distributed.fsdp._optim_utils: [WARNING] unflat_osd is empty? True
1: nid006494:11040:11040 [0] NCCL INFO AllReduce: opCount 1c sendbuff 0x14e70dc00000 recvbuff 0x14e70dc00000 count 1 datatype 1 op 0 root 0 comm 0xb794560 [nranks=16] stream 0xb78fbe0
0: nid006493:66246:66246 [0] NCCL INFO Broadcast: opCount 1c sendbuff 0x14f215a00000 recvbuff 0x14f215a00000 count 524288000 datatype 0 op 0 root 0 comm 0xb792c80 [nranks=16] stream 0xbc3a8a0
0: nid006493:66246:66246 [0] NCCL INFO Broadcast: opCount 1d sendbuff 0x14f1d6a00000 recvbuff 0x14f1d6a00000 count 524288000 datatype 0 op 0 root 0 comm 0xb792c80 [nranks=16] stream 0xbc3a8a0
... unflat_osd is empty? False on all other ranks

I think I will go make a PyTorch issue at this point, but maybe you have some idea about what could be happening.

Any chance you could produce a minimal repro? I'm not able to repro, and this doesn't look familiar to us.

I got caught up in other things, but finally had time to investigate this further. The composer code only loads the state dict on the global rank 0, while FSDP.scatter_full_optim_state_dict assumes that the optimizer state dict is located on each FSDP rank 0. This means checkpoint loading breaks with HSDP, for example.
I can try to fix this if you'd like, but I can't rule out needing some support. Is the intended functionality to only load on the global rank 0? Because it seems that PyTorch does not think so, and patches would be needed there.
Alternatively, I might just write a script that converts the full ckpt to a sharded one - as far as I can tell, this uses torch.distributed.checkpoint which is more likely to work, I think.

@mvpatel2000 to take a look

@rlrs We discussed internally a bit. So, it seems currently loading monolith checkpoints with HSDP is broken in the current API. There are 3 paths here:

Torch has a new API (currently gated in our code as >2.2.9 aka torch nightly) which we use internally and works well for this case. Unfortunately, this has a few hiccups requiring torch dist to be initialized, so it breaks in single GPU cases. We have opened issues / upstreamed a few changes to fix this, and I'm hoping as of 2.3 (in 1 month?) we can switch over to this API.
We can add support for HSDP + current/legacy API, which I think would involve loading the checkpoint on each local rank 0 of each shard group
[Not a fix] You could switch to sharded checkpoints or stop using HSDP

Given (1), I don't think we will be prioritizing supporting HSDP + monolith checkpoints with the current API as it will go away imminently. You can possibly switch to nightly (we have images here, e.g. mosaicml/pytorch:2.3.0_cu121-nightly20240110-python3.11-ubuntu20.04, with obvious disclaimer that there is risk in nightly) which should resolve this.
Alternatively, I'm happy to review PRs and help flesh out what (2) would look like if it is important to your workloads.


img fixed

img fixed in documentation: https://github.com/MicrosoftDocs/azure-docs/blob/main/articles/event-grid/subscribe-to-resource-notifications-resources-events.md

#sign-off


Gluon's size

It seems right now using Gluon makes my executable over 4 MB larger. This is compared to about 1.7 MB for Guile or about 300 KB for Lua. I am curious if you know specifically what makes Gluon so much larger than other embedded languages (is it some particular dependency?) and whether you plan to decrease Gluon's size in the future?

SInce gluon is statically type it inevitably needs some extra code for the typechecker (~10k / 46k LOC, tests included). There are also some modules such as auto completion and code formatting which aren't necessary for most users but which are currently in the main set of crates. These will be moved out eventually.
However, the most significant reducation is something you can do right now. Just enable link time optimization and the size should be reduced quite significantly (with LTO, compiling gluon-c-api comes in at 812 kb).
[profile.release]
lto = true

Another thing that can be done is to omit the parser and typechecking part of gluon and instead only load precompiled bytecode in the distributed executable. Currently it is a bit too complicated to omit the main gluon crate (which includes all the crates) for it to be usable though.

... plan to decrease Gluon's size in the future?

To answer the question directly. I have no specific plans to reduce the size other than normal clean ups (like the ones mentioned in the previous comment) as there are still a lot of features that needs implementing. In the long run though, binary size does have some weight though and as long as it does not overly ocmplicate things it is a worthwhile goal.

Great; thanks for the information.
It's nothing I expect you to figure out for me, but FYI, when I use LTO while linking with Gluon, I actually get a slightly larger binary (4.9 MB vs 4.8 MB).

Tried compiling the simplest possible program with gluon.
hello world (no gluon included) // 450kb
hello world + gluon // 4.5 Mb
hello world + gluon + lto // 4.5 Mb (a few kilobytes reduction)
hello world + gluon + lto + strip // 3.5 Mb

So a little under 1Mb of gluon is debug symbols (which is not included in lua's 300 kb) making gluon's current size about 3.2 Mb.
The fact that LTO does not help is weird though, while I may have overestimated its impact (a bunch of code is likely generic code which never gets instantiated and so never even gets passed to LLVM) I still expect it to remove at least a few hundred kilobytes...

Setting -C panic=abort reduces the size with another 5 Mb (to 3.0 Mb) making gluon about 2.7 Mb (hello world is 323 kB with the same settings)

cc  https://github.com/lalrpop/lalrpop/issues/304

Ran try_gluon through https://github.com/google/bloaty. Symbol sizes here if anyone is interested http://termbin.com/7vsb. Seems to be some monomorphization bloat in gluon_check but it seems a bit tricky to fix (but not impossible I don't think).

Tried to track downs some more redundant monomorphizations using bloaty and cargo-bloat. Didn't find that much but the binary size of a panic=abort binary is now down to 1.86 Mb (Windows .dll) .
https://docs.google.com/spreadsheets/d/1Wqae6MQLBtI_s1KnuaXpp3uIXZ2gsvTQmxzsjjzQhIc/edit?usp=sharing


It is ready for testing?

Hi,
That's look like a stunning project. Is this already stable for testing? And what that's with the "Engine @ 8ce2d29".
Best regards

Not at the moment. There's still a lot of work that needs doing, especially with the various file formats that the game uses.

thanks for the update. Looking forward to a release 👍

Hello! Definitely keen to see this come back in some shape or form! Is this still active?

Hey, sorry for the late reply! It's not inactive but it's not really active right now either. There isn't a ton of stuff I can do until I get around to reversing the mesh/texture file formats, and I'm a little busy with some personal stuff at the moment, so there won't be much here until that changes (and I'm not sure when that will be).

Hey, sorry for the late reply! It's not inactive but it's not really active right now either. There isn't a ton of stuff I can do until I get around to reversing the mesh/texture file formats, and I'm a little busy with some personal stuff at the moment, so there won't be much here until that changes (and I'm not sure when that will be).

Hey! No worries at all, hope you’re well and healthy. Will be interesting to see how you do when you come back to it. Definitely a memorable game.

Hi, I created an account just for this thread. I was wondering of this project was still active? Would love for someone just make this a playable game for everyone again.

Yeah I'm actively working on it right now

Hey Alex,
Brilliant news. Best of luck with it! I’ve just had the email notification
so not seen the GitHub recently but I’m excited to see what you get up to.
I’d offer to help but I could only realistically offer my video editing
skills if you need videos made etc
Again, enjoy and all the best.
On Fri, 11 Mar 2022 at 12:11 am, Alex @.***> wrote:

Yeah I'm actively working on it right now
—
Reply to this email directly, view it on GitHub
https://github.com/ThemeParkWorld/OpenTPW/issues/1#issuecomment-1064641805,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ATJ6QNRPYP6PCSTMDBEBHCDU7KFSPANCNFSM4PGAP5AQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you commented.Message ID:
@.***>

--
Kind Regards,
Ben Glasgow
www.BenGlasgow.co.uk

I'm going to move this issue to a discussion because I think it's more fitting than having an issue like this open - issues are really just for bug reports. I think eventually I'll also start a second discussion thread with some screenshots and progress (once there's some decent progress to show off)..


Long delay before OnVideoSendStatusChange is invoked for 1:1-calls

Description
When setting up a 1:1-call it takes very long before the OnVideoSendStatusChanged event is raised to notify that the video sending has become active.
Expected
The OnVideoSendStatusChanged event to be raised within 1 second just like it does when setting up a call to a meeting or setting up a group-call.
Actual
The OnVideoSendStatusChanged event is raised exactly 5 seconds after the call has been answered.
Additional information
This 5 seconds delay is present when the Bot service runs in the Azure cloud and is very consistent. When the same service is run locally and a local Teams client is called, the OnVideoSendStatusChanged event is raised almost instantly after the call has been answered.
We know that the video is routed differently for meetings/group-calls and 1:1-calls. The former are always routed via Microsoft Turn servers and the 1:1-calls are attempted to be sent directly to the endpoint using the ICE-protocol. Tracing the communication showed us that the video is sent directly from the Bot service to the endpoint for the 1:1-calls, so the ICE-protocol did successfully find a direct route without a Turn server). Because the delay is so consistent it looks like a time-out on the ICE-protocol, while a direct route is already available.
This issue does not only occur when calling a Teams client in our environment/tenant, but also at all our (>500) customers.
Another interesting observation is that the two-way audio path is open almost instantly after the call answer.
Code snippet
The video socket settings are created using the following code:
new VideoSocketSettings
                {
                    StreamDirections = StreamDirection.Sendrecv,
                    ReceiveColorFormat = VideoColorFormat.H264,
                    MediaType = MpMediaType.Video,
                    SupportedSendVideoFormats = new List<VideoFormat>()
                    {
                        VideoFormat.H264_1920x1080_30Fps,
                        VideoFormat.H264_1920x1080_15Fps,
                        VideoFormat.H264_1280x720_30Fps,
                        VideoFormat.H264_1280x720_15Fps,
                        VideoFormat.H264_960x540_30Fps,
                        VideoFormat.H264_640x360_30Fps,
                        VideoFormat.H264_640x360_15Fps,
                        VideoFormat.H264_424x240_15Fps,
                        VideoFormat.H264_320x180_15Fps,
                    },
                    MaxConcurrentSendStreams = 1,
                    CroppingMode = CroppingMode.FitToFrame,
                }

NuGet Versions

Microsoft.Skype.Bots.Media <IP_ADDRESS>9-alpha
Microsoft.Graph.Communications.Calls.Media <IP_ADDRESS>04
Microsoft.Graph 4.42.0

Can't say too much about the video socket and timing relating to that. What here's what I do know:
Running local media bots in a location separate to the calls hosting region adds substantial delay to answering calls. Upwards of 5-10 seconds.
Are you running your bot in a location close to the calls media hosting region? You can check the location as part of the ICall resource properties.

@rvleeuwen256 Can you please share a call-id? Thanks.

@rvleeuwen256 Can you please share a call-id? Thanks.

Hello ssulzer,
The following is a call made with the Bot framework to a native Windows desktop client.
Teams call Id: 5a1f5c00-4496-4c7f-a31a-c2851f92ca3f
CallChainId: 26b8c090-100a-4da1-bcde-fe9daaf20b24
Just for convenience I've added a description of the events that happened for this call according to our logging:
Answer of call creation: 2023-08-01 14:12:29.364
Comm event 'Establishing': 2023-08-01 14:12:29.411
OnAudioSendStatusChanged Active: 2023-08-01 14:12:40.717
Comm event 'Established': 2023-08-01 14:12:40.960
OnVideoSendStatusChanged Inactive: 2023-08-01 14:12:46.035
OnVideoSendStatusChanged Active: 2023-08-01 14:12:46.036
The 'Establishing' comm event is received very quickly (50 ms) after the call has been created. The AudioSendStatus is set to Active even before the 'Established' event has been received. Then it takes 5,075 seconds before the VideoSendStatus is set to Inactive and 1 ms later another event is raised to set the status to Active.

We investigated the issue further and found out that it was caused by the firewall that runs on the VM.
Using the verbose logging of the media platform and WireShark traces we found out that (contrary to what we thought) there was no direct media connection between the bot and the Teams client. The Stun binding requests that are sent from the Teams client to the bot during the Ice path discovery were blocked by the firewall. As a result the media path over a Microsoft Turn server was chosen, which immediately routes the audio, but waits a 5 seconds time-out before starting to route the video (obviously expecting a media direct connection will be found soon).
By adding an ‘allow’ firewall rule for the Udp protocol for the ‘media port range’ provided during the media platform initialization a direct media connection could be established which resulted in video in the Teams client in about 1 second.


odd and surprising things discovered while writing DNS records

I was adding dns records to my crawler and ran across a few odd things:
from io import BytesIO
from warcio.warcwriter import WARCWriter

payload = '''\
20170509000739
google.com. 10 IN A <IP_ADDRESS>
google.com. 10 IN A <IP_ADDRESS>
google.com. 10 IN A <IP_ADDRESS>
'''

payload = payload.encode('utf-8')

with open('test_dns.warc', 'wb') as f:
    writer = WARCWriter(f, gzip=False)

    # oddness #1 -- programming error leads to negative Content-Length
    # (error is that dns things are 'resource' not 'response' according to WARC 1.0 standard)
    # recommend: raising an exception for negative Content-Length
    record = writer.create_warc_record('dns:www.google.com', 'response', payload=BytesIO(payload),
                                       warc_content_type='text/dns')
    writer.write_record(record)

    # surprise #2 -- if I don't specify length=, I get a length of 0.
    # recommend: this should just work
    record = writer.create_warc_record('dns:www.google.com', 'resource', payload=BytesIO(payload),
                                       warc_content_type='text/dns')
    writer.write_record(record)

    # specify length, this one looks OK
    record = writer.create_warc_record('dns:www.google.com', 'resource', payload=BytesIO(payload),
                                       warc_content_type='text/dns', length=len(payload))
    writer.write_record(record)

Do you think either is worth patching? Or am I using it wrong? Should it also have thrown an exception for oddness #1 because the library expected to find http headers in the payload and didn't?

Yes, both 1) and 2) are bugs and should be fixed. I've seen DNS records stored as both resource and response, though i think WARC 1.0 recommends that they be stored as resource records.
The length computation should also work automatically.

Will add a fix and more test cases for this shortly, thanks for submitting.


Prater logs - Attestation process log hide roots

When chain processes an attestation it logs
2021-03-23 15:24:05 [CHAIN]           debug: Attestation processed slot=75, index=5, targetRoot=0x8e30967b30b0128ec3c23899738f2d8496986caf0fd5cceeb5042268a1df3ce0, aggregationBits=0xfbffbfffffffffffffeffeffffffff7f03
The targetRoot and aggregationBits are not actionable information and clutter the logs. Can we remove it?

Gossip logs have been reviewed already


[Blockly][UI] adjust image of sensebox while compiling

The image should depend on the chosen sensebox model, just like the background image

I suggest, a small white Window (for better contrast) which stays open after the download until closed. It could show

the description of the down and upload process depend on the selected board type like @PaulaScharf and @verena-witte  suggested
additional links to information like resetting the MCU-S2 after using micropython (see https://docs.sensebox.de/docs/misc/circuitpython_esp32/)
the better error messages done by @Thiemann96 if the download failed.

My experience with students who are often new to blockly and senseBox suggests, that blockly needs a clearer description of what is going on and expected from the user to do after the download. As I am not a real web dev i will just leave this here for now.


How do I get the real ip?

I set app.proxy = true but sometimes I still get someone with ctx.ip = "127.0.0.x"

sometimes or always?
2015-11-19 11:38 GMT+08:00 Alisson Cavalcante Agiani <
<EMAIL_ADDRESS>
I set app.proxy = true but sometimes I still get someone with ctx.ip =
"127.0.0.x"
—
Reply to this email directly or view it on GitHub
https://github.com/koajs/koa/issues/599.

always when someone is behind a NAT

this is what https://github.com/jshttp/proxy-addr is for, which i haven't had to implement. PR would be welcomed.  https://github.com/koajs/koa/issues/281

So getting the last ip of ctx.ips is not enough?

This seems to be working for returning the real ip:
const current_ip = ctx.ips.length > 0 ? ctx.ips[ctx.ips.length - 1] : ctx.ip;

the client's ip should be first, check out https://en.wikipedia.org/wiki/X-Forwarded-For

I know, I want the last ip because it is returning LAN ips

There's a problem using koa over nginx server, when I force X-Forwarded-For in the request.
An  X-Forwarded-For header requested by client overwrites this.request.ip. This is a critical security issue.
Found the problem in line 381 of koa/lib/request.js
https://github.com/koajs/koa/blob/master/lib/request.js#L381
It's better use X-Real-IP over X-Forwarded-For.

real_ip_header    X-Forwarded-For? supporting two sounds annoying to me, why not use the more common one?

Thats because NginX appends external request's X-Forwarded-For value to final header but clears external X-Real-IP header and gets it right with far end's value.

hmm yea I suppose it depends how nginx is configured, though if you have X-Real-IP you might as well just clobber X-Forwarded-For to ensure it's correct

If your koa app behind a nginx, you must add 'proxy_set_header        X-Forwarded-For $remote_addr' to the nginx proxy conf.

I just found that you can spoof an IP address on the standard configuration of nginx. And I happen to whitelist payment servers on my webhook by an IP address.
I agree with @jgdev, this is a critical security issue and should be fixed.

in nginx:
location / {
proxy_pass http://test; proxy_set_header Host $host:$server_port;
proxy_set_header X-Real-IP $remote_addr;
proxy_set_header X-Real-PORT $remote_port;
proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for;
}
in node koa:
app.proxy = true;
ip = ctx.ip;

in nginx:
location / {
proxy_pass http://test; proxy_set_header Host $host:$server_port;
proxy_set_header X-Real-IP $remote_addr;
proxy_set_header X-Real-PORT $remote_port;
proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for;
}
in node koa:
app.proxy = true;
ip = ctx.ip;

for me this worked plus
ip = ctx.request.ip;

I had the same problem but resolved it by using this module found on NPM request-ip
in koa it can be simply used userIp = requestIp.getClientIp(ctx.request)
The user ip is determined by the following order:
X-Client-IP
X-Forwarded-For (Header may return multiple IP addresses in the format: "client IP, proxy 1 IP, proxy 2 IP", so we take the the first one.)
CF-Connecting-IP (Cloudflare)
Fastly-Client-Ip (Fastly CDN and Firebase hosting header when forwared to a cloud function)
True-Client-Ip (Akamai and Cloudflare)
X-Real-IP (Nginx proxy/FastCGI)
X-Cluster-Client-IP (Rackspace LB, Riverbed Stingray)
X-Forwarded, Forwarded-For and Forwarded (Variations of #2)
req.connection.remoteAddress
req.socket.remoteAddress
req.connection.socket.remoteAddress
req.info.remoteAddress

If an IP address cannot be found, it will return null.


Leaflet view blank on Drupal 8

How to reproduce

Leaflet version I'm using: Latest
Browser (with version) I'm using: Chrome
OS/Platform (with version) I'm using: Windows 10

What behaviour I'm expecting and which behaviour I'm seeing
I am working with drupal vm. I use geofield to display leaflet location. While the content by itself is displaying properly, the view which shows all map locations is coming blank. While debugging, I see that the js file is not being detected. Is there something specfic i need to do? I just activated the module using drush
Minimal example reproducing the issue

[ ] this example is as simple as possible

Using http://playground-leaflet.rhcloud.com/ or any other jsfiddle-like site.

Hi, and thanks for taking the time to open a bug report in Leaflet.
However, in this repository we only handle bugs in "vanilla" Leaflet. This means that we do not handle bugs which are specific to frameworks such as:

React
Ractive
AngularJS
Leaflet for R
Joomla
Wordpress
Ionic
Cordova
Vue
Electron
Polymer
...etc

Please understand that we only have the time and energy to test Leaflet in plain web browsers.
Please try to either reproduce the bug without using any frameworks, or submit a bug to the appropiate repo.

But this has been used and tested on drupal 7 for years. It is just not working on D8

Once again: this is for stand-alone Leaflet. I do not care about Drupal. Bugs for the drupal-leaflet interaction go in https://www.drupal.org/project/issues/leaflet .


Set default icon size to 24dp

According to Material Design guidelines, system icons are 24dp

👀

Good improvement!
Awesome 👍

@DVDAndroid Hi! I uploaded latest version 1.9.
Thanks for contribution!