Question: How can I use the carousel with server side rendering?

Please suggest how to use with Vue SSR.
I am trying to integrate this with VueJS's framework Nuxt.js
import Vue from 'vue'
if(process.BROWSER_BUILD) {
    const VueCarousel = require('vue-carousel');
    VueCarousel.default.install(Vue)
}

I am getting this

vue.runtime.common.js:521 [Vue warn]: The client-side rendered virtual DOM tree is not matching server-rendered content. This is likely caused by incorrect HTML markup, for example nesting block-level elements inside , or missing . Bailing hydration and performing full client-side render.

Although I am able to make it work in dev mode, regardless of the warning.
On production mode vue-carousel doesn't work and doesn't show images at all.

Please suggest.

Hi @rohitpal99
I haven't worked with Nuxt.js before, I currently use this carousel in a SSR environment very similar to this one without any issues. Looking for help from anybody who can investigate with Nuxt.

+1

I'm having the exact same issue. Using
if (process.browser) {
  const VueCarousel = require('vue-carousel')
  VueCarousel.default.install(Vue)
}

to make the carousel globally available but indeed receiving the same warning when actually using it.

I am using this plugin with Vue and Nuxt too. @royscheeren, I am implementing it as a plugin with {src: '~plugins/vue-carousel.js', ssr: false}, in the nuxt.config.js file and with
import Vue from 'vue';
import VueCarousel from 'vue-carousel';

Vue.use(VueCarousel);

However, I indeed receive the same error.

Is there anyone working on this issue? I would love to solve it myself but I do not really know where to start.

Are you importing vue-carousel in any of your files? I've managed to get this working.
I added a vue-carousel.js file to the plugins folder, and then in my nuxt config folder { src: '~plugins/vue-carousel.js', ssr: false }
and inside my vue-carousel.js folder I just have
import Vue from 'vue';
import VueCarousel from 'vue-carousel';

Vue.use(VueCarousel);

I was trying to import the carousel which was breaking my build, however the plugin is available to use globally if installed in this way ^^

I solved it by:
// nuxt.config.js
plugins: [{ src: '~/plugins/carousel', ssr: false }],

// plugins/carousel.js
import Vue from 'vue'
import { Carousel, Slide } from 'vue-carousel'

Vue.component('carousel', Carousel)
Vue.component('slide', Slide)

Hope it helps!

@dieguezz you will still have error in console, what are you talking about?

@iamdubx That just worked for me, without messages in console. Maybe your problem is in another place, or i got something different which i forgot to mention (Like nuxt.js version or something but i dont think so). Anyway i am not using this plugin anymore, i made my own component because its a really simple feature.
Sorry if that does not help much..

@toddlawton I'm also working with Vue's native SSR (similarly to you, based also off of HN2.0 example) and am wondering how you managed to import it conditionally? Currently if setting up as the guide/examples show us to, I run into the following errors (server-side):
 ReferenceError: document is not defined
    at r (project/node_modules/vue-carousel/dist/vue-carousel.min.js:6:2155)
    at a (project/node_modules/vue-carousel/dist/vue-carousel.min.js:6:1986)
    at e.exports (project/node_modules/vue-carousel/dist/vue-carousel.min.js:6:3392)
    at Object.<anonymous> (project/node_modules/vue-carousel/dist/vue-carousel.min.js:6:947)
    at t (project/node_modules/vue-carousel/dist/vue-carousel.min.js:6:332)
    at VueComponent.a (project/node_modules/vue-carousel/dist/vue-carousel.min.js:6:786)
    at callHook (project/node_modules/vue/dist/vue.runtime.common.js:2663:21)
    at VueComponent.Vue._init (project/vue/dist/vue.runtime.common.js:4220:5)
    at new VueComponent (project/node_modules/vue/dist/vue.runtime.common.js:4394:12)
    at createComponentInstanceForVnode (project/node_modules/vue-server-renderer/build.js:6817:10)

@dieguezz I am pretty sure you are not telling the whole picture. It has nothing with Nuxt version. To get rid of warning you need to load plugin on mounted. You will have warning 100% in other case.

Hi.
Just tested with nuxt as it still gives errors, and it should give.. because it uses Browser only function like ( document and window )
To load the plugin in "mounted" is to bypass the server render, see: https://nuxtjs.org/guide/plugins
An easy solution is to use "no-ssr": https://github.com/egoist/vue-no-ssr and load the plugin as nuxt docs.
Of course all this solutions are not for server rendering, so seo will be hurt.
It would be nice to see this great plugin to work in full SSR.

I think the issue is that this.$isServer is undefined during render in nuxt. Because the guard is !this.$isServer, the code in those blocks continues to run. I think an option would be to use typeof(this.$isServer) !== 'undefined' && this.$isServer === true.
I think the best option is to set isServer as a prop with the default set to false. Then the user can decide what conditions they want to treat as "isServer".

I initially missed @sainf's recommendation, but indeed the answer to this thread appears to be the following:
// plugins/vue-carousel.js
import Vue from 'vue';
import VueCarousel from 'vue-carousel';

Vue.use(VueCarousel);

// nuxt.config.js
{
...
  plugins: [ '~/plugins/vue-carousel' ],
...
}```

```js
// e.g. pages/index.vue
<template>
<no-ssr>
  <carousel>
    <slide v-for='i in 10' :key='i'>Slide {{ i }}</slide>
  </carousel>
</no-ssr>
</template>

A couple points – I didn't specify ssr: false in nuxt.config.js and that's because while it's true that vue-carousel should not be used in SSR mode, it actually needs to be wrapped in a no-ssr component which appears to take a higher precedence.

I added  plugins: [{src: '~/plugins/vue-carousel.js', ssr: false}], in nuxt.config.js to force nuxt not to use ssr on this component, nu need to use <no-ssr>

I solved it by:
// nuxt.config.js
plugins: [{ src: '~/plugins/carousel', ssr: false }],

// plugins/carousel.js
import Vue from 'vue'
import { Carousel, Slide } from 'vue-carousel'

Vue.component('carousel', Carousel)
Vue.component('slide', Slide)

Hope it helps!

Its the solution for Nuxt.js ....

there were 2 prs open for making ssr possible but issues were closed for both without merging... why is that?
https://github.com/SSENSE/vue-carousel/pull/577
https://github.com/SSENSE/vue-carousel/pull/459


How does Fuzzy CRF work during decoding?

Hi, I'm just curious about the decoding process of Fuzzy CRF.
The paper said "For inference, we apply the Viterbi algorithm to maximize the score." But the original Viterbi algorithm only select one path with the highest score, In the multi-label classification problem, there may be multi valid path, so how to decide the number of the paths.. Is there any threshold or something other in the decoding process. Since unfamiliar with C++, I cant find the decoding process in the repository.
Looking forward your answer, thank you!

Any update on this?

Oh, I made a  mistake. The author proposed Fuzzy-CRF but didn't aims to solve multi-label sequence labeling problem, the final output of the Fuzzy-CRF still have only one path. This answer on stackoverflow misled me. The so-called fuzzy-CRF can't handle multi-label sequence labeling and is not specifically proposed to solve this problem. Sorry for disturb you!

Oh, I made a  mistake. The author proposed Fuzzy-CRF but didn't aims to solve multi-label sequence labeling problem, the final output of the Fuzzy-CRF still have only one path. This answer on stackoverflow misled me. The so-called fuzzy-CRF can't handle multi-label sequence labeling and is not specifically proposed to solve this problem. Sorry for disturb you!


[Bug] application/octet-stream response results in None rather than file download

Describe the Bug
I struggle to find any documentation on how to download file from SDK but after some time I narrowed it down to response: file internal format (https://github.com/fern-api/fern/issues/1546, https://github.com/fern-api/fern/commit/0da146fd63a73a5d0d20695cc5d6bf4a27316907), which I think should correspond to OpenAPI format:
"responses": {
  "200": {
    "description": "Stream the file in original format.",
    "content": {
      "application/octet-stream": {}
    }
  }
}

However, the generated Python code returns None. I know that SDK generator for Python is capable of producing an iterator on the streamed bytes:
https://github.com/fern-api/fern/blob/8fbd7084d46e2f1b5c5e1071fb9810afa710a6fe/seed/python-sdk/file-download/src/seed/service/client.py#L15
and that this is generated here:
https://github.com/fern-api/fern/blob/8fbd7084d46e2f1b5c5e1071fb9810afa710a6fe/generators/python/src/fern_python/generators/sdk/client_generator/endpoint_response_code_writer.py#L269
and I suppose that the OpenAPI parsing is defined in:
https://github.com/fern-api/fern/blob/7c2a8ea70d845d49d4af05344482878003526cee/packages/cli/openapi-parser/src/openapi/v3/converters/endpoint/convertResponse.ts#L192-L206
https://github.com/fern-api/fern/blob/7c2a8ea70d845d49d4af05344482878003526cee/packages/commons/core-utils/src/mediaType.ts#L105-L107
I do not see an obvious bug here, except for the documentation being absent. https://github.com/fern-api/fern/commit/0da146fd63a73a5d0d20695cc5d6bf4a27316907 is tagged as included since 0.16.37 so it does not look like a problem of using an old version, that said I do not really know this as I could not find a useful changelog.
Any hints as to why it does not work?
Information to Reproduce
CLI Version
0.22.0
Generator Version
1.4.0-rc3
API Definition
The minimal OpenAPI specification or Fern definition required to reproduce the bug.
"/api/tools/file/raw-data": {
  "get": {
    "summary": "Get Raw File Data",
    "operationId": "get_raw_file_data_api_v0_tools_file_raw_data_get",
    "parameters": [
      {
        "required": true,
        "schema": {
          "title": "Document Id",
          "type": "string"
        },
        "name": "document_id",
        "in": "query"
      }
    ],
    "responses": {
      "200": {
        "description": "Stream the file in original format.",
        "content": {
          "application/octet-stream": {}
        }
      }
    },
    "x-fern-sdk-group-name": "tools",
    "x-fern-availability": "beta",
    "x-fern-audiences": ["public"],
    "x-fern-sdk-method-name": "raw_data"
  }
}

Actual SDK
The buggy SDK that is produced:
# client.py

def raw_data(self, *, document_id: str, request_options: typing.Optional[RequestOptions] = None) -> None: # <-------- This part is buggy

Expected SDK
The expected SDK
# client.py

def raw_data(self, *, document_id: str, request_options: typing.Optional[RequestOptions] = None) -> typing.Iterator[bytes]:

Additional Context
None

Is there a test case for file_download starting from OpenAPI rather than from fern internal format?

@krassowski I cannot reproduce this, can you upgrade your Fern CLI version (fern upgrade) and regenerate the SDK?
We have this same config working in a few different places today

Upgrading to 0.39.1 fixed it, thanks!


Support running on multiple devices simultaneously

The very basic version was done in #253. The logging output is a mess though because logs from all devices on which tests are being run are cluttered together. And probably more problems exist that we're not aware of yet - this feature (of running on many devices simultaneously) was barely tested.
That said, I'm pretty sure that this issue can be closed. We've proved that it is possible. Let's open a new issue if we want to continue working on this feature.


Non-nullable types support for TypeScript 2.0

Since a new version of TypeScript with --strictNullCheck will be released soon it would be cool to have support for this in Immutable.js typings.
https://github.com/Microsoft/TypeScript/pull/7140

Something like this? #919

#919 was merged, but this only fixes the closure parameters. The remaining issue is with the return types:
listOfNumbers.get(5) // returns 5, should return 5 | undefined

What work is involved to get this done? Is it simply a case of updating the type definitions?

This might get tricky because arrayOfNumbers[index] has type number even if arrayOfNumbers is number[] (!), and this is intentional (https://github.com/Microsoft/TypeScript/issues/9235) although it's at least quite controversial if you ask me.
const array: number[] = [];

array[5000] = 5;

const a = array[0]; // a is a `number`, not `number | undefined` !!!
a.forEach(v => { /* v has `number` type but can have `undefined` value! */ } );
a.map(v => { /* v has `number` type but can have `undefined` value! */ } );
// ...

So one has to decide should Immutable.js mimic this behavior or should it have more type safety?
If we choose type safety then which way? Make all methods like forEach, find, map, sortBy, ... to go with T | undefined for values? mapper: (v: number | undefined, k: number | undefined) => M for Set<number>? Does it make any sense? What about toArray() and toObject()?
Or should we instead change all mutation methods which may potentially introduce undefined values to return List<T | undefined>? Like set, setSize, or List constructor:
function of<T>(...values: T[]): List<T>;
function List<T>(): List<T>;
function List<T>(array: Array<T>): List<T | undefined>;

interface List<T> extends Collection.Indexed<T> {
    // ...
    push(...values: T[]): List<T>; // push can't add undefined values, so we keep List<T> type
    set(index: number, value: T): List<T | undefined>; // can't guarantee that new list won't have undefined values
    setSize(size: number): List<T | undefined>; // can't guarantee that new list won't have undefined values
}

I don't know...

So one has to decide should Immutable.js mimic this behavior or should it have more type safety?

Interestingly, TypeScript's built-in signature for ES6 Map and Set does include undefined in the get signature: https://github.com/Microsoft/TypeScript/blob/445421b68b23a3fcb1a64d9541f31b5e0131ed34/src/lib/es2015.collection.d.ts#L5

All of this looks quite messy to me. For example, forEach of Javascript array and forEach of Immutable.js List have different semantics:
const array: number[] = [];
array[3] = 5;
array.forEach(v => console.log(v));
// Output:
// 5

vs
const list = List<number>().set(3, 5);
list.forEach(v => console.log(v));

// Output:
// undefined
// undefined
// undefined
// 5

I don't see a particularly good way to make it both null-safe and not annoying to use in real life.  Any ideas?

Another issue: Immutable.js is using .d.ts file to build documentation by using custom TypeScript syntax processor which is based on TypeScript version 1.3 embedded into the source tree (https://github.com/facebook/immutable-js/blob/master/pages/third_party/typescript/package.json). Obviously it breaks down when I add | undefined types because TS 1.3 doesn't even support union types yet! Just plugging in modern TS 2.1 won't simply work because doc generator is based on TypeScript.SyntaxWalker which apparently has been removed from TS (https://github.com/Microsoft/TypeScript/issues/1728).
TL;DR: you can't just upgrade typings with union types, non-nulls, tuple types, this types, etc. without breaking documentation generation.

Looks like a lot of this is already in git and not released, noticed thanks to https://github.com/facebook/immutable-js/issues/1034

New type definitions are almost done, and will be released soon!

@leebyron What does "soon" mean in this context?  I'm getting TS compiler errors because the definition for predicates have nullable parameters, when in reality they don't.  If a release is coming in a day or two, I'll wait.  If not, I'll have to figure out a way to manually bring the updated definitions into my project.


Update materialized-view.md

Updated header

@EdPrice-MSFT : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Testing strategies for quirrel

I was working on the dependabot upgrade for quirrel (#811), and I was not 100% sure how to test.
I can access the quirrel's console via http://localhost:9181/. I tried clicking "invoke" on a job to clear unverified accounts, but I was unable to verify that the job worked (I was still able to log in with the unverified account).

I had several instances where I was not able to use quirrel's web interface. Instead, I had to go to the API endpoints manually (e.g., http://localhost:3000/api/weekly-digest-mailer)

Thanks @nsunami!
Invoking the jobs would result in console output - also if there's an error. Sometimes I add some minor logging if there's something specific I need to test.
I believe quirrel is primarily being maintained - I always double check what actually changed. Most of the time it isn't much.
Does something like this help you?

Thank you for the input!  @chartgerink
I think the best approach for testing quirrel may be:

invoke jobs and check conole output
check the test app deployment works

Would that be good for now?

Yes that works - sorry for the immense delay on this. Adding this to the wiki as well and closing this issue as it is stale :)


HBASE-28622 FilterListWithAND can swallow SEEK_NEXT_USING_HINT

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 35s
Docker mode activated.

-0 :warning:
yetus
0m  2s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 10s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 33s
master passed

+1 :green_heart:
compile
1m  2s
master passed

+1 :green_heart:
shadedjars
5m 10s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 42s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

-1 :x:
mvninstall
0m 46s
root in the patch failed.

-1 :x:
compile
0m 32s
hbase-server in the patch failed.

-0 :warning:
javac
0m 32s
hbase-server in the patch failed.

-1 :x:
shadedjars
2m 16s
patch has 11 errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 37s
the patch passed

_ Other Tests _

-1 :x:
unit
0m 20s
hbase-client in the patch failed.

-1 :x:
unit
0m 33s
hbase-server in the patch failed.

16m 55s

Subsystem
Report/Notes

Docker
ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5955/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5955

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 3863ef80ed80 5.4.0-174-generic #193-Ubuntu SMP Thu Mar 7 14:29:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / a16f45811e

Default Java
Temurin-1.8.0_352-b08

mvninstall
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5955/1/artifact/yetus-jdk8-hadoop3-check/output/patch-mvninstall-root.txt

compile
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5955/1/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-server.txt

javac
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5955/1/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-server.txt

shadedjars
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5955/1/artifact/yetus-jdk8-hadoop3-check/output/patch-shadedjars.txt

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5955/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-client.txt

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5955/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5955/1/testReport/

Max. process+thread count
64 (vs. ulimit of 30000)

modules
C: hbase-client hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5955/1/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 13s
Docker mode activated.

-0 :warning:
yetus
0m  2s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 33s
master passed

+1 :green_heart:
compile
1m 17s
master passed

+1 :green_heart:
shadedjars
5m 13s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 46s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for patch

-1 :x:
mvninstall
0m 55s
root in the patch failed.

-1 :x:
compile
0m 42s
hbase-server in the patch failed.

-0 :warning:
javac
0m 42s
hbase-server in the patch failed.

-1 :x:
shadedjars
2m 19s
patch has 11 errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 46s
the patch passed

_ Other Tests _

-1 :x:
unit
0m 23s
hbase-client in the patch failed.

-1 :x:
unit
0m 43s
hbase-server in the patch failed.

18m 38s

Subsystem
Report/Notes

Docker
ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5955/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5955

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux b762640fcb6e 5.4.0-182-generic #202-Ubuntu SMP Fri Apr 26 12:29:36 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / a16f45811e

Default Java
Eclipse Adoptium-17.0.10+7

mvninstall
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5955/1/artifact/yetus-jdk17-hadoop3-check/output/patch-mvninstall-root.txt

compile
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5955/1/artifact/yetus-jdk17-hadoop3-check/output/patch-compile-hbase-server.txt

javac
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5955/1/artifact/yetus-jdk17-hadoop3-check/output/patch-compile-hbase-server.txt

shadedjars
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5955/1/artifact/yetus-jdk17-hadoop3-check/output/patch-shadedjars.txt

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5955/1/artifact/yetus-jdk17-hadoop3-check/output/patch-unit-hbase-client.txt

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5955/1/artifact/yetus-jdk17-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5955/1/testReport/

Max. process+thread count
79 (vs. ulimit of 30000)

modules
C: hbase-client hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5955/1/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  6s
Docker mode activated.

-0 :warning:
yetus
0m  2s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m  1s
master passed

+1 :green_heart:
compile
1m 10s
master passed

+1 :green_heart:
shadedjars
5m 16s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 45s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

-1 :x:
mvninstall
0m 57s
root in the patch failed.

-1 :x:
compile
0m 37s
hbase-server in the patch failed.

-0 :warning:
javac
0m 37s
hbase-server in the patch failed.

-1 :x:
shadedjars
2m 20s
patch has 11 errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 42s
the patch passed

_ Other Tests _

-1 :x:
unit
0m 21s
hbase-client in the patch failed.

-1 :x:
unit
0m 39s
hbase-server in the patch failed.

18m 48s

Subsystem
Report/Notes

Docker
ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5955/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5955

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux b18a666e8b21 5.4.0-174-generic #193-Ubuntu SMP Thu Mar 7 14:29:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / a16f45811e

Default Java
Eclipse Adoptium-11.0.17+8

mvninstall
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5955/1/artifact/yetus-jdk11-hadoop3-check/output/patch-mvninstall-root.txt

compile
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5955/1/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-server.txt

javac
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5955/1/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-server.txt

shadedjars
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5955/1/artifact/yetus-jdk11-hadoop3-check/output/patch-shadedjars.txt

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5955/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-client.txt

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5955/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5955/1/testReport/

Max. process+thread count
77 (vs. ulimit of 30000)

modules
C: hbase-client hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5955/1/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 36s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 55s
master passed

+1 :green_heart:
compile
3m 21s
master passed

+1 :green_heart:
checkstyle
0m 52s
master passed

+1 :green_heart:
spotless
0m 44s
branch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
2m 15s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for patch

-1 :x:
mvninstall
0m 53s
root in the patch failed.

-1 :x:
compile
1m 23s
hbase-server in the patch failed.

-0 :warning:
javac
1m 23s
hbase-server in the patch failed.

+1 :green_heart:
checkstyle
0m 50s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

-1 :x:
hadoopcheck
0m 58s
The patch causes 11 errors with Hadoop v3.3.6.

+1 :green_heart:
spotless
0m 39s
patch has no errors when running spotless:check.

-1 :x:
spotbugs
0m 25s
hbase-server in the patch failed.

_ Other Tests _

+1 :green_heart:
asflicense
0m 17s
The patch does not generate ASF License warnings.

19m 25s

Subsystem
Report/Notes

Docker
ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5955/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5955

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile

uname
Linux d1c632e5711c 5.4.0-174-generic #193-Ubuntu SMP Thu Mar 7 14:29:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / a16f45811e

Default Java
Eclipse Adoptium-11.0.17+8

mvninstall
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5955/1/artifact/yetus-general-check/output/patch-mvninstall-root.txt

compile
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5955/1/artifact/yetus-general-check/output/patch-compile-hbase-server.txt

javac
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5955/1/artifact/yetus-general-check/output/patch-compile-hbase-server.txt

hadoopcheck
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5955/1/artifact/yetus-general-check/output/patch-javac-3.3.6.txt

spotbugs
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5955/1/artifact/yetus-general-check/output/patch-spotbugs-hbase-server.txt

Max. process+thread count
83 (vs. ulimit of 30000)

modules
C: hbase-client hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5955/1/console

versions
git=2.34.1 maven=3.8.6 spotbugs=4.7.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 34s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 44s
master passed

+1 :green_heart:
compile
3m 18s
master passed

+1 :green_heart:
checkstyle
0m 53s
master passed

+1 :green_heart:
spotless
0m 42s
branch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
2m 11s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 47s
the patch passed

+1 :green_heart:
compile
3m 20s
the patch passed

+1 :green_heart:
javac
3m 20s
the patch passed

+1 :green_heart:
checkstyle
0m 53s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
4m 54s
Patch does not cause any errors with Hadoop 3.3.6.

+1 :green_heart:
spotless
0m 42s
patch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
2m 32s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 20s
The patch does not generate ASF License warnings.

32m 26s

Subsystem
Report/Notes

Docker
ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5955/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5955

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile

uname
Linux 1d5d999c2023 5.4.0-174-generic #193-Ubuntu SMP Thu Mar 7 14:29:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / a16f45811e

Default Java
Eclipse Adoptium-11.0.17+8

Max. process+thread count
81 (vs. ulimit of 30000)

modules
C: hbase-client hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5955/2/console

versions
git=2.34.1 maven=3.8.6 spotbugs=4.7.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 11s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m  9s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 47s
master passed

+1 :green_heart:
compile
1m 16s
master passed

+1 :green_heart:
shadedjars
5m 10s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 46s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 48s
the patch passed

+1 :green_heart:
compile
1m 15s
the patch passed

+1 :green_heart:
javac
1m 15s
the patch passed

+1 :green_heart:
shadedjars
5m 17s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 45s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 33s
hbase-client in the patch passed.

-1 :x:
unit
229m 12s
hbase-server in the patch failed.

255m 51s

Subsystem
Report/Notes

Docker
ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5955/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5955

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 482b6e496922 5.4.0-182-generic #202-Ubuntu SMP Fri Apr 26 12:29:36 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / a16f45811e

Default Java
Eclipse Adoptium-17.0.10+7

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5955/2/artifact/yetus-jdk17-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5955/2/testReport/

Max. process+thread count
5512 (vs. ulimit of 30000)

modules
C: hbase-client hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5955/2/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 34s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 24s
master passed

+1 :green_heart:
compile
1m  2s
master passed

+1 :green_heart:
shadedjars
5m 11s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 40s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 27s
the patch passed

+1 :green_heart:
compile
1m  1s
the patch passed

+1 :green_heart:
javac
1m  1s
the patch passed

+1 :green_heart:
shadedjars
5m 16s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 41s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 30s
hbase-client in the patch passed.

-1 :x:
unit
238m  7s
hbase-server in the patch failed.

264m 19s

Subsystem
Report/Notes

Docker
ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5955/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5955

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 4522b6484a9b 5.4.0-174-generic #193-Ubuntu SMP Thu Mar 7 14:29:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / a16f45811e

Default Java
Temurin-1.8.0_352-b08

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5955/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5955/2/testReport/

Max. process+thread count
4760 (vs. ulimit of 30000)

modules
C: hbase-client hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5955/2/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 41s
Docker mode activated.

-0 :warning:
yetus
0m  2s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 58s
master passed

+1 :green_heart:
compile
1m 11s
master passed

+1 :green_heart:
shadedjars
5m 16s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 46s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 48s
the patch passed

+1 :green_heart:
compile
1m 13s
the patch passed

+1 :green_heart:
javac
1m 13s
the patch passed

+1 :green_heart:
shadedjars
5m 18s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 42s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 42s
hbase-client in the patch passed.

-1 :x:
unit
243m 18s
hbase-server in the patch failed.

271m 48s

Subsystem
Report/Notes

Docker
ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5955/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5955

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 7d74624253d0 5.4.0-174-generic #193-Ubuntu SMP Thu Mar 7 14:29:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / a16f45811e

Default Java
Eclipse Adoptium-11.0.17+8

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5955/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5955/2/testReport/

Max. process+thread count
4976 (vs. ulimit of 30000)

modules
C: hbase-client hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5955/2/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 36s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 57s
master passed

+1 :green_heart:
compile
3m 22s
master passed

+1 :green_heart:
checkstyle
0m 54s
master passed

+1 :green_heart:
spotless
0m 44s
branch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
2m 15s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 47s
the patch passed

+1 :green_heart:
compile
3m 24s
the patch passed

+1 :green_heart:
javac
3m 24s
the patch passed

+1 :green_heart:
checkstyle
0m 50s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
4m 50s
Patch does not cause any errors with Hadoop 3.3.6.

+1 :green_heart:
spotless
0m 42s
patch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
2m 29s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 21s
The patch does not generate ASF License warnings.

32m 48s

Subsystem
Report/Notes

Docker
ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5955/3/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5955

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile

uname
Linux 33a3b00e82e9 5.4.0-174-generic #193-Ubuntu SMP Thu Mar 7 14:29:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / a16f45811e

Default Java
Eclipse Adoptium-11.0.17+8

Max. process+thread count
79 (vs. ulimit of 30000)

modules
C: hbase-client hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5955/3/console

versions
git=2.34.1 maven=3.8.6 spotbugs=4.7.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 15s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m  9s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m  1s
master passed

+1 :green_heart:
compile
1m 15s
master passed

+1 :green_heart:
shadedjars
5m 10s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 45s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 49s
the patch passed

+1 :green_heart:
compile
1m 16s
the patch passed

+1 :green_heart:
javac
1m 16s
the patch passed

+1 :green_heart:
shadedjars
5m 13s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 46s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 33s
hbase-client in the patch passed.

+1 :green_heart:
unit
221m 54s
hbase-server in the patch passed.

249m  2s

Subsystem
Report/Notes

Docker
ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5955/3/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5955

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 76a049cbc6db 5.4.0-182-generic #202-Ubuntu SMP Fri Apr 26 12:29:36 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / a16f45811e

Default Java
Eclipse Adoptium-17.0.10+7

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5955/3/testReport/

Max. process+thread count
4976 (vs. ulimit of 30000)

modules
C: hbase-client hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5955/3/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 30s
Docker mode activated.

-0 :warning:
yetus
0m  2s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m  6s
master passed

+1 :green_heart:
compile
1m  6s
master passed

+1 :green_heart:
shadedjars
5m 52s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 40s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 56s
the patch passed

+1 :green_heart:
compile
1m  6s
the patch passed

+1 :green_heart:
javac
1m  6s
the patch passed

+1 :green_heart:
shadedjars
5m 48s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 37s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 38s
hbase-client in the patch passed.

+1 :green_heart:
unit
227m 45s
hbase-server in the patch passed.

256m  8s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5955/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5955

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux b59af1f90992 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / a16f45811e

Default Java
Eclipse Adoptium-11.0.17+8

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5955/3/testReport/

Max. process+thread count
5206 (vs. ulimit of 30000)

modules
C: hbase-client hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5955/3/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 34s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 23s
master passed

+1 :green_heart:
compile
1m  1s
master passed

+1 :green_heart:
shadedjars
5m  9s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 40s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 25s
the patch passed

+1 :green_heart:
compile
1m  1s
the patch passed

+1 :green_heart:
javac
1m  1s
the patch passed

+1 :green_heart:
shadedjars
5m 13s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 16s
hbase-client generated 1 new + 30 unchanged - 0 fixed = 31 total (was 30)

_ Other Tests _

+1 :green_heart:
unit
1m 29s
hbase-client in the patch passed.

+1 :green_heart:
unit
236m  4s
hbase-server in the patch passed.

262m 10s

Subsystem
Report/Notes

Docker
ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5955/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5955

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 97d2baeb4a4e 5.4.0-174-generic #193-Ubuntu SMP Thu Mar 7 14:29:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / a16f45811e

Default Java
Temurin-1.8.0_352-b08

javadoc
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5955/3/artifact/yetus-jdk8-hadoop3-check/output/diff-javadoc-javadoc-hbase-client.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5955/3/testReport/

Max. process+thread count
5088 (vs. ulimit of 30000)

modules
C: hbase-client hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5955/3/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Added more comments, @Apache9 .

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 36s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 42s
master passed

+1 :green_heart:
compile
3m 19s
master passed

+1 :green_heart:
checkstyle
0m 54s
master passed

+1 :green_heart:
spotless
0m 42s
branch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
2m 13s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 44s
the patch passed

+1 :green_heart:
compile
3m 21s
the patch passed

+1 :green_heart:
javac
3m 21s
the patch passed

+1 :green_heart:
checkstyle
0m 51s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
4m 52s
Patch does not cause any errors with Hadoop 3.3.6.

+1 :green_heart:
spotless
0m 46s
patch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
2m 39s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 21s
The patch does not generate ASF License warnings.

32m 52s

Subsystem
Report/Notes

Docker
ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5955/4/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5955

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile

uname
Linux b09450ad96b5 5.4.0-174-generic #193-Ubuntu SMP Thu Mar 7 14:29:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / debb1921ed

Default Java
Eclipse Adoptium-11.0.17+8

Max. process+thread count
82 (vs. ulimit of 30000)

modules
C: hbase-client hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5955/4/console

versions
git=2.34.1 maven=3.8.6 spotbugs=4.7.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 13s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m  9s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 20s
master passed

+1 :green_heart:
compile
1m 24s
master passed

+1 :green_heart:
shadedjars
6m 25s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 13s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 13s
the patch passed

+1 :green_heart:
compile
1m 34s
the patch passed

+1 :green_heart:
javac
1m 34s
the patch passed

+1 :green_heart:
shadedjars
5m 22s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 45s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 32s
hbase-client in the patch passed.

+1 :green_heart:
unit
217m 18s
hbase-server in the patch passed.

247m 32s

Subsystem
Report/Notes

Docker
ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5955/4/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5955

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 76c0a417fae4 5.4.0-182-generic #202-Ubuntu SMP Fri Apr 26 12:29:36 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / debb1921ed

Default Java
Eclipse Adoptium-17.0.10+7

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5955/4/testReport/

Max. process+thread count
5412 (vs. ulimit of 30000)

modules
C: hbase-client hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5955/4/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 52s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 52s
master passed

+1 :green_heart:
compile
1m 10s
master passed

+1 :green_heart:
shadedjars
5m 16s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 44s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 48s
the patch passed

+1 :green_heart:
compile
1m 11s
the patch passed

+1 :green_heart:
javac
1m 11s
the patch passed

+1 :green_heart:
shadedjars
5m 17s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 44s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 41s
hbase-client in the patch passed.

-1 :x:
unit
237m 18s
hbase-server in the patch failed.

265m 51s

Subsystem
Report/Notes

Docker
ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5955/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5955

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 92c8299caafe 5.4.0-174-generic #193-Ubuntu SMP Thu Mar 7 14:29:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / debb1921ed

Default Java
Eclipse Adoptium-11.0.17+8

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5955/4/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5955/4/testReport/

Max. process+thread count
4833 (vs. ulimit of 30000)

modules
C: hbase-client hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5955/4/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 40s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 22s
master passed

+1 :green_heart:
compile
1m 21s
master passed

+1 :green_heart:
shadedjars
7m  6s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 55s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 24s
the patch passed

+1 :green_heart:
compile
1m 21s
the patch passed

+1 :green_heart:
javac
1m 21s
the patch passed

+1 :green_heart:
shadedjars
6m 26s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 15s
hbase-client generated 1 new + 30 unchanged - 0 fixed = 31 total (was 30)

_ Other Tests _

+1 :green_heart:
unit
1m 37s
hbase-client in the patch passed.

-1 :x:
unit
283m 45s
hbase-server in the patch failed.

316m 28s

Subsystem
Report/Notes

Docker
ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5955/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5955

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux ba57fd47427d 5.4.0-174-generic #193-Ubuntu SMP Thu Mar 7 14:29:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / debb1921ed

Default Java
Temurin-1.8.0_352-b08

javadoc
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5955/4/artifact/yetus-jdk8-hadoop3-check/output/diff-javadoc-javadoc-hbase-client.txt

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5955/4/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5955/4/testReport/

Max. process+thread count
4293 (vs. ulimit of 30000)

modules
C: hbase-client hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5955/4/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

I have fixed two bugs in the patch:

The new filterRowKey() logic should not be used when filterAllRemaining() is true
Array out of bounds error when the last filter is a hintingFilter.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 43s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 17s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 51s
master passed

+1 :green_heart:
compile
3m 20s
master passed

+1 :green_heart:
checkstyle
0m 52s
master passed

+1 :green_heart:
spotless
0m 42s
branch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
2m 14s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 51s
the patch passed

+1 :green_heart:
compile
3m 17s
the patch passed

+1 :green_heart:
javac
3m 17s
the patch passed

+1 :green_heart:
checkstyle
0m 53s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
4m 47s
Patch does not cause any errors with Hadoop 3.3.6.

+1 :green_heart:
spotless
0m 41s
patch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
2m 28s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 20s
The patch does not generate ASF License warnings.

32m 59s

Subsystem
Report/Notes

Docker
ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5955/5/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5955

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile

uname
Linux 9cd3641d31ee 5.4.0-174-generic #193-Ubuntu SMP Thu Mar 7 14:29:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 77ae12b8a2

Default Java
Eclipse Adoptium-11.0.17+8

Max. process+thread count
81 (vs. ulimit of 30000)

modules
C: hbase-client hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5955/5/console

versions
git=2.34.1 maven=3.8.6 spotbugs=4.7.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 11s
Docker mode activated.

-0 :warning:
yetus
0m  2s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 26s
master passed

+1 :green_heart:
compile
1m 17s
master passed

+1 :green_heart:
shadedjars
5m 13s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 47s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 49s
the patch passed

+1 :green_heart:
compile
1m 22s
the patch passed

+1 :green_heart:
javac
1m 22s
the patch passed

+1 :green_heart:
shadedjars
5m  8s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 46s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 33s
hbase-client in the patch passed.

+1 :green_heart:
unit
215m 24s
hbase-server in the patch passed.

243m 14s

Subsystem
Report/Notes

Docker
ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5955/5/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5955

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux d5c4545adcd1 5.4.0-182-generic #202-Ubuntu SMP Fri Apr 26 12:29:36 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 77ae12b8a2

Default Java
Eclipse Adoptium-17.0.10+7

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5955/5/testReport/

Max. process+thread count
5005 (vs. ulimit of 30000)

modules
C: hbase-client hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5955/5/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
2m 36s
Docker mode activated.

-0 :warning:
yetus
0m  4s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 54s
master passed

+1 :green_heart:
compile
1m  1s
master passed

+1 :green_heart:
shadedjars
5m 29s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 38s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 42s
the patch passed

+1 :green_heart:
compile
1m  1s
the patch passed

+1 :green_heart:
javac
1m  1s
the patch passed

+1 :green_heart:
shadedjars
5m 29s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 37s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 36s
hbase-client in the patch passed.

+1 :green_heart:
unit
214m 35s
hbase-server in the patch passed.

243m 32s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5955/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5955

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 6495560c099a 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 77ae12b8a2

Default Java
Eclipse Adoptium-11.0.17+8

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5955/5/testReport/

Max. process+thread count
5330 (vs. ulimit of 30000)

modules
C: hbase-client hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5955/5/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 58s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 33s
master passed

+1 :green_heart:
compile
1m  1s
master passed

+1 :green_heart:
shadedjars
5m 12s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 41s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 27s
the patch passed

+1 :green_heart:
compile
1m  2s
the patch passed

+1 :green_heart:
javac
1m  2s
the patch passed

+1 :green_heart:
shadedjars
5m 12s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 16s
hbase-client generated 1 new + 30 unchanged - 0 fixed = 31 total (was 30)

_ Other Tests _

+1 :green_heart:
unit
1m 30s
hbase-client in the patch passed.

+1 :green_heart:
unit
234m 57s
hbase-server in the patch passed.

261m 53s

Subsystem
Report/Notes

Docker
ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5955/5/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5955

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux f45cac171965 5.4.0-174-generic #193-Ubuntu SMP Thu Mar 7 14:29:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 77ae12b8a2

Default Java
Temurin-1.8.0_352-b08

javadoc
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5955/5/artifact/yetus-jdk8-hadoop3-check/output/diff-javadoc-javadoc-hbase-client.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5955/5/testReport/

Max. process+thread count
4861 (vs. ulimit of 30000)

modules
C: hbase-client hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5955/5/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 37s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 41s
master passed

+1 :green_heart:
compile
3m 19s
master passed

+1 :green_heart:
checkstyle
0m 53s
master passed

+1 :green_heart:
spotless
0m 42s
branch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
2m 11s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 43s
the patch passed

+1 :green_heart:
compile
3m 23s
the patch passed

+1 :green_heart:
javac
3m 23s
the patch passed

+1 :green_heart:
checkstyle
0m 53s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
4m 39s
Patch does not cause any errors with Hadoop 3.3.6.

+1 :green_heart:
spotless
0m 43s
patch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
2m 29s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 21s
The patch does not generate ASF License warnings.

32m 13s

Subsystem
Report/Notes

Docker
ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5955/6/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5955

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile

uname
Linux 8fb7971421d7 5.4.0-174-generic #193-Ubuntu SMP Thu Mar 7 14:29:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 13af64dc1c

Default Java
Eclipse Adoptium-11.0.17+8

Max. process+thread count
79 (vs. ulimit of 30000)

modules
C: hbase-client hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5955/6/console

versions
git=2.34.1 maven=3.8.6 spotbugs=4.7.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 29s
Docker mode activated.

-0 :warning:
yetus
0m  2s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 25s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 47s
master passed

+1 :green_heart:
compile
1m  2s
master passed

+1 :green_heart:
shadedjars
5m 30s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 36s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 40s
the patch passed

+1 :green_heart:
compile
1m  2s
the patch passed

+1 :green_heart:
javac
1m  2s
the patch passed

+1 :green_heart:
shadedjars
5m 28s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 37s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 36s
hbase-client in the patch passed.

+1 :green_heart:
unit
214m 38s
hbase-server in the patch passed.

241m 15s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5955/6/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5955

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 6dfee1e17d80 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 13af64dc1c

Default Java
Eclipse Adoptium-11.0.17+8

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5955/6/testReport/

Max. process+thread count
4516 (vs. ulimit of 30000)

modules
C: hbase-client hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5955/6/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 39s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 17s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 28s
master passed

+1 :green_heart:
compile
1m  2s
master passed

+1 :green_heart:
shadedjars
5m 12s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 40s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 25s
the patch passed

+1 :green_heart:
compile
1m  0s
the patch passed

+1 :green_heart:
javac
1m  0s
the patch passed

+1 :green_heart:
shadedjars
5m 14s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 16s
hbase-client generated 1 new + 30 unchanged - 0 fixed = 31 total (was 30)

_ Other Tests _

+1 :green_heart:
unit
1m 30s
hbase-client in the patch passed.

+1 :green_heart:
unit
236m 44s
hbase-server in the patch passed.

262m 39s

Subsystem
Report/Notes

Docker
ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5955/6/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5955

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 08bd8dc564b2 5.4.0-174-generic #193-Ubuntu SMP Thu Mar 7 14:29:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 13af64dc1c

Default Java
Temurin-1.8.0_352-b08

javadoc
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5955/6/artifact/yetus-jdk8-hadoop3-check/output/diff-javadoc-javadoc-hbase-client.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5955/6/testReport/

Max. process+thread count
4774 (vs. ulimit of 30000)

modules
C: hbase-client hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5955/6/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 12s
Docker mode activated.

-0 :warning:
yetus
0m  2s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 18s
master passed

+1 :green_heart:
compile
1m 15s
master passed

+1 :green_heart:
shadedjars
5m 12s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 46s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 47s
the patch passed

+1 :green_heart:
compile
1m 17s
the patch passed

+1 :green_heart:
javac
1m 17s
the patch passed

+1 :green_heart:
shadedjars
5m 14s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 47s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 33s
hbase-client in the patch passed.

-1 :x:
unit
246m 43s
hbase-server in the patch failed.

274m 13s

Subsystem
Report/Notes

Docker
ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5955/6/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5955

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 5e5b1c75c569 5.4.0-182-generic #202-Ubuntu SMP Fri Apr 26 12:29:36 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 13af64dc1c

Default Java
Eclipse Adoptium-17.0.10+7

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5955/6/artifact/yetus-jdk17-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5955/6/testReport/

Max. process+thread count
4663 (vs. ulimit of 30000)

modules
C: hbase-client hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5955/6/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.


Repo.preload is not recursive if one of the intermediary models is already loaded

I'm not exactly sure, if this is a bug, or it was designed like this and I want too much.
But with nested preloads, if one of the models is already loaded, it's child models won't be preloaded.
Example:
I have Post that has many Comments, and each comment belongs to a User.
If I first load post with only comments and without users using:
posts =
  from(p in Post, preload: :comments)
  |> Repo.all

And later try to load the authors for the comments:
posts = Repo.preload(posts, comments: :authors)

The authors won't be loaded.

Yup, bug. :)

Setting ecto sub model manually blocks preload path for that sub model as well.
I am guessing this is maybe what you are saying in: #1212 ?


Add option in fusionConfig to configure jsExtPattern

This might be minimalistic change allowing to experiment or develop with typescript?

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thank you very much for the pull request. Digging into figure out what's going on with the Fusion.js compiler is no easy task 😅
I'm going to leave this open for the time being while I run it by our team. We currently don't use TS internally (yet), but definitely want to help support the community. My suggestion for the time being would be to fork this package and publish it to a registry. I'll try to keep this thread updated with the direction we want to go, or how we're going to support TS in the future.

Good to hear your are open to enable typescript :) Publishing it separately sounds like a good idea for time being :)

@KevinGrandon Hi I have strange observation regarding publishing this package, when I published it as fusion-cli-ts then __DEV__ variable was not injected. I don't know where its injected but for sure not in this repository. My pocking at this problem fond relation of this __DEV__ variable and package name what was quite unexpected by me... package name must end with fusion-cli whether it is @scope/fusion-cli or whatever-fusion-cli... both work but fusion-cli-ts is not ?!

That is truly boggling since we should just inject the __DEV__ variable through a babel plugin, which I don't believe relies on any package name.
It should be this line which registers the plugin: https://github.com/fusionjs/fusion-cli/blob/master/build/get-babel-config.js#L149
What is the error message you're getting? Is it undefined?

I just tried this same thing this morning and had also modify the resolve.extensions array to include .ts and .tsx. Were you able to get this working without doing that?

Resolve extensions are for paths to packages without extensions file, in my testing so far I provided exact path to files so this didn't hit me :D I'll adjust it.
And regarding the __DEV__ and fusino-cli-ts, error is:
$ fusion dev
Using custom Babel config from .fusionrc.js
Warning: custom Babel config is an unstable API and may be not be supported in future releases. Use at your own risk.
(node:20282) DeprecationWarning: Tapable.plugin is deprecated. Use new API on `.hooks` instead
Build completed in 3.313s

Build completed in 3.387s

ReferenceError: __DEV__ is not defined
    at reload (/***/node_modules/fusion-cli-ts/entries/server-entry.js:81:1)
    at process.runNextTicks [as _tickCallback] (internal/process/next_tick.js:47:5)
    at evalScript (internal/process/execution.js:61:11)
    at executeUserCode (internal/bootstrap/node.js:499:5)
    at startMainThreadExecution (internal/bootstrap/node.js:439:3)

I checked the code of this babel plugin you mentioned, but I have no experience in babel api so its hard to say is there a problem... but something somewhere is not right


Inventory desync in fika

Most likely related to grid reordering, but not fully understood why.
Testing shows containers with reordering are out of sync from the start of raid. If host moves things around, the non-host gets in sync and things seem to be ok from there.
Current mitigation is to disable "Standardize Grid Ordering", currently enforced by 3.0.1

Player.log
Croutons Error Line 2122.txt
Rooster Error Line 1929.txt

first error is always a GClass3711 error, has foreign events

Investigation into why grid reordering doesn't work - clients send their inventories to each other as part of the serialized profile, using standard EFT serialization. All items are serialized/deserialized through GClass1685 and friends. Grids in particular end up using GClass1656. Grids and the items within them are serialized in order, with no regard for the actual ID of the grid an item is parented to.
If the grids are reordered, then on connection they are serialized in that new order and deseralized in the original order, and hence the desync.
The fix would be to overwrite the serialization logic to serialize in the original order, but I don't know if I even want to go there.
While this explains the grid reordering issue, this doesn't explain other potential causes of desync that are still being encountered

May be related to grenades?
Repro reported in fika discord has a grid spot that was occupied by a grenade that experienced a "dud throw", and then later the host thought that spot was still full but the client thought it was empty


Welsh localisation: missing OGL icon

OGL icon not currently rendering in footer. Part of #233

Done


Export SAM image encoder to onnx

Thank you for your wonderful work. Would you please provide SAM image encoder as onnx for deploying the whole model on GPU TensorRT? or is it possible to export SAM image encoder as an onnx? Thanks

see the Pull requests, somebody have done this work

https://github.com/facebookresearch/segment-anything/pull/29

hi bro, have you deployed the decoder model on GPU TensorRT successfully ?can you share your experience?


Feature Req: Interaction Sync across Devices w/ BrowserSync-like solution for real time responsive design dev

In the old days before Next.js where Webpack fiddling was expected, there was a way to add BrowserSync to build across multiple devices simultaneously. While we do have hot-reload these days, the Next.js stack does not sync the interactions across devices.
Given the ability to do multi-device UI with a System-UI based CSS approach, it seems ideal to also add this interaction sync.
However even with the recipes given by BrowserSync on their website - the webpack integration does not seem to separate out the build from the interaction sync or any other features. The API surface area seems monolithic.
Is there any other solutions that can be added that does only the interaction sync?
EDIT: As I'm writing this I found this
https://github.com/Applelo/vite-plugin-browser-sync
where you can pass BrowserSync options.
Perhaps this can be spun up in parallel silently in the background with options to disable the compiling/file watching.

Update it works!
vite.config.js in apps/next
import { defineConfig } from 'vite'
import VitePluginBrowserSync from 'vite-plugin-browser-sync'

// https://vitejs.dev/config/
export default {
  server: {
    watch: {
      ignored: ['**/**'],
    },
  },
  plugins: [
    VitePluginBrowserSync({
      bs: {
        ui: {
          port: 8080
        },
        notify: false,
        open: false,
        proxy: "localhost:3000",
        port: 3000
      }
    })
  ]
}

Have yarn dev running in one terminal tab.
Have vite running in another tab (from apps/next directory)
And then just go to localhost:3001 as instructed by Vite which has now wrapped the 3000 port with a vhost and spit it out at 3001.
Use ifconfig | grep inet to find your IP (example: <IP_ADDRESS>:3001 )so you can browse to that on all your devices and have them synced while deving

Update 2:
Q:  How do we get this into a background process so you don't need to spin up two servers explicitly?
A: concurrently "yarn dev" "npx vite" --kill-others
PersonallyI added
"webdev": "cd apps/next && yarn dev-sync"
at the top and
"dev-sync": "concurrently 'yarn dev' 'npx vite' --kill-others" in the apps/next`


feat: Support LIKE … ESCAPE … syntax

This PR backports changes to sqlparser-rs that incorporate ESCAPE support for LIKE, ILIKE, SIMILAR TO expressions, and their negated counterparts.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

133 of 173 (76.88%)  changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.3%) to 89.546%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

tests/sqlparser_common.rs
77
84
91.67%

src/parser.rs
29
38
76.32%

src/ast/mod.rs
27
51
52.94%

Totals

Change from base Build<PHONE_NUMBER>:
-0.3%

Covered Lines:
8823

Relevant Lines:
9853

💛  - Coveralls


Extending ClusterLoader Tuning Set with a Poisson Load Generator

What type of PR is this?
/kind feature

What this PR does / why we need it:
This PR adds a poisson load generator to clusterloader Tuning Set
Which issue(s) this PR fixes:
This PR allows clusterloader to generate a poisson load

Fixes #
Special notes for your reviewer:
"NONE"
Does this PR introduce a user-facing change?:

"NONE"

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

/assign @marseel @mborsz

For delegation

/ok-to-test
Please squash commits in to a single commit

/retest

@dumb0002 : the linter found some nits you need to fix.

/retest

/retest

@MikeSpreitzer, all the linter issues are now fixed

Have you signed CLA?

@marseel, I have the CLA via my company.  I know understand why the the cncf-cla: yes label was removed yesterday

/retest

@marseel, the CLA issue is fixed now.

Please squash commits

/remove-lifecycle stale

/reopen

/assign @mborsz

/reopen

/reopen

/reopen


Addresses admonition accessibility issue

Overview
This PR addresses an accessibility issue related to the titles of what sphinx calls paragraph-level directives (also know as notes/warnings/admonitions). This currently generates both the title and message content using the HTML
 tag. This causes issues in the following categories:

Visual Hierarchy - "Making texts larger helps guide the eye around the page." Using headings and making them visually apparent is especially helpful for users with cognitive disabilities.". By not providing an apparent visual difference between the title and message content, we're providing certain users with a poor user experience.
Screen Reader - " screen reader users can also benefit from headings. Screen reader users can navigate a page according to its headings, listen to a list of all headings, and skip to a desired heading to begin reading at that point. Screen reader users can use headings to skip the repeated blocks of content like headers, menus, and sidebars, for example." By not having the titles as a heading, we're providing screen reader users with a bad user experience.

Solution

New Approach inspired by similar changes here.

By inheriting from the sphinx  HTML5Translator class, we can define a custom translator that takes uses
 tags where we want.
Cases:

For every admonition we'll use
 for the title instead of the default
.
For a specific list of sub-headings we currently generate as strong text (bold).

Without customization, a .. note:: generates something like:

Note

...

After the customization we get something like

Note

...

Results
Before:

After:

Corresponding HTML:
Additional Note
Custom CSS was applied to make the change function correctly.
References
https://usability.yale.edu/web-accessibility/articles/headings

Codecov Report
Patch coverage has no change and project coverage change: -0.03 :warning:

Comparison is base (8d9f1cf) 93.39% compared to head (ca2b987) 93.37%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2928      +/-   ##
===========================================
- Coverage    93.39%   93.37%   -0.03%
===========================================
  Files           63       63
  Lines        13561    13561
===========================================
- Hits         12665    12662       -3
- Misses         896      899       +3

see 2 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Just some notes on doc strings. Not blockers though.

Thanks for the feedback! I addressed all issues/suggestions in the most recent commit. Lmk if there is anything I missed or something else you'd like to see in this PR.


ENH: Access to dual variable results of the MILP solver

Is your feature request related to a problem? Please describe.
Regarding the mixed integer linear programming, scipy provides the wrapper of HiGHS as scipy.optimize.milp.
With version 1.9.1, the dual variables are not included in the results, although the decision variables can be accessed.
In power engineering, it is useful to access the dual variables after solving the model. For example, local marginal price is the dual of power generation.
Describe the solution you'd like.
I kindly request to include the dual variables in the solver wrapper.
For example, after solving the model, the dual can be accessed as
from scipy.optimize import milp
res = milp(c=c, constraints=constraints, integrality=integrality)
res.x
res.dual

Describe alternatives you've considered.
Another costly solution will be to bypass the wrapper under scipy.optimize, directly calling the HiGHS.
However, including access to dual should be a low-cost but useful enhancement.
Additional context (e.g. screenshots, GIFs)
The example is referenced from scipy.optimize.milp.

We might be able to add this, but I'm not sure if HiGHS currently returns the duals for when there are integrality constraints. I say that because linprog exposes the duals when there are no integrality constraints, but they are all zero when there are integrality constraints.
For example:
import numpy as np
from scipy.optimize import linprog, milp, Bounds, LinearConstraint
rng = np.random.default_rng(0)
c = rng.random(size=5) - 0.5
A = rng.random(size=(4, 5))
b = rng.random(size=4)
bounds = [(-10, np.inf)]*5
linprog(c, A_eq=A, b_eq=b, bounds=bounds)

The result is:
           con: array([0., 0., 0., 0.])
 crossover_nit: 0
         eqlin:  marginals: array([ 0.13760231,  0.09501787, -0.25585934, -0.74905967])
  residual: array([0., 0., 0., 0.])
           fun: -7.4607245688555945
       ineqlin:  marginals: array([], dtype=float64)
  residual: array([], dtype=float64)
         lower:  marginals: array([0.        , 0.        , 0.        , 0.        , 0.68438045])
  residual: array([13.26897509, 10.03465834, 16.41472038, 13.77113844,  0.        ])
       message: 'Optimization terminated successfully. (HiGHS Status 7: Optimal)'
           nit: 4
         slack: array([], dtype=float64)
        status: 0
       success: True
         upper:  marginals: array([0., 0., 0., 0., 0.])
  residual: array([inf, inf, inf, inf, inf])
             x: array([  3.26897509,   0.03465834,   6.41472038,   3.77113844,
       -10.        ])

Note the integrality constraint happens to be satisfied.
The dual variables are under "marginals" for the different types of bounds. For example, the dual variables corresponding with the equality constraints are [ 0.13760231,  0.09501787, -0.25585934, -0.74905967].
When we add an integrality constraint:
integrality = [0, 0, 0, 0, 1]
linprog(c, A_eq=A, b_eq=b, bounds=bounds, integrality=integrality)

we get
           con: array([ 3.33066907e-16, -1.99840144e-15,  8.88178420e-16,  6.66133815e-16])
 crossover_nit: -1
         eqlin:  marginals: array([0., 0., 0., 0.])
  residual: array([ 3.33066907e-16, -1.99840144e-15,  8.88178420e-16,  6.66133815e-16])
           fun: -7.460724568855594
       ineqlin:  marginals: array([], dtype=float64)
  residual: array([], dtype=float64)
         lower:  marginals: array([0., 0., 0., 0., 0.])
  residual: array([13.26897509, 10.03465834, 16.41472038, 13.77113844,  0.        ])
       message: 'Optimization terminated successfully. (HiGHS Status 7: Optimal)'
           nit: -1
         slack: array([], dtype=float64)
        status: 0
       success: True
         upper:  marginals: array([0., 0., 0., 0., 0.])
  residual: array([inf, inf, inf, inf, inf])
             x: array([  3.26897509,   0.03465834,   6.41472038,   3.77113844,
       -10.        ])

The marginals all turn to zero, even though the solution hasn't actually changed.
@mckib2 For this example, when we get to this part of the code:
https://github.com/scipy/scipy/blob/2e5883ef7af4f5ed4a5b80a1759a45e43163bf3f/scipy/optimize/_linprog_highs.py#L377-L385
'lambda' is indeed in res, but marg_eqlin is all zeros when there are integrality constraints. Is that happening in the wrapper or is HiGHS returning them as all zero?

Hi @mdhaber,
Thanks for your reply.
I checked HiGHS python_api at https://github.com/ERGO-Code/HiGHS/blob/master/src/interfaces/highs_python_api.py
From lines 102 - 124, it seems that they do not offer dual values for MIP.
Will drop them a query about this and keep you updated in this thread.
Regards,
Jinning

Conclusion:
MIP has no dual problem, so the access to dual is unreasonable. We can discard this issue since it was my misunderstanding.
A Further information is attached below as the background of my issue.
In the power engineering, MILP is used first to determine the generator status. After eliminating all the integer variables, LP is further used to determine the marginal price.
Thanks,
Jinning

Ok, that would have been my guess. But depending on the algorithm used, those marginal prices might have been calculated in the solution of a relaxed problem in the last iteration, so it was worth asking.


Release on Docker Hub

It would be great if the container image was published as part of the release process.

I gave it a quick try with github actions, and I can't figure out why it continues to fail on login.
Maybe you have experience/an idea of why this action could be failing? :)
The logs should be here: https://github.com/elisescu/tty-proxy/runs/1731069924?check_suite_focus=true
And the action file I gave a try with: https://github.com/elisescu/tty-proxy/commit/f5d60d901a539029d7c8e0e2ebcabb29aca9b03b

I gave it a quick try with github actions, and I can't figure out why it continues to fail on login.
Maybe you have experience/an idea of why this action could be failing? :)
The logs should be here: https://github.com/elisescu/tty-proxy/runs/1731069924?check_suite_focus=true
And the action file I gave a try with: https://github.com/elisescu/tty-proxy/commit/f5d60d901a539029d7c8e0e2ebcabb29aca9b03b

I would also like to use this from dockerhub.
for haproxy ssl i have used:
use_backend back_tty-share if { hdr(host) -i ts.domain.ro }

backend back_tty-share
    mode http
    balance roundrobin
    option forwardfor
    option httpclose
    http-request set-header X-Forwarded-Port %[dst_port]
    http-request add-header X-Forwarded-Proto https if { ssl_fc }
    option httpchk HEAD / HTTP/1.1\r\nHost:localhost
    timeout server  300000
    server tty-share localhost:8080 check

Maybe you would like to add it to docs.
Also would like to buy you a beer, where can i donate?

This is so kind of you. Multumesc :).
I haven't thought of enabling donations to the project, as I didn't expect anyone would, so it's not possible to donate now.
But feel free to give my beer/donation to somebody else that you think would benefit from it - I'll appreciate that too :).
Thanks for the haproxy snippet - will add it at some point to the existing nginx example.


Downstream test failures caused by 0.3.0

tracking issue for https://github.com/JuliaLang/METADATA.jl/pull/9190#issuecomment-301363799

GeostatInversion https://github.com/JuliaCI/pkg.julialang.org/blob/07ab772b21a90b86b3c3cb32f48677b440b7902b/logs/GeostatInversion_0.5.log
PyAMG https://github.com/JuliaCI/pkg.julialang.org/blob/07ab772b21a90b86b3c3cb32f48677b440b7902b/logs/PyAMG_0.5.log
RobustLeastSquares https://github.com/JuliaCI/pkg.julialang.org/blob/07ab772b21a90b86b3c3cb32f48677b440b7902b/logs/RobustLeastSquares_0.5.log

there may actually be 2 or 3 separate bugs here, not sure

It appears to be all these errors were triggered because of the API change in IterativeSolvers @tkelman .
I have checked GeostatInversion @montyvesselinov. The default return of the solvers is the result without a ConvergenceHistory type,
so you just need to remove the [1] at the end of this line. If you want to use the ConvergenceHistory then set the log keyword value to true: log=true.
In the case of PyAMG @lukeolson, a lot of positional arguments have been moved to keywords.
I haven't check too deeply the last package but is probably due to an API change as well @andyferris.
You will find more changes in the manual. I would suggest using the help command  ?, the new API for each function is described there in a compact way.

let me know what you need changed in PyAMG -- not sure I see the cause of the problem

we're referring to the Julia wrapper package at https://github.com/cortner/PyAMG.jl by @cortner which uses this package as a test-only dependency for comparisons, PyAMG the python package has no problem here
can deprecations be added to allow any of the old style api's to keep working for now with warnings?

Whoops it makes sense now, I wasn't able to find the specific line...

Proposed changes above fixed: GeostatInversion. Thank you very much!
-monty
On Mon, May 15, 2017 at 8:38 AM, Juan Antonio López Mendoza <
<EMAIL_ADDRESS>wrote:

It appears to be all these errors were triggered because of the API change
in IterativeSolvers @tkelman https://github.com/tkelman .
I have checked GeostatInversion @montyvesselinov
https://github.com/montyvesselinov. The default return of the solvers
is the result without a ConvergenceHistory type,
so you just need to remove the [1] at the end of this line
https://github.com/madsjulia/GeostatInversion.jl/blob/master/src/lsqr.jl#L54.
If you want to use the ConvergenceHistory then set the log keyword value
to true: log=true.
In the case of PyAMG @lukeolson https://github.com/lukeolson, a lot of
positional arguments have been moved to keywords.
I haven't check too deeply the last package but is probably due to an API
change as well @andyferris https://github.com/andyferris.
You will find more changes in the manual
https://juliamath.github.io/IterativeSolvers.jl/latest/. I would
suggest using the help command ?, the new API for each function is
described there in a compact way.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/JuliaMath/IterativeSolvers.jl/issues/116#issuecomment-301495404,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFXxeGcRgWZR3Mpz9b_cdx3UMK_0V90Mks5r6GN8gaJpZM4NbJ5U
.


Prateekroopra feature5

Added the sub-functionality to remove the uploaded package.json files by clicking on the remove button.
Updated the following files:
components/Upload.js
pages/files.js
server/index.js

Thank you!
Seems like you added manually some files, and this is causing conflicts. Could you rebase and fix the conflicts?
Alternatively, I can integrate your changes manually.

Hi @
I don't have terminal access as of now, could you please integrate it manually this time?
Thank you!

This was handled in https://github.com/opencollective/backyourstack/pull/13