Identifiers validation failed for dataset CM Vertebrate Paleontology Collection

Identifier validation failed for the dataset CM Vertebrate Paleontology Collection:

Crawler attempt: 290
Publishing organization: Carnegie Museums
Publishing country: UNITED_STATES
Installation: IPT - Hosted by VertNet
Number of occurrences indexed for this dataset at the time of the issue: 79254
Cause: GBIF ID problems exceed 50% threshold: 100% duplicates; 84309 total records; 84309 absent records
Pipelines execution steps: http://api.gbif.org/v1/pipelines/history/execution/3255800/step

Publisher email
Hello,
I am contacting you from the GBIF Secretariat about a dataset published by the CM Vertebrate Paleontology Collection : https://doi.org/10.15468/hw4khc.
We noticed that the occurrenceIDs were changed. We have temporarily paused the ingestions of this dataset.
As you might already know, when an occurrence record has a new occurrenceID for a given dataset, our system considers it to be a new occurrence.
This means that it will be given a new gbifid and a new occurrence URL (like this one: https://www.gbif.org/occurrence/1252968762) and the old gbifid and URL will be deprecated.
In this case, this means that the occurrence URLs would be deprecated when ingesting the newest versions of these datasets.
We would like to check with you if those changes were intentional. Do you know if this is the case?
Please let us know, thanks! We are happy to resume the dataset ingestion.
Note that some users rely on those occurrence URLs and gbifids (like https://bionomia.net for example). In an attempt to improve
the stability of the occurrence URLs and gbifids, we have implemented a warning system to detect these type of changes in datasets (see this news item).
If the data publisher can provide us with a list of old and new occurrenceIDs per record, we can avoid the identifier and URL changes. Could that be an option?
Please let us know if you have any question. Thanks!
All the best,

You can skip/fix identifier validation using the registry UI.

@ktotsum FYI - still working through the ID lists with the folks at the CM. Close to resolution.


Update .gitignore

The file "sources_non_forked/ctrlp.vim/doc/tags-cn" keeps getting created for me and should be ignored.

+1, I added it to my global .gitignore for now.

Thanks!


Update idemix.rst

Thanks for the contribution! However, this is a read-only mirror. please read the contribution guide. Also, feel free to join us on chat!


feat(FN-1042): remove link while no page exists

Introduction :pencil2:
Remove links from TFM "Bank reports" page while individual bank report pages are not available.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (91637c1) 17.31% compared to head (aff3f22) 0.48%.
Report is 210 commits behind head on main-stbr-tfm-5.

Additional details and impacted files
@@                 Coverage Diff                 @@
##           main-stbr-tfm-5   #2564       +/-   ##
===================================================
- Coverage            17.31%   0.48%   -16.84%
===================================================
  Files                 1120     104     -1016
  Lines                25591    1452    -24139
  Branches              4101     360     -3741
===================================================
- Hits                  4432       7     -4425
+ Misses               18423    1231    -17192
+ Partials              2736     214     -2522

Flag
Coverage Δ

api-test
0.48% <ø> (ø)

ui-test
?

unit-test
?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Add class docstrings to module prompts

Add class docstring to all classes in prompts.py.
This issue is part of the documentation effort from issue https://github.com/llmware-ai/llmware/issues/219.

Nice job - merged!   👍


Really, really basic logging

I thought you liked descriptive variable names?

Ok, done.

Thank you


Is that OK to use AlphaFold generated PDB as a template

My target does not have a published PDB. Thus I used AlphaFold to generate a PDB as the template.
 It is probably too big for your GPU memory, you may have to try it

Thanks, Martin. You are giving the right direction to solve this problem.
The protein is about 1000 amino acids. But I have defined the hot spot residues to be the first 100 amino acids.
I thought the software will only take it as a 100-aa-long target. But I could be wrong.

It takes the whole pdb you provide as input


[embeddingapi] Add autocase for XWalkResourceClient.onDocumentLoadedI…

…nFrame
-add embeddingapi autocase for XWalkResourceClient.onDocumentLoadedInFrame
-modify testOnDownloadStart testcase
-cover the XWalkViewActivity and XWalkInitializer two ways
Impacted tests(approved): new 1, update 1, delete 0
Unit test platform: [Android]
Unit test result summary: pass 2, fail 0, block 0
https://crosswalk-project.org/jira/browse/XWALK-4320

@jennycao please help to review it.
Thanks.


Downloading the up-to-date bridge dataset

Hi, thanks for your great work!
It appears that you're utilizing the most recent bridge dataset from https://rail.eecs.berkeley.edu/datasets/bridge_release/data/tfds/. However, based on the script available at https://github.com/kpertsch/rlds_dataset_mod, it seems the files it fetches are named as bridge-train.xxx instead of the expected naming convention (bridge_dataset-train.xxx) from https://rail.eecs.berkeley.edu/datasets/bridge_release/data/tfds/. Additionally, the dataset downloaded using the script is labeled as 'bridge', whereas your configuration references 'bridge_dataset'.
Therefore, I'm curious if the downloading script is providing me with the exact version you're utilizing. Once again, thank you for your exceptional work!

Indeed the script in rlds_dataset_mod downloads from the official Open X-Embodiment bucket, which has an outdated version of the Bridge dataset. Please download Bridge separately from https://rail.eecs.berkeley.edu/datasets/bridge_release/data/tfds/
All other datasets should be downloaded correctly by the rlds_dataset_mod script.

Thanks!


#281 Trimming slowest/fastest run, not first/last in evaluate2.sh

Fixes #281.

This LGTM after some testing and I'm gonna merge it. Tagging @hundredwatt for awareness.

Oops! I had this originally but lots it along the way 😬

Ha, no worries. I verified a few results manually, so that's how I noticed
it. Note I'm converting the values to numbers for correct comparison, as
otherwise for instance 10 would be "lower" than 2.

Message ID: @.***>


Incorrect parameter values with Hibernate custom types.

We are using querydsl 3.x, and there lots of legacy columns in our JPA Entity mappings, because of this we had to use many hibernate custom types.
When there are

the same java type(like Boolean) but different custom types'(like yes_no, true_false) columns related conditions
and their  parameter values are the same (like Boolean.TRUE)
and parameters' position number is the same in a query(like ?1),

Hibernate maps parameter values incorrectly.
This was reported already - https://github.com/querydsl/querydsl/issues/1168
Actually I think this is a bug of hibernate - https://hibernate.atlassian.net/browse/HHH-9871 .
But QueryDSL can work around this bug.
For exampe, when there are two or more boolean types(same java type) but they're custom types like the following(it doesn't matter that the colums are in the same entity or two or more entities),
@Type(type = "true_false")
@Column(name = "employee", columnDefinition = "char(1)")
 private Boolean employee;

@Type(type = "yes_no")
@Column(name = "male", columnDefinition = "char(1)")
private Boolean male;

@Column(name = "old")
private Boolean old;

And in a QueryDsl query has conditions with same java type and same value(Boolean.TRUE), QueryDsl generates JPQL like the follwing,
// employee == Booealn,TRUE, male == Boolean.TRUE, old == Boolean.FALSE
from User user where employee = ?1 and male = ?1 and old = ?2

QueryDSL maps same java type value into same positional parameter.
real parameter value mappings in hibernate is like the following
employee = 'T' and male = 'T' and old = false

male parameter must have been 'Y' but it follows the first parameter value - 'T'.
employee and male columns have same java type but different custom types, QueryDsl maps same positional parameter(?1)  to these two columns.
I wonder QueryDSL could map different poisitional parameters for every different condition even though they have same java type value(like Boolean.TRUE in the example).

I'd rather not add a fix on the Querydsl level for this Hibernate bug, since maintaining those is quite time consuming.
But a valid workaround should be literals for these cases, e.g. BooleanTemplate.TRUE/FALSE


v<IP_ADDRESS> - Scheduled tasks not working

Bug Report
System Information

Operating System (Including distribution name and version number)
Description:    Ubuntu 20.04.1 LTS
Release:        20.04

bryantdl7@gameserv:~$ uname -r
5.4.0-56-generic
bryantdl7@gameserv:~$
========time is set to UTC properly=============
bryantdl7@gameserv:~$ date
Sat Dec  5 17:07:10 UTC 2020

AMP version and build date (Always use the version number, 'latest' is not valid!)
v<IP_ADDRESS>, built 23/11/2020 19:36
Which AMP release stream you're using (Mainline, Nightly or FastTrack)
Mainline

I confirm:

[x] that I have searched for an existing bug report for this issue.
[x] that I am using the latest available version of AMP.
[x] that my operating system is up-to-date.

Symptoms

Enter Symptoms on this line.
Reproduction

Enter reproductions steps here.

Create a rule based on time
Await for the tasks to occur
nothing happens, and no log entries even mention the backup failing.

I have included my two scheduling files, along with a log coinciding with a backup which shouldve taken place at 1450UTC.
12-5-2020.zip
I'm more than happy to share my entire instance file for this, I have had issues like this over the years, and the solution is always deleting the whole instance, and copying over the minecraft world to the new instance.
Something has to be getting messed up in the files since this is a clean VM holding AMP, this is a fresh instance of minecraft bedrock, and I am not editing any settings using anything other than the web UI.
I'm happy to even provide you a full virtual machine as a clonezilla file or a vdi. This is a purely stock ubuntu server, with just running the AMPInstall script "bash <(wget -qO- getamp.sh)" and licensing it. Again, I know how to fix this by making a fresh amp instance, but it shouldn't be coming to this for multiple years on fresh OS installs.
Thanks in advance!

Interestingly, one of my automations does work. When a backup finishes archiving the server still starts back up, just the time-related events do nothing. I don't know if this will give insight to the problem more, but I figured I'd add this in to see if it helps.

The issue has been identified. One part of AMP used 0-11 for months, another part used 1-12 which caused them not to fire. Next update will contain a fix for this.


Support React 18

Currently this project has dependencies preventing users to update to the latest version of React and Next.
This is especially an issue when using npm workspaces as seen below.

npm WARN ERESOLVE overriding peer dependency
npm WARN While resolving<EMAIL_ADDRESS>npm WARN Found<EMAIL_ADDRESS>npm WARN apps/web/node_modules/react
npm WARN   peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm WARN   apps/web/node_modules/react-dom
npm WARN     peer<EMAIL_ADDRESS>|| ^18.0.0-0" from<EMAIL_ADDRESS>npm WARN     apps/web/node_modules/next
npm WARN   1 more (next)
npm WARN
npm WARN Could not resolve dependency:
npm WARN peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm WARN apps/web/node_modules/react-dom
npm WARN   peer<EMAIL_ADDRESS>|| ^18.0.0-0" from<EMAIL_ADDRESS>npm WARN   apps/web/node_modules/next
npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR!
npm ERR! While resolving<EMAIL_ADDRESS>npm ERR! Found<EMAIL_ADDRESS>npm ERR! node_modules/react
npm ERR!   peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR!   node_modules/@hot-loader/react-dom
npm ERR<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR!     node_modules/@sanity/server
npm ERR<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR!       node_modules/@sanity/core
npm ERR<EMAIL_ADDRESS>from sanity@undefined
npm ERR!         apps/sanity
npm ERR!   peer<EMAIL_ADDRESS>|| 17.x" from<EMAIL_ADDRESS>npm ERR!   node_modules/@reach/auto-id
npm ERR<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR!     node_modules/@sanity/base
npm ERR<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR!       node_modules/@sanity/default-layout
npm ERR<EMAIL_ADDRESS>from sanity@undefined
npm ERR!         apps/sanity
npm ERR!       7 more (@sanity/default-login, @sanity/desk-tool, ...)
npm ERR<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR!     node_modules/@sanity/desk-tool
npm ERR<EMAIL_ADDRESS>from sanity@undefined
npm ERR!       apps/sanity
npm ERR!         sanity@undefined
npm ERR!         node_modules/sanity
npm ERR!     1 more (@sanity/form-builder)
npm ERR!   50 more (@reach/utils, @sanity/base, @sanity/default-layout, ...)
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer<EMAIL_ADDRESS>|| ^18.0.0-0" from<EMAIL_ADDRESS>npm ERR! node_modules/next
npm ERR!   peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR!   node_modules/eslint-config-next
npm ERR<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR!     packages/config
npm ERR<EMAIL_ADDRESS>npm ERR!       node_modules/config
npm ERR!
npm ERR! Conflicting peer dependency<EMAIL_ADDRESS>npm ERR! node_modules/react
npm ERR!   peer<EMAIL_ADDRESS>|| ^18.0.0-0" from<EMAIL_ADDRESS>npm ERR!   node_modules/next
npm ERR!     peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR!     node_modules/eslint-config-next
npm ERR<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR!       packages/config
npm ERR<EMAIL_ADDRESS>npm ERR!         node_modules/config
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR!
npm ERR! See /Users/danewilson/.npm/eresolve-report.txt for a full report.

I suspect supporting react 18 will be a big push, since you'll need to also update dependencies within the Sanity ecosystem.

Hi!
We updated next-sanity to have v18 in peer deps in v0.6.4 🙂
The errors you're getting don't seem related though, in any case we've been seeing this error a lot when working on our own tooling, here's how we workaround it: In the root of your npm workspace  create a .npmrc and put this in it:
legacy-peer-deps=true

Hope this helps!


path_helpers are not available in my trail

class BreadcrumbTrail < Croutons::BreadcrumbTrail

def internal_vaults_index
    home
    breadcrumb "Vaults", internal_vaults_path
  end

  def internal_vaults_new
    internal_vaults_index
    breadcrumb "Create a new Vault"
  end

  def method_missing(*m)
    p "breadcrumb_trail.rb: missing_method: #{m.first}"
  end

end

results in
"breadcrumb_trail.rb: missing_method: internal_vaults_path"
  Rendered breadcrumbs/_breadcrumbs.haml (Duration: 0.1ms | Allocations: 45)

Vaults
however, path_name is correct
rake routes | grep internal_vaults
internal_vaults GET                   /internal/vaults(.:format)          internal/vaults#index

lmao.
figured out in pull https://github.com/thoughtbot/croutons/pull/9 that you guys use the method_missing to call the path helpers. i override it to see which one was missing. yikes :-)


Add a Pinchable plan

Spec: https://material-motion.gitbooks.io/material-motion-starmap/content/specifications/motion_family/direct_manipulation.html

🎊 My diff is ready for review at http://codereview.cc/D1620


move examples folder under api

Folks are mistaking these as examples for github spec.
This should make it harder to find it.
And as a bonus, I'm converting a robust v2 lab example to github spec. I haven't tested it, so please take a good look

left comments - thanks for taking this on!

left comments - thanks for the bonus and taking this on!

done

The lab resource spec is slightly different from the course_template resource spec!

Tested on davesr here: https://github.com/CloudVLab/qwiklabs-test-content/pull/357
Found that assessments must use locale_id: for merging, id: does not work


Made the registry more fully-featured

Description
WIP
Review Checklists
Please check each item before approving the pull request. While going
through the checklist, it is recommended to leave comments on items that are
referenced in the checklist to make sure that they are reviewed. If there are
multiple reviewers, copy the checklists into sections titled ## [Reviewer Name].
If the PR doesn't touch Solidity, the corresponding checklist can
be removed.
[[Reviewer Name]]

[ ] Tokens

[ ] Do all approve calls use forceApprove?
[ ] Do all transfer calls use safeTransfer?
[ ] Do all transferFrom calls use msg.sender as the from address?

[ ] If not, is the function access restricted to prevent unauthorized
token spend?

[ ] Low-level calls (call, delegatecall, staticcall, transfer, send)

[ ] Is the returned success boolean checked to handle failed calls?
[ ] If using delegatecall, are there strict access controls on the
addresses that can be called? It shouldn't be possible to delegatecall
arbitrary addresses, so the list of possible targets should either be
immutable or tightly controlled by an admin.

[ ] Reentrancy

[ ] Are functions that make external calls or transfer ether marked as nonReentrant?

[ ] If not, is there documentation that explains why reentrancy is
not a concern or how it's mitigated?

[ ] Gas Optimizations

[ ] Is the logic as simple as possible?
[ ] Are the storage values that are used repeatedly cached in stack or
memory variables?
[ ] If loops are used, are there guards in place to avoid out-of-gas
issues?

[ ] Visibility

[ ] Are all payable functions restricted to avoid stuck ether?

[ ] Math

[ ] Is all of the arithmetic checked or guarded by if-statements that will
catch underflows?
[ ] If Safe functions are altered, are potential underflows and
overflows caught so that a failure flag can be thrown?
[ ] Are all of the rounding directions clearly documented?

[ ] Testing

[ ] Are there new or updated unit or integration tests?
[ ] Do the tests cover the happy paths?
[ ] Do the tests cover the unhappy paths?
[ ] Are there an adequate number of fuzz tests to ensure that we are
covering the full input space?

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

96 of 109 (88.07%)  changed or added relevant lines in 2 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.3%) to 93.031%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

contracts/src/factory/HyperdriveFactory.sol
13
17
76.47%

contracts/src/factory/HyperdriveRegistry.sol
83
92
90.22%

Files with Coverage Reduction
New Missed Lines
%

contracts/src/factory/HyperdriveRegistry.sol
1
89.36%

Totals

Change from base Build<PHONE_NUMBER>:
-0.3%

Covered Lines:
1909

Relevant Lines:
2052

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

96 of 109 (88.07%)  changed or added relevant lines in 2 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.4%) to 92.982%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

contracts/src/factory/HyperdriveFactory.sol
13
17
76.47%

contracts/src/factory/HyperdriveRegistry.sol
83
92
90.22%

Files with Coverage Reduction
New Missed Lines
%

contracts/src/factory/HyperdriveRegistry.sol
1
89.36%

Totals

Change from base Build<PHONE_NUMBER>:
-0.4%

Covered Lines:
1908

Relevant Lines:
2052

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

96 of 109 (88.07%)  changed or added relevant lines in 2 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.4%) to 92.982%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

contracts/src/factory/HyperdriveFactory.sol
13
17
76.47%

contracts/src/factory/HyperdriveRegistry.sol
83
92
90.22%

Files with Coverage Reduction
New Missed Lines
%

contracts/src/factory/HyperdriveRegistry.sol
1
89.36%

Totals

Change from base Build<PHONE_NUMBER>:
-0.4%

Covered Lines:
1908

Relevant Lines:
2052

💛  - Coveralls


Intermittent Python test failure in ActivityClassifierAutoValdSetTest

Rarely happens, but this is the result (seen in a Travis CI build on Linux, Python 3.5):
turicreate/test/test_activity_classifier.py::ActivityClassifierAutoValdSetTest::test_create_auto_validation_set_typical *** Error in `/home/travis/build/apple/turicreate/scripts/../deps/env/bin/python': malloc(): memory corruption (fast): 0x00000000059bf6e8 ***
scripts/run_python_test.sh: line 58:  7474 Aborted                 (core dumped) $cmd

See https://travis-ci.com/apple/turicreate/jobs/194576726

Also causes an intermittent C++ unit test failure in test_create_auto_validation_set_string_session_id:
turicreate/test/test_activity_classifier.py::ActivityClassifierAutoValdSetTest::test_create_auto_validation_set_string_session_id *** Error in `/home/travis/build/apple/turicreate/scripts/../deps/env/bin/python': free(): invalid pointer: 0x00007f3670007b48 ***
scripts/run_python_test.sh: line 58:  9258 Aborted                 (core dumped) $cmd

See https://travis-ci.com/apple/turicreate/jobs/200612366 for an example of this.

For this release either fix or skip this test.

I think this is fixed as we adopted the C++ implementation of AC since I can no longer see it. Still, I don't how to say if an intermittent test is fixed or not for certain.

I think we can assume it's fixed, and close the issue. If it happens again on a Travis run, we can reopen the issue and link to the instance where it happened.


Error 503 certificate has expired - docs are down

Code of Conduct

[X] I have read and agree to the GitHub Docs project's Code of Conduct

What article on docs.github.com is affected?
The whole website is down
What changes are you suggesting?
Fixing it :)
Additional information
No response

@guyschlider Thanks so much for opening this! This issue has been resolved ✨


Cannot install the package anymore

Running the command npm i<EMAIL_ADDRESS>returns the following error:
npm ERR! code E404
npm ERR! 404 Not Found - GET https://registry.npmjs.org/@vue%2ftsconfig - Not found
npm ERR! 404
npm ERR! 404  '<EMAIL_ADDRESS>is not in this registry.
npm ERR! 404 You should bug the author to publish it (or use the name yourself!)
npm ERR! 404
npm ERR! 404 Note that you can also install from a
npm ERR! 404 tarball, folder, http url, or git url.

Same, cannot install at all even when just running
yarn add -D @vue/tsconfig

Seems to be NPM https://status.npmjs.org/incidents/jglnklhspsnm

Working now for me

Yep, everything seems back to normal. Closing this issue.
Thx!


[slides] remove index

Job d2l-zh/PR-936/1 is complete.
Check the results at http://preview.d2l.ai/d2l-zh/PR-936/


revert to doxygen 1.9.2

Alternative fix for https://github.com/open-quantum-safe/liboqs/issues/1332

Barring some other configuration change that could be made in Doxygen, then yes this is a preferred approach I think. Our Github Markdown documentation is the priority, and Doxygen documentation is a second-level priority, so let's this to keep the optimal experience for Github Markdown and tolerate an older version of Doxygen.


Bam2fastq module

Uses picard SamToFastq
The module has been tested using capture, mrna and genome dataset

@whelena: Will you be submitting this module in a separate PR using the new approach?

yes I will


Deactivation of latex-input?

I use the latex-input plugin to provide access to unicode characters. I've grown used to this, which I use across all languages in VSCode, and so I'd like to keep using it instead of Agda's home-grown input method. However, it seems like there is some sort of conflict happening: in all other 5 or 6 language mode I quickly tried, typing \ in opens up an auto-complete pop-up, as expected, see this screenshot:

However, turning on the agda-mode plugin (or changing the language of the file to Agda) seems to break that. Do you know what might be causing this, and how I could fix it?

Please try disabling the input method of agda-mode and check if there are still any conflicts under Agda Mode › Input Method.

I have tried this, but it does not seem to have any effect on my issue. I also tried changing the input method activation key, but this does not help either.


Getting an error log when running a bal file which imports a package using ballerina native interface (non builtin)

Description:
$subject.
The error message is error occurred when pulling the package
This seems to be because, when the org is not ballerina, before checking whether the package is in BALLERINA_HOME/bre/lib, it is directly checked in local .ballerina or ballerina central causing the aforementioned error message. However, the bal file runs fine.
Steps to reproduce:

Copy paste the relevant native package jars in to BALLERINA_HOME/bre/lib
Import that native package in a bal file.
Run the bal file

Affected Versions:
0.970.0

For the 0.970.1 version the error log is,
could not find package wso2/mongodb:*

same issue. Is there any fix yet on this?

@shobhitJava This is not fixed yet. Expected to be fixed in an up coming release.
Please note that this is a harmless error message which is misleading. Even though you get this error, code written using the package should work.

I read this comment on a post so tried it but I am not able to run the code. It is giving me the error "  could not find package wso2/mongodb:*"

@shobhitJava Are you getting any errors other than "could not find package wso2/mongodb:*" ? Can you post a sample code you are trying to run?

no I am not getting any error other then this , but my services are not getting started as execution is getting stopped after getting this error.
Attaching source code
Changing the extension due to file type
test.bal.txt
hello_service.bal.txt

Could you please let us know the ballerina version and the mongodb package version you are using?

Please find the version below
[root@blockchain-1 ~]# mongod --version
db version v4.0.0
git version: 3b07af3d4f471ae89e8186d33bbb1d5259597d51
OpenSSL version: OpenSSL 1.0.1e-fips 11 Feb 2013
allocator: tcmalloc
modules: none
build environment:
distmod: rhel70
distarch: x86_64
target_arch: x86_64
[root@docker-repo ballerina-platform-0.976.1-SNAPSHOT]# ballerina -v
Ballerina 0.976.1-SNAPSHOT
Mongo db is running on different server. I have given you locahost file, in my version I have replaced the IP of server. Also with JAVA code it is getting connected. So connectivity issue is not there.

@shobhitJava Kindly note that I was asking the mongodb package version you have installed in ballerina, not the mongo database server version.
At the moment WSO2 MongoDB package is not released to Ballerina central therefore you have to download it from [2] and install according to the provided instructions. Also, the latest release of the WSO2 MongoDB package(0.5.7) supports Ballerina 0.975.0 only. Therefore you won't be able to use the MongoDB package with the latest Ballerina 0.976.1-SNAPSHOT. Once the next Ballerina version is released, compatible MongoDB package also will be released. For now you can try MongoDB 0.5.7 with Ballerina 0.975.0.
[1] https://github.com/wso2-ballerina/package-mongodb
[2] https://github.com/wso2-ballerina/package-mongodb/releases

Okay, welll I have followed the instruction given in (2).  For the version related to ballerina, I will wait for newer version.
Thanks for your feedback.


Filter for dimension values not refreshing for dashboard variable

Thanks for a great plugin, and I really like the new feature with dashboard variables for dimensions.
I use a dimension with a high number of values, and I return a limited number of values in ListDimensionValues. This works perfectly in the query editor where it calls ListDimensionValues on every filter change. But this is not the behavior in the dashboard variable for dimension, where is only calls ListDimensionValues initially on not on any filter change. Then the filter only works for the reduced values I returned in the first place.
Is it feasible to get this refreshed on every filter change?

Hi @jahaugum not sure if this is possible. I'll have to investigate this in detail.

just to confirm I understood the problem correctly. You want to configure a variable of type DimensionValue. After selecting the appropriate Dimension Key, a list of Dimension Values is returned by the backend system. In your case, a particular dimension, has many values and you only return a limited set. As a result you only see the limited number of dimensions and there is no way to get to the other dimension values. Is that correct?

alright. I understand. I think the best solution would be to provide the VariableQueryEditor with a filter field which is send to the backend. This would provide the same behavior like the Query Editor. What do you think?

I'm very happy with how it works in the QueryEditor, so that sound like a good solution.


browser object is null on ubuntu server 14.10

Hi,
I try to use ui4j but when I launch my jar on ubuntu server 14.10, my browser object is null with the code : BrowserEngine browser = BrowserFactory.getBrowser(BrowserType.WebKit);
Any idea why ?
Thanks

Ui4j requires ui4j-all or ui4j-webkit jar. Most probably your classpath contains only ui4j-api.jar.

In fact I realize that I'm not able to compile the ui4j maven project.
I have always the error : Failed to execute goal on project ui4j-webkit: Could not resolve dependencies for project com.ui4j:ui4j-webkit:bundle:2.0.0-SNAPSHOT: Could not find artifact com.ui4j:ui4j-api:jar:2.0.0-SNAPSHOT
How can I compile the last source code of ui4j with maven ?
Thank you.

Ok it was an error in my maven version.
Now I can execute my jar in command line but another error : Xlib:  extension "RANDR" missing on display ":99.0".
Any idea why ?
Thanks

libxslt is required by the JavaFX webkit implementation. Could you please check if libxslt is installed. If its not try to install it with this command sudo apt-get install libxslt1-dev.

Ok Thank you.
I have always the error Xlib: extension "RANDR" missing on display ":99.0". but it works.


changing name of project to ruleset

https://github.com/gbif/occurrence-annotation/issues/22
Changing the name of "project" to "ruleset".
This is a breaking change but otherwise the change is merely a name change, and everything should work the same.
I feel this change is necessary before "project" get further embedded into code and documentation.

Merged - thanks John


"Izvoarele" is listed in the drop-down menu

Description:
"Izvoarele" is listed in the drop-down menu alongside its corresponding county and commune, according to the law
Precondition:
The website is up an running.

Step 1
Type "Izvoarele" in the search bar.

Expected results
The location is listed in the drop-down menu as "Sat Izvoarele, TELEORMAN (Izvoarele)" and "Comuna Izvoarele, TELEORMAN".


Bold tag to strong tag refactor

I want to point out that  is a perfectly valid HTML element, it has its own semantic meaning (which is different to ). I have seen advice many times to replace  with , however blindly changing this is pointless - if it would be that easy,  probably would end up deprecated as it means the same thing as  (which it doesn't). Don't follow whatever HTML purists say, because I saw nightmare stuff like simulating tables using lists, when a table in question was a perfectly fine data table.
For instance, in this line:
this.sendReplyBox("This tournament's banlist:
" + Chat.escapeHTML(tournament.banlist.join(', ')));

 is better semantically than . Feel free to read HTML5 specification.
As  uses more bytes than  (but in the end it probably won't matter due to TCP packet lengths), I'm opposed to merging this, but at the same time, I'm aware that merging this will change absolutely nothing in Showdown, as Showdown needs deeper changes than this to be accessible for screen readers users.

That said, I suppose I'm willing to support this if you change this pull request to only change broadcasts (broadcasts probably should have , but it's not that big of a deal). I still don't see much point in it, but hey :smile:, the first step in contributing is important.

I believe all uses of  in PS code are to draw attention to them, which makes  appropriate.
Italics have a lot of meanings in English, but basically all uses of bold fit . I'd normally only use  and  in PS situations.
On the other hand, it's true that if basically all uses of bold should be , semantically, it's not saying anything over . Which I kind of agree. Situations where the bolding is entirely non-semantic can be handled with CSS (and ). Otherwise, it might be better to just use  and  (which are shorter and more readable) and ignore the semantic bold/italic elements?

I give up, I'm going straight to the spec:

The  element represents stress emphasis of its contents.

The  element represents strong importance, seriousness, or urgency for its contents.

The  element represents a span of text in an alternate voice or mood, or otherwise offset from the normal prose in a manner indicating a different quality of text, such as a taxonomic designation, a technical term, an idiomatic phrase from another language, transliteration, a thought, or a ship name in Western texts.

The  element represents a span of text to which attention is being drawn for utilitarian purposes without conveying any extra importance and with no implication of an alternate voice or mood, such as key words in a document abstract, product names in a review, actionable words in interactive text-driven software, or an article lede.

In other words,  and  cover a lot of situations where it would be grammatically appropriate to use bold or italics in English text, except for emphasis, which is covered by  and .
Which I think is... annoying and unnecessary. A screen reader will most likely treat  and  pretty similarly, ditto  and , so it's not like it's an accessibility concern. It's mostly for I guess scrapers? But scrapers trying to determine semantic meaning are going to be pretty stymied by how misused these four tags are in general, so honestly I'm still thinking we should just use  and  for everything.
I could maybe be persuaded to keep  for inline headings, like the spec says, I guess...

If we were to keep  for inline headings, we'd have to manually review each usage of it, and there are a lot of places where it's arguable. Like,
Server version: 0.10.2
Is this the important part of a heading, like the spec says,
Chapter 1: The Praxis
? Or is this a keyword, like
You enter a small room. Your sword glows brighter. A rat scurries past the corner wall.
?
I think this is way too much mental effort to spend on something that has zero effect on accessibility, text parsability, or anything like that. So that's why I think we should just use  and  for everything. Thoughts?

I strongly believe it's worth the mental effort, in the future we could think before placing a  or  tag before pr'ing it. I will look over all the tags in this pr with someone (feel free to pm me on PS nickname : Alpha Ninja) or alone and see over that they're all used correctly.

@DieterReinert that seems like a lot of effort for something so unimportant. Using just  and  or even  For everything seems fine imo

@DieterReinert, if it were unambiguous, that's one thing, but if we have to have an argument every pullreq with a  or  tag, that's excessive and very much not worth it, I think.
If you think it's worth all that effort, can you at least tell us why? Just saying "I strongly believe it's worth it" doesn't give us much to discuss.

@Zarel strong is a logical state, and bold is a physical state. Logical states separate presentation from the content, and by doing so allow for it to be expressed in many ways. Maybe instead of creating and displaying some text as bold you want to make/give it red, or a different size, or underlined, or whatever. It makes more sense to change the presentational properties of strong than it does bold. This is because bold is a physical state; there is no separation of presentation and content, and making bold do anything other than bold text would be confusing and wrong and confusing.
It is important to note that bold tag does have other uses, when one wants to draw attention without increasing importance.

@DieterReinert if "you" strongly believe this you shouldn't just copy and paste your reasoning why >:/ https://developer.mozilla.org/en-US/docs/Web/HTML/Element/strong

@AustinXII  I'll post my own reasoning later on that was just to explain what strong can do

The  tag (physical) and  tag (logical) tag result in the same bold markup. However, I prefer to give meaning to the content, so if you want to make something important  the better choice. The same for  and  that both make cursive markup, but where the text gets a different meaning by putting the emphasis on a part, you use  tag. However, where the text displays a different mood(example : a dream) then the surrounding text, the  tag is better. Also note that because the -element is a logical element it should render the element in the most appropriate manner for that browser/environment. Also the  tag is more "abstract", so if side servers would like a different way of formatting important text they can override the  tag. Example, I would like important text to be red instead of bold, makes more sense to override the  tag than the <bold>tag.

@DieterReinert if you still have to copy + paste and then only kinda re-word it, I really don't think this is necessary.

@AustinXII I didn't copy paste it from somewhere, it's just a general explanation. After that I gave my personal reasoning, I said something about side servers and I don't think you can copy paste that from somewhere.

Yes, I'm aware of those differences.
The problem is, your MDN quote directly contradicts the spec, which says that both are logical states that do subtly different but overlapping things. So does your later comment.
The other problem is, we might, for instance, at some point, say "look at the bold text". And then at that point, it won't make sense if the text is red instead of bold.

I guess if there are no further comments, I'm closing.


traffic manager synchronous mode prevents apply_settings call after loading a new world

Hi,
I am running code in the form of
      client = carla.Client("localhost", port)  # pylint: disable=no-member
      client.set_timeout(20)
      client.load_world(map_name="Town01")
      world = client.get_world()
      world.set_weather(carla.WeatherParameters.ClearNoon)  # pylint: disable=no-member
      world.wait_for_tick()
      frame = world.apply_settings(
          carla.WorldSettings(  # pylint: disable=no-member
              no_rendering_mode=False,
              synchronous_mode=True,
              fixed_delta_seconds=1.0 / fps,
          ))

Where after some time I want to load a new world (using the same code).
The problem is that if in between I spawn vehicles, then when running this for the second time, the apply_settings call never returns. This only happens when spawning vehicles, not when using an empty map or spawning only pedestrians.
     client.load_world(map_name="Town01")
     world = client.get_world()
      frame = world.apply_settings(
          carla.WorldSettings(  # pylint: disable=no-member
              no_rendering_mode=False,
              synchronous_mode=True,
              fixed_delta_seconds=1.0 / 20,
          ))

Note that I can successfully retrieve the new map after loading it, as well as do things like applying a new wheather condition etc.. It is only (re-)applying the setttings that fails.
I've tried to first ensure that all actors are destroyed (using the code below), but that didn't make any difference. I've also tried to first do world.wait_for_tick() before applying the settings. Again to no effect.
self._client.apply_batch([carla.command.DestroyActor(x) for x in [self._hero] + self._vehicles + self._pedestrians])

Am I missing a required step to reset the world? (The documentation seems to state that loading a new world automatically takes care of everything).
Client API version     = <IP_ADDRESS>-255-gc56a7738
Simulator API version  = ba812e75  (latest docker image)

It seems that the problem is actually the traffic manager, chaning the title accordingly.
As soon as I set the synchronous mode on the traffic manager, the world.apply_settings() call described above no longer returns after loading or reloading a world. I.e. after doing this:
    traffic_manager = client.get_trafficmanager(8000)
    traffic_manager.set_synchronous_mode(True)

This gets stuck in the apply_settings() call:
     client.reload_world()
     world = client.get_world()
      frame = world.apply_settings(
          carla.WorldSettings(  # pylint: disable=no-member
              no_rendering_mode=False,
              synchronous_mode=True,
              fixed_delta_seconds=1.0 / 20,
          ))

I have tried to set the synchronous mode to false again before reloading a world, but that did not help either. The documentation (https://carla.readthedocs.io/en/latest/adv_traffic_manager/) states that I do not have to destroy the traffic manager myself.
Any help would be much appreciated.

@jackbart94 could you please take a look at this?

This might be related to #2789.

My guess would be that the problem is entirely on the client side. If I'm running a client with a traffic manager connecting to a server in synchronous mode, then start another server, get a client for the second server from the Python process running the first client, load a world and try to apply synchronous settings for the second server, that last call doesn't return. The issue goes away if I load the world and apply settings on both servers before getting a traffic manager on either one. I therefore suspect that setting the traffic manager in synchronous mode leaves some piece of state on the client side that prevents the call applying synchronous settings on the world from returning.

Makes sense, after restarting the python script (not the server) it does indeed work again, as also mentioned in the issue linked above.

This is a possible workaround for this issue: https://github.com/carla-simulator/carla/issues/2789#issuecomment-689619998.

Sorry if it took so much to open a PR for this issue, it appears we have found a way to fix it!
It will soon be merged in dev and then to master when 0.9.10 comes out, but if you want to test it (and give us feedback!) the branch is traffic_manager/map_change_fix
Thanks for your patience!

Thanks for the fix! I can confirm that I'm now able to reload the world using the CARLA version from traffic_manager/map_change_fix.


inline code inside list is not properly rendered

stuff like
- run `python main.py`

is not properly rendered. It breaks it into two lines

Thanks for reporting this!

The same thing happens to me with bold font:
- This should be __bold__


[DO NOT MERGE] V2 - Add CSS via custom webpack config

This is a resubmission of #401 modified to incorporate the changes from #462
Similar to #477, this PR is a PoC that uses a project level webpack config to start the V2 Retail React App.
This version extends the default webpack config from pwa-kit-build and adds the css-loader and style-loader.
To see the imported plugins in action, a simple <H1> tag has been added to the home page and is styled using some imported css.
When starting the App, you will see the following:

In the most recent commits to this PR, @olibrook has added an example that uses a custom webpack config to set up a working coffeescript app
Also, #462 has been merged. Closing this PR

In the most recent commits to this PR, @olibrook has added an example that uses a custom webpack config to set up a working coffeescript app
Also, #462 has been merged. Closing this PR


Brotli compress error for resources larger than 65536

We get a AH01386: Brotli compress error when we try to serve resources sized larger than 2^16 (65536) bytes with brotli compression:
You can easily reproduce it with:
$ printf '.%.0s' {1..65536} > /path/to/your/document/root/test.txt

$ curl -sIk -H 'Accept-Encoding: br' 'https://localhost/test.txt'
HTTP/1.1 200 OK
Date: Fri, 22 Jul 2016 15:41:33 GMT
Server: Apache
Vary: Accept-Encoding
Content-Encoding: br
Content-Length: 13
Content-Type: text/plain

Now try with 65537 or any larger number:
$ printf '.%.0s' {1..65537} > /path/to/your/document/root/test.txt

$ curl -sIk -H 'Accept-Encoding: br' 'https://localhost/test.txt'
HTTP/1.1 500 Internal Server Error
Date: Fri, 22 Jul 2016 15:41:58 GMT
Server: Apache
Connection: close
Content-Type: text/plain

BrotliCompressionLevel is set to  7, BrotliWindowSize is 22.

It did not result in an error in my development environment.
Please present the execution environment.

Test by my development environment
create httpd config and html contents
% mkdir {conf,html}
% : create conf/app.conf
% cat > conf/app.conf <<EOF
LoadModule brotli_module modules/mod_brotli.so
BrotliCompressionLevel 7
BrotliWindowSize 22
<VirtualHost *:80>
  ServerName localhost
  DocumentRoot ${APP}/html
  DirectoryIndex index.html
  AddDefaultCharset UTF-8
  <Directory ${APP}/html>
    Options FollowSymLinks
    Require all granted
    SetOutputFilter BROTLI
  </Directory>
</VirtualHost>
<VirtualHost *:443>
  SSLEngine on
  SSLProtocol all -SSLv3
  SSLCertificateFile /etc/pki/tls/certs/localhost.crt
  SSLCertificateKeyFile /etc/pki/tls/private/localhost.key
  ServerName localhost
  DocumentRoot ${APP}/html
  DirectoryIndex index.html
  AddDefaultCharset UTF-8
  <Directory ${APP}/html>
    Options FollowSymLinks
    Require all granted
    SetOutputFilter BROTLI
  </Directory>
</VirtualHost>
EOF
% : create html contents
% printf '.%.0s' {1..65536} > html/65536.txt
% printf '.%.0s' {1..65537} > html/65537.txt
% printf '.%.0s' {1..99999} > html/99999.txt

__run docker container __
% docker run --rm -v $(pwd):/app docker.io/kjdev/apache-mod-brotli
% : docker container ip -> <IP_ADDRESS>

Dockerfile
response html contents
% curl -skI -H "Accept-Encoding:br" https://<IP_ADDRESS>/65536.txt
HTTP/1.1 200 OK
Date: Mon, 25 Jul 2016 00:39:11 GMT
Server: Apache/2.4.23 (Fedora) OpenSSL/1.0.2h-fips
Last-Modified: Mon, 25 Jul 2016 00:27:55 GMT
ETag: "10000-5386adafa229a-br"
Accept-Ranges: bytes
Vary: Accept-Encoding
Content-Encoding: br
Content-Length: 13
Content-Type: text/plain; charset=UTF-8
% curl -skI -H "Accept-Encoding:br" https://<IP_ADDRESS>/65537.txt
HTTP/1.1 200 OK
Date: Mon, 25 Jul 2016 00:39:42 GMT
Server: Apache/2.4.23 (Fedora) OpenSSL/1.0.2h-fips
Last-Modified: Mon, 25 Jul 2016 00:27:58 GMT
ETag: "10001-5386adb34d23a-br"
Accept-Ranges: bytes
Vary: Accept-Encoding
Content-Encoding: br
Content-Length: 18
Content-Type: text/plain; charset=UTF-8
% curl -skI -H "Accept-Encoding:br" https://<IP_ADDRESS>/99999.txt
HTTP/1.1 200 OK
Date: Mon, 25 Jul 2016 00:39:57 GMT
Server: Apache/2.4.23 (Fedora) OpenSSL/1.0.2h-fips
Last-Modified: Mon, 25 Jul 2016 00:38:30 GMT
ETag: "1869f-5386b00df5a6e-br"
Accept-Ranges: bytes
Vary: Accept-Encoding
Content-Encoding: br
Content-Length: 25
Content-Type: text/plain; charset=UTF-8

check response html contents
% curl -sk -H "Accept-Encoding:br" https://<IP_ADDRESS>/65536.txt > 65536.br
% curl -sk -H "Accept-Encoding:br" https://<IP_ADDRESS>/65537.txt > 65537.br
% curl -sk -H "Accept-Encoding:br" https://<IP_ADDRESS>/99999.txt > 99999.br
% : brotili decompress: bro -> brotili command
% bro --decompress --input 65536.br > 65536.out
% bro --decompress --input 65537.br > 65537.out
% bro --decompress --input 99999.br > 99999.out
% : check contents
% diff -s 65536.out html/65536.txt
Files 65536.out and html/65536.txt are identical
% diff -s 65537.out html/65537.txt
Files 65537.out and html/65537.txt are identical
% diff -s 99999.out html/99999.txt
Files 99999.out and html/99999.txt are identical

Your test-setup works fine for us. And our compiled module works as expected in CentOS7's default system apache config, too. However, when we use the system apache with our larger config, the compression error still occurs.
After narrowing down the config, I found that I can trigger the error in your test setup when I disable MMap.
Add this to your Dockerfile:
RUN sed -i 's|#EnableMMAP.*|EnableMMAP Off|g' /etc/httpd/conf/httpd.conf

I think the problem is, that with MMap the input payload is delivered in a single big bucket, and without MMap the brigade contains a lot of 8kb buckets.
With a big chung, the handling of regular bucket types works as intended: If the chunk is larger than block_space (64k) brotli_compress() is called.
However, for a list of small chunks the housekeeping is missing: All chunks are smaller than 64k and are copied to the ring buffer. But copy_len == block_space is never true and brotli_compress() is never called. That is left to the EOS handling, where brotli finds a too large buffer.
I have changed the code to keep track of the ring buffer size. Now we can prevent it from growing bigger than block_space and do intermediate non-flushing calls to WriteBrotliData(). That works with and without MMap for small and large files.
Does that sound reasonable to you @kjdev?

#3 is a pull-request with our patch.

Thanks.
When the 'EnableMMAP off', we can see that is an error.
It was also able to confirm that it can be modified in the patch of #3 .

Thank you!


SAML assertions obtained with an OAuth2.0 OBO flow

The info for the SubjectConfirmationData in the SAML token should mention that the issued reply URL is the first one in the list of reply URLs set on the enterprise application. We don't return the reply URL marked as default in the SAML SSO setup but the first one in the list, and since this is not mentioned in the documentation for SAML assertions obtained with an OAuth2.0 OBO flow it's causing a confusion.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1d91ee0b-7926-c0ad-aca2-48958c81acf3
Version Independent ID: 9fa490aa-49e4-8034-83c2-d6c8517834da
Content: Microsoft identity platform and OAuth2.0 On-Behalf-Of flow - Microsoft identity platform
Content Source: articles/active-directory/develop/v2-oauth2-on-behalf-of-flow.md
Service: active-directory
Sub-service: develop
GitHub Login: @nickludwig
Microsoft Alias: ludwignick

@Alex-str11 Thank you for your feedback . We will investigate and update the thread.

@Alex-str11 This is assigned to the author to review and update.

assignto:shreyanth

#reassign:sreyanth

@Alex-str11 thanks for pointing this out. I updated our docs to clarify the behavior.
The Recipient value will be the first non-wildcard Reply URL configured in the resource application configuration and not the default Reply URL that's configured for that application.

@Alex-str11 thanks for pointing this out. I updated our docs to clarify the behavior.
The Recipient value will be the first non-wildcard Reply URL configured in the resource application configuration and not the default Reply URL that's configured for that application.

Hello Sreyanth
I don't understand what you meant, I have four reply URLs in Azure, how do I target the wanted Recipient in API Request and on Azure. Can you give an example? Thanks.


multi-domains: behavior on failure to continue for each other entries

Hello,
I'm using dehydrated 0.6.5, with http challenge.
My domains.txt file seems like :
example.com www.example.com server1.example.com
test.example.com
foo.example.com
service2.example.com
anotherdomain1.com www.anotherdomain1.com
anotherdomain2.com www.anotherdomain2.com

Everything is managed on one server named server1.example.com.
I'm working to migrate everything on server2.example.com.
I started by migrate one part. It took time.
I got an issue.
All the certificates needs to be renewed everything should be fine except one of the vhost (foo.example.com) that is move on the new server. The challenge produced by the server1 is not found on server2 by letsencrypt servers.
I used a simple workaround : comment the foo.example.com to renew all the other certificates.
The current behavior is "stop everything" on error.
I got:
- [x] OK: example.com www.example.com server1.example.com
- [x] OK: test.example.com
- [ ] FAILURE: foo.example.com
- [ ] nothing tried: service2.example.com
- [ ] nothing tried: anotherdomain1.com www.anotherdomain1.com
- [ ] nothing tried: anotherdomain2.com www.anotherdomain2.com

Feature/bug request:

It is possible to have a behavior to continue after a failure to try to renew all certificates ? do not let expire certificates because of a neighbour has an issue.

Are you using the --keep-going flag?
See the parameter list under "Usage" on the main page:
--keep-going (-g)                Keep going after encountering an error while creating/renewing multiple certificates in cron mode

oh... I really missed this option ?!
It seems exactly what I needs !
but ... why it is not the default behavior ?

but ... why it is not the default behavior ?

When you're using --keep-going, the script will continue normally. You'll need to review the cron logs or have some other way of verifying that your certificates were all renewed successfully. You won't have a non-zero exit code to indicate that the program terminated abonrmally.

Thanks @txr13. Closing this as it's solved :)

Really ? dehydrated are unable to manage a simple global error status ?!
This option is a trap...
I implemented the behavior by myself.
#!/bin/sh
set -e
cd -- "$(dirname "$0")"

ERROR=0
[ -f all.domains.txt ] || cp -a dommains.txt all.domains.txt
while read -r line; do
        case "$line" in ('#'*) continue;; esac
        echo "$line" > domains.txt
        ./dehydrated-v0.6.5 --config config "${@:--c}" || ERROR=1
done < all.domains.txt
cp -a all.domains.txt domains.txt
exit $ERROR

Regards,


Support ZCLv7 zigpy changes

https://github.com/zigpy/zigpy/pull/716

The Philips quirk currently implements the OnOff/start_up_on_off (0x4003) option "manually":
https://github.com/zigpy/zha-device-handlers/blob/833c1b913105c87fe93b8dfd20902d27ec4004f8/zhaquirks/philips/__init__.py#L93-L97
I guess this can be removed in the future then. (But having it also shouldn't hurt anything)

It looks like all of the Philips/Signify light quirks can be removed, since they were just exposing the new ZCLv7 startup attributes.

@puddly I will only be able to check on Friday, no earlier, too busy...

Hi @puddly, sorry for the delay!
It appears that you can just remove the client io_sample command for this cluster, it's not used. I just tested it on my environment.

@puddly this still a thing?

Yeah, gotta finish the zigpy side. Forgot what I got stuck on...

I've updated this PR and the corresponding one in zigpy with the changes since May. Both are functional for me. However, my network is pretty homogeneous and quirks at the moment doesn't have complete unit test coverage so I'm not confident that the code is free of any new bugs.
Does anyone with Tuya devices or others that require heavy attribute/command rewriting in quirks want to try these changes out?
You can setup an editable copy of ZHA in your custom_components folder (https://github.com/zigpy/zigpy/issues/826#issuecomment-947850313) and update the zigpy and quirks dependencies in the manifest.json file:
git+https://github.com/puddly/zigpy@puddly/zclv7
git+https://github.com/puddly/zha-device-handlers@puddly/zclv7-fixes

I can  trying it on my large test network (13 devices 5 routers and 8 SED) but i think its not helping then its have some routers and all types of IKEA controllers and one tuya TRV but is using  my new quirk and is not using the tests (i have broken all test then reworking the quirk) and they is not sending so much data but i can playing with them so they is doing it.
Also i have local quirks that is not in HA 2021-10 (IKEA 5 button and shortcut) but they is in your dev so shall not being any problems.
I can "de patching" ZHA (patch for presets for my TRV) and using the old quirk for the testing then the TRV is on my living room table.
If you like i can doing it but i dont knowing if its helping your test case.

If you like i can doing it but i dont knowing if its helping your test case.

Thanks. Any real-world Tuya tests are better than none.

@puddly can you explaining how to change the manifest.json i only getting error and ZHA is not loading.
And shall i putting the complete downloaded git only the zgpy / zhaquirks folder in the custom_components folder ?
I have forgetting how i was doing then running bellows alpha / beta as custom_components ;-((

My mistake, Home Assistant runs more checks on the requirements in manifest.json before passing them to pip.

Copy/paste the homeassistant/components/zha folder into custom_components/zha. You could also git clone the Home Assistant repo and symlink the folder to track your changes.
Edit manifest.json and add a top-level "version": "1.0.0" key so it loads as a custom component.
Edit manifest.json and replace the zigpy==... dependency with django@git+https://github.com/puddly/zigpy@puddly/zclv7[^1].
Do the same for zha-quirks==...: django@git+https://github.com/puddly/zha-device-handlers@puddly/zclv7-fixes.

diff --git a/custom_components/zha/manifest.json b/custom_components/zha/manifest.json
index 1fa15259..56b76c4a 100644
--- a/custom_components/zha/manifest.json
+++ b/custom_components/zha/manifest.json
@@ -1,4 +1,5 @@
 {
+  "version": "1.0.0",
   "domain": "zha",
   "name": "Zigbee Home Automation",
   "config_flow": true,
@@ -7,9 +8,9 @@
     "bellows==0.28.0",
     "pyserial==3.5",
     "pyserial-asyncio==0.5",
-    "zha-quirks==0.0.63",
+    "django@git+https://github.com/puddly/zha-device-handlers@puddly/zclv7-fixes",
     "zigpy-deconz==0.13.0",
-    "zigpy==0.41.0",
+    "django@git+https://github.com/puddly/zigpy@puddly/zclv7",
     "zigpy-xbee==0.14.0",
     "zigpy-zigate==0.7.3",
     "zigpy-znp==0.6.1"

[^1]: django can really be any package name, it's just to trick Home Assistant into thinking it's not installed and then passing that whole string to pip. I picked django because it's probably not installed and won't be maliciously parked.

I was adding the first with version and deleting the zigpy and zha_quirk.
Then running pip in the  HA container with your 2 gits and restarting HA and somthing have being loaded:
Logger: homeassistant.config_entries
Source: components/zha/__init__.py:99
First occurred: 22:44:15 (1 occurrences)
Last logged: 22:44:15

Error setting up entry socket://<IP_ADDRESS>:6638 (LIDL LED NCP) for zha
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/config_entries.py", line 304, in async_setup
    result = await component.async_setup_entry(hass, self)  # type: ignore
  File "/usr/src/homeassistant/homeassistant/components/zha/__init__.py", line 99, in async_setup_entry
    setup_quirks(config)
  File "/usr/local/lib/python3.9/site-packages/zhaquirks/__init__.py", line 394, in setup
    importlib.import_module(modname)
  File "/usr/local/lib/python3.9/importlib/__init__.py", line 127, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 1030, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1007, in _find_and_load
  File "<frozen importlib._bootstrap>", line 986, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 680, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 850, in exec_module
  File "<frozen importlib._bootstrap>", line 228, in _call_with_frames_removed
  File "/usr/local/lib/python3.9/site-packages/zhaquirks/centralite/__init__.py", line 11, in <module>
    class CentraLiteAccelCluster(CustomCluster):
  File "/usr/local/lib/python3.9/site-packages/zigpy/zcl/__init__.py", line 91, in __init_subclass__
    raise TypeError(
TypeError: `manufacturer_attributes` is deprecated. Copy the parent class's `attributes` dictionary and update it with your manufacturer-specific `attributes`. Make sure to specify that it is manufacturer-specific through the  appropriate constructor or tuple!

I shall deleting my custom quirks then they can doing bad things and reporting back.

The error is coming from /usr/local/lib/python3.9/site-packages/zhaquirks/centralite/__init__.py so it seems like the zha-quirks package is not on the ZCLv7 branch, only zigpy.

I was doing one pip uninstall zha-quirks and then one "puddly" pip install git+https://github.com/puddly/zha-device-handlers@puddly/zclv7-fixes
and restarted HA and i have no errors and my tuya TRV have loosing its patched quirks so i thinks its loaded OK.
I think PIP was not deleting the old OK then installing the new one.
I testing little but i must going to sleep then having working to do tomorrow noon but i testing then i have time.

The TRV without the updated quirk dont have so many functions only on / off and setting / reporting setpopint temperature but i have ding both in ZHA and local for nearly one half hour and its very fast reporting to ZHA but slow reacting on commands but its still one "half sleeping end device" so its normal.
No error or warning in HA the log but the log file its being pity large with my debug setting.
Shall i testing all IKEA controllers 2 or is the tuya TRV enough ?

One error in the test setup but i dont knowing if its related to this update:
Logger: homeassistant.components.websocket_api.http.connection
Source: components/zha/api.py:631
Integration: Home Assistant WebSocket API (documentation, issues)
First occurred: November 14, 2021, 23:40:09 (2 occurrences)
Last logged: November 14, 2021, 23:40:54

[140339730776896] Error handling message: Unknown error
Traceback (most recent call last):
 File "/usr/src/homeassistant/homeassistant/components/websocket_api/decorators.py", line 26, in _handle_async_response
   await func(hass, connection, msg)
 File "/usr/src/homeassistant/homeassistant/components/zha/api.py", line 631, in websocket_device_cluster_commands
   ATTR_NAME: commands[CLUSTER_COMMANDS_SERVER][cmd_id][0],
TypeError: 'ZCLCommandDef' object is not subscriptable

Was looking in the log and i have some logging enabled but not so much and its was triggered the reporting attributes form one IKEA CWS 3 (the new RGBW bulb with MG21 module) or from analytics HA is collecting:
2021-11-14 23:32:15 DEBUG (MainThread) [zigpy.zcl] [0x6c21:1:0x0300] ZCL request 0x000a: Report_Attributes(attribute_reports=[Attribute(attrid=0x0007, value=TypeValue(type=uint16_t, value=250))])
2021-11-14 23:32:15 DEBUG (MainThread) [zigpy.zcl] [0x6c21:1:0x0300] Attribute report received: color_temperature=250
2021-11-14 23:33:15 INFO (MainThread) [homeassistant.components.analytics] Submitted analytics to Home Assistant servers. Information submitted includes {'uuid': 'bbe501a5c0d44ed687d61bf1bc49b40b', 'version': '2021.11.0', 'installation_type': 'Home Assistant Container'}
2021-11-14 23:40:09 ERROR (MainThread) [homeassistant.components.websocket_api.http.connection] [140339730776896] Error handling message: Unknown error
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/components/websocket_api/decorators.py", line 26, in _handle_async_response
    await func(hass, connection, msg)
  File "/usr/src/homeassistant/homeassistant/components/zha/api.py", line 631, in websocket_device_cluster_commands
    ATTR_NAME: commands[CLUSTER_COMMANDS_SERVER][cmd_id][0],
TypeError: 'ZCLCommandDef' object is not subscriptable
2021-11-14 23:40:54 ERROR (MainThread) [homeassistant.components.websocket_api.http.connection] [140339730776896] Error handling message: Unknown error
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/components/websocket_api/decorators.py", line 26, in _handle_async_response
    await func(hass, connection, msg)
  File "/usr/src/homeassistant/homeassistant/components/zha/api.py", line 631, in websocket_device_cluster_commands
    ATTR_NAME: commands[CLUSTER_COMMANDS_SERVER][cmd_id][0],
TypeError: 'ZCLCommandDef' object is not subscriptable
2021-11-14 23:42:47 DEBUG (MainThread) [zigpy.zcl] [0x6c21:1:0x0006] ZCL header: ZCLHeader(frame_control=FrameControl(frame_type=<FrameType.GLOBAL_COMMAND: 0>, is_manufacturer_specific=0, is_reply=1, disable_default_response=0, reserved=0, *is_cluster=False, *is_general=True), tsn=120, command_id=10, *is_reply=1)
2021-11-14 23:42:47 DEBUG (MainThread) [zigpy.zcl] [0x6c21:1:0x0006] ZCL request 0x000a: Report_Attributes(attribute_reports=[Attribute(attrid=0x0000, value=TypeValue(type=Bool, value=<Bool.false: 0>))])
2021-11-14 23:42:47 DEBUG (MainThread) [zigpy.zcl] [0x6c21:1:0x0006] Attribute report received: on_off=<Bool.false: 0>
2021-11-14 23:42:47 DEBUG (MainThread) [zigpy.zcl] [0x6c21:1:0x0008] ZCL header: ZCLHeader(frame_control=FrameControl(frame_type=<FrameType.GLOBAL_COMMAND: 0>, is_manufacturer_specific=0, is_reply=1, disable_default_response=0, reserved=0, *is_cluster=False, *is_general=True), tsn=121, command_id=10, *is_reply=1)
2021-11-14 23:42:47 DEBUG (MainThread) [zigpy.zcl] [0x6c21:1:0x0008] ZCL request 0x000a: Report_Attributes(attribute_reports=[Attribute(attrid=0x0000, value=TypeValue(type=uint8_t, value=42))])
2021-11-14 23:42:47 DEBUG (MainThread) [zigpy.zcl] [0x6c21:1:0x0008] Attribute report received: current_level=42

Then the error its tagged ZHA is not very likely its not relented to the analytic and around the error (5 minutes before and 30 minutes after) it was only the IKEA light that was reporting attributes.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

198 of 227 (87.22%)  changed or added relevant lines in 50 files are covered.
3 unchanged lines in 2 files lost coverage.
Overall coverage increased (+0.1%) to 80.293%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

zhaquirks/mli/tint.py
0
2
0.0%

zhaquirks/tuya/init.py
20
22
90.91%

zhaquirks/tuya/ts0601_electric_heating.py
1
3
33.33%

zhaquirks/tuya/ts0601_trv_sas.py
2
4
50.0%

zhaquirks/elko/init.py
0
3
0.0%

zhaquirks/xiaomi/init.py
19
23
82.61%

zhaquirks/init.py
1
6
16.67%

zhaquirks/tuya/ts0601_trv.py
53
62
85.48%

Files with Coverage Reduction
New Missed Lines
%

zhaquirks/init.py
1
78.13%

zhaquirks/tuya/ts0601_trv_sas.py
2
54.55%

Totals

Change from base Build<PHONE_NUMBER>:
0.1%

Covered Lines:
5366

Relevant Lines:
6683

💛  - Coveralls


There's a bit of a lag while moderating contents at the very bottom of a page of reports.

Describe the issue/bug :
While scrolling down through many reports and moderating them, it gets pretty laggy while choosing deletion reasons, scrolling, right-clicking, and moderating the content.
To Reproduce :

Visit the new mod panel.
Scroll down such that more than 372 reports are visible.
Click on "✏" and you might experience some lag.

Profile link [paste below] -->
https://brainly.in/app/profile/2709968

Ok so the main problem here is; whenever you scroll, the page tries to show reports by creating these elements, for example

A single element shown in the GIF consumes an insignificant amount of memory(RAM). But when the number of elements gets increases, this may result in lots of memory consume that can lead you to have a laggy page.
To solve this, the page will remove report boxes located in the upper/lower side of the viewport/screen when the user scrolls the page. Removal of the elements from the page will decrease the memory usage by freeing the RAM.
But this has a side effect. Users will not be able to use the browser's search tool(CTRL+F) to find texts on the page. Since elements that supposed to contain strings that users may want to find will get removed

Ohh, okay, got it. ✔
Maybe, to prevent this, we can restrict the amount of reports shown in one page? Say the limit of contents displayed in one page is 400, and the moderator will have to shift to the next page to moderate the next 400 reports. [Just a suggestion] 🤔
And, whenever the "LOAD REPORTS" feature is used, the solution you've described above comes to play?


Interface Optimization: Notes Field

Is your feature request related to a problem? Please describe.
At the moment note field for custom dkp add is small and you are unable to actually see full message in there after dozen on symbols
Describe the solution you'd like
Several solutions available from best to worse:

Show full text in the field while hoving mouse cursor over the field.
Make field flex (auto-changing size) while typing and then back to normal state when you've made addition.
Make field bigger statically. Worst option as it will eat space in the menu, while we try to stay minimalistic.

Additional context
here.]https://cdn.discordapp.com/attachments/841274229843296256/938779897537658930/unknown.png - current field screenshot

All GUI requests are to be denied at this point. UI requires general overhaul and no extensions to it are planned at this stage from our pov.
We need to rework whole GUI when the standby feature is done. Any help with reworking it will be appreciated.


double free or corruption in sctp_free_assoc

jvb_1      | * Error in `java': double free or corruption (!prev): 0x00007fd91c0caa00 *
jvb_1      | ======= Backtrace: =========
jvb_1      | /lib/x86_64-linux-gnu/libc.so.6(+0x70bfb)[0x7fd9b56f7bfb]
jvb_1      | /lib/x86_64-linux-gnu/libc.so.6(+0x76fc6)[0x7fd9b56fdfc6]
jvb_1      | /lib/x86_64-linux-gnu/libc.so.6(+0x7780e)[0x7fd9b56fe80e]
jvb_1      | /tmp/nativeutils1277245423677833/libjnisctp.so(sctp_free_assoc+0x1704)[0x7fd97c763fb1]
jvb_1      | /tmp/nativeutils1277245423677833/libjnisctp.so(sctp_timeout_handler+0xb73)[0x7fd97c789adc]
jvb_1      | /tmp/nativeutils1277245423677833/libjnisctp.so(+0x9bb23)[0x7fd97c7a8b23]
jvb_1      | /tmp/nativeutils1277245423677833/libjnisctp.so(user_sctp_timer_iterate+0xd8)[0x7fd97c7a8c52]
jvb_1      | /lib/x86_64-linux-gnu/libpthread.so.0(+0x74a4)[0x7fd9b605a4a4]
jvb_1      | /lib/x86_64-linux-gnu/libc.so.6(clone+0x3f)[0x7fd9b576fd0f]

This happened to us during a conference. Any ideas? Should I report it upstream?

We haven't seen this in a while, but we're not using SCTP much anymore.  You could report it upstream, but the version of usrsctp we're using at this point is probably a bit old, so I'm guessing they'll just say to update to latest.

Okay, no need to report it then. But is it a good idea to update the usrscpt here or what are your plans for the future?

We no longer use SCTP in the JVB in our deployments, which was our only rear use case for this lib, so this repo doesn't get a lot of attention.  I do hope to get around to merging the build improvements PR (https://github.com/jitsi/jitsi-sctp/pull/3) which should make it easier to update.

 So you say you don't use JVB in your deployments (you mean on meet.jit.si for example?).
If this is better,  it possible to disable SCTP, too?

Sorry, we do use the JVB in our deployments, but there are 2 supported client <-> jvb channel transports we support: datachannels (which use SCTP) and websockets.  We have moved over to using websockets for this channel, which means we don't exercise the SCTP code in the bridge really.

Thanks, I'll give it a try. For anybody who finds that issue here, see https://github.com/jitsi/jitsi-videobridge/blob/master/doc/web-sockets.md for enabling websockets.


NASNet Bug

hello
I've read the tensorflow version of nasnet and compared with your implementation.
I guess
https://github.com/Cadene/pretrained-models.pytorch/blob/795f3710648c49792530c721d632a0ec0e7ed628/pretrainedmodels/models/nasnet.py#L565
should be
x_cell_6 = self.cell_6(x_reduction_cell_0, x_cell_5)
and
https://github.com/Cadene/pretrained-models.pytorch/blob/795f3710648c49792530c721d632a0ec0e7ed628/pretrainedmodels/models/nasnet.py#L574
should be
x_cell_12 = self.cell_12(x_reduction_cell_1, x_cell_11)
isn't it?

Thanks for submitting this issue. However, I don't think our implementation is wrong.
How did you see this? Does our implementation work better with these modifications?


Failed to load X-Ray Mod Version 2.2.0, 1.19.3 Forge

The bug occurs without having Optifine or Optifabric installed? (Optifine bugs won't be fixed)

[X] Yes, I don't have Optifine install.

Mod version
1.19.3 (2.2.0)
Minecraft version
1.19.3
Mod loader
Forge
Description of the issue
I tried to load the mod, but at the start of Minecraft it crashes instantly. I´ve attached below the crashlog, latestlog, and a screenshot of the minecraft error message.
I´t also doesn´t work with the Mod Version 2.0.5
I hope thats enough for the problem.
And yes Optifine is NOT installed.
If you need anything else just contact me.
Excepted behavior
load minecraft normally
Obtained behavior
it crashes instantly
How to reproduce

install forge
drag your xray mod in folder
start minecraft
crash minecraft

Do I want to contribute to fix it?
None
Something else?

crash-2023-07-17_22.45.19-fml.txt
latest.log

XrayMod-2.2.0.jar

I´m sorry I´ve got the mod from a site where they mixed up the version of your mod and the minecraft version. And I got this github page through the logfile.
But thanks for the fast reply and that you pointed me out the correct version.
The Mod works fantastic. :)


How to mark dialog as read?

I want to mark all messages in dialog as read without go to dialog view and see all of them.
How can I do this?

Hi @tranngoclinh88 ,
You can use method:
+ (QB_NONNULL QBRequest *)markMessagesAsRead:(QB_NULLABLE NSSet QB_GENERIC(NSString *) *)messagesIDs
                                    dialogID:(QB_NONNULL NSString *)dialogID
                                successBlock:(QB_NULLABLE void(^)(QBResponse * QB_NONNULL_S response))successBlock
                                  errorBlock:(QB_NULLABLE QBRequestErrorBlock)errorBlock;```

and put `nil` to parameter `messagesIDs`


Add suffix to ServiceBus queues used in CI

Codecov Report

Merging #316 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #316      +/-   ##
==========================================
+ Coverage   98.75%   98.75%   +<.01%
==========================================
  Files          14       14
  Lines        1200     1206       +6
==========================================
+ Hits         1185     1191       +6
  Misses         15       15

Impacted Files
Coverage Δ

opwen_email_server/config.py
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d15c529...edfe4c7. Read the comment docs.


Pre-set filters do not work with spatial filter

When spatial filter state is set within the filterProperties, it does not show up on the map.

Sorry, my bad, it was an issue on my side. Closing the issue.


RTD Docs are not building correctly.

The RTD docs are not being generated properly.

It's not perfect and needs some formatting tweaks, but the basics work now.


docs: add usage of "gas branch" command to cli_commands.rst

Pull Request Test Coverage Report for Build 905820098

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 82.42%

Totals

Change from base Build 905548003:
0.0%

Covered Lines:
4379

Relevant Lines:
5313

💛  - Coveralls


submodules are only ignore if files_changed_only is True

I noticed this on a repo I'm developing that has 4 submodules. When the CI runs
cpp-linter --files-changed-only=false

All the submodules are crawled as if they're part of the current repo's original sources.
Moving the algorithm that detects submodules from list_source_files() into parse_ignored_option() should fix this, but I have to be careful to consider if the user explicitly specifies a submodule to be not ignored.

When --files-changed-only=ture, it should ignore submodules.
When --files-changed-only=false, analyze any source files in the repo including submodules.
So the current behavior of --files-changed-only=false is not expected?
I'm wondering if we should change files-changed-only default value to true. I guess users only care about modified files, not all source files.

When --files-changed-only=false, analyze any source files in the repo including submodules.

This was not my original intention. It doesn't make sense (to me) for a linter to be concerned with external sources. That's why in the README, I noted the ignore option can be used to explicitly include submodules (just not hidden folders that begin with a . like .github).

I'm wondering if we should change files-changed-only default value to true. I guess users only care about modified files, not all source files.

I have no objections to this. I think this was the original default until we started encouraging users to have a actions/checkout step. I also expect most users only want the file changes analyzed. Personally, I've been using this action to check all sources in my projects (for completeness because I itch for that 💯 ). I haven't been using clang-tidy for anything lately (but that may change in the future).

I'm almost draft a PR... There's a lot of changes, so the description will be wordy. I'd like to learn a bit more about pytest (& plugins) to optimize the unit tests I've written.

It doesn't make sense (to me) for a linter to be concerned with external sources

I agree we should only analyze any source files and ignore submodules when --files-changed-only=false
No worries, take your time. I'm also learning about pytest to refactor my bad smell unit tests :(

I might have to use a matrix in the CI to test various versions of python with various versions of clang-tools... My new database test is failing in CI, but it passes fine locally.

It also failed in my local environment.
/home/ubuntu/.local/lib/python3.8/site-packages/requests/adapters.py:501: ConnectionError
--------------------------------------------- Captured log call ---------------------------------------------
WARNING  CPP Linter:run.py:340 Could not find pcsound/pcsound.c! Did you checkout the repo?
========================================== short test summary info ==========================================
FAILED tests/lines_changed_only/test_lines_changed_only.py::test_run_clang_format_diff_only - requests.exc...
FAILED tests/lines_changed_only/test_lines_changed_only.py::test_run_clang_format_diff_adds - requests.exc...
================================= 2 failed, 22 passed in 257.41s (0:04:17) =================================

It's hang and failed from tests/lines_changed_only/test_lines_changed_only.py::test_run_clang_format_diff_only
tests/ignored_paths/test_ignored_paths.py::test_not_ignored PASSED                                    [ 83%]
tests/ignored_paths/test_ignored_paths.py::test_ignore_submodule PASSED                               [ 87%]
tests/lines_changed_only/test_lines_changed_only.py::test_lines_changed_only PASSED                   [ 91%]
tests/lines_changed_only/test_lines_changed_only.py::test_run_clang_format_diff_only

It failed locally for you because it couldn't download the source files from the commit that I'm using in the test.

I've been playing with test coverage to see what else needs to be tested. So far I'm (locally) getting 94% coverage if I exclude any functions that directly use the REST API for thread comments:

I also configured coverage.py to ignore type checking specific code and anything related to using rich as a logging extension, thus __init__.py is 100% covered. cpp_linter/thread_comments.py is also ignored because we would need a real CI event to test that code.
@shenxianpeng I see you've already created a codecov token for cpp-linter/clang-tools-pip. Can you create a org secret with a new codecov token, so we can use it for multiple repos? Or does the token have to specific to a project?
ps - Ensuring the best coverage has caused further improvements to the code base.

The test coverage is already very high 👍
@2bndy5 I have created a org secret with a new codecov token and also removed codecov token for cpp-linter/clang-tools-pip, then rerun the test action of clang-tools-pip, it still works.


Add typescript support

Hey, thanks for the useful package @ungoldman! I added TypeScript typings for your code, so TypeScript/Flow/Reason users can use this package too.
Happy holidays!

Hi @bcherny! I'm glad you found this to be useful. I wrote this several years ago when I was still working for Esri. I no longer have admin access to this repository, but @dmfenton or @jgravois may be able to review your pull request.
🖖

@dmfenton or @jgravois may be able to review your pull request.

certainly. thanks for the contribution @bcherny! i'll take a closer look in the next couple days.

prior relevant discussion: https://github.com/Esri/terraformer/issues/305


Auto ignore offenses with corrections over the size limit

I see multiple errors #8203, #8025, #8283 that all have the same pattern: a Style cop wants to do an auto-correction and goes through hoops to see if the correction would create too long a line.
This feels like an anti-pattern: the cop should add the offense and provide the auto-correction with a flag saying "hey, just ignore me if this is too long". The engine has all the necessary information to ignore it or not.
Is it worth doing?
cc/ @Drenmi @jonas054

But the cop should also refrain from reporting the offense in the first place, if correcting it would yield a line that's too long. So it would have to always run the auto-correction logic, even if --auto-correct was not given. To me, this seems complicated, and I would prefer to keep things as they are. Unless someone has an elegant solution to convince me. :slightly_smiling_face:

So it would have to always run the auto-correction logic, even if --auto-correct was not given.

Correct.

To me, this seems complicated

I'm not sure it is. I would make a copy of the corrector, do a remove for all lines before and after it, apply it and check the length of the resulting lines.
I think the resulting LOC would be about what it takes just to to implement the current check on #8203


WikiLinks - Forbidden failures may go away if useragent is properly set?

see https://stackoverflow.com/questions/46604840/403-response-with-httpclient-but-not-with-browser
example:
Talk:TIAA   https://bogleheads.org/wiki/Talk:TIAA
    Forbidden    http://www.sec.gov/Archives/edgar/data/1429401/000119312510093446/dex21.htm

added useragent via commit: https://github.com/bogle-tools/site/commit/e48e87c0cc6dcc2c81dc3cf5e4e67f827b1152b3


okhttp-digest unresolvable on maven central

Our customer is at a dead stop because com.burgstaller:okhttp-digest:jar:1.14 can't be resolved on maven central.

https://github.com/marklogic/java-client-api/issues/795
Add this repository to your pom.xml repostories section:
<repository>
	<id>jcenter</id>
	<url>http://jcenter.bintray.com</url>
</repository>

@tdiepenbrock, are there better ways we can advertise such requirements?  We included it on http://developer.marklogic.com/products/java , but maybe we should have it somewhere else also...  Where did the customer go to download 4.0.2?

It's worth creating a ticket asking them to publish to Maven Central.Bintray makes it really easy. Then it would resolve and "just work" without custom repository config.

Hi Sam,
It looks like the customer relies on Maven Central for everything.  They did not pull from the separate repo.  I’ll find out more tomorrow when we have our regularly scheduled conference call with them.
td
Thomas Diepenbrock
Technical Manager
MarkLogic Corporation
Thomas.Diepenbrock<EMAIL_ADDRESS>Cell:  +1<PHONE_NUMBER>
[cid:0B48B25A-8630-42FD-BFB9-3092CB213523] http://www.marklogic.com/social/
http://www.marklogic.com/social/
On Sep 18, 2017, at 12:32 PM, Sam Mefford <notifications<EMAIL_ADDRESS>wrote:
@tdiepenbrockhttps://github.com/tdiepenbrock, are there better ways we can advertise such requirements? We included it on http://developer.marklogic.com/products/java , but maybe we should have it somewhere else also... Where did the customer go to download 4.0.2?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/marklogic/java-client-api/issues/817#issuecomment-330279057, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AH7cXQ7d0vWXkFIAfrfK2TFU0MmB9xkaks5sjpsegaJpZM4Pa_kG.

Is this still an issue? It’s not really in our control, as it’s a descendent ancestor.


PHP 23.8.0 broke Drupal sites without cookie_samesite: Lax set in services.yml

After upgrading sites without cookie_samesite: Lax set in services.yml, it is not possible to login - an error To log in to this site, your browser must accept cookies from the domain is shown.
This PR https://github.com/uselagoon/lagoon-images/pull/755 introduced the overrides for cookie_samesite with a default value of None.
None has a special value when written in INI files. As per this bug report, it should be quoted "None".
The tests are not checking for quoted "None" https://github.com/uselagoon/lagoon-images/pull/755/files#diff-ef4add63b95387c9d137ce74198e6b3f5ae2d53d4218ce505831c8734a61ed13R348
With that said, it is not clear why, while having the value set to un-quoted None in ini, the cookie_samesite behaves like Strict.
The workaround is to simply add cookie_samesite: Lax to the site's services.yml.

Our php images do quote the ini value as "None":
➜  ~ docker run --rm -it uselagoon/php-8.1-cli:23.8.0 \
grep samesite /usr/local/etc/php/conf.d/00-lagoon-php.ini

configured lagoon-php.ini
session.cookie_samesite = "None"

I tested our Drupal 10 example and OOTB I was able to login without issues. The core services.yml and the default.services.yml both use Lax already, which overrides the php.ini value. Which option was set for your sites that broke?
Perhaps "None" is not a good default, since it requires the secure attribute to be true also, and is not compatible with older browsers: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Set-Cookie#samesitesamesite-value

@rocketeerbkw
thank you for working on this!
I can confirm that this affects non-Drupal sites (Matomo) - the cookie_samesite value gets mixed up and it is not possible to login locally.
It would be great to have this merged into a latest release.

@AlexSkrypnyk if you want to reconfirm locally - the images for this PR are at testlagoon/php-8.1-cli:pr-823 etc

Just a temp workaround - add the following to docker-compose.yml:
x-environment
  PHP_SESSION_COOKIE_SAMESITE: ""


⚠ Jenkins Plugins Artifactory has degraded performance

In c058913, Jenkins Plugins Artifactory (https://get.jenkins.io/plugins/artifactory/) experienced degraded performance:

HTTP code: 200
Response time: 1236 ms

Resolved: Jenkins Plugins Artifactory performance has improved in 3cb44ea after 18 minutes.


Bugfix/TS 489 Diversity Report Change Calculations

What's included?
Related issue: User Raised Issue BR_ADMIN_PR_000268 #489

Fix change calculations.

Who should test?
✅ Product owner
✅ Developers
How to test?
Example exercise on Production
Steps:

Go to the Diversity Report of an exercise.
Check if the changes are calculated correctly.

Risk - how likely is this to impact other areas?
🟢 No risk - this is a self-contained piece of work
Additional context
Include screen grabs, video demo, notes etc.
Related permissions
Have permissions been considered for this functionality?

No permission changes required
Permissions have been added / updated. Details:

PREVIEW:PRODUCTION
can be OFF, DEVELOP or STAGING

@HalcyonJAC Calculations all look good now :-) Just one thing: we don't need the % Change from previous column on the Applied tab. Is it possible to hide that column on the Applied tab only? Make the test white, would that be a quick solution?

@nickaddy The % Change from previous column has been hidden on the Applied tab. Could you test it again, please?