v7.4.0 export error

I am not sure, if this is intended or not, but I am getting an error when build my application with v7.4.0
> Build error occurred
/app/node_modules/vis-data/peer/index.js:1
export * from "./esm";
^^^^^^

SyntaxError: Unexpected token 'export'
    at wrapSafe (internal/modules/cjs/loader.js:1063:16)
    at Module._compile (internal/modules/cjs/loader.js:1111:27)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1167:10)
    at Module.load (internal/modules/cjs/loader.js:996:32)
    at Function.Module._load (internal/modules/cjs/loader.js:896:14)
    at Module.require (internal/modules/cjs/loader.js:1036:19)
    at require (internal/modules/cjs/helpers.js:72:18)
    at /app/node_modules/vis-network/peer/umd/vis-network.js:28:82
    at Object.<anonymous> (/app/node_modules/vis-network/peer/umd/vis-network.js:31:2)
    at Module._compile (internal/modules/cjs/loader.js:1147:30) {
  type: 'SyntaxError'
}
error Command failed with exit code 1.

Am I doing something wrong or is this an error with the new build system?

Hi @mikebarkmin,
I tried updating my project and it works fine. This seems like your importing ESM files from something that expects UMD. All the help files (like peer/index.js) are in ESM and intended to be used with bundlers that generally can process ESM without issues. If you need UMD you should import with something like vis-network/peer/umd/vis-network.min.js.
Though this may be completely off, without more info like whether you're using a bundler, how you import it etc. I can't really help you.

ok thank you. Using the UMD module fixed it.


Document relationship between min_idle, idle_timeout and max_lifetime

Looking at the documentation of Builder doesn't currently help understand r2d2's behaviour, when trying to answer questions like "how do I make sure there's always at least one connection at any given instant".
This is related to ivanceras/r2d2-sqlite#39: currently ::memory is basically broken (at least in the sense of pooling connection, every connection from the pool is independent).
It's possible that sqlite's mode=memory could be used to fix the issue (at least in part, it has limitations still) but sqlite will automatically delete and release the database if it has no connections open, so for this to work properly there needs to be a way to configure the pool such that once the first connection has been created there is always at least one connection in the pool at any instant.

If you set idle_timeout and max_lifetime to None, your connections should always stay open.


⚠ Minecraft has degraded performance

In f548a13, Minecraft (https://www.minecraft.net) experienced degraded performance:

HTTP code: 200
Response time: 1176 ms

Resolved: Minecraft performance has improved in 2324c06.


Is Multi-tenant login is possible using Non-Microsoft account???

Is Multi-tenant login is possible using Non-Microsoft account???
[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: cc84ec3c-dcb4-b735-5c51-5e7b1417a341
Version Independent ID: 39d44a1e-06e5-40d2-9c6c-d011377bdc13
Content: Single and multi-tenant apps in Azure AD - Microsoft identity platform
Content Source: articles/active-directory/develop/single-and-multi-tenant-apps.md
Service: active-directory
Sub-service: develop
GitHub Login: @rwike77
Microsoft Alias: ryanwi

@ricktam1469
Thanks for your feedback! We will investigate and update as appropriate.

@ricktam1469
Thank you for your time and patience throughout this issue!
For signing in with a Non-Microsoft account on a multi-tenant app, I tested this out using my Yahoo email, and was able to log-in once I invited my user to my AzureAD tenant.

If you have any other questions, please let me know.
Thank you for your time and patience throughout this issue.

@ricktam1469
I just wanted to check in and see if you had any other questions or if you were able to read my previous comment?

Yes it is resolved.


loss around 20 but yolo_video.py won't detect object

Loss pretty stable during stage 1 but when testing it with one of the training data images it doesn't detect the object

some training data didnt have object in it so it learned to not detect object to reduce loss, took out images without training object and it worked


[SEDONA-285] Added docker images for spark-sedona-zeppelin and spark-sedona-jupyterlab

Added docker images for spark-sedona:1.3.1-zeppelin and spark-sedona1.4.0-jupyterlab
Issue: #842
Did you read the Contributor Guide?

Yes, I have read Contributor Rules and Contributor Development Guide

Is this PR related to a JIRA ticket?

Yes, SEDONA-285

What changes were proposed in this PR?
Added docker images for spark-sedona:1.3.1-zeppelin and spark-sedona1.4.0-jupyterlab
How was this patch tested?
Local environment with docker.
Did this PR include necessary documentation updates?

Yes, I have added readmes in respective folders.

@kartikeyhadiya Thanks for your contribution. A few comments:

Since this is a major contribution, please create a JIRA ticket first.
Please do not duplicate any data files in the source repo. The source repo already has a couple of data files in binder. Please try to reuse those via Dockerfile.
Please do not directly copy jars to the source repo. Please download jars on the fly via Dockerfile.
All source code such as .sh script must have Apache License as the file header.
Once everything is done, you will need to add the docker compilation to GitHub Action with a Yaml file.

Thanks for your input.
For 2 & 3 point i just thought that if anyone wants to replicate they can just download the docker folder and start working but, I will make the necessary changes.
Can you please elaborate on 5 point? I have never used github actions, are you referring something like this https://docs.github.com/en/actions/creating-actions/creating-a-docker-container-action or https://josephrodriguezg.medium.com/build-and-publish-docker-images-with-github-actions-78be3b3fbb9b ?

I have created jira ticket and included it in main comment

@kartikeyhadiya Yes, for No.5, we will need docs.github.com/en/actions/creating-actions/creating-a-docker-container-action

Hey, @jiayuasu sorry for so much delay had a busy month at work.

I have made all the changes you proposed, please can you have a look. I didn't make github action for zeppelin docker file as I think if zeppelin is not updated sooner or later it will be of no use, still I have kept a dockerfile for that.
For publishing to dockerhub, please create 2 secrets named "DOCKERHUB_USERNAME" and "DOCKERHUB_PASSWORD". For now I have kept my repository as a placeholder, please let me know the repository to which I need to publish so I can make that changes.

Hey, @jiayuasu just following up on this.

@kartikeyhadiya Thanks for the great work here. I will take a look your fork and try to run it myself.

Thank you, please let me know if anything else is required.

@kartikeyhadiya Due to the complexity of this task, I have taken over this and created another PR based on this PR: https://github.com/apache/sedona/pull/939 Thanks for your help!


api: do not assume presence of content-type header

Use headers.get('content-type') instead of headers['content-type'] since the content-type header may not exist. As one example, DELETE /v1/users/{id} returns 204 with no content and thus no content-type header.

Thanks for this fix @jaysoffian !


x/build: add OpenBSD 6.4 builder

Update OpenBSD to 6.4.
Would've helped with testing e.g. https://go-review.googlesource.com/c/sys/+/127762.

Historically we have only updated the OpenBSD builders every two releases, so that we reduce the effort to once every 12 months while keeping on a supported release. As such, I would have expected that we would go from 6.2 to 6.4, when it is released in November.
Is the plan to upgrade to 6.3 now, then 6.4 in November and then follow every release (once every six months) after that?

If we did that historically, I'm not sure it's ever been because of some plan. I think we've just fallen behind and that's what's ended up happening by accident. Ideally we'd have ever version as soon as possible. (This is independent of Go's general OpenBSD support policy; but knowing about breakages sooner will help us prepare.)

Fair enough - it has been more planned than accidental, as I would normally raise an issue and handle the upgrade work when the builder was about to drop into an unsupported release. Ideally we'd run both currently supported versions so that we detect breakage across either of those...

Sorry, I didn't mean to imply you didn't have a plan. I'm just saying I certainly didn't, or I wasn't aware of one.

I'd start sooner with a 6.4-beta in snapshots if possible. I'm seeing strange behavior on GCE, admittedly with Go 1.10.1 (patched for MAP_STACK).

I've done some preparatory work, and I'm fairly close to being able to do this. However, it seems that the 6.4 release is due quite soon based on what I'm hearing, and the previous releases:
 • 2018-04-02: BSD Release: OpenBSD 6.3
 • 2017-10-09: BSD Release: OpenBSD 6.2
 • 2017-04-11: BSD Release: OpenBSD 6.1
 • 2016-09-01: BSD Release: OpenBSD 6.0
 • 2016-03-29: BSD Release: OpenBSD 5.9
 • 2015-10-18: BSD Release: OpenBSD 5.8
 • 2015-04-30: BSD Release: OpenBSD 5.7
 • 2014-11-01: BSD Release: OpenBSD 5.6
 • 2014-05-01: BSD Release: OpenBSD 5.5
 • 2013-11-01: BSD Release: OpenBSD 5.4
 • 2013-05-01: BSD Release: OpenBSD 5.3
 • 2012-11-01: BSD Release: OpenBSD 5.2

We're a week away from October now. At this point, it seems worthwhile to wait a little more for 6.4 to come out and target that instead of 6.3. Let me know if there are strong reasons to either go with 6.3 or a beta snapshot of 6.4 sooner.
Otherwise, I plan to resolve this issue as soon as 6.4 final is released. If there is any additional information about the OpenBSD release schedule and when 6.4 final is expected to be released, please let me know.

I would do some practice runs with 6.4-beta currently in snapshots. I made a few minor tweaks to enable running with snapshots for syzkaller. If things don't seem entirely trivial, I'm happy to back-port the changes to make.bash.

Okay, I'll start with adding a 6.4 beta snapshot builder, and update it to final 6.4 once that's out. It seems that it'll be helpful at getting us more useful debug information sooner.

If things don't seem entirely trivial, I'm happy to back-port the changes to make.bash.

If it's fast for you to send a CL to add snapshot support to make.bash and you'd like to do it, that'd be helpful. Feel free to add me as a reviewer. Otherwise, I'll work on that, and make use of https://github.com/google/syzkaller/commit/b117b6ed3dc89b7e307dab907dafc0e7defd5756 as a reference if needed. Thanks!

I've started working on this in CL 139857.
@blackgnezdo Can you please take a look at my question https://go-review.googlesource.com/c/build/+/133115/8/env/openbsd-amd64/make.bash#52, knowing the motivation behind that change will help me make progress on this. Thanks!

CL 139857 has been merged and cmd/coordinator redeployed. There are openbsd-amd64-64 and openbsd-386-64 builders running now.
It's not the final OpenBSD 6.4 release, and they haven't been tested yet, so they should be considered experimental for a few days until they prove to be reliable. They're not enabled for trybots yet.

OpenBSD 6.4 final is out today: https://www.openbsd.org/64.html

I'll work on updating the images to 6.4 final.
The current 6.4 snapshots have been quite stable on https://build.golang.org/:

Once the final 6.4 images prove to be equally reliable, we can then make TryBots use them.

FWIW, oct 11 snapshot should be nearly identical to 6.4 release.

Will redeploy cmd/coordinator later tonight (when it's quieter).

Version golang/build@24469dd429f05bdb34b644430843761abf7e1367 of cmd/coordinator is deployed now.

The latest status is that I've redeployed cmd/coordinator last night with the fix for #28403. Will let the v2 image OpenBSD 6.4 builders run for a few days to get an idea of their reliability and speed, then we can proceed with switching OpenBSD trybots from 6.2 to 6.4.

The v2 image appears to be equally stable:

The performance has improved after resolving #28403. See https://go-review.googlesource.com/c/build/+/144777/4..5//COMMIT_MSG.

Deployed coordinator. Trybots will now use OpenBSD 6.4 rather than 6.2. E.g.:


Drop support for Windows 8.1 and WP 8.1 and use VS2017 platform toolkit

These are really old platforms. Microsoft stopped supporting WP8.1 already, user base on Windows 8.1 is very small and shrinking. I do not think that anyone will start a new project targeting Windows 8.1 or even WP 8.1. Windows 10 is the way to go for all new apps. Let's move on.
Having to maintain these platforms makes adding new features really difficult. Not only would we have to install VS2015 (a whooping 26GB install with all required packages) just to check that they build, but theoretically, we would also have to test new features on Windows 8.1 and even WP 8.1, which is just not feasible anymore.
So I propose to drop support for these platforms for future development. A support branch can be created, so those who still do care about these platforms (anyone there?) can still build it. Project files for Windows 10 version should be updated to use the VS2017 platform toolkit.
Please let me know what you think.

Disagree. For example, our products uses Windows 8.1/7.0 SDKs and these products compatible with Windows 7 SP1.

@lukasf @mcosmin222 @reego-fr I updated the BuildFFmpeg.bat script to work only with Visual Studio 2017. It also builds the libraries for ARM64. You can get the script from here.
You can also get the latest compiled libraries for UWP (FFmpeg 4.1 Release) from here.

@ionutdanila On my fork, there is also a VS2017 version of the build file. We are just updating the fork to correctly work with FFmpeg 4.1. There were some breaking changes. You might run into problems when using FFmpeg 4.1 with the MS version of the lib.

@lukasf I already updated the source code for FFmpegInterop to work with FFmpeg 4.1. I also added a sample application to see the NuGet Package in action.

@ionutdanila I invite you to check out my fork. It is a much improved version of the lib. Readme is now updated to show improvements, also FFmpeg 4.1 is integrated.


Add tests to demonstrate issue #523

added 2 failing tests for issue #523

Should fix lint issues first.  Closing pull request for now.


esp_netif_lwip: esp_netif_new: Failed to configure netif with config=0x3ffc8b00  (IDFGH-2269)

Environment

Development Kit:      [ESP32-Wrover-Kite]
Kit version (for WroverKit/PicoKit/DevKitC): [v1|v2|v3|v4]
Module or chip used:  [ESP32-WROOM-32D]
IDF version (run git describe --tags to find it):
// v3.2-dev-1148-g96cd3b75c
Build System:         [Make|CMake]
Compiler version (run xtensa-esp32-elf-gcc --version to find it):
(crosstool-NG crosstool-ng-1.22.0-80-g6c4433a) 5.2.0
Operating System:     [Linux]
Power Supply:         [external 5V Battery]

Problem Description
I am starting the ESP32 in AP mode with Station scanning.
Then i am selecting a Station SSID and entering its password
After which im rebooting the entire wifi stack as shown in the code.
Earlier it functioned. After the esp_netif_init() insertion im getting a reboot(its configured to reboot upon fail)
After changing the tcpip_Adapter_init() to esp_netif_init() i am getting the following behaviour
Expected Behavior
I (521303) connectingtostation: starting connect
I (521303) deinit: 1------------------------
I (523313) wifi: station:  leave, AID = 1, bss_flags is 134259, bss:0x3ffbaf18
I (523313) wifi: new:<1,0>, old:<1,1>, ap:<1,1>, sta:<0,0>, prof:1
I (523413) wifi: flush txq
I (523413) wifi: stop sw txq
I (523413) wifi: lmac stop hw txq
I (523413) deinit: 2------------------------
I (525413) deinit: 3------------------------
I (525413) wifi: Deinit lldesc rx mblock:10
I (527423) deinit: 4------------------------
I (529433) wifi: wifi driver task: 3ffc0030, prio:23, stack:3584, core=0
I (529433) system_api: Base MAC address is not set, read default base MAC address from BLK0 of EFUSE
I (529433) system_api: Base MAC address is not set, read default base MAC address from BLK0 of EFUSE
I (529463) wifi: wifi firmware version: a44d1c6
I (529463) wifi: config NVS flash: enabled
I (529463) wifi: config nano formating: disabled
I (529463) wifi: Init dynamic tx buffer num: 32
I (529463) wifi: Init data frame dynamic rx buffer num: 32
I (529473) wifi: Init management frame dynamic rx buffer num: 32
I (529483) wifi: Init management short buffer num: 32
I (529483) wifi: Init static rx buffer size: 1600
I (529483) wifi: Init static rx buffer num: 10
I (529493) wifi: Init dynamic rx buffer num: 32
I (529493) deinit: ssid is pemwireless
I (529503) deinit: password is pemwireless52072
I (529633) wifi: mode : sta ( ) + softAP ( )
I (529643) wifi: Total power save buffer number: 16
I (529643) deinit: wifi connected starting MQTT
I (529643) system_api: Base MAC address is not set, read default base MAC address from BLK0 of EFUSE
11. I (529653) MQTT: Other event id:7
W (529653) httpd_txrx: httpd_sock_err: error in send : 113
W (529663) httpd_txrx: httpd_sock_err: error in recv : 113
I (529763) wifi: ap channel adjust o:1,1 n:6,1
I (529763) wifi: new:<6,1>, old:<1,0>, ap:<6,1>, sta:<6,1>, prof:1
I (530343) wifi: state: init -> auth (b0)
I (530363) wifi: state: auth -> assoc (0)
I (530363) wifi: state: assoc -> run (10)
I (530383) wifi: connected with pemwireless, aid = 2, channel 6, 40U, bssid =  , security type6
I (530393) wifi: pm start, type: 1

I (530453) wifi: AP's beacon interval = 102400 us, DTIM period = 1
I (531243) esp_netif_handlers: sta ip: <IP_ADDRESS>, mask: <IP_ADDRESS>, gw: <IP_ADDRESS>
I (535833) wifi: new:<6,1>, old:<6,1>, ap:<6,1>, sta:<6,1>, prof:6
I (535833) wifi: station:   join, AID=1, bgn, 40U
I (535873) ESP Event Handler: station  join, AID=1
E (559663) MQTT_CLIENT: Error transport connect
10. I (559663) MQTT: MQTT_EVENT_ERROR
5. I (559663) MQTT: MQTT_EVENT_DISCONNECTED
11. I (574663) MQTT: Other event id:7
I (574673) MQTT_CLIENT: Sending MQTT CONNECT message, type: 1, id: 0000
I (574683) MQTT: MQTT_EVENT_CONNECTED
1. I (574683) MQTT: sent publish successful, msg_id=36647
2. I (574693) MQTT: sent subscribe successful, msg_id=28149
3. I (574693) MQTT: sent subscribe successful, msg_id=36941
4. I (574703) MQTT: sent unsubscribe successful, msg_id=62782
8. I (574703) MQTT: MQTT_EVENT_PUBLISHED, msg_id=36647
6. I (574713) MQTT: MQTT_EVENT_SUBSCRIBED, msg_id=28149
I (574713) MQTT: sent publish successful, msg_id=0
6. I (574723) MQTT: MQTT_EVENT_SUBSCRIBED, msg_id=36941
I (574723) MQTT: sent publish successful, msg_id=0
7. I (574733) MQTT: MQTT_EVENT_UNSUBSCRIBED, msg_id=62782
9. I (574743) MQTT: MQTT_EVENT_DATA
TOPIC=/topic/qos0
DATA=data
9. I (574743) MQTT: MQTT_EVENT_DATA
TOPIC=/topic/qos0
DATA=data
I (689173) wifi: new:<6,1>, old:<6,1>, ap:<6,1>, sta:<6,0>, prof:6
I (690193) wifi: new:<6,1>, old:<6,1>, ap:<6,1>, sta:<6,1>, prof:6
I (798233) wifi: new:<6,1>, old:<6,1>, ap:<6,1>, sta:<6,0>, prof:6
I (800173) wifi: new:<6,1>, old:<6,1>, ap:<6,1>, sta:<6,1>, prof:6

Actual Behavior
I (31963) connectingtostation: starting connect
I (31973) deinit: 1------------------------
I (33973) wifi: station:  leave, AID = 1, bss_flags is 134259, bss:0x3ffbabf0
I (33973) wifi: new:<1,0>, old:<1,1>, ap:<1,1>, sta:<0,0>, prof:1
I (34003) wifi: flush txq
I (34003) wifi: stop sw txq
I (34003) wifi: lmac stop hw txq
I (34003) deinit: 2------------------------
I (36003) deinit: 3------------------------
I (36003) wifi: Deinit lldesc rx mblock:10
I (38013) deinit: 4------------------------
E (40013) esp_netif_lwip: esp_netif_new: Failed to configure netif with config=0x3ffc8b00 (config or if_key is)
assertion "netif" failed: file "/home/pemubuntu/espressif/esp-idf/components/esp_wifi/src/wifi_default.c", linp
abort() was called at PC 0x400d6bf3 on core 0

ELF file SHA256: 740df468a3cab8b73a3c87029b0942602d3a3c1d229ce3e15f2b562ccc579035

Backtrace: 0x4008f8f5:0x3ffc8a90 0x4008fc75:0x3ffc8ab0 0x400d6bf3:0x3ffc8ad0 0x400f791d:0x3ffc8b00 0x400d429d:0

Rebooting...
ets Jun  8 2016 00:22:57

Steps to repropduce

step1
Start the ESP32 in AP mode
enter password
ESP32 reboots the wifi stacks and now connects to the selection accesspoint as well as starts it personal accesspoint
code fails.

###Code which works properly
https://gist.github.com/rebeliousconformist/b9f05de13691d8ffa9ef6cdd0023c45a

Code to reproduce this issue
https://gist.github.com/rebeliousconformist/7352d013cd7036fc7e44b06a2dc20d43

Hi @rebeliousconformist
Thanks for reporting this issue and sharing both versions of the code.
The problem in this case is creating the default AP multiple times. Both these methods to create default wifi interfaces: esp_netif_create_default_wifi_ap() and esp_netif_create_default_wifi_sta() return a pointer to the corresponding esp_netif object. This is not very clear from the examples, as the return value is effectively ignored since no deinit takes places.
To address the issue please store the pointer to the created network interface so that it could be destroyed later in the deinit phase:

esp_netif_t * my_ap = esp_netif_create_default_wifi_ap(); in https://gist.github.com/rebeliousconformist/7352d013cd7036fc7e44b06a2dc20d43#file-restartap2-c-L93
esp_netif_destroy(my_ap); somewhere in the deinit part

The other alternative would be to call both create_ap and create_sta only once at startup (this is inline with tcpip_adapter behaviour, but not preferred though)
I'm sorry this is not (yet) properly documented.

works ! thanks !


[dexter-vs] System.ArgumentException when clicking on Properties

System.ArgumentException occurs when doublic-clicking on Properties node in Solution explorer.
Below is the details of the exception.
  HResult=0x80070057
  메시지=The parameter is incorrect. . (예외가 발생한 HRESULT: 0x80070057 (E_INVALIDARG))
  소스=
  StackTrace:
   / EnvDTE._DTE.get_ActiveDocument()
   / Dexter.Common.Config.Providers.FileInfoProvider.Load() 파일 D:\dexter\github\vs2017\Dexter\project\dexter-vs\Dexter\Common\Core\Config\Providers\FileInfoProvider.cs:줄 34
   / Dexter.Common.Config.Providers.ConfigurationProvider.LoadProjectInfo() 파일 D:\dexter\github\vs2017\Dexter\project\dexter-vs\Dexter\Common\Core\Config\Providers\ConfigurationProvider.cs:줄 55
   / Dexter.UI.Analysis.DexterAnalysisCommand.Refresh() 파일 D:\dexter\github\vs2017\Dexter\project\dexter-vs\Dexter\Core\UI\Analysis\DexterAnalysisCommand.cs:줄 177
   / Dexter.UI.Analysis.DexterFileAnalysisCommand.OnDocumentWindowActivated(Window gotFocus, Window lostFocus) 파일 D:\dexter\github\vs2017\Dexter\project\dexter-vs\Dexter\Core\UI\Analysis\DexterFileAnalysisCommand.cs:줄 48
   / Microsoft.VisualStudio.Platform.WindowManagement.DTE.WindowEvents.InternalFireActivated(Window gotFocus, Window lostFocus)```

I will check this out.

It was resolved by #154.


Consider to update your CHANGELOG

Please consider to update your CHANGELOG even for commits/PR that are not yet published.
Following pseudo-standard https://keepachangelog.com/en/1.0.0/ and especially the Unreleased section.
That will allows to other project that use the graphp/graph master branch to upgrade it easily!
Main reason, is of course changes occured with :

https://github.com/graphp/graph/pull/193
https://github.com/graphp/graph/pull/195

Thanks in advance

The current master branch which will be released as v1.0.0 not too far in the future. As usual, we will make sure to update the CHANGELOG.md when preparing the release.
In the meantime, you can continue using the v0.9.x release tags or keep using commit references if you're sure you want to use the latest beta version.
Refs #191, #190 and others


Support Azure Database for PostgreSQL - Flexible Server

Support https://docs.microsoft.com/en-us/azure/postgresql/flexible-server/overview which supports stop/start features for cost saving measures.
Implementation depends on -https://github.com/terraform-providers/terraform-provider-azurerm/issues/8654

@manoatsas did you have a PR you're working for this one? If so can you create and associate with this issue. Thx.

@riragh can this one be closed or marked as a dup

Yes, this can be closed as duplicate. The flexible server work is tracked in this active PR: https://github.com/sassoftware/viya4-iac-azure/pull/261

Should this issue remain open until PR #261 merged to 'main' and available in a release version?

There were multiple PRs and tickets around this, so I have closed them to avoid confusion. But I can link this issue to the active PR it can get automatically closed.

This should be closed. It's a dup.


Convert redirect URLs to Wagtail pages, if possible

If you use Wagtail's import_redirects management command (docs) to bulk import redirects from a file, the redirects that are created will have full URLs as targets, rather than Wagtail pages. If the target pages represented by those URLs are moved, or their slugs change, the redirects will no longer work.
We should add another management command to convert target links to Wagtail pages, where matching pages can be found. Here's a possible approach, which lacks tests and docs.
# wagtail/contrib/redirects/management/commands/update_redirects.py
from urllib.parse import urlparse
from django.core.management.base import BaseCommand
from django.http import Http404

from wagtail.contrib.redirects.models import Redirect
from wagtail.core.sites import get_site_for_hostname

class DummyRequest(object):
    pass

class Command(BaseCommand):
    help = "Converts target URLs to Wagtail pages, if they exist"

    def handle(self, *args, **options):
        for redirect in Redirect.objects.exclude(redirect_link=""):
            url = urlparse(redirect.redirect_link)
            host = url.netloc
            port = url.port or 80
            path = url.path
            site = get_site_for_hostname(host, port)
            request = DummyRequest()
            path_components = [component for component in path.split("/") if component]
            try:
                page, _, _ = site.root_page.specific.route(request, path_components)
            except Http404:
                page = None
            if page:
                redirect.redirect_page = page
                redirect.redirect_link = ""
                redirect.save()
                self.stdout.write("Converted redirect %s" % redirect.id)
            else:
                self.stdout.write(
                    "Could not find a page matching the redirect_link for redirect %s"
                    % redirect.id
                )

Reviving this old issue a little, because I think it'd make redirect so much easier to work with. This could be something we add as part of the import process, but it'd make it take even longer - do we think that's a problem? import_redirects already exists to bypass any timeout issues if needed.


feat: enable S3 account-level public block

By the way, this probably should have been flagged as a BREAKING change with the current defaults of being enabled., as it overrides public access settings for existing buckets.


Wrong assignment of treatment capacities in allocated water source

Treatment capacities may not be assigned to correct utilities in allocated water sources.
Lines 415/416 in WaterSources.cpp have to be changed to allocated_treatment_fractions->at(u) to allocated_treatment_fractions->at(i), since it is defined in the current scope before the other allocation vectors are adjusted to utility IDs.

Fixed.


Experimental fix in travis script

close PR at once for on-branch testing

close PR at once for on-branch testing

for v0.1.0.
More fixation needed for v0.1.0 needed to make no error and successfully pushing to DockerHub.

for v0.1.0.
More fixation needed for v0.1.0 needed to make no error and successfully pushing to DockerHub.


Release cycle document

🐛 Bug
Current document describe Pull Request process as GitHub flow (master + feature branch).
But current PR template mention about release branch, and feature PR should be merged toward release branch.
There is document-template mismatch.
To Reproduce
"doc - Contributing" explain master-based feature branch (GitHub flow).

git checkout my-PR-branch
git rebase master

"PR template" explain as below.

We separated bug-fix PRs and feature PRs and they shall land in master and release/1.X-dev accordingly.

There is disparity between doc and PR template.
Expected behavior
Doc and PR template match its contents.
As contributor, I hope clear explanation of below information.

branch model (e.g. GitHub flow)
master-release relationship (e.g. daily master->release merge)
refactoring PR (which branch it should based on?)

Environment
master 4d9db866a11f3b4b9b923bca811911ac79dad914

I see your confusion and we shall clean it...

in past (fro 1.0.x releases we had model all in master and bug cherry-picking in separate release branch)
now (since 1.1.0) we have master only for bugfixes and all features/refactoring goes to the release branch which will be later merged bask to master

I see your confusion and we shall clean it...

in past (fro 1.0.x releases we had model all in master and bug cherry-picking in separate release branch)
now (since 1.1.0) we have master only for bugfixes and all features/refactoring goes to the release branch which will be later merged bask to master

Clear explanation, thanks!
In this branch model, once a release branch is created, the release branch cannot contain bugFix in master until actual release.
Is it right?

Clear explanation, thanks!
In this branch model, once a release branch is created, the release branch cannot contain bugFix in master until actual release.
Is it right?

In this branch model, once a release branch is created, the release branch cannot contain bugFix in master until actual release.
Is it right?

well not exactly and we are still in process of fine-tuning this process... apriori the feature branch atm release/1.2-dev is the target for all feature/refactoring-like PRs (and master is the target for baby bugfix-like PRs), but we do not want to get to fair from fixes (and also from perspective of future merging back to master and reducing then eventual collisions to a minimum) we are doing sync after every bugfix release as you can see #5253 #5383

In this branch model, once a release branch is created, the release branch cannot contain bugFix in master until actual release.
Is it right?

well not exactly and we are still in process of fine-tuning this process... apriori the feature branch atm release/1.2-dev is the target for all feature/refactoring-like PRs (and master is the target for baby bugfix-like PRs), but we do not want to get to fair from fixes (and also from perspective of future merging back to master and reducing then eventual collisions to a minimum) we are doing sync after every bugfix release as you can see #5253 #5383

Hey @tarepan,
Would you mind create a PR to update "doc - Contributing" with @jirka clarifications ?
Best,
T.C

Hey @tarepan,
Would you mind create a PR to update "doc - Contributing" with @jirka clarifications ?
Best,
T.C

Hi @tchaton,
I am a bewbie in PyTorch-Lightning contribution, so have no confidence about whole contribution workflow.
If can, core contributors will be best for creating the PR.
Sincerely,
Tarepan

Hi @tchaton,
I am a bewbie in PyTorch-Lightning contribution, so have no confidence about whole contribution workflow.
If can, core contributors will be best for creating the PR.
Sincerely,
Tarepan

Closing in favor of #6622


When a method is overridden, rank the supertypes' method higher

If you search for "flatMap" the first result is SystemProperties.flatMap, which is unlikely to be what you're trying to find. This method overrides TraversableLike.flatMap, which is much more likely to be the one you're searching for. However, it's not even on the first page. There's also no indication that the method is overridden.
PS. This is a great project, and I will certainly use this on a daily basis. Thank you for making it!

hhmmm. yep, that may be a solution.


GH-3406 affected GH-3439 by adding a queryroot to the parsed TupleExpr

GitHub issue resolved: #3439
Briefly describe the changes proposed in this PR:
#GH-3406 added a QueryRoot to everything parsed. This was not reflected in the test of #3440

PR Author Checklist (see the contributor guidelines for more details):

[x] my pull request is self-contained
[x] I've added tests for the changes I made
[x] I've applied code formatting (you can use mvn process-resources to format from the command line)
[x] I've squashed my commits where necessary
[x] every commit message starts with the issue number (GH-xxxx) followed by a meaningful description of the change

When I build this on Windows, I get this test failure:
org.junit.ComparisonFailure: expected:<QueryRoot[
   Projection
      ProjectionElemList
         ProjectionElem "s"
         ProjectionElem "p"
         ProjectionElem "o"
         ProjectionElem "x"
      Join
         StatementPattern (costEstimate=1, resultSizeEstimate=1)
            Var (name=_const_5c6ba46_uri, value=ex:s2, anonymous)
            Var (name=_const_af00e088_uri, value=ex:pred, anonymous)
            Var (name=_const_17c09_lit_e2eec718_0, value="bah", anonymous)
         Join
            StatementPattern (costEstimate=10, resultSizeEstimate=10)
               Var (name=_const_5c6ba45_uri, value=ex:s1, anonymous)
               Var (name=_const_af00e088_uri, value=ex:pred, anonymous)
               Var (name=v)
            LeftJoin (new scope) (costEstimate=1000, resultSizeEstimate=1000)
               StatementPattern (resultSizeEstimate=1000)
                  Var (name=s)
                  Var (name=p)
                  Var (name=o)
               BindingSetAssignment ([[x=ex:a], [x=ex:b], [x=ex:c], [x=ex:d], [x=ex:e], [x=ex:f], [x=ex:g]])]
> but was:<QueryRoot[
   Projection
      ProjectionElemList
         ProjectionElem "s"
         ProjectionElem "p"
         ProjectionElem "o"
         ProjectionElem "x"
      Join
         StatementPattern (costEstimate=1, resultSizeEstimate=1)
            Var (name=_const_5c6ba46_uri, value=ex:s2, anonymous)
            Var (name=_const_af00e088_uri, value=ex:pred, anonymous)
            Var (name=_const_17c09_lit_e2eec718_0, value="bah", anonymous)
         Join
            StatementPattern (costEstimate=10, resultSizeEstimate=10)
               Var (name=_const_5c6ba45_uri, value=ex:s1, anonymous)
               Var (name=_const_af00e088_uri, value=ex:pred, anonymous)
               Var (name=v)
            LeftJoin (new scope) (costEstimate=1000, resultSizeEstimate=1000)
               StatementPattern (resultSizeEstimate=1000)
                  Var (name=s)
                  Var (name=p)
                  Var (name=o)
]
>
at org.eclipse.rdf4j.query.algebra.evaluation.impl.QueryCostEstimatesTest.testBindingSetAssignmentOptimization(QueryCostEstimatesTest.java:34)
	at [...]

It still seems to be the issue I documented when digging into what wasn't working earlier (see #3473), i.e., the platform-dependent line endings. I'll make a PR to your PR that fixes it for me.


Bug: [DeepRequired] Type errors when using Array interface extension

Versions

package
version

typescript
5.0.3

ts-essentials
9.3.1

Repro Code
See TS playground, which includes DeepRequired from ts-essentials 9.3.1. Note the potentially naive fix suggested in the copied ts-essentials code, as well as the workaround at the bottom.
TypeScript Playground
here
Expected Result
It should be possible to use DeepRequired with objects containing properties whose value is of a type which extends Array<T>. In situations like this, the property should be required to be set, but the expected members of the array should not change.
Actual Result
In TS ~4, this works as expected. However, in TS5.0.3, there's a compilation error - it looks to be down to the fact that the DeepRequired type is modifying the members of the Array interface:
The types of '[Symbol.unscopables].length' are incompatible between these types.
    Type 'boolean | undefined' is not assignable to type 'boolean'.
      Type 'undefined' is not assignable to type 'boolean'.(2322)

The PR changes https://github.com/ts-essentials/ts-essentials/pull/367 have been merged and the will be included in major release that will be deployed by the end of April

It's released just now as a part of v10.0.0


Opening downloaded pictures is slow with bad connection

Hi there!
I ran into the following problem:
If I'm in the forest with a bad connection, opening pictures takes multiple seconds -- even though I have downloaded the pictures for that area. In this case switching on offline mode helps (it's also no problem with a really good connection, like at home).
It seems to me the app prefers loading pictures again (if there is any connection at all) instead of using the ones which are already downloaded.
Would it be possible to check for downloaded pictures first (if that's really the thing I'm observing here)?
Best wishes and thanks for making such an amazing app!

Good catch!
It's definitely something we can improve, we'll look into it. cc @wang-li
Thanks for your report 👍

Thank you for reporting this bug @karajan9!
This should be fixed in the current version (available on the Play store now)


[rust] upstreaming rust/cxx integration

TODO after this PR would be to reuse these parts of cxx support downstream. (will require small tweaks to init tokio),
but want to land this now to unblock.

blocked by https://github.com/capnproto/capnproto/pull/2169

This seems to break windows build 😢

Yeah, windows rust build is  a bit tricky for some reason. Will require some fiddling.

This seems to break windows build 😢

Yeah, windows rust build is a bit tricky for some reason. Will require some fiddling.

Two things stick out:
This happens when linking external/capnp-cpp/src/kj/kj_c9e87b54.dll – Bazel does not enable shared linkage by default on Windows and we have never enabled it, no idea why it is happening here.
The build is complaining about undefined symbol: __declspec(dllimport) inet_pton being missing. When we link Rust binaries within workerd, we have to add ntdll.lib on Windows to avoid missing symbol warnings. It appears that this might be needed here too (if we link statically, the __declspec(dllimport) part should not appear here).
Overall, rules_rust does not support Windows well unfortunately so I'd expect more such issues along the way (well, perhaps Windows is just not very suitable for software development in general).

inet_pton

inet_pton is from Ws2_32.lib not ntdll.lib

This happens when linking external/capnp-cpp/src/kj/kj_c9e87b54.dll – Bazel does not enable shared linkage by default on Windows and we have never enabled it, no idea why it is happening here.

maybe this is what rust_crate does on windows?

I'll be CI-debugging windows build by commenting things out, sorry for the noise.

Windows build issue is fixed by:

upgrading to rust 1.82.0 (linker issue)
switching to mainline cxx crate. I do not think it is possible to build workerd-cxx on windows using bazel, so I will try to publish to crates.io later. For now cxx will do to unlock everyone

PTAL @danlapid

Windows build issue is fixed by:

upgrading to rust 1.82.0 (linker issue)
switching to mainline cxx crate. I do not think it is possible to build workerd-cxx on windows using bazel, so I will try to publish to crates.io later. For now cxx will do to unlock everyone

PTAL @danlapid

Glad you figured it out!

👑

@hoodmane we can integrate ruff now! 🤩

Thanks @mikea !

Np. I'll also follow up with wd_rust_binary tomorrow (me and @anonrig need it too)


Add missing getUser method definition

Explain your changes
Adds missing getUser method definition. It was declared in context typing, however, was not accessible, which could be confusing for new comers and users coming from NextJS SDK where such method was present.
Checklist

[x] I have read the “Pull requests” section in the contributing guidelines.
[x] I agree to the terms within the code of conduct.

🛟 If you need help, consider asking for advice over in the Kinde community.

Summary by CodeRabbit

New Features

Introduced a new feature to retrieve user information more efficiently within the app.

Thanks for this!


CHANGE: ipfs storage provider

Switching from web3.storage to nft.storage

web3.storage api connection has changed so switching to nft.storage, which is simple and reliable plus FREE.


feat: add icon library component

closes #7
Link to icon library page:
https://carbondesignsystem-git-fork-vpicone-icon-lib.carbon-design-system.now.sh/guidelines/iconography/library

[x] mobile search bar
[x] search by descriptors
[x] filter by category
[x] group by category and subcategory
[x] card and category styles
[x] use definition tooltip?
[x] replace local metadata.json with dependancy once icon lib
(waiting for catgories from https://github.com/carbon-design-system/carbon/pull/3632)

@designertyler added mobile styles based on our conversation

@carbon-design-system/design made my best guess on mobile spec. Wondering if these inputs should go full width or if they should have a margin. I ended up with the margin, cards go full width per IDL implementation.
with margin

without margin

there is a large "Undefined" category/subcategory in all icons view, and as search results

search term "video"

and in the Menu:

@chrisconnors-ibm FYI the undefined stuff was brought up in Slack and are dependent on the Sketch PR that was just merged in.

The menu contents order should be alphabetical (Actions, Brand, Enterprise, Organization, Person, Planning, Tools) to match the page layout order.

It looks like, for example, all of Brand subcat Social is appearing as undefined.

real quick, i know this is left field... i just happened in here to check out the progress... but can we get rid of the rules when there's a hover ... I noticed it in the example in Connors's comment above so I went and looked.

@jeanservaas it looks like that issue is in the React component. I'll create a separate issue for it.
http://react.carbondesignsystem.com/?path=/story/dropdown--default

@designertyler yes, really weird, at first i didn't think it was in the React component, but the rule comes and goes when you move your cursor.
One other thing to note though, the right side of the dropshadow on the drop down is also cut off and this doesn't not appear to be a problem in the React component.

@chrisconnors-ibm alphabetized fixed
@jeanservaas shadow stuff fixed
@joshblack I believe the issue was due to importing * from @carbon/icons-react while having two versions of the module (10.4 from carbon-elements which is pinned and 10.5-alpha- so I could have the 32px version and latest categories.)
Using @latest for the icons packages in the latest commit solved the issue.

noice, shadow LGT little old me

Testers: refer to https://github.com/carbon-design-system/carbon/blob/master/packages/icons/metadata.yml
search should hit on: name, friendly name, aliases, category, subcategory values from  metadata.yml

@chrisconnors-ibm search now hits on name and category in addition to friendly name, aliases, and subcategory.

Subcategories should be shown in alphabetical order.
There are 16 broken icons like this. I'm guessing this will be "fixed upstream"?

Something is off with the clear X when there's a term entered in the search field. This is on hover.

The dropdown is limited to 3.5 rows. Can we fully extend it?

If there's a serch term that has results in another category but not the selected one, the "no results" state should link to "all icons" like the mockup here https://github.com/carbon-design-system/carbon-www/issues/7#issuecomment-516041842

@joshblack not sure if you saw my note above but re: bundles I’m pretty sure that was fixed yesterday, let me know if you still think that’s not the case.

I believe the issue was due to importing * from @carbon/icons-react while having two versions of the module (10.4 from carbon-elements which is pinned and 10.5-alpha- so I could have the 32px version and latest categories.)

@designertyler

yeah those are upstream

fixed the close button

updated dropdown item background and max height

added All icons link with result count when the category filter is preventing icons from being shown
For the "0 matches for X in Y" text, it looks really weird to have both the text input and the X text updating together as the user types. I think that sort of tagline is more for a request that hits a server as opposed to something that updates in real time. I think the big all icons link and missing result count gets the point across that the category is what's causing there to be no results.

@vpicone how'd you verify that it was resolved?

@joshblack sorry I thought you were talking about the duplicate icon bundle that was happening from using the canary with the regular icons package.
The icons get put in the app bundle because they're used on other pages/components so the resources are shared. The current carbon website makes two requests for the same data when you load the home page. Icons are also included in the regular gatsby theme app.js at the moment.

The icons get put in the app bundle because they're used on other pages/components so the resources are shared.

I would assume only a subset of icons are ultimately shared, right? Surprised that it doesn't bring those chunks in and defer the reset till later. (Although that sounds gnarly and I do not envy that challenge on the bundler side lol)
As a part of this effort it'd be great if we could address this as it can lead to a poor user experience. Is there a performance budget for the site we could measure against? When looking at webpack, it seems like they suggest asset chunks stay <250kB, would that be something we'd want to mirror?

@joshblack proper dynamic imports is a possibility with the icons module name/prefix. At the moment I have to import the library in its entirety, I imagine that could be a vector for performance improvements down the line once we have the build metadata.
I'm not sure why the icons got put into a separate chunk for the old website there's a lot of unknowns. However, it does load the icon chunk in its entirety on the home page load as well. Maybe it has something to do with the lack of a default export on the icons-react package?
If you want I can keep exploring trying to chunk the icons onto their own.

At the moment I have to import the library in its entirety, I imagine that could be a vector for performance improvements down the line once we have the build metadata.

Yeah, definitely understand that. Something we could do is publish build-info.json and use that to derive the direct paths as it has a flat list of icons and their module paths (so webpack could in theory chunk by file instead of one glob)
When it comes to your last line, I think we should definitely try and figure out why our bundle size effectively doubled (329kB on live site to 705kB on preview URL, 1.9MB uncompressed to 5.8MB uncompressed). Would you agree? Or is this unrelated to changes made in this PR?

After clicking the all icons link the category selection should change to all icons. Right now I click the link, it takes me to all icons, but the category doesn't update.

For the "0 matches for X in Y" text, it looks really weird to have both the text input and the X text updating together as the user types.

Fair enough. Was it intentional to leave these parts? It's not really valid if there are results in another category.

At narrow widths, the resource cards expand all the way into the right margin

Here's how the cards should behave with the margin.

@designertyler I thought it still made sense because if they're looking for an icon X in category Y and it doesn't exist then they'd still want to contribute.
It sort of depends on whether we assume they are accidentally narrowing their search (whoops, go back to all icons).
Or we assume they're being intentional with their search: "Oh, there's no Health icon in the Brand category, let me contribute one!"

The scenario of accidentally narrowing search is what we were solving for. It needs to be clear that the icon they searched for (health) does exist even if it's not in the category they expected (brand).
That's why we had the text for "0 matches found in the category you selected... but hey, we do if you expand the category to all." There's no need to distract with the concept of submitting an icon if we do have icons that match their search term.

Totally, I was thinking if they have an intentionally narrow search i.e. looking for a Watson Health brand logo. If it didn't exist, we'd want them to contribute it. I'll take a crack at the design as intended now.

@joshblack the bundle size doubled because of the icons, unfortunately the dynamic imports of just the size we need isn't possible because of the lack of metadata.
The carbon design system website benefits from not receiving 4 assets for every icon at the moment. It also splits the icons into a separate chunk, but that chunk is still loaded on the homepage. Even with these two factors, the overall content sent over the wire is comparable between this PR and the carbon design system website (which clocks in around 800kb atm).

@designertyler

added a 0 result found in Category string.
removed contribution resources when icons exist in all categories
fixed margin at tablet width
fixed category reset

Makes sense @vpicone! Thanks for following up on this, really appreciate it 🙏
Interacting with the page, was curious if there is supposed to be a tooltip on the icon names? Unfortunately it isn't triggering and it looked like the titles had a cursor style on them 🤔

@joshblack tool tip wasn't working in chrome for some reason, it's good now.

@laurenmrice should be fixed now thank you!

@laurenmrice after some digging it looks like IBM Firefox is no longer a thing: https://w3.ibm.com/help/#/article/mozilla_faqs
That version of firefox (60) is no longer receiving updates, so it'll continue to lag behind the current (68).

Can confirm it looks fine in Firefox 68.
Tooltip should only be enabled on truncated text.

@designertyler the tooltip is an all or nothing thing. Since we truncate the text with css, there’s no way for us to know if a given label is truncated or not at a given screen width. Sometimes it’s cut off between media queries.

@vpicone Understood. I'm discussing the possibility of changing the spec to wrap the text to two lines rather than truncate at one line. FYI @jeanservaas @shixiedesign @laurenmrice
There's also an issue with the tooltip being cropped with longer titles on the right side.

Truncated (as-is)

Wrapped text

Personally I think it looks totally fine with 2 lines for name. I definitely don't want to go to 3-lines though. Is it possible to put a character count limit on the names for current (and contribution) icons.

yep lets do two line wrap

current IDL has two lines in  one spot: "Checkbox undeterminate"
https://www.ibm.com/design/language/elements/icon-library
I think it will fine too as long as it’s not every icon!

I assume the tool tip is only for truncated names? Why else would it be there?

The newest build got rid of the tooltips and now wraps the icon name text if it runs out of room.

that is probably better solution since having unneeded tool tips is not great.

The search and category dropdown should be sticky

@mjabbink I'll add the sticky search/dropdown
Only adding tooltips to truncated names is tough here since we need to check every name when the page loads and again whenever the browser changes sizes. That sort of thing works on say table headers (5-10 items), but becomes a huge performance hit on the scale here (700+ icons)

@mjabbink are you okay with putting the sticky search in a new issue since we don't have a spec for that at the moment?

I don’t think we need the “Categories” label over the dropdown. I think it should be removed

@vpicone @mjabbink Are we fine moving the sticky search to another PR after specs are done?
This PR should be ready to be approved once the titles wrap (glad to see IDL doing it!) and the "categories" label is removed.

@vpicone @designertyler we are definitely good to put sticky search in another PR — it's not ready, we need a full spec for it

@designertyler Please consolidate sticky search controls and any necessary iteration of search controls into a separate issue and link it here.


Fix gtn.criterion submodule and some cleanup

Submodule gtn.criterion links correctly now
Rename files like _graph.cpp --> graph.cpp

LGTM, thanks for the fixes!


PCRE grain expressions only allow the regexp on the value side.

Fix PCRE grain query expressions so they are matching what we expect.
caasp-admin:~ # docker exec -it 06bf salt -P 'bootstrap_complete:.*' cmd.run hostname
admin:
    caasp-admin
6b5cb85d20f94f6eb813449b228cfe13:
    caasp-worker-1
4c0e4d31bc754369940ffcbae28e2f0a:
    caasp-worker-0
cb92123fa85d4170807e0aa24573501b:
    caasp-master-0
66d5844bc5f14d1480896b1bc234dd92:
    caasp-master-1
3f3f505c6eb3464e8a08cc0ae6fbc8f4:
    caasp-master-2
caasp-admin:~ # docker exec -it 06bf salt -P 'bootstrap_.*:true' cmd.run hostname
No minions matched the target. No command was sent, no jid was assigned.
ERROR: No return received

Issue spotted by @kiall.

Fixed.

Despite at this point we should add a method any_action_in_progress or something similar that concatenates these for us... only having to update one place would be nicer and this pattern will just grow.

It seems this is a known issue saltstack/salt#30936


Feature Request - Add option to disable warning

Is your feature request related to a problem?
After setting a custom ThemeSelect i get presented with the following in my log:
02:40:47 [WARN] [starlight-blog-plugin] It looks like you already have a `ThemeSelect` component override in your Starlight configuration.
02:40:47 [WARN] [starlight-blog-plugin] To use `starlight-blog`, remove the override for the `ThemeSelect` component.

Describe the solution you'd like
I would love a toggle in the config to disable these warnings
Describe alternatives you've considered
This does not cause any real issue, more of just a console annoyance.  for advanced use cases it would be nice to be able to disable the console warning when its intended that you are remapping the components for your setup.
Additional Context
No response

The next version of the plugin will have a slightly updated message and considering that this did not get any traction, I will close this issue for now until we have more feedback as I prefer to act on the side of caution.


fix(types): make sure ScriptableAndArray covers fns that return arrays

@kurkle the original implementation of ScriptableAndArray allowed these:

string
string[]
fn that returns string

but we also need to allow "fn that returns string[]"
This PR makes it possible now to have a function that returns a string[] in TS.

but we also need to allow "fn that returns string[]"

What is the use case for this? (other than borderDash)

but we also need to allow "fn that returns string[]"

What is the use case for this? (other than borderDash)

Here's an example I am currently using in my project:
DoughtnutBgColor.ts
export const doughtnutBgColor = (ctx, _1) => {
  const dataset = ctx.dataset
  const result = dataset.data.map((val, i) => {
    if (i === 0 && val < 60) return '#FF6A6A'
    if (i === 0 && val >= 60 && val < 80) return '#F1BB42'
    if (i === 0 && val >= 80) return '#76dec5'
    return '#f0f7ff'
  })
  return result
}

I want to be able to then use this in my doughnut charts backgroundColor like so:
 backgroundColor: doughtnutBgColor as any
But obviously not using as any
This use case is for coloring doughtnut charts based on a pass/fail percentage. The charts right now, look like this:

@kurkle sounds good to me! Thanks for clarifying! overlooked that index.


Improve type-safety of RLMResults subscript by making return type generic rather than id

@austinzheng

👍

Also need to update the swift 2.2 version of the tests as they now warn about pointless casts.

I thought Swift 2.2 didn't import Objective-C generics? I'll check it out and find out.

@tgoyne You're right, there are warning! But, not because the generics were imported into Swift 2.2. Changing the return type to the generic type imported it as RLMObject, the class constraint on the generic. 👍

This should really have had an entry in the changelog

@bdash Sorry, should I create a new PR to add an entry? I'm not entirely clear on what sort of changes require an entry. Is it anything that breaks the API (warnings or errors), introduces features, or fixes major bugs?

Any changes in API, new features, enhancements to existing features, or bug fixes should have changelog entries. The only things that typically don't get changelog entries are internal refactoring with no user-visible consequences. I'd also exclude Swift 3 specific changes for now since we don't officially support it, and we'll likely be announcing all of the changes in a single location when our support for it becomes official.
It'd be worth adding an entry still as we've not yet released this change.


Assignment 2 Grading

Hi team,
Can you please mail credentials for your jenkins server
Email<EMAIL_ADDRESS>

Hi Team,
Please provide credentials for Jenkins with admin access. I am not able to look at job configurations with the mentioned credentials in Jenkins. Also, mention the job names and their associated branches which need to be tested.

Hello Raghu,
Actually currently we are working on Docker Setup.
Hence the services are currently down.
Once are setup is complete we will let you know

@iarora93 That's fine. You can take your time. In the meanwhile, I wanted to look at your Jenkins job configurations so that I can grade. Can you send the credentials to<EMAIL_ADDRESS>. Also please let me know when you are services are up.

Actually the link for the same is -
https://github.com/airavata-courses/CookieArmy/wiki/Project-2-release-instructions

@iarora93 Please refer to my previous comments. I am not able to see the configurations when I login using the credentials mentioned in the WIKI. To be specific., there is no "Configure" option when I click on any particular job. I am assuming only users with admin access can view configurations.

I have just mailed you the credentials.

Hey guys,
I went through your Jenkins job configurations. Are you running scripts that are already present in your slave nodes for deployment?  Ideally service should be deployed on a different instance and not in the same instance where you are building and testing it. In your case  it seems that the service is being built and deployed on the same instance.
There are no tests present. Please add tests for each service.
In WIKI you haven't explained how you are using Consul for service discovery. Also, the section regarding the improvements from project 1 could have been elaborated.
Regards,
Raghottam

Hello Raghottam,
We have deployed our services on multiple hosts and using Jenkins we are building as well as deploying.
In some cases, we have added scripts so that we don't have to write too many commands in Jenkins.
Also, do you want us to update the Wiki Page now?

Hello Raghottam,
I have made changes in Jenkins for DB Services.
Could you please have a look if this is what you were talking about.
We initially had a different idea of our Jenkins architecture.
However, if you want us to update we can update remaining jobs as well


Added pact contracts building tests for mailchimp provider

Added contract tests with newsletter as consumer and mailchimp as provider to build pact contracts , pact tests mocks mailchimp provider calls to build consumer side expected contracts
Here is the trello card https://trello.com/c/6a49QHdb/25-newsletter-mailchimp-pact-contracts

Merging without trying out on my own machine. Per the Trello ticket, this should have been merged a long time ago. Impact of merge should be minimal since this is just one new file for a contract test in a separate folder.


Update alpine to 3.12.1

Updated alpine version to latest - 3.12.1 released yesterday.

Hi and thanks for the PR @jammasterj89, but alpine:3.12 and alpine:3.12.1 is the same image.
https://hub.docker.com/layers/alpine/library/alpine/3.12/images/sha256-d7342993700f8cd7aba8496c2d0e57be0666e80b4c441925fc6f9361fa81d10e
https://hub.docker.com/layers/alpine/library/alpine/3.12.1/images/sha256-d7342993700f8cd7aba8496c2d0e57be0666e80b4c441925fc6f9361fa81d10e

Oh, apologies @konstruktoid! Not very helpful ha.

No worries :)


fix operator controller build.

resolve: https://github.com/istio/istio/issues/20966
[ ] Configuration Infrastructure
[ ] Docs
[ X ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

I'm removing the operator/Makefile.core.mk in https://github.com/istio/istio/pull/21145

thanks @dgn
/close


Example

Hi @monika16p
Feel free to reopen if this was not accidentally created.

Hi @monika16p
Feel free to reopen if this was not accidentally created.


Remove NLCD11_12 in standardization of raster classes for LC.

Now that there is an issue/PR devoted to combining and/or renaming some of the land use categories across datasets, I wonder if omitting NLCD11_12 should be done within that step of the pipeline? I'm not very familiar with what that step will look like though, so I leave that up to you.
Originally posted by @lekoenig in https://github.com/USGS-R/drb-inland-salinity-ml/pull/38#discussion_r795717688

@msleckman I think this has been addressed in #81. Is that right? If so, you can link the PR to this issue.

Yes, this was resolved in #81 because the NLCD LC class reclassification table converted NLCD 12 class into NA.


AppDashboard incorrect credential escaping

Remove incorrect use of cgi.escape for passwords when creating new users or changing passwords via the dashboard. The email/password should only be escaped when the values are for use in a view, and in this case should also escape the double quote character (so < > & " are all escaped)
To reproduce the issue, create a user via the dashboard with the password p&ssword, and then login using the password p&ssword.  The quote character not being escaped can be tested by entering the value " style="background: lime in the email field (for example)
You can work around this issue by using the "appscale" command to create users.

There was missing output escaping on the login form email address. I've updated the pull request to perform escaping in the templates and removed use of cgi module. The build with the update is:
https://ocd.appscale.com:8080/job/Daily Build/5162/

Fixes appscale#1737


Quick question - Office 2016 & Visual Studio 2019

I've packaged apps that are in .exe format and are available as a stand-alone. Now I need to package Office 2016 that has a range of files with different extensions. MSIX Packaging Tool is asking to choose the installer I want to package. What should I actually package?
Similarly, I also want to package Visual Studio 2019 using MSIX Packaging tool.
Please assist.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 915f8c22-43ba-79bd-140a-09665fdc6dbb
Version Independent ID: 8148245b-80c1-7062-ace3-44c61c03eff7
Content: MSIX resources - MSIX
Content Source: msix-src/resources.md
Product: msix
GitHub Login: @dianmsft
Microsoft Alias: diahar

Hello, Windows and Office are working hard to enable M365 Apps (e.g. Word, PowerPoint, Excel) to be packaged and delivered in MSIX format with the same full extensibility that customer enjoy in C2R and MSI; we’ll communicate details and timelines as these become available. As a result we do not recommend repackaging Office at this time.
Also we do not recommend repackaging Visual Studio 2019 at this time.


Can't install 'composer require mpociot/laravel-apidoc-generator'

php version : 7.0
laravel : 5.4
Using version ^2.0 for mpociot/laravel-apidoc-generator
./composer.json has been updated
Loading composer repositories with package information
Updating dependencies (including require-dev)
Your requirements could not be resolved to an installable set of packages.
Problem 1
- Installation request for mpociot/laravel-apidoc-generator ^2.0 -> satisfiable by mpociot/laravel-apidoc-generator[2.0.0].
- mpociot/laravel-apidoc-generator 2.0.0 requires laravel/framework ~5.4 -> satisfiable by laravel/framework[5.4.x-dev, 5.5.x-dev, v5.4.0, v5.4.1, v5.4.10, v5.4.11, v5.4.12, v5.4.13, v5.4.14, v5.4.15, v5.4.2, v5.4.3, v5.4.4, v5.4.5, v5.4.6, v5.4.7, v5.4.8, v5.4.9] but these conflict with your requirements or minimum-stability.
Installation failed, reverting ./composer.json to its original content.

I have the same issue

Sup! I'm having the same issue.
There's a message: "Can only install one of: php-di/invoker[2.0.0, 1.3.3]".
When I downgrade php-di/invoker it works but it's not compatible with my app, otherwise it doesn't allow me to install it.
Any ideas? :)


ffmpeg does not build due to msys problems

This is with vcpkg git master on Windows 10 Creators Update x64:
latte C:\src\vcpkg > .\vcpkg.exe install ffmpeg --triplet x64-windows
The following packages will be built and installed:
ffmpeg:x64-windows
Building package ffmpeg:x64-windows...
-- CURRENT_INSTALLED_DIR=C:/src/vcpkg/installed/x64-windows
-- DOWNLOADS=C:/src/vcpkg/downloads
-- CURRENT_PACKAGES_DIR=C:/src/vcpkg/packages/ffmpeg_x64-windows
-- CURRENT_BUILDTREES_DIR=C:/src/vcpkg/buildtrees/ffmpeg
-- CURRENT_PORT_DIR=C:/src/vcpkg/ports/ffmpeg/.
-- Downloading http://ffmpeg.org/releases/ffmpeg-3.2.4.tar.bz2...
-- Downloading http://ffmpeg.org/releases/ffmpeg-3.2.4.tar.bz2... OK
-- Testing integrity of downloaded file...
-- Testing integrity of downloaded file... OK
-- Extracting source C:/src/vcpkg/downloads/ffmpeg-3.2.4.tar.bz2
-- Extracting done
-- Building ffmpeg for Release
13 [main] bash (13536) C:\src\vcpkg\downloads\tools\msys2\msys32\usr\bin\bash.exe: *** fatal error - cygheap base mismatch detected - 0x1365408/0x12F5408.
This problem is probably due to using incompatible versions of the cygwin DLL.
Search for cygwin1.dll using the Windows Start->Find/Search facility
and delete all but the most recent version.  The most recent version should
reside in x:\cygwin\bin, where 'x' is the drive on which you have
installed the cygwin distribution.  Rebooting is also suggested if you
are unable to find another cygwin DLL.
[...]
The first thing I noticed is msys i686 is downloaded even on x64. 32bit builds are more suspect to heap mismatches due to limited adress space. Also the version of msys2 downloaded is really old.

Also, MSYS2 project recommends to use 64-bit.
https://github.com/msys2/msys2/wiki/MSYS2-installation

Note: if you are using 64-bit Windows, there is no reason to use 32-bit MSYS2. Well, to be honest, there is one reason: you want to develop MSYS2 software (or contribute to MSYS2-packages) and want to test that the software/package also works on 32-bit MSYS2. When it comes to native software, 64-bit MSYS2 can be used to build, install and run both 32-bit and 64-bit variants. 64-bit MSYS2 software (practically speaking) never needs to be "re-based", giving a better user experience.


[StimulusBundle] Handles Windows directory separator when normalizing controller names

Q
A

Bug fix?
yes

New feature?
no

Issues
Fix #1422

License
MIT

This fixes the issue that controller name normalization doesn't work as intended in Windows which uses \ as the directory separator. In fact, without the fix, PHPUnit fails when running on Windows platform with the following error:
1) Symfony\UX\StimulusBundle\Tests\AssetMapper\ControllerMapGeneratorTest::testGetControllersMap
Failed asserting that two arrays are identical.
--- Expected
+++ Actual
@@ @@
     4 => 'hello-with-dashes'
     5 => 'hello-with-underscores'
     6 => 'other'
-    7 => 'subdir--deeper'
-    8 => 'subdir--deeper-with-dashes'
-    9 => 'subdir--deeper-with-underscores'
+    7 => 'subdir\deeper'
+    8 => 'subdir\deeper-with-dashes'
+    9 => 'subdir\deeper-with-underscores'
     10 => 'typescript'
 )

Thanks for this excellent PR @tamcy!


Write documentation for using the cache

E.g. how to use Shuffle tools and how to retrieve the data on the fly with $shuffle_cache

That would be great.
Is the cache using persistance storage ?
Now that we use Opensearch, this could be possible to create long persitant list in between workflow

That would be great.
Is the cache using persistance storage ?
Now that we use Opensearch, this could be possible to create long persistent list in between workflow

It's persistent storage. May just be a bad name for it - we could call it something simple like "Key-value store"
The main point of the docs are these:

You can get and set values directly with the Shuffle-Tools app
This data can either be org-wide or workflow-wide
You can retrieve data with $shuffle_cache.key directly as well (missing frontend button)


Eliminate dead code in RabbitMessageChannelBinder

The code in question is RabbitMessageChannelBinder.createConsumerEndpoint(..) (see below). Basically the bridge channel that is created in the first line is not used anywhere
@Override
	protected MessageProducer createConsumerEndpoint(ConsumerDestination consumerDestination, String group,
													ExtendedConsumerProperties<RabbitConsumerProperties> properties) {
		DirectChannel convertingBridgeChannel = new DirectChannel();
		convertingBridgeChannel.setBeanFactory(this.getBeanFactory());

		. . .

		convertingBridgeChannel.setBeanName(baseQueueName + ".bridge");
. . .

There is also an intermittently NPE-failing test due to the timing issue with Rest. The test in question is RabbitBinderCleanerTests.testCleanStream(..). Will fix it under this issue


When we map xs:int to java.lang.Integer(not primitive int) xjc does not generate correct annotations in the bean code.

When we map xs:int to java.lang.Integer(not primitive int) xjc does not generate
correct annotations in the bean code. We are doing such mapping to support
"forward" compatibility in our xjc generated beans. We are using a binding.xjb
file to perform the mapping using something like
"<jxb:javaType name="java.lang.Integer" xmlType="xs:int" />"
Here are the problems:

It does not generate @XmlSchemaType(name = "int") and so JAX-WS
auto-generated wsdls shows the wrong types(shows as String when it should be int).

Does not put the required = true or false in the @XmlElement so all int
mapped fields shows as required when actually it should be optional.

Since the Adapter classes names are generated and fixed(Adapter.class), if
there are two xjc generated jars in the classpath, it will have two sets of
Adapter classes( e.g. Adapter1.class, Adapter2.class.. etc.). But Adapter1.class
from first jar might perform mapping from xs:long to java.lang.Long and the
second jar's Adapter1.class(same name file as jar 1) might be performing mapping
from xs:int to java.lang.Integer.

When this happens depending which Adapter.class gets loaded first you runtime
will fail.
There are couple of easy solutions.
Sol 1) Make sure the number in the Adapter.class has a direct relation to the
things it maps i.e. say Adapter5.class always maps xs:int to java.lang.Integer.
Sol 2) Instead of generating class names as Adapter.class, generate more
logical names like XsIntToJavaLangInteger.class.
Note[1]: Since I had tight project deadline I wrote a plugin to fix the issues 1
and 2, works fine.
Note[2]: Did a workaround for issue 3 by changing the package name, not nice but
works, until someone fixes it.
Thanks,
Prantor
Environment
Operating System: All
Platform: All
Affected Versions
[2.1.9]

Regarding problem 2: The default value for the XmlElement required attribute is false, so the field is optional when this attribute is missing.


[8.x] Use alias to 'rowid' when using SQLite

See #35792
Using this syntax removes the unnecessary sqlite_sequence table created by sqlite to keep track of AUTOINCREMENT values.
This PR makes me wonder if it wouldn't be a better idea to change the way $table->…Increments() are compiled with sqlite instead.

I have changes to do on this one

I have changes to do on this one

Mark this as ready to review when you are done.

Mark this as ready to review when you are done.

@Max13 just feel free to send this in when you're done.

@Max13 just feel free to send this in when you're done.


Moving the is_auth_token functionality to the dl/Util.py package

There is a need to have a common functionality in place that can be use throughout the managers to test if a given string is a token. This has been done in isolated places, such us the storageClient with the is_auth_token function.
We want to move that logic to the dl/Util.py package.
The is_auth_token returns an array a break down of the token components: user, user id, group id, token string if the string passed in has the format of a token otherwise returns None.

This was done put in astro-datalab/datalab repo commits: 45a9156  71b60d1 and c42147


Added node function stub

Just adding a folder called nodeFunction.

We could rename the folder to lambda-selenium-node and then the other one could be lambda-selenium-java

Yeah, that sounds good. I'll update.


Connect on demand or Auto-reconnect

PS /root> Get-pssession |fl
ComputerType           : RemoteMachine
ComputerName           : 你猜
ContainerId            :
VMName                 :
VMId                   :
ConfigurationName      : DefaultShell
InstanceId             :c94d88fa-e5ee-411e-8232-839e09b69ae0
Id                     : 17
Name                   : Runspace16
Availability           : None
ApplicationPrivateData : {UnhandledBreakpointMode,DebugBreakpointCount,PSVersionTable, BreakAll…}
Runspace               :System.Management.Automation.RemoteRunspace
Transport              : SSH
State                  : Broken
IdleTimeout            : -1
OutputBufferingMode    :
DisconnectedOn         :
ExpiresOn              :

It's dead, and when I call it again, hopefully it can be reactivated
For example
PS > Copy-Item -Path "xxx" -Destination "xxx" -Recurse -Force -FromSession (Get-PSSession -id 17)

Invoke-Command -ScriptBlock {} -Session $s

When using Enter-PSSession
Results
[administrator@[0::0]]: PS > get-acl
Command 'get-acl' was not run as the session in which it was intended to run was either closed or broken
PS />

Expected
[administrator@[0::0]]: PS > get-acl
Connection disconnected,Trying to reconnect
Directory: C:\Users\Administrator
                                                                Path      Owner                  Access
----      -----                  ------                         Documents BUILTIN\Administrators NT AUTHORITY\SYSTEM Allow  Fu…
[administrator@[0::0]]: PS >

or
[administrator@[0::0]]: PS > get-acl
Connection disconnected,Whether to reconnect[y/n]? y
Directory: C:\Users\Administrator
                                                                Path      Owner                  Access
----      -----                  ------                         Documents BUILTIN\Administrators NT AUTHORITY\SYSTEM Allow  Fu…
[administrator@[0::0]]: PS >

I don't think it can reconnect if the server side has been cleaned up or if credentials are required they aren't stored in the pssession.  However, I can see how it would be more user friendly to try to establish a new connection but the user would need to understand that the remote state is probably gone.

In two cases

The credentials have been stored. It exists. We'll just call him again

$s=Get-Credential
New-PSSession * -Credential $s
enter-PSSession * -Credential $s
enter-PSSession * -UserName $s

or
New-PSSession * KeyFilePath *
enter-PSSession * KeyFilePath *

The credentials are not stored

New-PSSession * -Credential a
New-PSSession * -UserName r
enter-PSSession * -Credential a
enter-PSSession * -UserName r

When he reconnects again, we'll just enter the password.
[administrator@[0::0]]: PS > get-acl
Connection disconnected,Whether to reconnect[y/n]? y
password:
Directory: C:\Users\Administrator
Path      Owner                  Access
----      -----                  ------
Documents BUILTIN\Administrators NT AUTHORITY\SYSTEM Allow  Fu…
[administrator@[0::0]]: PS >


Mercury initial integrator options

mercury_main.for -- fix of the documentation to correspond to the actual code (and documentation elsewhere in Mercury):
main code integration is stopped if opt(1).eq.1
manual Should the integrator stop if a close encounter occurs (yes or no)? with the classical 1=yes, 0=no
amuse_helpers.f90 -- default integration options to match param.in

just to be sure: the only change affecting the interface is that it now should continue when a close encounter occurs? Have you tested this?

Indeed, the only effective change is the opt(1)=0 (instead of the original opt(1)=1). The rest should only affect the output format of Mercury.
I made some tests and it seems that the integration does not stop in either case. The only difference I can find is that in case opt(1)=1 (i.e. when the integration should stop), Mercury outputs info on the close encounters in the information file (outfile(3)); a message similar to:
WARNING:  Stopping integration due to an encounter between         4,      16
         at           0.114years

for (all?) occured close encounters. Btw, It seems that this corresponds to messages encounter minima occured from the redirection file. But the integration does not stop and the results for the particles that experienced close encounters do not seem to be affected either.
After looking into mercury6_2.for and amuse_helpers.f90, I'm confused. Could it be related to the comment on line 897 in amuse_helpers.f90?

about 4b221fb : I would be hesitant with such  part of code being turned off (especially in mercury), however since there is a comment about it it should be ok..nonetheless maybe its an idea to make it settable from the interface with a parameter and making this piece conditional on that?

also let me know when you think you have really diverged too much from what good behaviour for mercury is (or when it breaks something)..also I think its easier if we just commit what are improvements anyway (and do this quickly)??

I agree that 4b221fb is not ideal solution at all. I introduced it to get some tests running. I think it would be ideal to implement removing particles in Mercury and also make it possible to turn it off from the amuse interface. Also note that correctly, the same changes need to be introduced in the variable-timestep integrator routine mal_hvar ([here] (https://github.com/jilkoval/amuse/blob/mercury/src/amuse/community/mercury/src/amuse_helpers.f90#L1294)). Similarly, the removal of particles by Mercury in collisions should be fixed.
My Mercury branch is quite experimental at the moment, to make some tests running. Hopefully and ideally, I can solve things properly soon ;)

What's the status of this? Ready for merging?

its ready exept for one thing: the collision setting and the bit about the commented out code.
In principle the changes should disable the mercury internal collision detection both for orbiters (the OPT(2) setting and central body (commented out bit). This is necessary because otherwise the amuse state becomes inconsistent... ideally this should be tested.

just to be on the safe side, creating new PR


guild data

Eveything worked as expected other than the guild getting reset for my host player. Not sure if I did something wrong in the process or if this is a known issue. Would appreciate any help also not sure what I could include for context that would help.

The instructions have been updated to better explain how to avoid this issue so I think they will help you this! The co-op host's character has to leave the guild before migrating to the dedicated server and applying my fix.

@xNul I don't know if you plan to continue working on it but the guild data is a big issue for me. I'm trying to transfer from xbox to steam and I don't think the workaround works for that because even if I transfer membership those members wont exists when I goto the new server.

@towicode unfortunately if every player loses their save when migrating, there's no way for the guild to carry over. You just have to put everything in storage boxes, take all your pokemon out of the guild, disband the guild, apply the fix, and create another guild afterward. But, the only reason that bug happens in the first place is when moving a save from Windows to Linux. If you host the server on a Windows computer instead of Linux, the bug won't happen and you can carry over your guild.

I am trying to do it on Windows but it disbands me from the guild as well.

@xNul not sure what you mean.
I'm doing windows xbox co-op to steam dedicated.

@xNul not sure what you mean.
I'm doing windows xbox co-op to windows steam dedicated.

I am doing the same transition. It all works except the guild dilemma. You will need an extra person to join on steam co-op. So you need to have every1 on gamepass in the same guild, then all leave except you. Then transfer to steam co-op, and have a fresh steam user join you. The fresh user joins your guild, and assumes control/you leave it. Now make the switch to dedicated, and have that user give control back to you, which should theoretically fix you. Then you have to change the GUID's of all the other gamepass players to their steam GUID's, add them to the guild, and they should be fixed too.
That is my theory at least right now but I am struggling to get all my co-op players online currently to fully test this. I was able to fix just myself like this though with 1 new steam user.

@towicode I haven't done an xbox to windows dedicated server migration before so I'm not sure what the steps are. I'd go by what @mel0n said.

@carsong24 have you managed to get your save working? I think some of these comments would help you. If you've abandoned trying this, I'll close the issue.


Can't uninstall app from Samsung SM-A515W

I installed the app using the FDroid application, and now I can't remove it. Every time I choose to uninstall it hangs then times-out. I'm running the latest Samsung OS (Android 13). And ideas?

That's weird, but I don't think that it has something to do with my game.

It's the only app I've seen that does this. Very weird. I'm going to try to force uninstall using ADB. I'll let you know if that works.

You can try this, but it's very weird, because I thought uninstalling is so deep integrated in android that a app can't  change anything at that.

I was able to remove it with the ADB uninstall command. Issue closed.


Cannot login / use codespaces in Safari

VSCode Version: whatever is latest in codespaces now
OS Version: browser (Safari)

I honestly tried to use Microsoft support, but that seems to be for business customers only
Steps to Reproduce:

Go to online.visualstudio.com
Click "Sign in" button
Observe constant redirects
Observe "Login failed due to an unexpected error. Please log out and try again."

I am absolutely sure that my account is OK, I can login with Chrome and I know my password!
Also, I tried private tab, clearing cookies etc.
From googling I see that people generally can use codespaces from iPad and Mac Safari.
So I think there may be something wrong with my account.
Could you please help?

Does this issue occur when all extensions are disabled?: N/A

Hi @dbogatov, can you please reopen this issue in the Codespaces repo? https://github.com/MicrosoftDocs/vscodespaces Thank you!


Feature #319 : Webapp, Capture and Sights french translation

The mods texts on the landing screen are not translated

A suggestion for later:
We shall start using icons in the capture buttons instead of texts for better UI.


Added fourmolu, gersemi, beautysh formatter and fixed cppcheck linter

This pull request adds the fourmolu, gersemi, and beautysh formattrs to the repository. It also fixes the lintCommand of the cppcheck linter, since i could not get it to work . Moreover, i added rootMarkers for cppcheck and i changed the command into a more mainstream one.
I believe these changes will be useful, especially since the archiving of null-ls
Thank you for your time and effort and considering this pull request.

I reverted the cppcheck corrections, this PR just includes the additions

Can you omit the SUPPORTED_LIST.md changes? I have to fix the doc gen for it


Update .nvmrc

Fixes an issue with .nvmrc
nvm use &&
yarn

which results in
Found '/home/simon/.cache/repos/vscode/.nvmrc' with version <16.14>
Now using node v16.14.2 (npm v8.5.0)
yarn install v1.22.19
$ node build/npm/preinstall.js
16.14.2
*** Please use node.js versions >=16.17.x and <17.

error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.

Thanks for the PR! you must have built for Electron 22 which was reverted, the current nvmrc version should be fine for building https://github.com/microsoft/vscode/blob/7b81968088b1955d36bf004efe6f0e63559973ac/build/npm/preinstall.js#L13. We will bump it again when updating Electron.


'replace' expression not working in variable definition.

Hi,
I have a YAML build containing the following:
variables:
  EF_Test: $[contains('ABCDE', 'BCD')] #This works
  EF_Revision: $[replace('test','st','aa')] #This does not work

When I queue the build I receive this message:
An error occurred while loading the YAML build pipeline. Unrecognized value: 'replace'. Located at position 1 within expression: replace('test','st','aa'). For more help, refer to https://go.microsoft.com/fwlink/?linkid=842996
I am using Azure DevOps Server 2019 update 1.1.  According to this page I would have expected the replace expression to work.  Am I doing something incorrectly, or is the documentation somehow incorrect?
Thanks,
Neil

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 77c58a78-a567-e99a-9eb7-62dddd1b90b6
Version Independent ID: 680a79bc-11de-39fc-43e3-e07dc762db18
Content: Expressions - Azure Pipelines
Content Source: docs/pipelines/process/expressions.md
Product: devops
Technology: devops-cicd-process
GitHub Login: @juliakm
Microsoft Alias: jukullam

I am also experiencing this issue. Is there any updates on this?

Same here, replace function is not recognized within {{ }} as well. I just want to replace a string for a given parameter and expose it as a environment variable. Azure Devops 2019 is used.

@craglea I apologize for the delay in responding. For product bugs, you'll need to post in our Developer Community. This forum is just for documentation issues.


需要SM4支持

Is your feature request related to a problem? Please describe.

We see FIXME: PKCS #5 can not use SM4

Describe the solution you'd like

Provide SM4 go interface for gmssl, since it is already implemented in gmssl C++

@davidkhala  不好意思最近有点忙没来得及及看github，目前应该是已经有了SM4了呀，在test中有ECB和CBC的测试代码，是希望单独做成一个函数么？


Fix typo and consistency: /security/overview.md

Mainly provide a consistent look for the links, which are validated one by one and are effective currently.
content/en/docs/concepts/security/overview.md

Preview: https://deploy-preview-36562--kubernetes-io-main-staging.netlify.app/docs/concepts/security/overview/

/kind cleanup

Page preview:
https://deploy-preview-36562--kubernetes-io-main-staging.netlify.app/docs/concepts/security/overview/

Thanks @windsonsea .
/approve


Inactive customer accounts are able to request and perform password reset

Steps to reproduce the problem

Create a customer through the dashboard or the API
Set the account to IsActive = False (User account active = unchecked)
Using the storefront or the API request the password reset using customer's email
Customer email should get the reset link (tested with MailHog)
Now, the user can use the link to change the password but cannot login because the account is still set as inactive

What I expected to happen
…
One of the two options:

Inactive accounts cannot request a password reset at all
If they can request a reset, doing so should set their accounts as active automatically

System information
Operating system:
Saleor platform (docker), 2.10
Win 10

IMO we shouldn't send password reset links for inactive accounts. In the mutation that triggers sending password reset links, we should add validation for that. If the account is inactive, a validation error should be returned.

@maarcingebala Yes that is a behavior I would expect as well. I may be able to do a pull request for that in the next two weeks.


Billing Management

A user should be able to manage their own billing settings

[ ] Billing/Plan page 310a page 310b (PR: #309)
[ ] Billing/Payment Method page 311

Other billing screens (not part of this issue):

Billing/Overview page 309
Billing/Invoice History page 312

@samyount @chasballew Feel free to weigh in on these screens and their copy.
When upgrading, we probably want to throw up a confirmation modal clarifying they'll be charged the $499 immediately.

@sandersonet - The billing can happen immediately, but the stack creation and contract/BAA piece are still async. The contracts are formatted and ready to be triggered through the Echosign API, per #151.

Good point @chasballew .  Do you have thoughts on how we can word this in the confirmation modal?  Something to the effect of "Once you upgrade, an Aptible Account Manager will contact you with instructions for signing a BAA and using your new PHI-ready environment.  Your card will be charged immediately."  cc @bantic

SGTM

updated the modal:

Closing this as finished.  Opening separate tickets for Overview and Invoices screens.


[ALS-4752] Remove included packages in favor of using a lambda layer built on requirements file

Remove included python libraries.
Update to use newer python version.
Update to build lambda layer and build it with requirements.

Checklist:

[X] Have you successfully deployed to an AWS account with your changes?

Deployed to non-fisma Aim-Ahead Dev

Jira ticket #ALS-4752

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Reviewed in office hours, 09/25/2023.


[SPARK-42046][TESTS] Add connect-client-jvm to connect module and fix port failure

What changes were proposed in this pull request?
This PR aims to add connect-client-jvm module to connect module.
Why are the changes needed?
Currently, connect-client-jvm are not tested in CI because we only invoke the following for connect module.
https://github.com/apache/spark/blob/5e0a82e590d1c3c3c5fa7f347dddf450fabbf772/.github/workflows/build_and_test.yml#L155
And, it fails in GitHub Action environment.
[info] - Check URI: sc://localhost:123/, isCorrect: true *** FAILED *** (6 milliseconds)
[info]   java.io.IOException: Failed to bind to address <IP_ADDRESS>/<IP_ADDRESS>:123
...
Cause: java.net.SocketException: Permission denied
[info]   at sun.nio.ch.Net.bind0(Native Method)

Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass the CIs and check SparkConnectClientSuite from the log.
$ dev/run-tests.py -m connect
...
[info] SparkConnectClientSuite:
SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
SLF4J: Defaulting to no-operation (NOP) logger implementation
SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.
[info] - Placeholder test: Create SparkConnectClient (100 milliseconds)
[info] - Test connection (114 milliseconds)
[info] - Test connection string (6 milliseconds)
[info] - Check URI: sc://host, isCorrect: true (0 milliseconds)
[info] - Check URI: sc://localhost/, isCorrect: true (4 milliseconds)
[info] - Check URI: sc://localhost:123/, isCorrect: true (12 milliseconds)
[info] - Check URI: sc://localhost/;, isCorrect: true (4 milliseconds)
[info] - Check URI: sc://host:123, isCorrect: true (1 millisecond)
[info] - Check URI: sc://host:123/;user_id=a94, isCorrect: true (1 millisecond)
[info] - Check URI: scc://host:12, isCorrect: false (1 millisecond)
[info] - Check URI: http://host, isCorrect: false (0 milliseconds)
[info] - Check URI: sc:/host:1234/path, isCorrect: false (0 milliseconds)
[info] - Check URI: sc://host/path, isCorrect: false (1 millisecond)
[info] - Check URI: sc://host/;parm1;param2, isCorrect: false (0 milliseconds)
[info] - Check URI: sc://host:123;user_id=a94, isCorrect: false (0 milliseconds)
[info] - Check URI: sc:///user_id=123, isCorrect: false (0 milliseconds)
[info] - Check URI: sc://host:-4, isCorrect: false (0 milliseconds)
[info] - Check URI: sc://:123/, isCorrect: false (0 milliseconds)
[info] - Non user-id parameters throw unsupported errors (1 millisecond)
[info] Run completed in 1 second, 75 milliseconds.
[info] Total number of tests run: 19
[info] Suites: completed 1, aborted 0
[info] Tests: succeeded 19, failed 0, canceled 0, ignored 0, pending 0
[info] All tests passed.
[success] Total time: 1 s, completed Jan 12, 2023, 10:10:49 PM

cc @HyukjinKwon

Thank you, @HyukjinKwon !

Oh, one test seems to fail in GitHub Action environment.
[info] - Check URI: sc://localhost:123/, isCorrect: true *** FAILED *** (6 milliseconds)
[info]   java.io.IOException: Failed to bind to address <IP_ADDRESS>/<IP_ADDRESS>:123

cc @hvanhovell @grundprinzip too FYI.

Merged to master.

Thank you, @HyukjinKwon and @grundprinzip .