Visualization Tools on ROGER and Docker

@yanliu-chn
@craig-willis
Hi Yan, thanks for adding ncview to ROGER. Now that I can see the data quite a few new problems have come to light. If  it is doable could you please   add Panoply  to ROGER. Panoply is a java based NetCDF view.
See []https://www.giss.nasa.gov/tools/panoply/(url)
Thanks ...Henry

@hmb1
I've been trying to get Panopoly to work via Docker via NoVNC and don't yet have it working.  I'll let you know if I can get it working.

Will it work if installed on Roger using X similar to how Henry is using
ncview?
On Fri, Jul 14, 2017 at 1:20 PM Craig Willis<EMAIL_ADDRESS>wrote:

@hmb1 https://github.com/hmb1
I've been trying to get Panopoly to work via Docker via NoVNC and don't
yet have it working. I'll let you know if I can get it working.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/terraref/computing-pipeline/issues/340#issuecomment-315430943,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAcX51wXlYK2AKAZtrnEEdy41ED7LMmKks5sN7FZgaJpZM4OYC0p
.

@dlebauer
Yes, if the ROGER team is willing to install the Java JRE on the head node.

I just got back from a conference travel. Panoply 4.8.1 is installed. In initial test, I was able to launch it and view netcdf files.
To use, do the following:
ssh -Y<EMAIL_ADDRESS>module purge; module load java/1.8.0_131 panoply/4.8.1
export JAVA_OPTS="-Xms512m -Xmx2048m"
$PANOPLY_HOME/panoply.sh
Again, if you use mac, you need XQuartz; if you use windows, you need an X ssh client to launch panoply remotely.

Hi Yan,
This is the command line I am now using to launch Panoply.

java -Xms2g -Xmx2g -jar /sw/PanoplyJ-4.8.1/jars/Panoply.jar

Its  working but the GUI is very slow to respond to mouse-clicks. Also resizing windows  is a real no-no (as with ncview). If you wanna test with some real NetCDF data see  "/home/butowskh/tmp"
...Henry

I'm not sure how to speed this up. This is not memory size issue, it's more of the network delay. I will explore some fast X software to see if it helps.
Also, ROGER login node is usually busy. To get around that, you can do the following to allocate a computing node for panoply use:
in one terminal
ssh<EMAIL_ADDRESS>qsub -l walltime=12:00:00,nodes=1:ppn=20 -I # wait until you grab a node, say cg-cmpXX
open another terminal
ssh -Y<EMAIL_ADDRESS>ssh -Y cg-cmpXX
module load java/1.8.0_131 panoply
java -Xms512m -Xmx100g -jar /sw/PanoplyJ-4.8.1/jars/Panoply.jar # each node has 256GB memory

Hi Yan,
I gave it a crack. Its still pretty slow though
...Henry

@hmb1 @yanliu-chn
I've been exploring running Panopoly via Workbench using Xpra+OpenBox.  In short, this is a CentOS Docker container running Xpra (https://xpra.org/) with a lightweight desktop environment (OpenBox).
@hmb1 It's still very rough, but if you want to give it a try I've written up some instructions:
panopoly-xpra.pdf
A few notes about xpra:

Cut and paste don't work with the web/HTML5 client
There is an xpra Desktop client, but it doesn't currently work due to Workbench authentication.  There may be a way around this if we want to pursue this option.

I've found xpra to generally have better performance than exporting native X.

On Docker+Xpra+OpenBox, I've been playing with this a bit this morning and was able to open and plot one of the smaller hyperspectral files from /data/terraref/ua-mac/hyperspectral/Level_1 and it seems functional.  As with any remote desktop application, it's not perfect, and Xpra has a lot of features to explore.   I'm able to resize windows (with lag).  The main hassle for me is the absence of copy-paste -- and this may be a limit of the HTML5 client.

I want to explore FastX, which our univ has site license. But installing any service daemon on the login node of ROGER needs a process for evaluation for security, policy... I don't see that is happening soon.

@craig-willis
I followed the instructions in your pdf above and it finally opened an  empty "Open Box" Desktop  in a browser tab. NO sign of Panoply. Should I install xpra on my local Ubuntu machine ?
...Henry

@hmb1 Were you able to right click to start an xterm and run the panopoly.sh?

OKay - Craig  I have an xterm window open. I am not seeing panoply.sh any where in my PATH ?

Sorry, I was lazy and didn't put it in the path:
/PanoplyJ/panoply.sh
If this works out, we can talk about what I can do to make it easier to use.

Great its certainly now usable. Is there still a 4GB memory limit on files ?

The JSON spec I provided sets a 1G memory limit on the container. You can increase that by either editing the JSON and re-importing or editing the app in Workbench (Resource Limit > Max Memory
-- you'll need to stop/remove the app first).  By default, users on the Workbench system have an 8GB limit per account. The VM itself only has 32GB.
Of course, this can all be changed.  How much memory do you think you'll need?

OK 8 GB should be OK for now.
if I have a super -huge var I can always hyperslab it
if I wanna have NCO and Netcdf as well -- shall I just hack the JSON file ?
looking down the road a little.- if I add xpra to my local machine will I be able to use OpenBox on my desktop ?

I'll need to add any additional dependencies to the Docker image.  I can build on the existing NCO/NetCDF environment I put together a while back.

looking down the road a little.- if I add xpra to my local machine will I be able to use OpenBox on my desktop ?

If you mean connecting to Workbench via the Xpra client instead of browser, this is something I'm working on.  I just need to make sure the Xpra sessions authenticated.  Let me know if you meant something different.

Yep thats what i mean

OK, so I'll add the NCO/NetCDF dependencies and see if I can get things working with the Desktop client.
Is there anything else you can think of that could make this better for you?

OK is my ROGER home directory already mounted some-where  in Docker ?

No and I'm not sure that this will be possible.  I'll see what we can do.

@yanliu-chn or @jdmaloney
If we wanted to share user data between ROGER and Workbench, what would be the best approach?   What about some sort of scratch space under gpfs/largeblockFS/projects/arpae/terraref/?

There is a user directory I think
gpfs/largeblockFS/projects/arpae/terraref/users
On Wed, Jul 19, 2017 at 7:02 AM Craig Willis<EMAIL_ADDRESS>wrote:

@yanliu-chn https://github.com/yanliu-chn or @jdmaloney
https://github.com/jdmaloney
If we wanted to share user data between ROGER and Workbench, what would be
the best approach? What about some sort of scratch space under
gpfs/largeblockFS/projects/arpae/terraref/?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/terraref/computing-pipeline/issues/340#issuecomment-316363769,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAcX59-jgU_IAG6lfS0eUwkqkTL6QuXwks5sPfBBgaJpZM4OYC0p
.

@robkooper when will thredds be available?

@yanliu-chn
sorry to be tedious, but when I try and create an interactive node on ROGER it seems to take ages to start
Am using the command:   qsub -l walltime=24:00:00,nodes=1:ppn=20 -I
...Henry

@hmb1  Will answer here for @yanliu-chn depending on ROGER's job load it may take a while for interactive jobs to start.  They reserve a couple nodes for interactive work, but if those are already taken by other interactive jobs then your interactive job will have to sit and wait for a compute node to become available (any compute node in that case, interactive jobs aren't exclusive to those two nodes, but they put those two nodes in place to help speed up the interactive job start time).  Looking at the load on ROGER right now, it seems as though there are a lot of jobs running and in the queue.  State of the queue can be seen by running "qstat" (you may already have known that, but wanted to make sure you had the tool available to you).

Thanks Jd ,

@jterstriep and @craig-willis can talk a bit to mount a specified directory into the VM via NFS.

Update based on 7/20 meeting:

Mount ROGER /gpfs/largeblockFS/project/arpae/terraref/users to workbench (will need @jdmaloney to export RW to <IP_ADDRESS>)
This directory will be available to containers running in Workbench under /data/terraref/users
From this point forward, these and similar visualization tools can be added to the container in Workbench (I'm updating the current image to include the NCO dependencies and ncview).

Status update: still waiting on NFS export for users directory.

@craig-willis Exported added

Per https://github.com/terraref/computing-pipeline/issues/155 the hyperspectral data are now available via THREDDS so can be visualized using Panoply installed locally (file --> open remote catalog --> at https://terraref.ncsa.illinois.edu/thredds/catalog.html). My understanding is that this catalogis updated daily and only includes the data products, so will not be useful in its current state for checking output during development.

@hmb1
ROGER's /gpfs/largeblockFS/projects/arpae/terraref/users is now available as /data/terraref/users on Workbench.  I had to create a user directory via ROGER and open permissions (777), since we don't have consistent UID/GID in Workbench. I was able to copy a sample netcdf file to my users directory on ROGER and open that file via Panoply in Workbench.
Any running applications/containers will need to be restarted to get the new mount.

I've added a new "NetCDF Visualization" application to the main TERRA-REF Workbench catalog. This is the Xpra+OpenBox container with NCO/NetCDF dependencies, NCView, Panoply.  I need to add documentation on how to use these environments before closing.

Closing
Remaining task of adding to documentation is here: https://github.com/terraref/documentation/issues/158


installation instructions

the instructions say python install -r requirements.txt instead of pip...

Hi,
The following PR https://github.com/clirimemini/Keye/pull/5 should resolve the issue.
Regards.


Admin - Initial Setup Documentation & Configuration

Documentation needed regarding instructions for how to set all of the fields on the "event" object

Record type - Need create a standard Record Type for page layout
-- Single standard Master Record Type, update and clean up the Page Layout #34

Template -  for Site itself #36 (With standardization, documentation may be limited, but should be focused toward branded to align with School)

Event type - Define and determine values

Location type - Define and document.  What are standards that may be globally used.  What does this control?

Audience - Need setup instructions with documentation of what this control

Event sponsor - What is this?  Define and articulate process to input what "Event Sponsors"

Academic program list - Related Object #37 (Documentation focused on connecting existing object or fields within the object and or records that need to be created)

Setting up Schools to be seen on event registration page

Refer to #90 as a related task
Refer to #92 as a related task

Refer to #90 as a related task

Google Document - https://docs.google.com/document/d/1KsU8HtFZdy8sQWunmp3ztOYQTOa8KkoSpzHuYGUnDqE/edit?usp=sharing

#90 is a duplicate and they cover the same items.  Additional and future notes referenced on the Wiki article.


Update metadata.textproto

Update metadata.proto for the test to include newly added deviation in pull/1653

Pull Request Functional Test Report for #1724 / 51d3216854daed3325bca79d379439a33944ab71
No tests identified for validation.
Help

It looks like #1699 included this change already.


process.env does not expose its keys as expected

I'm not sure if this is expected, but it doesn't feel right.
If I run an app with
$ REACT_APP_FOO=bar npm start

I can access process.env.REACT_APP_FOO, but REACT_APP_FOO in process.env returns false, and process.env["REACT_APP_FOO"] is undefined.
I'm trying to have something like:
function getConfig(key) {
   if (key in process.env) {
     return process.env[key];
   }

   return defaults[key];
}

If it's not there it will be undefined, your could could just be
function getConfig(key) {
   return process.env[key] || defaults[key];
}

I think this might be possible to fix if we use
new DefinePlugin({
  'process.env': {
    NODE_ENV: ...,
    OTHER_VAR: ...,
    // ...
  }
})

form instead of
new DefinePlugin({
  'process.env.NODE_ENV': ...,
  'process.env.OTHER_VAR': ...,
  // ...
})

like we do now.
Would you like to give it a try and maybe submit a PR?
The relevant code is in packages/react-scripts/config/env.js.
The contributing instructions are here.

Hey @gaearon I can do this.

Please check the PR above. I hope it is what you explained

Fixed in #807.

This is amazing to find already merged!
I've been working on a solution for the env vars issue on the Heroku buildpack. The ability to enumerate process.env entries will directly contribute to that solution 😄🍻

This is going to be included in 0.7.0, which will be out soon.


Limit role name length

Closes https://onejira.imperva.com/browse/SD-1306

You need to make this change in DAM and DRA as well to maintain the consistency.

@eytannnaim right, I meant to do length of -role to make it obvious what I was doing, but used the wrong data.

@lindanasredin I thought I only am supposed to manage Sonar code currently. I don't have any way currently to test anything in DAM or DRA.

@jsonar-cpapke You are right basically, except for cases where we need to maintain consistency and it's a simple fix, not a big feature. Surely I don't expect you to test DAM and DRA. When you push the code the actions will test them. Sorry for being presumptuous in my previous message, this is the first time we face such a case and we need to talk about it. So if it's not too much trouble for you, can you please make the change for the other IAM roles? You can search "resource "aws_iam_role"" in the entire project. Actually now that I'm searching, I see there are more locations related to Sonar, the db-with-agent and the MSSQL.

Can we do that as a separate PR? This is currently preventing on of our QA from testing dsfkit.

It won't matter because we have to release a new version of eDSF Kit for QA to get the fix, and we can't do it with a broken consistency, and we don't release on Thursday and we need to check if we have enough content to make a release.


confusing for mem malloc

func (mp *MemPool) Malloc(size int) []byte {
	pbuf := mp.pool.Get().(*[]byte)
	if cap(*pbuf) < size {
		if cap(*pbuf)+holderSize >= size {
			*pbuf = (*pbuf)[:cap(*pbuf)]
			*pbuf = append(*pbuf, holderBuffer[:size-len(*pbuf)]...) // <--- allocation occur when exceed cap, why not just create a new buffer ?
		} else {
			mp.pool.Put(pbuf)
			newBuf := make([]byte, size)
			pbuf = &newBuf
		}
	}

	if mp.Debug {
		mp.saveAllocStack(*pbuf)
	}

	return (*pbuf)[:size]
}

Thank you for you feedback!

allocation occur when exceed cap, why not just create a new buffer ?

If we just create a new buffer, we should reput the old into the pool, then there will be more buffers in the pool. And lots of the small buffer will be hardly reused and cause more reput and create.
Most of the time, append should not trigger the realloc(buffer move and copy), even if trigger the realloc, the buffer should be returned to the runtime or system, we don't need worry about it.
try this test: https://github.com/lesismal/nbio/blob/master/mempool/mempool_test.go#L7.
And change the code to that just creates a new buffer every time when the cap is not enough, compare the differences with the current implementation.

望哥，内存池这里的实现还有疑问或者建议没？如果没有，咱关了呀 😄


Improved the styling of feature section

Related Issues

Styling of feature section.

Closes: #71

Resolved the username link issue getting stuck

Closes: #74
Describe the changes you've made
I have changed the styling by aligning the text and icon of the feature section for good visibility in the smaller and medium-size screens and also improved a small spelling error in the feedback.html file.
Changed the styling of the anchor tag of the username which was causing, links to stuck in hover state.
Checklist:

[x] My code follows the style guidelines of this project.
[x] I have performed a self-review of my own code.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] I have made corresponding changes to the documentation.
[x] My changes generate no new warnings.

Screenshots

Original
Updated

**

**
updated screenshot

Updated

2> original

Updated:

@khannakshat7 Please review this PR. Thanks

@khannakshat7 and @CodesbyUnnati Please review this PR.

For every page, it is fine, but on the dashboard page,  it still remains the same.

Ohh sorry, I forgot that dashboard doesn't extend from base.html
I have updated it.
Check it once @CodesbyUnnati .
Thanks


Unable to instantiate service com.firebase.jobdispatcher.GooglePlayReceiver

My application occasionally crashes with that exception:
Fatal Exception: java.lang.RuntimeException
Unable to instantiate service com.firebase.jobdispatcher.GooglePlayReceiver: java.lang.ClassNotFoundException: Didn't find class "com.firebase.jobdispatcher.GooglePlayReceiver" on path: DexPathList[[zip file "/data/app/my.package.name-1/base.apk"],nativeLibraryDirectories=[/data/app/my.package.name-1/lib/arm, /vendor/lib, /system/lib]]

Fatal Exception: java.lang.RuntimeException: Unable to instantiate service com.firebase.jobdispatcher.GooglePlayReceiver: java.lang.ClassNotFoundException: Didn't find class "com.firebase.jobdispatcher.GooglePlayReceiver" on path: DexPathList[[zip file "/data/app/ru.appspress.showcase-1/base.apk"],nativeLibraryDirectories=[/data/app/ru.appspress.showcase-1/lib/arm, /vendor/lib, /system/lib]]
at android.app.ActivityThread.handleCreateService(ActivityThread.java:3047)
at android.app.ActivityThread.-wrap4(ActivityThread.java)
at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1571)
at android.os.Handler.dispatchMessage(Handler.java:111)
at android.os.Looper.loop(Looper.java:207)
at android.app.ActivityThread.main(ActivityThread.java:5728)
at java.lang.reflect.Method.invoke(Method.java)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:789)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:679)
Caused by java.lang.ClassNotFoundException: Didn't find class "com.firebase.jobdispatcher.GooglePlayReceiver" on path: DexPathList[[zip file "/data/app/ru.appspress.showcase-1/base.apk"],nativeLibraryDirectories=[/data/app/ru.appspress.showcase-1/lib/arm, /vendor/lib, /system/lib]]
at dalvik.system.BaseDexClassLoader.findClass(BaseDexClassLoader.java:56)
at java.lang.ClassLoader.loadClass(ClassLoader.java:511)
at java.lang.ClassLoader.loadClass(ClassLoader.java:469)
at android.app.ActivityThread.handleCreateService(ActivityThread.java:3044)
at android.app.ActivityThread.-wrap4(ActivityThread.java)
at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1571)
at android.os.Handler.dispatchMessage(Handler.java:111)
at android.os.Looper.loop(Looper.java:207)
at android.app.ActivityThread.main(ActivityThread.java:5728)
at java.lang.reflect.Method.invoke(Method.java)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:789)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:679)

Note: I use proguard, also  "persistent" flag in Manifest.xml switched on.
I haven't found a solution yet.  Could you help me, please?

I found  a description of a  similar  problem  in other library android-job here.  As I understand, it means that it can be a problem with GCM dependency. But.. I have this dependency everywhere.
This exception have been starting after update one version to another. Both of them have JobDispatcher and GCM dependency like this:
compile 'com.google.android.gms:play-services-gcm:10.2.6' compile ("com.firebase:firebase-jobdispatcher-with-gcm-dep:0.6.0") {         exclude module: "play-services-gcm"     }
Exception is in the first version only. I mean that after updating the old version to new version exception was in the old version (as I understand, the old version сan hang because "persistent" flag switched on). But I don't understand how  I can solve the problem

Hi Gleb,
Please use new version of Firebase Job Dispatcher.
Your problem was solved by excluding PendingCallback from the SDK.
compile 'com.firebase:firebase-jobdispatcher:0.7.0'
Thanks,
Egor

Hi, Egor!
I have a question:
It's been a long time, and the problem was solved in most cases, but on some devices it's left:
Fatal Exception: java.lang.RuntimeException
Unable to instantiate service com.firebase.jobdispatcher.GooglePlayReceiver: java.lang.ClassNotFoundException: Didn't find class "com.firebase.jobdispatcher.GooglePlayReceiver" on path: DexPathList[[zip file "/system/priv-app/BQ_appspress_v7.2.6bq_Appspress-release/BQ_appspress_v7.2.6bq_Appspress-release.apk"],nativeLibraryDirectories=[/system/priv-app/BQ_appspress_v7.2.6bq_Appspress-release/lib/arm, /system/lib, /vendor/lib, /system/vendor/lib]]

Version 7.2.6 (I mean BQ_appspress_v7.2.6bq_Appspress) doesn't contains JobDispatcher library.
As I understand, It  can happen on specific devices after updating application (because persistent flag or something else).  After updating the old process left and it happens when the new process tries to find GooglePlayReceiver in the old. Is there a way  not show this error to user?

Hi Gleb,
I think you could try to load the class by Class.forName(className) before use of FJD and if it throws ClassNotFoundException avoid FJD.

Egor, thank you!
But I think that it's cannot solve the problem, because class not found in the old apk.  Is there a way not show this error to user -- something like tools:node="remove"  (I mean the example here), but not remove?

Hi Gleb,
Sorry I misunderstood the issue.
The class not found exception is caused by the system because of an inconsistency between the manifest service configuration and the process. So you can't check it.
When your install new version of the app where you first introduce FJD, I expect that no FJD jobs will be presented. So Goople Play Services can't try to start com.firebase.jobdispatcher.GooglePlayReceiver service.
I think your apk might be built incorrectly.
Could you check that your apk contains com.firebase.jobdispatcher.GooglePlayReceiver with apktool aapt?

Also please verify that it is located in the right path.
[[zip file "/data/app/my.package.name-1/base.apk"],nativeLibraryDirectories=[/data/app/my.package.name-1/lib/arm, /vendor/lib, /system/lib]]

I used "dexdump classes.dex | grep -A 10 -B 10 'GooglePlayReceiver'"
dexdump is in SDK

https://stackoverflow.com/questions/10569015/unable-to-instantiate-service-classnotfoundexception
might also help

Egor,  thanks so much!
As I think, my problem is not exactly in FJD, but I need your help for solve this :-)
Apk built correctly, dexdump is here .
And it can be located in system path, like /system/app/Appspress/  .
We can see how both --  the old and the new processes  -- work simultaneously in some cases after update application.  It's only in specific devices.  (Note: "Persistent" flag in Manifest.xml is switched on.  )   So, I am searching a way to use FJD in a compatible way with the apk that doesn't contains FJD and the receiver.
Maybe I should stop using com.firebase.jobdispatcher.GooglePlayReceiver ?  Is it a class for using GcmNetworkManager, can I switch off this and how can I do this?

In April 2019 we announced that Firebase Job Dispatcher would be deprecated today, April 7th 2020.  For this reason we are going to close all open issues and archive the repository.  We will also stop supporting FJD for new app installations (such as those targeting sdk versions greater than Android Q).  Existing apps that rely on FJD should continue to function as usual.
While we will no longer work on FJD, we encourage you to migrate to Work Manager which is a superior tool and fully supported by the Android team.
Thank you for taking the time to try the library and provide this feedback.  We sincerely appreciate your effort and we apologize for not addressing it in time.


Flaky executions of flutter_tools suite

Steps to Reproduce
Execute flutter_tools test suite.
../../bin/cache/dart-sdk/bin/pub run test -rexpanded

It's flaky. Works on some runs, but at times I see failures like the one below. Not consistent which test it trips over.
Possibly related to similar failure on travis: https://travis-ci.org/flutter/flutter/jobs/226989178 (Unfortunately, I restarted it, so the failure doesn't show anymore. Several tests failed, the first without a stack trace). Similar behavior has been haunting AppVeyor runs as of late.
Logs
00:06 +77: test/analyze_once_test.dart: analyze once flutter create
00:06 +78: test/analyze_once_test.dart: analyze once flutter create
00:06 +78 -1: test/analyze_once_test.dart: analyze once flutter create
00:06 +78 -1: test/adb_test.dart: adb getServerVersion
  SocketException: OS Error: Connection refused, errno = 61, address = <IP_ADDRESS>, port = 57230
  package:flutter_tools/src/android/adb.dart 76:27   Adb._sendAdbServerCommand
  package:flutter_tools/src/android/adb.dart 53:12   Adb.getServerVersion
  test/adb_test.dart 32:40                           main.<fn>.<fn>
  test/src/context.dart 97:32                        testUsingContext.<fn>.<fn>
  package:flutter_tools/src/base/context.dart 76:26  AppContext._run
  package:flutter_tools/src/base/context.dart 66:13  AppContext.runInZone.<fn>
  dart:async                                         runZoned
  package:flutter_tools/src/base/context.dart 65:12  AppContext.runInZone
  test/src/context.dart 86:32                        testUsingContext.<fn>
  ===== asynchronous gap ===========================
  dart:async                                         _Completer.completeError
  package:flutter_tools/src/android/adb.dart 91:3    Adb._sendAdbServerCommand
  ===== asynchronous gap ===========================
  dart:async                                         _asyncErrorWrapperHelper
  package:flutter_tools/src/android/adb.dart 75:62   Adb._sendAdbServerCommand
  package:flutter_tools/src/android/adb.dart 53:12   Adb.getServerVersion
  test/adb_test.dart 32:40                           main.<fn>.<fn>
  ===== asynchronous gap ===========================
  dart:async                                         Future.Future.microtask
  test/adb_test.dart 29:51                           main.<fn>.<fn>
  test/src/context.dart 97:32                        testUsingContext.<fn>.<fn>
  ===== asynchronous gap ===========================
  dart:async                                         Future.Future.microtask
  test/src/context.dart 86:51                        testUsingContext.<fn>.<fn>
  package:flutter_tools/src/base/context.dart 76:26  AppContext._run
  ===== asynchronous gap ===========================
  dart:async                                         Future.Future.microtask
  package:flutter_tools/src/base/context.dart 72:48  AppContext._run
  package:flutter_tools/src/base/context.dart 66:13  AppContext.runInZone.<fn>
  dart:async                                         runZoned
  package:flutter_tools/src/base/context.dart 65:12  AppContext.runInZone
  test/src/context.dart 86:32                        testUsingContext.<fn>
  ===== asynchronous gap ===========================
  dart:async                                         Future.Future.microtask
  test/src/context.dart 69:30                        testUsingContext.<fn>

00:08 +79 -1: test/create_test.dart: create project
00:09 +80 -1: test/create_test.dart: create project
00:09 +81 -1: test/create_test.dart: create project

Flutter Doctor
[✓] Flutter (on Mac OS X 10.12.4 16E195, channel master)
• Flutter at /Users/mravn/github/flutter
• Framework revision 8bf1a16502 (50 minutes ago), 2017-04-28 23:50:37 +0200
• Engine revision da8ebf40bd
• Tools Dart version 1.23.0-dev.11.11
[✓] Host Executable Compatibility
• Downloaded executables execute on host
[✓] Android toolchain - develop for Android devices (Android SDK 25.0.2)
• Android SDK at /Users/mravn/Library/Android/sdk
• Platform android-25, build-tools 25.0.2
• Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
• Java version: OpenJDK Runtime Environment (build 1.8.0_112-release-b06)
[✓] iOS toolchain - develop for iOS devices (Xcode 8.3.2)
• Xcode at /Applications/Xcode.app/Contents/Developer
• Xcode 8.3.2, Build version 8E2002
• ios-deploy 1.9.1
• CocoaPods version 1.2.1
[✓] Android Studio (version 2.3)
• Android Studio at /Applications/Android Studio.app/Contents
• Gradle version 3.2
• Java version: OpenJDK Runtime Environment (build 1.8.0_112-release-b06)
[✓] IntelliJ IDEA Community Edition (version 2016.3.4)
• Dart plugin version 163.13137
• Flutter plugin version 12.0
[✓] WebStorm (version 2017.1.1)
• Flutter plugin version 13.0
[✓] Connected devices
• None

That these tests are flaky is definitely an issue, but we're tracking flake problems separately now.


Make TextureSystem::create(shared=true) truly create a shared TS.

It had been creating a separate TS for every create call, but with a
shared ImageCache (if requested).  That's not good enough. If two spots
in an app each request a shared TS, They probably want it to actually be
the same one, including any attributes already set in it.

Updated with changes to avoid destruction order fiasco with respect to the ImageCache that's referred to by the TextureSystem. Now we leak a single TS, which is small anyway, and it only happens when the app exits. There is no consequence to this other than valgrind warnings about a leak that doesn't really matter.


allow changing defaults

without having to copy and paste your excellent lib

Do you mean you'd like the ability to change the options with javascript?

yes

Good suggestion, will implement. Thanks.

A concept could be much like what sweet alert uses... You can pass a configuration object with the call optionally, and this object if exists would override the libraries defaults. Undersore already has a defaults method for this kind of object merge.

Allow changing defaults, added setOptions method, and added a lot of "options.(...)"  :) https://github.com/natzar/notie.js/commit/3f9014b1b4cc11a82ad2a99332d0c40e1ac41e0f  Time to refactor is close ... anyway I like this "factory" approach.

+1


Simplify SpanData

Consider to be removed:

Has remote parent

Currently SpanData is written as a result of the default implementation for the Span (including notions like dropped events). Maybe we should simplify this and the SpanData defined in the API does not include dropped events, and in the SDK (default implementation) we use directly the protos which include the notion of dropped events.

Makes sense to me.

This is a good separation between a logical description of a trace, and information describing the state of the tracing system.
Concern:

If the tracing runtime is taking action to conserve resources, such as dropping events, do we need to convey this information to the exporter? Should we be doing this sort of resource management?

SpanData is used for data representation of API:

Exporter consumes SpanData
Users describing out-of-band spans

@tedsuo I think Exporter will not consume SpanData. SpanData is just for users to describe out-of-band spans.

@bogdandrutu ok, so this is a subset of the protobuf object, which only contains fields that the user can set (including timestamps in this case).


Codeunit::TextManagement should be changed to Codeunit::"Filter Tokens"

title

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 8e8ca63e-19c6-5ecc-e195-c65cd67f5931
Version Independent ID: 18a89028-7ce4-51f1-0d1a-b119dd2303de
Content: Adding custom filter tokens - Business Central
Content Source: dev-itpro/developer/devenv-adding-filter-tokens.md
Service: dynamics365-business-central
GitHub Login: @mikebcMSFT
Microsoft Alias: solsen

OnAfterMakeTextFilter should be changed also to OnResolveTextFilterToken

Thanks for the feedback! the article has been updated.


[MBEDTLS] Add option to use fewer AES tables

This reduces usage of ROM/RAM (depending on the setting of MBEDTLS_AES_ROM_TABLES) to 2KB instead of 8KB. When using fewer tables, a single T-Table is used, and extra lookups require shifts, which has shown to be negligible in practice.
This new syscfg, MBEDTLS_AES_FEWER_TABLES, together with MBEDTLS_AES_ROM_TABLES, both of which are orthogonal, give me the following numbers, running a swap upgrade on the FRDM-K64F board:
                     FEWER_TABLES
                 0                1
          +----------------+--------------+
          | size: 29984    | size: 29888  |
        0 | swap: 18s      | swap: 18s    |
          | flash: 13398   | flash: 13302 |
          | ram: 8752      | ram: 2608    |
          +----------------+--------------+ ROM_TABLES
          | size: 38156    | size: 32028  |
        1 | swap: 19s      | swap: 19s    |
          | flash: 21570   | flash: 15442 |
          | ram: 4         | ram: 4       |
          +----------------+--------------+

Where "size" denotes the size of the resulting bootloader, "swap" the time it takes to swap 2 400KB encrypted images, "flash" and "ram" are the mbedtls size as output by newt size.
PS: MBEDTLS_AES_FEWER_TABLES is not made default on this commit.

 It'd be interesting to do a lower-level benchmark just to get an idea of how much time effect this has on the underlying operation.

@d3zd3z We have an app that inlcudes benchmark: https://github.com/apache/mynewt-core/tree/master/apps/crypto_test; I can check how each MbedTLS configuration performs, and also apply the Tinycrypt patch and check that as well...


support load gdnlib ?

some time need to write gd native ,need to load gdnlib.

I think this module can be ported to Godot Engine 4.0 gdextension, but there's less benefit to porting to GDNative.


Rename print utility classes

Suggest renaming print utility classes as follows:
visible-print-block --> print-visible-block
visible-print-inline --> print-visible-inline
visible-print-inline-block --> print-visible-inline-block
hidden-print --> print-hidden
This would prevent them showing in intellisense with hidden-xs-up, etc.

As you can see in the Docs, your suggestions runs against the naming scheme.
By migrating to a newer Version all these classes need to be renamed.

@bpierson I tend to agree with Tom. Do you have a counterargument?

No, Tom's argument makes sense. I was thinking too narrowly in terms of grid visibility, but in the broader terms of media queries the current naming convention makes more sense. Thanks.


requests dependency

redfish lib requires requests

This one can bee seen in the generated requirements file: https://github.com/criteo/hwbench/blob/fb1286726d8fc53ff295b5e533191bf8999ceda1/requirements/base.txt#L490 ; did you use it during install?

didn't checked base.txt before writing the issue, sorry
what led me to write this issue is the following message I've got during setup.py install
error: The 'requests' distribution was not found and is required by redfish
So I've installed requests manually and setup.py install again so that it goes through...

Yes, usually the recommended way si to use "pip install ." and it will use the setup.py and its declared dependencies, but also do recursive dependency installs.

Alright, So I close this issue as it's already handled


macOS support follow-up work from #235

We added basic macOS support in #235.
Once it's merged, we need to do a few more things:

[ ] Add a test target, IGListKit-macOSTests and existing tests that apply
[ ] Update .travis.yml to build and run the macOS targets on travis-ci
[ ] Add an example project in Examples/Examples-macOS/
[ ] Create a macro for the following imports, so we don't have to copy-paste:

#import <TargetConditionals.h>

#if TARGET_OS_EMBEDDED || TARGET_OS_SIMULATOR
    #import <UIKit/UIKit.h>
#else
    #import <Cocoa/Cocoa.h>
#endif

[ ] The .podspec currently lists files manually which is cumbersome. Let's move common files to Source/Common/ so that spec.osx.source_files can become: 'Source/Common/*.{h,m,mm}'. We'll also need to do the same for Source/Internal/Common/.

Let me know if you need help with the example project.

Thanks @insidegui !
Because of how our syncing system works, we'll have to setup the basic project internally and push it. After that, we can have contributors help.

@insidegui, just FYI #333 😄
@Sherlouk 2 things up for grabs here:

The macro mentioned above. I had trouble getting this to work. My macro game is not strong. cc @rnystrom
mac example, #333 (probably coordinate with @insidegui)

@jessesquires Cheers for the heads up!
Actually I think if I were to rebase correctly some of the changes from my branch are still valid against the original checklist -- or is that something you're still working on internally? (Referring to Common directory/Podspec update)

@jessesquires I don't know if a macro would be the best solution for this case. When porting Keyframes to macOS I created a separate header called Compatibility and imported it everywhere instead of adding the #ifdefs to each file individually.
I can do the sample :)

@jessesquires Just spent 5 minutes updating the work from my PR yesterday, the main changes are in this Podspec
Moving away from specifying per framework (for macOS at least) and setting the common files between all the frameworks as such.
Again apologies if this is being held up internally, didn't get a response to my query yesterday and it wasn't too much effort so happy to lose the work!

@Sherlouk -- Sorry about that -- yeah, we're still dealing with this internally. We have other syncing tasks that need to happen when we change the file structure like this. We'll get this into master here soon!

Moved common files in ad30e53507ad3c75a098054f4de49a5cd10f562d

Closing. One more task at #364


feat: Remove delayed initialisation from DbCacheReadObject and DbCacheReadCollection

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

code cleanup

What is the current behavior? (You can also link to an open issue here)

The DbCacheReadObject and DbCacheReadCollection support being lazy initialised.
We only make use of this for a couple of collections, and supporting it makes it hard to understand whether an operation on the cache collection will yield the fiber or not.
Additionally, for the cases where we were lazy initialising, by knowing we might be doing so, we can optimise by running the loads in parallel. Currently we would be loading them one at a time, as the code was not aware they would need loading

What is the new behavior (if this is a feature change)?

The collections no longer support being lazy initialised. Instead they should be wrapped in the LazyInitialise wrapper. This makes the api slightly less clean to do the operations, as it requires an explicit await to get a reference to the collection, but this makes it explicit that it may be an async operation.

Other information:

Status

[ ] Code documentation for the relevant parts in the code have been added/updated by the PR author
[x] The functionality has been tested by the PR author
[ ] The functionality has been tested by NRK

Codecov Report

Merging #541 (2b78b2b) into release36 (89ee294) will increase coverage by 0.14%.
The diff coverage is 94.38%.

@@              Coverage Diff              @@
##           release36     #541      +/-   ##
=============================================
+ Coverage      68.00%   68.14%   +0.14%
=============================================
  Files            252      255       +3
  Lines          16982    17051      +69
  Branches        3821     3835      +14
=============================================
+ Hits           11548    11620      +72
+ Misses          5398     5395       -3
  Partials          36       36

Impacted Files
Coverage Δ

...ueprints/context/syncIngestUpdateToPartInstance.ts
12.94% <0.00%> (+0.29%)
:arrow_up:

meteor/server/api/ingest/expectedPackages.ts
61.11% <77.77%> (+0.60%)
:arrow_up:

meteor/server/lib/lazy.ts
82.60% <82.60%> (ø)

meteor/server/cache/CacheObject.ts
86.73% <92.59%> (+1.95%)
:arrow_up:

meteor/server/api/ingest/cache.ts
84.93% <100.00%> (+3.77%)
:arrow_up:

meteor/server/api/ingest/commit.ts
89.17% <100.00%> (ø)

meteor/server/api/ingest/expectedPlayoutItems.ts
80.55% <100.00%> (+0.55%)
:arrow_up:

meteor/server/api/ingest/generation.ts
87.07% <100.00%> (+0.08%)
:arrow_up:

meteor/server/api/ingest/ingestCache.ts
78.65% <100.00%> (ø)

meteor/server/api/peripheralDevice.ts
71.04% <100.00%> (-0.07%)
:arrow_down:

... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89ee294...2b78b2b. Read the comment docs.

As discussed with @nytamin I am merging this now and a proper review will be done next week


Manage UDP packets lost or incomplete

Hi,
How can we manage UDP packets lost or incomplete ?
For example a join message never get recieved ?
Thx :)

Sadly, there is no handling of packet loss for now. As for now GodotHub is sufficient enough as messaging/chat system. I'm however trying to upgrade it to be suitable for handling multiplayer gameplay, and the issue of UDP packets lost were usually handled by action prediction system implemented by the game itself, not by GodotHub.
For the example of  join message not received, I assume it was when a player entering a game lobby, yes that is an issue. Probably need to implement received message event or some sort. More overhead will be introduced for stability/integrity tho. But when the client had joined, the game play itself should not have issue with packet loss due to what I had previously explained.
In conclusion, we don't handle packet loss, but we do need to implement a fail-safe in case of join or connected were received or not.

Added Handshake when joining channel when the channel already had members.


feat(coil-extension): disabling by site/page/pp

Testing
This section is first, simply to allow easy editing.
Test 2: Disable site, open site in new tab
Load a monetized page, with localStorage.WM_DEBUG = true
Use UI to disable site:

Open a new tab and reload the monetized site
Check the browser action icon shows disabled:

Test 1: Disable, refresh, enable
Load a monetized site, with localStorage.WM_DEBUG = true
Use UI to disable site:

Check for a monetizationstop event logged:

Check the browser action icon shows disabled:

Refresh the page
Check that the stream does not start
Use UI to stop disabling the site
Check that the BrowserAction icon removes disabled badge:

Check that the stream starts
Disabling By Site/Page/Payment Pointer
The "This site is Web-Monetized" footer now shows disabled state, via toggling the $ to a prohibit icon.
(Note, these screenshots may be stale at this point, best to build and try it out)
Normal:

Cursor hovered over footer bar to preview click action (not shown: mouse cursor becomes a hand indicating a clickable):

Clicked with disabling menu showing:

It's a bit tricky with iframes, but the way it's currently implemented, if ANY of the disable toggles are checked (ORing), then all iframes in the tab will be disabled. The rules DO propagate to other tabs/frame but it's otherwise kept "simple".  For example if you block a.com by domain or url, then b.com (enabled) includes a.com as an iframe, then the a.com frame will be blocked.
After disabling the current url, with the BrowserAction badge using a 🚫 emoji text with a dark background color:

Perhaps we could add a "one time exemption" button ? On a related note, with the current way the ORing of independent disabling controls works, there's no way to block a domain but enable for certain urls (exemptions)
TODO

[ ] Write a testing plan document
[ ] See if "chrome.contextMenus" menus work with Samsung Internet, FF on Android
[x] Less "technical" sounding language ?

Domain -> Site, URL -> Page ?
[ ] Change "Payment Pointer" to recipient ?

[ ] tool tips ?
[ ] Persistence

chrome.storage.sync

works on FF and Chrome

Samsung? Safari ?

Other options:
We could use the contextMenus api:

Known Bugs
Bug 1
CoilDev 0.0.51
For some reason the TabStates isn't book keeping isn't in sync with the BackgroundFramesService, such that there are FrameState's in existence in the former, but not the latter. The SetDisabling command calls backgroundFramesService.getFrameNotNull(...) which throws if the frame doesn't exist.

This is hopefully fixed in CoilDev <IP_ADDRESS>
Bug 2
There seems to be a regression in the youtube integration, with monetization not stopping when moving to an un-monetized video from a monetized one.

Discussed with @fruehle

Maybe we can replace the “This site is Web-Monetized” with”“Web Monetization disabled”
Can use – instead of banned emoji:
The en dash () is slightly wider than the hyphen (-) but narrower than the em dash (—).

Some comments:

Could we change the color of the active toggle to red?
Change the copy next to the 🚫 emoji from "This site is Web-Monetized" to "Web Monetization disabled"


Update documentation link to latest Django stable release

The previous link was resulting in a 404.

Thanks @cabello !


Fix test update commands

Request criteria

[X] I searched the zppy GitHub Discussions to find a similar question and didn't find it.
[X] I searched the zppy documentation.
[X] This issue does not match the other templates (i.e., it is not a bug report, documentation request, feature request, or a question.)

Issue description
In https://github.com/E3SM-Project/zppy/blob/main/tests/integration/template_directions.md, the line rm -rf #expand user_www#forsyth/zppy_test_bundles_www/<UNIQUE ID>/v2.LR.historical_0201/image_check_failures erroneously includes "forsyth". That should be removed.

The same error appears for the complete-run test line.

Additional changes:
# Remove the image check failures, so they don't end up in the expected files.
rm -rf /lcrc/group/e3sm/public_html/diagnostic_output/ac.forsyth2/forsyth/zppy_test_complete_run_www/<UNIQUE ID>/v2.LR.historical_0201/image_check_failures

=>
# Remove the image check failures, so they don't end up in the expected files.
rm -rf image_check_failures


how can i use 2 or 3 webviews in one project with different cookies?

how can i use 2 or 3 webviews in one project with different cookies?

We can access and modify/clear cookies, and official docs reference is here: https://electronjs.org/docs/api/cookies
Other refs:

https://github.com/electron/electron/issues/2426

You can use different partitions on every webview tag partition="persist:github". Cookies are accessible everywhere in the project by partition name. When using another webview, ensure that partition attribute for another session is removed.
https://www.electronjs.org/docs/api/webview-tag#partition

hey there, so I can just use the same url(tag src) on a couple webviews ,and set different partition to set different cookies?
yeah, I get there, thk


installation: elasticsearch library unpinned

FIX Fixes current build by unpinning elasticsearch library
(closes #88).

FIX Removes calls to deprecated IndicesClient.get_aliases.
This enables the support for elasticsearch library 5.x. (see
https://github.com/elastic/elasticsearch/pull/13906)

Signed-off-by: Nicolas Harraudeau<EMAIL_ADDRESS>

@jirikuncar tests passing at last on both ES 2.2 and ES 5 :)

LGTM


Project write access

Ahoy!
I need write access to the repo as part of my data ethics/writing-the-docs-and-project-framework work; feel free (obviously) to check with Abie that this isn't a spearphish ;)

You should have write access now. Let me know if you have issues.


Output error

Hi there, I've tried running a few different scripts, but nothing ever appears on the Output screen (no error messages either). I've tried clicking the run with JS button, deselecting the Output option, and reselecting, etc. with no luck.
The output screen has never worked for me, only displaying "960px" next to the Output text at the top of the output section. I'd like to check if there's  something I'm missing in my preferences or it it's an actual bug. This works the same from Chrome to IE. Thank you for any feedback.

A few problems there:

You're logging to the console - the output is for HTML/DOM (so open the console instead of the output panel).
The string "jsbin.com" is not valid JavaScript.


Added settings folder to hold setting files as per the build environment

Using a single setting file for all environments (development,
testing, production) is inefficient since many variable and
parameters vary according to the current environement. For
example, you'd want to set the 'DEBUG' option to 'True' during
local development, but it must be set to 'False' in a production
environment. This hierarchy lets you do jus that. Addionall
instruction to configure your virtualenv to automatically source
respective settings will be provided in the wiki.
Resolves #25
Original author of commit: Nitin Paul<EMAIL_ADDRESS>

Current coverage is 0.00%

Merging #33 into master will not affect coverage as of 4d24546

No diff could be generated. No reports for #33 found.
Review entire Coverage Diff as of 4d24546

Powered by Codecov. Updated on successful CI builds.

This was just a test to see if the commits could be merged into one. Closing.


Request: Rival 5

Device identification:
Bus 001 Device 002: ID 1038:183c SteelSeries ApS SteelSeries Rival 5

Product URL:
https://steelseries.com/gaming-mice/rival-5
SSE3 Screenshots:
I can add this later today, but I don't have them just yet.
I can also do the reverse-engineering steps if needed.

Hello,
There is already an opened issue for the Rival 5 → #165, let's continue there :)

I can also do the reverse-engineering steps if needed.

It will be helpful: I do not own this device :D


New-SSHSession : The located assembly's manifest definition does not match the assembly reference

I installed the module and get this error when trying to create new ssh session.
I have EMC PowerShell Toolkit installed which also has Renci.Ssh.Net.dll of an older version. This could be the reason. How can I solve it?

to be honest no clue on a solution since we both use the same assembly and in my case I have added patches to mine to fix some bugs I have the skill to fix since the project became abandoned.


React Query v4

:tada: This PR is included in version 2.0.0-beta.1 :tada:
The release is available on:

npm package (@beta dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Update sentinelhealth.md

Have updated the product name from Azure Sentinel to Microsoft Sentinel

please review and approve

@rboucher
I think the proposed change updates an auto-gen file. Can you submit a fix for the source? Or can the change be merged in this PR?
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

Hi @BillClarksonAntill thanks for pointing this out.
This article is automatically produced using the logs API. We have asked the developers to make the required change in the manifest file.
#please-close


bugfix/2018.07.16_fix-closing-script-tag

Changes

fix index.ts __redoc_state rendering

add commented out HTML comments
should now handle </script> tags (see #563)

@ntrepid8 thanks for the investigation and for your efforts but this fix is a bit hacky 😄
I fixed it by escaping closing script tag: https://github.com/Rebilly/ReDoc/commit/76906eb126de728a25af0163e4d4ee71f88f6be4

Sweet, thanks for fixing it!


Keywords in common metadata

Related Issue(s): #1187
Proposed Changes:

Keywords fields in common metadata to have it available in Stac Item

PR Checklist:

[X] This PR is made against the dev branch (all proposed changes except releases should be against dev, not master).
[X] This PR has no breaking changes.
[X] I have added my changes to the CHANGELOG
or a CHANGELOG entry is not required.
[ ] This PR affects the STAC API spec,
and I have opened issue/PR #XXX to track the change.

isn't it included automatically with the common metadata inclusion?
https://github.com/radiantearth/stac-spec/blob/92161e4424ad59fbadb29e4d21c1efaa55a6216f/collection-spec/json-schema/collection.json#L11

Good point, I'll check...

@cholmes @matthewhanson Would someone be willing to review this?


jtsync: skip notification if card has no members

If the card has no members then there is no point adding and immediately removing a comment, since noone will notice.

I think, you can subscribe/watch cards without being member - did you consider this?

@bmwiedemann Yes I did, but in those cases I don't think the notification would be received by subscribers anyway, since their nick is not mentioned.  However ICBW so I'm marking this as do not merge until I or someone else checks this.

@felixsch Any chance you could check that?

@aspiers after one year being unmerged ... is this PR still valid/needed?

I had subscribed to a card without being member and regularly got its notifications
suseapiuserrw commented on the card cloud-mkcloud7-job-upgrade-nondisruptive-ha-without-nodes-upgrade-x86_64 on SUSE Cloud Jenkins Green

@itxaka @jiisuchomel: card status changed to successful

@bmwiedemann Yeah and I think that's the correct behaviour. I don't know why I ever thought otherwise. So this seems invalid -> closing.


PHP8: Uncaught ValueError: No stream arrays wered pased in StreamSelectLoop::

It seems this kind of error suppression causes fatal errors on PHP 8
Is there any way to circumvent such error to cause a fatal error?
Also see https://github.com/dpovshed/octopus/issues/45 for a way how to reproduce...
When removing the error suppression by changing
 $ret = @\stream_select($read, $write, $except, $timeout === null ? null : 0, $timeout);

to
 $ret = \stream_select($read, $write, $except, $timeout === null ? null : 0, $timeout);

The following error is generated:
Cannot cast a filtered stream on this system

When changing https://github.com/reactphp/event-loop/blob/8bd064ce23c26c4decf186c2a5a818c9a8209eb0/src/StreamSelectLoop.php#L271
to
if ($read && $write) {

it works, but at this moment I have no idea what other effects this might have... 😕

@holtkamp Thanks for reporting, I can see a possible problem and understand where you're coming from!

The following error is generated:
Cannot cast a filtered stream on this system

This is the actual problem you're seeing – plus the existing error handling isn't particularly helpful either.
Streams that have a filter attached MUST NOT be passed to stream_select(). For instance, here's the relevant part of my documentation for clue/stream-filter:

Note that once a filter has been added to stream, the stream can no longer be passed to stream_select() (and family).

Warning: stream_select(): cannot cast a filtered stream on this system in {file} on line {line}

This is due to limitations of PHP's stream filter support, as it can no longer reliably tell when the underlying stream resource is actually ready. As an alternative, consider calling stream_select() on the unfiltered stream and then pass the unfiltered data through the fun() function.

Unfortunately, there doesn't seem to be a way to check whether a stream resource has any filters attached. This means it's up to you to ensure that streams passed to the event loop are "valid".

Additionally, the existing error handling isn't particularly helpful.
If you pass a stream with a filter attached to stream_select(), PHP will automatically emit a warning message for each such stream. Additionally, it will filter out this stream from the list of streams it actually checks.
If you do not pass any streams to stream_select(), PHP < 8 will emit a warning message and abort the operation without invoking the underlying select() call. As of PHP 8, this will throw a ValueError instead. This is something we explicitly avoid in our code, because we may still want to check any pending timers even if no streams are being watched.
Both combined however means that we have no idea that PHP filters out these invalid streams and as such we could end up with an empty array of streams, thus running into the problem again.
On top of this, we do not report any errors generated by stream_select(). This is necessary because the function will also emit a warning message when the select() call is interrupted by a system signal. This is a perfectly valid situation, but unfortunately PHP doesn't appear to expose a reasonable way to know the error reason. The underlying select() call returns a respective errno, but I don't see how this would be exposed on the PHP level.
We may want to look into using error_get_last() to check the actual error message in the future. However, this only exposes the very last error message (and as discussed above, there may be multiple independent errors). As an alternative, we may also set up a temporary error handler, but this will likely incur some noticeable overhead, so I'm not sure this is something we want to have on our hot path.
Sorting this out definitely requires a non-trivial amount of work to check out, but I suppose we're happy to accept PRs. :shipit:
The gist to reproduce this: https://3v4l.org/b8gYu

This combined means you're dealing with an error that is indeed very hard to see. The good news is that this should be relatively easy to fix on your end by making sure you're not passing any streams with a filter attached as discussed above.
I've double checked this and don't see any way this would interfere with PHP 8 other than the above observation. The code base has full code coverage and is tested against PHP 8 and older versions, so I don't see anything that would be broken here at the moment.
This turned out to be long wall of text. I'm curious what others have to add, any input is welcome :+1:

@holtkamp Thanks for reporting, I can see a possible problem and understand where you're coming from!

The following error is generated:
Cannot cast a filtered stream on this system

This is the actual problem you're seeing – plus the existing error handling isn't particularly helpful either.
Streams that have a filter attached MUST NOT be passed to stream_select(). For instance, here's the relevant part of my documentation for clue/stream-filter:

Note that once a filter has been added to stream, the stream can no longer be passed to stream_select() (and family).

Warning: stream_select(): cannot cast a filtered stream on this system in {file} on line {line}

This is due to limitations of PHP's stream filter support, as it can no longer reliably tell when the underlying stream resource is actually ready. As an alternative, consider calling stream_select() on the unfiltered stream and then pass the unfiltered data through the fun() function.

Unfortunately, there doesn't seem to be a way to check whether a stream resource has any filters attached. This means it's up to you to ensure that streams passed to the event loop are "valid".

Additionally, the existing error handling isn't particularly helpful.
If you pass a stream with a filter attached to stream_select(), PHP will automatically emit a warning message for each such stream. Additionally, it will filter out this stream from the list of streams it actually checks.
If you do not pass any streams to stream_select(), PHP < 8 will emit a warning message and abort the operation without invoking the underlying select() call. As of PHP 8, this will throw a ValueError instead. This is something we explicitly avoid in our code, because we may still want to check any pending timers even if no streams are being watched.
Both combined however means that we have no idea that PHP filters out these invalid streams and as such we could end up with an empty array of streams, thus running into the problem again.
On top of this, we do not report any errors generated by stream_select(). This is necessary because the function will also emit a warning message when the select() call is interrupted by a system signal. This is a perfectly valid situation, but unfortunately PHP doesn't appear to expose a reasonable way to know the error reason. The underlying select() call returns a respective errno, but I don't see how this would be exposed on the PHP level.
We may want to look into using error_get_last() to check the actual error message in the future. However, this only exposes the very last error message (and as discussed above, there may be multiple independent errors). As an alternative, we may also set up a temporary error handler, but this will likely incur some noticeable overhead, so I'm not sure this is something we want to have on our hot path.
Sorting this out definitely requires a non-trivial amount of work to check out, but I suppose we're happy to accept PRs. :shipit:
The gist to reproduce this: https://3v4l.org/b8gYu

This combined means you're dealing with an error that is indeed very hard to see. The good news is that this should be relatively easy to fix on your end by making sure you're not passing any streams with a filter attached as discussed above.
I've double checked this and don't see any way this would interfere with PHP 8 other than the above observation. The code base has full code coverage and is tested against PHP 8 and older versions, so I don't see anything that would be broken here at the moment.
This turned out to be long wall of text. I'm curious what others have to add, any input is welcome :+1:

Thanks for the greatly appreciated wall of text!
By searching for Cannot cast a filtered stream on this system I did find that documentation yesterday.

The good news is that this should be relatively easy to fix on your end by making sure you're not passing any streams with a filter attached as discussed above.

As far as I am concerned the referenced project "octopus" itself does not use any filters. When searching in the vendor folder for any signs of stream filtering, I encountered this:
https://github.com/ringcentral/psr7/blob/360faaec4b563958b673fb52bbe94e37f14bc686/src/InflateStream.php#L24
However, I do not see any indication this InflateStream is actually used.
Local file versus remote file
Note that when loading a local file, the error does not occur.
Together with the observation that using if ($read && $write) { instead of if ($read || $write) { circumvents the problem. Some further debugging indicates that the array with write streams is empty just before the error is triggered.
So what would be the suggested approach to ensure that the array with $write streams is not empty, probably caused by a remote file that has not started downloading yet?
Off-topic
Is there particular reason a fork of https://github.com/guzzle/psr7/blob/master/src/InflateStream.php is used?

Thanks for the greatly appreciated wall of text!
By searching for Cannot cast a filtered stream on this system I did find that documentation yesterday.

The good news is that this should be relatively easy to fix on your end by making sure you're not passing any streams with a filter attached as discussed above.

As far as I am concerned the referenced project "octopus" itself does not use any filters. When searching in the vendor folder for any signs of stream filtering, I encountered this:
https://github.com/ringcentral/psr7/blob/360faaec4b563958b673fb52bbe94e37f14bc686/src/InflateStream.php#L24
However, I do not see any indication this InflateStream is actually used.
Local file versus remote file
Note that when loading a local file, the error does not occur.
Together with the observation that using if ($read && $write) { instead of if ($read || $write) { circumvents the problem. Some further debugging indicates that the array with write streams is empty just before the error is triggered.
So what would be the suggested approach to ensure that the array with $write streams is not empty, probably caused by a remote file that has not started downloading yet?
Off-topic
Is there particular reason a fork of https://github.com/guzzle/psr7/blob/master/src/InflateStream.php is used?

As far as I am concerned the referenced project "octopus" itself does not use any filters.

We're not aware of any such issues in any other projects, so I wonder what could be the cause. I'm not familiar with the octopus code base, but perhaps you can provide a simple gist to reproduce this? :+1:

Local file versus remote file
Note that when loading a local file, the error does not occur.

Can you be more specific what "local file" means here? A simple gist would help :+1:

Together with the observation that using if ($read && $write) { instead of if ($read || $write) { circumvents the problem. Some further debugging indicates that the array with write streams is empty just before the error is triggered.

Unfortunately, this will break existing logic and test cases. The code is correct as-is. If you change this to &&, it means you're no longer watching readable streams when no writable streams exist (and vice versa).

Off-topic
Is there particular reason a fork of https://github.com/guzzle/psr7/blob/master/src/InflateStream.php is used?

See https://github.com/reactphp/http/issues/331

As far as I am concerned the referenced project "octopus" itself does not use any filters.

We're not aware of any such issues in any other projects, so I wonder what could be the cause. I'm not familiar with the octopus code base, but perhaps you can provide a simple gist to reproduce this? :+1:

Local file versus remote file
Note that when loading a local file, the error does not occur.

Can you be more specific what "local file" means here? A simple gist would help :+1:

Together with the observation that using if ($read && $write) { instead of if ($read || $write) { circumvents the problem. Some further debugging indicates that the array with write streams is empty just before the error is triggered.

Unfortunately, this will break existing logic and test cases. The code is correct as-is. If you change this to &&, it means you're no longer watching readable streams when no writable streams exist (and vice versa).

Off-topic
Is there particular reason a fork of https://github.com/guzzle/psr7/blob/master/src/InflateStream.php is used?

See https://github.com/reactphp/http/issues/331

You can have a look at the issue I mentioned https://github.com/dpovshed/octopus/issues/45 for an example on how to reproduce, this also indicates what I mean with "local" file 😉

You can have a look at the issue I mentioned https://github.com/dpovshed/octopus/issues/45 for an example on how to reproduce, this also indicates what I mean with "local" file 😉

@clue See https://github.com/amphp/amp/commit/73f6e71b34dfaf1811e85854638c9cafb617589c for a possible implementation for avoiding the suppression. Feel free to copy with attribution.

@clue See https://github.com/amphp/amp/commit/73f6e71b34dfaf1811e85854638c9cafb617589c for a possible implementation for avoiding the suppression. Feel free to copy with attribution.

Big thanks for https://github.com/reactphp/event-loop/issues/220#issuecomment-763612400
Indeed the initial step of the process of the example is blocking. This problem was "suppressed" when used on PHP < 8 and now surfaced.

Big thanks for https://github.com/reactphp/event-loop/issues/220#issuecomment-763612400
Indeed the initial step of the process of the example is blocking. This problem was "suppressed" when used on PHP < 8 and now surfaced.

@holtkamp Glad to hear this has been tracked down successfully!
For future reference, here's the relevant section from the PHP documentation for "Backward Incompatible Changes" in PHP 8:

The HTTP stream wrapper as used by functions like file_get_contents() now advertises HTTP/1.1 rather than HTTP/1.0 by default. This does not change the behavior of the client, but may cause servers to respond differently. To retain the old behavior, set the 'protocol_version' stream context option, e.g.
<?php
$ctx = stream_context_create(['http' => ['protocol_version' => '1.0']]);
echo file_get_contents('http://example.org', false, $ctx);
?>

– https://www.php.net/manual/en/migration80.incompatible.php#migration80.incompatible.standard


Globe icon "no internet"... except there is

I've got another one for you, @vocatus :
I'm getting the globe icon where my lan icon should be. Mouseover message says "Network, No internet access", except there is internet access. I'm getting this on both of my computers, one with a fresh install of Windows 10, and the other is an older install that just started doing it.
Both started doing it after running Tron 10.8.6
The reason I think it might be related to Tron is that stuff from the Microsoft store won't work.  Also, when trying to browse the Microsoft Store, it constantly comes up with a "Can't connect to the internet" message.
I think it may be related to a Microsoft telemetry thing that gets disabled during Tron.
I know I'm usually no help when it comes to providing more information, but if you tell me what you need and how to get it, I'll be happy to try.

small update: I got it to go away on the fresh install computer by uninstalling the driver from device manager, then letting it reinstall. But on the other computer, it seems to have no effect. I still tend to think it has something to do with something in the Windows telemetry being blocked.

Hmmm. I thought I'd fixed this many versions ago. It is related to one of the telemetry servers that gets blocked. It can't connect to the server Microsoft set up to respond to that checker so it thinks you're not online even though you are. I'm not sure which specific server is the one that affects the connectivity check.


[CoroutineAccessors] Default implementations are transparent.

Like every other method entry in the default witness table, the default implementations of the read2 and modify2 accessors that just call read and modify respectively should be transparent.

@swift-ci please test

@swift-ci please test source compatibility

@swift-ci please apple silicon benchmark

Why do these need to be emitted even if we're skipping function bodies otherwise?

@swift-ci please test source compatibility

@swift-ci please test

@swift-ci please test source compatibility

@swift-ci please apple silicon benchmark


how to fetch specific count of RLMObject

[Message objectsWhere:@"count=30"];

i want to fetch 30 message objects from the realm database . how to achieved it ?

When you retrieve objects, they are lazily loaded on access. So you can just get all messages by [Message allObjects] and iterate only over the first 30 objects.


More games

I think it would make sense to expand this to be not just a tetris clone, but a collection of classic text-based games. I could add at least minesweeper. Solitaire probably doesn't work very well as multiplayer, but other card games might.

Adding card games or minesweeper to the same game doesn't feel like a good idea. But more tetris-like game modes would be nice...

Awesome idea from a workmate: Ring mode but blocks move in opposite direction. They spawn from middle, and move towards edges of the game, perhaps to a random direction.

Another idea: opposite mode.

Similar to ring mode with 2 players, but there is nothing in the middle and you still fill up rows instead of rings as in traditional game.
Needs two players, so some kind of waiting screen when there is only one.
If more than two people join, split them as evenly as possible on two sides. With an odd number of players (currently 3 or 5, because MAX_CLIENTS_PER_LOBBY = 6), put n on one side and n+1 on the other.

I'll make separate issues from these...

#290  and #291


[Feature] Improving of the Mode-toggler

Description
The mode-toggler can have images on the slider, differentiating between light mode and dark mode. It will make it look more pretty.
Screenshots
Light Mode:

Dark Mode:

Checklist

[X] I have checked the existing issues.
[X] I follow Contributing Guidelines of this project.
[X] I am a GSSoC'24 contributor.
[X] I want to work on this issue.

Code of Conduct

[X] I agree to follow this project's "Code of Conduct".

@CSEdgeOff @Durgesh-Vaigandla please assign this issue to me.


Add tests utility classes

Codecov Report

Merging #124 into master will increase coverage by 0.27%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #124      +/-   ##
============================================
+ Coverage     48.94%   49.22%   +0.27%
- Complexity      612      618       +6
============================================
  Files           106      106
  Lines          2517     2517
  Branches        286      286
============================================
+ Hits           1232     1239       +7
+ Misses         1120     1115       -5
+ Partials        165      163       -2

Impacted Files
Coverage Δ
Complexity Δ

src/main/java/chopchop/commons/util/Pair.java
88.88% <0.00%> (+38.88%)
12.00% <0.00%> (+6.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d871fc...1a35f0b. Read the comment docs.


Propose IORING_SETUP_SQE128 and IORING_SETUP_CQE32

Hello,
I'm trying to iouring-go for the NVMe command passthru, but current version cannot support that because of SQE and CQE entry size.
To send the NVMe command through io_uring, SQE and CQE size should be extended with flag IORING_SETUP_SQE128 (128byte SQE entry) and IORING_SETUP_CQE32 (32Byte CQE entry). The other case, NVMe driver reject all command through io_uring.
kernel nvme driver:
https://elixir.bootlin.com/linux/latest/source/drivers/nvme/host/ioctl.c#L734
So, I propose the SQE128/CQE32 features for the passthru command.
Go 1.15 compatible:
https://github.com/sungup/iouring-go/tree/support_SQE128_CQE32
Go > 1.18 implementation using Generic type:
https://github.com/sungup/iouring-go/tree/support_SQE128_CQE32_generic
(This version is modified from Go 1.15 compatible codes to reduce the duplicated logics managing SQE ring buffer.)
For the SQE128/CQE32, I have abstract the SubmissionQueueEnrty and CompletionQueueEntry, so too many lines has been changed related with SQEntry and CQEntry type.

@Iceber Can I submit a PR this feature to this repository? Many lines had been changed to abstract SubmissionQueueEntry and CompletionQueueEvent.

@sungup Very welcome, this is an open source project, and more people participating will make the project better


[EventHubs] Add push mode samples to timed samples section

To be completed after issue: #16617
Summary
Many EH samples run forever because of push mode. Currently, we choose to ignore these samples when testing in the live test pipeline. This is done by listing the samples in the IGNORED_SAMPLES of scripts/devops_tasks/test_run_samples.py. We want to allow these samples to exit() after a time limit.
Scope of work
Add the following push-mode samples to the TIMED_SAMPLES section in scripts/devops_tasks/test_run_samples.py. Since this issue should be completed after #16617 , the TIMED_SAMPLES section should already be in place.
Success Criteria

Add EH push-mode samples to the TIMED_SAMPLES section.
Remove these samples from the IGNORED_SAMPLES section

all push-mode samples:
SYNC
        "authenticate_with_sas_token.py",
        "connection_to_custom_endpoint_address.py",
        "proxy.py",
        "receive_batch_with_checkpoint.py",
        "recv.py",
        "recv_track_last_enqueued_event_prop.py",
        "recv_with_checkpoint_by_event_count.py",
        "recv_with_checkpoint_by_time_interval.py",
        "recv_with_checkpoint_store.py",
        "recv_with_custom_starting_position.py",
        "sample_code_eventhub.py",
        # checkpointstoreblob samples
        "receive_events_using_checkpoint_store.py",
        "receive_events_using_checkpoint_store_storage_api_version.py"

ASYNC
        "authenticate_with_sas_token_async.py",
        "connection_to_custom_endpoint_address_async.py",
        "iot_hub_connection_string_receive_async.py",
        "proxy_async.py",
        "receive_batch_with_checkpoint_async.py",
        "recv_async.py",
        "recv_track_last_enqueued_event_prop_async.py",
        "recv_with_checkpoint_by_event_count_async.py",
        "recv_with_checkpoint_by_time_interval_async.py",
        "recv_with_checkpoint_store_async.py",
        "recv_with_custom_starting_position_async.py",
        "sample_code_eventhub_async.py".
        # checkpointstoreblobaio samples
        "receive_events_using_checkpoint_store_async.py",
        "receive_events_using_checkpoint_store_storage_api_version_async.py"

as per @yunhaoling 's comments in #17139, update : "auto_lock_renew(_async), those two don't receive forever"


Added new scraping jobs for KSH and KCM metrics

Issue #, if available:
Description of changes:
Added new jobs to scrape kube-scheduler and kube-controller-manager metrics from EKS. This will be released on 11/18.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Fixed the make run-test errors, and tested the changes with blueprint-construct-dev blueprint. I was able to visualize the AMP metrics via AMG as shown below.

/do-e2e-tests


Status and stability of master ?

What is the status of this package ? Is it functional ? May I use it in  a project to transmit data (not web related) ? I see that master CI build is currently in error on linux.
Are there plans to keep master a production ready branch and use a develop branch  for commits that may break releases ?

We are most certainly alive and actively working on quic-go :) Master is as production ready as it gets for us – which means there might still be breaking API changes from time to time as QUIC evolves. The implementation itself should be stable, with the caveat of the known issues in the bugtracker.
We have a quite extensive test suite and some hard-to-hunt-down bugs that are causing travis to be flaky, but I wouldn't worry about that too much.
Does that answer your questions?

Yes, thank you very much. I'm considering using QUIC for a Go program that will send FITS images from telescopes over long distances. I'm currently using tcp, but it is not convenient to adapt for long distances because of the need for users to adjust the buffer capacity. So I would be interested to use QUIC as a replacement for TCP for this app.
Does QUIC-go self adjust its buffer needs for long distance connections (e.g 1Gbit/s &250ms RTT) ?
Is there another method to communicate with you to avoid creating issues ?
What you do is a great work. Thank you very much.

I think it would definitely interesting to give QUIC a shot. We're seeing better performance than TCP in a lot of benchmarks, and it's much easier to adapt the congestion to your specific requirements.
The receive buffer can be adjusted in our config (via the flow control receive window parameters).
Let us know if you get any interesting results! Feel free to reach out via email (it's on my github profile).

My throughput measurement was not serious. I just measure the average speed for sending a 64MB file from connection opening to connection close. If BBR is used, the throughput should increase as QUIC seeks the optimal throughput. If BBR is used, the optimal throughput should be in an internal variable, as well as the minimal RTT.
I saw that the MSS was set to 1200. It is often 1500. It might be interesting to add it to the set of configuration variables. 1200 could be a default value. Is it constant or adjusted ?

We're currently not using BBR, but a Cubic version adopted for QUIC.
According the QUIC spec, the maximum packet size is 1200 bytes (unless an implementation does PMTUD). That's why we can't introduce a configuration option to set that value. You can try to increase it manually in the constants and see if it changes anything.

@chmike, I'm closing this issue. Please feel free to open a new issue if you have any further questions.


Add Koa support

Koa support similar to Express, but with withRouter and withSubRouter support
Enhanced demo compared to Express, by using a randomMessage module
Express demo: Use ../src import so that live code is used.

Thoughts
For follow-up?

What would be needed to make the DSL more protective.
ie:

withRouter should not be called within another withRouter call. Instead one should call withSubRouter
Or is it fine that someone may compose an invalid program? - well invalid from a certain perspective.

closing in favour of #192


Update README.md

Fixed Typo.

Hey @Steven-Chorkawy, thank you 👏 for your contribution - it is highly appreciated. This should be live shortly 😊


Project dead?

Is this project dead?

More like email hacked

What u mean?

This: https://github.com/lidgren/lidgren-network-gen3/pull/4#issuecomment-237390222

Something stole my entire Contacts list and github helpfully has reply-to which contain authentication - so they're just sending mails to random contacts of mine - some ending up here :-(


Changing TabContainer hseparation property does not adjust tabs

Godot version:
Godot v3.2.2.beta1.mono.official
OS/device including version:
Windows 10 Pro version 1909
Issue description:
Altering the hseparation value within the TabContainer's Custom Constants menu does not adjust the horizontal separation between tabs as the tooltip suggests
Steps to reproduce:
Create a scene:
TabContainer
-Control
-Control
-Control

With the TabContainer node selected and using the inspector, alter the value of Hseparation in the Custom Constants dropdown. The tabs maintain position and do not move.

This is because the hseparation is actually a space between tab's name and its icon. The documentation is wrong.


BIGTOP-3316: Fix HBase build failure on Arm platform

After HBase is bumped to 1.5.0, jruby patch command in build
script doesn't apply due to regex not match.
This patch refines sed command to make it more versatile to
various asciidoctorj-pdf versions.
Change-Id: Ib414ba3e7b66cf08e2080c75e1c83c563fa88224
Signed-off-by: Jun He<EMAIL_ADDRESS>

Verified with build tests of Ubuntu and Centos on arm servers.

Looks good. +1.

Thanks for review, @evans-ye


[occm] Replace call to Nova os-interfaces with direct Neutron call

What this PR does / why we need it:
os-interfaces is a proxy API for neutron's ports list. This has 2 significant disadvantages to us:

It adds the overhead of an extra API call every time it is used
It doesn't contain all the information returned by Neutron

This is a non-functional change, although is does reduce the load on nova-api without reducing functionality.
The primary motivation for this is to enable additional filtering using information from ports, e.g. filtering by port tag or the addition of subports as in #2228.
Release note:

NONE

cc @stephenfin @dulek

/cc @stephenfin @dulek

To the best of my knowledge, the only thing exposed by the nova /server/{server}/os-interface API that is not exposed by the /ports?device_id={server} API is the device tags. If you don't need those, this should be a no-op.

/lgtm

@mdbooth I don't think it's a good idea. We need to keep the interfaces order, listing neutron ports doesn't provide the exact order. See #863

You're thinking of server.Addresses, which preserves order. This change doesn't affect that. The API it replaces also doesn't guarantee order.

@mdbooth interesting. so it looks like the neutron default order is a timestamp, right? When an interface is attached to a node, neutron creates a port and the port gets the recent timestamp. If this order corresponds to the os-interfaces order, then I'm fine with a change ;)

@zetaab @jichenjc Could we merge this?


[WIP] Fix missing/wrong text for pt-br locale

Solves #1232

Hi @herodrigues, sorry that you PR wasn't reviewed in a timely manner. If you're interested in resubmitting it, I would be able to take a look now. :)

@feross, I don't have that fork anymore.
I'd have to start over again.

@feross, I don't have that fork anymore.
[...]

https://help.github.com/en/articles/checking-out-pull-requests-locally#modifying-an-inactive-pull-request-locally
see also this answer:

https://stackoverflow.com/questions/27567846/how-can-i-check-out-a-github-pull-request/30584951#30584951


[Snyk] Upgrade puppeteer from 22.7.1 to 22.8.0

This PR was automatically created by Snyk using the credentials of a real user.Snyk has created this PR to upgrade puppeteer from 22.7.1 to 22.8.0.
:information_source: Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.

The recommended version is 1 version ahead of your current version.
The recommended version was released 3 days ago, on 2024-05-06.

Release notes

Package name: puppeteer

22.8.0 - 2024-05-0622.8.0 (2024-05-06)
Miscellaneous Chores

puppeteer: Synchronize puppeteer versions

Dependencies

The following workspace dependencies were updated

dependencies

puppeteer-core bumped from 22.7.1 to 22.8.0

22.7.1 - 2024-04-2522.7.1 (2024-04-25)
Miscellaneous Chores

puppeteer: Synchronize puppeteer versions

Dependencies

The following workspace dependencies were updated

dependencies

puppeteer-core bumped from 22.7.0 to 22.7.1
@ puppeteer/browsers bumped from 2.2.2 to 2.2.3

    from puppeteer GitHub release notes

Commit messages

Package name: puppeteer

0ab1194 chore: release main (#12375)
d6be753 chore(deps): Bump the all group in /website with 6 updates (#12388)
b7f1993 chore(deps-dev): Bump the dev-dependencies group with 7 updates (#12387)
f23646b test: update canary expectations (#12386)
5772210 chore: add an ExtensionTransport (#12382)
0af4664 test: add canary specific expectation file (#12383)
dc303f0 test: clean test in after hook (#12325)
461a8ff fix: disable IsolateSandboxedIframes trial to prevent flakiness (#12381)
f7e44b9 ci: post a comment on canary failures (#12380)
73d7692 fix: turn on PdfOopif for PDF viewer (#12370)
44fb53e test: add a test for the web build (#12367)
54a6377 fix: remove --disable-field-trial-config (#12377)
dffad28 fix: deprecate CDP for Firefox (#12349)
533f83a docs: document dbus in the docker guide (#12378)
dfb31f3 test: puppeteer.connect with `using` disconnects the browser (#12371)
b5aab04 fix: don't start dbus service during build in Dockerfile (#12374)
b95ff05 chore: add Docker changes to release (#12373)
bed9a76 fix: set the default locale in Docker to en_US.UTF-8 (#12369)
d96b781 ci: make installation test more like the rest of tests (#12368)
110351a chore: pass down config form CDP connection to BiDi (#12366)
3103744 chore: don't run `destroyHandles` if realm is already disposed (#12365)
41d4320 docs: show `experimental` and `remark` blocks (#12363)
fb0d725 refactor: split entrypoint imports (#12350)
6fa6ce5 chore(deps): Bump the all group in /website with 4 updates (#12355)

Compare

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information:
🧐 View latest project report
🛠 Adjust upgrade PR settings
🔕 Ignore this dependency or unsubscribe from future upgrade PRs

coverage: 99.245%. remained the same
when pulling 4a63d78af1a1059ae2b23fdba966d1b2593c0f87 on snyk-upgrade-65185b14349c769dd1298ff803a47bab
into e96954da0ec6cb098216265d683f2e22017ec48f on master.


Update CLA link

Description
Replace Firebase dynamic links with Bitly alternative
Related issues & PRs
SC-14984

@Sese-Schneider can you please check why the check are not running 🤔

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

What exactly is missing here to merge the PR?


Extension Pack tab missing for Java Extension Pack

Java Extension Pack was updated to use the new "extensionPack" entry in package.json. However, the Extension Pack tab is missing in VS Code:

Instead, we see "Contributions" and "Changelog"
But for other extension packs, VS Code works this way:

And now we see "Extension Pack"
Do we miss anything?

@akaroml It is because of using old version of vsce to publish the extension. Please use the latest vsce and try.

@sandy081 thank you for the info.
@testforstephen please help upgrade vsce to the latest version in our CI pipeline.


fix(deps): update module github.com/ibm/platform-services-go-sdk to v0.31.1

This PR contains the following updates:

Package
Type
Update
Change

github.com/IBM/platform-services-go-sdk
require
patch
v0.31.0 -> v0.31.1

Release Notes

IBM/platform-services-go-sdk
v0.31.1
Compare Source
Bug Fixes

Usage Reports: rename Account_Summary billing_month property (#222) (8d3a404)

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, click this checkbox.

This PR has been generated by Renovate Bot.

:tada: This PR is included in version 1.2.15 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


UI Rework - Phase 2

This fixes the focus system. It works pretty much as you expect, clicking on certain controls gives them keyboard focus, clicking on the game screen or pressing escape removes it. As an added bonus, the GameScreen now controls the KeyBindingManager, so you can easily block game input with the UI input events.

Making this a separate PR probably isn't that great of an idea, now I have to regular merge the last one just to get this one to keep existing.

This PR get cherry picked into https://github.com/space-wizards/space-station-14/pull/463.


cowboy:stop_listener/1 crashes when calling it from my app shell

I don't think this is expected behaviour but if I try to stop a listener from my application shell I get a crash dump.
The motivation to do this is because I cannot stop my service using the start script generated by rebar3 when releasing, and I think this could be related. Something is getting stucked while stopping the service and definitely is cowboy related (without this app no problems so far).
I've tried the workaround suggested in #1021 but the result is the same. My project is running on Erlang 18.3.
This issue in ranch could also be relevant.
> cowboy:stop_listener(http_server).
> 16:57:30.310 [info] Application my-service exited with reason: shutdown
Terminating: []
{"Kernel pid terminated",application_controller,"{application_terminated,my-service,shutdown}"}

Crash dump is being written to: erl_crash.dump...done
Kernel pid terminated (application_controller) ({application_terminated,my-service,shutdown}

It shouldn't happen with Cowboy master. Try it.

I've just tried tag 2.0.0-pre.6 but it's not working for me. Same issue.

But have you also updated Ranch or was it the same version as before? The fix is in Ranch.

Well, I did rebar3 upgrade and then rebar3 release .... I saw in the output that ranch 1.3.0 was fetched. In fact I tried this before upgrading manually ranch to that version and it didn't solve the issue.
I'll check again on Monday. Maybe I did something wrong.

I can't reproduce on the ssl_hello_world example. I need more info if it's really an issue in Cowboy.

I will try running the examples provided because the problem is still present. I've built the project again with tag 2.0.0-pre.6 and checked that ranch 1.3.0 was being used and happens the same.

I've managed to understand what was going on. I was returning the cowboy PID in the start function, so when stopping the listener the whole application went down. I didn't pay attention to that return value, sorry!


Unexpected behaviour with angular directive

It returns an unexpected alignment result in case of this:
scope: {
  /* start selection */
  mapRef: '=',
  stateData: '=',
  polygons: '=',
  onWirecenterClicked: '=',
  onShowResultsChange: '='
  /* end selection */
}

solved in 0.11.0 if you exclusively set the character ":" as alignment char. Of course you can also use multiple cursors for the alignment. Then there is no need to change the settings, just place the cursors in front of each ":"


Define iPack Config Validation Code

Throw out specific errors for unsupported configuration types:
For example in v1 we will not support telemetry modules constantly streaming via a stream based solution but rather only support bulk uploads via a blob type facility.  If attempting to upload a config with stream set to TRUE, should return error code indicating as such.
NEED TO ALSO DEFINE what we support / don't support up front as well as what we plan to eventually support.

{
"name" : "visual_defect",
"version" : "0.0.1",
"industry" : "manufacturing",
"deploy_type" : "azure", // goal to support aws & on-prem; currently only azure supported.


Issue with __synchronize() identifier undefined.

So this started out as an issue with the identifier __synchonize() undefined. After tweaking the code a little bit, I was able to fix the issue by removing #include <device_launch_parameter.h> however, this makes global undefined. I am at a loss here, I searched everywhere online. I need help! thanks in advance. :)
Images https://imgur.com/a/COQe0Ef

Hi @Emerald233, Thank you for raising the issue. Can you please share your python, numba, llvmlite version. Also, please included a self-contained code sample to reproduce the problem i.e. it's possible to run as 'python bug.py'. so that I can reproduce and debug it.

I apologize, I did post this in the wrong repository thank you for informing me, I will post in the correct repository next time. I solved the issue, visual studio will underline some identifiers as error, but the code works fine when you run it. it's a bug they are currently trying to work out.


sdk updates etc

Docs Build status updates of commit 59fb09e:
:warning: Validation status: warnings

File
Status
Preview URL
Details

Advertising/bingads-13/guides/authentication-oauth-identity-platform.md
:warning:Warning

Details

Advertising/bingads-13/guides/release-notes.md
:white_check_mark:Succeeded

Advertising/bingads-13/guides/authentication-oauth-identity-platform.md

Line 96, Column 450: [Warning-file-not-found] Invalid file link: 'reference-third-party-cookies-spas.md'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 7dd2049:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

Advertising/bingads-13/guides/authentication-oauth-identity-platform.md
:white_check_mark:Succeeded

Advertising/bingads-13/guides/get-started-java.md
:white_check_mark:Succeeded

Advertising/bingads-13/guides/handle-service-errors-exceptions.md
:white_check_mark:Succeeded

Advertising/bingads-13/guides/release-notes.md
:white_check_mark:Succeeded

Advertising/bingads-13/guides/walkthrough-web-application-java.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 66bd3c7:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

Advertising/bingads-13/campaign-management-service/adduettags.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/eventgoal.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/uettag.md
:white_check_mark:Succeeded

Advertising/bingads-13/guides/authentication-oauth-identity-platform.md
:white_check_mark:Succeeded

Advertising/bingads-13/guides/get-started-java.md
:white_check_mark:Succeeded

Advertising/bingads-13/guides/handle-service-errors-exceptions.md
:white_check_mark:Succeeded

Advertising/bingads-13/guides/release-notes.md
:white_check_mark:Succeeded

Advertising/bingads-13/guides/report-attributes-performance-statistics.md
:white_check_mark:Succeeded

Advertising/bingads-13/guides/universal-event-tracking.md
:white_check_mark:Succeeded

Advertising/bingads-13/guides/walkthrough-web-application-java.md
:white_check_mark:Succeeded

Advertising/bingads-13/reporting-service/accountperformancereportcolumn.md
:white_check_mark:Succeeded

Advertising/bingads-13/reporting-service/campaignperformancereportcolumn.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


Add styles for new submenu

When searching some keywords like "covid-19 vaccinations", Google shows a new menu (Overview, New...) on the sidebar. This pull request make the menu don't overlap the search tools menu.
Fixes #38.

I think this fix is much better and makes your script useful but there is overlap ... in your search term above, I see "COVID-19" and "Covid-19 vaccine" overlapping the middle and right parts of "past hour" and "past 24 hours" respectively.  if that's the best that can be done, I'm still happy as it's still operational as you can still click on "past hour" and "past 24 hours" while before you could not


Fix chain-sync client bootstrapping on the direct chain.

Without that, there's no way we can hope the chain-sync client to observe anything on a real chain in a timely manner, since it'd have to synchronize the entire chain first.

We could write tests for that now :)


Add the only good font

Ah yes. Absolute requirement in a Reddit app

You passed the code review

💯 🥇