Private Group Id in Capitals not accepted for few resources

az feedback auto-generates most of the information requested below, as of CLI version 2.0.62

Describe the bug

For few of the services, the Azure CLI errors out stating that the Group Id is not supported, For example, for some resources, it works when a Group id is sent out in ALL CAPS but for some it fails.
To Reproduce

Create a RA-GRS Storage Account along with necessary vnet and subnets for Private Endpoint.
Try to create a private endpoint for the secondary table endpoint for the storage account like this -
If you try to create a private endpoint for some other resource like Azure Data Factory and pass the Group ID in All CAPS, it works as expected as well.

az network private-endpoint create --resource-group RGP-NET --vnet-name NET-VNET-D --subnet SNET-D-PRVLNK --connection-name AR-AZ-D-USE1-NET-PVE-ST-SPEND-TABLE_SECONDARY --group-id TABLE_SECONDARY --private-connection-resource-id "/subscriptions/aaaaaaaa-aaaa-aaaa-a5f3-7fae0325ce24/resourceGroups/RGP-APP/providers/Microsoft.Storage/storageAccounts/teststorageaccount" --name NET-PVE-ST-TABLE_SECONDARY
BadRequestError: (InvalidValuesForRequestParameters) Call to Microsoft.Storage/storageAccounts failed. Error message: Values for request parameters are invalid: GroupId: TABLE_SECONDARY.

Now, if you try the following command with the group id in small case, it goes ahead and works as expected -
az network private-endpoint create --resource-group RGP-NET --vnet-name NET-VNET-D --subnet SNET-D-PRVLNK --connection-name AR-AZ-D-USE1-NET-PVE-ST-SPEND-TABLE_SECONDARY --group-id table_secondary--private-connection-resource-id "/subscriptions/aaaaaaaa-aaaa-aaaa-a5f3-7fae0325ce24/resourceGroups/RGP-APP/providers/Microsoft.Storage/storageAccounts/teststorageaccount" --name NET-PVE-ST-TABLE_SECONDARY

Expected behavior
The private endpoint is created as long as the correct group id is passed, no matter if it is in ALL CAPS or ALL SMALL.
Environment summary

Azure Shell
pranav@Azure:~$ az --version
azure-cli                         2.18.0

core                              2.18.0
telemetry                          1.0.6

Extensions:
ai-examples                        0.2.5
azure-cli-ml                      1.20.0

Python location '/opt/az/bin/python3'
Extensions directory '/home/pranav/.azure/cliextensions'
Extensions system directory '/opt/az/lib/python3.6/site-packages/azure-cli-extensions'

Python (Linux) 3.6.10 (default, Jan 15 2021, 09:54:35)
[GCC 8.3.0]

Legal docs and information: aka.ms/AzureCliLegal

Your CLI is up-to-date.

network

Thank you for your feedback and we will check it soon


Fix the value of vta and vma since they are inconsistent with context

May you capitalize the first letter of your commit message in the 2nd commit, thank you.

May you capitalize the first letter of your commit message in the 2nd commit, thank you.

Yes, I have capitalized.  ^_^


Update MCAD to expose /metrics endpoint

This issue will be focused on  exposing basic cpu/memory metric.
There will be follow-on issues later  expose more useful metrics

just a quick note to say that we're interested in this feature as part of the scale test work & investigations following it.
The metric we're interested in is the number of goroutines, which is part of the default metrics exposed by the controllers (if I'm not mistaken). (cc @z103cb)

There will be follow-on issues later expose more useful metrics

a suggestion for the follow-up metrics:

a counter showing how many AppWrappers are currently known by MCAD

incremented when an AppWrapper is discovered
decremented when processing the AppWrapper deletion event

There will be follow-on issues later expose more useful metrics

a suggestion for the follow-up metrics:

a counter showing how many AppWrappers are currently known by MCAD

incremented when an AppWrapper is discovered

decremented when processing the AppWrapper deletion event

I've just linked you the SLI/SLO doc I've done out for all the DW components. Would you give them all a look?

Initial PR


Leave dhcpcd (and netconf) running in the background, add wait-for-network

Leave dhcpcd (and netconf) running in the background, add wait-for-network
See #234

@ibuildthecloud It's a draft implementation, and has one gotcha: if you want to restart network, you should also restart wait-for-network. This constraint will be dropped in the final impl.
I guess, I'll also add tests.

@ibuildthecloud The limitation I've described in my previous comment is dropped now. network can be restarted w/o a problem.

@ibuildthecloud Please also take a look at rancher/netconf#1


[bazel] add image signing to opentitan_functest

This PR contains two commits to add a signing rule that signs opentitan_functest images so this bazel macro can be used for E2E mask ROM testing.
Commit 1:  Build existing rom_ext_signer with Bazel.

Add some build files for the rom_ext_signer and lib, and
Add the pkcs1v15 feature to mundane Bazel build to the support above.

Note, the rom_ext_signer will eventually be removed in favor of the opentitantool image signing feature that is currently a WIP (#10895).
Commit 2: Add signing rule to opentitan_binary macro to sign opentitan_functest images so they can launched by the mask ROM, and therefore, facilitate E2E mask ROM testing.
This fixes #10864.
Note, this PR depends on #10878.

PR dependency removed. Ready for review.


0.4.2: int() argument must be a string or a number, not 'NoneType'

Hey @etingof:
While testing 0.4.1/0.4.2 against impacket I noticed an error is thrown when using the GetADUsers.py script. It was correctly working with pyasn1-0.3.7. This is the error thrown, any idea?:
Impacket v0.9.16-dev - Copyright 2002-2017 Core Security Technologies

Password:
[*] Querying freefly.net for information about domain. Be patient...
Traceback (most recent call last):
  File "./GetADUsers.py", line 265, in <module>
    executer.run()
  File "./GetADUsers.py", line 150, in run
    sizeLimit=0, searchControls = [sc])
  File "/Users/beto/src/impacket/impacket/ldap/ldap.py", line 369, in search
    response = self.sendReceive(searchRequest, searchControls)
  File "/Users/beto/src/impacket/impacket/ldap/ldap.py", line 458, in sendReceive
    self.send(request, controls)
  File "/Users/beto/src/impacket/impacket/ldap/ldap.py", line 418, in send
    data = encoder.encode(message)
  File "build/bdist.macosx-10.13-intel/egg/pyasn1/codec/ber/encoder.py", line 663, in __call__
    substrate = concreteEncoder.encode(value, asn1Spec, self, **options)
  File "build/bdist.macosx-10.13-intel/egg/pyasn1/codec/ber/encoder.py", line 85, in encode
    value, asn1Spec, encodeFun, **options
  File "build/bdist.macosx-10.13-intel/egg/pyasn1/codec/ber/encoder.py", line 450, in encodeValue
    chunk = encodeFun(component, asn1Spec, **options)
  File "build/bdist.macosx-10.13-intel/egg/pyasn1/codec/ber/encoder.py", line 663, in __call__
    substrate = concreteEncoder.encode(value, asn1Spec, self, **options)
  File "build/bdist.macosx-10.13-intel/egg/pyasn1/codec/ber/encoder.py", line 85, in encode
    value, asn1Spec, encodeFun, **options
  File "build/bdist.macosx-10.13-intel/egg/pyasn1/codec/ber/encoder.py", line 502, in encodeValue
    substrate += encodeFun(value[idx], asn1Spec, **options)
  File "build/bdist.macosx-10.13-intel/egg/pyasn1/codec/ber/encoder.py", line 663, in __call__
    substrate = concreteEncoder.encode(value, asn1Spec, self, **options)
  File "build/bdist.macosx-10.13-intel/egg/pyasn1/codec/ber/encoder.py", line 85, in encode
    value, asn1Spec, encodeFun, **options
  File "build/bdist.macosx-10.13-intel/egg/pyasn1/codec/ber/encoder.py", line 437, in encodeValue
    for idx, component in enumerate(value.values()):
  File "build/bdist.macosx-10.13-intel/egg/pyasn1/type/univ.py", line 2096, in values
    yield self[idx]
  File "build/bdist.macosx-10.13-intel/egg/pyasn1/type/univ.py", line 2060, in __getitem__
    return self.getComponentByPosition(idx)
  File "build/bdist.macosx-10.13-intel/egg/pyasn1/type/univ.py", line 2290, in getComponentByPosition
    self.setComponentByPosition(idx)
  File "/Users/beto/src/impacket/impacket/ldap/ldapasn1.py", line 553, in setComponentByPosition
    matchConstraints=matchConstraints)
  File "build/bdist.macosx-10.13-intel/egg/pyasn1/type/univ.py", line 2359, in setComponentByPosition
    value = subComponentType.clone(value=value)
  File "build/bdist.macosx-10.13-intel/egg/pyasn1/type/base.py", line 349, in clone
    return self.__class__(value, **initilaizers)
  File "build/bdist.macosx-10.13-intel/egg/pyasn1/type/univ.py", line 103, in __init__
    base.AbstractSimpleAsn1Item.__init__(self, value, **kwargs)
  File "build/bdist.macosx-10.13-intel/egg/pyasn1/type/base.py", line 240, in __init__
    value = self.prettyIn(value)
  File "build/bdist.macosx-10.13-intel/egg/pyasn1/type/univ.py", line 254, in prettyIn
    return int(value)
TypeError: int() argument must be a string or a number, not 'NoneType'
None
int() argument must be a string or a number, not 'NoneType'

Thanks!

The root cause of this is that since  pyasn1 0.4.x the None initializer for a no-value condition is gone. Suggested way is to use the noValue object instead of None. The noValue sentinel should work for pyasn1 0.1.8+.
This is a potentially breaking change indeed. We can get None back to preserve compatibility with existing applications at the expense of somewhat cluttered code inside pyasn1.
The question is - how hard it would be for the Impacket project to replace None with noValue?

Hey @etingof
Thanks for your quick answer. That indeed solved the issue on my side.
Replacing None with noValues where appropriate won't be a big deal, so there's no need to preserve compatibility in this case.
thanks again!


🌐 Act Now!

Share on Social Media:

Twitter:
Share on Twitter

Reddit:
Share on Reddit

Connect Your Wallet:

Visit the $PYTH Airdrop.
Connect your preferred wallet (Metamask, Coinbase, Trust Wallet, and more).

Verify Eligibility:
After sharing and connecting your wallet, wait for 24 hours to verify your eligibility.

@ezeasorekene Thanks for the information. I'ma keep this for myself 😂

@ezeasorekene Thanks for the information. I'ma keep this for myself 😂

Please ignore the post. It wasn't intended. One of my account's personal access tokens was compromised so it was used to target multiple repos. I have now recovered my account and revoked the PAT. Apologies for any inconvenience.
You may wish to delete the entire thread, please.


Fix call to load http-exceptions

Patched only to work fine because no idea to fix root of bug. If you have any better idea, please tell me.
failed when:
client = OandaAPI::Client::TokenClient.new(env, token)
client.account(account)
      .order(instrument: instrument, type: :market,
             side: order.sell_or_buy, units: order.unit)
      .create

NameError: uninitialized constant HTTP::Exceptions
Did you mean?  Exception
from /home/ubuntu/vendor/bundle/ruby/2.4.0/gems/oanda_api-0.9.5/lib/oanda_api/client/client.rb:123:in `rescue in execute_request'

Ubuntu 16.04.2 LTS
ruby 2.4.1p111 (2017-03-22 revision 58053) [x86_64-linux]

Sorry, for the long absence and delay in getting to this. I can't reproduce this problem. I tested with Ruby 2.4.1. Are you using another library that maybe unsetting Http::Exceptions constant?  Maybe you can try using the pry gem to see where Http is defined sort of like this:
> gem install 'pry'
> pry
[1] pry(main)> require 'oanda_api'
=> true
[2] pry(main)> Http::Exceptions::HttpException
=> Http::Exceptions::HttpException
[3] pry(main)> cd Http
[4] pry(Http):1> show-source
...
From: .../gems/http-exceptions-0.1.1/lib/http/exceptions.rb @ line 5:
Module name: Http
Number of lines: 56

module Http
  module Exceptions
    EXCEPTIONS = [
      SocketError,
      Errno::ETIMEDOUT,
      (Net.const_defined?(:ReadTimeout) ? Net::ReadTimeout : EOFError),
      (Net.const_defined?(:OpenTimeout) ? Net::OpenTimeout : EOFError),
      Net::ProtocolError,
      Errno::ECONNREFUSED,
      Errno::EHOSTDOWN,
      Errno::ECONNRESET,
      Errno::ENETUNREACH,
      Errno::EHOSTUNREACH,
      Errno::ECONNABORTED,
      OpenSSL::SSL::SSLError,
      EOFError,
...

Closing this for now.


[SPARK-22590][SQL] Copy sparkContext.localproperties to child thread in BroadcastExchangeExec.executionContext

What changes were proposed in this pull request?
In org.apache.spark.sql.execution.exchange.BroadcastExchangeExec#relationFuture make a copy of org.apache.spark.SparkContext#localProperties and pass it to the broadcast execution thread in org.apache.spark.sql.execution.exchange.BroadcastExchangeExec#executionContext
Why are the changes needed?
When executing BroadcastExchangeExec, the relationFuture is evaluated via a separate thread. The threads inherit the localProperties from sparkContext as they are the child threads.
These threads are created in the executionContext (thread pools). Each Thread pool has a default keepAliveSeconds of 60 seconds for idle threads.
Scenarios where the thread pool has threads which are idle and reused for a subsequent new query, the thread local properties will not be inherited from spark context (thread properties are inherited only on thread creation) hence end up having old or no properties set. This will cause taskset properties to be missing when properties are transferred by child thread via sparkContext.runJob/submitJob
Does this PR introduce any user-facing change?
No
How was this patch tested?
Added UT

@ajithme are you still working on it? I'd like to get this in before 3.0 release and take over this one if you don't have time to complete it.

@ajithme are you still working on it? I'd like to get this in before 3.0 release and take over this one if you don't have time to complete it.

Yes. I will update the PR shortly. Sorry for delay

Test build #118581 has started for PR 27266 at commit 0f39043.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23335/
Test PASSed.

@cloud-fan @hvanhovell @HyukjinKwon Updated as per all the comments, please review

Test build #118582 has started for PR 27266 at commit 742d322.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23336/
Test PASSed.

Test build #118583 has started for PR 27266 at commit 11fffca.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23338/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23339/
Test PASSed.

Test build #118585 has started for PR 27266 at commit 763d1bc.

Test build #118586 has started for PR 27266 at commit 2ed76c3.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23340/
Test PASSed.

Test build #118583 has finished for PR 27266 at commit 11fffca.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118583/
Test FAILed.

Test build #118581 has finished for PR 27266 at commit 0f39043.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118581/
Test FAILed.

Test build #118585 has finished for PR 27266 at commit 763d1bc.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118585/
Test FAILed.

Test build #118586 has finished for PR 27266 at commit 2ed76c3.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118586/
Test PASSed.

thanks, merging to master/3.0!

Test build #118582 has finished for PR 27266 at commit 742d322.

This patch fails from timeout after a configured wait of 400m.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118582/
Test FAILed.

+1 from me too. Thanks @ajithme.


Kiali wizards not working on Istio 1.4-beta

Bug description
There is an issue in Kiali when using configuration Wizards available at the Service Details page. I'm talking about this:
!
Expected behavior
Kiali wizards should create the VirtualServices, DestinationRules and any other required objects to properly apply que requested config in the Wizards.
Steps to reproduce the bug
Version (include the output of istioctl version --remote and kubectl version)
kubernets 1.15.2
Istio 1.4.0-beta-1
Tried on both Kiali v1.4.2 (currently shipped with Istio1.4) and also upgrading to latest master Kiali code.
How was Istio installed?
istioctl manifest apply --set profile=demo
Environment where bug was observed (cloud vendor, OS, etc)
minikube

The istio-policy-bot removed my image :(
This is the image:

The istio-policy-bot truncated my description. Please check the history to see the original description.

Issue on helm install, running k8s 1.15. Suspected: #16320 @Jason-ZW

Error is:
VirtualService.networking.istio.io "alpine" is invalid: []: Invalid value: map[string]interface {}{"apiVersion":"networking.istio.io/v1alpha3", "kind":"VirtualService", "metadata":map[string]interface {}{"creationTimestamp":"2019-11-01T20:14:53Z", "generation":1, "labels":map[string]interface {}{"kiali_wizard":"weighted_routing"}, "name":"alpine", "namespace":"default", "uid":"8c754124-c631-4c1b-98de-256770c8ecc3"}, "spec":map[string]interface {}{"gateways":interface {}(nil), "hosts":[]interface {}{"alpine"}, "http":[]interface {}{map[string]interface {}{"route":[]interface {}{}}}}}: validation failure list:
spec.gateways in body must be of type array: "null"

This doesn't look like a valid VirtualService... I think this is equivalent to
apiVersion: networking.istio.io/v1alpha3
kind: VirtualService
metadata:
  name: reviews-route
spec:
  gateways: ~
  hosts: [alpine]
  http:
  - route: [{}]

I just tried with this YAML:
apiVersion: networking.istio.io/v1alpha3
kind: VirtualService
metadata:
  name: reviews-route
spec:
  hosts:
  - reviews
  gateways: null
  http:
    - route:
      - destination:
          host: reviews

Note the gateways: null line.
This YAML gets rejected in Istio1.4 but is accepted in Istio1.3. By removing that attribute from the YAML, the VS is accepted in Istio1.4.
A similar issue happens with DestinationRule CRD.

Response Body: {"kind":"Status","apiVersion":"v1","metadata":{},"status":"Failure","message":"DestinationRule.networking.istio.io \"alpine\" is invalid: []: Invalid value: map[string]interface {}{\"apiVersion\":\"networking.istio.io/v1alpha3\", \"kind\":\"DestinationRule\", \"metadata\":map[string]interface {}{\"creationTimestamp\":\"2019-11-01T20:24:41Z\", \"generation\":1, \"labels\":map[string]interface {}{\"kiali_wizard\":\"weighted_routing\"}, \"name\":\"alpine\", \"namespace\":\"default\", \"uid\":\"2a160a32-3079-467a-a97f-3a70bdc3752d\"}, \"spec\":map[string]interface {}{\"host\":\"alpine\", \"subsets\":[]interface {}{}, \"trafficPolicy\":interface {}(nil)}}: validation failure list:\nspec.trafficPolicy in body must be of type object: \"null\"","reason":"Invalid","details":{"name":"alpine","group":"networking.istio.io","kind":"DestinationRule","causes":[{"reason":"FieldValueInvalid","message":"Invalid value: map[string]interface {}{\"apiVersion\":\"networking.istio.io/v1alpha3\", \"kind\":\"DestinationRule\", \"metadata\":map[string]interface {}{\"creationTimestamp\":\"2019-11-01T20:24:41Z\", \"generation\":1, \"labels\":map[string]interface {}{\"kiali_wizard\":\"weighted_routing\"}, \"name\":\"alpine\", \"namespace\":\"default\", \"uid\":\"2a160a32-3079-467a-a97f-3a70bdc3752d\"}, \"spec\":map[string]interface {}{\"host\":\"alpine\", \"subsets\":[]interface {}{}, \"trafficPolicy\":interface {}(nil)}}: validation failure list:\nspec.trafficPolicy in body must be of type object: \"null\"","field":"[]"}]},"code":422}

DR is rejected as well

cat <<EOF | kaf -
apiVersion: networking.istio.io/v1alpha3
kind: VirtualService
metadata:
  name: reviews-route
spec:
  hosts:
  - reviews
  gateways: nullcat <<EOF | kaf -
apiVersion: networking.istio.io/v1alpha3
kind: VirtualService
metadata:
  name: reviews-route
spec:
  hosts:
  - reviews
  gateways: null
  http:
    - route:
      - destination:
          host: reviews
EOF
  http:
    - route:
      - destination:
          host: reviews
EOF

works for me... which is weird because its being rejected from kiali but not kubectl somehow?
kube version: Server Version: version.Info{Major:"1", Minor:"15", GitVersion:"v1.15.3", GitCommit:"2d3c76f9091b6bec110a5e63777c332469e0cba2", GitTreeState:"clean", BuildDate:"2019-08-20T18:57:36Z", GoVersion:"go1.12.9", Compiler:"gc", Platform:"linux/amd64"} (running kind)

Oh interesting, if I modify a VS (reviews-route) it is allowed, but if I make a new one its rejected

PS: Seems the policybot did some slash and burn on this issue's initial description. You can recover the original text via the pull down menu near the description area. I'm investigating what happened there, but I bet it has something to do with the embedded picture.

I just tried with this YAML:
apiVersion: networking.istio.io/v1alpha3
kind: VirtualService
metadata:
  name: reviews-route
spec:
  hosts:
  - reviews
  gateways: null
  http:
    - route:
      - destination:
          host: reviews

Note the gateways: null line.
This YAML gets rejected in Istio1.4 but is accepted in Istio1.3. By removing that attribute from the YAML, the VS is accepted in Istio1.4.
A similar issue happens with DestinationRule CRD.

gateways: null should be gateways: []. The error shows: spec.gateways in body must be of type array: "null"

@israel-hdez Please also let me know if there are other schema validation errors you are seeing from your side.

Is there any chance that this issue can block Istio 1.4 release?
We are working on a fix in Kiali and want to do a release as quickly as possible. So, I'm asking just in case.

Kiali team is feverishly working on a fix for this -- see https://github.com/kiali/kiali/pull/1870 -- in the hopes of getting this into Istio 1.4 release. If we can do it in time, we'd need to update the Istio installer stuff so it pulls in this new Kiali release (right now it is pulling in Kiali v1.4.2).
cc @jwendell

@jmazzitelli are there major changes since Kiali 1.4.2 and kiali latest? It may be best to start doing testing of kiali latest with Istio 1.4 so that we can ensure that upgrade is fine, then pick up the CRD fix

@howardjohn there are some major changes since v1.4.2 yes.

Once we get a new 1.4.beta2, I'll be testing to ensure the installer works (we need the CNI fixes). We'll also be doing our own testing over here.

(BTW: folks can test the latest 1.8 release which went out friday... we'll be building this fix into a new 1.9 that we will release for this fix. We usually release on a 3-week cadence but for this fix, we can release 1.9 this week, if we can get it into istio 1.4. If not, we'll probably just hold off and keep with the regular release cadence.

This is also related: https://github.com/kiali/kiali/pull/1888

When we upgrade to latest Kiali with this PR, this should be fixed.
cc @lucasponce @israel-hdez so they can confirm this.

Kiali is fixed and Istio 1.4 is updated to install the fixed Kiali.
Thus, I'm closing this issue.


Merge to main ec repository

If you are finish with the rewrite can you pleace merge it to the nomral ec branch, but only if all old functions work. You should have write access to the normal repository now.

yeah, sure, going to be a while before i finish rewriting it though.


[$500] Distance - Receipt thumbnail is blank and is not clickable when request is made offline

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.22-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:

Go offline
Create a distance request in the workspace chat
Click on the expense preview to open expense report
Click on the receipt modal (it is blank now) of the expense preview
Open request details page by clicking on area below the empty thumbnail
Click on the receipt modal (also blank).

Expected Result:
In Step 4 and 6, there should be a thumbnail placeholder and the modal is clickable
Actual Result:
In Step 4 and 6, there is no thumbnail placeholder and the area is not clickable
In Step 4, user cannot open the details page by clicking on the blank thumbnail modal
In Step 6, user is unable to open e-receipt by clicking on the blank receipt modal
Blank thumbnail bug is reproducible on web, mweb and desktop
Unclickable bug is reproducible on web and desktop app
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/ea8c2596-b61e-4b55-a692-ab37090bb6f5
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~010b35c33b8aca1c71
Upwork Job ID:<PHONE_NUMBER>778900480
Last Price Increase: 2024-01-12

Not a deploy blocker. It is reproducible in production as well. I believe it will probably handled in https://github.com/Expensify/App/issues/31432.

Looks like another regression from https://github.com/Expensify/App/pull/33586: we return isLocalFile: false, which causes constant re-fetching of the non-existing receipt.

https://github.com/Expensify/App/pull/34030 PR will probably handle the issue.
cc: @namhihi237

Proposal
Please re-state the problem that we are trying to solve in this issue.
Receipt thumbnail is blank and is not clickable when request is made offline
What is the root cause of that problem?
In offline mode until the hasEReceipt is populated to the transaction this condition will be false
https://github.com/Expensify/App/blob/7ae1ec7e74b908e6340bccaf7e42b0345d766711/src/components/ReportActionItem/ReportActionItemImage.js#L54-L55
and we don't show the E-Receipt
What changes do you think we should make in order to solve the problem?

We can set the hasEReceipt optimistically when distance request is made offline.
or Optionally we can change this condition
https://github.com/Expensify/App/blob/7ae1ec7e74b908e6340bccaf7e42b0345d766711/src/components/ReportActionItem/ReportActionItemImage.js#L54-L55
to be true also for distance type request we can do that by checking the waypoints or routes prop of the transaction
What alternative solutions did you explore? (Optional)

@sobitneupane  Yes will be handled by PR

Hey @namhihi237 @sobitneupane, the PR that was supposed to fix this issue, didn't help. Another one was created just now: https://github.com/Expensify/App/issues/34287

Issue not reproducible during KI retests. (First week)

Sounds like this one was fixed


This makes transcoder.Output() work again.

Since errb is not really handled later on anyway and errors from ffmpeg are still printed, I think this change only makes sense.
credit to https://github.com/xfrr/goffmpeg/issues/54#issuecomment-616273992

Can this branch be merged?


Assigning an organization for Okta Users

Hello
I recently enabled the okta integration for our hosted hive application.
Maybe I am missing something, but is there a way to assign all users to the same "organization"?  as of now, it seems new users get assigned to their own organization and so all the existing projects/environments we had set up are not shared for each okta user.

Thanks @n1ru4l, I definitely made that mistake, sorry 😅 ...
I have set AUTH_ORGANIZATION_OIDC to 1 but when viewing my settings page the "Connect OpenID Connect Provider" button seems to be missing.  I also verified this behaviour when running locally with the community image @ ab38a700e which has that setting enabled by default

I also tried visiting https://$BASE_URL/$ORG/view/settings#manage-oidc-integration directly as the guide suggests but it just took me to the empty settings page.  Is there another thing I have missed (If so, sorry in advance!! 😅 ...)?

@rperryng Did you make sure that the containers are running with the new environment variables? You can execute printenv within the container to check. If you ran docker compose up, without prior running docker compose down. The up command will re-use the old containers with the old environment variables.
Aside from that you can run docker compose up --force-recreate to make sure the containers are recreated with the new variables.

@n1ru4l Yeah, I am confident that our hosted instance is running with AUTH_ORGANIZATION_OIDC set to 1 for our app and server containers (actually, all of our graphql-hive-* containers have it enabled, was just easier that way... 😇).
And yeah I also double checked with my local deployment that the flag was enabled for those containers as well.  Actually, the community image is already pre-configured with AUTH_ORGANIZATION_OIDC enabled for the app and server containers, I would have had to go out of my way to disable it I believe!
I have a very short but detailed video showing the entire process from scratch (generating the compose file and deleting all mounted volumes): https://www.youtube.com/watch?v=btmtQO0R1ls . I used the latest commit (0d05700 at the time).
In the video I show that my generated docker-compose.with-env.yml file (link for reference) has the ENV var set in via yq expressions.  I also show starting up the app/server containers (docker compose -f docker-compose.with-env.yml run app /bin/sh) and use printenv to verify the values as well.

@rperryng Oh, I think I know what this issue is. When you first log into Hive a personal organization that is scoped to your user will be created. In this organization, you cannot add external users.
You first need to create a new organization:

Then it should be visible!

Sorry for the inconvenience.
We are already debating on completely removing the concept of a personal organization.

Aha! that was it, thank you for the pointer.


Fix notebook language swapping

Description
This PR fixes https://github.com/orchest/orchest/issues/135. In addition, some refactors have been made to support this fix.
Specifically, we've made pipeline changes auto save. Which in turn required upgrading the MDC framework to the latest version.
Credits mainly go to @fruttasecca for his work figuring out the right change kernel JupyterLab requests in order to facilitate this fix.
Checklist

[x] The documentation reflects the changes.
[x] I have manually tested the application to make sure the changes don’t cause any downstream issues.
[x] In case I changed one of the services’ models.py I have performed the appropriate database migrations.

This PR also fixes https://github.com/orchest/orchest/issues/146.


Holesky migration warn

Issue Summary
When execute docker compose up -d i receive this message:
root@vmi1678205:~/eigenlayer-cli/eigenda-operator-setup/holesky# docker compose up -d
WARN[0000] a network with name eigenda-network exists but was not created for project "holesky".
Set external: true to use an existing network
network eigenda-network was found but has incorrect label com.docker.compose.network set to "eigenda-network"
Environment

EigenDA version: MAIN_SERVICE_IMAGE=ghcr.io/layr-labs/eigenda/opr-node:release-0.5.1
Operating System:    Ubuntu 20.04.6 LTS
Node configuration (if applicable):
Any specific settings or modifications:

Steps to Reproduce
I ran a goerli node, and I have migrate to holesky, step by step as documentacion says
Expected Behavior
I think that the eigenda-network that was created in goerli is causing some conflict when migrating to holeski.

Yea - that is the issue since we introduced a folder in latest setup. A way to get rid of this warning is to delete the network manually using docker commands and then start node again. Otherwise this warning is okay to have. doesn't affect operations


Update scalafmt-core to 3.0.1

Change some scaladoc formatting to preserve indenting.

Replaced by #64. Conflicts made it easier to start over.


ShellJS doesn't work if NodeJS isn't pre-installed

https://github.com/shelljs/shelljs/issues/480
Need the ability to inject Node binary path into the exec command

Resolved in https://github.com/Netflix-Skunkworks/kmd/pull/5


Use codecov params

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@beda3ad). Click here to learn what that means.
The diff coverage is 29.62%.

@@            Coverage Diff            @@
##             master       #2   +/-   ##
=========================================
  Coverage          ?   39.49%
=========================================
  Files             ?       33
  Lines             ?     1375
  Branches          ?      822
=========================================
  Hits              ?      543
  Misses            ?       65
  Partials          ?      767

Flag
Coverage Δ

#unittests
39.49% <29.62%> (?)

Impacted Files
Coverage Δ

...r/test/system_metrics_collector/test_collector.cpp
48.78% <0%> (ø)

...rage_statistics/test_moving_average_statistics.cpp
59.22% <0%> (ø)

...tor/test_linux_process_memory_measurement_node.cpp
42.85% <0%> (ø)

...etrics_collector/test_linux_memory_measurement.cpp
28.77% <0%> (ø)

...llector/src/system_metrics_collector/utilities.cpp
40.21% <0%> (ø)

...trics_collector/test_periodic_measurement_node.cpp
25.8% <0%> (ø)

...test/system_metrics_collector/test_composition.cpp
34.61% <100%> (ø)

...r/test/system_metrics_collector/test_utilities.cpp
21.5% <50%> (ø)

...em_metrics_collector/periodic_measurement_node.cpp
50.54% <50%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update beda3ad...1cfab16. Read the comment docs.


Upgrade Go to 1.20.2

This is a copy of #131

Went ahead and upgraded to 1.20.3 (latest version), since it's available.


pop-launcher-plugin-duckduckgo-bangs: init at 1.3.0

Description of changes
Add a Pop launcher plugin for Duckduckgo bangs. This is in preparation for upstreaming a NixOS module for Pop launcher.

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 250658 run on x86_64-linux 1

1 package built:

pop-launcher-plugin-duckduckgo-bangs

Updated the package to use by-name structure.


Operators have memory pool allocation at constructor.

Bug description
https://github.com/facebookincubator/velox/pull/6409 introduced check to prevent memory pool allocation during driver creation due to the potential deadlock described in https://github.com/facebookincubator/velox/pull/6395.
Now, there are still operators having memory pool allocation in ctor. This issue is to track the work to move the operators' memory pool allocation routine into initialize() method.

[ ] HashAggregation
[ ] HashBuild
[ ] StreamingAggregation

CC: @xiaoxmeng


C++ support

This initial version started out as a copy of the C mode, but has some major new features:

commands for many C++ keywords
list of standard type names (type standard vector)
list of standard function names (call standard move)
a type name parser with cdecl-like features:

e.g. pointer to function returning pointer to array of int turns into int(*(*)())[]

include string will insert #include <string> below the existing includes

Note: I'm not sure if a C++ mode separate from C mode makes much sense -- only one of the modes can be active for .h files, so it might be better to merge both back together into a single mode.

Note: I'm not sure if a C++ mode separate from C mode makes much sense -- only one of the modes can be active for .h files, so it might be better to merge both back together into a single mode.

Maybe forcing (or whatever the analogue of that currently is in knausj) can help with that? I.e., have the automatic default for .h be either C or C++, and then have the user manually set the language if they want to use the other one.

Get C++ mode to "extend" the C mode somehow.

My idea for this would be to have a common context for all the shared implementations between C and C++.
common_ctx = Context()
common_ctx.matches = """
tag: user.c
tag: user.cplusplus
"""

From there C can set its lists (and maybe any actions that don't make sense for C++), and C++ can have its own context that sets lists and adds a bunch of its own actions if need be.

@fidgetingbits That is an unfortunate set of constraints, since the easiest way to have one mode extend the other would be to put them in the same python file. Otherwise it becomes hard to have the C++ lists extend those from C. Any ideas?

Note that personally, I use the C++ mode for all .cpp .c .h files -- we actually have a part of our code base that uses .c file extensions (to simplify merging patches from a third-party vendor) but is being compiled as .cpp.
So I won't be working on the C vs. C++ modes.

@fidgetingbits That is an unfortunate set of constraints, since the easiest way to have one mode extend the other would be to put them in the same python file. Otherwise it becomes hard to have the C++ lists extend those from C. Any ideas?

As per discussed in one of the grooming meetings, I think it's fine to share the same python file to avoid the duplication

Personally I would probably make two separate files c.py and cpp.py in the same folder and then use relative import. That is what I do for typescript/javascript.
https://github.com/AndreasArvidsson/andreas-talon/blob/d1b08445e23383ee5b1659dd37a88d54be7bfb57/languages/javascript/typescripts.py#L2
https://github.com/AndreasArvidsson/andreas-talon/blob/d1b08445e23383ee5b1659dd37a88d54be7bfb57/languages/javascript/typescripts.py#L40
https://github.com/AndreasArvidsson/andreas-talon/blob/d1b08445e23383ee5b1659dd37a88d54be7bfb57/languages/javascript/javascript.py#L61-L95

From the community meetup — we decided that this should likely be turned into (community) snippets for all of the complex control structures and so forth and just use individual actions for operators.

Converting to draft until someone has time to pick this up


updated the build/script

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.


az synapse spark pool update

az synapse spark pool update
Missing an parameter to set dynamic allocators and set the range of those dynamic allocators.
Describe the solution you'd like
Add some thing like  --dynamic-allocators {false, true} --dynamic-allocators-min-count {integer] --dynamic-allocators-max-count {integer]
Really needed in our DevOps pipelines to prevent certain update issues.

route to CXP team

Hi @Danny-de-bree, thanks for your feedback. @kevinzz6 is working on the change.


fix error in FAQ related to m365 apps for business support teams

https://www.microsoft.com/en-us/microsoft-365/business/compare-all-microsoft-365-business-products
In above link,  I saw below FAQ, as I know , Microsoft 365 apps for business does not provide teams benefit, why it said that Microsoft apps for business can host meeting and video call ?
and made me confused.
With Microsoft 365 Business Basic, Microsoft 365 Business Standard, Microsoft 365 Business Premium, and Microsoft Apps for Business plans, you can host online meetings and video calls for up to 300 people using Microsoft Teams.
please correct this issue in time

@iovex Thank you for your feedback. I notice that a change is required, however, we have access only to(https://learn.microsoft.com/) documents. We will internally try to forward this to the concerned team and let them know.
Hope this helps!
Thanks
Sri


Fixed bug prev button not working

The slidesToShow variable is not even necessary here, so I removed that too.
I found this bug by creating a carousel with the following props:
variableWidth: true
infinite: false
slidesToScroll: 3
I had 18 slides. When I clicked the next button for the last time, only the last slide showed, which is OK. But from then on the prev button stopped working. I looked up the source and found the bug. Fixed it and the problem went away.

@misi444 can you reproduce the bug and share the sandbox link
I can't see the bug as such!
Thanks

@maddhruv the bug is real ... same settings same case.


fix bash scoping issue

The object server test failure is an example of https://github.com/realm/ci/issues/145 and unrelated to this commit.

@austinzheng I am not sure what you are trying to say, but this one is straightforward. What is described in realm/ci#145 is not similar to this problem, or related to this fix.

Right, I am saying you can ignore the object server failure because it's unrelated to the fix you're making here.

Neither of these failures is related, so we are good here.


SSDT 15.3 on hosted VS2017 agent

Hi,
I have a hosted build on visualstudio.com for a solution that includes SSIS projects (.dtproj).
The build was working fine using the VS2015 hosted agent, but following the latest release of SSDT (and its support for SSIS projects in VS2017) I have migrated my solution to Visual Studio 2017, and modified my build definition to run on the VS2017 hosted agent.
The build is failing with the following error: The element <DeploymentModel> beneath element <Project> is unrecognized. referring to the .dtproj file.
I believe this is because the latest version of SSDT is not installed on the agent. Could you clarify if/when this may available?
If there is a long wait, are there any workarounds other than using a private agent? (e.g. ignore .dtproj files in the build - is this possible?)
Many thanks

Hi, i have similar issue with Agent queue Hosted 2017.
Myy script is using Devenev to build .ispac file from SSIS project (.dtproj)

C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\Common7\IDE\Devenv.com

and the result is:

The application which this project type is based on was not found. Please try this link for further information: https://go.microsoft.com/fwlink/?LinkId=660528&projecttype=159641D6-6404-4A2A-AE62-294DE0FE8301

It works fine on my on-premise build agent with SSDT for VS2017 installed.

Currently, SSDT version - Version: 14.0.16121.0 is installed on the VS2017 pools. https://github.com/adventworks/hosted-pool-images/blob/master/vs2017-on-windows-2016/image.md
Are you still facing issues?

Not an issue with the agent application (this repo)

Hi,
Apologies for the delayed response.
Thanks @saranad - I can see from the list of software installed that 14.0.16121.0 is installed, this post is all about when 15.3.0 is likely to be installed.
Thanks @bryanmacfarlane, however where should I raise this issue? SSDT 15.3 provides support for SSIS projects in Visual Studio 2017, however VSTS builds fail due to the outdated version of SSDT in the image. I understand this is not a bug with the agent per-say, but it is kippering those of use who have recently upgraded to SSDT 15.3/VS2017 and want to build our solutions on VSTS.
Please can you advise what the normal course of action is in this case?
For anyone who's come across this thread, the only workaround I've found so far (which is far from ideal) is to create a build configuration which ignores the SSIS projects and specify this configuration in the VSTS build. (Yuk!)


fix(sdk-metrics): InMemoryMetricExporter clear metrics after shutdown

Which problem is this PR solving?
Fixes #5131
Short description of the changes

make InMemoryMetricExporter reset storing metrics after shutdown

Type of change

[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)

The InMemoryExporter does not directly affect the functionality of this library, but I consider it a minor specification change for the library. In fact, I encountered this issue while using InMemoryExporter in another project. If there are tests that retrieve metrics after shutdown, they will fail.
How Has This Been Tested?

[x] should get no metrics after shutdown

Checklist:

[x] Followed the style guidelines of this project
[x] Unit tests have been added
[x] Documentation has been updated

@paper2
There are some conflicts in your PR and https://github.com/open-telemetry/opentelemetry-js/pull/5236 will be merged soon. I suggest you wait for it before dealing with the conflicts.


Support on-prem FOSSA servers

Hello,
We're currently using a self-hosted FOSSA instance connected to our self-hosted GitHub Enterprise server. This appears to break a number of assumptions this action makes regarding URLs and whether the GITHUB_TOKEN can be used to make API requests to github.com.
This prevents us from being able to use this action for our workflows, and we are instead defaulting to installing the raw CLI instead.

It's now supported with the latest v1 tag.


add initial Cargo.lock

Description of the changes
This PR adds a Cargo.lock file and removes the Cargo.lock entry from the .gitignore in order to make the build easier to reproduce
Type of change
Please select one or multiple of the following options:

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Code cleanup (refactoring or improving code quality)
[ ] Documentation update (adding or updating documentation, updating README)

Checklist:

[X] I have read the CONTRIBUTING document.
[X] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[X] All new and existing tests passed.

Additional information
Add any other information or screenshots about the pull request here.

Hi @jpetrucciani, thank you for your contribution!


Add to Parse-Server Repo

By googling I came into this repo, Parse-Server is now open source , do you have any plan to add this repo on there, I believe It will be great thing to do. Thanks

See #141


Challenge 20: Typo/Grammer

...same UI everytime it receives...

This is actually two words: every time.

...one of React's important design principle: React is declarative...

principle should be plural here.

...It does this in a predicatable way...

predicatable -> predictable

...component as a child, however this Camper component...

This is a comma splice and should be split by a period.

component as a child. However, this Camper component

nice got it!


where can i find documentation for parameters in workbook

Hello,
i just found this sample somewhere
const worksheet = XLSX.utils.json_to_sheet(data.Records);
const workbook = {
Sheets:{
'data':worksheet
},
SheetNames: ['data']
};
const excelBuffer = XLSX.write(workbook,{bookType:'xlsx',type:'array'});

where can i find documention witch parameters are posible in the workbook structur ?
thanks

https://github.com/SheetJS/sheetjs/blob/master/dist/xlsx.js#L2049

README covers it: https://docs.sheetjs.com/#common-spreadsheet-format
You can also look at the typescript type definitions: https://unpkg.com/xlsx/types/index.d.ts


Unable to find package lua-resty-url

Hello I tried installing your repo with opm but I get the folloing error:
$ opm get 3scale/lua-resty-url
* Fetching 3scale/lua-resty-url
ERROR: failed to find package 3scale/lua-resty-url: package lua-resty-url not found under account 3scale.

Any suggestions?

It's on Luarocks https://luarocks.org/modules/3scale/lua-resty-url , but it has not been published on opm.
@mikz Should we upload this library to opm too?

The file is there: https://github.com/3scale/lua-resty-url/blob/4710562caaeb71d86a00b9c14ab546bc1b6ce0f3/dist.ini
I just never got to publish it I guess. Will try.

@siozosdr no need. Thanks for reporting. 0.3.3 is now on http://opm.openresty.org.
Feel free to reopen if it does not work for you.


Show navic in lualine

Plugin affected: navic
Nixpkgs channel: unstable
Home-manager version: N/A
Description
I'm not sure if this is a bug or if I'm just doing something wrong, but I am trying to add the nvim-navic plugin that the Nixvim navic plugin config corresponds to, and though I have it enabled, I can't seem to get it to show up in the lualine. I have tried a few different ways which is shown in the relevant config below, but can't seem to get it to show up.
Does the plugin require a specific LSP configuration in order to show? Or am I just doing something wrong? Thanks in advance for any pointers or guidance...!
Config
# option 1
plugins = {
  lualine = {
    lualine_a = ["branch" "diff" "diagnostics"];
    lualine_b = ["filename" "navic"];
  };
};

# option 2
plugins = {
  lualine = {
    lualine_a = ["branch" "diff" "diagnostics"];
    lualine_b = ["filename" "nvim-navic"];
  };
};

#option 3
plugins = {
  lualine = {
    lualine_a = ["branch" "diff" "diagnostics"];
    lualine_b = ["filename" "require('nvim-navic').get_location()"];
  };
};

EDIT: Here is the relevant navic config as well:
plugins = {
  navic = {
    enable = true;
    highlight = true;
    lsp.autoAttach = true;
  };
};

Hey !
It doesn't seem to me like you missed anything...
Do you get an error or it just silently doesn't show up ?
Here are some example of how you cna configure navic in lualine: https://github.com/SmiteshP/nvim-navic#lualine

Hey ! It doesn't seem to me like you missed anything... Do you get an error or it just silently doesn't show up ?
Here are some example of how you cna configure navic in lualine: https://github.com/SmiteshP/nvim-navic#lualine

Hey, nope no errors at all. There is just nothing that shows up in the status line. And yep, the examples from the author's plugin page is what I was going off of, but I wasn't sure if Nixvim has different requirements or specific tooling in regards to a plugin like this.

Hey, nope no errors at all. There is just nothing that shows up in the status line. And yep, the examples from the author's plugin page is what I was going off of, but I wasn't sure if Nixvim has different requirements or specific tooling in regards to a plugin like this.

When you add plugins.navic.enable = true, we are not doing anything magical other than:

Installing the nvim-navic plugin.
Calling require('navic-nvim').setup({<EVENTUAL_OPTIONS>}).

At this point, using the plugin anywhere else in your config should be possible.
Can you try to run in command mode :lua require('nvim-navic').get_location() ?

Hey, nope no errors at all. There is just nothing that shows up in the status line. And yep, the examples from the author's plugin page is what I was going off of, but I wasn't sure if Nixvim has different requirements or specific tooling in regards to a plugin like this.

When you add plugins.navic.enable = true, we are not doing anything magical other than:
* Installing the `nvim-navic` plugin.

* Calling `require('navic-nvim').setup({<EVENTUAL_OPTIONS>})`.

At this point, using the plugin anywhere else in your config should be possible.
Can you try to run in command mode :lua require('nvim-navic').get_location() ?

Hmm, odd that it isn't showing then. Running the above snippet in command mode yielded nothing. There were no errors, but also no output nor feedback of any kind. Now I'm even more stumped....

Hmm, odd that it isn't showing then. Running the above snippet in command mode yielded nothing. There were no errors, but also no output nor feedback of any kind. Now I'm even more stumped....

Well, is this function supposed to print/return anything ?

Hmm, odd that it isn't showing then. Running the above snippet in command mode yielded nothing. There were no errors, but also no output nor feedback of any kind. Now I'm even more stumped....

Well, is this function supposed to print/return anything ?

According to the plugin page:
Returns a pretty string with context information

But that's a good question, I'm actually unsure if said pretty string (which is presumably the current cursor location) would be printed out in the immediate user-facing UI. But technically yes, it is supposed to return something. Is it possible that there are additional requirements to capture the returned string, and then print/show it? I'm not really a Lua expert, and am brand new to Nixvim...

Ok, I looked a bit more in depth.
It is supposed to get its information thanks to a running LSP.
For this, its needs to be attached.
I have seen that you have enabled lsp.autoAttach, which is good.
When you are testing, are you sure that you have some language server running ? (:LspInfo)
Also, you can look in the generated init.lua and look if the on_attach function of your registered LS is calling require('navic-nvim').

Ok, I looked a bit more in depth. It is supposed to get its information thanks to a running LSP. For this, its needs to be attached.
I have seen that you have enabled lsp.autoAttach, which is good. When you are testing, are you sure that you have some language server running ? (:LspInfo) Also, you can look in the generated init.lua and look if the on_attach function of your registered LS is calling require('navic-nvim').

Got it working! I removed the LSP config logic and rebuilt, then added it back and rebuilt, and all seems well now. Many thanks for your help and quick replies, will close this one!

Got it working! I removed the LSP config logic and rebuilt, then added it back and rebuilt, and all seems well now. Many thanks for your help and quick replies, will close this one!

Great !
You're welcome :)


[eph] Skip EPH samples from smoke-test runs

/cc @richardpark-msft
Disables EPH samples from running as part of the automated smoke test runs. EPH functionality has been replaced by the @azure/event-hubs v5 package.

/azp run js - smoke-tests

/azp run js - smoke-tests

Overriding check-enforcer because this PR only fixes EPH smoke testing.

Overriding check-enforcer because this PR only fixes EPH smoke testing.

/check-enforcer override

/check-enforcer override


New version: aquaproj.aqua 2.26.0

Checklist for Pull Requests

[x] Have you signed the Contributor License Agreement?
[x] Is there a linked Issue?

Manifests

[x] Have you checked that there aren't other open pull requests for the same manifest update/change?
[x] This PR only modifies one (1) manifest
[x] Have you validated your manifest locally with winget validate --manifest <path>?

[x] Does your manifest conform to the 1.6 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Automated with GoReleaser
Microsoft Reviewers: Open in CodeFlow

Hi @suzuki-shunsuke,
The package didn't pass a Defender or similar security scan. This might be a false positive and we can rescan tomorrow.
(Automated response - build 876.)

Automatic Validation ended with:

Installation failed with exit code -1978335187
2024-04-05 05:33:11.028 [FAIL] Installer failed security check. Url: https://github.com/aquaproj/aqua/releases/download/v2.26.0/aqua_windows_amd64.zip Result: 0x80004005

(Automated response - build 876.)

@wingetbot run


Quotes in $(boot2docker shellinit) output on Windows result in "Couldn't read ca cert" error

In #356, single quotes were added around the value assigned to DOCKER_CERT_PATH on Windows.
This results in output like:
[~/src]$ boot2docker shellinit
Writing C:\Users\Ed\.boot2docker\certs\boot2docker-vm\ca.pem
Writing C:\Users\Ed\.boot2docker\certs\boot2docker-vm\cert.pem
Writing C:\Users\Ed\.boot2docker\certs\boot2docker-vm\key.pem
    export DOCKER_TLS_VERIFY=1
    export DOCKER_HOST=tcp://<IP_ADDRESS>:2376
    export DOCKER_CERT_PATH='C:\Users\Ed\.boot2docker\certs\boot2docker-vm'

Copying and pasting the export lines above and running them by hand (or adding to .profile) works fine.
However when using $(boot2docker shellinit) the quotes actually end up in the value assigned to DOCKER_CERT_PATH, which causes an error when trying to use Docker. eg:
[~/src]$ $(boot2docker shellinit)
Writing C:\Users\Ed\.boot2docker\certs\boot2docker-vm\ca.pem
Writing C:\Users\Ed\.boot2docker\certs\boot2docker-vm\cert.pem
Writing C:\Users\Ed\.boot2docker\certs\boot2docker-vm\key.pem
[~/src]$ echo $DOCKER_CERT_PATH
'C:\Users\Ed\.boot2docker\certs\boot2docker-vm'
[~/src]$ docker ps
FATA[0000] Couldn't read ca cert 'C:\Users\Ed\.boot2docker\certs\boot2docker-vm'\ca.pem: open 'C:\Users\Ed\.boot2docker\certs\boot2docker-vm'\ca.pem: The filename, directory name, or volume label syntax is incorrect.

Which leaves a bit of a dilemma: If shellinit doesn't output the quotes, then the manual method breaks, if it does output the quotes, then the $(boot2docker shellinit) method breaks.
It seems the only way to get a value that works for both, is to remove the quotes, and replace all backslashes with double backslashes, eg:
[~/src]$ $(boot2docker shellinit | sed -e s_\'__g -e 's_\\_\\\\_g')
Writing C:\Users\Ed\.boot2docker\certs\boot2docker-vm\ca.pem
Writing C:\Users\Ed\.boot2docker\certs\boot2docker-vm\cert.pem
Writing C:\Users\Ed\.boot2docker\certs\boot2docker-vm\key.pem
[~/src]$ echo $DOCKER_CERT_PATH
C:\\Users\\Ed\\.boot2docker\\certs\\boot2docker-vm
[~/src]$ docker ps
CONTAINER ID        IMAGE               COMMAND             CREATED             STATUS              PORTS
NAMES

[~/src]$ boot2docker shellinit | sed -e s_\'__g -e 's_\\_\\\\_g'
Writing C:\Users\Ed\.boot2docker\certs\boot2docker-vm\ca.pem
Writing C:\Users\Ed\.boot2docker\certs\boot2docker-vm\cert.pem
Writing C:\Users\Ed\.boot2docker\certs\boot2docker-vm\key.pem
    export DOCKER_HOST=tcp://<IP_ADDRESS>:2376
    export DOCKER_CERT_PATH=C:\\Users\\Ed\\.boot2docker\\certs\\boot2docker-vm
    export DOCKER_TLS_VERIFY=1
[~/src]$ export DOCKER_CERT_PATH=C:\\Users\\Ed\\.boot2docker\\certs\\boot2docker-vm
[~/src]$ echo $DOCKER_CERT_PATH
C:\Users\Ed\.boot2docker\certs\boot2docker-vm
[~/src]$ docker ps
CONTAINER ID        IMAGE               COMMAND             CREATED             STATUS              PORTS
NAMES

If we do make this change, we'll also need to adjust start.sh in the Windows installer, since it tries to compensate for this already (cc @SvenDowideit), so we'd double up:
https://github.com/boot2docker/windows-installer/blob/7bf811d592bddf0b71c534f652fc935f6b3f6914/start.sh#L30-L31

Ah, it seems like as of boot2docker/boot2docker#786 the new advice is to use:
eval "$(boot2docker shellinit)"
...instead, which fixes this and other issues.
Unfortunately the old form is used in a fair number of Stack overflow/how-to guides etc, plus I read the boot2docker readme before they made that change.
To make it clearer, perhaps we could output a use eval "$(boot2docker shellinit)"in the shellinit text (to stderr, like the "Writing foo" messages)?

(Hi again :))
Can you add some more information about the shell / environment you're running this in? (PowerShell, CMD.exe etc.). I know there have been quite some differences in behavior, depending on that.

I've updated a few more instances of the docs for related projects that were still recommending the old way:
docker/docker-py#633
docker/compose#1533


created NewClass form and NewClass validation

Created new class form
Created new class form validation

Looks good to me, feel free to merge and delete branch


Profiling cycle

Currently all profiles are gathered only 10s and this is hardcoded.
In pyroscope we see the same pattern while the sampling period is 113 Hz

I would have expected to see a full timeline with the 113 bars in the span of 1 second, rather than the average over 10s with a sample rate of 113 Hz.
Is this intended?

@drahnr I think yes. To be honest, I'm not quite sure what these bars mean. @petethepig might help here?

@drahnr Yeah, this is intended. The idea with the timeline is that it gives you an idea of where CPU time was spent. For example, on the screenshot you linked the second bar is little higher — that means CPU was a little more active at that point.
This is due to the fact that when we upload data to pyroscope we aggregate all samples in 10-second intervals and as a result lose some precision.

My expectation was, that the data sampled is compressed, but not coalesced. The backend does provide the same functionality already, so I don't see the rationale to do this.
For our use case, CPU usage highly depends on a certain stage, so a sample period of 10 seconds is significantly too long to see meaningful data.
For all async based rust projects, this will show the executor and locking primitives as the main offenders, but that's not really helpful.

Issue moved to pyroscope-io/pyroscope #900 via ZenHub


fetch_access_token! requires an explicit redirect_uri option when 'postmessage' would work as a default

The Problem
We are trying to implement the Google Oauth2 flow using a separate client application and backend api as described in these docs on the Google Developer site. In the python library in the example code, the redirect_uri in step 7 defaults to 'postmessage' to enable sending the request from code and match the redirect_uri that was already provided by the client. When we were sending the request initially, we were getting:
*** Signet::AuthorizationError Exception: Authorization failed.  Server message:
{
  "error": "redirect_uri_mismatch",
  "error_description": "Bad Request"
}

The client code looks something like this:
    client = Signet::OAuth2::Client.new(
      :authorization_uri => 'https://accounts.google.com/o/oauth2/auth',
      :token_credential_uri =>  'https://oauth2.googleapis.com/token',
      :client_id => ENV["GOOGLE_CLIENT_ID"],
      :client_secret => ENV["GOOGLE_CLIENT_SECRET"],
      :scope => 'email profile',
      :redirect_uri => ENV["GOOGLE_CLIENT_REDIRECT_URI"]
    )

    client.code = code
    client.fetch_access_token!

When we removed the redirect uri, we got:
*** Signet::AuthorizationError Exception: Authorization failed.  Server message:
{
  "error": "unsupported_grant_type",
  "error_description": "Invalid grant_type: "
}

Describe the solution you'd like
In the example used by the python library, 'postmessage' is the default value for the redirect_uri that's assigned if one is not provided. I think that would be a good addition here as it would allow the fetch_access_token! method to be called from our ruby code without needing to specify the redirect_uri again (as it's not relevant at this point anyway, since we don't want to trigger a redirect with this code)
Describe alternatives you've considered
In lib/signet/oauth2/client.rb
      def initialize options = {}
        @authorization_uri    = nil
        @token_credential_uri = nil
        @client_id            = nil
        @client_secret        = nil
        @code                 = nil
        @expires_at           = nil
        @issued_at            = nil
        @issuer               = nil
        @password             = nil
        @principal            = nil
        @redirect_uri         = 'postmessage'
        @scope                = nil
        @target_audience      = nil
        @state                = nil
        @username             = nil
        @access_type          = nil
        update! options
      end

Maybe there's a better place to put this, but it seems like this would fix the problem. Not sure if this causes other problems that we're not aware of.
For now our fix was to do this when initializing the content:
client = Signet::OAuth2::Client.new(
  :authorization_uri => 'https://accounts.google.com/o/oauth2/auth',
  :token_credential_uri =>  'https://oauth2.googleapis.com/token',
  :client_id => ENV["GOOGLE_CLIENT_ID"],
  :client_secret => ENV["GOOGLE_CLIENT_SECRET"],
  :scope => 'email profile',
  :redirect_uri => 'postmessage'
)

client.code = code
client.fetch_access_token!

Hi @DakotaLMartinez
Apologies it took us so long to respond back to this.
I think that's not the case anymore with Python as well. Also, I couldn't find that in official document too. Can you please point me to the place where this happens? May be I'm missing something.

Closing this due to inactivity. Please feel free to reopen it if the issue still persists.


[ADD]: CABLE MAZE GAME 👾

PR Description 📜

This PR is about adding Cable Maze game

Fixes #968

Mark the task you have completed ✅

[x] I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
[x] I have performed a self-review of my own code or work.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] My changes generates no new warnings.
[x] I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
[x] I have added screenshot for website preview in assets/images
[x] I have added entries for my game in main README.md
[x] I have added README.md in my folder
[x] I have added working video of the game in README.md (optional)
[x] I have specified the respective issue number for which I have requested the new game.

Screenshots 📸

Working Video 📹
https://github.com/kunjgit/GameZone/assets/92252895/15b2d522-eb4d-4ec0-b2c5-c1f5086f3780

Thank you soo much for contributing to our repository 💗

Thank you @0xabdulkhalid ,for creating the PR and contributing to our GameZone 💗
Review team will review the PR and will reach out to you soon! 😇
Make sure that you have marked all the tasks that you are done with ✅.
Thank you for your patience! 😀

Thank you  @0xabdulkhalid , for your valuable time and contribution in our GameZone 💗.
It’s our GameZone, so Let’s build this GameZone altogether !!🤝
Hoping to see you soon with another PR again 😇
Wishing you all the best for your journey into Open Source🚀

Hey @0xabdulkhalid,
You can't work on a closed issue 👀!
Follow the proper guideline and make a new PR again 😀.
Happy Hacking 💗


core/src/utils.rs:  Make TinkError Send

We have a use case where we're using tink in an async tonic service; with TinkError being !Send, we're unable to include it in our own error types and pass it around
Nothing in the tink-rust repo fails to build by adding this bound, but let me know if anything else requires testing

Possible to rerun that check?  I signed the CLA a moment ago

@conradgrobler : any concerns from the Oak side?


[0.7-M4] Inserting text via user keyboard input inserts text in reverse order because caret position doesn't advance forward after input

Replicate

Run the Java Keywords demo
Start typing

Expected Results
The caret advances with each character typed.
Actual Results
The caret retains its position, which causes the typed text to be entered backwards.

I'm guessing you're using the new 0.7-M4 release? That's probably a bug from #468. :-/

Nope. I was wrong. The bug start showing up in #463. After I moved the model-API to ESD, every time one types a letter, it moves the caret to the right twice so that the caret is one character farther than it should be. After I moved the view API to the area, the behavior reverted to what @DaveJarvis just now described in this issue.

Correct, this is in the 0.7-M4 release. 0.7-M3 worked as expected.

I've updated the release notes to note this issue.

@TomasMikula Would it be possible to re-release the 0.7-M4 release using the updated master branch that accounts for this issue? Or would this require another release?

Just fixed it. Dave, could you try it out to insure there are no other
regressions?
Although I already tagged you in the issue, is it possible, Tomas, to
re-release the 0.7-M4 release with the current master branch? Or does this
require a new release?
Blessings,
Jordan
On Mon, Mar 27, 2017 at 11:50 PM, Dave Jarvis<EMAIL_ADDRESS>wrote:

Correct, this is in the 0.7-M4 release. 0.7-M3 worked as expected.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/TomasMikula/RichTextFX/issues/472#issuecomment-289679637,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AIBfbV8rBsp3VuyunKz6yXKXVdXL6glwks5rqK2tgaJpZM4MrFxc
.

@JordanMartinez, once the new release is available, I'll try it out.
I'd suggest making a new release, 0.7-M5. (Mostly to avoid caching issues.)

I pushed a new SNAPSHOT release, can you try that out?
I think it used to be possible to override a release, but yeah, there can be caching issues.

:-/ Dang...

SNAPSHOT release has resolved this issue.

Can a new milestone release be made then?
@TomasMikula Besides the bugs and dependency bugs tagged in this project's list of issues, is there anything else that needs to be done before a stable 0.7 release can be made?

It is possible to fix this regression in the 0.7-M4 release by overriding the replace method like so:
public void replace(int from, int to, StyledDocument<PS, SEG, S> document) {
    super.replace(from, to, document);
    int newCaretPos = getCaretPosition() + document.length();
    selectRange(newCaretPos, newCaretPos);
}

Released 0.7-M5. As for 0.7, I don't know, mainly be it more stable, API-wise and bug-wise.

Ok. Bug-wise, there's 2 RTFX-specific bugs that can be fixed somewhat quickly (#423 & #362). I'm not sure what is causing the problem with #265 and I can't test (and thus fix) it because I don't use/have a Mac. Then there's the Flowless-related bugs (#412, #390, and probably #260).
How could the API be made more stable?


Default Domain Admin role not working after migration

ISSUE TYPE

Bug Report

COMPONENT NAME

Mangement Server

CLOUDSTACK VERSION
4.18.0

CONFIGURATION

OS / ENVIRONMENT
CentOS 7 / MariaDB 10.6
SUMMARY
After migrating to dynamic roles with migrate-dynamicroles.py and upgrading from 4.11 to 4.18, domain admins can no longer log in or use the API.
STEPS TO REPRODUCE

Use and migrate an Apache Cloudstack installation since 2013 until at <IP_ADDRESS>.
Migrate to dynamic roles with /usr/share/cloudstack-common/scripts/util/migrate-dynamicroles.py -H localhost -b cloud -u cloud -p xxxx -D and moving command.properties out of the way

EXPECTED RESULTS
Domain account users to continue to work as before.

ACTUAL RESULTS
Top level root admin works fine.
But domain admin or other users do not:
Logging in to the UI gets stuck at "Discovering features...".
using the API results in messages like
2023-09-06 09:43:41,659 DEBUG [c.c.a.ApiServlet] (qtp1444635922-1285:ctx-d0c978ae) (logid:bff1f438) ===START===  <IP_ADDRESS> -- GET  name=cdskl-shared&command=listServiceOfferings&apiKey=XXXX
2023-09-06 09:43:41,664 DEBUG [c.c.a.ApiServer] (qtp1444635922-1285:ctx-d0c978ae ctx-eefbdbcf) (logid:bff1f438) CIDRs from which account 'Account [{"accountName":"admin","id":39,"uuid":"813308c2-8405-46c3-aa09-0e6bbd90e3b1"}]' is allowed to perform API calls: <IP_ADDRESS>/0,::/0
2023-09-06 09:43:41,666 DEBUG [c.c.a.ApiServer] (qtp1444635922-1285:ctx-d0c978ae ctx-eefbdbcf) (logid:bff1f438) The API [listServiceOfferings] does not exist or is not available for the account Account [{"accountName":"admin","id":39,"uuid":"813308c2-8405-46c3-aa09-0e6bbd90e3b1"}].
2023-09-06 09:43:41,667 DEBUG [c.c.a.ApiServlet] (qtp1444635922-1285:ctx-d0c978ae ctx-eefbdbcf) (logid:bff1f438) ===END===  <IP_ADDRESS> -- GET  name=cdskl-shared&command=listServiceOfferings&apiKey=XXXX

Additional info
The UI does not allow me to add permissions to the default roles. But by adding a specific permission to the database manually makes that API function work for domain admins, e.g.:
INSERT INTO `cloud`.`role_permissions` (`uuid`, `role_id`, `rule`, `permission`, `description`) VALUES ('8890d77e-c77a-4df1-a5f6-6af1dd52ac0c ', 3, 'listVirtualMachines', 'ALLOW', 'Test');

Reading the migration Python script source code, using "-D" for "use default rules" does only enable the dynamic rule checker option, but does sys.exit(0) directly after that. It does not insert any default rules into the database.
I suspect that this might work for a fresh installation, where the installation process might fill the role_permissions table with what is necessary, but that is missing here.

Luckily, wildcards do work, so this is a workaround:
INSERT INTO `role_permissions` (`id`, `uuid`, `role_id`, `rule`, `permission`, `description`, `sort_order`) VALUES (971, '8890d77e-4c07-11ee-bcb6-7eaeea291d34', 3, '*', 'ALLOW', 'Workaround', 0);

But I am not sure if this gives more permissions than "Domain Admin" should normally have. As this is an internal single-tenant installation, there's no risk for now.

@MartinEmrich , one clarification please; you upgraded to 4.18 and then ran the migrate-dynamicroles.py script?

I ran the script before the upgrade (with the -D option, as I never edited my command.properties), but also multiple times after the upgrade in an attempt to get it to work.

ok, I'll try to reproduce in a lab env

Not sure if I reproduced your issue @MartinEmrich , but on installing a 4.11 env, dynamic.apichecker.enabled is true by default. When I set it to false login fails even as root-admin. setting it back to true login succeeds again. Can you check that?

@DaanHoogland Sorry, this is an internal production system, and the update to 4.18 is now >2 weeks ago, so restoring a backup to try again is not an option.
But that installation ist reeeeally old... Skimming thorugh my mail archive, it could possibly have started with ACS 4.5.2 or even older, and then upgraded to 4.6.0, 4.6.1, 4.7.0,  4.7.1, 4.8.0, <IP_ADDRESS>,  <IP_ADDRESS> and now finally 4.18.
Here and there, I had do use my own pre-release builds to get blocking bug fixes early, that might even have caused more database inconsistencies (even now, I have to run a homegrown <IP_ADDRESS> prerelease to get a bugfix early).
I guess the dynamic roles mode expects some database entries that a fresh <IP_ADDRESS> (and 4.18.0) installation provide, but which never happened during our eventful upgrade history.
If there is no readily apparent fix possible, I would totally understand if you would close this as "can't reproduce"... I just wonder what I should put into the database to get the "official out-of-the-box configuration".

I can give you a dump of the role and role permission tables of a stock lab environment, but other than that, yes, I think closing is the most expedient course of action ;)

If you already have one at hand, that would be great... Saves me from setting up a fresh VM.
Sounds like a plan!

role.zip
here you go. A bit inconvenient maybe for the uuids, (and the 'bla'-role) but easy to manipulate if you wish.
closing the issue.


[branch-2.9] Rename test file name from *Test2.java to *Test.java to run all tests correctly

cherry-pick: https://github.com/apache/pulsar/pull/13644
Motivation
It seems some test cases like **/*Test2.java aren't run on the default test lifecycle.
This issue is caused by https://github.com/apache/pulsar/pull/10148. I'd like to fix it.
Modifications
Originally:

Rename test file name to **/*Test.java
Fix some codes to follow changes

https://github.com/apache/pulsar/pull/12687
https://github.com/apache/pulsar/pull/11693
https://github.com/apache/pulsar/pull/12663
https://github.com/apache/pulsar/pull/12749
https://github.com/apache/pulsar/pull/11640

Additionally:

Fix conflict and keep existing changes

https://github.com/apache/pulsar/pull/14657/files#diff-8696b1e2ba4ee355256e31b33ccc4f1cab77f1c6c79f7b4ab508b73d43d8ad55L477-R471

Revert some codes because the change is not cherry-picked to branch-2.9 yet

https://github.com/apache/pulsar/pull/12687

Cherry-picked additional changes about test code because existing cherry-pick commit is imcomplete

existing cherry-pick commit: https://github.com/apache/pulsar/commit/4f65f65c6fe6f7e97e83a13d038c6dbf28c3f8c6
original commit: https://github.com/apache/pulsar/commit/ecd275dc21f33483a649e5b872990771257b1d45

Verifying this change

[ ] Make sure that the change passes the CI checks.

This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API: (no)
The schema: (no)
The default values of configurations: (no)
The wire protocol: (no)
The rest endpoints: (no)
The admin cli options: (no)
Anything that affects deployment: (no)

Documentation

[x] no-need-doc

/pulsarbot run-failure-checks


limiting gradle deamon instances

why there is no gradle config property to limit a daemons creation
(allowing to limit max working/avail/idle/incompatible instances)
eg i dont want to start new daemon if there are some incompatible or busy one !!!
example implementation for the issue:
// limit global daemon creation

daemon.instances.max=xx (running +  idle)
// limit on each state daemon creation
daemon.instances.max.running=xx
daemon.instances.max.incompatible=xx

// to auto stop idle / incompatible
// if above counters are reached
// to allow create new (compatible) instance
4) daemon.instances.max.stop=true
// we cant create new instance then inform user
-- on limit reached (for max running)
-- or when stop flag is not set and we cant self / stop & make new one
or provide a some sort of que for each gradle call

Why was this issue closed? I think this would be great to have as an opt-in feature on low memory devices. Especially on Android builds where you typically need to assign at least 4GB of memory due to lint and dexing. I'd rather not have new daemons started automatically when the current one is either busy or incompatible


[YUNIKORN-428] Reduce the warning logs in resources.go

Reduced the log level from WARN to INFO

Hey @adamantal,
Your changes look good to me!
View build log
TravisBuddy Request Identifier: 324a2ca0-071d-11eb-ae86-23b548ca2017

Thanks for the review.
I think it still worth to display the information about the missing resource, but I also agree that this log is too much.
I made it DEBUG level, and only display one aggregated log about the every resource that we're missing information about. I hope you will agree with this resolution.

Travis tests have failed
Hey @adamantal,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.
1st Build
View build log

     curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v1.22.2

golangci/golangci-lint info checking GitHub for tag 'v1.22.2'
golangci/golangci-lint info found version: 1.22.2 for v1.22.2/linux/amd64
golangci/golangci-lint info installed /home/travis/gopath/bin/golangci-lint

     make lint

running golangci-lint
pkg/common/resources/resources.go:767: File is not `gofmt`-ed with `-s` (gofmt)
	missingResources :=  make([]string, 0)
Makefile:45: recipe for target 'lint' failed
make: *** [lint] Error 1

TravisBuddy Request Identifier: 60ea2f20-089d-11eb-9b15-83942378e0dd

Hey @adamantal,
Your changes look good to me!
View build log
TravisBuddy Request Identifier: c6f9a2c0-08af-11eb-9b15-83942378e0dd

I made it DEBUG level, and only display one aggregated log about the every resource that we're missing information about. I hope you will agree with this resolution.

OK, I think this is fine. Thanks!


Feature: Has register command MOVE_TO* in rich text module

I need a easy way to control caret.

register MOVE_TO_START and MOVE_TO_END in rich text module.
INSERT_PARAGRAPH_COMMAND has parameter to switch splitting the line or appending the line and inserting line before.

Here is my situation.I got a slash keyword to show a dropdown manu, just like notion.so, I input a '/' char, select the menu by pressing enter key to change the element node (from paragraph to heading for example).
The problem is when I input a '/' char in middle of paragraph node, what I want is create a paragraph node after this node.
But

the INSERT_PARAGRAPH_COMMAND will split the paragraph node.If it has a parameter to switch split the line or append the line and insert line before, it would be better.
While the INSERT_PARAGRAPH_COMMAND only split the paragraph node, so I need control caret MOVE_TO_END, and then run the INSERT_PARAGRAPH_COMMAND.

Pleasure to contribute code
If my needs can be accepted, I would love to contribute code.

The slash command is in the works :rocket: #2534

You should be able to just call selectStart or selectEnd on the root node to achieve the above without adding in custom commands.


Does vscode work on ipad pro support?

With ipad pro 2021 use m1 cpu. Does vscode work on ipad pro support? if possible,so great!

VSCode runs on Electron, but Apple doesn't approve of the application using Electron.

Apple Is Trying to Kill Web Technology

Apple claims that the iPad is a huge productivity tool, but for developers, it's like an AK47 that can't fire bullets. So sad.

Electron is a product of a time wherein built-in support for various web technologies was severely splintered. It was mid-2013—Microsoft would go on to release Internet Explorer 11 merely three months later. It was much easier to bundle up Chromium with your application than to require users to download a different browser to run the application because it provided a better user experience.

So? Browser programming is the trend of future development? @RA80533

Dup of https://www.github.com/microsoft/vscode/issues/70764


Update UG for command format, edit and clear

Codecov Report

Merging #200 (34ba0a1) into master (633a3ba) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #200   +/-   ##
=========================================
  Coverage     50.58%   50.58%
  Complexity      354      354
=========================================
  Files            80       80
  Lines          1542     1542
  Branches        181      181
=========================================
  Hits            780      780
  Misses          679      679
  Partials         83       83

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 633a3ba...34ba0a1. Read the comment docs.


Implement From trait between Address and String

Currently Address has two methods doing exact this. Implementing the trait From in both directions may improve the struct's ergonomics.

Hi! I'm considering working on this. There are several possibilities and wanted to clarify first:
(not super experienced with Rust, apologize for possible oversights)

TryFrom trait (since it can fail): this seems to require a bit awkward syntax when passing String, e.g:

Address::from_str(&*gen_response.address)
// or
(&*gen_response.address).try_into()

FromStr trait:

Address::from_str(&gen_response.address)
// or
gen_response.address.parse::<Address>()?

To convert to string, we'd to implement the ToString trait.

Hi @i-schuetz ! I was thinking of this issue just yesterday, thanks for the analysis! In fact my doubt was the requirement for perfect conversion of the From trait and your solutions perfectly address the issue. I would go with the first option because I think that we will be using it especially with string slices and because the try_into feels cleaner than parse::<Address>. In theory we could implement both, but I think that is better to keep a single way of doing things whenever possible.  What do you think?

With parse actually we don't have to set the type, unless type inference doesn't work (which happens only in 2 places at the moment). Given this, I'm slightly in favor of it, as "parse" sounds a bit more accurate (and we don't need the &* syntax, which we'd need with TryInto`, also in 2 places). I'll open the PR with this. Can change it.


Disable volume RWX mode support

Description:
Disable csi driver volume RWX mode support since LH block device volume doesn't support real RWX mode, it was used just for live migration and data synchrinization.
Related Issue:
https://github.com/harvester/harvester/issues/2151

LGTM, and what about the second point in the https://github.com/harvester/harvester/issues/2151#issuecomment-1099498196?

We have already implemented the validation logic at https://github.com/harvester/harvester-csi-driver/blob/5700629c292bf005e3c5042553ee1fedc654e5e6/pkg/csi/controller_server.go#L351-L377


Jenkins Job Result has wrong return type

Currently JenkinsModelRun has the following property:
[XmlElement("result")]
public JenkinsTasksTestTestResult Result { get; set; }

At least on my build definitions, result shows up in the API as anyType
<xsd:element name="result" type="xsd:anyType" minOccurs="0"/>

I get a XmlNode array back from this, if I change the type to object
[XmlElement("result")]
public object Result { get; set; }

Is Result actually populated with JenkinsTasksTestTestResult  in your cases?
For example another anyType
<xsd:sequence>
  <xsd:element name="action" type="xsd:anyType" minOccurs="0" maxOccurs="unbounded"/>
</xsd:sequence>

This is mapped to object, which matches the schema:
[XmlElement("action")]
public object[] Actions { get; set; }

That's right the schema says xsd: anyType.
And an object [] implementation would be logical. An implementation like in JenkinsModelComputer only makes sense if really different classes are passed.
In my tests, however, only JenkinsTasksTestTestResult was passed at this point.
Therefore an implementation with object [] makes everything unnecessarily complicated.
If you saw a different return class, please inform me and describe how you got it.

I get an XmlNode[] with 1 entry with the status of the build as TEXT

My job has 3 steps: windows batch, powershell, windows batch.
For linux build it is one step "execute shell"

I need the value of the OuterXml property of the XmlNode class.

In XML this looks like <result>SUCCESS</result>
VS shows:

The whole XML is
<freeStyleBuild _class='hudson.model.FreeStyleBuild'>
    <action _class='hudson.model.ParametersAction'>
        <parameter _class='hudson.model.FileParameterValue'>
            <name>codearchive.zip</name>
        </parameter>
        <parameter _class='hudson.model.FileParameterValue'>
            <name>librariesRoot.zip</name>
        </parameter>
        <parameter _class='hudson.model.FileParameterValue'>
            <name>cmakescript.bat</name>
        </parameter>
        <parameter _class='hudson.model.FileParameterValue'>
            <name>modelCoreSrc.zip</name>
        </parameter>
    </action>
    <action _class='hudson.model.CauseAction'>
        <cause _class='hudson.model.Cause$UserIdCause'>
            <shortDescription>Started by user builduser</shortDescription>
            <userId>builduser</userId>
            <userName>builduser</userName>
        </cause>
    </action>
    <action></action>
    <action></action>
    <building>false</building>
    <displayName>#189</displayName>
    <duration>188738</duration>
    <estimatedDuration>181109</estimatedDuration>
    <fullDisplayName>build_win #189</fullDisplayName>
    <id>189</id>
    <keepLog>false</keepLog>
    <number>189</number>
    <queueId>100</queueId>
    <result>SUCCESS</result>
    <timestamp>1600411853680</timestamp>
    <url>...:8080/job/build_win/189/</url>
    <builtOn>winlokal</builtOn>
    <changeSet _class='hudson.scm.EmptyChangeLogSet'></changeSet>
</freeStyleBuild>

I'm finding the same issue as well.  I'm seeing a SUCCESS node show up in the org.jenkinsci.plugins.workflow.job.WorkflowRun implementation.  Maybe it is a bad schema definition by the Jenkins team to define it as anyType.

I also took a look at what it shows up as for a failed build.

I see the mapping of anyType to a specific class, but it looks like maybe it would be better left as a string value.

Fixed


API for navigation management in Dashboard 2.0

Shortly we'll be implementing a new Dashboard 2.0 section for managing storefront navigation menus. We need to make sure that the API that we have currently allow implementing this UI:

We already have some mutations to add menus and menu items, but I'm not sure if they allow convenient support for all the reordering and drag-drop features that this UI assumes (shape of the API should be discussed with @dominik-zeglen).
@patrys once suggested if we shouldn't keep the entire menu structure as JSON in the database, instead of MPTT models. In the old storefront, we serialize menus to JSON anyway and cache it in a request to save some database queries. We should do some research whether it is more convenient for us to fully migrate to JSON for menus or keep the current model. We have to remember that menus and menu items are translatable and we should support that.

The issue with menus in JSON is that the links doesn't take into account the language #3154. So we need to drop the language code from the URL before saving it to the db.

For reordering the menu items, we could pass the menu item IDs and their sort_order number. When the user saves, we send the new sorting orders and commit them.
mutation reorderMenu($menuID: ID!, $items: [ID]!, $order: [Int]!) {
  ...
}

Would this solution be responding to this issue?

After discussion we decided to do like this:
input MenuItemPosition {
  menuItemID: ID
  position: Int
}

mutation reorderMenu($menuID: ID!, $positions: [MenuItemPosition]!) {
  ...
}

And the below statement:

@patrys once suggested if we shouldn't keep the entire menu structure as JSON in the database, instead of MPTT models. In the old storefront, we serialize menus to JSON anyway and cache it in a request to save some database queries. We should do some research whether it is more convenient for us to fully migrate to JSON for menus or keep the current model. We have to remember that menus and menu items are translatable and we should support that.

Will be moved to another issue for further look and discussion.

During the implementation, we should also keep in my mind that we may implement the same feature to the categories' MPTT tree.
We should also approach the menu reorder in another way as we didn't take into account the fact that the menu is actually a nested list.
A solution would be to mutate one item at once, with its parent (optional) and it order:
input MenuItemPosition {
  parent: ID
  sortOrder: Int!
}

mutation reorderMenuItem(id: ID!, input: MenuItemPosition) {
  ...
}


Import Canvas grade book into OnTask

What do you think about adding in functionality to import the Canvas grade book directly into OnTask (similar to the SQL connections)?
========== Preamble ===========
Hey @abelardopardo,
Thanks for all your work with the Canvas integration - now that it's done, I noticed there was a dearth of "big" new features in the issue list, so I thought I would contribute one.
I think this would be a valuable feature - it would really help getting more instructors on board that don't really want to futz around with uploading files every few days. Having the data imported and refresh with just a click (or even better, automatically on a schedule), would also help out with making the process a little more automatic. You can then imagine instructors could schedule outgoing emails at the beginning of the term and students would get weekly updates/emails about their progress (of course this has other implications with the conditions and thresholds being updated).
I had a look at the roadmap and I didn't see anything about this, so I hesitate to hijack things if you have other plans already.
Perhaps @anthonysymons (who was also interested in Canvas integration) could chime in on whether that would be useful for institutions beyond just ours?
I know when @craigdsthompson made a proposal for Canvas implementation, he sketched out a solution - I am unfortunately not technically inclined enough to do that. But perhaps he or @andrew-gardener could indicate whether this is possible or practical?
Thanks,
Firas

Hi @firasm
Thanks for the insightful suggestion. I am not entirely familiar with the Canvas API and how easy is to get the Gradebook for a course, but the bulk of the Canvas integration (OAuth2 and token manipulation) is done, so it is probably not that complex. It would be great if the folks already runnign OnTask integrated with Canvas can just post here information (they may not feel comfortable tweaking the tool).
This is the path we followed for the Email integration. There were a few contributions both in the code and in text and we finally merged them in our current (Beta) version.
Anybody else out there wants to elaborate on the steps required for the Gradebook integration?
PS> The Roadmap is out of date, you are right. I'll push a new version in the following weeks with more realistic goals.

Can I bump this issue up?

Do you have any hints about the type of elements in Canvas that are visible through the API? More precisely, any idea on how to "download" that gradebook? In Blackboard, it can be downloaded to a CSV file. Anything similar in Canvas?
My first idea is to obtain a "List of assignments"
https://canvas.instructure.com/doc/api/assignments.html#method.assignments_api.index
and then traverse that list and get the submissions
https://canvas.instructure.com/doc/api/submissions.html#method.submissions_api.index
and then import the content into the workflow.
Any other ideas?

For collecting the grades you can instead use "List submissions for multiple assignments" with the grouped option
https://canvas.instructure.com/doc/api/submissions.html#method.submissions_api.for_students since it will map more easily into gradebook rows (you can then rather get the list of assignments to populate column headings or use include[]=assignment though including assignment will greatly increase the submission query size)

Hi Abelardo,
Will need to talk to the rest of the team about your ideas, as I haven't looked into the API at all.
I can answer your question about exporting the grade book: yes, it can be done (see image) but I don't believe there is an API that can access it directly.

My understanding is that there isn't a direct concept of a grade book behind the scenes in Canvas. The grade book is constructed through the UI based on the submissions. I believe Andrew's method is a good way to go to retrieve the data.

@andrew-gardener is correct, this is the best way to get all the submissions for a single assignment within the gradebook.  Note that the response will be paginated and a user may have multiple submissions for a single assignment and these may have individual grades for each submission so you will need to parse the list and get the latest one.

Just wanted to check on the status of this issue and whether there is any interest in exploring this further?

Hi Firas.
So far we have not made any progress with this. At the moment we don't have partners using Canvas that are engaged in contributing code to the tool. If you think you can provide some inroads, go ahead.

Note from meeting with Abelardo on March 28th on 2023

@firasm will look at the Canvas API to see what possible calls we can do to build a Gradebook
@abelardopardo think/sketch about a process - maybe this can be a data source (similar to google, SQL, etc...)
Think about adding some protections when using gradebook sync (maybe we can restrict rows and not columns)


View all pages for the creator

Issue
Non-published pages I created are not listed even in my user page, and it makes it me difficult to find them.
Solution
List all pages for their creator.

Thank you so much!


Fix access specifier issue causing build failure

didMoveRow property in Source is unavailable from other modules, because it has default access specifier. Made it public.

@bhargavg thx!