Don't think it's working anymore

The network box size appears the same, and there's no List of commits button.

Oops. my mistake, I didn't fully install it in Tampermonkey, UI comprehension fail!


support grpc-js

Creating this issue for tracking purposes.
Since we (client libraries) are planning to move from grpc to @grpc/grpc-js, grpc-gcp must start supporting @grpc/grpc-js. @WeiranFang this is likely for you :)

Thanks. I will work on this once we have the new package @types/grpc. Link to proposal for this new package: https://github.com/grpc/proposal/pull/126

Just to give priority - this is going to block us from using grpc-js in the spanner library.  This is kinda P1-ish.

@murgatroid99  do we have a timeline on @types/grpc?

@alexander-fenster grpc-gcp (new release v0.3.0) is now supporting grpc-js.


New Elasticsearch 5 sink

This PR adds a new Elasticsearch 5 with the new elastic.v5 library, keeping the existence of the old one with the elastic.v3 library.
Also, in this 'new' sink (but not so different as the old one, as it's almost a copy with some changes of that) changes the behaviour of timestamps, creating only a 'MetricsTimestamp' field instead of a per metric type timestamp (like CpuMetricsTimestamp, GeneralMetricsTimestamp).
This was necessary so we can use Kibana as a dashboard to those metrics in the future.
This is related to the issue #1410  and also an improvement of the previous PR #1443
Hope this helps, and appreciate feedbacks :)

This change is

OK, so this is strange. The Build failed because a file I haven't changed. And 'make test-unit' passed here, in my environment.
Gonna try again tomorrow to see what happened.

ping @AlmogBaku @DirectXMan12 I think this is the final one :)

@rikatz Can't we achieve the same without duplicating the whole packages? that's why there are interfaces...

also, it's not clear to me why have you duplicated also the drivers which are using the exact same code

@AlmogBaku I'm not a good golang developer (just trying to make this happen), so actually don't know how to implement this other way :)
Gonna study some options to do this, but will need some help :)

Ok, i've created a prototype that works with my approach.. I'll test it later (hope tomorrow)

@AlmogBaku Thanks :) maybe I can learn some stuffs from your prototype!

Damn, i'm really struggling with this godep. That's stopping me now from sending the PR
ahm #1314 @piosz

@AlmogBaku I understand you... 2 days spent so I could discover that another dep was breaking the godep save

@AlmogBaku not the right thread, but have you seen this: https://github.com/golang/dep ?

What is the state on this PR. My company will migrate to ES v5 soon too. Is the PR working? Can I help out somehow?

I also worked on a solution for that.. I still have few bugs I need to
solve before I can publish it..
I'll be able to work on it after the MWC event.
On Tue, Feb 21, 2017 at 10:50 PM andrejvanderzee<EMAIL_ADDRESS>wrote:

What is the state on this PR. My company will migrate to ES v5 soon too.
Is the PR working? Can I help out somehow?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes/heapster/pull/1464#issuecomment-281475809,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAGCpo4X9TOdoK4abmEMa1xFSdtAcjbvks5re04CgaJpZM4LkH24
.

--
http://www.rimoto.net/
www.rimoto.com http://www.rimoto.net/
Almog Baku
CTO & Cofounder *
Mobile: +972.50.2288.744
Social:  * http://www.facebook.com/AlmogBaku
http://www.linkedin.com/in/almogbaku

Closing this in favor of the new PR created by @AlmogBaku


Layers.png not set at bower.json

The icon image to change the layers (layers.png) is not defined at bower.json:
  "main": [
    "dist/leaflet.css",
    "dist/leaflet-src.js"
  ]

I guess Leaflet's bower.json has to look like this: (This is Leaflet Draw's bower.json and it's just an example)
  "main": [
    "dist/leaflet.draw.js",
    "dist/leaflet.draw.css",
    "dist/images/spritesheet-2x.png",
    "dist/images/spritesheet.png",
    "dist/images/spritesheet.svg"
  ]

@mourner @jonkoops do we still support bower?

Support for Bower was removed in https://github.com/Leaflet/Leaflet/pull/6635. The images were removed from Bower before that in https://github.com/Leaflet/Leaflet/pull/4481, as it was not allowed to have these kind of assets in the config file.
Closing this issue as it is no longer relevant.


Edit tool panel

In the app, we need an "edit tools panel" that has options for selectors (#14 ) as well as operations on those selectors.
Flow

Select a selector icon (box, sphere, etc) or just a mouse icon to not have an active selector
Adjust selector to where you'd like to be in the scene
Click on an operation (densify, delete, sparsify, etc)

I think it should be a narrow window with primarily clickable icons for each thing.
Extra

Consider undo with the operations - may be useful to have when you see the result of what you just did!

Looking at https://atlasicons.vectopus.com/ for icons

Creates edit pane with add and remove tools

Uploaded a set of icons as SVG and PNG, but dpg doesn't support SVG rendering (despite trying multiple libraries). I load the icon PNGs at the start of the program and am using 2 in the edit panel now. Closing this to make separate tickets for the other tools inside the edit panel.


fix: Fixed Bucket Policy chain dependency with Public Access Block

Description

Following AWS update of April 2023 for S3 Bucket Public Access Block default values for resources created via api calls, buckets are now created with block all public access enabled by default.
Motivation and Context

If a bucket is created with a public read policy, it will incur in 403 Access Denied caused by block all public access enabled at bucket creation, with the previous dependency chain the bucket policy gets created before the block all public access block.
Example of public read bucket policy:
{
    "Version": "2012-10-17",
    "Statement": [
        {
            "Sid": "ReadBucketPolicy",
            "Effect": "Allow",
            "Principal": "*",
            "Action": "s3:GetObject",
            "Resource": "arn:aws:s3:::bucket_name/*"
        }
    ]
}

Inverting the dependency chain between aws_s3_bucket_policy.this and aws_s3_bucket_public_access_block.this will solve this issue.
Breaking Changes

How Has This Been Tested?

[ ] I have updated at least one of the examples/* to demonstrate and validate my change(s)
[x] I have tested and validated these changes using one or more of the provided examples/* projects

[x] I have tested and validated these changes in aws cloud

[x] I have executed pre-commit run -a on my pull request

+1

Hello Guys, when will it be merged?

Please provide the complete code snippet which reproduces the bug so that I can run it locally and experience the problem.

Please provide the complete code snippet which reproduces the bug so that I can run it locally and experience the problem.

@antonbabenko
PR updated with example and error.
Best

Thank you for the PR, @Jean717p !

This PR is included in version 3.10.1 :tada:

FYI - With this version, I now see a cycle error
│ Error: Cycle: module.test-basic-vpc.module.dns-query-logs-s3-bucket.module.s3_bucket.aws_s3_bucket_public_access_block.this[0], module.test-basic-vpc.module.dns-query-logs-s3-bucket.module.s3_bucket.aws_s3_bucket_policy.this[0]
it appears that the aws_s3_bucket_public_access_block and the s3_bucket.aws_s3_bucket_policy have a cyclic dependency


fix: only query databases WHERE datallowconn = 't' in pg_database default-monitoring query

closes #4978
Signed-off-by: Daniel Chambre<EMAIL_ADDRESS>

/ok-to-merge


Don't Stop Me Now!

I dug a bit around in the uberspace logs and came to realise that we're using daemontools wrong. Our old restart command was svc -h – which is actually quite nice if you are dealing with regular processes. Not such much with Unicorn, who is quite opinionated about the signals. The HUP we sent left Unicorn in a unholy mess of an instance – still clung to the old release directory and a new Unicorn that couldn't bind to the port.
We could use svc -du but that would mean a bit of a downtime during deployment, or we could use the built in handling of Unicorn (which will drain old and accept new connections so the site won't go down during deployment).
Long story short: Let's try to use daemontools only for the initial start of the webserver (say - after a system reboot) and let Unicorn take over from there.
Changes:

Let Uberspace do the initial start (on boot, that's about it)
Let Unicorn handle USR2 + WINCH (restart, take over port + drain old master)

Empirical proof that this will work flawlessly
INFO -- : worker=0 ready
INFO -- : worker=1 ready
INFO -- : master process ready
INFO -- : worker=2 ready
INFO -- : reaped #<Process::Status: pid 763 exit 0> worker=1
INFO -- : reaped #<Process::Status: pid 760 exit 0> worker=0
INFO -- : reaped #<Process::Status: pid 768 exit 0> worker=2
INFO -- : master complete
INFO -- : Refreshing Gem list
INFO -- : listening on addr=<IP_ADDRESS>:9944 fd=9
INFO -- : worker=0 ready
INFO -- : worker=1 ready
INFO -- : master process ready
INFO -- : worker=2 ready
INFO -- : gracefully stopping all workers
INFO -- : executing ["/home/hacken/hacken-in-master/shared/bundle/ruby/2.2.0/bin/unicorn", "-p", "9944", "-E", "production", "-c", "config/unicorn.rb", {9=>#<Kgio::TCPServer:fd 9>}] (in /home/hacken/hacken-in-master/releases/20160414212612)
INFO -- : reaped #<Process::Status: pid 19597 exit 0> worker=0
INFO -- : reaped #<Process::Status: pid 19603 exit 0> worker=2
INFO -- : reaped #<Process::Status: pid 19600 exit 0> worker=1
INFO -- : inherited addr=<IP_ADDRESS>:9944 fd=9
INFO -- : Refreshing Gem list
INFO -- : master complete
INFO -- : worker=0 ready
INFO -- : worker=1 ready
INFO -- : master process ready
INFO -- : worker=2 ready

Actual depiction of Unicorn after receiving USR2

Thank you, Mr. Fahrenheit! That was one amazing PR right there :heart:


show other players in the game

using redis and pub sub add player presence to the game:

Bob is standing here.
Bob attacks a rat!
The rat hits Bob!

that means sanitising usernames and making it so you cant just spam "bad words / hate speech" etc.
and that's difficult to do for real.

Fixed!

Implemented; notifications happen now.


95 - Making cli more consistent

This PR aims to improve the consistency of our cli help menus.
Adding descriptions to every subcommand, adding help to every option, and making the text more consistent all across.

once and ap

If we decide that we can reuse the same message for help and description, I can move them to the localization folder. :D

QA
Test CLI overall. Since this task changed almost all cli commands we need to test them all.

QA
Minor changes. All looks good.


Performance tests? Or is it not a race?

But have you tested what you gained?
Your code, which needs to be loaded before you can use it, and requires extra async syntax on the connectedCallback
Your code IS "faster" on direct comparison with requestAnimationFrame and setTimeout "solutions" (not requiring any extra code)
But not using your code, those native 'hacks' are "faster"...

source: https://jsfiddle.net/WebComponents/0381j2og/
Just like WebReflection his solution; you proved you can get-ahead-of-the-line

Question is, what is really gained? Is it a race or about getting past that line? (knowing, for sure, child elements are parsed)
You are adding code complexity and code dependency to gain 1 or 2 ms?
You can only tell by A-B testing this in a real application...
Then again, are we re-writing our FP to faster for-loops?

Hi @Danny-Engelman thanks for checking out my work, and thanks for posting a code example. I was not not aware of the requestAnimationFrame or setTimeout approaches to this problem.
At first glance when I tested them myself, they seemed to work great, both performed faster than my solution in this repository, but I was a little suspicious. Is there something inherit to requestAnimationFrame and setTimeout that they will wait for all the child elements I need to be loaded. How do they know when to call back at the right time? Are they just waiting for the whole document to be loaded?
As I suspected they both appear to be race conditions. In many scenarios requestAnimationFrame and setTimeout will technically work, as the race condition appears to currently have a bit of head room. On my machine the race condition will fail somewhere around 1000 text paragraphs of child elements, which seems like it would cover most use cases, but that will change depending on the device and how browsers differ from each other and themselves in the future. The requestAnimationFrame and setTimeout functions were not built for this purpose, who knows how they will interact with  this scenario in the future? For these reasons I do not think they are a viable solution to the problem.
I found results when testing using jsfiddle to be very inconsistent so I have added essentially a race condition test to my demo page http://alexanderspirgel.com/children-loaded/demo to illustrate the issue. Let me know if my findings also match yours.
As for your comment:

and requires extra async syntax on the connectedCallback

This is just how I chose to implement because I prefer the async await syntax. It returns true or a promise. There is no reason you would have to add the async syntax to connectedCallback. You can see in the updated demo page code how I chose to implement it using the .then syntax. The .then syntax is very similar to that of requestAnimationFrame or setTimeout.

Tnx, great code rewrite, and great race, and totally valid arguments.
I had to reload 50 times for a value under 1000:

300 million years ago, in Computer Science class, we had to program fail-save programs.
Our professor (well, actually his teach assistants) literally pulled the power plug, when we were testing our programs.

And you learn the cost of software is not its 100% correctness. But programmers writing too many lines of code.
I now teach. And never pull that plug.
And, in this case, teach people setTimeout is not the best, but the best method for the team.
I've done a lot of (small, as they should be) components over the years. If I ever had 25 child-elements, it was a lot.

Thanks for your insights. You are definitely correct that in 99% of scenarios, using requestAnimationFrame  or setTimout will work well, but personally, I will reach for the mutation observer approach most of the time because I prefer the certainty.
Also it may be worth mentioning the pros and cons of both approaches when you teach (if you don't already).
Anyway thanks for raising the issue, I'll close it out now.


⚠ Bofrost.at has degraded performance

In 25e69c6, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1435 ms

Resolved: Bofrost.at performance has improved in 84f0ebe.


trim circleci jobs

Remove unused job definitions
Remove nightly and periodic builds that take up resources
Disable jobs that are already run by prow.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: rshriram
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

.circleci/OWNERS [rshriram]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

This should significantly cut down @louiscryan 's bill :)

/approved
/lgtm
@louiscryan told me he doesn't mind the CC charges.  Want the number, exp date, and CCV?

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: duderino, rshriram
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

.circleci/OWNERS [rshriram]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

merged. this is CI change - disabling redundant jobs, per last TOC meeting. Lint failure is known. Also synced with all release-xx branches

@rshriram: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-mixer-k8s-presubmit-tests.sh
a6aba5d8636de6140cc14d199a8ad2eb86a92f3b
link
/test integ-mixer-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Er, is passing lint no longer a requirement? Sure looks like it. Did someone turn that off?


Falling over when httpClient throws an exception

Stumbled over an issue when the httpClient throws an exception and I cannot catch it using the .catch() when using the QueryCoordinator's executemethod.
Usage is like this:
return this._query_coordinator.execute(new current_status_query_proxy()).then(result => {
      // success logic
    })
    .catch(e => {
     // error handling (doesn't kick in. ex: when no connection is available)
    });

When I change the implementation in the execute method on the QueryCoordinator to return the promise directly I can catch the error at any level in the promise-chain.
Is there a reason for bypassing the promise-chain and creating a new Promise?
ref: https://github.com/dolittle-interaction/JavaScript.Client/blob/82db296aab7558f66cf2237c7c3aae3494e34012/Source/queries/QueryCoordinator.js#L18

For reference, this is called the "Explicit Promise Construction Antipattern" - didn't know it had a name. It was linked to from this MDN article about using promises.


fix: automatic file: protocol handling

only do it for existing directories and use relative path

use more specific local directory check and make sure the path is absolute
use pnpm 7.18.1 for ecosystem-ci itself
change packageManager constraint in package.json of test project if it would use pnpm 7.18.0

see https://github.com/pnpm/pnpm/issues/5754. if that does not get resolved quickly, we'll have to figure out how to enforce staying on 7.17

updated the implementation here to avoid pnpm 7.18.0 , see https://github.com/vitejs/vite-ecosystem-ci/actions/runs/3629527374/jobs/6121834438#step:8:406


Use single exit callback

This diff solves the same problem that bermi addressed https://github.com/bruce/node-temp/pull/3, which is that if you create more than 10 temp files or dirs, you get the following warning:
(node) warning: possible EventEmitter memory leak detected. 11 listeners added. Use emitter.setMaxListeners() to increase limit.
Trace:
    at EventEmitter.<anonymous> (events.js:133:17)
    at EventEmitter.<anonymous> (node.js:383:29)
    at /Users/ryangreenberg/workspace/node-temp/lib/temp.js:73:13
    at /Users/ryangreenberg/workspace/node-temp/lib/temp.js:62:3
    at Object.openSync (/Users/ryangreenberg/workspace/node-temp/lib/temp.js:125:3)
    at Object.<anonymous> (/Users/ryangreenberg/workspace/node-temp/test/temp-test.js:45:8)
    at Module._compile (module.js:432:26)
    at Object..js (module.js:450:10)
    at Module.load (module.js:351:31)
    at Function._load (module.js:310:12)

The advantage of bermi's fix is that it's shorter.
A couple advantages of the attached diff:

a listener to process exit is only created when temp files are created (as opposed to unconditionally when you require the module)
named functions may make it more explicit what is happening for someone reading the code
includes a test that ensures that a single listener is used for all exit events.
you could expose deleteAllTempFiles in exports if people wanted an interface to deleting all temp files before process exit.

I didn't change the version number, so please change it if you accept this request. Thanks!

Great work, Ryan.  I'm pulling this in.  I'll add the export as well, as it may be useful, and bump the version.  Thanks!

Released as v0.4.0.  deleteAllTempFiles was renamed cleanup and exported after a bit of refactoring (split file and directory deletion).  Thanks again for the contribution.


VSCode starts debug mode during yarn install and causes yarn install to fail

VSCode Version: 1.50.0-insider
OS Version: Ubuntu 2-.04

Steps to Reproduce:

Run yarn in an npm project
VSCode starts and stops debug mode multiple times
yarn install fails

Does this issue occur when all extensions are disabled?: Yes
Installation works without problems when not installing with the VSCode Terminal

Thanks for the issue, this should be fixed in the next Insiders build. Until that happens you can get around this by setting debug.javascript.autoAttachFilter to disabled.


RFM - jfrog-cli

Package isn't being updated - https://chocolatey.org/packages/jfrog-cli
I've submitted several PRs - https://github.com/kevinkabatra/jfrog-cli/pulls
am willing to take over maintaining the package.

@jgeorgeson Please use the 'Contact Site Admins' link on the left of the package page and reference this issue.


QR code image only gets downloaded successfully on IOS or flagship devices.

I have recently finished this project using qrcodejs Free QR code generator.
Everything else is fine, but on devices i.e. Android, it throws an error Download fail or an undefined.html file gets downloaded.

Depending on your context you can try this

const downloadQR = () => {
let link = document.createElement('a');
link.download = 'qrcode.png';
link.href = document.querySelector('#qrcode canvas').toDataURL()
link.click();
}


willEnter and willLeave not firing

Am I understanding correctly that willEnter should fire upon mount, and willLeave will begin firing upon unmount?
I'm testing TransitionSpring, and I cannot get either to fire. Here's a short snippet...
  ...
  render: function() {
    return (

        <TransitionSpring
          endValue={this.endValue()}
          willEnter={this.willEnter}
          willLeave={this.willLeave}>
          {function(currentValue) {
            return ...;
          }.bind(this)}
        </TransitionSpring>

    );

I'm debugging both the willEnter and willLeave functions, and neither get kicked off.

What does your endValue() look like? Don't forget that willLeave fires when the return value from endValue() is missing a key that previously existed in the previous endValue(). Same for willEnter.

Ah, that must be it. I'll check that out stat. Thank you!!!

Which part of the README wasn't clear enough? I need to improve it.

From my perspective – having come from React's TransitionGroup – it wasn't immediately clear to me that Spring was not also responsible for unmounting. After digging through Issues on the Github repo, I indirectly discovered that wasn't the case – that the interpolations didn't simply work backwards (duh).
So, I turned to TransitionSpring assuming I'd find the answer. The docs dive right into an example (and a complicated one, at that) of how to use the component, but have little to say about why or what it's used for.
Other than that, it's a nicely done example with plenty of explanations on the handlers.

By complicated example, you mean the TodoMVC one?

This part struck me as dense for a minimum viable TransitionSpring implementation. After reading it about six or seven times, it began coming together ;)
let Demo = React.createClass({
  getInitialState() {
    return {
      blocks: {
        a: 'I am a',
        b: 'I am b',
        c: 'I am c',
      },
    };
  },

  getEndValue() {
    let blocks = this.state.blocks;
    let configs = {};
    Object.keys(blocks).forEach(key => {
      configs[key] = {
        height: {val: 50},
        opacity: {val: 1},
        text: blocks[key], // interpolate the above 2 fields only
      };
    });
    return configs;
  },

  willEnter(key) {
    return {
      height: {val: 50},
      opacity: {val: 1},
      text: this.state.blocks[key],
    };
  },

  willLeave(key, value, endValue, currentValue, currentSpeed) {
    // the key with this value is truly killed when the values reaches destination
    return {
      height: {val: 0},
      opacity: {val: 0},
      text: currentValue[key].text,
    };
  },

  handleClick(key) {
    let {...newBlocks} = this.state.blocks;
    delete newBlocks[key];
    this.setState({blocks: newBlocks});
  },

  render() {
    return (
      <TransitionSpring
        endValue={this.getEndValue()}
        willEnter={this.willEnter}
        willLeave={this.willLeave}>
        {currentValue =>

            {Object.keys(currentValue).map(key => {
              let style = {
                height: currentValue[key].height.val,
                opacity: currentValue[key].opacity.val,
              };
              return (

                  {currentValue[key].text}

              );
            })}

        }
      </TransitionSpring>
    );
  }
});

Thanks for opening up the docs to critique!

Hey, the API got a revamp. Can you check if the new docs are clearer now? I'll revamp the demo itself when I have the time.

Yes, TransitionMotion is much clearer now!


Hide colums not working

It's broken in v4.1.3, even in your demo http://ublaboo.paveljanda.com/datagrid/ - ajax request returns code 500

Nette/Latte behaves unreasonably in that case. Hmmm. Thanks for report.

That is apparently bug in latte snippets implementation.

Thx for quick fix. But still it's not working for me. Request is not failing anymore, but columns are not hiding - in response are snippets with all columns. Any advice what can I check if it's not problem in my grid usage? I have set only $grid->setColumnsHideable();


feat!: expedited proposals

Closes: #XXX
What is the purpose of the change
Feature: 2/3 Majority Emergency Voting Periods
Original Spec: https://github.com/osmosis-labs/osmosis/issues/1517
Description
This change introduces an option for any existing proposal to be expedited. If a proposal is expedited, it uses a shorter voting duration and a higher tally threshold. If a the higher threshold is not met under shorter voting duration, the proposal is converted as if it was a regular proposal and tallied / voted on under regular rules.
The distinction is achieved by having an IsExpedited flag on the proposal struct. When a proposal is converted from expedited to regular, this flag is flipped and VotingEndTime is extended. The rest of the fields,  including the ProposalId remain the same. As a result, all existing votes are preserved.
Differences from the Spec:

ExpeditedDuration is implemented on the VotingParams as opposed to Proposal struct
Did not create a separate index for expedited proposals. This would require duplicating logic for expedited proposals. Instead, in end block we iterate over both expedited and regular proposals and handle them appropriately

Brief Changelog

add IsExpedited flag to protos of all proposal content types
add ExpeditedVotingPeriod to protos of gov voting parameters
add ExpeditedThreshold to protos of gov tally parameters
implement changes in EndBlocker of x/gov to move expedited proposals to regular (with extended voting period) once voting period ends with proposal not meeting ExpeditedThreshold
add unit and integration tests to cover all new logic related to expedited proposals
fix existing tests

Testing and Verifying
This change is a trivial rework / code cleanup without any test coverage.
This change is already covered by existing tests, such as :

unit, integration and simulation tests in x/gov

This change added tests and can be verified as follows:

go test -timeout 30s -run ^TestExpeditedProposal_PassAndConversionToRegular$ github.com/cosmos/cosmos-sdk/x/gov
go test -timeout 30s -run ^TestProposalPassedEndblocker$ github.com/cosmos/cosmos-sdk/x/gov
go test -timeout 30s -run ^TestTickPassedVotingPeriod$ github.com/cosmos/cosmos-sdk/x/gov

Documentation and Release Note

Does this pull request introduce a new feature or user-facing behavior changes? yes
Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md? no
How is the feature or change documented? not documented

The isExpedited field is now defined on the Proposal type

Merging this to avoid having to continuously sync it with osmosis-main. We should be careful not to release this before governance decides on the future of this feature.
As for the current status of this as a whole, https://github.com/osmosis-labs/cosmos-sdk/pull/254 needs to be completed and merged before we create a gov prop. The gov prop is already written up and ready to go on-chain once #254 is in

Sweet! lmk once #254  is r4r!


Triangulation not working for non-convex polygon

Expected behavior and actual behavior.
Triangulation of a Polygon should not produce triangles outside the Polygon. While they have to be present for a MultiPoint with the same coords, it is not useful to have them for the Polygon.
Steps to reproduce the problem.
Repro data in https://github.com/jpmaterial/test_data/tree/master/Shapely/772
Operating system
Windows 10
Shapely version and provenance
installed dependencies with conda, installed shapely 1.7a2 by git cloning from github and setup.py develop

If you can provide the inputs in hex-encoded WKB, I can check them in the latest GEOS. There have been some triangulation improvements recently.

It does not seem like GEOS want to change the behaviour of this function. Quoting GEOS issue # 977:

Delaunay triangulation in GEOS relies on points and is not constrained. It is also a property of Delaunay triangulation to have the area increased to a full convex hull.

But I think this behaviour should be mentioned in the shapely documentation.

It seems like GEOS contains a separate function for performing constrained triangulation (https://libgeos.org/doxygen/classgeos_1_1triangulate_1_1polygon_1_1ConstrainedDelaunayTriangulator.html). Perhaps shapely can provide a binding to this function? I'm probably not the only one interested in this (see, for instance, https://stackoverflow.com/questions/65019170/how-do-you-triangulate-a-polygon-in-shapely https://gis.stackexchange.com/questions/316697/delaunay-triangulation-algorithm-in-shapely-producing-erratic-result)


AzNamingTool - Feature Request: Filter and examples of lower-level scope resources.

When using Jump To, both in Reference and in Configuration, let it be a filter displaying only the resources of the selected provider or even the only resource selecting and not a "Go To". This makes the display cleaner.
And in reference, that even resources that are lower-level scope, have examples of names displayed.
Thank you very much.

Hi @hmizael ,
Thank you for your suggestion. We have a big PR currently being reviewed that contains a new "filter" feature for the list of resource types.  We are hoping to have these new features released this week!

Bryan


Artifacts' Some output files are not displayed in playground

It gives only 1 file, other files are not either displayed/generated. is it possible to resolve?
Is it due to token limitation?

me too. no code and playground.

code & playground was not initially displayed, but later seen but only for first file: manifest.json

Could you try again? It should be writing only to a single file only (for now). Feel free to reopen, if you're still seeing this.


virtio-fs: add virtio_fs_extra_args for virtiofsd

Since virtio-fs is under active development, more
options will be added increasingly. To avaoid frequent
change on runtime side to handle option changes, use
one mingled arg to ease testing new option/feature of
virtiofsd.
See virtiofsd -h for more option details.
Signed-off-by: Eric Ren<EMAIL_ADDRESS>

@eryugey @bergwolf please help review, thanks~

/test

On Fri, Aug 23, 2019 at 6:32 AM Ganesh Maharaj Mahalingam <
<EMAIL_ADDRESS>wrote:

@ganeshmaharaj commented on this pull request.
In cli/config/configuration-qemu.toml.in
https://github.com/kata-containers/runtime/pull/1971#discussion_r316979296
:

@@ -108,6 +108,14 @@ virtio_fs_daemon = "@DEFVIRTIOFSDAEMON@"

Default size of DAX cache in MiB
virtio_fs_cache_size = @DEFVIRTIOFSCACHESIZE@
+# Extra args for virtiofsd daemon
+#
+# Format example:
+#   "-o arg1=xxx,arg2 --arg3=yyy"
+#
+# see virtiofsd -h for possible options.
+# virtio_fs_extra_args = ""
@renzhengeek https://github.com/renzhengeek while it is true that
upstream virtiofs will only work with QEMU, today's kata enables virtiofs
using nemu. Could we add this option to nemu config as well?
@bergwolf https://github.com/bergwolf @stefanha
https://github.com/stefanha WDYT?

Yes, it makes sense to enable it for NEMU if the next Kata release will
still support NEMU.
Stefan

On Fri, Aug 23, 2019 at 6:32 AM Ganesh Maharaj Mahalingam < @.> wrote: @.* commented on this pull request. ------------------------------ In cli/config/configuration-qemu.toml.in <#1971 (comment)> : > @@ -108,6 +108,14 @@ virtio_fs_daemon = "@DEFVIRTIOFSDAEMON@" # Default size of DAX cache in MiB virtio_fs_cache_size = @DEFVIRTIOFSCACHESIZE@ +# Extra args for virtiofsd daemon +# +# Format example: +# "-o arg1=xxx,arg2 --arg3=yyy" +# +# see virtiofsd -h for possible options. +# virtio_fs_extra_args = "" @renzhengeek https://github.com/renzhengeek while it is true that upstream virtiofs will only work with QEMU, today's kata enables virtiofs using nemu. Could we add this option to nemu config as well? @bergwolf https://github.com/bergwolf @stefanha https://github.com/stefanha WDYT?
Yes, it makes sense to enable it for NEMU if the next Kata release will still support NEMU. Stefan

Hi, done, thanks.

/test

Hi all,
I suddenly realized that the option name should be renamed to virtiofsd_extra_args, to clearly say it's for the daemon, not for the qemu/guest kernel, will update soon.

/test


Reactive issue

Is it necessary to set self.update() in the set function of ctx? Otherwise, we cannot get a response in the DOM when setting properties.

https://github.com/nuejs/nue/blob/master/packages/nuejs/src/browser/nue.js

The self.update() updates the dom to reflect the properties on the component instance.

cannot get a response in the DOM when setting properties.

What exactly you mean by this?
Thanks!

<div class="sidebar { isCollapsed ? 'collapsed' : '' }">
  <script>
    onSidebarCollapse() {
      this.isCollapsed = true
    }

    onSidebarExpand() {
      this.isCollapsed = false
    }
  </script>
</div>

For example, after calling onSidebarExpand to assign a value to isCollapsed, it cannot change the value of the class.

We need to call self.update to update the component after setting properties, or we can just update the component content related to the property. As follows:
  function updateProperty(key) {
    expr.forEach((el) => {
      if (el.toString().includes(key))
        el();
    });
  }

  set(__, key, val) {
    if ($parent && $parent[key] !== void 0) {
      $parent[key] = val;
      $parent.update();
    } else {
      self[key] = val;
      self.updateProperty(key);
    }
    return true;
  }

Nicely spotted!
Note that the client-side Nue JS is not currently under heavy development because there are some major pieces in the product development roadmap before the SPA stuff. There are quite many issues on the reactive lib, but they're addressed later. I should add a note to the README file about this.
Also — to add self.update() to that spot might cause unwanted side-effects. I think we need a proper client-side test suite for the reactive pieces before adding that change.

Got it

Thanks. I created a pinned issue for this.

I just spotted the same issue looking through the code.
About those unwanted side-effects, I know when I implemented a module transpiler I just had to check if the val actually contained a different value and only invoke the update() function if it was. If I didn't, I could hit an endless loop.
In any case, probably a good idea to hold off on changes here until these parts are covered in tests.


Missing data

[ ] Shell weight
[ ] Secondary name

[ ] Dispersion (Horizontal & Vertical)
[ ] A way to get ship shells, from ship directly for ship compare


Consider using a table

I've been using the git gist & now this repo to replace all the tools I use one by one. I think it would be great to have a table that maps the GNU/unix tools that each tool is supposed to replace. For eg:

unix
rust

cat
bat

cd
z

cp
xcp

diff
delta

diff
difftastic

du
dust

find
fd

grep
rg

ls
exa

ls
lsd

rm
rip

sed
sd

I think this mapping is more descriptive than whatever short descriptions one could come up with.
Not sure how much work it would be, but it would be nice to have trackers for the last commit & number of stars.

Thanks for this issue!
I've thought about this sort of one-to-one table. I'm hesitant because, while some of the Rust versions are meant to be "drop-in" replacements for specific Unix equivalents, others are a bit different. For example, they either have different flags (fd) or do things differently (rip sends deleted files to a "graveyard" and the readme says "You probably shouldn’t alias rm to rip.").
That said, I could hear an argument that readers are smart enough to read about each tool before installing them and making any aliases. I'll think about it some more, see if we get anymore comments!

Not sure how much work it would be, but it would be nice to have trackers for the last commit & number of stars.

Yep, this would be great. I just don't know how to do it yet! I moved this to a news issue: #3 .

I think it would be better to reverse the mapping since one crate could be used to replace more than one tool. sd for eg. can replace both sed & awk. Same for zoxide -> cd, z, autojump. Same for gitui -> git, lazygit.


Fix operator build

Two sample files were removed that are needed for the operator build to succeed [1] [2].  Without them this error is encountered:
$ IMAGE_TAG_BASE=quay.io/andrewbays/barbican-operator VERSION=0.0.1 IMG=$IMAGE_TAG_BASE:v$VERSION make manifests build docker-build docker-push bundle bundle-build bundle-push catalog-build catalog-push
...
Error: accumulating resources: 2 errors occurred:
	* accumulateFile error: "accumulating resources from '../samples': '/home/ocp/podified/barbican-operator/config/samples' must resolve to a file"
	* accumulateDirector error: "recursed accumulation of path '/home/ocp/podified/barbican-operator/config/samples': accumulating resources: 2 errors occurred:\n\t* accumulateFile error: \"accumulating resources from 'barbican_v1beta1_barbicanapi.yaml': evalsymlink failure on '/home/ocp/podified/barbican-operator/config/samples/barbican_v1beta1_barbicanapi.yaml' : lstat /home/ocp/podified/barbican-operator/config/samples/barbican_v1beta1_barbicanapi.yaml: no such file or directory\"\n\t* loader.New error: \"error loading barbican_v1beta1_barbicanapi.yaml with git: url lacks orgRepo: barbican_v1beta1_barbicanapi.yaml, dir: evalsymlink failure on '/home/ocp/podified/barbican-operator/config/samples/barbican_v1beta1_barbicanapi.yaml' : lstat /home/ocp/podified/barbican-operator/config/samples/barbican_v1beta1_barbicanapi.yaml: no such file or directory, get: invalid source string: barbican_v1beta1_barbicanapi.yaml\"\n\n"

[1] https://github.com/openstack-k8s-operators/barbican-operator/blob/41d26e9842110e20727073e2159b5172882e3ad3/config/samples/kustomization.yaml#L3
[2] https://github.com/openstack-k8s-operators/barbican-operator/blob/41d26e9842110e20727073e2159b5172882e3ad3/config/samples/kustomization.yaml#L5

Another option to fix this would be to remove lines [1] and [2].
[1] https://github.com/openstack-k8s-operators/barbican-operator/blob/41d26e9842110e20727073e2159b5172882e3ad3/config/samples/kustomization.yaml#L3
[2] https://github.com/openstack-k8s-operators/barbican-operator/blob/41d26e9842110e20727073e2159b5172882e3ad3/config/samples/kustomization.yaml#L5

I'm for removing those lines in  barbican-operator/config/samples/kustomization.yaml,  since those CRs will be created by the operator using data from the top level CR.

I'm for removing those lines in barbican-operator/config/samples/kustomization.yaml, since those CRs will be created by the operator using data from the top level CR.

Ack, done


Adapt to https://github.com/coq/coq/pull/19530

Adapt to https://github.com/coq/coq/pull/19530
This should be backward compatible and can be merged at your convenience, before the upstream PR.

Well, ok it's backward compatible but maybe not down to 8.4 !

@whonore what do you want to do with this? (FWIW, I tested it successfully on 8.12 and don't have anything older at hand to know exactly when it breaks)

Thanks for the fix.

Ha, indeed that works, thanks


Write sample about spring-security + Azure AD, LDAP login

Background

You can refer to parent issue (#25817) to get more information about all Azure AD related sample requirement.
As title. This issue is aimed to write sample about spring-security + Azure AD + LDAP login

Useful Links

https://docs.microsoft.com/en-us/azure/active-directory/fundamentals/auth-ldap
https://spring.io/guides/gs/authenticating-ldap/

@mpenabad1961 .
Copied from  https://github.com/Azure/azure-sdk-for-java/issues/26418#issuecomment-1011357778:

I currently use LDAP Spring Security and need to migrate to Azure AD, but UPS does not allow client-secret.

I think this GitHub issue can cover your requirement.
But this issue does not have ETA yet.

We currently use ActiveDirectoryLdapAuthenticationProvider in Spring Security for the LDAP integration, but not authorization.
Now we have a requirement for integration with Azure Active Directory Integration for MFA and SSO features. Our application is based on the Java spring framework. How we can implement this? Does this require a whole code change for Azure AD integration?
@chenrujun

@tomg-formpak
Thanks for reaching out, I will look into it and get back to you as soon as possible.

@tomg-formpak Thanks for reaching out, I will look into it and get back to you as soon as possible.

@chenrujun Thank you so much.
Note: It's Spring framework (not Spring Boot).

Hi @chenrujun just out of curiosity, would such example be any different from a plain Spring Security + LDAP protocol?
I'd assume this is the case, but only after I enable specific options to expose LDAP on my directory (encrypted of course). Correct?


1.0.0-alpha.1

This version rework completely the library, it's not compatible with previous version. Now you can use OPDS 2.0 with partial support.
BREAKING CHANGES
Opds::class

static method response() removed, now static method is Opds::make() and get() is a arrow method:

$opds = Opds::make();

$debug = $opds->get(); // `Opds::class` instance with response

return $opds->response(); // `never` because send response

To add entries, you have to use feeds() arrow method

feeds() accept OpdsEntryBook[] or OpdsEntryNavigation[] but also OpdsEntryNavigation or OpdsEntryBook

To add isSearch, you have to use isSearch() arrow method
To add title, you have to use title() arrow method
To add url, you have to use url() arrow method (only for testing, URL is automatically generated)
OPDS version can be handle by query param version: ?version=2.0 or ?version=1.2
To get generate response and keep Opds::class instance, you can use get() arrow method
To get response as XML or JSON, you can use response() arrow method
asString param removed, now you can use get() arrow method to debug response
To get response after get() you can use getResponse() arrow method (different that response() will return full content as never with headers)

use Kiwilan\Opds\Opds;
use Kiwilan\Opds\OpdsVersionEnum;

$entries = [];

$opds = Opds::make(new OpdsConfig()) // Accept `OpdsConfig::class`
  ->title('My search') // To set feed title
  ->isSearch() // To set feed as search
  ->url('https://example.com/search') // Only for testing, URL is automatically generated
  ->feeds($entries); // Accept `OpdsEntryBook[]`, `OpdsEntryNavigation[]`, `OpdsEntryNavigation` or `OpdsEntryBook`

return $opds->get();

Misc

OpdsConfig

usePagination is now default to false
forceJson param allow to skip OPDS 1.2

OpdsEntry is now OpdsEntryNavigation
OpdsEngine rewrite completely
OpdsResponse can be debug with getContent() method to inspect response (accessible if you use get() method)
OpdsEntry items have now get prefix for all getter

Added

add ODPS 2.0 support partially

@mikespub Do you want to beta-test 1.0.0 with partial JSON support?

This version don't support facets, groups and pagination.
Pagination will be first feature planned. For metadata, this version partially support with just basics entries, for metadata into belongsTo entry, just series supported for now.

One last point for future versions: for a re-usable package, it would be easier if we could get back the output as a result so we can handle the response ourselves afterwards, rather than let OPDSResponse->get() handle it.

I update Opds::class, now you can use get() method to get full instance with generated response into getResponse(). Method response() is available to send response to browser.
If you want to test OPDS 2.0 only when is full ready, I will send you a notification when all is done.

Thanks Ewilan, I would indeed prefer to wait for a more complete version before testing - sorry about that.
I've spent quite some time dragging the COPS code base from PHP 5.x to PHP 8.x, and adding OPDS 2.0 would be nice to have, so after dealing with a bunch of resource packages that hadn't been updated in 8 years, I was excited to find a modern package I could re-use that might provide that in the future :-)


PEP8 code styling

It's typical for python projects to adhere to PEP8. I'm wondering if there's any opinions/thoughts on it?
Generally that entails 4 space indents.
Most open source python projects follow the same general styling conventions.
While this may be a bikeshed in other programming languages, historically Python squared its styling issues away early on.
Any thoughts on this? If so, any preferred way of doing it?

We can use black formatter to format the whole repo.

@sdil If that is the case, you can merge #1
If you merge it, I will rebase #1. The code changes should be easier to see after that.


Add unit tests to increase code coverage

Signed-off-by: Jonathan Marcantonio<EMAIL_ADDRESS>https://github.com/stolostron/backlog/issues/22704

/unhold

/lgtm


Docs: Use pipenv to drive CI Sphinx build

Summary
This brings the website publishing for the docs in line with the changes from this PR https://github.com/apache/incubator-nuttx/pull/1698

This will pass once the changes in the linked PR are merged in.


New Client

There will be a new client, since the old one is very performant but very useless. Please tell me, what you want to see in the new client.

Cool fancy output

I started working on the client. In order to be more flexible with benchmarking and testing plans I'm working on an option to provide a config file.
What do you think about something like this:
general:
  totalduration: 10.0
  serverhostname: localhost
  serverport: 8080
  commandsperconn: 5
basic:
  key:
    minlen: 10
    maxlen: 1000
    alphanumeric: false
  value:
    minlen: 10
    maxlen: 1000
    alphanumeric: false
  cycleduration: -1.0
  cyclepattern: SET-GET-GET-GET-DEL

Looks nice


Increment version for batch releases

Increment package version after release of azure-batch

API change check
API changes are not detected in this pull request.


Calling stopScan during scanning causes an error

Report from user:
"I have been playing with the eddystone plugin in ionic.
I am a little confused about the following two statements:
startScan will keep scanning until you call stopScan().
To conserve energy, call stopScan() as soon as you've found the device you're looking for. Calling this function while scanning is in progress will produce an error
As I understand these two statements, because startScan scans continuously then stopScan will always cause an error.
In practice i observe that calling stopScan after startScan is running, does indeed show an error "Scanning already in progress!", and the beacon scanning continues.
Therefore how do we programatically stop beacon scanning ?"

Did a test app to verify problem with stopScan: https://github.com/mikaelkindborg/evo-demos/tree/master/Demos2016/eddystone-test
Could not reproduce this problem. Perhaps the code originally reported to demonstrate the error mistakenly called startScan instead of stopScan, which would produce the "Scanning already in progress!" error.

Hi @mikaelkindborg,
I was a little confused by the readme and wonder whether the user behind this issue got a bit muddled too. The paragraph I'm referring to is:
'To conserve energy, call stopScan() as soon as you've found the device you're looking for. Calling this function while scanning is in progress will produce an error.'
I think it would be clearer if it read:
'To conserve energy, call stopScan() as soon as you've found the device you're looking for.
Calling startScan() while scanning is in progress will produce an error.'
Otherwise on first glance it looks as if 'this function' refers to stopScan() rather than startScan()
Hope that makes sense!

@tomkelsey Thanks for the clarification! Will update the comment!


Once we support multiple Workspaces remove the concept of VisualStudioWorkspaceAccessor.Workspace

This is mostly to ensure we don't forget to do this. We've gone through all sorts of work to make our services not expect a "primary" workspace and I'd like to ensure we don't make that mistake again. Therefore, we should remove VisualStudioWorkspaceAccessor.Workspace once #1973 is completed.

ca15840d05994521101a86f7d364832a15bfd9dd


Interactions with futures

Hello! I was pointed to this library and it is pretty cool, thank you for making it.
How do these coroutines interact with futures? Can a coroutine be a future executor? Can futures run on a coroutine? Are there any limitations interacting across? Sorry, I am not too familiar with the stack unwinding machinery, drop, and such in Rust but from the README it looks like there are some different tradeoffs vs futures that might be incompatible?

Great, thanks!


Closing image by swiping up/down

Hello. I can not find an ability to close an image by swiping down or up like in native apps or many js lightbox galleries. Is this possible?

Also when I try to swipe up or down all controls disappears and the gallery stops working until
the back button is pressed. I am trying an Angular example app
https://user-images.githubusercontent.com/1417956/194368836-f2a24c51-ba41-454b-8383-2f366323ac0d.mov

@michaelkhabarov swiping up and down is not supported gestures. When you swipe up or down is equivalent to a tap gesture so you go into the zoom mode this is why the controls are hidden. All this is normal behaviour.  This is not a bug

@michaelkhabarov keep it open i will have a look when i have time tell me what you will expect as behaviour for swipe-up an down

I think swipe-down should be equivalent to the "Close" buton

In my opinion this gallery is a very nice example of swiping behaviour https://photoswipe.com

@michaelkhabarov thanks for the reference to https://photoswipe.com i saw the gesture behaviour and i think it is pretty simple. It could be implemented in the plugin but required a complete review of the code. I will see what i can do when i back home (3weeks time from now).

That would be pretty awesome .. I have implemented this plugin anyway. Can't wait until it's merged 🤗

@jayruben you could have made a PR and i will have merge it.

@michaelkhabarov @Elardzhi @jayruben this is fixed in 2.0.7

@michaelkhabarov @Elardzhi @jayruben  2.08 fix some issues for the web plugin

@jepiqueau do you have an example of the gesture? Because when I swipe to top or bottom the view will be inserted from the right if that is the effects you had implemented? Rather then the reference.. although it is nice

@jayruben on which platform ? I tried to implement what was suggested.

https://user-images.githubusercontent.com/16322433/211606797-0b792954-125c-4306-9d30-660a0f0b9feb.mov
@jepiqueau here is an example of how it is at my side

@jayruben this is due to the transition applied see Extensions/UIViewController.swift method dismissWithTransition()
transition.subtype = CATransitionSubtype.fromRight

if you do not like the transition applied i can remove it so open a new issue to remove the transition
you can test on your side by
in OneImageViewController.swift comment line 217 and uncomment  line 218
in SliderViewController.swift comment line 419 an add a line self.dismiss(animated: true, completion: nil)
in SliderViewController.swift comment line 347 an add a line self.dismiss(animated: true, completion: nil)
Hope this help

@jayruben you did not come back do you want me to remove the transition

@jepiqueau of course you don't have to remove it, have implemented it in our app. thanks in advance

@jayruben Would you like to have an option to select the transition top, bottom, left, right ?

That would be awesome.
Is there also a possibility to build in not only have the transition going from a direction but also only opacity transition with parent view controller underlying at normal position.
Or even if possible a combination of both?
Example: Direction Left + opacity
Example: Direction None + opacity
Example: Direction Bottom + No opacity
Thanks in advance,
Jay

On 18 Jan 2023, at 07:36, QUEAU Jean Pierre @.***> wrote:
@jayruben https://github.com/jayruben Would you like to have an option to select the transition top, bottom, left, right ?
—
Reply to this email directly, view it on GitHub https://github.com/capacitor-community/photoviewer/issues/26#issuecomment-1386560276, or unsubscribe https://github.com/notifications/unsubscribe-auth/AD4Q7AJJYFIE2IGZOCS45N3WS6FOFANCNFSM6AAAAAAQ6ZBEJE.
You are receiving this because you were mentioned.

@jayruben you mean fade in fade out. I will have a look but it is quite à job so it will take some time


Make replacement

Is your feature request related to a problem? Please describe.
xmake is a good replacement for CMake, but it is not a good replacement for make. As far as I understand it lacks the simple file dependencies like
a.msi: a.exe
   create-msi.exe a.exe

Describe the solution you'd like
Top level rule for a file with dependencies on other files, tasks, targets, e.g.:
add_file_target("a.msi", ["a.exe"], function() {
execute_program("create-msi.exe", ["a.exe"]);
})
Describe alternatives you've considered
Using make
Additional context

You need only call os.exec to do it in after_build().
target("a")
    set_kind("binary")
    add_files("src/*.c")
    after_build(function (target)
        os.execv("create-msi.exe", {target:targetfile()})
        -- or
        --  os.exec("create-msi.exe %s", target:targetfile())
    end)

Using make

xmake does not rely on make, but it can also generate makefiles.
xmake project -k makefile

What is obviously missing is the check that a.msi is up-to-date and also if this get more complicated. Basically a Makefile is a DAG where edges should be ordered according to the dependencies.

What is obviously missing is the check that a.msi is up-to-date and also if this get more complicated. Basically a Makefile is a DAG where edges should be ordered according to the dependencies.

You can add a check through os.mtime.
https://github.com/xmake-io/xmake/blob/d9b466eee4de846d35dbc1081728a5b635949da0/xmake/rules/lex_yacc/lex/xmake.lua#L83

Yes, I could do this. Lua is a programming language and allows everything. But this is a feature request for something that is easily done in make, but not in xmake.

I added depend.on_changed() to simplify adding dependent files.
    after_build(function (target)
        import("core.project.depend")
        depend.on_changed(function ()
            os.execv("create-msi.exe", {target:targetfile()})
        end, {files = target:targetfile()})
    end)


Permission to submit a pull request?

Hi Ben,
Can you grant me permissions to submit a pull request for angular-stripe and angular-credit-cards? I would like to contribute the minified versions for both of those scripts.
Thanks!

There are no special permissions required to send a PR. Even so, I don't published minified files with any projects. I'm willing to do a UMD build in isolated cases for ease of initial setup but I expect consumers to have a proper build process for production.


strict_on_args on recursive function

[@@strict_on_arguments [0]]
let rec cd (x:nat) : nat =
  if x = 0 then 0 else 1 + cd (x-1)

#push-options "--no_smt"
let _ = assert_norm (cd 1 > 0)
#pop-options

This should work, but gets stuck after the first iteration. The problem is a Tm_lazy node preventing the reduction, pushing a fix soon.

Making a note that this patch would fix this issue
commit 3111019fce5e11afdf2463780f90e675846c3d12 (HEAD -> pristine)
Author: Guido Martínez<EMAIL_ADDRESS>Date:   Sun Apr 7 13:32:13 2024 -0700

    Normalizer: a fix for strict_args

    Fixes #3234

diff --git a/src/typechecker/FStar.TypeChecker.Normalize.fst b/src/typechecker/FStar.TypeChecker.Normalize.fst
index f5110abb5c..ae4333e37e 100644
--- a/src/typechecker/FStar.TypeChecker.Normalize.fst
+++ b/src/typechecker/FStar.TypeChecker.Normalize.fst
@@ -1646,7 +1646,7 @@ let rec norm : cfg -> env -> stack -> term -> term =
                   if i >= norm_args_len then false
                   else
                     let arg_i, _ = List.nth norm_args i in
-                    let head, _ = arg_i |> U.unmeta_safe |> U.head_and_args in
+                    let head, _ = arg_i |> U.unmeta_safe |> U.unlazy_emb |> U.head_and_args in
                     match (un_uinst head).n with
                     | Tm_constant _ -> true
                     | Tm_fvar fv -> Env.is_datacon cfg.tcenv (S.lid_of_fv fv)

But, it unblocks some reductions of Lib.Exponentiation.Definition.pow in HACL* (which is marked strict_on_arguments), and it takes way too long. In particular, in Hacl.Spec.PrecompBaseTable256.fst it's called with an exponent of 2^128, and that ends up reducing now, which will not terminate in any reasonable amount of time (and will OOM too).


Social media slide ul

show information about social media with a ul
changed_mentors.slim   name  to _social_media.slim

Thanks @this-miguel !


Run SonarCloud only on pull requests to master

Run SonarCloud less often to reduce build times for normal CI builds.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: Lekkx91 sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


Cannot choose between cloud plugins in GUI dropdown list.

I have the dummy/local and the ec2 cloud plugin in my server.config.
In that case, 'local' is missing in the GUI 'cloud' dropdown list. To switch to local I have to actually outcomment the ec2 plugin in the server.config.
BTW: some marginal friction: it wasn't immediately clear to me in the cloud plugin configuration that
{group_set, ["MZbench_cluster"]}, (i.e is a [set], not just a "string")
and that subnet_id and iam_instance_profile_name can be set to the atom undefined
Keep up the awesome MZBench work ! :)

13:26:33.860 [error] [ API ] <0.433.0> Stage 'pipeline - allocating_hosts': failed
Benchmark has failed on allocating_hosts with reason:
{unknown_cloud_name,dummy}

...as soon as I have configured an EC2 plugin in server.config and try to clone a previously run bench that ran on dummy plugin.

Oh man, of course it was an error in my config file.
:)
sorry folks...


game opens to blank screen

On both the windows and android version

This is indeed an issue with the latest update, but I'm not sure how to fix it personally. It's related to some files not being loaded correctly; if anyone can submit a PR for it I'd definitely integrate it!

Issue seems to be caused by a failure to find the manifest.json file; it seems to be looking in the C drive and not wherever it should be looking for it

The problem is caused by the animation, which requires some processing of the AnimationConfig when it is packaged offline, and it feels like someone wrote a bug

Someone submitted a PR that does successfully fix this issue; update the app and you should be good to go.

Will do, thanks!
William Burleson @.***> 于2024年8月19日周一 16:45写道：

Someone submitted a PR that does successfully fix this issue; update the
app and you should be good to go.
—
Reply to this email directly, view it on GitHub
https://github.com/Admiral-Billy/Pokerogue-App/issues/127#issuecomment-2296011940,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AWYO7XXHJSULFLBKRDWUY2LZSGWCBAVCNFSM6AAAAABMV46VGCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOJWGAYTCOJUGA
.
You are receiving this because you commented.Message ID:
@.***>


Added Stock Market Project

Have you read the Contributing Guidelines ?
YES
Description
Stock Market Web App that displays the basic stock information of a particular stock such as price, percent change in the stock value, previous close, 52 weeks high, etc.
Fixes #584

Checklist

[x] I've read the contribution guidelines.
[x] I've checked the issue list before deciding what to submit.
[x] I've edited the README.md and link to my code.

Related Issues or Pull Requests
(Write your answer here.)

@photon149 The project already contains a README file with the output screenshots


Out of sample generalisation

What is the expected stability of these methods for out of sample predictions?
I ran a simple example using a power curve function ( see  below )  limited between [1,100].
The model performs quite well on the training set. Out of set it quickly diverges.
from kan import *

model = KAN(width=[1,2,1], grid=3, k=2, symbolic_enabled=False)
a,b,c = 0.7, 0.2, 0.1
f = lambda x: a*x**-b + c
dataset = create_dataset(f, n_var=1, ranges=[1,100])
model.train(dataset, opt="LBFGS", steps=20);

x = torch.tensor(np.arange(1,1000,0.1)).reshape(-1,1)[1:]
y_actual = f(x)
y_pred = model(x)[:,0].detach().numpy()

plt.scatter(x.numpy(),y_actual, color="red")
plt.scatter(x.numpy(),y_pred, color="blue")

Unfortunately, KANs don't guarantee out-of-distribution generalization (just like other models by default), unless you try symbolically snapping them.

Thanks for the feedback!
Can you elaborate on symbolic-snapping?

I guess the key idea here is to use symbolic regression to extract a parametric function that describes the data.
From there you should be able to generalise

Here is an example where KANs can generalize out-of-distribution. Frankly any symbolic method can achieve this if the correct symbolic formula is found. I cheated a little bit by changing two things:

I changed to b=1 since currently we only support regressing integer power exponents.
I changed to width = [1,1], since we know a [1,1] KAN (which is a spline) is enough for 1D functions.

from kan import *

model = KAN(width=[1,1], grid=3, k=2)
a,b,c = 1, 1, 0.1
f = lambda x: a*x**-b + c
dataset = create_dataset(f, n_var=1, ranges=[1,2])
model.train(dataset, opt="LBFGS", steps=100);

# fix function to be 1/x (unfortunately we don't support fractional order yet)
model.fix_symbolic(0,0,0,'1/x')

x = torch.tensor(np.arange(1,100,0.1)).reshape(-1,1)[1:]
y_actual = f(x)
y_pred = model(x)[:,0].detach().numpy()

plt.scatter(x.numpy(),y_actual, color="red")
plt.scatter(x.numpy(),y_pred, color="blue")

Amazing!
Perhpas going the sympy route might make sense?
See for instance the PySR implementation
https://github.com/MilesCranmer/PySR/blob/116eee19568e9cc0801e8d5996771ab75bb95998/pysr/export_sympy.py#L8


💿 Gather Percentage of non-gov.uk Subdomains That Are Delegated to Cloud Platform

Duplicate raised my mistake


Leak issues

When using redisson, I'm occasionally getting errors like this: "LEAK: you are creating too many HashedWheelTimer instances".What are possible causes of this issue?
I'm also seeing (probably related) errors like this: "LEAK: HashedWheelTimer.release() was not called before it's garbage-collected." I assume this is related to my problem, but I don't know where to look in my code for this leak. Could this be a bug?
Thanks!

Each Redisson instance has one HashedWheelTimer. How many Redisson instances do you have simultaneously?

Starting from https://github.com/mrniko/redisson/issues/134 you don't need to use multiple Redisson instances for each codec.


create-migration prompts loop if answering 'n' when altering a constraint

EdgeDB Version: EdgeDB 1.0-beta.1+g2eee1afe4.d20210301
When altering a constraint then running create-migration, the prompts loop if you answer 'no' to the drop/create prompts.
Migrating schema from:
module default {
  type User {
    required property username -> str {
      constraint exclusive;
      constraint regexp(r'\w+');
    }
  }
};

to:
module default {
  type User {
    required property username -> str {
      constraint exclusive;
      constraint regexp(r'[a-z0-9_]+');
    }
  }
};

and running edgedb create-migration:
did you create constraint 'std::regexp' of property 'username'? [y,n,l,c,b,s,q,?]
n
did you create constraint 'std::regexp' of property 'username'? [y,n,l,c,b,s,q,?]
n
did you create constraint 'std::regexp' of property 'username'? [y,n,l,c,b,s,q,?]
y
did you drop constraint 'std::regexp' of property 'username'? [y,n,l,c,b,s,q,?]
n
did you drop constraint 'std::regexp' of property 'username'? [y,n,l,c,b,s,q,?]
n
did you drop constraint 'std::regexp' of property 'username'? [y,n,l,c,b,s,q,?]
y
Created ./dbschema/migrations/00002.edgeql, id: m1fadkben4m45k2zh4juemhccnr25awzrdg4s3clpgalsl7lg5gi7q

From a quick glance, it looks like this happens for basically anything other than top-level object changes, because the logic for extracting a prompt and the logic for figuring out what was rejecting don't match up.


Location entities - "FAC" and "NORP"

In the geoparse.doc_to_ex_expanded function, there are two different lists of labels for entities:
['GPE', 'LOC', 'EVENT_LOC', 'NORP']

and
['GPE', 'LOC', 'EVENT_LOC', 'FAC']

Is this intentional?
https://github.com/ahalterman/mordecai3/blob/main/mordecai3/geoparse.py#L118-L120

Thanks for raising that question. I had to remember why I did it. That first list we just use for context when picking the best location. For that purpose, NORPs are very useful ("The city of Tripoli on the Lebanese coast") but we don't want to geoparse them. Conversely, FACs aren't as helpful for context, but we do want to geoparse them. I added a comment to the code because it definitely does look like an inconsistency.


Why can't the type be inferred inside spawn_fn

Please consider the following examples:
Example 1
let pool = CpuPool::new(2);
let local_packages = pool.spawn_fn(|| {
        let s = get_a_string();
        let res: Result<String, ()> = Ok(s);
        res
});

Example 2
let pool = CpuPool::new(2);
let local_packages = pool.spawn_fn(|| {
        let s = get_a_string();
        let res = Ok(s);
        res
});

The first example is compiled, however, the second one is not compiled with the error of error[E0283]: type annotations required: cannot resolve _: std::marker::Send, why should the type of res be provided?
rustc --version: rustc 1.16.0 (30cf806ef 2017-03-10)

Because in the second case the error type of the Result is unknowable: the compiler can't infer from that example what the type of an Err for this Result would be. And afaik, rust does not have a "bottom" type (like scala's Nothing) which is legal to use in any position.
In practice though, the function context in which the Future is used will allow both types to be inferred.

You can probably do something like:
Ok::<_, ()>(get_a_string())

Basically only specifying the error type


Add timezone support for dates package

Addresses https://github.com/mantinedev/mantine/issues/3432
I added a timezone setting to the DatesProvider, allowing to shift the dates for the components using it. Dates are shifted back and forth by the parent component. It is also used in some helper functions as needed.
It is a bit hacky but the only possible solution to not introduce breaking changes.

Please add documentation that describes how the feature works to DatesProvider page

@rtivital any idea why the tests are failing? that are all files that are not scope of this MR, are the tests failing in master branch?

I'll check the issue with tests tomorrow

@rtivital do you still need something for this MR?

No, I think it's fine

Thanks!

@rtivital it seams that the merge/build is somewhat strange, is there something i can fix?
for example:
https://github.com/mantinedev/mantine-v7/blob/172763983b1ae8eb6b4e46a12d0f679c93be923e/src/mantine-dates/src/components/DateTimePicker/DateTimePicker.tsx#L132C39-L132C39
it seams to be translated to:
const [_value, setValue] = useUncontrolled({
    value,
    defaultValue,
    finalValue: null,
    onChange
  });

you can see it in npm code view: https://www.npmjs.com/package/@mantine/dates/v/7.0.0-beta.7?activeTab=code
so useUncontrolledDates seam to be replaced with useUncontrolled which isn't working as intended.


[BUG] Trying to update proof hash for non-existing path

To Reproduce

Turn on inherit option in sharding.test.js: server1_proc = startServer(APP_SERVER, 'server1', ENV_VARIABLES[2], true)
Run ./node_modules/mocha/bin/mocha --timeout 320000 integration/sharding.test.js -g 'set_value with is_global = false'

Fixed.


Create Testimonial 4 Black

One need to make this component using HTML and Tailwind CSS. I would suggest to use Tailwind Playgrounds to make things faster and quicker.
Here is a reference to the component.

Follow figma design
After building the component please raise a PR with a screenshot of the component and add the component in Testimonials/src/testimonial-4.html by replacing the existing code with yours and also rename the file to testimonial-4-black.html
If you need to use any icon please use it from Hero Icons
Good luck.

@RavindraP04  can I work on this issue under JWOC


connecting database and linking front end and back end

Thank you for contributing! To help the review process, please provide the following:
Proposal
-Worked on Database adding some columns and data
-connected the database to the system and use it to retrieve data instead of fackdata.json file
-created  a main lesson route which display an overview of the classes.
Related
Provide links to any associated pull requests or issues. You can use #123 to link to a PR or issue in this repository, or user/repo#123 to link to other repositories.
Checklist

[ ] I have read the code of conduct and contributing guide
[ ] I have made this pull request to the master branch
[ ] I have run all of the automated validation using npm run ship
[ ] I have added myself to the "contributors" list in the package.json (or do not want to)

Hi Nouri
you are deleting the main files like app.js , db.js , index.html , main.js in this pull request. which are necessary to app work both locally and online. That's why i am not merging into master and closing this pull request.

Hi Nouri
you are deleting the main files like app.js , db.js , index.html , main.js in this pull request. which are necessary to app work both locally and online. That's why i am not merging into master and closing this pull request.


How to use bash code to tune hyperparameters?

Hello, congrats for the great work! I was trying to do hyperparameter tuning of my model, using a sh file to pass the arguments into the py file (using argparse).
However, if I have a script, say "run.sh", it will run the "example/run.py", and then "example/run.py" will try to get the hyperparameters in "examples/Triformer/Triformer_ETTh1.py".
Now I want to pass the hyperparameters from "run.sh" to "examples/Triformer/Triformer_ETTh1.py". But it seems I can only pass arguments to the "example/run.py". Since the parameters are stored in "examples/Triformer/Triformer_ETTh1.py", which is the file I want to modify, could you kindly suggest on that? Thanks very much for your time!

You can copy several your config files, and use different hyper-parameters.
For example, Triformer _etth1_lr_0001.py and Triformer
_etth1_lr_0002.py.

I see, that is indeed a clever way to do it. Thanks!

 If you have any other questions or suggestions, feel free to create a new issue.

How were you able to carry out Hyperparameter tuning? I'm trying to do so for my dataset using one of the BasicTS models using Optuna but unsure as the actual training is being done by easy-torch.

We are currently not familiar with Optuna or other AutoML tools, so BasicTS does not officially support training with these tools at this time. However, we are actively learning about these tools and exploring ways to integrate them into BasicTS in the future.


Reg. Linux log analytics agent installation

Team,
For a customer, we were installing Linux OMS agent on a Redhat linux machine.
Installation failed with the below error
Error during the onboarding request: curl returned 35.
Check the correctness of the workspace ID and shared key or run omsadmin.sh with '-v' Trying to stop omi with systemctl omi is stopped. Trying to start omi with systemctl omi is started. System appears to have SELinux installed, attempting to install selinux policy module for logrotate
However, the issue was due to an outdated CURL and Open SSL packages.
After updating CURL packages
After updating Open SSL from openssl-1.0.2k-16.el7_6.1.x86_64 to openssl-1.0.2k-21.el7_9.x86_64
Installation succeeded.
Please test this one and include that in documentation.
So other customers or system integrators do not face this problem

@arun-cogniz Thanks for your feedback. Can you please share your below information to make recommended changes ?

Share the Azure document that you were following
Which OS version of RedHat are you using

Red Hat Enterprise Linux Server release 7.6 (Maipo)
This is the doc page that i referred
https://docs.microsoft.com/en-us/azure/azure-monitor/agents/agent-linux

@arun-cogniz Thanks for sharing the details.
Assigning to content author @bwren for review .

Sorry for the late reply but finally getting to this. Going to add a note to the article to cover this.
#please-close


Remove --save option as it isn't required anymore

"As of npm 5.0.0, installed modules are added as a dependency by default, so the --save option is no longer needed. The other save options still exist and are listed in the documentation for npm install."
https://stackoverflow.com/a/19578808/142358

Thanks. Good to know! Since this is about migrating from and old version, chances are that users still use an older npm. So I’ll keep it for now.


An update for Unreal Gold (227j)

Feature Request
Unreal Gold has had an update since 227i, 227j.
Solution
Point people torwards that, and package libxmp.so.4 in the unreal-libs tarball
Additional Context
I created this here because I couldn't over at the other repo.

These sort of requests should go into the packages repo (I moved it here). What sort of problem did you have with it?
I will take a look soon

@daemonspudguy Where would the download for this be?
According to this, https://www.oldunreal.com/downloads/unreal/oldunreal-patches-for-unreal-latest-ver.j/
It looks like it is not out yet.

https://www.oldunreal.com/phpBB3/viewtopic.php?f=51&t=10395

Also, I would suggest updating the included openAL library.

Wait, in the help folder there is a tarball called convience_libs, i would recommend using that tarball's libraries.

@daemonspudguy I will take a look, normally I prefer to wait until an official release, but will see if this is usable.

@daemonspudguy For the libraries, normally the steam runtime has the libraries needed, so that would be best to use. I'll see if any additional libraries are needed.

@d10sfan the 64-bit binary doesn't work, at least with my system. The 32-bit binary does.
Use that.

@daemonspudguy It worked fine for me, what sort of error are you seeing?

"Illegal instruction"

If you're getting Serious Sam Classic flashbacks, so am I.

Seriously, just use the 32-bit build. The 64-bit one is still experimental.

@d10sfan I think the compiler made a binary that certain older CPUs like mine don't support. I don't know what causes it, and I can't compile it myself because proprietary.

@daemonspudguy Does the 32-bit version of this version work for you on your system?

@d10sfan Yes.

@daemonspudguy You can track progress here: https://github.com/luxtorpeda-dev/packages/pull/803
Let me know if  you run into any issues once that has been merged.


Bug 2043130: vmware-vsphere: Add external-snapshotter permissions to patch snapshots

The new external-snapshotter needs permissions to Patch VolumeSnapshots and
VolumeSnapshotContents.
https://github.com/kubernetes-csi/external-snapshotter/releases/tag/v5.0.1

/lgtm
/approve


exponentiation ^ support

I would like to see supports for exponentiation in CS:
2^2

That would make it easier than having to use a function for it.

If you try it, you'll notice that ^ is already an operator.
> 2 ^ 2
0


Opponent Glow Notes

What is your question?
In the source code, how can I do for when the opponent sings, his notes dosen't glow. Pls, could anyone help me?? I would aprecciate the help...

delete StrumPlayAnim(true, Std.int(Math.abs(note.noteData)), time); next to note.hitByOpponent = true;


【wip】pick plugin into develop

Issues associated with this PR
Your PR should present related issues you want to solve.
Solutions
You should show your solutions about the issues in your PR, including the overall solutions, details and the changes. At this time, Chinese is allowed to describe these.
UT result
Unit Test is needed if the code is changed, your unit test should cover boundary cases, corner cases, and some exceptional cases. And you need to show the UT result.
Benchmark
If your code involves the processing of every request, you should give the Benchmark Result.
Code Style

Make sure Goimports has run
Show Golint result

this pr is just for test。 do not need merged


RuntimeWarning: divide by zero encountered in true_divide

There is a warning when create_data.py runs.
What is it? What does it mean?
create reduced point cloud for testing set
[>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>] 12000/12000, 24.1 task/s, elapsed: 499s, ETA:     0s
[>                                       ] 3620/96000, 9.2 task/s, elapsed: 393s, ETA: 10041s/home/s/dev/mmdetection3d/mmdet3d/core/bbox/box_np_ops.py:374: RuntimeWarning: divide by zero encountered in true_divide
  point_2d_res = point_2d[..., :2] / point_2d[..., 2:3]
[>>>>>>>>>>>>>>>>>>>>>>>>>>>>         ] 73974/96000, 10.4 task/s, elapsed: 7086s, ETA:  211[>>[>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>] 96000/96000, 10.6 task/s, elapsed: 9061s, ETA:     0s

It means the point cloud depth should be zero


Manually removing someone's color role leaves orphan colors

Problem: Manually removing the color role from someone does not remove that user from the list of users with the color. The color is then not deleted, if that was the only user making use of it.
We should listen for GuildMemberRoleRemoveEvent and update the color roles accordingly.

https://github.com/the-programmers-hangout/HangoutBot/commit/deead942b3d189ba5459f1c323b6aae97936e9c7


Resume training from Lightning generated ckpt alone

Description & Motivation
It seems that whenever checkpointing is enabled, a corresponding *.ckpt file is generated, containing everything from the model weights, to the logging data and the parameters of the LitModule and LitDataModule.
This sounded great to me and so I thought naively that I could simply resume a training running just the following:
python mainCLI.py fit --ckpt_path /path/to/my/checkpoint.ckpt
However, this does not work, giving me the following error:
usage: mainCLI.py [-h] [-c CONFIG] [--print_config[=flags]] {fit,validate,test,predict,tune} ...
mainCLI.py: error: Configuration check failed :: Key "fit.data.dataset_dir" is required but not included in config object or its value is None.

This is an error for a missing path to my dataset, which is contained in the *.ckpt file which I'm trying to resume from.
Perhaps this is an intended behavior, or perhaps this is a bug. I'm guessing this has simply not been implemented, but I was wondering if this would be an opportunity to allow for all the parameters to be loaded from the ckpt if it contains them.
There might be possible scenarios which need to be handled though: e.g. if someone provides both a *.ckpt file and a config file, which one takes priority? The config file could take priority, allowing for someone to modify some parameters when resuming the training (example expand trainer.max_time if the reason the training ended was due to the trainer have reached maximum time). But if someone can change those parameters, then what parameters are reported by the logger? If someone changes the learning-rate for instance, which learning rate should be logged? I don't have an answer to that, but it seems these questions could also already be asked today, as it's technically already possible to resume a checkpoint differently and modify some parameters. Currently, no change to the parameters are reported, so first parameters are logged and no new parameters are logged.
Pitch
No response
Alternatives
No response
Additional context
No response
cc @carmocca @mauvilsa

Hi @kotchin
I think the CLI fails to instantiate your LightningDataModule, because it doesn't know what the value for the dataset_dir parameter should be (and it expects it to be in the config file). Would you mind sharing the datamodule implementation, or even better, a small runnable script that shows this error?
What happens if you edit the config file and add the dataset_dir value manually? Does this get you further?

If I run python mainCLI.py fit --ckpt_path /path/to/my/checkpoint.ckpt --print_config it yields the default values for all my parameters instead of the ones actually stored in the ckpt file.
Indeed it doesn't know what the dataset_dir parameter should be, because I haven't given it any default value. This is why I'm proposing to look for those values in the ckpt file, which was generated by a lightning experiment and contains all values for all parameters for the lightning module and the lightning data module.
If I provide a config file, everything works, which is as expected. But then it ignores all config parameters within the ckpt, which may be what we want, but I was wondering and this is what I'm proposing here, if it would be a good idea to attempt at retrieving all provided parameters from the ckpt which does seem to contain everything that's required for the resuming of the experiment?

One solution would be to use a default dataset_dir value and overwrite once the checkpoint gets loaded by implementing load_state_dict

@carmocca Thanks for your input:
overwrite once the checkpoint gets loaded by implementing the load_state_dict()
Is this done automatically, or does it require a manual intervention?
Digging more into it, it seems a config file is necessary for the LightningCLI to start, but that the end values used are in fact not from the config file but from the checkpoint file, meaning that while all the content of the config file needs to be present to make a hypothetical instantiation of the lightning module and lightning data module, the end result of the instances is following the content of what is defined in the checkpoint, is this understanding correct?

the end result of the instances is following the content of what is defined in the checkpoint, is this understanding correct?

Yes!

does it require a manual intervention?

You need to override this hook in your DataModule: https://pytorch-lightning.readthedocs.io/en/stable/api/pytorch_lightning.core.LightningDataModule.html#pytorch_lightning.core.LightningDataModule.load_state_dict

Thank you for your prompt reply.
In my case, I am working with LightningCLI and I want to reload model weights only and set all other parameters of the LightningModule (and LightningDataModule) with the attributes as defined in the config file, is there a recommended approach for this or is it out of scope for Lightning?


Automated cherry pick of #9808: fix(region): aws elb backendgroup sync bugfix

Cherry pick of #9808 on release/3.7.
#9808: fix(region): aws elb backendgroup sync bugfix

Codecov Report

Merging #9809 (f628f3f) into release/3.7 (0ff3997) will increase coverage by 9.97%.
The diff coverage is 100.00%.

@@               Coverage Diff                @@
##           release/3.7    #9809       +/-   ##
================================================
+ Coverage         5.98%   15.96%    +9.97%
================================================
  Files              848      124      -724
  Lines           131795    12786   -119009
================================================
- Hits              7887     2041     -5846
+ Misses          123206    10554   -112652
+ Partials           702      191      -511

Flag
Coverage Δ

aFlag
15.96% <100.00%> (+9.97%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/mcclient/modules/monitor/suggestsysrule.go
100.00% <100.00%> (ø)

pkg/compute/models/cloudsyncelb.go

pkg/compute/models/hostwires.go

pkg/cloudcommon/notifyclient/notify.go

pkg/util/fileutils2/blkid.go

pkg/mcclient/options/k8s/service.go

pkg/keystone/models/user_group_memberships.go

pkg/compute/models/loadbalancerbackendgroups.go

pkg/cloudprovider/waitstatus.go

pkg/compute/models/globalvpcs.go

... and 711 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8228a32...f628f3f. Read the comment docs.

Codecov Report

Merging #9809 (f628f3f) into release/3.7 (0ff3997) will increase coverage by 9.97%.
The diff coverage is 100.00%.

@@               Coverage Diff                @@
##           release/3.7    #9809       +/-   ##
================================================
+ Coverage         5.98%   15.96%    +9.97%
================================================
  Files              848      124      -724
  Lines           131795    12786   -119009
================================================
- Hits              7887     2041     -5846
+ Misses          123206    10554   -112652
+ Partials           702      191      -511

Flag
Coverage Δ

aFlag
15.96% <100.00%> (+9.97%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/mcclient/modules/monitor/suggestsysrule.go
100.00% <100.00%> (ø)

pkg/compute/models/cloudsyncelb.go

pkg/compute/models/hostwires.go

pkg/cloudcommon/notifyclient/notify.go

pkg/util/fileutils2/blkid.go

pkg/mcclient/options/k8s/service.go

pkg/keystone/models/user_group_memberships.go

pkg/compute/models/loadbalancerbackendgroups.go

pkg/cloudprovider/waitstatus.go

pkg/compute/models/globalvpcs.go

... and 711 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8228a32...f628f3f. Read the comment docs.

/lgtm
/approve

/lgtm
/approve


Adjust reference new capacity and activity for soft constraints

Adjust reference new capacity and activity for soft constraints. This PR supersedes #393 and includes the GAMS code modifications from that PR.
How to review

Read the diff and note that the CI checks all pass.

PR checklist

[x] Add or expand tests; coverage checks both ✅
[x] Add, expand, or update documentation.
[x] Update release notes.

Thanks! If the other PR is superseded, please close it with a comment like “Superseded by #474”.

@volker-krey I have added the required documentation of the GAMS code, added a tutorial on the usage of soft-constraints and I have also added test to ensure the relaxation works as expected. Please have a look and let me know if further adjustments are required.

@danielhuppmann and @volker-krey, all the suggestions from Daniel have been incorporated in the revisions I just made. The test example has now been simplified, costs are added and checked based on the COST_NODAL value in addition to the Objective function.

@khaeru and @LauWien rebased, approved, ready to merge unless anything else needs changing?

@khaeru and @LauWien rebased, approved, ready to merge unless anything else needs changing?

I'd just run the tests again and then merge it when every test passes, since the two failed tests appear to be flaky.

@LauWien all test have passed.


3 policies are listed, but text says "these two policies"

"these two policies" in https://docs.microsoft.com/en-us/microsoft-365/security/top-security-tasks-for-remote-work?view=o365-worldwide#1-enable-azure-ad-multi-factor-authentication-mfa should be changed to "these three policies", as 3 policies are listed:

Require MFA when sign-in risk is medium or high
Block clients that don't support modern authentication
High risk users must change password

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: bab2c963-204e-0e1d-8b1e-5909f7ef4d7d
Version Independent ID: 3229ebe7-858c-76e2-40c6-c98387f4a685
Content: Top 12 tasks for security teams to support working from home
Content Source: microsoft-365/security/top-security-tasks-for-remote-work.md
Product: m365-security
Technology: m365d
GitHub Login: @BrendaCarter
Microsoft Alias: bcarter

Thank you @rafalfitt for raising this to our attention. I have updated the article and you will see the update live later today. Thank you for helping us improve the quality of our documentation!


Integrated openwisp-utils

Coverage decreased (-36.8%) to 59.633% when pulling da71a8eef5a12deb1252def1367c7b3515522e07 on rohithasrk:utils-integrate into 5ea831c98b0a6de5972b61e2039cada9e47a786e on openwisp:master.

Coverage increased (+3.6%) to 100.0% when pulling e832c1605dbadc711a795b3156e554f8989ba41b on rohithasrk:utils-integrate into 5ea831c98b0a6de5972b61e2039cada9e47a786e on openwisp:master.

Coverage increased (+3.3%) to 100.0% when pulling d67f09b879ae62dcb831bd827d43ad1b049dc596 on rohithasrk:utils-integrate into fc38339f45a8a5b89405131dc8c1cd002d8c1d52 on openwisp:master.


Insufficient gem dependency for numo/narray

source 'https://rubygems.org'
gem 'charty', '0.2.1'

$ ruby -v
ruby 2.7.0p0 (2019-12-25 revision 647ee6f091) [x86_64-linux]
$ bundle exec ruby -e "require 'charty'"
Traceback (most recent call last):
        5: from -e:1:in `<main>'
        4: from -e:1:in `require'
        3: from /home/k0kubun/.rbenv/versions/2.7.0/lib/ruby/gems/2.7.0/gems/charty-0.2.1/lib/charty.rb:12:in `<top (required)>'
        2: from /home/k0kubun/.rbenv/versions/2.7.0/lib/ruby/gems/2.7.0/gems/charty-0.2.1/lib/charty.rb:12:in `require_relative'
        1: from /home/k0kubun/.rbenv/versions/2.7.0/lib/ruby/gems/2.7.0/gems/charty-0.2.1/lib/charty/palette.rb:1:in `<top (required)>'
/home/k0kubun/.rbenv/versions/2.7.0/lib/ruby/gems/2.7.0/gems/charty-0.2.1/lib/charty/palette.rb:1:in `require': cannot load such file -- numo/narray (LoadError)

Is this intentional?

It is intentional that we don't put numo-narray in the runtime dependencies because we want to support JRuby completely in the future.
But, it isn't intentional that numo-narray is loaded just when charty is loaded.
I'll fix it.

@k0kubun I've released version 0.2.3.  This version doesn't require numo-narray.


Add KNN Support to Point Cloud Operators

KNN support is needed as an alternative to a fixed radius in the RBF operators. The RBF interface has been updated for this work via issue #38. Work is happening via pull request #52.
The steps are:

[x] Expose a KNN vs. fixed radius option in the search parameter list.

[x] Hook into KNN search option. For now will search for KNN+1 to calculate a radius. If were to use KNN to calculate the distance then we would not get a contribution from the farthest point in the support group.

[x] Update the usage of the RBFs in the operators to either use the fixed radius or to calculate the radius on the fly. The calculated radius will be the euclidean distance between the point of interest and the KNN+1 neighbor.

[x] Ensure point cloud operator unit tests are passing.

This has been completed via additional work to PR #52. Passing to Damien for review.
We need to talk about 2 things in the review

The choice of kNN+1 for calculating the support radius
The means by which I choose to do the coarse parallel search. If using a fixed radius, then we just expand all of the local bounding boxes by the radius and do the search. This ensures that we get all points in the kD-tree that might end up in a support radius. For kNN, this is not clear - any distance is possible. To solve this, I expand the local box by 10% assuming some reasonable domain decomposition. Obviously this is arbitrary and affects performance.

Fixed in PR #52


[WIP] Attaching volume to OpenTofu runner to read https certs

This PR will mount cert path to opentofu-runner worker deployment by reading certs from secret application-certificate-secret

@bdunne Please review.


Address review comments from PR #21660.

Fixes https://github.com/project-chip/connectedhomeip/issues/22352
Problem
Un-addressed review issue.
Change overview
Address it.
Testing
No behavior changes.

Accepted for 1.0 as a fix from an already merged PR.


Additional check to handle BAD SSL_write retry, in master branch

New check is added in in ssl3_write_bytes, to handle ssl3_write_bytes failure.
If SSL_write is called after failure with smaller buffer length (smaller than overall length, but bigger than tot), then after ssl3_write_pending we are doing "n = (len - tot)". This will give a value close to 2^32 to n. Then this will cause ABR to application buffer.

CLA received! "need-cla" removed from this and your other PRs.

Who ever pushes to master should squash the commits into a single one.

merged/squashed.  okay for 1.1.0?

Different PRs for 1.1.0 and 1.0.2. See (#3123 and #3122)

oh yeah, right.  cbbe918 in master.  off to squash/merge the others now.


v-if render  if haven't v-else

What problem does this feature solve?
When using v-if, <!----> is rendered if it is not fulfilled and no haven't v-else, this causes problems if you are using properties like previousSibling, nextSibling, since these <!----> are counted as elements of the DOM
What does the proposed API look like?
Without <!---->

This would be more inconsistent if removed as you would have different number of children in different positions at each render.
Please provide a reproduction when filing issues like this, it is difficult to understand context. Furthermore, I'm not sure why you need to go that deep into the DOM API when you could use ref API or many other features.


idea: Write a kernel driver via OpenDAL for fun

As the title suggests, this issue is purely for fun, and I'm not sure if it will be useful or not. Nevertheless, I find the idea intriguing and think it's worth exploring.

Sounds interesting.

What does "kernel driver" mean here?

What does "kernel driver" mean here?

linux kernel modules


[SPARK-25402][SQL][BACKPORT-2.2] Null handling in BooleanSimplification

What changes were proposed in this pull request?
This PR is to fix the null handling in BooleanSimplification. In the rule BooleanSimplification, there are two cases that do not properly handle null values. The optimization is not right if either side is null. This PR is to fix them.
How was this patch tested?
Added test cases

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3054/
Test PASSed.

Test build #95999 has started for PR 22403 at commit 7088371.

Test build #95999 has finished for PR 22403 at commit 7088371.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95999/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3082/
Test PASSed.

Test build #96033 has started for PR 22403 at commit ec43727.

Test build #96033 has finished for PR 22403 at commit ec43727.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96033/
Test PASSed.

Merged to branch-2.2.


Lack of details on MountFlags and its usage with containerd in "Volumes" page

No details about mountflags and how to set that up using containerd only details around docker

/retitle Lack of details on MountFlags and its usage with containerd in "Volumes" page

/retitle Lack of details on MountFlags and its usage with containerd in "Volumes" page

/sig docs
/kind feature

Can I work on this, if this issue is being triage accepted

/sig storage
/triage accepted
(anyone is welcome to work on this - we have a “no cookie licking” policy in SIG Docs)
If someone has said they plan to work on an issue, and you're also considering that work, it's polite - but not mandatory - to try to co-ordinate.

I think the fix we should make is to remove https://kubernetes.io/docs/concepts/storage/volumes/#configuration - it's out of date and also doesn't belong as part of the conceptual explanation of what a volume is.

/assign

/close

Sure @iArchitSharma , this issue can be closed

/close