Added support for remote hybrid properties filters

Fixes #1345
Changes:

Updated hybrid property detection: added support for period-delimited column name - what it does is figure out if the last attribute on the last model is a hybrid property.
Added the key attribute to hybrid properties (this field is not automatically populated by sqlalchemy for hybrid properties, for some reason), which is used by flask-admin to determine the column name.
Prettifying the filter name for nested properties.
Removed unused method get_association_proxy_column_name I added in a previous PR (sorry!)

I can no longer run Flask-Admin, after something that was added in commit 47080aeb1ffee4ea5cfd3254c18209ea9b4a04ae. I get the following error:
[...]
File "/venv/lib/python3.5/site-packages/flask_admin/contrib/sqla/view.py", line 330, in __init__
    menu_icon_value=menu_icon_value)
  File "/venv/lib/python3.5/site-packages/flask_admin/model/base.py", line 771, in __init__
    self._refresh_cache()
  File "/venv/lib/python3.5/site-packages/flask_admin/model/base.py", line 890, in _refresh_cache
    self._refresh_filters_cache()
  File "/venv/lib/python3.5/site-packages/flask_admin/model/base.py", line 799, in _refresh_filters_cache
    self._filters = self.get_filters()
  File "/venv/lib/python3.5/site-packages/flask_admin/model/base.py", line 1098, in get_filters
    flt = self.scaffold_filters(n)
  File "/venv/lib/python3.5/site-packages/flask_admin/contrib/sqla/view.py", line 618, in scaffold_filters
    is_hybrid_property = tools.is_hybrid_property(self.model, name)
  File "/venv/lib/python3.5/site-packages/flask_admin/contrib/sqla/tools.py", line 205, in is_hybrid_property
    return last_name in get_hybrid_properties(last_model)
  File "/venv/lib/python3.5/site-packages/flask_admin/contrib/sqla/tools.py", line 188, in get_hybrid_properties
    for key, prop in inspect(model).all_orm_descriptors.items()
  File "/venv/lib/python3.5/site-packages/sqlalchemy/inspection.py", line 75, in inspect
    type_)
sqlalchemy.exc.NoInspectionAvailable: No inspection system is available for object of type <class 'function'>

I'm running SQLAlchemy==1.1.0b3. The model that raises the exception is a plain SQLAlchemy model. (Not using Flask-Alchemy).

Are you using the latest flask-admin master?
Can you provide a sample model and admin view that doesn't work?

Yup, latest master. I'll try to create a reproducible test case.

I believe this PR adds a dependency (speaklater) without adding it to the setup. As a result, using the master tip as is doesn't work. Is it expected to be installed seperatly ?

I think you're right.
I used it since I saw it being used in a test, but apparently it's a tests-only dependency.
It's being used as part of flask-babelex, which is a dependency of this project, however this is the first time it's being explicitly.
 I don't see an obvious workaround regarding this, but I'm open for suggestions.

I'd just add it as a dependency to the setup.py?


no release is available in Maven Central

Would be great to release the first version, even if it's not complete yet

@volodya-lombrozo ping...

@yegor256 I see, I will do it


Drag a copy

Hi
Is there a way to drag and drop a copy of an element inside a sortable like on this http://plnkr.co/edit/aSOlqR0UwBOXgpQSFKOH?p=preview
Thanks

@ZeGregg please check #3 and see If this helps.


rolling_update: remove 'ignore_errors'

There's no need to use ignore_errors: true on these tasks.
Using a loop on the task stopping mon daemons allows us to avoid
duplicating this task, the ignore_errors isn't needed here because it
won't fail the playbook if one of the ID doesn't exist (shortname vs. fqdn)
Using the right condition on the task starting the mgr daemon allows us
to avoid using an ignore_errors: true as well.
Signed-off-by: Guillaume Abrioux<EMAIL_ADDRESS>

jenkins test centos-non_container-update

jenkins test centos-container-update


Load example databases if no ?url= or ?csv= passed

By default it should load the two example databases that I talk about in https://simonwillison.net/2022/May/4/datasette-lite/
Currently it loads no databases at all and just gives you _memory:

I broke this in:

#32

Fixed.


*: add protection against unlimited log growth(#131)

Add protection against uncommitted log growth of leader.
This protection is done by estimate size of entry data
rather than count of entry. So entry with no data will
never be dropped
Add tests for raft and raw_node
fix wrong clippy command in CONTRIBUTING.md
close #131

Signed-off-by: lyzongyuan<EMAIL_ADDRESS>

keep PR up-to-date with master. @NingLin-P PTAL

Thank you! @DanteLee It will be helpful to have this protection.

@NingLin-P Done, PTAL. I'm new to rustlang and the project. Thanks for the comments so far.

Any update? @DanteLee

Any update? @DanteLee

Sorry for the delay. Focus on company these days. But i think i can submit a fix today.

@NingLin-P Done, PTAL :P

@NingLin-P Done ^_^

@BusyJay PTAL

@BusyJay Friendly ping, PTAL

@BusyJay PTAL :)

@BusyJay PTAL

@NingLin-P PTAL


Work on GitHub integration

Pull Request Test Coverage Report for Build 741829179

75 of 95 (78.95%)  changed or added relevant lines in 4 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.6%) to 70.534%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

lib/vagrant-libvirt/action/create_domain_volume.rb
30
32
93.75%

lib/vagrant-libvirt/action/handle_box_image.rb
41
49
83.67%

lib/vagrant-libvirt/action/create_domain.rb
2
12
16.67%

Totals

Change from base Build 686786237:
0.6%

Covered Lines:
1295

Relevant Lines:
1836

💛  - Coveralls


Docs: Add links to the examples directory

Codecov Report
Base: 93.21% // Head: 93.21% // No change to project coverage :thumbsup:

Coverage data is based on head (b318478) compared to base (c5c5444).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #58   +/-   ##
=======================================
  Coverage   93.21%   93.21%
=======================================
  Files          24       24
  Lines         973      973
=======================================
  Hits          907      907
  Misses         66       66

Flag
Coverage Δ

pytests
93.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Replace defaced images

Pushed data to old branch the correct branch is af/fix_defaced_images. Will push data to https://github.com/spine-generic/data-multi-subject/pull/119.


Font render shifted (displacement)

See below url:
http://mozilla.github.io/pdf.js/web/viewer.html?file=http://7xkeim.com1.z0.glb.clouddn.com/20150827143655-166.pdf
Platform: Windows XP SP3(32Bit) + Chrome 44.0.2403.125 m
Problem:

The highlighted line contains text:<PHONE_NUMBER>0 when pasted to notepad, but the highlight area shifted to left.

Seems to be better now, but still not perfect.
https://www.dropbox.com/s/a6j7mdq1r6otytq/Screenshot 2015-12-15 11.31.37.png?dl=0

Closing since the file is no longer available and text layer fixes were made in the meantime.


🚀 Demonstração de deploy

Codecov Report

Merging #9 (28505ea) into master (9b30d07) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master        #9   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           18        18
  Lines           76        76
  Branches         6         6
=========================================
  Hits            76        76

Impacted Files
Coverage Δ

components/organisms/Footer.js
100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b30d07...28505ea. Read the comment docs.


Revert "NFDIV-3824 - Lock down cases in bulk list flow"

As a precaution i'm creating a revert PR ready to go if anything fails with this and it needed to be pulled out.
Reverts hmcts/nfdiv-case-api#3400

PR went well. Closing as not needed.


Any demo？

Hey, could you please update some video results in the readme?

Hey, could you please update some video results in the readme?

Please refer to https://jdh-algo.github.io/JoyVASA/


Add description of Author

a professional introduction to the student of between 300 to 1000 words, focusing on professional background and skills (personal/non-professional interests are not prohibited, but should not be the focus)

This is about done, needs more specifics on languages and skills.
Python, pytorch, sklearn, fastAPI, Classification etc.

Skills section added, text spellchecked and wordcounted at ~400 words


Fix hang after calling SaeTrainer.save() w/ DDP

While trying to train with DDP on an 8xA100 node with default arguments...
torchrun --nproc_per_node gpu -m sae EleutherAI/pythia-160m togethercomputer/RedPajama-Data-1T-Sample --attn_implementation=eager

...the trainer hangs after saving--the layers are successfully saved, but afterwards the trainer doesn't make progress and stays stuck on iteration 999.
Running with TORCH_DISTRIBUTED_DEBUG=DETAIL, when a normal run would've hung, the trainer instead crashes with a process desync exception, saying rank 0 is in a barrier while the others have moved on to reduce. (Unfortunately I didn't save the exact exception, if it'd be useful I can undo my fix and get it.)
I believe the error is in trainer.py:save:
https://github.com/EleutherAI/sae/blob/2cc21c8ad11140209c725de68219ccfc5cea2c18/sae/trainer.py#L296-L309
The first if causes the other processes to leave the function immediately, so only rank 0 hits the barrier, causing the desync. After changing save to remove the early return, so that all processes reach dist.barrier(), training now passes the savepoint without issue.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Remove unnecessary console.error statement

Codecov Report

Merging #11043 (9e4f422) into main (fafa651) will decrease coverage by 0%.
The diff coverage is n/a.

@@          Coverage Diff           @@
##            main   #11043   +/-   ##
======================================
- Coverage     63%      63%   -1%
======================================
  Files        482      482
  Lines      33821    33832   +11
  Branches    5512     5513    +1
======================================
- Hits       21378    21360   -18
- Misses     10412    10430   +18
- Partials    2031     2042   +11

Impacted Files
Coverage Δ

src/kernels/jupyter/jupyterUtils.ts
70% <ø> (-1%)
:arrow_down:

src/notebooks/debugger/debugger.ts
66% <0%> (-12%)
:arrow_down:

src/kernels/execution/notebookUpdater.ts
88% <0%> (-8%)
:arrow_down:

src/notebooks/outputs/tracebackFormatter.ts
93% <0%> (-7%)
:arrow_down:

src/platform/common/cancellation.ts
62% <0%> (-6%)
:arrow_down:

src/notebooks/debugger/debuggingManagerBase.ts
69% <0%> (-6%)
:arrow_down:

src/platform/common/utils/misc.ts
78% <0%> (-5%)
:arrow_down:

src/platform/common/process/baseDaemon.node.ts
50% <0%> (-4%)
:arrow_down:

src/kernels/jupyter/baseKernelConnectionWrapper.ts
35% <0%> (-3%)
:arrow_down:

src/kernels/jupyter/jupyterKernelService.node.ts
74% <0%> (-2%)
:arrow_down:

... and 13 more


Datasource.updated_at - Did it change from 2.2 to 2.4 rest api?

I upgraded to Tableau 10.1, which i believe is rest api 2.4, and also downloaded the latest TableauServerClient module, and it looks like the datasource updated_at previously contained the maximum value between the modified date (versioning of extract) and the update date (when an extract last refreshed) for example.
Is this a known change? I couldn't find any documentation on the rest api that called that out. I was relying on the datasource.updated_at to be the combo to cover events where i knew whether a datasource was re-published or whether a datasource was last refreshed (in the case on an extract).
Any information would be super helpful, and thanks.
Paul

Strange thing is that I was able to change the api version setting to 2.3, and it still work on Tableau Server 10.1 and also for the modified/updated to be correct. So, everything works fine using the 2.3 rest api version.

Sorry, I missed this one!  I'll dig into it when I have a moment.

Thanks Russell!
On Thu, Feb 23, 2017 at 11:31 AM, Russell Hay<EMAIL_ADDRESS>wrote:

Sorry, I missed this one! I'll dig into it when I have a moment.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/tableau/server-client-python/issues/132#issuecomment-282062357,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHCRmlZe_Fbl8LrQlNvk4StxV8qn91wEks5rfcJ2gaJpZM4Lp2ai
.

weird.  The code path for this one doesn't vary based on rest version, so I have no idea how the behavior you are seeing is possible.  I'm going to try to repro it locally to see what's going on.
If you had a fiddler trace for both requests (2.4 vs. 2.3) where you are seeing the issue, that might speed up my investigation

Russell,
Let me test this again just to make sure then. I'll respond soon.
Thanks.
Paul
On Mon, Apr 10, 2017 at 1:15 PM, Russell Hay<EMAIL_ADDRESS>wrote:

weird. The code path for this one doesn't vary based on rest version, so I
have no idea how the behavior you are seeing is possible. I'm going to try
to repro it locally to see what's going on.
If you had a fiddler trace for both requests (2.4 vs. 2.3) where you are
seeing the issue, that might speed up my investigation
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/tableau/server-client-python/issues/132#issuecomment-293033885,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHCRmgEhP6P36mlQCr05OrW3Nvnrp_MGks5runHWgaJpZM4Lp2ai
.

Closing 2yo issue.  Please reopen if still an issue.


Improve overall code / test quality

Problem
In recent 5 checks on master branch, the cirque tests
Break 1 times on OnOff test
Break 3 times on Echo test
Break 1 times on MobileDevice test (#5679)
After reviewing the logs

The OnOff cluster test breaks on:

2021-03-29 14:38:33,260 [CHIPOnOffTest] INFO device: CHIP-Tool(7225390b...) exec: chip-tool onoff on 1
2021-03-29 14:38:33,342 [CHIPOnOffTest] INFO command return code: 1
2021-03-29 14:38:33,342 [CHIPOnOffTest] INFO command output:
CHIP:ZCL: Using ZAP configuration...
CHIP:ZCL: deactivate report event
CHIP:IN: TransportMgr initialized
CHIP:IN: local node id is 0x000000000001b669
CHIP:ZCL: Using ZAP configuration...
CHIP:ZCL: deactivate report event
CHIP:DL: CHIP task running
CHIP:TOO: Init failure! No pairing for device: 112233
CHIP:CTL: Shutting down the commissioner
CHIP:CTL: Shutting down the controller
CHIP:DL: System Layer shutdown
CHIP:DL: Inet Layer shutdown
CHIP:DL: BLE layer shutdown
CHIP:TOO: Run command failure: CHIP Error 4072 (0x00000FE8): Not connected

Mobile device crashed on

Segmentation fault (core dumped)
*** Segmentation fault
Register dump:

 RAX: 2d8292e87f8d12bd   RBX:<PHONE_NUMBER>18a680   RCX:<PHONE_NUMBER>000000
 RDX:<PHONE_NUMBER>000000   RSI:<PHONE_NUMBER>000000   RDI:<PHONE_NUMBER>18d568
 RBP: 00007f54377fd700   R8 : 00007f5447951f6d   R9 :<PHONE_NUMBER>00001e
 R10: 00007f5447a58070   R11:<PHONE_NUMBER>000000   R12:<PHONE_NUMBER>18d618
 R13:<PHONE_NUMBER>000000   R14:<PHONE_NUMBER>000001   R15:<PHONE_NUMBER>000000
 RSP: 00007f54377fd6f0

 RIP: 00007f54479b26e4   EFLAGS: 00010202

 CS: 0033   FS: 0000   GS: 0000

 Trap: 0000000d   Error: 00000000   OldMask: 00000000   CR2: 00000000

 FPUCW: 0000037f   FPUSW: 00000000   TAG: 00000000
 RIP: 00000000   RDP: 00000000

 ST(0) 0000<PHONE_NUMBER>000000   ST(1) 0000<PHONE_NUMBER>000000
 ST(2) 0000<PHONE_NUMBER>000000   ST(3) 0000<PHONE_NUMBER>000000
 ST(4) 0000<PHONE_NUMBER>000000   ST(5) 0000<PHONE_NUMBER>000000
 ST(6) 0000<PHONE_NUMBER>000000   ST(7) 0000<PHONE_NUMBER>000000
 mxcsr: 1fa0
 XMM0:<PHONE_NUMBER>0000000000000025252525 XMM1:<PHONE_NUMBER>0000000000000025252525
 XMM2:<PHONE_NUMBER>0000000000000025252525 XMM3:<PHONE_NUMBER>0000000000000025252525
 XMM4:<PHONE_NUMBER>0000000000000025252525 XMM5:<PHONE_NUMBER>0000000000000025252525
 XMM6:<PHONE_NUMBER>0000000000000025252525 XMM7:<PHONE_NUMBER>0000000000000025252525
 XMM8:<PHONE_NUMBER>0000000000000025252525 XMM9:<PHONE_NUMBER>0000000000000025252525
 XMM10:<PHONE_NUMBER>0000000000000025252525 XMM11:<PHONE_NUMBER>0000000000000025252525
 XMM12:<PHONE_NUMBER>0000000000000025252525 XMM13:<PHONE_NUMBER>0000000000000025252525
 XMM14:<PHONE_NUMBER>0000000000000025252525 XMM15:<PHONE_NUMBER>0000000000000025252525

Backtrace:
/usr/local/lib/python3.8/dist-packages/chip/_ChipDeviceCtrl.so(_ZN4chip17RendezvousSession11UpdateStateENS0_5StateEi+0x184)[0x7f54479b26e4]

EchoTest failed on

2021-03-29 20:42:26,096 [CHIPEchoTest] INFO device: CHIP-Echo-Requester(04ff2146...) exec: chip-echo-requester <IP_ADDRESS>
2021-03-29 20:42:26,574 [CHIPEchoTest] INFO command return code: 134
2021-03-29 20:42:26,574 [CHIPEchoTest] INFO command output:
Init CHIP Stack
CHIP:DL: writing settings to file (/tmp/chip_factory.ini.tmp)
CHIP:DL: renamed tmp file to file (/tmp/chip_factory.ini)
CHIP:DL: writing settings to file (/tmp/chip_config.ini.tmp)
CHIP:DL: renamed tmp file to file (/tmp/chip_config.ini)
CHIP:DL: writing settings to file (/tmp/chip_counters.ini.tmp)
CHIP:DL: renamed tmp file to file (/tmp/chip_counters.ini)
CHIP:DL: CHIP task running
CHIP:IN: TransportMgr initialized
CHIP:IN: local node id is 0x000000000001b669
CHIP:IN: New pairing for device 0x0000000000bc5c01, key 0!!
Establish secure session succeeded

Send echo request message to Node: 12344321
CHIP:IN: Secure message was encrypted: Msg ID 0
CHIP:IN: Sending msg from 0x000000000001b669to 0x0000000000bc5c01
CHIP:IN: Sending secure msg on generic transport
CHIP:IN: Secure msg send status 0
CHIP:EM: Rxd Ack; Removing MsgId:00000000 from Retrans Table
CHIP:EM: Removed CHIP MsgId:00000000 from RetransTable
CHIP:EM: Piggybacking Ack for MsgId:00000000 with msg

2021-03-29 20:42:26,574 [CHIPEchoTest] ERROR Echo failure: Init CHIP Stack
CHIP:DL: writing settings to file (/tmp/chip_factory.ini.tmp)
CHIP:DL: renamed tmp file to file (/tmp/chip_factory.ini)
CHIP:DL: writing settings to file (/tmp/chip_config.ini.tmp)
CHIP:DL: renamed tmp file to file (/tmp/chip_config.ini)
CHIP:DL: writing settings to file (/tmp/chip_counters.ini.tmp)
CHIP:DL: renamed tmp file to file (/tmp/chip_counters.ini)
CHIP:DL: CHIP task running
CHIP:IN: TransportMgr initialized
CHIP:IN: local node id is 0x000000000001b669
CHIP:IN: New pairing for device 0x0000000000bc5c01, key 0!!
Establish secure session succeeded

Send echo request message to Node: 12344321
CHIP:IN: Secure message was encrypted: Msg ID 0
CHIP:IN: Sending msg from 0x000000000001b669to 0x0000000000bc5c01
CHIP:IN: Sending secure msg on generic transport
CHIP:IN: Secure msg send status 0
CHIP:EM: Rxd Ack; Removing MsgId:00000000 from Retrans Table
CHIP:EM: Removed CHIP MsgId:00000000 from RetransTable
CHIP:EM: Piggybacking Ack for MsgId:00000000 with msg

Traceback (most recent call last):
  File "/home/runner/work/connectedhomeip/connectedhomeip/src/test_driver/linux-cirque/helper/CHIPTestBase.py", line 62, in run_test
    self.test_routine()
  File "/home/runner/work/connectedhomeip/connectedhomeip/src/test_driver/linux-cirque/test-echo.py", line 64, in test_routine
    self.run_data_model_test()
  File "/home/runner/work/connectedhomeip/connectedhomeip/src/test_driver/linux-cirque/test-echo.py", line 79, in run_data_model_test
    self.assertEqual(
  File "/home/runner/work/connectedhomeip/connectedhomeip/src/test_driver/linux-cirque/helper/CHIPTestBase.py", line 222, in assertEqual
    raise AssertionError
AssertionError

Proposed Solution
These error are not caused by the tests, but the code, we should fix the code to resolve these issues.
Also, these failure does not happen every time, so please rerun it if it is failed

When using gdb for backtrace:
2021-03-30 09:10:09,830 [CHIPMobileDevice] INFO Device finished key exchange.
2021-03-30 09:10:09,831 [CHIPMobileDevice] INFO Commissioning network to device 1
CHIP:ZCL: Successfully encoded 11 bytes
CHIP:IN: Connection from 'UNDEFINED' expired
CHIP:CTL: OnConnectionExpired was called for unknown device, ignoring it.
CHIP:IN: New pairing for device 0x0000000000000001, key 0!!
CHIP:IN: Secure message was encrypted: Msg ID 0
CHIP:IN: Sending msg from 0x000000000001b669to 0x0000000000000001
CHIP:IN: Sending secure msg on generic transport
CHIP:IN: Secure msg send status 0
CHIP:CTL: SendMessage returned 0
CHIP:CTL: AsyncSetKeyValue: ListPairedDevices0=AQAAAAAAAAA=
CHIP:CTL: AsyncSetKeyValue: StartKeyID=1

Thread 9 "python3" received signal SIGSEGV, Segmentation fault.
[Switching to Thread 0x7fefd8ff9700 (LWP 49)]
chip::RendezvousSession::UpdateState (this=0x14be4b0,
    newState=chip::RendezvousSession::kRendezvousComplete, err=0)
    at ../../../../../src/transport/RendezvousSession.cpp:298
298	../../../../../src/transport/RendezvousSession.cpp: No such file or directory.
#0  chip::RendezvousSession::UpdateState(chip::RendezvousSession::State, int)
    (this=0x14be4b0, newState=chip::RendezvousSession::kRendezvousComplete, err=0) at ../../../../../src/transport/RendezvousSession.cpp:298
#1  0x00007fefe1366f55 in chip::RendezvousSession::OnSessionEstablished()
    (this=0x14be4b0) at ../../../../../src/transport/RendezvousSession.cpp:207
#2  0x00007fefe136593b in chip::PASESession::HandleMsg2_and_SendMsg3(chip::PacketHeader const&, chip::System::PacketBufferHandle const&) (this=
    0x14be598, header=..., msg=...)
    at ../../../../../src/transport/PASESession.cpp:689
#3  0x00007fefe1365ebd in chip::PASESession::HandlePeerMessage(chip::PacketHeader const&, chip::Transport::PeerAddress const&, chip::System::PacketBufferHandle) (this=0x14be598, packetHeader=..., peerAddress=..., msg=...)
    at ../../../../../src/transport/PASESession.cpp:810
#4  0x00007fefe136765e in chip::RendezvousSession::HandlePairingMessage(chip::PacketHeader const&, chip::Transport::PeerAddress const&, chip::System::PacketBufferHandle) (this=0x14be4b0, packetHeader=..., peerAddress=..., msgBuf=...)
    at ../../../../../src/transport/RendezvousSession.cpp:391
#5  0x00007fefe13674aa in chip::RendezvousSession::OnRendezvousMessageReceived(chip::PacketHeader const&, chip::Transport::PeerAddress const&, chip::System::PacketBufferHandle)
    (this=0x14be4b0, packetHeader=..., peerAddress=..., msgBuf=...)
    at ../../../../../src/transport/RendezvousSession.cpp:363
#6  0x00007fefe13675bd in chip::RendezvousSession::OnMessageReceived(chip::PacketHeader const&, chip::Transport::PeerAddress const&, chip::System::PacketBufferHandle) (this=0x14be4b0, header=..., source=..., msgBuf=...)
    at ../../../../../src/transport/RendezvousSession.cpp:385
#7  0x00007fefe136b3c6 in chip::TransportMgrBase::HandleMessageReceived(chip::PacketHeader const&, chip::Transport::PeerAddress const&, chip::System::PacketBufferHandle) (this=0x14b2db0, packetHeader=..., peerAddress=..., msg=...)
    at ../../../../../src/transport/TransportMgrBase.cpp:54
#8  0x00007fefe13e1941 in chip::Transport::Base::HandleMessageReceived(chip::PacketHeader const&, chip::Transport::PeerAddress const&, chip::System::PacketBufferHandle&&) (this=0x14b2de0, header=..., source=..., buffer=...)
    at ../../../../../src/transport/raw/Base.h:93
#9  0x00007fefe13e1e8c in chip::Transport::UDP::OnUdpReceive(chip::Inet::IPEndPointBasis*, chip::System::PacketBufferHandle, chip::Inet::IPPacketInfo const*)
    (endPoint=0x7fefe144d1c8 <chip::Inet::UDPEndPoint::sPool+72>, buffer=..., pktInfo=0x7fefd8ff8c30) at ../../../../../src/transport/raw/UDP.cpp:118
#10 0x00007fefe1407cb0 in chip::Inet::IPEndPointBasis::HandlePendingIO(unsigned short) (this=0x7fefe144d1c8 <chip::Inet::UDPEndPoint::sPool+72>, aPort=11097)
    at ../../../../../src/inet/IPEndPointBasis.cpp:1183
#11 0x00007fefe13f63e7 in chip::Inet::UDPEndPoint::HandlePendingIO()
    (this=0x7fefe144d1c8 <chip::Inet::UDPEndPoint::sPool+72>)
    at ../../../../../src/inet/UDPEndPoint.cpp:941
#12 0x00007fefe13f1853 in chip::Inet::InetLayer::HandleSelectResult(int, fd_set*, fd_set*, fd_set*) (this=
    0x7fefe144a780 <chip::DeviceLayer::InetLayer>, selectRes=12, readfds=0x7fefe144aa70 <chip::DeviceLayer::PlatformManagerImpl::sInstance+16>, writefds=0x7fefe144aaf0 <chip::DeviceLayer::PlatformManagerImpl::sInstance+144>, exceptfds=0x7fefe144ab70 <chip::DeviceLayer::PlatformManagerImpl::sInstance+272>)
    at ../../../../../src/inet/InetLayer.cpp:1271
#13 0x00007fefe1344398 in chip::DeviceLayer::Internal::GenericPlatformManagerImpl_POSIX<chip::DeviceLayer::PlatformManagerImpl>::SysProcess()
    (this=0x7fefe144aa60 <chip::DeviceLayer::PlatformManagerImpl::sInstance>)
    at ../../../../../src/include/platform/internal/GenericPlatformManagerImpl_POSIX.cpp:185
#14 0x00007fefe1343e96 in chip::DeviceLayer::Internal::GenericPlatformManagerImpl_POSIX<chip::DeviceLayer::PlatformManagerImpl>::_RunEventLoop()
    (this=0x7fefe144aa60 <chip::DeviceLayer::PlatformManagerImpl::sInstance>)
    at ../../../../../src/include/platform/internal/GenericPlatformManagerImpl_POSIX.cpp:203
#15 0x00007fefe12bd6b2 in chip::DeviceLayer::PlatformManager::RunEventLoop()
    (this=0x7fefe144aa60 <chip::DeviceLayer::PlatformManagerImpl::sInstance>)
    at ../../../../../src/include/platform/PlatformManager.h:204
#16 0x00007fefe13444a3 in chip::DeviceLayer::Internal::GenericPlatformManagerImpl_POSIX<chip::DeviceLayer::PlatformManagerImpl>::EventLoopTaskMain(void*)
    (arg=0x7fefe144aa60 <chip::DeviceLayer::PlatformManagerImpl::sInstance>)
    at ../../../../../src/include/platform/internal/GenericPlatformManagerImpl_POSIX.cpp:214
#17 0x00007fefe2298609 in start_thread (arg=<optimized out>)
    at pthread_create.c:477
#18 0x00007fefe23d4293 in clone ()
    at ../sysdeps/unix/sysv/linux/x86_64/clone.S:95

It is very weird that we received this message at this time.


[FEATURE] Github as source for PDK pipeline

Describe the feature
Provide support for Github as source for PDK pipeline.
Use Case
Code stored in Github
Proposed Solution
No response
Other Information
No response
Acknowledgements

[ ] I may be able to implement this feature request
[ ] This feature might incur a breaking change

PDK version used
0.17.0
What languages will this feature affect?
Typescript
Environment details (OS name and version, etc.)
Macos Arm

Closing as this is already supported. Users can simply provide an "input" as part of synthShellStepPartialProps with a configured github repo.


Store file hashes in DB, check for changes in hashes on startup

Currently if changes are made when the daemon is offline, they won't sync until the file is updated again while the daemon can see it. This can be resolved by simply keeping a database of file hashes, and updating any of the changed files on startup.

Fixed by f12f429e35e8f28d95619cf4a9215b0867eda006


Add support for startOf("decade")

I find the lack of a startOf("decade") function frustrating because there is no simple way to get the date of the start of a decade.
The same way that moment().startOf("week") works and returns the first day of the week, I would like a moment().startOf("decade") which returns the first day of the decade.

If I were to extend moment (plugin), how could I define a 'decade' or a 'century' so that math would work out of the box (add, subtract, startOf, etc). It would seem that I would start with defining a Duration somehow, and I know I would have to extend my prototype to include the proper methods (decade(value?)). Just trying to wrap my head around how I would go about this...


No method named to_string found for struct with from_wasm_abi

no method named `to_string` found for struct `serde_wasm_bindgen::error::Error` in the current scope
items from traits can only be used if the trait is in scope

Example of working code
#[derive(Serialize, Deserialize, Tsify)]
#[serde(rename_all = "camelCase")]
#[tsify(into_wasm_abi)]
pub struct Foo {
  pub value: u128
}

Example of non-working code
#[derive(Serialize, Deserialize, Tsify)]
#[serde(rename_all = "camelCase")]
#[tsify(into_wasm_abi, from_wasm_abi)]
pub struct Foo {
  pub value: u128
}

Looks like the issue is no_std. Any way to get this working without std?


add gcpx

I've added alias gcpx='git cherry-pick -x', but I really feel like gcp should be changed to include the -x.  Made this change to preserve backward compatibility.

Thanks! The git help says that -x should only be added for cherry-picks between two public branches - therefore I think it's good to have it as an optional flag only...


MergeMap  dose not work when build publish to production !

MergeMap  dose not work when build publish to production !
Versions
Versions:
Angular CLI: 1.6.2
Node: 8.9.3
OS: linux x64
Angular: 5.1.2
... animations, common, compiler, compiler-cli, core, forms
... http, language-service, platform-browser
... platform-browser-dynamic, router

@angular/cli: 1.6.2
@angular-devkit/build-optimizer: 0.0.36
@angular-devkit/core: 0.0.22
@angular-devkit/schematics: 0.0.42
@ngtools/json-schema: 1.1.0
@schematics/angular: 0.1.11
@schematics/schematics: 0.0.11
typescript: 2.5.3
webpack: 3.10.0

Repro steps
Observable.of(...this.selectedEntries)
      .mergeMap(entry => {
        return this.orderSerivce
          .delOrderAuthEntry(
            this.orderNumber.toString(),
            entry.MTYPECODE,
            entry.FSEQ
          )
          .map(resp => {
            return { resp: resp, entry: entry };
          });
      })
      .subscribe(
        ret => {
           console.log("success")
        },
        err => {
          console.log("error");
        }
      );

Observed behavior

In develop enviroment It works ok ,print success , but after build to prod enviroment always print errror

The chrome console errorlog is :
e.orderSerivce.delOrderAuthEntry(...).map is not a function
    at t.project (main.851870d7df43a0fbca22.bundle.js:1)
    at t._tryNext (main.851870d7df43a0fbca22.bundle.js:1)
    at t._next (main.851870d7df43a0fbca22.bundle.js:1)
    at t.next (main.851870d7df43a0fbca22.bundle.js:1)
    at t._subscribe (main.851870d7df43a0fbca22.bundle.js:1)
    at t.e._trySubscribe (main.851870d7df43a0fbca22.bundle.js:1)
    at t.e.subscribe (main.851870d7df43a0fbca22.bundle.js:1)
    at e.call (main.851870d7df43a0fbca22.bundle.js:1)
    at e.subscribe (main.851870d7df43a0fbca22.bundle.js:1)
    at e.delAuth (main.851870d7df43a0fbca22.bundle.js:1)

Desired behavior

Mention any other details that might be useful (optional)

Are you importing mergeMap on that file? When you use the patching style of RxJS imports (import 'rxjs/add/operator/mergeMap';) it is important to import them on ALL files that use the operators.
If you don't you can get missing operator errors. These errors happen in dev but not in prod because prod has build optimizations that drop code. When you don't import the operators on all files that use them, you rely on the operators being loaded on other files that may not be used on your application in production.
If you are importing the operator on that file and still see the error, please upload a reproduction that we can follow and I will reopen the issue.


RNN results not reproducible

Hello,
Thanks for open sourcing the code.
After your commit:
https://github.com/melodyguan/enas/commit/2734eb2657847f090e1bc5c51c2b9cbf0be51887
I get 63.26 in ppl and not the 55.6 stated in the paper. However before this commit I get 55.6. Is there something I am missing?
Thanks

Hi,
Thanks for your interest. Commit 2734eb2 fixed a bug in the evaluation process. After the fix, we had to further tune the model's hyper-parameters to reach a good performance. The best number we could reach was 56.3. We have updated the paper and will soon role out a commit to fix the bug in the code.

Could you update the ptb_final.sh script to use the architecture and hyperparameters you used to get to the 56.3 perplexity reported in the paper?  Thanks!


GET 404 (Not Found) error - Routing doesn't work

So I've made an app which was working great but then I've figured out that menubar on top with two links would be ok so I've followed this tutorial: https://angular.io/docs/ts/latest/guide/router.html but something is wrong. I can't get it working and there is this error:
GET http://localhost:3000/about/about.component 404 (Not Found)
GET http://localhost:3000/home/home.component 404 (Not Found)
VSCode does not show any problems.
main file structure:
src
├───about
│   ├───about.component.html
│   ├───about.component.ts (and other .js and .js.map files)
├───app
│   ├───app.component.ts
│   ├───app.module.ts (and other .js and .js.map files...)
├───home
│   ├───home.component.html
│   ├───home.component.ts (other less relevant files)
in index.html I've added
app.module.ts:
import { RouterModule, Routes } from '@angular/router'
...
import { AppComponent }  from './app.component';
import { AboutComponent } from './../about/about.component';
import { HomeComponent } from './../home/home.component';

const appRoutes: Routes = [
  {
    path: '/home/home', //I've also tried home/home, home and so on
    component: HomeComponent,
  },
  {
    path: '/about/about',
    component: AboutComponent,
  },
]

@NgModule({
    imports: [
    BrowserModule,
    CommonModule,
    FormsModule,
    HttpModule,
    ReactiveFormsModule,
    RouterModule.forRoot(appRoutes),
    ....],
      declarations: [ AppComponent, AboutComponent, HomeComponent ],
    ....

app.component.ts:
import { Component } from '@angular/core';

@Component({
  selector: 'my-app',
  template: `

      Home
      About

    <router-outlet></router-outlet>
  `
})

export class AppComponent {

}

about.component.ts:
import { Component } from '@angular/core'

@Component({
  selector: 'about',
  moduleId: module.id,
  template: `

ABOUT

  `,
})

export class AboutComponent {

}

home.component.ts:
// imports

@Component({
  selector: 'home',
  moduleId: module.id,
  templateUrl: 'home.component.html',
  styleUrls: ['home.css'],
  providers: [HomeService],
})
export class HomeComponent {
// ...
}

The problem is probably connected to the routerLink but I've tried couple of different options and it didn't work.

Hi @mcichecki do it like this :
app.routes.ts
`import { ModuleWithProviders } from '@angular/core';
import { Routes, RouterModule } from '@angular/router';
import { AppComponent } from './app.component';
import { AboutComponent } from './about/about.component';
import { ServicesComponent } from './services/services.component';
import { Notfound404Component } from './notfound404/notfound404.component';
export const router: Routes = [
{path: '', redirectTo: 'app', pathMatch: 'full'},
{path: 'about', component: AboutComponent },
{path: 'services', component: ServicesComponent},
{path: '**', component: Notfound404Component  }
];
export const routes: ModuleWithProviders = RouterModule.forRoot(router)`
app.module.ts
`import { BrowserModule } from '@angular/platform-browser';
import { NgModule } from '@angular/core';
import { FormsModule } from '@angular/forms';
import { HttpModule } from '@angular/http';
import { routes } from './app.routes';
import { AppComponent } from './app.component';
import { AboutComponent } from './about/about.component';
import { ServicesComponent } from './services/services.component';
import { Notfound404Component } from './notfound404/notfound404.component';
@NgModule({
declarations: [
AppComponent,
AboutComponent,
ServicesComponent,
Notfound404Component
],
imports: [
BrowserModule,
FormsModule,
HttpModule,
routes
],
providers: [],
bootstrap: [AppComponent]
})
export class AppModule { }
`
app.component.html

 ul style="display: inline-flex;
    background-color: darkorange;">
  li
    Home
  /li

AND SO ON ...

and it will work fine.

I found this explanation quite helpful about the topic: Component-relative paths in Angular

I think it will be better if you post this question at StackOverflow. Because this seems a coding issue.

This repository is now deprecated. The Angular Quickstart project was a nice starting point for creating Angular applications. Now we recommend using the Angular CLI to create new Angular projects.
Starting from 1 November 2017, all the Angular documentation, at angular.io, is based on the Angular CLI.
Let's get started


Override container log path to empty if either of sandbox log directory or container log path is empty.

Override container log path to empty if either of sandbox log directory or container log path is empty.
If either of the log paths is empty, container won't start properly since the log path is not properly specified.


Change deploy location to arctic.oldweather.org

I could not get this to build, but for now I've manually copied the files to the new location on S3.


QUIC support

Since @juzi5201314 indicated that he would close https://github.com/rapiz1/rathole/pull/64 I now bring this PR.
Many thanks to juzi for his PR, looking at your approach and reading the comments in the PR was very helpful!
This PR is aware of https://github.com/rapiz1/rathole/pull/93 and an effort has been made to ensure QuicTransport::accept is cancel safe. But honestly, it is very difficult to determine if that is in fact the case.
This PR is standalone and does not immediately require merging of https://github.com/rapiz1/rathole/pull/95 which is much more experimental.
Just to kickstart the review, I want to address some comments in  https://github.com/rapiz1/rathole/pull/64
rust_tls vs native_tls
I may be possible to drop in a native_tls version of quinn-proto::crypto, but that is a lot of work, that I don't think I can put in, for this particular feature. Also, I might have to rewrite certain other parts of quinn as well that seems to, only be available when using the rust_tlsfeature of the quinncrate.
If the compilation time / executable size is a problem, then I would propose making QUIC a non-default feature.
Releasing UDP sockets in tests
I have spent a long time trying to get the tests working without using a pre-determined sleep between shutdown and restart of the server. This is what I came up with:

make sure that rathole::run does not exit before the currently running server instance coroutine has joined
add new async fn close(a: Self::Acceptor) method to the Transport trait such that graceful termination of the QUIC connections can be awaited
await close in Server::run to ensure that socket is released before coroutine joins

I hope that the above solution is acceptable.  The only other option is to rebind to a new random UDP port from a drop on the Acceptor.

This PR is aware of #93 and an effort has been made to ensure QuicTransport::accept is cancel safe. But honestly, it is very difficult to determine if that is in fact the case.

Seems safe to me 🤔

examples/tls/testserver.pfx looks like a slipping file?

No, identity.pfx does not provide a certificate that QUIC will accept. AFAIK QUIC requires that the server cert contains a DNS SAN. identity.pfx has a SAN, but it is IP type.

There are two files, examples/tls/test_server.pfx and examples/tls/testserver.pfx. Only the former has been used in toml files.

Ahh, yeah that file. that was not supposed to be committed. I will delete

Squashed the branch since rebasing was getting unwieldy with so many small commits and reverts

I see tests failing.
Can only test linux locally, and that passes on my desktop...
Dunno why the tests are failing

Try disable the quic test for mac, just like what tls does.
mac requires manual effort to make certificate work, which is hard to do  in CI

Jan 18 02:53:19.113  INFO handle{service=echo}: rathole::client: Starting 092c79e8f80e559e404bcf660c48f3522b67aba9ff1484b0367e1a4ddef7431d
Jan 18 02:53:19.113  INFO handle{service=pingpong}: rathole::client: Starting c78862c4afddaa20fd3ff12e5e270480706499341ca5d1d7437ec9668556805b
Jan 18 02:53:20.031  INFO test{config_path="tests/for_udp/quic_transport.toml" t=Udp}: integration_test: start the server
Jan 18 02:53:20.039  INFO config_watcher{path="tests/for_udp/quic_transport.toml"}: rathole::config_watcher: Start watching the config
Jan 18 02:53:20.040  INFO rathole::server: Listening at <IP_ADDRESS>:2332
Jan 18 02:53:20.182  INFO test{config_path="tests/for_tcp/quic_transport.toml" t=Tcp}: integration_test: start the server
Jan 18 02:53:20.189  INFO config_watcher{path="tests/for_tcp/quic_transport.toml"}: rathole::config_watcher: Start watching the config
Jan 18 02:53:20.194  INFO rathole::server: Listening at <IP_ADDRESS>:2333
Jan 18 02:53:22.059  INFO test{config_path="tests/for_udp/quic_transport.toml" t=Udp}: integration_test: echo
test udp ... FAILED
Jan 18 02:53:22.231  INFO test{config_path="tests/for_tcp/quic_transport.toml" t=Tcp}: integration_test: echo
error: test failed, to rerun pass '--test integration_test'
test tcp ... FAILED

Jan 18 02:53:19.113  INFO handle{service=echo}: rathole::client: Starting 092c79e8f80e559e404bcf660c48f3522b67aba9ff1484b0367e1a4ddef7431d

shows that the client tried to connect to the server, but by the end of the test, it had not succeeded nor returned any feedback.
I think there are two potential issues to address:

QUIC connect can't return an error immediately when the target port is not listened, due to the nature of UDP, which is the cause of no feedback. This can be solved either by

Enforce a timeout at https://github.com/emillynge/rathole/blob/7f083c21b7f0f637b28337c48c74f43830488aa4/src/client.rs#L393-L397
Utilize some QUIC features or enforce a timeout in the transport connect implementation. I wonder if there's already some timeout setting for QUIC connect.

As I previously mentioned, a IPv4 bind socket can't connect to a IPv6 address or vice versa. See https://docs.rs/quinn/latest/quinn/struct.Endpoint.html#method.client

Hi @emillynge What's the status of this? I think we are really close to get this merged.

Hi @emillynge What's the status of this? I think we are really close to get this merged.

I'm on vacation now, and then next week my parental leave is over and I'll have to go to work. I will try to wrap this up in the coming month, but my time is very limited now unfortunately.

@emillynge if you don't mind, I can pick up this and finish this PR.

@emillynge if you don't mind, I can pick up this and finish this PR.

I would be very pleased if you do so.
Can I transfer/share ownership of PR and branch somehow?

@cssivision can fork your repository with the PR branch and open a new one at least. But i think you can also add him as a member to your forked rathole repository so he can push changed. Correct me if i'am wrong

What is the future of this pull request? @rapiz1
The reason I'm asking this is that I'm thinking about implementing a new feature of QUIC as a transport type for rathole
should I submit a whole new pull request?


ImportError: cannot import name 'gcd' from 'fractions'  for Python3.9

When I run
from snorkel.labeling.model import LabelModel

Using Python3.9, I get this error
ImportError: cannot import name 'gcd' from 'fractions' (/Library/Frameworks/Python.framework/Versions/3.9/lib/python3.9/fractions.py)

It seems to be a bug in networkx, cf. this discussion.
As a workaround I'm rolling back to Python3.8, but this is obviously not ideal.

Hi keesjandevries,
Our repo only officially supports Python 3.8 or lower. If you want to set up an environment that will have all the right packages and dependencies you can run tox. See the Development Environment section of https://github.com/snorkel-team/snorkel/blob/master/CONTRIBUTING.md for more reference

I fixed this by importing networkx==2.5. Can you not relax the requirement?

Please don't go stale.

Thanks for the note, @dataqa. I know we've had issues with the networkx package in the past (e.g., it hasn't always adhered to semantic versioning, introducing non-backward compatible changes between minor versions), but we'll take a look and see if networkx==2.5 is feasible.

Hi @dataqa! According to setup.py we currently support using networkx==2.5. Let us know if you still have trouble using it!

Worked like a charm! Thanks so much :-)


Revert "MWPW-158776 Fix video CLS "

Reverts adobecom/milo#2915
Issue
Before: https://main--cc--adobecom.hlx.page/creativecloud/business/teams/lush?milolibs=stage
After: https://main--cc--adobecom.hlx.page/creativecloud/business/teams/lush?milolibs=revert-2915-marquee-cls
PSI
Before: - https://stage--cls--milo--adobecom.hlx.page?martech=off
After: - https://revert-2915-marquee-cls--milo--adobecom.hlx.page?martech=off

Closing this in favor of reverting https://github.com/adobecom/milo/pull/3002 as this one contains changes that will help pages for MAX.


Approval system

Closes #66
Description
Approval system added for approving or declining approval requests from organizations by the admin.
Three controller functions added in adminController.js to

See all approval requests.
Approve a request.
Decline a request.
Routes accordingly added in adminRoutes.js added.

Good work!


[bug] Missing Permission Error for WebviewWindow

Describe the bug
I encountered an issue while using Tauri v2. Normally, when we call APIs that require permissions, the console displays that we don't have the necessary permission (xxx).
While using WebviewWindow, I forgot to set the core:webview:allow-create-webview-window permission for the app. Unlike before, Tauri didn't inform me that I needed the core:webview:allow-create-webview-window permission to use it; instead, it threw a window not found error.
Just when I was at my wits' end, I used tauri://error and received the correct error message.
const currWindow = getCurrentWindow()

const webview = new WebviewWindow('login', { url: '/', parent: currWindow, })

webview.once('tauri://error', (err) => {
  console.log('webview creation failed: ', err)
})

webview.show()

Reproduction
https://github.com/Clover-You/tauri-window-permission-error
Expected behavior
No response
Full tauri info output
> tauri "info"

[✔] Environment
    - OS: Mac OS 15.0.1 x86_64 (X64)
    ✔ Xcode Command Line Tools: installed
    ✔ rustc: 1.81.0 (eeb90cda1 2024-09-04)
    ✔ cargo: 1.81.0 (2dbb1af80 2024-08-20)
    ✔ rustup: 1.27.1 (54dd3d00f 2024-04-24)
    ✔ Rust toolchain: stable-x86_64-apple-darwin (default)
    - node: 22.6.0
    - pnpm: 9.10.0
    - npm: 10.8.2
    - bun: 1.1.30

[-] Packages
    - tauri 🦀: 2.0.4
    - tauri-build 🦀: 2.0.1
    - wry 🦀: 0.46.2
    - tao 🦀: 0.30.3
    - @tauri-apps/api : 2.0.2
    - @tauri-apps/cli : 2.0.3

[-] Plugins
    - tauri-plugin-shell 🦀: 2.0.1
    - @tauri-apps/plugin-shell : 2.0.0

[-] App
    - build-type: bundle
    - CSP: unset
    - frontendDist: ../dist
    - devUrl: http://localhost:1420/
    - framework: React
    - bundler: Vite

Stack trace
No response
Additional context
No response

Just when I was at my wits' end, I used tauri://error and received the correct error message.

Due to the async nature of the IPC that's the best we can do for constructor based apis afaik.


Add footer for all pages

Footer should be displayed for all pages.
Currently footer is displayed only for catalog home page (/catalog). Put footer div for all pages.

Moved from sprint74 to 75 to work on implementation changes.


receiver/vmmetrics: Clean up stale code.

Receiver will be loaded through config.go instead of viper.

Codecov Report

Merging #161 into master will increase coverage by 0.39%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #161      +/-   ##
==========================================
+ Coverage   73.69%   74.08%   +0.39%
==========================================
  Files          95       95
  Lines        5827     5796      -31
==========================================
  Hits         4294     4294
+ Misses       1318     1287      -31
  Partials      215      215

Impacted Files
Coverage Δ

receiver/vmmetricsreceiver/factory.go
81.81% <ø> (ø)
:arrow_up:

receiver/vmmetricsreceiver/metrics_receiver.go
0% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8721e3b...0ef4c82. Read the comment docs.

Build failure seems to be due to processor:
https://travis-ci.org/open-telemetry/opentelemetry-service/builds/560085411#L496
processor/attributekeyprocessor/factory.go:26:9: undefined: processor.RegisterFactory
# github.com/open-telemetry/opentelemetry-service/processor/attributekeyprocessor [github.com/open-telemetry/opentelemetry-service/processor/attributekeyprocessor.test]
processor/attributekeyprocessor/factory.go:26:9: undefined: processor.RegisterFactory
processor/attributekeyprocessor/config_test.go:29:9: undefined: config.RegisterTestFactories
processor/attributekeyprocessor/config_test.go:33:38: not enough arguments in call to config.LoadConfigFile
	have (*testing.T, string)
	want (*testing.T, string, map[string]receiver.Factory, map[string]processor.Factory, map[string]exporter.Factory)
processor/attributekeyprocessor/config_test.go:71:13: undefined: processor.GetFactory
processor/attributekeyprocessor/config_test.go:73:38: not enough arguments in call to config.LoadConfigFile
	have (*testing.T, string)
	want (*testing.T, string, map[string]receiver.Factory, map[string]processor.Factory, map[string]exporter.Factory)
processor/attributekeyprocessor/factory_test.go:30:13: undefined: processor.GetFactory
processor/attributekeyprocessor/factory_test.go:38:13: undefined: processor.GetFactory
make: *** [vet] Error 2

@pjanotti can you take a look?

@songy23 the build failure is on a code that I no longer see in master. Can you rebase and see if it helps?

Never mind https://github.com/open-telemetry/opentelemetry-service/pull/163 fixed it. Rebased.

Commit message fixed, PTAL @tigrannajaryan


re: #233 Refactor formatdef_eslint_local

The old formatdef for eslint could not correctly locate the binary for eslint installed via sudo npm -g install eslint. It would also not work if a eslintrc.* file did not exist.
This simple patch makes the formatter fall back on using the $PATH to locate eslint if it is not a locally installed node_module, allows the formatter to run with the --no-eslintrc option if no config file can be found, and simplifies some of the logic where the formatter attempts to find the config files.
Patch tested with vim 8.0 compiled for Fedora 28 Workstation.

Apologies for the spam with the other PRs that I  opened and subsequently closed. I just reinstalled my OS on my laptop and some configs were fighting one another. Suffice it to say, git and a bunch of other things were very unhappy with me.
This PR should be good to go though. Review would be appreciated.

Okay, since you ask for it I would say the logic could be even more simplified than you already did. :)

Not only simplified, but also removed! Turns out eslint already does most of what this formatter was trying to accomplish. Hopefully this should be good to merge now :smile:

Not only simplified, but also removed! Turns out eslint already does most of what this formatter was trying to accomplish, as a consequence, the formatter still fails and complains loudly (in verbose mode) if there's no eslintrc file anywhere, but this probably for the best (if you set eslintrc as your linter, hopefully you have a defined style to lint against)

Okay that's interesting! But I feel there are two new problems now:

How does eslint know the actual location of the file it has to format? It only gets passed a tmp file, so any local eslint configuration may not be picked up.
If there is no config file, you cannot use the formatter. But in my experience many developers just like to stick with the defaults and thus have no config file for that reason.

Are these concerns valid?

How does eslint know the actual location of the file it has to format? It only gets passed a tmp file, so any local eslint configuration may not be picked up.

Would it be a suitable work around to create the tmp file in the current working directory?

If there is no config file, you cannot use the formatter. But in my experience many developers just like to stick with the defaults and thus have no config file for that reason.

This is the current behaviour of the formatter though, it returns a failure exit code if it can't find a configuration file. I don't think this is necessarily bad, since one can easily generate a valid eslintrc with
eslint --init

Maybe the formatter could try to run eslint, then if it fails, try it again with the --no-eslintrc option?

Would it be a suitable work around to create the tmp file in the current working directory?
That sounds like a decent solution. The file utils.vim contains a randomize function that can be used to help generate random filenames.

Maybe the formatter could try to run eslint, then if it fails, try it again with the --no-eslintrc option?
Sounds like a decent solution as well. This is actually very easy to implement, since vim-autoformat already comprises fallback behaviour. All we have to do is add two formatters for this and make sure the no-config variant is last in the fallback chain.

I don't know much about the source code, but I'm curious if instead of trying+failing+retrying every time, whether it's possible to detect whether there is an eslintrc config file, and call with or without --no-eslintrc as appropriate? That would save unnecessary program invocations. It's also possible that this is not a performance concern.

I don't know much about the source code, but I'm curious if instead of trying+failing+retrying every time, whether it's possible to detect whether there is an eslintrc config file, and call with or without --no-eslintrc as appropriate?

Not if we want to delegate the config finding logic to eslint instead of reimplenting it ourselves.

That would save unnecessary program invocations. It's also possible that this is not a performance concern.

As far as I know there is no concern for performance, as the fallback chain is evaluated every time you format the code and I've never heard of performance issues. Let's not optimize prematurely.

Any updates on this?
Also, reading back the comments,

How does eslint know the actual location of the file it has to format? It only gets passed a tmp file, so  any local eslint configuration may not be picked up.

Would it be a suitable work around to create the tmp file in the current working directory?

I would like to note that most format programs offer a commandline argument with which you can specify the location of the file being formatted, such that it may pick up the correct format config based on that location. Not sure if eslint has such a feature, but if it has, we should probably use it.

Hey @Chiel92 sorry, this fell off my list of priorities. I'll post an update when I have one hopefully early next week.

@keeferrourke Hi, any updates?

Closed due to inactivity.


Download the current folder

As suggested at https://discourse.jupyter.org/t/jupyter-archive-make-download-and-extract-archive-files/2363/8?u=hadim

Fixed by 76b5cf69f9e4ca2c5a8be705e33568fecb07bcbb


Does fotoopparat API provides a way to resize picture when saving photo?

As far as I understood client can only select the available camera resolution. But we need to be able to capture square pictures. Is there is a standard API for this?

Nope. It's only a capturing library


Introduce payments simcore service

The service was implemented and brought in in https://github.com/ITISFoundation/osparc-simcore/pull/4676

Blocked waiting for @pcrespov

Blocked waiting for @pcrespov

We will address this as soon as the payments service is fully functional and our partners have the gateway online.
Short update: payment service goes through its second iteration in https://github.com/ITISFoundation/osparc-simcore/pull/4743. For the moment I think it will need in total four iterations (i.e. 2 more).

All is done.


V-Sekai Social VR Meeting agenda for 2022-09-25

V-Sekai version
6b42f028b7dfc3873f2c4001bc2b853bfb7945f6
System information
Windows 10, Nvidia 3000 series
Issue description
This meeting will be on 2022-09-25 (America/Vancouver) in the V-Sekai Discord within the staff channel. During the meeting, we will be using the voice text chat channel to manage a speaker queue, post links, and for any sidebar discussions.
We wish to improve our processes for notifying and running meetings.
Attendees

@fire
Any staff members

Agenda for 20 minutes:
What features do we need to build for V-Sekai for a 2022 release?

[ ] Debugging xrcontroller in V-sekai blocker for user movement.
[ ] V-Sekai shard browsing for online running servers is offline and the list is broken and blocks collaborating
[ ] Being unable to validate the scene downloads blocks us from inviting friends and new collaborators.
[ ] Locomotion doesn't hide the vision in itch builds.
[ ] Has iFire streamed working nano sized features this weekend?
[ ] Evaluate and publish VRM to the 4.0 Asset Library
[ ] Evaluate and publish Unidot to the 4.0 Asset Library
[ ] Disable AnimationTree import in Unidot

Show and tell

[x] Faster downloads in V-Sekai
[x] Godot 64 bit float
[ ] Lyuma's dice shader port
[ ] Open to registering V-Sekai and Godot Engine gltf extensions.
[ ] gltf document extensions work with Lyuma, Fire and Aaron Frankee
[ ] Optimize gltf importers. https://github.com/tefusion/godot-subdiv https://github.com/fire/MaterialX
[x] Godot javascript as a wasgo replacement up to emulating wasm as js. Missing capability profiles.
[x] Sketch a slice-of-life social vr experience (text, diagrams) https://github.com/V-Sekai-fire/VSK_slice_of_life.git

Create next weeks agenda
To propose another item for the agenda, comment below (preferably before the meeting).
Steps to reproduce
None.
Minimal reproduction project
None.

I got stuck debugging xrcontroller in V-sekai it’s a blocker for user movement.

understand what we want the players' experience to be

I agree. I'll see what I can do about sketching (text, diagrams) something to show to the group.

This meeting did not happen on Sunday. Will try this weekend.

System information
Windows 10, Nvidia 3000 series
Issue description
This meeting was on 2022-10-02 (America/Vancouver) in the V-Sekai Discord within the staff channel. During the meeting, we will be using the voice text chat channel to manage a speaker queue, post links, and for any sidebar discussions.
We wish to improve our processes for notifying and running meetings.
Attendees

@fire
@lyuma

Agenda for 20 minutes:
What features do we need to build for V-Sekai for a 2022 release?

[x] Copy.ai generated documentation and summarization
[x] Evaluate and publish VRM to the 4.0 Asset Library
[x] Evaluate and publish Unidot to the 4.0 Asset Library
[x] Event planning

Show and tell
Create next weeks agenda
To propose another item for the agenda, comment below (preferably before the meeting).
Steps to reproduce
None.
Minimal reproduction project
None.


Add metadatalog interface and default in memory implementation

Changes

Add metadatalog interface which is used by stream source, microbatch execution.
Add default in memory implementation of metadatalog.

Check List

[x] New functionality includes testing.

[x] All tests pass, including unit test, integration test and doctest

[x] New functionality has been documented.

[x] New functionality has javadoc added
[ ] New functionality has user manual doc added

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #974 (a73a856) into feature/maximus-m1 (3a9d217) will decrease coverage by 35.19%.
The diff coverage is n/a.

@@                    Coverage Diff                    @@
##             feature/maximus-m1     #974       +/-   ##
=========================================================
- Coverage                 97.95%   62.76%   -35.20%
=========================================================
  Files                       300       10      -290
  Lines                      7784      658     -7126
  Branches                    500      119      -381
=========================================================
- Hits                       7625      413     -7212
- Misses                      158      192       +34
- Partials                      1       53       +52

Flag
Coverage Δ

query-workbench
62.76% <ø> (?)

sql-engine
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...earch/sql/planner/physical/collector/Rounding.java

...earch/sql/opensearch/data/utils/ObjectContent.java

...search/sql/expression/NamedArgumentExpression.java

.../opensearch/sql/planner/logical/LogicalDedupe.java

...ensearch/sql/planner/physical/ProjectOperator.java

...protocol/response/format/RawResponseFormatter.java

...protocol/response/format/CsvResponseFormatter.java

...opensearch/sql/exception/QueryEngineException.java

...opensearch/sql/expression/HighlightExpression.java

...search/sql/opensearch/security/SecurityAccess.java

... and 300 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Update to version v1.11.4 for 1.24

https://github.com/aws/amazon-vpc-cni-k8s/tree/v1.11.4

Sticking with 1.1.1


Segmentation fault Problem while running MCTS_10000

When I run MCTS_10000 with the default setting (./solve.sh 10000 16 16), I met the error "Segmentation fault". I think it's due to the undersized CPU I'm using as it works fine on both 1000 and 500 points.
I want to know what type of CPU you are running and how much memory is needed for the program to run normally.
I would be very grateful if you could give me some advice。

Thank you for your interest in our work. MCTS runs on Intel Xeon Gold 6230 80-core CPU. You may refer to Appendix D.1 for hardware configuration.
If you run out of CPU memory, you may reduce the number of threads (the 3rd argument):
./solve.sh 10000 16 4

If you have other questions, please do not hesitate to let me know.


SysEx messages longer than 8192 bytes

Hello!
I'm trying to use mido 1.2.9 in Python 3.7.0 under Windows 10 with the standard rtmidi backend to parse SysEx dumps.  I'm using this structure:
with mido.open_input(IN_PORT) as inport:
    for msg in inport:
        # Logic treating different message types here

Some of them are longer than 8192 bytes, which is the buffer size of rtmidi. When this happens, I do not receive any message at all. In the rtmidi documentation it says that:

Windows note: the Windows Multi Media API uses fixed size buffers for the reception of sysex messages, whose number and size is set at compile time. Sysex messages longer than the buffer size can not be received properly when using the Windows Multi Media API.
The default distribution of python-rtmidi sets the number of sysex buffers to four and the size of each to 8192 bytes. To change these values, edit the RT_SYSEX_BUFFER_COUNT and RT_SYSEX_BUFFER_SIZE preprocessor defines in RtMidi.cpp and recompile.

What is the best solution to this? Is there another way to parse the long SysEx messages? Could I try a different backend? Or do I have to recompile the rtmidi C++ file with a bigger buffer size?

Short of recompiling rtmidi yourself there's unfortunately nothing we can do about that at the moment.


Write down User Stories/Features List

This could be thought of as our initial "Road Map" for the development of the project. Here, we simply need to answer the question "What are the things/actions the users will experience as they use the app?". Let's create a simple list of features that will rise up from these User Stories. Assigning this to @isji just for start.

Not really sure if we could keep this here in Github where anyone can see it or move it back to our private Paper document where, but I think it would be good if everything we do for the project's design and development is transparent... to promote freedom! ;) @isji

For freedom! Awoo!
"What are the things/actions the users will experience as they use the app?"

Should I be very specific with this? User can create their own account. Or user can create an account using email verification and password?

Should I be very specific with this? User can create their own account. Or user can create an account using email verification and password?
I checked a use case list document from another project and they have specific points there such as:

I am a farmer in a large plantation. I make sure that the plants in the area assigned to me are healthy from planting to harvesting.
I have to report the number of plants that are infected by a particular type of disease.
...and so on.

For us, since we can't do a survey to real people right now and we work remotely, I think we can just start with a story like this:

This is John. John likes to eat out with friends. When John and his friends go out to eat at their favorite restaurants, sometimes one does not have cash, so someone has to pay for that friend's share. Sometimes no one has cash. So someone has to wash the dishes, or withdraw cash from an ATM.
...something like that :)

Sorry i think i need to rephrase the question to: What are the things/actions the users experience as they go through the use cases without the app? For example, John goes to Google Sheets and log the expense he made for the dinner and the corresponding friend's name whom he paid for.
Then after these user stories (experience without the app yet) we convert them into a use case list, where we imagine the using the app for the same story.


I want to display the video with centerCrop scaleType

I want to display the video with scaleType like centerCrop in ImageView.
I've try to change the size of the view by using android:layout_width and android:layout_height. But the video was also resized.

Hi,

I want to display the video with scaleType like centerCrop in ImageView.

I'm not sure what you mean, cold you clarify?

When I resize the YouTubePlayerView
What it was:

What I want:

Before I resize, i set:
android:layout_width="match_parent" and android:layout_height="200dp"
It looked like this:

The IFrame player (web player) is made to always fit the screen.
One way to do what you want is to fork the library and play with the css. Like changing it at runtime. This is just off the top of my head, let me know if you find better ways to do it.

OK, Thank you!


Remove main

The __main__.py file is very old and outdated. Removing it. (If anyone wants this, it should probably be updated/redone.)

Ah, there's also cli_test that needs to be removed

I suppose we no longer need click as a requirement?

https://github.com/microsoft/onnx-script/pull/593


[WIP] ART-1069: elliott puddle-advisories misses some advisory metadata

continue work base on https://gitlab.cee.redhat.com/openshift-art/tools/elliott/merge_requests/90/

Codecov Report

Merging #63 into master will decrease coverage by 0.61%.
The diff coverage is 2.04%.

@@            Coverage Diff             @@
##           master      #63      +/-   ##
==========================================
- Coverage   29.66%   29.04%   -0.62%
==========================================
  Files          24       25       +1
  Lines        2151     2200      +49
  Branches      361      368       +7
==========================================
+ Hits          638      639       +1
- Misses       1489     1537      +48
  Partials       24       24

Impacted Files
Coverage Δ

elliottlib/cli/puddle_advisories_cli.py
0% <0%> (ø)

elliottlib/errata.py
23.38% <9.09%> (-1.4%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 023de42...5109ba8. Read the comment docs.

I'd have liked to see some unit tests, but it's working fine and we kinda need this for tomorrow!


Feature/post more comments button fix

What does this pull request aim to achieve? 💯
Fix bug related to "Show more comments" button appearing when all the comments are already shown. Issue #1243

[x] I have checked that no one else is working on similar changes.
[x] I have read the latest README and understand the development workflow.
[x] The name of this branch is: feature/<branch_name>, or hotfix/<branch_name> if this is a hotfix. The branch is created in a cloned version of this repo, not a forked repo.
[x] This branch is rebased/merged with the latest staging (or the latest production if it is a hotfix).
[x] There are no merge conflicts.
[x] There are no console warnings and errors.
[x] On the right-hand side of this PR, I have linked the appropriate issue(s) under "Issues" and added a project progress under "Projects".

Hi @joshmorel, I tried re-deploy twice following the steps you advised recently, but the URL still doesn't work for me. May you help look into this issue and give some suggestions?

@Elohina @joshmorel
The deployment fails due to issue in "Deploy Review steps->

Hi @joshmorel, I tried re-deploy twice following the steps you advised recently, but the URL still doesn't work for me. May you help look into this issue and give some suggestions?

It looks like something funky happened during the initial deployment which caused the Terraform state file to diverge from the actual state of the infrastructure for this build. I was able to wipe out this build in AWS and rebuild from scratch. You should now be able to access the build: https://featurepost-more-comments-button-fix.fightpandemics.xyz/

Ok thanks, the website can work now.

For 5 comments rule (<= 5 comments shows no button :heavy_check_mark: ; > 5 comments shows "view more comments" :heavy_check_mark: ; Already shows all comments then shows "view less comments" :heavy_check_mark: )

Not sure if what result that team exactly wants, I tried to view comments in this post. I observed the numbers of popping up comments after pressed on "view more comments" are not fixed number (e.g. should extend more 15 comments each time the button is pressed, maybe??.) And also when I click on view more comments until it shows "view less button" > click on that button > all comments were hidden except the latest 5 comments on the top > press "view more comments" again > it shows all comments this time with "view less button".

Thanks for your observations @pemika-me. About the number of comments that have to be shown after clicking the button, it looks like it was done to increment the number of comments by the double of the previous amount every time you click the button. Maybe @joshmorel knows if that was the initial intention. I can also fix it to 5 but I would like to confirm if that change is necessary.

LGTM
tested with the following scenarios: comments > 10, comments == 5, comments < 5. For ind and org profile.


[CORE] Review the usage of Shell & Sysfs and how to improve the infrastructure to do tests

Feature: Develop the library EV3Dev-lang-java
In the third generation of Lego Mindstorms,
it is possible to install a complete Linux distribution and a complete Oracle JRE.
It is necessary to develop a library to use the hardware compatible with EV3Dev.

    Scenario: Improve the UML Design to improve testing
        Given The library EV3Dev-lang-java
        Then It is necessary to simplify the entry points to EV3Dev file system
        And Offer some ways to test the library

Current design:

With the current solution, is not possible to develop any test the project. The same situation happens in LeJOS project and it is normal this kind of comments in LeJOS forum:
https://lejos.sourceforge.io/forum/viewtopic.php?f=18&t=8798#p32045
In order to solve the solution, I have refactored the design of the project a bit to be able to change the ROOT_PATH of any interaction with ev3dev.
ROOT_PATH is /sys/class but after the refactoring, it is possible to set any path using a system variable. Using this change, I will try to develop tests for the project.
Many thanks for the analysis from @juan-medina and some ideas from the project @strongback
http://slides.com/strongback/using-strongback/#/4
Solution:

Maybe with this issue, I will finish every problem with the testing support but I will add the initial infrastructure to add tests on the project.
It is important to create a testing culture.
https://twitter.com/juanantoniobm/status/826069440836018176

It is necessary to do a full-feature regression tests but finally, I added the first tests to the project.
Thanks @juan-medina for the analysis.


Using indirect call in pre-checker function to avoid the relocation occurrence in XIP mode.

The stack profiler aot_func#xxx will call wrapped function of aot_func_internal#xxx using symbol reference,  in some platform, like xtensa, it’s translated into a native long call, which need resolve the indirect address by relocation, this will break the XIP feature which requires the eliminating of relocation.
The solution is to change the symbol reference into an indirect call through the lookup table, the code will be like this:
call_wrapped_func:                                ; preds = %stack_bound_check_block
  %func_addr1 = getelementptr inbounds ptr, ptr %func_ptrs_ptr, i32 75
  %func_tmp2 = load ptr, ptr %func_addr1, align 4
  tail call void %func_tmp2(ptr %exec_env)
  ret void

an alternative for xtensa is to use pc-relative calls. eg. https://github.com/yamt/llvm-project/commit/3f04244a4fd94952a3f208b7d1ee3afef2da1e3a
good: more efficient.
bad: a hack in llvm. i'm not sure how difficult a proper support would be.

an alternative for xtensa is to use pc-relative calls. eg. yamt/llvm-project@3f04244 good: more efficient. bad: a hack in llvm. i'm not sure how difficult a proper support would be.

Yes, patching llvm seems a good way instead of changing the AOT file format, @dongsheng28849455 could we apply the patch to llvm before we build llvm for aot compiler? We may add the patch file under build-script folder (like file lldb_wasm.patch), and change the build_llvm.py to apply the patch?

an alternative for xtensa is to use pc-relative calls. eg. yamt/llvm-project@3f04244 good: more efficient. bad: a hack in llvm. i'm not sure how difficult a proper support would be.

Yes, patching llvm seems a good way instead of changing the AOT file format, @dongsheng28849455 could we apply the patch to llvm before we build llvm for aot compiler? We may add the patch file under build-script folder (like file lldb_wasm.patch), and change the build_llvm.py to apply the patch?

we have tested with coremark, seems not much impact for performance.
This might be a more general solution, I'm not sure if any other target has similar issue? and we have to maintain the patch in future.

Yes, patching llvm seems a good way instead of changing the AOT file format, @dongsheng28849455 could we apply the patch to llvm before we build llvm for aot compiler? We may add the patch file under build-script folder (like file lldb_wasm.patch), and change the build_llvm.py to apply the patch?

we have tested with coremark, seems not much impact for performance. This might be a more general solution, I'm not sure if any other target has similar issue? or we have to maintain the patch in future.

There isn't similar issue reported in other targets yet, seems that we only need to add it for xtensa. The patch is simple and it should be easy to maintain, normally we only need to update the patch when we upgrade the LLVM version. Otherwise, we have to maintain two different AOT file formats (and not sure whether we should change the aot loader), it is also a little tiresome.

Yes, patching llvm seems a good way instead of changing the AOT file format, @dongsheng28849455 could we apply the patch to llvm before we build llvm for aot compiler? We may add the patch file under build-script folder (like file lldb_wasm.patch), and change the build_llvm.py to apply the patch?

we have tested with coremark, seems not much impact for performance. This might be a more general solution, I'm not sure if any other target has similar issue? or we have to maintain the patch in future.

There isn't similar issue reported in other targets yet, seems that we only need to add it for xtensa. The patch is simple and it should be easy to maintain, normally we only need to update the patch when we upgrade the LLVM version. Otherwise, we have to maintain two different AOT file formats (and not sure whether we should change the aot loader), it is also a little tiresome.

why we should maintain two AOT format? I think it is the same with normal XIP aot, and do not need change aot loader, just enlarge the the lookup table and follow the aot loading process as before.

we have tested with coremark, seems not much impact for performance.

can you share the numbers?

we have tested with coremark, seems not much impact for performance.

can you share the numbers?

test on esp32 device.
about 81.6, with --enable-multi-thread  option for wamrc 1.3.1 with this patch.
as a comparison, recedingly on wamrc1.1.2, the score is 88, but please note, which is without  --enable-multi-thread, the option will more or less reduce the execution speed.

Yes, patching llvm seems a good way instead of changing the AOT file format, @dongsheng28849455 could we apply the patch to llvm before we build llvm for aot compiler? We may add the patch file under build-script folder (like file lldb_wasm.patch), and change the build_llvm.py to apply the patch?

we have tested with coremark, seems not much impact for performance. This might be a more general solution, I'm not sure if any other target has similar issue? or we have to maintain the patch in future.

There isn't similar issue reported in other targets yet, seems that we only need to add it for xtensa. The patch is simple and it should be easy to maintain, normally we only need to update the patch when we upgrade the LLVM version. Otherwise, we have to maintain two different AOT file formats (and not sure whether we should change the aot loader), it is also a little tiresome.

why we should maintain two AOT format? I think it is the same with normal XIP aot, and do not need change aot loader, just enlarge the the lookup table and follow the aot loading process as before.

It changes the XIP's file format, so there are more differences between the formats of XIP and non-XIP than before. And from the comment in the code, it is only for XIP mode for xtensa, but from the changed code, it is for XIP for all targets, I am not sure whether we should leave the format unchanged for non-xtensa targets since the PR increases the binary size. My opinion is we had better keep the AOT file format as simple as we can to reduce the maintain effort, but it deserves more discussion.
@no1wudi could you help review the PR? Not sure whether the change of AOT file format is good to you since you also use XIP a lot.

I prefer to enhance LLVM, change the AOT file format will cause extra overhead for ARM/RISC-V.

LGTM


Unable to debug at all

1. Which version of PhantomJS are you using? Tip: run phantomjs --version.
2.1.1
2. What steps will reproduce the problem?

Put this code on a file named hello.js:

debugger;

for (var i=0; i < 5; i++)
{
  console.log('debugging in phantom js:' + i);
}

phantom.exit();

Run it with phantomjs --remote-debugger-port=9000 hello.js
Open http://localhost:9000/ and click file://hello.js

3. Which operating system are you using?
Tested on:

Mac OS X Sierra (Safari, Chrome, Firefox)
Ubuntu 16.10 (Safari on Wine, Chrome, Firefox)
Windows 7 Ultimate (Safari, Chrome, Firefox)

All browsers are updated.
4. Did you use binary PhantomJS or did you compile it from source?
Binary.
5. Please provide any additional information below.
The results are:
Safari:

Detached from the target
Remote debugging has been terminated with reason: websocket_closed
Please re-attach to the new target

(reloading didn't help)
It shows up instantly after clicking "hello.js". The process continues running. Sometimes when this happens I have this on terminal console (stdout) and the process stops:

Fatal Windows exception, code 0xc0000005.
PhantomJS has crashed. Please read the bug reporting guide at
http://phantomjs.org/bug-reporting.html and file a bug report.

Chrome and Firefox:
The console is totally non-responsible and I am unable to run __run(), as __run() + Enter just adds a line feed on the console input, and does not submit it to be ran.
So I am totally unable to debug it, unless by adding several console.log and reading the STDOUT all the time.

Have exactly the same issue here.
Tested with Windows 10, latest version of Chrome and Chromium.

Found a workaround!
On the resources tab once you have webkit debugger open, edit the file containing the function __run(){...}, and place __run(); after the function. Then select the statement and select 'Evaluate in Console'.

@jberumen3 Great solution!


node is missing

`E:\ComfyUI_windows_portable>.\python_embeded\python.exe -s ComfyUI\main.py --windows-standalone-build
[START] Security scan
[DONE] Security scan
ComfyUI-Manager: installing dependencies done.
** ComfyUI startup time: 2024-11-02 02:12:53.579487
** Platform: Windows
** Python version: 3.11.9 (tags/v3.11.9:de54cf5, Apr  2 2024, 10:12:12) [MSC v.1938 64 bit (AMD64)]
** Python executable: E:\ComfyUI_windows_portable\python_embeded\python.exe
** ComfyUI Path: E:\ComfyUI_windows_portable\ComfyUI
** Log path: E:\ComfyUI_windows_portable\comfyui.log
Prestartup times for custom nodes:
0.0 seconds: E:\ComfyUI_windows_portable\ComfyUI\custom_nodes\rgthree-comfy
0.6 seconds: E:\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI-Manager
Total VRAM 12288 MB, total RAM 32581 MB
pytorch version: 2.5.1+cu124
Set vram state to: NORMAL_VRAM
Device: cuda:0 NVIDIA GeForce RTX 3060 : cudaMallocAsync
Using pytorch cross attention
[Prompt Server] web root: E:\ComfyUI_windows_portable\ComfyUI\web
E:\ComfyUI_windows_portable\python_embeded\Lib\site-packages\kornia\feature\lightglue.py:44: FutureWarning: torch.cuda.amp.custom_fwd(args...) is deprecated. Please use torch.amp.custom_fwd(args..., device_type='cuda') instead.
@torch.cuda.amp.custom_fwd(cast_inputs=torch.float32)
Loading: ComfyUI-Impact-Pack (V7.10.7)
Loading: ComfyUI-Impact-Pack (Subpack: V0.7)
[Impact Pack] Wildcards loading done.
Loading: ComfyUI-Inspire-Pack (V1.6)
Traceback (most recent call last):
File "E:\ComfyUI_windows_portable\ComfyUI\nodes.py", line 2012, in load_custom_node
module_spec.loader.exec_module(module)
File "", line 940, in exec_module
File "", line 241, in call_with_frames_removed
File "E:\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI-Inspire-Pack_init.py", line 34, in
imported_module = importlib.import_module(".inspire.{}".format(module_name), name)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "importlib_init_.py", line 126, in import_module
File "", line 1204, in _gcd_import
File "", line 1176, in _find_and_load
File "", line 1147, in _find_and_load_unlocked
File "", line 690, in _load_unlocked
File "", line 940, in exec_module
File "", line 241, in _call_with_frames_removed
File "E:\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI-Inspire-Pack\inspire\regional_nodes.py", line 7, in
import webcolors
ModuleNotFoundError: No module named 'webcolors'
Cannot import E:\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI-Inspire-Pack module for custom nodes: No module named 'webcolors'
Total VRAM 12288 MB, total RAM 32581 MB
pytorch version: 2.5.1+cu124
Set vram state to: NORMAL_VRAM
Device: cuda:0 NVIDIA GeForce RTX 3060 : cudaMallocAsync
Loading: ComfyUI-Manager (V2.51.9)
ComfyUI Revision: 2804 [cc9cf6d1] | Released on '2024-10-31'
[ComfyUI-Manager] default cache updated: https://raw.githubusercontent.com/ltdrdata/ComfyUI-Manager/main/github-stats.json
[ComfyUI-Manager] default cache updated: https://raw.githubusercontent.com/ltdrdata/ComfyUI-Manager/main/model-list.json
[ComfyUI-Manager] default cache updated: https://raw.githubusercontent.com/ltdrdata/ComfyUI-Manager/main/alter-list.json
[ComfyUI-Manager] default cache updated: https://raw.githubusercontent.com/ltdrdata/ComfyUI-Manager/main/extension-node-map.json
[ComfyUI-Manager] default cache updated: https://raw.githubusercontent.com/ltdrdata/ComfyUI-Manager/main/custom-node-list.json
Traceback (most recent call last):
File "E:\ComfyUI_windows_portable\ComfyUI\nodes.py", line 2012, in load_custom_node
module_spec.loader.exec_module(module)
File "", line 940, in exec_module
File "", line 241, in call_with_frames_removed
File "E:\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI-PuLID-Flux-Enhanced_init.py", line 1, in
from .pulidflux import NODE_CLASS_MAPPINGS, NODE_DISPLAY_NAME_MAPPINGS
File "E:\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI-PuLID-Flux-Enhanced\pulidflux.py", line 11, in
from insightface.app import FaceAnalysis
File "E:\ComfyUI_windows_portable\python_embeded\Lib\site-packages\insightface_init_.py", line 16, in
from . import model_zoo
File "E:\ComfyUI_windows_portable\python_embeded\Lib\site-packages\insightface\model_zoo_init_.py", line 1, in
from .model_zoo import get_model
File "E:\ComfyUI_windows_portable\python_embeded\Lib\site-packages\insightface\model_zoo\model_zoo.py", line 11, in
from .arcface_onnx import *
File "E:\ComfyUI_windows_portable\python_embeded\Lib\site-packages\insightface\model_zoo\arcface_onnx.py", line 10, in
import onnx
File "E:\ComfyUI_windows_portable\python_embeded\Lib\site-packages\onnx_init_.py", line 77, in
from onnx.onnx_cpp2py_export import ONNX_ML
ImportError: DLL load failed while importing onnx_cpp2py_export: A dynamic link library (DLL) initialization routine failed.
Cannot import E:\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI-PuLID-Flux-Enhanced module for custom nodes: DLL load failed while importing onnx_cpp2py_export: A dynamic link library (DLL) initialization routine failed.
[comfyui_controlnet_aux] | INFO -> Using ckpts path: E:\ComfyUI_windows_portable\ComfyUI\custom_nodes\comfyui_controlnet_aux\ckpts
[comfyui_controlnet_aux] | INFO -> Using symlinks: False
[comfyui_controlnet_aux] | INFO -> Using ort providers: ['CUDAExecutionProvider', 'DirectMLExecutionProvider', 'OpenVINOExecutionProvider', 'ROCMExecutionProvider', 'CPUExecutionProvider', 'CoreMLExecutionProvider']
DWPose: Onnxruntime with acceleration providers detected
[rgthree-comfy] Loaded 42 extraordinary nodes. 🎉
Traceback (most recent call last):
File "E:\ComfyUI_windows_portable\ComfyUI\nodes.py", line 2012, in load_custom_node
module_spec.loader.exec_module(module)
File "", line 940, in exec_module
File "", line 241, in call_with_frames_removed
File "E:\ComfyUI_windows_portable\ComfyUI\custom_nodes\was-node-suite-comfyui_init.py", line 1, in
from .WAS_Node_Suite import NODE_CLASS_MAPPINGS
File "E:\ComfyUI_windows_portable\ComfyUI\custom_nodes\was-node-suite-comfyui\WAS_Node_Suite.py", line 37, in
from numba import jit
File "E:\ComfyUI_windows_portable\python_embeded\Lib\site-packages\numba_init_.py", line 59, in
ensure_critical_deps()
File "E:\ComfyUI_windows_portable\python_embeded\Lib\site-packages\numba_init.py", line 45, in _ensure_critical_deps
raise ImportError(msg)
ImportError: Numba needs NumPy 2.0 or less. Got NumPy 2.1.
Cannot import E:\ComfyUI_windows_portable\ComfyUI\custom_nodes\was-node-suite-comfyui module for custom nodes: Numba needs NumPy 2.0 or less. Got NumPy 2.1.

After restarting ComfyUI, please refresh the browser.
Restarting... [Legacy Mode]
[START] Security scan
E:\ComfyUI_windows_portable>pause
Press any key to continue . . . [DONE] Security scan
ComfyUI-Manager: installing dependencies done.
** ComfyUI startup time: 2024-11-02 02:13:26.554354
** Platform: Windows
** Python version: 3.11.9 (tags/v3.11.9:de54cf5, Apr  2 2024, 10:12:12) [MSC v.1938 64 bit (AMD64)]
** Python executable: E:\ComfyUI_windows_portable\python_embeded\python.exe
** ComfyUI Path: E:\ComfyUI_windows_portable\ComfyUI
** Log path: E:\ComfyUI_windows_portable\comfyui.log
#######################################################################
[ComfyUI-Manager] Starting dependency installation/(de)activation for the extension
[ComfyUI-Manager] Startup script completed.
#######################################################################
Prestartup times for custom nodes:
0.0 seconds: E:\ComfyUI_windows_portable\ComfyUI\custom_nodes\rgthree-comfy
1.0 seconds: E:\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI-Manager
Total VRAM 12288 MB, total RAM 32581 MB
pytorch version: 2.5.0+cu118
Set vram state to: NORMAL_VRAM
Device: cuda:0 NVIDIA GeForce RTX 3060 : cudaMallocAsync
Using pytorch cross attention
[Prompt Server] web root: E:\ComfyUI_windows_portable\ComfyUI\web
E:\ComfyUI_windows_portable\python_embeded\Lib\site-packages\kornia\feature\lightglue.py:44: FutureWarning: torch.cuda.amp.custom_fwd(args...) is deprecated. Please use torch.amp.custom_fwd(args..., device_type='cuda') instead.
@torch.cuda.amp.custom_fwd(cast_inputs=torch.float32)
Loading: ComfyUI-Impact-Pack (V7.10.7)
Loading: ComfyUI-Impact-Pack (Subpack: V0.7)
[Impact Pack] Wildcards loading done.
Loading: ComfyUI-Inspire-Pack (V1.6)
Traceback (most recent call last):
File "E:\ComfyUI_windows_portable\ComfyUI\nodes.py", line 2012, in load_custom_node
module_spec.loader.exec_module(module)
File "", line 940, in exec_module
File "", line 241, in call_with_frames_removed
File "E:\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI-Inspire-Pack_init.py", line 34, in
imported_module = importlib.import_module(".inspire.{}".format(module_name), name)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "importlib_init_.py", line 126, in import_module
File "", line 1204, in _gcd_import
File "", line 1176, in _find_and_load
File "", line 1147, in _find_and_load_unlocked
File "", line 690, in _load_unlocked
File "", line 940, in exec_module
File "", line 241, in _call_with_frames_removed
File "E:\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI-Inspire-Pack\inspire\regional_nodes.py", line 7, in
import webcolors
ModuleNotFoundError: No module named 'webcolors'
Cannot import E:\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI-Inspire-Pack module for custom nodes: No module named 'webcolors'
Total VRAM 12288 MB, total RAM 32581 MB
pytorch version: 2.5.0+cu118
Set vram state to: NORMAL_VRAM
Device: cuda:0 NVIDIA GeForce RTX 3060 : cudaMallocAsync
Loading: ComfyUI-Manager (V2.51.9)
ComfyUI Revision: 2804 [cc9cf6d1] | Released on '2024-10-31'
[ComfyUI-Manager] default cache updated: https://raw.githubusercontent.com/ltdrdata/ComfyUI-Manager/main/model-list.json
[ComfyUI-Manager] default cache updated: https://raw.githubusercontent.com/ltdrdata/ComfyUI-Manager/main/alter-list.json
[ComfyUI-Manager] default cache updated: https://raw.githubusercontent.com/ltdrdata/ComfyUI-Manager/main/extension-node-map.json
Traceback (most recent call last):
File "E:\ComfyUI_windows_portable\ComfyUI\nodes.py", line 2012, in load_custom_node
module_spec.loader.exec_module(module)
File "", line 940, in exec_module
File "", line 241, in call_with_frames_removed
File "E:\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI-PuLID-Flux-Enhanced_init.py", line 1, in
from .pulidflux import NODE_CLASS_MAPPINGS, NODE_DISPLAY_NAME_MAPPINGS
File "E:\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI-PuLID-Flux-Enhanced\pulidflux.py", line 11, in
from insightface.app import FaceAnalysis
File "E:\ComfyUI_windows_portable\python_embeded\Lib\site-packages\insightface_init_.py", line 16, in
from . import model_zoo
File "E:\ComfyUI_windows_portable\python_embeded\Lib\site-packages\insightface\model_zoo_init_.py", line 1, in
from .model_zoo import get_model
File "E:\ComfyUI_windows_portable\python_embeded\Lib\site-packages\insightface\model_zoo\model_zoo.py", line 11, in
from .arcface_onnx import *
File "E:\ComfyUI_windows_portable\python_embeded\Lib\site-packages\insightface\model_zoo\arcface_onnx.py", line 10, in
import onnx
File "E:\ComfyUI_windows_portable\python_embeded\Lib\site-packages\onnx_init_.py", line 77, in
from onnx.onnx_cpp2py_export import ONNX_ML
ImportError: DLL load failed while importing onnx_cpp2py_export: A dynamic link library (DLL) initialization routine failed.
Cannot import E:\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI-PuLID-Flux-Enhanced module for custom nodes: DLL load failed while importing onnx_cpp2py_export: A dynamic link library (DLL) initialization routine failed.
[ComfyUI-Manager] default cache updated: https://raw.githubusercontent.com/ltdrdata/ComfyUI-Manager/main/custom-node-list.json
[ComfyUI-Manager] default cache updated: https://raw.githubusercontent.com/ltdrdata/ComfyUI-Manager/main/github-stats.json
[comfyui_controlnet_aux] | INFO -> Using ckpts path: E:\ComfyUI_windows_portable\ComfyUI\custom_nodes\comfyui_controlnet_aux\ckpts
[comfyui_controlnet_aux] | INFO -> Using symlinks: False
[comfyui_controlnet_aux] | INFO -> Using ort providers: ['CUDAExecutionProvider', 'DirectMLExecutionProvider', 'OpenVINOExecutionProvider', 'ROCMExecutionProvider', 'CPUExecutionProvider', 'CoreMLExecutionProvider']
[rgthree-comfy] Loaded 42 magnificent nodes. 🎉
Traceback (most recent call last):
File "E:\ComfyUI_windows_portable\ComfyUI\nodes.py", line 2012, in load_custom_node
module_spec.loader.exec_module(module)
File "", line 940, in exec_module
File "", line 241, in call_with_frames_removed
File "E:\ComfyUI_windows_portable\ComfyUI\custom_nodes\was-node-suite-comfyui_init.py", line 1, in
from .WAS_Node_Suite import NODE_CLASS_MAPPINGS
File "E:\ComfyUI_windows_portable\ComfyUI\custom_nodes\was-node-suite-comfyui\WAS_Node_Suite.py", line 37, in
from numba import jit
File "E:\ComfyUI_windows_portable\python_embeded\Lib\site-packages\numba_init_.py", line 59, in
ensure_critical_deps()
File "E:\ComfyUI_windows_portable\python_embeded\Lib\site-packages\numba_init.py", line 45, in _ensure_critical_deps
raise ImportError(msg)
ImportError: Numba needs NumPy 2.0 or less. Got NumPy 2.1.
Cannot import E:\ComfyUI_windows_portable\ComfyUI\custom_nodes\was-node-suite-comfyui module for custom nodes: Numba needs NumPy 2.0 or less. Got NumPy 2.1.
Import times for custom nodes:
0.0 seconds: E:\ComfyUI_windows_portable\ComfyUI\custom_nodes\websocket_image_save.py
0.0 seconds: E:\ComfyUI_windows_portable\ComfyUI\custom_nodes\cg-use-everywhere
0.0 seconds: E:\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI_IPAdapter_plus
0.0 seconds: E:\ComfyUI_windows_portable\ComfyUI\custom_nodes\comfy-image-saver
0.0 seconds: E:\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI-AdvancedLivePortrait-main
0.0 seconds: E:\ComfyUI_windows_portable\ComfyUI\custom_nodes\Derfuu_ComfyUI_ModdedNodes
0.0 seconds (IMPORT FAILED): E:\ComfyUI_windows_portable\ComfyUI\custom_nodes\was-node-suite-comfyui
0.0 seconds: E:\ComfyUI_windows_portable\ComfyUI\custom_nodes\rgthree-comfy
0.0 seconds: E:\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI-GGUF
0.0 seconds: E:\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI_UltimateSDUpscale
0.0 seconds: E:\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI_essentials
0.0 seconds: E:\ComfyUI_windows_portable\ComfyUI\custom_nodes\comfyui_controlnet_aux
0.0 seconds: E:\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI-KJNodes
0.0 seconds (IMPORT FAILED): E:\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI-Inspire-Pack
0.0 seconds: E:\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI-Impact-Pack
0.1 seconds: E:\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI-VideoHelperSuite
0.3 seconds: E:\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI-AdvancedLivePortrait
0.4 seconds: E:\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI-Manager
12.5 seconds (IMPORT FAILED): E:\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI-PuLID-Flux-Enhanced
Starting server
To see the GUI go to: http://<IP_ADDRESS>:8188
FETCH DATA from: E:\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI-Manager\extension-node-map.json [DONE]`

i need help anyone answer

i need help anyone answer

this custom node is not working, also the original one... we have to wait someone other to make a new one or that this one is fixed

File "E:\ComfyUI_windows_portable\python_embeded\Lib\site-packages\numba_init.py", line 45, in _ensure_critical_deps
raise ImportError(msg)
ImportError: Numba needs NumPy 2.0 or less. Got NumPy 2.1.
you need to install numpy < 2.0
some of your other nodes must have installed numpy > 2.0, but this nodes (maybe as well as other nodes) can't work with numpy > 2.