minecraft: Update script URL

Motivation for this change
I just accidentally downgraded Minecraft because we depended on Arch's AUR and they were not up-to-date yet.
This change points the version logic at the source of truth for the Minecraft launcher.
Things done

[X] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[X] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[X] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[X] Tested execution of all binary files (usually in ./result/bin/)
[X] Determined the impact on package closure size (by running nix path-info -S before and after)
[X] Ensured that relevant documentation is up to date
[X] Fits CONTRIBUTING.md.

Pinging people who have previously updated Minecraft:
@hyperfekt @cpages @TredwellGit
References:
https://github.com/flathub/com.mojang.Minecraft/issues/36
https://bugs.mojang.com/secure/attachment/224554/launcher_log.txt <-- This shows us that the URL has been used since at least June 2019

Nice find on that URL. The part of their API that I tried using originally consistently returns versions older than are available in the AUR.

@hyperfekt yeah, I found http://launchermeta.mojang.com/mc/launcher.json initially but it's old


Enable Polls for every user

[ ] Make a migration to remove the polls module from every SolutionSettings
[ ] Make the polls tab visible for everyone (do not deploy before the release date of the "Around you" storycard)

Is this still correct, because what I understand from maureen is:

forms should be enabled for some cities only (paying customers probably)
merchants from those cities should be able to send forms too

Enabling polls for everyone was decided in the beginning of August, but in the mean time I heard something different from Steven. Let's verify with Tom if this is still valid.


es6 / yield

How use ajv with yield ?
have you an example ?
Thanks Ami44

ajv is synchronous. Or am I missing something? copileAsync can be used with yield with partial that returns thunk

copileAsync ? not google found

Sorry. compileAsync is ajv method, the only one that is asynchronous

thanks


Adds Tutorials for W2D1

This PR Adds all the Tutorials (1-6) for W2D1. Note there is a current issue in Colab when importing packages (this appears to be a wider issue beyond this notebooks).
Please note, I could not figure out how to make the README file automatically (for the Colab/Kaggle/nbviewer links)

@WesleyTheGeolien This PR now contains the completed W2D1 Tutorial notebooks, using the Climatematch formatting for code exercises and XKCD figures, and it is (hopefully!) ready to be used in the pre-pod
Please let me know if you have additional questions

Hey @BrodiePearson sorry didn't catch this before will hopefully update it in the next few days but need to merge everything together from multiple sources


Docs from backstage.io/docs having markdown as description

E.g. https://backstage.io/docs/features/techdocs/techdocs-overview

TechDocs Documentation · Backstage
## What is it?

The problem being that .md files in /docs folder of the repo doesn't have description document header field (https://docusaurus.io/docs/en/doc-markdown#documents).
So the solution is to go through all files and add description for each one of them ;)

@shmidt-i Can I work on this issue?

@iamrajiv please do, thanks!

@shmidt-i What should I give in description: should I give same as of title: in very .md file

@stefanalund What should I give in description: should I give same as of title: in very .md file.

Can be first paragraph of the text, just cleared from image tags or any markdown.
E.g.
https://backstage.io/docs/overview/what-is-backstage

Imagine string ![service-catalog]... being replaced by
Backstage is an open platform for building developer portals. Powered by a centralized service catalog, Backstage restores order to your microservices and infrastructure. So your product teams can ship high-quality code quickly — without compromising autonomy.

Backstage unifies all your infrastructure tooling, services, and documentation to create a streamlined development environment from end to end...


Update location for htmlize source

The original documented web location for emacs htmlize (a student webpage at a university) is no longer alive.  This patch switches the htmlize source directly to github where that same original developer has it now.

Please use fetchFromGitHub and squash your commits.

Cancelling and starting anew to provide squashed commit.

You do not have to close the pull request to do that. You can just force push to the corresponding branch.


Updating "Home" to "My Home" to add a sense of belonging

Resolved / Related Issues
Items resolved / related issues by this PR.

Closes #issue...
Related #issue...

Details of Changes
Add details of changes here.

Added...
Fixed...

Validation
How did you test these changes?

[ ] Built and ran the app
[ ] Tested the changes for accessibility

Screenshots (optional)
Add screenshots here.

Thank you for your contribution, we don't have plans to implement this change.


PCR opcode not matching with tb services

Hi,
In smoke_test_pcr_signing , there is one programming happening through kv for injection of privkey but im not able to find how that programming is done, because i do not see that opcode either 88 or 7 in caliptra_top_tb_services.
printf("Inject PRIVKEY into KV slot 7\n");
uint8_t privkey_inject_cmd = 0x88 + 0x7;
And this , for the below opcode 0X90 from tb_services i see it is injection of privkey, display and functionality are different they are conflicting
printf("Inject MSG into SHA512 digest\n");
printf("%c", 0x90);
can you please confirm on the above two things.
Thanks,
Navya

The opcode 0x90 is used to inject all required inputs for PCR_signing operation.

It injects a constant value as privkey into KV, and the slot number is determined by KV_ENTRY_FOR_SIGNING.
It injects a constant value as msg into sha512 pcr_sign port.

The piece of code for 0x88+0x7 remained from our previous debugging process and can be removed.


can this work with a mix of sso and normal creds?

I have various creds.. depending on the client they use normal creds, others need me to login with my sso cred.  It doesn't seem like this will work with sso creds.
Normally I would login with "aws sso login --profile  and it would then bring up a page .. after that I just export AWS_PROFILE= and it works
it would be awesome if I could do both

Thank you for your feedback! I understand the need to support both normal credentials and SSO credentials seamlessly. Currently, SSO login isn’t supported in the extension, but I’ll work on adding this functionality. The ability to log in with aws sso login and manage profiles directly within the extension sounds like a great improvement, and I’ll prioritize implementing it.
Stay tuned for updates, and feel free to share any other ideas or features you’d like to see!

A qq, after you run aws sso login, can you go and check ~/.aws/credentials and ~/.aws/sso/cache/ files/folders if you have your new credentials there ?
if you see your new credentials in the ~/.aws/credentials file, aws access extension should be able to read it. so click the extension icon on the status bar and select Set Active Profile to switch to this profile.
if this works, set Set Login Command as aws sso login --profile by clicking the extension icon then menu.
One last question, does this new credentials you set by aws sso ... has an expire date ?

in order, yes it does, ok.. but I have to use both .. can there be a way you have an option .. either export your profile or use AWS sso login depending on the profile?  I have a mix, not sure about the expiration date.  I'll look.  I know when I do an SSO login, it creates creds.. because I still export the AWS_PROFILE= and other things look for existing creds when trying to do something.

I do not understand wrong, you have your sso credentials in the ~/.aws/credentials under your profile name.
So you should be able to select this profile on the aws access extension to track it.
Further more you can set login command like 'aws sso login ...' to run when you need.
In my case, I have my custom sso command, these credentials have an expiration date.
When I select my profile created with sso login, I can see a count down to the expiration date.
As I set the login command, the extension automatically runs the login command to refresh the credentials when they are expired.
let me know what does not work for you


changes-made-home-page

Description
The text alignment and Call to Action button on the Main Page Hero Section are now correctly positioned and aligned.
Padding and Alignment are taken care of.
Fixes #403
Screenshots:
home-page :

Checklist

[x] Tests have been added or updated to cover the changes
[x] Documentation has been updated to reflect the changes
[x] Code follows the established coding style guidelines
[x] All tests are passing

this solves #403 with no merge conflicts

Okay I will resolve them.

@SurajPratap10 I have resolved all conflicts, now the PR can be merged.


Issue initing, maybe due to circular dependencies

What version of dep are you using (dep version)?
v0.3.0-248-gd3e738d
What dep command did you run?
dep init -v (see output below)
What did you expect to see?
Dep builds Gopkg.* files.
What did you see instead?
Getting direct dependencies...
Checked 233 directories for packages.
Found 69 direct dependencies.
Root project is "github.com/hashicorp/vault"
 112 transitively valid internal packages
 102 external packages imported from 69 projects
(0)   ✓ select (root)
(1)	? attempt github.com/armon/go-metrics with 3 pkgs; 1 versions to try
(1)	    try github.com/armon/go-metrics@master
(1)	✓ select github.com/armon/go-metrics@master w/3 pkgs
(2)	? attempt github.com/armon/go-proxyproto with 1 pkgs; 1 versions to try
(2)	    try github.com/armon/go-proxyproto@master
(2)	✓ select github.com/armon/go-proxyproto@master w/1 pkgs
(3)	? attempt github.com/armon/go-radix with 1 pkgs; 1 versions to try
(3)	    try github.com/armon/go-radix@master
(3)	✓ select github.com/armon/go-radix@master w/1 pkgs
(4)	? attempt github.com/fullsailor/pkcs7 with 1 pkgs; 1 versions to try
(4)	    try github.com/fullsailor/pkcs7@master
(4)	✓ select github.com/fullsailor/pkcs7@master w/1 pkgs
(5)	? attempt github.com/hashicorp/errwrap with 1 pkgs; 1 versions to try
(5)	    try github.com/hashicorp/errwrap@master
(5)	✓ select github.com/hashicorp/errwrap@master w/1 pkgs
(6)	? attempt github.com/duosecurity/duo_api_golang with 2 pkgs; 1 versions to try
(6)	    try github.com/duosecurity/duo_api_golang@master
(6)	✓ select github.com/duosecurity/duo_api_golang@master w/2 pkgs
(7)	? attempt github.com/hashicorp/go-sockaddr with 1 pkgs; 1 versions to try
(7)	    try github.com/hashicorp/go-sockaddr@master
(7)	✓ select github.com/hashicorp/go-sockaddr@master w/1 pkgs
(8)	? attempt github.com/go-errors/errors with 1 pkgs; 1 versions to try
(8)	    try github.com/go-errors/errors@master
(8)	✓ select github.com/go-errors/errors@master w/1 pkgs
(9)	? attempt github.com/jefferai/jsonx with 1 pkgs; 1 versions to try
(9)	    try github.com/jefferai/jsonx@master
(9)	✓ select github.com/jefferai/jsonx@master w/1 pkgs
(10)  ? attempt github.com/mitchellh/copystructure with 1 pkgs; 1 versions to try
(10)      try github.com/mitchellh/copystructure@master
(10)  ✓ select github.com/mitchellh/copystructure@master w/1 pkgs
(11)  ? attempt github.com/hashicorp/go-plugin with 1 pkgs; 1 versions to try
(11)      try github.com/hashicorp/go-plugin@master
(11)  ✓ select github.com/hashicorp/go-plugin@master w/1 pkgs
(12)  ? attempt github.com/hashicorp/go-rootcerts with 1 pkgs; 1 versions to try
(12)      try github.com/hashicorp/go-rootcerts@master
(12)  ✓ select github.com/hashicorp/go-rootcerts@master w/1 pkgs
(13)  ? attempt github.com/golang/protobuf with 1 pkgs; 1 versions to try
(13)      try github.com/golang/protobuf@master
(13)  ✓ select github.com/golang/protobuf@master w/1 pkgs
(14)  ? attempt github.com/mitchellh/go-testing-interface with 1 pkgs; 1 versions to try
(14)      try github.com/mitchellh/go-testing-interface@master
(14)  ✓ select github.com/mitchellh/go-testing-interface@master w/1 pkgs
(15)  ? attempt github.com/mitchellh/go-homedir with 1 pkgs; 1 versions to try
(15)      try github.com/mitchellh/go-homedir@master
(15)  ✓ select github.com/mitchellh/go-homedir@master w/1 pkgs
(16)  ? attempt github.com/hashicorp/go-uuid with 1 pkgs; 1 versions to try
(16)      try github.com/hashicorp/go-uuid@master
(16)  ✓ select github.com/hashicorp/go-uuid@master w/1 pkgs
(17)  ? attempt github.com/hashicorp/go-multierror with 1 pkgs; 1 versions to try
(17)      try github.com/hashicorp/go-multierror@master
(17)  ✓ select github.com/hashicorp/go-multierror@master w/1 pkgs
(18)  ? attempt gopkg.in/mgo.v2 with 1 pkgs; 1 versions to try
(18)      try gopkg.in/mgo.v2@v2
(18)  ✓ select gopkg.in/mgo.v2@v2 w/5 pkgs
(19)  ? attempt google.golang.org/api with 2 pkgs; 2 versions to try
(19)      try google.golang.org/api@master
(19)  ✓ select google.golang.org/api@master w/3 pkgs
(20)  ? attempt golang.org/x/sys with 1 pkgs; 1 versions to try
(20)      try golang.org/x/sys@master
(20)  ✓ select golang.org/x/sys@master w/1 pkgs
(21)  ? attempt github.com/mitchellh/reflectwalk with 1 pkgs; 1 versions to try
(21)      try github.com/mitchellh/reflectwalk@master
(21)  ✓ select github.com/mitchellh/reflectwalk@master w/1 pkgs
(22)  ? attempt github.com/ghodss/yaml with 1 pkgs; 2 versions to try
(22)      try<EMAIL_ADDRESS>(22)  ✓ select<EMAIL_ADDRESS>w/1 pkgs
(23)  ? attempt gopkg.in/yaml.v2 with 1 pkgs; 1 versions to try
(23)      try gopkg.in/yaml.v2@v2
(23)  ✓ select gopkg.in/yaml.v2@v2 w/1 pkgs
(24)  ? attempt github.com/hashicorp/go-syslog with 1 pkgs; 1 versions to try
(24)      try github.com/hashicorp/go-syslog@master
(24)  ✓ select github.com/hashicorp/go-syslog@master w/1 pkgs
(25)  ? attempt github.com/chrismalek/oktasdk-go with 1 pkgs; 2 versions to try
(25)      try github.com/chrismalek/oktasdk-go@master
(25)  ✓ select github.com/chrismalek/oktasdk-go@master w/1 pkgs
(26)  ? attempt github.com/google/go-querystring with 1 pkgs; 1 versions to try
(26)      try github.com/google/go-querystring@master
(26)  ✓ select github.com/google/go-querystring@master w/1 pkgs
(27)  ? attempt github.com/hashicorp/go-cleanhttp with 1 pkgs; 1 versions to try
(27)      try github.com/hashicorp/go-cleanhttp@master
(27)  ✓ select github.com/hashicorp/go-cleanhttp@master w/1 pkgs
(28)  ? attempt golang.org/x/oauth2 with 1 pkgs; 1 versions to try
(28)      try golang.org/x/oauth2@master
(28)  ✓ select golang.org/x/oauth2@master w/2 pkgs
(29)  ? attempt github.com/Jeffail/gabs with 1 pkgs; 3 versions to try
(29)      try<EMAIL_ADDRESS>(29)  ✓ select<EMAIL_ADDRESS>w/1 pkgs
(30)  ? attempt github.com/posener/complete with 1 pkgs; 1 versions to try
(30)      try github.com/posener/complete@master
(30)  ✓ select github.com/posener/complete@master w/4 pkgs
(31)  ? attempt github.com/michaelklishin/rabbit-hole with 1 pkgs; 7 versions to try
(31)      try<EMAIL_ADDRESS>(31)  ✓ select<EMAIL_ADDRESS>w/1 pkgs
(32)  ? attempt github.com/cockroachdb/cockroach-go with 1 pkgs; 3 versions to try
(32)      try github.com/cockroachdb/cockroach-go@master
(32)  ✓ select github.com/cockroachdb/cockroach-go@master w/1 pkgs
(33)  ? attempt github.com/mitchellh/mapstructure with 1 pkgs; 1 versions to try
(33)      try github.com/mitchellh/mapstructure@master
(33)  ✓ select github.com/mitchellh/mapstructure@master w/1 pkgs
(34)  ? attempt github.com/hashicorp/vault-plugin-auth-gcp with 1 pkgs; 1 versions to try
(34)      try github.com/hashicorp/vault-plugin-auth-gcp@master
(35)  ✗   github.com/hashicorp/vault-plugin-auth-gcp@master depends on github.com/hashicorp/vault with master, but that's already selected at
(34)    ← no more versions of github.com/hashicorp/vault-plugin-auth-gcp to try; begin backtrack
(33)  ← backtrack: no more versions of github.com/mitchellh/mapstructure to try
(32)  ← backtrack: no more versions of github.com/cockroachdb/cockroach-go to try
(31)  ← backtrack: no more versions of github.com/michaelklishin/rabbit-hole to try
(30)  ← backtrack: no more versions of github.com/posener/complete to try
(29)  ← backtrack: no more versions of github.com/Jeffail/gabs to try
(28)  ← backtrack: no more versions of golang.org/x/oauth2 to try
(27)  ← backtrack: no more versions of github.com/hashicorp/go-cleanhttp to try
(26)  ← backtrack: no more versions of github.com/google/go-querystring to try
(25)  ← backtrack: no more versions of github.com/chrismalek/oktasdk-go to try
(24)  ← backtrack: no more versions of github.com/hashicorp/go-syslog to try
(23)  ← backtrack: no more versions of gopkg.in/yaml.v2 to try
(22)  ← backtrack: no more versions of github.com/ghodss/yaml to try
(21)  ← backtrack: no more versions of github.com/mitchellh/reflectwalk to try
(20)  ← backtrack: no more versions of golang.org/x/sys to try
(19)  ← backtrack: no more versions of google.golang.org/api to try
(18)  ← backtrack: no more versions of gopkg.in/mgo.v2 to try
(17)  ← backtrack: no more versions of github.com/hashicorp/go-multierror to try
(16)  ← backtrack: no more versions of github.com/hashicorp/go-uuid to try
(15)  ← backtrack: no more versions of github.com/mitchellh/go-homedir to try
(14)  ← backtrack: no more versions of github.com/mitchellh/go-testing-interface to try
(13)  ← backtrack: no more versions of github.com/golang/protobuf to try
(12)  ← backtrack: no more versions of github.com/hashicorp/go-rootcerts to try
(11)  ← backtrack: no more versions of github.com/hashicorp/go-plugin to try
(10)  ← backtrack: no more versions of github.com/mitchellh/copystructure to try
(9)	← backtrack: no more versions of github.com/jefferai/jsonx to try
(8)	← backtrack: no more versions of github.com/go-errors/errors to try
(7)	← backtrack: no more versions of github.com/hashicorp/go-sockaddr to try
(6)	← backtrack: no more versions of github.com/duosecurity/duo_api_golang to try
(5)	← backtrack: no more versions of github.com/hashicorp/errwrap to try
(4)	← backtrack: no more versions of github.com/fullsailor/pkcs7 to try
(3)	← backtrack: no more versions of github.com/armon/go-radix to try
(2)	← backtrack: no more versions of github.com/armon/go-proxyproto to try
(1)	← backtrack: no more versions of github.com/armon/go-metrics to try
  ✗ solving failed

Solver wall times by segment:
     b-list-versions: 15.993287545s
         b-list-pkgs:  1.449205562s
              b-gmal:  975.663417ms
  b-deduce-proj-root:    52.45496ms
         select-root:   14.219985ms
         select-atom:    4.123771ms
             satisfy:    3.600891ms
            unselect:     3.38189ms
            new-atom:     940.808µs
           backtrack:     500.397µs
     b-source-exists:      43.223µs
               other:      25.323µs
          b-pair-rev:      11.874µs
           b-matches:        5.97µs
      b-pair-version:       2.596µs

  TOTAL: 18.497468212s

No versions of github.com/hashicorp/vault-plugin-auth-gcp met constraints:
	master: Could not introduce github.com/hashicorp/vault-plugin-auth-gcp@master, as it has a dependency on github.com/hashicorp/vault with constraint master, which does not allow the currently selected version of

Note: I did not cut off the output -- it ends with selected version of <blank>.
This may be related to #1125.
Right now I have one package using dep and another using govendor. The project using dep is https://github.com/hashicorp/vault-plugin-auth-gcp which currently is depending on master of https://github.com/hashicorp/vault
(Side question: since its inception Vault has put a v in front of tags; does dep deal with stripping that off before semvering what's there?)
Right now Vault uses govendor and has these stanzas -- note how the packages are separate:
		{
			"checksumSHA1": "0+GdkCbe9GplobPLWizCNqhntbU=",
			"path": "github.com/hashicorp/vault-plugin-auth-gcp",
			"revision": "6d78c24a995a2df3188ca891db068fbecbc69262",
			"revisionTime": "2017-09-05T14:51:27Z"
		},
		{
			"checksumSHA1": "UsbYUscv6YGOBS7qNcCr3mVwuX8=",
			"path": "github.com/hashicorp/vault-plugin-auth-gcp/plugin",
			"revision": "6d78c24a995a2df3188ca891db068fbecbc69262",
			"revisionTime": "2017-09-05T14:51:27Z"
		},
		{
			"checksumSHA1": "2Fk5xIPOoKD4Of9cUIQPKXb2htg=",
			"path": "github.com/hashicorp/vault-plugin-auth-gcp/plugin/util",
			"revision": "6d78c24a995a2df3188ca891db068fbecbc69262",
			"revisionTime": "2017-09-05T14:51:27Z"
		},

I wanted to try switching Vault over to dep. But since the first package is a plugin of Vault, and since Vault builds the plugin internally into itself when possible, they both have a dependency on each other. In reality only certain packages in the Vault repo are needed, but splitting them out of the Vault repo isn't really feasible (again, the plugin is also built-in internally when possible).
No matter what revision/tag/whatever I try specifying in the plugin's Gopkg file, the result is the same other than in the output saying "...a dependency on github.com/hashicorp/vault with constraint ^0.8.2...". The last part of it "...currently selected version of" always ends blank.
Possibly this can be addressed using an override? But didn't quite see what I'd specify. Maybe I need to hand-create a Gopkg.toml? But if I do that, will future runs of dep ensure still have a problem, and/or will they add any direct dependencies I missed, and what should be inside that file?

hi, welcome! this is an interesting one 😄
easy thing first:

(Side question: since its inception Vault has put a v in front of tags; does dep deal with stripping that off before semvering what's there?)

yep. this actually the source of some consternation for me, because we consider tags with and without the leading v to be equivalent. i can't actually recall what happens when both exist, but i believe one clobbers the other. more tests & checks needed. anyway:

they both have a dependency on each other. In reality only certain packages in the Vault repo are needed,

we do support project-level cycles, at least in part. (technically we don't disallow package-level cycles, either, but only because it's yet to actually be a problem for anyone, and i've yet to find an efficient incremental graph cycle detection algorithm). we added support for it right around when we opened dep up - #116. but, back then, nobody was using dep, so there was no possibility of there being constraints declared back onto the root project. i didn't think about it in the initial implementation, so i just didn't cover that case - as evidenced by some of those failure messages simply stopping mid-sentence. that happens because we treat the root project specially in several ways within the solver.
i don't think the mechanics of a fix here are going to be very hard, but it's also not immediately clear to me what we should do. the only solution that's readily apparent to me is that, when a project-level cycle passes back through the root project, we simply drop any explicit constraints there.
the only immediate drawback i can think of - and this is just OTTOMH, it might not be a thing - is that it might be easy to create situations that are unresolvable, or at least where certain versions become unreachable, for either vault or vault-plugin-auth-gcp's dependers because constraints declared in one or the other project are only satisfiable when the other project's constraints are knocked out by my proposed rule.

Possibly this can be addressed using an override? But didn't quite see what I'd specify.

maybe, although i think the only thing that really work in the override is an "any", which i believe we don't actually allow the user to explicitly specify.

Thanks for the detailed write up!
The only thing I can think of offhand, and I realize this is likely yucky but I have 0.01% of your experience in this area, is to be able to declare an explicit binding between repos such that the constraint is that the revisions match. E.g. the branch must be master for both, or they must be using the same tag, or something. Then you can assume that they are in sync and add them as is rather than solving.
That probably doesn't make much sense, and it also doesn't solve the init problem, but thought I'd throw it out there.

an explicit binding between repos such that the constraint is that the revisions match. E.g. the branch must be master for both, or they must be using the same tag, or something. Then you can assume that they are in sync and add them as is rather than solving.

iiiiiinteresting!
it likely would be yucky, but i haven't seriously explored a line of thought like this before. it has a pretty clear antecedent in graph theory - vertex contraction - which at least means that i can consider its effects on the system in a more formal way. my gut says that we'd need to find more reasons for doing something like this than just this one, but because it rests on this mathematical foundation, we could likely find some. (though still, maybe too yucky)

doesn't solve the init problem

yeah, this is a trickier thing. we're having more and more init smoothness problems recently, but this is one that goes deep. i think we may not have much choice but to do the "ignore root constraints" thing i laid out in order to make init - and subsequent ensures - workable at all.

thought I'd throw it out there.

please, don't hesitate to do this!

I believe other HashiCorp products might also have this issue. Terraform for instance split its providers out into separate packages to make it easier for contributors to work on just a single chunk of code, but IIRC it means they need to import helper libraries and structs/interfaces from the main repo and it has to import many of these providers to build into the binary.
I realize this is likely to only affect projects using a plugin based model. OTOH Go now added first party support for plugins which probably makes this scenario more likely going forward.

I believe other HashiCorp products might also have this issue

honestly, i'd like it to be more common for other orgs to at least feel comfortable with doing things like this. it's also something that might benefit k8s - we're in the midst of trying to figure out how to support their staging/ dir, which isn't a plugin-style use case, but is still an issue trying to have projects where the development is closely coupled with a given repository "move with" that repository, while still having a canonical identity external to it.
(in fact, /cc @sttts @kris-nova - this may end up relating to k8s things)

OTOH Go now added first party support for plugins which probably makes this scenario more likely going forward.

i opened #347 a while back, but we backburnered it b/c there are just so many problems with the language's plugin system that the whole area is rather anemic right now. i actually wonder if causality may end up flowing in the other direction - with improved package management, plugins become more feasible to actually use in production, which in turn structures and drives improvements in the language support for them. ¯\_(ツ)_/¯

Don't know where the issue is at, but a colleague of mine wrote a quick fix that I've added to a fork of mine, thought I'd throw it in there in case that may help finding a more durable solution:
https://github.com/asticode/dep/commit/942f050b345a2ae531651f42d28266a5889a5301

@asticode yeah, that's the naive fix (well done finding that deep in the solver, lol 😜). if we denote the root project with an (r), it solves this problem:
A(r) <-> B

The thing i'm trying to find time to grapple with in finding that more durable solution is what that means when A is published, and this situation then occurs:
C(r) -> A <-> B

i don't think there's really much to be done here, per se, but i want to get my head around the possible effects before introducing this kind of change into the ecosystem. this kind of variability, while convenient in the small, could potentially produce very confusing situations in the large.

@manuel-huez it'll likely require too much reworking of things to make this work cleanly in dep as-is, so i'm going to defer this to dep's successor tool. More info on that soon™ 😄

I'd like to a see an experimental flag which implements https://github.com/asticode/dep/commit/942f050b345a2ae531651f42d28266a5889a5301 so at least dep can handle more cases than it can today, rather than waiting for months/years for another tool to do it. Gating it behind appropriately scary-sounding flag names seems reasonable.
I've recently hit this issue, and it's frustrating knowing that there is a workaround available.


Millennial is a minimalist Jekyll theme for running a simple, clean, …

…content-focused publishing

Merge to master


security: process checklist

process this list in order

deploy #199
submit page to https://hstspreload.org/

(already done)


Mkdocs fails

Describe the bug
The action for releasing the latest probatus version failed on MKDOCS.
To Reproduce
Run the release action
Error traceback
If applicable please provide full traceback of the error.
Traceback (most recent call last):
  File "/opt/hostedtoolcache/Python/3.10.12/x64/bin/mkdocs", line 8, in <module>
    sys.exit(cli())
  File "/opt/hostedtoolcache/Python/3.10.12/x64/lib/python3.10/site-packages/click/core.py", line 1157, in __call__
    return self.main(*args, **kwargs)
  File "/opt/hostedtoolcache/Python/3.10.12/x64/lib/python3.10/site-packages/click/core.py", line 1078, in main
    rv = self.invoke(ctx)
  File "/opt/hostedtoolcache/Python/3.10.12/x64/lib/python3.10/site-packages/click/core.py", line 1688, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/opt/hostedtoolcache/Python/3.10.12/x64/lib/python3.10/site-packages/click/core.py", line 1434, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/opt/hostedtoolcache/Python/3.10.12/x64/lib/python3.10/site-packages/click/core.py", line 783, in invoke
    return __callback(*args, **kwargs)
  File "/opt/hostedtoolcache/Python/3.10.12/x64/lib/python3.10/site-packages/mkdocs/__main__.py", line 310, in gh_deploy_command
    cfg = config.load_config(remote_branch=remote_branch, remote_name=remote_name, **kwargs)
  File "/opt/hostedtoolcache/Python/3.10.12/x64/lib/python3.10/site-packages/mkdocs/config/base.py", line 378, in load_config
    errors, warnings = cfg.validate()
  File "/opt/hostedtoolcache/Python/3.10.12/x64/lib/python3.10/site-packages/mkdocs/config/base.py", line [23](https://github.com/ing-bank/probatus/actions/runs/5681820734/job/15398792261#step:7:24)0, in validate
    run_failed, run_warnings = self._validate()
File "/opt/hostedtoolcache/Python/3.10.12/x64/lib/python3.10/site-packages/mkdocs/config/base.py", line 188, in _validate
    self[key] = config_option.validate(value)
  File "/opt/hostedtoolcache/Python/3.10.12/x64/lib/python3.10/site-packages/mkdocs/config/config_options.py", line 182, in validate
    return self.run_validation(value)
  File "/opt/hostedtoolcache/Python/3.10.12/x64/lib/python3.10/site-packages/mkdocs/config/config_options.py", line 1054, in run_validation
    self.load_plugin_with_namespace(name, cfg)
  File "/opt/hostedtoolcache/Python/3.10.12/x64/lib/python3.10/site-packages/mkdocs/config/config_options.py", line 1090, in load_plugin_with_namespace
    return (name, self.load_plugin(name, config))
  File "/opt/hostedtoolcache/Python/3.10.12/x64/lib/python3.10/site-packages/mkdocs/config/config_options.py", line 1108, in load_plugin
    plugin_cls = self.installed_plugins[name].load()
  File "/opt/hostedtoolcache/Python/3.10.12/x64/lib/python3.10/importlib/metadata/__init__.py", line 171, in load
    module = import_module(match.group('module'))
  File "/opt/hostedtoolcache/Python/3.10.12/x64/lib/python3.10/importlib/__init__.py", line 126, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 1050, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1027, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1006, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 688, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 883, in exec_module
  File "<frozen importlib._bootstrap>", line 2[41](https://github.com/ing-bank/probatus/actions/runs/5681820734/job/15398792261#step:7:42), in _call_with_frames_removed
  File "/opt/hostedtoolcache/Python/3.10.12/x64/lib/python3.10/site-packages/mknotebooks/plugin.py", line 17, in <module>
    from mkdocs.structure.pages import Page, _RelativePathExtension
ImportError: cannot import name '_RelativePathExtension' from 'mkdocs.structure.pages' (/opt/hostedtoolcache/Python/3.10.12/x64/lib/python3.10/site-packages/mkdocs/structure/pages.py)
Error: Process completed with exit code 1.

Expected behavior
This should not happen. A suggestion for a fix would be to reimplement mkdocs, since now we are using a lot of potentially outdated MKDOCS functions.

Does not seem like it.


Networkx MultiDiGraph attribute not found

I am using network 1.1 version as stated in Readme. and there is no edge_subgraph method in its documentation.. I tried with g.subgraph() as well but still it remain blank graph.
python scripts/visualize/plot_transaction_graph.py outputs/sampleaml/sampleaml_log.csv 2
Traceback (most recent call last):
File "scripts/visualize/plot_transaction_graph.py", line 81, in
g_ = get_alert_graph(g, alertID)
File "scripts/visualize/plot_transaction_graph.py", line 55, in get_alert_graph
g_ = g.edge_subgraph(edges)
AttributeError: 'MultiDiGraph' object has no attribute 'edge_subgraph'

Thank you for your report.
Sorry, we used edge_subgraph function (only in NetworkX version 2.x) by mistake.
We will replace it for version 1.10.

I fixed get_alert_graph function at plot_transaction_graph.py. Would you please try it again?

it worked


Ability to enable SubSocial on demand

We realized that comments put down our bundle before having Nuxt. Adding like 2-3MB right now.
Thus we would like to add user ability to require or show comments if they wish so.
Maybe adding some default switch to Vuex/Settings to make it default off, not showing, best if not loading importantly.
It will save our console log for some infrequent errors coming from Subsocial bundle.

We had it removed in #1273 being taking down our app :|


Fix failing tests on master

By removing default-members section from the root Cargo.toml, cargo test in CircleCI is not able to detect all the tests in the crates.
This PR adds explicit cargo test --workspace command which will run tests on all workspace members in CIrcleCI pipeline. It also fixes some failing tests on master.

Going ahead and merging this for now, since it's pretty useful to develop against locally


KodaDot 2.0 - beta & migration

This will be place holder issue to bit coordinate the transition to the new rewrite.
It will be starting with merging #843 into main-nuxt, then syncing main-nuxt with main, then switching gears to deployment running from nuxt/ folder.
https://github.com/kodadot/nft-gallery/pull/843#issuecomment-955709805 origin

Approx migration strategy

once merged and up to date
merge main-nuxt --> main --> remove main-nuxt branch
deploy nuxt instance from main branch nuxt folder and test it as beta
figure out missing functionality & open new PRs against nuxt/ folder
deploy it as SSR on Vercel and test with beta users
move /nuxt folder to upper root and old spa to /spa folder
create branch from main --> main-spa
delete /spa folder from main branch

https://discord.com/channels/840514076538830888/842717226758701056/904325916346421258

Probably all of the issues labeled with nuxt are related in time of writing this

Wanted nicer number for this beautiful milestone https://github.com/kodadot/nft-gallery/issues/1060


Discord link is broken

The discord link on the bottom of  the help page is relative path. It doesn't work.
https://github.com/MrBean355/admiralbulldog-sounds/wiki/Help

Thank you! Fixed 🔧


change login , register logo name  and customize welcome.blade

design a slider on welcome.blade page and change login , register logo name

modify the second time welcome.blade


Feature for remember previous chat or responses.

hello, I am using your project and found one little thing: it is not saving or remembering the previous responses for better results. can you provide anything related to this issue? Thanks

Use  conversation_id

Here are two examples to consider depending on the context:

reusable-session-object
fix-conversation-id-fix-context

Here are two examples to consider depending on the context:以下是需要根据上下文考虑的两个示例：

reusable-session-object  可重用会话对象
fix-conversation-id-fix-context修复对话 ID 修复上下文

You can refer this github to check usage of conversation id.您可以参考这个github来检查对话id的使用情况。

Hello, I am currently using your project. I've built a web page with Flask, but I've failed to maintain the conversation content. I have tried your installation methods, but I still haven't been successful. Each conversation is new. Could you provide me with some solutions? Could it be that the methods are no longer valid due to the official update on July 13th?
Here's my app.py code:
from flask import Flask, render_template, request
from bardapi import Bard
import os
import requests
import json

app = Flask(__name__)

session = requests.Session()
session.headers = {
    "Host": "bard.google.com",
    "X-Same-Domain": "1",
    "User-Agent": "Mozilla/5.0 (Windows NT 10.0; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/91.0.4472.114 Safari/537.36",
    "Content-Type": "application/x-www-form-urlencoded;charset=UTF-8",
    "Origin": "https://bard.google.com",
    "Referer": "https://bard.google.com/",
}
os.environ['_BARD_API_KEY'] = 'XXXXXX'
session.cookies.set("__Secure-1PSID", os.getenv("_BARD_API_KEY"))

@app.route('/', methods=['GET', 'POST'])
def home():
    if request.method == 'POST':
        user_input = request.form.get('user_input')
        token = os.environ["_BARD_API_KEY"]
        bard = Bard(token=token, session=session, timeout=30)
        response = bard.get_answer(user_input)
        ai_response = response['content']
        conversation_id = response['conversation_id']
        return json.dumps({'answer': ai_response, 'cid': conversation_id})
    return render_template('home.html')

if __name__ == '__main__':
    app.run(host='<IP_ADDRESS>', debug=True)

It would be a good idea to check for follow-up issues regarding related content. While some persistence is possible through context IDs and sessions, a complete implementation is not feasible. Therefore, consider options such as creating a database or sending multiple conversation queries simultaneously. Thank you.


jcc.appointments failed to get appointment details

result = add_appointment_to_calendar(settings, app_user, json_data['appointmentID'])
AttributeError: 'NoneType' object has no attribute 'locationID'

8b477e6bb4b5f2c07614eed28480bf1e5984b408 should fix it


Apply methods to speed up Express

Is your improvement request related to a problem? Please describe.
Now that the dashboard is growing and becoming more feature-rich, it becomes notably less performant.
Describe the solution you'd like
Investigate ways to speed up the Express server as well as any client-side Javascript.
Describe alternatives you've considered
The alternative is clear: no investigation whether the application's performance could increase.
Additional context
An article on various ways to speed up Express.

All steps to speed up Express other than running multiple instances have been taken. A reverse-proxy has been set up to serve static files as well as redirect HTTP to HTTPS and remove www subdomain among other things. The next step would be to implement a session database, such as Redis, such that the application can be clustered.


Test Windows MinGW target on CI

Rust defaults to the x86_64-pc-windows-msvc platform on Windows, but both it and x86_64-pc-windows-gnu are Tier 1. We should test cargo auditable on both.

Done as of 77f84b527036dd57020b60cc9eb9591e11466983


Fix content-type for keystone receiver

This fix content-type issue in v0.6.2-Daito-RC1 tag

LGTM


Add method to get window by id

Builds on the work that @kirilpopov did in #171 (see method). Currently just uses a static method on the window class, but we could move this into a separate class (like the initial PR) if necessary.

@DevAndyLee Refactored and remove the .only tag in the wrap test.


Create folder if it doesn't exist.

Hi,
I am trying to check if a folder exists and if not create it.
The folder structure  is "/images/[imageset]/monochrome",  "/images/[imageset]/color".  As in /images/1/monochrome, /images/2/monochrome, ...
When uploading initially via
   String ftpprobestring = "/images/img" + String(counter) ;
   String ftpprobestring1 = ftpprobestring + "/col";
   String ftpprobestring2 = ftpprobestring + "/bw";
   ftp.OpenConnection();
   ftp.InitFile("TYPE A");

  ftp.MakeDir(ftpprobestring.c_str());
   ftp.MakeDir(ftpprobestring1.c_str());
   ftp.MakeDir(ftpprobestring2.c_str());
   ftp.CloseConnection();

every the program works like expected.
But if I want to create a folder that already exists I get a "550" for each attempt to create a folder - even if the following folders do not exist. For example the folder /1/ exists but the folders /monocrome/ and /color/ do not exist - I still get 3 answers "550".
I tried to create a list and check if one of the strings in said list contains the respective expressions - no success.
Is there a way to check if a folder exists and then create it?
Or use the server message like ftp.changeworkdir; if (server message == 550 ) makedir?
Cheers

I am trying to check if a folder exists and if not create it.

How?

But if I want to create a folder that already exists I get a "550" for each attempt to create a folder - even if the following folders do not exist. For example the folder /1/ exists but the folders /monocrome/ and /color/ do not exist - I still get 3 answers "550".

The highlighted was  confusing, can you please elaborate?

Is there a way to check if a folder exists and then create it?

Not as a FTP commands: https://en.wikipedia.org/wiki/List_of_FTP_commands
You will need to do it manually, by checking if the folder exists. You can use ContentList(const char * dir, String * list) in order to check if the folder exists.

Hey thanks a lot for the response.
And also thanks A LOT for providing this library!

How?

I first tried with a string list via ContentList  and a for loop to check if an entry contains the dynamic variable. I encountered a problem that the list got too big for the memory I have available.
But I found your answer to https://github.com/ldab/ESP32_FTPClient/issues/11
This made me understand the Getftpanswer function.
So I added a an "Exists" function that is basically copy paste of ChangeWorkDir and a ExistStatus function that is a copy paste of GetftpAnswer, but sets an external flag "doesexist" instead of _isconnected.
I'm pretty sure there is a more elegant way, but this seems to work in the situations described above and doesn't use much memory.
Thanks again.

Sure that are better implementation, working with strings take a lot of memory, it would be better with char array, etc...
FTP by definition have some limitations :)


error: class '(null)' of input object does not respond to either selector writeToFile:options:error: or writeToFile:atomically

Im getting the above error when building?

Restart of xcode fixed the issue


Implement CRUD Operations on Model with Child Records for LLBL Gen Pro

See #17

Should be easy enough :)

I get a build error on a warning that's not really severe:
ModelWithChildrenRepository.cs(129, 15): [CA1822] Member UpdateAlt does not access instance data and can be marked as static (Shared in VisualBasic)

Is this necessary? Will try to suppress that warning


Deploy fluentbit as a deployment

Signed-off-by: chengdehao<EMAIL_ADDRESS>
What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #304
Does this PR introduced a user-facing change?

Additional documentation, usage docs, etc.:

Why redefine a new crd, can't reuse the FlunetBit crd?

The collector should be a statefulset, not deployment because there're position data to persist


Updated the gallery text fields demo

Uses the new InputDecorator features for filled/underlined and outlined text fields.


[SPARK-36702][SQL] ArrayUnion handle duplicated Double.NaN and Float.Nan

What changes were proposed in this pull request?
For query
select array_union(array(cast('nan' as double), cast('nan' as double)), array())

This returns [NaN, NaN], but it should return [NaN].
This issue is caused by OpenHashSet can't handle Double.NaN and Float.NaN too.
In this pr we handle NaN like Null value
Why are the changes needed?
Fix bug
Does this PR introduce any user-facing change?
ArrayUnion won't show duplicated NaN value
How was this patch tested?
Added UT

Test build #143136 has started for PR 33951 at commit 5c515b8.

ping @cloud-fan

Test build #143137 has started for PR 33951 at commit cb928ff.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47640/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47641/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47640/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47640/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47641/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47641/

Test build #143136 has finished for PR 33951 at commit 5c515b8.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143136/

Test build #143137 has finished for PR 33951 at commit cb928ff.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143137/

How does this differ from https://github.com/apache/spark/pull/33955 ?

How does this differ from #33955 ?

#33955 make all flag in SQLOpenHashSet,

Mind elabourating https://github.com/apache/spark/pull/33951#issuecomment-917524836? Also let's keep one PR only for the issue if we're clear on which approach to go ahead for.

Mind elabourating #33951 (comment)? Also let's keep one PR only for the issue if we're clear on which approach to go ahead for.

Make this as draft, you can go ahead on that pr.


Wrong path to .env file

I am refering to this line in your code:
https://github.com/sjafferali/paperless-titles-from-ai/blob/be49e58f51fe6aaf7bad4363351facd8102a8bb2/app/cfg.py#L6C2-L6C79
I think that if the volumes are set as suggested in your readme.md, then the .env file path should be: /usr/src/paperless/scripts/.env

Thanks @grostim . I have fixed this path in https://github.com/sjafferali/paperless-titles-from-ai/pull/6 .


chore(main): release faro-shop 0.22.0

:robot: I have created a release beep boop
0.22.0 (2024-07-12)
Features

Bump app to 0.32.0 (#519) (bafe85b)

This PR was generated with Release Please. See documentation.

:robot: Created releases:

faro-shop-0.22.0
:sunflower:


Can't edit fields when custom SQL query is applied

Refs https://github.com/CartoDB/cartodb/issues/4810
Steps to reproduce:

Open a dataset on which you have admin rights
Apply a custom SQL query / view
Double click on a value - the "edit" popup will appear with a text input
Try to focus / type in that input - nothing happens

@alonsogarciapablo @xavijam  Is this behaviour allowed? I'm asking because I saw the solution of ticket #4810 was that metadata is not editable during custom queries.
What about this case? Should a user be able to change values with a query applied?

Yep, if a custom query is applied you can't edit the data.
Closing ticket!

So wait, I'm not sure I understand - why is this behavior intended? Granted, when I was doing this it was to do the same thing as a Filter but with a SQL query, but when applying a Filter you can still edit data. Why couldn't this also work with custom queries?

Basically with the filter query we ensure that query belongs to the current dataset, so the JS behaviour we have for the table models will work as expected (in fact it is a POST to records endpoint). Imagine if you run a query requesting data from several tables, in that case our table model doesn't know how to run an update because it doesn't know which are the table, that's the reason why we can't enable the edition over the results.
Another example would be related with security. If you are in an organization, and you request data of a table from another user where you have readonly limits, you couldn't run any update over it.

Ah okay, thanks for the update @xavijam! In that case, rather than preventing edits in all cases, what do you think about allowing edits only if the custom query belongs to the current dataset (like with filters), and preventing it in all other cases?


*: TestKVRange to clientv3/integration, fix rev

For coreos#4338.
And resp.Header.Revision should be from the one in storage
when we just do range, because there is no storage data
change.

@xiang90 @heyitsanthony Test passed. Please review. Thanks!

@xiang90 Fixed to grab response header from Put and compare cluster, member id in Range operations (raft term, revision change during iteration).
PTAL.
Thanks!

@xiang90 Just fixed and test passed. PTAL. Thanks!

@xiang90 I don't see raft term changes anymore. The test failure in semaphore is not related to
this change. I will keep trying to reproduce raft term change.

LGTM


new paginated functionality added in GET /tasks

tests are yet to be created
API Contract

Closing this, as this feature is already implemented (https://github.com/Real-Dev-Squad/website-backend/blob/develop/controllers/tasks.js)


Retention Policy Inconsistencies

There are inconsistencies in how retention policies are created and
altered in our system.  I will attempt to outline the current behavior and then
we can come to a consensus on the desired behavior.
Create retention policy without default and with default
If you have a retention policy that is not the default, and then create it
again, with the same specifications, but add DEFAULT when creating it, it
will actually make that the default RP, even though it was already created.
> CREATE DATABASE metrics
> SHOW RETENTION POLICIES ON metrics
name    duration        shardGroupDuration      replicaN        default
----    --------        ------------------      --------        -------
autogen 0s              168h0m0s                1               true

> CREATE RETENTION POLICY daily ON metrics DURATION 1d REPLICATION 1
> SHOW RETENTION POLICIES ON metrics
name    duration        shardGroupDuration      replicaN        default
----    --------        ------------------      --------        -------
autogen 0s              168h0m0s                1               true
daily   24h0m0s         1h0m0s                  1               false

> CREATE RETENTION POLICY daily ON metrics DURATION 1D REPLICATION 1 DEFAULT
> show retention policies on metrics
name    duration        shardGroupDuration      replicaN        default
----    --------        ------------------      --------        -------
autogen 0s              168h0m0s                1               false
daily   24h0m0s         1h0m0s                  1               true

Since the replication policy is already created, creating it again with a
different specification (in this case DEFAULT) should error out with
retention policy conflicts with an existing policy.
This is a bug currently, but fixing it will result in a breaking change.  I'm
not sure what our stance is on breaking changes when it fixes a bug that was
undesired behavior.
Clarifying when DEFAULT retention policies should be created.
When using the CREATE DATABASE statement and including retention policy
information, that retention policy should get created, and become the default.
No other retention policy (not even autogen if it's enabled, should be
created).
Example when specifying retention policy.
> CREATE DATABASE "foo" with NAME "thing"
> SHOW RETENTION POLICIES ON foo
name    duration        shardGroupDuration      replicaN        default
----    --------        ------------------      --------        -------
thing   0s              168h0m0s                1               true

Example when not specifying retention policy.
> CREATE DATABASE "foo"
> SHOW RETENTION POLICIES ON foo
name    duration        shardGroupDuration      replicaN        default
----    --------        ------------------      --------        -------
autogen 0s              168h0m0s                1               true

This is the current behavior.  I am just confirming that this is still correct.

This is a bug currently, but fixing it will result in a breaking change. I'm
not sure what our stance is on breaking changes when it fixes a bug that was
undesired behavior.

In my opinion this is not a breaking change, it's a bug fix. If DROP DATABASE didn't actually remove a database in some cases, I wouldn't consider fixing that a breaking change. I don't see how this is any different. It seems to me like the current behaviour is not desirable and that the second invocation of the CREATE RETENTION POLICY ... DEFAULT should return an error.


Gnome: Update default regex and version filtering

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes? Here's an example.

[x] Have you successfully run brew typecheck with your changes locally?
[x] Have you successfully run brew tests with your changes locally?

The Gnome strategy's default regex uses the + form of the standard regex for matching versions like 1.2.3. However, with the switch to the new version scheme, some packages had a release that omits a minor and patch (i.e., 40 instead of 40.0). The default regex fails to match versions like this but the looser * form will match both. [When creating regexes, we generally start with the + form and only switch to the looser * form when it's necessary and contextually-appropriate.]
This also updates the default version filtering logic that's applied to versions using the old GNOME version scheme (below version 40). Outside of the refactoring changes, this also filters out versions where the patch number is 90+, as these are also unstable.
Comparing the output without/with these changes, the only difference is that unstable versions with a 90+ patch are now omitted. As before, if a formula doesn't use the GNOME version scheme, we can opt out of the default filtering by adding a livecheck block with a regex (we only have a few formulae meeting this criteria at the moment).

For what it's worth, I'll be expanding the Gnome strategy test cases as part of a forthcoming PR and these changes are covered as part of that. [These issues were surfaced as part of writing the forthcoming tests but I'm creating separate PRs for fixes beforehand.]

Review period will end on 2022-06-13 at 23:26:58 UTC.

Review period ended.


implement distinct count

Task CountDistinct(Expression<Func<T, bool>> where = null, {columns-for-distinct}, bool isIncludeDeleted = false);


:sparkles: Add alert to edit existing review

https://issues.redhat.com/browse/MTA-412

@gildub This one has a small conflict


Add property based testing based on fast-check in Jest

🚀 Feature Proposal
Property based testing can be seen as some kind of fuzzing approach. It makes users able to cover a wider range of inputs with a single test.
Motivation
fast-check proved very useful on Jest and was behind the following issues:

https://github.com/facebook/jest/issues/7975
https://github.com/facebook/jest/issues/7941
https://github.com/facebook/jest/issues/7937 (for this one, the tests of fast-check failed because of the regression so I started to dig a bit and run property based on expect of Jest to see if I would be able to find other bugs like this one)

It is currently being added in the test suites of Jest itself: https://github.com/facebook/jest/pull/8012
Example
I think the integration of fast-check within Jest could be something like the one I did for ava: https://github.com/dubzzz/ava-fast-check/ but I am very opened to discussions on this point.
My current wrapper works as follow:

It provides testProp - and certainly itProp for Jest
Its signature is: testProp(testName, generators, property)
What's great with this wrapper is that it adds the seed next to the test name so that the user can have access to the seed even in case the test goes into an infinite loop (if and only if Jest can stop it in this case).

// for all a, b, c strings
// b is a substring of a + b + c
testProp('should detect the substring', [fc.string(), fc.string(), fc.string()], (a, b, c) => {
  return (a + b + c).includes(b);
});

or maybe:
// for all a, b, c strings
// b is a substring of a + b + c
test.prop('should detect the substring', [fc.string(), fc.string(), fc.string()], (a, b, c) => {
  return (a + b + c).includes(b);
});

Pitch
Jest is a very successful testing framework.
Adding property based testing directly within Jest would give the community a new way to check their code. It might help the JavaScript community to detect new bugs they even not though about before. fast-check has already been useful in many projects, see https://github.com/dubzzz/fast-check/blob/master/documentation/IssuesDiscovered.md

Something useful for the integration: fast-check follows semantic versioning.
Patch version should not:

modify the values that would be generated by an arbitrary for a given seed - Except maybe if there is a crash or infinite loop in the generation part
impact the shrinking tree
impact replay - the same seed and path would lead to the same value - direct consequence of the two points above
add new features

A minor should not:

break existing APIs
remove depreciated APIs

I am obviously a little biased concerning the choice of the framework as I wrote fast-check. In a nutshell when I first wanted to do property based in my company I opted for jsverify but got stuck on some of its limitations (due to initial design choices). So I started to explore how it worked and somehow started fast-check.
Why fast-check?
Maintained, used by awslabs/aws-cdk for instance, multiple unique features: replay, verbose, commands for UI tests, pre-conditions...
More on the read me.

See https://github.com/facebook/jest/pull/7938#issuecomment-468319292

Having recently discovered https://github.com/facebook/jest/pull/8032, just wanted to note that if we integrate something like this, we should definitely do it in a way that does not impact performance for users who do not use this feature (i.e. not unconditionally require('fast-check') from jest-circus or something).
In general I think it would be cleaner to have this in a standalone package, along the lines of ava-fast-check. @dubzzz do you think there would be any technical difficulties with doing that or other reasons why integrating more tightly with Jest would be beneficial?

Great idea!

Initially, I was not planning to add fast-check as an internal feature of Jest. But when @SimenB suggested it I really thought about this idea: I personally do think it would be a great thing for testing in JavaScript.
Indeed Jest has always proved ahead of time concerning test methodologies. For instance, when it came with snapshot tests, many developers tried and adopted it.
In a way, fast-check would be able to live alone without being directly integrated as a dependency of Jest. Doing a jest-fast-check would not be a big deal on my side and I can do it without any problems.
But I believe that pushing the property based testing through Jest, as one of its features, would highly increase the usage of the technic among dev communities. The more people will use such methodologies the more they will be confident about their code.

I'm not totally against adding something like this and I'd like to hear what others think about this. Just wanted to note that if there's no technical reason why it should be in Jest core, we could also consider promoting it in other ways (documentation, jest-community, etc.).

Totally agree, there is no technical reason to move it inside Jest core. Promoting the approach through documentation or Jest community might also be great. I let you see what's the best option ;)

Potentially, Jest could tell the fuzzer to do more/less work depending on how much other work there is to do, whether it's watch mode or one-shot, and probably other considerations. But that would be a nice-to-have and probably need a deeper integration than is being considered.

Jest could tell the fuzzer to do more/less work [...] watch mode or one-shot

I really like the idea suggested by @quasicomputational. Indeed by default, property based tends to take longer than classical units because it runs 100 tests for each property.
If fast-check was integrated as a dependency of Jest, such feature would be easy to build. fast-check already accepts options telling it to do only N runs (instead of 100 which is the default).
Syntax: fc.assert(/* your property */, { numRuns: 10, /* other settings */ })
If not, I don't know if there is a simple and long-term way to know whether the test is running in watch mode.

Another feature that would be more difficult to integrate if fast-check is not directly part of Jest is the retryTimes - more
By default, what you would want to retry in the case of property based is not the test itself but the execution of one run of the property.

@SimenB Any opinions on this RFC?

Another benefit to having Jest know about the property tests: being able to isolate iterations better, including resetting mocks, timers and modules. This is particularly important to get right for shrinking, because if you've managed to contaminate the environment so that the property always fails, it'll be shrunk away to nothing and you get a useless report.

testcheck seems to have support for Jest (although maybe a tad outdated). And regardless of the integration it can still be used without it. I've had success using testcheck with Jest in the past. How would you compare testcheck with fast-check?

Today, fast-check can easily be integrated into Jest without specific tooling.
test('here is a jest test using fast-check imported as fc', () => {
  fc.assert(
    fc.property(
      fc.nat(), fc.nat(),
      (a, b) => expect(a + b).toBe(b + a)
    )
  );
});

The benefits of adding such technology directly into Jest will be:

more visibility on the approach
better integration in watch mode: smaller number of tests for watch mode, replay of the last failure if any...

Concerning benefits of fast-check over others. Today I would say shrinking capabilities go further (I can provide you example in private if you need to), replay options, verbose mode, pre-condition checks...

testcheck can also be easily integrated without specific tooling. Here's an example of a test in our source code:
  it('normalizes the spans to strictly positive integers', () => {
    check(
      property(partGen, part => {
        n(part).forEach(span => {
          expect(span).toBeGreaterThan(0)
          expect(Number.isInteger(span)).toBe(true)
        })
      }),
    )
  })

The reason I bring up alternatives is because the Jest API is already quite extensive and I wonder if adding property testing to the matchers is something that should be left to third-party libraries 🤔
I think it would definitely be useful as part of the built-in matchers. The question is if it should be built from scratch with a new API considering Jest's philosophy or if a third-party library should be embedded into it. I'd love to hear what the Jest core team's thoughts are on this.

Can you interleave properties/generation around describe/it?  For example:
describe("MyClass instances", () => {
  fc.property(myClassGen, myInstance => {
    it("has foo", () => {
      expect(myInstance.foo()).toBe(true)
    });
    it("doesn't bar", () => {
      expect(myInstance.bar()).toBe(false)
    });
    it("munges any YourClass", () => {
      fc.property(yourClassGen, yourInstance => {
        expect(myInstance.munge(yourInstance));
      });
    });
  });
});

Sometimes I want generator to be run for a "suite" rather than for each individual test, but only sometimes.

@dubzzz having a test.forAll with similar functionality as test.each and prop matchers would be another nice feature (both in the case of a jest-fast-check lib or integrating into jest)
examples:
test('sum is associative', () => {
  const sum = (a, b) => a + b
  // calling sum with nat should always return another nat
  expect(sum).toBeClosed([fc.nat(), fc.nat()], fc.nat())
})

If you are interested, I am working on a package to ease integration of fast-check with jest. See https://github.com/dubzzz/jest-fast-check
All suggestions are welcomed (marchers, watch options for easier and faster replays). Meanwhile, having fast-check as a first class citizen would be even better 😊

Actually already done, closing it!

@dubzzz there's an incoming seed CLI argument via #12922 - is this something you could use for seeding in fast-check? That PR doesn't expose it (and fails if normalize isn't provided), but that's an easy fix if it'd be useful exposed on e.g. jest.getSeed() or some such.

Whaou such a good news. If I can access it I could definitely leverage it for @fast-check/jest. Is there any way to access it from @jest/globals or will there be any?

I'm thinking of just putting it on jest.getSeed() or something if it's useful to you as is 🙂

What's the format for the seed? Double value? Int32? Uint32? Or maybe no strong guarantee?
jest.getSeed() would probably be good (can I get jest global from @jest/globals? No strong issue not to have it, mostly asking)

What's the format for the seed? Double value? Int32? Uint32? Or maybe no strong guarantee?

https://github.com/facebook/jest/pull/12922/files#diff-9dbb1da56fa2045712eef8db063b52b3555a799b93e858b7449b5561bef52d9fR1143-R1147
If link is wonky - current implementation is whatever the user passed (which we should validate to ensure it conforms to our contract) or generating one in the shape of Math.floor((1 - Math.random()) * (Math.pow(2, 29) - 1))

Perfect 🥰 I'll draft something into @fast-check/jest soon to leverage it, thank you so much for it @SimenB

note that it hasn't landed it, but I hope to do so in a week or two (I'm heading on vacation tomorrow), but exciting to hear it'll work for your use case 👍

You'll probably have the answer quickly: is there a way to get the currently registered beforeEach out of jest? Or even better manually trigger it?
Why would I need that for fast-check? Because I need to rerun beforeEach and afterEach before and after any execution of the predicate. So being able to either access the registered one or trigger it would help.

@SimenB Not sure it's the case in the current 'seed' implementation but do you display the seed in case of failure? When manually defined it's questionable but seems to be needed in the automatic seed case.

is there a way to get the currently registered beforeEach out of jest?

I don't think so - closest might be handleTestEvent?

Not sure it's the case in the current 'seed' implementation but do you display the seed in case of failure?

Not decided. My current thinking is just landing a way of setting a seed, and it's up to the thing that uses this seed to print it

Thanks for all these answers, I'll check them as soon as the version of Jest get released in order to improve as much as possible @fast-check/jest. But definitely the new seed and showSeed options will help a lot.
By the way, I'm planning to change the API of @fast-check/jest and make it even closer to the real one provided by Jest. Up-to-now it used to expose two functions (with extra options like .concurrent and co as Jest does) called itProp and testProp (see documentation). In the next major I plan to make the API closer than the one of Jest by providing a revamped version of it and test. This revamped version will come with a new extra option called .prop and can be seen as a .each but for Property Based Testing.
Not fully made my mind about how I'll do but here is the idea: 3303
It's probably a good target to have a very close API in @fast-check/jest if one day fast-check and .prop want to be part of Jest to have a very close API in @fast-check/jest.


Issue 4763: Use same string on failed login regardless of whether account exists when in paranoid mode

Addresses issue #4763.
If paranoid mode is enabled, Devise will use devise.failure.invalid whether or not the user is attempting to log in with an existing identifier.
Previously, log in attempts in paranoid mode were using devise.failure.not_found_in_database if identifier did not exist, or devise.failure.invalid if identifier existed but password was wrong.

Thank you @TonyMK9068!


Document typical invalidation for IVectorView and IIterator

In every conforming implementation I've seen for IVector, when the vector contents are modified, it will invalidate all previously obtained views (IVectorView) and iterators (IIterator), causing them to return E_CHANGED_STATE on subsequent operations.
This HRESULT is projected as:

winrt::error_changed_state in C++/WinRT
Platform::ChangedStateException in C++/CX
System.InvalidOperationException in .NET/C#

It would be extremely helpful to note this as the typical behavior, as well as providing guidance for implementers.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 373e61cf-6eb1-6908-0f87-1fb25449fbed
Version Independent ID: d2c31fce-5750-c7fd-4fa4-f28bcb202b6f
Content: IIterator<T> Interface (Windows.Foundation.Collections) - Windows UWP applications
Content Source: https://cpubwin.visualstudio.com/DefaultCollection/windows-uwp/git/winrt-api-build?path=%2fwinrt-api-build%2fwindows.foundation.collections.iiterator_t.yml&version=GBlive&_a=contents
Product: uwp
Technology: winrt-reference
Git Login: hickeys
Microsoft Alias: hickeys

#1271 is related

Thanks for submitting your feedback and we apologize for the delayed response. I see that updates have not been made since the creation of this Issue, so I went ahead and created an internal work item to engage with our engineering folks, find the answers, and resolve this doc bug. There are several related IVectorView issues that I'm consolidating into one internal work item. The timeline for this may vary, so I will go ahead and close this and circle back when the changes are live.
We have moved to a new feedback system, and I want to ensure that we don't lose access to the feedback in our open issues. Though the Issue will be marked as Closed, we will monitor any replies that come afterwards so treat this like an open Issue. Many thanks.


Fix/type hierarchy

Fixes
Fix typing parsing. Changed structure from list to dict. This PR addresses issue #70. As mentioned in #70, we only allow the either keyword in the parameters spec.
This PR also fixes #76, #77 and #78.
Types of changes
What types of changes does your code introduce?
Put an x in the boxes that apply

[x] Bugfix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist
Put an x in the boxes that apply.

[x] I have read the CONTRIBUTING doc
[x] Lint and unit tests pass locally with my changes
[x] I have added tests that prove my fix is effective or that my feature works

Codecov Report

Merging #73 (d5bcee7) into main (ad68c05) will increase coverage by 0.31%.
The diff coverage is 95.83%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main      #73      +/-   ##
==========================================
+ Coverage   88.30%   88.62%   +0.31%
==========================================
  Files          20       20
  Lines        1052     1064      +12
  Branches      164      169       +5
==========================================
+ Hits          929      943      +14
+ Misses         95       94       -1
+ Partials       28       27       -1

Flag
Coverage Δ

unittests
88.62% <95.83%> (+0.31%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pddl/parser/domain.py
82.17% <83.33%> (+1.17%)
:arrow_up:

pddl/core.py
92.41% <100.00%> (ø)

pddl/custom_types.py
100.00% <100.00%> (ø)

pddl/formatter.py
98.33% <100.00%> (+0.25%)
:arrow_up:

In my opinion, the PR is in a good state. The code regarding consistency checks and parsing, if possible, can be improved in the future; in this PR we can focus on the functional part.

Looking now...

Looking pretty awesome to me! Not sure I'm a fan of the type_=.. syntax, but I don't have anything better to suggest at the moment ;). Let's merge it up.


fix NB_PREFIX url

For reference: the link to the notebooks from KF is not clearly editable.  For example, in the KF Servers homepage, the link 'Connect' does not reflect the location of the VSCode location directly.  The NB Code in pod.py (in orbit-controller) works correctly.  Since we removed kubespawner and replaced it with KF, the parameter 'default_url' is not able to be injected.

The NB code appears to work correctly.  More research into KF and the link it provides is needed


Update<EMAIL_ADDRESS>

Update rollup-pluginutils to a version which contains a fix for the braces package vulnerability.
https://nodesecurity.io/advisories/786

Thanks!


Remove CloudControllerManagerSpec from the External platform spec

Due to priority changes for the Installer Flexibility effort,
the decision about temporarily removing CloudControllerManagerSpec from the Infrastructure resource was made.

External platform API PR
Enhancement doc update PR

cc @elmiko @JoelSpeed

/cc @elmiko
/cc @JoelSpeed

I spoke to Denis before about this, this API was merged during the 4.13 cycle, but we aren't going to get to implementing it within 4.13. Best to remove the API and reintroduce it in a later release when we are ready to implement the backing logic
/approve


docs(readme): make docs badges more consistent

Just using shields to make the docs badges more consistent.  Feel free to close this if you think it isn't an improvement.

[X] The commit messages match the guidelines in https://github.com/hyperium/hyper/blob/master/CONTRIBUTING.md#git-commit-guidelines

Looks nice to me, thanks!


python-syntax doesn't load after default vim syntax file

There seems to be a bug in the logic that detects previous syntax files here. On my Ubuntu machine with Vim 8, the default vim syntax file gets loaded first: /usr/share/vim/vim80/syntax/python.vim
This sets the '''b:current_syntax''' variable meaning the ptyhon-syntax script exits early due to the above lines. This results in several problems like missing highlights (#26 ) and commands missing (#61 ). Is this something specific to my setup or an actual bug?

This syntax plugin needs to be loaded before any others, otherwise it will just return without doing anything. Just like the builtin syntax files do.
@Congee That has nothing to do with op's problem. If you want to define more keywords, you can do so easily in your personal config. Or if there's some keyword you feel that everyone could benefit from you can open a PR.


Store selected directories in localStorage

Saves the selected directories on update to localStorage and retrieves as the loading default.

@manthey Would we want to clear these from storage at some point and if so under what circumstance?

@manthey Would we want to clear these from storage at some point and if so under what circumstance?

Provided we handle the directories no longer existing, and, in that case default to something sensible, I think it is okay to not delete them.

We should show the images in the input directory if they are present.


Missing explicit IPMI channel numbers in set_bmc_credentials.sh

Some ipmitool commands in set_bmc_credentials.sh do not specify a channel number so the "currently used" channel is utilized. This causes problems in our hardware:
root@sut1-server2-pub:~# ipmitool user list
Get User Access command failed (channel 14, user 1): Invalid data field in request
root@sut1-server2-pub:~#

This causes the whole BMC credentials setting to fail.
The commands without a channel number are these:
cmdReturn=$(ipmitool user list)
...
cmdReturn1=$(ipmitool user summary)

The rest of the code suggests that channel 1 is to be used (judging from for example "ipmitool channel setaccess 1 $userNumber callin=on ipmi=on link=on privilege=4"), so the fix could be as simple as adding the channel number 1 to the commands listed above (e.g. "ipmitool user list 1" and "ipmitool user summary 1"). In our hw, using channel 1 works as expected.
Another option would be to figure out which channel works with something like this:
...
channel=''
function set_channel()
{
    for i in {1..15}; do
        ipmitool user list $i &>/dev/null
        status=$?
        if [ "$status" -eq "0" ] ; then
            channel=$i
            break
        fi
    done
}
set_channel
echo " Getting the user list from $channel"
cmdReturn=$(ipmitool user list $channel)
...

fyi @keedya @RackHD/corecommitters

Adding @uppalk1, @tannoa2

Agree with that. I will fix it and update.

@psalmia just out of curiosity, which hardware is this causing problems with? Is that something you can share?

For reference, the effort to cover resolution/update for this issue is being tracked in PT : https://www.pivotaltracker.com/projects/1492890/stories/117244649

The HW is Quanta STRATOS S210-X22RQ rackmount server.
On a related note, we have found a similar issue also in an HP ProLiant DL380p Generation8 server:
[root@S12 ~]# ipmitool user list
Get User Access command failed (channel 14, user 1): Parameter out of range
[root@S12 ~]# ipmitool user list 1
Get User Access command failed (channel 1, user 1): Parameter out of range
[root@S12 ~]# ipmitool user list 2
ID  Name             Callin  Link Auth  IPMI Msg   Channel Priv Limit
1   Administrator    true    false      true       ADMINISTRATOR
2   (Empty User)     true    false      false      NO ACCESS
3   (Empty User)     true    false      false      NO ACCESS
4   (Empty User)     true    false      false      NO ACCESS
5   (Empty User)     true    false      false      NO ACCESS
6   (Empty User)     true    false      false      NO ACCESS
7   (Empty User)     true    false      false      NO ACCESS
8   (Empty User)     true    false      false      NO ACCESS
9   (Empty User)     true    false      false      NO ACCESS
10  (Empty User)     true    false      false      NO ACCESS
11  (Empty User)     true    false      false      NO ACCESS
12  (Empty User)     true    false      false      NO ACCESS
[root@S12 ~]#

The difference is that even channel 1 is not working by default, so perhaps it would indeed be a good idea to figure out a working channel and use that.

Below PR has been created. Please take a look and see if it works. Thank you for the find and ideas on the fix.
https://github.com/RackHD/on-http/pull/234


Support to Ignore user provided files in state calculations.

Thanks for this amazing tool, glide was problematic.
We check in our cross project vendor folder. Long story short would it be possible to add a glob to exclude files from status checks -- e.g., **/BUILD.bazel.
Apologies if I have overlooked this support already, couldn't find anything in the documentation.
The long version. Using the Bazel build system with go can be quite a challenge -- the general strategy with the Bazel go rules is that it creates it's build files out-of-source for vendor directories. But this is problematic when cross compiling as build tags are not yet supported.  To work around this the build files need to be generated for the vendor folder and customised. govendor status calculations go blind once BUILD.bazel files are mangled in.
This is also how the Kubernetes project manages it's vendor folder with Bazel.

Thanks @hsyed for the suggestion. You're correct, nothing supports that right now. I'd be interested in supporting these features, but right now am low on time.
At some point in the future I'd like to go through the backlog and include features like this.


package apt-transport-https should be installed

Ubuntu default install not include apt-transport-https. so if you want to download package from https repo, you need install apt-transport-https package first

This change is

/lgtm
But travis looks messed up right now.

Travis should be fixed now. Try rebasing/updating the branch.

Travis should be fixed now.


Toast will be hidden by keyboard

I use the toast to show error message when user inputing something. But this toast won't show only when i dismiss keyboard.

I think we can't create a UIWindow above the keyboard since iOS 11. As a workaround, I did this
`let windows = UIApplication.shared.windows
windows.last?.makeToast("toast message")
`

This is up to you to decide where to present the toast. This is not an issue with the library.

still covered by keyboard now, im using https://github.com/nathantannar4/InputBarAccessoryView


brought dependencies inline with the latest versions of flutter and dart

flutter_localizations dependency (intl: ^1.18.0) clashes with this package (intl: ^1.17.0)
this PR resolves this problem

Hi Hannes,
Thank you for your help, but this dependency version update was already made on hotfix branch, including to the version 1.18.1. But anyway, thank you so much.


Branch patron book changes for PR comments

Refactored and fixed javadocs.

Codecov Report

Merging #64 (27adc3b) into master (bbdea71) will not change coverage.
The diff coverage is 83.65%.

@@            Coverage Diff            @@
##             master      #64   +/-   ##
=========================================
  Coverage     71.87%   71.87%
  Complexity      530      530
=========================================
  Files            87       87
  Lines          1625     1625
  Branches        189      189
=========================================
  Hits           1168     1168
  Misses          399      399
  Partials         58       58

Impacted Files
Coverage Δ

...main/java/seedu/address/commons/core/Messages.java
0.00% <ø> (ø)

...ss/logic/commands/exceptions/CommandException.java
100.00% <ø> (ø)

...in/java/seedu/address/logic/parser/ParserUtil.java
94.73% <ø> (ø)

...s/logic/parser/patron/FindPatronCommandParser.java
100.00% <ø> (ø)

src/main/java/seedu/address/model/person/Id.java
72.72% <ø> (ø)

.../java/seedu/address/model/util/SampleDataUtil.java
17.14% <0.00%> (ø)

src/main/java/seedu/address/ui/MainWindow.java
0.00% <0.00%> (ø)

src/main/java/seedu/address/ui/PersonCard.java
0.00% <0.00%> (ø)

...rc/main/java/seedu/address/ui/PersonListPanel.java
0.00% <0.00%> (ø)

src/main/java/seedu/address/model/AddressBook.java
84.61% <92.30%> (ø)

... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bbdea71...27adc3b. Read the comment docs.


Remove the SOAP api code from the repo (pycontrol)

The current library has a pycontrol module in it that manages a connection to the SOAP interface of the BigIP.  After talking with @jgruber he sees no reason for us to keep it given the new object/manager direction for the library.  We should be able to accomplish everything we need to with the REST API.
We should remove this code and if we need a SOAP session manager we should create an f5-icontrol-soap library like the f5-icontrol-rest library.
I did some looking around at the library and it doesn't appear that anything really uses this except for SSL certificates, but after discussion we can do this with the REST API and a SSLManager to be written in the future.

@swormke I think I can wrap this up too.

Unless sys/system.py and/or cm/cluster.py are tricky.


Things that we miss in BashOnWindows

Hi, we are a team who work using node.js. We are very excited about BashOnWindows because using it, we can write bash scripts to setup, and start our development environment in any OS. There is only two things that we miss in order to use it efectively:

Launch new terminals: Since there is no graphic server, We can't run commands in a new terminal. For example, I can't write a script that starts 'webpack-dev-server' and 'meteor'. In practice, this is a huge limitation.

Lack of file exposure: If you copy a file from Windows to BashOnWindows using the file explorer, you won't be able to reach it on bash. The only way to achieve that, is with a bash command like:
cp /mnt/c/path/of/a/windows/file /home/user/file

In practice, that means that my team don't have a graphical file explorer. They find it a very frustrating way to work. That's why we've decided stop using BashOnWindows by now. Hopefully our experience will help you to improve (or give us some hints). Feel free to ask us anything.
Thank you for all your efforts.
Adrian.

@Zeioth both of these are duplicates and both are being worked on.

Since there is no graphic server, We can't run commands in a new terminal. For example, I can't write a script that starts 'webpack-dev-server' and 'meteor'.

Wait, webpak servers don't (or shouldn't) have anything to do with lack of a graphic server. Web clients and web servers speak http, which WSL does fine. You can run firefox or chrome with VcXsrv, which is not an endorsed scenario, or you can run the Windows web clients via interop, which is. But either way a https server on WSL is entirely supported, and does not even require interop. The web client can be in another country let alone running on a native X11 server on WSL. Or I am misunderstanding your ask.

If you copy a file from Windows to BashOnWindows using the file explorer, you won't be able to reach it on bash.

Working on it.

You could use mc (Midnight Commander).


Breadcrumb click area is larger than area that gives mouse cursor feedback

🐛 Bug Report
You can click a breadcrumb item anywhere in its underlying div to navigate to its page. But the mouse cursor only changes to indicate that it's operable and the URL preview for the browser only appears when hovering over the link.
https://user-images.githubusercontent.com/10500124/168139383-fa8b5449-83f6-4371-bf11-8e7d5345fd4f.mov
💻 Repro or Code Sample
SLE Files app: https://enterprise-dev.systemlinkcloud.io/systems/20UCS1L10N--SN-PF2N6M5J--MAC-8C-8C-AA-F9-72-56/files
🤔 Expected Behavior
Either:

only the link is clickable
the whole item is clickable but it gives standard link feedback (cursor and URL preview)

😯 Current Behavior
Entire area clickable but only link gives feedback indicating so.
💁 Possible Solution

🔦 Context
Reported by Gergo at the UI Working Group
🌍 Your Environment

@msmithNI, it looks like the bug involving delegatesFocus: true and the component entering the :focus-visible state too aggressively has been fixed in chromium. The second bullet point in your comment should no longer be the case.

From the bit of debugging I did, this appears to be an Angular-only issue. The RouterLinkWithHref directive, which the NimbleBreadcrumbItemRouterLinkWithHrefDirective extends, adds a click handler that performs the navigation. The NimbleBreadcrumbItemRouterLinkWithHrefDirective applies to the entire nimble-breadcrumb-item rather than just the anchor element within its shadow root. As a result, clicking anywhere within the nimble-breadcrumb-item will cause the navigation to occur.

I looked into swallowing the click event if it was outside the bounding rect of the anchor element (in breadcrumb item's shadow DOM), but no luck. The RouterLinkWithHref``s s onClick method doesn't get the event, so we don't know the coordinates of the click to compare against the bounding box of the anchor. I tried to think of other solutions, but came up empty.


Updating documentation to be PEP-8 compliant in code samples and Django 1.8+ style settings.

I've updated the README so the code samples are compliant with PEP-8 (4 space indents), so they can be copy / pasted more easily into settings files. I've also updated some of the settings to reflect the style introduced in Django 1.8 for templates and URLs. Since only 1.8 and 1.9 are current supported (https://www.djangoproject.com/download/#supported-versions), this seemed to be the right time. Thanks for all of your work!

Thanks!


devtools::check() fails on license

❯ checking DESCRIPTION meta-information ... WARNING
  Non-standard license specification:
    `use_mit_license()`
  Standardizable: FALSE

Resolved in #177


[Client] Market AMM UI issues

Addendum: Top element is always Lords.
Component should be changed accordingly

resource icon not centered correctly on 100% viewport

Can only select one resource for both top and bottom element

Max value displayed on wrong side (Or right side, but should be selected in the top row then)

Deleting a number gives 'Nan' instead of '0', and is a pain to turn into a number again

fixed by #1400


Honor :inputs option in .formatter.exs

mix format reads the :inputs option in .formatter.exs to include files.
This pull request makes ElixirLS check the same :inputs option to decide if a file should be formatted.
Fixes https://github.com/elixir-lsp/vscode-elixir-ls/issues/120.

Thanks for this! It looks good. Could you add a test for this functionality? I'll work on trying to get the test suite back to green.

Test added. Behaviour changes according to .formatter.exs so I must make the inner implementation public and unit test that instead.


[AST] Adopt SubstitutionMap as the storage mechanism for substitutions

Start adopting SubstitutionMap as the storage mechanism for substitutions, replacing instances of SubstitutionList within AST nodes (and some APIs) with the uniqued, ASTContext-allocated SubstitutionMap. Specifically:

Make SubstitutionMap (de-)serializable, so we can easily embed a substitution map in the on-disk layout of an AST node
Switch NameAliasType over to storing a SubstitutionMap; eliminate corresponding SubstitutionList APIs.

@swift-ci please smoke test

@swift-ci please smoke test Linux


update(config): add callout for Windows path in torrentDir

Includes a couple of other minor language updates for better grammar.

Already in v6 that are pending merging.

https://github.com/cross-seed/cross-seed/pull/659/files#diff-15fff026bce4fedcf9bc7e8b8bd8b19fcecb75ab072483bed46b487f07e7d89e


Fix various issues encountered on Windows

There are a few things going on here, some specific to Windows and some are
race conditions that are just easier to hit on Windows but can be
reproduced on Linux if you add some delays.

So what you have to do is to make the hGet fail somehow, e.g., by
terminating the process that the hGet is reading from which will
make hGet fail.

You already terminate the process by sending the exit notification.
However, there is a race condition where listenServer will throw an
UnexpectedServerTermination exception after the server has
terminated as a result of the exit notification. On Linux, you
usually get lucky and end up killing the listenServer thread first
but due to 1 you always hit this on Windows. If you add a delay
after sending the exit notification you can also reproduce this on
Linux.

You need to set the handles to binary mode. Otherwise you end up
with newline conversions turning \r\n into \n which will cause
parse errors.

Thanks!


Add 8-10 dimensional Morton codes

I want to run ArborX on some higher dimensional datasets, so I thought I'd put that in. Should have done it in #853 but I didn't need it at the time. I don't expect to go higher than 10D right now.

Builds pass for once, just some warnings from the container builds.


Handle panics that percolate up to the graceful module

Log panics that percolate up to the graceful module with a stack trace and shut down the gitea instance as appropriately.
Also adds a panic handler to webhook.Deliver and mirror.syncMirrors.

Codecov Report

Merging #11291 into master will decrease coverage by 0.05%.
The diff coverage is 20.00%.

@@            Coverage Diff             @@
##           master   #11291      +/-   ##
==========================================
- Coverage   43.85%   43.80%   -0.06%
==========================================
  Files         607      607
  Lines       86893    86932      +39
==========================================
- Hits        38110    38079      -31
- Misses      44085    44143      +58
- Partials     4698     4710      +12

Impacted Files
Coverage Δ

services/mirror/mirror.go
18.38% <0.00%> (-0.37%)
:arrow_down:

modules/graceful/manager.go
28.07% <10.71%> (-3.18%)
:arrow_down:

modules/webhook/deliver.go
46.35% <83.33%> (+1.19%)
:arrow_up:

services/pull/update.go
52.54% <0.00%> (-6.78%)
:arrow_down:

services/pull/check.go
50.00% <0.00%> (-5.49%)
:arrow_down:

services/pull/temp_repo.go
29.05% <0.00%> (-5.13%)
:arrow_down:

services/pull/patch.go
62.93% <0.00%> (-2.80%)
:arrow_down:

modules/git/command.go
86.95% <0.00%> (-2.61%)
:arrow_down:

modules/git/repo.go
51.88% <0.00%> (-1.26%)
:arrow_down:

modules/notification/webhook/webhook.go
43.00% <0.00%> (-0.59%)
:arrow_down:

... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99082ee...495183c. Read the comment docs.


Implement Website Design

Implement the design from (Website Layout Design)

@Limeiz @sanlju  I think this should be the priority right now before we add more features


Mention scala_proto_register_toolchains in docs

Hi, thanks for this project! I was trying to get a simple example working with scala_proto_library and kept getting a no matching toolchains error from bazel. After reading the bazel docs on toolchains and this repository's WORKSPACE file I realized that I needed scala_proto_register_toolchains in my WORKSPACE and got things working. It would be great if the docs mentioned this!

@luser sorry we missed this! I'm glad you figured it out though. I'll update the docs later today to clarify this.


Delete user and roles is not possible

Hi,
I'm using your fantastic package but I have a weird issue.
I could delete user and roles easily but now it's not working anymore. I'm redirected directly on the controller's index view
I do not change middleware or other.
What do you think ?
Thanks for your time,
Regards

Did you make any other changes to your application?   If it was working at one point you may need to see if you can pin down the commit that broke it.
Are there any errors being logged?

Hi,
I just get a 302 when  the destroy function of UserController is called. It is not executed at all.
I've commited after I've got this problem so I can control exactly what error I have.
It's juste the deletion of a user or a role. The rest works like a charm.
Besides, no errors from my app.
Regards

It is possible that there is something wrong with your route spoofing  The delete requests are listed in the routes as "delete" http actions.  To facilitate that, Centaur uses a special javascript file to automatically convert links to "delete" routes to forms that are submitted with the "_method" parameter.

You're absolutely right ! The restfulizer.js file was not included in my master blade template.
That's why the delete method didn't work.
Thanks again for your help and your expertise, you help me a lot ;)

I had the same issue.
@t-prod what you think about adding this information regarding restfulizer.js to the documentation (e.g. wiki)?

How does this look?  https://github.com/SRLabs/Centaur/wiki/Form-Method-Spoofing

@rydurham great! Thank you!


Annotations: Change remove button to a close button

Fix #63
We don't see the mouse in the screencast, I'm:

Opening the annotation in the 3D view using the circle handler
Closing it with the close button (the cross)
Reopening it
Removing it with the delete button (the bin)

Screencast from 2023-01-02 17-50-28.webm

It works great! Thanks @martinRenou. Since I'm a fan of Windows 😃 , I'm feeling more consistent using the bar as the minimize icon and keeping the cross as the delete icon. What do you think?

I'm feeling more consistent using the bar as the minimize icon and keeping the cross as the delete icon. What do you think?

It's indeed more consistent with the cross for removing the 3D objects in the tree view 👍🏽
I'd be more confident with a dialog asking for delete confirmation if we use this UI. With the previous implementation my first impression was that the cross would just close the annotation and allow me to show it again later, not delete it, a delete confirmation prompt would have helped me.
Did you change the icons locally? Could you push it as a commit on my branch?