feature: Add UNIX socket support

I need some help here:

I could not figure out how to test the socket abstraction. spawn in the spec_helpers uses a real address. I don't know if I could just change it to another and let it go.
For some reason the test for UNIXServer is failing (but that I can figure out myself)
How would the cli work if everything needs a default value? Should not we handle hostname, port, unix file as just address?

Thank you!

@mauricioabreu the code is quite nice, I will take a proper look tonight and try to answer your questions
!

@marceloboeira Thank you!

No, thank you for all the support.
:)
On Fri, Sep 2, 2016 at 10:13 AM Mauricio de Abreu Antunes <
<EMAIL_ADDRESS>wrote:

@marceloboeira https://github.com/marceloboeira Thank you!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/marceloboeira/bojack/pull/49#issuecomment-244311795,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABz28V_tPiJ6TvuGD1l-5FeRhMNpvRSRks5ql9q0gaJpZM4JzL-U
.

--
Marcelo Boeira

I was reading a book these days, "Practical Object-Oriented Design in Ruby". In the beginning of this book the author talks about the case where we create functions that need hostname and port and she asks why we don't call it just address.

@mauricioabreu the thing is, you can have the hostname and port together, for sure. BUT you have to consider you are adding a responsibility to the class that receives the address, to split it. Since we don't use as an address, now this responsibility is credited to the "user".
If you add this logic and continue to do this for the dependencies, you make the server class handle a lot of functions, which is not what is supposed to do.
The best way to do it, in my opinion, would be to have a BoJack::Address class, that receives the input and return hostname and port. The server receives the address object instead of 2 strings.

@marceloboeira I was not thinking in adding this code to the server. Just like you said an Address object could handle it. We just use the address to create the socket and logging. Not sure if we actually use the hostname and port for specific cases.
Anyways, I am kinda lost with this PR. Commander needs a default value for every argument. This way I can not check if the user is trying to connect via TCP/IP or UnixSocket.

I am trying to solve this issue without this refactor (I am not sure if we need to have this refactor).
Reading the redis CLI it uses hostname and port (-h and -p)

Well, one idea is to have a default "empty" for the Unix socket since it is not the default way to run BoJack.

Basically, what we need is to decide the default interface: Unix/TCP.
My opinion, TCP should be the default, then we could have a flag: "--unix", "--use-unix-socket", if the flag is true then hostname as port are ignored.
What do you think? less effort and it is backwards compatible.

@marceloboeira I agree that TCP should be default.
The problem here is that other parts of the codebase rely on "hostname/port" like BoJack::Logger.build

@mauricioabreu hmm, maybe it is not relevant at all to have the hostname and port in the log after all.

@marceloboeira For developers/teams who watch logs and take actions on behalf of them it is useful.
Does it make sense?

@mauricioabreu in order to make it simple, create a logger initializer that initializes with the socket path, for another formatter, so a formatter for TCP and another for UnixSocket.

Bad rebase here.

Look how Postgres approach the CLI options.

Thanks for sharing @marceloboeira
redis-cli does it by having a unix-socket-file argument.
I am still trying to solve the code which passes the right socket ahead (UNIXServer or TCPServer). After solving this problem I will get back to the CLI.

@mauricioabreu yes, I think the unix-socket-file it is better. I just found interesting the way PGSQL does and wanted to document it here.

@marceloboeira thank you! It is good too see how others are handling this problem.

It looks like I am bad at overloading stuff. 😭

Sorry :( bad memory here

@mauricioabreu no worries, I am actually testing something with the webhooks, that's why I closed and reopened
ahha

@marceloboeira haha :P I am studying crystal again. Maybe it is time to get back to this pull request


Blazor Web Assembly - Deploy Azure Static Web App (Preview) appsettings.json issue

I'm using Deploy Azure Static Web App (Preview) task in my Release pipeline and I'm facing issue by not being able to replace appsettings.json values.
Here are the steps I'm doing.

In the build pipeline

NUGET restore
dotnet publish -c DEBUG

Release pipeline

replace appsettings.json values with a custom values (Because of multitenant configuration).
Use Deploy Azure Static Web App (Preview) to deploy my Blazor WebAssembly app.
No Oryx build is being used since it has been already built.

Result:

app deployed successfully but appsettings.json has not been updated.

Debug Results:

[x] I ran an echo script to make sure the appsettings.json file generated is correct(the one I wanted).
[x] Tried to create a new file (file named tenantsettings.json) to see if it's being updated and as a result it was updated successfully.
[x] Tried to have unpublished Blazor flies and used the Oryx build. the appsettings was updated successfully but I was having some issues with (text/html), css, Blazor not found issues in the console and the app was not loading at all.

I do not have the whole yaml file of the release as I'm using the classic release pipeline. What I have is the yaml of each task.
Please find below the tasks in yaml in order
1- Setup the config file pf a custom tool that will generate my appsettings.json
- task: jakkaj.vsts-yaml-writer.custom-build-release-task.YamlWriter@0 displayName: 'Update static web wettings'   inputs:     file: '$(System.DefaultWorkingDirectory)/_deployments/tools/StaticWebMultitenantConfig/appsettings.json'     set: 'Tenants="$(Host)",ApiUrl="$(HostApi)",AuthorityUrl="$(AuthUrl)",InputSettings="$(System.DefaultWorkingDirectory)/_deployments/web/Client/wwwroot/appsettings.json",OutputFile="$(System.DefaultWorkingDirectory)/_deployments/web/Client/wwwroot/tenantsettings.json"'     json: true
2- Run the custom tool to generate the settings and replace it
- script: 'dotnet StaticWebMultitenantConfig.dll'
  workingDirectory: '$(System.DefaultWorkingDirectory)/_deployments/tools/StaticWebMultitenantConfig'
  displayName: 'Set static web settings'

3- Deploy the built app using the Azure Static Web App (Preview) Task
- task: AzureStaticWebApp@0   displayName: 'Deploy static web app'   inputs:     app_location: '_deployments/web/Client/wwwroot'     config_file_location: '_deployments/web/Client/wwwroot'     skip_app_build: true     skip_api_build: true     is_static_export: false     verbose: true     azure_static_web_apps_api_token: '$(StaticWebApi)'
After step 2, if I echo the "_deployments/web/Client/wwwroot/appsettings.json" file, I get the right configuration but after the third step the appsettings.json is empty

@ZavenLepedjian Thanks for the tasks yaml. Not completely sure on what's going wrong here, but is it possible that the file generated in task 2 is not accessible by task 3?
To verify that, in task 3, can you try removing the static web app related steps and add a simple command to access the generated appsettings.json and see if you can see the contents?
And if the issue is happening only with static web app task, is it possible to provide a repro which I can access or provide me with access so that I can understand the issue better?

@vivekjilla Thanks for the help.
After trying to get the file content after task 2, I got permission denied.
/home/vsts/work/_temp/0b45eaf9-a2f1-4266-8e5b-55544d98e394.sh: line 3: /home/vsts/work/r1/a/_deployments/web/Client/wwwroot/appsettings.json: Permission denied
This result was predicted by you.

@ZavenLepedjian thanks for trying it out. Not sure what's happening here but seems like something to do with azure devops pipelines.
One thing we can do is to try a minimal repro where one task writes contents to a file and the next task reads it.
And maybe follow up with the azure devops team on this - https://github.com/MicrosoftDocs/azure-devops-docs/issues
Can you please try that and see.

@vivekjilla , After running chmod 777 -R . to give access on the file, I was able to read the content of the file.
But after the static web task, the appsettings is still not filled with the data I was waiting for.

@ZavenLepedjian Oh okay. Then, is it possible to give me access to your pipeline or provide an accessible repro, where I can look into further to get to the bottom of this? Thanks!

@vivekjilla it is very difficult for me to give you access to the pipeline as it is the company's release pipeline. maybe we can have a call and share screen so that you can look into it?
Also, even though I tried using incognito but, do you think this might be a problem of caching? Maybe the appsettings has been updated but it has been cached?

@ZavenLepedjian sure. Please send a mail to me at<EMAIL_ADDRESS>, We can discuss further there.
I can't think of a reason why this could be happening, at this point.

Thanks @vivekjilla , I will contact you soon via email

@vivekjilla I contacted you a week ago via email and didn't get any response.

@ZavenLepedjian I'm really sorry about that but  I didn't see any mail or can't seem to find. Can you please check again and also send me the subject I can search for.

@vivekjilla here's the subject of the email sent.
Azure static web app appsettings.json file modification
Hope to hear from you soon.

@vivekjilla do you have any updates?

Hi @vivekjilla Was my demo helpful? This is a blocking issue for me on a real project (and the demo)

@Eonasdan apologies for the delay. But can you try this work-around

Workaround is to have a file with different name in the repo and let the task create a new file with name appsettings.json.

Basically either don't keep the wwwroot/appsettings.json file in the repo or rename it to somethine else like wwwroot/_appsettings.json.
This way, your custom appsettings.json won't get replaced by the initial appsettings.json file during the deploy step.
And for us to investigate this further, is it also possible for you to share the deployment run logs. Thanks!

Based on your workaround, what I ended up doing was deleting the wwwroot/appsettings.json file before doing a publish in my build pipeline. In the deploy pipeline, I copy the environment specific file into the wwwroot folder. This seemed to work for the demo, I'll have to try it in the real project when I can get to it.
  - task: PowerShell@2
    displayName: 'Delete Config'
    inputs:
      pwsh: true
      targetType: 'inline'
      script: |
        $destination = "BlazorDemo/BlazorDemo.Web/wwwroot/appsettings.json"
        Remove-Item -Path $destination -Force


No way to get URL parameters from connRequest

Hi,
it looks like something is broken, there is no way to retrieve the url parameters (like the token) from the connRequest.
The server contrib example uses streamId for this but all chars after the next & are stripped.
Thanks

The streamid is a query parameter, i.e. the value of the streamid parameter has to be URL-encoded. If your streamid contains a & you have to encode it as %26.
All other query parameter are for configuring the SRT connection. Everything that is specific to your application has to be part of the streamid.

Hi, thanks for this fast answer!
Of course it is, I should ave thought about it... sorry
I know it's not related to gosrt implementation, but what would the best way to put auth in place with srt then ? It's not very convenient to put a "%26" in the url...
Thank again

In the streamid you're free to use any format for the information you want to transport. This means that you could use different separators that don't require URL encoding, e.g. streamid=token:qwertz,resource=foobar.

Understood thank you very much!


Add scroll to top effect on page navigation

Summary
React router preserves the current scroll value of the page when navigating. This leads to being dropped somewhere in the middle of pages when navigating to a new page. This can be resolved with a component with a useEffect to scroll to the top of the window on page navigation as outlined in this SO post
Acceptance Criteria
Pages load at the top of the page when navigating with react router.

Closed by #7


Added hide sidebar after link has been clicked

When on screen size of less than 768 pixels, the sidebar closes after a link is clicked. Also adjusted the left padding on the toggler when on a screen size of less than 768 pixels.

Issue: Close sidebar on clicking on link in small devices #95
Remove extra padding/margin for sidebar-toggler #84

My apologies, I am still getting the hang of the git workflow. I only meant to commit the last two of those seven commits

Ok great, thank you. Nice work.
But just so you know for next time, each issue should be resolved on a different pull request. Don't combine issues in the same pull request.
@all-contributors please add @caseycling for code and bug


Navigation: Table/Record page action to access activities page

👋 Heyo. Neat package!
I've followed the installation instructions and I've noticed there is no direct way to navigate to a given user/model's activities other than directly going to /{record}/activities. Am I missing something, or would it be good to have actions to access activities from the List and View pages?
I can have a crack at it over the weekend, but wanted to highlight it for now.

Not sure why you need an Action for that? It's basically
Action::make('activities')->url(YourResource::getUrl('activities'))

Yeah, that's basically what I was going to do. Probably didn't word my issue correctly - I'm saying that this should probably be included or have a quick instruction to add.

Not sure whether you have access to the resource from within an action? So it's probably not possible to build this upfront. I'll add it to the docs, to make it easier for people, even if it should be clear from Filament docs.


Importing a markdown file into my React application causes TestCafe to throw

What is your Scenario?
I am importing .md Markdown files into my React application. These are interpreted by the ReactMarkdown package for display. (Background: I'm doing this so non-technical staff can edit parts of the site content - i.e. a very basic CMS.)
What is the Current behavior?
In my most simplified test case simply importing the .md file (not using it, not importing or invoking ReactMarkdown) causes TestCafe to throw an "Unexpected token" error at the first character of the file (#)
What is the Expected behavior?
Importing a .md file should not, in itself, throw an error.

This happens on load, so the test code is no more than:
fixture('Test component').page('http://localhost:3000');
Your complete configuration file
module.exports = {
    screenshots: {
        takeOnFails: true,
        path: './testcafe/reports/screenshots/',
        pathPattern: '${DATE}_${TIME}_test-${TEST_INDEX}.png',
    },
    skipJsErrors: true,
};

Your complete test report
ERROR Cannot prepare tests due to the following error:
SyntaxError: C:\Repos\health-leyden\documentation-a
pp\src_markdown\data-viz\bar-chart.md: Unexpected token (1:0)

1 | ### Pattern summary
| ^
2 |
3 | Also called bar graph or column chart, the ba
r chart is useful for comparing categorical data wi
th a shared baseline. Bars can be orientated in eit
her a vertical or horizontal direction depending on space available or desired fidelity.
4 |
at Object. (C:\Repos\health-leyden\documentation-app\src_constants\nav-data.js:3:1)
at Object. (C:\Repos\health-leyden\testcafe\main.tc.js:1:1)

Screenshots
No response
Steps to Reproduce

import an .md file into your React project, e.g.: import barChartMarkdown from '../_markdown/data-viz/bar-chart.md';
load page in a TestCafe test

TestCafe version
^3.5.0
Node.js version
18.8.0
Command-line arguments
testcafe chrome ./testcafe/main.tc.js -r json:./testcafe/reports/chrome-report.json
Browser name(s) and version(s)
No response
Platform(s) and version(s)
Windows 11
Other
I've done my best with Google, looking for Testcafe/Markdown, or some way to tell Testcafe how to treat these files. I apologise if there's a known configuration for this (I've also read through the Testcafe config options in the docs, trying dev mode & disabling js errors)

Apologies - I have realized it's not loading the .md from my web application, bu from a data file from which I was getting the routes to test - from within testcafe itself. It probably still shouldn't error just by importing the file, but its easily worked around for me and anyone else experiencing it.


Incorrect semver

Bug report
Describe the bug
Many recent prereleases, including the latest (v7.0.2-canary.50) have incorrect semver. Look at the next releases on npm and immediately see that they are wrong. Versions are being published with semver that comes before already released versions.
To Reproduce
To understand the consequences, create a package.json with this:
{
  "dependencies": {
    "next": "^7.0.2-canary.50"
  }
}

Run npm install && npm ls next and you will see:
<EMAIL_ADDRESS>[redacted]
└──<EMAIL_ADDRESS>
v7.0.2 was installed, not 7.0.2-canary.50!
That is because although v7.0.2 was published 3 months before v7.0.2-canary.50, according to semver it comes after, as stable releases always follow prereleases. Pre-releases are anything with a - after the x.x.x.
To make matters in this instance even more confusing, v7.0.3-alpha.5 was published before a whole bunch of v7.0.2-canary.x releases.
Once a stable patch has been published, move on to a prerelease for the next patch!
Expected behavior
Releases should be correct semver.
Additional context
This keeps happening again and again, despite multiple previous discussions acknowledging the issue: https://github.com/zeit/next.js/issues/4955. @timneutkens it is very frustrating lessons of the past are forgotten.

I had "next": "^7.0.2-canary.xx" in my package.json and thought I was on the latest version for quite a while before realizing I wasn't getting some fixes I needed.  A very easy mistake to make!

To make matters in this instance even more confusing, v7.0.3-alpha.5 was published before a whole bunch of v7.0.2-canary.x releases.

This was a testing release and should be ignored in every sense.

The version scheme we had used release, we then switched to a monorepo using lerna to release prerelease versions. Then a security patch had to be released against old code / versioning scheme while the new scheme was being used. Hence why we haven't changed the versions yet. I'll release a new canary version today to solve this, this is a totally different issue than before btw, as that was bug/issue in release itself.


⚠ GitLab Server has degraded performance

In 446c2ad, GitLab Server (https://gitlab01.its-telekom.eu) experienced degraded performance:

HTTP code: 200
Response time: 12283 ms

Resolved: GitLab Server performance has improved in d6a4d8c.


Can I make this work for an archive ZIP from 2016?

I've got an archive ZIP from 2016. I've just got to step 1, "Copy ./data/tweets.js from your Twitter Archive zip file into the ./database directory of this project."
There is no tweets.js in ./data/ - I'm wondering if it's because Twitter's way of archiving has changed.
Do you know if there's a way to make it work? I'm happy to send someone my Twitter archive ZIP privately but I feel uncomfortable about posting it publicly!
Thank you in advance. :)

I don't know about 2016, but can confirm I just ran successfully on an archive from 10/2020.


GW2radial keybind -- where???

I reinstalled GW2Radial through GW2 add -on manager.
I can call the menu and bind keys for mounts, but I don't see where to bind the key for calling GW2 radial itself.

NVM, It's 'show on...'


linux-iot2050: enable CGROUP_BPF config to support docker

Also enable the CONFIG_BRIDGE_NETFILTER.
Signed-off-by: Su Baocheng<EMAIL_ADDRESS>

This should close #238

Looks good. Which docker packages did you test?

Looks good. Which docker packages did you test? Maybe mention this in the commit log.

The debian official docker.io and docker-compose packages are tested
with below method:
For docker.io package:
docker run -it debian:bullseye-slim /bin/bash
/# apt update
/# apt install wget
/# wget xxxx.com

For docker-compose package:
docker-compose up with
version: '2'
services:
  hello_world:
    image: debian:bullseye-slim
    command: [/bin/echo, 'Hello world']


Fix/make dark mode more robust

Dark mode switch now works even when Fingerprint validation fails (only remembering the choice is now dependent on Fingerprint functionality, not switching itself)
Switch happens instantly/optimistically instead of waiting for the network request
Use localStorage to store the preference locally too, to prevent a long flash of white mode when reloading the page (long flash still happens in incognito mode, obviously)
Cancel getUserPreferences request if the user switches dark mode before the request finishes (prevent the DB request from overriding the user choice if their connection is slow)
Improve TS coverage in related files
Add typescript eslint plugin

https://fingerprintjs.atlassian.net/browse/INTER-29

@TheUnderScorer still need your approval :)


Failed to build caffe2 on Centos

Hi, I am building caffe2 from source, per instructions here https://caffe2.ai/docs/getting-started.html?platform=centos&configuration=cloud, and it has problem compiling gloo related stuff. Here is the output:
liangluo@n37:~/caffe2/build$ make
[ 14%] Built target nccl_external
[ 14%] Built target pthreadpool
[ 14%] Built target nnpack_reference_layers
[ 14%] Built target nnpack
[ 14%] Built target gmock_main
[ 14%] Built target gmock
[ 14%] Built target gtest
[ 14%] Built target gtest_main
[ 14%] Built target benchmark
[ 14%] Built target gloo
[ 14%] Building NVCC (Device) object third_party/gloo/gloo/CMakeFiles/gloo_cuda.dir/nccl/gloo_cuda_generated_nccl.cu.o
nvcc fatal   : A single input file is required for a non-link phase when an outputfile is specified
CMake Error at gloo_cuda_generated_nccl.cu.o.Release.cmake:203 (message):
Error generating
/xxxxx/home/liangluo/caffe2/build/third_party/gloo/gloo/CMakeFiles/gloo_cuda.dir/nccl/./gloo_cuda_generated_nccl.cu.o
make[2]: *** [third_party/gloo/gloo/CMakeFiles/gloo_cuda.dir/nccl/gloo_cuda_generated_nccl.cu.o] Error 1
make[1]: *** [third_party/gloo/gloo/CMakeFiles/gloo_cuda.dir/all] Error 2
make: *** [all] Error 2
I'm using CUDA 8.
Any suggestion? Any more information required?
Thanks!

have the same problem on centOS. It looks like they broke smthing recently

Now I pull the code and I am getting
when doing cmake3 .. in the build folder.
CMake Error: INSTALL(EXPORT) given unknown export "GlooTargets"

I add set(CMAKE_VERBOSE_MAKEFILE on) in CMakeList.txt for more debug info:
/usr/local/cuda/bin/nvcc -M -D__CUDACC__ /opt/caffe2/third_party/gloo/gloo/nccl/nccl.cu -o /opt/caffe2/build/third_party/gloo/gloo/CMakeFiles/gloo_cuda.dir/nccl/gloo_cuda_generated_nccl.cu.o.NVCC-depend -ccbin /usr/bin/cc -m64 -gencode arch=compute_30,code=sm_30 -gencode arch=compute_35,code=sm_35 -gencode arch=compute_50,code=sm_50 -gencode arch=compute_52,code=sm_52 -gencode arch=compute_60,code=sm_60 -gencode arch=compute_61,code=sm_61 -gencode arch=compute_70,code=sm_70 -Xcudafe --diag_suppress=cc_clobber_ignored -Xcudafe --diag_suppress=integer_sign_change -Xcudafe --diag_suppress=useless_using_declaration -Xcudafe --diag_suppress=set_but_not_used -std=c++11 -Xcompiler -fPIC --expt-relaxed-constexpr -Wno-deprecated-gpu-targets -DNVCC -I/usr/local/cuda/include -I/opt/caffe2/build/third_party/gloo -I/opt/caffe2/third_party/cub -I/opt/caffe2/third_party/nccl/build/include -I/usr/local/cuda/include -I/opt/caffe2/third_party/pybind11/include -I/opt/caffe2/third_party/eigen -I/usr/include -I/opt/caffe2/third_party/benchmark/include -I/opt/caffe2/third_party/googletest/googletest/include -I/opt/caffe2/third_party/protobuf/src /opt/caffe2/build/confu-srcs/pthreadpool/include /opt/caffe2/build/confu-srcs/fxdiv/include -I/opt/caffe2/third_party/protobuf/src /opt/caffe2/third_party/NNPACK/include /opt/caffe2/third_party/NNPACK/src /opt/caffe2/build/confu-srcs/pthreadpool/include /opt/caffe2/build/confu-srcs/fxdiv/include /opt/caffe2/build/confu-srcs/psimd/include /opt/caffe2/build/confu-srcs/fp16/include -I/opt/caffe2/third_party/protobuf/src -I/opt/anaconda3/include/python3.6m -I/opt/anaconda3/lib/python3.6/site-packages/numpy/core/include -I/opt/caffe2/third_party/gloo

In this nvcc command, many include dirs dont have the -I option prefix. This command works when I add -I before include dirs.
So it seems to be a cmake bug.

Update cmake (3.10) to the latest version will work.

I'm using cmake3, the version is 3.6.1, the same error occured

@huangynn  ,pls follow @yytdfc  idea , switch ti cmake_3.10  .  well ,cmake<3.10 always occur error

@gjpicker  you got it right, all run smoothly when cmake 3.1 is used (OSX)
cmake3 == cmake3.6
cmake = cmake 3.1 when use brew to install cmake

I met same issue , how to use "cmake (3.10)" in CentOS to build Caffe2?
I already updated 3.10 , but don't know what to use 3.10 for instead.

cmake --version , if the version is 3.1, just apply the tutorial install steps

Thank you, @huangynn !
I tried "cd build && cmake .." and then did "make install" , but there're another error when building,  could you please advise?
The error seems related to nccl , i didn't know how  to make it right . i tried to install nccl from "/root/caffe2/third_party/nccl" , but it didn't work out.
[ 90%] Linking CXX executable ../bin/init_test
[ 91%] Linking CXX executable ../bin/logging_test
[ 91%] Linking CXX executable ../bin/common_test
../lib/libcaffe2_gpu.so: undefined reference to ncclGroupStart' ../lib/libcaffe2_gpu.so: undefined reference to ncclGroupEnd'
collect2: error: ld returned 1 exit status
make[2]: *** [bin/cpuid_test] Error 1
make[1]: *** [caffe2/CMakeFiles/cpuid_test.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
../lib/libcaffe2_gpu.so: undefined reference to ncclGroupStart' ../lib/libcaffe2_gpu.so: undefined reference to ncclGroupEnd'
collect2: error: ld returned 1 exit status
make[2]: *** [bin/timer_test] Error 1
make[1]: *** [caffe2/CMakeFiles/timer_test.dir/all] Error 2
../lib/libcaffe2_gpu.so: undefined reference to ncclGroupStart' ../lib/libcaffe2_gpu.so: undefined reference to ncclGroupEnd'
collect2: error: ld returned 1 exit status
make[2]: *** [bin/fixed_divisor_test] Error 1
make[1]: *** [caffe2/CMakeFiles/fixed_divisor_test.dir/all] Error 2
[ 91%] Linking CXX executable ../bin/proto_utils_test
../../lib/libcaffe2_gpu.so: undefined reference to ncclGroupStart' ../../lib/libcaffe2_gpu.so: undefined reference to ncclGroupEnd'
collect2: error: ld returned 1 exit status
../../lib/libcaffe2_gpu.so: undefined reference to ncclGroupStart' ../../lib/libcaffe2_gpu.so: undefined reference to ncclGroupEnd'
collect2: error: ld returned 1 exit status
../../lib/libcaffe2_gpu.so: undefined reference to ncclGroupStart' ../../lib/libcaffe2_gpu.so: undefined reference to ncclGroupEnd'
collect2: error: ld returned 1 exit status
make[2]: *** [bin/tutorial_blob] Error 1
make[1]: *** [caffe2/binaries/CMakeFiles/tutorial_blob.dir/all] Error 2
make[2]: *** [bin/convert_db] Error 1
make[2]: *** [bin/predictor_verifier] Error 1
make[1]: *** [caffe2/binaries/CMakeFiles/convert_db.dir/all] Error 2
make[1]: *** [caffe2/binaries/CMakeFiles/predictor_verifier.dir/all] Error 2
../lib/libcaffe2_gpu.so: undefined reference to ncclGroupStart' ../lib/libcaffe2_gpu.so: undefined reference to ncclGroupEnd'
collect2: error: ld returned 1 exit status
make[2]: *** [bin/fatal_signal_asan_no_sig_test] Error 1
make[1]: *** [caffe2/CMakeFiles/fatal_signal_asan_no_sig_test.dir/all] Error 2
../../lib/libcaffe2_gpu.so: undefined reference to ncclGroupStart' ../../lib/libcaffe2_gpu.so: undefined reference to ncclGroupEnd'
collect2: error: ld returned 1 exit status
make[2]: *** [bin/convert_caffe_image_db] Error 1
make[1]: *** [caffe2/binaries/CMakeFiles/convert_caffe_image_db.dir/all] Error 2
../../lib/libcaffe2_gpu.so: undefined reference to ncclGroupStart' ../../lib/libcaffe2_gpu.so: undefined reference to ncclGroupEnd'
collect2: error: ld returned 1 exit status
make[2]: *** [bin/run_plan] Error 1
make[1]: *** [caffe2/binaries/CMakeFiles/run_plan.dir/all] Error 2
../../lib/libcaffe2_gpu.so: undefined reference to ncclGroupStart' ../../lib/libcaffe2_gpu.so: undefined reference to ncclGroupEnd'
collect2: error: ld returned 1 exit status
make[2]: *** [bin/inspect_gpus] Error 1
make[1]: *** [caffe2/binaries/CMakeFiles/inspect_gpus.dir/all] Error 2
[ 91%] Linking CXX executable ../bin/event_test
../lib/libcaffe2_gpu.so: undefined reference to ncclGroupStart' ../lib/libcaffe2_gpu.so: undefined reference to ncclGroupEnd'
collect2: error: ld returned 1 exit status
make[2]: *** [bin/init_test] Error 1
make[1]: *** [caffe2/CMakeFiles/init_test.dir/all] Error 2
../lib/libcaffe2_gpu.so: undefined reference to ncclGroupStart' ../lib/libcaffe2_gpu.so: undefined reference to ncclGroupEnd'
collect2: error: ld returned 1 exit status
make[2]: *** [bin/common_test] Error 1
make[1]: *** [caffe2/CMakeFiles/common_test.dir/all] Error 2
../lib/libcaffe2_gpu.so: undefined reference to ncclGroupStart' ../lib/libcaffe2_gpu.so: undefined reference to ncclGroupEnd'
collect2: error: ld returned 1 exit status
make[2]: *** [bin/logging_test] Error 1
make[1]: *** [caffe2/CMakeFiles/logging_test.dir/all] Error 2
[ 92%] Linking CXX executable ../bin/registry_test
CMakeFiles/proto_utils_test.dir/utils/proto_utils_test.cc.o: In function caffe2::ProtoUtilsTest_SimpleReadWrite_Test::TestBody()': proto_utils_test.cc:(.text+0x31): warning: the use of tmpnam' is dangerous, better use mkstemp' ../lib/libcaffe2_gpu.so: undefined reference to ncclGroupStart'
../lib/libcaffe2_gpu.so: undefined reference to ncclGroupEnd' collect2: error: ld returned 1 exit status make[2]: *** [bin/proto_utils_test] Error 1 make[1]: *** [caffe2/CMakeFiles/proto_utils_test.dir/all] Error 2 [ 92%] Linking CXX executable ../bin/simple_queue_test [ 92%] Linking CXX executable ../bin/context_test ../lib/libcaffe2_gpu.so: undefined reference to ncclGroupStart'
../lib/libcaffe2_gpu.so: undefined reference to ncclGroupEnd' collect2: error: ld returned 1 exit status make[2]: *** [bin/event_test] Error 1 make[1]: *** [caffe2/CMakeFiles/event_test.dir/all] Error 2 [ 92%] Linking CXX executable ../bin/conv_op_cache_cudnn_test [ 92%] Linking CXX executable ../../bin/db_throughput [ 92%] Linking CXX executable ../../bin/print_core_object_sizes [ 92%] Linking CXX executable ../bin/smart_tensor_printer_test [ 93%] Linking CXX executable ../../bin/print_registered_core_operators [ 93%] Linking CXX executable ../../bin/split_db [ 93%] Linking CXX executable ../../bin/make_mnist_db ../lib/libcaffe2_gpu.so: undefined reference to ncclGroupStart'
../lib/libcaffe2_gpu.so: undefined reference to ncclGroupEnd' collect2: error: ld returned 1 exit status make[2]: *** [bin/registry_test] Error 1 make[1]: *** [caffe2/CMakeFiles/registry_test.dir/all] Error 2 [ 93%] Linking CXX executable ../../bin/make_cifar_db [ 93%] Linking CXX executable ../bin/event_gpu_test ../lib/libcaffe2_gpu.so: undefined reference to ncclGroupStart'
../lib/libcaffe2_gpu.so: undefined reference to ncclGroupEnd' collect2: error: ld returned 1 exit status make[2]: *** [bin/simple_queue_test] Error 1 make[1]: *** [caffe2/CMakeFiles/simple_queue_test.dir/all] Error 2 ../lib/libcaffe2_gpu.so: undefined reference to ncclGroupStart'
../lib/libcaffe2_gpu.so: undefined reference to ncclGroupEnd' collect2: error: ld returned 1 exit status make[2]: *** [bin/conv_op_cache_cudnn_test] Error 1 ../../lib/libcaffe2_gpu.so: undefined reference to ncclGroupStart'
../../lib/libcaffe2_gpu.so: undefined reference to ncclGroupEnd' collect2: error: ld returned 1 exit status make[1]: *** [caffe2/CMakeFiles/conv_op_cache_cudnn_test.dir/all] Error 2 make[2]: *** [bin/print_core_object_sizes] Error 1 make[1]: *** [caffe2/binaries/CMakeFiles/print_core_object_sizes.dir/all] Error 2 ../../lib/libcaffe2_gpu.so: undefined reference to ncclGroupStart'
../../lib/libcaffe2_gpu.so: undefined reference to ncclGroupEnd' collect2: error: ld returned 1 exit status make[2]: *** [bin/db_throughput] Error 1 make[1]: *** [caffe2/binaries/CMakeFiles/db_throughput.dir/all] Error 2 ../../lib/libcaffe2_gpu.so: undefined reference to ncclGroupStart'
../../lib/libcaffe2_gpu.so: undefined reference to ncclGroupEnd' collect2: error: ld returned 1 exit status make[2]: *** [bin/split_db] Error 1 make[1]: *** [caffe2/binaries/CMakeFiles/split_db.dir/all] Error 2 ../../lib/libcaffe2_gpu.so: undefined reference to ncclGroupStart'
../../lib/libcaffe2_gpu.so: undefined reference to ncclGroupEnd' collect2: error: ld returned 1 exit status make[2]: *** [bin/make_mnist_db] Error 1 make[1]: *** [caffe2/binaries/CMakeFiles/make_mnist_db.dir/all] Error 2 ../lib/libcaffe2_gpu.so: undefined reference to ncclGroupStart'
../lib/libcaffe2_gpu.so: undefined reference to ncclGroupEnd' collect2: error: ld returned 1 exit status make[2]: *** [bin/context_test] Error 1 make[1]: *** [caffe2/CMakeFiles/context_test.dir/all] Error 2 ../../lib/libcaffe2_gpu.so: undefined reference to ncclGroupStart'
../../lib/libcaffe2_gpu.so: undefined reference to ncclGroupEnd' collect2: error: ld returned 1 exit status make[2]: *** [bin/print_registered_core_operators] Error 1 make[1]: *** [caffe2/binaries/CMakeFiles/print_registered_core_operators.dir/all] Error 2 ../lib/libcaffe2_gpu.so: undefined reference to ncclGroupStart'
../lib/libcaffe2_gpu.so: undefined reference to ncclGroupEnd' collect2: error: ld returned 1 exit status make[2]: *** [bin/smart_tensor_printer_test] Error 1 ../../lib/libcaffe2_gpu.so: undefined reference to ncclGroupStart'
../../lib/libcaffe2_gpu.so: undefined reference to ncclGroupEnd' collect2: error: ld returned 1 exit status make[1]: *** [caffe2/CMakeFiles/smart_tensor_printer_test.dir/all] Error 2 make[2]: *** [bin/make_cifar_db] Error 1 make[1]: *** [caffe2/binaries/CMakeFiles/make_cifar_db.dir/all] Error 2 [ 93%] Linking CXX executable ../bin/stats_test ../lib/libcaffe2_gpu.so: undefined reference to ncclGroupStart'
../lib/libcaffe2_gpu.so: undefined reference to ncclGroupEnd' collect2: error: ld returned 1 exit status make[2]: *** [bin/event_gpu_test] Error 1 make[1]: *** [caffe2/CMakeFiles/event_gpu_test.dir/all] Error 2 [ 93%] Linking CXX executable ../../bin/speed_benchmark ../lib/libcaffe2_gpu.so: undefined reference to ncclGroupStart'
../lib/libcaffe2_gpu.so: undefined reference to ncclGroupEnd' collect2: error: ld returned 1 exit status [ 94%] Linking CXX executable ../bin/typeid_test make[2]: *** [bin/stats_test] Error 1 make[1]: *** [caffe2/CMakeFiles/stats_test.dir/all] Error 2 [ 95%] Linking CXX executable ../bin/conv_to_nnpack_transform_test [ 95%] Linking CXX executable ../bin/common_subexpression_elimination_test [ 95%] Linking CXX executable ../bin/operator_gpu_test [ 95%] Linking CXX executable ../bin/boolean_unmask_ops_test [ 95%] Linking CXX executable ../bin/module_test ../../lib/libcaffe2_gpu.so: undefined reference to ncclGroupStart'
../../lib/libcaffe2_gpu.so: undefined reference to ncclGroupEnd' collect2: error: ld returned 1 exit status make[2]: *** [bin/speed_benchmark] Error 1 make[1]: *** [caffe2/binaries/CMakeFiles/speed_benchmark.dir/all] Error 2 [ 95%] Linking CXX executable ../bin/text_file_reader_utils_test [ 96%] Linking CXX executable ../bin/context_gpu_test ../lib/libcaffe2_gpu.so: undefined reference to ncclGroupStart'
../lib/libcaffe2_gpu.so: undefined reference to ncclGroupEnd' collect2: error: ld returned 1 exit status make[2]: *** [bin/typeid_test] Error 1 make[1]: *** [caffe2/CMakeFiles/typeid_test.dir/all] Error 2 ../lib/libcaffe2_gpu.so: undefined reference to ncclGroupStart'
../lib/libcaffe2_gpu.so: undefined reference to ncclGroupEnd' collect2: error: ld returned 1 exit status make[2]: *** [bin/conv_to_nnpack_transform_test] Error 1 make[1]: *** [caffe2/CMakeFiles/conv_to_nnpack_transform_test.dir/all] Error 2 ../lib/libcaffe2_gpu.so: undefined reference to ncclGroupStart'
../lib/libcaffe2_gpu.so: undefined reference to ncclGroupEnd' collect2: error: ld returned 1 exit status make[2]: *** [bin/common_subexpression_elimination_test] Error 1 make[1]: *** [caffe2/CMakeFiles/common_subexpression_elimination_test.dir/all] Error 2 ../lib/libcaffe2_gpu.so: undefined reference to ncclGroupStart'
../lib/libcaffe2_gpu.so: undefined reference to ncclGroupEnd' collect2: error: ld returned 1 exit status make[2]: *** [bin/operator_gpu_test] Error 1 make[1]: *** [caffe2/CMakeFiles/operator_gpu_test.dir/all] Error 2 ../lib/libcaffe2_gpu.so: undefined reference to ncclGroupStart'
../lib/libcaffe2_gpu.so: undefined reference to ncclGroupEnd' collect2: error: ld returned 1 exit status make[2]: *** [bin/boolean_unmask_ops_test] Error 1 make[1]: *** [caffe2/CMakeFiles/boolean_unmask_ops_test.dir/all] Error 2 [ 97%] Linking CXX executable ../bin/workspace_test ../lib/libcaffe2_gpu.so: undefined reference to ncclGroupStart'
../lib/libcaffe2_gpu.so: undefined reference to ncclGroupEnd' collect2: error: ld returned 1 exit status make[2]: *** [bin/module_test] Error 1 make[1]: *** [caffe2/CMakeFiles/module_test.dir/all] Error 2 [ 97%] Linking CXX executable ../bin/parallel_net_test CMakeFiles/text_file_reader_utils_test.dir/operators/text_file_reader_utils_test.cc.o: In function caffe2::TextFileReaderUtilsTest_TokenizeTest_Test::TestBody()':
text_file_reader_utils_test.cc:(.text+0x1e03): warning: the use of tmpnam' is dangerous, better use mkstemp'
../lib/libcaffe2_gpu.so: undefined reference to ncclGroupStart' ../lib/libcaffe2_gpu.so: undefined reference to ncclGroupEnd'
collect2: error: ld returned 1 exit status
make[2]: *** [bin/text_file_reader_utils_test] Error 1
make[1]: *** [caffe2/CMakeFiles/text_file_reader_utils_test.dir/all] Error 2
[ 97%] Linking CXX executable ../../bin/core_overhead_benchmark
../lib/libcaffe2_gpu.so: undefined reference to ncclGroupStart' ../lib/libcaffe2_gpu.so: undefined reference to ncclGroupEnd'
collect2: error: ld returned 1 exit status
make[2]: *** [bin/context_gpu_test] Error 1
make[1]: *** [caffe2/CMakeFiles/context_gpu_test.dir/all] Error 2
../lib/libcaffe2_gpu.so: undefined reference to ncclGroupStart' ../lib/libcaffe2_gpu.so: undefined reference to ncclGroupEnd'
collect2: error: ld returned 1 exit status
make[2]: *** [bin/workspace_test] Error 1
make[1]: *** [caffe2/CMakeFiles/workspace_test.dir/all] Error 2
../lib/libcaffe2_gpu.so: undefined reference to ncclGroupStart' ../lib/libcaffe2_gpu.so: undefined reference to ncclGroupEnd'
collect2: error: ld returned 1 exit status
make[2]: *** [bin/parallel_net_test] Error 1
make[1]: *** [caffe2/CMakeFiles/parallel_net_test.dir/all] Error 2
[ 97%] Linking CXX executable ../bin/graph_test
[ 97%] Linking CXX executable ../bin/observer_test
../../lib/libcaffe2_gpu.so: undefined reference to ncclGroupStart' ../../lib/libcaffe2_gpu.so: undefined reference to ncclGroupEnd'
collect2: error: ld returned 1 exit status
make[2]: *** [bin/core_overhead_benchmark] Error 1
make[1]: *** [caffe2/binaries/CMakeFiles/core_overhead_benchmark.dir/all] Error 2
[ 97%] Linking CXX executable ../bin/operator_schema_test
[ 97%] Linking CXX executable ../bin/net_test
[ 97%] Linking CXX executable ../bin/math_test
../lib/libcaffe2_gpu.so: undefined reference to ncclGroupStart' ../lib/libcaffe2_gpu.so: undefined reference to ncclGroupEnd'
collect2: error: ld returned 1 exit status
make[2]: *** [bin/graph_test] Error 1
make[1]: *** [caffe2/CMakeFiles/graph_test.dir/all] Error 2
../lib/libcaffe2_gpu.so: undefined reference to ncclGroupStart' ../lib/libcaffe2_gpu.so: undefined reference to ncclGroupEnd'
collect2: error: ld returned 1 exit status
make[2]: *** [bin/observer_test] Error 1
make[1]: *** [caffe2/CMakeFiles/observer_test.dir/all] Error 2
../lib/libcaffe2_gpu.so: undefined reference to ncclGroupStart' ../lib/libcaffe2_gpu.so: undefined reference to ncclGroupEnd'
collect2: error: ld returned 1 exit status
make[2]: *** [bin/net_test] Error 1
make[1]: *** [caffe2/CMakeFiles/net_test.dir/all] Error 2
../lib/libcaffe2_gpu.so: undefined reference to ncclGroupStart' ../lib/libcaffe2_gpu.so: undefined reference to ncclGroupEnd'
collect2: error: ld returned 1 exit status
make[2]: *** [bin/operator_schema_test] Error 1
make[1]: *** [caffe2/CMakeFiles/operator_schema_test.dir/all] Error 2
[ 97%] Linking CXX executable ../bin/fully_connected_op_test
../lib/libcaffe2_gpu.so: undefined reference to ncclGroupStart' ../lib/libcaffe2_gpu.so: undefined reference to ncclGroupEnd'
collect2: error: ld returned 1 exit status
make[2]: *** [bin/math_test] Error 1
make[1]: *** [caffe2/CMakeFiles/math_test.dir/all] Error 2
[ 97%] Linking CXX executable ../bin/utility_ops_test
[ 97%] Linking CXX executable ../bin/reshape_op_gpu_test
[ 97%] Linking CXX executable ../bin/operator_fallback_gpu_test
[ 98%] Linking CXX executable ../bin/predictor_test
[ 98%] Linking CXX executable ../bin/conv_transpose_op_mobile_test
../lib/libcaffe2_gpu.so: undefined reference to ncclGroupStart' ../lib/libcaffe2_gpu.so: undefined reference to ncclGroupEnd'
collect2: error: ld returned 1 exit status
make[2]: *** [bin/fully_connected_op_test] Error 1
make[1]: *** [caffe2/CMakeFiles/fully_connected_op_test.dir/all] Error 2
[ 98%] Linking CXX executable ../bin/string_ops_test
../lib/libcaffe2_gpu.so: undefined reference to ncclGroupStart' ../lib/libcaffe2_gpu.so: undefined reference to ncclGroupEnd'
collect2: error: ld returned 1 exit status
make[2]: *** [bin/utility_ops_test] Error 1
make[1]: *** [caffe2/CMakeFiles/utility_ops_test.dir/all] Error 2
[ 98%] Linking CXX executable ../bin/transform_test
../lib/libcaffe2_gpu.so: undefined reference to ncclGroupStart' ../lib/libcaffe2_gpu.so: undefined reference to ncclGroupEnd'
collect2: error: ld returned 1 exit status
make[2]: *** [bin/reshape_op_gpu_test] Error 1
make[1]: *** [caffe2/CMakeFiles/reshape_op_gpu_test.dir/all] Error 2
[ 99%] Linking CXX executable ../bin/fully_connected_op_gpu_test
[ 99%] Linking CXX executable ../bin/utility_ops_gpu_test
../lib/libcaffe2_gpu.so: undefined reference to ncclGroupStart' ../lib/libcaffe2_gpu.so: undefined reference to ncclGroupEnd'
collect2: error: ld returned 1 exit status
make[2]: *** [bin/operator_fallback_gpu_test] Error 1
make[1]: *** [caffe2/CMakeFiles/operator_fallback_gpu_test.dir/all] Error 2
[ 99%] Linking CXX executable ../bin/elementwise_op_test
../lib/libcaffe2_gpu.so: undefined reference to ncclGroupStart' ../lib/libcaffe2_gpu.so: undefined reference to ncclGroupEnd'
collect2: error: ld returned 1 exit status
make[2]: *** [bin/predictor_test] Error 1
make[1]: *** [caffe2/CMakeFiles/predictor_test.dir/all] Error 2
../lib/libcaffe2_gpu.so: undefined reference to ncclGroupStart' ../lib/libcaffe2_gpu.so: undefined reference to ncclGroupEnd'
collect2: error: ld returned 1 exit status
make[2]: *** [bin/conv_transpose_op_mobile_test] Error 1
make[1]: *** [caffe2/CMakeFiles/conv_transpose_op_mobile_test.dir/all] Error 2
[ 99%] Linking CXX executable ../bin/elementwise_op_gpu_test
../lib/libcaffe2_gpu.so: undefined reference to ncclGroupStart' ../lib/libcaffe2_gpu.so: undefined reference to ncclGroupEnd'
collect2: error: ld returned 1 exit status
make[2]: *** [bin/string_ops_test] Error 1
make[1]: *** [caffe2/CMakeFiles/string_ops_test.dir/all] Error 2
../lib/libcaffe2_gpu.so: undefined reference to ncclGroupStart' ../lib/libcaffe2_gpu.so: undefined reference to ncclGroupEnd'
collect2: error: ld returned 1 exit status
make[2]: *** [bin/fully_connected_op_gpu_test] Error 1
make[1]: *** [caffe2/CMakeFiles/fully_connected_op_gpu_test.dir/all] Error 2
../lib/libcaffe2_gpu.so: undefined reference to ncclGroupStart' ../lib/libcaffe2_gpu.so: undefined reference to ncclGroupEnd'
collect2: error: ld returned 1 exit status
make[2]: *** [bin/transform_test] Error 1
make[1]: *** [caffe2/CMakeFiles/transform_test.dir/all] Error 2
../lib/libcaffe2_gpu.so: undefined reference to ncclGroupStart' ../lib/libcaffe2_gpu.so: undefined reference to ncclGroupEnd'
collect2: error: ld returned 1 exit status
make[2]: *** [bin/utility_ops_gpu_test] Error 1
make[1]: *** [caffe2/CMakeFiles/utility_ops_gpu_test.dir/all] Error 2
[ 99%] Linking CXX executable ../bin/math_gpu_test
../lib/libcaffe2_gpu.so: undefined reference to ncclGroupStart' ../lib/libcaffe2_gpu.so: undefined reference to ncclGroupEnd'
collect2: error: ld returned 1 exit status
make[2]: *** [bin/elementwise_op_test] Error 1
make[1]: *** [caffe2/CMakeFiles/elementwise_op_test.dir/all] Error 2
../lib/libcaffe2_gpu.so: undefined reference to ncclGroupStart' ../lib/libcaffe2_gpu.so: undefined reference to ncclGroupEnd'
collect2: error: ld returned 1 exit status
make[2]: *** [bin/elementwise_op_gpu_test] Error 1
make[1]: *** [caffe2/CMakeFiles/elementwise_op_gpu_test.dir/all] Error 2
[ 99%] Linking CXX executable ../bin/pattern_net_transform_test
../lib/libcaffe2_gpu.so: undefined reference to ncclGroupStart' ../lib/libcaffe2_gpu.so: undefined reference to ncclGroupEnd'
collect2: error: ld returned 1 exit status
make[2]: *** [bin/math_gpu_test] Error 1
make[1]: *** [caffe2/CMakeFiles/math_gpu_test.dir/all] Error 2
../lib/libcaffe2_gpu.so: undefined reference to ncclGroupStart' ../lib/libcaffe2_gpu.so: undefined reference to ncclGroupEnd'
collect2: error: ld returned 1 exit status
make[2]: *** [bin/pattern_net_transform_test] Error 1
make[1]: *** [caffe2/CMakeFiles/pattern_net_transform_test.dir/all] Error 2
[ 99%] Linking CXX executable ../bin/operator_test
[ 99%] Linking CXX executable ../bin/blob_gpu_test
../lib/libcaffe2_gpu.so: undefined reference to ncclGroupStart' ../lib/libcaffe2_gpu.so: undefined reference to ncclGroupEnd'
collect2: error: ld returned 1 exit status
make[2]: *** [bin/operator_test] Error 1
make[1]: *** [caffe2/CMakeFiles/operator_test.dir/all] Error 2
../lib/libcaffe2_gpu.so: undefined reference to ncclGroupStart' ../lib/libcaffe2_gpu.so: undefined reference to ncclGroupEnd'
collect2: error: ld returned 1 exit status
make[2]: *** [bin/blob_gpu_test] Error 1
make[1]: *** [caffe2/CMakeFiles/blob_gpu_test.dir/all] Error 2
[100%] Linking CXX executable ../bin/blob_test
CMakeFiles/blob_test.dir/core/blob_test.cc.o: In function caffe2::(anonymous namespace)::TypedTensorTest_BigTensorSerialization_Test<float>::TestBody()': blob_test.cc:(.text+0x441b1): warning: the use of tmpnam' is dangerous, better use mkstemp' ../lib/libcaffe2_gpu.so: undefined reference to ncclGroupStart'
../lib/libcaffe2_gpu.so: undefined reference to `ncclGroupEnd'
collect2: error: ld returned 1 exit status
make[2]: *** [bin/blob_test] Error 1
make[1]: *** [caffe2/CMakeFiles/blob_test.dir/all] Error 2
[100%] Linking CXX shared module python/caffe2_pybind11_state_gpu.so
[100%] Built target caffe2_pybind11_state_gpu
[100%] Linking CXX shared module python/caffe2_pybind11_state.so
[100%] Built target caffe2_pybind11_state
make: *** [all] Error 2

@beanliao Your issue is unrelated to this one (as discussed in #1601)

@yytdfc Thanks for your investigation. I can't repro the issue and we're trying to figure it out in facebookincubator/gloo#100. I'll take a look at the CMake diffs between 3.6 and 3.10 for the CUDA support.

I found a repro. I needed to explicitly enable NNPACK support. I found this by looking more closely at the nvcc command when the error happens, which indicates something is going on with the NNPACK includes that is incompatible with nvcc.
Now looking for a fix (other than upgrading CMake).

NNPACK uses a CMake generator expression for its include dirs ($<TARGET_PROPERTY:nnpack,INCLUDE_DIRECTORIES>) and this apparently doesn't expand into the real list (which contains > 1 directory) when the -I arguments are expanded. After the argument list is built, it is expanded after all, and we end up with paths without -I in the argument list to nvcc.

This was addressed in Kitware/CMake@7ded655f7ba82ea72a82d0555449f2df5ef38594 was first included in CMake 3.7.

Any solutions to this problem. I trying install pytorch and getting the same error
Issue Description
Building pytorch from source fails on power architecture machine.
Error reproducibility
Followed this tutorial to build and install pytorch from source on power architecture system.
IBM POWER8 CPU, NVIDIA Tesla P100 GPU
Error messages
make: *** [all] Error 2
Failed to run 'bash tools/build_pytorch_libs.sh --use-cuda --use-nnpack nccl caffe2 nanopb libshm gloo THD c10d'
System Config
PyTorch or Caffe2: pytorch
How you installed PyTorch (conda, pip, source): source
Build command you used (if compiling from source): python setup.py install
OS: Linux version 3.10.0-693.21.1.el7.ppc64le<EMAIL_ADDRESS>(gcc version 4.8.5 20150623 (Red Hat 4.8.5-16) (GCC) )
PyTorch version: v0.4.1
Python version: 3.6.5
CUDA/cuDNN version: 9.0/ 7.1.4
Edit: Found cuDNN: v7.1.4 (include: /cuda/9.0.69/include, library: /cuda/9.0.69/lib64/libcudnn.so.7)
GPU models and configuration: NVIDIA P100
GCC version (if compiling from source): 4.8.5
CMake version: 3.12.0
Versions of any other relevant libraries: spectrum_mpi instead of libopenmpi-dev-cuda
EDIT: No sudo access so can't install gfortran.


Stop depending on jQuery

Hi,
As the title says, I suggest to stop depending on jQuery in the webscheme library.
In 2020, many of jQuery's features can be replaced with vanilla JavaScript APIs, so I think jQuery is no longer necessary for us.

Pros

File size can be reduced
Users can use the native DOM seamlessly

Cons

Implementation becomes a little complicated
Break backwards compatibility

What do you think about that?

Good point. I want to keep backward compatibility as much as possible, so it is not possible to remove jQuery right now.
jQuery is only used in library/webscheme_lib.js, but problem is the getelem and $ function, which is equivalent to jQuery's $(). This cannot be implemented without jQuery.
In the future (say, v1.0.0) I'm thinking of making jQuery optional; jQuery is not embedded in biwascheme.js and user can use webscheme_lib by loading jquery.js explicitly.
Until then, it would be nice if there is a way to build biwascheme.js without jQuery (or, without jQuery and webscheme_lib)

Thank you for your reply.
I understand your opinion, and I'm looking forward to seeing the new version someday.
Close this issue for now.


Java Tracker not Terminating the thread after successfully sending Events

The Trackers continues to run even after the event has been send , Have to manually use  System.exit(1) to terminate the process which is not clean

Hey, @rahulrsingh09, I think this was due running Emitter thread. BatchEmitter supports close() method that is supposed to shut down the thread. Did you try to use it in shutdown hook?


JdbcIOIT flaky when run using io-it-suite-local

Note: the problem below should not affect io-it-suite and thus the jdbc jenkins job that's currently in PR. I haven't tested that exact configurations so I'm not 100% certain, but I don't have any indications that there'll be a problem.
---
I've been running the postgres kubernetes scripts locally for a while and haven't seen any problems.
However, now that I'm running it via io-it-suite-local, and I'm starting to see flakiness - clients attempting to connect to the postgres server will get "connection attempt failed" error.  The difference between what was working before and now is that now the load balancer and the pod are getting set up at the same time.
So I think the problem is in the interaction between the two or potentially just in the LoadBalancer service (it may take a little bit longer to get fully hooked up even after it reports an IP)
Possible causes:

the loadbalancer is reporting it's ready before it actually can serve traffic to the postgres instance
the lodabalancer has another status field that I'm not looking at - today we only check IP address, perhaps the loadbalancer exposes a status field? kubectl get/describe might be able to help. A cursory examination didn't show anything helpful.
the postgres instance isn't actually ready when it says it is. I don't think that's the issue since I was working with postgres pods before and they seemed fine then

Potential solutions:

if cause is slow postgres pod start (unlikely): determine postgres pod health by reading from sql?  (pg_ctl?), and then have pkb wait for that by adding a dynamic_pipeline_option that wait for the kubernetes status to be okay and sends to a non-existent pipeline option
file bug about loadbalancer not being ready when it says it is? (investigate that more :)
have some way for pkb to actually connect to and validate the connection to postgres (that seems complicated.)

If the problem is that the loadbalancer is not ready when it says it is, while we are waiting for kubernetes to fix the issue, one workaround would be to:

modify io-it-suite-local to not load any kubernetes scripts (set --beam_kubernetes_scripts equal to blank line or skip it altogether - https://github.com/apache/beam/blob/master/sdks/java/io/jdbc/pom.xml#L137)
have the user run the kubernetes scripts manually beforehand, wait for it to be healthy, and then run io-it-suite-local

To repro the problem:
mvn verify -Dio-it-suite-local -pl sdks/java/io/jdbc -DpkbLocation="your-copy-of-PerfKitBenchmarker/pkb.py" -DintegrationTestPipelineOptions='"--tempRoot=gs://sisk-test/staging"' -DforceDirectRunner=true
this should fail when run repeatedly.
Imported from Jira BEAM-2659. Original Jira may contain additional context.
Reported by: sisk.

obsolete for now. jdbcioit setup now retry connect to server (#23757)


Added Tango for Commitment Orchestrator

Thanks for contributing to the Harness Developer Hub! Our code owners will review your submission.
Description

Please describe your changes: __________________________________
Jira/GitHub Issue numbers (if any): ______________________________
Preview links/images (Internal contributors only): __________________

PR lifecycle
We aim to merge PRs within one week or less, but delays happen sometimes.
If your PR is open longer than two weeks without any human activity, please tag a code owner in a comment.
PRs must meet these requirements to be merged:

[ ] Successful preview build.
[ ] Code owner review.
[ ] No merge conflicts.
[ ] Release notes/new features docs: Feature/version released to at least one prod environment.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://6683d34dab199f23abbd1efc--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://668cd2cc1af95f3cf102e212--harness-developer.netlify.app

@joeyouss Tango doesn't show instance exclusion step though we see the button to get to that. is that expected?

@joeyouss Tango doesn't show instance exclusion step though we see the button to get to that. is that expected?

We can add that, let me edit screens


Value.ofNullable has a wrong assertion

Describe the bug
it says that Value<T>.ofNullable constructor  is to Create a value that is absent if value is null and [present] if it's not. and also The functionality is equiavalent to the following: x != null ? Value(x) : Value.absent()
But the problem is the assertion blocked the functionality:
  const Value.ofNullable(T? value)
      : assert(
          value != null || null is! T,
          "Value.ofNullable(null) can't be used for a nullable T, since the "
          'null value could be both absent and present.',
        ),
        _value = value,
        present = value != null;

Why Value.ofNullable(null) can't be used for a nullable T, ?? This assertion should be removed so we can use this construction to the equivalent functionality x != null ? Value(x) : Value.absent()

The point of the Value class is to distinguish between two common cases that one might intuitively represent as null:

Null as a present value: The column should explicitly be set to NULL in SQL.
Null as an absent value: The column should use the default value for inserts, or be unchanged for updates.

In other words, a Value stores more information than a nullable Dart expression. When we know that a column can only store non-nullable values (for instance because it has a NOT NULL constraint), the first case isn't relevant and using a nullable Dart object achieves the same thing as a value. Value.ofNullable exists only for this scenario, and this is documented as well. So it is intentional that ofNullable only works for non-nullable T.
If you have nullable columns and you want to interpret null as absent instead of setting the column to null, you'll have to spell out x != null ? Value(x) : Value.absent(). The intention here is that this choice is not obvious, and spelling it out makes it clear in code that one of the two null interpretations has explicitly been chosen. So I'll close this as working as intended.

The documentation also points out that the constructor should only be used when T is non-nullable though, which is also what the assertion is checking.

actually is implemented in such a way that the parameter shouldn't be null

The parameter can be null just fine, the type parameter is the problem. You can't do Value<String?>.ofNullable(null) since we then again have the ambiguitiy of not knowing "which null" you've meant.

I also agree with @praxder. When would this be applicable? For instance, if I'm certain that the value I'm inserting isn't nullable, I would simply use Value() instead of Value.ofNullable().

Alright, I understand now. Thank you for clarifying.

Are you considering adding a feature to handle nullable values? For instance, something like a wrapper for this:
String? polygonId;
final newSublot = SublotsCompanion(
name: drift.Value(controllerSublotName.text),
farmId: drift.Value(farmId),
cropId: drift.Value(currentCrop.value!.id),
polygonId: polygonId != null ? drift.Value(polygonId) : const drift.Value.absent(), // This comparison
);
await _farmsUseCase.insertSublot(newSublot);

Yeah, I think I'll add a Value.absentIfNull constructor for this. Given that the name is explicit about what happens with null, I think that could work for all types.


[FEATURE] Improve Test coverage for MLModelManager.java class

This issue is to track test coverage progress for the class MLModelManager.java
Here is the report showing what needs to be covered: https://app.codecov.io/gh/opensearch-project/ml-commons/blob/2.x/plugin%2Fsrc%2Fmain%2Fjava%2Forg%2Fopensearch%2Fml%2Fmodel%2FMLModelManager.java

This is a long pending item. It's tricky to add full coverage for ModelManage though.

I might take more time to do this. But, I would like to work on this anyway. can I target 80% or 85% coverage?

@rawwar Sure, no worries. Take your time. For now I'm assigning this issue to you. Let me know if you need any suggestion/assistance for this task. Thanks.


server.port property is not worked when combing Spring Cloud Config with other Spring projects.

Bug report
As title . Following is its reproduce step:

set
server:
port: 8202
in application.yml

together with below dependencies , tomcat start at port 8082

org.springframework.cloud
spring-cloud-starter-config
 2.1.0.RELEASE

 <dependency>
 	<groupId>org.springframework.boot</groupId>
 	<artifactId>spring-boot-starter-actuator</artifactId>
                 <version> 2.1.0.RELEASE</version>
 </dependency>

I have tried to config server port programmatically when starting applications,
or run with -Dserver.port=8202. Both of them are not worked.
But when I take rid of the starter-config dependency , server will start at port 8202.
Could anyone have a suggestion ?
Sincerely Regards.

Doesn't make much sense to me unless you are fetching config that has some other server.port configured.

Doesn't make much sense to me unless you are fetching config that has some other server.port configured.

I am sure that only one place has this configuration.
Following is its log :
2019-05-24 10:14:10.045  INFO 26532 --- [           main] o.s.b.w.embedded.tomcat.TomcatWebServer  : Tomcat initialized with port(s): 8082 (http)
May TomcatWebServer ignore the user defined value ? I have no idea about the sequence that  TomcatWebServer  read from.

What does /actuator/env say?

What does /actuator/env say?

As it prints out much information , I just cut part of them about 8082.
{"activeProfiles":["development"],"propertySources":[{"name":"server.ports","properties":{"local.server.port":{"value":8082}}},
"server.port":{"value":"8082"}
{"value":"/tmp/tomcat.7165274625889880626.8082"},

I don't understand. Is that from when it's working or not working?

I don't understand. Is that from when it's working or not working?

It is from not working.
I uploaded my config client project may benefit clarifying this issue.
config-client.zip

Is Dev tools setting it? I can't look at the project right now

Is Dev tools setting it? I can't look at the project right now

I use Eclipse to import config-client as Maven project .

Following is my bootstrap.properties, the port setting is not be read.
But others is properly read.
server.port= 8202
spring.application.name = config-client
spring.profiles.active=development
spring.cloud.config.uri = http://<IP_ADDRESS>:8888
management.endpoints.web.exposure.include=*

It hard to try your sample since it is missing the config server piece.  I don't see anything there that would cause it not to work.

It hard to try your sample since it is missing the config server piece. I don't see anything there that would cause it not to work.

Because server piece works properly, so I didn't post it.
The problem I meet is "server.port" setting in bootstrap.properties is not recognized by embedded Tomcat server in client side. However , when I write "server.port" setting in application.yml . Tomcat server can recognize it . If I do so , another issue is the setting of Spring Cloud Config not worked in application.yml

Again we need a complete working sample to reproduce the problem.

Again we need a complete working sample to reproduce the problem.

Following is my code.
Client side start
ConfigClientApplication.java
`package com.example.configclient;
import org.springframework.boot.SpringApplication;
import org.springframework.boot.autoconfigure.SpringBootApplication;
@SpringBootApplication
public class ConfigClientApplication {
public static void main(String[] args) {
	SpringApplication.run(ConfigClientApplication.class, args);
}

}
Controller.javapackage com.example.configclient.controller;
import org.springframework.beans.factory.annotation.Value;
import org.springframework.cloud.context.config.annotation.RefreshScope;
import org.springframework.web.bind.annotation.RequestMapping;
import org.springframework.web.bind.annotation.RestController;
@RestController
@RefreshScope
public class Controller {
@Value("${welcome.message: default value}")
String welcomeText;
@RequestMapping(value = "/")
public String welcomeText() {
	return welcomeText;
}

}
`
bootstrap.properties
server.port= 8202 spring.application.name = config-client spring.profiles.active=development spring.cloud.config.uri = http://<IP_ADDRESS>:8888 management.endpoints.web.exposure.include=*
pom.xml
`

4.0.0

org.springframework.boot
spring-boot-starter-parent
2.1.5.RELEASE

com.example
config-client
0.0.1-SNAPSHOT
config-client
Demo project for Spring Boot
<properties>
	<java.version>1.8</java.version>
	<skipTest>true</skipTest>
</properties>

<dependencies>
<dependency>
		<groupId>org.springframework.cloud</groupId>
		<artifactId>spring-cloud-starter-config</artifactId>
		<version>2.1.2.RELEASE</version>
	</dependency>

	<dependency>
		<groupId>org.springframework.boot</groupId>
		<artifactId>spring-boot-starter-actuator</artifactId>
	</dependency>

	<dependency>
		<groupId>org.springframework.boot</groupId>
		<artifactId>spring-boot-starter-web</artifactId>
	</dependency>
</dependencies>

<build>
	<plugins>
		<plugin>
			<groupId>org.springframework.boot</groupId>
			<artifactId>spring-boot-maven-plugin</artifactId>
		</plugin>
		<plugin>
			<groupId>org.apache.maven.plugins</groupId>
			<artifactId>maven-surefire-plugin</artifactId>
			<version>3.0.0-M3</version>
			<configuration>
				<skipTests>true</skipTests>
			</configuration>
		</plugin>
	</plugins>
</build>

`
=========================================
Client side end.
Server side start
ConfigserverApplication .java
`package com.example.demo;
import org.springframework.boot.SpringApplication;
import org.springframework.boot.autoconfigure.SpringBootApplication;
import org.springframework.cloud.config.server.EnableConfigServer;
@SpringBootApplication
@EnableConfigServer
public class ConfigserverApplication {
public static void main(String[] args) {
SpringApplication.run(ConfigserverApplication.class, args);
}
}`
bootstrap.properties
server.port = 8888 spring.profiles.active=native #for windows spring.cloud.config.server.native.searchLocations=file:///D:/temp #for linux #spring.cloud.config.server.native.searchLocations=/home/steven/temp
pom.xml
`

4.0.0

org.springframework.boot
spring-boot-starter-parent
2.0.5.RELEASE

com.example
demo
0.0.1-SNAPSHOT
config-server
Demo project for Spring Boot
<properties>
	<java.version>1.8</java.version>
</properties>

<dependencies>
	<dependency>
		<groupId>org.springframework.boot</groupId>
		<artifactId>spring-boot-starter</artifactId>
	</dependency>
	<dependency>
		<groupId>org.springframework.cloud</groupId>
		<artifactId>spring-cloud-config-server</artifactId>
		<version>2.0.4.RELEASE</version>
	</dependency>

</dependencies>

<build>
	<plugins>
		<plugin>
			<groupId>org.springframework.boot</groupId>
			<artifactId>spring-boot-maven-plugin</artifactId>
		</plugin>
	</plugins>
</build>

`
config-client-development.properties
`welcome.message = my test message 4
`

A complete sample we can run as a zip file or a repo we can close, not pasted in comments.

A complete sample we can run as a zip file or a repo we can close, not pasted in comments.

Attached files are server & client project zip. Only source code , no IDE tool settings or binary files.
config-client.zip
config-server.zip

I cannot run these samples because they assume you are running on windows

I cannot run these samples because they assume you are running on windows

Following is for Linux ,
server.port = 8888
spring.profiles.active=native
spring.cloud.config.server.native.searchLocations=/home/temp

When I run your samples I get the following for config client:
2019-06-05 16:38:16.161  INFO 30263 --- [           main] o.s.b.w.embedded.tomcat.TomcatWebServer  : Tomcat initialized with port(s): 8202 (http)

Looks like it is running fine on port 8202 from bootstrap.properties

If you would like us to look at this issue, please provide the requested information. If the information is not provided within the next 7 days this issue will be closed.

Closing due to lack of requested feedback. If you would like us to look at this issue, please provide the requested information and we will re-open the issue.

I had a similar problem. Cause: I configured SERVER_PORT environment variable, so no matter what you do at "server.port" in application.properties.
Solution: remove environment variable (from OS) or set to the port you want.
Reference: https://docs.spring.io/spring-boot/docs/2.1.9.RELEASE/reference/html/howto-embedded-web-servers.html
Hope this can help.


feat(UI): visualize input clear button

Checklist:

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the main branch of freeCodeCamp.
[x] I have tested these changes either locally on my machine, or GitPod.

Closes #48662

To visualize the button in the search bar that clear the search bar inputs, this PR was opened.
The code was tested locally with window 11 PC and Chrome, Edge, Firefox, and Brave browsers.

Android and iPhone Mobile situation is also tested using gitpod in android studio emulator (Pixel 3a XL, android 12.0, Chrome browser) and iPhone SE (iOS 15.7.1, Chrome, Firefox and Opera browsers).

Now search bar input is horizontally responsive when submit and clear button is appearing.
https://user-images.githubusercontent.com/44451585/206821079-b3216f2a-eaec-4a0e-88c6-147ed4947466.mp4

What do you think of moving the Reset button to the far right of the searchbar

Yes, I agree. Can you imagine typing in a long search string and then accidentally touching the reset button instead of the search button. Would make me very angry :angry: These buttons are so tiny on a small touch device that I know I would do that :slightly_smiling_face:

What do you think of moving the Reset button to the far right of the searchbar, so campers won't miss click it by mistake if they wanna click the Submit.

I also agree this. I totaly misunderstood the comments in original issue. Especially on small touch device, moving the Reset button to the far right of the searchbar will prevent miss clicking by campers.

In Edge, the icon isn't displayed.
It seems this is because the input clear button have not been implemented in search-bar-optimized.tsx in landing page. I'll also try to implement this.

After reading "Success Criterion 2.4.7" and "Using an author-supplied, visible focus indicator", should we show outline around the search bar inputs clear button when it has focus, like the search button and search bar input, with css code like below?
.ais-SearchBox-reset:focus {
  outline: #198eee solid 3px;
}

.ais-SearchBox-reset

Nice catch 👍. Go the easy route, and add reset icon selector to the code below.
.ais-SearchBox-submit:focus {
  outline: 3px solid var(--blue-mid);
}

here is the file https://github.com/mmatsumoto1026/freeCodeCamp/blob/5be065c7b546df7ba41270f897d6830d5457a077/client/src/components/Header/components/universal-nav.css#L492-L494

I am liking the accessibility enhancements so far. Nice work. There are some additional a11y issues regarding the search input but I think those are out of scope for this PR so I will open a new issue for them.
One thing I am noticing about this PR though is that I am only seeing the new inputReset component when on the main FCC landing page. If I am in the curriculum for example, then I do not see it (for example, there is no sr-only text for the button). Is this just me?

Also, if I was going to be real picky, I would suggest you remove the aria-label from the search text input and use a label instead (which you can visually hide with the sr-only class). As @Sboonny pointed out earlier, it is usually better to use visually hidden text instead of aria-label where possible because aria-label text often doesn't get translated.

One thing I am noticing about this PR though is that I am only seeing the new inputReset component when on the main FCC landing page. If I am in the curriculum for example, then I do not see it (for example, there is no sr-only text for the button). Is this just me? Same goes for the new changes to the submit button.

Not just you, me too. I had not been able to consider to add sr-only text for the buttons.
So I read algolia documentation to try to find out how can we do that, but I could not find the way to add sr-only text for the submit and clear buttons.
But alternatively, It seems that we can change the title of the buttons by setting translations prop in SearchBox component of search-bar.tsx.
So how about setting the prop for screen reader like below? By this setting, when the buttons are focused, JAWS and NVDA will say the same thing as landing pages in curriculum page. And also we will be able to make the title of the buttons translatable.
const submitTitle = t ? t('icons.magnifier') : '';
const resetTitle = t ? t('icons.inputReset') : '';
const placeholder = t ? t('search.placeholder') : '';

	<SearchBox
		focusShortcuts={['83', '191']}
		onChange={this.handleChange}
		onSubmit={e => {
			this.handleSearch(e);
		}}
		showLoadingIndicator={false}
		translations={{
			submitTitle: submitTitle,
			resetTitle: resetTitle,
			placeholder: placeholder
		}}
	/>

I would suggest you remove the aria-label from the search text input and use a label instead (which you can visually hide with the sr-only class).

I actually don't know why the author used aria-label here, but I agree with your suggestion which uses label instead of aria-label.
And Could I assume that I understood your suggestion with the code in search-bar-optimized.tsx shown below?
<label className='sr-only' htmlFor='ais-SearchBox-input'>
    {t ? t('search.label') : ''}
</label>
<input
    autoCapitalize='off'
    autoComplete='off'
    autoCorrect='off'
    id='ais-SearchBox-input'
    className='ais-SearchBox-input'
    maxLength={512}
    onChange={onChange}
    placeholder={placeholder}
    spellCheck='false'
    type='search'
    value={value}
    ref={inputElementRef}
/>

It seems that we can change the title of the buttons by setting translations prop in SearchBox component

If that's the only option we have then I guess it's better than nothing. I guess algolia sort of forgot about accessibility when creating their search widget :slightly_smiling_face:

Is this one ready for review @mmatsumoto1026?

Hello, @moT01. Yes, this PR now ready for review.
Sorry for not attaching "waiting review" label.

No worries - I'm pretty sure you aren't able to do that 👍

One more accessibility issue. Can we change the name of the magnifying glass icon? Right now it is set to "magnifier". But the icon actually initiates a search, so it should be set to "search".


Bug report: Zap Or Uninstall Is not Responding

Hello,
I'm trying to zap the cask Bitcoin-XT even after reading the instruction in 👍 :
https://github.com/caskroom/homebrew-cask/blob/master/doc/reporting_bugs/pre_bug_report.md
brew cask zap bitcoin-xt --force
==> Implied "brew cask uninstall bitcoin-xt"
==> Removing App '/Applications/Bitcoin-XT.app'.
Error: Permission denied - /Applications/Bitcoin-XT.app/Contents/_CodeSignature/CodeResources
Follow the instructions here:
  https://github.com/caskroom/homebrew-cask/blob/master/doc/reporting_bugs/pre_bug_report.md

If this doesn’t fix the problem, please report this bug:
  https://github.com/caskroom/homebrew-cask#reporting-bugs

/System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib/ruby/2.0.0/fileutils.rb:1439:in `unlink'
/System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib/ruby/2.0.0/fileutils.rb:1439:in `block in remove_file'
/System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib/ruby/2.0.0/fileutils.rb:1444:in `platform_support'
/System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib/ruby/2.0.0/fileutils.rb:1438:in `remove_file'
/System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib/ruby/2.0.0/fileutils.rb:1427:in `remove'
/System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib/ruby/2.0.0/fileutils.rb:770:in `block in remove_entry'
/System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib/ruby/2.0.0/fileutils.rb:1477:in `block (2 levels) in postorder_traverse'
/System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib/ruby/2.0.0/fileutils.rb:1477:in `block (2 levels) in postorder_traverse'
/System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib/ruby/2.0.0/fileutils.rb:1477:in `block (2 levels) in postorder_traverse'
/System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib/ruby/2.0.0/fileutils.rb:1481:in `postorder_traverse'
/System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib/ruby/2.0.0/fileutils.rb:1476:in `block in postorder_traverse'
/System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib/ruby/2.0.0/fileutils.rb:1475:in `each'
/System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib/ruby/2.0.0/fileutils.rb:1475:in `postorder_traverse'
/System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib/ruby/2.0.0/fileutils.rb:1476:in `block in postorder_traverse'
/System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib/ruby/2.0.0/fileutils.rb:1475:in `each'
/System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib/ruby/2.0.0/fileutils.rb:1475:in `postorder_traverse'
/System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib/ruby/2.0.0/fileutils.rb:1476:in `block in postorder_traverse'
/System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib/ruby/2.0.0/fileutils.rb:1475:in `each'
/System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib/ruby/2.0.0/fileutils.rb:1475:in `postorder_traverse'
/System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib/ruby/2.0.0/fileutils.rb:768:in `remove_entry'
/System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib/ruby/2.0.0/fileutils.rb:626:in `block in rm_r'
/System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib/ruby/2.0.0/fileutils.rb:622:in `each'
/System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib/ruby/2.0.0/fileutils.rb:622:in `rm_r'
/System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib/ruby/2.0.0/pathname.rb:570:in `rmtree'
/usr/local/Homebrew/Library/Homebrew/cask/lib/hbc/artifact/moved.rb:47:in `delete'
/usr/local/Homebrew/Library/Homebrew/cask/lib/hbc/artifact/relocated.rb:49:in `block in each_artifact'
/usr/local/Homebrew/Library/Homebrew/cask/lib/hbc/artifact/relocated.rb:47:in `each'
/usr/local/Homebrew/Library/Homebrew/cask/lib/hbc/artifact/relocated.rb:47:in `each_artifact'
/usr/local/Homebrew/Library/Homebrew/cask/lib/hbc/artifact/moved.rb:15:in `uninstall_phase'
/usr/local/Homebrew/Library/Homebrew/cask/lib/hbc/installer.rb:330:in `block in uninstall_artifacts'
/usr/local/Homebrew/Library/Homebrew/cask/lib/hbc/installer.rb:327:in `each'
/usr/local/Homebrew/Library/Homebrew/cask/lib/hbc/installer.rb:327:in `uninstall_artifacts'
/usr/local/Homebrew/Library/Homebrew/cask/lib/hbc/installer.rb:336:in `zap'
/usr/local/Homebrew/Library/Homebrew/cask/lib/hbc/cli/zap.rb:10:in `block in run'
/usr/local/Homebrew/Library/Homebrew/cask/lib/hbc/cli/zap.rb:7:in `each'
/usr/local/Homebrew/Library/Homebrew/cask/lib/hbc/cli/zap.rb:7:in `run'
/usr/local/Homebrew/Library/Homebrew/cask/lib/hbc/cli.rb:114:in `run_command'
/usr/local/Homebrew/Library/Homebrew/cask/lib/hbc/cli.rb:157:in `process'
/usr/local/Homebrew/Library/Homebrew/cmd/cask.rb:8:in `cask'
/usr/local/Homebrew/Library/Homebrew/brew.rb:91:in `<main>

should I permit the user to own the file /CodeResources ?

https://github.com/caskroom/homebrew-cask/pull/30905


Openssl verify fails with critical crlDistributionPoint extension

Already reported in issue #660
This is still an issue on version 1.0.2k
The actual error with openssl verify is:
error 34 at 0 depth lookup:unhandled critical extension
-ignore_critical makes it go away, but that's obviously wrong.
I'm not sure if there are other implications (whether e.g. s_client would work with such certificate)

OpenSSL does not handle the crlDistributionPoint extension, therefore it is doing the right thing when it is marked as critical.  Closing this.

I do not believe that is correct. Openssl verify has a -crl_download option (which I have tried and seems to do nothing even when crlDistributionPoint is non critical).
Changelog says:
*) New option -crl_download in several openssl utilities to download CRLs
from CRLDP extension in certificates.
[Steve Henson]

Ah, was this in certificates or crl's?

In a certificate
Happens with both a list of several URIs or a single URI
      X509v3 CRL Distribution Points: critical

            Full Name:
              URI:http://some.thi.ng/ca.crl

or
        X509v3 CRL Distribution Points: critical

            Full Name:
              URI:http://some1.thi.ng/ca.crl

            Full Name:
              URI:http://some2.thi.ng/ca.crl

            Full Name:
              URI:http://some3.thi.ng/ca.crl

fix with the closing of #3087.


check_model_has_tests_by_name being applied to all models

Describe the bug
When using pre-commit and committing a change of a file in the root directory that is not related to a dbt model (i.e. change to the .pre-commit-config.yaml), the check_model_has_tests_by_name hook checks across all available models in the manifest.json, this happens even if an exclude argument has been specified.
Also, related to the --exclude argument, the example presented in HOOKS.md shows the following example:
args: ["--test-cnt", "1", "--exclude models/demo", "--"]
However, this syntax generates an error, I believe this should be updated to:
 args: ["--test-cnt", "1", "--exclude", "models/demo", "--"]
To Reproduce
Steps to reproduce the behavior:

Add pre-commit hook to .pre-commit-config.yaml

   - repo: https://github.com/dbt-checkpoint/dbt-checkpoint
    rev: v2.0.1
    hooks:
      - id: check-model-has-tests-by-name
        args: ["--tests", "unique=1","--exclude",  "^(?!models/).*" ,"--"]

Stage and commit the .pre-commit-config.yaml change
pre-commit fails with all models in the project that fail the criteria (i.e. all models that do not have a unique test)

Expected behavior
The expected behavior is that this test checks only for dbt models or corresponding properties yml files that are committed or that using the exclude argument we can specify which files should be excluded. For example using the regex expression  "^(?!models/).*" would exclude committed changes that are not part of the models folder.
Version:
v2.0.1
Additional context
In this attached image you can see that check-model-has-test-by-name failed even when .pre-commit-config.yaml file was the only change. This is not specific to change to pre-commit-config file, changes to other files like project.yml also trigger this behavior.

Hey @SantiASC, we can't reproduce this apparent bug.
Both using and not using exclude statement

in both cases hook is skipped
✗ pre-commit
Check the model tests by a test name.................(no files to check)Skipped
sqlfluff-lint........................................(no files to check)Skipped
yamllint.............................................(no files to check)Skipped


Additional statements in role policy (eg. for AWS SSO)

I propose to add possibility to add more statements in assumable role policy.
In standard case assumable role could have policy like:
{
  "Version": "2012-10-17",
  "Statement": [
    {
      "Effect": "Allow",
      "Principal": {
        "AWS": [
          "arn:aws:iam::${var.master_aws_account_id}:user/ci-provisioner"
        ]
      },
      "Action": "sts:AssumeRole"
    }
  ]
}

And this will work for running Terraform with "static" user credential - eg. my own IAM user, IAM service account user.
But if I want to add access to other users using AWS SSO and also grant them rights to use Terraform using the same assumable role, the role policy should have one more statement, like:
{
  "Version": "2012-10-17",
  "Statement": [
    {
      "Effect": "Allow",
      "Principal": {
        "AWS": [
          "arn:aws:iam::${var.master_aws_account_id}:user/ci-provisioner"
        ]
      },
      "Action": "sts:AssumeRole"
    },
    {
      "Effect": "Allow",
      "Principal": {
        "AWS": [
          "arn:aws:iam::${var.sso_account_id}:root"
        ]
      },
      "Action": "sts:AssumeRole",
      "Condition": {
        "StringLike": {
          "aws:PrincipalArn": [
            "arn:aws:iam::${var.sso_account_id}:role/aws-reserved/sso.amazonaws.com/*/AWSReservedSSO_${var.sso_role_name}_*",
            "arn:aws:iam::${var.sso_account_id}:role/aws-reserved/sso.amazonaws.com/AWSReservedSSO_${var.sso_role_name}_*"
          ]
        }
      }
    }
  ]
}

Thus I have used override_json field in data "aws_iam_policy_document" "assume_role" and data "aws_iam_policy_document" "assume_role_with_mfa" datasources in iam-assumable-role module.
Without providing Sid in "source" policy document it is not possible to override any value. But it gives a possiblity to add a new statement entry.
So to to use it, in my TF code I have add:
data "aws_iam_policy_document" "assume_role_sso" {
  statement {
    effect = "Allow"

    actions = ["sts:AssumeRole"]

    principals {
      type        = "AWS"
      identifiers = ["arn:aws:iam::${var.sso_account_id}:root"]
    }

    condition {
      test     = "StringLike"
      variable = "aws:PrincipalArn"
      values = [
        "arn:aws:iam::${var.sso_account_id}:role/aws-reserved/sso.amazonaws.com/*/AWSReservedSSO_${var.sso_role_name}_*",
        "arn:aws:iam::${var.sso_account_id}:role/aws-reserved/sso.amazonaws.com/AWSReservedSSO_${var.sso_role_name}_*"
      ]
    }
  }
}

and in module I use it like:
module "ci_provisioner_role" {
  source  = "terraform-aws-modules/iam/aws//modules/iam-assumable-role"
  version = "~> 3.0"

  create_role       = true
  role_name         = "ci-provisioner"
  role_requires_mfa = false

  attach_admin_policy = true

  trusted_role_arns = [
    "arn:aws:iam::${var.master_aws_account_id}:user/ci-provisioner"
  ]

  role_additional_policy_statements = var.sso_trust_enabled ? data.aws_iam_policy_document.assume_role_sso.json : ""
}

You can see my change in https://github.com/terraform-aws-modules/terraform-aws-iam/compare/master...dzinek:additional-statement-role, it is ready (I hope) for create a Pull Request.

Checkout #176


feat(datepicker): pass options from popup to inline

Pass through options object wholesale from popup to inline datepicker

BREAKING CHANGE: This breaks any snake-cased key usage, i.e.
show-weeks. Convert all keys used to camelCase.

What is the reasoning of having datepickerMode in a separate way?

The reason is because it is already optionally two-way bound in the inline datepicker as a separate attribute. Probably need to clean that up, but doing that now would be a slightly bigger change.
I'm fine with making it - what do you think?

What I don't see is how the inline datepicker picks that mode from how you put it here.

It's mainly meant for reading

LGTM


Implement UCI standard

https://www.shredderchess.com/download/div/uci.zip

This was so annoying trying to implement that I nearly dropped the project.


Updated NPM version in the Get Started section. Starting from NPM 3+ …

Hi Grommet Team,
I´ve adjusted the doc in order to solve the 'Could not find preset es2015 relative to directory error' which happens when you follow the Get Started section and use NPM <3. Please see also https://slack-redir.net/link?url=https%3A%2F%2Fgithub.com%2Fgrommet%2Fgrommet%2Fissues%2F477.
Kind regards,
Paolo

thanks! welcome to the team


feat: remove ETH/FOX farming opportunity state

Description

Notice

[ ] Have you followed the guidelines in our Contributing guide?
[ ] Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Pull Request Type

[ ] :bug: Bug fix (Non-breaking Change: Fixes an issue)
[ ] :hammer_and_wrench: Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
[ ] :nail_care: New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

closes #
Risk

Testing

Engineering

Operations

Screenshots (if applicable)

Current dependencies on/for this PR:

develop

PR #3994

PR #3995   👈

This comment was auto-generated by Graphite.


AsyncStorage.getItem returns 'undefined'

I am simply trying to save some string items to local storage in a React-native ios application. The AsyncStorage.setItem promise resolves correctly however upon using AsyncStorage.getItem the resolved value is 'undefined'. Using version 0.3.4
    dataService
                    .fetchPost('session', {uuid: results.contents})
                    .then(result=>
                        result.json()
                )
                    .then(json =>
                        AsyncStorage
                            .setItem('jwToken', json.token)
                )
                    .then(()=>
                        AsyncStorage
                            .getItem('jwToken') //this is resolving to undefined
                )
                    .then(value =>   //this value is undefined here
                        dataService
                            .fetchGet('data', {access_token: value})
                )
                    .then(result =>
                        console.log(JSON.stringify(result))
                )
                    .catch(error =>
                        console.log('Error: ' + error.message)
                )

Fixed after upgrade of npm package "react-native" to "0.3.7"


IGNITE-5218: First version of decision trees.

please fix code inspection warnings: in CacheColumnDecisionTreeTrainerInput for field samplesCnt, in LabeledVectorDouble for variable label, and possibly also take a look at duplicated code reported for VarianceSplitCalculator.calculateRegionInfo vs RegionCalculators.VARIANCE


Example not working

First of all, thanks for making this library. I'm currently trying to create a FIX engine in rust and this library has been most helpful so far!
I was looking at the examples in but found some of them not working as expected(some even not compiling) such as https://github.com/ferrumfix/ferrumfix/blob/develop/examples/20_tokio_fix_initiator/src/main.rs
It seems that in 0.7.0 fefix::session::FixConnection was removed due to some reason. Would it be possible to know why?
And since fix::session::Backend trait it's genuine trait instead of async_trait, I'm presuming there are specific design patterns for FIX Engines in the future such as creating a socket acceptor in a tokio task and forwarding all messages to a different task via a channel? It would be great to know what you are planning and how I could help!
Thanks again for creating this library!

Hi! Thank you for reading through the code and providing feedback!
I decided to momentarily remove fefix::session::FixConnection because it's not ready yet. Mind you, it's the single feature I'm most dedicated to, so it'll be back in some future version once I've made some progress. Before 0.7.0, FixConnection was always there yet broken and I think it's better to be more direct in showing my users what I consider to be ready to use and what is not. This is also the reason why some examples using it may be momentarily commented out!
As for async_trait - you're right, it would be so much simpler. Unfortunately, it costs one allocation per function call which is quite expensive. For the foreseeable future, the Backend / Application type (I haven't settled on a name yet) will not be async and users will have to either use a thread pool or e.g. explicitly enter a Tokio Runtime. It's a bit annoying, but it'll work and it will flexible enough for almost any use case.
Long  term, we want to provide a middleware API so that users can build abstractions on top of Backend. Some examples might be:

Log all incoming and outgoing messages.
Store all messages in a DB.
Add some FIX field in the header of all outgoing messages, before they're sent out.
Build your application against an AsyncBackend wrapper, rather than directly against Backend.

The specific pattern via channels that you mentioned will be possible!
Thank you for offering to help! I don't think I'll be able to accept contributions to the core at the moment (it takes a lot of energy and things are mature enough yet), but our documentation could definitely use some help. You can try to build docs on your machine with RUSTDOCFLAGS="--cfg doc_cfg" cargo +nightly doc --all-features --open. You'll get warnings about missing documentation items and you can start from there. You can get a sense of what kind of writing style I'm going for by looking at what I've written so far.

@neysofu Sounds all good. This project definitely has a lot of potentials and I cannot wait to see how great this can become. In the meantime, since I'm currently looking for a ready-to-use library for FIX engines, I'll use https://github.com/jbendig/fix-rs for a simple poc product I'm working on. Hopefully, this project becomes production ready so that I'll be able to swith FIX library to this in the near future.
Thanks again for staring on this project.


chore: add lint action

It seems like our good friend eslint has not been run in a while :) I've added a GitHub action that runs eslint, and I've also cleaned up or ignored relevant errors so that the action will pass.
There are a number of warnings that we can clean up as well, but I think this is a good start. Additionally, if we want to add eslint configuration to other packages within the monorepo, we can simply add a lint yarn script, and lerna is smart enough to run the command on packages that have changed.

I like it, thanks!


Feedback for “Configuration files”

In "Push and Pull" section there are two tabs of how configuration may be done. In the first tab environment variables are used but the
import * as dotenv from "dotenv";
dotenv.config();

or
import 'dotenv/config';

is missing. The second tab uses environment variables as intended.
And I believe this may be misleading and confusing for newer users of drizzle or node.js.

This has been addressed in recent updates to the docs.


How about add custom AbstractModel class for user 's custom?

Inspired from laravel, can you add AbstractModel.h + AbstractModel.cc to models folder (when create new app), and auto extends to it when auto gen models orm?
With this abstract, user can freely to add their custom to each model

Could Mapper::paginate() in  #1112 solve your problem?

@hwc0919 yeah thanks, but I think you should add a custom-able for end-user to modify what they want

Could you give a example on what you refering by 'user custom'?
https://github.com/drogonframework/drogon/blob/d18740d4bca53670c55e1a3bbdb1b84694eda9f4/drogon_ctl/templates/model_h.csp#L560-L564
These things can be done for all models with a simple template function, which can be written anywhere you want. In fact, I think they are all business related and should not be appeared in orm level.

@hwc0919
Thanks,
I think atm, we not need an abstract model.
But should have a way for end-user modify orm Model
Like EAV ( https://en.wikipedia.org/wiki/Entity–attribute–value_model ), or custom output for toJson

You could make some templates like the Mapper template to approach the aim, for your case, just move the code you added to the model.csp outside, make it a function template:
    template <class T>
    std::shared_ptr<Json::Value> paginate(const drogon::orm::Criteria &criteria, int limit, int page)
    {
        if (page <= 0)
        {
            page = 1;
        }
        auto resJson = std::make_shared<Json::Value>();

        auto dbClientPtr = drogon::app().getDbClient()->newTransaction();
        drogon::orm::Mapper<T> tblMapper(dbClientPtr);
        (*resJson)["current_page"] = page;
        (*resJson)["total"] = static_cast<uint>(tblMapper.count(criteria));
        (*resJson)["per_page"] = limit;
        (*resJson)["data"] = Json::Value(Json::arrayValue);
        auto &resJsonData = (*resJson)["data"];
        auto rcb = tblMapper
                        .orderBy(T::Cols::_created_at, drogon::orm::SortOrder::DESC)
                        .limit(limit)
                        .offset(limit * (page - 1))
                        .findBy(criteria);
        for (const auto &row : rcb)
        {
            resJsonData.append(row.toJson());
        }

        return resJson;
    }

This static polymorphic technology can help you expand the capabilities of models

The model class generated by drogon_ctl create model is just a helper. If you need some custom feature, you can just modified the source file, add or modify some methods. No need of polymorphic at all. For example you can modify the toJson() method to ignore some fields or add some transformation, or you can add a method toCustomJson() to meet your own need.

@hwc0919
these model are auto-generated, so, as an end-user 's view-point, I'm scare about modify content of it
also, these file are updated after each update of drogon, so i think we should not modify it directly


RxMobius: Removes unused SchedulerWorkRunner class for rx/rx2

It seems the change is binary incompatible but we are not using this class anymore ... What would be the best way to clean things up?

We will simply have to keep it until we make a new major version. It's a bit bad, but not really terrible. (in case you haven't seen it, here's a great talk about that topic: https://www.youtube.com/watch?v=oyLBGkS5ICk)

Thanks for explaining will close the PR

This is not an unused class - it's a public API that users of mobius depend on. Eg. at Spotify we have at least 73 usages of it.

Oh makes sense, I will add it to the RxJava3 PR.