updated sprockets 3.x to 4.x

Describe the changes you have made in this PR -
As @Kartikay304 mentioned,
when we update sprockets 3.x to 4.x it throws double link errors
to solve double link error --> renamed the image files
ex: AsyncCounter_n.jpg to new_AsyncCounter_n.jpg
after that it throws error saying
Can't resolve image into URL: undefined method start_with?' for /\.(?:svg|eot|woff|ttf)$/:Regexp
to solve this , changed
Rails.application.config.assets.precompile << /\.(?:svg|eot|woff|woff2|ttf|otf)$/  line to Rails.application.config.assets.precompile << ["*.svg", "*.eot", "*.woff", "*.ttf"] in config/initializers/assets.rb
after that, it throws an error for something stylesheet.css in assests>config>manifist.js
to solve that added //= link application.css line in app/assets/config/manifest.js
Now getting some warnings saying DevTools failed to load source map

Please check if these steps are correct for updating sprockets 3.x to 4.x or not and how to solve these errors??

Coverage remained the same at 81.774% when pulling 0d45fcd8fcaa93e76ac2681f6c24aa83d7c180bd on pulkit-30:upgrade-sprockets into 29f98c87dd976f9106968ec4277131127f5b9fe0 on CircuitVerse:master.

You can delete image files which are no longer needed

Link for ref https://github.com/rails/sprockets/blob/master/UPGRADING.md

Hey @tacyons,
I tried to solve these errors but i am unable

one similar issue is also mentioned @rails community
One way I found, is to redirect to the correct mapped file, but I don't think it is a correct way to handle this error

Please help me out with this

Merging this as source map shouldn't be blocker for now


ValueCollection appears to cause crash on Quick Action

Mapping Generator Version
v1.21.15
Mapping Generator distribution
VSExtension
IDE type and version
Microsoft Visual Studio Professional 2019
Version 16.8.4
VisualStudio.16.Release/16.8.4+30907.101
Describe the incorrect behavior
When invoking the Quick Action menu on a CS0029 C# Cannot implicitly convert type squiggle which is a Dictionary<T,K>.ValueCollection the MappingGenerator extension crashes with the following stack trace:

System.IndexOutOfRangeException : Index was outside the bounds of the array.
at MappingGenerator.Mappings.MappingHelper.GetElementType(ITypeSymbol collectionType)
at async MappingGenerator.Mappings.MappingEngine.MapCollectionsAsync()
at async MappingGenerator.Mappings.MappingEngine.TryToCreateMappingExpression()
at async MappingGenerator.Mappings.MappingEngine.MapExpression()
at async MappingGenerator.Mappings.MappingEngine.MapExpression()
at async MappingGenerator.Features.CodeFixes.ExplicitConversionCodeFixProvider.GenerateExplicitConversion()
at async Microsoft.CodeAnalysis.CodeActions.CodeAction.GetChangedSolutionAsync()
at async Microsoft.CodeAnalysis.CodeActions.CodeAction.ComputeOperationsAsync()
at async Microsoft.CodeAnalysis.CodeActions.CodeAction.GetPreviewOperationsAsync()
at async Microsoft.CodeAnalysis.Editor.Implementation.Suggestions.SuggestedAction.GetPreviewResultAsync()
at async Microsoft.CodeAnalysis.Editor.Implementation.Suggestions.SuggestedActionWithNestedFlavors.<>c__DisplayClass11_0.b__0()
at async Microsoft.CodeAnalysis.Extensions.IExtensionManagerExtensions.PerformFunctionAsyncT

Here is some example code to reproduce:
public class Source { }
public class Destination { }

public IEnumerable<Destination> Example(Dictionary<string, Source> source)
{
	return source.Values;
}

Describe the expected behavior
Would expect either no suggestion from MappingGenerator, or even better it can create mapping from the ValueCollection.
Screenshots

Hi @antmeehan
This should be fixed in v1.22.  Would you mind testing the fix and letting me know it that works for you as expected?
Please also consider supporting MappingGenerator project. Thanks!

Thanks @cezarypiatek for the fast response! I'm very impressed with your DevOps process too.
The fix stops the crash now, but the mapping doesn't occur as I would expect. Eg.
public class Source
{
	public string A { get; set; }
}

public class Destination
{
	public string A { get; set; }
}

public IEnumerable<Destination> Example(Dictionary<string, Source> source)
{
	return source.Values;
}

gets changed to:
public IEnumerable<Destination> Example(Dictionary<string, Source> source)
{
	return source.Values.Select(sourceValue => new Destination());
}

But I would expect:
public IEnumerable<Destination> Example(Dictionary<string, Source> source)
{
	return source.Values.Select(sourceValue => new Destination()
	{
		A = sourceValue.A
	});
}

Thanks @cezarypiatek for the fast response! I'm very impressed with your DevOps process too.
The fix stops the crash now, but the mapping doesn't occur as I would expect. Eg.
public class Source
{
	public string A { get; set; }
}

public class Destination
{
	public string A { get; set; }
}

public IEnumerable<Destination> Example(Dictionary<string, Source> source)
{
	return source.Values;
}

gets changed to:
public IEnumerable<Destination> Example(Dictionary<string, Source> source)
{
	return source.Values.Select(sourceValue => new Destination());
}

But I would expect:
public IEnumerable<Destination> Example(Dictionary<string, Source> source)
{
	return source.Values.Select(sourceValue => new Destination()
	{
		A = sourceValue.A
	});
}

HI @antmeehan
Apologies, my mistake. Please check v1.22.1 (should be released shortly)

HI @antmeehan
Apologies, my mistake. Please check v1.22.1 (should be released shortly)


os.stat offers better performance than aiofiles.os.stat?

When the number of concurrent connections is limited, reading files using open without a thread-pool offers better performance than using thread-pools (like in aiofiles). However, when the number of concurrent connections is higher, for example 1000; a thread pool shows its benefit.
The same doesn't hold true for os.stat, that offers much better performance than aiofiles.os.stat even with 1000 concurrent connections.

done at https://github.com/RobertoPrevato/BlackSheep/commit/38e56a7175a8e61f9ff7d0c22358aae4c0fe62cd


Show next alarm when no event showing

The next alarm text will currently only show if there is an event showing on the widget

Fixed in version 2.0.1.


Rename Workspaces Easily

Renaming a workspace requires a user to hover over the workspace title in the sidebar and click the button that appears, and then click on the edit button in the new window that pops up. I think this could be made easier.
Suggestions (can be both):

When hovering over the workspace title in the sidebar, a pencil icon appears on the right. Clicking on this icon enters the edit mode on the workspace title.

or

Double clicking on the workspace title enters the workspace name edit mode

Hello @esimkowitz
I came across this issue and would like to work on resolving it. Can you assign it to me ?

Ah, this is for our old app, I believe it is no longer relevant. We completely redid our app this summer and just shipped our new workspaces feature, which pretty much exactly aligns with the suggested implementation here

I will close this issue for now as I believe we’ve satisfied the ask here, but please open a new one if you’ve got an idea on how our implementation can be improved!

No issues, thanks for the reply :)


Regarding Direction

I m using Course attribute which is in other field of position table but i think its not giving right direction in which vehicle is moving can you please help me to solve this problem

Course parameters shouldn't be in the other field. It's a separate parameter that is stored in its own column in the database.
If you think it's incorrect value, please provide corresponding HEX message from device that can be found in tracker-server.log file.

every hex message is different this is the one that i give you so can you helo me with this
2015-06-22 17:18:25 DEBUG: [8023 <- <IP_ADDRESS>] - HEX: 78780a13440604000200468b6f0d0a
2015-06-22 17:18:25 DEBUG: [8023 -> <IP_ADDRESS>] - HEX:<PHONE_NUMBER>46df4a0d0a
2015-06-22 17:18:25  INFO: device: 6, time: Mon Jun 22 17:18:25 NZST 2015, lat: -43.53970666666667, lon:<PHONE_NUMBER>3333332
These are the three detail in traccarweb.config and the course in my database save at this time is 54 so can you pls tell me is this right or what i have to do to resolve this problem .

I am waiting for your reply

The sample you provided is a status message, so it doesn't have any GPS info.


[BUG] Build failed on Hugo v0.124.1

Describe the bug 描述你遇到的错误
A build failure is spot upon running hugo server -D
Watching for changes in /workspace/personal-blog/{archetypes,assets,content,data,static,themes}
Watching for config changes in /workspace/personal-blog/config/_default
Start building sites …
hugo v0.124.1-db083b05f16c945fec04f745f0ca8640560cf1ec+extended linux/amd64 BuildDate=2024-03-20T11:40:10Z VendorInfo=gohugoio

WARN  Current environment is "development". The "comment system", "PWA", "CDN" and "fingerprint" will be disabled.
当前运行环境是 "development". "评论系统", "PWA", "CDN" 和 "fingerprint" 不会启用.
ERROR Inline fontawesome icons are deprecated. Remove params.page.fontawesome and audit all usage of :( fa icons ): on your site. Use the fa-icon shortcode instead. See https://hugodoit.pages.dev/theme-documentation-extended-shortcodes/#fa-icon
Built in 185 ms
Error: error building site: logged 1 error(s)

Expected behavior 期待的行为
Build should not failed
Screenshots 屏幕截图
No response
Build Environment 构建环境

OS: Debian 12 from devcontainer
Theme: https://github.com/HEIGE-PCloud/DoIt/commit/ea7dc16f031fb4069c88fcf4c34f3c344b89843a
Hugo: v0.124.1 Extend

Preview Environment 预览环境

OS: Windows 10 Pro
Browser: Brave Version 1.64.113 Chromium: 123.0.6312.86

Additional Information 补充信息
Not sure if this is related https://github.com/HEIGE-PCloud/DoIt/issues/1227, as the build was successful a few days ago. I suspect that a commit pushed recently may have triggered that deprecation.

Lol for anyone encountering this deprecation, simply set fontawesome = false in [params.page].
If you are using the params.toml file, it is in [page]

Lol for anyone encountering this deprecation, simply set fontawesome = false in [params.page].
If you are using the params.toml file, it is in [page]

It’s safe to remove this option completely.
Also do check whether you are actually using this syntax :( fa icon ): Migrate to the fa-icon shortcode if needed.


Implement Margin Trade notification settings

This shouldn't be merged until backend is ready for this? @tiltom

This could be merged because I only want to merge it to a new margin trade base branch. BE integration of notification settings will be added in https://taiga.sovryn.app/project/sovryn-light/task/282? .
PR from the base branch to development doesn't exist yet but I will create it (as a Draft) once this PR is merged and label it with do-not-merge.

@tiltom Looks good, the only thing is that we need this to be used on new spot trading page too. so we should make it a bit more reusable. maybe we can do it once the backed is ready.

That information is new to me :D Do you know if we're going to launch both Spot and Margin trade new pages at once? If so, you could merge our base branch to yours.

@tiltom Looks good, the only thing is that we need this to be used on new spot trading page too. so we should make it a bit more reusable. maybe we can do it once the backed is ready.

What is the use trade on spot trade? Notify user when price drops/increases to user target? Or it's for spot trading using order books?

@tiltom Looks good, the only thing is that we need this to be used on new spot trading page too. so we should make it a bit more reusable. maybe we can do it once the backed is ready.

What is the use case for it on spot trade? Notify user when price drops/increases to user target? Or it's for spot trading using order books?

@rick23p ?


Landmarks are not showing

You can see the camera preview and the score, but landmarks circles are not showing

Same problem with landmark not showing on camera preview

need to enable that flag in the code, dont remember where exactly

@aldolares @murali129 just uncomment this command rel.addView(modifiedImage); in CameraActivity class.
that solved the problem.
Thank You


Randomize filtered list (movie/food) to 5 movies (1 primary and 4 secondary) and 1 food

Created function to randomize the filtered list.

5 movies
1 food


Add 120 FPS Mod + DynamicFPS v1.41

I made this mod of a mod. Handle with care. Requires configuring the emulator to allow higher than 60 FPS, in the case of Yuzu, set Limit Speed Percent to 200% - Or just disable it.
FWIW: I get 80-110 FPS on my system with a 5800X3D and a RTX 3070. So I'm pretty sure it's 120 FPS but I can't actually be sure.

I merge the PR, i'll write a documentation and add it to the 1.4.1 zip tomorrow.
But i added you as collaborator if you wish to do it yourself, feel free to write documentation and add a 1.4.1 by following our model.


[go_router] ShellRoute doesn't correctly parse GoRouterState.params

when there are router parameters present, GoRouterState.params in ShellRoute.builder doesn't get filled, but it gets filled in the relative GoRoute
sample app:
class MyApp extends StatelessWidget {
  const MyApp({super.key});
  String logState(GoRouterState state) {
    return 'Current route: ${state.location}, params: ${state.params}, queryParams: ${state.queryParams}';
  }

  @override
  Widget build(BuildContext context) {
    return MaterialApp.router(
      title: 'Flutter Demo',
      routerConfig: GoRouter(
        initialLocation: '/a',
        routes: [
          ShellRoute(
            builder: (context, state, child) {
              return Scaffold(
                body: Column(
                  crossAxisAlignment: CrossAxisAlignment.stretch,
                  children: [
                    Text('ShellRoute: ${logState(state)}'),
                    Expanded(child: child),
                  ],
                ),
              );
            },
            routes: [
              GoRoute(
                path: '/a',
                builder: (context, state) => Text('a: ${logState(state)}'),
              ),
              GoRoute(
                path: '/b/:bParam',
                builder: (context, state) => Text('b: ${logState(state)}'),
              ),
            ],
          )
        ],
      ),
    );
  }
}

Result:

Expected Result:
params in both should be the same
using go_router: ^5.0.2
Flutter (Channel master, 3.4.0-30.0.pre.18, on Microsoft Windows [Version 10.0.19043.2075], locale en-US)
    • Flutter version 3.4.0-30.0.pre.18 on channel master at C:\tools\flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 9f5174f721 (28 hours ago), 2022-09-25 21:14:31 -0400
    • Engine revision 1c232b584c
    • Dart version 2.19.0 (build 2.19.0-240.0.dev)
    • DevTools version 2.17.0

@ahmednfwela thanks for filing the issue.  This issue is reproducible on the latest stable and master channels with go_router: ^5.0.2.
Issue Reproduction

Demo

Sample code
import 'package:flutter/material.dart';
import 'package:go_router/go_router.dart';

void main() {
  runApp(const MyApp());
}

class MyApp extends StatelessWidget {
  const MyApp({super.key});
  String logState(GoRouterState state) {
    return 'Current route: ${state.location}, params: ${state.params}, queryParams: ${state.queryParams}';
  }

  @override
  Widget build(BuildContext context) {
    return MaterialApp.router(
      title: 'Flutter Demo',
      routerConfig: GoRouter(
        initialLocation: '/a',
        routes: [
          ShellRoute(
            builder: (context, state, child) {
              return Scaffold(
                body: Column(
                  crossAxisAlignment: CrossAxisAlignment.stretch,
                  children: [
                    Text('ShellRoute: ${logState(state)}'),
                    Expanded(child: child),
                  ],
                ),
              );
            },
            routes: [
              GoRoute(
                path: '/a',
                builder: (context, state) => Text('a: ${logState(state)}'),
              ),
              GoRoute(
                path: '/b/:bParam',
                builder: (context, state) => Text('b: ${logState(state)}'),
              ),
            ],
          )
        ],
      ),
    );
  }
}

flutter doctor -v
[✓] Flutter (Channel stable, 3.3.2, on macOS 12.6 21G115 darwin-x64, locale en-VN)
    • Flutter version 3.3.2 on channel stable at /Users/huynq/Documents/GitHub/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision e3c29ec00c (6 days ago), 2022-09-14 08:46:55 -0500
    • Engine revision a4ff2c53d8
    • Dart version 2.18.1
    • DevTools version 2.15.0

[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at /Users/huynq/Library/Android/sdk
    • Platform android-33, build-tools 31.0.0
    • ANDROID_HOME = /Users/huynq/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 13.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 13E113
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2021.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)

[✓] IntelliJ IDEA Community Edition (version 2022.1.1)
    • IntelliJ at /Users/huynq/Library/Application Support/JetBrains/Toolbox/apps/IDEA-C/ch-0/221.5591.52/IntelliJ IDEA CE.app
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] VS Code (version 1.71.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.48.0

[✓] Connected device (2 available)
    • macOS (desktop) • macos  • darwin-x64     • macOS 12.6 21G115 darwin-x64
    • Chrome (web)    • chrome • web-javascript • Google Chrome 105.0.5195.125

[✓] HTTP Host Availability
    • All required HTTP hosts are available

• No issues found!

[✓] Flutter (Channel master, 3.4.0-31.0.pre.18, on macOS 12.6 21G115 darwin-x64, locale en-VN)
    • Flutter version 3.4.0-31.0.pre.18 on channel master at /Users/huynq/Documents/GitHub/flutter_master
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision cc6eb4b644 (22 minutes ago), 2022-09-26 22:31:24 -0400
    • Engine revision b5edb3f1fa
    • Dart version 2.19.0 (build 2.19.0-241.0.dev)
    • DevTools version 2.17.0

[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at /Users/huynq/Library/Android/sdk
    • Platform android-33, build-tools 31.0.0
    • ANDROID_HOME = /Users/huynq/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.0)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14A309
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2021.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)

[✓] IntelliJ IDEA Community Edition (version 2022.1.1)
    • IntelliJ at /Users/huynq/Library/Application Support/JetBrains/Toolbox/apps/IDEA-C/ch-0/221.5591.52/IntelliJ IDEA CE.app
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] VS Code (version 1.71.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.48.0

[✓] Connected device (3 available)
    • SM T225 (mobile) • R9JT3004VRJ • android-arm64  • Android 12 (API 31)
    • macOS (desktop)  • macos       • darwin-x64     • macOS 12.6 21G115 darwin-x64
    • Chrome (web)     • chrome      • web-javascript • Google Chrome 105.0.5195.125

[✓] HTTP Host Availability
    • All required HTTP hosts are available

• No issues found!

Investigation
But I see that the issue is not only reproducible with ShellRoute, it's also happening with normal route, for example Named Route:

Sample code (Modified named_routes)
The original example: https://github.com/flutter/packages/blob/main/packages/go_router/example/lib/named_routes.dart
// Copyright 2013 The Flutter Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

// TODO(goderbauer): Refactor the examples to remove this ignore, https://github.com/flutter/flutter/issues/110210
// ignore_for_file: avoid_dynamic_calls

import 'dart:convert';

import 'package:flutter/material.dart';
import 'package:go_router/go_router.dart';

// This scenario demonstrates how to navigate using named locations instead of
// URLs.
//
// Instead of hardcoding the URI locations , you can also use the named
// locations. To use this API, give a unique name to each GoRoute. The name can
// then be used in context.namedLocation to be translate back to the actual URL
// location.

final Map<String, dynamic> _families = const JsonDecoder().convert('''
{
  "f1": {
    "name": "Doe",
    "people": {
      "p1": {
        "name": "Jane",
        "age": 23
      },
      "p2": {
        "name": "John",
        "age": 6
      }
    }
  },
  "f2": {
    "name": "Wong",
    "people": {
      "p1": {
        "name": "June",
        "age": 51
      },
      "p2": {
        "name": "Xin",
        "age": 44
      }
    }
  }
}
''');

void main() => runApp(App());

/// The main app.
class App extends StatelessWidget {
  /// Creates an [App].
  App({Key? key}) : super(key: key);

  /// The title of the app.
  static const String title = 'GoRouter Example: Named Routes';

  @override
  Widget build(BuildContext context) => MaterialApp.router(
        routeInformationProvider: _router.routeInformationProvider,
        routeInformationParser: _router.routeInformationParser,
        routerDelegate: _router.routerDelegate,
        title: title,
        debugShowCheckedModeBanner: false,
      );

  String logState(GoRouterState state) {
    return 'Current route: ${state.location}, params: ${state.params}, queryParams: ${state.queryParams}';
  }

  late final GoRouter _router = GoRouter(
    debugLogDiagnostics: true,
    routes: <GoRoute>[
      GoRoute(
        name: 'home',
        path: '/',
        builder: (BuildContext context, GoRouterState state) {
          print('root: ${logState(state)}');
          return const HomeScreen();
        },
        routes: <GoRoute>[
          GoRoute(
            name: 'family',
            path: 'family/:fid',
            builder: (BuildContext context, GoRouterState state) {
              print('family: ${logState(state)}');
              return FamilyScreen(fid: state.params['fid']!);
            },
            routes: <GoRoute>[
              GoRoute(
                name: 'person',
                path: 'person/:pid',
                builder: (BuildContext context, GoRouterState state) {
                  return PersonScreen(
                      fid: state.params['fid']!, pid: state.params['pid']!);
                },
              ),
            ],
          ),
        ],
      ),
    ],
  );
}

/// The home screen that shows a list of families.
class HomeScreen extends StatelessWidget {
  /// Creates a [HomeScreen].
  const HomeScreen({Key? key}) : super(key: key);

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: const Text(App.title),
      ),
      body: ListView(
        children: <Widget>[
          for (final String fid in _families.keys)
            ListTile(
              title: Text(_families[fid]['name']),
              onTap: () => context.go(context.namedLocation('family',
                  params: <String, String>{'fid': fid})),
            )
        ],
      ),
    );
  }
}

/// The screen that shows a list of persons in a family.
class FamilyScreen extends StatelessWidget {
  /// Creates a [FamilyScreen].
  const FamilyScreen({required this.fid, Key? key}) : super(key: key);

  /// The id family to display.
  final String fid;

  @override
  Widget build(BuildContext context) {
    final Map<String, dynamic> people =
        _families[fid]['people'] as Map<String, dynamic>;
    return Scaffold(
      appBar: AppBar(title: Text(_families[fid]['name'])),
      body: ListView(
        children: <Widget>[
          for (final String pid in people.keys)
            ListTile(
              title: Text(people[pid]['name']),
              onTap: () => context.go(context.namedLocation(
                'person',
                params: <String, String>{'fid': fid, 'pid': pid},
                queryParams: <String, String>{'qid': 'quid'},
              )),
            ),
        ],
      ),
    );
  }
}

/// The person screen.
class PersonScreen extends StatelessWidget {
  /// Creates a [PersonScreen].
  const PersonScreen({required this.fid, required this.pid, Key? key})
      : super(key: key);

  /// The id of family this person belong to.
  final String fid;

  /// The id of the person to be displayed.
  final String pid;

  @override
  Widget build(BuildContext context) {
    final Map<String, dynamic> family = _families[fid];
    final Map<String, dynamic> person = family['people'][pid];
    return Scaffold(
      appBar: AppBar(title: Text(person['name'])),
      body: Text(
          '${person['name']} ${family['name']} is ${person['age']} years old'),
    );
  }
}

Steps to reproduce:

Run above modified sample code on Web platform
Go to http://localhost:50658/#/family/f2?query=hello from browser address bar
Check the log from console

Result:

root: Current route: /?query=hello, params: {}, queryParams: {query: hello}
family: Current route: /family/f2?query=hello, params: {fid: f2}, queryParams: {query: hello}

Could you try and confirm the same behavior?

yes @huycozy it's the same problem with normal routes

@ahmednfwela thanks for your confirmation. Labeling this issue for further investigation.

@ahmednfwela thanks for your confirmation. But after reviewing the Current route again in both kind of routes, there is a difference:

Shell Route:

ShellRoute: Current route: /b/test?hello=ddd, params: {}
b: Current route: /b/test?hello=ddd, params: {bParam: test}

Named route:

root: Current route: /?query=hello, params: {}
family: Current route: /family/f2?query=hello, params: {fid: f2}

We can easily see that the Named Route seems to be working properly when its Current route doesn't contain params in this case.
So I will keep the issue's title as it is for further insight/opinion from the team. Thank you!


Suggest message revisions

This is a handful of edits and suggestions for user-facing messages:

Applies consistent formatting to the .jsonc file.
Adds a message about supporting DDEV more broadly, pointing to the catch-all CTA page on ddev.com.
Revises and shortens the sponsorship call to action, removing the bit about organizations since individuals contributing matters as well. (And if encouraging organization sponsorship is important, that should be addressed in more prominent places like the ddev.com page and the GitHub Sponsors description.)
Revises most messages to curl typographic quotes, consistently use backticks, capitalize proper nouns, improve brevity, and be slightly more specific about the nature of the FAQ.
Removes an iffy Star Wars reference that read strangely in an attempt to be more direct. (Wanted to try “Don’t forget to read the fabulous manual!” but that felt kind of cringey too, and maybe too easy to miss.)

Take or leave whatever you’d like!

You are awesome.


Design of the sdk generation process

Is your feature request related to a problem? Please describe.
It is not clear about how to generate the sdk once the generate client is hit.
It makes sense to define the process of generation and how to enable users to receive the built sdk

This is related to the work that was intended for #2409
The work was closed since we chose to move to having a VS Code integration


Bobby still not working

Describe the bug
Render distances above 32 chunks don't render further than 32 chunks.
Steps to reproduce

Install bobby
Set bobby to render anything beyond 32 chunks
suffer, as the mod doesn't work.

Logs
https://gist.github.com/Its-Just-Luci/e6949cad4b8a59f96d9e66f563579685
Additional context
I tried this in an install with connector, FFAPI, and bobby reforged. It does not work.

Additionally I marked this as a bug as the game loads fine, the mod just doesn't seem to be communicating with the renderer, so I wouldn't consider it an "incompatibility"

it was a configuration thing. Apparently needed to enable internal server in the config


Tips For Consumption In An Alpine-based Container Image?

Firstly, I'd like to echo the previously expressed sentiment that this is a very cool project, and I really appreciate it. I'm using it in a custom container image based on Atlantis' image; gitcache dramatically speeds up Atlantis' downloading of GitHub-sourced Terraform modules. Any speed improvements we get further encourages teams to use Atlantis for a communal, highly visible approach to IaC.
To get this deployed, however, I needed to take a fairly circuitous path. In my image build, I'm currently cloning the source, installing the dependencies into a Python virtual environment, then placing a simple wrapper git script early in the PATH that just invokes the Python application and passes along any arguments. This works, but is a bit more complicated than I expected.
I wanted to use one of the distributed Linux binaries, but the base image Atlantis distributes is based on Alpine. As far as I can tell, the gitcache binaries are all glibc-linked, and Alpine ships with musl. I attempted to leverage some readily available compatibility layers via apk (gcompat , libc6-compat), but there were issues with finding the linker lib. I also tried installing glibc (including this Alpine-ready variant), but in these cases, the gitcache binaries immediately seg faulted. Next, I tried building from source, and although I eventually produced a binary, when used as a git wrapper, it would complain about missing Python dependencies (_socket is one example, IIRC).
And so, I arrived at the source-based solution outlined above.
It looks like Atlantis does have Debian-based images that would probably be more amenable here, but I'm keen on using Alpine, since the vulnerability counts discovered by tools like Trivy are a good bit lower, in my experience.
Admittedly, I could do more investigating myself, but I did eventually find something that works for both x86 and ARM architectures. For posterity's sake, do you have any plans to distribute binaries that work in Alpine? And maybe with ARM? Failing that, any tips to help build a usable executable in these conditions?
Many thanks for your time and this awesome tool.

Thank you for the very clear and detailed issue description. As you already pointed out, the problem seems to be the non-glibc part, which means that you can run python scripts but not the binary created by the pyInstaller.
I did a quick search and found https://github.com/six8/pyinstaller-alpine as a promising project. It actually builds pyInstaller inside an Alpine docker image and uses that to generate the binary of the python code. If I've understand it correctly, that could work to generate binaries for Alpine.
So a first attempt will be to try to build a pyInstaller generated binary for Alpine 3.20.3 (that was the referenced version in the atlantis/Dockerfile on x86. Next step would be to put that into a github action to generate the binary whenever a new release is created.
Unfortunately the arm support on github actions is currently non-existing, but I've read it should support arm runners by end of this year/start of next year. That would be the easiest option. Another option would be to implement some qemu virtualization but I feel that is really slow and brittle.
So I'll try the build first locally and keep you informed how it is going. ;-)

Thanks for the lead! I tried this out quickly as a multi-stage image build, and was able to make it work. Obviously, a lot more care could be taken to match environments, but this did work as a very quick PoC:
FROM six8/pyinstaller-alpine-linux-arm64:alpine-3.6-pyinstaller-v3.4 AS build

RUN mkdir -p /gitcache \
  && apk add --no-cache build-base bash python3-dev \
  && git clone --recurse-submodules https://github.com/seeraven/gitcache.git /gitcache \
  && cd /gitcache \
  && make current-release \
  && mv /gitcache/releases/git* /gitcache/gitcache

FROM ghcr.io/runatlantis/atlantis:v0.30.0

COPY --from=build --chown=atlantis /gitcache/gitcache /home/atlantis/bin/gitcache
ENV PATH=/home/atlantis/bin:$PATH
RUN gitcache > /dev/null 2>&1 \
  && mv ~/bin/gitcache ~/bin/git

From the container, cloning this repository:
51d915d1462d:~$ git clone https://github.com/seeraven/gitcache.git
2024-11-22 19:51:07 Starting Initial clone of https://github.com/seeraven/gitcache.git into /home/atlantis/.gitcache/mirrors/github.com/seeraven/gitcache.
Cloning into bare repository '/home/atlantis/.gitcache/mirrors/github.com/seeraven/gitcache/git'...
remote: Enumerating objects: 1304, done.
remote: Counting objects: 100% (325/325), done.
remote: Compressing objects: 100% (102/102), done.
remote: Total 1304 (delta 216), reused 301 (delta 208), pack-reused 979 (from 1)
Receiving objects: 100% (1304/1304), 337.43 KiB | 2.64 MiB/s, done.
Resolving deltas: 100% (850/850), done.
2024-11-22 19:51:07 Initial clone of https://github.com/seeraven/gitcache.git into /home/atlantis/.gitcache/mirrors/github.com/seeraven/gitcache was successfully completed within 0.6 seconds.
2024-11-22 19:51:08 Starting LFS fetch of ref master from https://github.com/seeraven/gitcache.git into /home/atlantis/.gitcache/mirrors/github.com/seeraven/gitcache.
fetch: Fetching reference refs/heads/master
2024-11-22 19:51:08 LFS fetch of ref master from https://github.com/seeraven/gitcache.git into /home/atlantis/.gitcache/mirrors/github.com/seeraven/gitcache was successfully completed within 0.0 seconds.
2024-11-22 19:51:08 Starting Clone from mirror /home/atlantis/.gitcache/mirrors/github.com/seeraven/gitcache.
Cloning into 'gitcache'...
done.
2024-11-22 19:51:08 Clone from mirror /home/atlantis/.gitcache/mirrors/github.com/seeraven/gitcache was successfully completed within 0.0 seconds.
2024-11-22 19:51:08 Setting push URL to https://github.com/seeraven/gitcache.git and configure LFS.

That is really cool, thanks for testing! I guess I'll integrate the Alpine support into the make4py Makefile system similar to the way Ubuntu is supported. That would then allow to also run the functional tests in that environment.

I was able to generate Alpine based binaries using the github actions. Starting with the latest release v1.0.19 Alpine binaries are provided.
Can you check whether that works for you? I've done the integration tests also on Alpine, but you'll never know... ;-)

It seems it is not necessary any more to build pyInstaller on Alpine Linux manually like the six8/pyinstaller-alpine-linux-arm64 image does. Simply installing pyInstaller into a python-alpine container uses already the musl bootloader. I've integrated the support for using Alpine docker containers in make4py and it works with my toy example. The next step is to integrate it into the gitcache repository. I think tomorrow I can start working on the github actions so at least binaries for Alpine on x86_64 are generated. Just to confirm, I'm currently using the latest Alpine version 3.20. Would that work for you or do you require an older version?

Yup, current versions of Alpine are preferable. The only reason I used such an old version was that's the latest ARM-compatible image six8 had on Dockerhub :)

I was able to generate Alpine based binaries using the github actions. Starting with the latest release v1.0.19 Alpine binaries are provided. Can you check whether that works for you? I've done the integration tests also on Alpine, but you'll never know... ;-)

I've confirmed this works! Many thanks for the efforts.

Cool, thanks for testing. I'll close the issue then. There is another issue regarding arm support, I guess if that github arm runner nodes are available I'll simply generate everything for arm too.


Ivana adding author bios v02

Including @KetpuntoG 's for today's demo.

Thanks, @KetpuntoG ! Should be sorted now.


Cant build JS

tried following documentation @ richstrat.com but unable to build either JS
~ JsDev/fastOptJS
JsDev/fullOptJS
sbt gives:
[error] No such setting/task
running Sbt 1.8.2
had a looksie in build.sc (documentation mentioned build.sbt) but couldnt see the right terminology..

Just noticed this pretty late. Unless you think otherwise I think the DevJsApp can be dispensed with. Use
DiceLessJs
BC305Js
ZugJs
WW2Js
Y!783JS
PlanetsJs
These should be fastOpt and fullOpt html dev files for each. I'll update the docs in the morning. My next task was to rebuild the website, so as I can upload the new apps. DiceLess being the priority app now.


Properly fix handling of null name in AchievementUser

Description
Properly fix handling of null name in AchievementUser
Type of change

[x] Bug fix (non-breaking change which fixes an issue)

How to test
Add a new user to a course. Before that user first logs in, try to access the achievements page (as a staff user).
Checklist

[x] I have tested this code

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 1 (0.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.004%) to 30.926%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/commons/sagas/RequestsSaga.ts
0
1
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
-0.004%

Covered Lines:
3429

Relevant Lines:
10338

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

0 of 1 (0.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.004%) to 30.926%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/commons/sagas/RequestsSaga.ts
0
1
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
-0.004%

Covered Lines:
3429

Relevant Lines:
10338

💛  - Coveralls


Server example on home page

There is a following example on the home page:
from aiohttp import web

async def handle(request):
    name = request.match_info.get('name', "Anonymous")
    text = "Hello, " + name
    return web.Response(body=text.encode('utf-8'))

app = web.Application()
app.router.add_get('/{name}', handle)

web.run_app(app)

From my perspective this example has following problems:

There is no page at http://localhost:8080 (it's 404), this also means get('name', "Anonymous") is useless
When I visit http://locahost:8080/something it's served with Content-Type: application/octed-stream, so it's not user-friendly (page is downloaded rather than shown). Adding a content-type of plain or html should help.

I have aiohttp 1.0.1 if that matters.

Makes sense.


Is a connection token required for Tap-to-Pay?

It's clear from all Stripe docs that use of a physical device requires a connection token. However, is a connection token required to solely use Tap-to-Pay? Is a location/location ID required to solely use Tap-to-Pay?

However, is a connection token required to solely use Tap-to-Pay?

Yep, it is. The connection token is used to authenticate your merchant account, so the SDK can identify which account is making the requests.

Is a location/location ID required to solely use Tap-to-Pay?

Yep. All readers must be associated with a location. Locations are used to configure the readers, for example, via the configuration API.


AAT document changes

https://mendix.atlassian.net/browse/TW-2311

Hi @MXClyde, could you please review the PR and approve it?

Hi @MXClyde, I reviewed all feedback comments except for line 89. Do you mean to move OAuth authentication from _AddOn_CanChangeEnvironmentInQuery: to Admin role? I edited the content as per this draft document:

Hi @MXClyde, I reviewed all feedback comments except for line 89. Do you mean to move OAuth authentication from _AddOn_CanChangeEnvironmentInQuery: to Admin role? I edited the content as per this draft document:

Yes, I believe having it only under Admin would be correct, but IDX team should be able to verify and confirm

@Karuna-Mendix Its good to have in Admin


These changes fix the error displayed after the display of flows

Result:FAILURE JenkinsConsole:https://s3.ipdk.io/ovs/PR-83-1/index.html GitCommit:https://github.com/ipdk-io/ovs/commits/24c6cc22cb7ee755daaf834d0bc5fb2b6f6bf51f

Please edit to clarify the title of PR - not clear what you are referring to

Result:SUCCESS JenkinsConsole:https://s3.ipdk.io/ovs/PR-83-2/index.html GitCommit:https://github.com/ipdk-io/ovs/commits/24c6cc22cb7ee755daaf834d0bc5fb2b6f6bf51f

Result:SUCCESS JenkinsConsole:https://s3.ipdk.io/ovs/PR-83-3/index.html GitCommit:https://github.com/ipdk-io/ovs/commits/f8e9e8f66bb725c2aeffdda17d5f88f2c4be87d8

Result:SUCCESS JenkinsConsole:https://s3.ipdk.io/ovs/PR-83-4/index.html GitCommit:https://github.com/ipdk-io/ovs/commits/66cfb16c689067648309dd5194f129f5786f5d4f

Result:SUCCESS JenkinsConsole:https://s3.ipdk.io/ovs/PR-83-5/index.html GitCommit:https://github.com/ipdk-io/ovs/commits/b3338b24eebd53fc30ee0618486b781f1557d905

Result:SUCCESS JenkinsConsole:https://s3.ipdk.io/ovs/PR-83-6/index.html GitCommit:https://github.com/ipdk-io/ovs/commits/b3338b24eebd53fc30ee0618486b781f1557d905

Result:SUCCESS JenkinsConsole:https://s3.ipdk.io/ovs/PR-83-7/index.html GitCommit:https://github.com/ipdk-io/ovs/commits/dce65d40d06a5c97311867001c322825fd5f49d0

Result:SUCCESS JenkinsConsole:https://s3.ipdk.io/ovs/PR-83-8/index.html GitCommit:https://github.com/ipdk-io/ovs/commits/fc4dfa3e259a50e32f0d1484282327d98f6dab10

Result:SUCCESS JenkinsConsole:https://s3.ipdk.io/ovs/PR-83-9/index.html GitCommit:https://github.com/ipdk-io/ovs/commits/4f0dfc4d75f1c4870cf76de82d64a99ed1f79dfc

Result:SUCCESS JenkinsConsole:https://s3.ipdk.io/ovs/PR-83-10/index.html GitCommit:https://github.com/ipdk-io/ovs/commits/4f0dfc4d75f1c4870cf76de82d64a99ed1f79dfc

Result:SUCCESS JenkinsConsole:https://s3.ipdk.io/ovs/PR-83-11/index.html GitCommit:https://github.com/ipdk-io/ovs/commits/049d3158172cad0c466e64561b91ff9c0ea1afae

Result:SUCCESS JenkinsConsole:https://s3.ipdk.io/ovs/PR-83-12/index.html GitCommit:https://github.com/ipdk-io/ovs/commits/9cdece5f10d1d85f1e06e6da099503f2d30b873d


Unable to connect github.scm.corp.ebay.com

Description
I was trying to initiate a sample project
npm install -g create-react-native-app sample-app
Expected Behavior
I'd expect that skeleton project was created after run the command
Observed Behavior
I received this error
$ npm install -g create-react-native-app sample-app
npm ERR! Error while executing:
npm ERR! /usr/bin/git ls-remote -h -t git://github.scm.corp.ebay.com/cubejs-ebay/ebay-global-header-node.git
npm ERR!
npm ERR!
npm ERR! exited with error code: 128

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/gen/.npm/_logs/2018-02-02T13_01_50_144Z-debug.log

Than I ran that isolated command:
 /usr/bin/git ls-remote -h -t git://github.scm.corp.ebay.com/cubejs-ebay/ebay-global-header-node.git
and received that:
fatal: unable to connect to github.scm.corp.ebay.com:
github.scm.corp.ebay.com: Name or service not known

I also did it in a remote server, to make sure it was not net problem
Environment

npm ls react-native-scripts:

npm ls react-native:

/var/www
└── (empty)

npm ls expo:

/var/www
└── (empty)

node -v:

/var/www
└── (empty)

npm -v: v8.9.4
yarn --version: 1.3.2
watchman version: watchman: command not found

Operating system: Linux SPDEV1 4.13.0-26-generic #29~16.04.2-Ubuntu SMP Tue Jan 9 22:00:44 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Ignore it.
I was trying to install and create the project at the same time.


⚠ ClamAV has degraded performance

In d058f19, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 1418 ms

Resolved: ClamAV performance has improved in b92fc54.


SIGSEGV on DestroyJavaVM

Please provide a brief summary of the bug
We use OpenJDK 13 in our project and plenty of builtin VCPKG libraries, OS is Ubuntu 18.04 x64.
After upgrading VCPGK we started hitting crash SIGSEGV : Invalid access to storage (11) in JVM on DestroyJavaVM.
Additional upgrading to OpenJDK 17 does not change this behavior - JVM crashes in the same manner.
So, it seems new VCPGK has brought incompatible components or build options to our host binary.
No idea, how to look for a root cause. The difference, that reveals in JVM behavior on new VCPGK, is that JNI logs plenty messages like below before crashing. Maybe, it is related and can give a hint.
Warning: SIGSEGV handler
expected:libjvm.so+0x66ea40
  found:engtest+0x57131f0
Signal Handlers:
SIGSEGV:
[engtest+0x57131f0]
, sa_mask[0]=
00011111001000000000000000000000
, sa_flags=
SA_ONSTACK|SA_SIGINFO

SIGBUS:
[libjvm.so+0x66ea40]
, sa_mask[0]=
11111111011111111101111111111110
, sa_flags=
SA_RESTART|SA_SIGINFO
JNI:

...

Please provide steps to reproduce where possible
not possible as the context is pretty complicated
Expected Results
No crash
Actual Results
Crash
What Java Version are you using?
OpenJDK/JRE 13
What is your operating system and platform?
Ubuntu 18.04 x64
How did you install Java?
Unpack JDK distributive files
Did it work before?
It works if our binary, which loads libjvm.so, has been built using old VCPKG. It starts failing, if JDK is not changed, but the binary is re-built using new VCPKG.

Did you test with the latest update version?
Yes, it was tested with the latest JDK 17.0.7

Did you test with other Java versions?
yes, it was also tested with JDK 13.0.1 and JDK 14.0.1

Relevant log output
// DestroyJavaVM() called
Checked JNI functions are being used to validate JNI usage
Checked JNI functions are being used to validate JNI usage
Warning: SIGSEGV handler
expected:libjvm.so+0x66ea40
  found:engtest+0x57131f0
Signal Handlers:
SIGSEGV:
[engtest+0x57131f0]
, sa_mask[0]=
00011111001000000000000000000000
, sa_flags=
SA_ONSTACK|SA_SIGINFO

SIGBUS:
[libjvm.so+0x66ea40]
, sa_mask[0]=
11111111011111111101111111111110
, sa_flags=
SA_RESTART|SA_SIGINFO
JNI:

...

Segmentation fault

FYI - 13 and 14 are no longer in support, but 17.07 should work as such:
Your JVM is experiencing a segmentation fault (SIGSEGV). This usually occurs when your application tries to access a memory location it's not allowed to access or when it's trying to write to a read-only location.
Here are some ways to debug this:

Verify the correctness of your JNI code: Check your JNI code (the code that interacts with your native library). Make sure that you're not accessing or modifying any data that you're not supposed to.

Check the input and output of your native functions: Sometimes, if the data passed from the JVM to the native function (or vice versa) is not correct, it can cause issues.

Use a debugger: You can use a debugger to trace the execution of your program and see exactly where the SIGSEGV is happening. gdb is a commonly used debugger for C/C++ programs. Here is how you can use it with your Java program:

Start the JVM with the native library in gdb: gdb --args java -Djava.library.path=<path-to-native-library> <YourJavaClass>
Set gdb to catch segmentation faults with the command: catch throw
Run the program in gdb with the command: run

When your program hits a segmentation fault, gdb will pause and allow you to inspect the state of your program.

Look at the JVM crash logs: When JVM crashes due to a native error, it often dumps a hs_err_pid file in the application's working directory. This file contains a detailed crash log including the stack trace of the crashing thread. You might find useful information to help you debug the issue.

Use a memory checking tool: Tools like Valgrind can be helpful to check for memory leaks and other memory-related issues. Keep in mind though that using Valgrind with Java can be tricky because Java's memory management (garbage collection) can cause a lot of noise in Valgrind's output.

Recheck the Library Path: Make sure the JVM correctly finds the native library at the specified library path.

Remember, these types of errors can be tricky to debug because they can be caused by a number of different issues. The best approach is to proceed systematically, eliminating possible causes one by one.

The difference, that reveals in JVM behavior on new VCPGK, is that JNI logs plenty messages like below before crashing. Maybe, it is related and can give a hint.

Since vcpkg is using its own compile flags, a good start is a minimal, reproducible code example.  For example, there could be a stack alignment issue caused by an upstream change.
Are you using vcpkg to compile your own proprietary code, or are you leveraging someone else's package to talk to libjvm.so?
Furthemore, this question may be best to ask in the vcpkg community as they'll be more familiar with recent regressions to VCPKG.

Hi @tresf

Since vcpkg is using its own compile flags, a good start is a minimal, reproducible code example. For example, there could be a stack alignment issue caused by an upstream change.

Moreover, we use custom triplet based on clang-9, lld-9 and libc++. And it is not easy to prepare minimal example without full context.

Are  you using vcpkg to compile your own proprietary code, or are you leveraging someone else's package to talk to libjvm.so?

We load and call libjvm.so in our proprietary code.
Could you take a look, whether the following observations may be helpful:

JVM crashes in our unit tests and does not crash in our primary binary (both share the same static lib, which leverages libjvm.so).
JVM logs the warning about ambiguity in the addresses in the binaries libjvm.so and engtest, which is our unit tests binary.

Warning: SIGSEGV handler
expected:libjvm.so+0x66ea40
  found:engtest+0x57131f0

The unit tests are based on Catch2 framework provided by VCPKG.
Re-building the unit tests using new VCPKG and old Catch2 fixes the issue, JVM is stopping crashing.

So, upgrading Catch2 package causes the issue. Could it be possible, that Catch2, being a test framework, uses a kind of extended runtime error handling, or something else, which may conflict with JVM somehow?
I will request vcpkg and Catch2 for help. But the crash seems to happen inside JVM. The stack traces are not stable and varies from run to run. But in general, the stack frames contain many unresolved addresses around libjvm.so frames.
GNU gdb (Ubuntu 8.1.1-0ubuntu1) 8.1.1
. . .
Core was generated by `./build/engLib/engTest/engtest'.
Program terminated with signal SIGSEGV, Segmentation fault.
#0  0x00007f027a0f0a23 in ?? ()
[Current thread is 1 (Thread 0x7f02788e4700 (LWP 32386))]
(gdb) bt
#0  0x00007f027a0f0a23 in ?? ()
#1  0x00007f027a105df4 in ?? ()
#2  0x00007f02788e1c20 in ?? ()
#3  0x00007f02a738d9da in Unsafe_CompareAndSetInt () from /home/stepan/Projects/new_vcpkg/build/engLib/engTest/java/jre/lib/client/libjvm.so
#4  0x00007f027a0092c0 in ?? ()
#5  0x00007f019b9767b0 in ?? ()
#6  0x00007f019b818a08 in ?? ()
#7  0x00007f02788e1e10 in ?? ()
#8  0x00007f0288b74675 in ?? ()
#9  0x00007f02788e1e70 in ?? ()
#10 0x00007f0288b759b8 in ?? ()
#11 0x0000000000000000 in ?? ()

Does this give any hints?

Hi,
I checked the Catch2 bugs for others with this problem, but the combination of JVM + Catch2 may be too specific for it to have been reported.
I did stumble upon this in my searching, I'm not sure if it's relevant or helpful...
https://stackoverflow.com/questions/36428044/whats-the-difference-between-compareandset-and-weakcompareandset-in-atomicrefer

Warning: SIGSEGV handler
expected:libjvm.so+0x66ea40
  found:engtest+0x57131f0

Is this normal with engtest?  It almost sounds like a namespace conflict, but perhaps that's intended.

Is this normal with engtest?

Nope, this is not. JVM prints this before crash.

It almost sounds like a namespace conflict, but perhaps that's intended.

Do you mean a namespace conflict during compilation? No, this is run-timesnippet, not compilation one.

The runtime message says it expected one shared library but found another, hence asking about namespace conflicts.  It's obvious that it's a runtime error.

Root cause is found, that is known issue -JVM raises different failures to probe the system config, and Catch2 also intercepts them, and this causes the crash. Application of appropriate Catch2 build settings resolves the problem. So, in general, it makes sense to note to be careful with intercepting Linux signals in case loading and running JVM in the same process.

@stepanm-aparavi thank for the update.  Can you provide a link to the settings which resolved this?

Closing as per https://github.com/adoptium/adoptium-support/issues/838#issuecomment-1643569947

@tresf those settings are CATCH_CONFIG_POSIX_SIGNALS/CATCH_CONFIG_NO_POSIX_SIGNALS and CATCH_CONFIG_WINDOWS_SEH/CATCH_CONFIG_NO_WINDOWS_SEH for Windows as well.
https://github.com/catchorg/Catch2/blob/devel/docs/configuration.md


Contacts should not be unique

Describe the task
A clear and concise description of what the task is.
Acceptance Criteria

[ ] remove unique constraint from models
[ ] remove unique checks in the backend
[ ] find something else to check for uniqueness
[ ] third

Additional context

Add any other context about the task here.
Or here

@dleard , a PR reminded me of this, do you want to add anything?


Exception Handling in cpp

Description 📜
This documentation explains about how to handle different type of problem or exceptions during execution of a program.

Domain of Contribution 📊

[x ] C/CPP

/assign

Closing this issue as #2397 got merged


Scroll to top button

It is difficult and inconvinient to scroll back to the top again and again instead just add a back to top button

Hey , this issue is already solved by someone else . Changes are made in the source code . Its just that they haven't made the PR . Shall I make the PR to this issue ?? or you can close the issue .

yeah cool, I'll close the issue


New version: Microsoft.Teams.Exploration version <IP_ADDRESS>623

ARP entries are correct.\r\n\r\n#### Auto-updated by vedantmgoyal2009/winget-pkgs-automation in workflow run 602
Microsoft Reviewers: Open in CodeFlow

/AzurePipelines run


docs: Update README with new @silvermine scope (#50)

Ugh - I just saw the notification for your PR 😆 You win. I missed line 41 in my PR.


openttd: add some missing dependencies

Description of changes
taken from here: https://github.com/YellowOnion/OpenTTD-patches/commit/nix-shell

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

@YellowOnion I've rebase your PR and force-pushed since there was an openttd update on master since. Furthermore, there seems more dependencies have been missing according to the cmake configure phase. I've added those. Please review my changes.
harfbuzz doesn't seem to be used - at lease the configure phase doesn't complain about it. Do you have more information about that?

@fpletz sorry I thought I had my master branch up to date ( or it was extremely bad timing)
cmake complains about harfbuzz, it's part of the icu dependency. lzo support isn't really needed as it's for very old game versions (< v0.3), Documentation doesn't mention Allegro, so I'm somewhat unsure what it's for, and I suspect it's been replaced with SDL, I also have no idea about the other ones you added, I didn't see any complains from cmake here, maybe I'll have a look over it again, but maybe it's a red herring after adding pkg-config, since cmake has it's own detection system.
https://github.com/JGRennison/Upstream-OpenTTD/blob/master/COMPILING.md

Thanks for the insights. I've removed lzo again and agree with allegro. And :+1: for harfbuzz, that seems to the the errors finding "SSE" which is totally obvious. :eyes:
All other dependencies were added since the configure phase was complaining about it. Have another look and if you agree I'll squash the commits and merge. Thanks a lot!

@fpletz oh I think I know what's the difference, I'm running cmake directly in an impure shell, must be getting dependencies from the environment. and then I skimmed over it looking for Yellow errors when I ported to nixpkgs, I suspect dependencies dependencies don't really matter for compiling/linking, just at run time, can't hurt to include though.


Multi-sheet Excel export

With issue #431 : rework the file saving to allow for multi-sheet Excel file saving.

Will come in with https://github.com/cidgoh/DataHarmonizer/tree/dh2-431-export-as-json as I can reuse the same code.
@ddooley the "Save as..." vs the "Export to..." feature – should this only be supported in the "Save as..." feature?
I mention this because "Export to..." seems to be "owned" by the template repository.

"Export to" involves conversion of a given schema to another, so will always involve a menu of specific target formats to map/convert fields to - each usually saved as tab separated data.  That's why its different from "save as" which is not mapping fields, its just saving schema content with its own slot fields/names/structure.
Export to function currently often involves adding export.js script to fiddle with fields as they are transformed to target.
Indeed templates don't necessarily need an export option and in fact the "Export to" menu may list nothing if there is no export target predefined.

@kennethbruskiewicz I believe this is finished in DH2 beta?  But loading of them needs testing?

Resolved in upcoming DH2-i18n-rc1 branch.


[Bug][Server] The registered address of a server is the loopback address <IP_ADDRESS>

Bug description
The registered address of a server is the loopback address <IP_ADDRESS>
Expected behavior
Bug fixed.
Screenshots
If applicable, add screenshots to help explain your problem.

Which version of Dolphin Scheduler:
-[1.3.x]
Additional context
Add any other context about the problem here.

close by #5117. release 1.3.6


How to understand the meaning of output?

Hi Prof Li,
I am curious about how to read the results file. Since there are no header and no description in the manuscript.
For example,
srf-aln.bed
Hap1Chr10	0	598	prefix#circ1-7	3.212577819676956	39397427	7	1
Hap1Chr10	645	860	prefix#circ1-7	7.834101382488479	39397427	7	1
Hap1Chr10	1335	1762	prefix#circ1-7	7.04896161086285	39397427	7	1
Hap1Chr10	1808	2129	prefix#circ1-7	8.475765485111276	39397427	7	1

srf-aln.len
prefix#circ2-510	1557996	0.9188644989499729	0.37808279015137913	0.37846257261974675
prefix#circ8-3288	388183	0.3024941409303183	0.09420134052291071	0.10453409306005174
prefix#circ4-1170	384661	0.9344680648134569	0.09334664796470571	0.09614660331296503
prefix#circ1-7	263795	4.78851708218328	0.064015793126544	0.06402380131916773

Thanks in advance,
Lan

Need to update the document. Just briefly for now, the BED file gives: chr, start, end, SRF contig name, and mean percent identity (3.21 = 3.21%). You can ignore the rest of columns.
For the abundance estimate: SRF contig name, total length in bp, mean percent identity, filtered fraction and unfiltered fraction. If you specify -g (highly recommended!), you get the fraction of the whole genome. If you don't specify -g, you get the fraction of SatDNA.
I will keep this issue until I update README. Thanks!

Did the fraction have a unit or just the percentage of the whole genome? Take prefix#circ2-510 as an example, the fraction should be 0.37% or 37% if I use HiFi reads for estimation.


SSH connections are leaked during polling

ExecCommand fails to close the ssh client and leaks a connection for every command that is executed. During a failed deployment, the CPI eventually exhausted its file descriptors on the bosh director.

Sorry, there missed defer client.Close() right after ExecCommand , we will make sure to fix it in eCPI v2 release.

Fixed in the commit -> https://github.com/cloudfoundry/bosh-softlayer-cpi/commit/24b38f0b867ca292b36f8b23d2081d14f8381553
Closing this issue now.


fix: AuthFooter link

🔗 Linked issue

📚 Description

fix footer link to homepage

📝 Checklist

[ ] I have linked an issue or discussion.
[ ] I have updated the documentation accordingly.

Thank you for the PR! However, the goal here isn't to redirect to the '/' since there's a middleware that protects the route and will redirect to the login page. Instead, we want to redirect to the landing page. I've already taken care of the fix, but I really appreciate your effort!


Change List<AttributeFunction> to Map<ResourceLocation, AttributeFunction>

Before release, this needs to happen as there are issues with using this structure. It was used to bypass a config issue but it has concurrency issues and possible duplication problems.

It will be done on the 1.21 branch


fix: RHTAPBUGS-386: Skip go issue due: RHTAPBUGS-386

Description
TSIA
Issue ticket number and link
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist:

[ ] I have performed a self-review of my code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added meaningful description with JIRA/GitHub issue key(if applicable), for example HASSuiteDescribe("STONE-123456789 devfile source")
[ ] I have updated labels (if needed)

/test redhat-appstudio-e2e

Closing the issue. I cannot reproduce it anymore after: https://github.com/devfile-samples/devfile-sample-go-basic/pull/24
Thank you @johnmcollier !


Feature request: make rich text soft line breaks configurable with rich text features

Feature request: make rich text soft line breaks configurable with rich text features
Issue Summary
The rich text features used to turn on/off heading levels, list items, etc should also make it possible to toggle soft line breaks (\n in the editor converted to
 in the HTML output). At the moment line breaks are turned on and there is no way to disable them.
See https://github.com/wagtail/wagtail/issues/4266#issuecomment-364750160 and https://github.com/wagtail/wagtail/pull/4268#issuecomment-365994579 for more context.
The current line break definition is here:
https://github.com/wagtail/wagtail/blob/7841f54fe873d128d21a30cb19752c7081ec7b1a/client/src/components/Draftail/index.js#L90-L93
We discussed this at Wagtail Space (in the core team meeting and outside), and there was some consensus that this would be valuable, even if a breaking change.

It could also be useful to have an InlineRichTextField which would allow editors to add bold, italic and links but prevent them adding line breaks (br), or other blocks like like ul, ol, ...
And especially not wrap the output in a
 tag.

I can see how InlineRichTextField would relate to https://github.com/wagtail/rfcs/pull/60

I believe this would be RFC 46. I’ve made a draft attempt at implementing this (https://github.com/wagtail/wagtail/pull/7249), it worked well, just didn’t have the time to finish it.

I've tried adding a custom "soft" line break feature to Draftail but unfortunately I couldn't quite get it to behave properly.
I couldn't figure out how to render those line breaks in the admin area after they are saved. Specifically when it loads them from the database and renders them in the the rich text area in Wagtail's backend.

from wagtail import hooks
from wagtail.admin.rich_text.converters.html_to_contentstate import LineBreakHandler

@hooks.register('register_rich_text_features')
def register_br_feature(features):
    """
    Feature that injects
 tags in rich text area. Unfortunately currently it doesn't render the
 tag
    properly in the backend. The built-in line break handling or something else is overwriting it.
    This means that subsequent saves of rich text areas will remove any previously stored line breaks.
    TODO: Fix it
    """
    feature_name = 'br'
    type_ = 'br'
    tag = 'br'
    control = {
        'type': type_,
        'label': '↵',
        'description': 'Line break',
        # 'element': 'br', # This breaks react rich text rendering in the backend, TODO: Fix it
    }
    features.register_editor_plugin(
        'draftail', feature_name, draftail_features.BlockFeature(control)
    )
    db_conversion = {
        'from_database_format': {
            tag: LineBreakHandler(), # This is currently doing nothing, TODO: Fix it
        },
        'to_database_format': {
            'block_map': {type_: {"element": 'br'}},
        },
    }
    features.register_converter_rule('contentstate', feature_name, db_conversion)
    features.default_features.append('br')

Any idea how to fix this issue?


Rip out remaining machine upgrades

About the PR

https://youtu.be/F90Cw4l-8NY?si=mcqoMzBVi6ub38V8&t=62
basic machine part stuff still exists for construction because i have better things to do than rewriting 1k lines of yaml for machine boards. all the underlying code still technically exists for any forks who want to use it.
also removes the guidebook article because it's completely irrelevant.
Why / Balance

We already removed all the regular upgraded parts so the code was just dead weight not doing much. No reason to have examine text for nonfunctional objects.
Technical details

removes every subscription to UpgradeExamineEvent and RefreshPartsEvent. Removes some code in generators/power that hooked into upgrades (gross) and removed all the unique upgrade events.
Media

[x] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

uh quite a few things:

Removes UpgradeBatteryComponent, UpgradePowerDrawComponent, UpgradePowerSupplierComponent, UpgradePowerSupplyRampingComponent and their associated systems.
removes "base" value fields, machine part fields, and scaling fields from GasRecyclerComponent, PortableScrubberComponent, StasisBedComponent, SeedExtractorComponent, SolutionHeaterComponent, GravityGeneratorComponent, MicrowaveComponent, ReagentGrinderComponent, all the cloning machine components, and many other that are so irrelevant that i genuinely doubt anyone has changed them.

Changelog

no cl no fun

Average ss14 diff.


Update Alda logo to be consistent with alda.io

Hey Severák! I've added a link to your Alda web workspace on the install page.
Just a couple days or so ago, I made a little update to the Alda logo on the Alda site, so I figured it would be good to update it here too for consistency.

Oh. I did not noticed this is pull request.
I merged it, thanks for your contribution.


Updated userpage

Resolve all the conflicts of previous commit commit(306) .
Check is there is still any is issue let me know .

your package.json file is not updated to it's failing

I made it updated , Check now .

All done ,I apologies brother , I don't know what happen but I didn't remove any code , but still now it's working fine .


Husky Melodic Installation in Ubuntu 18.04

Hello, when I try to install husky vie apt-get, that's what I obtain:

When I instead use source ( cloned https://github.com/husky/husky.git into catkin_ws/src , then make catkin_make at catkin_ws), when I try to launch it with $ roslaunch husky_gazebo husky_empty_world.launch , I get the following error, and Husky cannot be built into Gazebo

I was following the steps from http://wiki.ros.org/husky_gazebo/Tutorials/Simulating Husky , and except for https://github.com/husky/husky.git , I didn't install anything. Do you know what the problem is?
Thanks,

There was, apparently, a problem with ROS, I don't really know. Here's what I've done:
From http://wiki.ros.org/melodic/Installation/Ubuntu , I apply the all steps again, which took a short time. Then, I was able to install via sudo apt-get install ros-melodic-husky-simulator .
One other thing is, I was always sourcing my workspace (catkin_ws), and try to launch husky afterwards, and keep getting the error. Now, instead of the workspace, I directly use command line
$ roslaunch husky_gazebo husky_empty_world.launch , and it works. Actually, I completely removed that workspace now.
I hope it helps someone as desperate as me!


feat(ci): use slim base for runtime container

Produces a smaller runtime Docker container image, does not appear to cause any issue in runtime

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Folding this into #1185


Update bag repartition docstring

repartition can be used both for reducing and increasing the number of partitions. The docstring only mentioned reducing the number of partitions
Fixes #5570

[x] Tests added / passed
[x] Passes black dask / flake8 dask

Thanks for docstring updates @Timost .  I see this is your first time contributing, welcome!

My pleasure ! Not sure why the CI failed the second time though.


Nginx conf not being configured, nginx gateway error. DigitalOcean, node.js app.

Hello there, i'm new to dokku and nginx. After some minor problems with SSH keys i was able to push local git master to remote dokku (DigotalOcean's droplet), dokku finished app's deployment succesfully, but i was unable to enter my app, getting nginx 504  gateway time-out or 502 bad gateway. I found nginx.conf in ~/etc/nginx/ and cat nginx.conf showed pretty suspicious results.
Here's my nginx.conf:
https://gist.github.com/MaxYari/07d4d0dbf37641e94596
And it seems that it was pretty much the same before i even pushed app.
And here's output of  dokku that I was able to copy from console:
https://gist.github.com/MaxYari/caef124c17dac7d56fd2
dokku version is 0.3.17
I'm deploying node.js app on express+mongoose+socket.io+some other stuff that anyway listens on the same server port:
var port = process.env.PORT || 4242;
server.listen(port);

As i understand dokku somehow determines app type and configures nginx.conf accordingly. Therefore here something gone wrong? Or am i need to manually configure nginx somehow?

Oops, just after posting it i figured out that nginx.conf for app is located in home/dokku/MyApp/nginx.conf and here its contains
server {
  listen      [::]:80;
  listen      80;
  server_name MyApp.MyApp.net ;
  location    / {
    proxy_pass  http://MyApp;
    proxy_http_version 1.1;
    proxy_set_header Upgrade $http_upgrade;
    proxy_set_header Connection upgrade;
    proxy_set_header Host $http_host;
    proxy_set_header X-Forwarded-Proto $scheme;
    proxy_set_header X-Forwarded-For $remote_addr;
    proxy_set_header X-Forwarded-Port $server_port;
    proxy_set_header X-Request-Start $msec;
  }
  include /home/dokku/MyApp/nginx.conf.d/*.conf;
}
upstream MyApp { server 172.*x*.0.9:5000; }

Which looks much more promising. Again i'm new to nginx, so wuld you mind to give me advise what to do next? Wat is those ports 80 (in listen) and 5000 (in upstream) and how must they corelate to port which my server in node code listens.
Also am i need to link this conf somewhere manually or am i need to just edit something? (gateway error's still here obviously)

Ok i figured out that it seel that i need to symlink this nginx.conf in home/dokku/MyApp/nginx.conf to  folder to ~/etc/nginx/sites-enabled, done it, called it just MyApp.Another problem occured, wjile trying to reload nginx with nginx -s reload i recieved [emerg] duplicate upstream "MyApp" in /etc/nginx/sites-enabled/MyApp:18 the reson of which i can not quite grasp at this moment.

I'm having this issue with a basic Rails 4 application both on Google Compute Engine as well as DigitalOcean. Any suggestions?

@nickdb93 can you file a different issue? You just commented on a several month old issue without any information tying you to this one (which was user error).


Support for Intel oneAPI missing

I'm reposting the issue from https://github.com/bfgroup/b2/issues/413 here because the lack of response.
Environment and version details

Operating System+version: Arch Linux
Compiler+version: Intel oneAPI 2024.2.1
Shell: zsh
B2 Version: B2 5.2.1 (OS=LINUX, jobs=8)
B2 Configuration: Output of b2 --debug-configuration in your project.
not added because it uses gcc.

Brief problem description
Options defined in https://github.com/bfgroup/b2/blob/3c0f5630157c3db1025b54c2f6da25cf234b8e20/src/tools/intel-linux.jam are incompatible with LLVM-based Intel compilers:

-ip is not supported anymore

https://github.com/bfgroup/b2/blob/3c0f5630157c3db1025b54c2f6da25cf234b8e20/src/tools/intel-linux.jam#L216

-use-pch should be -include-pch or -pch-use

https://github.com/bfgroup/b2/blob/3c0f5630157c3db1025b54c2f6da25cf234b8e20/src/tools/intel-linux.jam#L262
https://github.com/bfgroup/b2/blob/3c0f5630157c3db1025b54c2f6da25cf234b8e20/src/tools/intel-linux.jam#L273

pch-create should be -Xclang -emit-pch -o (https://www.intel.com/content/www/us/en/developer/articles/technical/building-boost-with-oneapi.html)

https://github.com/bfgroup/b2/blob/3c0f5630157c3db1025b54c2f6da25cf234b8e20/src/tools/intel-linux.jam#L293
https://github.com/bfgroup/b2/blob/3c0f5630157c3db1025b54c2f6da25cf234b8e20/src/tools/intel-linux.jam#L303

the Fortran compiler is called ifx, not ifort

https://github.com/bfgroup/b2/blob/3c0f5630157c3db1025b54c2f6da25cf234b8e20/src/tools/intel-linux.jam#L298

Steps to reproduce the issue
Install Boost with
./bootstrap.sh --prefix=/tmp/boost
./b2 install --without-python --without-graph_parallel --without-mpi cxxstd=17  toolset=intel-linux  link=shared address-model=64 architecture=x86 runtime-link=shared

Actual behavior summary
The compiler gives warnings and errors and installation of a few files fails.
A few example errors are shown
intel-linux.compile.c++ bin.v2/libs/log/build/intel-linux-linux/release/x86_64/cxxstd-17-iso/threading-multi/visibility-hidden/trivial.o
icpx: command line warning #10430: Unsupported command line options encountered
These options as listed are not supported.
For more information, use '-qnextgen-diag'.
option list:
	-ip
	-wd177,780,2196,1782,193,304,981,1418,411,734,279

...skipped <pbin.v2/libs/math/build/intel-linux-linux/release/x86_64/cxxstd-17-iso/threading-multi/visibility-hidden>acoshl.o for lack of <pbin.v2/libs/math/build/intel-linux-linux/release/x86_64/cxxstd-17-iso/threading-multi/visibility-hidden>pch.pchi...

...failed updating 1 target...
   intel-linux.compile.c++.pch bin.v2/libs/math/build/intel-linux-linux/release/x86_64/cxxstd-17-iso/threading-multi/visibility-hidden/pch.pchi

Expected behavior summary
b2 should support the most recent Intel C++ compiler (icpx)

-ip is not supported anymore
-use-pch should be -include-pch or -pch-use
pch-create should be -Xclang -emit-pch -o

These have been fixed in spack (patch). I've been meaning to push them upstream, but I guess now is a good time. I can submit a PR here, unless you're working on one.

the Fortran compiler is called ifx, not ifort

Huh. I don't know why that hasn't been encountered in spack builds. As of 4e62a3e275 , the ony Fortran file I can find is ./numeric/odeint/performance/fortran_lorenz.f90. Clearly, it's needed. I'll add that to my TODO for spack.

Huh. I don't know why that hasn't been encountered in spack builds. As of https://github.com/boostorg/boost/commit/4e62a3e2751916960747954484d2e0be5957b225 , the ony Fortran file I can find is ./numeric/odeint/performance/fortran_lorenz.f90. Clearly, it's needed. I'll add that to my TODO for spack.

ifort exists in parallel and was the preferred compiler in the first oneAPI releases. But now, ifx is the default and iforts removal has been scheduled.

I can submit a PR here, unless you're working on one.

I can do that, but would mainly use code from your spack package. Let me know if that would be ok.

Huh. I don't know why that hasn't been encountered in spack builds. As of 4e62a3e , the ony Fortran file I can find is ./numeric/odeint/performance/fortran_lorenz.f90. Clearly, it's needed. I'll add that to my TODO for spack.

ifort exists in parallel and was the preferred compiler in the first oneAPI releases. But now, ifx is the default and iforts removal has been scheduled.

Ah, ok. That would explain it. Do you happen to know what version added ifx?

I can submit a PR here, unless you're working on one.

I can do that, but would mainly use code from your spack package. Let me know if that would be ok.

Of course! Let me know if you have any other questions about the patches there (there are lots).

Ah, ok. That would explain it. Do you happen to know what version added ifx?

It was there since the release of oneAPI (https://fortran-lang.discourse.group/t/intel-releases-oneapi-toolkit-free-fortran-2018/471). It reached feature parity with the old compiler in the 2023.0.0 release: https://fortran-lang.discourse.group/t/intel-fortran-2023-launch/4929

Closing, because https://github.com/boostorg/build/issues/739 seems to be the right place for this issue


Warning message for vdWHandler mentions BondHandler

Description
This warning is a bit surprising: https://github.com/openforcefield/openff-interchange/blob/8c12453ddf1738d7aee404acd5c34b61d42e6873/openff/interchange/smirnoff/_nonbonded.py#L107
/lila/home/lilywang/micromamba/envs/fb-195-tk-014-py310/lib/python3.10/site-packages/openff/interchange/smirnoff/_create.py:237: UserWarning: Automatically down-converting BondHandler from version 0.4 to 0.3. In the future, this down-conversion will not happen and verison 0.3 will not be supported.
  _downconvert_vdw_handler(force_field["vdW"])

Should that be the vdwHandler instead?
Also, a small typo -- verison should be version: https://github.com/openforcefield/openff-interchange/blob/8c12453ddf1738d7aee404acd5c34b61d42e6873/openff/interchange/smirnoff/_nonbonded.py#L108

Thanks for reporting, I'm bad at letting these slip in without reviews


Simplify AbstractSeekableByteChannel by right-sizing the provided byteBuffer

This builds on #393 by also right-sizing the provided byteBuffer to avoid reading more than we should, and abstracting this away from implementations. Now, the provided byteBuffer to implement against will have the right amount of remaining bytes to read into based on its position and capacity.
This PR is blocked until #393 is merged.

LGTM

Thanks - that was quick! I've pushed up an amendment to the way the new limit is calculated based on advice here, but otherwise I'm not anticipating making any further changes at my end unless there's review comments.


Fixing the docker build when Morpheus is a submodule

Fixes #1870 by ensuring that the root directory is mounted instead of just the Morpheus repo.

/merge


[move-only] When storing a trivial field of a borrowed parameter, treat the store as a trivial use.

rdar://111354827

@swift-ci test


IJulia build fails when g++ not installed?

Whenever I have installed "IJulia" on Linux, it's build fails every time and I could see in the error that it couldn't find the necessary compilers. Installing g++ resolves that (gcc was already installed).
Is that a known issue?
Can we have in in the documentation so that people don't face any such problem in future on Linux?

Probably the build failure is for one of IJulia's dependencies, e.g. Nettle?

yes actually, it is for many dependencies for IJulia.


Helpers update in the artisan make:theme command

When I use the artisan make:theme command, i get the error of undefined variable for str_slug and camel_case helpers.
I am using Laravel 6.
themes/src/Console/GenerateTheme.php

I've proposed a pull request with the related fixes. #88


Introduce wasm-opt for the build phase

This is beneficial step to create an extremely minimum wasm binary size but I suspect this step might not required for a general use case.
From some experiments to develop this repository, at least for Rust -> wasm, I think enabling LTO would reduce more  binary size than wasm-opt.
Here is benchmark results.

Environments

Rust 1.61
wasm-opt version 108
Source code  is https://github.com/tetsuharuohzeki/fastly-compute-at-edge-template/commit/b869e9f94c33efde48d0a78ed3234803d4f30c74

Result

without wasm-opt
wasm-opt

Without LTO
6MB
5.1MB

LTO = fat
1.6MB
1.4MB

LTO = thin
2.3MB
2MB

Of course, these results would change if toolchains are different or the application is different. But these results shows nice examples.
By these results, I think we can say following thumbs:

LTO improves the output wasm binary size dramatically even if whether ThinLTO or FatLTO. It would be nice to attempt to turn on LTO at first if we would like to reduce the output binary size with Rust.

I also guess we can apply this rule to other languages backed by LLVM.

FatLTO reduce the binary size more than ThinLTO. But FatLTO have a trade-off with increasing compiling time in generally.

I think this choice is the project dependent. Even though, ThinLTO still reduce the output size dramatically. I think ThinLTO would show an enough result for almost projects.

wasm-opt is useful to tune the output binary size extremely. But it improves only a bit by comparing with LTO and this size reduction might not be a matter.

Rather, integrating wasm-opt to CI requires to install binaryen. This effort might not show good cost performance comparing with maintaining your CI.


Heap overflow in power set creation ES 1.7.4

I have created a test where the creation of the power set for shard sorting causes a heap overflow.
I believe this assertion here is invalid ShardSorter.java Line 218. https://github.com/babsher/elasticsearch-hadoop/blob/master/mr/src/main/java/org/elasticsearch/hadoop/rest/ShardSorter.java#L218
See my fork https://github.com/babsher/elasticsearch-hadoop

Can be more specific on what is wrong with the aforementioned assert? It is too high which leads to the heap overflow (initially I started with 24 but as that is not that uncommon, moved to 30).

So if you look at my test the size is exactly 30 but I still have a heap overflow. In addition this is only querying 2 indices and on our cluster. We had hoped to query at least 30 indices.

The only quick workaround I can give for the moment is to stop using aliases. The issue (as you can tell by the ShardSorter comment) is that when dealing with an alias, there's no way for the client to easily select just a certain shard that belongs only to an index without having to redo the filtering and such from the backing alias (which is just replicating ES functionality).
Potentially ShardSorter can be improved by using a more memory efficient PowerSet.

From RestRepository.java Line 349 it seems like any multi-index query has the shard sorter run not just aliased queries. Our query hits multiple indices and has a , but I am sure there are no aliases in it.
Is the ShardSorter also needed to query multiple indices?

Multi indices tend to have the same issue though to a lesser degree - by requesting data from all indices at once instead of separate indices, one ends up with slightly different semantics. Breaking down the multi index into smaller sub-indices leads to subjobs which don't work all that well.
I'll review the issue and see whether it would be possible to perform the set lookup in a slower manner but without storing the data as a set.

Our data is a time series log so we have no choice but to use multiple indices. For now I am testing querying one index at a time and then joining the results into a single RDD.

Which is far from ideal, I know...

Maybe instead of generating the entire set at once the code could just iterate over the set?

Created a pull request that  fixes the issue.

@babsher Thanks for the PR - however for it to be accepted, the CLA needs to be signed.
Thanks,

I signed the CLA

The CLA check seems to fail for some reason. What email/username did you use for the CLA signup?
One more thing, your PR relies on JDK 8 while ES-Hadoop is still based on JDK 6/7.

I used my username babsher could it be because my email is hidden on github?

The CLA checks the email/user used in the commits against the user / email that signs the CLA. If the email is hidden then likely the checksum fails.
However the fact that you commented that you signed it, should be enough assuming you don't want to try it again and make your email public.

CLA checks pass now.

I've merged the PR into master. Thanks for the fix, providing issues and your patience.
Long term this should be fixed through elastic/elasticsearch#13494.
Basically currently any set larger than 31 is not supported as it yields way too many combinations (higher then (Integer.MAX_VALUE).

@costin I am digging further into the shard sorter and I am trying to understand why it tries to decrease the number of nodes used. I think in the case where you are reading a large number of shards or indices you would want to use more nodes and not less.
Can you help me understand why it needs to find the overlapping shards? Feel free to email me at<EMAIL_ADDRESS>

See https://github.com/elastic/elasticsearch-hadoop/issues/363


Drop PathSource TODO in GitSource

This effort was started in de6944798cf2940b91c742b8d6cd4294ea28f76a,
and looks (to me) to be resolved at this point.

@bors r+

:pushpin: Commit ab16c77 has been approved by matklad

:hourglass: Testing commit ab16c7750c1dcbf518bf6a153aea6c7100e53d1a with merge 2912a58de268e165873f42b06fcefeb3fb0b3fa9...

:sunny: Test successful - status-appveyor, status-travis
Approved by: matklad
Pushing 2912a58de268e165873f42b06fcefeb3fb0b3fa9 to master...


docker: Update distroless image -> d65ac1a

Fix #21353
Signed-off-by: Ryan Northey<EMAIL_ADDRESS>Commit Message:
From https://console.cloud.google.com/gcr/images/distroless/global/base-debian11@sha256:d65ac1a65a4d82a48ebd0a22aea2acdd95d7abeeda245dfee932ec0018c781f4/details
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

cc @lizan not sure why dependabot is not auto updating this - here is the dependabot logs:
https://github.com/envoyproxy/envoy/network/updates/376760944
there is a lot of 404s - that could be its normal operation, or may be the reason its not finding an update

proxy | 2022/05/26 17:13:49 [000] 404 https://gcr.io:443/v2/distroless/base-debian11/manifests/sha256-d65ac1a65a4d82a48ebd0a22aea2acdd95d7abeeda245dfee932ec0018c781f4.sig

looks like the reason i think


request: allow compressed delimited text files as remote URL data sources

As I posted in #1673, "The IPT can import uncompressed delimited text files directly from a URL"
But the info icon next to Source data header says "You can upload delimited text files either directly or compressed (zip or gzip)" ... (with some issues).

So, if compressed files are submitted using the upload button, the IPT can uncompress them.
But if a file is served from a remote URL, it must be uncompressed.

Why that difference?
If the IPT is able to uncompress uploaded files, why not allowing it to do the same for those files served from remote URLs?
That would save a lot of space in servers.
Thanks
@abubelinha

@abubelinha Thank you for contacting us. We're already planning to do that, see #1632 . Closing this


Force recalculation

First of all, very nice work, I like your virtual-list, it's very usefull and super efficient.
I just has a suggestion: have a way to force the rendering of the list, even if we don't scroll.
I'm using your list to show a big list of complex components. On each of this component I have a check box (to be able to select it and make later an action). Outside of the virtual-list, I have "select-all" button. When I click on it my items array is updated and all the items are marked as checked, but the Virtualist is not updated, because I didn't scroll it yet.
Is there a way to improve this?
Thanks

Ok, sorry for this question, it's already implemented.
For those who asked themselves  the same question, you have to do this :
<VirtualList ref="list" ... />

this.refs.list.forceUpdate();

Hey @flccrakers, thanks for the kind words, and glad to hear you found a solution!  You might also find some useful stuff in the example implementation here https://github.com/developerdizzle/react-virtual-list/blob/gh-pages/App.jsx.  I didn't have to use forceUpdate there because I'm changing the component's properties.  Basically changing the state or props will make the component recalculate and update.


Add Cask headers to python files

This adds the Cask headers to all python files in this project.

Do these files need shebangs and encodings at the top? This is what is at the top of our executable python files for docs...
#!/usr/bin/env python
# -*- coding: utf-8 -*-

One minor comment, otherwise LGTM.

These files are not executed directly, so they do not need shebangs.


Option to open external links with in-app browser

i.e. create a BrowserWindow for loading external links.

@egoist this issue is finished?

Do you need this feature? I haven't seen a use case for this 😄

That was my question when see this issue, I forget this then 👍

So I'm closing this for now, thanks for reminding me anyways!


Update account-permissions-and-security-settings-in-sharepoint-server…

…-2016.md
Added SP 2013 as this article also applies except where noted.

Update for #1734

@UmrG please take a look and see if this meets your expectations or if I missed something. I mostly removed explicit references to 2016/2019 as it also applies to 2013.

@JohanFreelancer9 Copy editing is needed for this PR. Thanks.


Changed link to aleph.io

I think this is where that link is meant to go? Re: Issue #243

Thanks!


[BugFix] SyncDataCollector init when device and env_device are different

Description
In the init method of the SyncDataCollector class, a small number of steps is taken with the policy to determine the relevant keys of the output TensorDict. When the policy device and the environment device are different, that can raise a RuntimeError since the input provided to the policy is located in the environment device.
This PR only makes sure that the TensorDict provided to the policy is in the policy device, and then moves the output TensorDict to the environment device again.
Types of changes
What types of changes does your code introduce? Remove all that do not apply:

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds core functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Documentation (update in the documentation)
[ ] Example (update in the folder of examples)

Checklist
Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

[x] I have read the CONTRIBUTION guide (required)
[ ] My change requires a change to the documentation.
[ ] I have updated the tests accordingly (required for a bug fix or a new feature).
[ ] I have updated the documentation accordingly.

Added tests for all device/passing_device combinations for SyncDataCollector, MultiSyncDataCollector and MultiaSyncDataCollector.
I noticed that for MultiSyncDataCollector, the output batch TensorDict has its device attribute set to None.
I think the problem can be in the TensorDict.cat method, which returns a TensorDict whose "next" TensorDict has device set to None. As a sanity check, I added a line of code to make sure the MultiSyncDataCollector output TensorDict is cast to the correct device.

@albertbou92 interesting

I noticed that for MultiSyncDataCollector, the yielded TensorDicts had its device attribute set to None.

Does this happen when the passing devices match too? Or just when there's more than one?
torch.cat should conserve the device (since we're sure that all device match). If it doesn't it's a bug. When the devices don't match, we first cast things to cpu before calling cat. It's definitely not ultra fast so we may want to parametrise that feature.

which returns a TensorDict whose "next" TensorDict has device set to None.
You mean that the tensordict has a device but the nested tensordict doesn't? Weird...

@albertbou92 interesting

I noticed that for MultiSyncDataCollector, the yielded TensorDicts had its device attribute set to None.

Does this happen when the passing devices match too? Or just when there's more than one? torch.cat should conserve the device (since we're sure that all device match). If it doesn't it's a bug. When the devices don't match, we first cast things to cpu before calling cat. It's definitely not ultra fast so we may want to parametrise that feature.

which returns a TensorDict whose "next" TensorDict has device set to None.
You mean that the tensordict has a device but the nested tensordict doesn't? Weird...

Does this happen when the passing devices match too?

Yes it happens for all device combinations

You mean that the tensordict has a device but the nested tensordict doesn't? Weird...

exactly

You mean that the tensordict has a device but the nested tensordict doesn't? Weird...

exactly

Ok then it's a tensordict bug, I'll have a look into it.

Should I remove the line of code to make sure the MultiSyncDataCollector yielded TensorDicts are cast to the correct device.
We could keep it as a sanity check, won't add overhead if the TensorDicts is already in the correct device.

Should I remove the line of code that makes sure the MultiSyncDataCollector yielded TensorDicts are cast to the correct device.
We could keep it as a sanity check, won't add overhead if the TensorDicts is already in the correct device.

Which line of code are we talking about?
By the way: can you check if the device bug with nested tensordicts is still present?

the device bug with nested TensorDicts seems to be fixed now!
In my code I added to the MultiSyncDataCollector iterator method a out_buffer = out_buffer.to(prev_device) after concatenating all different dicts to make sure the yielded TensorDict was places to the passing_device. Now that the cat method is fixed might be unnecessary.
I can remove it or we can either keep as a sanity check.

If it's not necessary I would remove it. Those things take little time but they quickly pile up to a consequent overhead.

ok, removed that checking line.
Now the PR just fixed the bug in  SyncDataCollector when policy device and passing_device are different and adds tests to make sure all collectors work with all device combinations.