[FIX] Remove ToSchema from RefundAggregateResponse and exclude it from OpenAPI documentation

Feature Description
The RefundAggregateResponse type used by the /refunds/aggregate API is currently annotated with ToSchema, which generates OpenAPI schema documentation for it. However, since this API is internal and should not be exposed to external users, the schema should not be generated or included in the OpenAPI documentation.
Current Behavior:

The RefundAggregateResponse struct is annotated with ToSchema, which automatically generates OpenAPI documentation.
This results in the exposure of internal API details that should remain hidden from external consumers.

Expected Behavior:

Remove the ToSchema derive macro from the RefundAggregateResponse struct.
Ensure that this struct and its associated API are excluded from OpenAPI documentation generation.

Possible Implementation
The Api refunds/aggregate returns RefundAggregateResponse
The following code should be modified to remove ToSchema and update the OpenAPI documentation accordingly:
#[derive(Clone, Debug, serde::Serialize, ToSchema)]
pub struct RefundAggregateResponse {
    /// The list of refund status with their count
    pub status_with_count: HashMap<enums::RefundStatus, i64>,
}

Tasks:

Remove the ToSchema derive macro from the RefundAggregateResponse struct.
Remove any references to RefundAggregateResponse from openapi.rs to ensure it is not documented.
Test to verify that this type is no longer included in the OpenAPI schema.

Additional Context:
Since the /refunds/aggregate API is for internal use only, removing the OpenAPI schema ensures that this internal API remains undocumented for merchants.
Have you spent some time checking if this feature request has been raised before?

[X] I checked and didn't find a similar issue

Submission Process:

Ask the maintainers for assignment of the issue, you can request for assignment by commenting on the issue itself.
Once assigned, submit a pull request (PR).
Maintainers will review and provide feedback, if any.
Maintainers can unassign issues due to inactivity, read more here.

Refer here for Terms and conditions for the contest.

Hello! Could you assign this to me? @apoorvdixit88

Hey @IshuSinghSE Kindly don't spam the issues with assignment request!

Hey @IshuSinghSE Kindly don't spam the issues with assignment request!

Okay

Thanks for understanding!

Hi, I can help on this issue after wrapping up #6117

Sure @qstommyshu , looking forward to it.

Hi, I would like to work on this issue

Assigned another issue to you, Thanks for your interest!

Hi @gorakhnathy7,
Would you mind assigning this issue to me? I have a PR #6293 is just waiting to be merged, and I already know how to implement #6111. I just need to wait for #6293 to be merged to start with #6111. Meanwhile I can work on this issue in parallel.
I want to get at least 4 PR submitted within this month.

@qstommyshu assigning this issue to you, please open a PR for this, in the mean time your other PRs can get merged.

Thanks!


⚠ Halloluise has degraded performance

In b254f69, Halloluise (https://halloluise.de) experienced degraded performance:

HTTP code: 200
Response time: 3541 ms

Resolved: Halloluise performance has improved in 8d3390b.


Project and job/model/runtime/dataset scope boundary issues

Describe the bug
when i create a job in project demo1,but the model/dataset/runtime can from other project, like project demo2.
is this a normal scope？
Expected behavior

https://github.com/star-whale/starwhale/pull/574


Cannot create property '$key' on boolean 'true'

Description
When using <firebase-query> with data structure like
{
$id: true
}

it throws an error
Cannot create property '$key' on boolean 'true'
Steps to reproduce
Create data like
{
    "notes-by-user": {
        "userId1": {
            "noteId1": true,
            "noteId2": true,
        }
    }
}

and <firebase-query> element like
<firebase-query
   path="/notes-by-user/userId1"
   data="{{notes}}">
</firebase-query>

Hi, thanks for reporting. Using <firebase-query> on locations where all of the children have primitive (boolean, string, number) values is not supported. Please consider nesting these values in objects.

But https://firebase.google.com/docs/database/web/structure-data#fanout actually give the above as an example.

@cdata this limitation pretty much kills doing fast lookup on the key. In the example I pasted there is no way one could do groups/[[an_id]]. Now one has to get the entire collection (groups) and iterate over it, it doesn't seem to scale TBH. Maybe you have a better suggestion.

Hi @cdata, I also stumbled  upon this issue today. I think this limitation is a real concern and the issue shouldn't be closed without fixing, or what do you think?

I think so. this is a serious limitation. Firebase team should open the issue again.

As workaround you can use firebase-document instead of firebase-query.
And then use a new element to convert your object into an array, like this:
<firebase-document       app-name="{{firebaseApp}}"       path="[[locAutoresD]]"       data="{{autoresAsociadosDocument}}"     ></firebase-document>     <object-to-array       object="[[autoresAsociadosDocument]]"       array="{{autoresAsociados}}"     ></object-to-array>
The element "object-to-array" should be like this:
`

`

We've also structured our firebase this way according with the Firebase docs' explanation that you should work in the way @ExWei showed. I found out this didn't work when I noticed that firebase-query misses a orderByValue option. Our whole platform is built on this design pattern, so upgrading from firebase-element to polymerfire is very dificult for us.


Pipeline doesn't process all BAMs in input directory

Ran the following command to process 18 BAMs in the input directory:
NXF_VER=20.07.1 /home/shared/nextflow run epidiverse/snp \
-c nextflow-docker_permissions.config \
-profile docker \
--input /home/shared/8TB_HDD_01/sam/data/O_lurida/BSseq/bams/070322-olymerge-snp/ \
--reference /home/shared/8TB_HDD_01/sam/data/O_lurida/genomes/Olurida_v081-mergecat98.fa

For some reason, the pipeline only processed 10 of the 18 and the selection of which files were selected seems random. For example, here is the list of files processed:
zr1394_3_s456_trimmed_bismark_bt2.deduplicated.bam
zr1394_6_s456_trimmed_bismark_bt2.deduplicated.bam
zr1394_7_s456_trimmed_bismark_bt2.deduplicated.bam
zr1394_8_s456_trimmed_bismark_bt2.deduplicated.bam
zr1394_9_s456_trimmed_bismark_bt2.deduplicated.bam
zr1394_10_s456_trimmed_bismark_bt2.deduplicated.bam
zr1394_11_s456_trimmed_bismark_bt2.deduplicated.bam
zr1394_15_s456_trimmed_bismark_bt2.deduplicated.bam
zr1394_16_s456_trimmed_bismark_bt2.deduplicated.bam
zr1394_18_s456_trimmed_bismark_bt2.deduplicated.bam

These were numbered sequentially (zr1394_{1..18}_s456_trimmed_bismark_bt2.deduplicated.bam).
Any idea on what might be happening here and/or where I can look in the logs to see why some were analyzed while others were skipped?

Hi there, thanks for opening these issues for the various pipelines in the Epidiverse toolkit! It's always good to hear from people, particularly outside the network, who are using the pipelines. Just FYI- I am currently out on vacation, but expect to be back next week and will do my best to get to all your open tickets as soon as possible.
In regards to this issue specifically, I think it's probably due to the --take parameter which may be undocumented in this pipeline. The idea is to not inadvertently fill up all the available disk space on the system by creating huge work directories, so by default it is limited to 10 samples (I think). You can increase the number of samples with this parameter if you have plenty of space available and expect your system can handle it.

Thanks again for the help. Using the --take <INTEGER> parameter was they key!


Merge verifying commits and files

@charlierudolph @allewun
This PR dries up the verification of unchanged commits, by re-using the commit table that was originally defined in the beginning of a feature.
In order to make that happen, I had to merge the command and file content comparison. Which is naturally anyways imho.

all comments addressed

Please push up your latest changes.

Can't you remove a few a file step definition and a few file helpers?
I also think we should change the name of content_of(file:, branch_name:) to content_of(file:, sha:). Should work exactly the same.

I have looked around, but found neither step definitions nor file helpers that aren't used anymore.

I also think we should change the name of content_of(file:, branch_name:) to content_of(file:, sha:). Should work exactly the same.

While this is technically true, this method is used only with branch names so far. I'm happy to change it once we provide a SHA to it somewhere.

all comments addressed

I still believe you can remove some steps in features/step_definitions/file_steps.rb and some functions in features/support/file_helpers.rb as we are no longer verifying files by themselves.

Sorry missed one of your comments. Where are we still verifying files on their own? You can also run  cucumber --format=usage which will report any unused steps

I was able to remove a good amount of redundant verifications, thanks for the hint!
I still verify the final file content in places like https://github.com/Originate/git-town/blob/kg-original-commits-2/features/git-hack/pull_main_branch_conflicts_with_open_changes.feature#L69.
I could remove the And now I have the following committed files  step and change it to look like this:
    And now I have the following commits
      | BRANCH      | LOCATION         | MESSAGE                   | FILE NAME        | FILE CONTENT     |
      | main        | local and remote | conflicting remote commit | conflicting_file | remote content   |
      |             |                  | conflicting local commit  | conflicting_file | resolved content |
      | new_feature | local            | conflicting remote commit | conflicting_file | remote content   |
      |             |                  | conflicting local commit  | conflicting_file | resolved content |

But I don't find this documenting clear enough what content the file in each branch actually has. Yes, the commits are verified in order. But having to go through each individual commit for each file feels overly cryptic and technical. But I don't feel strong either way.
What do you think?

And hey, I told you about finding unused cucumber steps! A much faster version is cucumber --dry-run -f stepdefs btw.

I favor moving all file content checks into the commit verification tables. The content of a file should always be the content of the last commit that changed the file.
However, at the moment we aren't verifying the order of commits. This was something I tried to implement before and wasn't able to. I'd like to take another crack at it.

Okay, so let's merge this PR then, implement the verification of commit order separately (#341), and then clean up the remaining And now I have the following commits steps (#342).

all comments addressed

Okay cool. :ship:


Generate qcow2 image for all providers

Having the qcow2 image generation process in the common podvm directory will make it easier to generate qcow2 images for all providers which can then be converted to native format as needed.
This will also help with releasing qcow2 images for podvm as release artifacts.

I did some testing with generating s390x qcow image in github actions earlier this week. Which worked, just need to extend some wait times as the emulation seems to be a little slow.
To produce a full image though we will also need to cross-compile, the binaries.


BigDecimal narrowing

It would be nice if BigDecimal implemented the (currently internal) interface in BigNumber of NarrowingOperations to support changing BigDecimals back to all the various basic types; Int, Long, Short, Float, Double, UInt, UShort, ULong, Byte and UByte,
Since BigDecimal is not "open"  extension functions are required to do this.  An example of one is below.
/**
 * Returns a long value that truncates any digits to the right of the decimal.
 *
 * @param exactRequired if true and non-zero truncation error would result
 * @throws ArithmeticException if the value is to large or too small for a long, or if
 * exactRequired true and value to right of decimal is non-zero
 */
fun BigDecimal.longValue(exactRequired: Boolean = false): Long {
    val limit = BigDecimal.fromLong(Long.MAX_VALUE)
    val lowLimit = BigDecimal.fromLong(Long.MIN_VALUE)
    if (this > limit || this < lowLimit)
        throw ArithmeticException("Narrowing to Long would lose significant digits")
    return checkTruncation(exactRequired)
}

private fun BigDecimal.checkTruncation(exactRequired: Boolean):Long {
    val result = this.divideAndRemainder(BigDecimal.ONE)
    if (exactRequired && !result.second.isZero()) {
        throw ArithmeticException("Narrowing would lose precision")
    }
    val work = this.minus(result.first)
    return work.significand.longValue(exactRequired)
}

This would provide a superset of the narrowing operations provided in java's BigDecimal

Thanks for looking at this! Sorry that code above is just a sample and has a bug so don't use it :-)

@skolson If you have time and would like to tackle this, a pull request would be great. I can help you out with any questions that you have regarding the internal organization of the library or possible ways to approach this.

I will try to work on this in a couple days. Will keep you posted here.

Ok, I have a first draft of code for this, but am having trouble with a couple unit tests. What environment do you use for debugging?  I'm using Android Studio but also have Intellij installed and could try there.  I see you have some JUnit tests in jvmTest but Android Studio doesn't seem to recognize the jvmTest/kotlin directory.  It looks like a sourceSet issue, as AS normally decorates sourceSet directories with green dots, and that isn't happening with jvmMain or jvmTest.
I can run unit tests fine in commonTest, which AS does decorate, but can't debug them with ADB. so am curious what your process is.
Also FYI I had to change dokka in the build.gradle scripts to 1.4.0-rc, which changed from "dokka" to "dokkaHtml" or "dokkaJavadoc".  I'm not a dokka user so I chose "dokkaJavadoc" just to get it to work.

Oops just noticing the gradle stuff that is linux-specific, so lemme see if I can get windows working for jvm target at least

Ok debugging fine now and have found a rounding issue. Lemme know if you want me to try to fix, or open another issue, or what.  Given this code:
val dub = BigDecimal.fromDouble(Double.MIN_VALUE)
val dub2 = dub.divide(BigDecimal.TEN)

Infinite precision should be in use, so this should get 4.9E-325 for dub2. Initially the correct new exponent of -325 is calculated, but then in fun roundDiscarded stuff gets lost, resulting in this debug output:
dub = {BigDecimal@1887} "4.9E-324"
 precision = 2
 significand = {BigInteger@2118} "49"
  magnitude = {long[1]@2120}
   0 = 49
  numberOfWords = 1
  stringRepresentation = null
  sign = {Sign@1924} "POSITIVE"
 exponent = -324
 decimalMode = null
dub2 = {BigDecimal@2115} "0.E-318"
 precision = 0
 significand = {BigInteger@2121} "0"
  magnitude = {long[1]@2124}
   0 = 0
  numberOfWords = 1
  stringRepresentation = null
  sign = {Sign@2125} "ZERO"
 exponent = -318
 decimalMode = {DecimalMode@1896} "DecimalMode(decimalPrecision=0, roundingMode=NONE)"

Hey @skolson, if you want to tackle the rounding issue that would be great! I think it would be better to open a separate issue for that, and handle it in a separate pull request, as it's then easier to review. I'll try to adapt the build.gradle.kts to enable JVM on windows/mac/linux depending on a local gradle variable. I'll open a separate issue for that.
As far as the IDE goes, I would definitely recommend IntelliJ, I'm using Ultimate, but Community version should work fine as well. The reason is that AS is usually lagging a bit with bleeding edge kotlin support, although even when using IntelliJ you'll see some issues where gradle builds the project fine, but IntelliJ thinks there are errors (expected/actual implementation when using common native source set, and others)

heres a pull request for windows development support, as well as fix for dokkaJavadoc https://github.com/ionspin/kotlin-multiplatform-bignum/pull/117

Thanks! I will get back to this on Tuesday, will keep you posted.

I merged the gradle configuration changes to master, so now if you add bignumPrimaryDevelopmentOs=windows to your gradle.properties (should be in  C:\Users<User>. gradle\gradle.properties) build script will enable JVM and JS targets when you run ./gradlew build
Same commit should also have fixed the dokkaJavadoc issue

Ok I'm gonna make a new issue and a different pull request for the rounding on division problem, and will work on that first as it'd be nice to have for the unit tests on the narrowing stuff.

I synced up the latest changes on the master, and now gradle is unhappy:
Host os name WINDOWS
[ios, ios32Arm, ios64Arm, macosX64, metadata, mingwX64, native, tvosArm64, tvosX64, watchosArm32, watchosArm64, watchosX86]
Dokka !
FAILURE: Build failed with an exception.
* What went wrong:
Task 'cleanJvmTest' not found in project ':bignum'.

I'm looking for the cause...

Well I have progress, but I keep hitting edge cases that trip up unit tests :-) This one is in BigInteger longValue implementation, which BigDecimal longValue relies on.  Doing this:
val l = BigInteger.fromLong(Long.MIN_VALUE)
val x = l.longValue()

x gets 0 instead of Long.MIN_VALUE, because the magnitude of Long.MIN_VALUE is actually 2 words. BigInteger longValue assumes correct value is in magnitude[0] which in this case is zero. (magnitude[1] = 1 in this case)
I think this is just because MIN_VALUE.abs is one larger than MAX_VALUE, so MIN_VALUE is the only value that can expose this error.  Any suggestions on a best fix for this one?
I'm close enough that it might be time for me to do the pull request so you can see what I have so far and we can decide what else needs doing (or undoing if I did something bad :-)). Unfortunately my pull request would have the fixes for both 111 and 114. I hope that's ok, I'm still a git newbie to these pull requests.

Another great catch, the reason BigInteger needs two words to store Long.MIN_VALUE is because the current implementation uses 63 out of 64 bits to store the number data, the last bit I reserved for more efficient addition operations, as then there is no need to check for overflow. There is a check for this situation when converting from Long.MIN_VALUE, but not the other way around. I think I can fix that quickly and push to master.
As far as your pull request tackling two issues, that's completely fine!
Once again, thanks for all the effort you are putting into this!

Hey! I think I have another in BigInteger longValue, this one is on the exactRequired comparison.  This line I think is trouble:
if (exactRequired && (this > Long.MAX_VALUE.toUInt()))

because the UInt comes back with the max integer value, not the max long, so then the compare is done on the int....

I'll fix that at the same time!

Here is the pull request that should fix the conversion problem #120

Any near-term plans to do a 0.2.0 snapshot publish that would have these changes in it?

Each merge to master is automatically published to sonatype snapshot, so the current 0.1.6-1.4.0-rc-SNAPSHOT has all the changes from this pull request (you can see the actual files here, note the timestamp at the end of the filename https://oss.sonatype.org/content/repositories/snapshots/com/ionspin/kotlin/bignum/0.1.6-1.4.0-rc-SNAPSHOT/). I'll bump the version up to 0.2.0 before the stable release, because there were enough changes to warrant it.
Btw, gradle can sometimes be uncooperative when the dependancies are already cached so you might need to do ./gradlew build --refresh-dependencies

Ok cool, I saw the target on the issue being 0.2.0 and thought it was waiting for that.

Hmm, I did the --refresh-dependencies, and the jar gradle has was built last night.  So is the sources jar. But AS is still not able to resolve the new code, and if I look in the sources jar, the new code isn't in that source either. So it's like the new stuff isn't merged or something?

It''s already there end of each build on master branch directly publishes to sonatype repository. I just tested it in a separate project and I'm seeing new narrowing functions.
If you are not seeing it it might be that Gradle is still using cached libraries (which hopefully --refresh-dependencies solves), or that Android Stuido is using cached libraries. In Android studio you can open Gradle tab, for me it's on the right side, right click on the project name and select Refresh Gradle Dependencies
But as I said it's finicky, i had several occasions where I had to delete gradle and m2 cache folders and reimport AS/IntelliJ project before the changes were visible, although it did get much better lately.


AngularSlideables does not work on div with generated html (ng-bind-html)

I was trying to get it working on a div which loads in content with html tags, but as long as there is an ng-bind-html attribute on the .slideable element it does not work.
The error given is "Uncaught TypeError: Cannot read property 'style' of null", when trying to log the content variable, you get "null".
AngularSlideables does work with html tags in the div and it works when I remove ng-bind-html (which is not an option for me).
Code example:

{{ tip.title }}

                    {{ tip.body }}

I discovered the same problem, it is because .directive('slideable',  calls var contents = element.html(); but element is in this case an array.

I ended up using this code
app.directive('slideToggle', function() {
  'use strict';
  return {
    restrict: 'A',
    scope: {
      isOpen: '=slideToggle' // 'data-slide-toggle' in our html
    },
    link: function(scope, element, attr) {
      var slideDuration = parseInt(attr.slideToggleDuration, 10) || 200;

      // Watch for when the value bound to isOpen changes
      // When it changes trigger a slideToggle
      scope.$watch('isOpen', function(newIsOpenVal, oldIsOpenVal) {
        if (newIsOpenVal !== oldIsOpenVal) {
          element.stop().slideToggle(slideDuration);
        }
      });

    }
  };
});


cannot batch correct between technologies, e.g. smartseq and 10X

I'm using the following code, which a cp from the tutorial:
import scvi
from scvi.dataset import AnnDatasetFromAnnData
from scvi.inference import UnsupervisedTrainer
from scvi.models.vae import VAE
from typing import Tuple

def compute_scvi_latent(
    adata: sc.AnnData,
    scVI_model_name: str,
    n_latent: int = 10,
    n_epochs: int = 150,
    lr: float = 1e-5,
    use_batches: bool = True,
    use_cuda: bool = True,
) -> Tuple[scvi.inference.Posterior, np.ndarray]:

    """
    Train and return a scVI model and sample a latent space

    :param adata: sc.AnnData object non-normalized
    :param n_latent: dimension of the latent space
    :param n_epochs: number of training epochs
    :param lr: learning rate
    :param use_batches
    :param use_cuda
    :return: (scvi.Posterior, latent_space)

    """
    print(scVI_model_name)
    print('Convert easily to scvi dataset')
    scviDataset = AnnDatasetFromAnnData(adata,batch_label = 'batch')
    print(np.unique(scviDataset.batch_indices))
    print(scviDataset.n_batches)

    print('Training a model...')
    print('VAE')
    vae = VAE(
        scviDataset.nb_genes,
        n_batch=scviDataset.n_batches * use_batches,
        n_hidden=128, n_latent=30, n_layers=5, dispersion='gene'
    )

    print('UnsupervisedTrainer')
    trainer = UnsupervisedTrainer(vae, scviDataset, train_size=.99, use_cuda=use_cuda,
                                  n_epochs_kl_warmup=None,n_iter_kl_warmup=int(128*5000/400))

    trainer.train(n_epochs=n_epochs, lr=lr)
    ####

    torch.save(trainer.model.state_dict(), scVI_model_name)

    print('Extracting latent space')
    posterior = trainer.create_posterior(
        trainer.model, scviDataset, indices=np.arange(len(scviDataset))
    ).sequential()

    latent, _, _ = posterior.get_latent()

    return posterior, latent

I defined the batch as:
adata.obs['batch'] = adata.obs['method'].astype(str) + '_' +adata.obs['tissue'].astype(str)

batch_dict_keys = list(set(adata.obs['batch']))
batch_dict_values = range(len(batch_dict_keys))

batch_dict = {batch_dict_keys[i]: batch_dict_values[i] for i in range(len(batch_dict_keys))}

adata.obs['batch_categories'] = adata.obs['batch'].copy()
adata.obs = adata.obs.replace({'batch': batch_dict})

where method is either smartseq2 or 10X. Then
n_epochs_all = None
n_epochs = 150 if n_epochs_all is None else n_epochs_all

scvi_posterior, scvi_latent = compute_scvi_latent(
    adata, n_epochs=n_epochs, n_latent=30,
    use_batches = True, use_cuda=True, scVI_model_name = 'lemur-scVI-'+celltypesubset+'.pkl'
)

followed by
sc.pp.neighbors(adata, n_neighbors=20, n_pcs=30, use_rep="X_scvi")
sc.tl.umap(adata)
sc.tl.leiden(adata, resolution=5, key_added="leiden_scvi")

sc.pl.umap(adata,color=['method','tissue','individual'],ncols=1)

which yields

any suggestions?

What were the results of
print(np.unique(scviDataset.batch_indices))
print(scviDataset.n_batches)

?

It's unclear exactly from just reading the code, but I think the problem may be that adata.obs['batch'] contains strings and not ints.

Ok I would still inspect manually that scviDataset.batch_indices contains what you want (and as ints).
Other reasons this can occur:

The lr is 1e-5, this seems really low, so the model probably is underfitting the data. I'd use 1e-3 at a minimum.
How many genes are you using? Unless you need all the genes for some reason, performance will be better if you cut down to a few thousand genes.
5 hidden layers means there are even more parameters to train, I'd run for 400 epochs at a minimum, unless you're manually inspecting the loss. I'm not even sure 5 hidden layers is necessary.
30 dimensions for the latent space also seems a bit high. scVI should more efficiently compress the data than a PCA, and it's possible with more dimensions here that disentangling the batch is harder.

@aopisco I'm going to close this issue, but feel free to reopen if you have any other questions or comments!

@aopisco After all these things, another point is that I think we performed some type of gene length correction in our analysis for merging some SS2 and 10x data? I think this is detailed in our scANVI manuscript, I'm sure @chenlingantelope can confirm / help / explain on that end.


Check httpcontext for null in javascript snippet. Fix issue 556

Fix Issue #556  .
Null check.

[ ] I ran Unit Tests locally.

For significant contributions please make sure you have completed the following items:

[ ] Changes in public surface reviewed

[ ] Design discussion issue #

[ ] CHANGELOG.md updated with one line description of the fix, and a link to the original issue.

[ ] The PR will trigger build, unit tests, and functional tests automatically. If your PR was submitted from fork - mention one of committers to initiate the build for you.
If you want to to re-run the build/tests, the easiest way is to simply Close and Re-Open this same PR. (Just click 'close pull request' followed by 'open pull request' buttons at the bottom of the PR)

Please follow [these] (https://github.com/Microsoft/ApplicationInsights-aspnetcore/blob/develop/Readme.md) instructions to build and test locally.

@SergeyKanzhelev can you review this?

Ping..


Hipchat adapter fails to hear incoming messages

Everything loads fine and Hubot enters the rooms correctly.  However, Hubot doesn't seem to hear or respond using the hipchat adapter on heroku (even when private messaging).  This is only error I can find, though I doubt its relevant
2011-10-26T23:58:57+00:00 app[app.1]: Cannot use StringPrep bindings. You may need to `npm install node-stringprep'

You may need to `npm install node-stringprep'

Is this fixed on 1.1.3?

Yup.  Although it still throws the error.  I would also note that I had to force the scripts to 1.1.2 in package.json, as 1.1.3 borked the heroku push.


Add backgroundColor to progress-spinner

Feature Description
Feature that would allow setting progress-spinner's background color.
Use Case
When using a progress-spinner for example as an indicator of stepper, it would look definitely better with colored background.
See spinner without background vs. with background.

A few considerations on this:

The spinner background should be transparent by default, to keep appearance the same between versions
It would be good to offer three choices for background: transparent (default), greyscale, color. Greyscale will be as you proposed and color will use a translucent version of the spinner color (see https://material.angular.io/components/progress-bar/examples for how this looks)
Need to decide on how the color will be set via the api, as there isn't a precedent for background options
I'm not a Material expert, but this doesn't seem to fit with the rest of Angular Material - I can't see any components that let you customise backgrounds like this

We're in the process of cleaning up our issue backlog. I'm closing this issue, because the Material Design specification doesn't explicitly allow background colors on spinners.

Hi everyone,
Hi @crisbeto,
I still can see a value of adding that "invisible, circular track". It is quite confusing when the process is stuck (lets say at 0-10%):

Implementation wise, there is no much effort - just to add another circle.
Our team had to implement a directive for that. It injects another circle with the same radius and strokeWidth then checks for it's changes on ngDoCheck:

It would be great to have this feature out of the box.


fix(releaserc): remove publish for openrpc release

:tada: This PR is included in version 1.1.3 :tada:
The release is available on:

1.1.3
GitHub release
1.1.3

Your semantic-release bot :package::rocket:


React-native Android Webview: navigator = {}

Setup:
Expo React-native app + Android Webview (react-native-webview package version  "11.23.0") + WebRTC
Permissions are set in Android Manifest for Camera and Audio devices.
When opening webview, user is asked about permisssion for Audio/Video but then when trying to access navigator object to get media devices only empty object is returned. (not undefined, just {} empty object).
Searched through all the issues here and on stackoverflow but could not find a reason why it is not set.
Thank you for any idea!

seems that sometimes it can be {} and functional


License?

I'm rather new to GitHub/public code, so apologizes if I've overlooked something.  Is there a license for this code?  I'd potentially like to use it for calculating postage for packages for commercial use.
I looked at some of the referenced GitHub repos you used and didn't immediately see licenses on them either.
Thanks!

Hi. I would like to use this library in a commercial application and fork it. According to section 2 here, I am not able to do it safely.

Hello! Would the MIT license suit your needs?

Added MIT license to the repo.


Evaluate impact of updates to CDS

The motivation
The team behind Copernicus/CDS has announced they are making substantial changes to the service in an attempt to modernise their infrastructure:
https://forum.ecmwf.int/t/a-new-cds-soon-to-be-launched-expect-some-disruptions/1607/50
They haven't released (or I couldn't find) any details on how these changes will impacts APIs / downstream consumers. This issue can simply serve as a reminder / TODO to check back periodically to see if changes will be required.
The team has stated:

the current Climate and Atmosphere Data Stores will continue to operate until complete shutdown on 1st September 2024.

So we will need to understand before September what, if any, changes will be required on our side.
The proposed solution
Watch and wait until details have been released about impacts to downstream consumers.
Additional context
https://forum.ecmwf.int/t/a-new-cds-soon-to-be-launched-expect-some-disruptions/1607

It seems we need to move to ads-beta because their stable system stops working on 2024-09-26:
2024-09-04T13:09:40.725000: 2024-09-04 11:09:40,725 INFO Welcome to the ADS.
2024-09-04T13:09:40.725000: As per our announcements on the Forum, this instance of ADS will be decommissioned on 26 September 2024 and will no longer be accessible from this date onwards.
2024-09-04T13:09:40.725000: Please update your cdsapi package to a version >=0.7.0, create an account on ADS-Beta and update your .cdsapirc file. We strongly recommend users to check our Guidelines at https://confluence.ecmwf.int/x/uINmFw
2024-09-04T13:09:40.725000: 2024-09-04 11:09:40,725 WARNING Move urgently to ads-beta

The ADS/CDS team now provides a migration guide to the new system: https://confluence.ecmwf.int/display/CKB/Please+read%3A+CDS+and+ADS+migrating+to+new+infrastructure%3A+Common+Data+Store+(CDS)+Engine
Steps to migrate openmethane-prior to the new ADS system:

[x] Register for an ECMWF account (https://www.ecmwf.int/)
[x] Accept terms for ADS beta with new account: https://ads-beta.atmosphere.copernicus.eu/
[x] Accept license to use Copernicus products (bottom of the Download page of the dataset we need): https://ads-beta.atmosphere.copernicus.eu/datasets/cams-global-fire-emissions-gfas?tab=download
[x] Accept terms for CDS beta with new account: https://cds-beta.climate.copernicus.eu/
[ ] Update credentials used in GHA
[ ] Update documentation to guide users to the new ADS account process


[torchlib] Revisit empty_var

May be it is trying to create a don't-care value of the given dimension? Then, the code is wrong, and needs an Expand perhaps.

Originally posted by @gramalingam in https://github.com/microsoft/onnxscript/issues/786#issuecomment-1594907255

This is refine, but not sure there have some better way to create empty tensor in OnnxScript.
https://github.com/microsoft/onnxscript/pull/902


refactor(cherow): WIP: Implement JSX

Coverage decreased (-1.7%) to 92.718% when pulling ece51b26ac2bd7c298ebf3e04acbd07003b6ba47 on jsxx into 0ad16bf12f82930fa9e103131b3277210a03bc53 on master.

This pull request introduces 1 alert when merging ece51b26ac2bd7c298ebf3e04acbd07003b6ba47 into 0ad16bf12f82930fa9e103131b3277210a03bc53 - view on LGTM.com
new alerts:

1 for Unused variable

Comment posted by LGTM.com

This pull request introduces 1 alert when merging d93a6da765a6db54d1989de0365c5510ddd5e41d into 0ad16bf12f82930fa9e103131b3277210a03bc53 - view on LGTM.com
new alerts:

1 for Unused variable

Comment posted by LGTM.com

This pull request introduces 1 alert when merging 04515cdd5db259a75b5b9a74c1344aa021257022 into 0ad16bf12f82930fa9e103131b3277210a03bc53 - view on LGTM.com
new alerts:

1 for Unused variable

Comment posted by LGTM.com


mouseup event is handled in angular-signature before being handled in signature.js

When drawing dots in the signature pad, it will be considered as empty (signature.isEmpty) because mouseup event was handled in angular-signature before being handled in signature_pad.js (handling the event in signature_pad.js will set this._isEmpty to false).
This only happens when drawing dots, when drawing a curve in the signature pad, this._isEmpty will be set to false when handling the mousemove event which will be fired before the mouseup event. So when the latter is fired, this._isEmpty was already set to false and the signature pad won't be considered as empty.
The solution is to defer handling mouseup event in angular-signature (ensuring that handling the same event in signature_pad.js will be done first).

The mechanism used to defer handling mouseup event was using the $timeout service, and I'm not sure if it's the better mechanism.


Support for fetching interactions from the lower triangle when it makes sense

Support fetching interactions from the matrix lower triangle in the following scenarios:

Query is materialized as a sparse matrix
Query is materialized as a dense matrix
Query is materialized as a table of pixels

Iterating over pixels from the lower triangle is not (and will never be) possible, as doing so would require pre-loading and re-sorting all pixels overlapping a query (defeating the purpose of iterators).
Closes #174
Closes #175

Codecov Report
Attention: Patch coverage is 93.75000% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 85.10%. Comparing base (9f426e7) to head (627bd08).
Report is 21 commits behind head on main.

Files
Patch %
Lines

...lude/hictk/transformers/impl/to_dataframe_impl.hpp
92.99%
15 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #179      +/-   ##
==========================================
+ Coverage   84.91%   85.10%   +0.18%
==========================================
  Files         119      120       +1
  Lines       10076    10305     +229
==========================================
+ Hits         8556     8770     +214
- Misses       1520     1535      +15

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Incorrect occupancy with two motion sensors

I have 2 motion sensors in the garage and causes MA to get stuck thinking that the area is occupied with its not.
I use Zigbee and Philips hue sensors and there are no ZHA issues reported. I see both sensors detecting motion and clearing correctly. Default timeout value are used for clearing, missed events, extended and clearing extended.
If I restart HA the issue stops for a while and then come back after a yet to be determined period and or squence.

I have many areas with more than one motion sensor working correctly. Will need more information to get to the cause.
Can you check the binary sensor for the area binary_sensor.$area_name and look if there are any active_sensors (attribute)?

Whilst collecting the info I found that one of my sensors hadnt been renamed to my naming standards and so I renamed them. I then deleted the MA Garage config and reconfigured but its still using the old entity names. I think this this is the other bug mentioned around deleted entities.
The area seems to be working again but im struggling to determine if its using both motion senors (suppect not). Most likely its only using the first correctly named sensor, therefore there is only one sensor and thats why is working :-(
I'll monitor and keep investigating.

Whilst collecting the info I found that one of my sensors hadnt been renamed to my naming standards and so I renamed them. I then deleted the MA Garage config and reconfigured but its still using the old entity names. I think this this is the other bug mentioned around deleted entities.
The area seems to be working again but im struggling to determine if its using both motion senors (suppect not). Most likely its only using the first correctly named sensor, therefore there is only one sensor and thats why is working :-(
I'll monitor and keep investigating.

Where is the configuration stored and will update the correct entity names manually?

I think this this is the other bug mentioned around deleted entities.

Make sure you're on the latest release (3.0.1), that has been fixed there.

The area seems to be working again but im struggling to determine if its using both motion senors (suppect not). Most likely its only using the first correctly named sensor, therefore there is only one sensor and thats why is working :-(

Look at the presence_sensors attribute, shall list all sensors it is using for presence.

Where is the configuration stored and will update the correct entity names manually?

Configuration of integrations over the UI will be on the /config/.storage/ folder.

Thanks for your response. It’s later here and so will explore more tomorrow.
Just an FYI that I’m using 3.0.1 and it’s deployed manually, not with HACS.
Kind regards,
Stuart

On 24 Jul 2022, at 6:53 pm, Jan Seidl @.***> wrote:

I think this this is the other bug mentioned around deleted entities.
Make sure you're on the latest release (3.0.1), that has been fixed there.
The area seems to be working again but im struggling to determine if its using both motion senors (suppect not). Most likely its only using the first correctly named sensor, therefore there is only one sensor and thats why is working :-(
Look at the presence_sensors attribute, shall list all sensors it is using for presence.
Where is the configuration stored and will update the correct entity names manually?
Configuration of integrations over the UI will be on the /config/.storage/ folder.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.

Ive been trying to track down specifics but its difficult as there is more than one issue.
In the Garage there are two sensors that are working correctly however the area is always detected as occupied. Ive stopped using automations within MA to rule them out and the issues persist, its all to do with the area being detected as occupied regardless of how long I ensure that the two ZHA sensors are not triggered.

I have another area called "Cloak Room". This has a single Ikea ZHA sensor and a single light. It uses default settings with "Create light group" and was working and then just stopped. I can see when I enter that the ZHA sensor tiggers as does the "Area (Cloak Room" sensor but the light doesnt come on.

I Splunk both event updates and HA logs and dont see any issues related to MA or associated components.
I used MA v2 until the HA breaking changes to groups and moved to 3.0.0 beta, then 3.0.0 release and then 3.0.1.
I currently suppect the following:

There are some values stored in previous versions that dont get updated or corrected with either deletion and reconfiguraiton or version uplift of MA.

When entities get changed in HA they dont get updated in MA. This remains the case if the MA config for that area is deleted, HA Restarted and the config recreated. Something is being persisted somewhere.

Theres a state persistance issue with sensors setting the state of "Area ($area)" that gets locked somehow. This is either due to dual motion sensors or where one of the sensors gets renamed. MA persists the old sensor entity name and therefore fails to get the right variable to mark the <binary_sensor.area.$areaname> as unoccupied.

I didn't manage to find the config in .storage to manually update.
If I thought it would make a difference I would deleted the whole integration and start again with a fresh 3.0.1 but I'm not convinced that all of the old configuration would be removed and the issues would remain.
I'm currently at "its nearly brilliant" and keen to help resolve these issues.

Got it. It's likely to be some leftover from previous releases. The 3.0-beta breaks backwards compat with 2.x and the 3.0 release breaks the 3.0-beta as well.
This was due the unique_id of MA's entities needing change to conform with HA's standards. You can check if you have any entities ending with _2 (which is the HA behavior when two entities have the same name. Might be the case that 3.0 created the entities with the new unique_id and now you have duplicated entities causing havoc.
Best for starting with 3.0 is to nuke'em all and re-configure, even if you're coming from the beta.

Just to confirm the correct removal process:

Using "Settings" + "Devices & Services", delete the MA configuration for each area
Once each area is deleted then delete MA as a whole from "Devices & Services"
Remove "magic_areas:" from configuration.yaml
Delete /config/custom_components/magic_areas
Restart HA

Hopefully this will remove 100% of the MA configuration. If you could confirm this, that would be great.

This is to fully remove the integration. If you're already on 3.0.1, you can just remove the areas (step 1) and restart to reset the configuration.

Ok, so I removed everything including deleting the MA folder in "custom_integrations", restarted and installed manually from scratch using MA 3.0.1. When HA restarted, MA created config for most of the areas except 2. I have 24 areas and the 2 that were not created in MA havent been touched for months. Both "Pantry" and "Master Walkin", I dont see any issues in HA logs and this wasnt an issue before with any version of MA 2 or 3. Ive tried deleting and recreating the Pantry area in HA and restarting HA multiple times but this has not resolved this.
UPDATE (2 hours later): I just found that "Pantry" and "Master Walkin" were listed as being "disabled by the user". I havent disabled these but something thought they were for random some reason. I re-enabled them and they are now working the same as other areas if I specifiy the lights.
There also seems to be rooms working that had stopped working before and other that we working fine, that now dont work. Just to confirm, I have checked that "Area Light Control ($area)" switches are all turned on.
Cloak Room:
This had stopped working previously but now after the reinstall and basic MA configuration, this room is working as expected currently.
Garage:
Garage has two motion sensors and the issue of it being stuck as "detected" is resolved. I can see both sensors being activated and "Area (Garage)" going on and off as expected.
Pantry:
This isnt working as the MA configuration has been created. UPDATE: Now working as expected
Laundry:
This was working fine previously but now, with the same basic MA config as "Cloak Room", isnt working. I can see the motion sensor being triggered and "Laundry (Area)" triggering but no lights were turned on. I reconfigured Laundry in MA and the only change I made was to specify the Laundry Light entity in the Overhead Lights feild. This resolved the issue and even though both lights and motion sensor is correctly defined within the "Laundry" area in HA.
Lobby:
This has the same issue as Laundry, it didnt work but did when I specified the light to turn on rather than leaving the option blank.
Summary:
Everthing is working as it should after some work arounds re-enabing areas in MA and specifying specific lights to turn on. I'm hopeful that the currently deployment will remain working and I'll not change anything for a few days to make sure. Previous experience was that some things work work initially and they stop working. Fingers crossed.

Thanks for the update. There was a behavior change that might explain the situation that previously if you haven't configured any lights it would turn on all lights. This behavior was changed to don't turn any lights if you don't have any defined, because there are situations where you may only want to have lights come up on the extended state. I do that to my entrance hall area and add the front door contact sensor as the accent entity so now lights only come on if I open the door or if there's activity in the area for a while.
Glad that so far everything is working. Nothing should change hopefully! Let me know if you have any other issues or if we can close this one.
Cheers!

Thanks and keep it up, MA is great and simlifies automation greatly.
Just a couple of side notes: I find the options for when things should be triggered confusing such as "state" and "sleep" etc, some hover tips would be great. Also I dont use the automation options for some rooms as I want to send data options to specific lights such as {"effect": "Solid", "brightness":"150"}, maybe an option here would be to allow triggering a scene rather than a light?
Thanks again and well done, MA is one of the best addon's for HA.

Closed but will monitor for issues

Back to where this thread began, the garage has 2 motion sensors, was working fine but now is stuck with "Area (Garage)" showing as Detected regardless of how long the period of inactivitiy of the 2 montion sensors has been.

The config for this area is as follows:
HA Area:

MA Config:

NOTE: I use my own automations that use the "Area (Garage)" status for activation which is now stuck as "detected"

NOTE: Presense hold is turn on based on the position of the wall switch which has been off the entire time of this test

BTW: Please consider using a different naming standard for the light groups created by MA as it would be natural for user to create something like light.bathroom_lights where these is just one switch. This leads to two enties called "Bathroom Lights", one being the one created by the user and the second being the group created by MA and likely with an entity name of light.bathroom_lights_2.
We use an auto entity card to show everything that is "on". MA creating lots of additional groups leads to multiple entries on the auto entities card for just one device being "on". With 24 areas this is difficult to filter.

Back to where this thread began, the garage has 2 motion sensors, was working fine but now is stuck with "Area (Garage)" showing as Detected regardless of how long the period of inactivitiy of the 2 montion sensors has been.

That's really odd. My guess would be that some of your other presence_sensors are flapping constantly.

Could you describe what each of the sensors listed under presence_sensors are? That might help me get an idea of what might be causing this.

TW: Please consider using a different naming standard for the light groups created by MA as it would be natural for user to create something like light.bathroom_lights where this is just one switch.

I hear you. I grew to name those "switch as X - light switches" something more specific like "Backyard Main", "Bathroom Vanity", or "Kitchen ceiling light". I'm not married to this name, it's whatever made sense when I was creating the feature, since that group is for all lights in the area I just went ahead and called "$area Lights". Could be "All Lights ($area)".
The catch is that I've done that for all other groups so change would have to be consistent across. Would have to wait for a major release tho since it's a breaking change.

Hey @hirsts, any updates?

Closing due inactivity. Please reopen if issue still persists.


Add VmExtension ps API calls

@larisaborodina,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot


[ci] Change conda install location

for https://github.com/Microsoft/LightGBM/pull/1849#issuecomment-439854619

@StrikerRUS I just remove all chmod, you can try it after the dev image built.
If that cannot work, you can try to add the last chmod.

@guolinke OK.

@guolinke chmod is needed, Permission error otherwise.

@guolinke I've checked - everything OK now. Please merge, because GitHub doesn't allow me to do it due to red CIs.

it seems the test still using usr/local/miniconda as envs.

Thanks @chivee for merging!


How to shut down a client gracefully?

  I see an example of calling mqtt_client.shutdown(), however this method doesn't seem to exist on version 0.30.1 of this library?

Shutdown that you see isn't graceful shutdown. Graceful shutdown isn't possible yet. I'm waiting for stable async/await to start the work.

OK.  Is there any way currently to cleanly shutdown the connection to the broker then?
I'm simply dropping the client, which results in an error message at the broker.

I've moved to the master branch and calling mqtt_client.shutdown() has the desired effect of sending a clean shutdown signal to the broker, thanks!


Make command issues

Two primary issues in trying to use make with onivim2:

Using built-in :make
There's not evidence to the user that this does anything. No error messages, nor confirmation that it is/isn't running, or that it has completely succesfully.

Using make from the terminal
Results in an Makefile error... coming from onivim 2. Running with make -n (verbose) shows that where it should be running make, it's not running onivim2:

In normal terminal:
[...]
make -s -f CMakeFiles/Makefile2 all
[continues sucessfullly]

In onivim2 terminal:
[...]
onivim2 -s -f CMakeFiles/Makefile2 all
[continues successfully]

I have a feeling that the first issue is being caused by the second, but with the side-effect that it isn't relaying the fact that make returns an error.
Version:
onivim2: Onivim 2 (0.5.9-nightly)
OS: (Linux) Manjaro

Thanks @jrwrigh for logging the issue!
I suspect these are related to some of the quickfix errors in #3332 . That's an interesting observations about the make command being superceded.
I'd be curious what the delta is from the output of the env command in the Onivim2 terminal vs normal terminal - might be a clue there why the command is being overridden.

Below is a diff of the output of env from the onivim2 terminal (onivim2ENV) and my normal terminal session (termENV).


OBS WebSocket issues

It is very noisy in debug.
It does not shutdown when asked.

Just fyi: obs websocket apparently has a deeper issue somewhere, as there are currently quite a few OBS and companion related problems with it: https://github.com/bitfocus/companion-module-obs-studio/issues/52

Hmm.  Actually, I'm pretty sure in this case the bug was on my side. haha.  I think I've got it fixed now though.
Thanks for the heads up! I'll keep an 👁 out.

OK, both of these bugs appear to be fixed.


Failed to execute send on Websocket: Still in CONNECTING state

I setup just "quick example" from the GitHub page to test that I had Ratchet going correctly, but when I connect to my test page I'm getting this error message.
Uncaught DOMException: Failed to execute 'send' on 'WebSocket': Still in CONNECTING state.     at http://php7dev/:5:8 (anonymous) @ (index):5 VM736:35 WebSocket connection to 'ws://localhost:8080/echo' failed: Connection closed before receiving a handshake response WrappedWebSocket @ VM736:35 (anonymous) @ (index):3
My client page that is connecting is just the following
<?php
?>
<script type="text/javascript">
  var conn = new WebSocket('ws://localhost:8080/echo');
  conn.onmessage = function(e){ console.log(e.data); };
  conn.send('Hello Me!');
</script>
<?

The message is being sent before the connection is established. Try this:
var conn = new WebSocket('ws://localhost:8080/echo');
conn.onmessage = function(e){ console.log(e.data); };
conn.onopen = () => conn.send('hello');


launch_library sensor is missing data

what is in my hass doesn't even come close to what is published or available. Something is screwy here.
hass state:
Long March 3B/E | Zhongxing 6C (Chinasat 6C)

hass attributes:
icon: mdi:rocket
 launch_time: 2019-03-09T08:30:00
attribution: Data provided by Launch Library.
friendly_name: Next launch agency: null
agency_country_code: null
stream: null

What's available from https://launchlibrary.net/1.4/launch/next/1  ::: https://pastebin.com/qemi5Dn4
Code link : https://github.com/home-assistant/home-assistant/blob/dev/homeassistant/components/sensor/launch_library.py

Please fill out the complete issue template.

Last working version: None? I’m on 88.2


Could you please make it work with 'Readable line length' off?

My suggestion would be to use a CSS snippet to increase the margin on the left hand side of the editor.

My suggestion would be to use a CSS snippet to increase the margin on the left hand side of the editor.

I tried this code but it doesn't work. :(
.markdown-source-view {
padding-left: 100px;
}

Not sure if anyone is still stuck on this, but if you're wanting to adapt the gutter size to include more arrows with "readable-line-length" turned off, you can use the .cm-gutters css class, and change the width.
e.g.,


Create prodMeter and add CEC values

Meter_List_Data_ADA.xlsx
The CEC has a list of solar meters. There are only a couple specs on here that we'll need to add, but this issue it to make sure that it doesn't get forgotten.

@blizita

Reviewed 5/26/2023: ProdMeter is created.


bug: (picker) text-overlapping each other

Bug Report
Ionic version:

[x] 4.x
Current behavior:

text overlapping each other if you click inside anywhere in picker then it will be okay

Expected behavior:

By default it should be scrollable
Steps to reproduce:

Open picker again and again.

Related code:

Html :
https://github.com/indraraj26/ionic4-starter-tabs-sidemenu/blob/picker/src/app/home/home.page.html
Ts :
https://github.com/indraraj26/ionic4-starter-tabs-sidemenu/blob/picker/src/app/home/home.page.ts
insert short code snippets here

Other information:

Ionic info:

D:\ionicv4-github\ionic4-tabs-sidemenu>ionic info

Ionic:

   Ionic CLI                     : 5.4.4 (C:\Users\indra26\AppData\Roaming\npm\node_modules\ionic)
   Ionic Framework               : @ionic/angular 4.11.4
   @angular-devkit/build-angular : 0.801.3
   @angular-devkit/schematics    : 8.1.3
   @angular/cli                  : 8.1.3
   @ionic/angular-toolkit        : 2.0.0

Cordova:

   Cordova CLI       : 8.1.2<EMAIL_ADDRESS>   Cordova Platforms : android 7.1.4
   Cordova Plugins   : cordova-plugin-ionic-keyboard 2.2.0, cordova-plugin-ionic-webview 4.1.3, (and 6 other plugins)

Utility:

   cordova-res : 0.8.0
   native-run  : 0.2.9

System:

   NodeJS : v10.16.3 (C:\Program Files\nodejs\node.exe)
   npm    : 6.9.0
   OS     : Windows 10

D:\ionicv4-github\ionic4-tabs-sidemenu>

Thanks for the issue. I am going to close this as a duplicate of https://github.com/ionic-team/ionic/issues/17664.


sts: Include issuer URL in Exchange error message

This would have saved me a long time debugging something very dumb.

Can you make this change in mono? It will then be synced to the public sdk repo.

whoops lol


Remove DisplayVersion equal to Package Version

null
Microsoft Reviewers: Open in CodeFlow

@wingetbot waivers Add Validation-No-Executables


Consider claim deposit to be pegged to bounty

Currently deposit is an optional field that adds confusion for users that want to schedule. Claiming deposits improves the crypto-economics and thus shall be enabled by default.
First proposal is to make it 1:1 with bounty, enforced by the protocol.

@pipermerriam any thoughts on that? I also consider to soft enable that in at the client side.

@kosecki123 I think you can solve this client-side.  Pegging it at the protocol level eliminates the option for using changes to the claim deposit size to influence how your call is handled.
Suppose someone is having their scheduled transactions DOS'd by malicious executors who are willing to burn their claim deposits in order to delay execution till after the claim window (and maybe even reclaim their deposit by executing with an alternate client).  Being able to crank up the deposit size increases the cost of this style of attack.
Similarly, I may add a large bounty to the transaction, but the claim bounty doesn't necessarily need to be as large.  If we assume a situation where the network is congested, executors may decline to claim transactions with high claim deposit sizes for fear that their executing transactions won't get accepted during the exclusive execution window.
I'd just hide the claim deposit controls from the user either under an advanced section, or with a layer of UX (like gas price) which abstracts the number away into a slider with easy to understand labels.

Archiving