safari issue

Safari didn't send cookies

as a result:
[error] 13#13: *43 readv() failed (104: Connection reset by peer) while reading upstream, client: x.x.x.x, server: _, request: "POST /api/v1/tracker/fingerprint HTTP/1.0", upstream: "http://x.x.x.x/api/v1/tracker/fingerprint", host: "id.octolab.net", referrer: "https://kamilsk.github.io/passport/"

so, fallback is work cookie not found, skip this check ("Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_3) AppleWebKit/604.5.6 (KHTML, like Gecko) Version/11.0.3 Safari/604.5.6": ""), but I need to find the right way

notes:

https://github.com/github/fetch#sending-cookies

how to reproduce with #20:

make demo-cross-origin-up demo-cross-origin-status && docker logs -f crossorigin_service_1
open http://demo/
watch log

2018/04/02 10:19:16 - set cookie
2018/04/02 10:19:16 marker=cross-origin <nil>
2018/04/02 10:19:16 -
2018/04/02 10:19:16 "GET http://passport.local/js/passport.js HTTP/1.0" from <IP_ADDRESS> - 200 2506B in 321.3µs
...
[cors] 2018/04/02 10:19:17 Handler: Preflight request
[cors] 2018/04/02 10:19:17   Preflight response headers: map[Access-Control-Allow-Credentials:[true] Vary:[Origin Access-Control-Request-Method Access-Control-Request-Headers] Access-Control-Allow-Origin:[http://demo.local] Access-Control-Allow-Methods:[POST] Access-Control-Allow-Headers:[Content-Type]]
2018/04/02 10:19:17 "OPTIONS http://passport.local/api/v1/tracker/fingerprint HTTP/1.0" from <IP_ADDRESS> - 200 0B in 297.2µs
[cors] 2018/04/02 10:19:17 Handler: Actual request
[cors] 2018/04/02 10:19:17   Actual response added headers: map[Vary:[Origin] Access-Control-Allow-Origin:[http://demo.local] Access-Control-Allow-Credentials:[true]]
2018/04/02 10:19:17 - get cookie
2018/04/02 10:19:17 marker=cross-origin <nil>
2018/04/02 10:19:17 -
2018/04/02 10:19:18 "POST http://passport.local/api/v1/tracker/fingerprint HTTP/1.0" from <IP_ADDRESS> - 000 0B in 251.6425ms

https://medium.com/@bluepnume/safaris-new-tracking-rules-and-enabling-cross-domain-data-storage-85241eea7483


Your Repo Doesn't follow Hacktoberfest 2022 rules

Hey,
I think your repo has been excluded from hacktoberfest.

@K4350, I've followed every rule, but I still don't know what's wrong with it.


No matching distribution found for instructor

Describe the bug
Not able to install instructor
To Reproduce
pip install instructor
Expected behavior
Screenshots
My python version is 3.11.7

Thank you @gao-hongnan , my actual version is 3.8.17.  My bad!

BTW, @gao-hongnan  do you know how to update the python version in Jupyterlab? Cause I found my window's python version is 3.11.7, but the Jupyterlab using the 3.8.17.

Hi @xfzhang990, I do not personally use JupyterLab. But your problem will be trickier if you are not using a package manager such as conda because then you have to manage the "switching" of python version yourself.
If you are already managing your virtual environments, then I would think you can do something along these lines (I am using linux/unix based so I am basing the windows command off memory):
python3.11 -m venv my-env
my-env\Scripts\activate
python3.11 -m pip install jupyterlab

Then hopefully you can run your usual jupyterlab command via this virtual environment.
Reference: Jupyter notebook is using different Kernel (python 3.8) from my default python version (Python 3.9) in my machine

Thank you @gao-hongnan! I have used Anaconda instead, it works now.


Mandatory vault prefix configuration

Switch from vault prefix based on repo to mandatory property
The previous repo based auto config was problematic in some contexts where the repo information was last and it's also causing issues with local development.
Fix cli plugin on mac
As part of working on this saw and fixed some tests failing on MAC. We don't run on macs in CI so this went unnoticed.

@imkarrer I would consider that a bug. ElastiConventionsPlugin should only configure things if present. It looks like the vault read is inside a withTask https://github.com/elastic/gradle-plugins/blob/f6b7926f8e73f7de7a89d3b16a126bc7ed116f72/plugins/elastic-conventions/src/main/java/co/elastic/gradle/elastic_conventions/ElasticConventionsPlugin.java#L107 so should only happen if we're actually using a snyk task. For the cloud repo we will be pulling this in (but this was the case with the old plugins too) because component image builds have snyk tasks out of the box .

Yes, especially because we previously did not require it to build the nightly vm images pipelines.  We had to borrow the cloud one to expedite the incident resolution.
https://buildkite.com/elastic/ci-vm-images/builds/5148#018fde52-0dff-4104-8bcf-e519b78b7a85


[CMake] Always disable string processing import

The issue here is that a configuration that has SWIFT_ENABLE_EXPERIMENTAL_STRING_PROCESSING disabled doesn't pass the flag to implicitly disable the module import, but when building the stdlib modules on said configurations, the compiler will try to link them against string processing because, well, it's an implicit import. Just always disable the implicit import for every stdlib module now.
Resolves: rdar://106326062 & rdar://106374161

@swift-ci please test


[WIP] Expose IPTC and XMP in metadata if available

Closes #904

@lovell I didn't see references to the WIP branch like mentioned in Contribution guide, so I've created PR targeting master branch. Feel free to change target branch.

Coverage remained the same at 99.226% when pulling 7a6629405affe454336bbc1a332e1130c7163c4c on oaleynik:feat__iptc-xmp into 358b8fe8b6d53422c77278ab6ee2b1894fd0e451 on lovell:master.

Coverage decreased (-77.2%) to 21.981% when pulling d82dbc03f6c37a1afd986652529d36867bfb96e6 on oaleynik:feat__iptc-xmp into 358b8fe8b6d53422c77278ab6ee2b1894fd0e451 on lovell:master.

Oops, that was my bad with coverage - forgot to remove .only from test.

Rebased and squashed.

Coverage remained the same at 99.226% when pulling 65f3c94465168a7519b6e5dbf9e5df9d9671f2f0 on oaleynik:feat__iptc-xmp into 358b8fe8b6d53422c77278ab6ee2b1894fd0e451 on lovell:master.

Hello, this looks great, thank you. Do you think it's worth adding an assertion that inspects the first byte/word of each Buffer to ensure their contents are as-expected too?

Hello, this looks great, thank you. Do you think it's worth adding an assertion that inspects the first byte/word of each Buffer to ensure their contents are as-expected too?
Update: I'm happy for devDependencies to be added that can parse the metadata for use in the tests.

@lovell I wanted to add some kind of IPTC parser, but I didn't find good implementation for nodejs, which is at least maintained. For use in my main job project I've ended up implementing the custom one (I need to be able to use streams). Not sure if I will be releasing that as independent npm package, but I will definitely think about adding here something like this https://github.com/devongovett/exif-reader/blob/master/index.js#L4

Coverage remained the same at 99.226% when pulling 333765c2e4d9d7d3553745d060b0b198e5a31656 on oaleynik:feat__iptc-xmp into 358b8fe8b6d53422c77278ab6ee2b1894fd0e451 on lovell:master.


how clear the map

there are my code:
pub TokensPowerOf get(fn tokens_power_of): map hasher(blake2_128_concat) T::AccountId => TokenTotalPower;

but when i use the founction "kill", there is a error:
<TokensPowerOf<T>>::kill();
    |                             ^^^^ function or associated item not found in `mine::TokensPowerOf<T>`
    |
    = note: the method `kill` exists but the following trait bounds were not satisfied:
            `mine::TokensPowerOf<T>: sp_api_hidden_includes_construct_runtime::hidden_include::storage::generator::StorageValue<_>`
            which is required by `mine::TokensPowerOf<T>: sp_api_hidden_includes_construct_runtime::hidden_include::StorageValue<_>`
            `&mine::TokensPowerOf<T>: sp_api_hidden_includes_construct_runtime::hidden_include::storage::generator::StorageValue<_>`
            which is required by `&mine::TokensPowerOf<T>: sp_api_hidden_includes_construct_runtime::hidden_include::StorageValue<_>`
            `&mut mine::TokensPowerOf<T>: sp_api_hidden_includes_construct_runtime::hidden_include::storage::generator::StorageValue<_>`
            which is required by `&mut mine::TokensPowerOf<T>: sp_api_hidden_includes_construct_runtime::hidden_include::StorageValue<_>`

Because your storage item is a StoragePrefixedMap you can call remove_all():
https://crates.parity.io/frame_support/storage/trait.StoragePrefixedMap.html#method.remove_all
<TokensPowerOf<T>>::remove_all();


Skipping Tasks?

I feel like I may have missed it somewhere, but is it possible to skip tasks programatically?
As an example, I have a Deploy Supertask that includes PreCheck and GitHubReleasePublic. I want that if the PreCheck identifies a certain condition (such as not finding the API key), to skip the GitHubReleasePublic task, but don't fail the build.
Is this possible or should I do the check in advance before calling Invoke Build and call it using a different task?

It sounds like you need something like this
$doGitHubReleasePublic = $true

task Deploy PreCheck, GitHubReleasePublic

task PreCheck {
    $script:doGitHubReleasePublic = $false
}

task GitHubReleasePublic -If {$doGitHubReleasePublic} {
    "Doing GitHubReleasePublic..."
}

If we run the above script we get GitHubReleasePublic skipped:
    Build Deploy C:\tmp\_180309_032658_ib_121\.build.ps1
    Task /Deploy/PreCheck
    Done /Deploy/PreCheck 00:00:00.0090174
>   Task /Deploy/GitHubReleasePublic skipped.
    Done /Deploy 00:00:00.0330429
    Build succeeded. 2 tasks, 0 errors, 0 warnings 00:00:00.2611698

If we comment out the line $script:doGitHubReleasePublic = $false in PreCheck and run again then:
    Build Deploy C:\tmp\_180309_032658_ib_121\.build.ps1
    Task /Deploy/PreCheck
    Done /Deploy/PreCheck 00:00:00.0095672
>   Task /Deploy/GitHubReleasePublic
>   Doing GitHubReleasePublic...
>   Done /Deploy/GitHubReleasePublic 00:00:00.0030305
    Done /Deploy 00:00:00.0356826
    Build succeeded. 3 tasks, 0 errors, 0 warnings 00:00:00.2599215

Yes, the special $do variables is exactly what I was looking for! Are
these in the wiki or docs? If not I'll add them. Thanks!
On Thu, Mar 8, 2018, 7:41 PM Roman Kuzmin<EMAIL_ADDRESS>wrote:

It sounds like you need something like this
$doGitHubReleasePublic = $true
task Deploy PreCheck, GitHubReleasePublic
task PreCheck {
$script:doGitHubReleasePublic = $false
}
task GitHubReleasePublic -If {$doGitHubReleasePublic} {
"Doing GitHubReleasePublic..."
}
If we run the above script we get GitHubReleasePublic skipped:
Build Deploy C:\tmp\_180309_032658_ib_121\.build.ps1
Task /Deploy/PreCheck
Done /Deploy/PreCheck 00:00:00.0090174

Task /Deploy/GitHubReleasePublic skipped.
Done /Deploy 00:00:00.0330429
Build succeeded. 2 tasks, 0 errors, 0 warnings 00:00:00.2611698

If we comment out the line $script:doGitHubReleasePublic = $false in
PreCheck and run again then:
Build Deploy C:\tmp\_180309_032658_ib_121\.build.ps1
Task /Deploy/PreCheck
Done /Deploy/PreCheck 00:00:00.0095672

Task /Deploy/GitHubReleasePublic
Doing GitHubReleasePublic...
Done /Deploy/GitHubReleasePublic 00:00:00.0030305
Done /Deploy 00:00:00.0356826
Build succeeded. 3 tasks, 0 errors, 0 warnings 00:00:00.2599215

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/nightroman/Invoke-Build/issues/121#issuecomment-371704162,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AOjVUiDXwhjU1uVzbbRi6nvOfJ3KlO1fks5tcfnfgaJpZM4SjpL8
.

A special variable is only one possible way of dealing with conditional tasks.
The concept of conditional tasks is described in help and wiki, I believe.
Wiki: Conditional tasks
Help:
. invoke-build
help task -parameter if

I totally missed the -if parameter part. I have a solution, thank you and closing.


Use /models/ path for api call to update settings

Related to https://github.com/huggingface/moon-landing/pull/3796#discussion_r970751649 (internal url).
Use updated api route for consistency
Previously: ".../api/user/repo_name/settings" and ".../api/datasets/user/repo_name/settings"
Now: ".../api/models/user/repo_name/settings" and ".../api/datasets/user/repo_name/settings"

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


Add documentation for token ring values

Some basic documentation is handy when someone is not as familiar with
the code.
More information can be found at
https://docs.datastax.com/en/dse/6.7/dse-arch/datastax_enterprise/dbArch/archAboutDataDistribute.html

Ooops, I intended to submit this to upstream gocql, but misclicked.


Add outline around input fields in register and login forms

Issue Report
Title
Add outline around input fields in register and login forms
Description
The form fields for in the register and login forms do not have a visible outline, which makes it less clear where the focus is. This issue affects user experience as it's difficult to visually identify the active field.
Steps to Reproduce the Issue
To assist us in understanding and resolving the issue, please outline the steps you took that led to the problem:

Action 1: Go to the register or login page.
Action 2: Observe the input fields for username and password.
Action 3: Focus on one of the fields by clicking or tabbing into it.

Feel free to be as detailed as necessary so we can replicate the issue accurately.
Expected Behavior
The username and password input fields should have a visible outline or border when focused, making them stand out and providing clear visual feedback to the user.
Actual Behavior
The input fields for username and password do not have an outline or border, which makes it difficult to determine where the user's focus is when filling out the form.
Screenshots (if applicable)

Additional Context
Add any other context or information that may help in diagnosing the issue.

Examples
Example 1
Title: Product Search Feature Returns No Results
Description: The product search functionality fails to display any results even for valid search queries.

Steps to Reproduce:

Navigate to the product search bar on the homepage.
Type "Wireless Mouse" into the search field.
Press the Enter key.

Expected Behavior: The system should display a list of products matching "Wireless Mouse."

Actual Behavior: The message "No results found" appears, regardless of valid input.

Example 2
Title: Login Issue with Valid Credentials
Description: Users are experiencing issues logging in, despite entering the correct username and password.

Steps to Reproduce:

Access the login page.
Input a valid username and password.
Click the "Login" button.

Expected Behavior: The user should successfully log in and be redirected to their dashboard.

Actual Behavior: An error message states, "Invalid credentials," preventing access.

Thank you for taking the time to report this issue! We appreciate your help in improving our project.

@sezallagwal not needed


LCP - Missing from audit of page report

Describe the bug
Hi,
i just started using the
@unlighthouse/core
module to extract core-web-vitals for several domains.
And i am not able to extract the metric
largest-contentful-paint
I tried it with the demo page
https://inspect.unlighthouse.dev/
and with the cli tool on my domain both with the same result.
Using page insights for one page returns the standard lighthouse report including the
lcp value.
Reproduction
Use demopage
System Info
System:
    OS: Windows 10 10.0.19044
    CPU: (8) x64 Intel(R) Core(TM) i7-1065G7 CPU @ 1.30GHz
    Memory: 14.58 GB / 31.59 GB
  Binaries:
    Node: 16.13.1 - C:\Program Files\nodejs\node.EXE
    Yarn: 1.22.15 - ~\AppData\Roaming\npm\yarn.CMD
    npm: 8.14.0 - C:\Program Files\nodejs\npm.CMD
  Browsers:
    Edge: Spartan (44.19041.1266.0), Chromium (105.0.1343.33)
    Internet Explorer: 11.0.19041.1566

Used Package Manager
yarn
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guide.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A, please open a GitHub Discussion instead.
[X] The provided reproduction is a minimal reproducible of the bug.

fixed thx Felix

Oh yeh thanks for the issue! This has indeed been fixed


Change end-of-year skip date  2020-12-31;

currently we're skipping the first day of the year, but it looks like it should be the last.
There are  40027 samples  2020-12-31. We should check subsequent years for any major spikes by querying the metadata db.
Probably we want to add a "skip-date" option to the CLI to make this configurable.

Currently we get
   sc2ts.inference: Extend 2021-01-02; ts:nodes=255357;edges=255380;mutations=155012
2024-08-03 05:29:36,625 [3379055] INFO     sc2ts.inference: Got alignments for 2369 of 2799 in metadata
2024-08-03 05:49:06,397 [3379055] INFO     sc2ts.inference: Added 2369 samples to match DB for 2021-01-02; hmm_cost:min=0.0,max=44.0,mean=1.2511608273533137,median=1.0
2024-08-03 05:49:06,400 [3379055] INFO     sc2ts.inference: Loading used samples into DB
2024-08-03 05:49:18,711 [3379055] INFO     sc2ts.inference: DB contains 37687 samples not in ARG
2024-08-03 05:49:19,903 [3379055] INFO     sc2ts.inference: Update ARG with low-cost samples for 2021-01-02
2024-08-03 05:49:19,904 [3379055] INFO     sc2ts.inference: Querying match DB WHERE: match_date=='2021-01-02' and hmm_cost<=5.0
2024-08-03 05:49:22,696 [3379055] INFO     sc2ts.inference: Got 1216 distinct paths for 2288 samples
2024-08-03 05:49:27,204 [3379055] INFO     sc2ts.inference: Pushing reversions for 2090 full-span samples
2024-08-03 05:49:28,506 [3379055] INFO     sc2ts.inference: Push reversions: delete 44 mutations; add 40 new nodes
2024-08-03 05:49:28,849 [3379055] INFO     sc2ts.inference: Coalescing mutations for 2090 full-span samples
2024-08-03 05:49:34,177 [3379055] INFO     sc2ts.inference: Coalescing mutations: delete 128 mutations; add 58 new nodes
2024-08-03 05:49:34,514 [3379055] INFO     sc2ts.inference: Looking for retrospective matches
2024-08-03 05:49:34,515 [3379055] INFO     sc2ts.inference: Querying match DB WHERE: match_date<'2021-01-02' AND match_date>'2020-12-03 00:00:00'
2024-08-03 05:50:15,576 [3379055] INFO     sc2ts.inference: Got 1877 distinct paths for 28294 samples
2024-08-03 06:03:13,117 [3379055] INFO     sc2ts.inference: Pushing reversions for 79 full-span samples
2024-08-03 06:03:14,057 [3379055] INFO     sc2ts.inference: Push reversions: delete 0 mutations; add 0 new nodes
2024-08-03 06:03:14,483 [3379055] INFO     sc2ts.inference: Coalescing mutations for 79 full-span samples
2024-08-03 06:03:15,732 [3379055] INFO     sc2ts.inference: Coalescing mutations: delete 65 mutations; add 19 new nodes

We're almost certainly adding in some time travellers there (unless we really do believe that there were 40X as many sequences collected on the last day of 2020)

This is probably the cause of a false recombinant added on this day (ERR5746594), which ends up having > 700 descendants later.

The samples on 2020-12-31 contain a number of UK strains classified by "Viridian_scorpio" as Omicron and Delta. However, the earliest omicron should be ~ 24 November 2021, and the earliest UK Delta should be 22 February 2021. So these are very likely to be misdated.
It is odd that we have time-travelling UK samples, as you might have thought these would have quite high-quality dates. It could be worth checking the origins, data quality, etc for a few of the e.g. UK Delta or UK Omicron strains on 2020-12-31, to see if we are missing something obvious about the dating problem?


Spark cannot load static resources from jar files.

Spark cannot load static resources from jar files.
spark framework version
compile group:'com.sparkjava', name:'spark-core', version:'2.7.2'

code
staticFileLocation("/public");

gradle run on the console screen
2018-10-24 09:58:46,034 [INFO -spark.staticfiles.StaticFilesConfiguration] StaticResourceHandler configured with folder = /public

java -jar static-file-bug-1.0-SNAPSHOT-jar-with-dependencies.jar
nothing log

Works fine for me in 2.8.0 (although I use Maven). Have you checked the files are actually packed in the jar? Note also that they will be mounted in the URL at /, not /public -- that path is simply the folder in resources where Spark will look.

Also did you run init() to ignite the spark?
Static files location must be configured before route mapping. If your application has no routes, init() must be called manually after location is set.

source: http://sparkjava.com/documentation#static-files

This has worked for a very long time and changes to this functionality has not been done in quite a while. Closing for now.


Return the old design

I really don't like new design, which starts from version 1.9.5 because of borders, which looks really shitty. Also I don't like non-full screen settings page

I can maybe add a switch to it, if you wanttt so

Enjoy

Thanks a lot


Param cleanup 2

Following parameter changes have been implemented:

CAMDeploymentBlobSource has been removed from all templates. Only binaryLocation exists where the DSC configuration and the nvidia driver are sourced from.
All artifactsLocation and artifactsLocationSasToken parameters from the remote-workstation templates have been removed. Only the userStorageAccountName, userStorageAccountUri, userStorageAccountSasToken and userStorageAccountKey parameters are used instead. The windows agents use the userStorageAccountUri and SasToken params whereas the linux agent uses the userStorageAccountName and Key params (same as before).

Also not you have merge conflicts so should pull from master. (Might be the same lines you need to change, actually...)


Include  and  queries in Graphql Codegen

What
Support for Graphql Codegen
Description
I've made a Graphql Codegen custom loader for <page-query> and <static-query> blocks. In other words, you can run graphql codegen and include the queries from those custom blocks in it. That way, if you're using TypeScript, you can add proper typing to the result available on $page or $static.
I've created this issue to give it some visibility, so it can be discovered if people are searching for similar solutions.
I wanted to ask if there's part in the docs where this could be documented. If not, we can close this issue.

Could you maybe add some more info to your README about the purpose? Why and when would I use it? Maybe a more complete example would already help. Thanks.


UI glitch: Reduce size of "Experimental" - releveant for Prisma Migrate

Happens on Firefox and Chrome on macOS

@Jolg42 : Isn't this a duplicate of #322?

Yes indeed, closing :)


修复insert values包含小数, parent错误的问题

https://github.com/alibaba/druid/issues/5483

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Test against latest Django & Python versions

Updates the Tox and Travis CI configurations, as well as the test project, to run tests with the latest officially supported combinations of Django and Python.
This implicitly drops support for Python 3.3.

Merging this update of the test environment. I've also updated the README and HISTORY.
@rosarior Maybe it makes sense to make a new release on PyPI now?


spirv-opt: skips if_conversion when dontflatten is set

Hi, we may mark some if statement as [flatten]/[branch] when cross compiling shader to bypass certain bugs.
I found that if_conversion pass ignores [branch] tag when performing optimizations.
I guess if_conversion should skip the optimization when an if statement is marked as [branch]?

Sorry, I rebased your change to get all of the tests to pass, but I forgot I wanted you to make a change.  I hope it does not mess you up too much.

Sorry, I rebased your change to get all of the tests to pass, but I forgot I wanted you to make a change. I hope it does not mess you up too much.

Sorry for my late reply. Sure, I've added the required test case,


This helps finding packages with bad utf

Checking hundreds of possibly installed packages manually should NOT be expected of the user ;)

Excellent. Thanks for the contrib.
One concern I have - what if there are clients relying on the UnicodeDecodeError to trap such exceptions? Perhaps that's unlikely and this would be safe. Let's roll it out and see.
 Given that Python 3 has built-in exception chaining, I'm more inclined to go with a simple raise Exception("Invalid encoding on package metadata %s" % self.path) and let the user re-run the decoding on Python 2 if they need to trace the invalid characters.


Fix binary to support project flag properly

If you used the project flag and defined a project to use, he would fail to select the project and assume the project was undefined.
Example:

@mAiNiNfEcTiOn thanks!

@tinganho ;-) My pleasure...

Forgot to mention that it is now published on npm. Just sudo npm install l10ns -g and you will get your changes.


convert cli processing to use click

Restructure the step-by-step commands in anticipation of adding some
new all-in-one commands that provide a higher-level interface.

@mergifyio refresh


HDDS-3651 Add tests for SCMRatisRequest.

What changes were proposed in this pull request?
HDDS-3651 Add tests for SCMRatisRequest.
(Please fill in changes proposed in this fix)
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-3651
(Please create an issue in ASF JIRA before opening a pull request,
and you need to set the title of the pull request which starts with
the corresponding JIRA issue number. (e.g. HDDS-XXXX. Fix a typo in YYY.)
Please replace this section with the link to the Apache JIRA)
How was this patch tested?
UT
(Please explain how this patch was tested. Ex: unit tests, manual tests)
(If this patch involves UI changes, please attach a screen-shot; otherwise, remove this)

+1.


new components not getting styled!

When we add new components that haven't been on the page before, we're doing a PUT to a client-side-generated URI and rendering them client-side through their template. Unfortunately, this means we're not pulling in the component styles!

fixed in commit 2fc2f88


Built target resource
이런 결과가 나오고, 이다음 !make install 실행 시,
[ 57%] Built target obj_khaiii
[ 61%] Built target khaiii
[ 69%] Built target bin_khaiii
[ 92%] Built target test_khaiii
Install the project...
-- Install configuration: ""
-- Up-to-date: /usr/local/include/khaiii
-- Installing: /usr/local/include/khaiii/KhaiiiApi.hpp
-- Installing: /usr/local/include/khaiii/khaiii_api.h
-- Installing: /usr/local/include/khaiii/khaiii_dev.h
CMake Error at cmake_install.cmake:50 (file):
file INSTALL cannot find "/content/drive/MyDrive/Colab
Notebooks/NLP/preprocess/khaiii/build/share/khaiii": No such file or
directory.
make: *** [Makefile:130: install] Error 1
이런 오류가 발생합니다.
제가 보기엔 !make resource 과정에서 build에 share 디렉토리가 생기지 않는 것이 문제인데 왜 생기지 않는 것인지 궁금합니다

죄송합니다. 너무 늦게 봤네요.
보여주신 내용만으로는 make resource 명령에서 어떤 오류가 발생했는지 파악이 힘듭니다.
재현이 되는 colab 노트북을 공유해 주시면 제가 테스트 해보겠습니다.


Fixed wrong key usage for finish message when using early data

When I used TLS-Attacker in client mode for testing early data, I found that the server side couldn't decrypt the Finished Message in the second handshake.
How to reproduce

Start server: openssl s_server -cert ./server_cert.pem -key ./server_key.pem -tls1_3 -early_data -no_anti_replay -trace

hint: -anit_replay is only active because the client won't close the connection with close_notify and I want to prevent that s_server is throwing away the session information

Start TLS-Attacker client: java -jar ./apps/TLS-Client.jar -connect localhost:4433 -config ./tls13_0rtt_short.txt
tls13_0rtt_short.txt

Error on server side:
ERROR
80609AF601000000:error:0A000119:SSL routines:tls_get_more_records:decryption failed or bad record mac:ssl/record/methods/tls_common.c:859:
80609AF601000000:error:0A000139:SSL routines::record layer failure:ssl/record/rec_layer_s3.c:650:
shutting down SSL
CONNECTION CLOSED

After some digging I think I found the root cause. The Finished message is encrypted with the same key as the EndOfEarlyData message. To see this, you can put
System.out.println(
    "Key used for encryption: "
    + Arrays.toString(
        getState().getKeySet().getWriteKey(getConnectionEndType())
));

at the beginning of public void encrypt(Record record) throws CryptoException { } in "TLS-Core/src/main/java/de/rub/nds/tlsattacker/core/record/cipher/RecordAEADCipher.java"
But EndOfEarlyData message needs to be encrypted under client_early_traffic_secret and the Finished message with client_handshake_traffic_secret (compare RFC8446, chapter 4.5 and 7.3).

I implemented a rough workaround to fix the client behavior in the second handshake flow. Roughly speaking, at the point where the client receives the server's Finish message, we precalculate the handshake_traffic_secret and store it in TlsContext (see FinishHandler.java) even though the next secret to be used is early_traffic_secret for sending EndOfEarlyData message.
When this message is sent out, we set the active key set to the stored handshake_traffic_secret so that the following Finish message sent by the client to the server is correctly encrypted (see EndOfEarlyDataHandler.java)

Disclaimer: This is working when using TLS-Attacker in client mode but not yet for the server mode. I will update this draft PR accordingly.

PR is available on TLS-Attacker Development: https://github.com/tls-attacker/TLS-Attacker-Development/pull/1142


Timestamp column editing scale doesn't persist

System information:
Windows 10
DBeaver version 6.2.4
Connection specification:
Postgres 11
Describe the problem you're observing:
Steps to reproduce, if exist:
Setting scale for a timestamp doesn't save the timestamp. This is needed to remove the microseconds from a timestamp field in postgres. I mostly use this to set it to zero, but it also doesn't work with positive numbers.

That resulting command should be
ALTER TABLE exacttarget.message ALTER COLUMN update_date TYPE timestamp(0) USING update_date::timestamp;

Fixed

verified


Feature tour enhancements

Remove JS error when no tour object exists
Update hopscotch to avoid multiple highlight containers being added even when one already exists or the tour isn't active.

This looks good, but there are still a bunch of situations where the tour popups get hidden. Notably, the prisoner number column's tour tip on a browser window at 800×600, but there are others too. Do we care for this PR?

Yeah, I'm not 100% happy with how the popups are handled on smaller resolutions. The current style for the box assumes it should come off the middle of the element which means some, like the prisoner number, can get cut off the screen slightly.
Probably should have a look in this branch.

LGTM now :+1:


Function attributes have no scope

Was broken in c8dc0226b485ee7b5740d5de2117a6f408c42510.

Fixed in https://github.com/0x9ef/vscode-vlang/commit/3e8f67f2abcb8e9ad8903b523ba8fd0ad16b4f67


Potential issue with Babel / Recursion in Aurelia View-Model

I am very new to Aurelia, and ES6 for that matter.  I hope this question doesn't fall into the noob category.
I am trying to take Aurelia on a test drive, by attempting to build some fairly complex custom components, one of which is a generic grid control supporting pagination, filtering, and grouping.  In the process of attempting to implement the grouping capability, I'm using the Lodash framework to recursively iterate over an array of objects, producing a nested collection of objects grouped on 1..n property values from the original array.
I implemented a function on my view-model class to perform the grouping.  The function looks like this:
// Takes object elements of an array and groups them based on
// one or more attribute values
// Source:  https://gist.github.com/joyrexus/9837596
nest(seq, keys) {
    if (!keys.length)
        return seq;
    var first = keys[0];
    var rest = keys.slice(1);
    return _.mapValues(_.groupBy(seq, first), function (value) {
        return nest(value, rest);
    });
}

When I attempt to invoke the nest function, I am seeing an error that indicates the attempt to recursively call itself fails.  Yet, I know this bit of code works by itself, as the author provided a link to a JSFiddle implementation of it that clearly demonstrates that it works.  The error I'm seeing when attempting to invoke this function within my view-model is:
ReferenceError: Can't find variable: nest
Are there any limitations associated with Aurelia regarding this type of recursive call?

I think I submitted this in the wrong location.


npms.io site down

npms.io seems to be down currently

I'm aware. The disk is full and I can't access the machine. Will try to recover. Alternatively I'be asked npmjs to host the API and the badges API on their end.
Will update this issue when I got more info.

I think if npmjs can host this that would be great and would reduce the pressure on you. keep up the good work

It has been fixed. Sorry for the inconvenience.

Thanks a lot
On Sat, 17 Jun 2017, 12:52 am André Cruz<EMAIL_ADDRESS>wrote:

Closed #174 https://github.com/npms-io/npms-www/issues/174.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/npms-io/npms-www/issues/174#event-1127620482, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABDlF_4KflBU1ZY1aMIPEusSaC-Ogy_Wks5sEwRcgaJpZM4N8bJ9
.


Python no internet connection and browser closes

https://github.com/simonfarah/tiktok-bot/issues/73#issuecomment-1693302211


Couldn't find librtsp.so

Hi Team
After using this library i am getting couldn't find "librtsp.so"

Can anyone please me finding this library

the same problem! how fix this problem?

服了，少.so文件


add chmod method

change directory mode recursively

Coverage decreased (-0.5%) to 53.465% when pulling 777fb61847f22be52995f113cd8a7fa6a612ef44 on Agnewee:master into a7f713484575001169746e81beda7dd604921eef on Prodesire:master.

Coverage decreased (-0.3%) to 53.702% when pulling 7dd5a41186788025fc323bb77ae7010130f8acee on Agnewee:master into 6c2fb2a7da4829fce6787efc62e61423486d81b2 on Prodesire:master.

I merged with command line and improved chmod. Maybe it is Github's bug that not closed this pull request automatically. I will close it anyway.


Added support for TrackingToken parameter in SagaTestFixture

This change allows annotated Sagas that rely on the TrackingToken parameter in their event handler methods to be tested with the Saga Test Fixture. Each event is wrapped in a TrackedEventMessage with a monotonically increasing sequence number.

Although I understand how this ensures the TrackingToken becomes a supported parameter in the SagaTestFixture, this wouldn't give the user direct control over what that token is during testing. Wouldn't that proof impractical?

After giving it some additional thought, I think my previous point doesn't really matter.
As it stands, the fixture is a clean-slate start anyhow. It is unaware of events that aren't part of the fixture.
So, by incrementing a global index value for every handled event, as is done in this PR, will align with the scope of the fixture.


Reduce strictness in changelog format

1. Why is this change necessary?
This allows less strict changelog files as those should be readable in other markdown renderers e.g. on code hosting services as well as in shopware.
# Changelog

## 1.0.0
- Initial setup

### 1.1.0

 * This is a very great feature
 ** Part of this feature is an additional indention

2. What does this change do, exactly?
Change substrings against trims to allow similar effect (removing symbols on the left side of a line).
3. Describe each step to reproduce the issue or behaviour.

Use an open source plugin with a similar changelog like in point 1
Publish it on github
Improve rendering for github markdown renderer
Prepare it for community store release
Get a hint that there is a built-in changelog reader that is not able parse the changelog file

4. Checklist

[ ] I have written tests and verified that they fail without my change
[x] I have squashed any insignificant commits
[ ] I have written or adjusted the documentation according to my changes
[ ] This change has comments for package types, values, functions, and non-obvious lines of code
[x] I have read the contribution requirements and fulfil them.

is there no test for the ChangelogParser? :thinking:

I get the test hint 😁

@jkrzefski just asked why no one is using the normalized changelog format https://keepachangelog.com/en/1.1.0/
Wouldn't that be a cool thing? It is human and machine readable. Or is this too much to enforce for a plugin manufacturer?

@JoshuaBehrens I wanted to introduce that standard, but there were people against it, because it has too much "features". so a simpler format was introduced :blush:

KISS ok

I followed your comments and changed the code

Hello,
thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/NEXT-9268
Please use this issue to track the state of your pull request.

@JoshuaBehrens
unfortunately the format with two signs (--, **) is not readable through most markdown readers. test in https://markdown-it.github.io/ so we will close this PR.
To test against full featured markdown, the parser needs to be changed much more.
thank you for your contribution anyways
👍

I understand that the list token repetition is uncommon for markdown but the indention with whitespaces instead is common and this is not possible by default but is covered by this pull request. The header token repetition for headlines is also covered by this pull request. Are these changes worthy to be merged?

Are these changes worthy to be merged?
Hi @JoshuaBehrens
we will discuss this and come back to you when we know what to do with your PR

thank you 👍


Chralu/issue41

fixes #41
This solution is a proposal.
It reflects the Web3modal config API :

creation of a Config is done through Web3Modal.defaultWagmiConfig
Config is retained on the Dart side.
Config must be passed as parameter to each action.

For now, the only action to use that mecanism is getAccount.
@kaumudpa any thoughts ?

This could be one approach.
What i had in mind was something like.
1.lets keep 1 default config as we currently have. This default config will be used by default by all the action unless we specify other config with an action.

Also Keep this ability of yours to spawn config as necessary.

Introduce a Transport only config.

Acrions will use default config if any other config is not provided.

@Chralu help me understand your solution here please. - I am kind of confused with your implementation.

There are two new objects :

JSWagmiConfig : a wagmi config
JSAppKit : a web3modal instance

Those objects are created by Web3Modal/Wagmi JS functions.
The dart code retrieves and uses the JS*** objects : There is no conversion to Dart types, but I added two alias types WagmiConfig and AppKit.
I did not convert JS objects to Dart ones to avoid losing data, and that way it seems we are keeping a reference to the JS object.
I'm not sure about the internal behavior of JS references, but this seems to "work" ...

Hi @Chralu
Can you please look into this https://github.com/0xMetaLab/wagmi_flutter_web/tree/TransportConfig and let me know your views?

https://github.com/0xMetaLab/wagmi_flutter_web/tree/TransportConfig

@Chralu  Please check #44

@kaumudpa I have finished that implementation.
In the example app, there are two wagmi configurations objects declared.
You can use the one you want in each wagmi call.
The Test switch config tab demonstrates this.

Hi @Chralu This looks good to me. Lets get this merged.


Autosubstitution depends on packages pulled in by default by the Microsoft.Quantum.Sdk

Describe the bug
To keep repo dependencies clean, no packages in qsharp-runtime can have dependencies on QuantumLibraries, as the dependencies need to flow just one way.
By default, though, the Microsoft.Quantum.Sdk adds dependencies to Standard unless turned off by the
IncludeQSharpCorePackages property, so this property is required in all projects on the qsharp-runtime repo.
To Reproduce
Check the package dependencies in either VS or nuget, and check that Standard is marked as dependency.

Related PR: https://github.com/microsoft/qsharp-runtime/pull/742

The fact that it also depends on the C# generation that is pulled in by the Sdk may cause the rewrite step to not load properly as part of the added tests as well.

Addressed with https://github.com/microsoft/qsharp-runtime/pull/748.


Update to TypeScript 1.5.3

Hello and thank you.
Can you please update the plugin to TypeScript version 1.5.3?
Thank you.

Released to central as 0.1.7.  Please let me know if you have any problems.

Hello.
Testing it now (no config, defaults). I have 1 file:
app/assets/javascripts/app.ts
I see it is compiled and copied into
target/web/typescript/main/javascripts/app.js
With that I see app.ts is also copied into:
target/web/public/main/javascripts/app.ts
So referencing app.js in 'main.scala.html':
<script src="@routes.Assets.versioned("javascripts/app.js")"></script>
gives 404.
Is this it is supposed to be?
I see that coffeescript file test.coffee is copied into:
target/web/coffeescript/main/javascripts/test.js
and also into:
target/web/public/main/javascripts/test.js.

Strangely enough after I have added test.coffee file, the compilation started to copy app.js to:
target/web/public/main/javascripts/app.js
and continued even when I removed the test.coffee.
But enabling sourceMaps in build.sbt:
TypescriptKeys.sourceMap := true
does not copy the app.js.map to:
target/web/public/main/javascripts/app.js.map
but only to
target/web/typescript/main/javascripts/app.js.map

It seems that the transpiled .js files are not copied to the public folder on Windows

That might be caused by #5.  Do you have a non-windows box to test on?

On non Windows I see that all is Ok except that .map file is not copies into target/web/public/main/javascripts/ folder.

Would you mind filing an issue about the .map file problem?  I'd love to tackle that as a separate issue.

I have just opened an issue on source maps.
Thank you.


feat: added linkTarget to md-text

Awesome, thank you!

Published to npm as<EMAIL_ADDRESS>


added comments in app.py

As far as adding documentation strings, might be helpful to look at the holy bible we call PEP8.

Got it, will check it out.


Implement state provider for OAuth2 protocol

Currently, to prevent the client for CSRF attacks as described in the OAuth2 RFC, the OAuth2 provider stores the state on the application side in the cache. So when using a clustered environment a distributed cache instance must be used. This pull request removes this cache dependency in favor of an abstract solution to handle the state on applications side. It comes with a session state provider that can store the state in the session to follow Play's stateless approach.

why are I saving oauth2 state in cookie, but not in session?

The Play session is also saved in a cookie. And by using an extra cookie we do not need to implement an expire strategy, because a cookie has such a strategy already implemented?


Remove encoder debounce 'fix' and fix interrupt triggers

Remove the debounce time in code that is unnecessary after physically shorting U8 and U12 on the powerboard.
Change interrupt triggers from rising edge to rising+falling edge.
Properly limit the main LLI loop to 100Hz.

@nilskiefer, thoughts?

This way, we can ensure the publisher's frequency without halting the entire loop.

It's a good idea and it sounds like something that should be implemented in a separate PR. I don't think it belongs in this PR since it substantially changes the publishing behaviour and should be tested accordingly. For this, I would say it is important to have clarity on what causes the remaining issues surrounding this code:

Every once in a while (~20 seconds) when using the remote control in override mode, the vehicle will hang for several seconds on the same remote input.
In some cases, connecting a serial reader will freeze the remote input on the vehicle completely. The input unfreezes sometimes when disconnecting the serial reader and sometimes not at all.

These issues were present before this PR and still linger. They are potentially dangerous if the vehicle gets stuck while driving towards obstacles. They appear to be related to using millis() vs micros() and delay() vs delayMicroseconds() and vary with the configured loop time (typically shorter causes more of these issues than longer) and how many serial publishers are active. The current PR works well when the IMU publishers are commented out while the encoders are active (this is sufficient for my purposes). I should note here that occasionally a 10ms loop time will cause problems and 15ms is safer, I can update that. Let me know if anything else needs to be changed that falls within the scope of these changes.

Fair enough! If it works, it works!


Added PAC update for new fields

Adds the PAC changes for the updated SVD file. Peripheral clock enable register now has named fields

bors r+


Dependencies sub nodes have objects for opening properties and View in object browser

I would expect this to only have "Scope to this" and "New Solution Explorer View"

It's just one users opinion, but personally I find the dependency type nodes hide the information I want to see. For me, the icons already provide a fairly clear distinction, and having to drill down into multiple hierarchies to get the full picture is more of an annoyance (albeit a minor one).

@lorcanmooney Thanks for your opinion.


Modify the schema-editor-files component so it can accept zip files

Introduction
For the custom-code tool we need the files component to be able to accept a zip file. The idea is that it is possible to upload a zip file contain all code/markup/style/images for the project.
Implementation
At the moment the files component is only able to handle single file uploads. The schema has to look like this (example usage in q-quiz).
We want to be able to define the schema in the following way to upload a zip file:
{
  "title": "Upload Zip file",
  "type": "object",
  "Q:type": "files",
  "Q:options": {
    "maxFiles": 1,
    "acceptedFiles": "application/zip",
    "fileProperties": {
      "url": "url"
    }
  }
}

Link to code for schema-editor-files component: https://github.com/nzzdev/Q-editor/blob/dev/client/src/elements/schema-editor/schema-editor-files.js

What is the exact plan here?

Extract the files in Q-Editor before uploading to the server

Extract the files in Q-server before storing to S3

Store the zip file as is on S3

should be possible already with the acceptedFiles property that takes a MIME type and configures dropzone accordingly

Re 1. and 2.: I am not sure if the gain is worth the added complexity. I see that we should be able to handle uploading a folder somehow. Can we discuss this before spending too much time implementing the special zip handling?

I will close this because we decided to not implement uploading the project files using a zip file -> see https://github.com/nzzdev/Q-editor/issues/155 for more infos


D400 Inter Camera HW Sync

Required Info

Camera Model
D415

Firmware Version
5.9.13

Operating System & Version
Win10

Kernel Version (Linux Only)
-

Platform
PC

SDK Version
2.13.0

Language
C/C++

Segment
FVV}

Issue Description
Hello,
I'd like to ask if the Inter Camera HW Sync is really available. There is an rs2_option added in the latest SDK (v2.13.0: https://github.com/IntelRealSense/librealsense/releases). However, the recommended FW version according to this release is 5.9.14. When you go to the available FWs (https://realsense.intel.com/intel-realsense-downloads/#firmware) you can see that the latest FW is 5.9.11. When you click on it (https://downloadcenter.intel.com/download/27792/Latest-Firmware-for-Intel-RealSense-D400-Product-Family), you can see that the latest available FW is 5.9.13. So I updated one my devices FW to 5.9.13.
When I run the following code:
#include <librealsense2/rs.h>
#include <librealsense2/rs_advanced_mode.hpp>
#include <iostream>

int main()
{
	rs2::context cxt;
	rs2::device dev = cxt.query_devices().back();
	auto sensors = dev.as<rs400::advanced_mode>().query_sensors();

	for (auto sensor : sensors) {
		std::cout << sensor.get_info(rs2_camera_info::RS2_CAMERA_INFO_RECOMMENDED_FIRMWARE_VERSION) << std::endl;
		std::cout << sensor.get_info(rs2_camera_info::RS2_CAMERA_INFO_FIRMWARE_VERSION) << std::endl;
		std::cout << sensor.supports(RS2_OPTION_INTER_CAM_SYNC_MODE) << std::endl;
	}

    return std::getchar();
}

I get:
<IP_ADDRESS>
<IP_ADDRESS>
0
<IP_ADDRESS>
<IP_ADDRESS>
0

From which I conclude that the FW does not support Inter Camera HW Sync. Any help or information is really appreciated.

Correct. We are currently working on validating and releasing new FW that includes this multicamera sync.

@agrunnet Thank for the reply.


Replace callbacks with promises in tests

Due to some well-known bugs with the test frameworks (supertest-as-promised and chai-http, for example), we were forced to use a callback-based approach in our tests (e.g., getRoot.js). The tests were always passing when using a promise-based approach, swallowing all errors.
We figured it's better to have tests that use callbacks and work than tests that use promises and don't work... but eventually we want tests that use promises and also actually work ;-)

Good idea, but we're not going to get to this any time soon. Closing it.


SendGrid Segmentation Query Language Reference

Description of the change:
Reason for the change:
Link to original source:

Closes #

Hello @Whatthefoxsays,Thanks again for the PR! We appreciate your contribution and look forward to                                              continued collaboration. Thanks!                                             Team SendGrid DX


Ext auth service : remove split_words to honor KOURIER_EXTAUTHZ* env vars

Changes
:bug: Ext auth service : remove split_words to honor KOURIER_EXTAUTHZ* env vars
/kind bug
With this fix, KOURIER_EXTAUTHZ_FAILUREMODEALLOW and KOURIER_EXTAUTHZ_MAXREQUESTBYTES env vars are honored as the docs states. Before that, users should set KOURIER_EXTAUTHZ_FAILURE_MODE_ALLOW and KOURIER_EXTAUTHZ_MAX_REQUEST_BYTES (notice the separating _) to change those parameters (see envconfig split_words documentation).

Release Note
No impacts on clients if they were following the config of ext auth in the README.md.
Docs
No docs.

Hello @nak3 !
As of now, if users are following this part in the README.md:

KOURIER_EXTAUTHZ_FAILUREMODEALLOW*: Allow traffic to go through if the ext auth service is down. Accepts true/false
KOURIER_EXTAUTHZ_MAXREQUESTBYTES: Max request bytes, if not set, defaults to 8192 Bytes. More info Envoy Docs

Then their parameters are not used in Kourier. But there is no error, so users could think that they have correctly change the parameters.
To be taken into account by Kourier, they have to set instead:

KOURIER_EXTAUTHZ_FAILURE_MODE_ALLOW
KOURIER_EXTAUTHZ_MAX_REQUEST_BYTES

which is not documented anywhere. They have to dig into the code to find those values.
I have changed the actual behavior instead of the docs, because I don't want this to be a breaking change for former users of KOURIER_EXTAUTHZ_FAILUREMODEALLOW and KOURIER_EXTAUTHZ_MAXREQUESTBYTES. To my opinion (but I might be wrong), people tend to follow the docs instead of diving into the source code.
Anyway, both approaches are ok, so tell me the approach you prefer! Note that if we change the docs, we have to inform users using these env vars to change them (add underscores).

/ok-to-test
Thank you for your explanation.
In addition to your comment, as per this commit history https://github.com/knative-sandbox/net-kourier/commit/2926c6a4461c3cf087face6c8b31c4cf3e5e1eec, KOURIER_EXTAUTHZ_FAILUREMODEALLOW and KOURIER_EXTAUTHZ_MAXREQUESTBYTES were originally expected (you might already know :sweat_smile: ), so let's use your change.

@norbjd Just in case, is it alright to merge this after v1.3 release? Today is the v1.3 release day (I think it will start when US folks are on-line) so I am hesitate to merge this just before the release.

That's ok for me @nak3 ! Let's merge this after the v1.3.0 release :wink:

/lgtm
/approve


docs: README edition guidelines

Duplicate with
https://github.com/ipfs/awesome-ipfs/pull/175

Is it? #175 doesn't tell you how to edit the README structure itself. It's about adding a new item to the list

Lets have this discussion in #154!


export name ReactComponent to help people migrate from create-react-app

refs https://create-react-app.dev/docs/adding-images-fonts-and-files/#adding-svgs

Second here.
@ArnaudBarre is it possible to implement this fallback?

I can add this, but on the opposite it would be a lie to make it work like the webpack loader because url is not the same syntax either (and Vite philosophy is to used import syntax to do that, not provide both do tree shaking afterward).
I think it's pretty easy to migrate with a regex CMD+R:

import { ReactComponent as ([\S]+) }
import $1

Without space in curly braces

import {ReactComponent as ([^}]+)}
import $1

Tell me what you think about this migration path

I can add this, but on the opposite it would be a lie to make it work like the webpack loader because url is not the same syntax either (and Vite philosophy is to used import syntax to do that, not provide both do tree shaking afterward).
I think it's pretty easy to migrate with a regex CMD+R:

import { ReactComponent as ([\S]+) }
import $1

Without space in curly braces

import {ReactComponent as ([^}]+)}
import $1

Tell me what you think about this migration path

Thank you for response.
Is it possible to use images like react component? Like  in code?

No Vite is "just" a toolchain, not a meta framework like Next or Gatsby, so there is no image component.
But like in CRA, you can import images and use a raw image tag:
import imageUrl from "./myImage.png" // always work in Vite
import mySvgAsUrl from "./mySvg.svg?inline" // with this plugin

...

return <img src={imageUrl} />

Thanks your for suggestion. We originally hoped to migrate without modifying the source code, but your idea is also operational. Thanks again!


feat(api): add register static method #51, update not to omit the file extension on import line #52

Alaska Airlines Pull Request
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Resolves: #51 #52
Summary:

Update dependency versions
Update not to omit the file extension on import line
AuroNav.register is to easily register the element without extra importing
import "@aurodesignsystem/auro-nav" will still register this element to
import { AuroNav } from '../src/auro-nav.js wont register this element until AuroNav.register gets called
Same change on AuroBreadcrumb and AuroAnchorlink
Update AuroNav to work with customized AuroBreadcrumb and AuroAnchorlink

Type of change:
Please delete options that are not relevant.

[x] New capability
[x] Revision of an existing capability
[ ] Infrastructure change (automation, etc.)
[ ] Other (please elaborate)

Checklist:

[x] My update follows the CONTRIBUTING guidelines of this project
[x] I have performed a self-review of my own update

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Auro Design System Team
Summary by Sourcery
Add a static register method to AuroNav, AuroBreadcrumb, and AuroAnchorlink components for custom element registration. Update import statements to include file extensions and enhance AuroNav compatibility with customized components. Update build configuration to include demo examples and enhance documentation with usage guidelines.
New Features:

Introduce a static register method for AuroNav, AuroBreadcrumb, and AuroAnchorlink components to allow custom element registration with unique names.

Enhancements:

Update import statements to include file extensions, ensuring compatibility and clarity in module imports.
Enhance AuroNav to work seamlessly with customized AuroBreadcrumb and AuroAnchorlink components.

Build:

Add new Rollup configurations for building demo index and API examples, generating minified JavaScript files.

Documentation:

Add documentation on recommended use and version control for Auro components, including examples of using the new register method.

:tada: This PR is included in version 2.1.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Default page served isn't configurable and lacks search / listAll functionality

As a new user, exploration of a API is faster if the user can search for endpoints or expand all (not fully, just to list).
The swagger-ui.html file is not configurable in anyway so adding this would requires serving your own copy of the file. Some options that should be accessible are docExpansion, javascript at the end of the page or a div for some custom html.
The default swagger-ui.html should include a button to expand all to list view. Here is a javascript bookmarklet doing this:
javascript:(function(){
  if (window.swaggerUi.getOption('docExpansion') === 'list') {
    window.swaggerUi.collapseAll();
    window.swaggerUi.setOption('docExpansion', 'none');
  } else {
    window.swaggerUi.listAll();
    window.swaggerUi.setOption('docExpansion', 'list');
  }
})();

The default swagger-ui.html should include a searchbox of the api. Here is a bookmarklet using the API key box to do this (taken from this swagger-ui bug):
javascript:(function(){

    var checkEmptyResources = function() {
        return $('.resource').each(function(i, res) {
          var visibleChildren;
          visibleChildren = $(res).find('.operation').filter(function(ii, op) {
            return $(op).css('display') !== 'none';
          });
          if (visibleChildren.size() <= 0) {
            return $(res).hide();
          } else {
            return $(res).show();
          }
        });
    };

    var pattern, searchterm;
    searchterm = $('#input_apiKey').val();
    pattern = new RegExp(searchterm, 'i');
    $('.operation').each(function(i, op) {
      var opDescription, opID, opSummary;
      opID = $(op).prop('id');
      opSummary = $(op).find('a.toggleOperation').text();
      opDescription = $(op).find('.markdown p').text();
      if ((pattern.test(opID)) || (pattern.test(opSummary)) || (pattern.test(opDescription))) {
        return $(op).show();
      } else {
        return $(op).hide();
      }
    });
    return checkEmptyResources();
})();

Noted that swagger-ui are working on adjusting their javascript library to add this but that doesn't change:

the ease of changing swagger-ui.html for someone who would rather be working on something else,
this being a trivial change to a default file that users can't configure in this repository that will have value to most users of the final served page.

These are great ideas :metal:. Would love to get a PR since you're more familiar with this than I admit to being.
Having said that, the swagger-ui that ships with this library is more of a convenience for spring framework users rather than a full blown customized swagger-ui. The fewer customizations to the script the better we stand at taking upgrades from the mother ship.

Oh yeah, it would only be an alterations to  swagger-ui.html. I'll work on an PR for you.

also have a look at this pr

Thank you.


Fixed #31880 -- Raised error when aggregation alias overrides existing annotation

Ticket: https://code.djangoproject.com/ticket/31880
(First implementation: https://github.com/django/django/pull/13390)
Suggested patch for the discussion https://code.djangoproject.com/ticket/31880#comment:7

@jacobtylerwalls proposed the same solution to fix ticket-31679, see #13273. My initial response was that it's too restrictive. I was thinking about checking that an aggregation overrides and uses the same aliases :thinking:. If it's not feasible or it's too complicated then I'm fine with this patch but we should add a backward incompatible note.

Hi @felixxm
The patch is indeed exactly the same :P And I agree that it is too restrictive.
I tried to focus back on the issue at hand:
Considering Author.objects.annotate(age_alias=F('age')).aggregate(age=Sum(F('age_alias')), avg_age=Avg(F('age'))),  the last aggregation is referring to the aggregation made just before, in the same aggregate call.
This should be less restrictive and still allow currently working QuerySets like Author.objects.annotate(age_alias=F('age')).aggregate(age_alias=Sum(F('age_alias')).
But still prevent the initial problem presented in the ticket https://code.djangoproject.com/ticket/31880
What do you think about this approach? :thinking:

@felixxm Merged the suggestions into one commit, thanks!

@David-Wobrock Thanks :+1:


[MTDSA-209] [DM] Add SaUtr path binder to validate SA UTRs provided in paths

Uses a hard coded UTR which is currently publicly available on the API developer hub.

👍


Fail to finish integration

Just reinstalled a fresh HA and tried this extension with no success:
Despite the modification on configuration (see here after remarks) the extension does not start
 WARNING (MainThread) [homeassistant.bootstrap] Waiting on integrations to complete setup: sensor.enedis
2022-10-15 19:40:22.388 WARNING (MainThread) [homeassistant.components.sensor] Timed out adding entities for domain sensor with platform enedis after 500s
2022-10-15 19:40:22.429 ERROR (MainThread) [homeassistant.helpers.event] Error while processing template: Template("{{ states.sensor.enedis_teleinfo.attributes["PRM"] }}")
Traceback (most recent call last):
  File "/srv/homeassistant/lib/python3.9/site-packages/homeassistant/helpers/template.py", line 420, in async_render
    render_result = _render_with_context(self.template, compiled, **kwargs)
  File "/srv/homeassistant/lib/python3.9/site-packages/homeassistant/helpers/template.py", line 1915, in _render_with_context
    return template.render(**kwargs)
  File "/srv/homeassistant/lib/python3.9/site-packages/jinja2/environment.py", line 1301, in render
    self.environment.handle_exception()
  File "/srv/homeassistant/lib/python3.9/site-packages/jinja2/environment.py", line 936, in handle_exception
    raise rewrite_traceback_stack(source=source)
  File "<template>", line 1, in top-level template code
  File "/srv/homeassistant/lib/python3.9/site-packages/jinja2/sandbox.py", line 303, in getitem

Note that documentation should be updated:

extension name is ENEDIS but config sample still point on TELEINFO

replace 1st line "plateform: teleinfo" with "plateform: enedis"

When using default Rasbery TTY port, console should be stop and homeassistant user should be able to access group tty

sudo systemctl stop<EMAIL_ADDRESS>&& sudo systemctl remove<EMAIL_ADDRESS>chmod g+w /dev/ttyAMA0
usermod -a -G tty homeassistant

Few progress:

it is not enough to remove systemctl stop<EMAIL_ADDRESS>should also remove serial console from /boot/cmdline.txt otherwise agetty restart aumatically
without agetty in place /dev/ttyAMA0 below to 'dialout' group also homeassistant should have access to this group
usermod -a -G dialout homeassistant

I now see Enedis-Teleinfo, nevertheless I still get an error within the log
2022-10-21 12:26:00.250 ERROR (MainThread) [homeassistant.helpers.entity] Update for sensor.enedis_teleinfo fails
Traceback (most recent call last):
  File "/srv/homeassistant/lib/python3.9/site-packages/homeassistant/helpers/entity.py", line 515, in async_update_ha_state
    await self.async_device_update()
  File "/srv/homeassistant/lib/python3.9/site-packages/homeassistant/helpers/entity.py", line 710, in async_device_update
    raise exc
  File "/usr/lib/python3.9/concurrent/futures/thread.py", line 52, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/home/homeassistant/.homeassistant/custom_components/teleinfo/sensor.py", line 122, in update
    _LOGGER.debug(" Got : [%s] =  (%s)", name, value)
UnboundLocalError: local variable 'name' referenced before assignment
2022-10-21 12:27:00.191 ERROR (MainThread) [homeassistant.helpers.entity] Update for sensor.enedis_teleinfo fails
Traceback (most recent call last):
  File "/srv/homeassistant/lib/python3.9/site-packages/homeassistant/helpers/entity.py", line 515, in async_update_ha_state
    await self.async_device_update()
  File "/srv/homeassistant/lib/python3.9/site-packages/homeassistant/helpers/entity.py", line 710, in async_device_update
    raise exc


PerPage / SortBy Components

These components are useful for easily displaying these common components in the toolbar - but currently they only support displaying as a select dropdown, using the Select component.
There are good use cases for having these displayed as a radio group or an unordered list.
The proposed solution would be to create two new generic components: Radio and List (names subject to change)
The Radio component would allow for only a single selection, and could use an icon to indicate selection status. Upon clicking a selection it would become the selected option.
The List component could be ordered or unordered, and would place the options passed into <li> elements. It may make sense to allow for multiple selections in this component, but it should also allow for indicating a selected element (likely via a classname).
Both of these components should be generic enough to support passing various data (similar to how the Select component current works) - this will allow them to be used as blocks in future components and also within the PerPage and SortBy components.
All components will need stories, documentation and tests.

Merged into templates branch.


PhoneNumber requires country code

[x] I was not able to find an open or closed issue matching what I'm seeing.
[x] This is not a question. (Questions should be asked on chat (Signup here) or our forums.)

Use case, UK business website with enquiry form for UK customers. They are not expected to enter the country code for their phone number. An 11 digit number beginning with 0 is not considered valid. e.g. 0161 123 4567 (calling internationally it would be +44<PHONE_NUMBER>).
Code to reproduce the issue
$phoneNumber->isValid('01611234567');

Expected results
Considered valid.
Actual results
Considered invalid.
Not sure of an easy fix for this, or whether the docs should state that the country code is expected?

I believe this is something the Google library takes into account... Looking at an alternative implementation it works as expected: https://giggsey.com/libphonenumber/.

@internalsystemerror
The current problem: the patterns for phone numbers in zend-i18n are very old. We need a script to update these patterns and have to rework all unit tests which belongs to the PhoneNumber validator.

Sorry, this issue report is a feature request and not a bug. The bug are the outdated phone number patterns which are covered in separate issue reports.

I like this feature request because it would be a great improvement for this component!

On further investigation, the example given above is in fact valid, and it's only UK mobiles which have an issue: e.g. 0787 512 1234.

@internalsystemerror
No problem. We have to write unit tests anyway.

This repository has been closed and moved to laminas/laminas-i18n; a new issue has been opened at https://github.com/laminas/laminas-i18n/issues/3.


Simple idea for a first iteration of an LFE stdlb

For context, see parent task, #107.
In LFE:

[x] Create a lib or stdlib directory in the LFE code base
[x] Add a README to explain what it does
[x] Add a Makefile so that the appropriate top-level LFE make targets can cd and compile the libraries
[x] In the stdlib Makefile, add a variable that will hold a list of the set of libraries that will comprise the stdlib
[x] In the stdlib Makefile, add a target for downloading LFE libraries for the stdlib
[x] In the stdlib Makefile, add a target for compiling LFE libraries for the stdlib
[x] Compile all libs to the LFE ebin dir
[x] Copy the libs' include files to LFE include dir
[x] Add a new top-level make target for LFE (e.g., make stdlib) that will build the defined libraries

In the "lfe" Github org:

[ ] Copy some libraries (wholesale or in part) to the "lfe" org on github
[ ] Prefix these repo names with "stdlib-" (self-documenting, for purposes of clarity)
[ ] Pare down these repos so simply include (1) a README (which will eventually contain or link to complete documentation for the library), (2) a src dir containing LFE modues, and (3) an optional include dir containing macros, functions, records, etc.

For both:

[x] Step through a standard LFE build, and make sure everything works
[ ] Iron out bugs or issues with the make stdlib target
[ ] Ensure that the standard LFE build still works
[ ] Ask @rvirding to give it a whirl :-)

Work is being done in this branch:

https://github.com/lfe/lfe/tree/stdlib-experiment

I've got this running against "lfex" github org libraries. If this is something we want to continue looking at, I'll need to copy those repos into the "lfe" github org, and update their include-lib paths (since those are breaking right now ... since they are part of the LFE paths in this setup, the include paths need to be changed to reflect this).
Also, a rename of modules, etc., would be necessary so they didn't clash with the modules in the "lfex" org. This would be just as simple as dropping the initial "l" from the module names.

This ended up being done for cl.lfe and clj.lfe.
Closing ...


Clair Scanner CVE Threshold

Per agreement with the Pega security team, the default build-failure threshold for the image scanner in this OSS project should be High, not Medium.
All CVEs regardless of severity will continue to be logged and audit-able by viewing the travis build.  The build should only fail for non-whitelisted CVEs of severity 'High' or higher.

Set threshold to Medium


Update npm packages

Update npm packages and especially protobufjs the new version of which contains fixes for proto3

Hi, I am going to patch the packages gradually, if you need specific patches let me know.
The protobuf package was updated today.
Thank you for your time


Make YouTube links to videos easily accessible from FUN

From the Jupyter Book one can always click on the "Watch on YouTube" button, but this feature is not accessible in FUN.
Pointing to YouTube will make sharing easier for the students and may therefore impact the visibility of the MOOC.
This is another good idea from Francois ;)

Done in FUN!


Improve visibility of GPU training in Tabular

Currently users can get various models such as LightGBM, CatBoost, XGBoost and tabular neural networks to train with GPU, however it is not well documented.
The current process to enable GPU for tabular models:
predictor.fit(..., ag_args_fit={'num_gpus': 1})

Note that LightGBM may need a special installation to use GPU.

So it should be like “ ‘num_gpus': 8 ”if I have eight gpus right?

but i got :Training LightGBM with GPU, note that this may negatively impact model quality compared to CPU training.
So should i do not add 'ag_args_fit'?

but i got :Training LightGBM with GPU, note that this may negatively impact model quality compared to CPU training. So should i do not add 'ag_args_fit'?

This message is because model quality is not identical between CPU and GPU, and GPU may have worse results. This is something you would need to verify yourself if GPU model is attaining good results for your needs.

So it should be like “ ‘num_gpus': 8 ”if I have eight gpus right?

Yes, but currently we have not tested multi-gpu and it may only use 1 GPU depending on the model.

Thks!

Added documentation for GPU usage in #1527

Why does the GPU CatBoost model take longer to train and perform better than the CPU Catboost version? Does the underlying architecture is different for CPU and GPU versions?

Why does the GPU CatBoost model take longer to train and perform better than the CPU Catboost version? Does the underlying architecture is different for both CPU and gnu versions of

but i got :Training LightGBM with GPU, note that this may negatively impact model quality compared to CPU training. So should i do not add 'ag_args_fit'?

This message is because model quality is not identical between CPU and GPU, and GPU may have worse results. This is something you would need to verify yourself if GPU model is attaining good results for your needs.


Is pulse_gate not a gate (i.e. in supported operations)?

What did you find confusing? Please describe.
I am looking for the device property that describes whether or not a device has pulse level control access. I was assuming that the list of supported operations would contain pulse_gate, but for one of the two devices where that is the case, I cannot find it:
device = AwsDevice("arn:aws:braket:eu-west-2::device/qpu/oqc/Lucy")
supported_ops = device.properties.action["braket.ir.openqasm.program"].supportedOperations
print(supported_ops)

['ccnot', 'cnot', 'cphaseshift', 'cswap', 'cy', 'cz', 'h', 'i', 'phaseshift', 'rx', 'ry', 'rz', 's', 'si', 'swap', 't', 'ti', 'v', 'vi', 'x', 'y', 'z', 'ecr']

Describe how documentation can be improved
It would be great to have more details about how pulse_gate is treated on braket python sdk, we need it for the pennylane braket plugin to allow pulse gates.
Additional context
Add any other context or screenshots about the documentation request here.

@Qottmann Thank you for raising this request. At the moment you would need to do something like a "Try Except" statement on "device.properties.pulse" in Python.

To add to the above, if you'd like to avoid a Try/Except, you can also check if the device properties contains a pulse entry with "pulse" in device.properties.dict()


Flexispot EF1

For flexispot EF1 the Desk model: Flexispot E5B works.
I have the Flexispot EF1 und I used the table from the E5B and it is working.

Yes indeed it is working for EF1 model, using E5B template. You just need to delete M switch because there is no M button on EF1 but there is preset 4 so you just need to add preset 4 from getting uart data from main page.

I have got two EF1 desks. I bought them at different times.
My first desk has a HCB103A-2 controller/remote.
The second desk has a HCB213A-1.
Using the E5B wiring table it works with the HCB213A-1 but it doesn't work with the other desk.

Thanks @lukes-ha, this is good news.
This ticket might be linked to https://github.com/iMicknl/LoctekMotion_IoT/issues/37 btw


SwitchNavigator in react-navigation

Not sure if anyone raised this before. But it seems that the react-navigation included in the boilerplate is so old that it doesn't contain SwitchNavigator. What's the reason of keeping an old version of react-navigation and any suggestion for a replacement of SwitchNavigator?
Thanks a lot!

We're updated to React Navigation 3.0 now. Thanks!
https://github.com/infinitered/ignite-ir-boilerplate-andross/blob/923235692e5fb51a8e55e178e690b26793c214bb/boilerplate.js#L182


Correct bad plugin options usage

Documentation bug. Fixes example on overriding plugin options during initialization.

Current coverage is 100% (diff: 100%)

Merging #45 into develop will not change coverage

@@           develop   #45   diff @@
====================================
  Files            3     3
  Lines           95    95
  Methods         17    17
  Messages         0     0
  Branches        10    10
====================================
  Hits            95    95
  Misses           0     0
  Partials         0     0

Powered by Codecov. Last update ae4dfe3...8c72001


sanitize hostnames

Use example.com instead of hostnames which are meaningless outside VPN connected hosts.  The docs should be generic and actual hostnames and wiki URLs are well known as they are commicated via email when allocations are given out.

LGTM, but we may have to revisit other of the .md files, if there are other entries e,g, troubleshooting.md has some we can sanitize, tips-and-vars.md has also a link to internal labs, but I consider this harmless. Thoughts?

Closing as stale


RESTFUL issues with PUT

https://nhsconnect.github.io/FHIR-NOO-API/build_consent_restful.html#POST
"Update the patients" should be "Update the patient's"
The link to search parameters makes no sense for a PUT

Patients changed to patient's and the reference has now been removed.


Add packages for creichert.

Issue with hlint 1.9. Fixing it now.

I uploaded a new version of the package which was causing issues. I'm not sure if I can jump start a rebuild myself.

I just kicked off a rebuild. For future reference, you can force that yourself be pushing a new commit to the PR, such add via --amend


Better manual operation

Is your feature request related to a problem? Please describe.

Also, there is not much speed specification.

Also, there is not much speed specification.
However, I would like to be able to go anywhere immediately after the train appears, without having to specify a route.
Also, there should be a UI to handle switching rails.
Also, it would be good to increase the principle to 5 levels and the acceleration to about 5 levels.
Please.

Think about other mods, please!

We are very sorry.
I will delete your post.
Thank you very much.


Allow Rails 5.0

Rails 5.0.0.beta1 is released. I loosened up the dependency so acl9 can be used in Rails 5.0 projects.

I've opened #98 to do this with proper test coverage. It's failing right now, but I'm working on it.


doc: fixing typo

Checklist

I have read the contributors guidelines and the code of conduct
I have updated the related issue with new insights and changes
I added unit tests and updated the docstrings
I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test:.
I documented my code
I ran pre-commit hooks and fixed any issue

Pull Request Test Coverage Report for Build<PHONE_NUMBER>6
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 93.691%

Totals

Change from base Build<PHONE_NUMBER>2:
0.0%

Covered Lines:
3252

Relevant Lines:
3471

💛  - Coveralls


Use macro {$SNMP_COMMUNITY} for discovery rules instead of public

Changed the discovery rules snmp community to use the same community name macro as the items.

Done.
Thanks.


No layer shown when adding layer to the map rectify screen

I believe this may have been fixed on mapwarper.net or nypl.
Also, change wording to "mosaic" if possible.

the URL is calling: where the map is 260 and the layer is 43
/layers/wms/260/43?FORMAT=imag

this should be fixed now.


Saner default configuration in motley_cue.conf

add more supported IdPs to the list
reasonable default groups authorised
remove m-team as default authorised group

add more supported IdPs to the list
remove m-team as default authorised group

Done in ff8bd37eb50c607cd353ee1f12e5c8f229d6dc57

reasonable default groups authorised

What are reasonable defaults? It's probably more secure to not authorise any groups by default. We can still provide a default list of supported OPs, although without additional authorisation configured, no users will be authorised.
For example, in the provided etc/motley_cue.conf the KIT IdP is supported but no one is authorised to use the service.

Very nice, that new config.
I'd say that the config should contain a lot of examples, that should work in practice, but they're all commented out.
One example missing would be an individual user (e.g. yours).
A cmdline example in which e.g. mccli shows your id (and groups / entitlements) would be nice to be shown in that config file, too.
Did you extend flaat for this, or did you code things yourself?

Very nice, that new config.
I'd say that the config should contain a lot of examples, that should work in practice, but they're all commented out.
One example missing would be an individual user (e.g. yours).

Good point.

A cmdline example in which e.g. mccli shows your id (and groups / entitlements) would be nice to be shown in that config file, too.

That would be nice. I'll get on the mccli issues next, so this is another feature I could add.

Did you extend flaat for this, or did you code things yourself?

No, I coded things myself. It's more a matter of parsing the authorisation rules in the config and using the appropriate decorators in flaat. Gabriel's idea about an authorisation rule engine and a well defined language would make sense here if we wanted to define something more complex, and then it definitely should be integrated in flaat.


refactor: Add localeExtension config option and clean up config procedure

General cleanup of the config creation procedure.
Fixes #257, #294, and #297.

@capellini Mind reviewing? Note that I had less than a half hour free this evening so haven't had a chance to write tests for the new config option. Appreciate any help you can offer. Thanks!


Refactoring cherry picks ocp

Bringing two cherry pick refactors to our midstream, since they are base for future refactors and bug fixes:

#2575
#2576

/retest

/retest

/lgtm


esdm: 1.0.0 -> 1.0.1

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/smuellerDD/esdm/releases.
meta.description for esdm is: Entropy Source and DRNG Manager in user space
meta.homepage for esdm is: https://www.chronox.de/esdm.html
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 1.0.1 with grep in /nix/store/ck9bf924g58fl9ws8pijkkigagbs38vr-esdm-1.0.1
found 1.0.1 in filename of file in /nix/store/ck9bf924g58fl9ws8pijkkigagbs38vr-esdm-1.0.1

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
esdm

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/ck9bf924g58fl9ws8pijkkigagbs38vr-esdm-1.0.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A esdm https://github.com/r-ryantm/nixpkgs/archive/7e1bac3bd5aa2505550d0058729fb3eb7e540e21.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/7e1bac3bd5aa2505550d0058729fb3eb7e540e21#esdm

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/ck9bf924g58fl9ws8pijkkigagbs38vr-esdm-1.0.1
ls -la /nix/store/ck9bf924g58fl9ws8pijkkigagbs38vr-esdm-1.0.1/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

esdm

Maintainer pings
cc @ORichterSec @thillux for testing.

The module needs to be adapted too. I should have time for this tomorrow or on the weekend.

WIP: #274307


Arash  Stella

Preparation

[X] I tested the latest release
[X] I looked at other issues (even the closed ones)
[X] I read the Troubleshooting Guide

FGO server
CN
FGA build number
1492
Describe the bug
After Arash opens the treasure and dies, the next round, the script set in advance will be invalid。(cn update model is related to action？)
Do not release the set skills, directly select the card，
But the next Arash (same round) there will be no error, I don't know if it’s a translation error or a bug
Video
NO
Device model
xiaomi
Android version
11
Screen size
No response
RAM
No response

Sorry, but I can't understand your bug report. You will have to ask someone to translate.
And you didn't even provide a video.

Duplicate of #861

This problem is not UI,

Picture 1 is the script I set
Picture 2 chooses the first one, next time, after Alash uses Stella to die, the next person to replace Alash will not use skills

https://user-images.githubusercontent.com/87466224/132816445-f7198a8e-0043-4654-a295-7305fedcc822.mp4


Be more resilient to null RelationshipsSnapshot collections

Issue #6157
See issue for full discussion.

:shipit:


Fix Managed HSM access control live test

/azp run js - keyvault-admin - tests

/azp run js - keyvault-admin - tests


Request for comment by MSVC team: linker error for inline function

Install Azure-Identity vcpackage built as DLL: vcpkg install azure-identity-cpp:x64-windows

Create a project that will consume it:
CMakeLists.txt:

cmake_minimum_required (VERSION 3.15)
project (vcpkg-test LANGUAGES CXX)

add_executable(vcpkg-test "main.cpp")
set_property(TARGET vcpkg-test PROPERTY MSVC_RUNTIME_LIBRARY "MultiThreadedDebugDLL")

set(VCPKG_TARGET_TRIPLET "x64-windows")
find_package(azure-identity-cpp "1.1.0" CONFIG REQUIRED)

target_link_libraries(vcpkg-test PRIVATE Azure::azure-identity)

main.cpp:
#include <azure/identity/client_secret_credential.hpp>

int main()
{
    Azure::Identity::ClientSecretCredential csc("a", "b", "c");
}

Build:

main.cpp.obj : error LNK2019: unresolved external symbol "const Azure::Identity::ClientSecretCredential::`vftable'"
(??_7ClientSecretCredential@Identity@Azure@@6B@) referenced in function
"public: __cdecl Azure::Identity::ClientSecretCredential::ClientSecretCredential(
class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> >,
class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> >,
class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> >,
struct Azure::Core::Credentials::TokenCredentialOptions const &)"
(??0ClientSecretCredential@Identity@Azure@@QEAA@V?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@00AEBUTokenCredentialOptions@Credentials@Core@2@@Z)
vcpkg-test.exe : fatal error LNK1120: 1 unresolved externals
  ninja: build stopped: subcommand failed.

Build All failed.

Press F12 on #include <azure/identity/client_secret_credential.hpp> - edit the header:
Add AZ_IDENTITY_DLLEXPORT for the ClientSecretCredential class:

class AZ_IDENTITY_DLLEXPORT ClientSecretCredential final : public Core::Credentials::TokenCredential {

Build again - build and link succeeds.

But adding AZ_IDENTITY_DLLEXPORT should not be required, because we use CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS: https://github.com/Azure/azure-sdk-for-cpp/blob/31dc284164611a2f81feda3abaa7275a17e64fa1/sdk/identity/azure-identity/CMakeLists.txt#L9

But why then it works in exact same situation for Azure-Core? Replace .cpp code with this:

#include <azure/core/datetime.hpp>

int main()
{
    Azure::DateTime dt(2021);
}

Build succeeds, no linker errors.

Questions:

Is this a MSVC bug?
How is it possible that there is a linker error for an inline function? And it's not that the non-inline function was not dllexported - we can edit the header without SDK recompilation, and it links, so SDK was built correctly.

What is the best way to fix it? We could add AZ_IDENTITY_DLLEXPORT attribute for Azure-Identity classes, but then how do we know which classes/libraries do need it, and which are not? Other libs do no seem to need it so far, but we wouldn't know for sure until we try to use every inline function. Plus, that attribute affects code readability. Ideally, if it worked without that. But if this is a bug, I guess we'll have to, so that it works on older versions?

More context:
The linker error is because an inline SDK function calls a non-inline SDK function:
https://github.com/Azure/azure-sdk-for-cpp/blob/3f5c5ae66476f7c77a0ffc0bf1d50f17192166b3/sdk/identity/azure-identity/inc/azure/identity/client_secret_credential.hpp#L89-L102
https://github.com/Azure/azure-sdk-for-cpp/blob/3f5c5ae66476f7c77a0ffc0bf1d50f17192166b3/sdk/identity/azure-identity/inc/azure/identity/client_secret_credential.hpp#L56-L61
So, if we call a non-inline SDK function directly from the code (I tried with GetToken()), then there is no linker error.
But if we call an inline SDK function which calls a non-inline SDK function, there is a linker error.
The Azure-Core counter-example does the same, and there is never a linker error:
https://github.com/Azure/azure-sdk-for-cpp/blob/3f5c5ae66476f7c77a0ffc0bf1d50f17192166b3/sdk/core/azure-core/inc/azure/core/datetime.hpp#L105-L114
https://github.com/Azure/azure-sdk-for-cpp/blob/3f5c5ae66476f7c77a0ffc0bf1d50f17192166b3/sdk/core/azure-core/inc/azure/core/datetime.hpp#L59-L70

Hi @antkmsft I finally find a way to get around this issue.
Move the definitions of constructor ClientSecretCredential() into .cpp file.

Closing per Jinming finding a valid fix.

From the initial error message: "error LNK2019: unresolved external symbol const Azure::Identity::ClientSecretCredential::vftable' (??_7ClientSecretCredential@Identity@Azure@@6B@) referenced in function ..." the problematic symbol isn't a function, it's the virtual function table. Polymorphic types in C++ are usually implemented with a "secret" pointer at the beginning of the object representation that points at a table of pointers-to-function that are implementations of the type's virtual` functions. "virtual function table" == "vftable". The vftable pointer is set in each constructor (and destructor) to track the objects dynamic type as it changes during construction / teardown.
Some implementations (at least those targeting the MSFT ABI and the SYSV ABI that linuxen use) have a handy trick where they avoid emitting a copy of the vtable and implementations of all virtual functions of every type in every TU by emitting that info for a given type only in the first TU that defines a non-inline non-virtual function for that type. The definition of ClientSecretCredential looks like:
  class ClientSecretCredential final : public Core::Credentials::TokenCredential {
  private:
    // non-static data members

    ClientSecretCredential(/* arguments */); // non-inline, non-virtual constructor

  public:
    explicit ClientSecretCredential(/* arguments */)
        : ClientSecretCredential(/* stuff */)
    {} // inline, non-virtual (delegating constructor)

    explicit ClientSecretCredential(/* different arguments */)
        : ClientSecretCredential(/* other stuff */)
    {} // inline, non-virtual (delegating constructor)

    // other non-static member functions
};

WIP: saving this despite not being finished yet


upgrade roll

may have upgrade a little bit the roll algorithme
from how I see, user should win with 33% winrate


Improve proto generation rake task

Use Dir.glob and clean it up.
Originally posted by @ahayworth in https://github.com/open-telemetry/opentelemetry-ruby/pull/1345#discussion_r941846248

🤔 I've rediscovered Rake::FileList. Because this activity is occurring in a Rakefile,
proto_files = Rake::FileList["opentelemetry-proto/**/*.proto"]

… is also an option.
I am resisting trying to write Rake rules for .proto to .pb. I expect they would end up weird and hard to read.


Add support for runtime constants (specialization)?

SpirV supports specialization: setting constants at runtime, can be useful?

+1 on this, it would be great if it could be defined similar to the parameters, as:
@python2shader
def compute_shader_multiply(
        index: ("input", "GlobalInvocationId", ivec3),
        data1: ("buffer", 0, Array(f32)),
        data2: ("buffer", 1, Array(f32)),
        data3: ("buffer", 2, Array(f32)),
        constants=[Constant("LEN_VAR", 0, )]):
    i = index.x
    data3[i] = data1[i] * data2[i]


Fix/pytest 7 0 0 hotfix

This PR implements a fix for a bug related to pytest 7.0.0 when running pytest with --import-mode=importlib
Solution:

fixed pytest version to 6.2.5

Hello @Moritz-Alexander-Kern! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file elephant/test/test_spike_train_synchrony.py:

Line 494:20: W292 no newline at end of file

In the file elephant/test/test_unitary_event_analysis.py:

Line 561:20: W292 no newline at end of file


jdtls: use root_dir for -data parameter (instead of cwd)

Problem description
In the init.lua file for the jdtls server the workspace folder is created by default using a "base workspace path" plus the last part of the current cwd (see here). I am wondering why we don't use the also available root_dir of the current Java project which is given to the function (see here) instead? This way we would get the actual project name instead of the last part of the cwd.
I am usually starting Neovim in my home directory and then do all navigation inside of it. Therefore my cwd is always /home/user/. As a consequence whenever I open a Java project the corresponding workspace folder points to the same folder: /home/user/workspace/user even when I have multiple Java projects open. This obviously causes problems like for example that my project dependencies can not be found etc.
I have build a "hack" in my config to change the cmd from nvim-lsp-installer to better point to an individual workspace folder per project (using the root_dir), but I though maybe this should be changed within the plugin. But maybe this was done on purpose and there are use cases in which my approach would cause other problems :thinking:
Neovim version (>= 0.6)
NVIM v0.6.1
Build type: RelWithDebInfo
LuaJIT 2.1.0-beta3
Operating system/version
Linux DTC69Y2 5.13.0-30-generic #33~20.04.1-Ubuntu SMP Mon Feb 7 14:25:10 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
I've recently downloaded the latest plugin version of both nvim-lsp-installer and nvim-lspconfig

[X] Yes

Affected language servers
jdtls
Steps to reproduce

start Neovim using the minimal config: nvim -u ~/Downloads/minimal_debug_init.lua
install jdtls using: LspInstall jdtls
open a Java file within a Java project e.g. :e <path-to-file>/MainClass.java
check the -data directory

use :LspInfo
check cmd and there the -data path

Actual behavior
-data argument is /home/<user>/workspace/<user>
Expected behavior
-data argument should be /home/<user>/workspace/<project-name>
LspInfo
Language client log: /home/user/.cache/nvim/lsp.log
 Detected filetype:   java

 1 client(s) attached to this buffer:

 Client: jdtls (id: 1, pid: 33257, bufnr: [1])
 	filetypes:       java
 	autostart:       true
 	root directory:  /home/user/git/mappy-v2-gui
 	cmd:             java -Declipse.application=org.eclipse.jdt.ls.core.id1 -Dosgi.bundles.defaultStartLevel=4 -Declipse.product=org.eclipse.jdt.ls.core.product -Dlog.protocol=true -Dlog.level=ALL -Xms1g -Xmx2G -javaagent:/home/user/.local/share/nvim/lsp_servers/jdtls/lombok.jar --add-modules=ALL-SYSTEM --add-opens java.base/java.util=ALL-UNNAMED --add-opens java.base/java.lang=ALL-UNNAMED -jar /home/user/.local/share/nvim/lsp_servers/jdtls/plugins/org.eclipse.equinox.launcher_1.6.400.v20210924-0641.jar -configuration /home/user/.local/share/nvim/lsp_servers/jdtls/config_linux -data /home/user/workspace/user

 Configured servers list: jdtls

Healthcheck
nvim-lsp-installer: require("nvim-lsp-installer.health").check()
========================================================================
## nvim-lsp-installer report
  - OK: neovim version >= 0.6.0
  - WARNING: **Ruby**: not available
  - WARNING: **RubyGem**: not available
  - WARNING: **julia**: not available
  - OK: **tar**: `tar (GNU tar) 1.30`
  - OK: **gzip**: `gzip 1.10`
  - OK: **wget**: `GNU Wget 1.20.3 built on linux-gnu.`
  - OK: **python3**: `Python 3.8.10`
  - OK: **Go**: `go version go1.17.3 linux/amd64`
  - OK: **sh**: `Ok`
  - OK: **bash**: `GNU bash, version 5.0.17(1)-release (x86_64-pc-linux-gnu)`
  - OK: **PHP**: `PHP 7.4.3 (cli) (built: Nov 25 2021 23:16:22) ( NTS )`
  - OK: **node**: `v14.17.6`
  - OK: **curl**: `curl 7.68.0 (x86_64-pc-linux-gnu) libcurl/7.68.0 OpenSSL/1.1.1f zlib/1.2.11 brotli/1.0.7 libidn2/2.2.0 libpsl/0.21.0 (+libidn2/2.2.0) libssh/0.9.3/openssl/zlib nghttp2/1.40.0 librtmp/2.3`
  - OK: **java**: `Ok`
  - OK: **Composer**: `Composer 1.10.1 2020-03-13 20:34:27`
  - OK: **javac**: `javac 17.0.1`
  - OK: **npm**: `7.24.1`
  - OK: **pip3**: `pip 21.3.1 from /home/user/.local/lib/python3.8/site-packages/pip (python 3.8)`

Screenshots or recordings
No response

Hello! Ah I see. I've pushed a little something to jdtls-workspace-dir (#504), does it work as you'd expect?

Thank you for the fast response.
I tested it with the minimal_debug config and that works fine now :+1:
For my personal config I use nvim-jdtls and therefore puzzle the server config together myself before handing it to the plugin. In there I use jdtls_server:get_default_options().cmd to use the jdtls installed by your plugin. Unfortunately for me the "default cmd" still points to the cwd, so that the problem persists. I realize that I have not add this information in the issue description (but at least it is fixed for the "default case" now)
Do you have any idea if this case could also be solved? Otherwise I need to stick with my hack.

Nevermind I figured out an easy solution (shortened to just present the basics):
local root_dir = require('jdtls.setup').find_root({ 'gradlew', '.git', 'pom.xml', 'mvnw' })
local config = { ... }
local server_available, jdtls = require('nvim-lsp-installer.servers').get_server('jdtls')

-- this will fill in the correct 'cmd' to use
jdtls:get_default_options().on_new_config(config, root_dir)

require('jdtls').start_or_attach(config)

So your change is indeed solving this as well :slightly_smiling_face:
(since the on_new_configfunction did not accept the workspace_path parameter before)

Ah, cool! A bit hacky but if it works it works :D. Feel free to add your solution to the Wiki!