[TS migration] Migrate 'useCurrentReportID.js' hook to TypeScript

Details

Fixed Issues

$ 24944
$ 24956
Tests

[x] Verify that no errors appear in the JS console

Offline tests

QA Steps

Open app
Select whatever chat
Chat should open without any problems

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native
https://github.com/Expensify/App/assets/25230417/1a4d74e6-ba09-4474-a158-c8b25bb881f4

Android: mWeb Chrome

iOS: Native
https://github.com/Expensify/App/assets/25230417/9b721f53-a743-482e-ac70-0ca8792fdede

iOS: mWeb Safari

MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/25230417/b1bf94bb-eec4-4246-b089-0761a4fa02ec

MacOS: Desktop
https://github.com/Expensify/App/assets/25230417/33b92e02-edb5-4c87-920b-095d45aae6e6

@VickyStash fixed :)

@blazejkustra thanks for the comments, fixed 😄

@kubabutkiewicz Again, when you marked this PR as ready no C+ was assigned. @AndrewGable Can you assign some C+ so that they can complete the reviewer checklist?

QA step is still missing

QA steps added
@AndrewGable @situchan

@kubabutkiewicz Also, please fix conflict

@situchan fixed

@situchan kindly bumping for review 😄

will review this in an hr

Please pull main

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native
https://github.com/Expensify/App/assets/108292595/4e0310f9-6504-4399-88d3-2eeb7dd6e29e

Android: mWeb Chrome
https://github.com/Expensify/App/assets/108292595/34329092-73a9-4871-bc24-c1cd4f04c996

iOS: Native
https://github.com/Expensify/App/assets/108292595/08ba99cb-9e5b-43cb-943e-09a02ad71d58

iOS: mWeb Safari
https://github.com/Expensify/App/assets/108292595/4075d4e6-d2ae-4ee9-a96d-7c0d3d013edd

MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/108292595/5860d76d-2af3-4db8-b2da-84e7d9101b7b

MacOS: Desktop
https://github.com/Expensify/App/assets/108292595/52178aed-400b-483b-9511-fb20458c265a

@AndrewGable all yours

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to production by https://github.com/puneetlath in version: 1.3.97-7 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to staging by https://github.com/AndrewGable in version: 1.3.98-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/roryabraham in version: 1.3.98-5 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Create an option for grab-all-posters.py to follow Plex naming convention

Referring back to this thread on Discord:
https://discord.com/channels/822460010649878528/1212077681965801502

+1 to have an option to save in this naming convention and folder hierarchy, but to also include the episode images.
   /Heroes
      /Season 01
         Heroes - s01e01 - xxxxx.mkv
         _Heroes - s01e01 - xxxxx.jpg_
         Season01.jpg
      /Season 02
         Heroes - s02e01 - yyyyy.mkv
         _Heroes - s02e01 - yyyyy.jpg_
         Season02.jpg
      /Season 03
         Heroes - s03e01 - zzzzz.mkv
         _Heroes - s03e01 - zzzzz.jpg_
         Season03.jpg
   poster.jpg
   background.jpg


refactor tableacl

move simpleacl.go from go/vt/tableacl to go/vt/simpleacl
add an AclFactory interface.
move both ACL and AclFactory interfaces to go/vt/tableacl/acl
define a package level variable called "acls" in tableacl which
contains all registered AclFactory.
enable simpleacl as the default tableacl mechanism.

To plugin the specific tableacl implementation other than simpleacl, one
could either modify all binaries (go/cmd/vtocc/vtocc.go and go/cmd/vttablet/vttablet.go)
to call tableacl.Register(...) and then point tableacl.DefaultACL to the
specific tableacl. Alternatively, one could also put the specific tableacl
implementation under go/vt/tableacl dir and use the init function to finish
the registeration.

LGTM


Change password feature

There's currently no option for a signed in user to update its password, it would be nice to add that.
(Note that in the current situation, it can still be changed, but is a bit counterintuitive: the user has to sign out, click on "I've lost my password", and then this person will get a link allowing to change its password)

This has been implemented some time ago!


[docker] fix on ubuntu 20.04

@jwhui I cannot re-run my PRs. Are there any settings changed recently?

@jwhui I cannot re-run my PRs. Are there any settings changed recently?

@bukepo, did you try logging out and logging back in to Travis?

@jwhui It works.


VSCode Intellisense is very slow with @tanstack/react-table 8.9.2

Describe the bug
I just migrated react-table from v7 to v8.
And VSCode Intellisense is loading infinitely.
Your minimal, reproducible example

Steps to reproduce

install @tanstack/react-table v8.9.2
When I open any file in which the components of @tanstack/react-table are imported, VSCode intellisense is loading infinitely.
When I remove the components import from @tanstack/react-table and restart Typescript server, I can't see the issue.

What I have tried from suggestions

I restarted Typescript server, and restarted VSCode but the issue was not fixed.
I installed @tanstack/react-table v8.9.1 but the issue still remained.
I downgraded VSCode v1.80.2 but the issue was not fixed

UPDATED
The given file with current issue has big enough amount of components imported.
When I remove import other big components, intellisense is working expected
Expected behavior
VSCode Intellisense should be loaded in time, like couple of seconds or less than a minute.
How often does this bug happen?
Every time
Screenshots or Videos
No response
Platform

OS: Windows
VSCode version: 1.81.1

react-table version
v8.9.2
TypeScript version
v5.1.6
Additional context
No response
Terms & Code of Conduct

[X] I agree to follow this project's Code of Conduct
[X] I understand that if my bug cannot be reliable reproduced in a debuggable environment, it will probably not be fixed and this issue may even be closed.

any news ? nothing is working anymore..

I resolved this issue by ignoring the file that uses @tanstack/react-table from vscode project and opening it separately:
"files.exclude": {         "**/.git": true,         "**/node_modules": true,         "**/Table.tsx": true,                           // here         "**/.svn": true,         "**/.hg": true,         "**/CVS": true,         "**/.DS_Store": true,         "**/Thumbs.db": true     },


[WFLY-8854] Clean up messaging resources in domain mode

Clean up messaging resources in domain mode so that runtime operations
and attributes are not part of the profile's model.
These runtime operations and attributes relies on the presence of
ActivemQ objects that are not started in HC.
Impacted resources and operations:

start and stop operations for acceptor, in-vm-acceptor,
remote-acceptor, bridge, broadcast-group, cluster-connection resources
get-connector-pairs-as-json operation for broadcast-group resource
get-nodes operation for cluster-connection resource

JIRA: https://issues.jboss.org/browse/WFLY-8854

Regarding the resolution possibilities in https://issues.jboss.org/browse/WFLY-8854, I opted to remove the operations/attributes even if that introduces breaking changes.
These ops and attributes were not working in profile model before. Users would not have been able to rely on their outcomes in any previous versions so I think it is ok to get rid of them.
@bstansberry are you ok with that decision?

@jmesnil This approach is fine with me.
FYI -- https://issues.jboss.org/browse/WFCORE-2829 which probably would have made this easier. I need to start posting on wildfly-dev about these little things. :(


Configurable namespace + Finalizers

@shawn-hurley What do you think are the next steps with this one? Do we want to open a story in Jira to track this? Is it still of enough interest to polish and merge?

I think that this idea is still very necessary but in regards to descoping conversations, I think this should be closed and rolled into that conversation.


Comments and badges missing after reloading window

Testing microsoft/vscode#167397
on Windows 11
In the vscode-docs repo, open draft PR microsoft/vscode#5677 and add a couple of comments to docs/sourcecontrol/intro-to-git.md.
The Comments view shows that there are comments and the badge reflects the resolved or unresolved state.
Reload the window and the Comments view doesn't show that there are comments.

Actually, there's a bug here.


Object.keys map and access with key

Got error for: Object.keys(abc).map(key => abc[key]);
Any idea why?
Link for try:
https://flow.org/try/#0PTAEAEDMBsHsHcBQiDGsB2BnALqNBXdbAJwE8BhWAEwFNNQBeUAb0VFH0wC5QByT3gBo2oAEbEevcUMQBfANzJspAA41QsFdgCWGekwAkAaRqlMAHmVrYkPLEIkK1OgD5FV9Zp16AsgEMVRhYAbQBrUx4vXSwAXR50fABbURpiBWQ0LFw-URRIrWjMf0CmZn5MXh4ARkE+aR4AJnTEAHlRACsaFGwAOnCzAAoclABKHsSAge1sGkTGF1Bh4OnZmJH5IA

I do need to do more complicated stuff using key.

This would work if the core definition for Object.keys() was changed to this:
static keys <T> (o: { +[key: T]: any }): Array<T>;
static keys(o: any): Array<string>;

Try flow
I've added this to my PR along with better definitions for Object.entries() and Object.values().

For now, the typing is actually correct as is because objects are allowed to have extra keys. There is some discussion of why changing this would currently be invalid, and of the teams effort to make this work in the future for exact object, in this PR.


Building Blocks - Gear VR compatibility

Added new instruction diagram for Gear VR
Gear VR users use touch gesture events instead of cursor events
Swipe left/right to change textures
Swipe up/down to change modes
Tap to explode in explode mode, to create in create mode

BTW, I just threw the instruction diagram together really quickly. Feel free to change it.


nz-modal destroyed twice.

弹框关闭
What is actually happening?
弹框关闭，报错
TypeError: Cannot read property 'nativeNode' of null
at removeDebugNodeFromIndex (core.js:30099)
at<EMAIL_ADDRESS>(core.js:32384)
at destroyViewNodes (core.js:31600)
at destroyView (core.js:31588)
at callViewAction (core.js:31706)
at execEmbeddedViewsAction (core.js:31649)
at destroyView (core.js:31578)
at callWithDebugContext (core.js:32324)
at Object.debugDestroyView [as destroyView] (core.js:32026)
at<EMAIL_ADDRESS>(core.js:22245)
at<EMAIL_ADDRESS>(common.js:3522)
at NgIf.set [as ngIf] (common.js:3478)
at updateProp (core.js:22883)
at checkAndUpdateDirectiveInline (core.js:22638)
at checkAndUpdateNodeInline (core.js:31501)
at checkAndUpdateNode (core.js:31463)
at debugCheckAndUpdateNode (core.js:32100)
at debugCheckDirectivesFn (core.js:32060)

Environment
Info

ng-zorro-antd
9.1.2

Browser
chrome 81.0.4044.138

build 和功能都不受影响，只是控制台报错

<nz-modal
*ngIf="showModal"
[nzVisible]="true"
(nzOnCancel)="showModal = false"

xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx

This problem is not related to nz-modal

This problem is not related to nz-modal , maybe your register twice nzModalModule

but when i use ng-zorro-antd 8.x it has not this error

This problem is not related to nz-modal , maybe your register twice nzModalModule

i import NgZorroAntdModule twice in different module，thx

I will reopen so that others with the same problem can find it until it fixed.


watson: added bash/zsh completions

Motivation for this change
Now the project can be used with bash/zsh completion
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 86056 1

1 package built:
- watson


Better Webhook and domain cert support

Explore the use of https://github.com/JoelSpeed/webhook-certificate-generator for managing
the Webhook configs and Pilot/Galley DNS-based certificates.
Example:
go get github.com/joelspeed/webhook-certificate-generator/cmd/webhook-certificate-generator

webhook-certificate-generator -a -n istio-system -s istio-pilot -k $KUBECONFIG -o pilot

Results in a secret named "pilot", signed by the public key of the Apiserver, with
...
 Validity
            Not Before: Jul  2 18:06:00 2019 GMT
            Not After : Jul  1 18:06:00 2020 GMT
CN=istio-pilot.istio-system.svc
 X509v3 Subject Alternative Name:
                DNS:istio-pilot, DNS:istio-pilot.istio-system, DNS:istio-pilot.istio-system.svc

For webhook (new installer in istio-control):
webhook-certificate-generator -a -n istio-control -s istio-sidecar-injector -k $KUBECONFIG -o injector --patch-mutating istio-sidecar-injector-istio-control

will update the mutating webhook with the apiservers own CA ( not sure if this is really needed - apiserver should recognize its own key ? ) and generates a secret with:
kubectl -n istio-control  get secrets injector -o 'go-template={{index .data "cert.pem"}}' | base64 -d > cert.pem
 openssl x509 -in cert.pem -text

...
 X509v3 Subject Alternative Name:
                DNS:istio-sidecar-injector, DNS:istio-sidecar-injector.istio-control, DNS:istio-sidecar-injector.istio-control.svc
 Subject: CN = istio-sidecar-injector.istio-control.svc

[ ] Configuration Infrastructure
[ ] Docs
[X] Installation
[X] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ X] User Experience
[ ] Developer Infrastructure
Additional context

Gaps so far:

cert rotation after 1 year
may need to be integrated as a library into operator/istioctl to not distribute a second binary

It would be nice to extend the tool to also generate SPIFFE certificates ( relatively easy, just
change the CSR), and maybe to auto-generate them by watching the service accounts - this would provide equivalent functionality with citadel, but using K8S own CA.

I did some testing for this - it's a pretty good library, works very nicely.
https://github.com/costinm/webhook-certificate-generator has an extension to auto-generate DNS-based certs for istio service accounts ( in particular for webhooks ).
Confirmed that K8S can't sign URL SANs nor intermediary CAs - so this is only useful for DNS-based certs for webhooks or legacy services.

@costinm, can I mark this as a duplicate of https://github.com/istio/istio/issues/17060?

Duplicate of https://github.com/istio/istio/issues/17060, closing.


Update Excel.workbookquery.delete.md

Improved method.

Docs Build status updates of commit d9b05c7:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

api/Excel.workbookquery.delete.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Page Title is Get-CsOnlineUser

Super minor feedback, the page title for this page is Get-CsOnlineUser. I believe that page must have been used as a template at some stage, because both this page and the page for Get-CsOnlineVoiceRoute have "Get-CsOnlineUser" as a title in the web browser.
See #4815 for related page. I am guessing there are several other pages with the same issue, may be worth reviewing quickly to ensure the title matches the cmdlet documented.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 020ad32c-9838-fbe1-0d40-9d521e944db5
Version Independent ID: 560561f2-d610-de41-f8fc-6cb9412784c7
Content: Get-CsOnlineVoiceRoutingPolicy (skype)
Content Source: skype/skype-ps/skype/Get-CsOnlineVoiceRoutingPolicy.md
Service: skypeforbusiness-powershell
GitHub Login: @tomkau
Microsoft Alias: tomkau

@officedocsbot assign @yogkumgit

@get-itips  Thank you very much for the contribution and updating the documentation with PR. @VladimirGluten47 Hope this update is helpful for you. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.


Azure File Copy stopped working

Required Information
Entering this information will route you directly to the right team and expedite traction.
Question, Bug, or Feature?
Type: Bug
Enter Task Name: AzureFileCopyV2
Environment

Server - Azure Pipelines or TFS on-premises?

If using Azure Pipelines, provide the account name, team project name, build definition name/build number:
Account name: squk-central
Team: Code Metrics
Build definition: Release definition 2
Build id: release id 195

https://squk-central.visualstudio.com/Code Metrics/_releaseProgress?_a=release-environment-logs&releaseId=195&environmentId=363

Agent - Hosted or Private: Private.

If using private agent, provide the OS of the machine running the agent and the agent version: Windows 10, 2.174.1

Issue Description
I have a production release pipeline on Azure DevOps with AzureFileCopyV2. It stopped working without apparent reason.
I followed a lot of posts regarding permissions to service principal, and it seems that the content is being uploaded to the storage account but by whatever reason (the log isn't clear), it is unable to download on the target machine.
Task logs
2020-10-26T15:07:52.1182836Z ##[section]Starting: Copy Files to Azure VM
2020-10-26T15:07:52.1821762Z ==============================================================================
2020-10-26T15:07:52.1822447Z Task         : Azure file copy
2020-10-26T15:07:52.1823085Z Description  : Copy files to Azure Blob Storage or virtual machines
2020-10-26T15:07:52.1823692Z Version      : 2.175.3
2020-10-26T15:07:52.1824213Z Author       : Microsoft Corporation
2020-10-26T15:07:52.1824964Z Help         : https://docs.microsoft.com/azure/devops/pipelines/tasks/deploy/azure-file-copy
2020-10-26T15:07:52.1825745Z ==============================================================================
2020-10-26T15:07:56.6443324Z Added TLS 1.2 in session.
2020-10-26T15:07:57.6998914Z ##[command]Import-Module -Name C:\Program Files\WindowsPowerShell\Modules\AzureRM\6.13.1\AzureRM.psd1 -Global
2020-10-26T15:08:29.0523994Z ##[command]Clear-AzureRmContext -Scope Process
2020-10-26T15:08:29.0525091Z ##[command]Disable-AzureRmContextAutosave -ErrorAction Stop
2020-10-26T15:08:31.3756886Z WARNING: AzureRM.Profile already loaded. Az and AzureRM modules cannot be imported in the same session or used in the
2020-10-26T15:08:31.3758369Z same script or runbook. If you are running PowerShell in an environment you control you can use the 'Uninstall-AzureRm'
2020-10-26T15:08:31.3759551Z  cmdlet to remove all AzureRm modules from your machine. If you are running in Azure Automation, take care that none of
2020-10-26T15:08:31.3760555Z  your runbooks import both Az and AzureRM modules. More information can be found here:
2020-10-26T15:08:31.3761358Z https://aka.ms/azps-migration-guide.
2020-10-26T15:08:32.1313383Z WARNING: AzureRM.Profile already loaded. Az and AzureRM modules cannot be imported in the same session or used in the
2020-10-26T15:08:32.1315177Z same script or runbook. If you are running PowerShell in an environment you control you can use the 'Uninstall-AzureRm'
2020-10-26T15:08:32.1316861Z  cmdlet to remove all AzureRm modules from your machine. If you are running in Azure Automation, take care that none of
2020-10-26T15:08:32.1318449Z  your runbooks import both Az and AzureRM modules. More information can be found here:
2020-10-26T15:08:32.2241608Z https://aka.ms/azps-migration-guide.
2020-10-26T15:08:32.6757734Z ##[command]Add-AzureRMAccount -ServicePrincipal -Tenant *** -Credential System.Management.Automation.PSCredential -Environment AzureCloud @processScope
2020-10-26T15:08:34.4633289Z ##[command] Select-AzureRMSubscription -SubscriptionId c25996f4-001e-4393-9d9b-705d6baef5a7 -TenantId ***
2020-10-26T15:08:43.2132841Z Uploading files from source path: 'C:\agent_work\r1\a\Code Metrics Latest' to storage account: 'sonarqubediag174' in container: '6fc05552-86b8-42f1-ad73-fdba84a22cc2' with blob prefix: ''
2020-10-26T15:08:43.2381933Z ##[command] & "AzCopy\AzCopy.exe" /Source:"C:\agent_work\r1\a\Code Metrics Latest" /Dest:"https://sonarqubediag174.blob.core.windows.net/6fc05552-86b8-42f1-ad73-fdba84a22cc2" /@:"C:\agent_work_temp\d5ndlb21nwprdja5fpkh3vunmi" /XO /Y /SetContentType /Z:"AzCopy" /V:"AzCopy\AzCopyVerbose_b55edc96-a4b0-4ec9-b989-dfe89c67dbfb.log" /S
2020-10-26T15:09:26.2329960Z [2020/10/26 08:09:26] Transfer summary:
2020-10-26T15:09:26.2330737Z -----------------
2020-10-26T15:09:26.2331218Z Total files transferred: 1571
2020-10-26T15:09:26.2331719Z Transfer successfully:   1571
2020-10-26T15:09:26.2332187Z Transfer skipped:        0
2020-10-26T15:09:26.2332611Z Transfer failed:         0
2020-10-26T15:09:26.2333141Z Elapsed time:            00.00:00:42
2020-10-26T15:09:26.7168542Z Uploaded files successfully from source path: 'C:\agent_work\r1\a\Code Metrics Latest' to storage account: 'sonarqubediag174' in container: '6fc05552-86b8-42f1-ad73-fdba84a22cc2' with blob prefix: ''
2020-10-26T15:09:36.4100595Z [Azure Call]Getting the custom script extension 'WinRMCustomScriptExtension' for vm 'SonarQube-App'
2020-10-26T15:09:36.8142781Z [Azure Call]Got the custom script extension 'WinRMCustomScriptExtension' for vm 'SonarQube-App'
2020-10-26T15:09:36.8605371Z [Azure Call]Getting the status for vm 'SonarQube-App'
2020-10-26T15:09:37.7224961Z [Azure Call]Got the status for vm 'SonarQube-App'
2020-10-26T15:09:42.6212623Z PSSession created for Machines:'codemetrics.westeurope.cloudapp.azure.com'
2020-10-26T15:09:44.7497727Z ================================================ codemetrics.westeurope.cloudapp.azure.com ================================================
2020-10-26T15:09:49.8348547Z ================================================ codemetrics.westeurope.cloudapp.azure.com ================================================
2020-10-26T15:09:49.9243233Z ##[command]& 'C:\Windows\System32\WindowsPowerShell\v1.0\powershell.exe' -NoLogo -NoProfile -NonInteractive
2020-10-26T15:09:49.9244190Z -ExecutionPolicy Unrestricted -Command ".
2020-10-26T15:09:49.9244941Z 'C:\Users\SonarQube\AppData\Local\Temp\2f0050b2-7ff7-4484-b0b3-90aa10348e60.ps1'"
2020-10-26T15:09:49.9245737Z
2020-10-26T15:09:49.9290741Z
2020-10-26T15:09:49.9292790Z
2020-10-26T15:09:49.9325384Z
2020-10-26T15:09:49.9327504Z
2020-10-26T15:09:49.9357930Z     Directory: C:\Windows\DtlDownloads\AFC_48c7c1a7-6989-4dbb-bac0-0dfe2f3d5ea3
2020-10-26T15:09:49.9358804Z
2020-10-26T15:09:49.9389152Z
2020-10-26T15:09:49.9391268Z
2020-10-26T15:09:49.9418876Z
2020-10-26T15:09:49.9420919Z
2020-10-26T15:09:49.9447853Z Mode                LastWriteTime         Length Name
2020-10-26T15:09:49.9448767Z
2020-10-26T15:09:49.9480041Z ----                -------------         ------ ----
2020-10-26T15:09:49.9481056Z
2020-10-26T15:09:49.9511908Z d-----       10/26/2020   3:09 PM                AzCopy
2020-10-26T15:09:49.9512664Z
2020-10-26T15:09:54.9588372Z ================================================ codemetrics.westeurope.cloudapp.azure.com ================================================
2020-10-26T15:09:59.9731806Z ================================================ codemetrics.westeurope.cloudapp.azure.com ================================================
2020-10-26T15:10:04.9734768Z ================================================ codemetrics.westeurope.cloudapp.azure.com ================================================
2020-10-26T15:10:09.9813188Z ================================================ codemetrics.westeurope.cloudapp.azure.com ================================================
2020-10-26T15:10:14.9863790Z ================================================ codemetrics.westeurope.cloudapp.azure.com ================================================
2020-10-26T15:10:20.1786887Z ================================================ codemetrics.westeurope.cloudapp.azure.com ================================================
2020-10-26T15:10:25.0214106Z ================================================ codemetrics.westeurope.cloudapp.azure.com ================================================
2020-10-26T15:10:30.0397551Z ================================================ codemetrics.westeurope.cloudapp.azure.com ================================================
2020-10-26T15:10:30.2549046Z [2020/10/26 15:10:27][ERROR] Error parsing source location
2020-10-26T15:10:30.2551276Z "https://sonarqubediag174.blob.core.windows.net/6fc05552-86b8-42f1-ad73-fdba84a22cc2": Failed to enumerate directory
2020-10-26T15:10:30.2553000Z https://sonarqubediag174.blob.core.windows.net/6fc05552-86b8-42f1-ad73-fdba84a22cc2 with file pattern . The underlying
2020-10-26T15:10:30.2554457Z connection was closed: An unexpected error occurred on a receive.
2020-10-26T15:10:30.2556935Z At line:1 char:1
2020-10-26T15:10:30.2558109Z + & 'C:\Windows\System32\WindowsPowerShell\v1.0\powershell.exe' -NoLogo ...
2020-10-26T15:10:30.2559244Z + ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2020-10-26T15:10:30.2560663Z     + CategoryInfo          : NotSpecified: ([2020/10/26 15:...d on a receive.:String) [], RemoteException
2020-10-26T15:10:30.2563500Z     + FullyQualifiedErrorId : NativeCommandError
2020-10-26T15:10:30.2564838Z
2020-10-26T15:10:30.2565627Z
2020-10-26T15:10:30.2728234Z
2020-10-26T15:10:30.2754469Z HttpStatusMessage:
2020-10-26T15:10:30.2757686Z RequestId:
2020-10-26T15:10:30.2761016Z Time: For more details, please type "AzCopy /?:Source" or use verbose option /V.
2020-10-26T15:10:30.2763118Z
2020-10-26T15:10:30.2766139Z
2020-10-26T15:10:30.2792897Z
2020-10-26T15:10:30.2824184Z
2020-10-26T15:10:30.2854815Z
2020-10-26T15:10:30.2856458Z
2020-10-26T15:10:30.2885083Z
2020-10-26T15:10:30.2886739Z
2020-10-26T15:10:32.2347204Z WARNING: AzureRM.Profile already loaded. Az and AzureRM modules cannot be imported in the same session or used in the
2020-10-26T15:10:32.2358061Z same script or runbook. If you are running PowerShell in an environment you control you can use the 'Uninstall-AzureRm'
2020-10-26T15:10:32.2365374Z  cmdlet to remove all AzureRm modules from your machine. If you are running in Azure Automation, take care that none of
2020-10-26T15:10:32.2366840Z  your runbooks import both Az and AzureRM modules. More information can be found here:
2020-10-26T15:10:32.2368105Z https://aka.ms/azps-migration-guide.
2020-10-26T15:10:32.8760598Z WARNING: AzureRM.Profile already loaded. Az and AzureRM modules cannot be imported in the same session or used in the
2020-10-26T15:10:32.8762638Z same script or runbook. If you are running PowerShell in an environment you control you can use the 'Uninstall-AzureRm'
2020-10-26T15:10:32.8764473Z  cmdlet to remove all AzureRm modules from your machine. If you are running in Azure Automation, take care that none of
2020-10-26T15:10:32.8765964Z  your runbooks import both Az and AzureRM modules. More information can be found here:
2020-10-26T15:10:32.8773994Z https://aka.ms/azps-migration-guide.
2020-10-26T15:10:33.1581590Z ##[command]Logout-AzAccount -Scope Process -ErrorAction Stop
2020-10-26T15:10:34.0170736Z WARNING: AzureRM.Profile already loaded. Az and AzureRM modules cannot be imported in the same session or used in the
2020-10-26T15:10:34.0172725Z same script or runbook. If you are running PowerShell in an environment you control you can use the 'Uninstall-AzureRm'
2020-10-26T15:10:34.0174382Z  cmdlet to remove all AzureRm modules from your machine. If you are running in Azure Automation, take care that none of
2020-10-26T15:10:34.0175867Z  your runbooks import both Az and AzureRM modules. More information can be found here:
2020-10-26T15:10:34.0245685Z https://aka.ms/azps-migration-guide.
2020-10-26T15:10:34.5299516Z ##[error]Non-Zero exit code: '1' for ComputerName: 'SonarQube-App'
2020-10-26T15:10:34.9968307Z ##[section]Finishing: Copy Files to Azure VM
Error logs
[ERROR] Error parsing source location "https://sonarqubediag174.blob.core.windows.net/6fc05552-86b8-42f1-ad73-fdba84a22cc2": Failed to enumerate directory https://sonarqubediag174.blob.core.windows.net/6fc05552-86b8-42f1-ad73-fdba84a22cc2 with file pattern . The underlying connection was closed: An unexpected error occurred on a receive.

@ericlemes Can you try Azure File Copy Version 3 or 4? 4 requires some extra permissions as mentioned here https://brettmckenzie.net/2020/03/23/azure-pipelines-copy-files-task-authentication-failed/

Hi @AmrutaKawade I tried v4 and got a similar error.
https://squk-central.visualstudio.com/Code Metrics/_releaseProgress?_a=release-environment-logs&releaseId=194&environmentId=361
2020-10-26T14:43:04.6723176Z Failed while downloading azcopy.exe from the URL with exception Exception calling "DownloadFile"

You can ping me on Teams if you'd like to discuss in details (Alias ercintra)

@ericlemes Can you send a snapshot of your pipeline once or provide permission to view the pipeline.. I am unable to open the link that you have provided.
While copying to VM, try to enable the options as shown in snapshot

Hi @20shivangi,
Unfortunately I can't give you rights for this repo which is private. I've been debugging this issue with @AmrutaKawade and we found out that the issue is because this machine has TLS versions older than 1.2 disabled and the internal way of downloading the azure copy to the remote machine that will then download the files uses System.Net.WebClient which by default tries to use older TLS versions.
Hence the reason why in the log we can see:
2020-10-26T15:10:30.2554457Z connection was closed: An unexpected error occurred on a receive.
Not sure about the solution though.

Adding https://*.windows.net in trusted sites on VM should fix this issue for AzureFileCopy V4


[Beta] useTransition API

Preview

@gaearon In this example you are passing isPending to Layout inside Router component in order to change opacity of the header section. By "rewrapping" navigate with startTransition in the IndexPage component it seems like isPending inside Router is always false and does not affect the header's opacity. Is that expected behavior? If so I would imagine it could break router logic that depends on the isPending flag.

Hmm interesting. Maybe this is a bug. I'll need to follow-up on that.


some fixes for firefox, and normalise version names

This adds Firefox to throughput_graphs.sh.
Main change is to normalise the version names for each browser -- I chose stable, beta, and canary but am open to suggestions.
Turns out we currently can't proxy in Firefox 40+ but I filed a separate issue and this will be useful to investigate:
https://github.com/uProxy/uproxy/issues/1777

Outside the localchrome validation, :+1:

I think I added it back, PTAL!

OK, assuming the localchrome stuff is good, will merge this. Thanks!


Add Link to own profile in user menu

Currently it seems that users don't have the ability to access their own profile page quickly from our homepage. When the user logs in, one of the obvious places that the user should be able to click on is their own profile picture or the profile name under the drop-down and I think ideally that should link to their own page.

I feel this is useful since they might want to quickly add the long description (about section) in their profile page. So currently the way they might do it will be to go to settings and then click on the profile picture or maybe directly typing their profile slug on the url bar (if they know it). 🤔
Suggestion: Simple solution is to add a link from the profile picture under the settings drop-down which links to their profile page.

Let me know if you agree with this or if you have any other suggestions. 😄
@opencollective/design @Betree

Good catch, it's not only from the home page, all of them are impacted. Avatar + name should definitely be clickable and link to your personal profile page.

I agree with @Betree as the quick solution!

Avatar + name should definitely be clickable and link to your personal profile page.

However it can be a little elusive and if we want to be super clear, we could do something like this.


Rm use of object values

Description
What changed?
Are there any files to ignore?

Awaiting to see these test pass in carbon


Mafia: Remove players from sublist after being manually added

Stops the above from happening.

Being done in #4493

whoops! :face_with_head_bandage:


can't use!

[Unhandled promise rejection: Error: The URL: https://api.microsofttranslator.com/V2/Http.svc/Translate?&to=fr&text='Engineering physics or engineering science refers to the study of the combined disciplines of physics', Error: Error: The URL: https://api.microsofttranslator.com/V2/Http.svc/Translate?&to=fr&text='Engineering physics or engineering science refers to the study of the combined disciplines of physics', Error: Error: The URL: https://api.microsofttranslator.com/V2/Http.svc/Translate?&to=fr&text='Engineering physics or engineering science refers to the study of the combined disciplines of physics', Error: Generic error]
upon is my test error message.

Please follow up on this issue instead https://github.com/danialkalbasi/react-native-power-translator/issues/18.


SAMR21x16 Cannot write > 3840 bytes

When programming the SAMR21x16 I get an error when programming files greater than 3840 bytes.
3840 Bytes
Device       : ATSAMR21x16
Version      : v2.0 [Arduino:XYZ] Sep 15 2019 08:29:47
Address      : 0x0
Pages        : 1024
Page Size    : 64 bytes
Total Size   : 64KB
Planes       : 1
Lock Regions : 16
Locked       : none
Security     : false
BOD          : true
BOR          : true
Erase flash
Done in 0.190 seconds
Write 3840 bytes to flash (60 pages)
[==============================] 100% (60/60 pages)
Done in 0.023 seconds
Verify 3840 bytes of flash
[==============================] 100% (60/60 pages)
Verify successful
Done in 0.228 seconds
When the file is 3841 bytes it fails
Device       : ATSAMR21x16
Version      : v2.0 [Arduino:XYZ] Sep 15 2019 08:29:47
Address      : 0x0
Pages        : 1024
Page Size    : 64 bytes
Total Size   : 64KB
Planes       : 1
Lock Regions : 16
Locked       : none
Security     : false
BOD          : true
BOR          : true
Erase flash
Done in 0.190 seconds
Write 3841 bytes to flash (61 pages)
[                              ] 0% (0/61 pages)
SAM-BA operation failed
Has anybody got a workaround for this problem ?

Pull Request submitted with solution


refactor: output release info to generated data dir

#834  👈 (View in Graphite)
main

This stack of pull requests is managed by Graphite. Learn more about stacking.


Release sdk/resourcemanager/reservations/armreservations/0.1.0

[ ] The purpose of this PR is explained in this or a referenced issue.
[ ] The PR does not update generated files.

These files are managed by the codegen framework at Azure/autorest.go.

[ ] Tests are included and/or updated for code changes.
[ ] Updates to CHANGELOG.md are included.
[ ] MIT license headers are included in each file.

/azp run prepare-pipelines

/azp run go - armreservations - ci


fieldset time dimension

Hello
I'm just a new user trying to read my model outputs from a netcdf file with following:
variables={'U': 'UVEL', 'V' :'VVEL', 'W':'WVEL'}
dimensions['U']={'time':'T','depth':'diag_levels','lat':'Y','lon':'Xp1'}
dimensions['V']={'time':'T','depth':'diag_levels','lat':'Yp1','lon':'X'}
dimensions['W']={'time':'T','depth':'diag_levels','lat':'Y','lon':'X'}
fset = FieldSet.from_netcdf(filenames, variables, dimensions,full_load=True)
however I'm getting this error:
field.pyc in from_netcdf(cls, filenames, variable, dimensions, indices, grid, mesh, allow_time_extrapolation, time_periodic, full_load, dimension_filename, **kwargs)
221                             data[ti:ti+len(tslice), 0, :, :] = filebuffer.data[:, :, :]
222                     else:
--> 223                         data[ti:ti+len(tslice), :, :, :] = filebuffer.data[:, :, :, :]
224                 ti += len(tslice)
225         else:
ValueError: could not broadcast input array from shape (583,50,200,176) into shape (1,50,200,176)
T is the unlimited dimension so it's a masked array. could this be causing the problem?

I indeed expect that the problem is related to your time dimension. Could you copy the header of your netcdf file here, so that we can have a look?
By the way, is there a reason that you use full_load=True? Do you also get an error when you use full_load=False?

Actually I tried first without full_load and then with, and also with specified indices but i got the same error.
"
<type 'netCDF4._netCDF4.Dataset'>
root group (NETCDF3_CLASSIC data model, file format NETCDF3):
MITgcm_version: checkpoint66g
...
MITgcm_mnc_ver: 0.9
sNx: 22
sNy: 25
OLx: 5
OLy: 5
nSx: 1
nSy: 1
nPx: 8
nPy: 8
Nx: 176
Ny: 200
Nr: 50
dimensions(sizes): T(583), Zmd000050(50), Xp1(177), Y(200), X(176), Yp1(201), Zld000050(50)
variables(dimensions): float64 diag_levels(Zmd000050), float64 Xp1(Xp1), float64 Y(Y), float64 X(X), float64 Yp1(Yp1), float64 T(T), int32 iter(T), float32 UVEL(T,Zmd000050,Y,Xp1), float32 VVEL(T,Zmd000050,Yp1,X), float32 WVEL(T,Zld000050,Y,X)
"
for T:
<type 'netCDF4._netCDF4.Variable'>
float64 T(T)
long_name: model_time
units: seconds since 2012-01-01, 00:00:00
unlimited dimensions: T
current shape = (583,)
filling on, default _FillValue of 9.96920996839e+36 used

OK, thanks. Nothing immediately jumps out as an obvious problem.
Would you mind sending me a copy of the netcdf file, so I can try to debug? Could even be a subset if the full thing is too large. My email address is<EMAIL_ADDRESS>perhaps you can use a transfer service like wetransfer or similar?

After having explored the netcdf file you sent me, I think I have a fix. It's in a branch at https://github.com/OceanParcels/parcels/compare/fix-mitgcm-time-dimension
Could you try run with this branch, and see if that fixes the error for you?

This branch has now become a PR (see #460) and I've also cleaned the code a bit. You will now have to explicitly add netcdf_engine='scipy' in your line
fset = FieldSet.from_netcdf(filenames, variables, dimensions, netcdf_engine='scipy')

Can you please check whether this now works for you?


Text symbolizer resets color to #000000

Bug
Describe the bug
The SLD parser appears to not parse the text color properly and resets it to #000000. This happens with SLDs from QGIS as well as the SLD generated by the demo app.
To Reproduce
Steps to reproduce the behavior:

Go to https://geostyler.github.io/geostyler-demo/
Edit Rule 1 to be of Kind: Text and choose a color other than black
Copy the SLD in the Code Editor to clipboard
Reload the page and paste the SLD from clipboard
Observe that the CSS parameter fill in Fill changes from your chosen color to #000000

Expected behavior
The SLD parser should recognize the the color and not change it to the default.
Additional context
I had a quick glance through the code of the SLD parser and I couldn't immediately see what is going wrong as it tries to extract the fill and fill-opacity from the CSS parameters.

Thanks for the info @rdewit.
@KaiVolland fixed this in https://github.com/geostyler/geostyler-sld-parser/pull/532


RemovedInDjango19Warning

I ran migrate and Django gave me this error three times.
$ ./manage.py migrate
$VIRTUAL_ENV/local/lib/python2.7/site-packages/simple_history/models.py:9:
RemovedInDjango19Warning: The utilities in django.db.models.loading are deprecated in
favor of the new application loading system.
  from django.db.models import loading

$VIRTUAL_ENV/local/lib/python2.7/site-packages/simple_history/models.py:14:
RemovedInDjango19Warning: django.utils.importlib will be removed in Django 1.9.
  from django.utils import importlib, six

$VIRTUAL_ENV/local/lib/python2.7/site-packages/django/contrib/admin/util.py:7:
RemovedInDjango19Warning: The django.contrib.admin.util module has been renamed. Use
django.contrib.admin.utils instead.
  "Use django.contrib.admin.utils instead.", RemovedInDjango19Warning)

Thanks for reporting this @andyosuna!  Those warnings can be safely ignored for now, but we should handle them before 1.9 is released.
What version of Django are you running?

Also what version of simple history are you on?

1.8.2 :grimacing:
simple history 1.6.1

Ah it looks like there are changes in the master branch to remove those warnings that show up on 1.8.
It looks like we need to do a new release to PyPI.
@macro1 I can do a release if you want me to. 1.6.2 or 1.7.0?

You can do a 1.6.2 release... All it will do is remove warnings. I didn't
release because nothing functionally changed.
On Jul 4, 2015 8:00 PM, "Trey Hunner"<EMAIL_ADDRESS>wrote:

Ah it looks like there are changes in the master branch
https://github.com/treyhunner/django-simple-history/compare/1.6.1...master
to remove those warnings that show up on 1.8.
It looks like we need to do a new release to PyPI.
@macro1 https://github.com/macro1 I can do a release if you want me to.
1.6.2 or 1.7.0?
—
Reply to this email directly or view it on GitHub
https://github.com/treyhunner/django-simple-history/issues/181#issuecomment-118542714
.

I made a new release to PyPI.


SpringApplicationConfiguration annotation marked as deprecated

Annotation "@SpringApplicationConfiguration" in HelloControllerTest class (line 20) is marked as deprecated right after opening the project.

Resolved via #26


[CLI] Add clever error support to Sui CLI

Description
Enables clever error rendering in the Sui CLI.
It also abstracts out some of the rendering logic for constants into their own file so it can be reused across the graphql and Sui CLI renderer.
This also updates the Move disassembler to use this new (nicer!) renderer to that we support rendered values for constants in the Move disassembler instead of just strings in constants.
Test plan
Added new tests for this to the Sui CLI, and updated/added additional tests for the disassembler.

Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

[ ] Protocol:
[ ] Nodes (Validators and Full nodes):
[ ] Indexer:
[ ] JSON-RPC:
[ ] GraphQL:
[X] CLI: Add better rendering for Move aborts, and added support for rendering clever errors.
[ ] Rust SDK:

This should be updated so we now render clever errors in the displays as well. I had...a lot of fun with the fact that Display is not async in Rust before coming to the pre-rendering solution here.


Feature Request: Route Guard

Add a function prop to allow navigation to a requested route to simplify guarding rather than using component's onMount.

My bad, it's already there : https://github.com/lyohaplotinka/svelte-easyroute/wiki/7.-Navigation-guards


feat: max file size validation

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@jkuri please, review and release it ASAP


Remove CONTRIBUTORS.md

Summary
The authors of all Qiskit elements are maintained in the Qiskit/qiskit authors file. Thus, Aqua's CONTRIBUTORS.md can be removed.
Details and comments
The authors file is currently missing following authors we have in CONTRIBUTORS.md:

[ ] Sergey Bravyi
[ ] Tal Kachmann
[ ] Martin Mevissen
[ ] Nikolaj Moll
[ ] Julia Rice
[ ] Kanav Setia
[ ] Andrea Simonetto
[ ] Ivano Tavernelli

Missing in general:

[ ] Igor Sokolov (resolved as soon as #746 is merged)

Existing by GitHub name only:

[x] Christa Zoufal (aka Zoufalc)
[x] Almudena Carrera Vazquez (aka anedumla)
[x] Max Rossmannek (aka mrossinek)

These should be properly added.

Also the qiskit authors file misses

Ivano Tavernelli
Igor Sokolov
Almudena Carrera Vazquez

and there quite some duplicates.

May I add myself to the list of "missing" authors since I am only listed via my Github username.

[ ] Max Rossmannek

I already had a look at the script which generates the AUTHORS file a while back and noticed that this line where the username qiskit-bot is being omitted.
If one would generalize this line and check against a blacklist of authors (such as duplicate names) and implement another whitelist of authors who are added regardless of the gathered Github names one could easily automate the corrections proposed here into the workflow of generating the AUTHORS file.

Look at the .mailmap file here - these are what are used by the tooling for naming changes etc

I updated the checklist above with the names in your comments.

It's possible to change names via .mailmap, however it's not possible to add people that have no email associated with a commit.
@mtreinish @yehuda-naveh Could we add a whitelist to Qiskit's author list as @mrossinek suggested?

@Cryoris "Igor Sokolov (resolved as soon as #746 is merged)" merged now


[WIP] OpenCV.js plugin

Hi!
In this PR you may find OpenCV's equalizeHist. Note: default image quality is 70% (Jpeg compression) which produces artifacts. Current way to apply it correctly is to set 100% image quality at the new task creation stage.

origin
equalizeHist over 70%
equalizeHist over 100%

OpenCV.js: opencv.js.zip
TODO:

[ ] Keep OpenCV transformations in case of other changes: rotation, scroll

@dkurt , I cannot see opencv.js in the PR.

@nmanovic, Yes, there is no OpenCV.js there because if there will new new methods it's required to upload it again that means all the previous versions of OpenCV.js will still live in the git history.
Is there an option to download it during docker-compose build ?

@nmanovic, Uploaded opencv.js as npm package: https://www.npmjs.com/package/opencv_js_cvat
Probably this is not the best solution, but to download it I used https://unpkg.com/

@dkurt , I will close the PR. It looks like nobody is going to finish it.


Configure no_superfluous_phpdoc_tags for Symfony

this PR is a placeholder.
codebase needs to be adjusted

I would override the configuration in the @PhpCsFixer rule set: 'allow_mixed' => false.

I decided to allow mixed so i can still grep for them git grep "@param mixed"
then, one day, we should stop using mixed at all.

:-1:   see also https://github.com/FriendsOfPHP/PHP-CS-Fixer/pull/4566


ASK results are being written on stdout

Wrong (current) code:
ResultSetFormatter.outputAsJSON(askResult);

must be changed in:
ResultSetFormatter.outputAsJSON(new WriterOutputStream(writer, CharacterSet.UTF_8), askResult);

Issue has been fixed. Twelve integration tests [1] have been added for checking the correct behaviour.

https://github.com/agazzarini/SolRDF/blob/master/solrdf/src/test/java/org/gazzax/labs/solrdf/integration/sparql/LearningSparql_ASK_ITCase.java


iOS update

Updated projects to recommended settings. Minimum iOS target is version 8.0 now.
Fixed an issue where CDEEditor could be presented twice, causing an exception.

You have branched from master... I have changes the target of the PR to develop...

@ChristianKienle I'll make sure to branch from develop from now on then. 👍

no worries. all good. love your pr. ❤


spi_fatfs.c incompatible with freertos?

Hello - We're looking to access the sd card via spi_fatfs (similar to allon_sensor_tflm_fatfs) while use the freertos OS.  It appears all of the sample spi_fatfs.c are using the eventlibrary, and are incompatible.  While porting over spi_fatfs.c, the dp_task timesout trying to acquire with the following output
sensor_type: 15
OV5647 on by app done
g_cursensorstream: 0
os_app_dplib_cb event=-76
send to dp task 0x11c
os_app_dplib_cb event=-77
send to dp task 0x11e
dp_recv_msg_event=0x11c
dp_recv_msg_event=0x11e
main_recv_msg=0x203
main_recv_msg.msg_data=0x11c fail
main_recv_msg=0x203
main_recv_msg.msg_data=0x11e fail

Is there an example spi_fatfs that uses freertos?
Thanks!

Hi @stantonious,
We don't have this example, we'll need some time to port it.

Hi @stantonious,
We've added fatfs support for the allon_sensor_tflm_freertos application.
You can enable FATFS support by setting SUPPORT_FATFS=1.


Session Feedback

Thanks for taking a couple of minutes to give feedback, which will help me improve for next time. Before doing anything else, hit the green button "Submit new issue" right now to save this issue content, rather than try to complete the feedback in this raw form. Then go through the questions and mark a single checkbox for each, to represent your answer. Finally, in the empty comment box below this one, please describe what you liked and what you didn't like.
How experienced were you with web development in general before this session?

[ ] Didn't know what HTML is
[ ] Heard about HTML/CSS/JavaScript, but never developed a web app
[ ] Used HTML/CSS/JavaScript before, but never developed a complete web app on my own
[x] Developed one or more (smaller) web app(s) on my own
[ ] I am a very experienced web developer

How experienced were you with UI5 before this session?

[ ] Didn't know what UI5 was
[ ] Heard about UI5, but never developed a UI5 app
[ ] Used UI5 before, but never developed a complete UI5 app on my own
[x] Developed one or more (smaller) UI5 app(s) on my own
[ ] I am Peter Muessig, or at least very experienced

How do you feel about UI5 now (after this session)?

[ ] Don't know what UI5 is
[ ] Know what UI5 is, but don't know how develop a UI5 app
[ ] Know how to use parts of it, but don't know how to built a complete application on my own
[x] Know how to built a complete application on my own
[ ] I am Peter Muessig, or at least very experienced

Did this session meet your expectations?

[ ] Not really
[ ] Somewhat
[x] Mostly
[ ] Fully

Was the time allotted to each exercise enough for you to work through them?

[ ] Not really
[ ] Somewhat
[ ] Mostly
[x] Fully

What did you think of the extra information (collapsable sections 💬) and explanations provided?

[ ] Too much information
[ ] Didn't really read it, didn't really bother me though
[x] Found it helpful as context and background

How did you find the way we all moved at the same pace through the exercises?

[ ] Would have preferred to go through them on my own at my own speed
[x] Didn't mind, no strong feelings either way
[ ] Found it useful to keep pace and discuss the exercise questions, and reflect

Which development environment(s) did you use?

[ ] SAP Business Application Studio
[x] Code editor on my local machine
[ ] Devcontainer

If you have time, please add a comment below to write free-form what you liked and what you disliked about the session. Thank you!

Really loved the extra information and redirects (embedded links) to explanations, as it better helps to understand what is happening - opposed to just seeing what is happening.
Great the energy/enthusiasm and I enjoy the informal setting.
See you at UI5Con!
5/5


feat: Allow specifying compute environments for queue

Description
Allow specifying compute environments for a job queue, and fix an issue when there are more than 3 compute environments.
Motivation and Context
Job queue should have maximum 3 compute environments associated with it.
Current version attaches ALL compute environments to all job queues, which is an issue because if more than 3 compute environments are defined - the apply will fail.
In addition, the module do not allow specifying compute environment(s) to be used by a specific queue.
Breaking Changes

No
How Has This Been Tested?

[x] I have updated at least one of the examples/* to demonstrate and validate my change(s)
[x] I have tested and validated these changes using one or more of the provided examples/* projects

[x] I have executed pre-commit run -a on my pull request

Who's responsible for reviews?

This issue has been resolved in version 2.0.0 :tada:


Integration testing

This is medium-difficulty for any newcomers, as it requires a somewhat intimate familiarity with the library.
Currently, much of the code that requires doing actual networking calls to a Kafka server are not tested. We can take advantage of Docker and Travis to enable integration testing the networking methods. I did some research and playing around today, and I came up with a setup that seems to work.
Basically, we set up a docker-compose.yml that uses a public Kafka container from the Docker registry, and give the Kafka version as a parameter. Then we set up our .travis.yml to run the tests for each Kafka version we want to test against. This will allow us not only to ensure sure the code works as intended, but also verify compatibility across as many versions of Kafka as we'd like. I realize that this crate is still pre-1.0, so retroactively adding tests for everything might be overkill, since the API is still subject to change, but it should help with getting at least the most important methods tested for correctness.
For testing locally, you would just need to have Docker and Compose installed and then, before running the cargo integration tests:

Set the KAFKA_VER environment variable in your shell
Bring up the desired Kafka container with docker-compose up -d

This commit in a branch of my fork showcases the code changes necessary. It uses the latest versions of 0.8, 0.9, and 0.10, and includes a simple integration test for loading the KafkaClient metadata. This is what a Travis build would look like.
What do you think?
Update
The above has been implemented and merged in #143! Let's keep this issue around to track progress of integration test backfilling.

yes, that definitely is quite cool! 👍 (many many thanks for the initiative!) it's a start to build up a integration test suite - which is missing so far. Some points/ideas coming to my mind:

can we run cargo test without the integration tests? (executing merely the unit tests; i'd say during development one wants to run the unit tests more often than the full integration tests since the latter typically run longer.)
i think it would be good to have the possibility to run all of this - maybe with a single script - on a local machine without the dependence on travis (assuming docker is available and running on the machine.)
i was wondering: how comes the test in your commit can assert exactly a single topic in the kafka broker with exactly two partitions? where is it defined that such a topic - and only this one - exists in the broker?
since kafka-rust is not covering any of the kafka administrative APIs, we might need to further think about how to reset the state in kafka between individual integration tests.
further, i believe it would be great trying to make a set up which includes more than one broker. there's lots of potentials in the code for errors when considering a cluster instead of a single broker kafka set-up.

I hope these ideas can be helpful.

can we run cargo test without the integration tests?

Yep, cargo test has the --doc, --lib, and --test options for running the documentation, unit, and integration tests, respectively.

i think it would be good to have the possibility to run all of this - maybe with a single script - on a local machine without the dependence on travis

Yep, as I described, all you need to do is set the KAFKA_VER env variable, and then do docker-compose up -d, and then you're good to go. It would be simple to write a script or a Makefile to do this automatically.

i was wondering: how comes the test in your commit can assert exactly a single topic in the kafka broker with exactly two partitions? where is it defined that such a topic - and only this one - exists in the broker?

Sorry, this was not obvious. The wurstmeiser/kafka Docker container is configured via its environment variables; the automatic creation of topics is controlled by the KAFKA_CREATE_TOPICS variable set here.

since kafka-rust is not covering any of the kafka administrative APIs, we might need to further think about how to reset the state in kafka between individual integration tests.

Yes, we'll definitely have to think about how to control broker state, because the larger the test suite gets, the more they will get tangled with each other. It may even be necessary to not run the integration tests in parallel.

further, i believe it would be great trying to make a set up which includes more than one broker. there's lots of potentials in the code for errors when considering a cluster instead of a single broker kafka set-up.

Indeed, we will definitely need to test clustered environments as well; the wurstmeister/kafka container does have the ability to scale to multiple nodes, but I haven't played with that yet.
We can use this issue as an ongoing place for discussion of these problems, until they're mostly ironed out.

i think it would be good to have the possibility to run all of this - maybe with a single script - on a local machine without the dependence on travis

Yep, as I described, all you need to do is set the KAFKA_VER env variable, and then do docker-compose up -d, and then you're good to go. It would be simple to write a script or a Makefile to do this automatically.

I just added a script named test to my branch which takes care of the docker setup and runs all tests with all Kafka versions automatically, if you'd like to check it out.

@dead10ck thanks for all your answers and the script. the idea becomes clearer to me. i like it! 👍 i'm a bit worried about the fact that the we'd need to spread the the topic creation (i.e. setting up the test) from the actual tests (this might lead to a difficult-to-maintain test-suite.) currently, this is our only chance. and as you'd said we can improve on this in the future.

 I have a PR open that adds a basic integration testing framework via Docker: #143. If you're familiar with Docker setups, I would appreciate a review! The tests in the PR are rather basic, but I wanted to get the framework settled first. Once it's merged, others can begin backfilling integration tests.

This has been merged in #143. Let's keep this issue around to track backfilling integration tests for the rest of the crate, where appropriate.

Is this issue still relevant?


[ColorPicker] Current Naive CMYK conversion function is not useful (or accurate)

Description of the new feature / enhancement
Currently, ColorPicker uses Naive CMYK conversion function to convert sRGB to CMYK.
black = 1 - max(red, green, blue)
cyan = (1 - red - black) / (1 - black)
magenta = (1 - green - black) / (1 - black)
yellow = (1 - blue - black) / (1 - black)

This conversion function was coincidentally also defined in CSS Color Model Level 4 (old draft version 2021-06-01), [1]
but Naive CMYK was removed in the latest draft version 2021-12-15 [2], probably due to being useless.
As far as I know, no other popular software uses this conversion function.
Why Naive CMYK is not useful (also not accurate)?

When multiple inks are printed on paper, some chemical and physical reactions happen. It is difficult to predict with math only.
The tone responsive of ink does not follow simple gamma rule, and the hue may even slightly change given single ink at different density.
One color may have multiple representations in CMYK. There is something called “black generation curve” that defines which representation to prefer. [3]
A typical black generation curve uses more CMY than K for light to medium gray, and uses more K than CMY for dark gray and black. This is to reduce banding effect and halo effect.

Which CMYK color spaces are useful?
In practical, a graphics designer who needs to use CMYK will need to deal with two CMYK color spaces:

A “working color space”, a standardized color space that the designing software uses to store images.
Typical examples are:

FOGRA39 CMYK
(ISO Standard, also recommended by W3C Color Model Level 4.)
SWOP v2 CMYK
(American standard, also default for Adobe Photoshop.)
Apple Generic CMYK
(Default for macOS, nobody else uses it, but easier to compute.)
PostScript DeviceCMYK (PostScript Language Reference Manual §7.2.3 [4])
(Default for LaTeX, mistakenly. It's called “Device”CMYK for a reason, so don't use it.)

A “device color space”, which depends on specific printer, paper, and ink.
Graphics designing software uses either ICC DeviceLink or Profile Connecting Space (PCS) to convert into them.
Therefore, we don't need to care about device color spaces.

Therefore, the solution is to target one (or multiple) standardized working color space.
What is the solution?
Unfortunately, there is no analytical formula to do the conversion, due to the reason I described.
The fastest way is to use a Look-up Table (LUT).
There are 4 options, choose either one of below:

Call the color management API provided by Windows. (ICC files are available at [5] and [6], copyright allows redistribution but not modification)
Or, import open-source library: LittleCMS2 is used by GIMP and other popular software.
Or, do the LUT lookup on our own. (Data are available at [7] and [8], be aware of copyright)
Or, precompute all 16,777,216 sRGB colors, so we don't need to embed a color management engine.
Or, just give up and remove CMYK from PowerToys. It's better not having this feature altogether, rather than misleading the users.

Scenario when this would be used?
The (only) scenario that (I can think of) is:

When the user sees a color that they want to pick, either from a document or a web page.
The user picks the color, copies the CMYK values.
The user types the CMYK values to a designing software, e.g., Adobe Photoshop or Affinity Designer.

Therefore, it is important that the CMYK value produced by ColorPicker is in a standarized “working color space”, as introduced in above section.
There is no reason that a user would ever need Naive CMYK.
Supporting information
References

W3C. CSS Color Model Level 4 (old draft version 2021-06-01): https://www.w3.org/TR/2021/WD-css-color-4-20210601/
W3C. CSS Color Model Level 4 (new draft version 2021-12-15): https://www.w3.org/TR/2021/WD-css-color-4-20211215/
ArgyllCMS. Typical usage scenarios: https://www.argyllcms.com/doc/Scenarios.html
Adobe. PostScript Language Reference Manual: https://www.adobe.com/jp/print/postscript/pdfs/PLRM.pdf
ICC. ICC Profile Registry: https://www.color.org/registry/index.xalter
Adobe. Adobe ICC Profiles download for Windows: https://www.adobe.com/support/downloads/iccprofiles/iccprofiles_win.html
ICC. CMYK Characterization Data: https://www.color.org/chardata/drsection1.xalter
FOGRA. Characterisation Data: https://fogra.org/en/downloads/work-tools/characterisation-data

Test colors
ICC profile used: Adobe ICC profile bundle, macOS ColorSync built-in profiles.
Rendering intent: relative colorimetric.

Although CSS Color Model Level 4 draft proposes using ceil(), Affinity Designer, LittleCMS2, as well as my values here use round().

This is a very technical issue, and needs to be addressed. Changes have been made to color picker since this issue was opened. Can you confirm this issue is still relevant in v0.73? /needinfo

I believe it is still relevant.
Naïve CMYK values are not used in any graphical application, thus not useful.
I would recommend either (1) including a color management framework or call the operating system’s provided API to do the conversion using an ICC file, (2) just remove the CMYK values to prevent misleading people.


How to use LayoutLM with digit-born documents such as WORD?

Describe
Model : LayoutLM
I want to use LayoutLM to extract information from WORD. I can parse  text from WORD with python-docx.  But how to get bound box?Do I have to use OCR ? Thanks.

@wangxin0718 The python-docx will not provide the 2d positions for each token in WORD. To use LayoutLM, you may need to convert the WORD into PDF, and use any PDF parser to extract texts as well as the 2d positions.


Project dependencies can be observed outside of Configuration Cache fingerprinting

Running ./gradlew :docs:userguideSinglePageHtml in the gradle/gradle build with Configuration Cache (already enabled) fails with the following error:
Caused by: java.lang.IllegalStateException: Unexpected project dependency observed outside of fingerprinting: consumer=:docs, target=:docs-asciidoctor-extensions

Build scan: https://ge.gradle.org/s/qxflkokqj6cn4

PR that introduced the related change: https://github.com/gradle/gradle/pull/29601

I am getting this in 8.10RC1 when running most documentation tasks:
* What went wrong:
Execution failed for task ':docs:userguideMultiPage'.
> Could not resolve all dependencies for configuration ':docs:detachedConfiguration5'.
   > Unexpected project dependency observed outside of fingerprinting: consumer=:docs, target=:docs-asciidoctor-extensions

https://ge.gradle.org/s/clxiaenrdt5x6

If you absolutely need to build the docs, change the wrapper version to something older:
./gradlew wrapper --gradle-version 8.10-20240722004758+0000 --distribution-type bin

I was able to start the docs build with this. Of course do not commit that change.

Another workaround is to not use CC for the task before the issue is fixed
./gradlew :docs:userguideSinglePageHtml --no-configuration-cache

The error happens

At execution time, when the Asciidoctor task's inputs are fingerprinted
This triggers a dependency substitution to resolve its target as a project dependency

the plugin uses detached configurations in that bit

which makes :docs project observe another :docs-asciidoctor-extensions project
which fails, because CC fingerprint writer is in the Paused state and does not, currently, expect any dependencies to be observed

The resolution is to ignore project dependencies observed outside of configuration time, because the work graph has already been stored and/or loaded by CC.


Add windows amd64 build target

Kept the executable name for linux to not make any breaking changes.

Thanks for the contribution.
I'd like you to change the executable name to cpfw-login.exe or cpfw-login-amd64.exe.

@felixb Done ;)

@felixb Like this?
cpfw-login.exe: .get-deps *.go
	 GOOS=windows GOARCH=amd64 go build -o $@ .

I'm not familiar with go, so I don't really know better.

It's not about go. It's about make.
But yes. that's correct. You need to change the make target in line 5 as well.


java-microprofile : Cache maven dependencies during appsody build

Checklist:

[x] Read the Code of Conduct and Contributing Guidelines.

[x] Followed the commit message guidelines.

[x] Stack adheres to Appsody stack structure.

Modifying an existing stack:

[x] Updated the stack version in stack.yaml

Break up the Dockerfile used during appsody build to allow caching of Maven dependencies. This will prevent redownloading all dependencies when source code in the user app is changed.
Related Issues:
Fixes #371

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

The way I read #371 suggests using some caching mechanism of something like Travis.
This looks, rather, like a smarter layering, reflecting the fact that every issuing of appsody build for a given stack will result in the same dependencies coming from the parent POM_.
If you agree, maybe remove the #371 reference and the word "cache"?

I have to agree I thought this will cache the open liberty zip files in the stack development image (Dockerfile-stack). It would be great if we can have the zip in the image instead of it downloading when the user runs appsody run/test/debug.

@neeraj-laad - we can layer the Dockerfile-stack file as well to get a similar behavior when appsody run is executed.

Looking at this more... in the dev image (Dockerfile-stack) we are mounting the .m2 directory into the container when appsody run is called, so we are only downloading the liberty zips once in the local workspace. Subsequent runs pull the zips from the local maven repo. I may be missing something in the run/test/debug lifecycle, but we are already caching the dependencies in this case.

Reading over the comment from @neeraj-laad

I have to agree I thought this will cache the open liberty zip files in the stack development image (Dockerfile-stack). It would be great if we can have the zip in the image instead of it downloading when the user runs appsody run/test/debug.

Like @awisniew90 said, these are already cached in the local .m2 repo, though it could still be nice to improve the experience on the very first appsody run for this stack.
I'm not sure I'd stop at having the zip in the image...  Should we just go ahead and do the mvn liberty:install-server so that it gets unzipped into the target/liberty/wlp/   ?
And we could always cut this PR at some point and do more later.. but see what you think.

Good point, we could expand the zip in a docker layer to improve time on later runs.

I will open another issue to focus on enhancements to the appsody run/test/debug (dev path) and keep this PR strictly enhancements to the appsody build path.


persian(farsi) lorem

Persian language was added to lorem

Lorem is never localized. Please use the realText provider instead.

sorry,i don't understant you,why we cannot change lorem file,i just added persian words instead of british's
it's very usefull for iranin developers


[Bug fix] Revive serviceReconciler.reconcileTargetsResource() to handle k8sService deletion de-registering targets

…8sService deletion

What type of PR is this?

Which issue does this PR fix: bug fix for #331
It's quite possible that this previous refactoring service_controller.go, cause a regression that "deleting k8sService do NOT de-registering targets".  Bring back the  (r *serviceReconciler) reconcileTargetsResource() logic to handle the k8sService deletion could fix this issue
What does this PR do / Why do we need it: bug fix for #331
If an issue # is not available please add repro steps and logs from aws-gateway-controller showing the issue:
Testing done on this change:

Automation added to e2e:
newly un-commented e2etest case pass, all test cases pass
Ran 29 of 29 Specs in 1876.938 seconds
SUCCESS! -- 29 Passed | 0 Failed | 0 Pending | 0 Skipped
--- PASS: TestIntegration (1877.46s)
PASS

Will this PR introduce any new dependencies?:

Will this break upgrades or downgrades. Has updating a running cluster been tested?:
Does this PR introduce any user-facing change?:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

can you also check manually that target de-registration is happening?

Already did the manual test, single step debug to trace the build_model and synthesizer  de-registering targets
code path, it works as expected

Please make sure the e2e test cover this scenario! So that we will NOT have another regression in future

finalizer added at line 126,  please check the service_controller.go code, for k8sService creation, it only add the finalizer. for k8sService deletion, it does de-registering targets and then remove finalizer.
controllers/service_controller.go
deregister_targets_test.go covered these use cases
deregister_targets_test.go


Merge into Image

You should think about copying or merging code from this repository into PistonDevelopers/image. It attempts to be the end-all image library, and it could use BMP support.

Thanks for the suggestion! I'll definitely look into this and create a pull request for the BMP format when time allows.

The PistonDevelopers/Image project has had support for BMP for quite a while now, so I'll close this issue


sys/stat: implement mkdirat

See: https://github.com/CraneStation/wasi-common/issues/16
https://linux.die.net/man/2/mkdirat
My first contribution to this repo. Tests were probably overkill...
Also, out of curiosity, is there any reason why mkdir is located in unistd? The documentation I read mentioned the function definition also being located in sys/stat.h.

Switched the error condition to ENOTDIR because I suspected the FreeBSD build was failing because of something related to set_permissions... not sure if that's the case, but seems to be passing now.

Rebased again...just leaving a comment because I forget if GH sends notifications for force pushes.


\tl_case:Nnn undefined.

This is a bug report from<EMAIL_ADDRESS>(this is not an email address).
jswxm says that the following code could not work with the unicode-math package, version 0.7f; in terms of version 0.8, the left vert disappears in the output PDF document.
\documentclass{article}

%\usepackage{amsmath}
\usepackage{unicode-math}

\begin{document}

        $\left|{2-1}  \right|=|1-2|$,

        $\big|{2-1}  \big|=|1-2|$

\end{document}

A new release will be heading to CTAN in the next few days…


Add raster support

This is a basic implementation of RasterDataSources.jl for NaturalEarth.  With this, the code:
using NaturalEarth, Rasters, CairoMakie
# All NaturalEarth rasters are tiffs,
# so we have to convert them manually to matrices of colors
# This might be better solved in Rasters.jl!
tiff = Raster(NaturalEarthRaster{:latest, 10, :HYP_HR}, 1)
tiff_image = Makie.RGBf.(eachslice(tiff, dims=3)...) ./ 255
image(tiff_image)

just works!

I'm also a little confused at why the tests fail attempting to download the ne_50m_coastline from https://raw.githubusercontent.com/nvkelso/natural-earth-vector/v5.1.2/geojson/ne_50m_coastline.geojson
but I'd think that's unrelated to this PR.

Yeah, I'm kind of confused as well...will have to check that out locally.

Thanks for the detailed review @rafaqz!  I'll definitely look into the layer/kwarg approach.


Feature/linting

I've newly setup lint thru eslint. We've had eslint for a long time tho, we ain't used it for a quite long time without reasons.

Usually, although almost all of codes are linting fixes, found that some critical undefined vars have been fixed and some minor codes have been fixed as well.
Not only have a lot fixes been done, but some ambiguous stuff have been left with XXX(minsu) comments. Please keep that in mind before doing code reviews.
logger.js at tracker-server/ which was duplicated.
Since the linting option at Actions have been added, npm run lint will also be run when PR is newly opened.

PTAL

Conflict resolved! PTAL

@platfowner I found out that why disparity happened just because my vscode auto fix does that... I all fixed finally. Thanks for the review! PTAL

Conflict resolved! PTAL

@platfowner PTAL. Sorry for huge confusion bcuz of 'eslint standard'. fixed em all.

PTAL. hope that we are almost there :)
Now, linting is not enforced when opening PR, but build and unittest are still checked.
Devs are able to check lint only in case of running 'npm run lint' locally. Thanks!

Yeah all tests have been passed so far :) I am merging it now. Thanks for the long journey!


apc.imports doesnt work on mac

i tried both
"apc.imports": [
        "/Users/path/styles.css",
        // ...
    ],

and
"apc.imports": [
        "file:///Users/path/styles.css",
        // ...
    ],

and non of the styles is applied to the editor.
Version: 1.82.0-insider
Commit: bf9c8105647b1e9d244f0f00155c21298e7554cf
Date: 2023-08-09T05:48:26.386Z
Electron: 25.4.0
ElectronBuildId: 22901934
Chromium: 114.0.5735.248
Node.js: 18.15.0
V8: <IP_ADDRESS>-electron.0
OS: Darwin arm64 21.6.0

works, check your styles


binary protocol v3

[x] update constants' version_codes
[x] stream id is now 2 bytes long (a [short] value), so the header is now 1 byte longer (9 bytes total).
[x] BATCH messages now have <flags> (like QUERY and EXECUTE) and a corresponding optional <serial_consistency> parameters (see Section 4.1.7).
[x] User Defined Types and tuple types have been added to ResultSet metadata (see <IP_ADDRESS>) and a new section on the serialization format of UDT and tuple values has been added to the documentation (Section 7).

[x] UDT
[x] Tuple

[x] The serialization format for collection has changed (both the collection size and the length of each argument is now 4 bytes long). See Section 6.
[x] The format of "Schema_change" results (Section <IP_ADDRESS>) and "SCHEMA_CHANGE" events (Section 4.2.6) has been modified, and now includes changes related to user types.

[ ] QUERY, EXECUTE and BATCH messages can now optionally provide the default timestamp for the query. As this feature is optionally enabled by clients, implementing it is at the discretion of the client.
[ ] QUERY, EXECUTE and BATCH messages can now optionally provide the names for the values of the query. As this feature is optionally enabled by clients, implementing it is at the discretion of the client.

That's awesome. Feel free to send a pull request now. We can work on the optional arguments in a different issue.

I'm just realizing we don't support skip_metadata and serial_consitency flags. The specs don't say they are optional so I was implementing them.
In regards of the v3: I wanted to support both v2 and v3 (and we still can) but I was struggling with the current structure and I wasn't sure how. I just came up with an idea: we could either have a Protocol class as an attribute of a session, and a subclass for v2 and v3 implementations.
In any case I think a refactor of the structure should be done to have a cleaner code base. I would like to have such a structure (I'm just making this up, haven't given it much thought yet):
cassandra
├── cassandra.lua
├── utils.lua -- we kinda need this for methods such as `shuffle`, `split` etc...
├── constants.lua -- those could have more than just the values. For ex it could specify how the `paging_size` flag should be encoded (as an `[int]`)
├── marshallers -- only deal with converting lua types to cql types
│   ├── marshall.lua
│   └── unmarshall.lua
└── protocol -- those could be classes for v2, v3...
    ├── reader.lua
    └── writer.lua

I am not sure if supporting the v2 is valuable though. iirc, Cassandra 1.x needs the binary v1, and 2.x (or is it 2.1?) can have v2 or v3 (really not sure about that, need to check). If this is true, we could just drop v2 all along.

Types could also be classes. That way it gets easy and elegant to serialize/deserialize them, do bit operations on them etc. A simple example:
local flags_repr = 0
flags_repr = setbit(flags_repr, constants.query_flags.VALUES)

becomes
local flags = Byte.new() -- a [byte]
flags:setbit(constants.query_flags.VALUES)


Add CI job for ShellCheck

Execution for:

https://github.com/osbuild/cloud-cleaner/actions/runs/6095071620/job/16537900229 - Image Builder
https://github.com/osbuild/cloud-cleaner/actions/runs/6095076223/job/16537911866 - CloudX


Is there instructions on how to install this?

I'm trying to run luarocks make on the plugins folder and I'm getting
Error: Argument missing: please specify a rockspec to use on current directory.
Is there a rockspec for this?

Hi,
I don't use rockspec for the moment (but you can propose a PR )
I use KONG_LUA_PACKAGE_PATH and KONG_CUSTOM_PLUGINS
For example my DockerFile:
FROM kong:0.10.3

RUN mkdir -p /usr/local/custom/kong/plugins

ADD key-auth-referer /usr/local/custom/kong/plugins/key-auth-referer

ADD referer /usr/local/custom/kong/plugins/referer

ENV KONG_LUA_PACKAGE_PATH=$KONG_LUA_PACKAGE_PATH;/usr/local/custom/?.lua;;

ENV KONG_CUSTOM_PLUGINS=key-auth-referer,referer

COPY custom-docker-entrypoint.sh /custom-docker-entrypoint.sh

ENTRYPOINT ["/custom-docker-entrypoint.sh"]

EXPOSE 8000 8443 8001 3946
CMD ["kong", "start", "--vv"]

Weird.  I tried using the environment variables and I'm still getting:
I'm running 0.12.1 by the way...
Error:
/usr/local/share/lua/5.1/kong/cmd/start.lua:62: /usr/local/share/lua/5.1/kong/cmd/start.lua:51: nginx: [error] init_by_lua error: /usr/local/share/lua/5.1/kong/init.lua:165: referer plugin is enabled but not installed;
module 'kong.plugins.referer.handler' not found:No LuaRocks module found for kong.plugins.referer.handler

I got it working.  I did my own rockspec and finally figured it out.  Thanks for responding though...


Check if document has been modified

In GitLab by @sumorok on May 29, 2019, 11:52
During analysis, check of the document has been updated before applying any updates.

In GitLab by @nwalczak on May 30, 2019, 08:23
I had a thought this morning about looking at the document's revision history.  I haven't dug into this deeply, but I found some example code: https://sites.google.com/site/appsscripttutorial/urlfetch-and-oauth/get-the-revision-history-of-a-resource-using-docslist-api

In GitLab by @jakebeal on Jun 17, 2019, 10:24
assigned to @nwalczak

In GitLab by @nwalczak on Jul 1, 2019, 08:53
I'm combining this issue with #51 in #65.

In GitLab by @nwalczak on Jul 1, 2019, 08:53
closed


API文档访问不了

[ ] I have searched the issues of this repository and believe that this is not a duplicate.

Reproduction link
https://f2.antv.vision/
Steps to reproduce
https://f2.antv.vision/

Environment
Info

f2
5.0.16

System
v1

Browser
所有

官方 https://f2.antv.vision/  访问不了

最新的官网地址是  https://f2.antv.antgroup.com/


[GHSA-5v34-g2px-j4fw] Improper Handling of Length Parameter Inconsistency in Apache Ant

Updates

Affected products

Comments
It looks ant was moved from ant repo and the vulnerability also impacts ant:ant 1.7.0 and bellow.

Any chance you've got a reference on why this affects ant 1.7.0 and below? 👀

ant:ant bellow 1.7.0  is tagged as vulnerable on Sonatype. The same CVE number. As the library was changed the group only I think this information is reliable.

Do you have a link? Or more ideally are there any references from the ant project itself?

You need to have an account to see it (free of charge):
https://ossindex.sonatype.org/component/pkg:maven/ant/ant

Do you know what license sonatype publishes their advisory data under? Again a reference to the ant project itself is preferred.

There is description on Apache security: https://ant.apache.org/security.html
So you can forget Sonatype that is by the way both free and commercial and license is not clear for me.
Apache security claims:
Fixed in Apache Ant 1.9.16 / Ant 1.10.11
Low: Denial of Service CVE-2021-36373 and CVE-2021-36374.
When reading a specially crafted archive an Apache Ant build can be made to allocate large amounts of memory that finally leads to an out of memory error, even for small inputs. This can be used to disrupt builds using Apache Ant.
It affects reading (or updating) tar archives as well as archives using the zip format or formats derived from it. Commonly used derived formats from ZIP archives are for instance JAR files and many office files.
This was fixed in revision 6594a2d.
These issues are similar to CVE-2021-35517 and CVE-2021-36090 present in Apache Commons Compress which have been detected by OSS Fuzz.
Affects: up to 1.9.15 / 1.10.10. Versions prior to 1.4 are not affected, versions prior to 1.9.0 are not affected when reading tar archives.
AB


Update Master with Live

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

biztalk/core/feature-pack-add-application-project.md
:white_check_mark:Succeeded
View

biztalk/core/high-availability-using-sql-server-always-on-availability-groups.md
:white_check_mark:Succeeded
View

biztalk/install-and-config-guides/configure-biztalk-server.md
:white_check_mark:Succeeded
View

biztalk/install-and-config-guides/hardware-and-software-requirements-for-biztalk-server-2016.md
:white_check_mark:Succeeded
View

biztalk/install-and-config-guides/set-up-and-install-prerequisites-for-biztalk-server-2016.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Security vulnerability in peer dependency request

Would you accept a PR that upgraded the request peer dependency to ^2.68 in order to fix this security vulnerability:  https://nvd.nist.gov/vuln/detail/CVE-2017-16026

I think we need to make a balance here. Increasing the version could mean a breaking change for some projects. And on the other side it is the job of the project anyway to install request. After all it’s defined as a peer dependency. What’s your perspective?

Hey @analog-nico, totally see your point - though I think it might be riskier to leave it as it can easily lead people to install the vulnerable version, and then only upgrade afterward if something like GitHub or npm notify them.
If we're worried about breaking changes, what do you think about bumping the min version to ^2.68 and releasing it as a major release?

I have a change in the pipeline that will be a breaking change as well. So let me include it with it then. May take a while though.

Ok, sounds good - thanks! Any place that we can track that?

Has anything moved with this issue? This is the last peer dependency we need to update to get rid of all security vulnerabilities.


Added pudb3 + wrapper to debug pyOCD in Unix shell.

Signed-off-by: Tomasz 'CeDeROM' CEDRO<EMAIL_ADDRESS>

Whoops. Internals of pyOCD changed a lot recently. I have updated the script. With this kind of reorganization why not a major number bump (i.e. 1.0 instead 0.30)? :-)

(Sorry it's taken me a while to get to your PRs.)
Imo this seems to be more of a personal utility than something most pyocd users would benefit from. It's really just prefixing pudb3 on the pyocd command-line, and the name of this script itself is almost the same amount of typing. Also, the choice of which Python command-line debugger to use is quite personal.
Probably a better option would be to extend the developer docs with a "Debugging pyOCD" section that describes this. (And how to debug in VSCode, which more people use, including me. I've been planning to document this for some time…)

Allrgith, this will land into the documentation then :-)