Broken separation of concerns

The way projects in this repository are coupled now, Microsoft.AspNetCore.Identity.EntityFrameworkCore package has dependency on Microsoft.AspNetCore.Identity package.
IdentityDbContext class is defined in Microsoft.AspNetCore.Identity.EntityFrameworkCore package.
If I want to create my own clean DAL project and only have ApplicationDbContext class + POCO entities there, and I decide that my ApplicationDbContext class will inherit from IdentityDbContext in order to be able to plug in to middleware later on - logically, I have to add reference to Microsoft.AspNetCore.Identity.EntityFrameworkCore package to DAL project, which results in Microsoft.AspNetCore.Identity being pulled in to DAL project as well, which gives me dependency on other packages that are related to cookies, HTTP, ...
What kind of architecture and dependency chain is this? I have web-related stuff in my DAL project which makes absolutely no sense.
I understand that I can copy+paste stuff from projects in this repository and arrange it the way I like it since it is all open source now, but is that really way to go?
Can you please shed some light on why is all this built this way? I could be just blind to something obvious.
Thank you!

Perhaps you should keep your business related entities separate from the identity management related entities.

@brockallen Well, even though that makes some sense when observed from DDD perspective, it still does not explain this dependency chain.
As a matter of fact, I've taken a close look into your MembershipReboot projects structure, and that's a great example of clear separation of concerns. I don't see your MembershipReboot.Ef project referencing any of the web assemblies, which is what I was expecting to see here as well.
Thanks for the suggestion though, appreciated. :)

Ok, I see your point about the web dependencies. I agree with that sentiment.

Not sure it is feasible at this point, but one way we could achieve that is by moving all interfaces and abstractions to a separate abstractions package, then have store packages depend on that. Not sure what the goal is though: if you want a DAL depend on IdentityDbContext you kind of carry a lot of baggage with that anyway.

E.g. ASP.NET Core Identity is Web specific.

E.g. ASP.NET Core Identity is Web specific.

This is a superficial design limitation that you've boxed yourselves into. It was brought up as a complaint early during this v3 rewrite. The prior versions of ASP.NET Identity were not web-specific, and to be blunt all ASP.NET Identity is is logic around DB queries, password validation, and brute force protection. The cookie authentication middleware is not part of ASP.NET identity, and its disingenuous and confusing to tell people that that it is.

We discussed this when we were deciding whether Identity should go in the AspNet namespace, and the outcome was that we intentionally decided against specifically supporting non web scenarios.

Hao, can you go into the rationale for it? It would be nice to see this explained and documented (and thus you can just point people to it). After all, this is all out in the open, right? cringe

@divega Well yes, ideal solution would be to move out required abstractions to new package, and then to have Microsoft.AspNetCore.Identity and Microsoft.AspNetCore.Identity.EntityFrameworkCore both depend on that package. That would allow to remove dependency from Microsoft.AspNetCore.Identity.EntityFrameworkCore on Microsoft.AspNetCore.Identity and therefore remove need to include dependencies on web related packages in tiers that are responsible for data access.
When it comes to patterns, it's never about them being a must, but about them being a good practice. If I was about to write my own store implementation, I would have to include Microsoft.AspNetCore.Identity in my project and pull web-related packages. I really don't think that's a good example on how to do stuff.
Thank you for considering this at least, and thanks @brockallen for giving your voice on this as well.
Keep up the good work! :)

I also think that depending on web assemblies/cookies is a huge disadvantage of this library. This could have been avoided easily and would have made this project massively more useful.

You could also consider decoupling DbContext from default identity domain model classes defined in Microsoft.AspNetCore.Identity.EntityFrameworkCore that are used and exposed by implementations of UserStore and RoleStore classes #920.

This is specially painful if you want to be able to replace Microsoft.AspNetCore.Identity.EntityFrameworkCore for some other implementation. You simply can't do it.
The UserManager<IdentityUser> class is directly dependent of IdentityUser. I can't use UserManager<OtherUser> because that will not work with the current implementation, as it is tied to the IdentityUser. IdentityUser cannot be swapped out.
Ideally, I should be able to simple swap the Entity Framework implementation, at runtime, for some other one. That just can't be done. At the current moment, the only solution is to fork Microsoft.AspNetCore.Identity.EntityFrameworkCore, which is what I am going to do now.
But that is also a pain, as I will have to keep my library in sync with your, which I shouldn't need to do.
At least this library is small. But still.

Agreed this lack of separation of concerns and tight coupling to IdentityUser is causing real problems when trying to work with this library. Should strongly consider addressing in a future release. To easily detect these problems, write samples that use more than one persistence technology. Write a sample that, using DI, can swap between using EF Core and Dapper for the implementation of its Identity classes. When you can write that sample without a great deal of pain, you're on the right track.

IdentityUser lives in EntityFrameworkCore, you don't have to derive from IdentityUser, you can implement your own TUser so I'm not sure I understand the issue, IdentityCore isn't tied to the EF implementation at all.

Plugging in your own non EF identity store should look basically like this:
    services.AddIdentity<YourUser, YourRole>().AddUserStore<YourUserStore>.AddRoleStore<YourRoleStore>();

No EF involved.

I want to optionally use EF for my persistence of my identity type. Here's a good example of what I'm looking to achieve: http://timschreiber.com/2015/01/14/persistence-ignorant-asp-net-identity-with-patterns-part-1/
I want to use POCOs for my identity types (user, role) and decouple their use from the decision of how I want to persist them (that decision likely will be made in another project from my web project). Does that make sense?

Part of the pain here is that the default templates make heavy use of IdentityUser in the AccountController and ManageController types. If these used a simple POCO class and some interfaces for working with such a class, it would make it much easier to extract things from the web project.

Fair enough, I believe the reason the IdentityUser/associated pocos don't live in core was due to a few navigation properties they have.  @divega might recall more details about that debate as well.
Would things be better for your optional EF scenario if the simple IdentityUser POCO lived in core for everyone to use if they desire?
cc @ajcvickers @blowdart if we want to move our pocos around, this might be a good thing to do in 2.0...

You'd have to put base classes in the core repo and then derived classes in the EF repo, I'd think. The derived classes would add the EF specific goo.

Yeah now I remember what the point of contention was, the placeholder navigation properties that exist for EF only.  That's really the only thing that would get removed for the entities to live on core...
Clearing for triage
Main issue:
https://github.com/aspnet/Identity/issues/332
Related issues:
https://github.com/aspnet/Identity/issues/547
https://github.com/aspnet/Identity/issues/489

If we're splitting stuff, we ought to split out the MVC specific bits, so folks can use identity from other types of apps, as we've had requests for.

Any chance just an interface would work for the identityuser? Let me mark my own user class as implementing IIDentityUser (or similar) which defines the necessary properties for AspNetCore.Identity to get the values it requires? Then I wouldn't need to inherit from or directly use a framework type.

@HaoK another point of contention is that the design of Identity intentionally does not prescribe how the types look like. E.g. the store interfaces are there to completely isolate the implementation of the managers from how the classes look like. They can be anything that the stores and the application understand. If you include these "POCOs" in the core package, it might mean one of two things:

All providers should use them as the base for their implementation: this pushes a new burden on providers, which now need to support this kind of "POCOs" (which are very EF-idiomatic, not just because of the navigation properties)

They are there just as a hint that a provider can use them: this can be potentially confusing and personally I don't think it provide a lot of value

Based on this and what @ardalis says his requirement is in https://github.com/aspnet/Identity/issues/883#issuecomment-295442262, I think a more useful way to think about this is that we only ship the POCOs in the turn-key EF Core implementation of the stores for convenience, but that if an application wants complete freedom and control on the types and that store it uses it can do so by providing its own implementation of the store interfaces.
Now, let's assume that:

You want to make it easier, i.e. you want to make it possible for an application to do what @ardalis wants without having to write that much code.
The EF-friendly "POCOs" that we define are really viable base types for a significant subset of all the providers

Then the way I would go about it is to move the "POCOs" into a base Identity store provider package that not only brings the POCOs but also a partial implementation of the store interfaces, in particular an implementation of all the repetitive property access code that is bound to the POCOs. Then it should be very easy to refactor the current EFCore provider to depend on this base provider.

Also, while we are at it, it would be nice if we could address what this issue was originally about: move the definitions of the Identity interfaces into a Abstractions package so that customers can write a DAL and providers can write a provider without bringing the whole graph of dependencies of ASP.NET.

Sure we've been overdue for cleaning up things in Identity...
So something like:
Microsoft.Extensions.Identity.Abstractions (UserManager/SignInManager/interfaces
Microsoft.Extensions.Identity.Providers.Core (IdentityUser/basic stores)
Microsoft.AspNetCore.Identity (SignInManager that works with AspNet)
Microsoft.AspNetCore.Identity.EntityFrameworkCore (EFStore)

I believe @ajcvickers was also compiling a list of the different improvements that have come up in this issue. I think template code that is not tied to the "POCOs" is part of it.
FWIW, I would probably pick a name do the base "POCO"-based stores pacakage that conveys the fact that it is an opinionated implementation.

e6f3ebf5810c793edc6f3b4ca3438194786b86a2

Good job, everyone, as soon as preview 2 is out I will try this out. Thanks!

Hello all! I was happy to see that IdentityUser had been moved out of EntityFramework and into Microsoft.AspNetCore.Identity in version 2.0.0 Preview2-Final. That was very helpful.
But I just upgraded from the preview version to the final release of ASPNETCore 2.1 and it's not there anymore. Where does IdentityUser live now please?
In my AuthorizationController.cs class I'm now getting the compilation error below:
Error	CS7069	Reference to type 'IdentityUser<,,,,>' claims it is defined in 'Microsoft.Extensions.Identity.Stores', but it could not be found	....\Controllers\AuthorizationController.cs

The solution to my problem above is:

Updating all the references to Nuget packages in each of my projects to the latest versions
Replace references to IdentityUser<TKey, TLogin, TRole, TClaim> (now obsolete, it seems) with references to the simpler IdentityUser<TKey> class.


redirect_stdout and redirect_stderr behaviour

Description
The redirect options don't properly restore stdout and stderr after ending. Instead of redirecting and restoring the current sys.stdout/sys.stderr, it redirects and restores whatever was the sys.stdout/sys.stderr at the time progressbar was imported.
Code
test.py:
import sys
import progressbar as pb

print(sys.stderr)
sys.stderr = open('somefile', 'w')
print(sys.stderr)
for i in pb.progressbar([1], redirect_stderr=True):
    print(sys.stderr)
    print("In wrapped stderr", file=sys.stderr)
print(sys.stderr)

I expect the following to be printed:
<_io.TextIOWrapper name='<stderr>' mode='w' encoding='UTF-8'>
<_io.TextIOWrapper name='somefile' mode='w' encoding='UTF-8'>
N/A% (0 of 1) |                                                                                | Elapsed Time: 0:00:00 ETA:  --:--:--
<progressbar.utils.WrappingIO object at 0x7f7eac4e0128>
100% (1 of 1) |########################################################################################################################| Elapsed Time: 0:00:00 Time:  0:00:00
<_io.TextIOWrapper name='somefile' mode='w' encoding='UTF-8'>

And somefile should contain In wrapped stderr.
Instead, somefile is empty and I get the following output:
<_io.TextIOWrapper name='<stderr>' mode='w' encoding='UTF-8'>
<_io.TextIOWrapper name='somefile' mode='w' encoding='UTF-8'>
N/A% (0 of 1) |                                                                                | Elapsed Time: 0:00:00 ETA:  --:--:--
<progressbar.utils.WrappingIO object at 0x7f725dc170b8>
In wrapped stderr
100% (1 of 1) |########################################################################################################################| Elapsed Time: 0:00:00 Time:  0:00:00
<_io.TextIOWrapper name='<stderr>' mode='w' encoding='UTF-8'>

As you can see, the In wrapped stderr was printed to the original sys.stderr, also, the sys.stderr was restored to the value it had, when progressbar was imported, and not somefile.
Versions

Python version: 3.7.1 (default, Oct 22 2018, 10:41:28) [GCC 8.2.1 20180831]
Python distribution/environment: Any
Operating System: Any? Ubuntu Linux for sure
Package version: 3.38.0

Proposed fix
Instead of using a singleton utils.streams, maybe create a new StreamWrapper every time a progressbar is created?

The way you want/expect it to work was actually the original behaviour some time ago. The reason it was changed is because it breaks the logging module otherwise: https://github.com/WoLpH/python-progressbar/issues/101
The thing is, similar to how this library keeps a local copy of stderr now, the logging module does that as well so I'm not sure what would be the best fix here. I understand your scenario but I believe the logging scenario is even more common. A workaround for the issue can be made like this:
from progressbar import utils

utils.streams.original_stdout = ...
utils.streams.original_stderr = ...


Modifiable Entries

Hi, this pr removes the data from wofi-emoji and instead stores it on  ~/.config/wofi-emoji.rc.

I'm not sure calling the database wofi-emoji.rc and putting it in ~/.config/ is very accurate 😅
I like the idea of externalising it from the wofi-emoji file though; how about putting it in ${XDG_CACHE_HOME:-~/.cache}/wofi-emoji.db instead?
Also, we could the curl | jq > $CACHED_DB line from build.sh into wofi-emoji (with a if [ ! -f "$CACHED_DB" ] check), so that removing the cache automatically gets wofi-emoji to re-download the file?

See https://github.com/Zeioth/wofi-emoji/pull/19 for the alternative I'm proposing

Another argument in favour of having the external file managed by wofi-emoji instead of build.sh is that this removes the need to install build.sh in the wofi-emoji package as compared with this PR which does need that, and it makes it easier for the user to not have to know to run two different commands to populate the db and to use it.


How to stop scanning after code retrieved ?

Because of scanning not stop phone is getting heated

see issue #23 .


Fix several typos and spellings

I love the way these pages look, by the way.

Thanks for the fixes!


refactor: replace ColumnOption::DialectSpecific with ColumnOption::Comment

Which issue does this PR close?
Closes #158
Rationale for this change
simplify code when parse "comment"

What changes are included in this PR?
replace ColumnOption::DialectSpecific with ColumnOption::Comment when parse "comment"

Are there any user-facing changes?
None

How does this change test

tested by the compiler
existing UT

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@baojinri Would you add a test in the tests for creating table with comment?


page.evaluate error in the after hook fails an otherwise passing test

Issue
I have some tests that pass but playwright reports them as a failure due to an error in the afterhook. It's coming from here. The trace report shows no network activity at this time.
Error: page.evaluate: Execution context was destroyed, most likely because of a navigation
at Object.context (...removed.../node_modules/playwright-test-coverage/index.js:34:18)

Note

The failure is only observed in chromium whenever it is run with a full suite (a file with multiple tests) of tests.

The failure does not appear in Firefox
Tests in my repo are configured to run against Chromium by default

When run individually on chromium the error is not present.
This error is observed when running tests in a way that is not generating code coverage files

I have not been able to check if this happens when code coverage is gathered

I see no missing awaits in the test
Other tests in the file pass without this error in the after hook

Attempted Action
I found this issue about page.evaluate in playwright's repo. The issue didn't seem similar but I tried some of the suggestions anyway. I tried adding bypassCSP: true to the playwright config. It didn't help.
Versions
playwright-test-coverage 1.2.12
playwright 1.39.0
Chromium 119.0.6045.9

Having worked on the tests longer I think I see the root of the issue. While everything was properly awaited the final action before the expect was clicking a submit button which triggered a navigation. The click was not properly followed up with a waitForUrl() which playwright defines as best practice for clicks that trigger navigation. I suspect that ending the test there left the browser in a state where the navigation was still resolving as the after hook was happening.
Hopefully this helps someone else experiencing the same issue. I searched the internet but found nothing which covered issues where a navigation interrupts a test after hook.


Camera permissions issue with Firefix

Created via Reamaze:
Link: /admin/conversations/youre-invited-to-our-biggest-secret-yet-dot-dot-dot-0425278da2becca5
Assignee: Oleksii serdiukov
We fixed the issue with requesting PermissionsAPI, but we have an other issue with getUserMedia - it also fails in Firefox (but should work as WebRTC is supported by FF)

[x] re-check permission API issue in Firefox. make sure we're catching all possible exceptions
[x] check getUserMedia, adjust its arguments to be working in FF

hotfixed directly to the master branch:  https://github.com/GoodDollar/GoodDAPP/commit/6530e05032f9e7f2d767152aefabd67e03bb8f7f

@serdiukov-o-nordwhale @sirpy user is able to switch on the camera permission and scan face or QR code
Checked on DEV V1.0.6-0
LG V30+ // Android 8.0 // firefox
Desktop: Windows 10 // firefox


[Feature Request]: Use multi stage dockerfile to build image.

Is there an existing issue for the same feature request?

[X] I have checked the existing issues.

Is your feature request related to a problem?
no

Describe the feature you'd like
Use separated stage to install node_modules and build front end and copy the artifacts to final stage. This is can reduce size of the final image.
Describe implementation you've considered
No response
Documentation, adoption, use case
No response
Additional information
No response

Released in v0.12.0


refs: Remove hardcoded timeout from workspace/refs

This is a relic from before we had streaming support. We still don't support
passing on $/cancelRequest. However, that should be fine since it seems to be
fine for references.

I think it would be better to keep a finite timeout but just increase it to something larger like 1 minute.


Global theme is not applied to components imported from library

Material-UI  v4.9.8
React      : 16.13
TypeScript   8.3
Hi everyone,
I'm facing an issue, and I searched in Google to find answer with no chance.
I have created a React / material Ui library, with a lot of components extended from Material UI.
this library belongs to a workspace monorepo, together with a main app.
The library is build with webpack and babel.
In the main app, I'm importing these components and try to apply the global theme, created in the main app, using ThemeProvider.
It's seems to work as first sight. When  the lib component is alone in the page, the theme is applied to it.
But as long as I add another react component, which is created in the main app and not download from the library, the lib components lost the theming.
Have also copied the code of one of the lib component inside the main App (Button in the following example). In this case, using the local Button and not the imported on from the library is working well. The theme is applied.
So I miss something here. Why the theme is "erased" from components imported from my react/material ui library?It seems a default theme is erasing my global team.
(see pictures below)
Button component in the library (simplified version)
const Button: React.FC<IButtonProps> = (props: IButtonProps): JSX.Element => {
		return (
			<MUIButton
				{...props}
				type={props.type ? props.type : EButtonTypes.BUTTON}
			>
				{props.children}
			</MUIButton>
		);
};

local component created in main app (with no styling at all)
const AppBar: React.FC<IAppBarProps> = (): JSX.Element => {
	return (

			<MUIAppBar position="static">
				<Toolbar>
					<IconButton edge="start" aria-label="open drawer">
						<MenuIcon />
					</IconButton>

							<SearchIcon />

						<InputBase
							placeholder="Search…"
							inputProps={{ "aria-label": "search" }}
						/>

				</Toolbar>
			</MUIAppBar>

	);
};

Main app
const MUITheme: Theme = createMuiTheme({
	overrides: {
		MuiButton: {
			root: {
				font: "initial",
				fontFamily: globalThemeSettings.typography.fontFamily,
				fontWeight: globalThemeSettings.typography.fontWeight,
				padding: `${2 * globalThemeSettings.spacingInit}px ${
					2 * globalThemeSettings.spacingInit
				}px`,
				backgroundColor: globalThemeSettings.buttons.backgroundColor,
				color: globalThemeSettings.colors.textColors.button.main,
				textTransform: "uppercase",
				"&:hover": {
					backgroundColor:
						globalThemeSettings.buttons.hover.backgroundColor,
					transform: `scale(${globalThemeSettings.buttons.hover.transformScale})`,
					transition: globalThemeSettings.buttons.hover.transition,
				},
			},
			outlined: {
				font: "initial",
				fontFamily: globalThemeSettings.typography.fontFamily,
				fontWeight: globalThemeSettings.typography.fontWeight,
				padding: `${globalThemeSettings.spacingInit}px ${
					2 * globalThemeSettings.spacingInit
				}px`,
				borderColor: globalThemeSettings.buttons.backgroundColor,
				borderWidth: 3,
				color: globalThemeSettings.buttons.backgroundColor,
				backgroundColor:
					globalThemeSettings.colors.textColors.button.main,
			},
			text: {
				font: "initial",
				fontFamily: globalThemeSettings.typography.fontFamily,
				fontWeight: globalThemeSettings.typography.fontWeight,
				padding: `${globalThemeSettings.spacingInit}px ${
					2 * globalThemeSettings.spacingInit
				}px`,
			},
		},
``	},)

Render with no AppBar

Render with AppBar. The button lost the theme

seeing the same issue, were you able to figure this out in the end @jeromeSH26

@chapati23 Usually, it means that the singleton theme's context is duplicated in the bundle.

Yeah, looks like it’s yet another yarn Link problem.
After symlinking material-ui (on top of react and react-dom), it worked.
what’s the “official” recommendation for locally developing an app + separate MUI-based component library? yarn link is the only way I know but feels hacky

@chapati23 we don't provide specific recommendations for working with a library that extends Material-UI. Instead, we aim to not be a bottleneck in such configuration.

Remove material-ui from dependencies in the package.json of the component library, if you're using rollup add material ui libraries in external property. Compile again, link your library to the project you want to test and done. Bad thing, if you're using storybook you will need material-ui libraries in the library.

@oliviertassinari Any development going on above? as there are a lot of projects using material ui in their component library There needs to be a solution to this. Having material UI in component library is necessary to have storybook working as well!

@chapati23 any chance you still know how you got it to work with symlink? even doing that isn't working for me

sry, too far in the past for my brain to still remember 😞

same issue


FreeBSD: graphics/darktable: release 2.6.2_3 fails to build under ports-mgmt/synth

I have run into a dependency issue on FreeBSD for ports which use OpenMP from the base system, in particular darktable. The FreeBSD bug report is here: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=240488
Build log for "synth test graphics/darktable" is attached to the FreeBSD bug report.
Original forum thread is here: https://forums.freebsd.org/threads/synth-cannot-install-or-upgrade-darktable.72250/
Right now I have to manually edit the Makefile and remove the libomp section to get darktable to install.

It's actually a port issue, rather than a synth issue. The port Makefile has to corrected individually. One example of a fix is in games/tesseract:
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=242292

Thanks for the comment! There is a suggested patch for the darktable package which moves the dependency to ports like in the tessaract example. This is the solution for now.
However, if the base system supplies the library, then probably it should be picked up. I don't know of a good solution to the problem at the moment.

FreeBSD has removed openmp from ports, and hence this issue is now fixed. Closing.


[HUDI-820] cleaner repair command should only inspect clean metadata files

@lamber-ken : This is something I missed when reviewing cleaner repair code changes. The repair command has a serious bug in that it might delete inflight instants of other actions.
cc @vinothchandar

Randomly saw this in test logs..
298541 [main] WARN  org.apache.hudi.common.HoodieClientTestHarness  - Closing file-system instance used in previous test-run
298630 [main] WARN  org.apache.hudi.table.action.clean.CleanActionExecutor  - Failed to perform previous clean operation, instant: [==>000000023__clean__INFLIGHT]
org.apache.hudi.exception.HoodieIOException: Not an Avro data file
	at org.apache.hudi.table.action.clean.CleanActionExecutor.runPendingClean(CleanActionExecutor.java:212)
	at org.apache.hudi.table.action.clean.CleanActionExecutor.lambda$execute$5(CleanActionExecutor.java:261)
	at java.util.ArrayList.forEach(ArrayList.java:1257)
	at org.apache.hudi.table.action.clean.CleanActionExecutor.execute(CleanActionExecutor.java:258)
	at org.apache.hudi.table.HoodieCopyOnWriteTable.clean(HoodieCopyOnWriteTable.java:197)
	at org.apache.hudi.client.HoodieWriteClient.clean(HoodieWriteClient.java:630)
	at org.apache.hudi.table.TestCleaner.runCleaner(TestCleaner.java:425)
	at org.apache.hudi.table.TestCleaner.runCleaner(TestCleaner.java:414)
	at org.apache.hudi.table.TestCleaner.testCleanPreviousCorruptedCleanFiles(TestCleaner.java:1000)

(May be totally a false alarm, but just saying we should understand if all these are expected)..

Randomly saw this in test logs..
298541 [main] WARN  org.apache.hudi.common.HoodieClientTestHarness  - Closing file-system instance used in previous test-run
298630 [main] WARN  org.apache.hudi.table.action.clean.CleanActionExecutor  - Failed to perform previous clean operation, instant: [==>000000023__clean__INFLIGHT]
org.apache.hudi.exception.HoodieIOException: Not an Avro data file
	at org.apache.hudi.table.action.clean.CleanActionExecutor.runPendingClean(CleanActionExecutor.java:212)
	at org.apache.hudi.table.action.clean.CleanActionExecutor.lambda$execute$5(CleanActionExecutor.java:261)
	at java.util.ArrayList.forEach(ArrayList.java:1257)
	at org.apache.hudi.table.action.clean.CleanActionExecutor.execute(CleanActionExecutor.java:258)
	at org.apache.hudi.table.HoodieCopyOnWriteTable.clean(HoodieCopyOnWriteTable.java:197)
	at org.apache.hudi.client.HoodieWriteClient.clean(HoodieWriteClient.java:630)
	at org.apache.hudi.table.TestCleaner.runCleaner(TestCleaner.java:425)
	at org.apache.hudi.table.TestCleaner.runCleaner(TestCleaner.java:414)
	at org.apache.hudi.table.TestCleaner.testCleanPreviousCorruptedCleanFiles(TestCleaner.java:1000)

(May be totally a false alarm, but just saying we should understand if all these are expected)..

These are expected, in TestCleaner#testCleanPreviousCorruptedCleanFiles test case, create a corrupted clean files first, then run cleaner.

Codecov Report

Merging #1542 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #1542      +/-   ##
============================================
- Coverage     71.78%   71.77%   -0.02%
  Complexity     1087     1087
============================================
  Files           385      385
  Lines         16575    16575
  Branches       1668     1668
============================================
- Hits          11899    11897       -2
- Misses         3947     3949       +2
  Partials        729      729

Impacted Files
Coverage Δ
Complexity Δ

...ache/hudi/common/fs/inline/InMemoryFileSystem.java
79.31% <0.00%> (-10.35%)
0.00% <0.00%> (ø%)

...e/hudi/common/table/log/HoodieLogFormatWriter.java
76.92% <0.00%> (+0.96%)
0.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa6aba7...2c72c50. Read the comment docs.

hi @bvaradar, the unit test TestCleaner#testCleanPreviousCorruptedCleanFiles has covered. IMO, TestRepairsCommand.java is redundant, WDYT?

@lamber-ken : Both tests different aspects of the change. TestCleaner tests the skipping of corrupted files whereas TestRepairsCommand checks if the underlying corrupted file is deleted.


Magical link

Subject: Magical link
Description:
I tried to login
Results:
I don’t recall my password and the magical link never made it into my mailbox. Please help me to login again: redacted email
Backend version: develop-7c33e18d
Frontend version:
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_6) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/14.1.2 Safari/605.1.15
Page: https://couchers.org/
User:

dupe #3520


Consider supporting migration logic for the ignore/checkpoint-files

Similar to, winget.packages.json consider supporting migration logic for winget.{HOSTNAME}.ignore and winget.{HOSTNAME}.checkpoint.

Added migration logic for ignore file.
Still need to consider whether checkpoints should be migrated or have some other configuration option to determine where to write. It may even make sense to reconsider how other resource files are managed (i.e. have a default JSON file that indicates where to read/write from/to which can be updated by the user).


add overflow-checking for negative arithmetic kernel

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

follow up of the https://github.com/apache/arrow-rs/issues/2642
cc @viirya
Describe the solution you'd like

Describe alternatives you've considered

Additional context

I believe this has now been implemented?

label_issue.py automatically added labels {'arrow'} from #2893


System requirments to download the agent?

Any CPU, memory requirements other than cache folder?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 02ad5c91-acc2-a50b-0b4a-8298c608df41
Version Independent ID: 2e80d5ac-1918-61f8-87d4-8133a0250b1b
Content: Azure Backup agent FAQ
Content Source: articles/backup/backup-azure-file-folder-backup-faq.md
Service: backup
GitHub Login: @trinadhk
Microsoft Alias: trinadhk

Hi @v-maroge
Thank you for your feedback! We will review and get back to you with our findings.

Hi, sorry to ping. Any information on this?

@v-maroge, sorry for the delay. Adding @GeethalakshmiG for her input.

@v-maroge, Confirmed with our Product Group, there is no specific requirement for CPU and Memory. We are working on developing a content on this topic but, I don't have an ETA to share publicly.


Implement more complete JSON serialization for sympy

Follow up to https://github.com/quantumlib/Cirq/pull/1880#pullrequestreview-278642567
It would be ideal if sympy itself had a serialization format. However, the most promising candidate srepr looks to be horribly unsafe to parse on untrusted input.
https://github.com/quantumlib/Cirq/pull/1880 adds support for sympy.Symbol, but we'll probably need support for more constructs; at least arithmetic

More support has been added for simple math.  Do we have more we'd like to add?  I'd recommend we close until we see if there is more complicated math that starts showing up that we need to serialize.

Sounds good to me!


Remove use of IConfiguration

This means all configuration is now code-based only.
See Issue #1800

:shipit:


Doesn't work on Ubuntu 22.04

Seems like it's not installing with the error only on my side. But I want to be sure that it's on;y on my side. Is it requires KVM? Because on that last step of launching libertea panel, it's always failing.

not install in 22.04

not install in 22.04

It doesn't work on Debian 10-11 too. I thought maybe it's because VPS is on OpenVZ?

Please post the output of the following two commands so we can investigate.
tail -n 50 /tmp/libertea-panel.init.log

tail -n 100 /tmp/libertea-panel.log


Store PhantomData in stashes of manual ToGlibPtr impls if only a lifetime is needed

https://github.com/gtk-rs/gtk-rs-core/commit/d373a78b01957b0d3430f3eb8b19b8459b5029ef

Just did a check and we only use PhantomData when a lifetime is needed.

Ah did I update that already? Apparently: https://github.com/gtk-rs/gtk4-rs/commit/6863c9c3ec4eb8bb4eaee1e76abdfa33fb38f4a0


Python 3 comptibility going forwards

Hi @mds-dwa, thank you for looking over our PRs - we've been hoping to align our internal changes with the upstream repository.
Internally we keep everything Py2/3 compatible, which at the moment looks like v0.12.1 with a handful of code compatibility modifications alongside Qt v5.12.5. Looking at the python3 branch, I was wondering if there was an intention to retain that compatibility going forward? It would also definitely be great at some point to get the project onto Qt v5.15.x, in step with the VFX Reference Platform.
Thanks for looking after this project, it's an incredibly useful tool!

I am hoping to keep the python3 branch in sync, though it occasionally falls by the wayside. I'm sure at some point enough new features will only work with python3 or Qt5 that it becomes the main branch, but that's likely a long way out. At one point, I was thinking something like six could help keep all the code in a single branch for python 2 and 3, but since the .qrc file gets compiled with either pyrcc4 or pyrcc5 on our end based on python 2 vs. 3, I think it has to stay separate for most people, without some changes to the build/release process here.
Regarding Qt5, it should already be compatible, but there are some newer features in Qt5 we could start leveraging if we ditched Qt4 completely. Do let me know if I'm wrong about that!

It's compatible for Qt5 - just had to patch in the corresponding images_rc.py is all I was noting. In terms of Python 2/3 compat, we have it working, so I might PR the last of the modifications we made to get there at some point.


Codemirror data overload and lagging problem

I am using the Codemirror version number is 5.44, and the React version is 16.13.1. There are about 200 lines of related code statements in the content area. When the code is only dozens of lines, it is not stuck. When the code is 200 lines, the deletion, addition, and modification statements are too laggy. The cursor will not come out until a few seconds later. What is the reason for this? I hope to get an answer!

200 lines should be absolutely no problem, unless some of them are enormously long. There may be something else going on not related to the core library.

Thank you for your answer. I checked the code (written by someone else) and found that there is a chage event that executes every time, while the code in the change event is synchronous, blocking thread execution. Now, I have changed the change event to asynchronous and added 600ms of anti shake to solve this problem!

200 lines should be absolutely no problem, unless some of them are enormously long. There may be something else going on not related to the core library.

Thank you for your answer. I checked the code (written by someone else) and found that there is a chage event that executes every time, while the code in the change event is synchronous, blocking thread execution. Now, I have changed the change event to asynchronous and added 600ms of anti shake to solve this problem!

200 lines should be absolutely no problem, unless some of them are enormously long. There may be something else going on not related to the core library.

Thank you for your answer. I checked the code (written by someone else) and found that there is a chage event that executes every time, while the code in the change event is synchronous, blocking thread execution. Now, I have changed the change event to asynchronous and added 600ms of anti shake to solve this problem!


test(download-file.js): Add some unit tests

Bringing back old refactor from last week.
I already tested things with npm run demo and works ok. Maybe #19 was not specifically related to this refactor, but with the module itself.
@baldore  @andresdavid90 you should double check though.

Current coverage is 75.60% (diff: 100%)

Merging #32 into master will increase coverage by 9.78%

@@             master        #32   diff @@
==========================================
  Files             4          5     +1
  Lines            79         82     +3
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits             52         62    +10
+ Misses           27         20     -7
  Partials          0          0

Powered by Codecov. Last update 286938f...9d0d6c6

I'll be out until next week but I'll take a look after that.

Hey guys, I'm working in the mock server and I've noticed a some things that we should take a look.

We need to remove all the Sync functions. Those functions block the event loop.
Use generators in the project with co or async/await.
Configure Mocha to use generators, this will make the async testing easier.

I just checked and this seems to be working fine. Merging.


x/tools/cmd/gopls: "Request textDocument/definition failed" when working on a module whose upper directory contains no Go code

What version of Go are you using (go version)?

$ go version
go version go1.12 darwin/amd64

Does this issue reproduce with the latest release?
yes
What operating system and processor architecture are you using (go env)?
go env

$ go env
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/mellon/Library/Caches/go-build"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOPATH="/Users/mellon/go"
GOPROXY=""
GORACE=""
GOROOT="/usr/local/go"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/darwin_amd64"
GCCGO="gccgo"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/01/v02g0nk97_98qt_4_dsq07hw0000gn/T/go-build847911855=/tmp/go-build -gno-record-gcc-switches -fno-common

What did you do?

Open demo code: https://github.com/kidlj/pki-example in vscode with the latest 0.9.3-beta.7 vscode-go extension and gopls language server on.
There's is a module inside the repository, which is github.com/kidlj/pki-example/demo.
When open the module directory with vscode, which is demo, it works fine.
$ code ~/Code/pki-example/demo

Instead if I open the upper directory, which is pki-example, gopls fails everything.
$ code ~/Code/pki-example

In the second case, gopls logs:
[Error - 2:08:41 AM] Request textDocument/codeAction failed.
  Message: no file information for file:///Users/mellon/Code/pki-example/demo/main.go
  Code: 0

What did you expect to see?
gopls works with vscode.
What did you see instead?
vscode 'Go To Definition' fails.

This is working as intended, you need to add any module directories you are using by hand as workspace directories in your vscode project. Until you do, the module is not visible to gopls, even if the files are, and thus it cannot analyze any of the code.
This is not something that gopls can fix, but it is possible in the future that the vscode go extension could either add the directories for you.

@ianthehat do you mean adding directories using Go modules under the "folders" property in the JSON? Because I did this and it's still not working for me.
[Error - 3:16:57 PM] Request textDocument/hover failed.
  Message: no file information for file:///Users/dextermiguel/Documents/dev/ss/k2/cmd/lambda/survey-ingest-legacy/survey-ingest-legacy.go
  Code: 0

{
  "folders": [
    {
      "path": "."
    },
    {
      "path": "/Users/dextermiguel/Documents/dev/ss/k2/cmd/lambda/survey-ingest-legacy"
    }
  ],

yes, but note that once you add them you currently need to reload the window as we do not track the update messages


multiqc issues with bcbio WES pipeline

Dear bcbio team,
I am getting MultiQC related error when I run whole exome analysis using bcbio-nextgen variant calling pipeline. Some how MultiQC peddy module was broken. Peddy ran without errors with bcbio pipleline. Please find below the error log.
[2018-11-15T06:36Z]local: KeyError: 'ancestry-prediction'
[2018-11-15T06:36Z]local: ============================================================
[2018-11-15T06:36Z]local: [INFO   ]        bcftools : Found 1 stats reports
[2018-11-15T06:36Z]local: [INFO   ]          snpeff : Found 1 reports
[2018-11-15T06:36Z]local: [INFO   ]          fastqc : Found 1 reports
[2018-11-15T06:36Z]local: [INFO   ]         multiqc : Compressing plot data
[2018-11-15T06:36Z]local: [INFO   ]         multiqc : Report      : ../../bcbiotx/tmpCENQTL/multiqc_report.html
[2018-11-15T06:36Z]local: [INFO   ]         multiqc : Data        : ../../bcbiotx/tmpCENQTL/multiqc_data
[2018-11-15T06:36Z]local: [INFO   ]         multiqc : MultiQC complete
[2018-11-15T06:36Z]local: Uncaught exception occurred
Traceback (most recent call last):
File "bcbio-v1.0.8/anaconda/lib/python2.7/site-packages/bcbio/provenance/do.py", line 23, in run
_do_run(cmd, checks, log_stdout, env=env)
File "bcbio-v1.0.8/anaconda/lib/python2.7/site-packages/bcbio/provenance/do.py", line 103, in _do_run
raise subprocess.CalledProcessError(exitcode, error_msg)
CalledProcessError: Command 'set -o pipefail; export PATH=bcbio-v1.0.8/anaconda/bin:$PATH &&  bcbio-v1.0.8/anaconda/bin/multiqc -f -l
[INFO   ]         multiqc : This is MultiQC v1.6.dev0
[INFO   ]         multiqc : Template    : default
Searching 25 files..
[INFO   ]     verifybamid : Found 1 reports
[INFO   ]           bcbio : Found 1 reports
[INFO   ]        samtools : Found 1 stats reports
[INFO   ]        samtools : Found 1 idxstats reports
[INFO   ]           peddy : Found 2 reports
[ERROR  ]         multiqc : Oops! The 'peddy' MultiQC module broke...
Please copy the following traceback and report it at https://github.com/ewels/MultiQC/issues
If possible, please include a log file that triggers the error - the last file found was:
peddy/sample.background_pca.json
Module peddy raised an exception: Traceback (most recent call last):
File "bcbio-v1.0.8/anaconda/bin/multiqc", line 440, in multiqc
output = mod()
File "bcbio-v1.0.8/anaconda/lib/python2.7/site-packages/multiqc/modules/peddy/peddy.py", line 87, in init
self.peddy_pca_plot()
File "bcbio-v1.0.8/anaconda/lib/python2.7/site-packages/multiqc/modules/peddy/peddy.py", line 219, in peddy_pca_plot
'color': ancestry_colors.get(d['ancestry-prediction'], default_color)
KeyError: 'ancestry-prediction'
Please find below attached peddy file
sample.background_pca.json.txt.zip
With WGS pipeline, it is able to generate multiQC on peddy results.
Please help me to resolve this.
Thanks In Advance
Fazulur Rehaman

Fazulur;
Thanks much for the debugging work and figuring out the underlying problem. The new peddy release (0.4.3) with this fix is available from bioconda, so updating with bcbio_conda install -c conda-forge -c bioconda peddy (or a standard --tools update) should get the latest version with the fix. Hope this gets everything running smoothly for your samples.

Hi Brad,
Thanks a lot. I will upgrade to new version.
Thanks & Regards
Fazulur Rehaman


#13400: Add data parallel suppport for Whisper Model

Ticket
Link to Github Issue
Problem description
Add Data Parallel implementation for Whisper model.
What's changed
Data Parallel implementation for Whisper model is added.
The model is configured to run on either N150 or N300, depending on the available machine.
Checklist

[ ] Post commit CI passes
[ ] Blackhole Post commit (if applicable)
[ ] Model regression CI testing passes (if applicable)
[ ] Device performance regression CI testing passes (if applicable)
[ ] New/Existing tests provide coverage for changes

I do not need to approve, but please:

Run full models CI (https://github.com/tenstorrent/tt-metal/actions/workflows/full-new-models-suite.yaml) Please talk to your teammates about it in a public channel, and tag me so I can see the conversation and ensure you introduce no new regressions
Resolve conflicts

I do not need to approve, but please:

Run full models CI (https://github.com/tenstorrent/tt-metal/actions/workflows/full-new-models-suite.yaml) Please talk to your teammates about it in a public channel, and tag me so I can see the conversation and ensure you introduce no new regressions
Resolve conflicts

@tt-rkim,
Sure, I've updated the team regarding the CI for the new models.


Get selected position using PositionSelectedCommand on ViewModel

1. How can I get the selected position of the observable collection binding PositionSelectedCommand to ViewModel?
I'm showing a list of dates and I want to change my UI data based on the selected date. This is the code on the ViewModel
        private ObservableCollection<SomeDate> _dateItems;         public ObservableCollection<SomeDate> DateItems         {             set             {                 SetProperty(ref _dateItems, value);             }             get             {                 return _dateItems;             }         }
        private ICommand _selectDateCommand;         public ICommand SelectDateCommand => _selectDateCommand ?? (_selectDateCommand = new Command<int>(ShowGoalsOfTheDay));
        private void ShowDataOfTheDay(int position)         {             Debug.WriteLine("Position selected command: " + position);         }
This way ShowDataOfTheDay is not called, but if I remove the int parameter from Command and on from the method, it calls the ShowDataOfTheDay, but I cannot get the position.

Am I passing the right parameter? If I pass the SomeDate object, it call the method, but the parameter value is always null.

Is it possible to get the selected item also?

@benazir0 hi, This project, probably, will be merged to XF.
If you wish, you can try another one https://github.com/AndreiMisiukevich/CardView
SelectedIndex and SelectedItem properties will be help you =)

@AndreiMisiukevich that is an excellent library. My background is white and the indicator is also white. How do I change the indicator color there? Is there any left and right indicator option like this library also?

@AndreiMisiukevich I have managed to change the indicator color style setting
<controls:IndicatorsControl SelectedIndicatorStyle="{StaticResource customStyle}">
Is it possible to use value converter to change the resource style like bellow?
<controls:IndicatorsControl SelectedIndicatorStyle="{Binding Item, Converter={StaticResource itemToStyle}}"/>
Also please let me know if there is an option to add left and right indicator on the carousel view.

@benazir0

Yes, sure you can use bindings for setting style, once SelectedIndicatorStyle is bindable property
Left/Right indicators - do you mean Rigth/Left arrows for navigating through the carousel?
This feature is deferred https://github.com/AndreiMisiukevich/CardView/issues/38
Because, i decided, that nobody need it)
You can easy add arrow to carouselview by yourself (because carouselview is absolutelayout)
Just create views, set them in layout and add ProtectedViewBehavior to behaviors collection of those views.

@benazir0 as Alex is returned, I think, we should create a new issue on my project and speak there.
Could you please create it? I will solve

I have made binding work like this:
<controls:IndicatorsControl>
    <controls:IndicatorsControl.SelectedIndicatorStyle>
        <Style TargetType="controls:IndicatorsControl">
            <Setter Property="BackgroundColor"  Value="{Binding item, Converter={StaticResource itemToStyle}}" />
            <Setter Property="HeightRequest" Value="25" />
            <Setter Property="HeightRequest" Value="25" />
        </Style>
    </controls:IndicatorsControl.SelectedIndicatorStyle>
</controls:IndicatorsControl>

@AndreiMisiukevich agreed.


put scaffolding in place for documentation autogeneration with tfplugindocs

This will allow us to autogenerate documentation using the tfplugindocs command. There are a couple of advantages to this:

Changes to resource schemas will be automatically reflected in the documentation after running tfplugindocs
Example code can be formatted with terraform fmt

Thanks for reviewing @pierre-fastly -- I'll make a followup PR that adds the autogeneration steps.


Define a way to let controllers update Spec

What problem are you facing?
While it's general consensus that the controller should not manipulate spec, i.e. desired state, in some cases the developer might want to update spec to adopt late initialization pattern that exists in Kubernetes https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/api-conventions.md#late-initialization
One could argue that defaulting via admission webhook could solve this, however, for external resources some fields are only available after the creation of the resource.

How could Crossplane help solve your problem?
There should be a way that allows spec update but I don't think all update calls we make should be converted from status. update. We need to define a way that implies that only in some cases, developer should opt for whole resource update, otherwise keep updating only status.

We need to define a way that implies that only in some cases, developer should opt for whole resource update, otherwise keep updating only status.

Sadly I don't believe this is possible for resources that use the status subresource; calling client.Update() updates only the object metadata and spec, and calling client.Status().Update() updates only the status.

Cross referencing https://github.com/crossplaneio/crossplane/issues/290, since I believe these issues are somewhat related.
It should be possible to do this today without any changes to the managed resource reconciler by plumbing the client.Client (i.e. Kubernetes client) through from the resource.ExternalConnector (which already has it) to the resource.ExternalClient that it produces. The Observe method of any resource.ExternalClient that requires late initialisation would be responsible for updating the spec of the managed resource under reconciliation, calling client.Update(), and handling any error.

An example of the pattern I suggested in https://github.com/crossplaneio/crossplane-runtime/issues/10#issuecomment-528239162 - late initialising the spec inside the Observe call - exists in the global address controller added in https://github.com/crossplaneio/crossplane/pull/750 .

The Observe method of any resource.ExternalClient that requires late initialisation would be responsible for updating the spec of the managed resource under reconciliation, calling client.Update(), and handling any error.

Hoped we can come up with a generic way to do it but I guess deferring it to Observe is as good as we can get since dealing with resource's configuration parameters in a generic way is usually not worth the headache.


gftools[qa] issues with cairo

Managed to install everything on my new M1 BigSur, but having issues running gftools qa.
(env) MacBookeRosalie:variable rosalie$ gftools qa -f *.ttf --fontbakery
Traceback (most recent call last):
  File "/Users/rosalie/Google/env/bin/gftools-qa.py", line 47, in <module>
    from diffenator.diff import DiffFonts
  File "/Users/rosalie/Google/env/lib/python3.9/site-packages/diffenator/__init__.py", line 9, in <module>
    from cairo import Context, ImageSurface, FORMAT_A8, FORMAT_ARGB32
  File "/Users/rosalie/Google/env/lib/python3.9/site-packages/cairo/__init__.py", line 1, in <module>
    from ._cairo import *  # noqa: F401,F403
ImportError: dlopen(/Users/rosalie/Google/env/lib/python3.9/site-packages/cairo/_cairo.cpython-39-darwin.so, 2): Symbol not found: _cairo_append_path
  Referenced from: /Users/rosalie/Google/env/lib/python3.9/site-packages/cairo/_cairo.cpython-39-darwin.so
  Expected in: flat namespace
 in /Users/rosalie/Google/env/lib/python3.9/site-packages/cairo/_cairo.cpython-39-darwin.so

Same issue as this: https://github.com/pygobject/pycairo/issues/226
But that doesn't seem to have a good solution...

If you're going to move to anything in HTML reports, I'd recommend moving to SVG, animated by Javascript. Vharfbuzz has a method to render a Uharfbuzz buffer as SVG.

I'm still quite fond of the current approach which uses the FreeType bitmaps. Perhaps allowing different backends would be a nice feature as well.

Looks like it has been fixed !


question

is this working for litecoin?

Yes, you just need to change the following values to match Litecoin:
https://github.com/prusnak/bip32utils/blob/master/bip32utils/BIP32Key.py#L26-L27
https://github.com/prusnak/bip32utils/blob/master/bip32utils/BIP32Key.py#L287


Bump version to 4.0.0

I am working towards #225 so hopefully we'll have that before we are fully ready for release. I asked about the copyright issue a while back and did not get a clear answer but definitely agree that it should probably be updated given that the repo is now under Intersect ownership/maintenance.
So, still some work to be done but at least we have a PR to start working against for tagging this as a proper release

Just curious: why bumping major version to 4.0.0? I don't see any breaking changes here, but maybe I am wrong?

@abailly, I felt it was appropriate because there wasn't any release in 2 years, so it seemed quite a big change. But it doesn't have to be a major version. There may end up being breaking changes though, not sure how it is going to unfold.

I don't have any fetichism about numbers so if 4.0.0 sounds cool, 4.0.0 it is :) We are planning to do such a release soonish with @paweljakubas


Transformation sheet API

The first two commits refactor the current index filter code. This actually
introduces more lines of code than it saves, but decouples the filtering from
the indexing a little.
The last commit adds a higher level API for extensions to use on top of the first. An example of what this API looks like is below, this adds an extra column to the active buffer counting the rows.
// Similar to a regular ZSV row handler used in ext_parse_all
void my_transformer_row_handler(void *ctx) {
  zsvsheet_transformation trn = ctx;
  struct transformation_context *priv = zsv_cb.ext_sheet_transformation_user_context(trn);
  zsv_parser parser = zsv_cb.ext_sheet_transformation_parser(trn);
  zsv_csv_writer writer = zsv_cb.ext_sheet_transformation_writer(trn);

  size_t j = zsv_cb.cell_count(parser);
  for (size_t i = 0; i < j; i++) {
    struct zsv_cell c = zsv_cb.get_cell(parser, i);
    zsv_writer_cell(writer, i == 0, c.str, c.len, c.quoted);
  }

  priv->col_count += j;

  if (!priv->row_count)
    zsv_writer_cell_s(writer, 0, (const unsigned char *)"Column count", 0);
  else
    zsv_writer_cell_zu(writer, 0, priv->col_count);

  priv->row_count++;
}

zsvsheet_status my_transformer_command_handler(zsvsheet_proc_context_t ctx) {
  struct transformation_context my_ctx = {
    .col_count = 0,
    .row_count = 0,
  };

  // TODO: This probably should happen in another worker thread and while that is happening the status should display
  //       that some work is in progress. The extension author will maybe want to have control over the status message.
  return zsv_cb.ext_sheet_push_transformation(ctx, &my_ctx, my_transformer_row_handler);
}

TODO (either in this PR or another):

[ ] run the transformation in a background thread and keep the user updated by changing the status
[x] figure out where custom_prop_handler and opts_used should come from?
[ ] tests

@richiejp looks great. Just a few questions/comments so far (have a few others but will reserve for after further review)

(this is somewhat of a nit): I'm don't quite follow why various names include "push"-- is referring to the style of parsing (push parsing)?
Some minor harmless but extraneous code bits can be removed:

  // these two lines unnecessary following `filename = zsvsheet_buffer_data_filename(buff);
  // since that function already does this
  if (!filename)
    filename = zsvsheet_buffer_filename(buff);

// opts_used only matters the very first time after a user has specified property overrides
// (such as adding a `--header-span` command-line option) and *before* the file it applies
// to has been opened by `zsv_new_with_properties()`. Once `zsv_new_with_properties(*opts)`
// has been called, the effect of opts_used is already reflected in the passed `opts` arg and in turn
// is saved in the ui_buffer structure
struct zsvsheet_transformation_opts {
  ...
  const char *opts_used; // this can be omitted
};

// note: custom_prop_handler should also be tracked, but this only matters for code that is external to
// `zsv` so this implementation can be deferred with a to-do note in the comments (as there already is)
// It may also be useful / desirable to consolidate the tracking of this info here, with the same tracking
// performed by sqlite3_csv_vtab-mem.c, in which case the global list could be kept in the CLI scope
// a pointer to it passed to the sql extension module, and that single shared memory structure used by
// both the sql module and `sheet` (and any others that may need)

thanks @liquidaty!

Push in {zsvsheet,ext}_sheet_push_transformation actually refers to pushing a new buffer to the top of the stack. It's quite ambiguous so I'll think of some alternatives.
OK, so opts_used can be removed and custom_prop_handler can be deferred.

So far my only suggestion is to replace "push" with "buffer", so that it becomes ext_sheet_buffer_transformation or just to remove "push".
On a separate note I think it is possible to "stream" the transformation with relatively few alterations by reading the file that is being written to. Albeit with the possibility of parser errors if quotes are left open, but this would allow the user to see the transformation in progress. If the builtin filter were also made to work this way then the user would see filter results slowly appear when filtering a very large file with most of the entries filtered out.
Furthermore the index could also be built incrementally and used before it has completed.
First though I am working on just putting the transformation into a background thread.

Rebased onto main and fixed some memory errors. I created a version which offloads the work onto another thread and redisplays the file as new results are read. I'll put that in a separate PR.

At this point I think this could be closed and superseded by #304
There are some issues fixed in #304 that would need to be backported here to the extent #304 is probably now in better working condition than this PR.


[Question] Use in Django

Hello,
How could i use this into a django project please ?
Thanks for help.
Regards,
Thierry

Hello !
MRQ doesn't have an integration with Django. We recommend using Celery for that use case.
thanks!

Thx
De: Sylvain Zimmer<EMAIL_ADDRESS>Répondre: pricingassistant/mrq<EMAIL_ADDRESS>Date: 3 septembre 2019 at 02:00:46
À: pricingassistant/mrq<EMAIL_ADDRESS>Cc: Thierry BOULOGNE<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Sujet:  Re: [pricingassistant/mrq] [Question] Use in Django (#215)
Hello !
MRQ doesn't have an integration with Django. We recommend using Celery for that use case.
thanks!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.


How to remove the "Initialization was successful" when it bypasses the vac?

Compile vac-bypass yourself (not vac-bypass-loader) and remove the messagebox.

Compile vac-bypass yourself (not vac-bypass-loader) and remove the messagebox.

thank you alot it was jst about the dll to hex but my friend helped me
Thanks.


Update PPP, UG, error message

Codecov Report

Merging #204 (37ef7cb) into master (40a9e6e) will increase coverage by 0.04%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master     #204      +/-   ##
============================================
+ Coverage     45.49%   45.53%   +0.04%
- Complexity      495      496       +1
============================================
  Files           129      129
  Lines          2473     2475       +2
  Branches        292      293       +1
============================================
+ Hits           1125     1127       +2
  Misses         1259     1259
  Partials         89       89

Impacted Files
Coverage Δ

.../seedu/address/logic/parser/ArgumentTokenizer.java
84.78% <0.00%> (ø)

...eedu/address/logic/parser/ImportCommandParser.java
84.61% <0.00%> (+0.61%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40a9e6e...37ef7cb. Read the comment docs.


Bug: Maya Repair Incorrect Frame Range Action fails / doesnt work

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior:
When workfile containing wrong frame range on OP instances like Review Animation Pointcache differing from DB entries Validator Repair action does not set those accordingly. Practically fails to repair those frame ranges.

And the log for the error when user triggered Repair action:
// pyblish.pyblish.plugin.Action : Finding failed instances..
// pyblish.pyblish.plugin.Action : Attempting repair for instance: rayman_rigMain_01_ ...
// Error: pyblish.plugin : Traceback (most recent call last):
//   File "D:\REPO\OpenPype\.venv\lib\site-packages\pyblish\plugin.py", line 527, in __explicit_process
//     runner(*args)
//   File "D:\REPO\OpenPype\openpype\pipeline\publish\publish_plugins.py", line 243, in process
//     plugin.repair(instance)
//   File "D:\REPO\OpenPype\openpype\hosts\maya\plugins\publish\validate_frame_range.py", line 139, in repair
//     if cmds.attributeQuery("handleStart", node=node, exists=True):
// TypeError: No object matches name: rayman_rigMain_01_
// Traceback (most recent call last):
//   File "D:\REPO\OpenPype\.venv\lib\site-packages\pyblish\plugin.py", line 527, in __explicit_process
//     runner(*args)
//   File "D:\REPO\OpenPype\openpype\pipeline\publish\publish_plugins.py", line 243, in process
//     plugin.repair(instance)
//   File "D:\REPO\OpenPype\openpype\hosts\maya\plugins\publish\validate_frame_range.py", line 139, in repair
//     if cmds.attributeQuery("handleStart", node=node, exists=True):
// TypeError: No object matches name: rayman_rigMain_01_

Expected Behavior:
If frame range being different from DB entries for current asset Validator's Repair action should fix those so the frame ranges matches DB.
Version
3.16.4
What platform you are running OpenPype on?
Windows
Steps To Reproduce:

Create Animation or Pointcache or any other instance with frame range attribs
Change frame range so they differ from database entry
Try to Publish
Use Repair action to fix frame ranges
Publish should happen without erroring out

Are there any labels you wish to add?

[X] I have added the relevant labels to the bug report.

Relevant log output:
No response
Additional context:
No response

This particular line I think should refer to instance.data["instance_node"] instead.
        node = instance.data["instance_node"]

If so, this might also be wrong.

I would like to contribute to this. Please help me out..

Thanks @BigRoy , will follow the steps you've provided and update you with the feedbacks.  Thanks!

@shobhit9957 Any luck with this?

Nothing, getting confused. I'm just a beginner to this open-source community...so it takes time. Can you please provide me some more detailed information...because that will provide me some more context. Thanks you, sorry for the late...

@shobhit9957 It's hard to get into detail to get you on track the right way. To help you out it's important that you clarify where you get stuck.

What did you try?
Where did you get confused? What went differently than you expected?

Actually, I got confused by seeing that big issue description, so I didn't even try my hands on. but I'll go through it throughly and try it....let's see what my beginner friendly skills can do. sorry @BigRoy you maybe expecting me to be a "G" here, but I'm actually a noob. but I'll give it a try...sorry.


One repo for multiple websites

I'm interested in using a single Netlify CMS repo accross multiple websites. So for example, having one admin area where content is edited and then it displays across the different websites.
I'm aware of branch subdomains, but my question is - is it possible not to have to merge content from one branch to another - can content be queried from a single source without having to merge branches? If you deploy on a master branch can that content then be displayed on any subdomain branches as part of that deploy?
Thanks.

You can have a single repo with multiple websites, and Netlify CMS can edit any of that content in one instance. You just need separate Netlify sites for each.
Sent with GitHawk

Ah - that makes sense. How would I go about cding into directories for each site - is that something you set up in the Netlify UI somewhere?

Yep, just edit the build command. Typically it's something like npm run build. If each website directory in your repo has it's own package.json with it's own build script, then in the Netlify site for each, your build command would be cd directory-name && npm run build. Likewise, the "Publish directory" field would need to reflect the right path, probably directory-name/dist.

How about having multiple repositories managed inside one instance of Netlify CMS? That'd be really useful for me at the moment.

@hughrawlinson can you open a separate issue explaining what you're trying to do?

This "cding" is quite hacky, I have to say. I cannot use a more finetuned netlify.toml then, right? This should be handled much better in the future.

This would be quite helpful.
We have a case where we want to deploy our Storybook with a different command than our main website.
The problem is that we also want to use [context.production] to run a different build command for our main site on production vs staging.
Adding this to the netlify.toml currently overrides the command for both sites.

@camsloanftc You can run different commands based on context in the setting of the netlify.toml
# Global settings applied to the whole site.
[build]
  command = "yarn build"
  publish = "public"

# build a preview of the site (Drafts and Future dates also)
[context.deploy-preview]
  command = "yarn build:preview"

# build a staging build for the `staging` branch
[context.staging]
  command = "yarn build:stage"

You can of course use any commands that fit your case

@talves - Yes we are doing that already, but we need to run a different command for our Storybook site, which relies on the same repo. So ideally we would need some way to use the URL of the site to check if it is the storybook url or the main website url, or have the ability to select a different netlify.toml file depending on the site we are building. This may be too much to ask though.

@camsloanftc now it makes sense.
I would handle it by creating a node script that checks an environment variable. Based on the value of the environment variable, the correct command would be executed. The Environment variable would be stored in the site admin console at app.netlify.com and not in the netlify.toml file.

Oh great call I had not thought of that.


Vmmaster clean app

!test

Refer to this link for build results (access rights to CI server needed):
http://jenkins.2gis.local/job/vmmaster.staging.regression/277/
Test PASSed.

:+1:


nz-select - set initial values through ngModel not working under nzServerSearch mode

Reproduction link
https://codesandbox.io/s/keen-architecture-h7ixo?file=/src/app/app.component.ts
Steps to reproduce
In nz-select set ngModel to  [(ngModel)]="selectedUser",  then in the code, initial selectedUser to ['David ']
What is expected?
Expect initial array of selectedUser (e.g. "David ") are displayed after page loading
What is actually happening?
ng-select display blank at first. Add (ngModelChange) event listener to log $event to console, then start a search and select a new item, e.g "Victor", console display both initial value and new value, e.g. ['David ', 'Victor'], however screen still show 'Victor' only

Environment
Info

ng-zorro-antd
9.1.2

Browser
all

https://ng.ant.design/components/select/zh#components-select-demo-default-value


Scottmo/prepare api 1

Updates:

Query object
Support loading xml into Query object + tests
Move feature query param parsing logic to controller

ToDos:

need a way to enforce the shape of Query xml (future)
API (soon)

Changes Unknown when pulling 7f0bb7fd21f00365e06958d979a872b7038ac64f on scottmo/prepareAPI into ** on master**.


Fixed issues and added a Visual Interface

Fixes issue with the filename having space and '/" character
Added boundary conditions
Updated mime partitioner to consider all mime types
Added ability to record license header in Solr Core by parsing Rat logs
Added a visual interface and 'statistics' Solr Core

thank you @karanjeets AWESOME. Please add some instructions for how to use the interface

this PR introduces this problem on Mac:
https://unix.stackexchange.com/questions/145299/simple-sed-replacement-of-tabs-mysteriously-failing
So, we need to fix it so that it works on Mac. I'll update this.

On Mac you can just install Homebrew and GNU Sed. I've updated the wiki, as described here: https://github.com/chrismattmann/drat/wiki/Installation

OK another problem I found here - your script pge/bin/rat_audit/copy_files.sh doesn't handle files that have '$' in their filename, and fails to copy those files, causing dratstats to fail.

Here is a file it fails on:
/Users/mattmann/drat/src/distribution/target/apache-tomcat-7.0.65/webapps/examples/WEB-INF/classes/async/Stockticker$TickListener.class

@karanjeets FYI


Update HA Airgap docs to pass in the environment variable for private registry during the helm chart install

https://rancher.com/docs/rancher/v2.x/en/installation/ha/helm-rancher/chart-options/#setting-extra-environment-variables


base: readable string for factory and base objects

Description
Add __str__ implementation to Base and StoredFactory.
Changes
Add __str__ implementation to Base and StoredFactory.
Related Issues
#261.
Checklist

[ ] Tests included
[ ] Build pass
[x] Documentation
[x] Code format and docstrings

Codecov Report

Merging #450 into development will decrease coverage by 0.09%.
The diff coverage is 75.00%.

@@               Coverage Diff               @@
##           development     #450      +/-   ##
===============================================
- Coverage        67.61%   67.52%   -0.10%
===============================================
  Files               81       81
  Lines             3761     3775      +14
===============================================
+ Hits              2543     2549       +6
- Misses            1218     1226       +8

Impacted Files
Coverage Δ

jumpscale/core/base/factory.py
91.89% <75.00%> (-0.46%)
:arrow_down:

jumpscale/core/base/meta.py
92.00% <75.00%> (-1.81%)
:arrow_down:

jumpscale/core/exceptions/exceptions.py
96.96% <0.00%> (-3.04%)
:arrow_down:

jumpscale/tools/startupcmd/startupcmd.py
85.71% <0.00%> (-1.30%)
:arrow_down:

jumpscale/core/logging/logging.py
92.37% <0.00%> (-0.85%)
:arrow_down:

jumpscale/servers/gedis/server.py
69.63% <0.00%> (-0.53%)
:arrow_down:

jumpscale/clients/redis/redis.py
88.23% <0.00%> (+2.94%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1fc6a0e...a75dc20. Read the comment docs.


Bump aml/cli for args-file fix

Signed-off-by: Darren Shepherd<EMAIL_ADDRESS>

Context of this change is this discussion: https://acorn-users.slack.com/archives/C03R9ME0SKC/p1698158763985289?thread_ts=1697468824.044219&cid=C03R9ME0SKC


[6.0] SILGen: Check whether return statement has expression before examining for compatibility.

Explanation: Fixes a compiler crash when a void return with no expression appeared inside of a noncopyable switch.
Scope: Bug fix.
Issue: rdar://127294417
Original PR: https://github.com/apple/swift/pull/73339
Risk: Low. Small bug fix.
Testing: Swift CI
Reviewer: TBD

@swift-ci Please test


Please consider exposing client and cache

When using the Flysystem plugin pattern, it's necessary to get access to client to run public methods available for specific client (such as getObjectUrl for s3 client).
Exposing cache allows the plugin to utilize caching when necessary.

This would be awesome!

A PR has just been merged which ads the getAdapter method.

What about the cache implementation? I would be nice if I could easily flush() the cache from my controller.

Pr submitted in #17


Reproducible PHP process crash

Yesterday I closed Issue:
https://github.com/Azure/msphpsql/issues/63
because the repro script there worked as expected.
I soon found out that the same problem still happens on other scenarios, but it needed a new repro script as the original one had been fixed.
While building the repro script, I managed to build a script that crashes PHP.
See the script here:
http://pastebin.com/VENbce75
This is PHP 7.0.9 x64 on Windows with sqlsrv <IP_ADDRESS>
This is the crash detail from the system event viewer:
Faulting application name: php-cgi.exe, version: <IP_ADDRESS>, time stamp: 0x578fb9d9
Faulting module name: php7.dll, version: <IP_ADDRESS>, time stamp: 0x578fc24b
Exception code: 0xc0000005
Fault offset: 0x00000000001f726a
Faulting process id: 0x3aa0
Faulting application start time: 0x01d1ed52c8dd0d3a
Faulting application path: D:\php_runtime\php764\php-cgi.exe
Faulting module path: D:\php_runtime\php764\php7.dll
Report Id: d4234854-d6ef-487f-b301-db4ecd4f9872
Faulting package full name:
Faulting package-relative application ID:
If I comment out the followin line from the repro script:
$pdo_options[PDO::ATTR_EMULATE_PREPARES] = TRUE;
then the crash goes away (there are other errors, but the focus of this post is the crash itself).

Having the same problem here, when disable ATTR_EMULATE_PREPARES the crash goes away.

@david-garcia-garcia thanks for the repro script. Let us emulate it and understand what is causing the crash. We will keep you posted.

@david-garcia-garcia @Rvdv87 : We believe we closed this issue with our latest release https://github.com/Azure/msphpsql/releases. Can you help us validate?

Fixed! Thanks, now I can go back to the original issue.


Need to add Sorting Algorithms

Algorithm
Name: Sorting Algorithms
Short Description: We already have searching algorithms, which are important, but often companies are more interested in sorting algorithms and their time complexities. This is something I will begin working on, but if any others are looking for something to do - starting writing sorting algorithms and make a PR.
Programming language: Any

@AustinTice Can I help on this?


⚠ Bofrost.es has degraded performance

In 186fc4c, Bofrost.es (https://www.bofrost.es) experienced degraded performance:

HTTP code: 200
Response time: 2076 ms

Resolved: Bofrost.es performance has improved in 2cb60b6 after 7 minutes.


presto-cli should cancel query & exit on SIGTERM

Currently presto cli cancels a query when it receives a SIGINT signal. However, when it receives a SIGTERM signal the cli process exits without canceling a query, leaving the query running in the cluster until it gets abandoned. This PR adds support for gracefully handling the SIGTERM signal in the cli.

@cberner updated.

I don't think we need to handle SIGTERM explicitly. Instead, we should be able to install a shutdown hook that interrupts the main thread, which should cancel the query (the Presto JDBC driver handles interruption). We might need handling in other places like Console.runConsole() to exit on interrupt.
Try this in Console before creating QueryRunner:
@SuppressWarnings("ClassExplicitlyExtendsThread")
private static void interruptThreadOnExit()
{
    Thread thread = Thread.currentThread();
    Runtime.getRuntime().addShutdownHook(new Thread()
    {
        @Override
        public void run()
        {
            thread.interrupt();
        }
    });
}

Shutdown hook also registers handlers for sigint and maybe some other signals, wouldn't that interfere with the sigint handler installed here? I just wanted to be specific that's why i only registered a handler for sigterm. Will give this a try.

@electrum updated the PR to use a shutdown hook.

@electrum addressed @martint 's comments.

I cherry picked the interrupt status fix. Will review the rest soon.

@electrum Just rebased and made minor changes. Can you please review?

@electrum rebased & simplified.

I was testing this out and noticed that without this, the CLI exits immediately when killed and properly resets ctrl-C to be the interrupt character. With this change, the CLI prints "Query aborted by user", prints the "presto>" prompt, then exits, but doesn't restore the interrupt character.
I need to figure out exactly what is happening in both scenarios. Any ideas?

@electrum jline seems to be executing stty commands under the hood, see TerminalLineSettings::stty(). I need to debug to understand how to recover it though.

I think what's happening is jline tries to recover the interrupt character and creates a process to run the command below (this command recovers the intr character, you can confirm it by running that command when the interrupt character is disabled -- you can check the result with stty -a)
stty gfmt1:cflag=4b00:iflag=6b02:lflag=200005cb:oflag=3:discard=f:dsusp=19:eof=4:eol=ff:eol2=ff:erase=7f:intr=3:kill=15:lnext=16:min=1:quit=1c:reprint=12:start=11:status=14:stop=13:susp=1a:time=0:werase=17:ispeed=9600:ospeed=9600

but the shutdown hook doesn't wait for this process to finish.

@electrum how do you feel about enabling the interrupt character in the shutdown hook? We can refactor a bit to pass the Terminal instance (that we can get from LineReader) to the shutdown hook and call:
((UnixTerminal) terminal).enableInterruptCharacter();

Or do you have another suggestion?

Merged, thanks!

After lots and lots of debugging, I finally figured out what was happening: when the JVM gets a SIGTERM, it runs the shutdown hooks, then exits (even if there are non-daemon threads still running).
The thread join would wait the full timeout and return, with the main thread still running (i.e. the join times out). The main thread would be sitting at the readline prompt when the JVM exits, thus never running the cleanup code.
I fixed that by changing the readline loop to watch for a flag that gets set by the shutdown hook. This allows the main thread to exit normally and thus perform all the cleanup. It also makes the thread join quick because the main thread actually exits.

@electrum thanks!


Can you help mi solve this error.Thanks,I use window10 system.

(moose-env) E:\data>moosez -d ./input -m clin_ct_organs_v2
 __  _______  ____  ________  ___   ___
/  |/  / __ \/ __ \/ __/ __/ |_  | / _ \

/ /|/ / // / // /\ / /  / __// // /
//  //_/_/// /()_/
A part of the ENHANCE community. Join us at www.enhance.pet to build the future of PET imaging together.
� CITATION:
Shiyam Sundar LK, Yu J, Muzik O, et al. Fully-automated, semantic segmentation of whole-body 18F-FDG PET/CT images based on data-centric artificial intelligence. J Nucl Med. June 2022.
Copyright 2022, Quantitative Imaging and Medical Physics Team, Medical University of Vienna
� NOTE:
Imaging: Clinical | Modality: CT | Tissue of interest: Organs | nnUNet version: v2
Required modalities: ['CT'] |  No. of modalities: 1 | Required prefix for non-DICOM files: ['CT_']
Warning: Subjects which don't have the required modalities [check file prefix] will be skipped.
CUDA not available on this device. Predictions will be run on CPU.
� MODEL DOWNLOAD:
A local instance of Dataset123_Organs has been detected.
� STANDARDIZING INPUT DATA TO NIFTI:
Processing subjects... ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━   0% -:--:--
Standardization complete.
Number of moose compliant subjects: 0 out of 0
� PREDICT:
Traceback (most recent call last):
File "D:\anaconda3\envs\moose-env\lib\runpy.py", line 197, in _run_module_as_main
\ Initiating    return _run_code(code, main_globals, None,
File "D:\anaconda3\envs\moose-env\lib\runpy.py", line 87, in run_code
exec(code, run_globals)
File "D:\anaconda3\envs\moose-env\Scripts\moosez.exe_main.py", line 7, in
File "C:\Users\DELL\AppData\Roaming\Python\Python39\site-packages\moosez\moosez.py", line 199, in main
time_per_dataset = total_elapsed_time / len(moose_compliant_subjects)
ZeroDivisionError: float division by zero

Hi @shifuxiao,
Would you be kind enough to let me know the moosez version you are using. My guess is that you are using 2.2.8? Any particular reason why? If you are really interested in the organs, I would suggest to use the latest version of moosez. The organ model is much more robust since the training data was larger.
Please upgrade using pip install --upgrade moosez!
Also the error you are seeing is basically because there are no moose compatible directory structure. Kindly have a look at the readme section!

Hi @shifuxiao, is this solved? Kindly update!

@shifuxiao I am closing this, assuming this issue has been solved.