typed-protocols:  allow compilation with GHC 8.10.1

..which otherwise fails:
src/Network/TypedProtocol/Proofs.hs:142:38: error:
Not in scope: type variable ‘ps’
|
142 |      TerminalStates :: forall (st :: ps).
|                                      ^^
src/Network/TypedProtocol/Proofs.hs:145:39: error:
Not in scope: type variable ‘ps’
|
145 |                     -> TerminalStates ps
|                                       ^^

@coot, using it in a personal project of mine, and having troubles with ghc-8.8 (even ghc-8.10) bug:
https://gitlab.haskell.org/ghc/ghc/issues/18129

bors r+

@coot, to answer your question in direct way -- I'm a bit shy of showing the actual code that's using network-protocols, because it's not something that I consider necessarily pretty code.
It's a very exploratory project, so while it's entirely free software, I'm a bit reserved about inflicting eye-bleed : -)
That said, if you are still interested with that caveat, I can share it -- although the typed-protocols usage is fairly shallow at the moment, and it's really equivalent to a basic ping-pong protocol, so it's not anything exciting : -)


Keeping customizer settings when packaging / deploying the theme

Sorry if this isn't unique to FoundationPress, feel free to close. But I'm finding that whenever I package a theme and upload it, most of the customiser settings don't carry through, such as active widgets (sometimes works) Mobile menu always reverts to top menu and any custom customiser settings that I make such as phone numbers/ addresses are lost
How can this bug be reproduced?

package theme
upload zip
navigate to customiser

What did you expect to happen?
Hoped that all previously configured settings would be retained
Please List the Following:

OS & version: macOS Sierra
Node version (node -v) [Node v4+ is required] : 8.2.1
FoundationPress version (see line 3 in package.json): 2.9.2 / 2.10..2
Foundation version (see dependencies in package.json) : 6.3 / 6.4.2

Without being 100% sure, I assume you will experience the same thing with other themes too? From my point of view, it's logical that custom settings are stored in the database (on the server) and not in the theme files. Please correct me if I am wrong.

I'm sure you are right :) its fine that the settings are stored in the database, but there doesn't seem to be any way (that I know of) to re-apply them, even when the same theme is activated .. I often find myself wondering why the off canvas has stopped working only to realise it has defaulted back to top menu

If you dump a copy of your localhost database to your remote server, along with your theme files of course, I'm sure you will get both your custom settings, content and design. As I said, I think the way it's working now is by design. But if you experience different behaviour for other themes, I'm willing to look into it.

@nitrokevin This happens to me all the time :)  Especially when starting with a base theme and then realizing I forgot to switch to a Child theme version of the Parent.
Take a look at Customizer Export/Import:
https://wordpress.org/plugins/customizer-export-import/


Combine Stateless Components and Class Components

I have a working setup for Stateless components:
// State
export const useMyAppStore = () => {
  return useContext(StoreContext)
}

// In the Component
const App = observer(() => {
  const store = useMyAppStore()
})

But I have one "Map Class component" that requires inner state. How can I inject the same Store into a class component and make it observe the state? I tried the below but it doesn't quite work:

import { useMyAppStore } from "./state"

@inject(useMyAppStore)
@observer

class Map extends Component {
  constructor(props) {
    super()
        console.log(props)
    }
}

Thanks!

But I have one "Map Class component" that requires inner state.

What does that even mean? Do you know about useState? :)
With your own Context, you cannot use inject, but you can use contextType as easy escape hatch.

Thank you. I am closing for now as it was perhaps not the best explanation. And I have a functional workaround :)


Drag gets triggered on mouse/tap up

Expected behavior
Long press (or sustained click) with no x/y movement triggers press event, but not drag.
Actual behavior
A long press (or sustained click) triggers the drag event on mouse up or touch end.

Hey @ixley,
Thanks for the report! May I ask you to link me a JSFiddle that reproduces the issue? That would help me to quickly review the bug.
Thanks!

@ngryman I actually noticed this exhibited on the demo site – (Mac) Safari, Chrome, and Firefox (latest versions)

Thanks for the catch 🐞. I'm on it.

Fixed and released as 0.1.6. Thanks!


Merge mutable edit endpoints with other edit field endpoints

Mutable fields should be editable using the add, edit, remove field endpoints

working with sbh2, will need to implement still for sbh3


please add a linux version.

Feel free to build it yourself, but I don't have a linux machine, thus I can't build or bugfix.

Build it yourself.


fix: remove head fallback

Update the fallback logic for missing head.html to support newer helix projects.
🚨 Not sure if older projects are utilizing this fallback.

@tripodsan Removed the fallback
Don't think there is anything else I need to do but merge into main for Helix 5. If I got that wrong let me know.


example cron-backfill doesn't work

Pre-requisites

[X] I have double-checked my configuration
[X] I can confirm the issues exists when I tested with :latest
[ ] I'd like to contribute the fix myself (see contributing guide)

What happened/what you expected to happen?
https://github.com/argoproj/argo-workflows/blob/master/examples/cron-backfill.yaml
This should run daily but it doesn't. (I change it to * * * * * for testing, it doesn't run)
Version
v3.4.4
Paste a small workflow that reproduces the issue. We must be able to run the workflow; don't enter a workflows that uses private images.
https://github.com/argoproj/argo-workflows/blob/master/examples/cron-backfill.yaml

Logs from the workflow controller
none

Logs from in your workflow's wait container
none

I figured it out, it requires entrypoint: main in cronworkflows. I think it is should use the entrypoint: main in the template if there is no entrypoint defined in cronworkflows


Installation problems (Docker)

Seems to be a very promising tool. I had some troubles yesterday installing it though, and I'm sorry but I can't tell anymore why the recommended method didn't work, I didn't save the logs.
But I tried the docker mode too now and there also was a problem. It seems Powershell didn't have the rights and so i had to set this in powershell:
Set-ExecutionPolicy -ExecutionPolicy RemoteSigned
And then run install-docker.ps1
But in Powershell without admin rights!

Which version of Windows are you on?
Also, are you still stuck with either method of installation?
I appreciate your feedback, it'll help me sort out any issues for everyone else as well.
You can ping me on Discord as well if you want to go over the steps and I'll update the installation steps if needed.

Yeah I'm still stuck and I'm on Windows 11. How can i contact you on Discord? I'm not used to it.

The Discord link is https://discord.gg/RzdGa839MK
This is the running on Docker section https://github.com/ramyma/a8r8?tab=readme-ov-file#docker-1
The wsl command is when using the WSL installation method, i can now see how it might look confusing coming at the beginning of the running section.
The read me lists all installation methods and then all running methods. Perhaps I can organize the sections by method for install / running / updating


⚠ Bofrost.de has degraded performance

In f360a25, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1654 ms

Resolved: Bofrost.de performance has improved in 848238b after 6 minutes.


Spelling & grammar fixes in README

Summary
Just a few spelling and grammar fixes in the README.
Details and comments
N/A

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Casing of 'Initialize project for use with VS Code' is wrong

Platform/OS Version: Win10
Node.is : 8.9.3
Extension Version : 0.12.0
Repro Steps:

F1 -> Type 'Azure Functions: Initialize Project for Use with VS Code'.
Check the result.

Expect:
Display 'Azure Functions: Initialize Project for Use with VS Code'.
Actual:
Display 'Azure Functions: Initialize project for use with VS Code'.

Should use title case for all command titles


Proof of concept: access properties

#2
access properties
[$foreach $orders]

Product: [$each.product.name] Number: [$each.number] [$each]

[$end]

After adding order via button <button m-click='order()' type="button">Order [$blue-sky]</button>
  Product: [$each.product.name] Number: [$each.number] [object Object]
  Product: [$each.product.name] Number: [$each.number] [object Object]
  Product: [$each.product.name] Number: [$each.number] [object Object]

Need to do parsing again in websocket.js, or do I miss something?

Added a way to recursively visualize incoming objects in the JS from WebSocket. Works fine for traversing through the object path. But pushing and rendering full objects is an issue that can't really be solved.
On the Java side, a full object would default to using the toString(). Something like
Order{product='Product{name='Whitewood'}', number=5}
though this depends entirely on the toString implementation.
On the Browser/JS side there is an object with the same values, but you don't have access to the same toString() or how the object is represented on the Java side. A direct toString() runs the JS version, which results in an [object]. Or we can do what I've done in the above commit and use JSON.stringify(obj), resulting in {"product":{"name":"Whitewood"},"number":5}
No real way around that, I think. Even we'd go really deep in the rabbit hole and transpile a toString() version in JS based on the Java version, the Java side is still just a method that can have any kind of implementation. If you'd use a constant in the toString(), for example, it would need to also transpile the constant as well, etc. It doesn't work.
So I think this is fine for now - it can deal with the most important use case which is rendering the properties. Maybe we can consider throwing an exception when a full object is rendered instead of a sub-property? Since it would never visualize properly.


Recovering from a crash.

Running the below snippet produces the issue. Every other time ran it will not show any devices provisioned or peers connections. Providing a callback to .listen() you can see an error below.
zetta()
  .use(LED)
  .use(function() {
    throw new Error('123')
  })
  .listen(1337, function(err) {

  });

err produced
{ [Error: ENOENT, unlink '/Users/ApigeeCorporation/Software/zetta/zetta/sample/multiple-peers/detroit/.devices/214.medea.hint']
  errno: 34,
  code: 'ENOENT',
  path: '/Users/ApigeeCorporation/Software/zetta/zetta/sample/multiple-peers/detroit/.devices/214.medea.hint' }

This particular error is a result of medea compaction throwing an error when a missing hint file is trying to be deleted.
Compact tries to remove the hint file: https://github.com/medea/medea/blob/63169f2995e969d7d4f606b6543927bd9f99fcb6/compactor.js#L164
It's caught in zetta here and bubbles up to zetta.listen. https://github.com/zettajs/zetta/blob/daab94e6aaac0580604e1094331fba245ff3d802/lib/registry.js#L63-L64

@kyork-cl I think you were experiencing this yesterday.

@AdamMagaluk Can you file an issue on medea/medea, and we'll track it here?

@kevinswiber Issue in medea https://github.com/medea/medea/issues/54

Fixed by<EMAIL_ADDRESS><EMAIL_ADDRESS> Thanks @AdamMagaluk!  As soon as we get a PR bumping up to those versions, we can merge and release.


Update get-started.xml

Description

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):
Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[ ] My code follows the code style of this project.
[ ] I have updated the documentation accordingly.

Codecov Report

Merging #711 (379a4cc) into master (4f05afc) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #711      +/-   ##
============================================
- Coverage     55.24%   55.22%   -0.02%
+ Complexity    10385    10381       -4
============================================
  Files          1061     1061
  Lines         65762    65762
  Branches       7531     7531
============================================
- Hits          36333    36320      -13
- Misses        26830    26842      +12
- Partials       2599     2600       +1

Impacted Files
Coverage Δ

.../jmeter/protocol/http/sampler/HTTPSamplerBase.java
70.50% <0.00%> (-1.65%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f05afc...379a4cc. Read the comment docs.


Cannot copy/paste files between root folders

Testing #29176
I'd expect to be able to copy a file from root folder A and paste it to root folder B.

The keyboard shortcuts (cmd+c cmd+v) work, but only within one folder.
After copying a file, right clicking the folder name and selecting paste works in its own root folder, but the paste option is grayed out for a different root folder.

Fixed, dup of https://github.com/Microsoft/vscode/issues/29626


Extra disk for s3backups

What
It has been agreed that backups should be temporarily stored on separate partitions as
to not cause any issues for other services should the backup process somehow use
up all it's disk space.
How
Create separate mounts for backups.  Here I have added Logical Volume Manager
config for Mongodb instances performing s3backups.

Do mounts needed to be added for other node classes? I'm tired so sorry if I'm missing stuff.
I'm going to try to unblock this now.

No, You're correct. It probably makes sense to add these to a base mongo class if one exists.

Looks fine to me but it's not part of the system i know about so I'm hesitant to say merge without another set of eyes. @surminus / @alexmuller can we get another +1 please?

I think the disks still need to be created on the machines - for example /dev/sde1 doesn't exist on the mongo-n machine which will cause Puppet to fail.

Context to Alex's comment.  I'll need to create a new PR on the provisioning repo to add disks for staging and prod.

So https://github.gds/gds/govuk-provisioning/pull/558 has now been merged. Before this gets deployed we'll need to add the disks in vCloud director.

Disks have been added. Merging.


Add an option to generate the documentation as PDF

Feature is already supported by other asciidoc plugins and not core for Confluence Publisher.


added network diagram with critical path

Should we add this in the image or in a markdown file somewhere?


Add configuration file

Configuration handling needs some love. We should standardize it so it can be easily editable and extensible. One of the propositions we discussed was to use a YAML file.
version: 1
selectedAccount: default
accounts:
  default:
    jiraName: somename
    accountId: 123
    token: 345
    config:
      settings:
        someFlag: true
        defaultRemainingEstimate: 1h
      aliases:
        sm: abc-123
        daily: abc-123
        lunch: abc-321
      attributes:
        _EXTERNALREF_: foo
        _COLOR_: green
  jake:
    jiraName: somename
    accountId: 123
    token: 345
    config:
      settings:
        defaultRemainingEstimate: 1h
      aliases: []
      attributes:
        _EXTERNALREF_: foo
        _COLOR_: green
config:
  settings:
    defaultRemainingEstimate: 0h
  aliases:
    sm: abc-123
    daily: abc-123
    lunch: abc-321
  attributes:
    _EXTERNALREF_: foo
    _COLOR_: green

While it would serve its purpose I'm not the biggest fan of the YAML format. I'd like us to consider TOML or HOCON which in my opinion have better syntaxes.

I modified some keys and my proposition is something like that:
version: 2
selectedAccount: default
accounts:
  default:
    jiraName: somename
    accountId: 123
    token: 345
    accountConfig:
      settings:
        someFlag: true
        defaultRemainingEstimate: 1h
      aliases:
        sm: abc-123
        daily: abc-123
        lunch: abc-321
      attributes:
        _EXTERNALREF_: foo
        _COLOR_: green
  jake:
    jiraName: somename
    accountId: 123
    token: 345
    accountConfig:
      settings:
        defaultRemainingEstimate: 1h
      aliases: []
      attributes:
        _EXTERNALREF_: foo
        _COLOR_: green
globalConfig:
  settings:
    defaultRemainingEstimate: 0h
  aliases:
    sm: abc-123
    daily: abc-123
    lunch: abc-321
  attributes:
    _EXTERNALREF_: foo
    _COLOR_: green

Also I started writing migration from old config file but for now I have some problems with parsing maps (for example aliases) to YAML.


Create room if user join unknown room

Follow xmpp spec http://xmpp.org/extensions/xep-0045.html#createroom

Awesome stuff! Thank you :smile:

Thanks ! I'm on private-room #198 now, but it seems more complicated :hurtrealbad: :smiley:

You're a legend @manland

@manland see my latest commit, you can define extra methods in the extend method now.
Also for us to merge passworded rooms in, we'd need the same functionality in both the XMPP and web interfaces. We might be able to help there though.

@hhaidar thanks :sweat_smile: :flushed:
@sibartlett thanks for the tips, i will take a look on your last commit. For the passworded rooms i have listed web client, xmpp and rest api :innocent:

@manland I've disabled this functionality by default, but it can be enabled via configuration. Please see this commit: ccbe1a0304498789723509f58ecd9a8135f03728


Created Search Result component, including storybook tests. Renamed D…

Checklist

[x] the contributor license agreement is signed
[x] commit message follows commit guidelines
[x] tests are included
[x] screenshots are included showing significant UI changes

Description of change

https://github.com/openequella/openEQUELLA/issues/1306
Currently this component takes a resultData object, which matches the data produced from the new search2 endpoint (https://github.com/openequella/openEQUELLA/pull/1784). As a result of this the component definitely isn't as well typed. I'm planning on using the interfaces defined in PR #1784 to make the Search result component more robust/typesafe
The component will display

Item name
Item description
The thumbnail of the first attachment in an item, falling back to a placeholder icon if the item has no attachments
custom metadata, and showing/hiding thumbnails (defined in a collection's Search result display template)
The default state of the attachment panel (opened/closed defined in a collection's Search result display template)

Things i'm not sure about:

Currently, all of my logic is happening inside one single component. But I tried to separate everything out as much as possible to aid readability. But some of those areas (attachment display in particular) that could possibly be split into its own comonent, to aid in reuse later

Storybook tests. I wasn't sure where to put the test thumbnail i am using. Also, i feel like there is a better, more clean way to test the separate areas of the component

What isn't included

Attachment grid view
Clicking attachments to view them/more details
CAL/CLA support

Cool I see the failed build is just due to com.tle.webtests.test.contribute.bugs.VisibilityScriptingBugTest


Allow installation with Symfony v7 Series

Relevant to #117

Looks like we can support both v6 and v7 without breaking BC but v5 needs to be dropped.


Custom presets

Make a zip file that contains all of the information of the preset

makes the preset shareable and downloadable

https://stackoverflow.com/questions/9324103/download-and-extract-zip-file-in-android

https://developer.android.com/training/basics/data-storage/files.html

Zip files should contain

Song_name.zip

meta.txt
deck 1
-1.1Normal
-...
deck 2
...
-deck 3
...
-deck 4
...
-tutorial.txt
-explore.txt

Should create preset folder structure as well

Make a cross platform Preset maker kind of software

file_name.zip

sounds

[nametag]_[deck]_[pad]_[gesture].wav
...

timing

[pad]_[gesture].txt
this is global timing, doesn't get affected by decks

timing in milliseconds

about

album_art.jpg
artist_icon.png

this should contain transparent background

artist_image.jpg

this should contain image of the artist \(artist profile picture\)

about_json.txt

the Preset maker software could be web-based html

need to open the preset from zip [High priority]

done


chore(features) enable CombinedServices by default

What this PR does / why we need it:
Enables CombinedServices by default and updates test matrix to reflect this.
Which issue this PR fixes:
Fix #3979
Special notes for your reviewer:
See https://github.com/Kong/kubernetes-ingress-controller/issues/3979#issuecomment-1577388487. It looks like we meant to do this for 2.11, but the original issue only requests part of this change.
PR Readiness Checklist:
Complete these before marking the PR as ready to review:

[x] the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

How come the parser test - TestParser_GoldenTests - didn't fail on this PR? 🤔 👀 It's failing now on main (as it should without the necessary adjustment).
https://github.com/Kong/kubernetes-ingress-controller/actions/runs/5223254320
cc: @czeslavo


Finalize ExpressionAssertion

ExpressionAssertion was proposed in #23. This patch does the following:

Rebases it from develop.
Adds operators for strict in/equality and negated regex.
Renames the "not in" operator to !in.
Removes a potential concurrency issue.
Refactors internals for readability, maintainability, and context.
Adds documentation.

Thanks @weierophinney ! Sorry for locked branch complications, not sure how/why it happened.


Ready pointcloud with intensity

Hello, thank you for your great work.
I have one trouble:
Exported Pointcloud has no intensity value of points.
I learned source code and see, that frames points have intensity values, but next step, when you produce submaps from frames, submaps points have no intensity value.
Does it possible to add intensity values to points in exported pointcloud ?
Thanks

The intensity information is lost in the frame merge in sub mapping. If you want intensity data, you need to modify the following part to retain the original intensity information.
https://github.com/koide3/glim/blob/3d65b3b72a730b6b41fc667ed639bae5c29ca78a/src/glim/mapping/sub_mapping.cpp#L461

The intensity information is lost in the frame merge in sub mapping. If you want intensity data, you need to modify the following part to retain the original intensity information.
https://github.com/koide3/glim/blob/3d65b3b72a730b6b41fc667ed639bae5c29ca78a/src/glim/mapping/sub_mapping.cpp#L461

Hello,I need to modify the function gtsam_points::merge_frames_auto to add intensity information,but I can't locate where the function was implemented, maybe I should rewrite it by myself?

merge_frames_* are in gtsam_points. I'm thinking of implementing a merge function with intensity support, but it has a low priority for now.

merge_frames_* are in gtsam_points. I'm thinking of implementing a merge function with intensity support, but it has a low priority for now.

Thanks，I found the declaration of merge_frames_* in the file point_cloud_cpu.hpp，but it seems there is no corresponding function implemention in the file point_cloud_cpu.cpp.?

Thank you for your guidance on handling intensities with gtsam_points. Following your advice, I have implemented the following enhancements:

Intensity Handling in gtsam_points: Modified gtsam_points to support intensity data.
Intensity Export in GLIM's Offline Viewer: Updated GLIM's Offline Viewer to include intensity data when exporting maps, provided the submap contains intensity information.

These changes enable GLIM to process and export intensity data effectively. I've created branches in my forks for both repositories:

GLIM: https://github.com/h-wata/glim/tree/feature/export_ply_with_intensities
gtsam_points: https://github.com/h-wata/gtsam_points/tree/feature/add_intensities

Feel free to explore these branches if you're interested.


Added how to get started article

I don't think this page really would add much value to the handbook. The divio.com website should direct people in the right directions.


Implement customizable hash functions

This pull request implements a new optional config parameter so users can use other hash functions.
It defaults to the current implementation and is a fully optional parameter.

I'm going to close this for now since it won't be useful for edge runtime - want to prioritize that first


The number_of_inhabitants does not update the households_appliances_other_electricity_efficiency

The slider number_of_inhabitants updates the electricity consumption of all the appliances in the demand except the households_appliances_other_electricity_efficiency.

Well spotted @georgiasavvidou. Because of the 'value freeze' we will postpone this to the January deploy.

@georgiasavvidou, for future reference: input's are part of the 'etsource' repository and issues about them should be created there.

OK got that! Thanks!
On Mon, Aug 17, 2015 at 2:18 PM, Chael Kruip<EMAIL_ADDRESS>wrote:

@georgiasavvidou https://github.com/georgiasavvidou, for future
reference: input's are part of the 'etsource' repository and issues about
them should be created there.
—
Reply to this email directly or view it on GitHub
https://github.com/quintel/etengine/issues/777#issuecomment-131797734.

--
Georgia Savvidou
Quintel Intelligence
Atrium - Strawinskylaan 3051
1077 ZX  Amsterdam
The Netherlands
Visiting address:
Keizersgracht 639
1017 DT Amsterdam
T  : +31 (0)20 301 22 69
F  : +31 (0)20 301 22 02
M : +31 (0)6 476 613 92
E<EMAIL_ADDRESS>I   : www.quintel.com and www.energytransitionmodel.com


FastRTPS: Example from http://dev.px4.io stalls after around one second

@VicenteEprosima I've tried to run the example code on my machine this weekend and it did work, but it showed the exit statistics (which are conditioned on !running) after about one second.
Is this intended or an issue in the example code? I was expecting that I could consume the data indefinitely.
@mcharleb @bkueng Have you tested the current state on master?

@LorenzMeier may you are missing micrortps_client start -l -1?

@LorenzMeier The default value are 10000 loops of execution if you want to launch for ever is needed to add the parameter "-l -1" as is pointing by TSC21 above. Do you think this must be the default behavior?

Is there any valid use case where you would want this behaviour? It seems so uncommon that I considered this to be a bug.

Ok, @LorenzMeier we changed defaults #7835


Add runObeliskRhyoliteWidget, standardPipeline.

runObeliskRhyoliteWidget serves the purpose of making integration with Obelisk a little less hectic.
standardPipeline serves as a useful example of what the final 'Pipeline' argument to serveDbOverWebsockets might look like.

changelog


How to make the tensorflow backend dont occupation all of my GPU?

I know in tensorflow can use following settings, but how to set in Keras?
config = tf.ConfigProto() config.gpu_options.allow_growth=True sess = tf.Session(config=config)

Please refer to #1538

@samre12 Thank your answer.


Add timezone

Sorry, you should set the time zone to an environment variable instead of hardcoding it!


Allow importing of records without a DOI

Currently we only allow importing of bibliographic records that have a DOI.
See: https://github.com/substance/texture/pull/480#discussion_r181580524
To add support for entries without DOI's we'd need to make sure we don't end up with a lot of duplicates. Some options:

Be okay with duplicates being created for entries without a DOI
Implement a checksum over JSON object so we can check if an entry has exactly the same content and if yes skip it.

Hi there
Why is this so important? Is it because you are still trying to build a database of references? :-)
Many journals do not have DOIs yet, and some journals with DOIs did not update their archives and add DOIs to them. Some books have DOIs, but not all.
We have to allow for all reference types to not have DOIs.
eLife has schematron that detects duplicate references I think @JGilbert-eLife can you explain how we do it?
Cheers
M

Yeah 😀 no, it isn't because of that. As you said there will be a lot of references without DOI. Also we are allowing to Import from reference Managers, such as Zotero. We are just concerned to introduce problems by allowing to import the same record twice.

Cool! I hope James might be able to share how we do the check via Schematron if that helps?

any news about this feature? I'm using texture for a spanish journal but it's near impossible to have all the doi codes

Are you planning on including schematron in texture or did you just want to know the logic we were following so you could replicate it in something else?

When integrating Texture into XPub we would like create an interface between Texture and Schematron. In addition to that, we are adding a simple validator into Texture that runs checks inside the editor on-the-fly.

Yeah  no, it isn't because of that. As you said there will be a lot of references without DOI. Also we are allowing to Import from reference Managers, such as Zotero. We are just concerned to introduce problems by allowing to import the same record twice.

I tried to import the csl jason (generated with zotero) file of citations without DOI and it didn´t allow me to do it because of lack of DOI error


error: could not compile anyhow after ninja -C build-out all for most update version.

ninja -C build-out all
error: component download failed for rust-std-x86_64-unknown-linux-gnu: could not rename downloaded file from '/home/nicolast0604/.rustup/downloads/b01011cbb5503c456ecc6a557a38e099994b8497df545c661ce8fd48c5beadc6.partial' to '/home/nicolast0604/.rustup/downloads/b01011cbb5503c456ecc6a557a38e099994b8497df545c661ce8fd48c5beadc6'
error: could not compile anyhow

do you need to do a rust update?
On Wed, Nov 10, 2021 at 9:59 PM nicolast0604 @.***>
wrote:

ninja -C build-out all
error: component download failed for rust-std-x86_64-unknown-linux-gnu:
could not rename downloaded file from
'/home/nicolast0604/.rustup/downloads/b01011cbb5503c456ecc6a557a38e099994b8497df545c661ce8fd48c5beadc6.partial'
to
'/home/nicolast0604/.rustup/downloads/b01011cbb5503c456ecc6a557a38e099994b8497df545c661ce8fd48c5beadc6'
error: could not compile anyhow
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/lowRISC/opentitan/issues/9165, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAH2RSR7ODRPHKOX3K7IQLLULNLTHANCNFSM5HZUWV4Q
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

My rust is 1.56.1 and I saw the opentitan guide is 1.55.0
is it too new or too old?
By the way, I didn't have problem with the previous git repro.

I've never seen this problem. Does it still persist @nicolast0604 ? If not, can you please close the issue? Thanks!


recommended nodejs and npm version?

Hi,
what's are the recommended nodejs and npm versions to run hubot-rocketchat?
Ciao!
Marcus

I run it with 4.8.4 without problems now. But some infos about that would be nice.

I know this is super delayed.  But this depends 100% on hubot.   I've used up to 6.x with out issues.  Haven't tried 8.x yet


Bump go 1.18

Fixes #

Proposed Changes

🧹 Update to go 1.18

Pre-review Checklist

[x ] At least 80% unit test coverage
[x ] E2E tests for any new behavior
[x ] Docs for any user-facing impact

Codecov Report

Merging #461 (f564dd6) into main (f8e7bdb) will decrease coverage by 0.14%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #461      +/-   ##
==========================================
- Coverage   66.23%   66.08%   -0.15%
==========================================
  Files          38       38
  Lines        2070     2070
==========================================
- Hits         1371     1368       -3
- Misses        655      658       +3
  Partials       44       44

Impacted Files
Coverage Δ

plugins/vsphere/pkg/command/auth/create.go
90.72% <0.00%> (ø)

pkg/vsphere/adapter.go
63.15% <0.00%> (-1.58%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us.


Cells ordering gets messed up when dragging one cell quickly.

Hi hpique, thanks a lot for this wonderful tableview. While playing around with the demo app, I found a pretty serious bug... I have made gif demonstrating the same.

When I long press on a cell and then move it around very quickly (in both directions - up and down), the ordering of the other cells gets messed up.
For example, in the gif above, look at the cell 4. It gets stuck to the cell that I am currently dragging around. And when I leave the cell 1, a blank space is found where actually the cell 4 should have been.
Also, when dragging the cell over long distance (in both directions, quickly), the ordering of other cells in the table view gets haphazard. If this bug is difficult to reproduce, please do ask to clarify, I'll be happy to make other gifs with more detailed description to sort this bug out.
Thanks again, hpique!

Also seeing this problem.  hpique or aksh1t did you have any leads code-wise where things are going wrong?

It looks to be the ordering of the call to -[UITableView moveRowAtIndexPath:toIndexPath:] that causes this, swapping it back fixes it for me:
diff --git a/HPReorderTableView/HPReorderTableView.m b/HPReorderTableView/HPReorderTableView.m
index b7d3fc7..5709fb4 100644
--- a/HPReorderTableView/HPReorderTableView.m
+++ b/HPReorderTableView/HPReorderTableView.m
@@ -296,7 +296,7 @@ static void HPGestureRecognizerCancel(UIGestureRecognizer *gestureRecognizer)
 - (void)reorderCurrentRowToIndexPath:(NSIndexPath*)toIndexPath
 {
     [self beginUpdates];
-    [self moveRowAtIndexPath:toIndexPath toIndexPath:_reorderCurrentIndexPath]; // Order is important to keep the empty cell behind
+    [self moveRowAtIndexPath:_reorderCurrentIndexPath toIndexPath:toIndexPath];
     if ([self.dataSource respondsToSelector:@selector(tableView:moveRowAtIndexPath:toIndexPath:)])
     {
         [self.dataSource tableView:self moveRowAtIndexPath:_reorderCurrentIndexPath toIndexPath:toIndexPath];

Not submitting a pull request for this as the order appears to be deliberately set that way (59f025c73da6e9aac8fdb2b4520504a15445d132) to work around another issue, which I can't test for.
-bok

So my patch above does re-introduce the behaviour I think 59f025c73da6e9aac8fdb2b4520504a15445d132 was supposed to fix; that is, the cell being moved moves on top of the other cells. I fixed that by setting the cell layer's zPosition on dequeue so that won't happen and now both bugs appear to be fixed:
        cell.layer.zPosition = -10;

I'll pop in a pull request shortly.

Quick drag also causes call of  - (void)tableView:(UITableView*)tableView moveRowAtIndexPath:(NSIndexPath*)sourceIndexPath toIndexPath:(NSIndexPath*)destinationIndexPath with a row difference greater than one which is fine if the data source implementation "knows" that, but example implementation from title page (exchangeObjectAtIndex) leads to inconsistencies in underlying array.


Fail to import Template workflows, Workflow not imported - template(s) not found

Describe the bug
Trying to import a workflow in the Template section fails with HTTP 400 and the message:
Workflow not imported - template(s) not found

To Reproduce
Steps to reproduce the behavior:

Create any workflow with the existing standard tasks and export it,
Go to Administer -> System Workflows -> Templates
Create a new template by importing the workflow created at step 1.

Expected behavior
The template should be imported.
Environment (please complete the following information):

OS: Any OS
Browser: Any browser
Version: 3.9.0

Relates to https://github.com/boomerang-io/roadmap/issues/294


tree-shaking with lodash-es

See https://github.com/webpack/webpack/issues/1612#issuecomment-161018259.
Currently tree-shaking lodash-es modules is not possible with webpack 2 beta.
First clone into node_modules:
git clone -b es --depth=1 https://github.com/lodash/lodash.git ./node_modules/lodash-es

then:
npm i -g webpack@beta

then:
npm i babel-loader@^5 babel-core@^5

with test.js:
import { chunk } from 'lodash-es';
console.log(chunk([1,2,3,4], 2));

then:
webpack ./test.js ./bundle.js -p --display-chunks --display-modules --display-origins --module-bind js=babel-loader?blacklist[]=es6.modules

is
> gzip-size bundle.js | pretty-bytes
30.41 kB

While the output of import { chunk } from 'lodash-es/array/chunk'
is
> gzip-size bundle.js | pretty-bytes
1.19 kB

Related to https://github.com/rollup/rollup/issues/45

Anything I can do to help?

Ping.

@jdalton Thanks for the notice! I'm sure @sokra will address when he gets time for it.

Anything I can do to help?

Yes! If you want, please test out the webpack 2 beta and investigate any issues you find. Or take a look at the issue tracker to help free up more of @sokra's time to put towards webpack 2. There are many questions that just need a little bit of research to address. Thanks!

Yes! If you want, please test out the webpack 2 beta and investigate any issues you find.

This issue is about webpack 2 beta, I did the investigation, and outlined how to reproduce the issue in detail. I believe I've created modules in a way that should enable tree-shaking. @shama do you see any obvious issues? The only thing I can think of is that the inclusion of
export { default as default } from './lodash.default';

is giving webpack 2 grief. What do you think?

I'm not sure what the cause of this issue is. If I were to take a guess, it's likely babel is transforming the modules in a way that webpack can't remove the unused code or webpack is tripping on some syntax in lodash-es.
I'm not sure, I haven't tried debugging this issue yet.

If I were to take a guess, it's likely babel is transforming the modules in a way that webpack can't remove the unused code or webpack is tripping on some syntax in lodash-es.

\cc @sebmck

@jdalton can you try with Babel 6?  default export semantics changed between Babel 5 and Babel 6, wondering if that could impact it?

Is Webpack doing the DCE on the CommonJS output?

Not babels fault. I noticed the issue, but it's a bit difficult.
We can optimize it, but this would be an unsafe optimization. The ES6 spec says that all dependencies must be loaded even if the exports are not used.

@sparty02

can you try with Babel 6?

Just tried and the result is similar to Babel 5 in terms of resulting file size.
@sokra

but it's a bit difficult.

Can you clarify (deep dive) into what the tricky part is.

The ES6 spec says that all dependencies must be loaded even if the exports are not used.

Isn't the point of the tree shake optimization to work around this?

Is there something I can do in the way I generate the lodash-es modules to make it easier for you?

@jdalton generating single file without re-exports would solve the issue, I believe

@indeyets Would you give an example to clarify.

I think what @indeyets is suggesting is instead of importing and re-exporting like is done now:
...
export { default as add } from './add';
...

to concatenate everything into a single file like this:
...
export function add(augend, addend) {
  var result;
  if (augend === undefined && addend === undefined) {
    return 0;
  }
  if (augend !== undefined) {
    result = augend;
  }
  if (addend !== undefined) {
    result = result === undefined ? addend : (result + addend);
  }
  return result;
}
...

I doubt that this would change anything, though.

I doubt that this would change anything, though.

If it's already having a hard time recognizing there are no size effects to something straight forward (as it is now) I can't imaging inlining packages (with their local vars) would make things easier.

Maybe I'm misunderstanding the issue, but wouldn't that have to work @Awk34 ? Otherwise the entire tree shaking system would clearly not be working. The issue from my understanding is that by re-exporting causes webpack to not safely know if the original file causes a side effect during import. In other words, much like you can cause side effects just by require('something'), the initial imports to then export could be causing side effects. If every method was inlined into one file there would be no ambiguity.
This still seems highly impractical for most developers as they don't have tooling to make an inlined file just for webpack. If webpack allowed explicitly marking files as having side effects that would work around the spec I believe. Webpack already has its own require.ensure, so would it be that much of a leap to be able to declare imports with side effects?

It would be nice if there were standards support for a "weak reexport" that would say "I'm exporting this thing, but it doesn't need to be evaluated unless someone uses it".  This would not change the semantics of loading except that a loader could use it as a signal to do more aggressive optimization.  Nothing prevents loaders from evolving this on their own as a comment or annotation or external configuration, but if there's value to it then having it in the language instead of being loader-specific would be better for everyone.
Obviously, if a naive weak reexport targets a module with default side-effects then you might see inconsistent behavior, but I don't think that risk means that a well-structured library like lodash-es shouldn't have the option to declare its own safety.  In SystemJS where all this happens in the browser, it's rather important that reexports not be eagerly fetched, but there's no way to avoid that today without drilling down to the individual files (import {x} from 'lodash-es/x') which is quite a bit less pleasant syntactically than plucking names out of a single lodash import (import {x,y,z} from 'lodash-es').  Webpack doesn't have to be as concerned with when/if the dependency gets fetched (not that reading hundreds of lodash modules that it doesn't need to is a great thing), but it still would benefit from a clear signal that it can exclude something from the bundle.

LoDash uses its own functions to create some of its other functions, which triggers mandatory bundling of a lot of unused code.  For example, instantiating without invokes rest.  This means that, even if without is never imported, the entire implementation of rest and all its dependencies must be packaged in order to preserve possible side-effects.  Tree shaking and dead code elimination aren't allowed to remove rest unless they can prove it's a pure function (no side-effects).  Because JS is so dynamic and doesn't have static typing, this is almost never possible to prove at build time.
Dead code removers like Uglify could theoretically have a "frozen environment" or "predictable builtins" mode where they assume that all JS built-ins (Object, RegExp, window, etc) follow the JS engine's native behavior.  That means it could make additional assumptions about what does and doesn't trigger side-effects.
For example, today when Uglify sees this:
const unused = Math.floor;

it can only minify to this:
Math.floor; // gotta keep those side-effects; "floor" might have a getter function

With a "frozen environment" option, however, it could assume that accessing Math.floor is side-effect-free because no one has monkey-patched the environment.  This would require the code minifier to contain an inventory of JS's native APIs so it can make those decisions.  Anything not in that inventory, such as a new browser API or node built-in, would be assumed to trigger side-effects.

I put together a ready-to-run project that shows what webpack is emitting before and after dead code elimination.  It's more grokkable than the default minified output.  It has certainly helped me thinking about which code is reachable, what triggers side-effects, etc.
https://github.com/cspotcode/lodash-webpack-DCE-example
It writes plain and gzipped file sizes into build/file-sizes.txt.  Webpack emits code comments marking all exports as either used or unused.

This issue seems to be resolved using webpack 2.1.0-beta.15 for both lodash and lodash-es.
index.js:
import { chunk } from 'lodash-es';
console.log(chunk([1,2,3,4], 2));

and
import { chunk } from 'lodash';
console.log(chunk([1,2,3,4], 2));

running
webpack ./index.js ./bundle.js -p --module-bind js=babel-loader?presets=es2015

generates a file that's ~1.3 kB gzipped.

Oops false positive.

This is still the case in beta.25.
While webpack 2 will, correctly, not re-export any of the unused top-level re-exports, the __webpack_require__ calls are left in. While this will, at an absolutely pedantic way, keep correctness as all the side-effects of the modules (such as requiring other modules and calling their functions) will still happen, it is not deletable by uglify (the entry point from @cspotcode's repo, the same module after uglify without mangling).
It would be better if, when an import is done specifically for reexporting (as is done in lodash-es/lodash.js, the entry point), the import call itself should not be emitted if it is unused. The unused dependencies also should be not emitted at all, as no minifier can tell that an array element accessed with a dynamic index is unused.

Do we already know why this is not working? Is it because the default export exports everything, which means evaluating everything?
Even then, shouldn't side-effect-less functions then be removed by uglify?
I just would like to understand how to write code so that unused exports without side-effects are not included in the final bundle…

@wmertens I don't think it's the default export. I was wondering the same thing and tried the build with a custom version of lodash-cli that doesn't include the default export and webpack 2 still included everything.
I've put it in this repo

There's always babel-plugin-lodash to help with cherry-picking.

Yes, and that works fine, but I'd like to know why it doesn't work out of
the box…
On Sun, Apr 16, 2017, 4:42 AM John-David Dalton<EMAIL_ADDRESS>wrote:

There's always babel-plugin-lodash
https://github.com/lodash/babel-plugin-lodash to help with
cherry-picking.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/webpack/webpack/issues/1750#issuecomment-294329873,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AADWlqZmYeur9EjjEb748ABbWbjt4695ks5rwYAJgaJpZM4G0NZQ
.

I think it all has to do with the default exports. Consider the lodash-es/isArray. Currently this file looks like this:
var isArray = Array.isArray;

export default isArray;

When I put this into my some file in my example I see the following in my webpack bundle:
/***/ (function(module, __webpack_exports__, __webpack_require__) {

"use strict";
/**
 * Checks if `value` is classified as an `Array` object.
 *
 * @static
 * @memberOf _
 * @since 0.1.0
 * @category Lang
 * @param {*} value The value to check.
 * @returns {boolean} Returns `true` if `value` is an array, else `false`.
 * @example
 *
 * _.isArray([1, 2, 3]);
 * // => true
 *
 * _.isArray(document.body.children);
 * // => false
 *
 * _.isArray('abc');
 * // => false
 *
 * _.isArray(_.noop);
 * // => false
 */
var isArray = Array.isArray;

/* harmony default export */ __webpack_exports__["a"] = (isArray);

Somehow isArray got picked up and I never made use of it. Lets now change the exports so that we don't use export default:
var isArray = Array.isArray;

// export default isArray;
export { isArray };

The new shiny webpack bundle already picked up the fact that I never used isArray:
/***/ (function(module, __webpack_exports__, __webpack_require__) {

"use strict";
/* unused harmony export isArray */
/**
 * Checks if `value` is classified as an `Array` object.
 *
 * @static
 * @memberOf _
 * @since 0.1.0
 * @category Lang
 * @param {*} value The value to check.
 * @returns {boolean} Returns `true` if `value` is an array, else `false`.
 * @example
 *
 * _.isArray([1, 2, 3]);
 * // => true
 *
 * _.isArray(document.body.children);
 * // => false
 *
 * _.isArray('abc');
 * // => false
 *
 * _.isArray(_.noop);
 * // => false
 */
var isArray = Array.isArray;

// export default isArray;

I have a feeling that if the lodash modules would avoid using export default and instead export each function with the name it was given then webpack would have no issue shaking the tree.
Please see this tslint rule that was developed for linting typescript files to prevent users from using default exports:
https://palantir.github.io/tslint/rules/no-default-export/
Main point to take:

current tooling differs on the correct way to handle default imports/exports. Avoiding them all
together can help avoid tooling bugs and conflicts.

Wow, weird, why would there be a difference between default and named exports? Is this perhaps some ES spec rule? If not, this seems like it could be a webpack bug…

This is really weird. The default export should be picked the same way. Could you file a new issue for this?

Here is it: https://github.com/webpack/webpack/issues/4761. I hope you guys can reproduce it with the repo.

Any news on this? I see lodash-es not tree shaked as well
import { map } from 'lodash-es';

But the whole lodash-es lib ends up in the vendor.min.js when building for production.
Works fine with custom code with exports.

@damianobarbati Don't use it this way (until cherry picking babel plugin). Current problem is monkey-patched default export. And still in the next release monolitic bundle will be dropped.

@TrySound how should I use it?
With direct imports like import map from 'lodash-es/map'? 😱
I can't find much info on this cherrky-picking about babel, can you point something interesting about it?
Thanks! :)

I saw that with the externals config you could make a small function
to map requests for lodash.x to lodash/x.
However, I don't see a way to do that with named imports. Would be
nice to have a small function that just replaces named imports with
per-file imports.

Sorry, forgot about links :)
https://github.com/lodash/lodash/wiki/Roadmap
https://github.com/lodash/babel-plugin-lodash

Thanks so much!
IMHO this sucks, because this means we're going to have this problem with a lot of modules.
Applying a direct plugin/exception for lodash does not look like a good fit :\

This plugin is customizable and can be used with any library. But library with transparent es modules only references can be tree shaked as well. I did this in recompose library.

Anything new about this issue?

lodash released 4.17.5, and the lodash-es package now contains the "sideEffects": false flag, which allows webpack4 to tree-shake lodash.
I've created a tiny repo showing the behavior: https://github.com/AviVahl/lodash-es-webpack4
There was no need to even use named imports.

I think this issue is now resolved, so can be closed?

is it ? How do we do tree-shaking with lodash-es and webpack 4?

Yep, Webpack 4 supports the "sideEffects": false flag, which lodash-es uses to enables cherry-picking.

@jdalton Can you provide any working example? I have usual es6 imports ie. import { get } from "lodash-es" and webpack is not tree shaking the lodash at all resulting in including full lodash library into my bundle. I'm using Webpack 4.11 so sideEffects flash should be use, but it's not. Only explicit functions import ie. import get from "lodash-es/get" make the bundle smaller.

https://github.com/AviVahl/lodash-es-webpack4
@LKay

@AviVahl Thank you, but I import only specific functions from lodash-es (ie/ import { isEmpty, isNil } from "lodash-es") not all as combined object (import * as _ from "lodash-es"). And tree shaking doesn't work if cherry picking is in place.

@LKay if you're using Babel make sure it isn't transpiling the ES6 import into require. Webpack needs to see the import and exports statements to do tree-shaking. If you're using babel-preset-env you can turn off the transpiling like this:
{
  "presets": [
    ["env", {
      "modules": false
    }]
  ]
}

Playing with lodash-es and tree shaking, i noticed a bundle size bigger than expected.
This occurs because /lodash-es/lodash.default.js is being bundled in some cases even when not used (directly or indirectly).
To test try:
import {filter} from 'lodash-es'

filter()

Will create a minified 16.5 kb bundle. lodash.default.js is bundled although is not imported by filter or its dependencies.
Webpack reports the reason as "harmony side effect evaluation"
If i import functions not used by 'lodash.default.js' to configure chaining like head, tree shaking works fine with a <1kb bundle.
So i would say that somehow the sideEffects flag used by lodash-es is not being considered at all


chore: changes for golang ci lint to pass

Overview
Mainly comments a function that we will eventually use when we stick the QGB implementation together.

Checklist

[ ] New and updated code has appropriate documentation
[ ] New and updated code has new and/or updated testing
[ ] Required CI checks are passing
[ ] Visual proof for any user facing features like CLI or documentation updates
[ ] Linked issues closed with keywords

Codecov Report

Merging #80 (c21286d) into main (16eb6c5) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #80   +/-   ##
=======================================
  Coverage   17.52%   17.52%
=======================================
  Files           2        2
  Lines          97       97
=======================================
  Hits           17       17
  Misses         79       79
  Partials        1        1

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

https://github.com/celestiaorg/orchestrator-relayer/issues/81


Saved Search 1.0 tracking

The type of this PR is: New events

This PR resolves FX-3014
Description
Saved Search 1.0 tracking!
There is 1 event to track: which is toggling on/off the Saved Search! This event depends on how we model Saved Search on the back end and if we are able to generate a "saved search id" - I started the convo with engineering.
@abhitip I would like to instrument the push notification we send for a saved search alert. Is there anything to be done here?
PR Checklist (tick all before merging)

[ ] If I've added a new file to the tree I've exported it from the common index.ts
[ ] I've added comments with examples for any new interfaces or helpers and ensured that they're in the docs
[ ] No platform-specific terminology has been used outside of click and tap (platform is inferred by the DB storing events)

Hmmm this push notification would be a product push notif right? Have you asked engineering?

LGTM! I'll let you merge

:rocket: PR was released in v2.4.0 :rocket:


Updated contributors.md

Description
This PR fixes #9
Notes for Reviewer

Module you've worked on

[ ] Frontend (Signup/Login)
[ ] Backend (Login)
[ ] Backend (Signup)
[ ] Homepage
[ ] Others

If you specified others, please mention...

Congrats on your First PR to PDA Org
@Bhuvanaa28


Add auth_time to ID token

Is your suggestion related to an experience ? Please describe.
The id token returned in the OIDC code flow doesn't contain the auth_time value if it isn't explicitly requested.
Describe the improvement
Add auth_time value to id token
Specification:
https://openid.net/specs/openid-connect-core-1_0.html#IDToken

This issue is being closed due to extended inactivity. Please feel free to reopen it if further attention is needed. Thank you for helping us keep the issue list relevant and focused!


Add thresholds per object for owl_predictor

Changes the owl_predictor to accept a list of floats for the thresholds instead of a single value. Each threshold applies to an object in the prompt at the same index.
I did not add support for the tree predictor so there will be errors if you use the tree predictor with these changes.
This change could just go under an experimental branch.

Thanks for the PR!  Apologies for the delay in reviewing.
For backwards compatibility, I'd suggest we

Keep the parameter name as "threshold"
Add type checking, to handle the scalar or list type accordingly.

For example, the parameter definition would look like:
threshold: Union[int, float, List[Union[int, float]]] = 0.1

And then before function logic, can add float / int type checking to create a list.
if isinstance(threshold, (int, float)):
   threshold = [threshold]

This way any existing code will work, but specifying multiple thresholds still enabled.
Thanks!
John

Hey John, I've implemented the changes please review.
Thanks!

Tested / merged, thanks!


Got 'Expected nnop.Parameters node, module not found in node' error

I tried to turn a pre-trained VGG into a nngraph module and stuck some texture loss layers (used in neural style transfer) between some layers, but I kept got this error:
Expected nnop.Parameters node, module not found in node
It seems that if I don't stuck texture loss layers, then the graph model is fine, but even if I add one texture loss layer into the graph model, I got this error.
Does anyone know how to solve this ? Thanks!

Hi,
I got the same error too when I tried to modify a model. I am not sure what exactly went wrong in your case but in my case,
creating the original nngraph model  -        local model = nn.gModule({input}, output)
My modification needed some extra inputs to the model so I had to create the new nngraph model as
local model = nn.gModule({input,newinput}, output).
In your case, if you have multiple (new) outputs make sure you add them to the output table.


Update Quiz.js

This is the updated JavaScript for Quiz repo. Please verify my PR.
If find useful then please accept my PR and give hacktoberfest label.

Hey @DhanushNehru , please take a look. I've updated the JavaScript for the Quiz repository. If you find it helpful, please consider accepting my pull request (PR)


Can't target specific version via Unity package manager

If, per the README, I target #release/stable, I can install the package without an issue. However, if I try to target e.g. v1.7.0, now matter how I format it, Unity can't find the package.

As far as I know, you cannot target a specific tag when cloning a repo using an https:// link. It's not an issue with the package or Unity, rather GitHub doesn't provide such a feature. Try installing a package with OpenUPM. Not only will it allow you to install a specific version, but you will also be able to upgrade/downgrade a plugin whenever needed, and it installs dependencies of a plugin for you.

Install OpenUPM CLI https://github.com/openupm/openupm-cli#installation
In the command line, go to the directory your project is located in.
Run openupm add<EMAIL_ADDRESS>


CAMEL-16255 Use of the slack-api-model to create rich content

The point is to add this functionality without breaking the current component.
Not sure about using the Gson to transform the Message Object to JSON but the model has a lot of properties.
It's included in the library
I can spend time to write code to use json-simple if we do not want to use it.

Ok I will try to create a new component camel-slack-sdk

I think it gives you more freedom of developing the component as you wish, without having to deal with the older implementation. Btw lets leave this open for others to comment. My comment is not mandatory :-)

I am actually not in favor of creating another component because that might confuse users on which component to use and what is really the difference. My question is, if we can use the Slack SDK in this existing component? Of course as long having the same input data, same configs and the same output data that doesn't break the experience for users.

My idea was to have a new component and deprecate the other one. I think it is possible to have the same component with the new model, but I don't think we could introduce the usage of SDK without breaking the current behavior.

I think it is possible to have the same component with the new model, but I don't think we could introduce the usage of SDK without breaking the current behavior.

If it is going to break the existing behavior, then definitely a new component with the SDK would make sense. Then I would at least rename this component to something like camel-slack-legacy and keep the new one with camel-slack to have it least confusing for the users. Of course this needs to be mentioned in the migration guides

I think I can transform the legacy module to use the slack SDK without breaking it.
The first issue I ran into is the version of the okhttp.They are using the 4.9.1 and apache camel is using 3.14.7
Tried to force the SDK to use old version but I got some ClassNotFoundException using the webhook compatibility (but no issue if using slack app token)

That would be a problem. Okhttp 4.x is kotlin based.

I found a working method while forcing the okhttp version to 3.14.7
We can just override one class and one method to provide our configuration. Just tested and it works well and does not break the camel-slack component

I found a working method while forcing the okhttp version to 3.14.7
We can just override one class and one method to provide our configuration. Just tested and it works well and does not break the camel-slack component

That will be good if you can get it to work on the existing component

Thank you all. I am working on it so you can get a look at it.

I am not sure about the doc. Feel free to review and criticise anything. I am here to reply to any question you have

Done ! Thank you for the review, I did not know about that versioning in the documentation.
I volunteer to help to support the module if there is any JIRA ticket that comes for it later.
Apache Camel is the center of two big applications in my company

Shall we merge this?

+1, @omarsmak if you have time go ahead.
Thanks!


New builds?

Any chance we'll get a new build with all the latest libraries?

Hi,
I'm not sure what you mean exactly.

New build released anyway.


Clickhousex?

Have you tries clickhousex or clickhouse_ecto?

I wanted to try clickhousex but it also uses http api, so probably won't be any differences with Pillar.
I didn't try clickhouse_ecto.


Move the binary docs to docs/

Can we change the links in https://github.com/GoogleCloudPlatform/healthcare-data-protection-suite/blob/master/README.md to point to the readmes?

Can we change the links in https://github.com/GoogleCloudPlatform/healthcare-data-protection-suite/blob/master/README.md to point to the readmes?

Done

WANT_LGTM=xingao


make replication timeouts configurable via startup options

Scope & Purpose
Make replication timeouts configurable via startup options.
The following options are available (for active failover and master-slave replication):
    --replication.connect-timeout
    --replication.request-timeout

Values can be specified in seconds. If these options are used, they will be used for replication requests, overriding any hard-coded defaults or explicitly configured timeouts.

[ ] Bug-Fix for devel-branch (i.e. no need for backports?)
[x] Bug-Fix for a released version (did you remember to port this to all relevant release branches?)
[x] The behavior in this PR can be (and was) manually tested (support / qa / customers can test it)

Testing & Verification
This change is a trivial rework / code cleanup without any test coverage.
https://<IP_ADDRESS>/view/PR/job/arangodb-matrix-pr/7249/

https://<IP_ADDRESS>/view/PR/job/arangodb-matrix-pr/7253/

Tests blue except unrelated failure with timeouted ssl_server suite (known issue with 3.4) and no artifacts for Windows PR (although no other failures in tests despite ssl_server at node) due to this (oskar and jenkins issue).


gh-1662 - forces the context to be updated

When operations are executed on a graph a new context object will be created, containing a new jobId

Codecov Report

Merging #1666 into develop will decrease coverage by 0.94%.
The diff coverage is 68.75%.

@@              Coverage Diff              @@
##             develop    #1666      +/-   ##
=============================================
- Coverage      65.65%   64.71%   -0.95%
+ Complexity      1917     1916       -1
=============================================
  Files            797      752      -45
  Lines          25669    24449    -1220
  Branches        3309     3174     -135
=============================================
- Hits           16854    15823    -1031
+ Misses          7484     7332     -152
+ Partials        1331     1294      -37

Impacted Files
Coverage Δ
Complexity Δ

...rc/main/java/uk/gov/gchq/gaffer/store/Context.java
51.8% <60%> (+2.57%)
0 <0> (ø)
:arrow_down:

.../src/main/java/uk/gov/gchq/gaffer/graph/Graph.java
59.82% <83.33%> (-0.35%)
0 <0> (ø)

...onutil/iterable/LimitedInMemorySortedIterable.java
47.22% <0%> (-2.78%)
15% <0%> (-1%)

.../gov/gchq/gaffer/mapstore/utils/ElementCloner.java

...gov/gchq/gaffer/federatedstore/FederatedStore.java

...e/operation/handler/FederatedGetSchemaHandler.java

...n/handler/impl/FederatedGetAllElementsHandler.java

...fer/federatedstore/exception/StorageException.java

...n/handler/impl/FederatedOperationChainHandler.java

...java/uk/gov/gchq/gaffer/mapstore/impl/MapImpl.java

... and 40 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a62bb2...fd8f0a9. Read the comment docs.


gohack undo leaves trailing newlines

This is how we can reproduce the issue:
$ git clone https://github.com/rogpeppe/go-internal.git
$ gohack get gopkg.in/errgo.v2
$ gohack undo
$ git status
On branch master
Your branch is up to date with 'origin/master'.

Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
        modified:   go.mod

no changes added to commit (use "git add" and/or "git commit -a")

git diff produces:
diff --git a/go.mod b/go.mod
index 1c11744..e980eb2 100644
--- a/go.mod
+++ b/go.mod
@@ -3,3 +3,5 @@ module github.com/rogpeppe/go-internal
 go 1.11

 require gopkg.in/errgo.v2 v2.1.0
+
+

What I expected is that it there should be no diff, i.e.
$ git status
On branch master
Your branch is up to date with 'origin/master'.

nothing to commit, working tree clean

Looking at the Go's source code
https://github.com/golang/go/blob/26154f31ad6c801d8bad5ef58df1e9263c6beec7/src/cmd/go/internal/modcmd/edit.go#L209
maybe we could include modf.Cleanup() before modf.Format() in
https://github.com/rogpeppe/gohack/blob/03d2ff3646b7ffc380e059413e4302f6cbdeb09b/gomodcmd.go#L91
Created PR #69 for this. :smile:

gohack should just use go mod edit commands instead of editing the file itself. There is a reason why the Go team doesn't provides a package to edit go.mod: the official go.mod editing API is go mod edit.

Beware that go hack came out very early in the timeline of modules, before tools like go mod edit were fully developed.
Also, note that there is in fact a package to parse and print go.mod files: https://pkg.go.dev/golang.org/x/mod/modfile

The fact is that you have to keep in sync the version of your Go toolchain, and any other tools that have go.mod capabilities.
gohack which uses a package to edit go.mod that :

the gohack maintainers have to keep to go.mod editing editing in sync with the toolchain (and that doesn't happen: github.com/rogpeppe/go-internal/modfile hasn't been updated for 2 years just shows that doesn't work)
the end user has to update gohack when (s)he updates the toolchain with a gohack that has upgraded it's go.mod support.
That's isn't sustainable.

golang.org/x/mod/modfile can help to solve the first point (but that would still require that the gohack maintainers upgrade the dependency in case of a new go.mod format change), but that will never fix the second point.
So go mod edit is the only sustainable way.


How do I test for failed compilation?

 I have tests that check for certain compilation errors: https://github.com/moigagoo/norm/blob/develop/tests/sqlite/tronocomp.Nim
How do I do such checks in balls?

It's easy to use a when compiles(someTemplate): fail"that should not have worked" but the unittest side of balls doesn't have any knowledge of the compiler (yet) and does not run semantic analysis on test blocks or search compiler output for particular errors.  If you need that, you should stick with testament.
This isn't a terribly difficult thing to add, though the most correct implementation would probably involve importing large parts of the compiler into unittests and hooking into the error handler for sem.  I did this in my https://github.com/disruptek/dust project at some point.
Honestly, the unittesting portion of balls is not particularly special; lately, most of the development has been around the test runner (in the v4 branch), which is becoming more useful.

Thanks for the quick response! I totally forgot about the compiles check, thanks.


Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: imjohnbo/issue-bot@v3

Just as before with Node 12, Node 16 Actions are deprecated: https://github.com/imjohnbo/issue-bot/issues/80
This is a very useful Action and it would be great to see it bumped up to Node 20 to stay current 🙏

Ahh, looks like you already have a PR to update the Node version @imjohnbo:
https://github.com/imjohnbo/issue-bot/pull/95

Thanks @ACyphus. Merged!


Doc: Improve contributing documentation

In the doc it mentions to go to subfolder of examples but it was not
there :).
Signed-off-by: Federico Guerinoni<EMAIL_ADDRESS>

Thanks again @guerinoni


Fix a typo in README, delete some stuff so using attrs seems more encouraging

Coverage decreased (-1.1%) to 98.901% when pulling b70b1cc20b89960f7eb2a560c6ee766903aecc2c on ashfall:readme-typo into 42320c51c934eede991ac8063ae98323a32212f8 on hynek:master.

Coverage remained the same at 100.0% when pulling 7a720f9b10da9f5ff43581d73a74ba9b8d2db314 on ashfall:readme-typo into 42320c51c934eede991ac8063ae98323a32212f8 on hynek:master.

Coverage decreased (-3.3%) to 96.703% when pulling 96bf13bfa88c69553e3ae947f41180264d235845 on ashfall:readme-typo into 42320c51c934eede991ac8063ae98323a32212f8 on hynek:master.

thanks!


fix Sign.config Params

hey @ishuailibertine, could you tell what is your reason behind this change?


Disable/Enable takes effect

Missing on the page is if the change of status for Resource Governor is immediate or only takes effect after a restart.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 84902a9f-1e98-8d5a-40a5-a3c5380005e7
Version Independent ID: 3c96894c-4509-c1a2-06c0-8d9656eceece
Content: Disable Resource Governor - SQL Server
Content Source: docs/relational-databases/resource-governor/disable-resource-governor.md
Product: sql
Technology: performance
GitHub Login: @WilliamDAssafMSFT
Microsoft Alias: wiassaf

@AndreAtEXPAG -- Andre, thank you for your feedback.  Please consider these resources:

SQL Server on Microsoft Q&A
DBA Stack Exchange
Stack Overflow

@WilliamDAssafMSFT -- William, please look into this issue.

Hi @AndreAtEXPAG!  Thanks for taking the time to create this GitHub issue. When RG is disabled, the Disabling the Resource Governor has the following results: takes place immediately. A doc update is in flight to make this more clear. Thanks! Your feedback helps improve the docs for everyone.


Tweak Windows instructions to mirror macOS

@CoderDake @kenzieschmoll this tweaks the Windows setup to be the same as the macOS version:
https://github.com/CoderDake/devtools/assets/1078012/82ae3cc2-4dc7-4a0e-80ae-d8c526d46809
This PR points at @CoderDake's branch since it hasn't landed yet (so this could be merged into it), or I can re-point this at flutter/devtools after that lands.

Superseded by https://github.com/flutter/devtools/pull/6490.


Incorrect colors with Windows Classic theme & --gdi sw

I'm seeing this on both OS X and Ubuntu (since it's a gdi SW issue). Server group policy is set to allow up to 32bit color, server is Win2008R2
xfreerdp -u win08b -p *** --gdi sw <IP_ADDRESS>
8 colors: http://i.imgur.com/tS83Lh.png
15/16/24 colors (orange lines are artefacts from dragging window, and should be same blue as bg): http://i.imgur.com/zdZJGh.png
32 colors (perfect!): http://i.imgur.com/7axfdh.png
When using 'Windows 7 Basic' theme, issue disappears. I will continue debugging this.

@dorianj I just pushed a fix, please confirm that it fixes it for you and I'll close this issue.

Fixed! Nice work.


DNN v9.11 "forgets" SMTP password

Description of bug
In the Servers / SMTP server control panel, DNN "forgets" the SMTP password.
Steps to reproduce
List the precise steps to reproduce the bug:

Start at the Servers / SMTP server control panel
Fill in correct information about the SMTP server (URL, port, etc.)
Select "Basic" authentication
Enter the SMTP username and password.
Click save and the "Test SMTP Settings" and everything works perfectly.

Log off or do some other stuff. Go back to the Servers / SMTP Server control panel.

Under the label, "SMTP Password", there will be a link "change" - do not click on it.
Click on "Test SMTP Settings" - now you get an error message (something about the SMTP configuration)
Now click on the "change" link and re-enter the password and then test again. Everything works perfect.

If you go away to do some other stuff and return to "Test SMTP Settings", you get the same error message about the SMTP conifguration.
Current behavior
Explain the current behavior.
I think that DNN is "forgetting" the SMTP server password.
Expected behavior
Provide a clear and concise description of the expected behavior.
It looks like the SMTP Server password is not being properly stored.
Screenshots
If applicable, provide screenshots to help explain the bug.
Nothing interesting to see.
Error information
Provide any error information (console errors, error logs, etc.) related to this bug.
The error message suggests a SPAM filter. I do not believe that because if I re-enter the SMTP password, everything works again.
AbsoluteURL:/API/PersonaBar/ServerSettingsSmtpHost/SendTestEmail
DefaultDataProvider:DotNetNuke.Data.SqlDataProvider, DotNetNuke
ExceptionGUID:be06e929-cc34-4cae-a350-c5792b2deaeb
AssemblyVersion:
PortalId:-1
UserId:-1
TabId:-1
RawUrl:
Referrer:
UserAgent:
ExceptionHash:XeM+9gaTul8GqBXJo45Q9k3uDfk=
Message:Transaction failed. The server response was: Sending address not accepted due to spam filter
StackTrace:
at System.Net.Mail.MailCommand.CheckResponse(SmtpStatusCode statusCode, String response)
at System.Net.Mail.MailCommand.Send(SmtpConnection conn, Byte[] command, MailAddress from, Boolean allowUnicode)
at System.Net.Mail.SmtpTransport.SendMail(MailAddress sender, MailAddressCollection recipients, String deliveryNotify, Boolean allowUnicode, SmtpFailedRecipientException& exception)
at System.Net.Mail.SmtpClient.Send(MailMessage message)
at DotNetNuke.Services.Mail.CoreMailProvider.SendMail(MailInfo mailInfo, SmtpInfo smtpInfo)
InnerMessage:
InnerStackTrace:
Source:System
FileName:
FileLineNumber:0
FileColumnNumber:0
Method:
Server Name: OMEN2
Additional context
Provide any additional context that may be helpful in understanding and/or resolving the bug.
Nothing useful
Affected version

[X] 09.11.00 latest supported release

Affected browser

[X] Chrome
[X] Firefox
[ ] Safari
[ ] Internet Explorer 11
[ ] Microsoft Edge (Classic)
[X] Microsoft Edge Chromium

Today, colleagues reported the same problem with incorrect SMTP configuration for every website updated to v9.11.0.

I've had trouble with DNN forgetting the SMTP password since v.9.06.01, still see it occasionally on 9.10.02, I haven't tried v9.11 yet.
I have no idea why it happens but it is pretty random and happens between once every 1-2 months. I just go into server settings and re-add and save the smtp password. From what I can tell, when DNN "looses" the password, the password doesn't actually become NULL or change in the SMTPPassword SettingValue under HostSettings in the database, DNN just can't see it anymore until you re-save through the interface.
I wish I could provide more info. Typically happens using global smtp mode with basic authentication.

I was able to reproduce the issue on current codebase and have a clue on how to resolve it. I'll try to tackle that on our next open-source co-coding session next Saturday 7 PM https://discord.gg/m4RaJWd8


"Overview" needs more pictures

Title—suggest at least one photo (or better yet, gif) per major UI component
https://github.com/OfficeDev/office-scripts-docs/blob/master/docs/overview/overview.md

Addressed by #46 .


Fix typos

Fix small typos

on encrypted
on argument checks where the null was checkd after the length

@laedit,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot


RFC: Remove Platform.trustManager

We only need this for
https://github.com/square/okhttp/blob/7135628c645892faf1a48a8cff464e0ed4ad88cb/okhttp/src/main/java/okhttp3/OkHttpClient.java#L594-L604
And Platform has
https://github.com/square/okhttp/blob/7135628c645892faf1a48a8cff464e0ed4ad88cb/okhttp/src/main/java/okhttp3/internal/platform/Platform.java#L166-L168
So I plan to combine these into a single call.

Relates to Conscrypt support as otherwise, I need this ghastly method :( or request a nice accessor
https://github.com/yschimke/okhttp/blob/conscrypt/okhttp/src/main/java/okhttp3/internal/platform/ConscryptPlatform.java#L32-L51

https://github.com/square/okhttp/pull/3611/files
n.b. Not so easy to use X509ExtendedTrustManager as method just fails, doesn't sort or filter.

The method sslSocketFactory(SSLSocketFactory sslSocketFactory) of OkHttpClient.Builder still has an @deprecated flag. I think that flag was forgotten there.

I think we should not support Conscrypt with this deprecated API. I'm even tempted to suggest that if you attempt that combination we just throw. Won't impact any existing apps.

The problem is that you made a breaking change with 3.9.1 compared to 3.9.0 with making the method trustManager of Plattform protected. Hence it's not possible to set a socket factory using your default trustmanager without calling the deprecated method I mentioned.

Gotcha. Everything in internal is undocumented implementation details, and that includes Platform. We don‘t maintain any API compatibility in internal.

... which is to say, do whatever you want in Platform!


Kubernetes docs update

In our K8s docs we state to set a environmental variable of something like CLUSTER='cookie'
Kubernetes interprets this to include the single quotes and will fail.
We should update our docs to not include the single quotes.

Hi @scottpgallagher! I'm moving this issue to the teleport repo where the docs are sourced from. This repo is for the stack that builds the docs.


feat: feature flag for guided onboarding copy

Description
This PR is a re-visit to #2817 which was reverted in #2840 due to a bug in the Pincode behavior, causing it to change even when the feature flag was set to false; this PR includes the same features with this bug addressed. In addition, during onboarding, copy has been updated for the "re-enter pin" page.
Original description: an additional remote config feature flag, showGuidedOnboardingCopy , is added and recognized through changes made in this PR. This boolean defaults to false; application would appear identical to that before this PR when this boolean is false.
Different header titles and guide texts are shown if the new feature flag is set to true from Firebase. For the Welcome page, the welcome prompt is changed.
The pages affected are the Welcome, Name and Picture, PIN Setup and Biometrics Setup.
Other changes
None
Tested
Tests for individual pages that were affected by this flag were written, with the selector mocked to return true on that flag, and affected copies verified to be the "guided onboarding" ones.
This feature flag currently has only been added to alfajores, but not mainnet yet.
How others should test
Depending on how the feature flag is applied, test users should see different copy during onboarding.
Related issues

Fixes ACT-417

Backwards compatibility
Backwards compatible in that an older app that do not recognize the new feature flag would ignore it. Upgrade compatible because default value of false will be added during upgrading the old state.

These are what the pin-entry looks like during onboarding now. @nityarao

@XrayBravoGolf can we enable this in Alfajores for QA testing?

yeah should be fine @MuckT


Will osin-mongo-storage work with the latest osin?

Will osin-mongo-storage work with the latest osin?

+1
cannot use storage (type *MongoStorage) as type osin.Storage in argument to osin.NewServer: *MongoStorage does not implement osin.Storage (missing Clone method)

There's another project on github I used as a souce of my own storage

@janekolszak which one?

Let me search for you: https://github.com/nguyenxuantuong/osin-mongo-storage

@janekolszak found a fork resolved this issue: https://github.com/ashkang/osin-mongo-storage


Provide consistent set of plugin IDs for Gradle Plugin project types

At the moment, in order to write a Gradle plugin, one of the following plugins needs to be applied:

java-gradle-plugin in order to write a Gradle plugin in Java
groovy-gradle-plugin - in order to write a Gradle plugin in Groovy DSL (precompiled script plugin)
kotlin-dsl - in order to write a Gradle plugin in Kotlin DSL (precompiled script plugin)

In order to make the plugin names more consistent, the suggestion is to use the {language-the-plugin-is-written-in}-gradle-plugin naming convention in the plugin names.
We also want the existing plugins to keep working for backwards compatibility - as such, introduce two new plugins that would only apply one of the existing plugins:

groovy-dsl-gradle-plugin would apply groovy-gradle-plugin internally
kotlin-dsl-gradle-plugin would apply kotlin-dsl plugin internally

At the same time, we might want to deprecate the current plugins as we introduce their "aliases".
With groovy-gradle-plugin, the deprecation should be straightforward as it is only meant for writing precompiled script plugins in Groovy DSL.
We can not deprecate kotlin-dsl plugin as it is used not only for writing precompiled script plugins in Kotlin DSL - some investigation is needed here.

As part of this work, the external plugins kotlin-dsl-plugins should become part of the Gradle distribution and no longer be published independently to the portal.
While in general we want to move plugins out of the distribution, this is not the right place to start with it as this is in the very core of Gradle. It's not consistent at the moment.

Thank you for your interest in Gradle!
This feature request is in the backlog of the relevant team, but this area of Gradle is currently not a focus one, so it might take a while before it gets implemented.


Fix diskann COSINE support

thanks cydrain! Is there a ganruatee that all of the index in milvus support cosine, including: Faiss, HNSW, DiskANN and AutoIndex

Yes, all float index types can support COSINE now

/close


Fixing config validation failure on booleans

When running Test-AdfCode, if your deployment config files contain Booleans, the script will fail with the following error:
Validation of config file completed.
ERROR: The variable '$123' cannot be retrieved because it has not been set.

This occurs because the ObjectProperty.ps1 script receives "123" as the "$value" var when "$dryRun" is "$true".  Setting "$value" = "$false" and correcting "$exp" so that it receives "$false" as its value instead of "$$false".

The script receives what you configured in config.csv/json file.
Because you didn't show it here, I assume you did it wrong.
Probably in your config file you had value like 123 or $false (rather than false)

Demo Config file deploying just an integration runtime for the sake of testing.

type,name,path,value
integrationRuntime,DEMO-AZIR,typeProperties.computeProperties.dataFlowProperties.coreCount,"16"
integrationRuntime,DEMO-AZIR,typeProperties.computeProperties.dataFlowProperties.computeType,"General"
integrationRuntime,DEMO-AZIR,typeProperties.computeProperties.dataFlowProperties.cleanup,false
integrationRuntime,DEMO-AZIR,typeProperties.computeProperties.copyComputeScaleProperties.dataIntegrationUnit,"8"
integrationRuntime,DEMO-AZIR,typeProperties.computeProperties.pipelineExternalComputeScaleProperties.timeToLive,"30"

The code I'm referencing that leads to the failure when passed a boolean variable.:
Starting on line 138 of Update-PropertiesFromFile, dryrun sets $value to 123, then calls Update-Object Property

if ($dryRun) { $value = 123 }
if ($validPath) {
    switch -Exact ($action)
    {
        'update'
        {
            Update-ObjectProperty -obj $json -path "properties.$path" -value "$value"
            $report.Updated += 1
        }
        'add'
        {
            Add-ObjectProperty -obj $json -path "properties.$path" -value "$value"
            $report.Added += 1
        }
        'remove'
        {
            Remove-ObjectProperty -obj $json -path "properties.$path"
            $report.Removed += 1
        }
    }
}

In ObjectProperty.ps1, line 14, the "$exp" var sets to $$value
 elseif ($fieldType -eq [Boolean]) {          Write-Debug "Setting as Boolean value"          $exp = "$obj.$path = $$value"
}
"$exp" becomes "$obj.$path = $123".  While $obj.$path can be resolved, the variable $123 doesn't exist.

If your target value is type of boolean, you must provide boolean value, not numeric.

Maybe I'm still misunderstanding... so the script I was quoting where that numeric value ($value = 123) is being set is part of Azure.datafactory.tools. - azure.datafactory.tools/private/Update-PropertiesFromFile.ps1

Is there something more I can provide to prove the need for this fix?  Or is there an alternate fix you can suggest to correct the issue where providing a boolean variable in the configs causes a failure?

Actually, the dryRun line shouldn't be there, so I need to remove it.

Closed this PR per @NowinskiK's last comment as my proposed resolution will no longer be necessary if we remove the $dryRun line


Feature/applics 199 welsh translation notify templates

Describe your changes
Update notify API calls for Welsh projects: bilingual templates used for Welsh projects for: get updates, interested party submission & examination submission.
https://pins-ds.atlassian.net.mcas.ms/jira/software/c/projects/APPLICS/boards/242?selectedIssue=APPLICS-199

Useful information to review or test
This ticket requires infra changes to be deployed to test + prod: they have already been deployed to dev.
For testing, for the bilingual templates, the cases must be Back Office cases with 'wales' as a region.

Type of change 🧩

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation update
[ ] Other (please explain in the description section above)

Checklist before requesting a review

[x] I have performed a self-review of my own code
[x] I have double checked this work does not include any hardcoded secrets or passwords
[ ] I have made corresponding changes to the documentation
[ ] I have provided details on how I have tested my code
[x] I have referenced the ticket number above
[x] I have provided a description of the ticket
[x] I have included unit tests to cover any testable code changes

:tada: This PR is included in version 2.28.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 2.34.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.14.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.2.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Background flickering when NormalNC guibg is set

Make sure you have done the following

[X] I have updated to the latest version of blink.cmp
[X] I have read the README

Bug Description
To repro the bug you need to set background of NormalNC highlighting group to something else that is the background of your Normal highlighting group.
vim.api.nvim_set_hl(0, 'NormalNC', {bg = 'red'})

I cannot reliably reproduce this as I initially thought that documentation.auto_show = true is what triggers it
Example with documentation.auto_show = true
https://github.com/user-attachments/assets/934840ba-afb2-47bb-b5a9-0a8f7fe03a5b
Though I was also unreliably repro this with auto_show disabled
https://github.com/user-attachments/assets/58ec66d3-6546-403d-a050-1f03c398fb78
Relevant configuration
{
        'saghen/blink.cmp',
        version = 'v0.*',
        build = 'cargo build --release',
        opts = {},
    },

neovim version
v0.10.3
blink.cmp version: branch, tag, or commit
v0.8.2

I can't reproduce this, are you able to reproduce it in a minimal repro environment? https://lazy.folke.io/developers#reprolua

Thanks for the suggestion. I was able to narrow it down to a simple repro. There is a bit more code that I'd so I added a few NOTE: comments for the key parts.
The TLDR is I have a status line that contains the path to current names lsp document symbol. Similar to what VS Code has next to the file tabs. If it fails to request the document symbols for the current buffer it resets the string containing the path to the current position and triggers the status line update by calling vim.cmd.redrawstatus(). If this line is commented out, than the issue goes away. While this may seem like an edge case, I think it is still fair to consider this a bug as this issue does not reproduce with nvim-cmp. I am interested to see what you think about it.
vim.env.LAZY_STDPATH = '.repro'
load(vim.fn.system('curl -s https://raw.githubusercontent.com/folke/lazy.nvim/main/bootstrap.lua'))()

-- NOTE: plugins
require('lazy.minit').repro({
	spec = {
		'stevearc/conform.nvim',
		'nvim-neotest/nvim-nio',
		{
			'neovim/nvim-lspconfig',
			dependencies = { 'saghen/blink.cmp' },
			config = function()
				require('lspconfig').lua_ls.setup({
					capabilities = require('blink.cmp').get_lsp_capabilities(),
					settings = {
						Lua = {
							runtime = {
								version = 'LuaJIT',
								path = vim.list_extend(
									vim.split(package.path, ';'),
									{ 'lua/?.lua', 'lua/?/init.lua' }
								),
							},
							workspace = {
								library = vim.list_extend({vim.env.VIMRUNTIME, 'lua'}, {})
							},
							completion = { callSnippet = 'Replace' },
							codeLens = { enable = true },
							hint = { enable = true, setType = true },
						}
					}
				})
			end,
			-- event = 'BufReadPre',
		},
		{
			'saghen/blink.cmp',
			version = 'v0.*',
			build = 'cargo build --release',
			opts = {
				completion = {
					documentation = {auto_show = true}
				}
			},
		},
	},
})

-- NOTE: make sure non current window is highlighted
vim.api.nvim_set_hl(0, 'NormalNC', { bg = 'red' })

-- NOTE: custom status line
local _lsp_symbol_cache = ''
vim.api.nvim_create_autocmd({ 'WinEnter', 'BufEnter' }, {
	pattern = '*',
	desc = 'restore statusline when entering window',
	callback = function()
		vim.opt.statusline = "%!v:lua._G.custom_statusline()"
	end,
})
vim.api.nvim_create_autocmd({ 'WinLeave', 'BufLeave' }, {
	pattern = '*',
	desc = 'simplify statusline when leaving window',
	callback = function()
		vim.wo.statusline = ' %f  %=%p%%  %l:%c '
	end,
})

function _G.custom_statusline()
	return table.concat({
		'%m%r %f %=',
		'  ',
		_lsp_symbol_cache,
		'  ',
		'%l:%c  ',
	}, '')
end

vim.api.nvim_create_autocmd({
	'CursorHold',
	'WinScrolled',
	'BufWinEnter',
}, {
	pattern = { '*' },
	callback = function()
		if #vim.lsp.get_clients({ bufnr = 0, method = 'textDocument/documentSymbol' }) == 0 then
			_lsp_symbol_cache = ''
			-- NOTE: commenting out this redrawstatus call removes the flickering
			vim.cmd.redrawstatus()
			return
		end
		local params = { textDocument = vim.lsp.util.make_text_document_params() }
		vim.lsp.buf_request(0, 'textDocument/documentSymbol', params, function(err, result)
			if err then
				_lsp_symbol_cache = ''
				vim.schedule(function()
					vim.cmd.redrawstatus()
				end)
				return
			end
			if not result then
				_lsp_symbol_cache = ''
				vim.cmd.redrawstatus()
				return
			end
			local cursor_pos = vim.api.nvim_win_get_cursor(0)
			local cursor_line = cursor_pos[1] - 1 -- Convert to 0-based index
			local cursor_col = cursor_pos[2] -- 0 based

			---@type string[]
			local named_symbols = {}

			-- Recursively traverses symbols
			-- Gets the named nodes surrounding current cursor
			---@param symbols lsp.DocumentSymbol[]
			local function process_symbols(symbols)
				for _, symbol in ipairs(symbols) do
					local range = symbol.range or symbol.location.range
					if
						(
						range.start.line < cursor_line
						or (
						range.start.line == cursor_line
						and range.start.character <= cursor_col
						)
						)
						and (
						range['end'].line > cursor_line
						or (
						range['end'].line == cursor_line
						and range['end'].character >= cursor_col
						)
						)
						then
							table.insert(named_symbols, symbol.name)
							if symbol.children then
								process_symbols(symbol.children)
							end
							break
						end
					end
				end
				process_symbols(result)

				_lsp_symbol_cache = table.concat(named_symbols, '  ')
				vim.cmd.redrawstatus()
			end)
		end,
		desc = 'Update lsp symbols for status line',
	})

Thanks, I was able to narrow it down to:
vim.env.LAZY_STDPATH = '.repro'
load(vim.fn.system('curl -s https://raw.githubusercontent.com/folke/lazy.nvim/main/bootstrap.lua'))()

-- NOTE: plugins
require('lazy.minit').repro({
	spec = {
		{
			'saghen/blink.cmp',
			version = 'v0.*',
			build = 'cargo build --release',
			opts = {},
		},
	},
})

-- NOTE: make sure non current window is highlighted
vim.api.nvim_set_hl(0, 'NormalNC', { bg = 'red' })

vim.api.nvim_create_autocmd('BufWinEnter', {
	callback = function()
		-- NOTE: commenting out this redrawstatus call removes the flickering
		vim.cmd.redrawstatus()
	end,
})

on a file like
test
| (type `t` here and nothing else)

It seems likely that this is a neovim bug because blink.cmp doesn't make any calls to change the focused window. You could wrap your redrawstatus in vim.schedule for now


-GraphAPIToken parameter required

Need Graph API token parameter to connect multiple services like MSOnline, and AzureAD.

@officedocsbot assign @yogkumgit

Hi @tonyoscard, thank you for your feedback.
The Exchange Online PowerShell V2 module is currently in Preview. If you have any feedback, concerns, or are facing any issues with the EXO V2 module, contact us at exocmdletpreview[at]service[dot]microsoft[dot]com (email address intentionally obscured to help prevent spam).

@dariomws  Thank you very much for the contribution and sharing this explanation. @tonyoscard
Hope this comment is helpful for you. If you see a documentation update is required, please feel free to open an issue for the same. We proceed here to close it. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.


Removed array from test and added some code that needs cleaning to YO

Could do with writing some nice clean code for checking the arguments but for now this will do

@hiroshi-ota :-D