Fixed wrong api request url for instances running in subfolders

Fixes #5156

Should I directly send a backport?

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@4b84928). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #5247   +/-   ##
=========================================
  Coverage          ?   37.61%
=========================================
  Files             ?      310
  Lines             ?    46040
  Branches          ?        0
=========================================
  Hits              ?    17319
  Misses            ?    26242
  Partials          ?     2479

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b84928...9f130f0. Read the comment docs.

@kolaente once this has been merged please do the backport. Thanks 😄

@techknowlogick only to 1.6 or also 1.5? (Since 1.5 isn't released yet)

@kolaente just 1.6 please 😄

Backport is up:  #5261


quinn project

Hi, I saw another project about quic: https://github.com/djc/quinn. What is the reason for opening another project? Can these two projects be merged?

What is the reason for opening another project?

I wanted to implement QUIC.

Can these two projects be merged?

Why?


[FEATURE] Include more transitions to stateful testing

Now if there is a link, then it always all inputs for an endpoint's bundle come from this link. It cuts out cases when an error is caused by random input data. It was implemented so in the early prototypes then I forgot about this corner case

It doesn't seem to bring many benefits in my experiments :(  I also observed some slowdown in execution


OCPQE-26461 Add test job registry config for 4.15

Add test job registry config for 4.15

/cc @rioliu-rh

@rioliu-rh I am not sure whether _releases/ocp-4.15-test-jobs-multi.json file also needs some modification for nightly or not. If yes then what it should be?

@rioliu-rh I am not sure whether _releases/ocp-4.15-test-jobs-multi.json file also needs some modification for nightly or not. If yes then what it should be?

currently we don't have controller job to run test for multi release stream.

this PR depends on https://github.com/openshift/release/pull/58145

/lgtm
/approve


[Bug][Server] Task ststus did not change to SUBMITTED_SUCCESS where start process

**For better global communication, Please describe it in English. If you feel the description in English is not clear, then you can append description in Chinese(just for Mandarin(CN)), thx! **
Describe the bug
when start a process with more than 20 tasks,20 task in status RUNNING,but the others not change
the other task cannot be found in task instance as well
To Reproduce
Steps to reproduce the behavior, for example:

keep master.property master.exec.task.num=20
create a process which has more than 20 task without relation
start the process

Expected behavior
20 tasks in running,the others in submitted_success
Screenshots

Which version of Dolphin Scheduler:
-[1.3.4]
Additional context
Add any other context about the problem here.
Requirement or improvement

Please describe about your requirements or improvement suggestions.

It is normal. If there are more than 20 tasks, you need to wait for 20 to be executed successfully before submitting other tasks


Documentation for creating has_many associations

I'm sorry to have to revert to the issues list here, but I can't for the life of me find any documentation on creating has_many relationships in FG 2.0. After some experimentation I found the solution below, but I don't know if this is the "right" way to do it:
class Post < ActiveRecord::Base
  has_many :comments
end

class Comment < ActiveRecord::Base
  belongs_to :post
end

FactoryGirl.define do
  factory :comment do
    body 'This is a comment'
  end

  factory :post do
    title 'This is a Post'
    comments { FactoryGirl.create_list(:comment, 2) }
    # or, to create only one =>  comments { [FactoryGirl.create(:comment)] }
  end
end

Factory.create :post

One problem is that I won't know if you called build or create when you factoried (nice, right?) your post, but this will always create the comments. So I played with the syntax a bit to get association in there instead and came up with this:
  factory :post do
    title 'This is a Post'
    comments { [association(:comment)] }
  end

Is that the right way to do it? GETTING_STARTED has a great reference for just about everything you can do with FG except this one case. Thanks!

After talking about this with @jferris, it seems like the ideal syntax may be something like this:
FactoryGirl.define do
  factory :user, :aliases => [:author]

  factory :comment do
    author
    post

    factory :old_comment do
      created_at { 1.year.ago }
    end
  end

  factory :post do
    factory :commented_post do
      comments(2) # this would create two `:comment`s
      # alternatively...
      comments # this would create one `:comment`
      old_comments(2, :body => 'something static') # this would create two `:comment`s, both with body of 'something static'
      old_comments # this would create one `:old_comment`
    end
  end
end

I've added more documentation in this commit: https://github.com/thoughtbot/factory_girl/commit/9c6c252d0fb58ba6321d8db56778bb3469ff5a77
It includes tests (since they're a great form of documentation) but the primary example is in the GETTING_STARTED document.
While it's beneficial to discuss syntactical improvements and ways to make this more straightforward, I think that's better handled in a separate pull request when an implementation is started; for now, this focuses on documentation and this commit should handle that request.
Thanks everyone for their contribution to the discussion!


ISTIO mesh expansion in AWS

@devops083 commented on Tue Nov 27 2018
setupMeshEx.sh is for only GCP?
how to implement ISTIO mesh expansion in AWS?

Need to update annotation for each loadbalancer server at: https://github.com/istio/istio/blob/master/install/kubernetes/mesh-expansion.yaml
And for https://istio.io/docs/setup/kubernetes/mesh-expansion/#setting-up-the-machines
select run install/tools/setupMeshEx.sh machineSetup VM_NAME
But not sure if mesh expansion is still working or not.

/cc @incfly

@incfly is setupMeshEx.sh deprecated as of 1.1?

It's not officially deprecated. We need a few tweaks to make it work again. I recently get it working on master branch. I plan to update the doc with automation in 1.2 release, but if anyone is interested in getting 1.1.x release working, we probably can do it (assuming it fits release schedule although)
Re AWS, I haven't tried it on AWS, but I believe we just need to make istioCP command working instead of gcloud compute scp, maybe few other things.  I'm happy to provide some help if anyone is interested.

We just published a blog post about it: https://www.paxos.com/istio-mesh-expansion-on-aws/

@gumdelli thanks for the blog post.
Cheers
-steve

Nice callout to ‘iptables -t nat nVL’, @gumdelli


Recognizing flavor, version_comment

In this PR we read and analyze the flavor of the database: Oracle/Percona/MariaDB/MaxScale based on version_comment and other params.
This gets visualized in the web UI, so it's easy to distinguish between different flavors in a cluster.

This deploys well. Ideally I would have bootstrap-like icons for MySQL, Percona, MariaDB so that we can indicate the flavor in smaller space than now.


MINOR: expose commit interval config for SimpleBenchmark

Expose the streams commit interval config for different testing scenarios.

cc\ @guozhangwang @enothereska
I was using this for testing, thought it might be good to have exposed for other tests as well.

LGTM! Merged to trunk.


Update explode to handle lists

Based on this feedback here that we received:
https://github.com/microsoft/pylance-release/issues/3871
It looks like explode also takes a list.

[x] Closes https://github.com/microsoft/pylance-release/issues/3871
[ ] Tests added: Please use assert_type() to assert the type of any return value

Since str is included, why not Sequence[Hashable]

Since str is included, why not Sequence[Hashable]

Good idea, I'll switch it to that.


Change IP structure so that IPv4 addresses are stored in RFC3493 format

In addition to saving 4 bytes for each instantiation, this change makes IP-related operations faster and clearer.
https://tools.ietf.org/html/rfc3493.html#section-3.7

The change looks good. Did you benchmark, that it’s faster now?
PS: The CI Ubuntu build failed with
configure: error: No compatible LZ4 compression library found. Consider --disable-lz4
+ exit 1

CI fails, it is known, but harmless. I will fix this week.

The change looks good. Did you benchmark, that it’s faster now?

I actually didn't, but I wouldn't expect noticeable improvements in terms of throughput from this change alone.
However, there is definitely a lot of space for improvements.

Looks like the macOS CI build is not starting, I'm going to merge the PR anyway as I already know that it succeeds.


[Misc] Sagemaker example notebooks

What's on your mind?
The provided SageMaker example notebooks in SWB require s3 buckets with read and write permissions for users.
Some of our users will not be provisioned an s3 bucket, but we would still like them to be able to run these notebook examples with minimal revisions. Is there an "easy" workaround to using s3 buckets in all the notebooks?
Versions:

Release Version installed: 5.0.0

fyi @avillach @srpiatt

Hi @simranmakwana, thanks for bringing up this question! I may be missing some context here, but if I'm understanding correctly, would the "Sharing a Study" section of the Service Workbench User Guide answer your question? By default, the Sagemaker notebook doesn't have an S3 bucket attached to it. When you launch the notebook, if you don't attach a study to it, an S3 bucket won't be attached to the notebook either. Let me know if that helps!
Thanks,
Sukeerth

Hi Sukeerth,
Thanks for the quick response! Sorry for not providing enough context in my original post!
I do not want to attach an S3 bucket to the notebook/workspace, but I do want to run the example Sagemaker jupyter notebook analyses. I'm referring to the notebooks that are located in the SageMaker Examples tab (screenshot attached). Is this possible?

Let me know if this clarifies the request, or if you need any additional information.
Best,
Simran

Hi Simran!
Thanks for the additional information! We do not currently support using the example SageMaker notebooks in the SageMaker Examples page. These require more permissions than we allow from the SWB-created SageMaker notebook instances. If you wanted to make this possible, you would need to edit the code base, especially the sagemaker notebook role to allow the example notebooks to work properly. When I tried using one of the example notebooks, I got an access denied error because the example notebook tried to make an S3 bucket for the notebook. So, it might be a limitation on the SageMaker Notebook Example notebooks' side that require an S3 bucket anyway.
For SWB-created SageMaker Notebooks, you do not need to attach an S3 bucket though! You can create a workspace of type SageMaker Notebook without attaching a Study to it. This will allow your users to use the notebook without having a bucket provisioned.
Let me know if you have further questions,
Marianna


I cannot create wallet for android mobile from the seed of 12 words

I cannot create wallet for android mobile from the seed of 12 words.
The import in the windows PC is ok,  but in android the button to continue is not enabled after introducing the seed.
Regards

is it a bip39 seed?

It's a bip39 seed from Multibit wallet.

bip39 is not supported on android.


allow null(or None) in RichTextField

I needed to use null (or None) in RichTextField in my database. So I prepared a patch that solves this. I have prepared a simple test for this and I have also modified the example/blog to reflect this.

No problem, thank you for your cooperation @akalipetis. I am already preparing another PR ;).


if can provide some hook inject before function run or after

for example, when program start, need to initinal mysql. redis and other client, if exist some hook, we can log "[xxxx client] initialed"

@whybangbang can you explain if anything was implemented to provide the proposed hook?


Issue #140: Sort whitelisted domains by domain name

Sort whitelisted domains on whitelist.php by the full domain name (institution column).
This provides a predictable sort order, though it does not try to group scools, teasing apart top level domains from sub domains for example.
Fix issue #140

Looks good. Please update CHANGES.md and merge.


search for vulnerabilities pathfinder and connect nessus scanner

Hello )
Please tell me, when I run the pathfinder scanner to search for the vulnerability of my network, and set the "script": "nmap-vulners" parameter, then the pathfinder plugin gives an error, what is the problem?
And the second question is how can I connect a third-party scanner such as nessus to the pathfinder plugin?

Hello as well,
For your first question about the error you experience when trying to scan using the nmap-vulners script, can you copy the log message you get back in the output window and paste it here? That will give an idea what might be happening. There also was a recent issue that was happening because of a change in the way nmap expected script folders to be passed now requiring a trailing slash in the directory name, make sure you have pulled the latest repo to have that change.
As for the second question about adding a new scanner to pathfinder, there is documentation on creating a new scanner and parser in the docs folder that should walk you through all the steps to add them as a module in the plugin.  The scanner creation one is here:
https://github.com/center-for-threat-informed-defense/caldera_pathfinder/blob/master/docs/scanner_creation.md
for each scanner added you would also need to create a parser too, which is covered here:
https://github.com/center-for-threat-informed-defense/caldera_pathfinder/blob/master/docs/parser_creation.md
Let me know if you need any more assistance or have any trouble following the documentation and I can help get you on the right track.

@mrengstrom you are very kind, thanks :)
I will try to figure out how to connect the nessus scanner, this is a little difficult task for me.
Here is the error when I run patfinder with nmup-vulners:
scan initiated, depending on scope it may take a few minutes
scan ID:7acaee81-d94f-4975-9631-d104fcdfdb1f failed. error output: NSE: failed to initialize the script engine:
/usr/bin/../share/nmap/nse_main.lua:821: directory 'nmap-vulners' found, but will not match without '/'
stack traceback:
[C]: in function 'error'
/usr/bin/../share/nmap/nse_main.lua:821: in local 'get_chosen_scripts'
/usr/bin/../share/nmap/nse_main.lua:1312: in main chunk
[C]: in ?
QUITTING!
p.s. pathfinder installed according to the instructions, without making any changes

No problem and glad to help.
I have looked a little into the Nessus scanner integration and it is a bit more intensive to integrate than nmap, but they do have a API for scanning and exporting results, that would be the way I would look at integrating it if I were to try.
Also there are a few parsing libraries in python that could be imported to help build up a parser that would support the nessus xml report format if you just wanted to import an exported report and not initiate a scan from the UI.
As for your error log, it appears you are having the issue I mentioned that was a recent issue we addressed and pushed to master.  So, you may want to go and pull latest from master and try running the scan again as it should now handle the latest version of nmap.
Here was the PR resolving that issue, so you can check if your nmap scanner module has these code changes in it:
https://github.com/center-for-threat-informed-defense/caldera_pathfinder/pull/27


Error: TypeError: Cannot read properties of undefined (reading 'testsuite')

Workflow run: https://github.com/MirrorNetworking/Mirror/actions/runs/7330497702/job/19961702474
Workflow: https://github.com/MirrorNetworking/Mirror/blob/Test-CI-No-Merge/.github/workflows/RunUnityTests.yml
RunUnityTests is called from main.yml.
We are using upload-artifact@v3 in case that matters.
Make sure you're looking at the Test-CI-No-Merge branch.

There is one test that's intentionally made to fail in this branch.
There are nearly 1100 tests in the repo.

Advice appreciated.

possible duplicate of #218

Hi @MrGadget1024 , the test run nor the workflow file is available anymore.
Please, include the name of the reported you are using, the type of test framework and its output format and a sample file which causes the error.

From Dec 2023? Of course they're long gone. We moved on to another solution.


修复 dubbo callback解码version 为空值

Issues associated with this PR
Your PR should present related issues you want to solve.
Solutions
You should show your solutions about the issues in your PR, including the overall solutions, details and the changes. At this time, Chinese is allowed to describe these.
UT result
Unit Test is needed if the code is changed, your unit test should cover boundary cases, corner cases, and some exceptional cases. And you need to show the UT result.
Benchmark
If your code involves the processing of every request, you should give the Benchmark Result.
Code Style

Make sure Goimports has run
Show Golint result

Codecov Report

Merging #1033 into xprotocol_stable will increase coverage by 0.06%.
The diff coverage is 40.90%.

@@                 Coverage Diff                  @@
##           xprotocol_stable    #1033      +/-   ##
====================================================
+ Coverage             55.50%   55.56%   +0.06%
====================================================
  Files                   234      234
  Lines                 23863    23867       +4
====================================================
+ Hits                  13244    13261      +17
+ Misses                 9407     9387      -20
- Partials               1212     1219       +7

Impacted Files
Coverage Δ

...rotocol/rpc/xprotocol/dubbo/dubborpc_if_tracing.go
55.92% <40.90%> (+17.40%)
:arrow_up:

pkg/stream/stream.go
33.33% <0.00%> (-13.34%)
:arrow_down:

pkg/buffer/iobuffer.go
73.94% <0.00%> (-1.27%)
:arrow_down:

pkg/module/http2/transport.go
78.30% <0.00%> (-0.44%)
:arrow_down:

pkg/module/http2/server.go
81.70% <0.00%> (-0.08%)
:arrow_down:

pkg/log/logger.go
56.35% <0.00%> (+1.65%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1c8096...aa7db3f. Read the comment docs.


Failure to deploy, no Analyse artifact

Expected Behaviour
When using the Analyse module as recommend part of an AEM project a user should be able to deploy and release artifacts to a repository.
Actual Behaviour
The Analyse module does not generate any artifacts, therefore when performing a Maven release errors like below can occur.
[INFO] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-gpg-plugin:1.6:sign (sign-artifacts) on project aem-guides-wknd.analyse: The project artifact has not been assembled yet. Please do not invoke this goal before the lifecycle phase "package". -> [Help 1]

Similar modules like ui.frontend, dispatcher, ui.tests generate artifacts and thus do not have the same issue.
Potential fixes:

add an assembly.xml file to the analyse module similar to the dispatcher module to generate an artifact containing the output of the analyse process.
Or modify the generated project so that the analyse module is skipped when a release is performed...

@bosschaert I know you have been working closely with the analyse module...

I think executing the aemanalyzer-maven-plugin inside the 'all' module is much more in line with Maven. That way you have one main artifact to deploy per module and less overhead. This would also solve the issue with the maven-gpg-plugin

@kwin yes that makes sense to me. @bosschaert wdyt? Might be a change we make to the archetype? The Analyse module would still get run each time, but no module is needed and no need to generate an artifact

Sorry for the late reply, @godanny86 I was on PTO. Yes what you and @kwin are suggesting makes sense. I see that the PR is already merged, is this issue still open?

@bosschaert welcome back! Yes I created the pr in aem-guides-wknd to un-block some activities. Ideally we keep aem-guides-wknd and the project-archetype in sync. If you like the approach used in https://github.com/adobe/aem-guides-wknd/pull/230 I can raise a PR to this repo...

Hi @godanny86 yes that sounds good to me.

Closing this one as per consultation with @bosschaert and @cziegeler


DOM interaction

Does this library support DOM interaction? Ex. click events?

Hi @DanielSokil
No, it does not. Right now the support is really basic

Hi @DanielSokil
Are you still interested in hardware emulation? If so I would be curious to know a little more on your use case, I'm working on that.


LOD fixes

BoundingVolume::transform: without the expand calls the center and
the radius would not be recalculated
SceneObject::frustumCull: crude workaround to force lod check for
all children scene objects; disables optimization but only in case
any scene object uses lod

GearVRf-DCO-1.0-Signed-off-by: Mihail Marinov<EMAIL_ADDRESS>

Have not checked the other samples yet for side effects.

For whatever it is worth: org.gearvrf.tester.PickerTests#canPickWithFrustum passes with this change but not with master.
Two other tests fail no matter what:
org.gearvrf.tester.PickerTests#canPickObjectWithRay
org.gearvrf.tester.PickerTests#testPickObjects

:+1: LGTM

@NolaDonato Any thoughts?

Will merge Thursday morning if there are no further comments.


Add README or short descriptions to questionnaires

It would be good to have a README to get some information about the questionnaires

Maybe with #2


Image cropper is not working with PNG image format

I am uploading a png image and cropper is displaying images but cropping feature is not working. When I save this image to server in jpg format and reloading its again. Its started working.
For JPG images its working finr from start of uploading images
Can someone help me to fix issue with PNG images?

MY Bad. I was using a very small images with size of 50 px.


fix 400 error response when importing open sans font

The Google open sans font was imported with the wrong parameters, causing an error in any project importing LBH-frontend 3.0.0

:tada: This PR is included in version 3.1.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


need help to set macvlan on unraid

HI. thanks for your docker.
docker network create -d macvlan
--subnet=<IP_ADDRESS>/24
--gateway=<IP_ADDRESS>
--ip-range=<IP_ADDRESS>/28
-o parent=eth0 vlan
flow your "readme " so I input above in unraid. however, I got blew inform when I run docker
--device='/dev/kvm' 'kroese/virtual-dsm:latest'
dd8159f537f67d799a35f47a63bbf84334583d2595c9db8bf87328b59c14d714
docker: Error response from daemon: failed to create the macvlan port: device or resource busy.

thanks for rely. My verizon home router address is <IP_ADDRESS>. So my lan should be 192.168.1.x. also, is the lan interface located at unraid- setting- network seting ?

my interface is eth0. looks like I input cerrect thing. but not work
docker network create -d macvlan
--subnet=<IP_ADDRESS>/24
--gateway=<IP_ADDRESS>
--ip-range=<IP_ADDRESS>/28
-o parent=eth0 vlan

oh thanks. I still struggle with that. Even I follow the way how to set
macvlan in unpraid. I almost give up.
Kroese @.***> 于 2023年4月18日周二 下午8:27写道：

Maybe we can move the conversation to #54
https://github.com/kroese/virtual-dsm/issues/54 because it is exactly
the same problem as you have.
—
Reply to this email directly, view it on GitHub
https://github.com/kroese/virtual-dsm/issues/36#issuecomment-1513950543,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A5IDX3NKVS3LFMJYT24T3TLXB4WQPANCNFSM6AAAAAAW4OJCLU
.
You are receiving this because you authored the thread.Message ID:
@.***>


How to handle search in toolbar.

Hello,
I'm using the toolbar in react navigation,
I can't find anywhere how to handle on change of the search or how to get its value.
This is a sample of the code

<Toolbar
onLeftElementPress= { () => {navigation.state.params.hamburgerClick();}}
onRightElementPress={ () => {
navigation.state.params.optionsClick();
                }}

                leftElement="menu"
                centerElement="Dashboard"
                rightElement="add"
                searchable={{
                    autoFocus: true,
                    placeholder: 'Search',
                    icon:"add",
                }}
            />
        </View>
    </ThemeProvider>

i tried to add   onSearchTextChanged={(keyword) =>alert(keyword)} which i found somewhere but it didn't work
Help!

Where should I add the onChangeText ?
I tried it like that

<Toolbar
onLeftElementPress= { () => {navigation.state.params.hamburgerClick();}}
onRightElementPress={ () => {
navigation.state.params.optionsClick();
                }}
                onChangeText={(keyword) =>console.log("look here",keyword)}
                leftElement="menu"
                centerElement="Dashboard"
                rightElement="add"
                searchable={{
                    autoFocus: true,
                    placeholder: 'Search',
                    icon:"add",
                }}
            />
        </View>
    </ThemeProvider>

And didn't work!

Thank you for your help,
But still it's not working i tried console.log or a function that does something, the onSearchTextChange
isn't being triggered!

@xotahal Is this a component fault on your side?

@bernardakl  sorry for late replay because i am new in react native  but  i done toolbar search handler. this is sample of code that code

 this.searchFilterFunction(text)**
        }}

        onLeftElementPress={() => this.requestLocationPermission()}

      />
    </View>

i hope this will  help you and other developer


Pro micro, cant run argb strip

Hello, im using Arduino Pro Micro ATmega32U4 16Mhz blue board (clone). Argb fans work perfectly in both outputs, controling them true icue. Problem comes when i put argb strip, it wont power up, tried both outs and different examples(like neopixel etc etc). Tried same strip on arduino mega,work fine. Complete mistery to me. Any suggestion?

Hi, I don't understand, what do you mean with both outputs? Can you please make a picture or schematic of the wiring you are using to connect the argb strip and arduino.

Hi i mean output in terms of 2 connectors for ie argb fan and strip. Out = digital pin 2 and pin 3 on board.
Im using standard wiring, 470ohm resistor on D-pin and 1000uf cap on power. ARGB Fans work perfect on both pin 2/3. Strip no response, i checked with multimer, it gets 5v. Same wiring on arduino mega, same strip = working. I dont understand

What is the exact type of the led strip, you have to configure the type in FastLED.addLeds call, so it can control the led strip. Do you use an external power supply for the strip?

Its WS2811 strip , RGB+IC 14W 5V 60 led/meter.
So i tried to change WS2812b to WS2811 in default example:
FastLED.addLeds<WS2812b, DATA_PIN_CHANNEL_1, RGB>(ledsChannel1, 96);
FastLED.addLeds<WS2812b, DATA_PIN_CHANNEL_2, RGB>(ledsChannel2, 96);
Still not working. What else to try? Sorry im not that skilled in programing, just know some basics.

have you connected ground of the strip to the arduino and the external power (common ground)?

I did exacly like on image. All gnd (from 2 ARGB plugs) are wired to pro micro gnd , - on capacitor, gnd from PSU molex. +5v from molex goes to 2 ARGB plugs. Data pin 2 and 3 are connected to ARGB plugs via 470ohm. Mistery?

Have you tested the led strip hardware by using a simple FastLED test sketch to just test that the strip works?

I tried now with FastLED sketches, not working... i rly dont get. Strip is 100% good, everything else too. This pro micro clone is smelly to me, but then how argb fans are working normal :\ So weird.


Official home wanted

Originally, an official hyper header (name TBD) module crate was requested in hyperium/hyper#189, 4 years ago.
Speaking of cute/snarky crate names, consider either of the following pronunciations of hyperx:

/ˈhīpər ˈeks/
/hī ˈpərks/

I'd be happy to transfer/contribute this to the hyperium organization if the goals for such a crate are well aligned.

It's not very clear to me what the purpose of this crate is. Right now it can be used to port apps from hyper 0.11 to 0.12. It can stay like this, or it can become a strongly-typed layer for the headers in the http crate, which would mean dropping the Headers and related types, and probably changing how parsing and formatting work.
In the latter case, there would no longer be a connection to hyper.
Related projects it might be worth looking into: https://github.com/sfackler/typed-headers, https://github.com/pyfisch/httpdate.
Answering this will also answer #2.

@Inicola, I agree with your summary on the current and potential future purpose of this fork.
My goal was to fill an obvious hole in the upgrade story from hyper 0.11 to 0.12, quickly and with minimal effort. @sfackler, mentioned he was prototyping back in January, and its good to see that he has new commits there in the last week.
Judging from commits, the hyper developers put a fair amount of work into the correctness of the typed-header parsing and serialization, which is preserved here, along with some legacy baggage given that it predates the http crate.  If it was easy enough to remove and replace the latter while keeping the robustness of the former, it would be worth continuing here.  That at least one of the hyper contributor's thinks a rewrite is more compelling, is definitely worth noting however.
Other then the hyperx crate name, there is no direct connection or dependency on hyper (master) as of now (and in either case).

I think @seanmonstar might be willing to pick this one up: https://github.com/hyperium/headers/ (it's a little better than this repository in that it has a proper history of the code, without the extra files).
If you're fine with that, I suggest starting by cherry-picking some commits from your repository, then cleaning up the old code a little (e.g. by dropping Headers). How do you feel about this plan?

Regarding the git history, @lnicola , I assume you mean in this new hyperium/headers publishing (which I haven't yet looked at in any details) the same or similar code has had git filter-branch or similar applied such that only historic commits pertaining to headers are included, in an albeit mutated form.  Your use of better, is therefore subjective. With hyperx, the providence and changes are quite clear, as from the CHANGELOG.md here:

Forked from hyper 0.11.27, extracting the typed header module
from hyperium/hyper@76fdbcf2, 0.11.x branch, preserved here as
76fdbcf2.

Where as, that will not be very easy to determine after filter-branch replaces all the commits in a fashion similar to a total rebase.
Beyond that minor point, I don't follow what you are suggesting in terms of moving forward.  Could you clarify?   Assuming there is common interest and this isn't being done better by these other projects, I would think hyperx::header::Headers would get deprecated first, and only after some better integration is found with http::HeaderMap?  @sfackler's typed-headers (your link above) seems to include some good ideas on how to do that integration, but I also haven't spent much time/thought on it.

Your use of better, is therefore subjective.

Fair enough. I meant that it can be a new crate (similar in spirit to http, hopefully used by a larger part of the ecosystem) whose provenance is less important, and which doesn't try to keep any semblance of compatibility with hyper 0.11.

I don't follow what you are suggesting in terms of moving forward.

Apply some of the hyperx commits to the new headers repository -- it seemed fair to ask here since you've authored them.
Move forward with the clean-ups and API changes (the http port) in the headers crate.
Keep hyperx as-is or deprecate it, depending on your preference, and continue the development in the headers repository.

I agree that typed-headers seems cleaner, but it still seems a bit allocation-heavy and is less complete, so maybe starting from the old hyper code isn't such a bad idea.

hyperx has been published on crates.io as a "new crate", but you must mean something else.  :)
I've kept the same licensing terms as the orginal hyper, so you can certainly re-purpose anything you find useful here with my work (consent granted), and with their consent, other contributors work.  But given observed behavior with the associated projects, I'm not seeing your 3rd party suggestions here as a terribly encouraging invitation to spend more time trying to contribute new work to hyperium(/headers). I hope you can understand that!
Also the emphasis on ASAP removal of hyperx::header::Headers, and of course the original removal of the header module for 0.12 in the first place,  suggest a different mindset and less emphasis on providing a painless upgrade path for existing users of the header module.

Also the emphasis on ASAP removal of hyperx::header::Headers,  and of course the original removal of the header module for 0.12 in the  first place,  suggest a different mindset and less emphasis on  providing a painless upgrade path for existing users of the header  module.

Indeed, I don't think there are any plans to keep full compatibility with the hyper 0.11 users. It's a new crate that happens to start from older code.
About the "ASAP removal" of Headers (and I was talking above about headers::Headers, not hyperx::header::Headers), it was just my idea. I'm not really affiliated with hyper or any other project. I only posted here to let you and other readers know about the new crate, in case they want to use and/or contribute to it in the future.
And sorry if this came out as offensive in any way, it wasn't intended.

Thanks much for that, and no offense assumed or taken.


Introduce code to list all alerts of a user that happened in a specific timeframe

Acceptance Criteria:
$ pd list-alerts --from 2020-10-16T07:00:00.0Z --to 2020-10-16T15:00:00.0Z
FOOBAR Pod failed to start in Production 2020-10-16T07:05:00.0Z

Feature added in this commit: 801f26b69f54c2f6865136696e2ada0393e3358b


About Fre's scheduler

Fre's scheduler is discussed here.
First I implemented a prototype scheduler here, but I found that react gave a better implement two days ago.
linked list vs min heap
There is a sorted queue, which we can implement using linked list or array.
React is implemented with a min heap in v16.10, which makes it standard and faster.
I think linked list is better for fre now, but heap is the best for sorted queue.
I need to reassess whether to use the min heap
Any ideas here? @mindplay-dk @yiliang114

completed！


Error while trying to withdraw

Clicked on a payment link on WhatsApp
Got directed to the dashboard - withdraw pop up open (Background was not blurred or brightened) (See 1.jpg)
the spinner is continually spinning and I can't press X or do anything else. I just got stuck.
Closed wallet and reopened it.  withdraw pop up opened again (Background WAS blurred or brightened)
After a sec, an error message pop up opened. Message error was on top of the withdraw pop up, and not at the same size (as every other pop up) - See 2.jpg
after another reopening of the wallet - Receive card is shown, but without an amount. balance is updated correctly. (See 3.jpg)

Possible issues

popup should not be stuck, try to figure out what conditions may cause it to get stuck
popups should not be on top of each other, how is that possible? arent all popups use same component?
what can cause an error popup to open on top of withdraw popup during the withdraw? are we closing processing popup if error occurs?
popups should have min height: designrelative(height,false)
Definition of Done

[ ] withdraw popup should not be stuck
[ ] processing popup should be closed on error
[ ] popups should have same height

@LiavGut @sirpy I have tested this issue on good dev and ewallet. The issue is reproducing for ewallet. And reproduces for gooddev, but after I clean the cache - receive start working as expected for gooddev. As I know the beta branches are deployed to ewallet server. Maybe we should merge the latest master to beta and deploy changes.
So after deployment, we can check if everything is ok.

@yaroslav-fedyshyn-nordwhale i believe this is related to the network issue.
there's an issue that withdrawing doesnt work correctly when returning to wallet via payment link after a while.
in any case the tasks are the same, if there's some kind of error

it shouldnt get stuck.
popups should not be on top of each other
in case we receive TX from blockchain event, amount should be read from there.

@yaroslav-fedyshyn-nordwhale
and the pop up should have a blurred and brightened background.

@yaroslav-fedyshyn-nordwhale
and the pop up should have a blurred and brightened background.

yes, when I tested, the background was the same as for other popups (blurred) on gooddev.

@sirpy
I tested this problem locally on the master and beta branches, the problem is not reproduced.
Please redeploy the ewallet

also, the height problem already fixed in another task. you should merge master to beta and deploy


multi-stage docker builds, base image updates and gh-actions

Use multi-stage builds for creating images.
Updated used build images.
Use GitHub Action to build and publish container images for multiple platforms.

when will the open PRs get merged?


Easier to read lookup table for encoding using UInt8(ascii: "A")

As proposed in by @weissi in https://github.com/apple/swift-nio/issues/1322
replacing the encode lookup table with uses of UInt8(ascii: “A”) instead of 65
for better to read code.

Codecov Report

Merging #4 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master       #4   +/-   ##
=======================================
  Coverage   97.67%   97.67%
=======================================
  Files           4        4
  Lines         258      258
=======================================
  Hits          252      252
  Misses          6        6

Flag
Coverage Δ

#base64
97.67% <ø> (ø)
:arrow_up:

#unittests
97.67% <ø> (ø)
:arrow_up:

Impacted Files
Coverage Δ

Sources/Base64/Base64.swift
97.66% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55892e5...183d89c. Read the comment docs.


finalize Authorea post

https://www.authorea.com/users/152698/articles/186842-valence-quantifying-gcms-data


Nuget packages with multiple assemblies are referencing only first .dll

If nuget packages referenced by linqpad script contains multiple assemblies, only first assembly is included in script reference section.
To reproduce:

Create new linqpad script
Add reference to Microsoft.Composition
lpless it

To observe:

Compilation output contains only 1 reference.
The lib folder of the package contains 5 dlls.

C:\Dev\Linqpad\Queries\linqpadless-issue-20.linq
  <Query Kind="Statements">
    <NuGetReference>Microsoft.Composition</NuGetReference>
  </Query>
  Packages referenced (1):
    Microsoft.Composition
  Packages directory: C:\Dev\Linqpad\Queries\packages
  Packages target: .NETFramework,Version=v4.6.2
  Querying latest version of Microsoft.Composition
    [INF]   GET https://api.nuget.org/v3/registration1-gz/microsoft.composition/index.json
    [INF]   GET https://api.nuget.org/v3/registration1-gz/microsoft.composition/index.json
    [INF]   OK https://api.nuget.org/v3/registration1-gz/microsoft.composition/index.json 651ms
    [INF]   OK https://api.nuget.org/v3/registration1-gz/microsoft.composition/index.json 651ms
    Using version 1.0.30
  Resolving references...
    Microsoft.Composition 1.0.30
  Resolved references (1):
    packages\Microsoft.Composition.1.0.30\lib\portable-net45+win8+wp8+wpa81\System.Composition.AttributedModel.dll

After applying 185713c37eede26c91881d6a0d0524c6e31fff8b, lpless correctly picks up 5 references for .NET Framework 4.6.2 from Microsoft.Composition 1.0.30 instead of just 1:
I:\LINQPad\Queries\LinqPadless-Issue-20.linq
  <Query Kind="Statements">
    <NuGetReference>Microsoft.Composition</NuGetReference>
    <Namespace>System.Composition</Namespace>
  </Query>
  Packages referenced (1):
    Microsoft.Composition
  Packages directory: I:\LINQPad\Queries\packages
  Packages target: .NETFramework,Version=v4.6.2
  Querying latest version of Microsoft.Composition
    [INF]   GET https://api.nuget.org/v3/registration1-gz/microsoft.composition/index.json
    [INF]   GET https://api.nuget.org/v3/registration1-gz/microsoft.composition/index.json
    [INF]   OK https://api.nuget.org/v3/registration1-gz/microsoft.composition/index.json 612ms
    [INF]   OK https://api.nuget.org/v3/registration1-gz/microsoft.composition/index.json 618ms
    [INF]   GET https://www.myget.org/F/raboof/api/v2/FindPackagesById()?id='Microsoft.Composition'
    [INF]   OK https://www.myget.org/F/raboof/api/v2/FindPackagesById()?id='Microsoft.Composition' 1134ms
    Using version 1.0.30
  Resolving references...
    Microsoft.Composition 1.0.30
  Resolved references (5):
    packages\Microsoft.Composition.1.0.30\lib\portable-net45+win8+wp8+wpa81\System.Composition.AttributedModel.dll
    packages\Microsoft.Composition.1.0.30\lib\portable-net45+win8+wp8+wpa81\System.Composition.Convention.dll
    packages\Microsoft.Composition.1.0.30\lib\portable-net45+win8+wp8+wpa81\System.Composition.Hosting.dll
    packages\Microsoft.Composition.1.0.30\lib\portable-net45+win8+wp8+wpa81\System.Composition.Runtime.dll
    packages\Microsoft.Composition.1.0.30\lib\portable-net45+win8+wp8+wpa81\System.Composition.TypedParts.dll

Thanks for reporting this.


Automated cherry pick of #11873

Cherry pick of #11873 on release-7.7.
/cc  @pvev
NONE

Will try to auto merge this PR once all tests and checks are passing. This might take up to an hour.

Trying to auto merge this PR.

Pull Request successfully merged
SHA: ab40a5753d74d0883e21979c4bcbcbb0d4977602


drvload loading keyboard drivers is not support laptop 2

Includes the laptop2 and 3 models, but its driver conflicts cannot be fully imported, and the drvload load driver is planned, but the drive for the laptop2 is found to be unsupported.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6b195b1b-81bf-310e-3ff4-e520826e7e94
Version Independent ID: fb399be5-9fb5-a3f9-f912-ed3fde235f05
Content: How to enable the Surface Laptop keyboard during MDT deployment (Surface) - Surface
Content Source: devices/surface/enable-surface-keyboard-for-windows-pe-deployment.md
Product: w10
Technology: windows
GitHub Login: @Teresa-Motiv
Microsoft Alias: v-tea

@officedocsbot assign @jvsam

Hi @goxia, thank you for bringing this to our attention. To clarify, are you saying that you cannot install the Surface Laptop 2 Drivers and Firmware update successfully? And you are using Windows 10 since it's a requirement, right? We would love to help you with your concern, however, this GitHub-based documentation feedback system is intended to help improve the quality of the technical documentation of Microsoft Docs. What we recommend is to open a service/support ticket in your tenant to report this issue. There are also other support resources that you can explore like the Microsoft Tech Community or the Technet forums where you can collaborate and discuss this issue with the community.  Thank you.
IMPORTANT: Surface update history for your reference. See Download drivers and firmware for Surface, as well.

Hi @jvsam , What I want to mean is that I want to be able to support both laptop2 and 3 keyboards in the Windows PE, but in fact their drivers can't be added to a single Windows PE at the same time.

Thank you for clarifying. Unfortunately, I do not have access to any Surface device, so it would be helpful if you could confirm if you are looking for this issue to be resolved in the software, or if you think this issue needs to be documented in the article, or both.
Regardless, I think this should be commented on by the document author @Teresa-Motiv or the contributor @CoveMiner .

@illfated , Thanks a lot.
This requirement can be prevalent in the enterprise, and if you can include it in the article, it will help users understand and avoid problems in advance.

Sounds like a good idea to add a note regarding this issue in the document. I am thinking something similar to the following text:

[!NOTE]
It is currently not supported to add Surface Laptop 2 and Surface Laptop 3 keyboard drivers in the same Windows PE boot instance due to driver conflict.

Feel free to suggest a different phrasing if the one above can be misunderstood or is open to different interpretations. If you also have a good suggestion for a good place in the article to place this note, that would be very helpful too. Thanks in advance. 👍

@illfated , Thanks. I think this has been very helpful to users, hope that the future can have a perfect solution.

Looks like the note was added to the topic, so closing this issue.


Error with truehd

When I add truehd to my list of audio codecs, I get the following error:
Could not write header for output file #0 (incorrect codec parameters ?): Invalid argument

Here is the full command:
/usr/bin/ffmpeg -i /path/to/sample.mkv -vcodec libx264 -map 0:0 -c:a:0 aac -map 0:1 -disposition:a:0 default -ac:a:0 2 -b:a:0 256k -metadata:s:a:0 language=eng -strict experimental -c:a:1 copy -map 0:1 -metadata:s:a:1 language=eng -disposition:a:1 none -f mp4 -threads auto -y /path/to/sample.m4v

And here is what the relevant section of autoProcess.ini looks like:
audio-codec = ac3,aac,eac3,dts,truehd

.mp4 containers do not support truehd audio streams, unfortunately. I'm in the process of making a pull request to 'fix' this by either forcing encoding of truehd to aac or spitting out a warning for people. I'll probably just add an option.

Opened pull request to resolve this - https://github.com/mdhiggins/sickbeard_mp4_automator/pull/816
Skipping the truehd stream seems to be the best option, as the next stream is always the AC3 core.  I've tried converting truehd --> aac/ac3/etc and the end result has issues with video/audio sync seemingly 50% of the time, so it's not reliable.

This is great, thanks Alex!


adding renv to R dep management tools list

I'd recommend including renv in the list of R dependency management tools as it's a great alternative to packrat.

Thank you. Very important addition.


The trainer is always walking to next fort

I am not clear the algorithm of the new version, from the log I noticed the trainer is always walking from one fort to another one,  he does not catch too often, do not use other balls except normal balls.
Anyone here has a good configuration to avoid this?
I miss the old version as it only contains two mode:  farm and catch. it was really efficient.

the only thing i could suggest is maybe do what im about to do and link it up to a pokemon go map? Where it knows the location of pokemon and catches them

Same here... Just going from a pokestop to the other and keep walking without finding any pokemon. Last dev branch has something wrong

I have same issue

As there have been many updates since this issue was posted, I'm assuming this issue has been resolved. If I'm wrong, please reopen.


Question: What http workers do ?

In this example:
<?php
Adapterman::init();

$http_worker = new Worker('http://localhost:8080');
$http_worker->count = cpu_count();
$http_worker->name = env('APP_NAME');

...

Can someone explain why we have to create mutiple http workers? I'm new to this idea. If the event loop (async) needs several http workers to manage parallel incoming requests, how is it different from php-fpm? Why it can't use a single thread like node ?

Creating multiple processes can fully utilize the CPU, while using only one process can only utilize one CPU.


Is The Blockquote Error?

I had writing > test but become > test without blockquote. Why?

I noticed the same error.

Me too!!

use $('#content').text() to get text works for me.

I'm getting the same thing!

This issue should be closed.  Since that's the issue is from the user not the lib itself.
Check the data string first to see if it > rather than />.  If your input is from server, it is possible to get />+ instead.  In that case, just replace your string using .replace(/>+/g, '>') before put it into marked().


How to use batteryml command line tool in Windows?

Download the raw data and run the two commands used in the preprocessing script:
I type in the Command Prompt and it says 'batteryml' is not recognized as an internal or external command, operable program or batch file.
Entering in Windows PowerShell executes successfully but without any action and result. Just skipped it.
What is the problem?

We did not test our tool in Windows. The command batteryml is installed by Python using the setup.py. Can you provide more information of how you install the package and your Python environment?

Hello, where do you enter the command specifically? I entered it in CMD in Windows.

You should use windows powershell and use batteryml instead of BatteryML. The command line is case-sensitive.

大小写是一样的效果，都没有起任何作用，路径也已经添加到系统变量中

Same problem here. Working on Windows 10. I have found the batteryml file in the bin folder as well as in my python environment folder. I have tried using both Paths but none worked. Any solution?

This error indicates the script batteryml is not found. I will test on Windows 10. Please stay tuned.

After some investigation, I made this work under Windows. The cause was the setup.py. We initially depended on the shebang line, e.g. #!/usr/bin/python, in bin/batteryml to work in Linux. Under Windows, pip cannot determine the correct entry point for this script. I got two solutions to this issue.

(Quick) Use bash under windows. For example, if you installed git, there may be a Git Bash, which you may find in your option menu after right click.
I will create a PR later to fully address this issue. The key is to use entry_points in setup.py.

#23 should address this issue.

Close this as #23 is merged. Feel free to reopen this if any further problems encountered.


disk full, cannot register on demo app

I visit http://trybootcamp.vitorfs.com/ and try to register.  I get error that indicates out of space.

I think than @vitorfs is able to work something around this. Perhaps to add some kind of backend than drops the database regularly?

Aw, I didn't see that one coming
I will free some space there

we are back online! sorry for the delay


Make worker node optional

Purpose
We've recently added Celery as a project dependency, and it's currently compulsory to run a worker in order to execute privacy requests. This PR makes that optional, by providing an option to run the worker on the same node as the webserver as a subprocess.
Changes

Moves worker definition into docker-compose.worker.yml
Adds USE_DEDICATED_WORKER config var
If USE_DEDICATED_WORKER is False -> run fidesops worker as a subprocess on webserver startup

Effect

Running docker compose up will bring up the webserver, and run fidesops worker as a subprocess on that container
Running docker compose -f docker-compose.yml -f docker-compose.worker.yml will force USE_DEDICATED_WORKER to True and bring up the worker container separately

Checklist

[x] Update CHANGELOG.md file

[x] Merge in main so the most recent CHANGELOG.md file is being appended to
[x] Add description within the Unreleased section in an appropriate category. Add a new category from the list at the top of the file if the needed one isn't already there.
[x] Add a link to this PR at the end of the description with the PR number as the text. example: #1

[x] Applicable documentation updated (guides, quickstart, postman collections, tutorial, fidesdemo, database diagram.
If docs updated (select one):

[ ] documentation complete, or draft/outline provided (tag docs-team to complete/review on this branch)
[ ] documentation issue created (tag docs-team to complete issue separately)

[ ] Good unit test/integration test coverage
[ ] This PR contains a DB migration. If checked, the reviewer should confirm with the author that the down_revision correctly references the previous migration before merging
[ ] The Run Unsafe PR Checks label has been applied, and checks have passed, if this PR touches any external services

Ticket
Fixes #769

Doing some thinking about workflow here, a user would need to both set FIDESOPS__EXECUTION__WORKER_ENABLED=True and use the make server-and-worker command, if they wished to run Celery on a separate worker.
This is fine for now, but I'd like to be able to detect the FIDESOPS__EXECUTION__WORKER_ENABLED from make server, so that the user experience is simpler.
We talked briefly about passing the env var around in Makefile, but I'm unsure if we specifically addressed the following: We could do something similar to how we call run_infrastructure.py for other Make commands, and pass in our WORKER_ENABLED env variable. What do you think? Should we create a ticket for this?

We talked briefly about passing the env var around in Makefile, but I'm unsure if we specifically addressed the following: We could do something similar to how we call run_infrastructure.py for other Make commands, and pass in our WORKER_ENABLED env variable. If enabled, we can then bring up docker-compose and docker-compose.worker. What do you think? Should we create a ticket for this?

I think they're two separate concerns. It's good for us to be able to spin up workers as and when we need to work with them locally, but it doesn't need to be part of the default setup as long as we can guarantee the same code is being run and it's only the paradigm that changes. Ideally I'd like to see if this does get in our way first and then address via the current change management avenues (retros etc).

@seanpreston sounds good to me, let's make sure we at least explain steps needed in the docs issue- https://github.com/ethyca/fidesops/issues/755


Pubsub resource names

Regenerate PubSub with generated resource name types

LGTM once Travis passes

Coverage decreased (-0.02%) to 84.208% when pulling e29787bc42810a214f8fa9a4e02434b95ffd2d91 on michaelbausor:pubsub-resource-names into 164878e2ac8c4ad0aaa9704b4da287358d92be4c on GoogleCloudPlatform:master.


[Bug] Reset view button doesn't reset the W/L

Describe the Bug
Reset view reset all image manipulation except W/L.
Steps to Reproduce

Open https://viewer.ohif.org/viewer?StudyInstanceUIDs=2.25.232704420736447710317909004159492840763
Click on MPR button
Do some image manipulation
Change the W/L
Click on the reset view button

The current behavior
everything is reset except W/L
The expected behavior
all image manipulation are reset
OS
Windows 10
Node version
16
Browser
Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36

https://github.com/cornerstonejs/cornerstone3D/pull/821


test framework: separate method for skippable test-level cleanup

Overriding the *testing.T's Cleanup as well as adding our own CleanupOrFail
WhenDone will not be skipped by --istio.test.nocleanup. ctx.Cleanup or ctx.CleanupOrFail should be used for cleanup that can be safely skipped without affecting other tests.
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[X] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Pull Request Attributes
Please check any characteristics that apply to this pull request.
[X] Does not have any changes that may affect Istio users.

@stevenctl: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
bce23bba800901a04e8f0e988f6fb4b315564c6f
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-k8s-tests_istio
f78060df3083d8a2454cb13b1fea0c55b93c0fb3
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest


Merge 'ThreeMammals:develop' into 'develop'

Let's update your repo with latest top-commits from head repository.
That will allow to perform rebase-operation for feature branches without merge-commits.
Please use Rebase and merge option.

@Ugway77 Алексей,
Don't forget to Sync fork please? So, develop branch will be updated with top commits!
This operation is technically the same as merging this PR with Rebase option.
It seems you have some new business logic in develop branch. But merging head repo develop will be very helpful to contribute in future.

You don't care. I see...


Create a constant lens.

Following on from https://xi.zulipchat.com/#narrow/stream/147926-druid/topic/druid-chatter/near/217758048, here is a PR to add a lens and constructor for it that always return the same value and discard changes. It's useful for when you have a widget that is usually dynamic, but sometimes can be static.
Comments welcome!

An alternative would be to get rid of the free function and make the value inside the lens pub.

Edit: I made it use a struct like the other lenses.

funny, I've been thinking about something similar lately.
My version of this is a "mixin lens", that converts A -> AB by adding some state. My vision of this, though, is that it isn't exactly a lens, but a special widget; the widget stores some state, B, and some pair of methods to do A -> AB and AB -> B, and then the dream (this is actually tricky, because commands are not generic) is that you can send this widget commands that will modify its internal state.
So... maybe my version doesn't make too much sense, right now.
In any case, it feels like this is sort of highlighting a larger problem, which is related to my work with errors, where the assumption that widgets are all displaying data from the global app model just doesn't really make sense.
I think the 'correct' solution to this will involve some real architectural thinking. I'm not opposed to having a lens like this in the meantime; it reminds me a lot of the work on 'scopes', and this is just a minimal, static scope?

I agree with all you say. I think there is a place for this lens - I think it feels intuitive.


"invalid byte sequence for encoding "UTF8": 0x00" when using ldap

Expected Behavior
Users/Groups pulled from LDAP are persisted.
Actual Behavior
I'm using LdapOrgEntityProvider to pull users and groups from ActiveDirectory.
Looks like data is pulled correctly, because I can see log entries like:
Read 458 LDAP users and 67 LDAP groups in 1.2 seconds. Committing...

I tried to narrow down search filter, to make sure rnd and name are always filled, but that doesn't seem to help.
ldap:
      providers:
        - target: <REDACTED>
          bind:
            dn: <REDACTED>
            secret: <REDACTED>
          users:
            dn: OU=Staff,<REDACTED>
            options:
              filter: (&(employeeID=*)(department=Engineering))
            map:
              rnd: employeeID
              name: employeeID
              email: mail
              description: title
          groups:
            dn: OU=Departments,<REDACTED>
            options:
              filter: (cn=Engineering*)
            map:
              rnd: objectSid
              displayName: cn
              email: mail
              name: objectSid
              members: member

Your Environment
Env created from latest state of main branch.

Thanks for quick response @freben.
I'll try your filtering suggestion!
Regarding objectSid, I'm not sure about it's type, but this was the only attribute in my AD setup that was unique, and was inline with regex that entity name has to comply to. In my case cn has spaces, which backstage does not like, nor is capable of stripping them.

You CAN supply custom mapping functions to do what you want actually (how to form the entity based on the bag of attributes).
https://github.com/backstage/backstage/blob/master/plugins/catalog-backend-module-ldap/src/processors/LdapOrgEntityProvider.ts#L86
You can also change the validation rules of the catalog if you wish, to allow spaces in names. But either way, you want especially metadata.name to be something very humanly understandable, something you can type out by hand, something you understand what it refers to by quick inspection, something to proudly display front and center in the Backstage interface :)

I found those transformers... but I have hard times wrapping my head around this... I'm not a TS guy:P
Either way, I was able to pull users, groups are still failing, most likely because of that objectSid.
And I guess I'll have to make sure that name on user matches members on group... which again will be difficult, because members in AD are of type CN, with spaces and so on...
LDAP is fun...

It turned out that modifying attribute does work :)


Unable to load AWS credentials

AWS credential create failed : Unable to load AWS credentials: please make sure the deployer defined AWS_ACCESS_KEY_ID and AWS_SECRET_ACCESS_KEY
[ec2-user@ip-172-31-10-174 cloudbreak]$ sudo /usr/local/bin/cbd start
[WARN] docker-compose.yml already exists, BUT generate would create a DIFFERENT one!
[WARN] if you want to regenerate, remove it first:
  cbd regenerate

[WARN] expected change:
101,102c101,102
<         - AWS_ACCESS_KEY_ID=AK***********************
<         - AWS_SECRET_ACCESS_KEY=T4X*****************
---
>         - AWS_ACCESS_KEY_ID=
>         - AWS_SECRET_ACCESS_KEY=

[ec2-user@ip-172-31-10-174 cloudbreak]$ sudo /usr/local/bin/cbd doctor
===> Deployer doctor: Checks your environment, and reports a diagnose.
local version:1.0.1
latest release:1.0.1
docker command: OK
docker client version: OK
/tmp/bashenv.135702591: line 1585: [: -lt: unary operator expected
docker server version: OK
[WARN] docker-compose.yml already exists, BUT generate would create a DIFFERENT one!
[WARN] if you want to regenerate, remove it first:
  cbd regenerate
[WARN] expected change:
101,102c101,102
<         - AWS_ACCESS_KEY_ID=AK***********************
<         - AWS_SECRET_ACCESS_KEY=T4*********************************
---
>         - AWS_ACCESS_KEY_ID=
>         - AWS_SECRET_ACCESS_KEY=
144c144
<     image: sequenceiq/cloudbreak:1.0.1
---
>     image: sequenceiq/cloudbreak:1.0.0

I think
https://github.com/sequenceiq/cloudbreak-deployer/blob/master/include/cloudbreak.bash#L132
is causing the problem.

If you read carefully the output, it says, you have to regenerate the yam files:
cbd regenerate

you already have a docker-compose.yml  cbd start did recognized that you changed something in your Profile which would generate a new docker-compose.yml, it even shows what the difference would be.
But cbd start will not automatically overwrite your docker-compose.yml, you have to tell it explicitly.
So pleas run cbd regenerate

@lalyos Thank you very much.

you are welcome,
btw i face this issue a lot of times. that the tool writes a warning, and users ignore them.
i'm not sure it automatic overwrite would be acceptable, but could resolve these issues.
maybe an automatic overwrite with backing up the yaml-s?
btw: i commented out your aws credentials from the comments, but please consider to generate new once ...

@lalyos I think if we make the message more clear like.. a "running cbd regenerate is needed before you can start successfully" will be more helpful.
As a user I missed it because it said a cbd generate will create a new one but not that I really need to go for that, that's its a requirement and not just some FYI kind of stuff should be made clear.
Yeah. I just notices my blunder on AWS keys. Thanks for that!


Restoring from checkpoint failed and user_emb接口结果获取为空

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.叔宝 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Segfault on startup (Linux version)

The current GPMDP version (v4.5.1) crashes when I launch it on my Fedora 29. According to multiple bug reports related to other Electron-based apps, this is due to this issue
Could you please update to Electron 2.0.8 in order to fix it ?

This is fixed in master...
https://github.com/MarshallOfSound/Google-Play-Music-Desktop-Player-UNOFFICIAL-/blob/master/package.json#L65

@MarshallOfSound
Hey, has the RPM been rebuilt on the main site yet? Otherwise, I'll compile. Just thought to ask.
Thanks!

@equilibrialthoughts it has not. see https://github.com/MarshallOfSound/Google-Play-Music-Desktop-Player-UNOFFICIAL-/issues/3391 for how you can grab the latest build of master off of circle.


Less secure tmpfile()

The documentation for tmpfile() states that it is deprecated and that a more secure version is tmpfile_s().
Is tmpfile_s() actually more secure, and if so, how? I think this needs explaining or changing in the documentation, because there's no obvious improvement to security, and it seems that it should be possible to implement tmpfile() in a safe manner.
I'm thinking of developers who will likely see this and be forced to change it out of an abundance of caution and as an act of diligence even though I suspect the only reason it's deprecated is because there's an _s variant, which was added just for consistent error reporting with the other _s functions, rather than to patch a security hole.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 414314a8-bd8d-99fc-1f6c-5df80b3cc1e3
Version Independent ID: ee91da15-7833-1638-7745-a0d8ee2329b0
Content: tmpfile
Content Source: docs/c-runtime-library/reference/tmpfile.md
Product: visual-cpp
Technology: cpp-ucrt
GitHub Login: @TylerMSFT
Microsoft Alias: twhitney

tmpfile_s is part of the safe-code practice extensions that are in at least ISO C11.  I agree it is not obvious what the edge case is, if any.  However, consistency is not entirely a bad thing, although tmpfile_s and the rest do feel a bit clumsier.  I agree these are not all about threat surface, many are about code safety.
This form does encourage always checking the return value, without having to go an extra step to check for a NULL pointer return.  Now the extra step is separate declaration of the FILE* to be set :).


Jest 20: mapCoverage

Issue

With mapCoverage set to true, I seem to get this:

in the reports with:

when I drill into the file.
If I disable mapCoverage everything seems to work as expected regarding the coverage, but the mapping is shifted.

Expected behavior

No file:// links

Can you create a minimal repo that reproduces this?

not yet, it seems to have something to do with:
  "modulePaths": ["<rootDir>/src"],

Before Jest 20 I was able to just have:
  "roots": ["<rootDir>/src"],

but after upgrading everything that had a relative import import x from 'bla/foo'; seemed to fail:
  ● Test suite failed to run

    Cannot find module 'base/serialization' from 'fixtures_proto.ts'

      at Resolver.resolveModule (node_modules/jest-resolve/build/index.js:172:17)
      at Object.<anonymous> (src/base/serialization/tests/fixtures/fixtures_proto.ts:5:25)

where it worked with Jest 19, so I changed roots to modulePaths, e.g. now I have:
  "modulePaths": ["<rootDir>/src"],

adding roots additionally doesn't seem to change anything.

This shows the problem: https://github.com/joscha/jest-20 - I haven't found out where exactly it blows up.

When I remove "extends": "./tsconfig.json" it seems to generate the coverage properly, I am just not able to say why.

I just ran:
git clone https://github.com/joscha/jest-20
cd jest-20
yarn install
yarn test

and got these results:
yarn test v0.23.4
$ rm -rf ./target/coverage
$ jest  --config jestconfig.json --ci --coverage --no-cache
 PASS  src/other/__tests__/index.ts
  ✓ should work (4ms)

Test Suites: 1 passed, 1 total
Tests:       1 passed, 1 total
Snapshots:   0 total
Time:        2.373s
Ran all test suites.
  console.log src/base/bla/index.ts:3
    hello

=============================== Coverage summary ===============================
Statements   : 100% ( 4/4 )
Branches     : 100% ( 0/0 )
Functions    : 100% ( 1/1 )
Lines        : 100% ( 2/2 )
================================================================================
Done in 9.24s.

have a look at the HTML report please in target/coverage/lcov/report.
I actually think "outDir": "target", is the problem.

when I remove
    "outDir": "target",

from tsconfig.json in the sample repo, then

becomes:

are we doing anything special with outDir in ts-jest?

We're not doing anything explicitly but it appears that having this value set is causing problems during testing.
There are two ways this can be fixed - by deleting outDir from the config during testing (hardcoded in ts-jest) or by setting its value to null in the tsconfig that testing uses (this works but gives a type warning in the editor).
I'm leaning towards the former as I don't see any need for outDir during testing. I think this can safely be hardcoded. What do you think?

I have set it to null for now, but I think removing it automatically would make sense. There is no output except coverage during a test run anyway, so it should be safe. Maybe add a comment to README to hint at it. Do you want me to create a PR for this?

Sure, that'd be great!

add delete config.outDir; here with a comment stating why and add a link to this issue.
change the version in package.json to 20.0.1

Thanks :)

PR is here: #202

Unfortunately, this is still not fixed due to #3524

@joscha https://github.com/facebook/jest/issues/3524#issuecomment-300556549

@thymikee does this mean we can use instrument as a proxy for collectCoverage?

Yes


[NEW CONTENT TYPE REQUEST] Pascal

What type of file would you like magika to detect?
Pascal (.pas)
What software can create/open these files?
Many IDEs, Any text editor.
Where can these files be found?
https://github.com/search?q=language%3APascal &type=repositories
If possible, please provide a specification for this file type.
Additional context

Closing, see #152 for context. Thanks!


Adding Brazilian Portugese to localization footer causes ValueError?

https://hosted.weblate.org/projects/pypa/warehouse/#translations says that we're now at 100% translated for Brazilian Portugese. Therefore, let's insert the footer of available locales/translations per #6624, and add Brazilian Portugese.
@yeraydiazdiaz @nlhkabu can either of you do this? Thanks.

I tried editing warehouse/i18n/__init__.py and warehouse/templates/base.html to include Brazilian Portugese:
diff --git a/warehouse/i18n/__init__.py b/warehouse/i18n/__init__.py
index 198a33ec..1304ba9f 100644
--- a/warehouse/i18n/__init__.py
+++ b/warehouse/i18n/__init__.py
@@ -14,7 +14,8 @@ from babel.core import Locale
 from pyramid.i18n import TranslationStringFactory, default_locale_negotiator
 from pyramid.threadlocal import get_current_request

-KNOWN_LOCALES = {"en": "English"}
+KNOWN_LOCALES = {"en": "English",
+                 "br-pt": "Brazilian Portugese"}

 LOCALE_ATTR = "_LOCALE_"

diff --git a/warehouse/templates/base.html b/warehouse/templates/base.html
index a46d25c8..80ad7b16 100644
--- a/warehouse/templates/base.html
+++ b/warehouse/templates/base.html
@@ -327,8 +327,7 @@

-
-    {% if KNOWN_LOCALES|length > 1 %}
+

       <form action="{{ request.route_path('locale') }}">

@@ -340,7 +339,7 @@

       </form>

-    {% endif %}
+

     {% include "warehouse:templates/includes/sponsors.html" %}

and got this stack trace:
Traceback (most recent call last):
  File "/opt/warehouse/lib/python3.7/site-packages/pyramid_debugtoolbar/panels/performance.py", line 58, in resource_timer_handler
    result = handler(request)
  File "/opt/warehouse/src/warehouse/raven.py", line 40, in raven_tween
    return handler(request)
  File "/opt/warehouse/lib/python3.7/site-packages/pyramid_tm/__init__.py", line 171, in tm_tween
    reraise(*exc_info)
  File "/opt/warehouse/lib/python3.7/site-packages/pyramid_tm/compat.py", line 36, in reraise
    raise value
  File "/opt/warehouse/lib/python3.7/site-packages/pyramid_tm/__init__.py", line 136, in tm_tween
    response = handler(request)
  File "/opt/warehouse/lib/python3.7/site-packages/pyramid/tweens.py", line 43, in excview_tween
    response = _error_handler(request, exc)
  File "/opt/warehouse/lib/python3.7/site-packages/pyramid/tweens.py", line 17, in _error_handler
    reraise(*exc_info)
  File "/opt/warehouse/lib/python3.7/site-packages/pyramid/compat.py", line 179, in reraise
    raise value
  File "/opt/warehouse/lib/python3.7/site-packages/pyramid/tweens.py", line 41, in excview_tween
    response = handler(request)
  File "/opt/warehouse/src/warehouse/cache/http.py", line 74, in conditional_http_tween
    response = handler(request)
  File "/opt/warehouse/src/warehouse/sanity.py", line 76, in sanity_tween_egress
    return unicode_redirects(handler(request))
  File "/opt/warehouse/lib/python3.7/site-packages/pyramid/router.py", line 148, in handle_request
    registry, request, context, context_iface, view_name
  File "/opt/warehouse/lib/python3.7/site-packages/pyramid/view.py", line 667, in _call_view
    response = view_callable(context, request)
  File "/opt/warehouse/src/warehouse/sessions.py", line 329, in wrapped
    return view(context, request)
  File "/opt/warehouse/src/warehouse/csrf.py", line 38, in wrapped
    return view(context, request)
  File "/opt/warehouse/lib/python3.7/site-packages/pyramid/viewderivers.py", line 514, in csrf_view
    return view(context, request)
  File "/opt/warehouse/src/warehouse/cache/origin/__init__.py", line 86, in wrapped
    return view(context, request)
  File "/opt/warehouse/src/warehouse/metrics/views.py", line 34, in wrapper_view
    return view(context, request)
  File "/opt/warehouse/lib/python3.7/site-packages/pyramid/viewderivers.py", line 460, in rendered_view
    request, result, view_inst, context
  File "/opt/warehouse/lib/python3.7/site-packages/pyramid/renderers.py", line 451, in render_view
    return self.render_to_response(response, system, request=request)
  File "/opt/warehouse/lib/python3.7/site-packages/pyramid/renderers.py", line 474, in render_to_response
    result = self.render(value, system_values, request=request)
  File "/opt/warehouse/lib/python3.7/site-packages/pyramid/renderers.py", line 470, in render
    result = renderer(value, system_values)
  File "/opt/warehouse/lib/python3.7/site-packages/pyramid_jinja2/__init__.py", line 265, in __call__
    return template.render(system)
  File "/opt/warehouse/lib/python3.7/site-packages/jinja2/asyncsupport.py", line 76, in render
    return original_render(self, *args, **kwargs)
  File "/opt/warehouse/lib/python3.7/site-packages/jinja2/environment.py", line 1008, in render
    return self.environment.handle_exception(exc_info, True)
  File "/opt/warehouse/lib/python3.7/site-packages/jinja2/environment.py", line 780, in handle_exception
    reraise(exc_type, exc_value, tb)
  File "/opt/warehouse/lib/python3.7/site-packages/jinja2/_compat.py", line 37, in reraise
    raise value.with_traceback(tb)
  File "/opt/warehouse/src/warehouse/templates/index.html", line 25, in top-level template code

{{ release.summary }}

  File "/opt/warehouse/src/warehouse/templates/base.html", line 144, in top-level template code
    {% block body %}
  File "/opt/warehouse/src/warehouse/templates/base.html", line 246, in block "body"
    {% block content %}
  File "/opt/warehouse/src/warehouse/templates/index.html", line 67, in block "content"

{% trans num_projects=num_projects|format_number %}{{ num_projects }} projects{% endtrans %}

  File "/opt/warehouse/src/warehouse/i18n/filters.py", line 45, in format_number
    locale = request.locale
  File "/opt/warehouse/lib/python3.7/site-packages/pyramid/decorator.py", line 43, in __get__
    val = self.wrapped(inst)
  File "/opt/warehouse/lib/python3.7/site-packages/pyramid/util.py", line 81, in <lambda>
    fn = lambda this: callable(this)
  File "/opt/warehouse/src/warehouse/i18n/__init__.py", line 48, in _locale
    return Locale.parse(request.locale_name, sep="_")
  File "/opt/warehouse/lib/python3.7/site-packages/babel/core.py", line 268, in parse
    parts = parse_locale(identifier, sep=sep)
  File "/opt/warehouse/lib/python3.7/site-packages/babel/core.py", line 1094, in parse_locale
    raise ValueError('expected only letters, got %r' % lang)
ValueError: expected only letters, got 'br-pt'

I think the right locale is pt_BR.

I think the right locale is pt_BR.

Yep, this is correct -- Babel's default locale format is cc_lc where cc is the country code and lc is the language code.

I tried
KNOWN_LOCALES = {"en": "English",
                 "pt_BR": "Brazilian Portugese"}

and got the same ValueError. @woodruffw diagnosed that I might need to clear my cookies because of a _LOCALE_ cookie issue. I used a different browser to visit localhost and did not get the error -- now I see the language chooser (INSTEAD of the sponsor footer). There is no Portugese content when I choose Portugese, probably because we haven't merged any of the new translations yet (they are in #6667).

@woodruffw You were able to find a way to fix this on Thursday night?

You were able to find a way to fix this on Thursday night?

Yep, the commits I made to #6747 should fix this.


Add posterFormat prop to <YouTube>

Add posterFormat prop to <YouTube> to allow selecting between jpg and webp posters

Not all videos have webp posters

Not all videos have webp posters

Ahhh, I didn’t know that! Maybe we should revert the change that switched to webp in that case? I wonder if there’s a reliable way to get the available images? If so, we could only use webp when available, but if not, I think it’s probably better to stick to the format that is reliably available by default.

I wonder if there’s a reliable way to get the available images?

Not without a fetch I don't think (e.g. to the YouTube API to get the list of thumbnails)
I have added a commit that reverts the default to jpg and allows selecting webp via posterFormat="webp"


Add monitoring rule: UseConstantForMetricAnnotation

@rultor merge

@rultor merge

@dgroup Done! FYI, the full log is here (took me 3min)


Add Loadify

Added Loadify iOS App to the open source list. Loadify is an iOS App that will download YouTube videos and save it to the gallery

Thx!


xdebug host config for windows/mac

We should add the following lines to our xdebug.ini:
xdebug.remote_host=host.docker.internal
xdebug.remote_port=9000
xdebug.idekey=VSCODE

This appears to have no impact on xdebug for ubuntu 16.04 (as expected, given the changes).
Alternatively, this can be added to the README for mac/windows users:
DOCKER_PHP_COMMAND="docker-php-ext-enable xdebug && echo 'xdebug.remote_host=host.docker.internal' >> /usr/local/etc/php/conf.d/xdebug.ini && echo 'xdebug.remote_port=9000' >> /usr/local/etc/php/conf.d/xdebug.ini && echo 'xdebug.idekey=VSCODE' >> /usr/local/etc/php/conf.d/xdebug.ini && "

Can we please add those lines on README? Was looking for this for ages. 😅

PR here: https://github.com/symbiote/docker-project/pull/38

That has since been merged, so closing this :smile:


Restrict branch creation

Feature Description
I had the same question that someone asked for GitHub here:

I was wondering if there is anyway to restrict the branch creation in GitHub Gitea. I have 4-5 branches created for a repo and would like to maintain it that way.

The idea is that developers work in their own repositories and merge into the main repository and branch through pull requests. Without the option of accidentally or willingly creating new branches in the main repository.
The answer given is that as of May 2022 GitHub has a branch protection setting named Restrict pushes that create matching branches. Adding a rule * will prevent the creation of any new branch.
It would be awesome if Gitea could support the same.
Screenshots

Duplicate of #2529

I saw issue #2529 but thought it was a different suggestion.
My understanding was that with the implementation of #2529 newly created branches automatically fall under branch protection if matching the wildcard once created. I now assume that pull request #20825 can also be used to prevent pushes that would create branches matching the wildcard. That will be great!

yes you could use * to protect all branches once wildcard branch protection is implemented


chore: classify broken proof was porting notes

Classifies by adding issue number #11039 to porting notes claiming:

broken proof was

@jcommelin Done!

Thanks :tada:
bors merge


Issues related to ClientRequest and 3xx redirection

I’ve discovered various glitches related to client redirection and ClientRequest.

When doing a redirect, the same HTTP method will always be used for the new request; e.g., if a POST request returns a “Location” header, a POST request will be done to the new location. This is correct behavior when the response HTTP status code is 307 Temporary Redirect or 308 Permanent Redirect, and is correct inasmuch as the specifics of this are undefined for 301 Moved Permanently and 302 Found, but not correct for 308 Permanent Redirect 303 See Other, for which the second request must explicitly be a GET request.
Due to a < being used where a <= is needed, there is an off-by-one error in the code that counts whether the client has redirected more than maxRedirects times, such that the effective limit is actually maxRedirects minus one - setting maxRedirects to 1 will cause no redirects to be followed, just as with setting it to 0.
If a “Location” header is present, ClientRequest.prepareForRedirect() is called, even if the maxRedirects limit has been hit and we’re not really going to do a redirect. As prepareForRedirect() wipes out the response data buffer, there’s no way to “read” the response to examine, for example, its response body or its headers. A particular use case where this might be desirable is to see if a route handler is returning a “Location” header in the first place.

Description

This PR adds code to detect and properly handle the 308 303 case, and to correct the above-mentioned bugs.
Motivation and Context

I discovered these issues while trying to write a test for Kitura route handler that takes a user's POST data, creates a page with it, then redirects the user to the page's URL. My test failed because the content of the page after redirecting was an error page rather than what was expected, and it was because the client was doing a POST request to the path in the Location header when it should have been doing a GET one. Later experimentation and debugging surfaced the other issues.
How Has This Been Tested?

The PR includes a new test case which checks various redirection-related behavior.
Checklist:

[x] I have submitted a CLA form
[x] If applicable, I have updated the documentation accordingly.
[x] If applicable, I have added tests to cover my changes.

Thanks for this!

When doing a redirect, the same HTTP method will always be used for the new request; e.g., if a POST request returns a “Location” header, a POST request will be done to the new location. This is correct behavior when the response HTTP status code is 307 Temporary Redirect or 308 Permanent Redirect, and is correct inasmuch as the specifics of this are undefined for 301 Moved Permanently and 302 Found, but not correct for 308 Permanent Redirect, for which the second request must explicitly be a GET request.

Can you point me at a spec which says that the request following 308 Permanent Redirect must be a GET? I looked at https://tools.ietf.org/html/rfc7238 but this says "it does not allow changing the request method from POST to GET".

(Sorry for the slow reply; not sure how I missed this.)
Sorry, I got my lines crossed in the OP. The status code I meant to say to force a GET request was 303 See Other.

@djones6 could you check over this too please?

Oops. Pushed the typo fix.

Oops. Just pushed the typo fix.

Thanks @NocturnalSolutions 👍


I am a Java developer interested in contributing.

Hi guys, I didn't see a better place documented to ask this so hopefully this is the right location.
I am a Java developer with 15 years experience who is looking for an OSS project to contribute to and this one looked interesting.  Are you currently looking for developer contributors?
My primary skill set also includes Oracle, Perl and Linux.  I am also proficient in JavaScript, JSON, XML, AJAX, HTML, CSS, Node and Python.
Thanks and please let me know.

@rluble explained to me in email how contributing to this project is similar to other OSS projects so I am closing this:
"Like many open source projects, j2cl is open to contributions and there is no formal process to become a contributor (see https://github.com/google/j2cl/blob/master/CONTRIBUTING.md). To contribute you can find an open issue and submit a fix. If you have specific ideas you can start an issue to discuss them."


fix: Add code_verifier into token request

Shopify added an extra check for /token request.
If you're seeing {"error":"","error_description":"code_verifier is invalid."} error, you have to include code_verifier field into the request

there's still a problem with
message: 'State cookie was missing.'
do you have it?

@AlexTroitsky try deleting all (or at least nextauth-related) cookies in your nextjs-app + clear all cookies on the shopify side and try again


automatically added to python module search path

When running the script scripts/pretrain.sh directly, a ModuleNotFoundError: No module named 'llava' may occur. Implement automatic configuration of the Python search path to include the necessary directory.
related issue:
https://github.com/haotian-liu/LLaVA/issues/1571

Thank you for your response. Have you resolved the issue? How to automatically add to python module search path?
I still have the issue: "ModuleNotFoundError: No module named 'llava'"
Thank you very much!

Thank you for your response. Have you resolved the issue? How to automatically add to python module search path? I still have the issue: "ModuleNotFoundError: No module named 'llava'"
Thank you very much!

Hi! Have you solved this issue? I face this same situation. Thank you very much!


Nix package PR is open

Hey, I wanted to let you know that I opened https://github.com/NixOS/nixpkgs/pull/356310 to make scooter available as a package for nix.
@thomasschafer If you add installation instructions for other package managers, you could mention nix there once the PR is merged. Maybe similar to how it's done for dua-cli:
Installation
...
NixOS
Nix-shell (temporary)
nix-shell -p scooter

NixOS configuration
  environment.systemPackages = [
    pkgs.scooter
  ];

Thank you so much @felixzieger! Let me know when it's merged and I'll update the readme here (or feel free to open a PR if you fancy it 😃)


API endpoint for current and historical prices of FA1.2 and FA2 tokens

Hi I I would like to add my "idea" for an API endpoint for tezos token prices.
So for FA2 and FA1.2 tokens there is no endpoint to get historical price or "live" price.
The API endpoint should allow to query tokens using the contract address which is unique to a given token.
Knowing the contract address for youves uUSD
KT1XRPEPXbZK25r3Htzp2o1x7xdMMmfocKNW
I should be able to query with Tzstats and get the current prices
Now the question some might ask is "But there are more decentralised exchanges so there are different prices, how to do that?"
A very good example is how coingecko does it. They have a separate object for every exchange they gather/track the data.
I dont say Tzstats api should track every dex. But for example the top 2-3?
then you would have something like this:
{
Quipu:{
"base": "uUSD",
"target": "XTZ",
"lastprice": 1,
"volume": "157824452",
"bid_ask_spread_percentage": "0.2",
"timestamp": "2022-04-27T21:10:16+00:00",
"last_trade_at": "2022-04-26T21:10:16+00:00",
"trade_url": "quipuswap dot com/pair"
}
Spicy:{
"base": "uUSD",
"target": "XTZ",
"lastprice": 1,
"volume": "157824452",
"bid_ask_spread_percentage": "0.2",
"timestamp": "2022-04-27T21:10:16+00:00",
"last_trade_at": "2022-04-26T21:10:16+00:00",
"trade_url": "spicyswap dot com/pair"
}
}```
Then people can easily get the data and build on top of it.
Since a year people are hoping for coingecko, cmc api but lets dont wait and integrate this for Tzstats. 🙂
My example screenshot is taken from this example here.
https://api.coingecko.com/api/v3/coins/ethereum/contract/0x0d8775f648430679a709e98d2b0cb6250d2887ef
The screenshot

I saw your discussion on the baking bad repo. Its a great feature idea, but expensive to implement and somewhat expensive to host that data. Quick bizdev question before we engage any further, how much would you be willing to pay for such a feature, say as monthly subscription.

I assume that the hurdles you mention - expensive to implement and somewhat expensive to host - are the reason why there is no possibility to track token prices in tezos defi and thus no real tools built on top of it.
I am currently building a product myself and stumbled accross this "problem", thats why I did propose it. I would be more than willing to pay for such a feature on a monthly subscription and I am sure many more other projects/services would be too as thats a real lacking piece in the ecosystem. When it comes to the price to be honest I dont know what a fair price would be so hard for me to throw in random amounts. I dont know €50 as monthly fee? I suppose it depends on the number of calls or the amount of data I can query from the API and if its a commercial license too so please take this a a big guess. With a short explainer about the pricing it can be more too.

Is there any update on this? @echa Maybe make a survey to gather interest if you are not convinced about this feature

This will be available when our token indexer is done. Probably a private/paid subscription though and not part of tzindex.

Sure private/paid feature sounds great, looking forward to an announcement!

This is available as private beta right now. Please send me an email if you're still interested.


React 17: export 'useInsertionEffect' (imported as 'e') was not found

When running yarn start on my project I get the following error.  I have checked and all preconditions in my package.json are fullfilled.
 I cannot really reproduce this bug. Can you show the implementation of your table? Maybe I can narrow it down to a specific feature.

Hi @rwieruch thanks for your quick reply.  It happens at the time of yarn start  (just for info, we are using Gatsby).  So the error is in<EMAIL_ADDRESS>9:10466-10486.
The funny think, is that when I use yarn build and deploy on Tomcat, there are no problems in the application or the table, however during build it lists the problems with error / warning, but builds successfully.  Unfortunetely when I use yarn start, the development applicaton simple does not start due to theses errors.
Just for testing purposes I updated to react 18.1.0 und react-dom 18.1.0 and then everything works fine.  We are considering simply to updating to react 18.1.0 to fix this problem. :-).
So, no stress on this problem, but maybe might be helpful why this is happening for other users.

The React version is useful, thanks! There have been many problems with this major update, so maybe I can fix it from within the library. Thanks again for all the information!

Will close this for now, because this is an issue for older React versions.


Extracting ByteString tag and value from CBORObject?

Ok, first of all your lib is great so thank you for that!
I'm very new to cbor, and trying to figure out how to decode some data.
Based of some python implementation which might be irrelevant:
tag, crc32 = cbor.loads(s)
s = tag.value
assert binascii.crc32(s) == crc32, 'crc32 checksum don\'t match.'
return cls(*cbor.loads(s))

I'm trying to do the same with your CBOR lib
I have some input data as bytes:
82d818584283581ce6c6f5f8275a769f4e2ce9fadbddc50f350ce3f32a552b48e9f98875a101581e581cca3e553c9c63c582084f2c432080796b930659ece479af1ac72a1e98001a681a9d13
  var cbor = CBORObject.DecodeFromBytes(bytes);
  // i.e.
  // {[24(h'83581CE6C6F5F8275A769F4E2CE9FADBDDC50F350CE3F32A552B48E9F98875A101581E581CCA3E553C9C63C582084F2C432080796B930659ECE479AF1AC72A1E9800'),<PHONE_NUMBER>]}
  if (cbor.Count == 2)
  {
    CBORObject[] cborArray = cbor.Values.ToArray();
    if (cborArray[1].Type == CBORType.Number) // the checksum crc32
    {
       var crc32 = cborArray[1].AsUInt32();  // Number:<PHONE_NUMBER>
       CBORObject cborByteStringWithTag = cborArray[0]; // ByteString: {24(h'83581CE6C6F5F8275A769F4E2CE9FADBDDC50F350CE3F32A552B48E9F98875A101581E581CCA3E553C9C63C582084F2C432080796B930659ECE479AF1AC72A1E9800')}
        // How to extract the tag and the '8358...' hex  string?
    }
  }

How do I handle the cborByteStringWithTag? trying to access the Values property throws an exception.
The Only way I see it can be done right now is to manually parse the {24(h'8358...')}  myself.
Am I missing anything? Thanks!

OK, it looks like:
byte[] byteString = cborByteStringWithTag.GetByteString();
Returns the correct value.


beeg broken

youtube-dl -v "https://beeg.com/1039870776"
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: [u'-v', u'https://beeg.com/1039870776']
[debug] Encodings: locale UTF-8, fs UTF-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2021.06.06
[debug] Python version 2.7.12 (CPython) - Linux-4.4.0-161-generic-x86_64-with-Ubuntu-16.04-xenial
[debug] exe versions: none
[debug] Proxy map: {}
[Beeg]<PHONE_NUMBER>: Downloading webpage
[Beeg]<PHONE_NUMBER>: Downloading JSON metadata
WARNING: [Beeg]<PHONE_NUMBER>: Failed to parse JSON No JSON object could be decoded
[Beeg]<PHONE_NUMBER>: Downloading JSON metadata
ERROR:<PHONE_NUMBER>: Failed to parse JSON  (caused by ValueError('No JSON object could be decoded',)); please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Traceback (most recent call last):
File "/usr/local/bin/youtube-dl/youtube_dl/extractor/common.py", line 906, in _parse_json
return json.loads(json_string)
File "/usr/lib/python2.7/json/init.py", line 339, in loads
return _default_decoder.decode(s)
File "/usr/lib/python2.7/json/decoder.py", line 364, in decode
obj, end = self.raw_decode(s, idx=_w(s, 0).end())
File "/usr/lib/python2.7/json/decoder.py", line 382, in raw_decode
raise ValueError("No JSON object could be decoded")
ValueError: No JSON object could be decoded
Traceback (most recent call last):
File "/usr/local/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 815, in wrapper
return func(self, *args, **kwargs)
File "/usr/local/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 836, in __extract_info
ie_result = ie.extract(url)
File "/usr/local/bin/youtube-dl/youtube_dl/extractor/common.py", line 534, in extract
ie_result = self._real_extract(url)
File "/usr/local/bin/youtube-dl/youtube_dl/extractor/beeg.py", line 74, in _real_extract
fatal=api_path == 'api.', query=query)
File "/usr/local/bin/youtube-dl/youtube_dl/extractor/common.py", line 899, in _download_json
expected_status=expected_status)
File "/usr/local/bin/youtube-dl/youtube_dl/extractor/common.py", line 883, in _download_json_handle
fatal=fatal), urlh
File "/usr/local/bin/youtube-dl/youtube_dl/extractor/common.py", line 910, in _parse_json
raise ExtractorError(errmsg, cause=ve)
ExtractorError:<PHONE_NUMBER>: Failed to parse JSON  (caused by ValueError('No JSON object could be decoded',)); please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.

Open the link in the browser.

This particular video is missing.
However there are clips from most of the video could be assembled listed in JSON at 'https://store.externulls.com/facts/file/%0.11d' % video_id. The clip URLs have the path from the resources of each of the fc_facts, prefixed by https://video.beeg.com.
When a video is present, full video URLs can be found in the resources of the file object in the JSON.
Possibly the site has changed its API, as a similar video that does exist is not found by yt-dl, with a log like OP's.


ALL CAPS TITLES SHOULD BE AVOIDED

https://petition.parliament.uk/petitions/104372
They're ugly and draw attention to petitions that might not warrant it
suggest:

automated (but non blocking) warning when user creates petition with high percentage caps
automated (but non blocking) warning when admin OKs petition with high percentage caps

We're working with the moderators to prevent these kinds of titles, so they'll be fixing them prior to publication (in consultation with the petition creator).