lsquic has different action between gquic and iquic if set conn idle timeout 0

We set http_server with prog_settings->es_idle_to = 0 and prog_settings->es_idle_conn_to = 0,  and then call http_client to send Q043 and h3-27 request to it.
Result：
Q043: Server destroy connection imediately after handshake completed.
h3-27: Server take client transport param idle timeout 30000ms, and send right response to http_client.
Does this expected? Or there are some bug? Thanks.

The Google QUIC connection code (Q043) does not interpret the "zero idle timeout" in any way and times out immediately; the IETF QUIC connection code interprets the "zero" as "idle timeout is not set".  The former should do a better job.


Functional analysis of (meta)proteomics datasets

A next step for Unipept is adding support for a functional analysis next to the existing taxonomic analysis. While the problem sounds similar to the taxonomic one, there are a few problems:

Available data: each UniProt entry has an associated taxon, but the same isn't true for functional annotations. Only 12% has an annotation with an EC number, GO terms are present for 60% of the entries.
UniProt proteins are associated with a single taxon, but can have multiple functions and thus multiple GO terms (2.8 terms per entry on average). These could be aggregated on a UniProt level or on a peptide level. The quality of the annotations is sometimes also disappointing.
We can't use the LCA algorithm of the taxonomy. GO exists out of 3 disjunct parts which are directed acyclic graphs whereas the taxonomy is a tree. This means that a node can have multiple parents. Aggregation must thus be done differently.

Finally, the question of "what is the expected output of a functional analysis" remains. Many articles pick a type of functional annotation and simply include a pie chart. If you ask a biologist if he learned something from the pie chart, the answer is almost always "no". We should be able to do better than that. Suggestions or good examples of such data visualisations are always welcome.

@bmesuere and Felix Van der Jeugt - we generally use MEGAN6 for functional analysis. However, the limiting step for MEGAN6 analysis is the BLAST-P search step and relative expertise needed to perform MEGAN6 analysis. I think it is essential to have an independent tool that generates similar (if not identical outputs).
I think the ability to perform functional analysis using the UniPept infrastructure would be great. Here are some examples (manuscript / links) that will help us define requirements.
a) Can the tool allow functional analysis using InterPro2GO, eggNOG or SEED?
b) Can the tool allow for pathway analysis using KEGG or iPath (http://letunic.com/publications/18276143.pdf)
One good example, for the kind of outputs expected is: http://biotechnologyforbiofuels.biomedcentral.com/articles/10.1186/s13068-016-0572-4
Going from simple to complex - a) Bar diagram b) Pie chart (both misleading since proteins are distributed across various functional categories) c) KEGG pathway representation and d) Principal component analyses based on biologcal processes. I think starting from simple to more complex would be a good idea.
This is an important tool in this hackathon and will have an immediate use / demonstration at the ABRF 2017 workshop that Tim, Jj and myself are planning to conduct (https://conf.abrf.org/the-galaxy-platform)
@alessandrotanca, @ Prof Rudney, Carolin Kolmeder, Tim Griffin  might want to add on what features would be required for this tool.

@PratikDJagtap @bmesuere
Concerning the type of functional annotation, we noticed that KO, eggNOG, InterPro, and UniProt protein families provide complementary information (in several cases a sequence is annotated using a database but not with the other, and for another sequences is the vice versa). As I wrote yesterday, the optimum would be a tool enabling merging of outputs from several databases to maximize functional annotation yield.
Concerning visual representation of the outputs, I completely agree with you about uselessness and ambiguity of pie charts. A quite good representation of abundance and dispersion can be provided by boxplots (e.g. using BoxPlotR, http://boxplot.bio.ed.ac.uk/).
For complex metabolic visualization KEGG pathway maps are really useful in my experience, but the free functions available on the KEGG website do not allow export of high resolution images or svg files (or you have alternative ways to download them?). I also agree on the great usefulness of function-based PCA and heatmaps for visualization of differential results.
I'm also really happy with cladograms, that can be generated using a tool available on the Huttenhower's lab Galaxy website (GraPhlAn, https://huttenhower.sph.harvard.edu/galaxy/).
...and we are also open to newer and more clever solutions for data visualization!

I agree with Allesandro that the best strategy is to compare results obtained from different ontologies, which can be done in MEGAN. The key issue in adding the same capabilities to Unipept will be keeping up with changes to the databases. BLAST-nr changed dramatically in September (no more GI numbers) and MEGAN has already released several updates of its ontology mapping files for InterPro2Go and and eggNOG since then since then. The problem with any online tool is going to be keeping it updated regularly so the results don't become obsolete. Another challenge with all ontologies is that there any many proteins which are assigned to multiple functional groups. This can cause considerable bias in display methods such as pie charts.

In the past I have been trying COG, eggNOG and KEGG for functional annotation of proteins from proteins derived from human faecal samples. Out of the three eggNOG performed the best.

My experience in MEGAN has been that the performance of different ontologies (interPro2GO, eggNOG, SEED, and KEGG ) relative to each other does not remain consistent. It can change each time a mapping file for any given ontology is updated. Since they are not all updated at the same time, results of a comparison between ontologies can vary over time.

As Pratik mentioned earlier KEGG is very repetetive and in my opinion not very suitable for microbes. With eggNOG (outside of MEGAN) I made very good experience with getting a function to more than 90% of my proteins.

This tool is quite useful for querying large numbers of sequences thru eggNOG:
https://github.com/jhcepas/eggnog-mapper

Thanks for your input, this really helps us a lot in figuring out what to build. Right now, we were focussing on how to do the consensus calculation for a single peptide (i.e. peptide -> multiple proteins -> multiple potential annotations per protein -> aggregation to a single function) and thing have something workable for GO and EC. Using multiple annotation sources would complicate this process a bit since this means adding (and eventually reducing) another dimension. Ideally we would like to precompute the consensus for each peptide in our database to achieve an acceptable performance.
On the visualisation side, we think that we can create an added value by combining the taxonomic information with the functional in an interactive visualisation. This means that selecting a taxon in the visualisation would highlight the "functions" that are mapped to the corresponding peptides (this is usually called "brushing" is visualisation lingo).
/cc @NoctuaNivalis


conversion_use_type misses members initialization

This is follow up of #411 PR which pointed out this issue
The ownInd_ is passed to the base class before it is initialized.
This allows it to compile, however, it should be cleaned up.

@mloskot we have #374 regarding this issue. So we have duplicate here.

On 6 October 2015 at 15:49, Sergei Nikulov<EMAIL_ADDRESS>wrote:

@mloskot https://github.com/mloskot we have #374
https://github.com/SOCI/soci/issues/374 regarding this issue. So we
have duplicate here.

If we do, then sorry for this duplicate - I was being lazy and didn't check.

Dup for #374


Prompt is not a vaild dict.

Well,  it is hard for me to use the api from OpenAI. And My computer is not powerful enough to run these models locally.
So I wrote a file in core/llm/AModelQW.py to access the Qwen model from Internet. （I have much free tokens to use so I choose it.）
It works good when I use the command like "list the files in this folder".
But when I give a complex command like find the *.ppt files in my PC. And tell me where they are. Point the files which maybe the study materials.
It works fine for the first few steps. But after SYSTEM_system_command_agent return the python script and Instructions， the ASSISTANT_system_command_agent give a tuple as prompt. It makes error cause Qwen only accept a dict.
So, does the tuple is neccessary for AIlice? Should I do something to remove it, or it just a bug?
AModelQW.py
import os, json

from ailice.common.utils.ATextSpliter import sentences_split
from ailice.common.AConfig import config
from ailice.core.llm.AFormatter import AFormatterQW
from dashscope import Generation

class AModelQW():
    def __init__(self, modelName: str):

        self.tokenizer = None
        self.modelName = modelName
        # self.client = openai.OpenAI(api_key = config.openaiGPTKey)
        self.api_key = os.environ.get("QWEN_KEY")
        self.formatter = AFormatterQW(systemAsUser=True)
        # self.contextWindow = 6122
        self.contextWindow=6122*0.6
        return

    def Generate(self, prompt: list[dict[str,str]], proc: callable, endchecker: callable, temperature: float = 0.2) -> str:
        # print("======>this is a generate: ", prompt)
        proc(txt='', action='open')
        currentPosition = 0
        text = ""
        responses = Generation.call(model=Generation.Models.qwen_max,
                                    result_format='message',
                                    messages=prompt,
                                    incremental_output=True,
                                    stream=True)
        for chunk in responses:
            if chunk.status_code == 200:
                text += (chunk.output.choices[0]['message']['content'] or "")

                if endchecker(text):
                    break

                sentences = [x for x in sentences_split(text[currentPosition:])]
                if (2 <= len(sentences)) and ("" != sentences[0].strip()):
                    proc(txt=sentences[0], action='append')
                    currentPosition += len(sentences[0])
            else:
                print(f"=====>response error, chunk id {chunk.request_id}, chunk status_code {chunk.status_code}, chunk code {chunk.code}, chunk message {chunk.message}")
                print(prompt)
        proc(txt=text[currentPosition:], action='close')
        return text

prompt
([{'role': 'system', 'content': '\nYou are an smart and helpful AI agent that helps user complete tasks that require programming. You will complete the task by interacting with agents with coding capabilities (hereinafter referred to as "coder").\nYour job is to communicate with the user to understand their needs, provide requirements for the coder, execute the returned code, extract possible running errors information and feed back to coder until the code runs correctly.\nFor programming tasks that are complex enough to consist of multiple modules, you can consider breaking down the task and assigning it to multiple agents to complete it.\nUsing function calls, you can create and interact with agents, reply to users, configure the program\'s running environment and execute programs.\nUse special symbols "<!|","|!>" as replacements for parentheses in function call syntax. Please pay special attention to the syntax when generating function call statements.\nOnly positional parameter function calls are supported, please do not use keyword parameters and keep the order of parameters consistent with the function definition.\nReferences are not supported in parameters of function call statements. Please use clear and straightforward expressions in function calls.\nFunctions with a single string parameter do not need to write quotation marks when passing parameters. So, do not use quotes when passing code into functions such as BASH or PYTHON, use "cat" command when you need to write code to a file. Avoid the extensive use of escape characters.\nFunction calls need to be placed at the end of your output, and prefixed with "!" to trigger execution.\nYou MUST call a function in your output.\nOnly the most recent rounds of historical conversations will be retained. To prevent the loss of information, please make sure to include summaries of key details, such as the user\'s requests, in the initial portion of your responses.\nIf you find that the environment variable A_IN_CONTAINER is predefined, you can install any necessary tools.\n\n"ext-modules" is a type of module that implements specific interfaces, defining a set of new function calls. Once loaded, you will be able to use the functions defined within it.\nDo not attempt to build ext-modules unless explicitly requested by the user. It adds complexity to the debugging process.\nPlease note that for ext-modules, you need to store the code in the current directory before running it, otherwise there will be an error that the python package cannot be found. You also need to run them as separate processes, or you will be stuck.\n\nYour workflow follows these steps (The details of functions such as CALL/PYTHON/BASH/RESPOND will be given below, and for the sake of simplicity in this context, the term \'coder\' is used to encompass both \'coder\' and \'module-coder\'):\n1. Receive user requirements, understand and engage with the user as needed to enhance understanding(use RESPOND).\n2. Choose or create a suitable coder agent, provide a clear and comprehensive description of the requirements to it(use CALL).\n3. Once coder returns the code, your responsibilities include:\n    Initial verification of whether the solution provided by the coder meets the requirements. If not, make modification requests to the coder.\n    Install the necessary dependencies following coder\'s instructions and execute the code (use BASH and PYTHON).\n    In case of error, send detailed error information to coder for code improvement (use CALL), the message include error and problematic lines of code (for the python case, the code is saved into a temp file like "/tmp/tmp*.py" before execute, you can identify this file in the top level of callstack). Go back to the beginning of step 3 and iterate until success.\n    During the iteration, if coder requires knowledge about specific libraries, query relevant knowledge through the "researcher" type agent (use CALL).\n4. Finally, return the execution result to the user (use RESPOND)."\n\nAvailable Functions:\n#Use this function to interact with an AI agent.\nCALL<!|agentType: str, agentName: str, msg: str|!>\nagentType: A string used to specify the type of AI agent. It can be of the following types:\n    1. "coder". An excellent coder, you need to leave any programming problems other than ext-modules building to him. It should be noted that he can only return the code to you, but does not have the authority to execute the code and configure the environment, this is where you need to help him.\n    2. "module-coder". The only agent capable of building ext-modules, and this is its sole responsibility.\n    3. "module-loader". An agent that can help you load and use ext-modules. Please pass in the address of the module when creating the agent, and then you can let it help you interact with the module. You can use this agent to assist in ext-module debugging.\n    4. "researcher". Suitable for technical problem search tasks such as library document or sample code search on the internet.\nagentName: The name of the AI agent instance. Create a new one if not found. Please use a concise name that reflects the agent’s responsibilities.\nmsg: message need to be told to the agent. The agent cannot see content other than msg. Please provide complete content in msg.\n\n#Dialog with user. Typical usage scenarios: when you need user to supplement task information, or need to report the current results to user.\nRESPOND<!|message: str|!>\n\n#Execute bash script. A timeout error will occur for programs that have not been completed for a long time.\nBASH<!|code: str|!>\n\n#Execute python code. Please note that you need to copy the complete code here, and you must not use references.\nPYTHON<!|code: str|!>\n\n#Wait for some seconds. The unit of the "duration" parameter is seconds. Useful when waiting for script or command execution to complete. \nWAIT<!|duration: int|!>\n\nEXAMPLE:\n!CALL<!|"coder", "clock_coder", "Build a program that can check CPU usage."|!>\n!PYTHON<!|print(\'hello wolrd.\')|!>\n\n\nEnd of general instructions.\n\nActive Agents: [\'file_finder: agentType coder\']\n\nRelevant Information: !CALL<!|"coder", "file_finder", "Write a Python script to find all .ppt files on the system and list their directories, with emphasis on those likely to contain study materials"|!>\n\nBased on the user\'s request,\nThe "RELEVANT INFORMATION" part contains data that may be related to the current task, originating from your own history or the histories of other agents. Please refrain from attempting to invoke functions mentioned in the relevant information, as you may not necessarily have the permissions to do so.\n\n'}, {'role': 'user', 'content': 'Function returned: {Agent file_finder returned: To create a Python script that finds all PowerPoint files (with a .ppt extension) on the system and lists their directories, with emphasis on those likely to contain study materials, we\'ll use the `os` and `glob` modules. The "emphasis" part is subjective, but we can consider directories containing keywords like "study," "education," "class," etc.\n\n```python\nimport os\nimport glob\n\n# List of keywords to identify directories potentially containing study materials\nstudy_keywords = ["study", "education", "class", "lecture", "presentation"]\n\ndef find_ppt_files():\n    # Find all ppt files in the file system\n    all_ppt_files = []\n    for root, dirs, files in os.walk("/"):\n        ppt_files = [os.path.join(root, f) for f in files if f.endswith(".ppt")]\n        all_ppt_files.extend(ppt_files)\n\n    # Filter directories based on study keywords\n    study_material_directories = set()\n    for ppt_file_path in all_ppt_files:\n        directory = os.path.dirname(ppt_file_path)\n        for keyword in study_keywords:\n            if keyword.lower() in directory.lower():\n                study_material_directories.add(directory)\n                break  # Add the directory only once even if it matches multiple keywords\n\n    # Print all ppt files along with their directories\n    print("All PowerPoint (.ppt) files:")\n    for ppt_file in all_ppt_files:\n        print(f"- {ppt_file}")\n\n    print("\\nDirectories likely to contain study materials:")\n    for dir in study_material_directories:\n        print(f"- {dir}")\n\nif __name__ == "__main__":\n    find_ppt_files()\n```\n\n**Instructions:**\n1. Replace the starting directory (`"/"`) with the appropriate starting directory if you don\'t want to search the entire file system.\n2. Run this script as a standalone program; it will list all .ppt files and highlight directories that might contain study materials.\n\nPlease note that searching the entire file system could take a significant amount of time depending on its size and structure. This script does not check the content of the PowerPoint files, only the directory names.\n}'}], 2221)

This issue is caused by a bug. I have fixed it, and once testing is complete, I will submit it.

fixed. You may need to check the settings in ALLMMeta, contextWindow should be set to normal size and should not be too small.
In addition, contextWindow*contextWindowRatio is the window length used by LLM for actual work. This value should not be too small, at least 2048 or above. To obtain better results, it is best to be around 4096 or 8192.

Thanks for your advice.
I think this bug has been fixed and I haven't had this problem again since I pulled the latest update.


Bug: non-strict parsing mode converts tag-names to UPPERCASE.

Bug-Report
I wondering why are the tag-names of a parsed xml UPPERCASE formatted?
Input:
<PascalCase>Foo</PascalCase>

Output:
{ "PASCALCASE": ["Foo"] }

And btw. why is the value wrapped to an array? Ok, I think because a tag could contain tag-nodes as childs. ... But why uppercase?
xml2js 0.4.19 (latest)
@types/xml2js 0.4.3 (latest)

I don't think it should uppercase. Can you post a minimal example on how this happens?
The result is in an array because you might potentially have multiple things in your tag, like <PascalCase><Haskell/><Idris/></PascalCase> so it stays consistent and is an array.

Thanks for fast response. See example

I see if I remove strict: false it works.

Can you make a minimal example which does not involve dependencies outside of xml2js, like Angular?

Blank JavaScript Example
Note: The dependencies timers, string_decoder, 'events' are required to work with xml2js (node).

That's interesting. Looks like the underlying parser, sax-js is uppercasing tag names for some reason…

So, this is an issue of the sax-js repositrory not xml2js?

I assume so, since we never actually do anything with the strict option except for passing it to sax-js:
https://github.com/Leonidas-from-XIV/node-xml2js/blob/0f0a2980b3db5366b3d50e4d0da422cb7af100c9/src/parser.coffee#L70-L74

Ok, your project xml2js uses the sax version 0.6.0, but the latest is 1.2.4. Maybe an update will fix this? But wait ... take a look to this issue on sax repo. I do not think that this gonna be changed.


cool background animation =D

The ASYNC Research Institute, appreciates your contribution to the A-Player codebase and will gladly accept your pull request.
With your help, the success of the A-Player will be more than guaranteed to dominate other current Media Players in the market.
We hope to see another contribution from you soon!


Fix AzureAISearchRM Error when doing vector/hybrid search

In hybrid/vector search case,
when calling client.search, get_embedding() is returning List[VectorQueries]:
https://github.com/stanfordnlp/dspy/blob/main/dspy/retrieve/azureaisearch_rm.py#L380
It can directly passed to the client.search.
Currently, an extra '[]' is added when passing the vector_query to the client.search:
https://github.com/stanfordnlp/dspy/blob/main/dspy/retrieve/azureaisearch_rm.py#L258
Results in serialization error from AISearch library.
The fix is to remove that extra []. Test is done with positive result after fix.

Thanks @jeffreyrubi !


Update Composer Installer hash

LGTM

Thanks for the review! Anything else you think we should make sure to get in?

As I mentioned in #57 , I still didn't get them work properly. especially when run with global options.
I try to mount the volume /composer, but seems I override some settings and it is not successful.


style: fix prettier style

:tada: This PR is included in version 4.1.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Changes write-out variables to be more distinctive

The list of available --write-out variables suffers from a slight case of "Wall of text" because the variable names are not in a distinguishably different format than the text describing them.
By marking the available variables as code, they become more distinctive.
(Alternatively, instead of displaying the names as code, they could be displayed in bold).

Thanks!


tf.estimator graph_saver.restore() error when calling train_and_evalute method

System information

Have I written custom code (as opposed to using a stock
example script provided in TensorFlow): yes
OS Platform and Distribution (e.g.,
Linux Ubuntu 16.04): Google Colab
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if
the issue happens on mobile device: no
TensorFlow installed from (source or
binary): Provided by Colab
TensorFlow version (use command below): 2.1.0
Python version: Python 3.6
Bazel version (if compiling from source): not relevant
GCC/Compiler version (if compiling from
source): not relevant
CUDA/cuDNN version: CUDA V10.1.243
GPU model and memory: GPU deactivated

Describe the current behavior
After evaluation, the train_and_evaluate method of the tf.estimator API throws an error when the Saver restores the checkpoints after exporting the model using tf.estimator.Exporter. It seems that the estimator calls the restore() method with too many arguments. See logs for details.
Describe the expected behavior
Until a few days ago, my (unchanged) code worked without any errors. So I guess some change in tensorflow/tf.estimator within the last days caused the issue to come up. Back then, the estimator was able to train, evaluate, export and then continue training without problems.
Standalone code to reproduce the issue
Here is a link to a Colab Notebook to reproduce the issue
Other info / logs
INFO:tensorflow:Finished evaluation at 2020-04-13-14:15:37
INFO:tensorflow:Saving dict for global step 2821: accuracy = 1.0, global_step = 2821, loss = 0.2742786
INFO:tensorflow:Saving 'checkpoint_path' summary for global step 2821: /content/simple/model.ckpt-2821
INFO:tensorflow:Calling model_fn.
INFO:tensorflow:Done calling model_fn.
INFO:tensorflow:Signatures INCLUDED in export for Classify: None
INFO:tensorflow:Signatures INCLUDED in export for Regress: None
INFO:tensorflow:Signatures INCLUDED in export for Predict: ['serving_default']
INFO:tensorflow:Signatures INCLUDED in export for Train: None
INFO:tensorflow:Signatures INCLUDED in export for Eval: None
---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
<ipython-input-128-30df9d6a3d21> in <module>()
----> 1 tf.estimator.train_and_evaluate(estimator, train_spec, eval_spec)

23 frames
/usr/local/lib/python3.6/dist-packages/tensorflow_estimator/python/estimator/training.py in train_and_evaluate(estimator, train_spec, eval_spec)
    471         '(with task id 0).  Given task id {}'.format(config.task_id))
    472
--> 473   return executor.run()
    474
    475

/usr/local/lib/python3.6/dist-packages/tensorflow_estimator/python/estimator/training.py in run(self)
    611         config.task_type != run_config_lib.TaskType.EVALUATOR):
    612       logging.info('Running training and evaluation locally (non-distributed).')
--> 613       return self.run_local()
    614
    615     # Distributed case.

/usr/local/lib/python3.6/dist-packages/tensorflow_estimator/python/estimator/training.py in run_local(self)
    712         max_steps=self._train_spec.max_steps,
    713         hooks=train_hooks,
--> 714         saving_listeners=saving_listeners)
    715
    716     eval_result = listener_for_eval.eval_result or _EvalResult(

/usr/local/lib/python3.6/dist-packages/tensorflow_estimator/python/estimator/estimator.py in train(self, input_fn, hooks, steps, max_steps, saving_listeners)
    372
    373       saving_listeners = _check_listeners_type(saving_listeners)
--> 374       loss = self._train_model(input_fn, hooks, saving_listeners)
    375       logging.info('Loss for final step: %s.', loss)
    376       return self

/usr/local/lib/python3.6/dist-packages/tensorflow_estimator/python/estimator/estimator.py in _train_model(self, input_fn, hooks, saving_listeners)
   1162       return self._train_model_distributed(input_fn, hooks, saving_listeners)
   1163     else:
-> 1164       return self._train_model_default(input_fn, hooks, saving_listeners)
   1165
   1166   def _train_model_default(self, input_fn, hooks, saving_listeners):

/usr/local/lib/python3.6/dist-packages/tensorflow_estimator/python/estimator/estimator.py in _train_model_default(self, input_fn, hooks, saving_listeners)
   1196       return self._train_with_estimator_spec(estimator_spec, worker_hooks,
   1197                                              hooks, global_step_tensor,
-> 1198                                              saving_listeners)
   1199
   1200   def _train_model_distributed(self, input_fn, hooks, saving_listeners):

/usr/local/lib/python3.6/dist-packages/tensorflow_estimator/python/estimator/estimator.py in _train_with_estimator_spec(self, estimator_spec, worker_hooks, hooks, global_step_tensor, saving_listeners)
   1495       any_step_done = False
   1496       while not mon_sess.should_stop():
-> 1497         _, loss = mon_sess.run([estimator_spec.train_op, estimator_spec.loss])
   1498         any_step_done = True
   1499     if not any_step_done:

/usr/local/lib/python3.6/dist-packages/tensorflow_core/python/training/monitored_session.py in run(self, fetches, feed_dict, options, run_metadata)
    776         feed_dict=feed_dict,
    777         options=options,
--> 778         run_metadata=run_metadata)
    779
    780   def run_step_fn(self, step_fn):

/usr/local/lib/python3.6/dist-packages/tensorflow_core/python/training/monitored_session.py in run(self, fetches, feed_dict, options, run_metadata)
   1281             feed_dict=feed_dict,
   1282             options=options,
-> 1283             run_metadata=run_metadata)
   1284       except _PREEMPTION_ERRORS as e:
   1285         logging.info(

/usr/local/lib/python3.6/dist-packages/tensorflow_core/python/training/monitored_session.py in run(self, *args, **kwargs)
   1382         raise six.reraise(*original_exc_info)
   1383       else:
-> 1384         raise six.reraise(*original_exc_info)
   1385
   1386

/usr/local/lib/python3.6/dist-packages/six.py in reraise(tp, value, tb)
    691             if value.__traceback__ is not tb:
    692                 raise value.with_traceback(tb)
--> 693             raise value
    694         finally:
    695             value = None

/usr/local/lib/python3.6/dist-packages/tensorflow_core/python/training/monitored_session.py in run(self, *args, **kwargs)
   1367   def run(self, *args, **kwargs):
   1368     try:
-> 1369       return self._sess.run(*args, **kwargs)
   1370     except _PREEMPTION_ERRORS:
   1371       raise

/usr/local/lib/python3.6/dist-packages/tensorflow_core/python/training/monitored_session.py in run(self, fetches, feed_dict, options, run_metadata)
   1448               results=outputs[hook] if hook in outputs else None,
   1449               options=options,
-> 1450               run_metadata=run_metadata))
   1451     self._should_stop = self._should_stop or run_context.stop_requested
   1452

/usr/local/lib/python3.6/dist-packages/tensorflow_core/python/training/basic_session_run_hooks.py in after_run(self, run_context, run_values)
    599       if self._timer.should_trigger_for_step(global_step):
    600         self._timer.update_last_triggered_step(global_step)
--> 601         if self._save(run_context.session, global_step):
    602           run_context.request_stop()
    603

/usr/local/lib/python3.6/dist-packages/tensorflow_core/python/training/basic_session_run_hooks.py in _save(self, session, step)
    625     should_stop = False
    626     for l in self._listeners:
--> 627       if l.after_save(session, step):
    628         logging.info(
    629             "A CheckpointSaverListener requested that training be stopped. "

/usr/local/lib/python3.6/dist-packages/tensorflow_estimator/python/estimator/training.py in after_save(***failed resolving arguments***)
    517       return True
    518     if self._timer.should_trigger_for_step(global_step_value):
--> 519       self._evaluate(global_step_value)  # updates self.eval_result
    520       if not self._continuous_eval_listener.after_eval(self.eval_result):
    521         logging.info('Exiting evaluation, as requested by '

/usr/local/lib/python3.6/dist-packages/tensorflow_estimator/python/estimator/training.py in _evaluate(self, global_step_value)
    537     self._timer.update_last_triggered_step(global_step_value)
    538     self.eval_result, self.export_results = (
--> 539         self._evaluator.evaluate_and_export())
    540     if self.eval_result.status != _EvalStatus.EVALUATED:
    541       #  This is unexpected; should never happen.

/usr/local/lib/python3.6/dist-packages/tensorflow_estimator/python/estimator/training.py in evaluate_and_export(self)
    930           self._max_training_steps if self._max_training_steps else False)
    931       export_results = self._export_eval_result(eval_result,
--> 932                                                 is_the_final_export)
    933
    934       if is_the_final_export:

/usr/local/lib/python3.6/dist-packages/tensorflow_estimator/python/estimator/training.py in _export_eval_result(self, eval_result, is_the_final_export)
    963                 checkpoint_path=eval_result.checkpoint_path,
    964                 eval_result=eval_result.metrics,
--> 965                 is_the_final_export=is_the_final_export))
    966       return export_results
    967

/usr/local/lib/python3.6/dist-packages/tensorflow_estimator/python/estimator/exporter.py in export(self, estimator, export_path, checkpoint_path, eval_result, is_the_final_export)
    466     export_result = self._saved_model_exporter.export(
    467         estimator, export_path, checkpoint_path, eval_result,
--> 468         is_the_final_export)
    469
    470     self._garbage_collect_exports(export_path)

/usr/local/lib/python3.6/dist-packages/tensorflow_estimator/python/estimator/exporter.py in export(***failed resolving arguments***)
    118         assets_extra=self._assets_extra,
    119         as_text=self._as_text,
--> 120         checkpoint_path=checkpoint_path)
    121
    122     return export_result

/usr/local/lib/python3.6/dist-packages/tensorflow_estimator/python/estimator/estimator.py in export_saved_model(self, export_dir_base, serving_input_receiver_fn, assets_extra, as_text, checkpoint_path, experimental_mode)
    737         as_text=as_text,
    738         checkpoint_path=checkpoint_path,
--> 739         strip_default_attrs=True)
    740
    741   def experimental_export_all_saved_models(

/usr/local/lib/python3.6/dist-packages/tensorflow_estimator/python/estimator/estimator.py in _export_all_saved_models(self, export_dir_base, input_receiver_fn_map, assets_extra, as_text, checkpoint_path, strip_default_attrs)
    860             builder, input_receiver_fn_map, checkpoint_path,
    861             save_variables, mode=ModeKeys.PREDICT,
--> 862             strip_default_attrs=strip_default_attrs)
    863         save_variables = False
    864

/usr/local/lib/python3.6/dist-packages/tensorflow_estimator/python/estimator/estimator.py in _add_meta_graph_for_mode(self, builder, input_receiver_fn_map, checkpoint_path, save_variables, mode, export_tags, check_variables, strip_default_attrs)
    967         if check_variables:
    968           try:
--> 969             graph_saver.restore(session, checkpoint_path)
    970           except errors.NotFoundError as e:
    971             msg = ('Could not load all requested variables from checkpoint. '

TypeError: restore() takes 2 positional arguments but 3 were given

@alxwdm, I tried to replicate the issue but getting different error, please take a look at the gist and help us to reproduce the issue. Thanks

@gadagashwini: I had to add a call to get_model = get_model_fn() after def get_model_fn(): [...] (sorry, this piece of code is a little confusing). Now the error as described above should appear.
In the meantime, I have looked around and I have something interesting. The file estimator.py in Colab (/usr/local/lib/python3.6/dist-packages/tensorflow_estimator/python/estimator/estimator.py) is different from the file estimator.py currently found in Github. I made some changes to the Colab version in the directory above and the error disappeared.

First of all, estimator.py in Colab has some missing imports compared to the current version on Github:
import tensorflow as tf
from tensorflow.python.training.tracking import graph_view
from tensorflow.python.training.tracking import util as trackable_util
And then, before the line that causes the error (976), I changed the code to:
        graph_saver = tf.compat.v1.train.Saver(           var_list=graph_view.ObjectGraphView(             estimator_spec.scaffold.saver).frozen_saveable_objects(),           sharded=True)
and uncommented
 #graph_saver = (estimator_spec.scaffold.saver or  tf.compat.v1.train.Saver(sharded=True))
Then there is no error as described above. In the "original" version in Github, there is an additional if isinstance(estimator_spec.scaffold.saver, ...) ..., but I left this part out when I fixed the error.

In order to re-import tensorflow_estimator, I restarted the Colab runtime and added an extra import command import tensorflow_estimator.

@alxwdm
can you please share a simple stand alone code to replicate the above issue or if possible share a colab gist with the error for us to analyse.


Chakra support for weakref as strongref

cc @bghgary to validate if needed

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

Snapshot stored with reference name:
refs/pull/15894/merge
Test environment:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/15894/merge/index.html
To test a playground add it to the URL, for example:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/15894/merge/index.html#WGZLGJ#4600
Links to test babylon tools with this snapshot:
https://playground.babylonjs.com/?snapshot=refs/pull/15894/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/15894/merge
https://gui.babylonjs.com/?snapshot=refs/pull/15894/merge
https://nme.babylonjs.com/?snapshot=refs/pull/15894/merge
To test the snapshot in the playground with a playground ID add it after the snapshot query string:
https://playground.babylonjs.com/?snapshot=refs/pull/15894/merge#BCU1XR#0

WebGL2 visualization test reporter:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/15894/merge/testResults/webgl2playwright/index.html

Visualization tests for WebGPU (Experimental)
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/15894/merge/testResults/webgpuplaywright/index.html


Add support for ResumeTimeout and Prolog in /etc/slumr/slurm.conf

The prolog part gets added automatically. Will search for scripts from
/usr/local/libexec/slurm/prolog.d/* but a variable can be used for setting a different value.
For resumetimeout, one needs to set the variable slurm_ResumeTimeout for this to be included in the slurm.conf
/fixes #125
/fixes #126

The folder /usr/local/libexec/slurm/prolog.d must exist and be non-empty when this is done.


Radio button on top right is not changing theme in one go

One feedback is that the radio button on the top right to change the page's theme is not changing the theme in one go.
For the first time, it will be like the below:

After clicking it for the first time, it becomes like,

And then it changes the theme to dark.

I hope this will help you to improve the website 🩹 💫

Yes, you are right @rudri182 , thanks for spotting and reporting this one.

@rudri182 Could you check if this is still an issue for you? The button works for me in one go now.


Python REPL kernel spins although REPL controller/interpreter is ready

originally from: https://github.com/microsoft/vscode-python/issues/24393#issuecomment-2515735767
Not quite sure what is causing this but the kernel selector or REPL controller continues to spin infinitely although interpreter is selected and REPL controller is ready.
/cc @amunger

For some reason, I cant get a consistent repro, it only happens sometime but not all the time

@DonJayamanne can probably help with this

Duplicate of upstream issue in vscode


Solution for auto-updating mods

Installed mods (via MODS env variable) do not get automatically updated. To ensure a flawless user experience, those mods should be auto-updated. One solution would be to use the HEALTH feature of docker containers, the same way we use it for updating the game files.

There is an auto update function here.
https://github.com/fairplay-zone/docker-dontstarvetogether/blob/a7e0767604fa509e92a3d2e055783ac11e47357c/build/static/bin/update.sh#L35-L37


Added tooltip option to all nodes

[ ] Bugfix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)

Proposed changes
This proposal will open possibility to display custom tooltips to all nodes. This can be used to for example give a quick explanation about what the node does without having to open it.
Request came from our own users, so made this quick proposition. Would love to see it in Node-RED instead of use having to run a fork
Example:
In the custom node:

In NodeRED:

Checklist

[x] I have read the contribution guidelines
[ ] For non-bugfix PRs, I have discussed this change on the forum/slack team.
[ ] I have run grunt to verify the unit tests pass
[ ] I have added suitable unit tests to cover the new/changed functionality

Coverage remained the same at 68.445% when pulling 5494b06311875a690ab357909977f1defa5ef94e on GerwinvBeek:master into 8762d0e1646f224e6021ccb1a31a3d794e180b7a on node-red:master.

In principle, this looks good.
One downside is that each node would have to implement this function in order to do anything.
An alternative would be for us to just show this.info if it is set for any node - that would provide a more consistent user experience. But it does remove the flexibility for a node to be able to provide a completely custom tooltip - is that something you have a requirement for? Your example shows this.info, but do you have cases in mind where it is something else?
We could also do a hybrid approach

if this.tooltip is defined, use that
else if this.info is defined, show the first paragraph of that (as we do with the tooltip when you hover over the node in the palette) This must be the rendered markdown version, not the raw text

If the node has its label hidden, we currently show the node label as the tooltip. In this instance, I'd suggest prefixing the result of the above with what we'd show today, so that information is still readily available.

I think in our situation we will use this.info for every node. This is an easy place for the user to place a description.
If that is prefered as the implementation instead of the tooltip property I can work with it!
I did try a implementation with the available popover (@node-red\editor-client\src\js\ui\common\popover.js). This did give me the ability to render markdown in the tooltip. However, it did complicate the code quite a bit. This might have to do with my lack of understanding the code. I still have a stash laying around I think, I could share it if you want to take a look at it?
I'd agree that rendering markdown is the prettier solution here!
I can definitely add the label to the beginning, that sounds like a good solution for when the label is hidden.

Thanks for this. I've got a couple concerns about the length of text this could display - and whether it should clip it at some sensible point.
Also, I think when the label is being shown as well, it ought to be on a line of its own if info is multiple lines.
I can also see that rendering it has markdown is non-trivial given the way we render it in the svg.
I'm going to hold off merging this for the imminent beta, but we can tidy up these last few points ahead of the final 3.0 release.

Thank you, do I just leave this pullrequest open and you commit the last few changes?

I think it would also be nice if there was some sort of visual cue on the nodes that have information in their description.

Re length, yes  agree first para should make sense. Could there be a link in the tooltip ? that opens up the sidebar to the correct full info page to show the rest ?


Logging, Debugging of CertPropSvc

Does this service have the ability to generate logs or debug information? I have an issue (https://answers.microsoft.com/en-us/windows/forum/windows_10-performance/certificate-propagation-service-crashes-after/97379527-a081-40ef-a015-11a41a42c0b0?tm=1552400317694) where CertPropSvc crashes after seeing a particular smartcard.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 69fe36f2-fe78-daaa-3d01-bb7b6fa43543
Version Independent ID: cb92d802-61bf-80db-2a10-5bd0f81b7819
Content: Certificate Propagation Service (Windows 10)
Content Source: windows/security/identity-protection/smart-cards/smart-card-certificate-propagation-service.md
Product: w10
GitHub Login: @DaniHalfin
Microsoft Alias: daniha

I was able to resolve my issue by attaching WinDbg to svchost, the CertPropSvc then writes fairly extensive logs to the debugger. In my case, the cause was a faulty minidriver.


bug in iso8601TimestampToDateValueTransformer – cannot parse microseconds

There's a bug in iso8601TimestampToDateValueTransformer.
Regex is allowing up to 6 digits in milliseconds section, see below
static const char * REGEX_ISO8601_TIMESTAMP =
                "\\A(\\d{4})-(\\d{2})-(\\d{2})[T\\s](\\d{2}):(\\d{2}):(\\d{2})" // Mandatory - YYYY-MM-DD(T|\s)hh:mm:ss
                "(?:"
                "[.](\\d{1,6})"                                   // Optional - .nnnnnn
                ")?"
                "(?:"
                "([+-])(\\d{2}):?(\\d{2})|Z"                       // Optional -[+-]hh:?mm or Z
                ")?\\z";

But that means that the time precision depends on the number of characters supplied.
But in the following lines I see the division by 1000 that suggests that iso8601TimestampToDateValueTransformer only supports milliseconds.
inputValue = [NSString stringWithString:newInputString];
milliseconds = [millisecondsString doubleValue]/1000.f;

I suggest changing it to
milliseconds = [millisecondsString doubleValue] / pow(10, millisecondsString.length);

Closed by https://github.com/RestKit/RKValueTransformers/issues/27.


Add Hanamura map image

This partially addresses #74 by showing an image of Hanamura when you select that map:

It may be a good thing you only got screenshots of Hanamura, @RobThePM. I'm wondering if the spectator camera is good because of how wide the field of view is. Does it seem a little odd/disorienting to look at the map image above? It could be just the crop I got, but there looked to be a bit of distortion in each area of the screenshot from the FoV. I opted to crop the image I did because its colors fit those @smbriones picked for Hanamura.

That picture for Hanamura seems totally fine, but I'm no designer so maybe they have other ideas. 😄

@cheshire137 I think it looks good, too! You could also try making the image a little smaller before cropping so you get a little bit more of Hanamura in there.

Thanks for the feedback, y'all! I was probably staring at it too long.

You could also try making the image a little smaller before cropping so you get a little bit more of Hanamura in there.

I'll try this!


Issue

We need to add figure labels and also do APA citations. Also, we have 2700 words so it has to be cut down quite a lot

oops


Release support for phpunit 6

In develop branch is added (and passing unit tests) support to phpunit 6. Can we release it?

@snapshotpl
Before that, we will remove the PHPUnit 4 support. (#43)

When? Maybe this or next week I will review and merge some PRs.


Add pandas dataframe support

Fix for issue #48

@dasjyao Thanks so much for this PR. Greatly appreciated.
I think there might be some issue with the new tests. Mind taking a look?

Added the fix for tests and formatted with black. I think there might be an issue with the SF connector failing tho. 😒

@dasjyao I had to include a fix for OrderedDict in find_column_type. This is due to Python 3.5 not having insertion order preserved in dicts.


Problems with textColor and selectedColor

I've styled the text using the attribute textColor="#949494" and selectedColor="#FFF" but only textColor is being displayed with the correct color, It seems that selectedColor="#FFF" is being ignored. Could you help me?

i've the trouble.

selectedColor is already '#FFFFFF' by default. What changes do you expect to see?
Maybe an image would help.


Replace screenshots by ones which don't use subpixel rendering

While updating #310 I noticed that two screenshots didn't reproduce exactly when I ran screenshotter.sh on my system. The differences were almost imperceptible at first, but with the help of GIMP I found out that the screenshots currently included in the master branch use subpixel rendering, while the ones the selenium docker images created for me do not. At large magnifications you'll notice this as the presence resp. absence of a slightly colored boundary along non-horizontal edges.
@JeffEverett, how did you create your screenshots? Did you run the latest screenshotter.sh to create them? If you run screenshotter.sh on the current master, can you reproduce your results or mine?
If Jeff can reproduce my results instead of his, then I'd ask the project owners to merge this branch so that we all compare against those. If not, then we need a more thourough investigation as to why the same docker image sometimes employs subpixel rendering and sometimes does not.

@gagern I noticed there were difference between the chrome screenshots that are in the repo and the ones that I generate locally w/o any changes to source code.  I didn't have time to investigate the different and ended up disabling the chrome screenshots because of this.  Maybe it's the same issue as this.

@kevinb7 I hadn't noticed 0dc9eed1c42ab111b1ba1d795270e579d4b423cc before, thanks for pointing this out. Can you upload your variants of these screenshots somewhere, e.g. as a separate branch (with no pull request)?
I don't think that this is the same issue, though: subpixel rendering would affect pretty much all of the screenshots, so if you can reproduce at least some screenshots, then you should have the same subpixel behavior. So perhaps we should open a new issue for the Chrome divergence.
Which version of the two Firefox screenshots in question here can you reproduce on that setup with the diverging Chrome results?

@gagern I've created an issue for it: https://github.com/Khan/KaTeX/issues/325.

PR #340 supersedes this one: if you merge that, there is no need to merge this here as well. If you merge this here first, then that, then the history will be clearer but it would mean more work for me.

Closed in preference of https://github.com/Khan/KaTeX/pull/340.


Publish dotnet core SDK to Chocolatey

Publish the .NET Core 2.0 SDK to Chocolatey repository.
Responding to blog comment by @richlander

Chris McKenzie
Would it be possible to publish the SDK installer to Chocolatey?
23 mins ago
Reply
Rich Lander [MSFT]

We have been thinking about doing two things:

– Publish the SDK to Chocolatey.
– Publish the SDK to Homebrew.

Whomever wants those, please create an issue at the dotnet/core repo. Whichever one has the most feedback, we’ll do first.

I'd love to see this as a standard part of the release pipeline. Yay!

+1 for chocolatey

+1 for chocolatey

+1 for chocolatey

+1 for chocolatey

+1 for chocolatey

+1 for chocolatey

+1 4 chocolatey

Issue moved to dotnet/cli #7779 via ZenHub


Bump SwiftLint 0.13.1

SwiftLint 0.13.1 is out! I used that occasion to review a bit the rules we are using. Since, we are getting more and more to contribute in this project (that's awesome!), it's even more important now to have a strict coding style.
That's why I added a few opt_in_rules that have meanings for IBAnimatable:

closure_spacing
conditional_returns_on_newline
empty_count
explicit_init
overridden_super_call
redundant_nil_coalescing
nimble_operator (that one will be useful only if we write tests one day 😬)

I'd like also use do a reminder of the disabled rules that I think they can /  should be enabled:

trailing_whitespace: that one has been disabled because we have a lot of warnings. I will fix that soon
line_length (88 warnings): We have quiet long lines in IBAnimatable, I think it will be worth to reduce them
cyclomatic_complexity (3 warnings, 2 errors): That one is hard to fix without changing IBAnimatable core. I don't really mind since it's our core is build like that, but it's worth a reminder: Do we really want that?
function_body_length (7 warnings): mostly due to the huge switch. Same speech as cyclomatic_complexity rule, the project is build on enums so we have huge switch. Just a reminder.
type_name (14 warnings): mostly due to AnimatableActivityIndicator*. I already though that our names are long, very long (we basically have a long prefix (Animatable*) and suffix (Designable), but right now, I have no idea how to reduce them.

That last part can be a full issue, so I will open one if any of you wants to talk more about this. For now, that PR is ready to go 😬

Only two points stick out for me: line length, depending on the value and type name length.
For the former, today's screens are far wider than they used to be, but a reasonable cap could be put in place (although line wrapping gets the job done) and clarity should still be king... which leads me to the length of type names. We do have fuzzy matches autocomplete, do we really have an issue there?
Sent from my iPhone

On 30 Nov 2016, at 07:48, Tom Baranes<EMAIL_ADDRESS>wrote:
SwiftLint 0.13.1 is out! I used that occasion to review a bit the rules we are using. Since, we are getting more and more to contribute in this project (that's awesome!), it's even more important now to have a strict coding style.
Added a few opt_in_rules:
closure_spacing
conditional_returns_on_newline
empty_count
explicit_init
overridden_super_call
redundant_nil_coalescing
nimble_operator (that one will be useful only if we write tests one day 😬)
I'd like also use do a reminder of the disabled rules that I think they can / should be enabled:
trailing_whitespace: that one has been disabled because we have a lot of warnings. I will fix that soon
line_length (88 warnings): We have quiet long lines in IBAnimatable, I think it will be worth to reduce them
cyclomatic_complexity (3 warnings, 2 errors): That one is hard to fix without changing IBAnimatable core. I don't really mind since it's our core is build like that, but it's worth a reminder: Do we really want that?
function_body_length (7 warnings): mostly due to the huge switch. Same speech as cyclomatic_complexity rule, the project is build on enums so we have huge switch. Just a reminder.
type_name (14 warnings): mostly due to AnimatableActivityIndicator*. I already though that our names are long, very long (we basically have a long prefix (Animatable*) and suffix (Designable), but right now, I have no idea how to reduce them.
That last part can be a full issue, so I will open one if any of you wants to talk more about this. For now, that PR is ready to go 😬
You can view, comment on, or merge this pull request online at:
https://github.com/IBAnimatable/IBAnimatable/pull/369
Commit Summary
Add few swiftlint opt_in_rules
Fix lint warnings
Reenable file_length rule
File Changes
M .swiftlint.yml (15)
M IBAnimatable/Animatable.swift (1)
M IBAnimatable/ColorType.swift (84)
M IBAnimatable/ContainerTransition.swift (2)
M IBAnimatable/GradientType.swift (689)
M IBAnimatable/PresentationAnimationType.swift (6)
M IBAnimatable/PresentationModalSize.swift (6)
M IBAnimatable/Utils.swift (2)
M IBAnimatableApp/GradientViewController.swift (6)
M IBAnimatableApp/MaskViewController.swift (2)
M IBAnimatableApp/ParamType.swift (2)
M Scripts/GradientsTypeScript.swift (2)
Patch Links:
https://github.com/IBAnimatable/IBAnimatable/pull/369.patch
https://github.com/IBAnimatable/IBAnimatable/pull/369.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

@tbaranes thanks for maintaining the project and making it better and better 👍👍👍.
It is great we can pass a big list of opt_in_rules. For the ones you mentioned. I think we should try to fix trailing_whitespace and ** line_length** as the starting point.  How about we create two tasks/issues and make them as difficulty: easy? Hopefully, we can fix them easily, also attract some contributors to start.
I agree with @Panajev "clarity should still be king". In Swift API Design Guidelines, Apple also suggests "Clarity is more important than brevity". We should keep the type names like AnimatableActivityIndicator* to keep the code more readable.
@Panajev I know your concern about line length. If they are caused by the good readable long type name, I think we should keep them. In some case, they are caused by we put all parameters in one line, I think we should break them in multiple lines which can help readability.
Actually, we are all in the same boat. We want to improve the quality of the code. We should follow the rules benefit us as human beings. Lint rules are the methods help us achieve the goal. Sometimes, if the Lint rules are opposite of our goal, we should ignore them. But a lot of times, lint rules can help us avoid some small code style issues, especially for someone is new to the project. I can use it as a utility for checking small code style issues.

@tbaranes great, thanks for adding tow tasks too 👍


[LiveComponent] auto-add aria-busy="true" during re-render

Something Ryan brought up in his livestream. I think this would help with accessibility but also allows styling loading state without using live-component specific stuff (https://tailwindcss.com/docs/hover-focus-and-other-states#aria-states).

... and role="status" on the loaders
( https://getbootstrap.com/docs/5.0/components/spinners/#about )

Let's keep it open @carsonbot :)
A good handling of busy / live / atomic would be benefit for everyone ... and could also allow us to remove the (almost-useless) css file we expose in this package
https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Attributes/aria-atomic


No body for section-slide

Hi, simple example:
= My Section 1
#my-custom-speaker-notes("something for section")

== My Slide
#my-custom-speaker-notes("something for slide")

It seems that the new-section-slide-fn does get the heading as body(first positional argument); but not the custom note that I provided. The heading can easily be obtained via utils.display-current-heading(level: 1); but the body is gone or triggering a new slide. As far as I understand, the part after "=My Section 1" could be treated as body, also for sections.
What do you think?

There is ambiguity here:
= Title

Slide body.

How many slides will be generated? touying currently believes that you should generate two slides instead of having the Slide body as part of the new-section-slide.
At the moment we don't have a very good syntax to distinguish between these.

But why would you create a second slide without a title? This is a personal preference, but I would not want that.
As far as I understand:
= Section

Some Content

creates 2 slides: The section slide and the title-less slide with some content, whereas
== Title

Some Content

would create only one slide with title and content? This could be confusing - both use heading to make slides but handle content differently...

I think your idea is reasonable. But I still think that the user who see
= Section

Some Content

will consider it should create 2 slides.
If only 1 slide is generated, then only a new-section-slide with invisible Some Content will be generated (at present, basically all themes believe that new-section-slide only has title, without considering body displaying). This is a huge annoyance for users, who will think that disappearing content is a bug.

In other words, do you think it makes more sense to just register slide-fn and then let theme makers dispatch new-section-slide-fn themselves in slide-fn?

No, that’s not exactly what I meant. I would prefer to keep them as two separate functions, but both could take the body/content as a parameter. A section slide might also require a body—not just for metadata as I intend to use it, but also to add section-specific elements like an image or a quote.

Okay, I think such a design is reasonable. There is just a small problem, if the section-slide-uses-body of built-in themes are configured with false, then your usage still won't work. Users may get a little confused.
= My Section 1
#my-custom-speaker-notes("something for section")

In short, I agree with the idea that new-section-slide-fn can have a body, but for the syntax, I think it needs to be carefully designed. Thanks for your issue.

Okay, I think such a design is reasonable. There is just a small problem, if the section-slide-uses-body of built-in themes are configured with false, then your usage still won't work. Users may get a little confused.

From what I understand, nearly all options can be overridden by the user through the config-xxx() methods. This means I could use the built-in template, override this specific setting within my presentation, and it should work as expected. Is that correct?

I don't think it's that simple because #let new-slide-section(body) must accept a positional argument unless we use named argument #let new-slide-section(body: none).

But #let new-slide-section() could accept an argument sink ...args so if a body is provided it would silently go unter the positional part of the sink argument...

At least for me it would be great to use h1 and h2 for sections and slides while being able to use my annotations for both. Right now I would have to create all sections the explicit way... So I'm really interested in this. Do you consider allowing bodies for section-slides?

I'll think about it, but it may take some time to think about the best way to do it.

Don't underestimate the power of discussion and talking. 😀 Is there any place to find interested users to incorporate into the discussion?

You can discuss it directly under this issue, I just haven't had time to think about it recently. Maybe I'll add this feature in the next release.

One question. For now I would like to call #section-slide function explicitly, but doing so, no new  heading is generated und thus missing in the agenda. I think there is some trick to make it work, right?

Minimal reproducible example? I can use the following code to generate it normally:
#show: university-theme.with(
  config-common(
    new-section-slide-fn: none,
  )
)

= Section

#new-section-slide[]

In the next version, a config-common(receive-body-for-new-section-slide-fn: true) configuration will be added, which defaults to true.


Build Failed

when I try to run react-native run-android
the build was failed and returning this error
:CrosswalkWebView:generateReleaseSources
:CrosswalkWebView:processReleaseJavaRes UP-TO-DATE
:CrosswalkWebView:compileReleaseJavaWithJavac
C:\react-apps\qt-games-mobile-app\node_modules\react-native-webview-crosswalk\sr
c\main\java\com\jordansexton\react\crosswalk\webview\CrosswalkWebViewGroupManage
r.java:44: error: getCurrentActivity() is not public in ReactContext; cannot be
accessed from outside package
        Activity _activity = reactContext.getCurrentActivity();
                                         ^
C:\react-apps\qt-games-mobile-app\node_modules\react-native-webview-crosswalk\sr
c\main\java\com\jordansexton\react\crosswalk\webview\CrosswalkWebViewGroupManage
r.java:59: error: getCurrentActivity() is not public in ReactContext; cannot be
accessed from outside package
      Activity _activity = reactContext.getCurrentActivity();
                                       ^
C:\react-apps\qt-games-mobile-app\node_modules\react-native-webview-crosswalk\sr
c\main\java\com\jordansexton\react\crosswalk\webview\CrosswalkWebViewGroupManage
r.java:95: error: getCurrentActivity() is not public in ReactContext; cannot be
accessed from outside package
        Activity _activity = reactContext.getCurrentActivity();
                                         ^
Note: C:\react-apps\qt-games-mobile-app\node_modules\react-native-webview-crossw
alk\src\main\java\com\jordansexton\react\crosswalk\webview\CrosswalkWebViewGroup
Manager.java uses unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
3 errors
:CrosswalkWebView:compileReleaseJavaWithJavac FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':CrosswalkWebView:compileReleaseJavaWithJavac'.
> Compilation failed; see the compiler error output for details.

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug
option to get more log output.

cureently using react-native 0.31.0

Checking with @zaynyatyi for his input. The method of activity reference changed in #26 due to changes in RN 0.29.0, but I haven't tested the latest release.

It happened again when I downgrade RN to 0.29.0

Right, okay. I don't think that it's a problem with RN 0.31.0 or your configuration. I'm guessing that it's an issue introduced in d8214664a768df936b726790cde943db9ade5efd or 1fbef2bb17661d3f407a4c9a92a08cce60dd6a61, but I'm hoping @zaynyatyi can weigh in. I'm not using the latest versions of RN, so I haven't looked at how the source has changed enough to know.

I will check it on weekend, currently i'm using it with RN 0.31 and it works well. I had something similar and it was solved after react-native module folder removement manually and reinstalling react-native module again.

Thanks @zaynyatyi. I'm sorry I'm not more help on this right now!

@jordansexton np. @markortiz can you paste your npm list?

so far this is my dependencies (npm list is too long,  it was cut on windows console)
"dependencies": {
    "autobind-decorator": "^1.3.3",
    "immutable": "^3.8.1",
    "minutes-seconds-milliseconds": "^1.0.3",
    "react": "15.2.1",
    "react-native": "^0.29.0",
    "react-native-cli": "^1.0.0",
    "react-native-router-flux": "^3.33.2",
    "react-native-webview-crosswalk": "^0.3.0",
    "react-redux": "^4.4.5",
    "redux": "^3.5.2",
    "redux-logger": "^2.6.1",
    "redux-thunk": "^2.1.0"
  }

I tried to delete manually the whole node_modules directory then I npm install it again.
And I got same error again.

@zaynyatyi is there any difference if I put new CrosswalkWebViewPackage(this) in MainApplication.java rather than MainActivity.java
import com.jordansexton.react.crosswalk.webview.CrosswalkWebViewPackage;    // <--- add this line

public class MainApplication extends Application implements ReactApplication {

  private final ReactNativeHost mReactNativeHost = new ReactNativeHost(this) {
    @Override
    protected boolean getUseDeveloperSupport() {
      return BuildConfig.DEBUG;
    }

    @Override
    protected List<ReactPackage> getPackages() {
      return Arrays.<ReactPackage>asList(
          new MainReactPackage(),
          new CrosswalkWebViewPackage(this)
      );
    }
  };

  @Override
  public ReactNativeHost getReactNativeHost() {
      return mReactNativeHost;
  }
}

@jordansexton  @zaynyatyi I create a new blank project with
"dependencies": {
    "react": "15.2.1",
    "react-native": "^0.29.0",
    "react-native-cli": "^1.0.0",
    "react-native-webview-crosswalk": "^0.3.0"
  }

and I still got the same error.
can you create a simple example project?
Thank you very much! :)

@markortiz yeah, i will provide simple example project. On new react Crosswalk should be put in MainApplication, not MainActivity. We have to mention it in readme, but i think rnpm integration will be better.

Thank you @zaynyatyi.
I also try rnpm and it did not integrate even it did not return any error.

yeah, we have to define some rules for it i suppose.

@zaynyatyi is there any news about this?
I tried to worked with the lower version of RN 0.28 but I cannot proceed because of the issue #13
Thank you very much.

@markortiz i just compiled it. I will prepare fork, can you give it a try?

@zaynyatyi  yes, just give me the instructions
Thanks!

Ok, your files should be like that ones.
Instead of using MainActivity to add crosswalk use MainApplication
https://gist.github.com/zaynyatyi/59190488de20c2cbdc506cd10cfe4454

@markortiz write me about your progress on that branch, maybe we will have more tests on that on Windows.

@zaynyatyi still working on it.
However while I'm trying to run it. I forgot to copy xwalk_core_library-18.48.477.13.aar to node_modules/react-native-webview-crosswalk/libs
and I got this error:
Building and installing the app on the device (cd android && gradlew.bat install
Debug...

FAILURE: Build failed with an exception.

* What went wrong:
A problem occurred configuring project ':CrosswalkWebView'.
> Could not resolve all dependencies for configuration ':CrosswalkWebView:_debug
Compile'.
   > Could not find :xwalk_core_library-18.48.477.13:.
     Searched in the following locations:
         file:/C:/Users/Mark/.m2/repository//xwalk_core_library-18.48.477.13//xw
alk_core_library-18.48.477.13-.pom
         file:/C:/Users/Mark/.m2/repository//xwalk_core_library-18.48.477.13//xw
alk_core_library-18.48.477.13-.aar
         https://jcenter.bintray.com//xwalk_core_library-18.48.477.13//xwalk_cor
e_library-18.48.477.13-.pom
         https://jcenter.bintray.com//xwalk_core_library-18.48.477.13//xwalk_cor
e_library-18.48.477.13-.aar
         file:/C:/react-apps/newapp/node_modules/react-native/android//xwalk_cor
e_library-18.48.477.13//xwalk_core_library-18.48.477.13-.pom
         file:/C:/react-apps/newapp/node_modules/react-native/android//xwalk_cor
e_library-18.48.477.13//xwalk_core_library-18.48.477.13-.aar
         file:/C:/react-apps/newapp/node_modules/react-native-webview-crosswalk/
libs/xwalk_core_library-18.48.477.13-.aar
         file:/C:/react-apps/newapp/node_modules/react-native-webview-crosswalk/
libs/xwalk_core_library-18.48.477.13.aar
         file:/C:/Users/Mark/AppData/Local/Android/sdk/extras/android/m2reposito
ry//xwalk_core_library-18.48.477.13//xwalk_core_library-18.48.477.13-.pom
         file:/C:/Users/Mark/AppData/Local/Android/sdk/extras/android/m2reposito
ry//xwalk_core_library-18.48.477.13//xwalk_core_library-18.48.477.13-.aar
         file:/C:/Users/Mark/AppData/Local/Android/sdk/extras/google/m2repositor
y//xwalk_core_library-18.48.477.13//xwalk_core_library-18.48.477.13-.pom
         file:/C:/Users/Mark/AppData/Local/Android/sdk/extras/google/m2repositor
y//xwalk_core_library-18.48.477.13//xwalk_core_library-18.48.477.13-.aar
     Required by:
         newapp:CrosswalkWebView:unspecified

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug
option to get more log output.

is this normal?

have you copied aar file?

If you didn't copied it - it's normal :)

you have to copy from node_modules/react-native-webview-crosswalk/libsto android libs folder, just like instructions said.

@zaynyatyi on that error, I forgot to copy the aar file.

@zaynyatyi Here is the result when I finished copy the aar file.
$ react-native run-android
Starting JS server...
Running C:\Users\Mark\AppData\Local\Android\sdk/platform-tools/adb reverse tcp:8
081 tcp:8081
error: closed
Could not run adb reverse: Command failed: C:\Users\Mark\AppData\Local\Android\s
dk/platform-tools/adb reverse tcp:8081 tcp:8081
Building and installing the app on the device (cd android && gradlew.bat install
Debug...
:CrosswalkWebView:compileLint
:CrosswalkWebView:copyReleaseLint UP-TO-DATE
:CrosswalkWebView:preBuild UP-TO-DATE
:CrosswalkWebView:preReleaseBuild UP-TO-DATE
:CrosswalkWebView:checkReleaseManifest
:CrosswalkWebView:preDebugAndroidTestBuild UP-TO-DATE
:CrosswalkWebView:preDebugBuild UP-TO-DATE
:CrosswalkWebView:preDebugUnitTestBuild UP-TO-DATE
:CrosswalkWebView:preReleaseUnitTestBuild UP-TO-DATE
:CrosswalkWebView:prepareComAndroidSupportAppcompatV72301Library UP-TO-DATE
:CrosswalkWebView:prepareComAndroidSupportRecyclerviewV72301Library UP-TO-DATE
:CrosswalkWebView:prepareComAndroidSupportSupportV42321Library UP-TO-DATE
:CrosswalkWebView:prepareComFacebookFrescoDrawee0110Library UP-TO-DATE
:CrosswalkWebView:prepareComFacebookFrescoFbcore0110Library UP-TO-DATE
:CrosswalkWebView:prepareComFacebookFrescoFresco0110Library UP-TO-DATE
:CrosswalkWebView:prepareComFacebookFrescoImagepipeline0110Library UP-TO-DATE
:CrosswalkWebView:prepareComFacebookFrescoImagepipelineBase0110Library UP-TO-DAT
E
:CrosswalkWebView:prepareComFacebookFrescoImagepipelineOkhttp30110Library UP-TO-
DATE
:CrosswalkWebView:prepareComFacebookReactReactNative0310Library UP-TO-DATE
:CrosswalkWebView:prepareComFacebookSoloaderSoloader010Library UP-TO-DATE
:CrosswalkWebView:prepareOrgWebkitAndroidJscR174650Library UP-TO-DATE
:CrosswalkWebView:prepareXwalk_core_library184847713Library UP-TO-DATE
:CrosswalkWebView:prepareReleaseDependencies
:CrosswalkWebView:compileReleaseAidl UP-TO-DATE
:CrosswalkWebView:compileReleaseRenderscript UP-TO-DATE
:CrosswalkWebView:generateReleaseBuildConfig UP-TO-DATE
:CrosswalkWebView:generateReleaseAssets UP-TO-DATE
:CrosswalkWebView:mergeReleaseAssets UP-TO-DATE
:CrosswalkWebView:generateReleaseResValues UP-TO-DATE
:CrosswalkWebView:generateReleaseResources UP-TO-DATE
:CrosswalkWebView:mergeReleaseResources UP-TO-DATE
:CrosswalkWebView:processReleaseManifest UP-TO-DATE
:CrosswalkWebView:processReleaseResources UP-TO-DATE
:CrosswalkWebView:generateReleaseSources UP-TO-DATE
:CrosswalkWebView:processReleaseJavaRes UP-TO-DATE
:CrosswalkWebView:compileReleaseJavaWithJavac UP-TO-DATE
:CrosswalkWebView:extractReleaseAnnotations UP-TO-DATE
:CrosswalkWebView:mergeReleaseProguardFiles UP-TO-DATE
:CrosswalkWebView:packageReleaseJar UP-TO-DATE
:CrosswalkWebView:compileReleaseNdk UP-TO-DATE
:CrosswalkWebView:packageReleaseJniLibs UP-TO-DATE
:CrosswalkWebView:packageReleaseLocalJar UP-TO-DATE
:CrosswalkWebView:packageReleaseRenderscript UP-TO-DATE
:CrosswalkWebView:packageReleaseResources UP-TO-DATE
:CrosswalkWebView:bundleRelease UP-TO-DATE
:app:preBuild UP-TO-DATE
:app:preDebugBuild UP-TO-DATE
:app:checkDebugManifest
:app:preReleaseBuild UP-TO-DATE
:app:prepareComAndroidSupportAppcompatV72301Library
:app:prepareComAndroidSupportRecyclerviewV72301Library
:app:prepareComAndroidSupportSupportV42321Library
:app:prepareComFacebookFrescoDrawee0110Library
:app:prepareComFacebookFrescoFbcore0110Library
:app:prepareComFacebookFrescoFresco0110Library
:app:prepareComFacebookFrescoImagepipeline0110Library
:app:prepareComFacebookFrescoImagepipelineBase0110Library
:app:prepareComFacebookFrescoImagepipelineOkhttp30110Library
:app:prepareComFacebookReactReactNative0310Library
:app:prepareComFacebookSoloaderSoloader010Library
:app:prepareNewappCrosswalkWebViewUnspecifiedLibrary
:app:prepareOrgWebkitAndroidJscR174650Library
:app:prepareXwalk_core_library184847713Library
:app:prepareDebugDependencies
:app:compileDebugAidl
:app:compileDebugRenderscript
:app:generateDebugBuildConfig
:app:generateDebugAssets UP-TO-DATE
:app:mergeDebugAssets
:app:generateDebugResValues UP-TO-DATE
:app:generateDebugResources
:app:mergeDebugResources
:app:bundleDebugJsAndAssets SKIPPED
:app:processDebugManifest
:app:processDebugResources
:app:generateDebugSources
:app:processDebugJavaRes UP-TO-DATE
:app:compileDebugJavaWithJavac
:app:compileDebugNdk UP-TO-DATE
:app:compileDebugSources
:app:preDexDebug
:app:dexDebug
Unknown source file : UNEXPECTED TOP-LEVEL EXCEPTION:
Unknown source file : com.android.dex.DexException: Multiple dex files define Lj
avax/annotation/CheckForNull;
Unknown source file :   at com.android.dx.merge.DexMerger.readSortableTypes(DexM
erger.java:596)
Unknown source file :   at com.android.dx.merge.DexMerger.getSortedTypes(DexMerg
er.java:554)
Unknown source file :   at com.android.dx.merge.DexMerger.mergeClassDefs(DexMerg
er.java:535)
Unknown source file :   at com.android.dx.merge.DexMerger.mergeDexes(DexMerger.j
ava:171)
Unknown source file :   at com.android.dx.merge.DexMerger.merge(DexMerger.java:1
89)
Unknown source file :   at com.android.dx.command.dexer.Main.mergeLibraryDexBuff
ers(Main.java:502)
Unknown source file :   at com.android.dx.command.dexer.Main.runMonoDex(Main.jav
a:334)
Unknown source file :   at com.android.dx.command.dexer.Main.run(Main.java:277)
Unknown source file :   at com.android.dx.command.dexer.Main.main(Main.java:245)

Unknown source file :   at com.android.dx.command.Main.main(Main.java:106)

:app:dexDebug FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':app:dexDebug'.
> com.android.ide.common.process.ProcessException: org.gradle.process.internal.E
xecException: Process 'command 'C:\Program Files\Java\jdk1.8.0_51\bin\java.exe''
 finished with non-zero exit value 2

You have to clean your gradle cache. Don't remember how to do it using gradle command, but you can cleanup your build folder and start again.

@zaynyatyi after clearing the .gradle folder and build folders
I got this error:
:app:preReleaseBuild UP-TO-DATE
:app:prepareComAndroidSupportAppcompatV72301Library
:app:prepareComAndroidSupportRecyclerviewV72301Library FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':app:prepareComAndroidSupportRecyclerviewV72301Librar
y'.
> Could not expand ZIP 'C:\Users\Mark\AppData\Local\Android\sdk\extras\android\m
2repository\com\android\support\recyclerview-v7\23.0.1\recyclerview-v7-23.0.1.aa
r'.

@zaynyatyi I try to rebuild the project.
I remove again the .gradle folder and `builds folders
and I got this error again,
:app:prepareXwalk_core_library184847713Library
:app:prepareDebugDependencies
:app:compileDebugAidl
:app:compileDebugRenderscript
:app:generateDebugBuildConfig
:app:generateDebugAssets UP-TO-DATE
:app:mergeDebugAssets
:app:generateDebugResValues
:app:generateDebugResources
:app:mergeDebugResources
:app:bundleDebugJsAndAssets SKIPPED
:app:processDebugManifest
:app:processDebugResources
:app:generateDebugSources
:app:processDebugJavaRes UP-TO-DATE
:app:compileDebugJavaWithJavac
:app:compileDebugNdk UP-TO-DATE
:app:compileDebugSources
:app:preDexDebug
:app:dexDebug
Unknown source file : UNEXPECTED TOP-LEVEL EXCEPTION:
Unknown source file : com.android.dex.DexException: Multiple dex files define Lj
avax/annotation/CheckForNull;
Unknown source file :   at com.android.dx.merge.DexMerger.readSortableTypes(DexM
erger.java:596)
Unknown source file :   at com.android.dx.merge.DexMerger.getSortedTypes(DexMerg
er.java:554)
Unknown source file :   at com.android.dx.merge.DexMerger.mergeClassDefs(DexMerg
er.java:535)
Unknown source file :   at com.android.dx.merge.DexMerger.mergeDexes(DexMerger.j
ava:171)
Unknown source file :   at com.android.dx.merge.DexMerger.merge(DexMerger.java:1
89)
Unknown source file :   at com.android.dx.command.dexer.Main.mergeLibraryDexBuff
ers(Main.java:502)
Unknown source file :   at com.android.dx.command.dexer.Main.runMonoDex(Main.jav
a:334)
Unknown source file :   at com.android.dx.command.dexer.Main.run(Main.java:277)
Unknown source file :   at com.android.dx.command.dexer.Main.main(Main.java:245)

Unknown source file :   at com.android.dx.command.Main.main(Main.java:106)

:app:dexDebug FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':app:dexDebug'.
> com.android.ide.common.process.ProcessException: org.gradle.process.internal.E
xecException: Process 'command 'C:\Program Files\Java\jdk1.8.0_51\bin\java.exe''
 finished with non-zero exit value 2

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug
option to get more log output.

BUILD FAILED

@zaynyatyi according to this http://stackoverflow.com/questions/32798816 it has something to do with build.gradle

@markortiz are you trying new project or your project with some side dependencies?

@zaynyatyi I'm trying it on a new project
here is my dependencies on android\app\build.gradle
'''
dependencies {
compile fileTree(dir: "libs", include: ["*.jar"])
compile "com.android.support:appcompat-v7:23.0.1"
compile "com.facebook.react:react-native:+"  // From node_modules
compile (name: "xwalk_core_library-18.48.477.13", ext: "aar")    // <--- add this line
compile project(':CrosswalkWebView')                             // <--- add this line
}
'''

should be fine, i will investigate what's wrong and will back to you when
will have more information.
вт, 30 авг. 2016 г. в 14:49, Makus<EMAIL_ADDRESS>
@zaynyatyi https://github.com/zaynyatyi I'm trying it on a new project
here is my dependencies on android\app\build.gradle
'''
dependencies {
compile fileTree(dir: "libs", include: ["*.jar"])
compile "com.android.support:appcompat-v7:23.0.1"
compile "com.facebook.react:react-native:+" // From node_modules
compile (name: "xwalk_core_library-18.48.477.13", ext: "aar") // <--- add
this line
compile project(':CrosswalkWebView') // <--- add this line
}
'''
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/jordansexton/react-native-webview-crosswalk/issues/27#issuecomment-243414458,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAUAMWxeoZvJa5jwIqGpbSyz7ONu1Pfrks5qlBjJgaJpZM4JsyF4
.

@zaynyatyi I have resolved this already.
I it works on a new project that started via rninit on build 0.31.0 then rnpm install your compiled `react-native-webview-crosswalk' and manually add the android settings.
and also I have wrong configuration on android/settings.gradle
instead of
include ':app'
include ':CrosswalkWebView', ':app'
project(':CrosswalkWebView').projectDir = new File(rootProject.projectDir, '../node_modules/react-native-webview-crosswalk')

what I did is
include ':app'
include ':CrosswalkWebView'
project(':CrosswalkWebView').projectDir = new File(rootProject.projectDir, '../node_modules/react-native-webview-crosswalk')

I will close this already.
Thank you very much for your help.

Glad you were able to work this out. Would either of you be interested in submitting a PR for how the documentation should be updated? I'm hoping we can help others who encounter this.

@markortiz cheers. I still didn't got my win notebook back.
@jordansexton yes, but main goal is to have it fully automated. Including lib copy and rnpm integration. Not sure how it could be done if rn-crosswalk will be side dependency of some other project (lib copy).

@jordansexton yeah sure, I'll find a time to create a for readme.
@zaynyatyi I think I need to reopen or create a new issue in related on this one.
I thought I was able to solve this issue by doing the steps above, but when I try to apply react-native-webview-crosswalk in existing and new project in windows 10 and then run react-native run-android it throws this error:
$ react-native run-android
Starting JS server...
Running C:\Users\Mark\AppData\Local\Android\sdk/platform-tools/adb reverse tcp:8
081 tcp:8081
error: no devices/emulators found
Could not run adb reverse: Command failed: C:\Users\Mark\AppData\Local\Android\s
dk/platform-tools/adb reverse tcp:8081 tcp:8081
Building and installing the app on the device (cd android && gradlew.bat install
Debug...
:CrosswalkWebView:compileLint
:CrosswalkWebView:copyReleaseLint UP-TO-DATE
:CrosswalkWebView:preBuild UP-TO-DATE
:CrosswalkWebView:preReleaseBuild UP-TO-DATE
:CrosswalkWebView:checkReleaseManifest
:CrosswalkWebView:preDebugAndroidTestBuild UP-TO-DATE
:CrosswalkWebView:preDebugBuild UP-TO-DATE
:CrosswalkWebView:preDebugUnitTestBuild UP-TO-DATE
:CrosswalkWebView:preReleaseUnitTestBuild UP-TO-DATE
:CrosswalkWebView:prepareComAndroidSupportAppcompatV72301Library
:CrosswalkWebView:prepareComAndroidSupportRecyclerviewV72301Library
:CrosswalkWebView:prepareComAndroidSupportSupportV42321Library
:CrosswalkWebView:prepareComFacebookFrescoDrawee0110Library
:CrosswalkWebView:prepareComFacebookFrescoFbcore0110Library
:CrosswalkWebView:prepareComFacebookFrescoFresco0110Library
:CrosswalkWebView:prepareComFacebookFrescoImagepipeline0110Library
:CrosswalkWebView:prepareComFacebookFrescoImagepipelineBase0110Library
:CrosswalkWebView:prepareComFacebookFrescoImagepipelineOkhttp30110Library
:CrosswalkWebView:prepareComFacebookReactReactNative0310Library
:CrosswalkWebView:prepareComFacebookSoloaderSoloader010Library
:CrosswalkWebView:prepareOrgWebkitAndroidJscR174650Library
:CrosswalkWebView:prepareXwalk_core_library184847713Library
:CrosswalkWebView:prepareReleaseDependencies
:CrosswalkWebView:compileReleaseAidl
:CrosswalkWebView:compileReleaseRenderscript
:CrosswalkWebView:generateReleaseBuildConfig
:CrosswalkWebView:generateReleaseAssets UP-TO-DATE
:CrosswalkWebView:mergeReleaseAssets
:CrosswalkWebView:generateReleaseResValues
:CrosswalkWebView:generateReleaseResources
:CrosswalkWebView:mergeReleaseResources
:CrosswalkWebView:processReleaseManifest
:CrosswalkWebView:processReleaseResources
:CrosswalkWebView:generateReleaseSources
:CrosswalkWebView:processReleaseJavaRes UP-TO-DATE
:CrosswalkWebView:compileReleaseJavaWithJavac
Note: C:\react-apps\qt-games-mobile-app\node_modules\react-native-webview-crossw
alk\src\main\java\com\jordansexton\react\crosswalk\webview\CrosswalkWebViewGroup
Manager.java uses unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
:CrosswalkWebView:extractReleaseAnnotations
:CrosswalkWebView:mergeReleaseProguardFiles
:CrosswalkWebView:packageReleaseJar
:CrosswalkWebView:compileReleaseNdk UP-TO-DATE
:CrosswalkWebView:packageReleaseJniLibs UP-TO-DATE
:CrosswalkWebView:packageReleaseLocalJar UP-TO-DATE
:CrosswalkWebView:packageReleaseRenderscript UP-TO-DATE
:CrosswalkWebView:packageReleaseResources
:CrosswalkWebView:bundleRelease
:app:preBuild UP-TO-DATE
:app:preDebugBuild UP-TO-DATE
:app:checkDebugManifest
:app:preReleaseBuild UP-TO-DATE
:react-native-immersive:compileLint
:react-native-immersive:copyReleaseLint UP-TO-DATE
:react-native-immersive:preBuild UP-TO-DATE
:react-native-immersive:preReleaseBuild UP-TO-DATE
:react-native-immersive:checkReleaseManifest
:react-native-immersive:preDebugAndroidTestBuild UP-TO-DATE
:react-native-immersive:preDebugBuild UP-TO-DATE
:react-native-immersive:preDebugUnitTestBuild UP-TO-DATE
:react-native-immersive:preReleaseUnitTestBuild UP-TO-DATE
:react-native-immersive:prepareComAndroidSupportAppcompatV72301Library
:react-native-immersive:prepareComAndroidSupportRecyclerviewV72301Library
:react-native-immersive:prepareComAndroidSupportSupportV42321Library
:react-native-immersive:prepareComFacebookFrescoDrawee0110Library
:react-native-immersive:prepareComFacebookFrescoFbcore0110Library
:react-native-immersive:prepareComFacebookFrescoFresco0110Library
:react-native-immersive:prepareComFacebookFrescoImagepipeline0110Library
:react-native-immersive:prepareComFacebookFrescoImagepipelineBase0110Library
:react-native-immersive:prepareComFacebookFrescoImagepipelineOkhttp30110Library
:react-native-immersive:prepareComFacebookReactReactNative0310Library
:react-native-immersive:prepareComFacebookSoloaderSoloader010Library
:react-native-immersive:prepareOrgWebkitAndroidJscR174650Library
:react-native-immersive:prepareReleaseDependencies
:react-native-immersive:compileReleaseAidl
:react-native-immersive:compileReleaseRenderscript
:react-native-immersive:generateReleaseBuildConfig FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':react-native-immersive:generateReleaseBuildConfig'.
> Failed to create C:\react-apps\qt-games-mobile-app\node_modules\react-native-i
mmersive\android\build\generated\source\buildConfig\release\com\rnimmersive

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug
option to get more log output.

BUILD FAILED

open it as separate. i don't what's immersive module about.

@zaynyatyi fixed the documentation in #28 which was just merged (thanks!) so I'm marking this as closed now, but if that's incorrect after updating to the latest version, please reopen and let me know!


Support Cameras

The readme file specifies camera export it is not in the current roadmap of this project. I hope my vote can count to reconsider this and add this feature.
Quite selfish by my side but having the option of exporting cameras is a requirement in the use I would give to the glTF files.

The latest release candidate (Release candidate 3) should already have partial support for this, could you try it out?
You just have to make sure to include  the camera(s) in your selection before exporting.

I just could try a fast test. If I try to export only the camera I get an error message a nothing gets exported. I select mesh with the camera, then the camera gets exported but I can't verify if the data exported it's accurate.

Oh you have found a bug.
Ah yes, we currently only export cameras as separate files, without geometry.
So this needs fixing. Will look at this ASAP.
Thanks for testing!

Thanks for testing!
No, thank you for the fast answer and support.

Turns out you can currently export a single camera (say persp) by passing the flag -cam persp... Exporting multiple cameras doesn't work yet. The exported camera properties aren't that well tested either, this is new stuff.
I'm going to refactor the code so more than a single camera can be exported, by providing multiple -cam arguments.

Could you try Release candidate 4? This might work for you.

Hi, I tried several things. First  I export a character with two cameras. The way I got both cameras exported was reapeating -cam flag for each camera. I don't know if this is the intended way to do it.
Then I exported only an animated camera with 3 keys and fov animated between second and third keyframe. The exporter didn't throw any error in the process. Exporting to glb or gltf format.
One thing that happens when I try to export the camera, with animation option set to none, the exporter throw an error when I export to gltf. It doesn't when I use -glb flag.
One question not related with cameras. When I export with -glb flag is there a way to exclude textures from the final glb file?

Thanks for testing. Cameras should be exported if you select them, or if you pass them as -cam flags.
I don't support animating fov yet, I am not sure if GLTF supports that, will look into it.
Having an option to exclude textures from the glb file would indeed be handy. I will make an issue for that.
Could you share a scene that crashes when exporting to GLTF?

Hi, maya doesn't crash but exporter throw this error: !!! maya2glTF: failed at 10:44:47 !!!
I had provided the scene but the error is easy to reproduce. Just create  a camera, try to export without animation and the error mentioned before is throw. I'm working with maya 2019 in windows 10 platform.
camera.zip

Could you try the latest release? (rc5)
Passing the extra flags -glt -ext should keep the textures external from the glb.
I also tried to fix the camera export crashing.
As for animating FOV, note that GLTF doesn't support this.

Everything seems to be working fine.
I had tried both things and I no longer get errors exporting camera alone in glTF format. Also the option to export to .glb, textures are copied to the export folder but they are not included in the .glb file.
About fov animation, it could be an issue but it's nothing you can do if glTF doesn't support it.
Thanks a lot for the great and responsive support.

Thanks for the help and for using Maya2glTF!

Fixed in d6eb424e01930d1139fcbdb86289d79750deb472


ES_BUILD_PN defined by default

https://github.com/dotnet/corert/blob/d0683071605aed956497506ed1aae4d366be0190/src/System.Private.CoreLib/src/System.Private.CoreLib.csproj#L32
Am I correct that ES_BUILD_PN means ProjectN?
And ProjectN means UWP apps?
I've found that there is check, for Windows version is disabled when ES_BUILD_PN  defined.
https://github.com/dotnet/corert/blob/a3e3edbb8e8e95ba97c1ad5f36d38965b768fd55/src/System.Private.CoreLib/shared/System/Diagnostics/Tracing/EventSource.cs#L1500
So there is thrown exception on resolving EventSetInformation function on Windows 7
I'am not sure if it can break something, but atleast it looks strange.

Am I correct that ES_BUILD_PN means ProjectN?

It means ProjectN-specific build of EventSource.
It should be fine to delete this ifdef. Interested in submitting a PR?

Shouldn't we check other code depenadant on this flag?
There is could be another assumptions specific to ProjectN
Also I've tried to remove this flag and got 2 buld errors.

I meant to just remove the ifdef around that specific line.
Most of the places where ES_BUILD_PN is used are needed for CoreRT; or do not harm at least.

Most of the places where ES_BUILD_PN is used are needed for CoreRT; or do not harm at least.

Then the define must be renamed to not confuse, as it no more related to PN :)


Fixed climate_on -function to provide the proper post_data.

Fixed also polling on status of climate_on.

Closed based on private discussion


ValueError: invalid literal for int() with base 10: '²' in normalizer

Hi there,
This is my code:
data['new_column'] = np.vectorize(normalizer.normalize)(data['tweet2'], normalize_entity = False)
Can i know why / how to solve the issue for
invalid literal for int() with base 10: '²'?
Thanks! :)

Cannot do this np.vectorize(normalizer.normalize)(data['tweet2'], normalize_entity = False).

Hi @huseinzol05 ,
If cannot do vectorize, could you please suggest how can I normalize the tweets data in dataframe?