Flatiron needs documentation and in-depth examples

The core parts of Flatiron (broadway, union, etc.) have enough documentation that you can infer generally how flatiron works, but flatiron itself has no documentation. In particular, the functionality of the baked-in plugins needs documenting.

The short answer is that its plugin system is based on broadway so that aspect should look the same.

Heads-up: A simple http example was added in d34cdb28309b95f87700edcef62f8cff07cac345.

I think a large/lengthy overview of using flatiron to build a blog would be ideal.  Coming into the main flatiron page I was confused by all the modules and what problems they are actually solving.  Nodeup episode 7's intro to flatiron is more informative than the website.  To get me up to speed I learn much faster when I can look at a familiar project (a simple blog) and see how all the pieces fit together.

+1 To the original point, we document all of the pieces but have no complete docs on how to use them all together. The flatironjs.org site gives snippets for the components but none for the whole.

I would love to see some examples. I'm going to try it out as a replacement for Express and actual code snippets could help a lot.

I've been experimenting with backbone some over the past few weeks.  Flatiron.js could act as a client-side/server-side replacement?  If so would be great to see the backbone todo-app example converted :)

You could elect to use director over backbone's router and it wouldn't be an issue as Backbone doesn't force you into their router.
I've thought about this some more and they could work together, just don't know if it is the best approach.

In that case, I would imagine that it's a matter of taste. Personally, I'd love to see an example where backbone's router is swapped out with director even if it's often not the first choice.

I'll love to see how it works all together in client/server side, 'cause there is some examples on how works on server or client, but not in both sites. Its just confusing me of how need to work with flatiron

@pksunkara Any progress on those "few more steps"? I'd like to update my answer on Stack Overflow: https://stackoverflow.com/questions/9057016/node-js-express-vs-flatiron/18583473#18583473
Thanks.


Background music

Added music tracks
Music plays on start
Music changes when player is in a zone

🌮

@latedude2 don't steal my tacos! 😡


[DO NOT MERGE] Client v2.1.0

Adds changelog for v2.1.0
Updates interfaces
Updates CLI descriptions
Updates React explanation
Adds crosschain sections

@ytham -- let's merge this into staging ?

@yi-sun sounds good, merging into staging


Icon to support Apple Mail links

Idea
Links to Apple mail, which have the format [Apple mail](message://%3c29580-0B7-482-AA0-8A7E11C757@com%3e) are not rendered properly.
Screenshots
Add some pictures to get the idea if needed

done

re-done )


Support Rails 7.0

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 4 (100.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-1.8%) to 95.357%

Totals

Change from base Build<PHONE_NUMBER>:
-1.8%

Covered Lines:
1150

Relevant Lines:
1206

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

4 of 4 (100.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-1.8%) to 95.357%

Totals

Change from base Build<PHONE_NUMBER>:
-1.8%

Covered Lines:
1150

Relevant Lines:
1206

💛  - Coveralls


Catch Received Notifications in Android

Currently there is no way to catch received notifications in Android.  There exists a way to in iOS but I'm not sure if I like it.  Might end up changing both.

Listening for and catching notifications in both Android and iOS is working.  Still a bit of clean-up before I commit my changes:

Unit tests for iOS listener.
iOS Example Client does not display the ID of the caught notification.
Possibly change the Listener methods to all be static.

Receiving notifications on iOS and Android is working.  At least I think so, need to test on a non-example program but I'm an optimist so I'm closing this issue for now.  Also updated the ReadMe on receiving notifications.


add location.hash

https://github.com/rackt/react-router/pull/1851

fixed by 9e416f92358a2d5bcc960635b792c09296582ac8

fixed by 9e416f92358a2d5bcc960635b792c09296582ac8


macOS: Don't include two windows in a11y tree.

What does the pull request do?
Previously due to the way we were handling the macOS accessibility/automation APIs, two Windows were showing up in the accessibility tree.
This fixes that so that there is only a single Window showing up. To do this, AvnRootAccessibilityElement has been removed and now AvnWindow handles the accessibility protocol itself, exposing its children via the AvnView.
The integration tests have been updated to no longer expect an extraneous Window in the automation tree.
As part of this working, I also started moving various classes outside of accessibility.mm/.h and into their own files to make navigation in xcode a little easier.
Before:

After:

This PR will conflcit with https://github.com/AvaloniaUI/Avalonia/pull/15800, so need to carefully decide which to merge first.


How can I see how much buying power I have?

Is there a way to do this with this API?

Just wanted to note that "Buying power" in the RH app is actually "unallocated_margin_cash" under "margin_balances" in get_account() response. At least for a margin account (might be different for cash account). I'm actually not sure what the "buying_power" value is yet.


Automatically upgrade configured asset root upon upgrading OpenGEE for install_fusion.sh

User Story
As a Open GEE user, I want a way to easily upgrade the asset root when upgrading GEE, so that I can avoid manual interactions during the upgrade.
AC

If there is a asset root configured, then upgrade THAT one and NO others - leave all others alone
Implement this in install_fusion.sh

Verification

Install previous version (e.g. 5.2.1)
test with a default asset-root (/gevol/assets)
test with a NON-default asset-root (e.g. /usr/local/google/gevol_test/assets)

Notes

The asset root configuration is stored in /gevol/assets/.config/volumes.xml
This same task, but for RPMs, will be written as a follow-on task (#759)
There is code already in install_fusion.sh to upgrade the default asset root. This task is to get the path from volumes.xml instead of hard-coded
You can use the geconfigureassetroot command to select a different asset root. Form more info see Relocate your asset root

It turns out the install script already has this capability


(do not merge) FACT-707-improve-acceptance-pre-suite

don't merge this.  still need to cherry-pick items from puppet pre-suite into here.
fix git install options
fix packages for solaris10 and unknown publisher for solaris11
workaround beaker env-issue by symlinking to required binaries out of PATH
gets facter acceptance running on sol10
makes it easier to spin up machines for manual testing or writing tests

Ping @er0ck. If this is bitrot, just close it. Or add a comment either way. Thanks!

@er0ck I'm gonna guess this is bitrot, so I'll close for now. Obviously feel very very free to re-open if I was off the mark!


native.tap(selector) doesn't work when circularProgressIndicator is active

Steps to reproduce

Clone https://github.com/bumper-visual/patrol_test and cd* into it
Start Android emulator (Pixel 4, API 31, Google Play)
Verify that the app builds fine: 'flutter build apk--debug
Run the integration test: patrol test --target integration_ test/example_test.dart*

Actual results
test will pass if we comment circularProgressIndicator
Logs
No response
Patrol version
patrol: 2.2.4
Patrol Doctor output
Patrol CLI version: 2.1.3
Program adb found in /opt/homebrew/bin/adb
Env var $ANDROID_HOME set to /Users/sasha/Library/Android/sdk
Program xcodebuild found in /usr/bin/xcodebuild
Program ideviceinstaller found in /opt/homebrew/bin/ideviceinstaller
Flutter Doctor output
[!] Flutter (Channel unknown, 3.7.10, on macOS 13.3.1 22E261 darwin-arm64, locale ru-UA)
! Flutter version 3.7.10 on channel unknown at /Users/sasha/development/flutter
Currently on an unknown channel. Run flutter channel to switch to an official channel.
If that doesn't fix the issue, reinstall Flutter by following instructions at
https://flutter.dev/docs/get-started/install.
! Unknown upstream repository.
Reinstall Flutter by following instructions at
https://flutter.dev/docs/get-started/install.
• Framework revision 4b12645012 (5 months ago), 2023-04-03 17:46:48 -0700
• Engine revision ec975089ac
• Dart version 2.19.6
• DevTools version 2.20.1
• If those were intentional, you can disregard the above warnings; however it is recommended
to use "git" directly to perform update checks and upgrades.
[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
• Android SDK at /Users/sasha/Library/Android/sdk
• Platform android-33, build-tools 31.0.0
• ANDROID_HOME = /Users/sasha/Library/Android/sdk
• Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
• Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)
• All Android licenses accepted.
[✓] Xcode - develop for iOS and macOS (Xcode 14.3.1)
• Xcode at /Applications/Xcode.app/Contents/Developer
• Build 14E300c
• CocoaPods version 1.12.1
[✗] Chrome - develop for the web (Cannot find Chrome executable at /Applications/Google
Chrome.app/Contents/MacOS/Google Chrome)
! Cannot find Chrome. Try setting CHROME_EXECUTABLE to a Chrome executable.
[✓] Android Studio (version 2021.2)
• Android Studio at /Applications/Android Studio.app/Contents
• Flutter plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/9212-flutter
• Dart plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/6351-dart
• Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)
[✓] Android Studio (version 2021.1)
• Android Studio at /Applications/Android Studio 2.app/Contents
• Flutter plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/9212-flutter
• Dart plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/6351-dart
• Java version OpenJDK Runtime Environment (build 11.0.11+0-b60-7772763)
[✓] VS Code (version 1.82.1)
• VS Code at /Applications/Visual Studio Code.app/Contents
• Flutter extension version 3.72.0
[✓] Connected device (1 available)
• macOS (desktop) • macos • darwin-arm64 • macOS 13.3.1 22E261 darwin-arm64
[✓] HTTP Host Availability
• All required HTTP hosts are available
! Doctor found issues in 2 categories.

But example_test doesn't contain a CircularProgressIndicator.

example_test shouldn't have CircularProgressIndicator
I use CircularProgressIndicator in my widget and Biometric dialog
and the test should tap on FloatingActionButton (to show Biometric dialog) and then dismiss it (press 'Cancel')
while Biometric dialog exists, CircularProgressIndicator is active
and the problem is that when I try native.tap(Selector('cancel')) test falls
but when I remove CircularProgressIndicator, everything works fine

Ah, forgive me, I read that issue too fast and thought you mean example_test in Patrol's repo.


HelpId for FormLayoutRow

I tried the text here https://www.openntf.org/main.nsf/project.xsp?r=project/XPages Extension Library/discussions/6A282A7062106AB686257E8F004845DA. This works, but the tooltip only displays the first time it you hover on the image. Subsequent times, Firebug shows the styling is applied, but the opacity is 0 (it's 1 the first time you hover on the tooltip). That explains why it's not showing, but I can't track down what's controlling it. (Domino 9.0.1 FP5, Ext Lib 16)
If the tooltip is not in the help facet, it works fine though. So it seems to be related to what helpId applies rather than the xe:tooltip component. I couldn't see anything obvious in com.ibm.xsp.extlib.controls that relates to opacity or the Dojo fadeIn effect (which also uses opacity).

You won't like my answer but "it works for me" :) Edited the XPagesExt NSF and tooltip worked fine repeatedly. Domino 9.0.1 FP5, ExtLib 16, Bootstrap3 or OneUI302 themes, Chrome or FF.
The opacity/fade-in is handled in Dojo code, in dijit.Tooltip:
// show it
domStyle.set(this.domNode, "opacity", 0);
this.fadeIn.play();

We extend dijit.Tooltip in extlib.dijit.Tooltip and then utilise that in the TooltipRenderer. In the bootstrap theme, it's further extended by extlib.responsive.dijit.xsp.bootstrap.Tooltip.
Here's the code I used, including copy-paste from the OpenNTF discussion.
<xe:formRow id="formRow1" label="First Name:" labelPosition="left">
    <xp:this.facets>
        <xp:span xp:key="help">
            <xp:image url="/.ibmxspres/.oneuiv302/oneuicompat/iconHelp16.png" alt="Help" id="helpImage1"></xp:image>
            <xe:tooltip id="tooltip1" for="helpImage1" label="Enter your first name."></xe:tooltip>
       </xp:span>
    </xp:this.facets>
    <xp:inputText id="inputText1" disableClientSideValidation="true"></xp:inputText>
</xe:formRow>

It seems for you that maybe fadeIn.play() isn't working on the second or more hovers, so it's just setting opacity to 0

Thanks, Brian. I'll try different databases and different browsers later and see if I can pinpoint what's different

The cause was CSS, possibly combined with long help text. I had a style specified ".form-table {width:100%}" which was forcing the help image to the far right of the screen. First time it shows, it displays above the help image, with the end of the tooltip to the left of the help image. Subsequent times the tooltip was displayed differently. When I just used Bootstrap_3 without my custom css, it appeared some way to the right (something else is coming into play for CSS as well, because the Form Table I have is in a custom control with fields extending much wider and this impacts the positioning as well, but just a Form Table dropped on the page appears differently). I think it's actually displaying, but off the screen.

Thanks Paul. There's some changes to the FormTable control Bootstrap rendering in the works for the next release. So keep an eye out for those in R17


Methods take &self but return &mut T

Some methods take an immutable reference to self and then return a mutable reference to a self derivative. This should be changed to take a mutable reference to self, while adding the corresponding immutable reference function.
This is currently blocked on the argument parser. Consider this example:
extern "C" fn example(ex: &mut ExecutionData, ret: &mut Zval) {
    let mut a = Arg::new("a", DataType::Long);
    let mut b = Arg::new("b", DataType::String);

    let parser = ArgParser::new(ex).arg(&mut a).arg(&mut b).parse();
                                ^^ immutable borrow happens here

    if parser.is_err() {
        return;
    }

    let this: &mut ZendClassObject<Example> = ex.get_object();
                                              ^^ mutable borrow happens here
}

ArgParser takes an &ExecutionData, and when parsed stores a reference to each arguments zval inside each argument, which has the same lifetime as ex. When we call ex.get_object(), we need to borrow mutably to mutate the underlying object, but &ExecutionData is still borrowed through the two arguments a and b.
Functions which exhibit this behaviour:

ExecutionData::get_object()
ExecutionData::get_self()

I'll have to think about this a bit as well.
But immediate thought is we might be able to avoid the problem by breaking apart ExecutionData into smaller chunks. While PHP stores everything in a single structure, we don't have to mirror that design - we could put separate accessors around each useful individual part of that structure and thus allow those borrows to have different lifetimes.
Same idea should work for globals as well.


Require mongo db but how to install?

Hi,
I started the backend server with main.py without installing mongodb.
It throws error when connecting mongodb in user_conversation_storage.get_user_conversation_storage()
It is trying to get os.getenv("MONGO_SERVER") as the db server.
However i do not know how to install mongodb and its schemas.
Can anyone help me on where to find the mongodb schema?

BTW, in frontend web, it says 'error fetch conversation list'.

I just found it in setup_script.sh ;-)


Update public organization page to show logos

This page should include the logos of the organizations and be a little more attractive
Suggest initially we create basic tiles which we then can tidy up with help of front end designer input

I think @stevejgordon hit some/all? of this with PR #906

I have started something basic on today's commute so you can re-assign back to me if you want.


[BUG] Not working as intended

README suggests to do this:
{
  "plugins": ["react-refresh"],
  "rules": {
    "react-refresh/only-export-components": "warn"
  }
}

But the plugin is doing the wrong exports, infact i only got it working by doing:
{
  "plugins": ["only-export-components"],
  "rules": {
    "only-export-components/only-export-components": "warn"
  }
}

The plugin name is based on the npm package. I think something is wrong in your setup. Do you have a small reproduction?

Sure, this is my usecase: https://github.com/AndreaPontrandolfo/sheriff/blob/master/configs/eslint.config.js#L536
I'm on the EslintFlatConfig.

Seems like you are using a namespace: https://eslint.org/blog/2022/08/new-config-system-part-2/#personalized-plugin-namespaces
The documentation is for the current configuration setup and I think it's fine for now because the flat config is still marked as experimental: https://eslint.org/docs/latest/user-guide/configuring/configuration-files-new
Closing as work as intended


re-integrate image generators

or something... they don't seem to be really integrated as it is. must dig in further

just need to be re-run with latest images


Observables to Buffer

I am using the latest version of your package. I'm trying to upload the generated buffer to my aws cloud. it looks like this:
...
    const file = this._pdfService.toBuffer('invoice', { locals: { invoice } });
    await this._fileService.uploadDocumentFile(file);
...

  public async uploadDocumentFile(buffer: any): Promise<string> {
    const date = format(new Date(), 'MM/yyyy');
    const key = `invoices/${date}`;

    await this._s3
      .putObject({
        Bucket: this.configService.get('AWS_PRIVATE_BUCKET_NAME_INVOICES'),
        Body: buffer,
        ACL: 'private',
        Key: key,
      })
      .promise();

    return key;
  }

Error:
InvalidParameterType: Expected params.Body to be a string, Buffer, Stream, Blob, or typed array object
How do I do that? I don't have much experience with RxJs

Okay, I solved it and thanks to you I found out more about Observable:)
  public async generateInvoice(invoice: InvoiceDto): Promise<any> {
    return this._pdfService
      .toBuffer('invoice', { locals: { invoice } })
      .subscribe(
        (file) => {
          this._fileService.uploadDocumentFile(file, invoice);
        },
        (error) => {
          throw new GenerateInvoiceInvalidException(error);
        },
      );
  }

However, this is not the best solution for me.
How else can I get just Buffer?

Hi @pietrzakadrian , you should probably try using this:
  public async generateInvoice(invoice: InvoiceDto): Promise<any> {
    const file = await this._pdfService
      .toBuffer('invoice', { locals: { invoice } })
      .toPromise();
    this._fileService.uploadDocumentFile(file, invoice);
  }

You can read more about it here.


Path to SettingsFile is not quoted

If a settings file is specified, the path is not quoted and therefore it fails if the path contains spaces.

I created a PR #30 for this (partially tested). I think this is quite a serious bug.

thanks! closing this as it is merged now


Typescript compilation error related to Trusted Types

Description
After updating from "lit": "^2.0.0-pre.2" to "lit": "^2.0.0-rc.1" my typescript project compilation fails with the following errors:
node_modules/lit-html/lit-html.d.ts:6:23 - error TS2688: Cannot find type definition file for 'trusted-types'.
 /// <reference types="trusted-types" />

node_modules/lit-html/lit-html.d.ts:66:8 - error TS2304: Cannot find name 'TrustedHTML'.
h: TrustedHTML;

Seems like default typescript DOM lib does not have TrustedTypes in them.

Thanks for the bug report, we should do something about this.
Two workarounds. You can install the TrustedTypes typings by running:
npm install "@types/trusted-types"

Or you can skip doing exhaustive type checking for dependencies by adding:
"skipLibCheck": true,

to the compilerOptions section of your tsconfig.json file

Fixed in<EMAIL_ADDRESS>Thank you for trying it out so quickly and filing such a clear and helpful bug!


BUG: Export to PDF creates corrupted files

Everything was working great yesterday.  Now today files are being truncated at 720KB file sizes which leads to a corrupted file.  If I export to PDF on a file that would generate a PDF smaller than 720KB it works ok.  I'm not seeing any JS errors in my console.  @benweet would you please check this out... I really need to update a document to keep production moving :)  Thanks!!

I solved my issue... still not sure what part of this was the problem though.
I was trying to regenerate a file that I had generated yesterday no problem... somehow today it was different.  I decided to try and scale up the Welcome document to over 720KB so that you could easily reproduce this... I concatenated the Welcome doc two more times (total of 3 copies) to generate an over 900KB file.  The thing is, it worked ok.
So I went back to mine and it was still failing.  I thought, how can I make it smaller? Reduce some of my image sizes.  So two of my images were really large pixel wise, and one was even a 1.1MB png.  I reduced the size of these from 3000px down to 1400 wide for one and 600px wide for the other.  That also reduced the file sizes.  Low and behold it worked, and generated a 1.4MB PDF.
Not sure if the backend service that generates PDFs changed recently and doesn't like larger images... but that's what it seems like.  FWIW I was also scaling and positioning the images in my markdown file with HTML originally, something like this:


Update priority descriptions

Internal review URL
@gewarren @BillWagner please review

Probably 😄

@tdykstra is this okay to merge?

#sign-off


A two player soccer inspired game but with the slight twist of teleportation. Score on the opponent by pushing the ball to win points. First to five wins!

How do you play your game?
Player one: WASD
Player two: IJKL

Code
Check off the items that are true.

[x] The game was made using the Sprig editor.
[x] The game is placed in the in the /games directory.
[x] The code is significantly different from all other games in the Sprig gallery (except for games labeled "demo").
[x] The game runs without errors.
[x] The name of the file/game contains only alphanumeric characters, -s, or _s.
[x] The game name is not the same as the others from gallery

Image (If an image is used)

[ ] The image is in the /games/img directory.
[ ] The name of the image matches the name of your file.

Thanks for your PR!

Thanks for your PR! Merry christmas! Where did you hear about Sprig?

Hi! Merry Christmas to you too! Just from a friend. Also, when can I expect
to have my game approved?
On Mon, Dec 25, 2023 at 7:38 PM Lucas @.***> wrote:

@.**** requested changes on this pull request.
Thanks for your PR! Merry christmas! Where did you hear about Sprig?
—
Reply to this email directly, view it on GitHub
https://github.com/hackclub/sprig/pull/1341#pullrequestreview-1795971923,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BE5MH5QQXEJP3U7MHIF7PXLYLIL6XAVCNFSM6AAAAABBCWJWOOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTOOJVHE3TCOJSGM
.
You are receiving this because you were mentioned.Message ID:
@.***>

when can I expect
to have my game approved?

Depends! Also - I think you closed this by accident, could you re-open?

Ah sorry! I don’t have experience with Git so how would I re open it?
On Tue, Dec 26, 2023 at 1:41 PM Lucas @.***> wrote:

when can I expect
to have my game approved?
Depends! Also - I think you closed this by accident, could you re-open?
—
Reply to this email directly, view it on GitHub
https://github.com/hackclub/sprig/pull/1341#issuecomment-1869712247, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/BE5MH5RKTDPKE2T44FCUOLDYLMK7NAVCNFSM6AAAAABBCWJWOOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNRZG4YTEMRUG4
.
You are receiving this because you modified the open/close state.Message
ID: @.***>

Ah sorry! I don’t have experience with Git so how would I re open it?
…
On Tue, Dec 26, 2023 at 1:41 PM Lucas @.> wrote: when can I expect to have my game approved? Depends! Also - I think you closed this by accident, could you re-open? — Reply to this email directly, view it on GitHub <#1341 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/BE5MH5RKTDPKE2T44FCUOLDYLMK7NAVCNFSM6AAAAABBCWJWOOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNRZG4YTEMRUG4 . You are receiving this because you modified the open/close state.Message ID: @.>

No worries! Just click on reopen button:)

Originally it was called “hope you have someone to play this game with”
since it’s a two player game. But that’s too long so “huff_ptegwu” :)
On Wed, Dec 27, 2023 at 3:45 PM Lucas @.***> wrote:

@.**** requested changes on this pull request.
Please re-check this:

The name of the file/game contains only alphanumeric characters, -s,
or _s.

Also - could you explain me why this name?
—
Reply to this email directly, view it on GitHub
https://github.com/hackclub/sprig/pull/1341#pullrequestreview-1797503177,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BE5MH5REKJ2ZF2Y5ADAXJFLYLSCGRAVCNFSM6AAAAABBCWJWOOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTOOJXGUYDGMJXG4
.
You are receiving this because you modified the open/close state.Message
ID: @.***>

oh nice! Just re-check this:

[ ] The name of the file/game contains only alphanumeric characters, -s, or _s.

Sorry, do you mean uncheck it and then check it again?
On Thu, Dec 28, 2023 at 12:48 PM Lucas @.***> wrote:

oh nice! Just re-check this:

The name of the file/game contains only alphanumeric characters, -s,
or _s.

—
Reply to this email directly, view it on GitHub
https://github.com/hackclub/sprig/pull/1341#issuecomment-1871376825, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/BE5MH5UKUUBDT7MVLQ6HZLLYLWWHRAVCNFSM6AAAAABBCWJWOOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNZRGM3TMOBSGU
.
You are receiving this because you modified the open/close state.Message
ID: @.***>

I meant please change your file to this be checked:)

Ok, I changed it. Is this good?

great thanks!
On Fri, Dec 29, 2023 at 7:44 PM Lucas @.***> wrote:

@.**** approved this pull request.
Perfect! Congrats:)
If you're a teen, you can get your sprig here!
https://sprig-order.hackclub.dev/
Hack Clubbers would love to see this! Just post a link and 1-2 sentences
talking about your game to our #ship
https://hackclub.slack.com/archives/C0M8PUPU6 channel
https://hackclub.com/slack/:)
—
Reply to this email directly, view it on GitHub
https://github.com/hackclub/sprig/pull/1341#pullrequestreview-1799263731,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BE5MH5RXAGKAEXTLGKFP4KLYL5PWRAVCNFSM6AAAAABBCWJWOOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTOOJZGI3DGNZTGE
.
You are receiving this because you modified the open/close state.Message
ID: @.***>


[SPARK-35037][SQL] Recognize sign before the interval string in literals

What changes were proposed in this pull request?

Extend SQL syntax rules to support a sign before the interval strings of ANSI year-month and day-time intervals.
Recognize - in AstBuilder and negate parsed intervals.

Why are the changes needed?
To conform to the SQL standard which allows a sign before the string interval, see "5.3 <literal>":
<interval literal> ::=
  INTERVAL [ <sign> ] <interval string> <interval qualifier>
<interval string> ::=
  <quote> <unquoted interval string> <quote>
<unquoted interval string> ::=
  [ <sign> ] { <year-month literal> | <day-time literal> }
<sign> ::=
    <plus sign>
  | <minus sign>

Does this PR introduce any user-facing change?
Should not because it just extends supported intervals syntax.
How was this patch tested?
By running new tests in interval.sql:
$ build/sbt "sql/testOnly *SQLQueryTestSuite -- -z interval.sql"

Test build #137239 has started for PR 32134 at commit 9b44a38.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41819/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41819/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41819/

Test build #137239 has finished for PR 32134 at commit 9b44a38.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137239/

The GA "Build and test / Scala 2.13 build with SBT (pull_request)" failed but I checked scala 2.13 locally:
$ ./dev/change-scala-version.sh 2.13
$ ./build/sbt -Pscala-2.13 compile
[success] Total time: 145 s (02:25), completed Apr 13, 2021 8:50:50 AM

Merging to master. Thank you @srowen for review.


Fix dependency plot showing Average of abs value

Signed-off-by: vinutha karanth<EMAIL_ADDRESS>
Description
we initialize with 'Average of absolute value' and corresponding data is shown in plot but just the dropdown doesn't show the above option.
One of the way to fix is to show 'Average of absolute value' as one of the drop down option as below along with other options.
Reviewed by Mehrnoosh.

Checklist

[x] I have added screenshots above for all UI changes.
[ ] I have added e2e tests for all UI changes.
[ ] Documentation was updated if it was needed.

Codecov Report

Merging #1765 (58d5f70) into main (4316b2d) will decrease coverage by 5.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1765      +/-   ##
==========================================
- Coverage   88.30%   83.25%   -5.06%
==========================================
  Files          89       19      -70
  Lines        5250      406    -4844
==========================================
- Hits         4636      338    -4298
+ Misses        614       68     -546

Flag
Coverage Δ

unittests
83.25% <ø> (-5.06%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...nalysis/erroranalysis/_internal/version_checker.py

responsibleai/responsibleai/feature_metadata.py

raiwidgets/raiwidgets/dashboard.py

raiwidgets/raiwidgets/interfaces.py

...dgets/raiwidgets/error_analysis_dashboard_input.py

...tools/error_analysis/dashboard_schemas/__init__.py

...sibleai/responsibleai/rai_insights/rai_insights.py

erroranalysis/erroranalysis/report/error_report.py

...ponsibleai/databalanceanalysis/balance_measures.py

...eai/responsibleai/databalanceanalysis/constants.py

... and 60 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Is there an E2E test for this which can validate this scenario?

Is there an E2E test for this which can validate this scenario?
I am planning to add it in coming PR. Just wanted to merge this for GA.


Option unwrap in CLI

I tried running sea-orm-cli generate entity on an existing PostgreSQL database and it panicked at https://github.com/SeaQL/sea-schema/blob/7099a2eaa10efb0eaacb07ff39b34dcb1510057a/src/postgres/parser/table_constraints.rs#L39. Backtrace:
thread 'main' panicked at 'called `Option::unwrap()` on a `None` value', /home/fenhl/.cargo/registry/src/github.com-1ecc6299db9ec823/sea-schema-0.2.7/src/postgres/parser/table_constraints.rs:39:47
stack backtrace:
   0: rust_begin_unwind
             at /rustc/c8dfcfe046a7680554bf4eb612bad840e7631c4b/library/std/src/panicking.rs:515:5
   1: core::panicking::panic_fmt
             at /rustc/c8dfcfe046a7680554bf4eb612bad840e7631c4b/library/core/src/panicking.rs:92:14
   2: core::panicking::panic
             at /rustc/c8dfcfe046a7680554bf4eb612bad840e7631c4b/library/core/src/panicking.rs:50:5
   3: <sea_schema::postgres::parser::table_constraints::TableConstraintsQueryResultParser as core::iter::traits::iterator::Iterator>::next
   4: <alloc::vec::Vec<T> as alloc::vec::spec_from_iter::SpecFromIter<T,I>>::from_iter
   5: <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll
   6: <futures_util::future::join_all::JoinAll<F> as core::future::future::Future>::poll
   7: sea_orm_cli::run_generate_command::{{closure}}
   8: <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll
   9: std::thread::local::LocalKey<T>::with
  10: <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll
  11: async_io::driver::block_on
  12: std::thread::local::LocalKey<T>::with
  13: async_std::task::builder::Builder::blocking
  14: sea_orm_cli::main
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.

Hi @fenhl, thank you so much for the issue.
We need more information to debug it. Would you mind...

Thank you so much in advance!!

We will include a verbose flag in sea-orm-cli to help debugging.

sea-orm-cli 0.2.2 released

Should I open a separate issue for my original problem?


Python 3.11 wheels

Hello!
Could it be possible to have wheels for Python 3.11 on PyPI? Thank you!
(And it could be possible to generate abi3 wheels, as in Brotli, to avoid the same problem in the future!)

it could be possible to generate abi3 wheels

I'd like that but I can't commit to this at the moment, if you would like to give it a try and send a PR you're welcome!
In the meantime I made https://github.com/fonttools/py-zopfli/pull/19 and https://github.com/google/brotli-wheels/pull/15 which should keep us going for a few more months


Error when installing (upgrading) existing (non ceedling) project

First of all, this is my first post on github.
We use many existing projects on which we wish to add unit tests using ceedling. our approach is to add the required files manually (files that are normally generated by ceedling using new). But we have an annoying issue if the project_x/test/support folder does not exist.
In some case we need to have tests in a custom folder. I have found on my ceedling 0.31.1 instance this annoying line:
# Genarate gitkeep in test support path
        FileUtils.touch(File.join(test_support_path, '.gitkeep'))

where test_support_path is hardcoded as test_support_path = File.join(name, 'test/support') a few lines above.
Why is the script failing when it can't touch this?
If it is absolutely necessary, is there a possibility to make this a part of the yml configuration? I don't think ceedling need to hardcode the test/ folder. tests can be anywhere as per the project.yml file.

I was able to reproduce this issue, let me update a little bit description:

Description
Upgrading existing project without existing /test/support folder cause build failure:
/usr/lib/ruby/3.0.0/fileutils.rb:1150:in `initialize': No such file or directory @ rb_sysopen - test_gcc_compile/test/support/.gitkeep (Errno::ENOENT)
	from /usr/lib/ruby/3.0.0/fileutils.rb:1150:in `open'
	from /usr/lib/ruby/3.0.0/fileutils.rb:1150:in `rescue in block in touch'
	from /usr/lib/ruby/3.0.0/fileutils.rb:1146:in `block in touch'
	from /usr/lib/ruby/3.0.0/fileutils.rb:1144:in `each'
	from /usr/lib/ruby/3.0.0/fileutils.rb:1144:in `touch'
	from /var/lib/gems/3.0.0/gems/ceedling-0.31.1/bin/ceedling:98:in `copy_assets_and_create_structure'

Steps to reproduce

In existing project folder delete test/support folder.
Run:  ceedling upgrade **<project_name>**

Actual Result:
/usr/lib/ruby/3.0.0/fileutils.rb:1150:in `initialize': No such file or directory @ rb_sysopen - test_gcc_compile/test/support/.gitkeep (Errno::ENOENT)
	from /usr/lib/ruby/3.0.0/fileutils.rb:1150:in `open'
	from /usr/lib/ruby/3.0.0/fileutils.rb:1150:in `rescue in block in touch'
	from /usr/lib/ruby/3.0.0/fileutils.rb:1146:in `block in touch'
	from /usr/lib/ruby/3.0.0/fileutils.rb:1144:in `each'
	from /usr/lib/ruby/3.0.0/fileutils.rb:1144:in `touch'
	from /var/lib/gems/3.0.0/gems/ceedling-0.31.1/bin/ceedling:98:in `copy_assets_and_create_structure'

Expected Result:
Unknown behaviour.

Hi @mvandervoord ,
Should Ceedling try to apply default settings at default. Try to create test/support folder or as it will feel more understandable:

load project.yml and check if the ```
:paths:
:supports:

- if the support key exists but point to another folder, the default location defined in https://github.com/ThrowTheSwitch/Ceedling/blob/master/bin/ceedling#L81 should be updated to defined in project.yml.

What is your opinion, how Ceedling should threat such of situation?

Hi @automat01  ,
Mentioned by you issue should be fixed in PR #738. If you will have time, can you check master branch and if fully solve your issue, can we close this this issue?
Kind Regards,
Lucas

Hi @lukzeg ,
Unfortunately , setting up to run ceedling from repo would require too much time for me to justify. You have described the problem really well and I have looked at #738 I think it should be fixed. I will definitely be checking out 0.32 release!
Thanks for your time.
Mathieu


AMBARI-23136: Continued: update execution_command to add two new apis

What changes were proposed in this pull request?
Add two apis
How was this patch tested?
Manually test

@adoroszlai I have updated the api name according to your comment

Installation via blueprint shows multiple errors in execution_command.  Have these been addressed?

@ncole those are being addressed in #892.  I would have preferred a single PR for the API + usage changes.  There were separate tasks originally, hence separate PRs I guess.

@ncole, the updated patch can fix your issue.

@adoroszlai You are right, that brings more convenience, unfortunately I worked on this package first, then that one.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/1652/
Test FAILed.
Test FAILured.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/1667/
Test FAILed.
Test FAILured.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/1674/
Test FAILed.
Test FAILured.


Implemented migration rollback.

Adjusted MigrationMigrateCommand::execute() with providing a new option migrate-to-version which allows defining the version to migrate database.
Adjusted MigrationStatusCommand::execute() with providing a new option last-version which allows receiving the last executed version of the migration.

Codecov Report
Base: 88.28% // Head: 67.33% // Decreases project coverage by -20.95% :warning:

Coverage data is based on head (73184ed) compared to base (49dc1ba).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@              Coverage Diff              @@
##             master    #1927       +/-   ##
=============================================
- Coverage     88.28%   67.33%   -20.96%
- Complexity     7951     7976       +25
=============================================
  Files           242      243        +1
  Lines         24211    24304       +93
=============================================
- Hits          21375    16365     -5010
- Misses         2836     7939     +5103

Flag
Coverage Δ

5-max
67.33% <0.00%> (-20.96%)
:arrow_down:

7.4
67.33% <0.00%> (-20.96%)
:arrow_down:

agnostic
67.33% <0.00%> (-0.27%)
:arrow_down:

mysql
?

pgsql
?

sqlite
?

Flags with carried forward coverage won't be shown. Click here to find out more.

 Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


back FmtStr objects with Blessed/Blessings colorstring output

We could do this before we switch to Blessed, but it'd be large.

The weakest version of this would be just ripping out termformatconstants.py, but there's a lot of other duplicated work too.
Another option would be completely doing away with our own internal representation, and reparsing terminal-formatted strings each time we do math with them.
FmtStrs are nice for doing things like "start with a line, then stick the text "hello" in bold into spaces 10-16 of it.  Cutting into it is going to be more complicated.

This sounds harder and less important than fixing the input code.

Most important is giving parsing input character sequences and understanding them via blessed - let's start with that

blocked on Blessed getting better parsing so that code can be used to produce FmtStrs


Perf improvements for get/search calls

Description

VersionId and LastUpdated will be set on POSTs
GET Resource calls will return the raw resource if VersionId and LastUpdated were already set in the raw resource. Otherwise, it will set them using System.Text.Json
Search calls will behave similar to GET calls. Bundles will be serialized using System.Text.Json as well.

Working on updating SQL persistence layer with the new columns that specify if VersionId and LastUpdated were set on the raw resource.
Related issues
Addresses [issue #].
Testing
All existing tests pass. A few tests added - will add more

This scenario looks broken:

POST new resource
GET by ID. Everything looks good. version = 1
PUT an update. In response, version =2. Looks good.
GET by ID. meta is missing from response.

On a PUT, we should optimistically set the version to 1 in the resource. In the stored procedure, if we see the actual version is not 1, then we can set rawResource.versionSet to false.

Nice job, @YazanMSFT! This is really great.


'vscode.executeHoverProvider' can return hover info from git lens

Issue Type: Bug
Bug

Install git lens

With an extension that executes vscode.executeHoverProvider at the current cursor position
You can use this extension to test this. It requests and displays hovers at the current cursor position (although it does have some caching so it will not always make new requests.

Open a tracked js file in a repo. Edit the file to have a line:

Array.from

Place your cursor on this line so that the git lens inline decorator shows up

Now request the hover contents at the end of the line (this would be a position such as  {_line: 0, _character: 10})
In the linked extension, you can make this request just by moving the cursor to the end of the line (again, the cursor must already be on the line so that the git lens inline decorater is showing)

Expected
Only hover contents from the code itself are returned
Actual
The contents from gitlens are also included (see the gravatar link):

VS Code version: Code - Insiders 1.50.0-insider (f943318042a3b9229049aea86cea04d0ff9c8210, 2020-09-23T05:28:07.760Z)
OS version: Darwin x64 19.6.0

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-7700K CPU @ 4.20GHz (8 x 4200)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmetal: disabled_offmultiple_raster_threads: enabled_onoop_rasterization: enabledopengl: enabled_onprotected_video_decode: unavailable_offrasterization: enabledskia_renderer: disabled_off_okvideo_decode: enabledwebgl: enabledwebgl2: enabled

Load (avg)
2, 2, 2

Memory (System)
40.00GB (0.77GB free)

Process Argv
-psn_0_5326100 --crash-reporter-id cefe23df-690f-4b1b-9ce9-e004d3be2745

Screen Reader
no

VM
0%

This is somewhat expected. We query all hover providers and return a joined result, there is no validation of the results. What we could add is a check that the hover range actually includes the given position - but for end of line positions that can get tricky...
@eamodio I assume that gitlens is a normal hover provider, right?

@jrieken  Yeah, GitLens uses HoverProviders for its hovers.

@eamodio What range does it use? I know you can hover over the decoration itself to trigger the hover, which I wouldn't expect to work with a HoverProvider since the decorations are not part of the file's normal text content

@mjbvz it depends on your settings (and current mode). You can choose to have the hovers always show over the whole line (then the range is for the full line), see here:

Closing as designed then


Distinction between group private messages and individual private messages

It would be nice if instead of having a single Private messages heading on the top-left that shows the combined notifications for all private one-on-one messages and all private group messages there would be two separate headings:

Private Messages
Group Messages

The problem my users have run into is a noisy group message prevents you from seeing that you have a new private one-on-one message from someone. Separating the two out would help distinguish between these two different kinds of messages.

Hmm I definitely see the use case here, but I'd worry a bit about complicating the UI by having a long list of left-sidebar filters.  This could be a case where an option to control whether those are separated in the UI makes sense, but I'd love to come up with something simpler.
OOC, have you thought about whether frequent, long, group private message conversations are a situation where you should be using an invite-only stream instead?

I think you're correct, long group private messages should be transitioned to be invite-only streams.

I was going to post a new issue but this seems similar. The problem I'm having is because of the way private group conversations are displayed on the left bar, I end up clicking an existing multiuser private message instead of sending only to one person.
The way it goes is I skim the names until I see the person I want and click and write. However because single and group messages are mixed (and not differentiated clearly) and only the first person's name is fully visible, it looks like the user I want when it's a group.
At the very least groups could be made a different color. I think a tiny icon with multiple people on it would be ideal.
If you're already doing something with avatars please let me know. None of my users have them.


Fix italian translation typo

Please ensure that your pull request meets the following requirements - thanks !

Follows our existing codestyle.
Does not break any unit tests.
Contains a reference to the issue that it fixes.
For cosmetic changes add one or multiple images, if possible.

We use Transifex for translations. Please make your changes there: https://www.transifex.com/k-9/k9mail/


Avoid TOCTOU for container verification

There is a race / Time-Of-Check-Time-Of-Use attack on container verification. When verifying a container name:tag, the verification may pass but the image that is pulled could have been changeed between the verification and the pull. We need to decide what to do about it:

Force users to pass container images by @sha256:xxx.

Pro: This is the most secure option
Cons:

We need to document which command for users to use (not a big deal I suppose), maybe with different tools (crane / docker / etc)
Not supported for GCB at the moment because GCB does not support storing the provenance along side the container. This will be supported in the future, though.

Let users pass mutable tag

Pros: easy for users.
Cons:

We need to provide a way for them to get the digest. We could print it to stdin (slsa-verifier ... | docker run). Or we could document how to use jq to grab the digest from provenance, assuming there is a single subject in the provenance: slsa-verifier ... -print-provenance | jq .. | docker run. If there are multiple subjects, the only viable solution is to print it to stdout.
There is a risk users forget to use the verified sha256. We can add this to our documentation, and also print a warning in stdout with a link to the documentation to avoid the attack.

Thoughts?
/cc @asraa @ianlewis

Force users to pass container images by @sha256:xxx.

This is what the slsa-github-generator generic container workflow is currently doing. However it splits the image name and tag into separate inputs in order to make it clear that this is necessary and ease validation.
Unfortunately the workflow wouldn't be able to use tags because we don't have the luxury of being able to specify piped commands to get the digest and avoid a TOCTOU. So if we went with option 2 for the verifier, in the case of the workflow you would build the image, use the sha to generate the SLSA and then verify with the tag. This might be a bit disjointed as a user experience.
However, In the case of the verifier I suppose option 2 would make sense for generators that use tags (like GCB currently). So by making one method easier, others might become worse UX 😕
Overall I support using option 1. It's more secure and you generally have to do this anyway with tools like cosign. But I understand the dilemma with regard to GCB.

I thought cosign does not force users to pass an immutable image, does it?

cosign will technically let you use the tag, but it assumes the image is already in the registry when you run cosign attest so the same TOCTOU occurs at build time too. The image tag could be modified between when the image is built and when cosign attest is run. So you need to use the digest.
Note: I think there is a --local option which gives cosign the ability to act on a local version of the image but in the case of the workflow, image build and provenance generation happen on separate job steps and thus separate VMs. For the other generic workflow we can upload a binary artifact to the workflow run (and pass the sha256sum for verification as as an input), but this isn't an option for container images.

Option 1 is fine with me to start with: we can always relax this requirement later if we wanted, whereas the other way around would be a breaking change.

+1. There is also no benefit to passing a tag besides compatibility with existing commands (maybe, which also might be susceptible to the same issues). We don't do any tag verification.
I'm not sure I understand the GCB issue of not having the provenance alongside?

actually you're right, Asra. We can still force users to use a @sha256:xxx container image to GCB for verification. Sorry I got confused. Let's start with option 1 then.

This is fixed. Before merging this PR, I wanted to ask about local images, ie those already pulled. Since they are local, they don't necessarily need to be pinned by hash. It's still dangerous. Bit I wanted to have your thoughts on the risk. In a multi-user environment, this could be risky... if the docker daemon does not differentiate between users. I'm pretty sure it does.
So it seems the risk is mostly a mistake by a developer, verifying then pulling a more recent version. This could also happen if the verifier and downloader are different daemon on the machine.
Any other thoughts?

Let's close.


re: disconnect event catch from MM && WalletConnevtV1

This looks good @snowwhitedev, thanks for cleaning this logic up.


ValidInputTypes is not enough, like type="number"

var ValidInputTypes = ['TEXT','PASSWORD','FILE','EMAIL','SEARCH','DATE'];
..........

@xialvjun can you make an exhaustive list of what's missing? Also don't hesitate to submit a PR

Would it be ok if I add these ones?:
number / month / week / time / datetime / datetime-local / tel / url

released as 1.1.0


decK CLI docs: Improve the Go → Markdown doc generation

Where is the problem?
Our decK CLI documentation is currently generated directly out of the Go code for decK. The output in the docs is the default markdown generated from a cobra command.
The default output for flags gets generated into one giant codeblock, which doesn't look great and is hard to read:

What is your suggestion?
Ideal format
We'd like the generated documentation to look like this:

Convert the command name into title metadata instead of a heading
Don't print the short description, only print the long description

 ---
 title: deck validate
 ---

The validate command reads the state file and ensures validity.
It reads all the specified state files and reports YAML/JSON
parsing issues. It also checks for foreign relationships
and alerts if there are broken relationships, or missing links present.
No communication takes places between decK and Kong during the execution of
this command.

Split out flags into definition list entries and their descriptions. For example, the options section for deck validate would look like this:

### Options

`-h`, `--help`
: Help for validate.

`--rbac-resources-only`
: Indicate that the state file(s) contain RBAC resources only (Kong Enterprise only)

`-s`, `--state <strings>`
: File(s) containing Kong's configuration. This flag can be specified multiple times for multiple files. Use '-' to read from stdin. (default [kong.yaml])

### SEE ALSO header should be ### See also

Files and references

decK repository

File that generates the docs
cmd files that the generator uses to generate the output

Cobra custom modules that we can use to customize the output: GenMarkdownCustom/GenMarkdownTreeCustom https://github.com/spf13/cobra/blob/master/doc/md_docs.go#L53
Output gets copied over into these files in the docs.konghq.com repository

Testing your changes
You can test any changes you make locally. Make sure you have set up the docs.konghq.com local dev environment, then go through the following steps:

Generate decK CLI doc:

Install Go (at least v1.16) on the machine where you want to generate the docs.
git clone Kong/deck, then navigate to this repo through your terminal.
Run make generate-cli-docs . This will generate docs into the docs/cli-docs directory in the repo.

Copy the generated files from the decK repo docs/cli-docs directory (except for deck_completion.go) into the docs.konghq.com repo, app/deck/1.7.x/reference directory.
Code of Conduct and Community Expectations

[X] I agree to follow this project's Code of Conduct
[X] I agree to abide by the Community Expectations

I am somewhat familiar with the decK CLI and will try to solve this problem. Starting to work on this.


Sync 'develop' with 'master'

What
Sync develop with master, otherwise we cannot create releases on this microservice
How to review
sense check it and ensure tests are :green_circle:
Who can review
Any ONS developer

Incorrect approach.


RuntimeError: CUDA error: invalid device ordinal

Describe the question

运行NER standard下的run_bert.py时报错如下：RuntimeError: CUDA error: invalid device ordinal，CUDA kernel errors might be asynchronously reported at some other API call,so the stacktrace below might be incorrect.
For debugging consider passing CUDA_LAUNCH_BLOCKING=1.
尝试将train.yaml中use_multi_gpu按照README_CN修改为True，cuda:1修改为0，没有效果。

Environment (please complete the following information):

OS: [ window]
Python Version [3.8]

Screenshots

If applicable, add screenshots to help explain your problem.

Additional context

Add any other context about the problem here.

可以尝试将CUDA_LAUNCH_BLOCKING设为1看进一步的报错信息


Could not import extension sphinx_tabs.tabs (exception: No module named 'pkg_resources')

Describe the bug
context
Sphinx build: https://github.com/schranz-search/schranz-search/actions/runs/7226815693/job/19693182370

Could not import extension sphinx_tabs.tabs (exception: No module named 'pkg_resources')

expectation
No error.
bug
But instead ___ happens
Here's an error message I ran into...
Run sphinx-build docs docs/_build
  sphinx-build docs docs/_build
  shell: /usr/bin/bash -e {0}
  env:
    pythonLocation: /opt/hostedtoolcache/Python/3.12.1/x64
    LD_LIBRARY_PATH: /opt/hostedtoolcache/Python/3.12.1/x64/lib
Running Sphinx v6.2.1

Extension error:
Could not import extension sphinx_tabs.tabs (exception: No module named 'pkg_resources')

problem
I think the problem is not related to sphinx tabs itself just about changes in the python ecosystem. But I don't know how to solve it. The issue appeared this week in my project, last build was 2023-11-23 (Python 3.12.0), maybe somebody has a hint what changed and make now the sphinx tabs crashing. Maybe it has todo with Python 3.12.1 release but not sure.
Reproduce the bug
Build steps are here: https://github.com/schranz-search/schranz-search/blob/0eef487d609d5e47e05b80cc6c5d060148b1fb56/.github/workflows/docs.yml#L28
List your environment
Not sure about this.

@alexander-schranz please could you update to the latest version, e.g. using pip install -U sphinx-tabs? We no longer depend on pkg_resources so this should sort the error

Failing that, it looks like Python 12 no longer includes setuptools. So pip install setuptools might help.
If others also find this is the case, we might need to include setuptools as a dependency to support Python 12 properly

@foster999 in my case require setuptools did fix it: https://github.com/schranz-search/schranz-search/blob/0.3/docs/requirements.txt


Added GPT-3 Tailwind CSS code generator

Added GPT-3 Tailwind CSS code generator

Thank you and take care 🤗


tracer testkit

continuation of https://github.com/typelevel/otel4s/pull/254
had to restart due to an attempt at git magic.

Did not see there's already an assigned open issue on this. Will close this

I think I've misunderstood the open issue for tracer sdk


Disable coverage by default

Describe the feature
First of all, thank you for this amazing action 🙌
Xdebug and PCOV are enabled by default causing a lot of jobs to run slower than needed. This can easily be disabled with coverage: none. But the problem is, most people copy the default snippet and don't realize it.
I just discovered that my phpunit job runs 3 minutes faster, composer-require-checker 3 minutes faster and probably more tools as well.
Now multiply this by ±50-100 builds / day a year long for our organization. That's a lot of wasted CPU time and thus CO2 emissions 🌏 .
I understand you cannot just change the default value, but maybe good to change this for the next major version?  🙏
And maybe we can update the readme so that every snippet has coverage: none? If people need coverage, they know how and what to alter.

Yes, this is planned for v3 and is noted in the to-do list we have for it.
https://github.com/shivammathur/setup-php/projects/1#column-6419035
Xdebug is enabled by default in the GitHub Action Ubuntu images, not something that setup-php enables. If you would like that to change, please create an issue in actions/virtual-environments.
With v3 if this is not changed on the images, setup-php will disable Xdebug.
Adding coverage: none to every snippet is not a good idea as those snippets might be used in workflows that collect code coverage and this would cause confusion. I have tried to improve the coverage section and make this more clear in https://github.com/shivammathur/setup-php/commit/7dadf1bf21e925ed3ae1f75c9849ad283eba735.


Minor grammar fixes

give → gives
access → accessed
are translated → is translated
exe.md).Like → exe.md). Like

Addressed the review comment.
This options → This option

Hi, @rpetrusha, @jzeferino. I updated the pull request with regard to your suggestion. I guess @rpetrusha's variant is more easily read.


Context menu with custom items

How can I add new items to context menu?
For example:

Expand all / Collapse all children nodes
Move node to other parent

This is well documented here in the repo, in the groups page and on jstree.com - check the contextmenu.items option.


Minor text changes

Thank you @alexravenna! And apologies for my delay on getting these updates merged.  Looks great and appreciate the clean up work.

@mattwojo Don't worry about it, it was my pleasure to give back a little!


osu-lazer: 2020.1121.0 -> 2020.1128.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for osu-lazer is: "Rhythm is just a click away"
meta.homepage for osu-lazer is: "https://osu.ppy.sh"
meta.changelog for osu-lazer is: ""
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 2020.1128.0 with grep in /nix/store/wm11hzhrfqgqa6f8569r2sj9zg90zjn4-osu-lazer-2020.1128.0

directory tree listing: https://gist.github.com/192a2452188235954d5be4419d4be47b

du listing: https://gist.github.com/f600c9391b456f9fa8f921e0a461fc9e

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
0 i686-linux rebuild(s)
0 x86_64-darwin rebuild(s)
0 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
osu-lazer

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/wm11hzhrfqgqa6f8569r2sj9zg90zjn4-osu-lazer-2020.1128.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A osu-lazer https://github.com/r-ryantm/nixpkgs/archive/df4f8c6ddb5993a144acdfdef025b7dbd8353edf.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/wm11hzhrfqgqa6f8569r2sj9zg90zjn4-osu-lazer-2020.1128.0
ls -la /nix/store/wm11hzhrfqgqa6f8569r2sj9zg90zjn4-osu-lazer-2020.1128.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review 1

1 package built:

osu-lazer

Maintainer pings
cc @oxalica for testing.

Result of nixpkgs-review pr 105542 run on x86_64-linux 1

1 package built:

osu-lazer


Issue with SplashScreen

From<EMAIL_ADDRESS>on November 04, 2010 09:32:08
What steps will reproduce the problem? 1. Create an Activity that will be the SplashScreen
2. In the onStart method add a 3 secs sleep
3. After the sleep use startActivity and move to another Activity
3. Test the app using assertCurrentActivity What is the expected output? What do you see instead? solo.assertCurrentActivity("Correct activity did not appear.", SplashActivity.class); should pass but the logs say:
junit.framework.ComparisonFailure: Correct activity did not appear. expected:<...Splash...> but was:<...Home...> What version of the product are you using? On what operating system? 1.8.0
macos
Original issue: http://code.google.com/p/robotium/issues/detail?id=26

From<EMAIL_ADDRESS>on November 05, 2010 05:07:39
Correct activity did not appear. expected:<...Splash...> but was:<...Home...>
I guess that the Activity that is opened after the splash screen is <...Home...>?
Owner: renasreda

From<EMAIL_ADDRESS>on November 05, 2010 05:14:10
Exactly. I know that using a sleep is not good but I would like to know why this test fails.
Some questions:

When is solo.assertCurrentActivity executed?
Leaving the UI thread alone will fix this issue?

From<EMAIL_ADDRESS>on November 05, 2010 05:34:24
It gets executed after the Home activity is active. By the time assertCurrentActivity() gets executed the Splash activity is no longer active. Usually the problem is the opposite. Please see this thread: http://groups.google.com/group/robotium-developers/browse_thread/thread/79a70038c16e35e6/f08a0d9733982a59?lnk=gst&q=getCurrentActivity#f08a0d9733982a59 In both cases there is unfortunately nothing we can do about it. It takes some time for Robotium to load and the activityMonitor to start registering a new Activity. If a new Activity is not registered then it will think that it is still on the Splash activity. In your case the sleep() prevents that and gives time to Robotium to register the new Home activity before assertCurrentActivity() is executed.
Thanks for reporting this. As I said earlier this is a known limitation which we can not do anything about.
Status: WontFix

From<EMAIL_ADDRESS>on November 05, 2010 05:49:46
renasreda: Thanks for your reply.
What would you recommend? Leave the SplashScreen untested?
Thanks.

From<EMAIL_ADDRESS>on November 05, 2010 05:53:57
Yes, that is what I would do. I would use assertCurrentActivity() on the Home activity instead. And then take it from there.

From<EMAIL_ADDRESS>on November 05, 2010 06:05:46
Cool, thanks for the support.


About Packet Fragmentation

Automatic small packets merging
Automatic fragmentation of reliable packets
Automatic MTU detection
Regarding these 3 features I switched from my fragmentation and reassembling UDP package mechanism to this library. But I couldn't see the automatic part of the library in the example. I want to send a kinda big chunk of data (a texture, with dynamic resolution). Can you provide an example script? Thank you.
Edit: I forgot to add that when I try to send all the package in Send function thinking it parses automatically, it gave me "The output byte buffer is too small to contain the encoded data, encoding 'Unicode (UTF-8)' fallback 'System.Text.EncoderExceptionFallback'."

@DenizYunus it works automatically when you use ReliableOrdered or ReliableUnordered messages. Just send large byte array - and you will receive it as one large packet
Don't use text for this. Use PutBytesWithLength or just PutBytes and get length from NetPacketReader.UserDataSize
Also for questions better use Discord chat https://discord.gg/FATFPdy


Bug Fix : Fatal Exception: NSInternalInconsistencyException

While switching between tabs by swiping and tab tapped, App getting crash.
Error log as below.
Fatal Exception: NSInternalInconsistencyException
No view controller managing visible view <UIView: 0x12f430fc0; frame = (0 0; 375 504.5); autoresize = W+RM+H+BM; layer = <CALayer: 0x12f430bb0>>

I found similar problem in stack overflow and fixed it.
Best regards,

Thanks!!!!


[1.1.5] IDE freezes sometimes when loading autocomplete/intellisense for localization

Stays like this, prior to 1.1.5 the IDE still froze but had another popup waiting for the threads and usually would unfreeze at the end.

CPU usage is at 0% when the IDE freezes this way.

Kill IDE and restart to get the IDE error log, then put it here.

Hmmm...the IDE error log may not be easy to get.
Should profiling and check plugin code later at 1.1.6.

Tested at 1.1.6 after some optimization, shold not be a very serious performance problem.

It's optimized but I met a IDE freeze during debugging sometimes, if you meet it after 1.1.6 is published, create another issue.


⚠ Bofrost.lu has degraded performance

In 617f641, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1404 ms

Resolved: Bofrost.lu performance has improved in 49986a6 after 1 minute.


[ELWGOLF] Electronic Fairways - Putting crashes module, and math seems off on swings

Module Information

Identifier: ELWGOLF
Module Name: Electronic Fairways
Version: 2.0

Describe the bug
Putting crashes module, and math seems off on swings ("Your shot went 3 yards") -- which is the same distance to the cup ?
To Reproduce
Steps to reproduce the behavior:

Enter Module
(P)lay Game
Select club and strength, Pick Club, Select Strength, Select Putt Strength
See error

Expected behavior
Ability to play through a shot
Screenshots
Unhandled exception. System.ArgumentOutOfRangeException: Specified argument was out of the range of valid values. (Parameter 'Unsupported OpCode: Fsubrp')
   at MBBSEmu.HostProcess.ExecutionUnits.ExecutionUnit.Execute(IntPtr16 entryPoint, UInt16 channelNumber, Boolean simulateCallFar, Boolean bypassState, Queue`1 initialStackValues, UInt16 initialStackPointer)
   at MBBSEmu.Module.MbbsModule.Execute(IntPtr16 entryPoint, UInt16 channelNumber, Boolean simulateCallFar, Boolean bypassSetState, Queue`1 initialStackValues, UInt16 initialStackPointer)
   at MBBSEmu.HostProcess.MbbsHost.WorkerThread()
   at System.Threading.ThreadHelper.ThreadStart_Context(Object state)
   at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
--- End of stack trace from previous location where exception was thrown ---
   at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
   at System.Threading.ThreadHelper.ThreadStart()

Software Information:

OS: Windows 2019 Server Standard
Telnet Client: NetRunner

Need to add the opcode FSUBRP and finish writing Unit Tests for all the remaining Floating Point operations


Function Calling doesn't seem to be working with Direct Connection

Hey good folks.
I'm struggling with function calling...
DOM
    <deep-chat       id="chat-element"       textInput='{"placeholder":{"text": "Welcome to the demo!"}}'     ></deep-chat>
      openAI: {
        key: "{redacted}",
        chat: {
          tools: [ `
            {
              type: "function",
              function: {
                name: "setFormFields",
                description:
                  "Sets the form fields with an array of values provided by user",
                parameters: [
                  {
                    name: "formFields",
                    type: "array",
                    description:
                      "An array of objects with field names and values",
                  },
                ],
              },
            },
          ],
          tool_choice: "auto",
          function_handler: (functionsDetails) => {
            return functionsDetails.map((functionDetails) => {
              return {
                response: getCurrentWeather(functionDetails.arguments),
              };
            });
          },
          max_tokens: 2000,
          system_prompt: "system_prompt",
        },
      },
    };

    elementRef.setAttribute(
      "directConnection",
      JSON.stringify(directConnection)
    );

And in the chat I get the following error.

So its saying I'm missing the function_handler but it is on the object.
However the way the direct connection is passed in using JSON stringification is likely to destroy any function on an object so wondering what I'm doing wrong here?
Many thanks for your help.

@OvidijusParsiunas That did the job thanks very much!


Append picker popup to document.body to avoid being clipped by parent's overflow: hidden style.

Reference Element Plus's ColorPicker compoent.

Are there any plans of doing it? It doesn't play well when used in combination with frameworks like Vuetify.

@fluentos I might add it eventually, maybe even sooner than later. But at this time I can only suggest positioning the element outside of container with overflow: hidden, or using a different component which supports the described use case

Implemented in v2

Implemented in v2

Works like a charm! Thank you a lot!


Bot/log disposal fix

Previously, if the bot was forcibly, or even due to an error stopped
and then started again without restarting the entire application, the
program would throw an error while trying to write to the log file,
because it was still open.
The function for the disposal was already properly defined, but never
called if the GC never picked it up, since it's only called in the destructor (which it did not on my machine).

Basically, this forces the bot manager to dispose of the bot and its log without having to wait for GC to pick it up, which may sometimes take a long time.

Ya the GC doesn't seem to like SteamBot's while loop running on the main thread.

Seems minor, I'll just merge


Highlighting range of text dynamically

Hi, Thank you for such an awesome package , I am wondering  if there is a way that I could highlight a range of text while typing

@ramisalem currently the option is not available in this package. But will find a workaround for this feature

@DaniAkash Thanks, I am still looking for it. Is there any other option, I can use,
I mean any other editor that supports React-native

@DaniAkash Thanks, I am still looking for it. Is there any other option, I can use,
I mean any other editor that supports React-native

Hi Rami, I'm planning on a major revamp for this project in March. In the mean time, you can try CN Rich Text Editor. It has highlighting support 👍
I'll try to add highlighting option to the new version.

@DaniAkash  Hi, that would be really great.


Feature/select extend props

It will close #441

Codecov Report
Patch coverage: 100.00% and no project coverage change.

Comparison is base (bf81874) 100.00% compared to head (e7e9ff6) 100.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@              Coverage Diff              @@
##           release/0.7      #444   +/-   ##
=============================================
  Coverage       100.00%   100.00%
=============================================
  Files               50        50
  Lines             1092      1093    +1
  Branches           438       439    +1
=============================================
+ Hits              1092      1093    +1

Impacted Files
Coverage Δ

src/formSelect/FormSelect.tsx
100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Mailpit shows wrong version in about.

we've verified that we are using 1.20.7 yet it says its 1.20.6

how can we see whats going on?

Hey @N6REJ. This same thing happened to you before in #357. The release version numbers are set automatically as the release is being compiled and packaged, so this is not technically possible - if you downloaded and installed 1.20.7 then that is what it is.
You can verify on the commandline (in the directory with the mailpit.exe file) by running mailpit version. If that shows you the correct version but the web interface doesn't, then you need to restart your stack because you somehow still have the old version running in memory. If however that is showing you an older version, then you have downloaded the wrong version.

If you need additional support, please provide me the link to your version and I can then manually compare and verify with what's on GitHub in the releases. Thanks.

Sorry to have bothered you.  I looked for the other ticket cause I remembered this happening once before.
I've no clue how but somehow we had the wrong version from your release.

No worries. Seeing as this is the second time this has happened (and assuming they were caused by the same issue), I'm curious as to how you are configuring your versions in the app - it is an automated or manual process?


null child

I'm getting the following errors when I try to use use either of the demo examples. Clean starter kit project with Polymer 1.7.1, installed using Bower.
Uncaught TypeError: Cannot read property 'children' of null
at HTMLElement.getTotalItems (paper-carousel.html:13)
at HTMLElement._setContainerSize (paper-carousel.html:13)
at HTMLElement._onResize (paper-carousel.html:13)
at HTMLElement.handler (polymer.html:560)
at HTMLElement.fire (polymer.html:1337)
at HTMLElement._fireResize (iron-resizable-behavior.html:151)
at HTMLElement.notifyResize (iron-resizable-behavior.html:101)
at HTMLElement._notifyDescendant (iron-resizable-behavior.html:190)
at HTMLElement._onIronRequestResizeNotifications (iron-resizable-behavior.html:170)
at HTMLElement.handler (polymer.html:560)
paper-carousel.html:13 Uncaught TypeError: Cannot read property 'children' of null
at HTMLElement.getTotalItems (http://localhost:8080/bower_components/paper-carousel/paper-carousel.html:13:682)
at HTMLElement._setContainerSize (http://localhost:8080/bower_components/paper-carousel/paper-carousel.html:13:3363)
at HTMLElement._onResize (http://localhost:8080/bower_components/paper-carousel/paper-carousel.html:13:8548)
at HTMLElement.handler (http://localhost:8080/bower_components/polymer/polymer.html:560:17)
at HTMLElement.fire (http://localhost:8080/bower_components/polymer/polymer.html:1337:6)
at HTMLElement._fireResize (http://localhost:8080/bower_components/iron-resizable-behavior/iron-resizable-behavior.html:151:12)
at HTMLElement.notifyResize (http://localhost:8080/bower_components/iron-resizable-behavior/iron-resizable-behavior.html:101:12)
at HTMLElement._notifyDescendant (http://localhost:8080/bower_components/iron-resizable-behavior/iron-resizable-behavior.html:190:18)
at HTMLElement. (http://localhost:8080/bower_components/iron-resizable-behavior/iron-resizable-behavior.html:97:16)
at Array.forEach (native)

hello,
if your problem Finished ? because I got the same problem.

+1 Same

Hello,
I have been testing the component on polymer-starter-kit.
I discovered that the polymer-starter-kit has shadow-dom usage activated, but our component is not ready to work directly with the shadow-dom.
Given the low compatibility of shadow-dom we do not plan on adapting the component to work on it at this moment.
To use our component you will have to disable the use of shadow-dom in the polymer configuration.
In the index.html file you must modify the following line of code:
From:
// Setup Polymer options
window.Polymer = {
    dom: 'shadow',
    lazyRegister: true
};

To:
// Setup Polymer options
window.Polymer = {
    dom: 'shady',
    lazyRegister: true
};

Thank you for your contribution

I've been mainly using shadow dom but shady might be the way to go for performance. I'll take another look.  Thanks.

Considering chrome and opera already support Shadow DOM V1, safari is fixing bugs in its implementation and firefox is currently developing it, I highly suggest you put this back on your backlog.
On the shady dom polyfill, this seems a pretty decent component to use, but it's unusable on standard polymer apps since it breaks the rule of polyfilling browsers only when necessary. Using this component means I have to polyfill for shady dom all the time.

Keep in mind that in Polymer 2, shadow dom is the standard. Shady dom will likely be deprecated for the next release, as browsers support shadow dom natively.


Disappeared SVG tags use in IE10 - IE11.

I am using svg through tag use and IE10 - IE11 have removed all of them(react-lite@0.15.27).
Got from server:
<svg class="icon-twitter" width="16px" height="16px" data-reactid="8"><use xlink:href="#twitter" /></svg>.
Got after react-lite applying:
<svg class="icon-twitter" width="16px" height="16px" data-reactid="8"></svg>.
In the same time<EMAIL_ADDRESS>has no this problem, all my SVG were displayed correctly.

thx feedback, I will check this problem and try to fixed it as soon.

@zazagag It seems like JSX don't support namespace xlink:href, and both react and react-lite ignore xlink:href

I found it just work the same as react.
import React, { Component } from 'react-lite'
import ReactDOM from 'react-lite'

function Test() {
	return (
		<svg className="icon-twitter" width="16px" height="16px">
			<use xlinkHref="#twitter" />
		</svg>
	)
}

ReactDOM.render(
	<Test />,
	document.getElementById('root')
)

In fact, react-lite will replace the whole dom tree from the server-side with the new dom tree, and data-reactid="8" will not appeare, so I think maybe something else cause the problem.


Renaming --identity to --authority in bench-tps

Problem
The keypair in bench-tps is used to fund accounts in benchmarking, so it should be renamed to --authority
Summary of Changes
Deprecated use of --identity. Substituted argument to --authority in tests. Currently, both names are usable.
Fixes https://github.com/solana-labs/solana/issues/30145

@KirillLykov @CriesofCarrots requesting your reviews.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 82.7%. Comparing base (94af1aa) to head (46309b0).
Report is 9 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #1435    +/-   ##
========================================
  Coverage    82.7%    82.7%
========================================
  Files         872      872
  Lines      370361   370389    +28
========================================
+ Hits       306478   306592   +114
+ Misses      63883    63797    -86

@kubanemil yes, something like that would fit.
Regarding where it is used: in multinode-demo and some other shell scripts. Checkout particular places with grep -nr "\-\-identity" --include "*.sh".

I have checked out each shell script that uses identity as a CLI argument, none of them uses it for solana-bench-tps, they are used mostly as $ validator --identity.

I have checked out each shell script that uses identity as a CLI argument, none of them uses it for solana-bench-tps, they are used mostly as $ validator --identity.

you are right. In this case, less work

done


Mysql Server Connection is sleeping

Hi,
I´ve installed onlyoffice communityserver on debian 9 and created an own mariadb database on the same server (running at localhost). The docker log of the community server is showing the following:
+ log_debug 'Mysql check connection for <IP_ADDRESS>'
+ echo 'onlyoffice: [Debug] Mysql check connection for <IP_ADDRESS>'
onlyoffice: [Debug] Mysql check connection for <IP_ADDRESS>
+ mysqladmin ping -h <IP_ADDRESS> -P 3306 -u onlyoffice --password=xyz --silent
+ sleep 1

I don´t know, what I´m doing wrong? I´ve created an empty database and the user onlyoffice has all rights on this database.
 Has anyone a hint, why the mysql connection is sleeping?

Hello @benhartwich  sorry for a late answer. Why you don't want run mysql in the same docker container? Connection from container to host machine is difficult. We recommend to you run all in docker containers.

Hi,
thanks for your answer. But how can I ensure, that the mysql database is backup on a docker pull / update of your software?

If you mapped folders to host (-v parameter) - all data stored on host machine. On update you create a new containers with the same -v parameters.

Can you show me an example please, which should be working? My database is on the same machine, but outside of the docker container.
I´ve tried the startup command posted above without any mysql settings, but it doesnt work either.

We describe in this section. If you want to move data from host mysql to docker mysql - just copy corresponding folders.
If you run docker containers for the first time and by default - we recommend use our script opensource-install.sh

Thanks, got it running without the mysql settings! Error was on my site!


Add txt_name & txt_value fields (DNS validation) to CustomHostname struct

Description
Adds txt_name and txt_value fields to CustomHostname struct that are needed for SSL Verification when using the txt method
Has your change been tested?
No unit tests yet. Unsure if needed.
Types of changes
What sort of change does your code introduce/modify?

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

unit tests please. you should be able to update existing HTTP mock responses and assert the struct values match.

Added!

Note I've added it as a seperate test as all the other tests used HTTP validation.

thanking you! 👏


chore(vm):  cluster mode

PR Type
enhancement, configuration changes

Description

Added HelmRelease configuration for VictoriaMetrics cluster, enabling cluster mode with specific resource and storage settings.
Updated DNS names and external DNS hostname annotations to include VictoriaMetrics components.
Added HTTPRoute configurations for VictoriaMetrics components to manage routing.
Enabled alertmanager with Slack integration for monitoring alerts.
Switched from vmsingle to vmcluster configuration in Kustomization.
Updated roleId for Vault approle authentication to reflect platform recreation.

Changes walkthrough 📝
Relevant filesConfiguration changes

platform-private-gateway-certificate.yamlUpdate DNS names for VictoriaMetrics components

infrastructure/base/gapi/platform-private-gateway-certificate.yaml

Added new DNS names for VictoriaMetrics components.

+4/-1

platform-private-gateway.yamlUpdate external DNS hostnames for VictoriaMetrics

infrastructure/base/gapi/platform-private-gateway.yaml
Updated external DNS hostname annotations to include VictoriaMetrics components.

+1/-1

helmrelease-vmsingle.yamlAdd default rules with dashboard annotations

observability/base/victoria-metrics-k8s-stack/helmrelease-vmsingle.yaml

Added default rules with dashboard annotations.

+6/-0

httproute-vmsingle.yamlUpdate hostname for vmsingle HTTPRoute

observability/base/victoria-metrics-k8s-stack/httproute-vmsingle.yaml

Updated hostname for vmsingle HTTPRoute.

+1/-1

kustomization.yamlSwitch to vmcluster configuration in Kustomization

observability/base/victoria-metrics-k8s-stack/kustomization.yaml
Switched from vmsingle to vmcluster configuration.  Updated resources to include vmcluster-specific files.

+12/-4

vault-clusterissuer.yamlUpdate roleId for Vault approle authentication

security/base/cert-manager/vault-clusterissuer.yaml

Updated roleId for Vault approle authentication.

+1/-1

Enhancement

helmrelease-vmcluster.yamlAdd HelmRelease configuration for VictoriaMetrics cluster

observability/base/victoria-metrics-k8s-stack/helmrelease-vmcluster.yaml
Added HelmRelease configuration for VictoriaMetrics cluster.  Configured resources, storage, and affinity for vmstorage, vmselect, and vminsert.  Enabled alertmanager and configured Slack integration.

+243/-0

httproute-vmcluster.yamlAdd HTTPRoute configurations for VictoriaMetrics components

observability/base/victoria-metrics-k8s-stack/httproute-vmcluster.yaml

Added HTTPRoute configurations for VictoriaMetrics components.

+77/-0

💡 PR-Agent usage:
Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

I still have an issue with the redirection for https://vmui.priv.cloud.ogenki.io

/describe


Secrets? What are secrets? And other such existential questions.

This is not clear yet. There was a guy on Intercom today very frustrated with how the docs didn't mention that secrets had to be edited differently. He was trying to change notify conf, and shahidh had to take him step by step through the entire thing.
@ecthiender

Content seems to be there.  Creating separate issue to track usability/discoverability of the page.

Updated link:  https://docs.platform.hasura.io/0.15/platform/manual/project/secrets/index.html


bgpv1: Extend the timeout for the Test_NeighborAddDel test

After the recent GoBGP version upgrade the Test_NeighborAddDel test takes a bit longer than it used to.
Still analyzing why exactly, but extending the timeout to 1 min should be enough to avoid CI issues.
Fixes: #25968

/test

k8s-1.26-kernel-net-next failed due to #25958, unrelated. This looks ready to merge?

yes, ready to merge


fix version generation on uncommon clones

In our pipelines we usually do git clone --depth <somdepth>  that causes go-semrel failures as it is not able to know which is the current version even if a git fetch --tags has been done in the repository. The only alternative is to clone the whole repository history or raise the depth value.
This PR makes possible to extract the current version from the current slice of tags in the repository after sort it out. I create the aux i variable in the loop because is way cheaper than call append in each iteration.

Thinking about it, this approach is just very aggressive as it will just ignore if the tag was created in another branch or not, it might be perfectly fine that the version is v0.1.0  even if there are tags in the repository. I gave it a good thinking but I don't really see an elegant and adequate way of solving the issue so I am closing this PR


feat: add changelog generation tooling

Fixes https://github.com/kubewarden/kubewarden-controller/issues/26
After this is merged, I will run this mechanism and create the initial CHANGELOG.md with a tagged release.

Is there a way to change the automatically generated changelog?
Sometimes is not a good idea to leave all the commit messages inside of it

Sometimes is not a good idea to leave all the commit messages inside of it

Since we are providing in the configuration a list of filters (https://github.com/kubewarden/kubewarden-controller/pull/27/commits/1a21af8313773768f0067961f9b1d85a3d088d64#diff-f27299617f81a75a6e22804bf0f13d035bf301b7a2b5ee7906bdda95be97055dR10-R13), you need to prefix your commit headline with any of those: feat, fix, perf or refactor.
Any other commit won't be included in the changelog. By default, the tool includes pull request merge commits. If we consider it's noisy and don't have value we can remove that part, but I wanted to give it a try and decide later on with the experience. If you have a different opinion we can update the behavior.

I'm fine with making a test, I just fear this will always let something slip into the changelog. When that happens I would like the ability to manually fix it.
Would that be doable?

Would that be doable?

Not at this time. The only source of truth is the repo, and the contents are regenerated from scratch on every run.

Merging as discussed, we plan to separate the changelog and the release notes.


Detecting a tap on the banner

Is there an easy way to detect a tap on the banner in order to take an action if it was tapped or not.

You can use the completion handler to take an action:
.toast(isPresenting: $showAlert, duration: 2, tapToDismiss: true, alert: {
   //AlertToast Goes Here
}, completion: { dismissed in
   //Completion block after dismiss (returns true)
})

Hope this answers your question.

I tried that, but it's always called with true. So I can't differentiate between user tapping on to dismiss, or it just being auto dismissed after 2 seconds. The same complexion handler is called on both occasions.

I've now added a new handler onTap that you can use.
.toast(isPresenting: $showAlert, duration: 2, tapToDismiss: true, alert: {
   //AlertToast Goes Here
}, onTap: {
 //On tap would call either `tapToDismiss` is false/true
 //If tapToDismiss is true, this action would call and then dismiss the alert
}, completion: {
   //Completion block after dismiss WITHOUT escaping variables
})

Don't forget to set duration to 0 if you don't want the alert to be auto dismissed.

Amazing that’s great. Thanks.


Add request / response builder fns for common HTTP headers.

As introduced in #131, it would be very nice to have helper fns on the builders for setting common HTTP headers. I'm not sure what the list should be, so we can discuss that here :)
Both Request and Response

Connection
Content-Length
Transer-Encoding

Request only

Accept
Host

Response only

ETag
Location

Would these functions just take be generic over HeaderValue: HttpTryFrom<V>?
If considering #264, would it be nice to utilize the stronger types? Or, I suppose those specific types can just implement HttpTryFrom, and thus be usable there... but there's nothing stopping you from accidentally builder.connection(ContentLength(100))...

@seanmonstar an interesting point. If the builders are kept in the main crate instead of the core crate, then it can use the types headers which would be very nice.


[DF] Update DataFusion to pick up SQL support for LIKE, ILIKE, SIMILAR TO with escape char

There is one test failure after this update:
FAILED tests/integration/test_sqlite.py::test_filter - AssertionError: DataFrame are different

The reason for this is that the representation of Like and NotLike has changed in the logical plan and the corresponding Python code now needs updating.
Previously these were modeled as Expr::Binary with Operator::Like/NotLike but now they are represented as a new top-level Expr::Like expression instead.

@ayushdg Could you help me out with the Python changes for this PR?

@ayushdg Could you help me out with the Python changes for this PR?

Yeah I can take a look

Codecov Report

:exclamation: No coverage uploaded for pull request base (datafusion-sql-planner@9273e17). Click here to learn what that means.
The diff coverage is n/a.

@@                    Coverage Diff                    @@
##             datafusion-sql-planner     #751   +/-   ##
=========================================================
  Coverage                          ?   74.97%
=========================================================
  Files                             ?       73
  Lines                             ?     3657
  Branches                          ?      754
=========================================================
  Hits                              ?     2742
  Misses                            ?      778
  Partials                          ?      137

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Error when running apache2-license-checker

Tried running against https://github.com/bbc/simorgh.
$ apache2-license-checker
Checked for local license-exceptions.json; but no file was found.
/Users/ashtoc03/Sites/bbc/simorgh/node_modules/@bbc/apache2-license-checker/scripts/check-licenses.js:16
  return exceptions[key] || exceptions[anyVersionKey]
                   ^

TypeError: Cannot read property<EMAIL_ADDRESS>of undefined
    at inExceptionList (/Users/ashtoc03/Sites/bbc/simorgh/node_modules/@bbc/apache2-license-checker/scripts/check-licenses.js:16:20)
    at Object.keys.forEach (/Users/ashtoc03/Sites/bbc/simorgh/node_modules/@bbc/apache2-license-checker/scripts/check-licenses.js:34:25)
    at Array.forEach (<anonymous>)
    at checkLicenses (/Users/ashtoc03/Sites/bbc/simorgh/node_modules/@bbc/apache2-license-checker/scripts/check-licenses.js:28:25)
    at ChildProcess.command.on (/Users/ashtoc03/Sites/bbc/simorgh/node_modules/@bbc/apache2-license-checker/run.js:23:3)
    at emitTwo (events.js:126:13)
    at ChildProcess.emit (events.js:214:7)
    at maybeClose (internal/child_process.js:925:16)
    at Socket.stream.socket.on (internal/child_process.js:346:11)
    at emitOne (events.js:116:13)

Thanks for the report, will look into that this morning - what directory / project did you run in it?

In the root. Thanks

@ChrisBAshton checked out the simorgh repo, installed the license checker, ran npm install, and managed to get this output:
[MAC: simorgh] npm run check-licenses

><EMAIL_ADDRESS>check-licenses /Users/beechj01/workspace/simorgh
> apache2-license-checker

Checked for local license-exceptions.json; but no file was found.
Acceptable project licenses (uses):
  (BSD-2-Clause OR MIT OR Apache-2.0) (2)
  (BSD-3-Clause OR GPL-2.0) (1)
  (GPL-2.0 OR MIT) (1)
  (MIT AND BSD-3-Clause) (1)
  (MIT AND Zlib) (1)
  (MIT OR Apache-2.0) (1)
  (MIT OR GPL-3.0) (1)
  (MIT OR WTFPL) (1)
  (WTFPL OR MIT) (2)
  AFLv2.1,BSD (1)
  Apache License, Version 2.0 (2)
  Apache-2.0 (75)
  BSD (4)
  BSD* (13)
  BSD-2-Clause (33)
  BSD-3-Clause (50)
  CC-BY-3.0 (1)
  CC-BY-4.0 (2)
  CC0-1.0 (2)
  ISC (107)
  MIT (1592)
  MIT* (9)
  MPL-2.0 (1)
  Public Domain (1)
  Unlicense (1)
  WTFPL (2)

Problems with the licenses for these dependencies:
<EMAIL_ADDRESS>    License:     (MIT OR Apache-2.0)
    Repository:  git://git.coolaj86.com/coolaj86/atob.js
    Publisher:   AJ ONeal
    Url:         https://coolaj86.com

<EMAIL_ADDRESS>    License:     MPL-2.0
    Repository:  https://github.com/dequelabs/axe-core
    Publisher:   undefined
    Url:         undefined

<EMAIL_ADDRESS>    License:     CC-BY-4.0
    Repository:  https://github.com/Fyrd/caniuse
    Publisher:   Alexis Deveria
    Url:         undefined

<EMAIL_ADDRESS>    License:     CC-BY-4.0
    Repository:  https://github.com/ben-eb/caniuse-lite
    Publisher:   Ben Briggs
    Url:         http://beneb.info

<EMAIL_ADDRESS>    License:     (MIT OR WTFPL)
    Repository:  https://github.com/ralphtheninja/expand-template
    Publisher:   LM
    Url:         undefined

<EMAIL_ADDRESS>    License:     (MIT OR GPL-3.0)
    Repository:  https://github.com/Stuk/jszip
    Publisher:   Stuart Knightley
    Url:         undefined

<EMAIL_ADDRESS>    License:     (BSD-3-Clause OR GPL-2.0)
    Repository:  https://github.com/digitalbazaar/forge
    Publisher:   Digital Bazaar, Inc.
    Url:         http://digitalbazaar.com/

<EMAIL_ADDRESS>    License:     (MIT AND Zlib)
    Repository:  https://github.com/nodeca/pako
    Publisher:   undefined
    Url:         undefined

<EMAIL_ADDRESS>    License:     (MIT AND BSD-3-Clause)
    Repository:  https://github.com/crypto-browserify/sha.js
    Publisher:   Dominic Tarr
    Url:         dominictarr.com

<EMAIL_ADDRESS>    License:     (GPL-2.0 OR MIT)
    Repository:  https://github.com/faisalman/ua-parser-js
    Publisher:   Faisal Salman
    Url:         http://faisalman.com

Licenses not ok Licensed (1897) Exceptions (0) Problems (10)
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>check-licenses: `apache2-license-checker`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>check-licenses script.

Hope that's what you were after :)

Also, side note... we were considering making the whitelist a per-project configuration as well, and having a set of defaults, but I need to talk with David, Steph and Richard T further since choice of acceptable licenses is under their purview.

Confirmed it works - not sure what went wrong! Thanks