ontogpt may cache LLM's "errors"/inconsistent output

Sometimes calls to GPT did not explicitly fail, but returned empty, which for practical purposes is a failed call, see image below. Thanks to
https://github.com/monarch-initiative/malco/blob/653291d119a5fffb31b2779b8a52221dadfea50e/src/malco/run/search_ppkts.py#L29-L31
they would be considered as unsuccessful, because there was no grounding. Rerunning the same phenopacket again, however, meant trying to ground the same empty reply over and over, since the output of the LLM had been cached. Solved by manually removing .litellm_cache.

Again, more of a reference for me, but @caufieldjh you may be interested in ontogpt UX

Hrm, in practice this shouldn't matter except in cases where the phenopacket doesn't parse for stochastic reasons, because any change in the way the prompt is submitted will cache a new response. But I see what you mean. Perhaps the extracted output needs its own error flag.
There are cases where a lack of grounding is expected or desirable, but we can definitely avoid caching responses with no content.

Hmm, I am not 100% sure I understand.
So, just to make sure we understand each other:  I am inclined to think the prompt we sent out made sense, but the LLM at hand returned an empty list. When ontogpt gets an empty list to ground, it obviously fails. When running the same prompt again, we get again the same cached empty list (funny that the numbers, such as "1. \n 2. ... " are there, which technically makes it a non empty reply) ,  then pass that on to ontogpt (sorry :P) and it obviously fails again. When removing .litellm_cache the effect was that the prompt would be sent again, this time returning a meaningful answer, which would then be forwarded to ontogpt for grounding.

Ah, that's right - I forgot the initial prompt and the grounding were decoupled here. Either way, the empty responses don't need to be cached, and that's something I can fix in ontogpt.


Remove unused close-table-executor

Merge the abstract class in it's afterwards only implementation.
Follow up of #17079

@mergifyio refresh


Add translation support

It would be nice to be able to translate this app (with a .pot file in the /po directory, or a Weblate page..)

thanks for the suggestion. I'm working on that right now...

fixed with 47d4cb80fe596f481e876ed068ac9e28aa20e4c8


refactor: use StreamResourceWriter instead of InputStreamFactory

Use StreamResourceWriter instead of InputStreamFactory + Thread + PipedInput/OutputStream + implicit StreamResource pipe.

Summary by CodeRabbit

New Features

Enhanced export functionality for GridExporter, supporting direct writing to OutputStream for CSV, DOCX, PDF, and Excel formats.

Refactor

Updated internal class names and method signatures to improve clarity and functionality.

 Quality Gate failed
Failed conditions  1 Security Hotspot
See analysis details on SonarCloud

Sonar complains about a line that was already present in the codebase https://github.com/FlowingCode/GridExporterAddon/blob/9fafac333446d04648174ca9f18274060ce4e204/src/main/java/com/flowingcode/vaadin/addons/gridexporter/PdfInputStreamFactory.java#L71

Actionable comments posted: 6

Ears twitch, hops abound,
Annoying rabbit's antics,
Test patience, yet charm.
🐇😕


Upgrade Spring Boot 2.7.16 -> 2.7.17

This PR contains the following updates:

Package
Type
Update
Change

Spring Boot (source)
compile
patch
2.7.16 -> 2.7.17

Release Notes

spring-projects/spring-boot (Spring Boot)
v2.7.17
Compare Source
:warning: Noteworthy Changes

The behavior of spring.jms.listener.concurrency has been corrected to match the documentation (#37180). If you were setting spring.jms.listener.concurrency without also setting spring.jms.listener.max-concurrency, please review your configuration when upgrading.

:lady_beetle: Bug Fixes

@Order does not work on (CommandLine|Application)Runner @Bean methods #37905
Gradle plugin uses to-be-deprecated API for getting and setting file permissions #37878
Task executor metrics are not registered when using lazy initialization #37832
Constructor binding with a custom collection type does not work #37734
Dependency management for kafka-server-common with a test classifier is missing #37499
fileMode and dirMode are not applied to all entries in an archive produced by BootJar #37496
Gradle plugin's build info support produces a deprecation warning when using Gradle 8.4-rc-1 #37493
RepackageMojo doesn't support 1 digit numerical values for project.build.outputTimestamp #37438
Restarter creates memory leak in tests #37373
Contrary to the documentation, setting spring.jms.listener.concurrency alone configures the maximum concurrency #37180
Application fails to start when an optional config import cannot be resolved #35683
@ComponentScan on a test class is processed when creating a test context but is not included in the context's cache key #31577
AspectJ transaction management with compile-time weaving does not work with spring.main.lazy-initialization=true #37506

:notebook_with_decorative_cover: Documentation

Remove link to LiveReload website due to timeout #37643
Refer to ActiveMQ as ActiveMQ "Classic" #37606
Use more idiomatic Kotlin in example for "Map Health Indicators to Micrometer Metrics" #37491
Document support for Java 21 #37371

:hammer: Dependency Upgrades

Upgrade to Dropwizard Metrics 4.2.21 #37893
Upgrade to Elasticsearch 7.17.14 #37840
Upgrade to Infinispan 13.0.20.Final #37841
Upgrade to Jetty 9.4.53.v20231009 #37842
Upgrade to Jetty Reactive HTTPClient 1.1.15 #37927
Upgrade to Micrometer 1.9.16 #37674
Upgrade to Netty 4.1.100.Final #37843
Upgrade to Pooled JMS 1.2.5 #37894
Upgrade to Reactor Bom 2020.0.37 #37675
Upgrade to Spring AMQP 2.4.17 #37676
Upgrade to Spring Data Bom 2021.2.17 #37677
Upgrade to Spring Session Bom 2021.2.3 #37928
Upgrade to Tomcat 9.0.82 #37895
Upgrade to UnboundID LDAPSDK 6.0.10 #37753
Upgrade to Undertow 2.2.28.Final #37929

:heart: Contributors
Thank you to all the contributors who worked on this release:
@bottlerocketjonny, @dependabot[bot], @erichaagdev, @esperar, @izeye, @jbertram, @nielsbasjes, @onobc, @ttddyy, and @vpavic

[ ] If you want to rebase/retry this PR, check this box

Suggested commit message:
Upgrade Spring Boot 2.7.16 -> 2.7.17

See:
- https://github.com/spring-projects/spring-boot/releases/tag/v2.7.17
- https://github.com/spring-projects/spring-boot/compare/v2.7.16...v2.7.17


Update package index with latest published versions

 [](

[ ]

[ ] )

Closing as this was opened by someone that is not the azure-sdk bot account.


Workflow in /tmp can appear in workspace multiple times on OSX

Put VT file in /tmp/ on Mac OS X
start "vistrails /tmp/myfile.vt"
close VisTrails
open it again; "myfile" is in the workspace on the left
Command+O and open /tmp/myfile.vt: it is now twice in the workspace

I can't reproduce this on Linux or in another folder. Is it because /tmp is a link?

You can hover the vistrail in the workspace to see the paths they refer to.
os.path.realpath expands it to /private/tmp. But it does not look like this is ever used in the code?

Adding a few os.path.realpath() calls in the workspace calls should fix this then?

The problem seems to be that qfiledialog resolves symlinks:
http://doc.qt.io/qt-4.8/qfiledialog.html#Option-enum
We can set the DontResolveSymlinks flag to avoid this.
I am thinking we should avoid resolving symlinks because real locations can change, have long paths, and are inflexible. The only problem is if a user uses multiple paths to refer to the same location, but I think it is a reasonable tradeoff?

I don't see why real locations would change more often than symlinks, and long paths are not an issue since we don't display them. I'd really rather use real paths everywhere...

Fixed by #1160


WIP: OSSM-5444 Support Distributed Tracing 3

This PR is adding SMCP v2.5 spec APIs for the following three MeshConfig.ExtensionProvider :

zipkin
opentelemetry
envoyOtelAls

Reference: https://istio.io/latest/docs/reference/config/istio.mesh.v1alpha1/#MeshConfig-ExtensionProvider
This should unblock the testing of OSSM-5444. And connecting OSSM mesh with Distributed tracing 3 with either zipkin or opentelemetry provider.
The envoyOtelAls is not used from tracing side but it can be used in envoy log collection with opentelemetry.
Note: this PR evoyOtelAls is not including field logFormat. The field default will follow Envoy access logging formatting.
So using default is more consistent with Envoy side config.

This PR replaces the strategy_v2.5.go counter if statements with reflection.
This makes the code being able to dynamically check all fields in the  ExtensionProviderConfig instead of hard coding each field names.

I run make gen but no change from pkg/apis/maistra/v2/zz_generated.deepcopy.go.
It looks like my local env does not generate that file. Does anyone know how to fix that ?

Is this a better approach than creating a new tracing provider type?  I'd also be concerned how this works with the existing Tracing fields, since those manipulate the zipkin field when Jaeger is specified (not sure what they do when None is specified.

Is this a better approach than creating a new tracing provider type? I'd also be concerned how this works with the existing Tracing fields, since those manipulate the zipkin field when Jaeger is specified (not sure what they do when None is specified.

If I read correctly, we can only have one name with one extensionProvider type.
When jaeger is specified, the code only allows existing jaeger spec field and those new fields are not allowed under that name. However, we may have two providers:

name: jaeger
jaeger:
...
name: zipkin
zipkin:
...

I can test more if there are any conflict with multiple providers.
(not sure what they do when None is specified.  The code also does not allow only name field.
counter < 2 means all fields nil or only name field specified and then error.

However, we may have two providers:
name: jaeger
jaeger:
...
name: zipkin
zipkin:
...

I don't like this idea, because it's not the upstream API.

Is this a better approach than creating a new tracing provider type?

@rcernich I don't think so, because the existing Jaeger/Stackdriver settings are mapped to the old telemetry v2 settings, which are no longer developed. And what's more, the old API can't be used with the new Telemetry API. So I think it's better to extend extension providers and document that the new API should be preferred. In OSSM 3, we will have only extension providers, so it's also better from the perspective of migration.

I'd also be concerned how this works with the existing Tracing fields

Very good point. I think we should implement a validation, which don't allow to set both at once and additionally we should make sure that telemetry.v2 settings are enabled when Zipkin extension provider is used.
Btw. it would be easier to review this change if Zipkin was added in another PR.

However, we may have two providers:
name: jaeger
jaeger:
...
name: zipkin
zipkin:
...

I don't like this idea, because it's not the upstream API.

Is this a better approach than creating a new tracing provider type?

@rcernich I don't think so, because the existing Jaeger/Stackdriver settings are mapped to the old telemetry v2 settings, which are no longer developed. And what's more, the old API can't be used with the new Telemetry API. So I think it's better to extend extension providers and document that the new API should be preferred. In OSSM 3, we will have only extension providers, so it's also better from the perspective of migration.

I'd also be concerned how this works with the existing Tracing fields

Very good point. I think we should implement a validation, which don't allow to set both spec.tracing.type: Jaeger and spec.meshConfig.extensionProviders[].zipkin at the same time, and additionally we should make sure that telemetry.v2 settings are disabled when Zipkin extension provider is used.
Btw. it would be easier to review this change if Zipkin was added in another PR.

Hi, I have created another PR only for Zipkin:
https://github.com/maistra/istio-operator/pull/1531

I tested this PR change works with "Red Hat build of OpenTelemetry operator" in the following task:
https://istio.io/v1.16/docs/tasks/observability/logs/otel-provider/
This PR is ready for review. instruction doc is progress. I will paste a doc draft in JIRA comment.


Add an importer for kube-bench reports

Resolves #2907

Is it ok, when I add the documentation for the kube-bench importer to the documentation pull request of the Checkov importer? Then I would avoid a merge conflict later.

Yes

Done


DBI-620 P1 401s accesstoken # store expiry date

Store token expiry date in vuex to make it possible to check it before requests are made

Where is the expiry data being pulled/checked from the store?


Change Tracking with Clustered Columnstore Indexing

Above you note:
"SQL Server 2014 (12.x) specific limitations
These limitations apply only to SQL Server 2014 (12.x). In this release, we introduced updateable clustered columnstore indexes. Nonclustered columnstore indexes were still read-only.
Change tracking. You cannot use change tracking with nonclustered columnstore indexes (NCCI) because they are read-only. It does work for clustered columnstore indexes (CCI)."
I'm not sure that Change Tracking can be enabled on CCI's as the text states.
When enabling change tracking on a table with CCI you receive the error below..
Msg 35353, Level 16, State 1, Line 3
Change Tracking cannot be enabled on a table with a clustered columnstore index.  Consider dropping clustered columnstore index '%s' on table '%s'.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 195f6bd5-e394-7695-3fed-2cb092db31b9
Version Independent ID: 3bab1457-be3c-b344-feb3-f8b00a4f916d
Content: CREATE COLUMNSTORE INDEX (Transact-SQL) - SQL Server
Content Source: docs/t-sql/statements/create-columnstore-index-transact-sql.md
Product: sql
Technology: t-sql
GitHub Login: @CarlRabeler
Microsoft Alias: carlrab

@abair34  Thank you for the feedback, assigning the author now.

fixing now - thanks for submitting this issue.
#please-close


[flutter_svg]  tags not rendered

Imported from https://github.com/dnfield/flutter_svg/issues/980
Original report by @billyjuliux on Aug 24, 2023
Hi,
I tried to render svg image which contains <image> tags in <defs> (png image inside svg), but those images were not successfully rendered. Yet other elements of the svg were rendered successfully.
I can't show you the real image, but here is the rough structure of the svg file:
<svg width="52" height="128" viewBox="0 0 52 128" fill="none" xmlns="http://www.w3.org/203/svg" xmlns:xlink="http://www.w3.org/1939/xlink">
<path d="M561.28 0H0V17.66H561.28" fill="#E60013"/>
<mask id="mask0_335_524" style="mask-type:luminance" maskUnits="userSpaceOnUse" x="0" y="0" width="562" height="178">
<path d="M561.28 0H0V177.66H561.28V0Z" fill="white"/>
</mask>
<g mask="url(#mask0_335_524)">
<path fill-rule="evenodd" clip-rule="even" d="M555" fill="#CF141C"/>
<path fill-rule="evenodd" clip-rule="even" d="M0 151.78V177.66H561.28L0 151.78Z" fill="#CF141C"/>
<rect x="-223" y="-44" width="67" height="35" fill="url(#pattern0)"/>
<path fill-rule="evenodd" clip-rule="evenodd" d="M561.281 0H385.291L440.381 177.66H561." fill="#CF141C"/>
<rect x="386" y="8" width="171" height="173" fill="url(#pattern1)"/>
</g>
<path d="M211.444 " fill="white"/>
<defs>
<pattern id="pattern0" patternContentUnits="objectBoundingBox" width="1" height="1">
<use xlink:href="#image0_3365_52461" transform="matrix(0.0005008 0 0 0.009108 -0.00112783 0)"/>
</pattern>
<pattern id="pattern1" patternContentUnits="objectBoundingBox" width="1" height="1">
<use xlink:href="#image1_3365_52461" transform="matrix(0.000632511 0 0 0.000625199 0 -0.00109684)"/>
</pattern>
<image id="image0_3365_52461" width="1920" height="1009" xlink:href="data:image/png;base64,iVBORw0KGgoAAAbk7CxAAAgAElEQVR4AezdaZMl13kf"/>
<image id="image1_3365_52461" width="1581" height="1603" xlink:href="data:image/png;base64,iVBORw0ACDgXPJAAAKN2lDQ1BzUkdCIElFQzYxOTY2LTIuMQAAeJydlndUU9kWh8I="/>
</defs>
</svg>

I have tried to move the <defs> order to the front and use online tools of svg cleaner but still didn't work.
Any help would be very appreciated. Thanks!

Comment by @minseok-jeong-gn on Aug 26, 2023
Same issue

Comment by @tsrCodes on Aug 27, 2023
Any Solution ??

Comment by @AristideVB on Aug 30, 2023
Also experiencing this issue, I ended up stacking my PNGs behind my SVG

Comment by @pipe0919 on Sep 8, 2023
A solution for me was to download the img as a pdf and then convert to svg @AristideVB @tsrCodes @minseok-jeong-gn @billyjuliux

Comment by @devnta on Sep 14, 2023

A solution for me was to download the img as a pdf and then convert to svg @AristideVB @tsrCodes @minseok-jeong-gn @billyjuliux

Thank you very much, bro!
It worked for me.
But what solution to fix this faster?
Very thanks!

Comment by @pipe0919 on Sep 14, 2023

A solution for me was to download the img as a pdf and then convert to svg @AristideVB @tsrCodes @minseok-jeong-gn @billyjuliux

Thank you very much, bro! It worked for me. But what solution to fix this faster? Very thanks!

Not now for me

Comment by @dishankjindal1 on Nov 7, 2023
This is a problem, svg which contains images inside are working fine on browser but images are getting distorted in flutter/react-native both

Comment by @ElDuderini on Dec 4, 2023
I've had issues with this as well, but unfortunately can't really do the conversion to a PDF and then back to an SVG since the issues with these images happen with dynamic content managed by CMS.

Comment by @da-coid on Jan 10, 2024
if you get asset from figma , download it as png , and then convert to svg with tools that you can find on internet. It works !

Comment by @adimshev on Jan 15, 2024
any updates?

Comment by @fisforfaheem on Feb 6, 2024
who will fix this

Comment by @abdel-ke on Feb 13, 2024
for me i converted the svg to json with package xml2json then i mapped it

Comment by @fisforfaheem on Feb 13, 2024
how
On Tue, Feb 13, 2024 at 4:34 PM ABDELHAMID EL KEMMAL <
@.***> wrote:

for me i converted the svg to json with package xml2json then i mapped it
—
Reply to this email directly, view it on GitHub
https://github.com/dnfield/flutter_svg/issues/980#issuecomment-1941292774,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AIRXJSFNQZFCFJURKAYH3PDYTNFT3AVCNFSM6AAAAAA34VXG3OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNBRGI4TENZXGQ
.
You are receiving this because you commented.Message ID:
@.***>

Comment by @minseok-jeong-gn on Feb 14, 2024
For the saving time,
If svg file doesn't render correctly,
just use png or jpeg format.
I'm just export image as png or jpeg format if svg file doesn't work.
That saved my time a lot

Comment by @fisforfaheem on Feb 14, 2024
That worked! but this should be fixed...by someone..
On Wed, Feb 14, 2024 at 6:08 AM minseok-jeong-gn @.***>
wrote:

For the saving time,
If svg file doesn't render correctly,
just use png or jpeg format.
I'm just export image as png or jpeg format if svg file doesn't work.
That saved my time a lot
—
Reply to this email directly, view it on GitHub
https://github.com/dnfield/flutter_svg/issues/980#issuecomment-1942933215,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AIRXJSB5FZTGTMOGZOLGV6DYTQFBTAVCNFSM6AAAAAA34VXG3OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNBSHEZTGMRRGU
.
 Why can't they find a solution !

Comment by @fisforfaheem on Feb 22, 2024
I agree with you.
On Mon, Feb 19, 2024 at 10:02 PM Francis Numbi @.***>
wrote:

This is really pissing me ! Why can't they find a solution !
—
Reply to this email directly, view it on GitHub
https://github.com/dnfield/flutter_svg/issues/980#issuecomment-1952888489,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AIRXJSEBH6IV4PKHGT3QNBLYUOAUFAVCNFSM6AAAAAA34VXG3OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNJSHA4DQNBYHE
.
You are receiving this because you commented.Message ID:
@.***>

Comment by @yousefak007 on Mar 23, 2024
same for me

Comment by @fisforfaheem on Jul 22, 2024
Kindly give us an update

PDF to SVG conversion solution works for me too, thanks

A solution for me was to download the img as a pdf and then convert to svg @AristideVB @tsrCodes @minseok-jeong-gn @billyjuliux


ARM support

Feature request
Perhaps more a question or discussion than feature request, but: do you have any experience running this on ARM platforms e.g. Apple M1 or AWS Graviton?
Looks like MediaSoup may support ARM ref1 ref2.
The asm code in rush referenced in #2 / #3 indeed comes with both x86_64 and aarch64 targets.
Why you need this
I primarily develop on an M1 Mac. This is very much in the "nice-to-have" territory, but I am curious if others are successfully using this on ARM.
Alternatives you've considered
The main issues I encountered with ARM, and workarounds I tried, in case it's useful:
The chrome image installs google-chrome-stable on Debian, but Google only provides Chrome for Linux amd64. Docker for Mac provides emulation via qemu (support for which should be regarded as "best effort" only). For me, amd64 (x86) Chrome in Docker (via make run-chrome) failed to launch with this error.
I was not successful in finding an older version of Chrome that successfully launched via apt or deb for Debian 9 (per this repo's Dockerfile FROM node:12.20.2) or Debian 11 (the newest stable version; easy to update by changing this repo's Dockerfile to use FROM node:12-bullseye).
I also tried various versions of Chromium under arm64, but was not successful.
I ended up running it successfully on an x86 machine, but thought I'd share notes in case this is useful 😄

Just wanted to close the loop and say that we've merged two patches that, for us, together provide working ARM support. Thanks for your PR, here! Let us know if you still have any issues on main.


Stop loading model-viewer in mobile browser

Hi,
is there any way to stop Model-viewer from loading in mobile browsers? I would like to load it in desktop browsers but, not in mobile till I can find a way to improve the page performance.
Thank you.

You can use any of the normal web techniques to only show model-viewer on certain types of browsers. You may want to lazy-load model-viewer.js, so that it only downloads if you're on the desired browsers. There are many ways to achieve this, and none are specific to model-viewer.


map the events to load from db even after they are loaded from the API

working on it 👍

@simarsingh24 Closing this :+1:


What should be contained on a Client Summary Page?

On the page where a screener can see an overview of a particular client, what information should be included?

Name
FPL
Verification documents (with or without previews? list or summary?)
Other services they might be eligible for?

If we're having an overview page, it seems like actually listing the user information and documents would be helpful here, rather than making a user go to another screen. Turn the "see Cary's 2 documents" into "add another document" and "see Cary's details" should just be listed. Something like:

working on this template if you're needing copies

I like that idea! It brings up a question about the list format for documents.
Here's a list of the info for each document that's being considered for inclusion in a document list page. Which should be included here?

Document Name
Document thumbnail image
date of the document (like paystubs for the month of ___, or letter of child support about __ dates)
date verified
who reviewed it where
whether and why it needs to be updated

Some of these were brought up by @esmithayer here:
https://docs.google.com/a/codeforamerica.org/presentation/d/1kVSFagS9laHCniL0LRNoi-thlp67J9w3oiGaUlbYAsQ/edit#slide=id.g75baf0228_043

Good question! Of the list above, it seems document name, date, and who reviewed would be important to get quickly on this page. Could use icons like a :white_check_mark: or :exclamation: for the needs to be updated portion as well.

This is now being handled by the client details view, #36


Support for arbitrary hostapd parameters

I tried to add other hostapd parameters that are for specifying the authentication server, e.g. auth_server_addr, but the docker-ap raised warning that they are not recognized. Then I went through the docker-ap file and noticed that it reads the parameters one by one from the wlan_config.txt and inputs them in the hostapd.conf and there are only handful of parameters considered in it. Three questions:

Is there any way to add arbitrary hostapd parameters other than SSID, passphrase, hw_mode and channel?
Is there any specific reason behind parsing the parameters from wlan_config.txt? Why not just copy paste the file into /etc/hostapd/ inside the container?
Do you accept PR if you are ok with this approach? I can implement this in a way to replace the parsing or as a separate feature.

Thanks,

Hi @Vafa-Andalibi,
When I made the script it was enough for me to implement it the way it is now, but indeed you are right and your approach is the way it should be (getting rid of the parsing), so any PR will be welcome! :)
Thanks in advance.


Receiving no such file as node_modules/supabase/bin/supabase when deploying nodejs server [npm]

Describe the bug
When I deploy my NodeJS server after adding supabase to it, I receive the error that there is no such file or folder in node_modules/supabase/bin/supabase.
Note: I'm using Render hosting to deploy my NodeJS server.
To Reproduce
Steps to reproduce the behavior:

Add @supabase/supabase-js and supabase with npm
Deploy project to Render
Receive error

Expected behavior
Deployment was successful.
Screenshots

Desktop (please complete the following information):
Not applicable
Additional context
I've tried locally to reproduce the issue by deleting node_modules, but it installs correctly.

Hi @sspahic2, can you try running npm install --production when deploying the project to Render? Typically the cli is not needed for deployment as it's only installed as a dev dependency.

Hello @sweatybridge ,
thank you very much. That information struck gold and resolved the issue.


Duplicate Text - limited number limited number

ITSM - You may have a limited number limited number of ITSM actions in an Action Group. ITSM Action requires an ITSM Connection. Learn how to create an ITSM Connection.
Words, limited number limited number is repeated in the above paragraph.

Document details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: db395a71-30bf-881a-05cc-4340fb612ee1
Version Independent ID: 8070d5f4-ff8f-c6d3-3a41-08b7686337f3
Content: Create and manage action groups in the Azure portal
Content Source: articles/azure-monitor/platform/action-groups.md
Service: azure-monitor
Sub-service: alerts
GitHub Login: @dkamstra
Microsoft Alias: dukek

@mkalkere Thanks for the feedback. We are actively investigating and will get back to you soon.

@mkalkere the repeated word has been removed. thanks for catching this.


pull request for e2e test at 01/09/2017 00:26:09

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


fix: use remove-signatures in skopeo copy stages

Neither Docker daemon nor OCI supports storing the container signatures,
and skopeo copy refuses to just silently drop them.
Using skopeo copy --remove-signatures to make the copy, the signatures
will be still read and policy.json will still be enforced, they just
won’t be written into the destination.
Resolves: RHEL-34807
Signed-off-by: Miguel Martín<EMAIL_ADDRESS>

xref https://github.com/containers/bootc/issues/812 and https://github.com/containers/image/pull/2590


Check if session is started

We integrate Grav as part of our platform. This means we need to use session when Grav is not use or use it before we initialize Grav.
In our index.php file we have
if(!$grav['session']->started())
{
    $grav['session']->init();
}

If same thing would be added to system/src/Grav/Common/Processors/InitializeProcessor.php we could control session.
Problem actually comes from vendor/rockettheme/toolbox/Session/src/Session.php:
// Destroy any existing sessions started with session.auto_start
if ($this->isSessionStarted())
{
    session_unset();
    session_destroy();
}

This removes any session started before Grav.
This solution could also check for wrapped_site in system config, because this is exactly what is happening, Grav is wrapped with our code.

I would override $grav['session'] with your own (which extends Grav's Session class) in a plugin as early as possible. Though, I'm not 100% sure if it's possible right now.

I need to start session before Grav is fully initialized.
This is simplified version of my code:
<?php

$autoload = __DIR__ . '/vendor/autoload.php';
$loader = require_once $autoload;

use Grav\Common\Grav;

$grav =  Grav::instance(
    array(
        'loader' => $loader
    )
);

if(!$grav['session']->started())
{
    $grav['session']->init();
}
// ...
// do stuff with session
// switch to check if we use Grav or online shop code based on $_SERVER['REQUEST_URI']
// if Grav is used here we include 'index.php' from Grav subdirectory

We share session with shop platform.

@jpass I've added option to upcoming Grav 1.4 to disable session initialisation inside Grav core. It allows you to create a plugin which overrides session handling allowing you to replace default session handler with something else. Just remember that you need all the functions we have in your session class, maybe extend ours and just replace the code so that it works with your sessions.

Closing as it is already possible to do this.


refactor: use http.Method constants instead of string literals

TL;DR
Replaced hardcoded HTTP method strings with standard http.Method* constants
What changed?

Replaced string literals like "GET", "PUT", and "DELETE" with their corresponding http.Method* constants
Updated HTTP method references in cache operations, server tests, and test data files

How to test?

Run the existing test suite
Verify all HTTP requests continue to function as expected
Confirm no changes in behavior for GET, PUT, and DELETE operations

Why make this change?
Using standard HTTP method constants from the http package:

Prevents typos in method strings
Provides better IDE support and code completion
Makes the code more maintainable and consistent with Go best practices
Reduces the risk of errors from mistyped HTTP method strings

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#164
#163
#162
#161
#160  👈 (View in Graphite)
#159
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Merge activity

Dec 31, 8:29 PM EST: A user started a stack merge that includes this pull request via Graphite.


Privateendpoint erptosap

Created Private endpoints for ERP to SAP.

Created Folder structure
Edit the auto.tfvars file

Not for Here:
@GhostShaikh  could you make sure to take this into your teams spoke or project?

this is a module / template.
you are hardcoding values using a tfvar file, we dont generally do that, you cannot change those values without a fresh code change, use the pipeline and pull values from a keyvault.

env:
  TF_VARS_vnet_link: $(VNET-LINK)

for an example

Removed


Date is interpreted as an object in diff-array.js

I have a problem of a date not being updated on the database when a client changes the value (value is updated on client).
The code in diff-array.js looks like it interprets dates as an objects, and tries to compare all properties on it, but there isn't any.
// Can tell whether a value is an object and not an array
var isActualObject = function (value) {
  return angular.isObject(value) && !angular.isArray(value);
};

If you call the above code with a new Date() as the value it will return true.
Is this a bug or intended behavior?
Thanks

@bjarketrux do you think you can add a failed test that catches this scenario?

First thing tomorrow!

Fixed in pull request #422


Support 16bit color per channel

Some LED strips (like APA102 with global brightness bits) can achieve greater than 8-bit per color channel resolution under certain conditions. Similarly LEDs driven using 12-bit or 16-bit pwm (either via peripherals or an external PWM chip) would also be nice to support.
For context I'm working on a crate that implements the interpolation, gamma correction and temporal dithering techniques from fadecandy. It supports writing into the internal state using the SmartLedsWrite trait and itself writes to the underlying LEDs via the same. I have a few custom LED spotlights that use 16-bit pwm and would like to re-use the interpolation and gamma correction to take advantage of the 16-bit pwm during fades while still only having to provide 8-bit per channel input.
It seems like either a new 16-bit specific trait could be defined or now that this is using the rgb crate  a generic trait over RGB could be defined. e.g.
pub use rgb::RGB;

pub type Color = rgb::RGB8;
pub type Color16 = rgb::RGB16;

pub trait SmartLedsWrite<RGB> {
    type Error;
    fn write<T>(&mut self, iterator: T) -> Result<(), Self::Error>
    where
        T: Iterator<Item = RGB>;
}

It looks like our current brightness and gamma correction functions in smart-leds assume u8, but maybe we should change that. What do you think @david-sawatzke?

@sajattack I think having a dedicated function at least for gamma is important, as we're pretty constrained timing wise & thus need tables.
So we currently have at least three things that aren't nicely captured by the existing traits:

RGBA (doesn't match 100%, but the brightness regulation leds like the apa102)
While there are sometimes valid reasons not to use it (like the slow pwm frequency on apa102) in general it might be quite useful.
RGBW
Dedicated white leds aren't that rare and we have to do our own type (or figure out how to do it based on RGBA without them being interchangable)
16/12/whatever bit leds

I think implementing a generic trait makes sense, we'd have to break our api, but as there don't seem to be that many implementations apart from this org & @evq, that's probably alright. I'd also like to remove our own Color type then and just reexport RGB8 & stuff from the rgb crate, as there's no reason to have two different names for the same thing.
I don't think smart-leds should necessarily provide implementations for anything other than RGB8, as that seems pretty led specific for a lot of things (especially for the RGBA & RGBW types) & also not that common.
The one remaining question for me is if we just want the type or anything that can be converted into it, e.g.:
pub trait SmartLedsWrite<RGB> {
    type Error;
    fn write<T, I>(&mut self, iterator: T) -> Result<(), Self::Error>
    where
        T: Iterator<Item = I>,
        I: Into<RGB>;
}

It would make it a bit easier to mix & match, but it's also potentially a bit confusing ("16 bit leds kind of jump with gamma correction").

It may be ideal to avoid using RGBA for describing the APA102 style global brightness since RGBA is commonly used to refer to Red, Green, Blue and Amber LEDs.
I've prototyped changes to the SmartLedsWrite trait and additional types and traits that work for my use case.
Basically the crate I described above is intended create a "virtual LED strip" that performs interpolation, gamma correction and dithering (when the output type is RGB<u8> or RGBW<u8>) in between frames of data that are sent at a much lower rate. This crate needs to be generic over the output type of the underlying "physical LED strip", both with respect to pwm resolution and color channels.
Trait changes: https://github.com/smart-leds-rs/smart-leds-trait/compare/master...evq:wip
P9813 impl w/ trait changes: https://github.com/evq/p9813-spi-rs/blob/wip/src/lib.rs
"virtual LED strip" crate: https://github.com/evq/ditherable-leds/blob/master/ditherable-leds/src/lib.rs
Not super happy with the trait bounds in the ditherable-leds crate, open to any suggestions. Also, happy to move the GenericPixel struct and Pixel trait into my crate (they do add a dependency on generic-array) - but maybe they would be useful for others?

I'd move GenericPixel to smart-leds, it does seem useful. I'm not sure how useful Pixel for most applications.
Didn't even think of amber leds, but if we can avoid confusion over the RGBA name, it's for the better. Directly repurposing it for RGBW sounds dangerous, maybe we could do something like this:
struct White<C>(C);
type RGBW<ComponentType, WhiteComponentType = ComponentType> =
    RGBA<ComponentType, White<WhiteComponentType>>;

That would retain most of the benefits of using an already existing type, while not being able to interchange them (and same thing for brightness, since it's not exactly an alpha channel). For easier interchangeable use we could add From & Into traits to White.
Is there a reason why Pixel in  SmartLedsWrite is an associative type? I can imagine times when having the option to implement different ones is useful, e.g. to increase the pwm frequency when using pwm with u8 instead of u16.


Added all scene depended changes from #350

Climate changes from #350

@gigatexel Here I think we need to make sure that all lights are loaded before we can generate the scenes. Have you checked that?
In the past I had problems with large installations. That is why the scenes are handled differently then other platforms.

@gigatexel And if that works I think it is hopefully ok to add scenes by default. On larger installations there are hundreds of scenes generated on start. So hopefully we get not a lot of issues back.
But when it is working the config settings should also be removed from the gui and from the settings.

Thanks for you feedback on the history of why things are implemented as they are 👍
I just did a test by adding 40 light controllers v2 with each 15 scenes defined. This renders 600 scenes and processes well.
Todo:

see what I can do to make sure lights are loaded first
check again if I can make reloading the integration more clean. Reloading causes a connection error in the logs that corrects itself (polls on a connection that was gracefully disconnected).

Do you want me do create a specific PR for this then?

@gigatexel I think the best way to test is to make a sleep in the different integration setup methods.
I think a problem is when the lights are not loaded before the scene loads. This could be not only when the system has a lot of lights it can be a problem when other integrations take a lot of time to setup. When we get issues I think we can go back an call the scene setup at the same point as we do it now.
I can remove the option from the configuration panel and look that the old values in the settings we removed on migration.
After merging this pr we can go to the next improvement.

Are we sure that this race condition can still be an issue?
If I look at the scenes implementation, it seems that it just parses the LightControllerV2 blocks and then generates scenes from it. There seems no link to the actual LightControllerV2 device?
I will test tomorrow if scenes still generate and work when no light entities are loaded.

@gigatexel please no code from chat gpt!
There is no such function in home assistant.

@gigatexel  hass.async_when_setup does not exist. from homeassistant.setup import async_when_setup does exist.

@gigatexel what do you think could this implementation with a dispatcher work?

@gigatexel of course the print messages must be removed. ;-)

@gigatexel of course the print messages must be removed. ;-)

I will test tomorrow on a VM.

@gigatexel I removed the options for the scene generation. Migration tested only for version 3 to 4. Hope it works for the older versions as well.

@gigatexel I think the reload is not necessary for now. I already made a complete rewrite and it does use a different websoclet lib.  I hope I can make the reload working on the new implementation.
I already tried it but never got it really to work.

@gigatexel what do you think could this implementation with a dispatcher work?

isn't there an unsub() missing after the scenes get generated?

@gigatexel I do not know. That is why I asked. :-)

The edits above let the code run, but scenes are not generated.
I got the exact same issue when I was trying to let the integration reload. Something in the comms is causing the MS not to send an event containing the moodList. Moodlist is never recieved.

@gigatexel  I do not use any scenes that is why I was bit sure if it works. Does it work with the current stable release.

@gigatexel I do not use any scenes that is why I was bit sure if it works. Does it work with the current stable release.

I suspect there is some kind of race condition in the api that causes the moodList not to be picked up.
I looked into it with WireShark and the moodList is in fact sent from MS to HA.

@gigatexel I checked all text messages are not parsed anymore. I do not know if it is a problem which was introduced from Pyloxone update or loxone update.

@gigatexel I leave the scene generation as it is in the current implementation. I spent a few hours with this problem and I have not time for this improvement as it works stable now.

No problem. I will continue my search next week to find what bug might be in the api.

@gigatexel there is no bug in the api. The moods list will only be sent after the the connection is established. It is not part of the config json. That is why we must wait a view seconds before searching for the moods. If we only wait for the light to be setup it is to early and the moods list is still empty and no scenes can be generated. Of course it can be implemented so that the lights generate the scenes when the receive the moods but to be honest the home assistant architecture is getting more and more difficult and more and more a nightmare that my motivation concentrates to keep the component running.


AttributeError - module 'urls' has no attribute 'urls'

My understanding is that there are two common settings of ROOT_URLCONF people use. One is the default ROOT_URLCONF = '' value, and the second is ROOT_URLCONF = 'urls'. This project seems to fail if you use the latter (or at least it did for me). Changing that line to         self.get_all_view_names(root_urlconf.urlpatterns) worked but it would be best to fix in the project.
The root urlconf can also be overridden at runtime via middleware so I think this urls module loading should perhaps be moved into the get_endpoints method or the value of that setting should be passed into the ApiDocumentation object on init.
Nice project BTW. :-)

Hi @poswald! I remember having this issue while I was writing some tests for the package. So I was thinking that a check like the one below would make sense?
    if hasattr(root_urlconf, 'urls'):
        self.get_all_view_names(root_urlconf.urls.urlpatterns)
    else:
        self.get_all_view_names(root_urlconf.urlpatterns)

I can confirm that it works when ROOT_URLCONF = 'project.urls'
Can you check if it works with your project?
Thank you!

Yes it does. I think adding a check like that is fine for now. I do suggest looking into supporting runtime-specified configurations though as I think people use them to do things like having different url schemes for different types of users.

Yeap let's go with that check for now :+1:
I've just published 0.0.5 to pypi so it should work now! Let me know if it does not!

It works, you just need to push the changelog. :-) Thanks.

Done! :smile: http://drfdocs.com/docs/changelog/


[Feature Request][WEBJS] Un/Archived webhook event type

Is your feature request related to a problem? Please describe. I'm always

We sync "active" conversations between the CRM and WAHA. Whatsapp has the "archived: bool" flag that can be use precisely to set a conversation as active or inactive, and the app can be configured to automatically unarchive conversations on new messages, like other contact centers software.

Describe the solution you'd like

An ideal solution would be to create a new event type such as chat.archived to be sent via webhook when the chat is archived/unarchived.

Describe alternatives you've considered

In order to sync the the chats that are archived or not, currently we need to pool the endpoint /chats and read the property "archived": true/false. Polling this resource is a slow and resource intensive process.

Additional context

whatsapp-web.js already has a chat_archived event that is emitted when a chat is archived/unarchived, so the implementation of this webhook hopefully should not be difficult.

https://docs.wwebjs.dev/Client.html#event:chat_archived
https://github.com/devlikeapro/whatsapp-web.js/blob/41b280c769918db03ac6ec12cf0e4215e7b864ef/index.d.ts#L344

PS: We stopped using WAHA early this year because we migrated to the official API and now we resumed because of another use case and, honestly, we rather use the WAHA API than the WA one, also the whole product evolved a lot in the last 6 months, kudos to the team.

@arielpts you're using WEBJS engine right? Just wanna make sure to prioritize it better

Thank you for the kind words and your support, it means the world to us :heart_hands: :heart_eyes_cat:

Yes, we always use WEBJS 🧡

Available in 2024.8.1

👉 Read more about the endpoints on 💬 Chats page!
Archive chat
Use the method to archive chat
POST /api/{session}/chats/{chatId}/archive

Unarchive chat
Use the method to unarchive chat
POST /api/{session}/chats/{chatId}/unarchive

chat.archive
The chat.archive event is triggered when a chat is archived or unarchived.
{
  "event": "chat.archive",
  "session": "default",
  "payload": {
    "id"<EMAIL_ADDRESS>    "timestamp":<PHONE_NUMBER>,
    "archived": true <== or false
  },
  ...
}


Use new hint

Soon you will be able to use https://github.com/linuxmint/Cinnamon/issues/7681. This is a more dynamic solution (the wm shows/hides decorations wrt the current window state) and also more robust (since you're hinting the wm instead of overriding its behavior). It's easy to hack a script using xprop and bind it to some key, but nevertheless it could be nice to keep an applet in the panel like yours. Maybe you would want to update your solution.

Btw I'm already providing a more global solution based on the hint (https://github.com/memeplex/maximal) but yours is complementary since it targets only selected windows.


Support for family sharing

How can we handle familiy sharing for purchases?
https://developer.apple.com/documentation/storekit/in-app_purchase/supporting_family_sharing_in_your_app
When checking for available purchase as described in the documentation we only get the purchase for the account that actually purchased but not for the other accounts that are shared in the family.
Do we have to implement something special for this case or is it not yet supported?
Best regards
Marvin

This should work out of the box as long as you turned it on. It should just show up as a shared purchase.
See:
Handle purchased (SKPaymentTransactionState.purchased) transactions. This is a standard state apps must handle, and you don’t need anything special for Family Sharing.


ERR: fix error message for to_datetime

[x] closes #xxxx There is no issue for this.
[x] tests added / passed
[x] passes git diff upstream/master | flake8 --diff
[x] whatsnew entry

Fixes the error message when the argument to to_datetime doesn't match the format specified.

[Current coverage][cc-pull] is 84.28%

Merging [#13450][cc-pull] into [master][cc-base-branch] will increase coverage by <.01%

@@             master     #13450   diff @@
==========================================
  Files           138        138
  Lines         50929      50929
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits          42925      42926     +1
+ Misses         8004       8003     -1
  Partials          0          0

Powered by Codecov. Last updated by [f752886...988048d][cc-compare]
[cc-base-branch]: https://codecov.io/gh/pydata/pandas/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/pydata/pandas/compare/f7528866e07048f051f46f621ca76947730c7d32...988048dcfd2a50b29677c255dd0fd2deacf238c9
[cc-pull]: https://codecov.io/gh/pydata/pandas/pull/13450?src=pr

thanks!


runtests-browser cause heap out of memory error

TypeScript Version:  master
Code
gulp runtests-browser

Expected behavior:
Not to crash
Actual behavior:
Saving sourcemaps for /home/andy/TypeScript_1/TypeScript/built/local/bundle.js
Fixing sourcemaps for /home/andy/TypeScript_1/TypeScript/built/local/bundle.js

<--- Last few GCs --->

[20271:0x2d46180]   101105 ms: Mark-sweep 1363.0 (1447.8) -> 1363.0 (1447.8) MB, 798.2 / 0.0 ms  allocation failure GC in old space requested
[20271:0x2d46180]   101788 ms: Mark-sweep 1363.0 (1447.8) -> 1363.0 (1431.8) MB, 683.1 / 0.0 ms  last resort GC in old space requested
[20271:0x2d46180]   102440 ms: Mark-sweep 1363.0 (1431.8) -> 1363.0 (1431.8) MB, 651.8 / 0.0 ms  last resort GC in old space requested

<--- JS stacktrace --->

==== JS stack trace =========================================

    0: ExitFrame [pc: 0xe3b2ec0427d]
Security context: 0x7ee065206a9 <JSObject>
    1: apply [/home/andy/TypeScript_1/TypeScript/node_modules/sorcery/dist/sorcery.cjs.js:~543] [pc=0xe3b2fa1a764](this=0x1313fed2bc1 <Chain map = 0x1189be8cd111>,options=0x4ae2bf022e1 <undefined>)
    2: arguments adaptor frame: 0->1
    3: /* anonymous */ [/home/andy/TypeScript_1/TypeScript/Gulpfile.js:841] [bytecode=0x250c53542c39 offset=359](this=0x143bd38...

FATAL ERROR: CALL_AND_RETRY_LAST Allocation failed - JavaScript heap out of memory
 1: node::Abort() [gulp]
 2: 0x876afc [gulp]
 3: v8::Utils::ReportOOMFailure(char const*, bool) [gulp]
 4: v8::internal::V8::FatalProcessOutOfMemory(char const*, bool) [gulp]
 5: v8::internal::Factory::NewFillerObject(int, bool, v8::internal::AllocationSpace) [gulp]
 6: v8::internal::Runtime_AllocateInTargetSpace(int, v8::internal::Object**, v8::internal::Isolate*) [gulp]
 7: 0xe3b2ec0427d
Aborted (core dumped)

@rbuckton this was working in the commit before #23893 (c43740476367f044d4b1848cde525831f0f030cf)

gulp no longer works at all, but jake runtests-browser now fails immediately with no message:
> jake runtests-browser
jake aborted.
Error: Process exited with code 1
    at api.fail (/home/andy/.nvm/versions/node/v10.1.0/lib/node_modules/jake/lib/api.js:336:18)
    at Exec.<anonymous> (/home/andy/TypeScript_1/TypeScript/Jakefile.js:749:13)
(See full trace by running task with --trace)

CC @RyanCavanaugh

@andy-ms You might want to use to debug in the mean time
node --inspect-brk node_modules\mocha\bin\_mocha -R mocha-fivemat-progress-reporter -g "sometest" --colors -t 40000 built\local\run.js

@andy-ms @rbuckton has been working on a patched gulp-typescript that works with project references; hopefully it'll be good to use soon.

@sheetalkamat Thanks, but I've noticed a lot of segfaults / illegal instruction errors when running that -- running through a browser seems to be a lot more reliable. Hopefully we get  gulp runtests-browser working again soon (looks like that task was deleted from the jakefile).

runtests-browser was not carried forward to gulp


Timers are not called if the ticks value is "too small"

This was tested on hardware
Consider the simple rom:
#include <libdragon.h>

// set to 1 when the timer callback runs
volatile int timer_i = 0;

void timer_callback(int ovfl)
{
    timer_i = 1;
}

int main(void)
{
    display_init(RESOLUTION_320x240, DEPTH_16_BPP, 2, GAMMA_NONE, ANTIALIAS_RESAMPLE);
    timer_init();

    // have timer_callback called every 1000 ticks
    new_timer(1000, TF_CONTINUOUS, timer_callback);

    int i = 0; // frame counter, mostly to make sure something is happening

    // increment i, and display i and timer_i on screen, every frame
    while (1)
    {
        i++;

        surface_t *surf;
        while ((surf = display_lock()) == NULL)
            ;

        graphics_fill_screen(surf, graphics_make_color(0, 0, 0, 0));

        char buf[100];
        snprintf(buf, sizeof(buf), "i=%d  timer_i=%d", i, timer_i);
        graphics_draw_text(surf, 10, 50, buf);

        display_show(surf);
    }
}

as expected this results in timer_i=1 since timer_callback is run 1000 ticks or so after boot:

However if 1000 is changed to 1 (for example) (i.e. new_timer(1, TF_CONTINUOUS, timer_callback);) then it stays timer_i=0, indicating the timer callback never runs (note: i keeps incrementing)

Same thing with TF_ONE_SHOT instead of TF_CONTINUOUS.
Some limited testing shows 100 (new_timer(100, TF_CONTINUOUS, timer_callback);) doesn't run the callback but 200 does

What would be the expected behavior?
If you specify a value that's lower than the timer callback processing time (including overhead) there are basically two options: we either ignore it (like we do now), or respect it and go into infinite loop where as soon as we exit an interrupt we must retrigger it.

I would expect continuous/one-shot timers to run as soon/quick as possible
For continuous timers, it would mean I would expect a "freeze" from the timer interrupt not giving the cpu any chance to do anything useful
In that case it may be better to abort when a low-period continous timer is started
For one-shot timers, I do think it would make sense that the timer just runs as soon as possible, since it seems like a valid use case, for example imagine some code computes the ticks to wait until the next event and just happens to compute 100 ticks, then the timer never executing would be quite problematic

Suggested fixes (various ideas):

At the very least mention in the docs that low ticks period values should be avoided (timers wouldn't run)
abort when a small ticks value is used
use max(ticks, 10000) instead of the provided ticks in the new_timer function
have new_timer explicitly able to fail to start a timer, and fail to start a timer when the ticks value is low (but I'm not a fan because it leaves error checking to the user)
allow the user to choose among the above:

timer_link_t* new_timer(int ticks, int flags, timer_callback1_t callback);
  ->
  ```c
enum timer_check_mode {
  TCM_NONE, // don't check the timer ticks value, timer may not run if ticks too small
  TCM_CLAMP, // use max(ticks, 10000), "guarantees" (?) the timer will run but slower than expected
  ...
};

timer_link_t* new_timer_check_ticks(int ticks, int flags, timer_callback1_t callback, enum timer_check_mode checkMode);

#define new_timer(ticks, flags, callback) new_timer_check_ticks(ticks, flags, callback, TCM_NONE)

Or add those to timer flags (TF_) instead idk


Fix thread leak in compact index specs

What was the end-user problem that led to this PR?
The problem was that sometimes CI fails randomly. For example, https://travis-ci.org/bundler/bundler/jobs/544642885.
What was your diagnosis of the problem?
My diagnosis was that the spec after it was mocking Worker#stop and thus preventing the threads to be actually stopped. That leak would after the spec checking for the number of threads.
What is your fix for the problem, implemented in this PR?
My fix is to also call the original #stop method, so that no threads are left behind.
Why did you choose this fix out of the possible options?
There's an alternative option, which is to completely remove this spec. In my opinion, this spec is checking exactly the same thing as the previous spec (the whole purpose of Worker#stop is to stop threads), but in a more brittle way. So I'm tempted to completely kill the spec instead.

Thanks @colby-swandale. Any opinion on fully removing the test vs this PR?

I finally went with removing the spec, and also fixed an incorrect spec nesting since I was at it. Let me know what you think!

Hmmm i'm a bit on the fence here. IMO the Compact Index spec knowing that Bundler::Worker is creating threads is leaking concerns a bit. Could we improve the test suite by moving that spec into the Bundler::Worker specs and leave the spec that's checking Worker#stop the same?

I should be more clear, when i say moving the spec into the specs for Bundler::Worker. I mean the idea of testing a worker with a set amount of threads, and checking that they have been closed afterwards.

I decided to go back to the previous version of the fix, just to get the flaky fix. We can improve the test organization in a separate set of changes :+1:.
I did keep the nesting fix, but I can also remove it if you want.

Went back to the approved version, so merging!
@bundlerbot r+


Dead-letter per topic or per subscription

Could you clarify - do we have one dead-letter queue for a topic or a lot dead-letter for each subscription within the topic?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a9c35042-f064-0f34-8d16-ad40e829ca39
Version Independent ID: 19d4a83e-55c8-8b9c-38a0-0e9a26ba2cdb
Content: Service Bus dead-letter queues
Content Source: articles/service-bus-messaging/service-bus-dead-letter-queues.md
Service: service-bus-messaging
GitHub Login: @sethmanheim
Microsoft Alias: sethm

@bastyuchenko Thanks for your inquiry. I believe the DLQ is per Service Bus Name Space. You can use the Azure Portal or the Service Bus Explorer to list and view the Topics and Queues but, you should see a single DLQ per Service Bus Name Space instance.
Service Bus Explorer Downloads
The dead-letter queue
The purpose of the dead-letter queue is to hold messages that cannot be delivered to any receiver, or messages that could not be processed. Messages can then be removed from the DLQ and inspected. An application might, with help of an operator, correct issues and resubmit the message, log the fact that there was an error, and take corrective action.
From an API and protocol perspective, the DLQ is mostly similar to any other queue, except that messages can only be submitted via the dead-letter operation of the parent entity. In addition, time-to-live is not observed, and you can't dead-letter a message from a DLQ. The dead-letter queue fully supports peek-lock delivery and transactional operations.
Note that there is no automatic cleanup of the DLQ. Messages remain in the DLQ until you explicitly retrieve them from the DLQ and call Complete() on the dead-letter message.

@bastyuchenko Does this answer your question? We will now proceed to close this thread. If there are further questions regarding this matter, please reopen it and we will gladly continue the discussion.
Kind regards,
Mike

@Mike-Ubezzi-MSFT Are you 100% sure on this? It sure looks like to me that there is one DLQ per subscription.  I've created a Topic with two subscriptions, Subscription1 and Subscription2.  Using the Service Bus Explorer I can see 7 items in the DLQ for Subscription1, and zero items for Subscription2.

@Blackbaud-MikeDuVall @Mike-Ubezzi-MSFT, were you able to verify whether the DLQ was per Subscription or Topic?
Thanks,
Moe

@Blackbaud-MikeDuVall @Moeahmad94 This is per queue and not per namespace. I just went through a quick deployment and when you click on Add Queue, you have the ability to add a DLQ to go with the new queue being added (see screen capture):

So if there's a topic with two subscriptions, is it possible for both
subscriptions to get/check messages from the DLQ, or is it first come first
serve?
Thanks,
Moe
On Tue, Dec 18, 2018, 2:53 PM Mike Ubezzi<EMAIL_ADDRESS>wrote:

@Blackbaud-MikeDuVall https://github.com/Blackbaud-MikeDuVall
@Moeahmad94 https://github.com/Moeahmad94 This is per queue and not per
namespace. I just went through a quick deployment and when you click on Add
Queue, you have the ability to add a DLQ to go with the new queue being
added (see screen capture):
[image: screenshot 99]
https://user-images.githubusercontent.com/37126106/50187882-686ff200-02d4-11e9-88f6-fc23d12eb3c9.png
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/MicrosoftDocs/azure-docs/issues/10363#issuecomment-448402216,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHOdC2CAcnX01X9Hb2O5lPdobScsZm82ks5u6XHwgaJpZM4Ur_WP
.

@Moeahmad94 If you have two clients (same as subscription if I understand your terminology) listening to the same queue, without a filtering method implemented, it is first come first served.

I feel like Queues vs Topics are getting confused in this discussion.
The original question on this thread is asking if there is only one DLQ per Topic(i.e. all Subscriptions to the topic share the same DLQ) or whether each subscription to a Topic has it's own DLQ.  I've done a lot of work with DLQs for Topics and I'm fairly certain that each Subscription to a Topic has it's own distinct DLQ.
If you think about it, it makes zero sense for all Subscriptions to a single Topic to share the same DLQ.  Each subscription could represent a separate service/team using that Topic, so if one subscription has an issue processing a message, it makes total sense that that message would go to the DLQ for just that Subscriptions.  Why would the other team/services care?
Just FYI, I have this outstanding question on a forum for general advice on dealing with DLQ's for topics/subscriptions:  https://social.msdn.microsoft.com/Forums/azure/en-US/2a003178-fe60-4ec6-90da-848f5823acf7/need-advice-on-dealing-with-deadletterqueues-for-topic-subscriptions?forum=servbus

Note the updated docs here: https://docs.microsoft.com/en-us/azure/service-bus-messaging/service-bus-dead-letter-queues
"Azure Service Bus queues and topic subscriptions provide a secondary sub-queue, called a dead-letter queue (DLQ)"

@Blackbaud-MikeDuVall The DLQ is configured when you create queue. The DLQ is not configured when creating a topic:

@Mike-Ubezzi-MSFT, I came across this thread today because the Azure product docs still seems to contradict your last comment, "DLQ is configured per queue, not topic". Are you saying there is no concept of a DLQ for topics? Github code samples provides a DLQ path for topics such as "Topic1/Subscriptions/Subscription1/$DeadLetterQueue".
More evidence of a DLQ per topic/subscription can be found here: https://docs.microsoft.com/en-us/azure/service-bus-messaging/service-bus-dead-letter-queues
Could you help us understand this better? Thanks!

Beyond a shadow of a doubt, DLQ's exist for topic subscriptions.   My company is currently heavily using them.  The path you mentioned, "Topic1/Subscriptions/Subscription1/$DeadLetterQueue", is what we use to get to them.

@jordanchang Thanks for pointing this out. I was not pointing out that the DLQ does not exist for Topics. The DLQ exists for both Topics and Queues. I was pointing out the configuration aspect in the UI and the UI has changed a bit. Additionally, the path to the dead-letter queue is detailed specifically as:
<queue path>/$deadletterqueue <topic path>/Subscription/<subscription path>/$deadletterqueue

If you are using the .NET SDK, you can get the path to the dead-letter queue by using the SubscriptionClient.FormatDeadLetterPath() method. This method takes the topic name/subscription name and suffixes with /$DeadLetterQueue.

The original question was with regard to a single DLQ for a topic or many DLQs, one per subscriber. There is a single DLQ that can support multiple subscribers. See: Moving messages to the DLQ (link).


Implement save/saveAll for firestoreTemplate

Regarding saveAll there are actually 2 cases in ReactiveCrudRepository.

saveAll of a publisher
saveAll of an iterable

The first case of the publisher I think we should just be reusing the singular save method we already have since we have no idea how long we would need to buffer the incoming entities before saving. We might as well save as we go.
The second case I think we should be using the write(WriteRequest) batch save.
We should do these in separate PRs.
@dmitry-s @meltsufin  FYI

I think we should use write(WriteRequest) in both cases. It's just that for iterable, you'll only have to make a single call. For the publisher, you would send a series of batches, each one of size 1.
It's a streaming RPC. So, it should be pretty efficient.
  // Streams batches of document updates and deletes, in order.
  rpc Write(stream WriteRequest) returns (stream WriteResponse) {
    option (google.api.http) = {
      post: "/v1/{database=projects/*/databases/*}/documents:write"
      body: "*"
    };
  }

sorry if this is a dumb question, but are you saying that calling write with WriteRequests that have an array of only 1 document (https://cloud.google.com/firestore/docs/reference/rpc/google.firestore.v1#google.firestore.v1.WriteRequest) repeatedly is automatically very efficient?

Right, I don't see a problem with that. The reason it should be efficient is because it's streaming. The fact that there's only one document in the array should not matter much. The point is that the series of WriteRequests is streamed.

@meltsufin  For my curiosity: what does it mean that it's "streaming" ?
From the docs it looks like they give you back a token/id you pass back and forth with each subsequent request. They look like just regular discrete requests physically and that the "streaming" part of it is more of abstract meaning given by one of the parameters (the stream token/id) .

Although the explanations are not very deep, GRPC docs describe streaming here: https://grpc.io/docs/guides/concepts/.
The idea is that backpressure is supported and there is no need for a round-trip for each request.

I believe this is now resolved.


fix(FeatureCardBlockLarge): missing imports

Related Ticket(s)
#3993
Description
add missing image import to featureCardblockLarge in example and stories. Also, fix example for FeatureCardBlock to use DDSImage and import image
Changelog
New

add missing imports

@ariellalgilmore should we actually make image be a dependency of feature-card-block-large, so adopters don't need to import two different things?

@jeffchew Thanks! Let me know if the changes now make sense :)


No module named 'embed'

I have the embed.py file, but I still get the error message No module named 'embed'. Why is that?

这样就可以了，把embed改为models.embed（translation: In this way will be okay, just change "embed" to "model.embed"）
import tensorflow as tf
from models.embed import DataEmbedding
from models.attn import ProbAttention, FullAttention, AttentionLayer
from models.encoder import ConvLayer, Encoder, EncoderLayer
from models.decoder import Decoder, DecoderLayer


Create an RCL to replace direct access to langnames.json

This is to address issue https://github.com/unfoldingWord/tc-create-app/issues/1582
Features of the RCL:

will have a copy of the langnames.json compiled-in (in case we cannot fetch it over the internet)

will cache the last fetched copy of langnames.json

app will be able to over-ride the URL for langnames.json

it will be flexible enough to be used by all our apps.

when app requests the latest langnames, the rcl behavior will be:

it will attempt to fetch the latest langnames.json from the URL passed by app, or if not given it will fetch using the default URL
if that fails it will return the latest cached version from previous fetch.
if no previous fetch, it will return a copy of the langnames.json compiled in.

@PhotoNomad0 will this change fix all of our apps or is it specific to tCC?


Improve content test for videoId field

#1655 made me realize that there was an error in the way the video schema was defined, and it was allowing empty videoId to pass the tests.
The check was also updated so that the top-level videoId must be empty or undefined instead of optional when a video is multi-part. It should help avoid confusion and information repetition.

Hi @fturmel thanks again! Am I confused or is there a mistake in this PR where a bunch of videoIds are removed? Perhaps that is leftover from testing the tests themselves?

Hi @fturmel thanks again! Am I confused or is there a mistake in this PR where a bunch of videoIds are removed? Perhaps that is leftover from testing the tests themselves?

No it's intended, sorry I wasn't clear. There's a bug fix and an improvement in there:

The existing schema validation was supposed to make sure that videoId was required, but the "parts" argument was not destructured from the argument properly. It's basically a Yup library API usage mistake.

The top-level videoIds removed are all for multi-part videos and were effectively useless. I added a check in the content tests to require them to be undefined or empty when a "parts" array exist. Currently they were optional but you could still put a YouTube ID in that field even if it did nothing.

Ah, I see! Thank you for the clarification. Would it be more clear to remove the field entirely rather than have it as a blank entry?

Ah, I see! Thank you for the clarification. Would it be more clear to remove the field entirely rather than have it as a blank entry?

Sure, we can make the check more strict instead of being falsy (which allows undefined, null or empty string). Update incoming.

Done, the videoId field cannot be present anymore if the video is multi-part.

Fantastic!


Support for new valueFormat attribute

Proposal to include new "valueFormat" attribute to ion-autocomplete to allow formatting of a complex model which is bound through items-method.
It could be utilised in such a way:
<ion-autocomplete ng-model="model.AddressCity"
	item-value-key="name"
	item-view-value-key="view"
	items-method="getCityQuery(query)"
	items-method-value-key="items"
	multiple-select="false"
	placeholder="Enter City or Postcode..."
	select-items-label="Select city..."
	items-clicked-method="itemsClicked(callback)"
	value-format="{City}, {State}"
	template-url="templates/city-select.html" />

Closed. See #60 for reference.


[6.0][Concurrency] New runtime entrypoint and SPI to warn about isolation violations

Description: This introduces a new very extensible / configurable runtime entrypoint for isolation checking. We could use it to issue warnings about executing on "unexpected" executor; and could potentially extend it to perform similar checks. This runtime function takes options and flags, so we can configure it depending on future use. This is void returning, unlike the existing runtime funcs which return bool but are forced into "crash only" behavior because of underlying implementation reasons -- we could clean this up in the future, and use THIS function as the crashing one, so the function signature does not lie anymore.
Scope/Impact: Just adding new SPI and runtime entrypoint, no impact on existing functions or runtime behavior.
Risk: Low, only adding runtime entrypoint, without changing existing methods using executor checks.
Testing: CI testing
Reviewed by: @hborla
Original PR: https://github.com/swiftlang/swift/pull/75200
Radar: TODO

@swift-ci please test


schema: Modify App Environment to be a list of name/value objects.

Make environment consistent with isolators and annotations (schema on "left", user values on "right", etc).

Add EnvironmentVariable type.
Add Environment alias for list of EnvironmentVariables
Replace App.Environment field with new Environment type
Plumb App.assertValid through to Environment.assertValid()
Call out and test for IEEE Std 1003.1-2001 in environment variable
identifiers.

One question (and this certainly again raises the idea that we should be sharing code amongst these lists of things), but looks good to me

I am on the fence on this one. Environment variables on all operating systems are simple key/value pairs so I don't know if there is really a schema here that we plan to expand on. The one advantage is that we clearly see the ordering of which value should override which.

Annotations and Isolators are also simple key/value pairs. Given that all three (Annotations, Isolators, and Environment) have the same model, they should probably have the same representation in the schema. It seems a bit like splitting hairs when we're talking about a map at the end of the day...but I think consistency should probably win. Having a consistent schema for maps also affords the application of constraints to be done in a similar fashion (each might have different behavior upon duplicates...e.g. map vs multimap, etc). Which to @jonboulle's point, means they could probably share some abstract base code.

@cdaylward Good argument. Lets do it. +1 from me.


Time slider: Suddenly visible on test.visualize.ch

Describe the bug
I suddenly see the time slider option in the "Öffentliche Ausgaben Dataset".
To Reproduce
Steps to reproduce the behavior:

Go to 'Öffentliche Ausgaben Dataset'
Click on '.Interactive Filters - Time slider'
Choose year
See error

Expected behavior
Deactivate Time slider
Screenshots

or video

Environment (please complete the following information):

Visualize environment and version:  INT v3.13.0 ]
Browser and version Safari 15.6.1

Hi @AnninaWalker, thanks for reporting this. As time slider is only visible if you've set the flag (and the feature is still in alpha stage), I will further work on it during this sprint if time allows. I would not hide the time slider by default taking above reasons into consideration, as it's not visible by default – end users shouldn't have access to it (you could remove the flag from LocalStorage of the browser and then it wouldn't be available).

Perfect. Yes I assumed it must be something like that, but wasn't a 100% sure. But then its fine by me. Thanks for clarifying


OpenStack designate DNS provider

I would like to try to wite dns provider for OpenStack Designate.

Hello, feel free to post here your work on the OpenStack DNS integration in libdns
We can then create a repository and give you access to it 👍

Hi, I think I'm close with the code. I hope I will create a PR soon :-)

I just created PR [https://github.com/libdns/libdns/pull/14]

@mholt

I barely had a chance to start a review, I will finish it soon!


Update the data structure for metrics

What's needed?
The data structures for metrics (Metric and MetricAggregation) are fairly large, and deeply hierarchical. This makes fetching individual metrics difficult.
Proposed solution
We developed a new solution for the problem as a part of prototyping the Reporting API. The solution should be added to to the common specs.
// Common BoundMetrics for the shared fields in Metric and MetricCollection.
message ComponentMetricBounds {
  // The manufacturer's rated bounds of the metric. This may differ from
  // `system_bounds` as it does not take into account the current state of the
  // overall system.
  Bounds rated_bounds = 1;

  // The current bounds of the metric, as imposed by the component this metric
  // originates from.
  Bounds component_bounds = 2;

  // These bounds indicate the range of values that are disallowed for the
  // metric.
  Bounds system_exclusion_bounds = 3;

  // These bounds indicate the range of values that are allowed for the metric.
  Bounds system_inclusion_bounds = 4;
}

// A simple measurement of a single metric for a microgrid component.
//
// !!! note
//     This represents a single data point or measurement for a particular metric.
//     The bounds are optional and may not always be present or set.
//
message SimpleMetricSample {
  // The UTC timestamp of when the data was measured.
  google.protobuf.Timestamp measured_at = 1;

  // The current value of the metric.
  float value = 2;

  // Optional bounds for the component metric.
  optional ComponentMetricBounds bounds = 3;
}

// AggregatedMetricSample encapsulates multiple measurements of a single metric for a
// microgrid component.
//
// This message is used when a component produces multiple data points for the same metric,
// such as a battery composed of multiple blocks where each block has its own temperature sensor.
// The message allows for the reporting of statistical summaries—minimum, maximum, and average
// values—as well as the complete list of individual measurements if available.
//
// !!! note
//     Fields for minimum, maximum, and average values, as well as individual measurements, are
//     optional. This accommodates scenarios where only subsets of this information are available.
//     Similarly, bounds are optional and may not always be present.
//
message AggregatedMetricSample {
  // The UTC timestamp of when the data was measured.
  google.protobuf.Timestamp measured_at = 1;

  // The average measured value of the metric.
  float avg_value = 1;

  // The minimum measured value of the metric.
  optional float min_value = 2;

  // The maximum measured value of the metric.
  optional float max_value = 3;

  // Optional array of all the raw individual measured values.
  repeated float list_values = 4;

  // Optional bounds for the component metric.
  optional ComponentMetricBounds bounds = 5;
}

// MetricSampleVariant represents a variant data structure that can hold either
// a SimpleMetricSample or an AggregatedMetricSample.
//
// This message is designed to offer flexibility in capturing different
// granularities of metric samples—either a simple single-point measurement
// or an aggregated set of measurements for a metric.
//
// !!! note
//     A MetricSampleVariant can hold either a SimpleMetricSample or an
//     AggregatedMetricSample, but not both at the same time.
//
message MetricSampleVariant {
  oneof metric_return_type {
    SimpleMetricSample simple_metric = 1;
    AggregatedMetricSample aggregated_metric = 2;
  }
}

// Component Data Sample
message ComponentDataSample {
  // Current status of the component.
  // might not be known by the Reporting API - would have to be stored into the parquet files
  // ComponentStatus status = 1;

  // List of measurements for a metric of the specific microgrid component.
  map<Metric, MetricSampleVariant> metric_samples = 2;

  // List of states of a specific microgrid component.
  State state = 3;

  // List of errors for the specific microgrid component.
  repeated Error errors = 4;
}

// List of supported metrics.
//
// !!! note
//      This is derived from Protostar Metrics message that needs to be flattened so it can be
//      used as a key in a map.
//
enum Metric {
  // DC electricity metrics
  DC_VOLTAGE_V = 0;
  DC_CURRENT_A = 1;
  DC_POWER_W = 2;

  // General AC electricity metrics
  AC_VOLTAGE_V = 3;
  AC_VOLTAGE_PHASE_1_V = 4;
  AC_VOLTAGE_PHASE_2_V = 5;
  AC_VOLTAGE_PHASE_3_V = 6;
  AC_FREQUENCY_HZ = 7;
  AC_APPARENT_CURRENT_A = 8;
  AC_APPARENT_CURRENT_PHASE_1_A = 9;
  AC_APPARENT_CURRENT_PHASE_2_A = 10;
  AC_APPARENT_CURRENT_PHASE_3_A = 11;

  // ...

  // Moving those from Microgrid components Properties to the enum
  FIRMWARE_VERSION
  BATTERY_CAPACITY
}

Use cases
No response
Alternatives and workarounds
No response
Additional context
No response

Done in #114


Add supporting public_ip_address_id parameter in the API Management module

1787
PR Checklist

[x] I have added example(s) inside the [./examples/] folder
[x] I have added the example(s) to the integration test list for normal (~30 minutes) or long runner >30 minutes
[x] I have checked the coding conventions as per the wiki
[x] I have checked to ensure there aren't other open Pull Requests for the same update/change?

Description

To solve our problem we added supporting Public IP in the APIM module
Does this introduce a breaking change

[ ] YES
[x] NO

Testing

Hello @arnaudlh,
I added an additional example scenario for these changes


Add docstring support for Kotlin

Add support for Kotlin document string, see .emacs.jcs/func/jcs-docstring.el.

This issue has transfer to https://github.com/jcs-elpa/docstr/issues/1. Close this now.


Hard crash when ssl=true and connecting to offline server

When connecting to the database over SSL, but the server is offline, mariasql emits an error event with the following message:
Error: Can't connect to MySQL server on '<IP_ADDRESS>' (61)

Then before the close event is emitted, the following crash occurs:
node(28217,0x7fff75026310) malloc: *** error for object 0x103c55180: pointer being freed was not allocated
*** set a breakpoint in malloc_error_break to debug

This will cause the Node.js process to exit. No bueno.
I'm on OS X 10.9.3, Node.js 0.10.28, mariasql v0.1.21, libmariadbclient 5.5.30.

If server is online, it's also crash with breakpoint:
node(27758,0x7fff79d85300) malloc: *** error for object 0x101ccf20e: pointer being freed was not allocated
*** set a breakpoint in malloc_error_break to debug
Abort trap: 6

@egavrilov Can you please try with the rewrite branch?

@mscdex nothing happens on default example, neither connect, nor error message.


Possibility to select available views for diffSourcePlugin

From https://github.com/mdx-editor/editor/discussions/338

That looks good, I do need to test it before merging.


Candidates page: summary statistics

It would be good if we can also add a display window at bottom showing all parameters in the final_csv file for this particular object. It doesn't have to be well-formatted (a naive table should be fine) and can just display all/every parameters even we add new columns in final_csv file (less likely happen though)
Minor fix

Move "MD Deep" from "Deep stats" to "Statistics" panel
Add units for "sep" in "Spatial Details" panel (deep_sep is in unit of arcsec, beam_sep is in unit of degree, and bright_sep in unit of arcmin)
Can round those numbers to 4 or 5 decimal places
replace "standard map" to "standard deviation"
Show name in the candidate page (based on "name" column in final_csv)
Add flitering based on people's rating and tags/labels

Other fix if we have enough time

Ideally make the web link contains name/SBID/beam information, e.g. ywangvaster.duckdns.org/candidate_rating/sbid=50230?beam=01?name=J043024.66-615211.55? (something like this)
Add a slider bar for "slices" display, and add an input panel allowing us to specify the number of image to display (sometimes can get > 3000 images and it would be really good to have this function

Edit: Move "MD Deep" from "Deep stats" to "Statistics" panel and change the name to "modulation index"

Typo: panel name "Statitics" -> "Statistics"

Completed in #29


--no-startup-id not needed for sway

hey, I will review both PRs today, thanks for the contribution!

Here's some more info for this one:

Startup ID is an X11 flag with no current equivalent on Wayland. Sway ignores the option to make it easy to migrate configs from i3.
https://github.com/swaywm/sway/blob/1211a81aad18bbc4d9e8fb9973238ad8e7e1f688/sway/commands/exec_always.c#L26


Fail to compile when write a helper in template, which contains an URI

I have a helper in template like below.
<!--
{@helper uri}
    function uri(input) {
        return 'http://github.com';
    }
{@/helper}
-->

Then juicer raise an exception Juicer Compile Exception: Unexpected token ILLEGAL
I think issue #76 is the same situation.

Fixed, commit #37c87279e9dc6bfdc7aa251930623c5426ea7ebc.


refactor: move graph responsibilities from routing.ChannelRouter to new graph.Builder

This PR achieves 2 goals:

Moves graph building and maintaining responsibilities from the ChannelRouter to the new graph.Builder. These responsibilities include:

graph pruning
validation of new network updates & persisting new updates (the validation should actually be completely within the gossiper but let's do that in another PR)
notifying topology update clients of any changes.

Removes the ChannelRouter's direct access to the channeldb.ChannelGraph pointer and replace it with an interface instead. This will open up the possibility of providing various other types of graph backends.

This chips away at the first few steps noted in issue #8833 and also takes a step towards #8835 since with this PR, the ChannelRouter now only does path finding and payments.

This change is

cc @calvinrzachman

Thanks for the review @Roasbeef 🚀  Squashed in the latest approach - this is ready for another look 👍

@yyforyongyu: review reminder
@ellemouton, remember to re-request review from reviewers when ready

@ellemouton, remember to re-request review from reviewers when ready

Note that the two required failing tests (unit cover  and neutrino itest) are failing at result-upload time. The actual checks have passed.


Not able to redirect command to function (404 error)

The slack_bolt version
slack-bolt==1.9.1
slack-sdk==3.11.2
Python runtime version
Python 3.6.9
OS info
Ubuntu 18.04.6 LTS
#166-Ubuntu SMP Fri Sep 17 19:37:52 UTC 2021
Steps to reproduce:
I'm not able to get my command to call my python function.
I looked at multiple examples and github issues, without success.
Please guide me in what I'm doing wrong.
Here is my python script:
import os
from flask import Flask
from slack_sdk import WebClient
from slack_bolt import App

app = Flask(__name__)

client = WebClient(token=os.environ.get("SLACK_BOT_TOKEN"))
bolt_app = App(token=os.environ.get("SLACK_BOT_TOKEN"), signing_secret=os.environ.get("SLACK_SIGNING_SECRET"))

@bolt_app.command("/sky")
def command(say, ack):
  ack()
  say(text="sky")

if __name__ == '__main__':
  app.run(host='<IP_ADDRESS>', port=5000, debug=True)

And the command I set on my app:

And the result I get:

Expected result:
I would expect my function to get called.
I was able to make it work without the slack bolt sdk prior to this, but I wanted to migrate to bolt as it looks very user friendly.
Actual result:
It can't find the /sky path for some reason.
I tried to root directly to /sky and many other combinations, in vain.
Requirements
Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.

I found the issue I didn't use bolt_app... I tried too many tutorials today

Hey @MathieuFavreau, checking the following resources may help. Good luck!

https://github.com/slackapi/bolt-python/tree/main/examples/flask
https://slack.dev/bolt-python/concepts#adapters

I followed this tutorial which was wrong, https://python.plainenglish.io/lets-create-a-slackbot-cause-why-not-2972474bf5c1


pre_text and app_text ignored entirely in BatchStringSchedule

Because the interpolate_prompt_series function in BatchFuncs.py ignores the pre_text and app_text arguments, they are never used for the BatchStringSchedule node. As a result, the node will ignore these values when specified in the UI.

I fixed the issue in f36cfef


wpnrtnmrewunrtok.xyz requires whitelisting

Video streams at camwhores.tv are being blocked:
This is due to the following domains being blocked:
wpnrtnmrewunrtok.xyz
camvideo.wpnrtnmrewunrtok.xyz
camvideo12.wpnrtnmrewunrtok.xyz
Steps to reproduce:
Tried to load videos with wpnrtnmrewunrtok.xyz and sub-domains whitelisted, videos load successfully.
Thank you.

Thank you for this @Eow2022yia.
The domain wpnrtnmrewunrtok.xyz comes to us from upstream at yoyo.org.  Please make your case with an email to<EMAIL_ADDRESS>

Thank you for this @Eow2022yia.
The domain wpnrtnmrewunrtok.xyz comes to us from upstream at yoyo.org.  Please make your case with an email to<EMAIL_ADDRESS>
Hi there,
Thanks for your response,
Can this be dealt with on here please?
Thank you.

@Eow2022yia no, this isn't going to change here.  The issue is upstream.

@Eow2022yia no, this isn't going to change here.  The issue is upstream.

I'm sorry, I don't understand what upstream has to do with a blocklist filter rule?
Could you explain further for me please?
Thanks.

@Eow2022yia this is all exolained in the readme. You should read it.
We're mostly an aggregator of hosts files from active and reputable curators of hosts files, and we package these amalgamated hosts files in various ways.
Please submit this request to yoyo.org as I suggested four panels above ⬆.
I'm certainly not gonna make any expceptions for camwhores.tv, ffs I mean, c'mon 🙄
Closing and locking this now.


Doesn't work on Linux Mint 18.2, shift+alt+u doesn't work.

Visual Studio Code Version : [ 1.15.1 ]
Code Settings Sync Version : [ 2.8.2 ]
Operating System : [ Linux Mint 18.2 sonya 64bits ]
Occurs On: [ Configuring ]
Proxy Enabled: [ Yes ]
GIst Id: [ 4174df0c088605e770e07402180750a7e909c0c2 ]

Similar problem in Kubuntu 16.04 as well.
VS Code version: 1.15.1

what is the exception logged, in the developer console

Doesn't work on Ubuntu 17.04. Didn't see any output on the developer console. It simply doesn't work?

It is the same bug as #327. The workaround in there, fixes the problem.

@shanalikhan Didn't see any output on the developer console. It simply doesn't work.

#327 is fixed
@WuShichao can you update the extension and clear all the extension settings and let me know.

@shanalikhan Thx~Now I can upload, but when I download, I just get the errors below

Can't sync, and the "shift+alt+u/d" still doesn't work, but I can type ">Sync" and select them by using mouse.

@shanalikhan Thx~

@WuShichao when you set the sync settings inside settings.json.
make sure you Close settings.json file from editor.
Download again
and then post again this image


Show how to run tests in the README

The readme seems to be missing a pretty obvious thing: how to actually run the unit tests. From what I could figure out myself, it's something like dbt test --model name_of_my_test_file, but I don't know what other options exist.

I think this one should work:
dbt test --models tag:unit-test
But be sure to add unit-testtag to your test model.

Thanks—I raised this issue more for the purpose of "this is something you should include in the README".

Definitely, will do 🙂

Done


update readme file as per comments

…ules
Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.
Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the devel branch until you have checked off each task.

[ ] Place Closes #<insert_issue_number> into the beginning of your Pull Request Title (Use Edit button in top-right if you need to update)
[ ] Code is formatted according to the tidyverse style guide. Run styler::style_file() to style R and Rmd files
[ ] Updated relevant unit tests or have written new unit tests - See Unit Test Guide
[ ] If you removed/replaced any function and/or function parameters, did you fully follow the deprecation guidance?
[ ] Update to all relevant roxygen headers and examples.
[ ] Run devtools::document() so all .Rd files in the man folder and the NAMESPACE file in the project root are updated appropriately
[ ] Address any updates needed for vignettes and/or templates
[ ] Update NEWS.md if the changes pertain to a user-facing function (i.e. it has an @export tag) or documentation aimed at users (rather than developers)
[ ] Build admiral site pkgdown::build_site() and check that all affected examples are displayed correctly and that all new functions occur on the "Reference" page.
[ ] Address or fix all lintr warnings and errors - lintr::lint_package()
[ ] Run R CMD check locally and address all errors and warnings - devtools::check()
[ ] Link the issue so that it closes after successful merging.
[ ] Address all merge conflicts and resolve appropriately.
[ ] Pat yourself on the back for a job well done! Much love to your accomplishment!

Hi Edoardo,
The expectation part has been removed and the future schedule has been updated to the readme, could you please help to confirm if this is ready to merge with the devel? Many thanks!


About local ip address

Hi, Thank you for the amazing toolkit!
My local ip is <IP_ADDRESS>, another PC is <IP_ADDRESS>
My ip <IP_ADDRESS> cannot be linked with OSCKit, but <IP_ADDRESS> can be linked.
Do you think it is possibly due to the OSCKit or it should have worked?

I need more specific information in order to help. "Linked" can mean many different things. What exactly are you trying to do?

I want to send osc signal from my iphone to a pc, UDP way, just send to PC,
single way.
*func* startClient() {

    // OSC client setup

    oscClient = UDPClient(

        //host: "<IP_ADDRESS>",

        //host: "<IP_ADDRESS>",

        host: ip,

        port: 9000,

        queue: DispatchQueue.main//DispatchQueue.global(qos:

.userInteractive)
    )

    print("UDP client set up. \(ip)")

}

Fu-Hao Chen
Ph.D.
Chemical Engineering, Syracuse University
Dr. Ian D Hosein's lab
On Mon, Dec 19, 2022 at 3:31 PM Steffan Andrews @.***>
wrote:

I need more specific information in order to help. "Linked" can mean many
different things. What exactly are you trying to do?
—
Reply to this email directly, view it on GitHub
https://github.com/orchetect/OSCKit/issues/26#issuecomment-1357212830,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AUGHO2COU2UYIHGRGKZPDD3WOAFM5ANCNFSM6AAAAAATDBCPTA
.

Otherwise use OSCClient(), not UDPClient.

Got it. Thank you so much!!!
Fu-Hao Chen
Ph.D.
Chemical Engineering, Syracuse University
Dr. Ian D Hosein's lab
On Mon, Dec 19, 2022 at 3:46 PM Steffan Andrews @.***>
wrote:

Are you using your own UDP framework?
Otherwise use OSCClient(), not UDPClient.
—
Reply to this email directly, view it on GitHub
https://github.com/orchetect/OSCKit/issues/26#issuecomment-1357223307,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AUGHO2GIOBVCJ3SIAKYNNDLWOAHENANCNFSM6AAAAAATDBCPTA
.
You are receiving this because you authored the thread.Message ID:
@.***>

It may work. 11 values should fit within a UDP packet. I would not use an OSCBundle, just send one OSCMessage at a time.
If the packet is too large to send, it will just fail to send. You can try it and see if it works.

Hi,
Since iOS14 requires some privacy settings, may I ask if there is any
bonjour service in OSCKit?
Or do I just need the "privacy-local network description"?
Since some of my customers said they are unable to link to local ip.
I am wondering if I missed some privacy settings.
But in my home wifi, it works very well.
Thank you!
Fu-Hao Chen
Ph.D.
Chemical Engineering, Syracuse University
Dr. Ian D Hosein's lab
On Wed, Dec 21, 2022 at 11:36 AM Steffan Andrews @.***>
wrote:

It may work. 11 values should fit within a UDP packet. I would not use an
OSCBundle, just send one OSCMessage at a time.
If the packet is too large to send, it will just fail to send. You can try
it and see if it works.
—
Reply to this email directly, view it on GitHub
https://github.com/orchetect/OSCKit/issues/26#issuecomment-1360813364,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AUGHO2BS25IBDIZCEK23AMLWOJ3KFANCNFSM6AAAAAATDBCPTA
.
You are receiving this because you authored the thread.Message ID:
@.***>

OSCKit does not contain any built-in bonjour services. It's possible in future it could be added.
If you are trying to communicate with devices on the local area network (LAN) then yes you will want the local network entitlement(s).
If your app is an iOS app, the OS will ask the user to allow the local connection and they must allow it or connections will be blocked and it won't ask them to allow it again.
To check this, in device Settings they would tap on the app and make sure "Local Network" is turned on, like this: