Windows CI is hanging

Looks like windows CI has gotten in the habit of hanging with the test suite. Time to see if it's a new problem with us or a new problem with GH

Whelp that's the same kind of failure we've been seeing lately all the way back on e26ee7da4d7a0adfdc00991351269f240ea66651, so it looks like something outside of our domain changed to cause this to start hanging. Wasn't able to reproduce the hang when running the test suite locally on windows 10 either. Guess I'll just ignore it for now and hope that it eventually goes away

It does look like the hangs are much less frequent back in this point in history though
The biggest change to the test suite since then was the switch from wiremock to tiny_http for setting up the fake servers for us to interact with. wiremock tries to reuse a pool of servers while we spin up a fresh server per test when using tiny_http. My hunch is that there's some implicit cleanup happening that can hang and spinning up more servers is increasing that chance


Inquiry About BLIP-2 Fine-Tuning Code

Hello, I noticed that in your paper, you mention fine-tuning the BLIP-2 model using the DriveLM-nuScenes dataset. However, the provided code only includes the LLaMA-Adapter model. Could you please share the code for fine-tuning the BLIP-2 model as described?
Thank you.

Thanks for your interest. We are working on the code clean up and will release them in the future, please stay tuned. On the other hand, we suggest you using the LLaMA-Adapter one because it supports multi-view input, which is a gread advancement compared to blip-2.


buttons to switch between colors and patterns

Ideally keeping the prompts otherwise the same!

Keeping the prompts otherwise the same is non-trivial since you can't seed Math.random. I'm not going to bother with that.


chore: bump vite-plugin-dts

Question

Resolution
We should keep only plugin type file . The option of vite-plugin-dts is strictOutput .

You're right, it doesn't seem like we need it


Remove jobs notify-suppliers-of-framework-clarification-questions-answers

We have two different Jenkins jobs that can send email 21 "New framework clarification questions and answers have been uploaded". This is because we intended to replace the job notify-suppliers-of-framework-clarification -questions-answers with the more generic and capable Jenkins job notify -suppliers-of-framework-application-event, but we never got around to it (see alphagov/digitalmarketplace-scripts#475 for the history of this).
However, having the two different jobs has caused some confusion, and we've been happily using notify-suppliers-of-framework-application-event for some time, so we can get rid of the older job.

Can we remove the job from the tabs as well please?

Can we remove the job from the tabs as well please?

Yep, of course, I always forget to do that, thanks.


For Windows developers, add a section on how to use Git Bash

Done!
Will need to find someone on windows to test the cmd command for the service principal though


Added support to compare object instance hierarchies. #56

Hi Greg,
As I mentioned in the feature description and in reply to your questions, this PR should answer all. Explicitly, yes all the existing tests passed and I've added mine simulating the feature. It was actually throwing exception on purpose but the fixed code.
Can you check this PR and discuss how you see it?
Pavel

Merged


vendor: update runtime-tools to HEAD

A couple of cross-platform PRs merged.

- What I did
- How I did it
- How to verify it
- Description for the changelog

/test all

/test e2e_fedora

Since tests are green, I am taking it @mrunalp approves. LGTM
Merging.


Bump v1.6.x branch to 1.6.4

[trickle] No significant performance differences

[microbenchmarks] No significant performance differences

test failures:

tsan didn't run on kokoro

[12:09:32][ERROR] Error executing task on slave
java.io.IOException: Failed to clone GitHub repository

macos dbg/opt kokoro: https://github.com/grpc/grpc/issues/12538 (fixed on master)
windows kokoro: https://github.com/grpc/grpc/issues/11383
interop cloud to prod: https://github.com/grpc/grpc/issues/10763
ubsan c: https://github.com/grpc/grpc/issues/11528


A pull/merge/push gone awry?

Sorry guys! I meant to pull, merge, then push, but somehow I wound up causing changes to other people's extensions by accident. And I'm not sure how to fix it.

is 6a42dab2e96fd79f12c00296f3246e042b04e466 the errant commit?
try git revert 6a42dab2e96fd79f12c00296f3246e042b04e466; git push if that's the problem.

6a42dab changed the correct file.
But this one seems to have made changes to Glk Object Recovery and Flexible Windows, neither of which I meant to touch.

well then revert that one. :-)

I tried reverting but I think I'm doing something wrong. I will have to come back to this later. Thanks though.

Hmm. Even though this merge says that changes were made to Flexible Windows and Glk Recovery Object, when I go directly to FW and GRO in this repo, they don't show any new changes.
So...maybe it's just reflecting the changes that were made in my local repo when I merged, and not actually changing FW and GRO again in this repo. I didn't see a lot of merges when I scrolled down to see the repo history, though, so I'm not sure if this is how it's supposed to work.

I'll take a look when I get home. It's probably fine.

There's no problem, that's just how merge commits look sometimes.


metrics completed

@megamsys/megam-dev  Great work  @rajthilakmca. Truly amazing, you singlehandedly hacked this beast. You are showing remarkable ability in coming up with architectural solutions. Keep it going.


tests.bins/dbg/qps_openloop_test (dbg,c++,macos)

https://grpc-testing.appspot.com/job/gRPC_master/15884/config=dbg,language=c++,platform=macos/testReport/junit/(root)/tests/bins_dbg_qps_openloop_test/
Related to #3869?

Are we seeing this after https://github.com/grpc/grpc/pull/5752?

@jtattermusch I don't think so. Then again, the PR's only been landed in master for about a few hours...

Although reported now, this test took place before that merge. I'm tempted to close this unless we see otherwise.

Sounds okay to me.


The "3D Tank Battle Video" youtube link from the 3D-Particle-Effects page is private and can't be viewed.

The 3D-Particle-Effects wiki page was mentioned in Discord recently. I clicked through on the "Tank Battle" link and the video was private. Maybe there's a public version someone knows of? Or maybe just delete the broken link?

Hey @travisfw, I just had a look and couldn't find a public or archived version of the video. But according to Wayback Machine, it was uploaded by John Renner, so if you're interested in the video maybe you could contact him. For the time being I will remove the link from the wiki and close this issue.


Import error:  cannot import name 'BaseKeyedVectors' from 'gensim.models.keyedvectors'

Thanks for making this very useful python package.
I tried to use it. But get an error with the following line:
from wefe.query import Query

---------------------------------------------------------------------------
ImportError                               Traceback (most recent call last)
<ipython-input-3-02319299b065> in <module>
----> 1 from wefe.query import Query
      2 from wefe.word_embedding_model import WordEmbeddingModel
      3 from wefe.metrics.WEAT import WEAT
      4 #import gensim.downloader as api

/anaconda/envs/py37_default/lib/python3.7/site-packages/wefe/__init__.py in <module>
----> 1 from .word_embedding_model import WordEmbeddingModel
      2 from .query import Query
      3 from .metrics.base_metric import BaseMetric
      4 from .metrics.WEAT import WEAT
      5 from .metrics.RND import RND

/anaconda/envs/py37_default/lib/python3.7/site-packages/wefe/word_embedding_model.py in <module>
----> 1 from gensim.models.keyedvectors import BaseKeyedVectors
      2
      3
      4 class WordEmbeddingModel:
      5     """A container for Word Embedding pre-trained models.

ImportError: cannot import name 'BaseKeyedVectors' from 'gensim.models.keyedvectors' (/anaconda/envs/py37_default/lib/python3.7/site-packages/gensim/models/keyedvectors.py)

Hello @santoshbs ,
The error you are describing is related to the gensim package.
Maybe it's not installed or if it is installed, you have an older version.
If you use pip as a python package manager, try running it on a console:
pip install --upgrade gensim

If you use anaconda, try running:
conda install -c conda-forge gensim

Tell me if it doesn't work.
Best regards,
Pablo.

Thanks a lot, @pabloBad. It worked with the following steps:
Downgrade Python to 3.8.0 or 3.7.0.
Downgrade gensim from 4.0 to 3.8.3.
Unfortunately, I had created a word2vec model using Gensim 4.0. An environment with gensim  3.8.3 does not seem to load this. So I guess I have to retrain the model with 3.8.3 and try WEAT for bias.


SCP-644 - Simplify Scale implementation

Simplify implementation of Scale, and change it to Round half away from zero.
Also added detection for shadowed Let variables in new static analysis implementation.

@shmish111, there is a property here https://github.com/input-output-hk/plutus/pull/2161/files#diff-675554bb6ed48c241ae65f1d93f986bcL316 that @nau wrote originally and I modified it. It compares the full implementation to a simpler one that uses round. It is still a bit confusing but I couldn't think of a simpler way of doing it without having lots of ifs


fix: increase max retries to 15

Description

Testing

Additional context

Codecov Report

Merging #75 (7414c4a) into main (85285c5) will decrease coverage by 2.73%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##              main      #75      +/-   ##
===========================================
- Coverage   100.00%   97.27%   -2.73%
===========================================
  Files           15       15
  Lines          440      440
  Branches        66       66
===========================================
- Hits           440      428      -12
- Misses           0       10      +10
- Partials         0        2       +2

Flag
Coverage Δ

integration
?

unittests
97.27% <100.00%> (ø)

unittests-3.10
92.50% <100.00%> (ø)

unittests-3.11
92.50% <100.00%> (ø)

unittests-3.8
92.50% <100.00%> (ø)

unittests-3.9
92.50% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

src/gpt_review/constants.py
100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes


SCARD does not show a key field any more

Describe the bug
The SCARD command needs a key field. It is even displayed in the documentation.
https://redisgrafana.github.io/redis-datasource/redis/SCARD/
Version
redis plug in 1.5.0
Grafana 8.2.0
Steps to reproduce
Create new panel. Add new query.
Expected behavior
Should show a key field.
Screenshots

@BSVogler, thank you for opening the issue.
Fixed and will be released in v2.0.0 today.


KAFKA-17600: Add nextOffsets to the ConsumerRecords

This PR implements KIP-1094.

@lucasbru

I suppose (without checking further) that this would mean that partRecords is empty here.

I assume when control records are returned, partRecords is empty while the position is advances.

I assume when control records are returned, partRecords is empty while the position is advanced.

You are right. Anyway, I'd assume we add a TP to nextOffsets if the position advanced.
I can have a look again tomorrow or next week to see if all comments have been addressed, and potentially merge it.

Thanks @AndrewJSchofield for the pointer. Yes, I followed the code, and as I stated before, when a control record is returned, the size of partRecords is 0 while the offset is updated.

@lucasbru I think the PR is ready for the last round of review. Thanks in advance.


Printing Error

I'm new to Homebrewery and my friend actually suggested the site for better looking pages for my character. However, I've finished one set and went to go and print, it looks fine as a PDF and that is as good as a print preview. Now when I actually print the pages, it is cutting off the other half of the page. So in actuality I only have half of everything that I've typed up over the course of 3 days.
I'm not sure if any one else is having this issue, but I would really like for my pages to print as they are shown, which they should do. I am very confused as to how they are not printing that way. I've tried changing my printer settings, and that didn't work either. Please help me fix this.
The first image is what I want to print and the second is how it comes out.

Never mind I fixed it. It was a browser problem, not a website problem.


Webcam.on() only allows a single handler to be bound

I discovered this when trying to bind multiple event handler functions to a single event, but it seems that the current version only allows a single event to be bound at a time.
Webcam.on('live', function() {
  // do something here with the camera
});

...

// Located somewhere else in code
Webcam.on('live', function() {
  // do something else with the camera
});

Only the most recently set handler will actually fire when the event is created. This seems contrary to how events are typically handled in Javascript - and it would be nice if the could could handle multiple events being attached.

You're absolutely right, Jason.  I'll fix this in the next release.  Thanks!

Just attached a pull request, but not sure if that's the direction you want to go. I noticed that the dispatcher also allows for arrays and global functions to be set.

Here's a simple events thing I wrote a while back. https://gist.github.com/positlabs/7646311

Thanks @scurker and @positlabs!  I may use some or both of these solutions :)

@positlabs's approach would be more beneficial if you wanted to unload event handlers as well. I haven't had a need for it yet, but I imagine there may be instances where someone would be interested.

Fixed in https://github.com/jhuckaby/webcamjs/commit/a7b886e3532a13580072a3fc21e260a44ff33edd
Thanks guys!

:+1: Thanks for hoping for this so quick!


Apply Clang-Tidy's suggestions

Signed-off-by: ice1000<EMAIL_ADDRESS>Applied some suggestions from Clang-Tidy to grpc_wrap.cc since it's originally C but now C++

Nice! Could you create a script to run clang tidy, like #209 ? Also we should use the same config as grpc's https://github.com/pingcap/grpc/blob/1de249c8a21563167152b1c7b794f9f4e4dcb7d0/.clang-tidy

No, Clang-Tidy only provides suggestions, it's CLion that provide fixes. These changes are done in my IDE.
IDE also gives annoying warnings like unused functions to the exported functions

Okay, but it still nice to have a script to provide suggestions.

@overvenus Done. Can we merge this?
Ref: http://clang.llvm.org/extra/clang-tidy/

Seems that clang-tidy itself can provide fixes

Fixed @overvenus

Test
Applied patch:
Index: grpc-sys/grpc_wrap.cc
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
--- grpc-sys/grpc_wrap.cc	(revision d17488a03069e8a8126e0b6ef7380d922d9fd56a)
+++ grpc-sys/grpc_wrap.cc	(date<PHONE_NUMBER>000)
@@ -401,7 +401,7 @@
     grpc_completion_queue* cq, const char* method, size_t method_len,
     const char* host, size_t host_len, gpr_timespec deadline) {
   grpc_slice method_slice = grpc_slice_from_copied_buffer(method, method_len);
-  grpc_slice* host_slice_ptr = nullptr;
+  grpc_slice* host_slice_ptr = NULL;
   grpc_slice host_slice;
   if (host != nullptr) {
     host_slice = grpc_slice_from_copied_buffer(host, host_len);

Output:
Running clang-tidy with: -checks=clang-analyzer-* -extra-arg-before=-x -extra-arg-before=c++ -extra-arg-before=-std=c++11 -extra-arg-before=-I./grpc-sys/grpc/third_party/googletest/include -extra-arg-before=-I./grpc-sys/grpc/third_party/googletest -extra-arg-before=-I./grpc-sys/grpc/include -extra-arg-before=-I./grpc-sys/grpc/gens -extra-arg-before=-I./grpc-sys/grpc/. -extra-arg-before=-I./grpc-sys/grpc/third_party/boringssl/include -extra-arg-before=-I./grpc-sys/grpc/third_party/benchmark/include -extra-arg-before=-I./grpc-sys/grpc/third_party/zlib -extra-arg-before=-I./grpc-sys/grpc/third_party/protobuf/src -extra-arg-before=-I./grpc-sys/grpc/third_party/abseil-cpp -extra-arg-before=-I./grpc-sys/grpc/third_party/cares/cares -extra-arg-before=-I./grpc-sys/grpc/third_party/cares -extra-arg-before=-I./grpc-sys/grpc/third_party/googletest/googletest/include -extra-arg-before=-I./grpc-sys/grpc/third_party/googletest/googlemock/include ./grpc-sys/grpc_wrap.cc

Clang-Tidy stdout:
/home/ice1000/git-repos/PingCAP/grpc-rs/grpc-sys/grpc_wrap.cc:404:32: error: use nullptr [modernize-use-nullptr,-warnings-as-errors]
  grpc_slice* host_slice_ptr = NULL;
                               ^~~~~
                               nullptr

Clang-Tidy stderr:
Error while trying to load a compilation database:
Could not auto-detect compilation database for file "./grpc-sys/grpc_wrap.cc"
No compilation database found in /home/ice1000/git-repos/PingCAP/grpc-rs/grpc-sys or any parent directory
fixed-compilation-database: Error while opening fixed database: No such file or directory
json-compilation-database: Error while opening JSON database: No such file or directory
Running without flags.
2 warnings generated.
Suppressed 1 warnings (1 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
1 warning treated as error

CI failed

CI failed

It's a problem related to #239

---- ping_pong::test_secure stdout ----
testing ping pong ... thread 'ping_pong::test_secure' panicked at 'called `Result::unwrap()` on an `Err` value: RpcFinished(None)', libcore/result.rs:1009:5
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.
stack backtrace:
   0: std::sys::unix::backtrace::tracing::imp::unwind_backtrace
             at libstd/sys/unix/backtrace/tracing/gcc_s.rs:49
   1: std::sys_common::backtrace::print
             at libstd/sys_common/backtrace.rs:71
             at libstd/sys_common/backtrace.rs:59
   2: std::panicking::default_hook::{{closure}}
             at libstd/panicking.rs:211
   3: std::panicking::default_hook
             at libstd/panicking.rs:221
   4: std::panicking::rust_panic_with_hook
             at libstd/panicking.rs:476
   5: std::panicking::continue_panic_fmt
             at libstd/panicking.rs:390
   6: rust_begin_unwind
             at libstd/panicking.rs:325
   7: core::panicking::panic_fmt
             at libcore/panicking.rs:77
   8: core::result::unwrap_failed
             at libcore/macros.rs:26
   9: <core::result::Result<T, E>>::unwrap
             at libcore/result.rs:808

It's unrelated to this PR.

@overvenus @BusyJay @siddontang I think there shouldn't be anything else wrong.

Can you add this to CI check as well?

@BusyJay Done, PTAL

Travis CI is down.

@overvenus @BusyJay @siddontang Any approving reviews?


Use yaml block style for console-search-config string

Description
Use YAML block style indicator in console-search-config data to make string human readable.
Related Issue
https://issues.redhat.com/browse/ACM-11206
Changes Made
Provide a clear and concise overview of the changes made in this pull request.
Checklist

[ ] I have tested the changes locally and they are functioning as expected.
[ ] I have updated the documentation (if necessary) to reflect the changes.
[ ] I have added/updated relevant unit tests (if applicable).
[ ] I have ensured that my code follows the project's coding standards.
[ ] I have checked for any potential security issues and addressed them.
[ ] I have added necessary comments to the code, especially in complex or unclear sections.
[ ] I have rebased my branch on top of the latest main/master branch.

Additional Notes
Add any additional notes, context, or information that might be helpful for reviewers.
Reviewers
Tag the appropriate reviewers who should review this pull request. To add reviewers, please add the following line:
/cc @dislbenn
Definition of Done

[ ] Code is reviewed.
[ ] Code is tested.
[ ] Documentation is updated.
[ ] All checks and tests pass.
[ ] Approved by at least one reviewer.
[ ] Merged into the main/master branch.

/lgtm


webpack: fix removed index.html in previous patch

There might be a better way to do it like the copy plugin, but I'm not super familiar with webpack and this seems to do the job.

There might be a better way to do it like the copy plugin, but I'm not super familiar with webpack and this seems to do the job.

I don't want to keep dist files in the repo.


Updates parsing of yarn.lock to use resolved URLs that are pulled from yarn and npm registries

Signed-off-by: Miki<EMAIL_ADDRESS>The changes include:

making the parser only look for resolved URLs in yarn.lock files
creating a fixture of yarn workspace with skeleton dependencies
updating integration tests in TestYarnPackageLockDirectory validate the results against the fixture
remove old yarn artifacts

Resolves
#925

Question about conflicts, from the existing test fixture:
<EMAIL_ADDRESS>  version "7.7.7"
  resolved "https://registry.yarnpkg.com/something-i-made-up/-/c0n-fab_u.laTION-7.7.7.tgz#b9c2bf5805f1e64aadeed6df3a2bfafb5a73f5a0"
  integrity sha512-p32cOF5q0Zqs9uBiONKYLm6BClCoBCM5O9JfeUSlnQLBTxYdTK+pW+nXflm8UkKd2UYlEbYz5qEi0JuZR9ckSw==

What is the right value here for the package name? c0n-fab_u.laTION or something-i-made-up ? Should we require that the outer package name (in this case c0n-fab_u.laTION) be a substring of the name extracted from the resolved URL? And if it's not a substring, default to the outer package name?

I think the only caveat I see is that using the resolved URL will only match in cases where there is a match with yarnpkg.com or npmjs.org which means that self-hosts/alternative hosting of packages won't be able to leverage the URL.

Correct. For them, it will simply fallback to the name inferred from the identifier. If we find other registry with standardized naming conventions, the regex can be updated.

What is the right value here for the package name?

While I haven't seen a spec doc for the naming convention used, all the resolved URLs I have seen from NPM and Yarn registries have @scope/name/-/name in them. While I am sure there are millions of package-versions on these registries, I have tested the pattern against over 4000 of them. From what i gather, the first @scope/name is what the package confesses to be and the second name (everything after /-/) is to avoid conflicts when downloading the archives prior to an install.
Of course , short of a spec doc from the registries, my 4000 cases of validation are not proof enough that an NPM/Yarn URL with a different structure doesn't exist. However, I think it is a strong indication that we shouldn't expect to see them.
We have 3 options here:

Continue to rely on @scope/name/-/whatever and handle problems when someone raises an issue.
Change pattern to (@scope)/(name)/-/($2) which will fallback to the inferred name.
Change pattern to (@scope)/(name)/-/(another-name) and simply throw a warning about the package name not matching what we expected but continue to use @scope/name` with the hopes that user will raise an issue asking about it.

While I think option 1 is perfect because I don't care for "whatever", I think option 2 will not detract from it but option 3 will encourage feedback.
PS, I will look into the unit test failure.

Approved - I'm updating the unit tests on this now


Add base image override to create testjob command

What type of PR is this?
(feature)
What this PR does / Why we need it?

Allows users to pass in a custom base image when testing new managed scripts.
Depends on backplane CLI changes (https://gitlab.cee.redhat.com/service/backplane-api/-/merge_requests/301) being merged.

Which Jira/Github issue(s) does this PR fix?
Resolves #
Special notes for your reviewer
Pre-checks (if applicable)

[ ] Ran unit tests locally
[ ] Validated the changes in a cluster
[ ] Included documentation changes with PR

Codecov Report

Merging #213 (ff3221c) into main (9d5f461) will increase coverage by 0.03%.
The diff coverage is 75.00%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #213      +/-   ##
==========================================
+ Coverage   51.61%   51.65%   +0.03%
==========================================
  Files          51       51
  Lines        3429     3440      +11
==========================================
+ Hits         1770     1777       +7
- Misses       1366     1369       +3
- Partials      293      294       +1

Files
Coverage Δ

cmd/ocm-backplane/managedJob/createManagedJob.go
73.33% <100.00%> (-0.36%)
:arrow_down:

cmd/ocm-backplane/testJob/createTestJob.go
70.25% <73.33%> (-0.10%)
:arrow_down:

lgtm, I will also check backplane-api code for the baseImageOverride part accordingly. Great work. :)


CREATED A BUDGET TRACKER WEB PAGE

Closes:
Title - Budget Buddy(Expense tracker app)
name - Jiya Bansal
under hacktober fest
Screenshots 📷

@jiyabansal123 provide with a working video.


Fix potentially over-written data

We had a stack allocated buffer assigned to a returned pointer, that is used multiple times. In order to avoid this data being overwritten, we are now allocating the buffer in the calling function.

Due to the reorganization of the TPM context structure in PR #107, this PR has been superseded by that PR. So, I'm closing this.


Adding a basic page for testing tutorial authoring

It's a simple page with the monaco editor on one side and the MakeCode editor on the other. Select your target in the dropdown and press the "Run in MakeCode" button to preview the tutorial! The text in the monaco editor also gets persisted in localstorage.

Hacks:

I had to duplicate the tutorial parsing code from pxtlib. I can fix this later by making some changes in PXT but I wanted this to be standalone for now
The pxt.json for each editor is hardcoded in the ts file
Obviously it is very ugly

Sorry for the gigantic GIF

is this a hack or something we want to push later on?

It would be nice to publish a cleaned up version later. It actually isn't too hacky, we could pretty easily move the parsing into PXT and make this more official


fix: the display issue of integerlike values in nanoplots

Fix #279 . This PR aims to improve the display of integer or integerlike values in nanoplots. During the implementation, I came across two interesting findings in the code:

Some locales may use the minus symbol − instead of -. Therefore, a conversion like str(n).replace("−", "-") might be necessary.
The negative values appear to be handled appropriately with this approach.

demo
from great_tables import GT
import polars as pl

random_numbers_df = pl.DataFrame(
    {
        "i": range(1, 5),
        "lines": [
            "20 23 6 7 37 23 21 4 7 16",
            "2.3 6.8 9.2 2.42 3.5 12.1 5.3 3.6 7.2 3.74",
            "-12 -5 6 3.7 0 8 -7.4",
            "-12 0 15 7 8 10 1 24 17 13 6", # negative values should be ok
        ],
    }
).with_columns(bars=pl.col("lines"))

(
    GT(random_numbers_df, rowname_col="i")
    .fmt_nanoplot(columns="lines")
    .fmt_nanoplot(columns="bars", plot_type="bar")
)

Codecov Report
Attention: Patch coverage is 96.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 82.53%. Comparing base (38033ce) to head (0fb017c).

Files
Patch %
Lines

great_tables/_utils_nanoplots.py
96.00%
1 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #319      +/-   ##
==========================================
+ Coverage   82.45%   82.53%   +0.07%
==========================================
  Files          41       41
  Lines        4258     4283      +25
==========================================
+ Hits         3511     3535      +24
- Misses        747      748       +1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

@rich-iannone do you mind taking a look? The test cases look good, but I'm a bit less familiar with this piece!

This looks great @jrycw ! I also took the opportunity to make the y-axis guides render in the same fashion (stripping decimal part of low and high value if all values of y are integerlike).
Here's what it looks like with my last change applied:

I used the following table code in my tests to examine the rendered values:
from great_tables import GT
import polars as pl

random_numbers_df = pl.DataFrame(
    {
        "i": range(1, 6),
        "lines": [
            "20 23 6 7 37 23 21 4 7 16",  # integer like
            "2.3 6.8 9.2 2.42 3.5 12.1 5.3 3.6 7.2 3.74",  # two decimal places
            "-12 -5 6 3.7 0 8 -7.4",  # not integerlike, one decimal place
            "-12 0 15 7 8 10 1 24 17 13 6",  # negative values should be ok
            "5.23e-11 15E-12 7E-12 8e-12 10e-12 1e-12 24e-12 17e-12 13e-12 6e-12",  # small values
        ],
    }
).with_columns(bars=pl.col("lines"))

(
    GT(random_numbers_df, rowname_col="i")
    .fmt_nanoplot(columns="lines")
    .fmt_nanoplot(columns="bars", plot_type="bar")
)

Let me know if the extra assignments look okay in terms of good coding style.

@rich-iannone, that looks fantastic. Honestly, I had wanted to make similar modifications initially. However, I got a bit lost in the _generate_nanoplot function. Nanoplots is definitely a standout feature of Great Tables, and I truly appreciate it. However, as more features are added, the codebase grows quickly, and it took me a while to figure out my place within each if statement. I feel that we might need to refactor this function into smaller pieces for better maintenance."

Thanks again for (so quickly!) looking at my final changes. Agreed that the nanoplots code could use a refactor and some abstractions, and we'll get there!
Will do a final review now :)


(doc) Typo: 'RandomStringBuilder' -> 'RandomStringGenerator'

Coverage remained the same at 97.833% when pulling 2151502eea87759211267a3c0732f4a8dae6045a on josteitv:master into 13627dab88753468c8d7c530f2fa2e68488a1d4f on apache:master.

Looks good to me. Many thanks for the contribution.


[server] add unused ENVOY_BUG implementation

Commit Message: Adds an implementation for ENVOY_BUG macro that logs at a critical level in release mode, and aborts in debug mode. ENVOY_BUGs will increment a stat every power of two in the server instance.
Additional Description aka Questions for Reviewers:

The power of two logic is contained in the EnvoyBugRegistrationImpl -- I'm not 100% sure if this is the right choice, and that maybe there should be a stats counter that is only incremented on power of two, rather than only calling the action on power of two.
Should logging levels be controlled by a flag?
Should an option to always log be controlled by a flag?
I purposely separated this from the ActionRegistrationImpl that handles ASSERTs, because the power-of-two logic is embedded in the class.

Risk Level: Low
Testing: Added server test testing stats
Release notes: Added note about new server stat, update stats doc
Signed-off-by: Asra Ali<EMAIL_ADDRESS>

@curiouserrandy @antoniovicente

This sounds roughly equivalent to ENVOY_LOG_DEBUG_ASSERT_IN_RELEASE, which I added a long time ago, except with a different macro so that it doesn't apply to all ASSERTs. Can anything be shared between the two, or should ENVOY_LOG_DEBUG_ASSERT_IN_RELEASE be deprecated?

Can anything be shared between the two, or should ENVOY_LOG_DEBUG_ASSERT_IN_RELEASE be deprecated?

Nice question. For re-use, what about when ENVOY_LOG_DEBUG_ASSERT_IN_RELEASE is defined, all ASSERTs are treated as ENVOY_BUGs (log failure, increment  counter)? Does that align with the use of ENVOY_LOG_DEBUG_ASSERT_IN_RELEASE? This would change ASSERT behavior, since ENVOY_BUG has exponential back-off behavior for counter increment and logging. But I think that makes sense for ENVOY_LOG_DEBUG_ASSERT_IN_RELEASE mode as well.
/cc @curiouserrandy

This sounds roughly equivalent to ENVOY_LOG_DEBUG_ASSERT_IN_RELEASE, which I added a long time ago, except with a different macro so that it doesn't apply to all ASSERTs. Can anything be shared between the two, or should ENVOY_LOG_DEBUG_ASSERT_IN_RELEASE be deprecated?

One issue with ENVOY_LOG_DEBUG_ASSERT_IN_RELEASE is the performance cost of enabling this behavior for all ASSERTs.  The two modes satisfy slightly different needs.

Can anything be shared between the two, or should ENVOY_LOG_DEBUG_ASSERT_IN_RELEASE be deprecated?

Nice question. For re-use, what about when ENVOY_LOG_DEBUG_ASSERT_IN_RELEASE is defined, all ASSERTs are treated as ENVOY_BUGs (log failure, increment counter)? Does that align with the use of ENVOY_LOG_DEBUG_ASSERT_IN_RELEASE?

Yeah, I think that would make sense. I think they could use the same stat; they're both indicating roughly the same thing.

This would change ASSERT behavior, since ENVOY_BUG has exponential back-off behavior for counter increment and logging. But I think that makes sense for ENVOY_LOG_DEBUG_ASSERT_IN_RELEASE mode as well.

Agreed.

In my opinion, we should move every ASSERT that isn't in a performance critical path to this mechanism. Would it make sense to make ENVOY_BUG into ASSERT, and then have EXPENSIVE_ASSERT or similar for the cases we identify that are performance sensitive?

Theoretically this sounds nice, but practically I think this will be incredibly difficult to audit that we would feel comfortable with a bulk replace. I would recommend we proceed with this new thing and see how many places we actually end up wanting to use it.

I'm not sure how to proceed here.  Greg/Ashley: Do you want to take over this review?  I'm fine excusing myself from it.

@asraa you have a merge conflict on the version history

ping? I can merge master again if needed. vaguely afraid of triggering tsan failure though


Add Missing Properties for ConfigurationFile.ini

Added additional attributes to better support non Express version of MSSQL
Signed-off-by: Skyler Layne<EMAIL_ADDRESS>Description
Adds better support for non Express versions of MSSQL.
Issues Resolved
resolves #121
Check List

[x] All tests pass. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/TESTING.MD
[x] New functionality includes testing.
[x] New functionality has been documented in the README if applicable
[x] All commits have been signed for the Developer Certificate of Origin. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/CONTRIBUTING.MD

@skylerto Thank you for your PR but this is not inline with the direction this cookbook is currently being developed. Currently the attributes and that particular ConfigurationFile.ini are only being kept for legacy support of an opinionated installation of SQL. The recommended approach for use of this cookbook is to use the install custom resource in a wrapper cookbook.


fix: node-fetch Component Governance vulnerability

Fixes #minor
Description
Fixes the high severity node-fetch vulnerability listed in this CG alert:
https://fuselabs.visualstudio.com/SDK_v4/_componentGovernance/112352/alert/6435491?typeId=10422422
Vulnerability: underscore 1.8.3. Recommended to upgrade to v 1.12.1.
Force node-fetch to v 2.6.7
Specific Changes
Add a resolutions section to the root package.json.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage remained the same at 84.548%

Files with Coverage Reduction
New Missed Lines
%

libraries/botbuilder-lg/src/templateExtensions.ts
1
84.48%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
19667

Relevant Lines:
22035

💛  - Coveralls


Invalid config

I am getting message in notifications:
Invalid config
The following integrations and platforms could not be set up:
bureau_of_meteorology.sensor
bureau_of_meteorology.weather
Please check your config.
removed the component already few time and restarted HA but no change.

Did you install using HACS?

Is there any more details in your logs?

Imstalled using HACS. Logs is showing this:
Logger: homeassistant.setup
Source: setup.py:280
First occurred: November 15, 2020, 11:30:54 PM (2 occurrences)
Last logged: November 15, 2020, 11:30:58 PM
Unable to prepare setup for platform bureau_of_meteorology.weather: Platform not found (cannot import name 'LENGTH_MILLIMETERS' from 'homeassistant.const' (/usr/src/homeassistant/homeassistant/const.py)).
Unable to prepare setup for platform bureau_of_meteorology.sensor: Platform not found (cannot import name 'LENGTH_MILLIMETERS' from 'homeassistant.const' (/usr/src/homeassistant/homeassistant/const.py)).
Could be some sort of conflict with open weather map? reason for asking becaise logs also shows this:
Logger: homeassistant.components.weather
Source: helpers/entity_platform.py:121
Integration: Weather (documentation, issues)
First occurred: November 15, 2020, 11:30:54 PM (1 occurrences)
Last logged: November 15, 2020, 11:30:54 PM
The openweathermap platform for the weather integration does not support platform setup. Please remove it from your config.
ZWhen I have some time I might remove open weather map and see.

Cool! You need to be running Home Assistant version 0.116.0 or later for this component. Earlier versions do not have the built in constants LENGTH_MILLIMETERS and PERCENTAGE so you will have to comment them out, and manually define them like below, OR upgrade your Home Assistant.
If you want to modify the code to be compatible with earlier versions of Home Assistant change the following in custom_components\bureau_of_meteorology\sensor.py, but please note that when you update this component it will override your changes.
from homeassistant.const import (
    ATTR_ATTRIBUTION,
    DEVICE_CLASS_HUMIDITY,
    DEVICE_CLASS_TEMPERATURE,
    DEVICE_CLASS_TIMESTAMP,
    #LENGTH_MILLIMETERS, <----- Comment out this line using the #
    #PERCENTAGE, <----- Comment out this line using the #
    TEMP_CELSIUS,
)
LENGTH_MILLIMETERS = "mm" # <---Add this line
PERCENTAGE = "%" # <---Add this line

thx Bremor, updated and it works now.


pull request for e2e test at 02/01/2017 06:45:14

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


[Enhancement Request] Is it possible to have a way to disable sha256-simd via an env var or some other method?

We are building restic (https://github.com/restic/restic) which uses minio-go - we're building to be FIPS-compatible, so that means it's using a version of goboringcrypto.
What we find is when running in FIPS enabled environments, when the CPU supports it, minio-go is using sha256-simd as a replacement for crypto/sha256.  This ends up creating a hash with sha256.New() which goboringcrypto does not recognize.
        "panic: goboringcrypto: hmac hash not recognized",
        "",
        "goroutine 21 [running]:",
        "crypto/hmac.New(0x8?, {0xc0001f0a80?, 0x0?, 0x8?})",
        "    crypto/hmac/hmac.go:136 +0x229",
        "github.com/minio/minio-go/v7/pkg/signer.sumHMAC({0xc0001f0a80?, 0xc0001f0a78?, 0x8?}, {0xc0001f0a90, 0x8, 0x8})",
        "    github.com/minio/minio-go/v7@v7.0.14/pkg/signer/utils.go:40 +0x4a",
        "github.com/minio/minio-go/v7/pkg/signer.getSigningKey({0xc00003a016?, 0x3?}, {0xe9ec5b, 0x9}, {0x9?, 0xc00019a480?, 0x0?}, {0xe98422, 0x2})",
        "    github.com/minio/minio-go/v7@v7.0.14/pkg/signer/request-signature-v4.go:68 +0xfc",
        "github.com/minio/minio-go/v7/pkg/signer.signV4({{0xe986bb, 0x3}, 0xc000284480, {0xe9d11d, 0x8}, 0x1, 0x1, 0xc0001f9e00, {0x0, 0x0}, ...}, ...)",
        "    github.com/minio/minio-go/v7@v7.0.14/pkg/signer/request-signature-v4.go:289 +0x55d",
        "github.com/minio/minio-go/v7/pkg/signer.SignV4(...)",
        "    github.com/minio/minio-go/v7@v7.0.14/pkg/signer/request-signature-v4.go:317",
        "github.com/minio/minio-go/v7.Client.getBucketLocationRequest({0xc000284240, 0xc000122cc0, 0x0, {{0x0, 0x0}, {0x0, 0x0}}, 0x0, 0xc0001f9c80, 0xc000124be0, ...}, ...)",
        "    github.com/minio/minio-go/v7@v7.0.14/bucket-cache.go:251 +0x770",
        "github.com/minio/minio-go/v7.Client.getBucketLocation({0xc000284240, 0xc000122cc0, 0x0, {{0x0, 0x0}, {0x0, 0x0}}, 0x0, 0xc0001f9c80, 0xc000124be0, ...}, ...)",
        "    github.com/minio/minio-go/v7@v7.0.14/bucket-cache.go:100 +0x118",
        "github.com/minio/minio-go/v7.Client.newRequest({0xc000284240, 0xc000122cc0, 0x0, {{0x0, 0x0}, {0x0, 0x0}}, 0x0, 0xc0001f9c80, 0xc000124be0, ...}, ...)",
        "    github.com/minio/minio-go/v7@v7.0.14/api.go:766 +0xde",
        "github.com/minio/minio-go/v7.Client.executeMethod({0xc000284240, 0xc000122cc0, 0x0, {{0x0, 0x0}, {0x0, 0x0}}, 0x0, 0xc0001f9c80, 0xc000124be0, ...}, ...)",
        "    github.com/minio/minio-go/v7@v7.0.14/api.go:637 +0x458",
        "github.com/minio/minio-go/v7.Client.listObjectsV2Query({0xc000284240, 0xc000122cc0, 0x0, {{0x0, 0x0}, {0x0, 0x0}}, 0x0, 0xc0001f9c80, 0xc000124be0, ...}, ...)",
        "    github.com/minio/minio-go/v7@v7.0.14/api-list.go:206 +0x7b4",
        "github.com/minio/minio-go/v7.Client.listObjectsV2.func1(0xc000122d20)",
        "    github.com/minio/minio-go/v7@v7.0.14/api-list.go:98 +0x24e",
        "created by github.com/minio/minio-go/v7.Client.listObjectsV2",
        "    github.com/minio/minio-go/v7@v7.0.14/api-list.go:92 +0x2ba",
        "ERROR: failure checking existence of repository"

Is there a way to allow an env var or something equivalent to allow us to disable the usage of the sha256-simd library (i.e. fallback to crypto/sha256 for certain envs?
For reference, we've seen that syncthing has implemented a workaround to disable the library via an env var:
https://github.com/syncthing/syncthing/pull/3617

We should not fail in this scenario, we should check why boring crypto is resulting in unexpected output.

I think this is the place:
goboring tries to recognize the specific HMAC that is being used:
https://github.com/golang/go/blob/dev.boringcrypto.go1.18/src/crypto/internal/boring/hmac.go (hashToMD)
We're seeing that hashToMD is returning nil.

Okay that is quite terrible :-)

goboring tries to recognize the specific HMAC that is being used: https://github.com/golang/go/blob/dev.boringcrypto.go1.18/src/crypto/internal/boring/hmac.go (hashToMD)

@aead @klauspost ^^ FYI when FIPS is compiled in.

@tesshuflower The CustomSHA256 in Client options allows you to specify which sha256 hash to use.
The interface is easy to satisfy:
type Hasher interface {
	[hash.Hash](https://pkg.go.dev/hash).[Hash](https://pkg.go.dev/hash#Hash)
	Close()
}

@klauspost I think even if I try to set CustomSHA256 in the the client options, it still ends up calling utilities in pkg/signer that use the sha256-simd?
https://github.com/minio/minio-go/blob/master/pkg/signer/utils.go#L40
This seems to be called from bucket_cache:
https://github.com/minio/minio-go/blob/master/bucket-cache.go#L257
and I don't see where it will use the customsha256 from options in this case - Possibly I'm missing something here though.

I see. That is a mistake.

Yes, a fips build tag is needed. FIPS / boringcrypto requires that a specific implementation of SHA-256 is used. A "custom" SHA-256 implementation (like SHA256-simd) will not work.

With #1700 You can

Use build tag fips

or

Replace CustomSHA256. The custom sha256 will not be used for signatures.

Wow this is great! Thanks very much for the quick turnaround!


call stack view too narrow

I am developing mainly in native and C++, and my call stacks aren't near as readable as one could get in plain GDB. This is what it looks like:

And this is what it looks like me trying to get more visibility:

Neither of the two vscode views actually are useful. Either I can see the editor window OR I can see the call stack somewhat proper.
What I now wish for is the ability (just like in Visual Studio, or, CGDB, ...., to have the call stack view not squeezed into the left panel, but optionally in the lower panel, just like where the (terminal|error|output|...)-panels are.

Somewhat similar to https://github.com/microsoft/vscode/issues/49923
We need a more flexible grid workbench layout (another issues exists for that).
Thus closing as a duplicate


Requires Shadow DOM

Our effect is dependent on using the Shadow DOM. Eventually that will no longer be an option. @mhulse, do you have any idea how feasible is it to eventually get this working without Shadow DOM?

Oh, shadow dom is going away?

Never mind, I misread the message, it turns out that eventually you won't be able to disable Shadow DOM at all, not that Shadow DOM will be going away.


SecurityError when doing SSR with Next.js

Hi!
I ran into an issue when I tried to use stitches with Next.js. Here are the steps to reproduce:

install the stitches-css starter from the Next.js examples
try to load an external stylesheet by adding the following code to _document.js:

  import Document, { Html, Head, Main, NextScript } from "next/document";
  ...

  render() {
    return (
      <Html>
        <Head>
          <link
            href="https://fonts.googleapis.com/css2?family=Roboto&display=swap"
            rel="stylesheet"
          />
        </Head>
        <body>
          <Main />
          <NextScript />
        </body>
      </Html>
    );
  }

get the following error (in Chrome):

SecurityError: Failed to execute 'insertRule' on 'CSSStyleSheet': Cannot access StyleSheet to insertRule
createCss
./node_modules/@stitches/css/es/index.js:183

It looks like something like this is the problem - maybe the insertRule order is off when there's already existing stylesheets?

Im pretty sure this was fixed in the latest release. Which version you on?

Yep you're right @peduarte, the version in the Next.js was 3.0.2, once I upgraded it to 5.0.0 the problem went away. Thanks!


Add a pop up dialog box for Polls/Survey done !

Hello, PR
done - #724
Type of PR

[ ] Bug fix
[x] Feature enhancement
[ ] Documentation update
[ ] Other (specify): ___________

Checklist

[X] I have performed a self-review of my code.
[x] I have tested the changes thoroughly before submitting this pull request.
[x] I have provided relevant issue numbers, screenshots, and videos after making the changes.
[x] I have commented my code, particularly in hard-to-understand areas.

@swaraj-das

@swaraj-das @AnitSarkar123

@swaraj-das @AnitSarkar123 please merge my PR with level 3 & gssoc-ext label

@swaraj-das @AnitSarkar123 please merge my PR with level 3 and gssoc-ext label 😭

@swaraj-das @AnitSarkar123 please merge my PR with level 3 and gssoc-ext label 😭😭

@swaraj-das @AnitSarkar123 please merge my PR with level 3 and gssoc-ext label 😭😭

@swaraj-das @AnitSarkar123

@AnitSarkar123 @swaraj-das sir plese add level 3 and gssoc-ext label, today is the last day...

@AnitSarkar123 @swaraj-das sir plese add level 3 and gssoc-ext label, today is the last day...

@AnitSarkar123 @swaraj-das sir plese add level 3 and gssoc-ext label, today is the last day...


Tin destroyed when mining

While I was mining (specifically for tin), it dropped two half-slabs (placeholders, probably), they went into my hotbar and then disappeared from my inventory. It didn't do this yesterday and the only difference is I'm wearing armour and using a diamond pickaxe instead of an iron one.

I'm having the same issue. Maybe 1 in 10 of the new oars I mine actually go into my inventory. They turn into half slabs and disappear It doesn't matter what pickaxe I use or if I'm wearing armor.

I am also still having this issue, hopefully the update will be released soon, kinda breaks it for me

Should be fixed in 2.1 Prerelease 2


Inference Training pipeline

@ziyi-yang @zinengtang  Thanks for sharing the wonderful work but can u please let us knw when shall be the inference and training pipeline along with pretrained weights be release ??
Thanks in advance

Hi, thanks for the interest in our work. The inference script is just merged: https://github.com/microsoft/i-Code/pull/50.


IDVA6-1792: Updated versions of all dependencies.

Short description outlining key changes/additions
Updated versions of all dependencies.
JIRA Ticket Number
IDVA6-1792
Type of change

[ ] Bug fix
[ ] New feature
[ ] Breaking change
[x] Infrastructure change

Pull request checklist

[x] I have added unit tests for new code that I have added
[x] I have added/updated functional tests where appropriate
[x] The code follows our coding standards

An exhaustive list of peer review checks can be read here

CI: Security warnings found!

CI: No security warnings found


Config file

Implemented the config file as mentioned in https://github.com/eugenevinitsky/sequential_social_dilemma_games/issues/151.
4 questions:

All run scripts work, except train_baseline_actions_dqn, I presume you're working on a private/unpushed ray branch?
Currently wondering: should we get rid of tf.app.flags and retrieve values from the dictionary created by config_parser directly?
tf.app.flags adds the benefit of command line arguments, are you currently using those?
Some parameters have not been implemented/are commented out, specifically the redis/memory/debug parameters. Either the debug flag is not needed anymore, or would you prefer debug-specific values for these parameters?

I haven't reproduced the results from the paper yet. Currently it takes me 6 days to take the 3e8 steps required per experiment - I'm in the process of requesting more powerful hardware.

Additionally, I imagine some train_* files can be merged when parametrized, there's a lot of duplicate code in there. Separating the experiment categories (baseline, visible actions, influence, moa) from their algorithms (A3C, A2C, DQN) so they can vary independently would be ideal, although I'm not sure whether it's easy to do.

These changes are all very outdated, and I'm getting rid of config_parser in my fork. Thus, closing.


Gamepad face buttons are not recognized correctly

Tested versions

Reproducible in: 4.3.stable
Not reproducible in: 4.2.2.stable

System information
Godot v4.3.stable - macOS 14.5.0 - Vulkan (Forward+) - integrated Apple M1 - Apple M1 (8 Threads)
Issue description
After updating to 4.3 from 4.2.2, the face buttons in my gamepad started being wrongly recognized by Godot.

The Top Action is recognized as the Left Action.
The Left Action is recognized as the Top Action.
The Bottom Action is recognized as the Right Action.
The Right Action is recognized as the Bottom Action.

The gamepad I use is an 8bitdo Pro 2 (https://www.8bitdo.com/pro2/), connected via wired connection to my computer.
I tried going to a 4.2.2 project, and it's still recognized properly there.
Steps to reproduce

In a 4.3 project, go to the Input Map.
Try to set an input with a gamepad's face buttons.

Note that since I only have access to one gamepad, I'm not sure if this can be reproduced with other gamepads.
Minimal reproduction project (MRP)
N/A

Related to https://github.com/godotengine/godot/issues/95588.


Update OperandType for new capstone version, split loader option in t…

…he cli, add new option to directly set the capstone ARCH and MODE for the decompilation (used by binexport backend)

I've corrected a couple of typos and removed some leftovers.
I also added the __len__ method to GenericGraph that was missing.
For the rest it LGTM.


remove analysis page and add it as a type of notice

Pull Request Test Coverage Report for Build<PHONE_NUMBER>7
Details

68 of 68 (100.0%)  changed or added relevant lines in 7 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.003%) to 99.38%

Totals

Change from base Build<PHONE_NUMBER>2:
0.003%

Covered Lines:
5781

Relevant Lines:
5800

💛  - Coveralls


Have you considered to use brew bundle

Have you looked into using https://github.com/Homebrew/homebrew-bundle for managing the brew dependencies instead of using the manual way you do it now ?

So a Brewfile is definitely a simpler solution which wouldn't require any scripting on my part. The Homebrew configuration currently only exists for installing packages on a (future) fresh machine. Part of that is installing software which I don't have currently installed through Homebrew.
e.g. I'll want to install Adobe Creative Cloud via brew cask install. However, Adobe CC wasn't initially installed through Homebrew on my current machines. So if I were using a Brewfile, brew bundle dump --force would remove adobe-creative-cloud every time. Currently all I have to do is echo "<package>" >> packages.txt when I want to add a new package; I don't need to worry about accidentally removing a package.
I'll admit I wasn't well-versed on Homebrew's bundle feature before since I wasn't aware of all the arguments you could apply in a Brewfile. I'll definitely reconsider my approach in the future if maintenance becomes too cumbersome.


slow performance both on iphone 6 and simulator

Hi,
I am experiencing slow performance (lagging) when I run your example code. Both on Xcode simulator and when built on Iphone 6. everything is up-to-date (xcode, ios).
any ideas? thanks.

@michalfeher I think it's because it uses TweenState instead of the React Native Animated Api ;)

@ahanriat thanks, could be. but building it with the dev flag set to false made it run 60fps :)

It's because it calls Javascript on each frame. When the dev flag is set to true, each time your component is re rendered (with TweenState), there is a lot of overhead (check of propTypes etc..). When using the Animated Api, you can offThread the animations, and update style without re render your component. So even with the dev flag set to true, it will run at 60fps ;)

I'm also seeing poor performance. It seems to happen the most after heavy scrolling.

This is with the dev flag set to true.

Whaooo that's rude ! You should try this branch https://github.com/dancormier/react-native-swipeout/tree/dc-redux, it use Animated Api :smile:

@ahanriat this is not a jab at you nor your code, simple an observation. I'll check out the branch.

Hi @ahanriat, @bsudekum, @michalfeher,
The current master does use tween-state, which creates this laggy performance. The branch @ahanriat referenced is not yet ready for release, but it's almost done and it does use the RN Animated
API. Hopefully, I can find some time to wrap it up and release this majorly updated version soon. All contributions are welcome!

Also, for anyone wondering what's left for the next major update:
https://github.com/dancormier/react-native-swipeout/tree/dc-redux#to-do-for-v300-issues

Yeah sorry for the confusion, I just wanted to say that the animation was very very slow ;)


Add tileSize and zoomOffset options

As described in the Mapbox docs, their tiles are meant to be rendered at 512x512px. The idea is to reduce network overhead by reducing the number of necessary network requests.
Leaflet supports this by allowing the user to specify two options:

tileSize
zoomOffset

This issue is related to this https://github.com/greensopinion/flutter-vector-map-tiles/issues/21#issuecomment-1031584292.

Thanks for the issue. If I understand correctly, Mapbox tiles should already work - but this is needed to use Mapbox as intended.
It would be great if we could address it with a single setting rather than two. Feel free to submit a PR.

Mapbox tiles are drawn correctly in terms of scale already, it's just very inefficient. There is also a misalignment of the details that should be visible at a given integer zoom level, which means that small features are displayed at a zoom level where they are barely visible.
I would prefer a single setting, but I also like Leaflet's approach because it's not specific to one vendor.

This is a good idea, but I'm not working on it right now. Feel free to submit a PR.

completed in 1.4.7, see VectorTileLayerOptions.tileOffset


Build not being updated, old version showing

In this project, I tried to stop and start with:
yarn run haul start -- --platform ios
But My build still contains the old UI:

After rebuild looks the same:

not showing the new code

I closed the ios simulator and reran react-native run-ios

Unfortunately, I couldn't reproduce it.
Try the following:

Turn on Live reload and see if saving reloads your app
Check if Haul contains any warnings / errors in regards to your application code

From the screenshots, I can see you are using text, instead of Text (note lowercase), which explains why you are seeing old UI (new one is not compiling)

Changing to Text has no effect I'm afraid:

No errors on the haul side. Are you able to see the text now if you compile my app?

Can you provide a full gist of your index.ios.js so that we can reproduce it? Have you tried running React Native packager to see if it works?

https://github.com/QuantumInformation/react-native-cron/blob/master/demo/index.ios.js
I'm gonna do a fresh install of react native for the 4th time to see if it works, if not I'll have to wait.

no luck

This might sound farfetched, but have you checked that you're running the packager in the same folder where you're editing the files? Very easy to make mistake when you've the same folder in 2 places.

I've done a reinstall of everything, somehow its working now.

Sorry guys on this new app, I made a change and then haul saw the change and updated:

If I make a change in an external node modules file, then the change is not pulled in, only if I update the actual project code
However running cmd+r and refresh on the debugger UI and the old code is there.
I fired up yarn run haul start -- --platform ios again and ran react-native run-ios and still the old code in the external node modules folder.

Seems as haul can't recognise any change in node_modules, it only loads the initial version the first time haul is run and then doesn't reload it.


Fixed empty NdOverlay on initialization in batched mode

Previously some parts of the plotting code would receive empty NdOverlays on initialization causing it to break. Now the plot is initialized on the last non-empty frame. Since the plot is updated subsequently with the correct frame this should not cause any issues.

Tests have passed. Merging.


google-apputils: enable for py3k

Motivation for this change
No apparent reason for it being disabled per #21061. I guess we'll find
out if there was a reason.
Things done

[x] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] Linux

[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip" (none depend)
[x] Tested execution of all binary files (usually in ./result/bin/) (none present)
[x] Fits CONTRIBUTING.md.

There seems to be an ubuntu package for python3 too, so it should be ok: http://packages.ubuntu.com/de/xenial/python/python3-google-apputils

Thanks!


feat: search-and-rescue network and training

Hi @sash-a , just making this smaller PR for the training network additions, just wanted your input on the structure and some of the proposed changes, see comments below. This probably still needs some tweaking though.

Thanks for this I'll have a look on Monday/Tuesday.
I didn't realise we didn't have anything setup for continuous distributions, sorry about that! At a glance your implementation looks pretty great though so thanks for all the extra work!
On a side note I'm surprised we don't use distrax or tfp I wonder how grad will work because they have stuff like inverse and log_det_jacobian. I guess we'll find out when we train it 😂. I'm not opposed to adding a distribution library as a dependency if needed, but you don't need to do unless something isn't working

On a side note I'm surprised we don't use distrax or tfp I wonder how grad will work because they have stuff like inverse and log_det_jacobian. I guess we'll find out when we train it 😂. I'm not opposed to adding a distribution library as a dependency if needed, but you don't need to do unless something isn't working

Haha, yeah actually was going to ask if Distrax was an option but didn't want to make too massive a change. For now I could add it as a dependency, then use it inside the normal distribution so it's relatively low impact?

How does it train, have you tried yet?

It runs, but I actually need to leave it going, will try it later in the week.

If this becomes too much of a hassle to test I think testing it mava will be much easier - all the networks etc are set up it would just require a small wrapper. See if you can get some signal here but if not let's switch to mava and see if that is easier to set up

So I implemented the the continuos actor and critic to return [batch, n-agents, n-actions] and [batch, n-agents] respectively, and it raises an error
Error in rank compatibility check: input 0 has rank 2 (shape (20, 2)) but expected 1; input 3 has rank 2 (shape (20, 2)) but expected 1.

raised here by rlax when calculating the advantage here, I think because the critic is returning a rank matrix of values per agents.
Comparing to the lbf policy, though it generated actions for multiple agents, it only returns a single values for all the agents by summing over the embedding here and then it returns individual actions per agent, but then when calculating the log-prob, it sums over the agent dimension here as this value is set to one, to get a an array [batch-size,] of log-probs.
We can probably do the same for the log-prob calculation for the continuos actions (i.e. sum over the agent dimensions) , but I'm a little less sure of the equivalent  single value across agent actions. Looks like this needs to be done in the critic network, guess I could flatten the individual observations into one large one?

Sorry I guess I wasn't clear, my comments were for the actor network. The critic should return a single value over (what we call in MARL) the joint-observation (ideally the state, but we don't have access to a true state representation here and the joint-observation is close enough). So you can basically pass the observation concatenated on the agent dim to the critic and return a single value for each item in the batch so the shape should be batch. This should solve the GAE issue as your value will now be the expected shape.
It should also be fine for your actor to return [batch, n-agents, n-actions] as it should be what the environments expects

Sorry I guess I wasn't clear, my comments were for the actor network. The critic should return a single value over (what we call in MARL) the joint-observation (ideally the state, but we don't have access to a true state representation here and the joint-observation is close enough). So you can basically pass the observation concatenated on the agent dim to the critic and return a single value for each item in the batch so the output shape of the values should be (batch,) which should match other environments (I think). This should solve the GAE issue as your value will now be the expected shape.
It should also be fine for your actor to return [batch, n-agents, n-actions] as it should be what the environments expects

Thanks yeah just made these changes, need to finalise the bijector, but seems to be working ok now!

Hi @sash-a, so this is running, and seems to be learning, something though not clear-cut.
This is the random policy  (blue) v a2c stochastic eval (orange) with 100 targets and 2 searchers

so it's doing marginally better but not by much. The greedy policy seems to settle on a consistently better strategy, but again not by a huge amount, and seems to not continue improving

Though in the current setup it's maybe hard to see what an optimal strategy could be, if the targets are distributed uniformly then a random search is probably not bad as long as you also try avoid other searchers. I image if the agents had some memory or were recurrent networks then they could learn a search pattern?
FYI I was going to merge this as it was meant to be a short branch just to sort out the training functionality.

What is the current default setup?

So this is random uniformly distributed targets, with random noisey movements (though checking now this is maybe a bit too noisy), and the rewards are summed over the agents (via the wrapper), with rewards shared in the case targets are simultaneously detected. Agents see other searching agents (within range) as part of their observation. So apart from other agents location they don't have a lot of info to go off.
One thing we discussed was having the agents be able to visualise targets as part of their observation, feels like it would make it easier, for example as agents could look at areas of low found target density (at least for a uniform distribution). Can see how it could be an optional feature, though you mentioned maybe tricky with the observation spec

I think I should have some time (possibly tomorrow) to test this in Mava I imagine some centralized training and memory would help here like you pointed out and that will be difficult to add here but already exists in Mava. Unless you want to test it in Mava, but I am happy to as I realize this would be another library to learn for you 😄

If you have time that'd be great, but let me know if not, I was keen to try out Mava anyway and have a bit of time.

though checking now this is maybe a bit too noisy

One important thing to check is that targets are significantly slower than the searchers, maybe 50% of their max speed, just so they are catchable.
I think test out whatever you think might make the problem easier. Number 1 thing I'd recommend is less agents and targets.

If you have time that'd be great, but let me know if not, I was keen to try out Mava anyway and have a bit of time.

I'll try to get to it tomorrow, at least I should be able to set up a branch where it will be piping through, not sure if I'll be able to run thorough tests

FYI I was going to merge this as it was meant to be a short branch just to sort out the training functionality.
No stress on this taking longer, unfortunately it always does take longer than you'd expect, I think let's keep it here for now as it's definitely easier.

Sorry more mean that I wanted to merge this branch into the main fork, just so it's a bit easier to track changes with new branches, then this one long-lived branch of the fork!

Ah I see, good plan easier to track new changes :smile:
Also I briefly started but didn't finish the Mava stuff on Friday, should finish it today :smile:


feat: add support to linux/aarch64

Adding support to aarch64 architectures on linux, as requested in https://github.com/bab2min/tomotopy/issues/196
It also keeps compatibility to M1 cpus

@claudinoac I've added CI for aarch64 Linux and fixed some scripts for the compilation.
It seems to work well. Thank you for your contribution.
I'll merge it.

@bab2min Thanks!


How to prepare the text data in Kosmos-2

Hello, thanks for your great work.  I am trying to train kosmos-2, yet I don't know how to prepare text data, when I set the /path/to/text config/ to None  (followed the instructions in train.sh), I got an error, it seems that the text data is necessary.

So how should I prepare this train-nogithub-noarvix-nopubmed-mtnlg.json,  any help will be appreciated.

We only provided the GRiT data as shown in the repo. For text data and interleaved data, you can prepare your corpora and update the data loader following your data format. You can use RedPajama/RefinedWeb and mC4 for these two parts.

We only provided the GRiT data as shown in the repo. For text data and interleaved data, you can prepare your corpora and update the data loader following your data format. You can use RedPajama/RefinedWeb and mC4 for these two parts.

Thanks for your reply, I also want to consult you are the text data and interleaved data necessary, can I train the model only with GRiT data?

Text data and interleaved data are mixed in to make sure that language capabilities and multimodal in-context learning can be retained. If you only need multimodal grounding capability, the GRiT dataset is enough for tuning. But you would expect more, the other corpora are needed.

I see, thanks for your kindly reply!


random FetchErrors when querying the api

I have the following query to build my routes in nuxtJS. We have quite some pages in our project and while fetching we often get the following errors:
FetchError: request to https://OUR-PRISMIC.cdn.prismic.io/api/v2/documents/search?page=1&pageSize=1&ref=[...] failed, reason: socket hang up

or
FetchError: request to https://climeworkscom.cdn.prismic.io/api/v2/documents/search?page=1[...] failed, reason: read ECONNRESET

This is the query.
     const page = initApi().then(api => {
        return api
          .query(Prismic.Predicates.at('document.type', 'page'))
          .then(response => {
            return response.results.map(payload => {
              return `/page/${payload.uid}`
            })
          })
      })
 [...]
    const results = [page, news, events]
      return Promise.all(results).then(values => {
        const allRoutes = []
        values.forEach(value => {
          allRoutes.push(...value)
        })
        return allRoutes
      })

Any idea why this happens? And how can we make sure that the requests succeed?

turns out i've used an old version of node-fetch. upgrading to<EMAIL_ADDRESS>solved the issue.

Hello,
There are no reason it should happen. Could you contact the support so we check the logs on our side?

@Bergrebell we have been getting some of those, as well, if you have any insight to share let me know, thanks!

@timtyrrell - we moved to heroku (ssr instead of pre-rendered via generate) because of this. but i've found this article by markus oberlehner that seems to solve this issue. you can find it here.


chore: optimize Argos CI setup

Motivation
Argos visual diffing CI is heavy to run, and in many cases we don't need to run it.
Let's run it more responsibly, only when we add an Argos label to the PRs that need it.
This also permits to dogfood a responsible setup that I plan to recommend to the community, so that they can stay under free quote (Hobby plan) or Fair-use (Open source)
Test Plan
CI

Does this work when the label is added later?

Does this work when the label is added later?

Yes it should because I added the "labeled" activity type (which is not a default activity type for the PR event)
  pull_request:
    branches: [main]
    types:
      # Those 3 are the default PR workflow activity types,
      # see https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request
      - opened
      - synchronize
      - reopened
      # We want trigger workflow on labeled too!
      - labeled

The tradeoff is that this workflow will also run if PR has already label "Argos" and we add a new label

Just added the label and it seems to be working:

There's probably a way to optimize even more and avoid the tradeoff above but that does not seem like a big deal for now

We can even go further and make it manually-triggered only. Just random thoughts.

That's what I suggested the Argos team to implement.
We can do that in GitHub with:
on:
  workflow_dispatch

But I don't find this UX very convenient so I prefer the label option for now


[SUGGESTION] Add jexactyl install & uninstall

yes please

i will add it soon

all good
and done


[EVO-972] Add Translations

Here is the branch we'll need so that Suspense works once this is deployed to staging or production: https://github.com/Hylozoic/hylo-evo/pull/1322

Merged dev back into this branch and included a bunch of tweaks.
I have a list of components that were impacted by merge-conflicts and I'm going to try validate that each is now working as intended. Basically any front-end work done between now and December might be a bit off.

Ok....
Draft es translations are now available.
I would like to work towards merging this branch into dev. I've scanned over the app and different components multiple times but we'll still probably want to test it in staging anyway.
After that, we can then progress with work on adding a way to select languages.

/Users/tibet/Dev/hylo/hylo-evo/src/routes/NonAuthLayoutRouter/util.js has a translation TODO in it

Found bug: try going to group explorer and selecting Farms and then clicking on the Filters - it crashes saying Error: Rendered more hooks than during the previous render.

Bug: the Create Role button says t('Create Role')

This function relies on an english language string to detect if its an error or not... that's not going to be reliable going forward. I am leaving this as a todo for #1498

Found a little broken spot: go to a User's profile and change the dropdown from Overview to Posts and it says "{{name}}s posts". (Also the posts don't load but thats a separate bug which i have filed)

Mousing over the visibility setting icon for a group in the group about info on the group explorer is showing this partially translated text: "Público - Anyone can find and see this group"

On the notifications settings page the text On and Off is not translated, and neither are the tooltips when hovering over the On/Off buttons


Unable to put an overlay of smaller size than the resized  image

Hi I have a functionality to put a default overlay on top of images of different sizes
and using sharp for generating those images
The error comes up saying the overlay image should be of same size of resized image
Is there a way to do the same

Hello, please try with the latest version:

"Improvements to overlayWith: differing sizes/formats, gravity, buffer input."

http://sharp.dimens.io/en/stable/changelog/#v0140-2nd-april-2016

@sbsomya Were you able to try with v0.14.0?
http://sharp.dimens.io/en/stable/api/#overlaywithimage-options

Yess lovell
Thanks

@lovell I am on 0.21.2 and this issue still exists


Update design of accordion component

What?
Porting the Design System's Accordion component into the gem and updating the Design to improve a11y and usability.
Why?
GOV.UK currently uses 3 different accordions on different parts of the site.  Some of them are not as accessible as they could be and they are not consistent in the way they open and close (the language they use). This is a fail of WCAG SC 3.2.4.
This update is part of on-going work to improve and create a consistent design that might eventually feed into the Design System depending on further research / outcome of performance. (Ticket)
Visual Changes
Before (left) After (right)

Interactions demo

Assistive Technology Testing

Testing Videos, Notes & Discussion
https://user-images.githubusercontent.com/71266765/106886676-0fde5780-66dc-11eb-8b41-cb0e99f0e060.mov
https://user-images.githubusercontent.com/71266765/106749352-52d9f580-661e-11eb-85fc-1f78fb368f8e.mov
https://user-images.githubusercontent.com/71266765/106749366-55d4e600-661e-11eb-97b5-c174e851b923.mov
https://user-images.githubusercontent.com/71266765/106749370-566d7c80-661e-11eb-99d2-809ed422d51a.mov
https://user-images.githubusercontent.com/71266765/106749373-57061300-661e-11eb-8a4a-60cc9cbc231e.mov
https://user-images.githubusercontent.com/71266765/106749377-57061300-661e-11eb-8d4f-48d52ada308a.mov
IE11

The heading reads the "Show / Hide this section" copy that is potentially redundant or confusing information to the user. This ties into comments from the original Accordion below:

The ‘Open all’ button reads out as ‘Open all sections’ for screen readers. This is potentially confusing for users as the visual content is different to what screen readers read out.
After discussion with team it was noted that this was based on the tested step-by-step and while not perfect is not an WCAG fail.

The markup on the accordion was queried if this is an issue with WCAG 1.3.1.  As this is essentially a large button but semantically is a section, with a heading, with a button.

After discussion with team it was noted as not a WCAG issue.
Partially related, it was noted as a non-blocker that that these focus states do not align. On further testing it appears this is also true with NVDA.

The change in focus states was queried if this would impact WCAG 3.2.4 as it's not consistent with other elements.

The team decided this was not a WCAG concern.
Possible Improvements

The Chevron could offer a visual cue on hover (after team discussion it was decided the current the affordance is fine)

Once the Accordion is opened, some work was done to auto-focus the inner Content once expanded for AT, I removed it as part of this PR as out of scope.

Buttons receiving the “hand cursor” has been noted as not strictly best practice. Needs discussion.

Anything else

Open PR on collections to ensure Design updates cascade through to uses on other repos.

Step-by-step update also implements this new Design in parallel (to resolve WCAG 3.2.4)

Porting over from Design System common.js polyfill for nodeListForEach
Conversation about altering this referenced here:

Further conversations about this element within the Design System are happening here

There is also a different prototype here

Issue raised as a reminder to remove this Gem Isolation after Design system updates to this element to stay inline with current architecture

Gem Doc's were updated to explain what Experimental means

A couple of visual things:

when focused and hovered, the heading text appears to be purple/dark blue instead of black whilst the show/hide text is black; I think that the heading text should be black for the best contrast.
the yellow background takes up all the space, but the screenshots on the pull request description show yellow only taking a portion of the accordion. Which is correct?
the grey border is still present during the focus state, sandwiched between the yellow and the black. I think that this should be removed when focused.

A couple of visual things:

when focused and hovered, the heading text appears to be purple/dark blue instead of black whilst the show/hide text is black; I think that the heading text should be black for the best contrast.
the yellow background takes up all the space, but the screenshots on the pull request description show yellow only taking a portion of the accordion. Which is correct?
the grey border is still present during the focus state, sandwiched between the yellow and the black. I think that this should be removed when focused.

A couple of visual things:

when focused and hovered, the heading text appears to be purple/dark blue instead of black whilst the show/hide text is black; I think that the heading text should be black for the best contrast.
the yellow background takes up all the space, but the screenshots on the pull request description show yellow only taking a portion of the accordion. Which is correct?
the grey border is still present during the focus state, sandwiched between the yellow and the black. I think that this should be removed when focused.

+1 to all of these, the Design has been updated since this was initially raised so will all be addressed.

A couple of visual things:

when focused and hovered, the heading text appears to be purple/dark blue instead of black whilst the show/hide text is black; I think that the heading text should be black for the best contrast.
the yellow background takes up all the space, but the screenshots on the pull request description show yellow only taking a portion of the accordion. Which is correct?
the grey border is still present during the focus state, sandwiched between the yellow and the black. I think that this should be removed when focused.

+1 to all of these, the Design has been updated since this was initially raised so will all be addressed.

There were some considerations noted during Design iterations that are also in sync within step-by-step
@injms:

My worry with the clickable area being so big is that the blank space on the right gives no indication that it's a link and is far enough away from a link to not be thought of as interactive.

@miaallers:

It's in line with SBS as @owenatgov points out, and this wasn't flagged as an issue during testing either with DAC or in other usability testing. Obviously we can never be 100% certain but the component has been in use for some time now

I noted:  The spacing change between the text and the icon. The icon now doesn't jump but the difference in spacing (which is expected, should be fine but a ponder)
@miaallers

It's not perfect, but nothing is perfect. I think it's fine

There were some considerations noted during Design iterations that are also in sync within step-by-step
@injms:

My worry with the clickable area being so big is that the blank space on the right gives no indication that it's a link and is far enough away from a link to not be thought of as interactive.

@miaallers:

It's in line with SBS as @owenatgov points out, and this wasn't flagged as an issue during testing either with DAC or in other usability testing. Obviously we can never be 100% certain but the component has been in use for some time now

I noted:  The spacing change between the text and the icon. The icon now doesn't jump but the difference in spacing (which is expected, should be fine but a ponder)
@miaallers

It's not perfect, but nothing is perfect. I think it's fine

We're looking really good! A couple of little nitpicks from testing:
Blockers
Spacing is a bit wonky on Firefox on the condensed accordion and on mobile

Potential problems
On voiceover, there's a weird flow after you open an accordion. I haven't dug into the markup but I suspect that this is to do with the hide text not being removed upon click. See video below.
https://user-images.githubusercontent.com/64783893/106597949-fd82e300-654e-11eb-90d1-c0a1f3aa6aaf.mov
Non-blockers
The focus state on voiceover where it gives stuff the little border is out of line with the focus state

Icons look a bit squashed on mobile for safari and firefox

Blockers
Spacing is a bit wonky on Firefox on the condensed accordion and on mobile

As per our convo this was a little tricky to replicate, this can be viewed by:
Condensed layout on Desktop + macOS + Firefox + User Sets minimum font-size to 16px

Otherwise it's OK (below) I tend to lean to this being an edge case but will tweak.

Potential problems
On voiceover, there's a weird flow after you open an accordion. I haven't dug into the markup but I suspect that this is to do with the hide text not being removed upon click. See video below.

I think you might be referring to "Hide this section" being heard twice?

Non-blockers
The focus state on voiceover where it gives stuff the little border is out of line with the focus state

I really want to have these focus states reviewed at the a11y clinic I'm a bit concerned users at 300% or zoomed in more might get confused about these large yellow blocks.

Icons look a bit squashed on mobile for safari and firefox

Can resolve this one.

Converting PR back into Draft to gain more feedback.
While the visual updates address the initial WCAG issue of 3.2.4, I am not confident that other Accordion concerns raised around WCAG 1.3.1 have been resolved.

Discussion outcome notes Added to PR.

This is looking pretty good. I tested it just now and I'm still getting the issue I raised in my last comment where "show this section"/"hide this section" is heard twice. Digging into the markup, I can see the reason is that the actual section under each heading (gem-c-accordion__section-content) has an aria-labelledby of its associated heading. Removing it seems to fix this.
I'm interested to know if this aria label is necessary. The step by step for example doesn't include it. Is this one for the DS team?

Riight I understand your comment now.  I remember requesting comments for this issue the other day (about hearing it twice). The general outcome from the team was AT users are used to filtering some noise.
So it’s needed as it defines / link the relationship of the inner Content to its respective Heading. It's currently on the DS version and you see a similar pattern here. It's been introduced with the new "Show this section"
I do agree, I'd prefer to resolve, I'll have a think with this one.

@owenatgov I resolved a few issues in this last update.

I've altered the aria label so it pulls in just the header copy, this resolves the issue of the button being heard twice
The structure was refactored, focus on the wider element now behaves better (this fixes the mismatch of AT alignment)
I've also converted the icons into CSS and adjusted, which makes this a lot cleaner.

Thanks @owenatgov

squash your commits together a bit before merging though.

Will do, I thought to myself the differences might be a bit easier to review this way to start - then the squash™

I know @alex-ju is putting out a breaking release today and as this is quite delicate we may want to wait a bit.

Ah OK, will do - i'll ping and hold off for the moment.

Once this is out I'd like to confer on differences between this and the step by step and see if we can bring in some of your technical choices eg: the css chevron, possibly moving towards bringing these close together, as is the dream.

Yup this works, whoop, leaving Accordion country, now boarding 😃


Version 9.12.0

Adds publishing-app metatag (PR #470)

https://trello.com/c/vhfMGngX/239-investigate-and-correct-smart-answer-google-analytics-tracking

@binaryberry is this a minor change? Just wondering if this should actually be version 9.11.1.

@andysellick I think it is! I'm adding functionality, not removing a bug: https://semver.org/


QUESTION: How to modify top right bar menu bar?

Hi, I need to add some items before "Logout" option in the top right bar. In the config file I don't see any option. Is that posible or may I need to edit source files?

Hello ! 👋
It's pretty simple. At first you have to recover the partials by making the following command :
php artisan vendor:publish --provider="JeroenNoten\LaravelAdminLte\ServiceProvider" --tag=views

Now, you can edit the views in resources/views/vendor/adminlte/page.blade.php
See you soon ! 👌


Authorization is not saving its state

Im using the auth fucntion provided by the library but i need to run it again everytime i exit the app to start using the request methods, otherwise the isAuthorized prop always returns false, i tried run it in a effect on the first render but it request the permissions if they arent allowed yet and i only want to show this screen when the user decides to do the connection.
const GoogleF = ()=>{
const options = {
scopes: [
Scopes.FITNESS_ACTIVITY_READ,
Scopes.FITNESS_ACTIVITY_WRITE,
Scopes.FITNESS_BODY_READ,
Scopes.FITNESS_BODY_WRITE,
Scopes.FITNESS_HEART_RATE_READ,
Scopes.FITNESS_HEART_RATE_WRITE,
],
};
GoogleFit.checkIsAuthorized().then(() => {
var authorized = GoogleFit.isAuthorized;
console.log(authorized);
if (authorized) {
setAuthor(true)
} else {
// Authentication if already not authorized for a particular device
GoogleFit.authorize(options)
.then(authResult => {
if (authResult.success) {
console.log('AUTH_SUCCESS');
             // if successfully authorized, fetch data
           } else {
             console.log('AUTH_DENIED ' + authResult.message);
           }
         })
         .catch(() => {
           dispatch('AUTH_ERROR');
         });
     }

});
}
This method works and allows me to obtain data but i find pretty incovinient having to run it every time i start the app, is there a way to change this so i dont have to run this every time and only once?

Hopefully this can answer your question: https://github.com/StasDoskalenko/react-native-google-fit/issues/240#issuecomment-923144572


S2_API_KEY error

I apoligize for bringing this to your attention as I know your away from the project. I think I am missing something here, I keep ketting a missing S2_API_KEY = os.environ['S2_API_KEY'] error. It will not load past this point, I cant seem to find the problem. Am I being blind here?  Located in Assistant/semantic_scholar/simple.py. Again sorry for dragging you back to the project, I know your busy with other things. Thank you for taking the time.

Hi, no worries. The S2 Api Key is necessary to do scientific paper research in the 'Research Mode'. The error you are recieving is associated to the fact that I didn't updated the .env file with the empty S2_API_KEY field.
Thank you for bringing this up, I updated the .env.txt in the project. If you happen to have similar errors with API KEYS missing you should just add an empty field in the .env like this API_KEY = ''


Nice error for configuration needing Map module

Replace a bare .get with a better check that a Map
module is available, when processing the configuration
in Kompile (which assumes it can use the standard Maps if desired).

Jenkins: test this please

@dwightguth please review.


Bug with pre_normalize with no missing values for continous data

When doing pre_normalize with no missing values for continous data,
x[idx] -= cmin
x[idx] /= diff

is not correct. Because x[idx] here is a sample, what we need is a feature.
So the input of pre_normalize should be self._X.transpose(), and returns x.transpose().
There are also problems with mixed data.
 def _distarray_no_missing(self, xc, xd):
        """Distance array for data with no missing values"""
        from scipy.spatial.distance import pdist, squareform
        attr = self._get_attribute_info()
        #------------------------------------------#
        def pre_normalize(x):
            """Normalizes continuous features so they are in the same range"""
            idx = 0
            print(x.shape)
            for i in attr:
                cmin = attr[i][2]
                diff = attr[i][3]
                x[idx] -= cmin
                x[idx] /= diff
                idx += 1
            return x
        #------------------------------------------#
        if self.data_type == 'discrete':
            return squareform(pdist(self._X, metric='hamming'))
        elif self.data_type == 'mixed':
            d_dist = squareform(pdist(xd, metric='hamming'))
            c_dist = squareform(pdist(pre_normalize(xc), metric='cityblock'))
            return np.add(d_dist, c_dist) / self._num_attributes
        else:
            self._X = pre_normalize(self._X)
            return squareform(pdist(self._X, metric='cityblock'))

Thank you for the issue report, @hongliuuuu. @pschmitt52, can you please look into this to verify?

Yes, I’ll take a look.
On Mar 29, 2017, at 1:47 PM, Randy Olson <notifications<EMAIL_ADDRESS>wrote:
Thank you for the issue report, @hongliuuuuhttps://github.com/hongliuuuu. @pschmitt52https://github.com/pschmitt52, can you please look into this to verify?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/EpistasisLab/scikit-rebate/issues/19#issuecomment-290187784, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AJJuG66tEEKCF4UfpYetRpHtmjl-M-CMks5rqqc8gaJpZM4Mr3J2.

Hi, I want to know if you have checked this out?
Thanks!

It's on my list for this week.   I'll get back to you.

This issue has been fixed on the master branch and will be pushed out to PyPi in a new version of the software soon. Thank you for reporting the issue, @hongliuuuu.


VolatileTime churning updates

/area API
/kind bug
Expected Behavior
No updates when only VolatileTime changes
Actual Behavior
I see the following in a test logstream:
    kubelogs.go:197: D 23:57:42.758 contour-ingress-controller-5fcc97657d-mxmdv [ingress/reconciler.go:341] [serving-tests/scale-to-n-scale-100-007-of-100-hfhmqwzs--ep] Updating status with:   v1alpha1.IngressStatus{
          	Status: v1.Status{
          		ObservedGeneration: 1,
          		Conditions: v1.Conditions{
          			{
          				Type:               "LoadBalancerReady",
          				Status:             "Unknown",
          				Severity:           "",
        - 				LastTransitionTime: apis.VolatileTime{Inner: v1.Time{Time: s"2020-08-28 23:57:42 +0000 UTC"}},
        + 				LastTransitionTime: apis.VolatileTime{Inner: v1.Time{Time: s"2020-08-28 23:57:42.712308213 +0000 UTC m=+62.545052943"}},
          				Reason:             "Uninitialized",
          				Message:            "Waiting for load balancer to be ready",
          			},
          			{
          				Type:               "NetworkConfigured",
          				Status:             "True",
          				Severity:           "",
        - 				LastTransitionTime: apis.VolatileTime{Inner: v1.Time{Time: s"2020-08-28 23:57:42 +0000 UTC"}},
        + 				LastTransitionTime: apis.VolatileTime{Inner: v1.Time{Time: s"2020-08-28 23:57:42.712308213 +0000 UTC m=+62.545052943"}},
          				Reason:             "",
          				Message:            "",
          			},
          			{
          				Type:               "Ready",
          				Status:             "Unknown",
          				Severity:           "",
        - 				LastTransitionTime: apis.VolatileTime{Inner: v1.Time{Time: s"2020-08-28 23:57:42 +0000 UTC"}},
        + 				LastTransitionTime: apis.VolatileTime{Inner: v1.Time{Time: s"2020-08-28 23:57:42.712308213 +0000 UTC m=+62.545052943"}},
          				Reason:             "Uninitialized",
          				Message:            "Waiting for load balancer to be ready",
          			},
          		},
          		Annotations: nil,
          	},
          	LoadBalancer:        nil,
          	PublicLoadBalancer:  nil,
          	PrivateLoadBalancer: nil,
          }

I don't see this spinning, but I'd have expected this to have never reached this log statement...
cc @dprotaso @whaught @n3wscott

I'm pretty sure this is due to retries.


ENH: indicate that on the Vidas you have to touch the screen to turn off the alarms

@celprov - this is not rendering properly notes
Please check my comment https://github.com/TheAxonLab/hcph-sops/pull/497#discussion_r1731013028