Regression in 0.6.2: Unable to debug tests inline

Describe the bug
I'm trying out migrating to Vitest for the new release. Mostly things went smoothly- I can use the explorer to run my tests inline.
If I try to debug them however, I get a message like Cannot find the file test item for <testName>.

It looks like it's coming from this error in the runner:
https://github.com/vitest-dev/vscode/blob/cac3d22b3c8c2f79a9cf53243004799e40fd232c/src/runner/runner.ts#L518
If I manually install version 0.6.1, I can hit this breakpoint successfully.
That said, it seems like if I try to run the test multiple times on 0.6.1 it still ends up hanging so there seem to be some other underlying issues.
Update:
I also notice that this test failure only occurs from within the test explorer (trying to use a symbol as a WeakMap key). When I run the same test via the CLI, there is no error at all.
Reproduction
Try to debug a TS test using the inline explorer debugger.
OS: Ubuntu 22.04.4 (WSL)
VSCode: 1.89.0-insider
This is my config:
import { fromHere } from "@arktype/fs"
import tsconfigPaths from "vite-tsconfig-paths"
import { defineConfig } from "vitest/config"

export default defineConfig({
	plugins: [tsconfigPaths()],
	test: {
		root: fromHere("..", ".."),
		globalSetup: fromHere("vitest.globalSetup.ts"),
		isolate: false,
		fileParallelism: false
	}
})

VScode settings:
	"vitest.rootConfig": "ark/repo/vitest.config.ts",

Output
[INFO 9:28:14 PM] [API] Vitest process 12606 created
[INFO 9:28:14 PM] [API] Collecting tests: /home/ssalb/2.0/ark/schema/__tests__/unit.test.ts
[Error 9:28:22 PM] Cannot find the file test item for symbol

Version
0.6.2
Validations

[X] Check that you are using the latest version of the extension
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

I'm having the same issue.

Fixed in https://github.com/vitest-dev/vscode/commit/b6461588ead317ab5d7d45c71d3fcb833fab9561


Build using bundler caching

Coverage increased (+0.1%) to 89.67% when pulling e70c1785d349bd732fd54d71cb027b50715b475a on jcoyne:optimize_travis into 56b10408559e3b77b387b60cc3c2caa30e3285ed on minnestar:master.


Display labels for ContainerProject, ContainerRoute

Addresses points (1), (2) of #7744.
ContainerProject labels now refreshed correctly and displayed:

ContainerRoute labels now displayed:

(ignore the tag called "Kubernetes label 'app'" on the right side of the last screenshot, it was in my DB from unrelated work.  the point here is just displaying the labels.)

@miq-bot add_label providers/containers, ui, bug

I verified that the refresh fix works on a pure kubernetes cluster.
  Technically labels can only be applied to the underlying namespace.  We're mapping both namespaces and projects to a ContainerProject, even when there's no openshift involved, which I wanted to verify.)

@zeari @moolitayer @enoodle can you review? Thanks.

Looks like ContainerRoute already had the labels-custom-attribute relation but didnt show it in the UI and Project didnt parse them at all.
Its weird that there was partial work on this.

Moreover, save_container_projects_inventory() was trying to save labels (but refresh never sent any):
https://github.com/ManageIQ/manageiq/blob/40b7e0799ec3f111de42729b0ee650944d288d04/app/models/ems_refresh/save_inventory_container.rb#L30-L31

LGTM :+1:

Now with test, non-angry rubocop (modulo parse_endpoint, which this PR doesnt touch) and renamed the method because it's really parsing 1 namespace at a time.

:+1: cc @blomquisg

overall LGTM aside from two nit comments

Oops, lost half of the rename in rebasing.  Should be OK now.

LGTM :+1:

Bah, changing the first half to avoid the ugly question of how to indent after foo(bar( made Rubocop dislike the second half.  Lets see...

ping  @blomquisg @chessbyte


SyntaxError: invalid syntax

I get bellow error, on 4 : Text Spammer - Write your own text to spam (Both DM and guild)
File "bots/DM/discord_text_spam_dm.py", line 12, in <module>
  import discord
File "C:\Users\myuser\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.8_qbz5n2kfra8p0\LocalCache\local-packages\Python38\site-packages\discord\__init__.py", line 20, in <module>
  from .client import Client, AppInfo, ChannelPermissions
File "C:\Users\myuser\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.8_qbz5n2kfra8p0\LocalCache\local-packages\Python38\site-packages\discord\client.py", line 38, in <module>
  from .state import ConnectionState
File "C:\Users\myuser\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.8_qbz5n2kfra8p0\LocalCache\local-packages\Python38\site-packages\discord\state.py", line 36, in <module>
  from . import utils, compat
File "C:\Users\myuser\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.8_qbz5n2kfra8p0\LocalCache\local-packages\Python38\site-packages\discord\compat.py", line 32
  create_task = asyncio.async
                        ^
SyntaxError: invalid syntax

OS: Windows 10
Python Version 3.8.3

Resolved, works fine with v3.6.4


Add support for Android NDK 12

Thanks @wonder-sk Happy to merge if it helps.
In the future we will need to switch to clang. gcc has been deprecated in the ndk and Qt 5.7 no longer compiles (requires C++11).

I have few more changes in recipes pending... stay tuned :-)

By the way, how do you mean Qt 5.7 no longer compiles with gcc? Qt project ships 5.7 for armv7 and if I understand correctly it is built with g++

I didn't manage with a quick test (errored out on C++11 features), I think the gcc version shipped with the NDK is just very, very old.

Got such problem too, but it's obviously just something dodgy with Qt5.7 vs cmake.
How to fix it - in Qt/5.7/android_armv7/lib/cmake/Qt5Core/Qt5CoreConfigExtras.cmake
Replace this line:
set_property(TARGET Qt5::Core PROPERTY INTERFACE_COMPILE_FEATURES cxx_decltype)

By this one:
set(CMAKE_CXX_STANDARD 14)

https://bugreports.qt.io/browse/QTBUG-54666
http://public.kitware.com/pipermail/cmake-developers/2016-July/029005.html

Thanks for the hint, will try next week!

@m-kuhn Ready to me merged... everything builds for me (NDK 12 + Qt 5.7 with the patch above)

Nice!
I wonder if this could be integrated in the android.toolchain file so it
would work with a vanilla Qt 5.7 SDK.
On 23/09/16 08:33, Martin Dobias wrote:

@m-kuhn https://github.com/m-kuhn Ready to me merged... everything
builds for me (NDK 12 + Qt 5.7 with the patch above)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/opengisch/OSGeo4A/pull/15#issuecomment-249113868,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAj6d4nnUiK_3FOqQ99VJZcwD72bHM0xks5qs3LMgaJpZM4KElPV.

Hmmm I don't really dare to try that: 1. it is something deep inside Qt5's cmake config, 2. it may just go away with a different combination of cmake/qt versions 3. android.toolchain should be generic config without special Qt stuff

android.toolchain is a collection of hacks and poorly implemented, there
are a zillion of different versions out there (see e.g.
https://github.com/taka-no-me/android-cmake/issues/81#issuecomment-229829753).
If there's anything at all that can be done, I don't mind at all.
On 23/09/16 09:13, Martin Dobias wrote:

Hmmm I don't really dare to try that: 1. it is something deep inside
Qt5's cmake config, 2. it may just go away with a different
combination of cmake/qt versions 3. android.toolchain should be
generic config without special Qt stuff
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/opengisch/OSGeo4A/pull/15#issuecomment-249119486,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAj6dx-CPPK4h5TDw23af5mTIq9yPY3Bks5qs3wPgaJpZM4KElPV.

Thanks, good stuff!
Were you able to compile QGIS as well? I had trouble with the GCC version check here which failed so it was compiled without C++11 but it worked if I removed the check (and I wonder if we could just require C++11 on QGIS anyway to "fix" this).

Yeah QGIS 2.14 compiled just fine for me - I didn't encounter any problem with GCC version check...


Collaboration on OpenAI.jl

Hey @rory-linehan! I am working on an article about using the OpenAI API in Julia. I wanted to propose some changes and such. Can you add me a collaborator here? I would also be interested in getting this moved to the JuliaML or JuliaAI org at some point.

Sure! I've added you. Sorry about the delay. Let me take a look at the other issue.

Hey! Can you invite me again? The link expired.

Got it !


XD-3556: Creation of a JobLaunchingTasklet

This commit creates a Tasklet implementation that utilizes Spring XD's
infrastructure to launch a job that is already deployed within the
Spring XD cluster.  In a future PR we'll make the timeout and polling
interval configurable.

Otherwise LGTM

squashed , rebased merged


Disable eslint rules that are incompatible with typescript

These rules are now replaced with equivalent 'typescript-eslint' rules.
BREAKING CHANGE: Config may find additional linting errors for: camelcase, indent, no-array-constructor, and no-unused-vars.
Thanks to @tombell for raising this original issue in #3  👏

:tada: This PR is included in version 2.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


[hotfix][doc] MT download link to filesystem-test-utils jar

@polyzos  Thanks for the contribution, Can you help fix the chinese version too ?

@hackergin done

@polyzos  Thanks for the update. LGTM.
It would be better to also change the title of the pull request, for example: [hotfix][doc] xxxxx.

@hackergin This should be fixed to release-1.20? not master branch?

i opened a new one for release-1.20 here

@lsyldliu   I think both need to be fixed, including master and release 1.20.


Fix PhpDoc of yii\db\pgsql\QueryBuilder::normalizeTableRowData()

Q
A

Is bugfix?
✔

New feature?
❌

Breaks BC?
❌

Fixed issues

👍


all: fix/suppress remaining warnings

This change suppresses or fixes remaining lint warnings from rules/sdk/* in the codebase.
This change should make the CI workflow green again :)

Rebased on top of master for a better diff. Once #20 is merged and I rebase this PR, CI should turn green.

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@cfeebb8). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #21   +/-   ##
=========================================
  Coverage          ?   71.05%
=========================================
  Files             ?        9
  Lines             ?      570
  Branches          ?        0
=========================================
  Hits              ?      405
  Misses            ?      143
  Partials          ?       22

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfeebb8...45fecd4. Read the comment docs.


Surface ERC20 extension address in UI

The ERC20 token extension is working and has been integrated. Now internal membership units are parallel tracked with actual ERC20 tokens that can be viewed in a wallet.
We should surface the ERC20 token address where appropriate in the UI so users are aware of it and can add it to their wallets. For example, after a user redeems a coupon, the confirmation can direct them to add the token address to their wallet.

As an added enhancement we can try to implement this: https://docs.metamask.io/guide/registering-your-token.html#code-free-example


intermittent timeout on Windows in PipeSourceSinkTest

seen at https://scala-ci.typesafe.com/job/scala-2.13.x-integrate-windows/240/consoleFull
[error] Test scala.sys.process.PipeSourceSinkTest.sourceInterrupted failed: java.util.concurrent.TimeoutException: Futures timed out after [2 seconds], took 2.056 sec

we should just increase the timeout a little.

the failure is on 2.13, but I should consider increasing the timeout all the way back on 2.11 and merge forward

the test wasn't added until 2.12

I see we already increased it once at https://github.com/scala/scala-dev/issues/313

why'd I open this ticket in the community-builds repo? it was seen in integrate-windows, not the community build. oh well :-\

https://github.com/scala/scala/pull/6081


New package: Falcosoft.VSTMIDISystemSynth version <IP_ADDRESS>

[x] Have you signed the Contributor License Agreement?
[x] Have you checked that there aren't other open pull requests for the same manifest update/change?
[x] This PR only modifies one (1) manifest
[x] Have you validated your manifest locally with winget validate --manifest <path>?

[x] Does your manifest conform to the 1.5 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

@microsoft-github-policy-service agree

Automatic Validation ended with:

Hi @Falcosoft,
Is another silent installer switch needed to proceed past the prompt, and complete the install automatically?

Problem has been fixed in next version.


Form Validation double value verification

Laravel Version: 9.31.0
PHP Version: 8.1.8
Laravel-admin: 1.8.17

Description:
Hi, i need to validate if a value is unique but i have to filter the "unique search" with other field for example:
if the username is unique for this club_id.
hope you can help me!
ps: the ideia is to validate before submiting, and the club id is a variable i get from php
Steps To Reproduce:
table example: (user_id, username, club_id)
$form->text('username')->updateRules(['required', "unique:user_table,username,{{id}}"]);

This should help - link to SO.
Basically 'unique:user_table,username,NULL,id,clud_id,' . $form->model()->club_id or something similar.
Or use more verbose OOP-based approach as described in this section of Laravel docs (last example).
'username' => [Rule::unique('user_table')->where(fn (Builder $query) => $query->where('club_id', $club_id))]

@alexoleynik0 thank you for your hints, i have solved my problem using something like this
$form->number('id','ID')->rules(['required' => Rule::unique('user_table')->where(fn(Builder $query) => $query->where('id', '!=', $form->model()->id)->where('club_id', $club_id))])->required();


Add script to copy lib files to example project dir for testing.

At present I copy these manually. A job for a script I think. The copies files should also be set to readonly to avoid editing.

Fixed with the magic of arduino-cli.


Dependabot REST API

Summary
This feature will expose information about Dependabot alerts and Dependabot updates in a new REST API.
Intended Outcome
While users can already access information about Dependabot alerts and Dependabot updates from the GraphQL API, many users have indicated a preference for working with a REST API instead.
How will it work?
No response

this has shipped to dotcom! leaving open to track to GHES https://github.blog/changelog/2022-09-22-dependabot-alerts-rest-api-is-now-available-in-public-beta

This shipped with GHES 3.8<EMAIL_ADDRESS>


May2020 fixes (Integrate MoreLenses Update)

WHAT IS THIS
Intgrated the changes to the MoreLenses mod (as done by @astog); changes are from the version published on the Civ6 Workshop.
Wherever possible, I called out the CQUI-specific items.  I did a little bit of code clarity work, adding function separators and the like.
TESTING
Loaded a game I had started before the May2020 patch and confirmed lenses worked; loaded a game started 2 days ago and confirmed lenses worked.  Both games had the Gathering Storm (expansion2) enabled.

Wrong branch, re-doing


starknet plugin appendix

#135
WIP

Hey! I suggest that you use ChatGPT / Bar to review the english quality of your sentences. It makes the book a bit more professional and facilitates comprehension. Here's a prompt that I like to use and works great:
You are an experienced developer and content writer who created a programming language called Cairo. Cairo is the first provable programming language developed by StarkWare for the Starknet blockchain network. Review the following content, which is the documentation of the Cairo programming language, and provide feedback in the form of a bulleted list. Your comments should address:

English quality: Identify any grammar, spelling, or phrasing issues. Rephrase unprofessional sentences to a more professional tone.
Content quality: Assess the clarity, organization, and effectiveness of the content. If you think a sentence can be rephrased for better clarity, you will propose the corresponding rephrasing.
Accuracy of facts: Point out any inaccuracies or inconsistencies in the information provided.
For each issue you identify, explain the problem and suggest how to reword or correct it.

The following page is an extract from the "<your section here>" section.

@rkdud007 Any update on this one?

@enitrat Hey was working on it ser 🫡

Okay actually let's pause it until the syntax update


[API-Draft][DOC] Add jdbc connector doc

Purpose of this pull request
Add jdbc connector doc

Check list

[x] Code changed are covered with tests, or it does not need tests for reason:
[x] If any new Jar binary package adding in your PR, please add License Notice according
New License Guide
[x] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs

Also the file name should be Upper Camel Case


Fixed custom status warning issue

Summary
Fixed the warning about the isCustomStatusEnabled prop in the ChannelInfo screen
Ticket Link
https://community.mattermost.com/core/pl/5w7c6hji7trjxx8gryzhakjhba
Checklist

[ ] Added or updated unit tests (required for all new features)
[ ] Has UI changes
[ ] Includes text changes and localization file updates

Device Information
This PR was tested on:

iPhone 12 Simulator - iOS 14.4
Android Emulator - Pixel_3a_API_30_x86 - Android 10

Release Note
Fixed the warning about the 'isCustomStatusEnabled' prop in ChannelInfo screen

Hello @manojmalik20,
Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

Cherry pick is scheduled.


parse method header and sections

Parse the Method data (pointed to by RVA, see mdtable.MethodDefRow), as much as is needed to perform data-agnostic computation over the bytecode (cryptographic and fuzzy hashes, entropy, value distributions, etc).
See ECMA-335 6th Edition, Section II.25.4 Common Intermediate Language physical layout

@malwarefrank I've been working on a Python library that parses method body sections and CIL instructions using RVAs recovered by dnfile. Is there any interest in adding this level of method body parsing directly to dnfile? You mention parsing the sections but not the CIL instructions.

sorry for the delayed response.  I would love to see what you are working on.  I am uncertain whether bytecode disassembly should be separate from dnfile or a part of it.
I would not want to succumb to scope creep too much before milestone 1.0, but thinking through some of those details may help to inform the API before I lock out breaking changes

Apologies for the delayed response. I've released the work I've been doing on CIL disassembly here: https://github.com/mandiant/dncil. The library supports parsing method body headers, instructions, and exception handlers. There is an example of using dnfile and dncil together here: https://github.com/mandiant/dncil/blob/main/scripts/print_cil_from_dn_file.py.
One option to consider is dnfile including dncil as a dependency to keep core functionalities isolated and easier to maintain. dnfile could leverage dncil to parse method bodies and we could make disassembly a configurable option. I think dnfile including dncil as a dependency makes the most sense as both projects have progressed.
I'd be happy to contribute code to make dnfile and dncil work together but understand if this is outside the scope of your vision for dnfile.

Thanks.  I started looking at the dncli code and realized that there have been some helpful changes since dnfile v0.8.0, including a user_strings shortcut.  I tagged master and pushed a new version to pypi.
I will look at the dncli code more and think through how to best integrate.

I like that dncil focuses on parsing the method bodies.  I still want to parse the MetadataTable MethodDef rows into a list of objects in dnfile and make accessible via a shortcut, maybe something like
import dnfile
pe = dnfile.dnPE("filename.exe")
if pe and pe.net:
    for method in pe.net.methods:
        # do something

I think I can do that without replicating any of the dncil method body parsing.  I should be able to use or cherrypick from @williballenthin work on #37 for method signature and param signature parsing for some if not most of it.  Then I can just import and call dncil for the method body parsing.

This sounds great. Please reach out if you have any questions or issues w/ dncil.

Parsing methods is complicated! </rant>
The MethodDef row defines a parameter list, but then the associated method signature also defines parameters.  I am working on this in the methods branch, but suffice to say it will be a while longer.


BigBird on RTE

As another member of the sesame street, BigBird beats BERT on GLUE tasks. The most  signifcant improvement comes from the RTE task.
Paper: https://arxiv.org/pdf/1901.11504.pdf
A community version: https://github.com/namisan/mt-dnn
If you're interested in contributing this, we're more than happy to help. Let's coordinate here

MTL(MultiTask Learning) is one of the most important topic in NLP research with LM.
It's heavily related on developing MTL frame on gluon-nlp.
pytext(https://arxiv.org/pdf/1812.08729.pdf) already implement on MTL for production use.


Implement AutoAux and auto-ABS methods for automatic formation of auxiliary basis sets

AutoAux, a method for generation of general-use auxiliary basis sets, has been described in J. Chem. Theory Comput. 13, 554 (2017). I've verified with help from Frank Neese and Georgi Stoychev that this implementation reproduces ORCA for the cc-pwCVQZ basis set at least for B, C, N, and O, and doing so found three typos in the paper.
auto-ABS, a method for Coulomb-fitting auxiliary basis sets, has been described in J. Chem. Phys. 127, 074102 (2007). This scheme is much sim

Codecov Report

Merging #206 (c7bf20c) into master (32721c8) will decrease coverage by 16.45%.
The diff coverage is 7.91%.

@bennybp please merge

Codecov Report

Merging #206 (e6e7e21) into master (e6e7e21) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head e6e7e21 differs from pull request most recent head 60527b5. Consider uploading reports for the commit 60527b5 to get more accurate results


feat(ui-hydro): add split view to merge "Daily power" and "Energy credits" matrices

Add overflow for the buttons.


Give version 3.1 a personal touch by allowing the software to greet the user using their first name if they want.

What this means is, instead of the standard "Welcome to UXL... Click the buttons..." text in the status bar, make it so that users can choose if they want the old text in the status bar or a personal message that says, "Welcome back to UXL Launcher, (FirstName)!" There will be an option on the General tab in Options that is a checkbox to use a personal greeting in the status bar; if the checkbox is checked, the "Enter your first name (or nickname.)" field will be enabled; otherwise, the status bar will display the standard text.

Instead of he General tab, put this on the Personalization tab.

Should be complete as of June 22, 2018: 6827462c357ad81e67c3cbefa92810d1de04b95c


Updating to Laravel 5.4 and Webpack

Is there any plan to update to Laravel 5.4 and use Laravel Mix with Webpack instead of Gulp.

Hi @mikimaine
Thanks for posting here!
Honestly I thought not a lot of people would be still using AngularJs now that Angular (angular 2) has been released so I was thinking that Laravel 5.3 would be the last release for AngularJS version and that I should start working on Laravel-Angular
However I didn't have much time in the past few months..
If the community actually needs a 5.4 version with Webpack support, I'll definitely do it!
( 👍  below if you'd need a 5.4 version )

@mikimaine if you just interested in webpack .. take a look here (https://github.com/JeffreyWay/laravel-elixir-webpack-official)

I would prefer a Lumen 5.4 with Angular 2.x since we mostly use Laravel as API, it would slim down and increase the performance. Just my 2 cents.

Laravel 5.4 with Angular 2 would be awesome. I've been using Angular 2 in an Ionic project and I can see being able to extend it farther with this project.

Hi @mikimaine
As I've learned about mobile performance in the past year, I've added a 2017 update to the readme
I don't think it's a good idea to start new apps using AngularJS if you're planning on having decent mobile User Experience because javascript bundles have very large sizes

@jadjoubran  so will Angular 2 will be a better choice.

@jadjoubran so when will it be released? As Laravel 5.4 have many better feature like mailable, Laravel Dusk, Real-time facades, blade's slots, etc.

Don't wan't to start a new project without this starter, so eagerly waiting for the latest release.

I actually started working on the upcoming version for Angular (2+) 🎉
It's still Work in progress but it works as a package on Laravel & Lumen
http://github.com/jadjoubran/laravel-angular

Hi everyone!
You can already get started with the new Laravel & Angular package.
Repo
Website & documentation
🎉


Replace md5 checksum on repository keys with fingerprint (bsc# 988907)

(cherry picked from commit ff7add4a8878744d071d035f5e06e9b8f4b9d2e4)

LGTM. just the space between bsc# and the bug number should be removed.

@rsalevsky Thanks for pointing that out. I'll fix my commit messages.

@rsalevsky Do you know what's going on with the Travis checks?

I should note that we mainly need this patch in stable/3.0 since we have disabled the key verification in master due to the SP1 -> SP2 transition.

#2244 should fix the issue

-1 cherrypick git hash is wrong, please update/rebase (to retrigger travis-ci)

@dirkmueller Fixed.

+1


Contribute to BSSw: Needs form fields

Form fields should be added to Contribute to BSSw to match those on Contact BSSw (note: currently form fields on Contact are incomplete. The final details will be posted to Bcamp.)

Forms edited based on Basecamp instructions!


bundle a pat with actions to avoid hitting github rate limits

this is usually needed for CIs, but it's currently unclear whether github will be more generous towards queries from their own infrastructure (i.e. actions).

A way to see the limits github is giving you is to run
attr(gh::gh("/user"), "response")[["x-ratelimit-remaining"]]


unable to know how to use package to do serialize and deserialize. provide example code or mention in docs. how to use it.

unable to know how to use package to do serialize and deserialize. provide example code or mention in docs. how to use it.

I assume you're trying to say that it's not clear how to use this package? I agree that the docs don't really help. It would be useful to have a small example in the front-page source docs.


add building-node-with-ninja.md

People always ask me about how to do this, and there's no info about it really anywhere.
R=@nodejs/documentation

Cool, thanks!
Just a note: having the 2 sections covering the 4 steps feels a little weird to me. Reading it from the top down, as someone that hasn't read it before, I can see someone running the quoted steps in the first block and getting frustrated when it doesn't work how they thought it would. Then they'd get to the next block and realize that was the part they actually needed to be reading.
Perhaps it would be better to mix the two blocks together, putting the explanation bits from the first section in with the explicit instructional bits of the second.

Closing this since docs aren't intended to live here anymore. Maybe redo the PR against nodejs/nodejs.org?

note to self: do this

@bengl Ah — I think we're pointing folks at PR'ing this material into nodejs/node itself now (ideally into doc/guides/. Although that's not built into the docs output right now, it shouldn't be too hard to add!


UWP support for integration_test/flutter_driver

To test plugins for UWP, we need to be able to run integration tests via Flutter driver.
IIRC there was almost no work needed to enable this for the other desktop platforms once flutter run worked, but since running is more complicated with UWP I'm not sure if that will be true here as well.
/cc @cbracken

Closing this since our intent is to wind down development on, and remove the UWP embedder in order to focus on the Win32 embedder which, over time, will start to adopt Windows SDK support (once our supported OSes is a subset of those that support doing so).
See: https://github.com/flutter/flutter/issues/14967#issuecomment-1085490495


[QUOTA] Quota interfaces

This PR introduces generic interfaces for quota based throttling in ambry.

Codecov Report

Merging #1751 (e58e706) into master (378455e) will decrease coverage by 3.97%.
The diff coverage is 2.29%.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 378455e...e58e706. Read the comment docs.

Codecov Report

Merging #1751 (e58e706) into master (378455e) will decrease coverage by 3.97%.
The diff coverage is 2.29%.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 378455e...e58e706. Read the comment docs.

Tow renaming comments:
QuotaManager-> ThrottlingManager: it would be a centralized manager for all kind of quota management. In the future, HostLevelThrottling can be also added to it.
EnforcementRecommendation -> QuotaRecommendation: since it's per quota.

Tow renaming comments:
QuotaManager-> ThrottlingManager: it would be a centralized manager for all kind of quota management. In the future, HostLevelThrottling can be also added to it.
EnforcementRecommendation -> QuotaRecommendation: since it's per quota.

Renamed EnforcementRecommendation to QuotaRecommendation.
As discussed offline, we decided to keep QuotaManager name as is, because it’s not just handling throttling. Its also handling other things like instantiating QuotaEnforcers, giving out quota usage and charging against the quota based on request cost.


added hightlight for more language

This PR is added to support highlight for rust, toml, lock, python, Makefile, wasm, dockerfile.
rust: https://deno.land/x/tar/src/lib.rs
toml: https://deno.land/x/tar/Cargo.toml
lock: https://deno.land/x/tar/Cargo.lock
python: https://deno.land/x/deno/tools/benchmark.py
Makefile: http://deno.land/x/dejs/Makefile
wasm: https://deno.land/x/wasm_imports/example/math.wasm
/cc @ry, @bartlomieju , @lucacasonato

How much bigger does this make the js bundle for the website?

@lucacasonato please review if you have the time.


Unbalanced parentheses in DocBlock cause error

I found a nice little edge case. If (for whatever reason) a DocBlock has unbalanced parentheses, PHP-CS-Fixer will error out and not be able to process that file. Example:
https://gist.github.com/samuelwilliams/ef214991b5d74a203d64
<?php
/**
 * {@link http://www.ietf.org/rfc/rfc1035.text)
 */
$someVar = 'hello';

php-cs-fixer fix ./TestFile.php --dry-run --diff
Fixed all files in 0.158 seconds, 6.500 MB memory used

Files that were not fixed due to internal error:
   1) ./TestFile.php

Can this behaviour be reasonably expected? There are legitimate reasons why one would want unbalanced parentheses in one's DocBlock, for instance: The parameter should be on [0, 10).

It's not a case when one has unbalanced brackets anywhere in docs, but when one has invalid inline tag.

Fair point. But is this the expected functionality, or should the nature of the error be raised at the end instead of a blanket "nope"?

I've seen this error before too.

See #1425


Activating Open Collective

This pull request adds backers and sponsors from your Open Collective https://opencollective.com/d3-node-editor ❤
It adds two badges at the top to show the latest number of backers and sponsors. It also adds placeholders so that the avatar/logo of new backers/sponsors can automatically be shown without having to update your README.md. [more info]. See how it looks on this repo.
We have also added a postinstall script to let people know after npm|yarn install that you are welcoming donations (optional). [More info]
You can also add a "Donate" button to your website and automatically show your backers and sponsors there with our widgets. Have a look here: https://opencollective.com/widgets
P.S: As with any pull request, feel free to comment or suggest changes. The only thing "required" are the placeholders on the README because we believe it's important to acknowledge the people in your community that are contributing (financially or with code!).
Thank you for your great contribution to the open source community. You are awesome! 🙌
And welcome to the open collective community! 😊
Come chat with us in the #opensource channel on https://slack.opencollective.com - great place to ask questions and share best practices with other open source sustainers!

Thanks for pull request!


Review 5: SignIn.jsx and AuditedBalanceInput.jsx

Overview
The focus for this code review will be centered around the Sign in an Audited Balance Input pages.
Please pay attention too:

Javascript issues
React components

Review Branch
review-05
Files to review

SignIn.jsx
AuditedBalanceInput.jsx

Checklists

Architecture
Design
JS
React

Due date
10/14/2024
For more information
The review process is documented at: http://courses.ics.hawaii.edu/ics414s21/morea/review/reading-idpm-review.html

SignIn.jsx
L56: Design-02, Avoid deeply nested conditionals. Avoid the empty string case to ensure that the alert is only rendered when there is an error.
AuditedBalanceInput.jsx
Arch-01: Obey file name convention. follow the camelCase convention.
L8: JS-02, ESLint disabled comment. Avoid disabling ESLint rules and pass required props.

File: SignIn.jsx
DE-06 (ln 50): The conditional rendering of the error message can be simplified using a more concise format, such as {error && ...} instead of the current ternary operation. This improves readability.
File: AuditedBalanceInput.jsx
ES-01 (ln 12): The line eslint-disable-next-line react/jsx-props-no-spreading is used to suppress warnings about spreading props. Instead of disabling the rule,refactor the code to avoid using prop spreading unless necessary.
DE-01 (ln N/A): The repeated use of AuditedBalanceField components with different labels and tooltips could be optimized by looping through an array of field data. This would make the code more maintainable and reduce repetition.
DE-06 (ln N/A): Code is generally readable, but further abstraction of form field logic (such as dynamically generating fields from an object) might improve maintainability, especially if this form grows more complex in the future.

SignIn.jsx
After looking over all the categories, there was nothing
that particularly stood out as needing to be fixed.
AuditedBalanceInput.jsx
JS-01 on line 27- file is called “AuditedBalanceInput.jsx” but header 2 says “Audited Balance.”
Maybe change header to say “Audited Balance Input” to keep it consistent?

SignIn.jsx
DE-06: Ensure code is readable - Code is easy to read with well-named variables and simple straightforward structure.
AuditedBalanceInput.jsx
DE-06: Ensure code is readable - The code is clean and readable. Variable names like AuditedBalanceField, TOOLTIP_TEXTS, and label are descriptive and make the code easy to follow.
https://github.com/manoa-inspire/MATP/blob/116e7207cf96259ad326531b914d40de9281e0a4/app/imports/ui/pages/AuditedBalanceInput.jsx#L17
ES-01: No errors, avoid warnings - While it's used to disable an ESLint rule and avoid lint errors. Maybe you could try to address the issue rather than disabling the rule, unless this was the only solution or made it easier to deal with.

1. SignIn.jsx Code Review:

Architecture (AR-01, AR-02, AR-03):

The file naming convention (SignIn.jsx) is appropriate and in camel case.

Design (DE-01, DE-02, DE-05):
Check for duplicate code or patterns throughout your application that could be refactored into reusable components or functions.

Avoid deeply nested JSX and ensure code blocks are concise and readable.
Comments should explain the "why" rather than the "how."

JavaScript (JS-01, JS-02, JS-03):

Ensure proper variable declarations and avoid any deeply nested loops or conditionals.
Check for the use of const/let appropriately.

React (RE-01, RE-02, RE-03):

Verify prop types are defined and all required props are passed into child components.
If there are any stateless components, use functional components with hooks where necessary.

2. AuditedBalanceInput.jsx Code Review:

Architecture (AR-01, AR-02, AR-03):

A naming convention for AuditedBalanceInput.jsx is correct.

Design (DE-01, DE-02, DE-03):

Look for any repeated logic that can be refactored to reduce duplication.
Avoid deep nesting of JSX elements, and ensure the code follows best practices for readability and maintainability.
Remove any dead or commented-out code.

JavaScript (JS-01, JS-02, JS-03):

Ensure variables are declared and used efficiently.
Avoid overly complex functions or deeply nested structures.

React (RE-01, RE-02, RE-07):

Use React hooks for any stateful logic.
Avoid using class components unless necessary, favoring functional components instead.
Ensure prop types are validated, and props are passed correctly to children.

SignIn.jsx

(DE-01) Check any deeply nested code blocks  to improve overall readability
(DE-02) Consider refactoring code segments to reduce code duplication (lines 55-56)

AuditedBalanceInput.jsx

(DE-03) Remove any dead or commented out code not being used
(ES-01) No errors or warnings, avoid disabling eslint errors (line 17)

SignIn.js
DE-01: Display password requirements on the form to improve user experience and reduce login errors.
JS-01: Ensure the error message displayed in the Alert is sanitized to prevent showing raw error details to the user.
AuditedBalanceInput.js
DE-01: Move inlinee styles for buttons into CSS classes for consistency and easier styling updates.


delta/PROTOCOL.md is vague w.r.t. the schema of checkpoint files

I'm trying to use the spec to implement a reader, but the spec is too vague on what the schema of a checkpoint file is supposed to be. Here are points that are not specified:

Which columns does a checkpoint file contain. The spec only gives an example of what columns it contains for a specific table, but it doesn't mention whether any possible checkpoint files will have exactly these columns for any conceivable table. Definition by example is nice, but at least a short sentence whether all files will look that way or in what way they can differ would be necessary to implement a reader that can read all allowable checkpoint files.
Are implementations allowed to add further columns to a checkpoint file? I have seen columns named 'cdc' and 'commitInfo' in the wild, but they are not mentioned in the spec. Are readers supposed to allow and ignore all columns that are not in the spec and assume that they will never change the semantics of the delta lake?
Is column lookup in the checkpoint file supposed to be by name or by position? I.e., say I have a checkpoint file whose first column is 'metaData' and second column is 'txn'. This order is different from the order in the spec (but I do have such a file). Is this a valid checkpoint file? I guess the answer is yes, but for a spec, it would be nice to be precise here.

@JFinis These are good points. Thanks! Are you interested in submitting a PR to improve the spec?

@JFinis just following up :) would you like to make a quick fix for this?

@scottsand-db @zsxwing Given that this is a spec and implementations already exist, I have a hard time proposing a fix here, as I honestly don't know what the desired semantics is supposed to be. Of course, I could just pick the answer I like most for all my questions, but that might mean that the spec gets specced in such a way that implementations don't conform to it anymore.
I guess it might therefore be more beneficial if someone who has deeper knowledge in the reference implementation proposes a wording that makes at least that implementation adhere to the spec.

Closing as this is also duplicated in https://github.com/delta-io/delta/issues/1284. There, I have clarified the checkpoint schema. Anyone is welcome to assign that issue to themselves and update the PROTOCOL.md. Thanks!


ReDoc support

Description
As a developer I want to be able to use ReDoc to browse my OpenAPI specfication.
Expected behaviour
Implement a plugin (or similar) to be able to browse to {base_url}/redoc to view the specification with ReDoc.
Actual behaviour
This behaviour does not currently exist.
Steps to reproduce
I read the issue #719 and the associated PR, but I was not sure how to use this information, so here is the way I implemented it.
Pre-requisites

I started from the OpenAPI3 HelloWorld example.
I installed flask-cors
I added the connexion_redoc.py file (see bellow)

The code
# connexion_redoc.py
"""Add a route to ReDoc."""

from flask import render_template_string

REDOC_TEMPLATE = '''
<!DOCTYPE html>
<html>
  <head>
    <title>ReDoc</title>
    <!-- needed for adaptive design -->
    <meta charset="utf-8"/>
    <meta name="viewport" content="width=device-width, initial-scale=1">
    <link href="https://fonts.googleapis.com/css?family=Montserrat:300,400,700|Roboto:300,400,700" rel="stylesheet">

    <!--
    ReDoc doesn't change outer page styles
    -->
    <style>
      body {
        margin: 0;
        padding: 0;
      }
    </style>
  </head>
  <body>
    <redoc spec-url="{{spec_url}}"></redoc>
    <script<EMAIL_ADDRESS></script>
  </body>
</html>
'''

def redoc_view(spec_url):
    """
    Render OpenAPI specification using ReDoc.

    :param str spec_url: URL to the JSON specification file
    """
    return render_template_string(REDOC_TEMPLATE, spec_url=spec_url)

def add_redoc_route(app, spec_url):
    """
    Add a '/redoc' route pointing to de ReDoc page.

    :param FlaskAPP app: the connexion application
    :param str spec_url: URL to the JSON specification file
    """
    app.app.add_url_rule('/redoc', 'redoc', redoc_view, defaults={'spec_url': spec_url})

#hello.py
#!/usr/bin/env python3

import connexion
from flask_cors import CORS

from connexion_redoc import add_redoc_route

def post_greeting(name: str) -> str:
    return 'Hello {name}'.format(name=name)

if __name__ == '__main__':
    app = connexion.FlaskApp(__name__, port=9090, specification_dir='openapi/')
    app.add_api('helloworld-api.yaml', arguments={'title': 'Hello World Example'})
    spec_url = "http://<IP_ADDRESS>:9090/v1.0/openapi.json"
    add_redoc_route(app, spec_url)
    CORS(app.app)
    app.run()

Questions regarding the implementation

I had to hardcode spec_url, what would be the proper way to implement it?
What would be the proper way to make this feature available to the connexion community?

Additional info:
Output of the commands:

python --version: Python 3.7.0
pip show connexion | grep "^Version\:": Version: 2.0.1

We've removed vendored swagger-ui from connexion and into a separate package that is optionally installed (swagger-ui-bundle).
AFAICT ReDoc falls into a similar bucket. I doubt we'd want to vendor it, so it would probably also make sense for it to live as a separate package, and be installable with pip extras.

Also, I don't think #719 is related at all - that's targeted at adding/changing middleware, not adding extra routes.

Ok, I'll try to reproduce the same thing as swagger-ui.
Can I get an answer to my other question please?

I had to hardcode spec_url, what would be the proper way to implement it?

yeah, look into how I did it with swagger-ui. the HTML is a Jinja template
that gets the spec url passed in
On Mon, Nov 12, 2018, 3:03 PM Rémy Greinhofer<EMAIL_ADDRESS>wrote:

Ok, I'll try to reproduce the same thing as swagger-ui.
Can I get an answer to my other question please?
I had to hardcode spec_url, what would be the proper way to implement it?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/zalando/connexion/issues/774#issuecomment-438060840,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAlPSSrYnCDVyJTOqVIEVHeDp37QDR7Bks5uuf5OgaJpZM4YY4LI
.

I tried it with the current implementation of connexion and a workaround.
I created a staticfile.yaml that looks like this
openapi: 3.0.0
servers: []
info:
  version: 0.1.0
  title: Static file yaml
  description: This is a API specification for the static files
tags:
  - name: Static
    description: Deliver static files like redoc documentation
    externalDocs:
      description: idea/inspiration found here
      url: https://github.com/zalando/connexion/issues/441
paths:
  /:
    get:
      operationId: api.static_redoc
      description: HTML file with rendered OpenAPI reference.
      tags:
        - Static
      responses:
        '200':
          description: Successfully loaded html page
          content:
            text/html:
              schema:
                type: string

Then I added this "api" to the connexion app by this part:
import connexion

app = connexion.FlaskApp(__name__, specification_dir='../specifications/')
app.add_api('myactualspec.yaml', base_path='/myactualapi')
app.add_api('staticfile.yaml', base_path='/redoc')

app.run(port=8080)

if __name__ == "__main__":
    app.run()

And implemented this handler in the api.py
def static_redoc():
    print("Deliver redoc")
    return flask.send_file('redoc.htm')

Of course, you have to provide a redoc.htm (I used the standard template) that refers to the spec with this line
<redoc spec-url='/myactualapi/openapi.json'></redoc>
which is available through the actual API
Works fine. Maybe this is useful as a workaround for you.

For people interested in using ReDoc instead of swagger UI I found a super simple solution.
In my python project package I simply added a templates folder including a single file named index.j2 containing the redoc html
<!DOCTYPE html>
<html>
  <head>
    <title>ReDoc</title>
    <!-- needed for adaptive design -->
    <meta charset="utf-8"/>
    <meta name="viewport" content="width=device-width, initial-scale=1">
    <link href="https://fonts.googleapis.com/css?family=Montserrat:300,400,700|Roboto:300,400,700" rel="stylesheet">

    <!--
    ReDoc doesn't change outer page styles
    -->
    <style>
      body {
        margin: 0;
        padding: 0;
      }
    </style>
  </head>
  <body>
    <redoc spec-url='{{ openapi_spec_url }}'></redoc>
    <script<EMAIL_ADDRESS></script>
  </body>
</html>

When I access my generated API documentation at /ui it then show ReDoc.
That's it!
Please note that if you installed connexion without the [swagger-ui] extension you will have to add the swagger_path option to your connexion app like:
app = FlaskApp(__name__, options={"swagger_path": "./"}

Of course you may notice that this prevent you from being able to serve SwaggerUI and ReDoc at the same time on different paths.
Tested with connexion 2.3.0

Here's a pretty simple way I figured out to serve ReDoc easily, without making SwaggerUI unavailable.
app = connexion.FlaskApp('ThisHereApp')
api = app.add_api('myspec.yml')
bp = flask.Blueprint('docs', __name__, url_prefix = api.base_path,
        template_folder = os.path.dirname(__file__))
# Copied from FlaskApi; it'd be nice to grab the spec path from the instance somehow
specPath = api.base_path + api.options.openapi_spec_path
serveRedoc = lambda: flask.render_template('redoc.j2', openapi_spec_url = specPath)
bp.add_url_rule('/docs/', __name__, serveRedoc)
app.app.register_blueprint(bp)

redoc.j2 is identical to the template in @hiboo 's (quite useful!) comment above. The code assumes that the template file is in the same where it lives. I'm not a flask wizard so there could be improvements here.
As mentioned in https://github.com/zalando/connexion/issues/441, it would be great to have an example of serving static content - or ReDoc specifically, even - in the documentation. It wasn't obvious to me for a while that you could add a blueprint that does this so readily.


Restapi auto azure kusto/resource manager - new PR

This is the auto-generated python client of Kusto resource provider, coming from PR https://github.com/Azure/azure-sdk-for-python/pull/3391

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Closing since the auto PR has been fixed. Thanks!


Open 2023-10-31-uplink-arm64-migration-preparation

Related: https://github.com/jenkins-infra/kubernetes-management/pull/4607#pullrequestreview-1704815716
Ref: https://github.com/jenkins-infra/helpdesk/issues/3619

LGTM, merging.


Enhance dev experience to support (easily) specifying which docker services to run

Is your feature request related to a problem? Please describe.
As a contributor to SN with an older development machine, the amount of docker containers that are spun up via ./sndev start can cause considerable resource consumption on my machine. This makes it hard to effectively develop. There are many services spun up, but many of them are not required to do certain pieces of work, depending on the changes you're looking to make.
Describe the solution you'd like
In my perspective, there are a few options:

Update sndev to provide a way to opt-out of spinning up certain docker services via ./sndev start. This could be done by adding a new CLI flag like --exclude <service> so the user could execute e.g. ./sndev start --exclude opensearch. It could also be done by supporting some .gitignored configuration file that is consulted when ./sndev start is executed.

Similar to number 1 above, sndev could be reduced to the minimum required services by default (app, db?), and developers could opt-in to other services, based on what they're trying to do. I'm not sure if this is better than having to opt-out (option 1).

As @huumn mentioned in the related comment thread (linked below), there could also be some cleanup performed on the depends_on entries in docker-compose.yml to reduce which services are automatically spun up, if you were to just spin up the app service (as an example) using ./sndev start app.  I like the idea of a config-driven approach more, I think, but this option certainly provides a workable solution. I guess it comes down to whether you want depends_on to reflect a prod-like configuration, or just the bare minimums for a functional development environment.

Describe alternatives you've considered
Enumerated above.
Additional context
Context comments where this was discussed

Here's a nice hack that works without making any changes to sndev.
Say I want to exclude opensearch and os-dashboard services, I could run:
./sndev start --scale opensearch=0 --scale os-dashboard=0
Inspired from this comment. This leverages the --scale option in docker compose up

Interesting, we could have some presets using this --scale option.
I think starting the minimum required services is best. So that is app, db and worker. It's less error prone and developer can gradually learn about other infrastructure we run like imgproxy, s3, opensearch, ... when they need it.
Since worker will try to index items which is not possible without opensearch, such jobs should fail gracefully with useful error messages.

I’m not sure I would say us starting with less services is the best way. It depends on how we implement running more services (or excluding services), whether running more services is easy to communicate, and what the majority of people are goin to find easiest.
I like that you run one command and that’s it.  But on the other hand this many containers will gobble up ram.
maybe we can inspect ram on device, if it’s low, start in a “minimal” mode. If not, gobble away.
Also, even the worker isn’t needed if we are really talking minimal.

We should probably use profiles for this: https://docs.docker.com/compose/profiles/

app and db don't get profiles because they're mandatory
other profiles

search (adds search stuff)
images (adds image stuff)
payments (adds payments stuff)
all (default)

Profiles sounds like a perfect fit!


Update insertionNode if changed on before-insert

Hello,
I was with the following case:
I wanted to insert the content of the new child inside a container that was created in the "before-insert" hook. As the insertionNode is defined before the hook, it was not catching the right element.
Ex: '.some-selector:last-of-type'
I don't know if this is the best way to solve this, but worked as i expected.
If you find interesting adding this, this is what I modified.

A bit unclear why you would create a container inside the before-insert hook? Why not just add the container class inside the partial? Probably simplifying too much :)
Good for you you got it solved, but as is it is a bit unclear what the added value is of reselecting the selector. Does not seem very efficient. So I need a little more persuading to be convinced :smile:

Closing due to inactivity.


Incohrnecy between prisma and graphql data

I have a question/answer model that I'm using on my app.
Below is the Prisma schema:
model Question {
  id                 String                    @id @default(cuid())
  isPrivate         Boolean
  questionId         String?
  answers            Question[]                @relation("QuestionResponse")
  question           Question?                 @relation("QuestionResponse", fields: [questionId], references: [id])
}

I need to have one query that return all the questions and their responses, which is also working fine. The issue is that i need to get only the non private questions AND answers.
I have the below resolver for the query:
const questions = await ctx.prisma.question.findMany({
      where: {
        questionnaireId: id,
        isPrivate: false,
        questionId: null
      },
      include: {
        answers: {
          where: {
            isPrivate: false
          }
        }
      }
    });
    console.log('questions', JSON.stringify(questions));
    return questions;
  },

The log shows exactly the data that I need (without the private ones), but once I call the query via Graphql query, I got all the questions and answers (including the non private).
This is the GraphQl Query:
query questions {
  questions(id: "ckiviuzkp0731gn8f5ohu4ww4") {
    id
    value
    answers {
      id
      value
    }
  }
}

Below is the graphQL schema for the Question Model:
  type Question {
    id: ID!
    isPrivate: Boolean
    answers: [Question]
    question: Question
    questionnaire: Questionnaire!
  }

and the resolver:
const resolver: IResolverObject = {
  id: (node: any) => node.id,
  isPrivate: (node: any) => node.isPrivate,
  answers: (node: any, args: any, ctx: Context) => ctx.prisma.question.findUnique({ where: { id: node.id } }).answers(),
  question: (node: any, args: any, ctx: Context) => ctx.prisma.question.findUnique({ where: { id: node.id } }).question(),
  questionnaire: (node: any, args: any, ctx: Context) => ctx.prisma.question.findUnique({ where: { id: node.id } }).questionnaire(),
};

How can the result be different for the same query?

Hey @geosigno 👋
In this resolver:
question: (node: any, args: any, ctx: Context) => ctx.prisma.question.findUnique({ where: { id: node.id } }).question()

Could you explain how you query for the private question as well? The query above where you explicitly query for questions is different from your resolvers.


[BUG] The generate_dependencies parameter doesn't work

When debugging the issue I was able to narrow it down to this method:
https://github.com/timostamm/protobuf-ts/blob/54d5e99266a87146cf1ed46b37d8fea9e7c74e33/packages/plugin-framework/src/descriptor-info.ts#L633-L653
I was able to resolve the issue by changing the method to do the following:
 isTypeUsed(type: AnyTypeDescriptorProto, inFiles: FileDescriptorProto[]): boolean {
     // Probably not the right way to get this
     const normalizedTypeName = this.nameLookup._reverse.get(type);
     let used = false;
     for (let fd of inFiles) {
         if (used) return used;
         this.tree.visitTypes(fd, typeDescriptor => {
             if (used) return;
             if (DescriptorProto.is(typeDescriptor)) {
                 const usedInField = typeDescriptor.field
                     .map(f => f.typeName)
                     .filter(Boolean)
                     .map(this.nameLookup.normalizeTypeName)
                     .includes(normalizedTypeName);
                 if (usedInField) {
                     used = true;
                 }
             } else if (ServiceDescriptorProto.is(typeDescriptor)) {
                 const usedInMethodInput = typeDescriptor.method.some(md => this.nameLookup.resolveTypeName(md.inputType!) === type);
                 const usedInMethodOutput = typeDescriptor.method.some(md => this.nameLookup.resolveTypeName(md.outputType!) === type);
                 if (usedInMethodInput || usedInMethodOutput) {
                     used = true;
                 }
             }
         })
     }
     return used;
 }

I'd be happy to open a PR if you think this is the correct way to resolve the issue.

Good catch, @jcready. PR is welcome!
A test case would be nice (but not required), see descriptor-registry.spec.ts for example.

    // Probably not the right way to get this
    const normalizedTypeName = this.nameLookup._reverse.get(type);

You should be able to use makeTypeName:
    const normalizedTypeName = this.nameLookup.makeTypeName(type);

Good catch, @jcready. PR is welcome!
A test case would be nice (but not required), see descriptor-registry.spec.ts for example.

    // Probably not the right way to get this
    const normalizedTypeName = this.nameLookup._reverse.get(type);

You should be able to use makeTypeName:
    const normalizedTypeName = this.nameLookup.makeTypeName(type);

Hey @jcready, I just added your fix. Hope you don't mind, and thank you.

Hey @jcready, I just added your fix. Hope you don't mind, and thank you.

No worries! I've been a bit busy with other things to make time for a proper PR with test coverage. Thank you for fixing the issue and the excellent library!

No worries! I've been a bit busy with other things to make time for a proper PR with test coverage. Thank you for fixing the issue and the excellent library!

Released in v2.0.0-alpha.12

Released in v2.0.0-alpha.12


DxChart - Dxi-Serie - Dxo-Point issue?

16.2.2-beta.2
Point visibility does not seem to work for dxo-option
Code method works
    @Input() chartSeries =     [         { valueField: "downloads", argumentField: "date", name: "Downloads", type: "stackedBar", axis: "downloads", },         {             valueField: "cumulativeDownloads", argumentField: "date", name: "CumulativeDownloads", type: "line",             axis: "cumulativeDownloads",             color: "black", point: { visible: false }         }     ];
        <dxi-serie valueField="cumulativeDownloads" argumentField="date" name="CumulativeDownloads" type="line" axis="cumulativeDownloads"
            color="black">
            <dxo-point visible="false"></dxo-point>
        </dxi-serie>

Found the cause, it is much like #274, I assume
For it to work, you need <dxo-point [visible]="false">
Similarly if you want to turn off the search panel for grids, it is
<dxo-search-panel [visible]="false">


Remove Material dialog library

Android give material dialog support in Alert Dialog, So I used android.support.v7.app.AlertDialog instead of Material dialog.
Support for vector drawable on older platforms (Crash fix in API < 21).

Material Dialogs is my library, which is superior to the AppCompat solution.

Yes, but material-camera does not use superior features of your dialog library. That's why I removed it for less methods count and overcome multidex problem.
I have also fixed crash for supporting vector in API<21.


tests: kernel: interrupt: arch.interrupt.minimallibci fails on nrf54h20 ppr

Describe the bug
The tests:

tests/kernel/interrupt/arch.interrupt.minimallibc
tests/kernel/interrupt/arch.shared_interrupt

Observed for

nrf54h20dk/nrf54h20/cpuppr

To Reproduce
Steps to reproduce the behavior:

have nrf54h20dk/nrf54h20/cpuppr connected
go to your zephyr dir
call ./scripts/twister -T tests/kernel/interrupt -p nrf54h20dk/nrf54h20/cpuppr --device-testing --device-serial /dev/ttyACM1 -v --inline-logs
See console output with error

Expected behavior
Valid console output
Impact
Not clear
Logs and console output
tests/kernel/interrupt/arch.interrupt.minimallibc:
*** Booting Zephyr OS build v3.7.0-rc2-61-g6700a154be3c ***
Running TESTSUITE interrupt_feature
===================================================================
START - test_isr_dynamic
installing dynamic ISR for IRQ 0
PASS - test_isr_dynamic in 0.004 seconds
===================================================================
START - test_isr_offload_job
SKIP - test_isr_offload_job in 0.001 seconds
===================================================================
START - test_isr_offload_job_identi
PASS - test_isr_offload_job_identi in 0.003 seconds
===================================================================
START - test_isr_offload_job_multiple
PASS - test_isr_offload_job_multiple in 0.003 seconds
===================================================================
START - test_nested_isr
Assertion failed at ../../../../../../../../../zephyr/zephyr/tests/kernel/interrupt/src/nested_irq.c:160: interrupt_feature_test_nested_isr: (isr0_result not equal to ISR0_TOKEN)
isr0 did not execute
FAIL - test_nested_isr in 0.026 seconds
===================================================================
START - test_prevent_interruption
locking interrupts
unlocking interrupts
timer fired
PASS - test_prevent_interruption in 0.262 seconds
===================================================================
TESTSUITE interrupt_feature failed.
------ TESTSUITE SUMMARY START ------
SUITE FAIL -  80.00% [interrupt_feature]: pass = 4, fail = 1, skip = 1, total = 6 duration = 0.299 seconds
- PASS - [interrupt_feature.test_isr_dynamic] duration = 0.004 seconds
- SKIP - [interrupt_feature.test_isr_offload_job] duration = 0.001 seconds
- PASS - [interrupt_feature.test_isr_offload_job_identi] duration = 0.003 seconds
- PASS - [interrupt_feature.test_isr_offload_job_multiple] duration = 0.003 seconds
- FAIL - [interrupt_feature.test_nested_isr] duration = 0.026 seconds
- PASS - [interrupt_feature.test_prevent_interruption] duration = 0.262 seconds
------ TESTSUITE SUMMARY END ------
===================================================================
PROJECT EXECUTION FAILED

Environment (please complete the following information):

OS: Ubuntu 20.04.1 LTS
Toolchain Zephyr SDK 0.16.8
Commit SHA or Version used: v3.7.0-rc2-61-g6700a154be3c

https://nordicsemi.atlassian.net/browse/NRFX-6325

Cannot reproduce


Deploy & hosting example

I have gotten my fork running on the free tier of redhat openshift, after a fair amount of hair-pulling.
I'm more interested in running it with dokku (a diy-mini-heroku) on a VM like digitalocean.
I've tried naively deploying the entire app to heroku and dokku instances, but in both cases the build process fails for me - the default buildpack sets NODE_ENV=production before npm install runs, so devDependencies like rimraf in the package.json file are not installed and cause commands like npm run clean to fail.
So I suspect your deploy process involves building everything locally and only deploying the dist/directory to production. I'm curious how you have the deploy scripts set up.
Thanks!

So in my case I think I was overlooking that NODE_ENV and NPM_CONFIG_PRODUCTION have different effects, and I wanted the latter but was messing with the former - thanks, dokku #1434.
More generally, I'm curious about deploy strategies with javascript-only apps - running webpack on my dinky VPS seems like a waste of time when I already run it locally. Do you have a separate repo you use to deploy the `dist/' directory, or do you ship up everything to your server and have it rebuild there?

at the moment, I am deploying to heroku and setting NPM_CONFIG_PRODUCTION=false and rebuilding it there. I then use mLab to host the mongo database.
It deploys to heroku when:

something is pushed to master
when the ci build completes successfully

if i am honest i haven't looked too much into deployment strategies as i normally deploy to heroku so rebuilding isn't too bad, it takes a bit of time, but i only need to do it every now and again

Congratulations on getting it running btw 😄

Thanks for sharing. Yeah I'm pleased to have figured out dokku and digitalocean. I like heroku but I am annoyed by their price-point, esp since mongo etc often costs extra. With dokku, I get close to the convenience of heroku + deeper access to the build stack + much more affordable hosting.
Perhaps you'd be interested in exploring dokku as well. It's pretty slick, digitalocean can spin up an image with it preinstalled in like 60 seconds. Steps to duplicate heroku functionality:

sign up for digitalocean. setup ssh keys. spin up dokku "droplet".
note the IP. visit w/ web browser to set up dokku box.
set up domain name with digitalocean for dokku droplet (could be some little subdomain, like apps.insidersbytes.com)
if you want to try deploying the our-wedding-heros app, adjust the database: environment variable in server/config/config.js to set from process.env.MONGO_URL
> git remote add dokku dokku@<your-dokku-box>:<app-name> (dokku uses  as the subdomain from which it serves the app, i.e. our-wedding-heros.apps.insiderbytes.com)
> git push dokku <your fav branch>:master (dokku only deploys from it's master branch). You'll see familiar, heroku-like feedback after pushing.
Set up mongo dokku plugin: ssh root@<your-dokku-box> (uses ssh keys set up previously)
> dokku config:set <app-name> NPM_CONFIG_PRODUCTION=false
> dokku plugin:install https://github.com/dokku/dokku-mongo.git mongo
> dokku mongo:create <app-db-name>
> dokku mongo:link <app-db-name> <app-name>
Potentially push to dokku again from your development box, wait for build. Should automatically hook into mongo and init db, then get served by nginx at <app-name>.<dokku-sub-domain>.<domain>.<TLD> 👍

If you like dokku, there is a bash script that helps with administration.
if npm build fails on your droplet, maybe you should add some swap space or upgrade droplet size.
Deploying the Right Way: Dokku on Digital Ocean goes into more detail about all the steps above.
lastly, If you decide to try out digitalocean, you can use my promo code to get $10 in hosting credit, enough for a month or two of hosting - I'll get $25 in credit too.

mLab give you a free 500mb mongo instance 😄 and i am using the free tier (i'm cheap like that 😉). If you have to pay for Heroku it is expensive, but it's so easy!
Thanks for the information! I will have a look at it, I haven't heard of dokku before. When I do I will use your promo code 👍

Well I guess the $5/mo 512mb ram "droplet" on digitalocean is slightly cheaper than the $7 512mb hobby dyno on heroku, but obviously heroku is far more convenient. Hm.
On the other hand, for $10/mo, you can use a single dokku image on a digitalocean 1gb droplet to deploy 5-10 apps almost as easily as heroku once it's set up.
I probably should have just gone with heroku instead of figuring this all out though.

btw, I have been filling my dev db with most of our content, I am using the following to update the production db. here it is in case it's useful to you.
# map mongodb to external ports
# note first port listed and use below as <port>. these ports map from nginx to
# the typical mongo ports running in the mongo docker container.
$ dokku mongo:expose <dbname>

# get mongodb auth
$ dokku mongo:info <app-name>
> mongodb://<username>:<password>@<internal-docker-hostname>:27017/<dbname>

# drop remote db and replace with dev db
$ mongodump --archive --db <dbname> | mongorestore --host <dokku-hostname> --port <port> --username <username> --password <password> --drop --archive --db <dbname>

I am just using the free tier, I have been using it since I started the project last year. The sleeping thing is a little annoying.
I was thinking of looking at some point at different ways to deploy / update releases and I was also considering using docker.
It's always good to learn new things 😄.
Thanks I was actually looking at pulling my production database down to my local to check a few things!


Reproducible crash of Defaults.publisher()

The following example will cause a crash:
let c = Defaults.publisher(.someSetting).first().sink { print($0) }

Oops, pressed submit too soon, more details coming soon

The easiest fix would be to remove this line: https://github.com/sindresorhus/Defaults/blob/63dcea312f9cbd17064294a3ae99c9147704b65f/Sources/Defaults/Observation%2BCombine.swift#L30
The observation would be automatically invalidated later on deinit anyway. And because you set subscriber = nil, it guarantees no additional values will be published in the meantime.
I'll submit a PR, I'll add a test case too.


IWorkbenchLayoutService has no startup method

I think there is a problem in @codingame/monaco-vscode-workbench-service-override/workbench.js:

Why is the startup being called?

It means you are importing the workbench-server-override without using registering the returned services


Problem merging font awesome into default font

Hello. I maintain an ImGui backend for the library Raylib (https://www.raylib.com/), for both C++ and C#.
One feature of the backend is that by default we add font awesome icons to the default font so that people can easily use them in ImGui.
I'm having a problem with the C# version of the code, no mater what I try I can't get the font to merge in anymore. This used to work a while ago, but there have been some library updates and refactors since I tested it last (changing over to events, etc..).
I'm in the process of updating the C# backend to the current ImGui.net <IP_ADDRESS>, so I know I'm on current code.
This is my font loading code for C#
https://github.com/raylib-extras/rlImGui-cs/blob/23df04bc3ee07c2225594e2e378955fec57662c4/rlImGui/rlImGui.cs#L277
C#
unsafe
{
    ImFontConfig icons_config = new ImFontConfig();
    icons_config.MergeMode = 1;                      // merge the glyph ranges into the default font
    icons_config.PixelSnapH = 1;                     // don't try to render on partial pixels
    icons_config.FontDataOwnedByAtlas = 0;           // the font atlas does not own this font data

    icons_config.GlyphMaxAdvanceX = float.MaxValue;
    icons_config.RasterizerMultiply = 1.0f;
    icons_config.OversampleH = 2;
    icons_config.OversampleV = 1;

    ushort[] IconRanges = new ushort[3];
    IconRanges[0] = IconFonts.FontAwesome6.IconMin;
    IconRanges[1] = IconFonts.FontAwesome6.IconMax;
    IconRanges[2] = 0;

    fixed (ushort* range = &IconRanges[0])
    {
        // this unmanaged memory must remain allocated for the entire run of rlImgui
        IconFonts.FontAwesome6.IconFontRanges = Marshal.AllocHGlobal(6);
        Buffer.MemoryCopy(range, IconFonts.FontAwesome6.IconFontRanges.ToPointer(), 6, 6);
        icons_config.GlyphRanges = (ushort*)IconFonts.FontAwesome6.IconFontRanges.ToPointer();

        byte[] fontDataBuffer = Convert.FromBase64String(IconFonts.FontAwesome6.IconFontData);

        fixed (byte* buffer = fontDataBuffer)
        {
            var fontPtr = ImGui.GetIO().Fonts.AddFontFromMemoryTTF(new IntPtr(buffer), fontDataBuffer.Length, 11, &icons_config, IconFonts.FontAwesome6.IconFontRanges);
        }
    }
}

The font atlas that is generated does not have any of the merged characters in it.

It never seems to load the font. It does not mater if I use the font from memory or a file on disk, so I don't think it's a data issue.
The code very similar to what I do in the C++ version of the backend, and that code does work.
https://github.com/raylib-extras/rlImGui/blob/de2c361b5835e6c2075b4f314bc7d949869666f1/rlImGui.cpp#L252
C++
	ImFontConfig icons_config;
	icons_config.MergeMode = true;
	icons_config.PixelSnapH = true;
	icons_config.FontDataOwnedByAtlas = false;

	icons_config.GlyphRanges = icons_ranges;

    ImGuiIO& io = ImGui::GetIO();

	io.Fonts->AddFontFromMemoryCompressedTTF((void*)fa_solid_900_compressed_data, fa_solid_900_compressed_size, FONT_AWESOME_ICON_SIZE, &icons_config, icons_ranges);

With this code in C++, I do see the icon fonts as part of the font atlas.

I'm sure there is something I'm missing or doing wrong, C# hasn't been my primary language for a while. Anyone have any idea what more I can do to try and track this down? Any help would be appreciated.

I got this working a while ago, and I believe you must call ImGuiNative.ImFontConfig_ImFontConfig to properly create an ImFontConfig:
ImFontConfig* icons_config = ImGuiNative.ImFontConfig_ImFontConfig();
icons_config->MergeMode = 1;
// etc...

Just cloned rlImGui-cs and tried it myself. The font seems to show up correctly now in the Metrics/Debugger window. Will make a PR.

Imgui constructors should be optional, looks like a imgui bug and you should report it to imgui repo.

Imgui constructors should be optional, looks like a imgui bug and you should report it to imgui repo.

The C++ version works just fine, so I don't think it's core ImGui issue. I think the main problem is that I was not allocating a native pointer, but a managed structure and it didn't marshal to the .net C# bindings correctly.

Read “Constructors/destructors” in https://github.com/dearimgui/dear_bindings repo.

@JeffM2501, did you find the solution?

@tingspain Have you tried calling ImGuiNative.ImFontConfig_ImFontConfig() instead of the ImFontConfig constructor? See my comment and PR for details.
I don't know why this would break in 1.90.0 though.

@NoahStolk, indeed.  I am sorry to not post my solution earlier.
Here is my code.
public static void AddIconsFonts(float fontSize, char iconMin, char iconMax, string fontFilePath)
{
      unsafe {

            ushort[]  ranges = { iconMin, iconMax, 0 };

            var rangesIntPtr = Marshal.UnsafeAddrOfPinnedArrayElement(ranges, 0);

            ImFontConfigPtr fontConfig      = ImGuiNative.ImFontConfig_ImFontConfig();
            fontConfig.MergeMode            = true;
            fontConfig.OversampleH          = 3;
            fontConfig.OversampleV          = 3;
            fontConfig.GlyphOffset          = Vector2.Zero;
            fontConfig.FontDataOwnedByAtlas = false;
            fontConfig.PixelSnapH           = true;
            fontConfig.GlyphMaxAdvanceX     = float.MaxValue;
            fontConfig.RasterizerMultiply   = 2.0f;

            ImGui.GetIO().Fonts.AddFontFromFileTTF( fontFilePath,
                                                      fontSize,
                                                      fontConfig,
                                                      rangesIntPtr);

      }
}

(Just in case, it  will be useful for someone)
And then I use it in my ImGuiController as follow:
var io = ImGui.GetIO();

unsafe {

      // Sanity Check
      if(!Core.Utils.FileExists("Assets/Fonts/Manrope/Manrope-Regular.ttf"))
            throw new System.NullReferenceException("The app can not find the default font");

      // Add the default fonts for the App
      io.Fonts.AddFontFromFileTTF("Assets/Fonts/Manrope/Manrope-Regular.ttf", 17.0f);

      // Add the App Icons
      if(Core.Utils.FileExists( ImGuiExt.AppIcons.FontFile ) )
            ImGuiExt.AddIconsFonts(14,
                                   ImGuiExt.AppIcons.IconMin,
                                   ImGuiExt.AppIcons.IconMax,
                                   ImGuiExt.AppIcons.FontFile);

}

io.ConfigFlags  |= ImGuiConfigFlags.DockingEnable         | ImGuiConfigFlags.ViewportsEnable | ImGuiConfigFlags.NavEnableKeyboard;
io.BackendFlags |= ImGuiBackendFlags.RendererHasVtxOffset | ImGuiBackendFlags.PlatformHasViewports;
io.Fonts.Build();

It will be more than welcome if anyone has any feedback/suggestion/recommendation.  ^___^
Thanks in advance!!!

holyy shit man genius...
forget font-awesome , i wasnt able to replace  normal Font no matter what...
```
public static void AddFont_viaGH460_build(string fontFilePath, float fontSize)
    {
        var io = ImGui.GetIO();

        unsafe
        {

            // Add the default fonts for the App
            io.Fonts.AddFontFromFileTTF(fontFilePath, 22.0f);

        }

        io.ConfigFlags |= ImGuiConfigFlags.DockingEnable | ImGuiConfigFlags.ViewportsEnable | ImGuiConfigFlags.NavEnableKeyboard;
        io.BackendFlags |= ImGuiBackendFlags.RendererHasVtxOffset | ImGuiBackendFlags.PlatformHasViewports;
        io.Fonts.Build();
    }

it works.

but i wish we can replace it while app is running.   not just Controller definition.

at ImGUIController.cs    i pasted the code here....

///
/// Constructs a new ImGuiController.
///
public ImGuiController(GraphicsDevice gd, OutputDescription outputDescription, int width, int height)
{
_gd = gd;
_windowWidth = width;
_windowHeight = height;
 ImGui.CreateContext();
 var io = ImGui.GetIO();
 io.BackendFlags |= ImGuiBackendFlags.RendererHasVtxOffset;
 io.ConfigFlags |= ImGuiConfigFlags.NavEnableKeyboard |
     ImGuiConfigFlags.DockingEnable;
 io.Fonts.Flags |= ImFontAtlasFlags.NoBakedLines;

 string FontPath = @"C:\Windows\Fonts\arial.ttf";
 Program.AddFont_viaGH460_build(FontPath, 22);

 CreateDeviceResources(gd, outputDescription);
 SetPerFrameImGuiData(1f / 60f);
 ImGui.NewFrame();
 _frameBegun = true;

}


Wildcard max_expansion version check update

Description
Change from 2x to 1.3 for wildcard interval max_expansion version check
since #1916 was backported.
Check List

[X] New functionality includes testing.

[X] All tests pass

[X] New functionality has been documented.

[X] New functionality has javadoc added

[X] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

cc @nknize @reta

@mattweber  I think we need to wait till https://github.com/opensearch-project/OpenSearch/pull/1979 gets in

@reta  yup, just wanted to have this ready to go.

x   Gradle Check failure 67b4833 Log 2068
Reports 2068

That is expected :-)

@reta can you please kick off the check again now that #1979 is merged

start gradle check

@reta can you please kick off the check again now that #1979 is merged

Sorry, I cannot, only for maintainers :-)


Fixed #688 Make getTotalRows public

Made getTotalRows public
Update index before returning the value
Changed Router's querying design docs to call getCurrentTotalRows()

#688

@hideki  as the fix per your review is very small, I rebased it to the original commit. I also rebased with the current master. Could you


dropped to released version of piplelines

The preview version of pipelines is not in corfxlab myget not on nuget.org. This means adding System.Buffers.ReaderWriter to a project fails, unless the project has pipelines myget feed (which is not common or intuitive). Since ReaderWriter (nor any components in corfxlab) needs preview of pipelines, I am dropping the pipelines dependency to the officially released on nuget.org.

@dotnet-bot test Innerloop OSX10.12 Release Build and Test

The latest pipelines package from master also has its own dependency issue due to System.Buffers which is blocking https://github.com/dotnet/corefxlab/pull/2550, so dropping to release is fine. However, I don't understand why it is necessary for you.
Also, remove it from the update-Dependencies project or it will change again when a new build comes out (with auto-PR):
https://github.com/dotnet/corefxlab/blob/fe117a6a49212d0f93e3ae4387d1fa05b5024c20/scripts/update-dependencies/Program.cs#L104


is there a module for nodejs?

casperjs is a greate project, if there a module for nodejs?

I think I found a way, after reading "Can I use CasperJS without using the casperjs executable?"
and there is a node module for phantomjs

On Mon, Feb 27, 2012 at 01:04, TZ
<EMAIL_ADDRESS>wrote:

casperjs is a greate project, if there a module for nodejs?

Nope, but using it using a subprocess is very easy, eg.
https://github.com/n1k0/nodetunes/blob/master/Cakefile#L41
Maybe you can use something like phantomjs-node, but it does
/basically/ the same thing.
++
--
Nicolas Perriault
http://www.akei.com/ — http://prendreuncafe.com/
Mobile: +33 660 92 08 67 — Skype: nperriault


Add unit tests to cpu

Take care of #108 (help argument) first. Many more incoming changes rely on it.
Resolves #112 (unit tests and refactor for cpu)

Codecov Report

Merging #115 into master will increase coverage by 0.41%.
The diff coverage is 80.64%.

@@            Coverage Diff             @@
##           master     #115      +/-   ##
==========================================
+ Coverage   81.12%   81.54%   +0.41%
==========================================
  Files          13       15       +2
  Lines         551      596      +45
==========================================
+ Hits          447      486      +39
- Misses        104      110       +6

Impacted Files
Coverage Δ

lib/pkg/cpu/cpulinux.go
0% <0%> (ø)

lib/pkg/cpu/cpu.go
90.69% <86.2%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4df0796...1d12967. Read the comment docs.


match batch size of data in model config

This fixes the following exception when training with different batch size:
$ python train.py --task biosnap --batch-size 4
Let's use 4 GPUs!
--- Data Preparation ---
Traceback (most recent call last):
  File "train.py", line 206, in <module>
    model_max, loss_history = main()
  File "train.py", line 156, in main
    auc, auprc, f1, logits, loss = test(testing_generator, model_max)
  File "train.py", line 64, in test
    loss = loss_fct(logits, label)
  File "/home/user/anaconda3/envs/MolTrans/lib/python3.7/site-packages/torch/nn/modules/module.py", line 1051, in _call_impl
    return forward_call(*input, **kwargs)
  File "/home/deepp/anaconda3/envs/MolTrans/lib/python3.7/site-packages/torch/nn/modules/loss.py", line 612, in forward
    return F.binary_cross_entropy(input, target, weight=self.weight, reduction=self.reduction)
  File "/home/user/anaconda3/envs/MolTrans/lib/python3.7/site-packages/torch/nn/functional.py", line 2886, in binary_cross_entropy
    "Please ensure they have the same size.".format(target.size(), input.size())
ValueError: Using a target size (torch.Size([4])) that is different to the input size (torch.Size([16])) is deprecated. Please ensure they have the same size.

Thanks!


Trouble Installing gulp-sass - Error: Cannot find module 'C:\scripts\install.js'

I've been stuck on this for several hours. I spent a lot of time googling and trying other's suggestions but no luck so far...
Here's a snapshot of my setup.
PATH
%appdata%\npm; %ProgramFiles%\nodejs; C:\Users\cjaeger1\AppData\Roaming\npm
NODE_PATH
%AppData%\npm\node_modules

node -p process.versios
{ http_parser: '2.3',
node: '0.12.6',
v8: '<IP_ADDRESS>',
uv: '1.6.1',
zlib: '1.2.8',
modules: '14',
openssl: '1.0.1o' }
node -p process.platform
win32
node -p process.arch
x64
npm install --save-dev gulp-sass
npm WARN package.json<EMAIL_ADDRESS>No repository field.
npm WARN package.json<EMAIL_ADDRESS>No README data

<EMAIL_ADDRESS>install c:\sites\iq-responsive\node_modules\gulp-sass\node_mod
ules\node-sass
node scripts/install.js

module.js:338
throw err;
^
Error: Cannot find module 'C:\scripts\install.js'
at Function.Module._resolveFilename (module.js:336:15)
at Function.Module._load (module.js:278:25)
at Function.Module.runMain (module.js:501:10)
at startup (node.js:129:16)
at node.js:814:3
npm ERR! Windows_NT 6.1.7601
npm ERR! argv "c:\Program Files\nodejs\node.exe" "c:\Program Files\nodejs
node_modules\npm\bin\npm-cli.js" "install" "--save-dev" "gulp-sass"
npm ERR! node v0.12.6
npm ERR! npm  v2.11.2
npm ERR! code ELIFECYCLE
npm ERR<EMAIL_ADDRESS>install: node scripts/install.js
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>install script 'node scripts/install.js'.
npm ERR! This is most likely a problem with the node-sass package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node scripts/install.js
npm ERR! You can get their info via:
npm ERR!     npm owner ls node-sass
npm ERR! There is likely additional logging output above.
npm ERR! Please include the following file with any support request:
npm ERR!     c:\sites\iq-responsive\npm-debug.log
Let me know if I should include a gist of the npm-debug.log
Thanks for any guidance!

Hi @jaegz, please follow the steps in the TROUBLESHOOTING guide and add the output to a gist.

same problem on ubuntu 14.04.
what is the problem?

Hi @mingfang, please follow the steps in the TROUBLESHOOTING guide and add the output to a gist.

Thanks @xzyfer .
Indeed the troubleshooting guide said to use -unsafe-perm and it works now.
Thanks for the quick response.

Followed the TROUBLESHOOTING guide and here's a gist of the output: https://gist.github.com/jaegz/251c27efc6f955aafce2
Thanks

Are you running npm install from cmd.exe or some other way?

Hi @saper,
I am running npm install from git bash

Can you try from cmd.exe shell if it works better?

Ok just tried it out... running into same error

I install gulp-sass，but every time it stoped there and never go on.    Windows 64 OS.

but if I install node-sass first and than install gulp-sass,it wil be installed successly.

Still stumped on this... My colleague with the same lenovo laptop was able to install this no problem. I switched my PATH variable to match his, and deleted the NODE_PATH... still getting kicked from install with same error mentioned above. Anything else I can provide that could help troubleshoot this issue?

Same problem here on windows 7 64

Please follow the TROUBLESHOOTING guide and paste the output produced into a github gist before posting "me too" style comments.

Anything else I can provide that could help troubleshoot this issue?

Can you try this under cmd.exe:
npm cache clean
npm install -ddd node-sass 2> npm.log

and post npm.log to gist.github.com again?

Sure thing, here it is:
https://gist.github.com/jaegz/a4195373e89e741afb6a

Can you post your environment values (SET) - if it's not too private?

Can you try to create C:\Users\cjaeger1\something and try to npm install node-sass there? Will it report C:\scripts\install.js failure or some other directory?

Also, can you go to C:\Users\cjaeger1\something and start
C:\WINDOWS\System32\cmd.exe /c node

and then type process.cwd() ?

It's me again - I have added some extra logging in my private npm fork. Can you just replace lib/utils/lifecycle.js in your npm install directorywith this file: https://github.com/saper/npm/blob/lifecyclelog/lib/utils/lifecycle.js and report the results of npm install -ddd node-sass agaaain

@saper thanks for looking deeper into this... much appreciated!
I'll be back at my desk in about 10hrs to step through everything and report back.
Btw, I just browsed that issue reference to npm/npm and I remember running into issues with phantomjs as well (while trying to install gulp-svg-sprite). I have put that issue on the back burner as node-sass/gulp-sass has been my main concern. Should I also post what smikes & othiym23 have suggested?

npm config ls is always nice, but I think we need to get more logs :)

Can you post your environment values (SET) - if it's not too private?

User PATH
C:\Windows\System32;C:\Users\cjaeger1\AppData\Roaming\npm
System Path
C:\Windows\System32;C:\Program Files (x86)\Intel\iCLS Client;C:\Program Files\Intel\iCLS Client;%SystemRoot%\system32;%SystemRoot%;%SystemRoot%\System32\Wbem;%SYSTEMROOT%\System32\WindowsPowerShell\v1.0;C:\Program Files\Intel\Intel(R) Management Engine Components\DAL;C:\Program Files\Intel\Intel(R) Management Engine Components\IPT;C:\Program Files (x86)\Intel\Intel(R) Management Engine Components\DAL;C:\Program Files (x86)\Intel\Intel(R) Management Engine Components\IPT;C:\Program Files\Intel\WiFi\bin;C:\Program Files\Common Files\Intel\WirelessCommon;C:\Program Files (x86)\Common Files\Lenovo;C:\SWTOOLS\ReadyApps;C:\Ruby193\bin;C:\Program Files\nodejs\

Can you try to create C:\Users\cjaeger1\something and try to npm install node-sass there? Will it report C:\scripts\install.js failure or some other directory? (just make sure you nuke all other copies of node_modules if possible).

Created C:\Users\cjaeger1\temp1 and ran npm install node-sass and reports fail to 'C:\scripts\install.js' (by nuke all other copies of node_modules you mean in that temp1 dir only, correct?)

Also, can you go to C:\Users\cjaeger1\something and start
C:\WINDOWS\System32\cmd.exe /c node
and then type process.cwd() ?

Outputs 'C:\\'

It's me again - I have added some extra logging in my private npm fork. Can you just replace lib/utils/lifecycle.js in your npm install directorywith this file: https://github.com/saper/npm/blob/lifecyclelog/lib/utils/lifecycle.js and report the results of npm install -ddd node-sass agaaain

Here she is: https://gist.github.com/jaegz/b0fc3fad2baa2fe6a70d

Also, can you go to C:\Users\cjaeger1\something and start
C:\WINDOWS\System32\cmd.exe /c node
and then type process.cwd() ?

Outputs 'C:\\'

This is the reason! But why? Is there any node.bat or anything on your %PATH% ?

Also, can you go to C:\Users\cjaeger1\something and start
C:\WINDOWS\System32\cmd.exe /c node
and then type process.cwd() ?

Outputs 'C:\\'

And when you do
C:\> cd C:\Users\cjaeger1
C:\Users\cjaeger1> C:\WINDOWS\System32\cmd.exe /C cmd

what is your working directory?

Can you post your environment values (SET) - if it's not too private?

User PATH
C:\Windows\System32;C:\Users\cjaeger1\AppData\Roaming\npm

Continuing ... what do the following commands say:
reg query "HKLM\Software\Microsoft\Command Processor" /s
reg query "HKCU\Software\Microsoft\Command Processor" /s

This is the reason! But why? Is there any node.bat or anything on your %PATH% ?

Great news, we're getting closer!

And when you do
C:> cd C:\Users\cjaeger1
C:\Users\cjaeger1> C:\WINDOWS\System32\cmd.exe /C cmd
what is your working directory?

working directory is C:>

Continuing ... what do the following commands say:
reg query "HKLM\Software\Microsoft\Command Processor" /s
reg query "HKCU\Software\Microsoft\Command Processor" /s

C:>reg query "HKLM\Software\Microsoft\Command Processor" /s
HKEY_LOCAL_MACHINE\Software\Microsoft\Command Processor
CompletionChar    REG_DWORD    0x40
DefaultColor    REG_DWORD    0x0
EnableExtensions    REG_DWORD    0x1
PathCompletionChar    REG_DWORD    0x40
C:>reg query "HKCU\Software\Microsoft\Command Processor" /s
HKEY_CURRENT_USER\Software\Microsoft\Command Processor
CompletionChar    REG_DWORD    0x9
DefaultColor    REG_DWORD    0x0
EnableExtensions    REG_DWORD    0x1
PathCompletionChar    REG_DWORD    0x9
Autorun    REG_SZ    CD /d C:\

On Tue, 11 Aug 2015, chris jaeger wrote:

Great news, we're getting closer!
C:>reg query "HKCU\Software\Microsoft\Command Processor" /s
HKEY_CURRENT_USER\Software\Microsoft\Command Processor
CompletionChar    REG_DWORD    0x9
DefaultColor    REG_DWORD    0x0
EnableExtensions    REG_DWORD    0x1
PathCompletionChar    REG_DWORD    0x9
Autorun    REG_SZ    CD /d C:
^^^^^^^^^

This is it. The same as https://github.com/sass/node-sass/issues/1012#issuecomment-115715502
Please remove this entry and everything will work(tm).

YES! npm install node-sass successful!
I don't remember ever setting up an autorun, but that's definitely what was failing the installations.
THANK YOU @saper
Let me know where to send beer money

Amazing work on this @saper.

Sorry, @saper I can install gulp-sass
npm install --save-dev gulp-sass doesn't work git:bash  always write that I must to install  gulp-sass
I'm open PowerShell on windows 10 do:
PS C:> reg query "HKCU\Software\Microsoft\Command Processor" /s
HKEY_CURRENT_USER\Software\Microsoft\Command Processor
CompletionChar    REG_DWORD    0x9
DefaultColor    REG_DWORD    0x0
EnableExtensions    REG_DWORD    0x1
PathCompletionChar    REG_DWORD    0x9
can you help me?

Running npm install --save gulp-sass --unsafe-perm worked for me.
node -v
v8.9.3
npm -v
5.5.1


How can I use a local copy of  marked.min.js

I have a local copy of  marked.min.js (and its dependencies TextRenderer.js, Slugger.js, etc...), plus I load md-block locally as well:
<script type="module" src="scripts/md-block.js"></script>

How can I now tell md-block to use the local script/marked.min.js and not the CDN https://cdn.jsdelivr.net/npm/marked/src/marked.min.js?

Did you try changing the URL in the md-block.js file? On line 10:
export const URLs = {
	marked: "https://cdn.jsdelivr.net/npm/marked/src/marked.min.js",
	DOMPurify<EMAIL_ADDRESS>}

Check the Using different URLs for marked and DOMPurify section in the README.


Lowest power consumption

Closing the screen
-->  digitalWrite(4, LOW);
Closing Wifi+BT
-->   WiFi.disconnect(true);
-->   WiFi.mode(WIFI_OFF);    // Switch WiFi off
Not reading the bat
-->  digitalWrite(POWER_EN_PIN, LOW);
And going to deep sleep
Best I can get is ~22ma consumption on the USB
Seems the USB chip put itself to off when not powered, and this is fine
So about 7.7 ma , when reading power from only the Battery ( most relevant metric)
But still 7.7mA, is way to much considering the Esp32 could go in the uA range!
Any other idea ?
Seems to be a firmware available ,,,,
https://github.com/Xinyuan-LilyGO/TTGO-T-Display/tree/master/firmware
I've never done this type of upgrade
Is this to fix this ?

Did the upload, With this tool
https://www.espressif.com/en/support/download/other-tools

It was suprisigly simple
The demo code can demonstrate a power down mode that I mesure down to 0.2mA in deep sleep.
This is cool
But my code still do 7.7mA
Will have to investigate further

Same problem here.
I get 17-19mA when connected to the USB. I haven't measured it only connected to the battery.


move_meta_stat_changes does not include Shell Smash.

Shell Smash: Raises user's Attack, Special Attack, and Speed by two stages. Lower user's Defense and Special Defense by one stage.

Presumably because the data structure for moves in the games has room for only 3 modified stats per move, the move_meta_stat_changes table (which presumably was built just from the move data structure in the games) lacks the stat change data for the move Shell Smash.
Luckily, if Bulbapedia's Shell Smash trivia section is to be believed and extrapolated from, it is probably the only move whose stat change data is missing. ("Shell Smash is the only status move that will always affect more than three stats simultaneously.")
Anyway, here's what you need to add:
move_id,stat_id,change
504,2,2
504,3,-1
504,4,2
504,5,-1
504,6,2

Hi it's been 4 years. Why is shell smash still missing the effect entries...?


remove redundant dependencies

Background
While implementing #21, I noticed that the library appeared to have some redundant dependencies. As I like to avoid transitive dependencies where possible, I thought I'd propose these changes.
Changes

change IsColorTerminal to no longer depend on golang.org/x/term, since we already depend on go-isatty and can just use that

while doing this, I thought we might as well upgrade go-isatty to the newest version, which also lets us use a tagged version for golang.org/x/sys

add asciiValid and asciiValidPrint functions, to avoid the dependency on segmentio/encoding (outside of tests, but that doesn't affect transitive dependencies)

since the rest of the codebase is ported without depending on segmentio, I thought it was a shame that just these two functions brought that whole dependency
also ported the tests for these functions

Sorry if I should have raised an issue about this first, but hope you might appreciate it anyway!

@hermannm Thank you, this is a great improvement! It's greatly appreciated.
I've got a bit of work to do on the GH workflow, it hasn't been touched in a while and has deprecation warnings for old versions of actions, and then I'll tag and release.
Thank you for all the work. Do you have any interest in being added as a collaborator on the repo?

Thank you for all the work. Do you have any interest in being added as a collaborator on the repo?

@neilotoole Sure, I'd be delighted to!

@hermannm Excellent. Invitation sent. Welcome!
Also: v0.7.0 has been tagged. Please feel free to verify if you have time.

@neilotoole Great to hear! I'll check it out


[RFC]: Add C implementation for @stdlib/math/base/special/minmax

Description
This RFC proposes to add a C implementation for @stdlib/math/base/special/minmax
Related Issues
Progresses #649
Questions

I note that the implementations of min and max are already available. Should the C implementation exactly follow the logic in the JS files, or could it use the min and max functions in C while maintaining the same function signature and return values?

Other
No.
Checklist

[X] I have read and understood the Code of Conduct.
[X] Searched for existing issues and pull requests.
[X] The issue name begins with RFC:.

@anirudhprabhakaran3 Sorry to be the bearer of bad news, but there is already a PR up for minmax: https://github.com/stdlib-js/stdlib/pull/1939.

Aah😔 seems like I have the worst luck coming to this!

@kgryte I'd like to work on this.

Can I work on this issue ?


Fixed issue with missing kind variable

Pull Request Test Coverage Report for Build 67

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 64:
0.0%

Covered Lines:
147

Relevant Lines:
147

💛  - Coveralls


sc's basic command don't work

Typed:
=
3
[RETURN]

Is this reproducible? I cannot confirm this behavior.

I tried it on Android 5.1 by using Termux.

Termux went through some big changes since 2020, and requires Android 7 now. Support for Android 5 was officially dropped on 01-01-2020, well before this issue was opened.
On my old tablet (2016) with Android 8 and the latest sc version from package n-t-roff-sc in the current Main repository, I cannot reproduce this issue.