Missing ListData interface in react-stately package

🐛 Bug Report
In @react-stately/data, the DataList interface is exported.
But missing ListData interface in react-stately package now.

🤔 Expected Behavior
ListData can be imported from the react-stately package.

😯 Current Behavior
ListData is not exported in the react-stately package.

💁 Possible Solution
Change https://github.com/adobe/react-spectrum/blob/main/packages/react-stately/src/index.ts to export ListData type
export type { ListData } from "@react-stately/data";

🔦 Context

The interface that can be imported in @react-stately/data can't be imported in react-stately, so I'm having trouble.

💻 Code Sample

🌍 Your Environment

Software
Version(s)

react-spectrum
3.3.0

Browser

Operating System

🧢 Your Company/Team

🕷 Tracking Issue (optional)

@kqito Hey, mind expanding on what you need the ListData type for? Are you running into a typescript issue where you need that type definition?

@LFDanLu Thank you for the reply!
For example, if I want to define ListData as a type of props, I will need this.
import { VFC } from "react";
import { ListData, useListData } from "@react-stately/data";

type ListDataItemsProps = {
  listData: ListData<string>;
};

const ListDataItems: VFC<ListDataItemsProps> = (props) => {
  return (

      {props.listData.items.map((item) => (
        {item}
      ))}

  );
};

const App: VFC = () => {
  const listData = useListData<string>({});

  return (

      <ListDataItems listData={listData} />

  );
};

export default App;

Are you running into a typescript issue where you need that type definition?

Of course, I think it is possible to use ListData by using ReturnType and other types, but I had a question about the fact that it is exported in @react-stately/data and not in react-stately.

@kqito Oh I see, this seems accidental to me, I think that type should've been included in the react-stately export as well.

I will create a PR to export the ListData and fix this. ;)
By the way, I think there are some interfaces other than ListData that have not been exported yet, are you planning to export them as well?

Which interfaces are you referring to? Ones like ListOptions or AsyncListData?

Yes. I'm also wondering if I should export interfaces related to hooks other than useDataList.

Sure, if you find any others that you think should be exported you can include them as well. If you find a lot, it might be worthwhile creating a bulk tracking issue for it.


Mask errors in Ember server runConnection

Fixes https://github.com/http4s/http4s/issues/7149.
Ok, so I'm not entirely sold on this change. Masking errors seems like a world of pain when things go wrong in unexpected ways. Here's my thinking:

all errors should already be reported through side-channels. So letting them leak to the unhandled error reporting just results in duplicate logging.

Random unhandled errors popping up is very unpopular. This issue is not the first time we've gotten complaints.
https://github.com/http4s/http4s/issues/7149

I did have one other implementation idea: after reporting an error through a side-channel, we could self-cancel the current fiber. Then, there would be no need to mask errors, and any errors that did appear would be legit. However, cancelation is rather drastic (unrecoverable) and may have unintended effects. Also Error and Canceled are distinct pathways e.g. in onFinalizeCase so it could be confusing for that as well.

Cancellation is weird and makes reasoning even trickier. Prefer masking to that.

I understand that you are not sold on this. In general I am against error masking myself.
I think one of the problems with error handling in http servers in general is that there exist error states that can happen due to clients behaving in a bad way. In this case interrupting connections, but I remember error logging for invalid user agent headers from the akka-http days. For me as someone who runs services which get lots of traffic from the internet: error logging in these cases is painful because it is very noisy and I can do nothing about it other than filtering them myself in some hacky way or another.
In my perfect world it would be easy to distinguish between "errors that are of interest" and "noisy stuff because http clients are weird" but I don't think that is really achievable or maintainable.
I would believe that this change makes my world better even if it is not perfect.


Out of Office

Hey to whoever is reading this 👋
Thanks for the interest in these icons! Please do let me know if any coins are missing, or need updating. I'm going to be away from my computer for a few weeks whilst on vacation – so I'm not ignoring any issues or have forgotten about this!

rather than making an issue, can i please ask in what way we must disclose the source of the icons in a website?


FindPattern performance

Currently it uses memcmp for each address, however, it's more effective to find the first byte of a pattern via memchr (which is highly optimized) first and then compare the found address against the whole pattern.

Thanks for the tip! I don't think I've ever come across memchr before, it looks really handy.


Converted to English

Converted to English from Swedish version

I'm sorry, but we no longer accept new sheets that are just an alternate translation to an existing sheet. If you would like to add a new translation for this sheet, please update the original sheet to use Roll20's sheet translation tools.

Hi @Jedra7609 are you still hoping to make this sheet English compatible? I can make a start if you'd like.

Hi,
I converted the sheet into English and submitted it but it seems they can't accept it this way.  The original will need to be re-written to allow the inbuilt Roll20 translation tools to work.


How to fetch threads of a ticket

Hi @thomas-kl1,
I just successfully fetched the data of a ticket via
$ticketDataObject = $gateway->getOperationPool()->getReadOperation('tickets')->get($params["ticket_id"]);

The response I get is this (via print_r):

Zoho\Desk\Model\DataObject Object
--
  | (
  | [entityIdFieldName:protected] => id
  | [data:protected] => Array
  | (
  | [modifiedTime] => 2021-12-09T08:17:06.000Z
  | [subCategory] =>
  | [statusType] => Open
  | [subject] => WG: xxx
  | [dueDate] =>
  | [departmentId] =><PHONE_NUMBER>00006907
  | [channel] => Email
  | [onholdTime] =>
  | [language] => German
  | [source] => Array
  | (
  | [appName] =>
  | [extId] =>
  | [permalink] =>
  | [type] => SYSTEM
  | [appPhotoURL] =>
  | )
  |
  | [resolution] =>
  | [sharedDepartments] => Array
  | (
  | )
  |
  | [closedTime] =>
  | [approvalCount] => 0
  | [isOverDue] =>
  | [isTrashed] =>
  | [createdTime] => 2021-12-07T12:57:57.000Z
  | [id] =><PHONE_NUMBER>06120001
  | [isResponseOverdue] =>
  | [customerResponseTime] => 2021-12-08T07:42:14.000Z
  | [productId] =>
  | [contactId] =><PHONE_NUMBER>06131069
  | [threadCount] => 7
  | [secondaryContacts] => Array
  | (
  | )
  |
  | [priority] =>
  | [classification] =>
  | [commentCount] => 0
  | [taskCount] => 1
  | [accountId] =>
  | [phone] =>
  | [webUrl] =>
  | [isSpam] =>
  | [status] =>
  | [entitySkills] => Array
  | (
  | )
  |
  | [ticketNumber] => 861
  | [sentiment] =>
  | [customFields] => Array
  | (
  | [Rückmeldung bevorzugt per] =>
  | [Link zu Angebot] =>
  | [Rückmeldung erwünscht bis] =>
  | )
  |
  | [isArchived] =>
  | [description] =>
  | [timeEntryCount] => 0
  | [channelRelatedInfo] =>
  | [responseDueDate] =>
  | [isDeleted] =>
  | [modifiedBy] =><PHONE_NUMBER>00069005
  | [followerCount] => 0
  | [email] => xxx
  | [layoutDetails] => Array
  | (
  | [id] =><PHONE_NUMBER>00083011
  | [layoutName] => Sales
  | )
  |
  | [channelCode] =>
  | [isFollowing] =>
  | [cf] => Array
  | (
  | [cf_link_zu_angebot] =>
  | [cf_ruckmeldung_bevorzugt] =>
  | [cf_ruckmeldung_erwunscht_bis] =>
  | )
  |
  | [slaId] =>
  | [layoutId] =><PHONE_NUMBER>00083011
  | [assigneeId] =><PHONE_NUMBER>00069005
  | [createdBy] =><PHONE_NUMBER>00069005
  | [teamId] =>
  | [tagCount] => 0
  | [attachmentCount] => 0
  | [isEscalated] =>
  | [category] =>
  | )
  |
  | )

I can see in the threadCount, that there are 7 replies on this ticket. My question is, how can I get those threads?
I found this specific information in the zoho desk api documentation, but I am not sure how to implement this using your php interface:
https://desk.zoho.com/DeskAPIDocument#Threads#Threads_Listconversations
Thank you in advance for your help.
Best,
Christian

Hi @ca-dsgn
Thank you for using this lib!
Could you try the following?
`$criteriaBuilder = new ListCriteriaBuilder();
$gateway->getOperationPool()->getListOperation('tickets', [$params["ticket_id"], 'threads'])->get($criteriaBuilder->create())`
It's not documented but you can pass extra arguments to the operation processors

Hi @thomas-kl1,
thank you for your quick reply and support on this. I really appreciate, that you share this library and that I don't have to implement it by myself completely from scratch ;-)
I inserted your snippet in my code, but I got this fatal error:
Fatal error: Uncaught Error: Call to undefined method Zoho\Desk\Model\Operation\ListOperation::get()
But I looked into the ListOperation class and checked, that the function should be getList() instead of get().
So by using

$criteriaBuilder = new ListCriteriaBuilder();

$gateway->getOperationPool()->getListOperation('tickets', [$params["ticket_id"], 'threads'])->get($criteriaBuilder->create())

I am receiving the threads of the ticket. So working perfect now. Thank you so much!
I have one more question regarding the create action for a ticket:
In your sample code you have this snippet:
$ticketDataObject = $gateway->getDataObjectFactory()->create('tickets', /* Entity values */);

try {
    $ticketDataObject = $gateway->getOperationPool()->getCreateOperation('tickets')->create($ticketDataObject);
} catch (CouldNotSaveException $e) {
    // Handle the exception...
}

Could you give a sample of the section /* Entity values */? Is this an object, which has the same structure like the object that the get action gives back? Or is it a associative array?
Thank you very much in advance.
Best,
Christian

Hi @ca-dsgn glad it helps you and it's working! Indeed the method is getList, not get, my bad..
Regarding the data object factory, the entity values must be an associative array of key-value pair. So it's easy an convenient to create generic data objects :)
If you appreciate the SDK you can add a ⭐, it helps me to who is using it :)

Hi @thomas-kl1
Ok, great. Thank you for your quick reply on this.
I have one more question:
I just realized, that the resultList objects only contain a summary property, which has a limited number of charaters and then a "..." at the end. So it is just a short summary.
In the documentation of Zoho Desk, I saw, that there should be another field "content" beside "summary", which contains the entire value of the thread. But I couldn't find this field in the response.
https://desk.zoho.com/DeskAPIDocument#Threads
Do you have any idea how to get the entire text of the thread?

@ca-dsgn seems it's not possible to get the full content within a list. So I guess you have to fetch the list to get the IDs of the thread so you can fetch them individually.
I need to check if a hack is possible or if I need to implement a new operators for subtypes. When I designed the SDK I didn't used much subtypes such as threads so it doesn't really handle all fine. However I'm thinking of adding a new method to allows it (along the setEntityType).
I don't know yet when I can work on it, maybe tonight or Monday

@thomas-kl1 Wow, thank you so much for your great support!


Nuxt 3 - SyntaxError: Unexpected token '<', "<!DOCTYPE "... is not valid JSON

Plugin
import { defineNuxtPlugin } from '#imports';
import { Vue3Lottie } from 'vue3-lottie';

export default defineNuxtPlugin((nuxtApp) => {
  nuxtApp.vueApp.component('Vue3Lottie', Vue3Lottie);
});

Component

<script setup>
import { Vue3Lottie } from 'vue3-lottie';
</script>

<template>
  <div class="flex flex-col items-center justify-center h-screen">
    <client-only>
      <Vue3Lottie
<EMAIL_ADDRESS>        :height="200"
        :width="200"
      />
    </client-only>
  </div>
</template>

Error

SyntaxError: Unexpected token '<', "<!DOCTYPE "... is not valid JSON

Additional information
Take note that I am trying to load a local json asset. I can confirm that the json file is working properly in lottie viewer online. However trying absolute path and relative path still results to the same error.

I would try loading the json file into a ref variable inside your script tag. Also you should use animationData in this instance. animationLink is for remote URLs


setTrack and subContent Examples

I don't get how subContent and setTrack should work, every examples use subUrl or setTrackByUrl.
I tried to put an ASS content as String but no lucky.
Off
@TFSThiagoBR98 Bom ver um carioca em um projeto bacana deste.

Its simple, just put ASS content in string literal like:
window.SubtitlesOctopusOnLoad = function () {
    var options = {
        video: video,
        subContent: `
[Script Info]
Title:
ScriptType: v4.00+
WrapStyle: 0
PlayResX: 640
PlayResY: 480
ScaledBorderAndShadow: yes

[V4+ Styles]
Format: Name, Fontname, Fontsize, PrimaryColour, SecondaryColour, OutlineColour, BackColour, Bold, Italic, Underline, StrikeOut, ScaleX, ScaleY, Spacing, Angle, BorderStyle, Outline, Shadow, Alignment, MarginL, MarginR, MarginV, Encoding
Style: Default,Arial,20,&H00FFFFFF,&H000000FF,&H00000000,&H00000000,0,0,0,0,100,100,0,0,1,2,2,2,10,10,10,0
Style: Alt,Times New Roman,40,&H00FFFFFF,&H000000FF,&H00000000,&H00000000,0,0,0,0,100,100,0,0,1,2,2,8,10,10,10,0

[Events]
Format: Layer, Start, End, Style, Name, MarginL, MarginR, MarginV, Effect, Text
Dialogue: 0,0:00:00.00,0:00:05.00,Default,,0000,0000,0000,,This is a test of the ASS format and some basic features in it.
`,
            fonts: ['/JavascriptSubtitlesOctopus/fonts/Arial.ttf', '/JavascriptSubtitlesOctopus/fonts/TimesNewRoman.ttf'],
            //onReady: onReadyFunction,
            debug: true,
            workerUrl: '/JavascriptSubtitlesOctopus/assets/js/subtitles-octopus-worker.js'
        };
        window.octopusInstance = new SubtitlesOctopus(options);
    };
    if (SubtitlesOctopus) {
        SubtitlesOctopusOnLoad();
    }
});

Try the example above, if it does not work, send me an example of what you're trying to do.
Off
@ErickVal Obrigado

Thanks @TFSThiagoBR98 , I got it.
You can also get that via AJAX instead use .setTrackByUrl
var xhr=new XMLHttpRequest();  xhr.open("GET","http://xxxxxxx/subtitle.ass");  xhr.onload=function(){     window.octopusInstance.setTrack(xhr.responseText)  }  xhr.send();


The "dynamic linking" section does not lead to an implementation of lazy binding in glibc

This was discussed on the glibc mailing list.

I think this is a duplicate of #237

Yep.


Add optional TLS session resumption

This small PR fixes #198
The flag name is obviously up for bikeshedding! :wink:
I also took the liberty of adding a very small missing test, which is unrelated to the PR, but was throwing a vet error.

Quick unscientific benchmarks with a local noop TLS server:
Without TLS session resumption:
$ hey -c 300 -q 2000 -z 10s -disable-keepalive https://localhost:8443
...
Requests/sec:	1291.3949
...
DNS+dialup:	0.2116 secs, 0.0034 secs, 3.6132 secs
...

With TLS session resupmtion:
$ hey -c 300 -q 2000 -z 10s -disable-keepalive -tls-session-resume https://localhost:8443
...
Requests/sec:	4023.0482
...
DNS+dialup:	0.0595 secs, 0.0009 secs, 3.0997 secs
...

@costela Yeah, time is always the issue. Thanks for replying. Let's hope @rakyll one day comes back and do a merge :-)


delete old branches

too many branches just hangin' around.

I can delete all merged and closed branches, if that's ok. (not sure if I have the permissions though.

go for it. any un-merged branch over a couple years old should be deleted
too. the rest we can look at
On April 3, 2017 at 08:54:39, Joseph W Becher<EMAIL_ADDRESS>wrote:

I can delete all merged and closed branches, if that's ok. (not sure if I
have the permissions though.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/mochajs/mocha/issues/2353#issuecomment-291186456, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AA4bMV1aHJlilPdb6lhLepN-DA7bfCOHks5rsRY_gaJpZM4JE1FV
.

Done. What do you want done with the Greenkeeper PRs? https://github.com/mochajs/mocha/pulls?q=is%3Apr+is%3Aopen+label%3Agreenkeeper

they all seem to break the build, but everything except #2668 is a devdependency, and we should probably upgrade those if we can.  upgrading production dependencies is difficult rn

in other words, leave and/or fix and/or merge them


Add an example that uses an environment variable set in Alloy

People are asking for it...

+1 would also like to see how we can use generic envVars into the Alloy helm chart. We need to construct the postgres host string:
https://github.com/fr3fou/home/blob/23e0c81c198e26d6ef325d386a187e29eed4acd1/apps/alloy/alloy.yaml#L98

yeah, I'm having issues with this as well. exactly with the line @jark-AB linked :D
may I ask, how did you come across my repository?

Honestly, in your example, it might be better to create a Kubernetes Secret with those variables, then use remote.kubernetes.secret to discover it and then string concatenation to create the connection string.
Using environment variables is great and all, but not always ideal for passing secrets.

yeah, I'm having issues with this as well. exactly with the line @jark-AB linked :D
may I ask, how did you come across my repository?

I was grepping around on users that use the prometheus.postgres exporter since we were trying to add that to Grafana Alloy and the docs weren't too clear on how to implement that. Docs instead use a sql configMap after more researching:
https://github.com/grafana/k8s-monitoring-helm/blob/eacedb97921698849301f1eb16575b242e8069dc/.github/configs/mysql-config.yaml#L59
However, we are n servers to x set of credentials and need to loop through a server + associated secretManager. So what we ended up doing is abstract this out to prom-postgres-exporter helm chart. That will be deployed and the service scraped by Alloy


Release pipeline should retain referenced tarball pipeline run

During work on https://github.com/dotnet/arcade-services/issues/2671 we encountered an issue where the tarball pipeline run (referenced by the source-build release pipeline when working with a servicing release) was not retained and caused failures for the test / validation runs.
Unlike the dotnet-installer-official run that is retained by the staging pipeline, the tarball one is not used by staging and does not get retained.
We should retain the runs we used in a successful servicing release (for example, as the last optional step of the Release stage)

[Triage] We should investigate if there is a policy around this and adhere to the policy.  It feels like a good decision to retain the release builds.  This should be an automated process, not a manual step in the checklist.
@oleksandr-didyk - please follow-up to see if a similar issue exists for the VMR.

Received confirmation that input builds to the release should be retained at least 3 years (currently we just retain these builds forever in AzDO).
The staging pipeline has a dedicated command in the Release CLI for retaining builds, will try to re-use it and introduce the Release CLI into the source-build pipeline as part of this work.

Draft PR - https://dev.azure.com/dnceng/internal/_git/dotnet-release/pullrequest/35205

Went through initial feedback, published PR

Received a suggestion on moving the retention into a different stage, working on it

PR merged, closing as Done


gede: 2.15.1 -> 2.15.4

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/gede/versions.
meta.description for gede is: '"Graphical frontend (GUI) to GDB"'.
meta.homepage for gede is: '"http://gede.acidron.com"

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 2.15.4 with grep in /nix/store/6v99hv22bnv4j8mfdqnvankqdigd7v10-gede-2.15.4

directory tree listing: https://gist.github.com/67e7c135a75804ad7d1c2e149c766eb3

du listing: https://gist.github.com/f6ec83e918f4baeebac807c9775df17a

Rebuild report (if merged into master) (click to expand)

3 total rebuild path(s)
1 package rebuild(s)
1 x86_64-linux rebuild(s)
1 i686-linux rebuild(s)
0 x86_64-darwin rebuild(s)
1 aarch64-linux rebuild(s)
First fifty rebuilds by attrpath
gede

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/6v99hv22bnv4j8mfdqnvankqdigd7v10-gede-2.15.4 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A gede https://github.com/r-ryantm/nixpkgs/archive/658224c2c09cea8bd0c661666e1648e44ff676ad.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/6v99hv22bnv4j8mfdqnvankqdigd7v10-gede-2.15.4
ls -la /nix/store/6v99hv22bnv4j8mfdqnvankqdigd7v10-gede-2.15.4/bin

cc @juliendehos for testing.

Ok for me.


docs: Add CONTRIBUTING.md

Fixes: #43
Added CONTRIBUTING.md file
Once check it!
Thank you

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@rrousselGit
Guide me, If any changes are required in this CONTRIBUTING.md

Thanks!

@rrousselGit
Sir, is this pr counted in Invertase Rewards or It will take some time to count ?

I've labeled it accordingly. It should count

@rrousselGit
It is not showing sir

Thank you sir
Have a nice day

@rrousselGit
Sir, how can I claim the invertase rewards which got due to contribution in this #45 merged pr ??


POWERMON-235: Add support for Redfish

This PR

Extends Kepler and KeplerInternal API to add Exporter.Redfish
Redfish spec has fields for adding reference to a secret which should
contain Redfish credentials.
The user supplied secret is mounted in the kepler container.
Added Unit tests and e2e test

This PR also made a change on Kepler resource. Shall we first limit this change to only KeplerInternal?
Also, if redfish.secretRef is not set in the CR, it seems to make it not mounting since there is no default value for that.

Also, if redfish.secretRef is not set in the CR, it seems to make it not mounting

thats by design. once secretRef is set, then only -redfish-cred-file-path is added to container

@vimalk78 nice work overall. It worked pretty well in my test. But few comments to address.
The main one being that secret must be present for kepler deployment to continue and the reason for failure to deploy must be reported back in Availability status.


Access using AAD

Which version of the SDK was used?
Current version 0.6.0
Which platform are you using? (ex: Windows, Linux, Debian)
Linux
This is more of a question than an issue, I see that there is a way to authenticate azure storage with AAD in this .Net example. I couldn't find any examples in go code to support something like this. Is this supported. Can you please confirm if this is supported?
We have an active issue rclone#3213, AAD authentication feature with storage would help unblocking this.

Hi @sandeepkru, yes, token credential is supported.
I'll add samples soon. In the mean time, please refer to this project.

Thank you!

Where is the sample? @zezha-msft


Turn on recovery as collisions only for floor snapping

fix #64726
This feature was added to improve floor detection but it lead to unexpected behaviour with other surface than floor (see issue).

Thanks!

This caused the CharacterBody3D to jitter on some floor surfaces in Beta 2


AndroidX support or use Essentials? :)

Can not resolve reference: Xamarin.Android.Support.Compat, referenced by Plugin.Permissions.

You should be able to use the https://www.nuget.org/packages/Xamarin.AndroidX.Migration/ package and you should be fine.

Would recommend migrating to Essentials though as that is my main focus with the team.

https://github.com/jamesmontemagno/PermissionsPlugin/pull/170


fix(avm): address bytecode hashing comments

Please read contributing guidelines and remove this line.

I'd change or comment the line mentioned here
https://github.com/AztecProtocol/aztec-packages/pull/8897#discussion_r1816845756


Mob Programming: Change Roles regularly.

We want to introduce a timekeeper role that is assigned to one of the Navigators maybe.
Tasks of the timekeeper:
Ensure there are at least two people that are going to be assigned the Driver role during a Mob Programming Session.
This must be ensured before the session starts.


fix: package specification of main output files fixed

:tada: This PR is included in version 1.0.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Rename a few attributes

Companion PRs:

https://github.com/SubstraFoundation/substra-backend/pull/345
https://github.com/SubstraFoundation/substra-chaincode/pull/129
https://github.com/SubstraFoundation/substra/pull/241

Rename:

Before
After

compute_plan_id
compute_plan_key (or simply key)

hash
checksum

data_manager.keys
data_manager.data_sample_keys

The travis-ci tests won't pass until the substra PR is merged.


(feat) Improved the Injective Delegation Script

Before submitting this PR, please make sure:

[x] Your code builds clean without any errors or warnings
[x] You are using approved title ("feat/", "fix/", "docs/", "refactor/")

A description of the changes proposed in the pull request:
With this change, you can use the delegation script without any modifications as it uses argparse to supply the parameters.
In addition to argparse, the script now also takes both a private key and seed phrase, without showing it on screen (no echo). This improves security (when someone is looking over your shoulder).
Also, deprecated functions have been replaced by up-to-date PyInjective functions. We might have to update the dependency in the docker container, though. I will make a separate PR for this.
Current usage:
usage: account_delegation_script.py [-h] [--network NETWORK] --grantee_address GRANTEE_ADDRESS [--granter_subaccount_index GRANTER_SUBACCOUNT_INDEX] [--grant_expiration_days GRANT_EXPIRATION_DAYS] [--spot_market_ids SPOT_MARKET_IDS]
                                    [--derivative_market_ids DERIVATIVE_MARKET_IDS]

Delegate Injective funds for trading.

options:
  -h, --help            show this help message and exit
  --network NETWORK
  --grantee_address GRANTEE_ADDRESS
  --granter_subaccount_index GRANTER_SUBACCOUNT_INDEX
  --grant_expiration_days GRANT_EXPIRATION_DAYS
                        Expiration of the grant (in days) (default: 365)
  --spot_market_ids SPOT_MARKET_IDS
                        Comma-separated list of spot market IDs to accept (see: mainnet: https://lcd.injective.network/injective/exchange/v1beta1/spot/markets testnet:
                        https://k8s.testnet.lcd.injective.network/injective/exchange/v1beta1/spot/markets) (default: None)
  --derivative_market_ids DERIVATIVE_MARKET_IDS
                        Comma-separated list of derivative market IDs to accept (see: mainnet: https://lcd.injective.network/injective/exchange/v1beta1/derivative/markets testnet:
                        https://k8s.testnet.lcd.injective.network/injective/exchange/v1beta1/derivative/markets) (default: None)

Tests performed by the developer:
Tested the script with my test trading account (Call was python hummingbot/connector/exchange/injective_v2/account_delegation_script.py --grantee_address inj1wdgalm0ygdcs4235gw7gqcwzsflpvaqfdq82tj --derivative_market_ids=0x18b2ca44b3d20a3b87c87d3765669b09b73b5e900693896c08394c70e79ab1e7 --grant_expiration_days 1): https://www.mintscan.io/injective/tx/9D310898642A5270FF969FC537180FD95E41FD60F391AA9A91B8632C5F890773
Tips for QA testing:

hi @peterwilli , thank you for submitting PR, fyi, it should be aimed to development, I changed it for now https://hummingbot.org/developers/contributions/#checklist

hi @peterwilli , thank you for submitting PR, fyi, it should be aimed to development, I changed it for now https://hummingbot.org/developers/contributions/#checklist

Yeah I saw, sorry I missed that

@cardosofede @fengtality


Add more CircleCI builds

Add more CircleCI builds:

gcc
gcc-8
clang
mingw-w64

Previously, there was only a gcc build.

Linux only change.


Support semantic versioning in Rancher catalog/API

Teams A, B, and C are working together.
C isn't working on a new release right now but A and B are.
As an engineer in team A I'd like to spin up in my environment the latest stacks in the catalog from my team A and my partner team B but I want to lock onto the major.minor.* semantic version matching the production version of team C and not their latest work that may be unstable and I don't need to deal with that as my new code doesn't interact with it.
So I ask for version 5.7.* from the catalog of team C's service. There's a 5.8 series and an older <IP_ADDRESS> but I am given the proper latest version for the semver expression I have specified which is <IP_ADDRESS> for example.

There is no way in our catalog-service today to ask for a specific version and return the relevant versions, but we've added some features in regards to versioning/upgrading.

Instead of showing templates by folder number, we are now displaying by version number. In this case, if you were on 5.7.30 and in your folders, there was a 5.7.20 and 5.7.35 and 5.8.0, then only 5.7.35 and 5.8.0 would show up as ability to upgrade. The "older versions" wouldn't show up even if they were in later folder numbers.

https://github.com/rancher/rancher/issues/5691

The other concept that we've added is "upgradeFrom" field, where you would be able to specify which versions this specific template could be upgraded from. Note: Upgrade from still hasn't been added in rancher-compose so it's not quite working yet.

https://github.com/rancher/rancher-catalog-service/pull/70
Between these 2 enhancements, I think you could achieve what you are looking for. Let me know what you think.

@alecl If the new fields that I laid out in 1.2.0 don't achieve what you are looking for, then please reopen.


⚠ Jerry Savelle Ministries International Australia has degraded performance

In 7d8c788, Jerry Savelle Ministries International Australia (https://jsmiaustralia.org) experienced degraded performance:

HTTP code: 200
Response time: 7995 ms

Resolved: Jerry Savelle Ministries International Australia performance has improved in 97d9d2e after 36 minutes.


Update GPT model to GPT-4o

Related to #67
Updates the AI model used in the code review process to GPT-4o.

Model Configuration: Changes the default AI model in action.yml to "gpt-4o".
Workflow Adjustment: Modifies .github/workflows/code_review.yml to use "gpt-4o" for the OpenAI API model during code reviews.

For more details, open the Copilot Workspace session.

Please note that this PR was created by GitHub Copilot Workspace using #67 as its task

@villesau looks better now? 😄

Please @villesau  review this soon, this will have a huge impact on pricing
gpt-4o Input $5.00 / 1M tokens Output $15.00 / 1M tokens
so half the price compared to GPT-4 Turbo.


[FEATURE] Generate types also for projections

Description
This request is related to my previous question https://github.com/cap-js/cds-typer/issues/121, in which I requested to generate types not only for 'base' entities, but also for views.
Now, I noticed that types are still not generated for projections, like e.g. (see file Payments.cds)
@readonly
@plural: 'TotalBalancesPerAccount'
entity TotalBalancePerAccount    as
    projection on WalletAssetTotals {
        key accountId,
            coalesce(
                sum(total), 0
            ) as total : Decimal,
    }
    group by
        accountId;

Suggested Solution
Please take care also of projections.
Alternatives
No response
Additional Context
No response

It would be good to have this. As a workaround for now, I add the projected properties as virtual properties to my entity. But if this virtual property is not a primitive type (but e.g. an association to an entity) this can't be marked as 'virtual' anymore so you'll end up with a whole bunch or null columns in your database. So the workaround still works, but it gets 'messy'.

Is this issue different from https://github.com/cap-js/cds-typer/issues/81?

I think, it is the same issue as https://github.com/cap-js/cds-typer/issues/81

Thanks for reporting back on this, let's close this as a duplicate then. This issue should still stay referenced in #81.

Hi Daniel,
yes, it looks good. :-)
Best regards,
Michael


Better handling of setting EE nodata masked value to NaNs values.

Fixed #86.
In the existing code, we're comparing data from Earth Engine, which arrives as floating-point numbers with 7-digit precision, to a masked value that's accurate to 9 digits. This discrepancy prevents a direct match. To address this, I introduced np.isclose(), which can match masked value with earth-engine data despite this precision difference.
Let's take an example:
import numpy as np
data = [(9999.,), (9999.01,), (9999.1,)]
Previous_Result = np.where( data == 9999, np.nan, data)
Current_Result = np.where( np.isclose(data, 9999), np.nan, data)
print(Previous_Result, Current_Result)

Output:
Previous_Result : [[9999.  ] [9999.01] [9999.1 ]]
Current_Result : [[nan] [nan] [9999.1]]

So np.isclose is match the value when their difference  is less than 0.1.
Official documentation link: https://numpy.org/doc/stable/reference/generated/numpy.isclose.html#numpy-isclose.

I added a comment change to the PR. LGTM!


[bb install issue] Library not loaded

I followed the installation steps from : https://github.com/AztecProtocol/aztec-packages/tree/master/barretenberg/cpp/src/barretenberg/bb#installation
but when I tried bb --version, I got the this error:
dyld[19062]: Library not loaded<EMAIL_ADDRESS>  Referenced from: <E1BF9892-14A9-31C8-960D-778F1B0864D3> /Users/USER_NAME/.bb/bb
  Reason: tried<EMAIL_ADDRESS>(no such file<EMAIL_ADDRESS>(no such file<EMAIL_ADDRESS>(no such file)
[1]    19062 abort      bb --version

I found a person who had the same issue ( https://github.com/AztecProtocol/aztec-packages/issues/8368 ) and I reinstalled LLVM as he did but no luck for me.
Here is my env:
nargo version = 0.33.0
noirc version = 0.33.0+325dac54efb6f99201de9fdeb0a507d45189607d
node = v18.17.0
MacOS

Does anyone know how to solve this issue?

Can you try installing bbup via the instructions here.
We need to update the README where you got those instructions from. cc @signorecello

Even installing with bbup can lead to this error. Since it's a dynamic linking error, it means you need to already have a library on your mac, otherwise the bb executable won't be able to run.
2 solutions, either:

install llvm@16 using homebrew. This will put the expected library in the place where it's looking
tell the executable where to find the libunwind library:

make sure you can find the libunwind.1.dylib file as part of your llvm installation (llvm versions >12 should have it in a folder called lib/)
patch the executable using install_name_tool (it's built in macos, nothing to install): this link explains how.


Story Auto Analytics Documentation

Task Description

As per #7739, we need to write some documentation on amp-story-auto-analytics and what the data migration means for the user.

@choumx Note that this is the last blocker before we can enable this new feature by default, which we need to do before bug bash tomorrow. Otherwise we risk punting this from this release.

Fixed by #9200


Support for env var $ONLY

Users should be able to:
docker-compose run crossdock -e ONLY=thisbehavior,thatbehavior

Where if ONLY is set, we run only the behaviors specified.

Oh, neat. We can also trim axes without any special headers.

Yeah, at the moment the easiest way is to comment out the other behaviors.


Default language at the root with other content inlanguage subfolders.

I have the following Hugo generated site structure: /en/* for English, /pl/ for Polish.
I would like to have English as default language, Polish as translated content, and keep the default language at the root "/" without redirecting the root site to the subfolder. Since the urls are gnerated based on language and folders, they will be still valid.
Can we keep the default language at the root of the domain?

Please use https://discuss.gohugo.io/ for questions.


[Feature]: CF apps can access external CF routes from VCAP_APPLICATION

Blockers/Dependencies
No response
Background
An application shall be able to read external URLs, since that is an important feature from the classic CF.
That is normally accessible via env var VCAP_APPLICATION
VCAPP_APPLICATION.application_uris = [URL1, URL2, ....]
where URL1, URL2 are CF Routes.
The same for VCAP_APPLICATION.uris
That is VERY important feature!
The app could construct URLS for itself (self-link) and give it to the end user, so he/she could click and use a specific link for that application.
That link could be transferred to another third party like email, message etc, so that it could be used outside the browser context.
Acceptance Criteria
In the application runtime, the following expressions gives a valid array of URL strings
VCAP_APPLICATION.application_uris
VCAP_APPLICATION.uris
Dev Notes
No response

Commit ae55aad070fcd36336888c54a0a0078c9d4cbf14 introduces this feature.


Fix bug in MySQL connection pooling

If someone asks for a connection and the pool of existing connections has more than a single item, all but the first will be lost.  This eventually leads to a hang where the pool of connections is empty, but the caching logic thinks the pool is full and won't create a new connection.
This is easy to run into if you have a bunch of render threads on a fast machine.  Any rendering operations will hang, the web interface will become unresponsive, and shutting down the server will produce a bunch of errors similar to:
[pool-6-thread-3/ERROR]: [dynmap] Tile read error - Interruped

UGH!   Good catch, and thanks for the fix!!


Could not find the requested service "firewall"

On macOS Sierra, running VirtualBox 5.1.8 and Vagrant 1.8.6, with Ansible 2.2.0, a fresh Drupal VM provision is bailing with:
TASK [geerlingguy.firewall : Ensure the firewall is enabled and will start on boot.] ***
fatal: [drupalvm]: FAILED! => {"changed": false, "failed": true, "msg": "Could not find the requested service \"'firewall'\": "}

RUNNING HANDLER [geerlingguy.firewall : restart firewall] **********************

PLAY RECAP *********************************************************************
drupalvm                   : ok=10   changed=6    unreachable=0    failed=1

This looks like it could be related to #829, but I'm doing a little more investigation. For now, the simplest fix is to stay on Ansible 2.1.x (e.g. pip install ansible==2.1) instead of installing Ansible 2.2.x... something's changed with Ansible's service module that must be causing this issue.
On Windows, the issue can be caused by non-UNIX line endings on the firewall service file (see #829 comments), but on Mac/Linux (and on Windows in general), it looks like Ansible 2.2's service module gets snagged, but only on Ubuntu 16.04, which leads me to believe something is missing for systemd.
Temporary Fixes

Switch back to Ansible 2.1.x (e.g. pip install ansible==2.1)
If you see this error, run vagrant reload --provision to restart the VM and continue provisioning)

See also: https://github.com/geerlingguy/ansible-role-firewall/issues/17

Ha... then since the firewall is set up but not configured properly... it looks like SSH is being blocked, so fix #2 might not work that great. Or it could be an issue with my latest iteration of the geerlingguy/ubuntu1604 box, or with Vagrant 1.8.6. Or VMware 8.5. Grr.

Getting same error. :( Tried destorying box, copying from working config, etc, no luck.
`TASK [geerlingguy.firewall : Ensure the firewall is enabled and will start on boot.] ***
fatal: [clbs]: FAILED! => {"changed": false, "failed": true, "msg": "Could not find the requested service "'firewall'": "}
RUNNING HANDLER [geerlingguy.firewall : restart firewall] **********************
to retry, use: --limit @/vagrant/provisioning/playbook.retry
PLAY RECAP *********************************************************************
clbs                       : ok=10   changed=5    unreachable=0    failed=1
`

After using vagrant reload --provision - I'm getting..
TASK [geerlingguy.postgresql : Ensure PostgreSQL packages are installed.] ******
fatal: [clbs]: FAILED! => {"failed": true, "msg": "'postgresql_packages' is undefined"}
	to retry, use: --limit @/vagrant/provisioning/playbook.retry

PLAY RECAP *********************************************************************
clbs                       : ok=106  changed=3    unreachable=0    failed=1

@enapthine - I opened https://github.com/geerlingguy/ansible-role-postgresql/issues/7 for that issue—it seems I might need to adjust a few things in a few different roles for Ansible 2.2+ compatibility.

I have a fix for this in the geerlingguy.firewall role. Will continue testing.

See upstream issue: https://github.com/geerlingguy/ansible-role-firewall/pull/22

Heh... now that I fixed the firewall issue, I hit the same thing with the mailhog role:
TASK [geerlingguy.mailhog : Ensure mailhog is enabled and will start on boot.] *
fatal: [drupalvm]: FAILED! => {"changed": false, "failed": true, "msg": "Could not find the requested service \"'mailhog'\": "}

Will open another upstream role.

And now that I fixed mailhog, I'm getting:
TASK [geerlingguy.java : Ensure Java is installed.] ****************************
fatal: [drupalvm]: FAILED! => {"failed": true, "msg": "'java_packages' is undefined"}

Ansible 2.2 is like a hydra for all my roles with custom init scripts :P

Issue for Java role: https://github.com/geerlingguy/ansible-role-java/issues/26


test result all zeros?

I trained pv-rcnn with custom data(only 3d point cloud data), the detection performance is fine when visualizing with one sample. But when I run python test.py, the log info is always zero. How to solve this? do I need to change the code?

I think maybe its because test set doesn't have labels.

I think maybe its because test set doesn't have labels.

I have the same issue, did you solve it ?


chore(header Authorization): Avoid duplicate "Bearer" keyword

If api_key contains Bearer keyword, remove it to avoid duplicate addition.

[ ] I understand that this repository is auto-generated and my pull request may not be merged

Changes being requested
Additional context & links

Unclear title

Thanks for the PR but we don't want to mess with API key values.


Performance tests

Subtask of https://github.com/omgnetwork/childchain/issues/59 and https://github.com/omgnetwork/childchain/issues/141
LoadTest.Runner.WatcherInfoAccountApi
Current behaviour
It creates and funds a single account on the childchain and then measures API responses multiple times for:

/account.get_balance
/account.get_utxos
/account.get_transactions
/transaction.create - the funded account sends the value back to the faucet account

No assertions are made during this test
Suggested behaviour
Split this test into two separate tests:

Run multiple iterations of:

create account
send some amount to the created account on the childchain
validate amount with /account.get_balance
validate that the account has the required utxos with  /account.get_utxos

Run multiple iterations of

create and fund account
send some amount from created account to another account with /transaction.create
validate created transaction with /transaction.create

LoadTest.Runner.UtxosLoad
Current behaviour
It has two scenarios:

Funds the account and creates multiple utxos
Sends utxos to another account

Suggested behaviour
It can be separated into two tests:

The first test will create multiple utxos for different accounts validating it with /account.get_utxos
The second test will spend utxos validating balances.

As you can see in this case I'm suggesting only to add assertions.
LoadTest.Runner.StandardExits
Current behaviour

Create many utxos
Start exits for the created utxos

Suggested behaviour

Create many utxos validating that utxos are created
Start exits validating balances on the rootchain

LoadTest.Runner.Smoke
Current behaviour

checks status api endpoints for childchain, watcher_info and watcher

Expected behaviour
I don't think it has to be ported (I don't think it's needed)
LoadTest.Runner.ChildChainTransactions
Current behaviour

funds the account
spends utxos

Expected behaviour
It seems this test is already part of LoadTest.Runner.UtxosLoad.
For now, I won't delete existing tests, I will just create new ones that can be run from the command line using mix run. You can check an example of such test in https://github.com/omgnetwork/elixir-omg/pull/1745

Done, thanks @ayrat555


Browser Extension

As much as it would be unnecessary, it would be extremely convenient if there were a browser extension, so that you could go to the factorio mod portal & use the extension to tell ModMyFactory to download the mod of the page you're on. Again, unnecessary, but it could very well streamline mod downloading. Thanks for your time.

I have no experience with development of browser add-ons. If someone wants to go ahead and take on this takes, by all means please proceed, I'd be more than happy to do the work on the software side. But I alone will not be able to make this happen.


Possible units error in getVerticalMassFlux

I have been comparing the estimated vertical mass fluxes generated by FV3 with those coming from the older FV code embedded in GEOS-Chem, and have found significant disagreement. However, I am wondering if this is because of a units issue and would appreciate any insights that the developers might have.
Specifically, in FV_StateMod, the vertical mass flux mfzxyz is calculated by calling fv_getVerticalMassFlux with mfxxyz and mfyxyz as inputs:
https://github.com/GEOS-ESM/FVdycoreCubed_GridComp/blob/b331e2ae0339bde84d63eacd911c36befe74d735/DynCore_GridCompMod.F90#L4347
Immediately beforehand, mfxxyz and mfyxyz are used to fill the MX and MY exports, which are stated to be in Pa m+2 s-1:
https://github.com/GEOS-ESM/FVdycoreCubed_GridComp/blob/b331e2ae0339bde84d63eacd911c36befe74d735/DynCore_GridCompMod.F90#L998
Similarly, mfxxyz is used immediately after the call to fv_getVerticalMassFlux to fill the export MFZ, which has declared units of kg m-2 s-1:
https://github.com/GEOS-ESM/FVdycoreCubed_GridComp/blob/b331e2ae0339bde84d63eacd911c36befe74d735/DynCore_GridCompMod.F90#L1032
However, as far as I can tell, the operations in fv_getVerticalMassFlux will not convert a quantity with units Pa m+2 s-1 to a quantity with units kg m-2 s-1.  Briefly, it appears that the routine in question first calculates conv, which must have units of Pa m+2 s-1 multiplied by the units of fac (noting that xfx = mfx):
https://github.com/GEOS-ESM/FVdycoreCubed_GridComp/blob/b331e2ae0339bde84d63eacd911c36befe74d735/FV_StateMod.F90#L3178-L3179
fac is equal to 1.0/(dt*MAPL_GRAV), and must therefore have units of s-1 * s+2 * m-1 = s+1 m-1:
https://github.com/GEOS-ESM/FVdycoreCubed_GridComp/blob/b331e2ae0339bde84d63eacd911c36befe74d735/FV_StateMod.F90#L3170
That implies that conv has units of Pa m+2 s-1 * s+1 m-1 = Pa m. The only remaining operation in fv_getVerticalMassFlux which should affect the units of the answer are on line 3204, when mfz is calculated. Here, b(k) * pit is subtract from conv, and then the result divided by MAPL_GRAV*area:
https://github.com/GEOS-ESM/FVdycoreCubed_GridComp/blob/b331e2ae0339bde84d63eacd911c36befe74d735/FV_StateMod.F90#L3204
pit is just an accumulation of conv so should have the same units, which I believe are still Pa m. Dividing by MAPL_GRAV*area should then have the effect of changing the units to Pa m * s+2 m-1 * m-2 = Pa s+2 m-2. Converting from pressure to mass still gives Pa = N m-2 = kg m s-2 m-2 = kg s-2 m-1, which means the eventual units end up being kg m-3. That would imply that a factor with units equal to velocity is missing from the calculation.
I haven't been able to find a fundamental error in my calculation, but may well be missing something obvious. Nonetheless, I would appreciate any insight that anyone can provide. My suspicion (but it is that at most) is that the application of fac is incorrect - removing that factor at least causes the units to work out correctly. It also makes logical sense, since inclusion of fac results in a duplicate division by MAPL_GRAV, and incurs a division by dt when the units of mfx are already meant to be a tendency. Alternatively, it may be that the units of mfx and mfy are incorrectly listed; but again, any information anyone can provide would be very welcome!

I'm going to assign @wmputman and hope he sees this. It's beyond me!

Yes - ultimately this is an issue that only @wmputman can answer.    If we don't hear back in a timely manner, we can at least have someone repeat this analysis as a check.

@tclune - think that @wmputman is not able to look at this - any thoughts on next steps?

This was taken long ago from the old LatLon core. This code is indeed wrong.  You just need to remove the fac in the calculation of conv.

@wmputman Queries:

Does this affect GEOS or is this in a code path we don't use?
Do you have a possible fix for the code? Or I guess @sdeastham could propose one.

Thanks @wmputman for the review and fix! @lizziel - suggest we cherry pick at least this update into the GCHP fork, since it is trivial but will make the diagnostic much more useful?


bug: wagmi cli "actions" plugin doesn't respect overridePackageName

Is there an existing issue for this?

[X] I have searched the existing issues

Package Version
@wagmi/core - 0.10.2
@wagmi/cli - 0.1.13
Current Behavior
The generated file from yarn wagmi generate will import everything from wagmi/actions
Expected Behavior
Imports should come from @wagmi/core
Steps To Reproduce
Install @wagmi/core ethers@^5 @wagmi/cli
Use the following config:
import { defineConfig } from '@wagmi/cli'
import { actions, erc } from '@wagmi/cli/plugins'

export default defineConfig({
  out: 'src/generated.ts',
  contracts: [],
  plugins: [
    erc({
      721: true
    }),
    actions({
      overridePackageName: '@wagmi/core'
    })
  ],
})

Run wagmi generate
Link to Minimal Reproducible Example (StackBlitz, CodeSandbox, GitHub repo etc.)
No response
Anything else?

Thanks for reporting! This should take care of that: https://github.com/wagmi-dev/wagmi/pull/2039

Thanks for the quick fix 👍


Old designer and new Designer code is not in sync

Describe the Bug
After deploying using Azure Devops old designer and new designer code view is not in sync. Also in designer code view if we change anything that is not reflecting in the flow.
Steps to Reproduce the Bug or Issue

go to code view of new designer
change any thing in json
try new transaction

Workflow JSON
No response
Expected behavior
As a user I expected after the changes in code view of new designer should reflect in workflow
Screenshots or Videos
No response
Platform And Browser

OS:  Windows
Browser: Chrome
Version: 107.0.5304

Additional context
No response
AB#16410875

Hey @GOURAVBISWAS , this is working as intended. The code view you open in the side panel is meant to be a snapshot of the workflow at that point. Keeping them in sync would take a ton of resources in any sizable workflow. I do think we can do more to communicate this though, code view for instance should probably be read only.


No IPAM documentation

I can't find any documentation that describes Calico's IPAM behavior and how it interacts with pools.  This would be useful info for Calico users to have.

@caseydavenport Casey - are you after beefing up our API docs in libcalico (i.e. someone writing to use libcalico), or adding some docs in calico-containers to indicate how our IPAM module assigned IPs from pools etc.  The latter is somewhat dependent on orchestrator though because it might be possible to specify which pool you choose from based on the environment.

@robbrockbank - My original intent here was to document how our IPAM module assigns blocks and pools.  I believe I raised this after answering a number of different questions about how Calico assigns IP addresses on Slack.
Maybe this is something that needs to be documented per-orchestrator.

Assigning to Turk since he's going to be looking into our docs in the near future.
@djosborne I think the requirement here is a doc that explains the philosophy behind Calico's IPAM behavior, why one would use it, and what it does.

This issue was moved to projectcalico/calico#63


🐛 BUG: wrangler dev --local occasionally emits 'Waiting for connection...' continuously

What version of Wrangler are you using?
2.0.9
What operating system are you using?
Windows 10
Describe the Bug
When I run wrangler dev --local in Powershell or cmd, sometimes it'll just emit 'Waiting for connection...' continuously until I force close via Ctrl+C.  Other times it works fine.
e.g.
 ⛅ wrangler 2.0.8
-------------------
⎔ Starting a local server...
Waiting for connection...
Waiting for connection...
Waiting for connection...
Waiting for connection...
(line above repeats forever)

https://github.com/cloudflare/wrangler2/blob/main/packages/wrangler/src/inspect.ts#L290
I've logged the websocket URL being used for the connection in the function above and when the issue occurs it appears the URL is a partial one (e.g. ws://<IP_ADDRESS>:9229/91fedb) instead of the full URL returned by node --inspect (e.g. ws://<IP_ADDRESS>:9229/91fedbcf-52c1-421c-9228-146631a3717b).  Opening a websocket with the partial URL causes the "unexpected-response" event to fire (due to the server returning 400 Bad Request) which then results in an endless loop as the connection is retried (see retryRemoteWebSocketConnection).
The source of the websocket URL appears to be parsed in:
https://github.com/cloudflare/wrangler2/blob/main/packages/wrangler/src/dev/local.tsx#L255
On my machine this handler typically receives data in two chunks (i.e. the event fires twice).  If a chunk contains a partial URL then the regex matches and setInspectorUrl is called with the invalid partial URL (which causes the issue).  If none of the chunks match the regex then setInspectorUrl is never called and the issue doesn't occur.
I've managed to fix this locally by accumulating the chunks and then testing the accumulated data with a modified regex that requires a 36 character UUID in the URL for a match.
Hope this helps / I'll open a PR with a fix shortly.

Awesome stuff @timabb031


[Card] cards and card groups are 1px too far to the left

Steps
Please see screenshot. I noticed this with semantic-ui-react originally, but it is also visible on the main page - notice in the docs that the Message boxes are the Cards are 1px off in the same fashion. https://semantic-ui.com/views/card.html

Expected Result
Components should look aligned when they're stacked.
Actual Result
Cards are 1px to the left of (some? all? I only checked a couple) other components
Version
2.2.14 (but see the link above - it's still true in latest)

I have made a JSFiddle as a test case to easily show this https://jsfiddle.net/1jgnog5k/


Add adverts to test3 help page

@Vino-S to implement

@Vino-S please note that there should be a DRAFT Help page which has the latest updates — it has disappeared!
I will attempt to restore the DRAFT and will let you know when Help is ready for the advert block. Thanks!

@Vino-S I've restored the Help page with the most recent updates. It is ready for you to create a draft version and add the advert block.
The page layout is a bit different from the usual, mainly to show one of the images at full width. Depending on where you put the advert, the page layout might need some tweaking — do let me know if you need help with that.


Add Template Name to Hover Tool Tip

You're in luck! This is an easy one to adjust!
You'll want to change the text value of the cell's "title" element. This can be found in the app.js file's treemap function.
So far, there isn't a ton of properties on the d.data object worth showing there, but you have access to any property in the myEventFrame object under the d.data.ef property.
Let me know if you need any help 😄

(not expecting this before you're back in town, btw)


Update all sgx crate dependencies to 0.6.0

Motivation

Future Work

Current dependencies on/for this PR:

main

PR #76   👈

This comment was auto-generated by Graphite.


helm delete is not honoring --timeout, it exists even before that

Output of helm version:v3.0.0
Output of kubectl version:v15.0.0
Cloud Provider/Platform (AKS, GKE, Minikube etc.): eks

@damodhar22 Can you add details on the issue in he description field?
Example:
Create pods with the below command

helm install myrelease mychart --wait --timeout 10m0s
helm delete myrelease --timeout 10m0s
the expectation is that delete command will exit after all the resources are deleted or after the timeout is up.
But the actual behavior is  delete command exits even before the timeout is up
and I can still query for the pods which are terminating state.
Why is delete command does not respect --timeout value?

@damodhar22 Can you add details on the issue in he decsripotion field?

I don't know if @damodhar22 was referring to this. I interpret this as allowing helm delete to accept a --wait option as helm install does, and in that case really wait (up to the limit established by --timeout for the resources (Pods, ....) to disappear

I don't know if @damodhar22 was referring to this. I interpret this as allowing helm delete to accept a --wait option as helm install does, and in that case really wait (up to the limit established by --timeout for the resources (Pods, ....) to disappear

@jpc4242 Yes, you interpreted it correctly. This is exactly what I was referring.

The problem I see in order to implement this is that the pods that you are seeing in terminating state may not even directly appear inside the helm chart. Probably your helm chart has e.g. a deployment or statefulset and this is what makes the Pods appear.
So for helm to "wait until all resources disappear" means that helm needs to know perfectly this list of resources, and IIRC as of today helmv3 doesn't do that and thats why you no longer receive in helm status the list of resources that you got in helmv2
For "correctly written" charts, you should expect the
-l app.kubernetes.io/instance=<releasename> selector to give you that list, or if not, at least the -l release=<releasename>. But this depends on the helm chart author doing things "correctly" so I am not sure if the helm command should rely on that.

I'm confused - helm 3 already knows exactly what resources are involved in a deployment, as can be seen when using --debug (it lists exactly what it's terminating). So what's preventing helm from waiting until those resources which it knows about are fully deleted, not just terminating?
This causes us major headaches when working with PVCs, as if someone deletes their environment then rapidly recreates it, the PVC is not finished terminating, but helm seems to think that's fine and proceeds with the recreation, then gets confused when the PVC vanishes from under it (as the termination is now complete).

Ping!  Can we please add --wait flag to helm uninstall?

Yes - see https://github.com/helm/helm/issues/2378#issuecomment-676530173.

#2378 became stale..


please do not use golang.org/x/sys

Because of China GFW, it's very hard to go get anithing from golang.org/x/ .
So it's so hard for us who are in China to use logrus if import  golang.org/x/sys.
Old version without golang.org/x/sys works so ok, why need golang.org/x/sys?
We now have to use old version of logrus. So sad.

Going back to syslog means we wouldn't be able to get updates of the package, as it's deprecated.
Also, as much as I like china, I don't think technical decisions should be based on a single country's restrictions.
https://golang.org/pkg/syscall/

NOTE: This package is locked down. Code outside the standard Go repository should be migrated to use the corresponding package in the golang.org/x/sys repository. That is also where updates required by new systems or versions should be applied. See https://golang.org/s/go1.4-syscall for more information.

Yes, I see the reason now. Thanks for answering.


Remove (or skip forward) silent parts of the downloaded video

DO NOT REMOVE OR SKIP THE ISSUE TEMPLATE

[X] I understand that I will be blocked if I intentionally remove or skip any mandatory* field

Checklist

[X] I'm requesting a feature unrelated to a specific site
[X] I've looked through the README
[X] I've verified that I have updated yt-dlp to nightly or master (update instructions)
[X] I've searched known issues and the bugtracker for similar issues including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue

Provide a description that is worded well enough to be understood
It would be interesting for users to have an option to cut silent parts of the downloaded video.
The main use cases are lectures and tech talks, where silent parts are frequent.
There are existing libraries like unsilence, or the jumpcutter tool that we could take inspiration from:

https://github.com/lagmoellertim/unsilence/
https://pypi.org/project/unsilence/
https://github.com/carykh/jumpcutter

Skipping forward would also be reasonable.
I was thinking of some options :

--silence-skip SECONDS with SECONDS being the threshold for creating a cut.
--silence-forward SECONDS with SECONDS being the threshold for creating a cut.
--silence-forward-speed SPEED with SPEED being the speed multiplier (x2, x3, etc).

More options could be useful too (like silence threshold in term of volume, etc).
Examples options available in the jumpcutter tool : https://github.com/carykh/jumpcutter/blob/master/jumpcutter.py#L55
I would completely understand if there's no willingness to include the functionality directly into yt-dlp.
After all, using --exec and a python script could work, but it's a lot less convenient for normal users.
Thanks for taking the time to read the request.
Provide verbose output that clearly demonstrates the problem

[ ] Run your yt-dlp command with -vU flag added (yt-dlp -vU <your command line>)
[ ] If using API, add 'verbose': True to YoutubeDL params instead
[ ] Copy the WHOLE output (starting with [debug] Command-line config) and insert it below

Complete Verbose Output
N/A -- feature request

You can already remove by timestamps using --remove-sections *START-END. Silence-detection is out of scope and would be better of as a postprocessor plugin


Release 23.3

Spring 2024 release
Milestone: Spring'24
Version: 23.3
Features

#2045
#2048
#2050
#2052
#1592
#2058
#1312
#1673
#1843
#2067
#2074
#2079
#2003
#2086

Optional

#2073

TODO

[ ] Release Notes
[ ] Release Artifacts


Fourier transform example?

I would love an example of using the Fourier transform utilities on one of the sample wav files. In fact, there are several algorithms here that could use a usage demonstration.

Yes, these would be nice. However I won't be working on these soon. I'd review a PR though.


improvement make timeout mutable on executing fragment rpc

Proposed changes
remote_fragment_exec_timeout_ms is a mutable config. When we increase the timeout by admin set frontend config, it still has the 10 second limit on rpc.
This PR makes timeout mutable on execution fragment rpc.

run buildall

run buildall

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 49.1 seconds
stream load tsv:          529 seconds loaded<PHONE_NUMBER>9 Bytes, about 134 MB/s
stream load json:         20 seconds loaded<PHONE_NUMBER> Bytes, about 112 MB/s
stream load orc:          64 seconds loaded<PHONE_NUMBER> Bytes, about 16 MB/s
stream load parquet:          31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select:          29.5 seconds inserted 10000000 Rows, about 338K ops/s
storage size:<PHONE_NUMBER>2 Bytes

run buildall

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 49.76 seconds
stream load tsv:          532 seconds loaded<PHONE_NUMBER>9 Bytes, about 134 MB/s
stream load json:         20 seconds loaded<PHONE_NUMBER> Bytes, about 112 MB/s
stream load orc:          64 seconds loaded<PHONE_NUMBER> Bytes, about 16 MB/s
stream load parquet:          31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select:          29.1 seconds inserted 10000000 Rows, about 343K ops/s
storage size:<PHONE_NUMBER>5 Bytes

Some workflows are not running, should I do something to push the process?
cc @dataroaring @hello-stephen , thx.


Add auv_msgs

From the Travis log:

Repository 'auv_msgs' with url 'https://github.com/oceansystemslab/auv_msgs' should end with .git but does not.

Apologies. It should work now.


output capture stats

build in an optional capture stats output stream.  something that works with statsd.

we'll use gopassivedns... as our namespace pattern, where thread is optional.
Metrics to log will be:
number of lookups (Increment)
size of connection cache tables (Gauge)
number of flushed connection table entries (Increment)
size of packet queue (Gauge)
size of tcp queue (Gauge)
size of log queue (Gauge)


Benchmark result

First of all, I really appreciate your excellent work!
We've been thinking building a similar screenshot service after Chrome Headless come out, glad we found rendertron before we start developing our own.
The thing is, we intend to use this screenshot/render service in production environment but couldn't find any benchmark result or pressure test result, like how many screenshot requests can it take parallelly?
Do you have any plan doing this, how can we help out?

Benchmarking is pretty tough for something like screenshots (and there's a number of other factors in play depending on where you host the image). In cases like AWS' IoT/lambda infrastructure there's roughly a ~2 second delay waiting for the function to run + loading the image.
That said, I've generally found that you can run around 10 parallel screenshot requests on a fairly common VM (1GB ram, 1 CPU) and expect them to finish in a few seconds.
I've also generally found it's better to scale horizontally than vertically, as Chrome does what it will with resources. So, it's generally favorable to launch a few images and then load-balance them (which is what I've done at browserless.io)


Issue toggling required state on TextField component

Steps to reproduce
Steps:

Create standard MUI TextField component with a label and required state set to true. (Asterisk should be visible)
Create button to toggle state of required from true to false
Click button to toggle state

Current behavior
Toggling required state from true to false on a standard TextField component with a label is causing the following error in :
"NotFoundError: Failed to execute 'removeChild' on 'Node': The node to be removed is not a child of this node."
Expected behavior
Asterisk should disappear from the label and required state should be at false.
Context
No response
Your environment

npx @mui/envinfo
  System:
    OS: Windows 11 10.0.22621
  Binaries:
    Node: 19.9.0 - C:\Program Files\nodejs\node.EXE
    npm: 9.6.3 - C:\Program Files\nodejs\npm.CMD
    pnpm: 9.12.3 - ~\AppData\Local\pnpm\pnpm.CMD
  Browsers:
    Chrome: Not Found
    Edge: Chromium (127.0.2651.86)
  npmPackages:
    @emotion/react: ^11.13.3 => 11.13.3
    @emotion/styled: ^11.13.0 => 11.13.0
    @mui/icons-material: ^6.1.6 => 6.1.6
    @mui/material: ^6.1.6 => 6.1.6
    @mui/system: ^6.1.6 => 6.1.6
    @mui/x-data-grid-premium: ^7.22.2 => 7.22.2
    @mui/x-date-pickers: ^7.22.2 => 7.22.2
    @mui/x-date-pickers-pro: ^7.22.2 => 7.22.2
    @mui/x-license: ^7.21.0 => 7.21.0
    @mui/x-tree-view: ^7.22.1 => 7.22.1
    @types/react: ^18.3.12 => 18.3.12
    react: ^18.3.1 => 18.3.1
    react-dom: ^18.3.1 => 18.3.1
    typescript: ^5.6.3 => 5.6.3

Search keywords: MuiFormLabelAsterisk MuiFormLabel MuiTextField Required

@seb-csoftware I've tried to reproduce your issue based on your issue, but it's working as expected for me. can you provide reproduction please?
sandbox: https://stackblitz.com/edit/react-x95tay?file=Demo.tsx
https://github.com/user-attachments/assets/a59090a8-be92-4e45-9f2a-b76d34d06bb0


Allow readonly Stringifiable[] in StringifiableRecord

Since the first argument to stringify isn't mutated, readonly arrays should be allowed as record values. This is a backwards-compatible change, you'll still be able to pass a mutable array if you like.

thank you!


How to active HUD

https://aur.archlinux.org/packages/dxvk-git/ ~  installed this pack
everything is so beautiful and it works fine in games (so thank u)
but i have a problem I could not activate HUD(FPS,memories etc)  the on-screen indicators
I tried 2 games and did not get results
The Walking Dead  http://store.steampowered.com/agecheck/app/207610/?l=turkish
The Hunter  Classic http://store.steampowered.com/app/253710/theHunter_Classic/
System information

GPU: Linux arch 4.16.3-1-ARCH #1 SMP PREEMPT Thu Apr 19 09:17:56 UTC 2018 x86_64 GNU/Linux
Driver:  GeForce GTX 950/PCIe/SSE2 390.48
Wine version:  wine-3.6
DXVK version: 0.42

ı usefull this script
#! /bin/sh
# script by xpander

# Read the file location and go into it
BINDIR="$(dirname "$(readlink -fn "$0")")"
cd "$BINDIR"

# Define directories.
gamedir=$BINDIR
winebindir="$BINDIR"/wine-staging/bin
wineprefixdir="$BINDIR"/_DXVK_prefix

# Disable debugging
export WINEDEBUG=-all

# Vulkan stuff
export DXVK_DEBUG_LAYERS=1
export DXVK_HUD=devinfo,fps,frametimes
DXVK_HUD=1

# Start Steam in prefix
PATH="$winebindir:$PATH" env WINEPREFIX="$wineprefixdir" wine "$BINDIR/_DXVK_prefix/drive_c/Program Files (x86)/Steam/Steam.exe" -no-cef-sandbox

Those are D3D9 games. DXVK only supports D3D11.