Define the version used via hierarchy

This PR changes packages so that component-appcat in parameters.components needs be defined outside of the package (e.g. commodore defaults).
Long story why:
The issue is the version number combined with the monorepo (component & package in one repo). When the package is using a tagged version (say, 0.1.1) that references component-appcat in master version, the master version is used for the component, even if the commodore defaults reference a different version. Not only are the packages used not on the same commit anymore with the component, but it also breaks the release process by introducing a chicken-and-egg-problem.
When releasing a new version, we would need to make a PR or commit that references component-appcat in the next version that doesn't yet exist (say, 0.1.0 > 0.2.0). The CI checks for that PR will fail, but after merging we'll create the new tag (0.2.0).
Having the component-appcat version outside of the packages, breaks a bit the philosophy behind packages, as one does need to maintain not only the right package version (that should include/define all dependencies) but also the version for the component.
We can alleviate this a bit by passing through the package version used to a intermediate parameter before setting the version in components
Checklist

[x] PR contains a single logical change (to build a better changelog).
[x] Update the documentation.
[x] Categorize the PR by setting a good title and adding one of the labels:
bug, enhancement, documentation, change, breaking, dependency
as they show up in the changelog.
[x] Link this PR to related issues or PRs.

For reviewers: The important change is in packages/composition/objectstorage/common.yml and maybe the documentation page.


Add other platforms that one can learn.

I bet there are other platforms with certification courses that can be of so much help.
Wish you could add links to the best courses in these platforms to avoid resource overload.

Thanks for the suggestion, @gateremark. I will keep this issue open if there is more interest in this. For now, we would like to keep the collection focused on Youtube open courses.


Update scalacheck to 1.15.3

Updates org.scalacheck:scalacheck from 1.15.2 to 1.15.3.
GitHub Release Notes - Changelog - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scalacheck", artifactId = "scalacheck" } ]

labels: library-update, semver-patch

Codecov Report

Merging #1659 (6107486) into master (9f92a63) will increase coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1659      +/-   ##
==========================================
+ Coverage   86.13%   86.17%   +0.04%
==========================================
  Files          61       61
  Lines        2423     2423
  Branches      138      130       -8
==========================================
+ Hits         2087     2088       +1
+ Misses        336      335       -1

Impacted Files
Coverage Δ

...rc/main/scala/io/circe/numbers/BiggerDecimal.scala
88.88% <0.00%> (+0.58%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f92a63...c73ca95. Read the comment docs.


htlcswitch: merge htlc custom records on modify

Update forward interceptor MODIFY to consistently merge custom records supplied by the interceptor with those already in LND (previously it would overwrite if set and merge if empty).
Note that this change does not provide the ability to clear any custom records (only overwrite them). If a use cases emerges for the ability to delete records, the API can be extended accordingly.
See #9166 for further discussion.

There isn't a good way to test this right now, because LND doesn't set any custom records - will be implicitly covered by the addition of #8390.

@carlaKC  - might require a re-push to un-stick those last couple of itest. GH actions bug

I removed the no-itest label to attempt to make them run (the label actually means "skip itests", not "it's okay this PR doesn't add any itests"), but a simple re-run of the actions didn't trigger them.
Would be good to make sure no itests are broken by this, so can you please do another change/rebase/push?

the label actually means "skip itests", not "it's okay this PR doesn't add any itests"

whoops, TIL!

Tests passed (with some known flakes), rebased to clear release notes conflict!


Fetching into a bare repo doesn't work

I'm trying to use go-git (v4) to fetch from a remote into a bare repo, and I'm getting back an "already up-to-date" error even though I know for sure that the remote has new commits.
I was writing a test to see what happens when doing a non-fast-forwardable fetch (inspecting the code, I think there's a bug there too as it doesn't appear to check the fast-forward + in the refspec at all), but it seems there's a bigger issue fetching at all.
Here is a shell script to set up a repro (run it in a new test directory):
#!/usr/bin/env bash

# Make bare repo
mkdir repo
cd repo
git init --bare
cd ..

# Make checkout and initialize remote repo
mkdir checkout
cd checkout
echo test > test
git init
git add test
git commit -m "test"
git remote add r ../repo
git push r master:master
cd ..

# Make a remote in the bare repo
cd repo
git remote add c $PWD/../checkout

Then, compile and run this Go program in the same directory:
package main

import (
	"fmt"

	"gopkg.in/src-d/go-billy.v3/osfs"
	gogit "gopkg.in/src-d/go-git.v4"
	"gopkg.in/src-d/go-git.v4/config"
	"gopkg.in/src-d/go-git.v4/storage/filesystem"
)

func main() {
	bare := osfs.New("./repo/")
	s, err := filesystem.NewStorage(bare)
	if err != nil {
		panic(err)
	}

	repo, err := gogit.Open(s, nil)
	if err != nil {
		panic(err)
	}

	o := &gogit.FetchOptions{
		RemoteName: "c",
		RefSpecs:   []config.RefSpec{"master:master"},
	}
	err = repo.Fetch(o)
	if err != nil {
		fmt.Printf("Couldn't fetch from remote (non-force): %+v\n", err)
	}

	o = &gogit.FetchOptions{
		RemoteName: "c",
		RefSpecs:   []config.RefSpec{"+master:master"},
	}
	err = repo.Fetch(o)
	if err != nil {
		fmt.Printf("Couldn't fetch from remote (force): %+v\n", err)
	}
}

I get the output:
$ go build -o fetch main.go && ./fetch
Couldn't fetch from remote (non-force): already up-to-date
Couldn't fetch from remote (force): already up-to-date

However, if you try it on the command line, this is the behavior:
repo$ git fetch c master:master
remote: Counting objects: 3, done.
remote: Compressing objects: 100% (2/2), done.
remote: Total 3 (delta 0), reused 0 (delta 0)
Unpacking objects: 100% (3/3), done.
From /tmp/gogittest/repo/../checkout
   93e4174..b66c535  master     -> master
 * [new branch]      master     -> c/master

Is go-git intended to be used to access bare repos?  Am I doing something wrong?  Thanks!  And thanks for the great project.

The problem is not in the fetch itself, is because you are using, short refs in the refspec like "+master:master". This is not currently supported you must to use a full refspec such as +refs/heads/master:refs/remotes/origin/master.

Oh, thanks!
Off the top of your head, will it reject non-fast-forward fetches without the +, the way it does on the command line?  (I can file a separate issue for that if you want.)

The current implementation is always force. But is being fixed there https://github.com/src-d/go-git/issues/490.

Awesome, I'll watch out for that.  Thanks.


Rename file with extensions .yml to .yaml for uniformity

In order to have the same naming conventions across all our code the .yaml extensions will be used across all files.

DO NOT MERGE YET*

CI needs to apply proper change first

I close this pull-request, it has been a long time now. Feel free to re-open it or ask for help.


Funds received on-chain don't swap automatically

Hi Team,
Please check my issue here 🔗 https://x.com/pio_taras/status/1809601751143665940?t=y0glAc9hlFBDcAz0gjQjJQ&s=19
Thanks.

This is fixed by https://github.com/ACINQ/lightning-kmp/pull/681: this was indeed a bug caused by an edge case in the migration from the legacy app, because you had a tiny utxo (701 sat) that wasn't economical to swap and incorrectly blocked the next swaps. This will be fixed in the next release and your pending swap will automatically complete after the app update.


[WIP] Add large 7-series parts

Added xc7k480t and xc7vx980t fabrics

As expected a stock GH runner didn't have enough memory to run RapidWright for the xc7k480tffg901-1 device


Cognitive Services / Face / Person Group create() parameter

Package Name:
Package Version:
Operating system: Windows 10
[ ] nodejs

version: v12.13.0

[ ] browser

name/version: Edge

[ ] typescript

version:

Is the bug related to documentation in

[ ] README.md
[x] source code documentation
[ ] SDK API docs on https://docs.microsoft.com

Describe the bug
In the Cognitive Services/Face SDK, the Person Group create() function lists an optional parameter that is not optional, but required.
Here is what it says in the SDK reference:
create(string, Models.PersonGroupCreateOptionalParams)
The 2nd parameter is supposed to be optional, but the function fails when this is used:
const PERSON_GROUP_ID = 'my-unique-person-group'
    await client.personGroup.create(PERSON_GROUP_ID)
        .then(() => {
        }).catch((err) => {
            console.log(err)
            throw err
        })

The function is fixed when the optional parameter is added:
const PERSON_GROUP_ID = 'my-unique-person-group'
    await client.personGroup.create(PERSON_GROUP_ID, { 'name': PERSON_GROUP_ID, 'recognitionModel': 'recognition_01' })
        .then(() => {
        }).catch((err) => {
            console.log(err)
            throw err
        })

To Reproduce
Steps to reproduce the behavior:

Run the single-parameter snippet above with any person group ID. You should get an error:

RestError: Request body is invalid.
    at new RestError (C:\Users\wazure\Desktop\Face\face_quickstart_node\node_modules\@azure\ms-rest-js\dist\msRest.node.js:1399:28)
    at C:\Users\wazure\Desktop\Face\face_quickstart_node\node_modules\@azure\ms-rest-js\dist\msRest.node.js:2490:37         at processTicksAndRejections (internal/process/task_queues.js:93:5)
    at async main (C:\Users\wazure\Desktop\Face\face_quickstart_node\FaceQuickstart.js:123:5) {
  code: 'BadArgument',                                                                                statusCode: 400,                                                                                request: WebResource {                                                                                streamResponseBody: false,                                                                                url: 'https://westus.api.cognitive.microsoft.com/face/v1.0/persongroups/my-unique-person-group',
    method: 'PUT',                                                                                headers: HttpHeaders { _headersMap: [Object] },
    body: '{"recognitionModel":"recognition_01"}',
    query: undefined,
    formData: undefined,
    withCredentials: false,
    abortSignal: undefined,
    timeout: 0,
    onUploadProgress: undefined,
    onDownloadProgress: undefined,
    proxySettings: undefined,
    operationSpec: {
      httpMethod: 'PUT',
      path: 'persongroups/{personGroupId}',
      urlParameters: [Array],
      requestBody: [Object],
      responses: [Object],
      serializer: [Serializer]
    }
  },
  response: {
    body: '{"error":{"code":"BadArgument","message":"Request body is invalid."}}',
    headers: HttpHeaders { _headersMap: [Object] },
    status: 400
  },
  body: {
    error: { code: 'BadArgument', message: 'Request body is invalid.' }
  }
}

Expected behavior
The person group should be created with only a person group ID as parameter.
Extra code needed
Before you can run the snippet, you need to authenticate a client. This will work:
var msRest = require("@azure/ms-rest-js");
var Face = require("@azure/cognitiveservices-face");

// Set the FACE_SUBSCRIPTION_KEY in your environment variables with your subscription key as a value.
let credentials = new msRest.ApiKeyCredentials({ inHeader: { 'Ocp-Apim-Subscription-Key': process.env['FACE_SUBSCRIPTION_KEY'] } });
// Set FACE_REGION in your environment variables with its endpoint region (such as 'westus') as a value.
let client = new Face.FaceClient(credentials, process.env['FACE_ENDPOINT']);

Thanks for reporting @wiazur
@ChrisHMSFT Can you please route this to the right person in the cognitive services - face team?

This issue is now resolved with the recent Node SDK update.


Huge memory leak after installing python package via integrated terminal

This problem happens all the time on MacOS. No matter what python package gets installed (via pip) the memory usage of pylance keeps climbing forcing a restart. What I did notice was that this problem only happens when packages are installed from within the integrated terminal. Along with pylance extension, a Code Helper (Renderer) also ends up with a lot of memory. My python settings are:
"[python]": {
	"editor.codeActionsOnSave": {
		"source.fixAll": true,
		"source.organizeImports": true
	},
	"editor.defaultFormatter": "ms-python.black-formatter",
	"editor.formatOnSave": true,
	"gitlens.codeLens.symbolScopes": [
		"!Module"
	]
},
"python.analysis.autoFormatStrings": true,
"python.analysis.autoImportCompletions": true,
"python.analysis.diagnosticMode": "workspace",
"python.analysis.fixAll": [
	"source.unusedImports"
],
"python.analysis.gotoDefinitionInStringLiteral": true,
"python.analysis.inlayHints.callArgumentNames": false,
"python.analysis.inlayHints.functionReturnTypes": true,
"python.analysis.inlayHints.pytestParameters": true,
"python.analysis.inlayHints.variableTypes": true,
"python.analysis.packageIndexDepths": [
	{
		"depth": 3,
		"includeAllSymbols": true,
		"name": ""
	}
],
"python.analysis.typeCheckingMode": "strict",
"python.defaultInterpreterPath": "${workspaceFolder}/.venv/bin/python",
"python.envFile": "${workspaceFolder}/staging.env",
"python.formatting.provider": "black",
"python.languageServer": "Pylance",
"python.linting.banditArgs": [
	"--ignore=8108"
],
"python.linting.banditEnabled": true,
"python.linting.lintOnSave": true,
"python.linting.prospectorArgs": [
	"-s",
	"veryhigh"
],
"python.linting.prospectorEnabled": false,
"python.terminal.activateEnvInCurrentTerminal": true,
"python.testing.pytestArgs": [
	"."
],
"python.testing.pytestEnabled": true,
"python.testing.unittestEnabled": true,

Thanks for the issue.
I'm afraid the settings aren't enough to cause a problem for me locally. Do you have an example project that causes the problem? My guess is something in your specific set of installed packages is causing an issue. You might also try setting your package index depth lower. Depending upon what you have installed a depth of 3 may cause us to load a LOT of files into memory. That could be the root cause of the problem.
Including the logs would also help us diagnose the issue:
https://github.com/microsoft/pylance-release/blob/main/TROUBLESHOOTING.md#filing-an-issue

I've changed global depth to 2 and it didn't help. There has got to be some regression in some of the recent releases. VSCode memory spikes while simply typing out some code. Reloading the window is how I'm getting around things. I'll enable logging but it says that it produces a lot of logs and I hope that doesn't slow things down

Without a project or a repro, we can't really help here. Generally, these sort of things are caused by specific python files causing really long analysis chains in our type evaluation code. So a repro is really the only way to figure out what the problem is.

Additionally, the logs should pinpoint any files that are taking up a lot of memory when being analyzed as we print out anything that takes a long time or is consuming significant memory.
The log shouldn't have any impact on pylance's memory consumption though. It just slows things down a bit.


How would I save the output image as it's own file in my deep_deep folder?

I have noticed an issue where the output image can be too large for you to download it via right clicking and saving in the browser.
How would I save the output image as it's own file in my deep_deep folder?

If I assigned the output of dream() to, say, 'img2':
img2 = cnn.dream(...
then I can do: dd.to_image(img2).save('output_folder/out.jpg', quality=95) (quality is for jpeg only and is omitted for png).
I can also do: dd.save_as_hdr(img2, 'output_folder/out.tiff') or out.exr to save the output as HDR floating point for later processing in, for instance, Photoshop.
I really need to work on that CLI interface. I personally live in jupyter notebook but it's been hard for others to get used to.

I just added a work-in-progress command line client, deep_dream_cli. It should be easier to do this with.


cdc,pkg: accommodate systemd TimeoutStopSec and k8s terminationGracePeriodSeconds

What problem does this PR solve?
Issue Number: ref #4757
What is changed and how it works?
Add liveness to TiCDC.
TiCDC sets liveness to Stopping upon receiving SIGTERM.
The exit perdure wait TiCDC drains all its tables and ownership (not implemented yet).
Check List
Tests

Unit test

Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note
None

/run-all-tests

LGTM

/run-unit-test

/merge

/run-kafka-integration-test


feature request: Check if a file is sorted already

Thanks for the great library! I am using it to add some determinism to our tsconfig files in our monorepo. One thing that would be helpful for us is a faster way to check if a file is already sorted. We run checks in CI to verify that files are in the right state, and while we can just "always sort" it is a little slow compared to our other "checks."
I was thinking that it would be easiest to implement something like this in the core library. I am willing to open a PR if you have suggestions for where and how to implement this.
There should probably be a corresponding flag on the CLI package, too.

Hey!
I think an isSorted() export could make sense, with e.g. a --check flag on the CLI 👍 The simplest way I can think of would be to basically go through the parsed data like the sorter does, but only comparing fields with their next sibling. If we encounter a value that should be before it's sibling, we exit early.
Since the comments are irrelevant to the order of the fields, there is a possibility that it would be faster to just strip all comments and use a regular JSON.parse, but I'm not sure if that would be worth it.
If you're keen then a PR is of course super welcome! ⭐


opencv2: don't build unfree libraries by default

Motivation for this change
In opencv 2.x, unfree libraries are built by default.  The package should therefore have been marked as unfree, but wasn't.
I've disabled the non-free libraries by default, and added an option to enable them.  There are three programs in Nixpkgs that depend on opencv2: mathematica, pfstools, and p2pvc.  pfstools requires the non-free libraries if it's built with opencv support, so I've disabled opencv by default there and added an option to enable it.  p2pvc links fine, so presumably doesn't need the non-free libraries.  I can't test mathematica, so I'm just going to leave it alone.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

If Mathematica is currently broken anyway, I think I'd like to go ahead with this without waiting, and then you could add enableUnfree to Mathematica's opencv2 input if it turns out to be required when you're doing your other fixes.  I think it's important that we fix license problems like this ASAP in case we e.g. are not permitted to distribute the result through Hydra.  Does that sound okay to you?


[MINOR] Skip loading last completed txn for single writer

Change Logs
Describe context and summary for this change. Highlight if any code was copied.
Skip the loading of last completed txn for single writer case. The loading process will read the latest commit file. It may introduces non-negligible overhead in writing when the commit file is large (e.g., 100+MB).
Impact
Describe any public API or user-facing feature change or any performance impact.
NO API change and will bring performance benefit for single writer case.
Risk level: none | low | medium | high
Choose one. If medium or high, explain what verification was done to mitigate the risks.
None.
Contributor's checklist

[x] Read through contributor's guide
[x] Change Logs and Impact were stated clearly
[ ] Adequate tests were added if applicable
[ ] CI passed

Canceling the CI run to prioritize release blockers. Apologies.

hey @YuweiXiao : can you rebase.
once CI is green, we are good to land.

@YuweiXiao : can you rebase w/ latest master. we fixed a flaky test.


Create a UI to download a spreadsheet

This is continuation of issue #884
Create a UI to download a spreadsheet of data that CELTS requested.

Branch added 1104-Spreadsheet-UI


08/02/2018 05:59 : Create Pull Request for branch master -> prTesting1_2018080205

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

split/updateTestCon1.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Error: filename "AppDelegate.swift" used twice

Hi, I am trying to use the Swift Validator but I keep getting an error saying that the AppDelegate.swift is declared twice. What i did was I added the Validator folder and the Validator.xcodeproj to the top level of my application. I would imagine because the compiler sees two declarations of AppDelegate.swift in my project, the compiler cannot see the difference between the two files. As a result, I tried to only include the Validator.xcodeproj into my project and removed the Validator folder from my project but the 'Validator' class is not being recognized. Any ideas on how to fix this?

An app can only have one AppDelegate.swift. If you put the whole folder in your app it will find two of them and throw an error. You really want to include these files:

Validator, ValidationRule, ValidationError, Rule, and one of the Rules like EmailRule should show you the pattern. Then you can just pick and choose what you want. I would just add the files into my project manually. I am still trying to figure out how to make a cocoapod in issue #1

This is really helpful. Thanks a lot! Really appreciate the clarification.


Preset fixes and UI refresh

Description
This PR implements the following features/fixes:

[x] Remove selectedPatch from presets store (we don't select patches here, just share or collect them with checkboxes)
[x] Improve deduplication and loading of collectable presets
[x] Check if a preset's notes are defined before showing them and truncate overly long notes
[x] Improve styling of presets tables for dark and light modes
[x] Add 'lookup' | 'scanning' | 'no-presets' views to PresetsCollect modal
[x] Move button to collect presets to top right of presets box and label it "Find Presets"
[x] Add the new Ditto logo

Link to issue
Please add a link to any relevant issues/tickets
Type of change
Please delete options that are not relevant.

[x] Bug fix (non-breaking change that fixes an issue)
[x] New feature (non-breaking change that adds functionality)

Screenshots/Screencaps
Light mode:

Dark mode:

Modal states:

Nice! this is all looking great 💯 one idea for the Find Presets button could be to show it in the bottom right corner of the table, similar to how the plugin does it 🤷🏼

Yeah, I think this would be better. One thing I was thinking about is the current placement probably doesn't work so well for mobile. Will think about adjusting it on another PR.


elixir_eulergravity_jeans_instability.jl crashes with given CFL

The example examples/paper_self_gravitating_gas_dynamics/elixir_eulergravity_jeans_instability.jl crashes with the supplied values for CFL Euler and CFL Gravity. With the values from the paper it runs.

That's bad. I wonder why it wasn't seen in CI. Looks like the change comes from https://github.com/trixi-framework/Trixi.jl/pull/326/files#diff-1c1b525549c1f59356be3f3049d0c2a66582d28e6b4959b17bf5830afc7452dd. I wonder whether it ran back then...
Could you please fix the example by adapting the CFL number? It may also be something different from the values we used in the paper (since Trixi.jl was quite different back then).

That is very strange. I wonder if it was related to switching from our hand rolled CarpenterKennedy 5-stage, order 4 implementation to the ODE library...In any case this was a good catch and fix in #2089


Compile editables that are both primary reqs and constraints

If an editable package is both a primary requirement and a constraint, it was being considered as solely a constraint, and so it and its dependencies were excluded from pip-compile output.
Instead of combining the editable requirements, we were returning the first one, and the two are sorted the same up to "... -c constraints.in" and "... -r requirements.in".
Changelog-friendly one-liner: Ensure editables that are both primary reqs and constraints appear in pip-compile output
Contributor checklist

[x] Provided the tests for the changes.
[x] Gave a clear one-line description in the PR (that the maintainers can add to CHANGELOG.md on release).
[ ] Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

Hello @richafrank!

If an editable package is both a primary requirement and a constraint, it was being considered as solely a constraint, and so it and its dependencies were excluded from pip-compile output.

It looks like a bug. Could you please provide also reproducible steps to test?

Hi @atugushev !
(I thought the unit test might serve as those steps. It fails on master.)
Put an editable in your requirements.in and the same one in a constraints via a second .in file. I can spell that out more precisely if that'd be helpful!

Usually, editables don't suppose to be in constraints file, but it looks like this bug related to layered workflow. Am I right?

Usually, editables don't suppose to be in constraints file, but it looks like this bug related to layered workflow. Am I right?

Yea, I'm generating a lockfile from a base set of requirements. Then I'm using that lockfile as constraints when generating a lockfile for a superset of the base requirements, to keep them in sync. The base requirements include an editable package, so it appears in the lockfile. Thoughts on this workflow?

Thanks for the review @atugushev . I'm certainly on board with your suggestions - I'm glad we don't need all that ordering compat.

Thanks, @richafrank!


Tablet survey does not intercept clicks

Version info

Wootric Android SDK version: 2.4.10
Android OS version: 7.0 Nougat
Android Device: Nexus 7 Emulator

Expected behavior
Tapping within the area of the screen covered by the survey should not interact with the Views behind the survey.
Actual behavior
Any tap outside of the wootric_et_feedback EditText or the ScoreView 0-10 views sends the click through to the View behind it. This is inconvenient because if the user misses their target even by a tiny amount, the UI will unexpectedly change.
Steps to reproduce

Build a layout with clickable Views that would be covered by the survey on a tablet.
Click near, but just outside the EditText.
Observe that the View behind the survey responds to the click event.

@jahunt1 thanks for reporting this. We'll take a look asap.

This issue was resolved on PR #40


Update action.yml to include latest versions of other scripts

Please verify.
One of my workflows send a few warnings after using this action, claiming it uses outdated actions. Is it safe to update all the versions to the latest?

I am not sure whether updating all these actions brings breaking, I will test it in later weeks.


sync_state: remove block_path, fixes #164

as per the title, this removes block_path and fixes #164

I think, in order to keep the sync_state protocol consistent, that we would need to construct the MmrDelta slightly different, as explained in this comment: https://github.com/0xPolygonMiden/miden-node/issues/152#issuecomment-1898116360 (unless this was planned for a future change or there si anything I'm missing)


Incorrect xref for linker option DRIVER

In the linker option DRIVER material, the section "To set this linker option programmatically" has an incorrect xref:
1.  See `P:Microsoft.VisualStudio.VCProjectEngine.VCLinkerTool.driver`.

Would open a pull request for this, but I can't seem to get the docfx to resolve an xref correctly. Perhaps someone familiar with the feature can make the change. Or provide a pointer as to what else is required and I can implement.
For example linker option DELAYLOAD has an xref that resolves correctly:
-   See <xref:Microsoft.VisualStudio.VCProjectEngine.VCLinkerTool.DelayLoadDLLs%2A>.
Following that pattern in DRIVER unfortunately doesn't resolve to a link in a local build. Instead it seems to have no resolution applied and ends up as raw text in the produced docs:
-   See <xref:Microsoft.VisualStudio.VCProjectEngine.VCLinkerTool.driver%2A>.
Trying it without the encoded asterisk at the end has the same result (not sure what that character is about):
-   See <xref:Microsoft.VisualStudio.VCProjectEngine.VCLinkerTool.driver>.
For reference, there is in fact a VCLinkerTool.driver property in the API docs:
https://msdn.microsoft.com/en-us/library/microsoft.visualstudio.vcprojectengine.vclinkertool.driver.aspx

Unfortunately, the xref system probably requires the customized build tool used internally by our publishing system to generate working links for preview. I don't think it's part of the stock DocFX capability. It uses custom YML files found in .zip form in the docs directory, for example. vs.140.zip, to associate the xref link with a URL. If the .NET API definition exists in the YML files, then it's safe to use in an xref link even if the preview doesn't show it working.

OK understood. I'll follow that pattern for future changes. Thanks for your pull request.
I see there are VCLinkerTool.yml files in 2 of the zip files:

vs.110.zip - Microsoft.VisualStudio.VCProjectEngine.VCLinkerTool.yml
vs.140.zip - Microsoft.VisualStudio.VCProjectEngine.VCLinkerTool.yml

I'm not seeing a driver property in either of them. They do both have the DelayLoadDLLs property from the working example. Is it possible the driver link is missing?

It may well be that VCLinkerTool.driver is not there in the YML. My search didn't find it, either, which means my fix will probably not fix much - yet. We've been finding a fair number of missing entries, particularly for enumeration types, and I'm told someone is looking into it. We'll probably get a new set of zip files and commit them "soon", then a new build of the whole project will pick them up and the xref links will appear as intended.


[Mistral-7B] API validation tokenizer is counting tokens incorrectly

System Info
next tokens size: 1807 = chunk_size - (resp_tokens_size + prompt_tokens_size) = 2000 - (135 + 58) = 2000 - (193) = 1807
but i'm getting error from text-generation-inference api:
text_generation.errors.ValidationError: Input validation error: inputs tokens + max_new_tokens must be <= 2500. Given: 2309 inputs tokens and 500 max_new_tokens
1807 against 2309 tokens
Information

[X] Docker
[ ] The CLI directly

Tasks

[ ] An officially supported command
[ ] My own modifications

Reproduction

Use TheBloke/Mistral-7B-Instruct-v0.1-AWQ model and its tokenizer to calculate tokens.
set input limit to 2000
Send to text-generation-inference api
receive error because input tokens size is over expected size

Expected behavior
Tokens are calculated properly, using HuggingFace provided model tokenizer and its settings inside repository.

using lastest docker image:
        "Id": "sha256:a111faa3a21bfa126c5e59b69f7b434a43072931cd184254e466a6fa2510dd39",
        "RepoTags": [
            "ghcr.io/huggingface/text-generation-inference:latest"
        ],
        "RepoDigests": [
            "ghcr.io/huggingface/text-generation-inference@sha256:553a1397345e37bc5c6c9eb2300ee46c7dd5c55937c245871608f903f7f71d7d"
        ],

corresponds to latest pushed image here:
https://github.com/huggingface/text-generation-inference/pkgs/container/text-generation-inference

I'll dig into how source code now, to find out how token input size validation is actually working and whether it is using provided model tokenizer or not.

Hmm it seems tokenizer is taken from repo here:
https://github.com/huggingface/text-generation-inference/blob/7a6fad6aac67d9bf21fe75c034a6bcab5dbd88d2/router/src/main.rs#L155

ok, finally got to the place where tokenizer is initialized https://github.com/huggingface/text-generation-inference/blob/main/server/text_generation_server/models/flash_mistral.py#L297

Shouldn't it be AutoTokenizer? Like i'm using in python:
tokenizer = AutoTokenizer.from_pretrained(model_name, trust_remote_code=True, use_fast=True)

https://huggingface.co/TheBloke/Mistral-7B-Instruct-v0.1-AWQ/blob/main/tokenizer_config.json#L39
Is indeed using LlamaTokenizerFast, but possibly some options are not used from repo?

Is tokenizer.model from the repo is used under the hood?

No, it's using tokenizer.json which is equivalent.
Can you share anything reproducible ?
You're sending a few numbers, but you're not giving the payload, so it's impossible to know who's right.

I'm using exact tokenizer, like you do, but in python:
tokenizer = LlamaTokenizerFast.from_pretrained(
    model_name,
    revision="main",
    padding_side="left",
    truncation_side="left",
    trust_remote_code=True,
)

Could it be that either python or rust implementation is outdated?

One moment

https://gist.github.com/Bec-k/5a6acfce3d1acc0a515356ca841730e5
this part is working fine
second call is breaking apart:
https://gist.github.com/Bec-k/ca1341404e4739dd1174702b4a341f1f
Basically i'm using langchain to extract large crawled texts into something useful.

Still getting incorrect tokens calculation from api, have tried everything and re-checked 100 times on my side...

Docker image is build on transformers==4.33.2 , but actual transformers library is 4.33.3 and there are ongoing changes related to Mistral. Possibly it is outdated?

oh damn, error is coming from rust, it seems there is another dependency library which is calculating tokens:
https://docs.rs/tokenizers/latest/tokenizers/
I suspect that it could be calculating them incorrectly.

I have found the bug... It's my fault, closing ticket. Sorry for the trouble.

Could you share what it was, might help others ?

Dumb mistake, was working too much. After changing prompt templates between multiple models i was testing on, i left two template same placeholders. Which in the end was leading to duplication on input in langchain depths, as variables are replaced somewhere inside langchain library.
Should have copied and calculated tokens from the input coming right into api...
Silly mistake.

@Bec-k
I had an issue where i want the
padding_side="left"
Is there an optio in TGI to do that?


0.10 doc updates page

Signed-off-by: JENNIFER RONDEAU<EMAIL_ADDRESS>addresses issue #856
I seem to have done something interesting with overlapping PRs. Will fix up after review as needed. This PR is for the new versions.md file only.

This LGTM, we'll just want to drop the first commit before merging since that's from PR #1004

commit removed, but not ready to YOLO :-)

Are you planning to add a link to this page on the docs site nav?

@skriss yes but that needs to be another PR against the gh-pages branch, until we move publication process (we'll have a new TOC altogether for 0.10 -- need entries for new CRDs info also)


Remove sealed-secret chart when upstream changes merged.

https://github.com/helm/charts/pull/22722

Bump - this can probs be tackled now?


Date format issue

Hello
All my stats related to September 1st, 2nd, 3rd and 4th are showed as 9th of January, 9th of Febraury, 9th of March and 9th of Abril respectivelly. I joined MTG Arena past August.

Vault progress example. Anyway this is true for all kind of stats.
Regards

This issue is related to date format output in the game log. Wizards are toying with it all the time for some reason. Changing from local to us and back to local again, so this issue comes up again and again, driving all our team crazy. Can you get the log from AppData\LocalLow\Wizards Of The Coast\MTGA and send it over to me using any cloud service for investigation?

This is really annoying, sorry to hear that.
You can find my log here https://drive.google.com/file/d/1Lwm_hFxYfLqSdhMHwUWC-5cQZjsBBQy1/view?usp=sharing
thanks!


Locale is not correct

In the "old" BIRT-Viewer you can see the date was in German format:

In the our BIRT-Viewer the date was in English format:

The old one was correct.

On my machine the date format is correct. I guess the system is using the default locale of the machine. Now the locale is explicitly set on the IRunAndRenderTask Object to a locale value hold by  the LocaleContextHolder of Spring. The default value is set to english. It is overridden by the browser accept-header request header. And that is overridden by reportengine-language cookie. And this can set by a request parameter language to session scoped value.
For instance, http://localhost:8080/report-cockpit-birt-web/reports/salesinvoice?language=de.

Locale is now correct.


Missions and streams may branch to main space

Not sure if this is being done correctly here.

This is a non-issue, in fact gta3.test and gtavc.test takes care of testing this already.


feat(chart/csi-node): add nvme kato parameter

Add parameter to configure keep alive timeout.
By default it's set to "" meaning it's the system default (5).
Signed-off-by: Tiago Castro<EMAIL_ADDRESS>

bors try

bors try

bors cancel

We have another good old bors bork
bors retry

bors ping

bors try

bors cancel

bors try

I wrote the status directly to the commit, seems to have unborked bors.. let's try again:
bors try

bors try

bors try

Something doesn't seem right...
ERROR: Error fetching remote repo 'origin'

hudson.plugins.git.GitException: Failed to fetch from https://github.com/openebs/mayastor-extensions.git

	at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:1003)

	at hudson.plugins.git.GitSCM.retrieveChanges(GitSCM.java:1244)

	at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1308)

	at org.jenkinsci.plugins.workflow.steps.scm.SCMStep.checkout(SCMStep.java:129)

	at org.jenkinsci.plugins.workflow.steps.scm.SCMStep$StepExecutionImpl.run(SCMStep.java:97)

	at org.jenkinsci.plugins.workflow.steps.scm.SCMStep$StepExecutionImpl.run(SCMStep.java:84)

	at org.jenkinsci.plugins.workflow.steps.SynchronousNonBlockingStepExecution.lambda$start$0(SynchronousNonBlockingStepExecution.java:47)

	at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515)

	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)

	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)

	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)

	at java.base/java.lang.Thread.run(Thread.java:829)

Caused by: hudson.plugins.git.GitException: Command "git submodule foreach --recursive git reset --hard" returned status code 128:

stdout: Entering 'dependencies/control-plane'

HEAD is now at 0d0e7e04 chore(bors): merge pull request #407

Entering 'dependencies/control-plane/rpc/api'

HEAD is now at f54c0cc feat: report hostnqn through registration and info messages (#39)

Entering 'dependencies/control-plane/utils/dependencies'

HEAD is now at 79e3fc7 feat(nvmeadm): add hostnqn config parameter (#16)

Entering 'dependencies/control-plane/utils/dependencies/h2'

HEAD is now at 929f268 fix header

stderr: fatal: No url found for submodule path 'rpc/api' in .gitmodules

looks like rpc could not be clean because it was owned by root?? should work now:
bors try

bors merge


Block writing still stops in non-sealing nodes due to nil BestPeer

Block writing stops in non-sealing nodes due to nil BestPeer
Description
It looks like we are still observing the same issue as originally described in https://github.com/0xPolygon/polygon-sdk/issues/167
After investigating, this seems to be related to some inconsistencies in how we determine the best peer to connect to within BestPeer(). We are seeing that at times, curDiff is always greater than bestTd, resulting in this function always returning nil.
We've adding some extra logging in BestPeer to help investigate:
func (s *Syncer) BestPeer() *syncPeer {
	var bestPeer *syncPeer
	var bestTd *big.Int

	for _, p := range s.peers {
		status := p.status
		if bestPeer == nil || status.Difficulty.Cmp(bestTd) > 0 {
			bestPeer, bestTd = p, status.Difficulty
		}
	}
	if bestPeer == nil {
		return nil
	}
	curDiff := s.blockchain.CurrentTD()
	fmt.Println("BestPeer() curDiff = ", curDiff)
	fmt.Println("BestPeer() bestTd = ", bestTd)
	if bestTd.Cmp(curDiff) <= 0 {
		return nil
	}
	return bestPeer
}

Although the change https://github.com/0xPolygon/polygon-sdk/commit/5170883f9de116c18ad32640c46af8e9de5f1a84 was put in (to broadcast the header's difficulty instead of the block number), it appears that we are actually initializing the header's Difficulty to be the same value as the header's Number, resulting in a broadcast of the same value:
https://github.com/0xPolygon/polygon-sdk/blob/bba205e6ed4aad9522450558ed3dbad67664e723/consensus/ibft/ibft.go#L349-L353
Upon attempting to correct L353 above, we are still seeing the same issue as can be seen in our logs. Below the bestTd is always<PHONE_NUMBER>77. Furthermore, the difficulty outputted in the enqueue block debug statement has the same value as the block number:
2021-10-07T14:11:43.046Z [DEBUG] polygon.consensus.syncer: enqueue block: peer=16Uiu2HAmBv5UkctkZK1ui2tMip6XqpykvMnrzDuLGNjN38YDztmW number=982519 hash=0xfbda9f200b380eeab2eeb9fb2e80bb25a925929b55c1f2a35d38dbc085f1c831
2021-10-07T14:11:43.046Z [DEBUG] polygon.consensus.syncer: update peer status: peer=16Uiu2HAmBv5UkctkZK1ui2tMip6XqpykvMnrzDuLGNjN38YDztmW latest block number=982519 latest block hash=0xfbda9f200b380eeab2eeb9fb2e80bb25a925929b55c1f2a35d38dbc085f1c831 difficulty=982519
2
BestPeer() curDiff =<PHONE_NUMBER>17
BestPeer() bestTd =<PHONE_NUMBER>77

I've put together the difficulties of the 5 peers currently connected:
peer1.status.Difficulty = 982668
peer2.status.Difficulty = 982668
peer3.status.Difficulty = 982668
peer4.status.Difficulty = 982668
peer5.status.Difficulty =<PHONE_NUMBER>77

In the above scenario, peer5 will always be our 'bestPeer', however its difficulty is always less than the current difficulty of<PHONE_NUMBER>17 so we will always return nil.
I would assume that if the Difficulty value for peer1-peer4 were sent correctly, we would connect to a better beer whose Difficulty would be greater than our current difficulty.
Your environment

OS and version Ubuntu 20
version of the Polygon SDK bba205e
branch that causes this issue develop

Steps to reproduce

start some non-sealing nodes connected to a cluster of 5 validators
observe that we can never connect to a peer who's difficulty is greater than the current block difficulty
restarting sometimes fixes the isssue

Expected behaviour
Gossip'd blocks should continue to be written to state and processed normally after bulk sync.
Actual behaviour
Although we still enqueue blocks, we are no longer writing them to state when we can't properly determine the best difficulty of a connected peer.

Hey @dankostiuk ,
the (recurring) issue is addressed in PR#208.


Fix HttpHeaderNamesTest

Motivation:
Fix HttpHeaderNamesTest. httpHeaderNamesContainsAllFieldsInHttpHeadersInGuava fail
Modifications:

Add SEC_AD_AUCTION_FETCH and AD_AUCTION_SIGNALS to HttpHeaderNames

Result:
Closes: https://github.com/line/armeria/issues/5492

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Allow non-obsidian blocks at portal frame corners

Opening an issue so we can discuss PR #51 further.
Real portal frames don't need any blocks at all on the corners, but I observed that air blocks allowed the portal projection to be seen at those locations. So my original PR required occluding blocks at the corners so the projection wouldn't be seen there.
As you pointed out, however, the block break listener explicitly checks for an obsidian block and then calls removeDamagedPortals. I suppose the check for obsidian can be changed to isOccluding(), which would result in removeDamagedPortals being called every time someone breaks a solid block.  Is that sufficient?  And do you have an idea how efficient that is?  I don't want to add a lot of extra load.  I guess it really depends on how many portals there are in that world.

Just to make sure you know...  You have a couple of debug lines at https://github.com/GorgeousOne/NetherView/blob/b48ca2f93051b9f31c8901faa1c9b7133c9b26e4/src/main/java/me/gorgeousone/netherview/listeners/TeleportListener.java#L107
System.out.println(portal);
System.out.println(counterPortal);

I did a quick test and this version seems to be working.

Added to update 2.1.0


cmd/dist: child process prints to log after make.bash has exited

$ cd goroot/src
$ git reset --hard dd0e7a9 # pristine recent snapshot
$ echo  "doesn't compile" >> cmd/go/internal/list/list.go
$ ./make.bash
Building Go cmd/dist using /usr/local/google/home/adonovan/go1.6.
Building Go toolchain1 using /usr/local/google/home/adonovan/go1.6.
Building Go bootstrap cmd/go (go_bootstrap) using Go toolchain1.
/usr/local/google/home/adonovan/goroot2/src/cmd/go/internal/list/list.go:421:1: syntax error: non-declaration statement outside function body
/usr/local/google/home/adonovan/goroot2/src/cmd/go/internal/list/list.go:421:16: newline in character literal
go tool dist: FAILED: /usr/local/google/home/adonovan/goroot2/pkg/tool/linux_amd64/compile -std -pack -o /tmp/go-tool-dist-385632282/cmd/go/internal/list/_go_.a -p cmd/go/internal/list /usr/local/google/home/adonovan/goroot2/src/cmd/go/internal/list/context.go /usr/local/google/home/adonovan/goroot2/src/cmd/go/internal/list/list.go: exit status 2
$ can't create /tmp/go-tool-dist-385632282/cmd/go/internal/run/_go_.a: open /tmp/go-tool-dist-385632282/cmd/go/internal/run/_go_.a: no such file or directory
can't create /tmp/go-tool-dist-385632282/cmd/go/internal/vet/_go_.a: open /tmp/go-tool-dist-385632282/cmd/go/internal/vet/_go_.a: no such file or directory
...

Notice the $ sign appearing in the middle of the output. This indicates that make.bash exited and the shell printed its prompt, but some child process of make.bash is still printing log output.  make.bash should wait for its children to exit before exiting itself.

The error is most likely coming from the compiler.  I'm pretty sure it's because the call to run in runInstall in cmd/dist/build.go will exit the dist tool if the compilation fails, without waiting for any other compilations running in parallel.

I'm going to work on this issue.

@ianlancetaylor - Looked into this. The run actually waits for background processes to finish when fatalf gets called. But it seems there are additional foreground run processes running which need to be waited for.
If I add a simple sync.WaitGroup for every run call and .Wait when fatalf is called, the issue is resolved. But I am wondering if this is the right approach ? We will how have 2 waitgroups - one is already bgHelpers, now we will have fgHelpers. Should we somehow combine all of these into a single waitgroup or look at some alternate solution ?
Or maybe I missed something altogether, please do let me know if that is the case.

Hmmm, this does seem kind of complicated as it seems easy to get into a deadlock situation, in which fatalf is waiting for its own goroutine to complete.  The current code avoids that by having run call bghelpers.Done before calling fatalf, but adding more complexity here will just make things even harer to understand.
In some sense code that is running in a goroutine, like runInstall, ought not to call run.  I suggest that we change the two calls to run in runInstall to call bgrun instead, with a new WaitGroup, and immediately wait for that WaitGroup.  That will push the calls into the existing mechanism.

Cool. We don't even need a new WaitGroup. Since we are immediately waiting, I just moved the same waitgroup above and it worked fine.
Will send a CL.


Add "listreplace" method for patching

Adds the ability to modify certain KH2 lists based on a YAML file. The editable lists are:

03system.bin

Trsr

Item

00battle.bin

Fmlv

Lvup

Bons

Adds the ability to deobfuscate encoded YAML files using Base64 Encoding. This is intended to be used with KH2 Randomizer, so that the source files aren't human readable to prevent cheating.

Test mod link: https://discord.com/channels/409140906625728532/810393223905411133/817009783706091560

Changes Kingdom Key to a 7 / 7 with Second Chance #Item
Changes Garden of Assemblage Map Chest to contain Valor Form #Trsr
Changes experience for level 2 Valor to 1, reward to Fire Element #Fmlv
Changes experience for level 2 Sora to 1, Strength and Magic to 10 #Lvup
Changes Hollow Bastion Bailey "Get Bonus" to Wisdom Form #Bons

All comments marked as "resolved" have been implemented and committed.
lvup changes are on hold for a decision about the data structure of Kh2.Battle.Lvup
Unit tests are in-progress.

I saw you added unit tests. Nice! I suggest to split your test into different smaller tests, each one for every scenario. One for the fmlv, another one for lvup and so on. In this way, if one of the functionalities break it is easier to track back which one of them is causing the test to fail.
Another small issue I suggested on Discord is to rebase your branch upon the one you want to merge to. I am not sure how it will work as you previously merged some stuff in. But try to do a git rebase upstream/feature/openkh-mods-loader after adding git remote add upstream git@github.com:xeeynamo/openkh.git.

It seems that my previous merges have messed up the Git Timeline and the merge gets messy. It may be best for me to close this PR, re-fork, and re-push my changes. Thoughts?
Also, I'll split the various tests.

Closed in favour of #457


take(channel, pattern) support

Hey, I'm working on a PR, but I wanted to run this by you first; the Take effect also has a variant that works with channels. It's fairly trivial to add this to typed-redux-saga's implementation, but since typescript doesn't support generator overloading I had to change it to a function with an IIGE (immediately invoked generator expression :).
export function take<A extends Action>(
  channel: Channel<A>,
  pattern: ActionPattern<A>,
): SagaIterator<A>;
export function take<A extends Action>(
  pattern?: ActionPattern<A>,
): SagaIterator<A>;
export function take<A extends Action>(a?: any, b?: any): SagaIterator<A> {
  return (function*() {
    if (a.take) {
      return yield rawTake(a, b);
    } else {
      return yield rawTake(b);
    }
  })();
}

This changes the type of the export, but not the signature. It's also possible to keep the generator and avoid the overload, but it's really ugly. Are you cool with using a function for the top level export, and if so, should the rest of the exports use the same pattern? In practice, it doesn't change the developer ergonomics re: intellisense.

Sounds great, thanks @parkerault.

Are you cool with using a function for the top level export

Yep

should the rest of the exports use the same pattern?

Probably

IIGE

Has a certain ring to it. ;)

Hey there, I'm trying to mirror the redux-saga call function signature, but the only way I can get it to type check is using this god-awful hack:

export function call<Fn extends AnyFn>(
  fn: Fn,
  ...args: Parameters<Fn>
): SagaIterator<CallResult<ReturnType<Fn>>>;

export function call<Ctx extends AnyProto<Ctx, Name>, Name extends string>(
  ctxAndFnName: [Ctx, Name],
  ...args: Parameters<Ctx[Name]>
): SagaIterator<CallResult<ReturnType<Ctx[Name]>>>;

export function call<Ctx extends AnyProto<Ctx, Name>, Name extends string>(
  ctxAndFnName: { context: Ctx; fn: Name },
  ...args: Parameters<Ctx[Name]>
): SagaIterator<CallResult<ReturnType<Ctx[Name]>>>;

export function call<Ctx, Fn extends AnyMethod<Ctx>>(
  ctxAndFn: [Ctx, Fn],
  ...args: Parameters<Fn>
): SagaIterator<CallResult<ReturnType<Fn>>>;

export function call<Ctx, Fn extends AnyMethod<Ctx>>(
  ctxAndFn: { context: Ctx; fn: Fn },
  ...args: Parameters<Fn>
): SagaIterator<CallResult<ReturnType<Fn>>>;

export function call<
  Fn extends AnyFn,
  Method extends AnyMethod<Ctx>,
  Ctx,
  CtxProto extends AnyProto<CtxProto, Name>,
  Name extends string
>(
  callee: any,
  ...args: any
): SagaIterator<FnCallResult<Fn> | MethodCallResult<CtxProto, Name>> {
  return (function*() {
    if (typeof callee === 'function') {
      return yield rawCall(callee as AnyFn, ...(args as Parameters<Fn>));
    } else if (callee instanceof Array) {
      if (typeof callee[1] === 'function') {
        return yield rawCall(
          callee as [Ctx, Method],
          ...(args as Parameters<Method>),
        );
      } else {
        return yield rawCall(
          callee as [CtxProto, Name],
          ...(args as Parameters<CtxProto[Name]>),
        );
      }
    } else if (callee.fn) {
      if (typeof callee.fn === 'function') {
        return yield rawCall(
          callee as { context: Ctx; fn: Method },
          ...(args as Parameters<Method>),
        );
      } else {
        return yield rawCall(
          callee as { context: CtxProto; fn: Name },
          ...(args as Parameters<CtxProto[Name]>),
        );
      }
    } else {
      return yield rawCall(callee as Fn, ...(args as Parameters<Fn>));
    }
  })();
}

type AnyFn = (...args: any[]) => any;
type AnyMethod<Ctx> = (this: Ctx, ...args: any[]) => any;
type AnyProto<Ctx, Name extends string> = { [P in Name]: AnyMethod<Ctx> };
type FnCallResult<Fn extends AnyFn> = CallResult<ReturnType<Fn>>;
type MethodCallResult<
  Ctx extends AnyProto<Ctx, Name>,
  Name extends string
> = CallResult<ReturnType<Ctx[Name]>>;

// It works:

interface MyInterface {
  foo: number;
  bar: string;
}

function myFn(foo: number, bar: string): Promise<MyInterface> {
  return Promise.resolve({ foo, bar });
}

class myClass {
  myFooBar: MyInterface = { foo: 2, bar: 'zxcv' };
  myMethod(foo: number, bar: string): Promise<MyInterface> {
    this.myFooBar = { foo, bar };
    return this.myOtherMethod();
  }
  myOtherMethod() {
    return Promise.resolve(this.myFooBar);
  }
}

const myInstance = new myClass();
const myMethod = myInstance.myMethod;

function* getItemInventory() {
  // All typed as MyInterface
  const result1 = yield* call(myFn, 1, 'asdf');
  const result2 = yield* call([myInstance, myMethod], 1, 'asdf');
  const result3 = yield* call([myInstance, 'myMethod'], 1, 'asdf');
  const result4 = yield* call({ context: myInstance, fn: myMethod }, 1, 'asdf');
  const result5 = yield* call(
    { context: myInstance, fn: 'myMethod' },
    1,
    'asdf',
  );
}

This is a failed previous attempt, but the compiler complained about the overloads not matching the implementation:
export function call<
  Fn extends AnyFn,
  Method extends AnyMethod<Ctx>,
  Ctx,
  CtxProto extends AnyProto<CtxProto, Name>,
  Name extends string
>(
  callee: Fn
  | [CtxProto, Name]
  | [Ctx, Method]
  | { context: CtxProto; fn: Name }
  | { context: Ctx; fn: Method },
  ...args: Parameters<Fn> | Parameters<CtxProto[Name]>
): SagaIterator<FnCallResult<Fn> | MethodCallResult<CtxProto, Name>> {
  return (function*() {
    return yield rawCall(callee, ...args);
  })()
}

This makes my eyes bleed. Am I missing something obvious? I'm not a typescript expert by any stretch of the imagination, so this is basically a brute force approach. I'm sure there's some elegant way to solve this using some kind of category theory magic. 🧙♂

The more I look at this, the more I'm convinced that this is not the right path. The effect creators in redux saga are incredibly simple; it's the middleware that does all of the heavy lifting. If you take a look at https://github.com/redux-saga/redux-saga/blob/master/packages/core/src/internal/io.js you can see that all we really need to do is some validation on the inputs and return an effect descriptor, which is way less complicated than trying to wrap the vanilla effect creators with typed functions. I am going to work on a POC to see if this approach is feasible.

Any progress on this?

So, I just added this line to index.d.ts:
export declare function take<T>(channel: TakeableChannel<T>, multicastPattern?: Pattern<T>): SagaGenerator<ChannelTakeEffect<T>>;
And this seems to do the trick for my sample. Am I missing something, which makes this more complex?


redirection after login to client application -vue.js with implicit mode.

https://stackoverflow.com/questions/58153118/redirection-not-happening-from-identityserver4-after-login-to-client-vuejs-appli
please have a look , had added all the reuview

Hi the problem is the application stuck on below point
redirecting to /connect/authorize/callback?client_id=Vuejs&redirect_uri=http%3A%2F%2Flocalhost%3A8484%2Flogin&response_type=id_token%20token&scope=openid%20profile%20courses%20roles%20country%20GPSSchoolAPI&state=5b7f679b185642db87a745f649dab48f&nonce=9f222f460a974434a6d0a7179d79765a.
and in

Chrome it gives the message - big header
In IE it stuck and on console of Identity Server4 it say that kesteral server header issue for this Have increased the header size in program.cs
in Mozila it stuck -no message is displayed.
I am not sure what is the issue, have cleared the browser cookies, and also change the port number.
please suggest.

The only place I typically see this error message is when cookies become too big.
This is something you could investigate.

Hi Sir, for that I have cleared the cookies and also changed the port number so that if any previous cookies is left will not be in any use.
please suggest.

Sorry - don't know.

HI @brockallen, Can you p[lease help on this. please.

Hi Santaosh
Your actual cookie size should be no more than 4KB in size. If it is larger than 4KB you will get this issue. If your client app is an MVC one, the cookie authentication middleware has an extensibility point where you can say where you want to store cookie data. So all that will be saved and stored in your cookie is a reference to that data thereby decreasing the size of your cookie.
Hope this helps or at least gives you some insight.
Regards
Farhad

Hi Farhad,
just I have seen that It is creating lots of cookies, but unable to understand from where it is being created, for reference below is the image.

Hi Santosh
Yes, this is internal to ASP.Core authentication doing it. If your cookie data/info is more than 4KB it will create chunks of cookies to hold the data hence the reason you have 'CXXXX' at the end of every cookie. The reason why one would have so many cookie chunks would be because of the amount of data e.g. many claims, you are putting into it.
A suggestion would be reducing the amount of data you adding to the cookie if possible? Maybe look into the concept I mentioned above if storing references in the cookie to data stored somewhere else.
Hope this helps!
Regards
Farhad

Thanks, Actually it was cookies issue. I have removed some Claims and now its running fine.


Add findtag tests

Fixes #54

Codecov Report

Merging #59 (59e3774) into master (e81489e) will increase coverage by 1.85%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master      #59      +/-   ##
============================================
+ Coverage     67.18%   69.04%   +1.85%
- Complexity      460      480      +20
============================================
  Files            86       86
  Lines          1542     1544       +2
  Branches        166      167       +1
============================================
+ Hits           1036     1066      +30
+ Misses          457      429      -28
  Partials         49       49

Impacted Files
Coverage Δ

...ess/model/person/TagContainsKeywordsPredicate.java
100.00% <100.00%> (+100.00%)
:arrow_up:

...a/seedu/address/logic/commands/FindTagCommand.java
100.00% <0.00%> (+100.00%)
:arrow_up:

...edu/address/logic/parser/FindTagCommandParser.java
100.00% <0.00%> (+100.00%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e81489e...59e3774. Read the comment docs.


Room status

Thank you for the great project.
It's really good starting point for me.

when host start playing the game, is there a logic to prevent not joining to the game?

You can set room status to private, so that only people with code can join and it wont show up in the server list. If you want something more than that you will have to write something in mirror to disconnect new clients if the game has started. :)


Event disappear after switching months

I was using this ui-calendar and found a issue that the event will disappear after switching to different months. The same issue happens on the demo here
http://angular-ui.github.io/ui-calendar/
delete some existing event -> add new event -> move the event to a different date -> go to next month -> go back to the current month
Then the new event will disappear. Note that the event is still on the list but just not on the calendar. I have tracked the behavior in the js console, and the source is still correct, but if I do $('#Calendar').fullCalendar( 'clientEvents' ); it does not show up that newly created event.

@linkolen Thanks :)

Same problem for me with fullcalendar 2.2.6 and latest angular ui calendar

Hi, I got this problem and then I modified the onAdded function as @linkolen suggested. It worked, but then I realized that when I dragged and dropped the events, I got this error: TypeError: Converting circular structure to JSON and I noticed that the event object has the "source" attribute which makes the event object have circular structure. Does anybody have the same issue? Or can you suggest a solution for this?

Why not to modify adding events? I added the attribute stick: bool to my events and changed the
eventsWatcher.onAdded = function(event) {
    scope.calendar.fullCalendar('renderEvent', event, event.stick ? event.stick : false);
};

$scope.events.push({ title: 'name', start:'2015-01-01', stick: true});

@anphu7492 I'm getting the same issue with the TypeError using @linkolen suggesting. In fact if I go in to modify the date object at all (i.e. increment the hour) I get that error. Still looking into a fix, either for the original issue that doesn't lead to this error, or a way around this.

Hi @Dlsqueak , Thank you for your suggestion. I also did the same thing. Actually, I deleted the 'source' property whenever I have to do something with the server. :D

@linkolen Your solution works awesome for me. Thanks! (FullCalendar v2.1.1)

you are welcome @jstoddardiv

@linkolen thanks dude!

If you add the event with the stick flag true then the event will stick to the calendar.
CAUTION: The minified version is not working properly. Use the src/calendar.js

var event = {
			title : $scope.newSchedule.expertise.toUpperCase().replace('-','_'),
			start : date,
			end : moment(date).add($scope.newSchedule.duration | 0 , "minutes").toDate(),
			stick : true,
			// expertise : $scope.newSchedule.expertise,
			// type : $scope.newSchedule.type,
			// repeat : $scope.newSchedule.repeat,
		};

Still don't get it working properly. Is there a one complete fix on this issue?

The stick property worked for me. Maybe this issue can be closed.

.```
fullCalendar( 'renderEvent', event [, stick ] )

setting ```stick``` to true, is solved my problem

I am using fullcalendar 2.4.0, latest ui-calendar available in https://github.com/angular-ui/ui-calendar/blob/master/src/calendar.js.
I am fetching new events on clicking next/previous and adding to the $scope.events. I have this logic in  events: function( start, end, callback ) {}, whenever there is change in month, based on some condition, I am pulling the new events.
I used stick: true in the event before adding to $scope.events, still events are gone after changing month.
Any help would be appreciated.
Thanks

The calender is supposed to load monthly events. notice the event persist when switching between different days and weeks within the same month.

stick solved my problem too.

This is a bit of a FAQ of FC itself. Set event to stick. FC author explains his rationale on #353 .

stick as true solved my problem too.

Thanks @angelix and @linkolen. Both suggestions works. I prefer the one by angelix.

@linkolen  thanks... worked for me too

When you paste stick: true to your event object you also need to add option when call renderEvent
$(fullCalendar).fullCalendar('renderEvent', event, true);`

$scope.getAllTimelineByPOID = function (PurchaseOrderID) {
timelineService.getAllTimelineByPOID(PurchaseOrderID).then(function (res) {
if (res.data.length > 0) {
$scope.timelineList = formatDate(res.data, '', ["PlannedDate", 'ActualDate', 'LastModified']);
var calenderval = res.data;
//Cache= true;
angular.forEach(calenderval, /stick,/ function (value) {
$scope.events.push({
title: value.Description,
start: value.ActualDate
//Cache: true
//stick: true
//end: value.ActualDate,
//allDay: false
                });
            });
            $scope.eventSources = [$scope.events];
            console.log($scope.eventSources);

            for (var i = 0; i < $scope.timelineList.length; i++) {
                $scope.timelineList[i].ActualDate = new Date($scope.timelineList[i].ActualDate);
                $scope.timelineList[i].LastModified = new Date($scope.timelineList[i].LastModified);
            }
        }
        else {
            $scope.timelineList.push($scope.timeline);
        }
    });
};

i'm facing same problem , help me out

Still don't get it working properly. Is there a one complete fix on this issue?

i'm also looking for it


Cartfile dependence version should update.

Update the version to support ios 8.0.

Hi, @ufosky. Could you please clarify what do you mean by dependence version?

Hi, @sergdort. The project deployment version is 9.0 and 10.0 like here: https://github.com/RxSwiftCommunity/RxAlamofire/blob/master/_.xcodeproj/project.pbxproj#L403
. You can search with word IPHONEOS_DEPLOYMENT_TARGET , it makes the framework cannot be used in project which deployment version is 8.0.


Add support for selected fields to blob get and list

This follows from #193. Main changes are:

Add AclField and BlobField classes to Storage
Add BlobGetOption class to Storage that supports the .fields option
Use BlobGetOption in Storage.get instead of BlobSourceOption
Add .fields option to BlobListOption
Update Blob.exists to use selected fields
Use BlobGetOption in BatchRequest.toGet instead of BlobSourceOption
Add unit and integration tests for selected fields

Looks good!
I think, for simplicity, we should reconsider ACL specific fields (the same way we don't expose owner specific fields). I don't even know how patch would work in such case.
Also, if we do so, I wonder if we could just have an enum instead of the BlobField and EntityField classes.
Providing an option to select fields for buckets (and having a BucketGetOption) would be nice too (and if we go with it, I would also suggest to expose only the high-level fields such as acl, lifecycle, cors and not, e.g. cors/maxAgeSeconds).

I addressed the comments. I removed AclField so that we only deal with first level fields and made BlobField an enum.  I also added support for selected fields to bucket get and list.

Nice, I like it much better.
Few nits and one potential bug regarding bucket get/listing.

I fixed the comments, thanks for the careful review.

I will need to rebase this to fix conflicts. Please let me know if you are reviewing this, otherwise I'll rebase it first.

@mziccard go ahead and re-base and let me know when ready for re-review.

@aozarov Rebased and updated according to your last comment.


typography and docs revamp

Figma reference/Github issue
https://www.figma.com/file/0vYcLbHGHFIJ44hFI45WQJ/🚀-Habitat?type=design&node-id=2151-5623&mode=dev
https://www.figma.com/file/0vYcLbHGHFIJ44hFI45WQJ/🚀-Habitat?type=design&node-id=0-1&mode=dev
What

adding the spacing tokens in the vars object
adding <H5 />, <H6 /> and <Inline /> componetns for the typography
adding margins in every typography component
adding a new "showcase" page for all of the typography components
complete redesign of the Colors page
updated existing components and stories to adjust to the new spacings and margins
updated the docs
updated the dependencies

please add some feedbacks if you think the noMargin prop could use a better name 😄


Ambiguity in the acc.

Hi @Solacex
Can you please tell me what "Acc." refers to in table 1. It would be great if you could tell how to calculate that exactly.
Is it OS or OS* as defined in prior works or is it something else?
Thanks!

For table 1, the acc is defined as the average over both known and unknown classes.


CNDB-10966 main: Add ability to read the TTLs and write times of the elements of a collection/UDT

Port of DB-1289/CASSANDRA-8877.

Thanks for the review.
I think I have addressed them all te comments.
I have also fixed some of the Sonar issues, but not the ones about the complexity of the AbstractMapSerializer methods. We have been using those for a long time and here we are just moving them around, so I think it's probably better not to touch them too much.
Regarding coverage, I don't know what's the threshold but it seems green at 87.6% in the report. Some of those methods are throwing assertion/unsupported errors because they are supposed to be unreachable. It doesn't seem very useful to create an artificial test to force reaching them.


Add CameraView

Part of #12
Docs for Toolkit PR 244
What changes to the docs does this PR provide?
Very basic docs and description of the members of CameraView
PR Checklist
Please check if your PR fulfills the following requirements:

[x] For new pages, used the provided template.
[x] For new features, added an entry in the Table of Contents.
[x] Ran against a spell and grammar checker.
[x] Contains NO breaking changes.

Other information

Docs Build status updates of commit f7636bb:
:warning: Validation status: warnings

File
Status
Preview URL
Details

docs/views/cameraview.md
:warning:Warning
View
Details

docs/TOC.yml
:white_check_mark:Succeeded
View

docs/views/cameraview.md

Line 46, Column 20: [Warning-xref-not-found] Cross reference not found: 'Xamarin.Forms.ICommand'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit e8bfd0e:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/TOC.yml
:white_check_mark:Succeeded
View

docs/views/cameraview.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit e55ca8a:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/TOC.yml
:white_check_mark:Succeeded
View

docs/views/cameraview.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


feat(schematic): fds-1688 add endpoints that return files

fixes FDS-1688
Adds endpoints that return csv files
Please review

all files in libs/schematic/api-description/src/
all files in apps/schematic/api/schematic_api/controllers/  except  storage_controller.py

How is this PR different from #2500 (same title and description)

It may be because of this new branch protection rule: reviewers must approve the latest version of the code submitted. Here, you have made modification after @GiaJordan's review.

This is stated below. GitHub could do a better job at invalidating reviews.

@GiaJordan Could you re-approve? I made on change to fix the schema used for tests from the develop to main version.


Minor edits for annotations.md

The annotation for the attribute “status.data.url” is fixed
service.binding has been changed to servicebinding for annotations in compliance with the previous annotation format.

thanks @Avni-Sharma - you'll probably need to rebase this PR once PR #48 goes through, since that restructures where the annotations are placed.

How does the servicebinding naming come about?  Elsewhere in the spec it's pretty consistently service.binding which was why I changed it previously (consistency ruling).  Is that naming convention (the removal of punctuation) common in OLM?

that's a good question @nebhale.  Maybe @sbose78 or @Avni-Sharma know more details, but as far as I know there isn't much guidance on custom x-descriptors notations.
There's a set of built-in x-descriptors that OCP's UI renders into a more user friendly form, but I haven't seen official docs that prescribe how to consistently extend it.  But the built-in types definitely have dots in their name, so I would say +1 for using service.binding for consistency.

Yeah, closing the PR as I am in consensus with the above comments.


Highlight entire line if a change is detected

@arnab great work, PrettyTextDiff is awesome!
I was wondering if it's possible to shade an entire line if a change is detected on the line:

Notice how the change is only visible after scrolling:

Thanks for any insight!

Hi @mgibbs189 - thanks for the kind words.
You can use jQuery's has selector to look for your diff-container containing <ins> and <del> elements and style those. An example:
$(".diff-container:has(ins)").addClass("has-diff");

Does that work?

@arnab That code snippet looks like it'd highlight the entire diff body, even if only 1 line contains changes. I'm trying to highlight only the actual lines with changes.
E.g. from the first screenshot, [active_plugins] is its own line, same goes for [blog_charset].
Maybe I'm over-thinking this, and it'd be best to just add word-wrap: break-word and call it a day :smile:

What I mean is this library will add <ins> and <del> into the changing containers. So if you have every line in a separate DOM element, you can use the presence of ins/del to detect changing lines.
Sounds like you don't though. In that case, yeah, word-wrap might be the answer. UX wise too, it'd probably be easier to scan when you don't have to scan at all.

Agreed, thanks for the feedback


The API of Coz deprecated???

fullNodeAPI = "http://api.wallet.cityofzion.io/v2/"
enum apiURL: String {
case getBalance = "address/balance/"
case getClaims = "address/claims/"
case getTransactionHistory = "address/history/"
}
These API maybe deprecated, it failed when I called some func in NeoClient.

It seems to be deprecated, I am moving to new API's shortly, probably today

https://github.com/CityOfZion/neo-swift/pull/109


Hide "open in windows terminal" options in right-click menu

Now the installer(v1.7) will forcefully appear "open in windows terminal" in menu. But I think it’s better to appear on the shift + right-click menu. I can't find a way to achieve it, so I hope the program can provide such an option.

no implementation details

This may be a duplicate of https://github.com/microsoft/terminal/issues/6113. That one already has the pull request https://github.com/microsoft/terminal/pull/9358 implementing it but perhaps they want to add a configuration option before merging.

Thanks for the suggestion! Please make sure to search for duplicates when filing new issues. This is already being tracked by another issue on our repo - please refer to #6113 for more discussion.
/dup #6113
/dup #8105


Cannot get Update XML file attribute to work

VSTS Extension you are using
FileUtilities/XmlFileUpdateTask
Where are you running it?
on-premise TFS 2017.2
Version of Extension/Task
3.1.2
Expected behaviour and actual behaviour
Trying to set appSetting value in web.config.
 exists in the file.
Stops with [error]Unhandled: Cannot read property 'attributes' of null.  Build log is below with parameters.
2018-03-08T23:43:11.1454938Z ==============================================================================
2018-03-08T23:43:11.1454938Z Task         : Update XML file attribute
2018-03-08T23:43:11.1454938Z Description  : Update an attribute in an Xml file based on XPath filter
2018-03-08T23:43:11.1454938Z Version      : 3.1.2
2018-03-08T23:43:11.1454938Z Author       : Black Marble
2018-03-08T23:43:11.1454938Z Help         : Version: 3.1.2. More Information
2018-03-08T23:43:11.1454938Z ==============================================================================
2018-03-08T23:43:11.4423685Z Param: filename - E:\Agent_work\2\a/Dev/for-deploy/website/Web.config
2018-03-08T23:43:11.4423685Z Param: recurse - true
2018-03-08T23:43:11.4423685Z Param: xpath - /configuration/appSettings/add[@key='BuildVersion']
2018-03-08T23:43:11.4423685Z Param: attribute - value
2018-03-08T23:43:11.4423685Z Param: value - 20180308.7
2018-03-08T23:43:11.5048781Z ##[error]Unhandled: Cannot read property 'attributes' of null
Steps to reproduce the problem

I think we need a bit more debug information to move this one forward.
Please set the build variable of system.debug = true this will give a far more detailed log showing all the input parameters and steps taken.
Also is can I confirm the BuildVersion key is present in the web.config present prior to running the script?
i.e. are you trying to update the entry not add it.

Yes, 'add key="BuildVersion" value=""' exists in the web.config.  I tried to put that in my original message but the angle brackets caused it to disappear from the message.  Below is the debug output.
The debug output told me what the problem is:
I have the "recurse" value unchecked, and the first debug line mentioning it confirms that value, but later the value has changed to true. This is an MVC project so there are 2 web.config files, one at the root and one in the Views subdirectory (both are required). Only the root contains the appSetting and should be modified.  For testing purposes I removed the Views\web.config file and then the Update XML worked!
So it is the recurse flag ending up true that is causing the problem.
2018-03-09T15:51:50.3228157Z ##[debug]Evaluating condition for step: 'Set Build Version'
2018-03-09T15:51:50.3228157Z ##[debug]Evaluating: succeeded()
2018-03-09T15:51:50.3228157Z ##[debug]Evaluating succeeded:
2018-03-09T15:51:50.3228157Z ##[debug]=> (Boolean) True
2018-03-09T15:51:50.3228157Z ##[debug]Expanded: True
2018-03-09T15:51:50.3228157Z ##[debug]Result: True
2018-03-09T15:51:50.3228157Z ##[section]Starting: Set Build Version
2018-03-09T15:51:50.3228157Z ==============================================================================
2018-03-09T15:51:50.3228157Z Task         : Update XML file attribute
2018-03-09T15:51:50.3228157Z Description  : Update an attribute in an Xml file based on XPath filter
2018-03-09T15:51:50.3228157Z Version      : 3.1.2
2018-03-09T15:51:50.3228157Z Author       : Black Marble
2018-03-09T15:51:50.3228157Z Help         : Version: 3.1.2. More Information
2018-03-09T15:51:50.3228157Z ==============================================================================
2018-03-09T15:51:50.6040748Z ##[debug]agent.workFolder=E:\Agent_work
2018-03-09T15:51:50.6040748Z ##[debug]loading inputs and endpoints
2018-03-09T15:51:50.6040748Z ##[debug]loading ENDPOINT_AUTH_PARAMETER_SYSTEMVSSCONNECTION_ACCESSTOKEN
2018-03-09T15:51:50.6040748Z ##[debug]loading ENDPOINT_AUTH_SCHEME_SYSTEMVSSCONNECTION
2018-03-09T15:51:50.6040748Z ##[debug]loading ENDPOINT_AUTH_SYSTEMVSSCONNECTION
2018-03-09T15:51:50.6040748Z ##[debug]loading INPUT_ATTRIBUTE
2018-03-09T15:51:50.6040748Z ##[debug]loading INPUT_FILENAME
2018-03-09T15:51:50.6040748Z ##[debug]loading INPUT_RECURSE
2018-03-09T15:51:50.6040748Z ##[debug]loading INPUT_VALUE
2018-03-09T15:51:50.6040748Z ##[debug]loading INPUT_XPATH
2018-03-09T15:51:50.6040748Z ##[debug]loaded 8
2018-03-09T15:51:50.6040748Z ##[debug]filename=E:\Agent_work\2\a\Dev\for-deploy\website\Web.config
2018-03-09T15:51:50.6040748Z ##[debug]xpath=/configuration/appSettings/add[@key='BuildVersion']
2018-03-09T15:51:50.6040748Z ##[debug]attribute=value
2018-03-09T15:51:50.6040748Z ##[debug]value=20180309.3
2018-03-09T15:51:50.6040748Z ##[debug]recurse=false
2018-03-09T15:51:50.6040748Z Param: filename - E:\Agent_work\2\a\Dev\for-deploy\website\Web.config
2018-03-09T15:51:50.6040748Z Param: recurse - true
2018-03-09T15:51:50.6040748Z Param: xpath - /configuration/appSettings/add[@key='BuildVersion']
2018-03-09T15:51:50.6040748Z Param: attribute - value
2018-03-09T15:51:50.6040748Z Param: value - 20180309.3
2018-03-09T15:51:50.6196909Z ##[debug]Looking in folder [E:\Agent_work\2\a\Dev\for-deploy\website] for files that match pattern [Web.config] using recursion [true]
2018-03-09T15:51:50.6665798Z ##[debug]task result: Failed
2018-03-09T15:51:50.6665798Z ##[error]Unhandled: Cannot read property 'attributes' of null
2018-03-09T15:51:50.6665798Z ##[debug]Processed: ##vso[task.issue type=error;]Unhandled: Cannot read property 'attributes' of null
2018-03-09T15:51:50.6665798Z ##[debug]Processed: ##vso[task.complete result=Failed;]Unhandled: Cannot read property 'attributes' of null
2018-03-09T15:51:50.6821936Z ##[section]Finishing: Set Build Version

Great sounds like you are unblocked then?

No, I need the recurse flag fixed.  I must have both web.config files so I cannot use this task as long as it insists on doing a recursive search.

OK I will look into it

There was a problem with the Boolean parameter parsing, this has been fixed in 3.2.2. I also revised the unit tests
Can you confirm this works for you

I appear to only have permission to install from the Marketplace, so I can't verify this fix until it's published.  I'm sure if the unit tests now check it, it will be fine. Thank you for your quick response.

OK I will close the issue, re-open it if you find the problem is not fixed.
The summary of the problem was that there was meant to be a unit test to check recursion processing, but it checked the ProcessFiles() function, this took the recurse parameter as a boolean, and all was OK when it was run (though I did improve the checking on the test). The issue was that the recurse parameter is passed as a string by VSTS into the tasks and the conversion of this value was failing.
I have now moved the conversion inside the ProcessFiles() function so it can be tested by the existing unit tests - much more robust


Where is the base.py?

When I run train.sh or main.py to trian a diffusion model, it has an error:
File "main.py", line 21, in
from ldm.data.base import Txt2ImgIterableBaseDataset
ModuleNotFoundError: No module named 'ldm.data.base'
I found that there is not a base.py file in the path of ./ldm/data/, maybe you forget to upload this file? Can I use the files in the paint-by-examples project directly? Did you modify this file in the paint-by-example?

Hi, just delete it, we will fix it soon. Thank you for your reminder!


[rom_e2e,dv] add more keymgr_init tests to DV

This PR contains two commits that:

add the variations of the keymgr_init ROM E2E test were added for the FPGA/Verilator platforms in #16357
removes a duplicate keymgr_init test.

This fixes #16370.

While reviewing this PR I went through a whole journey imagining: "Hey this looks like exactly what I need to do for those tests I need to add to DV"
"Hmm, what were those tests called again?"
"oh"
Anyway,
Thanks Tim!


Adding multithreaded pull of vtt info

On channels that have 100s or 1000s of videos, pulling vtt info can take a long time.
With this patch I added pulling vtt info using multithreading.
You can set number of jobs using "number-of-jobs".
It`s not ideal patch code wise, so feel free to edit it.
BTW great initiative :)

For even better multithreading, also the processing to db part should be parallelized.

So nice. 16 jobs and just brought in 1600 video subtitles in less than 10 minutes. Download was lightning fast: https://www.youtube.com/@YaleCourses.

Thank you, making this one it's own branch https://github.com/NotJoeMartinez/yt-fts/tree/multithreading_vtt


PHOENIX-5508 - ALTER INDEX REBUILD removes all rows from a simple glo…

…bal index

Note that the changes to PostDDLCompiler are just IDE refactoring the two giant anonymous classes to inner classes to make it easier to understand the code flow.


eccodes: 2.6.0 -> 2.7.0

Semi-automatic update generated by https://github.com/ryantm/nix-update tools. These checks were done:

built on NixOS
ran /nix/store/bfvhxcjlapkmg74v72z65csmqbpdy3fx-eccodes-2.7.0/bin/codes_info -v and found version 2.7.0
ran /nix/store/bfvhxcjlapkmg74v72z65csmqbpdy3fx-eccodes-2.7.0/bin/grib_histogram -h got 0 exit code
ran /nix/store/bfvhxcjlapkmg74v72z65csmqbpdy3fx-eccodes-2.7.0/bin/grib_histogram --help got 0 exit code
ran /nix/store/bfvhxcjlapkmg74v72z65csmqbpdy3fx-eccodes-2.7.0/bin/grib_filter -V and found version 2.7.0
ran /nix/store/bfvhxcjlapkmg74v72z65csmqbpdy3fx-eccodes-2.7.0/bin/grib_ls -V and found version 2.7.0
ran /nix/store/bfvhxcjlapkmg74v72z65csmqbpdy3fx-eccodes-2.7.0/bin/grib_dump -V and found version 2.7.0
ran /nix/store/bfvhxcjlapkmg74v72z65csmqbpdy3fx-eccodes-2.7.0/bin/grib_merge -V and found version 2.7.0
ran /nix/store/bfvhxcjlapkmg74v72z65csmqbpdy3fx-eccodes-2.7.0/bin/grib2ppm -h got 0 exit code
ran /nix/store/bfvhxcjlapkmg74v72z65csmqbpdy3fx-eccodes-2.7.0/bin/grib2ppm --help got 0 exit code
ran /nix/store/bfvhxcjlapkmg74v72z65csmqbpdy3fx-eccodes-2.7.0/bin/grib_set -V and found version 2.7.0
ran /nix/store/bfvhxcjlapkmg74v72z65csmqbpdy3fx-eccodes-2.7.0/bin/grib_get -V and found version 2.7.0
ran /nix/store/bfvhxcjlapkmg74v72z65csmqbpdy3fx-eccodes-2.7.0/bin/grib_get_data -V and found version 2.7.0
ran /nix/store/bfvhxcjlapkmg74v72z65csmqbpdy3fx-eccodes-2.7.0/bin/grib_copy -V and found version 2.7.0
ran /nix/store/bfvhxcjlapkmg74v72z65csmqbpdy3fx-eccodes-2.7.0/bin/grib_compare -V and found version 2.7.0
ran /nix/store/bfvhxcjlapkmg74v72z65csmqbpdy3fx-eccodes-2.7.0/bin/grib_index_build help got 0 exit code
ran /nix/store/bfvhxcjlapkmg74v72z65csmqbpdy3fx-eccodes-2.7.0/bin/grib_index_build -V and found version 2.7.0
ran /nix/store/bfvhxcjlapkmg74v72z65csmqbpdy3fx-eccodes-2.7.0/bin/bufr_ls -V and found version 2.7.0
ran /nix/store/bfvhxcjlapkmg74v72z65csmqbpdy3fx-eccodes-2.7.0/bin/bufr_dump -V and found version 2.7.0
ran /nix/store/bfvhxcjlapkmg74v72z65csmqbpdy3fx-eccodes-2.7.0/bin/bufr_set -V and found version 2.7.0
ran /nix/store/bfvhxcjlapkmg74v72z65csmqbpdy3fx-eccodes-2.7.0/bin/bufr_get -V and found version 2.7.0
ran /nix/store/bfvhxcjlapkmg74v72z65csmqbpdy3fx-eccodes-2.7.0/bin/bufr_copy -V and found version 2.7.0
ran /nix/store/bfvhxcjlapkmg74v72z65csmqbpdy3fx-eccodes-2.7.0/bin/bufr_compare -V and found version 2.7.0
ran /nix/store/bfvhxcjlapkmg74v72z65csmqbpdy3fx-eccodes-2.7.0/bin/bufr_index_build help got 0 exit code
ran /nix/store/bfvhxcjlapkmg74v72z65csmqbpdy3fx-eccodes-2.7.0/bin/bufr_index_build -V and found version 2.7.0
ran /nix/store/bfvhxcjlapkmg74v72z65csmqbpdy3fx-eccodes-2.7.0/bin/gts_get -V and found version 2.7.0
ran /nix/store/bfvhxcjlapkmg74v72z65csmqbpdy3fx-eccodes-2.7.0/bin/gts_compare -V and found version 2.7.0
ran /nix/store/bfvhxcjlapkmg74v72z65csmqbpdy3fx-eccodes-2.7.0/bin/gts_copy -V and found version 2.7.0
ran /nix/store/bfvhxcjlapkmg74v72z65csmqbpdy3fx-eccodes-2.7.0/bin/gts_dump -V and found version 2.7.0
ran /nix/store/bfvhxcjlapkmg74v72z65csmqbpdy3fx-eccodes-2.7.0/bin/gts_filter -V and found version 2.7.0
ran /nix/store/bfvhxcjlapkmg74v72z65csmqbpdy3fx-eccodes-2.7.0/bin/gts_ls -V and found version 2.7.0
ran /nix/store/bfvhxcjlapkmg74v72z65csmqbpdy3fx-eccodes-2.7.0/bin/metar_dump -V and found version 2.7.0
ran /nix/store/bfvhxcjlapkmg74v72z65csmqbpdy3fx-eccodes-2.7.0/bin/metar_ls -V and found version 2.7.0
ran /nix/store/bfvhxcjlapkmg74v72z65csmqbpdy3fx-eccodes-2.7.0/bin/metar_compare -V and found version 2.7.0
ran /nix/store/bfvhxcjlapkmg74v72z65csmqbpdy3fx-eccodes-2.7.0/bin/metar_get -V and found version 2.7.0
ran /nix/store/bfvhxcjlapkmg74v72z65csmqbpdy3fx-eccodes-2.7.0/bin/metar_filter -V and found version 2.7.0
ran /nix/store/bfvhxcjlapkmg74v72z65csmqbpdy3fx-eccodes-2.7.0/bin/metar_copy -V and found version 2.7.0
ran /nix/store/bfvhxcjlapkmg74v72z65csmqbpdy3fx-eccodes-2.7.0/bin/grib_to_netcdf -V and found version 2.7.0
ran /nix/store/bfvhxcjlapkmg74v72z65csmqbpdy3fx-eccodes-2.7.0/bin/codes_bufr_filter -V and found version 2.7.0
ran /nix/store/bfvhxcjlapkmg74v72z65csmqbpdy3fx-eccodes-2.7.0/bin/bufr_filter -V and found version 2.7.0
found 2.7.0 with grep in /nix/store/bfvhxcjlapkmg74v72z65csmqbpdy3fx-eccodes-2.7.0

cc @knedlsepp for review

Success on x86_64-darwin (full log)
Attempted: eccodes
Partial log (click to expand)
-- Installing: /nix/store/1000x355yn3c6wrl23y3r8raw30d61h5-eccodes-2.7.0/share/eccodes/ifs_samples/grib1_mlgrib2_ieee64/sh_ml_grib2.tmpl
-- Installing: /nix/store/1000x355yn3c6wrl23y3r8raw30d61h5-eccodes-2.7.0/share/eccodes/ifs_samples/grib1_mlgrib2_ieee64/sh_pl_grib1.tmpl
-- Installing: /nix/store/1000x355yn3c6wrl23y3r8raw30d61h5-eccodes-2.7.0/share/eccodes/ifs_samples/grib1_mlgrib2_ieee64/sh_pl_grib2.tmpl
-- Installing: /nix/store/1000x355yn3c6wrl23y3r8raw30d61h5-eccodes-2.7.0/share/eccodes/ifs_samples/grib1_mlgrib2_ieee64/sh_sfc_grib1.tmpl
-- Installing: /nix/store/1000x355yn3c6wrl23y3r8raw30d61h5-eccodes-2.7.0/share/eccodes/ifs_samples/grib1_mlgrib2_ieee64/sh_sfc_grib2.tmpl
post-installation fixup
strip is /nix/store/vb6mgjqgd9h11nbv60fvrp1ls9nxck2y-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/1000x355yn3c6wrl23y3r8raw30d61h5-eccodes-2.7.0/lib  /nix/store/1000x355yn3c6wrl23y3r8raw30d61h5-eccodes-2.7.0/bin
patching script interpreter paths in /nix/store/1000x355yn3c6wrl23y3r8raw30d61h5-eccodes-2.7.0
/nix/store/1000x355yn3c6wrl23y3r8raw30d61h5-eccodes-2.7.0/bin/bufr_filter: interpreter directive changed from "/bin/sh" to "/nix/store/8hdxjv3m14jgdnawi5l0mz2h59qkk2g9-bash-4.4-p19/bin/sh"

Success on aarch64-linux (full log)
Attempted: eccodes
Partial log (click to expand)
shrinking /nix/store/lbp4yb4jv1xw14qzmkwk9a8w0f56nwrl-eccodes-2.7.0/bin/codes_count
shrinking /nix/store/lbp4yb4jv1xw14qzmkwk9a8w0f56nwrl-eccodes-2.7.0/bin/codes_info
shrinking /nix/store/lbp4yb4jv1xw14qzmkwk9a8w0f56nwrl-eccodes-2.7.0/lib/libeccodes_f90.so
shrinking /nix/store/lbp4yb4jv1xw14qzmkwk9a8w0f56nwrl-eccodes-2.7.0/lib/libeccodes.so
strip is /nix/store/3zq400fri5dv7d30lpxlqm2v9y1iis6j-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/lbp4yb4jv1xw14qzmkwk9a8w0f56nwrl-eccodes-2.7.0/lib  /nix/store/lbp4yb4jv1xw14qzmkwk9a8w0f56nwrl-eccodes-2.7.0/bin
patching script interpreter paths in /nix/store/lbp4yb4jv1xw14qzmkwk9a8w0f56nwrl-eccodes-2.7.0
/nix/store/lbp4yb4jv1xw14qzmkwk9a8w0f56nwrl-eccodes-2.7.0/bin/bufr_filter: interpreter directive changed from "/bin/sh" to "/nix/store/3gg2p6n4kv2f0lsxd41f5iz1ivkbzyzr-bash-4.4-p19/bin/sh"
checking for references to /build in /nix/store/lbp4yb4jv1xw14qzmkwk9a8w0f56nwrl-eccodes-2.7.0...
/nix/store/lbp4yb4jv1xw14qzmkwk9a8w0f56nwrl-eccodes-2.7.0

Success on x86_64-linux (full log)
Attempted: eccodes
Partial log (click to expand)
shrinking /nix/store/bfvhxcjlapkmg74v72z65csmqbpdy3fx-eccodes-2.7.0/bin/grib_copy
shrinking /nix/store/bfvhxcjlapkmg74v72z65csmqbpdy3fx-eccodes-2.7.0/bin/metar_compare
shrinking /nix/store/bfvhxcjlapkmg74v72z65csmqbpdy3fx-eccodes-2.7.0/lib/libeccodes.so
shrinking /nix/store/bfvhxcjlapkmg74v72z65csmqbpdy3fx-eccodes-2.7.0/lib/libeccodes_f90.so
strip is /nix/store/fzcs0fn6bb04m82frhlb78nc03ny3w55-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/bfvhxcjlapkmg74v72z65csmqbpdy3fx-eccodes-2.7.0/lib  /nix/store/bfvhxcjlapkmg74v72z65csmqbpdy3fx-eccodes-2.7.0/bin
patching script interpreter paths in /nix/store/bfvhxcjlapkmg74v72z65csmqbpdy3fx-eccodes-2.7.0
/nix/store/bfvhxcjlapkmg74v72z65csmqbpdy3fx-eccodes-2.7.0/bin/bufr_filter: interpreter directive changed from "/bin/sh" to "/nix/store/q1g0rl8zfmz7r371fp5p42p4acmv297d-bash-4.4-p19/bin/sh"
checking for references to /build in /nix/store/bfvhxcjlapkmg74v72z65csmqbpdy3fx-eccodes-2.7.0...
/nix/store/bfvhxcjlapkmg74v72z65csmqbpdy3fx-eccodes-2.7.0

👍


Re-land "[Dispatch] extend CollapseDimensionsPass to more…"

Re-lands https://github.com/iree-org/iree/pull/19326 after adding a few more matmul specs that were missed. I left @match_mmt_8192x640x2560 commented out because the config was causing a slight regression in perf but the overall time spent was very low.
This reverts commit 7177c29.

I don't see any sdxl regressions @raikonenfnu @nithinsubbiah could you confirm this?

Merging with main to fix ci_summary

@IanWood1 can you decreased the UNet bound to 51ms here https://github.com/iree-org/iree/blob/main/.github/workflows/pkgci_regression_test.yml#L251 and here https://github.com/iree-org/iree/blob/main/.github/workflows/pkgci_regression_test.yml#L254


Implement GNB component

Todo

[x] Main menu categories

ETC

Opinions & Problems

Didn't yet done with react-routes


How to use this with TypeScript?

So, TypeScript uses modules for better typing.
If I want to import my TypeScript file, I could import it with import foo from './bar';. TypeScript checks the path, recognizes the file bar.ts and could retrieve information about the typings of foo.
However, if I want to import images, I have to tell TypeScript about those images and declare own modules like declare module '*.jpg';. See this link for further information.
But now comes the catch. I can import my images with
import testImage from 'images/test.jpg';`

just fine. But if I want to pass some queries (like resize it to 500px width and change the format to webp) , I have to alter this import.
import testImage from 'images/test.jpg?{"width":500, "format": "webp"}';`

But now TypeScript modules kick in and fail with Cannot find module 'images/test.jpg?{"width":500, "format": "webp"}' or its corresponding type declarations..
If I tell TypeScript about this module with
declare module '*.jpg?{"width":500, "format": "webp"}';

then this code works fine. The image gets resized, the format changes to webp. But as you can imagine, I don't want to declare modules for every possible image alteration.
Do you know a way to deal with this problem?

Unfortunately it seems like you'll have to do that or use // @ts-ignore.
Typescript only allows 1 wildcard in a declaration so declare module '*.jpg?*' isn't possible (see: https://stackoverflow.com/questions/56078811/how-can-i-use-multiple-wildcards-in-typescript-module-declarations)

I used this declaration now: declare module '*"format": "webp"}';
This also enables me to write stuff like import blorg from 'images/blorg.png?{"quality": 70, "format": "webp"}';. It might not be the perfect solution, but it works with low efforts.


update voltron views on specific breakpoint without stoping

I tried to update the voltron panels everytime the program hit thw breakpoint 0x402276 but without stopping the execution using the follow gdb script:
script.txt
break *0x402276

commands
silent
continue
end

continue

However voltron still showing the message Target busy.
Is there a command that a can use to automatic update the voltron views without pausing the execution?
Is there a better way to accomplish this?

Same, I'm using LLDB on macOS.

If you add a voltron update to your script that should do the trick