Prints environment variables added/removed to a component by doing odo link/unlink

What is the purpose of this change? What does it change?

This PR prints the environment variables that are added or removed from a component as a result of odo link or odo unlink operation.
Was the change discussed in an issue?
fixes #1964

How to test changes?

Build the binary
Start a service:$ odo service create dh-postgresql-apb dh-postgresql-apb --plan dev -p postgresql_database=mydata -p postgresql_password=secret -p postgresql_user=luke -p postgresql_version=10

Create a component, push it and link the service created above to the component:$ odo link dh-postgresql-apb
✓  Service dh-postgresql-apb has been successfully linked from the component nodejs-nodejs-ex-kyvs

Following environment variables were added to nodejs-nodejs-ex-kyvs component:
- DB_PORT
- DB_TYPE
- DB_USER
- DB_HOST
- DB_NAME
- DB_PASSWORD

Similarly, create another component and link the two components$ odo link component2

Environment variables should be printed on stdout

Re-ran the tests
Other than one comment. Looks good
/approve

/retest
[odo]  ✗  Unable to connect to OpenShift cluster, is it down?

/retest
[odo] I0902 11:21:12.399007   14516 preference.go:118] The path for preference file is /tmp/037321574/config.yaml
[odo] I0902 11:21:12.399073   14516 occlient.go:478] Trying to connect to server api.ci-op-9600ps7s-f09f4.origin-ci-int-aws.dev.rhcloud.com:6443
[odo] I0902 11:21:12.413751   14516 occlient.go:485] Server https://api.ci-op-9600ps7s-f09f4.origin-ci-int-aws.dev.rhcloud.com:6443 is up
[odo] I0902 11:21:12.490646   14516 occlient.go:408] isLoggedIn err:  <nil>
[odo]  output: "developer"
[odo]  •  Waiting for project to come up  ...
[odo]  ✓  Waiting for project to come up [386ms]
[odo]  ✓  Project 'ygbqtbxmwa' is ready for use
[odo]  ✓  New project created and now using project : ygbqtbxmwa
[odo] I0902 11:21:12.904952   14516 odo.go:70] Could not get the latest release information in time. Never mind, exiting gracefully :)
Running odo with args [odo project create ghrrnu -o json]
[odo] {"kind":"Project","apiVersion":"odo.openshift.io/v1alpha1","metadata":{"name":"ghrrnu","namespace":"ghrrnu","creationTimestamp":null},"message":"Project 'ghrrnu' is ready for use"}
Running odo with args [odo project delete ghrrnu -o json]
[odo] {"kind":"Error","apiVersion":"odo.openshift.io/v1alpha1","metadata":{"creationTimestamp":null},"message":"The project ghrrnu does not exist. Please check the list of projects using `odo project list`"}
Deleting project: ygbqtbxmwa
Running odo with args [odo project delete ygbqtbxmwa -f]
[odo]  ✗  The project ygbqtbxmwa does not exist. Please check the list of projects using `odo project list`
 • Failure [1.148 seconds]
odojsonoutput
/go/src/github.com/openshift/odo/tests/integration/json_test.go:16
  Delete the project and output json output
  /go/src/github.com/openshift/odo/tests/integration/json_test.go:37
    should be able to delete project and show output in json format [It]

/lgtm

@dharmit the tests are failing for 4hrs, can you please take a look?

/hold

A lot of different failures
Created dir: /tmp/037321574
Creating a new project: ygbqtbxmwa
Running odo with args [odo project create ygbqtbxmwa -w -v4]
[odo] I0902 11:21:12.399007   14516 preference.go:118] The path for preference file is /tmp/037321574/config.yaml
[odo] I0902 11:21:12.399073   14516 occlient.go:478] Trying to connect to server api.ci-op-9600ps7s-f09f4.origin-ci-int-aws.dev.rhcloud.com:6443
[odo] I0902 11:21:12.413751   14516 occlient.go:485] Server https://api.ci-op-9600ps7s-f09f4.origin-ci-int-aws.dev.rhcloud.com:6443 is up
[odo] I0902 11:21:12.490646   14516 occlient.go:408] isLoggedIn err:  <nil>
[odo]  output: "developer"
[odo]  •  Waiting for project to come up  ...
[odo]  ✓  Waiting for project to come up [386ms]
[odo]  ✓  Project 'ygbqtbxmwa' is ready for use
[odo]  ✓  New project created and now using project : ygbqtbxmwa
[odo] I0902 11:21:12.904952   14516 odo.go:70] Could not get the latest release information in time. Never mind, exiting gracefully :)
Running odo with args [odo project create ghrrnu -o json]
[odo] {"kind":"Project","apiVersion":"odo.openshift.io/v1alpha1","metadata":{"name":"ghrrnu","namespace":"ghrrnu","creationTimestamp":null},"message":"Project 'ghrrnu' is ready for use"}
Running odo with args [odo project delete ghrrnu -o json]
[odo] {"kind":"Error","apiVersion":"odo.openshift.io/v1alpha1","metadata":{"creationTimestamp":null},"message":"The project ghrrnu does not exist. Please check the list of projects using `odo project list`"}
Deleting project: ygbqtbxmwa
Running odo with args [odo project delete ygbqtbxmwa -f]
[odo]  ✗  The project ygbqtbxmwa does not exist. Please check the list of projects using `odo project list`

• Failure [1.148 seconds]
odojsonoutput
/go/src/github.com/openshift/odo/tests/integration/json_test.go:16
  Delete the project and output json output
  /go/src/github.com/openshift/odo/tests/integration/json_test.go:37
    should be able to delete project and show output in json format [It]
    /go/src/github.com/openshift/odo/tests/integration/json_test.go:44

    No future change is possible.  Bailing out early after 0.102s.
    Running odo with args [odo project delete ghrrnu -o json]
    Expected
        <int>: 1
    to match exit code:
        <int>: 0

    /go/src/github.com/openshift/odo/tests/helper/helper_run.go:32

2019/09/03 08:57:55 Container setup in pod integration completed successfully
2019/09/03 09:56:19 error: unable to signal to artifacts container to terminate in pod integration, triggering deletion: could not run remote command: container artifacts is not valid for pod integration
2019/09/03 09:56:19 error: unable to retrieve artifacts from pod integration: could not read gzipped artifacts: container artifacts is not valid for pod integration
2019/09/03 09:56:23 error: could not wait for pod 'integration': it is no longer present on the cluster (usually a result of a race or resource pressure. re-running the job should help)
E0903 09:56:23.681472      14 event.go:191] Server rejected event '&v1.Event{TypeMeta:v1.TypeMeta{Kind:"", APIVersion:""}, ObjectMeta:v1.ObjectMeta{Name:".15c0e51d25e576e6", GenerateName:"", Namespace:"ci-op-9gnrt8tg", SelfLink:"", UID:"", ResourceVersion:"", Generation:0, CreationTimestamp:v1.Time{Time:time.Time{wall:0x0, ext:0, loc:(*time.Location)(nil)}}, DeletionTimestamp:(*v1.Time)(nil), DeletionGracePeriodSeconds:(*int64)(nil), Labels:map[string]string(nil), Annotations:map[string]string(nil), OwnerReferences:[]v1.OwnerReference(nil), Initializers:(*v1.Initializers)(nil), Finalizers:[]string(nil), ClusterName:"", ManagedFields:[]v1.ManagedFieldsEntry(nil)}, InvolvedObject:v1.ObjectReference{Kind:"", Namespace:"ci-op-9gnrt8tg", Name:"", UID:"", APIVersion:"", ResourceVersion:"", FieldPath:""}, Reason:"CiJobFailed", Message:"Running job pull-ci-openshift-odo-master-integration for PR https://github.com/openshift/odo/pull/2035 in namespace ci-op-9gnrt8tg from author dharmit", Source:v1.EventSource{Component:"ci-op-9gnrt8tg", Host:""}, FirstTimestamp:v1.Time{Time:time.Time{wall:0xbf53ac11e86270e6, ext:5614328813618, loc:(*time.Location)(0x26765e0)}}, LastTimestamp:v1.Time{Time:time.Time{wall:0xbf53ac11e86270e6, ext:5614328813618, loc:(*time.Location)(0x26765e0)}}, Count:1, Type:"Warning", EventTime:v1.MicroTime{Time:time.Time{wall:0x0, ext:0, loc:(*time.Location)(nil)}}, Series:(*v1.EventSeries)(nil), Action:"", Related:(*v1.ObjectReference)(nil), ReportingController:"", ReportingInstance:""}': 'events ".15c0e51d25e576e6" is forbidden: unable to create new content in namespace ci-op-9gnrt8tg because it is being terminated' (will not retry!)
2019/09/03 09:56:24 Ran for 1h33m35s
2019/09/03 09:56:25 Submitted failure event to sentry (id=1ea313751c014a26b1e8239dbf9af2d3)
error: could not run steps: step integration failed: template pod "integration" failed: pod was deleted while ci-operator step was waiting for it

/retest

@girishramnani @kadel I'm not able to figure out where the tests are failing. I checked the latest run and it seems like things are failing in cmd_push_test.go test which I have not touched as a part of this PR.

/test all
let's see if everything works even when we run tests again

/retest
[odo]  ✗  Failed To Update Config To Component Deployed

#1981

Looks like a flake to me
Cannot retrieve metalink for repository: epel/x86_64. Please verify its path and try again
error: build error: running 'yum -y install make wget gcc git httpd-tools' failed with exit code 1
2019/09/04 12:04:39 Ran for 1m1s
2019/09/04 12:04:39 Submitted failure event to sentry (id=c2f55a00ef254c0bbab8a736bb3e66f4)
error: could not run steps: step root failed: could not wait for build: the build root failed after 58s with reason DockerBuildFailed: Docker build strategy has failed.

yum-config-manager --save --setopt=<repoid>.skip_if_unavailable=true

Cannot retrieve metalink for repository: epel/x86_64. Please verify its path and try again
error: build error: running 'yum -y install make wget gcc git httpd-tools' failed with exit code 1

/test integration

Terraform error. Not related to our code, I guess.
level=error msg="Terraform does not automatically rollback in the face of errors."
level=error msg="Instead, your Terraform state file has been partially updated with"
level=error msg="any resources that successfully completed. Please address the error"
level=error msg="above and apply again to incrementally change your infrastructure."
level=error
level=error
level=fatal msg="failed to fetch Cluster: failed to generate asset \"Cluster\": failed to create cluster: failed to apply using Terraform"
---
Container test exited with code 1, reason Error
---
Another process exited
---

/test integration

/retest
Cannot retrieve metalink for repository: epel/x86_64. Please verify its path and try again
error: build error: running 'yum -y install make wget gcc git httpd-tools' failed with exit code 1
2019/09/04 12:04:39 Ran for 1m1s
2019/09/04 12:04:39 Submitted failure event to sentry (id=c2f55a00ef254c0bbab8a736bb3e66f4)
error: could not run steps: step root failed: could not wait for build: the build root failed after 58s with reason DockerBuildFailed: Docker build strategy has failed.

/hold cancel
/lgtm


32-bit (x86) binaries, please?

Hello, many thanks for this excellent project/fork and efforts 👍
However, I am on Windows Vista SP2 (32-bit), fully updated with post EOL MS updates (intended for Server 2008 SP2), .Net Framework 4.6.1 (fully updated) and I'd like to test this; unfortunately, you are only providing 64-bit compiled binaries... 😭
Would you be so kind as to recompile for the 32-bit architecture and also target NT 6.0 kernel?
Thanks in anticipation...
OT: May you have the Happiest New Year, too!  ❤

You can find instruction how to compile for windows. I do not have such configuration, so it is hard to me to compile it.

Thank you for your swift reply, especially during the holiday period, however:

I am not at all versed in compiling OS code, with VS or other compilers...
This is a fairly old laptop, not suitable for installing toolchains and compiling code (2007 era Core2Duo, 3GB RAM, latest version of VS that could be installed is 2010...

I do not have such configuration, so it is hard to me to compile it.

AIUI, 64-bit compilers (on 64-bit hosts) are also able to compile 32-bit binaries via simple configuration changes...

https://github.com/e2iplayer/hlsdl/blob/master/msvc/BUID_WINDOWS.txt

Thanks, but I have already been there prior to creating this issue...

vcvarsall.bat" x64
(snip)
MACHINE=x64

Perhaps using vcvarsall.bat" x86 and targeting MACHINE=x86 would be the way to go (again, I'm not able to test myself...)? FWIW, all dependencies (cmake, openssl-1.1.0f, pthreads, curl) are already available as win32 flavours...
Please, don't give up so easily on us, on 32-bit OSes...
@Reino17
I have been using, with success, your win32 binary of the original project, could you, perhaps, take a look at this [or we could continue this discussion over at the MSFN forums, CoRoNe...]?
Thanks to any person that can provide win32 builds...

To be able to compile for Vista you need old SDK.
So, compilation only for the 32-bit unfortunately do not make the job.

I'm sorry, but I can't be of any help this time.
Compiling hlsdl (e2iplayer):
src/hls.c:10:10: fatal error: sys/prctl.h: No such file or directory
 #include <sys/prctl.h>
          ^~~~~~~~~~~~~
compilation terminated.
make: *** [makefile:36: src/hls.o] Error 1

Compiling hlsdl (selsta):
/cygdrive/[...]/cross_compilers/mingw-w64-i686/bin/i686-w64-mingw32-gcc src/main.o src/aes.o src/curl.o src/hls.o src/misc.o src/msg.o -L/cygdrive/[...]/cross_compilers/mingw-w64-i686/i686-w64-mingw32/lib -lcurl -lmbedtls -lmbedx509 -lmbedcrypto -lwldap32 -lz -lws2_32 -lavformat -lm -lws2_32 -lavcodec -pthread -lm -lavutil -pthread -lm -luser32 -ladvapi32 -o hlsdl
/cygdrive/[...]/cross_compilers/mingw-w64-i686/lib/gcc/i686-w64-mingw32/8.2.0/../../../../i686-w64-mingw32/bin/ld: src/hls.o: in function `decrypt_sample_aes':
/cygdrive/[...]/win32/hlsdl_git/src/hls.c:489: undefined reference to `memmem'
/cygdrive/[...]/cross_compilers/mingw-w64-i686/lib/gcc/i686-w64-mingw32/8.2.0/../../../../i686-w64-mingw32/bin/ld: /cygdrive/[...]/win32/hlsdl_git/src/hls.c:493: undefined reference to `memmem'
/cygdrive/[...]/cross_compilers/mingw-w64-i686/lib/gcc/i686-w64-mingw32/8.2.0/../../../../i686-w64-mingw32/bin/ld: /cygdrive/[...]/win32/hlsdl_git/src/hls.c:505: undefined reference to `memmem'
/cygdrive/[...]/cross_compilers/mingw-w64-i686/lib/gcc/i686-w64-mingw32/8.2.0/../../../../i686-w64-mingw32/bin/ld: /cygdrive/[...]/win32/hlsdl_git/src/hls.c:518: undefined reference to `memmem'
collect2: error: ld returned 1 exit status
make: *** [makefile:25: all] Error 1

Especially this one I find annoying, because it has worked before. I don't understand why it won't work now.


Complete city list?

Is there a complete list of cities that are supported in this project?  I tried looking through the documentation and can't seem to find anything.
Thank you.

Hi, maybe the following link is what you are looking for?
https://www.3dcitydb.org/3dcitydb/3dcitydb-in-action/

This is a good place to start.. Thanks


Help resolve errors in a minimalist demo of library

I am attempting to create a minimalist demo of the dicom-microscopy-viewer library. However, when loading a slide, I encounter console errors:
pyramid.js:560 could not load tile "2-1-1" at level 0, this tile does not exist
viewer.js:1330 error loading tile of optical path "1"
My code can be found here: https://github.com/wzwz1/dicom-microscopy-viewer-demo
Could you please advise on what I missed? Thank you.

@wzwz1 this seems to be a data issue? have you tried different WSI datasets and got the same error?

@igoroctaviano Thank you for your comment. I have verified that the same slide opens successfully with SLIM, indicating that the issue may not be related to the dataset itself.
SLIM link:
https://viewer.imaging.datacommons.cancer.gov/slim/studies/2.25.339079652118011480966947516338286615501/series/<IP_ADDRESS>.4.1.59<IP_ADDRESS>0712533.1568310047.1714962696405.4.0

I have verified that the same slide opens successfully with SLIM, indicating that the issue may not be related to the dataset itself.

@wzwz1 if you open the error log for https://viewer.imaging.datacommons.cancer.gov/slim/studies/2.25.339079652118011480966947516338286615501/series/<IP_ADDRESS>.4.1.59<IP_ADDRESS>0712533.1568310047.1714962696405.4.0, you will see at the bottom the same error message that you included in your original report, so at least the issue is not specific to your demo.

@dclunie I believe we noticed similar issues earlier, and could not explain this. This might be a false alarm in the code, since the slide appears to render without issues. But I do not know for sure.


ethereum derivation path keyboard type fix

Fixed in PR https://github.com/soramitsu/fearless-iOS/pull/1077


Problem with CerboGX

Cant start the adapter on CerboGX with connected Multiplus ll .
Solarsystem is SE12K with no other modbus connection open.
$/data/dbus-solaredge# python /data/dbus-solaredge/dbus-solaredge.py
2022-06-27 21:27:30,750 - DbusSolarEdge - INFO - Startup, trying connection to Modbus-Server: ModbusTCP <IP_ADDRESS>:1502, UNIT 126
2022-06-27 21:27:30,770 - DbusSolarEdge - INFO - Connected to Modbus Server.
2022-06-27 21:27:30,799 - root - INFO - registered ourselves on D-Bus as com.victronenergy.grid.grid_id00
Traceback (most recent call last):
File "/data/dbus-solaredge/dbus-solaredge.py", line 326, in
dbusservice['grid']           = new_service(base, 'grid',           'grid',              0, 0)
File "/data/dbus-solaredge/dbus-solaredge.py", line 208, in new_service
log.error('regs.isError: '+regs)
TypeError: can only concatenate str (not "ModbusIOException") to str

I had the same issue and as q quick hack I am able to run the application by removing the 'regs' from the log.error message.
It is probably somehow possible to get the regs.errorMessage or something similar from this ModbusIOException.

This should be fixed with the latest commit.


fafo: idk

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#73  👈
#69
#68
#67
#72
#66
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @jhechtf and the rest of your teammates on  Graphite

IDK what this was for anymore.


mmdet_custom & mmpose_custom failed

version is different, mmdet and mmpose are not compatible to data/mmdet_custom and data/mmpose_custom
preparing coco-pose and coco-inst failed in ./tools/train.py

I have the same problem, can the author provide the version?

I have the same problem, can the author provide the version?


Hotfix

Progress towards #9

https://discord.js.org/#/docs/main/stable/class/GuildMember?scrollTo=hasPermission

Here we have a case study of how not to use Git... don't code on one computer and test on another.


can't interact with show and mouse

Hello,
Very nice job, I am struggling with interacting with 3d window (on windows, python)
I tried :
vp = Plotter(bg='black')
show both Volume and Mesh
vp.show(vol1,vol2,interactive=0)
vp.interactor.Render()
vp.interactor.Start()
and onmy show with interactive=True but everytime I click in the window it's closing....
I guess I missed something
Best,
Arnaud

Hi Arnaud,
thanks for your interest, can you reproduce this minimal example:
from vtkplotter import *

vol1 = load(datadir+'embryo.tif').scale(0.05)
vol2 = load(datadir+'embryo.slc')

show(vol1, vol2, bg='black', axes=1)

Thanks for the quick answer,
I do see volumes but can not rotate or move anything, the window just close.
Best,

Is is only related to volumes or it's the same with meshes?
from vtkplotter import *

vol1 = load(datadir+'embryo.tif').scale(0.05)
sph = Sphere()

show(vol1, sph)

Or, can you run this?
https://lorensen.github.io/VTKExamples/site/Python/GeometricObjects/Cone/

the vtk runs and works well, trying to find embryo.tif now...

ok I didn't install the examples, doing it now

doesn' work with examples, same behaviour, the window closed as soon as I try to interact with it

Sorry, I can't help u, I don't have any log or debug info, running on dell laptop, python 3.7 ,nvidia gtx1050 +intel gpu, vtk visualisation works and interact well, but show() renders but no interaction with mouse, keyboard ok for what I succeeded to test

OK, thanks for reporting this, I'll give it a try on a windows system to see if i can reproduce the issue!

Which VTK version are you using?

...also, what happens if you add:
# Allow to interact with scene during interactor.Start() execution
settings.allowInteraction = False

I can not reproduce the issue on Windows 10 with vtk 8.2.0
Some of the keys presses do cause the renderer to crash, but that is a known problem of vtk and has been solved on the master branch of vtk.

settings.allowInteraction = False, doesn't change anything, I use vtk 8.1.0, I will try to update to vtk 8.2

I have vtk 8.1.2 actually

is it correct ?

win32OpenGL?

Also, in Scripts I have vtkplotter not vtkplotter.exe when I modify the name and run it:
This version of Anaconda3\Scripts\vtkplotter.exe is not compatible with the version of Windows you're running.
Compatibily mode doesn' change anything.
version installed : Successfully installed vtkplotter-2020.2.1
strange...

On windows it looks like that the window title is ignored..

you should not change vtkplotter to vtkplotter.exe because the file is a python script, you should rather run it with command python vtkplotter

Does this work for you?
import vtk
from vtkplotter import load, datadir

vol = load(datadir+'embryo.tif')

ren = vtk.vtkRenderer()
ren.AddActor(vol)

renWin = vtk.vtkRenderWindow()
renWin.AddRenderer(ren)

iren = vtk.vtkRenderWindowInteractor()
iren.SetRenderWindow(renWin)
iren.Initialize()
iren.Start()

This one works well, my bad for vtkplotter, vtkplotter is working well also. only problem with show....

OK. Next step:
from vtkplotter import load, datadir, Plotter

vol = load(datadir+'embryo.tif')

vp = Plotter()

ren = vp.renderer
iren = vp.interactor

ren.AddActor(vol)

iren.Initialize()
iren.Start()

this one crash

show(datadir+'embryo.tif'), this also crash

OK, but does it render an image? Any crashing message?
Next:

import vtk
from vtkplotter import load, datadir, Plotter, settings

settings.allowInteraction=False # try both

vol = load(datadir+'embryo.tif')

vp = Plotter()

ren = vp.renderer
iren = vp.interactor
renWin = vp.window

ren.AddActor(vol)

iren = vtk.vtkRenderWindowInteractor()
iren.SetRenderWindow(renWin)
iren.Initialize()
iren.Start()

they all render images, no message, and this last one works (rendering, interact). when I say crash its for interaction

True and False are working

next:
import vtk
from vtkplotter import load, datadir, Plotter, settings, Sphere

settings.allowInteraction=False

sph = Sphere().lw(0.1)

vp = Plotter()

ren = vp.renderer
ren.AddActor(sph)

iren = vtk.vtkRenderWindowInteractor()
iren.SetRenderWindow(vp.window)

iren.AddObserver("LeftButtonPressEvent", vp._mouseleft)
iren.AddObserver("RightButtonPressEvent", vp._mouseright)
iren.AddObserver("MiddleButtonPressEvent", vp._mousemiddle)
iren.AddObserver("KeyPressEvent", vp._keypress)

vsty = vtk.vtkInteractorStyleTrackballCamera()
iren.SetInteractorStyle(vsty)
iren.Initialize()
iren.Start()

try interact, press h

works, h gives the help

STOP!! import vtk
from vtkplotter import load, datadir, Plotter, settings, Sphere,show
settings.allowInteraction=False
sph = Sphere().lw(0.1)
show(sph)
this works....

..and the Volume can also be visualized and interacted with?

Yes, but any datadir volume crash...:
from vtkplotter import  load, datadir, settings, Sphere,show
settings.allowInteraction=True
vol1 = load(datadir+'embryo.tif').scale(0.05)
sph = Sphere().lw(0.1)
show(vol1)
crash, sphere is working well

True or False doesn't change anything

Ok, this points to a gpu problem, the show() seems unrelated.
Try
from vtkplotter import datadir, settings, Sphere, Volume, show
from vtkplotter.vtkio import loadImageData

settings.allowInteraction=True

img = loadImageData(datadir+'embryo.tif') # loads a vtkImageData obj

# mapper types are: gpu, opengl_gpu, smart, fixed, tetra, unstr
vol = Volume(img, mapperType='smart')

show(vol)

crash, I am not sure which gpu card I am using with python, with vtk sure it uses the nvidia geforce, maybe show uses the intel for any reasons

I was right, I force python to use geforce and it works now... so sorry for these troubles:

And huge thanks to you for your help, hope it can help others

Fixed in less than 24h :)
23h33minutes

Indeed it should not crash with 'smart' mapper type... anyway,
thanks for your patience in testing and debugging the issue

well, that was in my interest :)


Problem to implement Vaadin datepicker in angular2-rc4 forms

Hello Guys i have implemented vaadin date-picker in one of my pages.I want to assign formControl to the vaadin datepicker directive but it is showing error like this
 ORIGINAL EXCEPTION: No value accessor for ' '
And i have built the form in this way
`<form [formGroup]="myForm"  (ngSubmit)="onSubmit(myForm.value)">

SKU

Submit
`
And included the datepicker directive like this
`directives: [FORM_DIRECTIVES, REACTIVE_FORM_DIRECTIVES,Date,PolymerElement('vaadin-date-picker')]`
I dont want to use [(ngModel)],i want to get the value using FormControl only.What is the correct way to use vaadin datepicker in angular2 forms? Thanks

Hi @abhibly,
FormControl was added to Angular 2 in 2.0.0-RC4 release and we haven't yet updated angular2-polymer to cover that. There's a ticket about it already at https://github.com/vaadin/angular2-polymer/issues/43 so I'm closing this issue for now as a duplicate.
If you wan't to use forms with angular2-polymer, I recommend sticking to the deprecated API for now until the feature is added.

@tomivirkki Thank you sir,
The link which you gave is template driven forms.Does Vaadin Datepicker supports model driven forms also?

@tomivirkki  Thank You,implemented using model driven depricated forms

@abhibly Ok, glad you got it working


Update URL for gogetdoc

Also reccomend use of the -u flag for go get since
gogetdoc requires a reasonably up-to-date version of
golang.org/x/tools.

Well, that's an awful copy & paste error, sorry for that.


Add -host option to urlgen.

Overview
This pull request adds a -host CLI option to urlgen so we can generate URLs for different hosts.

+1


Adds DestinationConfirmed class to Kryp config.

Codecov Report

Merging #119 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #119   +/-   ##
=======================================
  Coverage   92.71%   92.71%
=======================================
  Files         132      132
  Lines        2100     2100
  Branches      120      120
=======================================
  Hits         1947     1947
  Misses        153      153

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56dd85b...4d88e0b. Read the comment docs.


fix(docs): support special emoticons

close #xxx

Pull Request Checklist

[x] Related tickets or issues have been linked in the PR description (or missing issue).
[x] Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
[x] Unit tests have been added for the changes (if applicable).
[x] Breaking changes have been documented (or no breaking changes introduced in this PR).

We should add pixel diff (visual comparison) e2e before merging this to make sure that we can render emoji and many languages correctly.

It's a new capability, so why wait until after e2e？


Y-Fe-B[IN]

You do not need to put in anything here :)
Just open the issue by clicing the green "Submit new issue" and within 10-15s a message instructing you do upload your files should appear!

Y-Fe-B.zip

Y-Fe-B.zip


Add Ability to Enter Image Descriptions

Currently, Tusk allows users to add images to posts, but does not give them the ability to enter descriptions for those images. Image descriptions are important for blind and low-vision readers to be able to interact on Mastodon, and some instances have developed a strong culture around adding image descriptions (example: some users will only boost posts with images if those images have descriptions).
I'd like a text box that allows the user to enter an image description after adding an image to a post. I don't have a strong opinion on where that text box should appear, but I think placing the text box underneath or covering the image when it appears in a lightbox after the user taps the thumbnail from the posting view would be appropriate. The image description should be saved with the post such that it gets rendered in the HTML of the web UI in the "alt" and "title" attributes of the <img> tag in the post.
Rough sketches for a suggested implementation
Step 1: https://www.dropbox.com/s/w40rru24ddpv48t/IMG_2514.JPG?dl=0
Step 2: https://www.dropbox.com/s/cm6fw7i4csv66wm/IMG_2515.JPG?dl=0
An example of a post with an image description can be seen here, note the title text that appears on hover and the alt and title attributes in the HTML

Whoops! this went to the wrong project, Please disregard


Divide performance viewer strategies in categories on the UI, add some initial styling.

Part of the changes in https://github.com/BabylonJS/Babylon.js/issues/11127
The colors for now are just placeholders.

Restructured the code a bit according to the comments!

There is a doc issue:
Missing text for Interface : IPerformanceViewerStrategyParamete
Missing text for Property : category (id: 47791) in IPerformanceViewerStrategyParameter
Missing text for Property : strategyCallback (id: 47790) in IPerformanceViewerStrategyParameter


Mips64 stub

It would be nice to make a "Hello world!" example for mips64 in rust and c and to check their building in ci.


added library path to glue job

used the "--extra-py-files" argument to specify the library path in the glue job and trigger

@armandcismaru does the path contain the full s3 uri?

I'll check it and fix it today if needed.

Yes, the path contains the full S3 uri, I fixed an instance in aws_glue_job where the bucket name would be repeated twice in script_location.


Inconsistent Line Endings?

Hey All,
I'm trying to get my GitHub setup so I can submit the patch that I had in the old Subversion Repository (http://msbuildtasks.tigris.org/issues/show_bug.cgi?id=129) that doesn't look like it transferred over. I'm completely new to GitHub, but reading online it seems something is probably wrong with my line endings, there are 61 files that the GitHub application seems to feel need to be committed, yet I've made no local changes.
Thanks

I am closing this as resolved.


SAML singleLogoutService

Is there a way to configure the SAML singleLogoutService through the python-social-auth settings?  I don't see it in the docs.

AFAIK there's no way yet.
Closing, reopen in social-core if still relevant.


Tableau datasources duplicating lineages with uppercase databases/table names

Describe the bug
When metadata is ingested from Tableau the database level entity does not merge with metadata ingested from the database itself if the database name (and presumably table) is uppercase.
To Reproduce
Steps to reproduce the behavior:

Create a Postgresql database with a fully uppercase name ex. DATABASE
Use that database in a Tableau dashboard as a live datasource
Ingest metadata from Tableau and Postgresql
View lineages

Expected behavior
Database name is imported with the expected case.
Screenshots
Two datasets with the "same" name.

Additional context
urn for the above objects:
Tableau  ->> urn:li:dataset:(urn:li:dataPlatform:postgres,nova.public.fact_enrolments_plus,PROD)
Postgres ->> urn:li:dataset:(urn:li:dataPlatform:postgres,NOVA.public.fact_enrolments_plus,PROD)

Confirmed in the Tableau metadata api that the name is as expected:
{
        "id": "c0a4dfbc-1193-6a2f-a91a-55c950cae875",
        "name": "NOVA",
        "connectionType": "postgres"
      }

Originally I thought this might be an issue with the Tableau ingest changing the uppercase names to lowercase, however after a conversation with @shirshanka on slack, it looks like this is an issue with the postgres ingest not dropping things down to lowercase.
I saw that there's a environment variable that can be set as a workaround, DATAHUB_DATASET_URN_TO_LOWER and it looks like there is an intention of everything going to lowercase but some things may be left out. I don't see a issue related to this atm, so I'll leave this open, but feel free to close if this is the appropriate workaround for the time being.
Thanks!

Hello,
I have a similar problem with Oracle instead of Postgres: the Tableau import uses names in the form "host:port.schema.table" for the Oracle sources :
Import Oracle : urn:li:dataPlatform:oracle,qual_don_prop.workflows
Import Tableau : urn:li:dataPlatform:oracle,zinnt:1525.qual_don_prop.workflows


Adjective grounding needs to be added to the pipeline

At one time and for various reasons the design had no vars for an EidosMention.  This was recently changed so that the canonicalName and groundings are vars.  I realize now that there is one more dangling piece of data: the adjective groundings.  These are being added optionally just for the jsonld export and they're the reason that in lots of apps there is this strange adjectiveGrounder being constructed in order to do the serialization.  It's quite a distraction.  IMO the adjective grounding should be added to the main pipeline.  If necessary, it could be turned off by default via the options.  This means that the serializer doesn't need to know anything about the grounding.  The deserializer can be made to read it back in if present.  The information is otherwise lost and we've been reconstituting on round trips.  The adjective grounder would become part of the EidosComponents and potentially accessible there for anything that still needs its own.  It would even be guaranteed to be the same one that the reader used.  Ensuring that was previously reason for excessive handling of config variables.

Done in #748

Oh no, so

#791 addresses this issue.


Organisation-wide Security & Compliance Retention Policies

Helllo,
Can I ask if the documentation could be updated to include a note about changing the organisation-wide Security & Compliance Retention policies applied to inactive mailboxes.
The documentation does state (albeit on a different page) that you cannot change the retention policy that an inactive mailbox is assigned to; this makes sense for policies where mailboxes are explicitly included as an inactive mailbox cannot be explicitly added to a policy.
The documentation does not make it clear that if an additional organisation-wide policy is created, that it is applied to inactive mailboxes too. I have a customer where they want to change the existing global policy for a new one, and it is not obvious what would happen when one is removed and another is added. I have tested this in a lab environment and it appears that the new policy is indeed applied to inactive mailboxes but it would be good if this could be clarified.
For reference, the mailbox hold-types table example of "Mario Necaise" provides the basic use case, but could be expanded to include something about changes in global policies.
Many Thanks

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ae6beff2-9c08-e965-d363-3bebcbf4e6c1
Version Independent ID: 8547a870-691a-2aed-682a-39c014869683
Content: Change the hold duration for an inactive mailbox - Microsoft 365 Compliance
Content Source: microsoft-365/compliance/change-the-hold-duration-for-an-inactive-mailbox.md
Service: o365-seccomp
GitHub Login: @markjjo
Microsoft Alias: markjjo

@markjjo Please help us in resolving this issue. Thanks


add contracts and tests

Signed-off-by: Stefan Pingel<EMAIL_ADDRESS>

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Unusable in the locked down environment

Steps to Reproduce
Run rye sync on a machine that has no internet access and only PyPi mirror set up.
Expected Result
Successful bootstrapping
Actual Result
Hangs at "Bootstrapping rye internals". Tried tcpdump and it is attempting to make the request to github.com. What is the solution to running this in an environment that has no internet access outside of the PyPi mirror?
Thanks!
Version Info
rye 0.39.0
commit: 0.39.0 (bf3ccf818 2024-08-21)
platform: linux (aarch64)
self-python: not bootstrapped (target<EMAIL_ADDRESS>symlink support: true
uv enabled: true
Stacktrace
No response

@mitsuhiko, could you please look into this? Thank you so much :)


[g-image] After build I have image with 3x of the original size

Description
g-image is compressing the image 3x of the original size of the image.
Steps to reproduce

Use a compressed image in a g-image (Use an ultra compressed image for easier testing. You can use ImageOptim with the JPEG quality in the minimum).
Compile using gridsome build
Check the size of the image before and after

Expected result
Should be an option to bypass the compression at least for the original/main resolution of the image and only compress for other sizes but respecting the quality parameter. Or check if the size of the compressed image is higher and bypass the compression. @hjvedvik tagging you 'cause you're assigned to all tasks related to g-image ❤
Edited:
Three ways I see this can be done for the developer:

Option to disable compression
Check if the compressed file is bigger than the original and ignore it
quality="100" means no compression

Actual result
The original size is 92kb and after the build I have 267kb.

Environment
  System:
    OS: macOS 10.15.5
    CPU: (4) x64 Intel(R) Core(TM) i5-5257U CPU @ 2.70GHz
  Binaries:
    Node: 12.16.3 - /usr/local/bin/node
    npm: 6.14.5 - /usr/local/bin/npm
  Browsers:
    Safari: 13.1.1
  npmPackages:
    @gridsome/plugin-sitemap: 0.4.0 => 0.4.0
    @gridsome/source-filesystem: 0.6.2 => 0.6.2
    @gridsome/transformer-remark: 0.6.1 => 0.6.1
    gridsome: 0.7.18 => 0.7.18
    gridsome-plugin-robots: 0.2.1 => 0.2.1
  npmGlobalPackages:
    @gridsome/cli: 0.3.3

Related https://github.com/gridsome/gridsome/issues/1091

4 slider images before building:

After building:

I'm using:
<g-image src="~/../uploads/1.jpg" quality="100"/>
Three ways I see this can be done for the developer:

Option to disable compression
Check if the compressed file is bigger than the original and ignore it
quality="100" means no compression

@hjvedvik but you will be the judge for the best way to achieve it 😄

I did some more work on this tonight and think I have a solution that works well now. But I have to wait until tomorrow before publishing a new release. I basically just implemented all your suggestions, @Kulcanhez :) They seem to work well as far as I've tested.
It will be possible to disable processing for all images by setting images: { minimize: false } in gridsome.config.js after the release. And for a single image with quality="100".  Images are still resized to the different sizes when processing is disabled as long as the resulting file size is not exceeding the initial size.

@Kulcanhez Just published v0.7.19 :) I named the option compress, which is true by default. And I also added defaultQuality: 75. Setting defaultQuality: 100 is basically the same as compress: false.
module.exports = {
  images: {
    compress: false // disables image compression
  }
}

@Kulcanhez Just published v0.7.19 :) I named the option compress, which is true by default. And I also added defaultQuality: 75. Setting defaultQuality: 100 is basically the same as compress: false.
module.exports = {
  images: {
    compress: false // disables image compression
  }
}

@hjvedvik I tested yesterday and is working amazingly!! Really thank you for the fast fix and for being open to suggestions ❤ 🚀

Just wanted to pop in and say I'm not sure these settings are working for JPGs. I tried setting compress to false, and tried different defaultQuality settings, and also tried the quality attribute in the g-image, none seemed to have an effect.

Just wanted to pop in and say I'm not sure these settings are working for JPGs. I tried setting compress to false, and tried different defaultQuality settings, and also tried the quality attribute in the g-image, none seemed to have an effect.


hasFileType fails with circular dependency error with Joi v11.0.0+

hapi-swgger version:
v7.7.1
What are you trying to achieve or the steps to reproduce ?
Trying to render the the Swagger UI using Joi >=v11.0.0 for payload validation results in:
TypeError: Converting circular structure to JSON
  at JSON.stringify (<anonymous>)

hapi-swagger tries to determine the swaggerType...
internals.hasFileType = function (route) {
    let routeString = JSON.stringify(route);
    return routeString.indexOf('swaggerType') > -1;
};

...and JSON.stringify fails with a circular dependency error.
It appears Joi >=v11.0.0  introduced a circular dependency with the property _currentJoi https://github.com/hapijs/joi/commit/27f2fb9bbf5616181ffa39b305b74fffaab6999b.
Example Route:
{
    method: 'POST',
    path: '/v1/foo',
    config: {
      description: '',
      handler: (request, reply) => {
        reply('Ok');
      },
      tags: ['api', 'v1'],
      validate: {
        payload: {
          id: Joi
            .string()
            .required()
            .description('Unique identifier')
            .example('SJYWvQjBaNb'),
        },
      },
    },
  }

Solution
Leverage json-stringify-safe to prevent errors being thrown from circular dependends in Joi objects.
const fastSafeStringify = require('fast-safe-stringify')

internals.hasFileType = function (route) {
    let routeString = fastSafeStringify(route);
    return routeString.indexOf('swaggerType') > -1;
};

I'm having the same issue

I'm too.


environment.yml is missing myst_nb

Building the docs in a fresh conda environment created via $ mamba env create -f environment.yml fails to find myst_nb. I guess the yml file needs an update
Found ninja-1.11.1 at /home/br/mambaforge/envs/scipy-dev/bin/ninja
Cleaning... 0 files.
[355/355] Linking target scipy/sparse/spar...parsetools.cpython-310-x86_64-linux-gnu.so
Build OK
💻  meson install -C build --only-changed
Installing, see meson-install.log...
Installation OK
# for testing
# @echo installed scipy 9a8ec79 matches git version 9a8ec79; exit 1
mkdir -p build/html build/doctrees
LANG=C /home/br/mambaforge/envs/scipy-dev/bin/python -msphinx -WT --keep-going  -b html -d build/doctrees -j1 source build/html
Running Sphinx v5.3.0
SciPy (VERSION 1.11.0.dev0+1910.9a8ec79)

Traceback (most recent call last):
  File "/home/br/mambaforge/envs/scipy-dev/lib/python3.10/site-packages/sphinx/registry.py", line 459, in load_extension
    mod = import_module(extname)
  File "/home/br/mambaforge/envs/scipy-dev/lib/python3.10/importlib/__init__.py", line 126, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 1050, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1027, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1004, in _find_and_load_unlocked
ModuleNotFoundError: No module named 'myst_nb'

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/home/br/mambaforge/envs/scipy-dev/lib/python3.10/site-packages/sphinx/cmd/build.py", line 276, in build_main
    app = Sphinx(args.sourcedir, args.confdir, args.outputdir,
  File "/home/br/mambaforge/envs/scipy-dev/lib/python3.10/site-packages/sphinx/application.py", line 223, in __init__
    self.setup_extension(extension)
  File "/home/br/mambaforge/envs/scipy-dev/lib/python3.10/site-packages/sphinx/application.py", line 398, in setup_extension
    self.registry.load_extension(self, extname)
  File "/home/br/mambaforge/envs/scipy-dev/lib/python3.10/site-packages/sphinx/registry.py", line 462, in load_extension
    raise ExtensionError(__('Could not import extension %s') % extname,
sphinx.errors.ExtensionError: Could not import extension myst_nb (exception: No module named 'myst_nb')

Extension error:
Could not import extension myst_nb (exception: No module named 'myst_nb')

Also
$ python dev.py lint
Traceback (most recent call last):
  File "/home/br/repos/scipy/scipy/tools/lint.py", line 138, in <module>
    main()
  File "/home/br/repos/scipy/scipy/tools/lint.py", line 127, in main
    rc, errors = run_ruff(other_files, fix=args.fix)
  File "/home/br/repos/scipy/scipy/tools/lint.py", line 73, in run_ruff
    res = subprocess.run(
  File "/home/br/mambaforge/envs/scipy-dev/lib/python3.10/subprocess.py", line 503, in run
    with Popen(*popenargs, **kwargs) as process:
  File "/home/br/mambaforge/envs/scipy-dev/lib/python3.10/subprocess.py", line 971, in __init__
    self._execute_child(args, executable, preexec_fn, close_fds,
  File "/home/br/mambaforge/envs/scipy-dev/lib/python3.10/subprocess.py", line 1847, in _execute_child
    raise child_exception_type(errno_num, err_msg, err_filename)
FileNotFoundError: [Errno 2] No such file or directory: 'ruff'

Both things work fine for me, and both myst-nb and ruff are present in environment.yml. Not sure what's happening for you, maybe an old environment or some env var set?

OK, does work on nuking the environment and redoing from scratch. Had several hiccups on switching to mamba, so let's call it a user fluke.


Add mac cross-compile CI job

We want to avoid regressing the mac android build, so we should have a CI job for it.

See https://github.com/servo/servo/issues/20958

I thought this was about compiling for mac from linux, to save precious mac builders for actually running tests.


[BUG] compiling whatsapp resources

Information

Apktool Version (apktool -2.8.0) -
Operating System (Mac, Linux, Windows) -linux
APK From? (Playstore, ROM, Other) -apkpure
Java Version (java --version) -Openjdk 17.0.7

Description
first when i started to reverse engineer whatsapp i used the 2.7.0 but can't compile apk unless i decompile it withoout resources so now i am using the last version and the error change the bug fixed in last version but here new problem i dont want to decompile without resources since i want to add my own pictures images and change package name to my own
Stacktrace/Logcat
./apktool b WhatsApp --use-aapt2
I: Using Apktool 2.8.0
I: Checking whether sources has changed...
I: Checking whether sources has changed...
I: Checking whether sources has changed...
I: Checking whether sources has changed...
I: Checking whether sources has changed...
I: Checking whether resources has changed...
I: Building resources...
W: /home/nobodyknows/Desktop/apktooldof/WhatsApp/res/animator/APKTOOL_DUMMYVAL_0x7f02000b.xml:7: error: attribute state_dragged (aka com.whatsapp:state_dragged) not found.
W: /home/nobodyknows/Desktop/apktooldof/WhatsApp/res/animator/APKTOOL_DUMMYVAL_0x7f02000c.xml:7: error: attribute state_dragged (aka com.whatsapp:state_dragged) not found.
W: /home/nobodyknows/Desktop/apktooldof/WhatsApp/res/animator/APKTOOL_DUMMYVAL_0x7f020016.xml:4: error: attribute state_dragged (aka com.whatsapp:state_dragged) not found.
W: /home/nobodyknows/Desktop/apktooldof/WhatsApp/res/color/APKTOOL_DUMMYVAL_0x7f06065c.xml:5: error: attribute state_dragged (aka com.whatsapp:state_dragged) not found.
W: /home/nobodyknows/Desktop/apktooldof/WhatsApp/res/color/APKTOOL_DUMMYVAL_0x7f06085b.xml:5: error: attribute state_dragged (aka com.whatsapp:state_dragged) not found.
W: /home/nobodyknows/Desktop/apktooldof/WhatsApp/res/color/APKTOOL_DUMMYVAL_0x7f06085b.xml:6: error: attribute state_dragged (aka com.whatsapp:state_dragged) not found.
W: /home/nobodyknows/Desktop/apktooldof/WhatsApp/res/color/APKTOOL_DUMMYVAL_0x7f06085c.xml:5: error: attribute state_dragged (aka com.whatsapp:state_dragged) not found.
W: /home/nobodyknows/Desktop/apktooldof/WhatsApp/res/drawable/mtrl_switch_thumb.xml:6: error: attribute state_with_icon (aka com.whatsapp:state_with_icon) not found.
W: error: failed linking file resources.
brut.androlib.exceptions.AndrolibException: brut.common.BrutException: could not exec (exit code = 1): [/tmp/brut_util_Jar_26608826609686595201617165250529962023.tmp, link, -o, /tmp/APKTOOL1139501867453885000.tmp, --package-id, 127, --min-sdk-version, 23, --version-code, 231374003, --version-name, <IP_ADDRESS>, --no-auto-version, --no-version-vectors, --no-version-transitions, --no-resource-deduping, --allow-reserved-package-id, --enable-sparse-encoding, -e, /tmp/APKTOOL1952182002010738841.tmp, -0, arsc, -I, /home/nobodyknows/.local/share/apktool/framework/1.apk, --manifest, /home/nobodyknows/Desktop/apktooldof/WhatsApp/AndroidManifest.xml, /home/nobodyknows/Desktop/apktooldof/WhatsApp/build/resources.zip]

Steps to Reproduce

apktool b Whatsapp  --use-aapt2

APK
https://m.apkpure.com/whatsapp-android/com.whatsapp/download
Questions to ask before submission

Have you tried apktool d, apktool b without changing anything? Yes
If you are trying to install a modified apk, did you resign it? yes
Are you using the latest apktool version? Yes

Thanks for the report, but this is a known issue just a few tickets back at: https://github.com/iBotPeaches/Apktool/issues/3129
Closing for duplicate.


usb: shell: Remove use of ctx_shell

The ctx_shell was only used a single place and in a function that already has a sh that would be better to use.

@Thalley why a draft? This looks like a trivial change.

I always keep PRs in draft until they reach their first CI pass :)

@jfischer-no please review :)

okay, although I have to bring it back soon.

:(
The concept of a ctx_shell is pretty terrible, as that is not how the shell really works. There can be multiple shells, and the shell executing the command may not be the shell receiving the result. See https://github.com/zephyrproject-rtos/zephyr/issues/70945 for a bit more.
In BT we have https://github.com/zephyrproject-rtos/zephyr/pull/74652 as a step forward to eliminating it


Optimistic Update for deleting/duplicating item in Array

I've setup everything and it works except you can see the small delay when deleting/duplicating items ( it doesn't feel live ), any idea how to solve this with onStart, this is my code:
export const api = createApi({
  reducerPath: "api",
  baseQuery: fetchBaseQuery({ baseUrl: "http://localhost:8081" }),
  entityTypes: ["Positions"],
  endpoints: (build) => ({
    getPositionsByCompany: build.query<Array<any>, void>({
      query: () => ({
        url: "/positions",
        method: "GET",
        credentials: "include",
      }),
      provides: (result: any) => [
        ...result.positions.map(({ _id }: any) => ({
          type: "Positions",
          id: _id,
        })),
        { type: "Positions", id: "LIST" },
      ],
    }),
    deletePosition: build.mutation<void, any>({
      query: (id: string) => ({
        url: `/positions/${id}`,
        method: "DELETE",
        credentials: "include",
      }),
      onStart(id, { dispatch, context }) {
        //...
      },
      invalidates: (_, id) => [{ type: "Positions", id }],
    }),
    duplicatePosition: build.mutation({
      query: (position: { positionid: any; name: string }) => ({
        url: "/positions/duplicate",
        method: "POST",
        body: position,
        credentials: "include",
      }),
      onStart(id, { dispatch, context }) {
        //...
      },
      invalidates: [{ type: "Positions", id: "LIST" }],
    }),
  }),
});

Below is example given in docs, it shows updating item, I've tried something similar with no success
onStart({ id, ...patch }, { dispatch, context }) {
    // When we start the request, just immediately update the cache
        context.undoPost = dispatch(
        api.util.updateQueryResult('getPost', id, (draft) => {
            Object.assign(draft, patch);
        })
    ).inversePatches;
},

You can do anything in that updateQueryResult, so you could do
api.util.updateQueryResult('getPositionsByCompany', id, (draft) => {
            draft.push(draft[id])
        })

or something similar

You can do anything in that updateQueryResult, so you could do
api.util.updateQueryResult('getPositionsByCompany', id, (draft) => {
            draft.push(draft[id])
        })

or something similar

Had no luck with this sadly, my console log is not logging anything for draft and there's no action dispatched on my redux dev tools for this ( all other actions are there, queries/mutations ) so is there any other way to test this. I've tried other things on draft not just .push but nothing seems to work.
Ik that docs are not yet 100% completed but what exactly are context, draft and updateQueryResult
This is basically what I have, didn't want to copy whole thing again just the endpoint I worked on, I also noticed for Object.assign example Immer Patch is used so is this necessary here
deletePosition: build.mutation<void, any, any>({
      query: (id: string) => ({
        url: `/positions/${id}`,
        method: "DELETE", // post, put, delete...
        credentials: "include",
      }),
      onStart(id, { dispatch, context }) {
        context.undoPost = dispatch(
          positionsApi.util.updateQueryResult(
            "getPositionsByCompany",
            id,
            (draft) => {
              console.log(draft);
              draft.push(draft[id]);
            }
          )
        ).inversePatches;
      },
      invalidates: (_, id) => [{ type: "Positions", id }],
    }),

draft is the value that was returned by your "getPositionsByCompany" request that you called with the parameter id. You can just modify that as you would do in a normal immerized RTK reducer. Logging should be possible with console.log(current(draft)).
If there is no value for useGetPositionsByCompany(id) in the cache, that callback will not be called and nothing will be updated (since there is nothing to update).


Absolute "for dummies" guide needed

When i saw this package on our it made my day. I loved the original package, and was in need of a nice and easy to implement search solution for v8. And this looked great. And it says on the github page "Easy to set up"... :). Well it's not plug and play, thats for sure :). I'm stuck and really need som guidance. The entire Controller thing is a bit above my front end skills. But let me walk through my steps so far.

I installed the package from within Umbraco, after downloading the zip from Our - Succes

I set an app setting in the web config, like this

i set all doc types to "Allow varying by culture"

i checked that there is content in the fullTextSearch fields in the External index. There is

I created an "App_Code" folder. My site didn't have one.

Now things are getting into unknown territory. I created "MyProject.cshtml" in the App_Code folder and copy pasted from the dev docs.

i created a partial for the search result and copy pasted from the dev docs.

when hitting the search page i get the following error:

I @claushingebjerg
Thanks for reaching out :)
In your controller you put your search model in the ViewBag, so in your view, in stead of writing Model.FullTextSearch... you need to write ViewBag.FullTextSearchResult.
Let me know if that helps you :)


modelcheck: duplicate failures into JUnit XML text

I triggered the tests on the itemis TeamCity, will squash & merge the PR once they pass.


Implement the ability to fetch a room

Part of #19. References to spec are based on https://github.com/ably/specification/pull/200 at commit aa7455d.
The @preconcurrency imports of ably-cocoa are temporary and will be removed once https://github.com/ably/ably-cocoa/issues/1962 is done; created #31 for tracking.
I’ve decided to, for now, throw ably-cocoa’s ARTErrorInfo for consistency with JS; created #32 to revisit this later.
https://ably.atlassian.net/browse/ECO-4936

Summary by CodeRabbit
Summary by CodeRabbit

New Features

Introduced a structured error handling mechanism in the Ably Chat SDK for improved error reporting.
Added a new Room protocol and DefaultRoom class to manage chat room functionalities.
Enhanced Rooms protocol with a new implementation for better room instance management.
Added Equatable conformance to various room option structs for easier equality checks.
Implemented utility functions and tests to validate error handling and room management.

Bug Fixes

Improved error handling to ensure consistency in room options and error reporting.

Tests

Added unit tests for the DefaultRooms class to validate room retrieval and error handling.
Enhanced test framework with utility functions for better error assertions.

I’ve pushed a new commit (before the original one) that implements the DefaultChatClient.rooms property.

I’ve pushed another commit to require that the realtime client conform to Sendable; this removes the need to scatter @preconcurrency import Ably across the codebase, moving that need to only the place where you initialise the library, which is clearer, I think.


Updated the games

Added the F1 games from Codemasters (from F1 2010 to F1 2021)

What are these from? I don't see any F1 games in the client.

Oh sorry I thought this was adding it to the client

Lol, no worries. But for future reference, this file documents the games already in the client, we can't add new ones.


Suppress "Warning only once for all operators" during PyTorch dispatch

This commit implements a warning filter to ignore the "Warning only once for all operators, other operators may also be overrided." message generated during PyTorch dispatch calls. This change helps maintain cleaner logs by preventing this specific warning from appearing, which can occur when multiple operators are overridden.

Thanks for your contribution，but I wonder if there is a more helpful way to suppress this warning but can also indicates that the replacement of flag_gems succeeded ？Also，Please use pre-commit to format your codes to make them the same style with the code repo

Hi @Bowen12992,
Thank you for your feedback. I understand your concerns, but I currently cannot find an elegant solution that both suppresses the warning and indicates that the patch was successful. Therefore, I have decided to close this PR for now.
If I come up with a better approach in the future, I will revisit this issue.


[WIP] [Feature] Implement form reset

closes #62

there is still a weird side effect where field arrays will reset to an empty field after submitting multiple times, can't really tell why this is happening
https://user-images.githubusercontent.com/10850738/226752199-ec440f1b-661d-47c3-b4d2-98d8a071c340.mov

@ShooTeX this issue should be fixed now. I'll also fix the merge conflicts for ya :)

@all-contributors please add @caxco93 for code, test, doc

Oh whoops that's the wrong username 🤦

@all-contributors please add @ShooTeX for code, test, doc


Screenshots Please

May you please add screenshots (ideally GIF) of this in action in readme? That's the first thing a lot of RN package searchers do. There are so many packages its not easy to (1) install each one, (2) then render it respecting properties, (3) then uninstall it if it doesn't fit.

Sorry, I'm really too busy to do it. Would you like to add some? Maybe we together can make it an awesome library 😄

I haven't used this yet, as I don't know what it really offers without seeing pictures. But sure ok, when I get some time, I'll install it and try to use it per Readme, I'm not sure what the end result is supposed to look like. Will screenshot what I get.

I will be interested to help you out with this. Does it work for Android as well?

@vijayst Yes! Thanks very much 😄

Screenshot for iOS

@vijayst Awesome! Can you make a PR to add this screenshot? Thanks very much.

ok sure, I will do a PR. And android screenshot is

Added PR!

Thanks so much @vijayst


Words helper

Useful for creating arbitrary lists on the fly
words('a', 'b', 'c') === ['a', 'b', 'c'];
words('a b c') === ['a', 'b', 'c'];
words('a\nb\nc') === ['a', 'b', 'c'];

{{#each (words "First" "Second" "Last") as |rank|}}
  Our {{rank}} place winner is ...
{{/each}}

Maybe call w helper

If one letter helpers are possible, I would vote for both.


Infrastructure - complete plan

The complete plan is:

For development this is just a normal react application (client-side rendered).
For production this repo builds into a prerendered site with client-side javascript applied.

Why? search engines should be able to index the documentation.
How? react-router with async routes, static-site-generator-webpack-plugin/Antwar, entry point per route.

It's published to the webpack.github.io repo. (Best via CI, codeship?)

This allows use to override webpack.github.io/docs when no webpack/docs repo exists. OR we remove the gh-pages branch and use the wiki as old docs.
We will rename the webpack/docs repo to webpack/old-docs once the new documentation ships.

Server-side elements are added via gordon with AWS lamdas + api gateway once needed

Not needed for the documentation
But will be needed to future stuff...

Probably safe to close now that most of the infrastructure is done. We are missing that gordon bit, but that can be discussed later.


link-checker is busted

for example, the helm link in https://github.com/kubernetes-incubator/service-catalog/tree/master/contrib/cmd/k8s-broker
This is irritating to me personally, as it takes a long time to run.

#dibs


OCaml support

Describe the language you want support for (compiler, specificities)
I'd like an interpreter for OCaml that uses utop and that work with detected filetypes ml, mli.
Support Level to achieve
Block-level support is enough for me....
Additional context
I've given https://opam.ocaml.org/blog/about-utop/ as the repl, but the ocaml command is also a repl so it may be an option if that's easier to work with. (I'm not sure what's required from the repl).
OCaml can be interpreted and should support fairly advance repl features, but I'b be happy with block support.

I'll work on it :-)
If it's not too much trouble I'll look into having REPL support as well

I must have missed something in the configuration.
Ocaml is listed as supported.

but evaluating a block trigger the generic interpreter, with an empty results.

Trying something similar with python, works as expected, so it seems the plugin work in general.
filetype=ocaml in my test.

filetype=ml (or mli) should work better
I didn't think twice and just hardcoded the compatibility with 'ml' and 'mli'. I'll add that as well
In the meantime, you can set the 'use_on_filetypes' key in the configuration (see documentation) to force the OCaml_fifo interpreter on 'ocaml' filetypes

Sorry, that's my fault, I've put the file extension instead of the filetype in the ticket. 🤦🏾
Let me try that.

With use_on_filetypes block mode works great for utop and ocaml.

Repl mode works too, the only unexpected behavior is I'm force to send ;; (which is the separator in the top level).
I mean:

print_endline "Hello, world"

works fine in block mode, but fails if repl is enabled, and I have to send that instead:
print_endline "Hello, world";;

For utop, I've dug around, it's possible to disable most of the fanciness if we send #utop_prompt_dummy;; to the running process.

In any case, it's already very functional for me, thanks for the quick turn around 😄

Repl mode works too, the only unexpected behavior is I'm force to send ;; (which is the separator in the top level).

Isn't it a normal behavior ? Using the REPL like a typical OCaml novice feels like ';;' is mandatory at the end of each statement. 1-statement files look like the only exception to this rule, be it through sniprun or not:
this will fail even in no-REPL mode
print_endline "Hello, world"
print_endline "Hello, world"

Is there something obvious I'm missing ?

No, you are totally correct on that point.
I think it comes to ocaml oddities: ;; are mandatory in the REPL, but completly optional in a "proper" source file (and most people don't use them).
So if I'm editing a regular ocaml file and sending bits of it to the REPL through sniprun, I have to remember to sprinkle it with extra ;; that I would not have bothered with otherwise. But I can live with it :)

what is a "proper" ocaml source file is quite alien to me, but hey, if it's okay with you...
(I mean, I can't conceivably parse ocaml statements (that may be multi-line) to automatically add ';;' at their end)
Is the non-REPL bloc-mode at least free of such hassle ?

Yes, it works as expected, both for "utop" and "ocaml"

v1.3.0 is released


serviceName attribute from @Webservice not used

When i have a separate api and impl project the generated wsdl is incorrect.
Inside the api the classes from the wsdl are generated.
Inside the impl project the api is used to implement the service.
Quarkus version: 2.8.3
Cxf version: 1.1.0
The ?wsdl result is
<wsdl:definitions xmlns:xsd="http://www.w3.org/2001/XMLSchema" xmlns:wsdl="http://schemas.xmlsoap.org/wsdl/" xmlns:tns="http://tempuri.org/" xmlns:soap12="http://schemas.xmlsoap.org/wsdl/soap12/" xmlns:ns1="http://schemas.xmlsoap.org/soap/http" name="Calculator" targetNamespace="http://tempuri.org/">
<wsdl:portType name="CalculatorWebServiceImpl_ClientProxy"> </wsdl:portType>
<wsdl:binding name="CalculatorSoapBinding" type="tns:CalculatorWebServiceImpl_ClientProxy">
<soap12:binding style="document" transport="http://schemas.xmlsoap.org/soap/http"/>
</wsdl:binding>
<wsdl:service name="Calculator">
<wsdl:port binding="tns:CalculatorSoapBinding" name="CalculatorWebServiceImpl_ClientProxyPort">
<soap12:address location="http://localhost:8080/ws/calculator"/>
</wsdl:port>
</wsdl:service>
</wsdl:definitions>

Here is a reproducer: https://github.com/querdenker2k/cxf-servicename-reproducer
With Cxf version 0.9 is it still working but then the serviceName is wrong: CalculatorWebServiceService instead of Calculator

Hi @querdenker2k Can you post an example of what the WSDL should look like?  My initial guess is that it may be a Jandex index issue in your setup, though I did not go through your code.

It's the unmodified wsdl from your repo from the tests

@querdenker2k Is there a reason you have this line?  I believe that may be the root cause of your issue, it's not quite a valid implementation class with that annotation.
https://github.com/querdenker2k/cxf-servicename-reproducer/blob/main/impl/src/main/java/io/quarkus/cxf/reproducer/impl/CalculatorWebServiceImpl.java#L8

ahh nice, i didn't know that this occurs in such an error.
but in fact i have a further problem for which i wrote the reproducer.
the @WebService#serviceName annotation was not read.
Instead of Calculator the service name inside the generated wsdl is CalculatorWebServiceService

Yes, that appears to be a valid issue.  Will try to have it addressed in the next release.  Thanks!

@shumonsharif can you say when a new release will be created

Hey @querdenker2k Apologies, I wasn't sure if you needed this quickly -- otherwise I could have given you a patch release a while back.  I'm going to do a release in the next few hours.

i am waiting for https://github.com/quarkusio/quarkus/issues/25325 as well. but i hope the next release will come in a few days.

Just released quarkus-cxf 1.2.0.

i am waiting for quarkusio/quarkus#25325 as well. but i hope the next release will come in a few days.

This issue should already be fixed in Quarkus 2.10.
Can you please test and let me know if everything is working as expected?

Yes, thanks a lot, its working as expected. But Quarkus 2.10 hasn't been released yet.


Is there a way how to get working without Android?

Hi,
After a year and half I got my Qube bulbs but as you know there is no iOS app yet. Is there a way how to register bulbs and get them working? And even worst... I turned Qube on but I cannot see it Bluetooth devices. There is no manual in the package. Pretty basic questions, I know, but your knowlegde about Qube is really valuable in this time. :)
Thanks

I'm afraid I didn't reverse engineer that bit, so I don't know :(

(In theory yes it should be possible to do so, but it'd involve figuring out the entire registration process)


False errors in files, compiled with partials

I'm using gulp-file-include to move repetitive parts of my html pages (like page header and footer) to outside files. However, gulp-html does not seem to use the compiled version for its validation, because it gives me errors about missing title element within head (which is inside one of the partials).
Here's a shortened version of my gulpfile.js:
var gulp            = require('gulp');
var gulpFileInclude = require('gulp-file-include');
var gulpHtml        = require('gulp-html');

gulp.task('html', function () {
    return gulp.src('src/*.html')

        // Include partials
        .pipe(gulpFileInclude({
            prefix:   '<!-- partial:',
            suffix:   ' -->',
            basepath: 'src/partials/',
            context:  {
                'compileJs': false
            }
        }))

        // Validate
        .pipe(gulpHtml())
        .pipe(gulp.dest('dist/'));
});

Am I missing something or is it a bug?

However, gulp-html does not seem to use the compiled version for its validation, because it gives me errors about missing title element within head (which is inside one of the partials).

@kpobococ I know this is an old issue, but I ran into it today while using gulp-html for the first time. I solved it by moving validation to a separate task.
gulp.task('html', function () {
    return gulp.src('src/*.html')
        // Build HTML here using something like a static site generator
        .pipe(gulp.dest('dist/'));
});

gulp.task('validate', function () {
    return gulp.src('dist/*.html')
        .pipe(validator())
        .pipe(gulp.dest('dist/'));
});

To me it seems like this defeats the purpose of Gulp streams... you should just be able to .pipe the compiled HTML into the validator(). For whatever reason, it seems to only work in a separate task.

For whatever reason, it seems to only work in a separate task.

I think he doesn't have a job, nor does he have a job in a separate task, sometimes it only reports running errors.
I tried to change the checked html code to a mess, and he didn't give any hints.
@XhmikosR

True. Most projects I've used this on, I ended up turning it off later when it threw random errors and blocked deployments. Hasn't been super useful.


docs: document kernel requirements

Add section to install document with some kernel requirements for
the different gadgets.
Fixes https://github.com/kinvolk/inspektor-gadget/issues/233

This PR completed a task in the TODO list of PR https://github.com/kinvolk/inspektor-gadget/pull/227.


its not working now...

hello,
I got this error, I wonder was if you may help on it.  Thanks.
he following exception was raised:
Cannot read properties of undefined (reading 'textContent')

Hi, the extension does not work for me as well, even though I get a different error message (data.getElementsByTagName(...)[0] is undefined).  If so, would you mind posting here an example recording? Could you also write which browser you are using and the extension version you have currently installed?

I have tried the latest Firefox and chrome on different PC and Mac but the result I got was the same.
Pass: vPEBD42K
https://chaochi.my.webex.com/chaochi.my/ldr.php?RCID=ccd7a7f86fc489bda2d290a7e9f59812

Simone @.***> 於 2022年5月5日 上午12:24 寫道：

Hi, the extension does not work for me as well, even though I get a different error message (data.getElementsByTagName(...)[0] is undefined).  If so, would you mind posting here an example recording? Could you also write which browser you are using and the extension version you have currently installed?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.

I made a PR that seems to be fixing the issue. You can wait for an official update from this repository or, if you are in a hurry, download it from my fork.


Update readme file

The current README file needs to be updated to provide clearer and more up-to-date information about the project. The current file lacks important details, such as instructions on how to install and run the project, and the latest changes made to the codebase.
To improve the project's documentation and make it more user-friendly for potential contributors and users, we need to update the README file. The updated file should include the following information:
Project description and goals
Instructions on how to install and run the project
Information about the latest changes made to the codebase
Contribution guidelines for potential contributors
Contact information for the project maintainers
By updating the README file, we can ensure that potential contributors and users have a clear understanding of the project and how to use it, which will ultimately improve the project's success and sustainability.

I have created a new readme with the details.


Build universal2 binaries on macos

I had to bump python to 3.11 version to make build running again. Pyinstaller also supports universal2 binaries (arm64 and amd64).

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thank you!


Unify should automatically implement replacements on work variables

The mmj2 tool enables someone to edit a single work variable into an expression, then press "unify" and automatically do a replacement of the work variables. So anyone who has used mmj2 will expect the same thing to work in metamath-lamp, even though it doesn't. Metamath-lamp does support replacement, but not in the same way.
It'd be very helpful if "unify" noted that work variables had been substituted with a specific expression, and then automatically apply applied that replacement everywhere if it had already occurred.

I think that in typical cases a work variable will only be replaced when it's already known what the justification & input labels are. That information could be used to instantly determine what the work variable value must become, and then quickly do a substitution across all statements if there's been such a replacement.

I think this is related to #77. In particular, I suspect implementing a full (syntactic) unification algorithm as described there would also resolve this issue.

I think that in typical cases a work variable will only be replaced when it's already known what the justification & input labels are. That information could be used to instantly determine what the work variable value must become, and then quickly do a substitution across all statements if there's been such a replacement.

This is very similar to what I meant by "I already have one idea what I can do" in this comment https://github.com/expln/metamath-lamp/issues/77#issuecomment-1579393093 Thanks for confirming that this is a typical case.

Sure! In the long term I think implementing "full unification" (at least as an option) is the best long-term move, as it's a more powerful algorithm & is what users of other tools are expecting. But I appreciate that implementing a subtle core algorithm takes time. The tool is already useful now; added power like that will just make it even more useful :-).


Dilithium cleanup - Remove obsolete code

https://github.com/Azure/azure-sdk-tools/issues/7640
https://github.com/Azure/azure-sdk-tools/issues/7667
https://github.com/Azure/azure-sdk-tools/issues/7811
https://github.com/Azure/azure-sdk-tools/issues/7812
https://github.com/Azure/azure-sdk-tools/issues/7813
https://github.com/Azure/azure-sdk-tools/issues/7840
https://github.com/Azure/azure-sdk-tools/issues/8183
https://github.com/Azure/azure-sdk-tools/issues/8184
https://github.com/Azure/azure-sdk-tools/issues/8201
https://github.com/Azure/azure-sdk-tools/issues/8279

As of 5/7/2024, before any removals, the BuildAndPublish step takes about 4m 49s:
https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=9543760&view=logs&s=8eb591c4-07e5-59cf-b484-30a7418d5e17

Closing. There few items left, but they have been deprioritized.


Change or allow configuration of log levels

The log level for "start" and "done" for each job is info. I would like to not have these logs in production, as we have a high volume of jobs.
I thought about lowering my production log level to warn, but I would like the phoenix request log messages, and they are also at info.
Two solutions that would work for me:

Change start and done to debug. I'm not sure if this would be ideal for others. I would keep fail at info or change it to warn.
Allow for configuring the level of each call. I could also see someone wanting to log done and fail, but not start. This should be doable with Logger.log/3, however it does recommend using the macros as they are optimized out at compile time.
Another option that would be less ideal, but simple and would be an improvement for me, is to just change fail to log at warn.

I'd be happy to write up a pull-request if there's agreement on a direction.

I'm not sure what's the best approach here. I'm not happy with any of the "two" (you listed 3 :P) solutions.
What I can promise is that I will think about this. I always thought that the Logging could be done by adding an GenEvent handler for the job tracking (https://github.com/edgurgel/verk#error-tracking). I'm not sure how it would impact Verk. Then we could open an option to not start this handler and you could have a custom handler to log however you may want?

I'm not happy with any of the "two" (you listed 3 :P) solutions.

That's fair. (I added a third at the last minute and forgot that I had specified "two").
I like the separate handler idea, although it may be a little more involved for me to help with.
Thanks for taking the time to think about this, being able to configure log levels would help me as I have these messages filtered out, but am still seeing these errors from heroku because of our high volume of log messages:
heroku/logplex: Error L10 (output buffer overflow): 67855 messages dropped since 2016-05-12T15:40:33+00:00.

Reviving this one. I'm logging way too much and the start/done message are not useful to me. Any reason you don't like option #2 above @edgurgel? I was imagining:
def start(%Job{jid: job_id, class: module}, process_id) do
  log_msg = "#{module} #{job_id} start"
  metadata = [process_id: inspect(process_id)]

  case Application.get_env(:verk, :start_job_log_level, :info) do
    :debug => debug(log_msg, metadata)
    :info => info(log_msg, metadata)
    :warn => warn(log_msg, metadata)
    :error => error(log_msg, metadata)
end

A bit verbose, but it allows for using the compile time optimized macros and configuration of each log message individually.

@keyan, yeah I don't mind having these options. Maybe just use Logger.log/3 and pass the level for each one (start_job, finish_job, etc) ? Do you want to send a PR?

Sure I'll open a PR 👍

@keyan wow, thanks for tackling this +1


Ruby: 2.3.6 -> 2.3.7, 2.4.3 -> 2.4.4, 2.5.0 -> 2.5.1

Motivation for this change
https://www.ruby-lang.org/en/news/2018/03/28/ruby-2-5-1-released/
https://www.ruby-lang.org/en/news/2018/03/28/ruby-2-4-4-released/
https://www.ruby-lang.org/en/news/2018/03/28/ruby-2-3-7-released/
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Fits CONTRIBUTING.md.

@GrahamcOfBorg build ruby_2_3 ruby_2_4 ruby_2_5

Failure on x86_64-darwin (full log)
Attempted: ruby_2_3, ruby_2_4, ruby_2_5
Partial log (click to expand)
/nix/store/8w6pi3r039shvkn0sprwg88bqwyla7ri-ruby-2.5.1/lib/libruby.2.5.1.dylib: fixing dylib
/nix/store/8w6pi3r039shvkn0sprwg88bqwyla7ri-ruby-2.5.1/lib/libruby.2.5.1.dylib: fixing dylib
/nix/store/8w6pi3r039shvkn0sprwg88bqwyla7ri-ruby-2.5.1/lib/libruby.2.5.1.dylib: fixing dylib
/nix/store/8w6pi3r039shvkn0sprwg88bqwyla7ri-ruby-2.5.1/lib/libruby.2.5.1.dylib: fixing dylib
/nix/store/8w6pi3r039shvkn0sprwg88bqwyla7ri-ruby-2.5.1/lib/libruby.2.5.1.dylib: fixing dylib
/nix/store/8w6pi3r039shvkn0sprwg88bqwyla7ri-ruby-2.5.1/lib/libruby.2.5.1.dylib: fixing dylib
/nix/store/8w6pi3r039shvkn0sprwg88bqwyla7ri-ruby-2.5.1/lib/libruby.2.5.1.dylib: fixing dylib
/nix/store/8w6pi3r039shvkn0sprwg88bqwyla7ri-ruby-2.5.1/lib/libruby.2.5.1.dylib: fixing dylib
/nix/store/8w6pi3r039shvkn0sprwg88bqwyla7ri-ruby-2.5.1/lib/libruby.2.5.1.dylib: fixing dylib
error: build of '/nix/store/r44jywbmcjwvqf9b9z6ih5kd6pl1cdfi-ruby-2.4.4.drv', '/nix/store/y3w7x2hh7wa55fmhn4f2vcypbalan9mm-ruby-2.3.7.drv' failed

Success on aarch64-linux (full log)
Attempted: ruby_2_3, ruby_2_4, ruby_2_5
Partial log (click to expand)
shrinking /nix/store/7shrvbzy1z9ylc60yi4dacajq5xq0b50-ruby-2.4.4/lib/ruby/2.4.0/aarch64-linux/ripper.so
shrinking /nix/store/7shrvbzy1z9ylc60yi4dacajq5xq0b50-ruby-2.4.4/lib/ruby/2.4.0/aarch64-linux/socket.so
gzipping man pages under /nix/store/7shrvbzy1z9ylc60yi4dacajq5xq0b50-ruby-2.4.4/share/man/
strip is /nix/store/gp7fylxwn18b7pl2c18ks89hsiaxyfvf-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/7shrvbzy1z9ylc60yi4dacajq5xq0b50-ruby-2.4.4/lib  /nix/store/7shrvbzy1z9ylc60yi4dacajq5xq0b50-ruby-2.4.4/bin
patching script interpreter paths in /nix/store/7shrvbzy1z9ylc60yi4dacajq5xq0b50-ruby-2.4.4
checking for references to /build in /nix/store/7shrvbzy1z9ylc60yi4dacajq5xq0b50-ruby-2.4.4...
/nix/store/3i4x85p7sf1pb07kgasj19mjs2n3mgmk-ruby-2.3.7
/nix/store/7shrvbzy1z9ylc60yi4dacajq5xq0b50-ruby-2.4.4
/nix/store/876kfpdfr351k7yxcmz6f95z9jlp66xr-ruby-2.5.1

Seems like the darwin failure is:
linking miniruby
ld: framework not found Foundation
clang-5.0: error: linker command failed with exit code 1 (use -v to see invocation)
make: *** [Makefile:221: miniruby] Error 1
builder for '/nix/store/4ffqylmb1ak3zkhl062c4djksdza1sjc-ruby-2.3.7.drv' failed with exit code 2

not sure what's that about

@manveru I guess this version conditional isn't correct. https://github.com/manveru/nixpkgs/blob/f99ded298f5b34437395cc739d52042b4dce3580/pkgs/development/interpreters/ruby/default.nix#L97

Success on x86_64-darwin (full log)
Attempted: ruby_2_3, ruby_2_4, ruby_2_5
Partial log (click to expand)
/nix/store/kvhi4g2m2q9qwrq5s62a1jacr8cmk91c-ruby-2.4.4/lib/libruby.2.4.4.dylib: fixing dylib
/nix/store/kvhi4g2m2q9qwrq5s62a1jacr8cmk91c-ruby-2.4.4/lib/libruby.2.4.4.dylib: fixing dylib
/nix/store/kvhi4g2m2q9qwrq5s62a1jacr8cmk91c-ruby-2.4.4/lib/libruby.2.4.4.dylib: fixing dylib
/nix/store/kvhi4g2m2q9qwrq5s62a1jacr8cmk91c-ruby-2.4.4/lib/libruby.2.4.4.dylib: fixing dylib
/nix/store/kvhi4g2m2q9qwrq5s62a1jacr8cmk91c-ruby-2.4.4/lib/libruby.2.4.4.dylib: fixing dylib
/nix/store/kvhi4g2m2q9qwrq5s62a1jacr8cmk91c-ruby-2.4.4/lib/libruby.2.4.4.dylib: fixing dylib
/nix/store/kvhi4g2m2q9qwrq5s62a1jacr8cmk91c-ruby-2.4.4/lib/libruby.2.4.4.dylib: fixing dylib
/nix/store/zabxkadxi7a06pyykya6gg4z2c6cqabr-ruby-2.3.7
/nix/store/kvhi4g2m2q9qwrq5s62a1jacr8cmk91c-ruby-2.4.4
/nix/store/y51mqdkwg0snv5gkrap45adrwkag5x6z-ruby-2.5.1

Success on aarch64-linux (full log)
Attempted: ruby_2_3, ruby_2_4, ruby_2_5
Partial log (click to expand)
shrinking /nix/store/7shrvbzy1z9ylc60yi4dacajq5xq0b50-ruby-2.4.4/lib/ruby/2.4.0/aarch64-linux/ripper.so
shrinking /nix/store/7shrvbzy1z9ylc60yi4dacajq5xq0b50-ruby-2.4.4/lib/ruby/2.4.0/aarch64-linux/socket.so
gzipping man pages under /nix/store/7shrvbzy1z9ylc60yi4dacajq5xq0b50-ruby-2.4.4/share/man/
strip is /nix/store/gp7fylxwn18b7pl2c18ks89hsiaxyfvf-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/7shrvbzy1z9ylc60yi4dacajq5xq0b50-ruby-2.4.4/lib  /nix/store/7shrvbzy1z9ylc60yi4dacajq5xq0b50-ruby-2.4.4/bin
patching script interpreter paths in /nix/store/7shrvbzy1z9ylc60yi4dacajq5xq0b50-ruby-2.4.4
checking for references to /build in /nix/store/7shrvbzy1z9ylc60yi4dacajq5xq0b50-ruby-2.4.4...
/nix/store/3i4x85p7sf1pb07kgasj19mjs2n3mgmk-ruby-2.3.7
/nix/store/7shrvbzy1z9ylc60yi4dacajq5xq0b50-ruby-2.4.4
/nix/store/876kfpdfr351k7yxcmz6f95z9jlp66xr-ruby-2.5.1

Backported to 18.03 in 94a3649e4ca.


Fails when input is stdin

What version of @tailwindcss/jit are you using?
v0.1.3
What version of Node.js are you using?
N/A
What browser are you using?
N/A
What operating system are you using?
macOS
Reproduction repository
N/A

This is with TAILWIND_MODE=build and the CSS passed in to postcss-cli via stdin:

Error: ENOENT: no such file or directory, stat '/Users/bep/dev/sites/hugo-starter-tailwindjit-basic/stdin'

Hey thanks for the report! This is ultimately going to be the same issue as #74, so going to track there.


[TASK]: Set up repo

Summary
Set up the repository for the schemaver tool
Definition of Done

[ ] Developers can install schemaver locally

Resolved by #5


workflows: fix copy-paste mistake

Found a small-ish mistake from #940. This pull request fixes that.
Sorry for the inconvenience :)

Addendum:
As most swearwords.go PRs are made by first-time contributors, this workflow requires prior approval. This kind of defeats the purpose, hence I removed it entirely. It'll now only comment on PRs against master in general (for contributors).
This limitation is imposed by GitHub themselves, which is rather annoying, but it is how it is.


Re-implement and test Manifestation::update

Re-implement and test Manifestation::update
This is the function that keeps an installation updated on
a distribution channel.
update takes a manifest describing a release of Rust
(which may be either a freshly-downloaded one, or the
same one used for the previous install), as well as lists
off extension components to add and remove.
From that it schedules a list of components to uninstall
and to uninstall to bring the installation up to date.
It downloads the components' packages. Then in a Transaction
uninstalls old packages and installs new packages,
writes the distribution manifest to "rustlib/multirust-dist.toml"
and a configuration containing the component name-target
pairs to "rustlib/multirust-config.toml".
This implementation is simpler than the existing one,
mostly because it doesn't reuse the manifest to represent
what is installed, but instead stores a list of installed
components. It also doesn't perform transformations on
the mamnifest itself to calculate the install set; rather
all the calculations are done over lists of Component.
Move MockInstallerBuilder into rust-install.
Next steps
I'm starting to get the lay of the land and have a more clear idea how to get to the end point. What I'm thinking of doing next is.

Wire the new installation code into the program and write integration tests of the binary itself, focusing on error and notification cases.
Replace v1 sh/msi installation code with new installation code, remove msi installer, move windows rustlib from bin to lib. Not planning on creating a transition plan; instead with the rustup rebranding we'll just start from scratch, not use the .multirust directory.
Add component selection to the cli.
Modify the install code further to not maintain compatibility with rust-install's metadata, instead using multirust-rs's own
Refactor crate organization a bit: combine rust_install and rust_manifest into multirust_dist (I like 'dist' better here since it encompasses interop with the distribution servers, which I consider separate from the installers, leaves room for a separate multirust_install crate). Possibly reorginize how the bin and lib are layed out - right now their sources share a single src directory, I might want to separate them into multirust and multirust-cli or something.
Rebrand to rustup: change all the internal names.
Change the installation procedure to install to $CARGO_HOME/bin and from the PATH variable, change how cargo's home directory is treated internally.
Work on the rustup.rs website.

That will get us more or less to the point where we can think about deploying rustup.rs and getting feedback.
After that we can look into NDK installation, a windows GUI installer, and Visual Studio integration.
Let me know how this plan looks to you. I'm most apprehensive about how to do a smooth transition from the worlds of multirust/multirust-rs/rustup.sh to rustup.rs. If you have much free time we may be able to divide up some of the work.

@Diggsey I've pushed a commit that address the build issues with this PR. I'm still working on the refactoring we discussed - moving the component list into the installer, and I'd like more time to do that in a follow up. Can we merge this when it passes?

32-bit linux failed, but it was a problem with the travis script :unamused:


bug with trifurcations

Are trifurcations allowed in valid morphs? I thought only bifurcations where valid.

some reconstructions  have them, but our code support it, but in the wrong way, so better to have  it supported properly

ok


CaseReference Data has unneeded / confusing column data B-G

From @aimeehan1

@aimeehan1 Can you give me some more info about this issue? I'm not sure where it occurs.

When the full dataset is downloaded from the portal, columns B-F have "CaseReference" data that includes; caseReference.additionalSources, caseReference.sourceId, caseReference.sourceUrl, caseReference.uploadIds, and caseReference.verificationStatus (please see [screenshot document (https://docs.google.com/document/d/1Wt2z2D37seaf6dxE4ySsnRzcYP7ozvW4TArHcCiDJRg/edit?usp=sharing) JAS 2024-03-25, image 1).
@aimeehan1 please jump in if I am wrong or if you had something else in mind, but source ID, upload ID, and verification status are not needed in this download.

My bad, I did not realize what B-G means 😄

Download Examples loaded in our SimEx folders.


Convert remaining network logs to structured logs

Overview
This converts the remaining logs to structured logs.
Key takeaways:

We can take advantage of ConnectionMetadata, to connect logs to a specific instance of a connection
We need to review levels of logs and strategies holistically after this e.g. not error! when a loop is terminated on purpose.
A couple logs can't currently easily copy the network context in its current form e.g. loop of moves within a move.

:exclamation: Invalid command

Bors help and documentation

Bors is a Github App used to manage merging of PRs in order to ensure that CI is always green. It does so by maintaining a Merge Queue. Once a PR reaches the head of the Merge Queue it is rebased on top of the latest version of the PR's base-branch (generally master) and then triggers CI. If CI comes back green the PR is then merged into the base-branch. Regardless of the outcome, the next PR is the queue is then processed.
General

This project's Merge Queue can be found here.
This project requires PRs to be Reviewed and Approved before they can be queued for merging.
Before PR's can be merged they must be configured with "Allow edits from maintainers" enabled. This is needed for Bors to be able to update PR's in-place so that Github can properly recognize and mark them as "merged" once they've been merged into the upstream branch.

Commands
Bors actions can be triggered by posting a comment which includes a line of the form /<action>.

Command
Action
Description

Land
land, merge
attempt to land or merge a PR

Canary
canary, try
canary a PR by performing all checks without merging

Cancel
cancel, stop
stop an in-progress land

Cherry Pick
cherry-pick <target>
cherry-pick a PR into <target> branch

Priority
priority
set the priority level for a PR (high, normal, low)

Help
help, h
show this help message

Options
Options for Pull Requests are configured through the application of labels.

          Option
Description

Indicates that the PR is high-priority. When queued the PR will be placed at the head of the merge queue.

Indicates that the PR is low-priority. When queued the PR will be placed at the back of the merge queue.

Before merging the PR will be squashed down to a single commit, only retaining the commit message of the first commit in the PR.

Love the PR. My biggest concern is that we probably need to make it really easy to disable logging / log pushing from VFNs. cc: @sherry-x

I guess your concern is about the explosion of logs from the PeerIds?  I agree that we'll need a way to prevent logging from VFNs.  Let's create an issue for it and follow up

/land


Feature/398 static fe

https://trello.com/c/0xR0uMZQ/398-implement-front-end-checkbox-elements-for-filters?filter=label:Tech
Change description
Implements the components needed for the /download page. There are no tests currently, but these can be implemented as we work on connecting the filters to the backend.
Some extra details are needed (specified in the TODOs) but are not considered a priority at the moment.

[ ] Unit tests and other appropriate tests added or updated
[ ] README and other documentation has been updated / added (if needed)
[ ] Commit messages are meaningful and follow good commit message guidelines (e.g. "FS-XXXX: Add margin to nav items preventing overlapping of logo")

How to test
If manual testing is needed, give suggested testing steps
Screenshots of UI changes (if applicable)

@bobbi-hbrown the  govuk_frontend.zip file is still checked in. Please remove it, i.e.
git rm govuk_frontend.zip
git commit

pre-commit.ci autofix

@bobbi-hbrown LGTM 👍 but please squash and merge as commit history is quite messy.


Required Text Field Message Repeated

With swiftDialog <IP_ADDRESS>88, the required field message is displayed multiple times.

Testing Script
#!/bin/zsh

rm /var/tmp/dialog.log
touch /var/tmp/dialog.log
demoName="Required Text Field Message Repeated"
/usr/local/bin/dialog --title "$demoName" \
--quitkey k \
--messagefont "size=14" \
--ontop \
--moveable \
--textfield "Asset Tag",required=true,prompt="Please enter your Mac's seven-digit Asset Tag",regex="^(AP|IP)?[0-9]{6,}$",regexerror="Please enter (at least) seven digits for the Asset Tag, optionally preceed by either AP or IP." \
--message "An **Asset Tag** is required and needs to be provided in the following format:  \n• Seven digits (or more)  \n• Optionally proceeeded by _AP_ or _IP_  \n\n**Steps to replicate**  \n\n1. Click **OK** three times  \n2. Enter _five_ random numbers  \n3. Click **OK**  \n4. Observe the required field message is repeated multiple times"

Can I just say @dan-snelson that I love the inclusion of the test script 🙂 - brilliant way to demonstrate and explain the issue

LGTM with <IP_ADDRESS>86


Why im loosing value attribute randomly?

I have a piece of code to reprocess with some logic a group of entities in an api rest service controller.
In production environment ive started to get exceptions aparently impossible in a logic sense like this one:
>Mensaje:Value cannot be null.
>Parameter name: source
>Source:System.Linq
>InnerException:
>StackTrace:   at System.Linq.Enumerable.Where[TSource](IEnumerable`1 source, >Func`2 predicate)

When i tried to reproduce the error in local environment or event in production environment i figured out that this happen only randomly times making it extremly hard to reproduce it.
After lots of test i get once and just once reproduce the exception in while debuging and i found that from one line to another i get one of the entity attributes null without reason that i can understand.
In first instance i believe that maybe i was taking too much entities in only one DB context instance so i tried to make smaller list. But the error still happening. indeed with only 15 entities i still geting the exception.
This is how the code structure looks:
private static void StartProces( List<Someentitie> someentitie)
{
	const int packageAmount = 200;
	var index = 0;

	while (indice < fichadas.Count )//sometimes are 15, sometimes are 10.000. I get the error in both cases.
	{
		var myEntitiePackage = someentitie.Skip(index).Take(packageAmount).Select(f => f.Id).ToList();
		index += packageAmount - 1;

		var optionsBuilder = new DbContextOptionsBuilder<MyContext>();
		optionsBuilder.UseSqlServer(AppSettingsHelper.ConnectionStrings.DefaultConnection)
			.UseLoggerFactory(LoggingHelper.LoggerFactory);
		var newDb = new MyContext(optionsBuilder.Options);

		var myEntities = newDb.Entities.Where(f => myEntitiePackage.Contains(f.Id)).Include(f => f.subEntitie)
			.Include(f => f.anotherSubEntitie)
			.Include(f => f.AnotherSubSubEntitite).ToList();

		myEntities.ForEach(f =>
		{
			f.ReProcess(dbNuevo);
		});
	}
}

public void ReProcess(MyContext db)
{
	CleanAndSaveMyEntitie(db);
	FillEntitieWithBasicAttributesAndSave(db)

	// At this point this.importantAttribute has a value

	new AuditoryLine(this, userId).Create(db);
	db.SaveChanges();

	// At this point this.importantAttribute is null

	....
}

DbContext is not thread safe. I believe point of issue is using ForEach with passing DbContext to ReProcess method inside. Since code snippet does not reveal whole code inside ReProcess it would be hard to tell what causes it. But SaveChanges concurrently like that are likely to cause weird errors.
Either create new DbContext inside ReProcess method or remove ForEach and iterate over each entity at a time.

I make the foreach change, but still happening the exception

@ufalak We're likely going to need a small, runnable project/solution or complete code listing that demonstrates the behavior you are seeing. I understand that this may not be easy, but realistically it's the only way we can make progress here.

A novelty on this is that also with only one entity also im having this issue.
Thats mean that this doesnt have any relation with possible multiple threads or memory overloading or something like that.

@ufalak We're likely going to need a small, runnable project/solution or complete code listing that demonstrates the behavior you are seeing. I understand that this may not be easy, but realistically it's the only way we can make progress here.

Maybe can help if i put a piece of log tracking all of this?

@ufalak then please post a project that demonstrates the issue

Ok i will post the method that make this happend. Its a bit long.
Maybe it will be useful to you if i post the log file where you can see the object attribute state and db queries?

@ufalak We need to debug your code to figure out what is going on. We are unlikely to be able to help you until you post code that we can run.

Ok so, close the issue.
Its imposible to me to post the entire runable code.
One reason is that is huge all of the logic, and model entitites that i need to post to make it runnable.
Another is because of the confidentiallity with my client
I can give you pieces of code (not runnable) or log info.
But runnable code, imposible.


safari on macbook having problems running bogle.tools

webassembly problem on browser? settings?
https://www.bogleheads.org/forum/viewtopic.php?p=7354134#p7354134

unsure what that problem was. closing, but know user if others start hitting this.


Can you add a shortcut to --delete-conflicting-outputs

Thank you for the plugin, It is convenient one shortcut to run it, but can you add option with --delete-conflicting-outputs

Nevermind - it does it already I had other issue with flutter/dart in path missing


Master: Support for extraVolumeMounts

Add Support for extraVolumeMounts in workergroup chart config. Allow externally created volume claims, or host mount or empty dir mounts  to be mounted within the cribl containers in the pods.

Implemented in 161288c