Changes to use release API docs

This PR contains two commits. The first one adds a link to JavaDocs into https://drill.apache.org/docs/ page and updates old links to 1.2.0 JDBC API.
The second commit removes JavaDocs for 1.2.0 JDBC and adds JavaDocs for all classes for new (1.17.0) release.

+1


move and improve AEON:0000027 'academic field descriptor'

Once https://github.com/information-artifact-ontology/IAO/pull/256 is merged, AEON:0000027 'academic field descriptor' should be moved under IAO:0020020 code set and its definition must be worked on in order to properly reflect this better ancestry. It also might be better to rename it to something along the lines of 'academic field code set'.

closed because of being a duplicate of #108


Generated flatmap accessors for providers

When connecting providers, it currently requires using flatMap() in some cases that looks out-of-place and adds noise in the DSL:
consumer {
    // Connect the producer task output to the consumer task input
    // Don't need to add a task dependency to the consumer task. This is automatically added
    inputFile = producer.flatMap { it.outputFile }
}

It would be great if users could reference the property directly:
consumer {
    // Connect the producer task output to the consumer task input
    // Don't need to add a task dependency to the consumer task. This is automatically added
    inputFile = producer.outputFile
}

This could be made possible if we generated accessor methods for @Nested property types and task types, adding an accessor for each of their properties, like so:
fun Provider<ProducerTask>.getOutputFile() = this.flatMap { it.outputFile }

Note that Provider has a couple methods that work like property accessors already: isPresent() and getOrNull() would result in conflicts, so we should explicitly filter these. TaskProvider also has a getName().

consumer {
// Connect the producer task output to the consumer task input
// Don't need to add a task dependency to the consumer task. This is automatically added
inputFile = producer.flatMap { it.outputFile }
}consumer {
// Connect the producer task output to the consumer task input
// Don't need to add a task dependency to the consumer task. This is automatically added
inputFile = producer.outputFile
}fun Provider.getOutputFile() = this.flatMap { it.outputFile }

Let's do this if we see this as a problem after the migration.


latest-portable out of date

latest-portable was last pushed 2 months ago so it looks like it has not been updated to 1.4.0-portable.   Actually using it confirms this - new command line option is missing from latest-portable.

Thanks for the heads-up! Will be looking into it.
In the meantime, nowadays (i think since v1.4.0) the regular :latest image is the portable build.

See also https://github.com/flashbots/mev-boost/issues/422

resolved, latest-portable is no longer available, and the latest image on docker hub is a portable build


[SPARK-21000][MESOS] Add Mesos labels support to the Spark Dispatcher

What changes were proposed in this pull request?
Add Mesos labels support to the Spark Dispatcher
How was this patch tested?
unit tests

Test build #77780 has started for PR 18220 at commit ee10af6.

Test build #77780 has finished for PR 18220 at commit ee10af6.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77780/
Test FAILed.

Test build #77781 has started for PR 18220 at commit 9c21758.

Test build #77781 has finished for PR 18220 at commit 9c21758.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77781/
Test PASSed.

Test build #77782 has started for PR 18220 at commit e09f55a.

Test build #77782 has finished for PR 18220 at commit e09f55a.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77782/
Test FAILed.

Test build #77785 has started for PR 18220 at commit 3d847a1.

Test build #77785 has finished for PR 18220 at commit 3d847a1.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77785/
Test FAILed.

Test build #77786 has started for PR 18220 at commit b32eb8a.

Test build #77786 has finished for PR 18220 at commit b32eb8a.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77786/
Test PASSed.

Merged build finished. Test PASSed.

@srowen Can we get a merge?  @ArtRand is a engineer working on Spark here at Mesosphere, and has approved these changes.
Thanks.

Test build #77816 has started for PR 18220 at commit 40707fe.

Test build #77817 has started for PR 18220 at commit 79c119c.

Test build #77816 has finished for PR 18220 at commit 40707fe.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77816/
Test FAILed.

Test build #77817 has finished for PR 18220 at commit 79c119c.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77817/
Test FAILed.

Test build #77818 has started for PR 18220 at commit a381419.

Test build #77818 has finished for PR 18220 at commit a381419.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77818/
Test PASSed.

Merged build finished. Test PASSed.

@srowen All comments addressed.  Tests are passing.

Test build #77851 has started for PR 18220 at commit 616c1b1.

Test build #77851 has finished for PR 18220 at commit 616c1b1.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77851/
Test FAILed.

Test build #77852 has started for PR 18220 at commit 218ab0d.

Test build #77852 has finished for PR 18220 at commit 218ab0d.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77852/
Test FAILed.

Test build #77855 has started for PR 18220 at commit fe916b2.

Test build #77855 has finished for PR 18220 at commit fe916b2.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77855/
Test PASSed.

Merged to master


Multiple responses for one request, and their order

Hello, I am setting up a data forwarding network using litep2p. May I ask a question about the RequestResponse protocol behavior.
Does the RequestResponse protocol support sending multiple responses from the response side for one request? If so, will these responses be received in sequence by the requesting side?

The connection closed after sending one response.
Fortunately, according to the libp2p specification (https://docs.libp2p.io/concepts/fundamentals/protocols/#binary-streams), the data is read in the same order as it was written.
A customized protocol can be achieved by referring to the custom_protocol example and the implementation of RequestResponseProtocol.

Yes, request-response protocol only allows sending one response per request. Basically, a new substream is opened for every request and closed after receiving the response.


The generator is boxing properties of recursive types that do not need boxing

Description
👋 I am observing that the generator is boxing properties that do not need boxing
Reproduction
This OpenAPI spec:
components:
  schemas:
    MyStruct:
      type: object
      properties:
        myProperty:
          type: array
          items:
            $ref: '#/components/schemas/MyStruct'

Generates boxed code:
internal struct MyStruct: Codable, Hashable, Sendable {
    /// - Remark: Generated from `#/components/schemas/MyStruct/myProperty`.
    internal var myProperty: [Components.Schemas.MyStruct]? {
        get  {
            storage.value.myProperty
        }
        _modify {
            yield &storage.value.myProperty
        }
    }
    /// Creates a new `MyStruct`.
    ///
    /// - Parameters:
    ///   - myProperty:
    internal init(myProperty: [Components.Schemas.MyStruct]? = nil) {
        storage = .init(value: .init(myProperty: myProperty))
    }
    internal enum CodingKeys: String, CodingKey {
        case myProperty
    }
    internal init(from decoder: any Decoder) throws {
        storage = try .init(from: decoder)
    }
    internal func encode(to encoder: any Encoder) throws {
        try storage.encode(to: encoder)
    }
    /// Internal reference storage to allow type recursion.
    private var storage: OpenAPIRuntime.CopyOnWriteBox<Storage>
    private struct Storage: Codable, Hashable, Sendable {
        /// - Remark: Generated from `#/components/schemas/MyStruct/myProperty`.
        var myProperty: [Components.Schemas.MyStruct]?
        init(myProperty: [Components.Schemas.MyStruct]? = nil) {
            self.myProperty = myProperty
        }
        typealias CodingKeys = Components.Schemas.MyStruct.CodingKeys
    }
}

Package version(s)
├──<EMAIL_ADDRESS>│   ├──<EMAIL_ADDRESS>│   │   └──<EMAIL_ADDRESS>│   ├──<EMAIL_ADDRESS>│   ├──<EMAIL_ADDRESS>│   │   └──<EMAIL_ADDRESS>│   ├──<EMAIL_ADDRESS>│   └──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>│   └──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>│   ├──<EMAIL_ADDRESS>│   │   └──<EMAIL_ADDRESS>│   ├──<EMAIL_ADDRESS>│   └──<EMAIL_ADDRESS>└──<EMAIL_ADDRESS>
Expected behavior
This swift code is valid and compiles:
struct MYStruct {
    let myProperty: [MYStruct]
}

So I would expect that the generated code does not have any boxing.
Environment
swift-driver version: <IP_ADDRESS> Apple Swift version 5.10 (swiftlang-<IP_ADDRESS> clang-15<IP_ADDRESS>)
Target: arm64-apple-macosx14.0
Additional information
Originally raised in https://github.com/apple/swift-openapi-generator/issues/70#issuecomment-2501931241

Yes this looks like a bug. The Array is enough to break the cycle, so we shouldn't need to box it again.
The way to fix this would be to first write a failing snippet test with this case (look for the tests with the word "recursive" in the name for inspiration), and then update the boxing logic.
@acecilia, would you consider contributing a fix here, with our guidance?

Thanks for guidance 👌 Will try yes


docs: Pin Jinja2 & markupsafe

Hi, I'm the maintainer of doc2dash, a tool to create browsable docsets from Sphinx documentation. One of your users asked for help on my bug tracker about converting your docs and while trying to reproduce, I've noticed that the documentation doesn't build with the pins that you have in your requirements.txt because Jinja2 and markupsafe broke some backwards-compatability.
With the two I'm adding here, it works again.

I've noticed you're not building your docs in CI, so generally speaking if you have any questions that someone a bit more intimate with Python, docs, and packaging feel free to ask.
Cheers

thanks


Hide Apple Pay component by default and display it only if method is available

Summary
Hide Apple Pay component by default and display it only if method is available. Avoids front-side edge effects if the component is not displayed.
I also add an onNotAvailable function to avoid having to copy the whole function in case of modification in a theme.
Fixed issue:  #54

@hossam-adyen You know when this PR will be merged on main ?

Hi @dimitriBouteille, this would be release more likely next week

Hi @hossam-adyen Do you know when a tag or release will be created with the latest fixes?

Hi @dimitriBouteille, it has ben released today in version 1.2.0


WaitForMultipleObjects returns a u32, but we can't match over WAIT_TIMEOUT and WAIT_FAILED

Which crate is this about?
windows
Crate version
0.36.1
Summary
I want to do this:
let result = unsafe {
    th::WaitForMultipleObjects(
        &self.events,
        false,
        wp::INFINITE,
    )
};

match result {
    th::WAIT_ABANDONED_0 => /* wait abandoned */,
    t::WAIT_TIMEOUT => /* do something on timeout */,
    f::WAIT_FAILED => /* do something on error, like Error::from_win32() */,
    other => {
        let base = th::WAIT_OBJECT_0;

        if other < base {
            panic!("other out of bounds; other = {}", other);
        }

        let index = (other - base) as usize;

        /* do something with index */
    }
}

But WAIT_TIMEOUT and WAIT_FAILED can no longer immediately be used in a match statement like the above, since they are now wrapped in a WIN32_ERROR, instead we have to make your own wrapper for WAIT_ABANDONED_0:
const WAIT_ABANDONED_0 : f::WIN32_ERROR = f::WIN32_ERROR(th::WAIT_ABANDONED_0);

match f::WIN32_ERROR(result) {
    WAIT_ABANDONED_0 => /* wait abandoned */,
    t::WAIT_TIMEOUT => /* do something on timeout */,
    f::WAIT_FAILED => /* do something on error, like Error::from_win32() */,
    f::WIN32_ERROR(other) => {
        let base = th::WAIT_OBJECT_0;

        if other < base {
            panic!("other out of bounds; other = {}", other);
        }

        let index = (other - base) as usize;

        /* do something with index */
    }
}

Toolchain version/configuration
No response
Reproducible example
No response
Crate manifest
No response
Expected behavior
No response
Actual behavior
No response
Additional comments
No response

This comes straight from the win32 metadata - I'll transfer this issue to that repo for resolution.


a couple of minor cleanups

Coverage increased (+0.04%) to 74.81% when pulling b94e04e07641e7f6c0537025fd73c747a8abba79 on gbordyugov:gb/minor-cleanups into 5047141c7578321392c824fe37d62fcc7327a187 on zalando:dev.


libglog.pc: Set Libs.private for static linking

This implements suggestion from #57.
Before:
$ pkg-config --libs libglog
-lglog
$ pkg-config --libs --static libglog
-lglog

After:
$ pkg-config --libs libglog
-lglog
$ pkg-config --libs --static libglog
-lglog -lunwind -lpthread -lgflags

By the way, I was also trying get_target_property(some_output_variable glog LINK_LIBRARIES), but it provides raw cmake-style value such as unwind::unwind;-lpthread;gflags which would need complicated parsing and transformation, so the solution used in this pull request seems easier.

Codecov Report

Merging #787 (1f5efdf) into master (1883610) will increase coverage by 2.69%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #787      +/-   ##
==========================================
+ Coverage   72.72%   75.42%   +2.69%
==========================================
  Files          17       14       -3
  Lines        3256     2885     -371
==========================================
- Hits         2368     2176     -192
+ Misses        888      709     -179

Impacted Files
Coverage Δ

src/utilities.cc
65.28% <0.00%> (-2.36%)
:arrow_down:

src/base/mutex.h
100.00% <0.00%> (ø)

src/windows/dirent.h

src/windows/port.cc

src/windows/port.h

src/logging.cc
73.64% <0.00%> (+0.07%)
:arrow_up:

src/demangle.cc
97.59% <0.00%> (+0.11%)
:arrow_up:

src/signalhandler.cc
6.75% <0.00%> (+0.30%)
:arrow_up:

src/vlog_is_on.cc
70.54% <0.00%> (+0.31%)
:arrow_up:

src/symbolize.cc
64.68% <0.00%> (+0.57%)
:arrow_up:

... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1883610...1f5efdf. Read the comment docs.

Thanks!


Assignment 1 Christian Primavera

Introduction

Hi all, I'm Christian, currently in the first year of my PhD at QuTech. I recently moved to Rotterdam, and since then I have enjoyed cycling to and from the university!
Describe your research in 2-3 sentences to someone that is not from your field (please avoid abbreviations)

I focus on creating quantum particles in silicon, which interact strongly with light. The long-term goal of this is to transfer quantum information over long distances, eventually trying to build a quantum internet.
My research entails the following aspects:

Research Aspect
Answer

Use/collect personal data (health data, interviews, surveys)
No

Use/collect experimental data (lab experiments, measurements with instruments)
Yes

Collaborate with industry
Yes (probably, but not yet)

Write/develop software as the main output of the project
No

Use code (as in programming) for data analysis
Yes

Work with large data (images, simulation models)
Yes

Other:
N/A

Reflections on the importance of RDM videos

Measurement outcomes in quantum mechanics are inherently probabilistic. Results always follow from statistical analyses of large datasets and need to be interpreted. It is therefore very important that anyone else is able to reconstruct the same conclusions from the original dataset.
What would you like to learn during this course?

I would like to learn how to organise recorded data in a way that anyone can understand later on, and how to avoid common mistakes that can lead to loss of progress.
Checklist assignments

[x] Assignment 1: creating a GitHub issue (before 12 September, 10:00)
[x] Respond to the GitHub issue #65
[x] Assignment 2: Data Flow Map 1 (share a link in this issue before 20 September 13:00). Link: https://tud365-my.sharepoint.com/:p:/g/personal/cfprimavera_tudelft_nl/Edx9uy1M-U5IvoVw84_Jh7kB-KABjj84kxpw7RAdQ04_zg?e=fcGPMo
[x] Provide feedback to at least one Assignment 2 from another participant
[x] Respond to the GitHub discussion #66
[x] Respond to the GitHub discussion #67
[x] Assignment 3: Data Flow Map 2 (share a link in this issue before 4 October 13:00). Link: https://tud365-my.sharepoint.com/:p:/g/personal/cfprimavera_tudelft_nl/Ea9ei841m2lFlWyXgoaW9PMBXNdajm9_IxVV45eivtavpw?e=RFsJwc
[ ] Provide feedback to at least one Assignment 3 from another participant
[ ] Assignment 4: Data Management Plan (before 11 October, 13:00)
[ ] Respond to the GitHub discussion #68 if you have any questions (optional)
[ ] Assignment 5: Data Flow Map 3: submit your slide (before 17 October, 17:00)

Hi Christian, looks like a good data flow map. It's funny to think that in the event the TU Delft gitlab server permanently loses everything, the code is still mirrored onto the local computer of your collaborators as extra redundancy.
Maybe one thing you could detail is whether the measurement data is automatically or manually backed up to this online datastore folder, and how often this is done.

Hi Christian! I reviewed your data flow map, and I find it well-structured. I imagine that you will deal with several designs for experimental setups, how do you track and store the design files? Could you put them under version control using tools like git?

Thanks for sharing assignment 2 @cfprimavera ! It looks very concise and clear - well done!

Prompted by feedback from @pietro-sillano I want to point you to dataled. This is not a TU Delft solution but so far I received positive feedback. Subversion could be a TU Delft solution for data versioning.
I assume that with a TU Delft datastore folder you mean the Bulk/Project/Group drives? For confidential data it is important to consider who has access to the data - so the Project Drive may be a good solution there.
Will you have to take any notes or set up documentation for the steps taken to create the processed data? If yes: where will this information be stored?
I hope your storage solutions are sufficient to cover your needs? I don't see the specific sizes listed - hence the question
I also don't see specific file formats listed: file formats are an important theme in assignment 3!

Hi Christian,
Overall your data flow map looks good! I have a few points which might clarify some stuff.
Data organisation:

It looks like all in all you thought about where to save what. If you show the complete structure, this would make it clearer where to find what for others. You can even add this in your documentation for example in a README-file.

Documentation:

You are using notebooks to write stuff down when doing manual processing. Will the be jupyter notebooks or other types? Where are you going to store them?

Acces:

Who are the people with access to the project drive? Group members, only your supervisor. outside collaborators? It is good to specify especially since you are dealing with confidential data.
You describe that the dataset can be described as open at the end of the project, but it is also confidential. Is this confidentiality only temporary?

Data publication:

You write a question mark for the designs of the heat shields for how somebody could request access. I think the question is about who should they contanct, or what procedure to follow if someone wants access.

Thanks for sharing assignment 3 @cfprimavera! Looks great again - well done! Thanks also for adding the file sizes and formats!
I have very little feedback:
Data organisation

Just out of curiosity: why the difference between camel and snake case in your experiment type and analysis times? Is that to keep the two apart?

File format

hdf5 is indeed an open format!

Access/Data publication

Similar comment to what @Pjieter already brought up: is the data/code confidential until it can be published together with the publication?
And regarding @Pjieter's feedback for access requests: 4TU.ResearchData has such a functionality built in where you could share data/code under restricted access and then grant access to individuals when this is requested. This is generally more intended for personal data as confidential data should eventually be able to be shared (since you're also publishing) - but it could be a solution for data/code that has a long embargo period before it can be shared publicly. You can also only share parts and describe in the README file who people should contact for more information/data/code.


Chart missing style elements after navigating away to subpage via $location.path()

Please refer to http://ceed.ucdavis.edu/ for this issue. (I will try to create a simpler example in jsfiddle soon...)
I am using Highcharts solid gauge via the highcharts-ng directive.
When I click on Leaflet map markers, a sidebar on the left opens showing gauge charts for that marker:

Clicking between different map markers refreshes the charts with new data, by changing the $scope objects for each chart's configuration. These charts still look correct when clicking between markers:

However, when we go to a subpage via the $location.path() service by clicking on the "View Live Data" button, then go back to the main page (either using the browser's 'Back' button or clicking on the compass icon in the upper-right corner of the page), then click on a marker again, the charts are missing their grey background color and default back to white:

When I inspect the chart's <rect> element before going to the subpage, I can see the correct 'fill' attribute is there ( fill="#eeedee" ):

But it reverts to white ( fill="#fff" ) after, and the attribute class="highcharts-background" is missing:

I think I can hack around this issue for now by modifying the attributes for this <rect> element after each chart refresh, using document.querySelector() or the D3.js library.

Upon closer inspection, it's actually adding a second rect attribute with different x, y, and fill attributes. If I delete the second rect, the chart looks normal again.

I just found out that this problem also occurs without the directive (just vanilla Highstock/Highcharts), so it's not a highcharts-ng issue. Sorry for the confusion! I am closing this issue.


ASIM DNS schema parser with its sample and test data for SentinelOne

Required items, please complete
Change(s):

Added ASIM DNS schema parser for SentinelOne based on API Data

Reason for Change(s):

Initial version ASIM DNS Parser

Version Updated:

Initial version

Testing Completed:

Yes

Checked that the validations are passing and have addressed any issues that are present:

Yes

Hi @jayeshprajapaticrest,
Thank you for raising Pull Request with us! We will review it internally and get back to you by shortly.

Hi @jayeshprajapaticrest, hope you are doing well. Just wanted to check if you got a chance to look at the suggestions shared. Please feel free to reach out to us for any queries or support. Thanks!

Hi @jayeshprajapaticrest, hope you are doing well. Just wanted to check if you got a chance to look at the suggestions shared. Please feel free to reach out to us for any queries or support. Thanks!

@v-sudkharat We will look into above suggested changes and revert here as soon as possible.

@vakohl we have mapped the inspection fields below in the DNS parser, which we found from SentinelOne Alerts logs.
RuleName
Rule
ThreatConfidence
ThreatOriginalConfidence


unittest_discovery.py fails if same dir name present in test and source dirs

Type: Bug

Behaviour
Expected vs. Actual
This repro shows you can run python -m unittest and it will run/pass, but in VSCode either:

With defaults from Python: Configure Tests observe Error discovering unittest tests due to ImportError.
Add "-t",".", to start of "python.testing.unittestArgs": to see tests are discovered and runnable, but gutter doesn't work, and trying to open test file from testing panel opens file at wrong location (test/test/test_bar.py instead of test/test_bar.py).

Steps to reproduce:

Clone this repro
Observe missing gutter icons and bad path when opening test file from testing panel.
Delete "-t",".", from start of "python.testing.unittestArgs": in settings.json.
Observe Error discovering unittest tests due to ImportError.

Diagnostic data

Python version (& distribution if applicable, e.g. Anaconda): 3.8.2
Type of virtual environment used (e.g. conda, venv, virtualenv, etc.): Global
Value of the python.languageServer setting: Default

Output for Python in the Output panel (View→Output, change the drop-down the upper-right of the Output panel to Python)

2023-07-25 12:35:37.882 [info] Discover tests for workspace name: vscode_test_bug - uri: /Users/dave/Desktop/vscode_test_bug
2023-07-25 12:35:37.923 [info] > /usr/bin/python3 ~/.vscode/extensions/ms-python.python-2023.12.0/pythonFiles/testing_tools/unittest_discovery.py ./test test_*.py
2023-07-25 12:35:37.924 [info] cwd: .
2023-07-25 12:35:38.102 [error] Error discovering unittest tests:
 Failed to import test module: foo.test_bar
Traceback (most recent call last):
  File "/Library/Developer/CommandLineTools/Library/Frameworks/Python3.framework/Versions/3.9/lib/python3.9/unittest/loader.py", line 436, in _find_test_path
    module = self._get_module_from_name(name)
  File "/Library/Developer/CommandLineTools/Library/Frameworks/Python3.framework/Versions/3.9/lib/python3.9/unittest/loader.py", line 377, in _get_module_from_name
    __import__(name)
  File "/Users/dave/Desktop/vscode_test_bug/test/foo/test_bar.py", line 2, in <module>
    from foo import bar
ImportError: cannot import name 'bar' from 'foo' (/Users/dave/Desktop/vscode_test_bug/test/foo/__init__.py)

User Settings

languageServer: "Pylance"

testing
• unittestArgs: "<placeholder>"
• unittestEnabled: true

Extension version: 2023.12.0
VS Code version: Code 1.80.1 (74f6148eb9ea00507ec113ec51c489d6ffb4b771, 2023-07-12T17:20:23.298Z)
OS version: Darwin x64 21.6.0
Modes:
Connection to 'ssh-remote+50' could not be established
Remote OS version: Linux x64 5.15.0-1041-azure
Remote OS version: Linux x64 5.15.0-1041-azure

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-4870HQ CPU @ 2.50GHz (8 x 2500)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmetal: disabled_offmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: enabled

Load (avg)
3, 5, 5

Memory (System)
16.00GB (0.10GB free)

Process Argv
--crash-reporter-id 8f7431c9-c952-46ec-b900-9195df7b4b57

Screen Reader
no

VM
0%

Connection to 'ssh-remote+50' could not be established

Item
Value

Remote
Codespaces

OS
Linux x64 5.15.0-1041-azure

CPUs
Intel(R) Xeon(R) Platinum 8370C CPU @ 2.80GHz (4 x 2793)

Memory (System)
7.75GB (5.25GB free)

VM
0%

Item
Value

Remote
Codespaces

OS
Linux x64 5.15.0-1041-azure

CPUs
AMD EPYC 7763 64-Core Processor (8 x 2445)

Memory (System)
31.34GB (29.35GB free)

VM
0%

A/B Experiments
vsliv368cf:30146710
vsreu685:30147344
python383cf:30185419
vspor879:30202332
vspor708:30202333
vspor363:30204092
vswsl492cf:30256860
vslsvsres303:30308271
vserr242:30382549
pythontb:30283811
vsjup518:30340749
pythonptprofiler:30281270
vshan820:30294714
vstes263:30335439
vscorecescf:30445987
vscod805cf:30301675
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
vsaa593:30376534
pythonvs932:30410667
py29gd2263cf:30792227
vscaac:30438847
vsclangdf:30486550
c4g48928:30535728
dsvsc012cf:30540253
pynewext54:30695312
azure-dev_surveyone:30548225
2e4cg342:30602488
f6dab269:30613381
showlangstatbar:30737416
vsctsb:30748421
03d35959:30757346
pythonfmttext:30731395
pythoncmvfstrcf:30756944
fixshowwlkth:30771522
hideindicator:30785051
pythongtdpath:30769146
i26e3531:30792625
gsofa:30797621
pythonnosmt12:30797651
e537b577:30795824
dsvsc013:30795093
dsvsc014:30797589

Also see it with "python.experiments.optOutFrom": ["pythonTestAdapter"]

Hi! I cloned your repo but didn't see the nested test folders so I added them as shown below. I also added some __init__.py files since those were needed to access the lower folder contents. I am not getting the error you had with the same settings, was there something about the setup I missed? Thanks

{
  "python.testing.unittestArgs": ["-t", "."],
  "python.testing.pytestEnabled": false,
  "python.testing.unittestEnabled": true
}

Because we have not heard back with the information we requested, we are closing this issue for now. If you are able to provide the info later on, then we will be happy to re-open this issue to pick up where we left off.


How to uncompress the bg_img.003.001

I was uncompressed the bg_img.003.001 to bg_img.003 with "7z" cmd tool, But bg_img.003 could not be uncompressed.

Hi, those bg_img.7z.00* files should be merged before uncompressing.

Or you can download them all, and double-click .001.
That will uncompress them all together.


at typechecking failure

(defun at-integer:integer (a:integer b:integer c:integer)
  (at 0 [a b c]))

results in tests/pact/tc.repl:131:10:Warning: Unable to resolve type ([<at167_l>]).

Updated slightly better example:
(defun tc-at-literal-typed-list:integer (a:integer)
  (at 0 [a]))

Failures:

  tests/TypecheckSpec.hs:35:80:
  1) pact typecheck tests/pact/tc.repl.tc-at-literal-typed-list typechecks
       expected: []
        but got: [[<at1_l>]]

  To rerun use: --match "/pact typecheck/tests/pact/tc.repl.tc-at-literal-typed-list typechecks/"

  tests/TypecheckSpec.hs:39:57:
  2) pact typecheck tests/pact/tc.repl.tc-at-literal-typed-list has no failures
       expected: []
        but got: [Failure list3 "Unable to resolve type ([<at1_l>])"]

  To rerun use: --match "/pact typecheck/tests/pact/tc.repl.tc-at-literal-typed-list has no failures/"

Randomized with seed 812962553


Consolidate function documentation

This commit consolidates function documentation from three specific guides to a single version with tabs.
You can preview these docs with this command:
dagger call -m github.com/levlaz/daggerverse/docusaurus serve --src https://github.com/levlaz/dagger#docs-237-convert-functions --dir "src/docs" up

A couple of points and questions.

I moved the python specific doc about annotation to the start of the guide from the end
I moved the comment about ctx and error being optional to the start of the go part as well
Are we planning to remove these "language specific dev manual" parts? i.e https://docs.dagger.io/manuals/developer/go
I started down a pathway to add a dagger.json to the snippets but I ran into some issues and also its not clear if we actually want to do this. I think we should to make the docs more testable, but feels like this should probably be a different project.

@vikram-dagger, I'm also thinking we need to document somewhere (not in this PR, of course) how these functions translate to the client versions in dag, and how they differ. Several Go users have been confused by this, especially when a function returns both an error and an object, because the client version doesn't return an error in this case.

@vikram-dagger, I'm also thinking we need to document somewhere (not in this PR, of course) how these functions translate to the client versions in dag, and how they differ. Several Go users have been confused by this, especially when a function returns both an error and an object, because the client version doesn't return an error in this case.

I made a new issue here so we don't lose this feedback: https://github.com/dagger/dagger/issues/7389


Search highlight unreadable

Hi,
The search highlight is unreadable (don't remember since which version).
Not perfect, but adding transparency can make the text visible:
For gruvbox-dark:
set highlight-color             rgba(250,189,47,0.5)
set highlight-active-color      rgba(254,128,25,0.5)

zathura --version:
zathura 0.5.8
girara 0.4.4 (runtime: 0.4.4)
(plugin) pdf-poppler (0.3.3) (/usr/lib/zathura/libpdf-poppler.so)

Thank you very much for your suggestion. I haven't used this software as my primary PDF reading tool for some time. However, once I have some time, I will standardize the colors to RGBA mode, which should resolve the issue.

The color format has been updated to RGBA, and the highlight color has been changed to semi-transparent. This issue should now be resolved.

0fbb6c94b5bcc8250e6edd4981f4f4991d28b94e


Data frames: get rid of wandb-run.json files

Start renaming data tables to data frames. Make Simpsons example update the results DataFrame after each epoch as well as at the end of the run.

@shawnlewis
This changes summary semantics: before, large structures like tensors would be written to files and replaced in the summary with a placeholder dictionary. This meant that if the user looked for their tensor after writing it to the summary, they would find the placeholder dictionary instead. If they then put the same tensor object into the summary again, except with different data in it, it would be treated as a new tensor and serialized all over again. The placeholder dictionary was effectively acting as a "clean/dirty" marker.
Now we track such objects by their Python ID's (ie. their memory addresses). The placeholder dictionaries don't magically appear in the summary any more, so we have no way of noticing if a particular summary key is dirty unless they put an entirely new tensor object in the same spot.

@shawnlewis implemented nested summaries that notice when any key is modified, even if it's not at the top level. This fixes that nasty bug we discussed on the offsite. This replaces the solution I described in the previous comment, which you didn't like.

@shawnlewis @raubitsj could you review this?


Can't package 'zxcvbn-cli' with new npm2rpm system

openSUSE 42.2 generates this kind of problem. It done with npm2rpm script others are still mumbled with depencies:
[   33s] + node2rpm-server --prep
[   33s] /usr/lib64/ruby/gems/2.1.0/gems/rpmspec-1.0.0/lib/rpmspec/stage.rb:9:in +': no implicit conversion of Symbol into String (TypeError) [   33s] 	from /usr/lib64/ruby/gems/2.1.0/gems/rpmspec-1.0.0/lib/rpmspec/stage.rb:9:in block in method_missing'
[   33s] 	from /usr/lib64/ruby/gems/2.1.0/gems/rpmspec-1.0.0/lib/rpmspec/stage.rb:9:in each' [   33s] 	from /usr/lib64/ruby/gems/2.1.0/gems/rpmspec-1.0.0/lib/rpmspec/stage.rb:9:in each_with_index'
[   33s] 	from /usr/lib64/ruby/gems/2.1.0/gems/rpmspec-1.0.0/lib/rpmspec/stage.rb:9:in method_missing' [   33s] 	from /usr/lib64/ruby/gems/2.1.0/gems/rpmspec-1.0.0/lib/rpmspec/parser.rb:22:in parse'
[   33s] 	from /usr/lib64/ruby/gems/2.1.0/gems/node2rpm-1.0.0/lib/node2rpm/system.rb:32:in buildroot' [   33s] 	from /usr/lib64/ruby/gems/2.1.0/gems/node2rpm-1.0.0/lib/node2rpm/system.rb:27:in buildroot'
[   33s] 	from /usr/lib64/ruby/gems/2.1.0/gems/node2rpm-1.0.0/lib/node2rpm/server.rb:9:in initialize' [   33s] 	from /usr/lib64/ruby/gems/2.1.0/gems/node2rpm-1.0.0/bin/node2rpm-server:7:in new'
[   33s] 	from /usr/lib64/ruby/gems/2.1.0/gems/node2rpm-1.0.0/bin/node2rpm-server:7:in <top (required)>' [   33s] 	from /usr/bin/node2rpm-server:23:in load'
[   33s] 	from /usr/bin/node2rpm-server:23:in `'
[   33s] error: Bad exit status from /var/tmp/rpm-tmp.NB2wus (%prep)
Spec can be found:
https://build.opensuse.org/package/show/home:illuusio:nodejs-packages/zxcvbn-cli

@illuusio this is fixed in rubygem-rpmspec. but a leaf problem is still there. /etc/os-release (provided by openSUSE-release package) needed by rubygem-rpmspec is not required. I need to investigate into it.

fixed. btw, node2rpm is at https://github.com/marguerite/rubygem-node2rpm.

Ok now installing goes until then installing and then I got
[   33s] + node2rpm-server --prep
[   33s] /usr/lib64/ruby/gems/2.1.0/gems/rpmspec-1.0.0/lib/rpmspec/changelog.rb:23:in `entries_suse': undefined method `map!' for nil:NilClass (NoMethodError)
[   33s] 	from /usr/lib64/ruby/gems/2.1.0/gems/rpmspec-1.0.0/lib/rpmspec/changelog.rb:13:in `entries'
[   33s] 	from /usr/lib64/ruby/gems/2.1.0/gems/rpmspec-1.0.0/lib/rpmspec/parser.rb:29:in `parse'
[   33s] 	from /usr/lib64/ruby/gems/2.1.0/gems/node2rpm-1.0.0/lib/node2rpm/system.rb:32:in `buildroot'
[   33s] 	from /usr/lib64/ruby/gems/2.1.0/gems/node2rpm-1.0.0/lib/node2rpm/system.rb:27:in `buildroot'
[   33s] 	from /usr/lib64/ruby/gems/2.1.0/gems/node2rpm-1.0.0/lib/node2rpm/server.rb:9:in `initialize'
[   33s] 	from /usr/lib64/ruby/gems/2.1.0/gems/node2rpm-1.0.0/bin/node2rpm-server:7:in `new'
[   33s] 	from /usr/lib64/ruby/gems/2.1.0/gems/node2rpm-1.0.0/bin/node2rpm-server:7:in `<top (required)>'
[   33s] 	from /usr/bin/node2rpm-server:23:in `load'
[   33s] 	from /usr/bin/node2rpm-server:23:in `<main>'
[   33s] error: Bad exit status from /var/tmp/rpm-tmp.iwSYtn (%prep)

Nodejs version is 4 is it a problem shouldn’t be because this is Ruby exception.


Feature request: bold_folder_labels setting like Sublime's

I really appreciate the minimal UI, however, I really do miss Sublime's bold_folder_labels. It does just that - makes folder labels bold - adding a distinguishing characteristic between them and files. This helps a lot when:

Dealing with long file and folder names, since it's no longer necessary to visually scan the entire right-to-left range of an item to determine what it is (i.e. spotting the expansion triangle);
Scanning the Explorer vertically, since the boundary between when folders end and files begin becomes clearer.

There are multiple issues (#123, #1833, #3200, many more) requesting a more powerful API for UI customization. But I couldn't find any issue requesting a specific setting to control the visual aspect of folders.

@zertosh we plan to add support for icons in the next release, would that help?

We should decide in a UX meeting if we really want this.

I think at least having this as an option in settings.json would be really helpful, and you can default the behavior to what it does now. In a project with hundreds of folders and thousands of files, file names in bold would really help my eyes scanning the file tree.

@stemcc have you tried one of the icon themes in VS Code?  Does that mitigate the concern of differentiating folders from files?

@bgashler1  indeed, I've tried Minimal, Seti (VSCode), and Nomo Dark Icon Theme.
I plan on sticking with Seti, but you'll notice that both Seti and Nomo Dark use carrots/arrows for their folder icons. That makes the folder tree easier on my eyes than without them, but it still doesn't quite feel "fast enough" for my brain/eyes to grok.
Immediately contrasting folders require little processing power on the part of my brain, and if the bolded folders were an option in settings, then we could use both the icon themes (which I really like and will continue using) along with contrasting folder font.
I never realized how little I actually acutely focused my eyes on my file tree tree when Im working on code across multiple folders. I wonder if this is simply a matter of VSCode doing things differently than Sublime and I just need more time to adjust.
But I'm the kind of person who increases the contrast on all my screens whenever possible because it's just so much more "comfortable" for me to use that way. Otherwise I find myself being aware of my eyes focusing in on text, whereas with more contrast, focusing on text seems more "automatic" for me.
I hope this doesn't sound hopelessly subjective!

@bpasero Any update? I think this setting should be added showing only folder icons is not enough and the users should decide if using icons or file + bolded folders or both.
Also having the ability to differentiate the folders foreground color from files is critical since colors are perceived before icons and text.

This feature request will not be considered in the next 6-12 months roadmap and as such will be closed to keep the number of issues we have to maintain actionable. Thanks for understanding and happy coding!

a 2hrs features...

I'm really interested in this feature. Visual differences between files and folders are way more apparent with bold / non-bold styles compared to only some icons.

I'm also really interested in this feature. All vscode-icon setting are great but the reduction in cognative load you get from Sublimes bold_folder_labels option is quite a lot better.

This would definitely be nice to have.
In a monorepo, its not uncommon to have a sidebar with enough entries to fill the entire screen (1440px in my case) and the immediate visual feedback one gets from the difference in font weight between folders and files makes a significant impact on the signal-to-noise ratio.

I also miss this feature in VSCode and would love to see this make it in the future. Sure, there are arrows, carets, or icons but I prefer having bolded (or colored) folders - it really makes a difference when browsing in a sidebar with lots of files.


[bug]: Svelte createUploader -> onClientUploadComplete broken in production. Package is unusable clientside. (@uploadthing/svelte 7.0.3)

Provide environment information
System:
    OS: macOS 15.0.1
    CPU: (8) arm64 Apple M1
    Memory: 106.84 MB / 8.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 21.5.0 - ~/.nvm/versions/node/v21.5.0/bin/node
    npm: 10.2.4 - ~/.nvm/versions/node/v21.5.0/bin/npm
  Browsers:
    Chrome: 129.0.6668.101
    Safari: 18.0.1
  npmPackages:
    @uploadthing/svelte: ^7.0.3 => 7.0.3
    typescript: ^5.6.3 => 5.6.3
    uploadthing: ^7.1.0 => 7.1.0

Describe the bug
Uploading from the client is broken for Svelte in production.
I correctly receive the webhook, the file is stored in uploadthing but the client does not get a confirmation that the uploading process is done.
Video showing this
Link to reproduction
https://www.loom.com/share/c017d0954d6a40d08f0c863fa378962f?sid=279d464a-905b-4021-b399-e8bf7899c392
To reproduce
src/lib/utils/uploadthing.ts
import` type { OurFileRouter } from "$lib/server/uploadthing";
import { generateSvelteHelpers } from "@uploadthing/svelte";
export const { createUploader, createUploadThing } =
  generateSvelteHelpers<OurFileRouter>();

import { createUploader } from '$lib/utils/uploadthing'
const uploader = createUploader('fileUploader', {
  onClientUploadComplete: (res) => {
  	console.log('Uploadthing Complete', res)
  }})
  ...
<UploadDropzone {uploader} />

👨👧👦 Contributing

[ ] 🙋♂ Yes, I'd be down to file a PR fixing this bug!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Temporary solution for this is to add { awaitServerData: false } to endpoint.
Currently there are no errors in onUploadComplete.

can you still repro this? there were a few minutes on Wednesday where a missing edge case could cause infinite client loading

I can confirm I can no longer repro this. Testing it with the exact same code.
Hmmm it was definitely more than a couple of minutes I experienced this issue for more than half a day so maybe it was related to something else.
But glad that it's resolved!


support noTimestamp and noVersionStamp groovydoc flags

@paulk-asert, do you mind signing the CLA?

Signed. Just a couple of comments on the PR changes:

I didn't know whether you deem AntGroovydoc.java to be part of your public api in which case you might want to overload the execute method defaulting the two new flags to false.
I haven't tried to do any version checking. Groovy 2.4.6 will be the first version to support these flags. Earlier versions of GroovyDocTool won't care if given additional properties - those entries in the map will be ignored and vice versa, older versions won't do anything if supplied with extra properties. But given the hook via antBuilder, it will likely complain if given parameters not in the Groovydoc ant task but I haven't tested this. It depends really whether this code only runs with a bundled Groovy or if there is a way to run it using any Groovy version.

Yes, AntGroovydoc is part of the public API. We probably do want to do some kind of version checking here if setting these properties will cause issues in Groovy versions < 2.4.6. Users can control what version of Groovy is used. Also, I think we'd likely want to wait until Groovy 2.4.6 is released before merging this in so we can add coverage to ensure setting the properties actually does something.

@paulk-asert Groovy 2.4.6 is out. I'm counting on you to finalize this PR.

I will create a new PR


Bug fix: Reset Route arguments for each call (on 4.x)

Forward #2431 to 4.x

Coverage increased (+0.02%) to 97.819% when pulling b46501b79398a9a69d5a7aff725c8ef1b3eb0d21 on mathmarques:patch-1 into 5b5675451ae78eab35ca5c58fb4a24bb547fcfb6 on slimphp:4.x.

Are you able to rebase?


ScrollArea with ScrollBar should reposition the thumb

When the user just moves the content in the scroll area without klicking on the thumb the thumb does not move.

fixed in 988dac1


Sighting Compass

This is the code for the Sighting Compass/Augmented Reality. There are still some things missing/not working (image is scaled and not cropped, if you've opened the camera once it runs always in the background and the permission request appears at the start or the application; I'm working on this). It's an experimental feature, so you have to enable experimental features to use this feature.

Thank you! Don't worry about the permission request, I can modify that as I have a flow in mind for that to optimize privacy (camera is a sensitive permission)


Pos control landing

The landdetection still does not recognize landing consistently.

It turns out that the stick threshold is set very tight:

Blue is the stick input which should be below 0.05.
The thrust and velocity satisfy ground contact condition.

We should set the calibration such that the sticks reach maximum travel at about 90% physical motion

So that you don't have to have it completely down

Pos Ctrl Landing has never worked for me. I'd rather had some scary moments with it, when it tried to compensate some GPS deviation while on the ground. I never trusted this function and I always switch to Stabilized after touch down. This is inconvenient but works.

@Stifael was this fixed?

@bresch I think we were running into this today, on the field.

Hm, the land detector seemed to work better. But its crucial to set the minimum thrust correctly and not to put the landing speed too low. The latter ensures that the thrust drops below the min thrust more quickly.

Here you have a few logs about land detection failures:
http://logs.px4.io/plot_app?log=bf1fc3b0-e88d-415d-9341-7d89c3df1450
http://logs.px4.io/plot_app?log=1f0b293c-8bf6-46eb-99c8-f4831263a5fc
http://logs.px4.io/plot_app?log=230472d3-0b70-46c1-8fd0-64de2376c0a6
http://logs.px4.io/plot_app?log=ac39ed67-05b1-4c35-8ae3-f66a96c2cc25

I think reaching the minimal thrust is mostly the problem (did not check the logs yet). I don't understand exactly why but we had a racer that did not even reach the ground with the default landing speed because the position controller still put out too much thrust to get the drone through the ground effect...
So I know it's only a pretty bad workaround but you can try for now to set MPC_LAND_SPEED to a higher value, descent manually with common-sense slow speed to not hit the ground too hard and then push the throttle stick down to the limit to get the thrust low...

@MaEtUgR You are right, the minimal thrust is the problem. In the following graph, you can see that when the drone hits the ground, the thrust only decreases slowly. This is because the altitude setpoint is defined by the actual speed and the max acceleration ([https://github.com/PX4/Firmware/blob/master/src/modules/mc_pos_control/mc_pos_control_main.cpp#L1066]) and when the vehicle touches the ground, the actual speed is close to zero.
In summary: ground touched -> vertical speed close to zero -> slow moving altitude SP -> slow thrust decrease
I think that could be fixed with one of the following solution (or a combination of both)

A velocity controller with integrator during descent instead of a position controller with a moving setpoint (thrust will drop faster as soon as we touch the ground).
A velocity controller without integrator but with vertical velocity error monitoring in the land detector.

@bresch
see https://github.com/PX4/Firmware/pull/6735 for similar discussion

@bresch:
obviously increasing the min thrust and vel_max_z is  not the solution, even it might hide the bug. monitoring the velocity is one solution, but I think there is a  an actual bug in the code that prevents the vehicle to go down entirely

MPC_VEL_MAX_DN is set to 0.1. orange is thrust, purple is the estimated velocity. when the vehcile hits the ground, the estimtaed velocity becomes negative instead of zero. although this would help to bring the thrust down more quickly, I dont understand why the estimation is closer to zero. also, in the plot above I the estimation is at zero.
also, when the velocity max down is set to small number (such as 0.1), I am able to get into the state where the vehicle increases in height despite having the throttle stick all the way down. This, however, is most likely due to the integrator which is not filled up at this stage (on the other hand, it takes quite some time do until the vehicle goes down again)

in sitl, from this log: http://logs.px4.io/plot_app?log=d96f06d1-8e65-4643-b702-b99176f5ed93
The max downward speed is set to 0.2. however, even demanding full downard speed, the vehicle does not move at all because it already thinks that it reached the max speed. when letting go the stick, the vehicle increases in altitude slightly.
I think there are two weird things that I dont understand:
1.) why is the estimation not converging to the true value (see plot below and compare to groundtruth)
2.) when letting go the stick and we already know that estimation is off, why then does the vehicle not increase in altitude?

I will do a replay log to see if I can figure out whats going on, but maybe @priseborough already has some clue

'> 2.) when letting go the stick and we already know that estimation is off, why then does the vehicle not increase in altitude? '
From my understanding, when you let go the sticks, the altitude controller will be engaged and set to the current altitude and will maintain the quad to the correct altitude even if the velocity is slightly wrong.

@bresch, yep thats true. that would explain the 2.)

@Stifael We've solved this issue (or tried to handle estimation error on LPOS_VZ when landing) by not just controlling the constant LPSP_VZ, but using a slow integral based on error in altitude (LPSP_Z - LPOS_Z) where LPSP_Z is moved downwards at LPSP_VZ speed. It needs careful implementation, but works very well. (LPOS_Z seems to not have estimation errors like LPOS_VZ).

@devbharat thank you for the explanation, that could work (or already does in your case).
By the way, the estimation for LPOS_Z can be off by several meters, but since you use the error in altitude that does not matter.
I will consider your solution, but I am still curious why the estimation in vel_z is not doing better, even in sitl

@Stifael We had estimation errors right after back transition as accel bias in body_x(cruise nose direction) were being learnt in Cruise and the suddenly after back transition to Hover were being used for LPOS_Z estimation. There was also some issue with not Mag alignment(hardware mag placement aligned with Pixracer) not being perfect, and velocity innovations were quite sensitive to the magnetometer's alignment offset. @priseborough had a long look at this for us, maybe he has something to say here.

@Stifael Do you only have the velocity estimation issue on sitl or also on the real hardware? Because I checked my logs and my velocity converges correctly to the gps velocity.
It looks like a tuning issue and I'm not sure if it's a good idea to implement a "hack" if it could work the right way with better tuning.

@bresch  A recurring problem with SITL has been that the vehicle simulation and FMU simulation are not synchronous which causes problems with IMU integration errors if the simulation is not able to keep up. This is particularly an issue when running the gazebo sim on slower platforms.
@Stifael Adding an integrator as @devbharat  suggests is a short term fix, but I think that longer term we should be moving to a reference model approach, where both the velocity and position states of  a reference model set-point are tracked and we do not have these transitions between velocity and position control. That would also enable 'stick feel' to be adjusted by changing velocity, accel and jerk limits on the reference model without changing any of the error gains. Such an approach does need logic to ensure that the reference model adjusts the trajectory if the vehicle control saturates.

@bresch: im not planning on implementing  anything yet, thats why I want to know why the estimation was off.  I saw that you dont have the issue, but fact is that we flew other vehicles where we were not able to land unless we increases the landing speed, similar to sitl. I probably shoud not have put it here, but when I was trying to replicate the problem I found the oddness. I actually first also assumed that it ii is a tuning problem, but im not entirely sure anymore.
@priseborough this issue should not be affected by just using velocity control. When landing you never enter position control and if estimation and control work correctly then it should work. The problem with the velocity estimation is a problem that occurs in reality as well and should be independent of the controller. @devbharat fix is a fix/hack for the estimation which should not be done in the controller side.

Let me summarize this from my side and exit:

The issue we faced (and apparently many of you are facing) is that while landing velocity tracking is working perfectly fine, and still the aircraft does not land. This is because the velocity estimate has an offset.
If you look at the corresponding position estimate, you would see that it is not decreasing. ie. the estimator knows that the aircraft is not descending - which is correct.
There are two ways to fix this problem. First would be looking into the estimator, as to why there is an offset in the velocity estimate. We did that, it's not perfect still but significantly better. [@priseborough would know whether the changes we made were hardware specific parameter tunings in the estimator or if there were functional changes to EKF2 and if there are upstream already].
Regardless of estimator fixes I mentioned above, the problem can and should also be addressed to in the controller scheme. When landing, you want to control the position, in that you want the position to descend (at a certain rate) and if your estimator tells you your position is not decreasing, and you do nothing about it, it is rather silly. Not using your position estimate for landing control makes your aircraft more susceptible to errors in velocity estimate, which is what you see. This is in contrast with @Stifael 's statement that this issue should not be affected by just using velocity control , and makes modifying the control loop to use position while landing more a fundamental improvement than a hack fix.

@Stifael My understanding is that  using 'just velocity control' is a problem if the demanded velocity is less than the velocity error. The end result is that the vehicle does not descend.
As for estimation 'working correctly', of course we will take care with the estimator to reduce the effect of sensor errors, but if the vehicle cannot land due to a vertical velocity error of 0.3 m/s (remembering that GPS can be biased by that much), then we also need to improve robustness of the control loops.

@devbharat

in that you want the position to descend (at a certain rate)

that would be the velocity.
you are completely correct that your solution is a complete valid solution. but why should the mc_pos_control be involved in that? I prefer to keep the mc_pos_control simple (its already doing way too many things), which means that it should just receive setpoints and current estimates.
@priseborough : even if the velocity error is small, the integrator should close it at some point.
by the way, the velocity estimation error might not be the root cause for having failed landings when close to ground (I did not see the log). I just realized that in sitl there is this oddness, but since it is simulation I would not make any farther claims.
@devbharat I will keep your solution in mind. but the problem that @bresch and myself encountered is still not solved.

@Stifael when position estimate and velocity estimate from the estimator do not agree(like in this case when the velocity estimate has an offset), then the rate of change of position estimate is different from velocity estimate.
For example, in the flight plot below, look at LPOS_Z and LPOS_VZ. LPOS_VZ is consistently >0 and yet the LPOS_Z estimate stays at the altitude. Look also the range sensor based altitude LPOS_Dist showing the plane not descending.

The plot below shows the "disagreement" between LPOS_VZ and GPS_velD

It can also happen the other way, causing the plane to descend faster than expected

Look at Bais estimate

and Position and velocity innovations having a jump

why should the mc_pos_control be involved in that?
Because luckily position estimate seems to not be biased ever, so using it in the controller in mpc makes sense to me.

@devbharat I got your point from the beginning.

then the rate of change of position estimate is different from velocity estimate.

I really understand what you mean, already the first time you mentioned that. I think where we dont agree on is about how to deal with it.

Something I can look at on the estimator side is provide the option in the output predictor for a vertical velocity that is kinematically consistent with the height. This will increase the effect of baro noise and position errors on height keeping but would enable use of a 'velocity only' control strategy.

@priseborough Not sure what you mean by output predictor, will it then just be hardcoded output different from the actual estimated states?
I know there is a clear tradeoff between accelerometer and barometer measurements. I guess barometer is used in measurement update of the altitude state and accelerometer is used in measurement update of the vertical velocity state.
But why is the model which is certainly including ΔAltitude = vertical velocity not "trusted"/"weighted" enough such that at least the sign of the states make sense in a kinematic sense?

@MaEtUgR The ecl EKF buffers observations and runs the filter on a delayed time horizon so that the effect of measurement delay can be compensated for.
The output predictor applies a strapdown INS algorithm to IMU data at the current time horizon to calculate quaternion, velocity and position output states. The output states are buffered and compared to the EKF states at the fusion time horizon and a correction is then applied to the output state buffer so that the output states track the EKF states.
This also acts to filter the observation noise which are the small steps in EKF states produced whenever a GPS, magnetometer or baro observation is fused. The curent algorithm minimises tracking error.
I have created a PR here which provides the option to output a velocity that is equivalent tot he first derivative of the position: https://github.com/PX4/ecl/pull/265. This does reduce tracking accuracy relative to the EKF states but if the mode was selected when the velocity demand was being limited or set by the landing sink rate limit, it would mask the effect of EKF vertical estimation errors.

https://github.com/PX4/Firmware/pull/7152

an improved mc-landdetector PR is here:
https://github.com/PX4/Firmware/pull/7314.

I will close it. Because I opened this issue I will close it for now, but keep tracking the land-detector progress


Couchbase support

Hi all, I found that I wrote spi module of artifact store supporting Couchbase in last year but not did PR.
It's based on pretty old revision so It may take a few time to rebase and test.
Anyway, would it be helpful if I wrap it up and PR? Give me a opinion.

I can imagine how we can offer a few plugins for the artifact store. The concern as with any functionality is making sure it doesn’t rot. If there’s a way to automate the testing then we should include it. There’s on going work for Mongo as well and so we can have more than one.

Contributions are welcomed.


Fix pip upgrade command on windows

There are some issues with upgrading pip in the Windows CI. Trying to fix it.
Run pip install --upgrade pip
Requirement already satisfied: pip in c:\hostedtoolcache\windows\python\3.10.11\x64\lib\site-packages (24.0)
Collecting pip
  Downloading pip-24.1-py3-none-any.whl.metadata (3.6 kB)
Downloading pip-24.1-py3-none-any.whl (1.8 MB)
   ---------------------------------------- 1.8/1.8 MB 29.2 MB/s eta 0:00:00
ERROR: To modify pip, please run the following command:
C:\hostedtoolcache\windows\Python\3.10.11\x64\python.exe -m pip install --upgrade pip

It seems to work now ... but you are suggestion not to update pip altogether?

which saves us a few secs :)


Fix json validation in queues

This will fail mypy because of a bit of a rabbit hole in how we handle the realm_filters data structure in markdown.py.  What I'd like us to do is replace that part of the commit with:

Changing the data structures for linkifiers to be a normal Zulip-style dictionary marshalling (maybe a TypedDict) of the linkifier rather than a tuple.
Just convert it to the list format when writing into an API response.
Do the same with muted_topics
As a follow-up, plan an API change we can do with a new client_capability that would let us remove these legacy formats entirely.

Closing as this was replaced by #16152.  Thanks @alexmv!


fix: vscode plugin cannot parse flags correctly

Codecov Report

Merging #36 (0e99aff) into master (85c4c53) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #36   +/-   ##
=======================================
  Coverage   93.44%   93.44%
=======================================
  Files           3        3
  Lines         305      305
=======================================
  Hits          285      285
  Misses         14       14
  Partials        6        6

Flag
Coverage Δ

unittests
93.44% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Test for python versions 3.10

Description
Test for python versions 3.10 and 3.11
Checklist

[x] I read the CONTRIBUTING guide and understand what's expected of me
[x] I ran this code in development and it appears to resolve the stated issue
[x] I added tests, or tests are not required/relevant for this PR
[x] I added an entry to the CHANGELOG detailing the change of this PR

We will the dbt minor version 1.4 in another PR


Activity based commands

Add GET and POST for current activity commands. Add GET and POST for activity based commands.

This was actually added with #38

Closing in lieu of #38


triple不支持应用级地址发现

[ ] I have searched the issues of this repository and believe that this is not a duplicate.
[ ] I have checked the FAQ of this repository and believe that this is not a duplicate.

Environment

Dubbo version: 3.x
Operating System version: Ubuntu 18.04.5
Java version: 11
nacos version: 1.4.2

Steps to reproduce this issue

provider配置

dubbo:
  application:
    metadata-type: remote
    register-mode: instance
  registry:
    address: nacos://${nacos.host}:${nacos.port}
  protocol:
    name: tri
    serialization: protobuf

consumer配置

dubbo:
  application:
    metadata-type: remote
    service-discovery:
      migration: APPLICATION_FIRST
  registry:
    address: nacos://${nacos.host}:${nacos.port}
#    ?registry-type=${nacos.registry-type}
  protocol:
    name: tri
    serialization: protobuf

Pls. provide [GitHub address] to reproduce this issue.
Expected Result

Actual Result

If there is an exception, please attach the exception trace:
java.lang.IllegalStateException: Failed to check the status of the service service.HelloService. No provider available for the service service.HelloService from the url dubbo://

I have reproduced this problem, and the problem can be more specific:
The Triple protocol is not working on Spring integrated with Dubbo.

@feng996  I have found the cause of the problem which is not related to dubbo-spring-boot-starter as I first thought.
The source is in org.apache.dubbo.config.metadata.ServiceInstanceHostPortCustomizer ,  let's have a look:
@Override
public void customize(ServiceInstance serviceInstance) {
    String host = null;
    int port = -1;
    // ......
    Set<URL> urls = writableMetadataService.getExportedServiceURLs();
    if (CollectionUtils.isNotEmpty(urls)) {
        ApplicationModel applicationModel = serviceInstance.getApplicationModel();
        String preferredProtocol = applicationModel.getCurrentConfig().getProtocol();
        //  The default value of preferredProtocol is dubbo.
        if (preferredProtocol != null) {
            for (URL exportedURL : urls) {
                // The protocol of exportedURL is tri
                // because of tri != dubbo, the host and port will not be assigned values.
                if (preferredProtocol.equals(exportedURL.getProtocol())) {
                    host = exportedURL.getHost();
                    port = exportedURL.getPort();
                    break;
                }
            }
        } else {
            URL url = urls.iterator().next();
            host = url.getHost();
            port = url.getPort();
        }
        // If not the port of instace > 0, the application instance will not be registered to RegistryCenter(like Nacos, Zookeeper).
        // As a result, the consumer can't find the avaliabe providers when our settging is registry-mode=instance
        if (serviceInstance instanceof DefaultServiceInstance) {
            DefaultServiceInstance instance = (DefaultServiceInstance) serviceInstance;
            instance.setHost(host);
            instance.setPort(port);
        }
    }
}

For the moment, if you want both consumer and provider to force using Application Discovery in tri protocol, just change one line config of provider as follows:
dubbo:
  application:
    metadata-type: remote
    register-mode: instance
    protocol: tri  <==== HERE, set preferredProtocol as tri

But, Dubbo official also needs to do two things for further promotion:

Complete the docs: Triple协议迁移指南 as soon as possible
The logic of preferredProtocol was not user-friendly, we maybe should optimize it.

添加 dubbo.application.protocol=tri
3.0.4 consumer reference 还是会报no provider ....
demo放在 #8987 回复里了

添加 dubbo.application.protocol=tri 3.0.4 consumer reference 还是会报no provider .... demo放在 #8987 回复里了

使用注解引用时，再次指定protocol=tri，解决
@DubboReference(providedBy = "feedback-provider", check = false, protocol = "tri")
private HelloService helloService;
看起来是provider配置里services key 为interface:protocol的原因（"com.example.feedback.api.service.HelloService:tri"）。
但是不知道为什么在注解引用时，并没有把dubbo.protocol.name=tri这个信息加到后面，需要在reference里再次指定


Can't install on Windows

I' getting the following error while trying to install on Windows:
Python version is:
Python 3.10.11 (tags/v3.10.11:7d4cc5a, Apr  5 2023, 00:38:17) [MSC v.1929 64 bit (AMD64)] on win32
Type "help", "copyright", "credits" or "license" for more information.

Download Qdrant
Attempt 1 to download https://github.com/qdrant/qdrant/releases/download/v1.10.0/qdrant-x86_64-pc-windows-msvc.zip
qdrant-x86_64-pc-windows-msvc.zip: 100%|█████████████████████████████████████████| 21.1M/21.1M [00:03<00:00, 6.47MiB/s]
Download Qdrant Web UI
Attempt 1 to download https://github.com/qdrant/qdrant-web-ui/releases/download/v0.1.29/dist-qdrant.zip
dist-qdrant.zip: 100%|███████████████████████████████████████████████████████████| 1.90M/1.90M [00:00<00:00, 6.33MiB/s]
Download Prompt Quill data
Attempt 1 to download https://civitai.com/api/download/models/567736
data.zip:  61%|████████████████████████████████████████                          | 8.86G/14.6G [25:09<16:14, 6.31MiB/s]
Error downloading: ('Connection broken: IncompleteRead(9518051328 bytes read,<PHONE_NUMBER> more expected)', IncompleteRead(9518051328 bytes read,<PHONE_NUMBER> more expected))
Retrying...
Attempt 2 to download https://civitai.com/api/download/models/567736
data.zip: 100%|█████████████████████████████████████████████████████████████████▉| 14.6G/14.6G [41:05<00:00, 6.35MiB/s]
Error downloading: ('Connection broken: IncompleteRead(15661072384 bytes read, 1413164 more expected)', IncompleteRead(15661072384 bytes read, 1413164 more expected))
Retrying...
Attempt 3 to download https://civitai.com/api/download/models/567736
data.zip: 100%|█████████████████████████████████████████████████████████████████▉| 14.6G/14.6G [40:51<00:00, 6.39MiB/s]
Error downloading: ('Connection broken: IncompleteRead(15661137920 bytes read, 1347628 more expected)', IncompleteRead(15661137920 bytes read, 1347628 more expected))
Retrying...
Attempt 4 to download https://civitai.com/api/download/models/567736
data.zip: 100%|█████████████████████████████████████████████████████████████████▉| 14.6G/14.6G [41:12<00:00, 6.33MiB/s]
Error downloading: ('Connection broken: IncompleteRead(15661137920 bytes read, 1347628 more expected)', IncompleteRead(15661137920 bytes read, 1347628 more expected))
Retrying...
Attempt 5 to download https://civitai.com/api/download/models/567736
data.zip:  21%|█████████████▉                                                    | 3.09G/14.6G [08:46<32:43, 6.29MiB/s]
Error downloading: ('Connection broken: IncompleteRead(3314184192 bytes read,<PHONE_NUMBER>6 more expected)', IncompleteRead(3314184192 bytes read,<PHONE_NUMBER>6 more expected))
Max retries (5) exceeded. Giving up.
Traceback (most recent call last):
  File "I:\Tools\prompt_quill\llama_index_pq\installer_files\env\Lib\site-packages\urllib3\response.py", line 748, in _error_catcher
    yield
  File "I:\Tools\prompt_quill\llama_index_pq\installer_files\env\Lib\site-packages\urllib3\response.py", line 894, in _raw_read
    raise IncompleteRead(self._fp_bytes_read, self.length_remaining)
urllib3.exceptions.IncompleteRead: IncompleteRead(3314184192 bytes read,<PHONE_NUMBER>6 more expected)

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "I:\Tools\prompt_quill\llama_index_pq\installer_files\env\Lib\site-packages\requests\models.py", line 820, in generate
    yield from self.raw.stream(chunk_size, decode_content=True)
  File "I:\Tools\prompt_quill\llama_index_pq\installer_files\env\Lib\site-packages\urllib3\response.py", line 1060, in stream
    data = self.read(amt=amt, decode_content=decode_content)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "I:\Tools\prompt_quill\llama_index_pq\installer_files\env\Lib\site-packages\urllib3\response.py", line 949, in read
    data = self._raw_read(amt)
           ^^^^^^^^^^^^^^^^^^^
  File "I:\Tools\prompt_quill\llama_index_pq\installer_files\env\Lib\site-packages\urllib3\response.py", line 872, in _raw_read
    with self._error_catcher():
  File "I:\Tools\prompt_quill\llama_index_pq\installer_files\env\Lib\contextlib.py", line 158, in __exit__
    self.gen.throw(typ, value, traceback)
  File "I:\Tools\prompt_quill\llama_index_pq\installer_files\env\Lib\site-packages\urllib3\response.py", line 772, in _error_catcher
    raise ProtocolError(arg, e) from e
urllib3.exceptions.ProtocolError: ('Connection broken: IncompleteRead(3314184192 bytes read,<PHONE_NUMBER>6 more expected)', IncompleteRead(3314184192 bytes read,<PHONE_NUMBER>6 more expected))

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "I:\Tools\prompt_quill\llama_index_pq\install_qdrant.py", line 153, in <module>
    download_qdrant()
  File "I:\Tools\prompt_quill\llama_index_pq\install_qdrant.py", line 121, in download_qdrant
    status_code = download_file(url, install_path)
                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "I:\Tools\prompt_quill\llama_index_pq\install_qdrant.py", line 48, in download_file
    for data in response.iter_content(chunk_size=1024):
  File "I:\Tools\prompt_quill\llama_index_pq\installer_files\env\Lib\site-packages\requests\models.py", line 822, in generate
    raise ChunkedEncodingError(e)
requests.exceptions.ChunkedEncodingError: ('Connection broken: IncompleteRead(3314184192 bytes read,<PHONE_NUMBER>6 more expected)', IncompleteRead(3314184192 bytes read,<PHONE_NUMBER>6 more expected))
Performing cleanup

After that installing continues, but I get another error:
ERROR: Ignored the following versions that require a different python version: 0.11.10 Requires-Python >=3.7,<=3.11; 1.0.0 Requires-Python >=3.7,<=3.11; 1.0.1 Requires-Python >=3.7,<=3.11; 1.0.2 Requires-Python >=3.7,<=3.11; 1.21.2 Requires-Python >=3.7,<3.11; 1.21.3 Requires-Python >=3.7,<3.11; 1.21.4 Requires-Python >=3.7,<3.11; 1.21.5 Requires-Python >=3.7,<3.11; 1.21.6 Requires-Python >=3.7,<3.11; 1.6.2 Requires-Python >=3.7,<3.10; 1.6.3 Requires-Python >=3.7,<3.10; 1.7.0 Requires-Python >=3.7,<3.10; 1.7.1 Requires-Python >=3.7,<3.10; 1.7.2 Requires-Python >=3.7,<3.11; 1.7.3 Requires-Python >=3.7,<3.11; 1.8.0 Requires-Python >=3.8,<3.11; 1.8.0rc1 Requires-Python >=3.8,<3.11; 1.8.0rc2 Requires-Python >=3.8,<3.11; 1.8.0rc3 Requires-Python >=3.8,<3.11; 1.8.0rc4 Requires-Python >=3.8,<3.11; 1.8.1 Requires-Python >=3.8,<3.11
ERROR: Could not find a version that satisfies the requirement torch==2.2.1+cu121 (from versions: 2.0.0, 2.0.1, 2.1.0, 2.1.1, 2.1.2, 2.2.0, 2.2.1, 2.2.2, 2.3.0, 2.3.1, 2.4.0, 2.4.1)
ERROR: No matching distribution found for torch==2.2.1+cu121

The first error seems to be a connection issue during the download.  Feel free to come to my discord and we try to figure it out. the whole process just worked. But I also had no issues downloading the large file from civit like you had.


[Task] Introduce bytebuddy proxy in apache/dubbo-spi-extensions

Pre-check

[X] I am sure that all the content I provide is in English.

Search before asking

[X] I had searched in the issues and found no similar feature requirement.

Apache Dubbo Component
Java SPI Extensions (apache/dubbo-spi-extensions)
Descriptions
Dubbo's default proxy is javassist. It has been tested by the practice of mass production.
Bytebuddy proxy can be chosen from dubbo-spi-exntensions. It still needs to be tested over time.
ref #13555
Task: Move bytebuddy implementation in apache/dubbo to apache/dubbo-spi-extensions
Related issues
https://github.com/apache/dubbo/discussions/13831
Are you willing to submit a pull request to fix on your own?

[ ] Yes I am willing to submit a pull request on my own!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

I'm interested. Please assign it to me.

I'm interested. Please assign it to me.

done


Namespaces.setPrefix() returns true when data is not set

I notice that in the JDK-9 Travis build the namespace test fails.  What is odd is that if you run the test again it works, so it could be compiler related.
Not sure if this is the reason, but Curator NodeCache says "it's not possible to stay transactionally in sync.  Users of this class must  be prepared for false-positives and false-negatives".
In the screenshot, you can see that data does not contain the jsonld namespace after it was supposed to have been set here.

Which compiler are you using? I have been using the oracle JDKs.

You can see from the build log that this happened on travis that used the oracle JDK.  Using travis ensures that this was not something unique to my configuration, which can easily get screwy, primarily because of IntelliJ not being fully geared to work with the Gradle 1.9 VM.
I am looking into how ZK connection state can be managed with Curator.  Do you think that connection state should have a handler?  The cache example has one.  Is it always assumed that the connection is there before a set, because when the test fails, I guess it is because there is no connection, but this state would not throw, so it seems that catch is unreachable.

I think that I have understood this problem.  It is not related at all to Curator or Zookeeper, but is the Jackson Object Mapper.  My theory (yet not totally proven) is that there are different symbols used for objects in Java 9 than what Jackson is expecting, perhaps because it was compiled with 1.8.  So, when the mapper returns a String, for example, and then you do a getBytes on the string, you see garbage at the front of the string like �� t r which was the symbol for the HashMap that Jackson left behind. It is not clear to me why it works on successive runs, but perhaps Jackson can reflect the runtime?

After more investigation, this first theory is not correct.  See attached test output with incremental logging.

getNamespaces() is actually called again after the test assertion fails, and it will return the expected response.  I commented out all of the assertions after the failing one, so the test should end.
Perhaps, the problem is because getNamespaces() overrides a non-package (trellis-spi) method and there are two class loaders working asynchronously?  idk, this one is a real jigsaw puzzle.
Also, the test always fails for me when run with gradlew at the CLI.
$ ../gradlew clean test --tests "org.trellisldp.rosid.common.NamespacesTest.testWriteNamespaces"

For reference, here is the output from same test run with 1.8...

finally I have made it work by removing @Override from getNamespaces()!

I guess that this is not really a fix, but maybe there is another workaround.  At least the cause is known now.

@christopher-johnson I changed the namespace cache implementation so that these async issues should be less of a problem. Feel free to re-open this issue if you find that this doesn't fix things.


Thankyou Komefai

Hi, I need someone  who can either help me set up a bot or write a bot for me (willing to pay), if interested please message me.

I managed to write the code myself, thank you very much Komefai for the program!.


seo improvements and accessibility fixes

SEO and Accessibility Enhancements 🚀
I've made key improvements to enhance both SEO and accessibility on the website:

SEO: Optimized meta tags, alt attributes, and internal links for better search engine visibility.
Accessibility: Added aria-label to buttons, input, and navigation for improved screen reader compatibility and enhanced keyboard navigation.

These updates will boost both user experience and search performance, making the site more inclusive and discoverable.
Looking forward to your feedback!

@ANSHIKA-26 kindly review and merge it

Kindly resolve conflicts

Kindly resolve conflicts

yeah resolved

Mention issue number

kindly make a new PR with the template properly followed


Attribution HTML sample causes horizontal scroll on small viewport widths

Description
Credit the creator section HTML content Cutting Off in small viewport size and Horizontal scroll bar is coming .
Reproduction

Visit this following Link: https://wordpress.org/openverse/image/517bc087-ee91-4e50-9cf2-1f5220beb35f/
Change the screen viewport to the mobile devices.
You will notice that the credit the creator HTML content Cutting Off.

Screenshots
https://prnt.sc/whlhofEEHWY8
Environment

Device: iPhone 12 Pro, Pixel 5, iPhone SE, iPhone XR
Browser: Chrome

Resolution

[ ] 🙋 I would be interested in resolving this bug.

The addition of tabs fixed this issue in main(not deployed to production yet). You can see at https://search-staging.openverse.engineering/image/517bc087-ee91-4e50-9cf2-1f5220beb35f/


Boss suggestion 4

$BOSS
Credit to Yorozuya for the idea.
//variable assignment
aurar=900
Arena
No special requirements.
Boss
$BOSS is a big monster in the middle of the arena. $BOSS is accompanied by $armorgoon and $magicgoon.
Phase 1 (100%-60% HP)
Both $goons have 0 base armor and magic resistance and an ability which teleports them close to $BOSS whenever they are not within $aurar of $BOSS. $magicgoon casts $spell instead of attacking, which deals magic damage in a line through a projectile.
$armorgoon provides a 150 armor aura. $magicgoon provides a 90% magic resistance aura. Both auras benefit the holders and have a radius of $aurar.
Phase 2 (60%-30% HP)
$BOSS summons another pair of $goons at the start of this phase.
$BOSS uses the following abilities from this phase onward:
$ability1: $BOSS turns players within $aurar ethereal for $several seconds. $BOSS proceeds to immediately cast $ability2.
$ability2: $BOSS channels for $few seconds, then launches magic projectiles in all directions. This deals $high magic damage to heroes hit. Projectiles are blocked by $goons (dealing no damage to them) and stop at the first unit hit.
$BOSS waits $long to use $ability1 again.
Phase 3 (30%-0% HP)
$BOSS resurrects all four $goons at the start of this phase.
Interval between use of $ability2 and $ability1 is significantly reduced.

Thank you for the post.
I have a few questions: when the boss gets four goons, do their auras stack?
How does the physical minion attack?
How long/far do the goons go out of the radius before teleporting back? There might be design space there.

No
By attacking physically like any unit ever
Immediately

ok i think the purpose should be if the team have so much dmg  they try to kill the $goons 1st then the the $boss
and if the team didnt have much dmg they should try to split them apart so they get out of each other auras which makes it easier to kill the boss
so making them teleport is bad idea for me
but if you give the boss $moderate movement speed and the m-goons $percentage1 of the boss movement speed and the a-goon $percentage2 of the m-goon movement speed  that will work


Can I change CDN path after init?

I am using this to alloc and init player
self.player = [[VBPlayer alloc]                  initWithCDN:xxx                  enabledPDN:NO                  licenseKey:nil];
However, can I just init and set CDN later like something
[self.player setCDN:xxx]

Hi there,
The CDN is a constitutive part of the player so it must be provided in its initialization method. Having a mutator will mean that you'll be able to swap it while playing i.e., to stop and start the process of loading the playback again. For that purpose you can just reinitialize the player with the new CDN.


CODE CHANGE: Problem in the "Exclusive Deals and Offers" section and the cards as well as title of "The Perfect Travel" section

Is there an existing issue for this?

[X] I have searched the existing issues

Describe the code change
I've came across two issues in which I can contribute:

Exclusive Deals and Offers - There's a problem in spacing between the elements in this section and also when we click on those carousel buttons to navigate through b/w different slides, it isn't very satisfying and the upper section starts having a vibrating effect (shown in the video).

The Perfect Travel - The title text of this section have a small 't' instead of capital 'T' for word 'travel' and also there's a need to fix the padding of text and button inside the cards.
screenrecord.zip

Proposed solution

Exclusive Deals and Offers - I will make improvements in the spacing between elements of this section and will implement a better carousel.

The Perfect Travel - I will make adjustments in the title text and also the padding b/w the card elements.

Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

@PriyaGhosal can you please review the changes?


Disable code splitting

Command
build
Description
We build a web component for customers however the new @angular-devkit/build-angular:application builder doesn't seem to have an option to disable code splitting.
Previously we used @angular-devkit/build-angular:browser with vendorChunk: true and concatenated the output files into a single JS file to get a single JS file to give to our customers.
We have some customers whose policies demand that they only load javascript from their own domains. Being able to provide them a single JS file has made it very easy to accommodate them.
However the new builder splits our component into 13 JS files, none of which are actually lazy loaded, all are immediately requested on page load.
Describe the solution you'd like
An option to limit, or turn off, code splitting. The old vendorChunk barely made it possible to publish a single JS file, and required some slightly hacky post-processing. It would be nice if such an option was offered natively.
As I understand, code splitting is an option that was added later to esbuild, so I'd think it would be easy to not do that.
Describe alternatives you've considered
We tried to use the browser-esbuild builder, for the web-component projects but:

The 'vendorChunk' option is not used by this builder and will be ignored.

The built application is still split across 13 JS files that cannot be concatenated into one working file.

@alan-agius4 Please don't close this so suddenly.
It's not a direct duplicate, #26478 was about single-entry. We'd really want a single-file.
That issue refers to https://github.com/angular/angular-cli/issues/23574:

This however is possible using the esbuild builder by putting all the polyfills and scripts into the main file.

However I can't find any documentation backing that statement, and I have not found a way to actually do that. If this truly is possible, could you point out how?

With the esbuild based builder, you can create a single bundle as explained in the above linked issue. For quick reference here's the comment https://github.com/angular/angular-cli/issues/26478#issuecomment-1828502818

I have read that comment, but I guess I'm completely failing to understand it.

If you do not use dynamic importing then there will be a single main JavaScript file and the polyfills JavaScript file generated in the output.

I've managed to eliminate the polyfill as per your recommendation add it to main.ts.
I do not use dynamic imports.

Step 1 does work as you said. However step 2 doesn't result at all in:  "there will be a single main JavaScript file". I'm still stuck with 12 files.

This should not be case, unless a dynamic import or some form of lazy-loading is used. It can also be that one of the libraries that you dependent on is using dynamic imports.

Ah, thanks, I'll look into doing that.

Thank you so much!
Apparently I really can't control the code splitting, but bundling the split results with esbuild in a post-build step works smoothly.
This is now run by my npm postbuild command:
#!/bin/env node
{
  const esbuild = require('esbuild');
  const { mkdirSync } = require('fs');

  const srcDir = 'dist/fooComponent/browser';
  const destDir = 'dist/components';
  const destFileName = 'fooComponent.js';

  mkdirSync(destDir, { recursive: true });

  console.log(`Bundling ${destFileName}…`);
  esbuild
    .build({
      entryPoints: [`${srcDir}/main.js`],
      bundle: true,
      minify: true,
      sourcemap: false,
      outfile: `${destDir}/${destFileName}`,
      format: 'esm',
    })
    .then(
      () => console.info(`${destFileName} created successfully!`),
      (error) => console.error(error),
    );
}


Frontend update, demo scripts.

@MasterJH5574

How are the two tests? Can our work passes both of them?

@MasterJH5574 I also removed the dtype field in SparseBuffer because its data buffer stores the information.


Clickable rows in dashboard tables

Rows in tables should be used as links to item details/edit.

Please make this work with CSS and not JS if possible.

We tried to do this in html and css, unfortunately we must use js.


Pre-validator isn't called for required value

OS: macOS 10.14.3
3.7.2 (v3.7.2:9a3ffc0492, Dec 24 2018, 02:44:43) [Clang 6.0 (clang-600.0.57)]
Pydantic 0.20.1

the keyword argument pre will cause validators to be called prior to other validation

Prior to 0.19.0 this worked for missing required values, but that release seems to break it. Validator doesn't seem to be even called:
In [6]: class Foo(BaseModel):
   ...:     bar: str
   ...:     @validator('bar', pre=True)
   ...:     def validate_bar(cls, value):
   ...:         print('Called')

In [7]: Foo()
---------------------------------------------------------------------------
ValidationError                           Traceback (most recent call last)
...
ValidationError: 1 validation error
bar
  field required (type=value_error.missing)

duplicate of #387

also discussed on #411.
Should be fixed soon.


ISV-5151: remove awx-operator from community operators

Thanks for submitting your Operator. Please check the below list before you create your Pull Request.
New Submissions

[ ] Are you familiar with our contribution guidelines?
[ ] Are you familiar with our operator pipeline?

[ ] Have you tested your Operator in all supported installation modes?
[ ] Have you considered whether you want to use semantic versioning order?
[ ] Is your submission signed?
[ ] Is operator icon set?

Your submission should not

[ ] Add more than one operator bundle per PR
[ ] Modify any operator
[ ] Rename an operator
[ ] Modify any files outside the above mentioned folders
[ ] Contain more than one commit. Please squash your commits.

Operator Description must contain (in order)

[ ] Description of the managed Application and where to find more information
[ ] Features and capabilities of your Operator and how to use it
[ ] Any manual steps about potential pre-requisites for using your Operator

Operator Metadata should contain

[ ] Human readable name and 1-liner description about your Operator
[ ] Valid category name1
[ ] One of the pre-defined capability levels2
[ ] Links to the maintainer, source code and documentation
[ ] Example templates for all Custom Resource Definitions intended to be used
[ ] A quadratic logo

Remember that you can preview your CSV here.
--
1 If you feel your Operator does not fit any of the pre-defined categories, file an issue against this repo and explain your need
2 For more information see here

@Allda PTAL

@johnbe11 Why was this operator removed?
The associated issue (https://issues.redhat.com/browse/ISV-5151) is not publicly visible and there is zero explanation in this PR


webworker: expose WorkerOptions parameter on constructor

closes https://github.com/Microsoft/TypeScript/issues/28136

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: AviVahl sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

@saschanaz ready for re-review. please let me know if any further changes are needed.

@AviVahl can you merge from master before I merge this?

@sandersn rebased to master

Thanks @AviVahl !


refactor(store,world): move around interfaces and base contracts

torn on whether to put interface files into an interfaces dir (I tend to prefer not doing this but we do this in world already and I'd like to be consistent)

torn on whether to put interface files into an interfaces dir (I tend to prefer not doing this but we do this in world already and I'd like to be consistent)

Agree with the point on consistency, moved tables to the same folder structure in both for the same reason


[stable/grafana] Bump to 6.0.0

What this PR does / why we need it:

Bumps Grafana to 6.0.0
Fixes broken README.md formatting

Which issue this PR fixes
Special notes for your reviewer:

Wasn't sure for major release of app to bump chart major, minor or bugfix.
I didn't see anything in upgrade notes that needed to be done to chart.

Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md

/ok-to-test
/assign @maorfr

/lgtm


samples/deploy_ovf.py fix bad object name in error

Fixes #556

Hi @seisen , Please can you provide testing details done after this change?
Thanks

$ python deploy_ovf.py -s XXX -u XXX --cluster_name CLUSTER_NEEDLE -f data.ovf -v Template
Before the patch:
Unable to find object by the name of CLUSTER_OTHER in list:
["CLUSTER_1", "CLUSTER_OTHER"]
After the patch:
Unable to find object by the name of CLUSTER_NEEDLE in list:
["CLUSTER_1", "CLUSTER_OTHER"]

Thanks for Contributing


Pedantic error

When I put vtkObjWriter in my modules I get the following errors because I have -Wpedantic set as my CXX_FLAGS
vtkOBJWriter.h:39:43: error: extra ‘;’ [-Werror=pedantic]
   vtkTypeMacro(vtkOBJWriter, vtkAlgorithm);

vtkOBJWriter.cpp:50:34: error: extra ‘;’ [-Werror=pedantic]
 vtkStandardNewMacro(vtkOBJWriter);

If I remove the semi-colons, surprisingly it compiles and also runs.

Seems reasonable since the macro will just "copy/paste" the code into that position, which already has all of its own semicolons. I'd be happy to accept a pull request!

Sure. I have created a pull request.


Docs referencing wrong Struct Tag

In the Model definition document it says to ignore a field the Struct Tag `gorm:"-"` must be set.
http://jinzhu.me/gorm/models.html#model-definition
However, after checking the source code it seems that the Struct tag ``` sql:"-"` `` must be set to ignore fields.
Where is the code for the documents stored?

Are you using an old version gorm?


[Bug] Message with email forwarded as an attachment only shows the content of the attached email

I just received a message (A) from someone using Outlook's features to forward another message (B) as an attached file. In OWA, when you open A, you can see what they wrote in this message and an icon for the attached message (B) is visible. Clicking on the attachment icon will open a new browser window with OWA showing the forwarded message (with its own attachments).
In nmail, A is only visible when HTML conversion is disabled, or when opening the corresponding plain text file (but it is not obvious that the multiple text files correspond to A and B):

I'm not sure if this can be improved or depends on the HTML conversion tool (lynx in my case). Maybe it's just the usual mess with HTML messages, and in that case it's fine to just toggle HTML on and off with t. However the difference here is it is not obvious that we are missing some content when viewing the HTML version, because it shows the forwarded message just fine, while usually I would toggle HTML on/off because the HTML version is unreadable, without ambiguity.

Thanks for reporting @Kabouik - I haven't come across this scenario in my own normal usage, but now when I test sending an attached email using Outlook I can see the behaviour you describe.
It is likely not an issue with lynx but rather with how nmail parses the email attachments. I will need to look into how nmail should process these type of email messages.

Thanks for reporting this issue @Kabouik - a fix has been implemented, and now any attached email messages should show up as as .eml attachment in nmail.
Please let me know if you still encounter any issues relating to this. Thanks!

Thanks for reporting this issue @Kabouik - a fix has been implemented, and now any attached email messages should show up as as .eml attachment in nmail.
Please let me know if you still encounter any issues relating to this. Thanks!

Additional changes were implemented in 392bd75 to ensure message list correctly indicates whether an email has an email message attachment. These changes will cause cache to be cleared. I don't foresee any more such changes in a near future.

Additional changes were implemented in 392bd75 to ensure message list correctly indicates whether an email has an email message attachment. These changes will cause cache to be cleared. I don't foresee any more such changes in a near future.

Thanks!

Thanks!


[Workspaces] Option to show only workspaces on current monitor

Should be able to enable config option to only show the workspaces on the current screen.

Implemented