Nested SECTIONS, execution path, and potential interference with language scope

Hello,
So this is a general question that could get quite further in depth. Running on Visual Studio 2015 Pro latest updates on Windows 7 x64. As far as I know, I have latest platform SDKs as well.
I am having a peculiar error in a BDD-style test approach, it "works" in the original author's RYO framework, but is failing to run under Catch.
In particular I am wrapping the C-nng reconnect test code in a C++ wrapper and running into some issues. So to establish some degree of sane expectations, I am porting the C tests into C++ Catch.
I can "run" the C tests, which reports "ok" and the duration, but not much else. So at least I think it is "running" successfully.
So that more or less leaves me with some Catch nuance I am ignorant to that may possibly be interfering.
First, according to the docs each SECTION are evaluated and each depth-first path is performed through each leaf, or as far as it can reach without striking a failure, correct? And in such a way that whatever is scoped in the parent(s) is visible to the nested SECTION, yes?
Thus far, the only differences I can fathom is that Catch runs from the beginning through the end of each leaf; whereas, Convey, from what I understand actually "unwinds" each node, with the possibility of a Reset operation at each unwind. Otherwise, that I can determine, it's the "same" depth-first BDD style organization.
All that said, this is probably insufficient detail for you, so I will need to circle around in the next day or so to present my repository that is based on the nng code for consideration. If you wouldn't mind, have a look at my reconnect.cpp when it is available and see if there is anything that jumps out as being potentially problematic.
Thanks!

Which error report is producing:
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
reconnect.exe is a Catch v1.10.0 host application.
Run with -? for options

-------------------------------------------------------------------------------
C style NNG reconnect works
  We can create a pipeline
  Dialing before listening works
  We can send a frame
-------------------------------------------------------------------------------
G:\Source\Spikes\nanomsg\cppnngswig-working\swig\cpp\tests\core\reconnect.cpp(12
8)
...............................................................................

G:\Source\Spikes\nanomsg\cppnngswig-working\swig\cpp\tests\core\reconnect.cpp(15
3): FAILED:
  REQUIRE( ::nng_msg_len(msgp) == std::strlen(hello.c_str()) )
with expansion:
  0 == 5
with messages:
  Dialing push on address: 'inproc://nng'
  Pull listening on address: 'inproc://nng'

===============================================================================
test cases:  1 |  0 passed | 1 failed
assertions: 23 | 22 passed | 1 failed

And for my C++ wrapper repo. Again it's the reconnect project, Catch unit tests.

Turns out my confusion was a semantic misunderstanding in the domain. Sections are okay after all; not the issue.


Simplify {CMPXCHG,DEC,INC,XADD}.LOCK in Decompiler

Interlocked* are Win only. With GCC and Clang they are __sync_*.
I assume it is easier for users of latter to adapt them if used (add some #define) ...

@ekilmer I cannot add you as reviewer ...

While on it I found:

On master branch:

Shouldn't there be ADD from ia.sinc in Constructor Line #'s?

I think your discussion topic should be linked to this https://github.com/NationalSecurityAgency/ghidra/discussions/5686 ?

In my head, there are two things the sleigh specifications are used for:

Producing human-readable and (attempting) recompilable decompilation
Semantics for (relatively) automated program analysis tools

While this PR is good for use-case 1, users of use-case 2 will likely not be happy about removing a pcode implementation, due to the addition of modeling more custom pcode ops.
It could be argued that use-case 2 people already need to model a lot of other existing pcodeops, but I would argue these pcodeops only exist because the semantics are sufficiently complex (sha1*, etc. instructions) or they are defacto interfaces (syscall, etc. instructions).
I see you've made a similar change to simplify pcode with a single new op in https://github.com/NationalSecurityAgency/ghidra/pull/5208, which means there's precedence from the maintainers for merging this kind of change, so this looks fine from that point of view.

If there were a way to support both use-cases, that would be ideal, but I'm not sure if that capability is possible. Off the top of my head, I imagine it could be implemented by including the Interlocked* changes alongside the existing implementation and have a conditional on some global state value recompileRepr, or something, that is set for the decompiler text view but unset for automated analyses. 🤷

@jobermayr in https://github.com/NationalSecurityAgency/ghidra/pull/5788#issuecomment-1723813058: It's an ADD with a destination memory operand, which means it could be locked,^1 so it goes through the lockable version in sleigh. In this case, there's no lock prefix, so it just turns into nothing and does the normal pcode operation(s).

so it goes through the lockable version in sleigh. In this case, there's no lock prefix, so it just turns into nothing and does the normal pcode operation(s).

Is there a counterpart to globalget or a possibility to check whether lockx_: is lockprefx=1 {} is true? So I could try sth. like:
:ADD^lockx_ Mem,Reg32    is vexMode=0 & lockx_ & opsize=1 & byte=0x1; Mem & Reg32 ...
{
    local tmp = globalget(lockprefx);
    if (tmp == 1) goto <interlocked>;
    Mem = Mem + Reg32;
    goto <end>;
<interlocked>
    Mem = InterlockedAdd(Mem, Reg32);
<end>
}

so it goes through the lockable version in sleigh. In this case, there's no lock prefix, so it just turns into nothing and does the normal pcode operation(s).

Is there a counterpart to globalset or a possibility to check whether lockx_: is lockprefx=1 {} is true? So I could try sth. like:
:ADD^lockx_ Mem,Reg32    is vexMode=0 & lockx_ & opsize=1 & byte=0x1; Mem & Reg32 ...
{
    local tmp = globalget(lockprefx);
    if (tmp == 1) goto <interlocked>;
    Mem = Mem + Reg32;
    goto <end>;
<interlocked>
    Mem = InterlockedAdd(Mem, Reg32);
<end>
}

Good question... I haven't seen anything like that, but maybe I missed it somewhere.

Good question... I haven't seen anything like that, but maybe I missed it somewhere.

It is really easy after trial and error (missing a good documentation):
:ADD^lockx_ Mem,Reg32   is vexMode=0 & lockx_ & lockprefx & opsize=1 & byte=0x1; Mem & Reg32 ...
{
    tmp:1 = lockprefx;
    if (tmp == 1) goto <interlocked>;
    *:4 Mem = *:4 Mem + Reg32;
    goto <end>;
<interlocked>
    *:4 Mem = InterlockedAdd(Mem, Reg32);
<end>
}

Good question... I haven't seen anything like that, but maybe I missed it somewhere.

It is really easy after trial and error (missing a good documentation):
:ADD^lockx_ Mem,Reg32   is vexMode=0 & lockx_ & lockprefx & opsize=1 & byte=0x1; Mem & Reg32 ...
{
    tmp:1 = lockprefx;
    if (tmp == 1) goto <interlocked>;
    *:4 Mem = *:4 Mem + Reg32;
    goto <end>;
<interlocked>
    *:4 Mem = InterlockedAdd(Mem, Reg32);
<end>
}

This may require a bit of trial and error but you should be able to do something like this.
:ADD^lockx_ Mem,Reg32   is vexMode=0 & lockx_ & lockprefx=0 & opsize=1 & byte=0x1; Mem & Reg32 ...
{
    *:4 Mem = *:4 Mem + Reg32;
}

:ADD^lockx_ Mem,Reg32   is vexMode=0 & lockx_ & lockprefx=1 & opsize=1 & byte=0x1; Mem & Reg32 ...
{
    *:4 Mem = InterlockedAdd(Mem, Reg32);
}


[OWL-241] refine host.delete API

modified:   http/graph_http.go
modified:   http/zabbix.go

The modification doesn't match your PR title. Could you please split it to different PRs?

Done. PR#19.


Clarification of number type

The spec definition uses "number" in a lot of places. As it is TypeScript based, this would imply any integer or floating point number is permitted. This is a problem for languages that have separate types for integers and floats.
In practice I imagine most implementations are using integer values. What prompted this was the WorkDoneProgress set of notifications, which have a percentage property. The doc comment implies that integer values are expected, but it doesn't say this outright and it would not be unreasonable to send floating point values to represent a fraction of a percent.
It would help a lot if the kinds of number number can represent are explicitly stated. If this is already in the spec I couldn't find it before the first usage in the Content-Length header description.

So far number is used as integer. The protocol is not using any floats.

But clangd reports the progress percentage with a float.
cc @sam-mccall

Some wording around number vs integer would be appreciated, maybe "number means 53-bit integer except where otherwise specified"?
Sending percentage: 98.5 seems natural and compliant with the current spec. If WorkDoneProgressReport.percentage is supposed to be an integer, I think the spec should say so. (But I don't think this would be an improvement)
FWIW, we look at this case by case and in every other case we decided not to send/receive non-integers. E.g. we'll reject a request with VersionedTextDocumentIdentifier.version = 17.3, while accepting both 17 and 17.0. Maybe non-complaint by the letter of the spec, but no complaints yet.

I don't think specifying the exact integer bit count is good. Typically the range of a number would be determined by it's purpose, and many grow with the size of the file (e.g., Positions). So any width can only be a lower bound unless you want to tie the protocol to files below a certain size.
If a client/server can pick the representation width, then I would just let them pick whatever they think is sane, and respond to overflow issues as they see fit. At most I think the spec should just add some advice on recommended minimum widths. Implementations that can satisfy them can be happy, and ones that can't aren't automatically noncompliant just because they can't handle files above some arbitrary size.
Allowing floats for percentage seems reasonable, clients could just round it as they like. It wouldn't even contradict the spec as-is.
I definitely would appreciate if the signedness is specified, even if it's just to say everything is signed. File versions apparently have clients returning negative numbers. But one particular type that normally wouldn't be expected to contain negative numbers is Position, so there probably exist implementations that only take non-negative values. (negative values are useful for translating Positions by other Positions, but I don't know of any existing reason for this in the protocol).

If a client/server can pick the representation width, then I would just let them pick whatever they think is sane, and respond to overflow issues as they see fit.

Completely disagree. A specification should be complete and data types are key parts of a specification. Otherwise it’s at best unpredictable, perhaps  de facto, and at worst unworkable.

@puremourning I think the width discussion should be a separate issue. I opened this one to have 'number' differentiated between integers and floats. This is universally useful, as many source languages support both (even if they appear as a single kind). And, based on https://github.com/microsoft/language-server-protocol/issues/1037#issuecomment-662412400, integer-only languages are still compatible with the protocol as-is, and float-only languages can emulate integers. Languages without numeric types would already be unable to support LSP given number is required in many placed. As you support a complete specification, I think we can agree on this much being good and useful.
On the other hand, specifying integer widths is much more controversial and is not something many higher level languages have control over. I understand there exist standards (e.g., 2^53 comes from IEEE 754), but I don't presume to know that every potential implementation language follows this standard.

I think we can agree on this much being good and useful.

no doubt! 👍

On the other hand, specifying integer widths is much more controversial

Yeah, sorry i didn't mean to imply that we should specify integers in bits, but that the required range of integers should be specified. e..g. A conforming implementation _must_ support integers in the range -2^31 to 2^31-1 or something like that. What i object to is the idea that we let server and client vendors "pick whatever they think is sane". That's cthulhu.

Sorry if the size thing is a distraction - solving only float vs int is still progress.
They are closely related though. Just like sending "7.5" as your document version is legal today but likely to lead to interop problems, so is "1180591620717411303424" (2^70). ±2^53 seems like the natural limit (per RFC7159, and the spec's general tendency towards JS/TS) and should be implementable everywhere. But any other (smaller) limit is obviously fine.

This could be made more precise using a JSON schema (#67) as the related Debug Adapter Protocol does instead of being limited to the TypeScript basic types. This allows them to use "type": "integer" where appropriate, although the human-readable spec is still translated to TypeScript number. Regarding ranges, the DAP uses the sentence "The value should be less than or equal to<PHONE_NUMBER> (2^31 - 1)." to indicate this where applicable so I don't think it's unreasonable to expect LSP to be able to indicate this as well.

I think adding the same sentence to LSP makes sense (e.g. defining number to be in the int32 range).
We could also do the following in the type definitions:
type int32 = number;
type uint32 = number;
and then use int32 and uint32 in the spec d.ts to make this clear. Opinions?

Opinions?

Sounds great.
If you're on the fence, I'd lean towards signed int32 everywhere (even when semantically nonnegative) for simplicity and as a concession to Java.

It seems fine, especially if there's precedence with DAP, and it's a lot more useful than the current situation. Would the change be visible in the specification document? I checked the DAP equivalent and the schema uses integer but the document that one would actually be reading only says number. If this was already the case with the LSP I would not have seen it.
I was also thinking over the benefits of fixing the value range. I guess implementations can take the fixed size in the spec to mean they don't need to validate the sizes, which may help with JSON libraries that silently round numbers that are too large (because all numbers must, by the spec, be in range in the first place). What should a sender do then if it needs to send a number outside of the range? Would detecting this need to be added to the reference implementation, or is the scenario just considered to be unsupported in the first place?

I would opt to do the change in the spec and the d.ts file.

OK. I did a pass over the spec. We have a one case were we allow decimals in the range of [0-1]. Do you think we need to say anything about the precision. I actually would leave it open.

One other questsion: the precentage for work done reporting is currently defined as a value between [0-100]. I can either allow decimals or only integers. I think it is good enough to only allow integers. Any objection?

Did all the edits. Please cast your votes for decimal and precentage

Closing. Left percentage as a uinteger in the range [0, 100]

@dbaeumer The ProgressToken type is still using number. Is this intentional?

Sorry, missed this. We'd have a preference for work done being floating point, as stable clangd 10 + 11 releases don't round the percentages.
Happy to change the behavior going forward (next release is in march or so), but those releases will still be around for a couple of years, probably.

@KamasamaK No, fixed it.


Modal dialogs do not close when they lose focus

Some of our modal dialogs do not close after a user tabs off of the last element. The focus has moved back to the underlying page but the modal remains. Make sure the modal closes when it loses focus.
This seems like a common thing that Bootstrap should be addressing. Research bootsrap's docs to determine if we're just missing something. Otherwise add some JS to close/hide the modal on blur.
This feedback was provided from the UCOP electronic accessibility review. It was defined as having 'Medium' priority.

@sjDCC @xsrust @briri This is no longer an issue as far as I can tell. But a link with a dialog box that opens in a new window can be an issue as it remains visible after clicking link. See screen shots. Not sure if this is worth coreecting, as jasvascript fix might affect some unforseen functionality.

@mariapraetzellis will check it and close it if it's fixed.

ok, I think this is no longer an issue. Here are the places where we use modal dialogs:

The 'Edit Profile' page - log in, go to the edit profile page, change your email address, click 'Save'. A password confirmation modal dialog will open. When I click off of the modal it disappears properly.
The 'Edit Plan' page - Edit one of your plans, click on the 'View all' link in the guidance selection area. Click off of the modal dialog. It disappears when you do so.
The 'Users' page - Login as an admin, go to the Admin --> Users page, click on 'Edit' for one of the users. The dialog disappears properly when I click off of it.

I also verified that the user can use the tab button to move to the 'cancel' and other buttons on the modal dialog

Edit profile pages
 works well
edit plan page works well when I click on expand all and collapse all
The 'Users' page - I am not sure @briri how to test this one

@magdalenadrafiova you can test the 'Users' page by logging in as an admin and the going to the 'Users' page. Then click on the 'Edit' link for one of the users. This will open a modal window that allows you to edit their privileges/roles. If you navigate away from the window (e.g. click on the greyed out page under the modal window) then the modal window properly closes (it was not doing that properly in the past).

Checked all 3 cases and modals all close. Yay!
Also, the "expand all" button let me tab to guidance embedded in tabs. Couldn't figure out how to do that before


Unpin scipy

Cannot reproduce the issue reported in #185, so this PR simply removes the pin to scipy<=1.12.
Closes #185
Opened as a draft to see if our CI passes.

The issue in the CI does not originate from scipy, but instead from incompatibility of tensorflow probability to numpy 2.0. At first, I could not reproduce the issue locally, because locally, I installed using the pmc specs, and pymc currently pins to numpy<2.
The current solution is to pin numpy in liesel to <2.0, too, until the downstream issue is addressed. There's already an issue in the tensorflow probability repo:

https://github.com/tensorflow/probability/issues/1814

Once this is addressed, we can unpin numpy, since pymc correctly handles its dependency on numpy itself.


set session_replication_role = 'replica';

Hi @benawad , I am not sure if this is the right place to ask you this, but I got a bug and it is tricky to kill it.
I am on the 36th minute of the tutorial, I am trying to run the app, do the first migration, and insert the first post.
I am getting this error:

For some reason, it tries to execute select statement two times and just looks like a lot of funny business with the SQL.
Any ideas, thoughts?

2 fixes I found. #1 is probably the most preferable

make sure the postgres user has superuser privileges - ALTER USER myuser WITH SUPERUSER;
in the mikro-orm.config, in the migrations section, add the disableForeignKeys option
export default {
migrations: {
path: path.join(__dirname, './migrations'),
pattern: /^[\w-]+\d+.[tj]s$/,
disableForeignKeys: false,
},
...

@kurtzilla Looks like a clean and elegant solution, thanks for the info

@kurtzilla Thanks! the #1 worked for me.


Remove caching of the DEBUG settings from the label printer plugin

As we discussed in #7622

Thanks @martonmiklos


METASEARCH 3.0

At the current moment, metasearch is not profitable.  Also, someone online told me making things for free forever is not sustainable, so thus I present:
METASEARCH 3.0
Current implemented features:

Google Analytics, to help us optimize and streamline the user experience
Advertisements from our sponsors, to make sure metasearch can stay sustainable for the foreseeable future
reCAPTCHA v2, to stop bots from illegally stealing my server's processing power and bandwidth

This pull request is only the start of this update for metasearch, other planned features include:

AI
Blockchain
Paid subscription (that shows less ads)
NFTs
AI
Metaverse

There is a staging instance for this update at https://staging.s.matdoes.dev. Looking forward to hearing your feedback!

lgtm

As a daily user of metasearch2, and a proud proponent of privacy. I see this as a blow to the metasearch ecosystem. I strongly encourage you reconsider your shift profit model.

Just don't do this to /buttons, I abuse that :3

A highly profitable next step would be to follow the footsteps of DuckDuckGo in partnering with BigTech.

This would kill the project and defeats the entire point, theres plenty of other meta search engines like searxng that are objectively better and arent trying to implement changes that compromise privacy and are trying to go for profit, implementing changes like that removes the point of using a metasearch engine and having privacy from using google. I can assure you will just waste your time since you will end up killing the project with changes like these.

@theogbob and others, first of all, thank you for voicing your concerns.
I understand that this update may adversely affect the workflow of a small minority of users, but it is necessary for the future of the project, as there are no developers who will work for free. We conducted extensive research to determine the best ways of going about this, and we discovered that the amount of advertising on a website is directly proportional to the amount of advertising revenue generated. If you are bothered by advertising, don't worry, the paid subscription will be releasing very soon.
As for privacy, I see no issue here. Google and our other advertising partners have a long-standing reputation of safeguarding their users' personal data from hackers and thieves. Now about the problem of SearxNG, we do have a plan for addressing it in the future. Our plan is to purchase the maintainers' rights to their project, and eventually merging it into metasearch and deprecating SearxNG.
There is no current plan to abort the development of metasearch 3.0. I've gone ahead and updated this branch with the new features from the master branch, as it will likely be merged soon.
Thanks for your understanding,
mat

The current implementation presents a significant accessibility issue: it is difficult for users to distinguish between advertisements and legitimate search results (see attached image). This can lead to confusion and impact the user experience.

To enhance clarity and improve usability, we recommend either providing a clearer visual distinction between advertisements and legitimate results or making the 'Ad' marker more prominent and readable.
I have attached a mockup demonstrating how the latter approach could be implemented, with a bolder and more distinct 'Ad' marker that will allow users to easily identify sponsored content, ensuring a more transparent and accessible interface.

@mat-1
It's not about googles data safety which debately isn't good but that's a different topic, it's the fact using a meta search engine is ment to provide privacy from providers like google who sell your data to advertises and use it for there own purposes and your changes basically are the opposite of what a meta search engine was supposed to be, a way to use search engines like google and maintain a level of privacy by not directly interacting with there URLs & apis.

Me when I shoot myself in the foot

Me when I shoot myself in the foot

describes this PR in 1 sentance

@mat-1 It's not about googles data safety which debately isn't good but that's a different topic, it's the fact using a meta search engine is ment to provide privacy from providers like google who sell your data to advertises and use it for there own purposes and your changes basically are the opposite of what a meta search engine was supposed to be, a way to use search engines like google and maintain a level of privacy by not directly interacting with there URLs & apis.

While we acknowledge that maintaining a certain level of privacy is important to our users, it’s crucial to understand that without a reliable and consistent source of revenue, the long-term viability of this project cannot be ensured. Balancing privacy concerns with the financial sustainability of our operations is essential, and we must consider all available options to ensure the continued growth and success of this initiative.
If you have any suitable alternatives to Google analytics and Google ads that might offer comparable benefits while offering enhanced data privacy, I’m confident Mat would be open to discussing them.

we should merge this 🗣🗣🗣

quite frankly i dont understand the hate. i like this more because it reminds me of google so im more familiar with it


mobile_scanner package conflicts with google_mlkit_face_detection

Hi all, thanks for the efforts in making this package.
I tried with mobile_scanner 3.0.0-beta.1 too, but GoogleMLKit/BarcodeScanning is 3.2.0 and GoogleMLKit/FaceDetection is 3.1.0.
  In Podfile:
    google_mlkit_commons (from `.symlinks/plugins/google_mlkit_commons/ios`) was resolved to 0.2.0, which depends on
      MLKitVision

    google_mlkit_face_detection (from `.symlinks/plugins/google_mlkit_face_detection/ios`) was resolved to 0.4.0, which depends on
      GoogleMLKit/FaceDetection (~> 3.1.0) was resolved to 3.1.0, which depends on
        MLKitFaceDetection (~> 2.1.0) was resolved to 2.1.0, which depends on
          MLKitVision (~> 4.1)

    mobile_scanner (from `.symlinks/plugins/mobile_scanner/ios`) was resolved to 0.0.1, which depends on
      GoogleMLKit/BarcodeScanning (~> 2.6.0) was resolved to 2.6.0, which depends on
        MLKitBarcodeScanning (~> 1.7.0) was resolved to 1.7.0, which depends on
          MLKitVision (~> 3.0)

You should run pod update in your ios directory. The version defined in this package is the latest version:
 s.dependency 'GoogleMLKit/BarcodeScanning', '~> 3.2.0'
https://github.com/juliansteenbakker/mobile_scanner/blob/master/ios/mobile_scanner.podspec

The google_mlkit_face_detection package has been updated.
https://github.com/bharat-biradar/Google-Ml-Kit-plugin/pull/356


The .project weight in '.pth' file seems mismatch with the model?

I've taken a look at the '.pth' file and I found there are two .project.weight when the depth of a tree is 2.
This is for dla34:

According to the figure in your paper and your code:

self.project comes after downsample and appears only once during a single level, but why here are two .project.weight  in the pth?
Hope for your reply soon.

I haven't found any pretrained weight (.pth) file provided in this repo, could you tell me where did you downloaded it? THX!


Add v8 heap statistics to Health endpoint

Adding properties from the following to the health endpoint JSON response:
v8.getHeapStatistics()
v8.getHeapSpaceStatistics()

LGTM.


Add 'x11' to display_init driver list

Add x11 to driver list for Pi Model B HDMI output using Raspbian Stretch

Fixed no output on Pi Model B HDMI video output by adding 'X11' to driver list.  Environment is Raspbian Stretch.

I hand merged your changes.  I don't know why every line was marked as changed.  Line endings?

Thanks, Jeff.  I'm unsure why the whole file showed as diff.  I edited in place under Debian.  Thank you for adjusting it.  I'll look out for cause in the future.

Yeah, well there's nothing to say that the files are not CRLF already, or
something else is not right about then.
Could be my fault.
J
On Tue, Feb 6, 2018 at 2:10 PM, Rick Slater<EMAIL_ADDRESS>wrote:

Thanks, Jeff. I'm unsure why the whole file showed as diff. I edited in
place under Debian. Thank you for adjusting it. I'll look out for cause in
the future.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/n1kdo/n1mm_view/pull/13#issuecomment-363531665, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ARfTZOhOcfZhm7QOdXuqkjKUZVGjmBoZks5tSKO0gaJpZM4R4W3l
.


Bugfix - DatePicker and TimePicker pass unknown props and allow enter key

Updates DatePicker and TimePicker to have the same behaviour as other components with an Input and pass unknown properties to the Input (e.g. tabIndex).
It also adds a KeyPress event to the input, that opens the dialog on enter and passes the event to any KeyPress passed as a prop.

Thanks! 👍 !


Changes to Temperature and Redshift Files

“emisssion_profile.jl”:
The current version seems to have some of the errors we previously fixed, such as: r_isco function incorrectly defined, and the being temp_obs and r_isco function not being exported correctly.
Additional changes are removing the negative sign from the Mdot equation, which previously seemed to be necessary to invert the temperature line profile the correct way round, but is no longer the required. Furthermore, removing this negative appears to have solved the issue of getting negative values inside our temperature function and as such we no longer need to take the absolute value of our temperature before taking the quarter power.
Finally, upon re-checking the units following the changes made to the r_isco function, namely changing the value of r_g into gravitational units (M), dimensional analysis suggested the resulting flux required a conversion factor of c^6/G^2. This would convert the flux obtained from using gravitational units which gives flux in 1/MT to SI units where flux is M/T^3. Testing this with our line temperature profile using “Rel_PT_Emission Profile.jl” we obtained a black hole with temperature of order 10^6 for a 10 solar mass black hole which is certainly reasonable.
“Rel_PT_Emission Profile.jl”:
Changes include corrections to the r_isco function and flux conversion factor from gravitational to SI units.
“ObsTempScript.jl”:
This is a script to obtain a plot of the observed temperature profile. It runs for a mass of 1, but seems to give incorrect temperatures.

Output of "ObsTempScript.jl":

@kyle8mcknight I've resolved the merge issues, so you will have to pull this branch again before you add new commits to the PR.
If I have some time this weekend, I'll try and have a look at the units as well, but I can't promise anything. My intuition is that the way the radius is being scaled from the integrator is off.
Can I request you plot the "Rel_PT_Emission Profile.jl" in gravitational radii, as it's more conventional in the literature. Practically, this is just dividing r_vals in L. 71 by the Schwarzschild radius, which would put it into the same units as the integrator.
From the setup you have created, it doesn't look like you need the plunging region redshift functions, since you specify the disc inner-radius to the ISCO, which is fine 👍
Just a thought, the Fanton paper made an assumption about the maximal temperature, and then coloured the image based off of maximal values (Eq. (78) I believe)? Could this be another avenue to explore in the mean time? It would give you two methods then to compare and discuss in your reports too.

The Schwarzschild radius for the Kerr black hole is actually already implemented, it's just termed inner_radius, as it's used in a chart context.
So you can get r_s with
using CarterBoyerLindquist

m = CarterMethodBL(M=1.0, a=1.0)
CarterBoyerLindquist.inner_radius(m)

The implementation of this function is here in CarterBoyerLindquist.jl.

@dangoh123 @kyle8mcknight With #16 the redshift for within the ISCO is now implemented, which should hopefully let you explore a more interesting range of a for your reports.


Set border-collapse: collapse in vlist

Fixes #2100.
vlist uses a table layout and border-collapse which affects it is set to separate in table tags. This resets it.

Codecov Report

Merging #2103 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2103   +/-   ##
=======================================
  Coverage   94.81%   94.81%
=======================================
  Files          81       81
  Lines        5280     5280
  Branches      926      926
=======================================
  Hits         5006     5006
  Misses        250      250
  Partials       24       24

Flag
Coverage Δ

#screenshotter
89.69% <ø> (ø)
:arrow_up:

#test
88.54% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad4a877...2429cd3. Read the comment docs.

Thanks for figuring this out.


customizing tool tips and item labels #3372

use for testing
https://www.dropbox.com/s/p9fwlx3uqlm0xhs/3372.bkr?dl=0

the tooltips look great, but the itemLabel option should set the item labels, right now it is setting the tooltips.  it should also turn on showItemLabel automatically.

also please add your test notebook to the tutorial directory and link to it from the main tutorial.

:+1:


feat: 🎸 add support for 7.0 envs

Description

Breaking Changes

JIRA Link

Checklist

[ ] Updated the Readme.md (if required) ?

/fast-forward


chore(main): release 0.2.9

:robot: I have created a release beep boop
0.2.9 (2024-01-18)
Bug Fixes

checkout repo... (3ecf38d)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/engeir/volcano-core/releases/tag/v0.2.9 :sunflower:


RTL support

Feature request（新功能建议）
It would be good to have RTL support for this template for the languages like Arabic, Urdu.

Hi, My name is Muhammad Adil Khan. I work for Portable, Australia and our goal is to contribute to open source projects on Github. My team and I would like to contribute to this project. Please let us know if we can work on this change request and would like to work on other tickets as well.
I look forward to hearing from you soon.
Thanks,
Adil


Demo works but webapp isnt connecting

The demo is running and is able to leave the menü and complete. But the web app isn't connecting to the switch its just loading the entire time.
I am running on a win 11 laptop and the newest Ubuntu(in a vm demo works with it) and switch version.
And there is crashed written under the loading points.
could somebody help me?

It connected after 30 tries but not sure why


Change APIs to return real entities instead of entity reference

Example:
GET teams?field=users returns a list of users in the team as entityReference. But entityReference does not have fields to return user profile.
@Sachin-chaurasiya FYI... A bug to track the request you made in issue #98

Won't fix


2.0.0 Release notes

We should make sure we have a good set of release notes for when we finally push the 2.0.0 release out of prerelease, which should be soon-ish.
/cc @AnthonySteele

Done by @AnthonySteele.


understanding onesource::substellar

Several remarks :

name is bad : should be something like substract_stellar_component_in_IR
bool substar should not be passed as an argument; the condition on it should be in photoz_lib
I do not understand the comment  only for lambda_rf>25000 when compared to the condition allFilters[k].lmean / (1 + consiz) < 25.
when ab[k]-fluxMod<0, abIR[k] is set to sab[k]. Why? I thought that in LePHARE allowing below 0 fluctuations of fluxes was a thing. What is the statistical rationale behind setting abIR[k] to sab[k]?
if I am not mistaken the last else condition means that sab[k] has to be negative, right? In which case busfir[k] and bscfir[k] should already be 0 no?

If I understand well, this code amounts to subtracting the predicted flux from interpolation of the best fit (interpolation in magnitude in the space of the templates, occurring in interp_lib). So what remains are IR emission lines and what else?
This is what gets fitted in fitIR so it means that the additional library for IR has templates for this component not coming from standard library. Can you write down what these are please, so that I can also put some explanation in the C API.

here are some answers:

we can change the naming. Fine for me. substract_stellar_component would be fine.
the comment is wrong. It should be "only for lambda_rf<2500"
In the case  ab[k]-fluxMod<0, I think it would have been more logical to set abIR to 0. That was a choice of Stephane for his 2013 paper. I can ask him why. But you don't want to keep the negative value, because if the fit in optical of the stellar component of the SED is going wrong, you don't want to subtract it and get crazy value. It's highly model dependent.
sab could be negative in case of upper limit, and the band is used in such case. I don't think it implies that budfir is set to 0 (i don't see why). So, I would keep it like this.

In this function, we substract the light coming from stellar population to the observed flux, in order to keep only the dust emission. Then, we can fit the dust emission (without the stellar component) using specific templates and get the LIR. To substract the stellar component, we fit templates like BC03 (without dust emission) in the UV-visible wavelength domain. The predicted flux at larger wavelength can be substracted from the observed ones, leaving only the observed dust emission (in reality, also the AGN but we don't include it yet).


add missing eslint dependencies

Hi @nikoskalogridis, I apologize about the confusion here.  We have switched to using standard, and @most/eslint-config-most is deprecated.  So, I think the right thing to do would be for us to delete the straggling .eslintrc files.  I'd be happy to do that, since it was a mess I made :) but if you'd rather do it in order to keep moving, that's fine too (and I'd be very thankful!).

@briancavalier sure I could remove it myself, no problem ;-)

Thank you! I’d really appreciate it.

closing in favour of #226


WebFinger Report Suggestions

If I imagine myself as a consumer of this report, these are the suggestions I'd have for improving the report format. Overall, my objective is to be able to consume the report information with maximal "signal to noise ratio" and minimal effort.
Note that these comments are for the WebFinger report. It's possible that we'll have a slightly different report template for AP/Fediverse test reports.
Suggestion: Use implementation names for the test matrix column headings.
The "Session n" heading provides no useful information to me. I'd like to see the name of the implementation that's a link to the session details. I don't want to click each heading to investigate which implementation it is.
Suggestion: Remove the node driver class names from the text matrix column headings.
As a WebFinger report consumer, I don't care about those in that context. If I need that information, I'll drill down into the session details.
Suggestion: Find a better way to label failures in the test matrix
The current approach of using the exception name is less useful, in my opinion, than just a "failed" label. I see "AssertionError" and "HardAssertionFailure" and I don't know what that is telling me without expanding the cell. It's just extra noise. There are two primary types of failures in WebFinger test suite: bad HTTP status and missing CORs header. Maybe we could use a short label for those in the cell (e.g., "Wrong HTTP status", "Missing CORS header").
Suggestion: Remove the malformed URI tests
Since it's effectively impossible to pass them. That's a spec issue, not an implementation issue per se.
Suggestion: Avoid floating right.
On a desktop, especially with large monitors and a wide browser window, it's more work to scan to the far right to see information since (in the west) we tend to read left-to-right. If that information is not valuable, then fine. But in this case, I think that's probably not the case (the feditest link, for example). If the metadata flowed on the left (maybe just to the right of the test summary), then the timestamp in the report title isn't needed since it can be found easily in the metadata table.
Suggestion: Minimize table borders
I understand this is an artistic/aesthetic consideration, but for me, the table borders are mostly visual noise that I need to dig through to find the information I want.

See also #89 which I'm working on.

It might also be useful to show a % pass, or an equivalent visual indicator, for each column in the test result matrix and for each row (to see how common a given test passes or fails across the set of servers).

Suggestion: Human-friendly test names
The test names are diffficult to read and have a lot repeated information (e.g., the "webfinger.server" prefix). Maybe we could use a decorator to provide a human-friendly name for the test?

Suggestion: Don't inline expanded error messages in the test matrix cells
With the fully expanded messages in the text matrix, I need to vertically scroll down to horizontally scroll the table and then vertically scroll back up to see which columns are visible. This is with a reasonably large monitor (32"). There are at least a couple possible solutions. One is to use a short name for the type of failure in the text matrix cells ("HTTP Status" or "No CORS Header" or "Wrong Content Type" that can be expanded to see the details). This would keep the matrix more vertically-compact. However, if we have a large number of tests, there would still be the same issue with the table height. We could also duplicate the headers at the bottom of the matrix for horizontal scrolling purposes (even with the verbose error messages in the cells).

Re matrix test column headings, I'm now using the constellation name, and in case of Imp-vs-X we can simply use X (and the constellation generation scripts do that now). But it's more complicated if we test application X against Y (e.g. Mastodon vs WordPress). For that, we need to list both apps, and the sequence is important too.
Re Node Driver in column: done.
Re failure labeling in the test matrix: Created separate issue #139
Re malformed URI tests, which specific tests would you like to remove?
Re floats: gone.
Re borders: replaced with something hopefully less offensive :-)
Re human-friendly test names: I'd prefer to keep the identifiers (which are now line breaking) and inline the description of the test. Separate issue #140
Re inline expanded error messages: removed, and see #139.
Can we close this and have separate issues for whatever remains of this list?

I'll close this and follow up on, or create, separate issues. Thanks.


fix: no params lead to error

I couldn't execute generate-benchmarks.sh, because vtebench was getting $2 as a param.
The culprit here is the param collector, which, when no params are given (i.e. $# is 2) it makes a sequence from 3 to 2. (2 contains the benchname).
This PR fixes that

yes, I am running macOS. I also thought it might've been to do with different versions of seq. I get similar issues sometimes in other projects.


DataGrid "Simple Filter Mode with Menu" header styling proposal

The problem
I am of the opinion that the DataGrid's "Simple Filter Mode with Menu" is the nicest way to do filtering. However I feel like the CSS could use some improvements when the column width becomes small.

In my opinion there is a lot of "wasted space" here.
My idea
So I got to thinking that maybe a container query that would activate when the column width is below 100px (or some other value) and then collapse the input.
The first thing you could do:
.rz-filter-button .rzi {
   display: none;
}

However this can also be taken a lot further:
.rz-filter-button {
   position: absolute;
   min-width: unset;
   margin-left: 0.2rem;
   z-index: 100;
   border-radius: 80%;
}

.rz-filter-button .rz-spinner-input {
   text-indent: 24px; /* A variable should probably be used here */
}

My questions for you!
Is this something that you find interesting?
Should I attempt a PR?
Which iteration is the best?
Do you have a better idea or improvements?

I have made a POC for it:

Here is the code for it:
.rz-cell-filter-content {
  container-type: inline-size;
}

@container (max-width: 200px) {
  .rz-cell-filter-content .rz-filter-button .rzi {
    display: none;
  }
  .rz-cell-filter-content .rz-filter-button {
    min-width: 2rem;
    min-height: 90%;
    margin: unset;
    border-radius: 50%;
    padding: unset;
  }
  .rz-cell-filter-content .rz-cell-filter-label {
    border: var(--rz-input-border);
    border-radius: var(--rz-input-border-radius);
    box-shadow: var(--rz-input-shadow);
    background-color: var(--rz-input-background-color);
    height: var(--rz-input-height) !important;
    display: flex;
    gap: 4px;
    align-items: center;
    padding: 0 4px;
  }
  .rz-cell-filter-content .rz-cell-filter-label:hover
  {
    box-shadow: var(--rz-input-hover-shadow);
    border: var(--rz-input-hover-border);
  }
  .rz-cell-filter-label:has(input:focus) {
    box-shadow: var(--rz-input-focus-shadow) !important;;
    border: var(--rz-input-focus-border) !important;;
    outline: var(--rz-input-focus-outline) !important;;
    outline-offset: var(--rz-input-focus-outline-offset) !important;;
  }
  .rz-cell-filter-content .rz-cell-filter-label .rz-inputtext,
  .rz-cell-filter-content .rz-cell-filter-label .rz-spinner,
  .rz-cell-filter-content .rz-cell-filter-label .rz-textbox {
    border: none !important;
    outline: none;
    box-shadow: none !important;
    background: unset;
  }

  .rz-cell-filter-content .rz-cell-filter-label .rz-textbox,
  .rz-cell-filter-content .rz-cell-filter-label .rz-spinner-input,
  .rz-cell-filter-content .rz-cell-filter-label .rz-spinner {
    padding: unset;
  }
}

I have tested it on all the themes on the Radzen website


Auto Doc does not work for Django2.0

URLPattern pattern._regex does not exist and its not rendering the urls properly.

any updates on this? 😬

@iMakedonsky can you please check out this and merge?

Hello, I tried your pull request and I got the same error.


Trivial fix for null-pointer segfault on invalid url

Current coverage is 56.08%

Merging #9 into php7 will not affect coverage as of 031b929

@@             php7      #9   diff @@
=====================================
  Files           4       4
  Stmts        1858    1858
  Branches        0       0
  Methods         0       0
=====================================
  Hit          1042    1042
  Partial         0       0
  Missed        816     816

Review entire Coverage Diff as of 031b929

Powered by Codecov. Updated on successful CI builds.

Good thing I am such an errant maintainer and missed the first PR, merged!


-p N, N > 1 seems absurdly slow?

Thanks for this brilliant tool which is exactly what I wanted.  I followed the helpful guide https://github.com/evansm7/vftool/issues/2#issuecomment-735455161
to get a Ubuntu VM which is very fast in single user mode (no -p option), but as soon as I enable more than one core, performance is very very slow.
Is this a known issue?

When you increase -p option you should also increase -m option to test.

Very funny, that's not the issue (I'm allocating 6 GB).  So nobody else sees this? That's very odd.  I can reproduce it trivially.

Very funny, that's not the issue (I'm allocating 6 GB and it reproduces with just -p2). So nobody else sees this? That's very odd. I can reproduce it trivially.

+1.  Running with 8 CPUs and 8GB RAM but so slow (disk IO?). Reduce it to -p1 then it works smoothly.

Noticing this too. With 1 CPU it is fine. You can easily see the problem when pinging the NAT gateway (in my case this is <IP_ADDRESS>).
With a single CPU the ping time is < 1ms, but with multiple CPUs it can be often > 100ms. Not disk bound or CPU bound, but more like a synchronisation issue. The problem appears to be fundamental to Apple's virtualisation framework as this phenomenon is also happening in the "SimpleVM" project too.

Been discussing this on Twitter – looks like Virtualization.framework is dropping interrupts that aren’t directed at VCPU 0. I can recreate by manually changing the IRQ affinity in sysfs; as an example, IRQ6 was my virtio-net interrupt and I lose network when I direct it at VCPU1 instead of “any”:
echo 1 > /proc/irq/6/smp_affinity_list
My Debian basic installation doesn’t have irqbalanced (or equivalent), so all IRQs remain steered at 0 – but other distros appear to install it by default.
Someone said they had problems with Ubuntu cloud image without irqbalanced, which I have yet to look into. Maybe they have a similar userspace utility, maybe the kernel now has some spicy redirection.
It isn’t a vftool/SimpleVM bug, but a workaround is needed. Feels like a distro-specific tips & tricks discussion?

That seems like an ... odd choice of apples.  I apt remove irqbalance and ran for f in /proc/irq/*/smp_affinity_list;do echo 0 > $f;done and it looks like it made this things way better.  Curiously enough, /proc/irq/1/smp_affinity_list, .., /proc/irq/4/smp_affinity_list can't be written and stay at 0-5 (I ran with -p6, thus the "5"), but it appears to be significantly better than before. Thanks!
I would close, but it seems worthwhile to mention this in the documentation before closing.

Thanks @tommythorn! I think removing irqbalance is enough, **edit it isn't, see below. I am seeing guest compilation timings for Rust be on par with the M1 host. Previously, using a VM launched with -p 4, cargo took over 7 minutes just to print that it had started compiling the first crate.
irqblance discussion below.
Rust compilation timings
time cargo build --force ripgrep
ubuntu guest with smp_affinity_list changes applied
Launched with -p 4
   Finished release [optimized + debuginfo] target(s) in 31.61s
   Replacing /home/test/.cargo/bin/rg
    Replaced package `ripgrep v12.1.1` with `ripgrep v12.1.1` (executable `rg`)

real    0m31.819s
user    1m55.319s
sys     0m2.653s

apple m1 host
   Finished release [optimized + debuginfo] target(s) in 27.25s
   Replacing /Users/seanj/.cargo/bin/rg
    Replaced package `ripgrep v12.1.1` with `ripgrep v12.1.1` (executable `rg`)

real	0m27.389s
user	2m39.468s
sys	0m8.593s

With irqbalance installed
root@ubuntu:~# cat /proc/irq/*/smp_affinity_list
0-3
0-3
0-3
0-3
3
0-3
1
0-3

Two minutes and cargo hasn't even finished updating crate index.
time cargo install --force ripgrep
    Updating crates.io index
^C

real    1m57.985s
user    0m0.166s
sys     0m0.038s

After allowing all cores to handle all interrupts
root@ubuntu:~# cat reset_affinity.sh
#!/bin/bash

# set -eux;

for f in /proc/irq/*/smp_affinity_list;
        do echo "0-3" > $f;
doneroot@ubuntu:~# ./reset_affinity.sh
./reset_affinity.sh: line 6: echo: write error: Input/output error
./reset_affinity.sh: line 6: echo: write error: Input/output error
./reset_affinity.sh: line 6: echo: write error: Input/output error
./reset_affinity.sh: line 6: echo: write error: Input/output error
root@ubuntu:~# cat /proc/irq/*/smp_affinity_list
0-3
0-3
0-3
0-3
0-3
0-3
0-3
0-3

We see compilation times back to normal.
   Finished release [optimized + debuginfo] target(s) in 31.73s
   Replacing /home/test/.cargo/bin/rg
    Replaced package `ripgrep v12.1.1` with `ripgrep v12.1.1` (executable `rg`)

real    0m31.931s
user    1m55.523s
sys     0m2.975s

But! It isn't the configuration, but that act of writing to the smp_affinity_list. Clearing and resetting the irqs to the slowest observed settings still results in a [32s,45s] compile.
With a reconfigured affinity list of
root@ubuntu:~# cat /proc/irq/*/smp_affinity_list
0-3
0-3
0-3
0-3
3
0
1
0

I was still able to get a 35s compile.
    Finished release [optimized + debuginfo] target(s) in 34.36s
   Replacing /home/test/.cargo/bin/rg
    Replaced package `ripgrep v12.1.1` with `ripgrep v12.1.1` (executable `rg`)

real    0m35.939s
user    2m0.677s
sys     0m2.327s

The worst configuration I could come up with apart from a fresh boot is
root@ubuntu:~# cat /proc/irq/*/smp_affinity_list
0-3
0-3
0-3
0-3
3
3
3
3

And while the console lags a bunch we still see
    Finished release [optimized + debuginfo] target(s) in 34.81s
   Replacing /home/test/.cargo/bin/rg
    Replaced package `ripgrep v12.1.1` with `ripgrep v12.1.1` (executable `rg`)

real    0m43.805s
user    1m55.938s
sys     0m1.976s

It looks like both irqbalance needs to be removed and, the smp_affinity_lists need to get written to, preferably with low numbered cpus.
root@ubuntu:~# cat reset_affinity.sh
#!/bin/bash

cat /proc/irq/*/smp_affinity_list;

for f in /proc/irq/*/smp_affinity_list;
        do echo "0" > $f;
done

cat /proc/irq/*/smp_affinity_list;

BTW, when running a guest with -p 8 I am seeing nearly identical rust compilation perf
 ../vftool/build/vftool -k vmlinux -i initrd -d a_disk1.img -m 2048 -p 8 -a "console=hvc0 root=/dev/vda"
    Finished release [optimized + debuginfo] target(s) in 25.59s
   Replacing /home/test/.cargo/bin/rg
    Replaced package `ripgrep v12.1.1` with `ripgrep v12.1.1` (executable `rg`)

real    0m25.815s
user    2m59.086s
sys     0m4.982s

M1 host

    Finished release [optimized + debuginfo] target(s) in 26.39s
   Replacing /Users/seanj/.cargo/bin/rg
    Replaced package `ripgrep v12.1.1` with `ripgrep v12.1.1` (executable `rg`)

real	0m26.523s
user	2m38.673s
sys	0m9.794s

You can also fix it by adding  irqaffinity=0 in the kernel cmdline.

You can also fix it by adding  irqaffinity=0 in the kernel cmdline.

irqaffinity=0 would probably be the preferred method. This should probably just be documented in the same way as the console.

irqaffinity=0 would probably be the preferred method. This should probably just be documented in the same way as the console.


[Card Image is not showing on some extensions]

What happened?
Bug: Card images of some extensions are not showing.
Name of extensions having issues:
Binary_To_Decimal_converter, Company Insider, Control Chrome Tabs, Dictionary_Extension, Dyslexic Help, Emoji-rating, Fahrenheit_Celsius_Converter, GDocs Viewer, Profile-statistics, Recipe Extension, Roots_Quadratic_Eqn, step-progress-bar, Type Color Change, Word_Counter
Also tell us, what did you expect to happen?
Just fix the card images having issues.
Screenshot.

How can we reproduce this bug?
Visit: Website
scroll down and you will see images of some cards that are not showing.
Desktop Information (Optional)
No response
Urgency (Optional)
No response

Will make a pull request for the issue soon.

Made a PR, please review, any further changes happy to resolve :)


[BACKEND] Add a configurable parameter for the number of threads per warp

Add a configurable parameter for the number of threads per warp for other GPU. Like: Intel GPU.
Make it default to be 32 not change code logic on the CUDA/AMD GPU.
Note: The Intel GPU GenX ISA is explicit SIMD and can support variant number of threads lane per HW execution unit.

Return 32 as the default number for threads per warp if no triton_gpu.threads-per-warp attribute in module op for backward compatible.

It seems I missed on change in the LIT test case that the new TritonToTritonGPU pass would add the attribute "threads-per-warp". I will update it quickly

@chengjunlu , please keep me informed if the PR has landed. I will rebase my third-party backend pr.

@ptillet @chengjunlu I have two comments regarding this PR:

The name threadPerWarp can be easily confused with the threadsPerWarps parameter used in BlockedEncodingAttr (code). Maybe warpSize is a better name.
For AMD backend, the current default warpSize should be 64. I think we currently use USE_ROCM to set warpSize. But it would be better if it can be set at frontend. cc: @jayfurmanek @micmelesse

@zhanglx13 I reviewed the PR quickly, but I agree with your comments. Would you be ok submitting another PR to fix these two things?

@ptillet Yeah. I'll take care of it.


assume utf-8 encoding instead of binary

Right now encoding does not work if the source data is in UTF already:
irb(main):009:0> "тест".force_encoding('utf-8').encode('utf-8', :invalid => :replace, :undef => :replace, :replace => '?')
=> "тест"
irb(main):010:0> "тест".force_encoding('binary').encode('utf-8', :invalid => :replace, :undef => :replace, :replace => '?')
=> "????????"

Never mind, looks like it breaks CSV parser for some reason.

That's a valid concern, though.  Can you give an example of where this was
breaking?
On Sunday, April 19, 2015, Alexey Lapitsky<EMAIL_ADDRESS>wrote:

Never mind, looks like it breaks CSV parser for some reason.
—
Reply to this email directly or view it on GitHub
https://github.com/cantino/reckon/pull/45#issuecomment-94294406.

You can see it in the tests:
https://github.com/cantino/reckon/blob/master/spec/reckon/csv_parser_spec.rb#L38
Reckon's CSV parser replaces all non-ascii content with "?" by default (which I don't think it should).
After my fix ruby's CSV implementation breaks with this backtrace in the tests (you can also see it in travis):
     Failure/Error: app = Reckon::CSVParser.new(:file => File.expand_path(File.join(File.dirname(__FILE__), "..", "data_fixtures", "extratofake.csv")))
     ArgumentError:
       invalid byte sequence in UTF-8
     # /usr/lib64/ruby/2.0.0/csv.rb:1987:in `=~'
     # /usr/lib64/ruby/2.0.0/csv.rb:1987:in `init_separators'
     # /usr/lib64/ruby/2.0.0/csv.rb:1509:in `initialize'
     # /usr/lib64/ruby/2.0.0/csv.rb:1288:in `new'
     # /usr/lib64/ruby/2.0.0/csv.rb:1288:in `parse'
     # ./lib/reckon/csv_parser.rb:244:in `parse'
     # ./lib/reckon/csv_parser.rb:11:in `initialize'
     # ./spec/reckon/csv_parser_spec.rb:36:in `new'
     # ./spec/reckon/csv_parser_spec.rb:36:in `block (3 levels) in <top (required)>'

What if we changed it to data = data.force_encoding(options[:encoding] || 'BINARY').encode('UTF-8', :invalid => :replace, :undef => :replace, :replace => '') so that all replacements go to ??  Would that fix the issue?


Add landuse boundary partial indexes

I noticed some slow queries, and these new indexes should speed them up.
@zerebubuth Could you review please?

:+1: nice catch!


scenario 4: step by step guide

scenario 4: step by step guide

@Mahesh-MSFT  can you merge this into the step-by-step branch? Since it's an outline, it may be better to commit to merge it to main when it's closer to completion.

will do @sblair01 . didn't knew there was a separate branch for step-by-step!

No worries Mahesh. Feel free to proceed under step-by-step branch as discussed. Thanks a lot.


Dotnet monitor

dotnet-monitor helm chart

@Doron-Bargo I finished doing all the changes you requested

I added toleartions


Suggestion for new command in Animu

Can we please have a new command for manga? Just like the one which we have for anime in Animu.
Thank you.

It'll be added shortly

Manga Command is added


Set -DLIBOMP_FORTRAN_MODULES=ON

If we want to build OpenBLAS with OpenMP support with flang (c.f. https://github.com/conda-forge/openblas-feedstock/pull/115), we'll need to package the Fortran bits of OpenMP, otherwise we run into:
[...]
[3646/19184] Building Fortran object CMakeFiles\LAPACK_OVERRIDES.dir\lapack-netlib\SRC\ssytrd_2stage.f.obj
[3647/19184] Building Fortran object CMakeFiles\LAPACK_OVERRIDES.dir\lapack-netlib\SRC\ssytrd_sb2st.F.obj
FAILED: CMakeFiles/LAPACK_OVERRIDES.dir/lapack-netlib/SRC/ssytrd_sb2st.F.obj
%BUILD_PREFIX%\Library\bin\flang.exe -I%SRC_DIR%\lapack-netlib\SRC -I%SRC_DIR%\lapack-netlib\LAPACKE\include -fopenmp -fopenmp -ffixed-line-length-72 -o CMakeFiles\LAPACK_OVERRIDES.dir\lapack-netlib\SRC\ssytrd_sb2st.F.obj -c CMakeFiles\LAPACK_OVERRIDES.dir\lapack-netlib\SRC\ssytrd_sb2st.F-pp.f
error: Semantic errors in CMakeFiles\LAPACK_OVERRIDES.dir\lapack-netlib\SRC\ssytrd_sb2st.F-pp.f
D:\\bld\\openblas_1719536014536\\work\\lapack-netlib\\SRC\\ssytrd_sb2st.F:237:11: error: Cannot read module file for module 'omp_lib': Source file 'omp_lib.mod' was not found
        use omp_lib
            ^^^^^^^

Flang 18 is going to be unusable to build OpenBLAS, but I'd like to open this for discussion/review already, so we can figure this out before LLVM 19 releases.
PS. This is rebased from the dev branch, with which I was able to get CI green in https://github.com/conda-forge/openblas-feedstock/pull/115.

This is quite curious. We cannot build the fortran bits of OpenMP 18 with flang 18, but it works if either of the versions is bumped to 19. In this PR we bump the flang version, on the dev branch it's the other way 'round.
In any case, even if we don't merge this for OpenMP 18, I want to enable this for OpenMP 19, so I'd appreciate feedback @conda-forge/openmp

Gentle ping on this @conda-forge/openmp

Can we move the .mod file to a different output? The cycles are also there in linux if we switch _openmp_mutex.

Hi! This is the friendly automated conda-forge-linting service.
I wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found some lint.
Here's what I've got...
For recipe/meta.yaml:

The build section contained an unexpected subsection name. build is not a valid subsection name.
The build section contained an unexpected subsection name. host is not a valid subsection name.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

Can we move the .mod file to a different output?

@isuruf, I've rebased this PR on #144 and added the output you wanted - I think I've incorporated all the feedback so far on this here. I still want to clean up the commit history better, but the content of the changes should be OK now. As such, I'd ask you to please review this at your earliest convenience.

Gentle ping @isuruf

Thanks for the review; should be fixed now.

Good now?

I think we're close here @isuruf, can you please help me wrap this up?


Question about MainLightShadows

Really cool package, I can't thank you enough for this ! I was wondering and fiddling with it and is there a way to actually remove the "self-shadowing" from the MainLightShadows. I've been trying for a good while now to get access to the unity shadow texture and the fact is while I'm compositing my lighting I've got issue that comes from trying to remove the ugly self shadowing that I'm getting with the node. It might not be possible maybe the actual shadow looks like this, but since I'm compositing my own self shadowing with the inverse DOT it kinda conflict with it. The projected shadow are so smooth and nice compared to what the self shadows are. :/ I'm a noob at HLSL could've probably figured it out in shaderlab, but now I'm a bit lost. Thanks in advance for your time!

I guess it's just not possible since the mesh is also casting shadow on itself, but weirdly enough projected shadow are really nice and smooth with the self-shadowing provided by unity is just kinda bad and vertex based. I'll try out another approach to actually mask it out via my Lighting DOT.  Also you should put a link up for donation because this is just a golden package ! :)

Yeah, I don't think there's a way to avoid the self shadowing (without removing shadow casting from the object completely but that's probably not what you want). The N dot L is usually combined with the shadows to hide it though. The vertex-y look might also look smoother if the shadow bias settings are adjusted on the URP asset.

Yes thanks a lot! I've figured as well, I was about to kinda go the hard way around with this ,but ended up using my N dot L as a mask, smoothstep it to refine and get as much of it out as possible without feeling a skewed lighting is the way to go here. I was about to dive into custom render passes and try to figure out how to get some global shadow map, but the same issue would've occured anyway. Thx again and really sorry to have bothered you with that ! :) It really amazing what can be done with your custom nodes.

I mean I added a lot on top already with SSS and normal map lighting ;) And I'm serious about if you ever create a place to receive donation I'm clearly gonna donate, cause this is just a life saver for any tech artist making a switch from standard to Scriptable pipeline and you sir deserved a medal ! :)


Entity static check

Added a static parameter to entities which can be set to false and true in the editor (False is default).
Also changed the check in ResourceView so that the first scene can be opened when first starting up the hymn. This was such a small change that I added it to this pull request rather than making a whole new branch just for it.

SonarQube analysis reported 1 issue
Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

 AncientFungus:LGEPR: Cppcheck cannot find all the include files (use --check-config for details)


Unable to connect to API Server on cluster startup

/kind bug
What happened: Created a cluster following the sequence of steps as described here and ran tarmak kubectl get nodes but received the following output:
$ tarmak kubectl get nodes
DEBU[0000] trying to connect to https://<IP_ADDRESS>:58100  app=tarmak
WARN[0000] error connecting to cluster: Get https://<IP_ADDRESS>:58100/version: dial tcp <IP_ADDRESS>:58100: getsockopt: connection refused  app=tarmak
DEBU[0000] start tunnel cmd=[ssh -F /Users/luke/.tarmak/dev-cluster/ssh_config -O forward -L<IP_ADDRESS>:58703:api.dev-cluster.tarmak.local:6443 bastion]  app=tarmak destination=api.dev-cluster.tarmak.local
WARN[0000] starting ssh tunnel failed with error: exit status 255  app=tarmak destination=api.dev-cluster.tarmak.local
DEBU[0000] error connecting to tunnel: dial tcp <IP_ADDRESS>:58703: getsockopt: connection refused  app=tarmak destination=api.dev-cluster.tarmak.local
DEBU[0000] error connecting to tunnel: dial tcp <IP_ADDRESS>:58703: getsockopt: connection refused  app=tarmak destination=api.dev-cluster.tarmak.local
DEBU[0001] error connecting to tunnel: dial tcp <IP_ADDRESS>:58703: getsockopt: connection refused  app=tarmak destination=api.dev-cluster.tarmak.local
DEBU[0001] error connecting to tunnel: dial tcp <IP_ADDRESS>:58703: getsockopt: connection refused  app=tarmak destination=api.dev-cluster.tarmak.local
DEBU[0002] error connecting to tunnel: dial tcp <IP_ADDRESS>:58703: getsockopt: connection refused  app=tarmak destination=api.dev-cluster.tarmak.local
DEBU[0002] error connecting to tunnel: dial tcp <IP_ADDRESS>:58703: getsockopt: connection refused  app=tarmak destination=api.dev-cluster.tarmak.local
DEBU[0003] error connecting to tunnel: dial tcp <IP_ADDRESS>:58703: getsockopt: connection refused  app=tarmak destination=api.dev-cluster.tarmak.local
DEBU[0003] error connecting to tunnel: dial tcp <IP_ADDRESS>:58703: getsockopt: connection refused  app=tarmak destination=api.dev-cluster.tarmak.local
DEBU[0004] error connecting to tunnel: dial tcp <IP_ADDRESS>:58703: getsockopt: connection refused  app=tarmak destination=api.dev-cluster.tarmak.local
DEBU[0004] error connecting to tunnel: dial tcp <IP_ADDRESS>:58703: getsockopt: connection refused  app=tarmak destination=api.dev-cluster.tarmak.local

What you expected to happen: To see the list of cluster nodes
How to reproduce it (as minimally and precisely as possible): Run:
tarmak init
tarmak clusters images build
tarmak clusters apply
tarmak kubectl get nodes

Anything else we need to know?: I am working from my own fork of the code (https://github.com/dippynark/tarmak/tree/67-add-pod-security-policies) compiled on OS X
Environment:

Kubernetes version (use kubectl version): tarmak kubectl version has the same issue, but outside of tarmak:

$ kubectl version
Client Version: version.Info{Major:"1", Minor:"8", GitVersion:"v1.8.6", GitCommit:"6260bb08c46c31eea6cb538b34a9ceb3e406689c", GitTreeState:"clean", BuildDate:"2017-12-21T06:34:11Z", GoVersion:"go1.8.3", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"9", GitVersion:"v1.9.3+coreos.0", GitCommit:"f588569ed1bd4a6c986205dd0d7b04da4ab1a3b6", GitTreeState:"clean", BuildDate:"2018-02-10T01:42:55Z", GoVersion:"go1.9.2", Compiler:"gc", Platform:"linux/amd64"}

Cloud provider or hardware configuration**: AWS
Install tools: tarmak
Others:

I think I found the bug. It seems like it's cleaning up the tunnel before executing kubectl:
https://github.com/jetstack/tarmak/blob/master/pkg/tarmak/kubectl/kubectl.go#L139
It was always doing that, but before the cleanup of the tunnel was not working.
I gess we needs to have a cleanUp boolean param or even a stopChannel somwhere around here:
https://github.com/jetstack/tarmak/blob/master/pkg/tarmak/kubectl/kubectl.go#L194
And then this only needs to happen after kubectl has been executed

/assign @dippynark


Add ability to configure double/float precision per config bindable

Incoming PR for OsuConfigManager once this is merged.

I'd consider making this not have a default value, so every call explicitly states a value (or null if it really thinks that's a good idea)

Will do, but I'll have to make sure the osu! PR gets pushed through with the next framework update or it'll break the build.

That's fine.

To make precision a mandatory argument, it needs to go before min.  This could cause a regression for anyone using the framework, since their existing code would be passing in what they think is min and max, but the actual arguments in those positions are precision and min.  I suggest we leave it as optional by default.


submodules=>true doesn't work for rugged

Gemfile:

gem 'rugged', :git => 'https://github.com/libgit2/rugged.git', :submodules => true

Output:

C:\Users\JWeatherford\Desktop\sonic-pi\app\gui\qt>bundler install
Updating https://github.com/jweather/hamster.git
Updating https://github.com/jweather/ruby-beautify.git
Fetching https://github.com/libgit2/rugged.git
fatal: destination path 'vendor/libgit2' already exists and is not an empty directory.
Clone of 'https://github.com/libgit2/libgit2.git' into submodule path 'vendor/libgit2' failed
Retrying git submodule update --init --recursive due to error (2/3): Bundler::Source::Git::GitCommandError Git error: command git submodule update --init --recursive in directory c:/users/jweatherford/desktop/sonic-pi/app/server/native/windows/lib/ruby/gems/1.9.1/bundler/gems/rugged-273e247d72dc has failed.
If this error persists you could try removing the cache directory 'c:/users/jweatherford/desktop/sonic-pi/app/server/native/windows/lib/ruby/gems/1.9.1/cache/bundler/git/rugged-7fee50588a821baac99ce836721cd0259aeedc25'
fatal: destination path 'vendor/libgit2' already exists and is not an empty directory.
Clone of 'https://github.com/libgit2/libgit2.git' into submodule path 'vendor/libgit2' failed
Retrying git submodule update --init --recursive due to error (3/3): Bundler::Source::Git::GitCommandError Git error: command git submodule update --init --recursive in directory c:/users/jweatherford/desktop/sonic-pi/app/server/native/windows/lib/ruby/gems/1.9.1/bundler/gems/rugged-273e247d72dc has failed.
If this error persists you could try removing the cache directory 'c:/users/jweatherford/desktop/sonic-pi/app/server/native/windows/lib/ruby/gems/1.9.1/cache/bundler/git/rugged-7fee50588a821baac99ce836721cd0259aeedc25'
fatal: destination path 'vendor/libgit2' already exists and is not an empty directory.
Clone of 'https://github.com/libgit2/libgit2.git' into submodule path 'vendor/libgit2' failed
Git error: command git submodule update --init --recursive in directory c:/users/jweatherford/desktop/sonic-pi/app/server/native/windows/lib/ruby/gems/1.9.1/bundler/gems/rugged-273e247d72dc has failed.
If this error persists you could try removing the cache directory 'c:/users/jweatherford/desktop/sonic-pi/app/server/native/windows/lib/ruby/gems/1.9.1/cache/bundler/git/rugged-7fee50588a821baac99ce836721cd0259aeedc25'

Well, this works fine for me:
$ cat Gemfile
gem 'rugged', :git => 'https://github.com/libgit2/rugged.git', :submodules => true
$ bundle install
Fetching https://github.com/libgit2/rugged.git
Cloning into 'vendor/libgit2'...
remote: Counting objects: 59652, done.
remote: Compressing objects: 100% (17281/17281), done.
remote: Total 59652 (delta 41202), reused 59611 (delta 41164), pack-reused 0
Receiving objects: 100% (59652/59652), 24.12 MiB | 64.00 KiB/s, done.
Resolving deltas: 100% (41202/41202), done.
Checking connectivity... done.
Resolving dependencies...
Using bundler 1.9.1
Using rugged 0.23.0b1 from https://github.com/libgit2/rugged.git (at master)
Bundle complete! 1 Gemfile dependency, 2 gems now installed.
Use `bundle show [gemname]` to see where a bundled gem is installed.

Can you provide specific reproduction steps?

I had this issue and fixed it with rm -rf /Users/dan/.rbenv/versions/2.2.2/lib/ruby/gems && gem install bundler && bundle.


gh-actions: Add lint workflow for new-log-viewer.

References

new-log-viewer series: #45 #46 #48 #51 #52 #53 #54 #55 #56
Description

gh-actions: Add lint workflow for new-log-viewer.

Validation performed

Created a junhaoliao:gh-action branch from junhaoliao:main.
Made modification in new-log-viewer/src/services/LogFileManager.ts:35 by adding a space in the TODO comment, which violates rule no-warning-comments.
After the GitHub Check was finished, observed the newly added line got marked by github-actions(bot) at https://github.com/junhaoliao/yscope-log-viewer/pull/4/files#r1722872785 in job https://github.com/junhaoliao/yscope-log-viewer/actions/runs/10467679713/job/28986950144 .

This PR had to be closed and replaced by #61 due this PR was wrongly created from Junhao's main branch.


📜 new post - sharepoint embedded overview

Category

[x] Content fix
[ ] New article

Related issues

n/a

Contents of the Pull Request
New article on an overview of SharePoint Embedded

thank you for contributing 🚀


Remove usages of replace() method

Fixes #2705

@lbdreyer All looks good. For #2706 I'm trying to retain some of the test tests, if I can, and they make sense.
I'm assuming that all the replace tests can just be purged?

I'm assuming that all the replace tests can just be purged?

Which tests are you referring to?

Which tests are you referring to?

These https://github.com/SciTools/iris/pull/2708/files#diff-1a002eee61524000a58a8e337597c7d7L1262 ...

The replace methods on iris.cube.Cube and iris._data_manager.DataManager, which those tests were testing, no longer exists so we should just delete them

One thing we did do was increase test coverage thru replacing biggus with dask.
For me replace is kinda equivalent to cube.data = data ... so I was just wondering whether there are any of those tests mentioned above, that could be re-purposed as such cube.data = data tests and live else where in another appropriate test class ... the answer is more likely not, but just thought I'd ask.

@bjlittle
I now understand your point. I think it would be overkill to keep some cube.replace tests but possibly reworking the data_manager.replace tests might make sense

@lbdreyer Thanks, this looks good to me 👍


Invalid global scope naming for UMD build

Intended and actual outcome:
When I removed the apollo-angular libraries from my angular project bundles and add them as externals instead; I noticed an issue.
$ head node_modules/apollo-angular-link-http/bundles/ng.apolloLink.http.umd.js
(function (global, factory) {
    typeof exports === 'object' && typeof module !== 'undefined' ? factory(exports, require('@angular/common/http'), require('apollo-link'), require('graphql/language/printer'), require('apollo-angular-link-http-common'), require('@angular/core')) :
    typeof define === 'function' && define.amd ? define('apollo-angular-link-http', ['exports', '@angular/common/http', 'apollo-link', 'graphql/language/printer', 'apollo-angular-link-http-common', '@angular/core'], factory) :
    (factory((global['ng.apolloLink.http'] = {}),global.ng.common.http,global.apolloLink.core,global.printer,global.ng.apolloLink.httpCommon,global.ng.core));

At the beginning of the last line you can see an assignment global['ng.apolloLink.http'] = {}. This should have been global.ng = global.ng || {}, global.ng.apolloLink = global.ng.apolloLink || {}, global.ng.apolloLink.http = {} instead.
global['ng.apolloLink.http'] is not the same as global.ng.apolloLink.http.
At the end of the last line you can even see that one of the imports is global.ng.apolloLink.httpCommon. When I checked that umd bundle it also assigned it's exports to global['ng.apolloLink.httpCommon']
How to reproduce the issue:
You can simply install the latest version of the packages and check the umd bundles.
Versions
I'm currently getting it on the latest version. I noticed a switch from rollup to ng-packagr, so that might be related (although ng-packagr uses rollup itself).
Currently, I've only checked 3 libraries apollo-angular, apollo-angular-link-http-common and apollo-angular-link-http. Which all faced the same issue.

I think we can change it all to be pascalCased, could you open a PR?

#1305 should fix it

v1.7.0


Building versioned shared library fails when using MinGW

This issue was originally created at: 2016-11-15 18:47:49.
This issue was reported by: yarmond.
yarmond said at 2016-11-15 18:47:49

Specifying a value for SHLIBVERSION in order to generate a versioned shared
library fails when compiling with MinGW. A minimal SConstruct:

env = Environment(tools=['mingw'])
lib = env.SharedLibrary('foo', ['foo.cpp'], SHLIBVERSION='2.4')
env.AlwaysBuild(lib)

Generates the following output:

scons: Reading SConscript files ...
scons: *** A shared library should have exactly one target with the suffix: .dll
    File "<...>\SConstruct", line 2, in <module>

Just came across this one, and tested since there have been shlib-versioning changes - and it still fails, though the failure is different now.
scons: Reading SConscript files ...

scons: *** Multiple ways to build the same target were specified for: foo.dll
File "C:/users/mats/Documents/github/scons/exp/issue3035/SConstruct", line 2, in <module>

Hmm. sounds like other issues which popped up and got fixed with the new logic..
I should probably stick some debug output in there similar to msvc test logic..


Validate all relevant square sizes are committed to in MsgWirePayForData

Closes https://github.com/celestiaorg/celestia-app/issues/620 (after https://github.com/celestiaorg/celestia-app/pull/654 merges)

I expect merge conflicts with https://github.com/celestiaorg/celestia-app/pull/654 so I'd like to merge that PR in first, prior to this one.

Sorry for prematurely moving this from draft to ready for review. Tests passed locally but CI is failing on TestIntegrationTestSuite which presumably doesn't run locally. Will fix and tag reviewers when this PR is ready.

Codecov Report

Merging #666 (e6c18ca) into main (13076a6) will increase coverage by 0.47%.
The diff coverage is 73.52%.

@@            Coverage Diff             @@
##             main     #666      +/-   ##
==========================================
+ Coverage   36.06%   36.54%   +0.47%
==========================================
  Files          24       24
  Lines        2623     2657      +34
==========================================
+ Hits          946      971      +25
- Misses       1594     1600       +6
- Partials       83       86       +3

Impacted Files
Coverage Δ

pkg/shares/parse_message_shares.go
88.60% <ø> (ø)

x/payment/types/wirepayfordata.go
66.35% <73.52%> (+1.33%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

just to note that this is consensus breaking

I'm dumb, this is probably not consensus breaking

I think this is consensus breaking b/c prior to this change, validators would've accepted PFDs that didn't sign over all commits. After this change, those PFDs are considered invalid.
Consensus tests would be very nice. +1 to https://github.com/celestiaorg/celestia-app/issues/313

Correct only the wire message, sorry for the lack of precision.

Then that should only affect the mempool, as even if a WireMsg makes it in the block, then all nodes should treat that the same, which is to subtract the minimum amount of gas.


Start adding Keras fuel economy example to docs

Add Keras example to docs based on https://www.tensorflow.org/tutorials/keras/basic_regression as suggested by @w4nderlust at https://twitter.com/w4nderlus7/status/1101333499817078784
Other example needs a little refinement as I'd hacked around with the data and it doesn't work out of the box. Will add over weekend.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thank you so much for submitting this, I will reformat a little and then merge it.


Don't restrict database error variant on executor

Describe the feature
This should not require ProviderError and should just require Error or Into<BlockExecutionError>
https://github.com/paradigmxyz/reth/blob/ead753db4c96f5f9f0fd2867106d88ef6d312405/crates/evm/src/execute.rs#L123-L123
blocked by https://github.com/paradigmxyz/reth/issues/8088
Additional context
No response

@mattsse I have looked into this one out of interest. Wanted to ask if you thought the diffs in the PR are on the right track or not.
I assume I can get around the current compiler error by implementing the appropriate from() or into(). But it feels like that could be going down the wrong track and likely to hit many more issues after that.
required for `revm_primitives::EVMError<std::boxed::Box<dyn std::error::Error>>` to implement `std::convert::Into<std::boxed::Box<revm_primitives::EVMError<reth_evm::execute::ProviderError>>>`

Any insight / direction would be appreciated, thanks 🙏

ah sorry I forgot to link the relevant issue #8152
this problem will go away with an upcoming stable rust feature, on nightly this already works


bash-it causes problem for gitserver

I installed bash-it on my server which hosts my git repos. Then I found that any remote pull or push from other machines returns the error message
fatal: protocol error: bad line length character: Plea
fatal: The remote end hung up unexpectedly

Uninstallation of bash-it solved the problem.

It looks like Bash-it tries to respond with some kind of error message on new connections - I suppose you're seeing this with SSH connections from a Git client, right?
Can you please try to log in using a standard SSH client into the server to see what Bash-it is trying to complain about? It's probably a message about a dependency that was not found or something like that.
If you get a result there, please post it here. We have tried to eliminate such messages from happening, since they interfere with all kinds of software (e.g. scp), but it looks like this one slipped through.  I bet it's the beginning of "Please do this or that to bla bla bla" 😄
Let me know what you find and we'll get this fixed.

Here are more details about this error.
The server has Ubuntu 16.04LTS installed. I installed bash-it through the git clone and install.sh method provided by the READEME file.
I am pulling/pushing on a Mac with macOS Sierra.

I suppose you're seeing this with SSH connections from a Git client, right?

Not sure what you mean. I did all these in iTerm2, with zsh shell.

In summary, the plugins that are causing trouble are nvm and fasd.

I also figured out it's about the plugins. Tried to enable and disable them to figure out which ones exactly.
If I enable chruby and chruby-auto, I got these
fatal: protocol error: bad line length character: Bash
/home/me/.bash_it/plugins/enabled/250---chruby-auto.plugin.bash: line 4: /usr/local/share/chruby/chruby.sh: No such file or directory
/home/me/.bash_it/plugins/enabled/250---chruby-auto.plugin.bash: line 5: /usr/local/share/chruby/auto.sh: No such file or directory
/home/me/.bash_it/plugins/enabled/250---chruby.plugin.bash: line 4: /usr/local/share/chruby/chruby.sh: No such file or directory

Then I enabled all the plugins and tried to disable them from the last one.
The message without chruby* stuff is
fatal: protocol error: bad line length character: Bash

I went all the way back up and I got a change in the message until I got to nvm plugin.
fatal: protocol error: bad line length character: You
/home/lei/.bash_it/plugins/enabled/250---go.plugin.bash: line 8: go: command not found

Then I diabled go plugin,
fatal: protocol error: bad line length character: You

Finally I figured out the last one which is fasd.

In general, you should only enable plugins that you intend to use, and for which you have installed the required dependencies. If you don't have the chruby tool installed, you should not enable the chruby or chruby-auto plugins. One could argue that the plugins should check for dependencies and then fail silently if the dependencies are not found - Pull Requests to fix these are more than welcome...
To be safe, disable all plugins and only enable what you really want to use.
The comment about the SSH connections was with regards to the "remote pull or push from other machines" that you wrote in your original post. When you use the ssh: protocol to connect to the Git repo, an SSH connection is opened, which opens a shell session on the server, which then runs through the ~/.bashrc file, which in your case seems to load Bash-it and then fails with an error message. You probably would not see this error if you used http:// or https:// for connecting to the Git server to push/pull. I'm not asking you to use HTTP(S) instead of SSH, just a comment...

@nwinkler I got it. Thank you for the explanation. 👍
It's pretty safe to close this issue I guess.

Thanks for closing this. Can you please summarize which plugin was causing the issue? I saw nvm and fasd in your post, but also the chruby ones. Anything else?

@nwinkler chruby, chruby-auto, and go.
I knew from the error message that these three responded with error simply because I haven't installed them. So I didn't include them in my original reply.
I learned from your reply and just realized that I do not have nvm and go either. So this is not bug at all.


Allows to mask secrets

It cool be neat to have details in CI environment but you have to hide your secrets

@all-contributors please add @sbenoistmics for code


Added "virtual" modifier to allow for overrides

Discussion (one-sided at the time of this request) of this PR can be found here: https://forum.openzeppelin.com/t/erc721presetminterpauserautoid-mint-function-and-tokenid/2780/8

The preset mint function is not override-able by parent contracts as it is not marked as virtual. Since mint is not part of the ERC721 standard, and the ability to user super and OZ's outstanding presets exists, why not allow for more flexibility?

Thanks for this contribution! This package is generated automatically from OpenZeppelin Contracts. Would you mind opening the same pull request over at OpenZeppelin/openzeppelin-contracts?


Use regular colima release instead of HEAD

The Problem/Issue/Bug:
Previously colima installation with --HEAD was required, but the needed things have made it into regular release.
How this PR Solves The Problem:
Change docs and tests to use regular colima brew install

TestComposer doesn't seem to work in latest colima/lima. Real oddities. It's actually ddev composer create that doesn't work, and composer create-project drupal/recommended-project /tmp/somepath seems to create the project in a subdirectory of /tmp/somepath instead of in /tmp/somepath itself.


always generates load scripts?

Description
Whenever I restore from Visual Studio, it always generates a ".paket/load" folder with load scripts.  I have tried putting generate_load_scripts: false in my paket.dependencies file, as well as just removing any mention of generate_load_scripts.  This is only an issue because sometimes I use VS Code as well, and OmniSharp (the plugin for C# in VS Code) will crash VS Code entirely if I open a folder that contains load scripts.
Repro steps
Please provide the steps required to reproduce the problem

Create a solution containing C# projects that uses paket.

Add generate_load_scripts: false to the top of the paket.dependencies file.

Set the VS setting to "Automatically restore packages during build in Visual"

Build the solution in VS

Expected behavior
The .paket folder would only contain paket.exe, paket.Restore.targets, and paket.targets
Actual behavior
The .paket folder also contains a "load" folder with load scripts.
Known workarounds
Delete the load folder manually each time you open VS Code.
Related information

Operating system: Win 10
Branch: Installed from the extension marketplace
.NET Runtime Version: ? Of my solution? net471
Performance information, links to performance testing scripts: none

Could you please upload a zip with the repro?
nathan wilson<EMAIL_ADDRESS>schrieb am Di., 2. Apr. 2019,
17:55:

Description
Whenever I restore from Visual Studio, it always generates a ".paket/load"
folder with load scripts. I have tried putting generate_load_scripts:
false in my paket.dependencies file, as well as just removing any mention
of generate_load_scripts. This is only an issue because sometimes I use
VS Code as well, and OmniSharp (the plugin for C# in VS Code) will crash VS
Code entirely if I open a folder that contains load scripts.
Repro steps
Please provide the steps required to reproduce the problem

Create a solution containing C# projects that uses paket.
2.
Add generate_load_scripts: false to the top of the paket.dependencies
file.
3.
Set the VS setting to "Automatically restore packages during build in
Visual"
4.
Build the solution in VS
Expected behavior
The .paket folder would only contain paket.exe, paket.Restore.targets, and
paket.targets
Actual behavior
The .paket folder also contains a "load" folder with load scripts.
Known workarounds
Delete the load folder manually each time you open VS Code.
Related information

Operating system: Win 10
Branch: Installed from the extension marketplace
.NET Runtime Version: ? Of my solution? net471
Performance information, links to performance testing scripts: none

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/fsprojects/Paket.VisualStudio/issues/175, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AADgNLduSLlpNRRkjhBbTfWevlHfXMgmks5vc31zgaJpZM4cYcVD
.

Okay, I had some trouble reproducing it from scratch, and learned more about the problem.  Apparently it happens when your paket.dependencies file and paket.lock file are out-of-sync.  Using the CLI, paket.dependencies wins (if you say generate_load_scripts: false in paket.dependencies, it doesn't matter what's in the paket.lock).  Using the VS extension, the paket.lock file wins (if you have GENERATE-LOAD-SCRIPTS: ON at the top of your lock file, it doesn't matter what's in paket.dependencies).    I have that situation replicated in the zip file attached.  If you look in paket.dependencies, it says generate_load_scripts: false, but if you open the .sln file in VS and build, it will produce a .paket/load folder.
Now that I know the cause and the fix, it's quite easy for me to workaround, so I guess this issue is just FYI.  Feel free to close if you want.
vs-paket-trouble.zip


support sequence

Enhancement

Issue has been fixed by PR #666  and will be published at IvorySQL V4.0

Issue has been fixed by PR #700


ESLint 9

Fix #9476

@pascalgrimaud & @murdos if you have time, maybe be try locally 🙂

@pascalgrimaud & @murdos if you have time, maybe be try locally 🙂

I won't be able to test before one week, but good Idea 🙂

@qmonmert : are you confident enough to merge this?
Is it only for the engine, right?
What about the generated apps?

@pascalgrimaud yes it's for the engine, I will do generated apps after (there is a ticket for that https://github.com/jhipster/jhipster-lite/issues/9496 ), and I'm confident to merge and if there are some problems I'm ready to fix 🙂

@pascalgrimaud https://opencollective.com/generator-jhipster/expenses/215615 🙂

@qmonmert : approved

@pascalgrimaud thanks


Install on MacBook Pro

I have tried installing on Mac and had this error. It looks like there is a possible workaround on PC, but perhaps someone knows how to fix on mac?
Thank you.
Gulp.js
WARN deprecated<EMAIL_ADDRESS>graceful-fs version 3 and before will fail on newer node releases. Please update to<EMAIL_ADDRESS>as soon as possible.

@gofundamental Nothing bad in this deprecation. Use can still use it.

Ok. Thank you. I'll try again. :)


typo: accomodate -> accommodate

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/desktop/how-to-dock-a-conversation-window-in-lync-sdk.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


feature-gates: adding initial structure

This commit introduces the FeatureGates struct in the operator's configuration, enabling a flexible and controlled approach to feature rollout. The FeatureGates struct allows for the enabling or disabling of specific features, with a default behaviour based on each feature's maturity level.
Uses Kubebuilder default value annotations for CRD fields to automatically set default behaviours in the Kubernetes API.
I'm trying to use a simple approach here where we could change promote/depromote a feature by just changing the comments and the default values.
Please let know what I'm missing (probably I'm missing a lot) and what you think about this approach.

@beraldoleal thanks! LGTM overall, couple of questions:

are we merging it with the dummy features? i.e. timeTrabel, AIhealing etc...?
consider filtering the events using Predicate rather than handler, see this reference (IIUC it would filter the events before actually emitted and handled)
Should we deploy also the  osc-feature-gates CM with the default values so it can be used as a template for the user? IDK if it's even possible...

Hi @snir911 , my comments bellow:

1. are we merging it with the dummy features? i.e. timeTrabel, AIhealing etc...?

Good question. I was planning to keep the default map empty (since is a code block) but keep the config/samples/featuregates.yaml there with some notes, saying those are fake... (since is just an example and until we have our first feature on boarded). Wdyt?

2. consider filtering the events using Predicate rather than handler, see this [reference](https://github.com/openshift/sandboxed-containers-operator/blob/721edad2c77f4c8ad7153acb15cdbfc7f0cdd2db/controllers/credentials_controller.go#L116-L140) (IIUC it would filter the events before actually emitted and handled)

When considering the implementation, my initial thought was to use Predicates. However, since the other watches were utilizing EventHandlers, I opted to maintain consistency and avoid a mix of approaches. To be honest, I also prefer using Predicates. If you see no issue with incorporating both EventHandlers and Predicates within the same setup, we could explore this option.

3. Should we deploy also the  osc-feature-gates CM with the default values so it can be used as a template for the user? IDK if it's even possible...

I believe it's possible, yes, but it might be unnecessary. The default values are intended for use as-is, without the need for user intervention. Introducing another ConfigMap into users' deployments for those adhering to the default values might not be ideal. The config/samples/ directory serves as a source of "templates" for users. So, unless there is something I'm missing, I would say to keep it just in config/samples/.

Hi @snir911 , my comments bellow:

are we merging it with the dummy features? i.e. timeTrabel, AIhealing etc...?

Good question. I was planning to keep the default map empty (since is a code block) but keep the config/samples/featuregates.yaml there with some notes, saying those are fake... (since is just an example and until we have our first feature on boarded). Wdyt?

IDK, we can either start with a real feature (maybe peer-pods? but just print a msg instead of actually enabling it ATM?) or maybe to leave only single dummy feature?

consider filtering the events using Predicate rather than handler, see this reference (IIUC it would filter the events before actually emitted and handled)

When considering the implementation, my initial thought was to use Predicates. However, since the other watches were utilizing EventHandlers, I opted to maintain consistency and avoid a mix of approaches. To be honest, I also prefer using Predicates. If you see no issue with incorporating both EventHandlers and Predicates within the same setup, we could explore this option.
AFAIK there's no problem to mix (we do it in the credentials controller), the handlers are usually used when there are some ops needed IIUC..

Should we deploy also the  osc-feature-gates CM with the default values so it can be used as a template for the user? IDK if it's even possible...

I believe it's possible, yes, but it might be unnecessary. The default values are intended for use as-is, without the need for user intervention. Introducing another ConfigMap into users' deployments for those adhering to the default values might not be ideal. The config/samples/ directory serves as a source of "templates" for users. So, unless there is something I'm missing, I would say to keep it just in config/samples/.

Sure, anyway we can do it at any point..

IDK, we can either start with a real feature (maybe peer-pods? but just print a msg instead of actually enabling it ATM?) or maybe to leave only single dummy feature?

Currently peerpods is enabled by another way... adding peer-pods to the feature feature gates without disabling the other way it will be confuse. Also, if we add a new feature with just a print message (lets say "CoCo") it will give the users the wrong impression. IMO it will be confusing. So yes, I will leave just a single dummy feature for now.

AFAIK there's no problem to mix (we do it in the credentials controller), the handlers are usually used when there are some ops needed IIUC..

Ok, I will send a new version with the Predicates.
Thanks again, @snir911 .

@snir911 @bpradipt just pushed with the Predicate implementation, let me know if I'm missing something.

@snir911 ?


Credentials are not updating with smart lock on login

Describe the bug
Credentials are not updating with Google smart lock on login.
Would you like to work on the issue?

yes

It is due to device settings -
E/SmartAuthViewModel$saveCredential: save:FAILURE com.google.android.gms.common.api.ApiException: 16: The save prompt is disabled for the current app. To restore, remove this app from the "Never save" list in the Smart Lock for Passwords settings for all accounts on this device.