[WIP] Erlang 19 integration branch

I'm confused why you're not using rand_compat here? I think that we want to support both Erlang 18 and Erlang 19, generally.

The discussion in Paris went back and forth a few times, but as I understood it, the final decision was to not spend any time on compatibility with older versions until we have a first stable release. And after the Antidote 1.0 release we would support the most commonly used versions.
Changing it to your compatibility library would not be much effort, so I could do that.

What still needs to be discussed is the time handling.
Here is what I got now from the discussions and from looking at the code.

Monotonicity: Replacing erlang:now with erlang:system_time (as it is done currently) should work, as system_time is still monotonic with the default time warp setting ("No Time Warp Mode").
Uniqueness: Most old uses of erlang:now do not need uniqueness. I think it might still be required for generating transaction-ids (in clocksi_interactive_tx_coord_fsm, line 171). There might be other places.
Restarts:  erlang:now and erlang:system_time seem to loose their guarantees after a system restart. So I guess the current version is also not correct in that sense.

Overall, I would suggest to fix the time handling in a separate pull request, since it probably requires a few refactorings if we really want to make the code safe in the presence of time warps and crashes.

I agree with the separate pull request. We need to address fault-tolerance in detail, and separation of concern is here the best way to make progress.

I changed the uses of rand to rand_compat.
Regarding the undefineds in the record types: There are  several cases:

I have changed the cases, where only minimal code changes were required.
I have added comments starting with TODO 19 for the cases that require bigger code changes, or more  knowledge about the purpose of the code.
Some fields are really optional, like the commit_time in the tx_coord_state.
One field was not used at all.

Is this ready to be merged?  What work still remains?  If any, can we make a check list in this PR so we know what we're waiting on?

If I understood @bieniusa correctly, she would also handle the erlang-time problems separately. Then I think this is ready to be merged.

@bieniusa can you confirm?

Confirm hereby the mergability.
@Peter: Can u take care that the remaining issues and bugs are tracked?
Von meinem iPhone gesendet

Am 05.10.2016 um 10:42 schrieb Christopher S. Meiklejohn<EMAIL_ADDRESS>@bieniusa can you confirm?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

Do we need to remove our old erlang and get 19 now?
Is the change back compat to 16B02?

On Oct 6, 2016, at 11:56, Christopher S. Meiklejohn<EMAIL_ADDRESS>wrote:
Merged #220 https://github.com/SyncFree/antidote/pull/220.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub https://github.com/SyncFree/antidote/pull/220#event-814506907, or mute the thread https://github.com/notifications/unsubscribe-auth/ACdPQjQiM9aECzmMI3DQu7Dw-XRbMTOdks5qxMXVgaJpZM4KHX1M.

I tried it with Erlang 18.3 and 19.0. It is not compatible with Erlang 16.

Problem: after the change, this happens when running antidote console:
[os_mon] cpu supervisor port (cpu_sup): Erlang has closed
{"Kernel pid terminated",application_controller,"{application_start_failure,riak_core,{bad_return,{{riak_core_app,start,[normal,[]]},{'EXIT',{undef,[{cuttlefish_schema,files,[["/Users/alek/test_antidote/antidote/_build/default/rel/antidote/lib/11-erlang_vm.schema","/Users/alek/test_antidote/antidote/_build/default/rel/antidote/lib/12-riak_core.schema","/Users/alek/test_antidote/antidote/_build/default/rel/antidote/lib/15-riak_sysmon.schema","/Users/alek/test_antidote/antidote/_build/default/rel/antidote/lib/21-leveldb.schema"]],[]},{clique_config,load_schema,1,[{file,"/Users/alek/test_antidote/antidote/_build/default/lib/clique/src/clique_config.erl"},{line,81}]},{riak_core_cli_registry,load_schema,0,[{file,"/Users/alek/test_antidote/antidote/_build/default/lib/riak_core/src/riak_core_cli_registry.erl"},{line,53}]},{riak_core_app,start,2,[{file,"/Users/alek/test_antidote/antidote/_build/default/lib/riak_core/src/riak_core_app.erl"},{line,104}]},{application_master,start_it_old,4,[{file,"application_master.erl"},{line,273}]}]}}}}}"}
Kernel pid terminated (application_controller) ({application_start_failure,riak_core,{bad_return,{{riak_core_app,start,[normal,[]]},{'EXIT',{undef,[{cuttlefish_schema,files,[["/Users/alek/test_antidot
Crash dump is being written to: erl_crash.dump…done

On Oct 6, 2016, at 11:56, Christopher S. Meiklejohn<EMAIL_ADDRESS>wrote:
Merged #220 https://github.com/SyncFree/antidote/pull/220.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub https://github.com/SyncFree/antidote/pull/220#event-814506907, or mute the thread https://github.com/notifications/unsubscribe-auth/ACdPQjQiM9aECzmMI3DQu7Dw-XRbMTOdks5qxMXVgaJpZM4KHX1M.

Using erlang 19.

On Oct 7, 2016, at 12:54, Alejandro Z. Tomsic<EMAIL_ADDRESS>wrote:
Problem: after the change, this happens when running antidote console:
[os_mon] cpu supervisor port (cpu_sup): Erlang has closed
{"Kernel pid terminated",application_controller,"{application_start_failure,riak_core,{bad_return,{{riak_core_app,start,[normal,[]]},{'EXIT',{undef,[{cuttlefish_schema,files,[["/Users/alek/test_antidote/antidote/_build/default/rel/antidote/lib/11-erlang_vm.schema","/Users/alek/test_antidote/antidote/_build/default/rel/antidote/lib/12-riak_core.schema","/Users/alek/test_antidote/antidote/_build/default/rel/antidote/lib/15-riak_sysmon.schema","/Users/alek/test_antidote/antidote/_build/default/rel/antidote/lib/21-leveldb.schema"]],[]},{clique_config,load_schema,1,[{file,"/Users/alek/test_antidote/antidote/_build/default/lib/clique/src/clique_config.erl"},{line,81}]},{riak_core_cli_registry,load_schema,0,[{file,"/Users/alek/test_antidote/antidote/_build/default/lib/riak_core/src/riak_core_cli_registry.erl"},{line,53}]},{riak_core_app,start,2,[{file,"/Users/alek/test_antidote/antidote/_build/default/lib/riak_core/src/riak_core_app.erl"},{line,104}]},{application_master,start_it_old,4,[{file,"application_master.erl"},{line,273}]}]}}}}}"}
Kernel pid terminated (application_controller) ({application_start_failure,riak_core,{bad_return,{{riak_core_app,start,[normal,[]]},{'EXIT',{undef,[{cuttlefish_schema,files,[["/Users/alek/test_antidot
Crash dump is being written to: erl_crash.dump…done

On Oct 6, 2016, at 11:56, Christopher S. Meiklejohn<EMAIL_ADDRESS><EMAIL_ADDRESS>wrote:
Merged #220 https://github.com/SyncFree/antidote/pull/220.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub https://github.com/SyncFree/antidote/pull/220#event-814506907, or mute the thread https://github.com/notifications/unsubscribe-auth/ACdPQjQiM9aECzmMI3DQu7Dw-XRbMTOdks5qxMXVgaJpZM4KHX1M.

Which Erlang exactly are you using?
I had problems with the one from ESL (was missing a Library), but can run tests with the one from Ericsson.
Can u compile and run the systests?
Von meinem iPhone gesendet

Am 07.10.2016 um 13:40 schrieb Alejandro Zlatko Tomsic<EMAIL_ADDRESS>Using erlang 19.

On Oct 7, 2016, at 12:54, Alejandro Z. Tomsic<EMAIL_ADDRESS>wrote:
Problem: after the change, this happens when running antidote console:
[os_mon] cpu supervisor port (cpu_sup): Erlang has closed
{"Kernel pid terminated",application_controller,"{application_start_failure,riak_core,{bad_return,{{riak_core_app,start,[normal,[]]},{'EXIT',{undef,[{cuttlefish_schema,files,[["/Users/alek/test_antidote/antidote/_build/default/rel/antidote/lib/11-erlang_vm.schema","/Users/alek/test_antidote/antidote/_build/default/rel/antidote/lib/12-riak_core.schema","/Users/alek/test_antidote/antidote/_build/default/rel/antidote/lib/15-riak_sysmon.schema","/Users/alek/test_antidote/antidote/_build/default/rel/antidote/lib/21-leveldb.schema"]],[]},{clique_config,load_schema,1,[{file,"/Users/alek/test_antidote/antidote/_build/default/lib/clique/src/clique_config.erl"},{line,81}]},{riak_core_cli_registry,load_schema,0,[{file,"/Users/alek/test_antidote/antidote/_build/default/lib/riak_core/src/riak_core_cli_registry.erl"},{line,53}]},{riak_core_app,start,2,[{file,"/Users/alek/test_antidote/antidote/_build/default/lib/riak_core/src/riak_core_app.erl"},{line,104}]},{application_master,start_it_old,4,[{file,"application_master.erl"},{line,273}]}]}}}}}"}
Kernel pid terminated (application_controller) ({application_start_failure,riak_core,{bad_return,{{riak_core_app,start,[normal,[]]},{'EXIT',{undef,[{cuttlefish_schema,files,[["/Users/alek/test_antidot
Crash dump is being written to: erl_crash.dump…done

On Oct 6, 2016, at 11:56, Christopher S. Meiklejohn<EMAIL_ADDRESS><EMAIL_ADDRESS>wrote:
Merged #220 https://github.com/SyncFree/antidote/pull/220.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub https://github.com/SyncFree/antidote/pull/220#event-814506907, or mute the thread https://github.com/notifications/unsubscribe-auth/ACdPQjQiM9aECzmMI3DQu7Dw-XRbMTOdks5qxMXVgaJpZM4KHX1M.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

On Oct 7, 2016, at 13:45, Annette Bieniusa<EMAIL_ADDRESS>wrote:
Which Erlang exactly are you using?

19.1 rev3 from ESL. The latest available.

I had problems with the one from ESL (was missing a Library), but can run tests with the one from Ericsson.

I have just tried uninstalling, installing 19 from ESL. Does not work.
I uninstalled that, installed 19 from macports, as suggested in http://www.erlang.org/downloads http://www.erlang.org/downloads.
Same problem.

Can u compile and run the systests?
Von meinem iPhone gesendet

Am 07.10.2016 um 13:40 schrieb Alejandro Zlatko Tomsic<EMAIL_ADDRESS>Using erlang 19.

On Oct 7, 2016, at 12:54, Alejandro Z. Tomsic<EMAIL_ADDRESS>wrote:
Problem: after the change, this happens when running antidote console:
[os_mon] cpu supervisor port (cpu_sup): Erlang has closed
{"Kernel pid terminated",application_controller,"{application_start_failure,riak_core,{bad_return,{{riak_core_app,start,[normal,[]]},{'EXIT',{undef,[{cuttlefish_schema,files,[["/Users/alek/test_antidote/antidote/_build/default/rel/antidote/lib/11-erlang_vm.schema","/Users/alek/test_antidote/antidote/_build/default/rel/antidote/lib/12-riak_core.schema","/Users/alek/test_antidote/antidote/_build/default/rel/antidote/lib/15-riak_sysmon.schema","/Users/alek/test_antidote/antidote/_build/default/rel/antidote/lib/21-leveldb.schema"]],[]},{clique_config,load_schema,1,[{file,"/Users/alek/test_antidote/antidote/_build/default/lib/clique/src/clique_config.erl"},{line,81}]},{riak_core_cli_registry,load_schema,0,[{file,"/Users/alek/test_antidote/antidote/_build/default/lib/riak_core/src/riak_core_cli_registry.erl"},{line,53}]},{riak_core_app,start,2,[{file,"/Users/alek/test_antidote/antidote/_build/default/lib/riak_core/src/riak_core_app.erl"},{line,104}]},{application_master,start_it_old,4,[{file,"application_master.erl"},{line,273}]}]}}}}}"}
Kernel pid terminated (application_controller) ({application_start_failure,riak_core,{bad_return,{{riak_core_app,start,[normal,[]]},{'EXIT',{undef,[{cuttlefish_schema,files,[["/Users/alek/test_antidot
Crash dump is being written to: erl_crash.dump…done

On Oct 6, 2016, at 11:56, Christopher S. Meiklejohn<EMAIL_ADDRESS><EMAIL_ADDRESS>wrote:
Merged #220 https://github.com/SyncFree/antidote/pull/220.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub https://github.com/SyncFree/antidote/pull/220#event-814506907, or mute the thread https://github.com/notifications/unsubscribe-auth/ACdPQjQiM9aECzmMI3DQu7Dw-XRbMTOdks5qxMXVgaJpZM4KHX1M.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub https://github.com/SyncFree/antidote/pull/220#issuecomment-252231248, or mute the thread https://github.com/notifications/unsubscribe-auth/ACdPQsyooHtjQTux1v3ds9oRn5Q_03sQks5qxjDPgaJpZM4KHX1M.

On Oct 7, 2016, at 14:09, Alejandro Z. Tomsic<EMAIL_ADDRESS>wrote:

On Oct 7, 2016, at 13:45, Annette Bieniusa<EMAIL_ADDRESS><EMAIL_ADDRESS>wrote:
Which Erlang exactly are you using?

19.1 rev3 from ESL. The latest available.

I had problems with the one from ESL (was missing a Library), but can run tests with the one from Ericsson.

I have just tried uninstalling, installing 19 from ESL. Does not work.
I uninstalled that, installed 19 from macports, as suggested in http://www.erlang.org/downloads http://www.erlang.org/downloads.
Same problem.

Can u compile and run the systests?

yes, can compile and all tests pass.

Von meinem iPhone gesendet

Am 07.10.2016 um 13:40 schrieb Alejandro Zlatko Tomsic<EMAIL_ADDRESS><EMAIL_ADDRESS>Using erlang 19.

On Oct 7, 2016, at 12:54, Alejandro Z. Tomsic<EMAIL_ADDRESS><EMAIL_ADDRESS>wrote:
Problem: after the change, this happens when running antidote console:
[os_mon] cpu supervisor port (cpu_sup): Erlang has closed
{"Kernel pid terminated",application_controller,"{application_start_failure,riak_core,{bad_return,{{riak_core_app,start,[normal,[]]},{'EXIT',{undef,[{cuttlefish_schema,files,[["/Users/alek/test_antidote/antidote/_build/default/rel/antidote/lib/11-erlang_vm.schema","/Users/alek/test_antidote/antidote/_build/default/rel/antidote/lib/12-riak_core.schema","/Users/alek/test_antidote/antidote/_build/default/rel/antidote/lib/15-riak_sysmon.schema","/Users/alek/test_antidote/antidote/_build/default/rel/antidote/lib/21-leveldb.schema"]],[]},{clique_config,load_schema,1,[{file,"/Users/alek/test_antidote/antidote/_build/default/lib/clique/src/clique_config.erl"},{line,81}]},{riak_core_cli_registry,load_schema,0,[{file,"/Users/alek/test_antidote/antidote/_build/default/lib/riak_core/src/riak_core_cli_registry.erl"},{line,53}]},{riak_core_app,start,2,[{file,"/Users/alek/test_antidote/antidote/_build/default/lib/riak_core/src/riak_core_app.erl"},{line,104}]},{application_master,start_it_old,4,[{file,"application_master.erl"},{line,273}]}]}}}}}"}
Kernel pid terminated (application_controller) ({application_start_failure,riak_core,{bad_return,{{riak_core_app,start,[normal,[]]},{'EXIT',{undef,[{cuttlefish_schema,files,[["/Users/alek/test_antidot
Crash dump is being written to: erl_crash.dump…done

On Oct 6, 2016, at 11:56, Christopher S. Meiklejohn<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>wrote:
Merged #220 <https://github.com/SyncFree/antidote/pull/220 https://github.com/SyncFree/antidote/pull/220>.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub <https://github.com/SyncFree/antidote/pull/220#event-814506907 https://github.com/SyncFree/antidote/pull/220#event-814506907>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACdPQjQiM9aECzmMI3DQu7Dw-XRbMTOdks5qxMXVgaJpZM4KHX1M https://github.com/notifications/unsubscribe-auth/ACdPQjQiM9aECzmMI3DQu7Dw-XRbMTOdks5qxMXVgaJpZM4KHX1M>.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub https://github.com/SyncFree/antidote/pull/220#issuecomment-252231248, or mute the thread https://github.com/notifications/unsubscribe-auth/ACdPQsyooHtjQTux1v3ds9oRn5Q_03sQks5qxjDPgaJpZM4KHX1M.

I am also getting similar error when starting antidote rel. Tests are
running fine.
I have erlang 19.1 from erlang.org.
There was a similar issue when moved to rebar3. These applications had to
be explicitly added to app.src for them to be loaded.
On Fri, Oct 7, 2016 at 4:44 PM, Alejandro Zlatko Tomsic <
<EMAIL_ADDRESS>wrote:

On Oct 7, 2016, at 14:09, Alejandro Z. Tomsic<EMAIL_ADDRESS>wrote:

On Oct 7, 2016, at 13:45, Annette Bieniusa<EMAIL_ADDRESS><EMAIL_ADDRESS>wrote:
Which Erlang exactly are you using?

19.1 rev3 from ESL. The latest available.

I had problems with the one from ESL (was missing a Library), but can
run tests with the one from Ericsson.

I have just tried uninstalling, installing 19 from ESL. Does not work.
I uninstalled that, installed 19 from macports, as suggested in
http://www.erlang.org/downloads http://www.erlang.org/downloads.
Same problem.

Can u compile and run the systests?

yes, can compile and all tests pass.

Von meinem iPhone gesendet

Am 07.10.2016 um 13:40 schrieb Alejandro Zlatko Tomsic <
<EMAIL_ADDRESS><EMAIL_ADDRESS>Using erlang 19.

On Oct 7, 2016, at 12:54, Alejandro Z. Tomsic<EMAIL_ADDRESS><EMAIL_ADDRESS>wrote:
Problem: after the change, this happens when running antidote
console:
[os_mon] cpu supervisor port (cpu_sup): Erlang has closed
{"Kernel pid terminated",application_controller,"{application_
start_failure,riak_core,{bad_return,{{riak_core_app,start,[
normal,[]]},{'EXIT',{undef,[{cuttlefish_schema,files,[["/
Users/alek/test_antidote/antidote/build/default/rel/
antidote/lib/11-erlang_vm.schema","/Users/alek/test
antidote/antidote/build/default/rel/antidote/lib/12-
riak_core.schema","/Users/alek/test_antidote/antidote/
build/default/rel/antidote/lib/15-riak_sysmon.schema","
/Users/alek/test_antidote/antidote/build/default/rel/
antidote/lib/21-leveldb.schema"]],[]},{clique_config,
load_schema,1,[{file,"/Users/alek/test_antidote/antidote/
build/default/lib/clique/src/clique_config.erl"},{line,81}
]},{riak_core_cli_registry,load_schema,0,[{file,"/Users/
alek/test_antidote/antidote/build/default/lib/riak_core/
src/riak_core_cli_registry.erl"},{line,53}]},{riak_core
app,start,2,[{file,"/Users/alek/test_antidote/antidote/_
build/default/lib/riak_core/src/riak_core_app.erl"},{
line,104}]},{application_master,start_it_old,4,[{file,
"application_master.erl"},{line,273}]}]}}}}}"}
Kernel pid terminated (application_controller)
({application_start_failure,riak_core,{bad_return,{{riak_
core_app,start,[normal,[]]},{'EXIT',{undef,[{cuttlefish_
schema,files,[["/Users/alek/test_antidot
Crash dump is being written to: erl_crash.dump…done

On Oct 6, 2016, at 11:56, Christopher S. Meiklejohn <
<EMAIL_ADDRESS><EMAIL_ADDRESS><mailto:
<EMAIL_ADDRESS><EMAIL_ADDRESS>wrote:
Merged #220 <https://github.com/SyncFree/antidote/pull/220 <
https://github.com/SyncFree/antidote/pull/220>>.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub <
https://github.com/SyncFree/antidote/pull/220#event-814506907 <
https://github.com/SyncFree/antidote/pull/220#event-814506907>>, or mute
the thread <https://github.com/notifications/unsubscribe-
auth/ACdPQjQiM9aECzmMI3DQu7Dw-XRbMTOdks5qxMXVgaJpZM4KHX1M <
https://github.com/notifications/unsubscribe-
auth/ACdPQjQiM9aECzmMI3DQu7Dw-XRbMTOdks5qxMXVgaJpZM4KHX1M>>.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub <
https://github.com/SyncFree/antidote/pull/220#issuecomment-252231248>, or
mute the thread <https://github.com/notifications/unsubscribe-auth/
ACdPQsyooHtjQTux1v3ds9oRn5Q_03sQks5qxjDPgaJpZM4KHX1M>.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/SyncFree/antidote/pull/220#issuecomment-252271522,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AB56pqK-tplHKOdHD2tWDs4WHVzXmA76ks5qxlrrgaJpZM4KHX1M
.

If it is a problem with the started application, we should maybe revert my commit here: https://github.com/SyncFree/antidote/pull/220/commits/944c7ff83dbad8167c8add55600ffd6877050c65
Could we extend the system tests to detect problems like this?

Actually, we fixed it in so far that we can get a console running by using the release:
./_build/default/rel/antidote/bin/antidote console
However, running „rebar3 shell“ does not work, even though the documentation says that it uses a release if there is one.


Access factories from request handlers

Is it currently possible to access factories from the request handler functions? I know that I can call db.pets.insert({...}), but unfortunately that isn't using the related factory. I've defined quite a few faker methods in the factory and I would like to reuse that structure from the request handler.

@samselikoff any ideas on that?

Right now it's not possible. People have kind of hacked it by importing the factory file directly, but that's not part of the public API.
I think eventually we'll need to support default values on the model layer, since this is really what you're getting at.

@samselikoff thanks for the feedback. what exactly is keeping us from adding something like server.create('user', data) on the DB itself? (e.g. db.users.create(data))

You actually can, as this in a route handler is server. So you can do that via this.create('user', data). But this is not public, and factories are really meant to seed the db with fake/contrived data, not default values.
For example, what if you wanted a default value of today for a date, but then in tests wanted to override that? That's why we need both default values and factory values. We just don't have an API for the former yet.

Closing due to inactivity.


x/website: The StderrPipe example refers to "io.ReadAll"

https://golang.org/pkg/os/exec/#Cmd.StderrPipe
The StderrPipe example has an error in it. It refers to "io.ReadAll" and it should be "ioutil.ReadAll" from io/ioutil package.

io.ReadAll was added in Go 1.16 and replaced ioutil with the ioutil being deprecated.
https://golang.org/pkg/io/ioutil/#ReadAll

As of Go 1.16, the same functionality is now provided by package io or package os, and those implementations should be preferred in new code. See the specific function documentation for details.

See https://golang.org/doc/go1.16#ioutil

Working as intended.

Ah, fair enough. I'll get my coat!


Any examples of multiple cameras capturing depth information?

I used two cameras to collect RGB and depth information in Omnibizon. I set the camera position and orientation using cam_1. set_position orientation (cam_1-position, quat1), but I found that when the two cameras were using their own set positions and quaternion poses for coordinate conversion, the point clouds could not align. Can anyone give me any suggestions for checking? In addition, after setting it up, I also checked the settings using cam_1. get_position _orientation (), and the obtained parameters were consistent with the set parameters. Is the coordinate system of the camera in Omnibizon equivalent to the depth acquisition reference plane?

I am using OmniGibson v1.1.1


Set the resync period to 10 hours

What this PR does / why we need it:
This is a version of https://github.com/jetstack/cert-manager/pull/3398 that sets the resync period to 10 hours without making it configurable as there is not much use into having it as a flag.
Release note:

Set the resync periods of informers to 10 hours instead of 30 seconds

@wallrj addressed here to prevent yet another PR
/kind bug

@meyskens Hi there 👋 , we noticed in Cluster API that after this change got in some of the objects aren't reconciled properly anymore, we noticed a similar bug as in https://github.com/jetstack/cert-manager/issues/3501. Would you be ok if we provide a PR to make it configurable?

Hi! #3501 seems to contain many issues which all have in common the error message (in cert-manager 1.3):
E0419 controller.go:158] msg="re-queuing item due to error processing" error="Operation
cannot be fulfilled on cert-tls: the object has been modified; please apply your changes
to the latest version and try again"

99.9% of the time, this message does not actually relate to the issue; unfortunately, the message does not make clear that this is a benign message (and not an error). Unfortunately, the message is unclear and people may think it is a symptom of their issue.
In 1.4, we changed the message a bit to clarify that. The level was changed from "error" to "info" and the message was reworded:
I0419 controller.go:158] msg="re-queuing item due to optimistic locking on resource"
error="Operation cannot be fulfilled on cert-tls: the object has been modified; please
apply your changes to the latest version and try again"

It seems like the message still looks like something "failed". I will look into ways of making this log line more understandable.

We noticed in Cluster API that after this change got in some of the objects aren't reconciled properly anymore.

That might be an actual bug (e.g., we forgot to set up a re-queuing on some object). We should investigate this issue, is there an issue on the cluster-api repository that may help?

Hi @meyskens @maelvls, thank you for the detailed clarification. For Cluster API, we actually tracked a bug on our side where the cluster we were working on had an older version of cert-manager installed (v0.16). This should be solved on our side, if we do see more of this reconciliation error I'll make sure to open a different issue.
Thanks for your help folks 🤗, the above helped track down the issue on our side!

FWIW, https://github.com/jetstack/cert-manager/pull/3919 also brought up the idea of a --resync flag (not sure why it was closed).


Add an example that demonstrates event-sourcing

I suppose, it makes sense to implement the event sourcing for the delivery service

Done


Rework the minimap button

it ugly

Just remove this thing. Its breaking other UI elements.

nope, don't remove this. Users want a minimap button.


Project Server 2016 database

Hi,
thanks to remove this line "Project Server 2016 database" at this step because there is no more Project Server DB in SP 2016 but only a Project Content DB.

@Memoi Thank you for submitting feedback. We are currently investigating this.

@officedocsbot assign @scanum

Thanks so much for the suggested update!


Delete FluentCMS.Shared project: is hould not be shared with UI

Shared project should be shared between API server related projects. Dependency to UI should be removed


Add integration tests with PostgreSQL DB backend

Feature Request / Improvement
PostgreSQL is a formally recognized DB backend for the SQLCatalog, but we do not have any integration tests that make use of a postgresql connection string.
Although the catalog methods are tested against sqlite, I think it is important to test all of the methods against PostgreSQL to ensure that the SQL operations are compatible with the PostgreSQL dialect.

Hi @sungwy I am interested in this, would adding IT with python test-containers for postgres suffice for this issue.

Hi @akashd11 - yes I think that would be great. I think putting up a test container with postgres and parameterizing the tests in tests/catalog/test_sql.py will be a good way to introduce this


Provide the "Status" detail on the Details Accordion

The full "policy" object (legislative artifact) may have a status value on it. If so, we should display the status.
<AccordionItem title="Status">   // new code here </AccordionItem>
Initially I think there was an expectation that statusHistory would be provided but it doesn't seem to be supported by the data model.

Alright then


support as a static framework

My project use new feature of cocoapod 1.5, static framework . So the framework assets becomes as one part of main application.
when using as a static framework,  assets will load failed.  I will collect more detail soon.

Ok. I am closing this issue, then.


Infinite chat history

Is your feature request related to a problem? Please describe.
I can't view old chat messages.
Describe the solution you'd like
Infinite chat history
Additional context (optional)
This would use up a lot of memory doing it the naive way, so I think it would be better (and cool and fun) to implement a virtual list for this.

Possible reference implementation: https://dev.to/adamklein/build-your-own-virtual-scroll-part-i-11ib

Closed by #117

I suppose the solution wasn't "infinite".


feat(0.17): version 0.17.1

Update to version 0.17.1

Thank you! Landed on https://github.com/ruimarinho/docker-bitcoin-core/commit/ef575b93dc246db707bb6ece9259a66c954a690f. Give it 15-20mins for the tags to be published.

Thanks for pushing the update to DockerHub @ruimarinho !
However, there is an issue. These are the three images updated today:

0.16
0.17-alpine
0.17

0.17-alpine is running v<IP_ADDRESS>-gef70f9b52b851c7997a9f1a0834714e3eebc1fd8 (release build) as expected but 0.17 is running Bitcoin Core version v0.17.0 (release build) (and I haven't tried 0.16).
latest has not been updated, nor is there a 0.17.1 tag.
However, I am able to get v0.17.1 by running 0.17-alpine, so thank you very much!
James

Docker Hub takes a long time to build from source. I just pushed the tags for 0.17.1, so those specific variants should be up in some hours.
latest, 0.17 and 0.17-alpine should be pointing to 0.17.1 now.


Please add the --kubeconfig arg to the helm chart (kube-webhook-certgen) so we can point to external cluster

Seems the the kube-webhook-certgen image supports the --kubeconfig arg but it is not possible to add it in the helm chart?
https://github.com/kubevela/kubevela/blob/c255d21ad63c879d50e3029fb72b679fe236275b/charts/vela-core/templates/cluster-gateway/job-patch.yaml#LL85C13-L85C13

By default, we use the in-cluster kubeconfig for the kube-webhook-certgen. Is there any problem with the default kubeconfig?

Hi, it would be nice to set the kubeconfig for use cases where we need to reference an external kubernetes. Eg you could be running certgen outside the cluster. certgen already supports the flag

I see. So it is like adding a "cert-gen-kubeconfig" parameter to the helm chart and place it in the program arguments for the cert-gen job?

I see. So it is like adding a "cert-gen-kubeconfig" parameter to the helm chart and place it in the program arguments for the cert-gen job?

Yes please 🙏🏿

I would love to work on this issue , Could you please assign this issue to me?

Hi @yashvardhanmishra, I'm glad that you want to contribute to this issue. I will assign it to you.


unable to see internal MySQL/MariaDB schema "mysql"

System information:

Operating system (distribution) and version: MacOS 10.14.6
DBeaver version: <IP_ADDRESS>002151353
Additional extensions: JDBC

Connection specification:

Database name and version: MariaDB 10.3
Driver name: JDBC
Do you use tunnels or proxies (SSH, SOCKS, etc)? SSH

Describe the problem you're observing:
MariaDB has several "internal" schema it uses for itself; "performance_schema" and "mysql". performance schema is visible in navigator panel "databases" folder element, but "mysql" is not.
I've looked in preferences for "view internal schema", as well as any connection-related settings, or driver related settings that would be responsible for it, but have found none.

Go to connection properties (f4), tab "General", turn on "Show system objects".

Seems like there is still an issue displaying "information_schema" database tables. The "tables" icon in the DB navigator has a '>' to the left indicating there are tables, but when I click on it, they are not displayed in the navigator.
Additionally, going into "edit connection", and clicking on tables shows a blank grid, i.e. that there are no tables.
The tables are clearly there, so not sure why they aren't displaying

@rotorboy , there are no Tables in Information_schema, only views. You could see them in Views folder


Polymer paper / material design theme

Anyone working on a Polymer paper / Google Material design custom theme template for autoform? It looks quite cool:
https://www.polymer-project.org/components/paper-elements/demo.html

Yeah, autoform + polymer would be killer feature for me. Do you have plan to do in natively as a part of autoform or just waiting until someone from community will do that?

A polymer pkg would be an add-on community pkg. I had been investigating more of a low-level support for web components in general (unify autoform input type definitions with web component spec), but for now it seems more complex than useful.

Closing. See #438

Not quite Polymer Paper, but Bootswatch has released a Paper theme.


Provider App v1.1

Copied comment: Propose a specific path forward for the provider app development and enhancements, possibilities include:
a) Retain current Swagger API with app server performing the bulk of value set logic, but replaces app server with a cqf-ruler and HAPI server to execution CQL libraries to process patient data, using same CQL libraries as patient/caregiver app.
b) Remove application server. Execute CQL value set logic within the JavaScript app.
c) Other?
Retain the current app UI design using common Typescript interface structures with the patient app and CQL logic outputs.


Artist list is too long, it moves some buttons out of window

Describe the bug

This song has long artist list. If you play it, you see some buttons on right side moving out of window, overlap buttons on left side.
Display scaling size: 125%
Display resolution: 1920 x 1080
Display size: 15 inches
To Reproduce
Steps to reproduce the behavior:

Play this song
If you don't see bug, change display scaling size

Screenshots

Window mode:

Maximize mode:

Desktop Setup

OS: Windows v10.0.19044
Spotify: v<IP_ADDRESS>4
Spicetify: v2.9.4
Dribbblish: v4.1.4-239033a

Logs

[paste logs here]

The bug is fixed after upgraded

Spotify: v<IP_ADDRESS>6
Spicetify: v2.9.6


rosetta: add option to ignore rosetta failure when installation cancelled

This adds a ignore-if-missing option that allows vfkit to not fail if the rosetta installation is cancelled by the user.
So far, if the rosetta installation was cancelled vfkit exited with an error. This behavior still exists if ignore-if-missing option is not set.
it fixes #160

Forgot to update the documentation, updating it

/approve
/lgtm


Publish core dumps from Linux and MacOS builds

I currently have a branch here that specifically does this for Mac builds. This will assist an investigation into a uamqp segfault that is occurring in the servicebus livetests.
This is the second such ask since december. Time to just add these to the pipelines.

Provided Yijun and Adam with a build that can get them a core dump. Moving back to backlog as there are higher priorities right now.

Closing, we'll see if really needed


chore: generalize layercake formulas to null-measurable and a.e.-nonnegative functions

The layercake formulas (a typical example of which is ∫⁻ f^p ∂μ = p * ∫⁻ t in 0..∞, t^(p-1) * μ {ω | f(ω) > t}) had been originally proven assuming measurability and nonnegativity of f. This PR generalizes them to null-measurable and a.e.-nonnegative f.

bors r+


WIP: Coolprop

Closes #2125.

Unfortunately I cannot continue because coolprop uses a msgpack implementation that is two year old.

Blocked by coolprop/coolprop#1586.

Thanks, looks solid!
Also, thanks for the fix regarding Coolprop & msgpack. : )


Ignore start and end tags for

Ignore , which seems to be present in some Overpass API results.

Sorry, pull request seems to include commits I didn't mean it to!

Coverage decreased (-1.4%) to 92.893% when pulling 7fc29269a1feb729699a65d86822c611ab221ddd on gregrs-uk:ignore-remark into b6e2cb16dd0f6c6a0932aeb241a7e1309f2e4250 on DinoTools:master.


some obs do not have a default, this may lead to failure when running the driver

example: sftlf (but that is normal) or rtnetcre
thanks @zshaheen for noticing this

@doutriaux1 @zshaheen The only additional variable that we use (so far), rtnetcre, has been added.   There is a pull request to implement.   When one of you has pushed to master I'll remove this issue... which will likely resurface from time to time as additional fields are added to our database


Implement IBApiNext

IBApiNext will be an second, more modern way of using IB API, in parallel (actually on top) of current IBApi interface.
Development will happen on https://github.com/stoqey/ib/tree/api-next
Design goal:

Provide support for automatic re-connection, including a watchdog that regularly checks the connection (not relying on socket termination events). A preview of this is available on https://github.com/stoqey/ib/blob/api-next/src/api/api-auto-connection.ts
The IBApiAutoConnection object does host an IBApi (use IBApiAutoConnection.api to access it), handles connect / disconnect / error events and provides connect & disconnect functions. It implements a connection-state watchdog and re-connect timer.
Provide rxjs wrappers for all req/cancel methods and introduce better TS compatibility (i.e. return undefined instead of MAX_VALUE).
This has been started on https://github.com/stoqey/ib/blob/api-next/src/api/api-next.ts
Basic design pattern:  a function must return an rxjs Observable that first delivers any cached values and than notifies about changes.

@Tsopic feel free to comment or continue to work on it (I will spend more time on that over the weekend, so by next week we should have most the of read-only methods as rxjs) ;)

Have pushed an update.
We have a first demo for IBApiNext: an inventory logger that keeps track of all kind of values on your IB accounts and logs it to console at certain intervals.
You can find it here https://github.com/stoqey/ib/tree/api-next/src/demo/inventory-logger
Status on the IBApiNext:
Think we have a design pattern now for all kind of functions.

Request with one-time return.
Should only be reqCurrentTime. This is getCurrentTime() now and returns a Promise
Request with full result on the event
See getPnL() or getPnLSingle().
Straight forward - do reqPnL on requestFunction, cancelPnL on cancelFunction, on event callback deliver the result into the subject, on cleanupFunction do cleanup.
Request with partial result on the event
See getAccountSummary().
On this type we get the the result piece-by-piece and want to cache into a full set.
To do this, first get the currently cache values from subject (subject.cached()), than update it and write it back (subject.cache()). When delivering the update to the subject, pass false as second argument on the subject.next(). This will tell that you want to manage the cache on your own and the (partial) update on the subjet.next() shall not overwrite it.
Request with that delivers a list via *End event.
See getPositions()
On this type we get a list of items. End of the list is signaled by an end event.
It quite similar to the "Request with partial result on the event" however update logic on the cache is different. You want to collect items until the end event, than write it to cache and than update cache as new items come on.

getMarketData() already is a kind of special thing. It does register for multiple events and outputs a whole bunch of new market data types from it.
I will add new functions as I need (so might take some time until he have getOrders() :P) - so feel free to give it a try if a new function ;)

A preview version of IBApiNext is available on master now.

Closing this, preview version is live since some time already - overhaul coming in soon, will move to "beto" status afterwards


feat RAtomicLong realization DECRBY with #decrementAndGet(long delta)

RAtomicLong add decrementAndGet(long delta) realization DECRBY

You need to reopen it if you consider this contribution to be merged


Warnings on External Links

People can add External Links to their JSON Schemas. Should I throw up a warning or some kind of indicator that they will leave the current site? Ask security minded people what they think.

I don't think that this is required anymore. After the security review this seems fine.

I don't think that this is required anymore. After the security review this seems fine.


httr for explicit 'nothing is returned' check.

This adds httr for explicitly warning the user if nothing is returned by the API. Silent failure is not a very good thing.

Hey, you are definitely right, silent failure is not a good option. I always thought of solving this with the APIs heartbeat method, but your solution is more reliable. Thank you for contributing to FirebrowseR.


Changed package versions to beta2

@pranavkm @yishaigalatzer
Just FYI...the Xunit packages are not available on public Nuget feed and we are figuring out if we need to create a separate feed for external packages, but other than that please take a look at the changes to other packages.

Hi @kichalla, I'm your friendly neighborhood Microsoft Open Technologies, Inc. Pull Request Bot (You can call me MSOTBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla2.msopentech.com.

TTYL, MSOTBOT;

In correct target branch..will create a new PR


No docstrings on ModelingCmd enum variants

Problem
The enum variants of enums like ModelingCmd don't have docs! See https://docs.rs/kittycad/latest/kittycad/types/enum.ModelingCmd.html
The docs are in the spec.json so this is an openapitor problem.

fixed this


Implement GraphQL queries and navigation for other pages

As a user, I can navigate directly to a user's profile page with their thoughts and friends list

As a user, I can navigate directly to a single thought's page to view reactions to that thought

The profile page and single thought's page have been fully implemented.


Raw pointer member variables of tflite::Interpreter are not initialized or released properly.

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): No
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Linux Ubuntu 16.04
TensorFlow installed from (source or binary): source
TensorFlow version (use command below): 1.8.0
Python version: 3.6.4
Bazel version (if compiling from source): 0.13.1
GCC/Compiler version (if compiling from source): gcc version 5.4.0 20160609 (Ubuntu 5.4.0-6ubuntu1~16.04.9)
CUDA/cuDNN version: 9/7
GPU model and memory: K80
Exact command to reproduce:

bazel build -c opt --copt="-D TFLITE_PROFILING_ENABLED" tensorflow/contrib/lite/tools:benchmark_model
./bazel-bin/tensorflow/contrib/lite/tools/benchmark_model --graph=model.tflite

output:
Graph: [model.tflite]
Num runs: [50]
Inter-run delay (seconds): [-1.0]
Num threads: [1]
Warmup runs: [1]
Use nnapi : [0]
Initialized session in 0.002312s
Running benchmark for 1 ddditerations:
Segmentation fault (core dumped)

There are two raw pointer member variables within tflite::Interpreter.

profiling::Profiler* profiler_ is not initialized.
It may cause segmentation fault if profiler_ is initialized with a nonzero value and users don't set it by tflite::Interpreter::SetProfiler.

ErrorReporter* error_reporter_
The default error reporter pointed by error_reporter_ will not be released.

Nagging Assignees @petewarden, @aselle, @andrehentz: It has been 14 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignees @petewarden, @aselle, @andrehentz: It has been 29 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignees @petewarden, @aselle, @andrehentz: It has been 44 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

The raw pointer member variables are not owned by the Interpreter, but good point about the the profiler_ pointer, I am going to send a patch.


Install Go as we need it for the post cherry-pick commands

The current GitStream config runs two go commands after each cherry-pick: https://github.com/rh-ecosystem-edge/kernel-module-management/blob/main/.github/gitstream.yml#L16-L17
Setup Go in the GitStream CI workflow to be able to run those commands.

/lgtm


[Enhancement] Add more test coverage for ConsumerManageProcessor

Before Creating the Enhancement Request

[X] I have confirmed that this should be classified as an enhancement rather than a bug/feature.

Summary
Add more test coverage for ConsumerManageProcessor
Motivation
add more tests
Describe the Solution You'd Like
add more tests
Describe Alternatives You've Considered
no
Additional Context
No response

link #8262


Improved Search

Hello, first off I want to say thanks for contributing to this project. I stumbled upon it after sharing a similar sentiment with Redoc's lack of support for a true 'Try' the API feature. I found you commenting on one of those issues, so I imagine this was the catalyst that brought you to making this.
This library is a true gem - I think it's very straightforward and easy to use. I know one of the main draws for me to Redoc was not only it's good-looking interface but the fact that you could import it directly as a React component. This is a completely separate thought, but FWIW I think you could see a wider adoption rate (especially these days) by sprinkling in explicit documentation on how to do this (maybe even offer a little React wrapper ala Redoc). It's obviously very simple to integrate this as a web component, but it might not hurt to spell it out for people. I know that I personally had never integrated a third-party web component into any of my React projects until stumbling across this.
OK - to the original thought - what do you think about expanding the search capabilities? My thoughts are not only searching "on type", or bringing the "plucked" links to the top (like Redoc), but perhaps integrating a little more "smarts" as well - maybe using something like lunr.js or down the road offering something like Algolia support. This feature, while not absolutely imperative to my needs, is one of those compare / contrasts that's hard to pass up.

Redoc's lack of Try feature is surely one of the reason but isnt the only one,
There are plenty of other reasons ranging from usability, look-n-feel, feature-set that did not align well with our vision of API documentation.
couple of primary reasons to create RapiDoc is

ReDoc and Swagger UI both are React component so the developer experience to integrate these with other libraries is not so great
A big chunk RapiDoc's user base deals with micro services, so they have smaller but many API specs. For documentation purpose they like to show it as one integrated document.

for example check this https://www.northbricks.io/apis/ it has about 4 or 5 open-api specs tucked into one integrated view (view-page-source on the site to see how its done)
that aside
RapiDoc has a fairly large internal user-base and many of our roadmap features are driven by them. We did various ux-survey in the past. w.r.t search what we found was most people relied on browser search than RapiDoc's own search.

Its easy to invoke and use cmd/ctrl-F
Better performs because its native
Natively supports jumping for one search item to another

We did experimented with full site searches, it is fine with small to medium sized specs, but some of the larger specs it wasnt as snappy as we would like it to be. The browser's native search was performing better. (also on our end we like to keep RapiDoc package size small).
you might ask why would RapiDoc even have a search then? well, thats coz, it behaves more like a filter by hiding other stuff and gives a focused view, rather than highlighting.
Many developers likes to make the documentation look smaller by pre-filtering it as per their area of interest and then navigate around it or use browser search to find stuff
But if you can provide me with some interesting reason why would you like to have a full text search within rapidoc and not use browser's native search, I will take it further

Thank you for the detailed explanation! I can clearly see now the benefits of filtering. It wasn't as intuitive with how my spec was laid out (I was searching for unique targets), not to mention I was in 'read' - and I think the functionality really shines in 'view' mode.
As semantical as it may seem, it might make sense to consider replacing the placeholder on the input with something like "filter" - however, I understand how the word "search" is much more universal. I agree that cmd/ctrl-f is much better suited for exact text matching- the only drawback I see to not having a full text search in the search box would be for user engagement. I see now it's intended function, but my initial gut reaction was that "the search was broken / not that good". This is could have unintended consequences for user's misjudging the validity of the UI (and in turn, the documented API itself). This is very much an off-the-cuff opinion, of course - it's just my personal conditioning that when I see a 'search box' I tend to expect ingenious, on-the-fly reporting of specific, typo-be-damned results (thanks Google).
I will close because you definitely addressed the thought process behind all of this. Thanks again!


Load config from a file (e.g. ~/.config/foundry or ~/.foundry/config.json)

Currently, we don't use an external config for foundry. To make configurations persist across invocations, we need a flat file. Please add ~/.config/foundry or ~/.foundry/config.json.

This has been implemented in 3.0.0.


Problem running on older GPUs

I can run the Theano benchmark on K80 using Cuda 8.0 and Python/2.7.12 but when I try to run it on older GPUs (K20 or M2090) using cuda 7.5 and python 2.7.9 the program gets killed:
$ SKIP=legacy python pylearn2_benchmark.py
Using gpu device 0: Tesla M2090 (CNMeM is disabled, cuDNN not available)
Note: cuDNN not available

CONFIG: input = 3 x 128 x 128 * ker = 3 x 96 x 11 x 11 ( bs = 128 , stride = 1 )
Killed

Any idea why this is happening?

Doing benchmark without cudnn isn't useful. Can you install it? It could
also fix your problem.
If not, I have the impression that it get killed by the OS. Are you testing
it on a cluster? Did you request enough CPU memory? If not, many job
scheduler could kill your job with that message.
Le 6 déc. 2016 21:37, "hpourreza"<EMAIL_ADDRESS>a écrit :
I can run the Theano benchmark on K80 using Cuda 8.0 and Python/2.7.12 but
when I try to run it on older GPUs (K20 or M2090) using cuda 7.5 and python
2.7.9 the program gets killed:
$ SKIP=legacy python pylearn2_benchmark.py
Using gpu device 0: Tesla M2090 (CNMeM is disabled, cuDNN not available)
Note: cuDNN not available
CONFIG: input = 3 x 128 x 128 * ker = 3 x 96 x 11 x 11 ( bs = 128 , stride = 1 )
Killed
Any idea why this is happening?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/soumith/convnet-benchmarks/issues/119, or mute the
thread
https://github.com/notifications/unsubscribe-auth/AALC-05uwS7fA_VL8lXj-4xWxTYvZ-knks5rFceXgaJpZM4LF2gW
.

Thanks @nouiz. I was asking for 2GB of memory but apparently it was not enough. I increased it and the code started running.
I can see libcudnn.so.x files within the CUDA installation but for some reason dnn_available() returns False.


Sequence edit form does not show onError sequences properly

Description:
https://github.com/user-attachments/assets/47226775-df60-4c59-946d-205a5b978868
Describe your problem(s)
The form does not display in full page, so when a dropdown has more than three values, the last values are not visible. The user needs to scroll the form to see the last values.
Describe your solution(s)
Related Issues (optional):

Suggested Labels (optional):

Suggested Assignees (optional):

The latest pre-release v1.1.0 has resolved the issue. Please reopen if the problem persists.


Prettier + Style updates

@Levino I added a prettier command to my webstorm. I thought that I already had it set up to Prettier on save, but either way it should be good going forward.
Also, I disagree about one of your comments (making things useful vs making it look nice). It should be both. Users will defintiely change the colors anyway, you're right, but design is important, IMO. Luckily there shouldn't be many design changes needed in future.
Re: CircleCI. I'm not familiar with configuring CircleCI, can you tell me what that failure is because of?


[example] should not render with outer border

Examples should be shown just like a note:

... The examples in ISO/IEC DIR 2 were all boxed. And this isn't just like a Note: it's hanging indent. (Unless notes are hanging indents as well?)
ISO/IEC DIR 2 does not actually say much about formatting -- and neither does the presupplied format. Will action these, but would be more comfortable if there was in fact an explicit format spec.

Yes I know — DIR 2 has them boxed. But DIR 1 has them open. So weird.

Or I thought, DIR 2 examples are actually boxed figures with an example inside.

I defer to your example from ISO 690. Fixed in isodoc.


fix: Moved gitSyncId from BranchAwareDomain to BaseDomain

Description
Moved gitSyncId from BranchAwareDomain to BaseDomain because it's changing property order in the git files.
Fixes #22282
Media

A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video

Type of change

Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Chore (housekeeping or task changes that don't impact user perception)
This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions, so we can reproduce.
Please also list any relevant details for your test configuration.
Delete anything that is not important

Manual
Jest
Cypress

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:
Dev activity

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] PR is being merged under a feature flag

QA activity:

[ ] Test plan has been approved by relevant developers
[ ] Test plan has been peer reviewed by QA
[ ] Cypress test cases have been added and approved by either SDET or manual QA
[ ] Organized project review call with relevant stakeholders after Round 1/2 of QA
[ ] Added Test Plan Approved label after reveiwing all Cypress test

/ok-to-test sha=e41c44623d5eb6fd8109367f86ea218e759946b6

@nayan-rafiq On importing apps, I am seeing n pages modified in change log with these commits, is this expected?
https://user-images.githubusercontent.com/80334441/231470796-f94e7f18-8c84-48ce-aa27-ee606b2d253c.mov

/build-deploy-preview

/ok-to-test sha=01d53e8d81a955b5161ddb0e0dceb9bdfa82ff87


terraform-providers.postgresql: 1.6.0 -> 1.7.1

Motivation for this change
Package update!
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 104771 1

3 packages built:

terraform-full
terraform-providers.postgresql
terraform_0_11-full


[DOC] How to implement many-to-many relationships (Supabase)

Documentation issue
I'm using supabase and I can't find somewhere in the docs talking about many-to-many relationships.
Describe the thing to improve
How to implement many-to-many relationships in refine ?
Same as the example from the doc, where a post is linked to a category, but this is a one-to-many relationship, I need a many-to-many relationship, so a post linked to many categories.
I would also need to know how to filter by posts by categories in a many-to-many relationship.
Describe the solution (optional)
No response

Hey @MetaCorp, thank you for the issue! We have this section(handling-many-to-many-relationships) in our Supabase docs. This is kind of overlooked because we don't explain the tables and their structures well and !inner might not be required, let me try to explain it here and we will also update the docs soon.
movies table: id(primary), title
categories table: id(primary), name
categories_movies table: category_id(primary), movie_id(primary) (a compose primary key with both of the columns)
Let's have some sample data like;
movies
| id | title           |
|----|-----------------|
| 1  | the green mile  |
|----|-----------------|

categories
| id | name           |
|----|----------------|
| 1  | drama          |
| 2  | mystery        |
|----|----------------|

categories_movies
| category_id | movie_id |
|-------------|----------|
| 1           | 1        |
| 2           | 1        |
|-------------|----------|

In our useTable(or similar), we need to add metaData.select like;
useTable({
  metaData: {
    select: "*, categories(name)",
  }
});

Since we have the relations defined in categories_movies table with composite primary key, we will be able to retrieve the data in our response with categories field as an array of values (categories: [{ name: "drama" }, { name: "mystery" }])
You can check out the Supabase's example here https://supabase.com/docs/reference/javascript/select at "Query foreign tables through a join table" tab.
note: Defining a composite primary key with both category_id and post_id is required for this select expression to work.

We'll update the documentation to show this usage and update the example to have a many-to-many field

Thank you, I'm able to retrieve data from supabase this way.
I want to add post with categories from the post/create.tsx page.
I'm using mui and right now, I'm testing with this component :
<Controller
      control={control}
      name="categories"
      // rules={{ required: "Category is required" }}
      render={({ field }) => (
          <Autocomplete
              {...autocompleteProps}
              {...field}
              multiple
              onChange={(_, value) => {
                  field.onChange(value);
              }}
              getOptionLabel={(item) => {
                  return item.title ? item.title : "";
              }}
              isOptionEqualToValue={(option, value) =>
                  value === undefined || option.id === value.id
              }
              renderInput={(params) => (
                  <TextField
                      {...params}
                      label="Categories"
                      margin="normal"
                      variant="outlined"
                      error={!!errors.categories}
                      helperText={errors.categories?.message}
                      required
                  />
              )}
          />
      )}
/>

But I have this error : column "categories" of relation "posts" does not exist.
I understand that I have no categories field for post in supabase, but how to tell refine the relationship when creating data from the post/create.tsx page ?

Hey @MetaCorp, you can check out this doc https://refine.dev/docs/packages/documentation/react-hook-form/useForm/#how-can-i-change-the-form-data-before-submitting-it-to-the-api
Supabase throws an error because it can't find categories column in the posts table, since there is really no such column, you need to remove that field before submitting the form and send create requests to the posts_categories table using useCreate(or useCreateMany for your case) separately.
Closing this issue for now, if you have any trouble while using useCreate or useCreateMany please reach out! 🚀

Hey again @aliemir,
I'm trying to implement filtering by categories in this many-to-many relationship. How can I do so with Refine ? What would be the field of the filter ?

@MetaCorp did you ever get this working?

Hi @rawkode, I asking you the same question :) did you ever get this working? Because right now I'm also in the same spot

Unfortunately not, I tried getting help here and on Discord; but no success.
Good luck!

@rawkode, I just found a workaround for this issue. I have attached the code which essentially explains the solution itself. It appears that with many-to-many relationships, we need to add !inner inside the select statement. I created a state with a default value and used useEffect to change the select value when the filter value changes. Here’s the revised code:
const [selectValue, setSelectValue] = React.useState<string>(
    "*, phone_numbers(*), tags(id, name)"
  );
 const { tableProps, tableQueryResult, filters } = useTable({
    resource: "contacts",
    meta: {
      select: selectValue,
    },
    sorters: {
      initial: [
        {
          field: "id",
          order: "desc",
        },
      ],
    },
    syncWithLocation: true,
    filters: {
      initial: [
        {
          field: "type",
          value: undefined,
          operator: "in",
        },
        {
          field: "tags.id",
          value: undefined,
          operator: "in",
        },
      ],
    },
    onSearch: (values: any) => {
      return [
        {
          field: "firstname",
          operator: "contains",
          value: values.name,
        },
      ];
    },
  });
  useEffect(() => {
    if (filters.find((item: any) => item.field == "tags.id")?.value) {
      setSelectValue("*, phone_numbers(*), tags!inner(id, name)");
    } else {
      setSelectValue("*, phone_numbers(*), tags(id, name)");
    }
  }, [filters.find((item: any) => item.field == "tags.id")?.value]);


Add drawer to show member details

Offcanvas + callback wiring (onClose, onMemberClick) + basic data fetching. Next PR will fetch rest of the data and display it.
https://user-images.githubusercontent.com/1481940/174393738-b68dae2c-b688-4223-a246-a140339d04a0.mp4

 Add drawer to show full hash and other information when clicking truncated hashes


Add the omega-transport-feign into distribution kit and Add the Openfeign LICENSE to the release/licenses fold

Add the omega-transport-feign into distribution kit
Add the Openfeign LICENSE to the release/licenses fold.

Coverage increased (+0.09%) to 93.184% when pulling 1f14ecd0462c8fa16bd63017bf9d8a44a7b373c3 on Lionelpang:SCB-732 into a537635cf6806ce52e159b438c881f4dc5290900 on apache:master.

Thx for the contribution.


Data not initialized in Constructor with Inheritance

We have the following structure generated in TypeScript from an Open API definition:
export class ChildDto extends ParentDto implements IChildDto {
    someChildProp?: number | undefined;

    constructor(data?: IChildDto ) {
        super(data);
        this._discriminator = 'ChildDto ';
    }

    init(_data?: any) {
        super.init(_data);
        if (_data) {
            this.someChildProp= _data['someChildProp'];
        }
    }

    static fromJS(data: any): ChildDto {
        data = typeof data === 'object' ? data : {};
        let result = new ChildDto();
        result.init(data);
        return result;
    }

    toJSON(data?: any) {
        data = typeof data === 'object' ? data : {};
        data['someChildProp'] = this.someChildProp;
        super.toJSON(data);
        return data;
    }
}

If i create a new instance of ChildDto by
const additionalCashFlow = new ChildDto({ someParentProp: 100,  someChildProp: 1});
the result is
ChildDto{         someParentProp: 100,         someChildProp: undefined         _discriminator: 'ChildDto',       }
where I would have expected someChildProp to be 1.

What is IRSFixedCashFlowDto?

Sorry, I forgot to replace this. It should be the ChildDto. I've edited the code example.

Ok, can you also post ParentDto?

Hi, yes. It looks like this:
`export class ParentDto implements IParentDto {
someParentProp?: number | undefined;
protected _discriminator: string;

constructor(data?: IParentDto) {
    if (data) {
        for (var property in data) {
            if (data.hasOwnProperty(property)) (<any>this)[property] = (<any>data)[property];
        }
    }
    this._discriminator = 'ParentDto';
}

init(_data?: any) {
    if (_data) {
        this.someParentProp = _data['someParentProp'];
    }
}

static fromJS(data: any): ParentDto {
    data = typeof data === 'object' ? data : {};
    if (data['t'] === 'SomeChildDto') {
        let result = new SomeChildDto();
        result.init(data);
        return result;
    }
    if (data['t'] === 'SomeOtherChildDto') {
        let result = new SomeOtherChildDto();
        result.init(data);
        return result;
    }
    if (data['t'] === 'ChildDto') {
        let result = new ChildDto();
        result.init(data);
        return result;
    }
    let result = new ParentDto();
    result.init(data);
    return result;
}

toJSON(data?: any) {
    data = typeof data === 'object' ? data : {};
    data['t'] = this._discriminator;
    data['someParentProp'] = this.someParentProp;
    return data;
}

}`

So the problem is the “ data.hasOwnProperty” check?

Hm, that was my guess, too. But according to the documentation it should work as expected.
I may have time over the weekend to do some more specific tests.

Hi, I just came across this and I think the explanation is rather simple:
For init everything should be ok. But when using the constructor the generated code currently looks like this:
constructor(data?: IDtoName) {         super(data);         this._discriminator = 'DtoName';     }
So it is always just delegating to super until it arrives at the very base of the hierarchy. I don't know why the generated code looks different now, but maybe it is the same issue with the hasOwnProperty, that it's just not taking properties of derived classes into account.

Maybe the easiest solution would be to just call init in the constructor. Or could this lead to other problems?


Remove the legacy AmqpReceiveLinkProcessor, which uses Reactor-Core FluxProcessor deprecated in 3.5.0

Extend #33704 to implement EH receiver recovery using FluxOperator so that we can remove dependency on AmqpReceiveLinkProcessor which uses Reactor-Core FluxProcessor deprecated in 3.5.0.  (wip).

As the direction is to have one new type (named MessageFlux) that merges the functionality of "AmqpReceiveLinkProcessor" (ARLP) and "ServiceBusReceiveLinkProcessor" (SBRLP), a difference between ARLP & SBRLP is - ARLP retries only on receiver-completion, not on receiver-error. To get the same behavior, EH can create MessageFlux with AmqpRetryOptions.setMaxRetries(0) to disable retry on receiver-error.

This new MessageFlux type implemented in the PR https://github.com/Azure/azure-sdk-for-java/pull/34854 and has been integrated to SB Non-session receiver.


dyId: Symbol not found: OBJC_CLASS$__TtCs12_SwiftObject - IntuneMAMSwift.framework

dyld: Symbol not found: OBJC_CLASS$__TtCs12_SwiftObject
Referenced from: /Users//Library/Developer/CoreSimulator/Devices/18FE6DA6-C140-41AB-8B8F-E4CB9CB8A648/data/Containers/Bundle/Application/5C108836-4EF8-4EA7-8AC3-48C315D06069/chatr.app/Frameworks/IntuneMAMSwift.framework/IntuneMAMSwift
Expected in: /Users//Library/Developer/Toolchains/swift-5.0-RELEASE.xctoolchain/usr/lib/swift/iphonesimulator/libswiftCore.dylib
in /Users/_/Library/Developer/CoreSimulator/Devices/18FE6DA6-C140-41AB-8B8F-E4CB9CB8A648/data/Containers/Bundle/Application/5C108836-4EF8-4EA7-8AC3-48C315D06069/chatr.app/Frameworks/IntuneMAMSwift.framework/IntuneMAMSwift
I get a successful build of the project but as the simulator starts to run the app I get above error. iOS 13, Intune (11.2.0).

Hey @slnali, it sounds like you may be trying to build with Xcode 11. Xcode 11 is not supported with the current version of the SDK. We are working on releasing an update to our SDK, and will in-turn update the sample repo as well. For now, the recommendation is to build with Xcode 10.

Thanks Kyle that worked, app is running now.

Closed


Add a section on automated machine learning

Perhaps the workshop already has too much material for the usual runtime (~8 hours), but how about a practical section on automated machine learning? I taught this section at the end of a version of this sklearn workshop and it was quite well-received, and I think it's a good topic to mention to beginners (even if just a teaser).

We are mostly focusing on things that can be applied directly in practice. Do you have an application of automl that can be run immediately and will be widely useful? Is there a two-liner in tpot that can be useful for many? I don't think auto-sklearn can be easily installed yet.

Yep, check this notebook. It's a very quick coding demo of TPOT for classification and regression, working on similar data sets to the ones in the rest of the workshop.
We've gone out of our way to make TPOT very easy to install and use, even for Python newbies.
I can flesh that notebook out more if there's interest in adding AutoML to the workshop. For now I just accompany that notebook with this talk, which takes about 20-30 mins to deliver.


Assign bot

Would be nice that if someone comment: I will take it it would assign it to the person for 48 hrs

After checking couple of new PRs this seems to be more relevant than ever. I'm gonna add some specs and try to come up with solution soon, if you guys agree:

Have working bot which assigns task on "/assign" in comments. Posts message with (example) "ASSIGNED - @kodadotuserxyz has been assigned with this issue. Task is locked 🔒 until DD-MM-YYYY HH-MM-SS". If the period expires and there's no linked closing PR open by that time -> task gets unassigned with message "OPEN ISSUE - issue wasn't resolved in locked period and is open to re-assignment!"

Triggering bot again by different user BEFORE the locked period is over will result in "ERROR - task is already assigned to @kodadotuserxyz. Wait until DD-MM-YYYY HH-MM-SS before re-assigning!"

Triggering bot again by different user AFTER the locked period is over but WHILE there's already open PR which is linked and closing said issue will result in "ERROR - task is already being resolved in PR #9999 by @kodadotuserxyz!"

Bot comments on PR that's linked AND it's supposed to be closing assigned issue:
a) If the PR author matches assignee:
"SUCCESS - PR #9999 is closing issue #9998 which was assigned to @kodadotxyz. Please wait for review or grab another issue in a meantime! https://github.com/kodadot/nft-gallery/issues/"
b) If the author just goes rogue and ignores all this:
"WARNING - This PR is closing issue #9999 which is not assigned to you!  Get the issue assigned first, wait until locked period is over or grab another issue https://github.com/kodadot/nft-gallery/issues/ Read more about assigning policy at CONTRIBUTING.MD (perhaps @cryptodamsky  could help here? )
c)  If the author gets issue assigned after creating PR (for example newcomers who just read WARNING from b)) -> bot comments with SUCCESS message from a)

Some limit on assigned issues at given time? Perhaps three would be the max. limit (unless PR is already open, that wouldn't be counted) after which bot can comment with "MAX ASSIGNED ISSUES LIMIT REACHED. Work on closing assgined issues before getting another issue assigned!"

Pretty sure I've missed some cases but since I'm gonna be looking into GitHub bots regarding #1477 anyways, might aswell work on this one too. Perhaps work on this one first since it's, wild west out there in PRs :laughing: (sorry it keeps happening to you @prachi00)
This was sort of discussed but not fleshed out at the last all-hands-dev call, some feedback / thoughts would be appreciated.

@petersopko makes sense, this would be so amazing and helpful when done 😍
yeah happened to me again today in #2498 😔

Would be nice that if someone comment: I will take it it would assign it to the person for 48 hrs

72hrs is way too much, on small issues 24-48hours should be bearable. We saw that even some complex issues done under 2 days or sooner.

"/assign"

Can we have something human centric?
All the cases would be probably easier understandable in some diagrams as in text is hard to catch some deadlock cases 👀
If you want to start cracking, let's try with https://autocode.com/ it's super easy to make first prototype :)
Oh try to look on gitcoin issues, they have something already cases handled, yet some of them comes to me as overkill.

Can we have something human centric?

I take this
I'll take this
I will take this

small issues 24-48hours should be bearable

If we can parse the $ (dollar) labels I would set 24 hr lock for single $ issue

Can we have something human centric?

I take this I'll take this I will take this

small issues 24-48hours should be bearable

If we can parse the $ (dollar) labels I would set 24 hr lock for single $ issue

I feel like 24 hours is too less though for one issue sometimes, so maybe we can also add support for increasing time with another comment?

72hrs is way too much, on small issues 24-48hours should be bearable. We saw that even some complex issues done under 2 days or sooner.

If we can parse the $ (dollar) labels I would set 24 hr lock for single $ issue

I feel like 24 hours is too less though for one issue sometimes, so maybe we can also add support for increasing time with another comment?

OK, if you guys agree, I'll make the first version with $ for 24hrs, $$ for 48hrs, $$$ for 72 and $$$$ and more for 120hrs, i.e. five days. We can add support if you want, or perhaps, since opening PR related to task could lock it until PR is resolved. As @yangwao mentioned before, PRs should be resolved within short period anyways, therefore this would add the requested 24-48hrs and it's also proving you're working on the issue.
a) add support function for additional 24hrs
b) force faster PRs which lock the issue
Can do either of those.

Can we have something human centric?

I take this
I'll take this
I will take this

OK, these three phrases for start.

All the cases would be probably easier understandable in some diagrams as in text is hard to catch some deadlock cases 👀

Will try to recaputre the specs with something eye-friendly tomorrow.

If you want to start cracking, let's try with https://autocode.com/ it's super easy to make first prototype :)

I've tried and apparently they don't support typescript! If you insist on doing it in Autocode, we can deploy the compiled JS folder and store TS for work. Since the first thing I've got was "file type not supported" I've opted for AWS Lambda for now, but I can still change as it's not working yet.

Okay, I've trained and tested the bot yesterday on my repo, needs some refinement with PRs today but it's more or less ready, now just ironing out the logic and messages with you :) Also, I need to write up some readme.md since Autocode does awesome job but the initial deployment seems to stay manual (can't do it from GitHub repo afaik).
Here's the promised diagram of bot logic:

some of the variables/terms in diagram and code:
ignoredUsers - bots and internal team, nothing happens if it's empty anyway, this just stops bot from executing right away
goPhrases = ['I take this', "I'll take this", 'I will take this']
bountyTimes =  {     $: 24,     $$: 48,     $$$: 72,     $$$$: 96,     $$$$$: 120, }
messages:

alreadyAssigned = ALREADY ASSIGNED - @${commentCreator}, you are already assigned to this issue! 🔒 Locked period expires at ${date}

errorMessage = ERROR - task is already assigned to @${username}. 🔒 Locked period expires at ${date}

cannotAssignAgain = ERROR - @${commentCreator},  your 🔒 Locked period expired at ${date}. If you are close to finishing this issue, open PR to ensure nobody else grabs it!

errorMessagePR = ERROR - @${username},  PR ${prNumber}  was already opened for this issue! Try grabbing another one!

successAssign = ASSIGNED - @${commentCreator} has been assigned with this issue. 🔒 Locked period is set for @${bountyTime} hours until ${date}

successPR = SUCCESS - @${prAuthor} you've successfully opened PR for issue ${closingIssue} which has been assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

warningPR = WARNING - @${prAuthor} you have opened PR for issue ${closingIssue} which isn't assigned to you. Please be warned that this PR may get rejected if there's another assignee for issue ${closingIssue}

@yangwao just saw your discord message related force push, automatized check and possible warning in comments under PR can be added as well.

Got it working with kv storage.

Updated my previous comment, it works now. I didn't use Cloudflare KV Workers but built-in Autocode kv util. Hope that's okay. https://docs.autocode.com/building-endpoints/keyvalue-storage/

built-in Autocode kv util

I have it working with KV workers after all, since I'm connecting it to #1477, there was a possibility of hitting upper limit with autocode's storage. @yangwao please check out the diagram when you're available, and let me know what you think. I'm working on connection to #1477 right now.

I'm working on connection to https://github.com/kodadot/nft-gallery/issues/1477 right now.

I would personally leave it for another issue // -> focus to make first working version of the assign bot

I would personally leave it for another issue // -> focus to make first working version of the assign bot

I've published version which is only affected by #1477 in a small way, basically it's just storing data objects needed for generating LEADERBOARD.md in the future. It's triggered by payout message, otherwise it does nothing. But I can remove it in case you want this fully separated, it just uses the same webhook for created comment on issue.
I was waiting for some feedback on the diagram, however, in case you want to test this in the meantime, I have it working on https://github.com/petersopko/kodabot-test/issues where you can get some issues assigned, PRs opened etc., and in case you want to install it and have it working for yourself at this stage, it's available here https://autocode.com/app/petersopko/kodabot/

I'll maybe adjust the formatting bit to be way easier to find, so contributor doesn't need it to read whole to find some key information

Suggestions

I'd remove timezone and keep just UTC for anyone out there to make easier calculations
[x] Is there sizeable windows for each bounty and hours? To reflect higher bounty might require sizeable time frame. Found it seems for $$ - 48, $$$ - 72hrs :)
what happens after the time period expires?
have you thought about making a dumb ranking system based on successful tasks, expired takes, unassigns?
if someone takes its, won't deliver, should not be able take it anymore?
is there limit issues a person have? Like 5 or so? So we focus on delivering PRs not assign race :D
did you thought about queue? like if there will be two persons who would like to do it, first who fails, can take over once first would not make it in time, surrender or won't deliver it out to keep continuous demand in tact. With ranking this would could play interesting, like adding higher rank to someone successfully deliver as backup someone else

Some debug
https://github.com/petersopko/kodabot-test/issues/9

My few coin-cents

I'll maybe adjust the formatting bit to be way easier to find, so contributor doesn't need it to read whole to find some key information

ok

I'd remove timezone and keep just UTC for anyone out there to make easier calculations

ok

[x]  Is there sizeable windows for each bounty and hours? To reflect higher bounty might require sizeable time frame. Found it seems for $$ - 48, $$$ - 72hrs :)

bountyTimes = { $: 24, $$: 48, $$$: 72, $$$$: 96, $$$$$: 120}

what happens after the time period expires?

after time period expires, nothing happens unless somebody else wants to take the issue. basically, if you won't finish in time and there's nobody else who'd like to try, feel free to go on?

if someone takes its, won't deliver, should not be able take it anymore?

I can set it that way. My thinking was right now, if you give it a shot, won't deliver, somebody else gives it a shot, won't deliver, then you can do it again. Do you want to keep only one try per person?

is there limit issues a person have? Like 5 or so? So we focus on delivering PRs not assign race :D

nope, I was waiting for this info, let's make it 5 issues then :)

have you thought about making a dumb ranking system based on successful tasks, expired takes, unassigns?
did you thought about queue? like if there will be two persons who would like to do it, first who fails, can take over once first would not make it in time, surrender or won't deliver it out to keep continuous demand in tact. With ranking this would could play interesting, like adding higher rank to someone successfully deliver as backup someone else

ranking system can be done but it's tricky. what counts as successful issue completion? If you open PR, is it already successful? That can be some PR opening race as you've mentioned. If not, what if PR review takes longer. Is it unsuccessful/expired?
I'd say, let's track two data points, assigned+merged as successful and assigned+unassigned as unsuccessful. These two points can be counted for every dev and it can be tracked and perhaps added as columns to LEADERBOARD.MD?
to the queue question, currently, locked period which is set, is stored only in kv workers. I can add queue, but re-assign will only happen on next bot trigger which is webhook for created comment. Therefore, if you are second you will be added to the queue and if somebody tries to assign issue after expiration again, you will be assigned instead. Won't happen automatically. Is this kind of queue ok?

Some debug
petersopko/kodabot-test#9

thank you for that, hard to debug this alone and github keeps flagging my fake accounts :D

My few coin-cents

Offtopic thoughts would be nice (optional) for v2 assign bot.
Bot would not assign higher priority issues, i.e. if we have p2 issues, some pool of issues which is significantly bigger than p3+, would not assign for p3+ or make it as a lower bound paid out issue, not sure how to handle this most efficiency.
I get that some p3 are easily solvable, but if projects would have ton of p2 open and people start working p5 probably it's not what they want to see being done on the short-term horizon from perspective of project
But this could be a highly controversial topic, but projects out there would help steer where they want to be if they set some priority labels for example.

Let's continue to #2932


SystemId is nullguid when using RecordRef and SystemIdNo

When trying to access the systemid-value of a record using recordreference, the field is found correctly using "SystemIdNo" but the value of the guid is always 0000000.. I even tried using LoadFields for the field but this didn't help. What's missing?

var
        field_i: Integer;
        SalesInvoiceHeader: Record "Sales Invoice Header";
        recordidv: RecordId;
    begin
        SalesInvoiceHeader.FindFirst();
        recordidv := SalesInvoiceHeader.RecordId;
        RecordRefe := recordidv.GetRecord();
        field_i := RecordRefe.SystemIdNo;
        fieldRefe := RecordRefe.Field(field_i);
        Message(fieldRefe.value);

This is not the right place to post that. Said that, are you debugging a new or "old" BC? Old BC can have systemId fields as 000000 because back then the system fields didn't exist, hence, records can have systemId as 00000000....

This is not the right place to post that. Said that, are you debugging a new or "old" BC? Old BC can have systemId fields as 000000 because back then the system fields didn't exist, hence, records can have systemId as 00000000....

Hi, ok.
It's a 23. The systemid has a value when I look at the record in question, just not when accessing this way.
Seems the recref isn't loading the fields. As a workaround, doing
        RecordRefe.SetRecFilter();
        RecordRefe.FindFirst();

actually updates the value and the systemid is then found. But Loadfields does not.
Will close.


Add Scheduled Universe Selection

Description

Adding UniverseSettings.Schedule that will allow users to
specify a custom selection schedule that is independent of the
underlying data frequency. For now only implemented for Coarse
selection.
Adding unit and regression tests

Related Issue

Closes https://github.com/QuantConnect/Lean/issues/3890
Motivation and Context

Improve user experience
Requires Documentation Change

Yes
How Has This Been Tested?

Unit and regression tests
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] Refactor (non-breaking change which improves implementation)
[ ] Performance (non-breaking change which improves performance. Please add associated performance test and results)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Non-functional change (xml comments/documentation/etc)

Checklist:

[x] My code follows the code style of this project.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.
[x] My branch follows the naming convention bug-<issue#>-<description> or feature-<issue#>-<description>

Per discussion in slack; need more thought to better handle the "Tuesday 5am" problem. Perhaps scheduling according to the universe file date not the actual wall clock time.

There are some time zone conflicts around supporting ITimeRules with this feature, because ITimeRules return in UTC but IDateRules are dates. So to keep it simple and since it didn't seem that it's a must-have, the PR implements only IDateRules
The PR was closed because of Tuesday 5 am problem: with the current implementation, performing selection every Monday, would consume Friday's data. This behavior seemed like a bug. The other discussed option would be actually performing selection on Tuesday 5 am with Monday's data. This last option would add some noise since user requested selection on Monday and it's happening on Tuesday, more of a filtering behavior: if data.Date >= selectionDate


Page Responsiveness

What happened?
The page isn't responsive for the mobile devices.
Reproduction steps
Steps to reproduce the behavior:

1. Open website in responsive mode or in any mobile device.
4. See error.

Expected behavior
It should be responsive.
Screenshots
No response
Version
1.0.3 (Edge)
Version (If not available above)
No response
What browsers are you seeing the problem on?
Firefox, Chrome, Safari, Microsoft Edge
Browsers (If not available above)
Samsung Internet Browser
Additional context
The error can be seen on any of the browser and version.
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Can you assign this issue to me ?

Ok you can work on it.... @GamingCapital


Data cleanup

This addresses some of the data issues in #44
data/ dir is now a little tidier - with files organized by type. scripts/ and raw/ have also been moved into data/
I wasn't quite feeling ambitious enough to rework the front-end code that uses variable-prefixed json (e.g. var foo = <actual-json>), since all of that seems subject to change in the near future. Instead, I moved all those files into data/deprecated/ so they should be easy to identify and update.

:deciduous_tree:


[WFSSL-4] Fixing segmentation fault on Fedora 26

Proposal fix - sort directory listing to avoid ssl & crypto library mismatch

Resolved with https://github.com/wildfly/wildfly-openssl/commit/b7bb447ce88084f77148ec5affefe577187ce56d


Renamed ordinal scales to categorical scales

Since the ordinal scales do not take into account the ordering of the data (even if there is one), it makes more sense to call them categorical scales.
A categorical scale is just a mapping from a finite set of values to another finite set of values.

@rmenegaux Not sure about this one. The OrdinalScale exposes d3.scale.ordinal, which is probably its namesake.
It's a major API change that will break any code using OrdinalScale for a minor naming inconvenience (alternately why not NominalScale). Anyway, we should first deprecate it with warnings before we switch it, if at all.

@dmadeka Reinstated the ordinal scales, which will trigger deprecation warnings if used.

As discussed in the dev meeting, the point of bqplot is to expose d3, and despite a misnaming, we might want to stick to the d3 naming convention


[Snyk] Security upgrade node from 16.18.1-alpine3.16 to 16.19.0-alpine3.16

This PR was automatically created by Snyk using the credentials of a real user.Keeping your Docker base image up-to-date means you’ll benefit from security fixes in the latest version of your chosen image.
Changes included in this PR

Dockerfile

We recommend upgrading to node:16.19.0-alpine3.16, as this image has only 0 known vulnerabilities. To do this, merge this pull request, then verify your application still works as expected.
Some of the most important vulnerabilities in your base image include:

Severity
Priority Score / 1000
Issue
Exploit Maturity

471
Double Free SNYK-ALPINE316-OPENSSL-3314624
No Known Exploit

471
Double Free SNYK-ALPINE316-OPENSSL-3314624
No Known Exploit

571
Access of Resource Using Incompatible Type ('Type Confusion') SNYK-ALPINE316-OPENSSL-3314641
No Known Exploit

571
Access of Resource Using Incompatible Type ('Type Confusion') SNYK-ALPINE316-OPENSSL-3314641
No Known Exploit

471
Use After Free SNYK-ALPINE316-OPENSSL-3314643
No Known Exploit

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
🛠 Adjust project settings

Learn how to fix vulnerabilities with free interactive lessons:
🦉 Learn about vulnerability in an interactive lesson of Snyk Learn.

allerede bumpet


[Chore]: Refactor UnknownKey error logic into shared function

Background
We re-use logic for parsing unknown key errors in every list handler.
Per this comment we should refactor the code to re-use a single shared function.
Action to take
Move the function in the service_binding_handler.go into shared.go and remove all the duplicated logic from list handlers by instead invoking the new shared function.
Impact
DRY up the code
Dev Notes
This is pulled out into a separate chore given the large blast radius making the change costly to include as part of another PR given the high risk of merge conflicts across the affected files.

We have introduced the request validator in all handlers that takes care to validate the incoming payload in one place. Closing therefore.