[Bug]: Unable to retrieve windows info

Platform
Windows 10 virtualized (VirtualBox 7.0.10)
Plugin
device_info_plus
Version
9.1.2
Flutter SDK
3.16.4
Steps to reproduce
error occurred while retrieving Windows info using device_info_plus with the folowing error message
[ERROR:flutter/runtime/dart_vm_initializer.cc(41)] Unhandled Exception: Error 0x00000000: Operazione completata.
#0      DeviceInfoPlusWindowsPlugin.getSystemMemoryInMegabytes (package:device_info_plus/src/device_info_plus_windows.dart:128:9)
#1      DeviceInfoPlusWindowsPlugin.getInfo (package:device_info_plus/src/device_info_plus_windows.dart:88:34)
#2      DeviceInfoPlusWindowsPlugin.deviceInfo (package:device_info_plus/src/device_info_plus_windows.dart:40:36)
#3      DeviceInfoPlugin.windowsInfo (package:device_info_plus/device_info_plus.dart:93:27)
#4      getDeviceInfo (package:myProject/lib/lib1.dart:391:47)
#5      main (package:myProject/main.dart:52:15)

Code Sample
Code to reproduce error

Future<String> getDeviceInfo() async {
  DeviceInfoPlugin deviceInfo = DeviceInfoPlugin();
  WindowsDeviceInfo info = await deviceInfo.windowsInfo; // lib1.dart, line 391

...

}

on android the same code is working (using androidInfo obviously)

Logs
PS C:\Users\Enrico\Desktop\ProgettiAndroidStudio\myProject> flutter run --verbose

....

IO  : Writing 160013 characters to text file C:\Users\Enrico\AppData\Local\Pub\Cache\log\pub_log.txt.
MSG : Logs written to C:\Users\Enrico\AppData\Local\Pub\Cache\log\pub_log.txt.
[+2593 ms] Found plugin connectivity_plus at C:\Users\Enrico\AppData\Local\Pub\Cache\hosted\pub.dev\connectivity_plus-5.0.2\
[  +35 ms] Found plugin device_info_plus at C:\Users\Enrico\AppData\Local\Pub\Cache\hosted\pub.dev\device_info_plus-9.1.2\
[   +8 ms] Found plugin flutter_beep at C:\Users\Enrico\AppData\Local\Pub\Cache\hosted\pub.dev\flutter_beep-1.0.0\
[   +4 ms] Found plugin flutter_internet_signal at C:\Users\Enrico\AppData\Local\Pub\Cache\hosted\pub.dev\flutter_internet_signal-0.0.30\
[  +54 ms] Found plugin network_info_plus at C:\Users\Enrico\AppData\Local\Pub\Cache\hosted\pub.dev\network_info_plus-4.1.0+1\
[   +7 ms] Found plugin package_info_plus at C:\Users\Enrico\AppData\Local\Pub\Cache\hosted\pub.dev\package_info_plus-5.0.1\
[   +7 ms] Found plugin path_provider at C:\Users\Enrico\AppData\Local\Pub\Cache\hosted\pub.dev\path_provider-2.1.2\
[   +1 ms] Found plugin path_provider_android at C:\Users\Enrico\AppData\Local\Pub\Cache\hosted\pub.dev\path_provider_android-2.2.2\
[   +2 ms] Found plugin path_provider_foundation at C:\Users\Enrico\AppData\Local\Pub\Cache\hosted\pub.dev\path_provider_foundation-2.3.2\
[   +2 ms] Found plugin path_provider_linux at C:\Users\Enrico\AppData\Local\Pub\Cache\hosted\pub.dev\path_provider_linux-2.2.1\
[  +33 ms] Found plugin path_provider_windows at C:\Users\Enrico\AppData\Local\Pub\Cache\hosted\pub.dev\path_provider_windows-2.2.1\
[  +10 ms] Found plugin permission_handler at C:\Users\Enrico\AppData\Local\Pub\Cache\hosted\pub.dev\permission_handler-11.2.0\
[  +11 ms] Found plugin permission_handler_android at C:\Users\Enrico\AppData\Local\Pub\Cache\hosted\pub.dev\permission_handler_android-12.0.3\
[  +16 ms] Found plugin permission_handler_apple at C:\Users\Enrico\AppData\Local\Pub\Cache\hosted\pub.dev\permission_handler_apple-9.3.0\
[  +21 ms] Found plugin permission_handler_html at C:\Users\Enrico\AppData\Local\Pub\Cache\hosted\pub.dev\permission_handler_html-0.1.1\
[   +2 ms] Found plugin permission_handler_windows at C:\Users\Enrico\AppData\Local\Pub\Cache\hosted\pub.dev\permission_handler_windows-0.2.1\
[   +7 ms] Found plugin shared_preferences at C:\Users\Enrico\AppData\Local\Pub\Cache\hosted\pub.dev\shared_preferences-2.2.2\
[   +1 ms] Found plugin shared_preferences_android at C:\Users\Enrico\AppData\Local\Pub\Cache\hosted\pub.dev\shared_preferences_android-2.2.1\
[   +1 ms] Found plugin shared_preferences_foundation at C:\Users\Enrico\AppData\Local\Pub\Cache\hosted\pub.dev\shared_preferences_foundation-2.3.5\
[   +1 ms] Found plugin shared_preferences_linux at C:\Users\Enrico\AppData\Local\Pub\Cache\hosted\pub.dev\shared_preferences_linux-2.3.2\
[   +2 ms] Found plugin shared_preferences_web at C:\Users\Enrico\AppData\Local\Pub\Cache\hosted\pub.dev\shared_preferences_web-2.2.2\
[   +1 ms] Found plugin shared_preferences_windows at C:\Users\Enrico\AppData\Local\Pub\Cache\hosted\pub.dev\shared_preferences_windows-2.3.2\
[   +8 ms] Found plugin url_launcher at C:\Users\Enrico\AppData\Local\Pub\Cache\hosted\pub.dev\url_launcher-6.2.4\
[   +1 ms] Found plugin url_launcher_android at C:\Users\Enrico\AppData\Local\Pub\Cache\hosted\pub.dev\url_launcher_android-6.2.2\
[   +1 ms] Found plugin url_launcher_ios at C:\Users\Enrico\AppData\Local\Pub\Cache\hosted\pub.dev\url_launcher_ios-6.2.4\
[   +1 ms] Found plugin url_launcher_linux at C:\Users\Enrico\AppData\Local\Pub\Cache\hosted\pub.dev\url_launcher_linux-3.1.1\
[   +1 ms] Found plugin url_launcher_macos at C:\Users\Enrico\AppData\Local\Pub\Cache\hosted\pub.dev\url_launcher_macos-3.1.0\
[   +2 ms] Found plugin url_launcher_web at C:\Users\Enrico\AppData\Local\Pub\Cache\hosted\pub.dev\url_launcher_web-2.2.3\
[   +1 ms] Found plugin url_launcher_windows at C:\Users\Enrico\AppData\Local\Pub\Cache\hosted\pub.dev\url_launcher_windows-3.1.1\
[   +2 ms] Found plugin wakelock_plus at C:\Users\Enrico\AppData\Local\Pub\Cache\hosted\pub.dev\wakelock_plus-1.1.4\
[   +4 ms] Found plugin webview_flutter at C:\Users\Enrico\AppData\Local\Pub\Cache\hosted\pub.dev\webview_flutter-4.4.4\
[   +1 ms] Found plugin webview_flutter_android at C:\Users\Enrico\AppData\Local\Pub\Cache\hosted\pub.dev\webview_flutter_android-3.14.0\
[   +2 ms] Found plugin webview_flutter_wkwebview at C:\Users\Enrico\AppData\Local\Pub\Cache\hosted\pub.dev\webview_flutter_wkwebview-3.10.2\
[  +57 ms] Found plugin connectivity_plus at C:\Users\Enrico\AppData\Local\Pub\Cache\hosted\pub.dev\connectivity_plus-5.0.2\
[   +8 ms] Found plugin device_info_plus at C:\Users\Enrico\AppData\Local\Pub\Cache\hosted\pub.dev\device_info_plus-9.1.2\
[   +5 ms] Found plugin flutter_beep at C:\Users\Enrico\AppData\Local\Pub\Cache\hosted\pub.dev\flutter_beep-1.0.0\
[   +1 ms] Found plugin flutter_internet_signal at C:\Users\Enrico\AppData\Local\Pub\Cache\hosted\pub.dev\flutter_internet_signal-0.0.30\
[  +12 ms] Found plugin network_info_plus at C:\Users\Enrico\AppData\Local\Pub\Cache\hosted\pub.dev\network_info_plus-4.1.0+1\
[   +3 ms] Found plugin package_info_plus at C:\Users\Enrico\AppData\Local\Pub\Cache\hosted\pub.dev\package_info_plus-5.0.1\
[   +4 ms] Found plugin path_provider at C:\Users\Enrico\AppData\Local\Pub\Cache\hosted\pub.dev\path_provider-2.1.2\
[   +1 ms] Found plugin path_provider_android at C:\Users\Enrico\AppData\Local\Pub\Cache\hosted\pub.dev\path_provider_android-2.2.2\
[   +1 ms] Found plugin path_provider_foundation at C:\Users\Enrico\AppData\Local\Pub\Cache\hosted\pub.dev\path_provider_foundation-2.3.2\
[   +1 ms] Found plugin path_provider_linux at C:\Users\Enrico\AppData\Local\Pub\Cache\hosted\pub.dev\path_provider_linux-2.2.1\
[   +2 ms] Found plugin path_provider_windows at C:\Users\Enrico\AppData\Local\Pub\Cache\hosted\pub.dev\path_provider_windows-2.2.1\
[   +2 ms] Found plugin permission_handler at C:\Users\Enrico\AppData\Local\Pub\Cache\hosted\pub.dev\permission_handler-11.2.0\
[   +1 ms] Found plugin permission_handler_android at C:\Users\Enrico\AppData\Local\Pub\Cache\hosted\pub.dev\permission_handler_android-12.0.3\
[   +1 ms] Found plugin permission_handler_apple at C:\Users\Enrico\AppData\Local\Pub\Cache\hosted\pub.dev\permission_handler_apple-9.3.0\
[   +1 ms] Found plugin permission_handler_html at C:\Users\Enrico\AppData\Local\Pub\Cache\hosted\pub.dev\permission_handler_html-0.1.1\
[   +1 ms] Found plugin permission_handler_windows at C:\Users\Enrico\AppData\Local\Pub\Cache\hosted\pub.dev\permission_handler_windows-0.2.1\
[   +7 ms] Found plugin shared_preferences at C:\Users\Enrico\AppData\Local\Pub\Cache\hosted\pub.dev\shared_preferences-2.2.2\
[   +1 ms] Found plugin shared_preferences_android at C:\Users\Enrico\AppData\Local\Pub\Cache\hosted\pub.dev\shared_preferences_android-2.2.1\
[   +1 ms] Found plugin shared_preferences_foundation at C:\Users\Enrico\AppData\Local\Pub\Cache\hosted\pub.dev\shared_preferences_foundation-2.3.5\
[   +1 ms] Found plugin shared_preferences_linux at C:\Users\Enrico\AppData\Local\Pub\Cache\hosted\pub.dev\shared_preferences_linux-2.3.2\
[   +1 ms] Found plugin shared_preferences_web at C:\Users\Enrico\AppData\Local\Pub\Cache\hosted\pub.dev\shared_preferences_web-2.2.2\
[   +1 ms] Found plugin shared_preferences_windows at C:\Users\Enrico\AppData\Local\Pub\Cache\hosted\pub.dev\shared_preferences_windows-2.3.2\
[   +5 ms] Found plugin url_launcher at C:\Users\Enrico\AppData\Local\Pub\Cache\hosted\pub.dev\url_launcher-6.2.4\
[   +1 ms] Found plugin url_launcher_android at C:\Users\Enrico\AppData\Local\Pub\Cache\hosted\pub.dev\url_launcher_android-6.2.2\
[   +1 ms] Found plugin url_launcher_ios at C:\Users\Enrico\AppData\Local\Pub\Cache\hosted\pub.dev\url_launcher_ios-6.2.4\
[   +1 ms] Found plugin url_launcher_linux at C:\Users\Enrico\AppData\Local\Pub\Cache\hosted\pub.dev\url_launcher_linux-3.1.1\
[   +1 ms] Found plugin url_launcher_macos at C:\Users\Enrico\AppData\Local\Pub\Cache\hosted\pub.dev\url_launcher_macos-3.1.0\
[   +1 ms] Found plugin url_launcher_web at C:\Users\Enrico\AppData\Local\Pub\Cache\hosted\pub.dev\url_launcher_web-2.2.3\
[   +1 ms] Found plugin url_launcher_windows at C:\Users\Enrico\AppData\Local\Pub\Cache\hosted\pub.dev\url_launcher_windows-3.1.1\
[   +2 ms] Found plugin wakelock_plus at C:\Users\Enrico\AppData\Local\Pub\Cache\hosted\pub.dev\wakelock_plus-1.1.4\
[   +3 ms] Found plugin webview_flutter at C:\Users\Enrico\AppData\Local\Pub\Cache\hosted\pub.dev\webview_flutter-4.4.4\
[   +1 ms] Found plugin webview_flutter_android at C:\Users\Enrico\AppData\Local\Pub\Cache\hosted\pub.dev\webview_flutter_android-3.14.0\
[   +2 ms] Found plugin webview_flutter_wkwebview at C:\Users\Enrico\AppData\Local\Pub\Cache\hosted\pub.dev\webview_flutter_wkwebview-3.10.2\
[  +77 ms] Generating C:\Users\Enrico\Desktop\ProgettiAndroidStudio\myProject\android\app\src\main\java\io\flutter\plugins\GeneratedPluginRegistrant.java
[ +120 ms] Initializing file store
[   +2 ms] gen_localizations: Starting due to {}
[ +495 ms] "fr": 1 untranslated message(s).
[        ] "it": 1 untranslated message(s).
[        ] To see a detailed report, use the untranslated-messages-file
           option in the l10n.yaml file:
           untranslated-messages-file: desiredFileName.txt
           <other option>: <other selection>

....

[  +22 ms] Building Windows application... (completed in 72,1s)
[   +2 ms] √  Built build\windows\x64\runner\Debug\my_project.exe.
[ +544 ms] VM Service URL on device: http://<IP_ADDRESS>:64342/VEber-TF1b4=/
[   +4 ms] Caching compiled dill
[  +38 ms] Connecting to service protocol: http://<IP_ADDRESS>:64342/VEber-TF1b4=/
[ +106 ms] Launching a Dart Developer Service (DDS) instance at http://<IP_ADDRESS>:0, connecting to VM service at http://<IP_ADDRESS>:64342/VEber-TF1b4=/.
[  +79 ms] DDS is listening at http://<IP_ADDRESS>:64345/YFxuuUX2088=/.
[  +50 ms] [ERROR:flutter/runtime/dart_vm_initializer.cc(41)] Unhandled Exception: Error 0x00000000: Operazione completata.
[        ] #0      DeviceInfoPlusWindowsPlugin.getSystemMemoryInMegabytes (package:device_info_plus/src/device_info_plus_windows.dart:128:9)
[   +2 ms] #1      DeviceInfoPlusWindowsPlugin.getInfo (package:device_info_plus/src/device_info_plus_windows.dart:88:34)
[        ] #2      DeviceInfoPlusWindowsPlugin.deviceInfo (package:device_info_plus/src/device_info_plus_windows.dart:40:36)
[        ] #3      DeviceInfoPlugin.windowsInfo (package:device_info_plus/device_info_plus.dart:93:27)
[        ] #4      getDeviceInfo (package:myProject/hmi/lib/lib1.dart:391:47)
[        ] #5      main (package:myProject/main.dart:52:15)
[        ] <asynchronous suspension>
[  +36 ms] Successfully connected to service protocol: http://<IP_ADDRESS>:64342/VEber-TF1b4=/
[  +21 ms] DevFS: Creating new filesystem on the device (null)
[  +17 ms] DevFS: Created new filesystem on the device (file:///C:/Users/Enrico/AppData/Local/Temp/myProjectbab8b6c0/myProject/)
[   +6 ms] Updating assets
[ +446 ms] Manifest contained wildcard assets. Inserting missing file into build graph to force rerun. for more information see #56466.
[  +14 ms] Syncing files to device Windows...
[   +2 ms] Compiling dart to kernel with 0 updated files
[        ] Processing bundle.
[   +1 ms] <- recompile package:myProject/main.dart fbe43801-fcde-4a2a-89b0-1505b506ae4b
[        ] <- fbe43801-fcde-4a2a-89b0-1505b506ae4b
[  +92 ms] Bundle processing done.
[ +244 ms] Updating files.
[   +1 ms] DevFS: Sync finished
[   +1 ms] Syncing files to device Windows... (completed in 343ms)
[        ] Synced 0.0MB.
[   +1 ms] <- accept
[   +3 ms] Connected to _flutterView/0x29d69a7d6a0.
[   +2 ms] Flutter run key commands.
[  +17 ms] r Hot reload.
[   +3 ms] R Hot restart.
[   +3 ms] h List all available interactive commands.
[   +1 ms] d Detach (terminate "flutter run" but leave application running).
[        ] c Clear the screen
[   +1 ms] q Quit (terminate the application on the device).
[   +6 ms] A Dart VM Service on Windows is available at: http://<IP_ADDRESS>:64345/YFxuuUX2088=/
[   +1 ms] The Flutter DevTools debugger and profiler on Windows is available at: http://<IP_ADDRESS>:9100?uri=http://<IP_ADDRESS>:64345/YFxuuUX2088=/

Flutter Doctor
[√] Flutter (Channel stable, 3.16.4, on Microsoft Windows [Versione 10.0.19045.3930], locale it-IT)
    • Flutter version 3.16.4 on channel stable at C:\src\flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 2e9cb0aa71 (7 weeks ago), 2023-12-11 14:35:13 -0700
    • Engine revision 54a7145303
    • Dart version 3.2.3
    • DevTools version 2.28.4

[√] Windows Version (Installed version of Windows is version 10 or higher)

[√] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at C:\Users\Enrico\AppData\Local\Android\sdk
    • Platform android-34, build-tools 34.0.0
    • Java binary at: C:\Program Files\Android\Android Studio\jbr\bin\java
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-b2043.56-10027231)
    • All Android licenses accepted.

[√] Chrome - develop for the web
    • Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe

[√] Visual Studio - develop Windows apps (Visual Studio Community 2022 17.7.6)
    • Visual Studio at C:\Program Files\Microsoft Visual Studio\2022\Community
    • Visual Studio Community 2022 version 17.7.34221.43
    • Windows 10 SDK version 10.0.22621.0

[√] Android Studio (version 2022.3)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin can be installed from:
       https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
       https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-b2043.56-10027231)

[√] Connected device (4 available)
    • TAB KINGKONG (mobile) • TKK230921001877 • android-arm64  • Android 13 (API 33)
    • Windows (desktop)     • windows         • windows-x64    • Microsoft Windows [Versione 10.0.19045.3930]
    • Chrome (web)          • chrome          • web-javascript • Google Chrome 120.0.6099.227
    • Edge (web)            • edge            • web-javascript • Microsoft Edge 121.0.2277.83

[√] Network resources
    • All expected network resources are available.

• No issues found!

Checklist before submitting a bug

[X] I searched issues in this repository and couldn't find such bug/problem
[X] I Google'd a solution and I couldn't find it
[X] I searched on StackOverflow for a solution and I couldn't find it
[X] I read the README.md file of the plugin
[X] I'm using the latest version of the plugin
[X] All dependencies are up to date with flutter pub upgrade
[X] I did a flutter clean
[X] I tried running the example project

[ERROR:flutter/runtime/dart_vm_initializer.cc(41)] Unhandled Exception: Error 0x00000000: Operazione completata.

This looks like some access permission issue according to logs. Have you search this error?

@vbuberen In the plugin documentation I don't see any particular setup for permissions on Windows. Furthermore, the method should return a string (even just "unknown" or something), not crash.
It seems to crash while requesting memory information.
#0      DeviceInfoPlusWindowsPlugin.getSystemMemoryInMegabytes (package:device_info_plus/src/device_info_plus_windows.dart:128:9)
It could be a problem with virtualbox

In the plugin documentation I don't see any particular setup for permissions on Windows. Furthermore, the method should return a string (even just "unknown" or something), not crash.

The thing is I am not the only one working on plugins and I don't really involved in Windows part of things. I shared with you what I found about the error you have seen. Presumably, you should have also seen is as you marked that Googled the error in the checkbox. Thanks for stating the obvious thing on how the plugin should work, but the tone of the message feels like demanding something to me. If that is so, you are free to open a PR and resolve the issue, thus, help other people with similar setups.

It was not my intention to be rude in any way, if I came across as rude I apologize.
I just wanted to reply to your message.
I can't solve this problem and I hope someone can help me, that's all.
Thanks for your answer

Could I ask you to check if this plugin works Ok in the setup you have with VirtualBox?
https://github.com/onepub-dev/system_info
I am not really familiar with Windows development and currently don't have anyone to help here, but would like to address the issue you encountered. Thus, would appreciate the feedback if that other plugin works fine for you.

One possible "fix" is that the getSystemMemoryInMegabytes in device_info_plus_windows.dart fails silently with a 0 rather than throwing an exception. At least it would make the plugin usable in a VM, even if the memory value is wrong.

This problem seems to occur in the virtual machine.


Cilium is droping ICMP packets (Invalid packet)

Bug report
When I deploy cilium, ICMP is stoping working on any cluster node, If I running cilium monitor -t drop I see that it is dropping EchoReply packets:
xx drop (Invalid packet) flow 0x318a7847 to endpoint 0, identity<PHONE_NUMBER>->0: <IP_ADDRESS> -> <IP_ADDRESS> EchoReply

I've tried to deploy with default settings from quick start guide and with kubeProxyReplacement=strict.
ICMP is working fine only if I setting global.kubeProxyReplacement=disabled option.
General Information

Cilium version (run cilium version):Client: 1.8.2 aa42034f0 2020-07-23T15:02:39-07:00 go version go1.14.6 linux/amd64
Daemon: 1.8.2 aa42034f0 2020-07-23T15:02:39-07:00 go version go1.14.6 linux/amd64

Kernel version (run uname -a)Linux m1c31 5.4.0-42-generic #46-Ubuntu SMP Fri Jul 10 00:24:02 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Orchestration system version in use (e.g. kubectl version, Mesos, ...):Client Version: version.Info{Major:"1", Minor:"18", GitVersion:"v1.18.0", GitCommit:"9e991415386e4cf155a24b1da15becaa390438d8", GitTreeState:"clean", BuildDate:"2020-03-25T14:58:59Z", GoVersion:"go1.13.8", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"18", GitVersion:"v1.18.6", GitCommit:"dff82dc0de47299ab66c83c626e08b245ab19037", GitTreeState:"clean", BuildDate:"2020-07-15T16:51:04Z", GoVersion:"go1.13.9", Compiler:"gc", Platform:"linux/amd64"}

Link to relevant artifacts (policies, deployments scripts, ...)

You top-level example was <IP_ADDRESS> -> <IP_ADDRESS>, what are these two addresses?

node-to-node or node-to-external host or external host-to-node
<IP_ADDRESS> - node
<IP_ADDRESS> - internet gateway
in current case i'm on the node pinging internet gateway, it is responding but reply packets are filtered on the node

Any ideas how can I debug this?

Any ideas how can I debug this?

I'd suggest to add the cilium_dbg before each relevant DROP_INVALID, and see with cilium monitor -v which path leads to the drops.

@brb could you point me to exact are please? I asume bpf/bpf_host.c ?

In your case it's most likely to-netdev in bpf/bpf_host.c. Grep for DROP_INVALID in its path, and keep adding cilium_dbg(ctx, DBG_GENERIC, 42, 0); for better visibility of the path.

That's weird indeed:
When I loading my patched cilium docker.io/kvaps/cilium-dev:3 I have no this bug.
When I loading official one docker.io/cilium/cilium:v1.8.2, the bug is still persists
So I wasn't able to reproduce it, but I've got new log message about DestinationUnreachable(Port):
xx drop (Invalid packet) flow 0x4ee11901 to endpoint 0, identity<PHONE_NUMBER>->0: <IP_ADDRESS> -> <IP_ADDRESS> DestinationUnreachable(Port)
xx drop (Invalid packet) flow 0x4ee11901 to endpoint 0, identity<PHONE_NUMBER>->0: <IP_ADDRESS> -> <IP_ADDRESS> EchoReply

diff --git a/bpf/bpf_host.c b/bpf/bpf_host.c
index fbb4aeb6b..66d835f7a 100644
--- a/bpf/bpf_host.c
+++ b/bpf/bpf_host.c
@@ -95,8 +95,10 @@ ipcache_lookup_srcid6(struct __ctx_buff *ctx)
 	struct ipv6hdr *ip6;
 	__u32 srcid = 0;

-	if (!revalidate_data(ctx, &data, &data_end, &ip6))
+	if (!revalidate_data(ctx, &data, &data_end, &ip6)) {
+    cilium_dbg(ctx, DBG_GENERIC, "line99", data, data_end, ip6);
 		return DROP_INVALID;
+  }

 	info = lookup_ip6_remote_endpoint((union v6addr *) &ip6->saddr);
 	if (info != NULL)
@@ -119,8 +121,10 @@ resolve_srcid_ipv6(struct __ctx_buff *ctx, __u32 srcid_from_proxy,
 	union v6addr *src;
 	int ret;

-	if (!revalidate_data(ctx, &data, &data_end, &ip6))
+	if (!revalidate_data(ctx, &data, &data_end, &ip6)) {
+    cilium_dbg(ctx, DBG_GENERIC, "line125", data, data_end, ip6);
 		return DROP_INVALID;
+  }

 	if (!from_host) {
 		union v6addr node_ip = {};
@@ -168,8 +172,10 @@ handle_ipv6(struct __ctx_buff *ctx, __u32 secctx, const bool from_host)
 	struct endpoint_info *ep;
 	__u8 nexthdr;

-	if (!revalidate_data(ctx, &data, &data_end, &ip6))
+	if (!revalidate_data(ctx, &data, &data_end, &ip6)) {
+    cilium_dbg(ctx, DBG_GENERIC, "line176", data, data_end, ip6);
 		return DROP_INVALID;
+  }

 	nexthdr = ip6->nexthdr;
 	hdrlen = ipv6_hdrlen(ctx, ETH_HLEN, &nexthdr);
@@ -197,8 +203,10 @@ handle_ipv6(struct __ctx_buff *ctx, __u32 secctx, const bool from_host)
 		skip_redirect = true;
 #endif /* ENCAP_IFINDEX || NO_REDIRECT */
 		/* Verifier workaround: modified ctx access. */
-		if (!revalidate_data(ctx, &data, &data_end, &ip6))
+		if (!revalidate_data(ctx, &data, &data_end, &ip6)) {
+      cilium_dbg(ctx, DBG_GENERIC, "line207", data, data_end, ip6);
 			return DROP_INVALID;
+    }
 	}
 #endif /* ENABLE_NODEPORT */

@@ -227,8 +235,10 @@ skip_host_firewall:
 		if (IS_ERR(ret))
 			return ret;

-		if (!revalidate_data(ctx, &data, &data_end, &ip6))
+		if (!revalidate_data(ctx, &data, &data_end, &ip6)) {
+      cilium_dbg(ctx, DBG_GENERIC, "line239", data, data_end, ip6);
 			return DROP_INVALID;
+    }
 	}

 	/* Lookup IPv4 address in list of local endpoints */
@@ -337,8 +347,10 @@ handle_to_netdev_ipv6(struct __ctx_buff *ctx)
 	__u32 srcID = 0;
 	__u8 nexthdr;

-	if (!revalidate_data(ctx, &data, &data_end, &ip6))
+	if (!revalidate_data(ctx, &data, &data_end, &ip6)) {
+    cilium_dbg(ctx, DBG_GENERIC, "line351", data, data_end, ip6);
 		return DROP_INVALID;
+  }

 	nexthdr = ip6->nexthdr;
 	hdrlen = ipv6_hdrlen(ctx, ETH_HLEN, &nexthdr);
@@ -370,8 +382,10 @@ resolve_srcid_ipv4(struct __ctx_buff *ctx, __u32 srcid_from_proxy,
 	void *data, *data_end;
 	struct iphdr *ip4;

-	if (!revalidate_data(ctx, &data, &data_end, &ip4))
+	if (!revalidate_data(ctx, &data, &data_end, &ip4)) {
+    cilium_dbg(ctx, DBG_GENERIC, "line386", data, data_end, ip4);
 		return DROP_INVALID;
+  }

 	/* Packets from the proxy will already have a real identity. */
 	if (identity_is_reserved(srcid_from_ipcache)) {
@@ -425,8 +439,10 @@ handle_ipv4(struct __ctx_buff *ctx, __u32 secctx, const bool from_host)
 	struct iphdr *ip4;
 	int ret;

-	if (!revalidate_data(ctx, &data, &data_end, &ip4))
+	if (!revalidate_data(ctx, &data, &data_end, &ip4)) {
+    cilium_dbg(ctx, DBG_GENERIC, "line443", data, data_end, ip4);
 		return DROP_INVALID;
+  }

 #ifdef ENABLE_NODEPORT
 	if (!from_host) {
@@ -446,8 +462,10 @@ handle_ipv4(struct __ctx_buff *ctx, __u32 secctx, const bool from_host)
 		skip_redirect = true;
 #endif /* ENCAP_IFINDEX || NO_REDIRECT */
 		/* Verifier workaround: modified ctx access. */
-		if (!revalidate_data(ctx, &data, &data_end, &ip4))
+		if (!revalidate_data(ctx, &data, &data_end, &ip4)) {
+      cilium_dbg(ctx, DBG_GENERIC, "line466", data, data_end, ip4);
 			return DROP_INVALID;
+    }
 	}
 #endif /* ENABLE_NODEPORT */

@@ -479,8 +497,10 @@ handle_ipv4(struct __ctx_buff *ctx, __u32 secctx, const bool from_host)
 		if (IS_ERR(ret))
 			return ret;

-		if (!revalidate_data(ctx, &data, &data_end, &ip4))
+		if (!revalidate_data(ctx, &data, &data_end, &ip4)) {
+      cilium_dbg(ctx, DBG_GENERIC, "line501", data, data_end, ip4);
 			return DROP_INVALID;
+    }
 	}

 	/* Lookup IPv4 address in list of local endpoints and host IPs */

Also I found that ping is starting working if I do:
rm -f /sys/fs/bpf/tc/globals/cilium_calls_netdev_00002

my docker image is not loading this program for some reason

My bad, I was using DBG_GENERIC wrong, now I just copied your line, and got two new lines:
CPU 04: MARK 0x3e4fb784 FROM 1921 DEBUG: No message, arg1=42 (0x2a) arg2=0 (0x0)
CPU 04: MARK 0x3e4fb784 FROM 1921 DEBUG: No message, arg1=42 (0x2a) arg2=0 (0x0)
xx drop (Invalid packet) flow 0x3e4fb784 to endpoint 0, identity<PHONE_NUMBER>->0: <IP_ADDRESS> -> <IP_ADDRESS> EchoReply

not much informative :(
here is correct patch:
diff --git a/bpf/bpf_host.c b/bpf/bpf_host.c
index fbb4aeb6b..098623c2a 100644
--- a/bpf/bpf_host.c
+++ b/bpf/bpf_host.c
@@ -95,8 +95,10 @@ ipcache_lookup_srcid6(struct __ctx_buff *ctx)
 	struct ipv6hdr *ip6;
 	__u32 srcid = 0;

-	if (!revalidate_data(ctx, &data, &data_end, &ip6))
+	if (!revalidate_data(ctx, &data, &data_end, &ip6)) {
+    cilium_dbg(ctx, DBG_GENERIC, 42, 0);
 		return DROP_INVALID;
+  }

 	info = lookup_ip6_remote_endpoint((union v6addr *) &ip6->saddr);
 	if (info != NULL)
@@ -119,8 +121,10 @@ resolve_srcid_ipv6(struct __ctx_buff *ctx, __u32 srcid_from_proxy,
 	union v6addr *src;
 	int ret;

-	if (!revalidate_data(ctx, &data, &data_end, &ip6))
+	if (!revalidate_data(ctx, &data, &data_end, &ip6)) {
+    cilium_dbg(ctx, DBG_GENERIC, 42, 0);
 		return DROP_INVALID;
+  }

 	if (!from_host) {
 		union v6addr node_ip = {};
@@ -168,8 +172,10 @@ handle_ipv6(struct __ctx_buff *ctx, __u32 secctx, const bool from_host)
 	struct endpoint_info *ep;
 	__u8 nexthdr;

-	if (!revalidate_data(ctx, &data, &data_end, &ip6))
+	if (!revalidate_data(ctx, &data, &data_end, &ip6)) {
+    cilium_dbg(ctx, DBG_GENERIC, 42, 0);
 		return DROP_INVALID;
+  }

 	nexthdr = ip6->nexthdr;
 	hdrlen = ipv6_hdrlen(ctx, ETH_HLEN, &nexthdr);
@@ -197,8 +203,10 @@ handle_ipv6(struct __ctx_buff *ctx, __u32 secctx, const bool from_host)
 		skip_redirect = true;
 #endif /* ENCAP_IFINDEX || NO_REDIRECT */
 		/* Verifier workaround: modified ctx access. */
-		if (!revalidate_data(ctx, &data, &data_end, &ip6))
+		if (!revalidate_data(ctx, &data, &data_end, &ip6)) {
+      cilium_dbg(ctx, DBG_GENERIC, 42, 0);
 			return DROP_INVALID;
+    }
 	}
 #endif /* ENABLE_NODEPORT */

@@ -227,8 +235,10 @@ skip_host_firewall:
 		if (IS_ERR(ret))
 			return ret;

-		if (!revalidate_data(ctx, &data, &data_end, &ip6))
+		if (!revalidate_data(ctx, &data, &data_end, &ip6)) {
+      cilium_dbg(ctx, DBG_GENERIC, 42, 0);
 			return DROP_INVALID;
+    }
 	}

 	/* Lookup IPv4 address in list of local endpoints */
@@ -337,8 +347,10 @@ handle_to_netdev_ipv6(struct __ctx_buff *ctx)
 	__u32 srcID = 0;
 	__u8 nexthdr;

-	if (!revalidate_data(ctx, &data, &data_end, &ip6))
+	if (!revalidate_data(ctx, &data, &data_end, &ip6)) {
+    cilium_dbg(ctx, DBG_GENERIC, 42, 0);
 		return DROP_INVALID;
+  }

 	nexthdr = ip6->nexthdr;
 	hdrlen = ipv6_hdrlen(ctx, ETH_HLEN, &nexthdr);
@@ -370,8 +382,10 @@ resolve_srcid_ipv4(struct __ctx_buff *ctx, __u32 srcid_from_proxy,
 	void *data, *data_end;
 	struct iphdr *ip4;

-	if (!revalidate_data(ctx, &data, &data_end, &ip4))
+	if (!revalidate_data(ctx, &data, &data_end, &ip4)) {
+    cilium_dbg(ctx, DBG_GENERIC, 42, 0);
 		return DROP_INVALID;
+  }

 	/* Packets from the proxy will already have a real identity. */
 	if (identity_is_reserved(srcid_from_ipcache)) {
@@ -425,8 +439,10 @@ handle_ipv4(struct __ctx_buff *ctx, __u32 secctx, const bool from_host)
 	struct iphdr *ip4;
 	int ret;

-	if (!revalidate_data(ctx, &data, &data_end, &ip4))
+	if (!revalidate_data(ctx, &data, &data_end, &ip4)) {
+    cilium_dbg(ctx, DBG_GENERIC, 42, 0);
 		return DROP_INVALID;
+  }

 #ifdef ENABLE_NODEPORT
 	if (!from_host) {
@@ -446,8 +462,10 @@ handle_ipv4(struct __ctx_buff *ctx, __u32 secctx, const bool from_host)
 		skip_redirect = true;
 #endif /* ENCAP_IFINDEX || NO_REDIRECT */
 		/* Verifier workaround: modified ctx access. */
-		if (!revalidate_data(ctx, &data, &data_end, &ip4))
+		if (!revalidate_data(ctx, &data, &data_end, &ip4)) {
+      cilium_dbg(ctx, DBG_GENERIC, 42, 0);
 			return DROP_INVALID;
+    }
 	}
 #endif /* ENABLE_NODEPORT */

@@ -479,8 +497,10 @@ handle_ipv4(struct __ctx_buff *ctx, __u32 secctx, const bool from_host)
 		if (IS_ERR(ret))
 			return ret;

-		if (!revalidate_data(ctx, &data, &data_end, &ip4))
+		if (!revalidate_data(ctx, &data, &data_end, &ip4)) {
+      cilium_dbg(ctx, DBG_GENERIC, 42, 0);
 			return DROP_INVALID;
+    }
 	}

 	/* Lookup IPv4 address in list of local endpoints and host IPs */

Got it!
https://github.com/cilium/cilium/blob/aa42034f09a5ac1218a8c6dfe0ee0b9bcf6d4801/bpf/bpf_host.c#L373-L374
https://github.com/cilium/cilium/blob/aa42034f09a5ac1218a8c6dfe0ee0b9bcf6d4801/bpf/bpf_host.c#L428-L429

Can't it be connected with the fact that this interface is having configured LACP?

What NIC do you have? /cc @borkmann

@brb
# lspci
01:00.0 Ethernet controller: Mellanox Technologies MT27520 Family [ConnectX-3 Pro]

# ethtool -i eno1
driver: mlx4_en
version: 4.0-0
firmware-version: 2.42.5004
expansion-rom-version:
bus-info: 0000:01:00.0
supports-statistics: yes
supports-test: yes
supports-eeprom-access: no
supports-register-dump: no
supports-priv-flags: yes

# uname -a
Linux m1c41 5.4.0-42-generic #46-Ubuntu SMP Fri Jul 10 00:24:02 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

For now can you replace the linked revalidate_data(..) with revalidate_data_first(..)?

replace the linked revalidate_data(..) with revalidate_data_first(..)?

working, no drops anymore

Cool, thanks for debugging this! Let us discuss tomorrow a possible fix.

Thanks for the confirmation @kvaps this really helps! This means that mlx4 only has eth header and we need to pull-in up to L4 hdr in order for this to work.

I just tested it with the latest mlx4_en module, same here:
# ethtool -i eno1
driver: mlx4_en
version: 5.0-<IP_ADDRESS>
firmware-version: 2.36.5020
expansion-rom-version:
bus-info: 0000:01:00.0
supports-statistics: yes
supports-test: yes
supports-eeprom-access: no
supports-register-dump: no
supports-priv-flags: yes

@kvaps Can you please check whether the issue is resolved with the brb0/cilium:skb-pull-v0 Docker image?

@brb this image is working fine: brb0/cilium@sha256:8415801ca4eaa53078b63b86ef5c7cb53e29c3a225b78d28161476c36e1f8f7c

I just found that problem persist with global.tunnel=vxlan and is working fine with global.tunnel=disabled

I just found that problem persist with global.tunnel=vxlan and is working fine with global.tunnel=disabled

Does it happen when a pod pings another pod on remote node? Or what is a packet flow?

Yes, ICMP was not working pod-to-pod  the same way as node-to-node or node-to-node in tunnelong mode.

the same way as node-to-node or node-to-pod in tunneling mode.

Just to confirm, you see the same ICMP drops due to invalid packet when running in the tunneling mode with the brb0/cilium:skb-pull-v0 image for node-to-node, node-to-pod and pod-to-pod, right?

@brb, sorry for confusing, I repeated the test:

pod-to-pod and node-to-pod is working fine even if pods located on different nodes
node-to-node is not working
pod-to-node is not working if pinging another node, not the same one where pod is running

Hmm, interesting. Could you repeat the experiment with cilium_dbg by adding to to-netdev in bpf_host.c and to-overlay in bpf_overlay.c, but this time by using the https://github.com/cilium/cilium/tree/pr/brb/pull_skb branch?

Re-opening because of the reported above case with overlay mode.

Re-opening because of the reported above case with overlay mode.
The original issue was in overlay mode

@brb your request is still valid?

Could you repeat the experiment with cilium_dbg by adding to to-netdev in bpf_host.c and to-overlay in bpf_overlay.c, but this time by using the https://github.com/cilium/cilium/tree/pr/brb/pull_skb branch?

or what should I test right now?

OK, I'm a bit confused - when you said https://github.com/cilium/cilium/issues/12854#issuecomment-675569188 which cases you tested?

@brb is your request still valid?

Yes, please.

Ok, let's start from beginning. I have cleanly bootstrapped nodes on ubuntu 20.04 with 5.4.0-42-generic  kernel.
Then I deploy cilium using helm:
helm upgrade --install cilium cilium/cilium --version 1.8.2 \
  --namespace kube-system \
  --set global.kubeProxyReplacement=strict \
  --set global.k8sServiceHost=cluster1-kubernetes-apiserver --set global.k8sServicePort=6443

result: ping is not working
Then I deploy cilium with --set global.kubeProxyReplacement=disabled
helm upgrade --install cilium cilium/cilium --version 1.8.2 \
  --namespace kube-system \
  --set global.kubeProxyReplacement=strict \
  --set global.k8sServiceHost=cluster1-kubernetes-apiserver --set global.k8sServicePort=6443 \
  --set global.kubeProxyReplacement=disabled

and do:
kubectl delete pod -n kube-system -l k8s-app=cilium

result: ping is working
Then I deploy cilium with
helm upgrade --install cilium cilium/cilium --version 1.8.2 \
  --namespace kube-system \
  --set global.kubeProxyReplacement=strict \
  --set global.k8sServiceHost=cluster1-kubernetes-apiserver --set global.k8sServicePort=6443 \
  --set global.tunnel=disabled \
  --set global.autoDirectNodeRoutes=true \
  --set global.nativeRoutingCIDR=<IP_ADDRESS>/12 \
  --set global.ipam.operator.clusterPoolIPv4PodCIDR=<IP_ADDRESS>/12 \
  --set global.ipam.operator.clusterPoolIPv4MaskSize=24

and do:
kubectl delete pod -n kube-system -l k8s-app=cilium

result: ping is not working
Then I deploy cilium with image from https://github.com/cilium/cilium/issues/12854#issuecomment-675525385
kubectl set image -n kube-system ds/cilium cilium-agent=brb0/cilium:skb-pull-v0
kubectl delete pod -n kube-system -l k8s-app=cilium

result: ping is working

Hmm, interesting. Could you repeat the experiment with cilium_dbg by adding to to-netdev in bpf_host.c and to-overlay in bpf_overlay.c, but this time by using the https://github.com/cilium/cilium/tree/pr/brb/pull_skb branch?

This branch is not accessible to me

Then I deploy cilium with image from #12854 (comment)
kubectl set image -n kube-system ds/cilium cilium-agent=brb0/cilium:skb-pull-v0
kubectl delete pod -n kube-system -l k8s-app=cilium
result: ping is working

So, the brb0/cilium:skb-pull-v0 image has resolved all cases: pod-to-pod, node-to-pod, node-to-node and pod-to-node?

So, the brb0/cilium:skb-pull-v0 image has resolved all cases

It is, thank you!

Thanks for the confirmation @kvaps this really helps! This means that mlx4 only has eth header in linear skb section and we need to pull-in up to L4 hdr in order for this to work.

@brb  @kvaps  May I ask that does this issue may also happens in xdp?
ctx_pull_data actually do nothing in xdp
https://github.com/cilium/cilium/blob/main/bpf/include/bpf/ctx/xdp.h#L100
#define ctx_pull_data(ctx, ...)		do { /* Already linear. */ } while (0)

@wenlxie unfortunately I have no this setup anymore


pin gcc libs

Checklist before submitting

[x] Did you read the contributor guide?
[ ] Did you update any affected documentation?
[ ] Did you write any tests to validate this change?

Description
Anaconda just updated toolchains and associated libraries.
This PR forces this recipe to build using the older toolchain and libraries by using the pins created in:
open-ce/open-ce#431
Issue:
open-ce/open-ce#315.
Review process to land

All tests and other checks must succeed.
At least one maintainer must review and approve.
If any  maintainer requests changes, they must be addressed.

pytorch-lightning is a noarch package so this is not needed.


dumphdinfo not giving output

I have been trying to get the hdseed and mnemonic of my wallet using the dash-cli, i found that the call to dumphdinfo is not giving any output.

Other calls like dumpwallet,importwallet are working fine. Am i missing something?

@anil215 Are you sure you are using an HD wallet? They are not enabled by default in the current version since support is still considered experimental. You would have had to use a command line option or add an entry to dash.conf to create an HD wallet. The result you are getting is the same thing I get when running that command on a standard (non-HD) wallet.

Hey @anil215, this should be fixed now in 12.3 :)

fixed by #2134


feat: add custom font using @next/font

If we import fonts the traditional way, the website first loads using the system font and then switches to the custom font. The @next/font package solves this issue and enables font optimizations.

Add the .woff2 font file in the fonts folder
Update the index.ts file with the newly added font

Then, update the tailwind config

Now, insert the generator in a className tag and use it

Also, cleaned up the home page and added an ignore file for prettier

Desktop

Mobile

made the banner a Link that redirects to this repo


Inputs >data

resolves #133 and replaces <inputs> with <data>.

I’m on mobile. Is the right branch? Seems to be the branch for #152.

I’m on mobile. Is the right branch? Seems to be the branch for #152.

I based this branch on the branch for #152 (confident that it will be merged) to avoid merge conflict.

I’m on mobile. Is the right branch? Seems to be the branch for #152.

After #152 is merged, the "Files Changed" tab of github automatically updated to show the difference between this branch to the new master only, not including all commits since the diverge, shortened from the previous changeset by more than 50%. Good job github.

inputs -> data looks clear, but do we need to support #133 with version 2019/05?

inputs -> data looks clear, but do we need to support #133 with version 2019/05?

Yes, since it's needed for x-dai bridge.

inputs -> data looks clear, but do we need to support #133 with version 2019/05?

Yes, since it's needed for x-dai bridge.

Ok.

@colourful-land git rebase master is useful here. See https://github.com/AlphaWallet/TokenScript/wiki/Useful-Git-Commands#rebase-master

Should those schema changes be in this PR alongside the smaller schema changes? Or is it just the inputs -> data changes I'm looking at?


directory not found

Type: Bug
i was working on vs code and then i turned it off and then it suddenly says file directory not found and after i reset it and di all the things again then  it works
but again this problem comes
VS Code version: Code 1.76.2 (ee2b180d582a7f601fa6ecfdad8d9fd269ab1884, 2023-03-14T17:55:54.936Z)
OS version: Windows_NT x64 10.0.19045
Modes:
Sandboxed: Yes

System Info

Item
Value

CPUs
Intel(R) Core(TM) i3-6006U CPU @ 2.00GHz (4 x 1992)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okskia_renderer: enabled_onvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: disabled_off

Load (avg)
undefined

Memory (System)
3.86GB (0.48GB free)

Process Argv
--crash-reporter-id a07512b6-2b06-440b-bf60-959a531404fe

Screen Reader
no

VM
0%

Extensions (12)

Extension
Author (truncated)
Version

html-snippets
abu
0.2.1

code-runner
for
0.12.0

c-cpp-runner
fra
5.1.2

CppSnippets
har
0.0.15

run-in-terminal
kor
0.0.6

cmake-tools
ms-
1.13.45

cpptools
ms-
1.14.4

cpptools-extension-pack
ms-
1.3.0

LiveServer
rit
5.7.9

html5-boilerplate
sid
1.1.1

cmake
twx
0.0.17

vscode-lldb
vad
1.9.0

(1 theme extensions excluded)

A/B Experiments
vsliv368cf:30146710
vsreu685:30147344
python383:30185418
vspor879:30202332
vspor708:30202333
vspor363:30204092
vslsvsres303:30308271
pythonvspyl392:30443607
vserr242cf:30382550
pythontb:30283811
vsjup518:30340749
pythonptprofiler:30281270
vshan820:30294714
vstes263cf:30335440
pythondataviewer:30285071
vscod805cf:30301675
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
cmake_vspar411:30581797
vsaa593cf:30376535
pythonvs932:30410667
cppdebug:30492333
vsclangdc:30486549
c4g48928:30535728
dsvsc012:30540252
pynewext54:30695312
azure-dev_surveyone:30548225
pyindex848:30662994
nodejswelcome1cf:30587006
2e4cg342:30602488
pyind779:30671433
f6dab269:30613381
pythonsymbol12:30671437
2i9eh265:30646982
vsctsb:30677850
defaultazurewalk:30687958
pythonms35:30686772

We closed this issue because it is a question about using VS Code rather than an issue or feature request. Please search for help on StackOverflow, where the community has already answered thousands of similar questions. You may find their guide on asking a new question helpful if your question has not already been asked. See also our issue reporting guidelines.
Happy Coding!


Support envoy cluster manager metrics

Support envoy cluster manager metrics- [ ] If this is non-trivial feature, paste the links/URLs to the design doc.

[X] Update the documentation to include this new feature.

[X] Tests(including UT, IT, E2E) are added to verify the new feature.

[X] If it's UI related, attach the screenshots below.

[ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #.

[X] Update the CHANGES log.

Metrics Name
Due to the envoy gRPC Metric Service   integrated metrics info and all meta info into the metrics name for now, like
envoy_metrics {
  name: "cluster.outbound|9080||details.default.svc.cluster.local.update_attempt"
  type: COUNTER
  metric {
    counter {
      value: 6.0
    }
    timestamp_ms:<PHONE_NUMBER>703
  }
}

I used envoy_cluster_metrics as the name of all the envoy cluster manager metrics in OAPand filter the specific metric with MAL.
Cluster Name(Upstream service) label
By parsing the name like cluster.outbound|9080||details.default.svc.cluster.local.update_attempt to get the ServiceMetaInfo. The format config is in the metadata-service-mapping.yaml which consists with the node service. Due to the given info only support
ServiceName, NameSpace, Version for now.
Snapshot

Should envoy/examples be updated?

Should envoy/examples be updated?

@wankai123 Please check that.

@wankai123 I can see Istio + Metrics Service e2e tests fail, please check the e2e.

Should envoy/examples be updated?

It seems outdated, I think configuring envoy directly very complex and less practice. Shall we just remove it?

Should envoy/examples be updated?

It seems outdated, I think configuring envoy directly very complex and less practice. Shall we just remove it and keep the istio way.

If so, I think We need to say envoy cluster manager metrics only support for Istio/Mesh scenario in docs,  and we should adapt to non-mesh/Istio scenario, what do you think?

If so, I think We need to say envoy cluster manager metrics only support for Istio/Mesh scenario in docs

Yes, the doc should be updated.

and we should adapt to non-mesh/Istio scenario, what do you think?

From what I see today, there is very little case, people expect SkyWalking to accept envoy ALS and metric-service for analysis. Do you face that?

If so, I think We need to say envoy cluster manager metrics only support for Istio/Mesh scenario in docs

Yes, the doc should be updated.

and we should adapt to non-mesh/Istio scenario, what do you think?

From what I see today, there is very little case, people expect SkyWalking to accept envoy ALS and metric-service for analysis. Do you face that?

Yes, for our case, we choose envoy to build our API gateway, but non-mesh scenario. and we expect envoy report it's ALS and metric to skywalking for observe envoy runtime status.

Should envoy/examples be updated?

It seems outdated, I think configuring envoy directly very complex and less practice. Shall we just remove it and keep the istio way.

I don’t think it should be considered as “outdate” as it is a demo of direct integration of Envoy which can be absolutely used without istio. But I agree we don’t have much efforts to align the feature parity between mesh and non-mesh scenarios so I agree not to update this directory.

If so, I think We need to say envoy cluster manager metrics only support for Istio/Mesh scenario in docs

Yes, the doc should be updated.

and we should adapt to non-mesh/Istio scenario, what do you think?

From what I see today, there is very little case, people expect SkyWalking to accept envoy ALS and metric-service for analysis. Do you face that?

Yes, for our case, we choose envoy to build our API gateway, but non-mesh scenario. and we expect envoy report it's ALS and metric to skywalking for observe envoy runtime status.

In the latest codes, we expect to match the all and metric service as always, so we begin to read identify section. Could you try the codes for your local or use case env, and share with us what is happening? We can't see your case, and can't run this verification for you.

In the latest codes, we expect to match the all and metric service as always

that's could be fine for our case, I'm only afraid there will be Istio's unique metrics. :-p

In the latest codes, we expect to match the all and metric service as always, so we begin to read identify section.

We had doc for this also if they want to use Envoy without istio https://github.com/apache/skywalking/blob/master/docs/en/setup/envoy/metrics_service_setting.md#configure-envoy-to-send-metrics-to-skywalking-without-istio

In the latest codes, we expect to match the all and metric service as always, so we begin to read identify section.

We had doc for this also if they want to use Envoy without istio https://github.com/apache/skywalking/blob/master/docs/en/setup/envoy/metrics_service_setting.md#configure-envoy-to-send-metrics-to-skywalking-without-istio

thx

Should envoy/examples be updated?
In this comment, I mean that we should update https://github.com/apache/skywalking/blob/master/docs/en/setup/envoy/metrics_service_setting.md#configure-envoy-to-send-metrics-to-skywalking-without-istio.

As the latest PR codes do not affect native envoy metrics, fine to me.

In the latest codes, we expect to match the all and metric service as always, so we begin to read identify section.

We had doc for this also if they want to use Envoy without istio https://github.com/apache/skywalking/blob/master/docs/en/setup/envoy/metrics_service_setting.md#configure-envoy-to-send-metrics-to-skywalking-without-istio

thx

Should envoy/examples be updated?

In this comment, I mean that if we should update
https://github.com/apache/skywalking/blob/master/docs/en/setup/envoy/metrics_service_setting.md#configure-envoy-to-send-metrics-to-skywalking-without-istio.
As the latest PR codes do not affect native envoy metrics, fine to me.

Yes, this PR doesn't change anything related to that. We just add more. @wankai123 You could keep the doc unchanged for this part.

@wankai123 I can see Istio + Metrics Service e2e tests fail, please check the e2e.

e2e fixed


Message for length

Custom failureMessage for length is not showing. Instead I get the default message. Is there anything wrong with my code?
Surname.add( Validate.Length, {
minimum: 2,
failureMessage: "Please write your full surname" } );

Found the answer in the documentation http://livevalidation.com/documentation#LiveValidation
I was using the examples instead, but documentation is very thorough. Thank you!


APEs are no longer destroyed by mousetraps

About the PR

what is sez on the tin.
Media

[x] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog

:cl:

fix: APEs can no longer be destroyed by mousetraps.

:skull:

Apes were so light they broke from mouse traps... insane
Sounds like a problem with mouse traps tbh

mousetrap jank


[Here's LIVe]+Broncos vs Chargers LIVE Streams ON TV CHANNEL SUNDAY 13 OCT 2024

[Here's LIVe]+Broncos vs Chargers LIVE Streams ON TV CHANNEL SUNDAY 13 OCT 2024.. The Denver Broncos will host the Los Angeles Chargers on Sunday, October 13, 2024, at Empower Field at Mile High in Denver. Kickoff is set for 4:05 p.m. ET. The Broncos are coming off a three-game winning streak, while the Chargers are looking to bounce back after two consecutive losses
.🔴 GO LIVE==►► CLICK HERE TO WATCH LIVE
🔴 GO LIVE==►► CLICK HERE TO WATCH LIVE
Date: Sunday, Oct. 13
Time: 4:05 p.m. ET/1:05 p.m. PT
TV: CBS
Streaming: Paramount+, Fubo, YouTube TV (NFL Sunday Ticket), NFL+
Location: Empower Field at Mile High Stadium in Denver.
When is kickoff time for Broncos vs. Chargers?
The NFL Week 6 game between the Los Angeles Chargers and Denver Broncos is scheduled to kick off at 4:05 p.m. ET (1:05 p.m. PT).
What TV channel is Broncos vs. Chargers?
The Week 6 game between the Los Angeles Chargers and Denver Broncos will be broadcast on CBS.
How to stream Broncos vs. Chargers for free
Chargers vs. Broncos is available for cord-cutters via Fubo, which is offering a one-week free trial for new subscribers.
Broncos vs. Chargers: TV, time, streaming for Sunday
The game between the Los Angeles Chargers and Denver Broncos will be broadcast on CBS.


Pusher error: Internal server error..

Reverb Version
1.0.0-beta7
Laravel Version
11.2.0
PHP Version
8.3.6
Description
Hi! Have problem with reverb broadcast in production

.env
BROADCAST_CONNECTION=reverb

REVERB_APP_ID=********
REVERB_APP_KEY=********
REVERB_APP_SECRET=********
REVERB_SERVER_HOST=<IP_ADDRESS>
REVERB_SERVER_PORT=8081
REVERB_SCHEME=https

REVERB_HOST=wss.*******.com
REVERB_PORT=443

supervisor
[program:reverb]
command=php /var/www/html/artisan reverb:start --host="<IP_ADDRESS>" --port=8081
autostart=true
autorestart=true
user=%(ENV_SUPERVISOR_PHP_USER)s
redirect_stderr=true
stdout_logfile=/var/www/html/storage/logs/reverb.log

Success connection to wss but something goes wrong. Can anyone help?

Steps To Reproduce
.

Hi @joedixon!

BroadcastException

Illuminate\Broadcasting\BroadcastException:
Pusher error: Internal server error..
at /var/www/html/vendor/laravel/framework/src/Illuminate/Broadcasting/Broadcasters/PusherBroadcaster.php:165
at Illuminate\Broadcasting\Broadcasters\PusherBroadcaster->broadcast()
(/var/www/html/vendor/laravel/framework/src/Illuminate/Broadcasting/BroadcastEvent.php:92)
at Illuminate\Broadcasting\BroadcastEvent->handle()
(/var/www/html/vendor/laravel/framework/src/Illuminate/Container/BoundMethod.php:36)
at Illuminate\Container\BoundMethod::Illuminate\Container{closure}()
(/var/www/html/vendor/laravel/framework/src/Illuminate/Container/Util.php:41)
at Illuminate\Container\Util::unwrapIfClosure()
(/var/www/html/vendor/laravel/framework/src/Illuminate/Container/BoundMethod.php:93)
at Illuminate\Container\BoundMethod::callBoundMethod()
(/var/www/html/vendor/laravel/framework/src/Illuminate/Container/BoundMethod.php:35)
at Illuminate\Container\BoundMethod::call()
(/var/www/html/vendor/laravel/framework/src/Illuminate/Container/Container.php:662)
at Illuminate\Container\Container->call()
(/var/www/html/vendor/laravel/framework/src/Illuminate/Bus/Dispatcher.php:128)
at Illuminate\Bus\Dispatcher->Illuminate\Bus{closure}()
(/var/www/html/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php:144)
at Illuminate\Pipeline\Pipeline->Illuminate\Pipeline{closure}()
(/var/www/html/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php:119)
at Illuminate\Pipeline\Pipeline->then()
(/var/www/html/vendor/laravel/framework/src/Illuminate/Bus/Dispatcher.php:132)
at Illuminate\Bus\Dispatcher->dispatchNow()
(/var/www/html/vendor/laravel/framework/src/Illuminate/Broadcasting/BroadcastManager.php:158)
at Illuminate\Broadcasting\BroadcastManager->queue()
(/var/www/html/vendor/laravel/framework/src/Illuminate/Events/Dispatcher.php:357)
at Illuminate\Events\Dispatcher->broadcastEvent()
(/var/www/html/vendor/laravel/framework/src/Illuminate/Events/Dispatcher.php:280)
at Illuminate\Events\Dispatcher->invokeListeners()
(/var/www/html/vendor/laravel/framework/src/Illuminate/Events/Dispatcher.php:266)
at Illuminate\Events\Dispatcher->dispatch()
(/var/www/html/vendor/laravel/framework/src/Illuminate/Broadcasting/PendingBroadcast.php:72)
at Illuminate\Broadcasting\PendingBroadcast->__destruct()
(/var/www/html/app/Services/Chat/SendMessageService.php:24)
at App\Services\Chat\SendMessageService->run()
(/var/www/html/app/Filament/Abstract/ChatAbstract.php:72)
at App\Filament\Abstract\ChatAbstract->sendMessage()
(/var/www/html/vendor/laravel/framework/src/Illuminate/Container/BoundMethod.php:36)
at Illuminate\Container\BoundMethod::Illuminate\Container{closure}()
(/var/www/html/vendor/laravel/framework/src/Illuminate/Container/Util.php:41)
at Illuminate\Container\Util::unwrapIfClosure()
(/var/www/html/vendor/laravel/framework/src/Illuminate/Container/BoundMethod.php:93)
at Illuminate\Container\BoundMethod::callBoundMethod()
(/var/www/html/vendor/laravel/framework/src/Illuminate/Container/BoundMethod.php:35)
at Illuminate\Container\BoundMethod::call()
(/var/www/html/vendor/livewire/livewire/src/Wrapped.php:23)
at Livewire\Wrapped->__call()
(/var/www/html/vendor/livewire/livewire/src/Mechanisms/HandleComponents/HandleComponents.php:468)
at Livewire\Mechanisms\HandleComponents\HandleComponents->callMethods()
(/var/www/html/vendor/livewire/livewire/src/Mechanisms/HandleComponents/HandleComponents.php:100)
at Livewire\Mechanisms\HandleComponents\HandleComponents->update()
(/var/www/html/vendor/livewire/livewire/src/LivewireManager.php:96)
at Livewire\LivewireManager->update()
(/var/www/html/vendor/livewire/livewire/src/Mechanisms/HandleRequests/HandleRequests.php:89)
at Livewire\Mechanisms\HandleRequests\HandleRequests->handleUpdate()
(/var/www/html/vendor/laravel/framework/src/Illuminate/Routing/ControllerDispatcher.php:46)
at Illuminate\Routing\ControllerDispatcher->dispatch()
(/var/www/html/vendor/laravel/framework/src/Illuminate/Routing/Route.php:260)
at Illuminate\Routing\Route->runController()
(/var/www/html/vendor/laravel/framework/src/Illuminate/Routing/Route.php:206)
at Illuminate\Routing\Route->run()
(/var/www/html/vendor/laravel/framework/src/Illuminate/Routing/Router.php:806)
at Illuminate\Routing\Router->Illuminate\Routing{closure}()
(/var/www/html/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php:144)
at Illuminate\Pipeline\Pipeline->Illuminate\Pipeline{closure}()
(/var/www/html/vendor/laravel/framework/src/Illuminate/Routing/Middleware/SubstituteBindings.php:50)
at Illuminate\Routing\Middleware\SubstituteBindings->handle()
(/var/www/html/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php:183)
at Illuminate\Pipeline\Pipeline->Illuminate\Pipeline{closure}()
(/var/www/html/vendor/laravel/framework/src/Illuminate/Foundation/Http/Middleware/VerifyCsrfToken.php:88)
at Illuminate\Foundation\Http\Middleware\VerifyCsrfToken->handle()
(/var/www/html/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php:183)
at Illuminate\Pipeline\Pipeline->Illuminate\Pipeline{closure}()
(/var/www/html/vendor/laravel/framework/src/Illuminate/View/Middleware/ShareErrorsFromSession.php:49)
at Illuminate\View\Middleware\ShareErrorsFromSession->handle()
(/var/www/html/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php:183)
at Illuminate\Pipeline\Pipeline->Illuminate\Pipeline{closure}()
(/var/www/html/vendor/laravel/framework/src/Illuminate/Session/Middleware/StartSession.php:121)
at Illuminate\Session\Middleware\StartSession->handleStatefulRequest()
(/var/www/html/vendor/laravel/framework/src/Illuminate/Session/Middleware/StartSession.php:64)
at Illuminate\Session\Middleware\StartSession->handle()
(/var/www/html/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php:183)
at Illuminate\Pipeline\Pipeline->Illuminate\Pipeline{closure}()
(/var/www/html/vendor/laravel/framework/src/Illuminate/Cookie/Middleware/AddQueuedCookiesToResponse.php:37)
at Illuminate\Cookie\Middleware\AddQueuedCookiesToResponse->handle()
(/var/www/html/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php:183)
at Illuminate\Pipeline\Pipeline->Illuminate\Pipeline{closure}()
(/var/www/html/vendor/laravel/framework/src/Illuminate/Cookie/Middleware/EncryptCookies.php:75)
at Illuminate\Cookie\Middleware\EncryptCookies->handle()
(/var/www/html/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php:183)
at Illuminate\Pipeline\Pipeline->Illuminate\Pipeline{closure}()
(/var/www/html/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php:119)
at Illuminate\Pipeline\Pipeline->then()
(/var/www/html/vendor/laravel/framework/src/Illuminate/Routing/Router.php:805)
at Illuminate\Routing\Router->runRouteWithinStack()
(/var/www/html/vendor/laravel/framework/src/Illuminate/Routing/Router.php:784)
at Illuminate\Routing\Router->runRoute()
(/var/www/html/vendor/laravel/framework/src/Illuminate/Routing/Router.php:748)
at Illuminate\Routing\Router->dispatchToRoute()
(/var/www/html/vendor/laravel/framework/src/Illuminate/Routing/Router.php:737)
at Illuminate\Routing\Router->dispatch()
(/var/www/html/vendor/laravel/framework/src/Illuminate/Foundation/Http/Kernel.php:200)
at Illuminate\Foundation\Http\Kernel->Illuminate\Foundation\Http{closure}()
(/var/www/html/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php:144)
at Illuminate\Pipeline\Pipeline->Illuminate\Pipeline{closure}()
(/var/www/html/vendor/livewire/livewire/src/Features/SupportDisablingBackButtonCache/DisableBackButtonCacheMiddleware.php:19)
at Livewire\Features\SupportDisablingBackButtonCache\DisableBackButtonCacheMiddleware->handle()
(/var/www/html/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php:183)
at Illuminate\Pipeline\Pipeline->Illuminate\Pipeline{closure}()
(/var/www/html/vendor/laravel/framework/src/Illuminate/Foundation/Http/Middleware/ConvertEmptyStringsToNull.php:27)
at Illuminate\Foundation\Http\Middleware\ConvertEmptyStringsToNull->handle()
(/var/www/html/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php:183)
at Illuminate\Pipeline\Pipeline->Illuminate\Pipeline{closure}()
(/var/www/html/vendor/laravel/framework/src/Illuminate/Foundation/Http/Middleware/TrimStrings.php:47)
at Illuminate\Foundation\Http\Middleware\TrimStrings->handle()
(/var/www/html/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php:183)
at Illuminate\Pipeline\Pipeline->Illuminate\Pipeline{closure}()
(/var/www/html/vendor/laravel/framework/src/Illuminate/Http/Middleware/ValidatePostSize.php:27)
at Illuminate\Http\Middleware\ValidatePostSize->handle()
(/var/www/html/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php:183)
at Illuminate\Pipeline\Pipeline->Illuminate\Pipeline{closure}()
(/var/www/html/vendor/laravel/framework/src/Illuminate/Foundation/Http/Middleware/PreventRequestsDuringMaintenance.php:110)
at Illuminate\Foundation\Http\Middleware\PreventRequestsDuringMaintenance->handle()
(/var/www/html/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php:183)
at Illuminate\Pipeline\Pipeline->Illuminate\Pipeline{closure}()
(/var/www/html/vendor/laravel/framework/src/Illuminate/Http/Middleware/HandleCors.php:49)
at Illuminate\Http\Middleware\HandleCors->handle()
(/var/www/html/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php:183)
at Illuminate\Pipeline\Pipeline->Illuminate\Pipeline{closure}()
(/var/www/html/vendor/laravel/framework/src/Illuminate/Http/Middleware/TrustProxies.php:57)
at Illuminate\Http\Middleware\TrustProxies->handle()
(/var/www/html/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php:183)
at Illuminate\Pipeline\Pipeline->Illuminate\Pipeline{closure}()
(/var/www/html/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php:119)
at Illuminate\Pipeline\Pipeline->then()
(/var/www/html/vendor/laravel/framework/src/Illuminate/Foundation/Http/Kernel.php:175)
at Illuminate\Foundation\Http\Kernel->sendRequestThroughRouter()
(/var/www/html/vendor/laravel/framework/src/Illuminate/Foundation/Http/Kernel.php:144)
at Illuminate\Foundation\Http\Kernel->handle()
(/var/www/html/vendor/laravel/framework/src/Illuminate/Foundation/Application.php:1168)
at Illuminate\Foundation\Application->handleRequest()
(/var/www/html/public/index.php:17)
at require_once('/var/www/html/public/index.php')
(/var/www/html/vendor/laravel/framework/src/Illuminate/Foundation/resources/server.php:16)

If you start the server in debug mode, you should see the cause of the 500 error in the server output.
php artisan reverb:start --debug

Debug trace

Connection Established .................................. 70363917.405033814
  Message Received ........................................ 70363917.405033814
1▕ {
2▕     "event": "pusher:subscribe",
3▕     "data": {
4▕         "auth": "-----:-----",
5▕         "channel": "private-admin.all.chats"...
Message Handled ......................................... 70363917.405033814
Message Received ........................................ 70363917.405033814
1▕ {
2▕     "event": "pusher:subscribe",
3▕     "data": {
4▕         "auth": "-----:-----",
5▕         "channel": "private-chat.7"
6▕     }
7▕ }
Message Handled ......................................... 70363917.405033814
Message Received ........................................ 70363917.405033814
1▕ {
2▕     "event": "pusher:subscribe",
3▕     "data": {
4▕         "auth": "-----:-----",
5▕         "channel": "private-App.Models.User.1"...
Message Handled ......................................... 70363917.405033814
Pruning Stale Connections ..................................................
Pinging Inactive Connections ...............................................

If you dump out the stack trace here, you will get a better idea what is causing the issue:
https://github.com/laravel/reverb/blob/main/src/Servers/Reverb/Http/Server.php#L63-L66

Found that.
Exception generated here https://github.com/laravel/reverb/blob/main/src/Protocols/Pusher/Http/Controllers/EventsController.php#L28
because request body content is null here https://github.com/laravel/reverb/blob/main/src/Protocols/Pusher/Http/Controllers/Controller.php#L46
but I can't understand why

JsonException

JsonException: Syntax error in /var/www/html/vendor/laravel/reverb/src/Protocols/Pusher/Http/Controllers/EventsController.php:28
Stack trace:
#0 /var/www/html/vendor/laravel/reverb/src/Protocols/Pusher/Http/Controllers/EventsController.php(28): json_decode()
#1 /var/www/html/vendor/laravel/reverb/src/Servers/Reverb/Http/Router.php(69): Laravel\Reverb\Protocols\Pusher\Http\Controllers\EventsController->__invoke()
#2 /var/www/html/vendor/laravel/reverb/src/Servers/Reverb/Http/Server.php(61): Laravel\Reverb\Servers\Reverb\Http\Router->dispatch()
#3 /var/www/html/vendor/laravel/reverb/src/Servers/Reverb/Http/Server.php(106): Laravel\Reverb\Servers\Reverb\Http\Server->handleRequest()
#4 /var/www/html/vendor/evenement/evenement/src/EventEmitterTrait.php(143): Laravel\Reverb\Servers\Reverb\Http\Server->Laravel\Reverb\Servers\Reverb\Http\{closure}()
#5 /var/www/html/vendor/react/stream/src/Util.php(71): Evenement\EventEmitter->emit()
#6 /var/www/html/vendor/evenement/evenement/src/EventEmitterTrait.php(143): React\Stream\Util::React\Stream\{closure}()
#7 /var/www/html/vendor/react/stream/src/DuplexResourceStream.php(196): Evenement\EventEmitter->emit()
#8 /var/www/html/vendor/react/event-loop/src/StreamSelectLoop.php(246): React\Stream\DuplexResourceStream->handleData()
#9 /var/www/html/vendor/react/event-loop/src/StreamSelectLoop.php(213): React\EventLoop\StreamSelectLoop->waitForStreamActivity()
#10 /var/www/html/vendor/laravel/reverb/src/Servers/Reverb/Http/Server.php(42): React\EventLoop\StreamSelectLoop->run()
#11 /var/www/html/vendor/laravel/reverb/src/Servers/Reverb/Console/Commands/StartServer.php(74): Laravel\Reverb\Servers\Reverb\Http\Server->start()
#12 /var/www/html/vendor/laravel/framework/src/Illuminate/Container/BoundMethod.php(36): Laravel\Reverb\Servers\Reverb\Console\Commands\StartServer->handle()
#13 /var/www/html/vendor/laravel/framework/src/Illuminate/Container/Util.php(41): Illuminate\Container\BoundMethod::Illuminate\Container\{closure}()
#14 /var/www/html/vendor/laravel/framework/src/Illuminate/Container/BoundMethod.php(93): Illuminate\Container\Util::unwrapIfClosure()
#15 /var/www/html/vendor/laravel/framework/src/Illuminate/Container/BoundMethod.php(35): Illuminate\Container\BoundMethod::callBoundMethod()
#16 /var/www/html/vendor/laravel/framework/src/Illuminate/Container/Container.php(662): Illuminate\Container\BoundMethod::call()
#17 /var/www/html/vendor/laravel/framework/src/Illuminate/Console/Command.php(212): Illuminate\Container\Container->call()
#18 /var/www/html/vendor/symfony/console/Command/Command.php(279): Illuminate\Console\Command->execute()
#19 /var/www/html/vendor/laravel/framework/src/Illuminate/Console/Command.php(181): Symfony\Component\Console\Command\Command->run()
#20 /var/www/html/vendor/symfony/console/Application.php(1049): Illuminate\Console\Command->run()
#21 /var/www/html/vendor/symfony/console/Application.php(318): Symfony\Component\Console\Application->doRunCommand()
#22 /var/www/html/vendor/symfony/console/Application.php(169): Symfony\Component\Console\Application->doRun()
#23 /var/www/html/vendor/laravel/framework/src/Illuminate/Foundation/Console/Kernel.php(196): Symfony\Component\Console\Application->run()
#24 /var/www/html/vendor/laravel/framework/src/Illuminate/Foundation/Application.php(1183): Illuminate\Foundation\Console\Kernel->handle()
#25 /var/www/html/artisan(13): Illuminate\Foundation\Application->handleCommand()
#26 {main}

Are you able to provide a repo and detailed steps on how to reproduce?
laravel new bug-report --github="--public"

Apologies, this project is covered by a NDA. However, I can provide a brief overview of the architecture.
We utilize Docker on the server to deploy the project. The primary load balancer on the server is Traefik.
We expose ports from the backend image as follows:
Port 8080 is mapped to port 80 for the main PHP application.
Port 8081 is used for the Reverb service.
Additionally, Traefik is configured to manage traffic for two domains:
www..com, which serves as the main application. Traefik routes all traffic from this domain to Docker port 8080.
wss..com, which handles WebSocket connections. Traefik routes all traffic from this domain to Docker port 8081.

.env

BROADCAST_CONNECTION=reverb
REVERB_APP_ID=********
REVERB_APP_KEY=********
REVERB_APP_SECRET=********
REVERB_HOST=<IP_ADDRESS>
REVERB_PORT=8081
REVERB_SCHEME=https
REVERB_HOST=wss.rebdron.com
REVERB_PORT=443
VITE_REVERB_APP_KEY="${REVERB_APP_KEY}"
VITE_REVERB_HOST="${REVERB_HOST}"
VITE_REVERB_PORT="${REVERB_PORT}"
VITE_REVERB_SCHEME="${REVERB_SCHEME}"

supervisord.conf

[supervisord]
nodaemon=true
user=root
logfile=/var/log/supervisor/supervisord.log
pidfile=/var/run/supervisord.pid
minfds=10000
[program:php]
command=%(ENV_SUPERVISOR_PHP_COMMAND)s
user=%(ENV_SUPERVISOR_PHP_USER)s
stdout_logfile=/dev/stdout
stdout_logfile_maxbytes=0
stderr_logfile=/dev/stderr
stderr_logfile_maxbytes=0
[program:reverb]
command=php /var/www/html/artisan reverb:start --debug --host="<IP_ADDRESS>" --port=8081
autostart=true
autorestart=true
user=%(ENV_SUPERVISOR_PHP_USER)s
redirect_stderr=true
stdout_logfile=/var/www/html/storage/logs/reverb.log

Locally, everything works without any issues. The setup is identical to that on the server.
If you require any further information, please feel free to let me know. I'll try describe that for you.

@alexsyvolap we need a repo that reproduces the issue otherwise it's going to be hard to debug this.  Log in as<EMAIL_ADDRESS>in one browser and as<EMAIL_ADDRESS>in the other.
From the<EMAIL_ADDRESS>account, navigate to "Users" and start a "Chat" with the admin user. Ensure that the admin user remains on the Dashboard page.
If you send a message to the admin user from the<EMAIL_ADDRESS>account, you should receive a notification on the admin side.
If everything works correctly, run the following command:
sail php artisan reverb:restart

and repeat the steps to verify the functionality. After running the command, an error should appear.
If everything works correctly again, go to vendor/laravel/reverb/src/Servers/Reverb/Http/Server.php:58 and insert logger()->debug($request->getBody());. Then, run sail php artisan reverb:restart.
In my case, these two steps reproduce the error.

@alexsyvolap there's way too much code in that repo for us to review. I'm sure that not all of that is needed to demonstrate the issue. Could you please re-create the repo with the most minimum amount of changes needed to demonstrate the issue you're facing?

@driesvints I provided only a small part of what I have. I don't understand how much I need to shorten it to reproduce the problem. It exists now on this stack.

@joedixon the problem arises on the production environment from the beginning of the Docker container launch. Locally, I reproduce it as described above after restarting reverb.

Hey @alexsyvolap I was only able to recreate the issue when sending a message at the exact time the server was restarting. I was able to mitigate that by wrapping the broadcast in a retry - something like the following:
retry(5, fn () => broadcast(new MessageSent($message))->toOthers(), 500);

On a side note, it looks like your code is binding to the connected event in echo.js and so you will receive multiple events if the client needs to reconnect (such as when the server has been restarted).

I encountered the same error mentioned in this thread when running my Laravel + Reverb setup in production. In my setup, approximately 80% of the broadcasts would fail, while the remaining 20% succeeded.
Production Setup Details:
Both the Reverb and Laravel applications were configured behind a Cloudflare tunnel, which functioned as a reverse proxy. Here's how the setup was configured:

Reverb Container: https://reverb.example.com:443 (public URL) routes through Cloudflare Tunnel to http://reverb-container:80 (internal network).

Laravel App: https://laravel.example.com:443 (public URL) routes through Cloudflare Tunnel to http://laravel-container:80 (internal network).

Issue Description:
Initially, my Laravel application accessed Reverb at its public endpoint (https://reverb.example.com). It was under this configuration that I experienced the frequent broadcast failures as outlined in this issue.
Solution That Worked:
I resolved the issue by bypassing the Cloudflare tunnel for internal communications between Laravel and Reverb. Instead of using the public URL, I configured Laravel to access Reverb's internal URL directly (http://reverb-container:80). Following this change, all broadcasts were successful.
This configuration might suggest that there is an issue with how Pusher handles TLS.


Make does all by default

typing just make should only build our target.. right now it just makes all by default.
we should have this rule up at the top:
default: $(TARGETS)

Also default and all and hello are all .PHONY targets.

Acked. We will fix this later once we are done with hello world.

What is the status with this? Are we still seeing the same weird compilation order problems?

#44 addressed

#48 fixed this issue, we can close it now.

Closing this issue now


add renovate user test

Renovate is a large TypeScript project with over 11k GitHub stars. Not enough to make it into the top 100 TypeScript repositories on GitHub, although not far off! We frequently see issues with TypeScript updates. Most recently we hit microsoft/TypeScript#50479 with the upgrade to TypeScript 4.8. Here's a search for TypeScript upgrade PRs sorted by the number of comments.
Given the size and complexity of the Renovate codebase, as well as the frequency of issues we experience when upgrading TypeScript, I believe it is appropriate to include it in the test suite.

Thanks!

Unfortunately I'm going to have to back this out; it doesn't appear to work:
Starting #15 / 18: https://github.com/renovatebot/renovate.git
/home/vsts/work/1/s> sudo mount -t tmpfs -o size=4g tmpfs /mnt/ts_downloads
Cloning if absent
Cloning https://github.com/renovatebot/renovate.git into renovate
Installing packages if absent
Ignoring package install error from non-product folder test/e2e:
> Exited with code 1
> No stdout
> error "../../renovate-v0.0.0-semantic-release.tgz": Tarball is not in network and can not be located in cache (["/mnt/ts_downloads/renovate/renovate-v0.0.0-semantic-release.tgz","/home/vsts/.cache/yarn/v6/.tmp/c8dfa9055a0cda93989d5be6b4d41ff9/.yarn-tarball.tgz"])
/mnt/ts_downloads/renovate> yarn cache clean --all
yarn cache v1.22.19
success Cleared cache.
Done in 3.61s.

Testing with /home/vsts/work/1/s/typescript-53146/built/local/tsserver.js (new)
Killing process 3748 and its descendents: 3759
New server timed out after 600000 ms
Done https://github.com/renovatebot/renovate.git
Repo https://github.com/renovatebot/renovate.git had status "Unknown failure"
Cleaning up repo
/home/vsts/work/1/s> sudo umount /mnt/ts_downloads

I haven't looked into why, but, it's blocking us from seeing green changes.


rc: fix static build

rc: fix static build

rc: add static build into release.nix

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage

[ ] Tested basic functionality of all binary files (usually in ./result/bin/)

22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

@SuperSandro2000 Can you review, please?

Since it is very hard to find somebody to review change to release.nix, let's skip it. @SuperSandro2000 ?

Result of nixpkgs-review pr 152020 run on x86_64-linux 1

1 package built:

rc


[TASK] Configure PHPUnit to be more strict

This change brings the PHPUnit configuration in line with what we have at Emogrifier (except for the difference in the XSD version number).

coverage: 38.622%. remained the same
when pulling 77f9b0f7fcbd4a8e0dbd00c0c7969ec0e93ec40b on task/phpunit-configuration
into a5a1f1a088d7068446b6396fb8735eb8e1e26f15 on main.

Done and repushed.


Assigning an issue does not send an email if user's notifications are set to "Only on Mention"

Feature Description
It would be ideal if assigning a user an issue (as per #8233 and #8546) would be considered a "mention" for the purposes of sending email notifications.
Screenshots
No response

came across this too now. would be very helpful and users expect a notification email when they got assigned also if they've On mention setting enabled.


Theme Selector no longer present

Home Assistant release with the issue:

0.76.2
Last working Home Assistant release (if known):
Did not try in previous versions
Operating environment (Hass.io/Docker/Windows/etc.):

Hassbian
Component/platform:

https://www.home-assistant.io/components/frontend/#themes
Description of problem:
After adding a theme to my configuration, the option to change it does not appear under Configuration->General
Problem-relevant configuration.yaml entries and (fill out even if it seems unimportant):
# Enables the frontend
frontend:
  themes:
    test:
      primary-color: green

Traceback (if applicable):
N/A

Additional information:

Duplicate as #16043
Those features moved to profile page, please enable new with. If you don't want to that, you can still set theme by service.
New auth will be set enable by default, so we won't fix this issue.


fix typo in testlink readme

What this PR does / why we need it:
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
Special notes for your reviewer:

/ok-to-test
/lgtm

/approve

/approve
On Sunday 01 April 2018 02:14 PM, k8s-ci-robot wrote:

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: /scf0920
https://github.com/kubernetes/charts/pull/4565#/, /timstoop
https://github.com/kubernetes/charts/pull/4565#issuecomment-377772326/
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: prydonius
Assign the PR to them by writing |/assign @prydonius| in a comment when
ready.
The full list of commands accepted by this bot can be found here
https://go.k8s.io/bot-commands.
The pull request process is described here
https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process
Needs approval from an approver in each of these files:

stable/testlink/OWNERS
https://github.com/kubernetes/charts/blob/master/stable/testlink/OWNERS

Approvers can indicate their approval by writing |/approve| in a comment
Approvers can cancel approval by writing |/approve cancel| in a comment
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes/charts/pull/4565#issuecomment-377772328,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAZCIzmpjD3bf7_a8hDcLgrnrigcQYbvks5tkJOBgaJpZM4TCgIu.

--
Sameer Naik
w: http://www.damagehead.com e<EMAIL_ADDRESS>


Add option to shift ObsDataSources to end of month

This helps with comparing with our model because observations are typically defined on the 15th, but our model is defined at the end of the month. Since we always find the closest data available, this can lead to comparisons across months.

merged with https://github.com/CliMA/ClimaCoupler.jl/pull/927


How to encode audio with different settings?

Thank you for an amazing paper and OS release. I'm wondering how we can try different settings of the encoder decoder to test the quality of different number of code books for example. Do we need separately trained models for the different compression ratios or could you just provide some examples on how to do it?

Hello,
Thank you for providing your code!
Similar to ekgren, I was wondering how can I test different compression ratios and the impact on reconstruction quality.
My understanding is that the model needs to be retrained with a different setting for encoder and decoder rates (stride settings). Is that correct? If so, could you please provide more checkpoints for those different settings if available?
Thanks!
Mary

Different compression ratios can be passed in via the n_quantizers argument here: https://github.com/descriptinc/descript-audio-codec/blob/main/dac/model/dac.py#L268. This would be for the pretrained model. We currently don't have any other checkpoints trained, though, with different strides, but they may come if we have time and resources to train them!

Hey, thanks for the response!
I have tried between different numbers from 1 up to 9 (9 is the default setting if I am not mistaken) for n_quantizers. (--n_quantizers argument when encoding).
However, I cannot see any impact on the compressed .dac file, its size remains the same. I would expect the file size to change depending on the compression ratio. Am I missing something?
Cheers!

Different compression ratios can be passed in via the n_quantizers argument here: https://github.com/descriptinc/descript-audio-codec/blob/main/dac/model/dac.py#L268. This would be for the pretrained model. We currently don't have any other checkpoints trained, though, with different strides, but they may come if we have time and resources to train them!

In the script in the github readme  n_quantizers doesn't seem to change the compression ratio.
from dac.utils.encode import process as encode

# Encode audio signal
encoded_out = encode(signal, 'cuda', model, n_quantizers=n_quantizers)
print(encoded_out['codes'])

The codes returne are the same regardless of the number of n_quantizers put in.

@ekgren thank you for raising this issue
@marypilataki

However, I cannot see any impact on the compressed .dac file, its size remains the same. I would expect the file size to change depending on the compression ratio. Am I missing something?

Yes, this was a bug on our end. We have release a new version that works as expected.
Please update your dac installation.
pip install descript-audio-codec==0.0.3

@listener17  The default bitrate is 8kbps for the following command
python3 -m dac encode /path/to/input --output /path/to/output/codes

Great, thanks so much for the prompt response!


VC Interface Table dropdown UI blip

The dropdown increases in width when clicked causing table dimension to re render. It changes back again when deselected.

Fixed with #35


Tsch/win2025cns

Reason for Change:

Issue Fixed:

Requirements:

[ ] uses conventional commit messages

[ ] includes documentation
[ ] adds unit tests
[ ] relevant PR labels added

Notes:

pipeline changes diff. not needed to merge right now.


Add stacked section controller demo

Changes in this pull request
Adding a pretty basic stacked demo. 3 different sections, each with 3 child section controllers that handle an Int data.
Requires #354 to be fully functional (working range).
Closes #134
Pull request checklist

[x] All tests pass. Demo project builds and runs.
[x] I have reviewed the contributing guide

Coverage remained the same at 97.955% when pulling d520adedb88252946bb186a85b85d550603bca35 on stack-demo into 2957ee5feb5c827d72bb80021fb59e93aa702653 on master.

Coverage remained the same at 97.955% when pulling d520adedb88252946bb186a85b85d550603bca35 on stack-demo into 2957ee5feb5c827d72bb80021fb59e93aa702653 on master.

Coverage remained the same at 97.955% when pulling d520adedb88252946bb186a85b85d550603bca35 on stack-demo into 2957ee5feb5c827d72bb80021fb59e93aa702653 on master.


clarify dev setup instructions

see commit messages for explanations.

@kalvdans the review type says you left comments but I don't see any, do you have any comments about the PR?

@kalvdans the review type says you left comments but I don't see any, do you have any comments about the PR?

I checked the Approve radio button without writing any message. Seems github hides the approval status once the review is stale, so it ends up empty. So I better write something in the text box next time!


Update 1.0.0 scripts and readme

seems https://raw.githubusercontent.com/Microsoft/artifacts-credprovider/v1.0.0/helpers/installcredprovider.sh doesn't have the change? would you ship this version? @satbai

@karataliu you should be able to use this one: https://raw.githubusercontent.com/microsoft/artifacts-credprovider/master/helpers/installcredprovider.sh


feat(windows, ip-address): add ipAddress info to windows details

Overview
Add ipAddress information to netinfo details on windows platform
This is a straight copy from the device info package, as mentioned in https://github.com/react-native-device-info/react-native-device-info/issues/1387 and Fixes #580
Test Plan
Works for me locally in testing the netinfo example on windows, after release I nominate @thnszgns to confirm it works in practice

This is a copy/paste of working code from the device-info module so it should be at least good enough to release thus I will do so, but if any of @jfkm69 or @aschultz or @jonthysell has a chance to check it, chuckle at how I'm obviously a Windows C++ hack (Full disclosure: I am not actually good enough at Windows C++ to even be a hack, actually), and/or make it better, I'd be much obliged

:tada: This PR is included in version 8.1.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

I am sorry I can't confirm, I updated to 8.1.0 but I don't see ipAddress available in details.
details:
bssid: null
cellularGeneration: null
frequency: null
isConnectionExpensive: false
ssid: null
strength: null
wifiGeneration: null

Please triple-check that you have actually loaded the new code + bundle, check the example app if necessary (note the two windows-specific package.json run scripts for testing), this definitely worked for me locally using the example.

Sorry for my last message! I did a new build one more time and it worked! I am not sure what was the problem, I did the exact same thing as before.

Excellent news though! Probably sunspots, or solar particles ;-). Thanks for checking + confirming. This was my first react-native-windows code ever. Of course, just a copy/paste of already working code from somewhere else but the work simply to get to that point has been slow going for me, I'm pleased it works


add UnmarshalErrors()

solves #140

I signed it!

@google-admin Any chance this can actually get merged?


Question: How to disallow use of anonymous js function

Question: How to disallow use of anonymous js function
Say I don't want any function() {} in my code but only () => {}. How to force this (force ts-only)?

we haven't implemented this rule yet, but would like to have it. duplicate of #165


Primitive styles don't apply on the test page

On https://taniarascia.github.io/html5-test/ selecting the primitive stylesheet doesn't work. In the console I can see that https://taniarascia.github.io/primitive/css/main.min.css returns 404.

Thanks for this. I removed the minified version for now and forgot to update that!


Uncaught TypeError: Cannot read property 'layer' of undefined

Really excited by the prospect of using this, however I'm encountering a couple of issues.
I'm able to preview my rendered compositions within the AE Bodymovin Extension, however when attempting to view the animation within Chrome, either via the embedded demo.html or with my own page, I get the following javascript error within the console:
Uncaught TypeError: Cannot read property 'layer' of undefined
Attached is the data.json for the composition.
composition.zip
Note: The composition has other problems that eventually need to be solved (perhaps related to the current limitations of the Bodymovin extension, I don't know), but for now I'd at least like to understand why I can't view it in Chrome despite being able to preview it within the extension.

I think you're linking expressions to a composition that is not selected as part of the export: "_MainControlComposition"
To export extra compositions that are not in the Main comp render tree, you need to select the settings gear next to the comp, check Extra Comps and select the extra comps needed.

Yup, that's done it. However now I'm getting a different error, which I'll report as a separate issue.

Hello,
I am using duik plug in for rigging as well as 3d camera and whenever I try to export nothing
pops up in the demo.html file, I was wondering are these features supported?

Hi, can you share the .aep so I can take a look?


Timer Template Payload Extraction

Closing this PR in favor of another one that will be opened with the same changes


Update index.md

Line 16: Fixed sentence "But are these Pods running?" Changed to "But where are these Pods running?"
What this PR does / why we need it:
Fixes a typo
Which issue(s) this PR fixes:
Fixes #
Quality checks

[X] My content adheres to the style guidelines
[] I ran make test or make e2e-test and it was successful

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Thanks @rizblie that change makes sense!


Set Grafana IP in Docker Container

I'm not seeing how I can specify options to the grafana-reporter command using docker run.  What I'd like to do is setup an environment variable for the options to grafana-reporter so that they are picked up automatically in the container, without having to build and maintain my own docker image.  Is this possible but just undocumented?

FWIW, this is the same pattern that Grafana uses, see https://grafana.com/docs/installation/docker/#configuration for reference.
It could be that this is possible but I can't figure out, in which case some documentation would be great.  Either way, some notes in the README that explain how to set the IP in a docker container would be helpful.
Thanks for your work and your help!

To be honest the docker support was added by a community member via a PR. I don't use it in my production setup. I recall that is was possible to add commandline parameters somehow, but I can't rememeber the details now. When I test this PR (https://github.com/IzakMarais/reporter/pull/135) I will experiment a bit to see if I can figure something out.
I would suggest you experiment and also search through the repo history for the issues related to the PRs that added docker support.

I simply use the command as in the readme. This is already successfully passing an option, namely --help to the reporter.
docker run izakmarais/grafana-reporter --help

The same works for other cmd line options:
docker run izakmarais/grafana-reporter -ip localhost:1234
2019/07/18 07:13:44 grafana reporter, version: 2.1-0 hash: 997082a234c053fad981efaccf3f2332c6ba5ed2
2019/07/18 07:13:44 serving at ':8686' and using grafana at 'localhost:1234'


button design can be improved

@avinash201199 Can i work on this issue?

go ahead :)
don't forget to add screen shot of your changes in pr

Hi , I can improve the button designes by introducing some cool similar color effects in them , try to give me this task.
i asssure you that you will not regret after seeing those designes.

Please assign me this issue, I would like to contribute.


feat: Add ignore changes on tags["elasticbeanstalk:shared-elb-environment-c…

Description
Add ignore_changes to aws_lb.
Motivation and Context
To avoid this situation when we have a shared ALB with ElasticBeanstalk
  ~ resource "aws_lb" "this" {
        id                                          = "arn:aws:elasticloadbalancing:xxx:xxxx:loadbalancer/app/shared-alb/xxx"
        name                                        = "shared-alb"
      ~ tags                                        = {
          - "elasticbeanstalk:shared-elb-environment-count" = "1" -> null
            "terraform-aws-modules"                         = "alb"
        }
      ~ tags_all                                    = {
          - "elasticbeanstalk:shared-elb-environment-count" = "1" -> null
            # (4 unchanged elements hidden)
        }
        # (21 unchanged attributes hidden)

        # (5 unchanged blocks hidden)
    }```

Breaking Changes
No.
How Has This Been Tested?

[ ] I have updated at least one of the examples/* to demonstrate and validate my change(s)
[ ] I have tested and validated these changes using one or more of the provided examples/* projects

[x] I have executed pre-commit run -a on my pull request

do we know if this change works as intended? what are the downsides of ignoring this?

Hello,
I tested in my environment and I didn't see any regression.
This tag is describe here: https://docs.aws.amazon.com/elasticbeanstalk/latest/dg/environments-cfg-alb-shared.html
I saw no disadvantage in ignoring it because this tag is added by AWS when we implement a shared ALB in ElasticBeanstalk

This PR is included in version 9.2.0 :tada:


JSDoc Editting

@type -> @typedef

Before in Webstorm

After in Webstorm

Coverage remained the same at 100.0% when pulling dff6d36307501dbed299c637274e1372bb36380a on kanziw:edit-jsdoc-json2csvparams into 0980ef5fdbd27c072d32591db3c045704e53a950 on zemirco:master.

Thanks!


Domain activation is Failed - [BRIEF DESCRIPTION]

App Id: d3j2z1g8shkddr
Region: us-west-2
Step: Domain activation
Status: Failed
Issue/question
I had already an active CloudFront distribution and Route53 setup for my domain.
Earlier my static website was hosted from S3 and not I am using Amplify.
I disabled the existing distribution and removed all CNAME and A records and then initiated the amplify add domain. And i am getting this error.
Error message
One or more of the CNAMEs you provided are already associated with a different resource.
Additional information

Refer to our documentation to troubleshoot domain setup.
https://docs.aws.amazon.com/amplify/latest/userguide/custom-domain-troubleshoot-guide.html
https://docs.aws.amazon.com/amplify/latest/userguide/custom-domain-troubleshoot-guide.html#i-get-a-cnamealreadyexistsexception-error
Let us know if you're still facing issues.

@sanjeetiitr this can happen even if you've deleted the CNAME record from your DNS provider if the name is still associated with an existing cloudfront distribution, or if not enough time has passed since the removal. I just checked your app and both your www and root domain seem to be working now though, so I'll close this but feel free to reopen if you're still having issues.

Thanks @kahdojay . It worked after removing all existing CloudFront distribution.


no submodules

Job to build TF binaries
Update TODO comment
Remove unnecessary submodule checkouts

Turns out we mostly do need submodules because of lit and doing our own submodule checkout is not helpful. I'm going to postpone this


sync

Coverage remained the same at 89.695% when pulling 44fe4df6fc454102713486ef8384bf753d773f87 on fix_jwt into d2b7c4642f0d28634189d42648b2c58ee29f1a95 on develop.


Stub Compatibility?

What frameworks is this compatible with? Or what rats/stubs

Hello,
Please take a minute to read README


Improve GitHub workflows

Not sure why we need this

Not sure why we need this?

🤔 not sure why you don't know why we need this?


Reorder primary colors to align with figma draft

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@anitagraser can you click this link and accept the CLA?

@anitagraser can you click this link and accept the CLA?

Done


Effort readings from Gazebo are zero

When reading joint_state messages from simulation in gazebo, the effort values are always zero. This seems to be in turn because the call to GetForce(0) in lwr_hw_gazebo.hpp returns zero. The documentation even says it is not implemented.
Looking at https://bitbucket.org/osrf/gazebo/issues/1321/proper-joint-torque-feedback
it seems that indeed there are no proper torque measurements possible, some suggest using GetForceTorque(), the values of which would need to be projected to the joint axis.
This might only be an upstream bug but maybe it is good for reference. Do the included torque based controllers work at all in simulation?

Hi @kjyv
Yes, the problem is upstream.
Using GetForceTorque() and projecting to the joint axis is kind of workaround.
This happens when using position_controllers since there is no actual PID, but the position is set directly. This is because we didn't want to tune a PID for simulation, and in the real case, KUKA already did a great job with the joint position control.

Do the included torque based controllers work at all in simulation?

They should, let us know if they don't.

Ok, I guess you have to decide if you want a workaround to be implemented or not, but it seems that it is not going to be fixed in gazebo anytime soon (I think it's a bit ridiculous for such a big project).
I basically wanted to prepare my experiment with the real robot in simulation and noticed that it didn't give these measurements. They are being set fine from the hardware/frl, so I'm ok for now. I'm not using torque control at the moment, I was only interested in the torque readings, so I can't comment on that (Does the torque controller not use the torque readings?)
It seems to me though you focus more on the real robot even though for me the main benefit of this package seems to be the ability to transparently switch between simulator and hardware and getting similar results. For that though, a proper (tuned) PID controller is probably closer to reality, no? The kuka controller will have some delay in reaching a position, generate different velocities depending on the distance to the setpoints etc.

Nothing to add for now. If you are willing to add this functionality for the workaround, you are welcome.
I re-read the issue on bitbucket, and it seems that the workaround was not properly working either, and the PR was declined.

For that though, a proper (tuned) PID controller is probably closer to reality, no?

Yes, but you would need to have the exact dynamic values of the arm, match the PID gains from KUKA position control (nobody that I know has access), and expect it behaves exactly the same.
Conclusion, closing for now, but thanks for pointing out the issue with gazebo.