acbuild end accepts running as non-superuser, then fails because of that

Context
acbuild.sh:
#!/bin/sh
set -e
tear_down() {
    set +e
    status=$?
    acbuild end
    set -e
    return $status
}
trap tear_down INT TERM EXIT
set -x
sudo -v
acbuild begin
acbuild dep add 'quay.io/baselibrary/ubuntu:14.04'
sudo acbuild run -- "true"
acbuild set-name 'test/test'
acbuild write 'test.aci'

acbuild version 0.4.0
appc version 0.8.5

rkt Version: 1.22.0
appc Version: 0.8.9
Go Version: go1.7.4
Go OS/Arch: linux/amd64
Features: -TPM +SDJOURNAL

Linux #1 SMP PREEMPT Fri Dec 9 07:24:34 CET 2016 x86_64 unknown unknown GNU/Linux

Action
As user who is member of rkt group on an XFS filesystem:
sh acbuild.sh

Expected
acbuild end succeeds or reports error that it must be run as superuser, similar to acbuild run.
Actual
+ sudo -v
+ acbuild begin
+ acbuild dep add quay.io/baselibrary/ubuntu:14.04
+ sudo acbuild run -- true
Downloading quay.io/baselibrary/ubuntu: [======================] 88.1 MB/88.1 MB
+ acbuild set-name test/test
+ acbuild write test.aci
+ tear_down
+ set +e
+ status=0
+ acbuild end
end: remove .acbuild/currentaci/rootfs/usr/share/zoneinfo/Europe/Amsterdam: permission denied
+ set -e
+ return 0

Alternative case
The previous script with the image name and tag sudo acbuild end instead succeeds.

The reason that acbuild end doesn't error out when run as non-root is that it may be able to succeed depending on the permissions inside the image being built. The rkt getting started guide is one such scenario where root is not needed.
One option to make this nicer would be to walk over the image being built looking for files with permissions acbuild can't delete, but that would be expensive.
I think I'm just going to make a PR that, when a permission denied error is encountered, just prints out a line suggesting that acbuild end be re-run as root, which will at least provide a little direction to the user.

One nitpick though, please make it say ‘a user with appropriate privileges’ not ‘root’.


chore: update readme

:tada: This PR is included in version 1.1.2 :tada:
The release is available on:

GitHub release
npm package (@latest dist-tag)

Your semantic-release bot :package::rocket:


Github Android sample app url leads to a 404

"2. Access the sample app's GitHub repository."
Url update proposition : https://github.com/microsoft/appcenter-sampleapp-android

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: dd0fc568-48f7-a1a0-f0a8-fb72d931d071
Version Independent ID: bf93c8d7-7344-cc55-35b1-7b8ab740328a
Content: Getting Started - Visual Studio App Center
Content Source: docs/quickstarts/android/getting-started.md
Service: vs-appcenter
GitHub Login: @sshibu
Microsoft Alias: t-shshib

It looks like app-secret value is incorrect, please follow our Getting Started doc


add note about RBAC-enabled clusters

closes #3664
Note that this is basically a re-iteration of the admonition above, so if there's a way we can consolidate those admonitions, any feedback would be appreciated!

LGTM

I just had an idea: what if we linked to the kubernetes distribution guide instead, and then from there we noted that GKE has RBAC enabled by default?
The end result would be
IMPORTANT: See the Kubernetes Distribution Guide for any specific setup steps required.
IMPORTANT: If you are using a multi-tenant cluster where resources are shared, it is strongly recommended installing Tiller using a secured configuration. For guidance, see Securing your Helm Installation.
And then under GKE:
Google Kubernetes Engine enables Role-Based Access Control by default. For guidance, see the Role Based Access Control Guide.

I kinda want to incorporate that guide in the docs so we can keep that up to date

I think what I'l do is just update the distro guide with that RBAC note and put your suggestion in as well. Just so we have our bases covered.

Ok, let me know when you'd like me to review

@bacongobbler Did you still want to add this?

yes for sure! I'll make it a TODO for tomorrow. Thanks for the ping.
/remove-lifecycle rotten

this has been noted in the GKE distro notes, so we can close this.


41280: Expose new permissions : DeleteUserPermission and UpdateUserPermission

Rationale
As a follow on to this change, for completeness sake we build on the AddUserPermission and introduce

DeleteUserPermission
UpdateUserPermission

In addition, to help with external development of admin security roles, we've introduced a listener to allow the automatic addition of registered permissions to admin roles.
Related Pull Requests
https://github.com/LabKey/platform/pull/1496
Changes

add new permissions
update instances of UserManagementPermission to check for either DeleteUserPermission or UpdateUserPermission where appropriate
assign new permissions to AppAdminRole
add AdminRoleListener and RoleManager.addAdminRoleListener

It's possible (though not likely, honestly) that the old permission (UserManagementPermission) is serialized for webpart permissions in the database and/or folder archives. If you want, you can address this by implementing getSerializationAliases(), e.g., on UpdateUserPermission. See DesignSampleTypePermission as a random example of this.


Perks not shown when launching with expired token launch

Describe the bug
The app will sometimes not show any perks in the Tickets page.
To Reproduce
Steps to reproduce the behavior:

Open the app with an expired session token (of a barista account) stored.
The tickets page will show, but no perks are shown.
Restart the app to see the perks appear.

Expected behavior
Step 2 should show perks
Screenshots

Device (please complete the following information):

Device: iPhone 11 Pro
OS: iOS 17.2 beta
App Version 3.7 (282)

Additional context
Caused by backend issue https://github.com/AnalogIO/analog-core/issues/239

Fixed by https://github.com/AnalogIO/analog-core/pull/240


[Dropdown] minCharacters for remote content

Hi, I'm currently implementing a Dropdown with a remote content, however I noticed that dropdown doesn't have a minCharacters setting like Search, so once the dropdown is clicked, it immediately sends a query to the server with an empty search term. Here is my current settings for dropdown..
$('.ui.dropdown.search').dropdown({
            apiSettings: {
                url: url,
                onResponse: (response) => {
                    var results = $.map(response, (val, index) => {
                        return val;
                    });

                    var res = {
                        "success": results.length > 0,
                        "results": results
                    };
                    return res;
                }
            },
            fields: {
                value: value,
                name: name
            },
            onChange: function (value) {
                callback(value);
            }
        });

Seems like a low hanging fruit


Support translations mechanism

Pull Request Test Coverage Report for Build #54

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 93.237%

Totals

Change from base Build #53:
0.0%

Covered Lines:
193

Relevant Lines:
207

💛  - Coveralls


Hide unnecessary interface elements with Style Settings [FR]

Hello!
I do not feel comfortable working in programs whose interface is littered with different graphic elements, responsible for different functions that I do not even use.
I want to optimize my workspace so that it contains only the functions that I use and nothing unnecessary.
I would like the Style Settings plugin to allow you to disable the following interface elements for the Prism theme:

File Explorer Icon
New File Icon
New Folder Icon
Change Sort Order Icon
Current View (Read / Edit) Icon
Close Icon
More Options Icon

As an alternative solution, I considered:

Hider Plugin.
It does not allow you to hide these elements
Style Settings → Feature Toggles → Hide Note Titlebar
I managed to hide Current View (Read / Edit) Icon, Close Icon and More Options Icon with this function, but other unwanted interface elements are still there, which I do not like =(

Thank you so much and have a great day!
(And it would also be useful to be able to disable the Note Titlebar from popping up when hovering over the top of the workspace.)

Hi @nttldnknwn,
Prism doesn't really aim to hide elements of the UI but instead exaggerate them for increased clarity. I don't intend on implementing the suggested features. You might find another theme such as Shimmering Focus better for your needs. It specifically puts more focus on this type of minimalism.


Card tap doesn't push to forecast

Intended functionality: Open app - > click zone -> Card opens -> tap card --> intended zone opens
Current issue: Open app - > click zone -> Card opens -> tap card --> nothing happens
Details

This is happening for me very close to 100% of the time
I can swipe to other zone cards, click on other zones
EDIT: I cannot click on any buttons in the global nav (obs wx data etc totally non responsive) - all I can do is swipe the cards and click on other zone
I can tap the zone polygon a second time after the card is up and it will navigate to the zone
if I tap the card a bunch of times it will generally get there eventually - I can't find any pattern, sometimes it's the third tap, sometimes the 12th tap
the card sometimes appears reactive in that it becomes semi translucent when I tap but doesn't do the intended function
It happens whether it's the first time I've opened it or the 10th
If I force close the app and reopen it still happens

this is the same issue: https://mail.google.com/mail/u/0/#inbox/FMfcgzGwJSKLhNjVRZWSPRkpbltBzhXt

I think this one might also be: https://mail.google.com/mail/u/0/#inbox/FMfcgzGwHxxDtRvPGTChTgNFMFsfwhQc

@charlotteguard can you see what Android software you have running on your phone?  Settings → System → About phone → Android version.
I have been playing around to see if I can replicate on the emulator and havent yet, but there are lots of Android software versions and I am wondering if some of them are more different then others.

Avy version 1.0.4 (75)
Build date 2<IP_ADDRESS>.49
Git revision f1f7dbe
Update group ID 78a4aae0-34db-44c3-80f4-2c0f58d78aa4 (channel: preview)
Update ID 519a4e98-5210-46ed-ac05-00d3ec54836f (platform: android)
User ID 1fd60a1f-d34e-468d-b636-ffffe4e51ceb

@charlotteguard when you have a moment can you paste what you see when you click on "Software information"?

Thinking about this a bit more - it's certainly possible that the interaction to move the Google Maps layer around are done entirely in the native layer, while computing where we need to navigate and driving that animation are in JavaScript (even if the animation itself, once triggered, is native). So it may be that #658 is the singular root cause here - hangs in JS lead to parts of the app being unresponsive.


Update README.md

This is Seán (spcsrc) doing text cleanup of all our docs & descriptions, so we can be ready for our big debut at CC Summit.  README.md file first, then other files.

Re-applied small corrections as part of PR #131 which includes other small doc updates / corrections.


Deleting schemas only results in soft deletion of schemas

When we create and delete a schema using Terraform, it results in the "soft deletion" of the schema.
This is problematic for us, since the "soft deleted" schemas also count towards the "Free Schemas Limit" quota for the "Stream Governance Package" that we have.
Will it be possible to do a "permanent delete" on the schema,  something that is currently supported in the CLI with the  "--permanent" flag? Details can be found here.
Thanks in advance.

@linouk23 I'll answer your question from #124 here
I took a look at the Confluent Cloud UI and it is currently not possible to perform a hard delete for schemas there.
Especially since an "immediate hard-delete" can have serious consequences if it is carried out incorrectly, because the clients use the schema ID to serialize the data. After a soft delete, the data serialized with it can still be deserialized.
The [Guidelines] (https://docs.confluent.io/platform/current/schema-registry/schema-deletion-guidelines.html#guidelines-for-using-these-apis) give a few reasons when it might be useful to use the API.
I definitely agree that there needs to be a way to also delete soft-deleted schemas, but perhaps you should do this carefully via the CLI or with curl, since you definitely have no way of then deserializing the data again if you hard deleted it.
Another idea, which would be a feature request for the schema registry, might be to introduce a config that allows defining a point in time after which soft-deleted schemas are permanently deleted.

Thank you @S1M0NM! Given the feedback from https://github.com/confluentinc/terraform-provider-confluent/issues/124#issuecomment-1403584887 and https://github.com/confluentinc/terraform-provider-confluent/issues/179#issue-1556865092 it looks like it may be a good idea to perform a soft deletion by default but have an option to override if necessary. In other words, we're looking at a boolean flag enable_hard_deletion or something that defaults to true. How does it sound to you @S1M0NM @bluedog13?

Thanks.
As long as we have the ability to perform a hard delete (since it's supported in the CLI and we use it to clean up), it works.  Having a flag would also mimic the CLI behavior.

@linouk23 The flag is a good idea.
(sorry forgot that point in my comment)

I was just wondering whether a soft_delete flag would be possible, which is false by default.
Setting soft_delete to true will update the confluent_schema resource, which will do a soft delete on the schema, and removing the resource entirely will do a hard delete.

Another point, which is still a question for me, is how enable_hard_deletion behaves in connection with a schema update. Does this mean that if I update the schema attribute of the confluent_schema resource, the current one will be evolved and the previous version will be hard deleted?
cc @linouk23 @bluedog13

I was just wondering whether a soft_delete flag would be possible, which is false by default.

Sure. I'll take a look at naming conventions for naming boolean attributes so we could slightly rename it but yeah overall it sounds good to me.

Another point, which is still a question for me, is how enable_hard_deletion behaves in connection with a schema update. Does this mean that if I update the schema attribute of the confluent_schema resource, the current one will be evolved and the previous version will be hard deleted?

So there're 2 options:

if enable_updates is set to true then all previous version will still exist and there's no deletions at all.
if enable_updates is set to false then schemas will be hard / soft deleted (depends on the value of soft_delete flag).

How does it sound to you? cc @S1M0NM

@S1M0NM

I was just wondering whether a soft_delete flag would be possible, which is false by default.
Setting soft_delete to true will update the confluent_schema resource, which will do a soft delete on the schema, and removing the resource entirely will do a hard delete.

It looks like

I took a look at the Confluent Cloud UI and it is currently not possible to perform a hard delete for schemas there.
Especially since an "immediate hard-delete" can have serious consequences if it is carried out incorrectly, because the clients use the schema ID to serialize the data. After a soft delete, the data serialized with it can still be deserialized.
The Guidelines give a few reasons when it might be useful to use the API.
I definitely agree that there needs to be a way to also delete soft-deleted schemas, but perhaps you should do this carefully via the CLI or with curl, since you definitely have no way of then deserializing the data again if you hard deleted it.
Another idea, which would be a feature request for the schema registry, might be to introduce a config that allows defining a point in time after which soft-deleted schemas are permanently deleted.

implies that soft deletion by default is expected here so I'm thinking about enable_hard_deletion = false by default.

Setting soft_delete to true will update the confluent_schema resource, which will do a soft delete on the schema, and removing the resource entirely will do a hard delete.

Regarding this -- I think it's going to be a 2 step process: first just enable_hard_deletion is updated to true and then the next step is to remove a resource.

I prefer having "soft delete" as default and a flag for hard deletion (false as default like you mention above).
This keeps it inline with how we use CLI and will not causing confusion between folks who use both CLI and Terraform for automation.

Regarding this -- I think it's going to be a 2 step process: first just enable_hard_deletion is updated to true and then the next step is to remove a resource.

What would the workflow look like to first perform a soft delete on a schema to restrict its use for serializing new data and then completely (hard) delete it later after x days because there is no longer any data serialized with it?

What about hard_deletion which is false by default?

sounds good to me

It should not need to be 2 step process. This is reasonable, and makes sense in CI/CD environments:
hard_delete = var.enviroment == "dev" ? true : false

@dylanmei hmm I'll run an experiment but I'm pretty sure it'd have to be 2 step process -- see this

More specifically, there's a scenario where a user sets
hard_delete = true

and then comments out a resource to delete instead of running a terraform destroy -- this way TF Provider won't be able to read an updated value for hard_delete property (since it was commented otu) so it'd be using false (a value before an update) when deleting a resource wdyt.

What would the workflow look like to first perform a soft delete on a schema to restrict its use for serializing new data and then completely (hard) delete it later after x days because there is no longer any data serialized with it?

Hmm I'm not super sure so I might need your help here but it looks like first they'd delete it from TF config (by using a default value of hard_delete) and then they could go through our docs that describe how to run a hard delete via API (and CLI?)? Does it make sense to you @S1M0NM?

Hmm I'm not super sure so I might need your help here but it looks like first they'd delete it from TF config (by using a default value of hard_delete) and then they could go through our docs that describe how to run a hard delete via API (and CLI?)? Does it make sense to you @S1M0NM?

Hmm.. I'm not entirely sure about that.
One of my ideas went along the lines of a soft_delete flag, which is false by default.
Deleting the confluent_schema resource would always lead to a hard deletion of the schema.
If I want to soft delete the schema first, I set soft_delete to true and after a certain period of time I delete the entire resource from my Terraform Config, which then performs the hard deletion.
However, this procedure could have dangerous side effects if the deletion happens accidentally and you carry out the hard deletion as a result.
The idea of cleaning up yourself via the API could then be safer

I'm happy to announce that we've just released a new 1.27.0 version of TF Provider that supports hard_delete attribute (defaults to false). Find more details in the docs:

cc @bluedog13 @S1M0NM


Releaes drift detection

If something is released to staging, but not on prod for x amount of time

Duplicate of https://github.com/gimlet-io/gimletd/issues/44


RobColeLr GitHub Organization

Hi, I opened a GitHub Organization named as RobColeLr. I think What you did is great and may be it's time to have an organization that gathered everything he offered that we can redistribute. I already invited you and see if you're interested in transferring this repo under that umbrella (I can invite you as owner if you want).
I don't have much plan for it (e.g. I probably won't be looking into the code and start modifying it). But if the project gains traction, at least it would be a one-stop-shop for his legacy. And who knows, may be some developers would even start to continue from his legacy.

Done! I have moved my repository to your org


Two /workspace related issues

Three months ago, in the middle of August, I was able to successfully build an image using Pack and the Heroku images. However, I just tried to build a new image today, but was unable to run the application due to various issues related to the /workspace directory.
I'm primarily using the official PHP buildpack, so my error story is based on that. You can verify this with the Heroku getting started example: https://github.com/heroku/php-getting-started
However, I also got errors trying to build the Python getting started image, so I assume all buildpacks are affected by this.
Issue 1: $HOME is not set correctly
Immediately after building the example image, I am unable to start it.
$ pack build php-sample
[...]
$ docker run --rm php-sample
vendor/bin/heroku-php-apache2: line 260: php: command not found
This program requires PHP 5.5.11 or newer; check your 'php' command.

Checking the PATH inside the container, I see the following:
heroku@fb7a0fd3f366:/workspace$ echo $PATH
/home/heroku/.heroku/php/sbin:/home/heroku/.heroku/php/bin:/home/heroku/.heroku/php/sbin:/home/heroku/.heroku/php/bin:/home/heroku/.heroku/php/sbin:/home/heroku/.heroku/php/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/home/heroku/vendor/bin

Compare this to the PATH inside the previous, working application:
heroku@d384a0aaf899:~$ echo $PATH
/workspace/.heroku/php/sbin:/workspace/.heroku/php/bin:/workspace/.heroku/php/sbin:/workspace/.heroku/php/bin:/workspace/.heroku/php/sbin:/workspace/.heroku/php/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/workspace/vendor/bin

The large PATH is largely thanks to the PHP buildpack, which adds some search folders relative to $HOME. Which if you compare the old image:
heroku@d384a0aaf899:~$ echo $HOME
/workspace

Is indeed different from the new image:
heroku@fb7a0fd3f366:/workspace$ echo $HOME
/home/heroku

This appears to be a consequence of this change: https://github.com/heroku/pack-images/commit/28e9a2cda3d8025db0614a31326599821e0f467d#diff-6f2bd57d9bf5b098ff9f4b368b035e49L12
Issue 2: The /app symlink is missing
To fix the issue above, I built a custom version of the pack image which restores the homedir argument from the breaking change. This however lead me to a new version:
httpd: error while loading shared libraries: libaprutil-1.so.0: cannot open shared object file: No such file or directory
This program requires Apache 2.4.10 or newer with mod_proxy and mod_proxy_fcgi enabled; check your 'httpd' command.

Checking if this really is the case:
heroku@2af983eaebaf:~$ which httpd
/workspace/.heroku/php/sbin/httpd
heroku@2af983eaebaf:~$ ldd /workspace/.heroku/php/sbin/httpd
	linux-vdso.so.1 (0x00007ffc6f35e000)
	libpcre.so.3 => /lib/x86_64-linux-gnu/libpcre.so.3 (0x00007ff04ae08000)
	libaprutil-1.so.0 => not found
	libapr-1.so.0 => not found
	libpthread.so.0 => /lib/x86_64-linux-gnu/libpthread.so.0 (0x00007ff04abe9000)
	libc.so.6 => /lib/x86_64-linux-gnu/libc.so.6 (0x00007ff04a7f8000)
	/lib64/ld-linux-x86-64.so.2 (0x00007ff04b324000)

As you can see, some of the libraries are missing.
Comparing this to the previous image:
heroku@d384a0aaf899:~$ which httpd
/workspace/.heroku/php/sbin/httpd
heroku@d384a0aaf899:~$ ldd /workspace/.heroku/php/sbin/httpd
	linux-vdso.so.1 (0x00007ffcf9384000)
	libpcre.so.3 => /lib/x86_64-linux-gnu/libpcre.so.3 (0x00007f0fd4893000)
	libaprutil-1.so.0 => /app/.heroku/php/lib/libaprutil-1.so.0 (0x00007f0fd4669000)
	libapr-1.so.0 => /app/.heroku/php/lib/libapr-1.so.0 (0x00007f0fd4432000)
	libpthread.so.0 => /lib/x86_64-linux-gnu/libpthread.so.0 (0x00007f0fd4213000)
	libc.so.6 => /lib/x86_64-linux-gnu/libc.so.6 (0x00007f0fd3e22000)
	libexpat.so.1 => /lib/x86_64-linux-gnu/libexpat.so.1 (0x00007f0fd3bf0000)
	libcrypt.so.1 => /lib/x86_64-linux-gnu/libcrypt.so.1 (0x00007f0fd39b8000)
	libdl.so.2 => /lib/x86_64-linux-gnu/libdl.so.2 (0x00007f0fd37b4000)
	/lib64/ld-linux-x86-64.so.2 (0x00007f0fd4daf000)

As you can see, the HTTPD server as built by the PHP buildpack looks in the /app folder. But Cloud Native Buildpacks don't use the /app folder but the /workspace folder. And you can actually see that the libraries are correctly placed in the /workspace/.heroku/php/lib/ folder.
In the past, this worked because a symlink was created between /workspace and /app. But it appears that this change removed this symlink.
https://github.com/heroku/pack-images/commit/28e9a2cda3d8025db0614a31326599821e0f467d#diff-6f2bd57d9bf5b098ff9f4b368b035e49L3
Version Report
Pack: v0.5.0 (git sha: c9cfac75b49609524e1ea33f809c12071406547c)
Docker: Docker version 19.03.2, build 6a30dfca03
Run image: heroku/pack:18@b5c992735c7b
Build image heroku/buildpacks:18@eb25208e1361

@HansAdema I've merged #43 and published heroku/buildpacks:18. Can you confirm that this works now?
Thanks for your patience through the freeze.

Hi!
I believe this issue has been resolved for a while - since the PHP getting started guide builds/runs fine for me locally (it's also tested in CI now, albeit just that it builds/boots:
https://app.circleci.com/pipelines/github/heroku/pack-images/1703/workflows/bb24bf93-68fb-4e8b-9851-9c76ac7d4acb/jobs/34014).
I believe this was fixed via a combination of #43, #54 and potentially some of the improvements to cnb-shim.


How to process text longer than 248?

Could you please give an example of how to change the code? Many thanks.

This model can't handle the text longer than 248. You may finetune your own Long-CLIP model for longer text.
Specifically, you need to modify 'load_from_clip' function in 'model/longclip.py'. You may adopt a larger interpolation ratio (recommended) or lowers the keep_len.
Besides, there're other small points like the shape of 'mask1' and 'mask2' in 'model/model_longclip.py' need to be changed. These are simple.

Why is there a limit on token length? My understanding is that during the pre-training of the CLIP model, positional encoding was only done for a length of 77 tokens. The model does not have prior knowledge of positional encodings beyond this length. For longer token sequences, giving a larger interpolation ratio accordingly is, as I understand it, to make the model pay more attention to the tokens in the later positions. Thanks for your enlightening work. I wonder if my understanding is correct?

the positional embedding is directly added to the input embeddings, so the tokenizer will truncate the tokens longer than 77 in original clip since the positional embedding shape is (77, xxx)


Add git-lfs to container

Git large file storage should be present on the container by default.

Completed.


Do we still need the wiki resource page?

In preparation for the June convening, we aggregated a lot of resources at
https://github.com/OpenNewsLabs/newsroom-security-curricula/wiki/Existing-Resources we need to confirm that those resources were indeed migrated to  Chapter 3: Resources, and replace that wiki page with a note directing folks to  Chapter 3: Resources.

Can someone add me to the project so that I can grab this?


fixed prereq bug, made data for 10 years only

Coverage increased (+0.05%) to 97.059% when pulling 645f3c281ad686a7795013bc2f6759f25ae08d19 on cleanUpData into 1e8911ba484c3353cf6f4087bd36c9379e624ebc on master.

Coverage increased (+0.05%) to 97.059% when pulling fae2040cbbd79e9e7a7407a71eb58644324d7364 on cleanUpData into 1e8911ba484c3353cf6f4087bd36c9379e624ebc on master.

Coverage increased (+0.05%) to 97.059% when pulling 71aaa6c59495d3423f2525b340a53bfd7dff79ee on cleanUpData into 1e8911ba484c3353cf6f4087bd36c9379e624ebc on master.

Coverage increased (+0.05%) to 97.059% when pulling 57828c32f94f0127f2ccc11f74f9b4d105d3eb01 on cleanUpData into 1e8911ba484c3353cf6f4087bd36c9379e624ebc on master.

Coverage increased (+0.05%) to 97.059% when pulling 2a8f0779a90d911e8ab9591506f8e4650863df99 on cleanUpData into 1e8911ba484c3353cf6f4087bd36c9379e624ebc on master.

Good job, Rohit.

Coverage remained the same at 97.006% when pulling 43b0227c30177d4026f4b20d3f63ef5d3cd537da on cleanUpData into 1e8911ba484c3353cf6f4087bd36c9379e624ebc on master.


Create a timeline

Add the following information:
Best in Thesis: Corrective and Preventive Maintenance Application
Created Android version of Preventive Maintenance Application for A big company
Work Experience:
Service Desk Executive - From 2017 up to date


Namespace Envoy code

Envoy code currently occupies the global namespace which can cause collisions when integrating with third party code. Moving all of Envoy into a top-level namespace with reasonably low probability of collision (e.g. lyft) would fix that.

@tschroed is this theoretical? Or it's causing you a real issue? Just trying to figure out how urgent it is to fix this. Will need to automate and make it part of check/fix format flow.

Sadly, actual. Some collisions that I've run into already: proto = google::protobuf (can be fixed by changing a new short namespace name) and Thread.
I expect that we'd take on the work to update the code. Check/fix is an interesting consideration that hadn't occurred to me.

OK one interim option is to just fix the real collisions you have now while figuring out a better long term option. The two you mentioned should be simple.


Injection of current folder path into TypeScript file

I'm using nswag run /runtime:NetCore31 with the below nswag.json config file. In the settings for the openApiToTypeScriptClient code generator, when I added the value for extensionCode it does prepend the imports for the base classes to the file, but at the end of the file, just before the closing brace, it also injects a line of code that is the current file path (which results in code that doesn't work).
{
  "runtime": "NetCore31",
  "defaultVariables": "Configuration=Release",
  "documentGenerator": {
    "webApiToOpenApi": {
      "defaultReferenceTypeNullHandling": "Null",
      "defaultDictionaryValueReferenceTypeNullHandling": "NotNull",
      "generateAbstractProperties": false,
      "flattenInheritanceHierarchy": false,
      "generateAbstractSchemas": true,
      "generateKnownTypes": true,
      "generateXmlObjects": false,
      "ignoreObsoleteProperties": false,
      "allowReferencesWithProperties": false,
      "generateEnumMappingDescription": true,
      "alwaysAllowAdditionalObjectProperties": false,
      "generateExamples": false,
      "schemaType": "OpenApi3",
      "serializerSettings": {
        "referenceLoopHandling": "Ignore",
        "maxDepth": 2
      },
      "serializerOptions": {},
      "excludedTypeNames": [],
      "defaultPropertyNameHandling": "Default",
      "defaultEnumHandling": "Integer",
      "title": "API",
      "description": "",
      "version": "1.0.0",
      "allowNullableBodyParameters": true,
      "defaultResponseReferenceTypeNullHandling": "Null",
      "useControllerSummaryAsTagDescription": true,
      "defaultUrlTemplate": "{controller}/{id?}",
      "isAspNetCore": true,
      "addMissingPathParameters": false,
      "controllerNames": [],
      "assemblyPaths": ["../bin/$(Configuration)/netcoreapp3.1/bootstrap.dll"],
      "referencePaths": ["../bin/$(Configuration)/netcoreapp3.1/"],
      "output": "swagger.json",
      "outputType": "OpenApi3"
    }
  },
  "codeGenerators": {
    "openApiToTypeScriptClient": {
      "codeGeneratorSettings": {},
      "className": "{controller}Client",
      "generateDtoTypes": true,
      "generateClientInterfaces": true,
      "generateClientClasses": true,
      "generateOptionalParameters": false,
      "excludedParameterNames": [],
      "wrapResponses": false,
      "wrapResponseMethods": [],
      "generateResponseClasses": true,
      "responseClass": "SwaggerResponse",
      "template": "Axios",
      "promiseType": "Promise",
      "wrapDtoExceptions": false,
      "clientBaseClass": "BaseClient",
      "configurationClass": "ClientOptions",
      "useTransformOptionsMethod": true,
      "useTransformResultMethod": true,
      "baseUrlTokenName": "API_BASE_URL",
      "protectedMethods": [],
      "importRequiredTypes": true,
      "useGetBaseUrlMethod": true,
      "queryNullValue": "",
      "exceptionClass": "ApiException",
      "useAbortSignal": false,
      "httpClass": "HttpClient",
      "withCredentials": true,
      "rxJsVersion": 6.0,
      "useSingletonProvider": false,
      "injectionTokenType": "OpaqueToken",
      "moduleName": "MyApi",
      "namespace": "",
      "typeScriptVersion": 2.7,
      "dateTimeType": "Date",
      "nullValue": "Undefined",
      "exportTypes": true,
      "operationGenerationMode": "MultipleClientsFromOperationId",
      "markOptionalProperties": true,
      "generateCloneMethod": false,
      "typeStyle": "Class",
      "enumStyle": "Enum",
      "useLeafType": false,
      "classTypes": [],
      "extendedClasses": [],
      "extensionCode": "import { BaseClient, ClientOptions } from './base';",
      "generateDefaultValues": true,
      "excludedTypeNames": [],
      "handleReferences": false,
      "generateConstructorInterface": true,
      "convertConstructorInterfaceData": false,
      "inlineNamedDictionaries": false,
      "inlineNamedAny": false,
      "templateDirectory": null,
      "typeNameGeneratorType": null,
      "propertyNameGeneratorType": null,
      "enumNameGeneratorType": null,
      "serviceHost": null,
      "serviceSchemes": null,
      "output": "src/index.ts",
      "newLineBehavior": "Auto"
    }
  }
}

The command-line output looks like this:
> nswag run /runtime:NetCore31

NSwag NPM CLI
NSwag command line tool for .NET Core NetCore31, toolchain v<IP_ADDRESS> (NJsonSchema v<IP_ADDRESS> (Newtonsoft.Json v<IP_ADDRESS>))
Visit http://NSwag.org for more information.
NSwag bin directory: /home/drv/Repositories/path/node_modules/nswag/bin/binaries/NetCore31

Executing file 'nswag.json' with variables ''...
Done.

Duration: 00:00:01.9931161

The end of the generated typescript file looks like this:
/* tslint:disable */
/* eslint-disable */
//----------------------
// <auto-generated>
//     Generated using the NSwag toolchain v<IP_ADDRESS> (NJsonSchema v<IP_ADDRESS> (Newtonsoft.Json v<IP_ADDRESS>)) (http://NSwag.org)
// </auto-generated>
//----------------------
// ReSharper disable InconsistentNaming

import { BaseClient, ClientOptions } from './base';
import axios, { AxiosError, AxiosInstance, AxiosRequestConfig, AxiosResponse, CancelToken } from 'axios';

export module MyApi {

//... about 10,400 lines of typescript

function isAxiosError(obj: any | undefined): obj is AxiosError {
    return obj && obj.isAxiosError === true;
}

/home/drv/Repositories/path/
}

This problem is still occurring and can be replicated (100% of the time) on another developer's machine running Windows. I have a hacky workaround to the problem, but it would be great to have it fixed.
My package.json has the following scripts:
"generate": "nswag run /runtime:NetCore31",
"postgenerate": "node fix-index.js",

And then fix-index.js does the following:
const path = require('path');
const fs = require('fs');

/**
 * For some reason, when nswag generates the index.ts file, it is placing the current directory path
 * as the next-to-last line of the file, which is invalid javascript since it's like /home/...
 * This removes lines that start with a / not immediately followed by another / or a *
 */
function removeBadLineFromGeneratedFile() {
    const file = path.resolve(__dirname, 'src', 'index.ts');
    fs.readFile(file, 'utf-8', (err, data) => {
        if (err) throw new Error('Failed to read index.ts.');

        const inputLines = data.toString().split('\n');
        const outputLines = [];
        inputLines.forEach((line) => {
            if (line.toLowerCase().startsWith('c:') ||
                (line.startsWith('/') && (line.charAt(1) !== '/' && line.charAt(1) !== '*'))) {
                return;
            }

            outputLines.push(line);
        });

        fs.writeFile(file, outputLines.join('\n'), 'utf-8', (err) => {
            if (err) throw new Error('Failed to write index.ts');
        });
    });
}

removeBadLineFromGeneratedFile();

could it be caused by the extensionCode parameter? does it create that line without extensionCode? what about an extension file?

Yes, it creates the extensionCode at the top of the file to inject my import statement. I'm not sure about an extension file.
I just verified the problem still exists with the 13.10.5 version of nswag.

Indeed, but if I remember correctly, the extension code is split : the imports are placed at the top while the rest is placed at the bottom.
I suspect something is wrong here, as it's probably not-so-commonly used.
Could you try to remove the extensionCode property completely?

Yes, it is definitely using the extensionCode property that introduced the issue I reported. Another interesting thing is that on Windows, when it inserts the import statement it changes './base' to '\base' which is another bug.
I changed my usage to instead have the fix-index postgenerate script insert the import statement and I stopped using extensionCode.

Taking some inspiration from @jeremyVignelles... Adding // to the beginning of the extensionCode value resolved the issue.

Adding // to the beginning (or the end) didn't work for me... but adding /* fix bug */ to the beginning did. Resulting line for extension code looks like this:
"extensionCode": "/* fix bug */ import { BaseClient, ClientOptions } from './base';",

I suspect something is wrong here, as it's probably not-so-commonly used.

That's well possible as I also do not use this anymore... would need to be tested and fixed in NJsonSchema

I'm wondering why it is not fixed during 4 years :) ? And how is the NSwag usable at all if I cannot reference my custom code for token injection, etc.? This is important issue and it is 100% reproducible

@omykhayl we have been waiting for a brave soul like you who will implement it, please create a PR with the missing functionality.


Shot settings not refreshing after changing camera

I started indi server with indi_pylibcamera and indi_simulator_ccd.
When I change Camera on "Camera & focuser" tab, "Shot settings" should refresh acording too selected camera.
Before camera change:

After camera change:

Expected after camera changed:

I plan to support several cameras little later. Let the issue remain so as not to forget about it

Done


add missing undefine of ARCH_CPU_MIPS_FAMILY

@googlebot rescan

Thanks for the pull request and sorry we didn't get around to merging this before port/atomic_pointer.h was removed in 7d8e41e49b8fddda66a2c5f0a6a47f1a916e8d26.


Add support for SESSION_COOKIE_SAMESITE

Add support for the SESSION_COOKIE_SAMESITE configuration option as documented in https://flask.palletsprojects.com/en/1.1.x/config/#SESSION_COOKIE_SAMESITE
(note that this includes the .travis.yml changes from #51)

@mbr I understand you may not be maintaining this project anymore. Would it be possible to just merge this PR? This would help fix samesite attribute control.


fixes #40. Added function to parse decimal values

Coverage remained the same at ?% when pulling ab1efe30092d200116cf3610c8154f48a3ad4d0e on 40_decimalFIeld_missing_parse_value into e1f7d33a6e922ffde9203d13d78da4070e7a414b on master.


Provide a data sources for ListClusters, ListAvailableRegions and ListDatabases

Feature Request
Presently, there exists a way of fetching a cluster by a known id, however, there is no ability to fetch all clusters which exist.  It could be great to have a data source for doing this as it allows for more dynamic configuration whereby it is not possible to do this today.
What is the problem right now?
Currently, we need to define out the cluster ID's and set them to internal variables to check against, rather than being able to dynamically create and/or fetch a cluster and get the id value.
Use Case
In our development environments, we prefer to reuse a single cluster (it's wasteful to continually create new clusters for each development environment), therefore, we want to be able to dynamically check against the clusters configurations to check and see if we have a development cluster available or not and then we create different databases for each dev environment since they're utilized very infrequently.
Ideally this would provide back information about each cluster in a list, this method already exists within the go SDK which is the backbone for the terraform provider: ListClusters, likewise, the ListAvailableRegions would certainly aide in associating the proper regions for a cluster. Then we would like to be able to fetch the currently configured databases, this lets us know if we need to create one or not ListDatabases in the event we are sharing this database for a different stack, think of a situation whereby you are reusing the database to test out a hotfix / derived stack.

Hi @mwillbanks - thank you for writing this up and sharing. We have been focused on adding functionality by building out resources, now doing a review to look at adding some additional data sources. This will be very helpful for that. We will explore doing list data sources as you've suggested.


[pg] Segfault on select * from pg_type

Reproduce:

Run local ydb
echo "select * from pg_type" | psql postgres://root:1234@localhost:5432/local

stacktrace

yqlrun behaviour: Fatal: ERROR:  invalid cache ID: 42
crash should be fixed in the ydbd itself

https://github.com/ydb-platform/ydb/pull/2545

should be fixed by https://github.com/ydb-platform/ydb/pull/2524


ROCm 5.4.2 + Pytorch seems not working correctly on ubuntu 20.04.1

Environments:
Hardware: RX6600 XT
1 Ubuntu - 5.15.0-72-generic #79~20.04.1-Ubuntu SMP
2 Installed dkms, rocms by amdgpu-install 5.4.2, following this guidance:
https://docs.amd.com/bundle/ROCm-Installation-Guide-v5.4.2/page/How_to_Install_ROCm.html
3 Python 3.10.10
4 Install pytorch stable 2.0.0 for ROCm 5.4.2 from https://pytorch.org/
5 Already export HSA_OVERRIDE_GFX_VERSION=10.3.0
The GPU seems to work but if I look at the loss function result of a simple Linear Model, I find that the loss is quite different between CPU & GPU result. CPU loss is 20.36 while GPU is -2.26.
The negative loss seems not correct when running the simple model in GPU, but no sure which is the direction to try, switch to another pytorch  + ROCm version set or some simple configuration change? Please help!
Detailed information:
The program output is:

CPU model weights: Parameter containing:
tensor([[0.9534, 1.0810]], requires_grad=True)
GPU model weights: Parameter containing:
tensor([[0.9534, 1.0810]], requires_grad=True)
CPU loss: 20.36042022705078
GPU loss: -1.7142915703512032e+38
Weight difference: tensor([[0.0000e+00, 1.1921e-07]], grad_fn=)
Loss difference: 1.7142915703512032e+38

Full python code as follows:
import torch
import torch.nn as nn
import torch.optim as optim
torch.manual_seed(42)
class LinearModel(nn.Module):
def init(self):
super(LinearModel, self).init()
self.fc = nn.Linear(2, 1)
def forward(self, x):
    return self.fc(x)

input_data = torch.tensor([[1.0, 2.0], [3.0, 4.0], [5.0, 6.0], [7.0, 8.0]], dtype=torch.float32)
target_data = torch.tensor([[3.0], [7.0], [11.0], [15.0]], dtype=torch.float32)
cpu_model = LinearModel()
gpu_model = LinearModel().to("cuda:0")
gpu_model.load_state_dict(cpu_model.state_dict())
cpu_optimizer = optim.SGD(cpu_model.parameters(), lr=0.01)
gpu_optimizer = optim.SGD(gpu_model.parameters(), lr=0.01)
criterion = nn.MSELoss()
cpu_optimizer.zero_grad()
cpu_output = cpu_model(input_data)
cpu_loss = criterion(cpu_output, target_data)
cpu_loss.backward()
cpu_optimizer.step()
input_data_gpu = input_data.to("cuda:0")
target_data_gpu = target_data.to("cuda:0")
gpu_optimizer.zero_grad()
gpu_output = gpu_model(input_data_gpu)
gpu_loss = criterion(gpu_output, target_data_gpu)
gpu_loss.backward()
gpu_optimizer.step()
gpu_model.to("cpu")
print("CPU model weights:", cpu_model.fc.weight)
print("GPU model weights:", gpu_model.fc.weight)
print("CPU loss:", cpu_loss.item())
print("GPU loss:", gpu_loss.item())
weight_difference = torch.abs(cpu_model.fc.weight - gpu_model.fc.weight)
loss_difference = abs(cpu_loss.item() - gpu_loss.item())
print("\nWeight difference:", weight_difference)
print("Loss difference:", loss_difference)
rocminfo
HSA System Attributes
Runtime Version:         1.1
System Timestamp Freq.:  1000.000000MHz
Sig. Max Wait Duration:<PHONE_NUMBER>3709551615 (0xFFFFFFFFFFFFFFFF) (timestamp count)
Machine Model:           LARGE
System Endianness:       LITTLE
HSA Agents

Agent 1

Name:                    Intel(R) Core(TM) i7-10700K CPU @ 3.80GHz
Uuid:                    CPU-XX
Marketing Name:          Intel(R) Core(TM) i7-10700K CPU @ 3.80GHz
Vendor Name:             CPU
Feature:                 None specified
Profile:                 FULL_PROFILE
Float Round Mode:        NEAR
Max Queue Number:        0(0x0)
Queue Min Size:          0(0x0)
Queue Max Size:          0(0x0)
Queue Type:              MULTI
Node:                    0
Device Type:             CPU
Cache Info:
L1:                      32768(0x8000) KB
Chip ID:                 0(0x0)
ASIC Revision:           0(0x0)
Cacheline Size:          64(0x40)
Max Clock Freq. (MHz):   5100
BDFID:                   0
Internal Node ID:        0
Compute Unit:            16
SIMDs per CU:            0
Shader Engines:          0
Shader Arrs. per Eng.:   0
WatchPts on Addr. Ranges:1
Features:                None
Pool Info:
Pool 1
Segment:                 GLOBAL; FLAGS: FINE GRAINED
Size:                    16319152(0xf902b0) KB
Allocatable:             TRUE
Alloc Granule:           4KB
Alloc Alignment:         4KB
Accessible by all:       TRUE
Pool 2
Segment:                 GLOBAL; FLAGS: KERNARG, FINE GRAINED
Size:                    16319152(0xf902b0) KB
Allocatable:             TRUE
Alloc Granule:           4KB
Alloc Alignment:         4KB
Accessible by all:       TRUE
Pool 3
Segment:                 GLOBAL; FLAGS: COARSE GRAINED
Size:                    16319152(0xf902b0) KB
Allocatable:             TRUE
Alloc Granule:           4KB
Alloc Alignment:         4KB
Accessible by all:       TRUE
ISA Info:

Agent 2

Name:                    gfx1030
Uuid:                    GPU-XX
Marketing Name:          AMD Radeon RX 6600 XT
Vendor Name:             AMD
Feature:                 KERNEL_DISPATCH
Profile:                 BASE_PROFILE
Float Round Mode:        NEAR
Max Queue Number:        128(0x80)
Queue Min Size:          64(0x40)
Queue Max Size:          131072(0x20000)
Queue Type:              MULTI
Node:                    1
Device Type:             GPU
Cache Info:
L1:                      16(0x10) KB
L2:                      2048(0x800) KB
L3:                      32768(0x8000) KB
Chip ID:                 29695(0x73ff)
ASIC Revision:           0(0x0)
Cacheline Size:          64(0x40)
Max Clock Freq. (MHz):   2900
BDFID:                   1536
Internal Node ID:        1
Compute Unit:            32
SIMDs per CU:            2
Shader Engines:          4
Shader Arrs. per Eng.:   2
WatchPts on Addr. Ranges:4
Features:                KERNEL_DISPATCH
Fast F16 Operation:      TRUE
Wavefront Size:          32(0x20)
Workgroup Max Size:      1024(0x400)
Workgroup Max Size per Dimension:
x                        1024(0x400)
y                        1024(0x400)
z                        1024(0x400)
Max Waves Per CU:        32(0x20)
Max Work-item Per CU:    1024(0x400)
Grid Max Size:<PHONE_NUMBER>(0xffffffff)
Grid Max Size per Dimension:
x<PHONE_NUMBER>(0xffffffff)
y<PHONE_NUMBER>(0xffffffff)
z<PHONE_NUMBER>(0xffffffff)
Max fbarriers/Workgrp:   32
Pool Info:
Pool 1
Segment:                 GLOBAL; FLAGS: COARSE GRAINED
Size:                    8372224(0x7fc000) KB
Allocatable:             TRUE
Alloc Granule:           4KB
Alloc Alignment:         4KB
Accessible by all:       FALSE
Pool 2
Segment:                 GROUP
Size:                    64(0x40) KB
Allocatable:             FALSE
Alloc Granule:           0KB
Alloc Alignment:         0KB
Accessible by all:       FALSE
ISA Info:
ISA 1
Name:                    amdgcn-amd-amdhsa--gfx1030
Machine Models:          HSA_MACHINE_MODEL_LARGE
Profiles:                HSA_PROFILE_BASE
Default Rounding Mode:   NEAR
Default Rounding Mode:   NEAR
Fast f16:                TRUE
Workgroup Max Size:      1024(0x400)
Workgroup Max Size per Dimension:
x                        1024(0x400)
y                        1024(0x400)
z                        1024(0x400)
Grid Max Size:<PHONE_NUMBER>(0xffffffff)
Grid Max Size per Dimension:
x<PHONE_NUMBER>(0xffffffff)
y<PHONE_NUMBER>(0xffffffff)
z<PHONE_NUMBER>(0xffffffff)
FBarrier Max Size:       32
*** Done ***
rocm-smi
GPU  Temp (DieEdge)  AvgPwr  SCLK    MCLK   Fan  Perf  PwrCap  VRAM%  GPU%
0    35.0c           4.0W    800Mhz  96Mhz  0%   auto  135.0W    5%   1%

Hello, your issue is related to mine as well, where I was getting really odd things happening like negative losses (checked proper data and targets) and outputs being more than 1 or less than 0 even if it was softmax. The issue I think is Pytorch 2.0, I don't get the same issue in Pytorch 1.3. I was thinking of opening an issue in Pytorch's github page and I think you should too.
https://github.com/RadeonOpenCompute/ROCm/issues/2055

Hello, your issue is related to mine as well, where I was getting really odd things happening like negative losses (checked proper data and targets) and outputs being more than 1 or less than 0 even if it was softmax. The issue I think is Pytorch 2.0, I don't get the same issue in Pytorch 1.3. I was thinking of opening an issue in Pytorch's github page and I think you should too.
#2055

Thanks for the input, would try to switch to Pytorch 1.3
I tried switching to tensorflow with ROCm, a similar model runs well on tensorflow.
Looks like it is issue of Pytorch not ROCm, would close this one


Jupyter notebook not connecting to kernel

Issue Type: Bug
Unable to start session for kernel Python 3.8.5 64-bit ('rait_env': conda). Select another kernel to launch with.
This is the error I get while connecting to jupyter notebook. It was working before this VS code version / this python extension version.
Extension version: 2020.8.106424
VS Code version: Code 1.48.2 (a0479759d6e9ea56afa657e454193f72aef85bd0, 2020-08-25T10:09:08.021Z)
OS version: Darwin x64 19.6.0

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-8850H CPU @ 2.60GHz (12 x 2600)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmetal: disabled_offmultiple_raster_threads: enabled_onoop_rasterization: disabled_offprotected_video_decode: unavailable_offrasterization: enabledskia_renderer: disabled_off_okvideo_decode: enabledviz_display_compositor: enabled_onviz_hit_test_surface_layer: disabled_off_okwebgl: enabledwebgl2: enabled

Load (avg)
3, 2, 2

Memory (System)
16.00GB (0.12GB free)

Process Argv

Screen Reader
no

VM
0%

I've started experiencing experiencing a similar issue in the last few days. Bumping up the logging verbosity revealed the following error details for me:
{"jsonrpc": "2.0", "method": "output", "params": {"source": "stderr", "out": "ValueError: Invalid Signature: b'c4c679719d5545f008ddb84d858dd45780c7d50f6570ee9a7ef2ce57494ae904'\n"}}
Error 2020-09-06 23:22:52: Kernel died [r [Error]: [IPKernelApp] ERROR | Invalid Message

	at t._next ~/.vscode/extensions/ms-python.python-2020.8.106424/out/client/extension.js:54:782299)

...snip...

Info 2020-09-06 23:22:52: Python Daemon (pid: 20538): write to stderr:   File "~/.local/share/virtualenvs/staying-up-to-date-explorable-wnFYf23f/lib/python3.7/site-packages/jupyter_client/session.py", line 927, in deserialize

Info 2020-09-06 23:22:52: Python Daemon (pid: 20538): write to stderr:     raise ValueError("Invalid Signature: %r" % signature)

Info 2020-09-06 23:22:52: Python Daemon (pid: 20538): write to stderr: ValueError: Invalid Signature:

Trawling though my Pipfile.lock I noticed that traitlets had been upgraded from 4.3.3 to 5.0.3. (traitlets seems to be a dependency of jupyter-core)
Reverting to traitlets==4.3.3 resolved the problem for me

Where to view the logs?


Atom.Object.defineProperty.get is deprecated.

Eleven deprecation warnings are listed (such as the one below this text) and remote-sync (2.3.1) is not working with Atom 0.174.0:
atom.workspaceView is no longer available.
In most cases you will not need the view. See the Workspace docs for
alternatives: https://atom.io/docs/api/latest/Workspace.
If you do need the view, please use atom.views.getView(atom.workspace),
which returns an HTMLElement.
Atom.Object.defineProperty.get (d:\Users\dgarciava\AppData\Local\atom\app-0.174.0\resources\app\src\atom.js:55:11)
Object.activate (d:\Users\dgarciava\.atom\packages\remote-sync\lib\RemoteSync.coffee:62:9)

Same here - deprecation warning still there in Atom 0.177.0

Are these all fixed in version 2.4.0?

Yes, just downloaded 2.4.0, restarted Atom and the deprecation warnings disappeared. Thanks!


[SPARK-35884][SQL] EXPLAIN FORMATTED for AQE

What changes were proposed in this pull request?

This is a followup of https://github.com/apache/spark/pull/29137 , which has some issues when running EXPLAIN FORMATTED
AdaptiveSparkPlan (13)
+- == Final Plan ==
   * HashAggregate (12)
   +- CustomShuffleReader (11)
      +- ShuffleQueryStage (10)
         +- Exchange (9)
            +- * HashAggregate (8)
               +- * Project (7)
                  +- * BroadcastHashJoin Inner BuildRight (6)
                     :- * LocalTableScan (1)
                     +- BroadcastQueryStage (5)
                        +- BroadcastExchange (4)
                           +- * Project (3)
                              +- * LocalTableScan (2)
+- == Initial Plan ==
   HashAggregate (unknown)
   +- Exchange (unknown)
      +- HashAggregate (unknown)
         +- Project (unknown)
            +- BroadcastHashJoin Inner BuildRight (unknown)
               :- Project (unknown)
               :  +- LocalTableScan (unknown)
               +- BroadcastExchange (unknown)
                  +- Project (3)
                     +- LocalTableScan (2)

Some nodes do not have an ID and show unknown. This PR fixes the issue.
Why are the changes needed?

bug fix
Does this PR introduce any user-facing change?

EXPLAIN FORMATTED with AQE displays correctly.
How was this patch tested?

new tests

cc @allisonwang-db @peter-toth @viirya @maropu

Test build #140281 has started for PR 33067 at commit 8276021.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44812/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44812/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/44812/

Test build #140281 has finished for PR 33067 at commit 8276021.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140281/

Thanks! Merging to master.


chore: consume tslint via file

Testing

Trade-offs

Dependencies

Screenshots

:tada: This PR is included in version 3.0.23 :tada:
The release is available on:

v3.0.23
GitHub release

Your semantic-release bot :package::rocket:


Replace selection of the incrementer by string with enum

The selection of the incrementer is currently done by a string variable. To reduce the potential of typos replace it with an enum.

It would be nice to be able to pass a function as well. In that way, one can define a custom incrementer.

Similar to the formatter I could add the possibility to use a transformer from Info to String. What do you think?

sounds good, in that way everyone can change it to their liking


Whether to reuse the Sigmoid function in the confidence loss calculation code?

Pytorch.BCEWithLogitsLoss performs the Sigmoid operation, but the Sigmoid is reused in the model code. Is this a bug?
class TokenConfidence(nn.Module):
def __init__(self, dim: int) -> None:

    super().__init__()

    self.token = nn.Sequential(nn.Linear(dim, 1), nn.Sigmoid())  # sigmoid once

    self.loss_fn = nn.BCEWithLogitsLoss(reduction="none")  # sigmoid twice

I think this is a bug, I tried removing nn.Sigmoid in self.token and adding torch.sigmoid in forward(), but the results are almost the same. Have you tried?


Typescript typings

I develop in typescript a lot these days. We can add a typings file to this repo that doesn't interfere with the code but allows those who use typescript to take advantage of it.

:+1: added this to the planned features section


Fix detection of Construct games

SteamDB link to the game
n/a
What is it being detected as and what should it be detected as? Any other information?
Thanks for your work reviewing engines used on Steam!
Construct comes up as the 5th most popular engine on the engines list, but it looks like the detection merely comes down to this code:
		//If I have a package.nw file and it matches nodeJS, it's probably Construct
		if( $has( 'Evidence.PACKAGE_NW' ) && $has( 'SDK.NodeJS' ) )
		{
			return 'Engine.Construct';
		}

This won't be accurate: it will produce both false negatives and false positives. In particular not all Construct games even have a file named package.nw - this is optional in Construct.
An accurate way to detect Construct games is to look for a file named either c2runtime.js or c3runtime.js, in the main files (including searching in subfolders) OR inside package.nw (as Construct supports exporting with either packaged or unpackaged assets). The package.nw file is just a zip file, so it can be searched or extracted like any old zip file in order to look for the tell-tale files c2runtime.js/c3runtime.js (which again should include searching in subfolders).
So to be clear there are four cases that indicate a Construct game:

c2runtime.js anywhere in main files
c3runtime.js anywhere in main files
c2runtime.js anywhere inside a zip file named package.nw
c3runtime.js anywhere inside a zip file named package.nw

You can ignore any other signals, this alone should be reliable enough to identify Construct games. I think implementing this will produce a significantly different number for Construct... but I'm not sure whether it will be higher or lower! It would be interesting to see.

We did this and the matches for Construct decreased significantly, though we believe the count is accurate now at least in terms of not having false positives.
Do you have any other things that giveaway construct games?

Some limitations:

We cannot scan file content at all
neither can we unpack zip files.
All we can detect based off of is the filenames that are immediately present.

Based on this it looks like many construct games will not be detected as they cannot be distinguished from a vanilla node.js game. We can however detect Node.JS, so this is better than nothing. This is similar to the situation with HaxeFlixel -- it gives off no signature of its own, but every HaxeFlixel game is also necessarily a Lime/OpenFL game, so you can at least have an idea of where they might be based on that detection.

The default export settings in Construct will bundle everything in to package.nw. Unless you look in there, it is probably indistinguishable from anything else using NW.js. So unfortunately I think if you are not going to look in a zip file, you won't be able to meaningfully identify Construct games.

https://steamdb.info/app/827670/ is still detected as "Construct", even if it has a Сredits RPG Maker MW.html file in its main depot (https://steamdb.info/depot/827671/).

https://steamdb.info/app/827670/ is still detected as "Construct", even if it has a Сredits RPG Maker MW.html file in its main depot (https://steamdb.info/depot/827671/).

That's because https://steamdb.info/depot/827672/ has c2runtime.js. Also this issue should be closed, now that it's resolved. I've never seen a package.nw that didn't contain a c2runtime.js or c3runtime.js, but the system now works as suggested.


flutter doc has an unexpected >

doc -> Navigator class -> pages property
has an unexpected > in Implementation

final List> pages

but i review source code ,it's right

final List<Page> pages;

Hi, @darshankawar can you please provide the source code of this?
so I will change it and make PR.
Thanks.

hello @darshankawar  iam beginner here and i want to contribute in  this , can you please guide me in doing this.
thanks.

Here's how the html looks like:

    final
    List
    <page<dynamic>> pages</page<dynamic>

It happens in other places as well, here are some examples:

localizationsDelegates property
delegates property
Cupertino App actions property

So basically it's happening with the properties that have a type of the form A<B<C>> where <C> is being rendered as an HTML tag.


dont get playtoken at all.

hey tested it now with 4 different clients on EU and i dont get an playtoken at all
edit:
password & mail are correct , iam able to login on the website and with official launcher without problems.
no otp

is it possible to start the game on the official launcher? playtaken is the last step before starting the game, it's after u have successfully logged in.

yup its possible to start the game with the official launcher.

okay nvm starting the launcher => closing it => starting again worked. maybe something went wrong in the background.

cool, I tested it on my end just now and I was able to log in smoothly, I will leave this issue up for the next 12 hours, if you don't encounter the issue again I will then close it.


Correct typo for detecting Windows platform

This typo needed to be fixed so that DIGITS could automatically find Caffe in Windows platforms.

Whoops, that was sloppy of me. Thanks for the bug report. We don't have a CLA from you yet - can you send us one so we can accept this PR? Thanks!

Hi @lukeyeager. I have one doubt about the CLA. It asks to fill in information about the "Corporation", but in my case I did this contribution in my spare time, not during my work time, so I'd say that it's more a personal contribution than something done at work. How should I fill in that kind of information then? Thanks.

@lunzueta I believe that depends on your company policy. I'll let you figure it out and send us one filled out in whichever way you decide.

Looks like it's my typo.  Let me double-check other files.

I've just sent the CLA signed, after checking this question with my Institution. Thanks.


doesn't work with view ( createView mongo >= 3.4 )

in the namespaces with  doesn't work
any roadmap to implement views ?

In fact as in the oplog there is no view transaction of views its not possible to implement :D

As you noted MongoDB 3.4 views don't have any log of changes because they are read-only (non-materialized). mongo-connector cannot replicate changes to these views because those changes don't exist in the oplog.


Middleware not getting called

Describe the bug
The adminjs router is not executing middleware function. I am trying to log accesses to admin endpoints along with the details of the adminUser that executed them but it is not working.
Installed libraries and their versions

<EMAIL_ADDRESS><EMAIL_ADDRESS>
To Reproduce
Steps to reproduce the behavior:

Go to admin page for any database model
Open the console to check if the path was logged
There is no log

Expected behavior
The path and the adminUser must be logged
Screenshots
If applicable, add screenshots to help explain your problem.
AdminJSOptions with schema
Paste your AdminJS config with database schema if it could be related to the issue
Desktop (please complete the following information if relevant):

OS: Mac OS Ventura 13.1
Browser Firefox
Version 108.0.1

Additional context
Why is the middleware below not getting executed?

const adminbroRouter = AdminBroExpress.buildAuthenticatedRouter(
  adminBro,
  {
    authenticate: async (email, password) => {
      try {
        const account = await AuthService.getByEmail(email);
        if (!account) {
          return false;
        }
        const { password: accountPassword } =
          await AuthService.getPasswordByEmail(email);
        if (!(await isHashEqual(accountPassword, password))) {
          return false;
        }
        if (!AuthService.isAdmin(account as any)) {
          return false;
        }
        return account;
      } catch (error) {
        return false;
      }
    },
    cookiePassword: ADMINJS_COOKIE_PASSWORD,
    cookieName: ADMINJS_COOKIE_NAME,
    maxRetries: {
      count: ADMINJS_MAX_RETRIES_COUNT,
      duration: ADMINJS_MAX_RETRIES_DURATION,
    },
  },
  null,
  sessionOptions,
);

adminbroRouter.use((req, res, next) => {
  // Why is this not being called?
  console.log(req.path, req.adminUser);
  return next();
});

As far as I can see you're using the old version of AdminJS. Could you migrate to newest version and check if the issue persists?


Help installing pokemon journal

Hey i need help installing pokemon journal. I installed git and node software. I used git and cloned it to a folder on my computer. Iam now lost on how to do the setup where i install the software "cd pokemon-journal && npm install" .  so help on this would be much appreciated Thx

Instruction from this site might be useful.
http://www.pokemongoprotips.com/pokemon-go-hack-how-to-list-hidden-iv-stats-for-all-your-pokemon/

You can download a pre-built release here: https://github.com/billyvg/pokemon-journal/releases


Adding the merices table

Adding the merices table to the readme file
@yashasvini121 , please assign me under this issue !!!

This issue isn't needed at the moment. Please review the existing issues or open a new one, relevant to the project and AI/ML if necessary.


Update circe-core, circe-generic, ... to 0.14.6

About this PR
📦 Updates

io.circe:circe-core
io.circe:circe-generic
io.circe:circe-jawn
io.circe:circe-testing

from 0.14.1 to 0.14.6
📜 GitHub Release Notes - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "io.circe" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "io.circe" }
}]

labels: library-update, early-semver-minor, semver-spec-patch, version-scheme:early-semver, commit-count:1

Codecov Report
Patch and project coverage have no change.

Comparison is base (c9465e8) 100.00% compared to head (81da31b) 100.00%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more.
Additional details and impacted files
@@            Coverage Diff            @@
##            master      #224   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            2         2
  Lines           35        35
  Branches         2         2
=========================================
  Hits            35        35

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Superseded by #246.

Superseded by #249.


Home page enhancements

The Home could have some enhancements.

The background map might suit the web view but it's not suitable for the mobile view. What if we used another one instead?
The Threefold logo & title with the Threefold Connect look a bit repetitive and make this section look a bit crowded. What if we only used the Threefold Connect title instead?
The spacing between page sections is not consistent  (before and after the description)
Rephrase the description to a more engaging phrase highlighting the overall view of the app

WIP
working in 2 options and making sure it works fine with both mode
https://www.figma.com/design/Y17fOEbL8KLRkwzm9TqkBv/TF-Connect?node-id=0-1&node-type=canvas&t=4lDwyjajeeN6uCaL-0

option 1

option 2

option 1 with mock-up

For the opening text, I collect the benefits of ThreeFold Connect App from mannual
https://manual.grid.tf/documentation/tfconnect/tfconnect_overview.html
"The ThreeFold Connect app offers secure passwordless 2FA, decentralized access to the ThreeFold Network, a private wallet to manage TFT tokens, and a built-in support chat. Stay updated with the latest news directly in the app."

other option to keep BG and change the logo

verision 3.9.1
android 15
verified now the home page looks like this in the 2 styles

testcase

@khaledyoussef24
I can see the spaces are not equal before and after the description.
please check again in the latest version.


Enable usage from within script.

I have an application which cannot be started by flamegraph.
This PR adds the ability to use flamegraph easily within an existing program.
Drop the line flamegraph.start_profile_thread(fd=open("./perf.log", "w")) into a script and profiling will start.
start_profile_thread is a small convenience method that starts up a flamegraph.ProfileThread.
I changed it so that the writing of results happens either when the thread is stopped or at an atexit hook. Writing only happens once.

Looks great, thanks!


An example of saving attachments without signatures pictures would be great.

An example of saving all attachements WITHOUT saving signature pictures would be fantastic... there is like 100+ threads about this specific thing, and none of them work.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a38b2975-5eb6-1aa4-c1fd-d0f033ace5ca
Version Independent ID: 85899731-9939-a779-29c4-4da652667b74
Content: Run flows based on email properties - Power Automate
Content Source: articles/email-triggers.md
Service: flow
GitHub Login: @MSFTMan
Microsoft Alias: deonhe

Hi @spyrule. Thanks for your feedback. Can you please point me to a good example of the threads you mention so we can investigate this further? Thanks!

@hamenon-ms  Is saving attachments while excluding signature pictures supported, or should this be a feature request?

@spyrule -
Thanks for your feedback. We are closing this issue because we are either unable to find relevant information or reproduce this. If you're still experiencing the issue described here, please reopen or create a new issue.


Remove zone support

Here is removed acra-addzone tool, all zonemode related things from code, tests, benchmarks, docker files.
Some of interfaces updated to support extra data additional context to be able to use AD (additional data) in AEAD (authenticated encryption with additional data) encryption. It is not used for now but left args for future extensions if we will want. But it is discussible do we need to leave it now...
It's draft because there is remaining changes in our ./examples and acrawriter wrappers. But main removings already made.
P.S. I tried to split changes into separate commits due to a lot of changes.
Checklist

[ ] Change is covered by automated tests
[ ] The coding guidelines are followed
[ ] Public API has proper documentation in the Acra documentation site or has PR on documentation repository
with new changes
[ ] CHANGELOG.md is updated (in case of notable or breaking changes)
[ ] CHANGELOG_DEV.md is updated
[ ] Benchmark results are attached (if applicable)
[ ] Example projects and code samples are up-to-date (in case of API changes)

We decided to merge this PR in next release after deprecating Zones.
Additionaly, we should re-check our eng demos with these changes due to renaming several files in examples. Just a reminder for me.


Mod incompatibility with Wildfire's Female Gender Mod

Equipping the maid outfit and/or the tails results in the player's breasts becoming solid purple:

Mod in question: https://modrinth.com/mod/female-gender

Whoops, nevermind, didn't see issue: https://github.com/JheffersonMarques/KawaiiDishes/issues/16


Support the time zone component

Is your feature request related to a problem? Please describe.
Support parsing and encoding the time zone component. The initial version won't do any fancy date/time timezone lookups yet, but will instead just focus on getting the data model right.
Describe the solution you'd like
See https://www.rfc-editor.org/rfc/rfc5545#section-3.6.5 for implementation details

At the calendar level: Need to verify that tzid is unique across timezones.

For verifying tzif is working:

Look at a known time range rule and get an interesting set of test dates / offsets to verify
Implement a ZoneInfo implementation based on the underlying tzdata
Test original zoneinfo vs synthetic zoneinfo implementation (This is basically to confirm that the times are being implemented correctly)
Interpret/build zoneinfo rule for forward looking rules
May need to search for other interesting timezone record variations to know if we're implementing it right (e.g. bits set that are different from Los Angeles)


Cyrylica  error

When i to add URL on Cyrylica - on Russian language", i get error from validation URL.
https://wxm/кекеё5
Why do you make validation URL? I think than it need removed. Validation must don't be related with this lib.
Fatal error: Uncaught InvalidArgumentException: The location must be a valid URL. You have specified: https://wxm/кекеё5. in ...vendor\samdark\sitemap\Sitemap.php:243 Stack trace: #0 ...vendor\samdark\sitemap\Sitemap.php(297): samdark\sitemap\Sitemap->validateLocation('https://wxm..')
...vendor\samdark\sitemap\Sitemap.php(272): samdark\sitemap\Sitemap->addSingleLanguageItem('https://wxm_...',<PHONE_NUMBER>, 'weekly', 0.3) #2
.../index.php(13): samdark\sitemap\Sitemap->addItem('https://wxm/...',<PHONE_NUMBER>, 'weekly', 0.3) #3 {main}
...vendor\samdark\sitemap\Sitemap.php on line 243

I fixed https://github.com/samdark/sitemap/pull/58
If exsisx opportunity,  write me down as an assistant/contribute )

OK. I'll check it.

Going to remove validation overall soon.


Use service type ClusterIP by default

What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #373 #206
Not sure if this will break post-submit test. Please correct me if I miss something I don't know.
With this fix, clusterIP svc url can be used for prediction. If //github.com/kubeflow/fairing/blob/master/examples/prediction/xgboost-high-level-apis.ipynb is tested in the same kubernetes cluster, it should work.
Release note:

Use service type ClusterIP by default

This change is

See my comments in #372 I remember that's have long discussion for service_type before. Generally user would like to use the service as a public service by default, not ClusterIP. I think we should only make ability to let user set the service_type. agree?

@Jeffwan by the way, if you changed the service_type to ClusterIP, I think the some test case prediction will be failed unless you set that as in option.

@jinchihe Hi Jinchi, I don't know the context. I looked at issue https://github.com/kubeflow/fairing/issues/206 and seems this issue mentioned fairing should not expose public endpoints. Not sure if that's still true or not.

"Generally user would like to use the service as a public service by default, not ClusterIP."
If this is the case, we can close above issue and I can revert changes for #206

I need endpoint change if user specify clusterIp. This is for #373

@Jeffwan I think if we update the service_type, the tests that called the examples/prediction/xgboost-high-level-apis.ipynb will not work, unless we also update the examples to point to the service type to Loadbalancer.
Now I'm thinking if we can use istio to route the fairing service?

@Jeffwan I think if we update the service_type, the tests that called the examples/prediction/xgboost-high-level-apis.ipynb will not work, unless we also update the examples to point to the service type to Loadbalancer.
Now I'm thinking if we can use istio to route the fairing service?

Yeah. If this has to be a public endpoint, as community move to istio based routes. Ingress is definitely a better option than Loadbalancer. This should be an improvement task,
In the PR, I think maybe I can just leave this change url = "http://{0}.{1}.svc.cluster.local:5000/predict".format(? This is a definitely a bug blocking users to user clusterIP.  I will revert all rest changes changing to ClusterIP. What do you think?

@Jeffwan Rechecked the code, for the PredictionEndpoint supports set the service_type now, I think that's OK to change the service type to ClusterIP as #206 logged.
Could you also please update the service type in class PredictionEndpoint to ClusterIP,
https://github.com/kubeflow/fairing/blob/7d7e9d15d507b4b07e50249fd6b7a5878806122f/kubeflow/fairing/ml_tasks/tasks.py#L86
and update the examples/prediction/xgboost-high-level-apis.ipynb to set the service type to LoadBalancer? Thanks.

@jinchihe Sure. I will make the change.

@jinchihe test pass and please have another check

/lgtm
/approve


[admin] Switch to organization membership helpers #142

Closed issue by optimizing organization membership check
with organization membership helpers.
Fixes #142

Coverage decreased (-0.02%) to 97.243% when pulling d2d37f99d96de0b061adfe05587a49ee4230c687 on issue-142-switch-organization-membership into 0c77bce86c89a8e64859c74b56eeff01f5d0e9e0 on master.


Crop polygon properly

Motivation and context

Resolve #2992
How has this been tested?

Manually
Checklist

[x] I submit my changes into the develop branch
[x] I have added description of my changes into CHANGELOG file
- [ ] I have updated the documentation accordingly
[ ] I have added tests to cover my changes
[x] I have linked related issues (read github docs)
[x] I have increased versions of npm packages if it is necessary (cvat-canvas,
cvat-core, cvat-data and cvat-ui)

License

[x] I submit my code changes under the same MIT License that covers the project.
Feel free to contact the maintainers if that's a concern.
[x] I have updated the license header for each file (see an example below)

# Copyright (C) 2021 Intel Corporation
#
# SPDX-License-Identifier: MIT

Coverage increased (+0.04%) to 75.008% when pulling a771ac839c80e5e53c324b888d651e18993418d0 on az/fix_crop into 57385fa762d6db0f273b964faa18afd6ff0ace60 on develop.

Hi @dvkruchinin
Need a test for this bug. Let me know if you need any assistance.


Failures on Reland "Implementation of evaluation to JS in frontend server"

There are new test failures on filtering on kinds; relevance boosting...Reland "Implementation of evaluation to JS in frontend server".
The tests
pkg/frontend_server/test/src/expression_compiler_test RuntimeError (expected Pass)

are failing on configurations
unittest-asserts-release-win

@annagrin, when opening an issue, can you assign it an area- label (if you know the right area)? That'll make the job of the issue triages easier; thanks!


Allow filter to be passed in ElasticKnnSearch knn_search and knn_hybrid_search

You can pass filter to an kNN in elasticsearch.
This is currently implemented in the langchain wrapper in the exact KNN search.
But is not yet implemented in the approximate KNN search.
Add filter param to _default_knn_query, knn_search, knn_hybrid_search.
cc: @jeffvestal, @derickson
Suggestion:
No response

Solved by ElasticsearchStore implementation


[Feature request] Add support for i128 and u128

Since both Rust and Elixir have support for 128-bit sized integers (i128, u128, erlang) it seems natural that Rustler should support it as well.
I have a specific use case for i128s as well, which is implementing support for the Decimal type from Polars in Explorer.

I can't really figure out if this is going to be a problem, but at least it's something to be aware of.

Would this work for you: https://github.com/rusterlium/rustler/tree/master/rustler_bigint ?

I can't really figure out if this is going to be a problem, but at least it's something to be aware of.

I don't think this is relevant for Rustler. It would be, if the NIF API actually included (C-based) support for 128-bit integer types, but it only supports up to 64.
If someone wants to work on this, https://github.com/rusterlium/rustler/tree/master/rustler_bigint can be taken as a basis. While that library is more general and implements support for arbitrarily-sized integers, the same approach (going via the term_to_binary) can be used for the standard library types i128 and u128.

I have not had time to look at the bigint library yet, but it indeed seems like the easiest way to handle something like this.

Implemented in #600.

Incredible! Thank you for your work @filmor!


Clean up files from gradle transition

Remove unused files and folders
Remove duplicated /java/main (app would still work, just threw up a load of useless errors in IDE) to fix compiler warning explained in #88

This PR is compatible with #121

Thanks!


Controller for table browser requests

Create a controller for the data service which handles the request and responses for table browser in the GUI

commit 2dcba48a6a1bc64fac1a84abc674253ca9efc8f5


Issues with MediatR 10.0 or did I implement incorrectly?

I upgraded to MediatR 10 and the following code is broken and throwing me the following error. It made me think that all the while I have been using MediatR incorrectly or there is something else is wrong? I'm able to use MediatR 9.0 with no problems - it all works well. :)

Severity	Code	Description	Project	File	Line	Suppression State
Error	CS0311	The type 'ExpenseCategoryDeleteRequest' cannot be used as type parameter 'TRequest' in the generic type or method 'IPipelineBehavior<TRequest, TResponse>'. There is no implicit reference conversion from 'ExpenseCategoryDeleteRequest' to 'MediatR.IRequest'.	xxx.Api	C:\Test\MediatrPipelines\MastersMediatrPipeline.cs

My code as follows:
ExpenseCategoryDeletePipeline
public class ExpenseCategoryDeletePipeline<TRequest, TResponse> : IPipelineBehavior<TRequest, TResponse>
        where TRequest : ExpenseCategoryDeleteRequest
        where TResponse : CommandResponse
    {
        public ExpenseCategoryDeletePipeline()
        {
        }

        public async Task<TResponse> Handle(TRequest request, CancellationToken cancellationToken, RequestHandlerDelegate<TResponse> next)
        {
            return await next();
        }
    }

ExpenseCategoryDeleteRequest
    public class ExpenseCategoryDeleteRequest : IRequest<CommandResponse>
    {
        public int ExpenseCategoryId { get; set; }
    }

CommandResponse
    public class CommandResponse
    {
        public string Success { get; private set; }
    }

The Registration is done at MastersMediatrPipeline.cs
services.AddScoped(typeof(IPipelineBehavior<ExpenseCategoryDeleteRequest, TResponse>), typeof(ExpenseCategoryDeletePipeline<ExpenseCategoryDeleteRequest, TResponse>));

Looks like there are breaking changes mentioned here in the Migration Guide and refer to this question.
I have more than 200 pipelines that require a change on MediatR 10.0. Can I get a sample using my above code on how to implement this change correctly without breaking too many things?

That part at the bottom should help? For open generics you need to add the additional constraint. Not sure why C# isn't smart enough to infer it.

Awesome - that works.


feat: add generate edi template

I think we need a README.md to describe the input structure, what the function does, and an example of how to call the function via cURL. Otherwise I don't think our typical developer will be able to self-service.
The event type on the handler is unknown, which doesn't help the reader understand the input structure. I think we need a comment at the top of the handler that points the user to the data shape, or points them to the readme that describes the data shape.

Sounds good, I was planning to do a follow-up with a README and will include details on the input structure as well as an example for invoking. Wanted to get the template in shape to deploy alongside a customer tomorrow, so didn't tackle the README yet


[Bug]: Dropped files is not displayed in File picker pop up when widget is moved outside the container

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior

Steps To Reproduce

Drag and drop a File picker widget
Add any file
Upload the file
Now drag and drop the file picker from container to canvas
Click on file picker
Observe that uploaded file is not displayed

Environment
Production
Version
Cloud

This problem is not actually faced by the app viewers, This is not of priority,
@techbhavin can you explain what change are you making in the PR?

Closing this off now now, this DX is not relevant and the changes made is costing us time, closing the PR as well right now