Volumetric Fog stops working when enabling shadows for omnilight or spotlight

Godot version
v4.0.dev.calinou [5db1f8b1a]
System information
Mx Linux (Debian Based)
Issue description
When enabling shadows for an omnilight or spotlight, volumetric fog stops working.
Steps to reproduce
Add environment
Enable Volumetric Fog
Add Omni Light (Make sure that its contributes to the Volumetric Fog)
Enable Omni Light Shadow
Fog stops working (or at least the light stops contributing)
https://user-images.githubusercontent.com/1168582/125146568-ce276200-e0fc-11eb-8bda-d60e87cba1d5.mp4
Minimal reproduction project
There is no reason to add minimal project since once the light's shadow is enabled it never contributes to the fog again even if the shadow is disabled. So all steps must be done to reproduce the issue.

I couldn't reproduce this with OmniLights yesterday, but I couldn't get SpotLights to display in volumetric fog (even though there were no error messages).

I can confirm the issue on both OmniLights and SpotLights on v4.0.dev.custom_build [e3744d2fe]
Note - SpotLights are much more difficult to see the effect of Volumetric Fog, try to view them with black sky (custom color) that might help, unless it's a bug.
Also Shadows cannot be turned off for both of those, not sure for directional, I'm not sure if this is a Known issue atm.

Also Shadows cannot be turned off for both of those, not sure for directional, I'm not sure if this is a Known issue atm.

Disabling shadows for point lights will only apply once you reload the scene. I think this has been reported elsewhere already.

@Calinou I can confirm this for Point Lights but not for Spot Lights. For some reason the fog still broken even if I reload the scene

This may have been fixed by https://github.com/godotengine/godot/pull/53353

I can't reproduce this on commit 9d1626b4d. However, I can reproduce a similar issue but only for SpotLight3D (and not OmniLight3D): https://github.com/godotengine/godot/issues/57722

Please open a new bug report as this is a separate issue, it causing the same problem means it's a new issue having the same effect

https://github.com/godotengine/godot/issues/83685


Switch to downloading CUDA host tools from NVIDIA's deb package feed

NVIDIA recently added and/or documented host (x86-64) package feeds for the CUDA tools. We can use these instead of requiring SDK Manager downloads and the NVIDIA_DEVNET_MIRROR setup.

Thanks @madisongh I've updated https://github.com/OE4T/meta-tegra/wiki/L4T-Integration-Issues and https://github.com/OE4T/meta-tegra/wiki/NVIDIA_DEVNET_MIRROR-and-SDK-Manager on the wiki.

Well done guys.


Update to Xcode 9 / Swift 4

Hey!
This PR is basically gardening for Xcode 9 - it sets all recommended by Xcode settings, as well as setting Swift version to 4.0 on all targets, including .podspec file.
It also changes APPLICATION_EXTENSION_API_ONLY to NO on iOS target, because iOS target uses UIApplication.shared accessor, which is disallowed in app extensions.
After those changes all targets compile, and iOS target tests run successfully. macOS and tvOS tests are failing due to issues that are unrelated to current PR, so they can be looked into separately.
Change in podspec file will also allow to not have warnings about Swift 4 migration in Xcode when using CocoaPods installation method(after next submission to Specs repo with new version).

Cool, thanks for contributing, would you want to join the team?

Sure, why not =) I don't know how much I would be able to contribute because of other OSS and projects on work, but I use this framework in one of my projects, and being a user of framework definitely makes it easier to contribute.


internal/callfn error when running main.go file

Hi, @xlab
I  try go run main.go but got this error:

Please help.

You cannot run android apps on desktop, should deploy them on device using commands from Makefile

Hi, @xlab.
Unfortunatelly I don't have android device but was hopping to generate apk file to run somewhere in cloud, VM etc.

@r3mb00 the makefile generates an APK artefact. You then decide what to do with it. You don't need a device to comopile the app, however go run is not enough.

@xlab I did ANDROID_HOME=path/to/sdk ../build-android.sh" to build an APK ready for deployment from Minimal Go app page but couldn't find apk.
I search all directories and subdirectories but found nothing did I do something wrong ?

You have to get the android sdk and ndk. The easiest way to do that is installing Android studio and getting it through the package manager in Android studio. It also comes with Android emulators you can test the built apk out on.

@Noofbiz thank you for the help.
I installed Android Studio and NDK with the SDK Manager sd you adviced:

@Noofbiz @xlab what next should I do?
Can you help please ?


audit.yml uses a deprecated Node.js version

https://github.com/tauri-apps/global-hotkey/actions/runs/10813047242


Provide a way to have jbuilder stop climbing the file system.

We have had a couple of issues with dependencies that use jbuilder to build themselves for our offline workflow. The reason is that we compile our dependencies in a local sandbox of our current project - and that sandbox resides within the current directory. When building one of those dependencies that has a jbuild-workspace.dev, apparently jbuilder will climb out of that sandbox and try to find the highest jbuild-workspace file and begin building from there (which is the wrong location). If every package were to make their build command specify --root ., then it wouldn't be an issue but we cannot control what other packages have as their build command.
Request: At least provide a way to prevent jbuilder from climbing higher. We can drop a dummy file in the local build sandboxes if that it something jbuilder would pay attention to. Something like jbuilder-stop-climbing, perhaps.
https://github.com/esy-ocaml/esy/issues/22#issuecomment-342205483

At least partly related to discussions in #234 and also https://github.com/janestreet/jbuilder/issues/240#issuecomment-325299995


Investigate Fleet API

Investigate integration with Fleet API: https://developer.tesla.com/docs/fleet-api

[ ] Consider the new vehicle command SDK (#7)
[x] How to deal with Fleet API only referring to vehicles, and not other products.
[ ] Ensure existing OAuth token flow still works. We don't want to lock users into the Fleet API.
[ ] Investigate OAuth flow differences, and plan an API that can work with the Owner API as well as Fleet API.

[ ] Handle Authorization Scopes
[ ] Investigate the uses of public key authentication.

[ ] Check if there are differences in the endpoints. A quick look seems the same so far, except for the domains.
[ ] Support multiple regions.
[ ] Check terms for anything that they don't like that this project might do.
[ ] Rate limit considerations. The docs specify certain rate limits and should be accounted for and handled.

How to deal with Fleet API only referring to vehicles

Multiple traits added in #8


Sim freezing

XP is freezing a lot. I don't know if this is related but there is a lot of this in log.txt
2:44:37.039 D/TEX: DDS file Custom Scenery/z_na_07/textures/100080_75792_BI18.dds is missing 32 bytes of low mips
2:44:37.362 W/TEX: DDS file Custom Scenery/z_na_07/textures/24992_18944_BI16.dds declares 11 mips, provides 11 mips, we expected 13 mips
2:44:37.362 D/TEX: DDS file Custom Scenery/z_na_07/textures/24992_18944_BI16.dds is missing 32 bytes of low mips
2:44:37.564 W/TEX: DDS file Custom Scenery/z_na_07/textures/24912_18976_BI16.dds declares 11 mips, provides 11 mips, we expected 13 mips
2:44:37.564 D/TEX: DDS file Custom Scenery/z_na_07/textures/24912_18976_BI16.dds is missing 32 bytes of low mips
2:44:37.715 W/TEX: DDS file Custom Scenery/z_na_07/textures/100096_75808_BI18.dds declares 11 mips, provides 11 mips, we expected 13 mips
2:44:37.715 D/TEX: DDS file Custom Scenery/z_na_07/textures/100096_75808_BI18.dds is missing 32 bytes of low mips
2:44:38.110 W/TEX: DDS file Custom Scenery/z_na_07/textures/100080_75808_BI18.dds declares 11 mips, provides 11 mips, we expected 13 mips
2:44:38.110 D/TEX: DDS file Custom Scenery/z_na_07/textures/100080_75808_BI18.dds is missing 32 bytes of low mips
2:44:38.702 W/TEX: DDS file Custom Scenery/z_na_07/textures/100000_75808_BI18.dds declares 11 mips, provides 11 mips, we expected 13 mips
2:44:38.702 D/TEX: DDS file Custom Scenery/z_na_07/textures/100000_75808_BI18.dds is missing 32 bytes of low mips
2:44:38.887 W/TEX: DDS file Custom Scenery/z_na_07/textures/24976_18944_BI16.dds declares 11 mips, provides 11 mips, we expected 13 mips
2:44:38.887 D/TEX: DDS file Custom Scenery/z_na_07/textures/24976_18944_BI16.dds is missing 32 bytes of low mips

Just had a look at the discussions and saw something about the xp beta having issues with ortho with the same log I posted above so I will be closing the issue.


”Coarnele Caprei”, ”Arama”, ”Petroșica” are listed in the drop-down menu

Description:
When user writes ”Coarnele Caprei”, ”Arama”, ”Petroșica” the locations appear in the drop-down menu next to the comune and the county which is a part according to the law.
Precondition:
The website is up an running.

Step 1
Write in the search bar "Coarnele Caprei"

Expected results
The location appears in the drop-down menu as "Sat Coarnele Caprei, IAȘI (Coarnele Caprei)".

Step 2
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 3
Write in the search bar "Arama"

Expected results
The location appears in the drop-down menu as "Sat Arama, IAȘI (Coarnele Caprei)".

Step 4
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 5
Write in the search bar "Petroșica"

Expected results
The location appears in the drop-down menu as "Sat Petroșica, IAȘI (Coarnele Caprei)".


ctr-drbg: always use the DF for OpenSSL's DRBGs

Force the use of the derivation function when creating OpenSSL's internal DRBGs.
FIPS mandates the use of a derivation function, so 3.4 cannot be validated as it stands which run counter to the indicator work that was included.
Not intended for back porting to earlier stable releases.  The issue was introduced in 3.2.  3.2 and 3.3 are unlikely to be FIPS validated with 3.4 so close.

@paulidale should it also go to master?

This is included as part of #25498, so no need to go separately.

24 hours has passed since 'approval: done' was set, but as this PR has been  updated in that time the label 'approval: ready to merge' is not being automatically set.  Please review the updates and set the label manually.

Merged to the master and 3.4 branches. Thank you for your contribution.


UIINREACH-156: Update INN-Reach Transaction Results List to Sort by Request Date Descending (newest requests first)

Test errors found. See https://jenkins-aws.indexdata.com/job/folio-org/job/ui-inn-reach/job/PR-174/1/


xclip: add revision to fetchsvn

It didn't have a specified revision, and the repository advanced to revision 87 in the meanwhile, breaking the fetchsvn.

Fixed by c9ef3b51a3e910f3850ab10378c8b58f0d2d97e8


Add missing units from official iso countries list

Thanks for finding these missing items. A couple of things need small tweaks before this gets merged, however:

Please sort the new items alphabetically by their 2-letter ISO code, in the same way the existing items on the list are sorted.
Please add the name of the new additions in the predominant local language (Antarctica doesn't need one, but notably the French Southern Territories should have "Terres australes françaises"), in the same manner as the other items already in the file.

Also, just as a note, Heard Island and McDonald Islands is a territory that is officially uninhabited, so while for the sake of completeness I'm happy to include it, I do wonder how many people are going to be selecting it. Then again, I don't pretend to know all of the use cases for the plugin, so if somebody is trying to record penguin survey data or something, I'd hate for them to be missing a necessary option...
At any rate, if you could please make the two small adjustments mentioned above, I'd be happy to accept this request and get it merged.

I'm aware of what you mentioned and even have had similar conversation with same arguments, but it finished with conclusion there should be all units from official ISO list. Maybe one day civilization will reach those islands too :)
Ad1. I see that items are sorted alphabetically by names not ISO codes and I've added new ones in this manner. Can you please verify?
Ad2. Done.

Nope, you're right about the sort order. That's my mistake.
I see you added the predominant language part, so this looks good.
I'll get this merged momentarily.


[ENHANCEMENT] Improve process to permit multiple document compilation passes

Is your feature request related to a problem? Please describe.
The module currently is single-tracked: It permits only the creation of a single compiled PDF using a set of input forms.  This limits its use in a REDCap project to a single compiled form.
Describe the solution you'd like
Update the module to add a loop structure around its configuration, allowing users to define multiple sequences of forms to convert to PDFs.
Additional context
Research projects often have multiple signature-controlled events (eg, an initial consent, as well as a human research subjects form, followed by possible re-consents or consent modifications as a study progresses).

Please make a pull request and I'm happy to include.  This was an EM for a specific project with limited funding, so it goes...

Yep - I'm hard at work on the PR for this.  It should go in tomorrow (I hope).

From: Andy Martin<EMAIL_ADDRESS>Sent: Monday, August 17, 2020 8:01 PM
To: susom/multi-signature-consent<EMAIL_ADDRESS>Cc: Frazier, Remi<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [susom/multi-signature-consent] [ENHANCEMENT] Improve process to permit multiple document compilation passes (#2)
Please make a pull request and I'm happy to include. This was an EM for a specific project with limited funding, so it goes...
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_susom_multi-2Dsignature-2Dconsent_issues_2-23issuecomment-2D675220667&d=DwMCaQ&c=iORugZls2LlYyCAZRB3XLg&r=nhhptS87aU7HW5b_42AOXPLxqQESGXQZVph4VAUDYas&m=6zYsoXFgx0CLAS0TKt6672iOsGG4ZOuoG9nJ_N68Rbw&s=UvpkA-HPjKc61QWFnCJn0p-Sb0yc8l6hDmJRgwY_Tgw&e=, or unsubscribehttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AG6JNHDNA4OPFE6TB2E3353SBHVHZANCNFSM4PGFHMTA&d=DwMCaQ&c=iORugZls2LlYyCAZRB3XLg&r=nhhptS87aU7HW5b_42AOXPLxqQESGXQZVph4VAUDYas&m=6zYsoXFgx0CLAS0TKt6672iOsGG4ZOuoG9nJ_N68Rbw&s=H5BpuRMy7X9TM-UYuPw1r8Swsa4AGBgn-o4V3wXeoic&e=.


Create test server for test-net deployment

We must deploy NF_3 to an Ethereum test net so that it can be fully exercised.  To do that we require a more permanent off-chain capability.  Accordingly, we will set up a suitable server to host the off-chain components associate with a test-net deployment.  Server specifications are:
32 GB Ram
8 Cores
250 GB disk.
Ubuntu 18.04 or 20.04

Completed


Problems with devise version

I'm trying to create an api of my web application, I want to use devise token auth, for managing sessions in the api but I have problems installing it, since there is a dependency problem with the gem devise.
Try to make a downgrade to the gem devise to version 4.3.0 but in this it presents a bug with ruby 2.5.0 that solved in version 4.4.0.
I do not know what to do, I have as a last option to make a separate application with the necessary version of devise, but I would like to exhaust some other alternative first.

Version:  devise_token_auth 0.1.42, Devise version 4.4.1

Sorry, we don't have a release yet. You can point to master: gem 'devise_token_auth', git: 'https://github.com/lynndylanhurley/devise_token_auth'


Image is not reflected on Readme File Update Image Path

Describe the bug
https://github.com/akshitagupta15june/Face-X/tree/master/Snapchat_Filters/Detective Filter

Image is not reflected on the readme File so

To Reproduce
Steps to reproduce the behavior:
1.
Expected behavior
A clear and concise description of what you expected to happen.
Actual behavior
A clear and concise description of how the code performed w.r.t expectations.
Screenshots

Additional details

hey,@akshitagupta15june can you assign me!


revised README with a logo added.

What do these changes do?

add logo in README.
revise the badge link to relative path.
in doc building target, cp the logo.png to docs dir.

Related issue number

Fixes

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 3 committers have signed the CLA.:white_check_mark: sighingnow:x: yecol:x: luoxiaojianYou have signed the CLA already but the status is still pending? Let us recheck it.


chore: more moderate probes in hmeta

Similar to #52. Refer to https://github.com/rqlite/kubernetes-configuration/blob/master/statefulset-3-node.yaml and test with a 3 hmeta cluster, increase the InitialDelaySeconds to reduce unnecessary checks.

I checked failed tests and it seems they failed because of a timeout bootstrap.

I checked failed tests and it seems they failed because of a timeout bootstrap.

The reason was that I changed the port name of the hmeta service, then I found we hardcoded the name to port. To solve this problem, I extracted a constants package to place the default container port of hmeta for other package usages.
Will add tests later.

I found we haven't added tests in the internal/admin package, supplementing them would be a lot of work, so I opened a new PR to handle it (#56).
@Rory-Z Shall we merge this PR first due to changes that didn't break test coverage much?

@g1eny0ung I think we can merge this PR, could you please Squash and merge this

@g1eny0ung I think we can merge this PR, could you please Squash and merge this

I don't have the permission to merge. 🤣 Can I be granted one?


[Service Bus] Batching Receiver (For sessions) during a disconnect

Issue https://github.com/Azure/azure-sdk-for-js/issues/8875
What's in the PR
"disconnect"/refresh logic added before did not cover the session scenarios.
This PR attempts to tackle the batching receiver for sessions upon "disconnect" scenarios to have a smooth-resolution/throw-errors based on the receiveMode.
receiveMessages - Scenarios to handle/test

[x] throws "session lock has expired" after a disconnect
[x] returns messages if drain is in progress (receiveAndDelete)
[x] throws an error if drain is in progress (peekLock)
[x] returns messages if receive in progress (receiveAndDelete)
[x] throws an error if receive is in progress (peekLock)

TODO

[x] Cover the scenarios above
[x] Tests
[x] Bug fix - number of receivers - https://github.com/Azure/azure-sdk-for-js/issues/13990
[x] Changelog
[ ] Streaming receiver - beyond the scope of this PR https://github.com/Azure/azure-sdk-for-js/issues/14212
[ ] Bad log messages https://github.com/Azure/azure-sdk-for-js/issues/13989 - beyond the scope of this PR
[ ] Stress testing plan for disconnect - https://github.com/Azure/azure-sdk-for-js/issues/13988 - beyond the scope of this PR

Fixes #8875

/azp run js - servicebus - tests

Just a note, I'm starting to review this.

@HarshaNalluru : here's the "fix" I was working on for session streaming receivers:
https://github.com/Azure/azure-sdk-for-js/compare/master...richardpark-msft:sb-session-disconnect?expand=1

I'm thinking of making a separate PR for streaming - started a separate branch here, here's the diff https://github.com/HarshaNalluru/azure-sdk-for-js/compare/harshan/sb/issue/8875-part-3...HarshaNalluru:harshan/sb/issue/8875-part-3-streaming?expand=1

/azp run js -service-bus - tests

Note: Merged streaming PR into this PR.

/azp run js - service-bus - tests

Still investigating the flaky ness of the disconnect test - that consistently fails on windows node_14

Here : https://github.com/Azure/azure-sdk-for-js/pull/14393

/azp run js - service-bus - tests

/azp run js - service-bus - tests

I agree @richardpark-msft, but this particular flaky test seems to be uncovering a problem with the service or how we interact with it. So, it needs to be resolved.

All green 🎉


Calling .to(...) on scalar arg breaks when specialization kicks in

One of our kernels has a scalar parameter. To avoid an overflow, at some point we cast it to int64 (i.e., we call v.to(tl.int64)).
On occasion we pass a value of 1 to that argument, and this triggers the specialization mechanism to build a ad-hoc kernel, where that parameter is replaced by a constexpr value. This however causes a compilation error when calling .to(...) on a constexpr.
Here is a repro:
In [1]: import triton

In [2]: import torch

In [3]: import triton.language as tl

In [4]: @triton.jit
   ...: def my_kernel(in_, out, mul):
   ...:     val = tl.load(in_)
   ...:     tl.store(out, val * mul.to(tl.int64))
   ...:

In [5]: in_ = torch.ones((1,), dtype=torch.long, device="cuda")

In [6]: out = torch.empty((1,), dtype=torch.long, device="cuda")

In [7]: my_kernel[1,](in_, out, 42)
Out[7]: <triton.compiler.compiler.CompiledKernel at 0x7fee5eea8850>

In [8]: out
Out[8]: tensor([42], device='cuda:0')

In [9]: my_kernel[1,](in_, out, 1)
---------------------------------------------------------------------------
AttributeError                            Traceback (most recent call last)
...
CompilationError: at 3:24:def my_kernel(in_, out, mul):
    val = tl.load(in_)
    tl.store(out, val * mul.to(tl.int64))
                        ^
AttributeError("'constexpr' object has no attribute 'to'")

I have triton-nightly 2.1.0.post20231118001511.

Note that we cannot use do_not_specialize to work around this because that argument is in fact a stride thus we want it to be specialized!

It would be nice if constexpr values had the same interface as tensor, but in the mean time you can use tl.full to turn a constant into a scalar tensor of the expected dtype
tl.full([], mul, tl.int64)


Invalid initialization arguments in make-texture

  (apply #'make-instance 'texture-object
         :asset texture-asset
         :dest (make-instance 'rl-rectangle
                              :x x
                              :y y
                              :width (or width (width texture-asset))
                              :height (or height (height texture-asset)))
         args))

As you can see above, make-texture, as it is in the asset-rework branch at the moment, gives :width and :height to the outer make-instance for texture-object via args. texture-object does not have :width/:height so this is an error.
I don't know the cleanest way to solve this since it's undesirable to list out each keyword in place of args. I tried that anyway and got an "uneven number of keywords" error - although this is probably a problem on my end. I will investigate it further soon.

Ah yes, silly me. I've added :allow-other-keys t to make-texture.

silly me

Why silly you? I'm the one who created that bug!


Update to 1.20

First time using this mod, wanted to use it for 1.20, realized there wasn't an update, chimpanzee brain have idea and 30 minutes after blacking out in a cold sweat with IntelliJ open I have a draft PR.
Some notes:

I can't actually test this right now - it starts and gets to the main menu, but Mojang removed the multiplayer server CLI arg, so I'd need to make my own mod to see if it works
Because of the new a11y onboarding screen, you need onboardAccessibility:false in options.txt to not immediately softlock while the soothing voice of the narrator reads out accessibility.onboarding.screen.narrator
Had to remove rootProject.name = "Curium" from settings.gradle because I cloned it as curium and something something case sensitivity
Window::readIconPixels is just gone. I did not have enough foresight to also set up a dev env in 1.19.4, so I have no idea what it's supposed to do or where it gets called. Removing the Overwrite just seemed to work (lol)
I strongly suspect more things will be broken from GuiGraphics. I don't see any errors in my IDE but who knows!
My game crashes with Fabric API installed and I have no idea why, GameRenderer::render conflicting being one of them. I tried commenting it out to get it to work, and the game Didn't Crash, but there was another conflict with sound that I didn't want to go track down

The last few commits I pushed gets everything working - the world would randomly stop ticking which I managed to trace to an infinite loop in a method in Frustum. It also seems to work with Fabric API now, too, and I was able to get a simple bot working with portablemc.
I'll take the PR off draft because it Technically Works:tm:.

Seems like com.mojang.blaze3d.audio.OggAudioStream changed slightly and loads LWJGL now

I can fix it if you like, or I can explain how you can check what loads stuff

It'd probably be better for you to fix right now. You should be able to commit to the fork.

Alright, I believe that's everything. Thanks for the PR :)


TypeError: Illuminate\Mail\PendingMail::send(): Argument #1 ($mailable) must be of type Illuminate\Contracts\Mail\Mailable, string given

Laravel Version: 8.x Latest
PHP Version: 8.1
Database Driver & Version: MariaDB

Description:
When i try to send a mail using a view inside a Job doesn't work, on sync works
Steps To Reproduce:
This code works,
\Mail::send('mails.emergency_call', [], function ($message) {
<EMAIL_ADDRESS>'Email Example');
});

but if you put the same code inside of handle method on a Job and when i call dispatch i get
Illuminate\Mail\PendingMail::send(): Argument #1 ($mailable) must be of type Illuminate\Contracts\Mail\Mailable,
string given, called in /var/www/app/Jobs/SendView.php on line 52
{"exception":"[object] (TypeError(code: 0): Illuminate\\Mail\\PendingMail::send():
Argument #1 ($mailable) must be of type Illuminate\\Contracts\\Mail\\Mailable,
string given, called in /var/www/app/Jobs/SendView.php on line 52
at /var/www/vendor/laravel/framework/src/Illuminate/Mail/PendingMail.php:122)
[stacktrace]
#0 /var/www/app/Jobs/SendView.php(52): Illuminate\\Mail\\PendingMail->send('mails.emergency_call.', Array, Object(Closure))

class SendView implements ShouldQueue{
    use Dispatchable, InteractsWithQueue, Queueable, SerializesModels;

    public function __construct(){
         $this->onConnection('database');
    }
    public function handle(){
        \Mail::send('mails.emergency_call', [], function ($message) {
<EMAIL_ADDRESS>'Email Example');
        });
    }
}

Hi there,
Thanks for reporting but it looks like this is a question which can be asked on a support channel. Please only use this issue tracker for reporting bugs with the library itself. If you have a question on how to use functionality provided by this repo you can try one of the following channels:

Laracasts Forums
Laravel.io Forums
StackOverflow
Discord
Larachat
IRC

However, this issue will not be locked and everyone is still free to discuss solutions to your problem!
Thanks.

@driesvints looks like a bug to me


Partials Footer

Hello. I get an error when trying to build on Netlify related to the partials/footer.html:
: can't evaluate field IsProduction in type interface {}
Is there something I'm missing? I am new at working with Hugo.. Thanks.

@snowfoxboots Would you mind sharing what Hugo version you are using?

hugo v0.81.0+extended darwin/amd64

@lxndrblz Here's the version I use as I included that line a part of the GA4 analytics request:
hugo v0.81.0-59D15C97 windows/amd64 BuildDate=2021-02-19T17:07:12Z VendorInfo=gohugoio
Though I don't use Netlify

I imagine it's caused by the following if clause:
{{- if and (hugo.IsProduction) (.Site.Params.gtagId) -}}
Though, that shouldn't be an issue. I'll do some research and report back.
@snowfoxboots  Would you mind sharing the full error messaging you are seeing?

@snowfoxboots  Could you please also share your netlify.toml?

Ah this is my mistake, I didn't update the newest version on the netlify.toml file. It does work.

@snowfoxboots That was a quick fix. Please let me know, if you are still running into another issue.


Fix subscribing to a behavior subject can miss the actual value (#512)

This is a possible fix for the issue #512 based on my own explanations and suggestions.

I'm closing this for now, see discussions in #512


store APNS certificate in env var

Hi I usually deploy to Heroku and prefer to keep my entire certificate as an environment variable rather as a file. Is this a feature you'd be interested in accepting via pull-request?

I'm -1 on it, why can't the environment variable point to a file path instead? Any particular reason?

I'm using this code in settings.py to load sertificate from ENV:
# PUSH NOTIFICATIONS
apns_file_name = os.path.join(BASE_DIR, 'apns_sandbox.pem')
if os.environ.get('APNS_CERTIFICATE'):
    # create certificate file from ENV var
    from tempfile import NamedTemporaryFile
    import atexit
    apns_file = NamedTemporaryFile(delete=False)
    apns_file.write(bytes(os.environ.get('APNS_CERTIFICATE'), 'UTF-8'))
    apns_file.close()
    apns_file_name = apns_file.name

    def unlink_apns_file():
        os.unlink(apns_file_name)
    atexit.register(unlink_apns_file)  # remove certificate file on exit

PUSH_NOTIFICATIONS_SETTINGS = {
        'APNS_CERTIFICATE': apns_file_name
}

To be honest, this functionality belongs in settings.py and this is a good enough solution, so rejecting and closing.

@jleclanche I'm think the issue here is how heroku deploy works. In order to deploy on heroku,  @jschneier must save the pem file on git repository. @jschneier , @jleclanche am I wrong?
@ilyatikhonov when used on heroku your solutions writes a temp file on each request?

@ninobaldo no you are wrong. this solution worked for me. i stored the value env var and then wrote it to a temp file.

@jschneier but does this not cause a file to be saved in every request? Heroku persists the pem?

Only on application boot.

Nice! Tks!

On 8 Feb 2017, at 20:52, Josh Schneier<EMAIL_ADDRESS>wrote:
Only on application boot.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/jleclanche/django-push-notifications/issues/248#issuecomment-278488942, or mute the thread https://github.com/notifications/unsubscribe-auth/AB5OjbG5S3UlNytfOIKnSN3-YtHTBlkoks5rakdCgaJpZM4GslEh.

Hi @ninobaldo, my solution creates a temp file only once per app instance during the initialization.

When I use a temporary file like the solution provided by @ilyatikhonov, device.send_message() times out. I'm not sure how to debug this.


[cherry-pick][release-2.40.0] Merge pull request #21910: Revert "convert windmill min timestamp to …

…beam min timestamp"
Please add a meaningful description for your change here

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

CP for https://github.com/apache/beam/pull/21910 - r: @kennknowles

Run Java PreCommit


HostedUIProvidersCustomResourceInputs issue after updating CLI and migrating auth resource

I am facing issues while pushing schema changes using amplify cli. I want to make few changes to the api and whenever I try to push I get the following errors.
UPDATE_FAILED      HostedUIProvidersCustomResourceInputs Custom::LambdaCallout Wed Jan 05 2022 09:48:19 GMT+0300 (Arabian Standard Time) Received response status [FAILED] from custom resource. Message returned: See the details in CloudWatch Log Stream: 2022/01/09/[$LATEST]3a19b4a6a3b54f8a934b84e092336d8e (RequestId: b23eaa49-2cdb-482b-a72b-fe14af149fa3)
UPDATE_FAILED               authyoumi0da39d96        AWS::CloudFormation::Stack Wed Jan 05 2022 09:48:30 GMT+0300 (Arabian Standard Time) Embedded stack arn:aws:cloudformation:us-east-2:575248310550:stack/amplify-youmi-dev-104725-authyoumi0da39d96-1PCTJAN92L43Z/d590ebe0-6ec5-11ec-bba9-02002f4e277e was not successfully updated. Currently in UPDATE_ROLLBACK_IN_PROGRESS with reason: The following resource(s) failed to update: [HostedUIProvidersCustomResourceInputs].
Following resources failed
Following resources failed

Resource Name: 2022/01/09/[$LATEST]3a19b4a6a3b54f8a934b84e092336d8e (Custom::LambdaCallout)
Event Type: update
Reason: Received response status [FAILED] from custom resource. Message returned: See the details in CloudWatch Log Stream: 2022/01/09/[$LATEST]3a19b4a6a3b54f8a934b84e092336d8e (RequestId: b23eaa49-2cdb-482b-a72b-fe14af149fa3)
URL: https://console.aws.amazon.com/cloudformation/home?region=us-east-2#/stacks/arn%3Aaws%3Acloudformation%3Aus-east-2%3A575248310550%3Astack%2Famplify-youmi-dev-104725-authyoumi0da39d96-1PCTJAN92L43Z%2Fd590ebe0-6ec5-11ec-bba9-02002f4e277e/events

✖ An error occurred when pushing the resources to the cloud 🛑 An error occurred during the push operation: Resource is not in the state stackUpdateComplete
AppID: d1ubl6yt089uw0
Region: us-east-2
It seems that the deployment of my backend has failed due to this reason and because of that I cannot make any changes to the database from the amplify console as it keeps looking for an active deployed backend.
So far me and my team have setup amplify backend, S3, IAM users and Cognito with identity pool and it was fine until we setup social signin.
For context, my knowledge about amplify is very little so there is a high chance I might have configured something in a wrong way that caused this issue.
Its been quite a while and I still am not able to find a proper solution. Any kind of help will be highly appreciated

Hey @sayed-mohidin :wave: this appears to be a duplicate of https://github.com/aws-amplify/amplify-cli/issues/7685, which has since been fixed. Can you confirm whether you have continued to experience this error on later versions of the CLI?

I confirm, the issue is still valid with CLI 7.6.22

Hey @ENT108 :wave: apologies for missing the reply here. Can you file a separate issue for that occurrence? I believe it would be beneficial to capture the current context of the project as this issue was addressed.
Closing issue due to inactivity. @sayed-mohidin if you are still experiencing this please reply back to this thread and we can re-open to investigate further 🙂

I had the same issue with HostedUIProvidersCustomResourceInputs failing on every push yesterday after an Amplify CLI upgrade prompted me to migrate our auth resource to a newer format. We ended up tracing the failure to the new cli-inputs.json file having a value for hostedUIProviderMeta that contained empty values for authorize_scopes and AttributeMapping for the SignInWithApple OAuth provider, which we are using for sign-in.
That value for hostedUIProviderMeta seems to get overwritten/broken any time you step through OAuth configuration using amplify auth update, so the most desirable fix here would be for the CLI to provide a workflow to modify those settings, or at a minimum to stop nuking any changes that the developer has already made to that value in the file.

I got it sorted by reviewing cloudWatch logs in detail for push jobs HostedUIProvidersCustomResource. Yes, cli-inputs had issues.

Ah, my CloudWatch logs were not so helpful. The error thrown by HostedUIProvidersCustomResource was a generic internal server error so required a bit of trial and error to track down.

@josefaidt Running amplify auth update and reconfiguring the auth through the CLI fixed the issue for me. Whenever I face the issue, I repeat the above steps and that seem to fix it. Hopefully this helps anyone facing the same problem.

That's funny... for us it is the exact opposite. Running amplify auth update reliably nukes our value for hostedUIProviderMeta in cli-inputs.json thereby breaking all subsequent pushes. Are you able to track down what value(s) in cli-inputs.json are involved for you?

That's funny... for us it is the exact opposite. Running amplify auth update reliably nukes our value for hostedUIProviderMeta in cli-inputs.json thereby breaking all subsequent pushes. Are you able to track down what value(s) in cli-inputs.json are involved for you?

It also destroys all mapping attributes.

@josefaidt - any progress on this issue? Our deployments were working fine until we decided to test Amplify Hosting on our development environment. I ran amplify pull locally on my machine and now we cannot push anything. I'm getting an obscure error of:
UPDATE_FAILED HostedUIProvidersCustomResourceInputs Custom::LambdaCallout Tue Jun 28 2022 10:32:24 GMT+0100 (British Summer Time) Received response status [FAILED] from custom resource. Message returned: See the details in CloudWatch Log Stream

any ideas how we can get unblocked?

@josefaidt - any progress on this issue? Our deployments were working fine until we decided to test Amplify Hosting on our development environment. I ran amplify pull locally on my machine and now we cannot push anything. I'm getting an obscure error of:
UPDATE_FAILED HostedUIProvidersCustomResourceInputs Custom::LambdaCallout Tue Jun 28 2022 10:32:24 GMT+0100 (British Summer Time) Received response status [FAILED] from custom resource. Message returned: See the details in CloudWatch Log Stream

any ideas how we can get unblocked?

What solved this for me was running amplify update auth.

OK, hitting this issue on subsequent pushes after migrating auth... any update on a fix for this?

The configuration parameters from my original auth resource were not all preserved across migration of my auth resource either. I would check the values in your newly generated cli-inputs.json file found in the auth resource directory (particularly the value for hostedUIProviderMeta) and ensure they match the expected values from pre-migration.

@gspeicher - I'm attempting to add our custom OIDC provider details into the CF stack.
I'm sure this was working, though.
Hopefully, the Amplify team adds custom OIDC provider support soon.
It seems that any update I'm doing to the cli-inputs.json file, to add this custom OIDC provider, is breaking our deployments.
I've managed to get back to a working state without our custom OIDC provider details added.

@josefaidt - yes, the custom OIDC provider details were not being respected. We've done this by hand now. It would be awesome if custom OIDC provider support was integrated/documented.

Hey @kylekirkby glad to hear you're up and running despite the trouble! We are tracking custom/generic OIDC provider support using this feature request https://github.com/aws-amplify/amplify-cli/issues/177, please subscribe to this issue for further updates on that topic.
Folks in the thread if you are still experiencing this issue could you please submit a new issue with the relevant information and minimal reproduction steps?

I'm running into this exact issue. Why was this closed? Should be just delete hostedUIProviderMeta in the cli file?


ENH: Different extrapolation modes for different dimensions in multidimensional filters.

I have minimally modified the code of the multidimensional filters (ndimage.filters) written in python to allow different extrapolation modes across different axis of the arrays, instead of forcing the user to choose only one.
I came to the need of this by applying filters to images of data in polar coordinates, where wrapping always makes sense for any filter across the angular axis (the 0 side should share information with the 2*pi side), but does not make sense at all along the radial axis.
I guess this extra control can be useful in many more cases.

@Eric89GXL Thank you for the feedback! As you mentioned other maintainer taking a look (do you have any suggestion of anyone in particular), I will wait until some else also confirm that they are interested in the PR, before putting more work on it. And I will leave the rebase for just before it is ready, to avoid having to do it more than once.

That sounds reasonable to me. You could look at who has recently reviewed related ndimage PRs and ping them, or just wait.

Looks like a nice enhancement, +1 from me.

Looks like there's a small issue with the docstring update - docfiller is used also by several other functions like correlate1d that do not get the sequence support for mode. So those docstrings will now be incorrect.
Maybe you did try to address that with
 A list of modes can be provided for each of the axes of
 of multidimensional inputs.

But that's not quite right - note that the input to correlate1d is allowed to be multi-dimensional (it just operates on a single axis).

@rgommers
Yes, I tried not adding another entry to avoid having to copy and paste the whole sentence before that. But maybe I did not phrase it well. I think something like may be compatible with everything:
 A list of modes can be provided specifying the mode to use for each of the axes in multidimensional filters.

But actually it is probably better to have it separate for the modes that have this enhancement. So, would you be ok with having a different entry in docfiller for just the filters affected by this new behavior, i.e. the modified filters (gaussian_filter, prewitt, sobel, generic_laplace, generic_gradient_magnitude, uniform_filter,_min_or_max_filter), plus the filters that make direct use of those filters (gaussian_laplace, gaussian_gradient_magnitude,laplace,minimum_filter, maximum_filter).
_mode_multiple_doc = \
"""mode : {'reflect', 'constant', 'nearest', 'mirror', 'wrap'}, optional
    The `mode` parameter determines how the array borders are
    handled, where `cval` is the value when mode is equal to
    'constant'.  A list of modes with length equal to the number of
    axes can be provided to specify different modes for different
    axes. Default is 'reflect'"""

So if you are happy with this I will implement all the changes we have discussed when I have some time. Should I do the squash and rebase already, or do you want to still keep the commit history for another iteration?
Note: rank_filter (the one used for median_filter, for example) actually also depends sometimes in maximum_filter and minimum_filter, however, in the most general case it depends on NI_RankFilter which is implemented in C acting across multiple dimensions simultaneously, so it is a bit more messy to provide the behaviour in those cases, as it would require a new c prototype to be compatible with list of modes. I would be happy to work on that some other time, but I would like to disentangle it from this simpler cases.

So, would you be ok with having a different entry in docfiller for just the filters affected by this new behavior

Yep, that would be great.

Should I do the squash and rebase already, or do you want to still keep the commit history for another iteration?

No, squash and rebase would be good. The history isn't very interesting.

I would be happy to work on that some other time, but I would like to disentangle it from this simpler cases.

good plan:)

@rgommers , @Eric89GXL
I have implemented the changes we have discussed (including a bunch of tests in the way) and then don rebase and squash. Feel free to take a look, and let me know :)

LGTM, +1 for merge

Great, @rgommers please let me know if you want anything else changed.

Thanks, positive review so merging.


Implemented Anastz Customization #130

Hi @neiljdo Added a new custom method to the BaseAnsatz class called custom, which implements BaseAnsatz.custom function, where anything can go inside that custom function, even custom gate definitions. I still think there needs to be modifications in this implementation, so far I modified the following:

class BasenAnsatz: To add a custom function for creating and using custom quantum gates within the BaseAnsatz class, which can then be utilized by any subclass such as CircuitAnsatz, you would define a method in BaseAnsatz for handling the custom gate logic. This method would ideally accept parameters for the gate's unitary matrix and the qubits it acts upon. Subclasses can then leverage this method to incorporate custom gates into their circuits.

Note: The code aims to provide a flexible framework for defining and applying custom quantum gates within quantum circuits. By allowing the user to specify a unitary matrix, any conceivable quantum operation can be implemented, provided it adheres to the unitary constraint.

class CircuitAnsatz: When defining specific ansatzes in subclasses, we can now utilize the add_custom_gate method to include custom gates as part of the circuit construction.
class CustomGate: To complete the integration of custom gates within the Diagram class, we need to implement the logic for inserting a CustomGate into the diagram's structure. This involves creating a new layer or incorporating the custom gate into an existing layer.
class Diagram / Diagram Structure: The implementation appends the custom gate as a new layer at the end of the diagram. Depending on the needs, we might want to insert the custom gate at a specific position or merge it with existing layers.
def create_layer_for_custom_gate:

Dynamic Layer Composition: This method dynamically constructs a new layer, considering the qubits the custom gate acts upon. It initializes the layer with identity operations (Id(qubit)) for all qubits and then replaces the relevant positions with the custom gate.
Handling of left and right Types: The left type is determined based on the diagram's existing structure, while the right type is adjusted to accommodate the maximum qubit index involved with the custom gate. This ensures the layer fits seamlessly into the diagram.
Layer Insertion: The new layer is appended to the end of the diagram. For more complex scenarios, such as inserting the layer at a specific position or integrating it with existing layers, additional logic would be required.
I still think there needs to be some kind of modifications to this implementation, this could also be seen as a proof of a method. But any kind of review would be a great help!

@valleyofblackpanther This will be closed for now, please follow-up discussion in Issue #130. It can be re-opened later if required.


Release Google.Cloud.DiscoveryEngine.V1Beta version 1.0.0-beta09

Changes in this release:
New features

Add data store, engine, serving config and site search engine services (commit b2d79e6)
Support search summarization with citations and references (commit b2d79e6)
Add suggestion deny list import/purge APIs (commit b2d79e6)
Add engine support for multi-turn search and search APIs (commit b2d79e6)

Documentation improvements

Keep the API doc up-to-date with recent changes (commit b2d79e6)

Created release for Google.Cloud.DiscoveryEngine.V1Beta-1.0.0-beta09


Az Active Directory Admin Group Name for Azure Database for PostgreSQL single server supports up to 63 Characters

Hello Team,
Please be informed that when I tried adding Azure Active Directory Group as Admin in Azure Database for PostgreSQL Single Server, it was observed that it supports AAD Group Name up to 63 characters.
If the AAD Group Name is 64 characters and above, it allows be to add and save but as soon as I refresh the page, AAD Group is No more displayed. It only displays "NO ACTIVE DIRECTORY ADMIN"
Below is what I tried and my observation (please correct me if I am wrong)

No. of Characters Supported for AAD Group Name in Az Database for PostgreSQL
Status after Refreshing the Az Portal

69
FAIL - Displays "NO ACTIVE DIRECTORY ADMIN"

40
Success - Displays the AAD GROUP NAME

43
Success - Displays the AAD GROUP NAME

55
Success - Displays the AAD GROUP NAME

61
Success - Displays the AAD GROUP NAME

65
FAIL - Displays "NO ACTIVE DIRECTORY ADMIN"

64
FAIL - Displays "NO ACTIVE DIRECTORY ADMIN"

63
Success - Displays the AAD GROUP NAME

62
Success - Displays the AAD GROUP NAME

There is also NO MENTION of such phenomenon in Limits Page of Az Database for PostgreSQL Single Server - https://learn.microsoft.com/en-us/azure/postgresql/single-server/concepts-limits or in Active Directory Authentication - https://learn.microsoft.com/en-us/azure/postgresql/single-server/how-to-configure-sign-in-azure-ad-authentication
Please let me know.
Awaiting for your response.
Many Thanks
Regards, Arindam Mitra

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 115c4394-bd60-5f8f-bd88-c76a7c0ee2cd
Version Independent ID: 87c3407f-8565-e63e-258a-044365f35ad2
Content: Use Azure Active Directory - Azure Database for PostgreSQL - Single Server
Content Source: articles/postgresql/single-server/how-to-configure-sign-in-azure-ad-authentication.md
Service: postgresql
Sub-service: single-server
GitHub Login: @sunilagarwal
Microsoft Alias: sunila

@arindam0310018 Thanks for your findings, We will look into it and update as appropriate.

Hi @sunilagarwal,
Could you please look into this document request. Thanks

Hello @GeethaThatipatri-MSFT, @sunilagarwal @shaktisingh-msft,
Request for an update ?
Many Thanks
Regards, Arindam Mitra

Hi @kabharati,
Could you please look into this document request. Thanks

Hi @kabharati,
When you find sometime, please do update!!!
Many Thanks
Regards, Arindam Mitra

hi @arindam0310018 - I need to validate this but it appears it is error in documentation and currently AAD document suggests 53-character limit which should have been 63 characters. I am following up with AAD team to confirm this.
From PG side we follow AAD limitations.

Hello @kabharati
Thank you for your kind reply.
I look forward for AAD Team`s reply.
Meanwhile, Could you share the link to the documentation which states AAD character limit to 53 characters ?
Many Thanks
Regards, Arindam Mitra

This is a typo and you're right this should be 63 characters. AAD team is correcting the docs.

#please-close

Hello @kabharati,
Thank you very much for correcting. Much Appreciated.
Kindly share the link where this was corrected.
Many Thanks
Regards, Arindam Mitra

Here is the link
https://learn.microsoft.com/en-us/azure/active-directory/enterprise-users/groups-naming-policy
Get Outlook for iOShttps://aka.ms/o0ukef

From: Arindam Mitra @.>
Sent: Friday, November 11, 2022 8:07:40 PM
To: MicrosoftDocs/azure-docs @.>
Cc: Kanchan Bharati @.>; Mention @.>
Subject: Re: [MicrosoftDocs/azure-docs] Az Active Directory Admin Group Name for Azure Database for PostgreSQL single server supports up to 63 Characters (Issue #100012)
Hello @kabharatihttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fkabharati&data=05|01|kabharati%40microsoft.com|d3fada21f77b42c9191a08dac44a4c1b|72f988bf86f141af91ab2d7cd011db47|1|0|638038120648945949|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=qMU%2F24CJvwtFr%2B0wDJpwnZRf3j00LzWFdWPRVRKfX6M%3D&reserved=0,
Thank you very much for correcting. Much Appreciated.
Kindly share the link where this was corrected.
Many Thanks
Regards, Arindam Mitra
—
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Fazure-docs%2Fissues%2F100012%23issuecomment-1312296658&data=05|01|kabharati%40microsoft.com|d3fada21f77b42c9191a08dac44a4c1b|72f988bf86f141af91ab2d7cd011db47|1|0|638038120648945949|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=nE4iTwEok2deZyoKAZZ7ESlJ3dQQ6iPRoYVSl3XD%2Fa8%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAWEFYP2R6RC6KSDGAMTGHS3WH3UVZANCNFSM6AAAAAARGPRRZE&data=05|01|kabharati%40microsoft.com|d3fada21f77b42c9191a08dac44a4c1b|72f988bf86f141af91ab2d7cd011db47|1|0|638038120648945949|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=inwDejZBnlwpPGrOkOGx11T2MFy8Hgl1aQw%2FjGI0xjk%3D&reserved=0.
You are receiving this because you were mentioned.Message ID: @.***>

Hello @kabharati
Thank you!!!
I can now see the changes made.
Thank you again for making the changes.

Best Regards, Arindam Mitra


timer for judoc.jl not active

it seems the thing can stay active for well over 1h.
This seems to work fine though which is good I guess. But still better to control this and shut it down after a while, also should message about it.

actually nothing bad seems to happen so might as well leave it as such and remove the conditionality that timer < something.


Console prompt can't keep up

[x] I am on the latest Hyper.app version

[x] I have searched the issues of this repo and believe that this is not a duplicate

OS version and name: Windows 10 x64 Build 15063

Hyper.app version: 1.4.8 (stable)

Link of a Gist with the contents of your .hyper.js: https://gist.github.com/NomNuggetNom/b71dcd3984117c1a949315339b48f03b

Relevant information from devtools (CMD+ALT+I on Mac OS, CTRL+SHIFT+I elsewhere): N/A

The issue is reproducible in vanilla Hyper.app: Is Vanilla

Issue
When the console receives a large number of lines quickly, it desyncs and stops scrolling down, essentially breaking the prompt. For example, when running the following:
for ((i=1; i<=5000; i++)); do
   echo $i
done

My console never makes it to the end. For example:

In fact, even when I try to force the prompt down, it doesn't make it all the way (normal prompt for reference). The scroll bar also stops working - I have to scroll up first to be able to scroll down.
This happens when using a git bash shell and when using the native Windows shell.

Hi! Thanks for creating this issue. We are working hard on the soon-to-be-released 2.0 version of hyper. One of the main upgrades is our terminal rendering library. In 1.x we use hterm, 2.x will be shipped with xterm.js, which is a much more mature library, and gives us better performance out-of-the-box.
We have also implemented "debouncing/throttling" of the terminal stream, which helps a lot.
Id like you to try this in 2.x and see if you notice any difference, you can read on how to try 2.x via our canary release channel here: https://zeit.co/blog/canary

Here's more on this topic: https://github.com/zeit/hyper/issues/687

Hey @albinekb, thanks for the quick reply. Great news! The problem is totally fixed in 2.x - could not reproduce it at all. 👍

Let's close this one, performance will be even more increased with xterm.js 3 (released in some months), it renders using webgl/canvas.
🙌


Add Radians and Degrees types and Angle trait

Objective
Fixes #11132.
 However, they come with several ambiguities. Consider the following:
transform.rotate_x(1.4);

Is the angle in degrees or radians? While experienced Bevy users might know that it's in radians and counterclockwise, it's not immediately clear from the actual code and requires checking the documentation.
The code above is just a single example, but the issue is quite common. To improve readability and ergonomics, it would be nice to have a consistent and expressive way of representing angles and/or 2D rotations.
See #11132 for more background and discussion.
Solution
Add Radians and Degrees types and a shared Angle trait, similar to the approach proposed by @aleqdev here.
Creating and converting angles
Creating angles is very simple:
let alpha = Radians(std::f32::consts::PI); // or Radians::PI directly
let beta = Degrees(180.0); // or Degrees::HALF

The unit can be converted in a few ways:
// These are equivalent
let alpha_2 = alpha.to_degrees();
let alpha_2 = Degrees::from(alpha);

// These are equivalent
let beta_2 = beta.to_radians();
let beta_2 = Radians::from(beta);

Angles can be considered equal even if the unit is different:
assert_eq!(Radians::PI, Degrees::HALF);

Of course, numerical issues could result in the values being slightly different, but that seems like an unavoidable issue unless we use some epsilon value in the comparison.
Angle math
Add, Sub, Mul, Div, and Rem are all implemented for angles:
assert_eq!(Radians::PI + Radians::TAU, 3.0 * Radians::PI);
assert_eq!(Degrees(30.0) * Degrees(2.0), Degrees(60.0));

The second value doesn't have to be wrapped in an angle type, with the exception of f32 / Angle because it's a bit unclear what that should return:
assert_eq!(Radians::PI + std::f32::consts::TAU, 3.0 * Radians::PI);
assert_eq!(Degrees(30.0) * 2.0, Degrees(60.0));

// This does NOT work currently, but I can change it if that'd make sense
assert_eq!(10.0 / Degrees(2.0), Degrees(5.0));
// This works
assert_eq!(Degrees(10.0) / 2.0, Degrees(5.0));

If one angle is in Radians and the other is in Degrees, Radians is always returned as the output:
assert_eq!(Radians::PI + Degrees::HALF, Radians::TAU);

This is because Add can only have one output for a given type pair. The output is Radians because radians are typically more common when working with angles.
However, there are special methods that allow type inference to work:
// This should return Degrees correctly
let alpha: Degrees = Radians::PI.sub_angle(Degrees(45.0));
assert_eq!(alpha, Degrees(45.0));

And of course, the angles have common math operations like sin, cos, tan, abs, min, and so on implemented.
Note that Radians and Degrees do not implement Deref or DerefMut, because that would have the footgun of methods like to_radians not working how you'd expect, and Degrees needs to first be converted to Radians for e.g. trigonometric operations.
Using angles in Bevy's APIs
One of the most prevalent places where Angle is now used is the rotation methods in Transform. They take an impl Into<Radians> so you can pass any angle type:
// Both of these work
transform.rotate_x(Radians::FRAC_PI_4);
transform.rotate_x(Degrees(45.0);

For now, I decided not to implement From<f32> for the angle types. This might be one of the more controversial parts of this PR, as some people prefer to be able to write just the float value like before. Personally, I'm a big fan of the explicitness of having to use an angle type, and the API is concise and ergonomic enough that I don't find the few extra characters to be a big deal. I'm open to changing this if that's the general consensus though.
The Angle trait also makes it possible to make methods accept any angle type using generics without having to convert to a specific type. This might be useful for logic that is unit-agnostic and just wants to e.g. get the sine of the angle.
In the future, I'd expect these angles to also be used for e.g. Transform2d rotation (and skew?), 2D rotations provided when constructing bounding volumes (originally inspired this PR), geometric methods for some primitive shapes, 2D angular velocity, and many other use cases as well as user code.
Open questions

Should we implement From<f32> for Radians and Degrees and allow implicit angles to be passed to functions as floats?
Which one is better, Radians and Degrees or Rad and Deg?
Do we like the approach shown here, or would the third option shown in #11132 be better?

Todo

[ ] Add proper tests for all common tasks and operations
[ ] Implement missing methods (sinh, sqrt, etc.)

In the future, we could also add an f64 version of Angle or make it generic. I didn't do this yet as most angles use f32, and generics would require a generic number trait, which adds some complexity.

Changelog

Added Radians and Degrees types and Angle trait
Changed Transform methods with f32 rotations to take an impl Into<Radians>
Changed Transform method docs to mention that the rotation is in the counterclockwise direction
Changed examples to use Radians for properties or arguments that represent angles or 2D angular velocity

Migration Guide
Wrap angles passed to Transform methods like rotate_x inside the Radians type:
// Before
transform.rotate_x(angle);

// After
transform.rotate_x(Radians(angle));

Alternatively, use Degrees if you expect the angle to use degrees.
It's also recommended to use Radians and Degrees for angle types in your own code, but this is optional.

For now, I needed to skip deriving Reflect for the angle types because bevy_math doesn't have bevy_reflect and it can't be properly done externally because the impl_reflect_struct! macro doesn't support tuple structs just yet.
Because of this, spotlights still use f32 angles at the moment. The alternative would've been to remove the Reflect impl from the spotlight.

From a first rough review I would say it looks solid 👌
Just some thoughts:

would it make sense to add as_radians and as_degrees to the trait? This way the user of the trait can convert to a specific type if that's useful and they don't have to deal with T: Angle
I have some concerns about the operators:

AddAssign/SubAssign of an angle type in combination with f32 feels like an implicit conversion, I'd vote to scratch that
Mul of angle type with another angle type feels weird if you treat degrees as a unit (what's the unit of the result? °²?), I would vote for removing that and just keeping the Mul of angle * f32
Div of angle type with another angle type feels like it should return a f32. Again thinking of degrees as units and we would scratch them with the division. It reads "how many times does this rotation into the other one". Div of angle with f32 is fine and reads how big is the rotation that is a n-th of this other rotation
similar reasoning would apply to both Rems

I'm not sure why the operator methods in the trait exist, did you face any problems with the regular operators?

Added a Controversial label. The issue is under discussion, and not sure there's a clear consensus. Nice to see code to support the argumentation thought, thanks!

@RobWalt

would it make sense to add as_radians and as_degrees to the trait?

Yeah, I think that would make sense, it'd make the trait more useful. f32 has to_radians and to_degrees, so that naming could also make sense (what Radians and Degrees currently have), but e.g. Radians::to_radians wouldn't actually convert anything. So perhaps as_ would be better since "radians as radians" might make a bit more sense than "radians to radians".

AddAssign/SubAssign of an angle type in combination with f32 feels like an implicit conversion

I'm kinda on the fence here, but I think I might agree. It just means that we should also remove Add<f32> and Sub<f32> since that's basically the same kind of implicit convertion.

Mul of angle type with another angle type feels weird if you treat degrees as a unit...
Div of angle type with another angle type feels like it should return a f32...

This is something I was wondering too. If we consider units, you're definitely correct. I was thinking that it'd be nice to have angle * angle work for usability reasons, but it's probably just confusing, and you could always do angle * angle.0 instead.
I think I'll change it to be like you suggested since that's more "correct".

I'm not sure why the operator methods in the trait exist, did you face any problems with the regular operators?

Do you mean why methods like add_angle exist instead of just doing it in Add?
So the goal is that we can do Degrees(90.0) + Radians(PI) and have it return either Degrees or Radians based on what type is inferred from the surroundings.
I might be dumb and missing an obvious solution, but Add for a given type pair X + Y can only have a single Output, like this:
impl Add<Radians> for Degrees {
    type Output = Radians;

    fn add(self, rhs: Radians) -> Self::Output {
        self.to_radians() + rhs
    }
}

You can't implement this a second time with Output = Degrees, because then there would be duplicate implementations of Add<Radians>. And you also can't do this:
impl<T: Angle> Add<Radians> for Degrees {
    type Output = T;

    fn add(self, rhs: Radians) -> Self::Output {
        Self::Output::from(self) + Self::Output::from(rhs)
    }
}

because T is "not constrained by the impl trait, self type, or predicates". However, a separate method works, because there it is constrained:
/// Adds the given `angle` to `self`, returning the inferred type of angle.
fn add_angle<T: Angle, Output: Angle>(self, angle: T) -> Output
where
    Output: From<Self> + From<T>,
{
    Output::from(self) + Output::from(angle)
}

Okay, I've made the following changes based on the feedback:

All implicit conversions should be gone; you can't do Degrees(90.0) + 45.0
Degrees(90.0) * Degrees(90.0) isn't possible, because it doesn't make sense mathematically. The other value must be an f32.

Some/Most angle crates I've seen just return Degrees though

Degrees(90.0) / Degrees(45.0) returns an f32 (same for Rem)
Adding or subtracting angles always returns the leff hand side operand instead of always returning Radians

This is unopinionated and more flexible
This is a relatively common Rust convention, e.g. Instant + Duration returns Instant like djeedai mentioned
This is what several angle crates like ang and angular_units seem to do

The PR is still definitely controversial and I'm not entirely sure about all of the details myself, but I think it does look more reasonable now.
As for this:

no clear example where some public API is improved; instead PR shows an internal change which doesn't benefit at all from the abstraction

I agree that my examples might not have been particularly convincing, and I think this is also quite subjective.
In my eyes, the main benefit comes from the explicitness. You know that a value is an angle (of a specific unit) without having to look at documentation or surrounding context. "Code is read more than it's written."
You could argue that radians are the unit used everywhere internally, but to know that, you need to know the codebase already. If you don't know that, you need to always double check.
A few examples where angle types make things more explicit and/or ergonomic.
With methods like gizmos.arc_2d, there are just three floats in a row. You can't tell what they represent without looking at the function signature. If the method used angle types, you'd at least know that two of them are angles.
// Before
gizmos.arc_2d(
    Vec2::ZERO,
    0.0,
    std::f32::consts::PI / 4.0,
    1.0,
    Color::GREEN
);

// After
gizmos.arc_2d(
    Vec2::ZERO,
    Radians(0.0),
    Radians::PI / 4.0,
    1.0,
    Color::GREEN
);

Of course, it's still not perfectly clear what each value does if you haven't seen the method before, but it is more explicit.
I have a PR to add more math helpers for primitive shapes (#10632), and it has some methods that return angles. It would be really nice if they could have units.
Currently, they (e.g. this) can use separate _degrees and _radians variants, but if there were units, we could either have just one variant (with a specific unit return type), keep them as they are but specify the return type as an angle, or even unify them using the Angle trait:
// Before
pub fn internal_angle_degrees(&self) -> f32 {
    (self.sides - 2) as f32 * 180.0 / self.sides as f32
}
pub fn internal_angle_radians(&self) -> f32 {
    (self.sides - 2) as f32 * PI / self.sides as f32
}

// After
pub fn internal_angle<T: Angle>(&self) -> T {
    (self.sides - 2) as f32 * Angle::HALF / self.sides as f32
}

// or just keep the separate functions, but return Degrees/Radians

Another ergonomics improvement is that sometimes degrees are just easier to work with. I myself used to struggle getting Transform rotations correct before learning how radians work in high school (not everyone even goes to high school), and it still isn't as intuitive as degrees.
With separate angle types, you also don't need to import PI everywhere. An example brought up on Discord, slightly modified:
// Before
transform.rotate_x(std::f32::consts::PI / 2.0);

// After
transform.rotate_x(Degrees(90.0));

With the old approach, you need to (1) know that the method takes radians, and (2) think of what PI / 2 looks like on a unit circle. Unless you have a strong background in mathematics, I'd argue that just 90 degrees is much more intuitive and quick to understand. You don't need to worry about the unit taken by rotate_x, or import anything (other than the Bevy prelude).
Of course, you could just do 90.0.to_radians() too, but I find it to still be a bit less clear, and you still need to know that the expected value is radians.

Closing for now, see https://github.com/bevyengine/bevy/issues/11132#issuecomment-1881794595. This can be reopened (or adopted) if there's more consensus that we should move forward with this or some similar approach, but at the moment it seems too controversial and perhaps unnecessary, and I myself am not entirely sure if we need/want this.


Hellfire passives missing when importing profile

When I import characters from my profile the passives are missing from their Hellfire Amulets, can't add the passive back with "add stat" so have to make a new amulet to copy what's used on the character. Another side effect of the new API?

Probably, I'll check when I get the chance.
What do you mean you can't add the passive back? Can you unlock the item and add the passive?

If I unlock the item I can only add normal secondaries (resists, goldfind etc), but if I use the dropdown to change the HFA into another amulet then change it back to HFA I can select a passive. Or delete the HFA and create a new one and I can select a passive.

Oh right yeah I forgot you can't add those. Maybe I should add an additional check to add missing passives to legendaries.

Should work now.


Cannot compile. Execution failed for task ':server:processReleaseResources'.

I'm trying to compile scrcpy on ubuntu 20.04 but I'm getting this output:
> Task :server:processReleaseResources FAILED
> Task :server:mergeReleaseNativeLibs NO-SOURCE

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':server:processReleaseResources'.
> A failure occurred while executing com.android.build.gradle.internal.res.LinkApplicationAndroidResourcesTask$TaskAction
   > AAPT2 aapt2-7.0.3-7396180-linux Daemon #0: Daemon startup failed
     This should not happen under normal circumstances, please file an issue if it does.

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

I tried --info and --debug on ninja and meson but appears like they don't belong to any of them.
Any idea what I may be missing here?

Looks like a gradle/Android gradle plugin: https://stackoverflow.com/questions/55861519/upgraded-to-android-studio-3-4-aapt2internalexception-aapt2-daemon-startup-f

That's weird, because I'm running ninja directly from the command line inside docker... Thank you anyway. I may be able to use some of the answers for myself

Found the problem. $HOME/.gradle needs to be executable (mount options) but it wasn't due to one of the dependencies to compile java actually being an executable (maybe it's many but I only failed at one of them).


Catastrophic performance failure with dask

Convolving then spectral interpolating can result in catastrophic performance failures with dask cubes.
Example:
ch3cnK0 = SpectralCube.read('CH3CN_8(0)-7(0).fits')
ch3cnK0_rg = ch3cnK0.convolve_to(h2cscube.beams.common_beam()).spectral_interpolate(h2cscube.spectral_axis)

cube = SpectralCube.read('../imaging_results/source_ab_137_spw69_clean_2sigma_n50000_masked_3sigma_pbmask0p18.image')
h2cscube = cube.with_spectral_unit(u.km/u.s, velocity_convention='radio', rest_value=137.371051*u.GHz).spectral_slab(-10*u.km/u.s, 80*u.km/u.s)
mask = (h2cscube > 5*u.mJy/u.beam).include().compute()

ch3cnK0_rg.with_mask(mask).write('CH3CN_8(0)-7(0)_masked.fits', overwrite=True)

For a 512x512x90 cube, this takes ~30s + 3m for FITS.
For dask...
ch3cnK0_dask_cube = SpectralCube.read('../imaging_results/source_ab_146_spw51_clean_2sigma_n50000_masked_3sigma_pbmask0p18.image').with_spectral_unit(u.km/u.s, velocity_convention='radio', rest_value=147.1745883*u.GHz).spectral_slab(-10*u.km/u.s, 80*u.km/u.s)
ch3cnK0_dc_rg = ch3cnK0_dask_cube.convolve_to(h2cscube.beams.common_beam()).spectral_interpolate(h2cscube.spectral_axis)
mch3cnK0_dc_rg = ch3cnK0_dc_rg.with_mask(mask)
# the above is very fast b/c it was lazy

result so far:
In [159]: ch3cnK0_dc_rg
Out[159]:
DaskSpectralCube with shape=(86, 512, 512) and unit=Jy / beam and chunk size (86, 1, 1):
 n_x:    512  type_x: RA---SIN  unit_x: deg    range:   266.528130 deg:  266.560501 deg
 n_y:    512  type_y: DEC--SIN  unit_y: deg    range:   -28.719152 deg:  -28.690763 deg
 n_s:     86  type_s: VRAD      unit_s: m / s  range:   -10386.411 m / s:   80192.488 m / s

In [160]: ch3cnK0_dc_rg._data
Out[160]: dask.array<getitem, shape=(86, 512, 512), dtype=float32, chunksize=(86, 1, 1), chunktype=numpy.ndarray>

In [161]: mch3cnK0_dc_rg = ch3cnK0_dc_rg.with_mask(mask)

In [162]: with ProgressBar():
     ...:     mch3cnK0_dc_rg.write('TEST.fits')
     ...:
     ...:
[                                        ] | 0% Completed | 10min 57.6s

This is already too slow to use.  I'm posting this so I don't lose what I've written, then I'll retry with a different chunking scheme.

OK, rechunking it solved the problem:
In [166]: with ProgressBar():
     ...:     t0=time.time()
     ...:     mch3cnK0_dc_rg.rechunk().write('TEST.fits', overwrite=True)
     ...:     print(time.time()-t0)
     ...:
     ...:
[########################################] | 100% Completed |  2min 46.0s
166.75409722328186

So we just need a healthier choice of chunk size for the spectral_interpolate command

(...but, somewhat aside, it is really frustrating to have a progressbar going that gives you no clue about how close to completing it is)


Add missing tools required for Docker

This change is

Closing this for now as #12 contains these changes.


Inlay hints preferences aren't taken into account with Swift 5.7

Describe the bug
When using Swift 5.7, disabling inlay hints doesn't seem to work (tested in a Linux container), so they are always displayed.
Environment

VS Code devcontainer with swiftlang/swift:nightly-5.7-focal image
Swift version (output of swift --version): Swift version 5.7-dev (LLVM eecf02df5133efe, Swift ad06e7d7251311a)
Visual Studio Code version: Version: 1.68.1 (Universal)
vscode-swift version: v0.6.0 preview

Additional context
In my quick tests it seemed to work fine  with older Swift versions

Inlay hints and Swift 5.7 are in a state of flux at the moment as we are in the process of moving across to the official LSP spec version of Inlay hints which is now used in VSCode. SourceKit-LSP 5.7 is now generating the official spec Inlay Hints which VSCode picks up automatically. But we still have the old system running as well. We need to release a new version of the extension which disables the old Inlay Hints for Swift 5.7 and above.
The official Inlay Hints display is controlled by VSCode setting Editor › Inlay Hints. It has some nice options where you can display the Inlay hints temporarily when a key is pressed.

@adam-fowler Thank you! I didn't know VS Code had something specific its its extension API to make these settings more global.

Closing as v0.7.0 adds comment pointing to correct option.


Upgrade text buffer

I'm opening this PR to test the optimization from https://github.com/atom/text-buffer/pull/312 against Atom. I think it should be fine, but I want to see a green Atom build first before publishing an official text-buffer release.

Failure is a flake. Merging.

Fixes #14952


Adding check on organization name

Adding validation that org name must be valid before submitting form. Adds alert icon to invalid orgname. Does not display message since format requirements are already present under input.

@bcaton85 Can you also add a check for the max length? Should flag on >255 characters.

Good catch!


[BugFix] Set COUNTER_QUERY_QUEUE_PENDING correctly

What type of PR is this：

[x] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Problem Summary(Required) ：

QueryQueueManager::maybeWait decrease COUNTER_QUERY_QUEUE_PENDING in the finally block, but increment of COUNTER_QUERY_QUEUE_PENDING is lost sometimes.
Checklist:

[x] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto backported to target branch

[x] 2.5
[ ] 2.4
[ ] 2.3
[ ] 2.2

[FE PR Coverage Check]
:heart_eyes: pass : 7 / 7 (100.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/qe/QueryQueueManager.java
7
7
100.00%
[]

run starrocks_admit_test

run starrocks_admit_test

@Mergifyio backport branch-2.5


Randomly-generated ids triggers mismatch warning with SSR

Specifications
@button-inc/bcgov-theme = 1.0.1
Describe the bug
When rendering the Navigation component and using nextjs's Server-side rendering, the following warming appears in the console (maybe only in development mode)
Warning: Prop id did not match. Server: "ntwkhfbh73g9tvz0yxnlk-toggle" Client: "k34mccn6xehpxmxv7x6rd-toggle"
The id is the one from the menu toggle input, which is randomly generated on both the server and the client, causing a mismatch
Additional context
Not quite sure what the effect of this warning is. At the minimum this is detrimental to the developers' experience, as the warning is displayed on every render (and may be displayed for multiple components, I haven't tested rendering complex pages with SSR yet)

FYI this is causing errors (https://nextjs.org/docs/messages/react-hydration-error) and requiring workarounds with performance impacts and increasing test flakyness.


(PUP-1343) Use chkconfig --add to ensure K-symlinks get installed

On RHEL/CentOS 5 systems, the use of chkconfig on to enable a service
does not create the K-symlinks in /etc/rc.d to shut down the service.
Running chkconfig --add before chkconfig on fixes this issue, and
should be harmless on the unaffected OS versions.
The rspec unit test has been updated, and a new acceptance test
included to validate the bugfix.

CLA signed by all contributors.


fix bugs and use builtin format function as PEP-3101 suggest

There is a bug in parse_int, '.' should be ','
Also, PEP-3101 suggest us to use builtin function format instead of %
Your API is awesome :smile:

parse_int should really be a .

The function is used to parse the numbers that are formatted by ogame, and they uses a . for the thousands separator.
>>> int(u'3.091'.replace('.', '').strip())
3091
>>> int(u'3.091'.replace(',', '').strip())
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
ValueError: invalid literal for int() with base 10: '3.091'

Thank you ! I'm glad you like the library :)

That's weird, our server display 3,425 instead of 3.425 O_O?

That's what I thought !
What domain are you playing on ?
I'm on en.ogame.gameforge.com.

I'm on tw.ogame.gameforge.com

Ok, so I guess the right fix would be to verify which domain you uses, and change the "thousands separator" accordingly.

But how do we know which server use ',' and which server use '.' ?
Maybe replace both to empty would be a easier solution? replace(',', '').replace('.', '')

Since ogame never use any floating point numbers, that would actually work.
Otherwise, I was thinking about:

Put a global variable thousands_separator = '.' here
change this for return int(text.replace(thousands_separator, '').strip())
Here you add a condition if domain == 'domain_a': thousands_separator = ','
(something like that)

OK, I understand~
So would you prefer I fix it by replacing both to empty string
or verify the domain and give it the right "thousands separator" to replace ?
I can do both.

I guess we can go the easy way

OK I update a new commit.
you can take a look at it :smiley:


Resolve jobs abao tests

Run postman tests before abao tests to populate data
Re-enable abao tests for jobs
Review Checklist

Tests were added to cover all code changes
Documentation was added / updated
Code and tests follow standards in CONTRIBUTING.md

All tests pass for me, so LGTM.
@nagem May want to pull latest fly/fly if testing via that environment.

LGTM!


Add changelog for the v1.0.0-alpha.1 release

What this PR does / why we need it:
This PR adds the changelog for the v1.0.0-alpha.1 release. The planned release date is today, May 11th.
Special notes for your reviewer:
The v1beta1 API has been intentionally left out from the changelog as it's still not user-facing.
Does this PR introduce a user-facing change?:
NONE

/assign @kron4eg

/retest

/retest


Fill all outlines and hide metrics

This change fills the outline for the active layer in addition to the inactive layers and hides the metrics of the active layer.
The code change should be mostly self-explanatory, with drawLayer_atPoint_asActive_attributes_ now using the default layer-drawing implementation of the graphics view and drawMetricsForLayer_atPoint_asActive_ now doing nothing. If you want to keep the metrics, you can also just partially accept this pull request.

Thank you very much!


Why do MS promote PC Mover Express?

PC mover Express does not use USMT and not even a Microsoft supported migration method?
None of the Modern UI app settings were migrated and none of the migrated accounts Office Modern Authentication/ADAL worked afterwards.
We tried also moving over the Adobe CC suite with "PC Mover Professional" and NOTHING worked afterwards. Not even Bridge?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: cde8580a-bd82-ebd2-3767-f3ee662a904e
Version Independent ID: 94323219-e4ed-8761-723e-06be33c3b9cc
Content: User State Migration Tool (USMT) Overview (Windows 10)
Content Source: windows/deployment/usmt/usmt-overview.md
Service: unspecified
GitHub Login: @greg-lindsay
Microsoft Alias: greglin

To use USMT st.alone an easy way is to use USMTGUI. It has been available for 10 years


[iOS] Use enum type inference

Thanks, merged manually https://github.com/hfhbd/ComposeTodo/pull/894


python syntax for remote sources?

It appears the current interfaces provides us a pure-python syntax only for pandas data.frames.  It would be great to have a more general syntax for remote connections, (including remote parquet as in #150 )
Following up from https://github.com/PRQL/pyprql/issues/150#issuecomment-1467116287 maybe a syntax similar to how existing SQL-based modules work (i.e. basically establish some kind of connection object and then pass the prql a string to that) could be used here?

Yup, I think something like duckdb.prql would be a great option, though I realize PRQL is intended to be backend agnostic so maybe that seems less than ideal.
Maybe the most obvious approach is merely to provide bindings to SQL translation  (Maybe that's already possible and I've just overlooked it)?  This is the approach taken in @eitsupi 's very nice prqlr package, e.g. https://eitsupi.github.io/prqlr/articles/knitr.html, which supports both the R equivalent of jupyter-magic with various backends, including in-memory data.frames, while for scripts, it just generates SQL strings which a user could pass to duckdb.sql() or whatever other backend db engine they prefer, e.g. something like
import duckdb, pyprql
con = duckdb.connect()

query = pyprql.compile(f'''
from invoices
filter invoice_date >= @1970-01-16
derive [
  transaction_fees = 0.8,
  income = total - transaction_fees
]
filter income > 1
group customer_id (
  aggregate [
    average total,
    sum_income = sum income,
    ct = count,
  ]
)
''')

con.execute(query).df()

If we want to simply compile, pyprql is not necessary.
It is complicated, but just use prql-python (prqlr is a package that implements almost the same functionality as prql-python in R)
Since this is just a string transformation, it can easily be used in combination with duckdb.
import duckdb
import polars as pl
import prql_python as prql

df = pl.DataFrame({'a': 42})
opts = prql.CompileOptions(target = "sql.duckdb")

duckdb.sql(prql.compile("from df", options=opts)).pl()

I agree that it would be great to have these examples in the documentation.

Thanks @eitsupi , this is great, precisely the workflow I was looking for!
Yes, I found the documentation a bit confusing on this, e.g. the PRQL README mentions only pyprql, I didn't realize it also contained bindings for most languages, but otherwise I think we can close this.

Great, we didn't explain that, so I added to the docs in #154.
Please reopen / add a new issue for anything!


About Datasets

你好，
请问训练数据集是公开的吗？
请问测试集使用的是UBC 100个test视频的每一帧经过animate anyone后的结果作为输入吗？能否公开测试数据？

We will not be releasing the training datasets; however, you can construct your own dataset following the steps outlined in the paper.

Will you release the test dataset?


Generate BOM

I just had an idea - java-deptools could generate BOM file (bill of materials) for all packages in package collection. BOM is just a Maven POM file which in its dependencyManagement section would list all artifacts provided in given collection (Fedora version).
Use cases:

for developers who want to develop software easily packageable; they would use artifacts from Maven Central, but versions which are available in Fedora, resulting in project that is easy to package - wouldn't require patching,
for packagers to help debugging packaging problems by using upstream binaries with versions matching Fedora versions.

Implementation shouldn't be difficult - java-deptools already opens all Java RPMs, it would just need to extract info about provided artifacts from Maven metadata and output that info as XML file. (At first I thought about writing a custom script to generate BOM from YUM metadata, but then I realized that version we put in provides is transformed, for example dashes are replaced with dots.)

Sounds reasonable. How should the BOM be published?


nixos/lib/make-disk-image.nix: fix systemd-boot-builder clobbering /homeless-shelter

Description of changes
systemd-boot-builder.py calls nix-env --list-generations which creates $HOME/.nix-defexpr/channels/nixos if it doesn't exist. This would cause a folder /homeless-shelter to show up in the final image which in turn breaks nix builds in the target image if sandboxing is turned off (as /homeless-shelter is never allowed to exist).
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Maybe an alternative fix:
Replace the nix-env --list-generations call in systemd-boot-builder.py with a ls /nix/var/nix/profiles/system call?

Replace the nix-env --list-generations call in systemd-boot-builder.py with a ls /nix/var/nix/profiles/system call?

This is what lanzaboote does. @JulienMalka do you have an opinion?

Such a change would be fine by me :)


Fixed a crash of MoleculeNetDataset when faulty smiles are encountered

In MoleculeNetDataset ".read_in_memory" and ".set_attributes" methods: if molecule is None, None is added for every property list. Further down there is the following line however:
self.assign_property("graph_size", [len(x) for x in node_attributes]

When iterating over one of the None elements in node_attributes there was an Exception NoneType object has no attribute length.
Changed the list comprehension to account for that.

Yes, thanks. Does both Openbabel and RDkit fail for a smile?

I think it was only RDKit, but I am not sure


Fix date time format localtime issue

Stack on #7195(commit).
According to the documentation, I imported the missing add-all-tz.js, and it should work properly again.
Checked on the Galaxy S22 and iOS simulator, the timezone in the screenshot is based on Central Time (UTC-6).

This may not be feasible, but for the en-GB locale would it be possible to still use the Lingui date formatting rather than the polyfill?
The polyfill sets the format as [date], [time] for en-GB on iOS (not sure about other platforms):

Which I think doesn't look as good as Lingui displays it, as [date] at [time]:

This may not be feasible, but for the en-GB locale would it be possible to still use the Lingui date formatting rather than the polyfill?

As mentioned here

Lingui does not format dates by itself. It internally uses https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl.
If dates are not formatted correctly for you it's most likely because you need to set up the polyfill: https://lingui.dev/tutorials/react-native#polyfilling-intl-apis

Also can refer to the related discussion in #7138. After Lingui adds support for date formatting, polyfills will still need to be introduced.
After applying the polyfill, there is indeed some regression with en-GB, as you mentioned. But I believe it is still within an acceptable range compared to the issues with Chinese and Japanese (I also checked the other supported app languages, and there were no particularly severe regressions).
This does not mean en-GB has been compromised. I noticed that<EMAIL_ADDRESS>defines how to format date outputs. I will look for ways to improve it upstream to reach the level prior to the polyfill.
This is a improvement process, but first, let’s fix the date display for Chinese, as it currently uses the en-US date format to display post times. I’d like to hear your thoughts on this.

No longer using polyfill, fixing this issue by modifying the language codes for Chinese. #7235


Minor correction to docker instructions in README

Adds a mount option to the docker command in README.adoc to avoid access permission problem (thanks to David Smith).

This is very minor, so I'll just merge it myself.


Symfony Bundle

This should be installable with composer and setup with symfony flex.
Im going to fork and see if I can integrate it into a installable bundle with little config effort to easily add this to existing symfony projects. I will create a PR if successful 😉

Hello, oh ok thank for contribute :)


Reload: "data" is already destructured by language and namespace.

This seems to fix the reload functionality for me (#5).
Would really appreciate it if one of the maintainers could review it.

omg...i totally forgot about this open issue...sorry for that.

@jamuhl Any change of a release in the coming days?

yes...will publish an update asap...today

should be in<EMAIL_ADDRESS>

👍 Thank you.


fix(alert): clean up code, tokens and example

ref #292

👋 Thanks for creating a pull request! 🚀 Checkout the storybook we created for it here.