activate #defines to remove boost dependencies

Uncommenting #define CPPLOG_NO_SYSTEM_IDS removes the compile-time dependency on boost include files and uncommenting #define CPPLOG_NO_THREADING removes the link time dependency on boost libraries; both issues are described at https://github.com/andrew-d/cpplog/issues/12 and the issue is resolved by this change.

DOH! i wasn't aware all my changes show up in the same pull request...
so does that mean i have to branch my fork to group changes together ??
or is there another way to have multiple pull requests ?
hmmm, i really like the git / github concept, but looks like i need some more practice.
sorry about any confusion caused.
anyway, 8a19173 is the change i originally meant to be committed to the master.
the remaining changes inverse the logic of the #defines used; instead of having a double negation, i.e. NO in the define name and checking with #ifndef, the code without anything defined is considered a reasonable default and additional features are enabled by setting the #define. i think that is much more straight forward.

Wow, nice refactor :D
I'm away from my main dev machine for today, so I'll look over and test the changes tomorrow, and if everything is alright, merge it all.
Best Regards.


Deep Sclerectomy

137760 GLAUCOMA, PRIMARY OPEN ANGLE; POAG
Varga Z, Shaarawy T. Deep sclerectomy: safety and efficacy. Middle East Afr J Ophthalmol. 2009 Jul;16(3):123-6. doi: 10.4103/0974-9233.56223. PMID: 20142976; PMCID: PMC2813598.
https://www.ncbi.nlm.nih.gov/pmc/articles/PMC2813598/
Deep sclerectomy is a surgical procedure used to treat glaucoma, a condition that can damage the optic nerve and lead to vision loss. This procedure involves creating a small flap in the sclera, the outermost layer of the eye, and removing a portion of the trabecular meshwork, the area of the eye responsible for draining aqueous humor, the fluid that circulates inside the eye.
During deep sclerectomy, a small incision is made in the conjunctiva, the membrane that covers the white part of the eye, and a thin flap is created in the sclera. A small opening is then made in the trabecular meshwork, and a portion of the meshwork is removed using a special surgical tool. The flap in the sclera is then repositioned, and a small amount of viscoelastic material may be used to maintain the shape of the space created by the procedure.
Deep sclerectomy is designed to improve the outflow of aqueous humor and lower intraocular pressure, which can help to prevent damage to the optic nerve. The procedure can be performed alone or in combination with cataract surgery, a common procedure to remove the natural lens of the eye.

deep sclerectomy was recently added MAXO:0000958
Let me know if it needs more context.
Thanks.

closing ticket. Sorry I have taken my time. I will try get to your tickets soon.


Add feature to embed everything even in debug mode

Sometimes that's useful, rust-embed has it too, so why not add it. Shouldn't be too hard.

Implemented in #11

Implemented in #11


Exclude machine-config-daemon from passwd_binaries.json

Description
A collection of policy exclusion updates as we gather experience about OCP workloads.
WIP for 4.5
Checklist

[ ] Investigated and inspected CI test results
[ ] Unit test and regression tests added
[ ] Evaluated and added CHANGELOG entry if required
[ ] Determined and documented upgrade steps
[ ] Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)

If any of these don't apply, please comment below.
Testing Performed
Here I tell how I validated my change
TODO(replace-me)
Use this space to explain how you validated that your change functions exactly how you expect it.
Feel free to attach JSON snippets, curl commands, screenshots, etc. Apply a simple benchmark: would the information you
provided convince any reviewer or any external reader that you did enough to validate your change.
It is acceptable to assume trust and keep this section light, e.g. as a bullet-point list.
It is acceptable to skip testing in cases when CI is sufficient, or it's a markdown or code comment change only.
It is also acceptable to skip testing for changes that are too taxing to test before merging. In such case you are
responsible for the change after it gets merged which includes reverting, fixing, etc. Make sure you validate the change
ASAP after it gets merged or explain in PR when the validation will be performed.
Explain here why you skipped testing in case you did so.
Have you created automated tests for your change? Explain here which validation activities you did manually and why so.
Reminder for reviewers
In addition to reviewing code here, reviewers must also review testing and request further testing in case the
performed one does not seem sufficient. As a reviewer, you must not approve the change until you understand the
performed testing and you are satisfied with it.

@alexeykazakov Please fold this into an already existing migration for 4.5 - 199_to_200

Superseded by https://github.com/stackrox/stackrox/pull/11822


Trap Server support needed with an easy to use API

PySNMP by etingof had a roundabout way of setting up a v2 TRAP server for receiving SNMP Traps and minimal support for V3 Trap.
We used pysnmp-bw in order to get v2 and v3 Trap support via SNMP, and the difference can be merged into pysnmp-lexstudio as well.
Would you be okay with me creating a PR and merging those changes (after writing a few UTs and checking the code?)

It is not a good idea to monitor TRAP/INFORM with Python due to performance limitations, but the changes in pysnmp-bw will be reviewed. If maintaining them isn't complicated, the commits will be cherry picked.

pysnmp-bw made a few changes in the underlying layers which currently we have no way to verify necessary or not. Thus, unable to move further on this item.

Sure. Can take a look. I think there were a few PRs I had made there, seeing that there were a few bugs in asyncio at that point in time. I can take a look and see if it is necessary

After some further testing we found the changes broke all test cases developed so far. We decided to close this request,

The new types introduced in pysnmp-bw are not mandatory. We developed our own trap listener for unit testing and it wasn't much work, https://github.com/lextudio/pysnmp/blob/v6.0.6/tests/manager_context.py
In release 6.0 we fully switched to asyncio, and the patches in pysnmp-bw are not compatible at least for now.

We might revisit such an idea in the future.


Port ATO-495 to 3.4.x

Summary

port #11924

@sanchariGr I've based this branch on disabled_flaky_tests and reverted your commit in this branch, so that when it is merged, you do not have to do anything to re-enable the tests that you have temporarily disabled.


completely refactor how we manage blocking and unblocking threads

This hides a lot of invariants from the implementation of the synchronization primitives, and makes sure we never have to release or acquire a vector clock on another thread but the active one.

@bors r+

:pushpin: Commit 2e1bf9cbc44cbd3ef1dae90fecd641f7bb2da431 has been approved by RalfJung
It is now in the queue for this repository.

:hourglass: Testing commit 2e1bf9cbc44cbd3ef1dae90fecd641f7bb2da431 with merge 5cbb61fce80bce3b639a757c2b1ce57322e4118b...

:sunny: Test successful - checks-actions
Approved by: RalfJung
Pushing 5cbb61fce80bce3b639a757c2b1ce57322e4118b to master...


unable to get storybook working

Hi, thanks for the awesome template. Unfortunately, running storybook init doesn't add any of the correct directories. Any ideas?

Would also love to this working with Storybook

@jsmellz I've never tried storybook for this project. So, it can definitely be hard to integrate the boilerplate with Storybook.
Totally Ok to add Storybook to this project. Open to suggestion and feedback.

@0xJacobean
The import alias like '@' is causing the problem.
You have to resolve it on the storybook main config file like this
Here is the official docs for the config.
Here is great resource to setup the storybook on nextjs from the creator.
@markatli @ixartz
Making a specific branch with storybook integrated as default will be awesome.

Someone has already open a pull request: https://github.com/ixartz/Next-js-Boilerplate/pull/35
But, he didn't responded back

@ixartz ok, so I prepared to pr, but wanna your advice.

bugs in npm v8
check this link: https://github.com/storybookjs/storybook/issues/18298
I'm using node v18 and npm v8. I try setting storybook and faced this issue.

Do migrate npm7, storybook makes .npmrc.

legacy-peer-deps=true

This is necessary to maintain package-lock, and there is no problem when someone else clones the project.
So is it okay to make pr with this?

storybook default components
I don't know if you've ever used storybook.
When you first set this up, it create example components: a button, a header, and a page.
Is it okay to make a pr with these included? If not, I'll remove components.

@CO0Ki3 Thank you for your help. But here is my experience:

I'm not against legacy-peer-deps but the CI will be failing, at least last time I'm using legacy-peer-deps (not with Storybook) and it fails the CI. Is it any we can avoid legacy-peer-deps?
Does it work with npm9 without legacy-peer-deps?

I have never used Storybook before, my experience is limited. But, I think we should remove the default component that are not used in the boilerplate.

So, instead of a storybook of Logged Out, we can create a storybook of https://github.com/ixartz/Next-js-Boilerplate/blob/main/src/pages/index.tsx or https://github.com/ixartz/Next-js-Boilerplate/blob/main/src/pages/about.tsx
Currently, the boilerplate doesn't have a small component, I think it make sense to add a button component and create a new directory named components. Then, we can create a new storybook for the new button component.
What do you think?

@ixartz Thank you for advice!

I haven't seen legacy-peer-deps cause problems when project hasn't storybook.
I'll check to see if there's a way to apply it only to storybook.
I have never used npm9. However, since it is a higher version, it is expected that there will be problems.
I'll check this one more time.

I also agree with you.

In my opinion, the first problem should be solved first.
When it's solved, I will create an example with the page of this project and a simple button component.

@CO0Ki3 Thank you for your response. We are totally aligned, definitively we should solve the first one. We can even merge the first one and then, tackling the second. It should make a smaller PR and make things easier to manage.

@ixartz Cool:)

@ixartz well.. npm v19 also make problem. So I'm finding how can use legacy-peer-deps only storybook:)

@CO0Ki3 You can open a new pull request and you can directly check on CI if it works.

Storybook 7 will automatically support Next.js out of the box: https://storybook.js.org/blog/integrate-nextjs-and-storybook-automatically/
I think it will make sense to add Storybook 7 directly, it's expected to be released in January.


feature : Adding our Service page in vigybag

i Want to add our service page in vigybag

sorry due to unavailibility... I can't assign you this  issue on that time


doc:remove python 3.7, 3.8 and add 3.10

Remove autobuild support for python 3.7 and 3.8, and add support for 3.10

@all-contributors please add @Malephilosopher for code


More button getting hide on clicking

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?
when i am clicking on more its dropdown menu hides the more button, also there is two more buttons

Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?
when i am clicking on more its dropdown menu hides the more button, also there is two more buttons

Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

@Ketanop321
Assigned!
Make sure to attach before & after screenshots in your PR. Also, star the repo before working on it. While creating your PR, ensure you pull all existing changes beforehand to avoid conflicts.
Happy open-source contributing!


[Request for External] table 11000003 "Detail Line" - CalculateVariation

Hello,
In GitHub request #16980, it was requested for procedure CalculateVariation to be marked as global.
Checking in BC 20.1.39959.0, the procedure is still local.
Can you please have a look?
Thank you,

Already done


Start cleaning up imports and naming

Adjusting most of the imports to follow the standard of "from path
import module" (instead of "from fully qualified module import things
in module")
Adding an init.py in the root of the library that delegates names to
their respective modules, to make using the library easier
Renaming a bunch of things from Database -> Spanner
type.py has a lot of things that need to be updated, which will be
addressed in a future PR

Anything else?


Fixed textRectForBounds for text that is horizontally aligned.

This fixes an issue where label width is greater text width and text is right or center aligned.

Thanks @mpurland!

@jhersh This fix appears to work for single line strings but does not work for multiple lines or where the paragraph style textAlignment for a glyph on a line differs.

@mpurland additional PRs are welcome :)

@jhersh Not sure what the fix for this one is. The issue for the hit area appears when the label textAlignment differs than the line attributed NSParagraphStyleAttributeName alignment, however if you set the alignment = label textAlignment and excluding the above fix it works.

@jhersh A more general fix that works. #528


Metaproteomic public repositories (from Protein database downloader)

Links to metaproteomic public repositories
IDEA:
It would be a good idea to add a few common publically available metaproteomics databases (see HOMD database for an example  below) to the Protein database downloader tool in Galaxy (https://github.com/galaxyproteomics/tools-galaxyp/tree/master/tools/dbbuilder).
Please suggest links for some useful metaproteomics databases.
HOMD database: ftp://ftp.homd.org/HOMD_annotated_genomes_archive/oral_microbiome_dynamic.aa.zip

General question, does anyone has good connections to those databases? It would be great to get a tighter integration with Galaxy via data_sources, for this we need help from the database developers.

Hello:  iMicrobe hosts quite a bit of environmental data as well as the CAMERA reference sequences (funded by the Moore Foundation years ago): ftp://ftp.imicrobe.us/ & imicrobe.us.
Hope this helps!

Human Microbiome Project
Reference Genomes from GI
http://downloads.hmpdacc.org/data/reference_genomes/body_sites/Gastrointestinal_tract.pep.fsa
HMP Metagenome
ftp://public-ftp.hmpdacc.org/HMGI/stool/
MetaHit
http://www.nature.com/nature/journal/v464/n7285/full/nature08821.html
http://www.bork.embl.de/~arumugam/Qin_et_al_2010/
BGI
http://gutmeta.genomics.org.cn/

Some of the databases that can be downloaded through the "Metaproteomics database downloader" tool (Protein database downloader tool in Galaxy (https://github.com/galaxyproteomics/tools-galaxyp/tree/master/tools/dbbuilder) would be (from some of the suggestions above):
HMP airways: http://downloads.hmpdacc.org/data/reference_genomes/body_sites/Airways.pep.fsa
HMP Blood: http://downloads.hmpdacc.org/data/reference_genomes/body_sites/Blood.pep.fsa
HMP Gastro-intestinal tract: http://downloads.hmpdacc.org/data/reference_genomes/body_sites/Gastrointestinal_tract.pep.fsa
HMP Oral: http://downloads.hmpdacc.org/data/reference_genomes/body_sites/Oral.pep.fsa
HMP Skin: http://downloads.hmpdacc.org/data/reference_genomes/body_sites/Skin.pep.fsa
HMP urogenital Tract: http://downloads.hmpdacc.org/data/reference_genomes/body_sites/Urogenital_tract.pep.fsa
HMP All Body Sites: http://downloads.hmpdacc.org/data/reference_genomes/all_pep_20141006.tar.gz
ftp://public.genomics.org.cn/BGI/gutmeta/UniSet/UniGene.pep.gz
http://www.bork.embl.de/~arumugam/Qin_et_al_2010/frequent_microbe_proteins.fasta.gz
Unfortunately, http://www.uniprot.org/help/unimes has been retired. However, if we can access information from https://www.ebi.ac.uk/metagenomics/ and generate customized databases using WGS data for SixGill, Omega2 and 16S rRNA sequencing data using the proposed UniProt API that would be great !
Ideas from @alessandrotanca, @ Prof Rudney, Carolin Kolmeder, Tim Griffin, @jhervey4 @stuppie @bgruening @jj-umn would be useful on what interface would be best to download data that can be used as an input for further utlization / analysis.

There has been an extension of the data by Qin et al. 2010 in 2014 by Li et al. (http://www.nature.com/nbt/journal/v32/n8/full/nbt.2942.html; behind this link are ENA numbers from where to derive the data). And just an anecdotal note: The unimes was anyway a not very deep collection of data.

We also have a good feedback regarding the human gut microbiota public database mentioned by Carolin. Another interesting public database, but based on the mouse gut microbiota, can be found here:
http://gigadb.org/dataset/view/id/100114/token/mZlMYJIF04LshpgP

It might already be on galaxy but something useful would be a tool for downloading genomes from ncbi (genbank). Some tool can be found here https://github.com/kblin/ncbi-genome-download . For earlier work we have had in-house python scripts to download a set of genomes (human intestine related microbes; the list can be found in Kolmeder et al. PLoS one 11(4):e0153294, Table S3) from ncbi.


Error when building esy-skia on MacOS

I went through the steps of installing the quick-start, but it fails at the build stage. I am on MacOS Big Sur and using esy 0.6.11. The same error happens when trying to build the Onivim2 editor.
esy_libjpeg_turbo-dc3b4679/include -Wno-poison-system-directories -std=c++11 -fvisibility-inlines-hidden -fno-exceptions -fno-rtti -Wnon-virtual-dtor -Wno-noexcept-type -Wno-abstract-vbase-init -Wno-weak-vtables -Wno-c++98-compat -Wno-c++98-compat-pedantic -Wno-undefined-func-template -c ../../src/ports/SkFontHost_mac.cpp -o obj/src/ports/libskia.SkFontHost_mac.o
    ../../src/ports/SkFontHost_mac.cpp:1721:29: error: multi-character character constant [-Werror,-Wfour-char-constants]
        if (!this->getTableSize('glyf') || !this->getTableSize('loca')) {
                                ^
    ../../src/ports/SkFontHost_mac.cpp:1721:60: error: multi-character character constant [-Werror,-Wfour-char-constants]
        if (!this->getTableSize('glyf') || !this->getTableSize('loca')) {
                                                               ^
    2 errors generated.
    [210/1196] compile ../../third_party/externals/libpng/pngget.c
    [211/1196] compile ../../third_party/externals/icu/source/common/ulistformatter.cpp
    [212/1196] compile ../../third_party/externals/icu/source/common/uiter.cpp
    [213/1196] compile ../../third_party/externals/libpng/pngpread.c
    [214/1196] compile ../../third_party/externals/icu/source/common/uloc_keytype.cpp
    [215/1196] compile ../../third_party/externals/libpng/png.c
    [216/1196] compile ../../third_party/externals/libpng/pngread.c
    [217/1196] compile ../../third_party/externals/icu/source/common/ucnvmbcs.cpp
    [218/1196] compile ../../third_party/externals/icu/source/common/uloc.cpp
    ninja: build stopped: subcommand failed.
    error: command failed: 'bash' './esy/build.sh' 'darwin' '/Users/erikdavtyan/.esy/3____________________________________________________________/i/esy_libjpeg_turbo-dc3b4679' (exited with 1)
    esy-build-package: exiting with errors above...

  building esy-skia@github:revery-ui/esy-skia#91c98f6
esy: exiting due to errors above

I've merged a fix to esy-slkia. Adding this to package.json should be sufficient:
  "resolutions": {
    "esy-skia": "revery-ui/esy-skia#b8aff12"
  }

A proper fix would be to have revery reference this fix, and then update this to use the latest revery , but unfortunately that has some other issues.


ModuleNotFoundError: No module named 'experiments'

Hi, when I run the file named "run_llava.py", it uses a function called "coco_img_id_to_path" that from "experiments.blip_utils", but i can't find this path. I find the "blip_utils" under "methods", but also don't have this function.
Could you help me to solve this problem? Thanks

OK, it works for me now. Thank you


Start: 100% CPU and >80% RAM

Modpack Name: Creative Drawers Producer
Additional Mods: Changed
Mods Removed: Oculus, FerriteCore
Developer, can you find better ways to optimize performance?

Wonderful CPU Utilization Graph

开发人员：你食不食油饼

@gengyoubo 你咋来了（）

https://github.com/LtxProgrammer/Changed-Minecraft-Mod/issues/1041

isn't it a minecraft or some other mod's issue

100% CPU utilization is not an issue, and is rather a good thing. As for memory, that can be expected with a large mod pack with limited performance mods. Please make sure you have changed-client.toml configured properly.

Forgot about this configuration file, let me adjust it in a moment.


Project does not build

Error here
user@192 verifiers-for-hyle % cargo build --release
    Updating crates.io index
warning: skipping duplicate package `fibonacci-program` found at `/Users/user/.cargo/git/checkouts/sp1-20c98843a1ffc860/df9a346/examples/aggregation/programs/fibonacci`
warning: skipping duplicate package `fibonacci-program` found at `/Users/user/.cargo/git/checkouts/sp1-20c98843a1ffc860/df9a346/examples/fibonacci/program`
    Updating git repository `https://github.com/sp1-patches/BLAKE3.git`
error: failed to get `blake3-zkvm` as a dependency of package `sp1-core v0.1.0 (https://github.com/succinctlabs/sp1.git?rev=df9a346#df9a3466)`
    ... which satisfies git dependency `sp1-core` (locked to 0.1.0) of package `sp1-verifier v0.1.0 (/Users/user/Documents/projects/verifiers-for-hyle/sp1-verifier)`

Caused by:
  failed to load source for dependency `blake3-zkvm`

Caused by:
  Unable to update https://github.com/sp1-patches/BLAKE3.git?branch=patch-blake3_zkvm/v.1.0.0#bac2d59f

Caused by:
  failed to fetch into: /Users/user/.cargo/git/db/blake3-551cb6a9ae540f14

Caused by:
  failed to authenticate when downloading repository

  * attempted to find username/password via git's `credential.helper` support, but failed

  if the git CLI succeeds then `net.git-fetch-with-cli` may help here
  https://doc.rust-lang.org/cargo/reference/config.html#netgit-fetch-with-cli

Caused by:
  failed to acquire username/password from local configuration
user@192 verifiers-for-hyle %

Hello, it should be fixed now.


Simplification: Remove LORange and LOConfig from pulse

What is the expected enhancement?
In https://github.com/Qiskit/qiskit-terra/blob/main/qiskit/pulse/configuration.py, there is an LORange and LOConfig which exist only to verify that the received freqs are between a min and a max. This comes from the backend and is used only by assemble, not anywhere in the pulse module.
These two classes should be deleted (deprecated if necessary, although I don't think it would be considered user facing) and wherever it is used, it should be replaced with something to the effect of if not (min_freq < freq < max_freq): raise <custom error>.
The user API should not change, and the behavior should not change for any input.

Can I work on the issue?

sure thing @saktar-unr I've assigned to you. Let us know if you have any questions, and make sure to refer to the contributing guidelines too 😄

@lcapelluto, Can you explain me what should be the expected behavior? LORange and LOConfig class are used in some test code. If I remove LORange and LOConfig class, should I make changes to all the files that used the classes?

Hi @saktar-unr I believe Lauren explained in the description that:

wherever it is used, it should be replaced with something to the effect of if not (min_freq < freq <  max_freq): raise <custom error>,

so if there are tests that use LORange and LOConfig you can probably replace with that. Also if you remove the classes then you can also remove the tests for those classes 😄

can i take this issue? i would like to start my first Contribution from here. @javabster

Hi @jade-emperror welcome! Tt looks like the last contributor is no longer working on this so yes I will assign you. As this is your first contribution please make sure to read the contributing guidelines, and let us know if you have any questions!

@javabster i have finished the set up of qiskit-terra and i executed tox to  know about the existing test percentage. it throwed me the following error.
RuntimeError: This version of jaxlib was built using AVX instructions, which your CPU and/or operating system do not support. You may be able work around this issue by building jaxlib from source.
do i have to build jaxlib from source or am i missing something?
System Configs:
OS : macOs Monterey

hi @jade-emperror some other contributors have experienced this issue in the past, check out the conversation here and see if it helps: https://github.com/Qiskit/qiskit-terra/issues/6633#issuecomment-986750360

Hi @javabster ! I think this issue is still open, can i contribute to this issue ?


"Cungrea" is listed in the drop-down menu

Description:
"Cungrea" is listed in the drop-down menu alongside its corresponding county and commune, according to the law
Precondition:
The website is up an running.

Step 1
Type "Cungrea" in the search bar.

Expected results
The location is listed in the drop-down menu as "Cungrea, Argeș (Ciomăgești)".


Scripts fix

please review and merge these changes to develop and then main.
we can talk later about using fiftyone more interactively, and about using persistent datasets that can be read into an ipython session.
tests are passing and everything should run properly for a new dataset. modified the readme too -- can still be improved, feel free to modify it further as you go tomorrow. I still need to modify toy dataset to have it with the same format as all our other datasets.

hey -- did all changes. thanks for taking a look.
It'll be useful if there's another pair of eyes on the plotting_utils.py funcs. should take just a few minutes to clean up and refine. then you could merge? going to Ram.


STORE: Fix OSSL_STORE_open_ex() error reporting, take 2

OSSL_STORE_open_ex() could result in reports like this:
80722AA3927F0000:error:80000002:system library:file_open_ex:No such file or directory:engines/e_loader_attic.c:1016:calling stat(file:test/blahdibleh.der)
80722AA3927F0000:error:41800069:lib(131)::path must be absolute:engines/e_loader_attic.c:1010:test/blahdibleh.der
80722AA3927F0000:error:1600007B:STORE routines:OSSL_STORE_open_ex:no loaders found:crypto/store/store_lib.c:148:No store loaders were found. For standard store loaders you need at least one of the default or base providers available. Did you forget to load them?

The last one turns out to be a bit too generically reported.  It
should only be reported when no loader were loaded at all, not when
loader_ctx happens to be NULL (which may happen for other reasons).
We also move the helpful message to the OSSL_STORE_LOADER fetcher.

Replaces #15476

An example how the above message could be confusing (this happens in current master):
$ ./util/wrap.pl apps/openssl storeutl does-not-exist.pem
Couldn't open file or uri does-not-exist.pem
8042B4C76B7F0000:error:16000069:STORE routines:ossl_store_get0_loader_int:unregistered scheme:../master/crypto/store/store_register.c:237:scheme=file
8042B4C76B7F0000:error:80000002:system library:file_open:No such file or directory:../master/providers/implementations/storemgmt/file_store.c:267:calling stat(does-not-exist.pem)
8042B4C76B7F0000:error:1600007B:STORE routines:OSSL_STORE_open_ex:no loaders found:../master/crypto/store/store_lib.c:148:No store loaders were found. For standard store loaders you need at least one of the default or base providers available. Did you forget to load them?

The last message is simply not true, there is indeed a loader available for the file scheme.
With this PR, we get this instead:
$ ./util/wrap.pl apps/openssl storeutl does-not-exist.pem
Couldn't open file or uri does-not-exist.pem
80622D7D9A7F0000:error:16000069:STORE routines:ossl_store_get0_loader_int:unregistered scheme:../master/crypto/store/store_register.c:237:scheme=file
80622D7D9A7F0000:error:80000002:system library:file_open:No such file or directory:../master/providers/implementations/storemgmt/file_store.c:267:calling stat(does-not-exist.pem)

While for a truly unknown scheme, we still get the helpful message:
$ ./util/wrap.pl apps/openssl storeutl flar:something
Couldn't open file or uri flar:something
80F2ECC63C7F0000:error:16000069:STORE routines:ossl_store_get0_loader_int:unregistered scheme:../master/crypto/store/store_register.c:237:scheme=file
80F2ECC63C7F0000:error:80000002:system library:file_open:No such file or directory:../master/providers/implementations/storemgmt/file_store.c:267:calling stat(flar:something)
80F2ECC63C7F0000:error:16000069:STORE routines:ossl_store_get0_loader_int:unregistered scheme:../master/crypto/store/store_register.c:237:scheme=flar
80F2ECC63C7F0000:error:1608010C:STORE routines:inner_loader_fetch:unsupported:../master/crypto/store/store_meth.c:356:No store loader found. For standard store loaders you need at least one of the default or base providers available. Did you forget to load them? Info: Global default library context, Scheme (flar : 0), Properties (<null>)

The force-pushes were rebasings on top of fresher master

This pull request is ready to merge

Merged
ecd699b6dae054d368ca9ff04f3b80013f3c241f STORE: Fix OSSL_STORE_open_ex() error reporting


feat: Add the inteligent tiering configuration

Description
This pull request adds the option of managing the bucket intelligent  tiering configuration by passing a map of objects to this module. This map of objects encapsulates the configuration options from this resource: https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/s3_bucket_intelligent_tiering_configuration
Motivation and Context
Intelligent tiering configuration can optimize the costs of the S3 buckets infrastructure and the changes in this pull request make these configurations available from the module.
Breaking Changes
None
How Has This Been Tested?

[x] I have updated at least one of the examples/* to demonstrate and validate my change(s)
[x] I have tested and validated these changes using one or more of the provided examples/* projects

[x] I have executed pre-commit run -a on my pull request

This issue has been resolved in version 3.3.0 :tada:


ERROR: Service 'microservice_secret_fpm' failed to build

When trying to build the docker containers, the 'microservice_secret_fpm' container fails to build and generates this error:
Cloning into '/usr/src/php/ext/redis'...
fatal: Remote branch php7 not found in upstream origin
ERROR: Service 'microservice_secret_fpm' failed to build: The command '/bin/sh -c apt-get update && apt-get -y install         git g++ libcurl4-gnutls-dev libicu-dev libmcrypt-dev libpq-dev libxml2-dev unzip zlib1g-dev     && git clone -b php7 https://github.com/phpredis/phpredis.git /usr/src/php/ext/redis     && docker-php-ext-install curl intl json mbstring mcrypt pdo pdo_mysql redis xml     && apt-get autoremove && apt-get autoclean     && rm -rf /var/lib/apt/lists/*' returned a non-zero code: 128

Steps to reproduce:

Clone docker repository
$ mkdir php-microservice
$ cd php-microservice/
$ git clone git@github.com:php-microservices/docker.git

Clone source repositories
$ mkdir source
$ cd source
$ for repo in secret location user battle; do git clone git@github.com:php-microservices/${repo}.git;
done

Build docker containers
$ cd ..
$ docker-compose build
...
Cloning into '/usr/src/php/ext/redis'...
fatal: Remote branch php7 not found in upstream origin
ERROR: Service 'microservice_secret_fpm' failed to build: The command '/bin/sh -c apt-get update && apt-get -y install         git g++ libcurl4-gnutls-dev libicu-dev libmcrypt-dev libpq-dev libxml2-dev unzip zlib1g-dev     && git clone -b php7 https://github.com/phpredis/phpredis.git /usr/src/php/ext/redis     && docker-php-ext-install curl intl json mbstring mcrypt pdo pdo_mysql redis xml     && apt-get autoremove && apt-get autoclean     && rm -rf /var/lib/apt/lists/*' returned a non-zero code: 128

The php branch was removed from the phpredis so we created a new repo with the Docker files updated. Please check https://github.com/php-microservices/docker-v2


mirrord container not working

Bug Description
we got the following errors when running mirrord container -- docker run nginx with the latest version 3.125.2
  x ! mirrord container is currently an unstable feature
    ✓ preparing to launch process
      ✓ operator not found
      ✓ agent pod created
      ✓ pod is ready                                                                           Error:   × Command output indicates an error [docker logs -f
  │ 78227db451644e0faa3ee02fa711a3a3a16b6d8a173daa4ec98df05e81cbeef2]: Error:   × Main
  │ internal proxy logic failed: connecting with agent failed: could not
  │   │ create connection with tls: Connection reset by peer (os error 104)
  │   ├─▶ connecting with agent failed: could not create connection with tls:
  │   │   Connection reset by peer (os error 104)
  │   ├─▶ could not create connection with tls: Connection reset by peer (os error
  │   │   104)
  │   ╰─▶ could not create connection with tls: Connection reset by peer (os error
  │       104)
  │   help:
  │
  │         - If you're still stuck:
  │
  │         >> Please open a new bug report at https://github.com/metalbear-co/
  │         mirrord/issues/new/choose
  │
  │         >> Or join our Discord https://discord.gg/metalbear and request help
  │         in #mirrord-help
  │
  │         >> Or email us at<EMAIL_ADDRESS>  │
  │
  │
  │
  help: This is a bug. Please report it in our Discord or GitHub repository.

Not sure what connections it's trying to make but I noticed it created the mirrord pod successfully in our cluster and the pod exited immediately with the following logs:
agent ready - version 3.125.2
  2024-12-04T02:51:11.142940Z  WARN mirrord_agent::outgoing::udp: interceptor_task -> no messages left
    at mirrord/agent/src/outgoing/udp.rs:225 on ThreadId(5)

  2024-12-04T02:51:11.143069Z  INFO mirrord_agent::entrypoint: main -> mirrord-agent `start` exiting successfully.
    at mirrord/agent/src/entrypoint.rs:847 on ThreadId(1)
2024-12-04T02:51:11.143188990Z

We are using EKS (v1.30.6-eks-7f9249a) and kubeconfig on the host machine is generated with aws eks update-kubeconfig --name OUR_CLUSTER_NAME.  Everything worked with mirrord exec
Steps to Reproduce

install the latest mirrord
connect to EKS v1.30
mirrord container -- docker run nginx

Backtrace
No response
mirrord layer logs
No response
mirrord intproxy logs
No response
mirrord agent logs
No response
mirrord config
No response
mirrord CLI version
No response
mirrord-agent version
No response
mirrord-operator version (if relevant)
No response
plugin kind and version (if relevant)
No response
Your operating system and version
ec2 ubuntu 22.04
Local process
using container
Local process version
No response
Additional Info
No response

Duplicate of
mirrord container -- docker run nginx fails · Issue #2927 · metalbear-co/mirrord

We found there is no log in the local mirrord-cli container (78227db451644e0faa3ee02fa711a3a3a16b6d8a173daa4ec98df05e81cbeef2) exited with code 137
so we think the issue is mirrord not able to start the nginx container

Hi, this looks like the mirrord-cli container was unable to connect back to our process running on the host machine, is there any reason the spawned container should be unable to connect to host machine with using the host's network addr?Just to check the communication by itself could you please run nc -l 8080 in one terminal and docker run --rm busybox nc <ip addr> 8080 -e "hostname" in another where you replace <ip addr> with your local addr (to get the ip addr we are trying to connect to linux: ip route get <IP_ADDRESS> | grep -oP 'src \K[0-9.]+' macos: ipconfig getifaddr $(route -n get default | grep interface | awk '{print $2}')) If you see some hostname (can be just some hex string) appear on the nc -l 808 this means it should be able to communicate with extproxy and extproxy probably didn't start (there should be logs in /tmp folder for extproxy logs and those can help with figuring out the issue), if the request fails I would take a look at why? we do need to access the host from the container, some overlap between docker network addrs and local network addrs can cause this issue.

Thank you. I tried the command you shared and nc -l 8080 does return with a hex 14e6b45e0a29 string. But there is no logs under /tmp folder
coder /tmp $ ip route get <IP_ADDRESS> | grep -oP 'src \K[0-9.]+'
<IP_ADDRESS>
coder /tmp $ nc -l 8080 & docker run --rm busybox nc <IP_ADDRESS> 8080 -e "hostname"
[1] 7807
14e6b45e0a29
[1]+  Done                    nc -l 8080
coder /tmp $ ls -a
.  ..


typo: Double word "that"

Hi, @nschonni the specs files are generated from our source code so we don't accept fixes to them as they would be overwritten.
However, I checked the typos you pointed out and found that some are still present even in the newer versions, I will be fixing the typos from our side so the generated specs do not have these typos. Thanks!


pipenv: 2023.10.24 -> 2024.0.1

Diff: https://github.com/pypa/pipenv/compare/v2023.10.24...v2024.0.1
Changelog: https://github.com/pypa/pipenv/releases
Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

There's an automated version bump update here: https://github.com/NixOS/nixpkgs/pull/321807
This is the same diff, plus I've added a test as suggested by @l0b0 here: https://github.com/NixOS/nixpkgs/pull/266877


Problem when resetting data with multiple grids

Hi, I merged the fixed code from #530 into my Hypergrid.js file. It passed the error. However, when I try to reset the data, it still print out this error:
Cannot read property 'top' of undefined at Constructor.getGridCellFromMousePoint

Let's use the other thread. I'll close this ticket


Understanding Attention mechanism

After reading the attention mechanism we could give the numerical example on that and explain it to others as well as they understand without any background information about it.
Don't forget to learn all the mathematical approaches behind that coding.

https://www.aparat.com/v/wsoNz?playlist=1001307


[Habits view] Percent of habit tracking displayed in a progress bar over 100%

Environment: 11 Home, Google Chrome.
Reproducible: always.
Build found: 23.02.2023
Preconditions

Registered User is logged in
User has at least one habit in progress
It is the day after the last day of the habit’s primary duration
User hasn't marked the habit as done on the current day and the day before

Steps to reproduce

Click on the habit card on My habits page.
Mark chosen habit as done on the current day and the day before.

Actual result
Percent of habit tracking displayed in a progress bar over 100%
Expected result
Percent of habit tracking shouldn't be calculated and displayed in a progress bar over 100%
https://user-images.githubusercontent.com/107051540/220971221-9b8cf347-c669-4f20-a615-aea2a7fe8b36.mp4
Postconditions
User story and test case links
E.g.: "User story #993
[Test case GC-5172]https://jira.softserve.academy/browse/GC-5172"

Need to change validation in back-end to don't allow change habit if workingDays = duration. And remove check for ACQUIRED - so user can edit AQUIRED habits.

Removed back end label because found way to fix in UI


feat: record http request params

add options to record http get(recordGetParams)/post(recordPostData) data, all default is false.
add requestFilter option to custom filter, default is all pass.
add bufferTransformer option to custom post data transformer, default like:

require('querystring').parse(buffer.toString('utf8'));

Codecov Report

Merging #233 into master will decrease coverage by 0.18%.
The diff coverage is 78.78%.

@@            Coverage Diff             @@
##           master     #233      +/-   ##
==========================================
- Coverage   80.51%   80.32%   -0.19%
==========================================
  Files         190      190
  Lines        6358     6400      +42
  Branches      857      864       +7
==========================================
+ Hits         5119     5141      +22
- Misses        855      874      +19
- Partials      384      385       +1

Impacted Files
Coverage Δ

packages/hook/src/patch/HttpServer.ts
86.11% <78.78%> (-6.92%)
:arrow_down:

packages/hook/src/index.ts
59.37% <0%> (-40.63%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac4acb2...82fe0e7. Read the comment docs.


v1.1.0 bump, copyright date

Fixes: https://github.com/IBM-Bluemix/gp-angular-client/issues/4

work in progress

Looks fine to me. Thanks.


istio/install/consul/README.md refers to non-existant file

See https://discuss.istio.io/t/quick-start-guide-references-non-existent-file/2496

Install instructions specify to download the release, which has the file. Users should not try to install from source, we have many docs saying this isn't supported. I don't think there is any action to do here.
Please reopen if you think there is still work to be done


more rustup, still unfinished

I'll have to look into working with the ring buffer more closely. Still WIP.

Left a comment about drop, but LGTM!

It should now (hopefully) drop again. We may want to improve that code later (as in use even more unsafe operations to make it faster), but it's a start – we at least have a building library (sans tests; I'll tackle them next).

To get the tests to run, I needed to pull in the time crate. I also added the log crate to reduce the rustc_private feature dependency.

Just a side note, I'm going to be traveling a lot starting this weekend (wedding to attend, then a week long business trip a few days after, then vacation).  So I'll probably be radio silent at times, feel free to push/merge/whatever as you see fit :)

Will do. I think I'll merge when the tests build, then again when they pass.

The last one hints at a change in the Fn* traits: We currently only allow Fn, not FnMut or even FnOnce. We need to look up where this is defined and use FnOnce if possible, otherwise at least FnMut.

I ran with FnMut for now, as FnOnce is too restrictive. I also fixed a load of warnings en passant.
Some tests fail (though that is probably to be expected, considering how I butchered the code :smile:

It's also extremely possible that the tests are failing because some of the core logic is just broken.  I remember struggling with getting the processors to wrap around the ringbuffer correctly, so I wouldn't discount actual bugs in there either :)


Fix diagnostics readability on light backgrounds

wanted to use this plugin but i'm using a light background, here's what i saw after i installed the plugin

so although it can be fixed by setting hi = { mixing_color = "#ffffff"  } i thought it would be neat if this could be set automatically when light background is enabled. when i looked into the source code, i found a bug too, in the if statement, there is default_hi.mixing_colors instead if default_hi.mixing_color

Oops ! Nice catch. Thank you a lot !


Updated about us page

Issue #30
Updated the about us page with particle effects 3d, responsive our team section, hover effects, removed horizontal
scrollbar and fixed navbar underflow.

@Akshatchaube01 It's showing vercel deployment failed, should I reopen another pullrequest?


Could not find docker image in Artifactory, expecting image ID when pulling from remote

Describe the bug
When pulling a library image from an Artifactory remote docker repository that points to docker hub, I receive the following error:
jfrog rt docker-pull <ip>/docker-remote/mariadb:10.2.23 docker-remote --build-name=mariadbtest --build-number=1
10.2.23: Pulling from docker-remote/mariadb
Digest: sha256:af57a388784d08cd2d4f054fabfc53aa9144a961a3a1be8067a5cf9443d01646
Status: Image is up to date for <ip>/docker-remote/mariadb:10.2.23
<ip>/docker-remote/mariadb:10.2.23
[Error] Could not find docker image in Artifactory, expecting image ID: sha256:de1cba14a3a39248a24bbc1ea1c981a53c56ab0d374299d691736cd84aedc217

I notice that if I do not include the --build-name and --build-number parameters, the pull works as expected.
I thought that this error could be due to the build name/number not yet existing in Artifactory, but according to the CLI documentation, those parameters are just used to gather data locally so that a build can later be published.
To Reproduce
set up a remote docker repository that points to https://registry-1.docker.io/
configure the jfrog CLI and issue jfrog rt docker-pull of some library image through the docker-remote repo, specifying the --build-name and --build-number parameters.
jfrog rt docker-pull <ip>/docker-remote/mariadb:10.2.23 docker-remote --build-name=mariadbtest --build-number=1

Expected behavior
I'd expect the image to pull successfully, regardless of whether or not i provide the --build-name and --build-number parameters
Versions

JFrog CLI version: 1.35.3
JFrog CLI operating system: ubuntu 18.04
Artifactory Version: 7.3

@trriplejay, We truly apologize for this incident, while we investigate this issue I would like to help you with a workaround until this gets patched.
Create a virtual docker repository add your remote docker repository to it (the one that points to docker hub).
Now try to pull from your virtual docker repository with build-name & build-number flags.

@trriplejay, we released JFrog CLI v1.35.4 to resolve this issue.
Feel free to upgrade - We'll appreciate your feedback for that!

We just ran into this on the azure devops extension and got around it by disabling collection of build info but the issue still seems present in cCLI version v1.35.5

To add to @whume, this was seen on a docker push rather than a pull for us

We just ran into this on the azure devops extension and got around it by disabling collection of build info but the issue still seems present in cCLI version v1.35.5

To add to @whume. We say this on a push rather than a pull

@whume and @dragoonTND,
Could it be that you're providing to the command a different repository, than the repository the reverse proxy is pointed to?
If this is not the issue, can you please help us reproduce the issue? If you can create step by step instructions, that could be extremely helpful.
Everything works for us with the latest release.

This is working for my case now 👍 thanks!

Thanks for the feedback @trriplejay.
@whume and @dragoonTND, did you see my comment above?

Ah I missed this let me give it a try when im online in the morning and ill try enabling build info again.


Added scrollbar for org list, adjust breakpoints for certain devices

This change makes it so that the organization list scrolls independently from the videos list.
The following changes were made:

Class styles were created for the new/modified height and overflow properties.
Apply a different height for xs breakpoint since the columns are rendered vertically with a dropdown instead of a list.
Adjust breakpoint column values to prevent accidental line breaks with "Select Live" text,  $t("views.multiview.video.selectLive"). This in particular occurred on iPads oriented vertically with the new scrollbar when I tested. Text styling is also used on different breakpoints if smaller text prevented line breaks or gave just enough room to prevent scrolling issues with very low resolution mobile devices (Galaxy S5).

Most important thing to note is that the card containing the org/video selector is a bit shorter in height now to accommodate the css properties that I modified/added for independent scrolling, otherwise it wouldn't have worked properly on certain mobile devices when the columns are stacked vertically. Albeit CSS and Vuetify aren't exactly my forte so open to suggestions for this problem. Maybe one solution is to apply different a different height for larger than xs devices to .video-list using $vuetify.breakpoint.
It may be best to apply thin-scroll-bar along with the fallback css properties for Firefox in the future as the scroll bars are a bit of an eyesore.

let's test it out


Wrong edge icon size

In PHPStorm the icon looks missized.
I am using MacOS. I am not familiar with how it works so wasn't able to pinpoint the issue yet.

The closest to a reproduction I could get was zooming a lot until the problem appear. I managed to fix it in 0.5.1 under those conditions in a417e8fb4efe62d350e2824118e2588654685bed, please reopen if it's still happening in the next release.

Thanks a lot!
This was on a retina screen so this might have been an important thing I forgot to mention.
I also see that the plugin is not compatible with the latest version - https://plugins.jetbrains.com/plugin/22932-adonis
Can you please push a release to the IntelliJ repository, or how does it work?

Thanks a lot! This was on a retina screen so this might have been an important thing I forgot to mention. I also see that the plugin is not compatible with the latest version - https://plugins.jetbrains.com/plugin/22932-adonis
Can you please push a release to the IntelliJ repository, or how does it work?

A release that handle newer version issue has been done already before this one and these fixes will be available after jetbrains approval ! 😄  f5dbe10


[vm/ffi] Array allocation in native memory

After https://github.com/dart-lang/sdk/issues/54526 is addressed, allocating arrays in native memory will look something like:
void main() {
  final array = calloc<MyStruct>(10).asArray(5, 2);
}

This repeats the array length.
We could consider adding some methods to Allocator to simplify this.
extension AllocatorAlloc on Allocator {
  external Array<T> array<T extends NativeType>(int dimension1,
      [int dimension2,
      int dimension3,
      int dimension4,
      int dimension5]);

  external Array<T> arrayMulti<T extends NativeType>(List<int> dimensions);
}

Which would allow us to write:
void main() {
  final array = calloc.array<MyStruct>(5, 2);
}

Side note: Pointer<Array<...>>
Note that there is no such thing as a Pointer<Array<...>>. The Pointer object would not know what the array dimensions are, so it could not have operator [] and operator []=. Instead it would need methods that take array dimensions. We could consider going that route instead.
However, that would lead to other issues. For example: calloc<Array<MyStruct>>() would not know how large the array is.

Not sure if this makes sense. Allocators are allocating memory and returning pointers. These pointers have to be eventually freed. The Array objects don't provide a way to get the pointer of the underlying data, so it wouldn't be possible to free those arrays anymore, would it?

Right, that's the same issue as with structs and unions. Except for we wouldn't have access to the underlying pointer at all...
Where's my coffee? ☕  🤓
If we want to have the underlying pointer, you would use exactly what we would already have with introducing asArray.
Closing as not planned.


Error while running "limo test"

Describe your problem here.
When I try to run the command "limo test", the only response I get is -> Not_found
Are you modding a build from source or with Lua?
Source
What is your build target?
Windows x64
Did you edit anything in this build? If so, mention or summarize your changes.
Yes, I edited discord.hx and the project.xml file

isnt it lime?

lime*


fix: Handle resources with sensitive fields

Updated the generic read (used by sources, processors, destinations) to handle sensitive values. It works by checking to see if a parameter is sensitive. If it is, the original values for parameter.Value and parameter.Sensitive are saved to state instead of the values returned by the bindplane API.
This resolves an issue where Terraform attempts to update sensitive parameters on resources every time a plan is applied. This is because the API returns "sensitive value" when Terraform expects an actual password or api key.
Because BindPlane cannot return sensitive values, Terraform is only capable of creating the initial value or updating it. It cannot detect drift. This is consistent with other providers. Users should use caution when updating sensitive parameters outside of Terraform.
Tested the following

updates to destination configurations result in plan updates
updates to non sensitive values using biplane ui result in configuration plan updates
bindplane no longer attempts to update sensitive values when nothing has changed

Output when no changes are made:
No changes. Your infrastructure matches the configuration.

Terraform has compared your real infrastructure against your configuration and found no differences, so no changes are needed.

Apply complete! Resources: 0 added, 0 changed, 0 destroyed.

Output when a destination (which has sensitive values) is updated from the UI
  # bindplane_destination.datadog will be updated in-place
  ~ resource "bindplane_destination" "datadog" {
        id              = "01H6PD3AMDBW2Z1DCB917SCGFH"
        name            = "example-datadog"
      ~ parameters_json = jsonencode(
          ~ [
              ~ {
                    name  = "site"
                  ~ value = "US3" -> "US1"
                },
                {
                    name  = "api_key"
                    value = "xxxx-xxxx-xxxx"
                },
                {
                    name  = "retry_on_failure_enabled"
                    value = true
                },
              ~ {
                    name  = "retry_on_failure_initial_interval"
                  ~ value = 2 -> 5
                },
                {
                    name  = "retry_on_failure_max_interval"
                    value = 30
                },
                # (6 unchanged elements hidden)
            ]
        )
        # (2 unchanged attributes hidden)
    }

Plan: 0 to add, 1 to change, 0 to destroy.

Notice that the api_key field is not being updated, however, the Terraform Apply will end up setting the api_key value to xxxx-xxxx-xxxx.

Rebased to pull in latest doc changes. The docs/ structure is required if we want to integrate with Hashicorp's doc site. See https://registry.terraform.io/providers/observIQ/bindplane/latest/docs


Empty scenetree

Tested versions

master

System information
Godot v4.3.dev.mono ([72d04adfe]) - Ubuntu 20.04.6 LTS (Focal Fossa) - X11 - Vulkan (Forward+) - dedicated AMD Radeon RX 6600 (RADV NAVI23) () - AMD Ryzen 7 5800X 8-Core Processor (16 Threads)
Issue description
Empty scenetree on unsaved scene, when switching from non-initialized unsaved scene.
Steps to reproduce

Create new scene A
Add a 3D root node
Create new scene B, don't create a root node
Switch back to scene A [unsaved]

Scenetree should now be empty.
The empty scenetree can be fixed by switching to a saved scene and then back, then the unsaved scenetree appears again.
Minimal reproduction project (MRP)
N/A

Can you replicate this on an unchanged branch? The commit you reference isn't part of the repo

@AThousandShips yes was able to repro on Godot v4.3.dev6

And on latest master as well? If you're able to test

Yeah sure, let me recompile

https://github.com/godotengine/godot/assets/6347200/81c26e37-06bd-48fb-8edd-c85b9ee38b35
Here's a simple repro video (if it works)

I can confirm on latest master

This is a regression caused by #86605:


Aspire project with Blazor WASM/server project opens by itself

I believe this started happening since Preview 4
Steps to reproduce:

Create a new Aspire project, everything default
When you launch this, only the dashboard will open as expected
Add a new Blazor project to the solution, make sure to set Interactive render mode to "Auto", so that you get the 2 projects, let it enlist in Aspire orchestration
Launch the dashboard and wait a minute, the new Blazor app will also open in a new window, with a random port. Not as expected

This only happens with the Blazor template that gives you the WASM and Server projects, not when you selected either WASM or Server

@timheuer putting this on your radar.

I think in this case the launching of the separate browser for Blazor is actually by-design with the way we have to wire up the wasm debugger.  Will need @BillHiebert to comment if there is any more silent ways of doing it but I think we need the client running (an instance of chrome/edge) to have something to attach to.

@timheuer - the separate browser is expected when using F5 since we need to configure the browser for WASM debugging. The 2nd part of this I am not sure about. The browser appears to have the proxy port, but the dashboard has the port from launchsettings.json. Not sure why that is.

I am also experiencing this happening with now way to control it.
The problem I have is that it fails to launch Chrome for some reason and gives a dialog about Puppeteer troubleshooting. If I hit ok on that model dialog then debugging ends.
So far I can only see this happening with one project in my solution, although I have 2. The other doesnt seem to support WASM debugging which is really annoying, but better then only getting 60 seconds of debug time per run.
Workaround is to make debugging use firefox which launches successfully.
It would be really nice to have some kind of indication that this is going to happen or to be able to toggle the behavior. I am on preview 5 as of this evening and the problem persists

@NicoVermeir @ciaranodonnell Right now this is how the Wasm debugging works. Since it uses JavaScript debugging there needs to be a defined process to attach to and one that is also configured for remote debugging (--remote-debugging) (which likely any default browser instance isn't).  So when we have a Blazor Wasm project we launch an instance of the browser with these settings and the debugger can attach to.
You can disable the auto launch by modifying the launchSettings.json in the Wasm project and setting launchBrowser:false there -- but then you won't get the Wasm debugging experience...maybe a mitigation to use and turn it on when you want to debug Wasm as well.

Appreciate the response. The reason I think its a challenging developer experience is that I have 3 blazor wasm projects in my solution that all have that launchBrowser:true and it only launches it for one of the projects. The newest one. The others have been in there for months and other than a period a few weeks ago where it did this for an afternoon, they've never had the second browser launch. I was having to launch my own debug browser and debug the C# in the chrome dev tools (Which was a terrible experience of its own).
I want the WASM debugging, but I want it to actually launch the browser successfully, and if it cant I don't want it to model over my VS and then tear it all down when I dismiss the error.

@ciaranodonnell the multiple wasm apps is an interesting scenario. Well check it out. Are they all hosted in the same server app? Can you describe that config a bit more and what the apphost looks like. Better if you can mock a sample repo?

@ciaranodonnell I just tried two Wasm projects (hosted in two indepdendent server projects, which are added to Aspire apphost). Indeed only one client app launched.  I wanted to make sure this matches your same configuration:

1 apphost
2 server apps (Blazor1, Blazor2)
2 wasm client apps (Blazor1.Client, Blazor2.Client)
each client app hosted in the respective server app
apphost has reference to server apps and added as AddProject

I first experimented with Aspire and noticed this issue. And, maybe the entire AppHost project can be launched in that browser instance set up for WASM debugging when there is at least one WASM project exist?

Ran into this problem today as well. I have both Server and WASM Blazor projects that were updated to .net 8 (without using the new stuff, just version bump approach until Azure auth for Web App is sorted out).
I finally was able to get my Blazor Server and WebAPI projects working today with Aspire after having a tough time dealing with the ports. I finally figure out that the applicationUrl in the launch profile only works if you have a single port (For example, this works: "https://localhost:44373", but this was not working: "https://localhost:44373;http://localhost:44374").
The dashboard is finally reflecting the port from the launch profiles, but it always pops up a new browser with the blazor window using a random port. The port used in the new window is also displayed on the Structured logs tab: "Now listening on: https://localhost:64318". When debugging, I just close this window and use the link from the Dashboard (Not a great experience, but it at least works!).
Throughout this whole process it felt like there is a huge gap regarding Blazor WASM standalone and I was really disappointed to learn it isn't supported. I couldn't find anything in the documents regarding that and only discovered it wasn't supported until after searching through github issues. I couldn't figure out why I would right click => Add => .Net Aspire Orchestration Support for my WASM standalone project and it was saying it succeeded, but nothing changed.

@timheuer - the separate browser is expected when using F5 since we need to configure the browser for WASM debugging. The 2nd part of this I am not sure about. The browser appears to have the proxy port, but the dashboard has the port from launchsettings.json. Not sure why that is.

Not sure if this helps for your scenario (or if you already solved it), but today I was able to get the browser for WASM debugging to use the port from the launchsettings.json by disabling the proxy using .WithEndpoint("https", endpoint => endpoint.IsProxied = false); when adding the project with .AddProject in the AppHost Program.cs (example from docs)

fwiw, I just changed the 'Project'/'Development' launch settings to:
"launchBrowser": false
Works for me 😊


Skip connection to Steam

Hello,
Would it be possible to add an option to disable Steam execution?
Indeed, Steam is not required to run the game, so it would be useful to be able to skip the version check and run the game directly from the gamefiles folder

Hey! Thanks for taking the time to submit this request.
I'm working on a rewrite right now, and I will add this to the to-do list.

I added this as a quick hack in my fork :) https://github.com/fionera/satisfactory-server

Nice work @fionera! Hoping to finish it soon, life's been particularly busy lately.

Nice work 👍
Made a mistake the first time
I no longer get a steam guard code!
What can I do?
Thank you


[demo] use Oswald web font on shields

PR for preview purposes only; see discussion here

There seems to be a race condition in which the font loads after some of the shields have been rendered and cached in the sprite sheet. This randomly affects different shields each time I reload the page in Firefox:

Each browser engine has slightly different behavior around Web fonts. If I remember correctly, WebKit generally draws blank text until the font loads, which would be worse in a case like this.
We might want to listen for a font loading event and trash and repopulate the shields in the sprite sheet at that time.

I think the issue may be that different font weights are being used randomly.  Four weights are loaded from google fonts:
https://github.com/ZeLonewolf/openstreetmap-americana/blob/a70c4c7bb3564e3c79eabbb77ffebb333566cc74/src/index.html#L9
I'm not sure why this would be happening, but the number shapes all look the same to me just randomly varying by weight with each page load.

the number shapes all look the same to me

Scratch that.  After some testing I've seen varying number shapes too.  Like these different 9s here:


Build duktape cleanup

Rationale
This series does:

remove the submodule initialization from build system;
avoid failing if duktape is not present - we simply disable it;
add a mechanism to provide DUKTAPE_SRC variable so we can do external duktape clones and use it from there - this is a distro building requirement, namely clear linux;

Besides the feature set of changes the series also brings a patch to fix an -gen.h installation bug;

overall the patches are okay per se, but I really dislike the huge special treatment to handle the duktape case.
Particularly considering its usage at this moment -- none as the JS support is too barebones and nobody is actually working on it. No timers, no XmHttpRequest, no time bounded execution (then it can block the main loop).
I guess I'll work into making FBP understand external modules and we add duktape as a separate module generated by a separate project, similar to SML that provides Soletta modules from outside. Then in that project we include duktape and do the mess all in there.

v2 coming...


Set Cert: should not check BasicConstraint CA: True with hardcoded value

https://github.com/DMTF/libspdm/blob/b327ead227f14998789bca7d045af17b99dd6d50/library/spdm_crypt_lib/libspdm_crypt_cert.c#L840-L846
Device Cert could specify pathLenConstraint in BasicConstraints and hence the hardcoded BASIC_CONSTRAINTS_STRING_TRUE_CASE can't cover all the true cases.
https://github.com/DMTF/libspdm/blob/b327ead227f14998789bca7d045af17b99dd6d50/library/spdm_crypt_lib/libspdm_crypt_cert.c#L98

Presumably the call to libspdm_x509_get_extended_basic_constraints would fail as cert_basic_constraints is not large enough to hold the whole field.


Env. variables are not taken into consideration

Hello, people!
It seems like offered environment variables are not taken into consideration during an installation of the driver.
For instance, in PowerShell $env:GECKODRIVER_VERSION="0.30.0"; npm install geckodriver still installs the latest version.
Same for $env:GECKODRIVER_FILEPATH="C:/Jenkins/geckodriver-v0.30.0-win64.zip"; npm install geckodriver.
So what's the point of those variables? Or I'm doing it wrong?

We have updated the project which should have fixed the problem. Let me know if it still occurs.


Minor fixes

Minor code tidying fixes for a bunch of compiler warnings:

Adding default initializers to fields without one
Remove padding by reordering members in a couple of structs
A few trivial copy->move changes
Use = defaulted constructors and destructors where appropriate
Also fixes a flaky PTP test, it was modifying an atomic just after rather than before the barrier.
PTP group race condition fix
Attempt to make scheduler tests less unreliable under TSan: with tsan overheads, I think the executor was able to finish executing its dummy task before the scheduler was able to execute the next one, resulting in re-use where it normally wouldn't occur

This should fix all of the current TSan issues listed in #189

@Shillaker can you merge? "The base branch restricts merging to authorized users"

@kubasz think I've given you sufficient permissions now. Let me know if not.


Make it possible to customize queryset result doc

parasolr change needed to support https://github.com/Princeton-CDH/geniza/pull/549

@kmcelwee can you give me a quick review?
this isn't a bugfix exactly, but it's such a tiny change, I don't really want to bump to version 0.9 just for this, but I want to use this feature in geniza; any thoughts?


Mutilable domains

You can now do mutiable domains on line ie
cloudflare.sh example.com www.example.com chess.example.com guru.mydomain.com
You can also change config setting with cloudflare midflow of the command line.
There is early help system (cloudflare.sh -help) which need some serious editing.
The reasion using hyphen "-" works, can not have domain (subdomins) with hyphen at start or the end of a name, you can thow have hyphen within name. Cloudflare will give you a "DNS Validation Error (Code: 1004) DNS name is invalid." error if try an create domain with hyphen at the start.
Hopefully it work, without any issues.

Things have been change. There are setting states internal/parameter/file. The are processed in that order.
It now only checks the cloudflare settings when about to process the -record_name
The config_file is able to remove white space outside double quotes.
<EMAIL_ADDRESS>  -zone-identifier="blarbalrblar"
    -record_name="thinking.example.com"
    -sleep="60"
      -ipset="<IP_ADDRESS>"
      -record_name="thinking.example.com"
    -sleep="60"
    -ipcheck
    -record_name="thinking.example.com"

I can not see what is an diffrance
Resolving conflicts between timetoexpire:main and K0p1-Git:main and committing changes timetoexpire:main

Hey @timetoexpire, sftlr I have been busy with work recently. This addition you've made is great; However, I don't specifically have the time to review it. I think the added complexity will make this script less accessible without further documentation. Feel free to publish this chance as yours on GitHub as an alternative for those who seek it! Thanks for the contribution once again!


feat!: support manifest v3

Context

Closes https://github.com/interledger/web-monetization-extension/issues/23
Changes proposed in this pull request

Changes proposed in this pull request

Use updated manifestv3.json, and modify it as needed for Firefox/Chrome support.
As MV3 doesn't enable hosts permissions on install (automatically or manually), add a prompt in the ConnectWallet screen to request permission. The Connect Wallet button is disabled if we don't have the permission.

If you've already connected your wallet, no prompt is shown. We need to improve that flow.

Make Webpack generate self-contained bundles. Otherwise, it uses dynamic script loading with document.createElement('script'), and document isn't defined in MV3 background service workers, which causes a fatal crash.
Clear all install-time warnings in Firefox as well as Chrome.

Questions:

Should I get rid of manifest v2 stuff? I tested it works fine in Firefox 110 even.
Should I show the permission error/prompt on all screens?

1. Should I get rid of manifest v2 stuff? I tested it works fine in Firefox 110 even.

I would keep them for now. We can probably default to using MV3 (renaming manifestv3.json to manifest.json) and keep the old manifest for the moment.

2. Should I show the permission error/prompt on all screens?

i don't think so, since the button will be disabled and we check the permission when the user submits the form.

Should I show the permission error/prompt on all screens?

i don't think so, since the button will be disabled and we check the permission when the user submits the form.

So, content script also won't be injected if current URL isn't doesn't have the permission. We ask for the permission only on connect screen, but if some has connected before, and they update the extension, they won't see that they haven't given the permissions.
Also valid in case the permission is removed later (for some reason - like mistake or browsers being more strict in future with privacy considerations, like removing permission after N days).


Update data-storage.qmd

I made several changes to the Data Storage page:

I restructured the local vs. cloud storage dichotomy because it doesn't make sense anymore in the current storage landscape. Now the division is between standard and research data-specific storage options.
I rewrote some of the text that was very generic.
I removed links to other LibGuide sections or to pages on the VU RDS portal that won't exist anymore once the handbook goes live.
I made sure that explanations are generally up to date and removed the descrriptions about group drives (because they've been finished).

@Elisa-on-GitHub do you want to merge yourself, or should I just do it? )))


[ENH] Refactor feature based transformers into their own subpackage

Reference Issues/PRs
Dependent on #916
What does this implement/fix? Explain your changes.
moves catch22, summary and tsfresh into a feature based package to mirror classification, clustering and regression

This appears to have some of the same changes as the other refactor PR so may conflict

This appears to have some of the same changes as the other refactor PR so may conflict

yes I tried to keep a linear dependency to avoid conflicts, but it doesnt seem to work so well for me


WIP: Allow more than one label to be selected in labels layer

Description

This PR is WIP but the goal is to enable selecting multiple labels rather than a single one. The selection model would mirror the layer list, with an active label and a selection.
Currently the selection works but does not update the active label (that should change — active should always be "last selected"). Additionally, there are no GUI controls for making selections. One idea would be that holding Cmd with the picker would allow one to update the existing selection.
Joint work with @brisvag 😊
Type of change

[ ] Bug-fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

References

How has this been tested?

[ ] example: the test suite for my feature covers cases x, y, and z
[ ] example: all tests pass with my change

Final checklist:

[ ] My PR is the minimum possible work for the desired functionality
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] If I included new strings, I have used trans. to make them localizable.
For more information see our translations guide.

active_label and selection now update each other whenever the first is not part of the second! :)

Bump @jni - any thoughts on converting this into an issue or getting it mergable? We could try and loop in some extra help from @grlee77 if we want to get this merged. Please advise

This PR have not been active for quite some time.
In order to keep the list of PRs short and easier to work with, I am going to tag this PR as stale and close it.
Feel free to reopen and remove the "stale" label when work on this PR resumes.
If you do not have the permissions to do so, feel free to request help from one of the maintainer to reopen and remove the stale label .


Fix simple TLS to permissive traffic (1.8 regression)

Fixes part of https://github.com/istio/istio/issues/29538. See issue for details. Basically we add an additional filter chain to match the simple tls

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

/test all

@howardjohn: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
ae803e8e1067cbff1259c1db7757f7ad09afb5ca
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/test all

@howardjohn: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
da85497ccd49a3125b8e97f67b776cf7051cc345
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
da85497ccd49a3125b8e97f67b776cf7051cc345
link
/test release-notes_istio

unit-tests_istio
da85497ccd49a3125b8e97f67b776cf7051cc345
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
da85497ccd49a3125b8e97f67b776cf7051cc345
link
/test release-notes_istio

unit-tests_istio
da85497ccd49a3125b8e97f67b776cf7051cc345
link
/test unit-tests_istio

integ-security-multicluster-tests_istio
da85497ccd49a3125b8e97f67b776cf7051cc345
link
/test integ-security-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test all

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
da85497ccd49a3125b8e97f67b776cf7051cc345
link
/test unit-tests_istio

integ-security-multicluster-tests_istio
da85497ccd49a3125b8e97f67b776cf7051cc345
link
/test integ-security-multicluster-tests_istio

release-notes_istio
da85497ccd49a3125b8e97f67b776cf7051cc345
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-security-multicluster-tests_istio
da85497ccd49a3125b8e97f67b776cf7051cc345
link
/test integ-security-multicluster-tests_istio

release-notes_istio
da85497ccd49a3125b8e97f67b776cf7051cc345
link
/test release-notes_istio

unit-tests_istio
da85497ccd49a3125b8e97f67b776cf7051cc345
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-security-multicluster-tests_istio
da85497ccd49a3125b8e97f67b776cf7051cc345
link
/test integ-security-multicluster-tests_istio

release-notes_istio
da85497ccd49a3125b8e97f67b776cf7051cc345
link
/test release-notes_istio

unit-tests_istio
da85497ccd49a3125b8e97f67b776cf7051cc345
link
/test unit-tests_istio

integ-pilot-multicluster-tests_istio
da85497ccd49a3125b8e97f67b776cf7051cc345
link
/test integ-pilot-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test all

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
da85497ccd49a3125b8e97f67b776cf7051cc345
link
/test unit-tests_istio

integ-pilot-multicluster-tests_istio
da85497ccd49a3125b8e97f67b776cf7051cc345
link
/test integ-pilot-multicluster-tests_istio

release-notes_istio
2c859e704aa3d87e6d6b84b237a03fad2202dca1
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
2c859e704aa3d87e6d6b84b237a03fad2202dca1
link
/test release-notes_istio

integ-security-k8s-tests_istio
2c859e704aa3d87e6d6b84b237a03fad2202dca1
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test all

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
2c859e704aa3d87e6d6b84b237a03fad2202dca1
link
/test integ-security-k8s-tests_istio

integ-pilot-multicluster-tests_istio
375a315c14f9011ba57de3e77d7b1cb5ebd82f01
link
/test integ-pilot-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
a2cd0ba8ac9a9eb82e72a7fb517eb7be5010aa92
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest
On Fri, Dec 18, 2020 at 11:16 AM Istio Automation<EMAIL_ADDRESS>wrote:

@howardjohn https://github.com/howardjohn: The following test failed,
say /retest to rerun all failed tests:
Test name Commit Details Rerun command
unit-tests_istio a2cd0ba
https://github.com/istio/istio/commit/a2cd0ba8ac9a9eb82e72a7fb517eb7be5010aa92
link
https://prow.istio.io/view/gs/istio-prow/pr-logs/pull/istio_istio/29589/unit-tests_istio/1340012299645095936 /test
unit-tests_istio
Instructions for interacting with me using PR comments are available here
https://git.k8s.io/community/contributors/guide/pull-requests.md. If
you have questions or suggestions related to my behavior, please file an
issue against the kubernetes/test-infra
https://github.com/kubernetes/test-infra/issues/new?title=Prow issue:
repository. I understand the commands that are listed here
https://go.k8s.io/bot-commands.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/pull/29589#issuecomment-748273323, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAEYGXIHBRLEOLLHXXUBWH3SVOTCFANCNFSM4UXKQECQ
.

@howardjohn: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
a2cd0ba8ac9a9eb82e72a7fb517eb7be5010aa92
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest


Simplify setup

PR for issue # .
Ready for a PR?

[x] I have updated the CHANGELOG with an entry including a description, a link to my profile, and a link to the issue ticket. This change is filed under an Enhancement or Bug Fix, is shown under the relevant release tag name, and is included in my PR branch.

Implementation Notes:
Changes calls for many boot tasks from (refresh-"dbname") to (refresh) etc. The database used is now loaded from a WOMBATS_ENV environment variable.
Datomic Pro download keys are optional if launching with either "dev" or nothing set for the WOMBATS_ENV environment variable. Hype!
Breaking changes:
None

@dehli I think this is good to go again.

Looks good! Just a few things left. After the changes, I'd recommend you do some local testing again to ensure it still works with the clean ups. Then you should be good to go!


Escape function name in profiler

function_name can be formatted as <built-in method builtins.len>, so it needs to be escaped; otherwise, the function name won't display at all in the resulting HTML. For extra clarity, function name is only rendered as a link if it's associated with a path and line number.
Before image:

After image:

Thanks!