Document known problems with some plugins and ajax content

After spending hours trying to troubleshoot Sticky (and Magellan) I find that the plugins are practically non-functional with ajax content (See: #9047 and it's related issues).
Please properly document this (it's a known problem since July 2016) in Sticky, Magellan, and any other plugins that might be affected in order for developers to be aware. This is especially important for your meteor-README.md file as these plugins won't be compatible with Meteor (just like #9919)
I've bundled issues with Magellan here as well, since both exhibit same non-functionality in Meteor, and both depend on content position/scroll.

PR 1/2 https://github.com/zurb/foundation-sites/pull/10947

Can you test if this PR fixes one of both?

Hi, did you already find some time to take a look again at this issue? Would be glad if you could give some feedback on this.

Sure thing, just give me a couple of days and I'll give this PR a spin.
On Mon, Mar 12, 2018 at 5:11 PM, Daniel Ruf<EMAIL_ADDRESS>wrote:

Hi, did you already find some time to take a look again at this issue?
Would be glad if you could give some feedback on this.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/zurb/foundation-sites/issues/10447#issuecomment-372479854,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABhdExT_v1U6qk60-04hnZC5xGY5hQDrks5tdvKpgaJpZM4OfsLz
.

--
-andrés

Sure thing, just give me a couple of days and I'll give this PR a spin.

Awesome, let us know if you need any assistance.

Hey Daniel, sorry for the delay.
Got around to this last night, had to do a major update of Meteor and ran into some issues, want to wrap this up today -- but it seems the PR was deleted, and the one I should be testing is the one here:
https://github.com/zurb/foundation-sites/pull/11077
Is this correct?

The PR is https://github.com/zurb/foundation-sites/issues/10447#issuecomment-367123856

The PR was not deleted, just the branch. The one that you linked to is the new one, right.

Great, will test this evening

I'm having a bit of a hard time applying this pull request. I'm assuming I
need to clone foundation-sites (develop), and apply this mail-formatted
patch:
https://patch-diff.githubusercontent.com/raw/zurb/foundation-sites/pull/11077.patch
I'm using 'patch -Rp1 -i', and getting "Unreversed patch detected" for all
but one file.
Am I going about this the wrong way? Once patched, I need a little guidance
as to how to test (using zurb template, and npm installed foundation-sites.
On Wed, Mar 21, 2018 at 10:08 AM, Daniel Ruf<EMAIL_ADDRESS>wrote:

The PR was not deleted, just the branch. The one that you linked to is the
new one, right.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/zurb/foundation-sites/issues/10447#issuecomment-374971163,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABhdE8FVjhHNlDC2vtLVTuqph8ej4cfKks5tgmz9gaJpZM4OfsLz
.

--
-andrés

Did you clone https://github.com/ncoden/foundation-sites and checkout the branch of the PR?

Daniel,
I noticed that this is now merged in with develop branch, I've pulled re-built and tested. Sticky is still not working for me. Please let me know if there is anything you'd like to me to do. My time has freed up and I am available.

Please provide the steps that you took.

I'm using zurb template, so within the project:
cd node_modules
mv foundation-sties foundation-sites.bup
git clone https://github.com/zurb/foundation-sites.git (develop already checked out)
cd ../
rm -rf dist
npm run build

Afterwards the plugin does seem to init (attributes are updated on the element, and container element) but nothing happens.

Yeah, same issue as I had before (haven't worked on this project for a while, so just getting back to it).
After init, if I manually use the _calc method it works:
$('#element').foundation('_calc', true);

cc @ncoden

We have improved that in Foundation v6.6. As there are no codepen or any steps to reproduce it is hard to test.
We are closing this issue due to this. If there are still issues in the latest release, please let us know.


Batch reprepare speculatively

Extracted repreparing as a method on Connection to avoid duplication. Also, after one statement in a batch is found to be unprepared, we speculatively prepare all prepared statements in the batch, as there is likelihood that once one of them becomes unprepared, the others do too.
Fixes: #529
Pre-review checklist

[x] I have split my patch into logically separate commits.
[x] All commit messages clearly explain what they change and why.
[ ] I added relevant tests for new features and bug fixes.
[x] All commits compile, pass static checks and pass test.
[x] PR description sums up the changes and reasons why they should be introduced.
[x] I added appropriate Fixes: annotations to PR description.

I've noticed I perform all prepares sequentially, effectively contradicting the purpose of this PR. Will change it into concurrent reprepare.

v2: made reprepares concurrent.

On the other hand, this is pessimizing for situations where the number of invalidated statements is orders of magnitude smaller than the number of statements in the batch.
We currently implement a variant of LRU with two pools (ref: https://github.com/scylladb/scylladb/commit/1a9c6d9fd3) and this speculative preparation may interact badly with the algorithm by pushing other prepared statements from the first, probationary buffer, even though lots of them might have already been prepared.
So, in order to judge how we should proceed with this, here's question 1: was this pull request based on an existing issue that somebody (or our test case) discovered, or was it a result of code inspection? If it's not based on a real issue, we at least need a couple of tests to prove that it makes sense, comparing what happens when a minority and majority of batch statements are not prepared, respectively.

(btw, the commit which deduplicates repreparing logic is good on its own anyway, so we can definitely apply that one regardless of the result of this discussion)

On the other hand, this is pessimizing for situations where the number of invalidated statements is orders of magnitude smaller than the number of statements in the batch.
We currently implement a variant of LRU with two pools (ref: scylladb/scylladb@1a9c6d9fd3) and this speculative preparation may interact badly with the algorithm by pushing other prepared statements from the first, probationary buffer, even though lots of them might have already been prepared.
So, in order to judge how we should proceed with this, here's question 1: was this pull request based on an existing issue that somebody (or our test case) discovered, or was it a result of code inspection? If it's not based on a real issue, we at least need a couple of tests to prove that it makes sense, comparing what happens when a minority and majority of batch statements are not prepared, respectively.

It was based solely on code inspection.

On the other hand, this is pessimizing for situations where the number of invalidated statements is orders of magnitude smaller than the number of statements in the batch.

As noted, implementing this could probably bring more harm than gain. Thus, closing.


Refactor config.cfg for config samples and doc

IDEs recognize cfg files as config files which is favorable for highlighting. This is currently we use txt for the samples.
This does not influence how the file is read.

solved see commit above


Incorrect redirection on session expiration with Cognito/Google

When a session expires, ra-auth-cognito does not appear to correctly redirect a user to the Cognito hosted UI.
In this state, this is what appears to happen, in chronological order:

getPermissions is called in the authProvider

the call to userPool.getCurrentUser() returns a valid user
the call to user.getSession returns an error: Cannot retrieve a new session. Please authenticate.
getPermissions returns Promise.reject with the error

checkAuth is called in the authProvider

the call to userPool.getCurrentUser() returns a valid user
the call to user.getSession returns an error: Cannot retrieve a new session. Please authenticate.
checkAuth returns Promise.reject with the error

If the {loginPage} attribute on <Admin> is set to Login (from this library), the user is forwarded to the Login view. This is not useful since username/password is not enabled. There appears to be no way to return to the Cognito Hosted UI login page without manually updating the URL in the location bar. Clearing browser data, navigating back to the applications root URL, etc. all lead to this scenario.

If the {loginPage} attribute on <Admin> is set to false, which makes sense given the information in #2, the screen is stuck on a loading view:

Making the following change in authProvider.ts checkAuth function resolves the issue in my testing:
        user.getSession((err, session) => {
          if (err) {
            console.log(err);
            // log the error?
+            return redirectToOAuthIfNeeded(new HttpError('No user', 401));
-            return reject(err);
          }

Changing this in getPermissions is not possible without larger changes, given where the redirectToOAuthIfNeeded is currently defined.
More information on the configuration of the application I am developing and how I am testing

testing using Brave Version 1.48.164 Chromium: 110.0.5481.100 (Official Build) (arm64)
Cognito and Google project set up according to documentation in this repository, with the exception that the Cognito application is configured to us Google as the only identity provider. Cognito user pool is not enabled.
Hosted UI is enabled using a Cognito domain, no custom domains
Additional information on the configuration of the Cognito app client:

Authentication flows
ALLOW_CUSTOM_AUTH
ALLOW_REFRESH_TOKEN_AUTH
ALLOW_USER_SRP_AUTH

Authentication flow session duration
3 minutes

Refresh token expiration
60 minutes

Access token expiration
5 minutes

ID token expiration
5 minutes

Relevant package versions in the project:

    "amazon-cognito-identity-js": "^6.1.2",
    "ra-auth-cognito": "^1.0.0",
    "ra-core": "4.7.2",
    "ra-data-simple-rest": "4.8.1",
    "react": "^18.2.0",
    "react-admin": "4.7.1",
    "react-dom": "^18.2.0",
    "react-scripts": "5.0.1",

Please let me know if I can provide any more details that would help.

Thanks for the detailed report and the fix. I was able to reproduce it and fix it

Hi, I still have this exact same issue with 1.0.1...

please can you make a new release with the fix... it's in fact not in 1.0.1


Simple CLI

Hi,
I do not know if it already exists, but is there a simple CLI for prql, where is takes in a prql file and writes a output (sql, etc)?
I could not find hints to that in the Readme.

Perhaps you are looking for prqlc?
This is a single binary CLI tool, but I think you will have to build it yourself as there is no distribution of pre-built binaries at this time.
https://github.com/PRQL/prql/tree/main/prql-compiler/prqlc

Ah, there it is. Maybe it is worthwhile to make is a bit more visible in the readme. I was looking for 'cli' or something like that and was not able to find it.

Agree. The documentation definitely has a lot of room for improvement....

Maybe a compiled binary for the prqlc could be made available on GitHub when a release is tagged?

I am fine with that. I just installed it via cargo. It was just hard to find. But having it released as a binary might be beneficial for others.

Closing because you want to make it more visible in #1877


Full-scale game disassemblies/decompilations

Hi, are you interested in adding disassembly/decompilation projects of commercial games? I am aware of a few dozen.

Not at the moment, but perhaps later if I get around to being more active with this again.


Update name of workflow in CICD - incorrectly named as publish to testpypi

The final stage should publish to pypi and not test pypi - note that only the name of the workflow needs to be changed to avoid confusion, the process is still correct.


Block Viewer: Show some additional stats

We can show some more information in the Block Viewer:

Last refresh time: it's already available in the API response
Total number of blocks (across all sources)
Total number of blocks in each group
Number of overlapping blocks (in each row/group and overall)
Which blocks are currently being compacted/downsampled (makes sense only when the Block Viewer is run from compactor)

@prmsrswt How would you like to display block statistics for each group? I was thinking of displaying it in the right sidebar similar to that of each block.

Hmm, that can work. Currently, I don't have a design in my mind, it'd be great if you can figure out something.

@aribalam I've opened a PR that takes care of the first 3 points so you might want to skip them.
cc: @prmsrswt

Still valid.

Still valid.

@ruddi10 sure, there's some on-going work around this issue so just keep those in mind.

@prmsrswt  There are no linked pull requests with this issue. So if you can please tell me what all is completed

There's this PR which handles quite a few of them: https://github.com/thanos-io/thanos/pull/3467

Still valid.

@GiedriusS Can I work on this? 👀
I guess there's a PR https://github.com/thanos-io/thanos/pull/3467 which can be used as the base 😶

Yep! Feel free to ask any questions if you have any.

@GiedriusS  has this issue been resolved? If not, may I take up this task?


Add README and contributors

@all-contributors add @loicmathieu for code and maintenance

@all-contributors add @loicmathieu for code and maintenance


2 Stage Heating

Is your feature request related to a problem? Please describe.
I have a mini-split system that cannot keep the set temperature when heating if the outside temperature gets too low.  I have a pellet stove that is used as a backup heat source and as auxiliary heat.
Describe the solution you'd like
I would like to be able to pick a second switch (in my case a Shelly 1 Plus) which controls an auxiliary heat source that is enabled/disabled when the primary heat source cannot keep the target temperature.  The trigger would be configurable with a combination of time and degrees from target temp (ie. if the current temperature is 2 degrees less than the set temp for 10 minutes).  The second heat source should have min/max on and off time configurable to prevent short cycling.
Describe alternatives you've considered
Currently with my SmartSi thermostats I have a separate NodeRed automation to handle this.
Additional context
None

Hello @kadaan ,
Thank you for your report. There is already a feature called aux_heat in the standard simple thermostat but I have to admit I don't understand what it is related for.
I see some services like: turn_aux_heat_on, def turn_aux_heat_off which seems exactly to be what you need.
Because I implement all features of standard climate entity, I wonder if it is not working out of the box.
Can you try calling the SERVICE CLIMATE.SET_AUX_HEAT to see what happens ?

I will try and see.

Any news on this ?

I close this due to non activity. Please reopen if needed


Counter reset between usages in containers

Description
While helping with a document on the discord server, I stumbled upon a curious bug:
#let q = counter("question")
#let step-show = {
    q.step()
    q.display("1")
}

#grid(step-show, step-show)

#pagebreak()
#step-show

#grid(step-show, step-show)

Will result in the following pages:
Page one:

Page two:

Removing the pagebreak, or moving the outer step-show before it solves the issue.
Reproduction URL
No response
Operating system
Web app
Typst version

[X] I am using the latest version of Typst

Behaviour is even more weird when adding extra #show-step calls after the second grid
#let q = counter("question")
#let step-show = {
    q.step()
    q.display("1")
}

#grid(step-show, step-show)

#pagebreak()
#step-show

#q.update(10)
#grid(step-show, step-show)

// None:
//

// One:
#step-show

// two:
#step-show

none:

one:

two:

lol what

Has there been any progress in resolving this issue? The following similar code exercises a similar sort of behaviour.
#let c = counter("c")
#let foo() = locate(
    loc => {
      c.step()
      c.display("1")
      str(c.at(loc).first())
    }
  )

#{
foo()
block(
  foo()
)
foo()
foo()
block(
  foo()
)
block(
  foo()
)
foo()
}

I have identified the problem some time ago, but the solution isn't yet implemented (and there also a few problems to be solved). We need to implement a new mechanism for assigning locations to elements. More details here: https://laurmaedje.github.io/posts/frozen-state/


chore: update security best practice

Problem Statement
Currently, users have no easy way to know how to enforce better TLS ciphers on webhook (even though the feature is there).
Adding documentation on security best practices on how to do it.

Nice, thanks for adding this!


Icons in bottom left icorrectly aligned after latest BD update

Describe the bug
A clear and concise description of what the bug is.
The settings, mute, and deafening buttons are misaligned. In the image, I also have Game Activity Toggle, but that does not align them when disabled. I have tested with ALL plugins disabled. I am on the latest.
Screenshots
If applicable, add screenshots to help explain your problem.

Update: This also includes these buttons, the emoji button, and the game theme is not correctly themed, button broke there too.

Hi, every icon in VC dosen't work from my perspective


upgrade node to v18 for csb

This PR upgrades the version of node for CodeSandbox to v18 LTS.
Needed for #1436

tbf, i'd probably just remove this integration altogether instead of updating it ;p

It looks like it's a GitHub App so I'm not sure what will happen if the config is completely removed

Rather than doing this, I'd avoid adding knip as a dependency: https://github.com/changesets/changesets/pull/1436/files#r1740307139

It looks like it's a GitHub App so I'm not sure what will happen if the config is completely removed

Good point. I just uninstalled it from this org. Could you remove the config file and retitle this PR?


Make coverage tests pass

General comment: make sure that all the commented code is removed.

Make sure to run hlint and apply the suggestions that are sensible.


GPU out of memory error

Got this out of memory error when i ran python  main.py -- prepare_metadata locally on my machine.
RuntimeError: cuda runtime error (2) : out of memory at /opt/conda/conda-bld/pytorch_1512387374934/work/torch/lib/THC/generic/THCStorage.cu:58
Any ideas how i might change the settings so that I can run the code on my local machine ?

Hi @Neoanarika,

Please paste entire error message.
What GPU do you have? How much memory?

In the prepare_metadata we use GPU when we calculate clusters for the validation purposes. But this is just single image in the forward pass.
Quick fix is to run it on CPUs -> in the vgg_extractor() comment out these two lines:
if torch.cuda.is_available():
    model = model.cuda()

Best,
Kamil

Actually i found out my setup with cuda was the problem. Thanks for the help 👍

@Neoanarika nice! I'm closing this issue.


Format on save for a notebook

Formatting with 'Format Cell' and 'Format Notebook' works but saving a notebook does not apply the formatters to each cell like a normal file would.
Example notebook cell that would be formatted if it was python:
\

print("hello, world")

# output

print("hello, world")

I'm wondering if it's something we can benefit from the file/workingCopy service.

If that makes it easier, black now supports formatting .ipynb files natively, like it supports .py files.

I'd also love format on save for notebooks. As mentioned above, I can use black **/*.ipynb and it works great (you need to install black with the jupyter extra, eg as python -m pip install black[jupyter]), but I'm now just banging my head against the wall trying to get this to run automatically...

I'd also love format on save for notebooks. As mentioned above, I can use black **/*.ipynb and it works great (you need to install black with the jupyter extra, eg as python -m pip install black[jupyter]), but I'm now just banging my head against the wall trying to get this to run automatically...

I really wish it could automatically format on save for jupyter notebooks.

Any update on this?

@NickCrews There is "editor.codeActionsOnSave" but it doesn't allow running arbitrary shell commands (for security reasons?) so you'd need to install an extension like Run On Save and get it call to black path/to/file.ipynb on save events.
Sadly even that doesn't work atm since VS Code does not yet expose lifecycle events for notebooks. The issues to upvote for that are

https://github.com/emeraldwalk/vscode-runonsave/issues/57
https://github.com/microsoft/vscode/issues/130799

If both get implemented, you should be able to add this to your settings to auto-format Jupyter notebooks:
"emeraldwalk.runonsave": {
  "commands": [
    {
      "match": "\\.ipynb$",
      "cmd": "black ${file}"
    }
  ]
}

same/related to https://github.com/microsoft/vscode/issues/130799

This can now be turned on by setting "notebook.formatOnSave.enabled": true.


Not detecting my intel iris xe gpu

So due to the google colabs stuff that's been happening, i downloaded the rvc that supports AMD and Intel gpu's, however it doesn't detect my gpu even though i have the supported download.

Same for me, I have RX5600xt and training is very slow, took multiple hours just to train one epoch


🔧 Allowlist for multiple relayers

🔧 Chore

Put post_data_request behind an allow list.
Motivation

Right now we don't have incentives in place to support permission-less relayers. To mitigate attacks we temporarily enable an allow list on the creation of data requests. This allow list is goverend by the DAO/Gov module

Relayer has been removed, and solvers now exist. No longer needed.


Fix c3sx gate definition (c3sqrtx->c3sx)

[x] I have added the tests to cover my changes.
[x] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.

Summary
Fixes #7148.
Change all the occurrences of c3sqrtx to c3sx to allow a quantum circuit with a
C3SXGate to be converted to qasm and back to a quantum circuit from the qasm.
Modify test_loading_all_qelib1_gates to truly test all qelib1.inc gates (except for specific ones).
Details and comments
During working on this PR, I encountered more issues:

Duplicate definitions and names of gates: rcccx, c3x, c4x, etc.
Initial fixes for the issues should be similar to the one here.

Unfortunately, I would not be able to fix them all now.

I'm not 100% sure that we're safe to change the name of an operation in qelib1.inc; it may well have knock-on implications for how gates are serialised when being passed to the backends, so I'll need to check internally if it's actually safe for us to do that at all.

So I'm waiting for your decision before moving forward with this PR.
Please check the linked issue - there is an alternative solution.

I'm sorry that this PR went so long without a response.  Looking back, and I know you had a maintainer response on your issue before you started work, I don't think this approach was ever going to feel super comfortable, because it always involved changing some fixed data, either on the Qiskit or OpenQASM 2 side.  Both of these had the potential to break existing user code, for something that Qiskit should be able to handle internally.
I've made #9183, which solves the problem in a much more conservative way.  I'm sorry that this PR got lost after the Christmas holidays last year, rather than me being able to work with you to merge it.


[GHSA-w596-4wvx-j9j6] ReDoS in py library

Updates

Affected products
Description

Comments
https://github.com/pytest-dev/py/issues/287#issuecomment-1283567565

Hey there @The-Compiler 👋
I'm sorry for your situation. Sadly people getting CVEs assigned on open issues is not an uncommon occurrence 😞
I've reworded your description update a bit and tried to make the advisory a little richer to aid anyone reading it and I've also added the codepath to the advisory so that dependabot can more intelligently target alerts.
Again sorry for the situation and thank you for reaching out :)

Thanks @darakian! This is very helpful and much appreciated.
Is there any process to get this kind of amendment back into CVE-2022-42969 as well? That would in addition help people outside of the GitHub ecosystem to accurately judge the (non-)severity of this issue for them.

Happy to help! 👍
Updating the root CVE is a harder pull. We don't have any control of that so, you'll need to get in contact with the assigning CNA (mitre in this case) and request the change on their end.
https://cve.mitre.org/about/contactus.html


feat(forge): Use uint fuzz strat for int & convert

Motivation
Our intN fuzzing strategy sucks
Solution
Leverage the UintN strategy and convert to a intN
Note the TODO. needs some validation on if it should be >= or whatever

I wasn't too involved in implementing the strategies, so it's a bit hard for me to follow and understand the motivation/reasoning behind this. Could we add some notes about that?

@mds1 lets maybe do the bytesN stuff in a separate PR, so we can get this over the line? What is blocking us?

Yea separate PR works 👍
@brockelmore why did you change the logic used to convert from uint to int, was the previous version not correct? I'd think we can just change the strategy to use the uint strategy, but keep the conversion logic the same since we know it works

why did you change the logic used to convert from uint to int, was the previous version not correct? I'd think we can just change the strategy to use the uint strategy, but keep the conversion logic the same since we know it works

tbh i just mass deleted the int strategy not really conceptualizing what it did. I will just put that back in and try to wrap this up today

bump - wonder what the best path for getting this over the line is?

Bump again - what's needed for this to get over the line? If the bandwidth is not there I can get it over the line, I just need to know what's missing :)

I think what's left is:

Restore the original logic used to convert from uint to int, see this comment: https://github.com/foundry-rs/foundry/pull/1259#issuecomment-1101548432
Fix the if condition check as described in this comment: https://github.com/foundry-rs/foundry/pull/1259#discussion_r848450675. Basically, instead of the current if x > U256::from(2u32).pow((nc as u32 / 2).into()) it should follow the logic in those two bullet points in that thread
In this PR or in a follow up PR, we should use the same strategy for FixedBytes also, since this strategy can also apply to all bytesNN types.

@brockelmore let me know if that sounds right to you.
IIRC both @brockelmore and myself at one point said we'd finish this PR, then both never got around to it 😅

Closing this in favor of #2499 :smile:


docs: circleci continuous integration example

Adds a basic circleci example almost equivalent to the github actions one.
I've tested the configuration on a personal project and it seems to work fine, but I am not a circleci user so please review thoroughly

Kodiak is too clever, wasn't expecting an immediate merge on approval with comments. Going back and cleaning up.


Python setup.py  install  error

pip，git clone,and zip the same problem,  i'am centos6
[root@]# python setup.py install --yes USE_AVX_INSTRUCTIONS
running install
running bdist_egg
running build
Detected Python architecture: 64bit
Detected platform: linux2
Configuring cmake ...
-- The C compiler identification is GNU 4.8.2
-- The CXX compiler identification is GNU 4.4.7
-- Check for working C compiler: /usr/bin/cc
-- Check for working C compiler: /usr/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler: /usr/bin/g++
-- Check for working CXX compiler: /usr/bin/g++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Boost version: 1.41.0
-- Found the following Boost libraries:
--   python
-- Found PythonLibs: /usr/lib64/libpython2.6.so (found suitable version "2.6.6", minimum required is "2.6")
-- USING BOOST_LIBS: /usr/lib64/libboost_python-mt.so
-- C++11 activated.
-- Enabling AVX instructions
CMake Deprecation Warning at /home/bl/dlib/dlib/CMakeLists.txt:31 (cmake_policy):
The OLD behavior for policy CMP0023 will be removed from a future version
of CMake.
The cmake-policies(7) manual explains that the OLD behaviors of all
policies are deprecated and that a policy should be set to OLD only under
specific short-term circumstances.  Projects should be ported to the NEW
behavior and not rely on setting a policy to OLD.
-- Looking for pthread.h
-- Looking for pthread.h - found
-- Looking for pthread_create
-- Looking for pthread_create - not found
-- Looking for pthread_create in pthreads
-- Looking for pthread_create in pthreads - not found
-- Looking for pthread_create in pthread
-- Looking for pthread_create in pthread - found
-- Found Threads: TRUE
-- Looking for XOpenDisplay in /usr/lib64/libX11.so;/usr/lib64/libXext.so
-- Looking for XOpenDisplay in /usr/lib64/libX11.so;/usr/lib64/libXext.so - found
-- Looking for gethostbyname
-- Looking for gethostbyname - found
-- Looking for connect
-- Looking for connect - found
-- Looking for remove
-- Looking for remove - found
-- Looking for shmat
-- Looking for shmat - found
-- Looking for IceConnectionNumber in ICE
-- Looking for IceConnectionNumber in ICE - found
-- Found X11: /usr/lib64/libX11.so
-- Looking for png_create_read_struct
-- Looking for png_create_read_struct - found
-- Looking for jpeg_read_header
-- Looking for jpeg_read_header - found
-- Searching for BLAS and LAPACK
-- Found PkgConfig: /usr/bin/pkg-config (found version "0.23")
-- Checking for module 'cblas'
--   No package 'cblas' found
-- Checking for module 'lapack'
--   No package 'lapack' found
-- Looking for sys/types.h
-- Looking for sys/types.h - found
-- Looking for stdint.h
-- Looking for stdint.h - found
-- Looking for stddef.h
-- Looking for stddef.h - found
-- Check size of void*
-- Check size of void* - done

*** No BLAS library found so using dlib's built in BLAS.  However, if you ***
*** install an optimized BLAS such as OpenBLAS or the Intel MKL your code ***
*** will run faster.  On Ubuntu you can install OpenBLAS by executing:    ***
***    sudo apt-get install libopenblas-dev liblapack-dev                 ***
*** Or you can easily install OpenBLAS from source by downloading the     ***
*** source tar file from http://www.openblas.net, extracting it, and      ***
*** running:                                                              ***
***    make; sudo make install                                            ***

CUDA_TOOLKIT_ROOT_DIR not found or specified
-- Could NOT find CUDA (missing: CUDA_TOOLKIT_ROOT_DIR CUDA_NVCC_EXECUTABLE CUDA_INCLUDE_DIRS CUDA_CUDART_LIBRARY) (Required is at least version "7.5")
-- *** cuDNN V5.0 OR GREATER NOT FOUND.  DLIB WILL NOT USE CUDA. ***
-- *** If you have cuDNN then set CMAKE_PREFIX_PATH to include cuDNN's folder.
-- Configuring done
-- Generating done
-- Build files have been written to: /home/bl/dlib/tools/python/build
Build using cmake ...
Scanning dependencies of target dlib
[  1%] Building CXX object dlib_build/CMakeFiles/dlib.dir/base64/base64_kernel_1.cpp.o
In file included from /home/bl/dlib/dlib/base64/base64_kernel_1.h:6,
from /home/bl/dlib/dlib/base64/base64_kernel_1.cpp:6:
/home/bl/dlib/dlib/base64/../algs.h:313: error: expected constructor, destructor, or type conversion before ‘bool’
/home/bl/dlib/dlib/base64/../algs.h:324: error: expected constructor, destructor, or type conversion before ‘bool’
/home/bl/dlib/dlib/base64/../algs.h:335: error: expected constructor, destructor, or type conversion before ‘bool’
/home/bl/dlib/dlib/base64/../algs.h:346: error: expected constructor, destructor, or type conversion before ‘bool’
gmake[2]: *** [dlib_build/CMakeFiles/dlib.dir/base64/base64_kernel_1.cpp.o] Error 1
error: cmake build failed!

Your compiler is really old.  You need to use a compiler that supports C++11.  So install a newer version of gcc or clang.


release: cannot install from .pkg into any dir except /usr/local/go

Please answer these questions before submitting your issue. Thanks!

What version of Go are you using (go version)?
1.7rc2
What operating system and processor architecture are you using (go env)?
Mac OS 10.11.4, darwin amd64
What did you do?
I installed 1.7rc2 from the pkg build (go1.7rc2.darwin-amd64.pkg).  I had set GOROOT to a different directory, but it always installs to /usr/local/go.

The documentation earlier, if I remember right, had a way to install to a different directory but even that is not there.
Is there no way to install it to a different directory?

CC @adg @broady

use go1.7rc2.darwin-amd64.tar.gz instead .pkg and will work.

But shouldn't .pkg also respect the go env values?

acording with dfc

These binaries have a $GOROOT value of /usr/local/go and recommend you unpack them into that location.

i always use the archive for other locations nor pkg  because it works. (for stable releases i use this project).

There is a related issue with the Windows installer (#16305) whereby users may choose an alternate installation directory, but two installations cannot coexist.
Let's look into making this user-configurable, but once we do, it'll have the same problem as the Windows installer.

@broady what's the status here?

Kicking down the road, since nobody owns this and it's not a regression.

I'm not sure this is a problem.
If you have opinions about installation directory, untar it there.
If you want the easy way, accept the conventions.


chore(v2): merge main down

Issue #, if available:
Description of changes:

Checklist

[ ] Meet tenets criteria
[ ] Update tests
[ ] Update docs
[ ] PR title follows conventional commit semantics

Breaking change checklist

RFC issue #:

[ ] Migration process documented
[ ] Implement warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 77.21%. Comparing base (8f176cc) to head (4976a5b).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff            @@
##                 v2    #1608   +/-   ##
=========================================
  Coverage     77.21%   77.21%
  Complexity      469      469
=========================================
  Files            49       49
  Lines          1685     1685
  Branches        254      254
=========================================
  Hits           1301     1301
  Misses          298      298
  Partials         86       86

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Assistance doing simple password authentication against a domain account from non-member system

Question
I'm using this with DBeaver client (and also seeing similar problem from mssql-scripter tool).
From Perl DBD and tsql clients I am able to authenticate with "SHORTDOMAIN\userid" and password, with no special actions taken. This is from a non-domain-joined system - i.e. I'm not authenticating with kerberos -- just userid and password.
From the dbeaver UI using mssql-jdbc, I have not been able to find any combination of settings to allow this authentication to work. I also have the same issue connecting with mssql-scripter utility, though that is python based.
The usual response error is just a login failure. If this weren't working from other clients like the perl and freetds tsql command line client, I'd point it at server configuration -- but it's clearly working from other tools. Is there something I need to do to get this to work?
Example:
root@itapps-d1:~ $ tsql -H HOSTNAME -U DOMAIN\\userid -D DBNAME -p 1433
Password:
locale is "LC_CTYPE=C.UTF-8;LC_NUMERIC=en_US.UTF-8;LC_TIME=en_US.UTF-8;LC_COLLATE=en_US.UTF-8;LC_MONETARY=en_US.UTF-8;LC_MESSAGES=en_US.UTF-8;LC_PAPER=en_US.UTF-8;LC_NAME=en_US.UTF-8;LC_ADDRESS=en_US.UTF-8;LC_TELEPHONE=en_US.UTF-8;LC_MEASUREMENT=en_US.UTF-8;LC_IDENTIFICATION=en_US.UTF-8"
locale charset is "UTF-8"
using default charset "UTF-8"
Setting DBNAME as default database in login packet
1>

I'm happy to run with a test build/etc. if it helps to diagnose.
Relevant Issues and Pull Requests

Hi nneul, what version of the JDBC driver are you using? And what version JDK? Is your client a Windows or Linux OS. What version SQL Server are you using, is it SQL Server Linux or no? What type of authentication are you trying to accomplish here, does Windows Integrated not work?

Most recent test was with plugin 8.2.0-jre8, but I can drop in newer if needed to reproduce.  DBeaver embeds 1.8.0_252.
SQL Server Authentication - login failed
Windows Authentication - not option since unjoined linux box, fields all gray
NTLM - login is from an untrusted domain
Active Directory - Password - Login failed for user
Active Directory - MSI - pw prompt is grayed out
Active Directory - Integrated - pw and user prompt grayed out
Kerberos - not domain joined, cannot use
Custom - logon failed for user
Client on Linux (ub18 and ub20). I am able to use the 'Windows Authentication' from windows clients that are domain joined.
Target SQL server version is 14.0.3281.6 on windows.
I'm connecting from a non-domain member non-windows box, and my access to the target database (which is not under my control) is granted to a domain user.
From a windows client I am able to use windows authentication with the plugin.

I have some other sql servers that are under my control that I could test with if needed, but the overall scenario would be the same - linux client, connecting to target server with an AD based userid+pw.
Connecting with built-in sa account DOES work, but does not help this scenario.

Key thing with all of this - I can connect just fine with perl and tsql clients from linux - but not using the JDBC based client. So what's not clear to me is what they are doing different in how they pass the authentication information.


Update 'manage your subscriptions' content

This PR updates the content for the Manage your subscriptions journey.
The content changes aim to:

set user expectations
provide useful information at the most appropriate point in the journey
improve the consistency of content elsewhere in the email notifications service

Card this relates to: https://trello.com/c/Psx11gaR/68-first-iteration-of-content-updates-for-the-manage-subscriptions-journey


Bump to k6 v0.45.1 to fix build

Hello, can you explain which build is broken ?

Hi @pmalhaire , sorry - I was doing bulk edits late in the (fri) day and could've done better message.
This is updating to v0.45.1 which doesn't not depend on a dependancy lib that "dissapeared" more info in https://github.com/grafana/k6/issues/3252 and linked issues


Panther manager refactor

manager_bt_node was moved to 2 separate nodes for lights and safety
some methods were moved to bt_utils.hpp
blackboard entries are now updated in topic callbacks
changed node naming in panther_diagnostics to match other packages standard, also added launch file
tests for new ROS nodes
Tests for behavior trees logic will be added later

@coderabbitai review

@coderabbitai review


Add support for C++ messages, make conversion symmetrical, and refactor

See https://discourse.ros.org/t/ros-2-type-support-introspection-and-conversion-of-c-c-messages-to-from-yaml/22295
Signed-off-by: Christophe Bedard<EMAIL_ADDRESS>

I don't quite understand the inclusion of both C and C++ namespaces, when there doesn't appear to be much difference between the types used in each.

I don't quite understand the inclusion of both C and C++ namespaces, when there doesn't appear to be much difference between the types used in each.

The underlying functions do things differently: the message (bytes) <--> YAML conversion isn't the same for C and C++ messages. That's why I used two different namespaces with roughly the same function names. Then, on top of this, I wanted to provide extern "C" functions so that C messages could be converted from C directly without the caller needing C++. std::string being used in the extern "C" functions is clearly an oversight (showing that I don't test this "functionality"), so I'll fix it.
Does this make sense?

std::string being used in the extern "C" functions is clearly an oversight (showing that I don't test this "functionality"), so I'll fix it.

Well it seems like I didn't really think it through back then. Actually supporting using dynmsg from C would require a few more changes, so I just removed most of the extern "C" functions: 75fd6b88dbcb2cc5110e72f25a827bfe8e8597f1. We can add this C functionality later on in another PR if it's actually needed.

I'm seeing a huge number of test failures. @christophebedard could you check them out?

I'm seeing a huge number of test failures. @christophebedard could you check them out?

@gbiggs they were due to the change & workaround I used, namely removing the type/value split in the YAML structure and working around yaml-cpp's limitation with int8_t/uint8_t. I updated the tests: abe0bb21513ee709a07653fb5e4635d00a87e8ca

This looks good to me. In it goes!
Thanks for the contribution!


How to inject dependencies?

It appears there's no generic version of options.Conventions.AddFolderApplicationModelConvention or options.ConfigureFilter. Is there a way to get a hold of the service container within filters, or do we need to create a scope in Startup.cs (hack if you ask me) and pass dependencies in?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f0646a3d-a5d1-d4b0-5494-fe38219d16c9
Version Independent ID: 8b659e63-93b8-a496-bc9b-dce0d9fa8f3c
Content: Filter methods for Razor Pages in ASP.NET Core
Content Source: aspnetcore/razor-pages/filter.md
Product: aspnet-core
Technology: aspnetcore-razorpages
GitHub Login: @Rick-Anderson
Microsoft Alias: riande

Hello! Thanks for contacting us. This sounds like a general question about using ASP.NET Core. While we try to look at and respond to all issues, for questions like this we recommend posting to a community support group like Stack Overflow with the asp.net-core tag.

This is a question about the intent to offer similar function in ASP.NET Razor Pages as exists in MVC - namely the ability to allow the DI container to inject dependencies into filters. I'm not sure how Stack Overflow would help more than the source (Microsoft). Isn't a documentation topic on these specific classes' use the appropriate place to discuss this?


The first knobs button with a title that contains brackets does not render.

Describe the bug
Hi, I am currently using a storybook using the knobs button in ^5.1.0-alpha.40 version.
I found a bug ...
The first knobs button with a title that contains brackets does not render.
However, if the first button is exposed, it will render normally.
Expected behavior
The text must be fully exposed, no matter what text is entered.
Code snippets
// not work
button('selection({ start: [1, 2], end: [3, 4] })', () =>
  app.selection({ start: [1, 2], end: [3, 4] })
);

// work
button('test', () => console.log('test'));
button('selection({ start: [1, 2], end: [3, 4] })', () =>
  app.selection({ start: [1, 2], end: [3, 4] })
);

Screenshots
// first Code snippets code

// second Code snippets code

System:

OS: OSX
Device: macbook pro 2018
Browser: chrome
Framework: preact
Addons: ^5.1.0-alpha.40
Version: ^5.1.0-alpha.40

Additional context
Thanks!

related #6526.


Cannot list network interfaces in docker container

Hello,
We are trying to Dockerize a C program based on the Trion SDK.
Unfortunately, the C program throws this error when the ListNetworkInterfaces() function is called: ERR_TARGET_UNKNOWN (100008)
The same program works fine on the host machine.
The docker image is based on Ubuntu 22, the Dewetron packages are installed and the Trion SDK compiled properly.
The docker image is ran with --privileged and --network host options to allow access of the host network interfaces.
We ran a small C program in order to list the network interfaces in the host machine and in the docker container, it works fine in both cases.
Do you have some information regarding this error in order to further troubleshoot the issue ?
Thanks and best regards

Hello,
i just tried to run  TN_OneAnalogChannel in an unpriviliged docker container.
ListNetworkInterfaces prints following output:
<?xml version="1.0"?>   <Network>     <Enumerate>       <Interface name="lo" index="1" hwaddress="00:00:00:00:00:00" flags="65609">         <Address family="1" address="<IP_ADDRESS>" mask="<IP_ADDRESS>" broadcast=""/>         <Address family="2" address="::1" mask="ffff:ffff:ffff:ffff:ffff:ffff:ffff:ffff" broadcast=""/>         </Interface>       <Interface name="eth0" index="127" hwaddress="02:42:ac:11:00:02" flags="69699">         <Address family="1" address="<IP_ADDRESS>" mask="<IP_ADDRESS>" broadcast="<IP_ADDRESS>"/>         <Address family="2" address="fd00::242:ac11:2" mask="ffff:ffff:ffff:ffff:ffff::" broadcast="ffff:ffff:ffff:ffff:ffff::"/>         <Address family="2" address="fe80::42:acff:fe11:2%eth0" mask="ffff:ffff:ffff:ffff::" broadcast="ffff:ffff:ffff:ffff::"/>         </Interface>       </Enumerate>     </Network>
I am pretty sure your problem is, that you use TRION API (that is used to access local hardware). If you want to use net devices (TRIONet, NexDAQ), you have to use TRIONET API instead.
You have to use following define:
USE_TRIONET_API
which is shown in the examples CMakeList files:
  set_property(TARGET ${SAMPLE}     APPEND     PROPERTY COMPILE_DEFINITIONS     USE_TRIONET_API   )
I am able to reproduce
Error: ERR_TARGET_UNKNOWN (100008)
when I deliberatly enable ListNetworkInterface in TRION examples. This is correct behaviour.
I hope this information helps!
Best regards,
Gunther

I am sorry that the SDK documentation does not explain this. We will try to improve.
Bye Gunther

Hello Gunther,
Thanks for the reply. We actually do define the USE_TRIONET_API flag.
Here's a Dockfile to reproduce the issue we have:
# Use the Ubuntu 22.04 as the base image
FROM ubuntu:22.04

# Set the working directory inside the container
WORKDIR /opt

# Update the package list and install dependencies for Dewetron package
# This might be simplified at some point
RUN apt update && \
    apt install -y --no-install-recommends \
    git \
    cmake \
    build-essential \
    ca-certificates \
    libpci-dev \
    libboost-all-dev \
    dkms \
    qtbase5-dev qtchooser qt5-qmake qtbase5-dev-tools \
    libczmq4 libgstreamer-plugins-base1.0-0 libgstreamer1.0-0 libmatio11 libmodbus5 \
    libqt5multimedia5 libqt5positioning5 libqt5qml5 libqt5quick5 libqt5svg5 vpx-tools mkvtoolnix \
    gstreamer1.0-plugins-base gstreamer1.0-plugins-good gstreamer1.0-plugins-bad \
    libgstreamer-plugins-good1.0-0 libgstreamer-plugins-bad1.0-0 libvpx7 liborc-0.4-0 \
    libqt5multimedia5-plugins qml-module-qtquick-dialogs qml-module-qtquick-xmllistmodel \
    qml-module-qt-labs-folderlistmodel qml-module-qtquick-controls qml-module-qtquick-controls2 qml-module-qtquick-shapes \
    net-tools \
    && rm -rf /var/lib/apt/lists/*

# Install Dewetron package
# We might save space by intalling packages independently at some point
COPY dewetron-apps-<IP_ADDRESS>-jammy.install .
RUN ./dewetron-apps-<IP_ADDRESS>-jammy.install

# Clone the TRION-SDK repository from GitHub and checkout tag TRION-R7.0.0
RUN git clone --no-checkout https://github.com/DEWETRON/TRION-SDK.git && \
    cd TRION-SDK && \
    git fetch --tags && \
    git checkout tags/TRION-R7.0.0

# Configure and build TRION-SDK samples. This also builds the trion_sdk_utils static lib
RUN cd TRION-SDK/trion/C && mkdir build && cd build && cmake .. && make
RUN cd TRION-SDK/trionet/C && mkdir build && cd build && cmake .. && make

# Copy tn_one_analog_channel sample and compile it directly
RUN cp TRION-SDK/trionet/C/analog/TN_OneAnalogChannel/tn_one_analog_channel.c .
 We also copy the tn_one_analog_channel and compile it directly.
When running the samples within the docker container:

the sample provided with the SDK runs fine
the sample compiled direclty gives a ERR_TARGET_UNKNOWN  error

We did the same thing on the host machine and both samples ran fine.
What did we miss that would cause the sample compiled in the docker container to fail ?
Best regards

The issue is the usage of trion_sdk_utils atatic lib:
From trion_sdk_util.c
#include <stdio.h>
#include <string.h>
#ifdef USE_TRIONET_API
#  include "dewepxinet_load.h"
#else
#  include "dewepxi_load.h"
#endif
#include "dewepxi_apicore.h"
#include "dewepxi_types.h"
#include "trion_sdk_util.h"
#ifdef WIN32
#include "dewepxi_apiutil.h"
#else
#include <stdio.h>
#endif

It also has to be build with USE_TRIONET_API defined.
Bye Gunther

Well done, we missed the fact that the utility lib was also compiled for trionet.
Thanks Gunther, I'm closing the ticket


data(gapminder): population v7

Gapminder released version 7 of their Population dataset. This dataset will be used to update our population OMM.
I have checked any changes between v6 and v7; they are all as expected. Changes are due to new estimates from UN WPP 2022, as v6 used UN WPP 2019.
UN WPP 2022
This version uses UN WPP 2022 estimates (instead of 2019) for data starting in 1950.
Minor adjustments before 1950
For data before 1950, Gapminder relies on CLIO Infra and US Census Bureau.
We have noticed that Gapminder has made some minor adjustments to data before 1950 (when comparing with v6).
For 22 countries, values have slightly changed in some years. These changes go from 5% to 22%. Find below the list of countries based on their maximum relative change in population:

5% - 7.5%: India, North Korea, Tonga, Mauritius, Malta, Fiji, United States, Samoa, United Arab Emirates
7.5% - 10%: Sudan, Azerbaijan, Vanuatu, Saint Vincent and the Grenadines, Central African Republic, Jordan, Suriname
10% - 15%: Serbia, Uganda, Kiribati
>15%: Solomon Islands, Lesotho, Papua New Guinea

These adjustments are likely caused due to the changes introduced by the 2022 revision by the UN. Gapminder adjusts the values before 1950 to align with UN's. Therefore, changes in UN estimates will influence these adjustments.
An example is Papua New Guinea, for which the UN estimated a population of 1,927,846 in 2019 and 1,542,854 in 2022. Therefore, Gapminder has adjusted their estimates for 1949 (roughly a 22%).
In their metadata for the period 1800 - 1949, Gapminder states:

Mainly Maddison via ClIo infra with some adjustments made by Gapminder to have estimates meet the UN data in 1950.

More details on the original dataset: https://docs.google.com/spreadsheets/d/1c1luQNdpH90tNbMIeU7jD__59wQ0bdIGRFpbMm8ZBTk/edit#gid=501532268

I have checked in open_numbers and have not been able to find any population data with historical values (i.e. data before 1950).
On the one hand

Data from https://github.com/open-numbers/ddf--gapminder--population seems only to have data starting from 1950.
Data from https://github.com/open-numbers/ddf--gapminder--population_historic was last updated 2/3 years ago.

On the contrary, data from https://www.gapminder.org/data/documentation/gd003/ contains data before 1950.
c. @larsyencken


Add CBA

What would we be without it?

^^
BTW: Should be under "ADV_Medical" as the list should be sorted alphabetically.

🤦♂ I have errors a 2nd grader wouldn't do in half of these PRs for some reason.


Fixes Potion and Enchantment ID Conflicts

I'm sure there might be some other conflicts that I didn't catch, but I fixed everything I could find:

Sanguimancy's AddHeart and RemoveHeart were overriding Blood Magic's Drowning and Haste
All of Brewcraft's Potion Effects were overriding Witchery
Added the default Aura Cascade config since it isn't already included

Changed Potion IDs to resolve conflicts with Botania
Changed Enchantment IDs to resolve conflicts with Blue Power

Too many configs were changed to merge this, I copied all the raws and pasted them into my working copy, all seems to work and it has been added manually, thanks for this.


Page not found in Ruby Docs

Issue:
Source links in Ruby API documentation are broken.
Example:
If you go to the Ruby API documentation and click on any Source Code link it will 404.

@frankyn Thank you for taking the time to report this. I am closing it as a dupe of #908, which I reopened. (#908 captures some discussion on the cause and solution; in case there is any more, I want to keep it in that issue.)
Please never hesitate to open an issue when you see something that can be improved in the docs (or the libraries.) Much appreciated!

Thanks @quartzmo!


conversion of cuda tensors

I am getting an error at the end of a fastai training loop.

can't convert CUDA tensor to numpy. Use Tensor.cpu() to copy the tensor to host memory first.

Seems a bit weird that pytorch does not just log a warning and do the conversion for you. However as they don't it would be useful to add ".cpu()" in the progress bar or earlier. This is my stack trace:
TypeError                                 Traceback (most recent call last)
 in
----> 1 learn.fit(1, lr=.01)
 in fit(self, epochs, lr, callbacks)
8         callbacks = [cb(self) for cb in self.callback_fns] + listify(callbacks)
9         fit(epochs, self.model, self.loss_func, opt=self.opt, data=self.data, metrics=self.metrics,
---> 10             callbacks=self.callbacks+callbacks)
11
12 # create and fit model
~/src/anaconda3/envs/fastai/lib/python3.6/site-packages/fastai/basic_train.py in fit(epochs, model, loss_func, opt, data, callbacks, metrics)
87     except Exception as e:
88         exception = e
---> 89         raise e
90     finally: cb_handler.on_train_end(exception)
91
~/src/anaconda3/envs/fastai/lib/python3.6/site-packages/fastai/basic_train.py in fit(epochs, model, loss_func, opt, data, callbacks, metrics)
84                                        cb_handler=cb_handler, pbar=pbar)
85             else: val_loss=None
---> 86             if cb_handler.on_epoch_end(val_loss): break
87     except Exception as e:
88         exception = e
~/src/anaconda3/envs/fastai/lib/python3.6/site-packages/fastai/callback.py in on_epoch_end(self, val_loss)
250                 met.on_epoch_end(**self.state_dict)
251                 self.state_dict['last_metrics'].append(met.metric)
--> 252         return np.any(self('epoch_end', False))
253
254     def on_train_end(self, exception:Union[bool,Exception])->None:
~/src/anaconda3/envs/fastai/lib/python3.6/site-packages/fastai/callback.py in call(self, cb_name, call_mets, **kwargs)
185         "Call through to all of the CallbakHandler functions."
186         if call_mets: [getattr(met, f'on_{cb_name}')(**self.state_dict, **kwargs) for met in self.metrics]
--> 187         return [getattr(cb, f'on_{cb_name}')(**self.state_dict, **kwargs) for cb in self.callbacks]
188
189     def on_train_begin(self, epochs:int, pbar:PBar, metrics:MetricFuncList)->None:
~/src/anaconda3/envs/fastai/lib/python3.6/site-packages/fastai/callback.py in (.0)
185         "Call through to all of the CallbakHandler functions."
186         if call_mets: [getattr(met, f'on_{cb_name}')(**self.state_dict, **kwargs) for met in self.metrics]
--> 187         return [getattr(cb, f'on_{cb_name}')(**self.state_dict, **kwargs) for cb in self.callbacks]
188
189     def on_train_begin(self, epochs:int, pbar:PBar, metrics:MetricFuncList)->None:
~/src/anaconda3/envs/fastai/lib/python3.6/site-packages/fastai/train.py in on_epoch_end(self, n_epochs, last_metrics, **kwargs)
55             x_bounds = (0, (n_epochs - len(rec.nb_batches)) * rec.nb_batches[-1] + len(rec.losses))
56             y_bounds = (0, max((max(Tensor(rec.losses)), max(Tensor(rec.val_losses)))))
---> 57             rec.pbar.update_graph([(iters, rec.losses), (val_iter, rec.val_losses)], x_bounds, y_bounds)
58             return False
59
~/src/anaconda3/envs/fastai/lib/python3.6/site-packages/fastprogress/fastprogress.py in update_graph(self, graphs, x_bounds, y_bounds)
189         self.ax.legend(loc='upper right')
190         if x_bounds is not None: self.ax.set_xlim(*x_bounds)
--> 191         if y_bounds is not None: self.ax.set_ylim(*y_bounds)
192         with self.out:
193             clear_output(wait=True)
~/src/anaconda3/envs/fastai/lib/python3.6/site-packages/matplotlib/axes/_base.py in set_ylim(self, bottom, top, emit, auto, ymin, ymax)
3474                  'bottom=%s, top=%s') % (bottom, top), stacklevel=2)
3475
-> 3476         bottom, top = mtransforms.nonsingular(bottom, top, increasing=False)
3477
3478         if self.get_yscale() == 'log':
~/src/anaconda3/envs/fastai/lib/python3.6/site-packages/matplotlib/transforms.py in nonsingular(vmin, vmax, expander, tiny, increasing)
2887     """
2888
-> 2889     if (not np.isfinite(vmin)) or (not np.isfinite(vmax)):
2890         return -expander, expander
2891
~/src/anaconda3/envs/fastai/lib/python3.6/site-packages/torch/tensor.py in array(self, dtype)
430     def array(self, dtype=None):
431         if dtype is None:
--> 432             return self.numpy()
433         else:
434             return self.numpy().astype(dtype, copy=False)
TypeError: can't convert CUDA tensor to numpy. Use Tensor.cpu() to copy the tensor to host memory first.

p.s. quite surprised nobody else has logged this. I suspect it is because historically the way to switch between cpu and cuda was to pass the device around and have .to(device) statements everywhere. I am using default tensor type of cuda float. This is really convenient as it allows one to switch between cpu and cuda with one line of code at the start.

I'm not sure this is an issue of fastprogress. You should go on fastai of the problem is still there.

p.s. quite surprised nobody else has logged this. I suspect it is because historically the way to switch between cpu and cuda was to pass the device around and have .to(device) statements everywhere. I am using default tensor type of cuda float. This is really convenient as it allows one to switch between cpu and cuda with one line of code at the start.

I met the same problem, I check my pytorch version, which is 1.0.0, which I compiled from source. I don't know if it matters.

I have just submitted a pull request to fastai which will fix. It is just a
one line change.
On Thu, 22 Nov 2018 at 02:45, David Xu<EMAIL_ADDRESS>wrote:

p.s. quite surprised nobody else has logged this. I suspect it is because
historically the way to switch between cpu and cuda was to pass the device
around and have .to(device) statements everywhere. I am using default
tensor type of cuda float. This is really convenient as it allows one to
switch between cpu and cuda with one line of code at the start.
I met the same problem, I check my pytorch version, which is 1.0.0, which
I compiled from source. I don't know if it matters.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/fastai/fastprogress/issues/16#issuecomment-440896254,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABJN6fDOqEc6RR_Td1PUPCyYL_7hQ1U9ks5uxg_SgaJpZM4YObmV
.


Introduce new flag -keep-column-names to not uppercase column names

What this Pull Request does / why we need it:
Right now, all columns names of a schema get uppercased automatically.
For my use case, I want to keep the names as provided.
In MySQL, this is not an issue.
Imagine you have this CSV file:
foo,bar,baz
1,3,hey
2,6,ho
3,9,lets
4,12,go

Running
./csv2db generate --file test.csv --table tblname --keep-column-names

will  lead to
CREATE TABLE tblname
(
  foo VARCHAR(1000),
  bar VARCHAR(1000),
  baz VARCHAR(1000)
);

while the old behavior is still the default. Running
./csv2db generate --file test.csv --table tblname

will lead to
CREATE TABLE tblname
(
  FOO VARCHAR(1000),
  BAR VARCHAR(1000),
  BAZ VARCHAR(1000)
);

Special notes for the reviewer:
The current, default, behaviour is not changed.

@gvenzl Just checking if there is any update on this or if you found time to have a look at this pull request?

This is superseded by ER #60.


POM Changes for Spark 4.0.0 [databricks]

This change adds the profiles needed to build the plugin for Spark 4.0.0
This PR depends on #10993
fixes #9259

This is in draft until https://github.com/NVIDIA/spark-rapids/pull/10993 https://github.com/NVIDIA/spark-rapids/pull/10992 are merged

pre-commit task failing for Spark400 as the private repo changes haven't been merged.

@gerashegalov do you have any more questions on this PR?

The 400 Pr check is failing. We need to wait until spark-rapids-private artifact is published https://github.com/NVIDIA/spark-rapids/actions/runs/9519648358/job/26243644463?pr=10994

I was wondering if this could be checked in before #11066. It doesn't need to wait, does it?

@razajafri  @mythrocks there are two pending issues with this PR indicated by the failing check
:x:  mvn[compile,RAT,scalastyle,docgen] / package-tests-scala213 (400, true) (pull_request)

buildver=400 cannot be built due to the corresponding spark-rapids-private dependency being missing
buildver=400 check should also be moved under JDK17

It currently fails with
Error:  Failed to execute goal org.apache.maven.plugins:maven-enforcer-plugin:3.5.0:enforce (enforce-java-version) on project rapids-4-spark-parent_2.13:
Error:  Rule 0: org.apache.maven.enforcer.rules.version.RequireJavaVersion failed with message:
Error:  Support for Spark 4.0.0 is only available with Java 17+

Update https://github.com/NVIDIA/spark-rapids/blob/4b449034f2a0105c687646176590b349f9901ea7/pom.xml#L871-L873
We need to exclude 400 from from PR checks based on JDK8,11

Depends on #11092

@razajafri @mythrocks there are two pending issues with this PR indicated by the failing check
❌ mvn[compile,RAT,scalastyle,docgen] / package-tests-scala213 (400, true) (pull_request)

buildver=400 cannot be built due to the corresponding spark-rapids-private dependency being missing
buildver=400 check should also be moved under JDK17

It currently fails with
Error:  Failed to execute goal org.apache.maven.plugins:maven-enforcer-plugin:3.5.0:enforce (enforce-java-version) on project rapids-4-spark-parent_2.13:
Error:  Rule 0: org.apache.maven.enforcer.rules.version.RequireJavaVersion failed with message:
Error:  Support for Spark 4.0.0 is only available with Java 17+

Update
https://github.com/NVIDIA/spark-rapids/blob/4b449034f2a0105c687646176590b349f9901ea7/pom.xml#L871-L873
We need to exclude 400 from from PR checks based on JDK8,11

It's not that simple as our rules will pick up everything from the pom in snapshots and nosnapshots (I believe) to build against jdk 8. The jdk17.buildvers tag will build using jdk 17 but with Scala 2.12. I am working with @pxLi to come up with changes to the mvn-verify github actions workflow and possibly version-defs.sh

The spark400 would fail jdk8+scala213 github action check, as its optional.
We could add a fix later.
Q: when we are sure about the new rule for spark 400+, if all 400+ following versions would only build against jdk17+scala213?

also do we want to release double releases as the dist jar should not include both jdk8 and jdk17 compiled objects? @sameerz @gerashegalov @jlowe @revans2 @tgravescs

If spark400 is for only debug purpose, then
for  nightly build CI, we can add a separated with JDK17+scala2.13 environment;
for the pre-merge github workflow, we can add a new profile like <snapshot400+> in the pom.xml, and a new job/step  in .github/workflows/mvn-verify-check.yml specified for the profile 400 shims

~The spark400 would fail jdk8+scala213 github action check. As its optional, we could add a fix later.~
Q: are we sure about the new rule for spark 400+, if all 400+ following versions would only build against jdk17+scala213?

Yes spark 400+ requires jdk17+scala213
Spark 4.0.0 is only supported for Scala 2.13
Support for Spark 4.0.0 is only available with Java 17+

Regarding JDK17+JDK8 in the same jar, I don't think that's technically impossible.  jars are just zip files, and each class file separately contains metadata with what JDK it was compiled with/for.  If you couldn't combine class files compiled with different JDK versions, uber/shaded jars would have all sorts of problems, since then one would need to worry about what JDK was used to build every dependency.  The main issue would be trying to access JDK17-compiled files with JDK8, but if we limit the JDK17 class files to only being accessed by the Spark 4 shim, then this should be OK in practice since Spark 4 requires JDK17 to run and would be the only platform accessing those JDK17-compiled classes in the jar.
There's a bigger issue here though, and it's that I'm guessing most of the unshimmed class files may need to be shimmed not because of APIs changing in Spark 4 but solely because they cannot be compiled with JDK8 and thus cannot generate a common class file across Spark versions.  For example, I tried compiling the plugin against Spark 4 with JDK8.  It complained that ColumnarCopyHelper, an unshimmed class, cannot compile because Spark's org.apache.spark.sql.execution.vectorized.WritableColumnVector class is compiled with version 61 and JDK8 only supports up to 52.  When I hacked around that error, I hit GpuColumnVector, another unshimmed class, cannot compile because Spark's org.apache.spark.sql.catalyst.expressions.Attribute class was compiled with 62 instead of 51.  All of this implies that any plugin class that touches a Spark class would need to be shimmed, which would be almost the entire plugin jar.

JDK 9+ has a backwards-compatible solution to the problem of mixing code depending on different JDK releases https://docs.oracle.com/en/java/javase/21/docs/specs/jar/jar.html#multi-release-jar-files.
So a naive and robust solution is to group the existing build process by JDK and then combine in a multi-release jar
later we can optimize duplication with methodology like #6555 and refactor to reduce the number of classes that depend on Spark

I was able to manufacture a working multi-release jar with spark400 and spark330.
I am exploring cross-compilation from JDK17 to JDK8. It should be require less work on the CI side.
Because 400 was not previously tested in combination with other shims there is outstanding coding work. Most notably some unshimmed classes extend internal.Logging which pull in different methods between 3.x and 4.x.

verify-all-modules (311, 8) is in a state of Expected as we haven't updated the parameters list on the github actions. We will do that once this PR is ready to merge as it will affect all the PRs

Got the second prototype working using cross-compile https://github.com/razajafri/spark-rapids/pull/3
So proposal is to simply switch at least the Scala2.13 pipeline to JDK17 for building.  Test runs for Shims other than 4.0.0 can be executed with both JDK 8 or JDK 17. Spark 4.0 tests can only be run on 17+

@pxLi All the cdh shims are failing because they are missing the flatbuffers-java dependency. Can you help me narrow this down.

@pxLi All the cdh shims are failing because they are missing the flatbuffers-java dependency. Can you help me narrow this down.

I saw compilation error but not missing dep issue
[INFO] compiling 459 Scala sources and 58 Java sources to /home/runner/work/spark-rapids/spark-rapids/sql-plugin/target/spark332cdh/classes ...
Error:  /home/runner/work/spark-rapids/spark-rapids/sql-plugin/src/main/scala/com/nvidia/spark/rapids/MetaUtils.scala:112: value createUnintializedVector is not a member of com.google.flatbuffers.FlatBufferBuilder
Error:  /home/runner/work/spark-rapids/spark-rapids/sql-plugin/src/main/scala/com/nvidia/spark/rapids/MetaUtils.scala:235: value createUnintializedVector is not a member of com.google.flatbuffers.FlatBufferBuilder
Error:  /home/runner/work/spark-rapids/spark-rapids/sql-plugin/src/main/scala/com/nvidia/spark/rapids/MetaUtils.scala:252: type ByteBufferFactory is not a member of object com.google.flatbuffers.FlatBufferBuilder
Error:  /home/runner/work/spark-rapids/spark-rapids/sql-plugin/src/main/scala/com/nvidia/spark/rapids/MetaUtils.scala:303: value createUnintializedVector is not a member of com.google.flatbuffers.FlatBufferBuilder
Error:  /home/runner/work/spark-rapids/spark-rapids/sql-plugin/src/main/scala/com/nvidia/spark/rapids/MetaUtils.scala:319: overloaded method constructor FlatBufferBuilder with alternatives:
  (x$1: java.nio.ByteBuffer)com.google.flatbuffers.FlatBufferBuilder <and>
  ()com.google.flatbuffers.FlatBufferBuilder <and>
  (x$1: Int)com.google.flatbuffers.FlatBufferBuilder
 cannot be applied to (Int, com.nvidia.spark.rapids.DirectByteBufferFactory)
Error:  /home/runner/work/spark-rapids/spark-rapids/sql-plugin/src/main/scala/com/nvidia/spark/rapids/MetaUtils.scala:328: overloaded method constructor FlatBufferBuilder with alternatives:
  (x$1: java.nio.ByteBuffer)com.google.flatbuffers.FlatBufferBuilder <and>
  ()com.google.flatbuffers.FlatBufferBuilder <and>
  (x$1: Int)com.google.flatbuffers.FlatBufferBuilder
 cannot be applied to (Int, com.nvidia.spark.rapids.DirectByteBufferFactory)
Error:  /home/runner/work/spark-rapids/spark-rapids/sql-plugin/src/main/scala/com/nvidia/spark/rapids/MetaUtils.scala:342: overloaded method constructor FlatBufferBuilder with alternatives:
  (x$1: java.nio.ByteBuffer)com.google.flatbuffers.FlatBufferBuilder <and>
  ()com.google.flatbuffers.FlatBufferBuilder <and>
  (x$1: Int)com.google.flatbuffers.FlatBufferBuilder
 cannot be applied to (Int, com.nvidia.spark.rapids.DirectByteBufferFactory)
Error:  /home/runner/work/spark-rapids/spark-rapids/sql-plugin/src/main/scala/com/nvidia/spark/rapids/MetaUtils.scala:368: overloaded method constructor FlatBufferBuilder with alternatives:
  (x$1: java.nio.ByteBuffer)com.google.flatbuffers.FlatBufferBuilder <and>
  ()com.google.flatbuffers.FlatBufferBuilder <and>
  (x$1: Int)com.google.flatbuffers.FlatBufferBuilder
 cannot be applied to (Int, com.nvidia.spark.rapids.DirectByteBufferFactory)
Error:  /home/runner/work/spark-rapids/spark-rapids/sql-plugin/src/main/scala/com/nvidia/spark/rapids/MetaUtils.scala:322: local val finIndex in method buildMetaResponse is never used
Error:  /home/runner/work/spark-rapids/spark-rapids/sql-plugin/src/main/scala/com/nvidia/spark/rapids/MetaUtils.scala:337: local val finIndex in method buildShuffleMetadataRequest is never used
Error:  /home/runner/work/spark-rapids/spark-rapids/sql-plugin/src/main/scala/com/nvidia/spark/rapids/MetaUtils.scala:375: local val root in method buildBufferTransferResponse is never used
Error:  /home/runner/work/spark-rapids/spark-rapids/sql-plugin/src/main/scala/com/nvidia/spark/rapids/MetaUtils.scala:390: local val transferRequestOffset in method buildTransferRequest is never used
Error: [ERROR] 12 errors found

I cannot repro the cdh compilation issue with the latest upstream or locally.
I would guess that it was introduced by some plugin version updates in this change. I am not quite familiar with CDH build ENV cc @tgravescs to help check if any known issue.

Filed an issue for Cloudera folks to add support for their shims against JDK 17 here

build

Blossom build is dependent on https://github.com/NVIDIA/spark-rapids/issues/11113

Blossom build is dependent on https://github.com/NVIDIA/spark-rapids/issues/11113

The pre-merge CI change for the scala2.13 + JDK17 build/test has been done ： https://github.com/NVIDIA/spark-rapids/pull/11117

For the scala2.13 final dist jar's nightly build and IT, as discussed with @razajafri
- We will build Scala 2.13 dist jar for spark 330+ with jdk 17
- We should run Scala2.13 dist jar's integration tests with jdk 8 runtime
Also Peixin and I discussed, we may need more IT matrix against the dist jar like : Scala2.13 + [JDK8/JDK11/JDK17]
@gerashegalov  @jlowe  @revans2  @tgravescs  Please let me know if you have any concern, thanks!
cc @pxLi  @GaryShen2008  @sameerz

I could not reproduce CDH compile issue https://github.com/NVIDIA/spark-rapids/pull/10994#issuecomment-2198819837 with scala-maven-plugin 4.7.1. It compiled fine for me.
Moreover CDH cannot be built with the PR in the current shape using JDK17:
12:13:12,271 [INFO] Compiling 12 Scala sources and 2 Java sources to /home/gshegalov/gits/NVIDIA/spark-rapids.worktrees/spark400/sql-plugin-api/target/spark321cdh/classes ...
12:13:13,890 [WARNING] [Warn] : bootstrap class path not set in conjunction with -source 8
12:13:13,985 [ERROR] [Error] : warnings found and -Werror specified

Talking to @razajafri it turns out that the CDH failure comment https://github.com/NVIDIA/spark-rapids/pull/10994#issuecomment-2198819837 refers to the this very PR workflow failure https://github.com/NVIDIA/spark-rapids/actions/runs/9732795299/job/26860542937. I suspect that the reason is the change in this PR to make cache-dependencies a matrix job. Then these caches clobber each other somehow.

I can reproduce the issue locally with the command below,
openjdk version "1.8.0_292"
OpenJDK Runtime Environment (AdoptOpenJDK)(build 1.8.0_292-b10)
OpenJDK 64-Bit Server VM (AdoptOpenJDK)(build 25.292-b10, mixed mode)
Apache Maven 3.9.7 (8b094c9513efc1b9ce2d952b3b9c8eaedaf8cbf0)
Maven home: /opt/homebrew/Cellar/maven/3.9.7/libexec
Java version: 1.8.0_292, vendor: AdoptOpenJDK

mvn package -P321cdh -am -pl integration_tests,tests,tools -P 'individual,pre-merge' -Dbuildver=321cdh -Dmaven.scalastyle.skip=true -Drat.skip=true

@razajafri @gerashegalov can you share your repro command and ENV info?

I can reproduce the issue locally with the command below,
openjdk version "1.8.0_292"
OpenJDK Runtime Environment (AdoptOpenJDK)(build 1.8.0_292-b10)
OpenJDK 64-Bit Server VM (AdoptOpenJDK)(build 25.292-b10, mixed mode)
Apache Maven 3.9.7 (8b094c9513efc1b9ce2d952b3b9c8eaedaf8cbf0)
Maven home: /opt/homebrew/Cellar/maven/3.9.7/libexec
Java version: 1.8.0_292, vendor: AdoptOpenJDK

mvn package -am -pl integration_tests,tests,tools -P 'individual,pre-merge' -Dbuildver=321cdh -Dmaven.scalastyle.skip=true -Drat.skip=true
# also
mvn clean install -DskipTests -Dmaven.scaladoc.skip -Dbuildver=321cdh -pl aggregator -am

@razajafri @gerashegalov can you share your repro command and ENV info? Have you tried JDK8 which cdh shim should be built with? and which commit are you building against? I am building against merging this change (https://github.com/razajafri/spark-rapids/tree/SP-9259-POM-changes) into upstream branch-24.08, and simply revert hardcoded 430
UPDATE: ~I also tried JDK17, but it failed the same. can you try purging your local .m2? there might be some old transitive dependencies, but a fresh run could introduce new versions which caused the issue.~ use below commands for local reproduce
repro also within our nightly docker image (mvn 3.6.3 + JDK8)
docker run --rm -it urm.nvidia.com/sw-spark-docker-local/plugin:dev-ubuntu20-cuda11.0.3-blossom-dev bash

git clone -b test-pom-changes https://github.com/razajafri/spark-rapids.git
cd spark-rapids
mvn -version
mvn package -am -pl integration_tests,tests,tools -P 'individual,pre-merge' -Dbuildver=321cdh -Dmaven.scalastyle.skip=true -Drat.skip=true

I am able to repro on branch-24.08 with no other change but just upgrading the scala.maven.plugin version to 4.7.1. I can spend more time tomorrow on this

Upgrading scala-maven-plugin version to 4.9.1 which is what Spark is using now fixes the problem.

I believe the difference between our local env and GH Maven action is that it uses https://maven.apache.org/guides/mini/guide-using-toolchains.html
Thanks for the docker repro @pxLi. Interestingly, locally my result is the opposite of GH workflow. Passes for 4.7.1, fails for 4.9.1
~/gits/NVIDIA/spark-rapids$ git log -1 --oneline
45b0d57c78 (HEAD -> pr/razajafri/10994, razajafri1/SP-9259-POM-changes) Upgrading the scala.maven.plugin version to 4.9.1 which is the same as Spark 4.0.0

~/gits/NVIDIA/spark-rapids$ REPODIR=$PWD
~/gits/NVIDIA/spark-rapids$ docker run -u $(id -u):$(id -g) --rm -it \
  -v /etc/group:/etc/group:ro -v /etc/passwd:/etc/passwd:ro -v /etc/shadow:/etc/shadow:ro -v /etc/sudoers.d:/etc/sudoers.d:ro \
  -v $REPODIR:$REPODIR:rw  -v $HOME/.m2:$HOME/.m2:rw \
  --workdir $REPODIR urm.nvidia.com/sw-spark-docker-local/plugin:dev-ubuntu20-cuda11.0.3-blossom-dev \
  mvn package  -pl integration_tests,tests,tools -am  -Dbuildver=321cdh -DskipTests -Dmaven.scaladoc.skip \
  -Dscala.plugin.version=4.7.1
...

[ERROR] [Error] /home/gshegalov/gits/NVIDIA/spark-rapids/sql-plugin/src/main/scala/com/nvidia/spark/rapids/MetaUtils.scala:390: local val transferRequestOffset in method buildTransferRequest is never used
[ERROR] 12 errors found
...

I believe the difference between our local env and GH Maven action is that it uses https://maven.apache.org/guides/mini/guide-using-toolchains.html
Thanks for the docker repro @pxLi. Interestingly, locally my result is the opposite of GH workflow. Passes for 4.7.1, fails for 4.9.1
~/gits/NVIDIA/spark-rapids$ git log -1 --oneline
45b0d57c78 (HEAD -> pr/razajafri/10994, razajafri1/SP-9259-POM-changes) Upgrading the scala.maven.plugin version to 4.9.1 which is the same as Spark 4.0.0

~/gits/NVIDIA/spark-rapids$ REPODIR=$PWD
~/gits/NVIDIA/spark-rapids$ docker run -u $(id -u):$(id -g) --rm -it \
  -v /etc/group:/etc/group:ro -v /etc/passwd:/etc/passwd:ro -v /etc/shadow:/etc/shadow:ro -v /etc/sudoers.d:/etc/sudoers.d:ro \
  -v $REPODIR:$REPODIR:rw  -v $HOME/.m2:$HOME/.m2:rw \
  --workdir $REPODIR urm.nvidia.com/sw-spark-docker-local/plugin:dev-ubuntu20-cuda11.0.3-blossom-dev \
  mvn package  -pl integration_tests,tests,tools -am  -Dbuildver=321cdh -DskipTests -Dmaven.scaladoc.skip \
  -Dscala.plugin.version=4.7.1
...

[ERROR] [Error] /home/gshegalov/gits/NVIDIA/spark-rapids/sql-plugin/src/main/scala/com/nvidia/spark/rapids/MetaUtils.scala:390: local val transferRequestOffset in method buildTransferRequest is never used
[ERROR] 12 errors found
...

In light of what you are seeing and our conversation, we should restrict cdh to 4.3.0 + jdk8 build.

build

build

The PR11144 based on this PR for the nightly build + IT CIs of Scala2.13 + JDK17, Scala2.13+JDK17 build got PASS,  IT with the new built jar on JDK8/11/17 Java runtime got PASS

build

build

build


Different way of solving quadratic equations

https://www.poshenloh.com/quadraticdetail/
Maybe this can be used for the quad stuff in fontTools/misc/bezierTools.py?

That's not a different way of solving quadratic equation. Just a different way to explain them. I'm not sure different from what though...
At any rate, our code does the same:
https://github.com/fonttools/fonttools/blob/f64f0b42f2d1163b2d85194e0979def539f5dca3/Lib/fontTools/misc/bezierTools.py#L621-L651
which is expected, since there's only one way to solve a quadratic equation.

Damn! I was hoping this could be exploited to simplify the calculation somehow. Oh well.


[config:generate] Make the installed PHP version configurable

With the Drupal VM 3.0.0 release, the default value of php_version changed to 7.0.
The other supported versions are 5.5 and 5.6.
These options should be presented to the user during the interaction stage to allow them to easily change the PHP version.

Re-opening. The commit has been reverted, as there are more variables that need to be added to get a different version of PHP installed. See http://docs.drupalvm.com/en/latest/other/php-56/.

This could be achieved once custom variables are added in #13, as well project level defaults in #43 as the package names will be different per guest OS/project.

Following https://github.com/geerlingguy/drupal-vm/pull/714, as this would be better if it was handled upstream.

This is now configurable within config.yml (see https://github.com/geerlingguy/drupal-vm/blob/master/default.config.yml#L239-L241), so will be fixed within #44.


Filter alt eh

@katiehealy I added some filter functions that I think have almost identical functionality to what is already in the package, but are much faster/simpler to run. Would be interested to hear what you think.

Thanks for the review! I think I caught the issue with characteristicName and I like the match.arg suggestion, so I added that too.


Fix checklists

Hi there, thanks for the nice project!
Just a quick PR to fix the checklists.

Nice catch, thanks very much 👍

No worries!


[oneDNN] Add 3D support to layout optimizer

This PR modifies Layout Optimizer by

adding 3D support for some op transposers
adding a transposer for MaxPool3D op
adding a layout optimizer transposer test for Conv3D

Hi @ezhulenev Can you please review this PR ? Thank you!

Hi @ezhulenev Can you please review this PR ? Thank you!

Hi @ezhulenev Can you please review this PR ? Thank you!

Hi @ezhulenev Can you please review this PR ? Thank you!

Hi @ezhulenev Can you please review this PR ? Thank you!

@kanvi-nervana Could you please help fix the build failure? Example error from Py+CPP Ubuntu CPU test:
tensorflow/core/grappler/optimizers/generic_layout_optimizer_transposer.cc:1035:20: error: no member named 'OK' in 'absl::Status'
    return Status::OK();
           ~~~~~~~~^
tensorflow/core/grappler/optimizers/generic_layout_optimizer_transposer.cc:1476:20: error: no member named 'OK' in 'absl::Status'
    return Status::OK();
           ~~~~~~~~^
tensorflow/core/grappler/optimizers/generic_layout_optimizer_transposer.cc:1729:22: error: no member named 'OK' in 'absl::Status'
      return Status::OK();
             ~~~~~~~~^
tensorflow/core/grappler/optimizers/generic_layout_optimizer_transposer.cc:1754:22: error: no member named 'OK' in 'absl::Status'
      return Status::OK();
             ~~~~~~~~^
tensorflow/core/grappler/optimizers/generic_layout_optimizer_transposer.cc:1935:20: error: no member named 'OK' in 'absl::Status'
    return Status::OK();
           ~~~~~~~~^
tensorflow/core/grappler/optimizers/generic_layout_optimizer_transposer.cc:1963:20: error: no member named 'OK' in 'absl::Status'
    return Status::OK();
           ~~~~~~~~^
tensorflow/core/grappler/optimizers/generic_layout_optimizer_transposer.cc:1981:20: error: no member named 'OK' in 'absl::Status'
    return Status::OK();
           ~~~~~~~~^
7 errors generated.

@kanvi-nervana Could you please help fix the build failure? Example error from Py+CPP Ubuntu CPU test:
tensorflow/core/grappler/optimizers/generic_layout_optimizer_transposer.cc:1035:20: error: no member named 'OK' in 'absl::Status'
    return Status::OK();
           ~~~~~~~~^
tensorflow/core/grappler/optimizers/generic_layout_optimizer_transposer.cc:1476:20: error: no member named 'OK' in 'absl::Status'
    return Status::OK();
           ~~~~~~~~^
tensorflow/core/grappler/optimizers/generic_layout_optimizer_transposer.cc:1729:22: error: no member named 'OK' in 'absl::Status'
      return Status::OK();
             ~~~~~~~~^
tensorflow/core/grappler/optimizers/generic_layout_optimizer_transposer.cc:1754:22: error: no member named 'OK' in 'absl::Status'
      return Status::OK();
             ~~~~~~~~^
tensorflow/core/grappler/optimizers/generic_layout_optimizer_transposer.cc:1935:20: error: no member named 'OK' in 'absl::Status'
    return Status::OK();
           ~~~~~~~~^
tensorflow/core/grappler/optimizers/generic_layout_optimizer_transposer.cc:1963:20: error: no member named 'OK' in 'absl::Status'
    return Status::OK();
           ~~~~~~~~^
tensorflow/core/grappler/optimizers/generic_layout_optimizer_transposer.cc:1981:20: error: no member named 'OK' in 'absl::Status'
    return Status::OK();
           ~~~~~~~~^
7 errors generated.

@penpornk I pushed a commit to fix the build issue, can you please review? Thanks!!

Hi @penpornk Can you please review this PR ? Thank you!


fix gallery caption image path mismatch in a widget_page

Purpose
In a widget_page, the gallery doesn't show image captions because of image path mismatch.
Parent dir of the gallery is prepended to locate images if in a widget_page, while during finding captions, parent dir is not added, which causes captions not displayed.

Thanks for reporting this bug :)


Sum of reads breakdown not equal to total reads

I checked the output log file for find_instersecting_snps. But when I noticed that the sum of indels, excess overlapping SNPs, keep, remap, and excess allelic combinations is larger than the total number of reads in the bam file. Any ideas why this happen?

I think I kind of figured it out. For keep, remap, and excess overlapping snps, the script adds one. For indels and excess allelic combinations, the script adds two. Also, for filter_reampped_reads the script outputs the number of reads instead of read pairs.  It would be better if it can be consistent.


feat(TextBox): add OnKeyUp & onKeyDown

Summary
Forward onKeyUp & onKeyDown on TextBox
wait for https://github.com/scaleway/scaleway-ui/pull/1836
Type

Feature

Summarise concisely:

Codecov Report

Merging #480 (d54a74d) into main (8654541) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #480   +/-   ##
=======================================
  Coverage   92.20%   92.20%
=======================================
  Files          26       26
  Lines         295      295
  Branches       35       35
=======================================
  Hits          272      272
  Misses         14       14
  Partials        9        9

Impacted Files
Coverage Δ

src/components/TextBoxField/index.tsx
100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2fde886...d54a74d. Read the comment docs.


Installing tm1py in enterprise environment

Hi,
I am trying to install tm1py in enterprise environment (private cloud with no internet connection)
We have python3.9 on the machine and use tm1py-1.6.2.tar.gz package with pip install.
We get the following errors on running: python3.9 -m pip install ./tm1py-1.6.2.tar.gz
WARNING: Retrying (Retry(total=4, connect=None, read=None, redirect=None, status=None)) after connection broken by 'NewConnectionError('<pip._vendor.urllib3.connection.HTTPSConnection object at 0x7f56b0aaf340>: Failed to establish a new connection: [Errno -2] Name or service not known')': /simple/requests/
WARNING: Retrying (Retry(total=3, connect=None, read=None, redirect=None, status=None)) after connection broken by 'NewConnectionError('<pip._vendor.urllib3.connection.HTTPSConnection object at 0x7f56b0aaff40>: Failed to establish a new connection: [Errno -2] Name or service not known')': /simple/requests/
WARNING: Retrying (Retry(total=2, connect=None, read=None, redirect=None, status=None)) after connection broken by 'NewConnectionError('<pip._vendor.urllib3.connection.HTTPSConnection object at 0x7f56b0a47130>: Failed to establish a new connection: [Errno -2] Name or service not known')': /simple/requests/
WARNING: Retrying (Retry(total=1, connect=None, read=None, redirect=None, status=None)) after connection broken by 'NewConnectionError('<pip._vendor.urllib3.connection.HTTPSConnection object at 0x7f56b0aaf970>: Failed to establish a new connection: [Errno -2] Name or service not known')': /simple/requests/
WARNING: Retrying (Retry(total=0, connect=None, read=None, redirect=None, status=None)) after connection broken by 'NewConnectionError('<pip._vendor.urllib3.connection.HTTPSConnection object at 0x7f56b0aa4760>: Failed to establish a new connection: [Errno -2] Name or service not known')': /simple/requests/
ERROR: Could not find a version that satisfies the requirement requests (from tm1py) (from versions: none)
ERROR: No matching distribution found for requests
It seems to me that it tries to connect to the internet and download some missing python packages but i can't identify what is actualy missing.
Regards,
Edi

Moved question to proper repo: https://github.com/cubewise-code/tm1py/issues/542


language-specific setting for format on save

VSCode Version: 1.6.0
OS Version: Ubuntu 14.04.5 LTS

Steps to Reproduce:

Turn on "format on save":
Edit json file
Save the file

  "editor.formatOnSave": true,

I'd like to use "format on save" for source code in my main language, but not for JSON or any other language. So it seems like this setting should be language-specific? Instead of a boolean, perhaps have a list of languages (or perhaps file extensions) for which format on save should be turned on?

Related to #1587, which tracks support for general language specific settings.