[jade] Jade/Pug #id syntax highlighting

VSCode Version: 1.3.0
OS Version:  CentOS Linux release 7.1.1503 (Core)

Jade/pug allows to write #Id along with .class
As seen in the image, sizing-addon1 dosen't have any syntax color( expected blue, the same as .class )

Fixed in the January build.
#id is now the same color as the .class.

Note: .class, #id and data-bind get all the same scope from the Pug text mate grammar. Please file issues there.


TensorFlow 2.2 and 2.3 not detecting the Titan XP GPU

System information

OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Ubuntu 18.04 LTS

TensorFlow installed from (source or binary): Binary in Virtual environment as per https://www.tensorflow.org/install/pip and https://www.tensorflow.org/install/gpu

TensorFlow version: 2.2 and 2.3 in two virtual environments

Python version:  Tried both 3.6 and 3.8 in virtual environments

Installed using virtualenv? pip? conda?: PIP

CUDA:
nvcc: NVIDIA (R) Cuda compiler driver Copyright (c) 2005-2019 NVIDIA Corporation Built on Sun_Jul_28_19:07:16_PDT_2019 Cuda compilation tools, release 10.1, V10.1.243

-cuDNN version:
`#define CUDNN_MAJOR 7
#define CUDNN_MINOR 6
#define CUDNN_PATCHLEVEL 5
#define CUDNN_VERSION (CUDNN_MAJOR * 1000 + CUDNN_MINOR * 100 + CUDNN_PATCHLEVEL)
`

GPU model and memory: Titan XP (Details from nvidia-smi, shared below)
Wed Oct 28 13:05:46 2020        +-----------------------------------------------------------------------------+ | NVIDIA-SMI 450.80.02    Driver Version: 450.80.02    CUDA Version: 11.0     | |-------------------------------+----------------------+----------------------+ | GPU  Name        Persistence-M| Bus-Id        Disp.A | Volatile Uncorr. ECC | | Fan  Temp  Perf  Pwr:Usage/Cap|         Memory-Usage | GPU-Util  Compute M. | |                               |                      |               MIG M. | |===============================+======================+======================| |   0  TITAN Xp            Off  | 00000000:01:00.0  On |                  N/A | | 23%   31C    P5    17W / 250W |    371MiB / 12192MiB |      0%      Default | |                               |                      |                  N/A

Describe the problem
TensorFlow 2.2 and 2.3 not detecting the Titan XP GPU
Provide the exact sequence of commands / steps that you executed before running into the problem
Created virtual environments using : python3.8 -m venv --system-site-packages ./TF_2 (same step for python 3.6)
Sourced: source TF_2/bin/activate
Code and outputs from terminal with python:
`>>> import tensorflow as tf
2020-10-28 12:56:39.039879: I tensorflow/stream_executor/platform/default/dso_loader.cc:48] Successfully opened dynamic library libcudart.so.10.1

tf.config.list_physical_devices('GPU')
2020-10-28 12:56:45.248971: I tensorflow/stream_executor/platform/default/dso_loader.cc:48] Successfully opened dynamic library libcuda.so.1
2020-10-28 12:56:45.282612: I tensorflow/stream_executor/cuda/cuda_gpu_executor.cc:982] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero
2020-10-28 12:56:45.283010: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1716] Found device 0 with properties:
pciBusID: 0000:01:00.0 name: TITAN Xp computeCapability: 6.1
coreClock: 1.582GHz coreCount: 30 deviceMemorySize: 11.91GiB deviceMemoryBandwidth: 510.07GiB/s
2020-10-28 12:56:45.283029: I tensorflow/stream_executor/platform/default/dso_loader.cc:48] Successfully opened dynamic library libcudart.so.10.1
2020-10-28 12:56:45.283144: W tensorflow/stream_executor/platform/default/dso_loader.cc:59] Could not load dynamic library 'libcublas.so.10'; dlerror: libcublas.so.10: cannot open shared object file: No such file or directory; LD_LIBRARY_PATH: /usr/local/cuda-10.1/lib64
2020-10-28 12:56:45.284267: I tensorflow/stream_executor/platform/default/dso_loader.cc:48] Successfully opened dynamic library libcufft.so.10
2020-10-28 12:56:45.284454: I tensorflow/stream_executor/platform/default/dso_loader.cc:48] Successfully opened dynamic library libcurand.so.10
2020-10-28 12:56:45.285753: I tensorflow/stream_executor/platform/default/dso_loader.cc:48] Successfully opened dynamic library libcusolver.so.10
2020-10-28 12:56:45.286488: I tensorflow/stream_executor/platform/default/dso_loader.cc:48] Successfully opened dynamic library libcusparse.so.10
2020-10-28 12:56:45.289239: I tensorflow/stream_executor/platform/default/dso_loader.cc:48] Successfully opened dynamic library libcudnn.so.7
2020-10-28 12:56:45.289253: W tensorflow/core/common_runtime/gpu/gpu_device.cc:1753] Cannot dlopen some GPU libraries. Please make sure the missing libraries mentioned above are installed properly if you would like to use GPU. Follow the guide at https://www.tensorflow.org/install/gpu for how to download and setup the required libraries for your platform.
Skipping registering GPU devices...
[]
`

Any other info / logs
Note the path was set in the ~/.bashrc
export PATH=/usr/local/cuda-10.1/bin${PATH:+:${PATH}} export LD_LIBRARY_PATH=/usr/local/cuda-10.1/lib64${LD_LIBRARY_PATH:+:${LD_LIBRARY_PATH}} export PATH=~/Downloads/protobuf${PATH:+:${PATH}}

@RRK13,
Please make sure you have executed all the commands as per the installation guide.
Also, please take a look at this StackOverflow comment from a similar issue and let us know if it helps. Thanks!


[FLINK-26092][table-runtime] Fix JSON_OBJECTAGG when emitting NULL

What is the purpose of the change
Previously, when the Json aggregation is taking place, and id
JsonOnNull.NULL is selected, which means that we still want to emit
a null JSON node, .i.e {.... "myField" : null ... } when no values
get accumulated, we used a null StringData object. When
state.backend.changelog.enabled is enabled, the contents of the map
accumulating the aggregated records, gets serialized leading to NPE,
since null is not supported by StringDataSerilizer.
To solve this, we instead create a StringData with an empty byte[],
which denotes the null, and when the aggregation ends and we create
the final JSON result, we check for a byte[] of length 0 in
order to write the JSON null node.
Verifying this change
This change added tests and can be verified as follows:

Change the parent class: BuiltInAggregateFunctionTestBase of JsonAggregationFunctionsITCase to run the whole set of tests with state.backend both hashmap and rocksdb.

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): no
The public API, i.e., is any changed class annotated with @Public(Evolving): no
The serializers: no
The runtime per-record code paths (performance sensitive): no
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
The S3 file system connector: no

Documentation

Does this pull request introduce a new feature? no
If yes, how is the feature documented? not applicable

@flinkbot run azure

The test failure is likely unrelated:
Mar 29 18:37:08 [ERROR] pure virtual method called
Mar 29 18:37:08 [ERROR] terminate called without an active exception
Mar 29 18:37:12 [ERROR] Aborted (core dumped)

The private branch passed the tests. Merging.


For discussion: change newsletter publication date to Friday

Current
Proposed
Activity

SOD Fri UTC-10
EOD Sun UTC-10
Cut-off for additional news stories and merges (exception: security stuff)

EOD Sun UTC-10
EOD Tue UTC-10
Open PR

EOD Tue UTC-10
EOD Thu UTC-10
deadline for reviews, additional content, and edits

~Noon Wed UTC
~Noon Fri UTC
Publication

~14:30 Thu UTC
TBD
Podcast

(EOD = End of Day; SOD = Start Of Day)
Main motivation: under the current schedule, I tend to put off writing
the newsletter until the weekend.  That worked fine when I was single
and weekends felt mostly like any other day to my work-at-home self.
Now I have a partner with a regular Mon-Fri job, so I want my weekends
free to spend with her.
Other advantages of this approach:

At present, the podcast day conflicts with the #bitcoin-core-dev weekly
meeting.  If we start publishing on Friday, the podcast will probably
not be on Thursday any more.

Disadvantages:

Change is annoying.

Friday is supposed to be one of the worst times to publish things as
some readers are already mentally checked out for the weekend.
However, the podcast could be Monday morning U.S. Eastern Time, which
might be a boost for it and could help bring attention back to the
newsletter topics.

Please discuss!

From a news perspective, publishing things on friday is a good way to have them missed, isn't it? People are busy thinking about the weekend, leave early, or are in timezones where it's already the weekend. If you have a persistent reminder like an rss feed, that's fine; but if the newsletter scrolled past on twitter, you might just miss out.
Not sure what "EOD UTC-10" is exactly; I'm going to guess 6pm, so ~0400 UTC the next day, and SOD as 10h earlier. Skipping out the versions where publication would end up on a weekend:

cutoff
open pr
comment deadline
publish
podcast
writing days
comment days

Fri 1800
Mon 0400
Wed 0400
Wed 1200
Thu 1430
Fri, Sat, Sun
Mon, Tue

Sat 1800
Tue 0400
Thu 0400
Thu 1200
Fri 1430 ?
Sat, Sun, Mon
Tue, Wed

Sun 1800
Wed 0400
Fri 0400
Fri 1200
Mon 1430 ?
Sun, Mon, Tue
Wed, Thu

Wed 1800
Fri 0400
Mon 0400
Mon 1200
Tue 1430
Wed, Thu, Fri
Sat, Sun

Thu 1800
Sat 0400
Tue 0400
Tue 1200
Wed 1430
Thu, Fri, Sat
Sun, Mon

I'd probably go for "publish on monday" out of these, with a bit of extra time for comments, perhaps something like:

Cutoff for news: Tue 1800 UTC (SOD Tue UTC-10)
Open PR: Thu 2200 UTC (Noon Thu UTC-10)
Podcast invites: Fri 1200 UTC ?
Comment deadline: Mon 0400 UTC
Publish: Mon 1200 UTC
Podcast: Tue 1430 UTC

If that's not enough time for review/comments, push back to Tue publish/Wed podcast?

@ajtowns's "publish on Monday" schedule works for me, but it does seem to imply everyone else will have to work on Friday or the weekend.

everyone else will have to work on Friday or the weekend

I don't mind at all.

I'm also fine with reviewing on weekends.

I’m in a similar situation as @harding and I generally try to avoid looking at work stuff on the weekend. I would probably not review the newsletter at all, if the review days were only on the weekend. On the other hand, I have already been contributing less to review recently due to other additional commitments I took on, so maybe my time-preference does not matter that much for the review days.
I would generally prefer if the Recap didn’t fall on Thursday, since we usually schedule NYC BitDevs on Thursdays, and therefore tend to have office guests more often on Thursdays.

Sounds like a useful experiment to run. FWIW I think readership matters, but I would prioritize sustainability above all other considerations. Given this newsletter's bus factor, I would support whatever Dave thinks is the best schedule for him.

"Friday noonish UTC" is Friday 10pm here, meaning it'll probably sit in my RSS feed until Monday anyway, so at least personally, it's the same thing :) If it were me, I'd still change "Publish Friday noonish" to "Publish Monday noonish" (keeping the other times the same) though. Moving the recap to the start of the week would be already a good win here too.

I'd still change "Publish Friday noonish" to "Publish Monday noonish" (keeping the other times the same)

It feels like a disservice to our audience to have a completed newsletter, which might include timely information like security announcements, and to sit on it for a few days because we want more views from our least dedicated readers.
I think we should run the experiment to see whether there's a major difference between Friday and Monday (which, alas, does mean that we'll be delaying news for some of our readers on at least one occasion, making my previous argument a hypocritical).  If there's not a major difference, I think we should choose the schedule that's most convenient for us.  If there is a major difference, then we should discuss it further.

It feels like a disservice to our audience to have a completed newsletter, which might include timely information like security announcements, and to sit on it for a few days because we want more views from our least dedicated readers.

If a vulnerability gets released the day after a newsletter is published, it'll still be a week before it's covered in the newsletter no matter what day it's published. Doesn't make sense to me to worry about a few days delay any which way for optech newsletters. (Likewise for if you spend a week or two reviewing a post before doing the optech write up; it's less timely, but the higher quality of the write up is much more valuable) If you want really timely updates, you should go to the source, not the weekly newsletter?
(Which is just to say (IMHO) that you shouldn't feel bad about it; not that you shouldn't release on friday if that makes you feel good!)

I think someone brought this up before, but if the newsletter is published on Friday, doing the recap on Monday would also draw additional attention to it. I would suspect that a lot of people track the newsletter via email or RSS, so it would land in their inbox either way. I support running the experiment, but my gut feeling is that Friday should work out fine.

ACK on publishing on Friday.
In order to AB test the email list send times, Monday vs Friday, we would need to be collecting some tracking information (opens at least) from our email provider, Mailchimp.
I've manually been turning off that tracking for each individual weekly newsletter as Mailchimp doesnt have a global setting to turn it off. Due to the manual nature, Ive missed turning that off for some newsletters, but for this experiment, we would be deliberately leaving that collecting on.
If we opt to collect email open rate information to facilitate this experiment, Id suggest we make a note of that on our disclaimer(s), perhaps: https://deploy-preview-1655--bitcoinops.netlify.app/en/newsletters/2024/05/15/#newsletter-publication-date-changes
Or if we think it would be helpful to have something broader on privacy policy, we can consider adding a page/text to the site.

The first Friday publication went out today. I executed all of the same publishing steps (social media, etc) as normal with the exception of the email blast being a multivariate test this time.
For this first week, I split delivery days 25% each to Friday/Saturday/Sunday/Monday. All (to be) sent at 630a ET. Both open and click tracking are enabled.

Week 1

Segment
Open Rate
Click Rate

Fri, May 17, 2024 6:30 AM  ET
36.1%
2.8%

Sat, May 18, 2024 6:30 AM  ET
38.4%
2.1%

Sun, May 19, 2024 6:30 AM  ET
36.8%
2.3%

Mon, May 20, 2024 6:30 AM  ET
34.3%
2.2%

@bitschmidty thanks!
Given that we also announced via Twitter and RSS on Friday, I suspect there's some confounding in those numbers, but if we simply take them at face value, I think they support publishing on whatever day is most convenient to us.
Friday continues to work for me, but I think Saturday morning publication might have the benefit of giving us a little extra time for reviews and additions.  Does anyone want to advocate either way?
Does anyone want further testing or to continue with the idea of trusting conventional wisdom about publishing on Monday?  ping @ajtowns
This week's newsletter (see #1685) should be ready to go Friday (or Saturday), so I suggest we publish then unless a further test is suggested.

I support publishing on whatever day is most convenient for you :) I'd be a bit skeptical of drawing any conclusions from a single sample, particularly for a newsletter that was published only a couple of days after the previous newsletter, but if you're happy with friday/saturday I don't think you really need additional data to justify doing whatever feels best...

I ran the 4 day email send time segmentation again this week. Though this time for 830a ET time slots. Stay tuned.

Week 2

Segment
Open Rate
Click Rate

Fri, May 24, 2024 8:30 AM  ET
35.5%
2.1%

Sat, May 25, 2024 8:30 AM  ET
36.9%
2.5%

Sun, May 26, 2024 8:30 AM  ET
37.7%
1.9%

Mon, May 27, 2024 8:30 AM  ET
36.5%
2.3%

Open rate margin of error: +/- 1.7%
Click rate margin of error: +/- 0.7%

I did not segment the email newsletter send times this week. I suspect data would be similar and dont see indications that deviating from sending Friday would garner audience benefits. Unless someone objects, I recommend we continue with Friday 1200 UTC publishing to everyone and Tuesday 1430 UTC for the Twitter Spaces Recap.

I recommend we continue with Friday 1200 UTC publishing to everyone and Tuesday 1430 UTC for the Twitter Spaces Recap.

Agreed.  Closing this issue, but continued discussion is welcome.  Thanks @bitschmidty for testing and everyone for you input!


lit-node-client-nodejs/Readme: Fix forgotten to change import alias.

Thanks for pointing this out!


[Bug]: Tray Icons too small when using the new tray module.

Checklist

[X] I have read the appropriate section in the contributing guidelines
[X] I believe this issue is a problem with polybar itself and not a misconfiguration on my part
[X] I have searched for other open and closed issues that may have already reported this problem
[X] I have checked the known issues page for this problem.
[X] I have followed the debugging guide to narrow down the problem to a minimal config.

Steps to reproduce
I'm trying to migrate my config to use the tray module, this is what I get now: https://imgur.com/D0SYaDA.png
This is how it used to look with ''tray-position = right'': https://imgur.com/uJ0hMxM.png
Minimal config
[bar/example]
modules-right = pulseaudio xkeyboard eth DATE tray

[module/tray]
type = internal/tray
format = <tray>

Polybar log
No response
Expected behavior
The tray should look like it did before.
Actual behavior
The tray icons are too small and misplaced.
Window Manager and Version
i3wm v4.23
Linux Distribution
Archlinux
Polybar version
Polybar 3.7.0

Additional Context / Screenshots
No response

The tray should look like it did before.

We don't guarantee this.
The icon size calculations have changed in the tray module, icons are now 66% of the bar height. I found that to go well together with the other defaults.
You can control the size of the icons using tray-size


Failing build because of yield keyword

I have errors like these when building with babel-preset-babili:
ERROR in ./src/redux/sagas/landing-menu.js
Module build failed: SyntaxError: The keyword 'yield' is reserved (1:2367)
    at Parser.pp.raise (PROJECT_FOLDER/node_modules/acorn/dist/acorn.js:1745:13)
    at Parser.pp.parseIdent (PROJECT_FOLDER/node_modules/acorn/dist/acorn.js:1464:240)
    at Parser.pp.parseExprAtom (PROJECT_FOLDER/node_modules/acorn/dist/acorn.js:1090:21)
    at Parser.pp.parseExprSubscripts (PROJECT_FOLDER/node_modules/acorn/dist/acorn.js:1023:19)
    at Parser.pp.parseMaybeUnary (PROJECT_FOLDER/node_modules/acorn/dist/acorn.js:1004:19)
    at Parser.pp.parseExprOps (PROJECT_FOLDER/node_modules/acorn/dist/acorn.js:948:19)
    at Parser.pp.parseMaybeConditional (PROJECT_FOLDER/node_modules/acorn/dist/acorn.js:930:19)
    at Parser.pp.parseMaybeAssign (PROJECT_FOLDER/node_modules/acorn/dist/acorn.js:908:19)
    at Parser.pp.parseVar (PROJECT_FOLDER/node_modules/acorn/dist/acorn.js:2743:24)
    at Parser.pp.parseVarStatement (PROJECT_FOLDER/node_modules/acorn/dist/acorn.js:2637:8)
    at Parser.pp.parseStatement (PROJECT_FOLDER/node_modules/acorn/dist/acorn.js:2437:19)
    at Parser.pp.parseBlock (PROJECT_FOLDER/node_modules/acorn/dist/acorn.js:2692:21)
    at Parser.pp.parseFunctionBody (PROJECT_FOLDER/node_modules/acorn/dist/acorn.js:1413:22)
    at Parser.pp.parseFunction (PROJECT_FOLDER/node_modules/acorn/dist/acorn.js:2770:8)
    at Parser.pp.parseFunctionStatement (PROJECT_FOLDER/node_modules/acorn/dist/acorn.js:2540:15)
    at Parser.pp.parseStatement (PROJECT_FOLDER/node_modules/acorn/dist/acorn.js:2420:19)
 @ ./src/redux/sagas/index.js 1:285-310

My .babelrc:
{
  "presets": [ "es2015", "stage-1", "react" ],
  "plugins": [
    "transform-runtime",
    "transform-decorators-legacy"
  ],
  "env": {
    "production": {
      "presets": ["babili"],
      "plugins": [
        "transform-react-inline-elements",
        "transform-react-constant-elements"
      ]
    }
  }
}

Please let me know if there any missing info I should provide

The error is coming from node_modules/acorn/dist/acorn.js so webpack?
Can you provide a small repro code snippet? But maybe it's just not transpiling yield.

I think I found the problematic part:
// this code snippet causes an error mentioned above
const { language, platform } = yield select(getPageParams);

// with this code snippet everything transpiles smoothly
const params = yield select(getPageParams);

I can probably create a repo where this error can be reproduced. Let me know if you need that

Yeah that would be good if you can

Sure thing: https://github.com/mistadikay/babili-yield-bug
Just run npm run build and you will see the error

Updated the repo with webpack CLI option. If you run npm run webpack, build is working. Could it be https://github.com/start-runner/simple-cli messing up something?

Nope, it's not start-runner. Removed it and build is still failing. Please see updated repo.
p.s.: sorry for the noise, just trying to help as much as I can 😕

I just tried different combinations, and removing the plugin babel-plugin-transform-merge-sibling-variables from the babili preset makes the example work.

Oh interesting.
function* onPageSave({ payload }) {
    const { language, platform } = yield select(getPageParams);
}

"use strict";

var _marked = [onPageSave].map(regeneratorRuntime.mark);

function onPageSave(_ref) {
    var a = _ref.payload,
        _ref2 = yield select(getPageParams),
        b = _ref2.language,
        c = _ref2.platform;

    return regeneratorRuntime.wrap(function onPageSave$(_context) {
        for (; 1;) switch (_context.prev = _context.next) {
            case 0:
            case "end":
                return _context.stop();
        }
    }, _marked[0], this);
}

add "minified: false" in the .babelrc to get whitespace back. It looks like it's combining the variables like @danez mentioned and yield isn't transformed

This works with "passPerPreset": true - forgot what we decided to do (add it to minify preset?)

I ran into the same issue and realized I posted a duplicate.
I left what info I could find in https://github.com/babel/babili/issues/149.

Any update on this? Since options are not released yet?

We just need to release an update ASAP, since passPerPreset = false is really too troublesome.

passPerPreset is by default enabled in babili.


Accessibility - Left menu is after main content

There is an accessibility issue with left menu (GoCWebTemplate.Application.LeftMenu_Layout.cshtml)
v4_0_32 and v4_0_45
"Issue: In the HTML code, the order of content is not in the same order as visually presented, which prevents a meaningful sequence experience for some users. In the code, the left side menu comes after the main content, which means that people relying on screen readers to get by or people unable to use a mouse can't get to this menu until they have tabbed through the whole page at the end.
How to fix: Make sure that in the HTML source code the left side menu comes before the page's main content."
https://esdc.prv/cgi-bin/scdtic-ictdcs/page-error-view.aspx?id=143&wid=0
Also when the screen size is small, the left menu shows up visually at the bottom after the main content (which might be ok, it wasn't mentioned)

Hello, thank you for creating this issue. The left menu layout will be fixed in the .net templates repo.
I created the issue: https://github.com/wet-boew/cdts-DotNetTemplates/issues/42


Release text change

For upgrading - the release text mentions:

Open your old HiddenWallet folder, copy your Config.cs

It should be Config.json

Thanks, I fixed it.


prometheus-k8s-0 keeps terminating

prometheus+:: {
  prometheus+: {
    spec+: {
      retention: '30d',
      storage: {
        volumeClaimTemplate:
          pvc.new() +
          pvc.mixin.spec.withAccessModes('ReadWriteOnce') +
          pvc.mixin.spec.resources.withRequests({ storage: '100Gi' }) +
          pvc.mixin.spec.withStorageClassName('prometheus-nfs'),
          pvc.mixin.spec.selector.withMatchLabels({ name: 'prometheus-nfs', }),
      },  // storage
    },  // spec
  },  // prometheus

apiVersion: storage.k8s.io/v1
kind: StorageClass
metadata:
name: prometheus-nfs
provisioner: kubernetes.io/no-provisioner
volumeBindingMode: WaitForFirstConsumer
apiVersion: v1
kind: PersistentVolume
metadata:
name: prometheus-k8s-db-prometheus-k8s-0
labels:
name: prometheus-k8s-0
spec:
capacity:
storage: 100Gi
accessModes:
- ReadWriteOnce
nfs:
path: /cube_prometheus02
server: <IP_ADDRESS>
persistentVolumeReclaimPolicy: Retain
storageClassName: prometheus-nfs
apiVersion: v1
kind: PersistentVolumeClaim
metadata:
labels:
app: prometheus
prometheus: prometheus-k8s
name: prometheus-k8s-db-prometheus-k8s-0
namespace: monitoring
spec:
accessModes:

ReadWriteOnce
resources:
requests:
storage: 100Gi
volumeName: prometheus-k8s-db-prometheus-k8s-0
storageClassName: prometheus-nfs
selector:
matchLabels:
name: prometheus-k8s-0

I had above config working for several weeks and now after Kube update from 16.3 to 17.0 prometheus did not install or start anymore and keeps in 'terminating' loop. If I comment above pvc out, prometheus install and run normally.
$ kubectl -n monitoring describe deployment prometheus-operator
Name:                   prometheus-operator
Namespace:              monitoring
CreationTimestamp:      Fri, 10 Jan 2020 12:54:00 +0200
Labels:                 app.kubernetes.io/component=controller
app.kubernetes.io/name=prometheus-operator
app.kubernetes.io/version=v0.34.0
Annotations:            deployment.kubernetes.io/revision: 1
Selector:               app.kubernetes.io/component=controller,app.kubernetes.io/name=prometheus-operator
Replicas:               1 desired | 1 updated | 1 total | 1 available | 0 unavailable
StrategyType:           RollingUpdate
MinReadySeconds:        0
RollingUpdateStrategy:  25% max unavailable, 25% max surge
Pod Template:
Labels:           app.kubernetes.io/component=controller
app.kubernetes.io/name=prometheus-operator
app.kubernetes.io/version=v0.34.0
Service Account:  prometheus-operator
Containers:
prometheus-operator:
Image:      quay.io/coreos/prometheus-operator:v0.34.0
Port:       8080/TCP
Host Port:  0/TCP
Args:
--kubelet-service=kube-system/kubelet
--logtostderr=true
--config-reloader-image=quay.io/coreos/configmap-reload:v0.0.1
--prometheus-config-reloader=quay.io/coreos/prometheus-config-reloader:v0.34.0
Limits:
cpu:     200m
memory:  200Mi
Requests:
cpu:        100m
memory:     100Mi
Environment:
Mounts:
Volumes:
Conditions:
Type           Status  Reason

Available      True    MinimumReplicasAvailable
Progressing    True    NewReplicaSetAvailable
OldReplicaSets:
NewReplicaSet:   prometheus-operator-99dccdc56 (1/1 replicas created)
Events:
Type    Reason             Age   From                   Message

Normal  ScalingReplicaSet  19m   deployment-controller  Scaled up replica set prometheus-operator-99dccdc56 to 1
$ kubectl version
Client Version: version.Info{Major:"1", Minor:"17", GitVersion:"v1.17.0", GitCommit:"70132b0f130acc0bed193d9ba59dd186f0e634cf", GitTreeState:"clean", BuildDate:"2019-12-07T21:20:10Z", GoVersion:"go1.13.4", Compiler:"gc", Platform:"linux/amd64"}
Kube is installed with kubeadm + Ansible.
apiVersion: monitoring.coreos.com/v1
kind: Prometheus
metadata:
labels:
prometheus: k8s
name: k8s
namespace: monitoring
spec:
alerting:
alertmanagers:
- name: alertmanager-main
namespace: monitoring
port: web
baseImage: quay.io/prometheus/prometheus
nodeSelector:
kubernetes.io/os: linux
podMonitorNamespaceSelector: {}
podMonitorSelector: {}
replicas: 2
resources:
requests:
memory: 400Mi
retention: 30d
ruleSelector:
matchLabels:
prometheus: k8s
role: alert-rules
securityContext:
fsGroup: 0
runAsNonRoot: false
runAsUser: 0
serviceAccountName: prometheus-k8s
serviceMonitorNamespaceSelector: {}
serviceMonitorSelector: {}
storage:
volumeClaimTemplate:
apiVersion: v1
kind: PersistentVolumeClaim
spec:
accessModes:
- ReadWriteOnce
resources:
requests:
storage: 100Gi
storageClassName: prometheus-nfs
version: v2.11.0
$ kubectl describe pod prometheus-k8s-0 -n monitoring
Name:                      prometheus-k8s-0
Namespace:                 monitoring
Priority:                  0
Node:                      k8s-prod-node1/<IP_ADDRESS>
Start Time:                Fri, 10 Jan 2020 13:17:32 +0200
Labels:                    app=prometheus
controller-revision-hash=prometheus-k8s-859d94dcd5
prometheus=k8s
statefulset.kubernetes.io/pod-name=prometheus-k8s-0
Annotations:
Status:                    Terminating (lasts )
Termination Grace Period:  600s
IP:
IPs:
Controlled By:             StatefulSet/prometheus-k8s
Containers:
prometheus:
Container ID:
Image:         quay.io/prometheus/prometheus:v2.11.0
Image ID:
Port:          9090/TCP
Host Port:     0/TCP
Args:
--web.console.templates=/etc/prometheus/consoles
--web.console.libraries=/etc/prometheus/console_libraries
--config.file=/etc/prometheus/config_out/prometheus.env.yaml
--storage.tsdb.path=/prometheus
--storage.tsdb.retention.time=30d
--web.enable-lifecycle
--storage.tsdb.no-lockfile
--web.route-prefix=/
State:          Terminated
Exit Code:    0
Started:      Mon, 01 Jan 0001 00:00:00 +0000
Finished:     Mon, 01 Jan 0001 00:00:00 +0000
Ready:          False
Restart Count:  0
Requests:
memory:     400Mi
Liveness:     http-get http://:web/-/healthy delay=0s timeout=3s period=5s #success=1 #failure=6
Readiness:    http-get http://:web/-/ready delay=0s timeout=3s period=5s #success=1 #failure=120
Environment:
Mounts:
/etc/prometheus/certs from tls-assets (ro)
/etc/prometheus/config_out from config-out (ro)
/etc/prometheus/rules/prometheus-k8s-rulefiles-0 from prometheus-k8s-rulefiles-0 (rw)
/prometheus from prometheus-k8s-db (rw,path="prometheus-db")
/var/run/secrets/kubernetes.io/serviceaccount from prometheus-k8s-token-zmbcc (ro)
prometheus-config-reloader:
Container ID:
Image:         quay.io/coreos/prometheus-config-reloader:v0.34.0
Image ID:
Port:
Host Port:
Command:
/bin/prometheus-config-reloader
Args:
--log-format=logfmt
--reload-url=http://localhost:9090/-/reload
--config-file=/etc/prometheus/config/prometheus.yaml.gz
--config-envsubst-file=/etc/prometheus/config_out/prometheus.env.yaml
State:          Terminated
Exit Code:    0
Started:      Mon, 01 Jan 0001 00:00:00 +0000
Finished:     Mon, 01 Jan 0001 00:00:00 +0000
Ready:          False
Restart Count:  0
Limits:
cpu:     100m
memory:  25Mi
Requests:
cpu:     100m
memory:  25Mi
Environment:
POD_NAME:  prometheus-k8s-0 (v1:metadata.name)
Mounts:
/etc/prometheus/config from config (rw)
/etc/prometheus/config_out from config-out (rw)
/var/run/secrets/kubernetes.io/serviceaccount from prometheus-k8s-token-zmbcc (ro)
rules-configmap-reloader:
Container ID:
Image:         quay.io/coreos/configmap-reload:v0.0.1
Image ID:
Port:
Host Port:
Args:
--webhook-url=http://localhost:9090/-/reload
--volume-dir=/etc/prometheus/rules/prometheus-k8s-rulefiles-0
State:          Terminated
Exit Code:    0
Started:      Mon, 01 Jan 0001 00:00:00 +0000
Finished:     Mon, 01 Jan 0001 00:00:00 +0000
Ready:          False
Restart Count:  0
Limits:
cpu:     100m
memory:  25Mi
Requests:
cpu:        100m
memory:     25Mi
Environment:
Mounts:
/etc/prometheus/rules/prometheus-k8s-rulefiles-0 from prometheus-k8s-rulefiles-0 (rw)
/var/run/secrets/kubernetes.io/serviceaccount from prometheus-k8s-token-zmbcc (ro)
Conditions:
Type              Status
Initialized       True
Ready             False
ContainersReady   False
PodScheduled      True
Volumes:
prometheus-k8s-db:
Type:       PersistentVolumeClaim (a reference to a PersistentVolumeClaim in the same namespace)
ClaimName:  prometheus-k8s-db-prometheus-k8s-0
ReadOnly:   false
config:
Type:        Secret (a volume populated by a Secret)
SecretName:  prometheus-k8s
Optional:    false
tls-assets:
Type:        Secret (a volume populated by a Secret)
SecretName:  prometheus-k8s-tls-assets
Optional:    false
config-out:
Type:       EmptyDir (a temporary directory that shares a pod's lifetime)
Medium:
SizeLimit:
prometheus-k8s-rulefiles-0:
Type:      ConfigMap (a volume populated by a ConfigMap)
Name:      prometheus-k8s-rulefiles-0
Optional:  false
prometheus-k8s-token-zmbcc:
Type:        Secret (a volume populated by a Secret)
SecretName:  prometheus-k8s-token-zmbcc
Optional:    false
QoS Class:       Burstable
Node-Selectors:  kubernetes.io/os=linux
Tolerations:     node.kubernetes.io/not-ready:NoExecute for 300s
node.kubernetes.io/unreachable:NoExecute for 300s
Events:
Type    Reason     Age        From               Message

Normal  Scheduled    default-scheduler  Successfully assigned monitoring/prometheus-k8s-0 to k8s-prod-node1
$ journalctl -lfu kubelet | grep 'prometheus'
Jan 10 13:18:16 k8s-prod-node0 kubelet[18533]: I0110 13:18:16.572930   18533 operation_generator.go:713] UnmountVolume.TearDown succeeded for volume "kubernetes.io/nfs/a076e9db-a640-4cda-9bec-ba4dba82766e-prometheus-k8s-db-prometheus-k8s-0" (OuterVolumeSpecName: "prometheus-k8s-db") pod "a076e9db-a640-4cda-9bec-ba4dba82766e" (UID: "a076e9db-a640-4cda-9bec-ba4dba82766e"). InnerVolumeSpecName "prometheus-k8s-db-prometheus-k8s-0". PluginName "kubernetes.io/nfs", VolumeGidValue ""
Jan 10 13:18:16 k8s-prod-node0 kubelet[18533]: I0110 13:18:16.642005   18533 reconciler.go:303] Volume detached for volume "prometheus-k8s-db-prometheus-k8s-0" (UniqueName: "kubernetes.io/nfs/a076e9db-a640-4cda-9bec-ba4dba82766e-prometheus-k8s-db-prometheus-k8s-0") on node "k8s-prod-node0" DevicePath ""
Jan 10 13:18:17 k8s-prod-node0 kubelet[18533]: E0110 13:18:17.860354   18533 kubelet_pods.go:1105] Failed killing the pod "prometheus-k8s-0": [failed to "KillContainer" for "rules-configmap-reloader" with KillContainerError: "rpc error: code = Unknown desc = Error: No such container: 13a1d6c67c8dfc6d2a8a397ee819113eea549c196fba0557e694fe47b81d3eb5", failed to "KillContainer" for "prometheus-config-reloader" with KillContainerError: "rpc error: code = Unknown desc = Error: No such container: a937f093bfcd41da2cecfa873fa54000a474f2a77c73a0648e97e1a4754ace4d"]
Jan 10 13:18:22 k8s-prod-node0 kubelet[18533]: I0110 13:18:22.157915   18533 reconciler.go:209] operationExecutor.VerifyControllerAttachedVolume started for volume "prometheus-k8s-token-zmbcc" (UniqueName: "kubernetes.io/secret/1acd9675-b68c-4f42-924b-460fbd3d0bba-prometheus-k8s-token-zmbcc") pod "prometheus-k8s-0" (UID: "1acd9675-b68c-4f42-924b-460fbd3d0bba")
Jan 10 13:18:22 k8s-prod-node0 kubelet[18533]: I0110 13:18:22.158325   18533 reconciler.go:209] operationExecutor.VerifyControllerAttachedVolume started for volume "config-out" (UniqueName: "kubernetes.io/empty-dir/1acd9675-b68c-4f42-924b-460fbd3d0bba-config-out") pod "prometheus-k8s-0" (UID: "1acd9675-b68c-4f42-924b-460fbd3d0bba")
Jan 10 13:18:22 k8s-prod-node0 kubelet[18533]: I0110 13:18:22.158489   18533 reconciler.go:209] operationExecutor.VerifyControllerAttachedVolume started for volume "tls-assets" (UniqueName: "kubernetes.io/secret/1acd9675-b68c-4f42-924b-460fbd3d0bba-tls-assets") pod "prometheus-k8s-0" (UID: "1acd9675-b68c-4f42-924b-460fbd3d0bba")
Jan 10 13:18:22 k8s-prod-node0 kubelet[18533]: I0110 13:18:22.158677   18533 reconciler.go:209] operationExecutor.VerifyControllerAttachedVolume started for volume "config" (UniqueName: "kubernetes.io/secret/1acd9675-b68c-4f42-924b-460fbd3d0bba-config") pod "prometheus-k8s-0" (UID: "1acd9675-b68c-4f42-924b-460fbd3d0bba")
Jan 10 13:18:22 k8s-prod-node0 kubelet[18533]: I0110 13:18:22.158791   18533 reconciler.go:209] operationExecutor.VerifyControllerAttachedVolume started for volume "prometheus-k8s-db-prometheus-k8s-0" (UniqueName: "kubernetes.io/nfs/1acd9675-b68c-4f42-924b-460fbd3d0bba-prometheus-k8s-db-prometheus-k8s-0") pod "prometheus-k8s-0" (UID: "1acd9675-b68c-4f42-924b-460fbd3d0bba")
Jan 10 13:18:22 k8s-prod-node0 kubelet[18533]: I0110 13:18:22.158882   18533 reconciler.go:209] operationExecutor.VerifyControllerAttachedVolume started for volume "prometheus-k8s-rulefiles-0" (UniqueName: "kubernetes.io/configmap/1acd9675-b68c-4f42-924b-460fbd3d0bba-prometheus-k8s-rulefiles-0") pod "prometheus-k8s-0" (UID: "1acd9675-b68c-4f42-924b-460fbd3d0bba")
Jan 10 13:18:22 k8s-prod-node0 kubelet[18533]: W0110 13:18:22.259703   18533 volume_linux.go:45] Setting volume ownership for /var/lib/kubelet/pods/1acd9675-b68c-4f42-924b-460fbd3d0bba/volumes/kubernetes.io~empty-dir/wrapped_prometheus-k8s-rulefiles-0 and fsGroup set. If the volume has a lot of files then setting volume ownership could be slow, see https://github.com/kubernetes/kubernetes/issues/69699
Jan 10 13:18:22 k8s-prod-node0 kubelet[18533]: W0110 13:18:22.260304   18533 volume_linux.go:45] Setting volume ownership for /var/lib/kubelet/pods/1acd9675-b68c-4f42-924b-460fbd3d0bba/volumes/kubernetes.io~configmap/prometheus-k8s-rulefiles-0 and fsGroup set. If the volume has a lot of files then setting volume ownership could be slow, see https://github.com/kubernetes/kubernetes/issues/69699
Jan 10 13:18:22 k8s-prod-node0 kubelet[18533]: W0110 13:18:22.287186   18533 volume_linux.go:45] Setting volume ownership for /var/lib/kubelet/pods/1acd9675-b68c-4f42-924b-460fbd3d0bba/volumes/kubernetes.io~empty-dir/wrapped_prometheus-k8s-token-zmbcc and fsGroup set. If the volume has a lot of files then setting volume ownership could be slow, see https://github.com/kubernetes/kubernetes/issues/69699
Jan 10 13:18:22 k8s-prod-node0 kubelet[18533]: W0110 13:18:22.287958   18533 volume_linux.go:45] Setting volume ownership for /var/lib/kubelet/pods/1acd9675-b68c-4f42-924b-460fbd3d0bba/volumes/kubernetes.io~secret/prometheus-k8s-token-zmbcc and fsGroup set. If the volume has a lot of files then setting volume ownership could be slow, see https://github.com/kubernetes/kubernetes/issues/69699

prometheus-k8s-0 / 1 does something with pvc mount before terminating, I did rm -rf * there and after install there were some files.

jsonnet/kube-prometheus/jsonnetfile.json:            "version": "release-0.34"

Do the prometheus operator logs say something?

$ kubectl logs prometheus-operator-99dccdc56-jzlj6 -n monitoring | wc -l
119230
$ kubectl logs prometheus-operator-99dccdc56-jzlj6 -n monitoring | grep 'info' | wc -l
118542
$ kubectl logs prometheus-operator-99dccdc56-jzlj6 -n monitoring | grep -v 'info' | wc -l
746
$ kubectl logs prometheus-operator-99dccdc56-jzlj6 -n monitoring | grep -v 'info' | cut -d' ' -f 3- | sort | uniq
1 operator.go:972] Sync "monitoring/k8s" failed: failed to delete StatefulSet to avoid forbidden action: statefulsets.apps "prometheus-k8s" not found
1 operator.go:972] Sync "monitoring/k8s" failed: updating StatefulSet failed: statefulsets.apps "prometheus-k8s" not found
msg="Staring insecure server on :8080"
msg="Starting Prometheus Operator version '0.34.0'."

$ kubectl get pods -n monitoring
NAME                                  READY   STATUS        RESTARTS   AGE
alertmanager-main-0                   2/2     Running       0          3d2h
alertmanager-main-1                   2/2     Running       0          3d2h
alertmanager-main-2                   2/2     Running       0          3d2h
grafana-58dc7468d7-t88gg              1/1     Running       0          3d2h
kube-state-metrics-769f4fd4d5-tskcv   3/3     Running       0          3d2h
node-exporter-clc95                   2/2     Running       0          3d2h
node-exporter-m522t                   2/2     Running       0          3d2h
node-exporter-qnfzc                   2/2     Running       0          3d2h
node-exporter-tbttr                   2/2     Running       0          3d2h
prometheus-adapter-5cd5798d96-tkzd2   1/1     Running       0          3d2h
prometheus-k8s-0                      0/3     Terminating   0          1s
prometheus-k8s-1                      0/3     Terminating   0          1s
prometheus-operator-99dccdc56-jzlj6   1/1     Running       0          3d2h

Do you maybe happen to have multiple prometheus operator pods running?

How is possible? Install was done :

name: Prome setup
shell: |
kubectl create -f manifests/setup
until kubectl get servicemonitors --all-namespaces ; do date; sleep 1; echo ""; done

name: Create Prometheus from manifests
shell: |
kubectl create -f /manifests/

I also did several times comlete delete with  kubectl delete --ignore-not-found=true -f manifests/ -f manifests/setup and new install with: kubectl create -f manifests/setup + kubectl create -f /manifests/ and result was same every time?
$ kubectl get pods --all-namespaces | grep 'operator'
monitoring    prometheus-operator-99dccdc56-jzlj6             1/1     Running       0          3d3h
I don't see any extra Pods running?

It doesn't look like you are. I'm just asking as we've seen this a couple times before :) . Could you share the whole log?

Do you mean operator log? It's 15MB, how can I deliver it to you?

$ du -h operator.log
16M	operator.log

How about if I make completely new install and hopefully log will be smaller?

Can't make up from the issue what version of k8s did this happen on?

$ kubectl version
Client Version: version.Info{Major:"1", Minor:"17", GitVersion:"v1.17.0", GitCommit:"70132b0f130acc0bed193d9ba59dd186f0e634cf", GitTreeState:"clean", BuildDate:"2019-12-07T21:20:10Z", GoVersion:"go1.13.4", Compiler:"gc", Platform:"linux/amd64"}
$ uname -a
4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
$ cat /etc/os-release
NAME="Ubuntu"
VERSION="18.04.3 LTS (Bionic Beaver)"
ID=ubuntu
ID_LIKE=debian
PRETTY_NAME="Ubuntu 18.04.3 LTS"
VERSION_ID="18.04"
HOME_URL="https://www.ubuntu.com/"
SUPPORT_URL="https://help.ubuntu.com/"
BUG_REPORT_URL="https://bugs.launchpad.net/ubuntu/"
PRIVACY_POLICY_URL="https://www.ubuntu.com/legal/terms-and-policies/privacy-policy"
VERSION_CODENAME=bionic
UBUNTU_CODENAME=bionic

I have had exactly same configuration running in 1.16.3 for 40 days:
$ kubectl  get pods -n monitoring
NAME                                  READY   STATUS    RESTARTS   AGE
alertmanager-main-0                   2/2     Running   0          40d
alertmanager-main-1                   2/2     Running   0          40d
alertmanager-main-2                   2/2     Running   0          40d
grafana-58dc7468d7-sqz9b              1/1     Running   0          40d
kube-state-metrics-78b46c84d8-hvqxl   3/3     Running   0          40d
node-exporter-6ffzv                   2/2     Running   0          40d
node-exporter-6pn9k                   2/2     Running   0          40d
node-exporter-mpq8m                   2/2     Running   0          40d
prometheus-adapter-5cd5798d96-97js5   1/1     Running   0          40d
prometheus-k8s-0                      3/3     Running   1          40d
prometheus-k8s-1                      3/3     Running   1          40d
prometheus-operator-99dccdc56-rmgl2   1/1     Running   0          40d
I tried to do new kubernetes install and kube-prometheus did not install anymore. Installer Ansible script was also same as I have used before.

Interesting we have recently switched to kube-prometheus CI tests against 1.17.0 so find this interesting. We also run 1.17 and have not had any problems yet.

I don't know if this is relevant, but we did these kernel parameter changes compared to 1.16.3 environment:
FS:
fs.inotify.max_user_watches = 524288
fs.inotify.max_user_instances = 8192
Net:
net.core.somaxconn=32768
net.ipv4.ip_local_port_range='1024 65535'

what changes you made to resolve this issue?

I upgraded prometheus to 0.35.1


Apps deploy but not listed in Modern view - Classic view shows reality

Category

[ ] Question
[ ] Typo
[X ] Bug
[ ] Additional article idea

Expected or Desired Behavior
Expect to see all apps deployed to the site from APPS CATALOG to be listed in Site Contents
Observed Behavior
Classic View = okay, Modern View shows only the first ever app added to site, two newer apps not listed
Steps to Reproduce
add multiple apps to a site; view site contents in Classic and Modern Views
Submission Guidelines

Apps deploy but not listed in Modern view - Classic view shows reality #1439

Whoops. I was trying to delete attachments (screen shots). See below...

My 3 custom web parts are deployed and work (inserted into a page). The issue is simply that the Site Contents isn't lists them.

Hi @waltsully - that's partly expected, but not wholly.  The modern view doesn't show apps that are in an installing state, and there could be some minor timing differences.  Are you still seeing two different views?  If so, we could use a bit of help in tracking this down.  Do you know how to find correlation IDs of requests?  If so, can you send us the correlation ID of the modern and the classic site contents page requests?
Thanks,
Pat.

Hi @patmill<EMAIL_ADDRESS>The phenomenon continues. Modern view of site contents one App shown; classic shows all three I’ve added.
correlation IDs of requests? This is done with f12 traces? Or Fiddler?
walt
From: Pat Miller<EMAIL_ADDRESS>Sent: Monday, March 19, 2018 6:14 PM
To: SharePoint/sp-dev-docs<EMAIL_ADDRESS>Cc: Walter Sully<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [SharePoint/sp-dev-docs] Apps deploy but not listed in Modern view - Classic view shows reality (#1439)
Hi @waltsullyhttps://github.com/waltsully - that's partly expected, but not wholly. The modern view doesn't show apps that are in an installing state, and there could be some minor timing differences. Are you still seeing two different views? If so, we could use a bit of help in tracking this down. Do you know how to find correlation IDs of requests? If so, can you send us the correlation ID of the modern and the classic site contents page requests?
Thanks,
Pat.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/SharePoint/sp-dev-docs/issues/1439#issuecomment-374400858, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AfrSNUNFoAWzMwxqOyTJImlvY-mAig8eks5tgC2qgaJpZM4Se5Oq.

This email has been scanned by MessageLabs on behalf of E-INS

Hi Walt - yes.  F12 should work fine.  Look at the network request to the viewlsts.aspx page.  If you look at the response headers, there should be a header named something like SPRequestID, with a GUID as the value.

@patmill<EMAIL_ADDRESS>From viewlsts.aspx headers
CLASSIC:  sprequestguid:  ee2b559e-40ae-5000-5313-8c4a11702bdc
MODERN: sprequestguid:  8c2b559e-101f-5000-6ef2-9fa54de2488
From: Pat Miller<EMAIL_ADDRESS>Sent: Monday, March 19, 2018 6:43 PM
To: SharePoint/sp-dev-docs<EMAIL_ADDRESS>Cc: Walter Sully<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [SharePoint/sp-dev-docs] Apps deploy but not listed in Modern view - Classic view shows reality (#1439)
Hi Walt - yes. F12 should work fine. Look at the network request to the viewlsts.aspx page. If you look at the response headers, there should be a header named something like SPRequestID, with a GUID as the value.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/SharePoint/sp-dev-docs/issues/1439#issuecomment-374409582, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AfrSNV1kFM5GltdDUhblRAL4oc5JMoSuks5tgDSLgaJpZM4Se5Oq.

This email has been scanned by MessageLabs on behalf of E-INS

Thanks @waltsully - I've updated our bug with this information.

Not sure if online SP updates have happened. I now have different but related symptoms:
Classic View correctly showed three web-parts each with unique name
Modern View show three web-parts all with same name & date.
From: Pat Miller<EMAIL_ADDRESS>Sent: Monday, March 19, 2018 7:29 PM
To: SharePoint/sp-dev-docs<EMAIL_ADDRESS>Cc: Walter Sully<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [SharePoint/sp-dev-docs] Apps deploy but not listed in Modern view - Classic view shows reality (#1439)
Thanks @waltsullyhttps://github.com/waltsully - I've updated our bug with this information.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/SharePoint/sp-dev-docs/issues/1439#issuecomment-374420455, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AfrSNSrPH_yd4tq5ULwFOvhoerRYnFQNks5tgD8igaJpZM4Se5Oq.

This email has been scanned by MessageLabs on behalf of E-INS

If this helps… when I deleted the web-part from the site contents (using classic view) the modern view then listed two apps both named and dated the same. The part name shown was of one of the remaining two (repeated).


use nf-core on an HPC with internet access

Description of the bug
Hello, I would like to ask if it's necessary to use nf-core on an HPC with internet access. After installing the software, I submitted a job using qsub, and I received the following error:
ERROR ~ Error executing process > 'NFCORE_ONCOANALYSER:WGTS:READ_ALIGNMENT_DNA:BWAMEM2_ALIGN (1)'
Caused by:
Failed to create Conda environment
command: conda env create --prefix /hsfscqjf2/ST_CQ/Reference/software/envs/wgs/test_example/oncoanalyser/work/conda/env-b8fbc0e3a4801429-6fa9e2f9e8bfb5dd9553b0c9cc3af98f --file /home/lvmeiqi/.nextflow/assets/nf-cor
status : 1
message:
Channels:
- conda-forge
- bioconda
- defaults
Platform: linux-64
Collecting package metadata (repodata.json): ...working... Retrying (Retry(total=2, connect=None, read=None, redirect=None, status=None)) after connection broken by 'NewConnectionError('<urllib3.connection.HTTPSCo
  Retrying (Retry(total=2, connect=None, read=None, redirect=None, status=None)) after connection broken by 'NewConnectionError('<urllib3.connection.HTTPSConnection object at 0x2b50678a5ee0>: Failed to establish a n

  Retrying (Retry(total=2, connect=None, read=None, redirect=None, status=None)) after connection broken by 'NewConnectionError('<urllib3.connection.HTTPSConnection object at 0x2b5062b20e60>: Failed to establish a n

  Retrying (Retry(total=2, connect=None, read=None, redirect=None, status=None)) after connection broken by 'NewConnectionError('<urllib3.connection.HTTPSConnection object at 0x2b50678a6060>: Failed to establish a n

  Retrying (Retry(total=1, connect=None, read=None, redirect=None, status=None)) after connection broken by 'NewConnectionError('<urllib3.connection.HTTPSConnection object at 0x2b50678a6300>: Failed to establish a n

  Retrying (Retry(total=1, connect=None, read=None, redirect=None, status=None)) after connection broken by 'NewConnectionError('<urllib3.connection.HTTPSConnection object at 0x2b50678a65a0>: Failed to establish a n

  Retrying (Retry(total=1, connect=None, read=None, redirect=None, status=None)) after connection broken by 'NewConnectionError('<urllib3.connection.HTTPSConnection object at 0x2b50678a66f0>: Failed to establish a n

  Retrying (Retry(total=1, connect=None, read=None, redirect=None, status=None)) after connection broken by 'NewConnectionError('<urllib3.connection.HTTPSConnection object at 0x2b50678a64e0>: Failed to establish a n

  Retrying (Retry(total=0, connect=None, read=None, redirect=None, status=None)) after connection broken by 'NewConnectionError('<urllib3.connection.HTTPSConnection object at 0x2b50665b8770>: Failed to establish a n

  Retrying (Retry(total=0, connect=None, read=None, redirect=None, status=None)) after connection broken by 'NewConnectionError('<urllib3.connection.HTTPSConnection object at 0x2b50665b8b00>: Failed to establish a n

  Retrying (Retry(total=0, connect=None, read=None, redirect=None, status=None)) after connection broken by 'NewConnectionError('<urllib3.connection.HTTPSConnection object at 0x2b50665df6e0>: Failed to establish a n

  Retrying (Retry(total=0, connect=None, read=None, redirect=None, status=None)) after connection broken by 'NewConnectionError('<urllib3.connection.HTTPSConnection object at 0x2b50665df860>: Failed to establish a n

  failed

  CondaHTTPError: HTTP 000 CONNECTION FAILED for url <https://repo.anaconda.com/pkgs/main/linux-64/repodata.json>
  Elapsed: -

  An HTTP error occurred when trying to retrieve this URL.
  HTTP errors are often intermittent, and a simple retry will get you on your way.

  If your current network has https://repo.anaconda.com blocked, please file
  a support request with your network engineering team.

  'https//repo.anaconda.com/pkgs/main/linux-64'

Command used and terminal output
nextflow run nf-core/oncoanalyser \
  -profile conda \
  -revision 1.0.0 \
  --mode wgts \
  --genome GRCh38_hmf \
  --input samplesheet.csv \
  --outdir output_directory \
  --max_memory '20.GB' \
  -config ./refdata.local.config

System information
No response

try to remove the defaults channel from the config, your admin might have blocked that

try to remove the defaults channel from the config, your admin might have blocked that

Should I remove the below in .nextflow/assets/nf-core/oncoanalyser/nextflow.config :
conda.channels  = ['conda-forge', 'bioconda', 'defaults']

Hi @Donbbit, were you able to get oncoanalyser running on your HPC?

Closing due to inactivity, please reopen if you'd like to continue discussing!


Updating validation signature

Fixes #37 .
Todo:

[ ] update documentation
[x] update Literal import for python versions < 3.8 (see https://github.com/wayfair-incubator/columbo/pull/88/checks?check_run_id=1858256105)
[x] retain support for legacy validator
[x] update new ValidationFailure to require an error string

@jamescurtin and @plannigan : I've made some updates to columbo to address #37 . When you get a chance, could you review the changes I've made? I still need to update the documentation, but want to make sure my updates are solid before updating documentation. Thanks!


Proxy killer to avoid port exhaustion

When a game server doesn't send any data to a proxy for a few seconds, it should be closed to avoid port eventual exhaustion. This is more urgent than #10, since there is a very real possibility that an instance might not close for a very long time, leading to unclosed proxies killing the server.

Implemented but untested in https://github.com/karashiiro/kartlobby/commit/be5073963f6917dbe9fdb8c6ba992860d1bc8c8e


Migrate to proc-macro2/syn/quote 1.0

@lnicola does this look good? I think I'll have to rebase the other PR after this gets merged

It does, but I'm not really familiar with the code and I didn't feel comfortable merging it. But as they say, "it's better to ask forgiveness it is to get permission".
So thank you for this work!


TS Definition Unexpected Token

Hi, thanks for providing a TS Definition, but I am receiving an Error there:
ERROR: Unexpected token export
.cordova\node_modules\cordova-android\node_modules\big-integer\BigInteger.d.ts:5
export = bigInt;
^^^^^^

Am I doing something wrong, or is this simply an error?

@toefraz You created the definition file, is there something wrong with the syntax here?

The syntax looks fine to me, @peterolson
I’m guessing it’s some configuration issue with Cordova and typescript. Unfortunately I don’t have any experience with that project

@JWO719 Are you able to use other TypeScript definitions without issue in your project?

Yeah that worked. I could imagine it is a configuration thing but I dunno. I thought it was configured properly.

@JWO719 If you posted your tsconfig maybe I could help spot the issue


MacOS: If brew fails to install ccache, skip using ccache?

See this CI Run: https://github.com/ninja-build/ninja/runs/5777867654?check_suite_focus=true
Install ccache
  /bin/bash -xc brew install ccache
  + brew install ccache
  ==> Downloading https://ghcr.io/v2/homebrew/core/hiredis/manifests/1.0.2
  ==> Downloading https://ghcr.io/v2/homebrew/core/hiredis/blobs/sha256:14ae7b3adb354b673a3744e9d849d6698846d5162d3d5f0eb8f9d8837c858e75
  ==> Downloading from https://pkg-containers.githubusercontent.com/ghcr1/blobs/sha256:14ae7b3adb354b673a3744e9d849d6698846d5162d3d5f0eb8f9d8837c858e75?se=2022-03-31T20%3A35%3A00Z&sig=%2FbbWXeQuHptzScNdWVeq0RKGBbHa1MTOGnW%2Fic5VZuY%3D&sp=r&spr=https&sr=b&sv=2019-12-12
  curl: (35) error:14004410:SSL routines:CONNECT_CR_SRVR_HELLO:sslv3 alert handshake failure
  Error: ccache: Failed to download resource "hiredis"
  Download failed: https://ghcr.io/v2/homebrew/core/hiredis/blobs/sha256:14ae7b3adb354b673a3744e9d849d6698846d5162d3d5f0eb8f9d8837c858e75
  Error: Restoring cache failed: Error: The process '/bin/bash' failed with exit code 1

sounds like a problem with your curl - SE recommends installing curl from brew.
I guess this problem only applies to a certain macos version and the version of curl that ships with it.
regarding your question:

If brew fails to install ccache, skip using ccache?

I don't think so. That's error silencing, I think we should not. If we silence here, users won't notice other problems. The right mitigation if you are not able to fix curl is to take out this action for this platform using a worflow conditional. But as said, I suggest to find the reason for the curl error.

I have no idea what the reason for the curl error is. I'm just using your ccache-action as-is. I don't otherwise interact with curl in any way.

The action use brew to install ccache, similar to what your PR does. You can e.g. swap the steps in your PR and install the dependencies 1st. If you add ccache there it should fail with the same error.
The SE post I found: https://unix.stackexchange.com/questions/192944/how-to-fix-curl-sslv3-alert-handshake-failure
It recommends installing curl from brew before this action.
Another recommendation for this PR is setting fail-fast to false:
  strategy:
      fail-fast: false

Right now github stops as soon as it errors, but it would actually be nice if your workflow executes the other macos version. it would be good to know if the problem only happens for 10.15.
If that's the case, I could also add a workaround in the action to install curl via brew before ccache for macos 10.15.

I'm seeing that the failure is inconsistent. Sometimes (with no changes to the macos.yml) it works, sometimes it doesn.t
This makes me think that there is potentially a misconfigured github supplied macos runner, or the problem is based on network variance.

Added fail-fast: false as requested

I'm seeing that the failure is inconsistent. Sometimes (with no changes to the macos.yml) it works, sometimes it doesn.t

I guess brew is using different mirrors to download packages, if unlucky it chooses one where you hit the sslv3 problem.
What's your perceived ratio of successful vs. failing workflow runs?

Out of about 6-7 runs, it failed twice with ssl errors. But I didn't have enough data points to say there was much of a pattern.

How about moving from Homebrew to GH download for macOS? Homebrew is MUCH slower. Maybe also do it for Ubuntu?

I don't see binary releases for mac and linux on github, but only windows.
At least on ubuntu apt seems the way to go. brew is the de-facto although not official standard... :thinking:
@jonesmz and maybe other finding this issue: It would be nice to confirm if upgrading curl before installing ccache via the action fixes the problem.
So the options we have:

retry the install n times (with some probability we get a "good" mirror)
install it from another place, e.g. github (not good if we have to install from source)
upgrade curl on mac (2 calls to brew install, to be confirmed, what if that triggers the error in the 1st call)
do nothing (I can't believe we are the only affected users, either github fixes the base image or brew does not use "broken mirrors")

I don't see binary releases for mac and linux on github, but only windows.

You're right, didn't see that!

Could it be that this was just a hickup of GH packages/container registry, which Homebrew uses as the download source?

Could it be that this was just a hickup of GH packages/container registry, which Homebrew uses as the download source?

That's what I mean with "broken mirrors": homebrew uses several mirrors for download to distribute the load. By chance it picks one that lets the download fail. I agree this could just be a hickup. We should only add a workaround if its a permanent issue.

I think Homebrew stopped using mirrors and now uses GHCR only

This seems to be failking all the time now...

@arximboldi do you have a link to a failing one?

I think it was just some downtime of ghcr returning 503. It's working now. Sorry for the noise!


Document all exported functions

As the title and use @ autodoc to generate public documentation. Optionally this can be broken down into smaller tasks and resolved over multiple PRs.

This is done now.


<IP_ADDRESS>.2 Failed to execute init_db

The scripts failed to connect to the postgresql instance running in docker. spesifically, the line psql -h "${DB_HOST}" -U "${DB_USER}" -p "${DB_PORT}" -d "postgres" -c '\q'. Even running this line in my terminal return role postgres doesn't exist. I tried copying the init_db from this official github repo, still returns the same error. The postgres user is confirmed to exist in the docker instance spinned up by the script, when i tried to run using db exec. it just faills when runing psql direclty on my host machine.
Model : Macbook Pro 13" M2
Error message :

can you help me with this? i dont know whats wrong. I followed everything inside the book. I even copied init_db from this repo, still failed and return the same error.

@mattot-the-builder I'm facing the same issue. How did you solve it?

I found the issue. I had postgres running locally on the same port. I ran brew services stop postgresql, then restarted the container and it worked.


Data Pre-processing ./preprocess.sh

I have a question, this export SCANNET_DIR=<path_to_downloaded_data>
"path_to_downloaded_data" is for what?

hi, this is for the path of downloaded ScanNet data, more specifically /public/v2


Refactor to use requests session

After working with the API it is going to be easier to refactor the code to use request session vs the traditional method.
We should create this as a class structure for ease.

Success: We are able to retrieve the user_id. Other issues will tackle getting workouts, parsing data, and other functionality.


Analyse how "Power Apps in Fusion Teams" fit into our Platform-as-a-Product initiatives (backstage)

[ ] Read @ https://www.drware.com/power-apps-development-in-fusion-teams/
[ ] Identify potential "golden paths" for Power App developers
[ ] Mock up control plane (backstage) GUI components focused on increasing productivity in Fusion Teams
[ ] Review with Office365 team
[ ] Implement new control plane components
[ ] Integrate new UI components with backend systems
[ ] Test & demo

How can we embrace no-code/low-code concepts in our current self-service platform?


Unify events from backends

Longterm goal: it would be nice to define a consistent API from all the backends.
https://docs.google.com/document/d/1-GQrFdDVrA57-ce0kbzSth4lQqfOMMRKpih3hPJmvoU/edit might be a good starting place for research.
/cc @whitfin

now we have a file event provider with default events.
when I modify a file /tmp/fs/test I got such messages after save the file in vim:
{:file_event, #PID<0.221.0>, {"/private/tmp/fs/.test.swpx", [:created, :removed]}}
{:file_event, #PID<0.221.0>, {"/private/tmp/fs/.test.swp", [:created, :removed, :changeowner]}}
{:file_event, #PID<0.221.0>, {"/private/tmp/fs/25454", [:created, :removed, :changeowner]}}
{:file_event, #PID<0.221.0>, {"/private/tmp/fs/test",  [:created, :inodemetamod, :renamed, :modified, :changeowner]}}
{:file_event, #PID<0.221.0>, {"/private/tmp/fs/test~", [:removed, :renamed]}}
{:file_event, #PID<0.221.0>, {"/private/tmp/fs/.test.swp", [:created, :removed, :modified, :changeowner]}}

This test is run under macos, I'm sure there will be different in other os.
is it necessary to make a middle to make sure the same result returned for all backends and all os?


Apply to embedded tweets?

Thank you very much for this excellent add-on! If it would be feasible for it to also apply to embedded tweets by adding platform.twitter.com to the list of domains that permissions need to be granted to, that would be great. Thanks again!

Hi, thanks for your interest in the extension.
At the beginning I had considered that the extension could do it but it wasn't a priority. The main target was for it to function on Twitter's website where most users would use it.
It implies making some changes, such as the way the user config is stored (a "fast" solution could be using only default config) and other things.
It's something I have yet to think about.
Thanks for the suggestion.

Thanks for the consideration, proceed as you feel is best appropriate!


Adding sidecar feature to KafkaOperator

Q
A

Bug fix?
no

New feature?
yes

API breaks?
no

Deprecations?
no

Related tickets

License
Apache 2.0

What's in this PR?
Adding sidecar features to kafka operator.
Enabling the required volumes and environment variables.
Why?
Better to have Sidecar enabling feature.
Checklist
[x] Implementation tested
[x] Error handling code meets the guideline
[x] Logging code meets the guideline
[x] User guide and development docs updated (if needed)

retesting

Thanks for this PR @adapured. Find my findings above.

@baluchicken : Fixed the code as per your comments. Please review.
Thanks

"Some checks were not successful".Stuck with "Mergeable — Invalid Configuration" . Creating a new PR. Closing this PR.

New PR: https://github.com/banzaicloud/kafka-operator/pull/632
"Some checks were not successful".Stuck with "Mergeable — Invalid Configuration"


Migrate to Cats Effect 3 ecosystem

Closes #299
This is going to be a very long-lasting WIP PR...
I am going to go through all the modules that already have got CE3-compatible dependencies and make the code compile.
Then fix the tests. Then wait for the rest dependencies and do the same.

@janstenpickle @CremboC I would appreciate your review.
The migration itself was quite easy. But there are several decisions to question and maybe to rework. I marked them with TODOs.
For now, we're blocked by a few dependencies and tests. I couldn't manage to work tests with the new IORuntime. It hangs for some reason when used with TestContext.
There are also a few things to change:

fs2.InspectableQueue is now deprecated. cats.effect.std.Queue doesn't support getSize. We need to rewrite the code that uses it.
There a lot of builder around BlazeClient that now requires an EC. It used to requier a Blocker but now it's gone. Moreover, it is said in the docs that EC.global would fit by default, so BlazeClient doesn't block. We can use Async[F].executionContext which is the default EC of the Runtime. Or ask for an optional EC param and use the default EC if it's None.
Some exporters wrap java drivers which I suppose to be non-blocking (udp, grpc senders). We used to provide Blockers for wrapping calls to them. I kept this semantic but I encourage you to discuss whether it's really needed to block such calls. They seem to be fire-and-forget calls to non-blocking drivers.

I also changed model a bit. SpanId and TraceId now don't conceal access to ThreadLocal random. Now they require Random as a bound on F. And where we have a Sync in the scope I derive a Random[F] instance via ThreadLocal random. I hope this change is ok for you. IMO, it is more fair and explicit.

Thanks @catostrophe this is really good.
I think some of the changes you mention can be backported now:

Not using Blocker for Async Java exporters
Do not use manually managed socket groups for avro exporters
Possibly switch tests to Munit?
Remove any usage of peeking on FS2 queues
Invert control of Random for span and trace IDs (I agree this is much clearer and makes it easier to test!)
Optional parameter for an execution context for Blaze client and server

I'm happy to start knocking some of these off over the weekend!

@janstenpickle

Not using Blocker for Async Java exporters
Optional parameter for an execution context for Blaze client and server

I made all ECs/Blockers optional. Since now we may ask Runtime to run a task on the default working EC or the default blocker. Now API looks better: if you want more fine-grained pool tuning, you provide your own EC; if not, just use the runtime defaults.

Do not use manually managed socket groups for avro exporters

I looked into the implementation of Network[F] and found that the global socket groups are initialized lazily NOT as resources. So manually managed socket groups seem even a cleaner approach. I kept them. I see no harm in using them.

Possibly switch tests to Munit?

I support this.

Now I'm looking at google-cloud-trace interop and I see there is Async API. I'll try to get rid of blocking calls.

All GRPC calls are async now.
All senders have an extra optional parameter ExecutionContext. It should be passed if a user wants an exporter to makes its calls in a dedicated thread pool. Most of senders are async, some are blocking - the difference is in the parameter name: ec or blocker.
If a EC is not passed, the exported works in the default runtime pool (be it the main worker pool or a blocking pool - depends on the sender).

I finally managed to migrate all modules that have CE3-compatible dependencies and make tests work.
The only test that still hangs is io.janstenpickle.trace4cats.rate.TokenBucketSpec. The ticker machinery is somewhat unclear to me, don't know why it hangs.

I finally managed to migrate all modules that have CE3-compatible dependencies and make tests work.
~The only test that still hangs is io.janstenpickle.trace4cats.rate.TokenBucketSpec.~ All tests have been migrated!

🙌
Thanks @catostrophe. I'm going to start backporting some of these changes to CE2 today, then we can cut a pre-CE3 release to reduce the delta in the upgrade.

@catostrophe I'm happy with this if you are. I'll create a CE3 branch to merge into

@janstenpickle fine!


tests(*): fix ssl upstream cert verify depth for mockbin.com

Summary

Rerunning the master test results in red today: https://github.com/Kong/kong/actions/runs/4830133642/jobs/8643121705
After digging, the errorlog shows
2023/05/01 17:50:00 [error] 71095#0: *2 upstream SSL certificate verify error: (22:certificate chain too long) while SSL handshaking to upstream, client: <IP_ADDRESS>, server: kong, request: "GET / HTTP/1.1", upstream: "https://<IP_ADDRESS>:443/requ
est", host: "mockbin.com"
2023/05/01 17:50:01 [error] 71095#0: *2 upstream SSL certificate verify error: (22:certificate chain too long) while SSL handshaking to upstream, client: <IP_ADDRESS>, server: kong, request: "GET / HTTP/1.1", upstream: "https://<IP_ADDRESS>:443/req
uest", host: "mockbin.com"
2023/05/01 17:50:01 [error] 71095#0: *2 upstream SSL certificate verify error: (22:certificate chain too long) while SSL handshaking to upstream, client: <IP_ADDRESS>, server: kong, request: "GET / HTTP/1.1", upstream: "https://<IP_ADDRESS>:443/requ
est", host: "mockbin.com"
2023/05/01 17:50:02 [error] 71095#0: *2 upstream SSL certificate verify error: (22:certificate chain too long) while SSL handshaking to upstream, client: <IP_ADDRESS>, server: kong, request: "GET / HTTP/1.1", upstream: "https://<IP_ADDRESS>:443/req
uest", host: "mockbin.com"
2023/05/01 17:50:02 [error] 71095#0: *2 upstream SSL certificate verify error: (22:certificate chain too long) while SSL handshaking to upstream, client: <IP_ADDRESS>, server: kong, request: "GET / HTTP/1.1", upstream: "https://<IP_ADDRESS>:443/requ
est", host: "mockbin.com"
2023/05/01 17:50:03 [error] 71095#0: *2 upstream SSL certificate verify error: (22:certificate chain too long) while SSL handshaking to upstream, client: <IP_ADDRESS>, server: kong, request: "GET / HTTP/1.1", upstream: "https://<IP_ADDRESS>:443/req
uest", host: "mockbin.com"

It seems that the mockbin.com has changed its cert the day before yesterday(04-29). I'm not sure how does the old server cert looks like, but having additional configuration on the SSL verify depth can solve this problem.
Checklist

[ ] The Pull Request has tests
[ ] There's an entry in the CHANGELOG
[ ] There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Full changelog

[Implement ...]

Issue reference

Fix #[issue number]

@windmgc is there a reason why this was only backported on ee and not on ce? Just checking because I noticed the same failures in release/3.1.x and release/3.2.x and I believe it should be backported there.

@samugi Thanks for reminding this! Just forget to backporting to these branches, working on it now


aiolifx-connection: init at 1.0.0

Description of changes
Add https://pypi.org/project/aiolifx-connection/ (deprecated package) at 1.0.0 to fix missing dependency for Home Assistant. This package is a very very thin shim around the base aiolifx package.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 187085 run on x86_64-linux 1

3 packages built:

home-assistant-component-tests.lifx
python310Packages.aiolifx-connection
python39Packages.aiolifx-connection

Whew, okay. I'll try to rip that package out on the next major home-assistant ugprade, since they already ripped it out again.
https://github.com/home-assistant/core/commit/db3e21df86d299d59e0c8ea4a3aeea1627837abc


3626: fix iOS Voiceover skip link bug

Fixed upstream in govuk_template / govuk_frontend_toolkit.

Is 3626 the right story number? The internal issue tracker has it as updating an interstitial page.


A11y_SQLMigrationControlPlane_MigrateToAzureSQL_ DatabasesForAssessment_ScreenReader: Column header for the table is not announced by the screen reader.

“Check out Accessibility Insights! - Identify accessibility bugs before check-in and make bug fixing faster and easier.”
GitHubTags:#A11yMAS;#A11yTCS;#AzureDataStudioextension'AzureSQLMigration'-Mac-Sept2022;#SQL Migration Control Plane;#A11ySev2;#WCAG1.3.1;#DesktopApp;#Win11;#ScreenReader;#Benchmark;#VoiceOver;#Mac
Environment Details:
Azure Data Studio: Version: 1.39.1
Operating System: Mac Version 12.5.1
Screen Reader: VoiceOver
Steps to Reproduce:

Install Azure data studio and open
Tab till Extension press enter key and install Azure SQL Migration
Tab till Respective server and right click
Tab till manage and press enter key
Tab till Azure SQL Migration and press enter key
Tab till migrate to azure SQL and press enter, saved session page will open
Select start new session and give next, Databases for assessment page will open
Open screen reader and observe that column header is not announced by the voice over.

Actual:
Column header for the table is not announced by the screen reader. It is only announced the name present in the column.
Expected:
Column header for the table should be announced by the screen reader. It should announce like Database column header, etc.
User Impact:
Screen reader user will get understand the column header for the table.
Screen Recording 2022-09-14 at 1.14.00 PM.zip

Githubtags:  #AzureDataStudioextensionAzureSQLMigration-Mac-Sept2022;

@BhanuPrakashGit and @InduPriya1805
This seems to be a voice over issue. Here is an example demonstrating that voiceover does not read column headers of table.
https://codepen.io/aasimkhan30/pen/yLxexmL

@aasimkhan30 Logged IRT bug, External to VoiceOver.

@BhanuPrakashGit since this is an external issue, can the severity of this be bug dropped from 2 to 3, as it is external and impacting our SLA.

@BhanuPrakashGit this issue is impacting our SLA, and we do not have the ability to fix it.  I would like to drop the bug severity from 2 to 3 so we are not graded for external issues.

The external bug is closed as By Design. As per the discussion with SME, closing this bug.
GithubTags:#Regressed:09-27-23;#Closed;


Apply featherlight to per JS loaded content

I'm trying to dynamically load images (as a result of a post request)
after manually initializing featherlight (since featherlight isn't listening to dynamically loaded content)
I managed to get a featherlight frame with overlay, but the image within it is not displayed.
See reduced testcase: http://jsfiddle.net/ovvtr7Lc/2/

Okay, featherlight seems to listen to dynamically added content! it works great now.
you should have noticed that in the documentation + that if you initialize a gallery, you don't need the featherlight data attribute PER image/a element.
I found that out when taking a look at the contribution fiddle: http://jsfiddle.net/JNsu6/15/

Congrats on finding the filter option. PR on documentation welcome.


perf: do not use parsers from the current stage inside quotations by default

(docs to follow)

!bench


Sapling/Orchard Key Agreement and KDF

All our keys are defined for Sapling and Orchard, we just have to finish the ephemeral - static diffie-hellman interaction to derive the shared secret.
Defined in

https://zips.z.cash/protocol/protocol.pdf#concretesaplingkeyagreement
and

https://zips.z.cash/protocol/protocol.pdf#saplinginband
Required for #269.

I think https://github.com/ZcashFoundation/zebra/issues/301 is a duplicate of this.

I think https://github.com/ZcashFoundation/zebra/issues/301 is a duplicate of this.

We're not planning to do full-node wallet work any time soon.
If we do, we'll need to decide if this ticket is in scope, and update its content, because the spec has changed since it was created.


Differences between explanations

Hello,
Can somwone explain differences between Bar graph and Waterfall ?
Features with Shapely should be independent, so why
with dataset Boston - on waterfall - Lstat has value +5.79 and on Bar plot +4.
What of this va;ues - is independent marginal add value (that is wanted)  osr whats the differnce between  diagrams ?
Whats the differences between shap_values[0] and shap_values[1] ? (its different explanation or not ?)
What values - are in shap_values - independent or not ?
How can transform shap_values to dataframe ? (pd.dataframe results with some errors ...)

When I have called the function shap_values, it gives an array with one entry, that entry being a numpy array.
`model = keras.models.load_model('../model.h5', compile=False)
will try to use just 100 random rows
number_of_rows_train = X_train.shape[0]
random_indices = np.random.choice(number_of_rows_train, size=100, replace=False)
X_train = X_train[random_indices, :]
def f(X):
return model.predict(X)
e = shap.KernelExplainer(f, X_train)
shap_values = e.shap_values(X_test)
print(f'shap_values shape: {shap_values[0].shape}') # array of length 1, with a numpy array inside
for idx in range(num_rows): # plotting for each test instance
f = plt.figure()
f = shap.force_plot(e.expected_value, shap_values= shap_values[0][idx,:], features= X_test[idx,:], feature_names = descriptors, show=False)
shap.save_html(f"plots/shap_plot_{my_names[idx]}_normalizedspace.html", f)
test_prediction_shap = y_scaler.inverse_transform(e.expected_value + sum(shap_values[0][idx,:]))
print(f'Using SHAP values, prediction for {my_names[idx]} is {test_prediction_shap}')

`
So shap_values[0] is a numpy array. The number of rows of this numpy array is the number of train or test instances. The number of columns of the numpy array is the number of features/descriptors each instance has when fed into the model.
To convert to a Pandas DataFrame, something like df = pd.DataFrame(shap_values[0]) should work.


Jenkins ECS agent plugin fixes

Added an instance cap: Allows us to control the maximum number of tasks which can be triggered
Added sleep to node termination: Prevents a race inside of Jenkins which could cause the node to be re-added if the build completes before Jenkins has registered the node as active
Added mode to task template: this allows us to define that a build MUST have the label specified in the template to trigger on ECS. This will allow us to roll out this functionality slowly to our Jenkins server.

per our offline discussion, updated the fields to be numbers. added some docs for instance cap


Rename and drop commands

use @heroku org
drop deprecated commands
add verbose flag to push and login

/cc @jbyrum @rsampaio @tt

Looks good to me.


terminal issue

Issue Type: Performance Issue
whenever i try to use the terminal windows, it would start displaying power shell and all sort of informations that i dont need. After i tried to change the settings to the command prompt and open a new terminal, the cursor under the terminal window would not start from the left hand side but start from the middle.
i have tried to use the 'clear' command but still giving me the same isuue

/needsMoreInfo
/gifPlease

Thanks for reporting this issue! Unfortunately, it's hard for us to understand what issue you're seeing. Please help us out by providing a screen recording showing exactly what isn't working as expected. While we can work with most standard formats, .gif files are preferred as they are displayed inline on GitHub. You may find https://gifcap.dev helpful as a browser-based gif recording tool.
If the issue depends on keyboard input, you can help us by enabling screencast mode for the recording (Developer: Toggle Screencast Mode in the command palette).
Happy coding!

Thanks for creating this issue! We figured it's missing some basic information or in some other way doesn't follow our issue reporting guidelines. Please take the time to review these and update the issue.
Happy Coding!

We closed this issue because it is a question about using VS Code rather than an issue or feature request. Please search for help on StackOverflow, where the community has already answered thousands of similar questions. You may find their guide on asking a new question helpful if your question has not already been asked. See also our issue reporting guidelines.
Happy Coding!


uninitialized constant Signal::ActiveRecord::Base

class SystemSubscribe::AddSubscriber
  include Signal
  attr_accessor :subscribe

  def initialize options={}
    @subscribe = Subscriber.new(options)
  end

  def call
    ActiveRecord::Base.transaction do
      return emit(:failure) unless save_subscribe
      send_subscriber_email
    end

    emit(:success, @subscribe)
  end

  private
  def save_subscribe
    @subscribe.save
  end

  def send_subscriber_email
    SubscriberNotifier.add_subscriber(@subscribe).deliver
  end
end

Can you paste the full backtrace?

NameError: uninitialized constant Signal::ActiveRecord::Base
from /Users/ricardopacheco/projects/socialcrm/app/services/system_subscribe/add_subscriber.rb:10:in call'   from (irb):10   from /Users/ricardopacheco/.rvm/gems/ruby-2.2.3@socialcrm/gems/railties-4.2.4/lib/rails/commands/console.rb:110:in start'
from /Users/ricardopacheco/.rvm/gems/ruby-2.2.3@socialcrm/gems/railties-4.2.4/lib/rails/commands/console.rb:9:in start'   from /Users/ricardopacheco/.rvm/gems/ruby-2.2.3@socialcrm/gems/railties-4.2.4/lib/rails/commands/commands_tasks.rb:68:in console'
from /Users/ricardopacheco/.rvm/gems/ruby-2.2.3@socialcrm/gems/railties-4.2.4/lib/rails/commands/commands_tasks.rb:39:in run_command!'   from /Users/ricardopacheco/.rvm/gems/ruby-2.2.3@socialcrm/gems/railties-4.2.4/lib/rails/commands.rb:17:in <top (required)>'
from /Users/ricardopacheco/projects/socialcrm/bin/rails:8:in <top (required)>'   from /Users/ricardopacheco/.rvm/rubies/ruby-2.2.3/lib/ruby/2.2.0/rubygems/core_ext/kernel_require.rb:54:in require'
from /Users/ricardopacheco/.rvm/rubies/ruby-2.2.3/lib/ruby/2.2.0/rubygems/core_ext/kernel_require.rb:54:in require'   from -e:1:in '

The problem is that the AR extensions does use the same module name (ActiveRecord). An alternative would be using something like include Signal.active_record, and delegate this to a different module.
Now, to solve your problem, for now, you can use ::ActiveRecord::Base.transaction.

Just released v1.0.0, so you have to use include Signal.active_record now.

@fnando I did what indicated to me and occurred another error:
NoMethodError: undefined method around_create' for SystemSubscribe::AddSubscriber:Class   from /Users/ricardopacheco/.rvm/gems/ruby-2.2.3@socialcrm/gems/signal-1.0.0/lib/signal/extensions/active_record.rb:12:in block in included'
from /Users/ricardopacheco/.rvm/gems/ruby-2.2.3@socialcrm/gems/signal-1.0.0/lib/signal/extensions/active_record.rb:9:in class_eval'   from /Users/ricardopacheco/.rvm/gems/ruby-2.2.3@socialcrm/gems/signal-1.0.0/lib/signal/extensions/active_record.rb:9:in included'
from /Users/ricardopacheco/projects/socialcrm/app/services/system_subscribe/add_subscriber.rb:2:in include'   from /Users/ricardopacheco/projects/socialcrm/app/services/system_subscribe/add_subscriber.rb:2:in class:AddSubscriber'
from /Users/ricardopacheco/projects/socialcrm/app/services/system_subscribe/add_subscriber.rb:1:in <top (required)>'   from /Users/ricardopacheco/.rvm/gems/ruby-2.2.3@socialcrm/gems/activesupport-4.2.4/lib/active_support/dependencies.rb:457:in load'
from /Users/ricardopacheco/.rvm/gems/ruby-2.2.3@socialcrm/gems/activesupport-4.2.4/lib/active_support/dependencies.rb:457:in block in load_file'   from /Users/ricardopacheco/.rvm/gems/ruby-2.2.3@socialcrm/gems/activesupport-4.2.4/lib/active_support/dependencies.rb:647:in new_constants_in'
from /Users/ricardopacheco/.rvm/gems/ruby-2.2.3@socialcrm/gems/activesupport-4.2.4/lib/active_support/dependencies.rb:456:in load_file'   from /Users/ricardopacheco/.rvm/gems/ruby-2.2.3@socialcrm/gems/activesupport-4.2.4/lib/active_support/dependencies.rb:354:in require_or_load'
from /Users/ricardopacheco/.rvm/gems/ruby-2.2.3@socialcrm/gems/activesupport-4.2.4/lib/active_support/dependencies.rb:494:in load_missing_constant'   from /Users/ricardopacheco/.rvm/gems/ruby-2.2.3@socialcrm/gems/activesupport-4.2.4/lib/active_support/dependencies.rb:184:in const_missing'
from (irb):4
from /Users/ricardopacheco/.rvm/gems/ruby-2.2.3@socialcrm/gems/railties-4.2.4/lib/rails/commands/console.rb:110:in start'   from /Users/ricardopacheco/.rvm/gems/ruby-2.2.3@socialcrm/gems/railties-4.2.4/lib/rails/commands/console.rb:9:in start'
from /Users/ricardopacheco/.rvm/gems/ruby-2.2.3@socialcrm/gems/railties-4.2.4/lib/rails/commands/commands_tasks.rb:68:in console'   from /Users/ricardopacheco/.rvm/gems/ruby-2.2.3@socialcrm/gems/railties-4.2.4/lib/rails/commands/commands_tasks.rb:39:in run_command!'
from /Users/ricardopacheco/.rvm/gems/ruby-2.2.3@socialcrm/gems/railties-4.2.4/lib/rails/commands.rb:17:in <top (required)>'   from /Users/ricardopacheco/.rvm/gems/ruby-2.2.3@socialcrm/gems/activesupport-4.2.4/lib/active_support/dependencies.rb:274:in require'
from /Users/ricardopacheco/.rvm/gems/ruby-2.2.3@socialcrm/gems/activesupport-4.2.4/lib/active_support/dependencies.rb:274:in block in require'   from /Users/ricardopacheco/.rvm/gems/ruby-2.2.3@socialcrm/gems/activesupport-4.2.4/lib/active_support/dependencies.rb:240:in load_dependency'
from /Users/ricardopacheco/.rvm/gems/ruby-2.2.3@socialcrm/gems/activesupport-4.2.4/lib/active_support/dependencies.rb:274:in require'   from /Users/ricardopacheco/projects/socialcrm/bin/rails:8:in <top (required)>'
from /Users/ricardopacheco/.rvm/gems/ruby-2.2.3@socialcrm/gems/activesupport-4.2.4/lib/active_support/dependencies.rb:268:in load'   from /Users/ricardopacheco/.rvm/gems/ruby-2.2.3@socialcrm/gems/activesupport-4.2.4/lib/active_support/dependencies.rb:268:in block in load'
from /Users/ricardopacheco/.rvm/gems/ruby-2.2.3@socialcrm/gems/activesupport-4.2.4/lib/active_support/dependencies.rb:240:in load_dependency'   from /Users/ricardopacheco/.rvm/gems/ruby-2.2.3@socialcrm/gems/activesupport-4.2.4/lib/active_support/dependencies.rb:268:in load'
from /Users/ricardopacheco/.rvm/rubies/ruby-2.2.3/lib/ruby/2.2.0/rubygems/core_ext/kernel_require.rb:54:in require'   from /Users/ricardopacheco/.rvm/rubies/ruby-2.2.3/lib/ruby/2.2.0/rubygems/core_ext/kernel_require.rb:54:in require'

You included Signal.active_record? That should be done only for AR models (which is not your case). Just use regular include Signal on PORO classes.

Yes! This error has happened before when I called Signal::ActiveRecord in 0.3.0 version

Let's start over, this time in pt-BR.
Pelo que vejo, o erro em SystemSubscribe::AddSubscriber acontece porque você está adicionando include Signal.active_record.
Na verdade, o seu código deve exatamente igual ao primeiro comentário da thread.
class SystemSubscribe::AddSubscriber
  include Signal
  attr_accessor :subscribe

  def initialize options={}
    @subscribe = Subscriber.new(options)
  end

  def call
    ActiveRecord::Base.transaction do
      return emit(:failure) unless save_subscribe
      send_subscriber_email
    end

    emit(:success, @subscribe)
  end

  private
  def save_subscribe
    @subscribe.save
  end

  def send_subscriber_email
    SubscriberNotifier.add_subscriber(@subscribe).deliver
  end
end

É isso mesmo @fnando, muito obrigado! :+1:


how to use ollama

My system has ollama server running. But I got the following error when I configure tldw to use ollama API
ollama_api_IP = http://<IP_ADDRESS>:11434/api/generate
ollama_api_key =
ollama_model = qwen2.5:7b-instruct-q5_K_M
WARNING:root:Summarization with ollama failed: Error: Invalid API Name ollama
WARNING:root:Failed to generate summary using ollama API
INFO:root:Summarization completed successfully.
ERROR:root:Summarization failed.
Any idea why this happens?
Thanks,

Thank you for opening an issue, sorry about that.
Seems I forgot to update the summarize function with ollama + custom OpenAI API endpoints.
Should be fixed now, please update and try again.

I got another error after pulling your fix:
INFO:root:process_url_with_metadata: Starting summarization with ollama...
INFO:root:Starting summarization process...
INFO:root:Ollama: Using API key from config file
Ollama: Submitting request to API endpoint
ERROR:root:Ollama: Error in processing: 'content'
Thanks,

Thanks for the update, sorry that its still not working, I refuse to use ollama, so I am doing this blind.
I've gone ahead and modified the JSON key check to look for '['message']['content']` in the response, instead of just 'content'.
That should resolve the issue, according to their docs. https://github.com/ollama/ollama/blob/main/docs/api.md
If it doesn't please let me know and I'll continue to try and figure it out.

It still doesn't work.
To verify my ollama server is OK, I use curl (below) and it works OK:
curl http://<IP_ADDRESS>:11434/api/generate -d '{                                  "model": "qwen2.5-coder:7b-instruct-q5_K_M",                                                                "prompt": "Why is the sky blue?",                                                                           "stream": false                                                                                }'
Do you verify tldw with lamma.cpp server?        If yes, I can try llama.cpp server.
Thanks,

I did not test it recently, just did, found bugs, fixed them, and pushed the changes. Llama.cpp should work for chatting now with no issues.
Did you receive the same error as before?
Can you please post the first bit of the servers response to that curl command?

Here is the error from printouts:
Ollama: Submitting request to API endpoint
ERROR:root:Ollama: Error in processing: 'content'
INFO:root:Summarization with ollama successful
INFO:root:Summary generated using ollama API
INFO:root:Summarization completed successfully.
INFO:root:process_url_with_metadata: Saving transcription and summary...
INFO:root:process_url_with_metadata: Transcription saved to: Results/Audio_Processing/The History of Toilets_transcription.txt
INFO:root:process_url_with_metadata: Summary saved to: Results/Audio_Processing/The History of Toilets_summary.txt
INFO:root:process_url_with_metadata: Keywords prepared: ['default', 'no_keyword_set']
INFO:root:process_url_with_metadata: Content updated successfully for media ID: 6. New version: 13
INFO:root:Attempting to read file: Results/Audio_Processing/The History of Toilets_summary.txt
INFO:root:Detected encoding: ascii
INFO:root:Successfully decoded file with encoding: ascii
The response of  my curl command:
{"model":"qwen2.5-coder:7b-instruct-q5_K_M","created_at":"2024-10-13T01:49:45.978756425Z","response":"The sky appears blue because of a phenomenon called Rayleigh scattering, named after Lord Rayleigh who first described it in 1871.\n\nWhen sunlight enters Earth's atmosphere, it encounters gas molecules such as nitrogen and oxygen. These molecules are much smaller than the wavelength of visible light, so they scatter the light in all directions.\n\nThe amount of scattering depends on the wavelength of the light. Shorter wavelengths (such as blue) are scattered more easily than longer wavelengths (such as red). This is because shorter wavelengths interact more strongly with gas molecules and are therefore more likely to be scattered.\n\nAs a result, when sunlight enters Earth's atmosphere, it is scattered in all directions, but the shorter wavelengths of blue light are scattered more frequently. As a result, we see the sky as blue during the day.\n\nDuring sunrise and sunset, the sun is lower on the horizon, so its light has to travel through more of the Earth's atmosphere before reaching our eyes. This causes even more scattering of the shorter wavelength blue light, resulting in a reddish or orange hue in the sky during these times.","done":true,"done_reason":"stop","context":[151644,8948,198,2610,525,264,10950,17847,13,151645,198,151644,872,198,10234,374,279,12884,6303,30,151645,198,151644,77091,198,785,12884,7952,6303,1576,315,264,24844,2598,13255,62969,71816,11,6941,1283,10214,13255,62969,879,1156,7481,432,304,220,16,23,22,16,382,4498,39020,28833,9237,594,16566,11,432,33906,6819,34615,1741,438,46403,323,23552,13,4220,34615,525,1753,9155,1091,279,45306,315,9434,3100,11,773,807,44477,279,3100,304,678,17961,382,785,3311,315,71816,13798,389,279,45306,315,279,3100,13,10698,261,92859,320,20805,438,6303,8,525,36967,803,6707,1091,5021,92859,320,20805,438,2518,568,1096,374,1576,23327,92859,16282,803,16510,448,6819,34615,323,525,8916,803,4363,311,387,36967,382,2121,264,1102,11,979,39020,28833,9237,594,16566,11,432,374,36967,304,678,17961,11,714,279,23327,92859,315,6303,3100,525,36967,803,13814,13,1634,264,1102,11,582,1490,279,12884,438,6303,2337,279,1899,382,16014,63819,323,42984,11,279,7015,374,4722,389,279,34074,11,773,1181,3100,702,311,5821,1526,803,315,279,9237,594,16566,1573,18739,1039,6414,13,1096,11137,1496,803,71816,315,279,23327,45306,6303,3100,11,12942,304,264,62144,812,476,18575,39040,304,279,12884,2337,1493,3039,13],"total_duration":77062695133,"load_duration":73682358729,"prompt_eval_count":25,"prompt_eval_duration":34378000,"eval_count":222,"eval_duration":3343166000}

Thank you, I broke down and installed ollama/set it up and verified it works with the chat and summary endpoints.
Now Ollama works. As of Commit: #353
Thanks again for the heads up about this.

I am not sure this new issue is related to the original one or not.
When I use ollama for rag search, I got this:
ERROR:root:Error in enhanced_rag_pipeline: Required inputs (['token_type_ids']) are missing from input feed (['input_ids', 'attention_mask']).

It seems it has nothing to do with ollama.
I narrowed it down whether exception occurred below:
def enhanced_rag_pipeline(query: str, api_choice: str, keywords: str = None) -> Dict[str, Any]:
# Rerank the results
reranked_results = ranker.rerank(rerank_request)
Hope it helps you to find the rootcause
Thanks

Can you please file a new issue with the full output of the console while running the application with:
python summarize.py -gui -log DEBUG
I'm unable to replicate the error you posted, as those error messages aren't in my code, and I don't see that pop up when testing either RAG pipeline with Ollama.


NCD - Subs Visit - Infrastructure [8h]

Issue
The subsequent visit for NCD is comprised of largely the same activities as the first encounter. The following activities are being carried over in the same order and with no changes:

Danger Signs
Symptom Review
Physical Exam
Family Planning
Next Steps

Changes will be happening to:

Medical History - which is switching to only outside care (see specific issue)
Labs - not all labs will be run every visit ( see #535)

To Do:

Create subsequent visit infrastructure
Pull over the activities that are not changing

There was no real need for this issue, as vast majority of infrastructure was in place alredy.
Making this a META issue.


Fix typos across fastlane repository

Checklist

[ ] I've run bundle exec rspec from the root directory to see all new and existing tests pass
[ ] I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
[x] I've read the Contribution Guidelines
[ ] I've updated the documentation if necessary.

Motivation and Context
To make Fastlane typo error-free
Description
Fixed files

I signed it!

@mollyIV Welcome!
 It would be great if it is implemented in your CI systems.


refactor(scripts): create alias on webpack for scripts and update paths

Current coverage is 100% (diff: 100%)

Merging #154 into master will not change coverage

@@           master   #154   diff @@
====================================
  Files          19     19
  Lines         320    320
  Methods         0      0
  Messages        0      0
  Branches        0      0
====================================
  Hits          320    320
  Misses          0      0
  Partials        0      0

Powered by Codecov. Last update c2ebfb4...23acaa9

We cant use aliases whenever we are providing files. It would require consumers to set the aliases as well.