HBASE-27170 ByteBuffAllocator leak when decompressing blocks near minSizeForReservoirUse

First commit fixes the leak and adds a test.
Second commit adds ResourceLeakDetector to RefCnt. It's already added at the netty layer, and is expected to be low overhead. One can disable it (along with at the netty layer) by setting -Dorg.apache.hbase.thirdparty.io.netty.leakDetection.level=DISABLED. I don't really have time to do any specific perf tests right now. I could wrap it in a special hbase.server.allocator.leakDetection.enabled config, at the cost of a few extra factory methods in ByteBuff.java and RefCnt.java. Or otherwise I could revert that commit and we can handle it in a different jira.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 21s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 28s
master passed

+1 :green_heart:
compile
2m 51s
master passed

+1 :green_heart:
checkstyle
0m 45s
master passed

+1 :green_heart:
spotless
0m 45s
branch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
1m 48s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m  7s
the patch passed

+1 :green_heart:
compile
2m 45s
the patch passed

+1 :green_heart:
javac
2m 45s
the patch passed

+1 :green_heart:
checkstyle
0m 44s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
11m 35s
Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.

+1 :green_heart:
spotless
0m 41s
patch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
1m 54s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 21s
The patch does not generate ASF License warnings.

34m 50s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4592/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4592

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile

uname
Linux 1a1fd592eddc 5.4.0-96-generic #109-Ubuntu SMP Wed Jan 12 16:49:16 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 724bf7837a

Default Java
AdoptOpenJDK-1.8.0_282-b08

Max. process+thread count
64 (vs. ulimit of 30000)

modules
C: hbase-common hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4592/1/console

versions
git=2.17.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 41s
Docker mode activated.

-0 :warning:
yetus
0m  2s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 52s
master passed

+1 :green_heart:
compile
0m 59s
master passed

+1 :green_heart:
shadedjars
4m  3s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 39s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 38s
the patch passed

+1 :green_heart:
compile
0m 57s
the patch passed

+1 :green_heart:
javac
0m 57s
the patch passed

+1 :green_heart:
shadedjars
4m  0s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 40s
the patch passed

_ Other Tests _

-1 :x:
unit
1m  7s
hbase-common in the patch failed.

-1 :x:
unit
195m 29s
hbase-server in the patch failed.

216m  3s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4592/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4592

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 4d266fe50ef7 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 724bf7837a

Default Java
AdoptOpenJDK-11.0.10+9

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4592/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-common.txt

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4592/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4592/1/testReport/

Max. process+thread count
2432 (vs. ulimit of 30000)

modules
C: hbase-common hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4592/1/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
2m 41s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m  9s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 17s
master passed

+1 :green_heart:
compile
0m 56s
master passed

+1 :green_heart:
shadedjars
3m 41s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 42s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 11s
the patch passed

+1 :green_heart:
compile
0m 56s
the patch passed

+1 :green_heart:
javac
0m 56s
the patch passed

+1 :green_heart:
shadedjars
3m 40s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 40s
the patch passed

_ Other Tests _

-1 :x:
unit
0m 53s
hbase-common in the patch failed.

-1 :x:
unit
215m 21s
hbase-server in the patch failed.

236m 34s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4592/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4592

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 2c8ea8539259 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 724bf7837a

Default Java
AdoptOpenJDK-1.8.0_282-b08

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4592/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-common.txt

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4592/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4592/1/testReport/

Max. process+thread count
2323 (vs. ulimit of 30000)

modules
C: hbase-common hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4592/1/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 40s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 20s
master passed

+1 :green_heart:
compile
2m 42s
master passed

+1 :green_heart:
checkstyle
0m 38s
master passed

+1 :green_heart:
spotless
0m 42s
branch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
1m 36s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 10s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m  3s
the patch passed

+1 :green_heart:
compile
2m 38s
the patch passed

+1 :green_heart:
javac
2m 38s
the patch passed

+1 :green_heart:
checkstyle
0m 37s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
11m 41s
Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.

+1 :green_heart:
spotless
0m 39s
patch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
1m 47s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 15s
The patch does not generate ASF License warnings.

34m 19s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4592/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4592

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile

uname
Linux f56c117e78d9 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 28 17:49:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 724bf7837a

Default Java
AdoptOpenJDK-1.8.0_282-b08

Max. process+thread count
64 (vs. ulimit of 30000)

modules
C: hbase-common hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4592/2/console

versions
git=2.17.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 47s
Docker mode activated.

-0 :warning:
yetus
0m  2s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 46s
master passed

+1 :green_heart:
compile
1m 19s
master passed

+1 :green_heart:
shadedjars
4m 17s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 51s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 33s
the patch passed

+1 :green_heart:
compile
1m 21s
the patch passed

+1 :green_heart:
javac
1m 21s
the patch passed

+1 :green_heart:
shadedjars
4m 23s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 59s
the patch passed

_ Other Tests _

-1 :x:
unit
1m 53s
hbase-common in the patch failed.

-1 :x:
unit
276m 33s
hbase-server in the patch failed.

302m 20s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4592/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4592

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 44901984e2d0 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 724bf7837a

Default Java
AdoptOpenJDK-11.0.10+9

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4592/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-common.txt

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4592/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4592/2/testReport/

Max. process+thread count
3063 (vs. ulimit of 30000)

modules
C: hbase-common hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4592/2/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 46s
Docker mode activated.

-0 :warning:
yetus
0m  2s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 23s
master passed

+1 :green_heart:
compile
1m  4s
master passed

+1 :green_heart:
shadedjars
4m 23s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 42s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m  7s
the patch passed

+1 :green_heart:
compile
1m  7s
the patch passed

+1 :green_heart:
javac
1m  7s
the patch passed

+1 :green_heart:
shadedjars
4m 31s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 40s
the patch passed

_ Other Tests _

-1 :x:
unit
1m  1s
hbase-common in the patch failed.

-1 :x:
unit
291m 12s
hbase-server in the patch failed.

314m 32s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4592/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4592

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux cfa44fc8fba8 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 724bf7837a

Default Java
AdoptOpenJDK-1.8.0_282-b08

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4592/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-common.txt

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4592/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4592/2/testReport/

Max. process+thread count
2508 (vs. ulimit of 30000)

modules
C: hbase-common hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4592/2/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 40s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 10s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m  3s
master passed

+1 :green_heart:
compile
2m 39s
master passed

+1 :green_heart:
checkstyle
0m 37s
master passed

+1 :green_heart:
spotless
0m 39s
branch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
1m 34s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 10s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m  6s
the patch passed

+1 :green_heart:
compile
2m 38s
the patch passed

+1 :green_heart:
javac
2m 38s
the patch passed

+1 :green_heart:
checkstyle
0m 38s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
11m 39s
Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.

+1 :green_heart:
spotless
0m 38s
patch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
1m 48s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 14s
The patch does not generate ASF License warnings.

33m 31s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4592/3/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4592

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile

uname
Linux 47bb764e5e4d 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 28 17:49:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 724bf7837a

Default Java
AdoptOpenJDK-1.8.0_282-b08

Max. process+thread count
64 (vs. ulimit of 30000)

modules
C: hbase-common hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4592/3/console

versions
git=2.17.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 51s
Docker mode activated.

-0 :warning:
yetus
0m  2s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 38s
master passed

+1 :green_heart:
compile
1m 21s
master passed

+1 :green_heart:
shadedjars
4m 18s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 52s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 31s
the patch passed

+1 :green_heart:
compile
1m 18s
the patch passed

+1 :green_heart:
javac
1m 18s
the patch passed

+1 :green_heart:
shadedjars
4m 26s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 54s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
2m 41s
hbase-common in the patch passed.

-1 :x:
unit
278m 38s
hbase-server in the patch failed.

305m  6s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4592/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4592

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 4bf53044e106 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 724bf7837a

Default Java
AdoptOpenJDK-11.0.10+9

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4592/3/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4592/3/testReport/

Max. process+thread count
2642 (vs. ulimit of 30000)

modules
C: hbase-common hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4592/3/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 50s
Docker mode activated.

-0 :warning:
yetus
0m  2s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m  9s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 17s
master passed

+1 :green_heart:
compile
1m  6s
master passed

+1 :green_heart:
shadedjars
4m 20s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 38s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m  6s
the patch passed

+1 :green_heart:
compile
1m 11s
the patch passed

+1 :green_heart:
javac
1m 11s
the patch passed

+1 :green_heart:
shadedjars
4m 22s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 41s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 41s
hbase-common in the patch passed.

-1 :x:
unit
292m  0s
hbase-server in the patch failed.

315m 36s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4592/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4592

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux e335fc7b09c0 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 724bf7837a

Default Java
AdoptOpenJDK-1.8.0_282-b08

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4592/3/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4592/3/testReport/

Max. process+thread count
2456 (vs. ulimit of 30000)

modules
C: hbase-common hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4592/3/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Test failures look unrelated and could not be reproduced locally. Kicked off a re-run.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 42s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 22s
master passed

+1 :green_heart:
compile
2m 45s
master passed

+1 :green_heart:
checkstyle
0m 40s
master passed

+1 :green_heart:
spotless
0m 42s
branch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
1m 42s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m  8s
the patch passed

+1 :green_heart:
compile
2m 44s
the patch passed

+1 :green_heart:
javac
2m 44s
the patch passed

+1 :green_heart:
checkstyle
0m 38s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
11m 57s
Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.

+1 :green_heart:
spotless
0m 39s
patch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
1m 48s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 15s
The patch does not generate ASF License warnings.

34m 55s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4592/4/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4592

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile

uname
Linux 599de6fe4297 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 724bf7837a

Default Java
AdoptOpenJDK-1.8.0_282-b08

Max. process+thread count
69 (vs. ulimit of 30000)

modules
C: hbase-common hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4592/4/console

versions
git=2.17.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 25s
Docker mode activated.

-0 :warning:
yetus
0m  2s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 44s
master passed

+1 :green_heart:
compile
1m  3s
master passed

+1 :green_heart:
shadedjars
3m 42s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 43s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 31s
the patch passed

+1 :green_heart:
compile
1m  4s
the patch passed

+1 :green_heart:
javac
1m  4s
the patch passed

+1 :green_heart:
shadedjars
3m 42s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 42s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 50s
hbase-common in the patch passed.

+1 :green_heart:
unit
198m  5s
hbase-server in the patch passed.

218m 48s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4592/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4592

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 7b69db5ae8e0 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 724bf7837a

Default Java
AdoptOpenJDK-11.0.10+9

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4592/4/testReport/

Max. process+thread count
3139 (vs. ulimit of 30000)

modules
C: hbase-common hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4592/4/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 20s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 31s
master passed

+1 :green_heart:
compile
0m 57s
master passed

+1 :green_heart:
shadedjars
3m 45s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 42s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 19s
the patch passed

+1 :green_heart:
compile
0m 55s
the patch passed

+1 :green_heart:
javac
0m 55s
the patch passed

+1 :green_heart:
shadedjars
3m 41s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 41s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 38s
hbase-common in the patch passed.

+1 :green_heart:
unit
219m  3s
hbase-server in the patch passed.

239m 52s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4592/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4592

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 5dd81423d6c2 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 724bf7837a

Default Java
AdoptOpenJDK-1.8.0_282-b08

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4592/4/testReport/

Max. process+thread count
2839 (vs. ulimit of 30000)

modules
C: hbase-common hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4592/4/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 37s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m  9s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m  3s
master passed

+1 :green_heart:
compile
2m 45s
master passed

+1 :green_heart:
checkstyle
0m 38s
master passed

+1 :green_heart:
spotless
0m 39s
branch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
1m 36s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 10s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m  8s
the patch passed

+1 :green_heart:
compile
2m 45s
the patch passed

+1 :green_heart:
javac
2m 45s
the patch passed

+1 :green_heart:
checkstyle
0m 38s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
11m 40s
Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.

+1 :green_heart:
spotless
0m 40s
patch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
1m 50s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 14s
The patch does not generate ASF License warnings.

34m  3s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4592/5/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4592

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile

uname
Linux 7c4b73161d83 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 724bf7837a

Default Java
AdoptOpenJDK-1.8.0_282-b08

Max. process+thread count
64 (vs. ulimit of 30000)

modules
C: hbase-common hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4592/5/console

versions
git=2.17.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 42s
Docker mode activated.

-0 :warning:
yetus
0m  2s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 10s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 36s
master passed

+1 :green_heart:
compile
1m 26s
master passed

+1 :green_heart:
shadedjars
4m 16s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 49s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 10s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 34s
the patch passed

+1 :green_heart:
compile
1m 20s
the patch passed

+1 :green_heart:
javac
1m 20s
the patch passed

+1 :green_heart:
shadedjars
4m 17s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m  5s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
2m 25s
hbase-common in the patch passed.

-1 :x:
unit
18m  7s
hbase-server in the patch failed.

43m 16s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4592/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4592

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux ee143a4cd832 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 724bf7837a

Default Java
AdoptOpenJDK-11.0.10+9

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4592/5/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4592/5/testReport/

Max. process+thread count
651 (vs. ulimit of 30000)

modules
C: hbase-common hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4592/5/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 42s
Docker mode activated.

-0 :warning:
yetus
0m  2s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 17s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 32s
master passed

+1 :green_heart:
compile
1m 16s
master passed

+1 :green_heart:
shadedjars
4m 16s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 48s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 14s
the patch passed

+1 :green_heart:
compile
1m  4s
the patch passed

+1 :green_heart:
javac
1m  4s
the patch passed

+1 :green_heart:
shadedjars
4m 23s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 39s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 55s
hbase-common in the patch passed.

+1 :green_heart:
unit
212m  7s
hbase-server in the patch passed.

236m 12s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4592/5/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4592

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 2fa0271a4d8f 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 724bf7837a

Default Java
AdoptOpenJDK-1.8.0_282-b08

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4592/5/testReport/

Max. process+thread count
2704 (vs. ulimit of 30000)

modules
C: hbase-common hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4592/5/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

So the actual leak is in HFileBlock? WHat is the root cause? Skimmed the jira description, it is not very clear to me...
Thanks.

@Apache9 here is the relevant passage for root cause:
The issue occurs when reading a compressed block which is smaller but close to the size of ByteBuffAllocator's minSizeForReservoirUse.:

We will pass intoHeap = false to fsBlockReader.readBlockData, because the block is DATA or ENCODED_DATA. As such we will use ByteBuffAllocator.
However, the block size is less than minSizeForReservoirUse, so ByteBuffAllocator will allocate an on-heap buffer (hasArray() == true)
The hasArray() value will determine whether to return an ExclusiveMemHFileBlock or SharedMemHFileBlock, in this case ExclusiveMemHFileBlock.
In HFileBlock.unpack, we will shallowClone the block, which will result in a new ExclusiveMemHFileBlock and pass along the same ByteBuffAllocator used before.
Next we call allocateBuffer, which will use the uncompressed size of the block. This new block size will be larger than minSizeForReservoirUse, so will be allocated off-heap
We'll call release() on the original block, which is a no-op because it was an ExclusiveMemHFileBlock
We'll return the unpacked block all the way up to our HFileReaderImpl/StoreFileScanner/etc
All of those upper level classes seem to properly close resources, either when the scanner is closed or when shipped() is called.
Unfortunately since it's an ExclusiveMemHFileBlock (which overloads release() to be a no-op), but backed by a DirectByteBuffer, that buffer will never properly be released back to the pool. Instead it will be GC'd, resulting in the leak.

Thanks for the detailed explaination. Looks reasonable. I wonder which commit in the history broke this...
Anyway, please give me sometime to go through the code again. The off heap reference counting is a very critical part in HBase, it may impact performance a lot with only a very little change.
I promise I will report back soon. And please kick me if I do not report back within 2 days...
Thanks @bbeaudreault for the great analysis and fix.

No problem @Apache9 , thanks for taking a look. I will say that my change in HFileBlock is actually the same operations, just in a different order (allocate buffer, then clone, rather than clone then allocate). So then the only functional change is withShared(!newBuf.hasArray()) rather than withShared(blk.isSharedMem()).
Of course the leak detection may affect performance, but I might recommend running with leakDetection.level=DISABLED in production, in which case there should be no overhead.
Hope that helps, let me know if you have any thoughts or questions when you take a look.

@Apache9 I've addressed your feedback.
I also added a new TestByteBuffAllocatorLeakDetection. I think it seems pretty brittle, but it worked locally. I am not sure this test is worth it, because I anticipate it being a potential flake in the future and also having unintended consequences due to changing the InternalLogger. But wanted you guys to have something to look at.
Let me know if that looks good to merge as is, or if you'd prefer I remove the new test. Or if any other comments.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 45s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 23s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m  4s
master passed

+1 :green_heart:
compile
2m 41s
master passed

+1 :green_heart:
checkstyle
0m 37s
master passed

+1 :green_heart:
spotless
0m 39s
branch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
1m 35s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 10s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m  9s
the patch passed

+1 :green_heart:
compile
2m 40s
the patch passed

-0 :warning:
javac
0m 29s
hbase-common generated 1 new + 151 unchanged - 0 fixed = 152 total (was 151)

-0 :warning:
checkstyle
0m 10s
hbase-common: The patch generated 1 new + 2 unchanged - 0 fixed = 3 total (was 2)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
11m 37s
Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.

-1 :x:
spotless
0m  8s
patch has 34 errors when running spotless:check, run spotless:apply to fix.

+1 :green_heart:
spotbugs
1m 52s
the patch passed

_ Other Tests _

-1 :x:
asflicense
0m 14s
The patch generated 1 ASF License warnings.

33m 22s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4592/6/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4592

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile

uname
Linux a642b88a43bf 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 28 17:49:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 724bf7837a

Default Java
AdoptOpenJDK-1.8.0_282-b08

javac
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4592/6/artifact/yetus-general-check/output/diff-compile-javac-hbase-common.txt

checkstyle
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4592/6/artifact/yetus-general-check/output/diff-checkstyle-hbase-common.txt

spotless
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4592/6/artifact/yetus-general-check/output/patch-spotless.txt

asflicense
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4592/6/artifact/yetus-general-check/output/patch-asflicense-problems.txt

Max. process+thread count
64 (vs. ulimit of 30000)

modules
C: hbase-common hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4592/6/console

versions
git=2.17.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 33s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 53s
master passed

+1 :green_heart:
compile
1m 20s
master passed

+1 :green_heart:
shadedjars
4m 13s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 58s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 28s
the patch passed

+1 :green_heart:
compile
1m 20s
the patch passed

+1 :green_heart:
javac
1m 20s
the patch passed

-1 :x:
shadedjars
1m 26s
patch has 10 errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 51s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
2m 48s
hbase-common in the patch passed.

-1 :x:
unit
279m 40s
hbase-server in the patch failed.

302m 54s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4592/6/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4592

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 9eee23a63e55 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 724bf7837a

Default Java
AdoptOpenJDK-11.0.10+9

shadedjars
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4592/6/artifact/yetus-jdk11-hadoop3-check/output/patch-shadedjars.txt

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4592/6/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4592/6/testReport/

Max. process+thread count
3028 (vs. ulimit of 30000)

modules
C: hbase-common hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4592/6/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 34s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 22s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 11s
master passed

+1 :green_heart:
compile
1m  3s
master passed

+1 :green_heart:
shadedjars
4m 23s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 40s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m  0s
the patch passed

+1 :green_heart:
compile
1m 14s
the patch passed

+1 :green_heart:
javac
1m 14s
the patch passed

-1 :x:
shadedjars
0m 54s
patch has 10 errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 47s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 54s
hbase-common in the patch passed.

-1 :x:
unit
293m 17s
hbase-server in the patch failed.

313m  6s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4592/6/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4592

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 45f5d1c7f124 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 724bf7837a

Default Java
AdoptOpenJDK-1.8.0_282-b08

shadedjars
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4592/6/artifact/yetus-jdk8-hadoop3-check/output/patch-shadedjars.txt

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4592/6/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4592/6/testReport/

Max. process+thread count
2567 (vs. ulimit of 30000)

modules
C: hbase-common hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4592/6/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 41s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 24s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 10s
master passed

+1 :green_heart:
compile
2m 44s
master passed

+1 :green_heart:
checkstyle
0m 37s
master passed

+1 :green_heart:
spotless
0m 40s
branch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
1m 37s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 10s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 10s
the patch passed

+1 :green_heart:
compile
2m 43s
the patch passed

-0 :warning:
javac
0m 29s
hbase-common generated 1 new + 151 unchanged - 0 fixed = 152 total (was 151)

+1 :green_heart:
checkstyle
0m 38s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
11m 47s
Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.

+1 :green_heart:
spotless
0m 41s
patch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
1m 49s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 14s
The patch does not generate ASF License warnings.

34m 20s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4592/7/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4592

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile

uname
Linux abb354d8ecc3 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 724bf7837a

Default Java
AdoptOpenJDK-1.8.0_282-b08

javac
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4592/7/artifact/yetus-general-check/output/diff-compile-javac-hbase-common.txt

Max. process+thread count
64 (vs. ulimit of 30000)

modules
C: hbase-common hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4592/7/console

versions
git=2.17.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 26s
Docker mode activated.

-0 :warning:
yetus
0m  2s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 10s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 30s
master passed

+1 :green_heart:
compile
1m  3s
master passed

+1 :green_heart:
shadedjars
3m 41s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 42s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 32s
the patch passed

+1 :green_heart:
compile
1m  3s
the patch passed

+1 :green_heart:
javac
1m  3s
the patch passed

+1 :green_heart:
shadedjars
3m 41s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 42s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 48s
hbase-common in the patch passed.

+1 :green_heart:
unit
198m  7s
hbase-server in the patch passed.

218m  5s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4592/7/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4592

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 38b546545a55 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 724bf7837a

Default Java
AdoptOpenJDK-11.0.10+9

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4592/7/testReport/

Max. process+thread count
3314 (vs. ulimit of 30000)

modules
C: hbase-common hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4592/7/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 46s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 23s
master passed

+1 :green_heart:
compile
0m 48s
master passed

+1 :green_heart:
shadedjars
3m 58s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 36s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 12s
the patch passed

+1 :green_heart:
compile
0m 49s
the patch passed

+1 :green_heart:
javac
0m 49s
the patch passed

+1 :green_heart:
shadedjars
3m 57s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 34s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 25s
hbase-common in the patch passed.

-1 :x:
unit
206m 58s
hbase-server in the patch failed.

226m 29s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4592/7/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4592

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 7f1b2bfd4e63 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 28 17:49:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 724bf7837a

Default Java
AdoptOpenJDK-1.8.0_282-b08

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4592/7/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4592/7/testReport/

Max. process+thread count
2587 (vs. ulimit of 30000)

modules
C: hbase-common hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4592/7/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 37s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 25s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 10s
master passed

+1 :green_heart:
compile
2m 45s
master passed

+1 :green_heart:
checkstyle
0m 37s
master passed

+1 :green_heart:
spotless
0m 40s
branch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
1m 36s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 10s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 11s
the patch passed

+1 :green_heart:
compile
2m 43s
the patch passed

+1 :green_heart:
javac
2m 43s
the patch passed

+1 :green_heart:
checkstyle
0m 38s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
11m 48s
Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.

+1 :green_heart:
spotless
0m 39s
patch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
1m 50s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 14s
The patch does not generate ASF License warnings.

34m 16s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4592/8/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4592

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile

uname
Linux d8b40876bced 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 724bf7837a

Default Java
AdoptOpenJDK-1.8.0_282-b08

Max. process+thread count
64 (vs. ulimit of 30000)

modules
C: hbase-common hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4592/8/console

versions
git=2.17.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 25s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 33s
master passed

+1 :green_heart:
compile
1m  2s
master passed

+1 :green_heart:
shadedjars
3m 41s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 41s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 34s
the patch passed

+1 :green_heart:
compile
1m  3s
the patch passed

+1 :green_heart:
javac
1m  3s
the patch passed

+1 :green_heart:
shadedjars
3m 41s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 42s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 50s
hbase-common in the patch passed.

+1 :green_heart:
unit
197m 38s
hbase-server in the patch passed.

217m 46s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4592/8/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4592

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 866a31a8f48d 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 724bf7837a

Default Java
AdoptOpenJDK-11.0.10+9

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4592/8/testReport/

Max. process+thread count
3069 (vs. ulimit of 30000)

modules
C: hbase-common hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4592/8/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 48s
Docker mode activated.

-0 :warning:
yetus
0m  2s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 24s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m  4s
master passed

+1 :green_heart:
compile
0m 48s
master passed

+1 :green_heart:
shadedjars
3m 54s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 35s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 10s
the patch passed

+1 :green_heart:
compile
0m 48s
the patch passed

+1 :green_heart:
javac
0m 48s
the patch passed

+1 :green_heart:
shadedjars
3m 54s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 33s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 24s
hbase-common in the patch passed.

+1 :green_heart:
unit
202m 29s
hbase-server in the patch passed.

221m 24s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4592/8/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4592

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 0e2a2ae73244 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 28 17:49:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 724bf7837a

Default Java
AdoptOpenJDK-1.8.0_282-b08

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4592/8/testReport/

Max. process+thread count
3948 (vs. ulimit of 30000)

modules
C: hbase-common hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4592/8/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.


rust/cctrusted_vm: enhance API tests

The current failure of test_replay_cc_eventlog_with_invalid_input is a known issue. I'll post fix for that in cc-trusted-api later.


python312Packages.autojinja: init at 1.14.1

Release: https://github.com/ldflo/autojinja/releases/tag/v1.14.1

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[x] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/4425

Why do we need this package? With 6 stars it seems pretty unpopular.


Update Localizable.strings

Description
Cross-platform consistency, ISO standards, microcopy

Codecov Report

Merging #312 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master    #312      +/-   ##
=========================================
- Coverage   11.12%   11.1%   -0.03%
=========================================
  Files         234     234
  Lines        9330    9330
=========================================
- Hits         1038    1036       -2
- Misses       8292    8294       +2

Impacted Files
Coverage Δ

...htning/Certificates/PinnedURLSessionDelegate.swift
93.1% <0%> (-3.45%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecd6c87...643565d. Read the comment docs.


skip the test temporarily,

Still investigating then test failure. Skip the test so insiders is unblocked.

Pull Request Test Coverage Report for Build 618291853

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 43.12%

Totals

Change from base Build 616505646:
0.0%

Covered Lines:
25085

Relevant Lines:
53218

💛  - Coveralls

@Charles-Gagnon I was just chatting with @MaddyDev. It may be a regression. Maybe we can run the product build against #14529.

No longer needed; culprit for integration test failures has been identified and fix merged


[ENH] - Build docker images for arm (aarch64)

Feature description
Build docker images for arm (aarch64) based machines.
Value and/or benefit
Currently conda-store is building docker images only for x86_64, which would not work for aarch64 machines. Implementing this issue will have the following benefits:

Users will be able to chose arm based images in their cloud provider to run conda-store on.
It will help developers run local deployment of Nebari (biggest consumer of conda-store) on Mac M1 (https://github.com/nebari-dev/nebari/issues/1405) or any arm based machines.

Anything else?
No response

Created a draft PR for reference: https://github.com/conda-incubator/conda-store/pull/822


KIC 2.0: Document new flags

KIC 2.0 adds new flags.
Acceptance criteria:

[x] new flags documented
[x] flag descriptions on docs.konghq.com match the flag set exposed by KIC 2.0

@mflendrich Do we have a way to generate flag values and descriptions from the code?

@mflendrich Do we have a way to generate flag values and descriptions from the code?

Yes. Running the application with --help should do it.

This is resolved in that the documentation is written, but there is a follow up for the final merge to main: https://github.com/Kong/kubernetes-ingress-controller/issues/1719

The controller enablement flags are not accurately documented now - the docs site refers to the EnablementStatus type which is no longer the case (the flags are now bools).

https://github.com/Kong/docs.konghq.com/pull/3120 makes a PR to the open PR to change the recently updates flags.


Install Error

This happens when i try npm i embed-table
One is replit and the other is another host:

Hey! Thanks for reporting this error. It will be fixed in #7 when the pull request is accepted.

Closed with #7


Make model names clearer

I initially didn't read the parenthetical and just used the model names in the table, which failed. This edit makes it clearer that the name for downloading is slightly different.

This is helpful. Thanks Jonathan!


[Feature Request] When help is the only subcommand, hide it from output

For instance here:

Or alternatively, remove it from output altogether, since it's repetitive and covered by --help:

Looks like would need to stop calling NewApp() or override Action.


Document player_force_respawn

also lined up the last column stuff (i recommend ignoring whitespace changes when diffing)

I'm gonna split up the table whitespace fix and the player_force_respawn entry addition just cause it looks nicer as two separate commits :P


WIP - Nav updates

WIP - DO NOT MERGE
The has several PRs that go with it and should be merged AFTER others.

Adds links to data-publication and tools.

Closing. In order to keep separation between the filing app and the "content" we won't include the nav here.


Update pr workflow

Codecov Report

Merging #9 (d76a35d) into main (c092cab) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main        #9   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            2         2
  Lines           61        61
  Branches        33        33
=========================================
  Hits            61        61

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95af552...d76a35d. Read the comment docs.


Input for resourcegroup in infra eraser workflow

The 'Infrastructure Eraser' workflow requires input at the start; specifically, we must input the Azure Resource Group to be deleted. If we input 'clear-all', every resource group will be deleted.
Acceptance Criteria:

[x] Input working and in place
[x]  Clear-all working

Issue closed: Input working and in place, also clear-all feature in place


Fix some issues with sign-in instructions.

Docs Build status updates of commit 0f4e0b6:
:clock10: Full build: the average full build time is 22 min(s) 22 sec(s), this is based on the last 198 build(s) for this repository.

Docs Build status updates of commit 0f4e0b6:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs-conceptual/azps-1.8.0/authenticate-azureps.md
:white_check_mark:Succeeded
View (azps-1.8.0)

docs-conceptual/azps-1.8.0/get-started-azureps.md
:white_check_mark:Succeeded
View (azps-1.8.0)

docs-conceptual/azps-1.8.0/install-az-ps.md
:white_check_mark:Succeeded
View (azps-1.8.0)

docs-conceptual/azps-2.6.0/authenticate-azureps.md
:white_check_mark:Succeeded
View (azps-2.6.0)

docs-conceptual/azps-2.6.0/get-started-azureps.md
:white_check_mark:Succeeded
View (azps-2.6.0)

docs-conceptual/azps-2.6.0/install-az-ps.md
:white_check_mark:Succeeded
View (azps-2.6.0)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Support full screen display

Description
Provide full screen mode option (via OpenSeadragon)
Done looks like

[x] User can enter full screen mode

Now supported.


[RFC] Split arangodbtests

Scope & Purpose
Adds a cmake option SPLIT_GOOGLE_TESTS. If set to On, instead of building one monolithic arangodbtests executable, multiple smaller executables (arangodbtests, arangodbtests_agency, arangodbtests_aql, ...) are built. In combination with USE_SHARED_LIBRARIES this hopefully helps to reduce development turnaround time. It also hopefully allows the Visual Studio Code gtest integration to work: before, it failed due to too many tests being in the same executable.

[ ] :hankey: Bugfix (requires CHANGELOG entry)
[ ] :pizza: New feature (requires CHANGELOG entry, feature documentation and release notes)
[ ] :fire: Performance improvement
[X] :hammer: Refactoring/simplification
[ ] :book: CHANGELOG entry made

Backports:

[X] No backports required
[ ] Backports required for: (Please specify versions and link PRs)

Related Information
Based upon https://github.com/arangodb/arangodb/pull/13688. Should be merged after.
Testing & Verification

[X] This change is a trivial rework / code cleanup without any test coverage.
[ ] The behavior in this PR was manually tested
[X] This change is already covered by existing tests, such as all of them.
[ ] This PR adds tests that were used to verify all changes:

[ ] Added new C++ Unit tests
[ ] Added new integration tests (e.g. in shell_server / shell_server_aql)
[ ] Added new resilience tests (only if the feature is impacted by failovers)

[ ] There are tests in an external testing repository:
[ ] I ensured this code runs with ASan / TSan or other static verification tools

https://github.com/arangodb/arangodb/pull/13688#issuecomment-824761644


Don’t hardcode owner, repo, and issue_number

https://github.com/smockle/action-autolabel/blob/60818f8bbf963e9cbad4f914c4a21c983177200a/src/index.ts#L39-L41
These can be read from context. Details: https://docs.github.com/en/actions/reference/context-and-expression-syntax-for-github-actions#github-context
When the action runs as a result of issue.created, we’ll have a specific issue_number; otherwise, we should iterate over every issue.

I’ll add these as optional inputs, so you can run the action against issues from any repo (i.e. not merely the repo which contains the workflow), with a fallback to context. 👍

From @smockle in https://github.com/smockle/action-autolabel/issues/5#issue-973207347:

When the action runs as a result of issues.created, we’ll have a specific issue_number; otherwise, we should iterate over every issue.

That enumerates two cases:

issues.created → single issue, and
workflow_dispatch/schedule → every issue

I’m considering supporting a third case: A subset of issues. A space-delimited list of issue numbers could be provided via inputs.issue_numbers. I’m planning another action (e.g. smockle/action-issue-filter) which would accumulate the issue numbers for issues with a specified label and provide them via outputs.

From @smockle in https://github.com/smockle/action-autolabel/issues/5#issuecomment-901136074:

I’ll add owner and repo as optional inputs, so you can run the action against issues from any repo (i.e. not merely the repo which contains the workflow), with a fallback to context. 👍

Resolved by #7

From @smockle in https://github.com/smockle/action-autolabel/issues/5#issue-973207347:

When the action runs as a result of issue.created, we’ll have a specific issue_number; otherwise, we should iterate over every issue.

The specific issue_number part of this landed in #8. I decided not to iterate over every issue in other instances, for quasi-Unix-philosophy reasons. A flexible action that can handle various inputs and can fetch other requisite data sounds nice, but I believe it’ll be frustrating to test and to use. Instead, I’ll build several single-purpose actions (e.g. a complementary smockle/action-number-issues or smockle/action-filter-issues, as proposed above), and workflows can compose them together.
From @smockle in https://github.com/smockle/action-autolabel/issues/5#issuecomment-901143765:

When the action runs as a result of issues.created, we’ll have a specific issue_number; otherwise, we should iterate over every issue.

That enumerates two cases:

issues.created → single issue, and
workflow_dispatch/schedule → every issue

I’m considering supporting a third case: A subset of issues. A space-delimited list of issue numbers could be provided via inputs.issue_numbers.

Resolved by #8

Opened https://github.com/smockle/action-autolabel/issues/9 to track next steps


Revert "[CVE Fixes] Update version of Nimbus.jose.jwt"

Reverts apache/druid#16320
Updating nimbus to version 9+ is causing HTTP ERROR 500 java.lang.NoSuchMethodError: 'net.minidev.json.JSONObject com.nimbusds.jwt.JWTClaimsSet.toJSONObject()'
Refer to https://github.com/SAP/cloud-security-services-integration-library/issues/429#issuecomment-1501601312 for more details.
We would need to upgrade other libraries as well for updating nimbus.jose.jwt

@pagrawal10 Whats other libraries need to get bumped up ?

We need to bump up druid-pac4j as well. I have created a PR for the same: https://github.com/apache/druid/pull/16567
We would need to add it as a different extension as that would not be compatible with JDK8.
pac4j versions > 5 are compatible with only JDK 11 and above
import needed is also different for pac4j v4.5.7 and pac4j v5.7.3 :
import org.pac4j.jee.context.JEEContext;
vs
import org.pac4j.core.context.JEEContext;


Please add the new Italy North region to the page

Italy North is now GA. It should be added to the first table: Azure regions to ExpressRoute locations within a geopolitical region.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: a00024b9-36f7-c9a8-4277-9360b0cd6163
Version Independent ID: aa65d869-db72-c0d8-a7e1-75a4949b6bbc
Content: Connectivity providers and locations for Azure ExpressRoute
Content Source: articles/expressroute/expressroute-locations.md
Service: expressroute
GitHub Login: @duongau
Microsoft Alias: duau

@luispb From the Product Availability page, I see only ExpressRoute Gateway is available in Italy North Region, not ExpressRoute Circuit.
Refer : https://azure.microsoft.com/en-in/explore/global-infrastructure/products-by-region/?products=expressroute&regions=italy-north

And the document to which you have raised this issue the only mentions ExpressRoute Circuit Locations.

Are you saying that ExpressRoute Circuit is available in Italy North Region?
If so, can you please let us know how you got the confirmation?

@luispb Since there are no active discussions on this thread, I shall go ahead and archive it.
Should you require any further information, please tag me and we shall reopen the thread and work with you


Ignore non API controllers for Swagger document generation

Swashbuckle requires plastering controllers/actions with
[ApiExplorerSettings(IgnoreApi = true)]
to ignore including them in document generation.
However, API controllers already typically inherit ControllerBase class while controllers with views inherti the Controller class.
Also, API controllers are most likely already decorated with the ApiController attribute.
Imo this should be enough for Swashbuckle to only pick the ones the either inherit ControllerBase and/or those the have the [ApiController] decorations.
Decorating those that we don't want included with [ApiExplorerSettings(IgnoreApi = true)] seems redundant.

What you’re looking for is including/omitting actions by convention - the convention in your case being based on the controller inheritance hierarchy. Swashbuckle is built on top of ApiExplorer, which already has a mechanism for this, and so you just need to wire up a simple ApiExplorer convention as described in the following link:
https://github.com/domaindrivendev/Swashbuckle.AspNetCore#omit-actions-by-convention

For example:
public class ApiExplorerConvention : IActionModelConvention
{
    public void Apply(ActionModel action)
    {
        action.ApiExplorer.IsVisible = action.Controller.ControllerType.BaseType == typeof(ControllerBase);
    }
}
```csharp

I ran into this in an MVC project where view controller actions were missing verbs and ran into
SwaggerGeneratorException: Ambiguous HTTP method for action - StaticPageController.Default. Actions require an explicit HttpMethod binding for Swagger/OpenAPI 3.0
So I decorated them with verbs and then those actions made up into Swagger doc. Which by default I don't think makes sense, or does it?
I wish the defaults were such that view controllers are excluded. Without having to decorate anything.
I'm not pushing this, it just makes more sense to me.

I just provided a solution that requires no decorating


Help: Colouring

Hi,
I need to put colors on each chain, which can be done with colorScheme: "chainid" but I also need to put custom colors on certain residues, which is possible via color: My_schemeId.
Imagine it like 4 chains colored via colorScheme and 10 residues from each chain are in let's say orange color.
If I put both, only "color" is active and colorScheme is ignored. In My_schemeId, the " * " coloring is not added but still no effect. I tried changing order but still color is active.
Writing custom colors for each chain is not a practical solution as chain number varies.
How can we do both?
Eg:  https://jsfiddle.net/ku1fhgrn/1/
Thank You

You could provide a custom Colormaker which implements atomColor itself, using the logic you described.
 function generateCustomSchemeID() {

          return NGL.ColormakerRegistry.addScheme(function(params) {

            var chainColors = [0xff0000, 0x00ff00, 0x0000ff] // Or whatever logic you want for these
            var residueColors = {
            	3: 0xffff00, // yellow
            	15: 0xffffff, // white..
            	14: 0xffff00,
                454: 0xffff00,
          	}

            this.atomColor = function(ap) {
              var resColor = residueColors[ap.resno]
            	if (resColor !== undefined) {

                return resColor
              }
              return chainColors[ap.chainIndex % chainColors.length] || 'grey'
            }
          })
        }

Other examples of this here:
https://github.com/nglviewer/ngl/blob/master/examples/scripts/color/custom.js

You could provide a custom Colormaker which implements atomColor itself, using the logic you described.
 function generateCustomSchemeID() {

          return NGL.ColormakerRegistry.addScheme(function(params) {

            var chainColors = [0xff0000, 0x00ff00, 0x0000ff] // Or whatever logic you want for these
            var residueColors = {
            	3: 0xffff00, // yellow
            	15: 0xffffff, // white..
            	14: 0xffff00,
                454: 0xffff00,
          	}

            this.atomColor = function(ap) {
              var resColor = residueColors[ap.resno]
            	if (resColor !== undefined) {

                return resColor
              }
              return chainColors[ap.chainIndex % chainColors.length] || 'grey'
            }
          })
        }

Other examples of this here:
https://github.com/nglviewer/ngl/blob/master/examples/scripts/color/custom.js

Thank You.
It's missing one important part.  I think I didn't put my question correctly.
You solution is great but it is coloring residues 3, 15, 14 , 454 from all chains. This is not what I need. I need let's say 3, 15 from chain A, 14 from chain B, 454 from chain C and so on. Chain A, B, C will have colors from "chainColors()" and color of the residue will be chain+residue.
Couldn't figure out how to add chain + residue combination.
NGL.ColormakerRegistry.addSelectionScheme() can take input as 3:A, 15:A, 14:B, 454:C but that's now what is used here
Thank You

Something like (untested)
 function generateCustomSchemeID() {

  return NGL.ColormakerRegistry.addScheme(function(params) {

    var chainColors = [0xff0000, 0x00ff00, 0x0000ff] // Or whatever logic you want for these
    var residueColors = {
      A: {
        3: 0xffff00, // yellow
        15: 0xffffff, // white..
      },
      B: {
        14: 0xffff00
      },
      C: {
        454: 0xffff00,
      }
    }
    this.atomColor = function(ap) {
    var resDict = residueColors[ap.chainname]

    var resColor = resDict && resDict[ap.resno]
    if (resColor !== undefined) {
      return resColor
    }
    return chainColors[ap.chainIndex % chainColors.length] || 'grey'
    }
  })
}

So this can be mixed with previous discussion. I will have different chain colors and mousehover change will not be slow?

I think that the performance issue is around speed of testing a large selection object, this side-steps that by replacing the (very general, complex) selection testing code with a minimally hard-coded bit of javascript for your specific use-case. Something like the above should be pretty performant.

Yes. I selected bigger structure so that if this works other structures will definitely work. With your function , changing color is without any performance issue.
I can understand what you did here, but the color is not changing.
https://jsfiddle.net/bophregz/4/
And on mousehover the chain colors are lost.
This is the main question.
How to color chain wise and highlight certain residues with different colors.
The topmost question here seems to be misleading. That's why I posted in other issue.

Right, so I think this is a bit confusing because there are two different ways to do this, and you can only have 1 colormaker assigned to the structure. When your example loads it uses my snippet above (custom atomColor), but when you mouseover it switches to selection based approach (which completely replaces the previous colormaker)
So, you need to choose one of the following:

Use selection colormaker (optionally including the getAtomSet for improved performance)
Completely custom colormaker where you implement atomColor yourself (in whatever way you choose)

1: The link above (https://jsfiddle.net/bophregz/4/) implements the first of these, but as you say only applies the info in colorData, you can add further rules (you currently specify rules for red and blue). If you look at this example: https://github.com/nglviewer/ngl/blob/master/examples/scripts/color/selection.js you can see rules get applied first to last and the first match applies the color, so you can have your red and blue rules followed by chain rules (i.e. default colors for those not explicitly set).
2: To do it with custom colormakers you'd have to rewrite my above snippet (https://github.com/nglviewer/ngl/issues/822#issuecomment-808106933) to take colorData as an argument and use it approriately in the logic in the colorMaker. This will give you the best performance, but it requires a bit more work on your part

OK. Will try.
But please keep this as TODO in mol* or maybe next version of ngl (if still developing).
This kind of user case is really common in my lab, and other labs we collaborate with.
Thank You

ps - I'm not associated with the mol* project at all (though it is a great product) but you can try asking on their issue tracker - I'm not familiar with their API so can't comment on how much easier or harder it would be to do there.
The TODO here I think is to fix performance in the selection mode (it's a simpler way to write the rules than implementing atomColor in your own Colormaker)


Support for Kafka 4.0

This proposal covers how Strimzi should handle the support for Kafka 4.0 and the removal of ZooKeeper support in Apache Kafka. Please have a look and let me know.

One question: Have we considered to jump the version number to 1.0.0 for 0.4z release to clearly let users know there's a gap between the 2 releases?

@showuon From my point of view ... Once we are fully on KRaft and Kafka 4.0, we need to start working on the v1 API. That would be the point to start discussing 1.0.0. If we did 1.0.0 now, we would have a breaking change soon after. If there is a general view that we should give some gap to better distinguish the versions, we could for example do something like 0.100.x etc. But I didn't think that was needed.

This now has 4 binding and 4 non-binding votes. If nobody comments until Wednesday (or requests more time), I will proceed and close this.

Approved with 5 binding and 4 non-binding +1 votes.


Fix framework moniker in project files

#27 updated to .NET 6; however, I missed updating the target framework in the project files. The net effect is that it's being built by .NET 6, and run on .NET 6, but targeting .NET 5 behavior and APIs. Change that.
Also, while changing the project files, switch the deployment to publish a single file, rather than all the DLLs together; this will simplify deployment.

Fixed in 2.2.1


onInstallConversionData not working, failure with "The data couldn’t be read because it isn’t in the correct format."

Report
Plugin Version
6.1.20
react-native: 0.63.3
On what Platform are you having the issue?
iOS & Android
What did you do?
rm -rf Pods/
pod install
What did you expect to happen?
onInstallConversionData not triggered
What happened instead?
onInstallConversionFailure returns:
{
status: "failure"
type: "onInstallConversionFailure"
data: "The data couldn’t be read because it isn’t in the correct format."
}
Please provide any other relevant information.
At 24.12.2020 in 13:10 (UTC-0) it's stop working, in released in store build too (they stopped sending data to server on onInstallConversionData event)

Zero tariff quotas have been exhausted... No notifications either in the appsflyer dashboard or in the mail

@kshport did you figure this out? we're seeing the same issue.

@jetaggart check appsflyer's quotas, they are most likely exhausted


no codegen import in ops [pr]

This isn't better. It's also still imported for type checking

Much better

Feel free to merge when you are ready


If a plugin is enabled all global classes are erase from project file

Godot version
3.3.3
System information
Windows 10
Issue description
So basically, as the title says, when i enable a custom plugin and i close a project every global class defined in the project settings disappear and when i re-open the project i get a wall of errors about scripts unable to find that class.
Important

The plugin is made by me.
The plugin add both a dock and a fullscreen scene.
Scripts that define these classes still exist.
After the errors the classes works normally and can be found by scripts.
Most of the errors are about tool scripts that execute stuff when the editor is opened.

Analysys
When i disable the plugin and close the project, the project file (project.godot) contain all class definitions.
When i enable the plugin and close the prohect, the project file (still project.godot) erase all class definitions and every other settings are untouched.
I've tried to download some random plugins to see if the same error happen and yes, even if i enable a single plugin it erase all the classes.
Conclusion
Now everytime i close the project i first disable the plugin, the error messages does not appear and all classes are not erased.
Idk, if is the current version of godot that give me this problem (i've recently upgraded from 3.3.2) or some bugs inside the plugin or project itself.
Extra
Here the project file when i close the project after enabling/disabling the plugin.
Everything after config_version and before [application] disappear.

Steps to reproduce
This is how i get this problem:

Make a global class
Make some scripts that use that class
Make a custom plugin
Enable the plugin
Close the project
Open the project
See errors

Minimal reproduction project
Here the project:
ConfigBox-pluginbug.zip
When opened it should show like 5 errors in the output about classes that does not exist.
If you run the project everything works normally (no more errors).

This has a good chance to be caused by Windows file locking limitations. This would be one more reason to move the global class definitions outside of project.godot: