Floating point rounding issues

Could counter_culture support decimal fields, and, if so, support a precision: ... option to ensure that values are rounded to the scale and precision of the field?
We're trying to get rid of floats because of rounding issues we've had calculating pricing and we use counter_culture for summing the total cost of things

If you're working with dollar amounts, I'd recommend using the money gem and storing cents. That being said, I'd be happy to look at a PR that added float and precision support to counter_culture. But it won't be something I'll be able to work on myself.


Native Experience - Restart kernel should prompt

In case the user made a mistake.
AND/OR
Implement Undo (:D)

Hey @greazer. Currently it defaults to a prompt and then asks you if you would like to be prompted in the future or not. Sounds like you clicked no at some point? The setting is Python -> Data Science -> Ask For Kernel Restart

@greazer. This currently respects the same setting as interactive window. Python -> Data Science -> Ask For Kernel Restart.


Fix compiling mruby-io on msc with UTF8 enabled

PR merged. Thank you!

Sorry, my confirmation wasn't enough.
The current MinGW seems to define ssize_t only if there is a special preprocessor definition in advance.
Therefore, I think this PR is generally okay.
However, Legacy MinGW on FreeBSD had its own ssize_t.
Also, maybe MinGW-w64 also has its own.
I about this will issue a new PR.


docs: is there a replacement for the mapState utility?

First of all, awesome work, super useful.
I successfully migrated Nuxt 2 stores using your library. I'm able to use $accessor but I feel like using state variable in components should be simplified. (eg: $accessor.submodule.property -> property). I've done that using mapState before using typed-vuex:
export default Vue.extend({
    computed: {
        // here is the magic
        ...mapState('submodule', ['property']),
    },
})

But we loose the type of the freshly computed property property. Is there a way to keep this sugar syntaxe (not redefine every computed property, aka keep an utility for this) without loosing the types?
I think this should be documented in a new computed properties section?

This would be quite a nice feature to add; PRs welcome!

It you could point me to the right direction, I would make it with pleasure !
However, I'm not a Typescript Guru.
I've looked into the mapState function utility from VueX, it's quite simple : https://github.com/vuejs/vuex/blob/7651d506e473886984eab625797477d63bc69981/src/helpers.js#L9
But untyped 😭
I'd like to have the same typed utility, like the first parameter is optional and useful for targetting a submodule, hence, the type should be keyof AccessorType? But it look like it's not working this way:
type AccessorType = typeof accessorType

// this type is = to any
type ModuleKeys = AccessorType[keyof AccessorType];

const mapAccessor = (key: ModuleKeys) => {
  // key is any here
}

This was a great idea - thank you! Should be usable in v0.3.0...


Appearance problem with ko-fi button and dark theme

Expected Behavior

The button should render correctly
Current Behavior

This button has an extra rectangular white background.
Possible Solution

This is obviously related to either the recent dark theme implementation in Toha, or the ko-fi integration but I have not looked into it more specifically.
Steps to Reproduce

Navigate to a page using Hugo Toha theme
Change to the dark theme if not already set
Reload the page if you had to change from the light theme to the dark theme
Now you should see the result like my screenshot below

Screenshots

Can be tested on my site at  korhonen.cc Ko-fi button not available anymore
Browsers Affected

[x] Chrome
[x] Firefox
[ ] Edge (not tested)
[ ] Safari 11 (not tested)
[ ] Safari 10 (not tested)
[ ] IE 11 (not tested

Don't see Ko-fi button on your site.

Sorry, I just looked into the law in my country and apparently it is not legal to collect money here, so I had to remove it. Can we perhaps add a button to the demo site of Toha? I don't know if a dummy account would work though.

Ok. I will check.

You may reproduce this error in my site: https://www.pablomarcos.me/
Codeberg repo: https://codeberg.org/FlyingFlamingo/pablomarcos-me

Looks fine to me.

Hum! Weird. Could you try on Firefox?
------- Original Message -------
El lunes, 8 de agosto de 2022 a las 06:03, Emruz Hossain 'notifications at github.com' @.***> escribió:

Looks fine to me.
image
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.Message ID: @.***>

I forced the dark theme from the menu and was able to reproduce it on Firefox Android.
Can't seem to reproduce using a Chromium based browser (FOSS Browser)

Btw on Firefox Android, if I leave the website theme on auto and change my phone theme to dark, the dark theme seems to work properly even after page reloads.

Look like something is broken. Lot's of error log. I have to take a look.

Any progress on this?
Sometimes change to dark mode will not show up white block but console still have that error log.

Hi @Yomisana. Sorry to disappoint. Not getting time to work on this issue. Going through some tough time.


Change Formatter.Where to .Partition w/ exporter query updates

This PR changes the Formatter interface by replacing Where (which returned a complete SQL WHERE clause) with Partition (which now returns only a partition identifier, that the SQL template can use as needed).
This change is in service of optimizing the query in annotation/exports/tcpinfo_annotation_export.sql to date-limit ranges in both the annotation and tcpinfo tables. With this change, typical dates only need to scan ~30-40GB (vs 400GB without date filters).
The consequence of this change is that the partition id (e.g. "shard" for statistics exports, and "date" for annotation exports) is a single parameter to the export query template. Before the Where method was returning an SQL clause, which makes reasoning about and optimizing the SQL export query more difficult or impossible. With this change, more of the actual SQL is present in the export query.
This change updates all uses of the {{ .whereClause }} in the annotation/exports and statistics/exports queries. Because only the partition ID is passed to the query template, the histograms and exports queries must agree on the partition column name, e.g. "shard".
FYI: @robertodauria

This change is

Pull Request Test Coverage Report for Build 117

6 of 14 (42.86%)  changed or added relevant lines in 3 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.2%) to 62.443%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

exporter/exporter.go
0
8
0.0%

Files with Coverage Reduction
New Missed Lines
%

formatter/annotation.go
1
94.74%

Totals

Change from base Build 115:
-0.2%

Covered Lines:
414

Relevant Lines:
663

💛  - Coveralls


Please add Overseerr support

Describe the feature you would like to see
please add Overseerr support https://github.com/sct/overseerr to show movie requests
Priority
Medium (Would be very useful)

@Famku Thank you for the suggestion ! Overseer would be a great addition. However, it might be a little more tricky because of all the dynamic data overseer requires.
Maybe you can help me and list the interesting api routes in this issue so I could try to make a Proof of Concept with the data you provide.
I think we need :

[ ] Autocomplete results from the search bar
[ ] A way to add a media

Here you can find the API:
https://api-docs.overseerr.dev/
I think get /request will show also poster_path of new requests
You might take a look on Organizr who already have this feature:
https://github.com/causefx/Organizr/blob/v2-master/api/homepage/overseerr.php

If Overseer is going to be added, can you add Jellyseerr as well? https://github.com/Fallenbagel/jellyseerr

If Overseer is going to be added, can you add Jellyseerr as well? https://github.com/Fallenbagel/jellyseerr

Jellyseerr looks really promising ! Imo it should be a part of Overseerr. Might add it later depending on how different the API is. We could probably contact the developer to tell them about our integration 😊 / Get them to help

Done with https://github.com/ajnart/homarr/releases/tag/v0.9.1


Problem Upserting records with composite (object) Ids

using the driver with WS engine:
SurrealDb.Net.Exceptions.SurrealDbException : There was a problem with the database: Found 'TestRecords:{"x":"xx","z":"zz"}' for the id field, but a specific record has been specified
public class TestRecord : Record {
    public string TestA { get; set; }
    public string TestB { get; set; }
    public string TestC { get; set; }
}
...
var testRecordResult = await surrealDbClient.Upsert(new TestRecord {
        Id = Thing.From("TestRecords", new { x = "xx", z = "zz" }),
        TestA = "Something",
        TestB = null,
        TestC = "SomethingElse",
    }, CancellationToken.None
);

yields the following problem:
SurrealDb.Net.Exceptions.SurrealDbException : There was a problem with the database: Found 'TestRecords:{"x":"xx","z":"zz"}' for the id field, but a specific record has been specified
I've noticed the same issue with the HTTP engine:
PUT http://localhost:8000/key/TestRecords/{"x":"xx","z":"zz"}
with body
{
    "id": "TestRecords:{\"x\":\"xx\",\"z\":\"zz\"}",
    "TestA":"xxxx",
    "TestB":null,
    "TestC":"xxxxx"
}

does not work
but with body
{
    "id": "TestRecords:{'x':'xx','z':'zz'}",
    "TestA":"xxxx",
    "TestB":null,
    "TestC":"xxxxx"
}

does work,
so this seems like a serialization issue when escaping strings of Ids that are objects?

Hello @erancahana
This is indeed an issue with how the id is currently serialized.
FYI, this issue will be gone in the next version of the library. Until then, the best alternative to do what you want is to write a Query by hand.


Replace sed -r with sed -E

Several scripts use sed -r to use extended regular expressions.
However, this option is not available in BSD sed.
Also GNU sed recommends to use -E option instead of -r option:
$ sed
...
  -E, -r, --regexp-extended
                 use extended regular expressions in the script
                 (for portability use POSIX -E).
...

This request just replaces sed -r with sed -E in the scripts.

@tom-tan Thanks!!


CodeLens become inactive after Webview is open

Type: Bug
When Webview is open with ViewColumn.One, Codelenses become inactive (codelenses don't change color when hovered, nothing happens when codelense is clicked).
To reproduce, launch extension sample: https://github.com/ak1394/vscode-extension-samples/tree/main/webview-sample
(This is a combination of webview-sample and codelens-sample from vscode-extension-samples)

Enable code lenses with the 'CodeLens Sample: Enable CodeLens' command
Create empty file, type something in there and observe code lens shown and it, and that it active and works
Open 'Cat Coding' webview with the 'CatCoding: Start cat coding session' command
Switch back to the file created in step 1 and observe that codelens doesn't work anymore.
Close cat coding webview or move it into a second column, codelense begins to work.

 Please let me know if you require any additional info. Also, I didn't mention it in the original report but I have tried it with extensions disabled and experienced the same issue.

Is there a logical conflict between WebView and CodeLens? @mjbvz

@mjbvz  can I take this one or is someone else working on it?

any news on this?

BTW, it doesn't have to be a WebView open by an extension to cause this. I can open VS Code "Settings" pane, and while it's open, none of the CodeLenses are clickable.

This can be reproduced easily (I think all newer vscode versions are impacted )
P.S: all extensions are turned off

Any update on this? We seen to be experiencing the same issue with our extension that adds custom CodeLenses to a new file type we're working on.

I have submitted a PR to fix this.


Cannot recreate database

I had a database, but wanted to start from scratch. So I deleted all Migrations and deleted the DB in sqlsrver (in Azure) '. I deleted the Migrations and created a new initial migration. Then I did a database update. It tells me the databse does already exist. (but I cannot see it in SQL studio). Here the commands I tried:
Windows PowerShell
Copyright (C) Microsoft Corporation. All rights reserved.
PS C:\WINDOWS\system32> cd D:\Users\Ben\Source\Repos\Xpndr\EF
PS D:\Users\Ben\Source\Repos\Xpndr\EF> dotnet ef database drop
Are you sure you want to drop the database 'xpndr' on server 'tcp:quadronc.database.windows.net,1433'? (y/N)
y
Entity Framework Core 2.1.1-rtm-30846 initialized 'XpndrContext' using provider 'Microsoft.EntityFrameworkCore.SqlServer' with options: CommandTimeout=600
Dropping database 'xpndr'.
Database 'xpndr' did not exist, no action was taken.
PS D:\Users\Ben\Source\Repos\Xpndr\EF> dotnet ef database update
Failed executing DbCommand (10,268ms) [Parameters=[], CommandType='Text', CommandTimeout='600']
CREATE DATABASE [xpndr];
System.Data.SqlClient.SqlException (0x80131904): Database 'xpndr' already exists. Choose a different database name.
   at System.Data.SqlClient.SqlConnection.OnError(SqlException exception, Boolean breakConnection, Action`1 wrapCloseInAction)
   at System.Data.SqlClient.TdsParser.ThrowExceptionAndWarning(TdsParserStateObject stateObj, Boolean callerHasConnectionLock, Boolean asyncClose)
   at System.Data.SqlClient.TdsParser.TryRun(RunBehavior runBehavior, SqlCommand cmdHandler, SqlDataReader dataStream, BulkCopySimpleResultSet bulkCopyHandler, TdsParserStateObject st
   at System.Data.SqlClient.SqlCommand.RunExecuteNonQueryTds(String methodName, Boolean async, Int32 timeout, Boolean asyncWrite)
   at System.Data.SqlClient.SqlCommand.InternalExecuteNonQuery(TaskCompletionSource`1 completion, Boolean sendToPipe, Int32 timeout, Boolean asyncWrite, String methodName)
   at System.Data.SqlClient.SqlCommand.ExecuteNonQuery()
   at Microsoft.EntityFrameworkCore.Storage.Internal.RelationalCommand.Execute(IRelationalConnection connection, DbCommandMethod executeMethod, IReadOnlyDictionary`2 parameterValues)
   at Microsoft.EntityFrameworkCore.Storage.Internal.RelationalCommand.ExecuteNonQuery(IRelationalConnection connection, IReadOnlyDictionary`2 parameterValues)
   at Microsoft.EntityFrameworkCore.Migrations.Internal.MigrationCommandExecutor.ExecuteNonQuery(IEnumerable`1 migrationCommands, IRelationalConnection connection)
   at Microsoft.EntityFrameworkCore.SqlServer.Storage.Internal.SqlServerDatabaseCreator.Create()
   at Microsoft.EntityFrameworkCore.Migrations.Internal.Migrator.Migrate(String targetMigration)
   at Microsoft.EntityFrameworkCore.Design.Internal.MigrationsOperations.UpdateDatabase(String targetMigration, String contextType)
   at Microsoft.EntityFrameworkCore.Design.OperationExecutor.OperationBase.Execute(Action action)
ClientConnectionId:23cd098c-4ee5-4c8f-ae5a-f9ed3fbb8e24
Error Number:1801,State:1,Class:16
Database 'xpndr' already exists. Choose a different database name.
PS D:\Users\Ben\Source\Repos\Xpndr\EF>

So it cannot find it when deleting, but when creating it says it is already there.
Trying this in SQL studio: CREATE DATABASE [xpndr];
Same Error. But the Database is not there.
Checking the Azure portal, the database is not visible in the list of databases, but it is visible in the deleted databases (3 times, I did delete and recreated it successfully before).

@geedsen can you try connecting to the database and creating it again without using EF Core? It looks like what you are seeing is Azure SQL Database behavior, independent of EF Core. Our hypothesis is that it is just taking a long time for Azure SQL Database to update its internal state to reflect the fact that the database does not exist anymore.

EF Team Triage: Closing this issue as the requested additional details have not been provided and we have been unable to reproduce it.
BTW this is a canned response and may have info or details that do not directly apply to this particular issue. While we'd like to spend the time to uniquely address every incoming issue, we get a lot traffic on the EF projects and that is not practical. To ensure we maximize the time we have to work on fixing bugs, implementing new features, etc. we use canned responses for common triage decisions.


PERF: use uniqueness_check from monotonic check when possible

closes #14266

@ssanderson @llllllllll
can you give this a check (ideally you can perf test this as well)......

Is this big enough to warrant a second release candidate? (you have a better understanding for how big a change this is).

@TomAugspurger well our entire test suite passes, so I don't think this is a big deal as not changing  functionaility (this is almost a bug fix).

some nice perf improvements as well (note these are backwards, in that a7469rc9 is master)
  [9ced5d50] [a7469cf9]
+   14.98μs    54.75ms   3656.26  indexing.series_getitem_scalar.time_series_getitem_scalar
+   30.83μs    54.60ms   1770.70  indexing.series_ix_scalar.time_series_ix_scalar
+   50.48μs    52.97ms   1049.33  indexing.series_loc_slice.time_series_loc_slice
+   54.64μs    53.11ms    972.14  indexing.series_ix_slice.time_series_ix_slice
+    2.21ms    56.38ms     25.52  timeseries.timeseries_large_lookup_value.time_timeseries_large_lookup_value
+    1.36ms     4.17ms      3.08  timeseries.timeseries_datetimeindex_offset_delta.time_timeseries_datetimeindex_offset_delta
+  231.80μs   514.32μs      2.22  timeseries.datetimeindex_add_offset.time_datetimeindex_add_offset
-    3.45ms     1.50ms      0.43  index_object.index_datetime_set_difference.time_index_datetime_difference_disjoint
-   51.35ms    21.71ms      0.42  frame_methods.frame_getitem_single_column.time_frame_getitem_single_column
-  312.45μs   129.48μs      0.41  timeseries.timeseries_asof_single.time_timeseries_asof_single
-  239.91μs    92.65μs      0.39  index_object.datetime_index_union.time_datetime_index_union
SOME BENCHMARKS HAVE CHANGED SIGNIFICANTLY.

@ssanderson if you could test out would be great.

Current coverage is 85.25% (diff: 100%)

Merging #14270 into master will decrease coverage by <.01%

@@             master     #14270   diff @@
==========================================
  Files           140        140
  Lines         50568      50568
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
- Hits          43112      43110     -2
- Misses         7456       7458     +2
  Partials          0          0

Powered by Codecov. Last update a7469cf...443d5e3

@jreback I'll take a look shortly.

This change looks good to me, not sure if I can easily test zipline with this though. Running the memory usage example from the issue shows the memory usage pretty constant across the get_loc call. Thanks for the really quick fix!

I'm installing this into a fresh zipline build to see if it runs (there may
be upgrade work that needs to happen to be compat with 0.19, so if that
doesn't work I'll probably just confirm the minimal repro case as well.)
On Wed, Sep 21, 2016 at 1:55 PM, Joe Jevnik<EMAIL_ADDRESS>wrote:

This change looks good to me, not sure if I can easily test zipline with
this though. Running the memory usage example from the issue shows the
memory usage pretty constant across the get_loc call. Thanks for the really
quick fix!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/pydata/pandas/pull/14270#issuecomment-248691100, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABg8hf0Wb0pogI1wR6RgrZFbCKUhloBPks5qsW-IgaJpZM4KCxuk
.

LGTM.  Thanks for the quick turnaround @jreback.


Check only changed lines

Hi,
We are running php-cs-fixer in a Gitlab CI job like this:
php-cs-fixer fix --config=.php_cs.dist --verbose --dry-run --using-cache=no \
    --path-mode=intersection --diff -- $(git diff --name-only \
        --diff-filter=ACMRTUXB HEAD~..HEAD)

This is working great, but checks all lines of all changed files between commit range HEAD~..HEAD.
Is there a way to limit php-cs-fixer to report only violations of changed lines?

Have you seen https://github.com/FriendsOfPHP/PHP-CS-Fixer#using-php-cs-fixer-on-ci?

Yes, that checks changed files between commit range $COMMIT_RANGE just fine, but we need to limit that further to changed lines.
Any idea how to do that?

Hi,
The tool works on a file level scope and it would be incredibly hard to work on line level as some of the rules move lines around, remove lines and/or insert lines, etc.

@slashsbin did you ever find a solution for checking only changed lines?

@slashsbin did you ever find a solution for checking only changed lines?

command: php ./vendor/bin/php-cs-fixer fix --using-cache=no --config .php-cs-fixer.dist.php  --diff --allow-risky=yes --path-mode=intersection -- $(git diff --name-only  --diff-filter=ACMRTUXB $(git cherry origin/master | head -1 | awk '{print $2}')..HEAD)
or alias:
# /etc/bash.bashrc

function ff(){
	php ./vendor/bin/php-cs-fixer fix --using-cache=no --config .php-cs-fixer.dist.php  --diff --allow-risky=yes --path-mode=intersection -- $(git diff --name-only  --diff-filter=ACMRTUXB $(git cherry origin/master | head -1 | awk '{print $2}')..HEAD)
}
export -f ff

@tyd no not really. and my understanding is that this is not possible with the current implementation.
The tool, by design, looks at the PHP files in a single context as a whole thing.


Arbitrary Message Signing

We have a proposal from Vacuum Labs that needs review and approval.
Arbitrary message signing Ledger feature proposal:
JS interface:
signMessage(message, path, options)

message: message to sign in hex
path: derivation path in form, e.g. m/44'/539'/0'/0/0 (the same as for sign call)
cryptoOptions: a number encoding hash function and curve used (the same as for sign call)
Return value (the same as for sign call):
A dictionary with following fields
returnCode: number,
errorMessage: string,
signatureCompact: Buffer/null,
signatureDER: Buffer/null,

Behavior:
The behavior depends on the message length and content. As it is infeasible for the client to review large number of screens we define MAXIMUM_SCREENS=15 (You can modify this constant if another value suits is better for you). Screens are described as for NanoS, NanoX ans NanoS+ will have slight modifications due to larger screen size.
If the length of the message length is less than 34xMAXIMUM_SCREENS bytes and it contains only ASCII characters between 32 and 127 (printable ASCII characters), then we will display the message. We will use the same approach as transaction signing uses - we will use flash disc to store the whole message and then the user will be able to review the message content as follows:
Screen 1 to k:
key: "Message (1/k)"
value: 34 bytes of the message
Screen k+1
key: APPROVE
Screen k+2
key: REJECT
In expert mode there will be additional screen showing derivation path, hash function, and curve used.
Otherwise, we will just calculate the rolling hash of the message and show it to the user.
Screen 1:
key, value: "Calculate the message hash on secure device"
Screen 2
key: "Message hash (1/2)"
value: message hash in hex, characters 1-34
Screen 3
key: "Message hash (2/2)"
value: message hash in hex, characters 35-64
Screen 4
key: APPROVE
Screen 5
key: REJECT
In expert mode there will be additional screen showing derivation path, hash function, and curve used.
Reasoning:
If the message is arbitrary and long, it is infeasible to show the user the whole message in any representation. The need of computing the hash on a secure device (or at least separate device - which makes it way harder to perform an attack using a compromised client) is very inconvenient from the user perspective. This also creates security concerns as users may ignore this request and then they are vulnerable to attack by compromised client, however there is very little else that we can reasonably do in this case. That is why we try to show the message whenever it is reasonable.

Just for completeness. Message input parameter is WITHOUT domain tag. The signed message will be signed with "FLOW-V0.0-user" (+ 0 bytes up to domain tag length) prefix. Thus this functionality cannot be misused to sign non-messages.

Otherwise, we will just calculate the rolling hash of the message and show it to the user.

I think this is bad idea from security perspective.

@bluesign Thanks for feedback. Showing only hash to the user is of course not optimal from the security point of view. But if the thing to sign is arbitrary there is not much we can do. Are you suggesting that we should only sign messages with displayable ASCII characters that are reasonably short (hashes are like this when given in hex)? If this would e sufficient, it would be definitely superior from security point of view.

@relatko exactly, there is no use case for user signing thats doesn’t work with cleartext.
If some dapp for some reason want to sign an arbitrary data, let them send the cleartext hash and sign it. For them nothing will change. (User will see the same hash anyway)
But it changes responsibility and threat model. It prevents malicious dapps to abuse this behavior (as I stated in my example, probably there can be a lot of more )
Also this can lead people to use user signing as intended.

Proposal looks good to me for our needs. From a usability point of view it makes sense to limit the number of screens the user would have to scroll through. Therefore I'd suggest limiting MAXIMUM_SCREENS to a smaller number (e.g. 4-6). However, fair argument that this should be on the dapps to not have cumbersomely long messages to sign. TLDR looks good


Start a new application button

This PR moves the Enter CRN form from the applications dashboard to its own page, accessible (for now) only from the applications dashboard.
It also refactors integration tests to be more in line with BDD (feedback v welcome).
Before

After

 Start a new application button


Fix transform elements incremental

Caused a bug in moving in/out horizontally

Codecov Report

Merging #121 (b922854) into master (9a2da84) will decrease coverage by 2.58%.
The diff coverage is 5.26%.

@@            Coverage Diff             @@
##           master     #121      +/-   ##
==========================================
- Coverage   59.43%   56.85%   -2.59%
==========================================
  Files          17       17
  Lines         424      445      +21
  Branches       71       73       +2
==========================================
+ Hits          252      253       +1
- Misses        142      162      +20
  Partials       30       30

Impacted Files
Coverage Δ

packages/dnd/src/Droppable/Droppable.js
0.00% <0.00%> (ø)

packages/dnd/src/Draggable/Draggable.js
46.66% <13.33%> (-7.31%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a2da84...b922854. Read the comment docs.

Nee to re-define leaving in case dragged left from the end of the list and it is released. What's the best movement? Currently, it rolls back all movements. But maybe it should preserve all transformation settling dragged in the end.


[C++] Prediction fails when data includes 'object' feature

Hi all,
I trained a multi-class classification model with python API. However, predict with C API did not work. I think it is the input data that led to this problem.
In my case, train and test data include object columns. Python package 'pandas' can easily transform object to category. When it came to   C API, it is hard to process the test data.
Any solutions?
Thanks,
Leed

Hey @leedchou, thanks for using LightGBM. The C API only handles floats. When you use categorical features in Python they get translated to their numeric representation. https://github.com/microsoft/LightGBM/blob/074b3e885503dfcb12a05268d6f4169054b15264/python-package/lightgbm/basic.py#L813
So you can extract the mappings of the categorical features from your dataframe and use that in your C application, e.g.
mappings = {
    col: {val: enc for enc, val in enumerate(dtype.categories)}
    for col, dtype in df.dtypes.items() if isinstance(dtype, pd.CategoricalDtype)
}

where df is your training dataframe.
Please let us know if you have further doubts.

Thank you @jmoralez very much for quick reponse, that is helpful.


Add features for system compatibility proposed by google (#14)

Alternative links can system now be added using a pattern and languages.
Changes are made to get compatibility with google requirements.

Seems to be abandoned.


Upgrade Clients Compatibility to v0.10

This PR pulled in all commits from upstream Kafka.  Further details below in sections on sub-modules:
Clients
The necessary modifications to enable MapR Streams compatibility in the clients sub-module were made.  All Kafka unit tests pass.  When unit-tests were run with MapR (using the MapR Sandbox), there were 4 failures due to differences in the API's.  These should probably be investigated to ensure compatible behavior between OSS Kafka and MapR.  Additionally, there are a few tests using Producer or Consumer test constructors that should be retrofitted to test for MapR.
To run the unit tests to Streams, ensure there is a MapR Client with necessary privileges running on the machine and run the tests with:
./gradlew -DtestMapr=true :clients:clean :clients:test

The below chart shows additional changes needed in the Native Code and/or the com.mapr.streams:mapr-streams jar:

Issue
kafka-clients (TODO's in PR)
mapr-streams
Native Code

1
org/apache/kafka/clients/consumer/ConsumerRecord#98   - Update assignments for added fields
com/mapr/streams/impl/listener/MarlinListener#197   - Use ctor w/ additional fields
Add support for additional fields: timestampType, checksum, serializedKeySize, serializedValueSize

2

com/mapr/streams/impl/listener/MarlinListener com/mapr/streams/impl/listener/MarlinListenerImpl   - Update method signatures to match new Kafka10 Consumer

3
org/apache/kafka/clients/consumer/KafkaConsumer#1894   - Call paused() from consumerDriver instead of Exception
com/mapr/streams/impl/listener/MarlinListener   - Add support for new paused() method
Add support for paused(), which gets the set of partitions that were previously paused by a call to pause

4

Verify updated description of timeout parameter to poll() is accurate: "The time, in milliseconds, spent waiting in poll if data is not available in the buffer.  If 0, returns immediately with any records that are available currently in the buffer, else returns empty.  Must not be negative."

5
org/apache/kafka/clients/consumer/KafkaConsumer#676   - Remove the log.warn

Include ConsumerInterceptor Functionality   - onConsume should be called during poll   - onCommit should be called during commitOffsetsAsync and commitOffsetsSync

6

Verify seekToBeginning and seekToEnd are compatible with documentation update: "If no partition is provided, seek to the first offset for all of the currently assigned partitions."

7
org/apache/kafka/clients/consumer/KafkaProducer#285   - Remove the UnsupportedOperationException

Include ProducerInterceptor Functionality   - onSend should be called during send   - onAcknowledgement should be called during InterceptorCallback#onCompletion

8
New Configurations were added and these should be investigated for compatibility.

Finally, the release notes for 10 should be reviewed to ensure all behavior is compatible.
Streams
Kafka Streams is a new feature of the API that provides a nice streaming workflow style interface for clients.  It essentially replaces Samza in a light-weight library.  The API leverages the lower level KafkaConsumer and KafkaProducer and should be compatible inasmuch as MapR is compatible with the OSS version, however there are some other blockers with functionality in the core streams code that prevent me from making progress on ensuring Streams is compatible.  These are outlined below:

The KTable and KStream classes allow users to dynamically assign a Producer Partitioner (StreamPartitioner interface) similar to the Partitioner interface in clients.  MapR uses StreamsPartitioner.  Should investigate if there are discrepancies in how these interrelate or if they are compatible.  If possible, it would be nice to use the same Producer Partitioner interface for both MapR and OSS.
Kafka Streams uses its own Consumer Partition Assignor (impl of PartitionAssignor) and configures it using the partition.assignment.strategy property.  MapR ignores this property and so Streams will not work in the current iteration.  MapR Streams will need to support this interface in clients.
The StreamPartitionAssignor that is used by Kafka Streams leverages a class called InternalTopicManager, which uses ZooKeeper for admin functionality.  Will need to expose some MapR admin functions via a programmatic API to sub for these.  The specific features used by InternalTopicManager are:

Getting brokers (returns a List<Integer>)
Getting partitions (returns a Map<Integer, List<Integer>>)
Create Topic
Delete Topic
Add Partitions

(FYI: we are a MapR customer currently using Streams.  We will follow up with our contact at MapR to discuss further and I am happy to meet to discuss these changes in more detail)

FYI: this comparison shows exactly what was changed from the upstream Kafka and this version.  Also, neglected to mention that to get the mapr tests to run I had to hack the mapr-streams jar to update the method signatures in the Listener classes that changed in the updated Consumer interface (re: issue 2 above).


Fix issue 16046 - ScopedAllocator does not set prev, causing segfaults

This is a simpler fix than https://github.com/dlang/phobos/pull/4702.

Current coverage is 88.86% (diff: 96.74%)

Merging #4742 into master will increase coverage by 0.07%

@@             master      #4742   diff @@
==========================================
  Files           121        122     +1
  Lines         74159      74755   +596
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits          65845      66428   +583
- Misses         8314       8327    +13
  Partials          0          0

Powered by Codecov. Last update 0538d0c...23e01e4

How do I see the lines covered with the Codecov tool?

How do I see the lines covered with the Codecov tool?

Either click on the "0538d0c...1b96629" diff link or if you want the annotation directly in the GitHub diff you can install their browser extension:
https://github.com/codecov/browser-extension

reviews pliz pliz

Looks good, modulo the note by Sebastian.

Looks good, modulo the note by Sebastian.

Yep this looks a lot better than #4702 and if I could, I would pull it ;-)

@wilzbach gave you rights

@wilzbach gave you rights

Thanks! As this PR is quite young (1 day) and I don't want to mess up my first merge at Phobos, I'll give this PR another day, s.t. everyone has a fair opportunity to shout ;-)

Auto-merge toggled on


Convert Hearing Date/Time to DateTimeOffset

Ref for migration: entity framework, migrate from datetime to datetimeoffset - Stack Overflow
Refs for integration testing:

Handling DateTimeOffset in SQLite with Entity Framework Core - Dangl.Blog();
Mechanism/API to specify a default conversion for any property of a given type in the model · Issue #10784 · dotnet/efcore

There has only ever been one enforcement order with a hearing scheduled. This work is not worth the effort.
Hearing date/time does not need to be localizable.


Revert #2081 to get rid of the SEGV in integration test

Seems to trigger only on Linux, so I suppose the bindings are wrong.

That did the trick.

I cried a little.


Add Plaktos to "Projects" section

I noticed in an issue comment that @georgeaf99 built this project using
WebTorrent :tada:

Awesome, thanks!


Add an event to Asset Transaction Payment

Follow up to https://github.com/paritytech/substrate/pull/11618
Should address https://github.com/paritytech/cumulus/pull/1367#discussion_r897680999 for a consistent experience on Statemint regardless of what asset one pays a fee in.

I will continue the job.


Eliminate dangling comma problem in user card

When state is not defined there was extra comma between country and city. Apparently, only @sakomws is living in USA, so he is the only one who has a state. One day when all of us relocate to USA (Inshallah) we can revert these changes 😆
Current situation:

lol pls move )


Unable to build on Linux

I meant to make a formal submission, but just ran out of time.  There are some issues with building the tutorial on Linux, and even more troublesome issues with running it -- at least for me.  My apologizes for bunching this all in one issue, but it does all have to do with getting Chapter 2 to build and run on Linux.
First some issues with header files:

For starters, I think it's cleaner to include the standard C++ headers in the source file that requires them rather than all bunched into HelperFunctions.h, so I'd move that block to "main.cpp".
That said, there is actually a missing include of  that does need to go in "HelperFunctions.h" for the use of "stdcmp()" -- I guess the MS-Windows compiler must be more lenient.
Also in "HelperFunctions.h", there is no need to include <unordered_map>.
The final issue with includes is that "main.cpp" also needs to include  for the declaration of "unique_ptr".

The only other issue with compiling is:

The type "DebugOutput" is not declared anywhere in the Linux build, so I removed the line at the top of the "OpenXRTutorial_Main()" function.  After that the build completed.

Unfortunately, when I then run "./OpenXRTutorialChapter2" it outputs the title of the tutorial, and then crashes on the line:
const std::vector<int64_t> &supportSwapchainFormats = GetSupportedSwapchainFormats();
I'm not sure whether this is the cause of the error, but in gdb, I was given this information:
(gdb) print supportSwapchainFormats
$4 = std::vector of length -525420, capacity -525420 = {6620760227972,<PHONE_NUMBER>16, -8895937474100832024,
-5437172960282474460, -4068641623515267036, -4519086758524671672,<PHONE_NUMBER>914, -18360, [,,,]
A negative vector length seems like it could be a problem, but I don't know whether this is a cause or a symptom.
I tried a few more experiments:

Changing the example version from 2.3 to 2.1:
#define XR_DOCS_CHAPTER_VERSION XR_DOCS_CHAPTER_2_1
and I tried forcing a graphics API setting -- which worked on the version from 07/25/23:
#define XR_USE_GRAPHICS_API_OPENGL
(also tried "VULKAN")

And one final thought -- last week I was able to get version Chapter 2.1 to build and run, and connect to the Monado OpenXR runtime, so that's a slight regression, but I'm happen to take a step back if it ultimately means we get where we want.

Thanks for the detailed feedback. We'll be revisiting the Linux build later in the week to address this.

Great, thanks Roderick.  I'll be on the road at SIGGRAPH next week, but I can certainly test whether the application builds, and at least get as far as running the app to see whether it crashes or not while away from my system.

Hi @wsherman64 we've got the Linux version working. It's been tested for Chapters 4 and 5 on OpenGL and Vulkan with Monado (no hardware yet, just emulation). If you've time to take a look, please let me know how you get on.


Use unsafe set_len and direct indexing in variance

This was suggested in #85
I'm not sure if it was worth it to pull out the t[j] outside of the match what is your opinion?

Thanks for another PR! This one has some minor caveats though.
I believe this may still have bound checks on the t[j] indexing - which I believe will prevent the compiler vectorizing. To get around it you can either do an unsafe get_unchecked_mut(j) and then mutate this value. Or you can use a trick like this one used elsewhere.
The best way to check whether this is working as expected is to pull up some minimal version of the code in the rust playground and check the output assembly to see if the code was vectorized and bound checks removed. Pretty messy stuff :) I'll take a go at this myself to see how it looks and report back.
As for your question about moving the t[j] out - I think it looks more Rust-like so I'm all for it!

TLDR; Looks like the code you presented actually optimizes well!
Here is a minimal example in the playground. Here I've replaced your assignment with a new slice (t_slice). If you go to the MIR view (make sure you are compiling in Release not Debug) you can see that there is a bounds check (search for "index out of bounds").
However if we go back to your code. The bounds check is no longer there and the code vectorizes well (looking at the asm output there is a lot of movup [mov packed scalar] and use of xmm registry).
As one last point... Could you change the line let mut variance = Vector::new(vec![T::zero(); m]); to let mut variance = Vector::zeros(m);. That one is my bad code :) but I think this makes it a little more readable.

I changed that line. Praise the compiler ;) the simple code won. Maybe we can also simplify that?

I'll definitely look at it. When I wrote that code the rejoicing was definitely needed - perhaps compiler changes means that it no longer helps..
Thanks for the PR. Merging now.


watcher error on WH in test_move_sharded.py::test_move_op

TT_METAL_WATCHER=30 pytest tests/tt_eager/python_api_testing/unit_testing/test_move_sharded.py::test_move_op -xv
2024-03-01 01:32:42.628 | INFO     | SiliconDriver   - Software version 6.0.0, Ethernet FW version 6.3.0 (Device 1)
                  Metal | INFO     | AI CLK for device 0 is:   1000 MHz
              LLRuntime | INFO     | Watcher log file: /home/ubuntu/bteng/tt-metal/built/watcher.log
              LLRuntime | INFO     | Watcher attached device 0
              LLRuntime | INFO     | Watcher thread watching...
2024-03-01 01:32:44.113 | INFO     | tests.tt_eager.python_api_testing.unit_testing.test_move_sharded:run_move_op:92 - shape=[1, 1, 25050, 64]
              LLRuntime | INFO     | Watcher checking device 0
                 Always | INFO     | Watcher stopped the device due to bad NOC unicast transaction
                 Always | INFO     | While running kernels:
                 Always | INFO     |  brisc : tt_metal/impl/dispatch/kernels/command_queue_consumer.cpp
                 Always | INFO     |  ncrisc: blank
                 Always | INFO     |  triscs: blank
                 Always | INFO     | Last waypoint: NAWW,W,W,W,W
                 Always | FATAL    | On core (x=1,y=10): brisc using noc0 tried to accesss core (00,00) L1[addr=0x00166280,len=0]
terminate called after throwing an instance of 'std::runtime_error'
  what():  TT_THROW @ tt_metal/impl/debug/watcher_server.cpp:205: tt::exception
info:
On core (x=1,y=10): brisc using noc0 tried to accesss core (00,00) L1[addr=0x00166280,len=0]
backtrace:
 --- /home/ubuntu/bteng/tt-metal/build/lib/libtt_metal.so(+0x2d6d4b) [0x7f4646007d4b]
 --- /home/ubuntu/bteng/tt-metal/build/lib/libtt_metal.so(+0x2d74cd) [0x7f46460084cd]
 --- /lib/x86_64-linux-gnu/libstdc++.so.6(+0xd6df4) [0x7f466c0abdf4]
 --- /lib/x86_64-linux-gnu/libpthread.so.0(+0x8609) [0x7f4686cd2609]
 --- /lib/x86_64-linux-gnu/libc.so.6(clone+0x43) [0x7f4686e0c353]

Fatal Python error: Aborted

@tt-nshanker @acejkov looks like you two recently touched this test, let me know if it's an easy fix

@mywoodstock do you know what this noc related error means on WH?

@mywoodstock do you know what this noc related error means on WH?

@tt-nshanker It looks like a zero sized transfer.

@mywoodstock , which op catgory should this go into? I am putting in window_based for now since it seems to already land in your queue

@jliangTT , this should be in TMs

assigning P1 as this is a CI issue. Let me know if we need to downgrade this to P2 if the test is not important.

i see three names assigned - whose queue is it in?


Fix double endif in gitea.ini

Removed the second one: text between if and endif is now all about lfs,
which seemed to be the point ;)
Might want to bump to v0.0.1 ;)

What about an {% else %} to avoid overwriting LFS_JWT_SECRET? Guess that was intended instead of the second endif?!
{% if gitea_lfs_server_enabled | bool -%}
LFS_START_SERVER = true
LFS_CONTENT_PATH = {{ gitea_lfs_content_path }}
LFS_JWT_SECRET   = {{ gitea_lfs_jwt_secret }}

{% else %}    <<<<--------------------

LFS_CONTENT_PATH      = {{ gitea_lfs_content_path }}
LFS_JWT_SECRET       = {{ gitea_lfs_secret }}
OFFLINE_MODE         = {{ gitea_lfs_mode }}
{% endif %}


JumpVaders are picky with where you stand

JumpVaders want you to stand dead center (or really close to it) when using them to move up, causing problems with moving you. Even with blocks on either side it does it.

These are both bugs, and I'll look into them asap. Should be a simple fix for both, but im currently away from home for a day or two.
Could you split this into two issues if possible? I prefer a dedicated issue for each bug. Thanks!!

If you could let me know what minecraft version and(if you know how) what mod version youre using that would be helpful in advance. I switched from a internal SNEAK event to ServerAPI's SNEAK event in recent JumpVader versions.

The MC Version is 1.20.1, and the mod version is 1.0.3.

Attempted to fix this with latest commit 2bccfd9 . This would be JumpVaderMod v1.0.8+mc1.20.1. There seems to be some weird interaction with the way I was teleporting the player. Im doing it the "traditional" way now so hopefully itll work. Let me know if the issue persists and thanks for reporting it to me!

Using build #12: Commit [2bccfd9] / version 1.0.8. Seems like nothing has really changed. The issue is exactly the same from my testing.

Fixed and tested working in v1.0.9+mc1.20.1. Thank you for reporting and let me know if you have any further issues!

I have installed v1.0.9 and I'm still having issues with warping up using a JumpVader if I'm not near center, it seems warping down does not have the same requirements though.

I have installed v1.0.9 and I'm still having issues with warping up using a JumpVader if I'm not near center, it seems warping down does not have the same requirements though.

Sorry, I didnt see this. So im not really able to replicate the issue on my end. Would it be possible for you to post a image of how you have the jump vaders setup as well as the blocks around them? I think I understand what you're saying but I just want to be sure. Also, please remove the .jar file for ServerAPI from your mods folder now if its still there, as that one should be referenced in JumpVadersv1.0.9  . Im sure its not what's causing this issue, but im trying to rule out other possible problems. Thanks!


Unable to initialize new repository with blackbox_initialize

Using<PHONE_NUMBER>674a538a9b09428f754fd3f2d2e2a0 - any attempt to get initialize a repository fails. Works fine using a much older version
$ blackbox_initialize
Enable blackbox for this git repo? (yes/no) yes
ERROR:  is not a blackbox Repo

Looks like the problem is in the call to change_to_vcs_root in blackbox_initialize
change_to_vcs_root will error if the repo is not already a blackbox Repo
# chdir to the base of the repo.
function change_to_vcs_root() {
  # if vcs_root not explicitly defined, use $REPOBASE

  local rbase=${1:-$REPOBASE} # use $1 but if unset use $REPOBASE

  if ! is_blackbox_repo "$rbase"; then
    echo "ERROR: $rbase is not a blackbox Repo"
    exit 1
  fi
}

Proposing a fix shortly

@tlimoncelli Confidence test is resolved.  Waiting on your ok to merge this.

@rfein-hearst please confirm this is resolved for you in the latest build


Add husky to run dotnet format whitespace on every commit

With this PR dotnet format whitespace will be run on every commit and the changes will be include automatically, so we cannot forget it.
Also had to fix a vulnerability build fail.

I like the idea of formatting before commit.

I like the idea of formatting before commit.

Later we can also run the analyzers, and gradually get more strict, so that we will not get any new nullable and dispose warnings in our repository.

Merging this one because it also fixes the build


Add a favicon.ico

I went for a tiny bin icon with "http" in it.  Sort of legible at 16x16 ... the ico also contains 32x32 and 64x64 sizes.

Here's a preview of it rendering 16x16 in Chrome on macos, nestled between GitHub and GMail:

Whoops, again without accidentally losing the alpha channel:

Fixes #459.

✨🍰✨


Fix 64-bit compiler warnings

There are many compiler warnings regarding type conversions in 64-bit. At least in Visual Studio. These need to be eliminated.

Fixed in c85a50db71649bf10d1375c1a7f92ea78ede264c


some work on PolymerDom class and a test

@jakemac53 I got some problems getting things working in firefox and safari.
I don't understand it, cause I do allmost the same here:
https://github.com/kasperpeulen/polymerjs-dart/blob/master/lib/polymerdom.dart
with this test:
https://github.com/kasperpeulen/polymerjs-dart/blob/master/test/PolymerDom_test.dart

Minor style nit, please rename PolymerDom_test.dart to polymer_dom_test.dart

HtmlElement should be Element throughout (to support SvgElement)

Ok, done with my first pass through. I will also test this out with TodoMvc and the Polymer.dart tests to make sure its all good, but I might not get around to that until tomorrow.
Thanks for the contributions!

Just tested with TodoMvc and Polymer dart, everything looks fine :)

Just tested with TodoMvc and Polymer dart, everything looks fine :)

nice :)
@jakemac53  the last commit was supposed to be named: review comments seems some brain malfunction on my side ...

let me know when you are done with everything and I will go ahead and merge

I see that the Polymer.Base class has a domhost property that gives already this exact shortcut:

domHost() Return the element whose local dom within which this element is contained. This is a shorthand for Polymer.dom(this).getOwnerRoot().host.

Maybe this shortcut is enough, so that we can leave the PolymerDom wrapper just as this ? I don't know what you're plans for the Polymer.Base class are, but I've made a complete wrapper for this class here:
https://github.com/kasperpeulen/polymerjs-dart/blob/master/lib/polymerbase.dart
Not sure where a wrapper for the polymbase class would fit in the polymerdart project, here, or at the polymer-dart repo ? @jakemac53

I think it is ready to be merged.

Polymer.Base will probably become a mixin class, but that is a task for another day. It needs to compose well with the PolymerMixin class defined in polymer-dart, which probably means moving some things out of that class and into the new PolymerBase class (or whatever it ends up being called).

thanks for the PR!

added https://github.com/dart-lang/polymer_interop/issues/6 to track the PolymerBase class.


Android build

Hello,
Does SIL Kit support build for Android? I mean if it is possible to build SIL Kit as a static or shared lib and use it by the application written in C++ in Android?
If not, do you have maybe any hints how could this be achieved?

Hi @kocho1984,
we currently do not officially support Android - that is, we haven't tested it or integrated it into our CI.
However, there is no reason why SIL Kit shouldn't run on Android with little to no changes (it is really portable).
The CMake build will probably work the same as on any Linux. Android is using LLVM's standard C++ library, this should support all features that we use.
Have you already tried building SIL Kit using Android NDK? can you shed some more light on the use cases involving Android?

@MariusBgm,
I'll try to build it with Android NDK. Thank you for your hint.
Regarding use case in Android: basically it is to test communication (send/receive) between two apps using SIL Kit.

@MariusBgm, I was able to build libSilKit.a with NDK. Due to the fact that SIL Kit uses exceptions, RTTI (for dynamic_cast), and has some cases where destructor is not virtual even if other methods are virtual, I had to enable following build options, as default compiler options for Android don't allow e.g. using exceptions.
-fexceptions, -frtti, -Wno-error=non-virtual-dtor
However, when I'm trying to build an application which is trying to use functionality from libSilKit.a, I get tons of linker errors which seem to be related to STL, e.g. shared_ptr, basic_string, etc.
Some examples:
ld.lld: error: undefined symbol: std::__ndk1::__shared_weak_count::__release_weak()
referenced by shared_ptr.h:184 (./workspace/android-ndk-r27c/toolchains/llvm/prebuilt/linux-x86_64/sysroot/usr/include/c++/v1/__memory/shared_ptr.h:184)
CapiParticipant.cpp.o:(SilKit_Participant_Create) in archive ./libSilKit.a

ld.lld: error: undefined symbol: std::__ndk1::basic_string<char, std::__ndk1::char_traits<char>, std::__ndk1::allocator<char>>::rfind(char, unsigned long) const
referenced by Filesystem.cpp:149 (./workspace/sil-kit-android/SilKit/source/util/Filesystem.cpp:149)
               Filesystem.cpp.o:(SilKit::Filesystem::parent_path(SilKit::Filesystem::path const&)) in archive ./libSilKit.a

You mentioned that you don't have an official Android build in your CI, but have you tried building it locally by any chance, or encountered similar linker errors in the past when working on Android builds?

@kocho1984 can you share the complete linker command line that cmake used for linking?
I suppose the libc++.so is not linked properly, see https://developer.android.com/ndk/guides/cpp-support
You may need to set the CMAKE_ANDROID_STL_STYLE to c++_shared , refer to https://cmake.org/cmake/help/latest/manual/cmake-toolchains.7.html#cross-compiling-for-android-with-the-ndk

@MariusBgm ,
If you are referring to the linker command line used for building SILKit lib

I used following cmake command and then start build with make
cmake -DCMAKE_TOOLCHAIN_FILE=$ANDROID_NDK_HOME/build/cmake/android.toolchain.cmake -DANDROID_PLATFORM=android-35 -DANDROID_ABI=arm64-v8a -DANDROID_NDK=$ANDROID_NDK_HOME  -DSILKIT_BUILD_DEMOS=OFF -DSILKIT_BUILD_STATIC=ON -DSILKIT_BUILD_TESTS=OFF -DCMAKE_ANDROID_STL_TYPE=c++_shared --trace ..

This is an output from the build. Command which starts linking libSilKit.a is in line 991 in
silkit_a_make_output.txt

[ 96%] Linking CXX static library ../../Release/libSilKit.a
Or you ask for the linker command used to build a lib which uses libSilKit.a?

@MariusBgm, thank you for quick response.
Static SilKit.a is intentinal.
Regarding -static-libstdc++ you mean that I can try to build static SilKit.a with that flag? Is my understanding correct?

@kocho1984  no, I mean your test application that links against the libSilKit.a.
You mentioned you are trying to build a lib which contains the static libSilKit.a (which is just an archive of object files):

However, when I'm trying to build a lib which is trying to use functionality from libSilKit.a, I get tons of linker errors which seem to be related to STL, e.g. shared_ptr, basic_string, etc.

you need to link your own library ( or test application for that matter) using --whole-archive and properly link the application where you use your own library against the stdc++ library.

Have you tried using the shared library build of silkit?

@MariusBgm
I would like to use it as a static lib, but just in case, I tried to build shared SilKit lib. The build fails unfortunately. There are following linker errors.

silkit_so_ndk_build_failed.txt

@kocho1984  I reproduced your issue locally. It's caused by our use of the linker script silkit.map.
Can you try the following patch? (or just remove the linker script from the cmake)
diff --git a/SilKit/source/CMakeLists.txt b/SilKit/source/CMakeLists.txt
index 322639c43..ea85d8e9c 100644
--- a/SilKit/source/CMakeLists.txt
+++ b/SilKit/source/CMakeLists.txt
@@ -243,7 +243,7 @@ if (MSVC)
             PDB_OUTPUT_DIRECTORY_DEBUG ${SILKIT_SYMBOLS_DIR}/Debug
             LINK_FLAGS "/DEBUG" #make sure the resulting .dll has a .pdb file
     )
-elseif(UNIX AND NOT APPLE)
+elseif(UNIX AND NOT APPLE AND NOT (CMAKE_SYSTEM_NAME MATCHES Android))

@MariusBgm

I confirm that SilKit shared lib can be built when I removed from CMakeLists.txt line with "silkit.map".

I was unable to get my shared library's build working with the SilKit static library built with NDK. Whether the SilKit library is built as shared or static, when it's compiled with the NDK, the NDK appends __ndk1 to the signature of STL functions, as in the below example:

ld.lld: error: undefined symbol: std::__ndk1::__shared_weak_count::__release_weak()
referenced by shared_ptr.h:184 (./workspace/android-ndk-r27c/toolchains/llvm/prebuilt/linux-x86_64/sysroot/usr/include/c++/v1/__memory/shared_ptr.h:184)
CapiParticipant.cpp.o:(SilKit_Participant_Create) in archive ./libSilKit.a

My shared library that relies on the SilKit library is an Android platform library built using the Android platform's Soong build system (which uses blueprints: Android.bp files rather than CMakeLists.txt).
This caused linker errors because the Android platform's libc++ doesn’t include __ndk1 in the STL function signatures, resulting in missing symbol definitions. If I could build the SilKit library within the Android platform using Soong instead of "cmake + NDK", the STL symbols should match and the issue would likely be resolved. However, SilKit and its dependencies are based entirely on cmake, with no support for Soong blueprints, so only a "cmake + NDK" build is currently feasible.
This post on android-ndk forum also confirms that build with NDK should be used only for apps, not for libs.
https://groups.google.com/g/android-ndk/c/OIinzHaWs0w

@kocho1984 thanks for the feedback.
Indeed, Android platform is a different environment than Android Apps.
Currently we do not support Soong / Bazel builds, CMake is the only supported build system.
Writing your own Android.bp blueprint files should be straight forward though.
However, out of curiosity: SilKit exposes a stable C ABI, so if the libc++ is statically linked, it might work.
If you are feeling lucky, you might try building it with the whole libc++_static included, however this is just for experimentation and not really supported:
cmake \
    -D CMAKE_TOOLCHAIN_FILE=$ANDROID_NDK_HOME/build/cmake/android.toolchain.cmake \
    -D ANDROID_PLATFORM=android-34 \
    -D ANDROID_ABI=arm64-v8a \
    -D ANDROID_NDK=$ANDROID_NDK_HOME \
    -D SILKIT_BUILD_DEMOS=OFF \
    -D SILKIT_BUILD_STATIC=OFF \
    -D CMAKE_ANDROID_STL_TYPE=c++_static \
    -D SILKIT_BUILD_TESTS=OFF  \
    -D CMAKE_SHARED_LINKER_FLAGS="-Wl,--whole-archive -lc++_static -Wl,--no-whole-archive" \
    -B _build/android -S .

The --whole-archive linker flag is crucial here.

This line contains both --whole-archive and --now-whole-archive. Is this correct?
-D CMAKE_SHARED_LINKER_FLAGS="-Wl,--whole-archive -lc++_static -Wl,--no-whole-archive"
Do you know maybe how that command should look in case I would like to build SilKit as a static lib?

@kocho1984

Is this correct?

Yes, it tells the linker to contain the whole archive named libc++static.a into your target shared library, in this case libSilKit.so.
You can add any number of libraries to be included, and mark the end of the linker input using the no-whole-archive:  -Wl, --whole-archive A.a B.A C.a ... -Wl,--no-whole-archive.

Do you know maybe how that command should look in case I would like to build SilKit as a static lib?

A static library is just an archive of object files -- the linker doesn't resolve symbols, and thus adding --whole-archive makes no sense here. You have to add the linker flags to your target library, not to libSilKit.a. So you have to modify your target library (in case you want to include the static silkit library and the static libc++_static.a).
Hope this helps.

@kocho1984 if you want to discuss this further or how to integrate SIL Kit into different build systems, feel free to contact me using my work emailadress which you can find in the git log.


Fix wording

"Create customize..." is grammatically incorrect and was changed based on the context.

Thank you, @ic-768


vaadin.manageDependencies = false stopped working in plugin version 0.11

vaadin.manageDependencies = false stopped working in plugin version 0.11.
In 0.10.7 it works as it should, but in 0.11+ the dependencies get pulled (wrong jars can be seen in eclipse under Web App Libraries), even if vaadin.manageDependencies is set to false.
I use gradle version 2.14.1 on Windows 7 64 bit and Eclipse Neon.

Hi,
Tried to reproduce this with the following simple build script:
plugins {
  id "fi.jasoft.plugin.vaadin" version "0.11.1"
}
vaadin.manageDependencies = false

and I get the following output:
/t/test $ gradle dependencies
Using Gradle Vaadin Plugin 0.11.1
:dependencies

------------------------------------------------------------
Root project
------------------------------------------------------------

archives - Configuration for archive artifacts.
No dependencies

compile - Dependencies for source set 'main'.
No dependencies

compileClasspath - Compile classpath for source set 'main'.
No dependencies

compileOnly - Compile dependencies for source set 'main'.
No dependencies

default - Configuration for default artifacts.
No dependencies

providedCompile - Additional compile classpath for libraries that should not be part of the WAR archive.
No dependencies

providedRuntime - Additional runtime classpath for libraries that should not be part of the WAR archive.
No dependencies

runtime - Runtime dependencies for source set 'main'.
No dependencies

testCompile - Dependencies for source set 'test'.
No dependencies

testCompileClasspath - Compile classpath for source set 'test'.
No dependencies

testCompileOnly - Compile dependencies for source set 'test'.
No dependencies

testRuntime - Runtime dependencies for source set 'test'.
No dependencies

BUILD SUCCESSFUL

Total time: 1.47 secs

So looks like manageDependencies is working at least for this case.
You could check the following things

Run the clean and cleanEclipse tasks on your project
Ensure Vaadin is not getting pulled in as  a transitive dependency of another dependency you have in your build
Ensure that your Eclipse configuration is up to date, press the "Refresh Gradle Build" button to refresh the project


docs: Fix simple typo, unintentianally -> unintentionally

There is a small typo in django_blog_it/django_blog_it/static/js/jquery.smartmenus.js.
Should read unintentionally rather than unintentianally.

Coverage remained the same at 80.944% when pulling 7d456e445655d0b725fede1f1710278f9fdcf0d1 on timgates42:bugfix_typo_unintentionally into ea079e9e08bb3498d0bd5680e9931eda5e7bfd1c on MicroPyramid:master.


feat(bin): Dry Run Flag

Description
The op-up binary should have a --dry-run flag to allow for "dry runs" for a given stack.

What is a dry run in this context? Does it mean validating the configs without spinning up any containers?


[2117] Add accept terms endpoint

Context
Not implemented in Rails... until now
Changes proposed in this pull request
TDD an endpoint into existence
Guidance to review
:ship:
Checklist

[x] Make sure all information from the Trello card is in here
[ ] Attach to Trello card
[x] Rebased master
[x] Cleaned commit history
[x] Tested by running locally

 Providers still getting the  'we don't know which organisation' error when they have been given access to an organisation


Updates the spruce beetle section with new beetle data explanation

This PR makes major text changes to the spruce beetle section of the report based on the text in this document: https://docs.google.com/document/d/1TS7CqsR54bFMuJsWbiXE6SnwefRwKFUngUr1nZGbh9E/edit#
To test this branch, please use this API version PR: https://github.com/ua-snap/data-api/pull/256 and set the following environment variables:
export SNAP_API_URL=http://localhost:5000
export RASDAMAN_URL=https://apollo.snap.uaf.edu/rasdaman/ows
Closes #414
Closes #415
Closes #432
Closes #453

@cstephen  Both of those changes made perfect sense to me, I've committed them and it's good to merge when you're ready!


Add dotenv-safe functionality

Hey @mrkkrp, this is ready for another review.
Thanks!

Hey @sestrella, This is ready for another review.
Thanks!

@acamino @mrkkrp @sestrella Do you have any other comments on this PR? Otherwise, we can merge it. 😄

@acamino I think we should squash some commits and then merge this PR. I've already rebased it with master.

The squash is done. It is ready to merge and bump in Hackage. 😄

I've noticed that we've lost a functionallity with this new feature: we won't be able to set the env vars from multiple .env

@sestrella @mrkkrp @acamino This is ready for a last review. 😄

@CristhianMotoche @acamino Please check the merging conflicts

@juanpaucar sure I'll do it. I hope you can take a look at this and give us feedback to merge it or fix it if necessary. Thanks.

@juanpaucar Could you take a look please?

Since we conserved onMissingFile I think we can omit parseMaybeFile
listToMaybe <$> onMissingFile (parseFile "does/not/exist.txt") (return [])
>>> Nothing

Also, I'm not sure why we want to return Nothing when the file is missing, it should failed!

@CristhianMotoche Are we still working on this?

@juanpaucar I'm not sure what will be the future of this PR. As we've discussed this feature only brings the capability to be sure that the mandatory env vars (defined in .env.example) are set. However, we also want to add some kind of "type safe env vars". These things stopped me to continue.

Let's stick to the discussion on the open issue. We could tackle type safe environment vars later and we can have a broader discussion only focused on that

🆒

@juanpaucar Could you take a look, please?

@CristhianMotoche could you update the readme file with the usage examples, please

Thanks @juanpaucar. I'll do a little refactor today in the evening and update the README.

@juanpaucar Ready for a new review!

This PR has already too many comments. The functionality has been added in another PR and the version was increased as it is a breaking change for the library.
I'm closing this in favor of #57


fix: props default value

when props is function type. Should not execute

I have no idea what _vueTypes_name is.
Please submit PRs with proper explanation of what you are fixing and add an accompanying test case.


Didn’t understand the online notebook use online physionet2012_dataset

Hi there 👋,
Thank you so much for your attention to PyPOTS and BrewPOTS! You can follow me on GitHub to receive the latest news of PyPOTS. If you find PyPOTS and BrewPOTS helpful to your work, please star our repositories. Your star is your recognition, which can help more people notice PyPOTS and grow PyPOTS community. It matters and is definitely a kind of contribution to the community.
I have received your message and will respond ASAP. Thank you for your patience! 😃
Best,
Wenjie

Hi @luoolu, could you please make it more clear that which steps in the notebook confuse you? And what kind of problem that you're trying to solve with PyPOTS?

Mainly how to load my own dataFrame for testing,confusied how the data organized with the notebook "physionet2012_dataset["n_features"]"

You may need to refer to this function
https://github.com/WenjieDu/PyPOTS/blob/cf9b627b332e4b9a6b1c852a8c6a3bf2ae73cd29/pypots/data/generating.py#L329-L435

can u give a demo,load local csv file to forecastting future data points?
loal csv like below:
Date, c1,c2,c3,c4,c5
2023/10/1, 1,2,3,4,5
2023/10/2, 6,7,8,9,10
2023/10/3, 11,12,13,14,15
......


Implement MutUntyped::from(mut_typed)

Objective
Allow to create MutUntyped<'a> instance from Mut<'a, T>.
Fixes #12405
Solution
Added impl<'a, T> From<Mut<'a, T>> for MutUntyped<'>

Merging as trivial.

Is there no risk of possible type safety loss by an automatically-applied From?

Mut to MutUntyped is both safe and easy to do. The same reason why &mut T to PtrMut has a From implementation. MutUntyped to Mut is unsafe and requires proving the conversion is safe.


Output formats

Great tool; it would be good to be able to select the output format, from a list including:

Wiki markup
HTML markup
CSV of relevant text & QID
other?

Thanks, that would make sense indeed!

Agreed, Wiki markup was the first thing that came to my mind.
It kind of works for Latvian text, too, but we have all these grammatical cases which make it impossible when not in Nominative.

HTML markup output could allow the user to enter a base URL, say:
http://pigsonthewing.org.uk/tag/
and then return a series of links (one per line) marked up with schema.org "sameAs", for example:
<link itemprop="url" href="https://www.wikidata.org/entity/Q43449" />Creative Commons
Note how the link text becomes part of the URL, lower case and with hyphens for spaces, as:
creative-commons
Alternatively, could use a dummy string like "$1" for the user to replace:
<link itemprop="url" href="https://www.wikidata.org/entity/Q43449" />Creative Commons

I am not sure about this particular HTML output - I would say that linking to user-supplied ontologies is beyond the scope of OpenTapioca. I would suggest to implement that as an external tool, which could potentially call OpenTapioca's API.


Something weird with spacing and fire locks

Description
Not all firelocks go down during a spacing, but they somehow still block the atmos changing even though you can walk through it
Screenshots
None
Additional context
I dunno how else to explain it tbh, just test firelocks and spacing an area

There was a similar issue a long time ago where people were able to move through firelocks while they were down. Probably related but can't find a filed issue for it.


HotspotSetupBluetoothSuccess report invalid checksum

when i donwload the newest make app and run it on my phone and onboarding my gateway, it report 'invalid checksum' when the app code run at
+++ b/src/features/hotspots/setup/HotspotSetupBluetoothSuccess.tsx
@@ -126,10 +126,16 @@ const HotspotSetupBluetoothSuccess = () => {
if (!parsed?.address) throw new Error('Invalid Token')
       const { address: ownerAddress } = parsed

try {
const addGatewayTxn = await createGatewayTxn({
ownerAddress,
payerAddress,
})
} catch (e) {

  alert('aaaa add gateway txn... owner ' + ownerAddress)

  alert('aaaa add gateway txn... payer ' + payerAddress)

}
navigation.replace('HotspotSetupPickWifiScreen', {

here is a owerAddress and payerAddress,
we thing it don't match with the gateway, but we don't know how to fixed the code in the gateway.


Create android 14

Looks like this was created by accident, closing. If needed, feel free to reopen with more details, thank you!


Get "iotHubName is not found" error when using Pip packages

OS and version used:  Windows 10

Python runtime used:  Python 3.6.5

SDK version used:  azure-iothub-device-client-1.4.0

Description of the issue:
When sending message to Azure IoT Hub using packages installed by Pip then get "iotHubName is not found" error.
Code sample exhibiting the issue:
I run the official sample: iothub_client_sample.py
Console log of the issue:
D:\Sample\azure-iot-sdk-python\device\samples>python iothub_client_sample.py -c "HostName=xxxxxx.azure-devices.net;DeviceId=device1;SharedAccessKey=xxxxxx" -p mqtt

Python 3.6.5 (v3.6.5:f59c0932b4, Mar 28 2018, 17:00:18) [MSC v.1900 64 bit (AMD64)]
IoT Hub Client for Python
Starting the IoT Hub Python sample...
    Protocol MQTT
    Connection string=HostName=ritaiothub.azure-devices.net;DeviceId=device1;SharedAccessKey=***
Error: Time:Mon Jul 16 17:07:45 2018 File:C:\release\iot-sdks-internals\release\python\automation\aziotsdk_pytools\src\c\iothub_client\src\iothub_client_core_ll.c Func:IoTHubClientCore_LL_CreateFromConnectionString Line:892 iotHubName is not found
Error: Time:Mon Jul 16 17:07:45 2018 File:C:\release\iot-sdks-internals\release\python\automation\aziotsdk_pytools\src\c\iothub_client\src\iothub_client_core.c Func:create_iothub_instance Line:928 Failure creating iothub handle
set_option TrustedCerts successful
SetRetryPolicy to: retryPolicy = 2
SetRetryPolicy to: retryTimeoutLimitInSeconds = 100
GetRetryPolicy returned: retryPolicy = 2
GetRetryPolicy returned: retryTimeoutLimitInSeconds = 100
IoTHubClient is reporting state
IoTHubClient sending 5 messages
IoTHubClient.send_event_async accepted message [0] for transmission to IoT Hub.
IoTHubClient.send_event_async accepted message [1] for transmission to IoT Hub.
IoTHubClient.send_event_async accepted message [2] for transmission to IoT Hub.
IoTHubClient.send_event_async accepted message [3] for transmission to IoT Hub.
IoTHubClient.send_event_async accepted message [4] for transmission to IoT Hub.
IoTHubClient waiting for commands, press Ctrl-C to exit
Send status: BUSY
Confirmation[0] for reported state received with:
    status_code: 204
    Total calls confirmed: 1
Confirmation[0] received for message with result = OK
    message_id: message_0
    correlation_id: correlation_0
    Properties: {'temperatureAlert': 'false'}
    Total calls confirmed: 1
Confirmation[1] received for message with result = OK
    message_id: message_1
    correlation_id: correlation_1
    Properties: {'temperatureAlert': 'false'}
    Total calls confirmed: 2
Confirmation[2] received for message with result = OK
    message_id: message_2
    correlation_id: correlation_2
    Properties: {'temperatureAlert': 'true'}
    Total calls confirmed: 3
Confirmation[3] received for message with result = OK
    message_id: message_3
    correlation_id: correlation_3
    Properties: {'temperatureAlert': 'true'}
    Total calls confirmed: 4
Confirmation[4] received for message with result = OK
    message_id: message_4
    correlation_id: correlation_4
    Properties: {'temperatureAlert': 'false'}
    Total calls confirmed: 5

@luyaok are you setting the content-type property by any chance?
can you see if what is suggested in this issue works for you?
https://github.com/Azure/azure-iot-sdk-python/issues/138

@pierreca Thanks for the reply. I don't set content-type. As suggested in #138 I add client.set_option("auto_url_encode_decode", True) but get the same error. I tried all protocols, mqtt, amqp and http, all of them reproduce the same error for me.
But C SDK don't reproduce this error for me.
AMQP:
D:\Sample\azure-iot-sdk-python\device\samples>python iothub_client_sample.py -c "HostName=xxxx.azure-devices.net;DeviceId=device1;SharedAccessKey=xxxx" -p amqp

Python 3.6.5 (v3.6.5:f59c0932b4, Mar 28 2018, 17:00:18) [MSC v.1900 64 bit (AMD64)]
IoT Hub Client for Python
Starting the IoT Hub Python sample...
    Protocol AMQP
    Connection string=HostName=xxxx.azure-devices.net;DeviceId=device1;SharedAccessKey=xxxx
Error: Time:Tue Jul 17 15:38:54 2018 File:C:\release\iot-sdks-internals\release\python\automation\aziotsdk_pytools\src\c\iothub_client\src\iothub_client_core_ll.c Func:IoTHubClientCore_LL_CreateFromConnectionString Line:892 iotHubName is not found
Error: Time:Tue Jul 17 15:38:54 2018 File:C:\release\iot-sdks-internals\release\python\automation\aziotsdk_pytools\src\c\iothub_client\src\iothub_client_core.c Func:create_iothub_instance Line:928 Failure creating iothub handle
set_option TrustedCerts successful

HTTP:
D:\Sample\azure-iot-sdk-python\device\samples>python iothub_client_sample.py -c "HostName=xxxx.azure-devices.net;DeviceId=device1;SharedAccessKey=xxxx" -p http

Python 3.6.5 (v3.6.5:f59c0932b4, Mar 28 2018, 17:00:18) [MSC v.1900 64 bit (AMD64)]
IoT Hub Client for Python
Starting the IoT Hub Python sample...
    Protocol HTTP
    Connection string=HostName=xxxx.azure-devices.net;DeviceId=device1;SharedAccessKey=xxxx
Error: Time:Tue Jul 17 15:41:33 2018 File:C:\release\iot-sdks-internals\release\python\automation\aziotsdk_pytools\src\c\iothub_client\src\iothub_client_core_ll.c Func:IoTHubClientCore_LL_CreateFromConnectionString Line:892 iotHubName is not found
Error: Time:Tue Jul 17 15:41:33 2018 File:C:\release\iot-sdks-internals\release\python\automation\aziotsdk_pytools\src\c\iothub_client\src\iothub_client_core.c Func:create_iothub_instance Line:928 Failure creating iothub handle
set_option TrustedCerts successful

@luyaok thanks for the additional information!
I just released a new version of the packages last night that snapped to the latest C SDK, would you mind updating to 1.4.1 and letting me know if you still see the problem?

@luyaok actually no need to test with the latest packages, it looks like it still happens. We're looking into it with the C SDK folks - it looks like it's related to a lower-level C SDK thing and as far as I can tell the messages still get sent so it is not blocking, it's just ugly, correct?

@pierreca Yes, messages get sent successfully. Just the error message seems unexpected.

I see exactly this too (iotHubName is not found, but messages get thru.)
I didn't when I started playing with the azure iothub sdk python last week.
(I'm using WSL Debian with Python 2.7)

Hello,
I have the same errors:
Error: Time:Wed Jul 18 09:39:12 2018 File:C:\release\iot-sdks-internals\release\python\automation\aziotsdk_pytools\src\c\iothub_client\src\iothub_client_core_ll.c Func:IoTHubClientCore_LL_CreateFromConnectionString Line:1077 iotHubName is not found
Error: Time:Wed Jul 18 09:39:12 2018 File:C:\release\iot-sdks-internals\release\python\automation\aziotsdk_pytools\src\c\iothub_client\src\iothub_client_core.c Func:create_iothub_instance Line:924 Failure creating iothub handle

@rowlandg @evxipol thanks for the feedback - it seems like a generalized issue and @ewertons will be looking at it from the C SDK perspective. Once this is fixed, we'll release new packages.

@luyaok @rowlandg @evxipol
It was an issue in the C++ wrapper. I checked in the fix.
See the change here:
https://github.com/Azure/azure-iot-sdk-python/commit/e49a1fa23c1624e645bd630f40b0b2fdb4e0993d
Best Regards,
Zoltan

@zolvarga thanks a lot for the fix!
@luyaok @rowlandg @evxipol @ToadTWP666 if you're building the SDK from source by cloning our repository, would you mind giving the fix a try and see how that works for you?
We will be releasing a new version of the packages with the fix in the coming days.

Thx. Will do when I get back from hols in a couple of weeks :)

I'm having the same problem.
I believe I have the latest version, because apparently the fix from @zolvarga is already there.

@ivandojr the fix is checked in, but the pip packages haven't been released - are you using pip packages or compiling from source?

Do we know when the pip packages will be released?

@dustinsummers within the next couple of days. We’re running into some issues with the generation of pip packages for MacOS which has been delaying us but worst case we’ll publish which platform separately to get you the fix. I will update the issue, tag everybody and close it when the packages are out.

Hello Guys,
We are facing the same issue with pip installed iothub-client saying
Error: Time:Tue Aug  7 18:31:50 2018 File:C:\release\iot-sdks-internals\release\python\automation\aziotsdk_pytools\src\c\iothub_client\src\iothub_client_core_ll.c Func:IoTHubClientCore_LL_CreateFromConnectionString Line:1077 iotHubName is not found
Error: Time:Tue Aug  7 18:31:50 2018 File:C:\release\iot-sdks-internals\release\python\automation\aziotsdk_pytools\src\c\iothub_client\src\iothub_client_core.c Func:create_iothub_instance Line:924 Failure creating iothub handle
generic error.
We are not able to send CSV files using http protocol by IoT hub client to IoT Hub because if this Issue.
I understand that the compatible packages for pip are not yet released. If that is the reason i am getting following error. Please let us know when the packages are available. If it is not related to the Packages then please let us know cause of the Issue.
Thank you
Kundhan

@KundhanSoothsayer that might be a different issue. the error that other folks are seeing is a spurious error that doesn't influence the successful connection to IoT Hub (which does not seem to be your case). Can you send messages successfully independently of the error? is the device communicating at all and only file upload is failing, or is it failing to connect?
regarding packages: I've been hitting issues with our release process and I'm taking the time to debug it to not release something that might be half broken - it's coming, I apologize about the delay. Really appreciate everybody's patience with this!!

Hi Pierre,
File upload functionality is failing and we are not able to send the messages to IoT hub. I used same client to connect through MQTT it works fine.
Thank you
Kundhan
Get Outlook for iOShttps://aka.ms/o0ukef

From: Pierre Cauchois<EMAIL_ADDRESS>Sent: Friday, August 10, 2018 10:54:00 PM
To: Azure/azure-iot-sdk-python
Cc: Kundhan Reddy Choodi; Mention
Subject: Re: [Azure/azure-iot-sdk-python] Get "iotHubName is not found" error when using Pip packages (#158)
@KundhanSoothsayerhttps://github.com/KundhanSoothsayer that might be a different issue. the error that other folks are seeing is a spurious error that doesn't influence the successful connection to IoT Hub (which does not seem to be your case). Can you send messages successfully independently of the error? is the device communicating at all and only file upload is failing, or is it failing to connect?
regarding packages: I've been hitting issues with our release process and I'm taking the time to debug it to not release something that might be half broken - it's coming, I apologize about the delay. Really appreciate everybody's patience with this!!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/Azure/azure-iot-sdk-python/issues/158#issuecomment-412246230, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AoO5lr0EU8VVh6oB3AxLI1s6ukQreZ1nks5uPkdIgaJpZM4VSB_n.

Thanks for the response,
I am using Python 3.6 on Windows 10 Machine.
Please find the code and logs.

Code:
import time
import sys
import iothub_client
import os
from iothub_client import IoTHubClient, IoTHubClientError, IoTHubTransportProvider, IoTHubClientResult, IoTHubError
CONNECTION_STRING = "CONNECTION_STRING OF DEVICE FROM IOT HUB"
PROTOCOL = IoTHubTransportProvider.HTTP
PATHTOFILE = "FOLDER PATH"
FILENAME = "CustomerSite1_d20180618.csv"
def blob_upload_conf_callback(result, user_context):
if str(result) == 'OK':
print ( "...file uploaded successfully." )
else:
print ( "...file upload callback returned: " + str(result) )
def iothub_file_upload_sample_run():
try:
print ( "IoT Hub file upload sample, press Ctrl-C to exit" )
    client = IoTHubClient(CONNECTION_STRING, PROTOCOL)

    f = open(PATHTOFILE, "r")
    content = f.read()

    client.upload_blob_async(FILENAME, content, len(content), blob_upload_conf_callback, 0)

    print ( "" )
    print ( "File upload initiated..." )

    while True:
        time.sleep(30)

except IoTHubError as iothub_error:
    print ( "Unexpected error %s from IoTHub" % iothub_error )
    return
except KeyboardInterrupt:
    print ( "IoTHubClient sample stopped" )
except:
    print ( "generic error" )

if name == 'main':
print ( "Simulating a file upload using the Azure IoT Hub Device SDK for Python" )
print ( "    Protocol %s" % PROTOCOL )
#print ( "    Connection string=%s" % CONNECTION_STRING )
iothub_file_upload_sample_run()

Logs:
(geaddzpy36) C:\GEA\OptiPartner\Code>python Optipartner_Batch_Edge.py
Simulating a file upload using the Azure IoT Hub Device SDK for Python
Protocol HTTP
IoT Hub file upload sample, press Ctrl-C to exit
Error: Time:Mon Aug 13 02:25:47 2018 File:C:\release\iot-sdks-internals\release\python\automation\aziotsdk_pytools\src\c\iothub_client\src\iothub_client_core_ll.c Func:IoTHubClientCore_LL_CreateFromConnectionString Line:1077 iotHubName is not found
Error: Time:Mon Aug 13 02:25:47 2018 File:C:\release\iot-sdks-internals\release\python\automation\aziotsdk_pytools\src\c\iothub_client\src\iothub_client_core.c Func:create_iothub_instance Line:924 Failure creating iothub handle
generic error

@KundhanSoothsayer  if you look closely you'll see that it's a different error. As i asked in my previous comment please open a different issue. posting here 1/ distracts from resolving the other issue 2/ does not help with issue triage.
thanks.

I have created  a new issue. Please find it.
https://github.com/Azure/azure-iot-sdk-python/issues/170
Thanks
Kundhan

@pierreca Are there any news on the release of the pip packages? I am really looking forward to getting them.
Thanks,
Peter

@1-Peter I just released the packages v1.4.2. Apologies for the wait time!

@luyaok, @rowlandg, @evxipol, @ivandojr, @KundhanSoothsayer, @1-Peter, thank you for your contribution to our open-sourced project! Please help us improve by filling out this 2-minute customer satisfaction survey

Error: Time:Wed Mar 20 15:04:47 2019 File:C:\Release\iot-sdks-internals\release\python\automation\aziotsdk_pytools\src\c\iothub_client\src\iothub_client_core_ll.c Func:IoTHubClientCore_LL_CreateFromConnectionString Line:1412 x509 option has wrong value, the only acceptable one is "true"
Error: Time:Wed Mar 20 15:04:47 2019 File:C:\Release\iot-sdks-internals\release\python\automation\aziotsdk_pytools\src\c\iothub_client\src\iothub_client_core_ll.c Func:IoTHubClientCore_LL_CreateFromConnectionString Line:1463 iotHubName is not found
Error: Time:Wed Mar 20 15:04:47 2019 File:C:\Release\iot-sdks-internals\release\python\automation\aziotsdk_pytools\src\c\iothub_client\src\iothub_client_core.c Func:create_iothub_instance Line:941 Failure creating iothub handle
Unexpected error IoTHubClient.IoTHubClient, IoTHubClientResult.ERROR from IoTHub
kindly help me in understanding this issue

At a glance...
Have you addressed this?
IoTHubClientCore_LL_CreateFromConnectionString Line:1412 x509 option has wrong value, the only acceptable one is "true"

Yes,
We have fixed this, our blob storage to IoT Hub is not connected, there was a bug in IOT Hub UI that made it looked like is properly connected but it is not connected.
Sent from Mailhttps://go.microsoft.com/fwlink/?LinkId=550986 for Windows 10

From: rowlandg<EMAIL_ADDRESS>Sent: Wednesday, March 20, 2019 5:46:54 AM
To: Azure/azure-iot-sdk-python
Cc: Kundhan Reddy Choodi; Mention
Subject: Re: [Azure/azure-iot-sdk-python] Get "iotHubName is not found" error when using Pip packages (#158)
At a glance...
Have you addressed this?
IoTHubClientCore_LL_CreateFromConnectionString Line:1412 x509 option has wrong value, the only acceptable one is "true"
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/Azure/azure-iot-sdk-python/issues/158#issuecomment-474758315, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AoO5ljR8v8CH7EhW-zrSIttvIxLrIhuOks5vYgOOgaJpZM4VSB_n.


Issue generating new golden files from intentparser2.sd2e.org

I am encountering a validation error while generating new SR golden file content against intentparser2.sd2e.org

https://docs.google.com/document/d/1fFcxyJyheMrzSsVoSsO6v7qHJKFf_0heIFtqEur02cg / YeastSTATES 1.0 Growth Curves Request : Works

https://docs.google.com/document/d/1Mba6kqDila4W32Z46NEqXZFx868A3O36I9GIVOvMQ70 / YeastSTATES 1.0 Time Series Round 1: Fails generation from IP with errors. This looks like either an issue with a control or a measurement entry timepoints value - not generating as an array per schema? This is as before - the only desired change here was expanding the current "strain" definition beyond its current single string value:

https://gitlab.sd2e.org/sd2program/cp-request/blob/master/input/structured_requests/YeastSTATES 1.0 Time Series Round 1.json#L84
{
	'errors': ["{'value': 0.0, 'unit': 'hour'} is not of type 'array'

Failed validating 'type' in schema['properties']['runs']['items']['properties']['measurements']['items']['properties']['controls']['items']['properties']['timepoints']:
    {'items': {'$ref': '#definitions/timepoint'},
     'minItems': 1,
     'type': 'array'}

On instance['runs'][0]['measurements'][0]['controls'][0]['timepoints']:
    {'unit': 'hour', 'value': 0.0}"]
}

@mwes I made a new build. Could you try running these two documents again using intentparser2.sd2e.org?

https://docs.google.com/document/d/1fFcxyJyheMrzSsVoSsO6v7qHJKFf_0heIFtqEur02cg / YeastSTATES 1.0 Growth Curves Request : Works

The first file is failing in IP's golden file testing because the SBOL dictionary has a duplicate entry for Plate reader fluorescence emission frequency. The json file that you've generated is mapping the SR output to
'plate_reader_info.fluor_em': '530:nanometer',
'plate_reader_info.fluor_ex': '488:nanometer',

while IP is generating this as the output:
'plate_reader_info.emission': '530:nanometer',
'plate_reader_info.excitation': '488:nanometer',

This second file should run successfully. I will need this json file updated and reran in IP.

https://docs.google.com/document/d/1Mba6kqDila4W32Z46NEqXZFx868A3O36I9GIVOvMQ70 / YeastSTATES 1.0 Time Series Round 1: Fails generation from IP with errors. This looks like either an issue with a control or a measurement entry timepoints value - not generating as an array per schema? This is as before - the only desired change here was expanding the current "strain" definition beyond its current single string value:

Deleted duplicate mappings for plate_reader_info.emission/excitation

@tramyn Thanks, re-generated and merged: https://gitlab.sd2e.org/sd2program/cp-request/merge_requests/571

Thank you @mwes. golden files are passing!


stable-1.10: yq: remove -X flag

stable-1.10 branch uses old version of yq that doesn't support
the -X flag, so we need to remove it.
Fixes: #1011.
Signed-off-by: Salvador Fuentes<EMAIL_ADDRESS>

/test-ubuntu


Add standard-markdown plugin

Change README with a npm run lint suggestion that adds markdown fixing.
Details here: https://standardjs.com/#can-i-check-code-inside-of-markdown-or-html-files

Not doing this for now. First attempt was unfruitful.


How can I build the app as an installable or executable file ?

It's a great starter for making an app of cross platform.
I has a problem that  running the command npm run build  deployed into a folder with many files. Is it possible to build the app as an installable or executable file ?

@koolay
The current setup uses electron-packager for making production builds. If you need to create full installers then you'll need to use electron-builder. It can be a little complicated at first to setup because there are many configurations available, but it is easy to use with the current project structure. Support for electron-builder will come in the near future.

@SimulatedGREG
Thanks for your reply.


Rename question-attachment-thumbnail to attachment-thumbnail

fixes #856

:+1: let's merge once the build goes green.


Opening a stopped shared app causes infinite loading

Context
When you try opening a shared app which is stopped by directly going to the URL it gets stuck on loading infinitely.
Steps to reproduce:

Alice creates an app named awesome-app and shares it with Bob
Alice stops the app
Bob has the url of the app, lets say http:///hub/user/alice/panel-share-48e7de5/, when Bob visits the app, directly via the url, he sees an infinitely loading spinner.

Ideally a modal should open asking if the user wants to start the app, just like it happens when you click on the stopped app card in the UI.
See relevant comments:

https://github.com/nebari-dev/jhub-apps/pull/533#issuecomment-2489341579
https://github.com/nebari-dev/jhub-apps/pull/533#issuecomment-2489360023

Value and/or benefit
A nicer UX
Anything else?
No response

cc @jbouder @kildre

cc @jbouder @kildre

@aktech , I created a PR to fix the infinite loading issue. Essentially the page was expecting the api response to include form data, which it does not, given the current API returns a 404. In order to fix the issue I added some error handling.
That said, as i mentioned the api call currently returns a 404, which may or may not be the expected behavior...this may need to be addressed if not. Also, the current implementation does not allow a non-owner to start an app, so opening the start modal doesn't make sense here.

@jbouder I created a ticket to give shared user the ability to Start/Stop shared server/app, I'll work on this right away:
https://gitlab.jatic.net/jatic/team-metrostar/t-e-platform/-/issues/862
cc @aktech

@aktech , I created a PR to fix the infinite loading issue. Essentially the page was expecting the api response to include form data, which it does not, given the current API returns a 404. In order to fix the issue I added some error handling.

I think error handling makes sense.

That said, as i mentioned the api call currently returns a 404, which may or may not be the expected behavior...this may need to be addressed if not.

Also, the current implementation does not allow a non-owner to start an app, so opening the start modal doesn't make sense here.

That's the expected behaviour as the user doesn't owns the app the API doesn't return app details for it with that url.

Also, the API call from frontend is:
http://<IP_ADDRESS>:8000/services/japps/server/panel-share-48e7de5
This doesn't tells the owner in the url (nor in query params),  so there is no way for backend to know which user this app belongs to and hence unable to fetch details for that app.
We can make the API return app details if we pass in owner (via query param) in this API call.

@aktech , I created a PR to fix the infinite loading issue. Essentially the page was expecting the api response to include form data, which it does not, given the current API returns a 404. In order to fix the issue I added some error handling.

I think error handling makes sense.

That said, as i mentioned the api call currently returns a 404, which may or may not be the expected behavior...this may need to be addressed if not.

That's the expected behaviour as the user doesn't owns the app the API doesn't return app details for it with that url.

Also, the current implementation does not allow a non-owner to start an app, so opening the start modal doesn't make sense here.

This is not the expected behaviour. The backend allows this. The frontend shouldn't be checking the permissions, anyone can start a shared app given they have permissions and checking that is backend's responsibility. UI should rely on API response to infer if the user has permissions or not.

In reference to the last point...it looks like Kilian is working on an update to allow a non-owner to start, so I assume nothing more to do right now on my end.

That's the expected behaviour as the user doesn't owns the app the API doesn't return app details for it with that url.

Also, the API call from frontend is:
http://<IP_ADDRESS>:8000/services/japps/server/panel-share-48e7de5
This doesn't tells the owner in the url (nor in query params), so there is no way for backend to know which user this app belongs to and hence unable to fetch details for that app.
We can make the API return app details if we pass in owner (via query param) in this API call.

In reference to this issue, I can't see a situation where a non-owner would navigate directly to the app, and have the owner details to pass to the API. Am I missing something here?

In reference to this issue, I can't see a situation where a non-owner would navigate directly to the app

A user ca bookmark a shared app, then they can directly go that app via url.

and have the owner details to pass to the API. Am I missing something here?

The app url is something like this: http://<IP_ADDRESS>:8000/hub/user/aktech/panel-share-48e7de5/
then frontend makes a call to backend with: http://<IP_ADDRESS>:8000/services/japps/server/panel-share-48e7de5
This makes backend return 404, when say Alice is requesting aktech's server as the default owner is the user who makes the call and the default user doesn't owns that server.

In reference to this issue, I can't see a situation where a non-owner would navigate directly to the app

A user ca bookmark a shared app, then they can directly go that app via url.

and have the owner details to pass to the API. Am I missing something here?

The app url is something like this: http://<IP_ADDRESS>:8000/hub/user/aktech/panel-share-48e7de5/
then frontend makes a call to backend with: http://<IP_ADDRESS>:8000/services/japps/server/panel-share-48e7de5
This makes backend return 404, when say Alice is requesting aktech's server as the default owner is the user who makes the call and the default user doesn't owns that server.

Yup, I get the bookmark thing. And now that I think of it, I can get the owner from the server URL, but what should I then do with that? The GET call is still going to return a 404, which means I won't know the actual status of the server. So I can't tell if its started, stopped, etc.
That said, I'm think I'm getting lost in the conversation :D...I might need you to just spell out what you suggest I updated and I can do a deeper dive.

If the frontend can send the owner in the get request, we can update the backend to return the server details and then frontend will know the actual status of the server, which means we can have the same behaviour (in going via bookmark link) as we have when some one clicks on the app card when app is not running.
Your PR is definitely an improvement from the current situation, so I am going to merge it, we can implement the above in a follow up PR as that requires backend change as well.

If the frontend can send the owner in the get request, we can update the backend to return the server details and then frontend will know the actual status of the server, which means we can have the same behaviour (in going via bookmark link) as we have when some one clicks on the app card when app is not running.
Your PR is definitely an improvement from the current situation, so I am going to merge it, we can implement the above in a follow up PR as that requires backend change as well.

That makes sense. I'll coordinate with @kildre on who will work that update.

Awesome, sounds great! 🎉


Bad response from server: (502 [error,getplugins]) Bad Gateway

Hello
my rutorrent is stop after i upgrade my ubuntu to 16.4
`[15.08.2016 13:20:17] WebUI started.
[15.08.2016 13:20:17] Bad response from server: (502 [error,getplugins]) Bad Gateway
[15.08.2016 13:20:17] Bad response from server: (502 [error,getuisettings])
502 Bad Gateway

502 Bad Gateway
nginx

`
any help ??
thnx

This is most likely due to Ubuntu 16 using php7.0 as opposed to previous versions using php5.
If you rerun the latest version of the main script, it should resolve this, though if you have made changes to your nginx config you will lose these changes, so be prepared to reapply them if needed.
Please let me know how it goes.

can I reinstall the script!?

yes, just download the latest copy and you can run it as usual, it will ask if you want to skip the rtorrent/libtorrent install, which you can, and this will reduce the runtime to a minute or two.

thnx its work now

Any instructions where to download it and install it ?


Create a Linode in a group

It would be nice to be able to specify a group from the add linode page, or otherwise add a linode to an existing group.

This is already addressed in #235.

Doh, sorry.

No worries, thanks!