Add a setting to override path to .NET debugger

Issue Description
The VSCode extension by default downloads vsdbg and uses that to debug .NET applications. However, vsdbg is a proprietary program and its license forbids usage in certain environments and the only way to specify alternative debugger path seems to be dedicated for use in remote debugging only and has to be configured for each project separately (because it's a launch.json option). To help remedy this situation, some configuration option could be introduced to override path to local debugger in a machine–wide manner.
Or it could just be used to specify another, already existing local installation of vsdbg :smile:
Expected Behavior
There should be a way to use other debugger than vsdbg downloaded by omnisharp-vscode.
Actual Behavior
There is none.
Environment information
VSCode version: 1.51.1
C# Extension: 1.23.8
Mono Information
$ mono --version
Mono JIT compiler version <IP_ADDRESS> (tarball Thu Dec 10 12:48:21 AM CET 2020)
Copyright (C) 2002-2014 Novell, Inc, Xamarin Inc and Contributors. www.mono-project.com
        TLS:           __thread
        SIGSEGV:       altstack
        Notifications: epoll
        Architecture:  amd64
        Disabled:      none
        Misc:          softdebug
        Interpreter:   yes
        LLVM:          supported, not enabled.
        Suspend:       hybrid
        GC:            sgen (concurrent by default)

$ msbuild -version
Microsoft (R) Build Engine version 16.8.0-ci-20618-01 for Mono
Copyright (C) Microsoft Corporation. All rights reserved.

<IP_ADDRESS>801

Dotnet Information
.NET SDK (reflecting any global.json):
 Version:   5.0.101
 Commit:    d05174dc5a

Runtime Environment:
 OS Name:     arch
 OS Version:
 OS Platform: Linux
 RID:         arch-x64
 Base Path:   /usr/share/dotnet/sdk/5.0.101/

Host (useful for support):
  Version: 5.0.1
  Commit:  b02e13abab

.NET SDKs installed:
  2.1.811 [/usr/share/dotnet/sdk]
  2.2.207 [/usr/share/dotnet/sdk]
  3.0.103 [/usr/share/dotnet/sdk]
  3.1.404 [/usr/share/dotnet/sdk]
  5.0.101 [/usr/share/dotnet/sdk]

.NET runtimes installed:
  Microsoft.AspNetCore.All 2.1.23 [/usr/share/dotnet/shared/Microsoft.AspNetCore.All]
  Microsoft.AspNetCore.All 2.2.8 [/usr/share/dotnet/shared/Microsoft.AspNetCore.All]
  Microsoft.AspNetCore.App 2.1.23 [/usr/share/dotnet/shared/Microsoft.AspNetCore.App]
  Microsoft.AspNetCore.App 2.2.8 [/usr/share/dotnet/shared/Microsoft.AspNetCore.App]
  Microsoft.AspNetCore.App 3.0.3 [/usr/share/dotnet/shared/Microsoft.AspNetCore.App]
  Microsoft.AspNetCore.App 3.1.10 [/usr/share/dotnet/shared/Microsoft.AspNetCore.App]
  Microsoft.AspNetCore.App 5.0.1 [/usr/share/dotnet/shared/Microsoft.AspNetCore.App]
  Microsoft.NETCore.App 2.1.23 [/usr/share/dotnet/shared/Microsoft.NETCore.App]
  Microsoft.NETCore.App 2.2.8 [/usr/share/dotnet/shared/Microsoft.NETCore.App]
  Microsoft.NETCore.App 3.0.3 [/usr/share/dotnet/shared/Microsoft.NETCore.App]
  Microsoft.NETCore.App 3.1.10 [/usr/share/dotnet/shared/Microsoft.NETCore.App]
  Microsoft.NETCore.App 5.0.1 [/usr/share/dotnet/shared/Microsoft.NETCore.App]

To install additional .NET runtimes or SDKs:
  https://aka.ms/dotnet-download

The way that VS Code designed Extensions is that you can have multiple extensions installed. Each extension can provide its own extension commands, add in a language service, or a debugging service.
The omnisharp-vscode extension provides the Omnisharp-Roslyn language service and the Microsoft C# Debugger for .NET Core.
If there is another C# debugger that works with the Debug Adapter Protocol, they should create a VSCode extension that contributes a debugger.
For example, you can see this extension contributes two debuggers types coreclr and clr.
https://github.com/OmniSharp/omnisharp-vscode/blob/3117b4e9e053b4928ec979f360f93b39ab697c11/package.json#L1039-L1042

The way that VS Code designed Extensions is that you can have multiple extensions installed. Each extension can provide its own extension commands, add in a language service, or a debugging service.
The omnisharp-vscode extension provides the Omnisharp-Roslyn language service and the Microsoft C# Debugger for .NET Core.
If there is another C# debugger that works with the Debug Adapter Protocol, they should create a VSCode extension that contributes a debugger.
For example, you can see this extension contributes two debuggers types coreclr and clr.
https://github.com/OmniSharp/omnisharp-vscode/blob/3117b4e9e053b4928ec979f360f93b39ab697c11/package.json#L1039-L1042

If there is another C# debugger that works with the Debug Adapter Protocol, they should create a VSCode extension that contributes a debugger.

So, if I understand this correctly, another extension can be created to provide a separate .NET debugger for users to choose when debugging .NET applications. Which is nice, but it doesn't solve the entire issue, as this would require changes to each launch.json to include a launch option using another debugger. Which is still quite far from more user–friendly solution like allowing developers to configure path to debugger to use in machine–wide settings.json, like omnisharp.monoPath allows for Mono and omnisharp.path does for omnisharp-roslyn.
To be clear, I'm not asking for support for debuggers other than vsdbg here, even if they happen to be DAP–compatible, just feature parity in configuration options for integrations with external components. Being able to actually use a different debugger would only be a nice side effect.

If there is another C# debugger that works with the Debug Adapter Protocol, they should create a VSCode extension that contributes a debugger.

So, if I understand this correctly, another extension can be created to provide a separate .NET debugger for users to choose when debugging .NET applications. Which is nice, but it doesn't solve the entire issue, as this would require changes to each launch.json to include a launch option using another debugger. Which is still quite far from more user–friendly solution like allowing developers to configure path to debugger to use in machine–wide settings.json, like omnisharp.monoPath allows for Mono and omnisharp.path does for omnisharp-roslyn.
To be clear, I'm not asking for support for debuggers other than vsdbg here, even if they happen to be DAP–compatible, just feature parity in configuration options for integrations with external components. Being able to actually use a different debugger would only be a nice side effect.

I agree that it would be nice to switch between different debuggers, the issue is that each debugger could have different launch/attach configurations. The only two required fields are noDebug and __restart. The rest is up to the debugger's implementation.
Reference: https://microsoft.github.io/debug-adapter-protocol/specification#Requests_Launch
For example, lets say we want to switch from the Windows .NET Core Debugger to the Mono Debugger.
Their launch configuration expects only the keys: program, args, cwd, runtimeExecutable, runtimeArgs, passDebugOptionsViaEnvironmentVariable, env, externalConsole, console.
From https://github.com/microsoft/vscode-mono-debug/blob/488eff1234a6d5be291b89dc30cba3f2d08de2c5/package.json#L143
However, this extension's debugger has a much larger list that is not included in the mono one. E.g. justMyCode, pipeTransport, etc...
From https://github.com/OmniSharp/omnisharp-vscode/blob/3117b4e9e053b4928ec979f360f93b39ab697c11/package.json#L1048
The way it was designed by VS Code it was if you needed to switch to a different debugger, you would use a different debug configuration.
If you have values that are shared across the configurations, you could use VS Code input variables or set environment variables and reference them by ${env:<NAME>}.

I agree that it would be nice to switch between different debuggers, the issue is that each debugger could have different launch/attach configurations. The only two required fields are noDebug and __restart. The rest is up to the debugger's implementation.
Reference: https://microsoft.github.io/debug-adapter-protocol/specification#Requests_Launch
For example, lets say we want to switch from the Windows .NET Core Debugger to the Mono Debugger.
Their launch configuration expects only the keys: program, args, cwd, runtimeExecutable, runtimeArgs, passDebugOptionsViaEnvironmentVariable, env, externalConsole, console.
From https://github.com/microsoft/vscode-mono-debug/blob/488eff1234a6d5be291b89dc30cba3f2d08de2c5/package.json#L143
However, this extension's debugger has a much larger list that is not included in the mono one. E.g. justMyCode, pipeTransport, etc...
From https://github.com/OmniSharp/omnisharp-vscode/blob/3117b4e9e053b4928ec979f360f93b39ab697c11/package.json#L1048
The way it was designed by VS Code it was if you needed to switch to a different debugger, you would use a different debug configuration.
If you have values that are shared across the configurations, you could use VS Code input variables or set environment variables and reference them by ${env:<NAME>}.

The way it was designed by VS Code it was if you needed to switch to a different debugger, you would use a different debug configuration.

Understood, thank you for the explanation. So, the only thing that remains is my request to add a setting for overriding path to vsdbg, as I said before:

To be clear, I'm not asking for support for debuggers other than vsdbg here, […], just feature parity in configuration options for integrations with external components.

Considering it's a very niche use case, I'll understand if you guys decide that it's unlikely to be implemented anytime soon. If so, feel free to close this issue.

The way it was designed by VS Code it was if you needed to switch to a different debugger, you would use a different debug configuration.

Understood, thank you for the explanation. So, the only thing that remains is my request to add a setting for overriding path to vsdbg, as I said before:

To be clear, I'm not asking for support for debuggers other than vsdbg here, […], just feature parity in configuration options for integrations with external components.

Considering it's a very niche use case, I'll understand if you guys decide that it's unlikely to be implemented anytime soon. If so, feel free to close this issue.


Reopen PR #8

Reopen #8

Let me know if there is still an issue @ljwolf

Not sure why some tests in test_heu.py fail occasionally.

Hmm... it's not all solvers, only the geodataframe and networkx ones...

I guess it's because the heuristic algorithms can produce suboptimal solutions. However, I didn't expect it to happen that often. One solution to prevent failing tests would be to set the random seed, i.e. to replace all occurrences of
cluster_object = MaxPRegionsHeu()
with
cluster_object = MaxPRegionsHeu(random_state=SOME_INTEGER_WHERE_THE_TESTS_PASS)
in test_heu.py. Do you consider going this path OK?

Yeah, that'd be appropriate: if the algorithm is nondeterminstic, it needs
to use a seed.
On Wed, May 9, 2018 at 10:20 AM yogabonito<EMAIL_ADDRESS>wrote:

I guess it's because the heuristic algorithms can produce suboptimal
solutions. However, I didn't expect it to happen that often. One solution
to prevent failing tests would be to set the random seed, i.e. to replace
all occurrences of
cluster_object = MaxPRegionsHeu()
with
cluster_object =
MaxPRegionsHeu(random_state=SOME_INTEGER_WHERE_THE_TESTS_PASS)
in test_heu.py. Do you consider going this path OK?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/pysal/region/pull/9#issuecomment-387677932, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ACJY84gXWzOA5JOQNc11UXIFhZ6v4uNXks5twrTCgaJpZM4T3dQ3
.

--
Levi John Wolf
Lecturer in Quantitative Human Geography | University of Bristol
Fellow | Center for Spatial Data Science, University of Chicago
Associate Member | Center for Multilevel Modeling, University of Bristol
Interim Director | Q-Step Program, University of Bristol
ljwolf.org

Man, still says "cannot be rebased due to conflicts." I'll see if I can figure this out.


C\task\PrintingTokens.c

Complete the task and attach a screenshot of your code and output. You may take the input yourself according to the task.

can you assign me this task?


Synchronous search interface

Exposed Index.searchSync() to search an Index synchronously, fixing #21.
Raw methods have been exposed as protected for internal manipulation of request's raw bytes.

@clement-leprovost-algolia: Does this look good to you?

@ElPicador and @clement-leprovost-algolia, does this now LGTY? :smile:

LGTM from a pure Java perspective

LTGM


UI/Qt: Fix long URLs showing the end instead of domain

Cursor in LocationEdit (Address bar) did not return to front after loading - because of that long URLs would hide the domain (location).
Before:

SetCursorPosition() needed two calls as with only one in highlight_location block it would still default to the end after load.
After:
https://github.com/user-attachments/assets/02bb89b1-ae87-4fbd-88fb-c346ca7a9574

This works nicely :)
You also need to update your commit message to use the correct prefix. You can do this using git commit --amend.

Please squash the two commits

Please squash the two commits, if that doesn't work try resetting to the previous commit and rewording it

I merged in changes from master between both of the commits, so both squashing and resetting - added all of the merged in changes as well. Do you feel that closing this pull and removing the branch to start over with single correct commit would be the best, to keep good clean git history in ladybird ?

Please use git rebase instead of git merge for the future. Uou can try resetting to the first commit in the PR and running git rebase master to be up to date tieh master.


refactor: detach data units from label rows in the project file structure

Objectives:

Detach data units from label rows in the logic to be able to fetch unannotated data without modifying label row states.
Move data units relevant info (not its labels) to the db while not breaking older projects.
Refactor ProjectFileStructure to enable calls from it to the db.
Update DBConnection to accept different project file structures, not only the default one, in case the user decides to store its data in some other layout (or we change the way the project is structured).

Closing this draft in favour of https://github.com/encord-team/encord-active/pull/329 because this one pulled already non-existent (squashed) commits.


docs: CONTRIBUTING.md and CODE_OF_CONDUCT.md

@kiprasmel @maxiejbe please review

@kiprasmel @maxiejbe please review

Coverage remained the same at 93.974% when pulling ea18a0af2ab9d753419a82b7baf0a52e2ec344b3 on docs/contribution-pashma into c54e8db3cc6e1de6f2f7739bd112379184914376 on master.

Coverage remained the same at 93.974% when pulling ea18a0af2ab9d753419a82b7baf0a52e2ec344b3 on docs/contribution-pashma into c54e8db3cc6e1de6f2f7739bd112379184914376 on master.

Honestly, not a fan of "codes of conduct" -- full of controversy and politics. I always assume positive intentions and I don't think we need one imo.
As for CONTRIBUTING - can't decide if it's lengthy because it explains everything well, or too long and would scare off potential contributors:D Perhaps focusing on the key essentials would be useful (our contributors wouldn't be newbies anyway I think, because the use case of the module is fairly specific and you aren't likely to search for it if you haven't at least had your feet wet).
Btw, are we going to start using semantic versioning? I've used for a while in [1] - it's great!
[1] the project that got me here in the first place:D https://github.com/kiprasmel/turbo-schedule

Honestly, not a fan of "codes of conduct" -- full of controversy and politics. I always assume positive intentions and I don't think we need one imo.
As for CONTRIBUTING - can't decide if it's lengthy because it explains everything well, or too long and would scare off potential contributors:D Perhaps focusing on the key essentials would be useful (our contributors wouldn't be newbies anyway I think, because the use case of the module is fairly specific and you aren't likely to search for it if you haven't at least had your feet wet).
Btw, are we going to start using semantic versioning? I've used for a while in [1] - it's great!
[1] the project that got me here in the first place:D https://github.com/kiprasmel/turbo-schedule

Honestly, not a fan of "codes of conduct" -- full of controversy and politics. I always assume positive intentions and I don't think we need one imo.

Agree, and that is why the doc is so short.

it's lengthy because it explains everything well, or too long

I believe it is the first one

Btw, are we going to start using semantic versioning? I've used for a while in [1] - it's great!

Yes, we are. And that will be done basing on commit messages. That is the reason we have a long CONTRIBUTING.md Will check the link.

Also made "Rebase and merge" as the only option for PRs. Thus all the commits will be bebased to master.


Misdecompilation while using a negative offset on a given address (x86)

Env: Ghidra 9.0, Linux, x86
Disas:
49 89 44        MOV        qword ptr [R12 + -0x8],vector48
24 f8
49 c7 04        MOV        qword ptr [R12],0x0
24 00 00
00 00
49 c7 44        MOV        qword ptr [R12 + 0x8],0x0
24 08 00
00 00 00
49 c7 44        MOV        qword ptr [R12 + 0x10],0x0
24 10 00
00 00 00

Decomp:
    vector48_data->p1 = vector48;
    vector48_data->p0 = NULL;
    vector48_data->p1 = NULL;
    vector48_data->p2 = NULL;

R12 corresponds to vector48_data. If it's not obvious, the first decompilation line is wrong (it's interpreting the -8 as +8).
For the context, vector48_data is a pointer to a struct with 3 pointers (void *p0, void *p1, void *p2). As far as I can remember, that issue was already present before assigning a struct type to vector48_data.
Note: the decompiler might be confused because vector48_data is an aligned pointer derived from a classic heap allocated buffer (that first pointer assignment is actually a way of storing the original allocated data pointer).

The decompiler isn't completely off base, since the vector48_data pointer is a pointer to a structure of a certain size.  The pointer can also act as a pointer to an array of the structures.
Agree it isn't correct, and the better option would be to display the negative access in another way.  If the structure size is changed to just 2 fields you get:
  param_1[-1].field_0x8 = in_RAX;
  param_1->field_0x0 = 0;
  param_1->field_0x8 = 0;
  param_1[1].field_0x0 = 0;

Which seems much closer to correct for the accesses to the structure.  The single negative index didn't try and turn it into an array, however the positive index past the end of the structure changed the access into an array access.
There has been discussions of allowing negative offsets for structure fields for this type of situation.

Just to help with this issue (because I believe it's an important one), here is a reproducible case:
#include <stdlib.h>
#include <stdio.h>
#include <stdint.h>

struct x {
    const int *a;
    const int *b;
    const int *c;
};

/*
 *       .---> +--------+ <-- heap alloc
 *       |     :        :
 *       |     :        :
 *       |     +--------+
 *       `---- |  orig  |
 *             +--------+
 *             |   a    |
 *             +--------+
 *             |   b    |
 *             +--------+
 *             |   c    |
 *             +--------+
 *             :        :
 *             :        :
 *             +--------+
 */

static const int x_a[] = {1, 2, 3};
static const int x_b[] = {4, 5, 6};
static const int x_c[] = {7, 8, 9};

static struct x *aligned_x_alloc(void)
{
    const size_t header_size = sizeof(uintptr_t) /* orig */
                             + 16;               /* align padding */
    const size_t buf_size = header_size + sizeof(struct x);

    void *buf = malloc(buf_size);
    if (!buf)
        return NULL;

    struct x *x = (struct x *)((uintptr_t)(buf + header_size) & ~0xf);
    x->a = x_a;
    x->b = x_b;
    x->c = x_c;

    void **orig = (void **)(((uint8_t *)x) - sizeof(uintptr_t));
    *orig = buf;

    return x;
}

void aligned_x_free(struct x *x)
{
    void **orig = (void **)(((uint8_t *)x) - sizeof(uintptr_t));
    printf("free-ing struct x %p {%p,%p,%p} @ heap-alloc %p\n",
           x, x->a, x->b, x->c, orig);
    free(*orig);
}

int main(void)
{
    struct x *x = aligned_x_alloc();
    if (!x)
        return -1;

    aligned_x_free(x);
    return 0;
}

Built with gcc -O2 (GCC 8.3.0 on Linux / x86_64), here is the best I could obtain with Ghidra 9.0.2:
int main(void)

{
    int ret;
    void *buf;
    x *x;

    buf = malloc(0x30);
    ret = -1;
    if (buf != NULL) {
        x = (x *)((long)buf + 0x18U & 0xfffffffffffffff0);
        x->a = (int *)0x102060;
        x->b = x_b;
        x->c = x_c;
        x->b = buf;
        aligned_x_free(x);
        ret = 0;
    }
    return ret;
}

Again of the context, the problematic line is x->b = buf.
I'm not sure this is related but you may also notice that for some reason Ghidra is confused about x->a type:

I was able to duplicate the problem from your source sample. Thanks for the concise bug report. I have a fix in a branch that should get merged shortly. The bug was basically an unsigned remainder that should have been signed.  Your example now looks like

x * aligned_x_alloc(void)
{
int *buf;
x *x;
buf = (int *)malloc(0x30);
if (buf == (int *)0x0) {
x = (x *)0x0;
}
else {
x = (x *)((ulong)(buf + 6) & 0xfffffffffffffff0);
x->a = (int *)0x400708;
x->b = x_b;
x->c = x_c;
x[-1].c = buf;
}
return x;
}

Ah nice, that's much better, thank you. Should I open another issue about x->a = (int *)0x400708;?


Initialize Database

User story

As a user
I want / need a database that holds my user data, booked desks, company data etc.
So that I can efficiently book desks

Acceptance criteria

Database initialization should follow the specified design
Database should contain dummy data to allow easy testing of future features
SQL Database should be used, industry partner suggested MS-SQL-Server Express or PostgreSQL
Dev environment setup in docker
Research production databases

Definition of done (DoD)

Added only after week 5
The same for all features
Here goes the project specific part

DoD general criteria

Feature has been fully implemented
Feature has been merged into the mainline
All acceptance criteria were met
Product owner approved features
All tests are passing
Developers agreed to release

As the database design fits our idea, some suggestions for dummy data: Add an admin role, normal user and an intial admin role (user that registers company with service and has the most permissions) to the roles for testing; Add a dummy company with maybe one normal registered user, one admin and one initial admin; Maybe add one building, one room and one desk or so registered with that company to the database. These are just some suggestions, feel free to add more or less.
xilef45: Pull-Request: init DB + add Dummy Data https://github.com/amosproj/amos2022ws05-shared-desk-mgmt/pull/5


Create devcontainer.json beta134

adn/@beta134

PR Checklist

[ ] No API changes were made (or the changes have been approved)
[ ] No major design changes were made (or the changes have been approved)
[ ] Added test (or behavior not changed)
[ ] Updated API documentation (or API not changed)
[ ] Added license to new files (if any)
[ ] Added Python wrapping to new files (if any) as described in ITK Software Guide Section 9.5
[ ] Added ITK examples for all new major features (if any)

Refer to the ITK Software Guide for
further development details if necessary.

Purpose of this PR is unclear, and that does not even look like valid JSON.

Looks spam. Joining date to GitHub and activity with similar PRs to other repositories indicate so. Closing.

I just reported spam to GitHub.


feat: implement avatar section

implements avatar selection page
fixes #118

Any update on this? @Akshola00

Any update on this? @Akshola00

Fixing this now

@Akshola00

ready for review


Feature request: disallow import from parent directory

I am not sure how others do this, but at least in our project we are using baseUrl in tsconfig and almost all of our imports are relative to the root of the repo, e.g.:
// should pass
import { SomeService } from 'common/services/some.service';
import { SomeService } from 'common/services';  // if you have index.ts
import { Foo } from './util/foo';

// should fail
import { SomeService } from '../../services/some.service';
import { SomeService } from '../services/some.service';

A rule to enforce this would be quite nice. How about no-parent-dir-import?
I am willing to investigate and make a PR if there is some interest.

This looks like a tslint feature, not codelyzer. Nothing Angular-specific here, right?

yep, nothing angular specific - but it might be easier / faster to include it here than in the tslint itself. I'll open the issue there and reference this one.
As for node_modules, it just goes down to order - it tries base directory first and then fallbacks to node_modules or any other folder dictated by compiler options paths property in tsconfig


Add unit test and fix golint issues

Codecov Report

Merging #1 (6fceab4) into master (c47c6a9) will increase coverage by 10.23%.
The diff coverage is 80.00%.

@@             Coverage Diff             @@
##           master       #1       +/-   ##
===========================================
+ Coverage   80.82%   91.06%   +10.23%
===========================================
  Files           3        3
  Lines         579      582        +3
===========================================
+ Hits          468      530       +62
+ Misses         87       38       -49
+ Partials       24       14       -10

Impacted Files
Coverage Δ

metrics_set.go
100.00% <ø> (+4.28%)
:arrow_up:

pusher.go
89.90% <0.00%> (+11.92%)
:arrow_up:

prom_entry.go
78.75% <100.00%> (+18.23%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c47c6a9...6fceab4. Read the comment docs.


[release 1.11] Bump base images / bump containerd

Pull Request Motivation
Update base images before a release and patch containerd vuln in minimal way (see commit message)
Kind
/kind cleanup
Release Note
NONE

/test pull-cert-manager-release-1.11-make-test


fix(tokens): update text-02 color token value

Closes https://github.com/carbon-design-system/carbon-website/issues/1374
text-02 color token was updated when we made the helper text changes a few months ago, but the token was not updated on the site
Changelog
Changed

text-02 is now Gray70 and not Gray80

Closing in favor of https://github.com/carbon-design-system/carbon-website/pull/1378


⚠ Bofrost.es has degraded performance

In 7919240, Bofrost.es (https://www.bofrost.es) experienced degraded performance:

HTTP code: 200
Response time: 1675 ms

Resolved: Bofrost.es performance has improved in a13059c after 21 minutes.


convert-argv.js adds HotModuleReplacementPlugin even when already available

Do you want to request a feature or report a bug?
To me it feels more like a bug.

What is the current behavior?
If the argv contains the --hot option, the HotModuleReplacementPlugin is added without further checks.
If the current behavior is a bug, please provide the steps to reproduce.

Add new webpack.plugins.HotModuleReplacementPlugin() to webpackConfig.plugins
Invoke webpack (or webpack-dev-server) bin with --hot flag.
Break after bin/convert-argv.js:383
Inspect options.plugins (plugin included twice)

Manifests in a weird error:

SyntaxError: missing ) after argument list

What is the expected behavior?
--hot should be a noop if already added as plugin
Please mention other relevant information such as the browser version, Node.js version, webpack version and Operating System.
I think you could consider it "wrong configuration" and maybe want to close it directlly, then it at least serves better discoverability when facing the error.
A simple fix within convert-argv.js would be the following:
var hasHotModuleReplacementPlugin = options.plugins.some((plugin) => {
  return plugin.constructor.name === 'HotModuleReplacementPlugin';
});

if (!hasHotModuleReplacementPlugin) {
  options.plugins.push(new HotModuleReplacementPlugin());
}

I was also bit by this issue. It was very difficult to track down the source of the problem!


Demo doesn't load

ReferenceError: Uj is not defined
Chrome 97.0.4692.99

Fixed with 9f436f1b3f63b1489f4fd24384b838b52b19c646
I wonder if it has been broken since I changed the demo URL > 1 year ago...
Thank you for reporting!


bad image tag in deploy/local-path-storage.yaml

The image tag didn't change in https://github.com/rancher/local-path-provisioner/blob/master/deploy/local-path-storage.yaml#L65 while the script in the configmap has changed to use env var for path. This would yield VOL_DIR: param not set error in the helper pod.

@zhxu73
Thank you.
We will fix it soon. Before that, you can use the stable release https://github.com/rancher/local-path-provisioner/tree/v0.0.21.


Error while installing requirements.txt

OS : Window 10
Pip : 18.1
Python : 3.6
I have set a virtual environment using virtualenv following the manuels on the book
and tried to install requirements.txt using pip install -r requirements.txt
However, it gives me following errors while installing the packages.
Could you give me some advices what to do?
I have tried pip install --upgrade setuptools to check if it was out of date but it`s up to date and everything looks fine... except those errors
Error with pyproj
Collecting pyproj==<IP_ADDRESS> (from -r requirements.txt (line 82))
  Using cached https://files.pythonhosted.org/packages/29/72/5c1888c4948a0c7b736d10e0f0f69966e7c0874a660222ed0a2c2c6daa9f/pyproj-<IP_ADDRESS>.tar.gz
    Complete output from command python setup.py egg_info:
    using bundled proj4..
    Traceback (most recent call last):
      File "c:\users\seungj~1\desktop\progra~1\til\deeple~1\src\deeple~1\lib\site-packages\setuptools\msvc.py", line 489, in _find_latest_available_vc_ver
        return self.find_available_vc_vers()[-1]
    IndexError: list index out of range

    During handling of the above exception, another exception occurred:

    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "C:\Users\SEUNGJ~1\AppData\Local\Temp\pip-install-ppenl6wd\pyproj\setup.py", line 72, in <module>
        objects = cc.compile(['nad2bin.c', 'src/pj_malloc.c'])
      File "c:\users\seung ju\appdata\local\programs\python\python36\Lib\distutils\_msvccompiler.py", line 345, in compile
        self.initialize()
      File "c:\users\seung ju\appdata\local\programs\python\python36\Lib\distutils\_msvccompiler.py", line 238, in initialize
        vc_env = _get_vc_env(plat_spec)
      File "c:\users\seungj~1\desktop\progra~1\til\deeple~1\src\deeple~1\lib\site-packages\setuptools\msvc.py", line 185, in msvc14_get_vc_env
        return EnvironmentInfo(plat_spec, vc_min_ver=14.0).return_env()
      File "c:\users\seungj~1\desktop\progra~1\til\deeple~1\src\deeple~1\lib\site-packages\setuptools\msvc.py", line 843, in __init__
        self.si = SystemInfo(self.ri, vc_ver)
      File "c:\users\seungj~1\desktop\progra~1\til\deeple~1\src\deeple~1\lib\site-packages\setuptools\msvc.py", line 485, in __init__
        self.vc_ver = vc_ver or self._find_latest_available_vc_ver()
      File "c:\users\seungj~1\desktop\progra~1\til\deeple~1\src\deeple~1\lib\site-packages\setuptools\msvc.py", line 492, in _find_latest_available_vc_ver
        raise distutils.errors.DistutilsPlatformError(err)
    distutils.errors.DistutilsPlatformError: Microsoft Visual C++ 14.0 is required. Get it with "Microsoft Visual C++ Build Tools": https://visualstudio.microsoft.com/downloads/

    ----------------------------------------
Command "python setup.py egg_info" failed with error code 1 in C:\Users\SEUNGJ~1\AppData\Local\Temp\pip-install-ppenl6wd\pyproj\

Error with shapely
Collecting shapely==1.6.4.post1 (from -r requirements.txt (line 97))
  Downloading https://files.pythonhosted.org/packages/7d/3c/0f09841db07aabf9cc387662be646f181d07ed196e6f60ce8be5f4a8f0bd/Shapely-1.6.4.post1.tar.gz (224kB)
    100% |████████████████████████████████| 225kB 322kB/s
    Complete output from command python setup.py egg_info:
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "C:\Users\SEUNGJ~1\AppData\Local\Temp\pip-install-oi7jf2j7\shapely\setup.py", line 80, in <module>
        from shapely._buildcfg import geos_version_string, geos_version, \
      File "C:\Users\SEUNGJ~1\AppData\Local\Temp\pip-install-oi7jf2j7\shapely\shapely\_buildcfg.py", line 200, in <module>
        lgeos = CDLL("geos_c.dll")
      File "c:\users\seung ju\appdata\local\programs\python\python36\Lib\ctypes\__init__.py", line 348, in __init__
        self._handle = _dlopen(self._name, mode)
    OSError: [WinError 126] \uc9c0\uc815\ub41c \ubaa8\ub4c8\uc744 \ucc3e\uc744 \uc218 \uc5c6\uc2b5\ub2c8\ub2e4

    ----------------------------------------
Command "python setup.py egg_info" failed with error code 1 in C:\Users\SEUNGJ~1\AppData\Local\Temp\pip-install-oi7jf2j7\shapely\

Error with tensorflow 1.4.1
Collecting tensorflow==1.4.1 (from -r requirements.txt (line 104))
  Could not find a version that satisfies the requirement tensorflow==1.4.1 (from -r requirements.txt (line 104)) (from versions: 1.2.0rc2, 1.2.0, 1.2.1, 1.3.0rc0, 1.3.0rc1, 1.3.0rc2, 1.3.0, 1.4.0rc0, 1.4.0rc1, 1.4.0, 1.5.0rc0, 1.5.0rc1, 1.5.0, 1.5.1, 1.6.0rc0, 1.6.0rc1, 1.6.0, 1.7.0rc0, 1.7.0rc1, 1.7.0, 1.7.1, 1.8.0rc0, 1.8.0rc1, 1.8.0, 1.9.0rc0, 1.9.0rc1, 1.9.0rc2, 1.9.0, 1.10.0rc0, 1.10.0rc1, 1.10.0, 1.11.0rc0, 1.11.0rc1, 1.11.0rc2, 1.11.0, 1.12.0rc0, 1.12.0rc1, 1.12.0rc2, 1.12.0)
No matching distribution found for tensorflow==1.4.1 (from -r requirements.txt (line 104))

That is weird. The line:
distutils.errors.DistutilsPlatformError: Microsoft Visual C++ 14.0 is required. Get it with "Microsoft Visual C++ Build Tools": https://visualstudio.microsoft.com/downloads/
Seems like looking into. Do you have that installed?

@DOsinga
Thanks, I have downloaded the "Microsoft Visual C++ Build Tools" and now I have no problem with pyproj module but still a problem remains  with shapely but this time, An OS error has emerged while installing the ```requirements.txt`` using pip.
Any suggestion? Thank you very much in advance.
Error with shapely
d/Shapely-1.6.4.post1.tar.gz
    Complete output from command python setup.py egg_info:
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "C:\Users\SEUNGJ~1\AppData\Local\Temp\pip-install-vnwbc04r\shapely\setup.py", line 80, in <module>
        from shapely._buildcfg import geos_version_string, geos_version, \
      File "C:\Users\SEUNGJ~1\AppData\Local\Temp\pip-install-vnwbc04r\shapely\shapely\_buildcfg.py", line 200, in <module>
        lgeos = CDLL("geos_c.dll")
      File "c:\users\seung ju\appdata\local\programs\python\python36\Lib\ctypes\__init__.py", line 348, in __init__
        self._handle = _dlopen(self._name, mode)
    OSError: [WinError 126] \uc9c0\uc815\ub41c \ubaa8\ub4c8\uc744 \ucc3e\uc744 \uc218 \uc5c6\uc2b5\ub2c8\ub2e4

    ----------------------------------------
Command "python setup.py egg_info" failed with error code 1 in C:\Users\SEUNGJ~1\AppData\Local\Temp\pip-install-vnwbc04r\shapely\

That error looks like something Korean maybe? Or at least the \uc9c0\uc815\ub41c \ubaa8\ub4c8\uc744 \ucc3e\uc744 \uc218 \uc5c6\uc2b5\ub2c8\ub2e4 bit.
It looks like getting shapely to work on Windows is tricky:
https://stackoverflow.com/questions/13144158/python-geos-and-shapely-on-windows-64
Has some suggestions. Starting from anaconda might be a good idea really. It gets you a lot of the other modules I am using. I've never used that on Windows though.

Any luck with this?

@DOsinga No :( It just repeatedly giving me the same error.

Following your suggestion, I tried with anaconda,  made a virtual environment using anaconda and tried to install the requirements.txt file using pip on the anaconda prompt.
However, the Error stays the same.
Error with Shapely
Collecting shapely==1.6.4.post1 (from -r requirements.txt (line 97))
  Using cached https://files.pythonhosted.org/packages/7d/3c/0f09841db07aabf9cc387662be646f181d07ed196e6f60ce8be5f4a8f0bd/Shapely-1.6.4.post1.tar.gz
    Complete output from command python setup.py egg_info:
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "C:\Users\SEUNGJ~1\AppData\Local\Temp\pip-install-tmhad1rz\shapely\setup.py", line 80, in <module>
        from shapely._buildcfg import geos_version_string, geos_version, \
      File "C:\Users\SEUNGJ~1\AppData\Local\Temp\pip-install-tmhad1rz\shapely\shapely\_buildcfg.py", line 200, in <module>
        lgeos = CDLL("geos_c.dll")
      File "C:\Users\Seung Ju\Anaconda3\envs\DeepLearningCB\lib\ctypes\__init__.py", line 348, in __init__
        self._handle = _dlopen(self._name, mode)
    **OSError: [WinError 126] \uc9c0\uc815\ub41c \ubaa8\ub4c8\uc744 \ucc3e\uc744 \uc218 \uc5c6\uc2b5\ub2c8\ub2e4**

I also do not understand what that
 OSError: [WinError 126] \uc9c0\uc815\ub41c \ubaa8\ub4c8\uc744 \ucc3e\uc744 \uc218

means so i simply comment it out by adding # in the requirements.txt #shapely==1.6.4.post1
but then anther problem pops up with  geopandas
for commenting shapely out.
Error with shapely from geopandas
Collecting widgetsnbextension==3.1.0 (from -r requirements.txt (line 114))
  Using cached https://files.pythonhosted.org/packages/20/9c/bb3d5bad8be29ce1fe3f09b991c3ad8e05b0f97302b91c9fb13bdea94219/widgetsnbextension-3.1.0-py2.py3-none-any.whl
Collecting shapely (from geopandas==0.3.0->-r requirements.txt (line 33))
  Using cached https://files.pythonhosted.org/packages/a2/fb/7a7af9ef7a35d16fa23b127abee272cfc483ca89029b73e92e93cdf36e6b/Shapely-1.6.4.post2.tar.gz
    Complete output from command python setup.py egg_info:
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "C:\Users\SEUNGJ~1\AppData\Local\Temp\pip-install-qflihv3t\shapely\setup.py", line 80, in <module>
        from shapely._buildcfg import geos_version_string, geos_version, \
      File "C:\Users\SEUNGJ~1\AppData\Local\Temp\pip-install-qflihv3t\shapely\shapely\_buildcfg.py", line 200, in <module>
        lgeos = CDLL("geos_c.dll")
      File "C:\Users\Seung Ju\Anaconda3\envs\DeepLearningCB\lib\ctypes\__init__.py", line 348, in __init__
        self._handle = _dlopen(self._name, mode)
    OSError: [WinError 126] \uc9c0\uc815\ub41c \ubaa8\ub4c8\uc744 \ucc3e\uc744 \uc218 \uc5c6\uc2b5\ub2c8\ub2e4

    ----------------------------------------
Command "python setup.py egg_info" failed with error code 1 in C:\Users\SEUNGJ~1\AppData\Local\Temp\pip-install-qflihv3t\shapely\

Should i just comment geopanas out too?
And It seems like pip can not find the tensorflow version 1.4.1 so i changed it to 1.4.0 which seem to work

What you could try is start with a anaconda environment and either install things on demand (anaconda should have most dependencies) without a version number, or after installing anaconda, try to install pip-tools:
pip install pip-tools

and then do a fresh pip-compile to create a new requirements.txt - that might take care of the version mismatch you seem to have. I.e.:
pip-compile
pip install -r requirements.txt

Let me know if this works.

@DOsinga
Hi, first of all, Happy new year!
I have installed all the dependencies by myself on Anaconda environment.
I have had problems with installing  pip install fiona and  pip install geopandas  which seems like a solid and recurrent problem on window fiona, geopandas
However
With the help of the blog,
i typed conda install -c conda-forge geopandas which installed a lot of packages including pyproj, shapely, geopandas, fiona etc..
The rest of packages that were not installed using the above command, i installed each of them manually.
Thanks for helping me out!

It's good to hear it seems to work now. This really should be easier!


Quaternion interpolation issue

@tfili already reported the details to @bagnell

Assuming this is still a bug (and any of you remember what the issue is) we should probably put some details here before people forget.  It's already been 4 months.

I'm closing this because it's been almost a year and this issue has no information in it.
@tfili @bagnell please open a new issue if you know what this was about.


Setup MIRI Test

This PR sets up MIRI to analyze potential memory safety violations arising from unsafe code at the MIR level.
MIRI is an interpreter that performs analysis at the MIR (Mid-level Intermediate Representation) level. Tests must be expressible in MIR to be testable with MIRI. Consequently, we are leveraging some test cases from the ACS project, originally written in C, by rewriting them in Rust.
Advantages of the Current Approach
To establish a Rust-based testing environment, I have added a test_utils module, allowing tests to be conducted at the function level rather than running the entire codebase.
#[test]
fn rmi_features() {
  let ret = rmi::<FEATURES>(&[0]);
  assert_eq!(ret[0], SUCCESS);
  ...
}

#[test]
fn rmi_version() {
  let ret = rmi::<VERSION>(&[encode_version()]);
  assert_eq!(ret[0], SUCCESS);
  ...
}

This modular testing approach facilitates the use of various Rust verification tools, such as MIRI and cargo-fuzzer. Additionally, by adding an abstraction layer for assembly, I expect to enhance our capability to verify code using tools like Kani.
Relationship with ACS Tests
This approach does have the drawback of duplicating tests already covered by ACS. However, it provides the significant advantage of enabling Rust-based testing without the need for an ACS + FVP setup. Considering these pros and cons, the next steps will focus on selectively incorporating ACS test cases that involve unsafe code flows into our Rust environment, rather than porting all ACS test cases.
This selective approach ensures we maintain a robust testing framework while leveraging Rust's advanced tooling for safety and verification.
How to test
MIRI Test
$ ./scripts/tests/miri.sh
running 10 tests
test r#macro::test::eprintln_with_format ... ok
test r#macro::test::eprintln_without_arg ... ok
test r#macro::test::eprintln_without_format ... ok
test r#macro::test::println_with_format ... ok
test r#macro::test::println_without_arg ... ok
test r#macro::test::println_without_format ... ok
test r#macro::test::set_of_const_assert ... ok
test rmi::features::test::rmi_features ... ok
test rmi::version::test::rmi_version ... ok

Cross Test
$ ./scripts/tests/crates.sh
running 10 tests
test r#macro::test::eprintln_with_format ... ok
test r#macro::test::eprintln_without_arg ... ok
test r#macro::test::eprintln_without_format ... ok
test r#macro::test::println_with_format ... ok
test r#macro::test::println_without_arg ... ok
test r#macro::test::println_without_format ... ok
test r#macro::test::set_of_const_assert ... ok
test rmi::features::test::rmi_features ... ok
test rmi::version::test::rmi_version ... ok

Just bit curious, how does it takes to analysis with miri for entire set of our project or with test snippet?

set of our project

Currently, I've added only two very small test snippets, which take about 2 seconds to run. I guess expanding this to full set of tests should not exponentially increase.
test result: ok. 9 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 1.71s


[ST] insufficient funds on OP->MODE eth

Describe the bug
UI always shows insufficient funds on OP-MODE route.
Link to ticket in discord
https://discord.com/channels/454734546869551114/1233010668257546341
Screenshots

@oncall

Another case:

Discord: https://discord.com/channels/454734546869551114/1233063761930092584

Another case, with nextUSDC:

https://discord.com/channels/454734546869551114/1233072091041890428

Another case, ETH Arb to Mode:

https://discord.com/channels/454734546869551114/1233115537328967700

Here is the list of past tickets:
https://app.intercom.com/a/apps/qge2vd8z/inbox/inbox/conversation/645
https://app.intercom.com/a/apps/qge2vd8z/inbox/inbox/conversation/643
https://app.intercom.com/a/apps/qge2vd8z/inbox/inbox/conversation/644
https://app.intercom.com/a/apps/qge2vd8z/inbox/inbox/conversation/647

Seeing a mismatch of contract addresses. Not sure yet why that's occurring.

https://github.com/connext/frontend/pull/52

Closed with https://github.com/connext/frontend/pull/52


Add Mike Lippincott

Add Mike Lippincott to WayScience Lab website. @gwaybio

@gwaybio I addressed comments and added a why statement. We can address the Netlify later in the week. Have a happy 4th!


Do not trigger tests for .preset.json

Added .preset.json to files that should not trigger tests
Description
Replace this text with a summary of the changes in this PR. Include why the changes are needed and context about the changes. List required dependencies. If there is a Git issue for the change, please link to it.
Types of changes in this PR
No release required

[ ] Examples or tests (addition or updates of examples or tests)
[ ] Documentation update
[x] CI-related update (pipeline, etc.)
[ ] Other changes that don't affect Terraform code

Release required

[ ] Bug fix (patch release (x.x.X): Change that fixes an issue and is compatible with earlier versions)
[ ] New feature (minor release (x.X.x): Change that adds functionality and is compatible with earlier versions)
[ ] Breaking change (major release (X.x.x): Change that is likely incompatible with previous versions)

Release notes content
Replace this text with information that users need to know about the bug fixes, features, and breaking changes. This information helps the merger write the commit message that is published in the release notes for the module.

Checklist for reviewers

[ ] If relevant, a test for the change is included or updated with this PR.
[ ] If relevant, documentation for the change is included or updated with this PR.

Merge actions for mergers

Merge by using "Squash and merge".

Use a relevant conventional commit message that is based on the PR contents and any release notes provided by the PR author.
The commit message determines whether a new version of the module is needed, and if so, which semver increment to use (major, minor, or patch).

@Beilmann Can you explain what exactly .preset.json files are used for in the code?

@ocofaigh https://github.com/terraform-ibm-modules/terraform-ibm-powervs-infrastructure/tree/main/examples/ibm-catalog/presets/slz_json_configs_for_powervs these are the presets.
Will be changing them to:
https://github.com/terraform-ibm-modules/terraform-ibm-powervs-infrastructure/tree/presets/examples/ibm-catalog/presets/slz-for-powervs

Currently the presets are not used by the tests that run in the PR pipelines right? But perhaps maybe one day there might be a test that uses a .presets.json file as part of its tests? Remember this script is used for many repos (internal and external) so I need to be careful here that this change won't impact a pipeline for a different repo

@ocofaigh we have 2 files: rhel-vpc-pvs.preset.json and sles-vpc-pvs.preset.json
How about it can ignore pvs.preset.json ?
It is not being used in pipleine

@surajsbharadwaj yes ok lets go with that then. Ignore pvs.preset.json

@ocofaigh i have added the prefix. Now it is pvs.preset.json

@ocofaigh should there be any * or? Because I just added pvs.preset.json


Pythonic Alternative to Construct-based Code

This PR replaces the original construct-based code with a more readable and flexible Pythonic alternative.
It uses data classes, the struct module, and custom pack/unpack functions while preserving the original functionality.
This PR fixes #44

Did you test it? The code is not sitting there, it is being used in Instructions.
Right now the PR does not make the layouts compatible with instructions. Can you do that and ensure its working fine?

Did you test it? The code is not sitting there, it is being used in Instructions. Right now the PR does not make the layouts compatible with instructions. Can you do that and ensure its working fine?

I dont see any conflict from my side & I have made it compatible with instructions

Instructions file is not updated tho. How have you made it compatible with it without modifying instructions as per changes made? The functions defined in the layouts file aren't being used to decode instructions in the instructions.py file I mentioned above.

Did you test it? The code is not sitting there, it is being used in Instructions. Right now the PR does not make the layouts compatible with instructions. Can you do that and ensure its working fine?

I dont see any conflict from my side & I have made it compatible with instructions

Instructions file is not updated tho. How have you made it compatible with it without modifying instructions as per changes made? The functions defined in the layouts file aren't being used to decode instructions in the instructions.py file I mentioned above.

Did you test it? The code is not sitting there, it is being used in Instructions. Right now the PR does not make the layouts compatible with instructions. Can you do that and ensure its working fine?

I dont see any conflict from my side & I have made it compatible with instructions

Instructions file is not updated tho. How have you made it compatible with it without modifying instructions as per changes made? The functions defined in the layouts file aren't being used to decode instructions in the instructions.py file I mentioned above.

ADVANCE_NONCE_ACCOUNT has no arguments, you can keep Pass. If it requires handling in the future, you can replace it

Did you test it? The code is not sitting there, it is being used in Instructions. Right now the PR does not make the layouts compatible with instructions. Can you do that and ensure its working fine?

I dont see any conflict from my side & I have made it compatible with instructions

Instructions file is not updated tho. How have you made it compatible with it without modifying instructions as per changes made? The functions defined in the layouts file aren't being used to decode instructions in the instructions.py file I mentioned above.

ADVANCE_NONCE_ACCOUNT has no arguments, you can keep Pass. If it requires handling in the future, you can replace it

I'm not sure what you mean here. I never mentioned about advance nonce account. I said that the changes that you have made look fine on surface, but they aren't tested. Because the layouts are supposed to be used in the instructions.py file to build instructions for all these specific actions. Making it Pythonic does not mean replacing data structures coming from struct lib and replacing them with class or dataclasses. It must compile down to the specific byte code that is accurate representation of the instruction, which struct is doing. For example this build method ultimately compiles down our code into byte code. You can see the structure is being used in the instructions file to compile the specified layout. Your changes are not doing that. You haven't made any changes to instructions file so how are your changes supposed to even work? That would directly throw import error, let alone, accurate compilation, which is the main goal.


Add new design to Select your last period date

Change the current design to this

Check files in wireframes folder.

@sarthology  Can I take this one?

Sure

There are some bugs on the wix/react-native-calender package. So we need to use another alternative for this.

Update ?

@sarthology

There are some bugs in the wix/react-native-calendar. Like you cannot change the date on click. Now  I am looking for another NPM package for the calendar.

It looks clean

Not able to push my code after pull the master code.
There is some issues.

 there are some bugs with `wix/react-native-calender` so I found `react-native-calendar-picker` for now. It's' not that much flexible to edit the calendar view. I am figuring out the fix for `wix/react-native-calender` for while.


[IN]

Ce-Eu-Rh (1) - Copie.zip
You do not need to put in anything here :)
Just open the issue by clicing the green "Submit new issue" and within 10-15s a message instructing you do upload your files should appear!

Ce-Eu-Rh (1) - Copie.zip

Hi @hamzabouchta! At this moment, the POSCAR extension is needed after each file.


Add ServerMetrics to collect metrics related server

Motivation:
Add ServerMetrics to collect metrics related server. #4992
Modifications:

Add ServerMetrics.increasePendingRequests() in Http1RequestDecoder#channelRead and Http1RequestDecoder#onHeadersRead before fireChannelRead()
Add ServerMetrics.decreasePendingRequests() and ServerMetrics.increaseActiveRequests() in HttpServerHandler#serve0 before service.serve(reqCtx, req)
Add ServerMetrics.decreaseActiveRequests() in AbstractHttpResponseHandler#tryComplete
Add ServerMetrics.increaseActiveConnectionsAndGet() and ServerMetrics.decreaseActiveConnections() in ConnectionLimitingHandler#channelRead

Result:

Closes #4992. (If this resolves the issue.)
users can implement features based on ServerMertrics like graceful shutdowns such as stopping the server when there are no pending requests.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Let me resolve the conflict. 😉

Gentle ping 🙏

I've pushed commits because we are about to release the next version.
There are also some failing tests that will be resolved after https://github.com/line/armeria/pull/5680 gets merged.


MKL_DNN is built during non-mkl builds.

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow):
No
OS Platform and Distribution (e.g., Linux Ubuntu 16.04):
Ubuntu 14.04
TensorFlow installed from (source or binary):
Source
TensorFlow version (use command below):
master after 1.7
Python version:
2.7
Bazel version (if compiling from source):
0.11
GCC/Compiler version (if compiling from source):
does not matter
CUDA/cuDNN version:
n/a
GPU model and memory:
n/a
Exact command to reproduce:

bazel test --test_tag_filters=-no_oss,-oss_serial,-gpu,-benchmark-test -k --copt='-march=skylake-avx512' - //tensorflow/... -//tensorflow/compiler/... -//tensorflow/contrib/...

Describe the problem
I expected to see some test failures, or some other build failures. no MKL code should be compiled with the above command.

Adding @agramesh1

@tatianashp thanks for letting us know, will look at it.

@gunan I am trying to reproduce this issue. Do you think it is related to clang or it can be reproduced by gcc?

I think the problem is mostly about mkl-DNN being included in BUILD rules when it is disabled. So it should not be compiler specific.
The compilation failure is just a symptom of the problem, I think.

But I think gcc should reproduce the issue.

Ok, I think I am able to reproduce it with gcc.

@gunan I created this PR #17934 which I think will fix this issue.

Nagging Assignee @jart: It has been 14 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

The issue have been resolved.

Hi,
I'm seeing this failure with Bazel 0.12.0rc2 (probably Bazel head as well). Here is my build info:
System information
Have I written custom code (as opposed to using a stock example script provided in TensorFlow):
No
OS Platform and Distribution (e.g., Linux Ubuntu 16.04):
Debian 8
TensorFlow installed from (source or binary):
Source
TensorFlow version (use command below):
commit 7535f6beb7ba95bf54e1513b0c2c51b844a7a49f
Python version:
2.7.9
Bazel version (if compiling from source):
0.12.0rc2 (https://releases.bazel.build/0.12.0/rc2/index.html)
GCC/Compiler version (if compiling from source):
does not matter
CUDA/cuDNN version:
n/a
GPU model and memory:
n/a
Exact command to reproduce:
bazel test -- //tensorflow/... -//tensorflow/compiler/... -//tensorflow/contrib/... -//tensorflow/core:platform_setround_test -//tensorflow/go:test -//tensorflow/java:pom -//tensorflow/python/estimator:export_test
Describe the problem
Bazel tried to build @mkl_dnn and source code is not found.
Source code / logs
ERROR: /root/.cache/bazel/_bazel_root/68a62076e91007a7908bc42a32e4cff9/external/mkl_dnn/BUILD:11:1: C++ compilation of rule '@mkl_dnn//:mkl_dnn' failed (Exit 1)
In file included from external/mkl_dnn/src/cpu/jit_avx2_convolution.cpp:20:
In file included from external/mkl_dnn/src/cpu/jit_avx2_convolution.hpp:23:
In file included from external/mkl_dnn/src/cpu/cpu_reducer.hpp:23:
external/mkl_dnn/src/common/mkldnn_thread.hpp:23:10: fatal error: 'omp.h' file not found
#include <omp.h>
^~~~~~~
1 error generated.
INFO: Elapsed time: 4.468s, Critical Path: 1.82s
FAILED: Build did NOT complete successfully
Can someone try this with Bazel 0.12.0rc2?

The PR just went through. Please try again in a day or so. If you still see error messages please reopen this issue.

I just executed the same command with Tensorflow head at b874783ccdf4cc36cb3546e6b6a998cb8f3470bb. I'm still seeing the same error with Bazel 0.12.0rc2:
ERROR: /root/.cache/bazel/_bazel_root/68a62076e91007a7908bc42a32e4cff9/external/mkl_dnn/BUILD:11:1: C++ compilation of rule '@mkl_dnn//:mkl_dnn' failed (Exit 1)
In file included from external/mkl_dnn/src/cpu/jit_uni_batch_normalization.cpp:22:
external/mkl_dnn/src/common/mkldnn_thread.hpp:23:10: fatal error: 'omp.h' file not found
#include <omp.h>
^~~~~~~
1 error generated.
I don't see to have permission to reopen the issue.

@xingao267 Does the problem happen with Bazel 0.11.0?

Is @mkl_dnn supposed to be used for some targets?

Just tried the same command with Bazel 0.11.1, it also failed. The log is
ERROR: /root/.cache/bazel/_bazel_root/68a62076e91007a7908bc42a32e4cff9/external/mkl_dnn/BUILD:11:1: C++ compilation of rule '@mkl_dnn//:mkl_dnn' failed (Exit 1)
In file included from external/mkl_dnn/src/cpu/cpu_reorder.cpp:23:
In file included from external/mkl_dnn/src/cpu/jit_reorder.hpp:27:
In file included from external/mkl_dnn/src/cpu/simple_reorder.hpp:25:
external/mkl_dnn/src/common/mkldnn_thread.hpp:23:10: fatal error: 'omp.h' file not found
#include <omp.h>
^~~~~~~
1 error generated.
INFO: Elapsed time: 266.949s, Critical Path: 52.28s
Is some of the targets run trying to use @mkl_dnn?

@xingao267 , So this isn't a regression in Bazel 0.12.0, we should fix the dependency somewhere in TensorFlow

I am looking at this issue..

@xingao267 can you test again with this PR #18401 ?

@mahmoud-abuzaina I tested it with Bazel 0.12.0rc3 and Bazel 0.11.1, and it builds.


Task 19

Worked on the backend script for the video module of the project

Allow all users to view the different videos on the platform.
Restrict upload functionality to only registered and logged users.
Restrict video editing and deleting features to only the user that posted it.
Map registered users to the videos they uploaded such that if their accounts get deleted, all their videos get deleted along

I've seen all the recommendations, I'll effect them as soon as I can
On Wed, Aug 10, 2022, 1:35 PM Festus Ali @.*** wrote:

@.**** requested changes on this pull request.
Please effect these few changes and make a commit to same branch so that
your pull request can be approved.
In coreels/settings.py
https://github.com/zuri-training/Team-118-Col-Films/pull/47#discussion_r942383572
:

@@ -91,8 +92,12 @@

DATABASES = {
'default': {

   'ENGINE': 'django.db.backends.sqlite3',

   'NAME': BASE_DIR / 'db.sqlite3',

   'ENGINE': 'django.db.backends.postgresql_psycopg2',

Consider using environment variables for database connection settings.
This will avoid leaking sensitive database connection strings to public
repositories as this.
In coreels/settings.py
https://github.com/zuri-training/Team-118-Col-Films/pull/47#discussion_r942388391
:

@@ -66,7 +67,7 @@
TEMPLATES = [
{
'BACKEND': 'django.template.backends.django.DjangoTemplates',

   'DIRS': ['templates'],

   'DIRS': [os.path.join(BASE_DIR,'templates')],

We are using Django 4.* which qualifies for the new PATH functions that
comes with python 3.
Hence, you can use BASE_DIR / templates' rather than os.path.join(BASE_DIR,
'templates')
Checkout Django Documentation https://docs.djangoproject.com/en/4.0/
for more details.
In reel/migrations/0001_initial.py
https://github.com/zuri-training/Team-118-Col-Films/pull/47#discussion_r942390073
:

@@ -1,96 +0,0 @@
-# Generated by Django 4.0.6 on 2022-07-29 05:36

It is best not to delete migration files as it can leave database in
inconsistent state. Especially during production.
In templates/views.py
https://github.com/zuri-training/Team-118-Col-Films/pull/47#discussion_r942394296
:

@@ -0,0 +1,75 @@
+from venv import create

I don't seem to understand why views.py will be inside a templates folder.
Please review these changes and notify me after making changes or with
reasons why you think it should be here.
—
Reply to this email directly, view it on GitHub
https://github.com/zuri-training/Team-118-Col-Films/pull/47#pullrequestreview-1068182223,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AYRVIY66OR7AXC3ZOCKQZDTVYOO2DANCNFSM56EHUUHA
.
You are receiving this because you authored the thread.Message ID:
@.***>


Hide protected and overridable members from public projections

According to the WinRT type system:

Protected interfaces
A composable class may declare zero or more of its member interfaces to be protected. A non-composable class may not declare member interfaces to be protected. Only code in a class that composes a composable class (directly or indirectly) may query for and use interfaces that the composable class declares as protected. Code from outside the composition chain may not query for, nor use, interfaces that the composable class declares as protected.
For example, if UIElement declares a protected interface IUIElementProtected, then only classes that compose UIElement—including both direct (Control) and indirect (Button) composition—may query for and use the IUIElementProtected interface.
Overridable interfaces
A composable class may declare zero or more of its member interfaces to be overridable. An overridable interface may only be queried for, and used within, a composition chain—similar to the rules about accessing protected interfaces detailed previously. However, where a protected interface may only be implemented by the class that originally declared it, overridable interfaces may be re-implemented by classes that compose the class that implemented the overridable interface.

Previously, cppwinrt allowed anyone to directly call protected/overridable members, for example this code works
StackPanel panel;
panel.ArrangeOverride({ }); // works, despite this being overridable
panel.ProtectedCursor(); // works, despite this being protected

This change makes it so that only implementation types which derive from the base have access to protected and overridable members.
This change is potentially breaking, but code that this change breaks should've never compiled to begin with (and indeed the equivalents in C++/CX as well as .NET Framework and .NET Core do not build).
In worse case, if access to protected and overridable members is desired (despite this being against the WinRT type system), one can do base.as<IBaseProtected>().ProtectedMember()
There's a potential gain to compile-time when Windows.UI.Xaml is involved, since a bunch of consume_t classes for overridable/protected members no longer get instantiated.
Fixes: #1317

Bump

Unfortunately, a project maintainer is not currently available to review this pull request. Please see the contributing guide for more information. Feel free to keep the conversation going on the related issue.

Per discussion thread, reopening

@jonwis - this change is going to be harder to review as it changes code gen which can't be directly reviewed just by looking at the PR even with good test coverage. I tend to take such PRs, clone the branch, and manually verify the code gen looks sound. Its tedious but the repercussions from bad code gen can be expensive if detected later on.
p.s. for windows-rs I opted to include code gen in the repo for test verification and diffing which helps to automate this.

I thought I had forgot about protected constructors, but it turns out protected constructors are already hidden from code which doesn't compose. I added test coverage for it as I couldn't find any.

I'll take this on Monday to compare the generated headers and some sample compiled code. I like the idea that we add some kind of "diff output" script that uses the current release version and the just-built version then your favorite directory-diffing tool to see what changed.
The source-breaking aspect has me concerned given how large the Windows OS codebase is and how widespread protected members are in WinUI3.
I know we don't like behavioral modification switches that change codegen, but this definitely is a place where it might be better to allow a "enable protected member access by namespace filter" control out.

how widespread protected members are in WinUI3.

Most WinUI 3 code is in C#, where protected members are hidden. I'd expect the amount of C++ developers which are actively using protected members against guidance to be fairly low.

enable protected member access by namespace filter

There is no precedent for per-namespace alterations of this kind. I would suggest you start without an escape hatch and see how bad the breaks are in practice by performing an OS build. You may find that they are easily manageable. Once you have a good idea of what the practical implications are, add an escape hatch as needed and only if absolutely necessary. The approach C++/WinRT has used in the past is to use a preprocessor definition like WINRT_LEAN_AND_MEAN. This will be a lot simpler to implement and manage.
https://learn.microsoft.com/en-us/windows/uwp/cpp-and-winrt-apis/macros
This is how I upgraded the OS from C++/WinRT 1.0 to 2.0. But again, you need to get the OS repo up to date first so that you can easily tell the delta of this change specifically. Otherwise, you will just be fighting a slew of random breaks.

Yeah, and namespace filtering is non-trivial to implement.

OK, https://github.com/sylveon/cppwinrt/pull/1 adds new differencing tools to compare the latest release and the under-development codegen. The changes here seem expected - mostly limited to XAML types, for instance. Will need to ingest into the OS carefully.

Unfortunately this does seem to be a breaking change, at least for some projects :(.  I'm trying to build our code base with a private cppwinrt.exe that I built from the HEAD of master and I have some build breaks that seem to match this signature.  (The project is currently on the most recent published release 2.0.230706.1 which narrowly missed this change).

Are those breaking changes perhaps caused by said projects using protected/overridable members? :P

Probably.  They are using something from Xaml::Controls::IControlProtected.  It even has Protected in the name 🤷.
Unfortunately this usage is a pattern established in an (internal) project template so there are dozens of components that will have this same break to fix.  At least this particular fix is not especially difficult.


Joint marginal probability

The MAR tasks computes the marginal probabilities on each individual variable. We should add a more general interface to allow computing joint marginal probabilities.

Fixed by #57


removing jquery dependency

removing jquery dependency for keydown keyup feature.

@nikugogoi if you could also remove jQuery from package.json and the plugin from webpack.congif.js I'll be happy to merge this

Removing the jQuery dependancy is awesome, but we should really be querying the component data (matches?) instead of querying the DOM.

@InstanceOfMichael yes that can be done. Using class binding in the v-for loop. The above fix was just a quick fix to not break the code


Go Bazel builds fail to find cel.dev/expr

In https://github.com/cncf/xds/pull/89 the cel.dev/expr based annotations were reintroduced. Unfortunately, there still seem to be issues when trying to use Bazel, Go and Gazelle together, and importing this module.
I've recently added a dependency on github.com/cncf/xds/go/xds/type/matcher/v3 and updated my dependency on go-control-plane to pick up a bugfix (https://github.com/envoyproxy/go-control-plane/commit/77feb56c98e5450a45be4715c868cca909873553 ).
(I'm not sure my new dependency there matters, tbh. It's just very close and maybe adding confusion.)
This update to go-control-plane updated the version to this library, and thus picked up the cel.dev/expr change.
Now, my builds fail with:
ERROR: /private/var/tmp/_bazel_randerson/01ba2733315bf63f62b0e43c3a981a72/external/com_github_cncf_xds_go/xds/type/v3/BUILD.bazel:3:11: no such target '@dev_cel_expr//:expr': target 'expr' not declared in package '' defined by /private/var/tmp/_bazel_randerson/01ba2733315bf63f62b0e43c3a981a72/external/dev_cel_expr/BUILD.bazel (Tip: use query "@dev_cel_expr//:*" to see all the targets in that package) and referenced by '@com_github_cncf_xds_go//xds/type/v3:type'
The BUILD file there doesn't actually define any go libraries, so this isn't particularly surprising, but I don't think this commit is working as expected right now.
I'm not really sure if the problem is here or in cel.dev/expr, but ... well, debugging 3 layers of modules down is not fun.

Lets see if we can poke folks to go accept https://github.com/google/cel-spec/pull/379 and https://github.com/google/cel-spec/pull/354

Not sure if it's related, but I can't build with bazel in WORKSPACE mode after upgrading to a recent commit.
ERROR: no such package '@@com_github_cncf_xds_go//xds/annotations/v3': BUILD file not found in directory 'xds/annotations/v3' of external repository @@com_github_cncf_xds_go. Add a BUILD file to a directory to mark it as a package.
ERROR: no such package '@@com_github_cncf_xds_go//udpa/annotations': BUILD file not found in directory 'udpa/annotations' of external repository @@com_github_cncf_xds_go. Add a BUILD file to a directory to mark it as a package.
ERROR: no such package '@@com_github_cncf_xds_go//xds/core/v3': BUILD file not found in directory 'xds/core/v3' of external repository @@com_github_cncf_xds_go. Add a BUILD file to a directory to mark it as a package.

ERROR: /external/com_github_envoyproxy_go_control_plane/envoy/type/v3/BUILD.bazel:3:11: no such package '@@com_github_cncf_xds_go//udpa/annotations': BUILD file not found in directory 'udpa/annotations' of external repository @@com_github_cncf_xds_go. Add a BUILD file to a directory to mark it as a package. and referenced by '@@com_github_envoyproxy_go_control_plane//envoy/type/v3:type'
ERROR: /external/com_github_envoyproxy_go_control_plane/envoy/type/v3/BUILD.bazel:3:11: no such package '@@com_github_cncf_xds_go//xds/annotations/v3': BUILD file not found in directory 'xds/annotations/v3' of external repository @@com_github_cncf_xds_go. Add a BUILD file to a directory to mark it as a package. and referenced by '@@com_github_envoyproxy_go_control_plane//envoy/type/v3:type'
ERROR: /external/com_github_envoyproxy_go_control_plane/envoy/type/matcher/v3/BUILD.bazel:3:11: no such package '@@com_github_cncf_xds_go//udpa/annotations': BUILD file not found in directory 'udpa/annotations' of external repository @@com_github_cncf_xds_go. Add a BUILD file to a directory to mark it as a package. and referenced by '@@com_github_envoyproxy_go_control_plane//envoy/type/matcher/v3:matcher'
ERROR: /external/com_github_envoyproxy_go_control_plane/envoy/type/matcher/v3/BUILD.bazel:3:11: no such package '@@com_github_cncf_xds_go//xds/core/v3': BUILD file not found in directory 'xds/core/v3' of external repository @@com_github_cncf_xds_go. Add a BUILD file to a directory to mark it as a package. and referenced by '@@com_github_envoyproxy_go_control_plane//envoy/type/matcher/v3:matcher'
ERROR: /external/com_github_envoyproxy_go_control_plane/envoy/config/core/v3/BUILD.bazel:3:11: no such package '@@com_github_cncf_xds_go//udpa/annotations': BUILD file not found in directory 'udpa/annotations' of external repository @@com_github_cncf_xds_go. Add a BUILD file to a directory to mark it as a package. and referenced by '@@com_github_envoyproxy_go_control_plane//envoy/config/core/v3:core'
ERROR: /external/com_github_envoyproxy_go_control_plane/envoy/config/core/v3/BUILD.bazel:3:11: no such package '@@com_github_cncf_xds_go//xds/annotations/v3': BUILD file not found in directory 'xds/annotations/v3' of external repository @@com_github_cncf_xds_go. Add a BUILD file to a directory to mark it as a package. and referenced by '@@com_github_envoyproxy_go_control_plane//envoy/config/core/v3:core'
ERROR: /external/com_github_envoyproxy_go_control_plane/envoy/config/core/v3/BUILD.bazel:3:11: no such package '@@com_github_cncf_xds_go//xds/core/v3': BUILD file not found in directory 'xds/core/v3' of external repository @@com_github_cncf_xds_go. Add a BUILD file to a directory to mark it as a package. and referenced by '@@com_github_envoyproxy_go_control_plane//envoy/config/core/v3:core'
ERROR: /external/com_github_envoyproxy_go_control_plane/envoy/service/auth/v3/BUILD.bazel:3:11: no such package '@@com_github_cncf_xds_go//udpa/annotations': BUILD file not found in directory 'udpa/annotations' of external repository @@com_github_cncf_xds_go. Add a BUILD file to a directory to mark it as a package. and referenced by '@@com_github_envoyproxy_go_control_plane//envoy/service/auth/v3:auth'


Add github action to check release download

This new workflow is intended to help with the release of new versions of all the Carvel tools.
Running this workflow would try to check all the binaries and download them to ensure the release notes are correct

@joaopapereira: Sounds a useful check to have. Couple of questions from me:

I see you're using the workflow_dispatch event. What will be triggering that? (E.g. will there be automation elsewhere to trigger it on releases?)
Who will be monitoring the outcome, and what actions should they take on a failure?

@joaopapereira: Sounds a useful check to have. Couple of questions from me:

I see you're using the workflow_dispatch event. What will be triggering that? (E.g. will there be automation elsewhere to trigger it on releases?)
Who will be monitoring the outcome, and what actions should they take on a failure?

One alternative which comes to mind, though it would be slightly more work (as it would be spread across repos), would be to add a workflow to each carvel app repo which, on the release event, would run this action for that app only. Then each Carvel app would have its own pipeline checking its own release notes, and the failures might be more clearly visible in the relevant repos. (But to be clear, I'm perfectly happy with the approach in this PR; I'm just wondering about what would create visibility most effectively for the Carvel maintainers.)

One alternative which comes to mind, though it would be slightly more work (as it would be spread across repos), would be to add a workflow to each carvel app repo which, on the release event, would run this action for that app only. Then each Carvel app would have its own pipeline checking its own release notes, and the failures might be more clearly visible in the relevant repos. (But to be clear, I'm perfectly happy with the approach in this PR; I'm just wondering about what would create visibility most effectively for the Carvel maintainers.)

@jbrunton We have a checklist we follow for now with the multiple things we need to do when releasing the tools. The idea is that we add this check as part of that checklist. Basically, we will have to manually run the workflow and check the result by hand.
My initial idea was to create this per repository, but it felt more like the responsibility of the action to ensure it can download all the tools (and a lot less work to have this in all repos 😃). But after thinking a little bit more the automated check might be easier to add to our process.

@jbrunton We have a checklist we follow for now with the multiple things we need to do when releasing the tools. The idea is that we add this check as part of that checklist. Basically, we will have to manually run the workflow and check the result by hand.
My initial idea was to create this per repository, but it felt more like the responsibility of the action to ensure it can download all the tools (and a lot less work to have this in all repos 😃). But after thinking a little bit more the automated check might be easier to add to our process.

@joaopapereira: Thanks for the context! I'm happy either way. Would you like me to go ahead and merge this PR so the option is there, or do you want to think on this further?

@joaopapereira: Thanks for the context! I'm happy either way. Would you like me to go ahead and merge this PR so the option is there, or do you want to think on this further?

After some soul searching I think we should do it per repository as you suggested.

After some soul searching I think we should do it per repository as you suggested.


Merge BDD stub

This branch stubs out basic tests for the project.
In order to set up testing you'll need to create a second URL to access the project at, called api-test, and create a new local_testing_config.php file next to the local_config file, which aims the database at the testing database. (Which you will need to create and then populate with the testingdb.sql file...)

Closed and delete after @severity merged via command line.


Fe hands on 17

https://video.drift.com/v/ab2jmjCfwnxCA2eURUMh1fFyAfjmz3TCm8pl89gGewM/

Metric
Value

alert_status
b:white_check_mark: OK/b

bugs
1

code_smells
8

reliability_rating
D (at least 1 Critical Bug)br/Note: A being best, E being worst

security_rating
A (0 Vulnerabilities)br/Note: A being best, E being worst

vulnerabilities
0


[zh-cn] resync /controllers/fluentd.yaml

added zh-cn comments in controllers/YAMLs.

/assign @tengqm

/lgtm
/approve


Popup to get more user rating on app store

Summary:
The app on The App Store needs more ratings and reviews, we can add a little popup displayed before the user closes the app which will ask the user if he/she wants to rate the app on app store. If user agrees then he/she will be redirected to The App Store or else user can opt for DO NOT SHOW THIS AGAIN option
Screen-shots:
Example

Would you like to work on the issue?
No

We might want to wait and be sure that all our issues around upload failures are fixed before we start prompting for ratings. Otherwise, we might attract more negative reviews than positive ones. :D

@maskaravivek Sure! I will be happy to add this feature as soon as issues around upload failures are fixed, can we keep the issue open?

Yes, let us keep the issue open.

We already have a link to rate the app in the About screen.
When the user quits the app, it is because they have something else to do (answer an email, look up directions, get the rare pokemon that just appeared, etc).
If we really really want to get more ratings, I would suggest showing the popup when the user opens their Achievements screen and they just got to the next level. The popup would say:

Congratulations, you reached level 2!
The free encyclopedia appreciates your uploads.
Would you like to rate the upload app?
Yes - Ask me later - Don't ask me again

The user is more likely to be in a positive mood at that time.
Discussions about this topic:

https://ux.stackexchange.com/questions/40717/asking-feedback-rating-for-a-mobile-app
https://ux.stackexchange.com/questions/81625/best-practices-for-asking-user-to-rate-this-app
https://ux.stackexchange.com/questions/57032/strategy-to-ask-app-users-for-review

@nicolas-raoul I agree that asking for feedback when the user reaches to next level would be much better than asking the user when he/she leaves the app.

I would like to pitch in my notions over the Issue.

We already have a link to rate the app in the About screen.

Yes currently about has the playstore link to rate the app there might be very few users who will rate the app this way.

If we really really want to get more ratings, I would suggest showing the popup when the user opens their Achievements screen and they just got to the next level.

Yes definitely the user will be delighted to see the improvement in their score's and hence there is a greater chance of user's moving ahead and rating/giving positive reviews for the app.
Yet there are a few things to keep in mind:

If the user hasn't clicked on "DO NOT SHOW THIS AGAIN" or if he has clicked on "REMIND ME LATER" then there user would be shown a popup every-time he navigates to Achievements
Repeated popups are sometimes distracting and doesn't pleases the user
The user won't be pleased to give good rating/reviews if this popup repeat's every-time he switches to achievements activity
Considering the above point, we can display the popup only when the user has made a new achievement/ reached to the next level in achievements(For example if the user has reached a next level in achievements then while exiting the app we can show the popup Congrats!! for reaching the next level. Please give sometime to rate our app on playstore )

@nicolas-raoul @maskaravivek is it a good time to implement this feature as per the discussion

Congratulations, you reached level 2!
The free encyclopedia appreciates your uploads.
Would you like to rate the upload app?
Yes - Ask me later - Don't ask me again

I think it is not yet, it requires 1, 2 months actually
On Fri, Mar 15, 2019, 13:39 Madhur Gupta<EMAIL_ADDRESS>wrote:

@nicolas-raoul https://github.com/nicolas-raoul @maskaravivek
https://github.com/maskaravivek is it a good time to implement this
feature as per the discussion
Congratulations, you reached level 2!
The free encyclopedia appreciates your uploads.
Would you like to rate the upload app?
Yes - Ask me later - Don't ask me again
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/commons-app/apps-android-commons/issues/2508#issuecomment-473254341,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AC-6SYmtuaQk1gt3Rysn9_cf_hvbNnETks5vW4Z9gaJpZM4bN_om
.

@neslihanturan Okay

@nicolas-raoul @4D17Y4 i want to work on this issue please assign me

@Rishavgupta12345 Please work on one issue at a time, thanks for your enthusiasm! :-)

@4D17Y4 you can assign me this issue now

Hey @Rishavgupta12345,
Nice work so far. Now as you have some experience working on commons I'd say go for a difficult bug and try to solve it.
Just to reiterate A quality PR is more valuable than number of issues/PRs.
With that said, finish up the assigned issues and then ping for this one.
Thanks.

Hey @Rishavgupta12345, Nice work so far. Now as you have some experience working on commons I'd say go for a difficult bug and try to solve it. Just to reiterate A quality PR is more valuable than number of issues/PRs.
With that said, finish up the assigned issues and then ping for this one. Thanks.

Thanks, @4D17Y4 I am targeting GSOC this year, it would be great to work under your guidance

@nicolas-raoul @4D17Y4 please assign me this

@nicolas-raoul @4D17Y4 worked on previous issues , so assign me this one

This issue has the debated label, which means that it is not ready for a volunteer to work on.
The reason is still https://github.com/commons-app/apps-android-commons/issues/2508#issuecomment-466662817, upload is still failing very often.
Thanks! :-)


some bugs

Great transitions for vapoursynth!
There is a bug in vs_transitions, in "fade_to_black" and "fade_from_black" , where black clip is hard coded to 24fps (using BlankClip),
so at the end of those two functions could be in init.py:
black_clip_resized = black_clip_resized.std.AssumeFPS(fpsnum=src_clip.fps.numerator, fpsden=src_clip.fps.denominator)
also to make it work for API4 it needs something like:
try:
    isAPI4 = vs.__api_version__.api_major >= 4
except AttributeError:
    isAPI4 = False
and to add in "wipe" function:
if isAPI4: ptr = np.asarray(fout[0])
else:      ptr = np.asarray(fout.get_write_array(0))

The package is currently being rewritten here: https://github.com/Irrational-Encoding-Wizardry/vs-transitions
The function you mentioned are already there with additional functionality too.

super, thanks!


do not infer cwd from pkgUp, if pkgUp walks all the way to /

The library pkgUp is used to find the closest package.json, which nyc uses as cwd.
If pkgUp walks all the way to /, it returns the string package.json. In this edge-case, we should not switch to cwd to the path of the package.json found by pkgUp.

This almost seems like a pkgUp bug. Shouldn't it return null?

This almost seems like a pkgUp bug. Shouldn't it return null?

It will. pkg-up --> find-up.
Any chance you have a /package.json on your machine @bcoe?

@novemberborn @jamestalmage I have no /package.json, and we were seeing the same behavior on Travis/Appveyor which was breaking tests.
I'm really confused because it feels like this should have always been broken, and pkg-up and find-up only have one release (and haven't changed in a while). This fixes things, but I'm trying to figure out which dependency of a dependency caused behavior to change  ¯_(ツ)_/¯

It's a bug in find-up, introduced by https://github.com/sindresorhus/find-up/pull/3 and released 3 days ago. Once it runs out of path parts to try it accidentally uses the working directory and returns a relative path.

This will be fixed with https://github.com/sindresorhus/find-up/pull/4.

<EMAIL_ADDRESS>is out with @novemberborn's fix. Sorry about the trouble.

@bcoe why merge this? find-up had a bug but that's resolved now.

@novemberborn I figured it was worth merging an explicit bump of find-up:
 "find-up": "^1.1.2",

@bcoe ah sorry, hadn't checked the diff :blush:


Disqus seems not loaded

When click an article, Disqus is not loaded and only a "D" icon is shown. Then an error prompts "Disqus seems to be taking longer than usual. Reload?". Any configuration needs to be done to enable Disqus? Thanks!

Problem solved by myself. Need create Disqus shortname and configure it.


Option to disable logging when using makeEnvPublic

When using makeEnvPublic in next.config.js:
const { makeEnvPublic } = require('next-runtime-env')

makeEnvPublic([
  'API_BASE_URL',
])

It logs ✓ Prefixed environment variable 'API_BASE_URL' (next-runtime-env) on every server start. Both in local development mode and on production environments this creates a lot of (duplicate) noise in the logs. An option to disable this would be a nice and simple addition:
makeEnvPublic([
  'API_BASE_URL',
], {
  loglevel: 'silent' // Other options could 'warn', 'info'
})

@gregorybolkenstijn, this would be a great addition! Happy to review a pull request for this.

I cloned the repo but didn't find the code for it. Anyway,  maybe you should try conditional logging. Instead of completely disabling the log, you can get env variables to conditionally log only during development.
Like this:
const { makeEnvPublic } = require('next-runtime-env')

const isDevelopment = process.env.NODE_ENV === 'development'

makeEnvPublic([
  'API_BASE_URL',
], {
  silent: !isDevelopment
})

if (isDevelopment) {
  console.log('✓ Prefixed environment variable \'API_BASE_URL\' (next-runtime-env)')
}


podman run: lines are terminated with CRLF

podman run emits lines to stdout terminated with CRLF (\r\n) instead of the conventional LF (\n):
# podman run --name foo registry.access.redhat.com/rhel7/rhel:latest cat /etc/adjtime |cat -e
0.0 0 0.0^M$
            0^M$
                UTC^M$
                      # podman logs foo | cat -e
0.0 0 0.0$
0$
UTC$

podman logs does not exhibit the same behavior.
I can't figure out where this is originating. Sorry.

Putting money on this being conmon

Huh.  No \r\n in the code over there.

@nalind PTAL
I think we have the same issue with buildah which does not use conmon.

@mrunalp PTAL

@edsantiago I think this is fixed...can you confirm?

@baude do you have a build? At first glance it seems to be still present in podman-0.3.5-1.gitdb6bf9e.fc27

Looks to be fixed in podman-0.4.1-1.gitb51d327.fc27. I'm still seeing a curious behavior in which, at some point in docker-autotest, tty settings get b0rked; in particular, -echo and -opost. If I track that down, I'll file a new issue.


PropertyCarousel not being used

PropertyCarousel component is not referenced anywhere. In the dreamhouse-sfdx version, it was part of the property record page.

Done in https://github.com/dreamhouseapp/dreamhouse-lwc/pull/103


Future feature: database support

[ ] #53
[ ] #27

hi I appreciate you, it would be better if there is mysql

hi I appreciate you, it would be better if there is mysql

Thanks for the appreciation!
I'm currently working on PlaceholderAPI support, but once that's finished I will probably start working on database support. I haven't worked with databases before, so it might take me some time to learn how to properly implement it, but I'll get there eventually!


feat(dataframe): support "repr" function in DataFrame

Task linked: CU-2b4rt3j 实现 DataFrame.repr 可视化方法

Try to reconsider the structure of header_info,
And try to find a better variable name for every variable in the code.


Endless loop for "Still creating..." after resources have already been setup and are running

UPDATE:
TL;DR: This appears to be a mistake of mine for not including the guest agent tools in my image template, can't believe I forgot that... Still, I'll leave this up in case some other sad sod stumbles upon the same issue.
It did eventually finish (after 20+ minutes) and throws:
Error: error from PVE: "500 QEMU guest agent is not running"
│ , QEMU Agent is enabled in you configuration but non installed/not working on your vm
│
│   with proxmox_vm_qemu.server1,
│   on server1.tf line 1, in resource "proxmox_vm_qemu" "server1":
│    1: resource "proxmox_vm_qemu" "server1" {

For some reason Terraform just gets stuck on "Still creating..." even after successfully setting up my resources.
It doesn't even take a minute until it is up and running, but it's as if Terraform never receives call back that all is well.
Has anyone stumbled upon this issue previously?

Terraform apply log:

Terraform used the selected providers to generate the following execution plan. Resource actions are indicated with the
following symbols:
  + create

Terraform will perform the following actions:

  # proxmox_vm_qemu.server1 will be created
  + resource "proxmox_vm_qemu" "server1" {
      + additional_wait           = 5
      + agent                     = 1
      + automatic_reboot          = true
      + balloon                   = 0
      + bios                      = "ovmf"
      + boot                      = (known after apply)
      + bootdisk                  = (known after apply)
      + clone                     = "windows-test"
      + clone_wait                = 10
      + cores                     = 2
      + cpu                       = "host"
      + default_ipv4_address      = (known after apply)
      + define_connection_info    = true
      + desc                      = "a test terraform server"
      + force_create              = false
      + full_clone                = true
      + guest_agent_ready_timeout = 100
      + hotplug                   = "network,disk,usb"
      + id                        = (known after apply)
      + kvm                       = true
      + memory                    = 4096
      + name                      = "server1"
      + nameserver                = (known after apply)
      + onboot                    = false
      + oncreate                  = true
      + preprovision              = true
      + reboot_required           = (known after apply)
      + scsihw                    = "lsi"
      + searchdomain              = (known after apply)
      + sockets                   = 1
      + ssh_host                  = (known after apply)
      + ssh_port                  = (known after apply)
      + tablet                    = true
      + target_node               = "pve2"
      + unused_disk               = (known after apply)
      + vcpus                     = 0
      + vlan                      = -1
      + vmid                      = (known after apply)
    }

Plan: 1 to add, 0 to change, 0 to destroy.

Do you want to perform these actions?
  Terraform will perform the actions described above.
  Only 'yes' will be accepted to approve.


Fix efr32 otPlatRandomGetTrue() declaration.

Thanks to @beriberikix for pointing this out!

Codecov Report

Merging #1654 into master will decrease coverage by 0.79%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master    #1654     +/-   ##
=========================================
- Coverage    67.3%   66.51%   -0.8%
=========================================
  Files         169      166      -3
  Lines       21136    21097     -39
  Branches     2594     2594
=========================================
- Hits        14226    14033    -193
- Misses       6009     6150    +141
- Partials      901      914     +13

Impacted Files
Coverage Δ

examples/platforms/posix/misc.c
0% <0%> (-66.67%)
:arrow_down:

src/core/api/icmp6_api.cpp
50% <0%> (-50%)
:arrow_down:

src/core/net/ip6.hpp
66.66% <0%> (-22.23%)
:arrow_down:

src/core/coap/coap_client.cpp
51.78% <0%> (-20.41%)
:arrow_down:

src/core/coap/coap_client.hpp
73.33% <0%> (-20%)
:arrow_down:

src/core/api/ip6_api.cpp
43.75% <0%> (-17.19%)
:arrow_down:

src/core/mac/mac_whitelist.cpp
76.59% <0%> (-17.03%)
:arrow_down:

src/core/api/netdata_api.cpp
57.44% <0%> (-14.9%)
:arrow_down:

src/core/api/thread_api.cpp
29.08% <0%> (-8.37%)
:arrow_down:

src/core/coap/coap_server.cpp
81.48% <0%> (-7.41%)
:arrow_down:

... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a830ec...046f4d3. Read the comment docs.


Allow for custom regions

I would like to use a list of custom regions, not just a whole country.
For example:

Berlin Neukölln, which is the area a very local community monitors and keeps up to data
Berlin-Brandenburg, which is the area of our local Stammtisch
The area of the project https://www.zesplus.de/forschungsprojekt, which is this area…area["boundary"="administrative"]["admin_level"="8"]["name"="Zeuthen"];
area["boundary"="administrative"]["admin_level"="8"]["name"="Eichwalde"];
area["boundary"="administrative"]["admin_level"="8"]["name"="Schulzendorf"];
area["boundary"="administrative"]["admin_level"="8"]["name"="Wildau"];
area["boundary"="administrative"]["admin_level"="8"]["name"="Königs Wusterhausen"];
area["boundary"="administrative"]["admin_level"="8"]["name"="Schönefeld"];

The area of https://www.openstreetmap.org/relation/1427697 which is where a similar project to ZES+ will take place next year

Is something like this possible already or planned?

You can have anything you like as a region, you just need to provide the related geometry in a GeoJSON file!
So it's already possible.

Thanks @jbelien. And I just found https://github.com/osmbe/osm-welcome-tool/blob/2.x/CONTRIBUTING.md#add-a-new-region, so I will follow that. Thanks!


Nullable settings with value NULL are not persisted

Commit f775ca2220ea93e34a7932fbc537b4de55c25539 introduced a bug where if you have a nullable setting and you leave it empty (thus turning into NULL) the setting is not persisted. This is due to the following line:
if (!isset($tempResource->{$field->attribute})) return;

It used to be property_exists, but has been changed to isset. Since isset also detected NULL, this skips saving the value when it is NULL.
Suggested fix
if (!array_key_exists($field->attribute, $tempResource->getAttributes())) return;

This checks if the $tempResource has the attribute as an array key in its attributes. It doesn't check whether it's null, just that it's set. This should prevent any cases where undefined attributes get persisted, though is that even possible?

I really need it too, please fix it

Heya! Sorry about the delay. FIxed now in version 5.2.1.


EigenAllocator for GPU ran out of memory when allocating 0

Environment info
Operating System: Ubuntu 16.04
Installed version of CUDA and cuDNN: CUDA-8.0, CUDNN 5.1.10
Tensorflow version r1.1
Hello, does anyone encountered this error ?
After some random number of iterations, i'm getting the below exception. Can anyone help me where its going wrong?
: E tensorflow/core/common_runtime/bfc_allocator.cc:244] tried to allocate 0 bytes
: W tensorflow/core/common_runtime/allocator_retry.cc:32] Request to allocate 0 bytes
: F tensorflow/core/common_runtime/gpu/gpu_device.cc:103] EigenAllocator for GPU ran out of memory when allocating 0. See error logs for more detailed info.
Aborted (core dumped)
Regards,
Sharath

This question is better asked on  StackOverflow since it is not a  bug or feature request. There is also a larger community that reads questions there. Thanks!
Also note #492 has some extra info that may be interesting to you.  I found that via the following search:
https://github.com/issues?utf8=✓&q=repo%3Atensorflow%2Ftensorflow+"EigenAllocator+for+GPU+ran+out+of+memory"


unindent_chained_methods breaks indentation for if statements without brackets

Input
The code looked like this before beautification:
      var g = 0;
      if (g === 1)
        g = 0;
      else
        g = 1;

Expected Output
The code should have looked like this after beautification:
      var g = 0;
      if (g === 1)
        g = 0;
      else
        g = 1;

Actual Output
The  code actually looked like this after beautification:
      var g = 0;
      if (g === 1)
      g = 0;
      else
      g = 1;

Steps to Reproduce
Environment
OS: Debian GNU/Linux 9 (stretch) 64-bit
CLI: js-beutify Ver: 1.7.5
Settings
js-beautify -u -s 2 -a -b collapse,preserve-inline

I can't reproduce this on http://jsbeautifier.org/  Not sure what would cause that to happen.

I've used the command line tool of js-beutify, ver: 1.7.5.

@hstig
What is the full command line you're using? (Including file name)

js-beautify -u -s 2 -a -b collapse,preserve-inline \#1378.js

@hstig
Ah, I see you only get it with unindent_chained_methods.  I see it now. Thanks!