Error: Not found: /favicon.ico when using emoji as favicon

Describe the bug
I get the following error when previewing a production build locally with prerender = true set.
Error: Not found: /favicon.ico
    at resolve (file:///Users/olafur/dev/hvaderibio/.svelte-kit/output/server/index.js:3187:18)
    at resolve (file:///Users/olafur/dev/hvaderibio/.svelte-kit/output/server/index.js:3054:34)
    at #options.hooks.handle (file:///Users/olafur/dev/hvaderibio/.svelte-kit/output/server/index.js:3231:59)
    at respond (file:///Users/olafur/dev/hvaderibio/.svelte-kit/output/server/index.js:3052:43)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

However there is no favicon.ico in my project as this is the code I use instead
		<link
			rel="icon"
			href="data:image/svg+xml,<svg xmlns=%22http://www.w3.org/2000/svg%22 viewBox=%220 0 100 100%22><text y=%22.9em%22 font-size=%2290%22>🎞</text></svg>"
		/>

Reproduction
https://github.com/multivac61/hvaderibio
Logs
pnpm build && pnpm run preview

><EMAIL_ADDRESS>build /Users/olafur/dev/hvaderibio
> vite build

vite v4.1.2 building SSR bundle for production...
✓ 59 modules transformed.
2:39:11 PM [vite-plugin-svelte] ssr compile done.
package   	files	  time	   avg
hvaderibio	    4	41.4ms	10.3ms

vite v4.1.2 building for production...
✓ 44 modules transformed.
2:39:12 PM [vite-plugin-svelte] dom compile done.
package   	files	  time	   avg
hvaderibio	    4	81.8ms	20.5ms
.svelte-kit/output/client/_app/version.json                                            0.03 kB
.svelte-kit/output/client/vite-manifest.json                                           3.32 kB
.svelte-kit/output/client/_app/immutable/assets/_layout-cb0259b3.css                  73.18 kB │ gzip: 10.09 kB
.svelte-kit/output/client/_app/immutable/chunks/1-b8026635.js                          0.09 kB │ gzip:  0.10 kB
.svelte-kit/output/client/_app/immutable/modules/pages/_page.ts-63299924.js            0.09 kB │ gzip:  0.10 kB
.svelte-kit/output/client/_app/immutable/chunks/0-0318290b.js                          0.10 kB │ gzip:  0.10 kB
.svelte-kit/output/client/_app/immutable/chunks/2-578bcf85.js                          0.15 kB │ gzip:  0.13 kB
.svelte-kit/output/client/_app/immutable/chunks/control-e7f5239e.js                    0.26 kB │ gzip:  0.18 kB
.svelte-kit/output/client/_app/immutable/components/pages/_layout.svelte-e014857f.js   0.55 kB │ gzip:  0.36 kB
.svelte-kit/output/client/_app/immutable/components/error.svelte-0c2d9b7a.js           0.98 kB │ gzip:  0.57 kB
.svelte-kit/output/client/_app/immutable/chunks/singletons-21706245.js                 2.56 kB │ gzip:  1.34 kB
.svelte-kit/output/client/_app/immutable/chunks/index-0d79d76e.js                      7.50 kB │ gzip:  3.04 kB
.svelte-kit/output/client/_app/immutable/components/pages/_page.svelte-f2380c35.js    13.53 kB │ gzip:  5.43 kB
.svelte-kit/output/client/_app/immutable/start-81eb9fa6.js                            28.17 kB │ gzip: 10.95 kB
.svelte-kit/output/client/_app/immutable/chunks/_page-d7ce62e5.js                     49.00 kB │ gzip: 12.32 kB
.svelte-kit/output/server/vite-manifest.json                           1.93 kB
.svelte-kit/output/server/_app/immutable/assets/_layout-e9663fe1.css  73.44 kB
.svelte-kit/output/server/internal.js                                  0.19 kB
.svelte-kit/output/server/entries/pages/_layout.svelte.js              0.26 kB
.svelte-kit/output/server/entries/fallbacks/error.svelte.js            0.83 kB
.svelte-kit/output/server/entries/pages/_page.ts.js                    1.18 kB
.svelte-kit/output/server/chunks/index.js                              1.95 kB
.svelte-kit/output/server/chunks/index2.js                             3.68 kB
.svelte-kit/output/server/entries/pages/_page.svelte.js                5.32 kB
.svelte-kit/output/server/chunks/internal.js                           5.33 kB
.svelte-kit/output/server/index.js                                    99.36 kB

Run npm run preview to preview your production build locally.

> Using @sveltejs/adapter-auto
  Could not detect a supported production environment. See https://kit.svelte.dev/docs/adapters to learn how to configure your app to run on the platform of your choosing
  ✔ done

><EMAIL_ADDRESS>preview /Users/olafur/dev/hvaderibio
> vite preview

  ➜  Local:   http://localhost:4173/
  ➜  Network: use --host to expose
Error: Not found: /favicon.ico
    at resolve (file:///Users/olafur/dev/hvaderibio/.svelte-kit/output/server/index.js:3187:18)
    at resolve (file:///Users/olafur/dev/hvaderibio/.svelte-kit/output/server/index.js:3054:34)
    at #options.hooks.handle (file:///Users/olafur/dev/hvaderibio/.svelte-kit/output/server/index.js:3231:59)
    at respond (file:///Users/olafur/dev/hvaderibio/.svelte-kit/output/server/index.js:3052:43)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
^C ELIFECYCLE  Command failed.

### System Info

```Shell
npx envinfo --system --binaries --browsers --npmPackages "{svelte,@sveltejs/*,vite}"
Need to install the following packages:
<EMAIL_ADDRESS>Ok to proceed? (y) y

  System:
    OS: macOS 13.2.1
    CPU: (10) arm64 Apple M1 Pro
    Memory: 143.03 MB / 32.00 GB
    Shell: 5.8.1 - /bin/zsh
  Binaries:
    Node: 19.3.0 - ~/.nvm/versions/node/v19.3.0/bin/node
    Yarn: 1.22.19 - /opt/homebrew/bin/yarn
    npm: 9.2.0 - ~/.nvm/versions/node/v19.3.0/bin/npm
  Browsers:
    Chrome: 110.0.5481.100
    Edge: 110.0.1587.57
    Firefox: 110.0
    Safari: 16.3
  npmPackages:
    @sveltejs/adapter-auto: ^2.0.0 => 2.0.0
    @sveltejs/kit: ^1.7.2 => 1.7.2
    svelte: ^3.55.1 => 3.55.1
    vite: ^4.1.2 => 4.1.2

Severity
annoyance
Additional Information
No response

I can't reproduce this. Are you certain that you don't have a tab open to localhost:4173 that's showing a different app (or an older version of the same app) that doesn't include the <link rel="icon">?

Oh man, you are right. I was messing around with several apps and must've gotten sidetracked 😅
I'm a C++ developer having a blast learning SvelteKit and by proxy web standards! At the moment I have no idea what I am doing but that's fine. I see myself as the Karate Kid learning to wax on, wax off until all of a sudden I know how to build  real web apps!

Oh man, you are right. I was messing around with several apps and must've gotten sidetracked 😅
I'm a C++ developer having a blast learning SvelteKit and by proxy web standards! At the moment I have no idea what I am doing but that's fine. I see myself as the Karate Kid learning to wax on, wax off until all of a sudden I know how to build  real web apps!

I ran into this same issue. In my case it was caused by the template I used which had /static/favicon.png, moving it to /public/favicon.png resolved the issue.


ci: run tests on renovate/** branches

Changes:

Run tests on pushes to renovate/** branch

Context:

Renovate bot is not working properly, I think it's because we don't run tests on the branches that Renovate bot creates.
I think running tests on pushes to renovate/** will be part of the solution.
We'd still need the branch protection rules from #11 to be done as well.
Documentation (please check one with an [x])

[ ] I have updated the documentation, or
[x] No documentation update is required

How I've tested my work (please tick one)
I have verified these changes via:

[x] Code inspection only, or
[ ] Newly added/modified unit tests, or
[ ] No unit tests but ran on a real repository, or
[ ] Both unit tests + ran on a real repository

I don't know if we need to run the CodeQL tests on the renovate/** branch as well?

superseedded by #13 ?

I'll consider this superseded by #13 for now. I think @viceice's way looks cleaner.


Character count is inaccurate/timeline allowed too many characters

I published the following post (using cmd-return) before realising that there were still too many characters for it to appear whole on the timeline:

And yet the timeline shows the post in its entirety:

The edit screen still shows 285/280 characters.

Looks like there's a similar issue with posts that originate on Glass: like this one from JF Martin (in the app, without the photo, the post is counted as 578 characters)

This is an issue with the optimization we made for showing posts right away in the timeline… I bet if you refresh the post will show properly truncated now, but it doesn't right away. I'll work on fixing this so it's consistent.

Mine is still not truncated, at least on this page which was the only way I could find the timeline version. I'm not sure what type of refresh would change this.
You can see JF Martin's is the same:

Maybe he would need to refresh it himself to force the truncation? Do posts in the timeline change from that far back?

I just tested this again, with the new 300-character limit, and this post has the same problem.


Add test coverage in TestGroupKeyManagementCluster for EpochStartTime0 set to 0

See https://github.com/project-chip/connectedhomeip/pull/26726#discussion_r1202305068
@rcasallas-silabs could you figure out what needs testing here?

Closing this because TestGroupKeyManagement has a step that test this:
    - label:           "KeySetWrite with EpochStartTime0 set to zero fails INVALID_COMMAND"       command: "KeySetWrite"       arguments:           values:               - name: "GroupKeySet"                 value:                     {                         GroupKeySetID: 0x01a1,                         GroupKeySecurityPolicy: 0,                         EpochKey0: "\xa0\xa1\xa2\xa3\xa4\xa5\xa6\xa7\xa8\xa9\xaa\xab\xac\xad\xae\xaf",                         EpochStartTime0: 0,                         EpochKey1: null,                         EpochStartTime1: null,                         EpochKey2: null,                         EpochStartTime2: null,                     }       response:           error: INVALID_COMMAND


Improving server side rendering docs to include feature

I was trying thaw and stumble accross an error cannot call wasm-bindgen imported functions on non-wasm targets when trying to serve my basic leptos page. It turns out the feature need to be added to those lists on Cargo.toml for thaw to work. This might be obvious to more experienced devs in rust, but me being a newbie couldn't solved it by myself.

Thank you!


fix: Drop coverage produced by nyc --all for files that were tested

Sometimes the coverage data produced by nyc --all is incompatible with
the coverage data produced by actual test runs.  This is generally due
to configuration error but results in inconsistent coverage reports or
in some cases causes nyc report to crash.  The workaround is
implemented in istanbul-lib-coverage to drop coverage data associated
with nyc --all when coverage data from a test run is found.  This
commit tags the coverage data when appropriate so the coverage merge
logic knows what to do.
Fixes #1113, #1124, #1148

Coverage decreased (-0.005%) to 97.845% when pulling 990bdec29e6053bc034302a6a653164cfeacf226 on coreyfarrell:annotate-all-cov into 77832845b85134d21eca3a23c812c4f21f36713f on istanbuljs:master.


Add showcase frontend application

Basic information

nrich version:
1.2.1
Module:
project

Additional information

Enhancement description
In real world, in most cases users would probably use Nrich with some frontend. After #55, it would be useful to have example frontend application which would showcase some Nrich features by example.
Current behaviour
Wanted behaviour
Possible workarounds

Implemented see: https://github.com/croz-ltd/nrich-demo-frontend


提供一种新的类全局timeout方法, 收敛包级别的超时设置

Codecov Report

Merging #295 (40985f7) into master (758557a) will decrease coverage by 0.06%.
The diff coverage is 88.23%.

@@            Coverage Diff             @@
##           master     #295      +/-   ##
==========================================
- Coverage   90.99%   90.92%   -0.07%
==========================================
  Files          44       44
  Lines        1699     1708       +9
==========================================
+ Hits         1546     1553       +7
- Misses        103      105       +2
  Partials       50       50

Impacted Files
Coverage Δ

dataflow/dataflow.go
89.67% <0.00%> (-1.18%)
:arrow_down:

dataflow/gout.go
100.00% <ø> (ø)

dataflow/req.go
81.81% <100.00%> (+0.44%)
:arrow_up:

gout_newopt.go
100.00% <100.00%> (ø)

gout_options.go
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 758557a...40985f7. Read the comment docs.


Moved LosslessDataConvertible definitions over from vapor/core

Trying to keep the style of LosslessDataConvertible consistent with LosslessStringConvertible

I've added a new type CryptoData to #82. Going forward, I think this will be more flexible than relying on Foundation.Data and these convertible protocols.


API & features feedback

I'm plan to release v1.0.0, before this we need

Finalize API signature
Add feature if really needed

Welcome feedback, thanks!

add search.arc.xz.gz


ci: update renovate to set vscode update with fix semantic commit type

:tada: This PR is included in version 0.14.0 :tada:
The release is available on:

Visual Studio Marketplace
GitHub release

Your semantic-release bot :package::rocket:


Update linker script to put .data into FLASH

This is the updated linker script and test from #86.
Sadly it looks like LLD does not use the ALIGN(4) in the .data section header to align the LMA (unlike gcc), so we still need the . = ALIGN(4) at the end of .rodata to ensure LMA alignment.
I've added a failing example which the ci script ensures fails when .data causes overflow. It just checks for non-zero return from cargo rather than specifically grepping for the linker error messages about .data overflowing; since we only have the one failing example I could remove the loop and just specifically check it and grep for the relevant error from gcc and lld if people think that would be better.

Thanks @adamgreig!
bors r+


Current merge and configuration scripts for windows platform are not working properly.

Description:
The Windows counterparts of the merge.sh and configure.sh scripts (i.e., merge.bat and configure.ps1) in the WSO2 Open Banking Accelerators are broken and require fixes to handle various issues.

Both merge.bat and configure.ps1 require the base product directory as their first parameter. But nowhere in our docs mention that nor the .sh files do not require that.
These scripts fail when the provided paths contain spaces
The content replacement logic in configure.ps1 does not work for all use cases. (When replacing the the INPUTS VARCHAR(1000) with INPUTS VARCHAR(7500)in the<APIM_HOME>/dbscripts/apimgt/mysql.sql` and when replacing some stuff in mssql files)
The configure.ps1 script in the IS accelerator tries to automatically download and install the IS connector. But its configure.sh file skips that step.
The consentmgr.war extracting step is missing from the IS configure.ps1 script.

These issues are not present in the Linux versions of these scripts (merge.sh and configure.sh), which work as expected. Fixing these issues is crucial for ensuring the functionality and reliability of the WSO2 Open Banking Accelerators on Windows platforms.
Affected Product Version:
OB APIM Accelerator 3.0.0, OB IS Accelerator 3.0.0
OS, DB, other environment details and versions:
OS - Microsoft Windows 10 Version 22H2
DB - MySQL 8.4.0

Related Internal Issue:

https://github.com/wso2-enterprise/wso2-ob-internal/issues/737


Use kubeadm-dind-cluster for e2e tests

As a bonus, add VM network checking to the updated expect script.

This change is

Reviewed 11 of 11 files at r1.
Review status: all files reviewed at latest revision, 2 unresolved discussions, some commit checks failed.

deploy/demo.sh, line 51 at r1 (raw file):

function demo::start-dind-cluster {
  demo::step "Will now clear any kubeadm-dind-cluster data on the current Docker"
  echo "VM console will be attached after Virtlet setup is complete, press Ctrl-] to detach." >&2

This message seems to be incorrect for non interactive test.

tests/e2e/e2e.sh, line 21 at r1 (raw file):

set -o errtrace

if [ $(uname) = Darwin ]; then

Hmmm... Is there a possibility that this would work on OS X?
I know that libvirt can be installed on mac (e.x. using brew), but will it work with kubeadm-dind-cluster?

Comments from Reviewable

Review status: 10 of 11 files reviewed at latest revision, 2 unresolved discussions.

deploy/demo.sh, line 51 at r1 (raw file):
Previously, jellonek (Piotr Skamruk) wrote…
This message seems to be incorrect for non interactive test.

Done.

tests/e2e/e2e.sh, line 21 at r1 (raw file):
Previously, jellonek (Piotr Skamruk) wrote…
Hmmm... Is there a possibility that this would work on OS X?
I know that libvirt can be installed on mac (e.x. using brew), but will it work with kubeadm-dind-cluster?

This scripts runs without problems on Mac. libvirt works inside docker (either inside Mac Docker's VM or on a remote docker engine) virsh.sh invokes virsh inside virtlet container.

Comments from Reviewable

 but tests failed.

Reviewed 1 of 1 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.

Comments from Reviewable

@jellonek I restarted it because the error is bit strange 2017-03-23 20:31:04.901+0000: 33: error : virQEMUCapsParseHelpStr:1419 : internal error: QEMU / QMP failed: Could not access KVM kernel module: No such file or directory

Review status: all files reviewed at latest revision, all discussions resolved, some commit checks pending.

Comments from Reviewable

So it's not strange because tests on travis require VIRTLET_DISABLE_KVM which was in dockercompose there https://github.com/Mirantis/virtlet/pull/225/files#diff-ab085fe24e590ec1acbd9b89bdf5522aL9
So it should be added to travis variables and then passed to e2e script and so on.

Review status: all files reviewed at latest revision, all discussions resolved, some commit checks pending.

Comments from Reviewable

@pigmej @jellonek I don't quite understand why QEMU complains about KVM here. Actually in this case VIRTLET_DISABLE_KVM is passed, it's currently hardcoded in Virtlet DaemonSet definition https://github.com/Mirantis/virtlet/blob/76e4a04bd3e6bd78378f831ae4c50bb82d3c2aad/deploy/virtlet-ds.yaml#L121 Basically replacing it with optional autodetect is what #223 is about. Concerning the actual reason for the test failure, if you see libvirt log at the end, this usually means that 'make test' stage failed, and you need to scroll up a bit to see what test caused the failure. The failed build appears to be cleared after restart so I can no longer see the log, but usually it's flaky CRI proxy race test - made in issue for it https://github.com/Mirantis/virtlet/issues/226 (there's a link to a sample failure log there, too) I'll try to see whether it's possible to fix it really quickly or we can disable the test on Travis for the time being.

Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.

Comments from Reviewable

It's green now....

Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.

Comments from Reviewable


feat: labeled parameters

Uses labeled parameters.

TODO
I don't now how to test it.

[ ] Test RestClient
[ ] Test Unity

close : #34

Hello, thanks for the PR.
The feature to enumerate select options by method is powerful, but I was concerned about the following:

Since the values are limited toint, So I did not see a big difference from enum.
The fact that values are limited to int may not be obvious to users.

Why not an approach such as giving each value of Enum a [Display("label name")], etc.?
If you have a strong use case that would require enumeration by method, please let us know.
We discussed this with the original author, but we decided not to merge it as is.
If you don't agree, reopen is welcome.

And If you have a strong use case that would require enumeration by method, please let us know.

I assumed that we would use descriptive names instead of key values for external data (such as game master data).
While I agree that there is some frustration with the limitation of using only int, I do not oppose closing this pull request.
I would be grateful if one or both of the following were provided as features:

A way to load and enumerate data at runtime.
A way to label data at runtime.

Ah ok,  it might be useful in some cases to be able to select master data.
However, It may not be a high priority to support in the main repo.
If you have a good implementation, PR is welcome.


Pipeline / Pre or Post Request Handler only for some specific  Domain events

Hi there,
Thanks for the great library and we are using this for one of our projects. So far every thing is working as expected. We came across a requirement and like to understand the best way to implement the same. Like to know how others have accomplished the similar requirements.
Requirement is as follows. We need to implement a profiling/ auditing for certain handlers only. Our initial thought was to implement as follows.
public interface IMarkerInterface {}
public class DomainObject : IMarkerInterface {}
publi class OtherDomainObjects () {}
We expected to implement a behavior that get executed for each and every Request Object that implements the IMarkerInterface.
Is that the right way to do? We are using structure map and we were not successful so far in get this working? Does anyone has tried the same. Any suggestions ideas are greatly appreciated.
Thanks

Hi,
I don't think that is a contraint on MediatR itself, but more on a language specific contraint, of inheritance of interfaces on the generics (the Pre or Post Handlers). I don't think there is a way to configurate the container (structure map) to give you a open generic but just if the type enherites from another (I can be wrong).
What you could do instead, and it's not that far off your proprosal desing, in fact, I even think is a far more suitable one, is to declare some attributes.
Then you could create a PreHandler that is registered on every request that inspects the message object and applies the profiling / auditing you see fit.

Hi Joao
Thanks for the direction. We will proceed with the design/implementation as you suggested. I have a follow up question. Is there any performance overhead is calling the preHandler for every request. The reason we ask is we have some Pipeline behaviors which does logging of Request/Response for every handler, some pipeline for some cross cutting concerns. So wondering with structure map what is the performance penalty of having too many preHandlers. Just want to do what is best and the minimum.
Thanks

Yes. It will have the overhead of creating the instance (if it's an instance per request) and the check for the attribute present.

@shibukraj An update.
With Autofac I was able to make your initial scenario, using builder.RegisterSource(new ContravariantRegistrationSource());
With StructureMap I believe that can be acomplish also.


Fix no-dsa

Also fixes no-dh

Shouldn't the commit simply say this:
Fix no-dh and no-dsa

It seems a bit silly to have that additional "also" line

It seems a bit silly to have that additional "also" line

It depends on how you look at it. If you see this as primarily a fix for no-dsa which co-incidentally fixes no-dh on the way then it makes perfect sense. I'm not sure why expressing it that way is a problem.

Looks like #9840 doesn't fix the build.info file part of this PR

Right.

So... are you going to fix the no-scyrpt problem along with in this PR or I fix that in #9840 separately?

I suggest you just make #9840 about the no-scrypt issue, and we'll keep this one for no-dsa.

OK

It depends on how you look at it...

Yeahok, never mind then


[Bug] The local cache artifact in "/workspaces/sage-monorepo/node_modules/.cache/nx/..." was not been generated on this machine.

Is there an existing issue for this?

[X] I have searched the existing issues

What product(s) are you seeing the problem on?
OpenChallenges
Current behavior
The error occurred after rebuilding a fresh dev container, running workspace-install and then when running openchallenges-build-images.
>  NX   Ran target build-image for 26 projects and 23 tasks they depend on (410ms)

    ✔    0/0 succeeded [0 read from cache]

    ✖    0/0 targets failed, including the following:

   View structured, searchable error logs at https://cloud.nx.app/runs/GvPHg6ShZ2

 >  NX   Invalid Cache Directory for Task "openchallenges-app-config-data:build"

   The local cache artifact in "/workspaces/sage-monorepo/node_modules/.cache/nx/18344747563957698274" was not been generated on this machine.
   As a result, the cache's content integrity cannot be confirmed, which may make cache restoration potentially unsafe.
   If your machine ID has changed since the artifact was cached, run "nx reset" to fix this issue.
   Read about the error and how to address it here: https://nx.dev/recipes/troubleshooting/unknown-local-cache

   Pass --verbose to see the stacktrace.

Expected behavior
No response
Anything else?
No response
Commit ID
No response
Are you developing inside the dev container?

[X] I am using the dev container

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Solution
The error message describes well the issue and propose to run nx reset, which solves the issue.


Some release tests fail on testnet when activity is high and gas prices are higher.

Description
Release tests that check gasPrices fail on testnet when activity is high.  This slows down the release process.
Steps to reproduce
Run the acceptancetest:release during business hours in the US.  The following may fail:
@release should execute "eth_getTransactionReceipt" for hash of legacy transaction,
@release should execute "eth_getTransactionReceipt" for hash of London transaction,
@release should execute "eth_getTransactionReceipt" for hash of 2930 transaction,
@release should return the right "effectiveGasPrice" for SYNTHETIC Contract Call transaction,
@release should execute "eth_sendRawTransaction" for legacy EIP 155 transactions,
@release should execute "eth_getTransactionByHash" for existing transaction,
@release fail "eth_getTransactionReceipt" on precheck with wrong nonce error when sending a tx with the same nonce twice,
@release fail "eth_getTransactionReceipt" on submitting with wrong nonce error when sending a tx with the same nonce twice,
@release should correctly execute "eth_getBalance" with block number in the last 15 minutes with several txs around that time,
Additional context
No response
Hedera network
testnet
Version
v0.36.0
Operating system
macOS

20% deviation fixed this.  PR #2033


SVGAndroidRenderer.processMaskBitmaps is very slow

What steps will reproduce the problem?
1. Render the attached test.svg using renderToCanvas

What is the expected output? What do you see instead?
For a small file like this, I'd have expected a few ms to render. Instead, it
took 200ms - 300ms. Using renderToPicture, and rendering the picture it was
only 15ms.

I profiled it, and processMaskBitmaps was the major bottleneck. Instead of the
custom processing, I'd guess drawBitmap using a PorterDuffXfermode would work
here, too. E.g. paint.setXfermode(new PorterDuffXfermode(Mode.DST_IN));

Original issue reported on code.google.com by<EMAIL_ADDRESS>on 17 Aug 2014 at 8:41
Attachments:

test.svg

Inherited issue, not relevant.


Establish a schedule for developing and offering FOLIO training

We need to plan training and documentation, and publish that plan. We have gotten the following questions related to training:

[x] Are there public timelines for migration/training opportunities, etc.?
[x] Will in people on the pods be required to train everyone else?

People have also expressed concern that Libraries faculty/staff aren't absorbing the scope and depth of impacts on workflows and day-to-day processes. Hopefully creating a clear and public plan for the scope of the training and documentation will do some "show rather than tell".

Timelines show that we plan to create training from May through August and then deliver it from September to Jan 2023 and through go-live. We have considered a few models for training and may get some help from a vendor.


Don't check state hashTreeRoot when reapplying blocks

Description
Improve performance of reapplying blocks by skipping the check that the resulting state root matches the root in the block. This would have been checked when initially importing the block so we know it is correct. Skipping this check should enable us to avoid calculating the root for the state which can be quite expensive. Since most uses of states wind up accessing the state root, the initial benefit here will be when multiple blocks need to be replayed to generate a state - we should not need to calculate the root for the intermediate states.
A further optimisation would be to have the resulting BeaconState take it's state root from the value in the block so that it doesn't need to calculate it even if something later needs to access it.

We were already checking this step in the actual state transition but then added the check as part of the actual regeneration scheduling code which is unnecessary.


github issue #8, added deep immutability, updateIn

added deeper immutability by using immutable.js fromJS() method when
setting the initial irecord (this will transform deeper arrays and objects when setting the irecord).
exposed the updateIn immutable method to irecord. this takes a transform
method and makes dealing with updating arrays (and their keys) easier.
added two tests.

:+1:

I'm not a big fan of the immutable API and wanted to keep it more simple but now I'm waffling.
Now I'm hungry for waffles.

Please use $ npm run check and get all the preflight checks passing. =)

I understand what you mean about keeping it simple, but using set without a transform function makes it tough to manage an array. the transform methods could be mapped to a method of the wrapper class though:
rec.set( 'keyThatGetsAnArray' ).push("new value")
rec.set( 'keyThatGetsAnArray' ).splice( ... args ...)
// etc

but exposing the inner transform API was the simpler solution I took here.
btw, love the package set up. the testing, linting, building, and prechecking are all real nice.

@NickStefan Would you mind opening a new issue for the .updateIn() functionality? That's really an entirely separate issue, and we need to think a little more carefully about the API.
Please review #10.


mt_tps does not seem to affect number of messages hitting the SMPP endpoint

We have mt_tps set to 1.
However, if 100 messages are queued in the outbound queue, all of them seem to be sent in less than a minute. (SMPP) This causes issues where the terms of usage require that only 1 message is sent per second.  How can we ensure that only 1 message is sent per second?
Please somebody advice.

Hi @Telewa
The mt_tps is the correct config value for the SMPP transport for limiting the rate of outbound messages.
If this is not correctly throttling messages, then it's possible that there is a bug in the throttling code. Do you see anything about throttling in the logs? There are a number of logs for various throttling actions at the INFO log level.
I would suggest looking at https://github.com/praekelt/vumi/blob/develop/vumi/transports/smpp/smpp_service.py#L74-L194 for a start at the throttling code.
Our contributing guidelines can be found at: https://github.com/praekelt/vumi/blob/develop/CONTRIBUTING.rst

Thank you @rudigiesler,
Yes I can see throttling happening. however, the even if mt_tps is set to 1, 100 messages are delivered pretty quickly without regard to this parameter. I would expect this param to determine how long it would take to deliver x number of messages.

@Telewa
Yes, this parameter should limit the amount of messages sent within each 1 second window. So as long as it's an integer greater than 0, it should limit the outbound speed to the configured messages per second. Keep in mind that this is vumi messages per second, not PDUs per second, but it seems like in your case you're talking about vumi messages per second.
If it's not then it's possible that there's a bug somewhere in the throttling code that we haven't been able to pick up on.

@rudigiesler just a clarification, does window in your previous message mean window_size as used here? https://github.com/praekelt/vumi/blob/e179b69296f368ce4ad6bce34f96c73df675c8b3/vumi/components/window_manager.py#L23
in case it is, how can we make this parameter dynamic ?

Cool.  Thanks @rudigiesler  for the clarification.
Do you confirm however, that if we have 100 messages in rabbitmq vumi outbound queue, to be sent out, and we have set the mt_tps to 1, then it should take 100 seconds to completely deliver all these messages?

Yes, if you're using the SMPP transport then that should be the case. If it doesn't limit the sending rate, then there's possibly a bug in the SMPP transport.

Thanks a lot @rudigiesler. i'll look at the code then. There could be a bug somewhere.


Make public folder path configurable

What problem does this feature solve?
Renaming or moving the public folder in order to use vue-cli alongside other frameworks (e.g. Laravel).
Yes, it is possible to achieve it with this configuration:
const path = require('path')

const publicDir = 'assets/html';

module.exports = {
    chainWebpack: config => {
        config
            .plugin('html')
            .tap(args => {
                args[0].template = path.resolve(publicDir + '/index.html');
                return args
            })

        config
            .plugin('copy')
            .tap(([pathConfigs]) => {
                pathConfigs[0].from = path.resolve(publicDir);
                return [pathConfigs]
            })
    }
}

But for such a simple configuration this feels ridiculous.
What does the proposed API look like?
Specify the public directory path in the vue.config.js
module.exports = {
    publicDir: 'assets/html' // Defaults to 'public'
}

@marvinrabe Thank you for the config example. I have been struggling with this same problem for days. The build process fails with your config but at least it's given me hope that I'll be able to figure out a solution.
At the very least I wish I could tell vue to not copy any or at least certain files from the public folder over to the /dist. My several gigabytes of files in the /public/gallery folder takes a while to copy and it's a waste of space to make a copy of it.

I also ran into this issue in the CLI. How come these two very popular frameworks (Vue.js and Laravel) have conflicting folder structures when they are so often used together? Cannot the teams cooperate together if it is a typical technology stack?
@yyx990803 I see your point here. But sometimes you need to have a thin Laravel wrapper around your Vue.js SPA and you don't want to move all Vue.js code to a subfolder if that's the place where you spend the most time during development. So having it at least configurable would be a great improvement. Although the ultimate solution would be not to have any conflicts between Vue.js and Laravel default folder structure.

I have a number of vue projects running, and to avoid boilerplate I put all common configuration in a node package called 'vue2-bootsrap', which is installed via npm and from which the vue-cli gets started:
vue-cli-service serve $INIT_CWD/src/main.js

While this works perfectly fine, the cli serve/build tasks are looking into the local vue2-bootstrap/public folder and do not respect the projects public folder index.html template or local static assets like a favicon.ico or a logo.png.
It would be greate to have a publicFolder option.

Anyone using Laravel have a look at nuxt.js and this boilerplate:
https://github.com/acidjazz/laranuxt
You can create a SPA in combination with a Laravel backend without the public folder issues of vue-cli.
Simply stop using vue-cli. In my opinion nuxt.js has the overall better design nonetheless.

const path = require('path')
const publicDir = 'assets' // Defaults to 'public'

module.exports = {
  chainWebpack(config) {
    config.plugin('html').tap((args) => {
      args[0].template = path.join(publicDir, 'index.html')
      return args
    })
    /* config
      .plugin('copy')
      .use(require('copy-webpack-plugin'), [
        [{ from: path.resolve(publicDir) }],
      ]) */
    config
      .plugin('copy')
      .use(require('copy-webpack-plugin'))
      .tap((args) => {
        return [
          [...(args[0] ? args[0] : []), { from: path.resolve(publicDir) }],
        ]
      })
  },
}


Question: Plans for standalone packages?

While this project is mainly for Azure deployments, I can see that the code is structured in such a way that there are parts that are completely Azure agnostic. Are there any plans of releasing such parts, for example, the Dicom.Core or Dicom.Client as official standalone NuGet packages?
I think that a stable and well functioning DICOMweb client library for .NET would be valuable for many that are not yet considering using the full blown project for example.

We've certainly talked about pulling out the DICOMweb client library, as well as releasing portions of the solution as NuGet packages.  I'll restart that conversation and update this thread shortly with some of our thoughts.  Some dependencies might be hard to pull out, but a Dicom.Client NuGet could certainly make interacting with any DICOMweb system, including this one, far simpler for .NET developers.

@edespong, I just wanted to cycle back to this comment!  I haven't forgotten about your request.  We've been very focused on getting the Azure Healthcare API hosted solution (which uses this as its underlying code) into general availability. I apologize for the delay, Erik.

closing as stale


Add progress information on inspection loading modal

This step is often taking over 30 seconds. With a simple spinner and no information on the progress, it leads the user to wonder if there is not a bug.
It would be a much better UX to have a % progress information

Created this issue on the wrong repo, sorry. Closing


Azure Devops - Key Vault task - Specified service connection needs to have x y z

Required Information
Entering this information will route you directly to the right team and expedite traction.
Question, Bug, or Feature?
Type: Bug
Enter Task Name: Azure Key Vault
list here (V# not needed):
https://github.com/Microsoft/azure-pipelines-tasks/tree/master/Tasks
Environment

Server - Azure Pipelines or TFS on-premises?
Azure Pipelines

If using Azure Pipelines, provide the account name, team project name, build definition name/build number:

account<EMAIL_ADDRESS>project: lab
release info: releaseId=389&environmentId=646&deploymentGroupPhaseId=567&agentName=COVD01

Agent - Hosted or Private:

If using Hosted agent, provide agent queue name:

If using private agent, provide the OS of the machine running the agent and the agent version:

OS Name	Microsoft Windows Server 2016 Datacenter
Version	10.0.14393 Build 14393
(This is a VM hosted on Azure)
Issue Description
We have an azure subscription.
I created a new Key Vault within that subscription.
I used the following powershell script to create a service principal and get all the details I needed to create a new service connection in Azure DevOps:
https://github.com/Microsoft/azure-pipelines-extensions/blob/master/TaskModules/powershell/Azure/SPNCreation.ps1
I have a release pipeline on Azure Devops.
I added an "Azure Key Vault" task to this pipeline.
I was able to select my subscription, and select my keyvault from the drop downs within the task:

However when I create a release, and this step is executed, it fails with the following error message written to the release log:

QlikClient: "Access denied. The specified Azure service connection needs to have Get, List secret management permissions on the selected key vault. To set these permissions, download the ProvisionKeyVaultPermissions.ps1 script from build/release logs and execute it, or set them from the Azure portal."

The thing is, when I set up the new service connection, I used a service principal that has full access. So I have no idea why access is denied.
Note: Our Azure Devops Organisation is under a different subscription from our Azure Key vault - ot sure if that makes any different.
Happy to provide any other details required. Note, the task log below says there is a ps1 script somewhere I can run, but i'm not sure where I have to navigate to in Azure Devops in order to download it.
Task logs

2019-04-30T16:54:59.3448695Z ##[section]Starting: Get QlikClient PFX From KeyVault
2019-04-30T16:54:59.3453310Z ==============================================================================
2019-04-30T16:54:59.3453421Z Task         : Azure Key Vault
2019-04-30T16:54:59.3453507Z Description  : Download Azure Key Vault Secrets
2019-04-30T16:54:59.3453581Z Version      : 1.0.32
2019-04-30T16:54:59.3453657Z Author       : Microsoft Corporation
2019-04-30T16:54:59.3453742Z Help         : More Information
2019-04-30T16:54:59.3453842Z ==============================================================================
2019-04-30T16:55:00.2810600Z SubscriptionId: 5adb7e7f-fe52-4809-b539-2e6bbdbaf890.
2019-04-30T16:55:00.2817095Z Key vault name: Hub-Dev.
2019-04-30T16:55:00.2842285Z Downloading secret value for: QlikClient.
2019-04-30T16:55:00.6533488Z ##[error]
QlikClient: "Access denied. The specified Azure service connection needs to have Get, List secret management permissions on the selected key vault. To set these permissions, download the ProvisionKeyVaultPermissions.ps1 script from build/release logs and execute it, or set them from the Azure portal."
2019-04-30T16:55:00.6534149Z Uploading C:\azagent\A1_work\r2\a\ProvisionKeyVaultPermissions.ps1 as attachment
2019-04-30T16:55:00.6580465Z ##[section]Finishing: Get QlikClient PFX From KeyVault

Troubleshooting
Checkout how to troubleshoot failures and collect debug logs: https://docs.microsoft.com/en-us/vsts/build-release/actions/troubleshooting
Error logs

Ah so I found the generated powershell scrip that the task was mentioning, in devops:
I needed to click on "Download all logs":

Then the file is:

I'll try running that powershell script and trying again

Yep.. running that powershell script fixed it. It would be good if someone can clarify why this is necessary though  - given the previous powershell script that was run I thought the service connection used should have full access required..?

@dazinator Good to see that you were able to resolve it yourself.
The azure service connection does not have permission on the key-vault and users need to explicitly give permissions to access the keyvault.
When we create keyvault backed variable groups, we take the users via the assignment of permissions flow but when the key vault task gets used directly, then users should run the power shell script to assign the permissions.

@dazinator

Yep.. running that powershell script fixed it. It would be good if someone can clarify why this is necessary though - given the previous powershell script that was run I thought the service connection used should have full access required..?

I have tried executing PowerShell script before accessing Key vault. Unfortunately I am getting same error before this task.
Please let me know where to execute this PS Script.
I have also checked all permissions on azure portal, service principal have full access.

@dazinator Where do you run the script? Do you run it before the azureKeyVault task or after when it fails? Could you please help with this one?

I'm running into the same issue except that my dev machine is a Mac and the build agent is Linux, so I don't have anywhere to run this .ps1. Is there an az CLI script equivalent?
Also it's not clear to me: is this script a run-once thing or does it need to be part of the pipeline tasks?
Any help much appreciated.

@darzu, you can run the following command for updating the key vault access policies for secrets
az keyvault set-policy --name "" --spn  --secret-permissions get list
In case you want to know more on setting access policies for key vault, refer to
https://docs.microsoft.com/en-us/azure/key-vault/key-vault-manage-with-cli2#authorizing-an-application-to-use-a-key-or-secret

@darzu , is this working for you?

Closing this issue. @darzu please reopen if you are still facing any issues

The specified Azure service connection needs to have "Get, List" secret management permissions on the selected key vault. Click "Authorize" to enable Azure Pipelines to set these permissions or manage secret permissions in the Azure portal.
Getting the same error for service connection "Free Trial".
Can some one help with resolution, please provide the url of the script, it's hard time getting the script mentioned in the above comment.

The specified Azure service connection needs to have "Get, List" secret management permissions on the selected key vault. Click "Authorize" to enable Azure Pipelines to set these permissions or manage secret permissions in the Azure portal.
Getting the same error for service connection "Free Trial".
Can some one help with resolution, please provide the url of the script, it's hard time getting the script mentioned in the above comment.

If you don't know the ID of the Service Principal you should download it by going to the log page and downloading all logs, because the downloaded script will contain the ID.

Otherwise, here is the content of the script:
$ErrorActionPreference="Stop";             Login-AzureRmAccount -SubscriptionId XXXXXXXX-XXXX-XXXX-XXXX-XXXXXXXXXXXX;             $spn=(Get-AzureRmADServicePrincipal -SPN XXXXXXXX-XXXX-XXXX-XXXX-XXXXXXXXXXXX);             $spnObjectId=$spn.Id;             Set-AzureRmKeyVaultAccessPolicy -VaultName yourVaultName -ObjectId $spnObjectId -PermissionsToSecrets get,list;

Stumbled upon this by accident, but thought I'd chip in some background knowledge for anyone else who finds themselves here, as there's a fundamental bit of knowledge not being explicitly stated.
There are two types of access being conflated in the initial question: Azure Resource role permissions and KeyVault Access Policies. These are referred to here as the Management Plane and the Data Plane. I've not spotted any other resource type that carries two types of permission sets like this.
The service principal in @dazinator 's example has full access on the Management Plane, but no access on the Data Plane*, hence why his deployment failed. This can be fixed in the portal by going to the KeyVault resource and, in the Access Policies blade, adding an access policy granting the service principal permission to the Data Plane. This is what the ProvisonKeyVaultPermissions script is doing: creating an access policy.
*It's worth noting that full permissions in the Management Plane includes the ability to create Access Policies, and thus control permissions on the Data Plane.

why i am getting this mail?
On Fri, May 29, 2020 at 3:35 PM BobTheMadCow<EMAIL_ADDRESS>wrote:

Stumbled upon this by accident, but thought I'd chip in some background
knowledge for anyone else who finds themselves here, as there's a
fundamental bit of knowledge not being explicitly stated.
There are two types of access being conflated in the initial question:
Azure Resource role permissions and KeyVault Access Policies. These are
referred to here
https://docs.microsoft.com/en-us/azure/key-vault/general/secure-your-key-vault
as the Management Plane and the Data Plane. I've not spotted any
other resource type that carries two types of permission sets like this.
The service principal in @dazinator https://github.com/dazinator 's
example has full access on the Management Plane, but no access on the Data
Plane*, hence why his deployment failed. This can be fixed in the portal
by going to the KeyVault resource and, in the Access Policies blade, adding
an access policy granting the service principal permission to the Data
Plane. This is what the ProvisonKeyVaultPermissions script is doing:
creating an access policy.
*It's worth noting that full permissions in the Management Plane includes
the ability to create Access Policies, and thus control permissions on the
Data Plane.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/microsoft/azure-pipelines-tasks/issues/10274#issuecomment-635889652,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJSPRVKYOHCUBE26XS3G2GDRT6CFTANCNFSM4HJOS4QA
.

This seems somewhat less than automated.  How do I capture the Service Connection's object id so that I can apply the access policy in the pipeline?

Experiencing the same issue. I uploaded the 4_ProvisionKeyVaultPermissions.ps1 file to /home/username via powershell in azure portal.
Executed -->

az account set --subscription $SUBSCRIPTION_NAME
./4_ProvisionKeyVaultPermissions.ps1

PS /home/username> .\4_ProvisionKeyVaultPermissions.ps1
WARNING: Interactive authentication is not supported in this session, please run cmdlet 'Connect-AzAccount -UseDeviceAuthentication'.
Set-AzKeyVaultAccessPolicy: /home/username/4_ProvisionKeyVaultPermissions.ps1:5
Line |
5 |              Set-AzureRmKeyVaultAccessPolicy -VaultName username-PAT -Ob …
|              ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| Vault 'username-PAT' does not exist in current subscription.  If this vault exists in your tenant, please switch to the correct subscription in order to modify the Access Policies of this vault.
I switched to the correct subscription and also gave list,get permission to the application via GUI. still getting the same error.


Test fix

This change is

r? @canndrew
(maidsafe_highfive has picked a reviewer for you, use r? to override)


Frontend authorization docs for plugin authors

Signed-off-by: Joon Park<EMAIL_ADDRESS>Hey, I just made a Pull Request!

:heavy_check_mark: Checklist

[ ] A changeset describing the change and affected packages. (more info)
[ ] Added or updated documentation
[ ] Tests for new functionality and regression tests for bug fixes
[ ] Screenshots attached (for UI changes)
[ ] All your commits have a Signed-off-by line in the message. (more info)

Blocked by https://github.com/backstage/backstage/pull/10450

We still plan on tackling these changes soon! Just haven't found the bandwidth yet.


Support for custom metadata namespaces for SmartControls

Example and case in issue #1560

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Hello @renanwilliam ,
Please signed the CLA.
Regards,
Diana

Hi @Shtilianova,
I have signed some times but it never update the status

@renanwilliam your commit seems to be originally created by @qmacro (or at least one of his automation scripts that regularly push to gh-pages).
This is why CLA assistant still waits for people to sign.
I'm not sure how this happened, but if @qmacro wasn't involved into your change, then you can just reset the commit author so only you show up in the commit.
 I have changed the author and the CLA now is ok.
Thanks

For all I know, https://github.com/SAP/openui5/issues/1560 is invalid. Thus I have to reject this pull request.


Web UI switches to turn_costs=false when changing the vehicle

See: https://github.com/graphhopper/graphhopper/issues/2139#issuecomment-701939220
Might be related to #1952 and probably only applies to the code we are running on graphhopper.com/maps (not the one on current master that uses profiles already).

We use profile everywhere now.


React Weather App With 5 Days Forecast

Describe the project
Introducing ForecastX - The ultimate weather forecasting app
ForecastX is a free and open-source React-based weather app with modern UI technologies. It allows users to track atmospheric conditions for any country or city, automatically saves and updates weather for favourite locations, and offers a 5-day weather forecast with 3-hour intervals. The app works offline, is built on Progressive Web App (PWA) technology, and supports cross-platform access. Users can customize settings to personalize their experience.
How does it work?
ForecastX was built on the openweatherapi, you can search cities or countries to get their weather details, or automatically track where you are using the geolocation API to get your current location weather details. This information are cached and stored in the browser localStorage. When the site loads, the images, pages and all are cached using service workers, so you can always access them offline. The app also would automatically forecast the 5 days weather condition pending on your current location or your search term.
Key Features

Can track the atmospheric condition of any country or city.
Can automatically track the weather of any saved location.
It built customised settings.
Works offline.
Can predict the weather of any geographical area for the next 5 days and 3-hour intervals.
It is free and open source.
Built using modern UI technologies.
Cross-Platform Application.
Built on the PWA technology.

Why Choose ForecastX ?
Accurate 5-day forecast, automatic location tracking, and offline access. Personalize your experience. Free, open-source, and accessible on all devices. Embrace the weather with confidence!
Try it now: Awesome Weather App
Issue Type:

[ ] Bug Report
[ ] Feature Request
[ ] Documentation
[x]  New Project

Technologies used for this project

ReactJS
Bootstrap5
OpenWeather API

Screenshots

React projects are not accepted

What about HTML games?  Are they accepted?
On Sun, 30 Jul 2023, 2:04 pm Tushar Kesarwani, @.***>
wrote:

Closed #1887
https://github.com/TusharKesarwani/Front-End-Projects/issues/1887 as
completed.
—
Reply to this email directly, view it on GitHub
https://github.com/TusharKesarwani/Front-End-Projects/issues/1887#event-9956743563,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AVDKY7USXZOES2PV7EZUDRLXSZLVFANCNFSM6AAAAAA24Q2GUQ
.
You are receiving this because you authored the thread.Message ID:
<TusharKesarwani/Front-End-Projects/issue/1887/issue_event/9956743563@
github.com>


Bike-shedding: throttle -> ?

Using real-world idea of what a throttle is makes it very confusing for the first time using the operator as it blocks until time as oppose to letting events through based on time limit passed in.
I am fully ready to accept I am incorrect, but the first time I used throttle this is the expected behavior.
mouse.
    movement.
    throttle(200).
    subscribe(...);

If the mouse was under continuous use then my expectation was 5 events / second.  If backwards compat is a requirement, then perhaps the method could be called choke (still drawing examples from engines).
Thoughts @blesh.  If this is totally unreasonable, feel no need to humor me and just close the ticket. :)

Using real-world idea of what a throttle is makes it very confusing for the first time using the operator as it blocks until time as oppose to letting events through based on time limit passed in.

I think that RxJS 5 already does this. Earlier version of RxJS had debounce and throttle switched around.
Here is a demonstration of RxJS 5's throttleTime:  http://jsfiddle.net/81hox6cy/
Is this satisfactory?

http://i1.wp.com/i286.photobucket.com/albums/ll117/humaicons/GIFs/spongebobleaves.gif?resize=500%2C323

😄


Implement CV location options

there should be a dropdown in the gui to switch between CV position being:

the position of pacman in the game state (current implementation)
the rounded estimated position of the robot from localization (from robot status)
a fixed value of (1,1)
the position of the mouse cursor

also the green dot in the gui should be the CV position, not always the position of pacman in the game state


Message Content Displaying on Linux

Whenever I get a new message, the content of the message displays in the notification. If I disable "Display desktop plaintext notifications" the notifications don't show at all.
Is there some way to enable notifications with something like "Message content hidden?"

Having looked through the other relevant issues, it seems there is the option to enable this, but the wording is vague. In the client Notification settings, disable "Display desktop plaintext notifications", then message contents are no longer displayed. Tested here and works.


Name only needed for debug

Update name field to only be used in debug mode (maybe)?

Bleh.  Not significant as long as const/prog-mem. (Appears to be .rodata)


Direct action on deployment

This pull request introduces an environment called reference_environment_direct_deployment. The environment loads an Excel file and uses it as a scaffold for calculation.

@jia-chenhua I'm creating the merge request so that we can communicate to the group what you are working on .

@jia-chenhua, I suggest installing the black formatter, please see https://github.com/psf/black

Please use openpyxl when reading excel files, for example:
pd.read_excel("foo.xlsx", engine="openpyxl")

The previous code only worked with xlrd 1.x and there are security vulnerabilities here. Hence, add openpyxl as a dependency and don't use old versions of xlrd as a dependency.

Hi @jia-chenhua, these are some initial code-review comments:

[ ] Suggest following python conventions throughout: variable names like Pathways2Net0 can be confusing to a python developer, because a python developer would think that this is a class. Please be roughly familiar with https://google.github.io/styleguide/pyguide.html. These patterns occur throughout and need to be revised: for example self.EconoImpact (there are many other examples)

[ ] As above, suggest installing the black formatter, please be familiar with https://github.com/psf/black

[ ] Avoid white spaces in all file names (for example, most of the Excel files have whitespaces), use underscores or dashes

[ ] Avoid checking in any outputs into GitHub (for example the set of output png files are polluting the environment folder). If a participant clones the environment, they shouldn't have access to these model-training related files: we are not following the "separation of concerns" mantra here.

[ ] Similarly, the many Model_*.zip files shouldn't be checked in

[ ] If env_original.py is not in use, it should be removed from the repository

[ ] There is duplication of information here:
"reference_environment_direct_deployment:reference-environment-direct-deployment-v0"

We should think of a more friendly structure here.

[ ] There are cache files in the repo that need to be removed and add to the .gitignore file: for example __pycache__ in reference_environment needs to be removed (there are other __pycache__ folders in the project that also need to be removed)

[ ] There are many imports that aren't being used, for example in this list:
import math

import pandas as pd
import numpy as np
import gym
from gym import spaces, logger
from gym.utils import seeding
import matplotlib.pyplot as plt
from pycel import ExcelCompiler
from IPython.display import FileLink

match, logger, seeding and FileLink aren't being used – so they should be removed from the import list.

@jia-chenhua I've just added a test script for demonstrating serialisation/de-serialisation here: https://github.com/rangl-labs/netzerotc/tree/175e4566cdbf352decb50b16fbc17cf11e218774/environment/reference_environment_direct_deployment/hack
The typical output is:
INFO: took 17.473490953445435 seconds to load natively
INFO: took 0.00010895729064941406 seconds to load from serialised file

so this is a speed-up of order 100 thousand.

I'll fix/resolve all code-review comments later, but for now, the black formatter, is it possible to temporarily revert back to the previous format/style (explained in #33 (comment))?

Yep, see https://github.com/rangl-labs/netzerotc/issues/33#issuecomment-939128296

@jia-chenhua can you update the documentation here: https://github.com/rangl-labs/netzerotc/blob/a9606078f04247576e918ecbce4b29c1c785c638/environment/README.md
Looks like we've moved on from loading xlsx files to loading serialised python objects – the documentation needs to reflect this.

Yep. Once that is done you can squash and merge this pull request into the main branch.

Hi @masonlr , should I squash and merge now, and then fix the issues in your code review comments https://github.com/rangl-labs/netzerotc/pull/34#issuecomment-933053092 after creating a new branch called 'fix_code_review' or so? Or should I fix them all and only after that, I squash and merge this request?

should I squash and merge now

Yep go for it. It's generally better to get changes into main as fast as you can, rather than having long-lived branches. Think many small iterations, rather than a few large iterations.

Thanks for your confirmation. It's done now, and I'll create another branch for fixing the code review comments https://github.com/rangl-labs/netzerotc/pull/34#issuecomment-933053092

Hi @jia-chenhua, these are some initial code-review comments:

[ ]  As above, suggest installing the black formatter, please be familiar with https://github.com/psf/black

Hi @masonlr , please feel free to apply black formatter on the latest commit on the latest commit https://github.com/rangl-labs/netzerotc/commit/64be42f2e276855772f227a6d03d977520440b0a.

Hi @jia-chenhua, these are some initial code-review comments:

[ ]  Avoid checking in any outputs into GitHub (for example the set of output png files are polluting the environment folder). If a participant clones the environment, they shouldn't have access to these model-training related files: we are not following the "separation of concerns" mantra here.
[ ]  Similarly, the many Model_*.zip files shouldn't be checked in
[ ]  If env_original.py is not in use, it should be removed from the repository
[ ]  There are cache files in the repo that need to be removed and add to the .gitignore file: for example __pycache__ in reference_environment needs to be removed (there are other __pycache__ folders in the project that also need to be removed)

Is it possible to delete these files directly on https://github.com/rangl-labs/netzerotc/tree/fix_code_review when opened in a web browser?

Hi @masonlr , it seems that in https://github.com/rangl-labs/netzerotc/pull/34/commits/462f9d44fcc1f3c0a2b702716bd578fda874bb58, the 'Pathways to Net Zero - Simplified.xlsx' containing sensitive information was pushed to /environment/compiled_workbook_objects/. Are we supposed not to push it due to confidentiality reason?

@jia-chenhua , I'm wondering whether in the slightly longer term it might be a good idea for you to have access to a native implementation of git. I believe that @jmontalvo94 has this on his Windows machine, so perhaps you could ask him? Then it might be easier to install black, and generally deal with repositories. (I also have a Mac laptop available whose built-in display isn't working, but which works with an external (eg HDMI) display, and can run git natively.)

as I'm not really familiar with the syntax of gym.make() and registering the package in pip, what should I do with the above line to simplify it?

@jia-chenhua please try to debug this - maybe it’s as simple as searching for the text “reference_environment_direct_deployment” or “reference-environment-direct-deployment” in the code, and replacing that name with something more friendly?

reference_environment_direct_deployment:reference-environment-direct-deployment-v0 has two parts to it:

reference_environment_direct_deployment likely comes from https://github.com/rangl-labs/netzerotc/blob/32e321ab559158e63a59a61e49206b990976b4f3/environment/setup.py#L5
reference-environment-direct-deployment-v0 comes from https://github.com/rangl-labs/netzerotc/blob/32e321ab559158e63a59a61e49206b990976b4f3/environment/reference_environment_direct_deployment/init.py#L4

Have a think about what you want in terms of naming, examples could be:

rangl:nztc-v0
nztc:direct-deployment-v0
nztc:integrated-energy-vision-v0

reference_environment_direct_deployment:reference-environment-direct-deployment-v0 has two parts to it:

reference_environment_direct_deployment likely comes from https://github.com/rangl-labs/netzerotc/blob/32e321ab559158e63a59a61e49206b990976b4f3/environment/setup.py#L5
reference-environment-direct-deployment-v0 comes from https://github.com/rangl-labs/netzerotc/blob/32e321ab559158e63a59a61e49206b990976b4f3/environment/reference_environment_direct_deployment/init.py#L4

Have a think about what you want in terms of naming, examples could be:

rangl:nztc-v0
nztc:direct-deployment-v0
nztc:integrated-energy-vision-v0

Thanks a lot for these suggestions, and I had now changed the "reference-environment-direct-deployment-v0" to "rangl-nztc-v0" in https://github.com/rangl-labs/netzerotc/commit/1c2fc3535e76ca3352a3a0304be31854e222bfd2, so that the reference_environment_direct_deployment is untouched, otherwise the folder has to be renamed, and https://github.com/rangl-labs/netzerotc/blob/32e321ab559158e63a59a61e49206b990976b4f3/environment/setup.py#L5 and the entry_point="reference_environment_direct_deployment.env:GymEnv" in https://github.com/rangl-labs/netzerotc/blob/32e321ab559158e63a59a61e49206b990976b4f3/environment/reference_environment_direct_deployment/init.py#L4 will all have to be changed all together, and any person running it will have to re-register using pip install or so, which might make confusions.


Octicon blank on latest version

I upgraded from 0.8.2 -> 0.10.2, which involved upgrading react-native-vector-icons from 3.0 -> 4.0, which blanked all of my type="octicon". 😢
e.g.
<Icon type="octicon" name="flame" />

was previously working.
type="font-awesome", etc. still working.

Consider looking at issues on the react-native-vector-icons repo. We haven't changes the way RNE consumes vector-icons. So seems most likely a change on the vector-icons side. Let me know if you come across a solution for this.

@booboothefool try the solution in here if it helps,  https://github.com/react-native-community/react-native-elements/issues/183

@binoy14
Ah, I am on RN 0.37 trying to use react-native-vector-icons 4.0.0. Seems like I am stuck. No worries.

For these i am  getting an same warning ..
 "react-native-vector-icons": "^4.5.0"
i am trying to get tools icon name from these[https://oblador.github.io/react-native-vector-icons/]

@dineshmm23 Which warning are you talking about ?


High CPU usage in webUI

I've noticed that when I live the webUI open the CPU on my 2018 Macbook Pro goes crazy (upwards of 70% cpu usage or more).
I was peeking through the source code when I saw this:
https://github.com/treasure-data/digdag/blob/3cac10b2bacb8e47a424cd7bbd11b6a6d1d6f272/digdag-ui/console.jsx#L1555
Looking at the stackoverflow accepted answer it looks like skyline3000 updated their answer in 2017.  They say:

According to this question, some people have found better performance across all browsers, especially Chrome, with transform: rotateZ(360deg).

I was wondering if any testing has been done using that transformation?

Hello, @mjtice
Thank you for reporting the issue.
Could you tell me the following?
I can't reproduce your issue in my environment.

OS version:
Digdag version:
Browser version:
Java Version:
Reproduce steps:

My test environment.

OS version: 10.13.6
Digdag version: 0.9.30
Browser version: Safari 12(13606.2.11)
Java Version: 1.8.0_121
Test steps:

digdag server -m
access http://localhost:65432

It seems that the StackOverflow page is here
CSS keyframe animation CPU usage is high, should it be this way?

Close the old issue. Please reopen or file new one if you need.


adding skip match tag set subtests

Pull Request Test Coverage Report for Build<PHONE_NUMBER>0
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 55.5%

Totals

Change from base Build<PHONE_NUMBER>6:
0.0%

Covered Lines:
1983

Relevant Lines:
3573

💛  - Coveralls


update k9s to v0.24.10

Expected Behaviour

download and use k9s v0.24.10
Current Behaviour

v0.24.2 is used
Possible Solution

Just update the version string in pkg?

Feel free to go ahead.
@nitishkumar71 do you want to take it?

Sure

Interesting to see that the K9s download URL format changed. This means that arkade won't be able to download earlier releases.
cc @derailed

@a5r0n this change is now available in the master branch and will be released within a few days.
Please do consider becoming a GitHub Sponsor to support our work on arkade
This is for individual users and / or companies including custom amounts and one-time options.


Thanks command improvement

Improved thanks command implementation
- **Use `lodash` for better performance due to lazy evaluation**
- **Discard non-existing users and self while thanking and thank only existing ones**
 (which also fixes thanking `@/all` as a bonus)
 i.e. if a user doesn't exist in gitter, then there will be no API calls to thank that user.

Command
thanks @camperbot @/all @all @belindarogers

Bot Response
@abhisekp sends brownie points to @camperbot and @belindarogers :sparkles: :thumbsup: :sparkles:
:warning: could not find receiver for belindarogers
:star: 1560 | @camperbot | http://www.freecodecamp.com/camperbot

Improved bot response about giving brownie points

OLD
abhisekp sends brownie points to @rphares and @qmikew1 and @dwd2010 and @camperbot and @csegate2 :sparkles: :thumbsup: :sparkles:

NEW
@abhisekp sends brownie points to @GitterBotX, @camperbot, @ltegman, @SaintPeter and @noncentz :sparkles: :thumbsup: :sparkles:

> ----
Tested in  GitterBotX/playground :white_check_mark:

> **NOTE:** Added `dedent` module which removes unwanted indentations from template strings. Please use **`npm install`** to install the new package :package: .
Fixes https://github.com/FreeCodeCamp/camperbot/issues/76
Fixes https://github.com/dcsan/gitterbot/issues/170

Any progress?
As per :point_up: This Comment in HelpContributors

There is a new user with the name E-Tank - and just entering a reply or comment on one of their questions automatically gives them brownie points.

@SaintPeter that is addressed by @noncentz in https://github.com/FreeCodeCamp/camperbot/pull/78
Just need to remove the line linked above  :point_up: and that can be merged.

I'm really confused what is going on in this thread. @abhisekp Is this ready? I see you've written a bunch of critiques on your own PR so I'm not really sure what the status of this is.

@ltegman it is not ready yet.. I've to implement the suggestions. Bit busy these days... Will correct them ASAP and ping you. :+1:

 :no_good:  DO NOT MERGE :no_good:

@abhisekp I know you are busy, but this would be great to have this soon. ;)


DocumentSession is a Blob class

Not this minute, but pretty soon get into DocumentSession and start pulling stuff out to smaller, cohesive classes

Calling it good enough right now, but may still pull out the batch update later


Set items align is center

All items is align left. Please set option to center (gravity).

same the #19

working in progress...

Thank for hardworking, and I reopen this issuse until this resolve.

@2dxgujun is the alignment issue fixed, if so can you please share.. as i am using this

I have fixed this problem in my forked-project
Check it:
https://github.com/leonacky/AndroidTagGroup
I'm a newbie for github. So I dont know how to request merge to original project and build for gradle
If you need you can clone that project and import to your project


Debian 8 jessie

That should be good for the new debian 8 box

Sorry ! I wanted to work on the fork not the original repo.


Add a prototype implementation of recursive checkpointing

Example:
import jax
import jax.numpy as jnp
from jax.experimental.checkpoint import checkpoint_recursive

@checkpoint_recursive
def f(x):
  for i in range(8):
    x = jnp.exp(x)
  return x

print(jax.make_jaxpr(f)(jnp.ones((4,))))

produces the following jaxpr:

{ lambda  ; a.
  let b = remat_call[ call_jaxpr={ lambda  ; a.
                                   let b = remat_call[ call_jaxpr={ lambda  ; a.
                                                                    let b = remat_call[ call_jaxpr={ lambda  ; a.
                                                                                let b = exp a
                                                                                in (b,) }
                                                                                concrete=False
                                                                                name=<unnamed wrapped function> ] a
                                                                        c = exp b
                                                                    in (c,) }
                                                       concrete=False
                                                       name=<lambda> ] a
                                       c = remat_call[ call_jaxpr={ lambda  ; a.
                                                                    let b = exp a
                                                                    in (b,) }
                                                       concrete=False
                                                       name=<unnamed wrapped function> ] b
                                       d = exp c
                                   in (d,) }
                      concrete=False
                      name=<lambda> ] a
      c = remat_call[ call_jaxpr={ lambda  ; a.
                                   let b = remat_call[ call_jaxpr={ lambda  ; a.
                                                                    let b = exp a
                                                                    in (b,) }
                                                       concrete=False
                                                       name=<unnamed wrapped function> ] a
                                       c = exp b
                                   in (c,) }
                      concrete=False
                      name=<lambda> ] b
      d = remat_call[ call_jaxpr={ lambda  ; a.
                                   let b = exp a
                                   in (b,) }
                      concrete=False
                      name=<unnamed wrapped function> ] c
      e = exp d
  in (e,) }

TODO:

[ ] Tests
[ ] Better cost estimation (loops, calls, conditionals all can have an arbitrary number of primitives inside)
[ ] Loop splitting, when the half-point of operation count lies inside a loop

Nit: do you plan to actually implement binomial checkpointing, or just a form of recursive "multilevel checkpointing"? Binomial checkpointing is definitely more efficient given a fixed memory budget, but may not be worth the trouble...

Yeah @mattjj has pointed out yesterday that this is not really binomial checkpointing. I'll change the name today. I would be interested in implementing the binomial scheme as well, but honestly I can't find a single paper that has a reasonable description of how this is done. Everything I find either uses the revolve procedure as a black box, or only discusses the lower bounds... Do you have any good references?

@apaszke Would you benefit from having a python implementation of Revolve? @jhueckelheim and others have spent time on this before and would be interested in contributing.  There exists an implementation by Julien Hermann associated with https://arxiv.org/pdf/1911.13214v1.pdf that might be straightforward to adapt. Unfortunately, the software artifact does not seem available.

There exists an implementation by Julien Hermann associated with https://arxiv.org/pdf/1911.13214v1.pdf that might be straightforward to adapt

This is definitely a nice description of the binomial checkpointing algorithm, at the very least! Thanks for the pointer.
From an implementation perspective, it seems like the first step would be to write the general code that implements an arbitrary "checkpointing strategy" in JAX's autodiff. Then we could explore swapping in different strategies, e.g., binomial vs binary checkpointing.

@apaszke Would you benefit from having a python implementation of Revolve? @jhueckelheim and others have spent time on this before and would be interested in contributing. There exists an implementation by Julien Hermann associated with https://arxiv.org/pdf/1911.13214v1.pdf that might be straightforward to adapt. Unfortunately, the software artifact does not seem available.

I believe the implementation that @sriharikrishna was refering to is that one:
https://gitlab.inria.fr/adjoint-computation/disk-revolve-public
The details can be found in the attached paper: https://dl.acm.org/doi/10.1145/3378672

Great reference @sriharikrishna, thanks for posting that! That's a very understandable formulation and I think we could implement something like that relatively easily. I think that memory persistent schedules are also the one we could desugar into some nesting of remats, so that's a good property to have.
Agreed with @shoyer that it would be great to write a toolbox for that and I'm happy to drive that. The code that's in this PR is a starting point which allows you to suspend the program after a fixed set of iterations, following https://openreview.net/pdf?id=BkYYXJ9i-, and we already have the single-level checkpointing implemented as jax.checkpoint. What else do we need?
I guess one thing that would be nice to have is an interpreter for the imperative code generated by most checkpointing tools. But I wonder if it wouldn't be better to just reimplement them in less stateful way...
@Gaupy thanks for the links. Unfortunately we won't be able to integrate that directly into JAX, because it's GPL licensed 😕 Still, the interpreter I mentioned above might help with an integration outside of the core if you'd be interested in that.

Ok I understand. What kind of licence would you need? Changing the licence is certainly not a problem (we did not give too much thoughts about the licence and I don't expect Julien to care either about  moving to a LGPL type of licence).

I think that Apache 2.0 or BSD are generally acceptable, although I'd have to check. @shoyer might know more.
Still, it looks like those programs are generally designed to output a sequence of steps and I think that for JAX purposes it would be better to get some kind of a tree representation that shows how the individual checkpoints are performed, so we'll probably need to rewrite it quite a bit anyway.

Ok I understand. What kind of licence would you need? Changing the licence is certainly not a problem (we did not give too much thoughts about the licence and I don't expect Julien to care either about moving to a LGPL type of licence).

We could distribute Apache, BSD or MIT licensed code with JAX.
We could depend on LGPL licensed code. I'm not entirely sure about GPL, but we definitely can't use AGPL (the current license) in any form: https://opensource.google/docs/using/agpl-policy/
All that said, I guess the most valuable component of this code/paper for us would be just having a reference for understanding exactly how the "revolve" algorithm works. Eventually we probably want a version of that in JAX.

Not sure this is the best location to describe the algorithm, but to understand the code there are two ways:

the first (simplest way but more computational intensive) is to compute the full schedule ahead of time via a dynamic program. The main dynamic program is the following:
T(l,c) = min_j j  + T(l-j,c-1) + T(j-1,c)
Essentially it means that to reverse a graph with l time steps with c memory slots, you go forward j time steps, write a checkpoint, then reverse the end of the graph (l-j time steps but only c-1 checkpoints remaining). One you've reversed the end of the graph, you reverse the beginning of the graph (j-1 initial steps) [I'm not 100% sure about the indexes]. Then you take the j such that this time is minimized. This is what our library H-Revolve does and why it provides the full schedule, it also works with a storage hierarchy.
I made some slides to describe it for multiple levels of storage, but it's similar, see here: http://people.bordeaux.inria.fr/gaupy/ressources/pub/slides/adjoint_comp.pdf (slide 15).

the second (more complicated, but can be computed online) is the same, but you can actually guess what the "j" that minimizes the progdyn should be (derived by Griewank and Walther in their revolve paper):
it says that given l and c, any j in the domain [max(β(c, t − 1), l − β(c − 1, t + 1)+1),min(β(c, t), l − β(c − 1, t)+1)] is optimal, where where t is the unique integer satisfying β(c, t) ≤ l < β(c, t + 1), and where β(c, t)= (c+t) !/ (c! t!) (c chooses c+t).

Thanks @Gaupy! I think the "full schedule" version is exactly what we want for JAX.

Ok. In the mean time I think we'll change the licence of our code to MIT if you want to try using it while you reimplement it.
I don't think we chose AGPL on purpose: I was pretty sure we licenced it GPL... I'm definitely interested in any feedback on usability. Note that if you use the "Revolve" function, that gives you the optimal binomial strategy assuming write and reads are negligible in front of the forward step cost.
If it is not the case you can use Hrevolve that can take as input both these times (more info on the TOMS paper linked below).

Awesome, thanks so much @Gaupy

Are there any traps we should be aware of in using this implementation of recursive checkpointing? Looks really handy but I realize that there could be a good reason why it hasn't been merged in yet.
And as always, thanks so much for your efforts.

Are there any traps we should be aware of in using this implementation of recursive checkpointing? Looks really handy but I realize that there could be a good reason why it hasn't been merged in yet.
And as always, thanks so much for your efforts.


Support SOAP request cxf(3.x) webservice

Please answer these questions before submitting pull request

Why submit this pull request?

[ ] Bug fix

[x] New feature provided

[ ] Improve performance

Related issues

You need to submit test pull request, do you know where and how?

Coverage decreased (-0.002%) to 16.819% when pulling 69cab442cba59f56c52419d960497b06ee681392 on wzsky:master into 1530a663d2d5c2a7925930006a29e7c4c874f785 on apache:master.

Coverage decreased (-0.002%) to 16.819% when pulling 69cab442cba59f56c52419d960497b06ee681392 on wzsky:master into 1530a663d2d5c2a7925930006a29e7c4c874f785 on apache:master.

Be advised, RESTEasy plugin merged, conflict needs to be solved.

Be advised, RESTEasy plugin merged, conflict needs to be solved.

Why PR closed?

Why PR closed?

solving conflict

I have tagged this PR as TBD(To be decided), so until you submit the test, and report to us that, the test has passed in your local, we wouldn't review. So you don't need to close the PR to resolve the conflict.

We are still waiting for integration test case PR, and with no conflict. With time passing, the conflicts will keep coming, because there are 6-7 plugin PRs are going.

I'm so sorry that my own pc has been stolen. I can not work now.I will coding the test case next week.
---Original---
From: "吴晟 Wu<EMAIL_ADDRESS>Date: Fri, May 31, 2019 16:32 PM
To<EMAIL_ADDRESS>Cc: "State change"state_change<EMAIL_ADDRESS>Subject: Re: [apache/skywalking]  Support SOAP request cxf(3.x) webservice (#2749)
We are still waiting for integration test case PR, and with no conflict. With time passing, the conflicts will keep coming, because there are 6-7 plugin PRs are going.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or mute the thread.

@wz8188 Sorry to hear that. Be careful. Just don't want to you feel frustrating, as the conflicts happen many times.

FAILURE

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/skywalking-e2e/14/

I am closing this PR for now, as no update in 30 days. Please submit a new one when you are ready. @wz8188


unicode: IsLetter check char 231 have error

What version of Go are you using (go version)?

$ go version
1.20.3

Does this issue reproduce with the latest release?
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
windows 11 intel 64

char 231  is half chinese char, it is not a letter.

atleast should add IsEnLetter or IsUtf8Letter. this cause my program many error.

Whether a Unicode code point is a letter or not is defined by the Unicode standard.  I don't know precisely what you mean by character 231.  The code point with the value decimal 231 is ç, which is a letter.  Closing because I think the function is behaving as documented and intended.  Please comment if you disagree.
I don't know precisely what you mean by IsEnLetter or IsUtf8Letter.


Fixup docs for schemaless changesets

"However, changesets also run without a changeset" is a bit self-referential, so I've tried to distinguish between data in a struct and data in a map (which has no implied schema). Also, the "as a tuple instead of a struct" bit seems superfluous (it's like saying "pass a tuple as a tuple").

@jonleighton ohai!
Oops, the second "changeset" was meant to be a "schema". Your explanation looks great though!
:heart: :green_heart: :blue_heart: :yellow_heart: :purple_heart:

ohai!


Missing word-break inside file list columns

When I open the modal on my server, I see something like this:

This rendering issue could be mitigated by allowing word-breaks not only for the links inside the filename column but also inside other columns:
table.file-list-table td {
    word-break: break-word;
}

resulting in a better layout:

@nopeslide sounds like you already know the fix... why not put in a pull request?

I'll gladly accept a PR :) I have a bit too much work now since COVID to do this myself and I planned to redesign the UI as per:
https://github.com/Amonith/mattermost-file-list/issues/7

Hey,
PR merged. Included in latest release:
https://github.com/Amonith/mattermost-file-list/releases/tag/v0.9.0


Custom Set Take Profit and Stop Loss

Allow to the user to set the stop loss and take profit of the bot from the input parameters

Duplicate of #2


TriStatePin proposal

I have simply added the enum variant as per the proposal in #31, since it seemed to be the most popular.
I am in the middle of implementing a charlieplexing crate for use in a project of mine (custom board using an stm32l051) and would therefore need this trait.
To try it out I implemented the trait for the stm32l0xx-hal in a branch together with an example application, and got the charlieplexing working as a proof of concept on my custom board driving 30 leds.
The charlieplexing crate is far from done, but I think the trait is going to work great, so to get the wheels spinning and allow for more opinions, I thought I might as well open a pull request right away...

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @thejpster (or someone else) soon.
If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.
Please see the contribution instructions for more information.

This seems straightforward enough, but I wonder if it needs an RFC before we go to unproven implementation.
@jamesmunns can you stick this on the agenda for Tuesday?

Lol.  There is an RFC! You even linked to it...
Still, I'd like to discuss this on Tuesday as I'm not quite sure of the process for merging.

we've just landed IoPin #269 which lets one toggle between input and output pin type-states, do we still need a TriStatePin or is does #269 cover the use cases for this okay?
(i feel like the type-state approach is possibly less ergonomic than that proposed here, but it should be pretty easy to implement a more convenient wrapper over it with an API like this)

Hello- Maybe I'm missing something, but I think I've bumped into a usecase that requires this or something like it. Threw together a quick example:
enum Things {
    Thing1,
    Thing2,
    Thing3,
}

let there_is_no_tri = pins.gpio13.into_floating_input();

let thing_closure = |thing: Things| -> () {
    match thing {
        Things::Thing1 => { there_is_no_tri.into_floating_input(); () }
        Things::Thing2 => there_is_no_tri.into_push_pull_output().set_low().unwrap(),
        _ => unimplemented!(),
    };
};

thing_closure(Things::Thing1);
thing_closure(Things::Thing2);

This code produces an error:
error[E0382]: use of moved value: `thing_closure`
   --> src\main.rs:245:9
    |
244 |         thing_closure(Things::Thing1);
    |         ----------------------------- `thing_closure` moved due to this call
245 |         thing_closure(Things::Thing2);
    |         ^^^^^^^^^^^^^ value used here after move
    |
note: closure cannot be invoked more than once because it moves the variable `there_is_no_tri` out of its environment
   --> src\main.rs:236:21
    |
236 |                     there_is_no_tri.into_floating_input();
    |                     ^^^^^^^^^^^^^^^
note: this value implements `FnOnce`, which causes it to be moved when called
   --> src\main.rs:244:9
    |
244 |         thing_closure(Things::Thing1);
    |         ^^^^^^^^^^^^^

Since into_floating_input takes self rather than &self or &mut self, the closure moves the variable out of the environment and it isn't reentrant (god bless rustc for making that error so self-explanatory :D ).
Just as an example of something that DOES currently work:
let mut boring_pin = pins.gpio13.into_push_pull_output();

let mut thing_closure = |thing: Things| -> () {
    match thing {
        Things::Thing1 => boring_pin.set_high().unwrap(),
        Things::Thing2 => boring_pin.set_low().unwrap(),
        _ => unimplemented!(),
    };
};

thing_closure(Things::Thing1);
thing_closure(Things::Thing2);

With this change, I'm pretty sure I could do this, and it would work fine.
let mut tristate_pin = pins.gpio13.into_tristate_output();

let mut thing_closure = |thing: Things| -> () {
    match thing {
        Things::Thing1 => boring_pin.set( PinState::Floating ).unwrap(),
        Things::Thing2 => boring_pin.set( PinState::Low).unwrap(),
        _ => unimplemented!(),
    };
};

thing_closure(Things::Thing1);
thing_closure(Things::Thing2);

(sorry, that was a lot of code but I hope got the point across)

Hello- Maybe I'm missing something, but I think I've bumped into a usecase that requires this or something like it. Threw together a quick example:
enum Things {
    Thing1,
    Thing2,
    Thing3,
}

let there_is_no_tri = pins.gpio13.into_floating_input();

let thing_closure = |thing: Things| -> () {
    match thing {
        Things::Thing1 => { there_is_no_tri.into_floating_input(); () }
        Things::Thing2 => there_is_no_tri.into_push_pull_output().set_low().unwrap(),
        _ => unimplemented!(),
    };
};

thing_closure(Things::Thing1);
thing_closure(Things::Thing2);

This code produces an error:
error[E0382]: use of moved value: `thing_closure`
   --> src\main.rs:245:9
    |
244 |         thing_closure(Things::Thing1);
    |         ----------------------------- `thing_closure` moved due to this call
245 |         thing_closure(Things::Thing2);
    |         ^^^^^^^^^^^^^ value used here after move
    |
note: closure cannot be invoked more than once because it moves the variable `there_is_no_tri` out of its environment
   --> src\main.rs:236:21
    |
236 |                     there_is_no_tri.into_floating_input();
    |                     ^^^^^^^^^^^^^^^
note: this value implements `FnOnce`, which causes it to be moved when called
   --> src\main.rs:244:9
    |
244 |         thing_closure(Things::Thing1);
    |         ^^^^^^^^^^^^^

Since into_floating_input takes self rather than &self or &mut self, the closure moves the variable out of the environment and it isn't reentrant (god bless rustc for making that error so self-explanatory :D ).  IoPin has the same problem of taking self.
I imagine there are many other uses (drivers?) that also have problems with this approach.
Just as an example of something that DOES currently work:
let mut boring_pin = pins.gpio13.into_push_pull_output();

let mut thing_closure = |thing: Things| -> () {
    match thing {
        Things::Thing1 => boring_pin.set_high().unwrap(),
        Things::Thing2 => boring_pin.set_low().unwrap(),
        _ => unimplemented!(),
    };
};

thing_closure(Things::Thing1);
thing_closure(Things::Thing2);

With this change, I'm pretty sure I could do this, and it would work fine.
let mut tristate_pin = pins.gpio13.into_tristate_output();

let mut thing_closure = |thing: Things| -> () {
    match thing {
        Things::Thing1 => boring_pin.set( PinState::Floating ).unwrap(),
        Things::Thing2 => boring_pin.set( PinState::Low).unwrap(),
        _ => unimplemented!(),
    };
};

thing_closure(Things::Thing1);
thing_closure(Things::Thing2);

One thing to note is that PinState already exists now because of IoPin, so you'd have to use some other enum (and perhaps have set_low(), set_high(), set_floating() as well).
(sorry, that was a lot of code but I hope it got the point across)


Dropdowns render with a border radius on Safari/vscode.dev

Dropdowns in Safari seem to be picking up some browser styles and render dropdowns with a 5px border radius:
Safari

Edge

This is no longer the case given the move to use border radius across inputs.


Implement AWS_IAM Authorizers

Based on the RFC #781, we need to implement the AWS_IAM Authorizers feature.
Requirements:

Implement Transform
Add tests
Add example(s)

Some code areas to get started for any interested contributors:

Add InvokeRole as a valid property of Auth https://github.com/awslabs/serverless-application-model/blob/master/samtranslator/model/api/api_generator.py#L20
Add an exception for AWS_IAM DefaultAuthorizer here https://github.com/awslabs/serverless-application-model/blob/master/samtranslator/model/api/api_generator.py#L321
Ensure this section is working and only a single sigv4 security definition gets added https://github.com/awslabs/serverless-application-model/blob/master/samtranslator/swagger/swagger.py#L343
Add 'sigv4' to securityDefinitions if it's defined as DefaultAuthorizer or if it is specified on any of the Methods https://github.com/awslabs/serverless-application-model/blob/master/samtranslator/swagger/swagger.py#L289
Update Integration with credentials https://github.com/awslabs/serverless-application-model/blob/master/samtranslator/swagger/swagger.py#L101

Is the idea that it would look something like:
Auth:
  DefaultAuthorizer: MyCognitoAuth # OPTIONAL
  Authorizers:
    AWS_IAM: some:arn:aws:1

and the serverless macro would transform that into specifying AWS_IAM for the auth type and add the policy to the resource policy on the API?

or possibly
Auth:
  Authorizers:
    AWS_IAM: NOT_AN_ARN

And the macro would create an IAM Role and substitute that role where applicable in the previous comment?

@rhboyd check out the RFC #781

Hey @brettstack, I would like to start working on this since this feature is needed for my job.
No problem?

Absolutely! We look forward to a PR. ❤

Hey @brettstack, My PR #827 is just ready for review!
Please go ahead 👍 😄 Thanks!

Thanks @horike37! This has been merged to develop and we'll get it out to production asap.

Great! Can't wait to release 😄

Released with SAM v1.11.0!


generated code changes the order of properties in struct

Define in swagger yaml:
Product:
    type: "object"
    properties:
      product_id:
        type: "string"
      name:
        type: "string"

Generated by "swagger generate server":
type Product struct {
	Name string `json:"name,omitempty"`
	ProductID string `json:"product_id,omitempty"`
}

I want product_id be the first property of Product struct.
Is there any way to keep the order of properties?

try x-order: n   extension

Thanks, it works.


Fully remove Galley component

Fixes https://github.com/istio/istio/issues/20299

@howardjohn: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
9cdf69c507b13922eb69096d2d98d8699fca9f16
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
9cdf69c507b13922eb69096d2d98d8699fca9f16
link
/test lint_istio

gencheck_istio
9cdf69c507b13922eb69096d2d98d8699fca9f16
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Implemented copy code button feature

Implemented support for copy code button in code blocks (#1262), also updated blog post about code to reflect it.
Here's how it looks like in light mode:

And in dark mode:

It does only appears when displaying code blocks using the markdown syntax, like:
```c++
code code code
```

Just now realized that my vscode formatted the css file differently. If you want to, I can undo the formatting.

Made requested changes.
Now I realized that there is an extra space after code when using line numbers (don't know why this happens, but it always did).


Create Change Password view

[x] Create change password method on User class
[x] Create update password function
[x] Create update password view
[x] Update User role to include the function
[ ] Write unit tests

@Zuiluj please create unit tests for this issue

Up for review in /pfunk/tests/test_web_change_password.py in branch feature/api_tests


[fix][broker] Fix non-persistent topic unsubscribe NPE.

Motivation
If unsubscribe non-persistent topic then deletes the subscription, it will throw NPE.
Documentation

[x] no-need-doc

#14363

Sure.


Lifting issue: int 0x29 in Windows. (fastfail)

int 0x29 isn't lifted as fastfail in Windows applications.
0x18000441d in the attached DLL has such an instruction.
https://msdn.microsoft.com/en-us/library/dn774154.aspx
pyvex.zip

Fixed in build 1.1.1065-dev.