[FLINK-2627][utils]Make Scala Data Set utils easier to access

Introduces a package object for Scala data set utils to simplify usage.
New usage: import org.apache.flink.api.scala.utils._

I am unable to get rid of the implicit type information for the zip functions, presumably because the type information for (Long,T) isn't found.

Have you tried constructing the type information explicitly createTypeInformation[(Long, T)]?

I get the following error on using that:
macro implementation not found: createTypeInformation (the most common reason is that you cannot use macro implementations in the same compilation run that defines them)
The correct place to use that would be just before the wrap call though, right?

I think for this, the type information should be passed from the call site, you should not need to create it explicitly.

Ah, sorry, my bad, you should take the TypeInformation fro T from the call site.
You may need to manually create the type info for the tuple, from the T type info, by creating a case class type info for Tuple2 with Long and T.

To be precise, directly before the map call. And you have to make declare the value as an implicit value. Otherwise, the map call won't find it.

I think the way to go is not to put the type info into the class, but into the methods, and create it as follows:
def zipWithIndex[T : TypeInformation : ClassTag](): DataSet[(Long, T)] = {
  val tInfo = implicitly[TypeInformation[T]]

  implicit val tupleTypeInformation = new CaseClassTypeInfo[(Long, T)](
      classOf[(Long, T)],
      Array(BasicTypeInfo.LONG_TYPE_INFO, tInfo),
      Seq(BasicTypeInfo.LONG_TYPE_INFO, tInfo),
      Array("_1", "_2"))

  wrap(jutils.zipWithIndex(self.javaSet)).map { t => (t.f0.toLong, t.f1) }

All the methods in the utils class should have parenthesis, they are not a side effect free getters after all.
Also, some tooling around creating Scala Tuple type information would be nice. I can see that there are more places where one would do that.

@StephanEwen , I have created a separate function to create type information for 2-tuple.
One question though. Why is there a need to generate type information explicitly here? The TypeInformationGen class does have a case analysis for Product types. I may be very wrong, but createTypeInformation macro cannot be used anywhere inside the module itself but only after the module's been compiled. This is perhaps why createTypeInformation works in, say, flink-ml.

The type information generation works as a macro on the abstract syntax tree, that's why it cannot work on its own code (or any code in the same project, which is the same compilation unit).

I think this looks good.
I personally like explicit arguments, even if it means sometimes explicitly summoning an implicit bound. It just makes it clearer where the type infos flow, which is not that easy to figure out ;-)
This is subject to debate, though. @tillrohrmann and @aljoscha may be of different opinion here...

I think I agree with that. I wasn't too happy about using implicit arguments here; we're constructing the type information explicitly anyway.
Will push a commit in a while to change this.

I took a stab at removing the implicit parameters here: https://github.com/aljoscha/flink/commit/e197ea4aba4005400bc80a5693f17ec2617bfae5
The tests are still running on Travis but I think it should work.

Ah. Thank you @aljoscha. Travis should pass. I've already pushed a fix.

Travis passes successfully. I've squashed the commits.
This should be mergeable now.

@StephanEwen , can you look this over again?

Hey @StephanEwen, apologies for being too eager but is it possible to get this in soon?

Unrelated failures. Already filed jiras for those. 2700 and 2612.

Looks good to me.
+1 to merge

LGTM.
+1 for merging :-)

Will address Till's comment and merge this...

I've already removed the line break. :)

Changes Unknown when pulling 784cbc1a7901c65719f92919a2f584b5636105bf on sachingoel0101:scala_utils_fix into ** on apache:master**.


Fix outdated links in Configuration meta

Description of your changes

Update crossplane.yaml with the current state of README

I have:

[x] Read and followed Upbound's contribution process.
[ ] Run make reviewable to ensure this PR is ready for review.
[ ] Added backport release-x.y labels to auto-backport this PR, as appropriate.

How has this code been tested
I proof read it.
I will also run uptest below to validate that Configuration can be built without any issues and validate that uptest pipelines are operable after the most recent changes

/test-examples

/test-examples


Add the ability to pin Issues

This adds the ability to pin important Issues and Pull Requests. You can also move pinned Issues around to change their Position. Resolves #2175.
Screenshots

The Design was mostly copied from the Projects Board.
Implementation
This uses a new pin_order Column in the issue table.  If the value is set to 0, the Issue is not pinned. If it's set to a bigger value, the value is the Position. 1 means it's the first pinned Issue, 2 means it's the second one etc. This is dived into Issues and Pull requests for each Repo.
TODO

[x] You can currently pin as many Issues as you want. Maybe we should add a Limit, which is configurable. GitHub uses 3, but I prefer 6, as this is better for bigger Projects, but I'm open for suggestions.
[x] Pin and Unpin events need to be added to the Issue history.
[x] Tests
[x] Migration

The feature itself is currently fully working, so tester who may find weird edge cases are very welcome!

Border is too thick, please use 1px border.

GitHub uses 3, but I prefer 6, as this is better for bigger Projects, but I'm open for suggestions.

I'd say 3 is fine as two rows of pins may be obnoxious.
Is a "X" icon implemented in the boxes where users with sufficient permission can un-pin?

Border is too thick, please use 1px border.

Done

I'd say 3 is fine as two rows of pins may be obnoxious.

I still think 6 would be better for bigger projects, but let's see what the other says

Is a "X" icon implemented in the boxes where users with sufficient permission can un-pin?

This is now added. I have also found a Bug in Tippy: If a Element with a Tooltip is removed, while the Tooltip is shown, the Tooltip is still shown.

This is now added. I have also found a Bug in Tippy: If a Element with a Tooltip is removed, while the Tooltip is shown, the Tooltip is still shown.

I think it's a case we hadn't seen yet. You can probably just el._tippy.destroy() before el.remove().

Are you on Windows? I think we have another newline issue in generated file.

Are you on Windows?

 I don't even know which script touches this file at all. Maybe you should just ignore if there is a final newline, if that makes problem. A final newline is not very important on such a large autogenrated file.

You can probably just el._tippy.destroy() before el.remove().

This looks like a private function. Should this really be used?

You can probably just el._tippy.destroy() before el.remove().

This looks like a private function. Should this really be used?

If you can obtain the reference to the tippy instance through other means, go for it. _tippy is only for cases where it's not possible to get the instance otherwise.

Are you on Windows?

 I don't even know which script touches this file at all. Maybe you should just ignore if there is a final newline, if that makes problem. A final newline is not very important on such a large autogenrated file.

So at least that confirms it's a Windows issue. File is generated during make tidy. We can add normalization for it, but it appears that normalization hadn't worked before in the swagger case via sed, so I guess we can do it in the golang script for this case.

https://github.com/go-gitea/gitea/pull/24407 should fix the newline issue.

What I've noticed already:
Yes, it's one possible approach to store the pin order directly inside the issues.
However, this approach also makes problems:

PRs also need that attribute as you can see at the moment. But what is a pinned PR?
This is often unneeded as it's pretty rare that you need to display the pinned issues (basically only on the "view issues" page)
What's the behavior for when the issue isn't pinned? PinnedOrder = 0?
You will only ever be able to pin your own issues and foreign issues from other repos will never be possible (not sure if this is actually useful or not)

All of these problems can be solved by using the following approach:
Instead of storing for each issue the ranking it is pinned in, let's store an external
type PinnedIssue {
  repoID int64 UNIQUE(issue_repo) // the repo pinning this issue, not necessarily the one owning it. Additionally, we can even think about whether this is the primary key for this struct, as every repo should likely only have one set of pinned issues…
  issueID int64 UNIQUE(issue_repo)
  order int64 // or a smaller type, it's not going to be bigger than 1000…
  createdUnix timestamp
}

Then you can query the pinned issues of a repository with the query
e.Where(PinnedIssue{repoID: repoID}).Asc("order, createdUnix").Find(<result list>)

Which should suffice for all cases where you actually want to separate the pinned issues.
Perhaps you'll need the second query
e.Get(PinnedIssue{repoID: <repoID>, issueID: <issueID>}).Exists()

to find out if a repo pins a single issue (It looked like you wanted to display a special icon on the issue view/edit page depending on if it is pinned or not when I skimmed through the PR changes).
What do you think?
(Every code I wrote here should be treated as pseudo-working-code. It may work, but it probably needs some adjustments.)

PRs also need that attribute as you can see at the moment. But what is a pinned PR?

This is often unneeded as it's pretty rare that you need to display the pinned issues (basically only on the "view issues" page)

Sure, you only need this foe the View Issues page and the Sidebar for a single Issue, but why is that a Problem?

What's the behavior for when the issue isn't pinned? PinnedOrder = 0?

Then it's simply not pinned. I'm not sure what you mean.

You will only ever be able to pin your own issues and foreign issues from other repos will never be possible (not sure if this is actually useful or not)

This is part of the Design. I think it should not be possible to pin Issues from other Repos. This would only be bring a benefit in a handful of situations, but it will make the Implementation more complex. It also confuses Users who see Issues from another Repo on the Issue page of a Repo.

I had now added a configurable limit for the pinned Issues

I have now added to pin and unpin Events to the History. this was way easier and faster than I thought. This PR is now feature complete. The only remaining things are the Tests and the Migration.

I have now added tests and the migration. This PR is now ready to review!

some CSS nits, eg: "float right" seems not good, "pinned-issue-card" max-width is complex?

I'm not very good at CSS. What's the Problem here with float: right?

use await for fetch instead of "then" ?

Done

not sure about whether some CSS classes are stable enough (card/meta/extra/right floated)

So I should copy them as a new Class?

I'm not very good at CSS. What's the Problem here with float: right?

Float is meant for "floating" a elements besides a text, not for general UI layout like we do in some places. For a horizontal flexbox pin box header, e.g. title and "x" icon, you can do something like:

{{title}}

{{svg}}

I have now updated the Layout with the Code from silverwind

Issue sidebar button margins fixed:

Doing some more style fixes...

Pushed some style fixes, looks much better now and uses CSS grid:

@silverwind Thanks for helping with the frontend stuff! I really appreciate that!
When #24669 is merged, I can also use the new Unpin Icon in this PR

@silverwind Thanks for helping with the frontend stuff! I really appreciate that!
When #24669 is merged, I can also use the new Unpin Icon in this PR

Merged.

I updated the PR so it now uses the new Icon

@JakobDev can you fix the issue title rendering in pinned issues like done here so that content inside backticks renders as code block:

Also, one merge conflict in options/locale/locale_en-US.ini appeared.

unpin has no response and it returned 500 in fact.
``
2023/05/13 14:31:43 ...s/process/manager.go:207:remove() [T] [645f2ecf] Done 645f2ecf: DELETE: /actions/release-action/issues/unpin/203018
2023/05/13 14:31:43 [645f2ecf] router: completed DELETE /actions/release-action/issues/unpin/203018 for <IP_ADDRESS>:49514, 500 Internal Server Error in 115.2ms @ repo/issue_pin.go:35(repo.IssueUnpin)

@JakobDev can you fix the issue title rendering in pinned issues like done here so that content inside backticks renders as code block:

Done

Also, one merge conflict in options/locale/locale_en-US.ini appeared.

Done

unpin has no response

This is expected. This is only called by a JS Function and not visited by the User directly.

and it returned 500 in fact.

I can't reproduce this on my Dev System. Can you find out what exactly causes this error, so I can fix it?
I had also added, that when MAX_PINNED is set to 0 in the Config, the button to Pin or Unpin a Issue is not shown.

I'm still more in favour of 6 as default, as I think it's better for larger Projects. It also brings Room for different kind of Issues e.g. first Row are current discussions, second row are currently critical Bug reports. To solve this discussion, I think it's the best to make a little vote, to see what more people like.
To vote, add a reaction to this comment:
Heart: 3 as default value
Rocket: 6 as default value
I will use the one that has more votes as default value.

Does anybody knew why _, err = db.GetEngine(dbctx).Table("issue"). raises a ineffectual assignment to err (ineffassign) error?

What that says is you assign err without using it.

I'm still more in favour of 6 as default,
So since the MAX_PIN is in app.ini, what is to stop me putting 999999 in that field ?
Is there a hard-coded max ?

What that says is you assign err without using it.

Thanks.
Maybe it would be better if we call this "err is assigned but not used" or something else to make this clear.

So since the MAX_PIN is in app.ini, what is to stop me putting 999999 in that field ?
Is there a hard-coded max ?

Nothing, but you need to be the Server Admin to do this. There are Users who use a hosted Gitea (e..g. I use Codeberg for my Projects), what means they can't change this themself, so I think we should use a good default value here that is capable for most Users. There is also nothing that forces you to use the max Number of Pinned Issues. If you like 3 more than 6, you still can only Pin 3 Issues while 6 is allowed.
And I also think this will not be changed by most Admins. They will most likely just use the default value and didn't take a look, if this can be configured.

Most people has voted for 3, so I changed it now to 3. I also added Documentation in docs/content/doc/administration/config-cheat-sheet.en-us.md.
Does it make sense to run UPDATE issue SET pin_order = 0 WHERE pin_order > MAX_PINNED on every startup to make sure, that not more Issues are pinned than allowed after a configuration change or can we ignore this?

I agree with @wxiaoguang, though perhaps a doctor command could be introduced for it, or a task on the admin page.
It may be nice for admins to be able to do it without sticking fingers in the DB, but I don't think it requires a startup query.

I think adding a new Button or a new doctor command just for the rare case somebody changed a specific value in the config is a little bit overkill, so I keep things as they are

Test failure is related:
    api_issue_pin_test.go:170:
        	Error Trace:	/home/runner/work/gitea/gitea/tests/integration/api_issue_pin_test.go:170
        	Error:      	Not equal:
        	            	expected: 1
        	            	actual  : 0
        	Test:       	TestAPIListPinnedIssues
panic: runtime error: index out of range [0] with length 0 [recovered]
	panic: runtime error: index out of range [0] with length 0

Once fixed, I think we can merge.

Is the test failure maybe just a Bug in the test suite? It only fails for Postgres, but not for the other Databases. And I only use basic SQL, so the Database should not be a Problem.

The tests were successful this time, so this was a Bug

This looks more like a Bug in the test suite. Correct me if I'm wrong, but I think the tests of a test suite should be always reproduceable (things like calling a external API are exceptions, but this does not happen here). The tests are executed in a clean Environment, so they should always behave the same. To be clear, I'm not saying that it is impossible that this Code does have a Bug that is only triggered under weird reproduceable, but I'm saying that the Tests should not fail one time and run sucessfully the second time without changing any Code.
Anyway, I'm updating the Branch to retrigger the Tests to see if it will run.

We now have this same issueicon.tmpl on the main branch which should be compatible with the usage here, so the file can be removed here.

Wait a moment

Okay, tell me when it's ready.

It is now ready. I have found a outdated TODO comment that I had removed now to not confuse others.

Noticed one bug: I can not unpin issues from the issue page because the ID value is incorrect, so it sends a DELETE request, gets 204, the issue is deleted in UI, but comes back on next page reload.
@JakobDev maybe you can followup with a fix PR that adresses above comments too.

Noticed one bug: I can not unpin issues from the issues list page because the ID value is incorrect, so it sends a DELETE request, gets 204, the box is removed in UI, but comes back on next page reload. Unpin from single issue page works fine.
@JakobDev maybe you can followup with a fix PR that adresses above comments too.

I think I have reported that I cannot remove the pinned issue?

Noticed one bug: I can not unpin issues from the issues list page because the ID value is incorrect, so it sends aDELETErequest, gets 204, the box is removed in UI, but comes back on next page reload. Unpin from single issue page works fine.

I'm sorry, but I can reproduce this on a brand new setup on Firefox and Chrome. I can unpin Issues using the X without problems. Can you maybe investigate what causes the wrong ID in your case?

maybe you can followup with a fix PR that adresses above comments too.

I can do that, but I need a Way to reproduce the Bug.

I think I have reported that I cannot remove the pinned issue?

I know, this was 2 weeks ago. I wrote that I can't reproduce this and was asking for more Details to reproduce. Because I got no Response, I though this was maybe caused by a Database corruption or something else and the Problem was gone.

I'm sorry, but I can reproduce this on a brand new setup on Firefox and Chrome. I can unpin Issues using the X without problems. Can you maybe investigate what causes the wrong ID in your case?

Just to confirm, this ID is meant to be the same as the issue ID seen in the URL, right?

Thanks to your question I was able to found the Problem: The ID is the ID of the Issue, but I'm accidental using issues_model.GetIssueByIndex to get the Issue. As I tested this mostly in the First Repo that I have created with the same Issues, the ID was the same as the Index, so I didn't noticed it.


pandas logo has a latex typo

Someone pointed this out on twitter (sorry, forgot who), but it you should be y_{it} =  not y_it as it looks like it might be now. The t should also be subscript.

cc @mdboom

I just put up a gist with the matplotlib script I used to create the (new) logo, with the corrected LaTeX expression:
https://gist.github.com/mdboom/06578d2edbb21807d0e216c8553bdf82
If you have a good suggestion about where in the pandas tree this should live permanently, I can make a PR with this stuff.

thanks @mdboom why don't you do a PR with this in pandas/doc/logo (new dir). If you can put the generated logo there as well. thanks.

Sure: see #12919.


Add conditional to get the invoice number if it exists or get the pre…

…view invoice otherwise

@bhelx Any idea what's going on with the build?

@MuffinMan10110 Travis had a networking hiccup I think. Reran the build

Alright, looks good. Will publish 1.3.1 today after I get one more thing in. You should see the bump referenced in the timeline here.

Thanks again @joelscrypt !


Added Value.getOrNull()

Fixes #1802

Current coverage is 97.08% (diff: 100%)

Merging #1806 into master will increase coverage by <.01%

@@             master      #1806   diff @@
==========================================
  Files            87         87
  Lines         11251      11252     +1
  Methods           0          0
  Messages          0          0
  Branches       1868       1869     +1
==========================================
+ Hits          10923      10924     +1
  Misses          205        205
  Partials        123        123

Powered by Codecov. Last update 275bed0...c77bf3a


/mark unhandled error: "TypeError: Cannot read property 'id' of undefined"

Describe the bug
Seeing this for markExperimentPoint sometimes in QA/Prod logs:
"TypeError: Cannot read property 'id' of undefined"

To Reproduce
I'm not sure, it's easy to see exactly where and why the error happens codewise, but I'm not sure how to reproduce or what it means if this is unexpectedly undefined.
if (experimentDecisionPoint.length) {
        let selectedExperimentDP = experimentDecisionPoint.filter( dp => dp.experiment.id === experimentId);
        const decisionPointId = selectedExperimentDP[0].id; //<---- oops, selectedExperimentDP can be undefined

Expected behavior
Handle the error w/o 500 internal error throw
Screenshots

I was able to reproduce this. This would be when marking without sending the experimentId, as is how it is currently used by Mathia.
A user who is technically eligible for at least 1 experiment loaded into upgrade in that environment that marks a valid decision point in an experiment that they are excluded from will get the above error.
The experiment they are eligible for can be in "Enrolling" or "Enrollment Complete" state.
The experiment they are excluded from can be in any state, even in "Inactive".
This allows them to follow a specific path through the code where they will hit this line of code:

      if (!experimentId) {
        if (filteredExperiments.length > 1) {
          const random = seedrandom(userId)();
          experimentId = filteredExperiments[Math.floor(random * experiments.length)].id;
        } else {
          experimentId = filteredExperiments[0] ? filteredExperiments[0].id : ''; // <--- filteredExperiments can be empty
        }
      }

Which then fails on this line, because it can't find any experiment id that equals empty string. (Sidebar, how come typescript allows this?? The types are defined for these arrays just fine...)
if (experimentDecisionPoint.length) {
        let selectedExperimentDP = experimentDecisionPoint.filter( dp => dp.experiment.id === experimentId);
        const decisionPointId = selectedExperimentDP[0].id; // <---- undefined, throws 500 error

in local, you can try this:

Create an experiment with include ALL and a single decision point (Experiment A)
Create another experiment with a different decision point, Include ALL except a user with id "Test" (Experiment B)
Start Experiment A enrolling.
Initialize "Test" user.
/mark user at the valid decision point in experiment B
You should see this error.

If you delete Experiment A, the error will not happen.

@ppratikcr7 is this something you can look into as a priority? It may be a simple fix, but it feels like it should get a deeper look to make sure things are getting handled correctly. We may need to have this patched into the current release.

@danoswaltCL Yes, looking into this.

Seeing this in production again, both /mark and v1/mark apis are failing (rarely, but still failing) with Cannot read property 'id' of undefined. Haven't tried to reproduce locally yet, but wanted to call it out asap


Scottwhi capi creds

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

BingAds/shopping-content/catalogs-resource.md
:white_check_mark:Succeeded

BingAds/shopping-content/get-started.md
:white_check_mark:Succeeded

BingAds/shopping-content/how-get-status-product-offers.md
:white_check_mark:Succeeded

BingAds/shopping-content/index.md
:white_check_mark:Succeeded

BingAds/shopping-content/manage-catalogs.md
:white_check_mark:Succeeded

BingAds/shopping-content/manage-products.md
:white_check_mark:Succeeded

BingAds/shopping-content/products-resource.md
:white_check_mark:Succeeded

BingAds/shopping-content/release-notes.md
:white_check_mark:Succeeded

BingAds/shopping-content/status-resource.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Multimap tries to keep the List/Set on the same node, but ignores Key Hash Tags in the given Key

As I described in the title, I am trying to utilize Key Hash Tags to accumulate data on the same ClusterNode.
I am using a Multimap and noticed the Key for the Lists/Sets are wrapped in the Key Hash Tags and so they may be placed on another Node.
For example:
The MultiMap key is "{multi.map}.some.key".
An entry in it would be saved in the List/Set "{{multi.map}.some.key}:ADJ...".
So the Hash is not "multi.map" but rather "{multi.map".
For further information see the "Key Hash Tag" section on https://redis.io/topics/cluster-spec

It's a bug! Thanks for report!

Done

Thanks a lot :)


Fix assembly_shipment_serializer_spec to match changes made in model

Commit 5c6eb7cc99 changed the Spree::Wombat::AssemblyShipmentSerializer model such that now the model is created only if ShipmentSerializer is defined. This caused assembly_shipment_serializer_spec.rb to abort with a load error because the AssemblyShipmentSerializer model name was not defined. The revised spec makes the same is defined?(ShipmentSerializer) check as the model so the spec does not abort.

Sorry, wrong repo! Will put pull request against spree-contrib/spree-product-assembly

I screwed up again. Closing again ...


Mark XFAIL for SciPy 1.8 release candidate

Rel #6323.
Mark tests as XFAIL, which fail with, at least, SciPy 1.8 rc because of its bug.

/test head

/test mini

/test head

/test head

Some combinations XPASS.

I fixed to use imperative pytest.xfail to make selective XFAIL seeing parametrized combinations. Note that imperative pytest.xfail simply skips actual testing codes and does not try to check them xpass, in contrast to pytest.mark.xfail, so we need to do like python -m pytest --runxfail to check if some xfail-marked tests could xpass.

/test head


dia: fix on darwin

Fixes runtime error:
GTK+ 2.x symbols detected. Using GTK+ 2.x and GTK+ 3 in the same process is not supported
Motivation for this change
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Fits CONTRIBUTING.md.

Success on aarch64-linux (full log)
Attempted: dia
Partial log (click to expand)
these paths will be fetched (3.39 MiB download, 19.86 MiB unpacked):
  /nix/store/5gan76hzgrgkvvdyg5hj0653f5lz79wi-libxslt-1.1.32
  /nix/store/x2j5rpjgpxisx8vkakaphk1ljyg7hkff-dia-<IP_ADDRESS>70622
copying path '/nix/store/5gan76hzgrgkvvdyg5hj0653f5lz79wi-libxslt-1.1.32' from 'https://cache.nixos.org'...
copying path '/nix/store/x2j5rpjgpxisx8vkakaphk1ljyg7hkff-dia-<IP_ADDRESS>70622' from 'https://cache.nixos.org'...
/nix/store/x2j5rpjgpxisx8vkakaphk1ljyg7hkff-dia-<IP_ADDRESS>70622

Success on x86_64-linux (full log)
Attempted: dia
Partial log (click to expand)
these paths will be fetched (3.44 MiB download, 19.83 MiB unpacked):
  /nix/store/x7pvmj45wg4yqqg0i3fk416bfrkwnlvs-dia-<IP_ADDRESS>70622
copying path '/nix/store/x7pvmj45wg4yqqg0i3fk416bfrkwnlvs-dia-<IP_ADDRESS>70622' from 'https://cache.nixos.org'...
/nix/store/x7pvmj45wg4yqqg0i3fk416bfrkwnlvs-dia-<IP_ADDRESS>70622

Success on x86_64-darwin (full log)
Attempted: dia
Partial log (click to expand)
/nix/store/nc5hqc30x455fdmjwf8pp44j6v407d6c-dia-<IP_ADDRESS>70622/lib/dia/libdia.dylib: fixing dylib
/nix/store/nc5hqc30x455fdmjwf8pp44j6v407d6c-dia-<IP_ADDRESS>70622/lib/dia/libdia.dylib: fixing dylib
/nix/store/nc5hqc30x455fdmjwf8pp44j6v407d6c-dia-<IP_ADDRESS>70622/lib/dia/libdia.dylib: fixing dylib
/nix/store/nc5hqc30x455fdmjwf8pp44j6v407d6c-dia-<IP_ADDRESS>70622/lib/dia/libdia.dylib: fixing dylib
/nix/store/nc5hqc30x455fdmjwf8pp44j6v407d6c-dia-<IP_ADDRESS>70622/lib/dia/libdia.dylib: fixing dylib
/nix/store/nc5hqc30x455fdmjwf8pp44j6v407d6c-dia-<IP_ADDRESS>70622/lib/dia/libdia.dylib: fixing dylib
/nix/store/nc5hqc30x455fdmjwf8pp44j6v407d6c-dia-<IP_ADDRESS>70622/lib/dia/libdia.dylib: fixing dylib
/nix/store/nc5hqc30x455fdmjwf8pp44j6v407d6c-dia-<IP_ADDRESS>70622/lib/dia/libdia.dylib: fixing dylib
/nix/store/nc5hqc30x455fdmjwf8pp44j6v407d6c-dia-<IP_ADDRESS>70622/lib/dia/libdia.dylib: fixing dylib
/nix/store/nc5hqc30x455fdmjwf8pp44j6v407d6c-dia-<IP_ADDRESS>70622

backported to 18.09: abd6a5bff3e


Space- Yieni

React Tic Tac Toe
Congratulations!  Please reflect on the assignment with these questions.
Reflection

Prompt
Response

How are events / event handlers and useState connected?
Event handlers and useState are connected via callback functions. The callback function use the hooks that are set using UseStates toggle between states when an event happens.

What are two ways to do "dynamic styling" with React? When should they be used?
The two ways to do "dynamic styling" in react are through inline css and using style sheets. In line css is useful for  directly styling JSX, whereas stylesheets are useful for styling the classes added to the JSX.

Much like Rails works with the HTTP request->response cycle, React works with the browser's input->output cycle. Describe React's cycle from receiving user input to outputting different page content.
Reacts cycle is triggered by an event. An event can be whatever the event listener is set to. Whether it be a click, hover, etc. When the event happens it then triggers react to run code, generally a call back function, that will adjust the state.

CS Fundamentals Questions

Question
Answer

What do you think is the BigO complexity of the method you use to compute a winner?
The time complexity of my compute winner method is O(n) where n is the size of the flattened square array ( which is just he number or squares on the board). The space complexity is also O(n) Because I am creating two arrays, newSquare and flatSquare.

Consider what happens when React processes a state change from setState -- it must re-render all of the components that now have different content because of that change.What kind of data structure are the components in, and what sort of algorithms would be appropriate for React's code to "traverse" those components?Speculate wildly about what the Big-O time complexity of that code might be.
The components are in a tree. You can use recursion to traverse it.

React Tic Tac Toe

Major Learning Goals/Code Review

Criteria
yes/no, and optionally any details/lines of code to reference

Demonstrates proper JavaScript coding style.
✔

Correctly passes props to child components.
✔

Correctly passes callback functions to child components and calls them to respond to user events.)
✔

Maintains the status of the game in state.
✔

Practices git with at least 6 small commits and meaningful commit messages
✔, yes, but I strongly suggest you don't use waves as commit messages and instead just describe the functionality added.

Uses existing stylesheets to render components
✔

Functional Requirements

Functional Requirement
yes/no

The Square component renders properly and executes the callback on a click event.
✔

The Board component renders a collection of squares
✔

The App component renders a board and uses state to maintain the status of the game.
✔

Utilizes callbacks to UI events to update state
✔

Overall Feedback

Overall Feedback
Criteria
yes/no

Green (Meets/Exceeds Standards)
5+ in Code Review && 3+ in Functional Requirements

Code Style Bonus Awards

Was the code particularly impressive in code style for any of these reasons (or more...?)

Quality
Yes?

Perfect Indentation
✅

Elegant/Clever
✅

Descriptive/Readable
✅

Concise
✅

Logical/Organized
✅

Summary
Nicely done, you hit all the learning goals here.  You nailed all the functionality.  I do think that checkForWinner can be done more compactly and readably, but your solution works.


Dates in the calendar are duplicated

[x] The issue is present in the latest release.
[x] I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯
Days in calendar are duplicated (double March 26).

Expected Behavior 🤔
No duplicated days.
Steps to Reproduce 🕹
Steps:

import moment from "moment-timezone"
import MomentUtils from "@date-io/moment"
Set default time zone in moment like this:
moment.tz.setDefault("Asia/Damascus");

I found two time zones to reproduce this bug:
"Asia/Damascus"
"Asia/Gaza"

Live example is here:
https://codesandbox.io/s/sleepy-yalow-ht57t?file=/src/App.jsx

Your Environment 🌎

Tech
Version

@material-ui/core
v4.4.3

@material-ui/pickers
v3.3.10

React
16.12.0

Browser
Chrome  Version 88.0.4324.192 (Official Build) (x86_64)

TypeScript
No

@date-io/moment
v1.3.11

moment-timezone
v0.5.33

@Potseluiko The component was moved to the main repository under the lab, in v5. https://next.material-ui.com/components/date-picker/. If you have a reproduction with this version, please open a new issue in https://github.com/mui-org/material-ui.


Changes IME to make it possible to use it from gdscript/gdnative

Changes IME input to use notification (NOTIFICATION_OS_IME_UPDATE) instead of callback.
Exposes IME methods to ClassDB.

Thanks!


Use block indent style when visual indent style fails

Closes #1078, closes #1580 and closes #1581.

I was a bit unsure about this change, but I think the results look good and it will be a good warm-up for moving to block indent by default (which I think we should do soon).

Thanks!


Preload not working?

HI, love this card but i'm struggling with an issue. As per the docs

Whether or not to preload the live view. Preloading causes the live view to render in the background regardless of what view is actually shown, so it's instantly available when requested. This consumes additional network/CPU resources continually.

When the page loads, I can see the spinner and then the camera feed appears, but i'm finding that when I switch to another tab and back, the camera view loads again. It's as if the camera is being unloaded when switching tabs. Any idea what i'm doing wrong?
type: custom:frigate-card
cameras:
  - live_provider: auto
    camera_entity: camera.doorbell_main_proxy
    frigate:
      camera_name: doorbell
    webrtc_card:
      entity: camera.doorbell_main_proxy
menu:
  style: outside
  position: right
  alignment: bottom
  buttons:
    frigate:
      enabled: false
    media_player:
      enabled: false
live:
  draggable: false
  auto_play: all
  lazy_load: false
  preload: true
timeline:
  media: clips
  show_recordings: true
dimensions:
  aspect_ratio_mode: static
  aspect_ratio: '3:4'

Hi @totalitarian , thanks for the feedback. I dug into this a little: at first I couldn't reproduce it, but if I use a WebRTC card camera then I can. The Frigate card "embeds" the WebRTC card, so whatever behavior that card uses underneath is a little opaque to the Frigate card -- this is one instance where surprise can occur. By default the WebRTC card won't allow streams to persist in the background, to enable that you need to pass the right option through.
When I use this it works:
type: custom:frigate-card
cameras:
  - camera_entity: camera.back_yard
    live_provider: webrtc-card
    webrtc_card:
      entity: camera.back_yard_rtsp
live:
  webrtc_card:
    background: true

The last line is the key one.

@dermotduffy that worked a treat. Many thanks!


feat: add token table

Summary
Schema:
CREATE TABLE tokens(
   address VARCHAR,
   symbol VARCHAR,
   decimals BIGINT,
   total_supply BIGINT,
   block_number BIGINT
)

Hi @fenghaojiang
Sorry for the confusing, I have update the summary, feel free to take :)

Hello,
Along with symbol, normally these is a name metadata also, I suggest to add "name VARCHAR" to this table, what do you think?

Then it would be
CREATE TABLE tokens(
address VARCHAR,
name VARCHAR,
symbol VARCHAR,
decimals BIGINT,
total_supply BIGINT,
block_number BIGINT
)


Failed to download 5.0.5 + no python3 support

I saw that you published the new version 3 days ago but pip install installing 5.0.4 which doesn't work for me with Python3.
Am I missing something?

Yeah, you're looking for this version: https://github.com/jeffwidman/cqlsh#600b4-mar-9-2022
I will release 6.0.0 once upstream cassandra ships 4.0 as GA... right now they are still shipping betas. I considered shipping 6.0.0 anyway, but I'd rather wait for GA because then PyPI version 6.0.0 will match the cqlsh version: https://github.com/apache/cassandra/commit/021232006c65b31a058735c5cc574096be4e8fe9
Unfortunately the metadata on the old versions 5.0.4 and earlier doesn't explicitly exclude python 3, so they still get pulled down by pip3.
I'd like to yank them, at least until Cassandra goes GA (and then can unyank them) but I don't have the proper permissions--when I was added as a maintainer on PyPI I was only given upload rights, not version management rights--I just fired an email to the owner to see if I can be made an admin and make this easier on folks.

I've yanked the old releases. So users will now get a message to install 6.0.0b4 for Python3.

Thanks @aboudreault!

just had a chance to test it but it breaks too quick :(
trying to run the following command via script:
cqlsh <my_scylla_hostname> -e "describe keyspaces;"

and I'm getting:
/usr/local/bin/cqlsh:470: DeprecationWarning: Legacy execution parameters will be removed in 4.0. Consider using execution profiles.
/usr/local/bin/cqlsh:500: DeprecationWarning: Setting the consistency level at the session level will be removed in 4.0. Consider using execution profiles and setting the desired consitency level to the EXEC_PROFILE_DEFAULT profile.
<stdin>:1:

any idea how can I use the execute flag in the new version? (6.0.0b4)
  -e EXECUTE, --execute=EXECUTE
                        Execute the statement and quit.

the warnings aren't error so I don't see the real issue and if your query was executed. You should probably create a ticket in the cassandra jira. This project is just packaging cqlsh from the project and publish on pypi.


Add RPN configs

Fixes https://github.com/facebookresearch/maskrcnn-benchmark/issues/65
This PR adds training configs for RPN.
I've launched training jobs to verify that they give expected accuracies. I'll be merging this PR once I've validated those numbers.

Here are the results for the training of these models:

backbone
type
lr schd
im / gpu
train mem (GB)
train time (s/iter)
train time total (hr)
inference time (s/im)
box AP
mask AP
kp AP
prop AR
model id

R-50-C4
RPN
1x
2
2.7
0.1674
4.2
0.057
-
-
-
51.5
6633541

R-50-FPN
RPN
1x
2
4.2
0.2940
7.3
0.078
-
-
-
56.8
6633542

R-101-FPN
RPN
1x
2
6.9
0.4070
10.2
0.097
-
-
-
58.0
6633899

X-101-32x8d-FPN
RPN
1x
2
13.3
0.9630
24.0
0.1644
-
-
-
59.4
6633900

The mAR metrics match the reported values in Detectron.
I'll merge this PR once I upload the pre-trained models and update the README

where is R-101-FPN config file?

@guabin1994 it's in https://github.com/facebookresearch/maskrcnn-benchmark/blob/a8d0381e870ede651f756454a5b5edcad4a3640b/configs/rpn_R_101_FPN_1x.yaml
Note that I haven't merged this PR yet, need to put the model weights online first.


I already spent an hour trying to implement it

Can't anyone make it just work? I'm trying various ways to implement it - npm, via script tag, programatically...Come on, it should be plug'n'play

Can you share an error message you get? Does the official demo work for you?

<script src="downloaded/pdfform.minipdf.dist.js"></script>
<script>
export default {
  mounted () {
    var pdf_buf = 'formularz_eu.pdf' // load PDF into an ArrayBuffer, for example via XHR (see demo)
    var fields = {
        'fieldname': ['value for fieldname[0]', 'value for fieldname[1]'],
    };
    var out_buf = pdfform().transform(pdf_buf, fields);
  }
}
</script>

[Vue warn]: Error in mounted hook: "ReferenceError: pdfform is not defined"
Yes, I'm using Vue.js, but when I import other scripts like this they work.
Yes, official demo works really nice for me (both versions).
I can't share because of privacy issues.

use nuxt is fine , and i did some work to create an ts version of this because of it's not work well with webpack;


[Bot] Updating Dockerfile dependencies

Updating Dockerfile dependencies to
Dockerfile

container-base: 2.0.20210721.2-21 => 2.0.20210721.2-22

Docker image: bucket-antivirus-function
Twistlock Image Scan
Vulnerabilities

CVE
Severity
Package
Version
Published since (days)
Has fix

ALAS-2019-1180
important
perl
1.04-294.43.amzn1
881
yes

ALAS-2013-177
medium
perl
1.04-294.43.amzn1
3057
yes

Total: 2
Critical: 0 High: 1 Medium: 1 Low: 0
Compliances
Private keys stored in image
Severity: high

Total: 1
Critical: 0 High: 1 Medium: 0 Low: 0


aldente: 1.22.2 -> 1.22.3

Description of changes
diff --git a/pkgs/os-specific/darwin/aldente/default.nix b/pkgs/os-specific/darwin/aldente/default.nix
index 6dd464a405f..7ca454609ae 100644
--- a/pkgs/os-specific/darwin/aldente/default.nix
+++ b/pkgs/os-specific/darwin/aldente/default.nix
@@ -6,11 +6,11 @@

 stdenvNoCC.mkDerivation (finalAttrs: {
   pname = "aldente";
-  version = "1.22.2";
+  version = "1.22.3";

   src = fetchurl {
     url = "https://github.com/davidwernhart/aldente-charge-limiter/releases/download/${finalAttrs.version}/AlDente.dmg";
-    hash = "sha256-bREI0RS4xvEccyw3yed5aD8oG5wmD5hyG82qW2tqlEA=";
+    hash = "sha256-pSqBDDumCbORLQ+B3skSqKmgG2KybR5Zb4ojiNQcAaM=";
   };

   dontBuild = true;

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 262354 run on aarch64-darwin 1

1 package updated

aldente (1.22.2 → 1.22.3)

1 package built

aldente

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/2787

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-already-reviewed/2617/1212


missing parent  "cell septum surface"

cell septum surface.
is defined
The extracellular (rather than the intracellular) exterior of a dividing septum; this surface is usually composed of cell wall material, for example, lineal (1,3)-beta-D-glucan in S. pombe.
but is not a child of division septum
division septum (GO:0000935)
please could  it be rehoused.
In addition could you change the primary name from
cell septum surface - division septum surface
to make clearer
(or even, since I don't think we need this distinction, merge into division septum (GO:0000935))

Definitely merge instead


LD A (HL+) implementation and test

Coverage increased (+0.01%) to 99.087% when pulling 31ea0debc572c154e253b7b5ba8f57fb5154af04 on ldahlpinchl-implementation into 8e0c41f24aff0a39f02de6bab64115a0b7e431e3 on master.


Bannerlord crashes when moving on campaign map

Bannerlord crashes when moving on campaign map.
Bannerboard is the involved module in the crash report:
https://report.butr.link/203665.html

Thanks, I'll look into it.
Sent from Outlook for iOShttps://aka.ms/o0ukef

From: Arvid Halvorsen Hansen @.>
Sent: Saturday, February 11, 2023 5:24:29 AM
To: edgarssults/Bannerboard @.>
Cc: Subscribed @.***>
Subject: [edgarssults/Bannerboard] Bannerlord crashes when moving on campaign map (Issue #4)
Bannerlord crashes when moving on campaign map.
Bannerboard is the involved module in the crash report:
https://report.butr.link/203665.html
—
Reply to this email directly, view it on GitHubhttps://github.com/edgarssults/Bannerboard/issues/4, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AB5Z3WQ26FMUVB34JEI4TFDWW4A63ANCNFSM6AAAAAAUYOQNAY.
You are receiving this because you are subscribed to this thread.Message ID: @.***>

Added additional exception handling around the hero widget updates. I'm not sure what exactly was null there, possibly the list of tracked heroes.


Don't use STDIN if file name is provided even if not a TTY

When running gql2ts as part of certain task runners STDIN will not be a TTY.
This causes this code here:
https://github.com/avantcredit/gql2ts/blob/4e36bd52fc81a3c8fbffd5685a0a3933a3474f5b/packages/cli/src/index.ts#L64-L74
to read from STDIN even if a filename is provided, which ultimately will result in the hard-to-debug error
GraphQLError: Syntax Error GraphQL request (1:1) Unexpected <EOF>
because the STDIN is empty.
I would propose to always read from file when a file name is given.

Makes sense, I'll take a look tomorrow, but doesn't seem too difficult.
What task runner are you using to do this? Is there a reason not to use the package itself over the cli tool?

There's a top level build bash script which eventually calls goreman to spawn a bunch of concurrent processes, one of which is npm run watch, which runs concurrently which runs chokidar schema.graphql -c "gql2ts -o graphqlschema.d.ts schema.graphql". This sounds more complicated than it really is and introducing a JS build script would be harder to maintain. I have no idea at what point it breaks down, but I think the proposed fix is reasonable

Definitely reasonable, I was just curious what the use case was. Sorry if it came off otherwise

not at all :)

I'll +1 this. I had the same issue running it as a task via Webstorm. It can be worked around by echoing something to the script first, like echo '' > gql2ts ./gql/schema.json -o ./frontend/gql/schema.ts , but it'd be better if it didn't block on reading when it doesn't have to.


Jest with Zone.js stops executing tests

🐛 Bug Report
Setting up existing Angular workspace library project with Jest.
Followed jest-preset-angular instructions.
But it fails with below line:
Failed: "Zone is needed for the async() test helper but could not be found. Please make sure that your environment includes zone.js/dist/zone.js"
I am aware that jest-zone-patch helps for zone purpose. Still it throws error.
I add required file manually as well, but no help
To Reproduce
Have Angular workspace with library in it. Generate a default component, with default spec file.
Setup jest.
And run tests.
--- OR ---
You can go to repo link mentioned, and check bug there with same steps
Expected behavior
Tests should work fine.
Link to repl or repo (highly encouraged)
https://github.com/varora1406/jest-zone-test
envinfo
Windows 10 environment
Have below project package configurations :
Angular dependencies - v9.0.3
"jest": "^26.0.1",
"jest-preset-angular": "^8.2.0",
"jest-zone-patch": "0.0.10",
"@types/jest": "^25.2.3"

It could be a comeback of https://github.com/facebook/jest/issues/5384

@thymikee , @jeysal
Maybe you guys can help out here

One little note, jest-zone-patch has been migrated into jest-preset-angular so you don’t need to install it explicitly anymore

I have same problem.
"@angular/core": "9.1.7".
"typescript": "^3.8.3",
"jest": "^26.0.1",
"jest-junit": "^10.0.0",
"jest-preset-angular": "^8.2.0",

Any ideas?

You can compare your project config with https://github.com/thymikee/jest-preset-angular/tree/master/example

works with added jestGlobalMocks.ts
but still have error
TypeError: Cannot read property 'ɵprov' of undefined

You can compare your project config with https://github.com/thymikee/jest-preset-angular/tree/master/example

Update @ahnpnl link: https://github.com/thymikee/jest-preset-angular/tree/master/examples/example-app-v12
I had the same issue and I'm trying to follow the config in this example


OneDark Theme

Added Theme "onedark.toml" To themeZip/v1.1.3

@CommandJoo
Whould you put the file into src/superfile_config/theme/onedark.toml?
The zip folder is for old verison.

Oh yeah sorry wasnt Sure where to Put it

That's my problem, that folder is really confusing. :/
I would delete it in the future!

Alright it should be in superfile_config/theme now

Ok thanks for your contribution!


[Proposal] Include a t function

The t function helps localizing strings where the component cannot be
used. Some examples are:

You need a list of localized strings alphabetically sorted.
Want to use as text in an ion-select.
Want to use as parameters of other functions (date formatting, as an
example).

It follows a few conventions I saw in many other libraries through the
years, while leaving others I'm not sure how I want them implemented
yet.
The main one is using the parameter count in replacements as the way
to pluralize the string. If a count field is found, we look for
a pluralize suffix. That is, to the key being used, we'll append the
result of running the select method to the count parameter. (Getting
the locale can certainly be improved, and maybe would need to be moved
to dictionary.

Hey, thank you so much!
I think this is fantastic and hits on a lot of points I've been considering. I do think I've made some progress towards accomplishing this, but more on that below.
Just wanted to share a few quick thoughts...

Pluralization needs to be discussed, but I think it's out of scope for this proposal. I've created a separate issue (#2) to track that.

Is t a clear name for the function? If it's a default export people can call it what they want, but I might lean towards naming it translate or phrase.

t should probably just be a thin wrapper around Dictionary.resolvePhrase(), so that all of the logic is shared between the t function and the phrase component. Or maybe it's the other way around, where Dictionary.resolvePhrase() becomes a wrapper around the t utility function.

What happens when the locale changes? Here, users would need to listen for the intlChange event, then recalculate everything that relies on t. Since I'd prefer users not listen to intlChange directly, this seems like a fit for a few patterns: Observable (https://github.com/ReactiveX/rxjs), Observer (like https://developer.mozilla.org/en-US/docs/Web/API/IntersectionObserver), maybe there's a way to do it with native Promises or Generators? I would prefer not to add a hard dependency on rxjs, since it's fairly opinionated.

As a first pass, I've implemented similar functionality in what I'm calling LanguageObserver. Check out a sample implementation in the demo. (Since I'm relying on utility functions to turn the results back into an object, I think that's something that needs to be changed soon.)
There's room for improvement, and I still think we may want to expose a t-like function for users that don't care about the locale change. But feel free to mess around with it (npm i @intl/core@next). Maybe the Observer pattern isn't even the right way to go? I'm not sure! I'd love to hear your thoughts.

I'll answer bullet point by bullet point:

If ICU lands, pluralization can go then. Will update asap.
The correct name is translate, though I might want to export it as a default so people can import it easier.
resolvePhrase is only the first part, I would not remove the replacement part from t. If you remove replacing the values, you get the phrase util. I think Phrase.replaceValueis a wrapper of translate.
I would say nothing should happen when locale changes. For a few reasons:

Nothing happens when locale changes in the phrase util.
translate returning the value given the current locale allows the codebase to grow with an observable-translate, while having the observable version complicates the non-observable one.
Quite likely, the component where it is being used already has to listen to intlChanged or repaint based on it.

Closing this.


Split kotlin-dsl-tooling-builders and not run them on TD

They seem to be much more flaky on TD, even with local executors.

@bot-gradle test and merge

Your PR is queued. See the queue page for details.

OK, I've already triggered a build for you.


Fix repo push remote to use the right url

The init script was updated to set the push remote to use the git@ url. However it was running the command in the wrong directory, so was actually setting the remote of the dev-env repo each time, not the sub-packages.
This fixes it to run the command in the right directory, but also runs it if the repo is already cloned - ie repair existing installed.

One return statement too much, but looks good otherwise @knolleary


CASSANDRA-18624 Interface to initialize the cryptographic provider, use ACCP as default

An interface ICryptoProvider is created. This will allow users to use custom providers if they don't prefer to use the default provider - ACCP. If installation/check of crypto provider fails then a fallback provider will be used and the exception will be logged as a warning message.
Circle CI build: java11 java8

Patch by @ayushisingh29; to be reviewed by @jrwest  and @clohfink for CASSANDRA-18624
Cassandra-18624

Thanks @smiklosovic for the suggestions. I have cherry-picked the improvements you made and also created the flag to fail on error.

I am closing this in favor of https://github.com/apache/cassandra/pull/2505 where we are building on top of this work.


ARM support

Thanks for creating the great tool. I am not seeing any ARM packages.
Do you have any plans to support the ARM processor.

We have ARM releases for MacOS already. Are you talking about other OS's that support ARM?

We have ARM releases for MacOS already. Are you talking about other OS's that support ARM?

I am not seeing it here unless which ever doesn't have arch in name is ARM?.

You need to get the aarch64 DMG, which is ARM 💪🏻


Cannot destructure property 'timeout' of 'undefined' as it is undefined.

Before opening, please confirm:

[X] I have installed the latest version of the Amplify CLI (see above), and confirmed that the issue still persists.
[X] I have searched for duplicate or closed issues.
[X] I have read the guide for submitting bug reports.
[X] I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.

How did you install the Amplify CLI?
npm
If applicable, what version of Node.js are you using?
No response
Amplify CLI Version
4.44.0
What operating system are you using?
mac
Amplify Categories
function
Amplify Commands
Not applicable
Describe the bug
Describe the bug
I'm trying to start the local development server. I followed the instructions in the manual and ran:
amplify mock
amplify mock function

This is the error I'm getting:
➜  showcase (ruby-2.5.5) git:(master) amplify mock function
? Provide the path to the event JSON object relative to /Users/newuser/x/rcv/showcase/amplify/backend/function/rcvce175542 src/event.json
Ensuring latest function changes are built...
Starting execution...
rcvce175542 failed with the following error:
TypeError: Cannot destructure property 'timeout' of 'undefined' as it is undefined.
    at getCancellableTimer (/Users/newuser/.volta/tools/image/packages/@aws-amplify/cli/lib/node_modules/@aws-amplify/cli/node_modules/amplify-util-mock/src/func/index.ts:73:32)
    at Object.timeConstrainedInvoker (/Users/newuser/.volta/tools/image/packages/@aws-amplify/cli/lib/node_modules/@aws-amplify/cli/node_modules/amplify-util-mock/src/func/index.ts:65:29)
    at Object.start (/Users/newuser/.volta/tools/image/packages/@aws-amplify/cli/lib/node_modules/@aws-amplify/cli/node_modules/amplify-util-mock/src/func/index.ts:48:26)
    at processTicksAndRejections (node:internal/process/task_queues:93:5)
    at Object.run (/Users/newuser/.volta/tools/image/packages/@aws-amplify/cli/lib/node_modules/@aws-amplify/cli/node_modules/amplify-util-mock/src/commands/mock/function.ts:14:5)
    at Object.executeAmplifyCommand (/Users/newuser/.volta/tools/image/packages/@aws-amplify/cli/lib/node_modules/@aws-amplify/cli/node_modules/amplify-util-mock/src/amplify-plugin-index.ts:8:3)
    at executePluginModuleCommand (/Users/newuser/.volta/tools/image/packages/@aws-amplify/cli/lib/node_modules/@aws-amplify/cli/src/execution-manager.ts:181:3)
    at Object.executeCommand (/Users/newuser/.volta/tools/image/packages/@aws-amplify/cli/lib/node_modules/@aws-amplify/cli/src/execution-manager.ts:28:5)
    at Object.run (/Users/newuser/.volta/tools/image/packages/@aws-amplify/cli/lib/node_modules/@aws-amplify/cli/src/index.ts:105:5)

It looks like context.input.options is undefined in this line:
const result = await exports.timeConstrainedInvoker(invoker({ event }), context.input.options);
...around here:
Object.timeConstrainedInvoker (/Users/newuser/.volta/tools/image/packages/@aws-amplify/cli/lib/node_modules/@aws-amplify/cli/node_modules/amplify-util-mock/src/func/index.ts:65:29)
I worked around it by adding a fallback option , i.e.{ timeout: 10 }.
Expected behavior
See the description above.
Reproduction steps
See the description above.
Log output
# Put your logs below this line

This appears to be a duplicate of https://github.com/aws-amplify/amplify-cli/issues/6653, which has been fixed and released. Can you try updating your version of the CLI.

I'm using 4.44.0. Is it not the latest version?

Ah, I see it's 4.45.2. Le me give it a try..

Works. Thank you.


Adding bootstrap styled search

This can be improved upon but I think we at least need to add the bootstrap styles to the input search field. The default search border is kinda ugly.
add_filter( 'genesis_search_form', 'bsg_search_form', 10, 4);

function bsg_search_form( $form, $search_text, $button_text, $label ) {

    $value_or_placeholder = ( get_search_query() == '' ) ? 'placeholder' : 'value';

    $form = sprintf( '<form method="get" class="search-form form-inline" action="%s" role="search">
%s<input type="search" class="search-field form-control" name="s" %s="%s" /><button type="submit" class="search-submit btn btn-default" value="%s" /></button>
</form>', home_url( '/' ), esc_html( $label ), $value_or_placeholder, esc_attr( $search_text ), esc_attr( $button_text ) );

    return $form;
}

Also, not sure why this is needed, but it seems to fix issues with the search width:
form.search-form .input-group-btn {
    width: 1%;
}
.search-form > .input-group {
    width: 100%;
}
.search-form .glyphicon {
    top: 2px;
}

Wow, this screenshot looks way better.  Thanks @bryanwillis
I look forward to trying this code out and getting this added to the project

For future reference, here is a list of the markup changes @bryanwillis outlined above

add class .form-inline to form element
wrap $search_text in div.input-group
add class .form-control to input search field
wrap input button in span.input-group-btn
change submit from input to button
add classes .search-submit and .btn-default to submit button
add i.glyphicon-search inside submit button

I found these three links helpful is building the format of the search box.

http://getbootstrap.com/css/#forms
http://getbootstrap.com/components/#input-groups-buttons
http://getbootstrap.com/components/#glyphicons-examples

Been meaning to get back to this for awhile, but kept forgetting about it. The 1% width  .input-group-button isn't getting priority over the auto width in the media query so it's not being displayed right.
So it's looking like this:

Instead of being full-width on all displays like this:

There are are a lot of ways to fix this.
1) Just target 768px as it seems to be only one affected:
@media (min-width: 768px) {
.search-form.form-inline .input-group > .input-group-btn {
    width: 1%;
 }
}

2) Use the sibling selector which will get priority:
input#bsg-search-form ~ .input-group-btn {
     width: 1%;
}

3) Use !important (hacky solution):
.search-form .input-group-btn {
     width: 1% !important;
}

On a side note from the search bar width, we also might still need to move the glyphicon search icon down another pixel, at least the way I'm seeing it. This could possibly be retina mac display only though.
.search-form .glyphicon {
    top: 2px;
}

Alternatively, we could fix both of these issues using flexbox. While the code here is the longest it is also way cleaner than bootstraps 1% width hack.
.search-form.form-inline .input-group,
.search-form.form-inline .input-group .input-group-btn {
    display: flex;
}
#bsg-search-form {
    flex: 1;
}
button.search-submit.btn.btn-default {
    display: inline-flex;
    padding: 0 14px;
    justify-content: center;  /* might not be needed */
    align-items: center; /*  might not be needed  */
}
@media (min-width: 768px) {
   .search-form.form-inline > .form-group {
        display: block;
    }
}


Removing extern crate in examples

In the examples, extern crate tch is used which is not needed since rust-2018. Is there any reason why this is still being used? I'm sorry if I might have missed something that was obvious. But if there is no reason to have it, I'd be more than happy to submit a pull request with those parts removed.
My apologies if I asked a question that has already been answered but I tried to look around for closed issues or pull requests which might have dealt with this but I couldn't find any.

There is no good reason that I would know of. I guess it just came from all the examples being started by copying a previous example. Anyway I just pushed some changes to remove these, thanks for reporting this!

No problem! Glad I could help


Change request protocol for proxying Jetty

Hi,
in my configuration I wanted to have apache (or nginx) to proxy the Jetty server.
My configuration was like that:
   https                 http
 --------->   Apache   -------> Jetty

As suggested by this link: https://wiki.eclipse.org/Jetty/Howto/Configure_mod_proxy the solution could be that of extending the SelectChannelConnector to set the proper schema.
The schema is retrieved from the X-Forwarded-Proto HTTP header to keep the mechanism forward compatible with Jetty 9.

Interesting... If I remember correctly, this is exactly the same configuration as run bij SURFnet. However, at SURFnet they do not need such a Jetty connector. Does any of the other collaborators remember how this isn't a problem at SURFnet?

I can describe better the situation.
The problem happens when we try to validate SAML assertions and they are considered valid only if released to the proper endpoint url.
So, in my case, an assertion is released to https://oauth.mi.garr.it/oauth2/authorize while jetty is running on http and on localhost, so it sees the URL http://localhost:8080/oauth2/authorize.
Error in the log:
10:38:50.369 [qtp118256356-23] ERROR o.o.c.b.d.BaseSAMLMessageDecoder - SAML message intended destination endpoint 'https://oauth.mi.garr.it/oauth2/authorize' did not match the recipient endpoint 'http://localhost:8080/oauth2/authorize'
2015-07-15 10:38:50.369:WARN:oejs.ServletHandler:/oauth2/authorize

By enabling ProxyPreserveHost On directive in Apache, situation gets better but sill presenting a problem. From the log:
13:17:22.258 [qtp555720467-20] ERROR o.o.c.b.d.BaseSAMLMessageDecoder - SAML message intended destination endpoint 'https://oauth.mi.garr.it/oauth2/authorize' did not match the recipient endpoint 'http://oauth.mi.garr.it/oauth2/authorize'
2015-07-15 13:17:22.267:WARN:oejs.ServletHandler:/oauth2/authorize

The extension to the connector was the only solution I've been able to find.
Any further comment would be highly appreciated!

Hi Biancini,
Thanks for the clarification.
I also did some digging in historical email conversations. It turns out that in production, SURFnet does not run the Apis web application on Jetty. So there is no issue there.
However, SURFnet has a partner who actually tried to run Apis using Jetty (don't know the current status). They also faced the problem you describe, and they solved it in almost the same way, using [this jar] (https://github.com/Nowaker/jetty-https/), containing almost the same impl as you did.

Included a maven dependency on that stratushost.eu jar
Added a reference to a custom jetty.xml in the pom.xml of apis-authorization-server-war
In that jetty.xml, added a Call to addConnector (see snippet below)

    <Call name="addConnector">
      <Arg>
          <!--<New class="org.eclipse.jetty.server.nio.SelectChannelConnector">-->
          <New class="eu.stratushost.java.jetty.SslConnector">
            <Set name="host"><Property name="jetty.host" /></Set>
            <Set name="port"><Property name="jetty.port" default="8080"/></Set>
            <Set name="forwarded">true</Set>
            <Set name="maxIdleTime">300000</Set>
            <Set name="Acceptors">2</Set>
            <Set name="statsOn">false</Set>
            <Set name="confidentialPort">8443</Set>
	    <Set name="lowResourcesConnections">20000</Set>
	    <Set name="lowResourcesMaxIdleTime">5000</Set>
          </New>
      </Arg>
    </Call>

Conclusions:

This PR contains a self contained solution (instead of the one by SURFnet's partner)
The extra module does no harm in environments that run apis-authorization-server-war in another container.

A word of caution though: Running Apis in production using the maven setup (maven jetty:run, with src/test/resources on classpath etc) is not something we endorse.
But anyway, let's merge this. @biancini could you please do some cleanup on this PR before I merge it? (remove .gitignore, add a proper readme.md or omit it at all, add an Apache License header to the Java file)
Thank you by the way!

Ops, sorry for the readme and other stuff. I must have forgotten them.
I should have cleaned the PR. Let me know if you suggest something more!

@gvanderploeg Is this ready for merge now?


German traffic sign recognition benchmark Model

Dataset

https://benchmark.ini.rub.de/?section=gtsrb&subsection=dataset

Hey! I would like to work on this issue. Can you please assign this issue to me under GSSoC'22?

Make PR till 31 May.

Sure. Thanks!

Hey! I have created the pull request. Could you please take a look?

@Rutikab12 I have added another commit to the PR for this issue. Can you check that one? I think it should work now.


Currency pair param for converter

https://github.com/moneyphp/money/issues/498

@sagikazarmark How about leaving the exchanges out of this, and just adding an optional 4th parameter?

@Padam87 I've commented on the PR, can you please take a look at it. Also, please rebase the PR from master.

Superseded by #644


Make API and trigger ports dynamic

Example output for feedback:

Because we're supporting hot-reloading and the number of workers can change at any time, supporting alphabetical ordering of ports its a bit trickier (but not impossible).
At the moment all ports will be consistently held under their names for the lifetime of a single nitric start.

@tjholm the e2e tests are failing as they expect the api on http://localhost:9001/apis/nitric-testr
you can override this by setting BASE_URL="what ever you want"

@tjholm the e2e tests are failing as they expect the api on http://localhost:9001/apis/nitric-testr you can override this by setting BASE_URL="what ever you want"

Looks like this needs to be updated, as the trigger URL for topics/schedules is going to be different in this new setup.

Codecov Report
Base: 28.67% // Head: 28.48% // Decreases project coverage by -0.19% :warning:

Coverage data is based on head (3dfb733) compared to base (d8efc7f).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #412      +/-   ##
===========================================
- Coverage    28.67%   28.48%   -0.20%
===========================================
  Files           54       54
  Lines         4878     4911      +33
===========================================
  Hits          1399     1399
- Misses        3348     3381      +33
  Partials       131      131

Flag
Coverage Δ

unittests
28.48% <0.00%> (-0.20%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/utils/net.go
0.00% <0.00%> (ø)

pkg/provider/pulumi/common/image.go
0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


When you install isort==4.3.0 version still shows 4.2.14

After installing wheel for version 4.3.0, isort --version-number still shows 4.2.14.
I just examined wheel contents and it indeed contains old version number, the same as in repo: https://github.com/timothycrosley/isort/blob/master/isort/init.py#L28
My Python is 3.6.2.

Should be fixed after merging #655

Version 4.3.0 on pypi still shows 4.2.14.

This should now be fixed in release 4.3.1, Thank you!


pull request for e2e test at 12/24/2016 02:26:11

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Add Download preplanned map sample

Context
This PR implements a sample to Download preplanned map.

Web Map
Preplanned Areas (popover)

Info
Code

@saratchandrakarumuri & @philium : thanks for your valuable feedback. I have carefully considered all of it, and responded to each comment with commits for your consideration.
Mind taking another look?

@saratchandrakarumuri Thanks for your time and attention.

All the issues are sorted except for the crash. I am still able to repro the crash.

That stack trace is much more helpful; thank you! I have pushed an additional commit (7cb8c4ae) that should resolve the crash.

When the popover is dismissed while downloading a map, download is terminated

This is working as intended. Would you agree this is sufficient for a sample?

Thanks for the review @saratchandrakarumuri. I'll stand by to hear from @philium about whether / when this is ready to merge from his perspective.


BRAT keeps downgrading plugin

If auto-update is on then BRAT will reinstall 0.0.3.
The update process then offers 0.0.4, so some part of auto-update does detect the new version.

0.2.0 should be the latest


hotfix: supportex handling

/lgtm

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (9c98940) 36.95% compared to head (0713f5c) 36.95%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #252   +/-   ##
=======================================
  Coverage   36.95%   36.95%
=======================================
  Files          16       16
  Lines        1675     1675
=======================================
  Hits          619      619
  Misses       1013     1013
  Partials       43       43


Exception when running getMenuItemById

[x ] I have read the contribution documentation for this project.
[x ] I agree to follow the code of conduct that this project follows, as appropriate.
[ x] I have searched the issue tracker for an issue that matches the one I want to file, without success.

Please describe your issue:
I am experiencing this exception only after running electron-forge make:
Uncaught Exception:
TypeError: p.getMenuInstance(...).getMenuItemById is not a function
    at t (/Users/galba/repos/wire/out/Reversee-darwin-x64/Reversee.app/Contents/Resources/app/src/main.js:1:816)
    at EventEmitter.s.on (/Users/galba/repos/wire/out/Reversee-darwin-x64/Reversee.app/Contents/Resources/app/src/main.js:1:2594)
    at emitTwo (events.js:106:13)
    at EventEmitter.emit (events.js:194:7)
    at WebContents.<anonymous> (/Users/galba/repos/wire/out/Reversee-darwin-x64/Reversee.app/Contents/Resources/electron.asar/browser/api/web-contents.js:247:13)
    at emitTwo (events.js:106:13)
    at WebContents.emit (events.js:194:7)

It seems like that somehow in the build process, the underlying electron version is not the latest one and the method getMenuItemById of Menu is missing.
When I run electron-forge start I do not get this error.
I have created a small git repo to demonstrate the problem:
https://github.com/galusben/electron-bug-385
After cloning run:
electron-forge start
The application starts
run: electron-forge make
Then run the .app file from the out dir, you will see a similar exception.
I am using mac, and experiencing the issue while building for mac.
Here are my dependencien:
 "devDependencies": {
    "chai": "^3.5.0",
    "chai-as-promised": "^5.3.0",
    "electron-prebuilt-compile": "1.7.9",
    "mocha": "^3.0.2",
    "rimraf": "^2.5.4",
    "spectron": "^3.6.0",
    "uglify-es": "^3.0.26"
  },
  "dependencies": {
    "bootstrap": "^3.3.7",
    "bootstrap-select": "^1.12.2",
    "codemirror": "^5.25.2",
    "electron-compile": "^6.4.2",
    "electron-squirrel-startup": "^1.0.0",
    "font-awesome": "^4.7.0",
    "jquery": "^3.1.0",
    "lodash": "^4.17.4",
    "request-to-curl": "^0.1.1",
    "split.js": "^1.3.4"
  },

Thanks!

Console output when you run electron-forge with the environment variable DEBUG=electron-forge:*. (Instructions on how to do so here). Please include the stack trace if one exists.
galba-mac:wire galba$ electron-forge make
WARNING: DEBUG environment variable detected.  Progress indicators will be sent over electron-forge:lifecycle
  electron-forge:lifecycle Process Started: Checking your system +0ms
  electron-forge:lifecycle Process Succeeded: Checking your system +730ms
  electron-forge:runtime-config setting key: verbose to value: false +0ms
WARNING: DEBUG environment variable detected.  Progress indicators will be sent over electron-forge:lifecycle
  electron-forge:lifecycle Process Started: Resolving Forge Config +0ms
  electron-forge:project-resolver searching for project in: /Users/galba/repos/wire +0ms
  electron-forge:project-resolver electron-forge compatible package.json found in /Users/galba/repos/wire/package.json +5ms
  electron-forge:lifecycle Process Succeeded: Resolving Forge Config +13ms
  electron-forge:require-search searching [ '../makers/darwin/zip.js',
  '../makers/generic/zip.js',
  'electron-forge-maker-zip',
  'zip',
  '/Users/galba/repos/wire/zip',
  '/Users/galba/repos/wire/node_modules/zip',
  '/usr/local/lib/node_modules/electron-forge/dist/makers/darwin/zip.js',
  '/usr/local/lib/node_modules/electron-forge/dist/makers/generic/zip.js',
  '/usr/local/lib/node_modules/electron-forge/dist/api/electron-forge-maker-zip',
  '/usr/local/lib/node_modules/electron-forge/dist/api/zip',
  '/Users/galba/repos/wire/zip',
  '/Users/galba/repos/wire/node_modules/zip',
  '/usr/local/lib/node_modules/electron-forge/dist/api/makers/darwin/zip.js',
  '/usr/local/lib/node_modules/electron-forge/dist/api/makers/generic/zip.js',
  '/usr/local/lib/node_modules/electron-forge/dist/api/node_modules/electron-forge-maker-zip',
  '/usr/local/lib/node_modules/electron-forge/dist/api/node_modules/zip',
  '/Users/galba/repos/wire/zip',
  '/Users/galba/repos/wire/node_modules/zip' ] relative to /usr/local/lib/node_modules/electron-forge/dist/api +0ms
  electron-forge:require-search testing ../makers/darwin/zip.js +1ms
  electron-forge:require-search testing ../makers/generic/zip.js +0ms
  electron-forge:require-search searching [ '../makers/darwin/dmg.js',
  '../makers/generic/dmg.js',
  'electron-forge-maker-dmg',
  'dmg',
  '/Users/galba/repos/wire/dmg',
  '/Users/galba/repos/wire/node_modules/dmg',
  '/usr/local/lib/node_modules/electron-forge/dist/makers/darwin/dmg.js',
  '/usr/local/lib/node_modules/electron-forge/dist/makers/generic/dmg.js',
  '/usr/local/lib/node_modules/electron-forge/dist/api/electron-forge-maker-dmg',
  '/usr/local/lib/node_modules/electron-forge/dist/api/dmg',
  '/Users/galba/repos/wire/dmg',
  '/Users/galba/repos/wire/node_modules/dmg',
  '/usr/local/lib/node_modules/electron-forge/dist/api/makers/darwin/dmg.js',
  '/usr/local/lib/node_modules/electron-forge/dist/api/makers/generic/dmg.js',
  '/usr/local/lib/node_modules/electron-forge/dist/api/node_modules/electron-forge-maker-dmg',
  '/usr/local/lib/node_modules/electron-forge/dist/api/node_modules/dmg',
  '/Users/galba/repos/wire/dmg',
  '/Users/galba/repos/wire/node_modules/dmg' ] relative to /usr/local/lib/node_modules/electron-forge/dist/api +2ms
  electron-forge:require-search testing ../makers/darwin/dmg.js +1ms
We need to package your application before we can make it
  electron-forge:lifecycle Process Started: Preparing to Package Application for arch: x64 +7ms
  electron-forge:project-resolver searching for project in: /Users/galba/repos/wire +13ms
  electron-forge:project-resolver electron-forge compatible package.json found in /Users/galba/repos/wire/package.json +0ms
  electron-forge:require-search searching [ './afterCopy.js',
  '/Users/galba/repos/wire/afterCopy.js',
  '/Users/galba/repos/wire/node_modules/afterCopy.js' ] relative to /Users/galba/repos/wire +6ms
  electron-forge:require-search testing ./afterCopy.js +0ms
  electron-forge:require-search testing /Users/galba/repos/wire/afterCopy.js +0ms
Loading custom after copy
  electron-forge:hook could not find hook: generateAssets +0ms
  electron-forge:hook could not find hook: prePackage +0ms
  electron-forge:packager packaging with options { asar: false,
  overwrite: true,
  dir: '/Users/galba/repos/wire',
  ignore: 'tests|.idea|.*iml|Dockerfile|bitbucket-pipelines.yml|afterCopy.js',
  platform: 'darwin',
  packageManager: 'yarn',
  icon: 'src/assets/Reversee',
  afterCopy: [ [Function], [Function], [Function], [Function] ],
  afterExtract: [],
  afterPrune: [ [Function: rebuildHookFn] ],
  arch: 'x64',
  out: '/Users/galba/repos/wire/out',
  electronVersion: '1.7.9',
  quiet: true } +0ms
  electron-forge:lifecycle Process Succeeded: Preparing to Package Application for arch: x64 +6s
  electron-forge:lifecycle Process Started: Compiling Application +2ms
Running custom after copy
/var/folders/9f/m1l6xy4x4zg7xwn203ffz6755th6cv/T/electron-packager/darwin-x64/Reversee-darwin-x64/Electron.app/Contents/Resources/app
1.7.9
darwin
x64
[ '.DS_Store',
  'assets',
  'breakPoint.html',
  'breakPointsEdit.html',
  'breakpoint.js',
  'breakpointsEdit.js',
  'index.html',
  'index.js',
  'interceptor.js',
  'main.js',
  'menu.js',
  'proxy.js',
  'resources' ]
.DS_Store
assets
breakPoint.html
breakPointsEdit.html
breakpoint.js
breakpointsEdit.js
index.html
index.js
interceptor.js
main.js
menu.js
proxy.js
resources
  electron-forge:lifecycle Process Succeeded: Compiling Application +7s
  electron-forge:lifecycle Process Started: Preparing native dependencies +4s
  electron-forge:lifecycle Process Succeeded: Preparing native dependencies +63ms
  electron-forge:lifecycle Process Started: Packaging Application +0ms
  electron-forge:hook could not find hook: postPackage +17s
  electron-forge:lifecycle Process Succeeded: Packaging Application +27ms
Making for the following targets:
  electron-forge:hook could not find hook: preMake +1ms
  electron-forge:lifecycle Process Started: Making for target: zip - On platform: darwin - For arch: x64 +2ms
  electron-forge:lifecycle Process Succeeded: Making for target: zip - On platform: darwin - For arch: x64 +13s
  electron-forge:lifecycle Process Started: Making for target: dmg - On platform: darwin - For arch: x64 +0ms
  electron-forge:lifecycle Process Succeeded: Making for target: dmg - On platform: darwin - For arch: x64 +14s
  electron-forge:hook could not find hook: postMake +27s
galba-mac:wire galba$

What command line arguments are you passing?
electron-forge make

What does your config.forge data in package.json look like?
    "forge": {
      "s3": {
        "accessKeyId": "***",
        "bucket": "***",
        "public": true
      },
      "make_targets": {
        "win32": [
          "zip",
          "squirrel"
        ],
        "darwin": [
          "zip",
          "dmg"
        ],
        "linux": [
          "zip",
          "deb"
        ]
      },
      "electronPackagerConfig": {
        "dir": "src",
        "ignore": "tests|.idea|.*iml|Dockerfile|afterCopy.js",
        "platform": [
          "linux",
          "win32",
          "darwin"
        ],
        "packageManager": "yarn",
        "icon": "src/assets/Reversee",
        "afterCopy": [
          "./afterCopy.js"
        ]
      },
      "electronWinstallerConfig": {
        "name": "Reversee",
        "title": "Reversee",
        "authors": "Gal Ben Ami",
        "description": "Reversee - ***"
      },
      "electronInstallerDebian": {
        "description": "Reversee - ****",
        "productDescription": "Reversee - ****"
      }
    }

Please provide either a failing minimal testcase (with a link to the code) or detailed steps to
reproduce your problem. Using electron-forge init is a good starting point, if that is not the
source of your problem.

getMenuItemById was added to Electron in https://github.com/electron/electron/commit/15b0878a176bec6ddef1a411f177900ff742f13b, and was first released in the 1.8.x series. As of the time of this comment, the 1.8.x series is in beta. Electron Forge defaults to the latest stable release when creating a new project.

@galusben To aleive confusion here, the reason it works with start is because there is a bug in<EMAIL_ADDRESS>that causes it to download @1.8.1 instead 👍

Strange, it doesn't work for me.

Thanks!


Absolute path in model.sdf causes problems

Hi @AndrejOrsula
Since there is an absolute path in the model.sdf file, the file does not resolve correctly on my machine.
https://github.com/AndrejOrsula/panda_ign_moveit2/blob/ed4bbd3d27e7d487a3109a130301802ac9a338b4/panda_description/panda/model.sdf#L731

Hello @marc-wittwer,
Please run xacro2sdf.bash as mentioned in panda_description/README.md.
Alternatively, run .git_hooks/pre-commit_convert_xacros.bash, which makes sure that URDF and SRDF are also updated (both should be fine though).

Thanks. I did miss that step.


default debug.log location?

Not specifically an issue but adding this now while It's cropped up again...
Is there any reason why the default debug file location is /tmp/debug.log and not the error_logs folder inside the XOT install directory? e.g. error_logs/debug.log
Or should I say is there any reason why it shouldn't be the latter by default?
I know debugging isn't turned on by default but when it is turned on by someone trying to troubleshoot an issue, in at least some case like shared hosting, or restricted access, they won't have access to the /tmp folder but are more likely to have access to the error_logs folder.
Also as far as I can see storing debug.log in the error_logs folder provides access to view the errors and also delete the debug.log via management whereas it doesn't seem to show when set to the default location - at least not according to my xampp test.
Might help to change this and make it part of 3.5 to help troubleshooting when people upgrade?

Sounds like a good idea to me...

Thanks @JohnSmith-LT I've committed this simple change. @torinfo if there's a reason not to change this please just revert back.

No. That's fine.


Add tool to make citation & mention history plots

This is copied from https://github.com/keflavich/astropy-graphs/, which was an old fork of the earliest version of this repo.  I'll add some examples to this PR.

Those figures were missing 2018, which is the first year astropy>IDL


Add osx-arm64

Checklist

[ ] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

@conda-forge-admin, please rerender

1.23.4 is the first NumPy release with Python 3.11 support

@conda-forge-admin, please rerender


node.get_name() from every Richtextlabel is not the text in my scene and get_class() = nil

Godot version
3.4.4
System information
macOS 12.3
Issue description
Hello,
when I normally call get_name for a node, I get the name entered in the scene. With RichtextLabel I only get a @@ and a number (@@1). Furthermore, I do not get a return value when I call get_class().
Shouldn't the name be output by RichtextLabel or is that an error?
translate_tree(get_tree().get_root())
func translate_tree(node):
		for N in node.get_children():
			if N.get_child_count() > 0:
				#print("["+N.get_name()+"]")
				self.translate_tree(N)
			else:
				print("- "+N.get_name())
				print(N.get_class())

Output example:
Node

TextureRect
TextureRect
img
TextureRect
Sprite
Sprite
ColorRect
ColorRect
@@5
VScrollBar
btn_last_cat
Button
@@6
Timer
@@7
Timer
@@8
Timer
TextureRect

Steps to reproduce
Create a Richtextlabel in your scene
use the function node.get_class() or node.get_name()
Minimal reproduction project
No response

@NeroNekro Please upload a minimal reproduction project to make this easier to troubleshoot.
Also, remember that RichTextLabel has an internal ScrollContainer node as a child.

The translate_tree() function print the deepest child nodes. If uncomment that print line, RichTextLabel will appear.

The translate_tree() function print the deepest child nodes. If uncomment that print line, RichTextLabel will appear.

Yes, my fault. I did not think about it.


XORG_COMPONENTS=xft needs build dep of fontconfig:dev

this should be handled at the ports level

and it's been done there (at the ports level)


is yarn any faster?

Changes

Maybe switch to yarn since it's the way things are going.
Checklist

[x] Added markup tests, or they don't apply here because...
[x] Updated the changelog at CHANGES.md
[x] Added myself to AUTHORS.txt, under Contributors

Why was this closed? Was yarn not much faster? As you said it seems to be the way things are going, plus if someone comes along in future and asks the same question it would be good to document why you opted not to switch.

Was yarn not much faster?

Was slower, but could be margin of error... definitely nothing worth writing home about.

As you said it seems to be the way things are going

I just read another article that said the opposite so since there was no pressing reason to do this I closed the issue.


Repeatedly building docker images on regular nodes

Steps taken/Steps to reproduce
Steps:

Start nodeA (authorized node)

Add nodeA as authorized node
xuefeihan@xuefeih-mac pyrsia %./target/debug/pyrsia authorize --peer 12D3KooWFz7xbGccWoN4HsEY8yH8QUj6GSPqcJTimwayYjNykeEq

Start nodeB (regular node)

Build the docker image alpine:3.16.100 on nodeA
xuefeihan@xuefeih-mac pyrsia % ./target/debug/pyrsia build docker --image alpine:3.16.100
Build request successfully handled. Build with ID 6cae08b2-68d5-4446-809e-ed24517eb829 has been started.
xuefeihan@xuefeih-mac pyrsia % ./target/debug/pyrsia inspect-log docker --image alpine:3.16.100
[
  {
"artifact_hash": "c766482b8dac037b60a137701852f3710c01f6ae2c21feeb3334aa77c559a108",
"artifact_id": "b8297f68-34fa-4907-87c0-593ee5ce8662",
"id": "8d0fc966-3156-4933-8838-62ba57fd99be",
"node_id": "0373d0a1-8bb3-482d-8479-9bf6e4b4f207",
"node_public_key": "6150ad04-0442-4bf0-8d27-206e49b2ab97",
"num_artifacts": 3,
"operation": "AddArtifact",
"package_specific_artifact_id": "alpine:3.16.100",
"package_specific_id": "alpine:3.16.100",
"package_type": "Docker",
"source_hash": "",
"source_id": "0cab8763-272e-4b75-bc54-cc1b1b57e457",
"timestamp":<PHONE_NUMBER>
  },
  {
"artifact_hash": "c766482b8dac037b60a137701852f3710c01f6ae2c21feeb3334aa77c559a108",
"artifact_id": "0398cd6e-f2c3-4986-aa82-6f1860013821",
"id": "43a0b721-033f-4a9a-8257-8c04bf0920e6",
"node_id": "d545c1fe-d754-4b82-9840-7a5215aa1172",
"node_public_key": "ba262fc1-a6d2-4384-959b-53aa15036535",
"num_artifacts": 3,
"operation": "AddArtifact",
"package_specific_artifact_id": "alpine@sha256:c766482b8dac037b60a137701852f3710c01f6ae2c21feeb3334aa77c559a108",
"package_specific_id": "alpine:3.16.100",
"package_type": "Docker",
"source_hash": "",
"source_id": "0dbcc1a0-6510-4eae-ae1e-494498a9d641",
"timestamp":<PHONE_NUMBER>
  },
  {
"artifact_hash": "b16e15764b8bc06c5c3f9f19bc8b99fa48e7894aa5a6ccdad65da49bbf564793",
"artifact_id": "a70fab9f-5c15-4dd4-abcb-b6c7f35c7fb2",
"id": "1270ba39-6062-49bc-9b65-3a12bac70e99",
"node_id": "3873d32b-2239-4a37-a592-1847a9844593",
"node_public_key": "00d0bacb-5bf6-42ed-8949-e17a25d63583",
"num_artifacts": 3,
"operation": "AddArtifact",
"package_specific_artifact_id": "alpine@null",
"package_specific_id": "alpine:3.16.100",
"package_type": "Docker",
"source_hash": "",
"source_id": "789cbe9c-f85c-4dab-8823-6a4824a34f46",
"timestamp":<PHONE_NUMBER>
  }
]

Build the docker image alpine:3.16.100 on nodeA again, and an error is reported. Now everything is normal.
xuefeihan@xuefeih-mac pyrsia % ./target/debug/pyrsia build docker --image alpine:3.16.100
Build request failed with error: HTTP status client error (400 Bad Request) for url (http://localhost:7889/build/docker)

config CLI to node B

Build the docker image alpine: 3.16.100 on nodeB again, which is successful. It should report errors. Repeatedly building the docker image
xuefeihan@xuefeih-mac pyrsia % ./target/debug/pyrsia build docker --image alpine:3.16.100
Build request successfully handled. Build with ID 1 has been started.
xuefeihan@xuefeih-mac pyrsia % ./target/debug/pyrsia build docker --image alpine:3.16.100
Build request successfully handled. Build with ID 2 has been started.

Expected Behavior
The same docker image can only be built once on authorized nodes and regular nodes.
Experienced Instance of the bug
rustc 1.63.0 (4b91a6ea7 2022-08-08)
Pyrsia 0.2.0(commit 77bfd6d5b64aa35e85bf3ac6e927673ef213a9ab)

@fishseabowl I just tested this and it does work as expected. It was fixed in #1215 which was merged in https://github.com/pyrsia/pyrsia/commit/1f8da9cc16cda34271249c961bfde3538eabb1ee just after the commit you referred to.
maybe you can verify as well, so we can close this issue?

@erwin1 The issue is still here.  Please double check it.
The steps to reproduce are as follows:

Run nodeA (authorized node)

  xuefeihan@xuefeih-mac nodeA % RUST_LOG=pyrsia=debug DEV_MODE=on \
  ./pyrsia_node --pipeline-service-endpoint http://localhost:8080 -p 7889 --listen-only --init-blockchain

Run build pipeline prototype

  xuefeihan@xuefeih-mac pyrsia_build_pipeline_prototype %RUST_LOG=debug cargo run

Add nodeA as authorized node

  xuefeihan@xuefeih-mac pyrsia %./target/debug/pyrsia authorize --peer
  12D3KooWHjSr3b9Ucy9ZqHGq2T9r8oQmxL17DXu4uXqkc3pQJNAW

Run nodeB (regular node)

  xuefeihan@xuefeih-mac nodeB % RUST_LOG=pyrsia=debug DEV_MODE=on \
  ./pyrsia_node --peer /ip4/<IP_ADDRESS>/tcp/52309/p2p/12D3KooWHjSr3b9Ucy9ZqHGq2T9r8oQmxL17DXu4uXqkc3pQJNAW

Build the docker image alpine:3.16.1 on nodeA(config port to 7889)

  xuefeihan@xuefeih-mac pyrsia % ./target/debug/pyrsia build docker --image alpine:3.16.1
  Build request successfully handled. Build with ID 189a0fbe-b9dc-4b02-8304-8651cbfb69b5 has been started.

Build the docker image alpine:3.16.1 on nodeA again, and an error is reported. Now everything is normal.

  xuefeihan@xuefeih-mac pyrsia % ./target/debug/pyrsia build docker --image alpine:3.16.1
  Build request failed with error: HTTP status client error (400 Bad Request) for url (http://localhost:7889/build/docker)

Config Pyrsia CLI to node B(config port to 7888)
Build the docker image alpine: 3.16.1 on nodeB, which is successful. It should report an error like Step 6.

 xuefeihan@xuefeih-mac pyrsia % ./target/debug/pyrsia build docker --image alpine:3.16.1
 Build request successfully handled. Build with ID 1 has been started.

 My output at step 8 is:
./pyrsia build docker --image alpine:3.16.1
Build request failed with error: HTTP status client error (400 Bad Request) for url (http://localhost:7888/build/docker)

while I see this in the node B logs
DEBUG pyrsia::docker::error_util           > Rejection: Rejection(RegistryError { code: BadRequest("Failed to start a build: ArtifactAlreadyExists { package_type: Docker, package_specific_id: \"alpine:3.16.1\" }") })

The most obvious reason this would happen is that node B didn't receive the blocks for the publication of the artifact you're trying to build. Is there anything in your node B logs that can help?
Also, before doing step 8, try to run:
./pyrsia inspect-log docker --image alpine:3.16.1

to check if the artifact is present in the transparency log.

Closed due to fix


JavaScript Library to parse rules in human readable format

Hi
We have used SpELRuleFactory to load rules from Json.
Our requirement is :

Show all rules to users in our web ui.
Business users and update rule directly from web ui and convert the update to Json format.

How can we achieve this ?

Hi, in my company, I  stored rules data (JSON) on MySQL (mongo is ok too) and cached them to Redis or LocalJVM cache.

We're doing that at my company. It may not be a perfect match, but we are using jsep. Here's the proof of concept I did on parsing it out.


Use new boot ConfigData framework

Bootstrap is now opt-in.
See #608 for original motivation.
Remaining issues

[ ] documentation updates.
[X] remove org.springframework.boot classes that are hacks
[ ] fix FIXME: legacy issues. Mostly disabled tests.
[X] Deprecate bootstrap? make bootsrap opt-in

If you review post-merge, not a problem, I can address issues later since this is just a milestone.

@spencergibb - Hey we have a library which provides a custom property source for bootstrap configuration when users add our starter dependency to their project.
Is bootstrap property sources being deprecated or is there an alternate way to access this feature? We are also wondering if we should instruct users that they should add spring.config.use-legacy-processing=true to their application.properties now or if we might be able to set the property to true in our starter dependency by default somehow.

Because bootstrapping is now, my client no longer connects to the config server (bootstrap properties with config server uri are no longer read).
Adding: "spring.cloud.bootstrap.enabled=true" to the application.properties does not help. When this property is evaluated (BootstrapApplicationListener.onApplicationEvent), using "Environment.getProperty()", it is always empty...
Same for property "spring.config.use-legacy-processing".
Putting these properties in bootstrap.properties does not make sense because it will not be read, but putting them in application.properties also does not work, what should be done here?
Also I see there is a way of bootstrapping if the  "org.springframework.cloud.bootstrap.marker.Marker" class is present, but it is not in the dependencies I have... (are you supposed to create it yourself?)
What is they new/correct way to have the client now about and connect to the config server after these changes?
I used the spring initializr to create the project with spring boot 2.4.0 (gradle). Only dependency was the "spring could config client", which was version "2020.0.0-M5".

@ruben056 see the documentation
https://docs.spring.io/spring-cloud-config/docs/3.0.0-M5/reference/html/#config-first-bootstrap

It must be set as a System Property or environment variable.

@ryanjbaxter Thx for the info, I was looking at the "older" docs I guess (https://cloud.spring.io/spring-cloud-config/multi/multi__spring_cloud_config_client.html)

@ruben056 - I think instead of setting the properties you can try using the new spring-cloud-starter-bootstrap to enable bootstrap; see: https://github.com/spring-cloud/spring-cloud-release/wiki/Spring-Cloud-2020.0-Release-Notes#breaking-changes
Adding this dependency to your project should have the equivalent effect of using spring.config.use-legacy-processing. I think for most applications its not practical to use the system property/environment variable route.
I think the "preferred" style is to migrate to the new spring.config.import style that is also discussed in the link. Think this should be in the new docs for config server.


Application error: a client-side exception has occurred (see the browser console for more information). when open localhost:3000

Hello,
I got error below after following your instructions in README when open localhost:3000. As I'm new to dagster, would you please help to check for me?
Thanks so much.

Hi @rennlan.
Thank you for your message. Can you please provide more details?

what OS and browser are you using?
can you post a screenshot of the console (where you ran docker compose) depicting the error

Best regards