onClick cannot be triggered using continuePropagation

Provide a general summary of the issue here
onClick should be able to be triggered on parent but it is not, calling the e.continuePropagation does not change the parent onClick to be able to be triggered.
🤔 Expected Behavior?
onClick should be able to be triggered on parent
😯 Current Behavior
onClick is not triggered on parent when clicking a child onPress or onPressStart with continuePropagation.
💁 Possible Solution
No response
🔦 Context
No response
🖥 Steps to Reproduce
https://codesandbox.io/p/sandbox/pensive-monad-vp8yp2?file=%2Fsrc%2FApp.js%3A25%2C17
Version

What browsers are you seeing the problem on?
Chrome
If other, please specify.
No response
What operating system are you using?
Mac
🧢 Your Company/Team
No response
🕷 Tracking Issue
No response

onClick is not triggered on parent when clicking a child onPress or onPressStart with continuePropagation.

As far as I can tell, only PressEvent handlers of the parent (a 'pressable' component, using usePress()) see the propagated event when PressEvent.continuePropagation() is called in the child (again, a 'pressable' component, using usePress()):
https://github.com/adobe/react-spectrum/blob/b2c9961586795542603b899a1e1925cbeee9f34f/packages/%40react-aria/interactions/test/usePress.test.js#L2896-L2921
The description of continuePropagation() also seems to say a similar thing:
https://github.com/adobe/react-spectrum/blob/b2c9961586795542603b899a1e1925cbeee9f34f/packages/%40react-types/shared/src/events.d.ts#L48-L53

onClick is not triggered on parent when clicking a child onPress or onPressStart with continuePropagation.

As far as I can tell, only PressEvent handlers of the parent (a 'pressable' component, using usePress()) see the propagated event when PressEvent.continuePropagation() is called in the child (again, a 'pressable' component, using usePress()):

This is a major issue since you might have third-party libraries that apply event listeners on wrapping components, that ain't a PressEvent (like MouseEvent), expecting the event to propagate.
Right now it's impossible to prevent the propagation from being stopped in those cases which totally breaks the other library, in our case, hotjar (https://help.hotjar.com/hc/en-us/articles/7053232973975-Heatmap-Data-Troubleshooting).

Related: I'm seeing this in the context of a Checkbox, where a press sometimes makes it through to the parent component when using tap-to-click on a trackpad, but not consistently. Tap-to-click the "Test" button a bunch of times here and eventually you'll see a state change:
https://codesandbox.io/p/sandbox/trusting-night-9q9824
https://github.com/adobe/react-spectrum/assets/13100/c8c459c3-a061-42fb-b097-4f3cadb2487d

Also, If I'm not mistaken, there doesn't seem to be a way to continue propagation for the onClick?
https://github.com/adobe/react-spectrum/blob/b2c9961586795542603b899a1e1925cbeee9f34f/packages/%40react-aria/interactions/src/usePress.ts#L303
UNLESS the event is virtual (Keyboards, Assistive Technologies, and element.click())
I want to be able to continuePropagation for normal mouse click as well.
In my example I have a 3rd party component that is inside a list item that is implemented via usePress. I can't interact with the 3rd party element via mouse click, because the propagation is stopped by the list item.

If your component is inside the one using usePress, then propagation shouldn't matter? We're not using a capturing listener, so your 3rd party component would get the event first wouldn't it?

@snowystinger, in my case, my component that has the onClick handler IS the parent of a Button (the react-aria-components  Button). I am building a platform similar to Webflow that allows people to change the styles of the selected elements on the page.
I have an onClick handler on the main parent element (just a div) and I use the event.target property to get the element the user clicked on/selected. The react-aria-components Button cannot be selected because the main parent onClick handler doesn't get triggered even if I use the .continuePropagation() method. I said: "OK, maybe I need to use the usePress hook on the parent element too".
What's worse is that I can't even use the usePress hook to attach the onPress event handler to my main parent div because the event.target property is always that main div. It's not the actual clicked element on the page. The normal browser onClick event.target returns the actual clicked element.
Here is a code example. Go an click on each paragraph and buttons on the page and watch the logs:

when clicking on a react-aria-components Button, there isn't an event triggered event if I use .continuePropagation() and even if the parent is using the usePress hook
when clicking any other element in the parent container, the onPress event.target doesn't return the clicked element just like the normal onClick event does. It always returns the element the onPress was attached to

https://codesandbox.io/p/devbox/toggle-button-react-aria-forked-ckh7fd?file=%2Fsrc%2FApp.jsx%3A34%2C1&welcome=true

The codesandbox is private, you'll need to make it public.
However, from looking at the screenshot you provided, continuePropagation just isn't being called in enough places. This is a pretty advanced use case and is not generally recommended as it may have unintended consequences. For instance, if you place a Button inside a Table, the press should be handled by the button, not the cell or row containing it.
In order to continuePropagation, you need to continue it on ALL press events, including Start and End.

@snowystinger, I just made the codesandbox public and also added the onPressStart and onPressEnd handlers: https://codesandbox.io/p/devbox/toggle-button-react-aria-forked-ckh7fd?file=%2Fsrc%2FApp.jsx%3A23%2C28&welcome=true
It seems it now correctly propagates the event up. But I still have an issue: The parent onPress handler doesn't correctly return the clicked target. Check the logs in the 1st and 3rd example in the codesandbox. I get the Div element instead of getting the clicked paragraph or the clicked button
The browser's onClick handler returns the clicked element, not the element that has the onClick handler attached.
I have this platform I am building where users can click anywhere on the page to "select" an element and then change its styles? The only way I could do this is with an onClick handler added to the main container of the page and then using event.target to get the clicked element.

PS. What is the reasoning for "In order to continuePropagation, you need to continue it on ALL press events, including Start and End."? Why not just onPress?

It has to do with how browsers work; if you stop events earlier in the chain, the actual browser onClick event will not fire. So you have to continue them all.
This shouldn't be a common thing to need to do. Attaching a click to the entire page will miss potentially many events from keyboard/assistive technology/touch and even mouse users. Many libraries will stop events, so it's not good to rely on an event that can be stopped so easily.
Instead, if you need to guarantee that you handle an event, I'd recommend looking into capture phase listeners for pointerdown/keydown. There are some other discussions in the repo about this with regard to 3rd party analytics libraries. I suggest having a search for those, it may help your use case as well.
Out of curiosity, why do you need the other target? can you usePress on that element? seems more React like and it'll prevent potential double/multiple handling. Or it sounds like you shouldn't be using usePress in this scenario?

Out of curiosity, why do you need the other target? can you usePress on that element? seems more React like and it'll prevent potential double/multiple handling. Or it sounds like you shouldn't be using usePress in this scenario?

@snowystinger, imagine you are using my platform to edit some React components or pages that you have in your project.  You open your page (by selecting the YourPage.tsx file) and it will be rendered on the platform (imagine Wix website builder or Webflow). Then, you can click on any element on your page that you want to change the styles for. You can have anything on your page: headings, paragraphs, buttons, divs etc.
To have this "click on anything to change styles" feature I can have one big event handler added to the container that has you page's HTML OR I can iterate over every element on your page and manually adding the onClick event handler on them (or maybe onPress events!?). The 2nd option sounds tedious and that's why I want one main click handler.
Now, you may say: "looks like your platform is pretty advanced and you are better off not using react aria for this. You should only use simple React and Javascript events because you have more control".
Well, I tried. I added the onClick event on the main parent and it works perfectly the way I described above, but only for normal HTML elements. The problem is this: if you have react-aria buttons on your page (or drag&drop a new button from the platform's built-in components which are react-aria buttons) and try to select them by clicking on them, they don't trigger to the native onClick handlers on the parent because react aria doesn't propagate the event up. (and they also don't react on the onClick events. I have to have the onPress on the parent)
One solution is to not have react aria components in the platform's built-in components and use something else all together. 😞  But this is not ideal because you, as a user, might want to use anything that is available: radix, tailwind UI, material UI, react-aria etc.
I really don't know how to solve this for react-aria components. I really want users to have anything on the page that they can select. Seems like the tedious solution described above might be the way to go... 😞

I think I understand your usecase better now. I would say you're trying to force React Aria to be something that it isn't.
 This directly conflicts with the roles and behaviors components may have.
I imagine that you'll want to be able to drag the components around after initially dropping them as well.
This falls into some categories of discussions that have come up recently. Given that everything is just buttons so you can drag them or open a popover from them, the component is really just a visual representation, not the actual functionality of the component. If you have a toggle between the edit mode and a preview mode, an option you have is you can swap out for the real ones at that time.
Another possibility would be to wrap each component in inert or something like this https://jsfiddle.net/bekuqamj/3/
Or you could add an overlay on top of your entire application to intercept events, or you can use capture phase on pointer events/keyboard events.
Keep in mind that our components are meant to be interacted with only in the way their roles dictate.
I'm going to close this issue as continue propagation can be achieved.
Also, responding to another comment above https://github.com/adobe/react-spectrum/issues/6267#issuecomment-2089083707
This is an invalid configuration, you cannot have a button inside a checkbox or label. Please position the button outside and next to the checkbox.


Fix login bug with irregular setstate

Warning: Cannot update a component (BrowserRouter) while rendering a different component (AuthenticationHandler). To locate the bad setState() call inside AuthenticationHandler, follow the stack trace as described in https://reactjs.org/link/setstate-in

Fixed in commit: https://github.com/psyrus/home-expenses-frontend/commit/97c7a7572bfa705eacff53ea5f069f1713f4d43d


Micronaut Framework

Hi guys, I started the real world backend example implementation using Micronaut framework: https://github.com/mirjahal/micronaut-realworld-example-app
Coming soon i update the README.md file with more information about the project.
@Cameron-C-Chapman @anishkny please, could set the labels backend and wip?
Thanks!

Hey @mirjahal
I was writing the same in the parallel universe. Can collaborate!
https://github.com/akamanocha/micronaut-realworld-example-app


RBAC delete functionality

I've added a tabbed page to display a filtered list of RBAC roles. Now users need the ability to delete a role per the mocks below.
Mocks: https://marvelapp.com/icccbi9/screen/60981818
Notes:

There won't be an edit option in the kebab, only delete
The delete option should be disabled unless there is exactly one policy

Created PR here https://github.com/RedHatInsights/insights-rbac-ui/pull/46

This feature has been merged


Add init to a uninitialized variable to resolve the check failure.

Description
To resolve the error:
https://maxis-file-service-prod-pdx.pdx.proxy.amazon.com/issues/P44273277/attachments/ec8ee721b460c4f96765ea95ae4261a2ff4c81e791a25dc72e50f459054e60db_c139b02e-130e-42d4-bed2-dff2a8072d12
Checklist:

[x] I have tested my changes. No regression in existing tests.
[x] My code is Linted.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/bot run checks


Export .obf not working

As in the title, I tried to use the export tool for integration in OSMAnd (.obf) but this didn't work : for my export I only got buildings extracted AND only the ones from a long time ago. No roads or POI included.
How can we move forward? If anyone is interested in the development, I / CartONG could help on the process as we set up it for a specific project.
Thks

Changed it to always show Data tab, even if only .obf is selected


Do you have any other inventory managing plugins, like a per-world inventory or backpack plugin?
I don't think this will happen with just Magic alone, I can't reproduce it myself and no one else has reported it.


Background Calculations

Merge existing distances_v3 branch to master (different from PR #1066 ). Closes issue #954 andd #408

I will check it today, sorry I was very busy yesterday. thanks for this, much obliged!

I will check it today, sorry I was very busy yesterday. thanks for this, much obliged!

No worries. Take your time. And the correct PR is #1149 . This one is closed because I don't want to modify the original distances_v3 branch.


why new repo?

may I know the reason for the new repository?

You're kinda right, it's the main idea of branches but who really cares?

After actively developing bootstrap-select for over 5 and a half years and writing close to 30,000 lines of code, I wanted full control of the project to ensure I could take it in the right direction. I also wanted the ability to add collaborators and update the project's description, as well as adjust other repository settings without having to always contact Silvio, thus speeding up development.
Seeing as Silvio hasn't shown much interest in the project the past 5 years, I was hoping he would be willing to transfer ownership to me to simplify things and ease the transition for the community. He has his reasons for not wanting to do that, though, so I opted to fork the original repository and continue my development here.


Xt/test diopi pytorch2.0

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.0 out of 2 committers have signed the CLA.:x: wey-code:x: xintian-514You have signed the CLA already but the status is still pending? Let us recheck it.


Integration Specs and  N + 1 Problem Fixing

Highlights

[ ] Write integration tests for views.
[ ] Solved the N+1 problem.

Below is an image of the test results

@cynthiainga Thank you for reviewing the project


Docker Not work

when i run this and try install docker on VSCode its installed but not working, is there anyway to fix this?

@DonMonro you will need to use udocker instead of docker. Here's how you can do it - https://stackoverflow.com/a/78282911/1305959

it's not full functionality and don't work in most expert usage
why you close this even ?

@DonMonro I've already provided a workaround, and that's through the use of udocker.

Chinese kids ...


[Extensibility] Protection level for TotalPurchaseLine on Page 55 "Purch. Invoice Subform"

Please set global variable "TotalPurchaseLine" in Page 55 "Purch. Invoice Subform" as protected variable. This variable saves the totals of the purchase document.
I would need this as a protected variable because I have a custom field in the "Purchase Invoice Subform" and currently I cannot know what the totals are for doing the calculation on my custom field.
Thank you

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.


Extracting onchain metadata info of native tokens from cardano db sync

Its not a bug. I am trying to get all the native tokens and NFTs with their metadata information using cardano dbsync. I found the assets name and policyID from ma_tx_mint and ma_tx_out joining with utxo_view but cannot find the metadata informations of those assets like the characteristics of the assets and url etc. Could someone help me?

It looks like there hasn't been any activity on this issue for a some time. We're closing it for now. If you're still experiencing this problem or have any updates, please reopen or create a new issue. Your feedback is valuable, thank you!


Proposal: Allow trailing commas in function argument list

TypeScript allows trailing commas in object definitions:
var obj = {
    key: 'value',
};

Proposal: Allow trailing commas in function argument list:
someFunction(argument,);

Why? Trailing commas in object definitions are great for convenience when editing lists:
{
    key1: 'val1',
    key2: 'val2',
    key3: 'val3',
};

Same is with functions, consider usage of Virtual Hypertext functions:
return (
    h('div', null,
        h('span', null, 'span 1'),
        h('span', null, 'span 1'),
        h('span', null, 'span 1'),
    )
);

#8942 ?

What am I missing here? If you try this on the Playground it already works. http://www.typescriptlang.org/play/#src=console.log(1%2C 2%2C )%3B

I get this in v1.8
TS1009:Trailing comma not allowed.

That's because jetbrains uses their own language service. In IntelliJ IDEA there's a setting to use the type script language service instead. I would definitely suggest that you investigate and see if this option is available in Webstorm as well.


Dev -> Prod

:tada: This PR is included in version 1.28.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


wine: 8.0 -> 8.0.1

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for wine is: An Open Source implementation of the Windows API on top of X, OpenGL, and Unix
meta.homepage for wine is: https://www.winehq.org/
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 8.0.1 with grep in /nix/store/b2brskdw738m0njx279bpvxlxn1flqis-wine-8.0.1
found 8.0.1 in filename of file in /nix/store/b2brskdw738m0njx279bpvxlxn1flqis-wine-8.0.1

Rebuild report (if merged into master) (click to expand)

38 total rebuild path(s)

38 package rebuild(s)

First fifty rebuilds by attrpath
exactaudiocopy
pipelight
playonlinux
q4wine
vkd3d
vkd3d-proton
wine
wine-staging
wine-wayland
wine64
wine64Packages.base
wine64Packages.fonts
wine64Packages.full
wine64Packages.minimal
wine64Packages.stable
wine64Packages.stableFull
wine64Packages.stagingFull
wine64Packages.unstableFull
wine64Packages.waylandFull
winePackages.base
winePackages.fonts
winePackages.full
winePackages.minimal
winePackages.stable
winePackages.stableFull
winePackages.stagingFull
winePackages.unstableFull
winePackages.waylandFull
wineWowPackages.base
wineWowPackages.fonts
wineWowPackages.full
wineWowPackages.minimal
wineWowPackages.stable
wineWowPackages.stableFull
wineWowPackages.stagingFull
wineWowPackages.unstableFull
wineWowPackages.waylandFull
wineasio

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/b2brskdw738m0njx279bpvxlxn1flqis-wine-8.0.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A wine https://github.com/r-ryantm/nixpkgs/archive/7ab00468a9f709165d987ac9fe14e758ab67d627.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/b2brskdw738m0njx279bpvxlxn1flqis-wine-8.0.1
ls -la /nix/store/b2brskdw738m0njx279bpvxlxn1flqis-wine-8.0.1/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
nixpkgs-review took longer than 45m and timed out

Maintainer pings
cc @avnik @7c6f434c @bendlas @jmc-figueira for testing.

This automatic update is incorrect, stable gecko should not be updated. Cf. first commit of https://github.com/NixOS/nixpkgs/pull/227785 .


Name module d3-scissors (or not)

var scissors = d3_scissors; // global variable

// setting up the generator accessors and other configuration
var cut = scissors.cut()
            .x(function(d) { return d.x; }) // point accessor
            .y(function(d) { return d.y; });

var P = [ ... ];
var Q = [ ... ];

// layout object (polygons, centroid, hinge points, etc.)
var layout = cut(P, Q);

// draw the cuts, transition cuts to their position in Q, etc.

If d3-chernoff exists, this can too.

Never knew about Chernoff faces.  This is almost the exact same idea I had with "Face Jam."  But apparently I got scooped in the '70s


Array example Caesar isn't well suited

it either requires loops or ranges (both haven't explained before)
it requires casting (or knowing how to omit that by defining to char variables)
it requires knowledge about ASCII (which we would at least have to explain)
it's non-idiomatic D, because we usually do stuff lazily

That being said, here's my "idiomatic" solution:
import std.array: array;
import std.algorithm: map;
return input.map!((x) => cast(char) (((x - 97) + shift) % 26 + 97)).array;

There definitely a solution for the array example using the result[] OP= ... syntax. I just don't have it anymore :-) So no need to use loops or any range operations. I agree it's a complicated example but I think it's nice to have some more advanced exercise. I liked that in the Gotour too.
But I noticed that another sentence is needed for the mathematical array operations that emphasises that those operations also possible with single values (like result[] -= 'a').
I'll post a solution when I got the time to re-invent it :-)

The solution without any ranges and loops:
char[] encrypt(char[] input, char shift)
{
    auto result = input.dup;
    result[] -= 'a';
    result[] += shift;
    result[] %= 26;
    result[] += 'a';
    return result;
}

I did it like this.
result[] = ((result[] - 'a' + shift) % 26) + 'a';
My first try was subtracting shift and failed because of that, but it works when shift is applied correctly.   I came here to check whether arr[] was valid on the RHS in that form of assignment and found my actual mistake.   :-)

None of these solutions work with EBCDIC input, because it has gaps between 'i' - 'j' and 'r' - 's'. My proposed solution would use an auto cipher = "abcdefghijklmnopqrstuvwxyz";. It would have to use a loop and only encrypt a result[i] if the character was in the cipher. It would then apply the shift to the cipher, but taking care that if the shift goes beyond 'z', it would subtract cipher.length to index from the a, and replace the result[i] with the corresponding letter from cipher.


Feat: Feature Request: Add Scraper Module for Bayt.com Job Listings

Describe the feature
develop a new module for scraping job listings from Bayt.com, which is the leading job site . This module should be capable of extracting detailed job information across various sectors and locations as specified on the website.
Add ScreenShots

Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSoC'24 contributor
[X] I want to work on this issue

Go ahead @msabry1
Note

Please create a separate module for this, as in the folder and project structure (if it is already created, just add your features as functions in the same module).
Do not use the `selenium web driver as it is incompatible with all devices and cloud platforms.
Before making any changes, please check whether the module you want to add exists. If yes, then you can add your functionality as a method only make a separate module and class for it.

All the best 👨💻


Upgrade Gdx Setup to generate projects using Gradle 8.3

Not to merge before #7246.
The only required change has been to remove the following line from the html module build.gradle as the property doesn't appear to exist on the latest GWT plugin version.
checkGwt.war = file("war")
Would be great if somebody could confirm how important this line is.

It isn't important; it was needed to do some verification task in an older Gradle/GWT-plugin version, but isn't needed now. Liftoff hasn't included that line for a while; it looks like I removed it 17 months ago.

By the way, it seems that the gwt-gradle-plugin has changed its package to  org.docstr: New PLugin Page (commit). So there's already version 1.1.29

I definitely agree about R8 full mode; it will be (or was just) set to disabled by default in new Liftoff projects because of how much trouble it causes during minimization. I still think we should update to Gradle 8.4, considering how infrequently gdx-setup updates.


Update lerna.json

Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

AWS CodeBuild CI Report

CodeBuild project: codebuildgithubautobuildPro-sdNVS2x9cuir
Commit ID: f496a147c1e936f5e9d9bd3b925c611d4969fd0c
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: codebuildgithubautobuildPro-HHah0H4kRcJ1
Commit ID: f496a147c1e936f5e9d9bd3b925c611d4969fd0c
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: codebuildgithubautobuildPro-ZQrYvg1Wv7BG
Commit ID: f496a147c1e936f5e9d9bd3b925c611d4969fd0c
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository


Use Builders for Commands

This should make commands be fully functional (subcommands, context menu commands, etc) and easier to implement. The unit tests should also be passing.

Also if ppl prefer it, the command builder can be easily inlined in the command files.

Also, is the .idea folder necessary? Seems like more clutter.

Also, is the .idea folder necessary? Seems like more clutter.

Is pretty much the same as the .vscode

Add your name to the list of developers in the README.

Is done (not sure why discord doesn't allow replying to comments that aren't attached to code)

You can delete the co-contributor note in the merge commit, and GitHub won't list them. Too late now though.

You... did contribute tho


[storage][stg73] added ORS

Skipping live tests for ors as it needs to set up two account and object replicate rules, which requires ARM tools.

/azp run js - storage-blob - tests

/azp run js - storage-blob - tests

/azp run js - storage-blob - tests

/azp run js - storage-blob - tests

/azp run js - storage-blob - tests

Will return list to align with other languages.


[FIX] return the latest batch data

A fix ensuring that the Batch returned to the user is the latest batch object fetched, and return the results when requested. This way the status of the batch and jobs will at least be shown as DONE, and not PENDING/RUNNING.
We suggest decoupling the wait and fetch_results when retrieving a batch. wait=True makes the python statement blocking but doesn't fetch the results by default while fetch_results=True implies wait=True and fetches and stores in memory the job results.
The underlying idea being, if a batch has many jobs fetching all the results might not be desirable and the user might want to implement  custom logic to fetch job results, e.g. only the last job of the batch if that's the one they care about.

Pending checking in e2e

Thanks for taking a look Matthieu. I'll update the PR description too now that this PR had a slight scope creep...
To be clear, we'd want to add the wait/fetch_results  behavior to Batch.add_job and Batch.declare_complete.

This change makes a lot of sense to me. Sorry for not reviewing it earlier! LGTM

@anneclairelh I updated the changelog let me know if we can merge this.

@anneclairelh I updated the changelog let me know if we can merge this.

LGTM!


Get Browser Catalog with assertion engine

Add assertion engine to Get Browser Catalog to allow easy python manipulations on the catalog.

fixed


Set targetframework for projectreference to another package

I have a package 'SilverlightOnlyPackage.nuproj' with silverlight target framework only and references to silverlight dependencies only. And I create a new package and reference this package to it. I want to set manually/automatic targetframework for this dependency. It seems that NuGet allows to do it - http://docs.nuget.org/create/nuspec-reference#specifying-dependencies
But I can't find the way to do it via NuProj.
I was trying
 <ItemGroup>
      <ProjectReference Include="..\NetFwOnlyPackage\NetFwOnlyPackage.nuproj">
          <TargetFramework>net451</TargetFramework>
      </ProjectReference>
      <ProjectReference Include="..\SilverightOnlyPackage\SilverightOnlyPackage.nuproj">
          <TargetFramework>sl5</TargetFramework>
      </ProjectReference>
  </ItemGroup>

But that's not work.

I assume your main package also contain .csproj references targeting different frameworks. Without package references you mentioned, the main package would also contain assemblies from dependency packages. Those dependencies would be in correct framework folder, probably something like:
lib\net451\NetFwOnlyPackage.dll
lib\net451\Main.dll
lib\sl5\SilverightOnlyPackage.dll
lib\sl5\Main.dll

What we need to change is dependency resolution behavior, so it would not lose TargetFramework metadata of removed assembly. Am I here on right track?

Hmm, I am not sure.
My goal here to have different dependent packages set for different platforms. I have one dependent package which contains only silverlight target platform, the result contains a package which depend on it, but without targetframework resolution. So if I try to add/install this  NuGet package to another *.csproj which targeting Framework 4.5.1 - I will get an error:

Could not install package 'SilverightOnlyPackage 1.0.0'. You are trying to install this package into a project that targets '.NETFramework,Version=v4.5.1', but the package does not contain any assembly references or content files that are compatible with that framework. For more information, contact the package author.

It's because the resulting package contains:
    <dependencies>
      <dependency id="NetFwOnlyPackage" version="1.0.0" />
      <dependency id="SilverightOnlyPackage" version="1.0.0" />
    </dependencies>

Example: https://github.com/AndirNotes/samples/tree/master/SilverightOnlyPackage

I think that problem here (see code below, https://github.com/nuproj/nuproj/blob/master/src/NuProj.Targets/NuProj.targets#L732).
<!-- Get files that are library and have assigned target framework (so no debug symbols files). -->
      <_DependencyFile Include="@(File)"
                       Condition="'%(File.PackageDirectory)' == 'Lib'
                         and '%(File.TargetFramework)' != ''
                         and '%(File.NuProjPackageId)' == '%(NuProjDependency.Identity)'"/>

     <_NuProjDependency Include="@(NuProjDependency)">
        <TargetFramework>%(_DependencyFile.TargetFramework)</TargetFramework>
      </_NuProjDependency>

It tries to find some library file in the package, and if it can't find anything, it just removes targetframework from projectreference.
I think NuProj should respect TargetFramework of dependencies. At least it should not override ProjectReference.TargetFramework in case it was set manually.
I suggest to fix it like:
<!-- Get files that are library and have assigned target framework (so no debug symbols files). -->
      <_DependencyFile Include="@(File)"
                       Condition="'%(File.PackageDirectory)' == 'Lib'
                         and '%(File.TargetFramework)' != ''
                         and '%(File.NuProjPackageId)' == '%(NuProjDependency.Identity)'"/>

       <_FilteredNuProjDependency Include="@(NuProjDependency)"
                                  Condition=" '%(TargetFramework)' == '' " />

      <_NuProjDependency Include="@(_FilteredNuProjDependency)">
        <TargetFramework>%(_DependencyFile.TargetFramework)</TargetFramework>
      </_NuProjDependency>

See pull request #103

The property <ReferringTargetFrameworkForProjectReferences> works well enough for what I need right now.


Errors Middleware + IngressRoute : Could not get Capture / value not found in context

Welcome!

[X] Yes, I've searched similar issues on GitHub and didn't find any.
[X] Yes, I've searched similar issues on the Traefik community forum and didn't find any.

What did you do?
I did enable middlewares on dashboard ingress route as available in Helm Chart :
https://github.com/traefik/traefik-helm-chart/blob/v28.3.0/traefik/values.yaml#L167
Something like:
        middlewares:
          - name: traefik-errors
            namespace: ingress-controller
          - name: traefik-forwardauth
            namespace: ingress-controller

However, every time I reach dashboard, I've a white page.
What did you see instead?
A white page and an error log instead of custom error page :
{
  "level": "debug",
  "middlewareName": "ingress-controller-traefik-forwardauth@kubernetescrd",
  "middlewareType": "CustomError",
  "time": "2024-06-17T19:08:38Z",
  "caller": "github.com/traefik/traefik/v3/pkg/middlewares/customerrors/custom_errors.go:87",
  "message": "Caught HTTP Status Code 401, returning error page"
}
{
  "level": "error",
  "service": "ingress-controller-traefik-errors-errorpage-service@kubernetescrd",
  "error": "value not found in context",
  "time": "2024-06-17T19:08:38Z",
  "caller": "github.com/traefik/traefik/v3/pkg/middlewares/metrics/metrics.go:147",
  "message": "Could not get Capture"
}

Disabling errors middleware, produces the expected result. It looks like issue is related to errors middleware.
Also, If I setup same middlewares on a Kubernetes Ingress with same domain and with a service redirecting to traefik port, I don't have the issue, everything is working as expected.
apiVersion: networking.k8s.io/v1
kind: Ingress
metadata:
  name: traefik-dashboard
  namespace: ingress-controller
  annotations:
    traefik.ingress.kubernetes.io/router.middlewares: ingress-controller-traefik-forwardauth@kubernetescrd,ingress-controller-traefik-errors@kubernetescrd
spec:
  ingressClassName: traefik
  tls:
    - hosts:
        - example.com
      secretName: example.com
  rules:
    - host: example.com
      http:
        paths:
          - path: /
            pathType: Prefix
            backend:
              service:
                name: traefik-traefik
                port:
                  number: 9000
---
apiVersion: v1
kind: Service
metadata:
  name: traefik-dashboard
  namespace: ingress-controller
spec:
  ports:
    - name: traefik
      protocol: TCP
      port: 9000
      targetPort: traefik
  selector:
    app.kubernetes.io/instance: traefik-ingress-controller
    app.kubernetes.io/name: traefik
  type: ClusterIP
  internalTrafficPolicy: Cluster

What version of Traefik are you using?
3.0.2
What is your environment & configuration?
# See middleware config above

Helm Chart
If applicable, please paste the log output in DEBUG level
See below

Could you please provide a simple repro? I’d like to tackle this.

Could you please provide a simple repro? I’d like to tackle this.

Hi @hood,
Thanks for checking this issue. Yes sure. I did simplify code. You can reproduce with this docker-compose. If you try to open traefik.localhost you should get the error (and so white page).
Please note that removing  '--metrics.prometheus=true' arg does not reproduce the issue.
services:

  traefik:
    image: "traefik:v3.0.2"
    container_name: "traefik"
    command:
      - "--log.level=DEBUG"
      - "--api.insecure=true"
      - "--providers.docker=true"
      - "--providers.docker.exposedbydefault=false"
      - "--entryPoints.web.address=:80"
      - '--accesslog=true'
      - '--ping=true'
      - '--metrics.prometheus=true'

    ports:
      - "80:80"
      - "8080:8080"
    volumes:
      - "/var/run/docker.sock:/var/run/docker.sock:ro"
    labels:
      - "traefik.enable=true"
      - "traefik.http.routers.dashboard.rule=Host(`traefik.localhost`) && PathPrefix(`/`)"
      - "traefik.http.routers.dashboard.service=api@internal"
      - "traefik.http.routers.dashboard.middlewares=testErrors@docker,testForwardAuth@docker"
      - "traefik.http.middlewares.testForwardAuth.forwardauth.address=https://api.github.com/user/emails"
      - "traefik.http.middlewares.testForwardAuth.forwardauth.trustForwardHeader=true"
      - "traefik.http.middlewares.testForwardAuth.forwardauth.authResponseHeaders=Authorization"
      - "traefik.http.middlewares.testErrors.errors.status=401-403"
      - "traefik.http.middlewares.testErrors.errors.service=whoami"
      - "traefik.http.middlewares.testErrors.errors.query=/?rd={url}"

  whoami:
    image: "traefik/whoami"
    container_name: "whoami"
    labels:
      - "traefik.enable=true"
      - "traefik.http.routers.whoami.rule=Host(`whoami.localhost`)"
      - "traefik.http.routers.whoami.entrypoints=web"
      - "traefik.http.services.whoami.loadbalancer.server.port=80"

HI guys.
I have the same problem. was there any workaround?

I see the same problem in my logs.

Try setting metrics.addInternals to true in the Helm chart.

Hey folks,
Thanks for your feedback.
If any community member can help us to move forward in fixing the issue, we would love the help.

Try setting metrics.addInternals to true in the Helm chart.

thanks, it seems to work

Closed by #11058

@rtribotte It seems it is not fixed with Traefik on Docker, as I might be getting the same issue. The service works few seconds after start of Traefik and then I am getting blank page and to make it work I needed to specify the service in each container.
I am on Traefik 3.1.2 using on Docker and using @huttotw solution and setting metrics.addInternals to true fixes this error for me.

Hello @Maypul, the fix hasn't been released yet, but should be in v3.1.3 soon.


Adding localisation support for content management

This is interesting @medfoxio! Let me know what you need in case you reopen this one

@arjayosma  I've included localization to manage the product. Here's the new pull request (PR).
https://github.com/medfoxio/nextacular-copy/pull/1


Core: Support multiple nested modules hooks properly

As discussed in #1047:

Modules currently have a childModule property, this contains a reference to a single module. This likely means that modules with multiple nested children are broken. We should fix that.

Left a few comments, but this looks pretty good to me and I'm not sure any immediate changes are needed.

The discussion is interesting but there is no blocker to merge this. I'm +1 to this too.


CIV-14008 GA Lip Hwf

JIRA link (if applicable)
https://tools.hmcts.net/jira/browse/CIV-14008
Change description
Testing branch and instruction
Does this PR introduce a breaking change? (check one with "x")
[ ] Yes
[ ] No

part of ga_lip_bulk branch


AWS v15.3.0 release

ℹ Team Firecracker is drafting AWS v15.3.0 release to provide updates for various components.
Target release date: TBD
Release PR: TBD
Scope
TBD
Pre-Release

[ ] Create release ticket on Releases board
[ ] Make an announcement on #sig-product that team is doing a release. Include a link to the ticket from the release board.
[ ] Make sure release was tested by creating new cluster, upgrading from older version and with HelloWorld app.
[ ] Aggregate release notes from all changed components and add to README.md in the release directory.
[ ] Send draft release announcement to #sig-product for review ASAP.
[ ] Verify documentation is up to date.

Releasing

[ ] Create release PR
Instructions

[ ] Define new release in release.yaml file.
[ ] Activate new release by setting state to active.
[ ] Deactivate old release if it's within same major version (state: deprecated). Verify with PO if you have doubts.
[ ] Check versions of all components included. They shouldn't be lower than those in the previous release unless there was a rollback.

Example PR

[ ] Release relevant operators.

[ ] Tag release branch.
[ ] Bump operator version in draft release.

[ ] Make sure that WIP releases in releases repo branch are removed and not merged to master since the master branch is deployed automatically after merging PR and that would make WIP releases visible in customers’ installations which should generally not happen.

Post-Release

[ ] Update front-end cluster with the new release.
[ ] Verify release is available on all installations. You can use this script.
[ ] Send out release announcement to all customers according to these instructions.
[ ] PO subscribes to release posts on Slack to get notifications if there are follow-up messages.
[ ] Close release task on Releases board.

We are currently working on AWS v17.0.0 and so far there hasn't been any need for this release.


Ghost Style not working as expected.

Code:

1

2

            p>3

4

5

6

/* CSS */
body
{
    background-color: grey;
}

ul
{
    list-style: none;
}

li
{
    width: 100px;
    color: white;
    background-color: purple;
    padding: 0 .5em;
}

// JS
const Sortable = require('sortable-dnd');

new Sortable(
    document.getElementById('group'),
    {
        ghostStyle:
        {
            display: 'none'
        }
    }
);

(I'm using this code in a Node environment)
So, basically I want to hide the ghost element completely using the style display: none; property, like this.
But unfortunately it looks something like this.
Is there any possible solution for this ?

@biologyscience
Sorry to reply so late, I forgot to add styles on dragImage, i'll fix it as soon as possible

oh ok 👍

@biologyscience
This issue has been fixed in version 0.3.4, you can try it again.

Awesome! It does work (the background color is no more visible), but apparently the text inside of it is still visible.
Any possible solution for it ?
PS: I think its the default behavior of HTML and CSS 🤔

Awesome! It does work (the background color is no more visible), but apparently the text inside of it is still visible. Any possible solution for it ?
PS: I think its the default behavior of HTML and CSS 🤔

what it looks like, my local test looks like it's all hidden


Support for Postgres Transaction

Signed-off-by: David<EMAIL_ADDRESS>
What problem does this PR solve?
Issue #20
What is changed and how it works?
Added support for "BEGIN READ WRITE" and "BEGIN READ ONLY"
light reformatting by go-formatter

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Codecov Report

Merging #22 (d57ac30) into main (4b66d3f) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #22   +/-   ##
=======================================
  Coverage   89.85%   89.85%
=======================================
  Files           7        7
  Lines        6513     6518    +5
=======================================
+ Hits         5852     5857    +5
  Misses        556      556
  Partials      105      105

need some test cases?

I have added some under parser_test.go/TestStartTransaction


Backward compatibility issue on InMemoryJobCatalog

Recent introduce of MutableJobCatalogBase.java seems brought a behavior change on put method in InMemoryJobCatalog.java  where it didn't check the state as running before.
https://github.com/linkedin/gobblin/commit/e3ee3f7ca219eb98486f0dfb6949d212271cef38#diff-8a524d0e4d3e6070855d294a53dc5c7fR52
@ibuenros Could you take a look and see if it can skip checking the state in put method? It currently breaks li-gobblin unit test.

Confirmed that there's no problem with latest version of li-gobblin. Closing the issue.


solved #180

@vishalkharge  please review and verify this PR in the deployment preview.

@vincentsong
When the viewer app is opened with the below URL[just streamAccountID and not streamName], it still shows the Try Again Page.
https://dp-187--cosmic-dango-2cc8f7.netlify.app/?streamAccountId=KtpPTK


Question about Draggable widget with ExpansionTile child

I want to achieve only the ExpansionTile's title to be draggable not it's children.
Here is a simple code sample of what I am trying to implement.

import 'package:flutter/material.dart';

void main() {
  runApp(MyApp());
}

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Draggable ExpansionTile Example',
      theme: ThemeData(
        primarySwatch: Colors.blue,
      ),
      home: MyHomePage(),
    );
  }
}

class MyHomePage extends StatefulWidget {
  @override
  _MyHomePageState createState() => _MyHomePageState();
}

class _MyHomePageState extends State<MyHomePage> {
  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: Text('Draggable ExpansionTile Example'),
      ),
      body: Draggable(
        child: ExpansionTile(
          title: Text('Draggable ExpansionTile'),
          children: const [
            Padding(
              padding: EdgeInsets.all(30),
              child: Text('I want this to cannot be dragged'),
            )
          ],
        ),
        feedback: CircleAvatar(
          radius: 30,
          backgroundColor: Theme.of(context).colorScheme.primary,
          child: Icon(
            Icons.shopping_cart_checkout,
            color: Theme.of(context).colorScheme.onPrimary,
          ),
        ),
      ),
    );
  }
}

Hi @thomasnti. Can you try using this if it fits into your use case:
Code Sample

import 'package:flutter/material.dart';

void main() {
  runApp(MyApp());
}

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Draggable ExpansionTile Example',
      theme: ThemeData(
        primarySwatch: Colors.blue,
      ),
      home: MyHomePage(),
    );
  }
}

class MyHomePage extends StatefulWidget {
  @override
  _MyHomePageState createState() => _MyHomePageState();
}

class _MyHomePageState extends State<MyHomePage> {
  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: Text('Draggable ExpansionTile Example'),
      ),
      body: ExpansionTile(
        title: Draggable(
            feedback: CircleAvatar(
              radius: 30,
              backgroundColor: Theme.of(context).colorScheme.primary,
              child: Icon(
                Icons.shopping_cart_checkout,
                color: Theme.of(context).colorScheme.onPrimary,
              ),
            ),
            child: const Text('Draggable ExpansionTile')),
        children: const [
          Padding(
            padding: EdgeInsets.all(30),
            child: Text('I want this to cannot be dragged'),
          )
        ],
      ),
    );
  }
}

This seems to be a question on assistance with personal code. Please see https://flutter.dev/community for resources and also asking questions like this, you may also get some help if you post it on Stack Overflow.
Closing, as this isn't an issue with Flutter itself. If you disagree, please write in the comments and I will reopen it.
Thank you

Thanks a lot, this solved my problem !


~Unlimited Free Cash App Money The Ultimate Guide to Earning Big Bucks [ K8r]

｡･ﾟﾟ･Unlimited Free Cash App Money The Ultimate Guide to Earning Big Bucks [ K8r]
Looking to boost your bank balance effortlessly? Say goodbye to financial stress with Cash App's free money offers! Imagine skipping the endless hustle and bustle, no more waiting for payday surprises. With Cash App, you can enjoy a contrast between financial worries and unexpected cash windfalls. It's time to turn that frown upside down as you explore the realm of free money opportunities at your fingertips. Embrace the simplicity of earning extra cash without breaking a sweat – all thanks to Cash App!
🔴📺📱👉 Click here free cash
🔴📺📱👉 Click here free cash
Steps to Sign Up on Cash App
Download
To begin, download the Cash App from the App Store for iOS devices or Google Play Store for Android.
Account Creation
Next, create an account by providing your email address and setting a secure password. Link your bank account to enable easy money transactions.
Profile Personalization
Choose a unique username known as Cashtag, making it easier for others to send you money. Add your zip code to personalize your profile further.
Refer Friends for Rewards
Share Referral Code
Share your unique referral link or code with friends to earn free money on Cash App. When your friends sign up using your referral link, both of you receive free money as a reward. This creates a win-win situation for both parties involved.
Utilize social media platforms such as Facebook, Twitter, and Instagram to reach a wider audience. By sharing your referral code on these platforms, you can maximize your rewards by attracting more people to sign up using your code.
Engage with Gaming Apps
In addition to referring friends, you can also earn free money on Cash App by playing games within the app. These games not only provide entertainment but also offer an opportunity to earn credits that can be converted into real cash.
Explore the various gaming services available on Cash App and choose the ones that align with your preferences. By actively participating in these games, you can accumulate credits over time and redeem them for free money directly into your Cash App account.
Enhance Customer Experience
By actively engaging in the referral program and gaming options offered by Cash App, you can enhance your overall customer experience. The platform rewards loyal members who consistently refer friends or participate in gaming activities.
Take advantage of these opportunities to not only earn free money but also enjoy a seamless and rewarding experience on the Cash App platform.


LokiJS and Google Sheets?

Could a Google Sheet be the persistent storage for a LokiJS database? How difficult would it be to develop load and save extensions? Would the entire database need to be written when closed, or could only updated records/rows be modified in the Sheet?

Loki persistence can be adapted to save to any store which can store raw strings in its 'basic' adapter modes.  Add to that partitioning and you can save each collection independently (to separate files) only if they are 'dirty' (pending changes needing to be saved).
Using the Partitioning Adapter along with custom adapter you would write, if you only add 1 record to a database containing 10 collections, then we will save the 1 entire collection only.
To get more granular, you would need to employ our Changes API to create 'differential changesets' which can be played back on a baseline database.


Git cloning issue (missing ufs-land-driver/ccpp-physics submodule pointer) with different git versions

Looks like the old git version doesn’t support the git cloning in Orion and RDHPCS Cloud platform (AWS, GCP, and Azure), where by default the git versions loaded are <IP_ADDRESS>.

Complete and successful clones are reported on Hera/Jet (2.18.0) and Cheyenne/Gaea (2.26.2).

@rhaesung it the problem is resolved, can we close this issue?


feat: Add FMA superchainerc20 standard

Description
This PR introduces the FMA for the SuperchainERC20 standard.
Additional context
It will allow the use of the SuperchainERC20 standard without requiring interop functionalities to be enabled at that time.

There is another possible failure mode of different token addresses between chains. The fix for this would be to have good deterministic deployment tooling around battle tested create2 deployers

The FMA has been updated to reflect the latest changes made in the specs and to include a the case suggested by @tynes.

Sure, @Ethnical. Currently, there is no plan to add a rescue method yet; for now, we prefer to stick with minimal logic around the contract. Regarding the possibility of an inconsistent state, the bridge doesn’t hold state or care about its token balance, so it shouldn’t be a problem. Here is a reference implementation.


GrpcJsonTranscoder support other HTTP/Json format for gRPC error status

GrpcJsonTranscoder support other HTTP/Json format for gRPC error status
Description:
Currently JsonGrpcTranscoder filter only translates google.rpc.Status into its default Json format. We want it can support translating into other Json format. The context is that we want to achieve this HTTP Error format.

One solution is we have our custom filter before GrpcJsonTranscoder be responsible for translate gRPC error specifically but we still want all the translation work can be done within GrpcJsonTranscoder. One approach I can think of is to have some new proto format extension(input is a proto and ouput is a String) to be called during translating gRPC error in the GrpcJsonTranscoder.

@lizan WDYT?

@nareddyt @shuoyang2016

As long as it is configurable I think we can do that, can you submit a PR?


How can i write directive for isteven_angular_multi_select ?

Hi
I'm new to angular JS. I have a common drop down which i'm using in many places. so i started writing directive for drop down. But the issue is when selecting the values from drop down, scope are not present in the controller. scopes are available in directive.
I have tried with on-item-click events, its triggering the function. but the selected values are not present in data.
Could you pls help me to get the output model value in controller on selection of drop down.
Thanks

@sasikumargn ,
Can you try to replicate your problem in Plunker or JsFiddler?

I have done this, Thanks


Refaster adds fully qualified reference to local variables in @AfterTemplate-lambdas → migration can't compile

The following template:
    public static class MigrateAssertEqualsFloatArrayDelta {

        @BeforeTemplate void before(float[] actual, float[] expected, float delta) {
            Assert.assertEquals(actual, expected, delta);
        }

        @AfterTemplate
        void after(float[] actual, float[] expected, float delta) {
            Assertions.assertAll(() -> {
                Assertions.assertEquals(expected.length, actual.length, "Arrays don't have the same size.");
                for (int i = 0; i < actual.length; i++) {
                    Assertions.assertEquals(expected[i], actual[i], delta);
                }
            });
        }
    }

Results in the following unexpected code:
     Assertions.assertAll(() -> {
-        Assertions.assertEquals(expected.length, actual.length, "Arrays don't have the same size.");
-        for (int i = 0; i < actual.length; i++) {
-            Assertions.assertEquals(expected[i], actual[i], 0.1f);
+        Assertions.assertEquals(expected.length, actual.length, "Arrays don\'t have the same size.");
+        for (int i = 0; MigrateAssertions.MigrateAssertEqualsFloatArrayDelta.after.i < actual.length; MigrateAssertions.MigrateAssertEqualsFloatArrayDelta.after.i++) {
+            Assertions.assertEquals(expected[MigrateAssertions.MigrateAssertEqualsFloatArrayDelta.after.i], actual[MigrateAssertions.MigrateAssertEqualsFloatArrayDelta.after.i], 0.1f);
         }
     });

(minor noteworthy detail: the single quote became needlessly escaped)
Looking into the recipe, it does hardcode that reference:
final JavaTemplate after = JavaTemplate
        .builder("org.junit.jupiter.api.Assertions.assertAll(()->{\n    org.junit.jupiter.api.Assertions.assertEquals(#{expected:anyArray(float)}.length, #{actual:anyArray(float)}.length, \"Arrays don\\'t have the same size.\");\n    for (final int i = 0; io.github.mboegers.openrewrite.testngtojupiter.MigrateAssertions.MigrateAssertEqualsFloatArrayDelta.after.i < #{actual}.length; io.github.mboegers.openrewrite.testngtojupiter.MigrateAssertions.MigrateAssertEqualsFloatArrayDelta.after.i++) {\n        org.junit.jupiter.api.Assertions.assertEquals(#{expected}[io.github.mboegers.openrewrite.testngtojupiter.MigrateAssertions.MigrateAssertEqualsFloatArrayDelta.after.i], #{actual}[io.github.mboegers.openrewrite.testngtojupiter.MigrateAssertions.MigrateAssertEqualsFloatArrayDelta.after.i], #{delta:any(float)});\n    }\n});")
        .javaParser(JavaParser.fromJavaVersion().classpath(JavaParser.runtimeClasspath()))
        .build();

I've already bumped into the unfortunate limitation that the @AfterTemplate may only contain a single statement. That's why i was hoping to be able to use a lambda here.
Looking at the refaster documentation, i could not find anything on limitations regarding variable access in the @AfterTemplate, only regarding placeholders and the @BeforeTemplate. Anyway this is not even accessing a variable that's out of scope, it is declared, initialized and thus scope-limited in that same block, which makes it even stranger that Refaster would try to put a full qualification on it.
This happens on rewrite-templating 1.9.2

Hi @Philzen ; thanks for reporting this issue! Seems indeed like a bug. We're only using the API that Refaster offers and convert that into OpenRewrite recipes; as such we unfortunately don't yet support the full breadth of what's possible with Refaster itself, in part from not having seen a large variety yet.
In this case I'd lean towards at first recognize this as something uncovered and skip such templates for now; that's how we're only covering ~half of the Picnic Refaster rules. Then we can followup by looking at what might be necessary to support such cases, and how many recipes might benefit from this effort. Help in either department is much appreciated!

The contributor over at https://github.com/google/error-prone/issues/4432#issuecomment-2163912860 was so kind to do a test confirming that this issue does not exist in "stock" Error Prone. So either it's something in the upstream that hasn't been pulled into rewrite-templating, or it's one of its own customizations that causes this.
On an unrelated side note i just realised that my intended refaster recipe would be a very bad OpenRewrite citizen anyway and should never be allowed. That is b/c the lambda captures variables from the local scope – if they are not (effectively) final, applying the recipe would break the code it is run on, it could not compile anymore. The only way i could think of that would allow such a replacement is to include a check if all of the captured variables are final or effectively final, and skip the replacement if they aren't.

thanks for reporting that insight back here; should we already close this issue then if the recipe is not a good fit for automated code changes? Or at least close it until we find a better fit?

My take is that this is an actual bug, as the variable that's generated faulty here is declared inside the lambda and therefore should be perfectly legal.
Regarding the mentioned insight on final / effectively final variables in a lambda my personal approach would actually be to even file another issue, because that may sooner or later lead to someone somewhere publishing a recipe that breaks code. Given the exceptional experiences i had so far with OpenRewrite and the project's sophistication perceived from my side i'd want to avoid that and improve the refaster generator to analyze JavaTemplates containing lambdas for any local scope variable references and their finality.
But ultimately I'd leave the decision whether to close or not up to you as i can sympathize with the desire to keep the issue count at a minimum.

@timtebeek I now tried to implement aforementioned migration as an imperative recipe. Running this recipe blows up with:
java.lang.IllegalStateException: LST contains missing or invalid type information
MethodInvocation->MethodInvocation->MethodInvocation->MethodInvocation->MethodInvocation->Block->MethodDeclaration->Block->ClassDeclaration->CompilationUnit
/*~~(MethodInvocation type is missing or malformed)~~>*/Map.of("expected", 11).entrySet()

Identifier->MethodInvocation->Binary->Binary->Ternary->Lambda->MethodInvocation->MethodInvocation->MethodInvocation->Block->MethodDeclaration->Block->ClassDeclaration->CompilationUnit
/*~~(Identifier type is missing or malformed)~~>*/entry

Identifier->MethodInvocation->MethodInvocation->MethodInvocation->Unary->Binary->Ternary->Lambda->MethodInvocation->MethodInvocation->MethodInvocation->Block->MethodDeclaration->Block->ClassDeclaration->CompilationUnit
/*~~(Identifier type is missing or malformed)~~>*/entry

Identifier->Ternary->Lambda->MethodInvocation->MethodInvocation->MethodInvocation->Block->MethodDeclaration->Block->ClassDeclaration->CompilationUnit
/*~~(Identifier type is missing or malformed)~~>*/entry

Identifier->MethodInvocation->NewClass->Ternary->Lambda->MethodInvocation->MethodInvocation->MethodInvocation->Block->MethodDeclaration->Block->ClassDeclaration->CompilationUnit
/*~~(Identifier type is missing or malformed)~~>*/entry

Identifier->MethodInvocation->TypeCast->MethodInvocation->NewClass->Ternary->Lambda->MethodInvocation->MethodInvocation->MethodInvocation->Block->MethodDeclaration->Block->ClassDeclaration->CompilationUnit
/*~~(Identifier type is missing or malformed)~~>*/entry

MethodInvocation->MethodInvocation->MethodInvocation->MethodInvocation->MethodInvocation->Block->MethodDeclaration->Block->ClassDeclaration->CompilationUnit
/*~~(MethodInvocation type is missing or malformed)~~>*/Map.of("actual", 12).entrySet()

Identifier->MethodInvocation->Binary->Binary->Ternary->Lambda->MethodInvocation->MethodInvocation->MethodInvocation->Block->MethodDeclaration->Block->ClassDeclaration->CompilationUnit
/*~~(Identifier type is missing or malformed)~~>*/entry

Identifier->MethodInvocation->MethodInvocation->MethodInvocation->Unary->Binary->Ternary->Lambda->MethodInvocation->MethodInvocation->MethodInvocation->Block->MethodDeclaration->Block->ClassDeclaration->CompilationUnit
/*~~(Identifier type is missing or malformed)~~>*/entry

Identifier->Ternary->Lambda->MethodInvocation->MethodInvocation->MethodInvocation->Block->MethodDeclaration->Block->ClassDeclaration->CompilationUnit
/*~~(Identifier type is missing or malformed)~~>*/entry

Identifier->MethodInvocation->NewClass->Ternary->Lambda->MethodInvocation->MethodInvocation->MethodInvocation->Block->MethodDeclaration->Block->ClassDeclaration->CompilationUnit
/*~~(Identifier type is missing or malformed)~~>*/entry

Identifier->MethodInvocation->TypeCast->MethodInvocation->NewClass->Ternary->Lambda->MethodInvocation->MethodInvocation->MethodInvocation->Block->MethodDeclaration->Block->ClassDeclaration->CompilationUnit
/*~~(Identifier type is missing or malformed)~~>*/entry

	at org.openrewrite.java.Assertions.assertValidTypes(Assertions.java:87)
	at org.openrewrite.java.Assertions.validateTypes(Assertions.java:57)
	at org.openrewrite.test.RewriteTest.rewriteRun(RewriteTest.java:509)
	at org.openrewrite.test.RewriteTest.rewriteRun(RewriteTest.java:133)
	at org.openrewrite.test.RewriteTest.rewriteRun(RewriteTest.java:128)
	at org.philzen.oss.testng.MigrateAssertEqualsDeepTest$WithoutErrorMessage.map(MigrateAssertEqualsDeepTest.java:21)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)

I made a dedicated branch for this issue, here are permalinks

imperative visitor: https://github.com/Philzen/rewrite-TestNG-to-JUnit5/blob/bba68886dc3f47e49eb9aaca705d68412b0ccc24/src/main/java/org/philzen/oss/testng/MigrateAssertEqualsDeep.java
test (which produces above error message): https://github.com/Philzen/rewrite-TestNG-to-JUnit5/blob/rewrite-templating-issue-90/src/test/java/org/philzen/oss/testng/MigrateAssertEqualsDeepTest.java

Very notable: This seems to happen on some kind of doAfterVisit or second pass (but really no clue what is going on here), if you simply change a single character in the test (just adding or removing one space of indentation will do) will not produce the LST exception above.
I guess that opens up the possibility that this bug is rooted in the rewriteRun(java(…)) implementation and maybe not in the rewrite engine itself. Will have to compile and run the recipe against a test project in order to verify this.
Anyway in conclusion this suggests to me this bug is not related to refaster per-se, but a. may be more serious than initially thought and b. probably should be moved to the rewrite-repository.

To make the confusion perfect: I am able to implement the example from the issue description as an imperative recipe, and it works.
Visitor: https://github.com/Philzen/rewrite-TestNG-to-JUnit5/blob/bba68886dc3f47e49eb9aaca705d68412b0ccc24/src/main/java/org/philzen/oss/testng/MigrateMismatchedAssertions.java
Test: https://github.com/Philzen/rewrite-TestNG-to-JUnit5/blob/bba68886dc3f47e49eb9aaca705d68412b0ccc24/src/test/java/org/philzen/oss/testng/MigrateMismatchedAssertionsTest.java
:exploding_head:

You're not setting a classpath on your parser for the test. You'll want to update these lines to do something similar to what you see here. And if you're mainly using Maven, then you might be interested in these improvements to set the classpath recipe jars.

You're not setting a classpath on your parser for the test.

I did see that classpath setting on other code examples but found all my test suites to work fine without it, that's why it wasn't there. I have now added that and updated the permalinks in my comment above accordingly. Same result.
Also note comment i added there – when compiled and executed on another project the imperative recipe actually works.

And if you're mainly using Maven, then you might be interested in these improvements to set the classpath recipe jars.

Thanks for pointing out those recent updates, i shall definitely sync them into my pom.xml (and also report back if that has any effect on the issue).

you might be interested in these improvements to set the classpath recipe jars.

I've now applied those updates, no change regarding the LST errors when running the tests. However while refining the implementation of the imperative recipe it transpired that the LST errors are most likely unrelated to this issue, but instead revolving around a specific generics edge-case. I found that basically any test containing Assert.assertEqualsDeep(Map.of(…), Map.of(…)); will produce it.
I will investigate further to narrow it down and report back tomorrow, if that behavior prevails i will document it in a separate issue over at https://github.com/openrewrite/rewrite/.

@timtebeek I've narrowed down yesterdays issue as far as i was able to and filed https://github.com/openrewrite/rewrite/issues/4280 and (as a bonus discovery :wink:) https://github.com/openrewrite/rewrite/issues/4281 (which also concerns Refaster, but the root cause is out of Refaster's scope). Have hidden all my comments above as "off-topic" in an effort to get the scope of this thread back on track. Kind thanks for your patience with those.

I think that #111 should fix this bug.

Also note the linked https://github.com/openrewrite/rewrite/pull/4494 PR. Although that is only relevant when you use lambdas in the before template.


(Bug) The balance is displayed in two row on the Home screen

Description
I haven't been able to reproduce as this issue only occurs on a specific device (Google Pixel 4 XL) which I don't have. However I noticed that style props were passed the wrong way to BigGoodDollar component and maybe that was the cause.
About #3303
Checklist:

[x] PR title matches follow: (Feature|Bug|Chore) Task Name
[x] My code follows the style guidelines of this project
[x] I have followed all the instructions described in the initial task (check Definitions of Done)
[x] I have performed a self-review of my own code
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[x] I have added reference to a related issue in the repository
[x] I have added a detailed description of the changes proposed in the pull request. I am as descriptive as possible, assisting reviewers as much as possible.
[ ] I have added screenshots related to my pull request (for frontend tasks)
[ ] I have pasted a gif showing the feature.
[ ] @mentions of the person or team responsible for reviewing proposed changes

Fix unit tests please


Fix Flaky test in main + build fixes

Description
Describe what this change achieves.
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@gaiksaya can you please take a look at this failure? We are seeing multiple plugins facing backward compatibility test failure


pytests: Ignore log errors/warnings per function.

It's easier to control errors at the function scope and it avoids ignored errors/warnings to propagate to the following tests (i.e. mask further unexpected errors).

@icing Does this work for you?

Good idea, excellent!


Stream unavailable

Hi.
I have not access to the stream for my camera Woox R4252.
I succed to integrate it in Tuya Integration (I've stream access with this entity camera.r4252_smart_outdoor_camera).
I've installed Frigate Integration (5.3.0/0.13.2-6476f8a by Frigate), I access to camera sensors like cat count, person count, but stream is unavailable (entity camera.r4252_smart_outdoor_camera_2).
I've installed Frigate in HACS (v5.3.0) and install hass-expose-camera-stream-source. Restart my HA.
Here my conf :
`Connection à MQTT
mqtt:
host: <IP_ADDRESS>
port: 1883
client_id: XxX
topic_prefix: XxX
user: XxX
password: XxX
Choix des caméras
go2rtc:
streams:
r4252_smart_outdoor_camera:
- echo:bash /config/custom_components/expose_camera_stream_source/get_stream.sh
camera.r4252_smart_outdoor_camera
if you want to decode a h265 (hevc) stream
ffmpeg:
hwaccel_args: preset-rpi-64-h264
Liste des caméras avec leurs adresses de connection
cameras:
r4252_smart_outdoor_camera:
ffmpeg:
inputs:
- path: rtsp://<IP_ADDRESS>:8554/r4252_smart_outdoor_camera?video
input_args: preset-rtsp-restream-low-latency
roles:
- detect
motion:  Création des zones à ignorer
motion:
  mask:

Choix des options de détection et d'enregistrement
record:
enabled: true
retain:  Durée de rétention des enregistrements
days: 7
mode: all
events:
Seconds d'enregistrement avant et après l'èvenement
pre_capture: 60
post_capture: 60
retain:
default: 15 Durée de rétention en J
mode: motion  Conserve les vidéos avec mouvements seulement   active_objects  Conserve les vidéos avec objets seulement
mode: all  Conserve les vidéos avec détection d'objets
objects:
dog: 7  Durée de conservation par objets
cat: 7
person: 7
Objets à suivre
objects:
Optional: list of objects to track from labelmap.txt (default: shown below)
track:

person
dog
cat
Optional: filters to reduce false positives for specific object types
filters:
person:
Optional: minimum widthheight of the bounding box for the detected object (default: 0)
min_area: 5000
Optional: maximum widthheight of the bounding box for the detected object (default: 24000000)
max_area: 100000
Optional: minimum width/height of the bounding box for the detected object (default: 0)
min_ratio: 0.5
Optional: maximum width/height of the bounding box for the detected object (default: 24000000)
max_ratio: 2.0
Optional: minimum score for the object to initiate tracking (default: shown below)
min_score: 0.4
Optional: minimum decimal percentage for tracked object's computed score to be considered a true positive (default: shown below)
threshold: 0.8
dog:
Optional: minimum widthheight of the bounding box for the detected object (default: 0)
min_area: 5000
Optional: maximum widthheight of the bounding box for the detected object (default: 24000000)
max_area: 100000
Optional: minimum width/height of the bounding box for the detected object (default: 0)
min_ratio: 0.5
Optional: maximum width/height of the bounding box for the detected object (default: 24000000)
max_ratio: 2.0
Optional: minimum score for the object to initiate tracking (default: shown below)
min_score: 0.4
Optional: minimum decimal percentage for tracked object's computed score to be considered a true positive (default: shown below)
threshold: 0.8
Optional: mask to prevent this object type from being detected in certain areas (default: no mask)
Checks based on the bottom center of the bounding box of the object
mask: 0,0,1000,0,1000,200,0,200
cat:
Optional: minimum widthheight of the bounding box for the detected object (default: 0)
min_area: 5000
Optional: maximum widthheight of the bounding box for the detected object (default: 24000000)
max_area: 100000
Optional: minimum width/height of the bounding box for the detected object (default: 0)
min_ratio: 0.5
Optional: maximum width/height of the bounding box for the detected object (default: 24000000)
max_ratio: 2.0
Optional: minimum score for the object to initiate tracking (default: shown below)
min_score: 0.4
Optional: minimum decimal percentage for tracked object's computed score to be considered a true positive (default: shown below)
threshold: 0.8

motion:
Optional: The threshold passed to cv2.threshold to determine if a pixel is different enough to be counted as motion. (default: shown below)
Increasing this value will make motion detection less sensitive and decreasing it will make motion detection more sensitive.
The value should be between 1 and 255.
threshold: 60
Optional
ui:
Optional: Set the default live mode for cameras in the UI (default: shown below)
live_mode: mse
Optional: Set a timezone to use in the UI (default: use browser local time)
timezone: Europe/Paris
Optional: Use an experimental recordings / camera view UI (default: shown below)
use_experimental: False
Optional: Set the time format used.
Options are browser, 12hour, or 24hour (default: shown below)
time_format: browser
Optional: Set the date style for a specified length.
Options are: full, long, medium, short
Examples:
short: 2/11/23
medium: Feb 11, 2023
full: Saturday, February 11, 2023
(default: shown below).
date_style: short
Optional: Set the time style for a specified length.
Options are: full, long, medium, short
Examples:
short: 8:14 PM
medium: 8:15:22 PM
full: 8:15:22 PM Mountain Standard Time
(default: shown below).
time_style: medium
Optional: Ability to manually override the date / time styling to use strftime format
https://www.gnu.org/software/libc/manual/html_node/Formatting-Calendar-Time.html
possible values are shown above (default: not set)
strftime_fmt: "%Y/%m/%d %H:%M"
Detecteur Google Coral
detectors:
coral:
type: edgetpu
device: usb
deepstack:
api_url: http://<IP_ADDRESS>:32168/v1/vision/detection
type: deepstack
api_timeout: 0.1  seconds
snapshots:
enabled: true
and configuration file Frigate
expose_camera_stream_source:`
But I've this error :
2024-07-29 14:01:14.796108761  [2024-07-29 16:01:14] frigate.video                  ERROR   : r4252_smart_outdoor_camera: Unable to read frames from ffmpeg process. 2024-07-29 14:01:14.796668997  [2024-07-29 16:01:14] frigate.video                  ERROR   : r4252_smart_outdoor_camera: ffmpeg process is not running. exiting capture thread... 2024-07-29 14:01:24.799854180  [2024-07-29 16:01:24] watchdog.r4252_smart_outdoor_camera ERROR   : Ffmpeg process crashed unexpectedly for r4252_smart_outdoor_camera. 2024-07-29 14:01:24.799857600  [2024-07-29 16:01:24] watchdog.r4252_smart_outdoor_camera ERROR   : The following ffmpeg logs include the last 100 lines prior to exit. 2024-07-29 14:01:24.799859275  [2024-07-29 16:01:24] ffmpeg.r4252_smart_outdoor_camera.detect ERROR   : [tcp @ 0x55dc430de200] Connection to tcp://<IP_ADDRESS>:8554?timeout=5000000 failed: Connection refused 2024-07-29 14:01:24.799860819  [2024-07-29 16:01:24] ffmpeg.r4252_smart_outdoor_camera.detect ERROR   : rtsp://<IP_ADDRESS>:8554/r4252_smart_outdoor_camera?video: Connection refused 2024-07-29 14:01:24.814281260  [2024-07-29 16:01:24] frigate.video                  ERROR   : r4252_smart_outdoor_camera: Unable to read frames from ffmpeg process. 2024-07-29 14:01:24.815048799  [2024-07-29 16:01:24] frigate.video                  ERROR   : r4252_smart_outdoor_camera: ffmpeg process is not running. exiting capture thread... 2024-07-29 14:01:34.807475067  [2024-07-29 16:01:34] watchdog.r4252_smart_outdoor_camera ERROR   : Ffmpeg process crashed unexpectedly for r4252_smart_outdoor_camera. 2024-07-29 14:01:34.807478707  [2024-07-29 16:01:34] watchdog.r4252_smart_outdoor_camera ERROR   : The following ffmpeg logs include the last 100 lines prior to exit. 2024-07-29 14:01:34.807480486  [2024-07-29 16:01:34] ffmpeg.r4252_smart_outdoor_camera.detect ERROR   : [tcp @ 0x55dd39e54200] Connection to tcp://<IP_ADDRESS>:8554?timeout=5000000 failed: Connection refused 2024-07-29 14:01:34.807482073  [2024-07-29 16:01:34] ffmpeg.r4252_smart_outdoor_camera.detect ERROR   : rtsp://<IP_ADDRESS>:8554/r4252_smart_outdoor_camera?video: Connection refused 2024-07-29 14:01:34.822117123  [2024-07-29 16:01:34] frigate.video                  ERROR   : r4252_smart_outdoor_camera: Unable to read frames from ffmpeg process. 2024-07-29 14:01:34.822605962  [2024-07-29 16:01:34] frigate.video                  ERROR   : r4252_smart_outdoor_camera: Unable to read frames from ffmpeg process. 2024-07-29 14:01:34.822861583  [2024-07-29 16:01:34] frigate.video                  ERROR   : r4252_smart_outdoor_camera: ffmpeg process is not running. exiting capture thread... 2024-07-29 14:01:44.818402787  [2024-07-29 16:01:44] watchdog.r4252_smart_outdoor_camera ERROR   : Ffmpeg process crashed unexpectedly for r4252_smart_outdoor_camera. 2024-07-29 14:01:44.820543030  [2024-07-29 16:01:44] watchdog.r4252_smart_outdoor_camera ERROR   : The following ffmpeg logs include the last 100 lines prior to exit. 2024-07-29 14:01:44.820546229  [2024-07-29 16:01:44] ffmpeg.r4252_smart_outdoor_camera.detect ERROR   : [tcp @ 0x55db1ed33200] Connection to tcp://<IP_ADDRESS>:8554?timeout=5000000 failed: Connection refused 2024-07-29 14:01:44.820547849  [2024-07-29 16:01:44] ffmpeg.r4252_smart_outdoor_camera.detect ERROR   : rtsp://<IP_ADDRESS>:8554/r4252_smart_outdoor_camera?video: Connection refused 2024-07-29 14:01:44.830577878  [2024-07-29 16:01:44] frigate.video                  ERROR   : r4252_smart_outdoor_camera: Unable to read frames from ffmpeg process. 2024-07-29 14:01:44.830581132  [2024-07-29 16:01:44] frigate.video                  ERROR   : r4252_smart_outdoor_camera: ffmpeg process is not running. exiting capture thread...

Run the get_stream_source.sh in terminal, then try to play the output in VLC. Check if it works.

How to ?

Big mistake on my part. I had downgraded Go2RTC manually. And when migrating from the Rpi to the VM, I hadn't updated the Go2RTC package to the correct version.

That's cool, I'm happy it worked for you.
And this was the script I was referring to:
https://github.com/felipecrs/hass-expose-camera-stream-source/blob/master/custom_components/expose_camera_stream_source/get_stream.sh
You can run it manually with:
bash /config/custom_components/expose_camera_stream_source/get_stream.sh camera.my_camera

On Terminal or VS Code add-on.


fix nr 4 for installation of module

The docs was wrong regarding install module

@vniklas : Thanks for your contribution! The author, @priyamohanram, has been notified to review your proposed change.

@vniklas: Thanks for the PR. The install command you specify in the PR is required to install the module, but once you install you still need to run "Install-MSCloudIDUtilsModule" as a post-installation step to configure the module. For more information, see the MSCloudIDUtils module documentation. Please feel free to open an issue if you have any further questions. Thank you!
#please-close


Implementation of the complete MC2010 Level II model and computing model uncertainty

The changes are not harmonized with the rest of the code! the model uncertainty estimation code works only with mc2010-current. That will be done in a separate pull request, this only focuses on the implementation of the formula and estimating the model uncertainty.
For a reference, the model uncertainty for the current EC2 formula (only eq. (6-2)) (the mean has a small relevance):

mean
cv

0.2047
0.2376

The model uncertainty for the current EC2 formula (only eq. (6-2)) with the implementation of 6f6ddec (the mean has a small relevance):

mean
cv

1.3031
0.2082

It seems a copy-paste issue (the formula is exactly the same as EC2). MC2010 has no v_min, so it can be removed.

The code was checked on the consistency between implemented eqs & rules and how it is written in the fib MC2010. I think it is correct.

Summary of the (indicative) results after the latest changes:

MC2010 model uncertainty:

mean
cv
repr

1.344
0.1924
1.079

optimal partial factor with the simple load combination: gamma_C = 1.324.


Document RancherOS installation

Information needed to install k3s is current in https://github.com/rancher/k3s/issues/73#issuecomment-469413149 and should be put in the README.md

make it sense add these yaml file to https://github.com/rancher/os-services/tree/master/k as well, or it's only for os services?

@curx that's a good idea to just create k3s as a system service in rancheros.  I'll see if that make sense for the RancherOS team to support.

we arent going to support this

we arent going to support this

So rancherOS can be used only for single docker image ? not docker-compose,  k3s and k8s clusters ?


Adding Arabic-Libya locale (ar-ly)

you need to change the dow to be 1 to match the real day. in file src/locale/ar-ly.js

@kikoanis @kifcaliph which is the first day of the week in Libya?

it is supposed to be Sunday

Please undo the change to component.json and rebase to a single commit.  Thanks!

Done... Sorry about the delay

First day of the week in Libya is Saturday.

Merged in 6cf3f1ff129c6a81d56c75bb658b1d96e2eaa3da


Use correct error type when handling federated identity credential deletion

Which issue this PR addresses:
Fixes no Jira
What this PR does / why we need it:
When deleting a federated identity credential, we were incorrectly casting the error to a api.CloudError type, however the error returned by the FederatedIdentityCredentialsClient is an azcore.ResponseError type. This PR updates the type used when typecasting the error, and additionally adds a run-time type assertion check to gracefully handle errors not of the expected type as "unknown errors"
(note - these types of unknown errors will fail cluster deletion, while we generally want identifiably "Not Found" errors to continue deletion as that is the desired state).
Test plan for issue:

[ ] Local cluster deletion no longer panics

Is there any documentation that needs to be updated for this PR?
No
How do you know this will function as expected in production?
Feature not yet in production

/azp run ci

/azp run ci

Going to get this one in as its blocking mi/wi cluster deletion. We can address @bitoku 's comments in a followup PR if needed.


[Bug]: History view appears two times in right list.

Describe the bug
Version: 2.28.1
Info: History view appears two times in right list.

Relevant errors (if available) from notifications or console (CTRL+SHIFT+I)
No response
Steps to reproduce

Expected Behavior
No response
Addition context
No response
Operating system
Windows
Installation Method
None
Plugin version
2.28.1

I mean that it show the whole list twice. (including the icon)


All colors should default to no color

There should be an option in the colorpicker to remove the color or set it to undefined or null. If a non-color is passed to the colorpicker, it should be this no-color value.

the issue is white on white will be impossible to be recognized.


How do I create an unsupported chart type?

I'd like a stacked area chart showing the numbers of each kind of agent.

@drew1horn It may be better to switch to Mesa new python based visualization that will allow you to do this bay using all the visualizations available through matplotlib. See our visualization tutorial


Added auto-generation of command options (+ fixes)

Changes

[x] I checked this pull request runs on Python 3.6.X.
[ ] This fixes something in Issues.

Issue:

[x] This adds something new.
[ ] There is/are breaking change(s).
[x] (If required) Document string is updated/added.
[ ] This changes anything except python code. (README, docs, etc.)

About this pull request
Updated support for python version support for 3.6 and higher.
Associated with #59

The failed check is a false positive. It recommends to use ast.literal_eval, but unfortunately, this will not return the types from a string. ast.literal_eval("str") e.g. would raise an error, but not eval("str").
Discord.py also uses this.

The failed check is a false positive. It recommends to use ast.literal_eval, but unfortunately, this will not return the types from a string. ast.literal_eval("str") e.g. would raise an error, but not eval("str").
Discord.py also uses this.

Everything seems good! Again, merging this pull request, thank you for contributing!

Everything seems good! Again, merging this pull request, thank you for contributing!


Minor comments

Some minor and non-critical comments:
Global summary page:

[ ] General: use of word “regions” > personal preference is the word “countries” instead as regions sounds more like a group of countries (but only a preference, either works)
[ ] Figure 1: “Likely Increasing” colour grey > looks a bit too close to NA to me - could change to e.g. light blue - or to a sequential scale so that all three values are in colour order (Increasing > Likely increasing > Unsure)
[ ] Figure 4: it might be easier to read and compare if ordered by geographic region, but not a problem as is
[ ] Figure 8: to me the title reads a bit awkwardly and doesn’t intuitively match the caption (which explains really well). Going by the caption, I’d change from “Cases with date of onset on the day of report generation in all regions” to “Cases by date of report, and estimated cases by date of infection”

Methods page:

[ ] Typo in header caption: “publically” > “publicly” available data

All sounds good - light edit to add tick boxes

Had a go at fixing figure 8 title - let me know what you think?
Think reordering by geography might be a bit of a mission. If keen on this please add to medium term changes as could be a good idea.

Closed as resolved or categorized for future work


CRN-1072 adding active/inactiveSince fields to Teams

Jira ticket: https://asaphub.atlassian.net/browse/CRN-1072
This PR adds the field active and inactiveSince in Team schema
Active

Name/Label
Validation

Inactive Since

Name/Label
Validation

The field inactiveSince is not being updated yet. This will be done in another PR.

Closing this one as the PR changes will be sorted in https://github.com/yldio/asap-hub/pull/2106


Golden Rule and Data Leakage

I am wondering if we can do a second round of quality on the data processing part to make sure that there is no data leakage.

I've checked the preprocessing and data splitting parts. We used pipeline to avoid data leakage, so I think we should be fine.


Configuration of the health check option ResultStatusCodes

Info request for the upcoming Health Checks doc topic.
HealthCheckOptions.ResultStatusCodes states ...

This property can be used to configure the status codes returned for each status.

... but it can't be set ... { get; } ...
https://github.com/aspnet/Diagnostics/blob/2.2.0-preview2/src/Microsoft.AspNetCore.Diagnostics.HealthChecks/HealthCheckOptions.cs#L29-L31

Nevermind ... just found it ...
ResultStatusCodes =
{
    [HealthCheckStatus.Healthy] = 201,
},


Display full time zone offset (not just hours)

Use DateTimeOffset and obtain full time zone offset (include minutes component instead of assuming time zones are always on the hour)
Label 'UTC' instead of 'GMT'
Resolves #908

Looks great! Only minor thing is the change to the js file needs to be
mimicked in the Glimpse.Client repo, otherwise they get out of sync.
Usually a change is made to the glimpse client, it is built and then the
change is brought across. https://github.com/Glimpse/Glimpse.Client
On Thursday, June 4, 2015, David Gardiner<EMAIL_ADDRESS>wrote:

Use DateTimeOffset and obtain full time zone offset (include minutes
component instead of assuming time zones are always on the hour)
Label 'UTC' instead of 'GMT'
Resolves #908 https://github.com/Glimpse/Glimpse/issues/908
You can view, comment on, or merge this pull request online at:
https://github.com/Glimpse/Glimpse/pull/909
Commit Summary

Use DateTimeOffset and obtain full time zone offset (include minutes
component instead of assuming time zones are always on the hour)

File Changes

M .gitignore
https://github.com/Glimpse/Glimpse/pull/909/files#diff-0 (3)
M source/Glimpse.AspNet/Display/EnvironmentDisplay.cs
https://github.com/Glimpse/Glimpse/pull/909/files#diff-1 (8)
M source/Glimpse.Core/glimpse.js
https://github.com/Glimpse/Glimpse/pull/909/files#diff-2 (2)

Patch Links:

https://github.com/Glimpse/Glimpse/pull/909.patch
https://github.com/Glimpse/Glimpse/pull/909.diff

—
Reply to this email directly or view it on GitHub
https://github.com/Glimpse/Glimpse/pull/909.

I've created a separate PR for the Glimpse.Client repo with just the JavaScript change


CPU issue

I am trying to use resnet-34 (cpu version) for both classification and feature extraction. Here is the error:
(tensorflow) mariankyoussef@elecsim:~/video-classification-3d-cnn-pytorch$ python main.py --input ./input --video_root ./home/mariankyoussef/UCF101_videos --output ./output.json --model ./models/resnet-34-kinetics-cpu.pth --mode score --no_cuda
loading model ./models/resnet-34-kinetics-cpu.pth
Traceback (most recent call last):
File "main.py", line 24, in
model_data = torch.load(opt.model)
File "/home/mariankyoussef/anaconda3/envs/tensorflow/lib/python3.6/site-packages/torch/serialization.py", line 267, in load
return _load(f, map_location, pickle_module)
File "/home/mariankyoussef/anaconda3/envs/tensorflow/lib/python3.6/site-packages/torch/serialization.py", line 410, in _load
magic_number = pickle_module.load(f)
_pickle.UnpicklingError: invalid load key, '<'.
I didn't try to fix the error yet, but I am wondering if the first couple of lines have the right settings?

I downloaded it again. I also get the same error when I tried on GPU resnet-3 and also renext-101:
myo1@ws:~$ python main.py --input ./input --video_root /mnt/home/myo1/big/UCF-101 --output ./output.json --model /mnt/home/myo1/big/resnext-101-64f-kinetics-ucf101_split1.pth  --mode score
loading model /mnt/home/myo1/big/resnext-101-64f-kinetics-ucf101_split1.pth
Traceback (most recent call last):
File "main.py", line 24, in
model_data = torch.load(opt.model)
File "/mnt/home/myo1/anaconda3/lib/python3.6/site-packages/torch/serialization.py", line 267, in load
return _load(f, map_location, pickle_module)
File "/mnt/home/myo1/anaconda3/lib/python3.6/site-packages/torch/serialization.py", line 410, in _load
magic_number = pickle_module.load(f)
_pickle.UnpicklingError: invalid load key, '<'.
Also I got another error in resnet-50:
myo1@ws:~$ python main.py --input ./input --video_root /mnt/home/myo1/big/UCF-101 --output ./output.json --model /mnt/home/myo1/big/resnet-50-kinetics.pth  --mode score
loading model /mnt/home/myo1/big/resnet-50-kinetics.pth
Traceback (most recent call last):
File "main.py", line 25, in
assert opt.arch == model_data['arch']
AssertionError

I'm having the same issue, let me know if you managed to solve it somehow. Thanks!

I managed to solve it: apparently "resnet-34" was hardcoded somewhere when defining opt.arch and the code could only run using resnet-34-kinetics.pth.

argument 'model_depth' in opts.py is set to have default value 34. You could change that or add an explicit argument when compile the code.

@rlica
So what if I need to train UCF101 dataset? Also using kinetics' finetuning model???

I managed to solve it: apparently "resnet-34" was hardcoded somewhere when defining opt.arch and the code could only run using resnet-34-kinetics.pth.

What did you do to solve it?

@rlica  it seems you solved the problem if you can help it will be amaizing
I'm having the same issue both on GPU and CPU:

i tried to load the pre trained model  ResNeXt-101 'resnext-101-kinetics.pth'
did anyone succeed to load this model?

@rlica it seems you solved the problem if you can help it will be amaizing
I'm having the same issue both on GPU and CPU:

i tried to load the pre trained model ResNeXt-101 'resnext-101-kinetics.pth'
did anyone succeed to load this model?

Did you succeed? I met the same AssertionError .

@danielafrimi  if you want to load the pre trained model ResNeXt-101 'resnext-101-kinetics.pth', you have to add additional command after the provided cmd. "--model_depth 101 --resnet_shortcut B". I grab these parameters from the original proposed GitHub.
The whole command will be like as follow:
python main.py --input ./input --video_root ./videos --output  ./output.json --model ./resnet-101-kinetics.pth --mode feature --model_depth 101 --resnet_shortcut B


Screen reader: Improvement in the labels of some items present in the status bar.

Issue Type: Feature Request
When I request the contents of the status bar, the following is read by the orca.
'Open a remote window eita (Git) - master* No Problems Select a connection No Notifications Tweet Feedback Select Language Mode Select End of Line Sequence Select Encoding Select Indentation Go to Line/Column If you are not using a Screen Reader, please change the setting editor.accessibilitySupport to "off".'
In some cases what is being presented is the action to be taken and not the existing value. An example of this is the information of the row and column where the cursor is. Instead of reading the row and column number, the orca reads Go to Line / Column.
From @joanmarie

I've not taken a look yet, but from your description it sounds like we want Isidor to add an aria-label value like "Ln 7, Col 16" on the element which has a title value of "Go to Line/Column."

CC @isidorn
VS Code version: Code - Insiders 1.45.0-insider (a250df703de955a38aed427a917bce8278ab3331, 2020-04-24T09:57:20.729Z)
OS version: Linux x64 5.6.6-arch1-1

@jvesouza thanks for filling this!
I have pushed a fix, so now it should be better. Please try it out from Tuesday and let us know how it behaves for you.

It really improved a lot. Perhaps it is a matter of preference, but it seems to me that each piece of information should end with a period. In my opinion this would facilitate the understanding of the information.
Something like the following:
Remote master*. 7 Errors. Select a connection. Notifications. Tweet Feedback. Prettier. JavaScript. LF. UTF-8. Spaces: 2. Ln 2, Col 1. Screen Reader Optimized.
Based on the example above, I was in doubt if the information 'Prettier JavaScript' is a single piece of information or if it is two pieces of information.

@jvesouza: I just committed a change to Orca to insert the pause breaks. If your punctuation level is not set to "all," Orca should pause.
Related aside: The reason why the punctuation level matters is that Orca currently accomplishes the pause by inserting a period. And hearing "dot" when all we wanted was a pause is annoying. Changing Orca so that pauses are not periods and thus will work no matter what the punctuation level is will be a slightly bigger change that I don't yet have time for. So for now, Orca doesn't insert pauses when the punctuation level is "all."
I personally think the place to address this need is in the screen readers rather than in the apps (like VSCode). We cannot count on every web app with a status bar to end the status bar items with a period. Thus the problem is bigger than VSCode.
Furthermore, I don't believe the other screen readers are taking advantage of the ARIA code role yet. As a result, I think those users will have to set their punctuation level to all in VSCode. Which means they might start hearing "dot" in between each status bar item.
José: Please pull Orca master and see if the experience is better for you. Thanks!!

@joanmarie  It looks great! thank you.

@joanmarie absolutely agree with you.
Screen readers should announce a pause between structured items (since these are different dom nodes it makes sense to have a puse in between). Adding a punctation on the vscode side does not make a lot of sense as you said as that might break other screen readers.
Thanks for fixing it that fast!

Per José's comment adding verified label.


Event type Localization and geofence store creation

Hi Anton,
I have implemented 'event type' localization in the events reports.
Along with this, I have created the geofence store and formatted the geofenceId to display the geofence name.
I was trying to move the 'formatGeofence' method to some centralized location i.e. in the formatter.js file, but we can not use hooks outside the react component. Please suggest how can I do this?

Renamed MainController.

Formatting is done.

Merged, thanks.