qiskit.test.decorators.enforce_subclasses_call machinery is broken in 3.11.1

Environment

Qiskit Terra version:

HEAD of main, currently dd7f9390cf07

Python version:

3.11.1

Operating system:

Both macOS and ubuntu, so far.
What is happening?
import test.python raises an error in 3.11.1, therefore tests do not run. @wshanks has indicated that it is working fine for him in 3.11.0 but not 3.11.1 (I don't have 3.11.0 installed).
Python 3.11.1 (v3.11.1:a7a450f84a, Dec  6 2022, 15:24:06) [Clang 13.0.0 (clang-13<IP_ADDRESS>)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import test.python
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/Users/ihincks/ibm/qiskit-terra/test/__init__.py", line 16, in <module>
    from qiskit.test.utils import generate_cases
  File "/Users/ihincks/ibm/qiskit-terra/qiskit/test/__init__.py", line 15, in <module>
    from .base import QiskitTestCase
  File "/Users/ihincks/ibm/qiskit-terra/qiskit/test/base.py", line 167, in <module>
    class QiskitTestCase(BaseQiskitTestCase):
  File "/Users/ihincks/ibm/qiskit-terra/qiskit/utils/classtools.py", line 117, in out
    retval = method(*args, **kwargs)
             ^^^^^^^^^^^^^^^^^^^^^^^
TypeError: TestCase.__init_subclass__() missing 1 required positional argument: 'cls'

Or, see an example of this happening in CI: https://github.com/Qiskit/qiskit-experiments/actions/runs/3704009805/jobs/6281449337
How can we reproduce the issue?
Run the tests or simply import test.python in Python 3.11.1.
What should happen?
This should not error.
Any suggestions?
No response

I'm having trouble reproducing this using only wrap_method. For example, the following works as expected:
import qiskit.utils

class Foo:
    pass

def print_blerg(*_):
    print("blerg")

qiskit.utils.classtools.wrap_method(Foo, "__init_subclass__", after=print_blerg)

class Goo(Foo):
    pass

If it works on 3.11.0 maybe https://github.com/python/cpython/pull/99646 is related which touches TestCase.__init_subclass__? Though it's weird that the failure isn't happening consistently, in some of the CI runs only Mac and in some only Linux failed..

please, revert https://github.com/Qiskit/qiskit-terra/pull/9296 when fixed.

I did a bit more digging and I think that https://github.com/python/cpython/pull/99646 is, surprisingly, unrelated to issue. I believe there has been a change in Python itself that breaks the way qiskit.utils._WrappedMethod.__get__ deals with __init_subclass__. I can't find the change in the 3.11.1 changelog, but didn't look as hard as I could have. That the change to TestCase appears in the same release is just bad luck.
Consider the following:
class Foo:
    def __init_subclass__(cls, *args, **kwargs):
        ...

method = type.__getattribute__(Foo, "__init_subclass__").__get__(None, Foo)
print(method)
method()

This snippet summarizes the path that qiskit's wrap_method and _WrappedMethod take to grab  the underlying __init_subclass__ method. In Python 3.11.1,method as defined above is not a bound method, but in previous Python versions, it is. Hence the TypeError when it's called without cls as the first argument.

Looking back, I think I over-engineered this machinery in response to a minor problem, mostly because I was enjoying learning more of the Python internals. That said, at the top of the file there's some special handling for the magic methods that lie about their implementations; you might be able to fix this by adding the __init_subclass__ string to the relevant set at the top of the file, if it's now an implicit class method rather than explicit one.

Yes, I think the issue requires both the unittest change and a change to how __init_subclass__ is treated in 3.11. __init_subclass__ is a weird case that gets converted into a classmethod (according to the documentation; what that actually means I am not sure and I think might have changed in 3.11) and I think the decorator/wrapper code might mischaracterize it now.

#9310 is a test of that idea.

I think something like this might work across versions, but I've never run terra tests locally and running into possibly superficial issues (circular imports do to _accellerate):
--- a/qiskit/utils/classtools.py
+++ b/qiskit/utils/classtools.py
@@ -101,14 +101,15 @@ class _WrappedMethod:
             self._method = method
         # If the inner method doesn't have `__get__` (like some builtin methods), it's faster to
         # test a Boolean each time than the repeatedly raise and catch an exception, which is what
-        # `hasattr` does.
-        self._method_has_get = hasattr(self._method, "__get__")
+        # `hasattr` does. Moreover, depending on the Python version, some magic methods' `__get__`
+        # method return an unbound version of the method, which we avoid by also checking `__self__`
+        self._use_get = hasattr(self._method, "__get__") and not hasattr(self._method, "__self__")

     def __get__(self, obj, objtype=None):
         # `self._method` doesn't invoke the `_method` descriptor (if it is one) because that only
         # happens for class variables. Here it's an instance variable, so we can pass through `obj`
         # and `objtype` correctly like this.
-        method = self._method.__get__(obj, objtype) if self._method_has_get else self._method
+        method = self._method.__get__(obj, objtype) if self._use_get else self._method

         @functools.wraps(method)
         def out(*args, **kwargs):

qiskit.test.decorators.enforce_subclasses_call is a class decorator that wraps specified methods of the class in wrappers that set a flag when the method is called and wraps __init_subclass__ in a wrapper that then wraps those methods on subclasses to clear the flags and then make sure the flags are set after the call.
The wrapper code distinguishes between methods defined on type and other methods and uses type.__getattribute__ or object.__getattribute__ accordingly here. This is the part I don't completely follow (though there are nice comments by the code). I can't find documentation on the difference between type.__getattribute__ and object.__getattribute__ (beyond reading the Python source code). I think that something funny happens with __init_subclass__ between the way it gets converted to a classmethod and the way it is bound to the class variable. The change in behavior might be related to the performance work that was done in 3.11 which I think worked on optimizing attribute access.
This code mimics how the qiskit method wrapper handles type methods and other methods:
class CustomInitSubclass:
    def __init_subclass__(cls, *args, **kwargs):
        super().__init_subclass__()

print(
    "type getter",
    type.__getattribute__(
        CustomInitSubclass,
        "__init_subclass__",
    ).__get__(None, CustomInitSubclass)
)

print(
    "object getter",
    object.__getattribute__(
        CustomInitSubclass,
        "__init_subclass__",
    ).__get__(None, CustomInitSubclass)
)

On 3.10, I see
type getter <bound method CustomInitSubclass.__init_subclass__ of <class '__main__.CustomInitSubclass'>>
object getter <bound method CustomInitSubclass.__init_subclass__ of <class '__main__.CustomInitSubclass'>>

while on 3.11 I see:
type getter <function CustomInitSubclass.__init_subclass__ at 0x7f2a321987c0>
object getter <bound method CustomInitSubclass.__init_subclass__ of <class '__main__.CustomInitSubclass'>>

In #9310, I just force __init_subclass__ back to the object getter instead of the type one. There may be more that is good to adjust by someone who understood the distinction between object.__getattribute__ and type.__getattribute__ better than I do.

@ihincks When I see a message about _accelerate, it is usually because I forgot to run pip install . after switching branches or Python versions (because it is the first compiled thing that is imported).

I can't remember all the details off the top of my head, but I'm fairly sure the differences are in how they apply the descriptor protocol - object.__getattribute__ fills in the fields like instance calls, and type.__getattribute__ fills in the fields as if they're class calls (because of course that's what's happening).  They have slightly different interplay with __new__, __init_subclass__ and __prepare__, which are "magic" descriptors (they bind differently to how their definitions would appear), but I can't remember / maybe never knew what that is.

There's a bit of description here (and near here). If @wshanks patch passes tests I'll personally be happy, because it's unlikely that these machines will ever test the magic methods in ways beyond enforce_subclass_call currently does 😄

My original suggestion was actually wrong and the one from @ihincks was closer to the right solution. Mine "worked" but only by chance for the specific circumstances covered by the tests. By forcing __init_subclass__ back to object.__getattribute__, I just forced the wrapper to call object.__init_subclass__ instead of the wrapped class's method. For the tests, that had the effect of just bypassing unittest.TestCase.__init_subclass__ (the only wrapping of __init_subclass__ in the tests) which does not do much so was not missed by the tests, but bypassing __init_subclass__ obviously would cause problems if anyone ever wanted to use __init_subclass__. I described the issue in #9310 in detail. The short version is that the classmethod was getting converted to a bound method by __getattribute__ and then unbound by __get__. Ian's solution detects the classmethod to bound method conversion by checking for __self__ and skips the call to __get__ that unbinds the function. #9310 instead avoids the classmethod to bound method conversion by avoiding __getattribute__.


[Bug] Cannot not be compile after add gleam_otp

After I run gleam add gleam_top under my terminal, the gleam.tomk add one more dependency
for gleam_top (gleam_otp = "~> 0.7")
But when I ran gleam run, it just show me the following error:

The gleam version is 0.30.5, and I ran it under MacOS, installed by homebrew

Hello! You need to upgrade your gleam_erlang version. Perhaps run gleam update.


2961 maps

Pull Request Checklist:

[x] Positive Test Case Written by Dev

[x] Automated Testing

[x] Sufficient User and Developer Documentation

[x] Passing Jenkins Build

[x] Peer Code review and approval

Positive Test Case

Open discovery map view and a resource page with maps, verify both show the maps in development mode.  Add the maps key to local_settings and check both maps again to validate they are in production mode.

@sblack-usu merge when ready


MIME types

I can't find any way to get the mime type of the file from either the Flow\Request or the Flow\File object?  If this functionality does not exist, I'd be glad to make a pull request for it, but I don't want to go reinventing the wheel and it seems like a pretty important thing to omit.

I think this more of applies to ng-flow than the PHP backend. You can detect the mime type after assembling the file from chunks into a complete file, either at Flow\File->save or more conveniently in Flow\Basic after if ($file->validateFile() and $file->saveFile($destination)). But if you want to filter out files for the uploader itself, it's kinda too late at this point.
The only convenient way to filter out unwanted filetypes (cruedly, but still that's something) is to init flow with appropriate options, i.e. before adding any files to the uploader, for example:
<div data-flow-init      data-flow-file-added="!!{png:1,jpg:1,jpeg:1}[$file.getExtension()]"      data-flow-files-submitted="$flow.upload()">

You should print out "https://github.com/flowjs/flow-php-server/blob/master/src/Flow/Request.php#L140" Though this array should not be trusted.
You should use http://www.php.net/manual/en/function.finfo-file.php instead.


WIP: Add a caching proxy feature to our unit testing framework.

Next steps:

unit tests for coverage
pytest plugin to turn it on and off

Critical Changes
Changes
Issues Closed

@prescod can you tell me a bit about the intended use case?

For example: my integration tests for describe take about 5 minutes to run because they download the describe data multiple times. With the cache, the second time I run them they take 11 seconds. So that's the use-case, fast turnaround for integration tests which otherwise would run very slowly.

@prescod Have you had a chance to look at whether we can use https://pypi.org/project/pytest-vcr/ for this?


Yo Travis! Come here, I think i got something 4 u.

You know. The usual.

when is this going to be merged? this fixes an issue at our company


Add .gitignore

add .gitignore
remove xcschememanagement.plist

Since scheme settings should be shared with configuration files under xcshareddata directory, I deleted the scheme configuration file under xcuserdata directory.

Thanks!


Document operator precedence handling, clean up format string expansion

Hi,
I've added docstrings for the new operator precedence functionality in
the compiler. Also I rewrote how the generated expression can be
customized based on what you've suggested in PR #48.
Let me know if something is amiss. Thanks!

Thanks, Ákos!


Add support for new models with new protocol.

Newer models of TV with the newer (rubbish) UI/OS require a more complicated communication setup, with hashing of a string that is provided when opening the socket to authenticate. This adds support for that, it will automatically switch to that setup when it detects the selected model as the TH-49CQE1W. I would expect this to work for other new models too, but they would need to be added to be identified.

How do we go about getting these changes merged into the base branch so we can control newer TV's

I've asked on the Slack multiple times and it seems to get ignored, so not sure what else I can do.


updated dockerfile to compile for RPI armhf

Description
The existing dockerfile was unable to be run on a raspberry pi as the dependancies took a very long time to compile and eventually failed.
The update to the dockerfile adds in raspberry pi sources as an additional fallback source, so if wheel fails to get it from main source it will get the requirements from the raspberry pi source.
I have also had to add some compiled dependancies to the postbuild container in order for the bot to run post build.
I have NOT updated the build pipelines to push to the container registry, the build command will need to be updated to use buildx to compile for both linux/amd64 and linux/armhf In order for the source ghcr.io/whittlem/pycryptobot/pycryptobot:latest to be used on both the rPi and a standard desktop build. Other architectures may be required as part of the keychain.
Fixes # (issue)
#587
Type of change
Please make your selection.

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update
[ ] This change requires a new dependency
[ ] Code Maintainability / comments
[ ] Code Refactoring / future-proofing

How Has This Been Tested?
I have only updated the dockerfile no other code so have tested the output of docker buildx to ensure that it compiles for an armhf with no errors. I have pushed to docker hub
https://hub.docker.com/r/mattwa/pycryptobot
and the bot has been running on a raspberry pi for 20+ hours with no errors that I have seen and it has executed 2 trades a buy and a dell trade. All looks to be working AOK.
Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added pytest unit tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules
[x] I have checked my code and corrected any misspellings

Canceling pull request due to compilation error for a raspberry pi 4 on aarch64. Will re-submit when tested again


Milestone/Project 2: feature - decorators 🎫

🚩I have made the following changes to complete OOP School Library - Milestone/Project 2
Here is a summary of what has been done
Type of files changed/added

In this new Branch, I have ➕ADDED➕ the succeeding *📂 folders and/or **📄 files to complete this milestone's requirements
*📂 root/

*📂 lib/

**📄 nameable.rb ➕

The -Nameable- class will raise the NotImplementedError exception if the correct_name method is not implemented.

The -BaseDecorator- will inherits from -Nameable-.

In its constructor it will get the nameable object and assign it to the @nameable attribute.

It will also implement the correct_name method returning the @nameable object's correct_name method.

-CapitalizeDecorator- will inherits from -BaseDecorator-.

It will implement the correct_name method returning the @nameable object's correct_name method capitalized.

-TrimmerDecorator- will inherits from -BaseDecorator-.

It will implement the correct_name method returning the @nameable object's correct_name method trimmed unless the @nameable object's correct_name method length is less <= 10 characters.

I have ✏MODIFIED✏ the succeeding *📂 folders and/or 📄** files
*📂 root/

**📄 README.md ✏

I have marked as complete the 'Class Decorators' item on Future Features section.

*📂 lib/

**📄 person.rb ✏

I have required nameable.
I have also included the method correct_name returning the @name attribute.

Thank you for taking the time to review this PR ⭐

If you require additional information or have any questions, don't hesitate to get in touch with me on Slack as Arturo (Arthur) Emanuel Guerra Iturres. I'll be happy to help you out. 🎯

Hi @Johnadibe John! how are you? absolutely! 🎯, you know, modularizing the decorators was my first approach 😄, however, I encountered the error that both the string modifier decorators were missing when I instantiated them on person.rb during testing.
The problem was that I was requiring just nameable and this file would only contain the nameable class interface. So in order for it to work I would have to require each string modifier decorator.
Such as:
require_relative 'class_decorators/capitalize_decorator'
require_relative 'class_decorators/trimmer_decorator'

What do you think? 🤠

Hello @ITurres, I believe it is okay if you do that.👍

Great then, thank you @Johnadibe John for having reviewed this PR! 👍🏼, wish you a great week and happy coding! 🎆


Change default organization to be set to My Company

Change default organization to be set to My Company instead of Spotiy or Acme Organization. As referenced in #2908
:heavy_check_mark: Checklist

[ ] A changeset describing the change and affected packages. (more info)
[ ] Added or updated documentation
[ ] Tests for new functionality and regression tests for bug fixes
[ ] Screenshots attached (for UI changes)

All fixed!


Disable onBytesReceived callback invocation when nobody is listening.

Description
Don't invoke image loading onBytesReceived callback if there is nobody listening for those events.
Related Issues
Performance traces show unnecessary callbacks load on UI isolate leading to dropped frames.
Tests
I added the following tests:
diff --git a/packages/flutter/test/foundation/consolidate_response_test.dart b/packages/flutter/test/foundation/consolidate_response_test.dart
--- a/packages/flutter/test/foundation/consolidate_response_test.dart
+++ b/packages/flutter/test/foundation/consolidate_response_test.dart
+    test('Doesn\'t invoke onBytesReceived when controller is off', () async {
+    test('Invokes onBytesReceived when controller is on', () async {
+    test('Stops invoking onBytesReceived when controller turns off', () async {

Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[ ] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[ ] I signed the CLA.
[ ] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[ ] I updated/added relevant documentation (doc comments with ///).
[ ] All existing and new tests are passing.
[ ] The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
[ ] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?

[ ] Yes, this is a breaking change (Please read Handling breaking changes). Replace this with a link to the e-mail where you asked for input on this proposed change.
[ ] No, this is not a breaking change.

I added the following tests:
Replace this with a list of the tests that you added as part of this PR. A change in behaviour with no test covering it will likely get reverted accidentally sooner or later. PRs must include tests for all changed/updated/fixed behaviors. See Test Coverage.

Tests?

I added the following tests:
Replace this with a list of the tests that you added as part of this PR. A change in behaviour with no test covering it will likely get reverted accidentally sooner or later. PRs must include tests for all changed/updated/fixed behaviors. See Test Coverage.

Tests?

Added some now.

What is the performance bottleneck? Is it calling onBytesReceived or is it adding a ImageChunkEvent to a StreamController that nobody is listening to?

What is the performance bottleneck? Is it calling onBytesReceived or is it adding a ImageChunkEvent to a StreamController that nobody is listening to? And how big is the difference in performance?

It's former - there are many onBytesReceived dart callbacks being invoked by Dart VM when nobody is actually listening. On prototypical "photos gallery" flutter app on its timeline it looks like avalanche of microscopic invocation of some dart code during  image loading, when the device is potentially busy with receiving the bytes, decoding already downloaded bytes, building frames with already decoded bytes.
The effect though might look more dramatic than it really is because those no-op callbacks even though invoked, don't interrupt or block frame construction(in other words, they won't cause jank).

The effect though might look more dramatic than it really is because those no-op callbacks even though invoked, don't interrupt or block frame construction(in other words, they won't cause jank).

Is it worthwhile to fix this problem then if it doesn't have much impact? Given our discussion above, fixing this probably requires a (major) redesign of how this works to get a sensible API...

The effect though might look more dramatic than it really is because those no-op callbacks even though invoked, don't interrupt or block frame construction(in other words, they won't cause jank).

Is it worthwhile to fix this problem then if it doesn't have much impact? Given our discussion above, fixing this probably requires a (major) redesign of how this works to get a sensible API...

Yeah, looks like it is not.


godot_4: 4.2.1-stable -> 4.2.2-stable

godot_4: 4.2.1-stable -> 4.2.2-stable
Release: https://github.com/godotengine/godot-builds/releases/tag/4.2.2-stable
godot_4-export-templates: init 4.2.2-stable
On pkgs/by-name check, I found weird to move this to pkgs/by-name because I was expecting this to exist at Godot 4 directory. Which also matches Godot 3 structure that already exists.

Nice! I was having a source-built godot_4-export-templates on my side, which is by no means universal...

godot_4-export-templates has to be moved to pkgs/by-name, however...

Result of nixpkgs-review pr 305118 run on x86_64-linux 1

3 packages built:

godot_4
godot_4-export-templates
godot_4.man


Remove zipcodes

closes #5

We probably need to add some tests and the NA issue #7 needs to be sorted

These changes were captured in other PRs

These changes were captured in other PRs


Use Enzyme or DifferentiationInterface for autodiff

Current Status
The AD part of the package has not undergone any major overhaul since I first implemented it around the start of the project. Back then I relied on Flux/Zygote, because the package was tailored to Flux models anyway (at the time), I was entirely new to AD and Julia; and I could use Zygote to differentiate through structs, like so:
"""
    ∂ℓ(
        generator::AbstractGradientBasedGenerator,
        ce::AbstractCounterfactualExplanation,
    )

The default method to compute the gradient of the loss function at the current counterfactual state for gradient-based generators.
It assumes that `Zygote.jl` has gradient access.
"""
function ∂ℓ(
    generator::AbstractGradientBasedGenerator, ce::AbstractCounterfactualExplanation
)
    return Flux.gradient(ce -> ℓ(generator, ce), ce)[1][:counterfactual_state]
end

Pain Points
The current implementation is less than ideal for various reasons:

Zygote cannot handle nested AD, which is necessary for some counterfactual generators (see #376).
Gradients are still taken implicitly, which is not in line with where the broader ecosystem is headed, I believe.
The previous point also makes it difficult to implement forward-over-reverse to solve the nested AD issue.
The AD implementation has never been optimized for performance, so I guess there's a lot of room for improvement here.

To Do

[ ] Double-check https://gdalle.github.io/JuliaCon2024-AutoDiff/#/title-slide
[ ] Try out DifferentiationInterface.jl

This seems like a good idea (he said, completely unbiased). Want a hand with that @pat-alt ?

@gdalle fancy seeing you here 😄
That would be amazing, of course, if you could help out, but only if it's not too much trouble for you. I want to look at this soon, but I might look at #495 first, because I think I may need this for a research project I'm currently working on.
I've updated the description a little bit. If you have any pointers, I'd much appreciate if you could share them here.
Thanks!


can't get the contact data

query contacts in graphql-playground get error
{
  user(id: 1) {
    name
    contacts {
      type
    }
  }
}

{
  "errors": [
    {
      "path": [
        "user",
        "contacts",
        0,
        "type"
      ],
      "message": "Cannot return null for non-nullable field",
      "locations": []
    }
  ],
  "data": {
    "user": {
      "name": "Test",
      "contacts": [
        null
      ]
    }
  }
}

but query post seems right
{
  user(id: 1) {
    name
    posts {
      title
    }
  }
}

{
  "data": {
    "user": {
      "posts": [
        {
          "title": "Test Post"
        }
      ],
      "name": "Test"
    }
  }
}

PS: already insert the seed data

@benwilson512  ping ..

i did little research -- i had to Manually preload :contacts filed
def find_user(id) do
    Repo.get(Accounts.User, id)
    |> Repo.preload(:contacts)
end

but why posts filed is "auto-loaded ?" ,  i can get the result without using preload(:posts)
i am new to absinthe , very confused

figured.


(kmttg)

Checklist

[X] I have checked the moderation queue that no new version has been submitted (only visible when logged in), or the submitted package version has failed the automated checks.

Please navigate to the following link to view the moderation queue.

[X] I have verified that the new version is a stable release.
[X] I have looked to see if there are any Bug reports that prevents a new version being submitted and that no existing Outdated Reports have been created.
[X] I have verified the new version has a Windows binary (EXE or MSI installer, Zip or other archive, etc).

New Software Version
2.8-l
Download location
https://github.com/lart2150/kmttg
Package Page
https://community.chocolatey.org/packages/kmttg

This package isn't maintained in this repository. Please contact the maintained.


operator: Refactor AWS and Azure allocators

This is the first step towards #9920.
$ for t in "${tags[@]}" ; do (echo "building with -tags ${t}..." ; go build -tags "${t}" && du -hs operator) ; done
building with -tags operator_aws,operator_azure...
 83M    operator
building with -tags operator_aws...
 80M    operator
building with -tags operator_azure...
 60M    operator
building with -tags ...
 58M    operator
$

test-me-please

Coverage increased (+0.4%) to 45.971% when pulling 8e74d3278ad14aad5463bf1e15474b3d772b3daf on pr/errordeveloper/operator-tags into d22fd6911757231df29d37cefa658c81260269f9 on master.

test-me-please

test-me-please

@tklauser thanks! I'm not sure how this happen, I guess I'm not paying all the attention to IDE warnings as macOS build is partly broken and there are far too many warnings.

Ah, actually I completely forgot to add godoc comments to new functions, that's what happen :)

test-me-please

17:17:19  [Fail] K8sServicesTest Checks ClusterIP Connectivity [AfterEach] Checks service on same node

...will re-run

test-me-please

I just got a little puzzled by number above, and what I didn't realise is that in my test I wasn't stripping the binaries. I've updated the description for the record.


Timed out fetching a new connection from the connection pool.

Bug description
I did some research on https://github.com/prisma/prisma/issues/25013. I found the possible cause of this problem.
Prisma's connection management relies on prisma-engine (rust language), and the mechanism is as follows:

When obtaining a connection from the connection pool, it will determine whether the idle time of the connection exceeds max_idle_lifetime (default 5 minutes). If so, the connection will be closed and recreated
One of the steps in creating a connection is to create a tls connector. The specific code is as follows. This step is a synchronous operation, and it has been tested that it is greatly affected by the CPU (~1s is required under a 100m CPU limit)

        let mut tls_builder = TlsConnector::builder();

        {
            let ssl_params = url.ssl_params();
            let auth = ssl_params.to_owned().into_auth().await?;

            if let Some(certificate) = auth.certificate.0 {
                tls_builder.add_root_certificate(certificate);
            }

            tls_builder.danger_accept_invalid_certs(auth.ssl_accept_mode == SslAcceptMode::AcceptInvalidCerts);

            if let Some(identity) = auth.identity.0 {
                tls_builder.identity(identity);
            }
        }

        let tls = MakeTlsConnector::new(tls_builder.build()?); // This line of code consumes more CPU resources
        let (client, conn) = timeout::connect(url.connect_timeout(), config.connect(tls)).await?;

The picture is the cpu flame graph of tls_builder.build(), The main CPU consumption is PEM_X509_INFO_read_bio_ex, OSSL_DECODER_CTX_new_for_pkey

When the connections in the connection pool are idle for a long time, a batch operation is initiated and all the connections in the connection pool need to be recreated. When the CPU pressure is high (CPU steal is high or CPU limit is low), the connection creation will exceed pool_timeout (10s) and connect_timeout (5s) due to the waiting time of TLS operation.
Here are some solutions
App layer solution

Keep the connection active: Use select 1 every 5 minutes to keep the connection active
Increase pool_time and connect_timeout to reduce the impact of tls timeout

Prisma layer solution

Modify the source code. Since tls may not be used, remove the tls build and use NoTls directly
Modify the source code and change the tls of each build to be generated by the existing tls.clone() (refer to mobc-postgres)

How to reproduce

Expected behavior
I would like to know if the solution I provided is feasible. Hope you can reply
Prisma information

// Add your schema.prisma

// Add your code using Prisma Client

Environment & setup

OS: CentOS
Database: PostgreSQL
Node.js version: v20.12.1

Prisma Version
5.12.1

Hi @youxq, thanks for this analysis! We've struggled to reproduce this issue in the past, hopefully your input will help us speed this up and fix this. Thanks!

We actually encourage you to open a PR to modify and test this!

@jkomyno Ok, I will open a PR later to try to fix it


Correctly load state from pretraining

    # Filter out decoder network keys
    ae_net_dict = {k: v for k, v in ae_net_dict.items() if k in net_dict}

Did not match any keys. The encoders seem to live in .encoder of the corresponding AE and we can directly import the keys from there.

addresses https://github.com/lukasruff/Deep-SAD-PyTorch/issues/9

addresses https://github.com/lukasruff/Deep-SAD-PyTorch/issues/9


can the -q flag be added?

I have a script that make nvr my $EDITOR when I'm using neovim's embedded terminal. I often run a command like nvim -q <(ag --vimgrep foo bar.txt) to quickly feed results to the quickfix list. Is there a way to add that flag to nvr?

Could you try if the latest version is working as expected?

Oh, of course. Check again!

Perfect, thanks. For completeness's sake, you may also want to add the -t flag, though I don't use that myself. It would, however, make nvr a more or less perfect copy of nvim inside nvim.

Okay, -t got added as well.

Awesome, thanks. I think nvr is basically feature complete at that point
then.

Yay. :-)
Neovim still wants to support these features natively in the future (that's why I never bothered writing tests for nvr), so I'm glad it worked out surprisingly unproblematic so far.
Thanks for your feedback!


Use type-safe getTileEntity() in blocks

This builds upon #2834, which eliminates so many getTileEntity() calls. (Either pull only this or the other one first, in which case I'll rebase this one.)
Once https://github.com/SleepyTrousers/EnderCore/pull/17 is in Ender IO's required EnderCore, I'll do the calls that have a IBlockAccess.

I can rework this to be standalone, as you don't like the generic handling one.

For reference, another report: http://pastebin.com/nB0Lh1C0


Investigate SVE acceleration for RPO hash function

Rounds of RPO hash function have a very regular structure which should be amenable to vectorized computation. This is especially true for the inverse alpha portion which applies ~70 identical operations to a state of 12 elements. This portion is by far the most time-consuming part of the hash function.
By using vectorized instructions, it may be possible to speed the hash function up by 2x - 3x (though, this needs to be confirmed). As one of our target machines for Miden VM is Graviton 3, which supports SVE extension, it would be great to see if can get this type of speed up there.
Ideally, we'd want to add a feature to this crate which, when enabled, would replace the current pure Rust code for either the entire RPO permutation, a single RPO round, are even just the inverse alpha computation.

have we also looked at hashing in the GPU? It could be useful in the VM to not compute the hash of the control blocks in the CPU while producing a trace, but compute the hash of all the blocks at the end using the GPU instead.

Yes, hashing on GPUs is something that we've actually already implemented on Apple silicon (see here). However it is done for a different step: during proof generation rather than during trace construction.
For trace construction, going all the way to the GPU might be an overkill (number of hashes we need to compute there is relatively small). But I think it would be very beneficial to offload hash computations for trace construction to other threads (right now, the whole trace generation process runs in a single thread, and I suspect we can speed it up a lot by parallelizing things like hashing).

Closed by #190.


Use skip instead of pending

pending will run the failing test and report a backtrace which adds
a lot of noise - using skip will still report that there are pending
specs but with a minimum of noise.
@miq-bot add-label test, api
@miq-bot assign @abellotti

LGTM!!!


EmailProof universal link does not open on Android even if app is installed

By defaul default the web addess "app.altme.io" is not set
i think the probleme is that one
https://stackoverflow.com/questions/70653427/android-deep-links-not-working-due-to-supported-web-addresses-being-disabled-by

I think this issue is already solved. I didn't face any issues with android  fresh build...
@ThierryThevenet @hawkbee1


Fix for #433 - TkFallback crashes when there is no fallback.

Fix for #433:

Updated TkFallback to check the Opt from the given fallback,
and if empty throw a message with a proper message.
Updated TkFallbackTest to run the snippet and check if the exception has
the proper message.

@danff Many thanks, I will find someone to review it before we merge

@pinaf this pull request is for you, please review

@danff looks good. 2 comments.

@pinaf Thank you for your comments. New changes have been commited.

@rultor merge

@rultor merge

@pinaf Thanks for your request. @yegor256 Please confirm this.

@danff see comment above

@yegor256 The message is related to the problem of no fallback available, i.e. fbk.route().has() == false, but the cause of the problems (i.e. exception) is also included in the message, so the final messages are diffrent. "There is no fallback..." is only a prefix to the full message.

@rultor merge

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 17min)

@elenavolokhova please, review this task for compliance with our quality rules

@rultor deploy pls

@rultor deploy pls

@davvd OK, I'll try to deploy now. You can check the progress here

@rultor deploy pls

@davvd Done! FYI, the full log is here (took me 11min)

@pinaf
According to our quality rules:

The code reviewer found at least three problems in the code.

There were only two issues found during review.
Please confirm that you will try to find at least three problems next time.

@elenavolokhova I confirm

@davvd Quality is acceptable here.

@davvd Quality is acceptable here.

@elenavolokhova thank you, let's try to make it "good" next time

@pinaf paied 10 mins to @elenavolokhova for QA review (payment ID is 75287141)... Thanks a lot, I just topped your account for 20 mins, transaction ID AP-9UE140457T556670G, total time was 47 hours and 31 mins... you're getting extra minutes here (c=5)... +20 to your rating, your total score is +6050


free band

Lora is free band, meybe add a way to send message without licence sign on lora?

It's free . APRS is for Ham Ops.
But maybe you want a Lora messenger without going into APRS world, right?
Like meshtastic?

Use Meshtastic instead if you don't have license, use ISM bands.
APRS is for Ham Ops only and wouldn't open for people without license. Sorry!


ERROR ReferenceError: localStorage is not defined

Hi,
I'm trying to use the branch howto/auth to check how the localstorage is used in client and server. Everything works fine, but I realized that the method getUsers() in user.service.ts do not use the JWT method.
I'm getting the error  "localStorage is not defined" when I use the jwt method as a parameter of transferHttp.get(url, this.jwt())
Just downloaded the branch, then modify the user.service.ts to:
return this.transferHttp.get(${this.baseUrl}/api/users, this.jwt());
So, can someone help me?
Thank you,

Local storage is not available on the server, you need to wrap that call to local storage with isPlatformBrowser()

Hi @isaac2004 thanks for answering!

Yes, you can either wrap it - or use D.I. to have an abstract class that you provide a Browser & Server implementation for. Browser implementation using actual localStorage, Server implementation using either a JS Object, or maybe even Redis or something (if you really need it persisted like that).
Hope that helps! :+1:


set koji-task-id label on BuildConfig

We should set a koji-task-id label on the BuildConfig to make it possible to search for builds that are due to a particular Koji task.

... we already do this.


atomic-swap: init at 0.4.1

Description of changes

Added atomic-swap, which facilitates atomic swaps of ETH and XMR.
The checks for this release are failing in their CI, so I doubt it's possible to get the checkPhase to run correctly for now.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Ah beaten by https://github.com/NixOS/nixpkgs/pull/241204


Backup cron expression fails validation

Describe the bug
When copying the default cron expression for daily backups from Artifactory and running terraform validate, a failure occurs on the date field.
Expected behavior
terraform validate passes with no reported issues.
Additional context
Provider version: 6.16.4
Sample resource:
resource "artifactory_backup" "daily" {
  key      = "backup-daily"
  enabled  = true
  cron_exp = "0 0 2 ? * MON-SAT"
}

Validation output:
│ Error: Invalid Cron expression
│
│   with artifactory_backup.daily,
│   on main.tf line 132, in resource "artifactory_backup" "daily":
│  132:   cron_exp = "0 0 2 ? * MON-SAT"
│
│ 0 0 2 ? * MON-SAT is not a valid cron: syntax error in year field: 'MON-SAT'

Note the error is for the year field. The validator seems to be parsing the expression into fields incorrectly.

@bmanuel, the cron expression you use is not correct. The provider uses https://github.com/gorhill/cronexpr to verify cron expression.
In your case, you're missing a year field, it should be like this 0 0 2 ? * MON-SAT *, then terraform verify will pass.
The format is as following - Minutes, Hours, Day of Month, Month, Day of Week, Year. You need to use all the fields, starting with minutes, if not, replace them with *.

@danielmkn is there any documentation that shows that the provider expects a year given that all of the Artifactory documentation leaves that field out?

@bmanuel, this resource uses the configuration call, which is not very well documented, so there are no cron format examples.
The thing is, if I remove the verification, the API takes any string as a cron expression, and the backup settings will be broken. I see the same behavior in the UI as well.
In the documentation I see this description for the field:
A valid CRON expression that you can use to control backup frequency. For example, to back up every 12 hours use a value of: 0 0 /12 * * ?

The cron expression there is not correct, unfortunately.
I think, the best we can get in the provider, is use this verification module, please, refer to the documentation.
I'll add this information to the field description.


[QUESTION] How to provide custom example value for single return

First check

[x] I used the GitHub search to find a similar issue and didn't find it.
[x] I searched the FastAPI documentation, with the integrated search.
[x] I already searched in Google "How to X in FastAPI" and didn't find any information.

Description
How can I provide a custom example value for the return value of routes? When the return is a Pydantic model, you can set the example keyword argument on a pydantic Field or add it to schema_extra in the Model config. However, when the return value is a simple type such as str or List[Optional[int]]` there seems to be no way to provide an example. Am I missing something, or is this a missing feature?

https://github.com/tiangolo/fastapi/issues/1007#issuecomment-589029073

@phy25 I am asking about responses not request parameters.

you can manually extend/alter the returned schema, but I'd think there would be a way to do this
https://fastapi.tiangolo.com/advanced/extending-openapi/

Hi, @retnikt !
You can add examples for in field responses. See this page

Thanks @Slyfoxy

Thanks for the help here everyone! :clap: :bow:
Thanks for reporting back and closing the issue @retnikt  :+1:


[loc] Request to add English (United Kingdom) language to VS Code

I have submitted requests for the new language on all vscode-* transifex projects.
I am willing to translate to English (United Kingdom).
My transifex account name is "mjcheetham".

what's different from the current default English?

There are a number of difference spellings (and differences between nouns or verbs in spelling) for some words. A few examples:
Color :us: vs Colour :gb:

Center :us: vs Centre :gb:

NB: I'm not suggesting changing the CSS properties here :sweat_smile:, just the help text and descriptions. Admittedly some of these strings here might be from the CSS language service and not part of the editor or workbench directly, but they are bundled with Code.
-ize :us: vs -ise :gb:

License (n., v.) :us: vs Licence (n.) and License (v.) :gb:

@mjcheetham , please review Adding language criteria here: https://github.com/Microsoft/Localization/wiki/How-to-request-a-new-UI-language-for-VS-Code-project.
And add your Transifex account link as a vote in this tracking issue.

Transifex account is:
mjcheetham
(https://www.transifex.com/user/profile/mjcheetham/)

I've noticed that in the past few months the English (United Kingdom) language has appeared on Transifex as a language available to translation, with currently four members listed as translators for the UK team.

BenjaminSouchet
LogneBudo
lasithds
mjcheetham (myself)

I've made many suggested translations to various strings, but in the last few days there seems to have been many strings marked as 'translated' (but still unreviewed) with incorrect translations (spelling mistakes from the British English perspective; for example "color" rather than "colour").
I do not seem to be able to do anything to remedy these incorrect translations, except make new suggestions or vote others (many of for which I have already made the correct suggestion).
Has UK English been formally accepted or not?
Example string which has been mistranslated as of 3 days ago:

The language en-GB was enabled in Transifex for VS Code projects. Close this issue.


Dev

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@40869f7). Click here to learn what that means.
The diff coverage is 19.6%.

@@            Coverage Diff            @@
##             master       #3   +/-   ##
=========================================
  Coverage          ?   25.28%
=========================================
  Files             ?        3
  Lines             ?      178
  Branches          ?        0
=========================================
  Hits              ?       45
  Misses            ?      133
  Partials          ?        0

Impacted Files
Coverage Δ

convert/__init__.py
100% <100%> (ø)

convert/run.py
18% <18%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40869f7...8b85bb8. Read the comment docs.

Neat!


The Script property appears doubled in the Remote inspector

Godot version
v3.4.beta2.official
System information
Windows 10
Issue description
The script property doubles in the inspector when running the app and selecting 'remote'. Is present on all nodes, in every project, in a new project, after clearing the cache at User/AppData/Roaming/Godot/Projects.

Steps to reproduce
Create a new, simple, runnable project. Run it and go to the 'Remote tab'. Select any node. In the inspector, the 'script' property is doubled. Occurs both in 3.3.2 and 3.4.beta2.official.
Minimal reproduction project
Test_3_4.zip

Sorry. By clearing the cache, I meant removing the project file at this location:
C:\Users\ulfij\AppData\Roaming\Godot\projects
And to clarify, I also meant that this didn't help. Not that it was a necessary step to reproduce the issue.

I can confirm this on v3.4.beta.custom_build [d22f487df].

I just noticed this bug in 3.4-stable, Standard version (Linux).
I did some manual bisecting of releases and can tell you this regression was introduced in 3.2.4.beta2.  I'm embarrased I didn't notice this much earlier.
Here's a screenshot of 3.2.4.beta1 and 3.2.4.beta2.  Looks like in beta2 somebody removed the "Script" header, and now the duplicated "Script" properties for a node display together.  I'm not sure why a node has (had!) a separate "Script" section when it already had a script property within its Node section.  Maybe the person who made the change was trying to resolve that duplication.
In any case, from 3.2.4.beta2 forward we now have those duplicate script properties over/under each other, confusingly.

Here's a screenshot of 3.2.4.beta1 and 3.2.4.beta2. Looks like in beta2 somebody removed the "Script" header, and now the duplicated "Script" properties for a node display together. I'm not sure why a node has (had!) a separate "Script" section when it already had a script property within its Node section. Maybe the person who made the change was trying to resolve that duplication.

Indeed, the Script group was removed in https://github.com/godotengine/godot/pull/43566.

I have tested and can confirm this issue is present at least since 3.0.

The inspector gets the properties from an object using the Object::get_property_list method which calls the virtual implementation and then adds some properties (like the script property). For the remote inspector, the object is an instance of ScriptEditorDebuggerInspectedObject which implements the virtual _get_property_list method by returning all of the object's properties (including script) so it gets added twice.
The properties retrieved from the _get_property_list virtual method (the remote properties) are added without a category and the script property that is added by Object::get_property_list at the end is added within the Script category (until #43566 which removes the category), but the script property has always been duplicated.
I can see a two ways to fix this:

Since we know Object::get_property_list will add the script property, the implementation of ScriptEditorDebuggerInspectedObject::_get_property_list can skip the script property and not push it.
The implementation of Object::get_property_list can check if the script property was added by the virtual method and not push it in this case.

I'm not sure which option is preferred.
Note: ScriptEditorDebuggerInspectedObject was renamed to EditorDebuggerRemoteObject in 4.0 but the issue still applies.


Incorrect screenshot on GitHub PRs marketing page.

This shows the Security Insights plugin.
https://roadie.io/backstage/plugins/github-pull-requests/

@martina-if I believe you misclick closed this in the standup this morning 😀

Oh, sorry about that!

I just checked the public website and this issue is still outstanding so I am moving the corresponding card on the Backstage Plugin Development board back to "Up next".

It's some kind of a gatsby bug with building images. When you open the site's source, you'll see that the image's src is src="/static/c7a8e87fc6a64f52bf3d2a257210ed60/ee604/GitHub-Mark-120px-plus.png". This is incorrect, somehow the image's source is set after the logo image and that's the real reason why those two github plugins share the same cover image - they have the same icon (in fact, github actions also).


Allows to work with @Nested tests

Depends on https://github.com/cariochi/reflecto/pull/2

Thanks, @lmartelli.  The @Nested tests support will be released in v1.2.3 which will be available in a couple of days.

Great ! This will remove the burden of publishing a patched version or including it in our project.


reverting docker compose workaround

Using Github actions docker image
We had to put a workaround in to stop relying on the Github actions docker-compose image since there was an error with that specific version.  This is removing the workaround and putting us back to the standard image used by the actions.
Issue
#368
Checklist
Note: You may remove items that are not applicable

Issue
#368

Mind changing the the text to be just #368 instead of [#368](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue)?  That way GitHub automatically links to that issue instead of linking to that generic GitHub documentation webpage.


Bump dask related version to latest available

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

Superseded by #10
Thanks @viniciusdc


WIP: Lua module support

For neovim

I have added release branch.
I think the feature is not stable yet.  It should be merged into master instead.

Merged.


feature:report bad actors

Feature request:
How can we report bad actor accounts?
I've been seeing a few of these recently.
For example this account.
It left a comment on this thread.

I understand that reporting can be abused.
Ultimately the question is: how can we deal with these?

To report bad actor accounts, use the platform’s built-in reporting tools, much like how CelebHoje handles celebrity news submissions. Include screenshots and specific details to help moderators address the issue effectively and reduce abuse of the reporting system.


KAFKA-14280: return random backoff for 1st retries

When doing quorum election, we added a random election backoff if vote got rejected or timeout, and hope next round, there will be no conflict between different voters. But currently, we calculate the random backoff by:
Math.min(RETRY_BACKOFF_BASE_MS * random.nextInt(2 << Math.min(20, retries - 1)),
        raftConfig.electionBackoffMaxMs());

That means, when multiple candidates tried to backoff for the 1st retries, they will all get 0ms backoff, and then keep conflicting again.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

@jsancio @cmccabe @hachikuji , call for review. Thanks.


group modularization is breaking Elysia method chaining

Sounds like a mouthful but you know how in ElysiaJS we can chain multiple .get() and .post() functions on an instance of Elysia? In that very same manner we can chain multiple .group() functions too, this works just fine.
But when I modularize my handlers then these chains fail. The first .group() function works but every chain after that throws red line errors (This expression is not callable. Each member of the union type <const NewElysia extends Elysia<any, any, any.....)
This works fine
This breaks the chaining

Hi! 👋 Just a regular user here, but I'd love to try and help out a bit. I've encountered a similar issue before, and though I'm still learning, here's a potential solution:
import Elysia from "elysia"

const dashboardRoutes = new Elysia().get("/", () => "Dashboard Home")
const usersRoutes = new Elysia().get("/", () => "Users Home")
const gamesRoutes = new Elysia().get("/", () => "Games Home")

const app = new Elysia()
  .guard({}, (app) =>
    app
      .group("/dashboard", (app) => app.use(dashboardRoutes))
      .group("/users", (app) => app.use(usersRoutes))
      .group("/games", (app) => app.use(gamesRoutes))
  )
  .listen(3000)

reference: https://elysiajs.com/concept/group.html#plugin-group

Hi, you can also use the callback without creating a new instance of Elysia, like in this code:
`
import Elysia from "elysia"
const dashboardRoutes = app => app.get("/", () => "Dashboard Home")
const usersRoutes = app => app.get("/", () => "Users Home")
const gamesRoutes = app => app.get("/", () => "Games Home")
const app = new Elysia()
.guard({}, (app) =>
app
.group("/dashboard", (app) => app.use(dashboardRoutes))
.group("/users", (app) => app.use(usersRoutes))
.group("/games", (app) => app.use(gamesRoutes))
)
.listen(3000)
`

Fixed as complete as mentioned by farhantallei and feggaa


Improvements mostly to Dir but also File and IO

Add emacs scratch-files and test temp-dir to gitignore, mostly so that I don't accidentally checkin a scratchfile.
Add Dir#pos=
Move Dir.foreach and Dir.each_child into C++
Change return-type of Dir#fileno to int
Add IO#to_i alias of IO#fileno
Change functions that always return a zero to return int instead of Value (File.link, symlink, mkfifo)
Add File.path,  File.rename, File.truncate and File#truncate
Fix Dir.open close-ensure issue using Defer trick.  👏
Restore helpers/fs.rb to upstream as #742 is fixed.
Import Dir.fileno test as #1019 is fixed.
Import passing specs for Dir children, each_child, each, entries, and foreach methods.  Some of those specs were NATFIXME'd due to lack of EUC_KR Encoding.

IIRC the remaining big to-do in Dir is Dir.glob, which looks like it'll be a big pain. 😦

Sweet


Updated data stores for "Pay Patient" and "Pay Practitioner".

[x] After these changes, the app was run and still works as expected
[x] Tests for these changes were added (if applicable)
[x] All existing unit tests were run and still pass

For a lot of these I think the mutation is enough and the action is kind of unnecessary, it's just a wrapper for the mutation. Still works though. My review also hasn't been requested, maybe I haven't been added to this repo yet

I agree there is some redundancy, however it's generally bad practice to commit a mutation outside of an action. In general, from your Vue component, you dispatch an action, which takes care of committing the mutation(s). The same principle applies in Redux with reducers (respective to mutations).
I've also added you as a "Maintainer" for the repo.

Fair point. Thanks Harry


Multiple Timescales Support

Currently the user interface side of Gerabaldi is locked to hours. Add support for modifying the time units prior and post timestamp conversions.

Addressed by PR #22


[Admin] Fix broken link

Docs Build status updates of commit 55d4f55:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/excel/custom-functions-batching.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 6a1cd1e:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/excel/custom-functions-batching.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


[Bug Report] JDK 17 doesn’t work

Bug Description
The bot doesn't do anything past loading config
Steps to Reproduce

Try to use JDK 17
Observe that it doesn't work

Expected Result
I expected the bot to work
Debug Output
N/A, 0.3.5, JDK 17 (tried with Oracle and AWS Corretto)

Additional Info
JDK 16 does though
Checklist

[X] I have looked for information about this within the documentation
[X] I have searched for similar issues on the issues page
[X] I am running the latest version of the bot:

Wdym? Do you have any logs for whats happening?

Nothing apart from a message saying the config loaded. The verbose flag isn't useful either

Honestly, it works for me on an older version of JMusicBot, so old that lavaplayer can't play anything lol

What version/commit?

Cannot reproduce using OpenJDK 17.

What version/commit?

Whatever it was 27th september 2020

I can confirm I have the same issue with Ubuntu 20.04 LTS.
Running Ubuntu 20.04.3 LTS

java --version
openjdk 17 2021-09-14
OpenJDK Runtime Environment (build 17+35-Ubuntu-120.04)
OpenJDK 64-Bit Server VM (build 17+35-Ubuntu-120.04, mixed mode, sharing)

java -Dnogui=true -jar JMusicBot-0.3.5.jar
[13:34:08] [INFO] [Startup]: Loaded config from /home/discord-music/config.txt

And it just sits there, won't respond in Discord.
If I use openjdk 16 everything works fine.

cat /etc/os-release
Output:
PRETTY_NAME="Debian GNU/Linux 11 (bullseye)"
NAME="Debian GNU/Linux"
VERSION_ID="11"
VERSION="11 (bullseye)"
VERSION_CODENAME=bullseye
ID=debian
HOME_URL="https://www.debian.org/"
SUPPORT_URL="https://www.debian.org/support"
BUG_REPORT_URL="https://bugs.debian.org/"

I'm also on Debian 11 Bullseye and have no issues, including Win10/Windows with Java 17, tho I stopped using Oracle/Open JDK a few years ago.
I use the Azul Zulu JDK builds, they are my preference, because they have higher quality standards and most issues fixed.

Cannot reproduce using OpenJDK 17 GA, both on Windows 11 and Debian 11. But I remember encountering the same issue a few months ago when JDK 17 was still in early access.

The errors encountered are on GA builds (from apt)
On Mon, 4 Oct 2021 at 2:04 PM, giovanniwijaya @.***>
wrote:

Cannot reproduce using OpenJDK 17 GA, both on Windows 11 and Debian 11.
But I remember encountering the same issue a few months ago when JDK 17 was
still in early access.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/jagrosh/MusicBot/issues/913#issuecomment-933068015,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AF6BVMF4KGVXDEBZ2S2JQLDUFD4TRANCNFSM5EXISJTA
.

Seems to be fixed, I also tried it on Coretto (not shown here)

I'll keep this issue open in case anyone else is still encountering the issue, unless I'm not supposed to do that, in which case a collaborator can close this

I can reproduce this issue when running the bot with image: openjdk:latest in docker-compose on Arch Linux.
However, the same docker-compose is working on a different host.
The issue was resolved by downgrading the image to openjdk:8.

I rebuilt the project with Maven and OpenJDK 17 and things worked then. Perhaps the released jar is being built against an older SDK?

It's targeting 1.8, and the errors I had previously were using a server
with only JDK 17, which is the server I compiled it on (still targeting 1.8)
On Sat, 20 Nov 2021 at 7:57 PM, Nathan E. Lutterman <
@.***> wrote:

I rebuilt the project with Maven and OpenJDK 17 and things worked then.
Perhaps the released jar is being built against an older SDK?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/jagrosh/MusicBot/issues/913#issuecomment-974606058,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AF6BVMFLBYULRBJPXWN34ATUM5BF7ANCNFSM5EXISJTA
.

I have the same issue using the current release JMusicBot-0.3.6.jar. Alpine Linux 3.15 openjdk17 package hangs after "Loaded Config". openjdk16 package works.

This appears to be fixed with version 0.3.8

Cannot reproduce on Openjdk 18 on Ubuntu 22


Official Blessing

I respectfully request of the Postgres-XL maintainers that this Postgres-XL Docker project be 'officially blessed'. The project is approximately 2 years old, has 68 stars on GitHub, has 24 forks on GitHub, has 11 watchers on GitHub, has over 100K downloads on Docker Hub (more in previous versions), and is licensed under MIT. In addition, googling for Postgres-XL Docker leads me to a blog post for 2015 (https://www.postgres-xl.org/2015/01/docker-for-postgres-xl/), which lists a link for which DNS is not resolvable.
Although I created the project, I have officially transferred ownership to Pavouk OÜ, a company in Estonia which I am a director of, and which makes Isoxya, a Web Crawler & Data Processing System (https://www.pavouk.tech/). Pavouk donates resources and CI time to build the images, publishes the images to Docker Hub (https://hub.docker.com/u/pavouk0), maintains the code in GitHub (https://github.com/pavouk-0), and publishes announcements on its blog, as part of its commitment to open-source software, to contribute something back to the community.
I would make this request myself personally on the Postgres-XL mailing lists, but despite being reported more than once, those mailing lists (since their migration to the new host, a year or two ago), remain broken for me, since I use the excellent email host Posteo (https://posteo.de/en), who offers a setting to guarantee secure delivery of emails over encryption-through-transit. Since Postgres-XL's mailing list provider doesn't support such, my emails to the list are rejected, and I have ended up unsubscribing. In the early days, I subscribed and manually disabled the security each time when posting, but hopefully it's understandable that this isn't really sustainable (it takes me minutes for each post, signing in via 2FA, etc.). If Postgres-XL's mailing list provider fixed their hosting to be secure, I would happily resubscribe and contribute as before.
I would be grateful if either @sstubbs or @LamaAni would be willing to carry this request to Postgres-XL maintainers on my behalf, they having contributed various accepted patches to this project, over the past year, and to reference this GitHub issue in their request.
Peace, tiredpixel. :)

Hi, Any update on this?

Unfortunately no. I sent this http://lists.postgres-xl.org/pipermail/postgres-xl-bugs-postgres-xl.org/2020-January/000501.html but no reply. We've been using Postgres xl for some time and never needed support. 2nd quadrant do provide commercial support if needed but yes if people are going to be using Postgres xl for the first time I would definitely have a second think about it.

Yea, I agree. I have decided to put a warning on postgres-xl-helm.

I'm just wondering: is there any update on this? I'm guessing not. If not, we can close it, as there appears to be very little we can do… :(

Unfortunately not yes this can be closed. I'm am also sad that there is so little response.

Yes, it is disappointing. And by no means the first time, in my experience. I'll close. Thanks for trying; much appreciated.


Rendering latex in VSC Markdown cells

Placeholder issue for VSCode.

you can use $equation = (a+b)$ for in same line latex equation
or $$equation = (a+b)$$ to make eqution in center of new line
example :
$f(x) =\left{\begin{array}{ll}0  & \mbox{if } x = 0 \{1 \over x} & \mbox{if } x \neq 0\end{array}\right.$
Code:
$f(x) =
\left\{
	\begin{array}{ll}
		0  & \mbox{if } x = 0 \\
		{1 \over x} & \mbox{if } x \neq 0
	\end{array}
\right.$

@AbdelrahmanHamdy1996 Thanks, we're using this issue to track discussions with VS Code.

Any solution for this?

What is wrong

VS code (dark img) is not able to render the latex format in the markdown cell. Jupyter on the other hand can showcase the right formulas.

Try to but the second formula in the new line, not in the same line with sigma

Tried the following
Edit Markdown mode:

Output

the test loss standard deviation $\sigma_l$
$$n = (\frac{1.96 \sigma_l}{d})^2$$
try this

Unfortunately that does not work as well
edit markdown mode

output

You are connected with the internet

Try to connect with the internet and reload the vscode window, if still  have this issue submit a new issue

Try normal Jupyter editor in vscode no preview

Tried the normal editor, not preview and it works fine there.


TypeError: 'ValuesView' object does not support indexing

File "D:/daima/dc/dl/深度学习案例/convert_estimator_savedmodel.py", line 33, in main
signature_def.inputs.values()[0].name)

Thanks for reporting @xxllp . Are you using TensorFlow 2.0?

I use tensorflow 1.13 ，and   fix this by  use  [v.name for v in signature_def.inputs.values()]
but  can not understand  the  code
graph_editor.graph_replace  get the error

ValueError: Dtypes <dtype: 'string'> and <dtype: 'uint8'> are not compatible.


Revert "[BugFix] Fix tokenizer out of vocab size"

Reverts vllm-project/vllm#3685
This impacted the performance of vLLM.
this commit cause the L4 opt benchmark to drop performance
before: https://buildkite.com/vllm/ci/builds/3695
after: https://buildkite.com/vllm/ci/builds/3716
before
Avg latency: 0.446163778666687 seconds
Throughput: 21.25 requests/s, 10879.19 tokens/s
after
Avg latency: 4.369133323666698 seconds
Throughput: 0.93 requests/s, 474.10 tokens/s

Replaced by #3741


feat: Enable global expose with nested paths

Closes #2350
I tried to be as explicit as I could, I modified Mapping attribute to executable_relname (relative path but with no extension), and executable_name() is now evaluated based on relname.

@ruben-arts I tried to add an integration test.
I modified dummy-channel-1, to a add a nested executable.
I'm not sure about which directory is $PREFIX/bin is it the bin directory were pixi will store exposed executables?
Anyway, I added rattler-build dependency to pytest feature and ran pixi r update-integration-test-data but it failed:
│ ╭─ Running build script
 │ │ %SRC_DIR%>IF "" == "" (
 │ │
 │ │  call %SRC_DIR%\build_env.bat
 │ │ )
 │ │ La syntaxe de la commande n’est pas correcte.
 │ │ %SRC_DIR%>mkdir -p $PREFIX/bin
 │ │ %SRC_DIR%>echo "dummy_e on windows"  1>$PREFIX/bin/dummy_e.bat
 │ │ Le chemin d’accès spécifié est introuvable.
 │ │ × error Script failed with status 1
 │ │ × error Work directory: 'C:\Users\bahugo\dev\pixi\tests\integration\test_data\channels\dummy_channel_1\bld\rattler-build_dummy_e_1730147400\work'
 │ │ × error To debug the build, run it manually in the work directory (execute the `./conda_build.sh` or `conda_build.bat` script)
 │ │
 │ ╰─────────────────── (took 0 seconds)
 │
 ╰─────────────────── (took 0 seconds)
Error:   × Script failed

Traceback (most recent call last):
  File "C:\Users\bahugo\dev\pixi\tests\integration\test_data\update-channels.py", line 37, in <module>
    main()
  File "C:\Users\bahugo\dev\pixi\tests\integration\test_data\update-channels.py", line 18, in main
    subprocess.run(
  File "C:\Users\bahugo\dev\pixi\.pixi\envs\default\Lib\subprocess.py", line 571, in run
    raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command '['rattler-build', 'build', '--target-platform', 'win-64', '--output-dir', 'channels/dummy_channel_1', '--recipe', 'recipes/dummy_channel_1.yaml']' returned non-zero exit status 1.

I tried to run conda_build.bat but it failed too.
I'm not familiar with rattler-build, do you have an idea?

@ruben-arts I tried to add an integration test. I modified dummy-channel-1, to a add a nested executable. I'm not sure about which directory is $PREFIX/bin is it the bin directory were pixi will store exposed executables? Anyway, I added rattler-build dependency to pytest feature and ran pixi r update-integration-test-data but it failed:
│ ╭─ Running build script
 │ │ %SRC_DIR%>IF "" == "" (
 │ │
 │ │  call %SRC_DIR%\build_env.bat
 │ │ )
 │ │ La syntaxe de la commande n’est pas correcte.
 │ │ %SRC_DIR%>mkdir -p $PREFIX/bin
 │ │ %SRC_DIR%>echo "dummy_e on windows"  1>$PREFIX/bin/dummy_e.bat
 │ │ Le chemin d’accès spécifié est introuvable.
 │ │ × error Script failed with status 1
 │ │ × error Work directory: 'C:\Users\bahugo\dev\pixi\tests\integration\test_data\channels\dummy_channel_1\bld\rattler-build_dummy_e_1730147400\work'
 │ │ × error To debug the build, run it manually in the work directory (execute the `./conda_build.sh` or `conda_build.bat` script)
 │ │
 │ ╰─────────────────── (took 0 seconds)
 │
 ╰─────────────────── (took 0 seconds)
Error:   × Script failed

Traceback (most recent call last):
  File "C:\Users\bahugo\dev\pixi\tests\integration\test_data\update-channels.py", line 37, in <module>
    main()
  File "C:\Users\bahugo\dev\pixi\tests\integration\test_data\update-channels.py", line 18, in main
    subprocess.run(
  File "C:\Users\bahugo\dev\pixi\.pixi\envs\default\Lib\subprocess.py", line 571, in run
    raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command '['rattler-build', 'build', '--target-platform', 'win-64', '--output-dir', 'channels/dummy_channel_1', '--recipe', 'recipes/dummy_channel_1.yaml']' returned non-zero exit status 1.

I tried to run conda_build.bat but it failed too. I'm not familiar with rattler-build, do you have an idea?

@ruben-arts I've managed to update integration test channel by compiling them use debian in wsl.
I ran integration tests on windows, the test I added ran successfully, but I got a fail for another test:
E           AssertionError: Return code was 106, expected 0, stderr: No pyvenv.cfg file

tests\integration\common.py:55: AssertionError

I don't get why it failed.

While reviewing I checked it out and did some small changes, here is the diff patch you could apply:

ff

Something is not working with python activation in integration test, I don't know why...
  Windows 10.0.26100 on D049 on  main +/- is 📦 v0.34.0 🦀 v1.81.0
~\dev\pixi ➜ C:\Users\bahugo\dev\pixi\pytest-temp\popen-gw0\test_sync_dependencies0\bin\python-injected.bat --version
> No pyvenv.cfg file

  Windows 10.0.26100 on D049 on  main +/- is 📦 v0.34.0 🦀 v1.81.0
~\dev\pixi ❯ C:\Users\bahugo\dev\pixi\pytest-temp\popen-gw0\test_sync_dependencies0\envs\test\Lib\venv\scripts\nt\python.exe
> No pyvenv.cfg file

I'll give this a go today! See if I can fix the issues

I'm sorry you are experiencing such a crazy merge conflict train. The code works well, I hope you have another example we can use in the documentation.

If fixed the merge issue, and tested some more.
Your implementation allows to use the following command on both platforms:
pixi global install pyside6 --expose qmlls=qt6/bin/qmlls

However it doesn't run anything on my machine. I'm fine with skipping an useful example as I'm assuming its not a big set of users hitting this. And other wise we'll find a example through that.

There is still an issue with this logic, the pixi global install python now exposes a  different version of python.exe as there are two in the whole binary. We need to get rid of the nested logic if the expose name is not a path like object.

There is still an issue with this logic, the pixi global install python now exposes a different version of python.exe as there are two in the whole binary. We need to get rid of the nested logic if the expose name is not a path like object.

@ruben-arts I don't think that nested path is the reason why it fails for python on windows.
In global/mod.rs I've changed executable search to find every executables like in every folder to be able to expose them if needed.
I think I must add a filter for cases where 2 executables where found, in those cases I must keep the one located in one of those folders :
let binary_folders = if cfg!(windows) {
        &([
            "",
            "Library/mingw-w64/bin/",
            "Library/usr/bin/",
            "Library/bin/",
            "Scripts/",
            "bin/",
        ][..])
    } else {
        &(["bin"][..])
    };

I'll give it a try tomorrow.

@ruben-arts @Hofer-Julian it's finally working!


Update configuration.rst

edit a mis-spelling word

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?


Pictures aren't there where they should be (swapped)

Book:<PHONE_NUMBER>050
Easy to see in Appendix A
that a lot of pictures aren't there where they should be (swapped).
As some of formulars are also pictures, this applies also to a lot of formulars ...
Greetings
Michael

remark: a lot of pictures are used several times in this book - does the failure has something to do with that???


Fix ODR-800: RackHD Redfish v1 - bad link returned in /redfish/v1/Sys…

…tems//LogServices/SEL/Entries/NN

:+1:


Add timezone to PDF's default timestamp.

Fixes #3948, let the date metadata of the pdf include timezone information if the date is not specified (or auto) in #set document.
Thanks the previous attempt #4636 on this issues, and this pr is inspired from it.
The timezone
Similar to #4636, and in summary, it will be:

Respect document.date, either a datetime(...) or none.
If document.date is auto (the default value),

if the --creation-timestamp is set in CLI, the timezone will be set to UTC;
else, the current time will be used, and the timezone will be set to local.

Else, the date metadata will not be written.

Testing
Similar to #4636.
(1) #set document(date: none)
// test.typ
#set document(date: none)
PDF

strings test.pdf | grep Date shows nothing.
(2) #set document(date: datetime(...))
// test.typ
#set document(date: datetime(year: 2020, month: 1, day: 1))
PDF

strings test.pdf | grep Date shows

(3) Default with --creation-timestamp (To ensure compilation reproducibility)
// test.typ
PDF

strings test.pdf | grep Date shows

(4) Default without --creation-timestamp(Assume the tz is UTC+8)
// test.typ
PDF

strings test.pdf | grep Date shows

The core typst crates should never interact with the environment directly. They are pure libraries without OS interaction. As such, reading the timezone in typst-pdf is problematic.
This may sound contrary to my previous statement in #4636 that I'm concerned about moving the logic to typst-cli. But what I want is basically to have the logic itself in typst-pdf, but the timezone reading itself in typst-cli.

Thank your reply! I am refactoring the code to meet your requirement now.
About another detail, the #4636 make the UNIX timestamp provided through the CLI command to be shown in UTC. And I am not sure about whether this is necessary.

The core typst crates should never interact with the environment directly. They are pure libraries without OS interaction. As such, reading the timezone in typst-pdf is problematic.
This may sound contrary to my previous statement in #4636 that I'm concerned about moving the logic to typst-cli. But what I want is basically to have the logic itself in typst-pdf, but the timezone reading itself in typst-cli.

Thanks for your reply! I have refactored the code to try to meet your requirement. Can you please review it again?

Given the conversion complexity with negatives, I think it'd be good to have some unit tests for Timezone::from_local

Thanks, the code looks very good now!

Thanks, the code looks very good now!

Thanks your advice, I learned a lot for it! ❤


Add OverlayLayout

Does the following:

Adds an OverlayLayout for stacking views on top of each other
Creates comprehensive tests for layout and configuration of overlay layouts
Adds a new page to the sample app with many overlay layouts so users can see its support

Codecov Report

Merging #127 into master will increase coverage by 0.28%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #127      +/-   ##
==========================================
+ Coverage   92.38%   92.67%   +0.28%
==========================================
  Files          58       60       +2
  Lines        3311     3467     +156
==========================================
+ Hits         3059     3213     +154
- Misses        252      254       +2

Impacted Files
Coverage Δ

LayoutKitTests/OverlayLayoutTests.swift
100% <100%> (ø)

LayoutKit/Layouts/OverlayLayout.swift
100% <100%> (ø)

LayoutKit/Views/ReloadableViewLayoutAdapter.swift
83.15% <0%> (-2.11%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c73a960...1b752d5. Read the comment docs.

Do you think if that is useful to add tests to check the order primary, background and overlay?

Great - did a final touch for all points brought up. Ready to be merged if all set.

Thank you for adding this, @dgattey !


cmd/cgo: cannot convert from type *_Ctype_char to type _Ctype_HANDLE (1.18 regression)

This code compiled on Windows with Go 1.17, but not with Go 1.18:
package p

/*
#include <windows.h>
*/
import "C"

func Error() {
	var x *C.char
	_ = C.HLOCAL(x)
}

The error message is:

p.go:10:15: cannot convert x (variable of type *_Ctype_char) to type _Ctype_HANDLE

Reverting 635e49388bf746a2b8c7ab1e9026aede0eb88b31 allows the code to compile again.
cc @eliasnaur @randall77 @dsnet @bradfitz

@josharian is this a problem in tip too? (I assume it is). If that's the case, this issue should be put in the 1.19 milestone, and the backport issue that you can ask gopherbot to open will be the one in the 1.18.1 milestone.

@ALTree oh right. thanks.
@gopherbot please open a backport issue for Go 1.18. This is a compilation regression.

(This bug was minimized from https://github.com/cyolosecurity/certstore/blob/main/certstore_windows.go#L666)
/cc @ianlancetaylor

CL 350070 is based on the valid observation that although the type of Windows HANDLE is void*, the values stored in variables of type HANDLE are normally not pointers.  Since Go's GC really wants to know whether something is a pointer or not, telling it that values of type HANDLE are not pointers seems like the right move in general.
Now, perhaps it's true that HLOCAL values happen to be pointers to memory.  As far as I can tell the correct way to get an HLOCAL value is to call LocalHandle; I guess that's a pointer to memory?  And it appears that new code is supposed to call HeapAlloc which doesn't have this problem.
Anyhow, if we are expected to convert Go pointers to HLOCAL and thus to HANDLE, we are in trouble, because now a HANDLE is sometimes a pointer to memory and sometimes not.
I don't see a problem with the code in cyolosecurity, and the code can easily be changed to compile by writing
	defer C.LocalFree(C.HLOCAL(unsafe.Pointer(cmsg)))

So it seems to me that the Go 1.18 behavior is safer and code that plays fast and loose with pointers should be adjusted.  (Note that the Go 1 compatibility guarantee does not apply to cgo code.)
Of course it would be better if that code could continue to work, and I'm certainly open to suggestions.

I'll offer a bit more context here:
The LocalAlloc, LocalFree, GlobalAlloc, GlobalFree and their other adjacent APIs are holdovers from 16-bit Windows. In those days, when we allocated heap memory, those functions would truly return a handle. The programmer would have to then call LocalLock or GlobalLock to convert that handle into a pointer, and then call LocalFree or GlobalFree when done accessing the memory.
Nowadays, for better or worse, the HLOCAL handle is frequently treated as synonymous with the pointer. HGLOBALs often are as well (though my personal preference is not to do so).
In general, I'd suggest that the best rule of thumb is to avoid allocating memory using those functions unless other APIs involved specifically require it -- eg the Win32 clipboard APIs expect to work with HGLOBALs. If some some reason a block of memory must absolutely be allocated via the Windows heap, HeapAlloc should be the default API choice.

@dblohm7 Thanks.
It looks like the code that led to this issue is calling FormatMessage with the FORMAT_MESSAGE_ALLOCATE_BUFFER which does indeed allocate memory using LocalAlloc.  It's then casually converting that memory to char*, which I guess is fine today but it should really be calling LocalLock, and should really be passing the original value to LocalFree.
So I think there is a plausible argument that the code in question is technically incorrect and this change caught the error.

OK, sounds like this working as intended. Thanks, @ianlancetaylor and @dblohm7.

Thanks, closing this issue as there currently doesn't seem to be anything to change in the Go tools.  Please comment if you disagree.


Grammatical Errors

Reading through this as I work on my own solution and found several grammar errors

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@jeffpatton1971 : Thanks for your contribution to the Azure documentation! The author, @bwren, has been notified to review your proposed change.

@jeffpatton1971 All looks good.  Thanks for this.

#signoff


python3Packages.build: ignore DeprecationWarning

Motivation for this change
Fix build (https://hydra.nixos.org/build/164508712)
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 155302 run on x86_64-linux 1

1 package failed to build:

python310Packages.check-manifest

4 packages built:

devpi-client
python310Packages.build
python39Packages.build
python39Packages.check-manifest

gevent and gpgme are still open to fix for Python 3.10.


ikea switch/button requiers a home hab to be used with the home app

Hello,
i have a lot of devices, only the ikea switch E1743 and ikea button E1812 are giving me the info in the homebridge that it is required a home hub to be used with the home app.
kind regards,
martin

What is the actually issue here?

I can't control these devices, they are not shown as switch

Can you provide the information requested in the Bug Report issue template?
Perhaps the answers to those questions will make it more clear to me.


Meta data scrambled when requesting meta data from a sequence of files

When requesting meta data for a list of files the meta data gets mixed up.
The MetaDataRetriever quite often returns the same meta data twice or thrice or scrambles together a completly new set of meta data.
A quick fix but dirty fix is delaying each meta data request by a 100ms.

Hi there @ton-An !
Are you retrieving metadata asynchronously (I mean two or more files at the same time)?
I'm using this plugin in my app, here & it works well.
I'm asking for the metadata one at a time.
Although, I accept my fault, that it should be fixed.
Thanks for the report!

Ahh, that solved it.
I was scanning the storage with the stream from directory.list and then immedeatly requesting meta data for the files. Making that operation synchronous worked

Any updates about this or a workaround

This was actually a design problem, refactored code & changed API a bit. Fixed, calls are now multithread friendly.


SCB-317 Prepare the release for Service-Center-1.0.0-m1

(cherry picked from commit b16e646)
Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Make sure there is a JIRA issue filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
[ ] Each commit in the pull request should have a meaningful subject line and body.
[ ] Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
[ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Run go build go test go fmt go vet to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

Codecov Report

Merging #269 into master will increase coverage by 0.16%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #269      +/-   ##
==========================================
+ Coverage   70.17%   70.33%   +0.16%
==========================================
  Files          17       17
  Lines        3470     3418      -52
==========================================
- Hits         2435     2404      -31
+ Misses        864      846      -18
+ Partials      171      168       -3

Impacted Files
Coverage Δ

server/service/microservices.go
74.45% <ø> (+0.39%)
:arrow_up:

server/service/util/dependency.go
57.58% <ø> (+0.41%)
:arrow_up:

server/service/util/microservice_util.go
74.84% <0%> (-1.73%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6b0b3a...e34c978. Read the comment docs.

Coverage increased (+0.2%) to 73.895% when pulling e34c978bf5fc57fcfc4ebd840fe050ecf7e52c13 on little-cui:master into d6b0b3ac55ae0ad3cd35525c7cf6a42ff9ad54ad on apache:master.


[BP-1.18][FLINK-34360][ci] Adds cleanup to job_init action

1.18 backport PR of parent PR #24277

parent PR was approved. Diff is the same. Merging w/o additional approval


snapscraft builds

this is an awesome project.
Could you have a look at implementing snap based builds. These are for ubuntu but other linux distros are also either suppoting them, or starting to support them.
This explains it all.
https://github.com/syncthing/syncthing/pull/3636
In here you can see their project go build script that calls to make a snapscraft build.
https://github.com/syncthing/syncthing/blob/master/build.go
Really curiosu what you think..

totally agree with you.
Note that snap is not the only new packer for linux. Gnome is pushing its on new one too, flatpack.
At the time i worked on that project i could not find enough resources to jump into it.

something that may be useful is to try to start a common group about those questions. I think they are yet several solutions to provide an installer to various os, but they are not coordinated.

i agree this is the problem. I guess i was seeing what your up to and thinking "hey here is all the bits to do it in this git org :) ".
But heres an approach:
I think the best place for this is over at Gallium. Because its a pure golang based alternative to Electron - no nodejs needed. For all application bundling, updating, etc we make a seperate repo called "gallium-pack". Gallium can use it but also anyone else. I can ask the org maintainer.

I can only tell that you seem very enthusiast about gallium (i agree about that),
I d want just to point that go has the ability to build

qt app (and some other various bindings to gui toolkits)
mobile apps
cli app
web app

IMVHU, such gallium-pack command, ideally, is a wrapper which applies gallium conventions&configuration to a series of per-target tool which will realize the desired packing.
Maybe gallium is the definitive solution that will simplify the problem of desktop applications at once, in which case doing a specific worth to be done, maybe its just a solution among many other, in which case a more agnostic solution may be more valuable to everyone. Where are you heading to ?

Hey again,
Yes i agree with you about go being able to build QT, mobile, CLI and web. Its exactly what i am working on making much more standardised. Gallium is just what i am using fro Desktop.
Regarding your idea for a place to put all this together, THIS repo is a very nice place to document it as you have done already with a link to all the toosl that do a specific thing.
I have started working on an Update system for Apps deployed to Servers and Desktops.
I have also started working on a Cloud based development environment.
I just send you an email about it :)

ok ill check this out asap.

https://snapcraft.io/create/
https://github.com/snapcore/snapd

https://github.com/goreleaser/goreleaser#snapcraft-build-customization


Add django-rest-framework

We need to add a skeleton for our various models, as well as adding django-rest-framework and setting it up.

Ready for review.

Two minor questions. Looks good!

:+1:


Add settings for the size of activity bar

Add an option to set the size (width) of the activity bar. This stackoverflow question shows that people do want this feature: https://stackoverflow.com/questions/45048214/activity-bar-width-in-visual-studio-code

@daviddossett I think miguel had an issue for this but possibly more spacious vs compact focused

Correct—this will most likely manifest as a setting related to the overall density of VS Code e.g. Comfortable | Compact but that is still under discussion.

I think it's unlikely that we would enable a version where we're going even smaller than today. However you can toggle the activity bar's visibility like so:

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

Closing as this will be explored as part of a density setting for the workbench all up. See https://github.com/microsoft/vscode/issues/115641 for some of the first ideas here. I'll create a new issue for this specifically soon.


[Bug] Cyclical dependency in the action config

Description
Saw cyclical dependency error with the node being in the action config.
Steps to reproduce the behaviour:

TODO

Important Details

Version: Prod
Plugin: Firebase

@hetunandu please add the impact / effort and get these cyclic issues closed

@hetunandu please add the impact / effort and get these cyclic issues closed

Fixed with #3259


Format: fix to place only a newline between call-comment-newline and def

Fixed #4672

Here come the fomratter master 🎉 @MakeNowJust


[🐛] Missing files in release archives

There are missing files in release archives. This is causing weird installation issues but the root cause is missing files.
Download this: https://github.com/bkimminich/juice-shop/releases/download/v12.8.1/juice-shop-12.8.1_node12_linux_x64.tgz
Extract and compare with repo:
For instance the frontend/ directory is missing package.json etc. in the tgz.

The packaged archives only contain what is needed to start to application with npm start. The frontend is already precompiled in there under /frontend/dist. You cannot develop based on the archived packages or run test suites or similar. For that you need the "full version" from GitHub source.

Thank you for that clarification! JuiceShop is awesome. Thank you so much. I'm helping to host a CTF again for high school students. JuiceShop has been a key piece these last couple of years for the CTF. Thank you!


chore: cleanup after release

So, what's the reason for this? Is this for better DX (local development) and/or isolation in CI?

@aidan-casey told me not to use self.version 🫣

Yeah, self.version shouldn't be used. I had an explanation for everything in a previous issue. Will see if I can dig it up or put down my thoughts later.

Okay, so long story short, there are a couple problems with self.version:

self.version resolves to the commit hash in CI which causes a slew of CI problems when testing Tempest as extensively as we are.
self.version is exact there is no room for different package versions within the same major version. Given the monorepo, this primarily comes into play when a third-party package requires a specific version. For example: Tempest requires self.version, the project uses 1.1.1 therefore, that resolves to 1.1.1. A third-party package is installed that requires ^1.1.2. This will fail since self.version is used and exact.

I'm not opposed to better ways here, but I don't think self.version is it.


Editing a post edited previously using steemit.com gives a blank post body

Expected behavior

After editing via any Steem client, a post's text, code and formatting should be editable and shown when the edit button is pressed.
Actual behavior

The post body content box is empty when attempting to edit.

How to reproduce

I posted this via busy.org first: https://busy.org/steem/@pfunk/arguments-for-keeping-the-steem-reward-pool-whole
I was not able to use certain formatting features with the busy editor, and also did not like the way Busy formatted spaces between paragraphs. So I edited the post using steemit.com. Attempting to edit it on Busy again reveals the bug.

Browser: Firefox 52.0.1

Related to https://github.com/adcpm/busy/issues/457

This issue has been solved in #729 on new-design branch


impl multiplication for polyval

Closes #25.
Basing multiplication of the RustCrytpo software implementation. This PR is about halfway finished, implements bmul64, and most of the main galois mul subroutine.
Still need to:

[ ] create a test vector (and hope for the bit-twiddling best)
[x] impl 64-bit overflowing multiplication
[x] finish the last chunk in mul

there's a broken test I wrote that isn't actually supposed to pass (and i have no test vectors for it yet; I might generate some from rust-crypto), but triggers circom's compiler errors, which has been useful (if painful).

All gfmul tests should be logically passing, but I'm having issues getting circomkit to correctly recognize the out[2][64] outputs, seems to only be capturing 64 of the 128 bits, causing these tests to fail.
Only thing left blocking this PR is figuring out that circomkit quirk and we're flying.
@Autoparallel @0xJepsen would you take a look?


Adding style to navbar

Is your feature request related to a problem? Please describe.
Describe the solution you'd like
A clear and concise description of what you want to happen.
Screenshots

@priyanshu070702 Go ahead
Show your support by stargazing the repo 🌟

@priyanshu070702 If you want to work again on this issue, 2 days will be given.
Plz finish the task.

@priyanshu070702 Due to inactivity this issue will be closed.